0803613c91691444fa8172e99fcf6da514c0f0f0
[WebKit-https.git] / WebCore / ChangeLog
1 2006-11-02  Simon Hausmann  <hausmann@kde.org>
2
3         Reviewed by Maciej, landed by Anders
4
5         * CMakeLists.txt: Make linkage against KDE libraries conditional
6         * platform/network/qt/ResourceHandleManager.cpp: Added a simple
7           Qt base resource handler that supports only requests to the
8           local filesystem. Used when compiling without KDE support.
9           ResourceHandleManager.cpp/h are to be split up into ResourceHandleManagerKDE
10           and ResourceHandleManagerQt in the future, as well as QtJob.cpp/h.
11         (WebCore::QtJob::QtJob):
12         (WebCore::QtJob::timerEvent):
13         (WebCore::ResourceHandleManager::ResourceHandleManager):
14         (WebCore::ResourceHandleManager::~ResourceHandleManager):
15         (WebCore::ResourceHandleManager::self):
16         (WebCore::ResourceHandleManager::remove):
17         (WebCore::ResourceHandleManager::add):
18         (WebCore::ResourceHandleManager::cancel):
19         (WebCore::ResourceHandleManager::deliverJobData):
20         * platform/network/qt/ResourceHandleManager.h:
21         * platform/qt/FrameQtClient.cpp:
22         (WebCore::FrameQtClientDefault::runJavaScriptAlert):
23         (WebCore::FrameQtClientDefault::runJavaScriptConfirm):
24         (WebCore::FrameQtClientDefault::runJavaScriptPrompt):
25         * platform/qt/LoaderFunctionsQt.cpp: Use the Qt messagebox and
26           input dialog functions when compiling without KDE support
27         (WebCore::ServeSynchronousRequest):
28
29 2006-11-02  David Carson  <dacarson@gmail.com>
30
31         Reviewed by Geoff, landed by Anders.
32
33         Fix for: http://bugs.webkit.org/show_bug.cgi?id=11471
34         Initializing variable in constructor.
35
36         * page/FramePrivate.h:
37         (WebCore::FramePrivate::FramePrivate):
38
39 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
40
41         Reviewed by Geoff.
42
43         Use CFMutableURLRequestRef instead of CFHTTPMessageRef since not all URL requests are http requests.
44         
45         * platform/network/cf/ResourceHandleCFNet.cpp:
46         (WebCore::addHeadersFromHashMap):
47         Don't set all headers at once since that clears any previous headers set.
48         
49         (WebCore::ResourceHandle::start):
50
51 2006-11-02  Adele Peterson  <adele@apple.com>
52
53         Reviewed by Mitz and Geoff.
54
55         - Fix for:
56         <rdar://problem/4650271> REGRESSION(NativeTextArea): Textareas don't get scrollbars when text gets too big for content area (10105)
57         <rdar://problem/4650813> REGRESSION(tiger-leopard): typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)
58         <rdar://problem/4658779> REGRESSION: Text selection is weird in textareas in Trac wiki editing pages
59
60         Test: fast/forms/textarea-scrollbar.html
61
62         To avoid some of our flexbox bugs for textareas, we're moving the text controls back to RenderBlock.  This should make them
63         a lot more stable.  In the future, when we've worked out more of the flexbox kinks, we may want to consider moving them back.
64
65         * rendering/RenderTextControl.h: Convert text controls back to RenderBlock instead of RenderFlexibleBox.
66         * rendering/RenderTextControl.cpp: 
67         (WebCore::RenderTextControl::RenderTextControl):
68         (WebCore::RenderTextControl::setStyle):
69         (WebCore::RenderTextControl::createDivStyle):
70         (WebCore::RenderTextControl::updateFromElement):
71         (WebCore::RenderTextControl::calcHeight):
72         (WebCore::RenderTextControl::baselinePosition):
73         (WebCore::RenderTextControl::nodeAtPoint):
74         (WebCore::RenderTextControl::layout): Set the inner div's height explicitly before doing a normal layout.
75         (WebCore::RenderTextControl::scrollWidth):
76         (WebCore::RenderTextControl::scrollHeight):
77         (WebCore::RenderTextControl::scrollLeft):
78         (WebCore::RenderTextControl::scrollTop):
79
80         * rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): Make subtree layout optimization work for textareas.
81
82 2006-11-02  John Sullivan  <sullivan@apple.com>
83
84         Reviewed by Geoff Garen
85
86         * editing/Selection.cpp:
87         (WebCore::Selection::showTreeForThis):
88         this debugging method now displays start offset and end offset, at Darin's suggestion
89
90 2006-11-01  Justin Garcia  <justin.garcia@apple.com>
91
92         Reviewed by darin
93
94         <rdar://problem/4062865>
95         Copy/paste of a select element fails to include the options
96         
97         * editing/SelectionController.cpp:
98         (WebCore::SelectionController::modify): Added paragraphBoundary.
99         * editing/htmlediting.cpp:
100         (WebCore::canHaveChildrenForEditing): Added checks for input elements
101         and textareas.  Insertion operations would fail when performed just 
102         before/after one of these elements b/c the content would be put inside 
103         the element.
104         (WebCore::enclosingNodeWithTag): Fixed a problem when calling these in non
105         editable content, and made the code to stop at an root faster (don't check
106         isDescendantOf on every iteration).
107         (WebCore::enclosingNodeOfType): Ditto.
108         (WebCore::enclosingList): Ditto.
109         (WebCore::enclosingListChild): Ditto.  Added a FIXME, this function seems
110         inappropriately named.
111         * editing/markup.cpp:
112         (WebCore::startMarkup): Use the text node's value instead of its rendered
113         content for text nodes inside select elements.  One might also turn off
114         annotation when createMarkup enters a select element, but createMarkup
115         is iterative, not recursive, so doing so would be complicated.
116         (WebCore::createMarkup): Add markup for unrendered nodes if they are 
117         descendants of a select element.
118         * editing/visible_units.cpp:
119         (WebCore::startOfParagraph): Migrate to isBlock/enclosingBlock.  Fixes bug
120         where various replaced elements can't be copied when they are the only
121         thing selected.
122         (WebCore::endOfParagraph): Ditto.
123
124 2006-11-01  Oliver Hunt  <oliver@apple.com>
125
126         Reviewed by Adam.
127
128         Converting more or kcanvas/quartz from Obj-C to C++
129         Minor SVG updates
130         compatibility fixes
131
132         * WebCore.xcodeproj/project.pbxproj:
133         * kcanvas/device/KRenderingPaintServer.h:
134         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.cpp: Added.
135         (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
136         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: Removed.
137         * kcanvas/device/quartz/KRenderingPaintServerQuartz.cpp: Added.
138         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: Removed.
139         * kcanvas/device/quartz/QuartzSupport.h:
140         * ksvg2/css/SVGCSSStyleSelector.cpp:
141         * ksvg2/misc/KCanvasRenderingStyle.h:
142         * ksvg2/scripts/cssmakeprops:
143         * ksvg2/scripts/cssmakevalues:
144         * ksvg2/scripts/make_names.pl:
145         * ksvg2/svg/SVGAnimateColorElement.cpp:
146         * ksvg2/svg/SVGAnimateTransformElement.cpp:
147         * ksvg2/svg/SVGAnimationElement.cpp:
148         * ksvg2/svg/SVGMaskElement.cpp:
149         * ksvg2/svg/SVGPatternElement.cpp:
150         * ksvg2/svg/svgpathparser.cpp:
151         * platform/Path.cpp:
152         * platform/graphics/svg/SVGResourceImage.h:
153         * rendering/RenderPath.cpp:
154         * rendering/SVGRenderAsText.cpp:
155
156 2006-11-02  Mitz Pettel  <mitz@webkit.org>
157
158         Reviewed by Adele.
159
160         - Fix a regression from r17521: painting of and crash caused by tables
161           with collapsed borders
162
163         * rendering/RenderTable.cpp:
164         (WebCore::RenderTable::paint): Changed 'paintInfo' to 'info'. Prior to
165         r17521, 'paintInfo' was the local variable. Now 'info' is the local variable
166         and 'paintInfo' is the parameter, which we were accidently modifying.
167
168 2006-11-01  Adele Peterson  <adele@apple.com>
169
170         Reviewed by Mitz.
171
172         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11277
173         REGRESSION: Incomplete repaint of overflow areas when deleting
174
175         Restrict the repaint rect for overflow blocks after the height has been fully computed.
176         Also, adjust the repaint rect coordinates for the scroll offset.
177
178         * rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
179         * rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
180
181 2006-11-01  Sam Weinig  <sam.weinig@gmail.com>
182
183         Reviewed by Mitz.
184
185         Fix for http://bugs.webkit.org/show_bug.cgi?id=11474
186         Rename the "p" member variable of the PaintInfo struct to "context"
187
188         - Renames the 'p' and 'r' member variables of the PaintInfo struct to
189           'context' and 'rect' respectively.
190
191         - Assorted surrounding cleanups.
192
193         * rendering/EllipsisBox.cpp:
194         (WebCore::EllipsisBox::paint):
195         * rendering/EllipsisBox.h:
196         * rendering/InlineBox.cpp:
197         (WebCore::InlineBox::paint):
198         * rendering/InlineFlowBox.cpp:
199         (WebCore::InlineFlowBox::paint):
200         (WebCore::InlineFlowBox::paintBackground):
201         (WebCore::InlineFlowBox::paintBackgroundAndBorder):
202         (WebCore::InlineFlowBox::paintDecorations):
203         * rendering/InlineFlowBox.h:
204         * rendering/InlineRunBox.h:
205         * rendering/InlineTextBox.cpp:
206         (WebCore::InlineTextBox::paint):
207         * rendering/InlineTextBox.h:
208         * rendering/RenderBlock.cpp:
209         (WebCore::RenderBlock::paint):
210         (WebCore::RenderBlock::paintChildren):
211         (WebCore::RenderBlock::paintCaret):
212         (WebCore::RenderBlock::paintObject):
213         (WebCore::RenderBlock::paintFloats):
214         (WebCore::RenderBlock::paintEllipsisBoxes):
215         (WebCore::RenderBlock::paintSelection):
216         (WebCore::RenderBlock::fillSelectionGaps):
217         (WebCore::RenderBlock::fillInlineSelectionGaps):
218         (WebCore::RenderBlock::fillBlockSelectionGaps):
219         (WebCore::RenderBlock::fillHorizontalSelectionGap):
220         (WebCore::RenderBlock::fillVerticalSelectionGap):
221         (WebCore::RenderBlock::fillLeftSelectionGap):
222         (WebCore::RenderBlock::fillRightSelectionGap):
223         * rendering/RenderBox.cpp:
224         (WebCore::RenderBox::paint):
225         (WebCore::RenderBox::paintRootBoxDecorations):
226         (WebCore::RenderBox::paintBoxDecorations):
227         * rendering/RenderBox.h:
228         * rendering/RenderButton.cpp:
229         (WebCore::RenderButton::paintObject):
230         * rendering/RenderFieldset.cpp:
231         (WebCore::RenderFieldset::paintBoxDecorations):
232         * rendering/RenderFileUploadControl.cpp:
233         (WebCore::RenderFileUploadControl::paintObject):
234         * rendering/RenderFlow.cpp:
235         (WebCore::RenderFlow::continuationBefore):
236         (WebCore::RenderFlow::addChildWithContinuation):
237         (WebCore::RenderFlow::addChild):
238         (WebCore::RenderFlow::attachLineBox):
239         (WebCore::RenderFlow::destroy):
240         (WebCore::RenderFlow::dirtyLinesFromChangedChild):
241         (WebCore::RenderFlow::dirtyLineBoxes):
242         (WebCore::RenderFlow::createInlineBox):
243         (WebCore::RenderFlow::paintLines):
244         (WebCore::RenderFlow::getAbsoluteRepaintRect):
245         (WebCore::RenderFlow::lowestPosition):
246         (WebCore::RenderFlow::rightmostPosition):
247         (WebCore::RenderFlow::leftmostPosition):
248         (WebCore::RenderFlow::caretRect):
249         (WebCore::RenderFlow::addFocusRingRects):
250         (WebCore::RenderFlow::paintOutline):
251         (WebCore::RenderFlow::paintOutlineForLine):
252         * rendering/RenderForeignObject.cpp:
253         (WebCore::RenderForeignObject::paint):
254         * rendering/RenderHTMLCanvas.cpp:
255         (WebCore::RenderHTMLCanvas::paint):
256         * rendering/RenderImage.cpp:
257         (WebCore::RenderImage::paint):
258         * rendering/RenderLayer.cpp:
259         (WebCore::RenderLayer::paintLayer):
260         * rendering/RenderListBox.cpp:
261         (WebCore::RenderListBox::paintObject):
262         (WebCore::RenderListBox::paintScrollbar):
263         (WebCore::RenderListBox::paintItemForeground):
264         (WebCore::RenderListBox::paintItemBackground):
265         * rendering/RenderListMarker.cpp:
266         (WebCore::RenderListMarker::paint):
267         * rendering/RenderMenuList.cpp:
268         (WebCore::RenderMenuList::paintObject):
269         * rendering/RenderObject.cpp:
270         (WebCore::RenderObject::paint):
271         * rendering/RenderObject.h:
272         (WebCore::RenderObject::PaintInfo::PaintInfo):
273         (WebCore::RenderObject::paintBoxDecorations):
274         (WebCore::RenderObject::paintingRootForChildren):
275         (WebCore::RenderObject::shouldPaintWithinRoot):
276         (WebCore::RenderObject::printBoxDecorations):
277         * rendering/RenderPath.cpp:
278         (WebCore::RenderPath::paint):
279         * rendering/RenderReplaced.cpp:
280         (WebCore::RenderReplaced::shouldPaint):
281         * rendering/RenderSVGContainer.cpp:
282         (WebCore::RenderSVGContainer::paint):
283         * rendering/RenderSVGContainer.h:
284         * rendering/RenderSVGImage.cpp:
285         (WebCore::RenderSVGImage::paint):
286         * rendering/RenderSVGText.cpp:
287         (WebCore::RenderSVGText::paint):
288         * rendering/RenderSVGText.h:
289         (WebCore::RenderSVGText::renderName):
290         * rendering/RenderTable.cpp:
291         (WebCore::RenderTable::paint):
292         (WebCore::RenderTable::paintBoxDecorations):
293         * rendering/RenderTable.h:
294         * rendering/RenderTableCell.cpp:
295         (WebCore::RenderTableCell::paint):
296         (WebCore::RenderTableCell::paintBackgroundsBehindCell):
297         (WebCore::RenderTableCell::paintBoxDecorations):
298         * rendering/RenderTableCell.h:
299         * rendering/RenderTableRow.cpp:
300         (WebCore::RenderTableRow::paint):
301         * rendering/RenderTableRow.h:
302         * rendering/RenderTableSection.cpp:
303         (WebCore::RenderTableSection::paint):
304         * rendering/RenderTableSection.h:
305         (WebCore::RenderTableSection::getBaseline):
306         (WebCore::RenderTableSection::setNeedCellRecalc):
307         * rendering/RenderText.h:
308         (WebCore::RenderText::renderName):
309         (WebCore::RenderText::paint):
310         (WebCore::RenderText::element):
311         * rendering/RenderTheme.cpp:
312         (WebCore::RenderTheme::paint):
313         (WebCore::RenderTheme::paintBorderOnly):
314         (WebCore::RenderTheme::paintDecorations):
315         * rendering/RenderTheme.h:
316         (WebCore::RenderTheme::RenderTheme):
317         (WebCore::RenderTheme::~RenderTheme):
318         (WebCore::RenderTheme::controlSupportsTints):
319         (WebCore::RenderTheme::adjustRepaintRect):
320         (WebCore::RenderTheme::themeChanged):
321         (WebCore::RenderTheme::supportsHover):
322         (WebCore::RenderTheme::paintCheckbox):
323         (WebCore::RenderTheme::setCheckboxSize):
324         (WebCore::RenderTheme::paintRadio):
325         (WebCore::RenderTheme::setRadioSize):
326         (WebCore::RenderTheme::paintButton):
327         (WebCore::RenderTheme::setButtonSize):
328         (WebCore::RenderTheme::paintTextField):
329         (WebCore::RenderTheme::paintTextArea):
330         (WebCore::RenderTheme::paintMenuList):
331         (WebCore::RenderTheme::paintMenuListButton):
332         * rendering/RenderThemeMac.mm:
333         (WebCore::RenderThemeMac::paintCheckbox):
334         (WebCore::RenderThemeMac::paintRadio):
335         (WebCore::RenderThemeMac::paintButton):
336         (WebCore::RenderThemeMac::paintTextField):
337         (WebCore::RenderThemeMac::paintTextArea):
338         (WebCore::RenderThemeMac::paintMenuList):
339         (WebCore::RenderThemeMac::paintMenuListButtonGradients):
340         (WebCore::RenderThemeMac::paintMenuListButton):
341         * rendering/RenderView.cpp:
342         (WebCore::RenderView::paint):
343         (WebCore::RenderView::paintBoxDecorations):
344         * rendering/RenderView.h:
345         * rendering/RenderWidget.cpp:
346         (WebCore::RenderWidget::paint):
347         * rendering/RenderWidget.h:
348         (WebCore::RenderWidget::isWidget):
349         * rendering/RootInlineBox.cpp:
350         (WebCore::RootInlineBox::paintEllipsisBox):
351         (WebCore::RootInlineBox::paintCustomHighlight):
352         (WebCore::RootInlineBox::paint):
353         (WebCore::RootInlineBox::fillLineSelectionGap):
354         * rendering/RootInlineBox.h:
355         * rendering/SVGInlineFlowBox.cpp:
356         (WebCore::paintSVGInlineFlow):
357
358 2006-11-01  Anders Carlsson  <acarlsson@apple.com>
359
360         Reviewed by Oliver, Brady.
361
362         * platform/network/ResourceResponse.h:
363         (WebCore::ResourceResponse::setLastModifiedDate):
364         (WebCore::ResourceResponse::lastModifiedDate):
365         Add getters and setters for last modified dadte.
366         
367         * platform/network/cf/ResourceResponseCFNet.cpp:
368         (WebCore::getResourceResponse):
369         Fetch the last modified date. Add correct offset to expired date.
370
371 2006-11-01  David Kilzer  <ddkilzer@kilzer.net>
372
373         Reviewed by Mitz.
374
375         Added missing "break;" statement in switch statement from r17493.
376
377         Bug 11442: [CSS 3] support for cursor: all-scroll
378         http://bugs.webkit.org/show_bug.cgi?id=11442
379
380         * css/CSSComputedStyleDeclaration.cpp:
381         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
382
383 2006-10-31  Mitz Pettel  <mitz@webkit.org>
384
385         Reviewed by Maciej.
386
387         - fix image dragging
388
389         This is covered by editing/selection/drag-to-contenteditable-iframe.html
390
391         * rendering/HitTestResult.cpp:
392         (WebCore::HitTestResult::altDisplayString): Changed imageTag to imgTag, for
393         HTML IMG elements.
394         (WebCore::HitTestResult::absoluteImageURL): Ditto.
395
396 2006-10-31  Beth Dakin  <bdakin@apple.com>
397
398         Reviewed by Maciej.
399
400         This adds the back-end of the remaining WebElementDictionary 
401         functions into HitTestResult.
402
403         * WebCore.exp:
404         * rendering/HitTestResult.cpp:
405         (WebCore::HitTestResult::title):
406         (WebCore::displayString): This is nearly identical to the 
407         displayString() defined in DOMInternal.mm except that it returns a 
408         String instead of an NSString. The old code path used the 
409         DOMInternal method, so I made a new one here for the new code path.
410         (WebCore::HitTestResult::altDisplayString):
411         (WebCore::HitTestResult::image):
412         (WebCore::HitTestResult::absoluteImageURL):
413         (WebCore::HitTestResult::absoluteLinkURL):
414         (WebCore::HitTestResult::titleDisplayString):
415         (WebCore::HitTestResult::textContent):
416         * rendering/HitTestResult.h:
417
418 2006-10-31  John Sullivan  <sullivan@apple.com>
419
420         * bridge/mac/FrameMac.mm:
421         (WebCore::FrameMac::markMisspellings):
422         Tiger build fix: added an #ifndef BUILDING_ON_TIGER where one was needed.
423
424 2006-10-31  John Sullivan  <sullivan@apple.com>
425
426         Reviewed by Maciej
427         
428         - fixed <rdar://problem/4804627> ToolTips do not appear for grammar suggestions
429         
430         The foundation of this was in my last checkin. This checkin is all about displaying
431         the correct string in the toolTip.
432
433         * dom/DocumentMarker.h:
434         New description field in this struct.
435
436         * bridge/mac/FrameMac.mm:
437         (WebCore::FrameMac::advanceToNextMisspelling):
438         When adding a grammar marker, supply the appropriate description. Also, added a comment
439         about the remaining work to make grammar checking return sensible answers.
440         (WebCore::FrameMac::markMisspellings):
441         ditto (yes, still needs some refactoring to minimize duplicated code)
442         
443         * dom/Document.h:
444         * dom/Document.cpp:
445         (WebCore::Document::addMarker):
446         Now takes an optional description string
447         (WebCore::Document::markerContainingPoint):
448         New function, returns a pointer to the (first) marker of the specified type whose rect 
449         contains the specified point, or 0 if none.
450         
451         * rendering/HitTestResult.cpp:
452         (WebCore::HitTestResult::spellingToolTip):
453         Replaced hardwired string placeholder implementation with code that uses markerContainingPoint
454         and gets the description from the marker.
455
456 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
457
458         Reviewed by Maciej.
459         
460         Fixed crash resulting from Darin's last patch to remove BrowserExtension.
461
462         * loader/mac/FrameLoaderMac.mm:
463         (WebCore::FrameLoader::createWindow):
464         * manual-tests/window-open-features-parsing.html: Updated for clarity.
465
466 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
467
468         Reviewed by Alice.
469
470         Moved some Editing code from WebKit, the bridge, and WebCore::Frame down 
471         to WebCore::Editor.
472         
473         Layout tests pass.
474         
475         Renamed "may*" to "can*" because "can" is more accurate (these functions
476         aren't just about permission) and it matches WebKit.
477
478         (WebCore::FrameMac::handleMouseMoveEvent): Directly test for dragging in a 
479         password field. Now that WebCore fully implements canCopy(), it doesn't just
480         mean "the selection is not in a password field" anymore.
481         (-[WebCoreFrameBridge _shouldAllowAccessFrom:]): Removed this #ifed-out code. 
482         The fact that it's not called anymore may represent a security issue, but I
483         don't see how commented-out code will help reveal the issue, and the
484         bridge is going away, anyway.
485         * editing/SelectionController.h: Changed selection() calls to references
486         to m_sel, to match the rest of the file.
487
488 2006-10-31  Justin Garcia  <justin.garcia@apple.com>
489
490         Reviewed by harrison
491         
492         <rdar://problem/4711063>
493         Pasting 10K lines into Mail/Blot takes ~7sec, in TextEdit it takes ~1.5sec
494
495         * editing/ReplaceSelectionCommand.cpp:
496         (WebCore::ReplacementFragment::ReplacementFragment): Don't do the test
497         insertion and plain text string creation unless we need the string
498         for a BeforeTextInserted event handler or for a plain text only region.
499         (WebCore::ReplacementFragment::removeInterchangeNodes): Added, moved
500         code here from ReplacementFragment's constructor.
501         (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Added a
502         FIXME.
503         * editing/ReplaceSelectionCommand.h:
504
505 2006-10-31  Ada Chan  <adachan@apple.com>
506
507         Reviewed by Adam
508
509         Correct forward declarations of the HitTestRequest struct.
510
511         * rendering/EllipsisBox.h:
512         * rendering/InlineBox.h:
513         * rendering/InlineFlowBox.h:
514         * rendering/RenderLayer.h:
515         * rendering/RenderObject.h:
516
517 2006-10-31  John Sullivan  <sullivan@apple.com>
518
519         Reviewed by Beth and Adam
520
521         Support for displaying tooltips for bad grammar. Currently this always displays the same tooltip; 
522         next I'll make it use a string that's relevant for a specific grammar error.
523
524         * WebCore.exp:
525         export symbol for spellingToolTip function
526         
527         * rendering/HitTestResult.h:
528         * rendering/HitTestResult.cpp:
529         (WebCore::HitTestResult::spellingToolTip):
530         new function, returns the string to be used in a tool tip that describes the questionable grammar
531         
532         * rendering/InlineTextBox.h:
533         * rendering/InlineTextBox.cpp:
534         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
535         now takes a style and font, needed to compute the rect representing the range containing
536         questionable grammar. Computes the rect and associates it with the marker.
537         (WebCore::InlineTextBox::paintDocumentMarkers):
538         Pass in the style and font now needed by paintSpellingOrGrammarMarker
539
540 2006-10-31  Adele Peterson  <adele@apple.com>
541
542         Removed commented out variable from last checkin.
543
544         * html/HTMLSelectElement.cpp:
545         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
546
547 2006-10-31  Brady Eidson  <beidson@apple.com>
548
549         Build fix (unused variable in release builds)
550
551         * html/HTMLSelectElement.cpp:
552         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
553
554 2006-10-31  Adele Peterson  <adele@apple.com>
555
556         Reviewed by Adam.
557
558         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11127 NativeListBox: arrow and drag selection should pivot around one list item
559         and http://bugs.webkit.org/show_bug.cgi?id=11173 REGRESSION (NativeListBox): Shift-clicking items in list box doesn't expand the current selection
560         and http://bugs.webkit.org/show_bug.cgi?id=11417 REGRESSION: onchange does not fire for list-style select elements
561
562         Tests: 
563         * LayoutTests/fast/forms/listbox-selection.html
564         * LayoutTests/fast/forms/listbox-onchange.html
565
566         * html/HTMLSelectElement.h: Added m_selectedListIndexBase and m_selectedListIndexExtent to track indices for the active selection in progress.
567           Added 2 vectors to cache selection state.  One is kept so that the previous selection state can be restored as the active selection grows and shrinks.
568           And one for onChange, that is updated after onChange is fired.
569           Added m_activeSelectionState to keep track of whether the current drag selection is selecting or deselecting.
570  
571         * html/HTMLSelectElement.cpp:
572         (WebCore::HTMLSelectElement::HTMLSelectElement): Initialized new variables.
573         (WebCore::HTMLSelectElement::setSelectedIndex): If needed, initialize m_selectedListIndexBase and m_selectedListIndexExtent.
574         (WebCore::HTMLSelectElement::dispatchBlurEvent): Only fire the onChange event here for menu lists.
575         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Updates base and extent variables for mouse and key events.
576         (WebCore::HTMLSelectElement::setBase): Added. Also caches the selection state.
577         (WebCore::HTMLSelectElement::setExtent): Added.
578         (WebCore::HTMLSelectElement::updateListBoxSelection): Added.
579         (WebCore::HTMLSelectElement::listBoxOnChange): Added.
580
581         * rendering/RenderListBox.cpp:
582         (WebCore::RenderListBox::updateFromElement): Only scroll to reveal the first index if both the first and last indices aren't visible.
583         (WebCore::RenderListBox::listIndexAtOffset): Added.  Replaces optionAtPoint, which is no longer used.
584         (WebCore::RenderListBox::autoscroll): Now sets the selection using the select's base and extent.
585         (WebCore::RenderListBox::stopAutoscroll): Added.  Tells the select element to fire onChange.  This is needed because the autoscroll can end from a mouseUp
586          outside of the list box, and the select element won't get a mouseUp event directly.  But the frame will stop the autoscroll at that point, and now we can
587          notify the select element from here.
588         (WebCore::RenderListBox::scrollToRevealElementAtListIndex): Checks new listIndexIsVisible method.
589         (WebCore::RenderListBox::listIndexIsVisible): Added.
590         (WebCore::RenderListBox::valueChanged): Removed unnecessary printf.
591
592         * page/Frame.cpp: (WebCore::Frame::stopAutoscrollTimer): Added rendererIsBeingDestroyed argument, so when the renderer calls this during destruction, 
593         we don't try to use the pointer to that renderer to call stopAutoscroll.  This is done so a renderer that's still alive has a chance to do some cleanup after autoscroll.
594         * rendering/RenderListBox.h: (WebCore::RenderListBox::shouldAutoscroll): Always returns true now, since we're also updating selection from the autoscroll timer.
595         * rendering/RenderObject.h: (WebCore::RenderObject::stopAutoscroll): Added.
596         * rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): Calls stopAutoscrollTimer with rendererIsBeingDestroyed argument.
597
598 2006-10-31  Beth Dakin  <bdakin@apple.com>
599
600         Forgot to check this in a minute ago. Oops!! Thanks Mitz!
601
602         * rendering/HitTestRequest.h: Added.
603         (WebCore::HitTestRequest::HitTestRequest):
604
605 2006-10-31  Beth Dakin  <bdakin@apple.com>
606
607         Reviewed by Maciej.
608
609         Fix for http://bugs.webkit.org/show_bug.cgi?id=11461 HitTestResult 
610         should be split into HitTestRequest and HitTestResult
611
612         This patch creates a new struct called HitTestRequest that holds 
613         the three boolean values (readonly, active, and mouseMove) that 
614         were formerly a part of HitTestResult. All hitTest() and 
615         nodeAtPoint() functions now take a HitTestRequest in addition to 
616         the HitTestResult.
617
618         * WebCore.exp:
619         * WebCore.xcodeproj/project.pbxproj:
620         * bridge/mac/FrameMac.mm:
621         (WebCore::FrameMac::eventMayStartDrag):
622         (WebCore::FrameMac::handleMouseMoveEvent):
623         * bridge/mac/WebCoreAXObject.mm:
624         (-[WebCoreAXObject doAXTextMarkerForPosition:]):
625         (-[WebCoreAXObject accessibilityHitTest:]):
626         * dom/Document.cpp:
627         (WebCore::Document::elementFromPoint):
628         (WebCore::Document::prepareMouseEvent):
629         * editing/SelectionController.cpp:
630         (WebCore::SelectionController::contains):
631         * page/Frame.cpp:
632         (WebCore::Frame::hitTestResultAtPoint):
633         * page/FrameView.cpp:
634         (WebCore::FrameView::handleWheelEvent):
635         * rendering/EllipsisBox.cpp:
636         (WebCore::EllipsisBox::nodeAtPoint):
637         * rendering/EllipsisBox.h:
638         * rendering/HitTestResult.cpp:
639         (WebCore::HitTestResult::HitTestResult):
640         (WebCore::HitTestResult::operator=):
641         * rendering/HitTestResult.h:
642         * rendering/InlineBox.cpp:
643         (WebCore::InlineBox::nodeAtPoint):
644         * rendering/InlineBox.h:
645         * rendering/InlineFlowBox.cpp:
646         (WebCore::InlineFlowBox::nodeAtPoint):
647         * rendering/InlineFlowBox.h:
648         * rendering/InlineTextBox.cpp:
649         (WebCore::InlineTextBox::nodeAtPoint):
650         * rendering/InlineTextBox.h:
651         * rendering/RenderBlock.cpp:
652         (WebCore::RenderBlock::nodeAtPoint):
653         * rendering/RenderBlock.h:
654         * rendering/RenderBox.cpp:
655         (WebCore::RenderBox::nodeAtPoint):
656         * rendering/RenderBox.h:
657         * rendering/RenderFlow.cpp:
658         (WebCore::RenderFlow::hitTestLines):
659         * rendering/RenderFlow.h:
660         * rendering/RenderForeignObject.cpp:
661         (WebCore::RenderForeignObject::nodeAtPoint):
662         * rendering/RenderForeignObject.h:
663         * rendering/RenderFrameSet.cpp:
664         (WebCore::RenderFrameSet::nodeAtPoint):
665         * rendering/RenderFrameSet.h:
666         * rendering/RenderImage.cpp:
667         (WebCore::RenderImage::nodeAtPoint):
668         * rendering/RenderImage.h:
669         * rendering/RenderInline.cpp:
670         (WebCore::RenderInline::nodeAtPoint):
671         * rendering/RenderInline.h:
672         * rendering/RenderLayer.cpp:
673         (WebCore::RenderLayer::autoscroll):
674         (WebCore::RenderLayer::hitTest):
675         (WebCore::RenderLayer::hitTestLayer):
676         (WebCore::RenderLayer::updateHoverActiveState):
677         * rendering/RenderLayer.h:
678         * rendering/RenderObject.cpp:
679         (WebCore::RenderObject::hitTest):
680         (WebCore::RenderObject::nodeAtPoint):
681         * rendering/RenderObject.h:
682         * rendering/RenderPath.cpp:
683         (WebCore::RenderPath::nodeAtPoint):
684         * rendering/RenderPath.h:
685         * rendering/RenderSVGImage.cpp:
686         (WebCore::RenderSVGImage::nodeAtPoint):
687         * rendering/RenderSVGImage.h:
688         * rendering/RenderSVGText.cpp:
689         (WebCore::RenderSVGText::nodeAtPoint):
690         * rendering/RenderSVGText.h:
691         * rendering/RenderTableRow.cpp:
692         (WebCore::RenderTableRow::nodeAtPoint):
693         * rendering/RenderTableRow.h:
694         * rendering/RenderTableSection.cpp:
695         (WebCore::RenderTableSection::nodeAtPoint):
696         * rendering/RenderTableSection.h:
697         * rendering/RenderText.h:
698         (WebCore::RenderText::nodeAtPoint):
699         * rendering/RenderTextControl.cpp:
700         (WebCore::RenderTextControl::nodeAtPoint):
701         * rendering/RenderTextControl.h:
702         * rendering/RootInlineBox.cpp:
703         (WebCore::RootInlineBox::nodeAtPoint):
704         * rendering/RootInlineBox.h:
705
706 2006-10-31  Lars Naesbye Christensen <larsnaesbye@stud.ku.dk>
707
708         Reviewed by Maciej.
709
710         Bug 11442: [CSS 3] support for cursor: all-scroll
711         http://bugs.webkit.org/show_bug.cgi?id=11442
712
713         * css/CSSComputedStyleDeclaration.cpp:
714         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
715         * css/CSSValueKeywords.in:
716         * css/cssparser.cpp:
717         (WebCore::CSSParser::parseValue):
718         * page/FrameView.cpp:
719         (WebCore::selectCursor):
720         * rendering/RenderStyle.h:
721
722 2006-10-31  Oliver Hunt  <oliver@apple.com>
723
724         Reviewed by Geoff.
725
726         Converting Obj-C++ to C++ in kcanvas
727
728         * WebCore.xcodeproj/project.pbxproj:
729         * kcanvas/device/quartz/KCanvasFilterQuartz.h:
730         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
731         * kcanvas/device/quartz/KCanvasItemQuartz.cpp: Added.
732         * kcanvas/device/quartz/KCanvasItemQuartz.mm: Removed.
733         * kcanvas/device/quartz/KRenderingDeviceQuartz.cpp: Added.
734         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
735         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm: Removed.
736         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
737         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
738         * kcanvas/device/quartz/QuartzSupport.cpp: Added.
739         * kcanvas/device/quartz/QuartzSupport.h:
740         * kcanvas/device/quartz/QuartzSupport.mm: Removed.
741         * platform/graphics/svg/cg/SVGResourceClipperCg.cpp: Added.
742         (WebCore::SVGResourceClipper::applyClip):
743         * platform/graphics/svg/cg/SVGResourceClipperCg.mm: Removed.
744         * platform/graphics/svg/cg/SVGResourceImageCg.cpp: Added.
745         * platform/graphics/svg/cg/SVGResourceImageCg.mm: Removed.
746
747 2006-10-31  Justin Garcia  <justin.garcia@apple.com>
748
749         Reviewed by harrison
750         
751         <rdar://problem/4808375>
752         REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) [11460}
753         
754         Completely back out r17276 because of performance issues.
755
756         * editing/TextIterator.cpp:
757         (WebCore::TextIterator::TextIterator):
758         (WebCore::TextIterator::advance):
759         (WebCore::TextIterator::handleTextNode):
760         (WebCore::TextIterator::handleTextBox):
761         (WebCore::TextIterator::handleReplacedElement):
762         (WebCore::TextIterator::handleNonTextNode):
763         (WebCore::TextIterator::exitNode):
764         (WebCore::TextIterator::emitCharacter):
765         (WebCore::TextIterator::range):
766         (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
767         (WebCore::SimplifiedBackwardsTextIterator::advance):
768         (WebCore::SimplifiedBackwardsTextIterator::handleTextNode):
769         (WebCore::SimplifiedBackwardsTextIterator::handleReplacedElement):
770         (WebCore::SimplifiedBackwardsTextIterator::emitCharacter):
771         (WebCore::SimplifiedBackwardsTextIterator::emitNewline):
772         (WebCore::SimplifiedBackwardsTextIterator::range):
773         (WebCore::CharacterIterator::range):
774         (WebCore::TextIterator::rangeFromLocationAndLength):
775         * editing/TextIterator.h:
776         (WebCore::TextIterator::atEnd):
777         (WebCore::SimplifiedBackwardsTextIterator::atEnd):
778
779 2006-10-31  Darin Adler  <darin@apple.com>
780
781         Reviewed by Brady.
782
783         - got "action dictionary" code out of FrameLoader,
784           replacing with a class called NavigationAction
785
786         * loader/DocumentLoader.h: Changed m_triggeringAction to a NavigationAction.
787         * loader/mac/DocumentLoaderMac.mm:
788         (WebCore::DocumentLoader::triggeringAction): Ditto.
789         (WebCore::DocumentLoader::setTriggeringAction): Ditto.
790
791         * loader/FrameLoader.h: Changed action parameters to NavigationAction.
792
793         * loader/FrameLoaderClient.h: Changed action parameters to NavigationAction.
794         Removed elementForEvent.
795         * loader/mac/FrameLoaderMac.mm:
796         (WebCore::FrameLoader::load): Ditto.
797         (WebCore::FrameLoader::reload): Ditto.
798         (WebCore::FrameLoader::checkNewWindowPolicy): Ditto.
799         (WebCore::FrameLoader::checkNavigationPolicy): Ditto.
800         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): Ditto.
801         (WebCore::FrameLoader::post): Ditto.
802
803         * loader/NavigationAction.h: Added.
804         * loader/NavigationAction.cpp: Added.
805         * loader/mac/NavigationActionMac.mm: Added.
806
807         * loader/mac/MainResourceLoaderMac.mm: Fixed copyright.
808
809         * WebCore.xcodeproj/project.pbxproj: Updated for new files.
810         * WebCore.exp: Updated.
811
812 2006-10-31  Steve Falkenburg  <sfalken@apple.com>
813
814         Reviewed by Adam.
815
816         Build fix
817
818         * platform/win/CookieJarWin.cpp:
819         (WebCore::cookies):
820
821 2006-10-31  Nikolas Zimmermann  <zimmermann@kde.org>
822
823         Reviewed by Maciej. Landed by Adam.
824
825         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11463
826
827         Move KCanvasTreeDebug into rendering, named as SVGRenderTreeAsText.*,
828         as dicussed with Dave. Also kill the outdated DESIGN document.
829
830         * CMakeLists.txt:
831         * WebCore.xcodeproj/project.pbxproj:
832         * kcanvas/DESIGN: Removed.
833         * kcanvas/KCanvasFilters.cpp:
834         * kcanvas/KCanvasTreeDebug.cpp: Moved to rendering/SVGRenderTreeAsText
835         * kcanvas/KCanvasTreeDebug.h: Ditto.
836         * kcanvas/device/KRenderingPaintServerGradient.cpp:
837         * kcanvas/device/KRenderingPaintServerPattern.cpp:
838         * kcanvas/device/KRenderingPaintServerSolid.cpp:
839         * platform/graphics/svg/SVGResourceClipper.cpp:
840         * rendering/RenderTreeAsText.cpp:
841         * rendering/SVGRenderTreeAsText.cpp: Added.
842         * rendering/SVGRenderTreeAsText.h: Added.
843         (WebCore::operator<<):
844
845 2006-10-31  MorganL  <morganl.webkit@yahoo.com>
846
847         Reviewed by Maciej.
848
849         Fixes http://bugs.webkit.org/show_bug.cgi?id=11286
850         Includes some CRLF -> LF fixups.
851
852         * platform/win/CookieJarWin.cpp:
853         (WebCore::cookies):
854
855 2006-10-31  Adam Roben  <aroben@apple.com>
856
857         Reviewed by Steve.
858
859         Fix some incorrect forward declarations.
860
861         * loader/FrameLoader.h:
862         * page/Frame.h:
863
864 2006-10-31  Darin Adler  <darin@apple.com>
865
866         * WebCore.xcodeproj/project.pbxproj: Change GraphicsTypes.h to a private header to
867         try to fix the build on the buildbot.
868
869 2006-10-31  Darin Adler  <darin@apple.com>
870
871         * bridge/mac/FrameMac.mm:
872         (WebCore::FrameMac::advanceToNextMisspelling): Build fix for release Tiger builds.
873         (WebCore::FrameMac::markMisspellings): Ditto.
874
875 2006-10-31  John Sullivan  <sullivan@apple.com>
876
877         * bridge/mac/FrameMac.mm:
878         (WebCore::FrameMac::advanceToNextMisspelling):
879         build fix: needed #ifndef BUILDING_ON_TIGER in one more place
880
881 2006-10-30  John Sullivan  <sullivan@apple.com>
882
883         Reviewed by Adam Roben
884         
885         - fixes <rdar://problem/4804614> Bad grammar ranges are not visibly marked
886         
887         This patch introduces much of the guts of grammar checking, though still not enough to actually
888         check grammar sensibly, due to:
889           
890         <rdar://problem/4811175> Many false reports of bad grammar appear, caused by insufficient 
891         context passed to grammar checker
892
893         * platform/Logging.h:
894         * platform/Logging.cpp:
895         new log channel SpellingAndGrammar
896
897         * bridge/mac/WebCorePageBridge.mm:
898         (initializeLoggingChannelsIfNecessary):
899         initialize new log channel
900
901         * bridge/mac/FrameMac.mm:
902         (WebCore::FrameMac::advanceToNextMisspelling):
903         Compute bad grammar range when computing misspelling range. Find first detailed grammar range from the
904         set NSSpellChecker determines. Compare it with misspelling range to see which is earliest (or shortest
905         in the event of a tie), and do further processing with that one (select range; create marker that
906         causes range to be visibly marked with a funky underline; update spelling panel appropriately).
907         (WebCore::FrameMac::markMisspellings):
908         More or less the same types of changes as in advanceToNextMisspelling The loops are structured just 
909         differently enough to make sharing code between these two functions a little tricky, so I decided to 
910         save that for a later patch.
911         
912         (WebCore::FrameMac::respondToChangedSelection):
913         remove grammar markers when we remove spelling markers        
914
915 2006-10-31  Nikolas Zimmermann <zimmermann@kde.org>
916
917         Reviewed by Mitz.
918
919         Fix Qt/Linux build with older gcc3.3.4.
920
921         * bindings/js/kjs_window.cpp:
922         (KJS::WindowFunc::callAsFunction):
923
924 2006-10-31  Zack Rusin  <zack@kde.org>
925
926         Reviewed by Mitz.
927
928         Fix the Qt build after last nights changes.
929
930         * WebCore/platform/qt/FrameQt.cpp:
931         * WebCore/platform/qt/EditorClientQt.h:
932         * WebCore/platform/qt/EditorClientQt.cpp:
933         * WebCore/platform/graphics/svg/qt/SVGResourceImageQt.cpp:
934         * WebCore/platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
935         * WebCore/CMakeLists.txt:
936         * WebCore/kcanvas/device/qt/KRenderingDeviceQt.cpp:
937         * WebKitQt/QtLauncher/CMakeLists.txt:
938         * WebKitQt/WebKitPart/CMakeLists.txt:
939
940 2006-10-30  Darin Adler  <darin@apple.com>
941
942         Reviewed by Anders.
943
944         - remove BrowserExtension
945
946         * WebCore.vcproj/WebCore/WebCore.vcproj:
947         * WebCore.xcodeproj/project.pbxproj:
948         * bindings/js/kjs_window.cpp:
949         (KJS::createNewWindow):
950         (KJS::WindowFunc::callAsFunction):
951         * bridge/BrowserExtension.h: Removed.
952         * bridge/mac/BrowserExtensionMac.h: Removed.
953         * bridge/mac/BrowserExtensionMac.mm: Removed.
954         * bridge/mac/FrameMac.mm:
955         (WebCore::FrameMac::FrameMac):
956         (WebCore::FrameMac::submitForm):
957         (WebCore::FrameMac::urlSelected):
958         * bridge/win/BrowserExtensionWin.cpp: Removed.
959         * bridge/win/BrowserExtensionWin.h: Removed.
960         * bridge/win/FrameWin.cpp:
961         (WebCore::FrameWin::FrameWin):
962         * loader/FrameLoader.cpp:
963         (WebCore::FrameLoader::createWindow):
964         * loader/FrameLoader.h:
965         * loader/icon/IconLoader.cpp:
966         * loader/mac/FrameLoaderMac.mm:
967         (WebCore::FrameLoader::safeLoad):
968         (WebCore::FrameLoader::load):
969         (WebCore::FrameLoader::createWindow):
970         * page/Frame.cpp:
971         (WebCore::Frame::urlSelected):
972         (WebCore::Frame::requestFrame):
973         (WebCore::Frame::submitForm):
974         (WebCore::Frame::scheduleHistoryNavigation):
975         (WebCore::Frame::redirectionTimerFired):
976         * page/Frame.h:
977         * page/FrameLoadRequest.h:
978         (WebCore::FrameLoadRequest::FrameLoadRequest):
979         (WebCore::FrameLoadRequest::isEmpty):
980         (WebCore::FrameLoadRequest::resourceRequest):
981         (WebCore::FrameLoadRequest::frameName):
982         (WebCore::FrameLoadRequest::setFrameName):
983         * page/FramePrivate.h:
984         (WebCore::FramePrivate::FramePrivate):
985         (WebCore::FramePrivate::~FramePrivate):
986         * platform/gdk/BrowserExtensionGdk.h: Removed.
987         * platform/gdk/FrameGdk.cpp:
988         (WebCore::FrameGdk::FrameGdk):
989         * platform/gdk/TemporaryLinkStubs.cpp:
990         * platform/network/ResourceRequest.h:
991         (WebCore::ResourceRequest::isEmpty):
992
993 2006-10-31  Nikolas Zimmermann  <zimmermann@kde.org>
994
995         Reviewed by Oliver.
996
997         Modified from original due to earlier reversion
998
999         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11436
1000
1001         Better SVG integration in WebKit, Part I.
1002
1003         The patch is mostly about creating a new platform/graphics directory, and
1004         moving the kcanvas resources (clipper/masker/marker) there (in svg budir),
1005         with a new name (KCanvasClipper -> SVGResourceClipper). Also fix several ownership
1006         issues, by using ref counting (the SVG classes now store RefPtrs to the resources).
1007
1008         KCanvasFilters is still left in kcanvas/ subdirectory, to be converted in a next patch.
1009         All details of the patch, and upcoming patches can be found in the bug report.
1010
1011         * CMakeLists.txt:
1012         * WebCore.xcodeproj/project.pbxproj:
1013         * graphics/svg/SVGResource.cpp: Removed.
1014         * graphics/svg/SVGResourceClipper.cpp: Removed.
1015         * graphics/svg/SVGResourceClipper.h: Removed.
1016         * graphics/svg/SVGResourceImage.h: Removed.
1017         * graphics/svg/SVGResourceListener.h: Removed.
1018         * graphics/svg/SVGResourceMarker.cpp: Removed.
1019         * graphics/svg/SVGResourceMarker.h: Removed.
1020         * graphics/svg/SVGResourceMasker.cpp: Removed.
1021         * graphics/svg/SVGResourceMasker.h: Removed.
1022         * kcanvas/KCanvasClipper.cpp: Removed.
1023         * kcanvas/KCanvasClipper.h: Removed.
1024         * kcanvas/KCanvasCreator.cpp: Removed.
1025         * kcanvas/KCanvasCreator.h: Removed.
1026         * kcanvas/KCanvasFilters.cpp:
1027         (WebCore::getFilterById):
1028         * kcanvas/KCanvasFilters.h:
1029         * kcanvas/KCanvasImage.h: Removed.
1030         * kcanvas/KCanvasMarker.cpp: Removed.
1031         * kcanvas/KCanvasMarker.h: Removed.
1032         * kcanvas/KCanvasMasker.cpp: Removed.
1033         * kcanvas/KCanvasMasker.h: Removed.
1034         * kcanvas/KCanvasResource.cpp: Removed.
1035         * kcanvas/KCanvasResource.h: Removed.
1036         * kcanvas/KCanvasResourceListener.h: Removed.
1037         * kcanvas/KCanvasTreeDebug.cpp:
1038         (WebCore::writeRenderResources):
1039         * kcanvas/device/KRenderingDevice.h:
1040         * kcanvas/device/KRenderingPaintServer.h:
1041         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
1042         * kcanvas/device/KRenderingPaintServerGradient.cpp:
1043         (WebCore::KRenderingPaintServerGradient::listener):
1044         (WebCore::KRenderingPaintServerGradient::setListener):
1045         * kcanvas/device/KRenderingPaintServerGradient.h:
1046         * kcanvas/device/KRenderingPaintServerPattern.cpp:
1047         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
1048         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
1049         (WebCore::KRenderingPaintServerPattern::tile):
1050         (WebCore::KRenderingPaintServerPattern::setTile):
1051         (WebCore::KRenderingPaintServerPattern::listener):
1052         (WebCore::KRenderingPaintServerPattern::setListener):
1053         * kcanvas/device/KRenderingPaintServerPattern.h:
1054         * kcanvas/device/KRenderingPaintServerSolid.h:
1055         * kcanvas/device/qt/KCanvasClipperQt.cpp: Removed.
1056         * kcanvas/device/qt/KCanvasClipperQt.h:
1057         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
1058         (WebCore::KRenderingDeviceQt::contextForImage):
1059         (WebCore::KRenderingDeviceQt::createResource):
1060         (WebCore::KRenderingDeviceQt::createPaintServer):
1061         * kcanvas/device/qt/KRenderingDeviceQt.h:
1062         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
1063         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
1064         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
1065         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
1066         * kcanvas/device/qt/RenderPathQt.h: Removed.
1067         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
1068         (WebCore::KCanvasFilterQuartz::getCIFilterStack):
1069         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
1070         * kcanvas/device/quartz/KCanvasMaskerQuartz.h: Removed.
1071         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm: Removed.
1072         * kcanvas/device/quartz/KCanvasResourcesQuartz.h: Removed.
1073         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm: Removed.
1074         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
1075         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
1076         (WebCore::KRenderingDeviceQuartz::contextForImage):
1077         (WebCore::KRenderingDeviceQuartz::createPaintServer):
1078         (WebCore::KRenderingDeviceQuartz::createResource):
1079         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
1080         (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
1081         (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz):
1082         (WebCore::KRenderingPaintServerGradientQuartz::setup):
1083         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
1084         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
1085         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
1086         (WebCore::patternCallback):
1087         (WebCore::KRenderingPaintServerPatternQuartz::setup):
1088         * kcanvas/device/quartz/QuartzSupport.mm:
1089         * ksvg2/misc/KCanvasRenderingStyle.cpp:
1090         (WebCore::sharedSolidPaintServer):
1091         * ksvg2/svg/SVGClipPathElement.cpp:
1092         (WebCore::SVGClipPathElement::SVGClipPathElement):
1093         (WebCore::SVGClipPathElement::~SVGClipPathElement):
1094         (WebCore::SVGClipPathElement::canvasResource):
1095         * ksvg2/svg/SVGClipPathElement.h:
1096         * ksvg2/svg/SVGFEImageElement.cpp:
1097         * ksvg2/svg/SVGFilterElement.cpp:
1098         (WebCore::SVGFilterElement::SVGFilterElement):
1099         (WebCore::SVGFilterElement::~SVGFilterElement):
1100         (WebCore::SVGFilterElement::canvasResource):
1101         * ksvg2/svg/SVGFilterElement.h:
1102         * ksvg2/svg/SVGGradientElement.cpp:
1103         (WebCore::SVGGradientElement::SVGGradientElement):
1104         (WebCore::SVGGradientElement::~SVGGradientElement):
1105         (WebCore::SVGGradientElement::canvasResource):
1106         (WebCore::SVGGradientElement::resourceNotification):
1107         * ksvg2/svg/SVGGradientElement.h:
1108         * ksvg2/svg/SVGImageElement.cpp:
1109         * ksvg2/svg/SVGLinearGradientElement.cpp:
1110         (WebCore::SVGLinearGradientElement::buildGradient):
1111         * ksvg2/svg/SVGLinearGradientElement.h:
1112         * ksvg2/svg/SVGMarkerElement.cpp:
1113         (WebCore::SVGMarkerElement::SVGMarkerElement):
1114         (WebCore::SVGMarkerElement::~SVGMarkerElement):
1115         (WebCore::SVGMarkerElement::canvasResource):
1116         * ksvg2/svg/SVGMarkerElement.h:
1117         * ksvg2/svg/SVGMaskElement.cpp:
1118         (WebCore::SVGMaskElement::SVGMaskElement):
1119         (WebCore::SVGMaskElement::~SVGMaskElement):
1120         (WebCore::SVGMaskElement::drawMaskerContent):
1121         (WebCore::SVGMaskElement::canvasResource):
1122         * ksvg2/svg/SVGMaskElement.h:
1123         * ksvg2/svg/SVGPatternElement.cpp:
1124         (WebCore::SVGPatternElement::SVGPatternElement):
1125         (WebCore::SVGPatternElement::~SVGPatternElement):
1126         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
1127         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
1128         (WebCore::SVGPatternElement::canvasResource):
1129         * ksvg2/svg/SVGPatternElement.h:
1130         * ksvg2/svg/SVGRadialGradientElement.cpp:
1131         (WebCore::SVGRadialGradientElement::buildGradient):
1132         * ksvg2/svg/SVGRadialGradientElement.h:
1133         * ksvg2/svg/SVGStyledElement.h:
1134         (WebCore::SVGStyledElement::canvasResource):
1135         * platform/GraphicsContext.cpp: Removed.
1136         * platform/GraphicsContext.h: Removed.
1137         * platform/GraphicsTypes.cpp: Removed.
1138         * platform/GraphicsTypes.h: Removed.
1139         * platform/graphics/GraphicsContext.cpp:
1140         (WebCore::GraphicsContextState::GraphicsContextState):
1141         (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
1142         (WebCore::GraphicsContext::createGraphicsContextPrivate):
1143         (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
1144         (WebCore::GraphicsContext::save):
1145         (WebCore::GraphicsContext::restore):
1146         (WebCore::GraphicsContext::font):
1147         (WebCore::GraphicsContext::setFont):
1148         (WebCore::GraphicsContext::pen):
1149         (WebCore::GraphicsContext::setPen):
1150         (WebCore::GraphicsContext::setFillColor):
1151         (WebCore::GraphicsContext::fillColor):
1152         (WebCore::GraphicsContext::updatingControlTints):
1153         (WebCore::GraphicsContext::setUpdatingControlTints):
1154         (WebCore::GraphicsContext::setPaintingDisabled):
1155         (WebCore::GraphicsContext::paintingDisabled):
1156         (WebCore::GraphicsContext::drawImage):
1157         (WebCore::GraphicsContext::drawText):
1158         (WebCore::GraphicsContext::drawHighlightForText):
1159         (WebCore::GraphicsContext::initFocusRing):
1160         (WebCore::GraphicsContext::clearFocusRing):
1161         (WebCore::GraphicsContext::focusRingBoundingRect):
1162         (WebCore::GraphicsContext::addFocusRingRect):
1163         (WebCore::GraphicsContext::focusRingWidth):
1164         (WebCore::GraphicsContext::focusRingOffset):
1165         (WebCore::GraphicsContext::focusRingRects):
1166         (WebCore::GraphicsContext::drawTiledImage):
1167         * platform/graphics/GraphicsContext.h:
1168         * platform/graphics/GraphicsTypes.cpp:
1169         (WebCore::):
1170         (WebCore::parseCompositeOperator):
1171         (WebCore::compositeOperatorName):
1172         (WebCore::parseLineCap):
1173         (WebCore::lineCapName):
1174         (WebCore::parseLineJoin):
1175         (WebCore::lineJoinName):
1176         * platform/graphics/GraphicsTypes.h:
1177         (WebCore::):
1178         * platform/graphics/svg/SVGResource.cpp: Added.
1179         (WebCore::SVGResource::SVGResource):
1180         (WebCore::SVGResource::~SVGResource):
1181         (WebCore::SVGResource::invalidate):
1182         (WebCore::SVGResource::addClient):
1183         (WebCore::SVGResource::clients):
1184         (WebCore::SVGResource::idInRegistry):
1185         (WebCore::SVGResource::setIdInRegistry):
1186         (WebCore::SVGResource::externalRepresentation):
1187         (WebCore::getResourceById):
1188         (WebCore::getPaintServerById):
1189         (WebCore::operator<<):
1190         * platform/graphics/svg/SVGResource.h: Added.
1191         (WebCore::):
1192         (WebCore::SVGResource::isPaintServer):
1193         (WebCore::SVGResource::isFilter):
1194         (WebCore::SVGResource::isClipper):
1195         (WebCore::SVGResource::isMarker):
1196         (WebCore::SVGResource::isMasker):
1197         (WebCore::SVGResourceListener::~SVGResourceListener):
1198         * platform/graphics/svg/SVGResourceClipper.cpp: Added.
1199         (WebCore::SVGResourceClipper::SVGResourceClipper):
1200         (WebCore::SVGResourceClipper::~SVGResourceClipper):
1201         (WebCore::SVGResourceClipper::resetClipData):
1202         (WebCore::SVGResourceClipper::addClipData):
1203         (WebCore::SVGResourceClipper::clipData):
1204         (WebCore::SVGResourceClipper::externalRepresentation):
1205         (WebCore::operator<<):
1206         (WebCore::getClipperById):
1207         * platform/graphics/svg/SVGResourceClipper.h: Added.
1208         (WebCore::ClipDataList::addPath):
1209         (WebCore::SVGResourceClipper::isClipper):
1210         * platform/graphics/svg/SVGResourceImage.h: Added.
1211         * platform/graphics/svg/SVGResourceMarker.cpp: Added.
1212         (WebCore::SVGResourceMarker::SVGResourceMarker):
1213         (WebCore::SVGResourceMarker::~SVGResourceMarker):
1214         (WebCore::SVGResourceMarker::setMarker):
1215         (WebCore::SVGResourceMarker::setRef):
1216         (WebCore::SVGResourceMarker::draw):
1217         (WebCore::SVGResourceMarker::externalRepresentation):
1218         (WebCore::getMarkerById):
1219         * platform/graphics/svg/SVGResourceMarker.h: Added.
1220         (WebCore::SVGResourceMarker::refX):
1221         (WebCore::SVGResourceMarker::refY):
1222         (WebCore::SVGResourceMarker::setAngle):
1223         (WebCore::SVGResourceMarker::setAutoAngle):
1224         (WebCore::SVGResourceMarker::angle):
1225         (WebCore::SVGResourceMarker::setUseStrokeWidth):
1226         (WebCore::SVGResourceMarker::useStrokeWidth):
1227         (WebCore::SVGResourceMarker::isMarker):
1228         * platform/graphics/svg/SVGResourceMasker.cpp: Added.
1229         (WebCore::SVGResourceMasker::SVGResourceMasker):
1230         (WebCore::SVGResourceMasker::~SVGResourceMasker):
1231         (WebCore::SVGResourceMasker::setMask):
1232         (WebCore::SVGResourceMasker::mask):
1233         (WebCore::SVGResourceMasker::externalRepresentation):
1234         (WebCore::getMaskerById):
1235         * platform/graphics/svg/SVGResourceMasker.h: Added.
1236         (WebCore::SVGResourceMasker::isMasker):
1237         * platform/graphics/svg/cg/SVGResourceClipperCg.mm: Added.
1238         (WebCore::SVGResourceClipper::applyClip):
1239         * platform/graphics/svg/cg/SVGResourceImageCg.mm: Added.
1240         (WebCore::SVGResourceImage::SVGResourceImage):
1241         (WebCore::SVGResourceImage::~SVGResourceImage):
1242         (WebCore::SVGResourceImage::init):
1243         (WebCore::SVGResourceImage::size):
1244         (WebCore::SVGResourceImage::cgLayer):
1245         (WebCore::SVGResourceImage::setCGLayer):
1246         * platform/graphics/svg/cg/SVGResourceMaskerCg.mm: Added.
1247         (WebCore::applyLuminanceToAlphaFilter):
1248         (WebCore::applyExpandAlphatoGrayscaleFilter):
1249         (WebCore::transformImageIntoGrayscaleMask):
1250         (WebCore::SVGResourceMasker::applyMask):
1251         * platform/graphics/svg/qt/SVGResourceClipperQt.cpp: Added.
1252         (WebCore::SVGResourceClipper::applyClip):
1253         * platform/graphics/svg/qt/SVGResourceImageQt.cpp: Added.
1254         (WebCore::SVGResourceImage::init):
1255         (WebCore::SVGResourceImage::size):
1256         * platform/graphics/svg/qt/SVGResourceMaskerQt.cpp: Added.
1257         (WebCore::SVGResourceMasker::applyMask):
1258         * platform/qt/GraphicsContextQt.cpp:
1259         * rendering/RenderPath.cpp:
1260         (WebCore::RenderPath::paint):
1261         (WebCore::DrawMarkersData::DrawMarkersData):
1262         (WebCore::RenderPath::drawMarkersIfNeeded):
1263         * rendering/RenderSVGContainer.cpp:
1264         (WebCore::RenderSVGContainer::paint):
1265         * rendering/RenderSVGImage.cpp:
1266         (WebCore::RenderSVGImage::paint):
1267         * rendering/SVGInlineFlowBox.cpp:
1268         (WebCore::paintSVGInlineFlow):
1269
1270 2006-10-30  John Sullivan  <sullivan@apple.com>
1271
1272         Reviewed by Brady
1273         
1274         - minor cleanup to make future patches clearer
1275
1276         * bridge/mac/FrameMac.mm:
1277         (WebCore::FrameMac::advanceToNextMisspelling):
1278         renamed misspelling to misspellingNSRange for clarity; changed > 0 test to == 0 test
1279         with "continue" to better match structure of similar code in markMisspellings; a few
1280         other style tweaks.
1281         
1282         (WebCore::FrameMac::markMisspellings):
1283         renamed misspelling to misspellingNSRange for clarity; removed unnecessary braces around
1284         a block just after a break and outdented accordingly.
1285
1286 2006-10-30  John Sullivan  <sullivan@apple.com>
1287
1288         Reviewed by Geoff Garen
1289         
1290         WebCore part of change to push the code that updates the spelling panel
1291         into WebCore, in preparation for some grammar-checking stuff.
1292
1293         * bridge/mac/FrameMac.h:
1294         * bridge/mac/FrameMac.mm:
1295         (WebCore::FrameMac::advanceToNextMisspelling):
1296         no more return value for this method, and update the spelling panel with
1297         the misspelled word here rather than in the WebKit callers.
1298
1299 2006-10-30  Oliver Hunt  <oliver@apple.com>
1300
1301         Reviewed by Anders.
1302
1303         Roll out last patch
1304
1305         * CMakeLists.txt:
1306         * ChangeLog:
1307         * WebCore.xcodeproj/project.pbxproj:
1308         * graphics/svg/SVGResource.cpp:
1309         * graphics/svg/SVGResourceClipper.cpp:
1310         * graphics/svg/SVGResourceClipper.h:
1311         * graphics/svg/SVGResourceImage.h:
1312         * graphics/svg/SVGResourceListener.h:
1313         * graphics/svg/SVGResourceMarker.cpp:
1314         * graphics/svg/SVGResourceMarker.h:
1315         * graphics/svg/SVGResourceMasker.cpp:
1316         * graphics/svg/SVGResourceMasker.h:
1317         * kcanvas/KCanvasClipper.cpp: Added.
1318         (WebCore::operator<<):
1319         (WebCore::KCanvasClipper::KCanvasClipper):
1320         (WebCore::KCanvasClipper::~KCanvasClipper):
1321         (WebCore::KCanvasClipper::resetClipData):
1322         (WebCore::KCanvasClipper::addClipData):
1323         (WebCore::KCanvasClipper::clipData):
1324         (WebCore::KCanvasClipper::externalRepresentation):
1325         (WebCore::getClipperById):
1326         * kcanvas/KCanvasClipper.h: Added.
1327         (WebCore::KCClipData::windRule):
1328         (WebCore::KCClipDataList::KCClipDataList):
1329         (WebCore::KCClipDataList::addPath):
1330         (WebCore::KCanvasClipper::isClipper):
1331         * kcanvas/KCanvasFilters.cpp:
1332         (WebCore::getFilterById):
1333         * kcanvas/KCanvasFilters.h:
1334         * kcanvas/KCanvasImage.h: Added.
1335         (WebCore::KCanvasImage::KCanvasImage):
1336         (WebCore::KCanvasImage::~KCanvasImage):
1337         * kcanvas/KCanvasMarker.cpp: Added.
1338         (WebCore::KCanvasMarker::KCanvasMarker):
1339         (WebCore::KCanvasMarker::~KCanvasMarker):
1340         (WebCore::KCanvasMarker::setMarker):
1341         (WebCore::KCanvasMarker::setRef):
1342         (WebCore::KCanvasMarker::refX):
1343         (WebCore::KCanvasMarker::refY):
1344         (WebCore::KCanvasMarker::setAngle):
1345         (WebCore::KCanvasMarker::angle):
1346         (WebCore::KCanvasMarker::setAutoAngle):
1347         (WebCore::KCanvasMarker::setUseStrokeWidth):
1348         (WebCore::KCanvasMarker::useStrokeWidth):
1349         (WebCore::KCanvasMarker::draw):
1350         (WebCore::KCanvasMarker::externalRepresentation):
1351         (WebCore::getMarkerById):
1352         * kcanvas/KCanvasMarker.h: Added.
1353         (WebCore::KCanvasMarker::isMarker):
1354         * kcanvas/KCanvasMasker.cpp: Added.
1355         (WebCore::KCanvasMasker::KCanvasMasker):
1356         (WebCore::KCanvasMasker::~KCanvasMasker):
1357         (WebCore::KCanvasMasker::setMask):
1358         (WebCore::KCanvasMasker::externalRepresentation):
1359         (WebCore::getMaskerById):
1360         * kcanvas/KCanvasMasker.h: Added.
1361         (WebCore::KCanvasMasker::isMasker):
1362         (WebCore::KCanvasMasker::mask):
1363         * kcanvas/KCanvasResource.cpp: Added.
1364         (WebCore::operator<<):
1365         (WebCore::KCanvasResource::KCanvasResource):
1366         (WebCore::KCanvasResource::~KCanvasResource):
1367         (WebCore::KCanvasResource::addClient):
1368         (WebCore::KCanvasResource::clients):
1369         (WebCore::KCanvasResource::invalidate):
1370         (WebCore::KCanvasResource::idInRegistry):
1371         (WebCore::KCanvasResource::setIdInRegistry):
1372         (WebCore::KCanvasResource::externalRepresentation):
1373         (WebCore::getResourceById):
1374         (WebCore::getPaintServerById):
1375         * kcanvas/KCanvasResource.h:
1376         (WebCore::):
1377         (WebCore::KCanvasResource::isPaintServer):
1378         (WebCore::KCanvasResource::isFilter):
1379         (WebCore::KCanvasResource::isClipper):
1380         (WebCore::KCanvasResource::isMarker):
1381         (WebCore::KCanvasResource::isMasker):
1382         * kcanvas/KCanvasResourceListener.h: Added.
1383         (KCanvasResourceListener::KCanvasResourceListener):
1384         (KCanvasResourceListener::~KCanvasResourceListener):
1385         * kcanvas/KCanvasTreeDebug.cpp:
1386         (WebCore::writeRenderResources):
1387         * kcanvas/device/KRenderingDevice.h:
1388         * kcanvas/device/KRenderingPaintServer.h:
1389         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
1390         (WebCore::KRenderingPaintServer::idInRegistry):
1391         (WebCore::KRenderingPaintServer::setIdInRegistry):
1392         * kcanvas/device/KRenderingPaintServerGradient.cpp:
1393         (WebCore::KRenderingPaintServerGradient::listener):
1394         (WebCore::KRenderingPaintServerGradient::setListener):
1395         * kcanvas/device/KRenderingPaintServerGradient.h:
1396         * kcanvas/device/KRenderingPaintServerPattern.cpp:
1397         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
1398         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
1399         (WebCore::KRenderingPaintServerPattern::tile):
1400         (WebCore::KRenderingPaintServerPattern::setTile):
1401         (WebCore::KRenderingPaintServerPattern::listener):
1402         (WebCore::KRenderingPaintServerPattern::setListener):
1403         * kcanvas/device/KRenderingPaintServerPattern.h:
1404         * kcanvas/device/KRenderingPaintServerSolid.h:
1405         * kcanvas/device/qt/KCanvasClipperQt.cpp:
1406         (WebCore::KCanvasClipperQt::applyClip):
1407         * kcanvas/device/qt/KCanvasClipperQt.h:
1408         (WebCore::KCanvasClipperQt::KCanvasClipperQt):
1409         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
1410         (WebCore::KRenderingDeviceQt::contextForImage):
1411         (WebCore::KRenderingDeviceQt::createResource):
1412         (WebCore::KRenderingDeviceQt::createPaintServer):
1413         * kcanvas/device/qt/KRenderingDeviceQt.h:
1414         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
1415         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
1416         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
1417         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
1418         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
1419         (WebCore::KCanvasFilterQuartz::getCIFilterStack):
1420         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
1421         * kcanvas/device/quartz/KCanvasMaskerQuartz.h:
1422         (WebCore::KCanvasMaskerQuartz::KCanvasMaskerQuartz):
1423         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
1424         (WebCore::applyLuminanceToAlphaFilter):
1425         (WebCore::applyExpandAlphatoGrayscaleFilter):
1426         (WebCore::transformImageIntoGrayscaleMask):
1427         (WebCore::KCanvasMaskerQuartz::applyMask):
1428         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
1429         (WebCore::KCanvasClipperQuartz::KCanvasClipperQuartz):
1430         (WebCore::KCanvasImageQuartz::KCanvasImageQuartz):
1431         (WebCore::KCanvasImageQuartz::init):
1432         (WebCore::KCanvasImageQuartz::size):
1433         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
1434         (WebCore::KCanvasClipperQuartz::applyClip):
1435         (WebCore::KCanvasImageQuartz::~KCanvasImageQuartz):
1436         (WebCore::KCanvasImageQuartz::cgLayer):
1437         (WebCore::KCanvasImageQuartz::setCGLayer):
1438         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
1439         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
1440         (WebCore::KRenderingDeviceQuartz::contextForImage):
1441         (WebCore::KRenderingDeviceQuartz::createPaintServer):
1442         (WebCore::KRenderingDeviceQuartz::createResource):
1443         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
1444         (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
1445         (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz):
1446         (WebCore::KRenderingPaintServerGradientQuartz::setup):
1447         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
1448         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
1449         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
1450         (WebCore::patternCallback):
1451         (WebCore::KRenderingPaintServerPatternQuartz::setup):
1452         * kcanvas/device/quartz/QuartzSupport.mm:
1453         * ksvg2/misc/KCanvasRenderingStyle.cpp:
1454         (WebCore::sharedSolidPaintServer):
1455         * ksvg2/svg/SVGClipPathElement.cpp:
1456         (WebCore::SVGClipPathElement::SVGClipPathElement):
1457         (WebCore::SVGClipPathElement::~SVGClipPathElement):
1458         (WebCore::SVGClipPathElement::canvasResource):
1459         * ksvg2/svg/SVGClipPathElement.h:
1460         * ksvg2/svg/SVGFEImageElement.cpp:
1461         * ksvg2/svg/SVGFilterElement.cpp:
1462         (WebCore::SVGFilterElement::SVGFilterElement):
1463         (WebCore::SVGFilterElement::~SVGFilterElement):
1464         (WebCore::SVGFilterElement::canvasResource):
1465         * ksvg2/svg/SVGFilterElement.h:
1466         * ksvg2/svg/SVGGradientElement.cpp:
1467         (WebCore::SVGGradientElement::SVGGradientElement):
1468         (WebCore::SVGGradientElement::~SVGGradientElement):
1469         (WebCore::SVGGradientElement::canvasResource):
1470         (WebCore::SVGGradientElement::resourceNotification):
1471         * ksvg2/svg/SVGGradientElement.h:
1472         * ksvg2/svg/SVGImageElement.cpp:
1473         * ksvg2/svg/SVGLinearGradientElement.cpp:
1474         (WebCore::SVGLinearGradientElement::buildGradient):
1475         * ksvg2/svg/SVGLinearGradientElement.h:
1476         * ksvg2/svg/SVGMarkerElement.cpp:
1477         (WebCore::SVGMarkerElement::SVGMarkerElement):
1478         (WebCore::SVGMarkerElement::~SVGMarkerElement):
1479         (WebCore::SVGMarkerElement::canvasResource):
1480         * ksvg2/svg/SVGMarkerElement.h:
1481         * ksvg2/svg/SVGMaskElement.cpp:
1482         (WebCore::SVGMaskElement::SVGMaskElement):
1483         (WebCore::SVGMaskElement::~SVGMaskElement):
1484         (WebCore::SVGMaskElement::drawMaskerContent):
1485         (WebCore::SVGMaskElement::canvasResource):
1486         * ksvg2/svg/SVGMaskElement.h:
1487         * ksvg2/svg/SVGPatternElement.cpp:
1488         (WebCore::SVGPatternElement::SVGPatternElement):
1489         (WebCore::SVGPatternElement::~SVGPatternElement):
1490         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
1491         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
1492         (WebCore::SVGPatternElement::canvasResource):
1493         * ksvg2/svg/SVGPatternElement.h:
1494         * ksvg2/svg/SVGRadialGradientElement.cpp:
1495         (WebCore::SVGRadialGradientElement::buildGradient):
1496         * ksvg2/svg/SVGRadialGradientElement.h:
1497         * ksvg2/svg/SVGStyledElement.h:
1498         (WebCore::SVGStyledElement::canvasResource):
1499         * platform/GraphicsContext.cpp: Added.
1500         (WebCore::GraphicsContextState::GraphicsContextState):
1501         (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
1502         (WebCore::GraphicsContext::createGraphicsContextPrivate):
1503         (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
1504         (WebCore::GraphicsContext::save):
1505         (WebCore::GraphicsContext::restore):
1506         (WebCore::GraphicsContext::font):
1507         (WebCore::GraphicsContext::setFont):
1508         (WebCore::GraphicsContext::pen):
1509         (WebCore::GraphicsContext::setPen):
1510         (WebCore::GraphicsContext::setFillColor):
1511         (WebCore::GraphicsContext::fillColor):
1512         (WebCore::GraphicsContext::updatingControlTints):
1513         (WebCore::GraphicsContext::setUpdatingControlTints):
1514         (WebCore::GraphicsContext::setPaintingDisabled):
1515         (WebCore::GraphicsContext::paintingDisabled):
1516         (WebCore::GraphicsContext::drawImage):
1517         (WebCore::GraphicsContext::drawText):
1518         (WebCore::GraphicsContext::drawHighlightForText):
1519         (WebCore::GraphicsContext::initFocusRing):
1520         (WebCore::GraphicsContext::clearFocusRing):
1521         (WebCore::GraphicsContext::focusRingBoundingRect):
1522         (WebCore::GraphicsContext::addFocusRingRect):
1523         (WebCore::GraphicsContext::focusRingWidth):
1524         (WebCore::GraphicsContext::focusRingOffset):
1525         (WebCore::GraphicsContext::focusRingRects):
1526         (WebCore::GraphicsContext::drawTiledImage):
1527         * platform/GraphicsContext.h: Added.
1528         * platform/GraphicsTypes.cpp: Added.
1529         (WebCore::):
1530         (WebCore::parseCompositeOperator):
1531         (WebCore::compositeOperatorName):
1532         (WebCore::parseLineCap):
1533         (WebCore::lineCapName):
1534         (WebCore::parseLineJoin):
1535         (WebCore::lineJoinName):
1536         * platform/GraphicsTypes.h: Added.
1537         (WebCore::):
1538         * platform/graphics/GraphicsContext.cpp:
1539         * platform/graphics/GraphicsContext.h:
1540         * platform/graphics/GraphicsTypes.cpp:
1541         * platform/graphics/GraphicsTypes.h:
1542         * platform/qt/GraphicsContextQt.cpp:
1543         * rendering/RenderPath.cpp:
1544         (WebCore::RenderPath::paint):
1545         (WebCore::DrawMarkersData::DrawMarkersData):
1546         (WebCore::RenderPath::drawMarkersIfNeeded):
1547         * rendering/RenderSVGContainer.cpp:
1548         (WebCore::RenderSVGContainer::paint):
1549         * rendering/RenderSVGImage.cpp:
1550         (WebCore::RenderSVGImage::paint):
1551         * rendering/SVGInlineFlowBox.cpp:
1552         (WebCore::paintSVGInlineFlow):
1553
1554 2006-10-30  John Sullivan  <sullivan@apple.com>
1555
1556         Reviewed by Geoff Garen.
1557         
1558         Moved spelling-related methods from bridge to EditorClient. Added one not-yet-used
1559         grammar-related method.
1560
1561         * bridge/EditorClient.h:
1562         declare isContinuousSpellCheckingEnabled(), spellCheckerDocumentTag(), and new
1563         isGrammarCheckingEnabled()
1564         
1565         * bridge/mac/WebCoreFrameBridge.h:
1566         removed bridge equivalents
1567
1568         * bridge/mac/FrameMac.mm:
1569         (WebCore::FrameMac::advanceToNextMisspelling):
1570         convert bridge-using code to editor()->client()-using code
1571         (WebCore::FrameMac::markMisspellingsInAdjacentWords):
1572         ditto
1573         (WebCore::FrameMac::markMisspellings):
1574         ditto
1575         (WebCore::FrameMac::respondToChangedSelection):
1576         ditto
1577         
1578         * editing/Editor.h:
1579         * editing/Editor.cpp:
1580         (WebCore::Editor::client):
1581         new method, returns EditorClient pointer. In an ideal world all the code that needed to
1582         access the EditorClient would be in Editor.cpp, and we wouldn't need this accessor.
1583         But for now it's too tricky to extricate the spelling-related code from FrameMac.mm.
1584
1585 2006-10-30  Geoffrey Garen  <ggaren@apple.com>
1586
1587         Reviewed by Darin.
1588
1589         Removed a number of editing and selection methods from the bridge.
1590         
1591         I moved cross-platform editing and selection code into Editor and 
1592         SelectionController, respecitvely.
1593
1594         I moved ObjC and AppKit stuff up into WebKit, so I ended up exporting
1595         everything + the kitchen sink.
1596         
1597         Specific comments below for interesting things.
1598         
1599         * bindings/objc/DOMInternal.h: Moved exception handling helper methods into
1600         a new file so that WebKit can use them, too. Added a helper method for
1601         handling exceptions when selecting a Range.
1602         * bridge/mac/FrameMac.h: Moved attributedString creation and helper functions into 
1603         WebKit, since they have to do with creating an NSAttributedString for API
1604         consumption, and not much to do with general Frame functionality.
1605         * editing/Editor.h: Moved lastEditCommand tracking (at least the data,
1606         for now) into the Editor. Eventually, the Frame will not have to notify 
1607         the Editor of what the lastEditCommand was, since the Editor will perform
1608         all EditCommands.
1609         * editing/SelectionController.h: The code here is just stuff moved from the bridge.
1610         * editing/SelectionController.cpp:
1611         (WebCore::SelectionController::setSelectedRange): We now explicitly check from DOM exceptions
1612         and return them. The bridge method to select a DOM range did this implicitly,
1613         since all ObjC DOM operations handle DOM exceptions by throwing them as
1614         ObjC exceptions.
1615         * editing/TextAffinity.h: Added helper functions for conversion to NSSelectionAffinity.
1616         The two enumerations are numerically identical, but that's an implementation
1617         detail of TextAffinity that clients shouldn't be required to know about.
1618
1619 2006-10-30  Timothy Hatcher  <timothy@apple.com>
1620
1621         Rolling out the following change because this crash:
1622         <rdar://problem/4806705> REGRESSION: Crash occurs at WebCore::Font::lineSpacing() when loading site (http://www.photoplusexpo.com/ppe/index.jsp) 
1623
1624         And this regression:
1625         <rdar://problem/4728514> REGRESSION: Safari applies the wrong font to BODY element at http://www.apple.com/downloads/dashboard/
1626
1627     2006-09-06  David Harrison  <harrison@apple.com>
1628
1629         Reviewed and tweaked by Tim H. 
1630
1631         <rdar://problem/4564955> WebKit doesn't trigger Auto Font Activation 
1632
1633         If we don't find the font in the available fonts list, call [NSFont fontWithName:size:] 
1634         to trigger a search that will include auto activation. No PLT or iBench perf impact. 
1635         No layout tests affected. Not testable in an automated way that will work on all systems. 
1636
1637         * platform/mac/WebFontCache.mm: 
1638         (+[WebFontCache fontWithFamily:traits:size:]): 
1639
1640 2006-10-30  Justin Garcia  <justin.garcia@apple.com>
1641
1642         Reviewed by harrison
1643
1644         <rdar://problem/4808375>
1645         REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) (11460)
1646
1647         * editing/TextIterator.cpp:
1648         (WebCore::TextIterator::exitNode): Only create VisiblePositions
1649         when we're going to use them to create a range for an emitted character.
1650         We should further speed TextIterators up by avoiding creating VisiblePositions
1651         for TIs that are only used for the characters they emit (like the one that 
1652         plainText uses).
1653
1654 2006-10-30  Sam Weinig  <sam.weinig@gmail.com>
1655
1656         Reviewed by Mitz.
1657
1658         Fix for http://bugs.webkit.org/show_bug.cgi?id=11441
1659         More rendering code cleaning
1660
1661         * WebCore.xcodeproj/project.pbxproj:
1662         * rendering/RenderApplet.cpp:
1663         (WebCore::RenderApplet::RenderApplet):
1664         (WebCore::RenderApplet::createWidgetIfNecessary):
1665         * rendering/RenderApplet.h:
1666         * rendering/RenderArena.cpp:
1667         (WebCore::):
1668         (WebCore::RenderArena::RenderArena):
1669         (WebCore::RenderArena::allocate):
1670         (WebCore::RenderArena::free):
1671         * rendering/RenderArena.h:
1672         * rendering/RenderBR.cpp:
1673         (WebCore::RenderBR::RenderBR):
1674         (WebCore::RenderBR::baselinePosition):
1675         (WebCore::RenderBR::lineHeight):
1676         (WebCore::RenderBR::setStyle):
1677         (WebCore::RenderBR::caretMinOffset):
1678         (WebCore::RenderBR::positionForCoordinates):
1679         (WebCore::RenderBR::inlineBox):
1680         * rendering/RenderBR.h:
1681         * rendering/RenderBlock.cpp:
1682         * rendering/RenderBlock.h:
1683         (WebCore::RenderBlock::maxTopMargin):
1684         (WebCore::RenderBlock::maxBottomMargin):
1685         (WebCore::RenderBlock::initMaxMarginValues):
1686         (WebCore::RenderBlock::containsFloats):
1687         (WebCore::RenderBlock::setHasMarkupTruncation):
1688         (WebCore::RenderBlock::BlockSelectionInfo::BlockSelectionInfo):
1689         (WebCore::RenderBlock::BlockSelectionInfo::block):
1690         (WebCore::RenderBlock::BlockSelectionInfo::state):
1691         (WebCore::RenderBlock::FloatingObject::FloatingObject):
1692         (WebCore::RenderBlock::CompactInfo::clear):
1693         * rendering/RenderButton.cpp:
1694         (WebCore::RenderButton::removeChild):
1695         (WebCore::RenderButton::paintObject):
1696         * rendering/RenderButton.h:
1697         (WebCore::RenderButton::renderName):
1698         (WebCore::RenderButton::removeLeftoverAnonymousBoxes):
1699         * rendering/RenderContainer.cpp:
1700         (WebCore::RenderContainer::RenderContainer):
1701         * rendering/RenderContainer.h:
1702         (WebCore::RenderContainer::firstChild):
1703         (WebCore::RenderContainer::lastChild):
1704         (WebCore::RenderContainer::calcMinMaxWidth):
1705         * rendering/RenderCounter.cpp:
1706         (WebCore::RenderCounter::RenderCounter):
1707         (WebCore::toRoman):
1708         (WebCore::toHebrew):
1709         (WebCore::RenderCounter::calcMinMaxWidth):
1710         * rendering/RenderCounter.h:
1711         * rendering/RenderFieldset.cpp:
1712         (WebCore::RenderFieldset::paintBoxDecorations):
1713         (WebCore::RenderFieldset::paintBorderMinusLegend):
1714         (WebCore::RenderFieldset::setStyle):
1715         * rendering/RenderFileUploadControl.cpp:
1716         (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
1717         (WebCore::RenderFileUploadControl::setStyle):
1718         (WebCore::RenderFileUploadControl::paintObject):
1719         (WebCore::RenderFileUploadControl::calcMinMaxWidth):
1720         * rendering/RenderFileUploadControl.h:
1721         (WebCore::RenderFileUploadControl::renderName):
1722         * rendering/RenderFlexibleBox.h:
1723         * rendering/RenderFlow.cpp:
1724         * rendering/RenderFlow.h:
1725         * rendering/RenderForeignObject.cpp:
1726         (WebCore::RenderForeignObject::RenderForeignObject):
1727         (WebCore::RenderForeignObject::paint):
1728         (WebCore::RenderForeignObject::computeAbsoluteRepaintRect):
1729         (WebCore::RenderForeignObject::layout):
1730         (WebCore::RenderForeignObject::nodeAtPoint):
1731         * rendering/RenderForeignObject.h:
1732         (WebCore::RenderForeignObject::renderName):
1733         * rendering/RenderFormElement.cpp:
1734         (WebCore::RenderFormElement::setStyle):
1735         (WebCore::RenderFormElement::layout):
1736         (WebCore::RenderFormElement::textAlignment):
1737         * rendering/RenderFormElement.h:
1738         * rendering/RenderFrame.cpp:
1739         * rendering/RenderFrame.h:
1740         (WebCore::RenderFrame::element):
1741         * rendering/RenderFrameSet.cpp:
1742         * rendering/RenderFrameSet.h:
1743         (WebCore::RenderFrameSet::element):
1744         * rendering/RenderHTMLCanvas.cpp:
1745         (WebCore::RenderHTMLCanvas::RenderHTMLCanvas):
1746         (WebCore::RenderHTMLCanvas::paint):
1747         * rendering/RenderHTMLCanvas.h:
1748         (WebCore::RenderHTMLCanvas::renderName):
1749         * rendering/RenderImage.cpp:
1750         (WebCore::RenderImage::RenderImage):
1751         (WebCore::RenderImage::setStyle):
1752         (WebCore::RenderImage::setContentObject):
1753         (WebCore::RenderImage::setCachedImage):
1754         (WebCore::RenderImage::imageChanged):
1755         (WebCore::RenderImage::paint):
1756         (WebCore::RenderImage::layout):
1757         (WebCore::RenderImage::updateAltText):
1758         * rendering/RenderImage.h:
1759         (WebCore::RenderImage::element):
1760         * rendering/RenderInline.cpp:
1761         (WebCore::RenderInline::RenderInline):
1762         (WebCore::RenderInline::~RenderInline):
1763         (WebCore::RenderInline::setStyle):
1764         (WebCore::RenderInline::addChildToFlow):
1765         (WebCore::RenderInline::cloneInline):
1766         (WebCore::RenderInline::splitInlines):
1767         (WebCore::RenderInline::splitFlow):
1768         (WebCore::RenderInline::paint):
1769         (WebCore::RenderInline::absoluteRects):
1770         (WebCore::RenderInline::calcMinMaxWidth):
1771         (WebCore::RenderInline::requiresLayer):
1772         (WebCore::RenderInline::width):
1773         (WebCore::RenderInline::height):
1774         (WebCore::RenderInline::renderName):
1775         (WebCore::RenderInline::nodeAtPoint):
1776         (WebCore::RenderInline::positionForCoordinates):
1777         * rendering/RenderInline.h:
1778         (WebCore::RenderInline::layout):
1779         * rendering/RenderLayer.cpp:
1780         * rendering/RenderLayer.h:
1781         (WebCore::ClipRects::ClipRects):
1782         (WebCore::RenderLayer::nextSibling):
1783         (WebCore::RenderLayer::root):
1784         (WebCore::RenderLayer::setPos):
1785         (WebCore::RenderLayer::height):
1786         (WebCore::RenderLayer::relativePositionOffset):
1787         * rendering/RenderLineEdit.cpp:
1788         (WebCore::RenderLineEdit::setStyle):
1789         (WebCore::RenderLineEdit::updateFromElement):
1790         (WebCore::RenderLineEdit::selectionStart):
1791         (WebCore::RenderLineEdit::selectionEnd):
1792         (WebCore::RenderLineEdit::setSelectionStart):
1793         (WebCore::RenderLineEdit::setSelectionEnd):
1794         (WebCore::RenderLineEdit::setSelectionRange):
1795         * rendering/RenderLineEdit.h:
1796         * rendering/RenderListBox.cpp:
1797         * rendering/RenderListBox.h:
1798         (WebCore::RenderListBox::renderName):
1799         * rendering/RenderListItem.cpp:
1800         (WebCore::RenderListItem::setStyle):
1801         (WebCore::getParentOfFirstLineBox):
1802         (WebCore::RenderListItem::updateMarkerLocation):
1803         (WebCore::RenderListItem::positionListMarker):
1804         (WebCore::RenderListItem::paint):
1805         * rendering/RenderListItem.h:
1806         * rendering/RenderListMarker.cpp:
1807         * rendering/RenderListMarker.h:
1808         (WebCore::RenderListMarker::renderName):
1809         (WebCore::RenderListMarker::isListMarker):
1810
1811 2006-10-30  Timothy Hatcher  <timothy@apple.com>
1812
1813         Reviewed by Hyatt.
1814
1815         <rdar://problem/4478625> Basic table editing and culling
1816
1817         Refined the criteria for deletable elements, rely on the renderer more.
1818         Corrected the interface positioning for elements that have borders.
1819
1820         * editing/DeleteButtonController.cpp:
1821         (WebCore::isDeletableElement):
1822         (WebCore::DeleteButtonController::show):
1823
1824 2006-10-30  Darin Adler  <darin@apple.com>
1825
1826         - fix build
1827
1828         * loader/ResourceLoader.h: Added header guard.
1829
1830 2006-10-31  Darin Adler  <darin@apple.com>
1831
1832         Reviewed by Adam.
1833
1834         - fix FrameLoader files so they can be built on non-Mac platforms
1835
1836         * page/FramePrivate.h:
1837         (WebCore::FramePrivate::FramePrivate): Added code to create the frame loader.
1838         (WebCore::FramePrivate::~FramePrivate): Added code to delete the frame loader.
1839
1840         * page/Page.h:
1841         * page/Page.cpp: (WebCore::Page::setDefersLoading): Removed the
1842         #if PLATFORM(MAC) that Adam added as a stop-gap when I did this wrong
1843         the other day.
1844
1845         * bridge/mac/FrameMac.mm:
1846         (WebCore::FrameMac::FrameMac): Removed code to create the frame loader.
1847         (WebCore::FrameMac::~FrameMac): Removed code to delete the frame loader.
1848
1849         * loader/FrameLoader.h: Changed import to include, added #if PLATFORM(MAC)
1850         around the PolicyCheck definition.
1851
1852         * loader/FormState.cpp: Changed import to include.
1853         * loader/FrameLoader.cpp: Ditto.
1854         * loader/MainResourceLoader.h: Ditto.
1855
1856         * loader/FrameLoaderTypes.h: Added a header guard.
1857
1858         * loader/NetscapePlugInStreamLoader.h: Changed import to include.
1859         Added #if PLATFORM(MAC) around Mac-specific details.
1860         * loader/SubresourceLoader.h: Ditto.
1861
1862         * page/Frame.cpp: (WebCore::Frame::loader): Updated name of loader to
1863         m_loader from m_frameLoader.
1864
1865         * CMakeLists.txt: Updated.
1866         * WebCoreSources.bkl: Updated.
1867
1868 2006-10-30  Nikolas Zimmermann  <zimmermann@kde.org>
1869
1870         Reviewed and landed by Anders.
1871
1872         Patch by Zack rusin to fix: 
1873         http://bugs.webkit.org/show_bug.cgi?id=11429
1874
1875         Fix startup crash.
1876
1877         * platform/qt/FrameQtClient.cpp:
1878         (WebCore::FrameQtClientDefault::openURL):
1879
1880 2006-10-30  Zach Rusin  <zack@kde.org>
1881
1882         Reviewed and landed by Anders.
1883
1884         * platform/network/qt/ResourceHandleQt.cpp:
1885         (WebCore::ResourceHandle::receivedResponse):
1886         * platform/qt/FrameQtClient.cpp:
1887         (WebCore::FrameQtClientDefault::FrameQtClientDefault):
1888         * platform/qt/LoaderFunctionsQt.cpp:
1889         (WebCore::ServeSynchronousRequest):
1890         More build fixes.
1891
1892 2006-10-30  Simon Hausmann  <hausmann@kde.org>
1893
1894         Reviewed and landed by Anders.
1895         
1896         - fix Qt build
1897         * platform/qt/FrameQtClient.cpp: ResourceLoaderClient ->
1898         ResourceHandleClient
1899
1900 2006-10-30  Darin Adler  <darin@apple.com>
1901
1902         Reviewed by John Sullivan.
1903
1904         - work toward removing Objective-C data types from FrameLoader.h:
1905           removed NSDate, NSString, WebCorePageState, WebCoreResourceLoader,
1906           and WebCoreResourceHandle
1907         - moved bodyBackgroundColor function from Frame to WebFrame in WebKit
1908
1909         * page/PageState.h:
1910         * page/PageState.cpp: Added, C++ class with much of what WebCorePageState had.
1911
1912         * bridge/mac/FrameMac.h: Removed uneeeded declarations and bodyBackgroundColor().
1913         * bridge/mac/FrameMac.mm: (WebCore::FrameMac::startRedirectionTimer): Use a
1914         double for the date instead of an NSDate.
1915
1916         * bridge/mac/WebCoreFrameBridge.h:
1917         * bridge/mac/WebCoreFrameBridge.mm: Removed invalidatePageCache and
1918         saveDocumentToPageCache methods.
1919
1920         * bridge/mac/WebCorePageState.h:
1921         * bridge/mac/WebCorePageState.mm: Removed most of the class and turned it into
1922         an Objective-C wrapper for PageState.
1923
1924         * loader/FrameLoader.h: Removed unused Objective-C types, eliminated use of
1925         NSDate and WebCorePageState.
1926         * loader/FrameLoaderClient.h: Changed NSDate to double.
1927         * loader/mac/FrameLoaderMac.mm:
1928         (WebCore::FrameLoader::receivedMainResourceError): Moved call to setInPageCache
1929         here that used to be in invalidateCurrentItemPageCache on the WebKit side.
1930         (WebCore::FrameLoader::clientRedirected): Changed NSDate to double for date.
1931         (WebCore::FrameLoader::open): Moved one of the open functions that was part of
1932         commitProvisionalLoad inside the commitProvisionalLoad function, so that it can
1933         extract the parameters from the response. Changed the open function that takes
1934         a PageState to use the new C++ PageState.
1935         (WebCore::FrameLoader::commitProvisionalLoad): Added the code from the open
1936         function; tightened up logic, removing a few cases that could never happen, as
1937         well as the unused reload boolean.
1938
1939         * ForwardingHeaders/kjs/property_map.h: Added.
1940
1941         * WebCore.exp: Updated.
1942         * WebCore.xcodeproj/project.pbxproj: Updated.
1943
1944 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
1945
1946         Reviewed by Anders.
1947
1948         - added ResourceResponse class and didReceiveResponse delegate call
1949         
1950         * WebCore.xcodeproj/project.pbxproj: Added new files.
1951         * bridge/mac/WebCoreFrameBridge.h: Removed no longer needed
1952         expiresTimeForResponse: method.
1953         * dom/XMLTokenizer.cpp:
1954         (WebCore::openFunc): Updated to use ResourceResponse.
1955         * loader/FrameLoader.h: Update loadResourceSynchronously to
1956         use ResourceResponse.
1957         * loader/LoaderFunctions.h:
1958         * loader/icon/IconLoader.cpp:
1959         (IconLoader::didReceiveResponse): Updated from receivedResponse
1960         and made cross-platform.
1961         * loader/icon/IconLoader.h: updated for above change
1962         * loader/loader.cpp:
1963         (WebCore::Loader::receivedResponse): reduced to just saving
1964         the PlatformResponse (ideally we'd phase out use of this).
1965         (WebCore::Loader::didReceivedResponse): most of the ReceivedResponse 
1966         logic.
1967         * loader/loader.h:
1968         * loader/mac/FrameLoaderMac.mm:
1969         (WebCore::FrameLoader::loadResourceSynchronously): Return results
1970         as ResourceResponse.
1971         * loader/mac/IconLoaderMac.mm: remove receivedResponse.
1972         * loader/mac/LoaderFunctionsMac.mm:
1973         (WebCore::ServeSynchronousRequest): take ResourceResponse as
1974         argument.
1975         * platform/network/ResourceHandle.cpp:
1976         * platform/network/ResourceHandle.h: Remove calls for
1977         broken out response pieces.
1978         * platform/network/ResourceHandleClient.h:
1979         (WebCore::ResourceHandleClient::didReceiveResponse): New
1980         delegate method.
1981         * platform/network/ResourceHandleInternal.h:
1982         (WebCore::ResourceHandleInternal::ResourceHandleInternal): Remove
1983         storage of response bits, we're not gonna return them
1984         seprately any more.
1985         * platform/network/ResourceResponse.h: Added.
1986         (WebCore::ResourceResponse::ResourceResponse): Freshly
1987         implemented. Same for below.
1988         (WebCore::ResourceResponse::url):
1989         (WebCore::ResourceResponse::mimeType):
1990         (WebCore::ResourceResponse::expectedContentLength):
1991         (WebCore::ResourceResponse::textEncodingName):
1992         (WebCore::ResourceResponse::suggestedFilename):
1993         (WebCore::ResourceResponse::httpStatusCode):
1994         (WebCore::ResourceResponse::setHTTPStatusCode):
1995         (WebCore::ResourceResponse::httpHeaderField):
1996         (WebCore::ResourceResponse::httpHeaderFields):
1997         (WebCore::ResourceResponse::isMultipart):
1998         (WebCore::ResourceResponse::setExpirationDate):
1999         (WebCore::ResourceResponse::expirationDate):
2000         * platform/network/cf/ResourceHandleCFNet.cpp:
2001         (WebCore::didReceiveResponse): Send didReceiveResponse
2002         client method.
2003         * platform/network/cf/ResourceResponseCFNet.h: Added.
2004         * platform/network/cf/ResourceResponseCFNet.mm: Added.
2005         (getResourceResponse): Helper function to get a ResourceResponse 
2006         from CFURLResponseRef.
2007         * platform/network/mac/ResourceHandleMac.mm:
2008         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2009         Don't bother cleaning up fields we no longer have.
2010         (WebCore::ResourceHandle::receivedResponse): Send
2011         didReceiveResponse client method.
2012         * platform/network/mac/ResourceResponseMac.h: Added.
2013         * platform/network/mac/ResourceResponseMac.mm: Added.
2014         (getResourceResponse): Helper function to get a ResourceResponse 
2015         from an NSURLResponse*.
2016         * rendering/HitTestResult.cpp:
2017         * xml/XSLTProcessor.cpp:
2018         (WebCore::docLoaderFunc): Prepare for use of ResourceResponse.
2019         * xml/xmlhttprequest.cpp:
2020         (WebCore::XMLHttpRequest::getResponseText): Store http response
2021         info in the form of a ResourceResponse, change all methods to
2022         account for this.
2023         (WebCore::XMLHttpRequest::getResponseXML):
2024         (WebCore::XMLHttpRequest::XMLHttpRequest):
2025         (WebCore::XMLHttpRequest::open):
2026         (WebCore::XMLHttpRequest::send):
2027         (WebCore::XMLHttpRequest::getAllResponseHeaders):
2028         (WebCore::XMLHttpRequest::getResponseHeader):
2029         (WebCore::XMLHttpRequest::getStatus):
2030         (WebCore::XMLHttpRequest::getStatusText):
2031         (WebCore::XMLHttpRequest::processSyncLoadResults):
2032         (WebCore::XMLHttpRequest::didFinishLoading):
2033         (WebCore::XMLHttpRequest::didReceiveResponse):
2034         (WebCore::XMLHttpRequest::didReceiveData):
2035         * xml/xmlhttprequest.h:
2036
2037 2006-10-29  Darin Adler  <darin@apple.com>
2038
2039         - fix build
2040
2041         * loader/DocumentLoader.h: Add declarations so this compiles without ObjC.
2042         * loader/NetscapePlugInStreamLoader.h: Ditto.
2043         * loader/ResourceLoader.h: Ditto.
2044
2045 2006-10-29  Darin Adler  <darin@apple.com>
2046
2047         - one last name change -- WebFormState.h to FormState.h
2048         - added more empty placeholder platform-independent files
2049           for currently-Mac-specific loader classes
2050
2051         * loader/FormState.cpp: Updated include.
2052         * loader/FrameLoader.cpp: Updated include.
2053         * loader/mac/FrameLoaderMac.mm: Updated include.
2054
2055         * loader/WebFormState.h: Removed.
2056         * loader/FormState.h: Added.
2057
2058         * loader/DocumentLoader.cpp: Added.
2059         * loader/MainResourceLoader.cpp: Added.
2060         * loader/NetscapePlugInStreamLoader.cpp: Added.
2061         * loader/ResourceLoader.cpp: Added.
2062         * loader/SubresourceLoader.cpp: Added.
2063
2064         * WebCore.xcodeproj/project.pbxproj: Updated for changes above.
2065
2066 2006-10-29  Darin Adler  <darin@apple.com>
2067
2068         - did the do-webcore-rename renames, including a number of changes
2069           to the names of loader files (and WebResourceLoader -> ResourceLoader),
2070           jScript() to scriptProxy(), jScriptEnabled() to javaScriptEnabled(),
2071           and improvements to the names of decoder classes and their source
2072           files (Decoder -> TextResourceDecoder, StreamingTextDecoder -> TextCodec)
2073
2074         * CMakeLists.txt:
2075         * WebCore.exp:
2076         * WebCore.vcproj/WebCore/WebCore.vcproj:
2077         * WebCore.xcodeproj/project.pbxproj:
2078         * WebCoreSources.bkl:
2079         * bindings/js/kjs_binding.cpp:
2080         (KJS::ScriptInterpreter::updateDOMNodeDocument):
2081         * bindings/js/kjs_events.cpp:
2082         (KJS::JSAbstractEventListener::handleEvent):
2083         (KJS::JSLazyEventListener::parseCode):
2084         * bindings/js/kjs_html.cpp:
2085         (KJS::JSHTMLElement::implementsCall):
2086         * bindings/js/kjs_traversal.cpp:
2087         (KJS::JSNodeFilterCondition::acceptNode):
2088         * bindings/js/kjs_window.cpp:
2089         (KJS::Window::interpreter):
2090         (KJS::Window::retrieveWindow):
2091         (KJS::Window::retrieve):
2092         (KJS::ScheduledAction::execute):
2093         * bindings/objc/DOMInternal.mm:
2094         (-[WebScriptObject _initializeScriptDOMNodeImp]):
2095         * bridge/mac/FrameMac.mm:
2096         (WebCore::FrameMac::executionContextForDOM):
2097         (WebCore::FrameMac::bindingRootObject):
2098         (WebCore::FrameMac::windowScriptObject):
2099         (WebCore::FrameMac::windowScriptNPObject):
2100         (WebCore::FrameMac::partClearedInBegin):
2101         * bridge/mac/WebCoreEncodings.mm:
2102         * bridge/mac/WebCoreFrameBridge.mm:
2103         (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
2104         (-[WebCoreFrameBridge stringWithData:]):
2105         (-[WebCoreFrameBridge executionContextForView:]):
2106         * bridge/win/FrameWin.cpp:
2107         * dom/Document.cpp:
2108         (WebCore::Document::inputEncoding):
2109         (WebCore::Document::setCharset):
2110         (WebCore::Document::createHTMLEventListener):
2111         (WebCore::Document::setDecoder):
2112         * dom/Document.h:
2113         (WebCore::Document::decoder):
2114         * dom/EventTargetNode.cpp:
2115         (WebCore::EventTargetNode::dispatchGenericEvent):
2116         * html/HTMLParser.cpp:
2117         (WebCore::HTMLParser::noscriptCreateErrorCheck):
2118         (WebCore::HTMLParser::canvasCreateErrorCheck):
2119         (WebCore::HTMLParser::isInline):
2120         * html/HTMLPlugInElement.cpp:
2121         (WebCore::HTMLPlugInElement::createNPObject):
2122         * html/HTMLScriptElement.cpp:
2123         (WebCore::HTMLScriptElement::evaluateScript):
2124         * html/HTMLTokenizer.cpp:
2125         (WebCore::HTMLTokenizer::parseTag):
2126         (WebCore::HTMLTokenizer::processToken):
2127         * ksvg2/misc/SVGDocumentExtensions.cpp:
2128         (WebCore::SVGDocumentExtensions::createSVGEventListener):
2129         * loader/CachedCSSStyleSheet.cpp:
2130         (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
2131         (WebCore::CachedCSSStyleSheet::setEncoding):
2132         * loader/CachedCSSStyleSheet.h:
2133         * loader/CachedXBLDocument.cpp:
2134         (WebCore::CachedXBLDocument::CachedXBLDocument):
2135         (WebCore::CachedXBLDocument::setEncoding):
2136         * loader/CachedXBLDocument.h:
2137         * loader/CachedXSLStyleSheet.cpp:
2138         (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
2139         (WebCore::CachedXSLStyleSheet::setEncoding):
2140         * loader/CachedXSLStyleSheet.h:
2141         * loader/Decoder.cpp: Removed.
2142         * loader/Decoder.h: Removed.
2143         * loader/FrameLoader.cpp:
2144         * loader/FrameLoader.h:
2145         * loader/FrameLoaderClient.h:
2146         * loader/MainResourceLoader.h: Added.
2147         * loader/NetscapePlugInStreamLoader.h: Added.
2148         * loader/Request.h:
2149         (WebCore::Request::cachedResource):
2150         * loader/ResourceLoader.h: Added.
2151         * loader/SubresourceLoader.h: Added.
2152         * loader/TextResourceDecoder.cpp: Added.
2153         (WebCore::TextResourceDecoder::determineContentType):
2154         (WebCore::TextResourceDecoder::defaultEncoding):
2155         (WebCore::TextResourceDecoder::TextResourceDecoder):
2156         (WebCore::TextResourceDecoder::~TextResourceDecoder):
2157         (WebCore::TextResourceDecoder::setEncoding):
2158         (WebCore::TextResourceDecoder::checkForBOM):
2159         (WebCore::TextResourceDecoder::checkForCSSCharset):
2160         (WebCore::TextResourceDecoder::checkForHeadCharset):
2161         (WebCore::TextResourceDecoder::detectJapaneseEncoding):
2162         (WebCore::TextResourceDecoder::decode):
2163         (WebCore::TextResourceDecoder::flush):
2164         * loader/TextResourceDecoder.h: Added.
2165         * loader/WebDocumentLoader.h: Removed.
2166         * loader/WebLoader.h: Removed.
2167         * loader/WebMainResourceLoader.h: Removed.
2168         * loader/WebNetscapePlugInStreamLoader.h: Removed.
2169         * loader/WebSubresourceLoader.h: Removed.
2170         * loader/loader.cpp:
2171         (WebCore::Loader::servePendingRequests):
2172         (WebCore::Loader::receivedAllData):
2173         (WebCore::Loader::receivedResponse):
2174         (WebCore::Loader::didReceiveData):
2175         (WebCore::Loader::cancelRequests):
2176         (WebCore::Loader::jobForRequest):
2177         * loader/mac/DocumentLoaderMac.mm:
2178         * loader/mac/FormDataStream.m: Added.
2179         * loader/mac/FrameLoaderMac.mm:
2180         (WebCore::FrameLoader::cancelPendingArchiveLoad):
2181         (WebCore::FrameLoader::addPlugInStreamLoader):
2182         (WebCore::FrameLoader::removePlugInStreamLoader):
2183         (WebCore::FrameLoader::addSubresourceLoader):
2184         (WebCore::FrameLoader::removeSubresourceLoader):
2185         (WebCore::FrameLoader::willSendRequest):
2186         (WebCore::FrameLoader::didReceiveAuthenticationChallenge):
2187         (WebCore::FrameLoader::didCancelAuthenticationChallenge):
2188         (WebCore::FrameLoader::didReceiveResponse):
2189         (WebCore::FrameLoader::didReceiveData):
2190         (WebCore::FrameLoader::didFinishLoad):
2191         (WebCore::FrameLoader::didFailToLoad):
2192         (WebCore::FrameLoader::open):
2193         (WebCore::FrameLoader::willUseArchive):
2194         (WebCore::FrameLoader::isArchiveLoadPending):
2195         * loader/mac/ImageDocumentMac.mm:
2196         * loader/mac/LoaderFunctionsMac.mm:
2197         (WebCore::CheckCacheObjectStatus):
2198         * loader/mac/MainResourceLoaderMac.mm:
2199         (WebCore::MainResourceLoader::MainResourceLoader):
2200         (WebCore::MainResourceLoader::releaseDelegate):
2201         (WebCore::MainResourceLoader::didCancel):
2202         (WebCore::MainResourceLoader::addData):
2203         (WebCore::MainResourceLoader::willSendRequest):
2204         (WebCore::MainResourceLoader::continueAfterContentPolicy):
2205         (WebCore::MainResourceLoader::didReceiveData):
2206         (WebCore::MainResourceLoader::didFinishLoading):
2207         (WebCore::MainResourceLoader::setDefersLoading):
2208         * loader/mac/NetscapePlugInStreamLoaderMac.mm:
2209         (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
2210         (WebCore::NetscapePlugInStreamLoader::releaseResources):
2211         (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
2212         (WebCore::NetscapePlugInStreamLoader::didReceiveData):
2213         (WebCore::NetscapePlugInStreamLoader::didFinishLoading):
2214         (WebCore::NetscapePlugInStreamLoader::didFail):
2215         (WebCore::NetscapePlugInStreamLoader::didCancel):
2216         * loader/mac/ResourceLoaderMac.mm:
2217         (WebCore::ResourceLoader::ResourceLoader):
2218         (WebCore::ResourceLoader::~ResourceLoader):
2219         (WebCore::ResourceLoader::releaseResources):
2220         (WebCore::ResourceLoader::load):
2221         (WebCore::ResourceLoader::setDefersLoading):
2222         (WebCore::ResourceLoader::frameLoader):
2223         (WebCore::ResourceLoader::addData):
2224         (WebCore::ResourceLoader::resourceData):
2225         (WebCore::ResourceLoader::clearResourceData):
2226         (WebCore::ResourceLoader::willSendRequest):
2227         (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
2228         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
2229         (WebCore::ResourceLoader::didReceiveResponse):
2230         (WebCore::ResourceLoader::didReceiveData):
2231         (WebCore::ResourceLoader::willStopBufferingData):
2232         (WebCore::ResourceLoader::didFinishLoading):
2233         (WebCore::ResourceLoader::didFinishLoadingOnePart):
2234         (WebCore::ResourceLoader::didFail):
2235         (WebCore::ResourceLoader::willCacheResponse):
2236         (WebCore::ResourceLoader::didCancel):
2237         (WebCore::ResourceLoader::cancel):
2238         (WebCore::ResourceLoader::setIdentifier):
2239         (WebCore::ResourceLoader::response):
2240         (WebCore::ResourceLoader::inConnectionCallback):
2241         (WebCore::ResourceLoader::cancelledError):
2242         (WebCore::ResourceLoader::receivedCredential):
2243         (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential):
2244         (WebCore::ResourceLoader::receivedCancellation):
2245         (WebCore::ResourceLoader::delegate):
2246         (WebCore::ResourceLoader::releaseDelegate):
2247         (-[WebCoreResourceLoaderAsDelegate initWithLoader:]):
2248         * loader/mac/SubresourceLoaderMac.mm:
2249         (WebCore::SubresourceLoader::SubresourceLoader):
2250         (WebCore::SubresourceLoader::willSendRequest):
2251         (WebCore::SubresourceLoader::didReceiveResponse):
2252         (WebCore::SubresourceLoader::didReceiveData):
2253         (WebCore::SubresourceLoader::didFinishLoading):
2254         (WebCore::SubresourceLoader::didFail):
2255         (WebCore::SubresourceLoader::didCancel):
2256         * loader/mac/WebFormDataStream.h: Removed.
2257         * loader/mac/WebFormDataStream.m: Removed.
2258         * page/Frame.cpp:
2259         (WebCore::Frame::javaScriptEnabled):
2260         (WebCore::Frame::scriptProxy):
2261         (WebCore::Frame::executeScript):
2262         (WebCore::Frame::write):
2263         (WebCore::Frame::userGestureHint):
2264         (WebCore::Frame::saveInterpreterBuiltins):
2265         (WebCore::Frame::restoreInterpreterBuiltins):
2266         (WebCore::Frame::backslashAsCurrencySymbol):
2267         * page/Frame.h:
2268         * page/FramePrivate.h:
2269         * platform/StreamingTextDecoder.cpp: Removed.
2270         * platform/StreamingTextDecoder.h: Removed.
2271         * platform/StreamingTextDecoderICU.cpp: Removed.
2272         * platform/StreamingTextDecoderICU.h: Removed.
2273         * platform/TextCodec.cpp: Added.
2274         * platform/TextCodec.h: Added.
2275         * platform/TextCodecICU.cpp: Added.
2276         * platform/TextCodecICU.h: Added.
2277         * platform/TextCodecLatin1.h:
2278         * platform/TextCodecUTF16.h:
2279         * platform/TextDecoder.h:
2280         * platform/TextEncoding.cpp:
2281         * platform/TextEncodingRegistry.cpp:
2282         * platform/image-decoders/jpeg/jmorecfg.h:
2283         * platform/mac/StreamingTextDecoderMac.cpp: Removed.
2284         * platform/mac/StreamingTextDecoderMac.h: Removed.
2285         * platform/mac/TextCodecMac.cpp: Added.
2286         * platform/mac/TextCodecMac.h: Added.
2287         * platform/network/ResourceHandleInternal.h:
2288         * platform/network/mac/ResourceHandleMac.mm:
2289         * platform/qt/FrameQt.cpp:
2290         (WebCore::FrameQt::bindingRootObject):
2291         * platform/qt/LoaderFunctionsQt.cpp:
2292         (WebCore::CheckCacheObjectStatus):
2293         * rendering/RenderObject.cpp:
2294         (WebCore::RenderObject::backslashAsCurrencySymbol):
2295         * xml/XSLTProcessor.cpp:
2296         (WebCore::XSLTProcessor::createDocumentFromSource):
2297         * xml/xmlhttprequest.cpp:
2298         (WebCore::XMLHttpRequest::didReceiveData):
2299         * xml/xmlhttprequest.h:
2300
2301 2006-10-29  Darin Adler  <darin@apple.com>
2302
2303         Rubber stamped by Adam (kinda).
2304
2305         - add Mac suffixes and correct filenames inside loader/mac
2306
2307         * WebCore.xcodeproj/project.pbxproj: Updated for changes below.
2308
2309         * loader/mac/FrameLoader.mm: Removed.
2310         * loader/mac/WebDocumentLoader.mm: Removed.
2311         * loader/mac/WebLoader.mm: Removed.
2312         * loader/mac/WebMainResourceLoader.mm: Removed.
2313         * loader/mac/WebNetscapePlugInStreamLoader.mm: Removed.
2314         * loader/mac/WebSubresourceLoader.mm: Removed.
2315
2316         * loader/mac/FrameLoaderMac.mm: Added.
2317         * loader/mac/DocumentLoaderMac.mm: Added.
2318         * loader/mac/ResourceLoaderMac.mm: Added.
2319         * loader/mac/MainResourceLoaderMac.mm: Added.
2320         * loader/mac/WebNetscapePlugInStreamLoaderMac.mm: Added.
2321         * loader/mac/SubresourceLoaderMac.mm: Removed.
2322
2323 2006-10-29  Darin Adler  <darin@apple.com>
2324
2325         Reviewed by Adam.
2326
2327         - moving towards use of FrameLoader cross-platform; get FrameLoader.h
2328           and FrameLoader.cpp mostly ready
2329
2330         * WebCore.xcodeproj/project.pbxproj: Added FrameLoader.cpp and
2331         FormState.cpp. Removed WebFormState.mm.
2332
2333         * loader/FrameLoader.h: Put in lots of #if statements to see if we can
2334         get this header compiling on non-Mac.
2335         * loader/FrameLoader.cpp: Added. Has non-Mac-specific bits of FrameLoader.
2336         * loader/mac/FrameLoader.mm: Moved some non-Mac-specific bits out.
2337
2338         * loader/FrameLoaderClient.h: Added some ifdefs.
2339         * loader/WebDocumentLoader.h: Ditto.
2340         * loader/WebLoader.h: Ditto.
2341         * loader/WebMainResourceLoader.h: Ditto.
2342
2343         * loader/mac/WebDocumentLoader.mm:
2344         (WebCore::DocumentLoader::isLoadingInAPISense):
2345         Rewrote to work without bridge, partly to remove the need for ObjC
2346         bridge type in the header, and also because we're tearing down the bridge.
2347
2348         * loader/mac/WebMainResourceLoader.mm:
2349         (WebCore::MainResourceLoader::MainResourceLoader): Removed unused
2350         m_contentLength and m_bytesReceived.
2351         (WebCore::MainResourceLoader::didReceiveResponse): Ditto.
2352         (WebCore::MainResourceLoader::didReceiveData): Ditto.
2353
2354         * bridge/mac/WebCoreFrameBridge.h: Removed doneProcessingData.
2355         * bridge/mac/WebCoreFrameBridge.mm: Ditto.
2356
2357         * loader/mac/FormState.mm: Removed.
2358         * loader/FormState.cpp: Added.
2359
2360 2006-10-29  Darin Adler  <darin@apple.com>
2361
2362         Rubber stamped by Adam.
2363
2364         - moving towards use of FrameLoader cross-platform; move the headers
2365           for the Mac loader from loader/mac into loader, in preparation for
2366           making them useful on non-Mac
2367
2368         * WebCore.xcodeproj/project.pbxproj:
2369
2370         * loader/mac/FrameLoader.h: Removed.
2371         * loader/mac/WebDocumentLoader.h: Removed.
2372         * loader/mac/WebFormState.h: Removed.
2373         * loader/mac/WebLoader.h: Removed.
2374         * loader/mac/WebMainResourceLoader.h: Removed.
2375         * loader/mac/WebNetscapePlugInStreamLoader.h: Removed.
2376         * loader/mac/WebSubresourceLoader.h: Removed.
2377
2378         * loader/FrameLoader.h: Added.
2379         * loader/WebDocumentLoader.h: Added.
2380         * loader/WebFormState.h: Added.
2381         * loader/WebLoader.h: Added.
2382         * loader/WebMainResourceLoader.h: Added.
2383         * loader/WebNetscapePlugInStreamLoader.h: Added.
2384         * loader/WebSubresourceLoader.h: Added.
2385
2386 2006-10-29  Adam Roben  <aroben@apple.com>
2387
2388         Reviewed by Geoff.
2389
2390         Finish Darin's clean up of the use of __APPLE__ in WebCore, begun in
2391         r17405.
2392
2393         * platform/DeprecatedString.h:
2394
2395 2006-10-29  Beth Dakin  <bdakin@apple.com>
2396
2397         Rubber stamped by Geoff.
2398
2399         This is a followup to my HitTestResult checkin. Most of the 
2400         HitTestResult local variables in the code were named i or info for 
2401         when the class was named NodeInfo. This patch renames all of these 
2402         local variables to result.
2403
2404         * dom/Document.cpp:
2405         (WebCore::Document::prepareMouseEvent):
2406         * html/HTMLAreaElement.cpp:
2407         (WebCore::HTMLAreaElement::mapMouseEvent):
2408         * html/HTMLMapElement.cpp:
2409         (WebCore::HTMLMapElement::mapMouseEvent):
2410         * rendering/EllipsisBox.cpp:
2411         (WebCore::EllipsisBox::nodeAtPoint):
2412         * rendering/EllipsisBox.h:
2413         * rendering/InlineBox.cpp:
2414         (WebCore::InlineBox::nodeAtPoint):
2415         * rendering/InlineFlowBox.cpp:
2416         (WebCore::InlineFlowBox::nodeAtPoint):
2417         * rendering/InlineTextBox.cpp:
2418         (WebCore::InlineTextBox::nodeAtPoint):
2419         * rendering/RenderBlock.cpp:
2420         (WebCore::RenderBlock::isPointInScrollbar):
2421         (WebCore::RenderBlock::nodeAtPoint):
2422         * rendering/RenderBlock.h:
2423         * rendering/RenderBox.cpp:
2424         (WebCore::RenderBox::nodeAtPoint):
2425         * rendering/RenderBox.h:
2426         * rendering/RenderFlow.cpp:
2427         (WebCore::RenderFlow::hitTestLines):
2428         * rendering/RenderFlow.h:
2429         * rendering/RenderForeignObject.cpp:
2430         (WebCore::RenderForeignObject::nodeAtPoint):
2431         * rendering/RenderFrameSet.cpp:
2432         (WebCore::RenderFrameSet::nodeAtPoint):
2433         * rendering/RenderImage.cpp:
2434         (WebCore::RenderImage::nodeAtPoint):
2435         * rendering/RenderInline.cpp:
2436         (WebCore::RenderInline::nodeAtPoint):
2437         * rendering/RenderInline.h:
2438         * rendering/RenderLayer.cpp:
2439         (WebCore::RenderLayer::autoscroll):
2440         (WebCore::RenderLayer::hitTest):
2441         (WebCore::RenderLayer::hitTestLayer):
2442         (WebCore::RenderLayer::updateHoverActiveState):
2443         * rendering/RenderListBox.cpp:
2444         (WebCore::RenderListBox::isPointInScrollbar):
2445         * rendering/RenderObject.cpp:
2446         (WebCore::RenderObject::hitTest):
2447         (WebCore::RenderObject::setInnerNode):
2448         (WebCore::RenderObject::nodeAtPoint):
2449         * rendering/RenderObject.h:
2450         * rendering/RenderPath.cpp:
2451         (WebCore::RenderPath::nodeAtPoint):
2452         * rendering/RenderSVGImage.cpp:
2453         (WebCore::RenderSVGImage::nodeAtPoint):
2454         * rendering/RenderSVGText.cpp:
2455         (WebCore::RenderSVGText::nodeAtPoint):
2456         * rendering/RenderTableRow.cpp:
2457         (WebCore::RenderTableRow::nodeAtPoint):
2458         * rendering/RenderTableRow.h:
2459         * rendering/RenderTableSection.cpp:
2460         (WebCore::RenderTableSection::nodeAtPoint):
2461         * rendering/RenderTableSection.h:
2462         * rendering/RenderTextControl.cpp:
2463         (WebCore::RenderTextControl::nodeAtPoint):
2464         * rendering/RootInlineBox.cpp:
2465         (WebCore::RootInlineBox::nodeAtPoint):
2466         * rendering/RootInlineBox.h:
2467
2468 2006-10-29  Adam Roben  <aroben@apple.com>
2469
2470         More semi-fixes.
2471
2472         * page/Page.cpp: Forgot to wrap the actual definition of
2473         setDefersLoading() in PLATFORM(MAC).
2474         * platform/PlatformWheelEvent.h: Fix up preprocessor directives.
2475
2476 2006-10-29  Adam Roben  <aroben@apple.com>
2477
2478         Build semi-fix.
2479
2480         Move all FrameLoader-related code in Page.{cpp,h} within #if
2481         PLATFORM(MAC), since this class currently only exists on Mac.
2482
2483         * page/Page.cpp:
2484         * page/Page.h:
2485
2486 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
2487
2488         build fix.
2489         
2490         * platform/PlatformString.h:
2491         (WebCore::String::operator NSString*):
2492
2493 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
2494
2495         Rolled out accidental commit.
2496         
2497         * platform/AtomicString.h:
2498         (WebCore::AtomicString::AtomicString):
2499         (WebCore::AtomicString::operator NSString*):
2500
2501 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
2502
2503         RS by Darin.
2504
2505         Rolled out change to map NULL Strings to nil NSStrings because it caused
2506         even more AppKit crashes. Maybe we should remove the NSString * operator
2507         entirely, since its use is not straight-forward, and require callers to
2508         specify explicitly whether they tolerate NULL.
2509         
2510         * platform/AtomicString.h:
2511         * platform/PlatformString.h:
2512         (WebCore::String::operator NSString*):
2513         * platform/mac/TextFieldMac.mm:
2514         (-[NSSearchFieldCell _addStringToRecentSearches:]):
2515
2516 2006-10-29  Darin Adler  <darin@apple.com>
2517
2518         Reviewed by Geoff.
2519
2520         - fixed storage leak showing up on the buildbot
2521
2522         * loader/mac/WebSubresourceLoader.mm: (WebCore::SubresourceLoader::create):
2523         Release the NSURLRequest after passing it to load. Also clean up logic a bit.
2524
2525 2006-10-29  Darin Adler  <darin@apple.com>
2526
2527         Rubber stamped by Adam.
2528
2529         - renamed WebFrameLoaderClient to match the class name inside it
2530
2531         * loader/mac/WebFrameLoaderClient.h: Removed.
2532         * loader/FrameLoaderClient.h: Moved it here.
2533
2534         * WebCore.xcodeproj/project.pbxproj: Updated project.
2535
2536         * bridge/mac/FrameMac.mm: Updated includes.
2537         * bridge/mac/WebCoreFrameBridge.mm: Ditto.
2538         * loader/mac/FrameLoader.mm: Ditto.
2539         * loader/mac/WebLoader.h: Ditto.
2540
2541 2006-10-29  Darin Adler  <darin@apple.com>
2542
2543         Reviewed by Mitz.
2544
2545         - fix crash visible on buildbot and also when running the test
2546           anchor-image-scrolled-x-y.html under libgmalloc
2547
2548         * loader/mac/WebSubresourceLoader.h: Renamed m_loader to m_handle
2549         now that the class is named ResourceHandle.
2550         * loader/mac/WebSubresourceLoader.mm: Renaming, plus:
2551         (WebCore::SubresourceLoader::didFinishLoading): Get the handle into
2552         a local RefPtr before calling finishJobAndHandle, since we might get
2553         cancelled inside that function, so we should not rely on m_handle to
2554         keep the ResourceHandle alive.
2555         (WebCore::SubresourceLoader::didFail): Ditto.
2556         (WebCore::SubresourceLoader::didCancel): Ditto.
2557
2558 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2559
2560         - build fix
2561
2562         * platform/network/mac/ResourceHandleMac.mm:
2563
2564 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2565
2566         Rubber stamped by Darin.
2567
2568         - renamed ResourceLoader to ResourceHandle (and same for related classes)
2569
2570         * CMakeLists.txt:
2571         * Projects/gdk/webcore-gdk.bkl:
2572         * WebCore.vcproj/WebCore/WebCore.vcproj:
2573         * WebCore.xcodeproj/project.pbxproj:
2574         * WebCoreSources.bkl:
2575         * bridge/mac/FrameMac.mm:
2576         * bridge/win/FrameWin.cpp:
2577         * dom/XMLTokenizer.cpp:
2578         * loader/Cache.cpp:
2579         * loader/CachedResource.h:
2580         * loader/LoaderFunctions.h:
2581         * loader/icon/IconLoader.cpp:
2582         (IconLoader::startLoading):
2583         (IconLoader::didReceiveData):
2584         (IconLoader::didFinishLoading):
2585         * loader/icon/IconLoader.h:
2586         * loader/loader.cpp:
2587         (WebCore::Loader::servePendingRequests):
2588         (WebCore::Loader::receivedAllData):
2589         (WebCore::Loader::receivedResponse):
2590         (WebCore::Loader::didReceiveData):
2591         (WebCore::Loader::cancelRequests):
2592         (WebCore::Loader::jobForRequest):
2593         * loader/loader.h:
2594         * loader/mac/IconLoaderMac.mm:
2595         (IconLoader::receivedResponse):
2596         * loader/mac/LoaderFunctionsMac.mm:
2597         * loader/mac/WebLoader.h:
2598         * loader/mac/WebSubresourceLoader.h:
2599         * loader/mac/WebSubresourceLoader.mm:
2600         (WebCore::SubresourceLoader::SubresourceLoader):
2601         (WebCore::SubresourceLoader::create):
2602         * platform/gdk/FrameGdk.cpp:
2603         (WebCore::FrameGdkClientDefault::FrameGdkClientDefault):
2604         (WebCore::FrameGdkClientDefault::openURL):
2605         (WebCore::FrameGdkClientDefault::submitForm):
2606         (WebCore::FrameGdkClientDefault::receivedResponse):
2607         (WebCore::FrameGdkClientDefault::didReceiveData):
2608         (WebCore::FrameGdkClientDefault::receivedAllData):
2609         * platform/gdk/FrameGdk.h:
2610         * platform/gdk/TemporaryLinkStubs.cpp:
2611         (WebCore::ServeSynchronousRequest):
2612         (WebCore::ResourceHandle::assembleResponseHeaders):
2613         (WebCore::ResourceHandle::retrieveCharset):
2614         * platform/network/ResourceHandle.cpp: Added.
2615         (WebCore::ResourceHandle::ResourceHandle):
2616         (WebCore::ResourceHandle::create):
2617         (WebCore::ResourceHandle::isErrorPage):
2618         (WebCore::ResourceHandle::error):
2619         (WebCore::ResourceHandle::setError):
2620         (WebCore::ResourceHandle::responseEncoding):
2621         (WebCore::ResourceHandle::responseHTTPHeadersAsString):
2622         (WebCore::ResourceHandle::kill):
2623         (WebCore::ResourceHandle::requestHeaders):
2624         (WebCore::ResourceHandle::url):
2625         (WebCore::ResourceHandle::postData):
2626         (WebCore::ResourceHandle::method):
2627         (WebCore::ResourceHandle::client):
2628         * platform/network/ResourceHandle.h: Added.
2629         (WebCore::ResourceHandle::getInternal):
2630         * platform/network/ResourceHandleClient.h: Added.
2631         (WebCore::ResourceHandleClient::~ResourceHandleClient):
2632         (WebCore::ResourceHandleClient::didReceiveData):
2633         (WebCore::ResourceHandleClient::didFinishLoading):
2634         (WebCore::ResourceHandleClient::receivedRedirect):
2635         (WebCore::ResourceHandleClient::receivedResponse):
2636         (WebCore::ResourceHandleClient::receivedAllData):
2637         * platform/network/ResourceHandleInternal.h: Added.
2638         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
2639         * platform/network/ResourceLoader.cpp: Removed.
2640         * platform/network/ResourceLoader.h: Removed.
2641         * platform/network/ResourceLoaderClient.h: Removed.
2642         * platform/network/ResourceLoaderInternal.h: Removed.
2643         * platform/network/cf/ResourceHandleCFNet.cpp: Added.
2644         (WebCore::willSendRequest):
2645         (WebCore::didReceiveResponse):
2646         (WebCore::didReceiveData):
2647         (WebCore::didFinishLoading):
2648         (WebCore::didFail):
2649         (WebCore::willCacheResponse):
2650         (WebCore::didReceiveChallenge):
2651         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2652         (WebCore::ResourceHandle::~ResourceHandle):
2653         (WebCore::ResourceHandle::start):
2654         (WebCore::ResourceHandle::cancel):
2655         * platform/network/cf/ResourceLoaderCFNet.cpp: Removed.
2656         * platform/network/gdk/ResourceHandleCurl.cpp: Added.
2657         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2658         (WebCore::ResourceHandle::~ResourceHandle):
2659         (WebCore::ResourceHandle::start):
2660         (WebCore::ResourceHandle::cancel):
2661         * platform/network/gdk/ResourceHandleManager.cpp: Added.
2662         (WebCore::ResourceHandleManager::ResourceHandleManager):
2663         (WebCore::ResourceHandleManager::get):
2664         (WebCore::ResourceHandleManager::useSimpleTransfer):
2665         (WebCore::writeCallback):
2666         (WebCore::ResourceHandleManager::downloadTimerCallback):
2667         (WebCore::ResourceHandleManager::remove):
2668         (WebCore::ResourceHandleManager::add):
2669         (WebCore::ResourceHandleManager::cancel):
2670         * platform/network/gdk/ResourceHandleManager.h: Added.
2671         * platform/network/gdk/ResourceLoaderCurl.cpp: Removed.
2672         * platform/network/gdk/ResourceLoaderManager.cpp: Removed.
2673         * platform/network/gdk/ResourceLoaderManager.h: Removed.
2674         * platform/network/mac/ResourceHandleMac.mm: Added.
2675         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2676         (WebCore::ResourceHandle::~ResourceHandle):
2677         (WebCore::ResourceHandle::start):
2678         (WebCore::ResourceHandle::assembleResponseHeaders):
2679         (WebCore::ResourceHandle::retrieveResponseEncoding):
2680         (WebCore::ResourceHandle::receivedResponse):
2681         (WebCore::ResourceHandle::cancel):
2682         (WebCore::ResourceHandle::redirectedToURL):
2683         (WebCore::ResourceHandle::addData):
2684         (WebCore::ResourceHandle::finishJobAndHandle):
2685         (WebCore::ResourceHandle::reportError):
2686         * platform/network/mac/ResourceLoaderMac.mm: Removed.
2687         * platform/network/qt/ResourceHandleManager.cpp: Added.
2688         (WebCore::ResourceHandleManager::ResourceHandleManager):
2689         (WebCore::ResourceHandleManager::~ResourceHandleManager):
2690         (WebCore::ResourceHandleManager::self):
2691         (WebCore::ResourceHandleManager::slotData):
2692         (WebCore::ResourceHandleManager::slotMimetype):
2693         (WebCore::ResourceHandleManager::slotResult):
2694         (WebCore::ResourceHandleManager::remove):
2695         (WebCore::ResourceHandleManager::add):
2696         (WebCore::ResourceHandleManager::cancel):
2697         * platform/network/qt/ResourceHandleManager.h: Added.
2698         * platform/network/qt/ResourceHandleQt.cpp: Added.
2699         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2700         (WebCore::ResourceHandle::~ResourceHandle):
2701         (WebCore::ResourceHandle::start):
2702         (WebCore::ResourceHandle::cancel):
2703         (WebCore::ResourceHandle::assembleResponseHeaders):
2704         (WebCore::ResourceHandle::retrieveResponseEncoding):
2705         (WebCore::ResourceHandle::receivedResponse):
2706         (WebCore::ResourceHandle::extractCharsetFromHeaders):
2707         * platform/network/qt/ResourceLoaderManager.cpp: Removed.
2708         * platform/network/qt/ResourceLoaderManager.h: Removed.
2709         * platform/network/qt/ResourceLoaderQt.cpp: Removed.
2710         * platform/network/win/ResourceHandleWin.cpp: Added.
2711         (WebCore::):
2712         (WebCore::addToOutstandingJobs):
2713         (WebCore::lookupResourceHandle):
2714         (WebCore::ResourceHandleWndProc):
2715         (WebCore::initializeOffScreenResourceHandleWindow):
2716         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2717         (WebCore::ResourceHandle::~ResourceHandle):
2718         (WebCore::ResourceHandle::onHandleCreated):
2719         (WebCore::ResourceHandle::onRequestRedirected):
2720         (WebCore::ResourceHandle::onRequestComplete):
2721         (WebCore::ResourceHandle::start):
2722         (WebCore::ResourceHandle::fileLoadTimer):
2723         (WebCore::ResourceHandle::cancel):
2724         (WebCore::ResourceHandle::setHasReceivedResponse):
2725         (WebCore::ResourceHandle::hasReceivedResponse):
2726         * platform/network/win/ResourceHandleWin.h: Added.
2727         * platform/network/win/ResourceLoaderWin.cpp: Removed.
2728         * platform/network/win/ResourceLoaderWin.h: Removed.
2729         * platform/qt/FrameQt.cpp:
2730         * platform/qt/FrameQtClient.cpp:
2731         (WebCore::FrameQtClientDefault::openURL):
2732         (WebCore::FrameQtClientDefault::submitForm):
2733         (WebCore::FrameQtClientDefault::receivedResponse):
2734         (WebCore::FrameQtClientDefault::didReceiveData):
2735         (WebCore::FrameQtClientDefault::receivedAllData):
2736         * platform/qt/FrameQtClient.h:
2737         * platform/win/TemporaryLinkStubs.cpp:
2738         (WebCore::ResourceHandle::assembleResponseHeaders):
2739         (WebCore::ResourceHandle::retrieveResponseEncoding):
2740         (WebCore::ServeSynchronousRequest):
2741         * xml/XSLTProcessor.cpp:
2742         * xml/xmlhttprequest.cpp:
2743         (WebCore::XMLHttpRequest::send):
2744         (WebCore::XMLHttpRequest::didFinishLoading):
2745         (WebCore::XMLHttpRequest::receivedRedirect):
2746         (WebCore::XMLHttpRequest::didReceiveData):
2747         * xml/xmlhttprequest.h:
2748
2749 t2006-10-29  Darin Adler  <darin@apple.com>
2750
2751         Reviewed by Maciej.
2752
2753         - eliminate use of NSArray to carry form data around
2754
2755         * WebCore.exp:
2756         * WebCore.xcodeproj/project.pbxproj:
2757         * bridge/mac/FormDataMac.h: Removed.
2758         * bridge/mac/FormDataMac.mm: Removed.
2759         * bridge/mac/FrameMac.h:
2760         * bridge/mac/WebCoreFrameBridge.h:
2761         * bridge/mac/WebCoreFrameBridge.mm:
2762         * html/HTMLFormElement.cpp:
2763         (WebCore::HTMLFormElement::submit):
2764         * loader/FormData.h:
2765         (WebCore::FormData::isEmpty):
2766         * loader/mac/FrameLoader.h:
2767         * loader/mac/FrameLoader.mm:
2768         (WebCore::FrameLoader::load):
2769         (WebCore::FrameLoader::post):
2770         (WebCore::FrameLoader::loadEmptyDocumentSynchronously):
2771         (WebCore::FrameLoader::loadResourceSynchronously):
2772         * loader/mac/LoaderFunctionsMac.mm:
2773         (WebCore::ServeSynchronousRequest):
2774         * loader/mac/WebFormDataStream.h:
2775         * loader/mac/WebFormDataStream.m:
2776         (WebCore::pairRetain):
2777         (WebCore::pairRelease):
2778         (WebCore::pairEqual):
2779         (WebCore::pairHash):
2780         (WebCore::closeCurrentStream):
2781         (WebCore::scheduleWithPair):
2782         (WebCore::advanceCurrentStream):
2783         (WebCore::openNextStream):
2784         (WebCore::formCreate):
2785         (WebCore::formFinalize):
2786         (WebCore::formOpen):
2787         (WebCore::formRead):
2788         (WebCore::formCanRead):
2789         (WebCore::formClose):
2790         (WebCore::formSchedule):
2791         (WebCore::formUnschedule):
2792         (WebCore::formEventCallback):
2793         (WebCore::setHTTPBody):
2794         * loader/mac/WebSubresourceLoader.h:
2795         * loader/mac/WebSubresourceLoader.mm:
2796         (WebCore::SubresourceLoader::create):
2797         * platform/network/mac/ResourceLoaderMac.mm:
2798
2799 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2800
2801         Reviewed by Darin.
2802
2803         - create SubresourceLoader with a ResourceRequest, not broken out request bits
2804
2805         * loader/mac/WebSubresourceLoader.h:
2806         * loader/mac/WebSubresourceLoader.mm:
2807         (WebCore::SubresourceLoader::create):
2808         * platform/network/mac/ResourceLoaderMac.mm:
2809         (WebCore::ResourceLoader::start):
2810
2811 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2812
2813         Reviewed by Darin.
2814
2815         - removed ObjC glue between ResourceLoader and SubresourceLoader, then now talk to each other directly
2816
2817         Removed WebCoreResourceLoader, WebCoreResourceHandle and WebCoreResourceLoaderImp
2818         
2819         * WebCore.xcodeproj/project.pbxproj:
2820         * bridge/mac/WebCoreFrameBridge.h:
2821         * loader/mac/FrameLoader.h:
2822         * loader/mac/FrameLoader.mm:
2823         * loader/mac/LoaderFunctionsMac.mm:
2824         * loader/mac/WebLoader.h:
2825         * loader/mac/WebSubresourceLoader.h:
2826         * loader/mac/WebSubresourceLoader.mm:
2827         (WebCore::SubresourceLoader::SubresourceLoader):
2828         (WebCore::SubresourceLoader::create):
2829         (WebCore::SubresourceLoader::willSendRequest):
2830         (WebCore::SubresourceLoader::didReceiveResponse):
2831         (WebCore::SubresourceLoader::didReceiveData):
2832         (WebCore::SubresourceLoader::didFinishLoading):
2833         (WebCore::SubresourceLoader::didFail):
2834         (WebCore::SubresourceLoader::didCancel):
2835         * platform/network/ResourceLoader.h:
2836         * platform/network/ResourceLoaderInternal.h:
2837         * platform/network/mac/ResourceLoaderMac.mm:
2838         (WebCore::ResourceLoader::~ResourceLoader):
2839         (WebCore::ResourceLoader::start):
2840         (WebCore::ResourceLoader::receivedResponse):
2841         (WebCore::ResourceLoader::cancel):
2842         (WebCore::ResourceLoader::redirectedToURL):
2843         (WebCore::ResourceLoader::addData):
2844         (WebCore::ResourceLoader::finishJobAndHandle):
2845         (WebCore::ResourceLoader::reportError):
2846         * platform/network/mac/WebCoreResourceLoader.h: Removed.
2847         * platform/network/mac/WebCoreResourceLoaderImp.h: Removed.
2848         * platform/network/mac/WebCoreResourceLoaderImp.mm: Removed.
2849
2850 2006-10-28  Darin Adler  <darin@apple.com>
2851
2852         Reviewed by Maciej.
2853
2854         - eliminated the use of Objective-C for the policy decider
2855           machinery, obviating the need for WebPolicyDecider,
2856           WebCoreFrameLoaderAsDelegate, and
2857           WebCoreMainResourceLoaderAsPolicyDelegate
2858
2859         - grouped the state related to policy decisions into a PolicyCheck
2860           class to simplify the FrameLoader logic
2861
2862         - removed six methods from the bridge, reducing FrameLoader's use of
2863           the bridge to a single method
2864
2865         - changed form state to always use HashMap instead of NSDictionary
2866
2867         - moved the defersLoading flag from WebView to WebCore::Page
2868           and changed code to consistently call it defersLoading rather
2869           than defersCallbacks
2870
2871         - updated for rename of PassRefPtr::release to releaseRef
2872         - replaced all uses of __APPLE__ with appropriate PLATFORM defines
2873         - cleaned up kjs_binding.h a bit
2874         - cleaned up FrameMac.h a bit
2875
2876         * loader/mac/WebPolicyDecider.h: Removed.
2877         * loader/mac/WebPolicyDecider.mm: Removed.
2878         * WebCore.xcodeproj/project.pbxproj: Updated for removal.
2879
2880         * WebCore.exp:
2881         * bindings/js/kjs_binding.cpp:
2882         (KJS::ScriptInterpreter::ScriptInterpreter):
2883         (KJS::ScriptInterpreter::wasRunByUserGesture):
2884         * bindings/js/kjs_binding.h:
2885         (KJS::ScriptInterpreter::setCurrentEvent):
2886         (KJS::ScriptInterpreter::setInlineCode):
2887         (KJS::ScriptInterpreter::setProcessingTimerCallback):
2888         (KJS::ScriptInterpreter::getCurrentEvent):
2889         (KJS::cacheDOMObject):
2890         (KJS::DOMExceptionTranslator::DOMExceptionTranslator):
2891         * bridge/AXObjectCache.h:
2892         * bridge/mac/BrowserExtensionMac.mm:
2893         (WebCore::BrowserExtensionMac::createNewWindow):
2894         * bridge/mac/FrameMac.h:
2895         * bridge/mac/FrameMac.mm:
2896         (WebCore::FrameMac::loadRequest):
2897         (WebCore::FrameMac::submitForm):
2898         (WebCore::FrameMac::urlSelected):
2899         (WebCore::FrameMac::userAgent):
2900         (WebCore::FrameMac::passMouseDownEventToWidget):
2901         (WebCore::FrameMac::handleMouseMoveEvent):
2902         * bridge/mac/PageMac.mm:
2903         (WebCore::Page::Page):
2904         * bridge/mac/WebCoreEditCommand.mm:
2905         * bridge/mac/WebCoreFrameBridge.h:
2906         * bridge/mac/WebCoreFrameBridge.mm:
2907         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
2908         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
2909         * css/CSSComputedStyleDeclaration.cpp:
2910         (WebCore::):
2911         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2912         * css/CSSPrimitiveValue.cpp:
2913         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
2914         (WebCore::CSSPrimitiveValue::cleanup):
2915         (WebCore::CSSPrimitiveValue::cssText):
2916         * css/CSSPrimitiveValue.h:
2917         (WebCore::CSSPrimitiveValue::):
2918         * css/CSSValueList.cpp:
2919         (WebCore::CSSValueList::append):
2920         * css/cssparser.cpp:
2921         (WebCore::CSSParser::parseValue):
2922         * css/cssparser.h:
2923         * css/cssstyleselector.cpp:
2924         (WebCore::CSSStyleSelector::applyProperty):
2925         * dom/Document.cpp:
2926         (WebCore::Document::Document):
2927         (WebCore::Document::updateSelection):
2928         (WebCore::Document::implicitClose):
2929         (WebCore::Document::setFocusNode):
2930         * dom/Document.h:
2931         * editing/ReplaceSelectionCommand.h:
2932         * html/HTMLParser.cpp:
2933         (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
2934         * loader/mac/FrameLoader.h:
2935         (WebCore::PolicyCheck::request):
2936         * loader/mac/FrameLoader.mm:
2937         (WebCore::FrameLoader::~FrameLoader):
2938         (WebCore::FrameLoader::safeLoad):
2939         (WebCore::FrameLoader::load):
2940         (WebCore::FrameLoader::open):
2941         (WebCore::FrameLoader::stopLoading):
2942         (WebCore::setAllDefersLoading):
2943         (WebCore::FrameLoader::setDefersLoading):
2944         (WebCore::FrameLoader::willSendRequest):
2945         (WebCore::FrameLoader::receivedMainResourceError):
2946         (WebCore::FrameLoader::callContinueFragmentScrollAfterNavigationPolicy):
2947         (WebCore::FrameLoader::commitProvisionalLoad):
2948         (WebCore::FrameLoader::checkNavigationPolicy):
2949         (WebCore::FrameLoader::checkContentPolicy):
2950         (WebCore::FrameLoader::cancelContentPolicyCheck):
2951         (WebCore::FrameLoader::stopPolicyCheck):
2952         (WebCore::FrameLoader::checkNewWindowPolicy):
2953         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
2954         (WebCore::FrameLoader::continueAfterNavigationPolicy):
2955         (WebCore::FrameLoader::continueAfterContentPolicy):
2956         (WebCore::FrameLoader::continueAfterWillSubmitForm):
2957         (WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy):
2958         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
2959         (WebCore::FrameLoader::closeDocument):
2960         (WebCore::FrameLoader::transitionToCommitted):
2961         (WebCore::FrameLoader::callContinueLoadAfterNewWindowPolicy):
2962         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
2963         (WebCore::FrameLoader::post):
2964         (WebCore::FrameLoader::detachFromParent):
2965         (WebCore::FrameLoader::addExtraFieldsToRequest):
2966         (WebCore::PolicyCheck::PolicyCheck):
2967         (WebCore::PolicyCheck::clear):
2968         (WebCore::PolicyCheck::set):
2969         (WebCore::PolicyCheck::call):
2970         (WebCore::PolicyCheck::dropRequest):
2971         (WebCore::FrameLoaderClient::~FrameLoaderClient):
2972         * loader/mac/WebFormState.h:
2973         * loader/mac/WebFormState.mm:
2974         * loader/mac/WebFrameLoaderClient.h:
2975         * loader/mac/WebLoader.h:
2976         (WebCore::WebResourceLoader::defersLoading):
2977         * loader/mac/WebLoader.mm:
2978         (WebCore::WebResourceLoader::WebResourceLoader):
2979         (WebCore::WebResourceLoader::load):
2980         (WebCore::WebResourceLoader::setDefersLoading):
2981         * loader/mac/WebMainResourceLoader.h:
2982         * loader/mac/WebMainResourceLoader.mm:
2983         (WebCore::MainResourceLoader::MainResourceLoader):
2984         (WebCore::MainResourceLoader::releaseDelegate):
2985         (WebCore::MainResourceLoader::didCancel):
2986         (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy):
2987         (WebCore::MainResourceLoader::continueAfterNavigationPolicy):
2988         (WebCore::MainResourceLoader::willSendRequest):
2989         (WebCore::MainResourceLoader::callContinueAfterContentPolicy):
2990         (WebCore::MainResourceLoader::continueAfterContentPolicy):
2991         (WebCore::MainResourceLoader::didReceiveResponse):
2992         (WebCore::MainResourceLoader::didReceiveData):
2993         (WebCore::MainResourceLoader::didFinishLoading):
2994         (WebCore::MainResourceLoader::didFail):
2995         (WebCore::MainResourceLoader::loadNow):
2996         (WebCore::MainResourceLoader::load):
2997         (WebCore::MainResourceLoader::setDefersLoading):
2998         * page/Frame.cpp:
2999         (WebCore::Frame::paint):
3000         * page/FrameView.cpp:
3001         (WebCore::FrameView::layout):
3002         * page/FrameView.h:
3003         * page/Page.cpp:
3004         (WebCore::Page::setDefersLoading):
3005         * page/Page.h:
3006         (WebCore::Page::defersLoading):
3007         * platform/DeprecatedString.h:
3008         * platform/DeprecatedStringList.h:
3009         * platform/FontFallbackList.h:
3010         * platform/PlatformKeyboardEvent.h:
3011         * platform/PlatformMouseEvent.h:
3012         * platform/PlatformWheelEvent.h:
3013         * platform/mac/ClipboardMac.h:
3014         * platform/mac/ClipboardMac.mm:
3015         (WebCore::ClipboardMac::setDragImage):
3016         (WebCore::ClipboardMac::dragNSImage):
3017         (WebCore::ClipboardMac::sourceOperation):
3018         (WebCore::ClipboardMac::destinationOperation):
3019         * rendering/RenderObject.cpp:
3020         (WebCore::RenderObject::setStyle):
3021         * rendering/break_lines.cpp:
3022         (WebCore::nextBreakablePosition):
3023
3024 2006-10-28  Adam Roben  <aroben@apple.com>
3025
3026         Reviewed by Maciej.
3027
3028         Fix layout tests that broke after r17399. Mitz discovered that the
3029         failures were caused by HitTestResult::m_point being uninitialized
3030         much of the time. HitTestResults are now always constructed with a
3031         point, and RenderLayer::hitTest and RenderLayer::hitTestLayer use that
3032         point instead of being passed one explicitly.
3033
3034         * WebCore.exp: Change constructor symbol.
3035         * bridge/mac/FrameMac.mm:
3036         (WebCore::FrameMac::eventMayStartDrag): Update to new constructor and
3037         hitTest().
3038         (WebCore::FrameMac::handleMouseMoveEvent): Ditto.
3039         * bridge/mac/WebCoreAXObject.mm:
3040         (-[WebCoreAXObject doAXTextMarkerForPosition:]): Ditto.
3041         (-[WebCoreAXObject accessibilityHitTest:]): Ditto.
3042         * dom/Document.cpp:
3043         (WebCore::Document::elementFromPoint): Ditto.
3044         (WebCore::Document::prepareMouseEvent): Ditto.
3045         * page/Frame.cpp:
3046         (WebCore::Frame::isPointInsideSelection): Ditto.
3047         (WebCore::Frame::hitTestResultAtPoint): Ditto.
3048         * page/FrameView.cpp:
3049         (WebCore::FrameView::handleWheelEvent): Ditto.
3050         * rendering/HitTestResult.cpp:
3051         (WebCore::HitTestResult::HitTestResult): Initalize m_point with the
3052         passed point.
3053         * rendering/HitTestResult.h: Update constructor declaration.
3054         * rendering/RenderLayer.cpp:
3055         (WebCore::RenderLayer::autoscroll): Update to new constructor and
3056         hitTest().
3057         (WebCore::RenderLayer::hitTest): Use the IntPoint stored in the
3058         HitTestResult instead of being passed one.
3059         (WebCore::RenderLayer::hitTestLayer): Ditto.
3060         * rendering/RenderLayer.h: Update declarations.
3061
3062 2006-10-28  Nikolas Zimmermann  <zimmermann@kde.org>
3063
3064         Reviewed by Anders.
3065
3066         Fix Qt/Linux build.
3067
3068         * CMakeLists.txt:
3069         * platform/qt/FrameQtClient.cpp:
3070         (WebCore::numRequests):
3071         (WebCore::FrameQtClientDefault::numPendingOrLoadingRequests):
3072         * platform/qt/PopupMenuQt.cpp:
3073         (WebCore::PopupMenu::updateFromElement):
3074
3075 2006-10-28  David Carson  <dacarson@gmail.com>
3076
3077         Tweaked by Sam. Reviewed by Brady.
3078
3079         Fix for: http://bugs.webkit.org/show_bug.cgi?id=11437
3080         Initialize m_modifyBiasSet to false, as it sometimes gets 
3081         used before it has been initalized.
3082
3083         * editing/SelectionController.cpp:
3084         (WebCore::SelectionController::SelectionController):
3085
3086 2006-10-28  Beth Dakin  <bdakin@apple.com>
3087
3088         Reviewed by Darin.
3089
3090         This is the WebCore half of pushing elementAtPoint and the backend 
3091         of WebElementDictionary into WebCore. Most of the changes below are 
3092         to accommodate one of the following:
3093                 
3094         -NodeInfo is now a stand-alone class called HitTestResult. 
3095                 Previously it was defined in RenderObject.h, but not for 
3096                 any particular reason. The WebElementDictionary 
3097                 functionality that was pushed into WebCore has been pushed 
3098                 specifically into the this class. In fact, 
3099                 WebElementDictionary now keeps a HitTestResult as a member 
3100                 varibale.
3101                 
3102         -The enumeration AccessPolicy is now called 
3103                 ClipboardAccessPolicy and is defined in its own header. It 
3104                 was previously defined in ClipboardMac.h, but is now 
3105                 defined independently to avoid including ClipboardMac.h 
3106                 from within FrameMac.h since FrameMac.h is now included in 
3107                 WebElementDictionary.m in WebKit.
3108                 
3109         -Element now has a virtual target() for the sake of 
3110                 NodeInfo::targetFrame() 
3111
3112         * WebCore.exp: Several WebCore functions are newly called from 
3113         WebKit, so they have been added here. 
3114         * WebCore.xcodeproj/project.pbxproj:
3115         * bindings/objc/DOM.mm: Must include Image.h because of adjustments 
3116         to ClipboardMac.
3117         * bridge/mac/FrameMac.h: Adjust to HitTestResult changes.
3118         * bridge/mac/FrameMac.mm:
3119         (WebCore::FrameMac::freeClipboard): Adjust to ClipboardAccessPolicy 
3120         and HitTestResult changes.
3121         (WebCore::FrameMac::eventMayStartDrag): Same.
3122         (WebCore::FrameMac::handleMouseMoveEvent): Same.
3123         (WebCore::FrameMac::dispatchCPPEvent): Same.
3124         (WebCore::FrameMac::mayDHTMLCut): Same.
3125         (WebCore::FrameMac::mayDHTMLCopy): Same.
3126         (WebCore::FrameMac::mayDHTMLPaste): Same.
3127         (WebCore::FrameMac::tryDHTMLCut): Same
3128         (WebCore::FrameMac::tryDHTMLCopy): Same.
3129         (WebCore::FrameMac::tryDHTMLPaste): Same.
3130         * bridge/mac/WebCoreAXObject.mm:
3131         (-[WebCoreAXObject doAXTextMarkerForPosition:]): Adjust to 
3132         HitTestResult changes.
3133         (-[WebCoreAXObject accessibilityHitTest:]): Same.
3134         * bridge/mac/WebCoreFrameBridge.h: Same.
3135         * bridge/mac/WebCoreFrameBridge.mm:
3136         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): Adjust for 
3137         ClipboardAccessPolicy changes.
3138         (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]): Same.
3139         (-[WebCoreFrameBridge concludeDragForDraggingInfo:]): Same.
3140         * dom/Document.cpp:
3141         (WebCore::Document::elementFromPoint): Adjust for HitTestResult 
3142         changes.
3143         (WebCore::Document::prepareMouseEvent): Same.
3144         * dom/Element.h:
3145         (WebCore::Element::target): Now has a virtual target()
3146         * html/HTMLAnchorElement.h: Same.
3147         * html/HTMLAreaElement.cpp:
3148         (WebCore::HTMLAreaElement::mapMouseEvent): Adjust for HitTestResult 
3149         changes.
3150         * html/HTMLAreaElement.h: Virtual target()
3151         * html/HTMLBaseElement.h:
3152         (WebCore::HTMLBaseElement::target): Same.
3153         * html/HTMLFormElement.h: Same.
3154         * html/HTMLLinkElement.h: Same.
3155         * html/HTMLMapElement.cpp:
3156         (WebCore::HTMLMapElement::mapMouseEvent): Adjust for HitTestResult 
3157         changes.
3158         * html/HTMLMapElement.h: Same.
3159         * page/Frame.cpp:
3160         (WebCore::Frame::isPointInsideSelection): Same.
3161         (WebCore::Frame::hitTestResultAtPoint): Same. 
3162         * page/Frame.h: Same.
3163         * page/FrameView.cpp:
3164         (WebCore::FrameView::handleWheelEvent): Same.
3165         * platform/mac/ClipboardAccessPolicy.h: Added.
3166         (WebCore::):
3167         * platform/mac/ClipboardMac.h: Remove definition of AccessPolicy, 
3168         include ClipboardAccessPolicy.h, and rename AccessPolicy to 
3169         ClipboardAccessPolicy.
3170         * platform/mac/ClipboardMac.mm: Rename ClipboardAccessPolicy.
3171         (WebCore::ClipboardMac::ClipboardMac):
3172         (WebCore::ClipboardMac::setAccessPolicy):
3173         (WebCore::ClipboardMac::clearData):
3174         (WebCore::ClipboardMac::clearAllData):
3175         (WebCore::ClipboardMac::getData):
3176         (WebCore::ClipboardMac::setData):
3177         (WebCore::ClipboardMac::types):
3178         (WebCore::ClipboardMac::setDragImage):
3179         (WebCore::ClipboardMac::setDropEffect):
3180         (WebCore::ClipboardMac::setEffectAllowed):
3181         * rendering/EllipsisBox.cpp:
3182         (WebCore::EllipsisBox::nodeAtPoint): Adjust for HitTestResult 
3183         changes.
3184         * rendering/EllipsisBox.h:
3185         * rendering/HitTestResult.cpp: Added.
3186         (WebCore::HitTestResult::HitTestResult):
3187         (WebCore::HitTestResult::~HitTestResult):
3188         (WebCore::HitTestResult::operator=):
3189         (WebCore::HitTestResult::setInnerNode):
3190         (WebCore::HitTestResult::setInnerNonSharedNode):
3191         (WebCore::HitTestResult::setURLElement):
3192         (WebCore::HitTestResult::setScrollbar):
3193         (WebCore::HitTestResult::targetFrame):
3194         (WebCore::HitTestResult::boundingBox):
3195         (WebCore::HitTestResult::isSelected):
3196         (WebCore::HitTestResult::title):
3197         * rendering/HitTestResult.h: Added.
3198         (WebCore::HitTestResult::readonly):
3199         (WebCore::HitTestResult::active):
3200         (WebCore::HitTestResult::mouseMove):
3201         (WebCore::HitTestResult::innerNode):
3202         (WebCore::HitTestResult::innerNonSharedNode):
3203         (WebCore::HitTestResult::point):
3204         (WebCore::HitTestResult::URLElement):
3205         (WebCore::HitTestResult::scrollbar):
3206         (WebCore::HitTestResult::setPoint):
3207         (WebCore::HitTestResult::setReadonly):
3208         (WebCore::HitTestResult::setActive):
3209         (WebCore::HitTestResult::setMouseMove):
3210         * rendering/InlineBox.cpp:
3211         (WebCore::InlineBox::nodeAtPoint): Adjust to HitTestResult changes.
3212         * rendering/InlineBox.h: Same.
3213         * rendering/InlineFlowBox.cpp:
3214         (WebCore::InlineFlowBox::nodeAtPoint): Same.
3215         * rendering/InlineFlowBox.h: Same.
3216         * rendering/InlineTextBox.cpp: 
3217         (WebCore::InlineTextBox::nodeAtPoint): Same.
3218         * rendering/InlineTextBox.h: Same.
3219         * rendering/RenderBlock.cpp:
3220         (WebCore::RenderBlock::isPointInScrollbar): Same.
3221         (WebCore::RenderBlock::nodeAtPoint): Same.
3222         * rendering/RenderBlock.h: Same.
3223         * rendering/RenderBox.cpp:
3224         (WebCore::RenderBox::nodeAtPoint): Same.
3225         * rendering/RenderBox.h: Same.
3226         * rendering/RenderFlow.cpp:
3227         (WebCore::RenderFlow::hitTestLines): Same.
3228         * rendering/RenderFlow.h: Same.
3229         * rendering/RenderForeignObject.cpp:
3230         (WebCore::RenderForeignObject::nodeAtPoint): Same.
3231         * rendering/RenderForeignObject.h: Same.
3232         * rendering/RenderFrameSet.cpp:
3233         (WebCore::RenderFrameSet::nodeAtPoint): Same.
3234         * rendering/RenderFrameSet.h: Same.
3235         * rendering/RenderImage.cpp:
3236         (WebCore::RenderImage::nodeAtPoint): Same.
3237         * rendering/RenderImage.h: Same.
3238         * rendering/RenderInline.cpp:
3239         (WebCore::RenderInline::nodeAtPoint): Same.
3240         * rendering/RenderInline.h: Same.
3241         * rendering/RenderLayer.cpp:
3242         (WebCore::RenderLayer::autoscroll): Same.
3243         (WebCore::RenderLayer::hitTest): Same.
3244         (WebCore::RenderLayer::hitTestLayer): Same.
3245         (WebCore::RenderLayer::updateHoverActiveState): Same.
3246         * rendering/RenderLayer.h: Same.
3247         * rendering/RenderListBox.cpp:
3248         (WebCore::RenderListBox::isPointInScrollbar): Same.
3249         * rendering/RenderListBox.h: Same.
3250         * rendering/RenderObject.cpp:
3251         (WebCore::RenderObject::hitTest): Same.
3252         (WebCore::RenderObject::setInnerNode): Same.
3253         (WebCore::RenderObject::nodeAtPoint): Same.
3254         * rendering/RenderObject.h: Remove NodeInfo class and forward 
3255         declare HitTestResult.
3256         * rendering/RenderPath.cpp:
3257         (WebCore::RenderPath::nodeAtPoint): Adjust to HitTestResult 
3258         changes.
3259         * rendering/RenderPath.h: Same.
3260         * rendering/RenderSVGImage.cpp:
3261         (WebCore::RenderSVGImage::nodeAtPoint): Same.
3262         * rendering/RenderSVGImage.h: Same
3263         * rendering/RenderSVGText.cpp:
3264         (WebCore::RenderSVGText::nodeAtPoint): Same.
3265         * rendering/RenderSVGText.h: Same.
3266         * rendering/RenderTableRow.cpp:
3267         (WebCore::RenderTableRow::nodeAtPoint): Same.
3268         * rendering/RenderTableRow.h: Same.
3269         * rendering/RenderTableSection.cpp:
3270         (WebCore::RenderTableSection::nodeAtPoint): Same.
3271         * rendering/RenderTableSection.h: Same.
3272         * rendering/RenderText.h: Same.
3273         (WebCore::RenderText::nodeAtPoint): Same.
3274         * rendering/RenderTextControl.cpp:
3275         (WebCore::RenderTextControl::nodeAtPoint): Same.
3276         * rendering/RenderTextControl.h: Same.
3277         * rendering/RootInlineBox.cpp:
3278         (WebCore::RootInlineBox::nodeAtPoint): Same.
3279         * rendering/RootInlineBox.h: Same.
3280
3281 2006-10-27  Maciej Stachowiak  <mjs@apple.com>
3282
3283         Reviewed by Anders.
3284
3285         - reverted fix for http://bugs.webkit.org/show_bug.cgi?id=11212, later we will address the performance
3286         impact of fixing it again.
3287
3288         * bridge/mac/FrameMac.mm:
3289         (WebCore::FrameMac::clear):
3290
3291 2006-10-27  Maciej Stachowiak  <mjs@apple.com>
3292
3293         Reviewed by John & Adam.
3294
3295         - assorted speedups to fix perf regression from fixing correctness regression
3296
3297         * WebCore.exp: exported new methods.
3298         * WebCore.xcodeproj/project.pbxproj: Added CachedResourceMac.mm
3299         * bridge/mac/WebCoreFrameBridge.h:
3300         * bridge/mac/WebCoreFrameBridge.mm:
3301         * loader/CachedResource.cpp: Removed now obsolete getCFURL.
3302         * loader/CachedResource.h:
3303         * loader/mac/CachedResourceMac.mm: Added.
3304         (WebCore::CachedResource::getNSURLRequest): New method; the NSURLRequest is
3305         now cached in the CachedObject.
3306         * loader/mac/FrameLoader.h:
3307         * loader/mac/FrameLoader.mm:
3308         (WebCore::FrameLoader::loadedResourceFromMemoryCache): New method - lets
3309         the WebKit side do faster dispatch for clients that implement the fast path delegate. 
3310         * loader/mac/LoaderFunctionsMac.mm:
3311         (WebCore::CheckCacheObjectStatus): Instead of calling several FrameLoader methods,
3312         just call loadedResourceFromMemoryCache.
3313         * loader/mac/WebFrameLoaderClient.h:
3314
3315 2006-10-27  Oliver Hunt  <oliver@apple.com>
3316
3317         Reviewed by Maciej.
3318
3319         build fix
3320
3321         * dom/Document.cpp:
3322         (WebCore::Document::referrer):
3323
3324 2006-10-27  Geoffrey Garen  <ggaren@apple.com>
3325
3326         Reviewed by Maciej.
3327
3328         Moved some WebCoreFrameBridge functions into FrameLoader.
3329         
3330         I had to make FrameLoader.h capable of compiling in C++-only source files
3331         by adding some forward declarations and __OBJC__ #ifdefs.
3332
3333         * WebCore.exp:
3334         * bridge/mac/FrameMac.h:
3335         * bridge/mac/FrameMac.mm:
3336         (WebCore::FrameMac::createEmptyDocument):
3337         (WebCore::FrameMac::tokenizerProcessedData):
3338         * bridge/mac/WebCoreFrameBridge.h:
3339         * bridge/mac/WebCoreFrameBridge.mm:
3340         * dom/Document.cpp:
3341         (WebCore::Document::processHttpEquiv):
3342         (WebCore::Document::referrer):
3343         * loader/LoaderFunctions.h:
3344         * loader/mac/FrameLoader.h:
3345         * loader/mac/FrameLoader.mm:
3346         (WebCore::numRequests):
3347         (WebCore::FrameLoader::numPendingOrLoadingRequests):
3348         (WebCore::FrameLoader::isReloading):
3349         (WebCore::FrameLoader::referrer):
3350         (WebCore::FrameLoader::loadEmptyDocumentSynchronously):
3351         (WebCore::FrameLoader::startLoadingResource):
3352         * loader/mac/LoaderFunctionsMac.mm:
3353         (WebCore::CheckIfReloading):
3354         * page/Frame.h:
3355         * page/FrameTree.cpp:
3356         (WebCore::FrameTree::isDescendantOf):
3357         (WebCore::FrameTree::traverseNext):
3358         * page/FrameTree.h:
3359         * platform/network/mac/ResourceLoaderMac.mm:
3360         (WebCore::ResourceLoader::start):
3361
3362 2006-10-27  Timothy Hatcher  <timothy@apple.com>
3363
3364         Reviewed by Darin.
3365
3366         <rdar://problem/4478625> HTML Editing: Basic table editing and culling
3367
3368         Expanded the Deletion UI to lists, positioned block element and block elementss with borders.
3369
3370         * editing/DeleteButtonController.cpp:
3371         (WebCore::isDeletableElement):
3372         (WebCore::enclosingDeletableElement):
3373         (WebCore::DeleteButtonController::respondToChangedSelection):
3374
3375 2006-10-27  John Sullivan  <sullivan@apple.com>
3376
3377         Reviewed by Kevin Decker
3378         
3379         Some more grammar-checking plumbing. No additional grammar jokes will have been made by the time
3380         you haven't not finished reading this.
3381
3382         * rendering/InlineTextBox.h:
3383         * rendering/InlineTextBox.cpp:
3384         (WebCore::InlineTextBox::paint):
3385         Updated for changed signature of paintDocumentMarkers, which causes grammar markers to be
3386         considered also.
3387         (WebCore::InlineTextBox::paintDocumentMarkers):
3388         Renamed from paintAllMarkersOfType; now takes a bool for whether background or foreground
3389         markers should be painted, instead of a marker type. This avoids walking the collection of
3390         markers multiple times back to back. Now handles grammar markers.
3391
3392 2006-10-27  Timothy Hatcher  <timothy@apple.com>
3393
3394         Reviewed by Beth.
3395
3396         Renamed Copy Files to Copy Generated Headers.
3397         Copy 4 DOM*Internal.h headers.
3398
3399         * WebCore.xcodeproj/project.pbxproj:
3400         * bindings/scripts/CodeGeneratorObjC.pm:
3401
3402 2006-10-27  John Sullivan  <sullivan@apple.com>
3403
3404         Reviewed by Anders
3405
3406         * WebCore.exp:
3407         exported symbol for FrameMac->advanceToNextSpelling()
3408         
3409         * bridge/mac/WebCoreFrameBridge.h:
3410         * bridge/mac/WebCoreFrameBridge.mm:
3411         removed advanceToNextMisspelling callers. Clients in WebKit must now call FrameMac directly.
3412
3413 2006-10-27  Justin Garcia  <justin.garcia@apple.com>
3414
3415         Reviewed by harrison
3416         
3417         <http://bugs.webkit.org/show_bug.cgi?id=11423>
3418         REGRESSION: First newline missing from textarea's value
3419         
3420         The regression is that foo, return, bar in a textarea serializes as 'foobar'.
3421         
3422         Before my change in r17223, return (an InsertLineBreak) would insert a '\n' 
3423         (the line break) then a br to prevent the '\n' from collapsing, since the 
3424         insertion is being done at the end of a block (the textarea's shadow div).  Then, 
3425         inserting "bar" would displace the br, and "foo\nbar" would serialize as "foo\nbar".  
3426         After my change in r17223, InsertLineBreak would insert a br then a '\n' (reversed 
3427         the order).  Then inserting "bar" would displace the '\n' and "foo"<br>"bar" would 
3428         serialize as "foobar" because when serializing RenderTextControl intentionally asks 
3429         textContent to not convert brs to newlines.  It seems to think that the only brs in 
3430         the shadow div will be placeholders or collapsed.
3431         
3432         We could remove this assumption, but, for consistancy's sake, I changed InsertLineBreak 
3433         to insert two '\n's when at the end of a block in white-space:pre text.  This alone 
3434         would have fixed the bug, but introduced a new one, because foo, return, bar would 
3435         produce "foo\nbar\n" which would serialize as "foo\nbar\n" (even though the second 
3436         '\n' is collapsed, because of 9661).  So, then I changed placeholder displacement to 
3437         displace a '\n' if it's acting as a placeholder.  A "placeholder" is now defined as 
3438         a br or '\n' that will collapse (become superfluous) when content is inserted just 
3439         before it.
3440         
3441         * editing/CompositeEditCommand.cpp:
3442         (WebCore::CompositeEditCommand::removePlaceholderAt): Renamed.  Remove
3443         a br or '\n' if content inserted just before it will cause it to collapse.
3444         * editing/CompositeEditCommand.h:
3445         * editing/InsertLineBreakCommand.cpp:
3446         (WebCore::InsertLineBreakCommand::doApply): Insert the same type of node
3447         to prevent a collapse as was used for the line break.  Fixed comments.
3448         * editing/InsertTextCommand.cpp:
3449         (WebCore::InsertTextCommand::input): Call the renamed function.
3450         
3451 2006-10-27  Geoffrey Garen  <ggaren@apple.com>
3452
3453         Reviewed by Brady.
3454
3455         Fixed semantic inaccuracy in String::operator NSString *(), where a NULL
3456         String became an empty NSString *, instead of nil. This will become important
3457         as we start using this conversion more.
3458         
3459         Added work-around for AppKit crash that semantic accuracy revealed.
3460         
3461         No testcase because I don't think there's a way to reflect this change
3462         in a webpage yet.
3463
3464         * platform/PlatformString.h:
3465         (WebCore::String::operator NSString*):
3466         * platform/mac/TextFieldMac.mm:
3467         (-[NSSearchFieldCell _addStringToRecentSearches:]):
3468
3469 2006-10-27  David Harrison  <harrison@apple.com>
3470
3471         Reviewed by Maciej,
3472
3473         <rdar://problem/4003820> Expose blockquotes in AXAttributedStringForTextMarkerRange
3474
3475         * bridge/mac/WebCoreAXObject.mm:
3476         (blockquoteLevel):
3477         Calculate and return the blockquote level of the element.
3478         
3479         (AXAttributeStringSetBlockquoteLevel):
3480         Add, if non-zero, or clear the block quote level attribute.
3481         
3482         (AXAttributedStringAppendText):
3483         Send AXAttributeStringSetBlockquoteLevel.
3484
3485 2006-10-27  Darin Adler  <darin@apple.com>
3486
3487         - fix one error in the Qt build
3488
3489         * platform/qt/GraphicsContextQt.cpp:
3490         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
3491         Updated.
3492
3493 2006-10-27  Darin Adler  <darin@apple.com>
3494
3495         Reviewed by Maciej.
3496
3497         * WebCore.exp: Export more symbols needed by WebKit.
3498
3499 2006-10-26  Geoffrey Garen  <ggaren@apple.com>
3500
3501         Reviewed by the Baroness Esmeralda Von Scratch N' Purr XIV.
3502
3503         Fixed layout test crash. Oops.
3504         
3505         * loader/mac/WebDocumentLoader.mm:
3506         (WebCore::canonicalizedTitle):
3507
3508 2006-10-26  John Sullivan  <sullivan@apple.com>
3509
3510         Reviewed by Brady
3511         
3512         - fixed <rdar://problem/4806064> Repro crash in FrameMac::loadRequest following iTunes music store link from salon.com
3513         
3514         This restores some of the nil-handling that was implicit before some of the code was converted from
3515         Objective-C to C++.
3516
3517         * bridge/mac/FrameMac.mm:
3518         (WebCore::FrameMac::loadRequest):
3519         handle nil FrameMac
3520         
3521         * bridge/mac/WebCoreFrameBridge.mm:
3522         (-[WebCoreFrameBridge canTargetLoadInFrame:]):
3523         handle nil Frame
3524
3525 2006-10-26  Geoffrey Garen  <ggaren@apple.com>
3526
3527         Reviewed by Darin, Maciej.
3528
3529         Removed many uses of NSString *.
3530         Moved a few methods from WebCoreFrameBridge to FrameLoader, replacing 
3531         stringByCollapsingNonPrintingChara