04f2946d148bfb879959f54483da5104bf9b0ed9
[WebKit-https.git] / WebCore / ChangeLog
1 2009-03-06  Peter Kasting  <pkasting@google.com>
2
3         Build bustage fix.
4
5         * dom/Node.cpp:
6         (WebCore::Node::dispatchWheelEvent):
7
8 2009-03-06  Eric Carlson  <eric.carlson@apple.com>
9
10         Reviewed by Antti Koivisto.
11
12         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
13         (WebCore::MediaPlayerPrivate::createQTMovieView):  Delay callback while setting up movieview.
14
15 2009-03-06  Douglas R. Davidson  <ddavidso@apple.com>
16
17         Reviewed by Justin Garcia.
18         
19         https://bugs.webkit.org/show_bug.cgi?id=24108
20
21         Update spelling and grammar checking to use the new combined text 
22         checking (with automatic language identification) on Snow Leopard. 
23         Tested manually in Mail and Safari; automated tests to come later. 
24         
25         * editing/Editor.cpp:
26         (WebCore::findFirstMisspellingOrBadGrammarInRange):
27         (WebCore::Editor::advanceToNextMisspelling):
28         (WebCore::guessesForMisspelledOrUngrammaticalRange):
29         (WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection):
30         (WebCore::Editor::markMisspellingsAfterTypingToPosition):
31         (WebCore::markAllMisspellingsAndBadGrammarInRanges):
32         (WebCore::Editor::markMisspellingsAndBadGrammar):
33         * editing/Editor.h:
34         * loader/EmptyClients.h:
35         (WebCore::EmptyEditorClient::checkSpellingAndGrammarOfParagraph):
36         * page/EditorClient.h:
37         * page/Frame.cpp:
38         (WebCore::Frame::respondToChangedSelection):
39         * platform/ContextMenu.cpp:
40         (WebCore::ContextMenu::populate):
41
42 2009-03-06  Peter Kasting  <pkasting@google.com>
43
44         Reviewed by Darin Fisher.
45
46         https://bugs.webkit.org/show_bug.cgi?id=24407
47         Windows scroll amount was too small, and wheel scroll distance
48         conversion code was overly complex.
49
50         * page/EventHandler.cpp:
51         (WebCore::scrollAndAcceptEvent):
52         * platform/PlatformWheelEvent.h:
53         (WebCore::):
54         * platform/ScrollView.cpp:
55         (WebCore::ScrollView::wheelEvent):
56         * platform/Scrollbar.h:
57         * platform/gtk/WheelEventGtk.cpp:
58         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
59         * platform/mac/WheelEventMac.mm:
60         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
61         * platform/qt/WheelEventQt.cpp:
62         * platform/win/WheelEventWin.cpp:
63         (WebCore::horizontalScrollChars):
64         (WebCore::verticalScrollLines):
65         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
66         * platform/wx/MouseWheelEventWx.cpp:
67         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
68
69 2009-03-06  Dimitri Glazkov  <dglazkov@chromium.org>
70
71         Reviewed by Adam Roben.
72
73         Generate valid bindings with HTML5 database support disabled. 
74
75         * inspector/InspectorController.idl: Added feature guard around 
76         databaseTableNames definition.
77
78 2009-03-04  Xan Lopez  <xan@gnome.org>
79
80         Reviewed by Holger Freyther.
81
82         https://bugs.webkit.org/show_bug.cgi?id=24358
83         [GTK] Scrollbars not clipped correctly
84
85         Do not take into account the case of being a ScrollView scrollbar,
86         since those are native in our case.
87
88         * platform/gtk/ScrollbarGtk.cpp:
89         (ScrollbarGtk::frameRectsChanged):
90
91 2009-03-04  Xan Lopez  <xan@gnome.org>
92
93         Reviewed by Holger Freyther.
94
95         https://bugs.webkit.org/show_bug.cgi?id=24358
96         [GTK] Scrollbars not clipped correctly
97
98         Move Widget::paint to ScrollbarGtk::paint, since it's scrollbar
99         specific and it's our only Widget anyway.
100
101         * platform/gtk/ScrollbarGtk.cpp:
102         (ScrollbarGtk::paint):
103         * platform/gtk/ScrollbarGtk.h:
104         * platform/gtk/WidgetGtk.cpp:
105
106 2009-03-04  Xan Lopez  <xan@gnome.org>
107
108         Reviewed by Holger Freyther.
109
110         https://bugs.webkit.org/show_bug.cgi?id=24358
111         [GTK] Scrollbars not clipped correctly
112
113         Use correct clip rectangle and apply coordinate translation needed
114         for non-ScrollView scrollbars.
115
116         We were ignoring the clip rectangle passed as parameter, which is
117         wrong in the case of non coalesced expose events. This, in turn,
118         uncovers the fact that we were not applying coordinate translation
119         to our position.
120
121         * platform/gtk/WidgetGtk.cpp:
122         (WebCore::Widget::paint):
123
124 2009-03-06  Eric Carlson  <eric.carlson@apple.com>
125
126         Build fix, no review
127
128         * platform/graphics/chromium/MediaPlayerPrivateChromium.h: fix setSize declaration
129
130 2009-03-06  Eric Carlson  <eric.carlson@apple.com>
131
132         Reviewed by Simon Fraser.
133
134         https://bugs.webkit.org/show_bug.cgi?id=22790
135         Bug 22790: [Transforms] MediaPlayer::setRect() makes no sense with transforms
136         Replace media engine setRect with setSize since they don't use about the 
137         position anyway.
138
139         * platform/graphics/MediaPlayer.cpp:
140         (WebCore::NullMediaPlayerPrivate::setSize): Changed from setRect.
141         (WebCore::MediaPlayer::setSize): Ditto.
142         * platform/graphics/MediaPlayer.h:
143         (WebCore::MediaPlayer::size): Changed from rect().
144
145         * platform/graphics/MediaPlayerPrivate.h: Changed setRect to setSize.
146
147         * platform/graphics/chromium/MediaPlayerPrivateChromium.h: Ditto.
148
149         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: 
150         (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_size instead of m_rect
151         (WebCore::MediaPlayerPrivate::setSize): Changed from setRect
152         (WebCore::MediaPlayerPrivate::paint): update comment
153         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h: m_rect -> m_size.
154
155         * platform/graphics/mac/MediaPlayerPrivateQTKit.h:  m_rect
156         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
157         (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_rect.
158         (WebCore::MediaPlayerPrivate::createQTMovieView): setRect-> setSize.
159         (WebCore::MediaPlayerPrivate::setSize): Changed from setRect
160         (WebCore::MediaPlayerPrivate::paint): Call view:setFrame: when in a media document so 
161         the movie is drawn in the correct location.
162
163         * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
164         (WebCore::MediaPlayerPrivate::setSize):  Changed from setRect
165         * platform/graphics/qt/MediaPlayerPrivatePhonon.h:
166
167         * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
168         (WebCore::MediaPlayerPrivate::setSize):  Changed from setRect
169         * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
170
171         * rendering/RenderVideo.cpp:
172         (WebCore::RenderVideo::updatePlayer): Call setSize instead of setRect.
173
174 2009-03-06  Darin Adler  <darin@apple.com>
175
176         Reviewed by Darin Fisher.
177
178         Bug 24422: REGRESSION: null-URL crash in FrameLoader setting location.hash on new window
179         https://bugs.webkit.org/show_bug.cgi?id=24422
180         rdar://problem/6402208
181
182         Test: fast/dom/location-new-window-no-crash.html
183
184         The issue here is empty (or null) URLs. I picked the "schedule navigation" bottleneck
185         to add some checks for empty URLs. We could also put the empty URL checks at some
186         other bottleneck level and add more assertions over time. I tried adding a few more
187         assertions to functions like loadURL and hit them while running the regression tests,
188         so it's probably going to be a bit tricky to clean this up throughout the loader.
189
190         * loader/FrameLoader.cpp:
191         (WebCore::ScheduledRedirection::ScheduledRedirection): Explicitly marked this struct
192         immutable by making all its members const. Added assertions about the arguments,
193         including that the URL is not empty. Initialized one uninitialized member in one of
194         the constructors.
195         (WebCore::FrameLoader::scheduleHTTPRedirection): Added an early exit to make this
196         a no-op if passed an empty URL.
197         (WebCore::FrameLoader::scheduleLocationChange): Ditto.
198         (WebCore::FrameLoader::scheduleRefresh): Ditto.
199
200 2009-03-06  Gustavo Noronha Silva  <gns@gnome.org>
201
202         Reviewed by Holger Freyther.
203
204         https://bugs.webkit.org/show_bug.cgi?id=24423
205         Use new soup_message_body_set_accumulate API in soup backend
206
207         Disable accumulating chunks for request_body on file uploads,
208         using the new soup API.
209
210         * platform/network/soup/ResourceHandleSoup.cpp:
211         (WebCore::ResourceHandle::startHttp):
212
213 2009-03-06  Gustavo Noronha Silva  <gns@gnome.org>
214
215         Reviewed by Holger Freyther.
216
217         Replace use of deprecated SOUP_MESSAGE_OVERWRITE_CHUNKS flag with
218         the new soup_message_body_set_accumulate API in soup.
219
220         * platform/network/soup/ResourceHandleSoup.cpp:
221         (WebCore::gotHeadersCallback):
222         (WebCore::ResourceHandle::startHttp):
223
224 2009-03-06  Gustavo Noronha Silva  <gns@gnome.org>
225
226         Reviewed by Holger Freyther.
227
228         https://bugs.webkit.org/show_bug.cgi?id=24051
229         Soup backend needs content sniffing capabilities
230
231         Perform content sniffing when using soup, so that we have a chance
232         of figuring out the Content-Type of the file if it's not sent by
233         the server.
234
235         * platform/network/ResourceHandleInternal.h:
236         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
237         * platform/network/soup/ResourceHandleSoup.cpp:
238         (WebCore::gotHeadersCallback):
239         (WebCore::gotChunkCallback):
240
241 2009-03-06  Hironori Bono  <hbono@chromium.org>
242
243         Reviewed by Alexey Proskuryakov.
244
245         https://bugs.webkit.org/show_bug.cgi?id=24342
246         Cannot insert a Thai character after a Thai prepend character when using ICU 4.0
247
248         This change creates a new break iterator "cursorMovementIterator" for
249         moving cursors and use it when moving an input cursor.
250         In "TextBreakIteratorICU.cpp", this break iterator uses custom ruleset
251         based on the one of ICU 3.8.
252         On the other hand, in "TextBreakIteratorQt.cpp", this break iterator
253         just calls the characterBreakIterator() function.
254
255         Test: editing/inserting/insert-thai-characters-001.html
256
257         * platform/text/TextBreakIterator.h: Added a new function cursorMovementIterator().
258         * platform/text/TextBreakIteratorICU.cpp: Implemented the cursorMovementIterator() function for ICU.
259         (WebCore::setUpIteratorWithRules): Ditto.
260         (WebCore::cursorMovementIterator): Ditto.
261         * platform/text/qt/TextBreakIteratorQt.cpp: Implemented the cursorMovementIterator() function for Qt.
262         (WebCore::cursorMovementIterator): Ditto.
263         * rendering/RenderText.cpp: Call the cursorMovementIterator() function when moving an input cursor.
264         (WebCore::RenderText::previousOffset): Ditto.
265         (WebCore::RenderText::nextOffset): Ditto.
266
267 2009-03-05  Alexey Proskuryakov  <ap@webkit.org>
268
269         Reviewed by Oliver Hunt.
270
271         <rdar://problem/6621701> Safari 4 Beta Breaks XMLHttpRequest Response Text With Special
272         Characters (a compatibility issue with widgets).
273
274         Test: http/tests/xmlhttprequest/broken-xml-encoding.html
275
276         Revert part of an Acid 3 fix - now we are no longer strict when decoding XMLHttpRequest XML
277         responses.
278
279         * loader/TextResourceDecoder.cpp:
280         (WebCore::TextResourceDecoder::TextResourceDecoder):
281         (WebCore::TextResourceDecoder::decode):
282         (WebCore::TextResourceDecoder::flush):
283         * loader/TextResourceDecoder.h:
284         (WebCore::TextResourceDecoder::useLenientXMLDecoding):
285         Don't stop on XML decoding errors if useLenientXMLDecoding() was called.
286
287         * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didReceiveData): Don't stop on XML
288         decoding errors. This behavior is now limited to other kinds of XML content.
289
290 2009-03-05  Simone Fiorentino  <simone.fiorentino@consulenti.fastweb.it>
291
292         Bug 24382: request to add SH4 platform
293
294         <https://bugs.webkit.org/show_bug.cgi?id=24382>
295
296         Reviewed by David Kilzer.
297
298         * platform/text/AtomicString.cpp:
299         (WebCore::equal): Aligned memory access on SH4 platform.
300
301 2009-03-05  Jeremy Moskovich  <jeremy@chromium.org>
302
303         Reviewed by Simon Fraser.
304
305         Fix for https://bugs.webkit.org/show_bug.cgi?id=24215
306
307         Gears expects an object tag with display:none to instantiate the plugin,
308         so we add a workaround to make this work and fix Gears on WebKit trunk.
309
310         * html/HTMLObjectElement.cpp:
311         (WebCore::HTMLObjectElement::rendererIsNeeded):
312
313 2009-03-05  Avi Drissman  <avi@chromium.org>
314
315         Reviewed by Darin Fisher.
316
317         Need to have Chromium Mac match Safari Mac's accesskey handling
318         https://bugs.webkit.org/show_bug.cgi?id=24404
319
320         * page/chromium/EventHandlerChromium.cpp:
321         (WebCore::EventHandler::accessKeyModifiers): Share access key modifiers with Mac Safari when building for the Mac.
322
323 2009-03-05  Simon Fraser  <simon.fraser@apple.com>
324
325         Reviewed by Dave Hyatt
326
327         https://bugs.webkit.org/show_bug.cgi?id=24412
328         
329         Fix crash when hit-testing elements with -webkit-transform-style: preserve-3d
330         but no transform. We need to make localTransformState if we see preserve-3d.
331         Also need to call update3DTransformedDescendantStatus() before we test
332         m_has3DTransformedDescendant.
333
334         Test: transforms/3d/hit-testing/hit-preserves-3d.html
335
336         * rendering/RenderLayer.cpp:
337         (WebCore::RenderLayer::hitTestLayer):
338
339 2009-03-05  Eric Seidel  <eric@webkit.org>
340
341         Reviewed by David Hyatt.
342
343         Changes to RenderLayer destruction to hopefully help catch an elusive crasher
344         https://bugs.webkit.org/show_bug.cgi?id=24409
345         
346         Added a new RenderBoxModelObject::destroyLayer() call which is
347         now the only way which RenderLayers should ever be destroyed.
348         This ensures that the pointer to the layer is cleared in the
349         RenderObject after destruction, allowing us to ASSERT in the
350         RenderBoxModelObject destructor.
351
352         * rendering/RenderBox.cpp:
353         (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
354         * rendering/RenderBoxModelObject.cpp:
355         (WebCore::RenderBoxModelObject::~RenderBoxModelObject):
356         (WebCore::RenderBoxModelObject::destroyLayer):
357         (WebCore::RenderBoxModelObject::destroy):
358         (WebCore::RenderBoxModelObject::styleDidChange):
359         * rendering/RenderBoxModelObject.h:
360         * rendering/RenderLayer.cpp:
361         (WebCore::RenderLayer::stackingContext):
362         (WebCore::RenderLayer::destroy):
363         (WebCore::RenderLayer::removeOnlyThisLayer):
364         * rendering/RenderLayer.h:
365         * rendering/RenderObject.cpp:
366         (WebCore::RenderObject::destroy):
367         * rendering/RenderWidget.cpp:
368         (WebCore::RenderWidget::destroy):
369
370 2009-03-05  Eric Seidel  <eric@webkit.org>
371
372         Reviewed by David Hyatt.
373
374         Remove old, unused IE 5.5 scrollbar-* CSS properties.
375         Sort the unimplemented getComputedStyle properties so it's
376         easier to see which ones actually need implementation.
377
378         * css/CSSComputedStyleDeclaration.cpp:
379         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
380         * css/CSSParser.cpp:
381         (WebCore::CSSParser::parseValue):
382         * css/CSSPropertyNames.in:
383         * css/CSSStyleSelector.cpp:
384         (WebCore::CSSStyleSelector::applyProperty):
385
386 2009-03-05  Justin Garcia  <justin.garcia@apple.com>
387
388         Reviewed by Darin Adler.
389         
390         WebViewDidChangeSelectionNotifications weren't being sent for commands that change the selection's position
391         within the document without changing its position in the DOM.  For example, pressing return in (caret marked by ^):
392         <div contentEditable="true"><div>^Hello</div></div>
393         Undo was being enabled, shouldDeleteDOMRange called, etc. when doing no-op deletes (a delete in an empty document 
394         for example). 
395
396         Changes to layout tests demonstrate fix.
397         
398         * editing/EditCommand.cpp:
399         (WebCore::EditCommand::apply): Don't call applyEditing for a TypingCommand.  The TypingCommand knows whether or
400         not it did work that needs to be applied.
401         * editing/Editor.cpp:
402         (WebCore::Editor::appliedEditing): Moved code (but did not alter) to changeSelectionAfterCommand.
403         (WebCore::Editor::unappliedEditing): Ditto.
404         (WebCore::Editor::reappliedEditing): Ditto.
405         (WebCore::Editor::changeSelectionAfterCommand): Moved code from *appliedEditing into here.  Also call out to
406         EditorClient::respondToChangedSelection() for commands that changed the selection's position in the document
407         even if they did not change it's position in the DOM.  Any TypingCommand that gets this far changed it's position
408         in the document.
409         * editing/Editor.h:
410         * editing/TypingCommand.cpp:
411         (WebCore::TypingCommand::TypingCommand): Removed unused m_appliedEditing.
412         (WebCore::TypingCommand::typingAddedToOpenCommand): Always apply editing.  We won't get this far if we don't need to.
413         (WebCore::TypingCommand::deleteKeyPressed): Don't do any of the things that only make sense for Range selections, like
414         adding to the killring and responding to a change in selections if the delete was a no-op.
415         (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
416         * editing/TypingCommand.h:
417
418 2009-03-05  Dimitri Glazkov  <dglazkov@chromium.org>
419
420         Reviewed by Adam Roben.
421
422         Eliminate a ref-counting leak in InspectorController.
423
424         * inspector/InspectorController.h: Made constructor private, added static create method.
425         * page/Page.cpp:
426         (WebCore::Page::Page): Change initializer to use static create method.
427
428 2009-03-05  Dimitri Glazkov  <dglazkov@chromium.org>
429
430         Reviewed by Timothy Hatcher.
431
432         https://bugs.webkit.org/show_bug.cgi?id=24355
433         Add InspectorController.idl and convert InspectorController.cpp to use
434         JSC bindings.
435
436         * DerivedSources.make: Added InspectorController.idl
437         * WebCore.xcodeproj/project.pbxproj: Added idl, bindings files.
438         * bindings/js/JSInspectorControllerCustom.cpp: Added.
439         * bindings/scripts/CodeGeneratorJS.pm: Added Array to no-header types.
440         * inspector/InspectorController.cpp: Removed hand-rolled bindings.
441         * inspector/InspectorController.h: Added platform and addSourceToFrame methods.
442         * inspector/InspectorController.idl: Added.
443         * page/Page.h: Changed member to RefPtr since InspectorController is now ref-counted.
444
445 2009-03-05  Eric Carlson  <eric.carlson@apple.com>
446
447         Reviewed by Simon Fraser.
448
449         https://bugs.webkit.org/show_bug.cgi?id=24400
450         Bug 24400: Remove "start", "end", "loopStart", "loopEnd", "currentLoop", and "playCount" 
451         media element attributes
452
453         Test: media/video-loop.html
454
455         * html/HTMLMediaElement.cpp:
456         (WebCore::HTMLMediaElement::HTMLMediaElement):
457         (WebCore::HTMLMediaElement::loadInternal):
458         (WebCore::HTMLMediaElement::setNetworkState):
459         (WebCore::HTMLMediaElement::seek):
460         (WebCore::HTMLMediaElement::playInternal):
461         (WebCore::HTMLMediaElement::loop):
462         (WebCore::HTMLMediaElement::setLoop):
463         (WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
464         (WebCore::HTMLMediaElement::endedPlayback):
465         (WebCore::HTMLMediaElement::updatePlayState):
466         * html/HTMLMediaElement.h:
467         * html/HTMLMediaElement.idl:
468
469 2009-03-05  Steve Falkenburg  <sfalken@apple.com>
470
471         <rdar://problem/6651112> Safari asks about re-posting a form even when page is cached
472         
473         Reviewed by Ada Chan.
474
475         * platform/network/cf/ResourceHandleCFNet.cpp:
476         (WebCore::ResourceHandle::willLoadFromCache): Ported from Mac version.
477
478 2009-03-05  David Hyatt  <hyatt@apple.com>
479
480         Reviewed by Eric Seidel
481
482         https://bugs.webkit.org/show_bug.cgi?id=24248
483
484         Make sure painting of overflow controls checks that visibility:visible is set on the block before
485         painting.  Pixel tests caught this regression.
486
487         Make sure resizer painting pushes a clip of the corner rect.  It was relying on the clip layers happened
488         to do to their bounds (which had nothing to do with overflow).
489
490         * rendering/RenderBlock.cpp:
491         (WebCore::RenderBlock::paint):
492         * rendering/RenderLayer.cpp:
493         (WebCore::RenderLayer::paintResizer):
494
495 2009-03-05  Yong Li  <yong.li@torchmobile.com>
496
497         Reviewed by Simon Fraser.
498
499         https://bugs.webkit.org/show_bug.cgi?id=24386
500         A faster implementation of extractMIMETypeFromMediaType.
501
502         * platform/network/HTTPParsers.cpp:
503         (WebCore::extractMIMETypeFromMediaType):
504
505 2009-03-05  Yong Li  <yong.li@torchmobile.com>
506
507         Reviewed by Antti Koivisto.
508
509         https://bugs.webkit.org/show_bug.cgi?id=24392
510         Do not get the current time for unless we're doing PRELOAD_DEBUG as this
511         can be unnecessarily expensive.
512
513         * html/PreloadScanner.cpp:
514         (WebCore::PreloadScanner::write):
515
516 2009-03-04  Simon Fraser  <simon.fraser@apple.com>
517
518         Reviewed by Dave Hyatt
519
520         https://bugs.webkit.org/show_bug.cgi?id=24327
521         
522         When mapping points and hit testing through transforms, work
523         correctly when acclerated animations of transforms are running.
524         
525         Tested by LayoutTests/animations/animation-hit-test-transform.html,
526         which only failed when ACCELERATED_COMPOSITING was turned on.
527
528         * rendering/RenderLayer.cpp:
529         (WebCore::RenderLayer::currentTransform):
530         * rendering/RenderLayer.h:
531         * rendering/RenderObject.cpp:
532         (WebCore::RenderObject::transformFromContainer):
533
534 2009-03-05  Mike Belshe  <mike@belshe.com>
535
536         Reviewed by Darin Fisher.
537
538         https://bugs.webkit.org/show_bug.cgi?id=24391
539         Frame.cpp uses JSC specific includes
540
541         * page/Frame.cpp:
542
543 2009-03-05  Gustavo Noronha Silva  <gns@gnome.org>
544
545         Reviewed by Alexey Proskuryakov.
546
547         https://bugs.webkit.org/show_bug.cgi?id=24389
548         WebKitGTK+ crashes when cancelling plugin loads
549
550         Remove bogus calls to the client's didFinishLoading method from
551         our ResourceHandle::cancel implementation. Calling
552         didFinishLoading here is mostly inoffensive for most loads, but
553         causes crashes when plugin loads are cancelled.
554
555         * platform/network/soup/ResourceHandleSoup.cpp:
556         (WebCore::ResourceHandle::cancel):
557
558 2009-03-05  Steve Falkenburg  <sfalken@apple.com>
559
560         Windows build fix.
561         
562         * WebCore.vcproj/QTMovieWin.vcproj:
563
564 2009-03-05  Adam Treat  <adam.treat@torchmobile.com>
565
566         Build fix for when ENABLE_NETSCAPE_PLUGIN_API = 0.  The method
567         ScriptController::jsObjectForPluginElement(HTMLPlugInElement*); is not
568         protected by an #if and uses HTMLPlugInElement so it must be included.
569
570         * bindings/js/ScriptController.cpp:
571
572 2009-03-05  Dimitri Glazkov  <dglazkov@chromium.org>
573
574         GTK Build fix.
575
576         * inspector/ConsoleMessage.h: Use proper header.
577
578 2009-03-05  Dimitri Glazkov  <dglazkov@chromium.org>
579
580         Reviewed by Timothy Hatcher.
581
582         https://bugs.webkit.org/show_bug.cgi?id=24376
583         Split InspectorController.cpp file into separate classes.
584
585         * GNUmakefile.am: Modified to include new files.
586         * WebCore.pro: Ditto.
587         * WebCore.scons: Ditto.
588         * WebCore.vcproj/WebCore.vcproj: Ditto.
589         * WebCore.xcodeproj/project.pbxproj: Ditto.
590         * WebCoreSources.bkl: Ditto.
591         * inspector/ConsoleMessage.cpp: Added.
592         * inspector/ConsoleMessage.h: Added.
593         * inspector/InspectorController.cpp:
594         * inspector/InspectorDOMStorageResource.cpp: Added.
595         * inspector/InspectorDOMStorageResource.h: Added.
596         * inspector/InspectorDatabaseResource.cpp: Added.
597         * inspector/InspectorDatabaseResource.h: Added.
598         * inspector/InspectorResource.cpp: Added.
599         * inspector/InspectorResource.h: Added.
600
601 2009-03-05  Eric Carlson  <eric.carlson@apple.com>
602
603         Reviewed by Darin Adler
604
605         https://bugs.webkit.org/show_bug.cgi?id=24387
606         Remove media element bufferingRate attribute. No test necessary as there
607         were none for this attribute.
608
609         * html/HTMLMediaElement.cpp:
610         (WebCore::HTMLMediaElement::HTMLMediaElement): Don't initialize m_bufferingRate.
611         (WebCore::HTMLMediaElement::loadInternal): Ditto.
612         (WebCore::HTMLMediaElement::setNetworkState): Ditto.
613         (WebCore::HTMLMediaElement::progressEventTimerFired): Don't calculate m_bufferingRate.
614         * html/HTMLMediaElement.h: Remove m_bufferingRate.
615         * html/HTMLMediaElement.idl: Ditto.
616
617 2009-03-05  Xan Lopez  <xan@gnome.org>
618
619         Reviewed by Mark Rowe.
620
621         https://bugs.webkit.org/show_bug.cgi?id=24377
622         [GTK] Comply better with coding style guidelines in ResourceHandleSoup
623
624         Use C++ booleans, 0 instead of NULL, prefix boolean variables with
625         'is', do not use 'else if' if the previous if had a return, delete
626         trailing whitespace, etc.
627
628         * platform/network/ResourceHandleInternal.h:
629         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
630         * platform/network/soup/ResourceHandleSoup.cpp:
631         (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
632         (WebCore::fillResponseFromMessage):
633         (WebCore::restartedCallback):
634         (WebCore::finishedCallback):
635         (WebCore::parseDataUrl):
636         (WebCore::ensureSessionIsInitialized):
637         (WebCore::ResourceHandle::startHttp):
638         (WebCore::reportUnknownProtocolError):
639         (WebCore::ResourceHandle::start):
640         (WebCore::cleanupGioOperation):
641         (WebCore::closeCallback):
642         (WebCore::readCallback):
643         (WebCore::openCallback):
644         (WebCore::queryInfoCallback):
645         (WebCore::ResourceHandle::startGio):
646
647 2009-03-04  Simon Fraser  <simon.fraser@apple.com>
648
649         Reviewed by Eric Seidel
650
651         https://bugs.webkit.org/show_bug.cgi?id=24328
652         
653         If an element has backface-visibility: hidden, hit testing should not
654         hit the back sides of elements. Test for that by inverting the accumulated
655         transform and looking at the z vector.
656
657         Tested by transforms/3d/hit-testing/backface-hit-test.html
658         
659         * rendering/RenderLayer.cpp:
660         (WebCore::RenderLayer::hitTestLayer):
661
662 2009-03-04  Adam Langley  <agl@google.com>
663
664         Reviewed by Darin Fisher.
665
666         r41362 mistakenly added functions "RenderThemeWin::" into
667         RenderThemeChromiumGtk.cpp. When correcting this, I somehow changed
668         them to void return types. This patch switches them back to ints.
669
670         https://bugs.webkit.org/show_bug.cgi?id=24360
671
672         * rendering/RenderThemeChromiumLinux.cpp:
673         (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingLeft):
674         (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingRight):
675         (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingTop):
676         (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingBottom):
677
678 2009-03-04  Adam Langley  <agl@google.com>
679
680         Reviewed by Darin Fisher.
681
682         Chromium Linux: change some metrics to better match Windows after
683         r41416. Aesthetically this may be worse, but web-compat is king.
684
685         Also, the previous code had an off by one error when drawing
686         scrollbars which caused the scrollbar to overflow it's bounds by 1px
687         at the right and bottom edges.
688
689         https://bugs.webkit.org/show_bug.cgi?id=24369
690
691         * rendering/RenderThemeChromiumLinux.cpp:
692         (WebCore::):
693         (WebCore::RenderThemeChromiumLinux::systemFont):
694         * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
695         (WebCore::ScrollbarThemeChromium::paintTrackPiece):
696
697 2009-03-04  Eric Seidel  <eric@webkit.org>
698
699         Reviewed by Adam Roben.
700
701         Add an ASSERT to better demonstrate the cause of the crash in
702         https://bugs.webkit.org/show_bug.cgi?id=23736
703
704         * loader/DocLoader.cpp:
705         (WebCore::DocLoader::~DocLoader):
706
707 2009-03-04  David Levin  <levin@chromium.org>
708
709         Reviewed by Alexey Proskuryakov.
710
711         Bug 24337: Assert when doing sync XHR in a worker for a cacheable response.
712         <https://bugs.webkit.org/show_bug.cgi?id=24337>
713
714         Tests: http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html
715                http/tests/xmlhttprequest/workers/xmlhttprequest-file-not-found.html
716
717         * loader/mac/ResourceLoaderMac.mm:
718         (WebCore::ResourceLoader::willCacheResponse):
719         An identifier is only asssigned if resource load callbacks are done.  So don't send
720         willCacheResponse which uses identifier if resource load callbacks aren't being sent.
721
722 2009-03-04  David Levin  <levin@chromium.org>
723
724         Reviewed by Alexey Proskuryakov.
725
726         Bug 24330: Sync xhr in workers should send an abort exception when the worker is terminated.
727         <https://bugs.webkit.org/show_bug.cgi?id=24330>
728
729         Test: http/tests/xmlhttprequest/workers/abort-exception-assert.html
730
731         * dom/ExceptionCode.cpp:
732         (WebCore::xmlHttpRequestExceptionNames):
733         Added missing ABORT_ERR whose absence caused an assert.
734
735         * loader/WorkerThreadableLoader.cpp:
736         (WebCore::WorkerThreadableLoader::loadResourceSynchronously):
737         (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel):
738         Add more logic to handle the termination case for sync xhr.
739
740 2009-03-04  Eric Carlson  <eric.carlson@apple.com>
741
742         Reviewed by Antti Koivisto.
743
744         https://bugs.webkit.org/show_bug.cgi?id=24364
745         Add support for HTMLMediaElement canPlayType method. Make
746         MediaPlayer::supportsType take a ContentType instead of a
747         separate mime type and codecs parameter.
748
749         Test: media/video-can-play-type.html
750
751         * dom/DOMImplementation.cpp:
752         (WebCore::DOMImplementation::createDocument):
753         * html/HTMLMediaElement.cpp:
754         (WebCore::HTMLMediaElement::canPlayType): Add canPlayType method.
755         (WebCore::HTMLMediaElement::loadInternal): selectMediaURL returns a ContentType.
756         (WebCore::HTMLMediaElement::selectMediaURL): Return a ContentType instead of raw MIME type.
757         (WebCore::HTMLMediaElement::initialURL): selectMediaURL returns a ContentType.
758         * html/HTMLMediaElement.h: Add prototype.
759         * html/HTMLMediaElement.idl: Ditto.
760         * platform/graphics/MediaPlayer.cpp:
761         (WebCore::MediaPlayer::load): Take a ContentType instead of raw MIME type.
762         (WebCore::MediaPlayer::supportsType): Ditto.
763         * platform/graphics/MediaPlayer.h:
764
765 2009-03-04  Antti Koivisto  <antti@apple.com>
766
767         Reviewed by Dave Hyatt.
768
769         https://bugs.webkit.org/show_bug.cgi?id=24359
770         Repaint throttling mechanism
771         
772         Excessive repainting can slow down page loadind. This implements a timer
773         based throttling mechanism. It is behind ENABLE(REPAINT_THROTTLING) and not 
774         enabled by default.
775
776         * loader/FrameLoader.cpp:
777         (WebCore::FrameLoader::checkCompleted):
778         * page/EventHandler.cpp:
779         (WebCore::EventHandler::dispatchDragEvent):
780         (WebCore::EventHandler::dispatchMouseEvent):
781         (WebCore::EventHandler::keyEvent):
782         (WebCore::EventHandler::handleTextInputEvent):
783         * page/FrameView.cpp:
784         (WebCore::FrameView::FrameView):
785         (WebCore::FrameView::reset):
786         (WebCore::FrameView::repaintContentRectangle):
787         (WebCore::FrameView::beginDeferredRepaints):
788         (WebCore::FrameView::endDeferredRepaints):
789         (WebCore::FrameView::checkStopDelayingDeferredRepaints):
790         (WebCore::FrameView::doDeferredRepaints):
791         (WebCore::FrameView::updateDeferredRepaintDelay):
792         (WebCore::FrameView::resetDeferredRepaintDelay):
793         (WebCore::FrameView::adjustedDeferredRepaintDelay):
794         (WebCore::FrameView::deferredRepaintTimerFired):
795         (WebCore::FrameView::paintContents):
796         * page/FrameView.h:
797
798 2009-03-04  Sam Weinig  <sam@webkit.org>
799
800         Rubber-stamped by Antti Koivisto.
801
802         Remove LOW_BANDWIDTH_DISPLAY as it is not being used by any platforms.
803
804         * dom/Document.cpp:
805         (WebCore::Document::Document):
806         * dom/Document.h:
807         (WebCore::Document::haveStylesheetsLoaded):
808         * html/HTMLTokenizer.cpp:
809         (WebCore::HTMLTokenizer::scriptHandler):
810         * loader/Cache.cpp:
811         (WebCore::Cache::requestResource):
812         * loader/CachedCSSStyleSheet.cpp:
813         (WebCore::CachedCSSStyleSheet::checkNotify):
814         * loader/DocLoader.h:
815         * loader/FrameLoader.cpp:
816         (WebCore::FrameLoader::FrameLoader):
817         (WebCore::FrameLoader::requestFrame):
818         (WebCore::FrameLoader::stopLoading):
819         (WebCore::FrameLoader::begin):
820         (WebCore::FrameLoader::write):
821         (WebCore::FrameLoader::endIfNotLoadingMainResource):
822         (WebCore::FrameLoader::checkCompleted):
823         (WebCore::FrameLoader::requestObject):
824         (WebCore::FrameLoader::loadItem):
825         * loader/FrameLoader.h:
826
827 2009-03-02  Xan Lopez  <xan@gnome.org>
828
829         Reviewed by Mark Rowe.
830
831         https://bugs.webkit.org/show_bug.cgi?id=24287
832         [GTK] Move auth dialog feature to WebKit/
833
834         Remove WebKitSoupAuthDialog files from build and stop using it.
835
836         * GNUmakefile.am:
837         * platform/network/soup/ResourceHandleSoup.cpp:
838         (WebCore::ensureSessionIsInitialized):
839         * platform/network/soup/webkit-soup-auth-dialog.c: Removed.
840         * platform/network/soup/webkit-soup-auth-dialog.h: Removed.
841
842 2009-03-04  Simon Fraser  <simon.fraser@apple.com>
843
844         Reviewed by Dave Hyatt
845         
846         https://bugs.webkit.org/show_bug.cgi?id=24361
847         
848         Reinstate code that sets result.innerNode when hitTest() returns true,
849         but never filled in the innerNode. Fixes hit testing of generated content.
850
851         Test: fast/css-generated-content/hit-test-generated-content.html
852
853         * rendering/RenderLayer.cpp:
854         (WebCore::RenderLayer::hitTestContents):
855
856 2009-03-04  Adam Barth  <abath@webkit.org>
857
858         Reviewed by Alexey Proskuryakov.
859
860         https://bugs.webkit.org/show_bug.cgi?id=24356
861
862         Fix WebKit style for allowUniversalAccessFromFileURLs.
863
864         * WebCore.base.exp:
865         * dom/Document.cpp:
866         (WebCore::Document::initSecurityContext):
867         * page/Settings.cpp:
868         (WebCore::Settings::Settings):
869         (WebCore::Settings::setAllowUniversalAccessFromFileURLs):
870         * page/Settings.h:
871         (WebCore::Settings::allowUniversalAccessFromFileURLs):
872
873 2009-03-04  Brady Eidson  <beidson@apple.com>
874
875         Reviewed by Darin Adler
876
877         <rdar://problem/6619630> Quick Look of vCards stuck on image of first card opened.
878
879         I narrowed this down to http://trac.webkit.org/changeset/39304 which, among other things,
880         consolidated some of the various decision making pieces of the Cache into the new method
881         FrameLoader::cachePolicy().
882
883         Before 39304, when deciding whether to use an existing CachedResource, we checked if the FrameLoader 
884         is reloading.  If it is, we'd evict any existing resource then recreate it.  Quick looks uses the
885         same URL for this image every time and expects it to be reloaded with each new card.
886
887         The FrameLoader::isReloading() check did one thing - Ask the DocumentLoader if it's cache policy
888         is "ReloadIgnoringCacheData".  This check was lost in the consolidation to the new method.  
889
890         * loader/FrameLoader.cpp:
891         (WebCore::FrameLoader::cachePolicy): Restore the DocumentLoader's cachePolicy check as a possible
892           condition for returning CachePolicyReload.
893
894 2009-03-04  Timothy Hatcher  <timothy@apple.com>
895
896         * English.lproj/localizedStrings.js: Update strings to include "DATABASES",
897         "LOCAL STORAGE" and "SESSION STORAGE".
898
899 2009-03-04  Timothy Hatcher  <timothy@apple.com>
900
901         Fix a regression where the Web Inspector console would not animate
902         in or out correctly.
903
904         Reviewed by Anders Carlsson.
905
906         * inspector/front-end/inspector.css: Move a z-index to a child element
907         to get the correct stacking order during the animation.
908
909 2009-03-03  David Hyatt  <hyatt@apple.com>
910
911         https://bugs.webkit.org/show_bug.cgi?id=24201, pathologically bad block layout.
912
913         Make sure to factor clear deltas into y position estimates.  Also avoid doing the comparison of
914         the final position against the y position estimate until after the clear has happened.  This gets rid
915         of some duplicated cut/pasted code and also ensures a layout delta only has to be put in once.
916
917         Reviewed by Dan Bernstein
918
919         Added fast/block/float/nested-clearance.html
920
921         * rendering/RenderBlock.cpp:
922         (WebCore::RenderBlock::collapseMargins):
923         (WebCore::RenderBlock::clearFloatsIfNeeded):
924         (WebCore::RenderBlock::estimateVerticalPosition):
925         (WebCore::RenderBlock::layoutBlockChildren):
926         (WebCore::RenderBlock::getClearDelta):
927         * rendering/RenderBlock.h:
928
929 2009-03-02  Kim Grönholm  <kim.gronholm@nomovok.com>
930
931         Reviewed by Simon Hausmann.
932
933         Improvement to 3d transformations rendering in QtWebKit. QTransform is used
934         instead of QMatrix. This allows perspective transformations since QTransform is
935         a true 3x3 matrix.
936
937         * platform/graphics/qt/GraphicsContextQt.cpp: Use QTransform instead of QMatrix everywhere.
938         (WebCore::GraphicsContext::getCTM):
939         (WebCore::GraphicsContext::restorePlatformState):
940         (WebCore::GraphicsContext::fillPath):
941         (WebCore::GraphicsContext::strokePath):
942         (WebCore::GraphicsContext::fillRect):
943         (WebCore::GraphicsContext::translate):
944         (WebCore::GraphicsContext::rotate):
945         (WebCore::GraphicsContext::scale):
946         (WebCore::GraphicsContext::concatCTM):
947         * platform/graphics/qt/ImageQt.cpp:
948         (WebCore::Image::drawPattern):
949         * platform/graphics/qt/PathQt.cpp:
950         (WebCore::Path::translate):
951         (WebCore::Path::transform):
952         * platform/graphics/qt/PatternQt.cpp:
953         (WebCore::Pattern::createPlatformPattern):
954         * platform/graphics/qt/TransformationMatrixQt.cpp:
955         (WebCore::TransformationMatrix::operator QTransform): Replace the conversion operator
956         to QMatrix with one to QTransform.
957         * platform/graphics/transforms/TransformationMatrix.h:
958         * platform/graphics/qt/FontQt.cpp:
959
960 2009-02-24  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
961
962         Reviewed by Simon Hausmann.
963
964         https://bugs.webkit.org/show_bug.cgi?id=24151
965         Fix Qt/S60 build break
966
967         * platform/FileSystem.h: Create a default case for non-win and non-mac Qt builds
968         * platform/qt/FileSystemQt.cpp: Ditto
969         (WebCore::unloadModule):
970
971 2009-03-03  Mike Belshe  <mike@belshe.com>
972
973         Reviewed by Alexey Proskuryakov.
974
975         https://bugs.webkit.org/show_bug.cgi?id=21939
976         Uninitialized ExceptionCode in DOMWindow::postMessage
977
978         * dom/MessagePort.cpp:
979         (WebCore::MessagePort::postMessage):
980
981 2009-03-03  David Kilzer  <ddkilzer@apple.com>
982
983         <rdar://problem/6581203> WebCore and WebKit should install the same set of headers during installhdrs phase as build phase
984
985         Reviewed by Mark Rowe.
986
987         The fix is to add INSTALLHDRS_COPY_PHASE = YES and
988         INSTALLHDRS_SCRIPT_PHASE = YES to WebCore.xcconfig, then to make
989         sure various build phase scripts work with the installhdrs build
990         phase.
991
992         * Configurations/Base.xcconfig: Defined REAL_PLATFORM_NAME
993         based on PLATFORM_NAME to work around the missing definition on
994         Tiger.
995         * Configurations/WebCore.xcconfig: Added
996         JAVASCRIPTCORE_PRIVATE_HEADERS_DIR variable to simplify logic in
997         the "Generate Derived Sources" script.  Added
998         INSTALLHDRS_COPY_PHASE = YES and INSTALLHDRS_SCRIPT_PHASE = YES.
999
1000         * WebCore.xcodeproj/project.pbxproj:
1001         - Added shell code to prevent running "Check For Global
1002           Initializers", "Check For Exit Time Destructors" and "Check
1003           For Weak VTables" scripts during the installhdrs build phase.
1004         - Made "Generate Derived Sources" work for the installhdrs build
1005           phase.  Also simplified setting of CREATE_HASH_TABLE by using
1006           JAVASCRIPTCORE_PRIVATE_HEADERS_DIR.
1007
1008 2009-03-02  Adam Langley  <agl@google.com>
1009
1010         Reviewed by Darin Fisher.
1011
1012         Chromium Linux: Switch to using Skia to render widgets.
1013
1014         In order to sandbox the Chromium renderer on Linux we need to remove
1015         the X connection. GTK cannot render without an X connection so, for
1016         now, we render widgets ourselves.
1017
1018         Previously didn't use anti-alias fonts in order to match Windows font
1019         rendering exactly. This was helpful when bootstrapping our layout
1020         tests. Now, however, we are ready to enable it.
1021
1022         https://bugs.webkit.org/show_bug.cgi?id=24244
1023
1024         * platform/chromium/ScrollbarThemeChromium.cpp:
1025         (WebCore::ScrollbarThemeChromium::buttonSize):
1026         * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
1027         (WebCore::ScrollbarThemeChromium::scrollbarThickness):
1028         (WebCore::ScrollbarThemeChromium::paintTrackPiece):
1029         (WebCore::ScrollbarThemeChromium::paintButton):
1030         (WebCore::ScrollbarThemeChromium::paintThumb):
1031         * platform/graphics/chromium/FontPlatformDataLinux.cpp:
1032         (WebCore::FontPlatformData::setupPaint):
1033         * platform/graphics/skia/PlatformContextSkia.cpp:
1034         (PlatformContextSkia::PlatformContextSkia):
1035         (PlatformContextSkia::~PlatformContextSkia):
1036         * platform/graphics/skia/PlatformContextSkia.h:
1037         * rendering/RenderThemeChromiumGtk.cpp: Removed.
1038         * rendering/RenderThemeChromiumGtk.h: Removed.
1039         * rendering/RenderThemeChromiumLinux.cpp: Added.
1040         * rendering/RenderThemeChromiumLinux.h: Added.
1041
1042 2009-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
1043
1044         Reviewed by Darin Fisher.
1045
1046         https://bugs.webkit.org/show_bug.cgi?id=24261
1047         Fix return types.
1048
1049         Test: LayoutTests/dom/svg/level3/xpath/XPathEvaluator_evaluate_TYPE_ERR.svg
1050
1051         * bindings/v8/V8Binding.h:
1052         (WebCore::toInt32): change return type to int
1053         (WebCore::toFloat): change return type to float.
1054
1055 2009-03-03  Anders Carlsson  <andersca@apple.com>
1056
1057         Reviewed by John Sullivan.
1058
1059         https://bugs.webkit.org/show_bug.cgi?id=22884
1060         <rdar://problem/6449783>
1061         modified layout test crashes Safari
1062
1063         Null check NPStream before dereferencing it.
1064         
1065         * plugins/PluginView.cpp:
1066         (WebCore::PluginView::destroyStream):
1067
1068 2009-03-03  Eric Carlson  <eric.carlson@apple.com>
1069
1070         Reviewed by Simon Fraser.
1071
1072         Fix for <rdar://problem/6641045>
1073         Don't call QTKit to get movie properties until movie metadata has been loaded.
1074
1075         * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
1076         (WebCore::MediaPlayerPrivate::metaDataAvailable): defined
1077         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
1078         (WebCore::MediaPlayerPrivate::createQTTime): return default if !metaDataAvailable.
1079         (WebCore::MediaPlayerPrivate::play): Ditto.
1080         (WebCore::MediaPlayerPrivate::pause): Ditto.
1081         (WebCore::MediaPlayerPrivate::duration): Ditto.
1082         (WebCore::MediaPlayerPrivate::currentTime): Ditto.
1083         (WebCore::MediaPlayerPrivate::seek): Ditto.
1084         (WebCore::MediaPlayerPrivate::seekTimerFired): Ditto.
1085         (WebCore::MediaPlayerPrivate::paused): Ditto.
1086         (WebCore::MediaPlayerPrivate::seeking): Ditto.
1087         (WebCore::MediaPlayerPrivate::naturalSize): Ditto.
1088         (WebCore::MediaPlayerPrivate::hasVideo): Ditto.
1089         (WebCore::MediaPlayerPrivate::setVolume): Ditto.
1090         (WebCore::MediaPlayerPrivate::setRate): Ditto.
1091         (WebCore::MediaPlayerPrivate::dataRate): Ditto.
1092         (WebCore::MediaPlayerPrivate::maxTimeLoaded): Ditto.
1093         (WebCore::MediaPlayerPrivate::totalBytes): Ditto.
1094
1095 2009-03-03  Kevin McCullough  <kmccullough@apple.com>
1096
1097         - Spelling fix.
1098
1099         * page/Console.cpp:
1100         (WebCore::Console::profile):
1101
1102 2009-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
1103
1104         Reviewed by Darin Fisher.
1105
1106         https://bugs.webkit.org/show_bug.cgi?id=23657
1107         Remove Database API callback IDLs from the project. 
1108         They were removed in r40633.
1109
1110         * WebCore.xcodeproj/project.pbxproj: Removed IDL files from the project.
1111
1112 2009-03-03  Kevin McCullough  <kmccullough@apple.com>
1113
1114         Reviewed by Oliver Hunt.
1115
1116         <rdar://problem/6639110> console.profile() doesn't work without a title
1117
1118         * page/Console.cpp:
1119         (WebCore::Console::profile): If there is no title assume this is a user
1120         initiated profile and give it the next incremented title name.
1121
1122 2009-03-03  Timothy Hatcher  <timothy@apple.com>
1123
1124         Fix a regression that broke dirxml and caused an ASSERT in debug builds. Also simplified
1125         the console code and refactored things to have fewer code paths and duplication.
1126
1127         rdar://problem/6367127
1128         https://bugs.webkit.org/show_bug.cgi?id=24329
1129
1130         Reviewed by Kevin McCullough.
1131
1132         Test: manual-tests/inspector/console-dir.html
1133
1134         * bindings/js/JSInspectedObjectWrapper.cpp:
1135         (WebCore::JSInspectedObjectWrapper::wrap): Use the lexicalGlobalObject instead of dynamicGlobalObject
1136         to fix an ASSERT about using a wrapper from the wrong ExecState.
1137         * bindings/js/JSQuarantinedObjectWrapper.cpp:
1138         (WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper): Ditto.
1139         (WebCore::JSQuarantinedObjectWrapper::allowsUnwrappedAccessFrom): Ditto.
1140         * inspector/front-end/Console.js:
1141         (WebInspector.Console.prototype._format): Remove the inline argument and add forceObjectFormat.
1142         When forceObjectFormat is true, the only formatter used is _formatobject.
1143         (WebInspector.Console.prototype._formatvalue): Remove the inline argument.
1144         (WebInspector.Console.prototype._formatstring): Ditto.
1145         (WebInspector.Console.prototype._formatregexp): Ditto.
1146         (WebInspector.Console.prototype._formatarray): Ditto.
1147         (WebInspector.Console.prototype._formatnode): Remove the inline argument and make a DOM tree instead of an anchor.
1148         (WebInspector.Console.prototype._formatobject): Remove the inline argument and always make a property graph.
1149         (WebInspector.Console.prototype._formaterror): Remove the inline argument.
1150         (WebInspector.ConsoleMessage): Remove the case for MessageLevel.Node and
1151         simplify the case for MessageLevel.Object to use the normal _format code path with the %O formatter.
1152         (WebInspector.ConsoleMessage.prototype._format.formatForConsole): Don't pass an additional true argument for inline.
1153         (WebInspector.ConsoleMessage.prototype._format.formatAsObjectForConsole): Added. Pass a true argument for forceObjectFormat.
1154         (WebInspector.ConsoleMessage.prototype._format): Added support for the %O formatter. Use formatForConsole for all arguments.
1155         (WebInspector.ConsoleMessage.prototype.toString): Add the other message levels.
1156         * inspector/front-end/inspector.css: Tweak styles to look and work correctly.
1157         * inspector/front-end/utilities.js:
1158         (Object.type): Return "node" for Node objects.
1159         (Object.describe): Handle the "node" type.
1160         * page/Console.cpp:
1161         (WebCore::printMessageSourceAndLevelPrefix): Fix an assert by adding the other message level types.
1162         (WebCore::Console::dirxml): Use the standard log fuction since it prints a DOM tree for nodes by default.
1163         * page/Console.h:
1164         (WebCore::enum MessageLevel): Removed NodeMessageLevel. Added a FIXME.
1165
1166 2009-03-03  Scott Violet  <sky@google.com>
1167
1168         Reviewed by Eric Seidel.
1169
1170         https://bugs.webkit.org/show_bug.cgi?id=24325
1171         Crash on replacing document contents during drop.
1172
1173         Makes sure a node is in the document during a move before using it.
1174
1175         Test: fast/events/crash-on-mutate-during-drop.html
1176
1177         * editing/MoveSelectionCommand.cpp:
1178         (WebCore::MoveSelectionCommand::doApply):
1179
1180 2009-03-03  Jungshik Shin <jshin@chromium.org>
1181
1182         Reviewed by Eric Seidel.
1183
1184         https://bugs.webkit.org/show_bug.cgi?id=23028
1185         Enable dynamic web font support to Chromium on Windows.
1186         Files that were omitted by mistake in the latest patch
1187         that was landed.
1188
1189         * loader/CachedFont.cpp:
1190         (WebCore::CachedFont::~CachedFont):
1191         (WebCore::CachedFont::ensureCustomFontData):
1192         (WebCore::CachedFont::platformDataFromCustomData):
1193         (WebCore::CachedFont::allClientsRemoved):
1194         * platform/graphics/chromium/FontCustomPlatformData.cpp:
1195         (WebCore::EOTStream::EOTStream):
1196         (WebCore::createFontCustomPlatformData):
1197         * platform/graphics/win/FontCustomPlatformData.cpp:
1198         (WebCore::EOTStream::EOTStream):
1199         (WebCore::createFontCustomPlatformData):
1200
1201 2009-03-03  Gustavo Noronha Silva  <gns@gnome.org>
1202
1203         Reviewed by Alexey Proskuryakov.
1204
1205         https://bugs.webkit.org/show_bug.cgi?id=16826
1206         [Gtk] Implement WebKitDownload
1207
1208         Make the Soup backend able to handle requests without a frame,
1209         since we may have such things now that we support downloads.
1210
1211         * platform/network/ResourceHandleInternal.h:
1212         * platform/network/soup/ResourceHandleSoup.cpp:
1213         (WebCore::ResourceHandle::start):
1214
1215 2009-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
1216
1217         Reviewed by Eric Seidel.
1218
1219         https://bugs.webkit.org/show_bug.cgi?id=24331
1220         Add custom V8 bindings for Element, Attr, HTMLFrame, and HTMLIFrame.
1221
1222         * bindings/v8/custom/V8AttrCustom.cpp: Added.
1223         * bindings/v8/custom/V8CustomBinding.cpp: Added.
1224         * bindings/v8/custom/V8CustomBinding.h: Added attribute-checking helpers.
1225         * bindings/v8/custom/V8ElementCustom.cpp: Added.
1226         * bindings/v8/custom/V8HTMLFrameElementCustom.cpp: Added.
1227         * bindings/v8/custom/V8HTMLIFrameElementCustom.cpp: Added.
1228
1229 2009-03-03  Brady Eidson  <beidson@apple.com>
1230
1231         Reviewed by Darin Adler
1232
1233         <rdar://problem/6616664> - Quick looks of various file types is broken
1234
1235         In http://trac.webkit.org/changeset/40553 there was an attempt to prevent NSURLRequest churn
1236         for non-HTTP loads when the underlying ResourceRequest changed.  Unfortunately it was a little
1237         overzealous as the mainDocumentURL is relevant for all loads, not only HTTP/HTTPS loads.
1238
1239         Partially reverted behavior to always set the mainDocumentURL in situations when we would've
1240         before that patch.
1241
1242         * loader/FrameLoader.cpp:
1243         (WebCore::FrameLoader::addExtraFieldsToRequest):
1244
1245         * platform/network/ResourceRequestBase.cpp:
1246         (WebCore::ResourceRequestBase::setMainDocumentURL):
1247
1248 2009-03-03  Chris Marrin  <cmarrin@apple.com>
1249
1250         Reviewed by Simon Fraser.
1251
1252         https://bugs.webkit.org/show_bug.cgi?id=24256
1253
1254         Added a WebCoreForceSoftwareAnimation flag.
1255
1256         * platform/graphics/mac/GraphicsLayerCA.mm:
1257         (WebCore::forceSoftwareAnimation):
1258         (WebCore::GraphicsLayerCA::setOpacity):
1259         (WebCore::GraphicsLayerCA::animateTransform):
1260         (WebCore::GraphicsLayerCA::animateFloat):
1261
1262 2009-03-02  Chris Marrin  <cmarrin@apple.com>
1263
1264         Reviewed by Sam Weinig.
1265
1266         https://bugs.webkit.org/show_bug.cgi?id=24257
1267
1268         Added prototype properties for several classes with constructors that
1269         were missing them, including the one mentioned in the bug.
1270
1271         Test: fast/dom/Window/custom-constructors.html
1272
1273         * bindings/js/JSAudioConstructor.cpp:
1274         (WebCore::JSAudioConstructor::JSAudioConstructor):
1275         * bindings/js/JSDOMWindowBase.cpp:
1276         (jsDOMWindowBaseWebKitCSSMatrix):
1277         * bindings/js/JSImageConstructor.cpp:
1278         (WebCore::JSImageConstructor::JSImageConstructor):
1279         * bindings/js/JSOptionConstructor.cpp:
1280         (WebCore::JSOptionConstructor::JSOptionConstructor):
1281         * bindings/js/JSWebKitCSSMatrixConstructor.cpp:
1282         (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor):
1283         * bindings/js/JSWebKitCSSMatrixConstructor.h:
1284         * bindings/js/JSWebKitPointConstructor.cpp:
1285         (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
1286         * bindings/js/JSWorkerConstructor.cpp:
1287         (WebCore::JSWorkerConstructor::JSWorkerConstructor):
1288
1289 2009-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
1290
1291         Reviewed by Darin Fisher.
1292
1293         https://bugs.webkit.org/show_bug.cgi?id=24321
1294         Add V8 bindings headers.
1295
1296         * bindings/v8/V8Binding.h: Added.
1297         * bindings/v8/V8Proxy.h: Added.
1298         * bindings/v8/custom/V8CustomBinding.h: Added.
1299         * bindings/v8/custom/V8CustomEventListener.h: Added.
1300
1301 2009-03-03  Jungshik Shin <jshin@chromium.org>
1302
1303         Reviewed by Eric Seidel.
1304
1305         https://bugs.webkit.org/show_bug.cgi?id=23803
1306         Fix an 'off-by-1' error in ChromiumWin's font fallback.
1307
1308         * platform/graphics/chromium/FontCacheChromiumWin.cpp:
1309         (WebCore::FontCache::getFontDataForCharacters):
1310
1311 2009-03-03  Jungshik Shin  <jshin@chromium.org>
1312
1313         Reviewed by Eric Seidel.
1314
1315         http://bugs.webkit.org/show_bug.cgi?id=23028
1316         Enable dynamic web font support to Chromium on Windows: Part 1
1317         - Move OpenTypeUtilities.{cpp,h} to platform/graphics/opentype
1318           from platform/graphics/win because both Windows port and Chromium Windows
1319           port will use them.
1320         - Adjust WebCore.vcproj accordingly.
1321
1322         * WebCore.vcproj/WebCore.vcproj:
1323         * platform/graphics/opentype: Added.
1324         * platform/graphics/opentype/OpenTypeUtilities.cpp: Copied from WebCore/platform/graphics/win/OpenTypeUtilities.cpp.
1325         * platform/graphics/opentype/OpenTypeUtilities.h: Copied from WebCore/platform/graphics/win/OpenTypeUtilities.h.
1326         * platform/graphics/win/OpenTypeUtilities.cpp: Removed.
1327         * platform/graphics/win/OpenTypeUtilities.h: Removed.
1328
1329 2009-03-03  Simon Fraser  <simon.fraser@apple.com>
1330
1331         Reviewed by Dave Hyatt
1332
1333         https://bugs.webkit.org/show_bug.cgi?id=24312
1334         
1335         Take 3D transforms into account when hit testing:
1336         
1337         1. Maintain a bit on each RenderLayer that is set when the layer
1338            has 3d descendants, so that we know when to fall into the slow
1339            hit testing path.
1340            
1341         2. Make a ref-counted HitTestingTransformState, which is used to store
1342            an accumulated transform, and the hit test point, and hitTestRect
1343            in the plane of the ancestor non-3d ('flattening') layer.
1344            
1345            It's ref-counted so we can heap allocate it (to avoid stack bloat),
1346            and avoid copying when hitTestLayer calls itself after applying the transform.
1347            
1348         3. Add logic to hitTestLayer to depth-test just direct descendants, if any have
1349            3D transforms, or to do deep depth-testing when traversing a preserves-3d
1350            hierarchy. When hit, layers compute a z-offset from the ancestor flattening
1351            layer, which allows for correct depth testing.
1352            
1353            The existing early-return codepath is unaffected when there are no 3d transforms
1354            and no preserve-3d.
1355
1356         * rendering/RenderLayer.cpp:
1357         (WebCore::RenderLayer::RenderLayer):
1358         (WebCore::RenderLayer::updateTransform):
1359         (WebCore::RenderLayer::dirty3DTransformedDescendantStatus):
1360         (WebCore::RenderLayer::update3DTransformedDescendantStatus):
1361         (WebCore::RenderLayer::hitTest):
1362         (WebCore::computeZOffset):
1363         (WebCore::RenderLayer::createLocalTransformState):
1364         (WebCore::RenderLayer::hitTestLayer):
1365         (WebCore::RenderLayer::hitTestContents):
1366         * rendering/RenderLayer.h:
1367         (WebCore::RenderLayer::preserves3D):
1368         (WebCore::RenderLayer::has3DTransform):
1369         (WebCore::RenderLayer::setHas3DTransformedDescendant):
1370         (WebCore::RenderLayer::has3DTransformedDescendant):
1371         * rendering/RenderLayerBacking.cpp:
1372         * rendering/TransformState.cpp:
1373         (WebCore::TransformState::flatten):
1374         (WebCore::TransformState::mappedPoint):
1375         (WebCore::HitTestingTransformState::move):
1376         (WebCore::HitTestingTransformState::applyTransform):
1377         (WebCore::HitTestingTransformState::flatten):
1378         (WebCore::HitTestingTransformState::mappedPoint):
1379         (WebCore::HitTestingTransformState::mappedQuad):
1380         * rendering/TransformState.h:
1381         (WebCore::TransformState::TransformState):
1382         (WebCore::HitTestingTransformState::create):
1383         (WebCore::HitTestingTransformState::move):
1384         (WebCore::HitTestingTransformState::HitTestingTransformState):
1385
1386 2009-03-03  Brett Wilson  <brettw@chromium.org>
1387
1388         Fix uninitialized memory reads in the Chromium Windows transparency
1389         code that were identified by Purify,
1390
1391         Reviewed by Darin Fisher.
1392
1393         * platform/graphics/chromium/TransparencyWin.cpp:
1394         (WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers):
1395         (WebCore::TransparencyWin::initializeNewContext):
1396
1397 2009-03-03  Simon Fraser  <simon.fraser@apple.com>
1398
1399         Reviewed by Dave Hyatt
1400
1401         https://bugs.webkit.org/show_bug.cgi?id=24312
1402         
1403         Factor the code that compute a transform relative to the container
1404         into RenderObject::transformFromContainer().
1405         
1406         * rendering/RenderBox.cpp:
1407         (WebCore::RenderBox::mapLocalToAbsolutePoint):
1408         (WebCore::RenderBox::mapAbsoluteToLocalPoint):
1409         * rendering/RenderObject.cpp:
1410         (WebCore::RenderObject::transformFromContainer):
1411         * rendering/RenderObject.h:
1412
1413 2009-03-03  Simon Fraser  <simon.fraser@apple.com>
1414
1415         Reviewed by Dave Hyatt
1416
1417         https://bugs.webkit.org/show_bug.cgi?id=24317
1418         
1419         Always return |true| from RenderTextControlMultiLine::nodeAtPoint() if
1420         the superclass found a node, otherwise we set the innerNode of the
1421         HitTestResult, but don't actually report that we found a hit.
1422
1423         * rendering/RenderTextControlMultiLine.cpp:
1424         (WebCore::RenderTextControlMultiLine::nodeAtPoint):
1425
1426 2009-03-03  Onne Gorter  <onne.gorter@avinity.net>
1427
1428         Reviewed by Anders Carlsson.
1429
1430         https://bugs.webkit.org/show_bug.cgi?id=23707
1431         resizing plugins does not work, because the plugin never gets informed
1432
1433         Make gtk plugins resize correctly, by sending them the setwindow event
1434         correctly. Also ensure that all plugin eventing is done with correct
1435         locking/calling. Mostly copied from mac implementation.
1436
1437         manual test: manual-tests/gtk/plugin-resize-scroll.html
1438
1439         * plugins/PluginView.h:
1440         * plugins/gtk/PluginViewGtk.cpp:
1441         (WebCore::PluginView::dispatchNPEvent):
1442         ensure locking/calling for NPEvents
1443         (WebCore::PluginView::updatePluginWidget):
1444         if something changed, let setNPWindowIfNeeded handle it
1445         (WebCore::PluginView::paint):
1446         (WebCore::PluginView::handleKeyboardEvent):
1447         (WebCore::PluginView::handleMouseEvent):
1448         ensure calling conventions
1449         (WebCore::PluginView::setNPWindowRect):
1450         just pass control to setNPWindowIfNeeded
1451         (WebCore::PluginView::setNPWindowIfNeeded):
1452         event the plugin correctly of new window
1453         (WebCore::PluginView::init):
1454         init through the new setup
1455
1456 2009-03-03  Mike Belshe  <mike@belshe.com>
1457
1458         Reviewed by Darin Fisher.
1459
1460         https://bugs.webkit.org/show_bug.cgi?id=24311
1461         Make IDL returning DOMObject use [V8Custom]
1462
1463         * dom/Document.idl:
1464         * html/HTMLCanvasElement.idl:
1465
1466 2009-03-02  Simon Fraser  <simon.fraser@apple.com>
1467
1468         Reviewed by Adele Peterson
1469
1470         https://bugs.webkit.org/show_bug.cgi?id=24313
1471         
1472         If RenderTextControlSingleLine::nodeAtPoint() pokes a node into the
1473         HitTestResult, then it had better well return |true|. And m_innerBlock
1474         could never have been set as the hit node by the superclass, because
1475         the superclass knows nothing about m_innerBlock.
1476         
1477         Test: fast/forms/input-hit-test-border.html
1478
1479         * rendering/RenderTextControlSingleLine.cpp:
1480         (WebCore::RenderTextControlSingleLine::nodeAtPoint):
1481
1482 2009-03-02  Sam Weinig  <sam@webkit.org>
1483
1484         Reviewed by Mark Rowe.
1485
1486         Enable Geolocation (except on Tiger and Leopard).
1487
1488         * Configurations/WebCore.xcconfig:
1489
1490 2009-03-02  Ojan Vafai  <ojan@chromium.org>
1491
1492         Reviewed by Adele Peterson.
1493
1494         Fix https://bugs.webkit.org/show_bug.cgi?id=24307
1495         Null out m_highlightedNode on hideHighlight().
1496         Ran WebCore/manual-tests/inspector/highlight-nodes.html.
1497
1498         * inspector/InspectorController.cpp:
1499         (WebCore::InspectorController::hideHighlight):
1500
1501 2009-03-02  Sam Weinig  <sam@webkit.org>
1502
1503         Reviewed by Geoffrey Garen.
1504
1505         Fix for <rdar://problem/6507404> Add Geolocation support.
1506
1507         This is not yet turned on for any Mac platform.
1508
1509         * WebCore.xcodeproj/project.pbxproj:
1510         * page/Chrome.cpp:
1511         (WebCore::Chrome::shouldAllowGeolocationForFrame):
1512         * page/Chrome.h:
1513         * page/ChromeClient.h:
1514         (WebCore::ChromeClient::shouldAllowGeolocationForFrame):
1515         * page/Geolocation.cpp:
1516         (WebCore::Geolocation::Geolocation):
1517         (WebCore::Geolocation::disconnectFrame): Remove call to setUsingGeolocation as the document
1518         will not be alive at this point.
1519         (WebCore::Geolocation::getCurrentPosition): Check if the embedding app allows geolocation and
1520         return a PERMISSION_DENIED if not.
1521         (WebCore::Geolocation::watchPosition): Ditto.
1522         (WebCore::Geolocation::shouldAllowGeolocation): Perform request to embedding layer of whether
1523         to allow geolocation and cache the result. 
1524         * page/Geolocation.h:
1525         (WebCore::Geolocation::):
1526         * platform/GeolocationService.cpp:
1527         * platform/GeolocationService.h:
1528         (WebCore::GeolocationService::~GeolocationService):
1529         (WebCore::GeolocationService::stopUpdating):
1530         * platform/mac/GeolocationServiceMac.h: Added.
1531         (WebCore::GeolocationServiceMac::lastPosition):
1532         (WebCore::GeolocationServiceMac::lastError):
1533         * platform/mac/GeolocationServiceMac.mm: Added.
1534         (WebCore::GeolocationService::create):
1535         (WebCore::GeolocationServiceMac::GeolocationServiceMac):
1536         (WebCore::GeolocationServiceMac::~GeolocationServiceMac):
1537         (WebCore::GeolocationServiceMac::startUpdating):
1538         (WebCore::GeolocationServiceMac::stopUpdating):
1539         (WebCore::GeolocationServiceMac::suspend):
1540         (WebCore::GeolocationServiceMac::resume):
1541         (WebCore::GeolocationServiceMac::positionChanged):
1542         (WebCore::GeolocationServiceMac::errorOccurred):
1543         (-[WebCoreCoreLocationObserver initWithCallback:]):
1544         (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):
1545         (-[WebCoreCoreLocationObserver locationManager:didFailWithError:]):
1546
1547 2009-03-02  Kevin Ollivier  <kevino@theolliviers.com>
1548
1549         Build fixes for wxWidgets Mac trunk build.
1550
1551         * platform/wx/wxcode/mac/carbon/fontprops.cpp:
1552         (wxFontProperties::wxFontProperties):
1553         (GetTextExtent):
1554         * webcore-wx.bkl:
1555
1556 2009-03-02  Kevin Ollivier  <kevino@theolliviers.com>
1557
1558         wxGTK missing header build fix.
1559
1560         * platform/wx/wxcode/gtk/fontprops.cpp:
1561
1562 2009-03-02  Dan Bernstein  <mitz@apple.com>
1563
1564         Reviewed by Adam Roben.
1565
1566         - fix https://bugs.webkit.org/show_bug.cgi?id=21811
1567           REGRESSION: Windows Build Not Selecting Proper Font
1568
1569         * platform/graphics/win/FontCacheWin.cpp:
1570         (WebCore::createGDIFont): Added back code to verify that the created
1571         HFONT has the requested face name.
1572
1573 2009-03-02  Timothy Hatcher  <timothy@apple.com>
1574
1575         Fixes a regression caused by splitting the input and output of console commands.
1576
1577         https://bugs.webkit.org/show_bug.cgi?id=24293
1578
1579         Reviewed by Kevin McCullough.
1580
1581         * inspector/front-end/Console.js:
1582         (WebInspector.Console.prototype.addMessage): Don't treat ConsoleCommandResult as a
1583         normal ConsoleMessage when appending. This prevents resetting repeatCounts incorrectly.
1584
1585 2009-03-02  Timothy Hatcher  <timothy@apple.com>
1586
1587         Make exception messages and logged Error objects display consistently.
1588
1589         https://bugs.webkit.org/show_bug.cgi?id=18983
1590
1591         Reviewed by Adam Roben.
1592
1593         * English.lproj/localizedStrings.js: Remove a string for line numbers.
1594         * inspector/front-end/Console.js:
1595         (WebInspector.Console.prototype._enterKeyPressed): Pass the exception
1596         boolean to the ConsoleCommandResult constructor and don't pass level.
1597         (WebInspector.Console.prototype._formatnode): Fix a className typo.
1598         (WebInspector.Console.prototype._formaterror): Add an error-message
1599         classed span around the message to show in red and remove the
1600         console-message-url class from the link so it doesn't float right.
1601         Instead enclose the link in parentheses and use displayNameForURL
1602         to shorten the URL in the link.
1603         (WebInspector.ConsoleMessage.prototype.toMessageElement): Simplify
1604         how line numbers are shown since link underlining a string with
1605         parentheses looks bad.
1606         (WebInspector.ConsoleCommandResult): Take an exception boolean flag
1607         instead of a level and get line and URL based on that flag.
1608         * inspector/front-end/inspector.css: Tweaks to the styles.
1609
1610 2009-03-02  Ojan Vafai  <ojan@chromium.org>
1611
1612         Reviewed by Adele Peterson.
1613
1614         Bug 24048: extra windows button padding doesn't apply when there's no appearance
1615         <https://bugs.webkit.org/show_bug.cgi?id=24048>
1616
1617         Replace adjustButtonInnerStyle with buttonInternalPaddingLeft/Right/Top/Bottom.
1618
1619         No tests added as existing tests already cover this behavior.
1620
1621         * rendering/RenderButton.cpp:
1622         (WebCore::RenderButton::setupInnerStyle):
1623         * rendering/RenderTheme.cpp:
1624         * rendering/RenderTheme.h:
1625         (WebCore::RenderTheme::buttonInternalPaddingLeft):
1626         (WebCore::RenderTheme::buttonInternalPaddingRight):
1627         (WebCore::RenderTheme::buttonInternalPaddingTop):
1628         * rendering/RenderThemeChromiumGtk.cpp:
1629         (WebCore::RenderThemeWin::buttonInternalPaddingLeft):
1630         (WebCore::RenderThemeWin::buttonInternalPaddingRight):
1631         (WebCore::RenderThemeWin::buttonInternalPaddingTop):
1632         (WebCore::RenderThemeWin::buttonInternalPaddingBottom):
1633         * rendering/RenderThemeChromiumGtk.h:
1634         * rendering/RenderThemeChromiumWin.cpp:
1635         (WebCore::RenderThemeChromiumWin::buttonInternalPaddingLeft):
1636         (WebCore::RenderThemeChromiumWin::buttonInternalPaddingRight):
1637         (WebCore::RenderThemeChromiumWin::buttonInternalPaddingTop):
1638         (WebCore::RenderThemeChromiumWin::buttonInternalPaddingBottom):
1639         * rendering/RenderThemeChromiumWin.h:
1640         * rendering/RenderThemeWin.cpp:
1641         (WebCore::RenderThemeWin::buttonInternalPaddingLeft):
1642         (WebCore::RenderThemeWin::buttonInternalPaddingRight):
1643         (WebCore::RenderThemeWin::buttonInternalPaddingTop):
1644         (WebCore::RenderThemeWin::buttonInternalPaddingBottom):
1645         * rendering/RenderThemeWin.h:
1646
1647 2009-03-02  Adam Treat  <adam.treat@torchmobile.com>
1648
1649         Build fix for Qt port.  Remove unnecessary assert.
1650
1651         * platform/graphics/qt/ImageBufferQt.cpp:
1652         (WebCore::ImageBuffer::putImageData):
1653
1654 2009-03-02  Adam Treat  <adam.treat@torchmobile.com>
1655
1656         Reviewed by Adam Roben and previously by Eric Seidel and Simon Fraser.
1657
1658         https://bugs.webkit.org/show_bug.cgi?id=24227
1659         Ensure that the checkForSolidColor() optimization is correctly triggered
1660         for all cases of drawPattern.  Currently, the optimization was not triggered
1661         when the check had not been previously performed via a request for the
1662         image's NativeImagePtr.
1663
1664         Implement the Qt version of the checkForSolidColor() method.  Combined with
1665         the bug fix this reduces the time it takes to draw a repeating background
1666         of a 1x1 image from ~50msecs to ~0msecs on my machine.
1667
1668         * platform/graphics/BitmapImage.cpp:
1669         (WebCore::BitmapImage::BitmapImage):
1670         * platform/graphics/BitmapImage.h:
1671         (WebCore::BitmapImage::mayFillWithSolidColor):
1672         * platform/graphics/Image.h:
1673         (WebCore::Image::mayFillWithSolidColor):
1674         * platform/graphics/cairo/ImageCairo.cpp:
1675         (WebCore::BitmapImage::BitmapImage):
1676         (WebCore::BitmapImage::checkForSolidColor):
1677         * platform/graphics/cg/ImageCG.cpp:
1678         (WebCore::BitmapImage::BitmapImage):
1679         (WebCore::BitmapImage::checkForSolidColor):
1680         * platform/graphics/qt/ImageQt.cpp:
1681         (WebCore::BitmapImage::checkForSolidColor):
1682         * platform/graphics/skia/ImageSkia.cpp:
1683         (WebCore::BitmapImage::checkForSolidColor):
1684         * platform/graphics/wx/ImageWx.cpp:
1685         (WebCore::BitmapImage::checkForSolidColor):
1686
1687 2009-03-02  Gustavo Noronha Silva  <gns@gnome.org>
1688
1689         Unreviewed build fix; adding missing files to EXTRA_DIST, so that
1690         they show up in the tarball.
1691
1692         * GNUmakefile.am:
1693
1694 2009-03-02  Dirk Schulze  <krit@webkit.org>
1695
1696         Reviewed by Holger Freyther.
1697
1698         Added putImageData to Qt. Discussed with Ariya Hidayat.
1699
1700         [Qt] lacks putImageData support in Canvas
1701         https://bugs.webkit.org/show_bug.cgi?id=22186
1702
1703         * platform/graphics/qt/ImageBufferQt.cpp:
1704         (WebCore::ImageBuffer::putImageData):
1705
1706 2009-03-02  Timothy Hatcher  <timothy@apple.com>
1707
1708         Show exception messages again when evaluating bad expressions in the
1709         Web Inspector's console.
1710
1711         https://bugs.webkit.org/show_bug.cgi?id=19890
1712
1713         Reviewed by Oliver Hunt.
1714
1715         * bindings/js/JSQuarantinedObjectWrapper.cpp:
1716         (WebCore::JSQuarantinedObjectWrapper::transferExceptionToExecState):
1717         Fix the order in which the exception is set and cleared now that the
1718         exception is stored in the shared GlobalData, not per ExecState.
1719
1720 2009-02-28  Timothy Hatcher  <timothy@apple.com>
1721
1722         Make input in the Web Inspector console print before any output
1723         that might be added by the called function.
1724
1725         https://bugs.webkit.org/show_bug.cgi?id=19931
1726
1727         Reviewed by Oliver Hunt.
1728
1729         * inspector/front-end/Console.js:
1730         (WebInspector.Console.prototype._enterKeyPressed): Add the command
1731         message before evaluating the result. Associate the originating
1732         command to the result, so if they are adjacent there is no divider.
1733         (WebInspector.ConsoleCommand): No longer take a result.
1734         (WebInspector.ConsoleCommand.prototype.toMessageElement): Result
1735         code removed since it isn't used now.
1736         (WebInspector.ConsoleCommandResult): Subclass ConsoleMessage.
1737         (WebInspector.ConsoleCommandResult.prototype.toMessageElement):
1738         Call the ConsoleMessage toMessageElement and add a style class.
1739         * inspector/front-end/inspector.css: Add a new style class for
1740         adjacent results to hide the divider. Also tweak the position of
1741         the disclosure triangle for objects to not use the left margin.
1742
1743 2009-03-01  Chris Fleizach  <cfleizach@apple.com>
1744
1745         Reviewed by Oliver Hunt.
1746
1747         Bug 24282: AX Palindrome error when asking for a specific index of the AXChildren array
1748         <https://bugs.webkit.org/show_bug.cgi?id=24282>
1749
1750         When fetching an array of elements with a range, attachment views need to be returned
1751         instead of the actual attachment.
1752
1753         * page/mac/AccessibilityObjectWrapper.mm:
1754         (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
1755         (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
1756
1757 2009-03-01  Ojan Vafai  <ojan@chromium.org>
1758
1759         Reviewed by Eric Seidel.
1760
1761         Bug 24251: Cleanup: replace positionForCoordinates with positionForPoint
1762         <https://bugs.webkit.org/show_bug.cgi?id=24251>
1763         
1764         Make RenderObject::positionForCoordinate non-virtual and
1765         RenderObject::positionForPoint virtual in preparation for
1766         removing positionFor* from RenderObject/RenderText.
1767
1768         * page/Frame.cpp:
1769         (WebCore::Frame::visiblePositionForPoint):
1770         * rendering/RenderBR.cpp:
1771         (WebCore::RenderBR::positionForPoint):
1772         * rendering/RenderBR.h:
1773         * rendering/RenderBlock.cpp:
1774         (WebCore::RenderBlock::positionForPoint):
1775         * rendering/RenderBlock.h:
1776         * rendering/RenderBox.cpp:
1777         (WebCore::RenderBox::positionForPoint):
1778         * rendering/RenderBox.h:
1779         * rendering/RenderInline.cpp:
1780         (WebCore::RenderInline::positionForPoint):
1781         * rendering/RenderInline.h:
1782         * rendering/RenderObject.cpp:
1783         (WebCore::RenderObject::positionForCoordinates):
1784         (WebCore::RenderObject::positionForPoint):
1785         * rendering/RenderObject.h:
1786         * rendering/RenderReplaced.cpp:
1787         (WebCore::RenderReplaced::positionForPoint):
1788         * rendering/RenderReplaced.h:
1789         * rendering/RenderSVGInlineText.cpp:
1790         (WebCore::RenderSVGInlineText::positionForPoint):
1791         * rendering/RenderSVGInlineText.h:
1792         * rendering/RenderText.cpp:
1793         (WebCore::RenderText::positionForPoint):
1794         * rendering/RenderText.h:
1795
1796 2009-03-01  Larry Ewing  <lewing@novell.com>
1797
1798         Reviewed by Alexey Proskuryakov.
1799
1800         https://bugs.webkit.org/show_bug.cgi?id=24080
1801         NPN_GetValue casting to the wrong type and writing outside bounds
1802
1803         Make sure to cast the value to the correct type so that only
1804         memory owned by the value is written to.
1805
1806         * plugins/gtk/PluginViewGtk.cpp (PluginView::getValueStatic): 
1807         * plugins/qt/PluginViewQt.cpp (PluginView::getValueStatic):
1808         * plugins/mac/PluginViewMac.cpp (PluginView::getValueStatic): 
1809         (PluginView::getValue):
1810
1811 2009-03-01  Jeremy Moskovich  <jeremy@chromium.org>
1812
1813         Reviewed by Simon Fraser.
1814
1815         https://bugs.webkit.org/show_bug.cgi?id=24197 and
1816         https://bugs.webkit.org/show_bug.cgi?id=23512
1817
1818         The Windows version of cgColor() is conditionally compiled using
1819         !PLATFORM(MAC) change this to PLATFORM(WIN_OS) so that Chrome
1820         can use the OS X version instead of the Windows version.
1821
1822         Also rename cgColor() -> createCGColor()
1823
1824         No observable change in behavior, so no test.
1825
1826         * platform/graphics/Color.h:
1827         * platform/graphics/cg/ColorCG.cpp:
1828         (WebCore::createCGColor):
1829         * platform/graphics/cg/GraphicsContextCG.cpp:
1830         (WebCore::GraphicsContext::setPlatformShadow):
1831         * platform/graphics/mac/ColorMac.mm:
1832         (WebCore::createCGColor):
1833         * platform/graphics/mac/GraphicsContextMac.mm:
1834         (WebCore::GraphicsContext::drawFocusRing):
1835         * platform/graphics/mac/GraphicsLayerCA.mm:
1836         (WebCore::setLayerBorderColor):
1837         (WebCore::setLayerBackgroundColor):
1838         (WebCore::GraphicsLayerCA::setBackgroundColor):
1839         * platform/graphics/win/GraphicsContextCGWin.cpp:
1840         (WebCore::GraphicsContext::drawFocusRing):
1841         * svg/graphics/filters/cg/SVGFEHelpersCg.mm:
1842         (WebCore::ciColor):
1843
1844 2009-03-01  David Levin  <levin@chromium.org>
1845
1846         Reviewed by Alexey Proskuryakov.
1847
1848         Bug 24271: XMLHttpRequest needs js bindings for Workers.
1849         <https://bugs.webkit.org/show_bug.cgi?id=24271>
1850
1851         Tests: http/tests/xmlhttprequest/workers/methods-async.html
1852                http/tests/xmlhttprequest/workers/methods.html
1853
1854         * bindings/js/JSWorkerContextBase.cpp:
1855         (WebCore::JSWorkerContextBase::getOwnPropertySlot):
1856         (jsWorkerContextBaseXMLHttpRequest):
1857         (setJSWorkerContextBaseXMLHttpRequest):
1858         Expose XMLHttpRequest to Workers.
1859
1860         * bindings/js/JSWorkerContextBase.h:
1861
1862         * bindings/js/JSXMLHttpRequestConstructor.cpp:
1863         (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
1864         (WebCore::constructXMLHttpRequest):
1865         (WebCore::JSXMLHttpRequestConstructor::mark):
1866         Removed the dependencies on Document.
1867
1868         * bindings/js/JSXMLHttpRequestConstructor.h:
1869         (WebCore::JSXMLHttpRequestConstructor::scriptExecutionContext):
1870         * dom/EventException.idl:
1871         * dom/EventListener.idl:
1872         Change to have the NoStaticTables attribute since they are used from XHR.
1873
1874         * loader/WorkerThreadableLoader.cpp:
1875         (WebCore::workerContextDidFinishLoading):
1876         (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
1877         Fixed identifier to be unsigned long.
1878
1879         * loader/WorkerThreadableLoader.h:
1880         * workers/WorkerThread.cpp:
1881         (WebCore::WorkerThread::workerThread):
1882         Stop active objects when the thread is getting shutdown so that xhr gets properly shutdown.
1883
1884         * xml/XMLHttpRequestUpload.cpp:
1885
1886         * xml/XMLHttpRequest.idl:
1887         * xml/XMLHttpRequestException.idl:
1888         * xml/XMLHttpRequestProgressEvent.idl:
1889         * xml/XMLHttpRequestUpload.idl:
1890         Change to have the NoStaticTables attribute since they are used from XHR.
1891
1892 2009-03-01  Horia Olaru  <olaru@adobe.com>
1893
1894         Adding manual debugger test cases for bug.
1895
1896         https://bugs.webkit.org/show_bug.cgi?id=21073
1897
1898         Reviewed by Kevin McCullough.
1899
1900         * manual-tests/inspector/debugger-step-on-do-while-statements.html: Added.
1901         * manual-tests/inspector/debugger-step-on-for-in-statements.html: Added.
1902         * manual-tests/inspector/debugger-step-on-for-statements.html: Added.
1903         * manual-tests/inspector/debugger-step-on-while-statements.html: Added.
1904         * manual-tests/inspector/resources/loop-statements.js: Added.
1905
1906 2009-03-01  Dan Bernstein  <mitz@apple.com>
1907
1908         Reviewed by Darin Adler.
1909
1910         - fix <rdar://problem/6634768> Reproducible crash in RenderLayer::updateScrollCornerStyle() using full-page zoom at MobileMe Contacts
1911
1912         Test: fast/events/scroll-during-zoom-change.html
1913
1914         * dom/Document.cpp:
1915         (WebCore::Document::recalcStyle): Pause scheduled events during style
1916         reclaculation. Changes to the zoom property result in scroll events
1917         being generated during style recalc, and those events need to be
1918         deferred until the render tree is consistent.
1919         * page/FrameView.cpp:
1920         (WebCore::FrameView::layout): Changed to account for a case in which the
1921         post-layout tasks trigger a nested layout, which reactivates the
1922         post-layout task timer.
1923
1924 2009-03-01  Ross Boucher  <rboucher@gmail.com>
1925
1926         Alphabetically sort scripts in the Script's panel file popup menu.
1927
1928         https://bugs.webkit.org/show_bug.cgi?id=23395
1929
1930         Reviewed by Timothy Hatcher.
1931
1932         * inspector/front-end/ScriptsPanel.js:
1933         (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
1934         * inspector/front-end/utilities.js:
1935         (insertionIndexForObjectInListSortedByFunction):
1936         (indexOfObjectInListSortedByFunction):
1937
1938 2009-03-01  Yael Aharon  <yael.aharon@nokia.com>
1939
1940         Pass securityOrigin->host() instead of securityOrigin->domain() to WebInspector
1941         when creating databases, localStorage or sessionStorage. Changing document.domain
1942         should have no affect on databases, localStorage and sessionStorage in Web Inspector.
1943
1944         https://bugs.webkit.org/show_bug.cgi?id=23844
1945
1946         Reviewed by Timothy Hatcher.
1947
1948         * inspector/InspectorController.cpp:
1949         (WebCore::InspectorController::addDOMStorageScriptResource):
1950         (WebCore::InspectorController::didUseDOMStorage):
1951         * storage/Database.cpp:
1952         (WebCore::Database::openDatabase):
1953
1954 2009-03-01  Gustavo Noronha Silva  <gns@gnome.org>
1955
1956         Reviewed by Holger Freyther.
1957
1958         Avoid leaking errors when reporting GIO errors.
1959
1960         * platform/network/soup/ResourceHandleSoup.cpp:
1961         (WebCore::readCallback):
1962         (WebCore::openCallback):
1963         (WebCore::queryInfoCallback):
1964
1965 2009-03-01  Gustavo Noronha Silva  <gns@gnome.org>
1966
1967         Reviewed by Holger Freyther.
1968
1969         Fixes crash when the GIO backend is given the URI for a directory.
1970
1971         * platform/network/soup/ResourceHandleSoup.cpp:
1972         (WebCore::networkErrorForFile):
1973
1974 2009-02-28  Dimitri Glazkov  <dglazkov@chromium.org>
1975
1976         Reviewed by Darin Fisher.
1977
1978         https://bugs.webkit.org/show_bug.cgi?id=24261
1979         Fix V8 custom binding scrubbing error.
1980
1981         Test: fast/dom/TreeWalker/TreeWalker-currentNode.html
1982         Test: traversal/exception-forwarding.html
1983         TesT: traversal/stay-within-root.html
1984
1985         * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
1986         * bindings/v8/custom/V8NodeIteratorCustom.cpp:
1987         (WebCore::toV8): Replace v8::Undefined() return value with v8::Null().
1988         * bindings/v8/custom/V8TreeWalkerCustom.cpp:
1989         (WebCore::toV8): Ditto.
1990
1991 2009-02-28  Dimitri Glazkov  <dglazkov@chromium.org>
1992
1993         Reviewed by Darin Fisher.
1994
1995         https://bugs.webkit.org/show_bug.cgi?id=24261
1996         Fix V8 custom binding scrubbing error.
1997
1998         Test: fast/dom/CSSStyleDeclaration/css-properties-case-sensitive.html
1999
2000         * WebCore.xcodeproj/project.pbxproj:
2001         * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
2002         (WebCore::cssPropertyName):  Remove dubious checks, left over from
2003             incomplete conversion of parameter from pointer to pass-by-ref.
2004         (WebCore::NAMED_PROPERTY_GETTER): Initialize parameter.
2005         (WebCore::NAMED_PROPERTY_SETTER): Ditto.
2006
2007 2009-02-28  Xan Lopez  <xan@gnome.org>
2008
2009         Reviewed by Holger Freyther.
2010
2011         https://bugs.webkit.org/show_bug.cgi?id=24263
2012         [GTK] ref ResourceHandle until we are finished with it
2013
2014         Add a ref to the ResourceHandle in startHttp so we can keep it
2015         alive untill all callbacks have been executed, and unref it when
2016         soup tells us it's done with the SoupMessage (in
2017         finishedCallback). Fixes a number of crashes when calling
2018         didReceiveData whould crash because of the handle dying.
2019
2020         * platform/network/soup/ResourceHandleSoup.cpp:
2021         (WebCore::finishedCallback):
2022         (WebCore::ResourceHandle::startHttp):
2023
2024 2009-02-28  Adam Bergkvist <adam.bergkvist@ericsson.com>
2025
2026         Reviewed by Alexey Proskuryakov.
2027
2028         https://bugs.webkit.org/show_bug.cgi?id=24226
2029         [SOUP] HTTP status text is never set
2030
2031         Set HTTP status text to SoupMessage reason_phrase.
2032
2033         * platform/network/soup/ResourceHandleSoup.cpp:
2034         (WebCore::fillResponseFromMessage):
2035
2036 2009-02-28  Dan Bernstein  <mitz@apple.com>
2037
2038         - fix malformed project file
2039
2040         * WebCore.xcodeproj/project.pbxproj:
2041
2042 2009-02-28  Dan Bernstein  <mitz@apple.com>
2043
2044         Reviewed by Oliver Hunt.
2045
2046         - fix https://bugs.webkit.org/show_bug.cgi?id=23848
2047           <rdar://problem/6573250> REGRESSION: Crash when mouse cursor moves over a link on www.opportuno.de
2048
2049         Test: fast/layers/inline-dirty-z-order-lists.html
2050
2051         * rendering/RenderBox.cpp:
2052         (WebCore::RenderBox::styleWillChange): Moved the code that dirties a
2053         layer's and its stacking context's z-order lists when the layer's
2054         z-index or visibility change from here...
2055         * rendering/RenderBoxModelObject.cpp:
2056         (WebCore::RenderBoxModelObject::styleWillChange): ...to here, so that
2057         it will apply to RenderInline too.
2058
2059 2009-02-27  Alexey Proskuryakov  <ap@webkit.org>
2060
2061         Reviewed by David Hyatt.
2062
2063         Don't include TextResourceDecoder.h in Document.h
2064
2065         This undoes inlining of Document::displayStringModifiedByEncoding() to avoid world rebuilds
2066         when TextResourceDecoder.h is modified. Performance impact is expected to be negligible.
2067
2068         * dom/Document.cpp:
2069         (WebCore::Document::displayStringModifiedByEncoding):
2070         (WebCore::Document::displayBufferModifiedByEncoding):
2071         * dom/Document.h:
2072         * WebCore.base.exp:
2073
2074 2009-02-27  Matt Pennig  <pennig@apple.com>
2075
2076         Reviewed by David Hyatt.
2077
2078         Resolves: https://bugs.webkit.org/show_bug.cgi?id=24107
2079         "Fixed elements have 0 as an offsetLeft property"
2080         
2081         Code also brings offsetLeft/Top in full conformance with the spec.
2082         Added two tests, one for fixed-position elements, and one for <html>.
2083         
2084         Tests: fast/dom/Element/fixed-position-offset-parent.html
2085                fast/dom/Element/offsetLeft-offsetTop-html.html
2086
2087         * rendering/RenderBoxModelObject.cpp:
2088         (WebCore::RenderBoxModelObject::offsetLeft):
2089         (WebCore::RenderBoxModelObject::offsetTop):
2090
2091 2009-02-27  Dean Jackson  <dino@apple.com>
2092
2093         Reviewed by Simon Fraser.
2094
2095         renderer()->hasTransform() returns true for elements
2096         with perspective, but no transform, so test for transform
2097         when hit testing. This fixes ASSERT from
2098         https://bugs.webkit.org/show_bug.cgi?id=24252
2099
2100         Test: transforms/no_transform_hit_testing.html
2101
2102         * rendering/RenderLayer.cpp:
2103         (WebCore::RenderLayer::hitTestLayer):
2104
2105 2009-02-27  Dimitri Glazkov  <dglazkov@chromium.org>
2106
2107         Reviewed by Darin Fisher.
2108
2109         Fix scrubbing error -- a reversed condition.
2110
2111         * bindings/v8/ScriptValue.h:
2112         (WebCore::ScriptValue::clear): Change early exit for empty value, not the opposite.
2113
2114 2009-02-27  Jian Li  <jianli@chromium.org>
2115
2116         Reviewed by Alexey Proskuryakov.
2117
2118         Add confirmMessageFromWorkerObject to WorkerObjectProxy.
2119         https://bugs.webkit.org/show_bug.cgi?id=24152
2120
2121         * workers/WorkerMessagingProxy.cpp:
2122         (WebCore::MessageWorkerContextTask::performTask):
2123         (WebCore::WorkerMessagingProxy::confirmMessageFromWorkerObject):
2124         * workers/WorkerMessagingProxy.h:
2125         * workers/WorkerObjectProxy.h:
2126
2127 2009-02-27  Anders Carlsson  <andersca@apple.com>
2128
2129         Reviewed by David Hyatt.
2130
2131         Revert r41295, the fix for https://bugs.webkit.org/show_bug.cgi?id=24227 
2132         because it leads to assertion failures in the Mac port.
2133         
2134         * platform/graphics/BitmapImage.cpp:
2135         (WebCore::BitmapImage::BitmapImage):
2136         * platform/graphics/BitmapImage.h:
2137         (WebCore::BitmapImage::mayFillWithSolidColor):
2138         * platform/graphics/Image.h:
2139         (WebCore::Image::mayFillWithSolidColor):
2140         * platform/graphics/cairo/ImageCairo.cpp:
2141         (WebCore::BitmapImage::BitmapImage):
2142         * platform/graphics/cg/ImageCG.cpp:
2143         (WebCore::BitmapImage::BitmapImage):
2144         (WebCore::BitmapImage::checkForSolidColor):
2145         * platform/graphics/qt/ImageQt.cpp:
2146         (WebCore::BitmapImage::checkForSolidColor):
2147         * platform/graphics/skia/ImageSkia.cpp:
2148         (WebCore::BitmapImage::checkForSolidColor):
2149         * platform/graphics/wx/ImageWx.cpp:
2150         (WebCore::BitmapImage::checkForSolidColor):
2151
2152 2009-02-27  Adam Barth  <abarth@webkit.org>
2153
2154         Reviewed by Eric Seidel.
2155
2156         https://bugs.webkit.org/show_bug.cgi?id=20249
2157
2158         Add a preference to allow universal access from local URLs to mitigate
2159         some attacks.  Some clients still want to allow this access, so we
2160         expose this as a preference.
2161
2162         * WebCore.base.exp:
2163         * dom/Document.cpp:
2164         (WebCore::Document::initSecurityContext):
2165         * page/SecurityOrigin.cpp:
2166         (WebCore::SecurityOrigin::SecurityOrigin):
2167         * page/Settings.cpp:
2168         (WebCore::Settings::Settings):
2169         (WebCore::Settings::setAllowUniversalAccessFromFileUrls):
2170         * page/Settings.h:
2171         (WebCore::Settings::allowUniversalAccessFromFileUrls):
2172
2173 2009-02-27  Adam Treat  <adam.treat@torchmobile.com>
2174
2175         Reviewed by Eric Seidel.
2176
2177         https://bugs.webkit.org/show_bug.cgi?id=24229
2178         If an image has no alpha channel there is no reason to use SourceOver.
2179
2180         * platform/graphics/qt/ImageQt.cpp:
2181         (WebCore::Image::drawPattern):
2182         (WebCore::BitmapImage::draw):
2183
2184 2009-02-27  Adam Treat  <adam.treat@torchmobile.com>
2185
2186         Reviewed by Eric Seidel and Simon Fraser.
2187
2188         https://bugs.webkit.org/show_bug.cgi?id=24227
2189         Ensure that the checkForSolidColor() optimization is correctly triggered
2190         for all cases of drawPattern.  Currently, the optimization was not triggered
2191         when the check had not been previously performed via a request for the
2192         image's NativeImagePtr.
2193
2194         Implement the Qt version of the checkForSolidColor() method.  Combined with
2195         the bug fix this reduces the time it takes to draw a repeating background
2196         of a 1x1 image from ~50msecs to ~0msecs on my machine.
2197
2198         * platform/graphics/BitmapImage.cpp:
2199         (WebCore::BitmapImage::BitmapImage):
2200         * platform/graphics/BitmapImage.h:
2201         (WebCore::BitmapImage::mayFillWithSolidColor):
2202         * platform/graphics/Image.h:
2203         (WebCore::Image::mayFillWithSolidColor):
2204         * platform/graphics/cairo/ImageCairo.cpp:
2205         (WebCore::BitmapImage::BitmapImage):
2206         * platform/graphics/cg/ImageCG.cpp:
2207         (WebCore::BitmapImage::BitmapImage):
2208         (WebCore::BitmapImage::checkForSolidColor):
2209         * platform/graphics/qt/ImageQt.cpp:
2210         (WebCore::BitmapImage::checkForSolidColor):
2211         * platform/graphics/skia/ImageSkia.cpp:
2212         (WebCore::BitmapImage::checkForSolidColor):
2213         * platform/graphics/wx/ImageWx.cpp:
2214         (WebCore::BitmapImage::checkForSolidColor):
2215
2216 2009-02-27  Dirk Schulze  <krit@webkit.org>
2217
2218         Reviewed by Zack Rusin.
2219
2220         Added support for gradients and pattern on Fonts for Qt.
2221
2222         [Qt] gradients and patterns for FontQt
2223         https://bugs.webkit.org/show_bug.cgi?id=24243
2224
2225         * platform/graphics/qt/FontQt.cpp:
2226         (WebCore::Font::drawComplexText):
2227
2228 2009-02-27  Jian Li  <jianli@chromium.org>
2229
2230         Reviewed by Alexey Proskuryakov.
2231
2232         WorkerContextProxy::create in WorkerMessagingProxy.cpp should only be provided for non-Chromium platform.
2233         https://bugs.webkit.org/show_bug.cgi?id=24113
2234
2235         * workers/WorkerMessagingProxy.cpp:
2236
2237 2009-02-27  Yael Aharon  <yael.aharon@nokia.com>
2238
2239         Added a refresh button to storage views.
2240
2241         https://bugs.webkit.org/show_bug.cgi?id=24040
2242
2243         Reviewed by Timothy Hatcher.
2244
2245         * inspector/front-end/DOMStorageItemsView.js:
2246         (WebInspector.DOMStorageItemsView):
2247         (WebInspector.DOMStorageItemsView.prototype.get statusBarItems):
2248         (WebInspector.DOMStorageItemsView.prototype.update):
2249         (WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
2250         * inspector/front-end/DatabaseTableView.js:
2251         (WebInspector.DatabaseTableView):
2252         (WebInspector.DatabaseTableView.prototype.get statusBarItems):
2253         (WebInspector.DatabaseTableView.prototype._refreshButtonClicked):
2254         * inspector/front-end/DatabasesPanel.js:
2255         (WebInspector.DatabasesPanel):
2256         (WebInspector.DatabasesPanel.prototype.get statusBarItems):
2257         (WebInspector.DatabasesPanel.prototype.reset):
2258         (WebInspector.DatabasesPanel.prototype.showDatabase):
2259         (WebInspector.DatabasesPanel.prototype.showDOMStorage):
2260         (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
2261         * inspector/front-end/inspector.css:
2262
2263 2009-02-27  Yael Aharon  <yael.aharon@nokia.com>
2264
2265         Added support for editing/deleting localStorage and sessionStorage items
2266         directly from Web Inspector.
2267
2268         https://bugs.webkit.org/show_bug.cgi?id=23866.
2269
2270         Reviewed by Timothy Hatcher.
2271
2272         * WebCore.vcproj/WebCore.vcproj:
2273         * inspector/front-end/DOMStorageDataGrid.js: Added.
2274         (WebInspector.DOMStorageDataGrid):
2275         (WebInspector.DOMStorageDataGrid.prototype._ondblclick):
2276         (WebInspector.DOMStorageDataGrid.prototype._startEditing):
2277         (WebInspector.DOMStorageDataGrid.prototype._editingCommitted):
2278         (WebInspector.DOMStorageDataGrid.prototype._editingCancelled):
2279         (WebInspector.DOMStorageDataGrid.prototype.deleteSelectedRow):
2280         * inspector/front-end/DOMStorageItemsView.js:
2281         (WebInspector.DOMStorageItemsView):
2282         (WebInspector.DOMStorageItemsView.prototype.get statusBarItems):
2283         (WebInspector.DOMStorageItemsView.prototype.hide):
2284         (WebInspector.DOMStorageItemsView.prototype.update):
2285         (WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked):
2286         * inspector/front-end/DatabasesPanel.js:
2287         (WebInspector.DatabasesPanel):
2288         (WebInspector.DatabasesPanel.prototype.get statusBarItems):
2289         (WebInspector.DatabasesPanel.prototype.reset):
2290         (WebInspector.DatabasesPanel.prototype.showDOMStorage):
2291         (WebInspector.DatabasesPanel.prototype.dataGridForDOMStorage):
2292         (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
2293         * inspector/front-end/WebKit.qrc:
2294         * inspector/front-end/inspector.css:
2295         * inspector/front-end/inspector.html:
2296
2297 2009-02-26  Brett Wilson  <brettw@chromium.org>
2298
2299         Fix Windows transparency for the Chromium port. Implement a helper
2300         class for handling transparency on Windows. It allows semitransparent
2301         ClearType and semitransparent form controls by making new layers in the
2302         background.
2303
2304         It also replaces the "ThemeHelper" which allows better
2305         scaling and transforms on Windows form controls. In addition to the
2306         functionality that the ThemeHelper did, but additionally handles the
2307         antialiasing properly so that the form controls aren't composited on a
2308         white square.
2309
2310         https://bugs.webkit.org/show_bug.cgi?id=24101
2311
2312         Reviewed by Eric Seidel.
2313
2314         * platform/graphics/chromium/FontChromiumWin.cpp:
2315         (WebCore::):
2316         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
2317         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
2318         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
2319         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::drawGlyphs):
2320         (WebCore::Font::drawGlyphs):
2321         * platform/graphics/chromium/ThemeHelperChromiumWin.cpp:
2322         * platform/graphics/chromium/ThemeHelperChromiumWin.h:
2323         * platform/graphics/chromium/TransparencyWin.cpp: Added.
2324         (WebCore::):
2325         (WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers):
2326         (WebCore::TransparencyWin::OwnedBuffers::destBitmap):
2327         (WebCore::TransparencyWin::OwnedBuffers::referenceBitmap):
2328         (WebCore::TransparencyWin::OwnedBuffers::canHandleSize):
2329         (WebCore::TransparencyWin::TransparencyWin):
2330         (WebCore::TransparencyWin::~TransparencyWin):
2331         (WebCore::TransparencyWin::init):
2332         (WebCore::TransparencyWin::computeLayerSize):
2333         (WebCore::TransparencyWin::setupLayer):
2334         (WebCore::TransparencyWin::setupLayerForNoLayer):
2335         (WebCore::TransparencyWin::setupLayerForOpaqueCompositeLayer):
2336         (WebCore::TransparencyWin::setupLayerForTextComposite):
2337         (WebCore::TransparencyWin::setupLayerForWhiteLayer):
2338         (WebCore::TransparencyWin::setupTransform):
2339         (WebCore::TransparencyWin::setupTransformForKeepTransform):
2340         (WebCore::TransparencyWin::setupTransformForUntransform):
2341         (WebCore::TransparencyWin::setupTransformForScaleTransform):
2342         (WebCore::TransparencyWin::setTextCompositeColor):
2343         (WebCore::TransparencyWin::initializeNewContext):
2344         (WebCore::TransparencyWin::compositeOpaqueComposite):
2345         (WebCore::TransparencyWin::compositeTextComposite):
2346         (WebCore::TransparencyWin::makeLayerOpaque):
2347         * platform/graphics/chromium/TransparencyWin.h: Added.
2348         (WebCore::TransparencyWin::):
2349         (WebCore::TransparencyWin::context):
2350         (WebCore::TransparencyWin::platformContext):
2351         (WebCore::TransparencyWin::drawRect):
2352         * platform/graphics/skia/GraphicsContextSkia.cpp:
2353         (WebCore::GraphicsContext::endTransparencyLayer):
2354         * platform/graphics/skia/ImageSkia.cpp:
2355         (WebCore::paintSkBitmap):
2356         * rendering/RenderThemeChromiumWin.cpp:
2357         (WebCore::):
2358         (WebCore::RenderThemeChromiumWin::paintButton):
2359         (WebCore::RenderThemeChromiumWin::paintMenuList):
2360         (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
2361
2362 2009-02-27  Dimitri Glazkov  <dglazkov@chromium.org>
2363
2364         Reviewed by Eric Seidel.
2365
2366         https://bugs.webkit.org/show_bug.cgi?id=24211
2367         Add ScheduledAction for V8.
2368
2369         * bindings/v8/ScheduledAction.cpp: Added.
2370         (WebCore::ScheduledAction::ScheduledAction):
2371         (WebCore::ScheduledAction::~ScheduledAction):
2372         (WebCore::ScheduledAction::execute):
2373         * bindings/v8/ScheduledAction.h: Added.
2374         (WebCore::ScheduledAction::ScheduledAction):
2375
2376 2009-02-27  Zack Rusin  <zack@kde.org>
2377
2378         Reviewed by Nikolas Zimmermann.
2379
2380         Qt: be more reasonable about scrolled lines
2381
2382         cMouseWheelPixelsPerLineStep is currently a constant set to 13.3. it doesn't
2383         match our metrics meaning that Qt scrolls by ~2 lines by default which is quite
2384         irritating. so lets scroll vertically by the Qt set number of lines * Qt default
2385         single step scroll
2386
2387         * platform/qt/WheelEventQt.cpp:
2388
2389 2009-02-27  Xan Lopez  <xan@gnome.org>
2390
2391         Rubber-stamped by Alexey Proskuryakov.
2392
2393         https://bugs.webkit.org/show_bug.cgi?id=24222
2394         [GTK] Remove checks for old glib versions
2395
2396         libsoup, which is a hard dependency, needs at least glib 2.15.3,
2397         so remove all glib checks for versions older than that.
2398
2399         * platform/gtk/ContextMenuGtk.cpp:
2400         (WebCore::ContextMenu::ContextMenu):
2401         * platform/gtk/ContextMenuItemGtk.cpp:
2402         (WebCore::ContextMenuItem::setSubMenu):
2403         * platform/gtk/PopupMenuGtk.cpp:
2404         (WebCore::PopupMenu::show):
2405         * platform/gtk/WidgetGtk.cpp:
2406         (WebCore::Widget::retainPlatformWidget):
2407         * platform/network/soup/ResourceHandleSoup.cpp:
2408
2409 2009-02-26  Dirk Schulze  <krit@webkit.org>
2410
2411         Reviewed by Oliver Hunt.
2412
2413         Added support for Gradients and Patterns on filled or stroked Fonts
2414         in Cairo. I also added support for globalAlpha on FontCairo.
2415
2416         [CAIRO] SVG/Canvas fonts miss gradients/pattern support
2417         https://bugs.webkit.org/show_bug.cgi?id=18617
2418
2419         * html/CanvasRenderingContext2D.cpp:
2420         (WebCore::CanvasRenderingContext2D::drawTextInternal):
2421         * platform/graphics/cairo/FontCairo.cpp:
2422         (WebCore::Font::drawGlyphs):
2423
2424 2009-02-26  Stephen White  <senorblanco@chromium.org>
2425
2426         Reviewed by Eric Seidel.
2427
2428         https://bugs.webkit.org/show_bug.cgi?id=23957
2429
2430         Fix for SVG gradient and pattern text for Chromium/skia. 
2431         Added accessors for the fill and stroke gradients to
2432         GraphicsContext.  Changed the paintSkiaText function to take a
2433         GraphicsContext, so we can check for gradients/patterns. 
2434         Changed the skiaDrawText function to set the SkPaint shader
2435         correctly, and to scale up the gradient shader matrix to
2436         encompass the entire text string.  Also offset each glyph
2437         separately, rather than transforming the canvas, so that the
2438         gradient/pattern stays fixed relative to the text origin.
2439
2440         * platform/graphics/GraphicsContext.cpp:
2441         (WebCore::GraphicsContext::getFillGradient):
2442         (WebCore::GraphicsContext::getStrokeGradient):
2443         (WebCore::GraphicsContext::getFillPattern):
2444         (WebCore::GraphicsContext::getStrokePattern):
2445         * platform/graphics/GraphicsContext.h:
2446         * platform/graphics/chromium/FontChromiumWin.cpp:
2447         (WebCore::Font::drawGlyphs):
2448         * platform/graphics/chromium/UniscribeHelper.cpp:
2449         (WebCore::UniscribeHelper::draw):
2450         * platform/graphics/skia/SkiaFontWin.cpp:
2451         (WebCore::windowsCanHandleTextDrawing):
2452         (WebCore::skiaDrawText):
2453         (WebCore::paintSkiaText):
2454         * platform/graphics/skia/SkiaFontWin.h:
2455
2456 2009-02-26  Dimitri Glazkov  <dglazkov@chromium.org>
2457
2458         Reviewed by Eric Seidel.
2459
2460         https://bugs.webkit.org/show_bug.cgi?id=24208
2461         Add custom V8 bindings for Navigator, Clipboard, Document, and Node.
2462
2463         * bindings/v8/custom/V8ClipboardCustom.cpp: Added.
2464         (WebCore::ACCESSOR_GETTER):
2465         (WebCore::CALLBACK_FUNC_DECL):
2466         * bindings/v8/custom/V8DocumentCustom.cpp: Added.
2467         (WebCore::CALLBACK_FUNC_DECL):
2468         * bindings/v8/custom/V8NavigatorCustom.cpp: Added.
2469         (WebCore::ACCESSOR_GETTER):
2470         * bindings/v8/custom/V8NodeCustom.cpp: Added.
2471         (WebCore::CALLBACK_FUNC_DECL):
2472
2473 2009-02-26  Gustavo Noronha Silva  <gns@gnome.org>
2474
2475         Unreviewed build fix for building with GNOME Keyring enabled.
2476
2477         * platform/network/soup/webkit-soup-auth-dialog.c:
2478         (show_auth_dialog):
2479
2480 2009-02-26  Xan Lopez  <xan@gnome.org>
2481
2482         Reviewed by Holger Freyther.
2483
2484         https://bugs.webkit.org/show_bug.cgi?id=16947
2485         [GTK] Missing HTTP Auth challenge
2486
2487         Add HTTP authentication dialog with optional GNOME Keyring
2488         storage.
2489
2490         * GNUmakefile.am:
2491         * platform/network/ResourceHandleInternal.h:
2492         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
2493         * platform/network/soup/ResourceHandleSoup.cpp:
2494         (WebCore::currentToplevelCallback):
2495         (WebCore::ResourceHandle::startHttp):
2496         (WebCore::ResourceHandle::start):
2497         * platform/network/soup/webkit-soup-auth-dialog.c: Added.
2498         (webkit_soup_auth_dialog_class_init):
2499         (webkit_soup_auth_dialog_init):
2500         (webkit_soup_auth_dialog_session_feature_init):
2501         (free_authData):
2502         (set_password_callback):
2503         (response_callback):
2504         (show_auth_dialog):
2505         (find_password_callback):
2506         (session_authenticate):
2507         (attach):
2508         * platform/network/soup/webkit-soup-auth-dialog.h: Added.
2509
2510 2009-02-25  Ojan Vafai  <ojan@chromium.org> and Eric Seidel <eric@webkit.org>
2511
2512         Reviewed by Dave Hyatt.
2513
2514         After Ojan's positionForCoordinates fix http://trac.webkit.org/changeset/41191
2515         svg/custom/pointer-events-image.svg and svg/custom/pointer-events-text.svg
2516         started failing because Ojan's new code was now *correctly* calling through to
2517         SVG asking for the closest text offset in the last line box, instead of
2518         just returning the offset at the end of the last line box when clicking below a box.
2519
2520         But!  The SVG code was wrong, in that it returned the character offset of the last
2521         character when you asked for a character offset after the end of the box, instead
2522         it should return the offset *after* the last character.  This patch fixes
2523         that behavior by reordering the last two clauses in svgCharacterHitsPosition.
2524
2525         The SVG positionForCoordinates function is still wrong, and I've added some FIXMEs
2526         to document what's wrong.  I've also cleaned up the code a bit so it's clearer
2527         what it is doing (which also makes more obvious what's wrong with it).
2528
2529         * rendering/RenderSVGInlineText.cpp:
2530         (WebCore::RenderSVGInlineText::positionForCoordinates):
2531         * rendering/SVGInlineTextBox.cpp:
2532         (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::SVGInlineTextBoxClosestCharacterToPositionWalker):
2533         (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::chunkPortionCallback):
2534         (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::offsetOfHitCharacter):
2535         (WebCore::SVGInlineTextBox::closestCharacterToPosition):
2536         (WebCore::SVGInlineTextBox::svgCharacterHitsPosition):
2537
2538 2009-02-26  Darin Fisher  <darin@chromium.org>
2539
2540         Reviewed by Eric Seidel.
2541
2542         Minor cleanup of ChromiumBridge:
2543         Removing unused matchesMIMEType method and s/Javascript/JavaScript/
2544
2545         * platform/chromium/ChromiumBridge.h:
2546         * platform/chromium/MimeTypeRegistryChromium.cpp:
2547         (WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
2548         (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
2549         (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
2550
2551 2009-02-26  David Hyatt  <hyatt@apple.com>
2552
2553         Reviewed by Sam Weinig
2554
2555         Fix text-bottom vertical alignment.  It was incorrectly aligning the bottom of the descent instead of including
2556         the line-height below the descent.
2557
2558         Added fast/inline/vertical-align-text-bottom.html
2559
2560         * rendering/RenderBoxModelObject.cpp:
2561         (WebCore::RenderBoxModelObject::verticalPosition):
2562
2563 2009-02-26  Dirk Schulze  <krit@webkit.org>
2564
2565         Reviewed by Eric Seidel.
2566
2567         Make SVG Masking platform independet with the use of ImageBuffer::getImageData(),
2568         ImageBuffer::putImageData() and GraphicsContext::clipToImageBuffer(). Every platform has
2569         just to implement this three methods to support SVG Masking now.
2570  
2571         Make SVG Masking platform aware
2572         https://bugs.webkit.org/show_bug.cgi?id=19243
2573
2574         * GNUmakefile.am:
2575         * WebCore.pro:
2576         * WebCore.vcproj/WebCore.vcproj:
2577         * WebCore.xcodeproj/project.pbxproj:
2578         * svg/graphics/SVGResourceMasker.cpp:
2579         (WebCore::SVGResourceMasker::applyMask):
2580         * svg/graphics/cairo/SVGResourceMaskerCairo.cpp: Removed.
2581         * svg/graphics/cg/SVGResourceMaskerCg.cpp: Removed.
2582         * svg/graphics/cg/SVGResourceMaskerCg.mm: Removed.
2583         * svg/graphics/qt/SVGResourceMaskerQt.cpp: Removed.
2584         * svg/graphics/skia/SVGResourceMaskerSkia.cpp: Removed.
2585
2586 2009-02-26  Yong Li  <yong.li@torchmobile.com>
2587
2588         Reviewed by Darin Adler, Antti Koivisto and Alexey Proskuryakov.
2589
2590         Test: http/tests/misc/slow-preload-cancel.html
2591
2592         https://bugs.webkit.org/show_bug.cgi?id=24133
2593         Clear all pending preloads in the DocLoader object when we decide to
2594         cancel its all requests.
2595
2596         * loader/DocLoader.cpp:
2597         (WebCore::DocLoader::clearPendingPreloads):
2598         * loader/DocLoader.h:
2599         * loader/loader.cpp:
2600         (WebCore::Loader::cancelRequests):
2601
2602 2009-02-26  Dimitri Glazkov  <dglazkov@chromium.org>
2603
2604         Reviewed by Eric Seidel.
2605
2606         https://bugs.webkit.org/show_bug.cgi?id=24182
2607         Add NodeFilter, NodeIterator, and TreeWalker custom V8 bindings.
2608
2609         * bindings/v8/custom/V8NodeFilterCustom.cpp: Added.
2610         (WebCore::CALLBACK_FUNC_DECL):
2611         * bindings/v8/custom/V8NodeIteratorCustom.cpp: Added.
2612         (WebCore::toV8):
2613         (WebCore::CALLBACK_FUNC_DECL):
2614         * bindings/v8/custom/V8TreeWalkerCustom.cpp: Added.
2615         (WebCore::toV8):
2616         (WebCore::CALLBACK_FUNC_DECL):
2617
2618 2009-02-26  Alexey Proskuryakov  <ap@webkit.org>
2619
2620         Reviewed by Darin Adler.
2621
2622         https://bugs.webkit.org/show_bug.cgi?id=23500
2623         KURL::parse() incorrectly compares its result to original string
2624
2625         * platform/KURL.cpp: (WebCore::KURL::parse): Take string length into account.
2626
2627 2009-02-26  Ojan Vafai  <ojan@chromium.org>
2628
2629         Reviewed by Kevin McCullough.
2630
2631         Manual test for inspector node highlighting.
2632
2633         * manual-tests/inspector/highlight-nodes.html: Added.
2634
2635 2009-02-16  Anantanarayanan Iyengar  <ananta@chromium.org>
2636
2637         Reviewed by Darin Fisher.
2638
2639         https://bugs.webkit.org/show_bug.cgi?id=23973
2640         ScrollView::scrollContents can be invoked during view shutdown.  In
2641         this scenario the FrameView::hostWindow method can return NULL, which
2642         indicates that the frame/page is being destroyed. This causes a crash
2643         when we try to dereference a NULL hostWindow pointer.  Fix is to add a
2644         NULL check for this.  
2645
2646         * platform/ScrollView.cpp:
2647         (WebCore::ScrollView::scrollContents):
2648
2649 2009-02-26  Rahul Kuchhal  <kuchhal@chromium.org>
2650
2651         Reviewed by Dave Hyatt.
2652
2653         https://bugs.webkit.org/show_bug.cgi?id=24003
2654         Fix a crash caused by unsafe type conversion.
2655
2656         Test: fast/block/positioning/absolute-in-inline-rtl-4.html
2657
2658         * rendering/RenderBox.cpp:
2659         (WebCore::RenderBox::calcAbsoluteHorizontalValues):
2660
2661 2009-02-26  Ojan Vafai  <ojan@chromium.org>
2662
2663         Reviewed by Adam Roben.
2664
2665         https://bugs.webkit.org/show_bug.cgi?id=24202
2666         Have drawNodeHighlight clip instead of clearing. This makes it work for
2667         both Safari and Chromium since Chromium draws the inspector highlighting
2668         in the same buffer as the page.
2669
2670         * inspector/InspectorController.cpp:
2671         (WebCore::quadToPath):
2672         (WebCore::drawOutlinedQuad):
2673         (WebCore::drawOutlinedQuadWithClip):
2674         (WebCore::drawHighlightForBox):
2675
2676 2009-02-26  David Hyatt  <hyatt@apple.com>
2677
2678         Reviewed by Dan Bernstein & Darin Adler
2679
2680         Make sure the border/padding are properly omitted at the start of an inline that is a continuation.
2681         
2682         Added fast/inline/inline-continuation-borders.html
2683
2684         * rendering/InlineFlowBox.cpp:
2685         (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
2686
2687 2009-02-26  Simon Fraser  <simon.fraser@apple.com>
2688
2689         Build fix, no review.
2690         
2691         Try to fix the wx build after r41218.
2692
2693         * WebCoreSources.bkl:
2694
2695 2009-02-26  Alexey Proskuryakov  <ap@webkit.org>
2696
2697         Reviewed by Darin Adler.
2698
2699         https://bugs.webkit.org/show_bug.cgi?id=19527
2700         ASSERTION FAILED: containerA && containerB
2701
2702         Test: fast/dom/Range/bug-19527.html
2703
2704         * dom/Range.cpp:
2705         (WebCore::Range::isPointInRange):
2706         (WebCore::Range::comparePoint):
2707         Bring the behavior in line with current Firefox, making it impossible for these methods
2708         to pass a null container to compareBoundaryPoints().
2709
2710 2009-02-26  Jonathon Jongsma  <jonathon@quotidian.org>
2711
2712         Reviewed by Holger Freyther.
2713
2714         https://bugs.webkit.org/show_bug.cgi?id=20358
2715
2716         * platform/graphics/gtk/SimpleFontDataGtk.cpp:
2717         (WebCore::SimpleFontData::smallCapsFontData): the small-caps font data
2718         should set the computed size rather than the specified size, otherwise
2719         the caps just get rendered normal size.
2720
2721 2009-02-26  Benjamin Meyer  <benjamin.meyer@torchmobile.com>
2722
2723         Reviewed by George Staikos.
2724
2725         https://bugs.webkit.org/show_bug.cgi?id=24062
2726         QNetworkCookieJar expects the url and not the policy url.  Sending the
2727         policy url will cause QNetworkCookieJar to behave incorrectly.  One
2728         example would be a cookie that does not have a path or domain.
2729         QNetworkCookieJar will use the url it is given to fill in default values.
2730         This allows setting cookies on the url of the main frame from an iFrame
2731         when the cookie should be set on the url of the iFrame.
2732
2733         Originally noticed on http://writer.zoho.com/jsp/home.jsp?serviceurl=/index.do
2734
2735         * platform/qt/CookieJarQt.cpp:
2736         (WebCore::setCookies):
2737
2738 2009-02-26  Charles Wei  <charles.wei@torchmobile.com.cn>
2739
2740         Reviewed by George Staikos.
2741
2742         make WebKit/Qt compile with SVG disabled
2743
2744         * WebCore.pro:
2745         * platform/graphics/qt/FontPlatformDataQt.cpp:
2746
2747 2009-02-25  Gustavo Noronha Silva  <gns@gnome.org>
2748
2749         Unreviewed build fix. Add WebCore/workers to the list of paths
2750         searched by the bindings generator perl script.
2751
2752         * GNUmakefile.am:
2753
2754 2009-02-25  Sam Weinig  <sam@webkit.org>
2755
2756         Reviewed by Geoffrey Garen.
2757
2758         Add canvas to the list of RenderObjects that can mark a page as
2759         visually not empty.
2760
2761         * rendering/RenderHTMLCanvas.cpp:
2762         (WebCore::RenderHTMLCanvas::RenderHTMLCanvas):
2763
2764 2009-02-25  Eric Carlson  <eric.carlson@apple.com>
2765
2766         Reviewed by Dave Hyatt.
2767
2768         * rendering/RenderBox.cpp:
2769         (WebCore::RenderBox::nodeAtPoint): Remove assertion fired when child has layer
2770         as RenderMedia with controls always has a layer.
2771
2772 2009-02-25  Dan Bernstein  <mitz@apple.com>
2773
2774         Reviewed by Simon Fraser.
2775
2776         - fix https://bugs.webkit.org/show_bug.cgi?id=24130
2777           <rdar://problem/6618196> Paint very slow when horizontally resizing
2778
2779         Test: fast/gradients/background-clipped.html
2780
2781         * rendering/RenderBoxModelObject.cpp:
2782         (WebCore::RenderBoxModelObject::paintFillLayerExtended): Intersect the
2783         destination rectangle passed to drawTiledImage() with the dirty
2784         rectangle. This makes it more likely for the destination rect to be
2785         contained in a single tile rect, which results in a faster code path
2786         being taken down the road (just drawing a single tile instead of
2787         tiling).
2788
2789 2009-02-25  Ojan Vafai  <ojan@chromium.org>
2790
2791         Reviewed by Eric Seidel.
2792
2793         Fix test regressions from positionForCoordinates patch.
2794         https://bugs.webkit.org/show_bug.cgi?id=24148
2795
2796         * rendering/RenderBlock.cpp:
2797         (WebCore::positionForPointWithInlineChildren):
2798         Remove ASSERT that placeholder text codepath is hitting.
2799
2800 2009-02-25  Chris Fleizach  <cfleizach@apple.com>
2801
2802         Reviewed by Beth Dakin.
2803
2804         Bug 24143: Crash occurs at WebCore::AccessibilityTable::isTableExposableThroughAccessibility() when applying a link in GMail
2805         https://bugs.webkit.org/show_bug.cgi?id=24143
2806
2807         When an AX object is marked dirty, do not create AX elements while going up the parent chain.
2808         Do not allow AXRenderObjects to remove their own IDs from the cache, all the cache to do that work
2809         Make sure the AXObjectWrapper's have an object before calling them
2810         In AXObjectCache, change get -> getOrCreate. Use get() to only retrieve an element if it exists
2811
2812         Test: platform/mac-snowleopard/accessibility/table-updating.html
2813
2814         * WebCore.base.exp:
2815         * page/AXObjectCache.cpp:
2816         (WebCore::AXObjectCache::~AXObjectCache):
2817         (WebCore::AXObjectCache::get):
2818         (WebCore::AXObjectCache::getOrCreate):
2819         (WebCore::AXObjectCache::removeAXID):
2820         (WebCore::AXObjectCache::handleActiveDescendantChanged):
2821         (WebCore::AXObjectCache::handleAriaRoleChanged):
2822         * page/AXObjectCache.h:
2823         * page/AccessibilityImageMapLink.cpp:
2824         (WebCore::AccessibilityImageMapLink::parentObject):
2825         * page/AccessibilityListBox.cpp:
2826         (WebCore::AccessibilityListBox::listBoxOptionAccessibilityObject):
2827         (WebCore::AccessibilityListBox::doAccessibilityHitTest):
2828         * page/AccessibilityListBoxOption.cpp:
2829         (WebCore::AccessibilityListBoxOption::elementRect):
2830         (WebCore::AccessibilityListBoxOption::parentObject):
2831         * page/AccessibilityObject.cpp:
2832         (WebCore::AccessibilityObject::detach):
2833         (WebCore::AccessibilityObject::parentObjectIfExists):
2834         (WebCore::replacedNodeNeedsCharacter):
2835         (WebCore::AccessibilityObject::accessibilityObjectForPosition):
2836         * page/AccessibilityObject.h:
2837         * page/AccessibilityRenderObject.cpp:
2838         (WebCore::AccessibilityRenderObject::firstChild):
2839         (WebCore::AccessibilityRenderObject::lastChild):
2840         (WebCore::AccessibilityRenderObject::previousSibling):
2841         (WebCore::AccessibilityRenderObject::nextSibling):
2842         (WebCore::AccessibilityRenderObject::parentObjectIfExists):
2843         (WebCore::AccessibilityRenderObject::parentObject):
2844         (WebCore::AccessibilityRenderObject::isAttachment):
2845         (WebCore::AccessibilityRenderObject::headingLevel):
2846         (WebCore::AccessibilityRenderObject::anchorElement):
2847         (WebCore::AccessibilityRenderObject::menuForMenuButton):
2848         (WebCore::AccessibilityRenderObject::menuButtonForMenu):
2849         (WebCore::AccessibilityRenderObject::checkboxOrRadioRect):
2850         (WebCore::AccessibilityRenderObject::internalLinkElement):
2851         (WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers):
2852         (WebCore::AccessibilityRenderObject::titleUIElement):
2853         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
2854         (WebCore::AccessibilityRenderObject::accessibilityParentForImageMap):
2855         (WebCore::AccessibilityRenderObject::getDocumentLinks):
2856         (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
2857         (WebCore::AccessibilityRenderObject::focusedUIElement):
2858         (WebCore::AccessibilityRenderObject::activeDescendant):
2859         (WebCore::AccessibilityRenderObject::observableObject):
2860         (WebCore::AccessibilityRenderObject::childrenChanged):
2861         (WebCore::AccessibilityRenderObject::addChildren):
2862         * page/AccessibilityRenderObject.h:
2863         (WebCore::AccessibilityRenderObject::setRenderObject):
2864         * page/AccessibilityTable.cpp:
2865         (WebCore::AccessibilityTable::addChildren):
2866         (WebCore::AccessibilityTable::headerContainer):
2867         (WebCore::AccessibilityTable::cellForColumnAndRow):
2868         * page/AccessibilityTableCell.cpp:
2869         (WebCore::AccessibilityTableCell::isTableCell):
2870         (WebCore::AccessibilityTableCell::titleUIElement):
2871         * page/AccessibilityTableColumn.cpp:
2872         (WebCore::AccessibilityTableColumn::headerObjectForSection):
2873         * page/AccessibilityTableRow.cpp:
2874         (WebCore::AccessibilityTableRow::isTableRow):
2875         * page/gtk/AccessibilityObjectWrapperAtk.cpp:
2876         * page/mac/AXObjectCacheMac.mm:
2877         (WebCore::AXObjectCache::postNotification):
2878         (WebCore::AXObjectCache::postNotificationToElement):
2879         * page/mac/AccessibilityObjectWrapper.mm:
2880         (textMarkerForVisiblePosition):
2881         (AXLinkElementForNode):
2882         (nsStringForReplacedNode):
2883         (-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):
2884         (-[AccessibilityObjectWrapper accessibilityActionNames]):
2885         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
2886         (-[AccessibilityObjectWrapper accessibilityFocusedUIElement]):
2887         (-[AccessibilityObjectWrapper accessibilityHitTest:]):
2888         (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
2889         (-[AccessibilityObjectWrapper accessibilityIsIgnored]):
2890         (-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
2891         (-[AccessibilityObjectWrapper accessibilityPerformPressAction]):
2892         (-[AccessibilityObjectWrapper accessibilityPerformAction:]):
2893         (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
2894         (-[AccessibilityObjectWrapper _accessibilityParentForSubview:]):
2895         (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
2896         (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
2897         (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
2898
2899 2009-02-25  Beth Dakin  <bdakin@apple.com>
2900
2901         Reviewed by Geoff Garen.
2902
2903         Re-working of <rdar://problem/6487249> repro crash in 
2904         WebCore::CSSParser::parseFillImage copying entire contents of this 
2905         page
2906         -and corresponding: https://bugs.webkit.org/show_bug.cgi?id=24172
2907
2908         Fixes a bunch of layout test failures I caused!
2909
2910         * css/CSSParser.cpp:
2911         (WebCore::CSSParser::parseValue):
2912         (WebCore::CSSParser::parseContent):
2913         (WebCore::CSSParser::parseFillImage):
2914         (WebCore::CSSParser::parseFontFaceSrc):
2915         (WebCore::CSSParser::parseBorderImage):
2916
2917 2009-02-25  Dimitri Glazkov  <dglazkov@chromium.org>
2918
2919         Reviewed by Eric Seidel.
2920
2921         https://bugs.webkit.org/show_bug.cgi?id=24174
2922         Add more V8 custom bindings.
2923
2924         * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: Added.
2925         (WebCore::hasCSSPropertyNamePrefix):
2926         (WebCore::cssPropertyName):
2927         (WebCore::NAMED_PROPERTY_GETTER):
2928         (WebCore::NAMED_PROPERTY_SETTER):
2929         * bindings/v8/custom/V8DOMStringListCustom.cpp: Added.
2930         (WebCore::INDEXED_PROPERTY_GETTER):
2931         (WebCore::CALLBACK_FUNC_DECL):
2932         * bindings/v8/custom/V8EventCustom.cpp: Added.
2933         (WebCore::ACCESSOR_SETTER):
2934         (WebCore::ACCESSOR_GETTER):
2935         * bindings/v8/custom/V8HTMLDocumentCustom.cpp: Added.
2936         (WebCore::NAMED_PROPERTY_DELETER):
2937         (WebCore::NAMED_PROPERTY_SETTER):
2938         (WebCore::NAMED_PROPERTY_GETTER):
2939         * bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp: Added.
2940         (WebCore::NAMED_PROPERTY_GETTER):
2941         * bindings/v8/custom/V8NamedNodeMapCustom.cpp: Added.
2942         (WebCore::INDEXED_PROPERTY_GETTER):
2943         (WebCore::NAMED_PROPERTY_GETTER):
2944         * bindings/v8/custom/V8NodeListCustom.cpp: Added.
2945         (WebCore::NAMED_PROPERTY_GETTER):
2946         * bindings/v8/custom/V8StyleSheetListCustom.cpp: Added.
2947         (WebCore::NAMED_PROPERTY_GETTER):
2948
2949 2009-02-25  Scott Violet  <sky@google.com>
2950
2951         Reviewed by Dave Hyatt.
2952
2953         https://bugs.webkit.org/show_bug.cgi?id=24171
2954         Provides a RenderTheme method for getting the scroll bar size and
2955         changes RenderListBox to use it. RenderTheme returns a size of regular,
2956         and Mac's override to return small. Changes ScrollbarThemeChromium to
2957         use the scrollbarsize of the scrollbar when getting the size
2958         instead of passing in no-args.
2959
2960         * platform/chromium/ScrollbarThemeChromium.cpp:
2961         (WebCore::ScrollbarThemeChromium::trackRect):
2962         (WebCore::ScrollbarThemeChromium::buttonSize):
2963         * rendering/RenderListBox.cpp:
2964         (WebCore::RenderListBox::createScrollbar):
2965         * rendering/RenderTheme.h:
2966         (WebCore::RenderTheme::scrollbarControlSizeForPart):
2967         * rendering/RenderThemeChromiumMac.h:
2968         (WebCore::RenderThemeChromiumMac::scrollbarControlSizeForPart):
2969         * rendering/RenderThemeMac.h:
2970         (WebCore::RenderThemeMac::scrollbarControlSizeForPart):
2971
2972 2009-02-25  Beth Dakin  <bdakin@apple.com>
2973
2974         Reviewed by Darin Adler.
2975
2976         Fix for <rdar://problem/6487249> repro crash in 
2977         WebCore::CSSParser::parseFillImage copying entire contents of this 
2978         page
2979         -and corresponding: https://bugs.webkit.org/show_bug.cgi?id=24172
2980
2981         * css/CSSParser.cpp:
2982         (WebCore::CSSParser::parseValue): Null-check m_styleSheet
2983
2984 2009-02-25  Adam Treat  <adam.treat@torchmobile.com>
2985
2986         Fix the Qt build.
2987
2988         * WebCore.pro:
2989
2990 2009-02-25  Jan Michael Alonzo  <jmalonzo@webkit.org>
2991
2992         Gtk build fix. Not reviewed.
2993
2994         Add files to the build per r41218.
2995         Rename WebkitPoint.h to WebKitPoint.h in DOMWindow.cpp
2996
2997         * GNUmakefile.am:
2998         * page/DOMWindow.cpp:
2999
3000 2009-02-25  Zan Dobersek  <zandobersek@gmail.com>
3001
3002         Reviewed by Alexey Proskuryakov.
3003
3004         https://bugs.webkit.org/show_bug.cgi?id=24043
3005         When faced with URLs with unsupported protocol on Gtk port,
3006         report the error through an idle function and return true, so
3007         a proper resource handle is created.
3008
3009         * platform/network/soup/ResourceHandleSoup.cpp:
3010         (WebCore::reportUnknownProtocolError):
3011         (WebCore::ResourceHandle::start):
3012
3013 2009-02-25  Steve Falkenburg  <sfalken@apple.com>
3014
3015         Windows build fix.
3016         Use struct to forward declare ResourceRequest.
3017
3018         * history/HistoryItem.h:
3019         * inspector/InspectorController.h:
3020         * loader/DocumentThreadableLoader.h:
3021         * loader/FrameLoaderClient.h:
3022         * loader/MainResourceLoader.h:
3023         * loader/SubresourceLoader.h:
3024         * loader/SubresourceLoaderClient.h:
3025         * loader/ThreadableLoader.h:
3026         * loader/WorkerThreadableLoader.h:
3027         * platform/CrossThreadCopier.h:
3028         * platform/network/ResourceHandle.h:
3029         * platform/network/ResourceHandleClient.h:
3030         * platform/network/ResourceRequestBase.h:
3031         * platform/network/cf/ResourceRequestCFNet.h:
3032         * xml/XMLHttpRequest.h:
3033
3034 2009-02-25  Steve Falkenburg  <sfalken@apple.com>
3035
3036         Partial Windows build fix.
3037         
3038         * DerivedSources.cpp:
3039         * WebCore.vcproj/WebCore.vcproj:
3040
3041 2009-02-25  Dirk Schulze  <krit@webkit.org>
3042
3043         Reviewed by Oliver Hunt.
3044
3045         Ported arcTo to Qt. Qt has no native support for arcTo. This changes
3046         calculate the behavior of arcTo and draws it with lineTo and arc.
3047
3048         [QT] implement Canvas arcTo
3049         https://bugs.webkit.org/show_bug.cgi?id=23873
3050
3051         * platform/graphics/qt/PathQt.cpp:
3052         (WebCore::Path::addArcTo):
3053
3054 2009-02-25  Simon Fraser  <simon.fraser@apple.com>
3055
3056         Reviewed by Dan Bernstein
3057
3058         Remove idl files from Resources, and sort.
3059         
3060         * WebCore.xcodeproj/project.pbxproj:
3061
3062 2009-02-25  Chris Marrin  <cmarrin@apple.com>
3063
3064         Reviewed by Simon Fraser.
3065
3066         https://bugs.webkit.org/show_bug.cgi?id=23943
3067
3068         Added webkitConvertPointFromNodeToPage and webkitConvertPointFromPageToNode on
3069         the window object. Also added WebKitPoint object, which is passed in and out
3070         of these functions.
3071
3072         Test: fast/dom/Window/webkitConvertPoint.html
3073
3074         * DerivedSources.make:
3075         * WebCore.pro:
3076         * WebCore.vcproj/WebCore.vcproj:
3077         * WebCore.xcodeproj/project.pbxproj:
3078         * WebCoreSources.bkl:
3079         * bindings/js/JSDOMWindowBase.cpp:
3080         (jsDOMWindowBaseWebKitPoint):
3081         (setJSDOMWindowBaseWebKitPoint):
3082         * bindings/js/JSWebKitPointConstructor.cpp: Added.
3083         (WebCore::):
3084         (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
3085         (WebCore::constructWebKitPoint):
3086         (WebCore::JSWebKitPointConstructor::getConstructData):
3087         * bindings/js/JSWebKitPointConstructor.h: Added.
3088         (WebCore::JSWebKitPointConstructor::classInfo):
3089         * dom/Node.cpp:
3090         (WebCore::Node::convertToPage):
3091         (WebCore::Node::convertFromPage):
3092         * dom/Node.h:
3093         * page/DOMWindow.cpp:
3094         (WebCore::DOMWindow::webkitConvertPointFromNodeToPage):
3095         (WebCore::DOMWindow::webkitConvertPointFromPageToNode):
3096         * page/DOMWindow.h:
3097         * page/DOMWindow.idl:
3098         * page/WebKitPoint.h: Added.
3099         (WebCore::WebKitPoint::create):
3100         (WebCore::WebKitPoint::x):
3101         (WebCore::WebKitPoint::y):
3102         (WebCore::WebKitPoint::setX):
3103         (WebCore::WebKitPoint::setY):
3104         (WebCore::WebKitPoint::WebKitPoint):
3105         * page/WebKitPoint.idl: Added.
3106
3107 2009-02-25  Jian Li  <jianli@chromium.org>
3108
3109         Reviewed by Alexey Proskuryakov.
3110
3111         Remove "#if ENABLE(WORKERS)" wrap from CrossThreadCopier files.
3112         https://bugs.webkit.org/show_bug.cgi?id=24145
3113
3114         * platform/CrossThreadCopier.cpp:
3115         * platform/CrossThreadCopier.h:
3116
3117 2009-02-25  David Levin  <levin@chromium.org>
3118
3119         Reviewed by Alexey Proskuryakov.
3120
3121         Bug 23688: ThreadableLoader needs a sync implementation for Workers.
3122         <https://bugs.webkit.org/show_bug.cgi?id=23688>
3123
3124         No observable change in behavior, so no test.
3125
3126         * loader/ThreadableLoader.cpp:
3127         (WebCore::ThreadableLoader::loadResourceSynchronously):
3128         * loader/ThreadableLoaderClientWrapper.h:
3129         (WebCore::ThreadableLoaderClientWrapper::clearClient):
3130         (WebCore::ThreadableLoaderClientWrapper::done):
3131         (WebCore::ThreadableLoaderClientWrapper::didFinishLoading):
3132         (WebCore::ThreadableLoaderClientWrapper::didFail):
3133         (WebCore::ThreadableLoaderClientWrapper::didFailRedirectCheck):
3134         (WebCore::ThreadableLoaderClientWrapper::ThreadableLoaderClientWrapper):
3135         Expose whether the loader is done (based on what callbacks were done).
3136
3137         * loader/WorkerThreadableLoader.cpp:
3138         (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
3139         (WebCore::WorkerThreadableLoader::loadResourceSynchronously):
3140         Each loader is given its own mode so that only its callbacks get through the run loop.
3141
3142         The xhr spec says that the readystatechange events are synchronous, so in the case of a
3143         nested sync xhr no readystatechange events should be fired for the outer xhr.
3144
3145         (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
3146
3147         * loader/WorkerThreadableLoader.h:
3148         (WebCore::WorkerThreadableLoader::create):
3149         (WebCore::WorkerThreadableLoader::done):
3150
3151         * workers/WorkerRunLoop.cpp:
3152         (WebCore::WorkerRunLoop::WorkerRunLoop):
3153         * workers/WorkerRunLoop.h:
3154         (WebCore::WorkerRunLoop::createUniqueId):
3155         Simple method to create a uniqueId on demand with respect to the run loop.
3156
3157         * workers/WorkerThread.h:
3158
3159 2009-02-25  David Levin  <levin@chromium.org>
3160
3161         Reviewed by Alexey Proskuryakov.
3162
3163         Bug 24089: ThreadableLoader::loadResourceSynchronously should do callbacks like the async code.
3164         <https://bugs.webkit.org/show_bug.cgi?id=24089>
3165
3166         Make threadable loader callbacks to happen during the sync load call.
3167
3168         Changes the behavior of sync xhr for insecure redirects in two ways:
3169         + Sends an error event instead of an abort event (which is the same as async xhr's behavior).
3170         + Throws a network exception which is what other browsers do and what the spec
3171         says to do (http://www.w3.org/TR/XMLHttpRequest/).
3172
3173         * loader/DocumentThreadableLoader.cpp:
3174         (WebCore::DocumentThreadableLoader::loadResourceSynchronously):
3175         * loader/DocumentThreadableLoader.h:
3176         * loader/ThreadableLoader.cpp:
3177         (WebCore::ThreadableLoader::loadResourceSynchronously):
3178         * loader/ThreadableLoader.h:
3179         * xml/XMLHttpRequest.cpp:
3180         (WebCore::XMLHttpRequest::XMLHttpRequest):
3181         (WebCore::XMLHttpRequest::loadRequestSynchronously):
3182         (WebCore::XMLHttpRequest::loadRequestAsynchronously):
3183         (WebCore::XMLHttpRequest::didFail):
3184         (WebCore::XMLHttpRequest::didFailRedirectCheck):
3185         * xml/XMLHttpRequest.h:
3186
3187 2009-02-24  Chris Marrin  <cmarrin@apple.com>
3188
3189         Reviewed by David Hyatt.
3190
3191         https://bugs.webkit.org/show_bug.cgi?id=23368
3192
3193         Added logic to correctly hit test accelerated layers.
3194
3195         Tests: animations/animation-hit-test-transform.html
3196                animations/animation-hit-test.html
3197                transitions/transition-hit-test-transform.html
3198                transitions/transition-hit-test.html
3199
3200         * page/animation/KeyframeAnimation.cpp:
3201         (WebCore::KeyframeAnimation::animate):
3202         * rendering/RenderLayer.cpp:
3203         (WebCore::RenderLayer::hitTestLayer):
3204         (WebCore::RenderLayer::updateClipRects):
3205         * rendering/RenderLayerBacking.cpp:
3206         (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
3207
3208 2009-02-25  Alexey Proskuryakov  <ap@webkit.org>
3209
3210         Reviewed by Darin Adler.
3211
3212         https://bugs.webkit.org/show_bug.cgi?id=24067
3213         REGRESSION: Crash in WebCore::Document::initSecurityContext
3214
3215         The crash started to happen when we removed a check for frame->document() being null.
3216         However, the original document shouldn't be null here, because it is needed to alias
3217         security origins. So, this patch fixes the crash by correcting security origin behavior.
3218
3219         Test: http/tests/security/aboutBlank/window-open-self-about-blank.html
3220         This tests for not crashing, and for inheriting the domain from the document being replaced.
3221         Preserving the aliasing cannot be tested for automatically, because we'd need a non-trivial
3222         domain to remove a prefix from.
3223
3224         * loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): Create a new document before
3225         clearing the frame, so that Document::initSecurityContext() could access the old one.
3226
3227 2009-02-25  Jay Campan  <jcampan@google.com>
3228
3229         Reviewed by Darin Fisher.
3230
3231         https://bugs.webkit.org/show_bug.cgi?id=24066
3232
3233         Items in drop-downs were not painted correctly.  Makes sure the
3234         PopupListBox invalidates in the coordinates of the window as this is
3235         FramelessScrollView::invalidateRect paints to.
3236
3237         * platform/chromium/PopupMenuChromium.cpp:
3238         (WebCore::PopupListBox::invalidateRow):
3239
3240 2009-02-24  Simon Fraser  <simon.fraser@apple.com>
3241
3242         Reviewed by Anders Carlsson
3243
3244         https://bugs.webkit.org/show_bug.cgi?id=15081
3245         
3246         Make display:none work for applet, emebed and object elements
3247         by calling rendererIsNeeded() on superclasses.
3248
3249         Tests: fast/replaced/applet-display-none.html
3250                fast/replaced/embed-display-none.html
3251                fast/replaced/object-display-none.html
3252
3253         * html/HTMLAppletElement.cpp:
3254         (WebCore::HTMLAppletElement::rendererIsNeeded):
3255         * html/HTMLElement.cpp:
3256         (WebCore::HTMLElement::rendererIsNeeded):
3257         * html/HTMLEmbedElement.cpp:
3258         (WebCore::HTMLEmbedElement::rendererIsNeeded):
3259         * html/HTMLObjectElement.cpp:
3260         (WebCore::HTMLObjectElement::rendererIsNeeded):
3261
3262 2009-02-24  Simon Fraser  <simon.fraser@apple.com>
3263
3264         Reviewed by Dave Hyatt
3265
3266         https://bugs.webkit.org/show_bug.cgi?id=24137
3267         
3268         Fix localToAbsolute() and absoluteToLocal() to map points through 3d transforms,
3269         taking perspective and transform-style: preserve-3d into account.
3270         
3271         In order to support transform-style: preserve-3d, which keeps elements in a
3272         3d space, we have to carry along an accumulated matrix in TransformState.
3273         We also need to apply the perspective from the parent, if any, with the
3274         appropriate origin.
3275
3276         * GNUmakefile.am:
3277         * WebCore.base.exp:
3278         * WebCore.pro:
3279         * WebCore.scons:
3280         * WebCore.vcproj/WebCore.vcproj:
3281         * WebCore.xcodeproj/project.pbxproj:
3282         * WebCoreSources.bkl:
3283         * css/CSSComputedStyleDeclaration.cpp:
3284         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
3285         * platform/graphics/transforms/TransformationMatrix.cpp:
3286         (WebCore::TransformationMatrix::translate):
3287         (WebCore::TransformationMatrix::translate3d):
3288         (WebCore::TransformationMatrix::translateRight3d):
3289         * platform/graphics/transforms/TransformationMatrix.h:
3290         * rendering/RenderBox.cpp:
3291         (WebCore::RenderBox::mapLocalToAbsolutePoint):
3292         (WebCore::RenderBox::mapAbsoluteToLocalPoint):
3293         * rendering/RenderBox.h:
3294         * rendering/RenderLayer.cpp:
3295         (WebCore::RenderLayer::updateTransform):
3296         (WebCore::RenderLayer::perspectiveTransform):
3297         (WebCore::RenderLayer::perspectiveOrigin):
3298         * rendering/RenderLayer.h:
3299         * rendering/RenderLayerBacking.cpp:
3300         (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
3301         * rendering/RenderLayerCompositor.cpp:
3302         (WebCore::requiresCompositingLayerForTransform):
3303         (WebCore::RenderLayerCompositor::layerHas3DContent):
3304         * rendering/RenderObject.cpp:
3305         (WebCore::RenderObject::localToAbsolute):
3306         (WebCore::RenderObject::absoluteToLocal):
3307         (WebCore::RenderObject::mapLocalToAbsolutePoint):
3308         (WebCore::RenderObject::mapAbsoluteToLocalPoint):
3309         * rendering/RenderObject.h:
3310         * rendering/RenderTableCell.cpp:
3311         (WebCore::RenderTableCell::mapLocalToAbsolutePoint):
3312         (WebCore::RenderTableCell::mapAbsoluteToLocalPoint):
3313         * rendering/RenderTableCell.h:
3314         * rendering/RenderView.cpp:
3315         (WebCore::RenderView::mapLocalToAbsolutePoint):
3316         (WebCore::RenderView::mapAbsoluteToLocalPoint):
3317         * rendering/RenderView.h:
3318         * rendering/TransformState.cpp: Added.
3319         (WebCore::TransformState::move):
3320         (WebCore::TransformState::applyTransform):
3321         (WebCore::TransformState::flatten):
3322         * rendering/TransformState.h: Added.
3323         (WebCore::TransformState::):
3324         (WebCore::TransformState::TransformState):
3325         (WebCore::TransformState::move):
3326         * rendering/style/RenderStyle.h:
3327         (WebCore::InheritedFlags::hasPerspective):
3328
3329 2009-02-24  Sam Weinig  <sam@webkit.org>
3330
3331         Reviewed by David Hyatt.
3332
3333         Fix for https://bugs.webkit.org/show_bug.cgi?id=23990
3334         Regression (r40837): JavaScript image popup doesn't work
3335
3336         Make the getClientRects and getBoundingClientRect methods return rects
3337         relative to the viewport.
3338
3339         Test: fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport.html
3340
3341         * dom/Element.cpp:
3342         (WebCore::Element::getClientRects):
3343         (WebCore::Element::getBoundingClientRect):
3344
3345 2009-02-24  Ojan Vafai  <ojan@chromium.org>
3346
3347         Reviewed by Eric Seidel.
3348
3349         SVG pages don't have a body or an html element! 
3350         Don't return early if there is no body.
3351
3352         * editing/VisiblePosition.cpp:
3353         (WebCore::VisiblePosition::canonicalPosition):
3354
3355 2009-02-23  David Hyatt  <hyatt@apple.com>
3356
3357         Reviewed by Eric Seidel
3358
3359         https://bugs.webkit.org/show_bug.cgi?id=23740, painting order wrong for normal flow elements with overflow: hidden
3360         
3361         This patch reworks the painting of overflow.  There is now the concept of a "self-painting layer."  All
3362         layers are considered to be self-painting except for overflow layers that are normal flow (and that don't have
3363         reflections or masks).
3364         
3365         If an overflow layer is not self-painting, then it ends up painted by its parent just like any other normal flow object.
3366         The only difference is that the clip has to be pushed and popped when painting the object's children.
3367         
3368         The lightweight clipping scheme used for controls has been extended to cover overflow now in this simplified case.  With
3369         the code consolidated into reusable push/pop functions, all of the renderers that use overflow have been patched to
3370         use the new functions.
3371         
3372         Hit testing has also been patched to check the overflow clip rect first before recurring into children.
3373         
3374         Scrollbar paint has been moved into RenderBlock for now, since none of the table objects support scrollbars
3375         yet, and scrollbar hit testing was already there anyway.  Now the two code paths are more symmetrical.
3376         
3377         Masks are now treated like normal flow layers (just like reflections).
3378
3379         A couple of test cases have been added to fast/overflow to test the stacking order. 
3380
3381         * rendering/InlineFlowBox.cpp:
3382         (WebCore::InlineFlowBox::nodeAtPoint):
3383         (WebCore::InlineFlowBox::paint):
3384         * rendering/RenderBlock.cpp:
3385         (WebCore::RenderBlock::repaintOverhangingFloats):
3386         (WebCore::RenderBlock::paint):
3387         (WebCore::RenderBlock::paintChildren):
3388         (WebCore::RenderBlock::paintObject):
3389         (WebCore::RenderBlock::paintFloats):
3390         (WebCore::RenderBlock::insertFloatingObject):
3391         (WebCore::RenderBlock::floatRect):
3392         (WebCore::RenderBlock::lowestPosition):
3393         (WebCore::RenderBlock::rightmostPosition):
3394         (WebCore::RenderBlock::leftmostPosition):
3395         (WebCore::RenderBlock::addOverhangingFloats):
3396         (WebCore::RenderBlock::nodeAtPoint):
3397         (WebCore::RenderBlock::hitTestContents):
3398         * rendering/RenderBox.cpp:
3399         (WebCore::RenderBox::nodeAtPoint):
3400         (WebCore::RenderBox::pushContentsClip):
3401         (WebCore::RenderBox::popContentsClip):
3402         * rendering/RenderBox.h:
3403         (WebCore::RenderBox::paintObject):
3404         * rendering/RenderBoxModelObject.cpp:
3405         (WebCore::RenderBoxModelObject::hasSelfPaintingLayer):
3406         * rendering/RenderBoxModelObject.h:
3407         * rendering/RenderLayer.cpp:
3408         (WebCore::RenderLayer::paintLayer):
3409         (WebCore::RenderLayer::hitTestLayer):
3410         (WebCore::RenderLayer::shouldBeNormalFlowOnly):
3411         (WebCore::RenderLayer::isSelfPaintingLayer):
3412         * rendering/RenderLayer.h:
3413         * rendering/RenderTable.cpp:
3414         (WebCore::RenderTable::paint):
3415         (WebCore::RenderTable::paintObject):
3416         (WebCore::RenderTable::nodeAtPoint):
3417         * rendering/RenderTable.h:
3418         * rendering/RenderTableCell.cpp:
3419         (WebCore::RenderTableCell::paint):
3420         * rendering/RenderTableRow.cpp:
3421         (WebCore::RenderTableRow::nodeAtPoint):
3422         (WebCore::RenderTableRow::paint):
3423         * rendering/RenderTableRow.h:
3424         * rendering/RenderTableSection.cpp:
3425         (WebCore::RenderTableSection::paint):
3426         (WebCore::RenderTableSection::paintObject):
3427         (WebCore::RenderTableSection::nodeAtPoint):
3428         * rendering/RenderTableSection.h:
3429         * rendering/RenderTreeAsText.cpp:
3430         (WebCore::write):
3431         (WebCore::writeLayers):
3432
3433 2009-02-24  David Levin  <levin@chromium.org>
3434
3435         Reviewed by NOBODY (build fix).
3436
3437         Attempted build fix for wx-mac.
3438
3439         * WebCoreSources.bkl:
3440
3441 2009-02-24  David Levin  <levin@chromium.org>
3442
3443         Reviewed by NOBODY (build fix).
3444
3445         Attempted build fixes for qt-linux and wx-mac.
3446
3447         * WebCore.pro:
3448         * webcore-base.bkl:
3449
3450 2009-02-24  Ojan Vafai  <ojan@dhcp-172-31-134-214.sfo.corp.google.com>
3451
3452         Reviewed by Sam Weinig.
3453
3454         Fix null pointer error. If the node is the Document, then ownerDocument() 
3455         returns null, document() does not.
3456
3457         * editing/VisiblePosition.cpp:
3458         (WebCore::VisiblePosition::canonicalPosition):
3459
3460 2009-02-24  Jian Li  <jianli@chromium.org>
3461
3462         Reviewed by NOBODY (attempted build fixes).
3463
3464         Fix build break for Windows and Linux.
3465
3466         * GNUmakefile.am:
3467         * WebCore.vcproj/WebCore.vcproj:
3468
3469 2009-02-24  Dimitri Glazkov  <dglazkov@chromium.org>
3470
3471         Reviewed by Eric Seidel.
3472
3473         https://bugs.webkit.org/show_bug.cgi?id=24131
3474         Fix-up COM/RefCounted dichotomy in Chromium port.
3475
3476         * page/chromium/AccessibilityObjectWrapper.h:
3477         (WebCore::AccessibilityObjectWrapper::AccessibilityObjectWrapper): Added
3478         explicit setting of recount.
3479
3480 2009-02-24  Dimitri Glazkov  <dglazkov@chromium.org>
3481
3482         Reviewed by Eric Seidel.
3483
3484         https://bugs.webkit.org/show_bug.cgi?id=24141
3485         Add clarity to V8 interceptor helper function.
3486
3487         * bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
3488         (WebCore::NAMED_PROPERTY_GETTER): Renamed to notHandledByInterceptor.
3489         (WebCore::NAMED_PROPERTY_SETTER): Ditto.
3490         (WebCore::INDEXED_PROPERTY_GETTER): Ditto.
3491         (WebCore::INDEXED_PROPERTY_SETTER): Ditto.
3492
3493 2009-02-24  Simon Fraser  <simon.fraser@apple.com>
3494
3495         Reviewed by Eric Seidel
3496
3497         Minor numeric cleanup: convert float literals to doubles.
3498         
3499         * platform/graphics/transforms/RotateTransformOperation.cpp:
3500         (WebCore::RotateTransformOperation::blend):
3501
3502 2009-02-24  Mark Mentovai  <mark@chromium.org>
3503
3504         Reviewed by Eric Seidel.
3505
3506         https://bugs.webkit.org/show_bug.cgi?id=24139
3507         Add missing include.
3508
3509         * bindings/v8/ScriptInstance.h:
3510
3511 2009-02-24  Jian Li  <jianli@chromium.org>
3512
3513         Reviewed by Alexey Proskuryakov.
3514
3515         Move worker related files from dom directory to worker directory under WebCore.
3516         https://bugs.webkit.org/show_bug.cgi?id=24123
3517
3518         * DerivedSources.make:
3519         * GNUmakefile.am:
3520         * WebCore.pro:
3521         * WebCore.scons:
3522         * WebCore.vcproj/MigrateIDLAndScripts:
3523         * WebCore.vcproj/WebCore.vcproj:
3524         * WebCore.xcodeproj/project.pbxproj:
3525         * platform/CrossThreadCopier.cpp: Renamed from WebCore/dom/CrossThreadCopier.cpp.
3526         * platform/CrossThreadCopier.h: Renamed from WebCore/dom/CrossThreadCopier.h.
3527         * workers/GenericWorkerTask.h: Renamed from WebCore/dom/GenericWorkerTask.h.
3528         * workers/Worker.cpp: Renamed from WebCore/dom/Worker.cpp.
3529         * workers/Worker.h: Renamed from WebCore/dom/Worker.h.
3530         * workers/Worker.idl: Renamed from WebCore/dom/Worker.idl.
3531         * workers/WorkerContext.cpp: Renamed from WebCore/dom/WorkerContext.cpp.
3532         * workers/WorkerContext.h: Renamed from WebCore/dom/WorkerContext.h.
3533         * workers/WorkerContext.idl: Renamed from WebCore/dom/WorkerContext.idl.
3534         * workers/WorkerContextProxy.h: Renamed from WebCore/dom/WorkerContextProxy.h.
3535         * workers/WorkerLocation.cpp: Renamed from WebCore/dom/WorkerLocation.cpp.
3536         * workers/WorkerLocation.h: Renamed from WebCore/dom/WorkerLocation.h.
3537         * workers/WorkerLocation.idl: Renamed from WebCore/dom/WorkerLocation.idl.
3538         * workers/WorkerMessagingProxy.cpp: Renamed from WebCore/dom/WorkerMessagingProxy.cpp.
3539         * workers/WorkerMessagingProxy.h: Renamed from WebCore/dom/WorkerMessagingProxy.h.
3540         * workers/WorkerObjectProxy.h: Renamed from WebCore/dom/WorkerObjectProxy.h.
3541         * workers/WorkerRunLoop.cpp: Renamed from WebCore/dom/WorkerRunLoop.cpp.
3542         * workers/WorkerRunLoop.h: Renamed from WebCore/dom/WorkerRunLoop.h.
3543         * workers/WorkerThread.cpp: Renamed from WebCore/dom/WorkerThread.cpp.
3544         * workers/WorkerThread.h: Renamed from WebCore/dom/WorkerThread.h.
3545
3546 2009-02-05  Ojan Vafai  <ojan@chromium.org> and Eric Seidel <eric@webkit.org>
3547
3548         Reviewed by Dave Hyatt.
3549
3550         Make cursor positions match IE6/IE7/FF3 when clicking in margins/padding
3551         around divs inside editable regions.
3552         https://bugs.webkit.org/show_bug.cgi?id=23605
3553
3554         Fix clicks outside editable regions from focusing the editable region.
3555         https://bugs.webkit.org/show_bug.cgi?id=23607
3556
3557         Removed editing/selection/contenteditable-click-outside.html as it's
3558         not as useful as our new tests.
3559
3560         Clean up RenderBlock::positionForCoordinates to remove dead code,
3561         duplicate code, and generally make it more readable.
3562
3563         Tests: editing/selection/click-in-margins-inside-editable-div.html
3564                editing/selection/click-in-padding-with-multiple-line-boxes.html
3565                editing/selection/click-outside-editable-div.html
3566
3567         * editing/VisiblePosition.cpp:
3568         (WebCore::VisiblePosition::canonicalPosition):
3569         * rendering/RenderBlock.cpp:
3570         (WebCore::positionForPointRespectingEditingBoundaries):
3571         (WebCore::positionForPointWithInlineChildren):
3572         (WebCore::RenderBlock::positionForCoordinates):
3573         (WebCore::RenderBlock::updateFirstLetter):
3574
3575 2009-02-24  Sam Weinig  <sam@webkit.org>
3576
3577         Reviewed by Geoffrey Garen.
3578
3579         Related to <rdar://problem/6590295>
3580         Allow disabling javascript: urls.
3581
3582         * WebCore.base.exp:
3583         * html/HTMLAnchorElement.cpp:
3584         (WebCore::HTMLAnchorElement::parseMappedAttribute):
3585         * loader/FrameLoader.cpp:
3586         (WebCore::FrameLoader::executeIfJavaScriptURL):
3587         * page/Page.cpp:
3588         (WebCore::Page::Page):
3589         (WebCore::Page::setJavaScriptURLsAreAllowed):
3590         (WebCore::Page::javaScriptURLsAreAllowed):
3591         * page/Page.h:
3592
3593 2009-02-24  Simon Fraser  <simon.fraser@apple.com>
3594
3595         Fix build when ACCELERATED_COMPOSITING is turned on
3596         (overflowList() -> normalFlowList()).
3597     
3598         * rendering/RenderLayerBacking.cpp:
3599         (WebCore::RenderLayerBacking::hasNonCompositingContent):
3600         (WebCore::RenderLayerBacking::paintIntoLayer):
3601         * rendering/RenderLayerCompositor.cpp:
3602         (WebCore::RenderLayerCompositor::calculateCompositedBounds):
3603         (WebCore::RenderLayerCompositor::computeCompositingRequirements):
3604         (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
3605         (WebCore::RenderLayerCompositor::recursiveRepaintLayerRect):
3606         (WebCore::RenderLayerCompositor::layerHas3DContent):
3607
3608 2009-02-24  Simon Fraser  <simon.fraser@apple.com>
3609
3610         Reviewed by Darin Adler
3611         
3612         https://bugs.webkit.org/show_bug.cgi?id=24135
3613         
3614         Round the FloatPoint returned by absoluteToLocal(), rather than
3615         truncating it.
3616
3617         * dom/MouseRelatedEvent.cpp:
3618         (WebCore::MouseRelatedEvent::receivedTarget):
3619
3620 2009-02-24  Beth Dakin  <bdakin@apple.com>
3621
3622         Reviewed by Sam Weinig.
3623
3624         Fix for https://bugs.webkit.org/show_bug.cgi?id=24004 REGRESSION: 
3625         Ordered list item marker misaligned when line height is not 1.2 
3626         -and corresponding <rdar://problem/6602506>
3627
3628         This is a regression from http://trac.webkit.org/changeset/40880 
3629         where createInlineBox was taken off of RenderObject and moved to 
3630         RenderBox. The problem was that the RenderBox version still needs 
3631         to be virtual because there is still an existing implementation in 
3632         RenderListMarker. 
3633
3634         * rendering/RenderBox.h:
3635         * rendering/RenderListMarker.cpp:
3636         (WebCore::RenderListMarker::createInlineBox):
3637         * rendering/RenderListMarker.h:
3638
3639 2009-02-24  Dimitri Glazkov  <dglazkov@chromium.org>
3640
3641         Reviewed by Eric Seidel.
3642
3643         https://bugs.webkit.org/show_bug.cgi?id=24128
3644         Upstream more V8 custom bindings: constructors, XSLTProcessor.
3645
3646         * bindings/v8/custom/V8DOMParserConstructor.cpp: Added.
3647         (WebCore::CALLBACK_FUNC_DECL):
3648         * bindings/v8/custom/V8MessageChannelConstructor.cpp: Added.
3649         (WebCore::CALLBACK_FUNC_DECL):
3650         * bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp: Added.
3651         (WebCore::CALLBACK_FUNC_DECL):
3652         * bindings/v8/custom/V8XMLSerializerConstructor.cpp: Added.
3653         (WebCore::CALLBACK_FUNC_DECL):
3654         * bindings/v8/custom/V8XPathEvaluatorConstructor.cpp: Added.
3655         (WebCore::CALLBACK_FUNC_DECL):
3656         * bindings/v8/custom/V8XSLTProcessorCustom.cpp: Added.
3657         (WebCore::CALLBACK_FUNC_DECL):
3658
3659 2009-02-24  David Levin  <levin@chromium.org>
3660
3661         Reviewed by Alexey Proskuryakov.
3662
3663         Bug 24090: WorkerThreadableLoader needs to be able to post tasks for a mode.
3664         <https://bugs.webkit.org/show_bug.cgi?id=24090>
3665
3666         No observable change in behavior, so no test.
3667
3668         * dom/WorkerMessagingProxy.cpp:
3669         (WebCore::WorkerMessagingProxy::postMessageToWorkerContext):
3670         (WebCore::WorkerMessagingProxy::postTaskToWorkerContext):
3671         Fixed the bug that m_unconfirmedMessageCount was getting incremented for non-message tasks.
3672
3673         (WebCore::WorkerMessagingProxy::postTaskForModeToWorkerContext):
3674
3675         * dom/WorkerMessagingProxy.h:
3676         * loader/ThreadableLoader.cpp:
3677         (WebCore::ThreadableLoader::create):
3678         * loader/WorkerThreadableLoader.cpp:
3679         (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
3680         (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
3681         (WebCore::WorkerThreadableLoader::MainThreadBridge::didSendData):
3682         (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse):
3683         (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):
3684         (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
3685         (WebCore::WorkerThreadableLoader::MainThreadBridge::didFail):
3686         (WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck):
3687         (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveAuthenticationCancellation):
3688         Changed these methods to post task using a mode.
3689
3690         * loader/WorkerThreadableLoader.h:
3691         (WebCore::WorkerThreadableLoader::create):
3692
3693 2009-02-24  Alexey Proskuryakov  <ap@webkit.org>
3694
3695         Reviewed by Darin Adler.
3696
3697         https://bugs.webkit.org/show_bug.cgi?id=24091
3698         <rdar://problem/6468660> Start of redirect chain ends up as master entry in Application Cache
3699
3700         Test: http/tests/appcache/access-via-redirect.php
3701
3702         * loader/appcache/ApplicationCacheGroup.cpp:
3703         (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): Use the URL we ended up with,
3704         not the original one.
3705
3706 2009-02-24  Jian Li  <jianli@chromium.org>
3707
3708         Reviewed by Alexey Proskuryakov.
3709
3710         Change to include WorkerObjectProxy.h instead of WorkerMessagingProxy.h in WorkerContext.cpp and WorkerScriptController.cpp.
3711         https://bugs.webkit.org/show_bug.cgi?id=24112
3712
3713         * bindings/js/WorkerScriptController.cpp:
3714         * dom/WorkerContext.cpp:
3715
3716 2009-02-23  Antti Koivisto  <antti@apple.com>
3717
3718         Reviewed by Oliver Hunt.
3719
3720         <rdar://problem/6613796> Extended text codecs registered on webview creation
3721
3722         Comparing a text encoding with string "GBK" ended up constructing
3723         TextEncoding("GBK") which in turn initialized all extended
3724         text codecs.
3725
3726         * platform/text/TextCodecICU.cpp:
3727         (WebCore::TextCodecICU::decode):
3728
3729 2009-02-23  Sam Weinig  <sam@webkit.org>
3730
3731         Fix Qt build.
3732
3733         * bridge/qt/qt_runtime.cpp:
3734         (JSC::Bindings::valueRealType):
3735
3736 2009-02-23  Julien Chaffraix  <jchaffraix@webkit.org>
3737
3738         Reviewed by Darin Adler.
3739
3740         Bug 23956: Safari crashes when cloneNode fails (cloning a XML element with an invalid nodeName)
3741
3742         The crash occurred because Document::cloneNode would call Document::createElementNS. Unfortunately
3743         element created with createElement could have a wrong nodeName (createElement sets the string as the
3744         localName without checking for a prefix).
3745
3746         The fix is to call Document::createElement(const QualifiedName&, bool) that will not do any checks on the QualifiedName
3747         and will always succeed.
3748         Also rolled-out the HTMLElement specialisation of clonedNode as it was equivalent to what is done now (added an ASSERT
3749         to ensure that).
3750
3751         Test: fast/dom/cloneNode.html
3752
3753         * dom/Element.cpp:
3754         (WebCore::Element::cloneNode): Call createElement(const QualifiedName&, bool) instead of createElementNS as it will
3755         always return an element.
3756
3757         * html/HTMLElement.cpp:
3758         * html/HTMLElement.h: Removed HTMLElement::clonedNode as it is equivalent to what is now done.
3759
3760 2009-02-23  Dimitri Glazkov  <dglazkov@chromium.org>
3761
3762         Reviewed by Eric Seidel.
3763
3764         https://bugs.webkit.org/show_bug.cgi?id=24109
3765         Upstream V8 Script abstractions, all except ScriptController.
3766
3767         * bindings/v8/ScriptCachedFrameData.h: Added.
3768         (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
3769         (WebCore::ScriptCachedFrameData::~ScriptCachedFrameData):
3770         (WebCore::ScriptCachedFrameData::restore):
3771         (WebCore::ScriptCachedFrameData::clear):
3772         (WebCore::ScriptCachedFrameData::domWindow):
3773         * bindings/v8/ScriptCallFrame.cpp: Added.
3774         (WebCore::ScriptCallFrame::ScriptCallFrame):
3775         (WebCore::ScriptCallFrame::~ScriptCallFrame):
3776         (WebCore::ScriptCallFrame::argumentAt):
3777         * bindings/v8/ScriptCallFrame.h: Added.
3778         (WebCore::ScriptCallFrame::functionName):
3779         (WebCore::ScriptCallFrame::sourceURL):
3780         (WebCore::ScriptCallFrame::lineNumber):
3781         (WebCore::ScriptCallFrame::argumentCount):
3782         * bindings/v8/ScriptCallStack.cpp: Added.
3783         (WebCore::ScriptCallStack::ScriptCallStack):
3784         (WebCore::ScriptCallStack::~ScriptCallStack):
3785         (WebCore::ScriptCallStack::at):
3786         * bindings/v8/ScriptCallStack.h: Added.
3787         (WebCore::ScriptCallStack::size):
3788         * bindings/v8/ScriptInstance.cpp: Added.
3789         (WebCore::V8ScriptInstance::V8ScriptInstance):
3790         (WebCore::V8ScriptInstance::~V8ScriptInstance):
3791         (WebCore::V8ScriptInstance::instance):
3792         (WebCore::V8ScriptInstance::clear):
3793         (WebCore::V8ScriptInstance::set):
3794         * bindings/v8/ScriptInstance.h: Added.
3795         (WebCore::V8ScriptInstance::create):
3796         * bindings/v8/ScriptSourceCode.h: Added.
3797         (WebCore::ScriptSourceCode::ScriptSourceCode):
3798         (WebCore::ScriptSourceCode::isEmpty):
3799         (WebCore::ScriptSourceCode::source):
3800         (WebCore::ScriptSourceCode::url):
3801         (WebCore::ScriptSourceCode::startLine):
3802         * bindings/v8/ScriptState.h: Added.
3803         (WebCore::ScriptState::hadException):
3804         (WebCore::ScriptState::setException):
3805         (WebCore::ScriptState::exception):
3806         * bindings/v8/ScriptString.h: Added.
3807         (WebCore::ScriptString::ScriptString):
3808         (WebCore::ScriptString::operator String):
3809         (WebCore::ScriptString::isNull):
3810         (WebCore::ScriptString::size):
3811         (WebCore::ScriptString::operator=):
3812         (WebCore::ScriptString::operator+=):
3813         * bindings/v8/ScriptValue.cpp: Added.
3814         (WebCore::ScriptValue::getString):
3815         * bindings/v8/ScriptValue.h: Added.
3816         (WebCore::ScriptValue::ScriptValue):
3817         (WebCore::ScriptValue::operator=):
3818         (WebCore::ScriptValue::operator==):
3819         (WebCore::ScriptValue::operator!=):
3820         (WebCore::ScriptValue::isNull):
3821         (WebCore::ScriptValue::isUndefined):
3822         (WebCore::ScriptValue::clear):
3823         (WebCore::ScriptValue::~ScriptValue):
3824         (WebCore::ScriptValue::v8Value):
3825
3826 2009-02-23  Adam Treat  <adam.treat@torchmobile.com>
3827
3828         Reviewed by Timothy Hatcher.
3829
3830         https://bugs.webkit.org/show_bug.cgi?id=24106
3831         The Qt port is crashing on exit because the tear down procedure involves
3832         the WebCore::InspectorController trying to access the JS execution context
3833         for a page that is being deleted.  This patch amends the inspector so
3834         that it does not try and access the execution context of the WebCore::Page
3835         in the midst of deletion.
3836
3837         * inspector/InspectorController.cpp:
3838         (WebCore::InspectorController::inspectedPageDestroyed):
3839         (WebCore::InspectorController::stopUserInitiatedProfiling):
3840
3841 2009-02-23  David Levin  <levin@chromium.org>
3842
3843         Reviewed by Alexey Proskuryakov.
3844
3845         Bug 24088: ThreadableLoaderClient::didFailWillSendRequestCheck isn't wired up completely for workers and could use a better name.
3846         <https://bugs.webkit.org/show_bug.cgi?id=24088>
3847
3848         No observable change in behavior, so no test.
3849
3850         * loader/DocumentThreadableLoader.cpp:
3851         (WebCore::DocumentThreadableLoader::create):
3852         * loader/ThreadableLoaderClient.h:
3853         (WebCore::ThreadableLoaderClient::didFailRedirectCheck):
3854         * loader/ThreadableLoaderClientWrapper.h:
3855         (WebCore::ThreadableLoaderClientWrapper::didFailRedirectCheck):
3856         * loader/WorkerThreadableLoader.cpp:
3857         (WebCore::workerContextDidFailRedirectCheck):
3858         (WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck):
3859         * loader/WorkerThreadableLoader.h:
3860         * xml/XMLHttpRequest.cpp:
3861         (WebCore::XMLHttpRequest::didFinishLoading):
3862         * xml/XMLHttpRequest.h:
3863
3864 2009-02-23  David Levin  <levin@chromium.org>
3865
3866         Reviewed by Alexey Proskuryakov.
3867
3868         Bug 24047: Need to simplify nested if's in WorkerRunLoop::runInMode
3869         <https://bugs.webkit.org/show_bug.cgi?id=24047>
3870
3871         Made a nested if inside of WorkerRunLoop::runInMode a lot simpler by
3872         using only MessageQueue::waitForMessageFilteredWithTimeout instead
3873         of three different MessageQueue methods.
3874
3875         No observable change in behavior, so no test.
3876
3877         * dom/WorkerRunLoop.cpp:
3878         (WebCore::ModePredicate::operator()):
3879         Minor clean-up to able to pass a const ref point for ModePredicate into runInMode.
3880         (WebCore::WorkerRunLoop::runInMode):
3881         * dom/WorkerRunLoop.h:
3882
3883 2009-02-23  David Hyatt  <hyatt@apple.com>
3884
3885         In preparation for making layers for multicol objects (so that they can properly split child layers
3886         into multiple columns), rename all of the "overflowOnly" and "overflowList" members and functions
3887         of RenderLayer to use the term "normal flow" instead.
3888
3889         Reviewed by Cameron Zwarich
3890
3891         * rendering/RenderLayer.cpp:
3892         (WebCore::RenderLayer::RenderLayer):
3893         (WebCore::RenderLayer::~RenderLayer):
3894         (WebCore::RenderLayer::setHasVisibleContent):
3895         (WebCore::RenderLayer::enclosingCompositingLayer):
3896         (WebCore::RenderLayer::addChild):
3897         (WebCore::RenderLayer::removeChild):
3898         (WebCore::RenderLayer::paintLayer):
3899         (WebCore::RenderLayer::hitTestLayer):
3900         (WebCore::RenderLayer::dirtyNormalFlowList):
3901         (WebCore::RenderLayer::updateNormalFlowList):
3902         (WebCore::RenderLayer::collectLayers):
3903         (WebCore::RenderLayer::updateLayerListsIfNeeded):
3904         (WebCore::RenderLayer::shouldBeNormalFlowOnly):
3905         (WebCore::RenderLayer::styleChanged):
3906         * rendering/RenderLayer.h:
3907         (WebCore::RenderLayer::isNormalFlowOnly):
3908         (WebCore::RenderLayer::normalFlowList):
3909         * rendering/RenderTreeAsText.cpp:
3910         (WebCore::writeLayers):
3911
3912 2009-02-23  David Hyatt  <hyatt@apple.com>
3913
3914         Fix the stacking order for column rules in multi-column layout.  Column rules should paint as part of the background of an element, just
3915         after all other components of the background have been painted.  This allows negative z-index children to still paint on top of the
3916         column rules (rather than ending up above the background of the box but behind the column rules).
3917
3918         Reviewed by Eric Seidel
3919
3920         Added fast/multicol/column-rules-stacking.html
3921
3922         * rendering/RenderBlock.cpp:
3923         (WebCore::RenderBlock::paintColumnRules):
3924         (WebCore::RenderBlock::paintColumnContents):
3925         (WebCore::RenderBlock::paintObject):
3926         * rendering/RenderBlock.h:
3927
3928 2009-02-23  Adam Treat  <adam.treat@torchmobile.com>
3929
3930         Reviewed by David Hyatt.
3931
3932         No testcases have been added or modified since this patch should not result in
3933         a behavior change for ports that have layout tests enabled.
3934
3935         Currently, the implementation of GraphicsContext::drawLineForText amongst
3936         the various ports differ in that some of them are honoring the context's
3937         strokeStyle when drawing a text-decoration and some of them are not.
3938         For instance, Apple's Mac port *does not* honor the context's strokeStyle(),
3939         but the Cairo implementation does and has an explicit workaround that
3940         sets the strokeStyle() temporarily.
3941
3942         This patch fixes so that all ports are consistent by explicitly making sure
3943         to set the GraphicsContext strokeStyle to SolidStroke whenever
3944         painting the text-decoration of an InlineFlowBox or InlineTextBox as these
3945         should always use a solid stroke.
3946
3947         This patch addresses these bugs:
3948         https://bugs.webkit.org/show_bug.cgi?id=19364
3949         https://bugs.webkit.org/show_bug.cgi?id=15659
3950
3951         * rendering/InlineFlowBox.cpp:
3952         (WebCore::InlineFlowBox::paintTextDecorations):
3953         * rendering/InlineTextBox.cpp:
3954         (WebCore::InlineTextBox::paintDecoration):
3955
3956 2009-02-23  Scott Violet  <sky@google.com>
3957
3958         Reviewed by Eric Seidel.
3959
3960         https://bugs.webkit.org/show_bug.cgi?id=24098
3961         Bugs in ClipboardChromium
3962
3963         Fixes the following bugs in ClipboardChromium:
3964         * It's possible for the extension to be empty, resulting in a bad file
3965           name, for example, 'foo.' or just '.'.
3966         * We weren't restricting the size of the file to MAX_PATH.
3967         * We weren't removing characters that are invalid for file system names.
3968
3969         * platform/chromium/ClipboardChromium.cpp:
3970         (WebCore::writeImageToDataObject):
3971         * platform/chromium/ClipboardChromium.h:
3972         * platform/chromium/ClipboardChromiumLinux.cpp: Added.
3973         (WebCore::ClipboardChromium::validateFileName):
3974         * platform/chromium/ClipboardChromiumMac.cpp: Added.
3975         (WebCore::ClipboardChromium::validateFileName):
3976         * platform/chromium/ClipboardChromiumWin.cpp: Added.
3977         (WebCore::isInvalidFileCharacter):
3978         (WebCore::ClipboardChromium::validateFileName):
3979
3980 2009-02-23  Thiago Macieira  <thiago.macieira@nokia.com>
3981
3982         Reviewed by Simon Hausmann.
3983
3984         Fix the Copyright notices in a few files
3985
3986         * platform/qt/RenderThemeQt.h:
3987
3988 2009-02-23  Xan Lopez  <xan@gnome.org>
3989
3990         Reviewed by Alexey Proskuryakov.
3991
3992         https://bugs.webkit.org/show_bug.cgi?id=22624
3993         [SOUP][GTK] Need API to get SoupSession from WebKit.
3994
3995         Allow to retrieve the Soup session and modify the code to take
3996         into account users changing features on it.
3997
3998         * platform/network/ResourceHandle.h:
3999         * platform/network/soup/CookieJarSoup.cpp:
4000         (WebCore::defaultCookieJar):
4001         (WebCore::setDefaultCookieJar):
4002         * platform/network/soup/CookieJarSoup.h:
4003         * platform/network/soup/ResourceHandleSoup.cpp:
4004         (WebCore::createSoupSession):
4005         (WebCore::ensureSessionIsInitialized):
4006         (WebCore::ResourceHandle::startHttp):
4007         (WebCore::ResourceHandle::cancel):
4008         (WebCore::ResourceHandle::defaultSession):
4009
4010 2009-02-23  Xan Lopez  <xan@gnome.org>
4011
4012         Reviewed by Alexey Proskuryakov.
4013
4014         https://bugs.webkit.org/show_bug.cgi?id=22624
4015         [SOUP][GTK] Need API to get SoupSession from WebKit.
4016
4017         Remove CURL support.
4018
4019         * GNUmakefile.am:
4020
4021 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
4022
4023         Reviewed by Mark Rowe.
4024
4025         Test: fast/dom/empty-hash-and-search.html
4026
4027         https://bugs.webkit.org/show_bug.cgi?id=21147
4028         hash property returns incorrect value for links w/o hash
4029
4030         Make hash() and search() behavior for empty and missing parts match IE and Firefox.
4031
4032         * platform/KURL.cpp:
4033         (WebCore::KURL::query): Changed to return query without '?', as it is already done for ref().
4034         (WebCore::KURL::prettyURL): Append the query with the question mark.
4035
4036         * page/Location.cpp:
4037         (WebCore::Location::search): Return an empty string if query is empty or missing.
4038         (WebCore::Location::hash): Return an empty string for empty hashes, not only missing ones.
4039
4040         * dom/WorkerLocation.cpp:
4041         (WebCore::WorkerLocation::search):
4042         (WebCore::WorkerLocation::hash):
4043         Match document.location fixes above.
4044
4045         * html/HTMLAnchorElement.cpp:
4046         (WebCore::HTMLAnchorElement::hash):
4047         (WebCore::HTMLAnchorElement::search):
4048         Return an empty string for empty and missing parts.
4049
4050 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
4051
4052         Reviewed by Darin Adler.
4053
4054         https://bugs.webkit.org/show_bug.cgi?id=20184
4055         SELECT with no name generates invalid query string
4056
4057         Test: fast/forms/select-no-name.html
4058
4059         * html/HTMLSelectElement.cpp:
4060         (WebCore::HTMLSelectElement::appendFormData): Added a check for empty name.
4061
4062 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
4063
4064         Apply review comments for the previous check-in (forgot to save the file, oops).
4065
4066         * dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren):
4067
4068 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
4069
4070         Reviewed by Darin Adler.
4071
4072         https://bugs.webkit.org/show_bug.cgi?id=15707
4073         Crash when manipulating document from within an iframe onload function
4074
4075         Test: fast/dom/onload-open.html
4076
4077         * dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren): Protect the container and
4078         the current node, because anything can happen when dispatching events.
4079
4080 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
4081
4082         Reviewed by Darin Adler.
4083
4084         https://bugs.webkit.org/show_bug.cgi?id=18970
4085         Numerically named input fields cause document.forms loop problems
4086
4087         Test: fast/forms/numeric-input-name.html
4088
4089         * bindings/scripts/CodeGeneratorJS.pm: Try index getter before name getter, even if the
4090         latter overrides properties.
4091
4092 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
4093
4094         Reviewed by Sam Weinig.
4095
4096         https://bugs.webkit.org/show_bug.cgi?id=24059
4097         Tokenizer::write() return value is never used
4098
4099         * dom/Tokenizer.h:
4100         * dom/XMLTokenizer.cpp:
4101         (WebCore::XMLTokenizer::write):
4102         * dom/XMLTokenizer.h:
4103         * html/HTMLTokenizer.cpp:
4104         (WebCore::HTMLTokenizer::write):
4105         * html/HTMLTokenizer.h:
4106         * loader/FTPDirectoryDocument.cpp:
4107         (WebCore::FTPDirectoryTokenizer::write):
4108         * loader/ImageDocument.cpp:
4109         (WebCore::ImageTokenizer::write):
4110         * loader/MediaDocument.cpp:
4111         (WebCore::MediaTokenizer::write):
4112         * loader/PluginDocument.cpp:
4113         (WebCore::PluginTokenizer::write):
4114         * loader/TextDocument.cpp:
4115         (WebCore::TextTokenizer::write):
4116         Made write() return void, not bool.
4117
4118 2009-02-20  Geoffrey Garen  <ggaren@apple.com>
4119
4120         Reviewed by Sam Weinig.
4121
4122         Updated for JavaScriptCore changes to timeout checking.
4123
4124         * bindings/js/JSCustomPositionCallback.cpp:
4125         (WebCore::JSCustomPositionCallback::handleEvent):
4126         * bindings/js/JSCustomPositionErrorCallback.cpp:
4127         (WebCore::JSCustomPositionErrorCallback::handleEvent):
4128         * bindings/js/JSCustomSQLStatementCallback.cpp:
4129         (WebCore::JSCustomSQLStatementCallback::handleEvent):
4130         * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
4131         (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
4132         * bindings/js/JSCustomSQLTransactionCallback.cpp:
4133         (WebCore::JSCustomSQLTransactionCallback::handleEvent):
4134         * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
4135         (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
4136         * bindings/js/JSCustomVoidCallback.cpp:
4137         (WebCore::JSCustomVoidCallback::handleEvent):
4138         * bindings/js/JSCustomXPathNSResolver.cpp:
4139         (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
4140         * bindings/js/JSDOMWindowBase.cpp:
4141         (WebCore::JSDOMWindowBase::JSDOMWindowBase):
4142         (WebCore::JSDOMWindowBase::commonJSGlobalData):
4143         * bindings/js/JSEventListener.cpp:
4144         (WebCore::JSAbstractEventListener::handleEvent):
4145         * bindings/js/ScheduledAction.cpp:
4146         (WebCore::ScheduledAction::executeFunctionInContext):
4147         * bindings/js/ScriptController.cpp:
4148         (WebCore::ScriptController::evaluate):
4149         * bindings/js/WorkerScriptController.cpp:
4150         (WebCore::WorkerScriptController::evaluate):
4151         (WebCore::WorkerScriptController::forbidExecution):
4152         * bindings/objc/WebScriptObject.mm:
4153         (-[WebScriptObject callWebScriptMethod:withArguments:]):
4154         (-[WebScriptObject evaluateWebScript:]):
4155         * bridge/NP_jsobject.cpp:
4156         (_NPN_InvokeDefault):
4157         (_NPN_Invoke):
4158         (_NPN_Evaluate):
4159         (_NPN_Construct):
4160         * bridge/jni/jni_jsobject.mm:
4161         (JavaJSObject::call):
4162         (JavaJSObject::eval):
4163
4164 2009-02-21  Hironori Bono  <hbono@chromium.org>
4165
4166         Reviewed by Alexey Proskuryakov.
4167
4168         https://bugs.webkit.org/show_bug.cgi?id=23786
4169         [Chromium] line-break characters in a complex text are treated as zero-width spaces
4170
4171         This change prevents the UniscribeHelper class from treating the line-break characters
4172         as whitespaces.
4173
4174         Tests: fast/text/international/bidi-linebreak-001.html
4175                fast/text/international/bidi-linebreak-002.html
4176                fast/text/international/bidi-linebreak-003.html
4177
4178         * platform/graphics/chromium/UniscribeHelper.cpp:
4179         (WebCore::UniscribeHelper::adjustSpaceAdvances):
4180         Make the UniscribeHelper::adjustSpaceAdvances() function treat all characters in
4181         the treatAsSpace() function (e.g. U+0020, U+000A, U+000D, U+00A0) as whitespaces,
4182         so does when Chromium renders a simple text.
4183
4184 2009-02-20  Julien Chaffraix  <jchaffraix@webkit.org>
4185
4186         Reviewed by Alexey Proskuryakov.
4187
4188         Bug 23940: Use Document::createElement(const QualifiedName&, bool) when creating a known element inside WebCore
4189
4190         Document::createElement(const QualifiedName&, bool) does not check for the prefix as opposed the the one taking an AtomicString
4191         or Document::createElementNS. This is perfectly fine internally because we know the type of element created and the check is
4192         unneeded.
4193
4194         It also removes the use of an ExceptionCode argument which was here only to check that the prefix check was fine. Finally it
4195         enables us to use some generated QualifiedName.
4196
4197         * bindings/js/JSOptionConstructor.cpp:
4198         (WebCore::constructHTMLOptionElement):
4199         * dom/Document.cpp:
4200         (WebCore::Document::setTitle):
4201         * dom/XMLTokenizer.cpp:
4202         (WebCore::createXHTMLParserErrorHeader):
4203         (WebCore::XMLTokenizer::insertErrorMessageBlock):
4204         * editing/CompositeEditCommand.cpp:
4205         (WebCore::createBlockPlaceholderElement):
4206         * editing/htmlediting.cpp:
4207         (WebCore::createTabSpanElement):
4208         * html/HTMLSelectElement.cpp:
4209         (WebCore::HTMLSelectElement::setLength):
4210         * loader/FTPDirectoryDocument.cpp:
4211         (WebCore::FTPDirectoryTokenizer::appendEntry):
4212         (WebCore::FTPDirectoryTokenizer::createTDForFilename):
4213         (WebCore::FTPDirectoryTokenizer::loadDocumentTemplate):
4214         (WebCore::FTPDirectoryTokenizer::createBasicDocument):
4215         * loader/ImageDocument.cpp:
4216         (WebCore::ImageDocument::createDocumentStructure):
4217         * loader/MediaDocument.cpp:
4218         (WebCore::MediaTokenizer::createDocumentStructure):
4219         * loader/PluginDocument.cpp:
4220         (WebCore::PluginTokenizer::createDocumentStructure):
4221         * loader/TextDocument.cpp:
4222         (WebCore::TextTokenizer::write):
4223         * page/Frame.cpp:
4224         (WebCore::Frame::selectionComputedStyle):
4225         (WebCore::Frame::styleForSelectionStart):
4226         Document::createElement(const AtomicString&, ...) to Document::createElement(const QualifiedName&, ...) switch.
4227
4228         * xml/XPathFunctions.cpp:
4229         (WebCore::XPath::FunLang::evaluate): Re-use langAttr instead of creating a new attribute.
4230         * page/DragController.cpp:
4231         (WebCore::documentFragmentFromDragData): Use the HTMLAnchorElement directly to get rid of the static cast.
4232
4233 2009-02-19  Dimitri Glazkov  <dglazkov@chromium.org>
4234
4235         Reviewed by Eric Seidel.
4236
4237         https://bugs.webkit.org/show_bug.cgi?id=24060
4238         Fix up to accommodate for CanvasPixelArray return.
4239
4240         * platform/graphics/skia/ImageBufferSkia.cpp:
4241         (WebCore::ImageBuffer::getImageData): Added an extra data() to call.
4242         (WebCore::ImageBuffer::putImageData): Ditto.
4243
4244 2009-02-20  Eric Carlson  <eric.carlson@apple.com>
4245
4246         Simon Fraser
4247
4248         https://bugs.webkit.org/show_bug.cgi?id=24042
4249         Bug 24042: MediaPlayer should cache plug-in proxy
4250
4251         The changes in https://bugs.webkit.org/show_bug.cgi?id=23917 assume that
4252         MediaPlayer will always have created the private media player object before
4253         the plug-in is instantiated and calls back with the proxy object. This is not
4254         true on all platforms because of threading latency, so MediaPlayer should
4255         cache the plug-in proxy so it can pass it to the media engine at a later time.
4256
4257         * platform/graphics/MediaPlayer.cpp:
4258         (WebCore::NullMediaPlayerPrivate::setPoster): Null media engine implementation of proxy methods.
4259         (WebCore::NullMediaPlayerPrivate::deliverNotification): Ditto.
4260         (WebCore::NullMediaPlayerPrivate::setMediaPlayerProxy): Ditto.
4261         (WebCore::MediaPlayer::MediaPlayer): Initialize m_playerProxy.
4262         (WebCore::MediaPlayer::load): Pass m_playerProxy to newly created engine.
4263  &