Fixing a typo.
[WebKit-https.git] / WebCore / ChangeLog
1 2009-10-19  Dumitru Daniliuc  <dumi@chromium.org>
2
3         Reviewed by Darin Adler.
4
5         Fixing a typo.
6
7         https://bugs.webkit.org/show_bug.cgi?id=30543
8
9         * platform/sql/SQLiteDatabase.h:
10
11 2009-10-19  Dmitry Titov  <dimich@chromium.org>
12
13         Reviewed by Darin Adler.
14
15         Manual Test for crash caused by JS accessing DOMWindow which is disconnected from the Frame.
16         https://bugs.webkit.org/show_bug.cgi?id=30544
17
18         * manual-tests/crash-on-accessing-domwindow-without-frame.html: Added.
19
20 2009-10-19  Simon Fraser  <simon.fraser@apple.com>
21
22         Reviewed by Darin Adler.
23
24         Flash at end of opacity/transform transition sometimes
25         https://bugs.webkit.org/show_bug.cgi?id=30501
26         
27         When a transition finishes, there window of time between when the animation is
28         removed, and the final style set on the GraphicsLayer. This caused the layer to revert
29         to its old appearance for one or two frames. To avoid this, we set the final
30         transform or opacity at the start of the transition; we know that the animation
31         will override the final value for as long as its running.
32         
33         No test because this is a very transient effect that can't be captured
34         in a test.
35
36         * rendering/RenderLayerBacking.cpp:
37         (WebCore::RenderLayerBacking::createGraphicsLayer):
38         (WebCore::RenderLayerBacking::updateLayerOpacity):
39         (WebCore::RenderLayerBacking::updateLayerTransform):
40         (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
41         (WebCore::RenderLayerBacking::startTransition):
42         * rendering/RenderLayerBacking.h:
43
44 2009-10-19  Pavel Feldman  <pfeldman@chromium.org>
45
46         Reviewed by Timothy Hatcher.
47
48         Web Inspector: Add more stop characters into console completions.
49
50         https://bugs.webkit.org/show_bug.cgi?id=30477
51
52         * inspector/front-end/ConsoleView.js:
53         (WebInspector.ConsoleView.prototype.completions):
54         (WebInspector.ConsoleView.prototype._reportCompletions):
55
56 2009-10-19  Marshall Culpepper  <mculpepper@appcelerator.com>
57
58         Reviewed by Adam Roben.
59
60         implemented ClipboardWin::files()
61         https://bugs.webkit.org/show_bug.cgi?id=29666
62
63         * platform/win/ClipboardWin.cpp:
64         (WebCore::ClipboardWin::files):
65
66 2009-10-19  Nate Chapin  <japhet@chromium.org>
67
68         Reviewed by Alexey Proskuryakov.
69
70         Add support for link relations in HTMLAnchorElement and implement rel="noreferrer".
71
72         https://bugs.webkit.org/show_bug.cgi?id=28986
73
74         Tests: http/tests/navigation/no-referrer-reset.html
75                http/tests/navigation/no-referrer-same-window.html
76                http/tests/navigation/no-referrer-subframe.html
77                http/tests/navigation/no-referrer-target-blank.html
78
79         * WebCore.base.exp: Update FrameLoader::loadFrameRequest export symbol
80         * html/HTMLAnchorElement.cpp: Add support for link relations and implement noreferrer
81         (WebCore::HTMLAnchorElement::HTMLAnchorElement):
82         (WebCore::HTMLAnchorElement::defaultEventHandler):
83         (WebCore::HTMLAnchorElement::parseMappedAttribute):
84         (WebCore::HTMLAnchorElement::hasRel):
85         (WebCore::HTMLAnchorElement::setRel):
86         * html/HTMLAnchorElement.h: Add support for link relations and implement noreferrer
87         * loader/FrameLoader.cpp:
88         (WebCore::FrameLoader::FrameLoader):
89         (WebCore::FrameLoader::createWindow):
90         (WebCore::FrameLoader::changeLocation):
91         (WebCore::FrameLoader::urlSelected): Add parameter for referrer policy
92         (WebCore::FrameLoader::loadFrameRequest): Add parameter for referrer policy
93         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): Suppress opener if requested by ReferrerPolicy
94         * loader/FrameLoader.h: Update urlSelected and loadFrameRequest prototypes
95         * loader/FrameLoaderTypes.h: Add enum for referrer policy
96         * loader/RedirectScheduler.cpp:
97         (WebCore::RedirectScheduler::timerFired):
98         * page/ContextMenuController.cpp:
99         (WebCore::ContextMenuController::contextMenuItemSelected): Update call to urlSelected()
100         * svg/SVGAElement.cpp:
101         (WebCore::SVGAElement::defaultEventHandler): Update call to urlSelected()
102
103
104 2009-10-19  Alpha Lam  <hclam@chromium.org>
105
106         Reviewed by Dimitri Glazkov (dglazkov@chromium.org).
107
108         [v8] typeof(HTMLMediaElement) should return undefined if media
109         engine is not available
110         https://bugs.webkit.org/show_bug.cgi?id=30343
111
112         Check for availability of the media engine to disable
113         HTMLMediaElement, HTMLAudioElement, HTMLVideoElement, MediaError
114         in runtime.
115
116         Try runs and review in Chromium:
117         http://codereview.chromium.org/276011
118
119         Test: manual-tests/chromium/media-player-not-available.html
120
121         The above test can work work in Chromium. Testing procedures:
122         1. Remove all media support libraries in Chromium (e.g. ffmpeg libraries)
123         2. Open Chromium with above test page
124         3. Verify the test results according to the test page
125
126         * bindings/v8/custom/V8CustomBinding.h:
127         Declare enabler methods.
128         * bindings/v8/custom/V8DOMWindowCustom.cpp:
129         Report enabled only if media player is available.
130         * manual-tests/chromium/media-player-not-available.html: Added.
131         Manual test, following instruction in this test for procedures.
132         * page/DOMWindow.idl:
133         Mark HTMLMediaElement, HTMLAudioElement, HTMLVideElement, MediaError
134         as enabled at runtime.
135
136 2009-10-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
137
138         Reviewed by David Hyatt.
139
140         Refactor out some of the code in paint() into paintPanScrollIcon()
141         and paintScrollbars() in preparation of some Qt API changes.
142
143         * platform/ScrollView.cpp:
144         (WebCore::ScrollView::paint):
145         * platform/ScrollView.h:
146
147 2009-10-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
148
149         Reviewed by Adam Roben.
150
151         Make the local static panScrollIcon into a Image* instead
152         of a RefPtr<Image>.
153
154         * platform/ScrollView.cpp:
155         (WebCore::ScrollView::wheelEvent):
156
157 2009-10-19  Andrew Scherkus  <scherkus@chromium.org>
158
159         Reviewed by David Levin.
160
161         Forcefully set antialiasing for Chromium media controls.
162
163         https://bugs.webkit.org/show_bug.cgi?id=30521
164
165         Before it was nondeterministiacally being enabled based on the previous state of GraphicsContext.
166
167         Covered by existing layout tests.
168
169         * rendering/RenderMediaControlsChromium.cpp:
170         (WebCore::paintMediaSlider): Added setShouldAntialias(true).
171
172 2009-10-19  Jens Alfke  <jens@mooseyard.com>
173
174         Reviewed by Darin Adler.
175
176         Optimize string upper/lowercasing
177         https://bugs.webkit.org/show_bug.cgi?id=30261
178         
179         - Added AtomicString::upper() and lower()
180         - Further optimized StringImpl::lower()
181         - Removed StringImpl::isLower()
182         - Added QualifiedName::localNameUpper(), which is cached, thereby saving
183           thousands of upper() calls and string allocations.
184  
185          * dom/Element.cpp:
186          (WebCore::Element::setAttribute): Call AtomicString::lower()
187          * dom/QualifiedName.cpp:
188          (WebCore::QualifiedName::localNameUpper): New method
189          * dom/QualifiedName.h: Added localNameUpper() method
190          * dom/StyledElement.cpp:
191          (WebCore::StyledElement::parseMappedAttribute):  Call AtomicString::lower()
192          * html/HTMLDocument.cpp:
193          (WebCore::HTMLDocument::createElement): Call AtomicString::lower()
194          * html/HTMLElement.cpp:
195          (WebCore::HTMLElement::nodeName): Call localNameUpper()
196          * platform/text/AtomicString.cpp:
197          (WebCore::AtomicString::lower): New method
198          (WebCore::AtomicString::upper): New method
199          * platform/text/AtomicString.h: Added lower() and upper()
200          * platform/text/StringImpl.cpp: Removed isLower()
201          (WebCore::StringImpl::lower): Further optimization of initial loop
202          * platform/text/StringImpl.h: Removed isLower()
203  
204 2009-10-19  Nate Chapin  <japhet@chromium.org>
205
206         Reviewed by Adam Barth.
207
208         If a call to a plugin's invokeMethod, invokeDefault or construct
209         returns false, throw an exception into JS.        
210
211         https://bugs.webkit.org/show_bug.cgi?id=30239
212
213         Test: plugins/netscape-invoke-failure.html
214
215         * bindings/v8/V8NPObject.cpp: Check return values of invokeMethod, invokeDefault and construct.
216         (npObjectInvokeImpl):
217         * bridge/c/c_instance.cpp:
218         (JSC::Bindings::CInstance::invokeMethod): Check return value
219         (JSC::Bindings::CInstance::invokeDefaultMethod): Check return value
220         (JSC::Bindings::CInstance::invokeConstruct): Check return value
221
222 2009-10-16  Stephen White  <senorblanco@chromium.org>
223
224         Reviewed by Adam Barth.
225
226         Fix for chromium/skia canvas arc start/end positions, when the arc is
227         >= 360 degrees.
228         https://bugs.webkit.org/show_bug.cgi?id=30449
229
230         Covered by new test:
231         LayoutTests/fast/canvas/arc360.html
232
233         * platform/graphics/skia/PathSkia.cpp:
234         (WebCore::Path::addArc):
235
236 2009-10-19  Kent Tamura  <tkent@chromium.org>
237
238         Reviewed by Alexey Proskuryakov.
239
240         Fix uninitialized variable reference in Element::removeAttribute().
241         https://bugs.webkit.org/show_bug.cgi?id=30502
242
243         * dom/Element.cpp:
244         (WebCore::Element::removeAttribute):
245
246 2009-10-19  Eric Carlson  <eric.carlson@apple.com>
247
248         Reviewed by Simon Fraser.
249
250         https://bugs.webkit.org/show_bug.cgi?id=30463
251         Remove HTML5 media element 'loadend' event
252
253         * dom/EventNames.h:
254         * html/HTMLMediaElement.cpp:
255         (WebCore::HTMLMediaElement::parseMappedAttribute): Remove 'loadend'.
256         (WebCore::HTMLMediaElement::loadInternal): Ditto.
257         (WebCore::HTMLMediaElement::noneSupported): Ditto.
258         (WebCore::HTMLMediaElement::mediaEngineError): Ditto.
259         (WebCore::HTMLMediaElement::setNetworkState): Ditto.
260         (WebCore::HTMLMediaElement::userCancelledLoad): Ditto.
261
262 2009-10-19  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
263
264         Reviewed by Adam Barth.
265
266         [Qt] Remove deletion of outgoing FormData object when reply is finished.
267         The buffers will be destroyed a bit later, when the QNetworkReply is deleted.
268         Bug: https://bugs.webkit.org/show_bug.cgi?id=29551
269
270         * platform/network/qt/QNetworkReplyHandler.cpp:
271         * platform/network/qt/QNetworkReplyHandler.h:
272
273 2009-10-19  Dimitri Glazkov  <dglazkov@chromium.org>
274
275         Reviewed by Darin Adler.
276
277         Fix hard-to-reproduce crash in HTMLTokenizer by avoiding a rare
278         fastRealloc edge case.
279         https://bugs.webkit.org/show_bug.cgi?id=29313
280
281         No test, the crash shows up occasionally in crash dumps, we weren't able
282         to reproduce it locally.
283
284         * html/HTMLTokenizer.cpp:
285         (WebCore::HTMLTokenizer::enlargeScriptBuffer): Added an early exit to
286             avoid calling fastRealloc with the size of 0.
287
288 2009-10-19  Andrew Scherkus  <scherkus@chromium.org>
289
290         Reviewed by Eric Seidel.
291
292         Use fillRect() instead of drawRect() to fix Chromium media controls rendering.
293
294         https://bugs.webkit.org/show_bug.cgi?id=30371
295
296         Chromium Mac layout tests will need to be rebaselined.  Existing layout tests for Linux/Win still pass.
297
298         * rendering/RenderMediaControlsChromium.cpp:
299         (WebCore::paintMediaSlider): Use fillRect() instead of drawRect().
300
301 2009-10-19  Dmitry Titov  <dimich@chromium.org>
302
303         Reviewed by Adam Barth.
304
305         Crash in DOMWindow::clearTimeout etc when DOMWindow is not connected to a frame.
306         https://bugs.webkit.org/show_bug.cgi?id=29832
307
308         Need to make sure the script caches are reset when frame gets disconnected from still-alive DOMWindow.
309         This will prevent JS from calling DOMWindow methods that can not be completed w/o the frame.
310
311         I am not sure it's possible to test this since the only file that repros the problem need ~10 seconds to cause crash.
312
313         * page/Frame.cpp:
314         (WebCore::Frame::~Frame): Right after frame disconnects from DOMWindow, clear WindowShell.
315
316 2009-10-19  Csaba Osztrogonác  <ossy@webkit.org>
317
318         Unreviewed build warning fix.
319         [Qt] Apply changes to WebCore.pro introduced in r49778
320
321         * WebCore.pro: Removed svg/graphics/filters/SVGFEGaussianBlur.h from HEADERS
322
323 2009-10-19  Dirk Schulze  <krit@webkit.org>
324
325         Reviewed by Darin Adler.
326
327         Move feGaussianBlur from WebCore/svg to WebCore/platform
328         [https://bugs.webkit.org/show_bug.cgi?id=30495]
329
330         This patch moves SVGFRGaussianBlur from svg/graphics/filters
331         to platform/graphics/filters/FEGaussianBlur. This is needed
332         for shadow support on Qt and Cairo.
333         No change in functionality, therfore no new test case needed.
334
335         * GNUmakefile.am:
336         * WebCore.gypi:
337         * WebCore.pro:
338         * WebCore.vcproj/WebCore.vcproj:
339         * WebCore.xcodeproj/project.pbxproj:
340         * platform/graphics/filters/FEGaussianBlur.cpp: Added.
341         * platform/graphics/filters/FEGaussianBlur.h: Added.
342         * svg/SVGFEGaussianBlurElement.h:
343         * svg/graphics/filters/SVGFEGaussianBlur.cpp: Removed.
344         * svg/graphics/filters/SVGFEGaussianBlur.h: Removed.
345
346 2009-10-19  Yael Aharon  <yael.aharon@nokia.com>
347
348         Unreviewed.
349
350         Added reviewer name to r49574.
351
352 2009-10-19  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
353
354         Reviewed by Xan Lopez.
355
356         https://bugs.webkit.org/show_bug.cgi?id=30489
357         [Gtk] The document frame/html container claims to be parentless
358
359         Work around for the parentless claim made by the accessible associated
360         with the embedded WebView. When we identify this condition, get the
361         widget's parent, and then get the AtkObject from that. Admittedly an ugly
362         hack, but we'll need it for Yelp and other Gtk+/GNOME applications which
363         plan to switch over to WebKit.
364
365         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
366         (webkit_accessible_get_parent):
367
368 2009-10-19  Benjamin Otte  <otte@gnome.org>
369
370         Reviewed by Jan Alonzo.
371
372         Handle duration queries properly
373         https://bugs.webkit.org/show_bug.cgi?id=29999
374
375         Previously duration queries failed to handle unknown duration
376         and didn't treat the returned duration as an unsigned.
377
378         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
379         (WebCore::MediaPlayerPrivate::duration):
380
381 2009-10-19  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
382
383         Reviewed by Tor Arne Vestbø.
384
385         [Qt] Fix build on Windows.
386
387         * plugins/win/PluginViewWin.cpp:
388         (windowHandleForPageClient):
389
390 2009-10-19  Girish Ramakrishnan  <girish@forwardbias.in>
391
392         Reviewed by Holger Freyther.
393
394         [Qt] Windowed Plugins: Don't crash when client is 0.
395         
396         Client is 0 when we use QWebPage without a QWebView or QGraphicsWebView.
397         In addition, setFrameRect()/updatePluginWidget() is called even if the
398         plugin was not succesfully loaded. updatePluginWidget() updates the
399         window rect which is, in theory, useful to draw something that indicates
400         that we didn't load successfully.
401         
402         So, a status check is added to setNPWindowIfNeeded.
403
404         https://bugs.webkit.org/show_bug.cgi?id=30380
405
406         * plugins/qt/PluginViewQt.cpp:
407         (WebCore::PluginView::setNPWindowIfNeeded):
408         (WebCore::PluginView::platformStart):
409
410 2009-10-19  Girish Ramakrishnan  <girish@forwardbias.in>
411
412         Reviewed by Holger Freyther.
413
414         [Qt] Windowed Plugins: Fix crash when QWebPage is deleted after QWebView.
415         
416         Fixes various sources of crashes:
417         1. The PluginContainer is a child of QWebView. When the view gets deleted,
418         the PluginView is not notified about the deletion of PluginContainer.
419         2. QWebView destructor does not set client to 0.
420         3. Sometimes pending paint events are sent after the plugin has died, so add
421         a check in PluginView::setNPWindowIfNeeded.
422
423         https://bugs.webkit.org/show_bug.cgi?id=30354
424
425         * plugins/qt/PluginContainerQt.cpp:
426         (PluginContainerQt::~PluginContainerQt):
427         * plugins/qt/PluginViewQt.cpp:
428         (WebCore::PluginView::setNPWindowIfNeeded):
429
430 2009-10-19  Jakob Truelsen  <antialize@gmail.com>
431
432         Reviewed by Adam Barth.
433
434         https://bugs.webkit.org/show_bug.cgi?id=29042
435         Allow one to customize the minimal and maximal shrink factors used when printing.
436
437         * page/PrintContext.cpp:
438         (WebCore::PrintContext::begin):
439         * page/Settings.cpp:
440         (WebCore::Settings::Settings):
441         (WebCore::Settings::setPrintingMinimumShrinkFactor):
442         (WebCore::Settings::setPrintingMaximumShrinkFactor):
443         * page/Settings.h:
444         (WebCore::Settings::printingMinimumShrinkFactor):
445         (WebCore::Settings::printingMaximumShrinkFactor):
446
447 2009-10-18  Erik Arvidsson  <arv@chromium.org>
448
449         Reviewed by Adam Barth.
450
451         Fixes issue where doubleclicking a word could select following adjacent newlines.
452         https://bugs.webkit.org/show_bug.cgi?id=30234
453
454         Tests: platform/mac/editing/selection/doubleclick-should-not-expand-across-lines.html
455                platform/mac/editing/selection/script-tests/TEMPLATE.html
456                platform/win/editing/selection/doubleclick-should-not-expand-across-lines.html
457                platform/win/editing/selection/script-tests/TEMPLATE.html
458
459         * editing/VisibleSelection.cpp:
460         (WebCore::VisibleSelection::appendTrailingWhitespace):
461
462 2009-10-18  Kevin Ollivier  <kevino@theolliviers.com>
463
464         CURL build fix, use proper header name.
465
466         * platform/network/curl/ResourceHandleManager.h:
467
468 2009-10-18  Pavel Feldman  <pfeldman@chromium.org>
469
470         Reviewed by Timothy Hatcher.
471
472         Web Inspector: Properties on Arrays and NodeLists are not logged correctly.
473
474         https://bugs.webkit.org/show_bug.cgi?id=30485
475
476         * inspector/front-end/ConsoleView.js:
477         (WebInspector.ConsoleView.prototype._formatarray):
478         (WebInspector.ConsoleView.prototype._printArray):
479
480 2009-10-18  Pavel Feldman  <pfeldman@chromium.org>
481
482         Not reviewed: touching WebCore so that it
483         initiated inspector frontend deployment on Windows.
484
485         Web Inspector: frontend files are not deployed in Windows
486         incremental build.
487
488         * inspector/InspectorDOMAgent.cpp:
489         (WebCore::InspectorDOMAgent::unbind):
490
491 2009-10-18  Pavel Feldman  <pfeldman@chromium.org>
492
493         Reviewed by Timothy Hatcher.
494
495         Web Inspector: Title of dir(["test", "test2"]) should be Array
496
497         https://bugs.webkit.org/show_bug.cgi?id=30486
498
499         Test: inspector/console-tests.html
500
501         * inspector/front-end/InjectedScript.js:
502
503 2009-10-18  Dirk Schulze  <krit@webkit.org>
504
505         Reviewed by Nikolas Zimmermann.
506
507         REGRESSION: SVG Mask doesn't work for maskContentUnits="objectBoundingBox"
508         [https://bugs.webkit.org/show_bug.cgi?id=30480]
509
510         Patch for SVGMaskElement landed in r49598 should correct the location of
511         the mask image graphics context. It only corrects the location for userSpaceOnUse
512         mode in maskContentUnits but breaks objectBoundingBoxMode.
513         The maskDestRect shouldn't be moved. It is not responsible for the correct context
514         postioin but for the correct position of the mask image.
515         This patch calculates the context postion independently from the maskDestRect.
516         It also uses lineareRGB color space for masking on CG now. This is the default
517         color space for masking operations.
518         We already have tests for both maskContentUnits modes.
519
520             *svg/W3C-SVG-1.1/masking-intro-01-f.svg
521             *svg/custom/mask-with-default-value.svg
522
523         Some tests needed new pixel tests because of the new color space.
524
525         * svg/SVGMaskElement.cpp:
526         (WebCore::SVGMaskElement::drawMaskerContent):
527
528 2009-10-18  Anton Muhin  <antonm@chromium.org>
529
530         Reviewed by Adam Barth.
531
532         Use v8::Integer::NewFromUnsigned when converting unsigneds into V8's numbers.
533         That is notably faster for small numbers (most common case).
534         https://bugs.webkit.org/show_bug.cgi?id=30493
535
536         * bindings/scripts/CodeGeneratorV8.pm:
537
538 2009-10-18  Jan Michael Alonzo  <jmalonzo@webkit.org>
539
540         Reviewed by Holger Freyther.
541
542         [GTK] Add MathML to the build system
543         https://bugs.webkit.org/show_bug.cgi?id=30487
544
545         Add MathML sources if MathML support is enabled.
546
547         * GNUmakefile.am:
548
549 2009-10-18  Kevin Ollivier  <kevino@theolliviers.com>
550
551         Non-PCH build fix. Added missing header.
552
553         * bridge/runtime_root.h:
554
555 2009-10-18  Simon Fraser  <simon.fraser@apple.com>
556
557         Reviewed by Dan Bernstein.
558
559         Compositing layers not correctly updated after partial layout
560         https://bugs.webkit.org/show_bug.cgi?id=30425
561         
562         When a partial layout happened, for example as the result of a postion-change-only
563         layout, then some compositing layer positions were not correctly updated. To fix
564         this, updateLayerPositions() now carries along a flag that is set at the rootmost
565         layer being updated, and used to determine when we hit the first compositing layer
566         in this update. RenderLayerBacking::updateAfterLayout() makes use of this information
567         to do a full geometry update on that layer, which is thus the rootmost compositing
568         layer that is being updated.
569
570         Test: compositing/geometry/partial-layout-update.html
571
572         * page/FrameView.cpp:
573         (WebCore::FrameView::layout):
574         * rendering/RenderLayer.cpp:
575         (WebCore::RenderLayer::updateLayerPositions):
576         (WebCore::RenderLayer::scrollToOffset):
577         * rendering/RenderLayer.h:
578         (WebCore::RenderLayer::):
579         * rendering/RenderLayerBacking.cpp:
580         (WebCore::RenderLayerBacking::updateAfterLayout):
581         * rendering/RenderLayerBacking.h:
582
583 2009-09-13  Kevin Watters  <kevinwatters@gmail.com>
584
585         Reviewed by Kevin Ollivier.
586
587         Add support for proxies in CURL.
588  
589         https://bugs.webkit.org/show_bug.cgi?id=30446
590
591         * platform/network/curl/ResourceHandleManager.cpp:
592         (WebCore::ResourceHandleManager::setProxyInfo):
593         (WebCore::ResourceHandleManager::initializeHandle):
594         * platform/network/curl/ResourceHandleManager.h:
595         (WebCore::ResourceHandleManager::):
596
597 2009-10-18  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
598
599         Reviewed by Xan Lopez
600
601         https://bugs.webkit.org/show_bug.cgi?id=25901
602         Use ATK_ROLE_SECTION for divTag and ATK_ROLE_LABEL for labelTag
603
604         Replaces the use of ATK_ROLE_PANEL with the expected accessible roles.
605
606         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
607         (webkit_accessible_get_role):
608
609 2009-10-17  Nikolas Zimmermann  <nzimmermann@rim.com>
610
611         Reviewed by George Staikos.
612
613         Cleanup SVGElement code, preparing for animVal support
614         https://bugs.webkit.org/show_bug.cgi?id=30466
615
616         Add new SynchronizablePropertyController and move the code for SVG property <-> XML attribute synchronization
617         from SVGElement. This is a further preparation for animVal support, where SynchronizablePropertyController will
618         be used to control the start/end state of an animated property.
619
620         We're currently tracking animated properties that need synchronization, generalize this concept and use
621         it to track their creation (bound to certain SVG*Element classes) as well as a flag determing the need
622         of synchronization (no SVG DOM object wrappers, no synchronization needed).
623
624         No change in functionality, thus no tests.
625
626         * GNUmakefile.am: Add 'SynchronizablePropertyController.cpp/h' to build
627         * WebCore.gypi: Ditto.
628         * WebCore.pro: Ditto.
629         * WebCore.vcproj/WebCore.vcproj: Ditto.
630         * WebCore.xcodeproj/project.pbxproj: Ditto.
631         * svg/SVGAllInOne.cpp: Ditto.
632         * svg/SVGAnimatedProperty.h: Add registerProperty() function 
633         (WebCore::::SVGAnimatedProperty): Call registerProperty() function  
634         (WebCore::::registerProperty): Add new registerProperty() function, announcing new properties to SynchronizablePropertyController.
635         * svg/SVGAnimatedTemplate.h: Use propertyController() method, to access the new functions moved from SVGElement.
636         (WebCore::lookupOrCreateWrapper):
637         * svg/SVGElement.cpp: Adapt to code moving to SynchronizablePropertyController.
638         (WebCore::SVGElement::updateAnimatedSVGAttribute):
639         * svg/SVGElement.h: Move handling SVG property synchronization to SynchronizablePropertyController.
640         (WebCore::SVGElement::propertyController): Expose reference to SynchronizablePropertyController object.
641         * svg/SVGViewSpec.cpp: Reorder initialization order of contextElement, leading to possible crashes.
642         (WebCore::SVGViewSpec::SVGViewSpec):
643         (WebCore::SVGViewSpec::viewTarget):
644         * svg/SVGViewSpec.h: Ditto.
645         (WebCore::SVGViewSpec::contextElement):
646         * svg/SynchronizablePropertyController.cpp: Added.
647         (WebCore::SynchronizablePropertyController::SynchronizablePropertyController):
648         (WebCore::SynchronizablePropertyController::registerProperty):
649         (WebCore::SynchronizablePropertyController::setPropertyNeedsSynchronization):
650         (WebCore::SynchronizablePropertyController::synchronizeProperty):
651         (WebCore::SynchronizablePropertyController::synchronizeAllProperties):
652         (WebCore::SynchronizablePropertyController::startAnimation):
653         (WebCore::SynchronizablePropertyController::stopAnimation):
654         * svg/SynchronizablePropertyController.h: Added.
655         (WebCore::SynchronizableProperty::SynchronizableProperty):
656         (WebCore::SynchronizableProperty::isHashTableDeletedValue):
657         (WebCore::SynchronizableProperty::operator==):
658         (WebCore::SynchronizablePropertyHash::hash):
659         (WebCore::SynchronizablePropertyHash::equal):
660         (WebCore::SynchronizablePropertyHashTraits::constructDeletedValue):
661         (WebCore::SynchronizablePropertyHashTraits::isDeletedValue):
662
663 2009-10-17  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
664
665         Reviewed by Xan Lopez.
666
667         https://bugs.webkit.org/show_bug.cgi?id=25413
668         [GTK] Please expose the level of headings
669
670         Exposes the heading level as an attribute of the AtkObject.
671
672         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
673         (addAttributeToSet):
674         (webkit_accessible_get_attributes):
675         (webkit_accessible_class_init):
676
677 2009-10-17  Kwang Yul Seo  <skyul@company100.net>
678
679         Reviewed by Eric Seidel.
680
681         EventHandler::eventLoopHandleMouseDragged needs ENABLE(DRAG_SUPPORT) guards
682         https://bugs.webkit.org/show_bug.cgi?id=30472
683
684         Put ENABLE(DRAG_SUPPORT) guards around EventHandler::eventLoopHandleMouseDragged
685         in EventHandler.cpp. MSVC fails to compile when DRAG_SUPPORT not enabled.
686
687         * page/EventHandler.cpp:
688
689 2009-10-17  Alpha Lam  <hclam@chromium.org>
690
691         Reviewed by Eric Seidel.
692
693         [chromium] Video controls not zoomed / transformed correctly
694         https://bugs.webkit.org/show_bug.cgi?id=30461
695
696         Draw the images in the controls scaled.
697
698         No new tests. With this change Chromium will pass the following tests:
699         LayoutTests/media/video-controls-zoomed.html
700         LayoutTests/media/video-controls-transformed.html
701
702         * rendering/RenderMediaControlsChromium.cpp:
703         (WebCore::paintMediaButton):
704         Pass along the target rect directly.
705         (WebCore::RenderMediaControlsChromium::adjustMediaSliderThumbSize):
706         Adjust the thumb slide applied with the scale factor.
707
708 2009-10-17  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
709
710         Unreviewed.
711
712         [Gtk] Build fix for WebKitGtk after r49723.
713
714         Add bindings/js/JSExceptionBase.* to the build.
715
716         * GNUmakefile.am:
717
718 2009-10-17  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
719
720         Unreviewed.
721
722         [Qt] Build fix for QtWebKit after r49723.
723
724         Add bindings/js/JSExceptionBase.cpp to the build.
725
726         * WebCore.pro:
727
728 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
729
730         Reviewed by Dan Bernstein.
731
732         https://bugs.webkit.org/show_bug.cgi?id=30456
733         Fixes for new Debug_All Windows build configuration.
734
735         * platform/network/cf/ResourceRequestCFNet.cpp:
736         (WebCore::findCFNetworkModule): Ask for the correct library instead of guessing.
737         * platform/win/ScrollbarThemeSafari.cpp: Use new DEBUG_ALL preprocessor define for library naming.
738         * rendering/RenderMediaControls.cpp: Use new DEBUG_ALL preprocessor define for library naming.
739         * rendering/RenderThemeSafari.cpp: Use new DEBUG_ALL preprocessor define for library naming.
740
741 2009-10-16  Jon Honeycutt  <jhoneycutt@apple.com>
742
743         Add SPI to determine whether a plug-in has ever been halted.
744
745         Part of <rdar://problem/7312158>.
746
747         Reviewed by Dan Bernstein.
748
749         * plugins/PluginView.cpp:
750         (WebCore::PluginView::PluginView):
751         Initialize m_hasBeenHalted.
752
753         * plugins/PluginView.h:
754         (WebCore::PluginView::hasBeenHalted):
755         Return m_hasBeenHalted.
756
757         * plugins/win/PluginViewWin.cpp:
758         (WebCore::PluginView::halt):
759         Set m_hasBeenHalted.
760
761 2009-10-16  Adam Barth  <abarth@webkit.org>
762
763         Reviewed by Alexey Proskuryakov.
764
765         @charset rule after the first byte causes the rest of css to be ignored
766         https://bugs.webkit.org/show_bug.cgi?id=18265
767
768         Apparently we're supposed to tolerate whitespace before the charset
769         rule so folks can write code like this:
770
771         <style>
772         @charset "utf-8"
773         ...
774         </style>
775
776         I'm told this is one of the top compatability problems in China.
777         Tests: fast/css/comment-before-charset-external.html
778                fast/css/comment-before-charset.html
779                fast/css/many-spaces-before-charset.html
780                fast/css/space-before-charset-external.html
781                fast/css/space-before-charset.html
782
783         * css/CSSGrammar.y:
784
785 2009-10-16  Brian Weinstein  <bweinstein@apple.com>
786
787         Reviewed by Darin Adler.
788
789         Fixes part of <http://webkit.org/b/30412>.
790         Web Inspector should get human readable DOM Exceptions.
791
792         Add a description field to ExceptionBase, and call it through 
793         reportException which allows the user/developer to get a more detailed
794         and coherent error explanation through the Web Inspector.
795
796         This only applies to exceptions that come from a script on the page when
797         it is run. DOM Exceptions that come from the code run in the console, or DOM
798         exceptions that are caught and logged will come in a future patch.
799
800         Tests: inspector/uncaught-dom1-exception.html
801                inspector/uncaught-dom3-exception.html
802                inspector/uncaught-dom8-exception.html
803
804         * WebCore.gypi:
805         * WebCore.vcproj/WebCore.vcproj:
806         * WebCore.xcodeproj/project.pbxproj:
807         * bindings/js/JSDOMBinding.cpp:
808         (WebCore::reportException):
809         * bindings/js/JSExceptionBase.cpp: Added.
810         (WebCore::toExceptionBase):
811         * bindings/js/JSExceptionBase.h: Added.
812         * dom/ExceptionBase.cpp:
813         (WebCore::ExceptionBase::ExceptionBase):
814         * dom/ExceptionBase.h:
815         (WebCore::ExceptionBase::description):
816         * dom/ExceptionCode.cpp:
817         (WebCore::):
818         (WebCore::getExceptionCodeDescription):
819         * dom/ExceptionCode.h:
820
821 2009-10-16  Geoffrey Garen  <ggaren@apple.com>
822
823         Build fix: forgot to check in this #include.
824
825         * bridge/runtime_root.h:
826
827 2009-10-16  Simon Fraser  <simon.fraser@apple.com>
828
829         Reviewed by Dan Bernstein.
830
831         Transform layer gets stuck with the wrong transform after an animation ends
832         <rdar://problem/7311662>
833
834         Work around a CoreAnimation bug which causes an animated transform layer to
835         end up with a stale transform.
836         
837         Test: compositing/animation/state-at-end-event-transform-layer.html
838
839         * platform/graphics/mac/GraphicsLayerCA.mm:
840         (WebCore::bug7311367Workaround):
841         (WebCore::GraphicsLayerCA::removeAnimationFromLayer):
842
843 2009-10-16  Simon Fraser  <simon.fraser@apple.com>
844
845         Reviewed by Dan Bernstein.
846
847         After running a transition with an end event listener, can't change the transform
848         https://bugs.webkit.org/show_bug.cgi?id=30454
849         
850         Fix an issue where, if a document had any listener for webkitTransitionEnd or webkitAnimationEnd,
851         the animations would not get cleaned up correctly, which broke subsequent changes of transform.
852         
853         Now, we always clean up the animations right after queuing up the end events.
854
855         Tests: animations/state-at-end-event.html
856                transitions/move-after-transition.html
857
858         * page/animation/ImplicitAnimation.cpp:
859         (WebCore::ImplicitAnimation::onAnimationEnd):
860         * page/animation/KeyframeAnimation.cpp:
861         (WebCore::KeyframeAnimation::onAnimationEnd):
862
863 2009-10-15  Joseph Pecoraro  <joepeck@webkit.org>
864
865         Reviewed by Timothy Hatcher.
866
867         Web Inspector: Handle the Enter Key in the Elements Tree Hierarchy
868         https://bugs.webkit.org/show_bug.cgi?id=30428
869
870         TextNode => Edit Text Node
871         Has Attributes => Edit First Attribute
872         No Attributes => Start Editing New Attribute
873
874         * inspector/front-end/ElementsTreeOutline.js:
875         (WebInspector.ElementsTreeOutline.prototype.handleKeyEvent): handle the "Enter" key
876         (WebInspector.ElementsTreeElement.prototype.set hovered): only add new attribute button on nodes with attributes
877         (WebInspector.ElementsTreeElement.prototype._addNewAttribute): prevent moving backwards where there are no attributes
878         (WebInspector.ElementsTreeElement.prototype._startEditingFromEvent): renamed to be clearer
879         (WebInspector.ElementsTreeElement.prototype._startEditing): transition to the appropriate edit state for a tree element
880
881 2009-10-16  Adam Barth  <abarth@webkit.org>
882
883         Reviewed by Eric Seidel.
884
885         Fix header indent style for FrameLoader and friends
886         https://bugs.webkit.org/show_bug.cgi?id=30430
887
888         * loader/FrameLoader.h:
889         (WebCore::FrameLoader::frame):
890         (WebCore::FrameLoader::policyChecker):
891         (WebCore::FrameLoader::history):
892         (WebCore::FrameLoader::notifier):
893         (WebCore::FrameLoader::isLoadingMainResource):
894         (WebCore::FrameLoader::documentLoader):
895         (WebCore::FrameLoader::policyDocumentLoader):
896         (WebCore::FrameLoader::provisionalDocumentLoader):
897         (WebCore::FrameLoader::state):
898         (WebCore::FrameLoader::client):
899         (WebCore::FrameLoader::url):
900         (WebCore::FrameLoader::isLoadingFromCachedPage):
901         (WebCore::FrameLoader::committingFirstRealLoad):
902         (WebCore::FrameLoader::committedFirstRealDocumentLoad):
903         (WebCore::FrameLoader::creatingInitialEmptyDocument):
904         * loader/HistoryController.h:
905         (WebCore::HistoryController::currentItem):
906         (WebCore::HistoryController::provisionalItem):
907         * loader/PolicyCallback.h:
908         (WebCore::PolicyCallback::request):
909         * loader/PolicyChecker.h:
910         (WebCore::PolicyChecker::loadType):
911         (WebCore::PolicyChecker::setLoadType):
912         (WebCore::PolicyChecker::delegateIsDecidingNavigationPolicy):
913         (WebCore::PolicyChecker::delegateIsHandlingUnimplementablePolicy):
914         * loader/RedirectScheduler.h:
915         * loader/ResourceLoadNotifier.h:
916
917 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
918
919         Reviewed by Adam Roben.
920
921         Add a Debug_All configuration to build entire stack as debug.
922         Change Debug_Internal to:
923         - stop using _debug suffix for all WebKit/Safari binaries
924         - not use _debug as a DLL naming suffix
925         - use non-debug C runtime lib.
926
927         * WebCore.vcproj/QTMovieWin.vcproj: Add Debug_All configuration.
928         * WebCore.vcproj/WebCore.make: Debug build in makefile should build Debug_All.
929         * WebCore.vcproj/WebCore.sln: Add Debug_All configuration.
930         * WebCore.vcproj/WebCore.submit.sln: Add Debug_All configuration.
931         * WebCore.vcproj/WebCore.vcproj: Add Debug_All configuration.
932         * WebCore.vcproj/WebCoreGenerated.vcproj: Renamed single configuration from "Release" to "all".
933
934 2009-10-16  Dimitri Glazkov  <dglazkov@chromium.org>
935
936         No review, rolling out r49693, because it broke Chromium build.
937         http://trac.webkit.org/changeset/49693
938
939         * WebCore.gyp/WebCore.gyp:
940         * WebCore.gypi:
941
942 2009-10-16  Andrew Scherkus  <scherkus@chromium.org>
943
944         Reviewed by Eric Carlson.
945
946         Updated media resource selection algorithm to reflect latest HTML 5 specification.
947
948         Noticable changes:
949             -  Elements with no source should have their network state set to NETWORK_EMPTY as opposed to NETWORK_NO_SOURCE
950             -  Empty string ("") is now considered a valid URL resolving to the current page and will be loaded
951
952         Tests: media/video-src-empty.html
953                media/video-src-none.html
954
955         https://bugs.webkit.org/show_bug.cgi?id=30407
956
957         * html/HTMLMediaElement.cpp:
958         (WebCore::HTMLMediaElement::selectMediaResource): Updated code and comments to match spec.
959
960 2009-10-16  Adam Barth  <abarth@webkit.org>
961
962         Reviewed by Eric Seidel.
963
964         Insecure plug-ins don't trigger mixed content
965         https://bugs.webkit.org/show_bug.cgi?id=30431
966
967         Added the missing check.
968
969         Test: http/tests/security/mixedContent/insecure-plugin-in-iframe.html
970
971         * loader/FrameLoader.cpp:
972         (WebCore::FrameLoader::loadPlugin):
973
974 2009-10-16  Andrew Scherkus  <scherkus@chromium.org>
975
976         Reviewed by Eric Carlson.
977
978         Set autobuffer to true and schedule load in V8 audio element constructor.
979
980         https://bugs.webkit.org/show_bug.cgi?id=30448
981
982         Covered by existing tests.
983
984         * bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
985         (WebCore::CALLBACK_FUNC_DECL): Set autobuffer to true and schedule load.
986
987 2009-10-16  Andrew Scherkus  <scherkus@chromium.org>
988
989         Reviewed by Eric Seidel.
990
991         Remove FIXME in RenderMediaControlsChromium as bug was fixed upstream.
992
993         https://bugs.webkit.org/show_bug.cgi?id=30422
994
995         Covered by existing media layout tests.
996
997         * rendering/RenderMediaControlsChromium.cpp:
998         (WebCore::paintMediaSlider): Removed round() and FIXME.
999
1000 2009-10-16  Andrew Scherkus  <scherkus@chromium.org>
1001
1002         Reviewed by Eric Seidel.
1003
1004         Fix Chromium media controls to render a disabled play button when the element is unintialized.
1005
1006         https://bugs.webkit.org/show_bug.cgi?id=30410
1007
1008         Covered by existing layout tests.
1009
1010         * rendering/RenderMediaControlsChromium.cpp:
1011         (WebCore::paintMediaPlayButton): Include check for NETWORK_EMPTY to render disabled play button.
1012
1013 2009-10-16  Oliver Hunt  <oliver@apple.com>
1014
1015         Reviewed by Gavin Barraclough.
1016
1017         Make typeinfo flags default to false
1018         https://bugs.webkit.org/show_bug.cgi?id=30372
1019
1020         Last part -- replace HasDefaultGetPropertyNames with OverridesGetPropertyNames
1021         flag.
1022
1023         * bindings/js/JSDOMWindowShell.h:
1024         (WebCore::JSDOMWindowShell::createStructure):
1025         * bindings/js/JSHTMLAllCollection.h:
1026         (WebCore::JSHTMLAllCollection::createStructure):
1027         * bindings/js/JSQuarantinedObjectWrapper.h:
1028         (WebCore::JSQuarantinedObjectWrapper::createStructure):
1029         * bindings/scripts/CodeGeneratorJS.pm:
1030         * bridge/runtime_array.h:
1031         (JSC::RuntimeArray::createStructure):
1032         * bridge/runtime_object.h:
1033         (JSC::RuntimeObjectImp::createStructure):
1034
1035 2009-10-16  Steven Knight  <sgk@chromium.org>
1036
1037         Reviewed by David Levin.
1038
1039         https://bugs.webkit.org/show_bug.cgi?id=30447
1040         Handle long link lines by building .idl-generated bindings in a
1041         separate webcore_bindings library target.  Avoid Visual Studio
1042         dependency issues by building additional generated .cpp and .h files
1043         in a separate webcore_bindings_sources target.
1044
1045         Chrome should still build and test successfully.
1046
1047         * WebCore.gyp/WebCore.gyp:
1048         * WebCore.gypi:
1049
1050 2009-10-16  Simon Fraser  <simon.fraser@apple.com>
1051
1052         Reviewed by Eric Carlson.
1053
1054         Transform transitions that used to be accelerated are no longer so
1055         https://bugs.webkit.org/show_bug.cgi?id=30453
1056
1057         The change in r49633, to not run accelerated animations/transitions on layers that
1058         are not attached, broke accelerated transitions/animations in many cases where they start
1059         as soon as the page loads. This change reverts the code that tests for the GraphicsLayer being
1060         attached.
1061         
1062         No test, because it's not possible from a test to know whether a transition is accelerated or not.
1063
1064         * rendering/RenderLayerBacking.cpp:
1065         (WebCore::RenderLayerBacking::startAnimation):
1066         (WebCore::RenderLayerBacking::startTransition):
1067
1068 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
1069
1070         wxMSW build fix, build the MSW source to get methods that use the MSW version of
1071         PlatformModuleVersion.
1072
1073         * wscript:
1074
1075 2009-10-16  Adam Barth  <abarth@webkit.org>
1076
1077         Unreviewed build fix.  Add back MIMETypeRegistryChromium with the right
1078         casing.
1079
1080         * platform/chromium/MIMETypeRegistryChromium.cpp: Added.
1081         (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
1082         (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
1083         (WebCore::MIMETypeRegistry::getMIMETypeForPath):
1084         (WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
1085         (WebCore::MIMETypeRegistry::isSupportedImageResourceMIMEType):
1086         (WebCore::MIMETypeRegistry::isSupportedImageMIMETypeForEncoding):
1087         (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
1088         (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
1089         (WebCore::MIMETypeRegistry::isSupportedMediaMIMEType):
1090         (WebCore::MIMETypeRegistry::isJavaAppletMIMEType):
1091         (WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension):
1092         (WebCore::dummyHashSet):
1093         (WebCore::MIMETypeRegistry::getSupportedImageMIMETypes):
1094         (WebCore::MIMETypeRegistry::getSupportedImageResourceMIMETypes):
1095         (WebCore::MIMETypeRegistry::getSupportedImageMIMETypesForEncoding):
1096         (WebCore::MIMETypeRegistry::getSupportedNonImageMIMETypes):
1097         (WebCore::MIMETypeRegistry::getSupportedMediaMIMETypes):
1098
1099 2009-10-16  Adam Barth  <abarth@webkit.org>
1100
1101         Reviewed by Darin Adler.
1102
1103         MimeTypeRegistryChromium is mis-casen
1104         https://bugs.webkit.org/show_bug.cgi?id=30441
1105
1106         Change the case of MimeTypeRegistryChromium to match other platforms.
1107
1108         * WebCore.gypi:
1109         * platform/chromium/MIMETypeRegistryChromium.cpp: Copied from WebCore/platform/chromium/MimeTypeRegistryChromium.cpp.
1110         * platform/chromium/MimeTypeRegistryChromium.cpp: Removed.
1111
1112 2009-10-16  Dimitri Glazkov  <dglazkov@chromium.org>
1113
1114         Reviewed by Eric Seidel.
1115
1116         Change EmptyPluginHalterClient in SVGImage to be non-static, to
1117         match changes made http://trac.webkit.org/changeset/49385.
1118         https://bugs.webkit.org/show_bug.cgi?id=30403
1119
1120         Run the following layout test sequence:
1121           LayoutTests/svg/W3C-SVG-1.1/struct-image-01-t.svg
1122           LayoutTests/svg/W3C-SVG-1.1/struct-image-03-t.svg
1123           LayoutTests/svg/W3C-SVG-1.1/struct-image-04-t.svg
1124           LayoutTests/svg/W3C-SVG-1.1/struct-image-05-b.svg
1125           LayoutTests/svg/W3C-SVG-1.1/struct-image-06-t.svg
1126           LayoutTests/svg/W3C-SVG-1.1/struct-image-07-t.svg
1127           LayoutTests/svg/W3C-SVG-1.1/struct-image-08-t.svg
1128           LayoutTests/svg/W3C-SVG-1.1/struct-image-09-t.svg
1129           LayoutTests/svg/W3C-SVG-1.1/struct-image-10-t.svg
1130           LayoutTests/svg/carto.net/scrollbar.svg
1131           LayoutTests/svg/carto.net/selectionlist.svg
1132
1133         selectionlist.svg should not crash.
1134
1135         * svg/graphics/SVGImage.cpp:
1136         (WebCore::SVGImage::dataChanged): Made EmptyPluginHalterClient non-static.
1137
1138 2009-10-16  Victor Wang  <victorw@chromium.org>
1139
1140         Reviewed by David Levin.
1141
1142         Add beforeload event support to V8DOMWrapper
1143
1144         https://bugs.webkit.org/show_bug.cgi?id=30413
1145
1146         LayoutTests/fast/dom/beforeload/frame-before-load.html
1147
1148         * bindings/v8/V8DOMWrapper.cpp:
1149         (WebCore::V8DOMWrapper::convertEventToV8Object):
1150
1151 2009-10-16  Adam Barth  <abarth@webkit.org>
1152
1153         Reviewed by Darin Adler.
1154
1155         MimeTypeRegistryChromium is mis-casen
1156         https://bugs.webkit.org/show_bug.cgi?id=30441
1157
1158         Change the case of MimeTypeRegistryChromium to match other platforms.
1159
1160         * WebCore.gypi:
1161         * platform/chromium/MIMETypeRegistryChromium.cpp: Copied from WebCore/platform/chromium/MimeTypeRegistryChromium.cpp.
1162         * platform/chromium/MimeTypeRegistryChromium.cpp: Removed.
1163
1164 2009-10-16  Adam Barth  <abarth@webkit.org>
1165
1166         Reviewed by Mark Rowe.
1167
1168         Chrome doesn't set Content-Type for file upload when the file extension
1169         is not recognized
1170         https://bugs.webkit.org/show_bug.cgi?id=30433
1171
1172         Apparently, getMIMETypeForPath is supposed to return
1173         application/octet-stream when it doesn't have a better MIME type.
1174
1175         * platform/chromium/MimeTypeRegistryChromium.cpp:
1176         (WebCore::MIMETypeRegistry::getMIMETypeForPath):
1177
1178 2009-10-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1179
1180         Pull out r49676 as it caused build breakges on Symbian
1181
1182         * plugins/symbian/PluginViewSymbian.cpp:
1183
1184 2009-10-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1185
1186         Reviewed by Ariya Hidayat.
1187
1188         Crash fix when loading NPAPI plugins on Qt/Mac
1189
1190         There's no guarantee that the plist will be valid even if we
1191         ask the plugin to create it. Crash obverved with iGetter.
1192
1193         * plugins/mac/PluginPackageMac.cpp:
1194
1195 2009-10-15  Stephen White  <senorblanco@chromium.org>
1196
1197         Reviewed by David Levin.
1198
1199         Fix for Chromium/skia's implementation of canvas's isPointInPath().
1200         https://bugs.webkit.org/show_bug.cgi?id=30402
1201
1202         Covered by LayoutTests/fast/canvas/pointInPath.html.
1203
1204         * platform/graphics/skia/SkiaUtils.cpp:
1205         (WebCore::SkPathContainsPoint):
1206
1207 2009-10-15  Adam Barth  <abarth@webkit.org>
1208
1209         Reviewed by Darin Adler.
1210
1211         Factor ResourceLoadNotifier out of FrameLoader
1212         https://bugs.webkit.org/show_bug.cgi?id=30379
1213
1214         These methods have virtually no interaction with the rest of
1215         FrameLoader.
1216
1217         * GNUmakefile.am:
1218         * WebCore.gypi:
1219         * WebCore.pro:
1220         * WebCore.vcproj/WebCore.vcproj:
1221         * WebCore.xcodeproj/project.pbxproj:
1222         * WebCoreSources.bkl:
1223         * dom/Document.cpp:
1224         (WebCore::Document::resourceRetrievedByXMLHttpRequest):
1225         * loader/FrameLoader.cpp:
1226         (WebCore::FrameLoader::FrameLoader):
1227         (WebCore::FrameLoader::continueLoadAfterWillSubmitForm):
1228         (WebCore::ResourceLoadNotifier::ResourceLoadNotifier):
1229         (WebCore::ResourceLoadNotifier::activeDocumentLoader):
1230         (WebCore::ResourceLoadNotifier::assignIdentifierToInitialRequest):
1231         (WebCore::ResourceLoadNotifier::willSendRequest):
1232         (WebCore::ResourceLoadNotifier::didReceiveResponse):
1233         (WebCore::ResourceLoadNotifier::didReceiveData):
1234         (WebCore::ResourceLoadNotifier::didFailToLoad):
1235         (WebCore::ResourceLoadNotifier::didLoadResourceByXMLHttpRequest):
1236         (WebCore::FrameLoader::sendRemainingDelegateMessages):
1237         (WebCore::FrameLoader::requestFromDelegate):
1238         (WebCore::ResourceLoadNotifier::didFinishLoad):
1239         (WebCore::ResourceLoadNotifier::didReceiveAuthenticationChallenge):
1240         (WebCore::ResourceLoadNotifier::didCancelAuthenticationChallenge):
1241         (WebCore::ResourceLoadNotifier::dispatchAssignIdentifierToInitialRequest):
1242         (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
1243         (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse):
1244         (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength):
1245         (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
1246         * loader/FrameLoader.h:
1247         (WebCore::FrameLoader::notifier):
1248         * loader/MainResourceLoader.cpp:
1249         (WebCore::MainResourceLoader::receivedError):
1250         * loader/ResourceLoadNotifier.cpp: Added.
1251         (WebCore::ResourceLoadNotifier::ResourceLoadNotifier):
1252         (WebCore::ResourceLoadNotifier::didReceiveAuthenticationChallenge):
1253         (WebCore::ResourceLoadNotifier::didCancelAuthenticationChallenge):
1254         (WebCore::ResourceLoadNotifier::assignIdentifierToInitialRequest):
1255         (WebCore::ResourceLoadNotifier::willSendRequest):
1256         (WebCore::ResourceLoadNotifier::didReceiveResponse):
1257         (WebCore::ResourceLoadNotifier::didReceiveData):
1258         (WebCore::ResourceLoadNotifier::didFinishLoad):
1259         (WebCore::ResourceLoadNotifier::didFailToLoad):
1260         (WebCore::ResourceLoadNotifier::didLoadResourceByXMLHttpRequest):
1261         (WebCore::ResourceLoadNotifier::dispatchAssignIdentifierToInitialRequest):
1262         (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
1263         (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse):
1264         (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength):
1265         (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
1266         (WebCore::ResourceLoadNotifier::activeDocumentLoader):
1267         * loader/ResourceLoadNotifier.h: Added.
1268         * loader/ResourceLoader.cpp:
1269         (WebCore::ResourceLoader::willSendRequest):
1270         (WebCore::ResourceLoader::didReceiveResponse):
1271         (WebCore::ResourceLoader::didReceiveData):
1272         (WebCore::ResourceLoader::didFinishLoadingOnePart):
1273         (WebCore::ResourceLoader::didFail):
1274         (WebCore::ResourceLoader::didCancel):
1275         (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
1276         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
1277
1278 2009-10-15  Roland Steiner  <rolandsteiner@google.com>
1279
1280         Reviewed by Darin Fisher.
1281
1282         Bug 30427 -  Remove unneeded methods in ChromiumDataObject
1283         (https://bugs.webkit.org/show_bug.cgi?id=30427)
1284         
1285         Remove no longer needed methods from ChromiumDataObject.
1286
1287         No new tests (no functional change)
1288
1289         * platform/chromium/ChromiumDataObject.h:
1290
1291 2009-10-16  Yael Aharon  <yael.aharon@nokia.com>
1292
1293         Reviewed by Tor Arne Vestbø.
1294
1295         [Qt] Need a way to inform the application when a Netscape plugin is created or deleted
1296         https://bugs.webkit.org/show_bug.cgi?id=30179
1297
1298         Inform the application when a plugin is created or destroyed, but only if the 
1299         application registered for these notifications.
1300
1301         * plugins/symbian/PluginViewSymbian.cpp:
1302         (WebCore::PluginView::platformStart):
1303         (WebCore::PluginView::platformDestroy):
1304
1305 2009-10-16  Shu Chang  <Chang.Shu@nokia.com>
1306
1307         Reviewed by Eric Seidel.
1308
1309         Default language translation should be determined by locale settings,
1310         e.g., "en-US".
1311         https://bugs.webkit.org/show_bug.cgi?id=29653
1312
1313         Test: fast/js/navigator-language.html
1314
1315         * platform/qt/Localizations.cpp:
1316         (WebCore::defaultLanguage):
1317
1318 2009-10-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1319
1320         Reviewed by Ariya Hidayat.
1321
1322         Crash fix when loading NPAPI plugins on Qt/Mac
1323
1324         There's no guarantee that the plist will be valid even if we
1325         ask the plugin to create it. Crash obverved with iGetter.
1326
1327         * plugins/mac/PluginPackageMac.cpp:
1328
1329 2009-10-15  Stephen White  <senorblanco@chromium.org>
1330
1331         Reviewed by David Levin.
1332
1333         Fix for Chromium/skia's implementation of canvas's isPointInPath().
1334         https://bugs.webkit.org/show_bug.cgi?id=30402
1335
1336         Covered by LayoutTests/fast/canvas/pointInPath.html.
1337
1338         * platform/graphics/skia/SkiaUtils.cpp:
1339         (WebCore::SkPathContainsPoint):
1340
1341 2009-10-15  Adam Barth  <abarth@webkit.org>
1342
1343         Reviewed by Darin Adler.
1344
1345         Factor ResourceLoadNotifier out of FrameLoader
1346         https://bugs.webkit.org/show_bug.cgi?id=30379
1347
1348         These methods have virtually no interaction with the rest of
1349         FrameLoader.
1350
1351         * GNUmakefile.am:
1352         * WebCore.gypi:
1353         * WebCore.pro:
1354         * WebCore.vcproj/WebCore.vcproj:
1355         * WebCore.xcodeproj/project.pbxproj:
1356         * WebCoreSources.bkl:
1357         * dom/Document.cpp:
1358         (WebCore::Document::resourceRetrievedByXMLHttpRequest):
1359         * loader/FrameLoader.cpp:
1360         (WebCore::FrameLoader::FrameLoader):
1361         (WebCore::FrameLoader::continueLoadAfterWillSubmitForm):
1362         (WebCore::ResourceLoadNotifier::ResourceLoadNotifier):
1363         (WebCore::ResourceLoadNotifier::activeDocumentLoader):
1364         (WebCore::ResourceLoadNotifier::assignIdentifierToInitialRequest):
1365         (WebCore::ResourceLoadNotifier::willSendRequest):
1366         (WebCore::ResourceLoadNotifier::didReceiveResponse):
1367         (WebCore::ResourceLoadNotifier::didReceiveData):
1368         (WebCore::ResourceLoadNotifier::didFailToLoad):
1369         (WebCore::ResourceLoadNotifier::didLoadResourceByXMLHttpRequest):
1370         (WebCore::FrameLoader::sendRemainingDelegateMessages):
1371         (WebCore::FrameLoader::requestFromDelegate):
1372         (WebCore::ResourceLoadNotifier::didFinishLoad):
1373         (WebCore::ResourceLoadNotifier::didReceiveAuthenticationChallenge):
1374         (WebCore::ResourceLoadNotifier::didCancelAuthenticationChallenge):
1375         (WebCore::ResourceLoadNotifier::dispatchAssignIdentifierToInitialRequest):
1376         (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
1377         (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse):
1378         (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength):
1379         (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
1380         * loader/FrameLoader.h:
1381         (WebCore::FrameLoader::notifier):
1382         * loader/MainResourceLoader.cpp:
1383         (WebCore::MainResourceLoader::receivedError):
1384         * loader/ResourceLoadNotifier.cpp: Added.
1385         (WebCore::ResourceLoadNotifier::ResourceLoadNotifier):
1386         (WebCore::ResourceLoadNotifier::didReceiveAuthenticationChallenge):
1387         (WebCore::ResourceLoadNotifier::didCancelAuthenticationChallenge):
1388         (WebCore::ResourceLoadNotifier::assignIdentifierToInitialRequest):
1389         (WebCore::ResourceLoadNotifier::willSendRequest):
1390         (WebCore::ResourceLoadNotifier::didReceiveResponse):
1391         (WebCore::ResourceLoadNotifier::didReceiveData):
1392         (WebCore::ResourceLoadNotifier::didFinishLoad):
1393         (WebCore::ResourceLoadNotifier::didFailToLoad):
1394         (WebCore::ResourceLoadNotifier::didLoadResourceByXMLHttpRequest):
1395         (WebCore::ResourceLoadNotifier::dispatchAssignIdentifierToInitialRequest):
1396         (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
1397         (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse):
1398         (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength):
1399         (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
1400         (WebCore::ResourceLoadNotifier::activeDocumentLoader):
1401         * loader/ResourceLoadNotifier.h: Added.
1402         * loader/ResourceLoader.cpp:
1403         (WebCore::ResourceLoader::willSendRequest):
1404         (WebCore::ResourceLoader::didReceiveResponse):
1405         (WebCore::ResourceLoader::didReceiveData):
1406         (WebCore::ResourceLoader::didFinishLoadingOnePart):
1407         (WebCore::ResourceLoader::didFail):
1408         (WebCore::ResourceLoader::didCancel):
1409         (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
1410         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
1411
1412 2009-10-15  Roland Steiner  <rolandsteiner@google.com>
1413
1414         Reviewed by Darin Fisher.
1415
1416         Bug 30427 -  Remove unneeded methods in ChromiumDataObject
1417         (https://bugs.webkit.org/show_bug.cgi?id=30427)
1418         
1419         Remove no longer needed methods from ChromiumDataObject.
1420
1421         No new tests (no functional change)
1422
1423         * platform/chromium/ChromiumDataObject.h:
1424
1425 2009-10-15  Daniel Bates  <dbates@webkit.org>
1426
1427         No review, rolling out r49644.
1428         http://trac.webkit.org/changeset/49644
1429         
1430         We need to think about this change some more. See bug #30418 
1431         for more details.
1432
1433         * page/XSSAuditor.cpp:
1434         (WebCore::XSSAuditor::canEvaluate):
1435         (WebCore::XSSAuditor::canEvaluateJavaScriptURL):
1436         (WebCore::XSSAuditor::canCreateInlineEventListener):
1437         (WebCore::XSSAuditor::canLoadExternalScriptFromSrc):
1438         (WebCore::XSSAuditor::canLoadObject):
1439         (WebCore::XSSAuditor::canSetBaseElementURL):
1440         (WebCore::XSSAuditor::findInRequest):
1441         * page/XSSAuditor.h:
1442
1443 2009-10-14  Jon Honeycutt  <jhoneycutt@apple.com>
1444
1445         Add SPI to determine whether a node is a halted plug-in.
1446
1447         Part of <rdar://problem/7273354> Halted plug-ins should restart on
1448         mouseover
1449
1450         https://bugs.webkit.org/show_bug.cgi?id=30151
1451
1452         Reviewed by Darin Adler.
1453
1454         * plugins/PluginView.cpp:
1455         (WebCore::PluginView::PluginView):
1456         Initialize m_isHalted.
1457
1458         * plugins/PluginView.h:
1459         (WebCore::PluginView::isHalted):
1460         Return m_isHalted.
1461
1462         * plugins/win/PluginViewWin.cpp:
1463         (WebCore::PluginView::halt):
1464         Set m_isHalted to true.
1465         (WebCore::PluginView::restart):
1466         clear m_isHalted.
1467
1468 2009-10-15  Zoltan Horvath  <zoltan@webkit.org>
1469
1470         Reviewed by Oliver Hunt.
1471
1472         [Qt] Build fix for QtWebKit after r49649.
1473
1474         Change JSC::HasNonDefaultMark to OverridesMarkChildren in createStructure function.
1475
1476         * bridge/qt/qt_runtime.h:
1477         (JSC::Bindings::QtRuntimeMethod::createStructure):
1478
1479 2009-10-15  Pavel Feldman  <pfeldman@chromium.org>
1480
1481         Not reviewed - build fix.
1482
1483         Web Inspector: add file missing in r49648
1484
1485         * inspector/front-end/TestController.js: Added.
1486         (WebInspector.TestController):
1487         (WebInspector.TestController.prototype.waitUntilDone):
1488         (WebInspector.TestController.prototype.notifyDone):
1489         (WebInspector.evaluateForTestInFrontend):
1490
1491 2009-10-15  Oliver Hunt  <oliver@apple.com>
1492
1493         Reviewed by Darin Adler.
1494
1495         Make typeinfo flags default to false
1496         https://bugs.webkit.org/show_bug.cgi?id=30372
1497
1498         Part 2 -- Reverse the TypeInfo HasDefaultMark flag to OverridesMarkChildren, etc
1499
1500         * bindings/js/JSDOMBinding.h:
1501         (WebCore::DOMObjectWithGlobalPointer::createStructure):
1502         (WebCore::DOMConstructorObject::createStructure):
1503         * bindings/js/JSDOMWindowShell.h:
1504         (WebCore::JSDOMWindowShell::createStructure):
1505         * bindings/js/JSHTMLAllCollection.h:
1506         (WebCore::JSHTMLAllCollection::createStructure):
1507         * bindings/js/JSQuarantinedObjectWrapper.h:
1508         (WebCore::JSQuarantinedObjectWrapper::createStructure):
1509         * bindings/scripts/CodeGeneratorJS.pm:
1510         * bridge/qt/qt_runtime.h:
1511         (JSC::Bindings::QtRuntimeMethod::createStructure):
1512         * bridge/runtime_method.h:
1513         (JSC::RuntimeMethod::createStructure):
1514
1515 2009-10-15  Pavel Feldman  <pfeldman@chromium.org>
1516
1517         Reviewed by Timothy Hatcher.
1518
1519         Web Inspector: introduce test controller with waitUntilDone
1520         on frontend side.
1521
1522         https://bugs.webkit.org/show_bug.cgi?id=30400
1523
1524         * WebCore.gypi:
1525         * WebCore.vcproj/WebCore.vcproj:
1526         * inspector/front-end/TestController.js: Added.
1527         (WebInspector.TestController):
1528         (WebInspector.TestController.prototype.waitUntilDone):
1529         (WebInspector.TestController.prototype.notifyDone):
1530         (WebInspector.evaluateForTestInFrontend):
1531         * inspector/front-end/WebKit.qrc:
1532         * inspector/front-end/inspector.html:
1533         * inspector/front-end/inspector.js:
1534
1535 2009-10-15  Daniel Bates  <dbates@webkit.org>
1536
1537         Reviewed by Adam Barth.
1538
1539         https://bugs.webkit.org/show_bug.cgi?id=27895
1540         
1541         Fixes an issue in which injecting an inline event handler whose value ends in a single-line
1542         JavaScript comment can bypass the XSSAuditor. Similarly fixes this issue with respect to
1543         the HTML Base element, HTML Object element, inline and external script tags, and
1544         JavaScript multi-line variants of all of these attacks.
1545
1546         Tests: http/tests/security/xssAuditor/base-href-comment.html
1547                http/tests/security/xssAuditor/iframe-javascript-url-comment.html
1548                http/tests/security/xssAuditor/img-onerror-HTML-comment.html
1549                http/tests/security/xssAuditor/img-onerror-comment.html
1550                http/tests/security/xssAuditor/object-tag-comment.html
1551                http/tests/security/xssAuditor/script-tag-comment-HTML-entity.html
1552                http/tests/security/xssAuditor/script-tag-comment.html
1553                http/tests/security/xssAuditor/script-tag-with-source-comment.html
1554
1555         * page/XSSAuditor.cpp: Added constant minAttackLength.
1556         (WebCore::XSSAuditor::canEvaluate):
1557         (WebCore::XSSAuditor::canEvaluateJavaScriptURL):
1558         (WebCore::XSSAuditor::canCreateInlineEventListener):
1559         (WebCore::XSSAuditor::canLoadExternalScriptFromSrc):
1560         (WebCore::XSSAuditor::canLoadObject):
1561         (WebCore::XSSAuditor::canSetBaseElementURL):
1562         (WebCore::XSSAuditor::findInRequest): Added parameter context. Only looks at up 
1563         to minAttackLength of script code plus context (if any).
1564         * page/XSSAuditor.h:
1565
1566 2009-10-08  Adam Langley  <agl@google.com>
1567
1568         Reviewed by Eric Seidel.
1569
1570         Currently, Skia clip paths are 1-bit. This patch makes our path
1571         clipping anti-aliased for non-canvas drawing.
1572
1573         http://code.google.com/p/chromium/issues/detail?id=5927
1574         https://bugs.webkit.org/show_bug.cgi?id=28820
1575         http://www.imperialviolet.org/2009/09/02/anti-aliased-clipping.html
1576
1577         Already covered by layout tests. New baselines will be needed in the
1578         Chromium tree.
1579
1580         (Reland. First landed in r49329, reverted in r49330 due to Windows
1581         build break)
1582
1583         * html/canvas/CanvasRenderingContext2D.cpp:
1584         (WebCore::CanvasRenderingContext2D::clip):
1585         * platform/graphics/GraphicsContext.h:
1586         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1587         (WebCore::GraphicsContext::canvasClip):
1588         * platform/graphics/cg/GraphicsContextCG.cpp:
1589         (WebCore::GraphicsContext::canvasClip):
1590         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
1591         (WebCore::GraphicsContext::canvasClip):
1592         * platform/graphics/qt/GraphicsContextQt.cpp:
1593         (WebCore::GraphicsContext::canvasClip):
1594         * platform/graphics/skia/GraphicsContextSkia.cpp:
1595         (WebCore::GraphicsContext::addInnerRoundedRectClip):
1596         (WebCore::GraphicsContext::clip):
1597         (WebCore::GraphicsContext::canvasClip):
1598         (WebCore::GraphicsContext::clipPath):
1599         * platform/graphics/skia/PlatformContextSkia.cpp:
1600         (PlatformContextSkia::clipPathAntiAliased):
1601         (PlatformContextSkia::restore):
1602         (PlatformContextSkia::applyAntiAliasedClipPaths):
1603         * platform/graphics/skia/PlatformContextSkia.h:
1604         * platform/graphics/win/GraphicsContextWin.cpp:
1605         (WebCore::GraphicsContext::canvasClip):
1606         * platform/graphics/wince/GraphicsContextWince.cpp:
1607         (WebCore::GraphicsContext::canvasClip):
1608         * platform/graphics/wx/GraphicsContextWx.cpp:
1609         (WebCore::GraphicsContext::canvasClip):
1610
1611 2009-10-15  Eric Carlson  <eric.carlson@apple.com>
1612
1613         Reviewed by Simon Fraser.
1614
1615         <rdar://problem/7295738> No way to mute/unmute a movie in full screen video mode
1616
1617         * WebCore.Video.exp: Export muted and setMute.
1618
1619 2009-10-15  Simon Fraser  <simon.fraser@apple.com>
1620
1621         Reviewed by Dan Bernstein.
1622
1623         Transitions fail to run sometimes
1624         https://bugs.webkit.org/show_bug.cgi?id=26770
1625
1626         Fix an issue where we could attempt to start accelerated animations or transitions on
1627         GraphicsLayer that were not rooted (because of visibility:hidden), which would leave
1628         the AnimationController's m_waitingForResponse flag in a state that killed subsequent
1629         software transitions.
1630
1631         * page/animation/AnimationController.cpp:
1632         (WebCore::AnimationControllerPrivate::AnimationControllerPrivate):
1633         (WebCore::AnimationControllerPrivate::endAnimationUpdate):
1634         (WebCore::AnimationControllerPrivate::receivedStartTimeResponse):
1635         (WebCore::AnimationControllerPrivate::addToStartTimeResponseWaitList):
1636         (WebCore::AnimationControllerPrivate::startTimeResponse):
1637         * page/animation/AnimationControllerPrivate.h:
1638         Make some methods non-inline for ease of debugging (these are not hot methods).
1639         Rename m_waitingForAResponse to m_waitingForResponse.
1640         
1641         * platform/graphics/GraphicsLayer.h:
1642         * platform/graphics/GraphicsLayer.cpp:
1643         (WebCore::GraphicsLayer::hasAncestor):
1644         New method to report whether the receiver has the given layer as an ancestor. Used for checking
1645         whether a layer is rooted.
1646
1647         * rendering/RenderLayerBacking.cpp:
1648         (WebCore::RenderLayerBacking::startAnimation):
1649         (WebCore::RenderLayerBacking::startTransition):
1650         Don't try to start accelerated animations or transitions on non-rooted GraphicsLayers.
1651
1652 2009-10-15  Alexander Pavlov  <apavlov@chromium.org>
1653
1654         Reviewed by Pavel Feldman.
1655
1656         Refactor ProfilesPanel to support multiple profile types
1657
1658         Data describing different profile types are now stored in distinct objects.
1659         https://bugs.webkit.org/show_bug.cgi?id=30332
1660
1661         * WebCore.vcproj/WebCore.vcproj:
1662         * inspector/front-end/ProfileView.js:
1663         (WebInspector.CPUProfileView.profileCallback):
1664         (WebInspector.CPUProfileView):
1665         (WebInspector.CPUProfileView.prototype._sortData):
1666         (WebInspector.CPUProfileType):
1667         (WebInspector.CPUProfileType.prototype.get buttonTooltip):
1668         (WebInspector.CPUProfileType.prototype.get buttonStyle):
1669         (WebInspector.CPUProfileType.prototype.buttonClicked):
1670         (WebInspector.CPUProfileType.prototype.setRecordingProfile):
1671         (WebInspector.CPUProfile):
1672         (WebInspector.CPUProfile.prototype.get title):
1673         (WebInspector.CPUProfile.prototype.get uid):
1674         (WebInspector.CPUProfile.prototype.get head):
1675         (WebInspector.CPUProfile.prototype.createView):
1676         (WebInspector.CPUProfile.prototype.viewForProfile):
1677         * inspector/front-end/ProfilesPanel.js:
1678         (WebInspector.ProfileType):
1679         (WebInspector.ProfileType.prototype.get buttonTooltip):
1680         (WebInspector.ProfileType.prototype.get buttonStyle):
1681         (WebInspector.ProfileType.prototype.get buttonCaption):
1682         (WebInspector.ProfileType.prototype.get id):
1683         (WebInspector.ProfileType.prototype.get name):
1684         (WebInspector.ProfileType.prototype.buttonClicked):
1685         (WebInspector.ProfilesPanel):
1686         (WebInspector.ProfilesPanel.prototype.get statusBarItems.clickHandler):
1687         (WebInspector.ProfilesPanel.prototype.get statusBarItems):
1688         (WebInspector.ProfilesPanel.prototype.reset):
1689         (WebInspector.ProfilesPanel.prototype.registerProfileType):
1690         (WebInspector.ProfilesPanel.prototype._makeKey):
1691         (WebInspector.ProfilesPanel.prototype.addProfileHeader):
1692         (WebInspector.ProfilesPanel.prototype.showProfile):
1693         (WebInspector.ProfilesPanel.prototype.getProfileType):
1694         (WebInspector.ProfilesPanel.prototype.showProfileForURL):
1695         (WebInspector.ProfilesPanel.prototype.updateProfileTypeButtons):
1696         (WebInspector.ProfilesPanel.prototype.displayTitleForProfileLink):
1697         (WebInspector.ProfilesPanel.prototype.get searchableViews):
1698         (WebInspector.ProfilesPanel.prototype._updateInterface):
1699         * inspector/front-end/inspector.js:
1700         (WebInspector._createPanels):
1701         (WebInspector.documentClick.followLink):
1702         (WebInspector.documentClick):
1703         (WebInspector.addProfileHeader):
1704         (WebInspector.setRecordingProfile):
1705         (WebInspector.linkifyStringAsFragment):
1706         (WebInspector.showProfileForURL):
1707
1708 2009-10-15  Pavel Feldman  <pfeldman@chromium.org>
1709
1710         Reviewed by Timothy Hatcher.
1711
1712         Web Inspector: Enable inspector layout tests.
1713
1714         https://bugs.webkit.org/show_bug.cgi?id=30014
1715
1716         * inspector/InspectorController.cpp:
1717         (WebCore::InspectorController::evaluateForTestInFrontend):
1718
1719 2009-10-15  Philippe Normand  <pnormand@igalia.com>
1720
1721         Reviewed by Gustavo Noronha.
1722
1723         [GStreamer] READY state doesn't mean "enough data"
1724         https://bugs.webkit.org/show_bug.cgi?id=30003
1725
1726         STATE_READY means MediaPlayer::HaveNothing
1727
1728         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
1729         (WebCore::MediaPlayerPrivate::updateStates):
1730
1731 2009-10-15  Philippe Normand  <pnormand@igalia.com>
1732
1733         Reviewed by Gustavo Noronha.
1734
1735         https://bugs.webkit.org/show_bug.cgi?id=30002
1736
1737         implement cancelLoad
1738
1739         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
1740         (WebCore::MediaPlayerPrivate::cancelLoad):
1741
1742 2009-10-15  Sebastian Dröge  <sebastian.droege@collabora.co.uk>
1743
1744         Reviewed by Gustavo Noronha.
1745
1746         https://bugs.webkit.org/show_bug.cgi?id=30353
1747         
1748         Fix race condition, leading to a deadlock
1749
1750         * platform/graphics/gtk/VideoSinkGStreamer.cpp:
1751         (webkit_video_sink_timeout_func):
1752         (webkit_video_sink_render):
1753         (unlock_buffer_mutex):
1754         (webkit_video_sink_unlock):
1755         (webkit_video_sink_unlock_stop):
1756         (webkit_video_sink_stop):
1757         (webkit_video_sink_start):
1758         (webkit_video_sink_class_init):
1759         Fix race condition in unlock/render that would lead to deadlocks.
1760
1761 2009-10-15  Sebastian Dröge  <sebastian.droege@collabora.co.uk>
1762
1763         Reviewed by Gustavo Noronha.
1764
1765         https://bugs.webkit.org/show_bug.cgi?id=30374
1766         
1767         Check if caps are valid before parsing them
1768
1769         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
1770         (WebCore::MediaPlayerPrivate::duration):
1771         Check if caps are valid before parsing them in ::naturalSize().
1772         This prevents assertions if the natural size should be calculated
1773         before the video caps are negotiated.
1774
1775 2009-10-15  Philippe Normand  <pnormand@igalia.com>
1776
1777         Reviewed by Gustavo Noronha.
1778
1779         https://bugs.webkit.org/show_bug.cgi?id=30006
1780         [GStreamer] Unnecessary checks for Messages types in callbacks
1781
1782         refactored gst message callbacks into a single one
1783
1784         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
1785         (WebCore::mediaPlayerPrivateMessageCallback):
1786         (WebCore::do_gst_init):
1787         (WebCore::MediaPlayerPrivate::duration):
1788         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
1789
1790 2009-10-15  Shu Chang  <Chang.Shu@nokia.com>
1791
1792         Reviewed by Adele Peterson.
1793
1794         Anchor elements should be mouse focusable regardless isLink flag.
1795         https://bugs.webkit.org/show_bug.cgi?id=26856
1796
1797         * html/HTMLAnchorElement.cpp:
1798         * html/HTMLAnchorElement.h:
1799
1800 2009-10-15  Nikolas Zimmermann  <nzimmermann@rim.com>
1801
1802         Not reviewed. Sort XCode project file.
1803
1804         * WebCore.xcodeproj/project.pbxproj:
1805
1806 2009-10-15  Yury Semikhatsky  <yurys@chromium.org>
1807
1808         Reviewed by Dave Hyatt.
1809
1810         Return correct shorthand property name for 
1811         background-repeat-x, background-repeat-y, background-position-x,
1812         background-position-y, -webkit-mask-position-x, -webkit-mask-position-y,
1813         -webkit-mask-repeat-x, -webkit-mask-repeat-y.
1814
1815         https://bugs.webkit.org/show_bug.cgi?id=28972
1816
1817         Test: fast/backgrounds/repeat/background-repeat-shorthand.html
1818
1819         * css/CSSParser.cpp:
1820         (WebCore::CSSParser::parseValue):
1821
1822 2009-10-14  Mikhail Naganov  <mnaganov@chromium.org>
1823
1824         Reviewed by Pavel Feldman.
1825
1826         Web Inspector: Migrate profiles to the injected script-based schema.
1827
1828         https://bugs.webkit.org/show_bug.cgi?id=30328
1829
1830         * bindings/js/JSInspectorBackendCustom.cpp:
1831         * bindings/v8/custom/V8CustomBinding.h:
1832         * inspector/InspectorBackend.cpp:
1833         (WebCore::InspectorBackend::getProfileHeaders):
1834         (WebCore::InspectorBackend::getProfile):
1835         * inspector/InspectorBackend.h:
1836         * inspector/InspectorBackend.idl:
1837         * inspector/InspectorController.cpp:
1838         (WebCore::InspectorController::addProfile):
1839         (WebCore::InspectorController::getProfileHeaders):
1840         (WebCore::InspectorController::getProfile):
1841         (WebCore::InspectorController::createProfileHeader):
1842         * inspector/InspectorController.h:
1843         * inspector/InspectorFrontend.cpp:
1844         (WebCore::InspectorFrontend::addProfileHeader):
1845         (WebCore::InspectorFrontend::didGetProfileHeaders):
1846         (WebCore::InspectorFrontend::didGetProfile):
1847         * inspector/InspectorFrontend.h:
1848         * inspector/JavaScriptProfileNode.cpp:
1849         (WebCore::ProfileNodeClass):
1850         * inspector/front-end/ProfileView.js:
1851         (WebInspector.ProfileView.profileCallback):
1852         (WebInspector.ProfileView):
1853         (WebInspector.ProfileView.prototype._mouseDownInDataGrid):
1854         (WebInspector.ProfileView.prototype._assignParentsInProfile):
1855         * inspector/front-end/ProfilesPanel.js:
1856         (WebInspector.ProfilesPanel.prototype.addProfileHeader):
1857         * inspector/front-end/inspector.js:
1858         (WebInspector.addProfileHeader):
1859
1860 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
1861
1862         Reviewed by Timothy Hatcher.
1863
1864         Web Inspector: Create and update frontend script objects only when
1865         web inspector is visible.
1866
1867         https://bugs.webkit.org/show_bug.cgi?id=30376
1868
1869         * inspector/InspectorController.cpp:
1870         (WebCore::InspectorController::addConsoleMessage):
1871         (WebCore::InspectorController::populateScriptObjects):
1872         (WebCore::InspectorController::pruneResources):
1873         (WebCore::InspectorController::didCommitLoad):
1874         (WebCore::InspectorController::didLoadResourceFromMemoryCache):
1875         (WebCore::InspectorController::identifierForInitialRequest):
1876         (WebCore::InspectorController::mainResourceFiredDOMContentEvent):
1877         (WebCore::InspectorController::mainResourceFiredLoadEvent):
1878         (WebCore::InspectorController::willSendRequest):
1879         (WebCore::InspectorController::didReceiveResponse):
1880         (WebCore::InspectorController::didReceiveContentLength):
1881         (WebCore::InspectorController::didFinishLoading):
1882         (WebCore::InspectorController::didFailLoading):
1883         (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
1884         (WebCore::InspectorController::scriptImported):
1885         (WebCore::InspectorController::didOpenDatabase):
1886         (WebCore::InspectorController::didUseDOMStorage):
1887         (WebCore::InspectorController::evaluateForTestInFrontend):
1888
1889 2009-10-15  Joseph Pecoraro  <joepeck@webkit.org>
1890
1891         Fix Windows build.
1892
1893         * dom/Document.idl:
1894
1895 2009-10-14  Joseph Pecoraro  <joepeck@webkit.org>
1896
1897         Reviewed by Adam Barth.
1898
1899         [HTML5] Add document.head
1900         https://bugs.webkit.org/show_bug.cgi?id=30232
1901
1902         Test is fast/dom/document-head.html
1903
1904         * dom/Document.idl: added readonly attribute head
1905
1906 2009-10-14  Matt Mueller  <mattm@chromium.org>
1907
1908         Reviewed by Darin Adler.
1909
1910         Check FNonNeg after the unit switch to avoid valgrind uninitialised conditional reference in WebCore::CSSParser::validUnit.  See http://crbug.com/20939.
1911         https://bugs.webkit.org/show_bug.cgi?id=30347
1912         https://bugs.webkit.org/show_bug.cgi?id=22772
1913
1914         Covered by running LayoutTests/fast/css/invalid-percentage-property.html under valgrind.
1915
1916         * css/CSSParser.cpp:
1917         (WebCore::CSSParser::validUnit):
1918
1919 2009-10-14  Adam Barth  <abarth@webkit.org>
1920
1921         Reviewed by Sam Weinig.
1922
1923         Move scrolling code from FrameLoader to FrameView
1924         https://bugs.webkit.org/show_bug.cgi?id=30370
1925
1926         This code is about controlling the Frame's view, not about loading
1927         stuff into the frame.
1928
1929         * loader/FrameLoader.cpp:
1930         (WebCore::FrameLoader::finishedParsing):
1931         (WebCore::FrameLoader::scrollToAnchor):
1932         * page/FrameView.cpp:
1933         (WebCore::FrameView::scrollToFragment):
1934         (WebCore::FrameView::scrollToAnchor):
1935         * page/FrameView.h:
1936
1937 2009-10-14  Oliver Hunt  <oliver@apple.com>
1938
1939         Reviewed by Geoff Garen.
1940
1941         Make typeinfo flags default to false
1942         https://bugs.webkit.org/show_bug.cgi?id=30372
1943         
1944         Part 1. Reverse the HasStandardGetOwnPropertySlot flag.
1945
1946         * bindings/js/JSDOMBinding.h:
1947         (WebCore::DOMObjectWithGlobalPointer::createStructure):
1948         (WebCore::DOMConstructorObject::createStructure):
1949         * bindings/js/JSDOMWindowShell.h:
1950         (WebCore::JSDOMWindowShell::createStructure):
1951         * bindings/js/JSHTMLAllCollection.h:
1952         (WebCore::JSHTMLAllCollection::createStructure):
1953         * bindings/js/JSQuarantinedObjectWrapper.h:
1954         (WebCore::JSQuarantinedObjectWrapper::createStructure):
1955         * bindings/scripts/CodeGeneratorJS.pm:
1956         * bridge/objc/objc_runtime.h:
1957         (JSC::Bindings::ObjcFallbackObjectImp::createStructure):
1958         * bridge/runtime_array.h:
1959         (JSC::RuntimeArray::createStructure):
1960         * bridge/runtime_method.h:
1961         (JSC::RuntimeMethod::createStructure):
1962         * bridge/runtime_object.h:
1963         (JSC::RuntimeObjectImp::createStructure):
1964
1965 2009-10-14  Adam Barth  <abarth@webkit.org>
1966
1967         Reviewed by Darin Adler.
1968
1969         [XSSAuditor] Add an exception for local files
1970         https://bugs.webkit.org/show_bug.cgi?id=30352
1971
1972         Reduce XSS auditor false positives by always letting pages load scripts
1973         from their own host. We don't actually know of any false positives
1974         that this prevents, but it seems like a good idea.
1975
1976         One subtly is that we don't add this exception for scripts that have a
1977         query string because (1) URLs with query strings are more apt to
1978         confuse servers and (2) it is much less common to load scripts with a
1979         query string.
1980
1981         Tests: http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query.html
1982                http/tests/security/xssAuditor/script-tag-with-source-same-host.html
1983
1984         * page/XSSAuditor.cpp:
1985         (WebCore::XSSAuditor::canLoadExternalScriptFromSrc):
1986
1987 2009-10-14  Nikolas Zimmermann  <nzimmermann@rim.com>
1988
1989         Reviewed by George Staikos.
1990
1991         Kill virtual contextElement() method spread all over SVG code
1992         https://bugs.webkit.org/show_bug.cgi?id=30183
1993
1994         Remove virtual contextElement() function from all SVG*Element classes, as all animated properties live in the
1995         SVG*Element classes now instead of the SVGFitToViewBox / SVGURIReference / SVGExternalResourcesRequired
1996         subclasses. This is a first step to working animVal support. More patches will follow that depend on this change.
1997
1998         Remove "This file is part of the KDE project" from several files, change my old mail adress wildfox -> zimmermann,
1999         and remove vim modelines on all files I touched. No change in functionality, thus no new tests.
2000
2001         * svg/SVGAElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
2002         * svg/SVGAltGlyphElement.h: Remove virtual contextElement() method.
2003         * svg/SVGAnimatedProperty.h:
2004         (WebCore::::synchronize):
2005         (WebCore::::startAnimation):
2006         (WebCore::::stopAnimation):
2007         * svg/SVGAnimationElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
2008         * svg/SVGCircleElement.h: Ditto.
2009         * svg/SVGClipPathElement.h: Ditto.
2010         * svg/SVGCursorElement.h: Ditto.
2011         * svg/SVGDefsElement.h: Ditto.
2012         * svg/SVGEllipseElement.h: Ditto.
2013         * svg/SVGExternalResourcesRequired.h: Remove pure-virtual contextElement() method.
2014         * svg/SVGFEImageElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
2015         * svg/SVGFELightElement.h: Remove virtual contextElement() method.
2016         * svg/SVGFEMergeNodeElement.h: Ditto.
2017         * svg/SVGFilterElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
2018         * svg/SVGFilterPrimitiveStandardAttributes.h: Remove virtual contextElement() method.
2019         * svg/SVGFitToViewBox.cpp:
2020         (WebCore::SVGFitToViewBox::parseViewBox): Add Document* parameter - we used to fetch the Document pointer from the context element.
2021         (WebCore::SVGFitToViewBox::parseMappedAttribute): Ditto.
2022         * svg/SVGFitToViewBox.h: Remove pure-virtual contextElement() method.
2023         * svg/SVGFontElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
2024         * svg/SVGForeignObjectElement.h: Ditto.
2025         * svg/SVGGElement.h: Ditto.
2026         * svg/SVGGradientElement.h: Ditto.
2027         * svg/SVGImageElement.h: Ditto.
2028         * svg/SVGLineElement.h: Ditto.
2029         * svg/SVGMPathElement.h: Ditto. Fix license indention.
2030         * svg/SVGMarkerElement.cpp:
2031         (WebCore::SVGMarkerElement::parseMappedAttribute): Pass document() to SVGFitToViewBox::parseMappedAttribute().
2032         * svg/SVGMarkerElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
2033         * svg/SVGMaskElement.h: Ditto.
2034         * svg/SVGPathElement.h: Ditto.
2035         * svg/SVGPatternElement.cpp:
2036         (WebCore::SVGPatternElement::parseMappedAttribute): Pass document() to SVGFitToViewBox::parseMappedAttribute().
2037         * svg/SVGPatternElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
2038         * svg/SVGPolyElement.cpp:
2039         (WebCore::SVGPolyElement::updateAnimatedSVGAttribute): synchronizeProperty<...>() has been renamed to PropertySynchronizer<...>::synchronize().
2040         * svg/SVGPolyElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
2041         * svg/SVGRectElement.h: Ditto.
2042         * svg/SVGSVGElement.cpp:
2043         (WebCore::SVGSVGElement::parseMappedAttribute): Pass document() to SVGFitToViewBox::parseMappedAttribute().
2044         * svg/SVGSVGElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
2045         * svg/SVGScriptElement.h: Ditto.
2046         * svg/SVGSwitchElement.h: Ditto.
2047         * svg/SVGSymbolElement.cpp:
2048         (WebCore::SVGSymbolElement::parseMappedAttribute): Pass document() to SVGFitToViewBox::parseMappedAttribute().
2049         * svg/SVGSymbolElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
2050         * svg/SVGTRefElement.h: Remove virtual contextElement() method.
2051         * svg/SVGTextContentElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
2052         * svg/SVGTextPathElement.h: Remove virtual contextElement() method.
2053         * svg/SVGUseElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
2054         * svg/SVGViewElement.cpp:
2055         (WebCore::SVGViewElement::parseMappedAttribute): Pass document() to SVGFitToViewBox::parseMappedAttribute().
2056         * svg/SVGViewElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
2057         * svg/SVGViewSpec.cpp:
2058         (WebCore::SVGViewSpec::setViewBoxString): Pass document() to SVGFitToViewBox::parseMappedAttribute().
2059         (WebCore::SVGViewSpec::parseViewSpec): Ditto.
2060         * svg/SVGViewSpec.h: Devirtualize contextElement() method, it's the only place where contextElement() remains needed.
2061
2062 2009-10-14  Dirk Schulze  <krit@webkit.org>
2063
2064         Reviewed by Nikolas Zimmermann.
2065
2066         SVG Masking with wrong offset
2067         [https://bugs.webkit.org/show_bug.cgi?id=30325]
2068
2069         SVGMaskElement moves the mask image graphics context to the wrong location.
2070         In objectBoundingBoxMode the maskDestRect gets translated. This transformation
2071         is not used in the later calculation. Fix by consistenly calculating the translation
2072         offsets from the final mask destination rect.
2073
2074         Test: svg/custom/mask-with-default-value.svg
2075
2076         * svg/SVGMaskElement.cpp:
2077         (WebCore::SVGMaskElement::drawMaskerContent):
2078
2079 2009-10-14  Kevin Decker  <kdecker@apple.com>
2080
2081         Rubberstamped by Jon Honeycutt.
2082         
2083         Export a few more showSubstituteImage() related methods.
2084         
2085         * WebCore.base.exp:
2086         * WebCore.xcodeproj/project.pbxproj:
2087
2088 2009-10-14  Evan Martin  <evan@chromium.org>
2089
2090         Reviewed by Darin Adler.
2091
2092         Stringify CSS units manually (without printf) to make the formatting
2093         locale-insensitive and obey CSS spec with respect to large values.
2094         
2095         https://bugs.webkit.org/show_bug.cgi?id=18994
2096
2097         * css/CSSPrimitiveValue.cpp:
2098         (WebCore::appendCSSDouble):
2099         (WebCore::formatWithUnits):
2100         (WebCore::CSSPrimitiveValue::cssText):
2101
2102 2009-10-14  Mark Seaborn  <mseaborn@google.com>
2103
2104         Reviewed by Darin Adler.
2105
2106         Check error return value in Perl build script
2107         https://bugs.webkit.org/show_bug.cgi?id=30316
2108
2109         * css/makevalues.pl: Die if gperf fails.
2110
2111 2009-10-14  Dirk Schulze  <krit@webkit.org>
2112
2113         Reviewed by Nikolas Zimmermann.
2114
2115         SVG wrong filterRegions for userSpaceOnUse and percentage values
2116         [https://bugs.webkit.org/show_bug.cgi?id=30330]
2117
2118         Some clean-up of the SVG filter calculation code. This clean-up
2119         also fixes the problem with percentage and userSpaceInUse mode.
2120
2121         Test: svg/filters/subRegion-in-userSpace.svg
2122
2123         * platform/graphics/filters/FilterEffect.cpp:
2124         (WebCore::FilterEffect::FilterEffect):
2125         * platform/graphics/filters/FilterEffect.h:
2126         * rendering/SVGRenderSupport.cpp:
2127         (WebCore::SVGRenderBase::filterBoundingBoxForRenderer):
2128         * svg/SVGFilterElement.cpp:
2129         (WebCore::SVGFilterElement::buildFilter):
2130         (WebCore::SVGFilterElement::canvasResource):
2131         * svg/SVGFilterElement.h:
2132         * svg/SVGFilterPrimitiveStandardAttributes.cpp:
2133         (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
2134         * svg/graphics/SVGResourceFilter.cpp:
2135         (WebCore::SVGResourceFilter::SVGResourceFilter):
2136         (WebCore::SVGResourceFilter::~SVGResourceFilter):
2137         (WebCore::SVGResourceFilter::addFilterEffect):
2138         (WebCore::SVGResourceFilter::prepareFilter):
2139         * svg/graphics/SVGResourceFilter.h:
2140         (WebCore::SVGResourceFilter::create):
2141         * svg/graphics/filters/SVGFilter.cpp:
2142         (WebCore::SVGFilter::SVGFilter):
2143         (WebCore::SVGFilter::calculateEffectSubRegion):
2144         (WebCore::SVGFilter::create):
2145         * svg/graphics/filters/SVGFilter.h:
2146
2147 2009-10-14  Chris Marrin  <cmarrin@apple.com>
2148
2149         The last change fixed the problem, removing diagnostic printfs.
2150
2151         * platform/graphics/mac/GraphicsContext3DMac.cpp:
2152         (WebCore::GraphicsContext3D::GraphicsContext3D):
2153
2154 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
2155
2156         CURL build fix for versions < 7.18.
2157
2158         * platform/network/curl/ResourceHandleCurl.cpp:
2159         (WebCore::ResourceHandle::setDefersLoading):
2160         * platform/network/curl/ResourceHandleManager.cpp:
2161         (WebCore::ResourceHandleManager::initializeHandle):
2162
2163 2009-10-14  Chris Marrin  <cmarrin@apple.com>
2164
2165         One more round of changes to figure out why the webgl 
2166         tests are crashing on the build bot. Here I am trying
2167         to see if we can create a software renderer. I am also
2168         printing the found pixel formats.
2169
2170         * platform/graphics/mac/GraphicsContext3DMac.cpp:
2171         (WebCore::GraphicsContext3D::GraphicsContext3D):
2172
2173 2009-10-14  Yael Aharon  <yael.aharon@nokia.com>
2174  
2175         Reviewed by Simon Hausmann.
2176  
2177         Enabling NPAPI plugin support on Qt Webkit for S60 platform
2178         https://bugs.webkit.org/show_bug.cgi?id=29302
2179
2180         Also implemented by Mahesh Kulkarni<mahesh.kulkarni@nokia.com>, 
2181         Rohini Ananth <rohini.ananth@nokia.com> and help from Norbert Lesr
2182         <norbert.leser@nokia.com>
2183          
2184         * WebCore.pro:
2185         Enabling ENABLE_NETSCAPE_PLUGIN_API for S60 and added S60 specific 
2186         new plugin files to be compiled under symbian: macro
2187
2188         * bridge/npapi.h:
2189         Added NPEvent and NPRegion definition for Symbian
2190
2191         * plugins/PluginPackage.h:
2192         Added S60 specific plugin interface and plugin loader variables
2193         * plugins/PluginPackage.cpp:
2194         (WebCore::PluginPackage::unload): Added !PLATFORM(SYMBIAN) macro.
2195         Default implementation to be used only for non-symbian platform
2196         * plugins/PluginDatabase.cpp:
2197         Macro !SYMBIAN checking
2198         * plugins/PluginView.h:
2199         Add Symbian to platforms that support setNPWindowIfNeeded
2200         * plugins/PluginView.cpp:
2201         (WebCore::PluginView::setFrameRect): Add Symbian to platforms that
2202         call setNPWindowRect from setFrameRect
2203          
2204         Added folder 'symbian' which contains implementation files for S60
2205         platform-specific NPAPI plugin functionality, under /plugins folder
2206         * plugins/symbian
2207         * plugins/symbian/npinterface.h:
2208         Plugin Interface to be implemented by S60 NPAPI plugins 
2209         * plugins/symbian/PluginContainerSymbian.h:
2210         * plugins/symbian/PluginContainerSymbian.cpp:
2211         * plugins/symbian/PluginDatabaseSymbian.cpp:
2212         * plugins/symbian/PluginViewSymbian.cpp:
2213         * plugins/symbian/PluginPackageSymbian.cpp:
2214
2215 2009-10-14  Chris Marrin  <cmarrin@apple.com>
2216
2217         More changes to figure out why the webgl tests are crashing on the build bot.
2218
2219         * platform/graphics/mac/GraphicsContext3DMac.cpp:
2220         (WebCore::GraphicsContext3D::GraphicsContext3D):
2221
2222 2009-10-14  Victor Wang  <victorw@chromium.org>
2223
2224         Reviewed by David Hyatt.
2225
2226         Round non-integer line height values.
2227
2228         Change webkit to rounding non-integer line height values
2229         instead of truncating them. This fixes a layout test
2230         failure on Windows and matches the calculation in IE and Firefox. 
2231
2232         https://bugs.webkit.org/show_bug.cgi?id=24434
2233
2234         Test: fast/css/line-height-rounding.html
2235               fast/forms/textarea-scrollbar-height.htm
2236
2237         * css/CSSComputedStyleDeclaration.cpp:
2238         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2239         * rendering/InlineFlowBox.cpp:
2240         (WebCore::InlineFlowBox::computeLogicalBoxHeights):
2241         * rendering/RenderBR.cpp:
2242         (WebCore::RenderBR::lineHeight):
2243         * rendering/style/RenderStyle.h:
2244         (WebCore::InheritedFlags::computedLineHeight):
2245
2246 2009-10-13  Kelly Norton  <knorton@google.com>
2247
2248         Reviewed by Pavel Feldman.
2249
2250         Removes the persistent setting for InspectorTimelineAgent and renames timeline related
2251         interfaces to be more consistent with the JavaScript profiler.
2252
2253         * inspector/InspectorBackend.cpp:
2254         (WebCore::InspectorBackend::startTimelineProfiler):
2255         (WebCore::InspectorBackend::stopTimelineProfiler):
2256         (WebCore::InspectorBackend::timelineProfilerEnabled):
2257         * inspector/InspectorBackend.h:
2258         * inspector/InspectorBackend.idl:
2259         * inspector/InspectorController.cpp:
2260         (WebCore::InspectorController::setFrontendProxyObject):
2261         (WebCore::InspectorController::startTimelineProfiler):
2262         (WebCore::InspectorController::stopTimelineProfiler):
2263         (WebCore::InspectorController::timelineProfilerEnabled):
2264         * inspector/InspectorController.h:
2265         * inspector/InspectorFrontend.cpp:
2266         (WebCore::InspectorFrontend::timelineProfilerWasStarted):
2267         (WebCore::InspectorFrontend::timelineProfilerWasStopped):
2268         * inspector/InspectorFrontend.h:
2269         * inspector/front-end/TimelineAgent.js:
2270         (WebInspector.timelineProfilerWasStarted):
2271         (WebInspector.timelineProfilerWasStopped):
2272
2273 2009-10-01  Yong Li  <yong.li@torchmobile.com>
2274
2275         Reviewed by Adele Peterson.
2276
2277         Fix crash when loading invalid image data
2278         https://bugs.webkit.org/show_bug.cgi?id=29980
2279
2280         * rendering/RenderImage.cpp:
2281         (WebCore::RenderImage::setImageSizeForAltText):
2282
2283 2009-10-09  Stephen White  <senorblanco@chromium.org>
2284
2285         Reviewed by Eric Seidel.
2286
2287         Fix for NULL ptr deref in canvas's toDataURL().
2288         https://bugs.webkit.org/show_bug.cgi?id=30254
2289
2290         Test: fast/canvas/canvas-toDataURL-crash.html
2291
2292         * html/HTMLCanvasElement.cpp:
2293         (WebCore::HTMLCanvasElement::toDataURL):
2294
2295 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
2296
2297         Not reviewed, reverting r49558 since it broke profiler tests.
2298
2299         https://bugs.webkit.org/show_bug.cgi?id=30328
2300
2301         * bindings/js/JSInspectorBackendCustom.cpp:
2302         * bindings/v8/custom/V8CustomBinding.h:
2303         * inspector/InspectorBackend.cpp:
2304         (WebCore::InspectorBackend::getProfileHeaders):
2305         (WebCore::InspectorBackend::getProfile):
2306         * inspector/InspectorBackend.h:
2307         * inspector/InspectorBackend.idl:
2308         * inspector/InspectorController.cpp:
2309         (WebCore::InspectorController::addProfile):
2310         (WebCore::InspectorController::getProfileHeaders):
2311         (WebCore::InspectorController::getProfile):
2312         (WebCore::InspectorController::createProfileHeader):
2313         * inspector/InspectorController.h:
2314         * inspector/InspectorFrontend.cpp:
2315         (WebCore::InspectorFrontend::addProfileHeader):
2316         (WebCore::InspectorFrontend::didGetProfileHeaders):
2317         (WebCore::InspectorFrontend::didGetProfile):
2318         * inspector/InspectorFrontend.h:
2319         * inspector/JavaScriptProfileNode.cpp:
2320         (WebCore::ProfileNodeClass):
2321         * inspector/front-end/ProfileView.js:
2322         (WebInspector.ProfileView.profileCallback):
2323         (WebInspector.ProfileView):
2324         (WebInspector.ProfileView.prototype._mouseDownInDataGrid):
2325         (WebInspector.ProfileView.prototype._assignParentsInProfile):
2326         * inspector/front-end/ProfilesPanel.js:
2327         (WebInspector.ProfilesPanel.prototype.addProfileHeader):
2328         * inspector/front-end/inspector.js:
2329         (WebInspector.addProfileHeader):
2330
2331 2009-10-13  Holger Hans Peter Freyther  <zecke@selfish.org>
2332
2333         Reviewed by Simon Hausmann.
2334
2335         ImageDecoderQt: Minor tweaks to the decoder
2336
2337         - Only cache the data when we start to use it.
2338         - Start with a repetition count of none for normal images.
2339         - Do not use canRead as this will trigger parsing of the full image
2340         - Cope with a GIF failing to decode the first frame, do not
2341           set m_failed to true if decoding the first frame failed
2342         - Inform the QImageReader about the format that was detected
2343         - Always create a ImageDecoderQt when when we have more
2344         than four byte.
2345
2346
2347         * platform/graphics/qt/ImageDecoderQt.cpp:
2348         (WebCore::ImageDecoder::create): Always create QImageReader for a significant speed up
2349         (WebCore::ImageDecoderQt::ImageDecoderQt): Initialize m_repetitionCount to cAnimationNone
2350         (WebCore::ImageDecoderQt::setData): Only call ImageDecoder::setData when everything has been received
2351         (WebCore::ImageDecoderQt::isSizeAvailable): Do not check m_failed twice.
2352         (WebCore::ImageDecoderQt::filenameExtension): Convert from QByteArray to String
2353         (WebCore::ImageDecoderQt::frameBufferAtIndex): Check for m_failed before trying to decode
2354         (WebCore::ImageDecoderQt::internalDecodeSize): Fail if the size is QSize()
2355         (WebCore::ImageDecoderQt::forceLoadEverything): Handle the case were decoding the first frame fails
2356         * platform/graphics/qt/ImageDecoderQt.h: Change the m_format type
2357
2358 2009-10-14  Mikhail Naganov  <mnaganov@chromium.org>
2359
2360         Reviewed by Pavel Feldman.
2361
2362         Web Inspector: Migrate profiles to the injected script-based schema.
2363
2364         https://bugs.webkit.org/show_bug.cgi?id=30328
2365
2366         * bindings/js/JSInspectorBackendCustom.cpp:
2367         * bindings/v8/custom/V8CustomBinding.h:
2368         * inspector/InspectorBackend.cpp:
2369         (WebCore::InspectorBackend::getProfileHeaders):
2370         (WebCore::InspectorBackend::getProfile):
2371         * inspector/InspectorBackend.h:
2372         * inspector/InspectorBackend.idl:
2373         * inspector/InspectorController.cpp:
2374         (WebCore::InspectorController::addProfile):
2375         (WebCore::InspectorController::getProfileHeaders):
2376         (WebCore::InspectorController::getProfile):
2377         (WebCore::InspectorController::createProfileHeader):
2378         * inspector/InspectorController.h:
2379         * inspector/InspectorFrontend.cpp:
2380         (WebCore::InspectorFrontend::addProfileHeader):
2381         (WebCore::InspectorFrontend::didGetProfileHeaders):
2382         (WebCore::InspectorFrontend::didGetProfile):
2383         * inspector/InspectorFrontend.h:
2384         * inspector/JavaScriptProfileNode.cpp:
2385         (WebCore::ProfileNodeClass):
2386         * inspector/front-end/ProfileView.js:
2387         (WebInspector.ProfileView.profileCallback):
2388         (WebInspector.ProfileView):
2389         (WebInspector.ProfileView.prototype._mouseDownInDataGrid):
2390         (WebInspector.ProfileView.prototype._assignParentsInProfile):
2391         * inspector/front-end/ProfilesPanel.js:
2392         (WebInspector.ProfilesPanel.prototype.addProfileHeader):
2393         * inspector/front-end/inspector.js:
2394         (WebInspector.addProfileHeader):
2395
2396 2009-10-13  Yury Semikhatsky  <yurys@chromium.org>
2397
2398         Reviewed by Pavel Feldman.
2399
2400         Don't collect call frame properties until they're needed for completion.
2401
2402         https://bugs.webkit.org/show_bug.cgi?id=30334
2403
2404         * inspector/front-end/ConsoleView.js:
2405         (WebInspector.ConsoleView.prototype.completions):
2406         * inspector/front-end/InjectedScript.js:
2407         (InjectedScript.getCompletions): if call frame id is specified and the expression is empty collect frame properties.
2408         (InjectedScript.CallFrameProxy.prototype._wrapScopeChain): don't send call frame properties until they're needed.
2409         * inspector/front-end/ScriptsPanel.js:
2410
2411 >>>>>>> .r49765
2412 2009-10-13  Yongjun Zhang  <yongjun.zhang@nokia.com>
2413
2414         Reviewed by Ariya Hidayat.
2415
2416         https://bugs.webkit.org/show_bug.cgi?id=29106
2417         [Qt] make CachedResourceHandle.h compile in winscw Symbian compiler.
2418
2419         Don't inline constructor CachedResourceHandle<T>(R*) to stop winscw
2420         compiler aggressively resolve inheritance of class R.  
2421         
2422         The winscw compiler bug is reported at:
2423         https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=9812.
2424         
2425         The change should be reverted when the above bug is fixed in winscw compiler.
2426
2427         * loader/CachedResourceHandle.h:
2428         (WebCore::::CachedResourceHandle):
2429
2430 2009-10-13  Dimitri Glazkov  <dglazkov@chromium.org>
2431
2432         No review, rolling out r49554, because it broke Win and Chromium builds.
2433         http://trac.webkit.org/changeset/49554
2434
2435         * css/CSSPrimitiveValue.cpp:
2436         (WebCore::CSSPrimitiveValue::cssText):
2437
2438 2009-10-13  Evan Martin  <evan@chromium.org>
2439
2440         Reviewed by Adam Barth.
2441
2442         Stringify CSS units manually (without printf) to make the formatting
2443         locale-insensitive and obey CSS spec with respect to large values.
2444         
2445         https://bugs.webkit.org/show_bug.cgi?id=18994
2446
2447         * css/CSSPrimitiveValue.cpp:
2448         (WebCore::appendCSSDouble):
2449         (WebCore::formatWithUnits):
2450         (WebCore::CSSPrimitiveValue::cssText):
2451
2452 2009-10-13  Evan Martin  <evan@chromium.org>
2453
2454         Reviewed by David Levin.
2455
2456         Make grippy lines vertical on horizontal scrollbars in Linux Chrome.
2457         While we're rebaselining scrollbars, fix an off by one in the vertical
2458         scrollbar rendering too.
2459
2460         https://bugs.webkit.org/show_bug.cgi?id=30319
2461
2462         Tests: this is covered by every pixel test involving scrollbars.
2463
2464         * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
2465         (WebCore::ScrollbarThemeChromiumLinux::paintThumb):
2466
2467 2009-10-13  Sam Weinig  <sam@webkit.org>
2468
2469         Reviewed by David Hyatt.
2470
2471         Fix issue where clientX and clientY on MouseEvents were wrong when
2472         the page was zoomed and scrolled.
2473
2474         Test: fast/events/clientXY-in-zoom-and-scroll.html
2475
2476         * dom/MouseRelatedEvent.cpp:
2477         (WebCore::contentsX): Take page zoom into account.
2478         (WebCore::contentsY): Ditto.
2479
2480 2009-10-13  Dave Hyatt  <hyatt@apple.com>
2481
2482         Reviewed by Adam Roben.
2483
2484         Change the order of arguments on some of the user stylesheet/script functions.  Split the removal functions
2485         out into separate ones for scripts and stylesheets.
2486
2487         * WebCore.base.exp:
2488         * page/PageGroup.cpp:
2489         (WebCore::PageGroup::addUserScriptToWorld):
2490         (WebCore::PageGroup::addUserStyleSheetToWorld):
2491         (WebCore::PageGroup::removeUserScriptFromWorld):
2492         (WebCore::PageGroup::removeUserStyleSheetFromWorld):
2493         (WebCore::PageGroup::removeUserScriptsFromWorld):
2494         (WebCore::PageGroup::removeUserStyleSheetsFromWorld):
2495         * page/PageGroup.h:
2496         (WebCore::PageGroup::userScripts):
2497         (WebCore::PageGroup::userStyleSheets):
2498
2499 2009-10-13  Evan Martin  <evan@chromium.org>
2500
2501         Reviewed by Dmitry Titov.
2502
2503         Chrome's "Skia" theme paints select controls backwards in RTL.
2504
2505         https://bugs.webkit.org/show_bug.cgi?id=30320
2506
2507         Test: fast/text/international/bidi-menulist.html
2508         (The test is about something else, but it includes RTL selects.)
2509
2510         * rendering/RenderThemeChromiumSkia.cpp:
2511         (WebCore::RenderThemeChromiumSkia::paintMenuList): flip the arrow position in RTL case.
2512
2513 2009-10-13  Dmitry Titov  <dimich@chromium.org>
2514
2515         Reviewed by Alexey Proskuryakov.
2516
2517         https://bugs.webkit.org/show_bug.cgi?id=30318
2518         ScriptExecutionContext is not anymore needed to create an EventListener - remove old code.
2519         It's a followup to r48884. It removed the need to pass the ScritpExecutionContext
2520         into EventListener constructor but did not remove the code pulling ScriptExecutionContext.
2521
2522         Tests:
2523         Test adds event listener to a DocumentType Node which is created without a document
2524         and then dispatches the event after attaching a node to the tree. Event
2525         should fire when node is attached to the tree.
2526
2527         * fast/events/add-event-without-document-expected.txt: Added.
2528         * fast/events/add-event-without-document.html: Added.
2529
2530         All changes in files below are the same - remove the code that calls
2531         EventTarget::scriptExecutionContext and checks it for NULL.
2532
2533         * bindings/js/JSAbstractWorkerCustom.cpp:
2534         (WebCore::JSAbstractWorker::addEventListener):
2535         (WebCore::JSAbstractWorker::removeEventListener):
2536         * bindings/js/JSDOMApplicationCacheCustom.cpp:
2537         (WebCore::JSDOMApplicationCache::addEventListener):
2538         (WebCore::JSDOMApplicationCache::removeEventListener):
2539         * bindings/js/JSDesktopNotificationsCustom.cpp:
2540         (WebCore::JSNotification::addEventListener):
2541         (WebCore::):
2542         * bindings/js/JSEventSourceCustom.cpp:
2543         (WebCore::JSEventSource::addEventListener):
2544         (WebCore::JSEventSource::removeEventListener):
2545         * bindings/js/JSMessagePortCustom.cpp:
2546         (WebCore::JSMessagePort::addEventListener):
2547         (WebCore::JSMessagePort::removeEventListener):
2548         * bindings/js/JSNodeCustom.cpp:
2549         (WebCore::JSNode::addEventListener):
2550         (WebCore::JSNode::removeEventListener):
2551         * bindings/js/JSSVGElementInstanceCustom.cpp:
2552         (WebCore::JSSVGElementInstance::addEventListener):
2553         (WebCore::JSSVGElementInstance::removeEventListener):
2554         * bindings/js/JSXMLHttpRequestCustom.cpp:
2555         (WebCore::JSXMLHttpRequest::addEventListener):
2556         (WebCore::JSXMLHttpRequest::removeEventListener):
2557         * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
2558         (WebCore::JSXMLHttpRequestUpload::addEventListener):
2559         (WebCore::JSXMLHttpRequestUpload::removeEventListener):
2560         * bindings/js/JSWebSocketCustom.cpp:
2561         (WebCore::JSWebSocket::addEventListener):
2562         (WebCore::JSWebSocket::removeEventListener):
2563
2564 2009-10-13  Drew Wilson  <atwilson@atwilson-macpro.local>
2565
2566         Reviewed by David Levin.
2567
2568         Enable SHARED_WORKERS for Chromium
2569         https://bugs.webkit.org/show_bug.cgi?id=30289
2570
2571         Cleaned up bitrot in SharedWorker V8 bindings.
2572
2573         * WebCore.gypi:
2574         Removed default implementation of SharedWorkerRepository so Chromium can provide its own.
2575         * bindings/v8/DerivedSourcesAllInOne.cpp:
2576         Added V8SharedWorkerContext.cpp.
2577         * bindings/v8/V8DOMWrapper.cpp:
2578         (WebCore::V8DOMWrapper::getTemplate):
2579         Added case statements for SHAREDWORKER and SHAREDWORKERCONTEXT.
2580         * bindings/v8/V8Index.cpp:
2581         Now includes V8SharedWorkerContext.h to allow supporting SharedWorkers.
2582         * bindings/v8/V8Index.h:
2583         Added definition for SHAREDWORKERCONTEXT wrapper.
2584         * bindings/v8/WorkerContextExecutionProxy.cpp:
2585         Added includes for SharedWorker.h and SharedWorkerContext.h.
2586         * bindings/v8/custom/V8CustomBinding.h:
2587         Reorganized Worker field indexes to be clearer, and fixed mismatch in worker field index.
2588         Also added field indexes for SharedWorkers.
2589         * bindings/v8/custom/V8DOMWindowCustom.cpp:
2590         (WebCore::ACCESSOR_RUNTIME_ENABLER):
2591         Added runtime enabler for the SharedWorker constructor.
2592         * bindings/v8/custom/V8SharedWorkerCustom.cpp:
2593         (WebCore::CALLBACK_FUNC_DECL):
2594         Cleaned up bitrot (various APIs have changed since this file was written).
2595         * page/DOMWindow.idl:
2596         Added EnabledAtRuntime flag to window.SharedWorker.
2597
2598 2009-10-13  Alexey Proskuryakov  <ap@apple.com>
2599
2600         Reviewed by Brady Eidson.
2601
2602         https://bugs.webkit.org/show_bug.cgi?id=30345
2603         HTTP tests for credential handling fail on Tiger
2604
2605         We cannot prevent NSURLConnection from doing its credentil handling on Tiger anyway; so
2606         let it do its work without intervention. Once again, we pass explicitly passed credentials
2607         in URL, fixing regressions from Safari 3.
2608
2609         * platform/network/mac/ResourceHandleMac.mm:
2610         (WebCore::ResourceHandle::start):
2611         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
2612         (WebCore::ResourceHandle::receivedCredential):
2613
2614 2009-10-13  Roland Steiner  <rolandsteiner@google.com>
2615
2616         Reviewed by Adam Barth.
2617
2618         Bug 28964 -  [Chromium] ChromiumDataObject should have getter/setter interface
2619
2620         Reworked and added to the getter/setter interface in ChromiumDataObject:
2621         - added contains...() methods to just query the state
2622         - added containsValid...URL() methods for URL data members
2623         - removed takeFileNames() as this was too type-dependent
2624         - changed return type of fileNames() to Vector<String>
2625         - added interface methods to allow appending to and iteration over file names
2626
2627         No new tests (no functional behavior changed).
2628
2629         * platform/chromium/ChromiumDataObject.h:
2630         (WebCore::ChromiumDataObject::containsMainURL):
2631         (WebCore::ChromiumDataObject::containsValidMainURL):
2632         (WebCore::ChromiumDataObject::containsMainURLTitle):
2633         (WebCore::ChromiumDataObject::containsTextPlain):
2634         (WebCore::ChromiumDataObject::containsTextHTML):
2635         (WebCore::ChromiumDataObject::containsHTMLBaseURL):
2636         (WebCore::ChromiumDataObject::containsValidHTMLBaseURL):
2637         (WebCore::ChromiumDataObject::containsContent):
2638         (WebCore::ChromiumDataObject::containsContentFileExtension):
2639         (WebCore::ChromiumDataObject::containsContentFileName):
2640         (WebCore::ChromiumDataObject::setContentFileName):
2641         (WebCore::ChromiumDataObject::containsFileNames):
2642         (WebCore::ChromiumDataObject::fileNames):
2643         (WebCore::ChromiumDataObject::clearFileNames):
2644         (WebCore::ChromiumDataObject::countFileNames):
2645         (WebCore::ChromiumDataObject::fileNameAt):
2646         (WebCore::ChromiumDataObject::setFileNames):
2647         (WebCore::ChromiumDataObject::appendToFileNames):
2648         (WebCore::ChromiumDataObject::popFileName):
2649
2650 2009-10-13  Simon Fraser  <simon.fraser@apple.com>
2651
2652         Temporary debugging changes to figure out why the webgl tests are crashing on the build bot.
2653
2654         * platform/graphics/mac/GraphicsContext3DMac.cpp:
2655         (WebCore::GraphicsContext3D::GraphicsContext3D):
2656
2657 2009-10-13  Simon Fraser  <simon.fraser@apple.com>
2658
2659         Reviewed by Dan Bernstein.
2660
2661         Visibility:visible inside a compositing layer doesn't make the element visible
2662         https://bugs.webkit.org/show_bug.cgi?id=30339
2663         
2664         When deciding if a layer had any renderable content, RenderLayerBacking::paintIntoLayer()
2665         only consulted hasVisibleContent(), which does not take into a account child layers which
2666         may be visible. We also have to consult hasVisibleDescendant() as well.
2667
2668         Test: compositing/compositing-visible-descendant.html
2669
2670         * rendering/RenderLayer.h:
2671         (WebCore::RenderLayer::hasVisibleDescendant):
2672         * rendering/RenderLayerBacking.cpp:
2673         (WebCore::RenderLayerBacking::paintIntoLayer):
2674
2675 2009-10-13  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2676
2677         Reviewed by Simon Hausmann.
2678
2679         Refactor ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH
2680         https://bugs.webkit.org/show_bug.cgi?id=30278
2681
2682         Move the definition of ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH 
2683         from the make system into common code.
2684
2685         Enable ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH if NETSCAPE_PLUGIN_API 
2686         support is not enabled.
2687
2688         Remove notImplemented() from PluginPackageNone.cpp and 
2689         PluginDataNone.cpp make them just empty functions.
2690
2691         * GNUmakefile.am:
2692         * WebCore.pro:
2693         * plugins/PluginDataNone.cpp:
2694         (WebCore::PluginData::initPlugins):
2695         (WebCore::PluginData::refresh):
2696         * plugins/PluginPackageNone.cpp:
2697         (WebCore::PluginPackage::determineQuirks):
2698         (WebCore::PluginPackage::fetchInfo):
2699         (WebCore::PluginPackage::load):
2700
2701 2009-10-13  Alexey Proskuryakov  <ap@apple.com>
2702
2703         Reviewed by Dan Bernstein.
2704
2705         https://bugs.webkit.org/show_bug.cgi?id=30150
2706         <rdar://problem/7283540> REGRESSION: Crash when accessing clipboardData.types
2707
2708         Test: editing/pasteboard/crash-accessing-clipboardData-types.html
2709
2710         * platform/mac/ClipboardMac.mm: (WebCore::addHTMLClipboardTypesForCocoaType): The String
2711         class doesn't have operator bool, it's operator NSString* that is invoked instead, and it
2712         converts null strings to non-null @"".
2713
2714 2009-10-13  Drew Wilson  <atwilson@atwilson-macpro.local>
2715
2716         Reviewed by Dimitri Glazkov.
2717
2718         window attributes (like localStorage) that are disabled at runtime are still visible
2719         https://bugs.webkit.org/show_bug.cgi?id=30240
2720
2721         Adding codegen/bindings to support runtime disabling of attributes.
2722
2723         No new tests (only supported by chrome currently)
2724
2725         * bindings/scripts/CodeGeneratorV8.pm:
2726         Refactored the guts of GenerateBatchedAttributeData into a separate GenerateSingleBatchedAttribute with a passed-in indentation level to allow generating a single BatchedAttribute struct.
2727         Added support for the EnabledAtRuntime extended attribute, which generates a call to the appropriate XXXXEnabled() API before adding the attribute to the instance.
2728         * bindings/v8/V8Proxy.cpp:
2729         (WebCore::batchConfigureAttributes):
2730         Refactored attribute setting code into a common inline routine.
2731         * bindings/v8/V8Proxy.h:
2732         (WebCore::configureAttribute):
2733         Inline function which configures a single attribute given a BatchedAttribute struct.
2734         * bindings/v8/custom/V8CustomBinding.h:
2735         Added (DECLARE_)ACCESSOR_RUNTIME_ENABLER to allow enabling attributes at runtime.
2736         * bindings/v8/custom/V8DOMWindowCustom.cpp:
2737         Added code to enable window.Audio only if MediaPlayer.isAvailable() == true
2738         * page/DOMWindow.idl:
2739         Added [EnabledAtRuntime] extended attribute to the Audio attribute.
2740
2741 2009-10-13  Michelangelo De Simone  <micdesim@gmail.com>
2742
2743         Reviewed by Adam Barth.
2744
2745         https://bugs.webkit.org/show_bug.cgi?id=27457
2746         Added support for static validation on type=email input elements as per
2747         HTML5 specs:
2748         http://www.whatwg.org/specs/web-apps/current-work/#e-mail-state
2749
2750         Test: fast/forms/ValidityState-typeMismatch-email.html
2751
2752         * html/ValidityState.cpp:
2753         (WebCore::ValidityState::typeMismatch): ValidityState.typeMismatch
2754         performs validation on type=email input elements now.
2755         (WebCore::ValidityState::isValidEmailAddress): simple validation method 
2756         * html/ValidityState.h:
2757
2758 2009-10-13  Dmitry Titov  <dimich@chromium.org>
2759
2760         Reviewed by Adam Barth.
2761
2762         Event listeners installed on a window object returned from window.open() don't work
2763         https://bugs.webkit.org/show_bug.cgi?id=28716
2764
2765         Tests: http/tests/security/window-events-clear-domain.html
2766                http/tests/security/window-events-clear-port.html
2767                http/tests/security/window-events-pass.html
2768
2769         * dom/Document.cpp: Split code of Document::clear() in a way to avoid removing all
2770         window event handlers when implicitOpen is called. It is called in 2 cases - on
2771         committing loaded content (no need to clean handlers) and on document.open() (needs to remove handlers).
2772
2773         (WebCore::Document::open): in addition to calling implicitOpen it also removes window
2774         event handlers, to preserve the behavior of document.open().
2775
2776         (WebCore::Document::implicitOpen): includes the part of removed Document::clear() that
2777         does not remove window event handlers.
2778
2779         * dom/Document.h: Removed clear().
2780
2781         * loader/FrameLoader.cpp:
2782         (WebCore::FrameLoader::stopLoading): add check to avoid removing window event handlers
2783         if we transition from temporary empty document to a loaded one.
2784
2785         (WebCore::FrameLoader::didOpenURL): Remove closeURL() which was called twice when loading.
2786         (WebCore::FrameLoader::finishedLoadingDocument): add closeURL() to compensate for change above.
2787
2788 2009-10-13  Brian Weinstein  <bweinstein@apple.com>
2789
2790         Reviewed by Pavel Feldman.
2791
2792         Fix a leak in the inspector by calling didRemoveNode with
2793         an error code when it fails, instead of returning from the
2794         Backend.
2795
2796         * inspector/InspectorBackend.cpp:
2797         (WebCore::InspectorBackend::removeNode):
2798         * inspector/front-end/ElementsTreeOutline.js:
2799
2800 2009-10-13  Brian Weinstein  <bweinstein@apple.com>
2801
2802         Reviewed by Timothy Hatcher.
2803
2804         Fixes <https://bugs.webkit.org/show_bug.cgi?id=30337>.
2805         Web Inspector: Should be able to delete nodes from the Elements Tree.
2806         
2807         When the delete key is pressed and a element is selected in the tree,
2808         the element should be deleted from the Elements Tree and the DOM.
2809
2810         * inspector/InspectorBackend.cpp:
2811         (WebCore::InspectorBackend::removeNode):
2812         * inspector/InspectorBackend.h:
2813         * inspector/InspectorBackend.idl:
2814         * inspector/InspectorFrontend.cpp:
2815         (WebCore::InspectorFrontend::didRemoveNode):
2816         * inspector/InspectorFrontend.h:
2817         * inspector/front-end/ElementsPanel.js:
2818         (WebInspector.ElementsPanel.prototype._updateModifiedNodes):
2819         * inspector/front-end/ElementsTreeOutline.js:
2820         (WebInspector.ElementsTreeOutline.prototype.handleKeyEvent):
2821
2822 2009-10-13  Brian Weinstein  <bweinstein@apple.com>
2823
2824         Reviewed by Timothy Hatcher.
2825
2826         Fix REGRESSION(49479): Mouseover on resources graph doesn't show timings.
2827         
2828         Set pointer-events: none on the new overlay so mouseover events are passed
2829         to the resources graph so we can show timings.
2830
2831         * inspector/front-end/inspector.css:
2832
2833 2009-10-13  Girish Ramakrishnan  <girish@forwardbias.in>
2834
2835         Reviewed by Simon Hausmann.
2836
2837         [Qt] Plugins : Remove all traces of winId. Use ownerWidget() instead.
2838         
2839         This is a bug for two reasons:
2840         1. Everytime we use winId(), we end up creating a native widget. This causes an
2841         unnecessary copy of contents from the backing store to the native widget.
2842         2. Neither windowed nor windowless plugins require the winId of the QWebView or
2843         QGraphicsView.
2844         
2845         Introduce ownerWidget() which returns a QWidget * without creating a native widget
2846         (as opposed to QWidget::find(winId)).
2847
2848        https://bugs.webkit.org/show_bug.cgi?id=30170
2849
2850         * platform/qt/PlatformScreenQt.cpp:
2851         (WebCore::screenDepthPerComponent):
2852         * platform/qt/PopupMenuQt.cpp:
2853         (WebCore::PopupMenu::show):
2854         * platform/qt/QWebPageClient.h:
2855         * plugins/qt/PluginViewQt.cpp:
2856         (WebCore::setSharedXEventFields):
2857         (WebCore::PluginView::initXEvent):
2858         (WebCore::PluginView::getValue):
2859         (WebCore::PluginView::platformStart):
2860
2861 2009-10-13  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2862
2863         Unreviewed build system fix. Typo in a filename.
2864
2865         * GNUmakefile.am:
2866
2867 2009-10-12  Alexander Pavlov  <apavlov@chromium.org>
2868
2869         Reviewed by Timothy Hatcher.
2870         Alter profile link format to enable multiple profile types
2871         https://bugs.webkit.org/show_bug.cgi?id=30253
2872
2873         The new profile URL includes the profile type along with the
2874         profile title and uid.
2875
2876         * inspector/InspectorController.cpp:
2877         (WebCore::InspectorController::addProfileFinishedMessageToConsole):
2878         (WebCore::InspectorController::addStartProfilingMessageToConsole):
2879         * inspector/front-end/inspector.js:
2880         (WebInspector.documentClick.followLink):
2881         (WebInspector.documentClick):
2882         (WebInspector.linkifyStringAsFragment):
2883
2884 2009-10-12  Alexander Pavlov  <apavlov@chromium.org>
2885
2886         Reviewed by Timothy Hatcher.
2887
2888         Fix same-named profiles grouping in the Profiles panel.
2889
2890         The tree node re-parenting while adding a new group node was broken.
2891          
2892         https://bugs.webkit.org/show_bug.cgi?id=30299
2893
2894         * inspector/front-end/ProfilesPanel.js:
2895         (WebInspector.ProfilesPanel.prototype.addProfile):
2896
2897 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
2898
2899         Reviewed by Timothy Hatcher.
2900
2901         Web Inspector: Enforce async interaction between inspector controller and frontend.
2902
2903         https://bugs.webkit.org/show_bug.cgi?id=30300
2904
2905         * inspector/front-end/inspector.js:
2906         (WebInspector.dispatch.delayDispatch):
2907         (WebInspector.dispatch):
2908
2909 2009-10-12  Xiaomei Ji  <xji@chromium.org>
2910
2911         Reviewed by Sam Weinig.
2912
2913         Fix issue caretRangeFromPoint() returns wrong result for a zoomed and 
2914         scrolled page.
2915         https://bugs.webkit.org/show_bug.cgi?id=30034
2916
2917         * dom/Document.cpp:
2918         (WebCore::Document::elementFromPoint): calculate the correct point 
2919         relative to document when the page is zoomed and scrolled.
2920         (WebCore::Document::caretRangeFromPoint): calculate the correct point 
2921         relative to document when the page is zoomed and scrolled.
2922
2923 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
2924
2925         Reviewed by Sam Weinig.
2926
2927         JavaScript bindings of WebSocket addEventListener/removeEventListener
2928         https://bugs.webkit.org/show_bug.cgi?id=29841
2929
2930         Test: fast/websockets/websocket-event-target.html
2931
2932         * bindings/js/JSWebSocketCustom.cpp:
2933         (WebCore::JSWebSocket::addEventListener):
2934         (WebCore::JSWebSocket::removeEventListener):
2935         * bindings/v8/custom/V8CustomBinding.h:
2936         * bindings/v8/custom/V8WebSocketCustom.cpp:
2937         (WebCore::CALLBACK_FUNC_DECL):
2938         * websockets/WebSocket.idl:
2939
2940 2009-10-12  Sam Weinig  <sam@webkit.org>
2941
2942         Reviewed by Darin Adler.
2943
2944         Fix for https://bugs.webkit.org/show_bug.cgi?id=29078
2945         <rdar://problem/7288221>
2946
2947         Add a mechanism to blacklist certain codecs.  Initially, just blacklist UTF-7 as HTML5 encourages.
2948
2949         * platform/text/TextEncodingRegistry.cpp:
2950         (WebCore::pruneBlacklistedCodecs):
2951         (WebCore::buildBaseTextCodecMaps):
2952         (WebCore::extendTextCodecMaps):
2953
2954 2009-10-09  Dave Hyatt  <hyatt@apple.com>
2955
2956         Reviewed by Darin Adler.
2957
2958         Add support for the beforeload event to frames.  Complete support of the beforeload event by making sure
2959         its wrapper gets properly constructed (so that the URL field of the event can be accessed).  Add support
2960         for the Objective-C wrapper class as well.
2961
2962         Added fast/dom/beforeload/frame-before-load.html
2963
2964         * WebCore.xcodeproj/project.pbxproj:
2965         * bindings/js/JSEventCustom.cpp:
2966         (WebCore::toJS):
2967         * bindings/objc/DOMEvents.mm:
2968         (kitClass):
2969         * dom/BeforeLoadEvent.h:
2970         (WebCore::BeforeLoadEvent::isBeforeLoadEvent):
2971         * dom/Event.cpp:
2972         (WebCore::Event::isBeforeLoadEvent):
2973         * dom/Event.h:
2974         * html/HTMLFrameElementBase.cpp:
2975         (WebCore::HTMLFrameElementBase::parseMappedAttribute):
2976         * loader/FrameLoader.cpp:
2977         (WebCore::FrameLoader::loadWithDocumentLoader):
2978
2979 2009-10-12  Dan Bernstein  <mitz@apple.com>
2980
2981         Reviewed by Simon Fraser.
2982
2983         Fix <rdar://problem/7094146> Reproducible crash at
2984         RenderObject::localToAbsolute()
2985
2986         Test: fast/dynamic/position-absolute-to-fixed-crash.html
2987
2988         The crash was caused by stale positioned objects lists following an
2989         object transitioning from being absolutely position to being fixed
2990         positioned.
2991
2992         * rendering/RenderBox.cpp:
2993         (WebCore::RenderBox::styleWillChange): In case of a transition between
2994         absolute and fixed position, mark the parent as having a child needing
2995         layout, so that this object will get inserted into its new container's
2996         positioned objects list.
2997         * rendering/RenderObject.cpp:
2998         (WebCore::RenderObject::styleWillChange): Changed a condition to cover
2999         this transition, so that this object gets removed from its current
3000         container's positioned objects list.
3001
3002 2009-10-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3003
3004         Reviewed by Simon Hausmann.
3005
3006         Add a palette() method that is needed by our RenderTheme.
3007
3008         * platform/qt/QWebPageClient.h:
3009
3010 2009-10-12  Dirk Schulze  <krit@webkit.org>
3011
3012         Reviewed by Nikolas Zimmermann.
3013
3014         SVG Gradients can't handle percentage values in userSpaceOnUse mode
3015         [https://bugs.webkit.org/show_bug.cgi?id=30286]
3016
3017         Fixed *GradientAttributes to take SVGLength instead of double. This casues
3018         the problem, that we can't calculate the correct size of a gradient on
3019         userSpaceOnUse mode with percentage values.
3020
3021         Test: svg/custom/gradient-userSpaceOnUse-with-percentage.svg
3022
3023         * svg/LinearGradientAttributes.h:
3024         (WebCore::LinearGradientAttributes::LinearGradientAttributes):
3025         (WebCore::LinearGradientAttributes::x1):
3026         (WebCore::LinearGradientAttributes::y1):
3027         (WebCore::LinearGradientAttributes::x2):
3028         (WebCore::LinearGradientAttributes::y2):
3029         (WebCore::LinearGradientAttributes::setX1):
3030         (WebCore::LinearGradientAttributes::setY1):
3031         (WebCore::LinearGradientAttributes::setX2):
3032         (WebCore::LinearGradientAttributes::setY2):
3033         * svg/RadialGradientAttributes.h:
3034         (WebCore::RadialGradientAttributes::RadialGradientAttributes):
3035         (WebCore::RadialGradientAttributes::cx):
3036         (WebCore::RadialGradientAttributes::cy):
3037         (WebCore::RadialGradientAttributes::r):
3038         (WebCore::RadialGradientAttributes::fx):
3039         (WebCore::RadialGradientAttributes::fy):
3040         (WebCore::RadialGradientAttributes::setCx):
3041         (WebCore::RadialGradientAttributes::setCy):
3042         (WebCore::RadialGradientAttributes::setR):
3043         (WebCore::RadialGradientAttributes::setFx):
3044         (WebCore::RadialGradientAttributes::setFy):
3045         * svg/SVGLinearGradientElement.cpp:
3046         (WebCore::SVGLinearGradientElement::buildGradient):
3047         (WebCore::SVGLinearGradientElement::collectGradientProperties):
3048         * svg/SVGRadialGradientElement.cpp:
3049         (WebCore::SVGRadialGradientElement::buildGradient):
3050         (WebCore::SVGRadialGradientElement::collectGradientProperties):
3051
3052 2009-10-12  Brian Weinstein  <bweinstein@apple.com>
3053
3054         Reviewed by Timothy Hatcher.
3055
3056         Fixes <http://webkit.org/b/30315>.
3057         Web Inspector: DOM Content and Load lines in Resources are unclear what they mean.
3058         
3059         Add tooltip text to the Load event and DOM Content event lines through
3060         a new layer that allows these lines to be on top of the view.
3061
3062         * inspector/front-end/ResourcesPanel.js:
3063         (WebInspector.ResourcesPanel.prototype._updateGraphDividersIfNeeded):
3064         (WebInspector.ResourcesPanel.prototype._updateDividersLabelBarPosition):
3065         * inspector/front-end/inspector.css:
3066
3067 2009-10-12  Dimitri Glazkov  <dglazkov@chromium.org>
3068
3069         No review, rolling out r49429, because it broke layout tests.
3070         http://trac.webkit.org/changeset/49429
3071
3072         * bindings/v8/V8AbstractEventListener.cpp:
3073         (WebCore::V8AbstractEventListener::~V8AbstractEventListener):
3074
3075 2009-10-12  Dirk Schulze  <krit@webkit.org>
3076
3077         Reviewed by Eric Seidel.
3078
3079         SVG - crash on feMerge when input not available
3080         [https://bugs.webkit.org/show_bug.cgi?id=30297]
3081
3082         Make a early return in SVGFEMergeElement if the needed
3083         filter effect doesn't exist.
3084
3085         Test: svg/filters/feMerge-wrong-input.svg
3086
3087         * svg/SVGFEMergeElement.cpp:
3088         (WebCore::SVGFEMergeElement::build):
3089
3090 2009-10-12  Chris Marrin  <cmarrin@apple.com>
3091
3092         Reviewed by Oliver Hunt.
3093
3094         Added automatic flush before compositing
3095         https://bugs.webkit.org/show_bug.cgi?id=30236
3096
3097         This causes image to always render correctly. In writing a testcase
3098         I needed to implement readPixels. This exposed a bug in reading back
3099         values from a CanvasArray subclass, so I fixed that as well. Now when
3100         you wrap a CanvasArray in a JSValue it actually wraps the specific
3101         subclass. To do this I need to add virtual methods to each CanvasArray
3102         subclass to determine the type and a custom toJS method for CanvasArray
3103         to create the proper wrapper. 
3104
3105         Test: fast/canvas/webgl/triangle.html
3106
3107         * WebCore.xcodeproj/project.pbxproj:
3108         * bindings/js/JSCanvasArrayCustom.cpp:
3109         (WebCore::toJS):
3110         * html/canvas/CanvasArray.h:
3111         (WebCore::CanvasArray::isByteArray):
3112         (WebCore::CanvasArray::isUnsignedByteArray):
3113         (WebCore::CanvasArray::isShortArray):
3114         (WebCore::CanvasArray::isUnsignedShortArray):
3115         (WebCore::CanvasArray::isIntArray):
3116         (WebCore::CanvasArray::isUnsignedIntArray):
3117         (WebCore::CanvasArray::isFloatArray):
3118         * html/canvas/CanvasArray.idl:
3119         * html/canvas/CanvasByteArray.h:
3120         (WebCore::CanvasByteArray::isByteArray):
3121         * html/canvas/CanvasFloatArray.h:
3122         (WebCore::CanvasFloatArray::isFloatArray):
3123         * html/canvas/CanvasIntArray.h:
3124         (WebCore::CanvasIntArray::isIntArray):
3125         * html/canvas/CanvasRenderingContext3D.cpp:
3126         (WebCore::CanvasRenderingContext3D::readPixels):
3127         * html/canvas/CanvasRenderingContext3D.h:
3128         * html/canvas/CanvasRenderingContext3D.idl:
3129         * html/canvas/CanvasShortArray.h:
3130         (WebCore::CanvasShortArray::isShortArray):
3131         * html/canvas/CanvasUnsignedByteArray.h:
3132         (WebCore::CanvasUnsignedByteArray::isUnsignedByteArray):
3133         * html/canvas/CanvasUnsignedIntArray.h:
3134         (WebCore::CanvasUnsignedIntArray::isUnsignedIntArray):
3135         * html/canvas/CanvasUnsignedShortArray.h:
3136         (WebCore::CanvasUnsignedShortArray::isUnsignedShortArray):
3137         * platform/graphics/GraphicsContext3D.h:
3138         * platform/graphics/mac/Canvas3DLayer.mm:
3139         (-[Canvas3DLayer drawInCGLContext:pixelFormat:forLayerTime:displayTime:]):
3140         * platform/graphics/mac/GraphicsContext3DMac.cpp:
3141         (WebCore::GraphicsContext3D::readPixels):
3142
3143 2009-10-12  Sebastian Dröge  <sebastian.droege@collabora.co.uk>
3144
3145         Reviewed by Gustavo Noronha.
3146
3147         https://bugs.webkit.org/show_bug.cgi?id=30307
3148         
3149         Fix 0 sentinel for g_object_set() function call.
3150
3151         * platform/graphics/gtk/DataSourceGStreamer.cpp:
3152         (webkit_data_src_uri_set_uri):
3153         0 is passed as 32 bit value on x86-64 in vararg functions, but
3154         g_object_set() expects a 64 bit 0. This will cause crashes.
3155
3156 2009-10-12  Cameron McCormack  <cam@mcc.id.au>
3157
3158         Reviewed by Eric Seidel.
3159
3160         Drop in="" from <feFlood>
3161         https://bugs.webkit.org/show_bug.cgi?id=29001
3162
3163         This makes <feFlood in="bogus"> have an effect, too.
3164
3165         http://www.w3.org/2003/01/REC-SVG11-20030114-errata#feflood-attribute
3166
3167         Test: svg/dom/feFlood-no-in1.html
3168
3169         * svg/SVGFEFloodElement.cpp:
3170         (WebCore::SVGFEFloodElement::SVGFEFloodElement):
3171         (WebCore::SVGFEFloodElement::build):
3172         * svg/SVGFEFloodElement.h:
3173         * svg/SVGFEFloodElement.idl:
3174         * svg/graphics/filters/SVGFEFlood.cpp:
3175         (WebCore::FEFlood::FEFlood):
3176         (WebCore::FEFlood::create):
3177         * svg/graphics/filters/SVGFEFlood.h:
3178
3179 2009-10-12  Sebastian Dröge  <sebastian.droege@collabora.co.uk>
3180
3181         Reviewed by Gustavo Noronha.
3182
3183         https://bugs.webkit.org/show_bug.cgi?id=29998
3184         
3185         Scale video to completely fill the target surface while
3186         keeping the aspect ratio. This fixes displaying of the
3187         YouTube HTML5 sample website.
3188
3189         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
3190         Scale video to completely fill the target surface, keep
3191         the aspect ratio and center it.
3192
3193 2009-10-12  Sebastian Dröge  <sebastian.droege@collabora.co.uk>
3194
3195         Reviewed by Gustavo Noronha.
3196
3197         https://bugs.webkit.org/show_bug.cgi?id=29997
3198         
3199         Fixes double memcpy of all rendered video frames.
3200
3201         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
3202         (WebCore::mediaPlayerPrivateRepaintCallback):
3203         (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
3204         (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
3205         (WebCore::MediaPlayerPrivate::duration):
3206         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
3207         * platform/graphics/gtk/VideoSinkGStreamer.cpp:
3208         (webkit_video_sink_timeout_func):
3209         (webkit_video_sink_dispose):
3210         (unlock_buffer_mutex):
3211         (webkit_video_sink_unlock):
3212         (marshal_VOID__MINIOBJECT):
3213         (webkit_video_sink_class_init):
3214         (webkit_video_sink_new):
3215         * platform/graphics/gtk/VideoSinkGStreamer.h:
3216         Directly pass the buffers up to the MediaPlayerPrivate::paint()
3217         method instead of rendering them first to an intermediate cairo
3218         surface. This should increase performance and peak memory usage.
3219
3220 2009-10-11  Daniel Bates  <dbates@webkit.org>
3221
3222         Reviewed by Adam Barth.
3223
3224         https://bugs.webkit.org/show_bug.cgi?id=30242
3225         
3226         Fixes an issue where JavaScript URLs that are URL-encoded twice can 
3227         bypass the XSSAuditor.
3228         
3229         JavaScript URLs that are completed by method Document::completeURL have added
3230         URL-encoded characters such that a direct comparison with the URL-decoded 
3231         outgoing HTTP parameters is not sufficient. Instead, the URL-decoded outgoing 
3232         HTTP parameters must be URL-decoded before comparison.
3233
3234         Tests: http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode.html
3235                http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2.html
3236                http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3.html
3237
3238         * bindings/ScriptControllerBase.cpp:
3239         (WebCore::ScriptController::executeIfJavaScriptURL): Modified to pass XSSAuditor
3240         the URL-decoded source code for the JavaScript URL.
3241         * page/XSSAuditor.cpp:
3242         (WebCore::isIllegalURICharacter): Minor syntactical change to the comment.
3243         (WebCore::XSSAuditor::CachingURLCanonicalizer::canonicalizeURL): Added 
3244         parameter decodeURLEscapeSequencesTwice.
3245         (WebCore::XSSAuditor::canEvaluateJavaScriptURL):
3246         (WebCore::XSSAuditor::decodeURL): Ditto.
3247         (WebCore::XSSAuditor::findInRequest): Ditto.
3248         * page/XSSAuditor.h:
3249         (WebCore::XSSAuditor::CachingURLCanonicalizer::CachingURLCanonicalizer): Ditto.
3250
3251 2009-10-11  Dominic Cooney  <dominicc@google.com>
3252
3253         Reviewed by Adam Barth.
3254
3255         Fixes a build break in the V8 bindings caused by revision 49420.
3256         https://bugs.webkit.org/show_bug.cgi?id=30294
3257
3258         Revision 49420 introduces an IDL-defined CanvasActiveInfo
3259         type. This causes a build break in the V8 bindings where
3260         CanvasGraphicsContext3D naively refers to CanvasActiveInfo as a
3261         non-ref type.
3262
3263         * WebCore.gypi: Include CanvasActiveInfo.idl in build.
3264         * bindings/scripts/CodeGeneratorV8.pm: CanvasActiveInfo is a ref
3265           ptr type.
3266         * bindings/v8/DOMObjectsInclude.h: Include generated
3267           CanvasActiveInfo files.
3268         * bindings/v8/DerivedSourcesAllInOne.cpp:
3269         * bindings/v8/V8Index.cpp:
3270         * bindings/v8/V8Index.h:
3271
3272 2009-10-11  Collin Jackson  <collinj@webkit.org>
3273
3274         Reviewed by Adam Barth.
3275
3276         Log mixed content warnings to console
3277
3278         https://bugs.webkit.org/show_bug.cgi?id=30290
3279
3280         * loader/FrameLoader.cpp:
3281         (WebCore::FrameLoader::checkIfDisplayInsecureContent):
3282         (WebCore::FrameLoader::checkIfRunInsecureContent):
3283
3284 2009-10-11  Søren Gjesse  <sgjesse@chromium.org>
3285
3286         Reviewed by Adam Barth.
3287
3288         [V8] Add a context scope in JS listener destructor. The destructor code uses the cotext. See http://crbug.com/24200.
3289         https://bugs.webkit.org/show_bug.cgi?id=30250
3290
3291         * bindings/v8/V8AbstractEventListener.cpp:
3292         (WebCore::V8AbstractEventListener::~V8AbstractEventListener):
3293
3294 2009-10-11  Lyon Chen  <lyon.chen@torchmobile.com>
3295
3296         Reviewed by Alexey Proskuryakov.
3297
3298         Correct the position of #endif sentence inside WebCore::Document::finishedParsing().
3299
3300         https://bugs.webkit.org/show_bug.cgi?id=30244
3301
3302         This change requires no test case as it fix a compiling error.
3303
3304         * dom/Document.cpp:
3305         (WebCore::Document::finishedParsing):
3306
3307 2009-10-11  Dominic Cooney  <dominicc@google.com>
3308
3309         Reviewed by Adam Barth.
3310
3311         Sets a 500K stack limit for JavaScript workers in Chromium.
3312         https://bugs.webkit.org/show_bug.cgi?id=29797
3313
3314         Runaway recursion in JavaScript workers crashes the Chromium
3315         worker process on OS X. This is because V8's default stack limit
3316         is 512K on ia32 or 1M on x64, but the worker process runs workers
3317         on a thread with the OS X default stack size--512K. Because there
3318         are already some C+frames on the stack when V8 establishes its
3319         512K default stack limit, and V8 doesn't precisely enforce the
3320         stack limit, runaway recursion in V8 workers overflows the OS
3321         stack and segfaults, killing the worker process. This is described
3322         in Chromium bug 21653 <http://crbug.com/21653>.
3323
3324         This patch sets the V8 stack limit for worker JavaScript in
3325         Chromium to a more conservative 500K on all platforms. This allows
3326         some "headroom" for the C+stack in use when the limit is set up,
3327         and some "legroom" for the V8 helper functions which in practice
3328         briefly flout the V8 stack limit.
3329
3330         Test: LayoutTests/fast/workers/use-machine-stack.html
3331
3332         * bindings/v8/WorkerContextExecutionProxy.cpp:
3333         (WebCore::WorkerContextExecutionProxy::initV8IfNeeded):
3334         * bindings/v8/WorkerContextExecutionProxy.h:
3335
3336 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
3337
3338         wx build fix for wxMac 2.9, use wxGC API for measuring text.
3339
3340         * platform/wx/wxcode/mac/carbon/fontprops.cpp:
3341         (GetTextExtent):
3342
3343 2009-10-10  Cameron McCormack  <cam@mcc.id.au>
3344
3345         Reviewed by Sam Weinig.
3346
3347         Allow [Reflect] on SVG elements.
3348         https://bugs.webkit.org/show_bug.cgi?id=28936
3349
3350         Update the JS binding generators to reference SVGNames instead of
3351         HTMLNames, if [Reflect]ing an attribute on an SVG element.  Make
3352         SVGElement::id use [Reflect].
3353
3354         Also make [Reflect] on an attribute with a setter exception work in ObjC
3355         bindings.
3356
3357         Test: svg/dom/id-reflect.html
3358
3359         * bindings/scripts/CodeGenerator.pm: Add a function to determine the
3360         appropriate C+namespace for attribute name constants.
3361         * bindings/scripts/CodeGeneratorObjC.pm: Generate ExceptionCode handling
3362         code for [Reflect] on an attribute with a setter exception.
3363         * bindings/scripts/CodeGeneratorCOM.pm: Generate "SVGNames" instead of
3364         "HTMLNames" when appropriate.
3365         * bindings/scripts/CodeGeneratorJS.pm: Ditto.
3366         * bindings/scripts/CodeGeneratorV8.pm: Ditto.
3367         * svg/SVGElement.cpp: Remove getter and setter methods for id.
3368         * svg/SVGElement.h: Ditto.
3369         * svg/SVGElement.idl: Add [Reflect] to id.
3370
3371 2009-10-10  Oliver Hunt  <oliver@apple.com>
3372
3373         Fix paths in xcode.
3374
3375         * WebCore.xcodeproj/project.pbxproj:
3376
3377 2009-10-10  Oliver Hunt  <oliver@apple.com>
3378
3379         Reviewed by Eric Carlson.
3380
3381         Implement getActiveAttrib and getActiveUniform
3382         https://bugs.webkit.org/show_bug.cgi?id=30276
3383
3384         Implements the getActiveAttrib and getActiveUniform APIs.
3385         Rather simple patch, adds CanvasActiveInfo definition and implementation
3386         and adds forwarding to the GraphicsContext3D.
3387
3388         Test: fast/canvas/webgl/getActiveTest.html
3389
3390         * DerivedSources.make:
3391         * WebCore.xcodeproj/project.pbxproj:
3392         * html/canvas/CanvasActiveInfo.h: Added.
3393         (WebCore::CanvasActiveInfo::create):
3394         (WebCore::CanvasActiveInfo::name):
3395         (WebCore::CanvasActiveInfo::type):
3396         (WebCore::CanvasActiveInfo::size):
3397         (WebCore::CanvasActiveInfo::CanvasActiveInfo):
3398         * html/canvas/CanvasActiveInfo.idl: Added.
3399         * html/canvas/CanvasObject.h:
3400         (WebCore::CanvasObject::context):
3401           Need to make the context public as it is needed to ensure we don't
3402           provide a program from one context as an argument to another.
3403         * html/canvas/CanvasRenderingContext3D.cpp:
3404         (WebCore::CanvasRenderingContext3D::getActiveAttrib):
3405         (WebCore::CanvasRenderingContext3D::getActiveUniform):
3406         * html/canvas/CanvasRenderingContext3D.h:
3407         * html/canvas/CanvasRenderingContext3D.idl:
3408         * platform/graphics/GraphicsContext3D.h:
3409         * platform/graphics/mac/GraphicsContext3DMac.cpp:
3410         (WebCore::GraphicsContext3D::getActiveAttrib):
3411         (WebCore::GraphicsContext3D::getActiveUniform):
3412
3413 2009-10-10  Pavel Feldman  <pfeldman@chromium.org>
3414
3415         Reviewed by Timothy Hatcher.
3416
3417         Web Inspector: Adding new attributes in Element Panel is
3418         counterintuitive.
3419
3420         https://bugs.webkit.org/show_bug.cgi?id=30057
3421
3422         * inspector/front-end/ElementsTreeOutline.js:
3423         (WebInspector.ElementsTreeOutline.prototype._onmousemove):
3424         (WebInspector.ElementsTreeElement.prototype.set hovered):
3425         (WebInspector.ElementsTreeElement.prototype.toggleNewAttributeButton):
3426
3427 2009-10-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3428
3429         Reviewed by Holger Freyther.
3430
3431         Build fix if Netscape plugin support is turned off
3432         https://bugs.webkit.org/show_bug.cgi?id=30275
3433
3434         In addition to fixing the build break with guards
3435         remove notImplemented() from PluginViewNone.cpp and
3436         make them just just be empty functions.
3437
3438         * plugins/PluginView.cpp:
3439         (WebCore::PluginView::handleEvent):
3440         (WebCore::PluginView::PluginView):
3441         * plugins/PluginView.h:
3442         * plugins/PluginViewNone.cpp:
3443         (WebCore::PluginView::setFocus):
3444         (WebCore::PluginView::show):
3445         (WebCore::PluginView::hide):
3446         (WebCore::PluginView::paint):
3447         (WebCore::PluginView::handleKeyboardEvent):
3448         (WebCore::PluginView::handleMouseEvent):
3449         (WebCore::PluginView::setParent):
3450         (WebCore::PluginView::setNPWindowRect):
3451         (WebCore::PluginView::handlePostReadFile):
3452         (WebCore::PluginView::getValue):
3453         (WebCore::PluginView::getValueStatic):
3454         (WebCore::PluginView::invalidateRect):
3455         (WebCore::PluginView::invalidateRegion):
3456         (WebCore::PluginView::forceRedraw):
3457         (WebCore::PluginView::platformStart):
3458         (WebCore::PluginView::platformDestroy):
3459         (WebCore::PluginView::setParentVisible):
3460         (WebCore::PluginView::updatePluginWidget):
3461
3462 2009-10-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3463
3464         Unreviewed.
3465
3466         [Qt] Build fix for QtWebKit after r49415.
3467
3468         Add HistoryController.cpp to the build.
3469
3470         * WebCore.pro:
3471
3472 2009-10-09  Darin Fisher  <darin@chromium.org>
3473
3474         Reviewed by Eric Seidel.
3475
3476         [Chromium] KURLGoogle's protocolIs barfs on input containing hyphens
3477         https://bugs.webkit.org/show_bug.cgi?id=30262
3478
3479         This is not testable from WebKit since WebKit never uses the member
3480         function form of protocolIs with input that can be controlled from a
3481         web page.  It always passes string literals lacking hyphens.
3482
3483         * platform/KURLGoogle.cpp:
3484         (WebCore::lowerCaseEqualsASCII): Only assert if toASCIILower would
3485         transform the input character.
3486
3487 2009-10-10  Adam Barth  <abarth@webkit.org>
3488
3489         Reviewed by Oliver Hunt.
3490
3491         Move HistoryController to its own file
3492         https://bugs.webkit.org/show_bug.cgi?id=30272
3493
3494         Purely mechanical.
3495
3496         * GNUmakefile.am:
3497         * WebCore.gypi:
3498         * WebCore.vcproj/WebCore.vcproj:
3499         * WebCore.xcodeproj/project.pbxproj:
3500         * WebCoreSources.bkl:
3501         * loader/FrameLoader.cpp:
3502         * loader/FrameLoader.h:
3503         * loader/HistoryController.cpp: Added.
3504         * loader/HistoryController.h: Added.
3505
3506 2009-10-09  Ryosuke Niwa  <rniwa@webkit.org>
3507
3508         Reviewed by Eric Seidel.
3509
3510         ApplyStyleCommand removes presentational tags even when not necessary
3511         https://bugs.webkit.org/show_bug.cgi?id=28091
3512
3513         This patch updates implicitlyStyledElementShouldBeRemovedWhenApplyingStyle to return true
3514         (triggering removal of tag) only if the style implicitly added by the element is not present in
3515         the new style to apply. It also changes surroundNodeRangeWithElement so that it merges the
3516         surrounding element when possible. applyTextDecorationStyle is modified so that it does not add
3517         style span when the style attribute is empty.
3518
3519         Test: editing/execCommand/toggle-style-3.html
3520
3521         * editing/ApplyStyleCommand.cpp:
3522         (WebCore::ApplyStyleCommand::shouldRemoveTextDecorationTag): Returns true if specified text
3523         decoration is not present in the style to apply
3524         (WebCore::ApplyStyleCommand::implicitlyStyledElementShouldBeRemovedWhenApplyingStyle): No longer
3525         returns true if the tag is used in new style
3526         (WebCore::ApplyStyleCommand::applyTextDecorationStyle): Does not add style-span when redundant
3527         (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement): Merges the newly created element
3528         with the surrounding identical elements
3529         * editing/ApplyStyleCommand.h:
3530
3531 2009-10-09  Adam Barth  <abarth@webkit.org>
3532
3533         Reviewed by Darin Adler.
3534
3535         Factor HistoryController out of FrameLoader
3536         https://bugs.webkit.org/show_bug.cgi?id=30246
3537
3538         HistoryController is in charge of managing the current / previous /
3539         provisional HistoryItems.  The split isn't perfect, but it's a place to
3540         start.  I'll move HistoryController into its own file in another patch.
3541
3542         * WebCore.base.exp:
3543         * loader/FrameLoader.cpp:
3544         (WebCore::HistoryController::HistoryController):
3545         (WebCore::HistoryController::~HistoryController):
3546         (WebCore::FrameLoader::FrameLoader):
3547         (WebCore::FrameLoader::closeURL):
3548         (WebCore::FrameLoader::begin):
3549         (WebCore::HistoryController::restoreDocumentState):
3550         (WebCore::HistoryController::setCurrentItem):
3551         (WebCore::HistoryController::setProvisionalItem):
3552         (WebCore::FrameLoader::loadURLIntoChildFrame):
3553         (WebCore::FrameLoader::canCachePageContainingThisFrame):
3554         (WebCore::FrameLoader::logCanCacheFrameDecision):
3555         (WebCore::FrameLoader::scrollToAnchor):
3556         (WebCore::FrameLoader::commitProvisionalLoad):
3557         (WebCore::FrameLoader::transitionToCommitted):
3558         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
3559         (WebCore::FrameLoader::didFirstLayout):
3560         (WebCore::HistoryController::updateForFrameLoadCompleted):
3561         (WebCore::FrameLoader::frameLoadCompleted):
3562         (WebCore::FrameLoader::detachFromParent):
3563         (WebCore::FrameLoader::receivedMainResourceError):
3564         (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
3565         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
3566         (WebCore::HistoryController::addHistoryItemForFragmentScroll):
3567         (WebCore::FrameLoader::loadProvisionalItemFromCachedPage):
3568         (WebCore::FrameLoader::shouldTreatURLAsSameAsCurrent):
3569         (WebCore::HistoryController::createHistoryItem):
3570         (WebCore::FrameLoader::checkDidPerformFirstNavigation):
3571         (WebCore::HistoryController::addBackForwardItemClippedAtTarget):
3572         (WebCore::HistoryController::createHistoryItemTree):
3573         (WebCore::HistoryController::saveScrollPositionAndViewStateToItem):
3574         (WebCore::HistoryController::restoreScrollPositionAndViewState):
3575         (WebCore::HistoryController::invalidateCurrentItemCachedPage):
3576         (WebCore::HistoryController::saveDocumentState):
3577         (WebCore::FrameLoader::loadItem):
3578         (WebCore::HistoryController::urlsMatchItem):
3579         (WebCore::HistoryController::goToItem):
3580         (WebCore::HistoryController::recursiveGoToItem):
3581         (WebCore::HistoryController::childFramesMatchItem):
3582         (WebCore::HistoryController::updateForStandardLoad):
3583         (WebCore::HistoryController::updateForClientRedirect):
3584         (WebCore::HistoryController::updateForBackForwardNavigation):
3585         (WebCore::HistoryController::updateForReload):
3586         (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList):
3587         (WebCore::HistoryController::updateForCommit):
3588         (WebCore::HistoryController::updateForAnchorScroll):
3589         (WebCore::HistoryController::saveDocumentAndScrollState):
3590         (WebCore::HistoryController::setCurrentItemTitle):
3591         (WebCore::FrameLoader::didChangeTitle):
3592         * loader/FrameLoader.h:
3593         (WebCore::HistoryController::current):
3594         (WebCore::HistoryController::provisional):
3595         (WebCore::FrameLoader::policyChecker):
3596         (WebCore::FrameLoader::history):
3597         (WebCore::FrameLoader::creatingInitialEmptyDocument):
3598         * page/Page.cpp:
3599         (WebCore::Page::goToItem):
3600
3601 2009-10-09  Alexey Proskuryakov  <ap@apple.com>
3602
3603         Unreviewed - fixing an obvious typo in my previous check-in.
3604
3605         https://bugs.webkit.org/show_bug.cgi?id=30260
3606         <rdar://problem/6447115> REGRESSION: Logging out from SAP doesn't work
3607
3608         Fixes existing tests (which I thought I had run the previous time).
3609
3610         * platform/network/CredentialStorage.cpp: (WebCore::originsWithCredentials): Return the
3611         set by reference.
3612
3613 2009-10-09  David Levin  <levin@chromium.org>
3614
3615         Reviewed by Eric Seidel.