[Efl] Fix path returned by builtDylibPathForName in webkitdirs.pm
[WebKit-https.git] / Tools / ChangeLog
1 2011-12-19  Raphael Kubo da Costa  <kubo@profusion.mobi>
2
3         [Efl] Fix path returned by builtDylibPathForName in webkitdirs.pm
4         https://bugs.webkit.org/show_bug.cgi?id=74854
5
6         Reviewed by Csaba Osztrogonác.
7
8         Since r101052, libewebkit.so is built in a different location, so we
9         need to adjust the path returned by builtDylibPathForName.
10
11         usesPerConfigurationBuildDirectory also needs to be fixed, as the Efl
12         port also respects Release/Debug configurations.
13
14         These changes should make run-launcher finally work correctly with
15         webkit-efl.
16
17         * Scripts/webkitdirs.pm:
18         (usesPerConfigurationBuildDirectory):
19         (builtDylibPathForName):
20
21 2011-12-19  Simon Hausmann  <simon.hausmann@nokia.com>
22
23         [Qt][WK2] Add support for modal event loop processing for WTR
24         https://bugs.webkit.org/show_bug.cgi?id=74852
25
26         Reviewed by Kenneth Rohde Christiansen.
27
28         Rewrote event loop processing: Instead of terminating the event loop
29         in notifyDone() - something no other platform does - we now respect the
30         "bool& condition" parameter passed to platformRunUntil. This ensures
31         proper termination even when the condition is changed from within a
32         nested event loop, because only when we _exit_ from the nested event
33         loop we will check the condition and terminate the test properly.
34
35         In addition this patch implements TestController::runModal by means of
36         a nested event loop, which is passed to the platform webview that is
37         supposed to be modal. It is that view's responsibility to exit the
38         loop, upon destruction. I believe that's similar to how it works on the Mac,
39         where it doesn't seem that NSApp's runModalForWindow is terminate via
40         abort/stopModal but simply because the window is closed.
41
42         * WebKitTestRunner/PlatformWebView.h:
43         (WTR::PlatformWebView::setModalEventLoop):
44         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
45         (WTR::PlatformWebView::PlatformWebView):
46         (WTR::PlatformWebView::~PlatformWebView):
47         * WebKitTestRunner/qt/TestControllerQt.cpp:
48         (WTR::TestController::notifyDone):
49         (WTR::TestController::platformRunUntil):
50         (WTR::TestController::runModal):
51
52 2011-12-18  Kentaro Hara  <haraken@chromium.org>
53
54         REGRESSION(r103149): prepare-ChangeLog outputs a warning
55         https://bugs.webkit.org/show_bug.cgi?id=74808
56
57         Reviewed by David Kilzer.
58
59         Added the prototype declaration of main() to avoid warning messages.
60         Sorted subroutine declarations in the alphabetical order.
61
62         * Scripts/prepare-ChangeLog:
63
64 2011-12-17  Adenilson Cavalcanti  <cavalcantii@gmail.com>
65
66         [Qt] Fix QtTestBrowser compilation with QtWidgets module
67         https://bugs.webkit.org/show_bug.cgi?id=74791
68
69         Reviewed by Andreas Kling.
70
71         * QtTestBrowser/QtTestBrowser.pro:
72
73 2011-12-17  Kentaro Hara  <haraken@chromium.org>
74
75         Remove top-level code completely from prepare-ChangeLog
76         https://bugs.webkit.org/show_bug.cgi?id=74698
77
78         Reviewed by Darin Adler.
79
80         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest manner.
81         This patch just moves all top-level code into main().
82
83         * Scripts/prepare-ChangeLog:
84         (main):
85
86 2011-12-16  Dean Jackson  <dino@apple.com>
87
88         Move webkit-bug-importer to Contributor. It won't
89         autocomplete as an Account.
90         See https://bugs.webkit.org/show_bug.cgi?id=74739
91         for some discussion.
92
93         Unreviewed.
94
95         * Scripts/webkitpy/common/config/committers.py:
96
97 2011-12-16  Dean Jackson  <dino@apple.com>
98
99         Add webkit-bug-importer@group.apple.com to accounts
100         so that it autocompletes in bugzilla.
101
102         Unreviewed.
103
104         * Scripts/webkitpy/common/config/committers.py:
105
106 2011-12-16  Philippe Normand  <pnormand@igalia.com>
107
108         Unreviewed, skipping 3 failing GTK API tests.
109
110         * Scripts/run-gtk-tests:
111
112 2011-12-16  Philippe Normand  <pnormand@igalia.com>
113
114         Unreviewed, GTK API tests build fix attempt.
115
116         * Scripts/run-gtk-tests: Run xvfb on a display not used by NRWT.
117
118 2011-12-16  Philippe Normand  <pnormand@igalia.com>
119
120         Unreviewed, unskipping GTK testdownload. Should pass on the bot now.
121
122         * Scripts/run-gtk-tests:
123
124 2011-12-16  Simon Hausmann  <simon.hausmann@nokia.com>
125
126         [Qt] Fix the build for newer Qt5
127         https://bugs.webkit.org/show_bug.cgi?id=74703
128
129         Reviewed by Csaba Osztrogonác.
130
131         * QtTestBrowser/launcherwindow.h: Add missing forward declaration.
132         * DumpRenderTree/qt/EventSenderQt.cpp:
133         (EventSender::sendTouchEvent): Allocate QTouchDevice and use with QTouchEvent constructor.
134         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Ditto.
135         (WTR::EventSenderProxy::sendTouchEvent):
136         * MiniBrowser/qt/MiniBrowserApplication.cpp:
137         (MiniBrowserApplication::sendTouchEvent): Ditto.
138         (MiniBrowserApplication::notify): Adapt to changed API for marking primary touch point.
139
140 2011-12-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
141
142         [Qt] Detect and force clean build when feature defines are added
143
144         Reviewed by Ossy.
145
146         https://bugs.webkit.org/show_bug.cgi?id=74689
147
148         * Scripts/webkitdirs.pm:
149
150 2011-12-16  Kentaro Hara  <haraken@chromium.org>
151
152         [Refactoring] Remove all global variables from prepare-ChangeLog
153         https://bugs.webkit.org/show_bug.cgi?id=74681
154
155         Reviewed by Ryosuke Niwa.
156
157         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
158         manner. This bug is one of the incremental refactorings to remove all top-level
159         code and global variables from prepare-ChangeLog. In this patch,
160         we make the following global variables be used only through parameter passing.
161         This patch removes all global variables from prepare-ChangeLog.
162             - $mergeBase
163             - $gitCommit
164             - $gitIndex
165
166         * Scripts/prepare-ChangeLog:
167         (generateFunctionLists):
168         (changeLogNameFromArgs):
169         (changeLogEmailAddressFromArgs):
170         (generateNewChangeLogs):
171         (printDiff):
172         (diffFromToString):
173         (diffCommand):
174         (statusCommand):
175         (createPatchCommand):
176         (generateFileList):
177         (isConflictStatus):
178
179 2011-12-15  Philippe Normand  <pnormand@igalia.com>
180
181         [GTK] Rounding errors on 32-bit machines causes tests to fail
182         https://bugs.webkit.org/show_bug.cgi?id=72254
183
184         Initial patch by vanuan@gmail.com.
185         Reviewed by Martin Robinson.
186
187         * Scripts/webkitdirs.pm:
188         (runAutogenForAutotoolsProjectIfNecessary): Pass additional
189         CXXFLAGS to autogen in an attempt to harmonize floating point
190         values between 32-bit and 64-bit architectures.
191
192 2011-12-16  Martin Robinson  <mrobinson@igalia.com>
193
194         [GTK] Make distcheck fails during the install
195         https://bugs.webkit.org/show_bug.cgi?id=74274
196
197         No review, since this is a build fix.
198
199         * GNUmakefile.am: Remove BUILT_SOURCES from the dependency list for the gtkdoc
200         step. BUILT_SOURCES includes forwarding header generation for WebKit2, which
201         always runs. This means that the gtkdoc step was always running when make was
202         invoked. Generating gtkdoc during 'make install' was triggering a race condition
203         with the library file. Later we can fix generate-forwarding-headers and unbreak
204         'make docs,' but this bandaid is sufficient to let us release.
205
206 2011-12-15  Eric Seidel  <eric@webkit.org>
207
208         NRWT should use free + inactive memory for default_child_processes on OS X (and never return < 1 process)
209         https://bugs.webkit.org/show_bug.cgi?id=74650
210
211         Reviewed by Adam Barth.
212
213         * Scripts/webkitpy/common/system/platforminfo.py:
214         (PlatformInfo._compute_bytes_from_vm_stat_output):
215         * Scripts/webkitpy/layout_tests/port/base.py:
216         (Port.default_child_processes):
217         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
218         (PortTest.test_default_child_processes):
219
220 2011-12-15  Filip Pizlo  <fpizlo@apple.com>
221
222         bencher script should support remote benchmarking on platforms that don't have ruby
223         https://bugs.webkit.org/show_bug.cgi?id=74659
224
225         Rubber-stamped by Sam Weinig.
226         
227         Added the ability to have bencher generate a benchmarking playload that consists of
228         copies of all of the benchmarks, optionally copies of all of the frameworks and
229         binaries to run all of the VMs, and a sh script that runs the benchmarks in random
230         order, which then spits out a raw results file that bencher can parse.
231         
232         In normal operating mode, you never see this, as it just generates the payload and
233         script internally, runs it, parses the results, and spits them out.
234         
235         The --remote mode has been changed to use this style, so any remote host that has
236         sshd, passwordless login support, a ~/.bencher file that points to a "tempPath", and
237         a sh-compatible shell can be used for remote benchmarking.
238         
239         The feature to include VMs in the benchmarking payload is by default only activated
240         when using --remote, but it can also be activated when doing local benchmarking; the
241         benefit is that you remove any pathname-related performance pathologies. All VMs
242         become equal because they are all located in
243         /path/to/bencher/directory/temp/benchdata/vmN where N is the configuration number
244         (usually 0 or 1).
245         
246         Also fixed bugs in the DumpRenderTree support. It's now possible to run all benchmarks
247         through DumpRenderTree. This is only a bit slower than running in jsc.
248
249         * Scripts/bencher:
250
251 2011-12-15  Dirk Pranke  <dpranke@chromium.org>
252
253         webkitpy: clean up TestPort to (mostly) not create a new filesystem
254         https://bugs.webkit.org/show_bug.cgi?id=74556
255
256         This change modifies the TestPort to be ready to add tests to an
257         existing filesystem instead of creating a new filesystem; we
258         leave unit_test_filesystem() in for now for compatibility.
259
260         * Scripts/webkitpy/common/host_mock.py:
261         (MockHost.__init__):
262           - call add_unit_tests_to_mock_filesystem by default to make
263             the MockHost more generally useful for layout_test unit tests.
264         * Scripts/webkitpy/layout_tests/port/test.py:
265         (TestInstance.__init__):
266         (add_unit_tests_to_mock_filesystem):
267         (add_file):
268         (unit_test_filesystem):
269         (TestPort.__init__):
270         (TestPort._set_default_overriding_none):
271
272 2011-12-15  Dirk Pranke  <dpranke@chromium.org>
273
274         webkitpy: cleanup prior to systemhostifying the layout_test/port* classes
275         https://bugs.webkit.org/show_bug.cgi?id=74551
276
277         This is some minor cleanup prior to making all of the host/port
278         changes described in bug 74138.
279
280         * Scripts/webkitpy/common/host_mock.py:
281         (MockHost.__init__):
282           - make sure the scm object is initialized with the same mock
283             executive and filesystem objects.
284
285         * Scripts/webkitpy/common/system/filesystem_mock.py:
286         (MockFileSystem.clear_written_files):
287           - add a routine that will be useful in testing.
288         (MockFileSystem.maybe_make_directory):
289         (MockFileSystem.write_binary_file):
290           - fix bugs to make sure directories are created properly.
291         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
292         (_Process.run):
293           - add clarifying comments.
294         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
295         (MockDRTPort.__init__):
296         (MockDRT.__init__):
297           - add clarifying comments.
298
299 2011-12-15  Anders Carlsson  <andersca@apple.com>
300
301         Regression (r102866): Navigating away from or closing a page with a plugin crashes
302         https://bugs.webkit.org/show_bug.cgi?id=74655
303
304         Reviewed by Sam Weinig.
305
306         Add a bunch of tests.
307
308         * TestWebKitAPI/Tests/WTF/Functional.cpp:
309
310 2011-12-15  Stephanie Lewis  <slewis@apple.com>
311
312         https://bugs.webkit.org/show_bug.cgi?id=74469
313         Escape paths to svn commands so our tools can handle filenames with @ symbols.
314
315         Reviewed by Adam Roben.
316
317         * Scripts/VCSUtils.pm:
318         (scmMoveOrRenameFile):
319         (scmAddExecutableBit):
320         (scmRemoveExecutableBit):
321         (determineSVNRoot):
322         (svnRevisionForDirectory):
323         (pathRelativeToSVNRepositoryRootForPath):
324         (svnStatus):
325         (escapeSubversionPath):
326         * Scripts/parse-malloc-history:
327         (main):
328         * Scripts/prepare-ChangeLog:
329         (diffCommand):
330         (statusCommand):
331         (findOriginalFileFromSvn):
332         (determinePropertyChanges):
333         * Scripts/resolve-ChangeLogs:
334         (conflictFiles):
335         (resolveConflict):
336         (showStatus):
337         * Scripts/svn-apply:
338         (patch):
339         (scmCopy):
340         (scmAdd):
341         (scmRemove):
342         * Scripts/svn-create-patch:
343         (findBaseUrl):
344         (findMimeType):
345         (findSourceFileAndRevision):
346         (generateDiff):
347         (generateFileList):
348         (manufacturePatchForAdditionWithHistory):
349         * Scripts/svn-unapply:
350         (patch):
351         (revertDirectories):
352
353 2011-12-15  Michael Bruning  <michael.bruning@nokia.com>
354
355         [qt][wk2] MiniBrowser: Add pressed state for viewport info button.
356         https://bugs.webkit.org/show_bug.cgi?id=74617
357
358         Reviewed by Kenneth Rohde Christiansen.
359
360         * MiniBrowser/qt/qml/BrowserWindow.qml: Added state dependent coloring
361         for viewport info button, adjusted height and added rounded corners.
362
363 2011-12-15  Andy Estes  <aestes@apple.com>
364
365         TestFailures: store the name of the buildbot results directory in a property
366         https://bugs.webkit.org/show_bug.cgi?id=74663
367
368         Reviewed by Adam Barth.
369         
370         Store the name of the results directory as a property on Buildbot's
371         prototype. This allows subclasses of Buildbot to customize the results
372         directory.
373
374         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js:
375         (Buildbot.prototype.resultsDirectoryURL):
376
377 2011-12-15  Tony Chang  <tony@chromium.org>
378
379         [chromium] pass --delete_unversioned_trees to gclient on the bots
380         https://bugs.webkit.org/show_bug.cgi?id=74565
381
382         Reviewed by Kenneth Russell.
383
384         It was temporarily removed in r102891 to keep the bots green.  Now
385         that the bots have cycled, we can add it back.
386
387         * Scripts/update-webkit-chromium:
388
389 2011-12-15  Kentaro Hara  <haraken@chromium.org>
390
391         [Refactoring] In prepare-ChangeLog, make several global variables be used only through parameter passing
392         https://bugs.webkit.org/show_bug.cgi?id=74497
393
394         Reviewed by Ryosuke Niwa.
395
396         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
397         manner. This bug is one of the incremental refactorings to remove all top-level
398         code and global variables from prepare-ChangeLog. In this patch,
399         we make the following global variables be used only through parameter passing.
400             - $bugDescription
401             - $bugNumber
402             - $name
403             - $emailAddress
404             - $gitReviewer
405             - $writeChangeLogs
406
407         * Scripts/prepare-ChangeLog:
408         (fetchBugDescriptionFromURL):
409         (generateNewChangeLogs):
410         (reviewerAndDescriptionForGitCommit):
411
412 2011-12-15  Raphael Kubo da Costa  <kubo@profusion.mobi>
413
414         [EFL] Add a few more web database functions to ewk_settings.
415         https://bugs.webkit.org/show_bug.cgi?id=72148
416
417         Reviewed by Antonio Gomes.
418
419         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
420         (LayoutTestController::clearAllDatabases):
421         (LayoutTestController::setDatabaseQuota):
422
423 2011-12-15  Martin Kosiba  <mkosiba@google.com>
424
425         Fix find on web pages with -webkit-user-select: none for Chromium
426         https://bugs.webkit.org/show_bug.cgi?id=72281
427
428         Reviewed by Ryosuke Niwa.
429
430         Provided a partial findString implementation. This doesn't support
431         all of the FindOptions since they're not exposed via WebFindOptions.
432
433         * DumpRenderTree/chromium/LayoutTestController.cpp:
434         (LayoutTestController::LayoutTestController):
435         (LayoutTestController::findString):
436         * DumpRenderTree/chromium/LayoutTestController.h:
437
438 2011-12-15  Kenneth Russell  <kbr@google.com>
439
440         [chromium] Add DRT support for WebKitPageCacheSupportsPluginsPreferenceKey
441         https://bugs.webkit.org/show_bug.cgi?id=74581
442
443         Reviewed by Darin Fisher.
444
445         * DumpRenderTree/chromium/LayoutTestController.cpp:
446         (LayoutTestController::overridePreference):
447         * DumpRenderTree/chromium/WebPreferences.cpp:
448         (WebPreferences::reset):
449         (WebPreferences::applyTo):
450         * DumpRenderTree/chromium/WebPreferences.h:
451
452 2011-12-15  Kenneth Rohde Christiansen  <kenneth@webkit.org>
453
454         [Qt] Improve the look of the viewport info overlay
455
456         Reviewed by Tor Arne Vestbø.
457
458         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
459
460 2011-12-15  Igor Oliveira  <igor.oliveira@openbossa.org>
461
462         [Qt] Support requestAnimationFrame API
463         https://bugs.webkit.org/show_bug.cgi?id=74528
464
465         Add build-option for requestAnimationFrame feature.
466
467         Reviewed by Kenneth Rohde Christiansen.
468
469         * qmake/mkspecs/features/features.prf:
470
471 2011-12-15  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
472
473         [Qt] Don't add WebCoreSupport and WebKit APIs to include WebCore's include path
474
475         Reviewed by Simon Hausmann.
476
477         * qmake/mkspecs/features/webcore.prf:
478
479 2011-12-15  Michael Brüning  <michael.bruning@nokia.com>
480
481         [QT][WK2]Add (experimental) viewport info view to Minibrowser/qt.
482         https://bugs.webkit.org/show_bug.cgi?id=72893
483
484         Reviewed by Kenneth Rohde Christiansen.
485
486         This patch extends QQuickWebViewExperimental by a property named
487         viewportInfo, which contains the viewport scalability and
488         layout and contents size information. This property is exposed to
489         QML through the experimental extension for QQuickWebView.
490
491         * MiniBrowser/qt/MiniBrowser.pro:
492         * MiniBrowser/qt/MiniBrowser.qrc:
493         * MiniBrowser/qt/icons/info.png: Added.
494         * MiniBrowser/qt/qml/BrowserWindow.qml:
495         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Added.
496
497 2011-12-15  Shinya Kawanaka  <shinyak@google.com>
498
499         [chromium] WebViewHost::requestCheckingOfText should return immediately if text is empty.
500         https://bugs.webkit.org/show_bug.cgi?id=74586
501
502         Reviewed by Hajime Morita.
503
504         No new tests. Covered by existing tests.
505
506         * DumpRenderTree/chromium/WebViewHost.cpp:
507         (WebViewHost::requestCheckingOfText):
508           Returns immediately if text is empty.
509
510 2011-12-15  Alexander Færøy  <ahf@0x90.dk>
511
512         [Qt] QtWebKit fails to build on Mac OS X after r102776
513         https://bugs.webkit.org/show_bug.cgi?id=74593
514
515         Reviewed by Simon Hausmann.
516
517         CONFIG =+ link_pkgconfig is needed such that the correct parameters
518         are passed to the compiler.
519
520         * DumpRenderTree/qt/DumpRenderTree.pro:
521
522 2011-12-14  Tony Chang  <tony@chromium.org>
523
524         [chromium] Remove redundant third_party entries from chromium DEPS
525         https://bugs.webkit.org/show_bug.cgi?id=74472
526
527         Reviewed by Kenneth Russell.
528
529         * Scripts/update-webkit-chromium: Temporarily keep unversioned trees.
530
531 2011-12-14  Kentaro Hara  <haraken@chromium.org>
532
533         [Refactoring] In prepare-ChangeLog, replace $isGit and $isSVN with
534         VCSUtils::isGit() and VCSUtils::isSVN().
535         https://bugs.webkit.org/show_bug.cgi?id=74485
536
537         Reviewed by David Kilzer.
538
539         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
540         manner. This bug is one of the incremental refactorings to remove all top-level
541         code and global variables from prepare-ChangeLog. This patch replaces $isGit and $isSVN
542         with VCSUtils::isGit() and VCSUtils::isSVN(). This patch also removes firstDirectoryOrCwd(),
543         assuming that no user will mix Git/SVN checkouts and thus we can judge SVN or Git
544         just by looking at the current working directory.
545
546         * Scripts/prepare-ChangeLog: Removed firstDirectoryOrCwd().
547         (diffFromToString):
548         (diffCommand):
549         (statusCommand):
550         (createPatchCommand):
551         (diffHeaderFormat):
552         (generateFileList):
553         (isAddedStatus):
554         (isConflictStatus):
555         (statusDescription):
556         (extractLineRange):
557
558 2011-12-14  Sam Weinig  <weinig@apple.com>
559
560         Remove whitespace from InheritedPropertySheets attributes in
561         vsprops files to appease the Visual Studio project migrator.
562
563         Reviewed by Adam Roben.
564
565         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops:
566         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops:
567         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops:
568         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
569         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
570         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
571         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops:
572         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops:
573         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops:
574         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
575         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
576         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
577         * DumpRenderTree/win/ImageDiffDebug.vsprops:
578         * DumpRenderTree/win/ImageDiffDebugAll.vsprops:
579         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops:
580         * DumpRenderTree/win/ImageDiffProduction.vsprops:
581         * DumpRenderTree/win/ImageDiffRelease.vsprops:
582         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
583         * MiniBrowser/Configurations/MiniBrowserDebug.vsprops:
584         * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops:
585         * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops:
586         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
587         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
588         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
589         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
590         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
591         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops:
592         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops:
593         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops:
594         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
595         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
596         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
597         * WebKitTestRunner/win/InjectedBundleDebug.vsprops:
598         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops:
599         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops:
600         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
601         * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
602         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
603         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops:
604         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops:
605         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops:
606         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
607         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
608         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
609         * WinLauncher/WinLauncherDebug.vsprops:
610         * WinLauncher/WinLauncherDebugAll.vsprops:
611         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops:
612         * WinLauncher/WinLauncherProduction.vsprops:
613         * WinLauncher/WinLauncherRelease.vsprops:
614         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
615         * record-memory-win/record-memory-winDebug.vsprops:
616         * record-memory-win/record-memory-winDebugAll.vsprops:
617         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops:
618         * record-memory-win/record-memory-winProduction.vsprops:
619         * record-memory-win/record-memory-winRelease.vsprops:
620         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
621
622 2011-12-14  Anders Carlsson  <andersca@apple.com>
623
624         Windows build fix.
625
626         Move CHECKs out of the destructor.
627
628         * TestWebKitAPI/Tests/WTF/Functional.cpp:
629         (TestWebKitAPI::B::~B):
630         (TestWebKitAPI::TEST):
631
632 2011-12-14  Anders Carlsson  <andersca@apple.com>
633
634         binding a member function should ref/deref the object pointer if needed
635         https://bugs.webkit.org/show_bug.cgi?id=74552
636
637         Reviewed by Sam Weinig.
638
639         Add new tests.
640
641         * TestWebKitAPI/Tests/WTF/Functional.cpp:
642         (TestWebKitAPI::B::B):
643         (TestWebKitAPI::B::~B):
644         (TestWebKitAPI::B::ref):
645         (TestWebKitAPI::B::deref):
646         (TestWebKitAPI::B::f):
647         (TestWebKitAPI::B::g):
648         (TestWebKitAPI::TEST):
649
650 2011-12-14  Hajime Morrita  <morrita@chromium.org>
651
652         JS_INLINE and WTF_INLINE should be visible from WebCore
653         https://bugs.webkit.org/show_bug.cgi?id=73191
654
655         Reviewed by Kevin Ollivier.
656
657         Removed macro definitions which is now provided by Platform.h
658
659         * DumpRenderTree/chromium/config.h:
660         * DumpRenderTree/config.h:
661         * DumpRenderTree/ForwardingHeaders/runtime/JSExportMacros.h: Added.
662         * DumpRenderTree/ForwardingHeaders/wtf/ExportMacros.h: Added.
663         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Add new ForwardingHeaders.
664         * TestWebKitAPI/config.h:
665         * WebKitTestRunner/config.h:
666
667 2011-12-14  Kentaro Hara  <haraken@chromium.org>
668
669         Unreviewed, rolling out r102761.
670         http://trac.webkit.org/changeset/102761
671         https://bugs.webkit.org/show_bug.cgi?id=74485
672
673         we came up with a better fix than this (see comments in bug
674         74485)
675
676         * Scripts/prepare-ChangeLog:
677         (generateFunctionLists):
678         (printDiff):
679         (diffCommand):
680         (statusCommand):
681         (createPatchCommand):
682         (generateFileList):
683         (isAddedStatus):
684         (isConflictStatus):
685         (statusDescription):
686         (extractLineRange):
687
688 2011-12-14  Anders Carlsson  <andersca@apple.com>
689
690         Work around a bug in the MSVC2005 compiler
691         https://bugs.webkit.org/show_bug.cgi?id=74550
692
693         Reviewed by Sam Weinig.
694
695         Re-enable tests.
696
697         * TestWebKitAPI/Tests/WTF/Functional.cpp:
698
699 2011-12-14  Csaba Osztrogonác  <ossy@webkit.org>
700
701         [Qt] Test fonts are not used with Qt5
702         https://bugs.webkit.org/show_bug.cgi?id=72513
703
704         My last unreviewed buildfix for this crazy bug.
705
706         * qmake/mkspecs/features/features.prf:
707
708 2011-12-14  Anders Carlsson  <andersca@apple.com>
709
710         Another attempt at fixing the Windows build.
711
712         Disable all the tests until I can figure out what's going on here.
713
714         * TestWebKitAPI/Tests/WTF/Functional.cpp:
715
716 2011-12-14  Anders Carlsson  <andersca@apple.com>
717
718         Fix the Windows build.
719
720         Disable some of the tests for now.
721
722         * TestWebKitAPI/Tests/WTF/Functional.cpp:
723
724 2011-12-14  Anders Carlsson  <andersca@apple.com>
725
726         bind should handle member functions
727         https://bugs.webkit.org/show_bug.cgi?id=74529
728
729         Reviewed by Sam Weinig.
730
731         Add tests.
732
733         * TestWebKitAPI/Tests/WTF/Functional.cpp:
734         (TestWebKitAPI::A::A):
735         (TestWebKitAPI::A::f):
736         (TestWebKitAPI::A::addF):
737         (TestWebKitAPI::TEST):
738
739 2011-12-14  Anders Carlsson  <andersca@apple.com>
740
741         Add unary and binary bind overloads
742         https://bugs.webkit.org/show_bug.cgi?id=74524
743
744         Reviewed by Sam Weinig.
745
746         Add tests.
747
748         * TestWebKitAPI/Tests/WTF/Functional.cpp:
749         (TestWebKitAPI::TEST):
750         (TestWebKitAPI::multiplyByTwo):
751         (TestWebKitAPI::multiplyByOneAndAHalf):
752         (TestWebKitAPI::multiply):
753         (TestWebKitAPI::subtract):
754
755 2011-12-14  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
756
757         [Qt] Test fonts are not used with Qt5
758         https://bugs.webkit.org/show_bug.cgi?id=72513
759
760         MIPS and SH4 buildfix after r102776 and r102795.
761
762         Reviewed by Csaba Osztrogonác.
763
764         * qmake/mkspecs/features/features.prf:
765
766 2011-12-14  Csaba Osztrogonác  <ossy@webkit.org>
767
768         [Qt] Unreviewed speculative MIPS and SH4 buildfix after r102776.
769
770         * qmake/mkspecs/features/features.prf:
771
772 2011-12-14  Andreas Kling  <kling@webkit.org>
773
774         Make my e-mail address a little more awesome.
775
776         * Scripts/webkitpy/common/config/committers.py:
777
778 2011-12-14  Csaba Osztrogonác  <ossy@webkit.org>
779
780         [Qt] Rollout r102769, because it broke Qt-4.8 builds.
781
782         * qmake/mkspecs/features/webcore.prf:
783
784 2011-12-14  Balazs Kelemen  <kbalazs@webkit.org>
785
786         [Qt] Test fonts are not used with Qt5
787         https://bugs.webkit.org/show_bug.cgi?id=72513
788
789         Reviewed by Simon Hausmann.
790
791         Don't depend on Q_WS_X11 anymore since it's not the Qt5
792         way to detect the platform. Make the guards depend
793         on our own configtest for fontconfig. For Qt4 we can still
794         use the preassumption that we have it on Linux.
795
796         * DumpRenderTree/qt/DumpRenderTree.pro:
797         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
798         (WebCore::DumpRenderTree::open):
799         (WebCore::DumpRenderTree::initializeFonts):
800         * DumpRenderTree/qt/DumpRenderTreeQt.h:
801         * DumpRenderTree/qt/main.cpp:
802         (main): Additionally remove a nonsense piece of code that was
803         trying to reset the font settings - which is not necessary -
804         after we have already returned from main.
805         * WebKitTestRunner/InjectedBundle/Target.pri:
806         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
807         (WTR::activateFonts):
808         * WebKitTestRunner/Target.pri: Remove unnecessary fontconfig linkage
809         from WTR. It is not needed. We set up the fonts via the injected bundle.
810         * qmake/config.tests/fontconfig/fontconfig.cpp: Added.
811         (main):
812         * qmake/config.tests/fontconfig/fontconfig.pro: Added.
813         * qmake/mkspecs/features/features.prf:
814         * qmake/sync.profile:
815
816 2011-12-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
817
818         [Qt] Don't add WebCoreSupport and WebKit APIs to include WebCore's include path
819
820         Followup to r102679
821
822         https://bugs.webkit.org/show_bug.cgi?id=74413
823
824         Reviewed by Simon Hausmann.
825
826         * qmake/mkspecs/features/webcore.prf:
827
828 2011-12-14  Pierre Rossi  <pierre.rossi@gmail.com>
829
830         [Qt] Mobile theme could use a little refresh
831         https://bugs.webkit.org/show_bug.cgi?id=74293
832
833         Have MiniBrowser use the mobile theme when not
834         passed --desktop.
835
836         Reviewed by Kenneth Rohde Christiansen.
837
838         * MiniBrowser/qt/MiniBrowserApplication.cpp:
839         (MiniBrowserApplication::handleUserOptions):
840
841 2011-12-14  João Paulo Rechi Vita  <jprvita@openbossa.org>
842
843         [Qt] [Gardening] Remove qt-4.7 layout tests dir
844         https://bugs.webkit.org/show_bug.cgi?id=74426
845
846         Building trunk now depends on Qt >= 4.8, so no need to keep this directory
847         on the tree.
848
849         Reviewed by Csaba Osztrogonác.
850
851         * Scripts/webkitpy/layout_tests/port/qt.py:
852         (QtPort.qt_version):
853         (QtPort.baseline_search_path):
854         (QtPort._skipped_file_search_paths):
855         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
856         (QtPortTest._assert_search_path):
857
858 2011-12-14  Kentaro Hara  <haraken@chromium.org>
859
860         [Refactoring] In prepare-ChangeLog, make $isGit and $isSVN be used only
861         through parameter passing
862         https://bugs.webkit.org/show_bug.cgi?id=74485
863
864         Reviewed by Ryosuke Niwa.
865
866         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
867         manner. This bug is one of the incremental refactorings to remove all top-level
868         code and global variables from prepare-ChangeLog. In this patch,
869         we make the following global variables be used only through parameter passing.
870             - $isGit
871             - $isSVN
872
873         * Scripts/prepare-ChangeLog:
874         (generateFunctionLists):
875         (printDiff):
876         (diffFromToString):
877         (diffCommand):
878         (statusCommand):
879         (createPatchCommand):
880         (diffHeaderFormat):
881         (generateFileList):
882         (isAddedStatus):
883         (isConflictStatus):
884         (statusDescription):
885         (extractLineRange):
886
887 2011-12-14  Alexander Færøy  <alexander.faeroy@nokia.com>
888
889         [Qt] DeviceOrientationClientMockQt should be removed in favor of DeviceOrientationClientMock
890         https://bugs.webkit.org/show_bug.cgi?id=74417
891
892         Reviewed by Simon Hausmann.
893
894         Based on original patch by Kenneth Christiansen.
895
896         Already covered by current tests.
897
898         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
899         (WebCore::DumpRenderTree::DumpRenderTree):
900         (WebCore::DumpRenderTree::~DumpRenderTree):
901         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
902         (LayoutTestController::setMockDeviceOrientation):
903
904 2011-12-03  Philippe Normand  <pnormand@igalia.com>
905
906         [GTK] Bad text rendering since r101343
907         https://bugs.webkit.org/show_bug.cgi?id=73744
908
909         Reviewed by Martin Robinson.
910
911         Turn cairo hint metrics off for better font metrics reporting in
912         the tests. This is especially important for SVG.
913
914         * DumpRenderTree/gtk/DumpRenderTree.cpp:
915         (initializeGtkFontSettings):
916         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
917         (WTR::initializeGtkSettings):
918
919 2011-12-13  Kentaro Hara  <haraken@chromium.org>
920
921         [Refactoring] Remove several global variables from prepare-ChangeLog
922         https://bugs.webkit.org/show_bug.cgi?id=74389
923
924         Reviewed by David Kilzer.
925
926         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
927         manner. This bug is one of the incremental refactorings to remove all top-level
928         code and global variables from prepare-ChangeLog. In this patch,
929         we make the following global variables being used only through parameter passing.
930             - %paths
931             - $changedFiles
932             - $conflictFiles
933             - $functionLists
934             - $bugURL
935
936         * Scripts/prepare-ChangeLog:
937         (findChangeLogs):
938         (generateNewChangeLogs):
939         (processPaths):
940         (generateFileList):
941         (firstDirectoryOrCwd):
942
943 2011-12-13  Anders Carlsson  <andersca@apple.com>
944
945         Add a very bare-bones implementation of bind and Function to WTF
946         https://bugs.webkit.org/show_bug.cgi?id=74462
947
948         Reviewed by Sam Weinig.
949
950         Add basic tests for WTF::Function and WTF::bind.
951
952         * TestWebKitAPI/TestWebKitAPI.gypi:
953         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
954         * TestWebKitAPI/Tests/Functional.cpp: Added.
955         (TestWebKitAPI::returnFortyTwo):
956         (TestWebKitAPI::TEST):
957         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
958
959 2011-12-13  Robin Dunn  <robin@alldunn.com>
960
961         [wx] Add a URL argument to wxWebView constructor.
962         https://bugs.webkit.org/show_bug.cgi?id=74316
963         
964         Reviewed by Kevin Ollivier.
965
966         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
967         (MyApp::OnInit):
968         * wx/browser/browser.cpp:
969         (MyApp::OnInit):
970
971 2011-12-13  Raphael Kubo da Costa  <kubo@profusion.mobi>
972
973         watchlist: Add watchlist for EFL, CMake and libsoup code and put myself on it.
974         https://bugs.webkit.org/show_bug.cgi?id=74430
975
976         Reviewed by David Levin.
977
978         * Scripts/webkitpy/common/config/watchlist:
979
980 2011-12-13  Peter Beverloo  <peter@chromium.org>
981
982         [Chromium] Pull in FreeType and decrease check-out complexity for Android
983         https://bugs.webkit.org/show_bug.cgi?id=74401
984
985         Decrease the check-out complexity by removing the need to first run
986         "update-webkit-chromium --chromium" prior to running it with
987         "--chromium-android", which was caused by an unversioned third_party/
988         directory being created. This moves the Android NDK to Source/WebKit/
989         chromium/, coming from third_party/ in that directory.
990
991         Reviewed by Adam Barth.
992
993         * Scripts/update-webkit-chromium:
994         * Scripts/webkitdirs.pm:
995         (buildChromiumMakefile):
996
997 2011-12-13  Andy Wingo  <wingo@igalia.com> and Martin Robinson <mrobinson@igalia.com>
998
999         build-jsc passing incorrect args to buildGtkProject
1000         https://bugs.webkit.org/show_bug.cgi?id=74308
1001
1002         Reviewed by Gustavo Noronha Silva.
1003
1004         * Scripts/build-webkit: Instead of invoking buildGtkProject with
1005         another argument about webkit2, unshift a --disable-webkit2
1006         argument onto the buildArgs.
1007         * Scripts/webkitdirs.pm: Remove $enableWebKit2 arg. Only save autogen.sh
1008         arguments for WebKit to prevent unnecessary reconfiguration when build-webkit
1009         and build-jsc are run one after the other.
1010
1011 2011-12-13  Csaba Osztrogonác  <ossy@webkit.org>
1012
1013         [Qt] REGRESSION(102679): It broke Qt5-WK1 build
1014         https://bugs.webkit.org/show_bug.cgi?id=74413
1015
1016         Unreviewed buildfix.
1017
1018         * qmake/mkspecs/features/webcore.prf: Temporarily revert a part of r102679 until a proper fix.
1019
1020 2011-12-13  Csaba Osztrogonác  <ossy@webkit.org>
1021
1022         [Qt] Unreviewed speculativ debug buildfix after r102679.
1023
1024         * QtTestBrowser/QtTestBrowser.pro:
1025         * QtTestBrowser/main.cpp:
1026
1027 2011-12-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1028
1029         [Qt] Get rid of layering violations in includes
1030
1031         WebKit/qt/API and WebKit/qt/WebCoreSupport should not be included
1032         in the webcore.prf, but rather in each target that specificly needs
1033         headers in these location. We used to include them directly in webcore
1034         since we had layering violations between WebCore and WebKit, but now
1035         that they are gone there's no reason to do that.
1036
1037         Reviewed by Simon Hausmann.
1038
1039         * DumpRenderTree/qt/DumpRenderTree.pro:
1040         * QtTestBrowser/launcherwindow.h:
1041         * WebKitTestRunner/InjectedBundle/Target.pri:
1042         * qmake/mkspecs/features/webcore.prf:
1043         * qmake/mkspecs/features/webkit2.prf:
1044
1045 2011-12-13  János Badics  <dicska@gmail.com>
1046
1047         [NRWT] It crashes intermittently when there are WebProcess crashes
1048         https://bugs.webkit.org/show_bug.cgi?id=73451
1049
1050         Use self.poll() instead of self._proc.poll() because it checks if self._proc is None or not.
1051
1052         Reviewed by Kenneth Rohde Christiansen.
1053
1054         * Scripts/webkitpy/layout_tests/port/server_process.py:
1055         (ServerProcess._check_for_crash):
1056
1057 2011-12-13  Carlos Garcia Campos  <cgarcia@igalia.com>
1058
1059         Unreviewed. Fix GTK+ API docs build.
1060
1061         * gtk/generate-gtkdoc:
1062         (get_webkit2_options): Ignore WebKitUIClient since it's private
1063         API.
1064
1065 2011-12-13  Kenichi Ishibashi  <bashi@chromium.org>
1066
1067         Reviewed, removed one of my email addresses to use the apprpriate one.
1068
1069         * Scripts/webkitpy/common/config/committers.py:
1070
1071 2011-12-12  Ádám Kallai  <Kallai.Adam@stud.u-szeged.hu>
1072
1073         [Qt] Fix skip list search path and expected file search path in ORWT
1074         https://bugs.webkit.org/show_bug.cgi?id=74281
1075
1076         Expected file search path fixed.
1077
1078         Print all used skipped list and expected search path in verbose mode similar to NRWT.
1079
1080         Reviewed by Csaba Osztrogonác.
1081
1082         * Scripts/old-run-webkit-tests:
1083         (buildPlatformResultHierarchy):
1084         (buildPlatformTestHierarchy):
1085         (readSkippedFiles):
1086
1087 2011-12-12  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
1088
1089         [Qt] Missing layoutTestController.dumpWillCacheResponse
1090         https://bugs.webkit.org/show_bug.cgi?id=74287
1091
1092         Reviewed by Csaba Osztrogonác.
1093
1094         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1095         (LayoutTestController::reset):
1096         (LayoutTestController::dumpWillCacheResponse):
1097         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1098
1099 2011-12-12  Martin Robinson  <mrobinson@igalia.com>
1100
1101         [GTK] platform/gtk/fonts/custom-font-missing-glyphs.html fails on 64-bit Debug
1102         https://bugs.webkit.org/show_bug.cgi?id=73771
1103
1104         Reviewed by Gustavo Noronha Silva.
1105
1106         When using a fallback font during testing, always use DejaVu Sans. This prevents
1107         falling back to DejaVu Serif on some systems.
1108
1109         * DumpRenderTree/gtk/fonts/fonts.conf: Fall back to DejaVu Sans.
1110
1111 2011-12-08  Pierre Rossi  <pierre.rossi@gmail.com>
1112
1113         Add myself as a committer
1114
1115         * Scripts/webkitpy/common/config/committers.py:
1116
1117 2011-12-12  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1118
1119         [Qt] [WK2] Support customizing popup menus with QML
1120         https://bugs.webkit.org/show_bug.cgi?id=73560
1121
1122         Reviewed by Tor Arne Vestbø.
1123
1124         Add an Item Selector to our WebView using the experimental API.
1125
1126         * MiniBrowser/qt/MiniBrowser.pro:
1127         * MiniBrowser/qt/MiniBrowser.qrc:
1128         * MiniBrowser/qt/qml/BrowserWindow.qml:
1129         * MiniBrowser/qt/qml/ItemSelector.qml: Added.
1130
1131 2011-12-12  Alexander Færøy  <alexander.faeroy@nokia.com>
1132
1133         [Qt] MiniBrowser should only visualize mock touch points when in non-desktop mode
1134         https://bugs.webkit.org/show_bug.cgi?id=74283
1135
1136         Reviewed by Simon Hausmann.
1137
1138         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1139         (MiniBrowserApplication::sendTouchEvent):
1140
1141 2011-12-12  Kentaro Hara  <haraken@chromium.org>
1142
1143         [Refactoring] In prepare-ChangeLog, move into a method the top-level code
1144         to show ChangeLogs diff and open ChangeLogs in an editor
1145         https://bugs.webkit.org/show_bug.cgi?id=74266
1146
1147         Reviewed by Ryosuke Niwa.
1148
1149         We are planning to write unit-tests for prepare-ChangeLog
1150         in a run-leaks_unittest manner. This patch is one of the incremental
1151         refactorings to remove all top-level code and global variables from
1152         prepare-ChangeLog.
1153
1154         * Scripts/prepare-ChangeLog: Moved the top-level code to show ChangeLogs diff into printDiff().
1155         Moved the top-level code to open ChangeLogs in an editor into openChangeLogs().
1156         Renamed @changed_files to @changedFiles.
1157         Renamed %conflict_files to %conflictFiles.
1158         (generateFunctionLists):
1159         (printDiff):
1160         (openChangeLogs):
1161
1162 2011-12-11  Kentaro Hara  <haraken@chromium.org>
1163
1164         [Refactoring] Move top-level code to resolve conflicted ChangeLogs into a method
1165         https://bugs.webkit.org/show_bug.cgi?id=74257
1166
1167         Reviewed by Ryosuke Niwa.
1168
1169         We are planning to write unit-tests for prepare-ChangeLog
1170         in a run-leaks_unittest/ manner. This patch is one of the incremental
1171         refactorings to remove all top-level code and global variables from
1172         prepare-ChangeLog.
1173
1174         * Scripts/prepare-ChangeLog: Moved top-level code to get the latest ChangeLogs
1175         into getLatestChangeLogs(), and moved top-level code to resolve conflicted ChangeLogs
1176         into resolveConflictedChangeLogs().
1177         (getLatestChangeLogs):
1178         (resolveConflictedChangeLogs):
1179
1180 2011-12-11  Kentaro Hara  <haraken@chromium.org>
1181
1182         [Refactoring] Move top-level code to generate a new ChangeLog into a method
1183         https://bugs.webkit.org/show_bug.cgi?id=74253
1184
1185         Reviewed by David Kilzer.
1186
1187         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing,
1188         which requires to remove top-level code and global variables. This patch is one of
1189         the incremental refactorings for that.
1190
1191         * Scripts/prepare-ChangeLog: Moved top-level code to generate a new ChangeLog into generateNewChangeLogs().
1192         (generateFunctionLists):
1193         (findChangeLogs):
1194         (generateNewChangeLogs):
1195         (generateFileList): Removed an unnecessary variable $didChangeRegressionTests.
1196
1197 2011-12-10  Kentaro Hara  <haraken@chromium.org>
1198
1199         [Refactoring] In prepare-ChangeLog, move top-level code to find ChangeLogs into a method
1200         https://bugs.webkit.org/show_bug.cgi?id=74175
1201
1202         Reviewed by Ryosuke Niwa.
1203
1204         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
1205         This requires to remove top-level code. This patch is one of the incremental refactorings
1206         for that.
1207
1208         * Scripts/prepare-ChangeLog: Moved top-level code to find ChangeLogs into findChangeLogs().
1209         (findChangeLogs):
1210
1211 2011-12-10  Andreas Kling  <kling@webkit.org>
1212
1213         Add my Apple e-mail to committers.py.
1214
1215         * Scripts/webkitpy/common/config/committers.py:
1216
1217 2011-12-09  Dirk Pranke  <dpranke@chromium.org>
1218
1219         chromium win build: revert build_webkit_exes_from_webkit_gyp change
1220         https://bugs.webkit.org/show_bug.cgi?id=74225
1221
1222         This change sets build_webkit_exes_from_webkit_gyp back to 1;
1223         the "All.gyp" solution doesn't work on windows.
1224
1225         * Scripts/webkitdirs.pm:
1226         (buildChromium):
1227
1228 2011-12-09  Hugo Parente Lima  <hugo.lima@openbossa.org>
1229
1230         [Qt] Click's count is limited to three continuous clicks.
1231         https://bugs.webkit.org/show_bug.cgi?id=45666
1232
1233         Reviewed by Kenneth Rohde Christiansen.
1234
1235         Update m_time at every call to leapForward, so double clicks
1236         event are correctly sent by EventSender.
1237
1238         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1239         (WTR::EventSenderProxy::updateClickCountForButton):
1240         (WTR::EventSenderProxy::leapForward):
1241
1242 2011-12-09  Kentaro Hara  <haraken@chromium.org>
1243
1244         [Refactoring] Reduce top-level code in prepare-ChangeLog
1245         https://bugs.webkit.org/show_bug.cgi?id=74172
1246
1247         Reviewed by Ryosuke Niwa.
1248
1249         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
1250         This requires to remove top-level code. This patch is one of the incremental refactorings
1251         for that.
1252
1253         * Scripts/prepare-ChangeLog: Moved some top-level code into generateFunctionLists().
1254         (generateFunctionLists):
1255
1256 2011-12-09  Sam Weinig  <sam@webkit.org>
1257
1258         Expose a WKConnectionRef which represents the connection to/from the WebProcess/UIProcess
1259         https://bugs.webkit.org/show_bug.cgi?id=74218
1260
1261         Reviewed by Anders Carlsson.
1262
1263         Add a test of the WKConnectionRef API.
1264
1265         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1266         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp: Added.
1267         (TestWebKitAPI::didCreateConnection):
1268         (TestWebKitAPI::connectionDidReceiveMessage):
1269         (TestWebKitAPI::connectionDidClose):
1270         (TestWebKitAPI::TEST):
1271         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp: Added.
1272         (TestWebKitAPI::connectionDidReceiveMessage):
1273         (TestWebKitAPI::WKConnectionTest::WKConnectionTest):
1274         (TestWebKitAPI::WKConnectionTest::initialize):
1275
1276 2011-12-09  David Levin  <levin@chromium.org>
1277
1278         Hash* iterators should allow comparison between const and const versions.
1279         https://bugs.webkit.org/show_bug.cgi?id=73370
1280
1281         Reviewed by Darin Adler.
1282
1283         * TestWebKitAPI/TestWebKitAPI.gypi: Add the new test file to the build.
1284         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
1285         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
1286         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Added.
1287         (TestWebKitAPI::TEST): Add a test for the new functionality.
1288
1289 2011-12-09  Dirk Pranke  <dpranke@chromium.org>
1290
1291         chromium: visual studio projects are busted when build_webkit_exes_from_webkit_gyp==0
1292         https://bugs.webkit.org/show_bug.cgi?id=74212
1293
1294         Reviewed by Tony Chang.
1295
1296         The change introduced in r102201 to split the executables out of
1297         WebKit.gyp apparently doesn't work right on Windows, since
1298         WebKit.gyp and Tools.gyp refer to dependent projects by
1299         different relative paths (it appears gyp doesn't normalize the
1300         paths). This change moves Tools.gyp to be in the same directory
1301         as WebKit.gyp (and All.gyp), which should fix this and
1302         conveniently will also solve the problem of how to add Tools.gyp
1303         to the chromium DEPS file.
1304
1305         * Tools.gyp: Renamed to ../Source/WebKit/chromium/Tools.gyp
1306
1307 2011-12-09  Kentaro Hara  <haraken@chromium.org>
1308
1309         [Refactoring] In prepare-ChangeLog, move top-level code to fetch a bug description from URL into a method
1310         https://bugs.webkit.org/show_bug.cgi?id=74173
1311
1312         Reviewed by Ryosuke Niwa.
1313
1314         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
1315         This requires to remove top-level code. This patch is one of the incremental refactorings
1316         for that.
1317
1318         * Scripts/prepare-ChangeLog: Moved top-level code to fetch a bug description from URL into fetchBugDescriptionFromURL().
1319         (fetchBugDescriptionFromURL):
1320
1321 2011-12-09  Tony Chang  <tony@chromium.org>
1322
1323         Switch the chromium mac bots to using skia test results
1324         https://bugs.webkit.org/show_bug.cgi?id=74201
1325
1326         Reviewed by Ryosuke Niwa.
1327
1328         This is reverting http://trac.webkit.org/changeset/97781 and changing
1329         the name in master.cfg to no longer have cg in the name.
1330
1331         * BuildSlaveSupport/build.webkit.org-config/config.json:
1332         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1333         (appendCustomBuildFlags):
1334         (RunWebKitTests.start):
1335
1336 2011-12-09  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1337
1338         [Qt] Remove a wrongly placed ASSERT.
1339
1340         Reviewed by Tor Arne Vestbø.
1341
1342         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1343         (MiniBrowserApplication::notify):
1344
1345 2011-12-09  Cary Clark  <caryclark@google.com>
1346
1347         layout_test update to accommodate new use_skia=1 default on Chromium-Mac
1348         https://bugs.webkit.org/show_bug.cgi?id=74118
1349
1350         Reviewed by Adam Barth.
1351
1352         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1353         (get):
1354         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1355         (ChromiumMacPort.__init__):
1356         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1357         (ChromiumMacPortTest.test_versions):
1358         (ChromiumMacPortTest.test_graphics_type):
1359
1360 2011-12-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1361
1362         [Qt] Use new qmake option in Qt5 to prevent dependency issues with GNUmake
1363
1364         The GNUmake + gcc_MD_depends options together produce .d files using GCC, but
1365         this failed when moving files in the source tree, as the .d file would contain
1366         stale dependencies on the old source file location. By keeping the object files
1367         (and hence the depdendency files) in a proper tree structure inside the objects
1368         directory we can prevent this failure.
1369
1370         A side benefit is that we can also have objects with the same name inside the
1371         same project.
1372
1373         Reviewed by Simon Hausmann.
1374
1375         * qmake/mkspecs/features/unix/default_pre.prf:
1376
1377 2011-12-09  Csaba Osztrogonác  <ossy@webkit.org>
1378
1379         Unreviewed. Update unit test after r102412.
1380
1381         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1382         (IRCCommandTest.test_whois):
1383
1384 2011-12-09  Kentaro Hara  <haraken@chromium.org>
1385
1386         REGRESSION(r102105): run-bindings-tests should output full diff results
1387         https://bugs.webkit.org/show_bug.cgi?id=74166
1388
1389         Reviewed by Adam Barth.
1390
1391         Since r102105, the output of run-bindings-tests is truncated to 500 characters.
1392         run-bindings-tests should output full diff results.
1393
1394         * Scripts/webkitpy/bindings/main.py: Replaced e.message_with_output() with e.output.
1395         (BindingsTests.generate_from_idl):
1396         (BindingsTests.generate_supplemental_dependency):
1397         (BindingsTests.detect_changes):
1398
1399 2011-12-09  Simon Hausmann  <simon.hausmann@nokia.com>
1400
1401         [Qt] Fix compilation with newly separated Qt 5 QtQuick module
1402         https://bugs.webkit.org/show_bug.cgi?id=73990
1403
1404         Reviewed by Kenneth Rohde Christiansen, tweaked by Csaba Osztrogonác.
1405
1406         Fix QtQuick includes after move from QtDeclarative to QtQuick.
1407
1408         * MiniBrowser/qt/BrowserWindow.h:
1409         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1410
1411 2011-12-08  Adam Klein  <adamk@chromium.org>
1412
1413         [MutationObservers] V8LazyEventHandler breaks microtask delivery semantics
1414         https://bugs.webkit.org/show_bug.cgi?id=73492
1415
1416         Reviewed by Adam Barth.
1417
1418         Add eventSender.scheduleAsynchronousKeyDown, needed to cause a
1419         keypress event without any script on the stack.
1420
1421         * DumpRenderTree/chromium/EventSender.cpp:
1422         (EventSender::EventSender):
1423         (EventSender::keyDown):
1424         (KeyDownTask::KeyDownTask):
1425         (KeyDownTask::runIfValid):
1426         (EventSender::scheduleAsynchronousKeyDown):
1427         * DumpRenderTree/chromium/EventSender.h:
1428
1429 2011-12-08  Hayato Ito  <hayato@chromium.org>
1430
1431         [gdb] Pretty printer for a 8-bit version of WTF::StringImpl and LChar*.
1432         https://bugs.webkit.org/show_bug.cgi?id=73980
1433
1434         Reviewed by Tony Chang.
1435
1436         * gdb/webkit.py:
1437         (guess_string_length):
1438         (ustring_to_string):
1439         (lstring_to_string):
1440         (LCharStringPrinter):
1441         (LCharStringPrinter.to_string):
1442         (WTFStringImplPrinter.get_length):
1443         (WTFStringImplPrinter.to_string):
1444         (WTFStringImplPrinter.is_8bit):
1445         (WTFStringPrinter.stringimpl_ptr):
1446         (WTFStringPrinter.get_length):
1447         (WTFStringPrinter.to_string):
1448         (add_pretty_printers.lookup_function):
1449
1450 2011-12-08  Pierre Rossi  <pierre.rossi@gmail.com>
1451
1452         Drop ENABLE_NO_LISTBOX_RENDERING, and make it a runtime decision.
1453         https://bugs.webkit.org/show_bug.cgi?id=73916
1454
1455         Reviewed by Kent Tamura.
1456
1457         * qmake/mkspecs/features/features.prf:
1458
1459 2011-12-08  Adrienne Walker  <enne@google.com>
1460
1461         Unreviewed contributor additions to committers.py.
1462
1463         * Scripts/webkitpy/common/config/committers.py:
1464
1465 2011-12-08  David Reveman  <reveman@chromium.org>
1466
1467         [Chromium] Add per-tile painting flag to DumpRenderTree and rename AcceleratedDrawing to AcceleratedPainting in chromium specific code.
1468         https://bugs.webkit.org/show_bug.cgi?id=74017
1469
1470         Reviewed by James Robinson.
1471         
1472         Add support for command line flag enable-per-tile-painting in DumpRenderTree.
1473
1474         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1475         (main):
1476         * DumpRenderTree/chromium/TestShell.cpp:
1477         (TestShell::TestShell):
1478         (TestShell::resetWebSettings):
1479         * DumpRenderTree/chromium/TestShell.h:
1480         (TestShell::setAcceleratedPaintingEnabled):
1481         (TestShell::setPerTilePaintingEnabled):
1482         * DumpRenderTree/chromium/WebPreferences.cpp:
1483         (WebPreferences::reset):
1484         (WebPreferences::applyTo):
1485         * DumpRenderTree/chromium/WebPreferences.h:
1486         * Scripts/webkitpy/layout_tests/port/chromium.py:
1487         (ChromiumDriver._wrapper_options):
1488         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1489         (parse_args):
1490
1491 2011-12-08  Dirk Pranke  <dpranke@chromium.org>
1492
1493         create a "SystemHost" object for webkitpy to slim down the Host object
1494         https://bugs.webkit.org/show_bug.cgi?id=72680
1495
1496         Reviewed by Eric Siedel.
1497
1498         This creates a SystemHost object that other objects that should
1499         only have dependencies on functionality in webkitpy.common.system
1500         can use; this will allow them to not require a full Host.
1501
1502         * Scripts/webkitpy/common/host.py:
1503         * Scripts/webkitpy/common/host_mock.py:
1504         * Scripts/webkitpy/common/system/systemhost.py: Added.
1505         * Scripts/webkitpy/common/system/systemhost_mock.py: Added.
1506
1507 2011-12-08  Chris Fleizach  <cfleizach@apple.com>
1508
1509         AX: platform/mac/accessibility/search-with-frames.html crashes
1510         https://bugs.webkit.org/show_bug.cgi?id=74093
1511
1512         Reviewed by Darin Adler.
1513
1514         Take care of the case when an incoming element is null.
1515
1516         * DumpRenderTree/AccessibilityUIElement.cpp:
1517         (uiElementForSearchPredicateCallback):
1518         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1519         (AccessibilityUIElement::uiElementForSearchPredicate):
1520         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1521         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1522
1523 2011-12-08  Alexander Færøy  <ahf@0x90.dk>
1524
1525         [Qt] Visualize mock point ID's in the MiniBrowser
1526         https://bugs.webkit.org/show_bug.cgi?id=74098
1527
1528         Reviewed by Tor Arne Vestbø.
1529
1530         * MiniBrowser/qt/BrowserWindow.cpp:
1531         (BrowserWindow::updateVisualMockTouchPoints):
1532         * MiniBrowser/qt/qml/MockTouchPoint.qml:
1533
1534 2011-12-08  Dominic Mazzoni  <dmazzoni@google.com>
1535
1536         Accessibility: AccessibilityController should support listening to notifications on all elements.
1537         https://bugs.webkit.org/show_bug.cgi?id=72866
1538
1539         Adds addNotificationListener and removeNotificationListener methods
1540         to AccessibilityController, to listen to notifications on any element
1541         rather than a specific element. Mac (DRT and WKTR) and Chromium (DRT)
1542         implementations are all contained in this change.
1543
1544         On Mac, refactors AccessibilityNotificationHandler into its own
1545         source file that can be used by both AccessibilityController and
1546         AccessibilityUIElement. (Both DRT and WKTR.)
1547
1548         Reviewed by Chris Fleizach.
1549
1550         * DumpRenderTree/AccessibilityController.cpp:
1551         (addNotificationListenerCallback):
1552         (removeNotificationListenerCallback):
1553         (AccessibilityController::getJSClass):
1554         * DumpRenderTree/AccessibilityController.h:
1555         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1556         * DumpRenderTree/chromium/AccessibilityController.cpp:
1557         (AccessibilityController::AccessibilityController):
1558         (AccessibilityController::notificationReceived):
1559         (AccessibilityController::addNotificationListenerCallback):
1560         (AccessibilityController::removeNotificationListenerCallback):
1561         * DumpRenderTree/chromium/AccessibilityController.h:
1562         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1563         (AccessibilityController::addNotificationListener):
1564         (AccessibilityController::removeNotificationListener):
1565         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1566         (AccessibilityController::~AccessibilityController):
1567         (AccessibilityController::addNotificationListener):
1568         (AccessibilityController::removeNotificationListener):
1569         * DumpRenderTree/mac/AccessibilityNotificationHandler.h: Added.
1570         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm: Added.
1571         (-[NSString createJSStringRef]):
1572         (-[AccessibilityNotificationHandler init]):
1573         (-[AccessibilityNotificationHandler setPlatformElement:]):
1574         (-[AccessibilityNotificationHandler dealloc]):
1575         (-[AccessibilityNotificationHandler setCallback:]):
1576         (-[AccessibilityNotificationHandler startObserving]):
1577         (-[AccessibilityNotificationHandler _notificationReceived:]):
1578         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1579         (AccessibilityUIElement::addNotificationListener):
1580         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1581         (notificationListenerProc):
1582         (AccessibilityController::addNotificationListener):
1583         (AccessibilityController::removeNotificationListener):
1584         (AccessibilityController::winNotificationReceived):
1585         (AccessibilityController::winAddNotificationListener):
1586         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1587         (AccessibilityUIElement::addNotificationListener):
1588         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1589         (WTR::AccessibilityController::addNotificationListener):
1590         (WTR::AccessibilityController::removeNotificationListener):
1591         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
1592         (WTR::AccessibilityController::logAccessibilityEvents):
1593         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
1594         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
1595         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
1596         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
1597         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
1598         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm: Added.
1599         (WTR::AccessibilityController::addNotificationListener):
1600         (WTR::AccessibilityController::removeNotificationListener):
1601         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h: Added.
1602         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm: Added.
1603         (-[NSString createJSStringRef]):
1604         (-[AccessibilityNotificationHandler init]):
1605         (-[AccessibilityNotificationHandler setPlatformElement:]):
1606         (-[AccessibilityNotificationHandler dealloc]):
1607         (-[AccessibilityNotificationHandler setCallback:]):
1608         (-[AccessibilityNotificationHandler startObserving]):
1609         (-[AccessibilityNotificationHandler _notificationReceived:]):
1610         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1611         (WTR::AccessibilityUIElement::AccessibilityUIElement):
1612         (WTR::AccessibilityUIElement::verticalScrollbar):
1613         (WTR::AccessibilityUIElement::addNotificationListener):
1614         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1615
1616 2011-12-08  Csaba Osztrogonác  <ossy@webkit.org>
1617
1618         [Qt][WK2] Unreviewed buildfix after r102352.
1619
1620         * qmake/mkspecs/features/webkit2.prf:
1621
1622 2011-12-08  Adam Roben  <aroben@apple.com>
1623
1624         Make finding crash logs by PID work on Snow Leopard
1625
1626         Crash Reporter on Snow Leopard doesn't set the "app_description" extended attribute that we
1627         were using to check the PID of the crashed process. (Crash Reporter on Lion does.) Now we
1628         read the first line of the crash log and pull the PID out of there.
1629
1630         Fixes <http://webkit.org/b/74094> "webkit-patch crash-log <process> <PID>" doesn't work on
1631         Snow Leopard
1632
1633         Reviewed by Darin Adler.
1634
1635         * Scripts/webkitpy/common/system/crashlogs.py:
1636         (CrashLogs._find_newest_log_darwin): Read the first line of the crash log to get the process
1637         name and PID for the log, rather than checking the Lion-only app_description extended
1638         attribute. We now also reject the log if the process name doesn't match what we expect.
1639
1640         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
1641         (make_mock_crash_report_darwin): Added. Returns a mock crash report given a process name and
1642         PID.
1643         (CrashLogsTest.assertLinesEqual): Added. This is a compatibility shim around
1644         unittest.TestCase.assertMultiLineEqual, which didn't exist before Python 2.7.
1645         (CrashLogsTest.test_find_log_darwin): Made the mock crash reports more believable by using
1646         the new make_mock_crash_report_darwin function. Also added tests for files that can't be
1647         read, files that actually contain a crash log for some other process, and files that are
1648         misformatted.
1649
1650         * Scripts/webkitpy/common/system/filesystem.py: Removed FileSystem.getxattr, which is now
1651         unused.
1652
1653         * Scripts/webkitpy/common/system/filesystem_mock.py:
1654         (MockFileSystem.__init__): Removed xattr support, which is now unused.
1655         (MockFileSystem.open_text_file_for_reading): Changed to actually pass the file's data to
1656         ReadableTextFileObject. This function was completely broken before!
1657         (ReadableBinaryFileObject.__init__): Made the data parameter non-optional to try to prevent
1658         bugs like the above.
1659         (ReadableTextFileObject.__init__): Added. Wraps the data in a StringIO object so we can do
1660         things like readline() and seek().
1661
1662         (ReadableTextFileObject.close):
1663         (ReadableTextFileObject.read):
1664         Added. We override the superclass implementation to account for using a StringIO object.
1665
1666         (ReadableTextFileObject.readline):
1667         (ReadableTextFileObject.seek):
1668         Added. These just call through to StringIO.
1669
1670         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1671         (MainTest.test_crash_log):
1672         (MainTest.test_web_process_crash_log):
1673         Changed to use make_mock_crash_report_darwin.
1674
1675 2011-12-06  Jon Lee  <jonlee@apple.com>
1676
1677         [WK2] Add permissions support (73960)
1678         https://bugs.webkit.org/show_bug.cgi?id=73960
1679         <rdar://problem/10357008>
1680
1681         Reviewed by Darin Adler.
1682
1683         Add null function item to comply with added callback to WKPageUIClient.
1684
1685         * MiniBrowser/mac/BrowserWindowController.m:
1686         (-[BrowserWindowController awakeFromNib]):
1687         * WebKitTestRunner/TestController.cpp:
1688         (WTR::TestController::createOtherPage):
1689         (WTR::TestController::initialize):
1690
1691 2011-12-08  Alexander Færøy  <alexander.faeroy@nokia.com>
1692
1693         [Qt] Visualize mock points in the Qt MiniBrowser
1694         https://bugs.webkit.org/show_bug.cgi?id=74074
1695
1696         Reviewed by Tor Arne Vestbø.
1697
1698         * MiniBrowser/qt/BrowserWindow.cpp:
1699         (BrowserWindow::updateVisualMockTouchPoints):
1700         * MiniBrowser/qt/BrowserWindow.h:
1701         * MiniBrowser/qt/MiniBrowser.qrc:
1702         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1703         (MiniBrowserApplication::notify):
1704         (MiniBrowserApplication::sendTouchEvent):
1705         * MiniBrowser/qt/MiniBrowserApplication.h:
1706         * MiniBrowser/qt/icons/touchpoint.png: Added.
1707         * MiniBrowser/qt/qml/MockTouchPoint.qml: Added.
1708
1709 2011-12-08  Simon Hausmann  <simon.hausmann@nokia.com>
1710
1711         [Qt] WebKitTestRunner crashes with debug builds
1712         https://bugs.webkit.org/show_bug.cgi?id=74090
1713
1714         Reviewed by Tor Arne Vestbø.
1715
1716         * WebKitTestRunner/qt/TestControllerQt.cpp:
1717         (WTR::TestController::platformInitialize): Call QQuickWebView::platformInitialize
1718         to ensure WTF/JSC threading is initialized.
1719
1720 2011-12-08  Dirk Pranke  <dpranke@chromium.org>
1721
1722         fix build-webkit --chromium after breakage in r102201
1723         https://bugs.webkit.org/show_bug.cgi?id=74031
1724
1725         Reviewed by Tony Chang.
1726
1727         * Scripts/webkitdirs.pm:
1728         (buildChromium):
1729
1730 2011-12-08  Kentaro Hara  <haraken@chromium.org>
1731
1732         Unreviewed, rolling out r102280.
1733         http://trac.webkit.org/changeset/102280
1734         https://bugs.webkit.org/show_bug.cgi?id=74031
1735
1736         Chromium/Windows build is broken
1737
1738         * Scripts/webkitdirs.pm:
1739         (buildChromium):
1740
1741 2011-12-08  Nayan Kumar K  <nayankk@motorola.com>
1742
1743         Adding myself to committers list.
1744
1745         Unreviewed.
1746
1747         * Scripts/webkitpy/common/config/committers.py:
1748
1749 2011-12-07  Michael Saboff  <msaboff@apple.com>
1750
1751         StringBuilderTest.Append and StringBuilderTest.ToStringPreserveCapacity are failing.
1752         https://bugs.webkit.org/show_bug.cgi?id=73995
1753
1754         Reenabled failing tests that the code part of the patch fixes.
1755
1756         Reviewed by Geoffrey Garen.
1757
1758         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1759         (TestWebKitAPI::TEST):
1760
1761 2011-12-07  MORITA Hajime  <morrita@google.com>
1762
1763         [filter-build-webkit] should not emit reset color when --no-color is given
1764         https://bugs.webkit.org/show_bug.cgi?id=73992
1765
1766         Reviewed by Daniel Bates.
1767
1768         Stop printing control sequences when --no-color is given.
1769         After this change, the filter runs nicely even on environments
1770         like Emacs compilation-mode which cannot understand the control sequence.
1771
1772         * Scripts/filter-build-webkit:
1773         (printLine):
1774
1775 2011-12-07  Eric Seidel  <eric@webkit.org>
1776
1777         Use free memory to determine if we have space for DRT instances instead of total memory
1778         https://bugs.webkit.org/show_bug.cgi?id=74021
1779
1780         Reviewed by Adam Barth.
1781
1782         This will hopefully make the Mac buildbots behave better.
1783
1784         I also reduced the expected memory needed per DRT now that
1785         we're properly accounting for the system memory in our calculations.
1786
1787         * Scripts/webkitpy/common/system/platforminfo.py:
1788         (PlatformInfo.total_bytes_memory):
1789         (PlatformInfo._compute_free_bytes_from_vm_stat_output):
1790         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1791         (MockPlatformInfo.total_bytes_memory):
1792         * Scripts/webkitpy/layout_tests/port/base.py:
1793         (Port.default_child_processes):
1794         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1795         (PortTest.test_default_child_processes):
1796
1797 2011-12-07  Dirk Pranke  <dpranke@chromium.org>
1798
1799         fix build-webkit --chromium after breakage in r102201
1800         https://bugs.webkit.org/show_bug.cgi?id=74031
1801
1802         Reviewed by Tony Chang.
1803
1804         r102201 introduced a change to the chromium build that splits
1805         the executables out of WebKit.gyp into other gyp files, and adds
1806         a new "All.gyp" that builds everything. However, I forgot to
1807         update the build script to use All.gyp.
1808
1809         * Scripts/webkitdirs.pm:
1810         (buildChromium):
1811
1812 2011-12-07  Tom Zakrajsek  <tomz@codeaurora.org>
1813
1814         Moved myself to the committers list.
1815
1816         * Scripts/webkitpy/common/config/committers.py:
1817
1818 2011-11-30  Simon Hausmann  <simon.hausmann@nokia.com>
1819
1820         [Qt] Fix debug shlib build with V8.
1821
1822         Reviewed by Tor Arne Vestbø.
1823
1824         * qmake/mkspecs/features/qtwebkit.prf: Don't link jscore with
1825         v8 builds.
1826
1827 2011-11-30  Simon Hausmann  <simon.hausmann@nokia.com>
1828
1829         [Qt] V8 build fixes.
1830
1831         Reviewed by Tor Arne Vestbø.
1832
1833         * qmake/mkspecs/features/javascriptcore.prf: Don't add
1834         Source/Thirdparty to the include search path here.
1835         * qmake/mkspecs/features/webcore.prf: Instead it belongs here, because it's
1836         used when building WebCore as well as using it, because header files like
1837         GraphicsContext3D.h include stuff from ThirdParty.
1838
1839 2011-12-07  Peter Beverloo  <peter@chromium.org>
1840
1841         [Chromium] Fix project file generation for the Android bot after r102201
1842         https://bugs.webkit.org/show_bug.cgi?id=73996
1843
1844         The gyp refactoring in r102201 was didn't explicitly exclude
1845         the Android operating system in Tools/Tools.gyp, which broke
1846         as gcc_version is not defined for that configuration.
1847
1848         Reviewed by Andreas Kling.
1849
1850         * Tools.gyp:
1851
1852 2011-12-07  Vsevolod Vlasov  <vsevik@chromium.org>
1853
1854         Unreviewed. Disabled failing tests on chromium.
1855
1856         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1857         (TestWebKitAPI::TEST):
1858
1859 2011-12-06  Dirk Pranke  <dpranke@chromium.org>
1860
1861         binaries in webkit.gyp should be split into a new file to break circular dependencies on webkit_support
1862         https://bugs.webkit.org/show_bug.cgi?id=73382
1863
1864         Reviewed by Tony Chang.
1865
1866         XCode (and hence GYP) can't handle circular dependencies between
1867         files (and projects). Accordingly, although the binaries in
1868         WebKit.gyp depend on webkit_support and webkit_support depends
1869         on webkit, we don't mention the latter dependency in the file.
1870         To fix this, this change moves the binaries like DRT into a new
1871         GYP file, and modifies gyp_webkit to build from that file
1872         instead of WebKit.gyp.
1873
1874         * Tools.gyp: Added.
1875
1876 2011-12-06  Adam Roben  <aroben@apple.com>
1877
1878         Add a pid parameter to CrashLogs.find_newest_log
1879
1880         When a PID is passed, only crash logs corresponding to a crashed process with that PID are
1881         considered.
1882
1883         Fixes <http://webkit.org/b/73942> webkitpy provides no way to specify the PID of the crashed
1884         process whose crash log you want to find
1885
1886         Reviewed by Dirk Pranke.
1887
1888         * Scripts/webkitpy/common/system/crashlogs.py:
1889         (CrashLogs.find_newest_log): Added an optional pid parameter.
1890         (CrashLogs._find_newest_log_darwin): Added a pid parameter. When specified, we look at each
1891         candidate log's app_description extended attribute to see if that log corresponds to a
1892         crashed process with the specified PID.
1893
1894         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
1895         (CrashLogsTest.test_find_newest_log_darwin): Added a few more mock crash logs with various
1896         contents and PIDs. Added tests that show that the pid parameter to find_newest_log is
1897         respected. Also fixed an erroneous use of assertTrue instead of assertEqual.
1898
1899         * Scripts/webkitpy/common/system/filesystem.py:
1900         (FileSystem.getxattr): Added. On Darwin, calls through to the xattr module. On other
1901         systems, raises a KeyError, mimicking the behavior on Darwin when the given attribute isn't
1902         present.
1903
1904         * Scripts/webkitpy/common/system/filesystem_mock.py:
1905         (MockFileSystem.__init__): Added an optional xattrs parameter. Documented other parameters.
1906         (MockFileSystem.getxattr): Added. Just pulls the given attribute out of the xattrs
1907         dictionary.
1908
1909         * Scripts/webkitpy/tool/commands/queries.py:
1910         (CrashLog): Added help text. Added an optional PID parameter.
1911         (CrashLog.execute): Pass the PID, if any, through to find_newest_log.
1912
1913 2011-12-06  Adam Roben  <aroben@apple.com>
1914
1915         Wait for Crash Reporter to finish even when it lets the crashed process die quickly
1916
1917         NRWT was only waiting for Crash Reporter in cases where it was keeping the crashed process
1918         alive beyond the normal timeout limit. In cases where the crashed process was able to die
1919         faster, NRWT would assume that Crash Reporter had finished even though it often was still
1920         running, which would lead to an incorrect crash log being picked up.
1921
1922         Part of <http://webkit.org/b/71380> NRWT incorrectly associates crash logs with tests
1923
1924         Reviewed by Dirk Pranke.
1925
1926         * Scripts/webkitpy/layout_tests/port/server_process.py:
1927         (ServerProcess._reset):
1928         (ServerProcess.write):
1929         (ServerProcess._check_for_crash): Changed to use new set_crashed function instead of setting
1930         .crashed directly. Added wait_for_crash_reporter parameter, which we pass along to
1931         set_crashed.
1932
1933         (ServerProcess._handle_timeout): Fixed a logic error that would cause .crashed and
1934         .timed_out both to be set to True in cases where Crash Reporter took a long time to run. Now
1935         we bail out of handling the failure as a timeout if we find out that the process in fact
1936         crashed. We tell _check_for_crash not to wait for Crash Reporter because we've already done
1937         so.
1938         (ServerProcess.set_crashed): Added. When the process crashes, we wait for Crash Reporter to
1939         finish running (unless directed otherwise) so we can be sure the crash log has been saved to
1940         disk.
1941
1942         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
1943         (TrivialMockPort.is_crash_reporter): Added.
1944
1945         * Scripts/webkitpy/layout_tests/port/webkit.py:
1946         (WebKitDriver._check_for_driver_crash): Changed to use set_crashed. (This also fixed a typo
1947         that would have partially broken crash detection on Windows, if NRWT worked on Windows.)
1948
1949 2011-12-06  Adam Barth  <abarth@webkit.org>
1950
1951         NRWT fails on unreleased versions of Mac OS X
1952         https://bugs.webkit.org/show_bug.cgi?id=72748
1953
1954         Reviewed by Dirk Pranke.
1955
1956         Hopefully this patch will make NRWT work on future versions on Mac OS X.
1957         Most of the infrastructure was already in place, but there were some
1958         asserts that failed.  I've tested this patch by haxoring the version
1959         detection logic to simulate an unknown version.  We might need to
1960         iterate based on feedback from folks with a real future version.
1961
1962         * Scripts/webkitpy/layout_tests/port/apple.py:
1963         (ApplePort.__init__):
1964             - mac-future is an allowed port_name that's used internally by
1965               webkitpy to represent future versions of Mac OS X.
1966         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1967         (test_versions):
1968             - Test that we don't throw exceptions when dealing with future
1969               versions of Mac OS X.
1970         * Scripts/webkitpy/layout_tests/port/webkit.py:
1971         (WebKitPort._expectations_from_skipped_files):
1972             - Demote this logging message to "debug".  It's expected that
1973               mac-future doesn't have a Skipped file.
1974         * Scripts/webkitpy/layout_tests/port/mac.py:
1975         (MacPort.__init__):
1976         * Scripts/webkitpy/layout_tests/port/win.py:
1977         (WinPort.__init__):
1978             - Re-order some code in these constructors so that
1979               self._operating_system is available to the ApplePort constructor.
1980
1981 2011-12-06  Tommy Widenflycht  <tommyw@google.com>
1982
1983         Added myself as a committer.
1984
1985         * Scripts/webkitpy/common/config/committers.py:
1986
1987 2011-12-06  Peter Beverloo  <peter@chromium.org>
1988
1989         Added myself as a committer.
1990
1991         * Scripts/webkitpy/common/config/committers.py:
1992
1993 2011-12-06  Kentaro Hara  <haraken@chromium.org>
1994
1995         [Refactoring] In webkitpy/bindings/main.py, replace subprocess.Popen() with Executive
1996         https://bugs.webkit.org/show_bug.cgi?id=73637
1997
1998         Reviewed by Adam Barth.
1999
2000         This patch replaces subprocess.Popen() with Executive, similar to other
2001         Python scripts in webkitpy/. I manually confirmed that run-bindings-tests
2002         works well for cases where no exception is raised, no exception is raised
2003         but diff is found, and ScriptError is raised.
2004
2005         * Scripts/run-bindings-tests:
2006         (main):
2007         * Scripts/webkitpy/bindings/main.py: Replaces subprocess.Popen() with Executive.
2008         (BindingsTests.__init__):
2009         (BindingsTests.generate_from_idl):
2010         (BindingsTests.generate_supplemental_dependency):
2011         (BindingsTests.detect_changes):
2012
2013 2011-12-05  Alexander Færøy  <alexander.faeroy@nokia.com>
2014
2015         [Qt] MiniBrowser should default to touch behavior
2016         https://bugs.webkit.org/show_bug.cgi?id=73863
2017
2018         Reviewed by Chang Shu.
2019
2020         MiniBrowser currently defaults to the traditional desktop behaviour
2021         instead of touch behaviour which is prefered.
2022
2023         * MiniBrowser/qt/BrowserWindow.cpp:
2024         (BrowserWindow::BrowserWindow):
2025         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2026         (printHelp):
2027         (MiniBrowserApplication::handleUserOptions):
2028         * MiniBrowser/qt/MiniBrowserApplication.h:
2029         (WindowOptions::WindowOptions):
2030         (WindowOptions::setUseTraditionalDesktopBehavior):
2031         (WindowOptions::useTraditionalDesktopBehavior):
2032
2033 2011-12-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
2034
2035         webkit.py: Really fix the printing of StringImpl now that 8-bit strings are present.
2036         https://bugs.webkit.org/show_bug.cgi?id=73878
2037
2038         Reviewed by Tony Chang.
2039
2040         r98624 turned StringImpl::m_data into StringImpl::{m_data8,m_data16}.
2041         r98785 made webkit.py always use m_data16, which does not work when
2042         the string is an 8-bit string (such as KURL::string()).
2043
2044         I was not able to directly call StringImpl::is8Bit() in the Python
2045         code, so I just reproduced the implementation there.
2046
2047         * gdb/webkit.py:
2048         (WTFStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
2049         (WTFStringPrinter.to_string):
2050         (JSCUStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
2051         (JSCUStringPrinter.to_string):
2052
2053 2011-12-05  Eric Seidel  <eric@webkit.org>
2054
2055         Up the "expected ram for each DRT instance" to 400MB instead of 300MB
2056         in hopes of making the Snow Leopard bot stop timing out.
2057
2058         Unreviewed.
2059
2060         * Scripts/webkitpy/layout_tests/port/base.py:
2061         (Port.default_child_processes):
2062         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2063         (PortTest.test_default_child_processes):
2064
2065 2011-12-05  Eric Seidel  <eric@webkit.org>
2066
2067         NRWT creates too many workers on RAM-limited machines
2068         https://bugs.webkit.org/show_bug.cgi?id=73847
2069
2070         Reviewed by Dirk Pranke.
2071
2072         Make NRWT restrict its number of workers when there isn't enough
2073         RAM to support them.
2074         Also re-enable parallel testing on the Mac bots which were
2075         failing due to not enough ram.
2076
2077         * Scripts/run-webkit-tests:
2078         (platformIsReadyForParallelTesting):
2079         * Scripts/webkitpy/common/host.py:
2080         (Host.__init__):
2081         * Scripts/webkitpy/common/system/executive_mock.py:
2082         (MockExecutive.cpu_count):
2083         * Scripts/webkitpy/common/system/platforminfo.py:
2084         (PlatformInfo.__init__):
2085         (PlatformInfo.display_name):
2086         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2087         (MockPlatformInfo.display_name):
2088         * Scripts/webkitpy/layout_tests/port/base.py:
2089         (Port.default_child_processes):
2090         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2091         (PortTest.test_default_child_processes):
2092         (PortTest.test_pretty_patch_os_error):
2093
2094 2011-12-05  Hugo Parente Lima  <hugo.lima@openbossa.org>
2095
2096         Last mouse event could be lost if a JS call to eventSender.leapForward is made
2097         https://bugs.webkit.org/show_bug.cgi?id=73366
2098
2099         Reviewed by Kenneth Rohde Christiansen.
2100
2101         Empty the entire event queue when requested besides using
2102         sendEvent instead of postEvent to make sure all events were
2103         delivered.
2104
2105         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
2106         (WTR::EventSenderProxy::EventSenderProxy):
2107         (WTR::EventSenderProxy::sendOrQueueEvent):
2108         (WTR::EventSenderProxy::replaySavedEvents):
2109
2110 2011-12-05  Adam Barth  <abarth@webkit.org>
2111
2112         [Chromium] Remove no-longer-used forwarding headers in the WebKit API
2113         https://bugs.webkit.org/show_bug.cgi?id=73845
2114
2115         Reviewed by Darin Fisher.
2116
2117         Update includes to point to the new header locations.
2118
2119         * DumpRenderTree/chromium/AccessibilityController.cpp:
2120         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2121         * DumpRenderTree/chromium/CppBoundClass.cpp:
2122         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2123         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2124         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2125         * DumpRenderTree/chromium/EventSender.cpp:
2126         * DumpRenderTree/chromium/EventSender.h:
2127         * DumpRenderTree/chromium/GamepadController.h:
2128         * DumpRenderTree/chromium/LayoutTestController.cpp:
2129         * DumpRenderTree/chromium/LayoutTestController.h:
2130         * DumpRenderTree/chromium/MockSpellCheck.cpp:
2131         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2132         * DumpRenderTree/chromium/PlainTextController.cpp:
2133         * DumpRenderTree/chromium/Task.cpp:
2134         * DumpRenderTree/chromium/TestNavigationController.h:
2135         * DumpRenderTree/chromium/TestShell.cpp:
2136         * DumpRenderTree/chromium/TestWebPlugin.cpp:
2137         * DumpRenderTree/chromium/TestWebPlugin.h:
2138         * DumpRenderTree/chromium/TextInputController.cpp:
2139         * DumpRenderTree/chromium/WebPermissions.cpp:
2140         * DumpRenderTree/chromium/WebPreferences.h:
2141         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2142         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2143         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
2144         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
2145         * DumpRenderTree/chromium/WebViewHost.cpp:
2146
2147 2011-12-05  Ryosuke Niwa  <rniwa@webkit.org>
2148
2149         Add Aharon Lanin to the contributors list.
2150
2151         * Scripts/webkitpy/common/config/committers.py:
2152
2153 2011-12-05  Jarred Nicholls  <jarred@sencha.com>
2154
2155         Moving myself from contributors to committers.
2156
2157         * Scripts/webkitpy/common/config/committers.py:
2158
2159 2011-12-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
2160
2161         Add myself as a committer.
2162
2163         * Scripts/webkitpy/common/config/committers.py:
2164
2165 2011-12-05  Michael Brüning  <michael.bruning@nokia.com>
2166
2167         [Qt] Rename QQuickWebView::canStop property to just loading 
2168         https://bugs.webkit.org/show_bug.cgi?id=73813
2169
2170         Reviewed by Kenneth Rohde Christiansen.
2171
2172         Replaced references to WebView.canStop with WebView.loading.
2173
2174         * MiniBrowser/qt/qml/BrowserWindow.qml:
2175
2176 2011-12-05  Dirk Pranke  <dpranke@chromium.org>
2177
2178         run-webkit-tests: limit --child-processes properly on apple mac
2179         https://bugs.webkit.org/show_bug.cgi?id=73856
2180
2181         Reviewed by Adam Roben.
2182
2183         Fix typos in r102013 so that we correctly pass --child-processes=1 on
2184         the apple mac bots temporarily.
2185
2186         * Scripts/run-webkit-tests:
2187         (platformIsReadyForParallelTesting):
2188
2189 2011-12-05  Ryosuke Niwa  <rniwa@webkit.org>
2190
2191         Temporarily set --child-process=1 on Mac because 20+ tests are timing out
2192         https://bugs.webkit.org/show_bug.cgi?id=73840
2193
2194         Reviewed by Simon Fraser.
2195
2196         Temporarily go back to single process mode on Mac.
2197
2198         * Scripts/run-webkit-tests:
2199         (platformIsReadyForParallelTesting):
2200
2201 2011-12-05  Adam Roben  <aroben@apple.com>
2202
2203         Redeploy apple-macpro-7 and apple-xserve-1
2204
2205         These slaves have been sitting idle since we removed our Leopard builders in r97496.
2206
2207         Fixes <http://webkit.org/b/73829> REGRESSION (r97496): apple-macpro-7 and apple-xserve-1 are
2208         sitting idle
2209
2210         Reviewed by Sam Weinig.
2211
2212         * BuildSlaveSupport/build.webkit.org-config/config.json: Re-added apple-macpro-7 and
2213         apple-xserve-1. The former is now doing "SnowLeopard Intel Debug (WebKit2 Tests)", which
2214         allows apple-xserve-9 to be a build-only slave, and the latter is doing "Lion Intel Debug
2215         (WebKit2 Tests)".
2216
2217 2011-12-05  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2218
2219         [Qt] Make the UI of the MiniBrowser slightly nicer
2220
2221         Rubberstamped by Simon Hausmann.
2222
2223         - Add proper padding
2224         - Show feedback when pressing on the toolbar icons
2225         - Make the text entry better looking
2226
2227         * MiniBrowser/qt/qml/BrowserWindow.qml:
2228
2229 2011-12-05  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2230
2231         NRWT should handle duplicated expectations
2232         https://bugs.webkit.org/show_bug.cgi?id=69750
2233
2234         Reviewed by Dirk Pranke.
2235
2236         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2237         (TestExpectations.__init__):
2238         (TestExpectations._report_errors):
2239         (TestExpectations._add_expectations):
2240         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2241         (test_add_skipped_tests):
2242         * Scripts/webkitpy/layout_tests/port/base.py:
2243         (Port.skipped_tests):
2244         * Scripts/webkitpy/layout_tests/port/webkit.py:
2245         (WebKitPort.test_expectations):
2246         (WebKitPort.skipped_tests):
2247         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2248         (test_test_expectations):
2249
2250 2011-12-04  Eric Seidel  <eric@webkit.org>
2251
2252         After success with Mac, Win and Gtk, turning on parallel testing
2253         by default for all platforms (except Qt).
2254
2255         We'll add more platforms to the blacklist if we see problems.
2256
2257         Unreviewed.
2258
2259         * Scripts/run-webkit-tests:
2260         (platformIsReadyForParallelTesting):
2261
2262 2011-12-04  Sam Weinig  <sam@webkit.org>
2263
2264         Add tests for RetainPtr::adoptNS/adoptCF
2265         https://bugs.webkit.org/show_bug.cgi?id=73470
2266
2267         Reviewed by Adam Roben and Darin Adler.
2268
2269         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2270         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp: Added.
2271         (TestWebKitAPI::TEST):
2272         Test that adopting using adoptCF creates a RetainPtr with a
2273         value whose retain count is 1.
2274
2275         * TestWebKitAPI/Tests/WTF/ns: Added.
2276         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm: Added.
2277         (TestWebKitAPI::TEST):
2278         Test that adopting using adoptNS creates a RetainPtr with a
2279         value whose retain count is 1.
2280
2281 2011-12-04  Martin Robinson  <mrobinson@igalia.com>
2282
2283         [GTK] Include cairo, pixman and gnome-icon-theme in the jhbuild modules
2284         https://bugs.webkit.org/show_bug.cgi?id=73748
2285
2286         Reviewed by Gustavo Noronha Silva.
2287
2288         * gtk/jhbuild.modules: Add some new modules the jhbuild moduleset.
2289
2290 2011-12-04  Philippe Normand  <pnormand@igalia.com>
2291
2292         Another GTK build fix after r101922.
2293
2294         Rubber-stamped by Martin Robinson.
2295
2296         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2297         (LayoutTestController::pathToLocalResource): Plug possible String ref leak.
2298
2299 2011-12-04  Xan Lopez  <xlopez@igalia.com>
2300
2301         Fix compiler warning in LayoutTestController
2302
2303         Reviewed by Philippe Normand.
2304
2305         * DumpRenderTree/LayoutTestController.cpp:
2306         (LayoutTestController::LayoutTestController): fix warning.
2307
2308 2011-12-04  Alexandre Mazari  <scaroo@gmail.com>
2309
2310         Add missing methods used by fast/notifications tests to LayoutTestController
2311         https://bugs.webkit.org/show_bug.cgi?id=63616
2312
2313         Reviewed by Martin Robinson.
2314
2315         Add missing simulateDesktopNotificationClick method used by
2316         fast/notifications. Provide a default implementation for
2317         areDesktopNotificationPermissionRequestsIgnored and
2318         ignoreDesktopNotificationPermissionRequests.
2319
2320         * DumpRenderTree/LayoutTestController.cpp:
2321         (LayoutTestController::LayoutTestController): call into the port implementation.
2322         (simulateDesktopNotificationClickCallback): ditto.
2323         (ignoreDesktopNotificationPermissionRequestsCallback): default implementation.
2324         (LayoutTestController::staticFunctions): declare new methods.
2325         (LayoutTestController::ignoreDesktopNotificationPermissionRequests): default implementation.
2326         * DumpRenderTree/LayoutTestController.h:
2327         (LayoutTestController::areDesktopNotificationPermissionRequestsIgnored):
2328         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2329         (LayoutTestController::simulateDesktopNotificationClick): dummy implementation.
2330         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2331         (LayoutTestController::simulateDesktopNotificationClick): ditto.
2332         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2333         (LayoutTestController::simulateDesktopNotificationClick): ditto.
2334         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2335         (LayoutTestController::simulateDesktopNotificationClick): ditto.
2336         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2337         (LayoutTestController::simulateDesktopNotificationClick): ditto.
2338
2339 2011-12-03  Mario Sanchez Prada  <msanchez@igalia.com>
2340
2341         [GTK] Don't log document events in DRT
2342         https://bugs.webkit.org/show_bug.cgi?id=73746
2343
2344         Reviewed by Martin Robinson.
2345
2346         Stop connecting globally to document-related events.
2347
2348         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
2349         (connectAccessibilityCallbacks): Removed connections.
2350         (disconnectAccessibilityCallbacks): Removed disconnections.
2351
2352 2011-12-03  Dan Bernstein  <mitz@apple.com>
2353
2354         Added a test for <rdar://problem/10523721> Crash at WebCore::SubresourceLoader::releaseResources
2355
2356         Reviewed by Darin Adler.
2357
2358         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2359         * TestWebKitAPI/Tests/mac/SubresourceErrorCrash.mm: Added.
2360         (TestWebKitAPI::TEST):
2361
2362 2011-12-03  Philippe Normand  <pnormand@igalia.com>
2363
2364         Another GTK build fix after r101922.
2365
2366         Rubber-stamped by Martin James Robinson.
2367
2368         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2369         (LayoutTestController::pathToLocalResource): return value needs to
2370         be a URI.
2371
2372 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
2373
2374         Small fix for my previous patch. Do not try to delete a member
2375         of a dictionary that does not exist.
2376
2377         Reviewed by Gustavo Noronha Silva.
2378
2379         * gtk/run-with-jhbuild:
2380         (install_and_run_jhbuild):
2381
2382 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
2383
2384         Fix jhbuild installation for people who have unusual MAKE environment
2385         variables such as 'make -j4' as the jhbuild build does not handle it.
2386
2387         Reviewed by Gustavo Noronha Silva.
2388
2389         * gtk/run-with-jhbuild:
2390         (install_and_run_jhbuild): Remove any MAKE environment variable before building jhbuild.
2391
2392 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
2393
2394         Fix the update-webkitgtk-libs script to properly trigger a jhbuild installation
2395         when run for the first time.
2396
2397         Reviewed by Gustavo Noronha Silva.
2398
2399         * Scripts/update-webkitgtk-libs: Fix first run.
2400
2401 2011-12-03  Philippe Normand  <pnormand@igalia.com>
2402
2403         Unreviewed, GTK build fix after r101922.
2404
2405         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2406         (LayoutTestController::pathToLocalResource): Added sentinel in
2407         g_build_filename call.
2408
2409 2011-12-03  Philippe Normand  <pnormand@igalia.com>
2410
2411         GTK API tests build fix. Run the tests inside jhbuild.
2412
2413         Rubber-stamped by Gustavo Noronha Silva.
2414
2415         * Scripts/run-gtk-tests:
2416         (TestRunner.__init__):
2417         (TestRunner.run._error_handler):
2418         (TestRunner):
2419         (TestRunner.run):
2420
2421 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
2422
2423         Small build fix. Properly specify the path to the locally installed jhbuild.
2424
2425         * Scripts/update-webkitgtk-libs: Fix jhbuild path.
2426
2427 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
2428
2429         [GTK][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
2430         https://bugs.webkit.org/show_bug.cgi?id=67256
2431
2432         Reviewed by Philippe Normand.
2433
2434         Implement LayoutTestController::pathToLocalResource for GTK+. Instead of passing 
2435         WEBKIT_TEST_FONTS to the GTK+ test harnesses, pass a more generic WEBKIT_TOP_LEVEL,
2436         which points to the more generic top-level path of the WebKit checkout. This code is
2437         duplicated between WK1 and WK2 harnesses because we do not currently have a way to
2438         share code here.
2439
2440         If WEBKIT_TOP_LEVEL is not provided, we search for the top level based on the binary
2441         location. This will cause the fallback to fail if you build into a non-typical location
2442         or even fake it with a symlink. In this case it's important to use the environment variable.
2443
2444         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2445         (getTopLevelPath): Added.
2446         (initializeFonts): Use the new helper to get the font path.
2447         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Expose the new helper.
2448         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2449         (LayoutTestController::pathToLocalResource):Use the new helper to normalize
2450         test paths.
2451         * Scripts/webkitpy/layout_tests/port/gtk.py:
2452         (GtkPort.setup_environ_for_server):Pass the top-level path of the
2453         checkout instead of passing the font path.
2454         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2455         (WTR::getTopLevelPath): Added this helper.
2456         (WTR::inititializeFontConfigSetting): Use the helper to find the font path.
2457
2458 2011-12-02  David Levin  <levin@chromium.org>
2459
2460         Rename WTF class from TemporarilyChange to TemporaryChange.
2461         https://bugs.webkit.org/show_bug.cgi?id=73479
2462
2463         Reviewed by Eric Seidel.
2464
2465         * DumpRenderTree/ForwardingHeaders/wtf/TemporarilyChange.h: Removed.
2466         * DumpRenderTree/ForwardingHeaders/wtf/TemporaryChange.h: Added.
2467         * TestWebKitAPI/TestWebKitAPI.gypi:
2468         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2469         * TestWebKitAPI/Tests/WTF/TemporaryChange.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/TemporarilyChange.cpp.
2470         (TestWebKitAPI::TEST):
2471         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2472
2473 2011-12-02  Tony Chang  <tony@chromium.org>
2474
2475         [NRWT] reftest asserts intermittently on the Qt-WK2 bot
2476         https://bugs.webkit.org/show_bug.cgi?id=73453
2477
2478         Reviewed by Ryosuke Niwa.
2479
2480         We used to assert if a ref test didn't generate pixel results. Instead, just claim it is a failing test.
2481         The verbose output will include the failure reason.
2482
2483         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Don't assert, return FailureReftestNoImagesGenerated instead.
2484         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2485         (write_test_result):
2486         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py: Remove stray letter t.
2487         * Scripts/webkitpy/layout_tests/models/test_failures.py: Add a new failure type: FailureReftestNoImagesGenerated
2488         (determine_result_type):
2489         (FailureReftestNoImagesGenerated.__init__):
2490         (FailureReftestNoImagesGenerated):
2491         (FailureReftestNoImagesGenerated.message):
2492         * Scripts/webkitpy/layout_tests/port/test.py: Add a test case for integration tests.
2493         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Update test counts.
2494         (MainTest.test_run_singly_actually_runs_tests):
2495         (MainTest.test_unexpected_failures):
2496         (EndToEndTest.test_end_to_end):
2497
2498 2011-12-02  Ryosuke Niwa  <rniwa@webkit.org>
2499
2500         ChangeLog should be able to parse annotated changelogs
2501         https://bugs.webkit.org/show_bug.cgi?id=72703
2502
2503         Reviewed by Eric Seidel.
2504
2505         Make parse_entries_from_file aware of svn blame annotation such as "100000 ossy@webkit.org ",
2506         and extract the revision number for each entry.
2507
2508         Also add a support to extract "svn blame" result from svn/git checkout to scm classes.
2509
2510         * Scripts/webkitpy/common/checkout/changelog.py:
2511         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2512         * Scripts/webkitpy/common/checkout/scm/git.py:
2513         * Scripts/webkitpy/common/checkout/scm/scm.py:
2514         * Scripts/webkitpy/common/checkout/scm/svn.py:
2515
2516 2011-12-02  Eric Seidel  <eric@webkit.org>
2517
2518         Enable parallel testing for Win and Gtk bots
2519         after confirming with Lucas and Martin the bots should be OK.
2520
2521         Unreviewed. (I ran the idea by Lucas and Martin.)
2522
2523         * Scripts/run-webkit-tests:
2524         (platformIsReadyForParallelTesting):
2525
2526 2011-12-02  Martin Robinson  <mrobinson@igalia.com>
2527
2528         Try to fix the GTK+ build.
2529
2530         * gtk/jhbuild.modules: Properly specify the glib-networking
2531         dependency for soup.
2532
2533 2011-12-02  Martin Robinson  <mrobinson@igalia.com>
2534
2535         Fix a syntax error in the committers.py file.
2536
2537         * Scripts/webkitpy/common/config/committers.py: Add a missing comma.
2538
2539 2011-12-02  Ryosuke Niwa  <rniwa@webkit.org>
2540
2541         Add Alan Stearns and Peter Linss to the contributors list.
2542
2543         * Scripts/webkitpy/common/config/committers.py:
2544
2545 2011-12-02  Kent Tamura  <tkent@chromium.org>
2546
2547         [Chromium] Fix compilation warnings for ASSERT()
2548         https://bugs.webkit.org/show_bug.cgi?id=73623
2549
2550         Reviewed by Tony Chang.
2551
2552         * DumpRenderTree/chromium/ImageDiff.cpp:
2553          - Fix fprintf format: %s -> %d for __LINE__
2554          - Do nothing for ASSERT() if NDEBUG.
2555
2556 2011-12-02  Eric Seidel  <eric@webkit.org>
2557
2558         Enable parallel testing for all Mac bots.
2559
2560         Unreviewed.
2561
2562         * Scripts/run-webkit-tests:
2563         (platformIsReadyForParallelTesting):
2564
2565 2011-12-02  Eric Seidel  <eric@webkit.org>
2566
2567         Enable parallel testing for run-webkit-tests on Mac Lion.
2568         I plan to move all the machines to parallel testing shortly
2569         but we're starting with Lion.
2570
2571         Unreviewed.
2572
2573         * Scripts/run-webkit-tests:
2574         (platformIsReadyForParallelTesting):
2575
2576 2011-12-02  Kausalya Madhusudhanan  <kmadhusu@chromium.org>
2577
2578         Added helper method to identify whether the page has custom page size style.
2579         https://bugs.webkit.org/show_bug.cgi?id=73585
2580
2581         Reviewed by Darin Fisher.
2582
2583         * DumpRenderTree/chromium/LayoutTestController.cpp:
2584         (LayoutTestController::LayoutTestController):
2585         (LayoutTestController::hasCustomPageSizeStyle):
2586         * DumpRenderTree/chromium/LayoutTestController.h:
2587
2588 2011-12-01  Ryosuke Niwa  <rniwa@webkit.org>
2589
2590         [NRWT] reftest should support having multiple references per test
2591         https://bugs.webkit.org/show_bug.cgi?id=73613
2592
2593         Reviewed by Dirk Pranke.
2594
2595         Add a support for having multiple reference files for a single test.
2596
2597         Because a reftest succeeds when it matches at least one of expected matches and fails when it matches
2598         at least one of expected mismatches, we compare expected mismatches first in order to minimize
2599         the number of reference files to open on DRT.
2600
2601         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2602         (interpret_test_failures): Remove checks no longer applicable.
2603         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2604         (ResultSummaryTest.test_interpret_test_failures): Ditto.
2605         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2606         (SingleTestRunner.__init__): Remove a bunch of code and just call port.reference_files.
2607         (SingleTestRunner._driver_input):
2608         (SingleTestRunner.run):
2609         (SingleTestRunner._run_reftest): Compare the output of the test to each reference file.
2610         * Scripts/webkitpy/layout_tests/models/test_input.py:
2611         (TestInput.__init__): Remove ref_file and is_mismatch_reftest because they are no longer used.
2612         * Scripts/webkitpy/layout_tests/port/base.py:
2613         (Port.reference_files): Renamed from _reference_file_for. Returns a list of expectation, filename pairs.
2614         (_parse_reftest_list): Now supports parsing multiple entries for a single test.
2615         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2616         (PortTest.test_parse_reftest_list):
2617         * Scripts/webkitpy/layout_tests/port/test.py:
2618         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2619         (MainTest.test_unexpected_failures):
2620         (MainTest.test_reftest_skipped_if_unlisted): Renamed from test_missing_and_unexpected_results.
2621         (EndToEndTest.test_end_to_end):
2622         (EndToEndTest.test_reftest_with_two_notrefs): Added.
2623
2624 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
2625
2626         Build libsoup without gnome dependencies (like keyring).
2627
2628         * gtk/jhbuild.modules:
2629
2630 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
2631
2632         Also build gcrypt and p11-kit, and make them dependencies of
2633         gnutls.
2634
2635         * gtk/jhbuild.modules:
2636
2637 2011-12-02  Kevin Ollivier  <kevino@theolliviers.com>
2638
2639         [wx] Unreviewed build fixes for Windows build.
2640
2641         * waf/build/wxpresets.py:
2642
2643 2011-12-01  Eric Seidel  <eric@webkit.org>
2644
2645         Reviewed by Adam Barth.
2646
2647         webkit-patch post, post-commits, upload should warn when posting to a closed bug, and offer to reopen it
2648         https://bugs.webkit.org/show_bug.cgi?id=32006
2649
2650         I decided not to make it warn, and just have it re-open the bug.
2651         That's not that different from today's behavior which will
2652         just silently attach the patch.
2653
2654         This patch makes behavior between upload and land-safely consistent
2655         (previously one would assign patches and the other would not)
2656         as well as adds the ability for both to ensure that the bug is open.
2657
2658         To test this I had to add a few more methods to MockBugzilla which
2659         (positively) affected a few other test results.
2660
2661         I also made AbstractStep keep a cached copy of the Bug object
2662         and used the cached copy where appropriate (including for 'bug_title').
2663         This should reduce the number of bug fetches we perform.
2664
2665         * Scripts/webkitpy/tool/commands/download_unittest.py:
2666         * Scripts/webkitpy/tool/commands/upload.py:
2667         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2668         * Scripts/webkitpy/tool/mocktool.py:
2669         * Scripts/webkitpy/tool/steps/__init__.py:
2670         * Scripts/webkitpy/tool/steps/abstractstep.py:
2671         * Scripts/webkitpy/tool/steps/closebug.py:
2672         * Scripts/webkitpy/tool/steps/ensurebugisopenandassigned.py: Added.
2673         * Scripts/webkitpy/tool/steps/postdiff.py:
2674         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
2675         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2676         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2677         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
2678
2679 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
2680
2681         Also pass --no-interact to jhbuild when updating dependencies.
2682
2683         * Scripts/update-webkitgtk-libs:
2684
2685 2011-12-02  Alice Boxhall  <aboxhall@chromium.org>
2686
2687         Make _build_path check more thoroughly that build paths exist.
2688         https://bugs.webkit.org/show_bug.cgi?id=73601
2689
2690         Reviewed by Ojan Vafai.
2691
2692         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2693         (ChromiumMacPort._build_path):
2694
2695 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
2696
2697         Add libffi to the jhbuild modules list as a glib dependency.
2698
2699         Rubber-stamped by Martin Robinson.
2700
2701         * gtk/jhbuild.modules:
2702
2703 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
2704
2705         Build fix. Use internal pcre on glib, make gnutls a dependency of
2706         glib-networking, unset AR_FLAGS for jhbuild builds, and run jhbuild
2707         in non-interactive mode.
2708
2709         * Scripts/update-webkitgtk-libs:
2710         * gtk/jhbuild.modules:
2711         * gtk/run-with-jhbuild:
2712
2713 2011-12-02  Adam Roben  <aroben@apple.com>
2714
2715         Fix for Python 2.6
2716
2717         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2718         (RunUnitTests.countFailures): Removed the flags parameter to re.split, which was only added
2719         in Python 2.7, and used whitespace instead of start-of-string/end-of-string markers when
2720         searching for "Tests that timed out:" etc. This makes our check less strict, but it
2721         shouldn't matter given the kinds of content we parse.
2722
2723 2011-12-02  Adam Roben  <aroben@apple.com>
2724
2725         Fix names of failed/timed out tests in run-api-tests output
2726
2727         Fixes <http://webkit.org/b/73663> run-api-tests prints suite names twice for failed or timed
2728         out tests
2729
2730         We were ending up with the suite name doubled (e.g., "WebKit2.WebKit2.MouseMoveAfterCrash").
2731
2732         Reviewed by Simon Fraser.
2733
2734         * Scripts/run-api-tests:
2735         (runTest): Don't prepend the suite name to $test. It's already been prepended at the start
2736         of this function.
2737
2738 2011-11-29  Martin Robinson  <mrobinson@igalia.com>
2739
2740         [GTK] generate-gtkdoc should respect build type
2741         https://bugs.webkit.org/show_bug.cgi?id=73296
2742
2743         Reviewed by Philippe Normand.
2744
2745         * Scripts/webkitdirs.pm:
2746         (buildAutotoolsProject): Pass the --debug to the generate-gtkdoc script.
2747         * gtk/common.py: If --build is passed give preference to the Debug build directory.
2748
2749 2011-12-02  Tony Chang  <tony@chromium.org>
2750
2751         [nrwt] fix wdiff output
2752         https://bugs.webkit.org/show_bug.cgi?id=73604
2753
2754         Reviewed by Adam Barth.
2755
2756         * Scripts/webkitpy/layout_tests/port/base.py:
2757         (Port.wdiff_text):
2758         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2759         (PortTest.test_wdiff_text):
2760
2761 2011-12-02  Adam Roben  <aroben@apple.com>
2762
2763         Teach build.webkit.org to display how many unit tests failed or timed out
2764
2765         Fixes <http://webkit.org/b/73659> It's hard to tell how many unit tests are failing on
2766         build.webkit.org
2767
2768         We now display something like "5 unit tests failed or timed out". Eventually we might want
2769         to split out how many failure vs. timeouts there were.
2770
2771         Reviewed by Darin Adler.
2772
2773         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2774         (TestWithFailureCount): Moved this class up to the top of the file so it is before any other
2775         classes that may want to subclass it.
2776         (RunUnitTests): Changed to inherit from TestWithFailureCount.
2777         (RunUnitTests.countFailures): Added. Counts the number of tests following the "Tests that
2778         timed out:" and "Tests that failed:" lines, if present.
2779
2780         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2781         (StubStdio):
2782         (StubRemoteCommand):
2783         Added these two stub classes to mimic buildbot's RemoteCommand and log classes.
2784
2785         (RunUnitTestsTest.assertFailures): Helper method to check that we interpreted the results of
2786         the test run correctly.
2787
2788         (RunUnitTestsTest.test_no_failures_or_timeouts):
2789         (RunUnitTestsTest.test_one_failure):
2790         (RunUnitTestsTest.test_multiple_failures):
2791         (RunUnitTestsTest.test_one_timeout):
2792         (RunUnitTestsTest.test_multiple_timeouts):
2793         (RunUnitTestsTest.test_multiple_failures_and_timeouts):
2794         Test various cases.
2795
2796 2011-12-02  Adam Roben  <aroben@apple.com>
2797
2798         Teach prepare-ChangeLog to treat master.cfg as a Python file
2799
2800         Fixes <http://webkit.org/b/73658> prepare-ChangeLog doesn't show modified classes/functions
2801         in buildbot's master.cfg
2802
2803         Reviewed by Darin Adler.
2804
2805         * Scripts/prepare-ChangeLog:
2806         (get_function_line_ranges): Use get_function_line_ranges_for_python if the filename is
2807         master.cfg.
2808
2809 2011-12-02  Martin Robinson  <mrobinson@igalia.com>
2810
2811         [GTK] Create a wrapper script that knows how to install jhbuild and run commands with it
2812         https://bugs.webkit.org/show_bug.cgi?id=73669
2813
2814         Reviewed by Gustavo Noronha Silva.
2815
2816         Add a wrapper script that knows how to install jhbuild and also to wrap commands
2817         in the jhbuild shell.
2818
2819         * Scripts/webkitdirs.pm:
2820         (runAutogenForAutotoolsProject): Use the new wrapper script.
2821         (mustReRunAutogen): Ditto.
2822         (buildAutotoolsProject): Ditto.
2823         * Scripts/webkitpy/layout_tests/port/gtk.py:
2824         (GtkDriver.cmd_line): Ditto.
2825         * gtk/run-with-jhbuild: Added.
2826
2827 2011-12-01  Adam Roben  <aroben@apple.com>
2828
2829         Teach check-webkit-style how to check the syntax of JSON files
2830
2831         Fixes <http://webkit.org/b/73590> check-webkit-style doesn't flag JSON syntax errors
2832
2833         I previously landed this patch as r101711, but the new tests failed on Snow Leopard. This
2834         patch is identical to that one except for two change: assertIn(a, b) (which is new to Python
2835         2.7) has been replaced with assertTrue(a in b), and the test_missing_closing_brace test has
2836         been removed, since its output differs by platform.
2837
2838         Reviewed by Darin Adler.
2839
2840         * Scripts/webkitpy/style/checker.py:
2841         (_all_categories): Added JSONChecker's categories to the set of all categories.
2842         (FileType): Added a JSON type. Incremented other types.
2843         (CheckerDispatcher._file_type): Use the JSON file type for .json files.
2844         (CheckerDispatcher._create_checker): Use a JSONChecker for JSON files.
2845
2846         * Scripts/webkitpy/style/checker_unittest.py:
2847         (CheckerDispatcherDispatchTest.assert_checker_json): Added this helper method.
2848         (CheckerDispatcherDispatchTest.test_json_paths): Added. Based on test_python_paths.
2849
2850         * Scripts/webkitpy/style/checkers/jsonchecker.py: Added. (I didn't name this just "json",
2851         which would have matched our other checkers, because I couldn't figure out how to call
2852         "json.loads" without hitting namespace conflicts.)
2853         (JSONChecker.__init__): Turn of line filtering so that we always check the whole file, not
2854         just the modified lines from a patch.
2855         (JSONChecker.check): Try to parse the lines as JSON. Mark an error if there was an
2856         exception.
2857         (JSONChecker.line_number_from_json_exception): Parse the json modules exception message to
2858         try to extract a line number.
2859
2860         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Added.
2861         (MockErrorHandler.__init__):
2862         (MockErrorHandler.turn_off_line_filtering):
2863         (MockErrorHandler.__call__):
2864         Helper class. Copied from xml_unittest.py.
2865
2866         (JSONCheckerTest.test_line_number_from_json_exception): Test the
2867         line_number_from_json_exception helper method.
2868
2869         (JSONCheckerTest.assert_no_error):
2870         (JSONCheckerTest.assert_error):
2871         Helper methods to assert that we did or didn't get an error.
2872
2873         (JSONCheckerTest.mock_handle_style_error): Helper method.
2874
2875         (JSONCheckerTest.test_conflict_marker):
2876         (JSONCheckerTest.test_single_quote):
2877         (JSONCheckerTest.test_init):
2878         (JSONCheckerTest.test_no_error):
2879         Test various cases.
2880
2881 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
2882
2883         [GTK] Add glib, glib-networking, gnutls and libsoup to jhbuild
2884         https://bugs.webkit.org/show_bug.cgi?id=73664
2885
2886         Reviewed by Martin Robinson.
2887
2888         This patch adds our HTTP library and its main dependencies; this
2889         should not affect layout or rendering.
2890
2891         * gtk/jhbuild.modules:
2892
2893 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
2894
2895         [GTK] Also run DumpRenderTree under jhbuild
2896         https://bugs.webkit.org/show_bug.cgi?id=73646
2897
2898         Reviewed by Martin Robinson.
2899
2900         * Scripts/webkitpy/layout_tests/port/gtk.py:
2901         (GtkDriver.cmd_line):
2902
2903 2011-12-02  Hajime Morrita  <morrita@chromium.org>
2904
2905         Unreviewed, rolling out r101751 and r101775.
2906         http://trac.webkit.org/changeset/101751
2907         http://trac.webkit.org/changeset/101775
2908         https://bugs.webkit.org/show_bug.cgi?id=73191
2909
2910         breaks Windows build
2911
2912         * DumpRenderTree/chromium/config.h:
2913         * DumpRenderTree/config.h:
2914         * TestWebKitAPI/config.h:
2915         * WebKitTestRunner/config.h:
2916
2917 2011-12-02  Kentaro Hara  <haraken@chromium.org>
2918
2919         Move run-bindings-tests implementation to webkitpy/bindings/main.py
2920         https://bugs.webkit.org/show_bug.cgi?id=73619
2921
2922         Reviewed by Adam Barth.
2923
2924         As run-bindings-tests has been growing, this patch just moves its implementation
2925         to webkitpy/bindings/main.py to integrate with the rest of webkitpy.
2926
2927         No change in behavior.
2928
2929         * Scripts/run-bindings-tests:
2930         (main):
2931         * Scripts/webkitpy/bindings/__init__.py: Added.
2932         * Scripts/webkitpy/bindings/main.py: Added.
2933         (BindingsTests.__init__):
2934         (BindingsTests.generate_from_idl):
2935         (BindingsTests.generate_supplemental_dependency):
2936         (BindingsTests.detect_changes):
2937         (BindingsTests.run_tests):
2938
2939 2011-12-01  Ilya Tikhonovsky  <loislo@chromium.org>
2940
2941         Tools/Scripts: eliminate find_test_files from Port class.
2942         https://bugs.webkit.org/show_bug.cgi?id=73553
2943
2944         rebaseline.py and chromium_gpu.py use Port.find_test_files() the same way as it is used in Port.tests()
2945         I'd like to replace all calls to find_test_files with tests and eliminate find_tests_files.
2946         Also I'll move _is_test_file() and related functions close to Port.tests().
2947
2948         Reviewed by Dirk Pranke.
2949
2950         * Scripts/webkitpy/layout_tests/port/base.py:
2951         (Port.tests):
2952         (Port.is_reference_html_file):
2953         (Port._has_supported_extension):
2954         (Port._is_test_file):
2955         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2956         (PortTest.test_find_no_paths_specified):
2957         (PortTest.test_find_one_test):
2958         (PortTest.test_find_glob):
2959         (PortTest.test_find_with_skipped_directories):
2960         (PortTest.test_find_with_skipped_directories_2):
2961         (PortTest.test_is_test_file):
2962         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2963         (_default_tests_paths):
2964         (ChromiumGpuLinuxPort.tests):
2965         (ChromiumGpuCgMacPort.tests):
2966         (ChromiumGpuMacPort.tests):
2967         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2968         (ChromiumGpuTest.test_default_tests_paths.test_paths):
2969         (ChromiumGpuTest.test_default_tests_paths):
2970         (ChromiumGpuTest.test_test_files.test_paths):
2971         (ChromiumGpuTest):
2972         (ChromiumGpuTest.test_test_files):
2973         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2974         (get_tests_run.RecordingTestDriver.run_test):
2975         * Scripts/webkitpy/tool/commands/rebaseline.py:
2976         (OptimizeBaselines._optimize_baseline):
2977         (OptimizeBaselines.execute):
2978         (AnalyzeBaselines._analyze_baseline):
2979         (AnalyzeBaselines.execute):
2980
2981 2011-12-01  Hajime Morrita  <morrita@chromium.org>
2982
2983         JS_INLINE and WTF_INLINE should be visible from WebCore
2984         https://bugs.webkit.org/show_bug.cgi?id=73191
2985
2986         Reviewed by Kevin Ollivier.
2987
2988         Removed macro definitions which is now provided by Platform.h
2989
2990         * DumpRenderTree/chromium/config.h:
2991         * DumpRenderTree/config.h:
2992         * TestWebKitAPI/config.h:
2993         * WebKitTestRunner/config.h:
2994
2995 2011-12-01  Hayato Ito  <hayato@chromium.org>
2996
2997         Explicitly pass tolerance=0 to port.diff_image in case of RefTestMismatch failure.
2998         https://bugs.webkit.org/show_bug.cgi?id=73406
2999
3000         Reviewed by Ryosuke Niwa.
3001
3002         WebKitPort's image_diff uses tolerance='0.1' in default.
3003         When reftests fail, we should use tolerace=0 when diff-ing images.
3004
3005         Since ImageDiff on chromium port doesn't use tolerance value as of now,
3006         this change doesn't affect chromium port's behavior.
3007
3008         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3009         (write_test_result):
3010         * Scripts/webkitpy/layout_tests/port/base.py:
3011         (Port.diff_image):
3012         * Scripts/webkitpy/layout_tests/port/chromium.py:
3013         (ChromiumPort.diff_image):
3014         * Scripts/webkitpy/layout_tests/port/test.py:
3015         (TestPort.diff_image):
3016         * Scripts/webkitpy/layout_tests/port/webkit.py:
3017         (WebKitPort.diff_image):
3018         (WebKitPort._start_image_diff_process):
3019         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3020         (MainTest.test_tolerance.ImageDiffTestPort.diff_image):
3021
3022 2011-12-01  Adam Klein  <adamk@chromium.org>
3023
3024         Add Chromium ToT GTest build bots (and group selection support) to flakiness dashboard
3025         https://bugs.webkit.org/show_bug.cgi?id=73599
3026
3027         Reviewed by Ojan Vafai.
3028
3029         * TestResultServer/static-dashboards/builders.js:
3030         * TestResultServer/static-dashboards/dashboard_base.js:
3031         ():
3032         (htmlForTestTypeSwitcher):
3033         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3034         (testHtmlForTestTypeSwitcherGroup):
3035
3036 2011-12-01  Ryosuke Niwa  <rniwa@webkit.org>
3037
3038         Parse reftest.list and extract types of ref tests
3039         https://bugs.webkit.org/show_bug.cgi?id=66837
3040
3041         Reviewed by Dirk Pranke.
3042
3043         Add support for reftest.list to base port.
3044
3045         * Scripts/webkitpy/common/find_files.py:
3046         (find):
3047         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3048         (SingleTestRunner.__init__):
3049         * Scripts/webkitpy/layout_tests/port/base.py:
3050         (Port.__init__): Initialize self._reftest_list. It's a dictionary mapping from a test directory
3051         to a dictionary of {test path: ("==" or "!=", reference file path)}
3052         (Port._get_reftest_list): Added; calls test_file.parse_reftest_list to fill self._reftest_list.
3053         (Port._reference_file_for): Added; obtains the reference file name given a test name.
3054         (Port.is_reftest): Added; Calls _reference_file_for.
3055         (Port.reftest_expected_filename): Calls _reference_file_for.
3056         (Port.reftest_expected_mismatch_filename): Ditto.
3057         (Port.find_test_files):
3058         (is_reference_html_file): Treat any file that starts with ref- or notref- or ends with
3059         -expected, -expected-mismach, -ref, or -notref as a reference file.
3060         (_is_test_file):
3061         (_parse_reftest_list): Added.
3062         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3063         (PortTest.test_is_test_file):
3064         (PortTest.test_parse_reftest_list):
3065         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3066         (DryrunDriver.run_test):
3067         * Scripts/webkitpy/layout_tests/port/test.py:
3068         (unit_test_filesystem.add_test_file):
3069         (unit_test_filesystem.add_file):
3070         (unit_test_filesystem):
3071         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3072         (get_tests_run.RecordingTestDriver.run_test):
3073         (MainTest.test_unexpected_failures):
3074         (MainTest.test_missing_and_unexpected_results):
3075         (EndToEndTest.test_end_to_end):
3076         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3077         (Rebaseliner._compile_rebaselining_tests):
3078
3079 2011-12-01  Sheriff Bot  <webkit.review.bot@gmail.com>
3080
3081         Unreviewed, rolling out r101711.
3082         http://trac.webkit.org/changeset/101711
3083         https://bugs.webkit.org/show_bug.cgi?id=73605
3084
3085         Broke 3 webkitpy tests (Requested by rniwa on #webkit).
3086
3087         * Scripts/webkitpy/style/checker.py:
3088         (_all_categories):
3089         (FileType):
3090         (CheckerDispatcher._file_type):
3091         (CheckerDispatcher._create_checker):
3092         * Scripts/webkitpy/style/checker_unittest.py:
3093         (CheckerDispatcherDispatchTest.assert_checker_cpp):
3094         (CheckerDispatcherDispatchTest.test_cpp_paths):
3095         * Scripts/webkitpy/style/checkers/jsonchecker.py: Removed.
3096         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Removed.
3097
3098 2011-12-01  Gustavo Noronha Silva  <gns@gnome.org>
3099
3100         Unreviewed. Add myself to GStreamer and WebKit2GTK+ watchlists.
3101
3102         * Scripts/webkitpy/common/config/watchlist:
3103
3104 2011-12-01  Martin Robinson  <mrobinson@igalia.com>
3105
3106         [GTK] Read fonts from the jhbuild root
3107         https://bugs.webkit.org/show_bug.cgi?id=73487
3108
3109         Reviewed by Gustavo Noronha Silva.
3110
3111         Read fonts from the jhbuild root instead of from the system. This will ensure
3112         that all testers use the same fonts instead of leaving this up to luck.
3113
3114         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3115         (initializeFonts): Load fonts from jhbuild root.
3116         * Scripts/webkitpy/layout_tests/port/gtk.py:
3117         (GtkPort.setup_environ_for_server): Pass an environment variable containing
3118         the path to the jhbuild root.
3119         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3120         (WTR::inititializeFontConfigSetting): Load fonts from the jhbuild root.
3121
3122 2011-12-01  Adam Roben  <aroben@apple.com>
3123
3124         Teach check-webkit-style how to check the syntax of JSON files
3125
3126         Fixes <http://webkit.org/b/73590> check-webkit-style doesn't flag JSON syntax errors
3127
3128         Reviewed by Darin Adler.
3129
3130         * Scripts/webkitpy/style/checker.py:
3131         (_all_categories): Added JSONChecker's categories to the set of all categories.
3132         (FileType): Added a JSON type. Incremented other types.
3133         (CheckerDispatcher._file_type): Use the JSON file type for .json files.
3134         (CheckerDispatcher._create_checker): Use a JSONChecker for JSON files.
3135
3136         * Scripts/webkitpy/style/checker_unittest.py:
3137         (CheckerDispatcherDispatchTest.assert_checker_json): Added this helper method.
3138         (CheckerDispatcherDispatchTest.test_json_paths): Added. Based on test_python_paths.
3139
3140         * Scripts/webkitpy/style/checkers/jsonchecker.py: Added. (I didn't name this just "json",
3141         which would have matched our other checkers, because I couldn't figure out how to call
3142         "json.loads" without hitting namespace conflicts.)
3143         (JSONChecker.__init__): Turn of line filtering so that we always check the whole file, not
3144         just the modified lines from a patch.
3145         (JSONChecker.check): Try to parse the lines as JSON. Mark an error if there was an
3146         exception.
3147         (JSONChecker.line_number_from_json_exception): Parse the json modules exception message to
3148         try to extract a line number.
3149
3150         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Added.
3151         (MockErrorHandler.__init__):
3152         (MockErrorHandler.turn_off_line_filtering):
3153         (MockErrorHandler.__call__):
3154         Helper class. Copied from xml_unittest.py.
3155
3156         (JSONCheckerTest.test_line_number_from_json_exception): Test the
3157         line_number_from_json_exception helper method.
3158
3159         (JSONCheckerTest.assert_no_error):
3160         (JSONCheckerTest.assert_error):
3161         Helper methods to assert that we did or didn't get an error.
3162
3163         (JSONCheckerTest.mock_handle_style_error): Helper method.
3164
3165         (JSONCheckerTest.test_conflict_marker):
3166         (JSONCheckerTest.test_single_quote):
3167         (JSONCheckerTest.test_init):
3168         (JSONCheckerTest.test_missing_closing_brace):
3169         (JSONCheckerTest.test_no_error):
3170         Test various cases.
3171
3172 2011-12-01  Martin Robinson  <mrobinson@igalia.com>
3173
3174         [GTK] Add a helper function to find the current executable's path
3175         https://bugs.webkit.org/show_bug.cgi?id=73473
3176
3177         Reviewed by Gustavo Noronha Silva.
3178
3179         Update MiniBrowser to not pass the binary directory as an environment variable.
3180         This means that you can move the binaries around without it breaking.
3181
3182         * MiniBrowser/gtk/main.c:
3183         (main): No longer set the environment variable.
3184         * WebKitTestRunner/GNUmakefile.am: No longer add the directory path define.
3185         * WebKitTestRunner/gtk/main.cpp:  Ditto.
3186
3187 2011-12-01  Gustavo Noronha Silva  <gns@gnome.org>
3188
3189         Unreviewed. Fix bad file =(.
3190
3191         * gtk/jhbuild.modules:
3192         * Scripts/webkitdirs.pm:
3193         (runAutogenForAutotoolsProject):
3194
3195 2011-12-01  Gustavo Noronha Silva  <gns@gnome.org>
3196
3197         [GTK] Add freetype to our jhbuild setup
3198         https://bugs.webkit.org/show_bug.cgi?id=73488
3199
3200         Reviewed by Martin Robinson.
3201
3202         This adds the first library to our jhbuild setup, and makes sure
3203         build-webkit calls autogen.sh and make with jhbuild, so that the
3204         environment is properly set.
3205
3206         * Scripts/webkitdirs.pm:
3207         (saveSum):
3208         (hashFile):
3209         (runAutogenForAutotoolsProject): save md5sum of jhbuild-related files, and
3210         call autogen under jhbuild run;
3211         (mustRunAutogen): generalized the arguments change checking to also force
3212         running autogen when jhbuild files change;
3213         (buildAutotoolsProject): run make under jhbuild;
3214         * gtk/jhbuild.modules: add freetype.
3215
3216 2011-12-01  Dominic Mazzoni  <dmazzoni@google.com>
3217
3218         Fix WebKitTestRunner compile warnings with XCode 3.2
3219         https://bugs.webkit.org/show_bug.cgi?id=73378
3220
3221         Reviewed by Chris Fleizach.
3222
3223         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
3224         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
3225         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
3226         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
3227         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3228         (WTR::AccessibilityUIElement::AccessibilityUIElement):
3229         (WTR::AccessibilityUIElement::verticalScrollbar):
3230
3231 2011-12-01  Adam Roben  <aroben@apple.com>
3232
3233         Allow committers to use their Trac credentials to force builds on the buildbots
3234
3235         Fixes <http://webkit.org/b/73353>
3236
3237         A new class, CommitterAuth, handles authentication of WebKit committers. CommitterAuth uses
3238         three files to do its job: a config file that contains a list of WebKit committer usernames,
3239         an htdigest file that contains Trac credentials, and JSON file that gives the paths for
3240         those two files.
3241
3242         Reviewed by Darin Adler.
3243
3244         * BuildSlaveSupport/build.webkit.org-config/committer_auth.py: Added.
3245         (Error): Basic wrapper around Exception that we use for cases where we couldn't even check
3246         whether credentials were valid or not.
3247         (CommitterAuth.__init__): Just store the path to auth.json.
3248         (CommitterAuth.auth_json): Load, parse, and return auth.json.
3249         (CommitterAuth.auth_json_filename): Return the path to auth.json.
3250         (CommitterAuth.authenticate): Return true if the user is a WebKit committer and their
3251         credentials are valid Trac credentials. Return false otherwise or if an error occurred while
3252         checking those conditions.
3253         (CommitterAuth.is_webkit_committer): Return true if the user is a WebKit committer. Return
3254         false otherwise or if an exception was thrown.
3255         (CommitterAuth.is_webkit_trac_user): Return true if the username/password are present in the
3256         Trac credentials htdigest file. Return false otherwise or if an exception was thrown.
3257
3258         (CommitterAuth.open_auth_json_file):
3259         (CommitterAuth.open_trac_credentials_file):
3260         (CommitterAuth.open_webkit_committers_file):
3261         Open the specified file. These are mostly useful for testing purposes.
3262
3263         (CommitterAuth.trac_credentials_filename):
3264         (CommitterAuth.webkit_committers_filename):
3265         Return the path to the specified file by retrieving it from auth.json.
3266
3267         (CommitterAuth.webkit_committers): Load and parse the committers file and extract the list
3268         of WebKit committers from it.
3269
3270         * BuildSlaveSupport/build.webkit.org-config/committer_auth_unittest.py: Added.
3271         (CMStringIO.__enter__):
3272         (CMStringIO.__exit__):
3273         Helper class that makes it possible to use StringIO with the "with" statement.
3274
3275         (open_override): Helper context manager for overriding the global "open" function
3276         temporarily.
3277
3278         (CommitterAuthTest.setUp): Set up a somewhat-mocked CommitterAuth that is used by most
3279         tests.
3280         (CommitterAuthTest.fake_open_function): Returns a function that can be used in place of
3281         "open" to test that the expected path was opened.
3282         (CommitterAuthTest.test_authentication_success): Test that committers can authenticate
3283         successfully.
3284         (CommitterAuthTest.test_committer_without_trac_credentials_fails): Test that committers who
3285         somehow have no Trac account can't authenticate.
3286
3287         (CommitterAuthTest.test_fail_to_open_auth_json_file):
3288         (CommitterAuthTest.test_fail_to_open_trac_credentials_file):
3289         (CommitterAuthTest.test_fail_to_open_webkit_committers_file):
3290         Test what happens when we can't open the three files we depend upon.
3291
3292         (CommitterAuthTest.test_implements_IAuth): Test that we fulfill buildbot's expectations for
3293         an authentication class.
3294
3295         (CommitterAuthTest.test_invalid_auth_json_file):
3296         (CommitterAuthTest.test_invalid_committers_file):
3297         (CommitterAuthTest.test_invalid_trac_credentials_file):
3298         (CommitterAuthTest.test_missing_auth_json_keys):
3299         Test what happens when the three files we depend upon are invalid in some way.
3300
3301         (CommitterAuthTest.test_open_auth_json_file):
3302         (CommitterAuthTest.test_open_trac_credentials_file):
3303         (CommitterAuthTest.test_open_webkit_committers_file):
3304         Test that we open the expected paths.
3305
3306         (CommitterAuthTest.test_trac_credentials_filename):
3307         (CommitterAuthTest.test_webkit_committers_filename):
3308         Test that we extract filenames out of auth.json correctly.
3309
3310         (CommitterAuthTest.test_non_committer_fails):
3311         (CommitterAuthTest.test_unknown_user_fails):
3312         (CommitterAuthTest.test_username_is_prefix_of_valid_user):
3313         (CommitterAuthTest.test_wrong_password_fails):
3314         Test various failed authentication attempts.
3315
3316         (CommitterAuthTest.test_webkit_committers): Test that we can parse the list of WebKit
3317         committers out of the committers file correctly.
3318
3319         (CommitterAuthTest.fake_auth_json_file):
3320         (CommitterAuthTest.invalid_auth_json_file):
3321         (CommitterAuthTest.fake_committers_file):
3322         (CommitterAuthTest.invalid_committers_file):
3323         (CommitterAuthTest.fake_htdigest_file):
3324         (CommitterAuthTest.invalid_htdigest_file):
3325         Return various fake files for testing.
3326
3327         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Specify an instance of CommitterAuth
3328         to be used for authentication in the web interface, and specify that only authenticated
3329         users may force builds.
3330
3331 2011-12-01  Adam Roben  <aroben@apple.com>
3332
3333         Add an HTDigestParser class to webkitpy
3334
3335         Fixes <http://webkit.org/b/73575> webkitpy doesn't provide a way to parse htdigest files
3336
3337         This class can be used to parse Apache's htdigest files and check whether a given
3338         username/realm/password tuple is present in the file. Eventually this will be used for
3339         authenticating users on build.webkit.org (<http://webkit.org/b/73353>).
3340
3341         Reviewed by Eric Seidel.
3342
3343         * Scripts/webkitpy/common/net/htdigestparser.py: Added.
3344         (HTDigestParser.__init__): Stores the parsed representation of the file.
3345         (HTDigestParser.authenticate): Hashes the username/realm/password tuple to generate a hashed
3346         password and returns whether the resulting tuple is present in the file.
3347         (HTDigestParser.entries): Just returns the parsed representation of the file.
3348         (HTDigestParser.parse_file): Splits each line on colons and checks that each line has the
3349         expected syntax ('username:realm:hashed_password'). If any line is invalid, we treat the
3350         whole file as invalid and all authentication attempts will fail.
3351
3352         * Scripts/webkitpy/common/net/htdigestparser_unittest.py: Added.
3353         (HTDigestParserTest.assertEntriesEqual): Helper method to assert that fake_htdigest_file,
3354         optionally appended with some extra data, generates the expected entries.
3355         (HTDigestParserTest.test_authenticate): Tests that tuples present in the file can
3356         authenticate, and tuples not present cannot.
3357         (HTDigestParserTest.test_entries): Tests that we get the expected entries from
3358         fake_htdigest_file.
3359
3360         (HTDigestParserTest.test_empty_file):
3361         (HTDigestParserTest.test_too_few_colons):
3362         (HTDigestParserTest.test_too_many_colons):
3363         (HTDigestParserTest.test_invalid_hash):
3364         Test various forms of invalid files.
3365
3366         (HTDigestParserTest.fake_htdigest_file): Returns a fake valid htdigest file for testing.
3367
3368 2011-12-01  Philippe Normand  <pnormand@igalia.com>
3369
3370         [GTK] Make the new 64-bit Release bot part of the core set
3371         https://bugs.webkit.org/show_bug.cgi?id=73570
3372
3373         Reviewed by Adam Roben.
3374
3375         The 64-bit Release bot re-introduced in r101676 replaces the 64-bit
3376         Debug bot which was already part of the core set. The GTK
3377         gardeners are willing to actively maintain it.
3378
3379         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3380         (BuildBot.__init__):
3381         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3382         (test_builder_name_regexps):
3383
3384 2011-12-01  Philippe Normand  <pnormand@igalia.com>
3385
3386         [GTK] Buildslave switch from 32-bit Debug to 64-bit Release
3387         https://bugs.webkit.org/show_bug.cgi?id=73547
3388
3389         Reviewed by Adam Roben.
3390
3391         * BuildSlaveSupport/build.webkit.org-config/config.json: Rename
3392         the 32-bit Debug configuration to 64-bit Release. The new slave is
3393         a 64-bit machine already. The 32-bit slave will be shut down.
3394
3395 2011-12-01  Martin Robinson  <mrobinson@igalia.com>
3396
3397         [GTK] build-jsc should not trigger gtkdoc generation
3398         https://bugs.webkit.org/show_bug.cgi?id=73552
3399
3400         Reviewed by Philippe Normand.
3401
3402         Do not generate gtkdoc when building projects other than WebKit. In particular, this ensures
3403         that build-jsc does not try to generate gtkdoc.
3404
3405         * Scripts/webkitdirs.pm:
3406         (buildAutotoolsProject): Only generate gtkdoc if the project is "WebKit".
3407
3408 2011-12-01  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3409
3410         tests_run0.txt gets clobbered when re-running failing tests
3411         https://bugs.webkit.org/show_bug.cgi?id=63844
3412
3413         Reviewed by Dirk Pranke.
3414
3415         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3416         (Manager.results_directory):
3417         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3418         (AbstractWorker.__init__):
3419         (_ManagerConnection.start_worker):
3420         (_InlineManager.start_worker):
3421         (_MultiProcessManager.start_worker):
3422         (_WorkerConnection.__init__):
3423         (_InlineWorkerConnection.__init__):
3424         (_MultiProcessWorkerConnection.__init__):
3425         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3426         (_TestWorker.__init__):
3427         (_TestsMixin.test_cancel):
3428         (_TestsMixin.test_done):
3429         (_TestsMixin.test_unknown_message):
3430         (InterfaceTest.test_managerconnection_is_abstract):
3431         (InterfaceTest.test_workerconnection_is_abstract):
3432         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3433         (Worker.__init__):
3434         (Worker.safe_init):
3435         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3436         (MainTest.test_retries_directory):
3437
3438 2011-12-01  Adam Roben  <aroben@apple.com>
3439
3440         Buildbot fix
3441
3442         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved all of the initialization of
3443         BuildmasterConfig not performed by loadBuilderConfig up to the top of the file. This makes
3444         it possible for build steps to reference things like the buildbotURL property of the config.
3445
3446 2011-11-30  Adam Roben  <aroben@apple.com>
3447
3448         Use curl for downloading builds to test slaves
3449
3450         Buildbot's built-in file transfer capabilities are transferring files much more slowly than
3451         curl does. This seems to be due to a combination of buildbot being single-threaded (and thus
3452         often busy servicing web requests, etc.) and using an IPC mechanism with fairly high
3453         overhead (courtesy of the Twisted framework).
3454
3455         Eventually we'd like to make Buildbot's built-in transferring more efficient. In the
3456         meantime we'll try using curl for downloads and keep thinking about a solution for uploads.
3457         This should make the test slaves quite a bit faster, and should ease the CPU load on
3458         build.webkit.org a bit.
3459
3460         Part of <http://webkit.org/b/73484> Mac slaves take 7+ minutes to upload or download a build
3461
3462         Reviewed by Mark Rowe.
3463
3464         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added the CreateWebKitBuildDirectory
3465         to Test slaves. It's run just before DownloadBuiltProduct.
3466         (DownloadBuiltProduct): Changed to be a normal ShellCommand that invokes curl to perform the
3467         download.
3468         (CreateWebKitBuildDirectory): Added. Creates the WebKitBuild directory on a slave.
3469         FileDownload used to do this for us automatically.
3470
3471 2011-11-21  Philippe Normand  <pnormand@igalia.com>
3472
3473         [GTK] enable-webaudio websetting
3474         https://bugs.webkit.org/show_bug.cgi?id=69836
3475
3476         Reviewed by Martin Robinson.
3477
3478         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3479         (LayoutTestController::overridePreference): Update WebKitGTK
3480         enable-webaudio setting when a layout test requests it.
3481
3482 2011-11-30  Ilya Tikhonovsky  <loislo@chromium.org>
3483
3484         Web Inspector: chromium: I'd like to add a script for running perf tests for WebInspector.
3485         https://bugs.webkit.org/show_bug.cgi?id=73079
3486
3487         The idea is to have performance tests for WebInspector.
3488         I was suggested to put these tests into PerformanceTests/inspector.
3489         They produce output in a format that is suitable for chromium perf bot drawing scripts.
3490
3491         I'd like to reuse code for scanning folders for test files.
3492         Because of the fact that original test_files.py has common and layout specific parts
3493         I decided to extract the generic part and put it into webkitpy/common
3494         I think the two packages with name test_files look strange but I have no idea about a better name.
3495
3496         Reviewed by Dirk Pranke.
3497
3498         * Scripts/run-inspector-perf-tests.py: Added.
3499         * Scripts/webkitpy/common/find_files.py: Renamed from Tools/Scripts/webkitpy/layout_tests/port/test_files.py.
3500         (find):
3501         (_normalize):
3502         * Scripts/webkitpy/common/find_files_unittest.py: Added.
3503         (MockWinFileSystem.join):
3504         (MockWinFileSystem):
3505         (MockWinFileSystem.normpath):
3506         (TestWinNormalize.assert_filesystem_normalizes):
3507         (TestWinNormalize.test_mocked_win):
3508         (TestWinNormalize):
3509         (TestWinNormalize.test_win):
3510         * Scripts/webkitpy/layout_tests/port/base.py:
3511         (Port.tests):
3512         (Port.find_test_files):
3513         (Port._driver_class):
3514         (is_reference_html_file):
3515         (_has_supported_extension):
3516         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3517         (PortTest.test_find_no_paths_specified):
3518         (PortTest.test_find_one_test):
3519         (PortTest.test_find_glob):
3520         (PortTest.test_find_with_skipped_directories):
3521         (PortTest.test_find_with_skipped_directories_2):
3522         (PortTest):
3523         (PortTest.test_is_test_file):
3524         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3525         (_tests):
3526         * Scripts/webkitpy/layout_tests/port/test.py:
3527         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py: Removed.
3528         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3529         * Scripts/webkitpy/performance_tests/__init__.py: Added.
3530         * Scripts/webkitpy/performance_tests/perftestsrunner.py: Added.
3531         (PerfTestsRunner.__init__):
3532         (PerfTestsRunner._parse_args):
3533         (PerfTestsRunner._collect_tests._is_test_file):
3534         (PerfTestsRunner._collect_tests):
3535         (PerfTestsRunner.run):
3536         (PerfTestsRunner._run_tests_set):
3537         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: Added.
3538         (MainTest.TestPort):
3539         (MainTest.TestPort.create_driver):
3540         (MainTest.TestDriver.run_test):
3541         (MainTest.TestDriver):
3542         (MainTest.TestDriver.stop):
3543         (MainTest.create_runner):
3544         (MainTest.run_test):
3545         (MainTest.test_run_passing_test):
3546         (MainTest.test_run_silent_test):
3547         (MainTest.test_run_failed_test):
3548         (MainTest.test_run_tonguey_test):
3549         (MainTest.test_run_timeout_test):
3550         (MainTest.test_run_crash_test):
3551         (MainTest.test_run_test_set):
3552         (MainTest.test_collect_tests):
3553         (MainTest):
3554         (MainTest.test_parse_args):
3555         * Scripts/webkitpy/tool/commands/rebaseline.py:
3556         (OptimizeBaselines.execute):
3557         (AnalyzeBaselines.execute):
3558
3559 2011-11-30  nduca@chromium.org  <nduca@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
3560
3561         [chromium] Enable threaded compositing via CCThreadProxy::hasThread only
3562         https://bugs.webkit.org/show_bug.cgi?id=70838
3563
3564         Reviewed by James Robinson.
3565
3566         * DumpRenderTree/chromium/TestShell.cpp:
3567         (TestShell::resetWebSettings):
3568         * DumpRenderTree/chromium/TestShell.h:
3569         (TestShell::threadedCompositingEnabled):
3570         * DumpRenderTree/chromium/WebPreferences.cpp:
3571         (WebPreferences::reset):
3572         (WebPreferences::applyTo):
3573         * DumpRenderTree/chromium/WebPreferences.h:
3574         * DumpRenderTree/chromium/WebViewHost.cpp:
3575         (WebViewHost::WebViewHost):
3576         (WebViewHost::~WebViewHost):
3577
3578 2011-11-30  Chris Fleizach  <cfleizach@apple.com>
3579
3580         AX: Nodes are reporting that focus can be set when they really can't
3581         https://bugs.webkit.org/show_bug.cgi?id=72791
3582
3583         Reviewed by Beth Dakin.
3584
3585         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3586         (AccessibilityUIElement::isFocusable):
3587         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3588         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3589         (WTR::AccessibilityUIElement::isFocusable):
3590
3591 2011-11-30  Alejandro G. Castro  <alex@igalia.com>
3592
3593         Moved myself to the reviewers list.
3594
3595         * Scripts/webkitpy/common/config/committers.py:
3596
3597 2011-11-30  David Levin  <levin@chromium.org>
3598
3599         [chromium] Move didUpdateLayout from WebFrameClient to WebViewClient.
3600         https://bugs.webkit.org/show_bug.cgi?id=73415
3601
3602         Reviewed by Darin Fisher.
3603
3604         * DumpRenderTree/chromium/WebViewHost.cpp:
3605         (WebViewHost::didUpdateLayout): Move didUpdateLayout to account for
3606         it being moved to a new interface and having the parameter removed.
3607         * DumpRenderTree/chromium/WebViewHost.h: Ditto.
3608
3609 2011-11-30  Adam Roben  <aroben@apple.com>
3610
3611         Make NRWT show DRT/WTR build logs when the build fails or --verbose is passed
3612
3613         This will make it a lot easier to investigate build failures on the bots.
3614
3615         Fixes <http://webkit.org/b/71160> NRWT doesn't show build output when building DRT
3616
3617         Reviewed by Eric Seidel.
3618
3619         * Scripts/webkitpy/common/system/executive_mock.py:
3620         (MockExecutive.run_command): Include the mock output in the ScriptError we raise since it
3621         makes the expected output in WebKitPortTest.test_build_driver more closely mimic the output
3622         seen in practice.
3623
3624         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3625         (ManagerTest.test_http_locking): Pass False for the configure_logging parameter to Printer.
3626         The Printer was modifying the root logger in way that would cause my new tests in
3627         WebKitPort.test_build_driver to fail. The value of the configure_logging parameter doesn't
3628         seem important to the functioning of this test, and passing False makes Printer not modify
3629         the root logger.
3630
3631         * Scripts/webkitpy/layout_tests/port/webkit.py:
3632         (WebKitPort._run_script): Log the output of the command at the DEBUG level so it will show
3633         up when --verbose is passed but not otherwise.
3634         (WebKitPort._build_driver): When an error occurs, log the error message and the script's
3635         output at the ERROR level so it will always show up.
3636
3637         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3638         (WebKitPortTest.test_build_driver): Test that nothing is logged in the normal, successful
3639         cases. Test that the build scripts' output is logged when --verbose is passed or the build
3640         fails.
3641
3642 2011-11-30  Adam Roben  <aroben@apple.com>