URLParser: Handle \ in path according to spec
[WebKit-https.git] / Tools / ChangeLog
1 2016-09-09  Alex Christensen  <achristensen@webkit.org>
2
3         URLParser: Handle \ in path according to spec
4         https://bugs.webkit.org/show_bug.cgi?id=161805
5
6         Reviewed by Andy Estes.
7
8         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
9         (TestWebKitAPI::TEST_F):
10
11 2016-09-09  Alex Christensen  <achristensen@webkit.org>
12
13         URLParser should parse URLs with non-special schemes
14         https://bugs.webkit.org/show_bug.cgi?id=161786
15
16         Reviewed by Andy Estes.
17
18         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
19         (TestWebKitAPI::TEST_F):
20
21 2016-09-08  Yusuke Suzuki  <utatane.tea@gmail.com>
22
23         [WTF] HashTable's rehash is not compatible to Ref<T> and ASan
24         https://bugs.webkit.org/show_bug.cgi?id=161763
25
26         Reviewed by Mark Lam.
27
28         Add tests that inserts many Ref<>s. It incurs HashTable::rehash, and we can ensure
29         that ASan crash does not occur with this patch.
30
31         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
32         (TestWebKitAPI::TEST):
33         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
34         (TestWebKitAPI::TEST):
35
36 2016-09-08  Alex Christensen  <achristensen@webkit.org>
37
38         URLParser: Handle \ in paths of special URLs according to spec
39         https://bugs.webkit.org/show_bug.cgi?id=161781
40
41         Reviewed by Tim Horton.
42
43         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
44         (TestWebKitAPI::TEST_F):
45
46 2016-09-08  Simon Fraser  <simon.fraser@apple.com>
47
48         Update the content-animation.plan file to run css-accelerated-animation.html
49         and pull SVN revision r205680.
50
51         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
52
53 2016-09-08  Simon Fraser  <simon.fraser@apple.com>
54
55         Add a content-animation test with accelerated CSS animations
56         https://bugs.webkit.org/show_bug.cgi?id=161776
57
58         Reviewed by Dean Jackson.
59
60         * Scripts/webkitpy/benchmark_runner/data/patches/ContentAnimation.patch:
61
62 2016-09-08  Alex Christensen  <achristensen@webkit.org>
63
64         URLParser: Parsing empty URLs with a base URL should return the base URL
65         https://bugs.webkit.org/show_bug.cgi?id=161777
66
67         Reviewed by Tim Horton.
68
69         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
70         (TestWebKitAPI::TEST_F):
71
72 2016-09-08  Alex Christensen  <achristensen@webkit.org>
73
74         URLParser failures should preserve the original input string
75         https://bugs.webkit.org/show_bug.cgi?id=161769
76
77         Reviewed by Tim Horton.
78
79         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
80         (TestWebKitAPI::TEST_F):
81         (TestWebKitAPI::shouldFail):
82
83 2016-09-08  Alex Christensen  <achristensen@webkit.org>
84
85         URLParser should parse URLs with a user but no password
86         https://bugs.webkit.org/show_bug.cgi?id=161773
87
88         Reviewed by Brady Eidson.
89
90         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
91         (TestWebKitAPI::TEST_F):
92
93 2016-09-08  Alex Christensen  <achristensen@webkit.org>
94
95         URLParser should parse ports after IPv4 and IPv6 hosts
96         https://bugs.webkit.org/show_bug.cgi?id=161731
97
98         Reviewed by Brady Eidson.
99
100         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
101         (TestWebKitAPI::TEST_F):
102
103 2016-09-08  Alex Christensen  <achristensen@webkit.org>
104
105         URLParser should correctly handle \ in path
106         https://bugs.webkit.org/show_bug.cgi?id=161762
107
108         Reviewed by Brady Eidson.
109
110         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
111         (TestWebKitAPI::TEST_F):
112
113 2016-09-08  Alex Christensen  <achristensen@webkit.org>
114
115         URLParser should handle URLs with empty authority
116         https://bugs.webkit.org/show_bug.cgi?id=161711
117
118         Reviewed by Brady Eidson.
119
120         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
121         (TestWebKitAPI::TEST_F):
122
123 2016-09-08  Alex Christensen  <achristensen@webkit.org>
124
125         Re-land r205580 after r205649 fixed the test failures
126         https://bugs.webkit.org/show_bug.cgi?id=161668
127
128         Re-landing changesets:
129
130         "Punycode encode non-ascii hosts in URLParser"
131         https://bugs.webkit.org/show_bug.cgi?id=161655
132         http://trac.webkit.org/changeset/205521
133
134         "Fix query-only and fragment-only relative URLs when using
135         URLParser"
136         https://bugs.webkit.org/show_bug.cgi?id=161657
137         http://trac.webkit.org/changeset/205526
138
139         "URLParser should parse / as a relative URL"
140         https://bugs.webkit.org/show_bug.cgi?id=161667
141         http://trac.webkit.org/changeset/205532
142
143 2016-09-08  Dean Jackson  <dino@apple.com>
144
145         Expose Apple Pencil input to testing system
146         https://bugs.webkit.org/show_bug.cgi?id=161670
147         <rdar://problem/28183327>
148
149         I fixed the internal builds, now try to fix the public builds.
150
151         * WebKitTestRunner/ios/IOKitSPI.h: Add new enum values.
152
153 2016-09-07  Dean Jackson  <dino@apple.com>
154
155         Expose Apple Pencil input to testing system
156         https://bugs.webkit.org/show_bug.cgi?id=161670
157         <rdar://problem/28183327>
158
159         Attempt to fix iOS 9 builds.
160
161         * WebKitTestRunner/ios/HIDEventGenerator.mm:
162         (-[HIDEventGenerator _createIOHIDEventType:]):
163
164 2016-09-07  Alex Christensen  <achristensen@webkit.org>
165
166         Roll out r205580 and r205582.
167         https://bugs.webkit.org/show_bug.cgi?id=161668
168
169         I need to figure out why this is failing on the bots before landing any more URLParser progress.
170
171 2016-09-07  Alex Christensen  <achristensen@webkit.org>
172
173         Unreviewed, revert r205533.
174         https://bugs.webkit.org/show_bug.cgi?id=161668
175
176         Re-landing changesets:
177
178         "Punycode encode non-ascii hosts in URLParser"
179         https://bugs.webkit.org/show_bug.cgi?id=161655
180         http://trac.webkit.org/changeset/205521
181
182         "Fix query-only and fragment-only relative URLs when using
183         URLParser"
184         https://bugs.webkit.org/show_bug.cgi?id=161657
185         http://trac.webkit.org/changeset/205526
186
187         "URLParser should parse / as a relative URL"
188         https://bugs.webkit.org/show_bug.cgi?id=161667
189         http://trac.webkit.org/changeset/205532
190
191 2016-09-07  Simon Fraser  <simon.fraser@apple.com>
192
193         Enable the <meter> element on iOS
194         https://bugs.webkit.org/show_bug.cgi?id=161714
195         rdar://problem/8978410
196
197         Reviewed by Tim Horton.
198
199         Define ENABLE_METER_ELEMENT unconditionally now.
200
201         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
202
203 2016-09-07  Jonathan Bedard  <jbedard@apple.com>
204
205         Run spindumps on timeout on iOS 9 Simulator Release WK2 (Tests)
206         https://bugs.webkit.org/show_bug.cgi?id=161699
207
208         Reviewed by Alexey Proskuryakov.
209
210         This change does not have testing associated with it because the testing infrastructure does not exists, we cannot currently mock build-bot variables.
211
212         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
213         (RunWebKitTests): Enable sample on timeout for everything.
214         (RunWebKitTests.start): Disable sample on timeout for everything except iOS 9 WK2 release simulators.
215
216 2016-09-06  Dean Jackson  <dino@apple.com>
217
218         Expose Apple Pencil input to testing system
219         https://bugs.webkit.org/show_bug.cgi?id=161670
220         <rdar://problem/28183327>
221
222         Reviewed by Simon Fraser.
223
224         Add API to UIScriptController that allows a test to emulate
225         stylus input, such as from the Apple Pencil.
226
227         The code is only implemented for WebKitTestRunner.
228
229         There are also four new tests that ensure an Apple Pencil
230         operates similarly to a regular touch. The main difference
231         is that you can't have multiple touches when using an Apple Pencil.
232
233         * DumpRenderTree/ios/UIScriptControllerIOS.mm: New methods. Empty implementations.
234         (WTR::UIScriptController::stylusDownAtPoint):
235         (WTR::UIScriptController::stylusMoveToPoint):
236         (WTR::UIScriptController::stylusUpAtPoint):
237         (WTR::UIScriptController::stylusTapAtPoint):
238         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: New methods.
239         * TestRunnerShared/UIScriptContext/UIScriptController.cpp: Empty implementations.
240         (WTR::UIScriptController::stylusDownAtPoint):
241         (WTR::UIScriptController::stylusMoveToPoint):
242         (WTR::UIScriptController::stylusUpAtPoint):
243         (WTR::UIScriptController::stylusTapAtPoint):
244         * TestRunnerShared/UIScriptContext/UIScriptController.h:
245
246         * WebKitTestRunner/ios/HIDEventGenerator.h:
247         * WebKitTestRunner/ios/HIDEventGenerator.mm: New StylusEvent types. Add some properties
248         to SyntheticEventDigitizerInfo.
249         (-[HIDEventGenerator _createIOHIDEventType:]): Add support for StylusEvent types.
250         (-[HIDEventGenerator touchDownAtPoints:touchCount:]): Clear any old stylus info.
251         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:]):
252         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:]):
253         (-[HIDEventGenerator stylusUpAtPoint:]):
254         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
255         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
256         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
257         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
258         * WebKitTestRunner/ios/IOKitSPI.h: Add new include, and new SPI.
259         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Calls into the HIDEventGenerator for the new API.
260         (WTR::UIScriptController::stylusDownAtPoint):
261         (WTR::UIScriptController::stylusMoveToPoint):
262         (WTR::UIScriptController::stylusUpAtPoint):
263         (WTR::UIScriptController::stylusTapAtPoint):
264
265 2016-09-07  Daniel Bates  <dabates@apple.com>
266
267         Update WebKitSystemInterface
268
269         Rubber-stamped by Dean Jackson.
270
271         Copy WebKitSystemInterface for iOS 10 to the built products directory.
272
273         * Scripts/copy-webkitlibraries-to-product-directory:
274
275 2016-09-07  Youenn Fablet  <youenn@apple.com>
276
277         [Streams API] Separate compile flag for ReadableStream and WritableStream
278         https://bugs.webkit.org/show_bug.cgi?id=161044
279
280         Reviewed by Alex Christensen.
281
282         Moving from STREAMS_API to READABLE_STREAM_API and WRITABLE_STREAM_API compilation flags.
283
284         * Scripts/webkitperl/FeatureList.pm:
285         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
286
287 2016-09-07  Carlos Garcia Campos  <cgarcia@igalia.com>
288
289         [GTK] Move some GObject DOM unstable API to stable
290         https://bugs.webkit.org/show_bug.cgi?id=161681
291
292         Reviewed by Žan Doberšek.
293
294         Do not use user message handler unstable API in the tests, since we have stable convenient API for that.
295
296         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
297         (testUserContentManagerScriptMessageFromDOMBindings):
298         (serverCallback): Deleted.
299         (beforeAll): Deleted.
300         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
301         (documentLoadedCallback):
302         (emitURIChanged): Deleted.
303
304 2016-09-07  Youenn Fablet  <youenn@apple.com>
305
306         Using tests-options.json to compute whether tests are slow
307         https://bugs.webkit.org/show_bug.cgi?id=161626
308
309         Reviewed by Darin Adler.
310
311         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: Updated first test to use a MockHost.
312         * Scripts/webkitpy/layout_tests/controllers/manager.py:
313         (Manager.__init__): Loading tests-options.json
314         (Manager._test_is_slow): Computing timeout value based on tests-options.json.
315
316 2016-09-07  Hunseop Jeong  <hs85.jeong@samsung.com>
317
318         [EFL] Need the libosmesa to support the software backend drawing.
319         https://bugs.webkit.org/show_bug.cgi?id=147065
320
321         Reviewed by Gyuyoung Kim.
322
323         Added the libosmesa to support the software backend drawing.
324
325         * efl/install-dependencies:
326
327 2016-09-06  Commit Queue  <commit-queue@webkit.org>
328
329         Unreviewed, rolling out r205521, r205526, and r205532.
330         https://bugs.webkit.org/show_bug.cgi?id=161668
331
332         broke API tests (Requested by alexchristensen on #webkit).
333
334         Reverted changesets:
335
336         "Punycode encode non-ascii hosts in URLParser"
337         https://bugs.webkit.org/show_bug.cgi?id=161655
338         http://trac.webkit.org/changeset/205521
339
340         "Fix query-only and fragment-only relative URLs when using
341         URLParser"
342         https://bugs.webkit.org/show_bug.cgi?id=161657
343         http://trac.webkit.org/changeset/205526
344
345         "URLParser should parse / as a relative URL"
346         https://bugs.webkit.org/show_bug.cgi?id=161667
347         http://trac.webkit.org/changeset/205532
348
349 2016-09-06  Alex Christensen  <achristensen@webkit.org>
350
351         URLParser should parse / as a relative URL
352         https://bugs.webkit.org/show_bug.cgi?id=161667
353
354         Reviewed by Tim Horton.
355
356         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
357         (TestWebKitAPI::TEST_F):
358
359 2016-09-06  Daniel Bates  <dabates@apple.com>
360
361         [iOS] DumpRenderTree and WebKitTestRunner fail to build - "Ad Hoc code signing is not allowed with SDK 'Simulator - iOS 10.0'"
362         https://bugs.webkit.org/show_bug.cgi?id=161661
363
364         Reviewed by Darin Adler.
365
366         Allow ad-hoc code signing when building the dummy DumpRenderTree and WebKitTestRunner
367         command line tools for simulator with the iOS 10 beta SDK.
368
369         * DumpRenderTree/mac/Configurations/Base.xcconfig:
370         * WebKitTestRunner/Configurations/Base.xcconfig:
371
372 2016-09-06  Alex Christensen  <achristensen@webkit.org>
373
374         Fix query-only and fragment-only relative URLs when using URLParser
375         https://bugs.webkit.org/show_bug.cgi?id=161657
376
377         Reviewed by Tim Horton.
378
379         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
380         (TestWebKitAPI::TEST_F):
381
382 2016-09-06  Alex Christensen  <achristensen@webkit.org>
383
384         Punycode encode non-ascii hosts in URLParser
385         https://bugs.webkit.org/show_bug.cgi?id=161655
386
387         Reviewed by Tim Horton.
388
389         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
390         (TestWebKitAPI::wideString):
391         (TestWebKitAPI::TEST_F):
392
393 2016-09-05  Alex Christensen  <achristensen@webkit.org>
394
395         Implement relative file urls and begin implementing character encoding in URLParser
396         https://bugs.webkit.org/show_bug.cgi?id=161618
397
398         Reviewed by Tim Horton.
399
400         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
401         (TestWebKitAPI::TEST_F):
402
403 2016-09-06  Commit Queue  <commit-queue@webkit.org>
404
405         Unreviewed, rolling out r205480.
406         https://bugs.webkit.org/show_bug.cgi?id=161630
407
408         tests-options.json is not known from knockout filesystem
409         (Requested by youenn on #webkit).
410
411         Reverted changeset:
412
413         "Using tests-options.json to compute whether tests are slow"
414         https://bugs.webkit.org/show_bug.cgi?id=161626
415         http://trac.webkit.org/changeset/205480
416
417 2016-09-06  Michael Catanzaro  <mcatanzaro@igalia.com>
418
419         "Redundant argument in sprintf" warning spam from prepare-ChangeLog
420         https://bugs.webkit.org/show_bug.cgi?id=161606
421
422         Reviewed by Darin Adler.
423
424         Avoid extra arguments in call to sprintf, hopefully without introducing new warnings this
425         time.
426
427         * Scripts/prepare-ChangeLog:
428         (statusDescription):
429
430 2016-09-06  Youenn Fablet  <youenn@apple.com>
431
432         Using tests-options.json to compute whether tests are slow
433         https://bugs.webkit.org/show_bug.cgi?id=161626
434
435         Reviewed by Darin Adler.
436
437         * Scripts/webkitpy/layout_tests/controllers/manager.py:
438         (Manager.__init__): Loading tests-options.json
439         (Manager._test_is_slow): Computing timeout value based on tests-options.json.
440
441 2016-09-06  Commit Queue  <commit-queue@webkit.org>
442
443         Unreviewed, rolling out r205461.
444         https://bugs.webkit.org/show_bug.cgi?id=161628
445
446         Introduced "Use of uninitialized value $original in sprintf"
447         warning (Requested by mcatanzaro on #webkit).
448
449         Reverted changeset:
450
451         ""Redundant argument in sprintf" warning spam from prepare-
452         ChangeLog"
453         https://bugs.webkit.org/show_bug.cgi?id=161606
454         http://trac.webkit.org/changeset/205461
455
456 2016-09-06  Youenn Fablet  <youenn@apple.com>
457
458         W3C test importer should be able to identify slow test
459         https://bugs.webkit.org/show_bug.cgi?id=161601
460
461         Reviewed by Darin Adler.
462
463         Test parser is now identifying slow tests based on "meta element name=timeout content=long" elements.
464         Test importer is updating test-options.json file according that information.
465
466         In case of clean import, the test-options.json is cleaned from 'slow' options for all W3C tests.
467
468         * Scripts/webkitpy/w3c/test_importer.py:
469         (TestImporter.__init__):
470         (TestImporter.find_importable_tests):
471         (TestImporter.import_tests):
472         (TestImporter.update_test_options):
473         (TestImporter):
474         (TestImporter.remove_slow_from_w3c_test_options):
475         * Scripts/webkitpy/w3c/test_parser.py:
476         (TestParser.analyze_test):
477         (TestParser.is_slow_test):
478         (TestParser.potential_ref_filename):
479
480 2016-09-06  Per Arne Vollan  <pvollan@apple.com>
481
482         [Win] Crash logs have incorrect symbols.
483         https://bugs.webkit.org/show_bug.cgi?id=161603
484
485         Reviewed by Darin Adler.
486
487         Add build path to _NT_SYMBOL_PATH environment variable.
488
489         * Scripts/webkitpy/port/win.py:
490         (WinPort.setup_crash_log_saving):
491
492 2016-08-31  Filip Pizlo  <fpizlo@apple.com>
493
494         Butterflies should be allocated in Auxiliary MarkedSpace instead of CopiedSpace and we should rewrite as much of the GC as needed to make this not a regression
495         https://bugs.webkit.org/show_bug.cgi?id=160125
496
497         Reviewed by Geoffrey Garen and Keith Miller.
498
499         * DumpRenderTree/TestRunner.cpp:
500         * DumpRenderTree/mac/DumpRenderTree.mm:
501         (DumpRenderTreeMain):
502         * Scripts/run-jsc-stress-tests:
503         * TestWebKitAPI/Tests/WTF/Vector.cpp:
504         (TestWebKitAPI::TEST):
505
506 2016-09-05  Michael Catanzaro  <mcatanzaro@igalia.com>
507
508         "Redundant argument in sprintf" warning spam from prepare-ChangeLog
509         https://bugs.webkit.org/show_bug.cgi?id=161606
510
511         Reviewed by Darin Adler.
512
513         Avoid extra arguments in call to sprintf.
514
515         * Scripts/prepare-ChangeLog:
516         (statusDescription):
517
518 2016-09-05  Michael Catanzaro  <mcatanzaro@igalia.com>
519
520         [GTK] Skip several failing API tests
521
522         Unfortunately we don't have any form of test expectations for API tests, so we'll just skip
523         them after bugs are filed.
524
525         * Scripts/run-gtk-tests:
526         (TestRunner):
527
528 2016-09-05  Youenn Fablet  <youenn@apple.com>
529
530         Fix W3C test importer unit tests after r205447
531         https://bugs.webkit.org/show_bug.cgi?id=161604
532
533         Unreviewed.
534
535         * Scripts/webkitpy/w3c/test_importer.py:
536         (TestImporter.__init__): Skip cleaning test_resource_files files if resource-files.json cannot be read.
537
538 2016-09-05  Philippe Normand  <pnormand@igalia.com>
539
540         WebRTC: Several media stream tests crashing
541         https://bugs.webkit.org/show_bug.cgi?id=161582
542
543         Reviewed by Alejandro G. Castro.
544
545         * gtk/jhbuild.modules: Bump to latest OpenWebRTC master fixing the crash on missing
546         glvideoflip GStreamer element.
547
548 2016-09-05  Youenn Fablet  <youenn@apple.com>
549
550         W3C test importer should generate the list of resource files
551         https://bugs.webkit.org/show_bug.cgi?id=161578
552
553         Reviewed by Ryosuke Niwa.
554
555         Generating LayoutTests/imported/w3c/resources/resource-files.json when importing tests.
556
557         * Scripts/webkitpy/w3c/test_importer.py:
558         (TestImporter.__init__): Reading test resource files configuration file.
559         (TestImporter.find_importable_tests):
560         (TestImporter.import_tests): Update the test resource files based on test parsed files.
561         (TestImporter):
562         (TestImporter._already_identified_as_resource_file): Helper routine to know whether a file is already set as a resource file.
563         (TestImporter._is_in_resources_directory: Helper routine to know whether a file is in a resources directory.
564
565 2016-09-03  Wenson Hsieh  <wenson_hsieh@apple.com>
566
567         Media controls behave strangely when videos mute from within a playing handler
568         https://bugs.webkit.org/show_bug.cgi?id=161559
569         <rdar://problem/28018438>
570
571         Reviewed by Darin Adler.
572
573         Accounts for changes when determining whether or not to show media controls for autoplaying videos that have not
574         begun playing yet. Rather than check for a controlled media element upon page load, we force tests to wait until
575         all autoplaying videos have actually begun playing. This extends to tests that involve interaction, such as
576         clicking or scrolling.
577
578         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
579         (-[VideoControlsManagerTestWebView callJavascriptFunction:]):
580         (-[VideoControlsManagerTestWebView expectControlsManager:afterReceivingMessage:]):
581         (-[VideoControlsManagerTestWebView performAfterReceivingMessage:action:]):
582         (-[VideoControlsManagerTestWebView waitForPageToLoadWithAutoplayingVideos:]):
583         (TestWebKitAPI::TEST):
584         (-[VideoControlsManagerTestWebView loadTestPageNamed:andExpectControlsManager:afterReceivingMessage:]): Deleted.
585         * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html:
586         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html:
587         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-playing-scroll-away.html:
588         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-click-to-pause.html:
589         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-scroll-to-video.html:
590         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-paused-video-hides-controls.html:
591         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-muted-video-hides-controls.html:
592         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-video-keeps-controls.html:
593         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html:
594
595 2016-09-03  Wenson Hsieh  <wenson_hsieh@apple.com>
596
597         Refactor the heuristic for showing media controls to take all media sessions into account
598         https://bugs.webkit.org/show_bug.cgi?id=161503
599         <rdar://problem/28033783>
600
601         Reviewed by Darin Adler.
602
603         Adds new unit tests verifying the behavior of media playback controls when scrolling another video into view.
604         Please see the WebCore ChangeLog for more details about this change. Also refactors existing
605         VideoControlsManager tests by folding duplicated setup and testing logic into helper methods to make the unit
606         tests more readable.
607
608         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
609         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
610         (-[MessageHandler initWithMessage:handler:]):
611         (-[MessageHandler userContentController:didReceiveScriptMessage:]):
612         (-[VideoControlsManagerTestWebView performAfterLoading:]):
613         (-[VideoControlsManagerTestWebView loadTestPageNamed:]):
614         (-[VideoControlsManagerTestWebView loadTestPageNamed:andExpectControlsManager:afterReceivingMessage:]):
615         (-[VideoControlsManagerTestWebView performAfterReceivingMessage:action:]):
616         (-[VideoControlsManagerTestWebView controlledElementID]):
617         (-[VideoControlsManagerTestWebView _handleControlledElementIDResponse:]):
618         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
619         (TestWebKitAPI::TEST):
620         (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]): Deleted.
621         (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
622         (-[OnLoadMessageHandler initWithWKWebView:handler:]): Deleted.
623         (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
624         (-[WKWebView performAfterLoading:]): Deleted.
625         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-playing-scroll-away.html: Added.
626         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-click-to-pause.html: Added.
627         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-scroll-to-video.html: Added.
628         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-paused-video-hides-controls.html: Added.
629         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-muted-video-hides-controls.html: Added.
630         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-video-keeps-controls.html: Added.
631
632 2016-09-03  Youenn Fablet  <youenn@apple.com>
633
634         run-webkit-tests should detect w3c test resource files
635         https://bugs.webkit.org/show_bug.cgi?id=161307
636
637         Reviewed by Ryosuke Niwa.
638
639         * Scripts/webkitpy/port/base.py:
640         (Port.__init__): Adding self._w3c_resource_files to store the list of resource files.
641         (Port.potential_test_names_from_expected_file):
642         (Port._real_tests):
643         (Port.is_w3c_resource_file): Computing whether a file is a resource file based on imported/w3c/resources/resource-files.json.
644         (Port._is_test_file): Updated to call Port.is_w3c_resource_file. _is_test_file is no longer static.
645         (Port): Deleted.
646         * Scripts/webkitpy/port/base_unittest.py:
647         (PortTest.test_additional_platform_directory):
648         (PortTest.test_find_no_paths_specified):
649         (PortTest.test_is_test_file): Updated to use non-static version of _is_test_file.
650         (PortTest.test_is_w3c_resource_file): Adding tests.
651
652 2016-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
653
654         Unreviewed. Fix archive-built-product step in GTK+ bots after r205280.
655
656         * BuildSlaveSupport/built-product-archive:
657         (archiveBuiltProduct): Do not copy to the archive the files needed to run GObject DOM bindings API breaks tests
658         that no longer exist.
659
660 2016-09-02  Alex Christensen  <achristensen@webkit.org>
661
662         URLParser should parse file URLs
663         https://bugs.webkit.org/show_bug.cgi?id=161556
664
665         Reviewed by Tim Horton.
666
667         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
668         (TestWebKitAPI::TEST_F):
669         (TestWebKitAPI::checkURLDifferences):
670
671 2016-09-01  Michael Saboff  <msaboff@apple.com>
672
673         Import Chakra tests to JSC
674         https://bugs.webkit.org/show_bug.cgi?id=154697
675
676         Reviewed by Saam Barati.
677
678         Added "runChakra" and "chakraPassFailErrorHandler" to support the running of
679         Chakra tests.
680
681         * Scripts/run-jsc-stress-tests:
682
683 2016-09-02  Jonathan Bedard  <jbedard@apple.com>
684
685         WebKitTestRunner needs layoutTestController.setDashboardCompatibilityMode
686         https://bugs.webkit.org/show_bug.cgi?id=42547
687  
688         Reviewed by Darin Adler.
689
690         Added JavaScript bindings and C++ implementation of setUseDashboardCompatibilityMode for the WebKit2 sTestRunner.
691         Note: this bug mistakenly called this function setDashboardCompatibilityMode, it is actually setUseDashboardCompatibilityMode.
692
693         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Added dashboard compatiblity mode setter.
694         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
695         (WTR::InjectedBundle::beginTesting): Reset dashboard compatibility mode.
696         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
697         (WTR::TestRunner::setJavaScriptCanAccessClipboard): Code style changes.
698         (WTR::TestRunner::setPrivateBrowsingEnabled): Code style changes.
699         (WTR::TestRunner::setUseDashboardCompatibilityMode): Added dashboard compatiblity mode setter.
700         (WTR::TestRunner::setPopupBlockingEnabled): Code style changes.
701         (WTR::TestRunner::setAuthorAndUserStylesEnabled): Code style changes.
702         (WTR::TestRunner::addOriginAccessWhitelistEntry): Code style changes.
703         * WebKitTestRunner/InjectedBundle/TestRunner.h: Added dashboard compatiblity mode setter.
704
705 2016-09-02  Jer Noble  <jer.noble@apple.com>
706
707         Unreviewed build fix: restore storyboard files to Xcode 7-compatability.
708
709         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard:
710         * MobileMiniBrowser/MobileMiniBrowserFramework/Base.lproj/Main.storyboard:
711
712 2016-09-02  Tim Horton  <timothy_horton@apple.com>
713
714         REGRESSION (r205329): Two API tests time out on iOS Simulator
715         https://bugs.webkit.org/show_bug.cgi?id=161542
716
717         Reviewed by Brady Eidson.
718
719         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
720         (createAnimatedResizeWebView):
721         (createFirstVisuallyNonEmptyWatchingNavigationDelegate):
722         (TEST):
723         (animatedResizeWebView): Deleted.
724         The navigation delegate was being stored in a local and went out of scope
725         before the test was over. Keep it around, instead.
726
727 2016-08-31  Jer Noble  <jer.noble@apple.com>
728
729         Refactor MobileMiniBrowser into an application framework to allow external XCTesting
730         https://bugs.webkit.org/show_bug.cgi?id=161462
731
732         Reviewed by Eric Carlson.
733
734         XCTest targets need to be in the same project as the application which they're testing. To facilitate
735         having external projects with XCTest targets, move the application's implementation into a framework
736         that can be included with a bare-bones application shell for testing.
737
738         Simultaneously, add the ability to load files from within the new framework's bundle by using a
739         'bundle:/' URL scheme. Update the tests to use this new bundle URL and remove the dependency on
740         an external server for testing.
741
742         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
743         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard:
744         * MobileMiniBrowser/MobileMiniBrowser/Info.plist:
745         * MobileMiniBrowser/MobileMiniBrowser/main.m:
746         * MobileMiniBrowser/MobileMiniBrowserFramework/AppDelegate.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h.
747         * MobileMiniBrowser/MobileMiniBrowserFramework/AppDelegate.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m.
748         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Manually instantiate the main view
749             controller from the framework's bundle.
750         * MobileMiniBrowser/MobileMiniBrowserFramework/Assets.xcassets/AppIcon.appiconset/Contents.json: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/Assets.xcassets/AppIcon.appiconset/Contents.json.
751         * MobileMiniBrowser/MobileMiniBrowserFramework/Base.lproj/Main.storyboard: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard.
752         * MobileMiniBrowser/MobileMiniBrowserFramework/Info.plist: Added.
753         * MobileMiniBrowser/MobileMiniBrowserFramework/MobileMiniBrowser.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h.
754         * MobileMiniBrowser/MobileMiniBrowserFramework/TabViewController.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/TabViewController.h.
755         * MobileMiniBrowser/MobileMiniBrowserFramework/TabViewController.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/TabViewController.m.
756         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.h.
757         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.m.
758         (+[NSURL __bundleURLForFileURL:bundle:]): Add utility method.
759         (+[NSURL __fileURLForBundleURL:bundle:]): Ditto.
760         (-[WebViewController navigateTo:]): Support loading "bundle:/" URLs which are really just "file:" URLs
761             pointing to the framework's resources directory.
762         (-[WebViewController observeValueForKeyPath:ofObject:change:context:]): Ditto.
763         * MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m:
764         (-[MobileMiniBrowserUITests testBasicVideoPlayback]):
765
766 2016-09-02  Jonathan Bedard  <jbedard@apple.com>
767
768         Fix --no-sample-on-timeout command line argument
769         https://bugs.webkit.org/show_bug.cgi?id=161507
770
771         Reviewed by Alexey Proskuryakov.
772
773         This patch fixes the —no-sample-on-timeout flag and correctly names spindumps as spindump.txt.
774
775         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
776         (parse_args): Fixed —-no-sample-on-timeout.
777         * Scripts/webkitpy/port/apple.py:
778         (ApplePort.sample_process): Use correct file name.
779         (ApplePort.spindump_file_path): Spindump and sample file names are different.
780         * Scripts/webkitpy/port/driver.py:
781         (Driver._check_for_driver_timeout): Check “sample_on_timeout” flag.
782         * Scripts/webkitpy/port/mac_unittest.py:
783         (MacTest.test_spindump): Modified for correct filename.
784
785 2016-09-02  Jonathan Bedard  <jbedard@apple.com>
786
787         Unreviewed: moved myself to the reviewers list.
788
789         * Scripts/webkitpy/common/config/contributors.json:
790
791 2016-09-02  Tomas Popela  <tpopela@redhat.com>
792
793         [GTK] Fix compiler warning in MiniBrowser
794         https://bugs.webkit.org/show_bug.cgi?id=161529
795
796         We were missing a return statement in decidePermissionRequest() and
797         also there was unused variable in browserWindowConstructed().
798
799         Reviewed by Carlos Garcia Campos.
800
801         * MiniBrowser/gtk/BrowserTab.c:
802         (decidePermissionRequest):
803         * MiniBrowser/gtk/BrowserWindow.c:
804         (browserWindowConstructed):
805
806 2016-09-01  Dan Bernstein  <mitz@apple.com>
807
808         Build fix.
809
810         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
811
812 2016-09-01  Tim Horton  <timothy_horton@apple.com>
813
814         Provide a TestWebKitAPI-wide WKNavigationDelegate to simplify tests
815         https://bugs.webkit.org/show_bug.cgi?id=161413
816
817         Reviewed by Simon Fraser.
818
819         Add TestNavigationDelegate, which provides block properties to make
820         writing tests feel a little more natural (the callbacks can be inline),
821         and also add WKWebView _test_waitForDidFinishNavigation, so that many
822         tests don't even need to manually allocate a navigation delegate at all.
823
824         Adopt in some of the simpler tests; there are a few navigation delegates
825         left behind, which we can move to the new model in the future.
826
827         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
828         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm:
829         (TEST):
830         (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]): Deleted.
831         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm:
832         (TEST):
833         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]): Deleted.
834         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
835         (animatedResizeWebView):
836         (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]): Deleted.
837         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
838         (-[AutoLayoutWKWebView initWithFrame:configuration:]):
839         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
840         (TEST):
841         (-[AutoLayoutNavigationDelegate webView:didFinishNavigation:]): Deleted.
842         * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm:
843         (TEST):
844         (-[CancelFontSubresourceNavigationDelegate webView:didFinishNavigation:]): Deleted.
845         * TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm:
846         (WebKit2_CommandBackForwardTestWKWebView::SetUp):
847         (WebKit2_CommandBackForwardTestWKWebView::loadFiles):
848         (TEST_F):
849         (-[CommandBackForwardNavigationDelegate webView:didFinishNavigation:]): Deleted.
850         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
851         (expectLinkCount):
852         (TEST):
853         (-[DataDetectionNavigationDelegate webView:didFinishNavigation:]): Deleted.
854         * TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm:
855         (TEST):
856         (-[FindInPageNavigationDelegate webView:didFinishNavigation:]): Deleted.
857         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm:
858         (TEST):
859         (-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]): Deleted.
860         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
861         (TEST):
862         (-[DatabaseProcessKillNavigationDelegate webView:didFinishNavigation:]): Deleted.
863         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
864         (-[IndexedDBNavigationDelegate webView:didFinishNavigation:]): Deleted.
865         * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLNotChange.mm:
866         (TEST):
867         (-[ProvisionalURLNotChangeController webView:didFinishNavigation:]): Deleted.
868         (-[ProvisionalURLNotChangeController webView:didFailProvisionalNavigation:withError:]): Deleted.
869         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
870         (RequiresUserActionForPlaybackTest::createWebView):
871         (RequiresUserActionForPlaybackTest::testVideoWithAudio):
872         (RequiresUserActionForPlaybackTest::testVideoWithoutAudio):
873         (RequiresUserActionForPlaybackTest::testAudioOnly):
874         (-[RequiresUserActionForPlaybackNavigationDelegate webView:didFinishNavigation:]): Deleted.
875         * TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm:
876         (TEST):
877         (-[ShrinkToFitNavigationDelegate webView:didFinishNavigation:]): Deleted.
878         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
879         (TEST):
880         (webViewForScriptMessageHandlerMultipleHandlerRemovalTest):
881         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorld.mm:
882         (TEST):
883         (-[SimpleDelegate webView:didFinishNavigation:]): Deleted.
884         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm:
885         (TEST):
886         (-[WKPDFViewResizeNavigationDelegate webView:didFinishNavigation:]): Deleted.
887         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
888         (TEST):
889         (-[EvaluateJavaScriptNavigationDelegate webView:didFinishNavigation:]): Deleted.
890         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewTextInput.mm:
891         (TEST):
892         (-[DummyNavigationDelegate webView:didFinishNavigation:]): Deleted.
893         * TestWebKitAPI/cocoa/TestNavigationDelegate.h: Added.
894         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm: Added.
895         (-[TestNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
896         (-[TestNavigationDelegate webView:didFinishNavigation:]):
897         (-[TestNavigationDelegate _webView:renderingProgressDidChange:]):
898         (-[TestNavigationDelegate waitForDidFinishNavigation]):
899         (-[WKWebView _test_waitForDidFinishNavigation]):
900
901 2016-09-01  Ricky Mondello  <rmondello@apple.com>
902
903         YouTube Flash plug-in replacement facility should not insert showinfo=0 into iframe URLs
904         https://bugs.webkit.org/show_bug.cgi?id=161478
905         <rdar://problem/28050847>
906
907         Reviewed by Eric Carlson.
908
909         * TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp:
910         (TestWebKitAPI::TEST_F): Update expected results.
911
912 2016-09-01  Anders Carlsson  <andersca@apple.com>
913
914         add BlockPtr::fromCallable
915         https://bugs.webkit.org/show_bug.cgi?id=161504
916
917         Reviewed by Tim Horton.
918
919         Add a test.
920
921         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
922         * TestWebKitAPI/Tests/WTF/BlockPtr.mm: Added.
923         (TestWebKitAPI::TEST):
924
925 2016-09-01  Alex Christensen  <achristensen@webkit.org>
926
927         URLParser should handle . and .. in URL paths
928         https://bugs.webkit.org/show_bug.cgi?id=161443
929
930         Reviewed by Brady Eidson.
931
932         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
933         (TestWebKitAPI::eq):
934         (TestWebKitAPI::TEST_F):
935
936 2016-09-01  Commit Queue  <commit-queue@webkit.org>
937
938         Unreviewed, rolling out r205295 and r205303.
939         https://bugs.webkit.org/show_bug.cgi?id=161505
940
941         Broke the iOS build (Requested by ryanhaddad on #webkit).
942
943         Reverted changesets:
944
945         "Refactor MobileMiniBrowser into an application framework to
946         allow external XCTesting"
947         https://bugs.webkit.org/show_bug.cgi?id=161462
948         http://trac.webkit.org/changeset/205295
949
950         "Unreviewed build-fix; don't specify an explicit deployment
951         target."
952         http://trac.webkit.org/changeset/205303
953
954 2016-09-01  Ricky Mondello  <rmondello@apple.com>
955
956         YouTube Flash plug-in replacement facility should more gracefully handle malformed queries
957         https://bugs.webkit.org/show_bug.cgi?id=161476
958         <rdar://problem/28050847>
959
960         Reviewed by Eric Carlson.
961
962         * TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp:
963         (TestWebKitAPI::TEST_F): New tests. The first two and second-to-last test cases cover the "malformed" query
964             logic. A few other tests are added, too.
965
966 2016-09-01  Jer Noble  <jer.noble@apple.com>
967
968         Unreviewed build-fix; don't specify an explicit deployment target.
969
970         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
971
972 2016-08-31  Jer Noble  <jer.noble@apple.com>
973
974         Refactor MobileMiniBrowser into an application framework to allow external XCTesting
975         https://bugs.webkit.org/show_bug.cgi?id=161462
976
977         Reviewed by Eric Carlson.
978
979         XCTest targets need to be in the same project as the application which they're testing. To facilitate
980         having external projects with XCTest targets, move the application's implementation into a framework
981         that can be included with a bare-bones application shell for testing.
982
983         Simultaneously, add the ability to load files from within the new framework's bundle by using a
984         'bundle:/' URL scheme. Update the tests to use this new bundle URL and remove the dependency on
985         an external server for testing.
986
987         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
988         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard:
989         * MobileMiniBrowser/MobileMiniBrowser/Info.plist:
990         * MobileMiniBrowser/MobileMiniBrowser/main.m:
991         * MobileMiniBrowser/MobileMiniBrowserFramework/AppDelegate.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h.
992         * MobileMiniBrowser/MobileMiniBrowserFramework/AppDelegate.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m.
993         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Manually instantiate the main view
994             controller from the framework's bundle.
995         * MobileMiniBrowser/MobileMiniBrowserFramework/Assets.xcassets/AppIcon.appiconset/Contents.json: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/Assets.xcassets/AppIcon.appiconset/Contents.json.
996         * MobileMiniBrowser/MobileMiniBrowserFramework/Base.lproj/Main.storyboard: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard.
997         * MobileMiniBrowser/MobileMiniBrowserFramework/Info.plist: Added.
998         * MobileMiniBrowser/MobileMiniBrowserFramework/MobileMiniBrowser.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h.
999         * MobileMiniBrowser/MobileMiniBrowserFramework/TabViewController.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/TabViewController.h.
1000         * MobileMiniBrowser/MobileMiniBrowserFramework/TabViewController.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/TabViewController.m.
1001         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.h.
1002         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.m.
1003         (+[NSURL __bundleURLForFileURL:bundle:]): Add utility method.
1004         (+[NSURL __fileURLForBundleURL:bundle:]): Ditto.
1005         (-[WebViewController navigateTo:]): Support loading "bundle:/" URLs which are really just "file:" URLs
1006             pointing to the framework's resources directory.
1007         (-[WebViewController observeValueForKeyPath:ofObject:change:context:]): Ditto.
1008         * MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m:
1009         (-[MobileMiniBrowserUITests testBasicVideoPlayback]):
1010
1011 2016-09-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1012
1013         Unreviewed. Fix webkitpy unit tests after r205280.
1014
1015         * Scripts/webkitpy/style/checker_unittest.py:
1016         (GlobalVariablesTest.test_path_rules_specifier):
1017
1018 2016-08-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1019
1020         [GTK] Move GObject DOM bindings to WebKit2 layer and stop auto generating them
1021         https://bugs.webkit.org/show_bug.cgi?id=161438
1022
1023         Reviewed by Michael Catanzaro.
1024
1025         Remove scripts related to the GObject DOM bindings auto-generation.
1026
1027         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1028         (RunGtkAPITests.getText2):
1029         (TestFactory.__init__):
1030         (RunWebKit1Tests): Deleted.
1031         (RunWebKit1Tests.start): Deleted.
1032         (RunWebKit1LeakTests): Deleted.
1033         (RunWebKit1LeakTests.start): Deleted.
1034         (RunAndUploadPerfTests): Deleted.
1035         (RunAndUploadPerfTests.start): Deleted.
1036         (BuildAndRemoteJSCTestsFactory.__init__): Deleted.
1037         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1038         (BuildStepsTest.test_unnecessary_expected_results):
1039         (RunAndUploadPerfTestsTest): Deleted.
1040         (RunAndUploadPerfTestsTest.assertResults): Deleted.
1041         (RunAndUploadPerfTestsTest.test_success): Deleted.
1042         (RunAndUploadPerfTestsTest.test_tests_failed): Deleted.
1043         (RunAndUploadPerfTestsTest.test_build_bad_build): Deleted.
1044         (RunAndUploadPerfTestsTest.test_build_bad_source_json): Deleted.
1045         (RunAndUploadPerfTestsTest.test_build_bad_marge): Deleted.
1046         (RunAndUploadPerfTestsTest.test_build_bad_failed_uploading): Deleted.
1047         (RunAndUploadPerfTestsTest.test_build_bad_preparation): Deleted.
1048         (RunAndUploadPerfTestsTest.test_buildbot_timeout): Deleted.
1049         (RunBenchmarkTest): Deleted.
1050         (RunBenchmarkTest.assertResults): Deleted.
1051         (RunBenchmarkTest.test_success): Deleted.
1052         * Scripts/run-bindings-tests:
1053         (main):
1054         * Scripts/webkitpy/style/checker.py:
1055         * gtk/check-for-webkitdom-api-breaks: Removed.
1056         * gtk/generate-gtkdoc:
1057         * gtk/webkitdom.py: Removed.
1058
1059 2016-08-31  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1060
1061         [EFL] Small clean up in MiniBrowser
1062         https://bugs.webkit.org/show_bug.cgi?id=161428
1063
1064         Reviewed by Yusuke Suzuki.
1065
1066         This patch resizes MiniBrowser, add *char* constants for scheme,
1067         does line breaking, and remove unnecessary spaces.
1068
1069         * MiniBrowser/efl/main.c:
1070         (on_mouse_wheel):
1071         (history_list_hide):
1072         (script_execute_callback):
1073         (on_key_down):
1074         (on_url_changed):
1075         (on_error):
1076         (on_color_picker_request):
1077         (url_from_user_input):
1078         (url_load_from_user_input):
1079         (on_back_button_clicked):
1080         (on_search_case_option_changed):
1081         (on_search_word_start_option_changed):
1082         (on_list_item_select):
1083         (navigation_button_longpress_process):
1084         (on_navigation_policy_decision):
1085         (window_create):
1086         (parse_cookies_policy):
1087
1088 2016-08-31  Alex Christensen  <achristensen@webkit.org>
1089
1090         Implement IPv6 parsing in URLParser
1091         https://bugs.webkit.org/show_bug.cgi?id=161390
1092
1093         Reviewed by Darin Adler.
1094
1095         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1096         (TestWebKitAPI::TEST_F):
1097         (TestWebKitAPI::checkURLDifferences):
1098
1099 2016-08-31  Brady Eidson  <beidson@apple.com>
1100
1101         WK2 Gamepad provider on iOS.
1102         https://bugs.webkit.org/show_bug.cgi?id=161412
1103
1104         Reviewed by Tim Horton.
1105
1106         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1107
1108 2016-08-30  Ricky Mondello  <rmondello@apple.com>
1109
1110         YouTubePluginReplacementTest's URL transformation logic should have tests
1111         https://bugs.webkit.org/show_bug.cgi?id=161406
1112         <rdar://problem/28050847>
1113
1114         Reviewed by Eric Carlson.
1115
1116         Add some very basic tests. Future patches should expand on these to find and fix bugs.
1117
1118         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add YouTubePluginReplacement.cpp.
1119         * TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp: Added.
1120         (TestWebKitAPI::test): Added.
1121         (TestWebKitAPI::TEST_F): Added.
1122
1123 2016-08-30  Brady Eidson  <beidson@apple.com>
1124
1125         GameController.framework backend for gamepad API.
1126         https://bugs.webkit.org/show_bug.cgi?id=161086
1127
1128         Reviewed by Alex Christensen.
1129
1130         * MiniBrowser/mac/AppDelegate.m:
1131         (-[BrowserAppDelegate awakeFromNib]):
1132
1133         * MiniBrowser/mac/SettingsController.h:
1134         * MiniBrowser/mac/SettingsController.m:
1135         (-[SettingsController _populateMenu]):
1136         (-[SettingsController validateMenuItem:]):
1137         (-[SettingsController usesGameControllerFramework]):
1138         (-[SettingsController toggleUsesGameControllerFramework:]):
1139
1140 2016-08-30  Brent Fulgham  <bfulgham@apple.com>
1141
1142         Use of uninitialised memory in TransformationMatrx::blend4()
1143         https://bugs.webkit.org/show_bug.cgi?id=134621
1144         <rdar://problem/27337539>
1145
1146         Reviewed by Dean Jackson.
1147
1148         Change is based on the Blink change (patch by <alancutter@chromium.org>):
1149         <https://src.chromium.org/viewvc/blink?revision=177453&view=revision>
1150
1151         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1152         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp: Added.
1153         (TestWebKitAPI::TEST):
1154
1155 2016-08-30  Alex Christensen  <achristensen@webkit.org>
1156
1157         URLParser should handle relative URLs that start with //
1158         https://bugs.webkit.org/show_bug.cgi?id=161364
1159
1160         Reviewed by Darin Adler.
1161
1162         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1163         (TestWebKitAPI::checkRelativeURL):
1164         (TestWebKitAPI::TEST_F):
1165
1166 2016-08-29  Aakash Jain  <aakash_jain@apple.com>
1167
1168         EWS patch status page should indicate bot corresponding to each status message
1169         https://bugs.webkit.org/show_bug.cgi?id=161280
1170
1171         Reviewed by Alexey Proskuryakov.
1172
1173         * QueueStatusServer/templates/patch.html: Formatting changes.
1174
1175 2016-08-29  Aakash Jain  <aakash_jain@apple.com>
1176
1177         EWS should indicate which bot processed the patch
1178         https://bugs.webkit.org/show_bug.cgi?id=161222
1179
1180         Reviewed by Alexey Proskuryakov.
1181
1182         * QueueStatusServer/handlers/statusbubble.py:
1183         (StatusBubble._build_bubble): Remove the bot id from bubbles as it is confusing.
1184         bot ids are now displayed in patch status page.
1185
1186 2016-08-29  Alex Christensen  <achristensen@webkit.org>
1187
1188         URLParser should parse about:blank
1189         https://bugs.webkit.org/show_bug.cgi?id=161324
1190
1191         Reviewed by Brady Eidson.
1192
1193         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1194         (TestWebKitAPI::TEST_F):
1195
1196 2016-08-29  JF Bastien  <jfbastien@apple.com>
1197
1198         Bug 161165 - check-webkit-style doesn't understand macros containing `else` or labels
1199         https://bugs.webkit.org/show_bug.cgi?id=161165
1200
1201         Reviewed by Geoffrey Garen.
1202
1203         Fix handling of `else` in a macro. Don't handle labels in a macro:
1204         the checker is already pretty messy in that area and it should be
1205         a rare thing.
1206
1207         * Scripts/webkitpy/style/checkers/cpp.py:
1208         (check_braces):
1209         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1210         (CppStyleTest.test_else_clause_not_on_same_line_as_else):
1211
1212 2016-08-29  Alex Christensen  <achristensen@webkit.org>
1213
1214         API test URLParserTest.ParserFailures failing ASSERT_NOT_REACHED
1215         https://bugs.webkit.org/show_bug.cgi?id=161317
1216
1217         Reviewed by Brady Eidson.
1218
1219         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1220         (TestWebKitAPI::TEST_F):
1221
1222 2016-08-29  Jer Noble  <jer.noble@apple.com>
1223
1224         Unreviewed gardening; only build MiniBrowser against iOS SDK targets.
1225
1226         * Makefile:
1227
1228 2016-08-29  Jonathan Bedard  <jbedard@apple.com>
1229
1230         Sample Process on notifyDone timed out
1231         https://bugs.webkit.org/show_bug.cgi?id=161063
1232
1233         Reviewed by Darin Adler.
1234
1235         * Scripts/webkitpy/port/driver.py:
1236         (Driver._check_for_driver_timeout): 
1237         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Call sample_process during notifyDone timeouts.
1238         (WTR::TestRunner::waitToDumpWatchdogTimerFired):
1239         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm: Log pid and name for testing harness.
1240
1241 2016-08-29  Jonathan Bedard  <jbedard@apple.com>
1242
1243         Check-webkit-style does not work with Objective-C blocks
1244         https://bugs.webkit.org/show_bug.cgi?id=161247
1245
1246         Reviewed by Darin Adler.
1247
1248         * Scripts/webkitpy/style/checkers/cpp.py:
1249         (regex_for_lambda_functions): Changed to regex_for_lambdas_and_blocks.
1250         (regex_for_lambdas_and_blocks): Added check for Objective-C blocks.
1251         (check_spacing_for_function_call): Pass file state for lambda check.
1252         (check_spacing): Pass file state for lambda check.
1253         (check_braces): Pass file state for lambda check.
1254         (check_style): Pass file state for lambda check.
1255         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1256         (CppStyleTest.test_cpp_lambda_functions): Changed from ‘test_lambda_functions’.
1257         (CppStyleTest.test_objective_c_block): Tests Objective-C blocks.
1258         (CppStyleTest.test_lambda_functions): Changed to ‘test_cpp_lambda_functions’.
1259
1260 2016-08-29  Aakash Jain  <aakash_jain@apple.com>
1261
1262         EWS patch status page should indicate bot corresponding to each status message
1263         https://bugs.webkit.org/show_bug.cgi?id=161280
1264
1265         Reviewed by Alexey Proskuryakov.
1266
1267         * QueueStatusServer/templates/patch.html: Added bot_id in the template so that bot id is displayed
1268         for each status message.
1269         * QueueStatusServer/stylesheets/common.css:
1270         (.status-bot): Added corresponding stylesheet class.
1271
1272 2016-08-29  Per Arne Vollan  <pvollan@apple.com>
1273
1274         Attempt to fix Windows build after r205090.
1275
1276         Unreviewed build fix.
1277
1278         * DumpRenderTree/win/DRTDataObject.cpp:
1279         (cfFileNameWFormat):
1280         (cfUrlWFormat):
1281
1282 2016-08-27  Alex Christensen  <achristensen@webkit.org>
1283
1284         URLParser should parse relative URLs
1285         https://bugs.webkit.org/show_bug.cgi?id=161282
1286
1287         Reviewed by Darin Adler.
1288
1289         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1290         (TestWebKitAPI::TEST):
1291         Added some tests for the new operator=.
1292         Test saving iterators, restoring iterators, and even assigning iterators to new CodePoints objects.
1293         Using the same iterator to iterate multiple objects is bad practice, but it's possible and now tested.
1294         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1295         (TestWebKitAPI::checkURL):
1296         (TestWebKitAPI::TEST_F):
1297         (TestWebKitAPI::checkRelativeURL):
1298         (TestWebKitAPI::checkURLDifferences):
1299         (TestWebKitAPI::shouldFail):
1300         Add some relative URL tests.
1301
1302 2016-08-27  Jonathan Bedard  <jbedard@apple.com>
1303
1304         WTR needs an implementation of setAutomaticLinkDetectionEnabled
1305         https://bugs.webkit.org/show_bug.cgi?id=87162
1306
1307         Reviewed by Darin Adler.
1308
1309         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Added setAutomaticLinkDetectionEnabled binding.
1310         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1311         (WTR::InjectedBundle::beginTesting): Set automatic link detection to false by default.
1312         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1313         (WTR::TestRunner::setAutomaticLinkDetectionEnabled): Added setAutomaticLinkDetectionEnabled definition.
1314         * WebKitTestRunner/InjectedBundle/TestRunner.h: Added setAutomaticLinkDetectionEnabled declaration.
1315
1316 2016-08-27  Joseph Pecoraro  <pecoraro@apple.com>
1317
1318         Web Inspector: Make localizedString.js diff and commit friendly (UTF16 -> UTF8)
1319         https://bugs.webkit.org/show_bug.cgi?id=28685
1320         <rdar://problem/16460975>
1321
1322         Reviewed by Darin Adler.
1323
1324         * Scripts/extract-localizable-js-strings:
1325         * Scripts/update-webkit-localizable-strings:
1326         WebInspectorUI localizedStrings.js is now UTF-8. Other clients of
1327         this script still use UTF-16, so keep that the default.
1328
1329 2016-08-27  Alexey Proskuryakov  <ap@apple.com>
1330
1331         REGRESSION (r204052): Popovers on bot watcher's dashboard are broken
1332         https://bugs.webkit.org/show_bug.cgi?id=161254
1333
1334         Reviewed by Darin Adler.
1335
1336         Simplify the CSS. My understanding that the CSS was correct, and the root cause
1337         is tracked in bug 160478.
1338
1339         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
1340
1341 2016-08-27  Simon Fraser  <simon.fraser@apple.com>
1342
1343         Add run-webkit-tests --print-expectations to show expectations for all or a subset of tests
1344         https://bugs.webkit.org/show_bug.cgi?id=161217
1345
1346         Reviewed by Ryosuke Niwa.
1347
1348         "run-webkit-tests --print-expectations" runs the same logic as running the tests, but
1349         dumps out the lists of tests that would be run and skipped, and, for each, the entry
1350         in TestExpectations that determines the expected outcome of the test.
1351
1352         This is an improved version of webkit-patch print-expectations.
1353
1354         See bug for sample output.
1355
1356         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1357         (Manager._print_expectations_for_subset): Print out the list of tests and expected
1358         outcome for some subset of tests.
1359         (Manager.print_expectations): Do the same splitting by device class that running tests
1360         does, and for each subset of tests, call _print_expectations_for_subset.
1361         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1362         (TestExpectationParser.expectation_for_skipped_test): Set the flag
1363         expectation_line.not_applicable_to_current_platform
1364         (TestExpectationLine.__init__): Init not_applicable_to_current_platform to False
1365         (TestExpectationLine.expected_behavior): line.expectation is ['PASS'] by default,
1366         even for skipped tests. This function returns a list relevant for display, taking the skipped
1367         modifier into account.
1368         (TestExpectationLine.create_passing_expectation): expectations is normally a list, not a set.
1369         (TestExpectations.readable_filename_and_line_number): Return something printable for 
1370         lines with and without filenames
1371         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1372         (main): Handle options.print_expectations
1373         (parse_args): Add support for --print-expectations
1374         (_print_expectations):
1375         * Scripts/webkitpy/port/ios.py:
1376         (IOSSimulatorPort.default_child_processes): Make this a debug log.
1377
1378 2016-08-26  Dan Bernstein  <mitz@apple.com>
1379
1380         Keep trying to fix the build after r205057.
1381
1382         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1383
1384 2016-08-26  Dan Bernstein  <mitz@apple.com>
1385
1386         Keep trying to fix the build after r205057.
1387
1388         * MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m: Don’t try to import nonexistent
1389           config.h. This file is only meant to be built with Xcode anyway.
1390         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard: Make this compile
1391           with Xcode 7.3 and deploy to iOS 9.0.
1392         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard: Ditto.
1393         * MobileMiniBrowser/MobileMiniBrowser/TabViewController.m: Don’t try to import config.h.
1394         * MobileMiniBrowser/MobileMiniBrowser/WebViewController.m: Ditto.
1395
1396 2016-08-26  Dan Bernstein  <mitz@apple.com>
1397
1398         Start trying to fix the build after r205057.
1399
1400         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1401
1402 2016-08-26  Alexey Proskuryakov  <ap@apple.com>
1403
1404         Remove Yosemite Leaks from the flakiness dashboard
1405         https://bugs.webkit.org/show_bug.cgi?id=161253
1406
1407         Reviewed by Anders Carlsson.
1408
1409         * TestResultServer/static-dashboards/builders.jsonp:
1410
1411 2016-08-26  Sam Weinig  <sam@webkit.org>
1412
1413         Remove support for ENABLE_LEGACY_WEB_AUDIO
1414         https://bugs.webkit.org/show_bug.cgi?id=161262
1415
1416         Reviewed by Anders Carlsson.
1417
1418         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1419
1420 2016-08-26  Jer Noble  <jer.noble@apple.com>
1421
1422         Add a test harness for running UI tests on the iOS Simulator
1423         https://bugs.webkit.org/show_bug.cgi?id=161265
1424
1425         Reviewed by Simon Fraser.
1426
1427         Add a new iOS Simulator application which uses WKWebView to implement a basic browser, and which
1428         can serve as a test harness for WebKit UI tests.
1429
1430         Also add a basic media playback test which verifies that a <video> element will begin playing in
1431         fullscreen on an iPhone device, but will play inline on an iPad device.
1432
1433         * Makefile: Add MobileMiniBrowser as a Module for iOS builds.
1434         * MobileMiniBrowser/Configurations/Base.xcconfig: Added.
1435         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Added.
1436         * MobileMiniBrowser/Configurations/MobileMiniBrowser.xcconfig: Added.
1437         * MobileMiniBrowser/Makefile: Added.
1438         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj: Added.
1439         * MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h: Added.
1440         * MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m: Added.
1441         (-[AppDelegate application:didFinishLaunchingWithOptions:]):
1442         (-[AppDelegate applicationWillResignActive:]):
1443         (-[AppDelegate applicationDidEnterBackground:]):
1444         (-[AppDelegate applicationWillEnterForeground:]):
1445         (-[AppDelegate applicationDidBecomeActive:]):
1446         (-[AppDelegate applicationWillTerminate:]):
1447         * MobileMiniBrowser/MobileMiniBrowser/Assets.xcassets/AppIcon.appiconset/Contents.json: Added.
1448         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard: Added.
1449         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard: Added.
1450         * MobileMiniBrowser/MobileMiniBrowser/Info.plist: Added.
1451         * MobileMiniBrowser/MobileMiniBrowser/TabViewController.h: Added.
1452         * MobileMiniBrowser/MobileMiniBrowser/TabViewController.m: Added.
1453         (-[TabViewController dealloc]):
1454         (-[TabViewController viewDidLoad]):
1455         (-[TabViewController observeValueForKeyPath:ofObject:change:context:]):
1456         (-[TabViewController tableView:cellForRowAtIndexPath:]):
1457         (-[TabViewController tableView:numberOfRowsInSection:]):
1458         (-[TabViewController numberOfSectionsInTableView:]):
1459         (-[TabViewController tableView:canEditRowAtIndexPath:]):
1460         (-[TabViewController tableView:canMoveRowAtIndexPath:]):
1461         (-[TabViewController tableView:commitEditingStyle:forRowAtIndexPath:]):
1462         (-[TabViewController tableView:didSelectRowAtIndexPath:]):
1463         * MobileMiniBrowser/MobileMiniBrowser/WebViewController.h: Added.
1464         * MobileMiniBrowser/MobileMiniBrowser/WebViewController.m: Added.
1465         (-[WebViewController viewDidLoad]):
1466         (-[WebViewController didReceiveMemoryWarning]):
1467         (-[WebViewController reload:]):
1468         (-[WebViewController goBack:]):
1469         (-[WebViewController goForward:]):
1470         (-[WebViewController urlFieldEditingBegan:]):
1471         (-[WebViewController navigateTo:]):
1472         (-[WebViewController showTabs:]):
1473         (-[WebViewController selectWebViewAtIndex:]):
1474         (-[WebViewController removeWebViewAtIndex:]):
1475         (-[WebViewController addWebView]):
1476         (-[WebViewController createWebView]):
1477         (-[WebViewController removeWebView:]):
1478         (-[WebViewController setCurrentWebView:]):
1479         (-[WebViewController webView:didFailNavigation:withError:]):
1480         (-[WebViewController observeValueForKeyPath:ofObject:change:context:]):
1481         * MobileMiniBrowser/MobileMiniBrowser/main.m: Added.
1482         (main):
1483         * MobileMiniBrowser/MobileMiniBrowserUITests/Info.plist: Added.
1484         * MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m: Added.
1485         (-[MobileMiniBrowserUITests setUp]):
1486         (-[MobileMiniBrowserUITests tearDown]):
1487         (-[MobileMiniBrowserUITests testBasicVideoPlayback]):
1488
1489 2016-08-26  Aakash Jain  <aakash_jain@apple.com>
1490
1491         webkit-queues queue-status page should should list more recent statuses
1492         https://bugs.webkit.org/show_bug.cgi?id=161220
1493
1494         Reviewed by Daniel Bates.
1495
1496         * QueueStatusServer/handlers/queuestatus.py:
1497         (QueueStatus._fetch_statuses): Increase the number of recent statuses from 15 to 50.
1498
1499 2016-08-26  Dan Bernstein  <mitz@apple.com>
1500
1501         [Cocoa] Infinite recursion calling -charValue on a WKNSNumber
1502         https://bugs.webkit.org/show_bug.cgi?id=161258
1503
1504         Reviewed by Anders Carlsson.
1505
1506         * TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm:
1507         (TestWebKitAPI::TEST):
1508
1509 2016-08-26  Csaba Osztrogonác  <ossy@webkit.org>
1510
1511         Fix the ENABLE(WEBASSEMBLY) build on Linux
1512         https://bugs.webkit.org/show_bug.cgi?id=161197
1513
1514         Reviewed by Mark Lam.
1515
1516         * Scripts/build-jsc:
1517
1518 2016-08-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1519
1520         [GTK] run-gtk-tests should use the driver environment for checking the accessibility bus
1521         https://bugs.webkit.org/show_bug.cgi?id=161149
1522
1523         Reviewed by Carlos Garcia Campos.
1524
1525         Add a new function for waiting for the accesibility bus. It sets
1526         the test environment variables before starting the GLib mainloop.
1527         And restores the previous environment after it has finished.
1528         It also adds a timeout (5 seconds) to abort in case it has not
1529         been able to detect the accesibility bus before the timeout expires.
1530
1531         * Scripts/run-gtk-tests:
1532         (TestRunner):
1533         (TestRunner._wait_for_accessibility_bus):
1534         (TestRunner._wait_for_accessibility_bus.timeout_accessibility_bus):
1535         (TestRunner._start_accessibility_daemons):
1536         (TestRunner._get_tests_from_google_test_suite): Run this command also with the driver test environment.
1537
1538 2016-08-26  Per Arne Vollan  <pvollan@apple.com>
1539
1540         [Win] Warning fix.
1541         https://bugs.webkit.org/show_bug.cgi?id=161236
1542
1543         Reviewed by Brent Fulgham.
1544
1545         The & operator in the Test struct has no body.
1546
1547         * TestWebKitAPI/Tests/WTF/Vector.cpp:
1548         (TestWebKitAPI::TEST):
1549
1550 2016-08-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1551
1552         [GTK] run-gtk-tests should use webkitpy.port.gtk and webkitpy.port.xvfbdriver
1553         https://bugs.webkit.org/show_bug.cgi?id=160736
1554
1555         Reviewed by Carlos Garcia Campos.
1556
1557         This plugs run-gtk-tests into the webkitpy testing infrastructure.
1558         As a benefit of this, run-gtk-tests now can be executed over any of
1559         the existing supported gtk test display servers (xvfb, weston-over-xvfb,
1560         or native xorg). A new command line switch --wayland is added for
1561         run-gtk-tests.
1562
1563         * Scripts/run-gtk-tests:
1564         (TestRunner.__init__): Remove the --display command line switch, its not longer useful.
1565         Add a --wayland command line switch.
1566         (TestRunner._start_accessibility_daemons):
1567         (TestRunner):
1568         (TestRunner.__init__):
1569         (TestRunner._run_xvfb): Deleted.
1570         (TestRunner._create_driver):
1571         (TestRunner._setup_testing_environment): Delete the environment variable definitions that
1572         are now done by driver._setup_environ_for_test().
1573         (TestRunner._tear_down_testing_environment):
1574         * Scripts/webkitpy/port/driver.py:
1575         (Driver.__init__): Define self._server_name in the constructor of the base class.
1576         It is used by several functions, so it makes sense to store once the value here.
1577         (Driver._setup_environ_for_test): Factorize setting the environment for a given test.
1578         (Driver._start): Get the environment from self._setup_environ_for_test()
1579         * Scripts/webkitpy/port/driver_unittest.py:
1580         (DriverTest):
1581         (DriverTest.test_setup_environ_for_test): Add unittest for driver._setup_environ_for_test()
1582         * Scripts/webkitpy/port/gtk.py: Move the inspection of the env var USE_NATIVE_XDISPLAY to the constructor.
1583         (GtkPort.__init__):
1584         (GtkPort._driver_class):
1585         * Scripts/webkitpy/port/westondriver.py: Define and use self._setup_environ_for_test()
1586         (WestonDriver._setup_environ_for_test):
1587         (WestonDriver._start):
1588         * Scripts/webkitpy/port/xorgdriver.py: Define and use self._setup_environ_for_test()
1589         (XorgDriver._setup_environ_for_test):
1590         (XorgDriver._start):
1591         * Scripts/webkitpy/port/xvfbdriver.py: Define and use self._setup_environ_for_test()
1592         (XvfbDriver._setup_environ_for_test):
1593         (XvfbDriver._start):
1594
1595 2016-08-26  Csaba Osztrogonác  <ossy@webkit.org>
1596
1597         [EFL][GTK] REGRESSION(204877): Fix the clean build
1598         https://bugs.webkit.org/show_bug.cgi?id=161240
1599
1600         Reviewed by Carlos Garcia Campos.
1601
1602         * WebKitTestRunner/PlatformEfl.cmake:
1603         * WebKitTestRunner/PlatformGTK.cmake:
1604
1605 2016-08-26  Aakash Jain  <aakash_jain@apple.com>
1606
1607         EWS should indicate which bot processed the patch
1608         https://bugs.webkit.org/show_bug.cgi?id=161222
1609
1610         Reviewed by Daniel Bates.
1611
1612         * QueueStatusServer/handlers/statusbubble.py:
1613         (StatusBubble._build_bubble): Display the bot id in status bubble. Also removed "Started processing" message since
1614         after bug fix of 161223, bots send the "Started processing patch" message and it would be displayed in Recent messages.
1615         Also added "Started processing patch" message to progress_statuses.
1616         I might consider displaying bot id in other statuses as well later on.
1617
1618 2016-08-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1619
1620         [EFL] Change homepage url to www.ewebkit.org on MiniBrowser
1621         https://bugs.webkit.org/show_bug.cgi?id=161184
1622
1623         Reviewed by Carlos Garcia Campos.
1624
1625         * MiniBrowser/efl/main.c: Set www.ewebkit.org.
1626
1627 2016-08-25  Aakash Jain  <aakash_jain@apple.com>
1628
1629         ews queues should update status server when they start processing patch
1630         https://bugs.webkit.org/show_bug.cgi?id=161223
1631
1632         Reviewed by Daniel Bates.
1633
1634         * Scripts/webkitpy/tool/commands/queues.py:
1635         (AbstractReviewQueue.process_work_item): Update status server that the bot started processing the patch.
1636         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1637         (EarlyWarningSystemTest._default_expected_logs): Updated the unit test accordingly.
1638         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1639         (StyleQueueTest.test_style_queue_with_style_exception): Same.
1640         (test_style_queue_with_watch_list_exception): Same.
1641         (test_non_valid_patch): Same.
1642
1643 2016-08-25  Alex Christensen  <achristensen@webkit.org>
1644
1645         CMake build fix.
1646
1647         * DumpRenderTree/PlatformMac.cmake:
1648
1649 2016-08-25  Alex Christensen  <achristensen@webkit.org>
1650
1651         Fix URLParserTest with GuardMalloc
1652         https://bugs.webkit.org/show_bug.cgi?id=161214
1653         rdar://problem/28014390
1654
1655         Reviewed by Tim Horton.
1656
1657         The CString returned by String::utf8 was going out of scope before we were doing a string comparison on its data.
1658         This just does the comparison of the CStrings instead to keep them in scope during the comparison.
1659
1660         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1661         (TestWebKitAPI::eq):
1662         (TestWebKitAPI::checkURL):
1663         (TestWebKitAPI::checkURLDifferences):
1664         (TestWebKitAPI::s): Deleted.
1665
1666 2016-08-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1667
1668         Dragging against the end of the inline media scrubber causes the media scrubber to hide
1669         https://bugs.webkit.org/show_bug.cgi?id=161207
1670
1671         Reviewed by Eric Carlson.
1672
1673         Tweaks an existing WebKit API test covering this behavior change. After some discussion, rather than hide media
1674         controls in this case, we should actually continue showing them. This is because seeking due to user gestures
1675         similar to "scrubbing" are indistinguishable from gestures that immediately seek to the end.
1676
1677         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1678         (TestWebKitAPI::TEST):
1679
1680 2016-08-25  Daniel Bates  <dabates@apple.com>
1681
1682         Watch more things.
1683
1684         * Scripts/webkitpy/common/config/watchlist:
1685
1686 2016-08-25  Daniel Bates  <dabates@apple.com>
1687
1688         Fix test failure on GTK Linux bots after <http://trac.webkit.org/changeset/204695>
1689         (https://bugs.webkit.org/show_bug.cgi?id=148437)
1690
1691         Remove use of module File::Slurp as it is not part of the standard Perl 5 distribution
1692         and is not installed on the GTK Linux bots.
1693
1694         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
1695         (writeFileWithContent): Added.
1696
1697 2016-08-25  Per Arne Vollan  <pvollan@apple.com>
1698
1699         [Win] run-api-tests is failing.
1700         https://bugs.webkit.org/show_bug.cgi?id=161140
1701
1702         Reviewed by Brent Fulgham.
1703
1704         Since the move constructor is called 3 more times on Windows, we will have 3 more destructor calls.
1705
1706         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
1707         (TestWebKitAPI::TEST):
1708
1709 2016-08-24  Per Arne Vollan  <pvollan@apple.com>
1710
1711         [Win] run-api-tests is failing.
1712         https://bugs.webkit.org/show_bug.cgi?id=161140
1713
1714         Reviewed by Brent Fulgham.
1715
1716         The number of times the move constructor is called is different on Windows in this test. This seems
1717         to be caused by differences in MSVC's implementation of lambdas or std functions like std::make_tuple.
1718
1719         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
1720         (TestWebKitAPI::TEST):
1721
1722 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
1723
1724         Fix iOS DRT build.
1725
1726         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1727         (WTR::UIScriptController::zoomToScale):
1728
1729 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
1730
1731         [iOS DRT] Hook up uiController.zoomToScale() for DRT
1732         https://bugs.webkit.org/show_bug.cgi?id=161173
1733
1734         Reviewed by Tim Horton.
1735         
1736         Make a UIWebScrollView subclass, DumpRenderTreeWebScrollView, which has an internal delegate to get
1737         UIScrollView delegate callbacks. Store the zoomToScaleCompletionHandler on it.
1738         
1739         UIScriptController::zoomToScale() has to bounce the zoom to the main thread (no poking UIKit from
1740         the WebThread!), but queue up the callback first.
1741
1742         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
1743         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
1744         (-[DumpRenderTreeWebScrollView initWithFrame:]):
1745         (-[DumpRenderTreeWebScrollView dealloc]):
1746         (-[DumpRenderTreeWebScrollView zoomToScale:animated:completionHandler:]):
1747         (-[DumpRenderTreeWebScrollView completedZoomToScale]):
1748         (-[DumpRenderTreeWebScrollViewDelegate initWithScrollView:]):
1749         (-[DumpRenderTreeWebScrollViewDelegate viewForZoomingInScrollView:]): All UIScrollView delegates need to implement this.
1750         (-[DumpRenderTreeWebScrollViewDelegate scrollViewDidEndZooming:withView:atScale:]):
1751         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1752         (WTR::UIScriptController::zoomToScale):
1753         * DumpRenderTree/mac/DumpRenderTree.mm:
1754         (createWebViewAndOffscreenWindow):
1755         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1756         (WTR::UIScriptController::context):
1757
1758 2016-08-24  Ryan Haddad  <ryanhaddad@apple.com>
1759
1760         Attempt to fix Windows build after r204918.
1761
1762         Unreviewed build fix.
1763
1764         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1765         (ResourceLoadDelegate::willSendRequest):
1766
1767 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
1768
1769         [iOS DRT] Get basic viewport tests working in DRT
1770         https://bugs.webkit.org/show_bug.cgi?id=161160
1771
1772         Reviewed by Tim Horton.
1773         
1774         Hook up enough of UIScriptController in iOS DRT to be able to read viewport
1775         scale, and get the contentVisibleRect.
1776         
1777         Requires exposing a bit of UIWebBrowserView SPI from UIKit, which in turn
1778         requires typing the gWebBrowserView as a DumpRenderTreeBrowserView * everywhere.
1779         
1780         One test has different results between DRT and WTR, but DRT behavior seems to differ
1781         from UIWebView here, so just give it a WK1-specific result.
1782
1783         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
1784         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
1785         (-[DumpRenderTreeBrowserView documentVisibleRect]):
1786         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1787         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1788         (WTR::UIScriptController::zoomScale):
1789         (WTR::UIScriptController::minimumZoomScale):
1790         (WTR::UIScriptController::maximumZoomScale):
1791         (WTR::UIScriptController::contentVisibleRect):
1792         * DumpRenderTree/mac/DumpRenderTree.mm:
1793         (createWebViewAndOffscreenWindow):
1794         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1795
1796 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
1797
1798         Minor project rearrangement.
1799
1800         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1801
1802 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
1803
1804         [iOS DRT] Make iOS DRT use the same window size as WebKitTestRunner for flexible viewport tests
1805         https://bugs.webkit.org/show_bug.cgi?id=161124
1806
1807         Reviewed by Daniel Bates.
1808         
1809         Use the main UIScreen's bounds for the size of the window in flexible viewport mode,
1810         and remove the 'phoneBrowserAddressBarOffset' hack, so that it matches WTR.
1811         
1812         Remove some unnecessary zero initializations of static variables.
1813         
1814         Change _setVisibleSize to use the window size, which should not be a behavior change
1815         because this it just used for text autosizing, which is disabled by default,
1816         and only the width is consulted.
1817
1818         * DumpRenderTree/mac/DumpRenderTree.mm:
1819         (adjustWebDocumentForFlexibleViewport):
1820         (adjustWebDocumentForStandardViewport):
1821         (createWebViewAndOffscreenWindow):
1822
1823 2016-08-24  Jonathan Bedard  <jbedard@apple.com>
1824
1825         WebKit2 needs layoutTestController.setDeferMainResourceDataLoad
1826         https://bugs.webkit.org/show_bug.cgi?id=42777
1827
1828         Reviewed by Darin Adler.
1829
1830         The setDeferMainResourceDataLoad method was not correctly tested in DumpRenderTree and would pass even when setDeterMainResourceDataLoad was not called.  Removed function and test.
1831
1832         * DumpRenderTree/TestRunner.cpp:
1833         (setDeferMainResourceDataLoadCallback): Removed setDeferMainResourceDataLoad.
1834         * DumpRenderTree/TestRunner.h:
1835         (TestRunner::deferMainResourceDataLoad): Ditto.
1836         (TestRunner::setDeferMainResourceDataLoad): Ditto.
1837         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Ditto.
1838
1839 2016-08-23  Anders Carlsson  <andersca@apple.com>
1840
1841         Add enum traits and use them in the IPC::Decoder
1842         https://bugs.webkit.org/show_bug.cgi?id=161103
1843
1844         Reviewed by Sam Weinig.
1845
1846         Add API test.
1847
1848         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1849         * TestWebKitAPI/Tests/WTF/EnumTraits.cpp: Added.
1850         (TestWebKitAPI::TEST):
1851
1852 2016-08-24  Filip Pizlo  <fpizlo@apple.com>
1853
1854         Unreviewed, roll out r204901, r204897, r204866, r204856, r204854.
1855
1856         * DumpRenderTree/TestRunner.cpp:
1857         * DumpRenderTree/mac/DumpRenderTree.mm:
1858         (DumpRenderTreeMain):
1859         * Scripts/run-jsc-stress-tests:
1860         * TestWebKitAPI/Tests/WTF/Vector.cpp:
1861         (TestWebKitAPI::TEST):
1862
1863 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
1864
1865         Try to fix Production builds.
1866         
1867         PRODUCTION_FRAMEWORKS_DIR was undefined here.
1868
1869         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1870
1871 2016-08-24  Dan Bernstein  <mitz@apple.com>
1872
1873         Add a convenience function for creating a WKFrameHandleRef from a WKFrameRef without going through WKFrameInfoRef
1874         https://bugs.webkit.org/show_bug.cgi?id=161152
1875
1876         Reviewed by Anders Carlsson.
1877
1878         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1879         * TestWebKitAPI/Tests/WebKit2/FrameHandle.cpp: Added.
1880         (TestWebKitAPI::didFinishLoadForFrame):
1881         (TestWebKitAPI::TEST):
1882
1883 2016-08-24  Nan Wang  <n_wang@apple.com>
1884
1885         AX: Add test for line text marker range on iOS
1886         https://bugs.webkit.org/show_bug.cgi?id=161108
1887         <rdar://problem/27976405>
1888
1889         Reviewed by Chris Fleizach.
1890
1891         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1892         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1893         (AccessibilityUIElement::textMarkerRangeForElement):
1894         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1895         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1896         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
1897
1898 2016-08-24  Per Arne Vollan  <pvollan@apple.com>
1899
1900         [Win] Warning fixes.
1901         https://bugs.webkit.org/show_bug.cgi?id=161079
1902
1903         Reviewed by Brent Fulgham.
1904
1905         * MiniBrowser/win/WebDownloadDelegate.cpp:
1906         * MiniBrowser/win/WinMain.cpp:
1907         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1908         (TestWebKitAPI::TEST):
1909
1910 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
1911
1912         Fix Windows DRT build.
1913
1914         * DumpRenderTree/win/TestRunnerWin.cpp:
1915         (TestRunner::mainFrameJSContext):
1916
1917 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
1918
1919         Try to fix Windows build.
1920         
1921         Pass Tools/DumpRenderTree/Bindings as the working directory for the generate_bindings.pl
1922         so that perl finds CodeGeneratorDumpRenderTree.pm.
1923
1924         * DumpRenderTree/CMakeLists.txt:
1925
1926 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
1927
1928         Hook up UIScriptController in DumpRenderTree
1929         https://bugs.webkit.org/show_bug.cgi?id=161064
1930
1931         Reviewed by Sam Weinig.
1932
1933         Add a skeleton implementation of UIScriptController to DumpRenderTree, building for both
1934         Mac and iOS. Currently this is sufficient to test doAsyncTask(), enabling two tests
1935         in fast/harness which test this.
1936
1937         Add a DerivedSources target to DumpRenderTree to invoke DerivedSources.make.
1938
1939         Move related code shared between WTR and DRT into Tools/TestRunnerShared, and cleanse it of
1940         WK2-isms. Fix the makefiles to refer to the new location.
1941
1942         Hook up TestRunner::runUIScript() for DumpRenderTree, which requires keeping track of callbacks
1943         by ID and firing them once they are complete.
1944
1945         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm: Added (copied from WTR).
1946         * DumpRenderTree/CMakeLists.txt:
1947         * DumpRenderTree/DerivedSources.make: Copied from Tools/WebKitTestRunner/DerivedSources.make.
1948         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1949         * DumpRenderTree/TestRunner.cpp:
1950         (runUIScriptCallback):
1951         (TestRunner::staticFunctions):
1952         (TestRunner::cacheTestRunnerCallback):
1953         (TestRunner::callTestRunnerCallback):
1954         (TestRunner::clearTestRunnerCallbacks):
1955         (nextUIScriptCallbackID):
1956         (TestRunner::runUIScript):
1957         (TestRunner::callUIScriptCallback):
1958         (TestRunner::uiScriptDidComplete):
1959         (TestRunner::cleanup):
1960         * DumpRenderTree/TestRunner.h:
1961         * DumpRenderTree/ios/UIScriptControllerIOS.mm: Added.
1962         * DumpRenderTree/mac/Configurations/Base.xcconfig: DerivedSources.make needs WEBCORE_PRIVATE_HEADERS_DIR to be defined.
1963         * DumpRenderTree/mac/DumpRenderTree.mm:
1964         (runTest):
1965         * DumpRenderTree/mac/TestRunnerMac.mm:
1966         (TestRunner::mainFrameJSContext):
1967         * DumpRenderTree/mac/UIScriptControllerMac.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h.
1968         (WTR::UIScriptController::doAsyncTask):
1969         * DumpRenderTree/win/DumpRenderTree.cpp:
1970         * TestRunnerShared/Bindings/JSWrappable.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h.
1971         (WTR::JSWrappable::~JSWrappable):
1972         (WTR::JSValueMakeStringOrNull):
1973         * TestRunnerShared/Bindings/JSWrapper.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp.
1974         (WTR::JSWrapper::wrap):
1975         (WTR::JSWrapper::unwrap):
1976         (WTR::unwrapObject):
1977         (WTR::JSWrapper::initialize):
1978         (WTR::JSWrapper::finalize):
1979         * TestRunnerShared/Bindings/JSWrapper.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h.
1980         (WTR::toJS):
1981         (WTR::setProperty):
1982         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: Renamed from Tools/WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl.
1983         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptContext.cpp.
1984         * TestRunnerShared/UIScriptContext/UIScriptContext.h: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptContext.h.
1985         (WTR::UIScriptContext::currentParentCallbackIsPendingCompletion):
1986         * TestRunnerShared/UIScriptContext/UIScriptController.cpp: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptController.cpp.
1987         * TestRunnerShared/UIScriptContext/UIScriptController.h: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptController.h.
1988         * WebKitTestRunner/CMakeLists.txt:
1989         * WebKitTestRunner/DerivedSources.make:
1990         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
1991         (WTR::JSWrappable::~JSWrappable): Deleted.
1992         (WTR::JSValueMakeStringOrNull): Deleted.
1993         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
1994         (WTR::JSWrapper::wrap): Deleted.
1995         (WTR::JSWrapper::unwrap): Deleted.
1996         (WTR::unwrapObject): Deleted.
1997         (WTR::JSWrapper::initialize): Deleted.
1998         (WTR::JSWrapper::finalize): Deleted.
1999         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:
2000         (WTR::toJS): Deleted.
2001         (WTR::setProperty): Deleted.
2002         * WebKitTestRunner/TestInvocation.cpp:
2003         (WTR::TestInvocation::runUISideScript):
2004         (WTR::TestInvocation::uiScriptDidComplete):
2005         * WebKitTestRunner/TestInvocation.h:
2006         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp: Moved
2007         * WebKitTestRunner/UIScriptContext/UIScriptContext.h: Moved
2008         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp: Moved
2009         * WebKitTestRunner/UIScriptContext/UIScriptController.h: Moved
2010         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2011         * WebKitTestRunner/config.h:
2012         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2013         (WTR::UIScriptController::contentVisibleRect):
2014
2015 2016-08-23  Saam Barati  <sbarati@apple.com>
2016
2017         JSC should have a "microbenchmarks" directory instead of "regress" directory
2018         https://bugs.webkit.org/show_bug.cgi?id=161096
2019
2020         Rubber stamped by Mark Lam.
2021
2022         This patch moves LayoutTests/js/regress/script-tests to the JSTests/microbenchmarks
2023         directory and removes all the related html and txt files. I did this because
2024         that directory was only there for microbenchmarks, and not for "regression"
2025         tests. I also changed the various scripts to point to it.
2026
2027         * Scripts/run-javascriptcore-tests:
2028         (runJSCStressTests):
2029         * Scripts/run-jsc-benchmarks:
2030
2031 2016-08-23  Alex Christensen  <achristensen@webkit.org>
2032
2033         Fix EFL build.
2034
2035         * TestWebKitAPI/CMakeLists.txt:
2036         Include new directory.
2037
2038 2016-08-22  Filip Pizlo  <fpizlo@apple.com>
2039
2040         Butterflies should be allocated in Auxiliary MarkedSpace instead of CopiedSpace and we should rewrite as much of the GC as needed to make this not a regression
2041         https://bugs.webkit.org/show_bug.cgi?id=160125
2042
2043         Reviewed by Geoffrey Garen.
2044
2045         * DumpRenderTree/TestRunner.cpp: Rewire some #includes.
2046         * Scripts/run-jsc-stress-tests: New test flag!
2047
2048 2016-08-23  Brady Eidson  <beidson@apple.com>
2049
2050         WK2 Gamepad layout test support.
2051         https://bugs.webkit.org/show_bug.cgi?id=134671
2052
2053         Reviewed by Alex Christensen.
2054         
2055         Have the injected bundle expose the MockGamepadProvider to the UI process, which will then 
2056         feed back into the UIGamepadProvider.
2057         
2058         Also, fool NSApplication into treating the most recently created "isKeyWindow" of the test windows
2059         as the actual keyWindow for the test runner, which will allow the view to get gamepad updates.
2060
2061         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2062         
2063         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2064         (WTR::TestRunner::setMockGamepadDetails):
2065         (WTR::TestRunner::setMockGamepadAxisValue):
2066         (WTR::TestRunner::setMockGamepadButtonValue):
2067         
2068         * WebKitTestRunner/PlatformWebView.h:
2069         
2070         * WebKitTestRunner/TestController.cpp:
2071         (WTR::TestController::initialize):
2072         
2073         * WebKitTestRunner/TestInvocation.cpp:
2074         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2075         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Deleted.
2076         
2077         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2078         
2079         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2080         (-[WebKitTestRunnerWindow initWithFrame:]):
2081         (-[WebKitTestRunnerWindow dealloc]):
2082         (WTR::PlatformWebView::keyWindow):
2083         
2084         * WebKitTestRunner/ios/TestControllerIOS.mm:
2085         (WTR::wtr_NSApplication_keyWindow):
2086         (WTR::TestController::platformInitialize):
2087         
2088         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2089         (+[WebKitTestRunnerWindow _WTR_keyWindow]):
2090         (-[WebKitTestRunnerWindow initWithContentRect:styleMask:backing:defer:]):
2091         (-[WebKitTestRunnerWindow dealloc]):
2092         (WTR::PlatformWebView::keyWindow):
2093         
2094         * WebKitTestRunner/mac/TestControllerMac.mm:
2095         (WTR::wtr_NSApplication_keyWindow):
2096         (WTR::TestController::platformInitialize):
2097         * WebKitTestRunner/mac/main.mm:
2098
2099 2016-08-23  Alexey Proskuryakov  <ap@apple.com>
2100
2101         REGRESSION (PHP 5.6): http/tests/misc/bad-charset-alias.html fails
2102         https://bugs.webkit.org/show_bug.cgi?id=161047
2103         rdar://problem/27434307
2104
2105         Reviewed by Lucas Forschler.
2106
2107         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: Specify a php.ini file.
2108
2109 2016-08-23  Chris Dumez  <cdumez@apple.com>
2110
2111         Unreviewed, rolling out r204243.
2112
2113         Caused some layout test failures
2114
2115         Reverted changeset:
2116
2117         "Write API test to cover crash fix in r204135"
2118         https://bugs.webkit.org/show_bug.cgi?id=160587
2119         http://trac.webkit.org/changeset/204243
2120
2121 2016-08-23  Rawinder Singh  <rawinder.singh-webkit@cisra.canon.com.au>
2122
2123         Order feature option list in FeatureList.pm
2124         https://bugs.webkit.org/show_bug.cgi?id=161074
2125
2126         Reviewed by Michael Catanzaro.
2127
2128         Reorder features in alphabetical order based on command line option. Also, sort variables in alphabetical order.
2129
2130         * Scripts/webkitperl/FeatureList.pm:
2131
2132 2016-08-22  Dewei Zhu  <dewei_zhu@apple.com>
2133
2134         Stop python icon bouncing in the dock while running browser benchmarks.
2135         https://bugs.webkit.org/show_bug.cgi?id=161066
2136
2137         Reviewed by Ryosuke Niwa.
2138
2139         Bouncing python icon may impact browser benchmark results.
2140         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2141         (OSXBrowserDriver.prepare_env):
2142         (OSXBrowserDriver.restore_env):
2143
2144 2016-08-22  Simon Fraser  <simon.fraser@apple.com>
2145
2146         <select> menu on iPad causes shifting of hit-testing areas
2147         https://bugs.webkit.org/show_bug.cgi?id=150079
2148
2149         Reviewed by Tim Horton.
2150
2151         -isAssistingNode (aka the poorly named isEditable) is input into WebPageProxy::computeCustomFixedPositionRect(),
2152         so when it changes we have to update visible rects. We were doing this on focus, but failing
2153         to do it on blur.
2154
2155         Added the ability to test by:
2156         1. Making it possible to initiate an animated scroll in the UI process
2157         2. Adding callbacks for starting and ending interaction with a form control. Sadly
2158         the "ending interaction" for <select> popovers on iPad isn't late enough, since we
2159         have no way currently to know when the dimming view behind the popover animates out,
2160         so for now the test keeps trying to tap a button.
2161
2162         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
2163         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
2164         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
2165         (WTR::UIScriptController::setDidStartFormControlInteractionCallback):
2166         (WTR::UIScriptController::didStartFormControlInteractionCallback):
2167         (WTR::UIScriptController::setDidEndFormControlInteractionCallback):
2168         (WTR::UIScriptController::didEndFormControlInteractionCallback):
2169         (WTR::UIScriptController::scrollToOffset):
2170         (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
2171         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
2172         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
2173         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2174         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2175         (-[TestRunnerWKWebView dealloc]):
2176         (-[TestRunnerWKWebView didStartFormControlInteraction]):
2177         (-[TestRunnerWKWebView didEndFormControlInteraction]):
2178         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2179         (WTR::contentOffsetBoundedInValidRange):
2180         (WTR::UIScriptController::scrollToOffset):
2181         (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
2182         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
2183
2184 2016-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2185
2186         [EFL][GTK] Script process-linux-coredump is not needed, switch back to use the kernel core dumper instead.
2187         https://bugs.webkit.org/show_bug.cgi?id=160927
2188
2189         Reviewed by Daniel Bates.
2190
2191         * Scripts/process-linux-coredump: Removed.
2192         * Scripts/webkitpy/port/efl.py:
2193         (EflPort._get_crash_log):
2194         * Scripts/webkitpy/port/gtk.py:
2195         (GtkPort._get_crash_log):
2196         * Scripts/webkitpy/port/linux_get_crash_log.py:
2197         (GDBCrashLogGenerator.__init__):
2198         (GDBCrashLogGenerator.generate_crash_log):
2199         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2200         (GDBCrashLogGeneratorTest.test_generate_crash_log):
2201
2202 2016-08-22  Jonathan Bedard  <jbedard@apple.com>
2203
2204         check-webkit-style does not work with Lambda functions in C++
2205         https://bugs.webkit.org/show_bug.cgi?id=160910
2206
2207         Reviewed by Darin Adler.
2208
2209         This change eliminates false positives on correctly styled lambda functions and includes a few basic checks on capture list.
2210
2211         * Scripts/webkitpy/style/checkers/cpp.py:
2212         (regex_for_lambda_functions): Added function which checks if a string is the start of a lambda function.
2213         (check_for_non_standard_constructs): Added lambda function check.
2214         (check_spacing_for_function_call): Added lambda function check.
2215         (check_braces): Added lambda function check.
2216         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2217         (CppStyleTest.test_lambda_functions): Added test function for lambda function style checks.
2218
2219 2016-08-21  Alex Christensen  <achristensen@webkit.org>
2220
2221         URLParser should parse IPv4 addresses
2222         https://bugs.webkit.org/show_bug.cgi?id=161023
2223
2224         Reviewed by Darin Adler.
2225
2226         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2227         (TestWebKitAPI::TEST_F):
2228         (TestWebKitAPI::checkURLDifferences):
2229         We are already getting differences between the old URL::parse and the new URLParser.
2230         (TestWebKitAPI::shouldFail):
2231
2232 2016-08-21  Daniel Bates  <dabates@apple.com>
2233
2234         prepare-ChangeLog lists unmodified functions as modified and marks functions with few changes as deleted
2235         https://bugs.webkit.org/show_bug.cgi?id=148437
2236
2237         Reviewed by Dan Bernstein.
2238
2239         * Scripts/prepare-ChangeLog:
2240         (diffCommand): When using a Subversion checkout, generate a unified diff without any context lines.
2241         This matches our behavior when using a Git checkout. The function overlap logic in generateFunctionListsByRanges()
2242         assumes that its line ranges were from a unified diff without any context lines.
2243         (extractLineRangeAfterChange): A deleted line should be represented with a ("begin line number", "end line number") = ("new starting line number", "new starting line number").
2244         (extractLineRangeBeforeChange): An added line should be represented with a ("begin line number", "end line number") = ("original starting line number", "original starting line number").
2245         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Update expected results
2246         based on changes to extractLineRangeAfterChange() and extractLineRangeBeforeChange().
2247         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl: Added.
2248         (discardOutput): Convenience function invokes the specified function redirecting standard output and standard error
2249         to /dev/null for the duration of the function call.
2250
2251 2016-08-20  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
2252
2253         [EFL] Remove unnecessary a patch to mute ecore warnings
2254         https://bugs.webkit.org/show_bug.cgi?id=160997
2255
2256         Reviewed by Darin Adler.
2257
2258         There is no warning messages during the layout test and perf test
2259         after bumping efl version from 1.17 to 1.18. Remove it.
2260
2261         * efl/patches/ecore_remove_warnings.patch: Removed.
2262
2263 2016-08-20  Simon Fraser  <simon.fraser@apple.com>
2264
2265         REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
2266         https://bugs.webkit.org/show_bug.cgi?id=160985
2267
2268         Re-land r204672, but don't check the result of 'xcrun simctl shutdown', because
2269         device shutdown seems to happen as result of killing Simulator.apps, and we're racing
2270         with that.
2271
2272         * Scripts/webkitpy/layout_tests/views/printing.py:
2273         (Printer.print_config):
2274         * Scripts/webkitpy/port/base.py:
2275         (Port.driver_cmd_line_for_logging):
2276         (Port.driver_cmd_line): Deleted.
2277         * Scripts/webkitpy/port/driver.py:
2278         (IOSSimulatorDriver.cmd_line):
2279         * Scripts/webkitpy/port/ios.py:
2280         (IOSSimulatorPort.__init__):
2281         (IOSSimulatorPort.driver_cmd_line_for_logging):
2282         (IOSSimulatorPort._create_simulators):
2283         (IOSSimulatorPort.setup_test_run):
2284         (IOSSimulatorPort._quit_ios_simulator):
2285         (IOSSimulatorPort.clean_up_test_run):
2286         (IOSSimulatorPort._create_device):
2287         (IOSSimulatorPort):
2288         (IOSSimulatorPort._remove_device):
2289         (IOSSimulatorPort._testing_device):
2290         (IOSSimulatorPort.device_id_for_worker_number):
2291         (IOSSimulatorPort._set_device_class): Deleted.
2292         (IOSSimulatorPort.testing_device): Deleted.
2293         * Scripts/webkitpy/port/port_testcase.py:
2294         (PortTestCase.test_driver_cmd_line):
2295         * Scripts/webkitpy/xcode/simulator.py:
2296         (Device.shutdown):
2297         (Device):
2298         (Device.delete):
2299         (Device.reset):
2300         (Simulator):
2301         (Simulator.create_device):
2302         (Simulator.remove_device):
2303         (Simulator.device_number):
2304         (Simulator.device_state_description):
2305         (Simulator.wait_until_device_is_in_state):
2306
2307 2016-08-19  Ryan Haddad  <ryanhaddad@apple.com>
2308
2309         Unreviewed, rolling out r204659.
2310
2311         This change appears to have caused ios-simulator LayoutTests
2312         to fail when shutting down the simulator
2313
2314         Reverted changeset:
2315
2316         "REGRESSION (r204477): Running LayoutTests on ios-simulator
2317         became ~15 minutes slower"
2318         https://bugs.webkit.org/show_bug.cgi?id=160985
2319         http://trac.webkit.org/changeset/204659
2320
2321 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
2322
2323         Build fix for non-USE_SIM_SERVICE_CONTEXT builds
2324         * LayoutTestRelay/LayoutTestRelay/main.m: (main):
2325
2326 2016-08-18  Simon Fraser  <simon.fraser@apple.com>
2327
2328         REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
2329         https://bugs.webkit.org/show_bug.cgi?id=160985
2330
2331         Reviewed by Alexey Proskuryakov.
2332         
2333         r204477 removed @memoized on a couple of ios.py functions, causing them to instantiate
2334         a Simulator() on every call, which causes 'xcrun simctl list' to run. The functions
2335         must not be @memoized, because their return value depends on the value of simulator_device_type().
2336         
2337         Fix by adding some global state in simulator.py that tracks the created devices 
2338         in a worker number -> Device dictionary. Explicitly create devices in _create_simulators(),
2339         and delete them in clean_up_test_run().
2340         
2341         Also explicitly called 'xcrun simctl shutdown' to shut down devices, since it seems
2342         that killing the Simulator apps isn't enough.
2343         
2344         Simulator tracks the devices in a global dictionary, since state needs to persist
2345         across different instances of IOSSimulatorPort.
2346         
2347         Annoyingly, the "Command line:" dumping tried to access a device before we'd done
2348         any setup. Rather than implicitly creating a device here (which the old code did),
2349         override the more clearly named driver_cmd_line_for_logging() in IOSSimulatorPort
2350         and set flag to say that device_id_for_worker_number() doesn't need to return a real
2351         device id.
2352
2353         * Scripts/webkitpy/layout_tests/views/printing.py:
2354         (print_options):
2355         (Printer.print_config):
2356         * Scripts/webkitpy/port/base.py:
2357         (Port.driver_cmd_line_for_logging):
2358         (Port.driver_cmd_line): Deleted.
2359         * Scripts/webkitpy/port/driver.py:
2360         (IOSSimulatorDriver.cmd_line):
2361         * Scripts/webkitpy/port/ios.py:
2362         (IOSSimulatorPort.__init__):
2363         (IOSSimulatorPort.driver_cmd_line_for_logging):
2364         (IOSSimulatorPort._create_simulators):
2365         (IOSSimulatorPort.setup_test_run):
2366         (IOSSimulatorPort.clean_up_test_run):
2367         (IOSSimulatorPort._create_device):
2368         (IOSSimulatorPort):
2369         (IOSSimulatorPort._remove_device):
2370         (IOSSimulatorPort._testing_device):
2371         (IOSSimulatorPort.device_id_for_worker_number):
2372         (IOSSimulatorPort._set_device_class): Deleted.
2373         (IOSSimulatorPort.testing_device): Deleted.
2374         * Scripts/webkitpy/port/port_testcase.py:
2375         (PortTestCase.test_driver_cmd_line):
2376         * Scripts/webkitpy/xcode/simulator.py:
2377         (Device.shutdown):
2378         (Device.delete):
2379         (Device.reset):
2380         (Simulator.create_device):
2381         (Simulator.remove_device):
2382         (Simulator.device_number):
2383         (Simulator.device_state_description):
2384         (Simulator.wait_until_device_is_in_state):
2385
2386 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
2387
2388         Adopt SimServiceContext in LayoutTestRelay
2389         https://bugs.webkit.org/show_bug.cgi?id=161000
2390         <rdar://problem/25765594>
2391
2392         Reviewed by Daniel Bates.
2393
2394         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
2395         * LayoutTestRelay/LayoutTestRelay/main.m:
2396
2397 2016-08-19  Lucas Forschler  <lforschler@apple.com>
2398
2399         Remove Yosemite Leaks bot after http://trac.webkit.org/projects/webkit/changeset/204629
2400
2401         Reviewed by Kocsen Chung.
2402
2403         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2404         (WebKitBuildbot):
2405
2406 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
2407
2408         Partial revert of r203811 - this key is not needed.
2409
2410         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: (-[LTRelayController installApp]):
2411
2412 2016-08-19  Daniel Bates  <dabates@apple.com>
2413
2414         Another attempt to fix the iOS 9.3 build
2415
2416         Define WK_EMPTY_, WK_NOT_, and WK_NOT_YES.
2417
2418         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2419         * WebKitTestRunner/Configurations/Base.xcconfig:
2420
2421 2016-08-19  Lucas Forschler  <lforschler@apple.com>
2422
2423         Remove Yosemite Leaks bot from config.json
2424         
2425         Reviewed by Alexey Proskuryakov.
2426
2427         * BuildSlaveSupport/build.webkit.org-config/config.json:
2428
2429 2016-08-18  Dan Bernstein  <mitz@apple.com>
2430
2431         [Cocoa] API::Number needs to be wrapped by an NSNumber
2432         https://bugs.webkit.org/show_bug.cgi?id=160977
2433         <rdar://problem/27877735>
2434
2435         Reviewed by Anders Carlsson.
2436
2437         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2438         * TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm: Added.
2439         (TestWebKitAPI::TEST):
2440
2441 2016-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
2442
2443         [Cocoa] Migrate off of deprecated CoreGraphics API CGContextSelectFont() and CGContextShowTextAtPoint()
2444         https://bugs.webkit.org/show_bug.cgi?id=160895
2445
2446         Reviewed by Dean Jackson.
2447
2448         Link to the existing CoreText framework.
2449
2450         * DumpRenderTree/PlatformWin.cmake:
2451         * TestWebKitAPI/PlatformWin.cmake:
2452
2453 2016-08-17  Brent Fulgham  <bfulgham@apple.com>
2454
2455         [Win] Remove old libraries from build inputs
2456         https://bugs.webkit.org/show_bug.cgi?id=160949
2457
2458         Reviewed by Dean Jackson.
2459
2460         Modify the download script to remove the old 'icuuc.lib' and
2461         'icuin.lib' files for Windows builds.
2462
2463         * Scripts/update-webkit-auxiliary-libs:
2464
2465 2016-08-17  Jonathan Bedard  <jbedard@apple.com>
2466
2467         Extra logging for crash reason
2468         https://bugs.webkit.org/show_bug.cgi?id=160943
2469
2470         Reviewed by Alexey Proskuryakov.
2471
2472         A number of tests have been erroneously marked as crashed, this should help diagnose these false crashes.
2473
2474         * Scripts/webkitpy/port/server_process.py:
2475         (ServerProcess.write): Add extra logging to determine why a process has been marked as crashed.
2476         (ServerProcess._wait_for_data_and_update_buffers_using_select): Ditto.
2477         (ServerProcess.has_crashed): Ditto.
2478
2479 2016-08-17  Dan Bernstein  <mitz@apple.com>
2480
2481         [Cocoa] -[NSString isEqualToString:] returns NO for any WKNSString argument
2482         https://bugs.webkit.org/show_bug.cgi?id=160938
2483         <rdar://problem/27876652>
2484
2485         Reviewed by Anders Carlsson.
2486
2487         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2488         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm: Added.
2489         (TestWebKitAPI::TEST):
2490
2491 2016-08-17  Chris Fleizach  <cfleizach@apple.com>
2492
2493         AX: Support abbreviations in iOS
2494         https://bugs.webkit.org/show_bug.cgi?id=160907
2495
2496         Reviewed by Joanmarie Diggs.
2497
2498         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2499         (AccessibilityUIElement::stringAttributeValue):
2500         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2501         (WTR::AccessibilityUIElement::stringAttributeValue):
2502
2503 2016-08-17  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
2504
2505         [EFL] Bump efl version from 1.17 to 1.18
2506         https://bugs.webkit.org/show_bug.cgi?id=160899
2507
2508         Reviewed by Antonio Gomes.
2509
2510         To use efl-1.18, EFL port needs to update install dependencies as well.
2511
2512         * efl/install-dependencies:
2513         * efl/jhbuild.modules:
2514
2515 2016-08-17  Per Arne Vollan  <pvollan@apple.com>
2516
2517         [Win] Add tests for linked fonts.
2518         https://bugs.webkit.org/show_bug.cgi?id=160898
2519
2520         Reviewed by Brent Fulgham.
2521
2522         Add tests for https://trac.webkit.org/changeset/204502.
2523
2524         * TestWebKitAPI/PlatformWin.cmake:
2525         * TestWebKitAPI/Tests/WebCore/win/LinkedFonts.cpp: Added.
2526         (TestWebKitAPI::TEST):
2527
2528 2016-08-16  Daniel Bates  <dabates@apple.com>
2529
2530         prepare-ChangeLog: Extract logic from generateFunctionLists() into a function that takes a delegate object
2531         https://bugs.webkit.org/show_bug.cgi?id=160924
2532
2533         Reviewed by Stephanie Lewis.
2534
2535         Towards adding unit tests for generateFunctionLists() we move its logic into actuallyGenerateFunctionLists()
2536         and have actuallyGenerateFunctionLists() take a delegate object to use to query the file system and SCM.
2537         We modify generateFunctionLists() to call actuallyGenerateFunctionLists(). This will make is possible to
2538         test the generate function list machinery without requiring a SCM checkout by substituting a delegate
2539         object that mocks out the file system and SCM operations.
2540
2541         * Scripts/VCSUtils.pm:
2542         (parseDiffStartLine): Parses an SVN or Git start line and returns the path to the target file.
2543         * Scripts/prepare-ChangeLog:
2544         (generateFunctionLists): Move functionality to actually generate the function lists to actuallyGenerateFunctionLists(),
2545         abstracting the logic to query the file system and SCM into functions on a delegate object that
2546         we pass to it.
2547         (actuallyGenerateFunctionLists): Extracted from generateFunctionLists().
2548         (diffHeaderFormat): Deleted.
2549
2550 2016-08-16  Alex Christensen  <achristensen@webkit.org>
2551
2552         URLParser should parse URLs without credentials
2553         https://bugs.webkit.org/show_bug.cgi?id=160913
2554
2555         Reviewed by Brady Eidson.
2556
2557         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2558         (TestWebKitAPI::s):
2559         (TestWebKitAPI::checkURL):
2560         (TestWebKitAPI::TEST_F):
2561
2562 2016-08-16  Anders Carlsson  <andersca@apple.com>
2563
2564         Add WTF::ScopeExit
2565         https://bugs.webkit.org/show_bug.cgi?id=160908
2566
2567         Reviewed by Geoffrey Garen.
2568
2569         * TestWebKitAPI/CMakeLists.txt:
2570         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2571         * TestWebKitAPI/Tests/WTF/Scope.cpp: Added.
2572         (TestWebKitAPI::TEST):
2573
2574 2016-08-16  Aakash Jain  <aakash_jain@apple.com>
2575
2576         EWS logs file are rotated too quickly
2577         https://bugs.webkit.org/show_bug.cgi?id=160724
2578
2579         Reviewed by Daniel Bates.
2580
2581         Currently we are rotating the log file after 10 iterations of queue. If the queue
2582         doesn't have any pending patches, these iterations result in very small amount of 
2583         logs (1 KB log file). Even if the queue process some patches, logs are few KBs.
2584         This results in a lot of log files in a day. This patch ensures that we rotate the
2585         log file when its file size is greater than or equal to 100 KB.
2586
2587         * EWSTools/start-queue-mac.sh: Added check for file size before rotating log file.
2588
2589 2016-08-16  Daniel Bates  <dabates@apple.com>
2590
2591         WKSI static library should be named by major iOS revision, not individual updates
2592         https://bugs.webkit.org/show_bug.cgi?id=160727
2593         <rdar://problem/22274848>
2594
2595         Reviewed by Alexey Proskuryakov.
2596
2597         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2598         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2599         * Scripts/copy-webkitlibraries-to-product-directory:
2600         * WebKitTestRunner/Configurations/Base.xcconfig:
2601         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2602
2603 2016-08-16  Simon Fraser  <simon.fraser@apple.com>
2604
2605         Make it possible to test iOS select elements, and add iPhone and iPad tests for them
2606         https://bugs.webkit.org/show_bug.cgi?id=160909
2607
2608         Reviewed by Enrica Casucci.
2609         
2610         Add functions to UIScriptController to dismiss the form accessory view for iOS,
2611         and to programmatically pick a row from a <select> picker.
2612
2613         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
2614         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
2615         (WTR::UIScriptController::dismissFormAccessoryView):
2616         (WTR::UIScriptController::selectFormAccessoryPickerRow):
2617         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
2618         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2619         (WTR::UIScriptController::dismissFormAccessoryView):
2620         (WTR::UIScriptController::selectFormAccessoryPickerRow):
2621
2622 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
2623
2624         [iOS] Add iPad viewport and form tests, and revert the iPad-testing part of r202132
2625         https://bugs.webkit.org/show_bug.cgi?id=160878
2626
2627         Reviewed by Tim Horton.
2628         
2629         Remove testing-specific "forceIPadStyleZoomOnInputFocus" behavior added in r202132
2630         now that we have the ability to run tests in the iPad simulator.
2631
2632         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
2633         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
2634         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
2635         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
2636         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
2637         * WebKitTestRunner/ios/TestControllerIOS.mm:
2638         (WTR::TestController::platformResetStateToConsistentValues): Deleted.
2639         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2640         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
2641         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
2642
2643 2016-08-15  Anders Carlsson  <andersca@apple.com>
2644
2645         Add an address-of operator to RetainPtr
2646         https://bugs.webkit.org/show_bug.cgi?id=160879
2647
2648         Reviewed by Tim Horton.
2649
2650         Test HashMap and HashSet with an object whose operator& is deleted.
2651
2652         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2653         Sort the Xcode project.
2654
2655         * TestWebKitAPI/Tests/WTF/DeletedAddressOfOperator.h: Added.
2656         (DeletedAddressOfOperator::DeletedAddressOfOperator):
2657         (DeletedAddressOfOperator::value):
2658         (DeletedAddressOfOperator::operator==):
2659         (WTF::HashTraits<DeletedAddressOfOperator>::constructDeletedValue):
2660         (WTF::HashTraits<DeletedAddressOfOperator>::isDeletedValue):
2661         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::hash):
2662         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::equal):
2663         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2664         (TestWebKitAPI::TEST):
2665         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2666         (TestWebKitAPI::TEST):
2667
2668 2016-08-16  Jonathan Bedard  <jbedard@apple.com>
2669
2670         False crashes in fast/text/emoji-gender-* tests
2671         https://bugs.webkit.org/show_bug.cgi?id=160779
2672
2673         Reviewed by Alexey Proskuryakov.
2674
2675         Fix from <rdar://problem/27786762>, where timed out tests falsely report as crashed.
2676
2677         * Scripts/webkitpy/port/driver.py:
2678         (Driver._check_for_driver_crash_or_unresponsiveness): Change call to ‘write’ to disable crash flag.
2679         * Scripts/webkitpy/port/driver_unittest.py: Added 3 variable to test version of ‘write.’
2680         * Scripts/webkitpy/port/server_process.py:
2681         (ServerProcess.write): Allow caller to disable crash flag on exception.
2682
2683 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
2684
2685         webkitpy error in TestRunResults.merge()
2686         https://bugs.webkit.org/show_bug.cgi?id=160882
2687
2688         Reviewed by Daniel Bates.
2689         
2690         The argument to TestRunResults.merge() can be None if there are no device-specifc
2691         initial results or retry results in Manager.run(), so just return early in that case.
2692
2693         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2694         (TestRunResults.merge):
2695
2696 2016-08-15  Sam Weinig  <sam@webkit.org>
2697
2698         Speed up compile times by not including wtf/Variant.h so much
2699         https://bugs.webkit.org/show_bug.cgi?id=160847
2700
2701         Reviewed by Alex Christensen and Saam Barati.
2702
2703         * TestWebKitAPI/Tests/WTF/Variant.cpp:
2704         (TestWebKitAPI::TEST):
2705         Explicitly use std::experimental::variant.
2706
2707 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
2708
2709         Allow a port to run tests with a custom device setup
2710         https://bugs.webkit.org/show_bug.cgi?id=160833
2711
2712         Reviewed by Daniel Bates.
2713
2714         These changes allow the IOSSimulator port to run tests in iPad mode.
2715
2716         This is made possible by allowing a platform to define CUSTOM_DEVICE_CLASSES,
2717         in this case 'ipad'. When specified, any test in a directory with a suffix that matches
2718         a custom device will be collected into a set, and run in that device's environment after
2719         the other tests have run.
2720
2721         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2722         (Manager._custom_device_for_test): If the test contains a directory matching a
2723         custom device suffix, return that custom device.
2724         (Manager._set_up_run): Push the custom device class, if any, into options so
2725         that the Worker can get to it.
2726         (Manager.run): Go through the list of tests, and break it down into device-generic
2727         tests, and tests for each device class. _run_test_subset is then called for
2728         each collection of tests, and the results merged.
2729         (Manager._run_test_subset): Some lines unwrapped.
2730         (Manager._end_test_run):
2731         (Manager._run_tests):
2732         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2733         (SingleTestRunner.__init__): Unwrapped a line.
2734         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2735         (TestRunResults.merge): Add this function to merge TestRunResults
2736         * Scripts/webkitpy/layout_tests/views/printing.py:
2737         (Printer.print_workers_and_shards): Print the custom device, if any.
2738         * Scripts/webkitpy/port/base.py:
2739         (Port): Base port has empty array of custom devices.
2740         (Port.setup_test_run): Add device_class argument.
2741         * Scripts/webkitpy/port/driver.py:
2742         (DriverInput.__repr__):
2743         (Driver.check_driver.implementation):
2744         * Scripts/webkitpy/port/efl.py:
2745         (EflPort.setup_test_run):
2746         * Scripts/webkitpy/port/gtk.py:
2747         (GtkPort.setup_test_run):
2748         * Scripts/webkitpy/port/ios.py:
2749         (IOSSimulatorPort): Add CUSTOM_DEVICE_CLASSES for ipad.
2750         (IOSSimulatorPort.__init__):
2751         (IOSSimulatorPort.simulator_device_type): Use a device name from the DEVICE_CLASS_MAP
2752         based on the custom device class.
2753         (IOSSimulatorPort._set_device_class):
2754         (IOSSimulatorPort._create_simulators): Factor some code into this function.
2755         (IOSSimulatorPort.setup_test_run):
2756         (IOSSimulatorPort.testing_device):
2757         (IOSSimulatorPort.reset_preferences): This used to create the simulator apps, but that
2758         seemed wrong for this function. That was moved to setup_test_run().
2759         (IOSSimulatorPort.check_sys_deps): This function used to create testing devices,
2760         but this happened too early, before we knew which kind of devices to create. Devices
2761         are now created in setup_test_run().
2762         * Scripts/webkitpy/port/win.py:
2763         (WinPort.setup_test_run):
2764
2765 2016-08-15  Daniel Bates  <dabates@apple.com>
2766
2767         Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
2768         private frameworks and libraries
2769         https://bugs.webkit.org/show_bug.cgi?id=155931
2770         <rdar://problem/25807989>
2771
2772         Reviewed by Dan Bernstein.
2773
2774         Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
2775         where X is the major version of the active iOS SDK.
2776
2777         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2778         * WebKitTestRunner/Configurations/Base.xcconfig:
2779
2780 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
2781
2782         Add a setting and preferences to enable visual viewport mode
2783         https://bugs.webkit.org/show_bug.cgi?id=160843
2784
2785         Reviewed by Sam Weinig.
2786         
2787         Pref and a menu item to toggle visualViewportEnabled for WebKits 1 and 2.
2788
2789         * MiniBrowser/mac/SettingsController.h:
2790         * MiniBrowser/mac/SettingsController.m:
2791         (-[SettingsController _populateMenu]):
2792         (-[SettingsController validateMenuItem:]):
2793         (-[SettingsController visualViewportEnabled]):
2794         (-[SettingsController toggleVisualViewportEnabled:]):
2795         * MiniBrowser/mac/WK1BrowserWindowController.m:
2796         (-[WK1BrowserWindowController didChangeSettings]):
2797         * MiniBrowser/mac/WK2BrowserWindowController.m:
2798         (-[WK2BrowserWindowController didChangeSettings]):
2799
2800 2016-08-15  Konstantin Tokarev  <annulen@yandex.ru>
2801
2802         Allow using make-dist with non-GTK ports
2803         https://bugs.webkit.org/show_bug.cgi?id=160842
2804
2805         Reviewed by Michael Catanzaro.
2806
2807         This patch adds support for setting base name of tarball and argument
2808         passed to cmake's -DPORT= via command line arguments.
2809
2810         * gtk/make-dist.py:
2811         (Distcheck.configure):
2812         (Distcheck.check):
2813         (get_tarball_root_and_output_filename_from_arguments):
2814
2815 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2816
2817         [GTK] Install script lacks gstreamer related dependencies
2818         https://bugs.webkit.org/show_bug.cgi?id=160814
2819
2820         Reviewed by Carlos Garcia Campos.
2821
2822         * gtk/install-dependencies: Fedora case had already listed this dependencies,
2823         but both Arch and Debian/Ubuntu were missing them.
2824
2825 2016-08-13  Konstantin Tokarev  <annulen@yandex.ru>
2826
2827         make-dist.py should not allow unknown rules in manifest
2828         https://bugs.webkit.org/show_bug.cgi?id=160841
2829
2830         Reviewed by Carlos Garcia Campos.
2831
2832         * gtk/make-dist.py:
2833         (Manifest.process_line):
2834
2835 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2836
2837         [EFL][GTK] Install script not working on Debian 9 (testing) and Ubuntu 16.10
2838         https://bugs.webkit.org/show_bug.cgi?id=160809
2839
2840         Reviewed by Carlos Garcia Campos.
2841
2842         * efl/install-dependencies: Factorize the previous logic for handling the php5/7
2843         case, and use it also for the new package names of libpng and libgeoclue.
2844         * gtk/install-dependencies: Ditto.
2845
2846 2016-08-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2847
2848         Skip to check directories existence in build-webkit
2849         https://bugs.webkit.org/show_bug.cgi?id=160691
2850
2851         Reviewed by Alex Christensen.
2852
2853         CMake checks if directories are there itself. So CMake ports
2854         don't need to check it in the build-webkit script.
2855
2856         * Scripts/build-webkit:
2857         * Scripts/webkitdirs.pm:
2858         (determineSourceDir):
2859         (isCMakeBuild):
2860
2861 2016-08-12  Alex Christensen  <achristensen@webkit.org>
2862
2863         Make URLParser work with URLs missing URL parts
2864         https://bugs.webkit.org/show_bug.cgi?id=160824
2865
2866         Reviewed by Brady Eidson.
2867
2868         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2869         (TestWebKitAPI::s):
2870         (TestWebKitAPI::checkURL):
2871         (TestWebKitAPI::TEST_F):
2872         (TestWebKitAPI::eq): Deleted.
2873
2874 2016-08-12  John Wilander  <wilander@apple.com>
2875
2876         Add HashCountedSet API tests to TestWTFLibrary target
2877         https://bugs.webkit.org/show_bug.cgi?id=160815
2878
2879         Reviewed by Alex Christensen.
2880
2881         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2882             Added HashCountedSet.cpp and sorted the file reference section
2883             according to UNIX sort.
2884
2885 2016-08-12  Ryosuke Niwa  <rniwa@webkit.org>
2886
2887         run-benchmark should run JetStream 1.1 instead of 1.0.1
2888         https://bugs.webkit.org/show_bug.cgi?id=160816
2889
2890         Reviewed by Filip Pizlo.
2891
2892         Use the latest JetStream 1.1 in run-benchmark.
2893
2894         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
2895         (BenchmarkBuilder.__exit__):
2896         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Updated to apply against 1.1 directory.
2897         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Updated to use r190897, which is the last
2898         change to JetStream directory.
2899
2900 2016-08-12  Alex Christensen  <achristensen@webkit.org>
2901
2902         Initial URLParser implementation
2903         https://bugs.webkit.org/show_bug.cgi?id=160811
2904
2905         Reviewed by Brady Eidson.
2906
2907         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2908         (TestWebKitAPI::eq):
2909         (TestWebKitAPI::checkURL):
2910         (TestWebKitAPI::TEST_F):
2911
2912 2016-08-12  Brady Eidson  <beidson@apple.com>
2913
2914         Fix the 32-bit Mac build after:
2915         Add WK2 ExperimentalFeature support to MiniBrowser
2916         https://bugs.webkit.org/show_bug.cgi?id=160788
2917
2918         Unreviewed.
2919
2920         Sprinkle "#if WK_API_ENABLED"s liberally.
2921         
2922         * MiniBrowser/mac/AppDelegate.m:
2923         (defaultConfiguration):
2924         * MiniBrowser/mac/SettingsController.m:
2925         (-[SettingsController _populateMenu]):
2926         (-[SettingsController validateMenuItem:]):
2927
2928 2016-08-12  Philippe Normand  <pnormand@igalia.com>
2929
2930         [GStreamer][OWR] Video rendering fixes
2931         https://bugs.webkit.org/show_bug.cgi?id=160764
2932
2933         Reviewed by Xabier Rodriguez-Calvar.
2934
2935         * gtk/jhbuild.modules: Bump to current OpenWebRTC master.
2936
2937 2016-08-12  Per Arne Vollan  <pvollan@apple.com>
2938
2939         Add missing return statement in convertFast function added in r204376.
2940
2941         Unreviewed.
2942
2943         * Scripts/webkitpy/common/system/path.py:
2944         (_CygPath.convertFast):
2945
2946 2016-08-11  Brady Eidson  <beidson@apple.com>
2947
2948         Add WK2 ExperimentalFeature support to MiniBrowser.
2949         https://bugs.webkit.org/show_bug.cgi?id=160788
2950
2951         Reviewed by Alex Christensen.
2952
2953         * MiniBrowser/mac/AppDelegate.h:
2954         * MiniBrowser/mac/AppDelegate.m:
2955         (defaultConfiguration):
2956         (defaultPreferences):
2957         
2958         * MiniBrowser/mac/SettingsController.m:
2959         (-[SettingsController _populateMenu]):
2960         (-[SettingsController validateMenuItem:]):
2961         (-[SettingsController toggleExperimentalFeature:]):
2962
2963 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
2964
2965         Keep EWS logs for longer
2966         https://bugs.webkit.org/show_bug.cgi?id=160776
2967
2968         Reviewed by Daniel Bates.
2969
2970         * EWSTools/start-queue-mac.sh: Keep logs for 30 days instead of 14 days.
2971
2972 2016-08-11  Simon Fraser  <simon.fraser@apple.com>
2973
2974         iOS DRT/WTR project cleanup
2975         https://bugs.webkit.org/show_bug.cgi?id=160778
2976
2977         Reviewed by Tim Horton.
2978
2979         Move TARGETED_DEVICE_FAMILY from the project to an xcconfig file.
2980
2981         Remove AppDelegate.* which were unused.
2982
2983         Exclude ios/Launch.storyboard on more platforms.
2984
2985         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2986         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
2987         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2988         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2989         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Removed.
2990         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Removed.
2991         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Deleted.
2992
2993 2016-08-11  Alex Christensen  <achristensen@webkit.org>
2994
2995         Fix Yosemite bots' cookie accept policies after r204365.
2996         https://bugs.webkit.org/show_bug.cgi?id=160758
2997
2998         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
2999         (TEST):
3000         This makes the test fully clean up after itself.
3001
3002 2016-08-11  Alex Christensen  <achristensen@webkit.org>
3003
3004         Fix Yosemite bots' cookie accept policies after r204365.
3005         https://bugs.webkit.org/show_bug.cgi?id=160758
3006
3007         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
3008         (TEST):
3009         I didn't restore the cookieAcceptPolicy of the sharedHTTPCookieStorage after changing it with this API test.
3010         On Yosemite, this is changing the cookieAcceptPolicy that DumpRenderTree uses.
3011         On more recent Cocoa platforms, it is only changing the cookieAcceptPolicy that TestWebKitAPI uses, which isn't
3012         causing any problems because there are no other API tests that do anything with cookies.
3013         My solution will be to restore the original cookieAcceptPolicy after running this API test to clean up,
3014         but first I am committing this patch setting the cookieAcceptPolicy to NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain
3015         to reset any bots that have run tests since r204365.  I will commit a followup that sets it to originalCookieAcceptPolicy.
3016
3017 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
3018
3019         EWS should check if the patch is still valid before executing every major step
3020         https://bugs.webkit.org/show_bug.cgi?id=160739
3021         rdar://problem/27768813
3022
3023         Reviewed by Alexey Proskuryakov.
3024
3025         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3026         (CommitQueueTask.run): validate method is now executed in base class.
3027         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
3028         (EarlyWarningSystemTask.run): validate method is now executed in base class.
3029         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
3030         (StyleQueueTask.validate): Raise an PatchIsNotValid exception instead of returning False.
3031         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3032         (PatchAnalysisTask._run_command): validate the patch before executing any command. This is to ensure
3033         that we do not waste time on any patch which has become invalid (e.g.: obsolete, r-).
3034         * Scripts/webkitpy/tool/commands/perfalizer.py:
3035         (PerfalizerTask.validate): Added.
3036         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3037         (test_manual_reject_during_processing): Updated test case.
3038
3039 2016-08-11  Alex Christensen  <achristensen@webkit.org>
3040
3041         Add URLParser stub
3042         https://bugs.webkit.org/show_bug.cgi?id=160770
3043
3044         Reviewed by Sam Weinig.
3045
3046         * TestWebKitAPI/PlatformGTK.cmake:
3047         * TestWebKitAPI/PlatformWin.cmake:
3048         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3049         * TestWebKitAPI/Tests/WebCore/URLParser.cpp: Added.
3050         (TestWebKitAPI::TEST_F):
3051
3052 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
3053
3054         [iOS DRT] Allow DRT to be iPad-sized in the iPad simulator
3055         https://bugs.webkit.org/show_bug.cgi?id=160761
3056
3057         Reviewed by Tim Horton.
3058
3059         Give iOS DRT a Launch storyboard.
3060
3061         Have it use a UIViewController so future forms testing works correctly.
3062
3063         Add TARGETED_DEVICE_FAMILY = "1,2" to the build settings for the .app, so that it
3064         can run in iPad mode.
3065
3066         Remove empty InfoPlist.strings files.
3067
3068         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3069         * DumpRenderTree/ios/Info.plist:
3070         * DumpRenderTree/ios/Launch.storyboard: Added.
3071         * DumpRenderTree/mac/DumpRenderTree.mm:
3072         (createWebViewAndOffscreenWindow):
3073         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3074         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Removed.
3075         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3076         (WTR::PlatformWebView::PlatformWebView): Drive-by leak fix.
3077
3078 2016-08-11  Per Arne Vollan  <pvollan@apple.com>
3079
3080         [Win] Unable to reliably run tests in parallel
3081         https://bugs.webkit.org/show_bug.cgi?id=140914
3082
3083         Reviewed by Brent Fulgham.
3084
3085         The cygpath utility function can fail badly when running with multiple DumpRenderTree
3086         processes. We can use string replacement to convert the Cygwin path to a Windows path
3087         instead.
3088
3089         * Scripts/webkitpy/common/system/path.py:
3090         (cygpathFast):
3091         * Scripts/webkitpy/port/driver.py:
3092         (Driver._command_from_driver_input):
3093
3094 2016-08-10  Alex Christensen  <achristensen@webkit.org>
3095
3096         Fix crash when changing cookie accept policy after r204327
3097         https://bugs.webkit.org/show_bug.cgi?id=160758
3098
3099         Reviewed by Simon Fraser.
3100
3101         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3102         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Added.
3103         (-[CookieAcceptPolicyMessageHandler userContentController:didReceiveScriptMessage:]):
3104         (TEST):
3105         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Added.
3106
3107 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
3108
3109         [iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
3110         https://bugs.webkit.org/show_bug.cgi?id=160757
3111
3112         Reviewed by Tim Horton.
3113
3114         When programmatically creating the test UIWindow, make a root UIViewController and parent
3115         the WKWebView in its view. This makes the app more like a normal UIKit application.
3116         
3117         Move the WKWebView down 20px to avoid the status bar.
3118         
3119         Give the UIWindow a gray background so it's obvious where the window and view positioned.
3120
3121         Sorted the project file. Removed the link to UIKit which showed red, and wasn't necessary.
3122         
3123         Remove duplicate references to Launch.storyboard.
3124
3125         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3126         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Add license.
3127         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Add license.
3128         (-[AppDelegate applicationWillResignActive:]): Deleted.
3129         (-[AppDelegate applicationDidEnterBackground:]): Deleted.
3130         (-[AppDelegate applicationWillEnterForeground:]): Deleted.
3131         (-[AppDelegate applicationDidBecomeActive:]): Deleted.
3132         (-[AppDelegate applicationWillTerminate:]): Deleted.
3133         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3134         (WTR::viewRectForWindowRect):
3135         (WTR::PlatformWebView::PlatformWebView):
3136         (WTR::PlatformWebView::setWindowFrame):
3137
3138 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
3139
3140         [iOS WK2] Use the simulated device's screen size, rather than a harcoded size
3141         https://bugs.webkit.org/show_bug.cgi?id=160748
3142
3143         Reviewed by Tim Horton.
3144         
3145         Use the main UIScreen's bounds for the window size if we're using a flexible viewport. This
3146         opens the door for tests using other device sizes.
3147
3148         * WebKitTestRunner/ios/TestControllerIOS.mm:
3149         (WTR::TestController::platformConfigureViewForTest):
3150
3151 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
3152
3153         Sort the feature flags in the FEATURE_DEFINES lines
3154         https://bugs.webkit.org/show_bug.cgi?id=160742
3155
3156         Reviewed by Anders Carlsson.
3157         
3158         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3159
3160 2016-08-09  Simon Fraser  <simon.fraser@apple.com>
3161
3162         Logging and other minor improvements to iOS webkitpy
3163         https://bugs.webkit.org/show_bug.cgi?id=160722
3164
3165         Reviewed by Dan Bates.
3166
3167         Fix --debug-rwt-logging to log all the calls to simctl as well as device state information,
3168         to make it easier to debug launching issues.
3169
3170         Have reset_preferences() reset the device, rather than just nuking the data
3171         directory (which broke some versions of the simulator).
3172
3173         Make the Simulator.app launch in the background with open -g.
3174
3175         Wait for the simulator device to be in a known state in some more places.
3176
3177         * Scripts/webkitpy/port/ios.py:
3178         (IOSSimulatorPort.setup_test_run):
3179         (IOSSimulatorPort._quit_ios_simulator):
3180         (IOSSimulatorPort.clean_up_test_run):
3181         (IOSSimulatorPort.setup_environ_for_server):
3182         (IOSSimulatorPort.reset_preferences):
3183         * Scripts/webkitpy/xcode/simulator.py:
3184         (Device.create):
3185         (Device.delete):
3186         (Device):
3187         (Device.reset):
3188         (Simulator.wait_until_device_is_booted):
3189         (Simulator.wait_until_device_is_in_state):
3190         (Simulator):
3191         (Simulator.delete_device):
3192         (Simulator.reset_device):
3193         (Simulator.lookup_or_create_device):
3194
3195 2016-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3196
3197         [GTK][EFL] ALSA_CARD environment variable is not passed for layout tests.
3198         https://bugs.webkit.org/show_bug.cgi?id=160697
3199
3200         Reviewed by Antonio Gomes.
3201
3202         * Scripts/webkitpy/port/base.py:
3203         (Port.to.setup_environ_for_server): Add ALSA_CARD and sort the Linux
3204         list of environment variables to copy.
3205
3206 2016-08-09  George Ruan  <gruan@apple.com>
3207
3208         Implement functionality of media capture on iOS
3209         https://bugs.webkit.org/show_bug.cgi?id=158945
3210         <rdar://problem/26893343>
3211
3212         Reviewed by Tim Horton.
3213
3214         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Enable Media
3215         Capture feature on iOS.
3216
3217 2016-08-09  Saam Barati  <sbarati@apple.com>
3218
3219         Parser<LexerType>::parseFunctionInfo() has the wrong info about captured vars when a function is not cached.
3220         https://bugs.webkit.org/show_bug.cgi?id=160671
3221         <rdar://problem/27756112>
3222
3223         Reviewed by Mark Lam.
3224
3225         * Scripts/run-jsc-stress-tests:
3226
3227 2016-08-09  Alexey Proskuryakov  <ap@apple.com>
3228
3229         Make directory reading code in iOSSimulatorDevices() more strict
3230         https://bugs.webkit.org/show_bug.cgi?id=160702
3231
3232         Reviewed by Tim Horton.
3233
3234         * Scripts/webkitdirs.pm:
3235         (iOSSimulatorDevices):
3236
3237 2016-08-06  Sam Weinig  <sam@webkit.org>
3238
3239         Replace NodeOrString with std::variant<RefPtr<Node>, String>
3240         https://bugs.webkit.org/show_bug.cgi?id=160638
3241
3242         Reviewed by Anders Carlsson.
3243
3244         * TestWebKitAPI/CMakeLists.txt:
3245         * TestWebKitAPI/Tests/WTF/Variant.cpp:
3246         Add additional tests for the initial state of std::variant and using
3247         makeVisitor for visiting.
3248
3249 2016-08-09  Aakash Jain  <aakash_jain@apple.com>
3250
3251         EWS logging should ensure the logging to file is stopped on queue termination
3252         https://bugs.webkit.org/show_bug.cgi?id=160698
3253         rdar://problem/24464570
3254
3255         Reviewed by Daniel Bates.
3256
3257         * Scripts/webkitpy/tool/bot/queueengine.py:
3258         (QueueEngine._stopping): Stop logging to file on queue termination.
3259         (QueueEngine._begin_logging): Configure the Python logger to log to file.
3260         * Scripts/webkitpy/common/system/logutils.py:
3261         (configure_logger_to_log_to_file): Return the handler so as to enable caller to remove it later.
3262         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
3263         (QueueEngineTest._run_engine): Removed extra newline character to improve log readability.
3264         * Scripts/webkitpy/tool/commands/queues.py:
3265         (AbstractQueue._log_directory): Reverting to os.path.join as we don't have host object.
3266         (AbstractQueue.queue_log_path): Same.
3267         (AbstractQueue.begin_work_queue): Removed logging initialization, it is now being done in QueueEngine.
3268         (AbstractQueue.__init__): Removed host parameter, not required anymore, it was required by logging initialization
3269         which moved to QueueEngine now.
3270         (PatchProcessingQueue.__init__): Same.
3271         (CommitQueue.__init__): Same.
3272         (AbstractReviewQueue.__init__): Same.
3273         (StyleQueue.__init__): Same.
3274         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3275         (TestCommitQueue): Removed host parameter.
3276         (TestCommitQueue.__init__): Same.
3277         (AbstractPatchQueueTest.test_next_patch): Same.
3278         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
3279         (test_commit_queue_failure): Same.
3280         (mock_run_webkit_patch):
3281         (MockCommitQueueTask.results_from_patch_test_run): Same.
3282         (test_rollout_lands): Same.
3283         (test_non_valid_patch): Same.
3284         (test_auto_retry): Same.
3285         (test_style_queue_with_watch_list_exception): Same.
3286         (TestQueue.__init__): Deleted.
3287         (TestReviewQueue.__init__): Deleted.
3288         (TestFeederQueue.__init__): Deleted.
3289
3290 2016-08-09  Konstantin Tokarev  <annulen@yandex.ru>
3291
3292         webkit-gtk tarball fails to build due to missing files
3293         https://bugs.webkit.org/show_bug.cgi?id=160684
3294
3295         Reviewed by Alex Christensen.
3296
3297         * gtk/manifest.txt.in: Added back spi directories.
3298
3299 2016-08-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3300
3301         [GTK] Build the jhbuild with -O2 optimization level by default
3302         https://bugs.webkit.org/show_bug.cgi?id=160544
3303
3304         Reviewed by Michael Catanzaro.
3305
3306         * gtk/jhbuildrc: Pass -O2 when building the JHBuild, as also -g1
3307         which don't increases the required disk space significatively and
3308         provides better debug information than no passing it.
3309
3310 2016-08-09  Csaba Osztrogonác  <ossy@webkit.org>
3311
3312         Allow more --cmakeargs option in build-jsc and build-webkit
3313         https://bugs.webkit.org/show_bug.cgi?id=160340
3314
3315         Reviewed by Michael Catanzaro.
3316
3317         * Scripts/build-jsc:
3318         * Scripts/build-webkit:
3319
3320 2016-08-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3321
3322         Do not check if WebKitLibraries folder exists on EFL and GTK
3323         https://bugs.webkit.org/show_bug.cgi?id=160659
3324
3325         Reviewed by Csaba Osztrogonác.
3326
3327         Though WebKitLibraries is only needed by mac and win ports,
3328         EFL and GTK ports have checked whether it exists.
3329
3330         * Scripts/build-webkit:
3331
3332 2016-08-08  Aakash Jain  <aakash_jain@apple.com>
3333
3334         Some EWS console logs doesn't go to log file
3335         https://bugs.webkit.org/show_bug.cgi?id=160585
3336         rdar://problem/24464570
3337
3338         Reviewed by Daniel Bates.
3339
3340         * Scripts/webkitpy/common/system/logutils.py:
3341         (FileSystemHandler._open): Ensure that we open logfile in append mode in order to avoid
3342         any possible overwriting.
3343         * Scripts/webkitpy/common/system/filesystem.py:
3344         (FileSystem.open_text_file_for_writing): Add should_append parameter to append to file.
3345         * Scripts/webkitpy/common/system/filesystem_mock.py:
3346         (MockFileSystem.open_text_file_for_writing): Same.
3347         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3348         (RealFileSystemTest.test_read_and_write_text_file): Removed unused variable 'hex_equivalent'.
3349         (RealFileSystemTest.test_append_to_text_file): Added new unit test for testing append functionality.
3350         * Scripts/webkitpy/tool/commands/queues.py:
3351         (AbstractQueue.begin_work_queue): Configure the logger for overall webkitpy to log to file.
3352         This will ensure that all the sub-modules inside webkitpy will log to file.
3353
3354 2016-08-08  Simon Fraser  <simon.fraser@apple.com>
3355
3356         Have the iOS platform interit from the Apple platform in webkitpy
3357         https://bugs.webkit.org/show_bug.cgi?id=160672
3358
3359         Reviewed by Dan Bates.
3360         
3361         The IOSSimulatorPort used to inherit from Port, rather than ApplePort.
3362         Fix this, and move duplicated code from IOSSimulatorPort and MacPort into
3363         ApplePort.
3364         
3365         Since WinPort also inherits from ApplePort, it needs to stub out some things
3366         that are unavailable on Windows (leaks, sampling).
3367         
3368         Some SnowLeopard-related code and the associated test were removed.
3369
3370         * Scripts/webkitpy/port/apple.py:
3371         (ApplePort.__init__):
3372         (ApplePort):
3373         (ApplePort._make_leak_detector):
3374         (ApplePort.default_timeout_ms):
3375         (ApplePort.supports_per_test_timeout):
3376         (ApplePort.should_retry_crashes):
3377         (ApplePort._generate_all_test_configurations):
3378         (ApplePort.check_for_leaks):
3379         (ApplePort.print_leaks_summary):
3380         (ApplePort._path_to_webcore_library):
3381         (ApplePort.show_results_html_file):
3382         (ApplePort._merge_crash_logs):
3383         (ApplePort._look_for_all_crash_logs_in_log_dir):
3384         (ApplePort._get_crash_log):
3385         (ApplePort.look_for_new_crash_logs):
3386         (ApplePort.sample_process):
3387         (ApplePort.sample_file_path):
3388         (ApplePort.look_for_new_samples):
3389         (ApplePort._path_to_helper):
3390         (ApplePort.determine_full_port_name): Deleted.
3391         * Scripts/webkitpy/port/ios.py:
3392         (IOSSimulatorPort):
3393         (IOSSimulatorPort.__init__):
3394         (IOSSimulatorPort.default_timeout_ms): Deleted.
3395         (IOSSimulatorPort.supports_per_test_timeout): Deleted.
3396         (IOSSimulatorPort.should_retry_crashes): Deleted.
3397         (IOSSimulatorPort.check_for_leaks): Deleted.
3398         (IOSSimulatorPort.print_leaks_summary): Deleted.
3399         (IOSSimulatorPort._path_to_webcore_library): Deleted.
3400         (IOSSimulatorPort.show_results_html_file): Deleted.
3401         (IOSSimulatorPort.sample_file_path): Deleted.
3402         (IOSSimulatorPort._merge_crash_logs): Deleted.
3403         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Deleted.
3404         (IOSSimulatorPort.look_for_new_crash_logs): Deleted.
3405         (IOSSimulatorPort.look_for_new_samples): Deleted.
3406         (IOSSimulatorPort.sample_process): Deleted.
3407         (IOSSimulatorPort._path_to_helper): Deleted.
3408         (IOSSimulatorPort.make_command): Deleted.
3409         * Scripts/webkitpy/port/mac.py:
3410         (MacPort.__init__):
3411         (MacPort.make_command):
3412         (MacPort._build_java_test_support):
3413         (MacPort): Deleted.
3414         (MacPort.default_timeout_ms): Deleted.
3415         (MacPort.supports_per_test_timeout): Deleted.
3416         (MacPort.should_retry_crashes): Deleted.
3417         (MacPort.default_child_processes): Deleted.
3418         (MacPort.check_for_leaks): Deleted.
3419         (MacPort.print_leaks_summary): Deleted.
3420         (MacPort._path_to_webcore_library): Deleted.
3421         (MacPort.show_results_html_file): Deleted.
3422         (MacPort.sample_file_path): Deleted.
3423         (MacPort._merge_crash_logs): Deleted.
3424         (MacPort._look_for_all_crash_logs_in_log_dir): Deleted.
3425         (MacPort.look_for_new_crash_logs): Deleted.
3426         (MacPort.look_for_new_samples): Deleted.
3427         (MacPort.sample_process): Deleted.
3428         (MacPort._path_to_helper): Deleted.
3429         * Scripts/webkitpy/port/mac_unittest.py:
3430         (MacTest.test_default_child_processes): Deleted.
3431         * Scripts/webkitpy/port/win.py:
3432         (WinPort.look_for_new_samples):
3433         (WinPort):
3434         (WinPort.sample_process):
3435         (WinPort._make_leak_detector):
3436         (WinPort.check_for_leaks):
3437         (WinPort.print_leaks_summary):
3438         (WinPort._path_to_webcore_library):
3439
3440 2016-08-08  Matt Baker  <mattbaker@apple.com>
3441
3442         Unreviewed: moved myself to the reviewers list.
3443
3444         * Scripts/webkitpy/common/config/contributors.json:
3445
3446 2016-08-08  Chris Dumez  <cdumez@apple.com>
3447
3448         Update API tests in mac/SetDocumentURI.mm after r204247
3449         https://bugs.webkit.org/show_bug.cgi?id=160660
3450
3451         Reviewed by Alex Christensen.
3452
3453         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
3454         (TestWebKitAPI::TEST):
3455
3456 2016-08-08  Jonathan Bedard  <jbedard@apple.com>
3457
3458         run-webkit-tests should trigger a spindump when WebContent process is unresponsive
3459         https://bugs.webkit.org/show_bug.cgi?id=159827
3460
3461         Reviewed by Daniel Bates.
3462
3463         This change was spurred by a process hang which occurred between tests and did
3464         not produce a meaningful crashlog.
3465
3466         * Scripts/webkitpy/port/driver.py:
3467         (Driver._check_for_driver_crash_or_unresponsiveness): Notify test controller when finished through stdin.
3468
3469          * Scripts/webkitpy/port/ios.py:
3470         (IOSSimulatorPort):
3471         (IOSSimulatorPort.sample_process): Attempt spindump, but use sample if spindump fails.
3472         * Scripts/webkitpy/port/mac.py:
3473         (MacPort):
3474         (MacPort.sample_process): Attempt spindump, but use sample if spindump fails.
3475
3476         * Scripts/webkitpy/port/mac_unittest.py: Changed expected values to match spindump calls, added specific spindump test.
3477         * Scripts/webkitpy/port/driver_unittest.py: Added dummy write function.
3478
3479         * WebKitTestRunner/TestController.h:
3480         (WTR::TestController::usingServerMode): Added accessor for m_usingServerMode.
3481         * WebKitTestRunner/TestInvocation.cpp:
3482         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Wait for stdin before continuing when in server mode.
3483
3484 2016-08-07  Dan Bernstein  <mitz@apple.com>
3485
3486         [Cocoa] Reply block leaks if the remote object doesn’t call it
3487         https://bugs.webkit.org/show_bug.cgi?id=160642
3488
3489         Reviewed by Sam Weinig.
3490
3491         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Declared a new method.
3492         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
3493         (TEST): Added a test case that checks that the reply block is released even when it’s not
3494           called.
3495         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
3496         (-[RemoteObjectRegistryPlugIn doNotCallCompletionHandler:]): Implement new method by not
3497           calling the completion handler.
3498
3499 2016-08-07  Chris Dumez  <cdumez@apple.com>
3500
3501         Write API test to cover crash fix in r204135
3502         https://bugs.webkit.org/show_bug.cgi?id=160587
3503
3504         Reviewed by Darin Adler.
3505
3506         Add API test to cover crash fix in r204135. This reproduces the crash
3507         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
3508         callback.
3509
3510         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
3511         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
3512         (TEST):
3513
3514 2016-08-06  Chris Dumez  <cdumez@apple.com>
3515
3516         Unreviewed, rolling out r204226.
3517
3518         Broke some API tests
3519
3520         Reverted changeset:
3521
3522         "Write API test to cover crash fix in r204135"
3523         https://bugs.webkit.org/show_bug.cgi?id=160587
3524         http://trac.webkit.org/changeset/204226
3525
3526 2016-08-06  Aakash Jain  <aakash_jain@apple.com>
3527
3528         EWS Style Queue fails to process patches which fails validation
3529         https://bugs.webkit.org/show_bug.cgi?id=160632
3530
3531         Reviewed by Alexey Proskuryakov.
3532
3533         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
3534         (StyleQueueTask.validate): Add more information about validation failure.
3535         (StyleQueueTask.run): Pass the error details in the PatchIsNotValid exception.
3536         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3537         (test_non_valid_patch): Add a unit test to test the above code path.
3538
3539 2016-08-06  Sam Weinig  <sam@webkit.org>
3540
3541         WTF needs a variant implementation
3542         https://bugs.webkit.org/show_bug.cgi?id=160618
3543
3544         Reviewed by Darin Adler.
3545
3546         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3547         * TestWebKitAPI/Tests/WTF/Variant.cpp: Added.
3548         Add tests for the variant implementation.
3549
3550 2016-08-06  Chris Dumez  <cdumez@apple.com>
3551
3552         Write API test to cover crash fix in r204135
3553         https://bugs.webkit.org/show_bug.cgi?id=160587
3554
3555         Reviewed by Darin Adler.
3556
3557         Add API test to cover crash fix in r204135. This reproduces the crash
3558         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
3559         callback.
3560
3561         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
3562         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
3563         (TEST):
3564
3565 2016-08-05  Tim Horton  <timothy_horton@apple.com>
3566
3567         run-api-tests should use a headed simulator
3568         https://bugs.webkit.org/show_bug.cgi?id=160611
3569
3570         Reviewed by Sam Weinig.
3571
3572         CADisplayLink doesn't work in a headless simulator, but is
3573         vital for the proper functioning of WebKit2 painting on iOS.
3574         So, we should not use a headless simulator.
3575
3576         * Scripts/run-api-tests:
3577         Launch a simulator app, don't just boot the simulator.
3578
3579         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
3580         Re-enable a test that works now.
3581
3582 2016-08-05  Dan Bernstein  <mitz@apple.com>
3583
3584         [Cocoa] WKRemoteObjectCoder doesn’t handle NSRange
3585         https://bugs.webkit.org/show_bug.cgi?id=160589
3586
3587         Reviewed by Tim Horton.
3588
3589         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
3590         (remoteObjectInterface): Fixed a mistake in the set of allowed classes in one of the reply
3591           blocks, which wasn’t caught because the test wasn’t run correctly.
3592         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
3593         (TEST): Fixed the -selectionAndClickInformationForClickAtPoint:completionHandler: test, and
3594           added a test that sends over an NSRange.
3595         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
3596         (-[RemoteObjectRegistryPlugIn takeRange:completionHandler:]): Added. Calls the completion
3597           handler with the range‘s location and length.
3598
3599 2016-08-05  Enrica Casucci  <enrica@apple.com>
3600
3601         Fixing tests failing after r204175.
3602
3603         Unreviewed.
3604
3605         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:
3606
3607 2016-08-05  Enrica Casucci  <enrica@apple.com>
3608
3609         Build fix after 204053.
3610
3611         Unreviewed.
3612
3613         * TestWebKitAPI/Configurations/Base.xcconfig:
3614         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
3615         (-[MockContentFilterEnabler initWithCoder:]):
3616         (-[MockContentFilterEnabler dealloc]):
3617
3618 2016-08-05  Konstantin Tokarev  <annulen@yandex.ru>
3619
3620         Print test name in "Last character read from DRT..." error message.
3621         https://bugs.webkit.org/show_bug.cgi?id=160559
3622
3623         Reviewed by Michael Catanzaro.
3624
3625         * Scripts/webkitpy/port/driver.py: