ff38f02f4e2157dfb1e011f7abde22bb6292723b
[WebKit-https.git] / Tools / ChangeLog
1 2013-12-18  Anders Carlsson  <andersca@apple.com>
2
3         Remove now useless test.
4
5         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
6         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm: Removed.
7         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm: Removed.
8         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Shared.h: Removed.
9
10 2013-12-18  Gavin Barraclough  <barraclough@apple.com>
11
12         Fix page visibility api test, initialization in WebKit2
13         https://bugs.webkit.org/show_bug.cgi?id=125933
14
15         Reviewed by Anders Carlsson.
16
17         The API test for page visibility is broken, fix this. This revealed a recent regression in WebKit2
18         (introduced in https://bugs.webkit.org/show_bug.cgi?id=123379), caused by a typo removing a '!'.
19
20         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
21         (TestWebKitAPI::TEST_F):
22             - Running a test on WebKit1 twice is not the same as running it on WebKit2!
23
24 2013-12-18  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
25
26         Should not have identifiers with underscores in them, especially not leading underscores.
27         https://bugs.webkit.org/show_bug.cgi?id=125847
28
29         Reviewed by Darin Adler.
30
31         * Scripts/webkitpy/style/checkers/cpp.py:
32         (check_identifier_name_in_declaration):
33         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
34         (CppStyleTest.test_runtime_selfinit):
35         (WebKitStyleTest.test_names):
36
37 2013-12-18  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
38
39         False webkit-check-style warnings on *.
40         https://bugs.webkit.org/show_bug.cgi?id=125915
41
42         Reviewed by Darin Adler.
43
44         * Scripts/webkitpy/style/checkers/cpp.py:
45         (check_spacing):
46         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
47         (CppStyleTest.test_pointer_reference_marker_location):
48
49 2013-12-18  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
50
51         prepare-ChangeLog doesn't handle templates properly
52         https://bugs.webkit.org/show_bug.cgi?id=125853
53
54         Reviewed by Daniel Bates.
55
56         * Scripts/prepare-ChangeLog:
57         (get_function_line_ranges_for_cpp):
58         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
59         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
60         (Class110<TemplateClass>::func36):
61
62 2013-12-18  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
63
64         Move expectation parsing out of the constructor of TestExpectations
65         https://bugs.webkit.org/show_bug.cgi?id=125439
66
67         Reviewed by Csaba Osztrogonác.
68
69         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
70         (LayoutTestRunnerTests._run_tests):
71         (LayoutTestRunnerTests.test_interrupt_if_at_failure_limits):
72         (LayoutTestRunnerTests.test_update_summary_with_result):
73         * Scripts/webkitpy/layout_tests/controllers/manager.py:
74         (Manager.run):
75         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
76         (ManagerTest.test_look_for_new_crash_logs):
77         * Scripts/webkitpy/layout_tests/lint_test_expectations.py:
78         (lint):
79         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
80         (TestExpectations.suffixes_for_expectations):
81         (TestExpectations.__init__):
82         (TestExpectations):
83         (TestExpectations.parse_generic_expectations):
84         (TestExpectations.parse_default_port_expectations):
85         (TestExpectations.parse_override_expectations):
86         (TestExpectations.parse_all_expectations):
87         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
88         (parse_exp):
89         (SkippedTests.check):
90         (SkippedTests.test_skipped_entry_dont_exist):
91         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
92         (run_results):
93         * Scripts/webkitpy/tool/commands/queries.py:
94         (PrintExpectations._model):
95         * Scripts/webkitpy/tool/commands/rebaseline.py:
96         (RebaselineTest._update_expectations_file):
97         (RebaselineExpectations._update_expectations_files):
98         (RebaselineExpectations._tests_to_rebaseline):
99
100 2013-12-17  Jer Noble  <jer.noble@apple.com>
101
102         Fix TimeRanges::intersectWith
103         https://bugs.webkit.org/show_bug.cgi?id=118802
104
105         Reviewed by Eric Carlson.
106
107         Add unit tests for WebCore/TimeRanges.
108
109         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
110         * TestWebKitAPI/Tests/WebCore/TimeRanges.cpp: Added.
111         (TestWebKitAPI::ToString):
112         (TestWebKitAPI::TEST):
113
114 2013-12-17  Alexey Proskuryakov  <ap@apple.com>
115
116         Botwatcher's dashboard ceases to update itself after a while
117         https://bugs.webkit.org/show_bug.cgi?id=125885
118
119         Reviewed by Timothy Hatcher.
120
121         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
122         Removed code that checked for the view being hidden. It's none of model's business.
123
124         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
125         (BuildbotQueueView): Find out what platform the view is for. Initlialize update timer.
126         (BuildbotQueueView.prototype._updateHiddenState): Start or stop update timer as appropriate.
127         We now stop the timer for hidden views.
128         (BuildbotQueueView.prototype._updateQueues): Removed the logic for ignoring some updates.
129
130 2013-12-17  Anders Carlsson  <andersca@apple.com>
131
132         Fix the 32-bit build.
133
134         * MiniBrowser/MiniBrowserWebProcessPlugIn.h:
135         * MiniBrowser/MiniBrowserWebProcessPlugIn.m:
136
137 2013-12-17  Anders Carlsson  <andersca@apple.com>
138
139         Give the MiniBrowser a bundle
140         https://bugs.webkit.org/show_bug.cgi?id=125882
141
142         Reviewed by Sam Weinig.
143
144         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Added.
145         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
146         * MiniBrowser/MiniBrowserWebProcessPlugIn.h: Added.
147         * MiniBrowser/MiniBrowserWebProcessPlugIn.m: Added.
148         (-[MiniBrowserWebProcessPlugIn webProcessPlugIn:initializeWithObject:]):
149         * MiniBrowser/mac/AppDelegate.m:
150         (-[BrowserAppDelegate init]):
151         * MiniBrowser/mac/Bundle/Info.plist: Added.
152         * MiniBrowser/mac/Bundle/MiniBrowserBundle_Prefix.pch: Added.
153
154 2013-12-17  Gavin Barraclough  <barraclough@apple.com>
155
156         Remove PageVisibilityStateUnloaded
157         https://bugs.webkit.org/show_bug.cgi?id=125869
158
159         Reviewed by Anders Carlsson.
160
161         This is not currently supported by WebKit, remove this enum value.
162         We can always add this back later if/when we add support for this state.
163
164         * DumpRenderTree/mac/TestRunnerMac.mm:
165         (TestRunner::setPageVisibility):
166         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp:
167         (TestWebKitAPI::didRunStep3StateChangePrerenderToUnloaded):
168         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
169         (WTR::TestRunner::setPageVisibility):
170             - remove test for visibility state "unloaded"; this is no longer supported (it never really was).
171
172 2013-12-12  Martin Robinson  <mrobinson@igalia.com>
173
174         [GTK] [CMake] Build the plugin process against GTK+ 2
175         https://bugs.webkit.org/show_bug.cgi?id=116374
176
177         Reviewed by Gustavo Noronha Silva.
178
179         * TestWebKitAPI/PlatformGTK.cmake: Add WebCorePlatformGTK to the list of
180         libraries required for WebCore unit tests.
181
182 2013-12-17  Brent Fulgham  <bfulgham@apple.com>
183
184         [Win] Revise filter-build-webkit to deal with Windows build logs
185         https://bugs.webkit.org/show_bug.cgi?id=125866
186
187         Reviewed by David Kilzer.
188
189         Enhance the script to accept a 'platform' argument. When platform
190         'win' is provided, use processing for the Windows build file format.
191         Otherwise, process the files as normal.
192
193         * Scripts/filter-build-webkit:
194         (usageAndExit): Add a 'platform' argument
195         (shouldIgnoreLine): When platform == 'win' use the new Windows
196         rules for processing the build file.
197
198 2013-12-17  Alexey Proskuryakov  <ap@apple.com>
199
200         Update style checker now that ENUM_CLASS is gone
201         https://bugs.webkit.org/show_bug.cgi?id=125864
202
203         Reviewed by Anders Carlsson.
204
205         * Scripts/webkitpy/style/checkers/cpp.py:
206         (_EnumState.process_clean_line):
207         (check_braces):
208         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
209         (NoNonVirtualDestructorsTest.test_enum_casing.Foo):
210         (NoNonVirtualDestructorsTest.test_enum_casing):
211         (NoNonVirtualDestructorsTest.test_enum_casing.Enum123):
212         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass):
213         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum):
214         (WebKitStyleTest.test_braces.CPP11EnumClass):
215
216 2013-12-17  Mario Sanchez Prada  <mario.prada@samsung.com>
217
218         [ATK] Expose accessibility objects for <dl>, <dt> and <dd>
219         https://bugs.webkit.org/show_bug.cgi?id=125857
220
221         Reviewed by Chris Fleizach.
222
223         Add mappings to DRT & WKTR for the newly exposed roles, and
224         increase the version of ATK used by the internal jhbuild.
225
226         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
227         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
228         * gtk/jhbuild.modules: Raise version of ATK up to 2.11.4.
229
230 2013-12-17  Alex Christensen  <achristensen@webkit.org>
231
232         [WinCairo] Adding support for GStreamer and GLib.
233         https://bugs.webkit.org/show_bug.cgi?id=124867
234
235         Reviewed by Philippe Normand.
236
237         * WinLauncher/WinLauncher.cpp:
238         (wWinMain):
239         Added g_main_context_iteration in main event loop.
240
241 2013-12-17  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
242
243         Fix for C++ should have the & or * beside the type not the variable name check.
244         https://bugs.webkit.org/show_bug.cgi?id=125846
245
246         Reviewed by Darin Adler.
247
248         * Scripts/webkitpy/style/checkers/cpp.py:
249         (check_spacing):
250         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
251         (CppStyleTest.test_pointer_reference_marker_location):
252
253 2013-12-16  Rob Buis  <rob.buis@samsung.com>
254
255         Add my Samsung email address.
256
257         Unreviewed.
258
259         * Scripts/webkitpy/common/config/contributors.json:
260
261 2013-12-16  Oliver Hunt  <oliver@apple.com>
262
263         Cache getters and custom accessors on the prototype chain
264         https://bugs.webkit.org/show_bug.cgi?id=125602
265
266         Reviewed by Michael Saboff.
267
268         Make sure bencher scripts also make noInline exist
269
270         * Scripts/bencher:
271
272 2013-12-16  Anders Carlsson  <andersca@apple.com>
273
274         Fix crash when trying to load a null HTML string
275         https://bugs.webkit.org/show_bug.cgi?id=125801
276
277         Reviewed by Dan Bernstein.
278
279         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
280         (TestWebKitAPI::TEST_F):
281         Update test results.
282
283 2013-12-16  Alex Christensen  <achristensen@webkit.org>
284
285         Fixed Win64 build on VS2013.
286         https://bugs.webkit.org/show_bug.cgi?id=125753
287
288         Reviewed by Brent Fulgham.
289
290         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
291         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
292         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
293         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
294         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
295         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
296         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
297         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
298         * win/record-memory/record-memory.vcxproj:
299         Added correct PlatformToolset for 64-bit builds.
300
301 2013-12-16  Simon Fraser  <simon.fraser@apple.com>
302
303         Add a menu option to MiniBrowser to enable UI-side compositing
304         https://bugs.webkit.org/show_bug.cgi?id=125793
305
306         Reviewed by Anders Carlsson.
307         
308         Make it possible to test UI-side compositing in MiniBrowser WK2 windows.
309
310         * MiniBrowser/mac/BrowserWindowController.h: Add optional protocol method
311         to toggle UI-side compositing.
312         * MiniBrowser/mac/MainMenu.xib: Add menu item to Debug menu.
313         * MiniBrowser/mac/WK2BrowserWindowController.m:
314         (-[WK2BrowserWindowController validateMenuItem:]):
315         (-[WK2BrowserWindowController isUISideCompositingEnabled]):
316         (-[WK2BrowserWindowController toggleUISideCompositing:]):
317         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
318         Adjust the window title to indicate whether the window is using UI-side compositing.
319
320 2013-12-16  Commit Queue  <commit-queue@webkit.org>
321
322         Unreviewed, rolling out r160645.
323         http://trac.webkit.org/changeset/160645
324         https://bugs.webkit.org/show_bug.cgi?id=125787
325
326         Change breaks test-webkitpy (Requested by bfulgham on
327         #webkit).
328
329         * Scripts/prepare-ChangeLog:
330         (get_selector_line_ranges_for_css):
331
332 2013-12-16  David Farler  <dfarler@apple.com>
333
334         [ASAN] WebKitLauncher: Include libasancrashreporter.dylib in DYLD_INSERT_LIBRARIES if it exists
335         https://bugs.webkit.org/show_bug.cgi?id=124610
336
337         Reviewed by Mark Rowe.
338
339         * WebKitLauncher/WebKitNightlyEnabler.m:
340         (enableWebKitNightlyBehaviour):
341         Add libasancrashreporter.dylib to DYLD_INSERT_LIBRARIES.
342         * WebKitLauncher/main.m:
343         (main):
344         Include both libasancrashreporter and the nightly enabler to
345         the list of libraries to insert.
346
347 2013-12-16  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
348
349         Resolve inconsistant style warning caused by r160319.
350         https://bugs.webkit.org/show_bug.cgi?id=125772
351
352         Reviewed by Darin Adler.
353
354         * Scripts/webkitpy/style/checkers/cpp.py:
355         (check_for_extra_new_line_at_eof):
356         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
357         (CppStyleTest.test_newline_at_eof):
358         (CppStyleTest.test_extra_newlines_at_eof):
359
360 2013-12-16  Eva Balazsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
361
362         Remove mock_drt.py: parse_options() - --test-shell and --pixel-tests=<path>
363         https://bugs.webkit.org/show_bug.cgi?id=125780
364
365         Reviewed by Darin Adler.
366
367         * Scripts/webkitpy/port/mock_drt.py:
368         (main):
369         (parse_options):
370         (MockDRT.write_test_output):
371         * Scripts/webkitpy/port/mock_drt_unittest.py:
372         (MockDRTTest.assertTest):
373         (MockDRTTest.test_reftest_mismatch):
374
375 2013-12-16  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
376
377         prepare-Changelog treats CSS keyframes as mismatched parentheses.
378         https://bugs.webkit.org/show_bug.cgi?id=125435
379
380         Reviewed by Darin Adler.
381
382         * Scripts/prepare-ChangeLog:
383         (get_selector_line_ranges_for_css):
384
385 2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
386
387         [ATK] Expose accessibility objects for more WAI-ARIA roles
388         https://bugs.webkit.org/show_bug.cgi?id=125596
389
390         Reviewed by Chris Fleizach.
391
392         Add mappings to DRT & WKTR for the newly exposed roles.
393
394         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
395         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
396
397 2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
398
399         [ATK] Expose accessibility objects with ATK_ROLE_CHECK_MENU_ITEM
400         https://bugs.webkit.org/show_bug.cgi?id=125594
401
402         Reviewed by Chris Fleizach.
403
404         Add mappings to DRT & WKTR for checkmenuitem role.
405
406         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
407         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
408
409 2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
410
411         [ATK] Expose accessibility objects with ATK_ROLE_ARTICLE
412         https://bugs.webkit.org/show_bug.cgi?id=125587
413
414         Reviewed by Chris Fleizach.
415
416         Add mappings to DRT & WKTR for article roles.
417
418         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
419         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
420
421 2013-12-16  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
422
423         [FTL] Allow EFL to build FTL with the build-jsc script.
424         https://bugs.webkit.org/show_bug.cgi?id=125774
425
426         Reviewed by Zoltan Herczeg.
427
428         * Scripts/build-jsc:
429
430 2013-12-16  Krzysztof Czech  <k.czech@samsung.com>
431
432         Add myself as a committer
433
434         Unreviewed.
435
436         * Scripts/webkitpy/common/config/contributors.json:
437
438 2013-12-15  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
439
440         Refactor option handling in WebKitTestRunner.
441         https://bugs.webkit.org/show_bug.cgi?id=123185
442
443         Reviewed by Darin Adler.
444
445         Option handling is refactored (according to the FIXME) that allows
446         to automatically generate the help message.
447
448         * WebKitTestRunner/CMakeLists.txt:
449         * WebKitTestRunner/GNUmakefile.am:
450         * WebKitTestRunner/Options.cpp: Added.
451         (WTR::Options::Options):
452         (WTR::handleOptionTimeout):
453         (WTR::handleOptionNoTimeout):
454         (WTR::handleOptionNoTimeoutAtAll):
455         (WTR::handleOptionVerbose):
456         (WTR::handleOptionGcBetweenTests):
457         (WTR::handleOptionPixelTests):
458         (WTR::handleOptionPrintSupportedFeatures):
459         (WTR::handleOptionComplexText):
460         (WTR::handleOptionAcceleratedDrawing):
461         (WTR::handleOptionRemoteLayerTree):
462         (WTR::handleOptionUnmatched):
463         (WTR::OptionsHandler::OptionsHandler):
464         (WTR::Option::Option):
465         (WTR::Option::matches):
466         (WTR::OptionsHandler::parse):
467         (WTR::OptionsHandler::printHelp):
468         * WebKitTestRunner/Options.h: Added.
469         * WebKitTestRunner/TestController.cpp:
470         (WTR::TestController::initialize):
471         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
472
473 2013-12-15  Dan Bernstein  <mitz@apple.com>
474
475         32-bit build fix.
476
477         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
478         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
479
480 2013-12-14  Tim Horton  <timothy_horton@apple.com>
481
482         stylebot should warn when FeatureDefines differ
483         https://bugs.webkit.org/show_bug.cgi?id=125748
484
485         Reviewed by Dan Bernstein.
486
487         Add a stylebot checker that ensures that FeatureDefines.xcconfig files
488         are always exactly equal (and warns people adding new FeatureDefines.xcconfig files,
489         an unlikely occurrance, to add them to the list).
490
491         It's a bit nontraditional for stylebot because it will warn on existing errors in the tree,
492         but that is the most straightforward way to implement it (and we're at zero diffs right now).
493
494         * Scripts/webkitpy/style/checker.py:
495         (_all_categories):
496         (FileType):
497         (CheckerDispatcher._file_type):
498         (CheckerDispatcher._create_checker):
499         * Scripts/webkitpy/style/checkers/featuredefines.py: Added.
500         (FeatureDefinesChecker):
501         (FeatureDefinesChecker.__init__):
502         (FeatureDefinesChecker.check):
503
504 2013-12-13  Sam Weinig  <sam@webkit.org>
505
506         Fix API tests.
507
508         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
509         (TestWebKitAPI::TEST_F):
510
511 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
512
513         [Win] Remove Pre-VS2013 support code.
514         https://bugs.webkit.org/show_bug.cgi?id=125693
515
516         Reviewed by Darin Adler.
517
518         * DumpRenderTree/cg/ImageDiffCG.cpp: Remove strtof stub now supplied by
519         the math library.
520         * DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
521
522 2013-12-13  Lucas Forschler  <lforschler@apple.com>
523
524         Update Webkit bots.
525         
526         Unreviewed.
527         
528         * BuildSlaveSupport/build.webkit.org-config/config.json:
529
530 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
531
532         [Win] Unreviewed build fix after r160548
533
534         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj: Specify
535         we are using vs12_xp target for Makefile-based projects.
536
537 2013-12-13  Lucas Forschler  <lforschler@apple.com>
538
539         Update Apple Webkit Bots
540         
541         Unreviewed.
542
543         * BuildSlaveSupport/build.webkit.org-config/config.json:
544
545 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
546
547         Unreviewed build fix after r160548.
548
549         * Scripts/webkitdirs.pm:
550         (setupCygwinEnv): VCExpress.exe is now called WDExpress.exe.
551
552 2013-12-13  Lucas Forschler  <lforschler@apple.com>
553
554         Update Apple bots.
555         
556         Unreviewed.
557
558         * BuildSlaveSupport/build.webkit.org-config/config.json:
559
560 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
561
562         [Win] Switch WebKit solution to Visual Studio 2013
563         https://bugs.webkit.org/show_bug.cgi?id=125192
564
565         Reviewed by Anders Carlsson.
566
567         Project files must reference vs12_xp for 32-bit builds. 
568
569         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
570         Update for VS2013
571         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
572         Ditto
573         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
574         Ditto
575         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
576         Ditto
577         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
578         Ditto
579         * Scripts/webkitdirs.pm:
580         (visualStudioInstallDir): Specify VS2013
581         (visualStudioVersion): Ditto.
582         (setupAppleWinEnv): Use VS2013 in messages
583         (setupCygwinEnv): Ditto
584         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
585         Update for VS2013
586         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
587         Ditto
588         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
589         Ditto
590         * win/record-memory/record-memory.vcxproj:
591         Ditto
592
593 2013-12-11  Martin Robinson  <mrobinson@igalia.com> and Danilo Cesar Lemes de Paula  <danilo.cesar@collabora.co.uk>
594
595         Adding a .ycm_extra_conf file for webkitGtk
596         https://bugs.webkit.org/show_bug.cgi?id=119618
597
598         Reviewed by Gustavo Noronha Silva.
599
600         Added a YouCompleteMe flag discovery script for Vim and the GTK+ port. The script
601         read the GTK+ build files to determine dynamically what flags to compile a source
602         file with. This allows Vim to provide auto-complete for C++/C language. See
603         https://github.com/Valloric/YouCompleteMe for how to use this file.
604
605         * gtk/common.py:
606         (get_build_path): Added a fatal argument to build_path to avoid crashing YCM on failure.
607         * gtk/ycm_extra_conf.py: Added.
608
609 2013-12-12  Tim Horton  <timothy_horton@apple.com>
610
611         [wk2] Handle pinch-to-zoom gesture
612         https://bugs.webkit.org/show_bug.cgi?id=125604
613
614         Reviewed by Simon Fraser.
615
616         * MiniBrowser/mac/WK2BrowserWindowController.m:
617         (-[WK2BrowserWindowController awakeFromNib]):
618         Enable handling of the magnification gesture in Minibrowser WebKit2 windows.
619
620 2013-12-12  Eunmi Lee  <eunmi15.lee@samsung.com>
621
622         Unreviewed. Add myself as a committer.
623
624         * Scripts/webkitpy/common/config/contributors.json:
625
626 2013-12-12  Lucas Forschler  <lforschler@apple.com>
627
628         Update hardware for Apple bots.
629         
630         Unreviewed.
631
632         * BuildSlaveSupport/build.webkit.org-config/config.json:
633
634 2013-12-12  Lucas Forschler  <lforschler@apple.com>
635
636         Remove unused Apple Bots.
637         
638         Unreviewed.
639
640         * BuildSlaveSupport/build.webkit.org-config/config.json:
641
642 2013-12-12  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
643
644         Unreviewed. Add myself as a committer.
645
646         * Scripts/webkitpy/common/config/contributors.json:
647
648 2013-12-12  Joseph Pecoraro  <pecoraro@apple.com>
649
650         Test new JSContext name APIs
651         https://bugs.webkit.org/show_bug.cgi?id=125607
652
653         Reviewed by Darin Adler.
654
655         * Scripts/run-javascriptcore-tests:
656         Remove trailing whitespace.
657
658 2013-12-12  Zan Dobersek  <zdobersek@igalia.com>
659
660         [Autotools] Prepend the WebCore layer archives' names with 'lib'
661         https://bugs.webkit.org/show_bug.cgi?id=125627
662
663         Reviewed by Martin Robinson.
664
665         * TestWebKitAPI/GNUmakefile.am: Libtool can complain about the WebCore layer archives not being prepended
666         with 'lib' when they are used during linking, so the prefix is now added to avoid such issues.
667
668 2013-12-12  Commit Queue  <commit-queue@webkit.org>
669
670         Unreviewed, rolling out r160446.
671         http://trac.webkit.org/changeset/160446
672         https://bugs.webkit.org/show_bug.cgi?id=125630
673
674         The upower-glib-based implementation is using API that was
675         recently removed (Requested by zdobersek1 on #webkit).
676
677         * Scripts/webkitperl/FeatureList.pm:
678
679 2013-12-12  Commit Queue  <commit-queue@webkit.org>
680
681         Unreviewed, rolling out r160417.
682         http://trac.webkit.org/changeset/160417
683         https://bugs.webkit.org/show_bug.cgi?id=125629
684
685         The patch is causing crashes (Requested by zdobersek1 on
686         #webkit).
687
688         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
689         (axObjectEventListener):
690         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
691
692 2013-12-12  Zan Dobersek  <zdobersek@igalia.com>
693
694         Use of ar T option not supported by older binutils
695         https://bugs.webkit.org/show_bug.cgi?id=118732
696
697         Reviewed by Gustavo Noronha Silva.
698
699         * TestWebKitAPI/GNUmakefile.am: To support non-thin archives when generating the WebCoreLayer archive,
700         switch to using the AR_FLAGS variable (which can be overridden) for providing the ar flags for the
701         new archive. Non-thin archives also pose the problem as their members are only noted by the basename
702         of the member's object file, and not the full path to it. To work around that, all the object files
703         under the build directory are listed by their relative paths. The members of various archives then have
704         the basenames of their paths grepped against that list, with the found path correlating to the member
705         finally added as the new member of the WebCoreLayer archive.
706
707 2013-12-11  Myles C. Maxfield  <mmaxfield@apple.com>
708
709         check-webkit-style shouldn't check spacing in #if preprocessor lines
710         https://bugs.webkit.org/show_bug.cgi?id=125534
711
712         Reviewed by Ryosuke Niwa.
713
714         Preprocessor lines that start with #if shouldn't have to adhere to
715         the same spacing requirements that regular code does
716
717         * Scripts/webkitpy/style/checkers/cpp.py:
718         (check_spacing):
719         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
720         (CppStyleTest.test_spacing_for_binary_ops):
721         (WebKitStyleTest.test_line_breaking):
722
723 2013-12-11  Myles C. Maxfield  <mmaxfield@apple.com>
724
725         check-webkit-style can't determine if a comma is part of an initialization list
726         https://bugs.webkit.org/show_bug.cgi?id=125537
727
728         Reviewed by Darin Adler.
729
730         The original check to make sure that initialization list lines start with
731         a comma didn't distinguish between commas that belong to the initialization
732         list and commas that are part of function calls. Because we don't want to
733         match parentheses with regular expressions, we should weaken this check to
734         only check for commas at the end of initialization list lines.
735
736         * Scripts/webkitpy/style/checkers/cpp.py:
737         (check_member_initialization_list):
738         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
739         (WebKitStyleTest.test_member_initialization_list):
740
741 2013-12-11  Tim Horton  <timothy_horton@apple.com>
742
743         Make it possible to compare layout test results between various configurations of WebKit
744         https://bugs.webkit.org/show_bug.cgi?id=125212
745         <rdar://problem/15199108>
746
747         Reviewed by Darin Adler.
748
749         * Scripts/compare-webkit-configurations: Added.
750         Add a script that allows comparison between the "normal" WebKit configuration
751         used for testing and a different configuration (e.g. with accelerated drawing
752         turned on, with the remote layer tree enabled, or WebKit1 vs WebKit2), like so:
753
754         compare-webkit-configurations -2 --comparison=accelerated-drawing compositing/background-color
755
756         This script runs the tests once in the default configuration, ignoring
757         all test expectations, writing the results out to a temporary directory.
758
759         It then runs the tests again in the modified configuration, against the
760         just-written temporary results.
761
762         Ref tests are treated as pixel tests, with their pixel output dumped to disk.
763
764         * DumpRenderTree/mac/DumpRenderTree.mm:
765         (resetWebPreferencesToConsistentValues):
766         (initializeGlobalsFromCommandLineOptions):
767         Enable accelerated drawing if requested.
768
769         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
770         (parse_args):
771         Add --accelerated-drawing and --remote-layer-tree feature switches, which
772         are forwarded on to the test drivers.
773         Move those two and --complex-text into their own "feature switches" section.
774         Drive-by change "Mac OS X" to "OS X".
775         Add --treat-ref-tests-as-pixel-tests option, which treats ref tests
776         as traditional pixel tests (with PNGs dumped on disk), and
777         ignores e.g. -expected.html files.
778
779         * Scripts/webkitpy/port/base.py:
780         (Port.reference_files):
781         Pretend that there are no ref tests.
782         Since is_reference_html_file is intact, our mechanism to ignore
783         the expected files will continue working in this case.
784
785         * Scripts/webkitpy/port/driver.py:
786         (Driver.cmd_line):
787         Forward --accelerated-drawing and --remote-layer-tree to DRT/WKTR.
788
789         * WebKitTestRunner/TestController.cpp:
790         (WTR::TestController::TestController):
791         (WTR::TestController::initialize):
792         (WTR::TestController::resetPreferencesToConsistentValues):
793         * WebKitTestRunner/TestController.h:
794         (WTR::TestController::shouldUseRemoteLayerTree):
795         * WebKitTestRunner/TestInvocation.cpp:
796         (WTR::updateThreadedScrollingForCurrentTest):
797         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
798         (WTR::PlatformWebView::PlatformWebView):
799         Parse and implement the three feature switches.
800
801 2013-12-11  Mario Sanchez Prada  <mario.prada@samsung.com>
802
803         [ATK] Expose accessibility objects WAI-ARIA landmark roles
804         https://bugs.webkit.org/show_bug.cgi?id=125584
805
806         Reviewed by Chris Fleizach.
807
808         Add mappings to DRT & WKTR for landmark roles.
809
810         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
811         (AccessibilityUIElement::role):
812         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
813         (WTR::AccessibilityUIElement::role):
814         * gtk/jhbuild.modules:
815
816 2013-12-11  Alejandro G. Castro  <alex@igalia.com>
817
818         [GTK] Avoid double quotations when passing parameters to valgrind in gtk.py
819         https://bugs.webkit.org/show_bug.cgi?id=125441
820
821         Reviewed by Martin Robinson.
822
823         Just avoid the double quotations when building the parameter
824         because some versions of valgrind are not handling it correctly.
825
826         * Scripts/webkitpy/port/gtk.py:
827         (GtkPort.setup_environ_for_server):
828
829 2013-12-11  Zan Dobersek  <zdobersek@igalia.com>
830
831         [GTK] Enable Battery Status API
832         https://bugs.webkit.org/show_bug.cgi?id=125453
833
834         Reviewed by Martin Robinson.
835
836         * Scripts/webkitperl/FeatureList.pm: Enable the Battery Status API feature for the GTK port.
837
838 2013-12-11  José Dapena Paz  <jdapena@igalia.com> and Zan Dobersek  <zdobersek@igalia.com>
839
840         [GTK][WK2] Add the WebKitBatteryProvider class
841         https://bugs.webkit.org/show_bug.cgi?id=115720
842
843         Reviewed by Martin Robinson.
844
845         * gtk/generate-gtkdoc:
846         (get_webkit2_options): Ignore the WebKitBatteryProvider source files when generating the documentation.
847
848 2013-12-11  Mark Rowe  <mrowe@apple.com>
849
850         <https://webkit.org/b/125563> Remove the DumpRenderTree Perl Support module
851
852         Now that old-run-webkit-tests is not used on OS X it's not worth the time and effort
853         to build and maintain this custom Perl module.
854
855         Reviewed by Anders Carlsson.
856
857         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Remove the target.
858         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c: Removed.
859         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Removed.
860         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Removed.
861         * DumpRenderTree/mac/PerlSupport/Makefile: Removed.
862         * Scripts/old-run-webkit-tests: Update a comment that referred to DumpRenderTreeSupport as a reason to
863         build DumpRenderTree.
864         (dumpToolDidCrash): Stop importing and using the module.
865         * Scripts/webkitpy/port/base.py:
866         (Port._build_driver): Update a comment in the same manner as in old-run-webkit-tests.
867
868 2013-12-11  Brendan Long  <b.long@cablelabs.com>
869
870         [GTK] Add "enable-mediasource" property to WebKitWebSettings
871         https://bugs.webkit.org/show_bug.cgi?id=125566
872
873         Reviewed by Philippe Normand.
874
875         * DumpRenderTree/gtk/DumpRenderTree.cpp:
876         (resetDefaultsToConsistentValues): Turn MediaSource on by default for easier testing.
877         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
878         (TestRunner::overridePreference): Allow overriding WebKitMediaSourceEnabled.
879
880 2013-12-11  Dan Bernstein  <mitz@apple.com>
881
882         [Mac] Observe the activeURL property to keep the MiniBrowser URL field up to date
883         https://bugs.webkit.org/show_bug.cgi?id=125579
884
885         Reviewed by Anders Carlsson.
886
887         * MiniBrowser/mac/WK2BrowserWindowController.m:
888         (-[WK2BrowserWindowController dealloc]): Stop observing the activeURL property.
889         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]): When the
890         activeURL property changes, update the URL field with its value.
891         (-[WK2BrowserWindowController awakeFromNib]): Start observing the activeURL property.
892         (-[WK2BrowserWindowController browsingContextControllerDidStartProvisionalLoad:]): Just log.
893         (-[WK2BrowserWindowController browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]):
894         Ditto.
895         (-[WK2BrowserWindowController browsingContextController:didFailProvisionalLoadWithError:]):
896         Ditto.
897         (-[WK2BrowserWindowController browsingContextControllerDidCommitLoad:]): Ditto.
898         (-[WK2BrowserWindowController browsingContextController:didFailLoadWithError:]): Ditto.
899
900 2013-12-11  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
901
902         Fixed test-wepkitpy logging for buildslaves
903         https://bugs.webkit.org/show_bug.cgi?id=125445
904
905         Reviewed by Csaba Osztrogonác.
906
907         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
908         (RunPythonTests):
909
910 2013-12-11  Mario Sanchez Prada  <mario.prada@samsung.com>
911
912         Programmatically-inserted children lack accessibility events
913         https://bugs.webkit.org/show_bug.cgi?id=100275
914
915         Reviewed by Chris Fleizach.
916
917         Update DRT and WebKitTestRunner to handle the children-changed
918         signal properly, considering the detail and optional parameters.
919
920         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp: Updated.
921         (axObjectEventListener):
922         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Updated.
923
924 2013-12-03  Mark Rowe  <mrowe@apple.com>
925
926         <https://webkit.org/b/125139> Modernize the WebKit API headers
927         <rdar://problem/15540175>
928
929         Reviewed by Anders Carlsson.
930
931         * DumpRenderTree/mac/TestRunnerMac.mm:
932         (TestRunner::setCacheModel): Cast to the enum type.
933
934 2013-12-10  Filip Pizlo  <fpizlo@apple.com>
935
936         Get rid of forward exit on DoubleAsInt32
937         https://bugs.webkit.org/show_bug.cgi?id=125552
938
939         Reviewed by Oliver Hunt.
940         
941         Add some support for testing the generic (non-X86) paths on X86 by disabling
942         architecture-specific optimizations (ASO's).
943
944         * Scripts/run-javascriptcore-tests:
945         * Scripts/run-jsc-stress-tests:
946
947 2013-12-10  Ryuan Choi  <ryuan.choi@samsung.com>
948
949         Unreviewed EFL build fix attempt
950
951         * TestWebKitAPI/CMakeLists.txt: Added ${WEBKIT2_DIR}/Platform/CoreIPC to include lists.
952         * WebKitTestRunner/CMakeLists.txt: Ditto.
953
954 2013-12-10  Anders Carlsson  <andersca@apple.com>
955
956         Add a HashMap constructor that takes an initializer list
957         https://bugs.webkit.org/show_bug.cgi?id=125551
958
959         Reviewed by Dan Bernstein.
960
961         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
962         (TestWebKitAPI::TEST):
963
964 2013-12-10  Laszlo Vidacs  <lac@inf.u-szeged.hu>
965
966         Use std::array when computing MD5 checksum
967         https://bugs.webkit.org/show_bug.cgi?id=125509
968
969         Reviewed by Anders Carlsson.
970
971         Use MD5::Digest type and MD5::hashSize when computing MD5 checksum.
972
973         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
974         (computeMD5HashStringForBitmapContext):
975         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
976         (computeMD5HashStringForBitmapContext):
977         * TestWebKitAPI/Tests/WTF/MD5.cpp:
978         (TestWebKitAPI::expectMD5):
979         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
980         (WTR::computeMD5HashStringForCairoSurface):
981         * WebKitTestRunner/cg/TestInvocationCG.cpp:
982         (WTR::computeMD5HashStringForContext):
983
984 2013-12-10  Mario Sanchez Prada  <mario.prada@samsung.com>
985
986         [ATK] Expose splitter elements with ATK_ROLE_SEPARATOR
987         https://bugs.webkit.org/show_bug.cgi?id=125522
988
989         Reviewed by Chris Fleizach.
990
991         Update strings representing ATK_ROLE_SEPARATOR for layout tests.
992
993         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
994         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
995
996 2013-12-10  Laszlo Vidacs  <lac@inf.u-szeged.hu>
997
998         Add --makeargs option to build-jsc
999         https://bugs.webkit.org/show_bug.cgi?id=125344
1000
1001         Reviewed by Filip Pizlo.
1002
1003         * Scripts/build-jsc: Handle and pass makefile arguments in jsc build.
1004
1005 2013-12-10  Joanmarie Diggs  <jdiggs@igalia.com>
1006
1007         AX: [ATK] Convert the get_text atktest.c unit tests to layout tests
1008         https://bugs.webkit.org/show_bug.cgi?id=125497
1009
1010         Reviewed by Mario Sanchez Prada.
1011
1012         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1013         (AccessibilityUIElement::stringForRange): Implemented.
1014         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1015         (WTR::AccessibilityUIElement::stringForRange): Implemented.
1016
1017 2013-12-10  Martin Robinson  <mrobinson@igalia.com>
1018
1019         Various fixes for the CMake GTK+ build
1020
1021         Reviewed by Gustavo Noronha.
1022
1023         * MiniBrowser/gtk/CMakeLists.txt: Update source list and correct the name of BrowserMarshal.h.
1024         * TestWebKitAPI/PlatformGTK.cmake: Add GTK+ libraries to the test program. They're required.
1025
1026 2013-12-10  László Langó  <lango@inf.u-szeged.hu>
1027
1028         --cloop option does not work in Tools/Scripts/build-jsc.
1029         https://bugs.webkit.org/show_bug.cgi?id=125214
1030
1031         Reviewed by Csaba Osztrogonác.
1032
1033         * Scripts/build-jsc:
1034
1035 2013-12-10  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1036
1037         Merge mark_for_landing and mark_for_commit_queue into one argument
1038         https://bugs.webkit.org/show_bug.cgi?id=125448
1039
1040         Reviewed by Ryosuke Niwa.
1041
1042         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1043         (CommitQueueFlag):
1044         (Bugzilla._commit_queue_flag):
1045         (Bugzilla._fill_attachment_form):
1046         (Bugzilla.add_patch_to_bug):
1047         (Bugzilla.create_bug):
1048         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1049         (test_commit_queue_flag.assert_commit_queue_flag):
1050         (test_commit_queue_flag):
1051
1052 2013-12-09  Tim Horton  <timothy_horton@apple.com>
1053
1054         Remove dead extract_reference_link.py (and the reftests module)
1055         https://bugs.webkit.org/show_bug.cgi?id=125116
1056
1057         Reviewed by Ryosuke Niwa.
1058
1059         This code doesn't seem to have ever been used.
1060
1061         * Scripts/webkitpy/layout_tests/reftests/__init__.py: Removed.
1062         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py: Removed.
1063         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py: Removed.
1064
1065 2013-12-09  Mario Sanchez Prada  <mario.prada@samsung.com>
1066
1067         [ATK] Translate ATK_ROLE_SECTION into "AXSection" in DRT/WKTR
1068         https://bugs.webkit.org/show_bug.cgi?id=125456
1069
1070         Reviewed by Chris Fleizach.
1071
1072         Return 'AXSection' for section roles instead of 'AXDiv'.
1073
1074         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1075         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1076
1077 2013-12-09  Brian J. Burg  <burg@cs.washington.edu>
1078
1079         check-webkit-style should check for extra newlines at EOF
1080         https://bugs.webkit.org/show_bug.cgi?id=125424
1081
1082         Reviewed by Darin Adler.
1083
1084         Report a style violation if extraneous newlines are added
1085         to the end of a C++ file. There should only be one newline at EOF.
1086
1087         * Scripts/webkitpy/style/checkers/cpp.py:
1088         (check_for_missing_new_line_at_eof): Renamed from check_for_new_line_at_eof.
1089         (check_for_extra_new_line_at_eof): Added.
1090         (_process_lines): Added new check and renamed existing EOF check.
1091         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1092         (CppStyleTest.test_extra_newlines_at_eof): Added.
1093         (CppStyleTest.test_extra_newlines_at_eof.do_test): Added.
1094
1095 2013-12-09  Laszlo Vidacs  <lac@inf.u-szeged.hu>
1096
1097         check-webkit-style: ternary operator in macro call identified as initialization list
1098         https://bugs.webkit.org/show_bug.cgi?id=125443
1099
1100         Reviewed by Ryosuke Niwa.
1101
1102         Do not match initialization list when questionmark is placed before :
1103
1104         * Scripts/webkitpy/style/checkers/cpp.py:
1105         (check_member_initialization_list):
1106
1107 2013-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
1108
1109         AX: [ATK] Convert the get_{string,text}_at_offset atktest.c unit tests to layout tests
1110         https://bugs.webkit.org/show_bug.cgi?id=125451
1111
1112         Reviewed by Mario Sanchez Prada.
1113
1114         Create the needed callbacks for DRT and WKTR.
1115
1116         * DumpRenderTree/AccessibilityUIElement.cpp:
1117         (characterAtOffsetCallback): added
1118         (wordAtOffsetCallback): added
1119         (lineAtOffsetCallback): added
1120         (sentenceAtOffsetCallback): added
1121         (AccessibilityUIElement::getJSClass):
1122         * DumpRenderTree/AccessibilityUIElement.h:
1123         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1124         (stringAtOffset): added
1125         (AccessibilityUIElement::characterAtOffset): added
1126         (AccessibilityUIElement::wordAtOffset): added
1127         (AccessibilityUIElement::lineAtOffset): added
1128         (AccessibilityUIElement::sentenceAtOffset): added
1129         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1130         (WTR::AccessibilityUIElement::characterAtOffset): added
1131         (WTR::AccessibilityUIElement::wordAtOffset): added
1132         (WTR::AccessibilityUIElement::lineAtOffset): added
1133         (WTR::AccessibilityUIElement::sentenceAtOffset): added
1134         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1135         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1136         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1137         (WTR::stringAtOffset): added
1138         (WTR::AccessibilityUIElement::characterAtOffset): added
1139         (WTR::AccessibilityUIElement::wordAtOffset): added
1140         (WTR::AccessibilityUIElement::lineAtOffset): added
1141         (WTR::AccessibilityUIElement::sentenceAtOffset): added
1142
1143 2013-12-08  Sam Weinig  <sam@webkit.org>
1144
1145         32-bit MiniBrowser doesn't build
1146         https://bugs.webkit.org/show_bug.cgi?id=125420
1147
1148         Reviewed by Dan Bernstein.
1149
1150         * MiniBrowser/mac/AppDelegate.h:
1151         * MiniBrowser/mac/AppDelegate.m:
1152         (-[BrowserAppDelegate init]):
1153         (-[BrowserAppDelegate applicationWillTerminate:]):
1154
1155 2013-12-08  Brian Holt  <brian.holt@samsung.com>
1156
1157         [WK2] Add ENABLE_NETWORK_PROCESS flag
1158         https://bugs.webkit.org/show_bug.cgi?id=125421
1159
1160         Add support to build with the Network Process enabled.
1161
1162         Reviewed by Martin Robinson.
1163
1164         * Scripts/webkitperl/FeatureList.pm:
1165
1166 2013-12-07  Filip Pizlo  <fpizlo@apple.com>
1167
1168         Fold typedArray.length if typedArray is constant
1169         https://bugs.webkit.org/show_bug.cgi?id=125252
1170
1171         Reviewed by Sam Weinig.
1172         
1173         Add Source/JavaScriptCore/tests/stress to the set of JS tests. This is where you
1174         should put tests that run just like JSRegress but don't run as part of LayoutTests.
1175         Currently I'm using it for tests that require some surgical support from jsc.cpp.
1176
1177         * Scripts/run-javascriptcore-tests:
1178
1179 2013-12-08  Zan Dobersek  <zdobersek@igalia.com>
1180
1181         [gdb] Update printers for WTF::CString, JSC::JSString
1182         https://bugs.webkit.org/show_bug.cgi?id=124600
1183
1184         Reviewed by Gustavo Noronha Silva.
1185
1186         Update the two printers after they fell behind the changes in implementation.
1187
1188         * gdb/webkit.py:
1189         (WTFCStringPrinter.to_string):
1190         (JSCJSStringPrinter.to_string):
1191
1192 2013-12-08  Zan Dobersek  <zdobersek@igalia.com>
1193
1194         [webkitpy] Add a WestonDriver unit test
1195         https://bugs.webkit.org/show_bug.cgi?id=125408
1196
1197         Reviewed by Gustavo Noronha Silva.
1198
1199         Add a webkitpy unit test for the Weston driver.
1200
1201         * Scripts/webkitpy/port/westondriver_unittest.py: Added.
1202         (WestonDriverTest):
1203         (WestonDriverTest.make_driver): Sets up a new WestonDriver instance for testing purposes.
1204         (WestonDriverTest.test_start): Check that the Weston compositor is launched properly and that
1205         the server environment contains proper WAYLAND and GDK_BACKEND entries.
1206         (WestonDriverTest.test_stop): Check that the Weston compositor is terminated properly and that
1207         the driver cleans up the temporary directory.
1208         (WestonDriverTest.test_stop.FakeWestonProcess): A helper class that logs the expected termination.
1209         (WestonDriverTest.test_stop.FakeWestonProcess.terminate):
1210
1211 2013-12-08  Brendan Long  <b.long@cablelabs.com>
1212
1213         [Gtk] install-dependencies doesn't install libgtk-3-dev
1214         https://bugs.webkit.org/show_bug.cgi?id=125320
1215
1216         Reviewed by Gustavo Noronha Silva.
1217
1218         * gtk/install-dependencies: Add libgtk-3-dev, libsoup2.4 and subversion
1219
1220 2013-12-07  Sam Weinig  <sam@webkit.org>
1221
1222         [Cocoa] Convert a few more parts of MiniBrowser over to the Objective-C API
1223         https://bugs.webkit.org/show_bug.cgi?id=125401
1224
1225         Reviewed by Dan Bernstein.
1226
1227         * MiniBrowser/mac/WK2BrowserWindowController.m:
1228         (-[WK2BrowserWindowController fetch:]):
1229         (-[WK2BrowserWindowController reload:]):
1230         (-[WK2BrowserWindowController goBack:]):
1231         (-[WK2BrowserWindowController goForward:]):
1232         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
1233         (-[WK2BrowserWindowController currentZoomFactor]):
1234         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
1235         (-[WK2BrowserWindowController zoomIn:]):
1236         (-[WK2BrowserWindowController zoomOut:]):
1237         (-[WK2BrowserWindowController canResetZoom]):
1238         (-[WK2BrowserWindowController resetZoom:]):
1239         (-[WK2BrowserWindowController toggleZoomMode:]):
1240         (-[WK2BrowserWindowController updateTextFieldFromURL:]):
1241
1242 2013-12-07  Sam Weinig  <sam@webkit.org>
1243
1244         Convert MiniBrowser to use WKProcessGroup and WKBrowsingContextGroup
1245         https://bugs.webkit.org/show_bug.cgi?id=125400
1246
1247         Reviewed by Dan Bernstein.
1248
1249         * MiniBrowser/mac/AppDelegate.h:
1250         * MiniBrowser/mac/AppDelegate.m:
1251         * MiniBrowser/mac/WK2BrowserWindowController.h:
1252         * MiniBrowser/mac/WK2BrowserWindowController.m:
1253         (-[WK2BrowserWindowController initWithProcessGroup:browsingContextGroup:]):
1254         (-[WK2BrowserWindowController dealloc]):
1255         (createNewPage):
1256         (-[WK2BrowserWindowController awakeFromNib]):
1257         (-[WK2BrowserWindowController browsingContextController:didNavigateWithNavigationData:]):
1258         (-[WK2BrowserWindowController browsingContextController:didPerformClientRedirectFromURL:toURL:]):
1259         (-[WK2BrowserWindowController browsingContextController:didPerformServerRedirectFromURL:toURL:]):
1260         (-[WK2BrowserWindowController browsingContextController:didUpdateHistoryTitle:forURL:]):
1261         Replace global WKContextRef and WKPageGroupRef with WKProcessGroup and WKBrowsingContextGroup. Also
1262         replace context based WKContextHistoryClient with WKBrowsingContextController based WKBrowsingContextHistoryDelegate
1263
1264 2013-12-07  Gustavo Noronha Silva  <gns@gnome.org>
1265
1266         [GTK] Run each gtest subtest separately instead of in one go
1267         https://bugs.webkit.org/show_bug.cgi?id=125386
1268
1269         Reviewed by Martin Robinson.
1270
1271         This is what other ports are doing (except they build each test as a separate binary)
1272         and will help with the timeouts we sometimes hit because it applies to the full test
1273         run.
1274
1275         * Scripts/run-gtk-tests:
1276         (TestRunner._get_tests_from_google_test_suite): get a list of available sub-tests.
1277         (TestRunner._run_google_test): run a single subtest from a gtest binary.
1278         (TestRunner._run_google_test_suite): call the binary once per subtest.
1279
1280 2013-12-07  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1281
1282         Move PrettyPatch related code to prettypatch.py
1283         https://bugs.webkit.org/show_bug.cgi?id=124937
1284
1285         Reviewed by Ryosuke Niwa.
1286
1287         This code seems to have a better place here than in Port, since PrettyPatch already knows
1288         pretty_patch_path, and this also unifies the usage of PrettyPatch
1289
1290         * Scripts/webkitpy/common/prettypatch.py:
1291         (PrettyPatch.__init__):
1292         (PrettyPatch.pretty_diff):
1293         (PrettyPatch):
1294         (PrettyPatch.pretty_patch_available):
1295         (PrettyPatch.check_pretty_patch):
1296         (PrettyPatch.pretty_patch_text):
1297         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1298         (TestResultWriter.create_text_diff_and_write_result):
1299         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1300         (summarize_results):
1301         * Scripts/webkitpy/port/base.py:
1302         (Port.__init__):
1303         (Port.wdiff_available):
1304         (Port.check_image_diff):
1305         (Port.wdiff_text):
1306         * Scripts/webkitpy/port/base_unittest.py:
1307         (PortTest.test_pretty_patch_os_error):
1308         (PortTest.test_pretty_patch_script_error):
1309
1310 2013-12-06  Dan Bernstein  <mitz@apple.com>
1311
1312         [Mac] MiniBrowser Debug builds are compiled with -Os
1313         https://bugs.webkit.org/show_bug.cgi?id=125376
1314
1315         Reviewed by Tim Horton.
1316
1317         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Set GCC_OPTIMIZATION_LEVEL to 0 for
1318         the Debug configuration at the project level.
1319
1320 2013-12-06  Jer Noble  <jer.noble@apple.com>
1321
1322         [MSE] Add a runtime-setting for the MediaSource constructor.
1323         https://bugs.webkit.org/show_bug.cgi?id=125336
1324
1325         Reviewed by Eric Carlson.
1326
1327         Enable MediaSource in DRT and WKTR.
1328
1329         * DumpRenderTree/mac/DumpRenderTree.mm:
1330         (resetWebPreferencesToConsistentValues):
1331         * WebKitTestRunner/TestController.cpp:
1332         (WTR::TestController::resetPreferencesToConsistentValues):
1333
1334 2013-12-06  Jer Noble  <jer.noble@apple.com>
1335
1336         Strip out extraneous logging from AppleGVA in media tests.
1337         https://bugs.webkit.org/show_bug.cgi?id=125357
1338
1339         Reviewed by Simon Fraser.
1340
1341         Add a mechanism for stripping out abritrary regular expressions from test input and output.
1342
1343         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1344         (SingleTestRunner._run_compare_test): Strip out logging
1345         * Scripts/webkitpy/port/base.py:
1346         (Port.logging_patterns_to_strip): Return an empty list by default.
1347         * Scripts/webkitpy/port/driver.py:
1348         (DriverOutput.strip_patterns): Apply the port specific patterns to the text.
1349         * Scripts/webkitpy/port/mac.py:
1350         (MacPort.logging_patterns_to_strip): Return a complete list.
1351
1352 2013-12-06  Dean Jackson  <dino@apple.com>
1353
1354         Updating ANGLE should point to instructions
1355         https://bugs.webkit.org/show_bug.cgi?id=125361
1356
1357         Reviewed by Eric Carlson.
1358
1359         Point to https://trac.webkit.org/wiki/UpdatingANGLE when
1360         someone wants to patch ANGLE.
1361
1362         * Scripts/webkitpy/common/config/watchlist:
1363
1364 2013-12-06  Dan Bernstein  <mitz@apple.com>
1365
1366         [Mac] Transition MiniBrowser to the Cocoa API: load delegate
1367         https://bugs.webkit.org/show_bug.cgi?id=125334
1368
1369         Reviewed by Darin Adler.
1370
1371         * MiniBrowser/mac/WK2BrowserWindowController.m:
1372         (-[WK2BrowserWindowController dealloc]): Nil out the load delegate and stop observing the
1373         title property.
1374         (-[WK2BrowserWindowController isPaginated]): Changed to use Cocoa SPI.
1375         (-[WK2BrowserWindowController togglePaginationMode:]): Ditto.
1376         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]): Update the
1377         window title with the title property changes.
1378         (-[WK2BrowserWindowController awakeFromNib]): Start observing the title property. Changed to
1379         set the load delegate instead of the load client.
1380         (-[WK2BrowserWindowController updateTextFieldFromURL:]): Changed to use Cocoa types.
1381         (-[WK2BrowserWindowController updateProvisionalURL]): Removed frame parameter.
1382         (-[WK2BrowserWindowController updateCommittedURL]): Ditto.
1383         (-[WK2BrowserWindowController browsingContextControllerDidStartProvisionalLoad:]):
1384         Implemented this load delegate method.
1385         (-[WK2BrowserWindowController browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]):
1386         Ditto.
1387         (-[WK2BrowserWindowController browsingContextController:didFailProvisionalLoadWithError:]): Ditto.
1388         (-[WK2BrowserWindowController browsingContextControllerDidCommitLoad:]): Ditto.
1389         (-[WK2BrowserWindowController browsingContextControllerDidFinishLoad:]): Ditto.
1390         (-[WK2BrowserWindowController browsingContextController:didFailLoadWithError:]): Ditto.
1391         (-[WK2BrowserWindowController browsingContextControllerDidChangeBackForwardList:addedItem:removedItems:]):
1392         Ditto.
1393         (-[WK2BrowserWindowController browsingContextController:canAuthenticateAgainstProtectionSpace:]):
1394         Ditto.
1395         (-[WK2BrowserWindowController browsingContextController:didReceiveAuthenticationChallenge:]): Ditto.
1396
1397 2013-12-06  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1398
1399         Remove function from style/checkers/cpp.py.
1400         https://bugs.webkit.org/show_bug.cgi?id=125341
1401
1402         Reviewed by Darin Adler.
1403
1404         Corrects a FIXME: by removing a function from cpp.py.
1405
1406         * Scripts/webkitpy/style/checkers/cpp.py:
1407         (CppChecker.__init__):
1408         (CppChecker.check):
1409         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1410         (CppStyleTestBase.process_file_data):
1411
1412 2013-12-06  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
1413
1414         check-webkit-style: false positive warning for indentation of #ifdef code.
1415         https://bugs.webkit.org/show_bug.cgi?id=125254
1416
1417         Reviewed by Darin Adler.
1418
1419         * Scripts/webkitpy/style/checkers/cpp.py:
1420         (check_member_initialization_list):
1421         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1422         (WebKitStyleTest.test_member_initialization_list):
1423
1424 2013-12-06  Chris Fleizach  <cfleizach@apple.com>
1425
1426         Fix spelling error in style checker: beggining
1427         https://bugs.webkit.org/show_bug.cgi?id=125347
1428
1429         Reviewed by Anders Carlsson.
1430
1431         * Scripts/webkitpy/style/checkers/cpp.py:
1432         (check_member_initialization_list):
1433         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1434         (WebKitStyleTest.test_member_initialization_list):
1435
1436 2013-12-06  Lukasz Gajowy  <l.gajowy@samsung.com>
1437
1438         [ATK] Missing aria roles mappings
1439         https://bugs.webkit.org/show_bug.cgi?id=117729
1440
1441         Reviewed by Mario Sanchez Prada.
1442
1443         Added new mappings to AccessibilityUIElementAtk.cpp.
1444
1445         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1446         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1447
1448 2013-12-06  Csaba Osztrogonác  <ossy@webkit.org>
1449
1450         Typo fix after r160218.
1451
1452         * Scripts/webkitpy/test/main.py:
1453         (main):
1454
1455 2013-12-06  Csaba Osztrogonác  <ossy@webkit.org>
1456
1457         Unreviewed fix after r160206.
1458
1459         * Scripts/webkitpy/test/main.py:
1460         (main): sys.platform can be win32 or cygwin too on Windows.
1461
1462 2013-12-05  Csaba Osztrogonác  <ossy@webkit.org>
1463
1464         Disable WebKit2 webkitpy unittests on Windows
1465         https://bugs.webkit.org/show_bug.cgi?id=125318
1466
1467         Reviewed by Ryosuke Niwa.
1468
1469         * Scripts/webkitpy/test/main.py:
1470         (main):
1471
1472 2013-12-05  Anders Carlsson  <andersca@apple.com>
1473
1474         Tweak WeakObjCPtr
1475         https://bugs.webkit.org/show_bug.cgi?id=125311
1476
1477         Reviewed by Darin Adler.
1478
1479         Split up tests into more logical groups. Add new tests for new functionality.
1480
1481         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm:
1482
1483 2013-12-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1484
1485         [GTK] Fix gtk-doc warnings when generating DOM bindings API docs
1486         https://bugs.webkit.org/show_bug.cgi?id=125302
1487
1488         Reviewed by Philippe Normand.
1489
1490         * gtk/generate-webkitdom-doc-files:
1491         (WebKitDOMDocGeneratorSections.write_footer): Add a new section
1492         containing a private subsection for WEBKIT_API, WEBKIT_DEPRECATED
1493         and WEBKIT_DEPRECATED_FOR macros.
1494
1495 2013-12-05  Laszlo Vidacs  <lac@inf.u-szeged.hu>
1496
1497         Fix cross compilation on x86
1498         https://bugs.webkit.org/show_bug.cgi?id=125295
1499
1500         Reviewed by Zoltan Herczeg.
1501
1502         Certain compiler flags should not be added when cross compilation is enabled.
1503
1504         * Scripts/webkitdirs.pm:
1505         (runAutogenForAutotoolsProjectIfNecessary):
1506         (generateBuildSystemFromCMakeProject):
1507
1508 2013-12-05  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1509
1510         Remove duplicated/dead code from cpp style checker unit tests.
1511         https://bugs.webkit.org/show_bug.cgi?id=125226
1512
1513         Reviewed by Ryosuke Niwa.
1514
1515         Remove the first definition of OrderOfIncludesTest class as it is
1516         overwritten by the second. Remove a duplicated assert statement
1517         from the second class.
1518
1519         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1520         (OrderOfIncludesTest.setUp):
1521         (OrderOfIncludesTest.test_try_drop_common_suffixes):
1522           The last assert was duplicated.
1523
1524 2013-12-05  László Langó  <lango@inf.u-szeged.hu>
1525
1526         Remove Scripts/generate-qt-inspector-resource.
1527         https://bugs.webkit.org/show_bug.cgi?id=125288
1528
1529         Reviewed by Andreas Kling.
1530
1531         * Scripts/generate-qt-inspector-resource: Removed. There is no QT anymore.
1532         We don't need this file.
1533
1534 2013-12-05  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1535
1536         Remove certain methods from TestExpectations and use TestExpectationsModel instead of them
1537         https://bugs.webkit.org/show_bug.cgi?id=125218
1538
1539         Reviewed by Ryosuke Niwa.
1540
1541         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1542         (LayoutTestFinder.skip_tests):
1543         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1544         (LayoutTestRunner.run_tests):
1545         (LayoutTestRunner._update_summary_with_result):
1546         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1547         (Manager._test_is_slow):
1548         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1549         (JSONLayoutResultsGenerator._insert_failure_summaries):
1550         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1551         (TestExpectations.get_rebaselining_failures):
1552         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1553         (assert_exp):
1554         (MiscTests.test_multiple_results):
1555         (MiscTests.test_category_expectations):
1556         (MiscTests.test_get_modifiers):
1557         (MiscTests.test_get_expectations_string):
1558         (MiscTests.test_expectation_to_string):
1559         (MiscTests.test_get_test_set):
1560         (MiscTests.test_more_specific_override_resets_skip):
1561         (SkippedTests.check):
1562         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1563         (TestRunResults.__init__):
1564         (summarize_results):
1565         * Scripts/webkitpy/tool/commands/rebaseline.py:
1566         (RebaselineExpectations._tests_to_rebaseline):
1567
1568 2013-12-04  Ryosuke Niwa  <rniwa@webkit.org>
1569
1570         Enable HTMLTemplateElement by default
1571         https://bugs.webkit.org/show_bug.cgi?id=123851
1572
1573         Reviewed by Antti Koivisto.
1574
1575         * Scripts/webkitperl/FeatureList.pm:
1576
1577 2013-12-04  Jozsef Berta  <jberta@inf.u-szeged.hu>
1578
1579         [EFL] Bumping GStreamer version to 1.2.1
1580         https://bugs.webkit.org/show_bug.cgi?id=125155
1581
1582         Reviewed by Gyuyoung Kim.
1583
1584         * efl/jhbuild.modules: Set the GStreamer version to 1.2.1
1585
1586
1587 2013-12-04  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1588
1589         Update jhbuild revision.
1590         https://bugs.webkit.org/show_bug.cgi?id=124966
1591         
1592         Reviewed by Gyuyoung Kim.
1593
1594         Used version of Jhbuild failed to create directories and caused
1595         update-webkitefl-libs to fail. Latest Jhbuild version has it fixed.
1596
1597         * jhbuild/jhbuild-wrapper:
1598
1599 2013-12-04  Anders Carlsson  <andersca@apple.com>
1600
1601         Add a WeakObjCPtr class
1602         https://bugs.webkit.org/show_bug.cgi?id=125267
1603
1604         Reviewed by Geoffrey Garen.
1605
1606         Add API tests for WeakObjCPtr.
1607
1608         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1609         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm: Added.
1610         (TEST):
1611
1612 2013-12-04  Anders Carlsson  <andersca@apple.com>
1613
1614         Make the estimatedProgress property observable using KVO
1615         https://bugs.webkit.org/show_bug.cgi?id=125259
1616
1617         Reviewed by Dan Bernstein.
1618
1619         Bind the progress indicator value to the "estimatedProgress" property.
1620
1621         * MiniBrowser/mac/WK2BrowserWindowController.m:
1622         (-[WK2BrowserWindowController dealloc]):
1623         (-[WK2BrowserWindowController awakeFromNib]):
1624
1625 2013-12-04  Anders Carlsson  <andersca@apple.com>
1626
1627         Add a loading property to WKBrowsingContextController
1628         https://bugs.webkit.org/show_bug.cgi?id=125256
1629
1630         Reviewed by Dan Bernstein.
1631
1632         Bind the progress indicator visibility to the "loading" property.
1633
1634         * MiniBrowser/mac/WK2BrowserWindowController.m:
1635         (-[WK2BrowserWindowController dealloc]):
1636         (-[WK2BrowserWindowController awakeFromNib]):
1637         (-[WK2BrowserWindowController didStartProgress]):
1638         (-[WK2BrowserWindowController didFinishProgress]):
1639
1640 2013-12-04  Nick Diego Yamane  <nick.yamane@openbossa.org>
1641
1642         [EFL][WK2] Buildfix after r160104
1643         https://bugs.webkit.org/show_bug.cgi?id=125231
1644
1645         Reviewed by Anders Carlsson.
1646
1647         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
1648         (TestWebKitAPI::TEST): reinterpret_cast<WKFooClientBase*>(&client) -> &client.base
1649         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1650         (TestWebKitAPI::setViewClient): Ditto.
1651
1652 2013-12-04  Myles C. Maxfield  <mmaxfield@apple.com>
1653
1654         check-webkit-style detected some ternary statements as initialization lists
1655         https://bugs.webkit.org/show_bug.cgi?id=125246
1656
1657         Reviewed by Dean Jackson.
1658
1659         The regular expression that check-webkit-tests uses to detect initialization
1660         lists was too broad, resulting in false positives. This patch makes the
1661         regex more specific
1662
1663         * Scripts/webkitpy/style/checkers/cpp.py:
1664         (check_member_initialization_list):
1665         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1666         (WebKitStyleTest.test_member_initialization_list):
1667
1668 2013-12-04  Mark Hahnenberg  <mhahnenberg@apple.com>
1669
1670         run-jsc-stress-tests can only run locally
1671         https://bugs.webkit.org/show_bug.cgi?id=124551
1672
1673         Reviewed by Filip Pizlo.
1674
1675         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Fixed a couple issues. One was if the script was
1676         killed before the lock directory was removed, future executions wouldn't make any progress. Also 
1677         added a couple more signals to handle gracefully at shutdown. 
1678         * Scripts/run-javascriptcore-tests: Pass through the --remote argument to run-jsc-stress-tests.
1679         * Scripts/run-jsc-stress-tests: Added support for the --remote flag. It accepts a hostname, user, and port.
1680         The script then generates the test bundle, tars it up, and copies it to the remote host via ssh where
1681         it then untars the bundle and executes the shell-based test runner. Also refactored some of the logic
1682         toward the end of the script to make it easier to tell which of the various modes do what.
1683
1684 2013-12-04  Csaba Osztrogonác  <ossy@webkit.org>
1685
1686         [EFL][WK2] Buildfix after r160104
1687         https://bugs.webkit.org/show_bug.cgi?id=125233
1688
1689         Reviewed by Anders Carlsson.
1690
1691         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
1692         (TestWebKitAPI::TEST):
1693         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1694         (TestWebKitAPI::setPageLoaderClient):
1695
1696 2013-12-03  Anders Carlsson  <andersca@apple.com>
1697
1698         Deprecate all unversioned client structs in favor of having explicit versioned structs
1699         https://bugs.webkit.org/show_bug.cgi?id=125203
1700
1701         Reviewed by Dan Bernstein.
1702
1703         Update for WebKit2 API changes.
1704
1705         * MiniBrowser/mac/AppDelegate.m:
1706         (-[BrowserAppDelegate init]):
1707         * MiniBrowser/mac/WK2BrowserWindowController.m:
1708         (-[WK2BrowserWindowController awakeFromNib]):
1709         * TestWebKitAPI/InjectedBundleController.cpp:
1710         (TestWebKitAPI::InjectedBundleController::initialize):
1711         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
1712         (TestWebKitAPI::TEST):
1713         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
1714         (TestWebKitAPI::setInjectedBundleClient):
1715         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp:
1716         (TestWebKitAPI::TEST):
1717         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
1718         (TestWebKitAPI::TEST):
1719         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
1720         (TestWebKitAPI::TEST):
1721         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
1722         (TestWebKitAPI::DOMWindowExtensionBasic::didCreatePage):
1723         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
1724         (TestWebKitAPI::TEST):
1725         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
1726         (TestWebKitAPI::DOMWindowExtensionNoCache::didCreatePage):
1727         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp:
1728         (TestWebKitAPI::setInjectedBundleClient):
1729         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
1730         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
1731         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
1732         (TestWebKitAPI::TEST):
1733         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1734         (TestWebKitAPI::TEST):
1735         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
1736         (TestWebKitAPI::setContextDownloadClient):
1737         (TestWebKitAPI::setPagePolicyClient):
1738         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1739         (TestWebKitAPI::TEST):
1740         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
1741         (TestWebKitAPI::TEST):
1742         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
1743         (TestWebKitAPI::TEST):
1744         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
1745         (TestWebKitAPI::TEST):
1746         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
1747         (TestWebKitAPI::TEST):
1748         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
1749         (TestWebKitAPI::TEST):
1750         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1751         (TestWebKitAPI::setupGeolocationProvider):
1752         (TestWebKitAPI::setupView):
1753         (TestWebKitAPI::TEST):
1754         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
1755         (TestWebKitAPI::TEST):
1756         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
1757         (TestWebKitAPI::setPageLoaderClient):
1758         (TestWebKitAPI::setInjectedBundleClient):
1759         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
1760         (TestWebKitAPI::HitTestResultNodeHandleTest::didCreatePage):
1761         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
1762         (TestWebKitAPI::TEST):
1763         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
1764         (TestWebKitAPI::setInjectedBundleClient):
1765         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
1766         (TestWebKitAPI::InjectedBundleFrameHitTestTest::didCreatePage):
1767         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
1768         (TestWebKitAPI::TEST):
1769         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
1770         (TestWebKitAPI::TEST):
1771         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1772         (TestWebKitAPI::TEST):
1773         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
1774         (TestWebKitAPI::TEST):
1775         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
1776         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::didCreatePage):
1777         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
1778         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
1779         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
1780         (TestWebKitAPI::setPageLoaderClient):
1781         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
1782         (TestWebKitAPI::setPageLoaderClient):
1783         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1784         (TestWebKitAPI::setPageLoaderClient):
1785         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
1786         (TestWebKitAPI::setPageLoaderClient):
1787         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1788         (TestWebKitAPI::setPageLoaderClient):
1789         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1790         (TestWebKitAPI::TEST):
1791         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1792         (TestWebKitAPI::TEST):
1793         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
1794         (TestWebKitAPI::setInjectedBundleClient):
1795         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
1796         (TestWebKitAPI::ParentFrameTest::didCreatePage):
1797         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
1798         (TestWebKitAPI::setInjectedBundleClient):
1799         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
1800         (TestWebKitAPI::PasteboardNotificationsTest::didCreatePage):
1801         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1802         (TestWebKitAPI::TEST):
1803         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
1804         (TestWebKitAPI::TEST):
1805         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
1806         (TestWebKitAPI::TEST):
1807         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
1808         (TestWebKitAPI::TEST):
1809         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
1810         (TestWebKitAPI::setInjectedBundleClient):
1811         (TestWebKitAPI::setPageLoaderClient):
1812         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
1813         (TestWebKitAPI::setPageLoaderClient):
1814         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
1815         (TestWebKitAPI::TEST):
1816         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
1817         (TestWebKitAPI::setPageLoaderClient):
1818         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
1819         (TestWebKitAPI::ShouldGoToBackForwardListItemTest::didCreatePage):
1820         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1821         (TestWebKitAPI::TEST):
1822         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp:
1823         (TestWebKitAPI::TEST):
1824         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
1825         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setInjectedBundleClient):
1826         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
1827         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp:
1828         (TestWebKitAPI::TEST):
1829         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp:
1830         (TestWebKitAPI::WKConnectionTest::initialize):
1831         * TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp:
1832         (TestWebKitAPI::setPageLoaderClient):
1833         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
1834         (TestWebKitAPI::setInjectedBundleClient):
1835         (TestWebKitAPI::TEST):
1836         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
1837         (TestWebKitAPI::WebKit2WillLoadTest::setInjectedBundleClient):
1838         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
1839         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp:
1840         (TestWebKitAPI::setInjectedBundleClient):
1841         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
1842         (TestWebKitAPI::WillSendSubmitEventTest::didCreatePage):
1843         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
1844         (TestWebKitAPI::TEST):
1845         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
1846         (TestWebKitAPI::setInjectedBundleClient):
1847         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1848         (TestWebKitAPI::TEST):
1849         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
1850         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
1851         (TestWebKitAPI::DenyWillSendRequestTest::didCreatePage):
1852         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
1853         (TestWebKitAPI::didCreateConnection):
1854         (TestWebKitAPI::TEST):
1855         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1856         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
1857         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm:
1858         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1859         (TestWebKitAPI::setPageLoaderClient):
1860         * WebKitTestRunner/GeolocationProviderMock.cpp:
1861         (WTR::GeolocationProviderMock::GeolocationProviderMock):
1862         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1863         (WTR::InjectedBundle::initialize):
1864         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1865         (WTR::InjectedBundlePage::InjectedBundlePage):
1866         * WebKitTestRunner/TestController.cpp:
1867         (WTR::TestController::createOtherPage):
1868         (WTR::TestController::initialize):
1869         (WTR::TestController::createWebViewWithOptions):
1870
1871 2013-12-04  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1872
1873         Style checker for .messages.in files (WTF:: prefix)
1874         https://bugs.webkit.org/show_bug.cgi?id=125142
1875
1876         Reviewed by Anders Carlsson.
1877
1878         A new style checker for .messages.in files, that checks for the use of WTF::
1879         prefix in these files. (Also checks for tabs as these files were previously
1880         handled as text files.)
1881
1882         * Scripts/webkitpy/style/checker.py:
1883         (CheckerDispatcher._create_checker):
1884           New checker is returned for .messages.in files.
1885         * Scripts/webkitpy/style/checkers/messagesin.py: Added.
1886           The new style checker class.
1887         (MessagesInChecker):
1888         (MessagesInChecker.__init__):
1889         (MessagesInChecker.check):
1890         (MessagesInChecker.check_WTF_prefix):
1891         * Scripts/webkitpy/style/checkers/messagesin_unittest.py: Added.
1892           Unit test for the new style  checker class.
1893         (MessagesInCheckerStyleTestCase):
1894         (test_checker):
1895         (test_checker.error_handler_for_test):
1896         (MessagesInCheckerTestCase):
1897         (MessagesInCheckerTestCase.test_init):
1898         (MessagesInCheckerTestCase.test_init.error_handler_for_test):
1899
1900 2013-12-04  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
1901
1902         Style checker requires alphabetical ordering in cmake lists even it contains variable.
1903         https://bugs.webkit.org/show_bug.cgi?id=124918
1904
1905         Reviewed by Csaba Osztrogonác.
1906
1907         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
1908         (CMakeCheckerTest.test_check):
1909         * Scripts/webkitpy/style/checkers/cmake.py:
1910         (CMakeChecker._check_list_order):
1911         This will ignore lines with variable substitution.
1912
1913 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
1914
1915         check-webkit-style is wrong about expected format parameter pack rvalue reference arguments
1916         https://bugs.webkit.org/show_bug.cgi?id=124731
1917
1918         Reviewed by Zoltan Herczeg.
1919
1920         * Scripts/webkitpy/style/checkers/cpp.py:
1921         (check_spacing):
1922         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1923         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack):
1924
1925 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
1926
1927         Remove codecs and os dependencies from filereader.py in webkitpy/style.
1928         https://bugs.webkit.org/show_bug.cgi?id=124719
1929
1930         Although TextFileReader requires a FileSystem it circumvents it in two places!
1931         We should use the FileSystem only and remove codecs and os imports.
1932
1933         Reviewed by Zoltan Herczeg.
1934
1935         * Scripts/webkitpy/common/system/filesystem.py:
1936         (FileSystem.open_stdin): Moved from TextFileReader
1937         * Scripts/webkitpy/style/filereader.py:
1938         (TextFileReader._read_lines): use FileSystem instead of calling codecs.open directly
1939         (TextFileReader._process_directory): use FileSystem instead of calling os.walk directly
1940
1941 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
1942
1943         check-webkit-style should check member initialization indentation.
1944         https://bugs.webkit.org/show_bug.cgi?id=124820
1945
1946         Reviewed by Zoltan Herczeg.
1947
1948         check-webkit-style should check member initialization indentation
1949         belongs to webkit coding style:
1950         http://www.webkit.org/coding/coding-style.html#punctuation-member-init
1951
1952         * Scripts/webkitpy/style/checkers/cpp.py:
1953         (check_member_initialization_list): Add new method to check member
1954         initialization list.
1955         (check_style): Add the call of the new method.
1956         (check_language): Move self initialization checking into the new method.
1957         (CppChecker): Add a new category for initialization list.
1958         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1959         (CppStyleTest.test_runtime_selfinit):
1960         (CppStyleTest.test_deprecated_cast):
1961         (WebKitStyleTest.test_member_initialization_list): Add new testcases for
1962         the new feature.
1963
1964 2013-12-04  Tamas Gergely  <gertom@inf.u-szeged.hu>
1965
1966         style-bot should reject Committer additions to committers.py
1967         https://bugs.webkit.org/show_bug.cgi?id=107574
1968
1969         Reviewed by Zoltan Herczeg.
1970
1971         The style check when executed in non-interactive mode (probably by a
1972         bot) will raise an additional error if the contributors.json file is
1973         modified. Non-interactive mode information is propagated to the
1974         Dispatcher, which creates a special JSON checker for the
1975         contributors.json file.
1976
1977         * Scripts/webkitpy/style/checker.py:
1978         (check_webkit_style_configuration):
1979         (CheckerDispatcher._create_checker):
1980         (CheckerDispatcher.dispatch):
1981         (StyleProcessorConfiguration.__init__):
1982         (StyleProcessor.process):
1983         * Scripts/webkitpy/style/checker_unittest.py:
1984         (CheckerDispatcherSkipTest._assert_should_skip_without_warning):
1985         (CheckerDispatcherDispatchTest.dispatch):
1986         (StyleProcessorConfigurationTest._style_checker_configuration):
1987         (StyleProcessor_EndToEndTest.test_init):
1988         (StyleProcessor_EndToEndTest.test_process):
1989         (StyleProcessor_CodeCoverageTest.MockDispatcher.dispatch):
1990         (StyleProcessor_CodeCoverageTest.setUp):
1991         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1992         (JSONChecker.line_number_from_json_exception):
1993         (JSONContributorsChecker):
1994         (JSONContributorsChecker.check):
1995         * Scripts/webkitpy/style/error_handlers_unittest.py:
1996         (DefaultStyleErrorHandlerTest._style_checker_configuration):
1997         * Scripts/webkitpy/style/optparser.py:
1998         (CommandOptionValues.__init__):
1999         (ArgumentParser._create_option_parser):
2000         (ArgumentParser.parse):
2001         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2002         (test_post):
2003         (test_upload):
2004         * Scripts/webkitpy/tool/steps/checkstyle.py:
2005         (CheckStyle.run):
2006
2007 2013-12-04  Nick Diego Yamane  <nick.yamane@openbossa.org>
2008
2009         [EFL][WK2] Fix build after API::Client changes
2010         https://bugs.webkit.org/show_bug.cgi?id=125206
2011
2012         Reviewed by Csaba Osztrogonác.
2013
2014         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
2015         (TestWebKitAPI::TEST):
2016         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
2017         (TestWebKitAPI::setViewClient):
2018
2019 2013-12-03  Dan Bernstein  <mitz@apple.com>
2020
2021         Fixed a test timing out after r160040.
2022
2023         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
2024         (-[SimpleLoadFailDelegate browsingContextController:didFailProvisionalLoadWithError:]):
2025         Updated for the delegate method rename.
2026
2027 2013-12-03  Filip Pizlo  <fpizlo@apple.com>
2028
2029         REGRESSION: repro scripts disappear when you rerun tests
2030         https://bugs.webkit.org/show_bug.cgi?id=125184
2031
2032         Reviewed by Mark Hahnenberg.
2033         
2034         This bug made it difficult to quickly see if a test that recently failed is still
2035         failing while also running a new batch of tests.
2036
2037         Repro scripts are supposed to stay around until you delete them explicitly. This
2038         patch accomplishes that.
2039
2040         * Scripts/run-jsc-stress-tests:
2041
2042 2013-12-03  peavo@outlook.com  <peavo@outlook.com>
2043
2044         [Win] run-jsc-stress-tests has a great number of failures (2026/7606) on Windows
2045         https://bugs.webkit.org/show_bug.cgi?id=125111
2046
2047         Reviewed by Filip Pizlo.
2048
2049         Almost all errors seem to be caused by differences in line ending when diffing test output with expected output.
2050
2051         * Scripts/run-javascriptcore-tests: Enable api test and stress test for WinCairo.
2052         * Scripts/run-jsc-stress-tests: Ignore carriage return when diffing test output with expected output.
2053
2054 2013-12-03  Ryosuke Niwa  <rniwa@webkit.org>
2055
2056         Add a script to automatically configure a git clone
2057         https://bugs.webkit.org/show_bug.cgi?id=110073
2058
2059         Revert the change to use https for now since git.webkit.org is setup with http.
2060
2061         * Scripts/webkitpy/tool/commands/setupgitclone.py:
2062         (SetupGitClone.execute):
2063
2064 2013-12-03  Ryosuke Niwa  <rniwa@webkit.org>
2065
2066         Add a script to automatically configure a git clone
2067         https://bugs.webkit.org/show_bug.cgi?id=110073
2068
2069         Reviewed by Benjamin Poulain.
2070
2071         Added "webkit-patch setup-git-clone" to setup a brand new Git clone.
2072
2073         This command runs various commands listed on http://trac.webkit.org/wiki/UsingGitWithWebKit
2074
2075         * Scripts/webkitpy/tool/commands/__init__.py:
2076         * Scripts/webkitpy/tool/commands/setupgitclone.py: Added.
2077         (SetupGitClone):
2078         (SetupGitClone.execute):
2079
2080 2013-12-03  Anders Carlsson  <andersca@apple.com>
2081
2082         Deprecate WKNotificationProvider
2083         https://bugs.webkit.org/show_bug.cgi?id=125178
2084
2085         Reviewed by Sam Weinig.
2086
2087         Update for WebKit2 changes.
2088
2089         * WebKitTestRunner/TestController.cpp:
2090         (WTR::TestController::initialize):
2091         * WebKitTestRunner/WebNotificationProvider.cpp:
2092         (WTR::WebNotificationProvider::provider):
2093         * WebKitTestRunner/WebNotificationProvider.h:
2094
2095 2013-12-03  Brent Fulgham  <bfulgham@apple.com>
2096
2097         [Win] Support 64-bit Application Support Libraries Location 
2098         https://bugs.webkit.org/show_bug.cgi?id=125179
2099
2100         Reviewed by Tim Horton.
2101
2102         Enable the user to specify a location for 64-bit support libraries (such as libxml2, ICU, etc.)
2103         on Windows until an official distribution is available that properly creates registry settings
2104         to specify these locations.
2105
2106         * Scripts/webkitdirs.pm:
2107         (setupAppleWinEnv): Notify user to set WEBKIT_64_SUPPORT environment variable if needed.
2108         (setupCygwinEnv): Report WEWBKIT_64_SUPPORT path when running 64-bit builds.
2109         (appleApplicationSupportPath): Add WEBKIT_64_SUPPORT location to runtime environment when
2110         running 64-bit builds.
2111
2112 2013-12-03  Mark Hahnenberg  <mhahnenberg@apple.com>
2113
2114         run-jsc-stress-tests only supports host environments that have make installed
2115         https://bugs.webkit.org/show_bug.cgi?id=124550
2116
2117         Reviewed by Darin Adler.
2118
2119         This might not be the case for all hosts, so this patch implements an alternate "backend" 
2120         for run-jsc-stress-tests to use normal shell commands rather than Makefiles. To remain at 
2121         least somewhat competitive with the make-based test runner, the shell backend uses subshells
2122         run in the background to allow tests to run in parallel. Since the concurrency primitives 
2123         in shell scripting are rather coarse, the overhead of this parallelism is higher than that 
2124         of the make-based runner.
2125
2126         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added. This is the runner that is copied into
2127         the bundle and controls all of the parallel aspects of the shell-based test runner.
2128         * Scripts/run-jsc-stress-tests:
2129
2130 2013-12-03  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
2131
2132         Remove function from TextChecker
2133         https://bugs.webkit.org/show_bug.cgi?id=125148
2134
2135         Reviewed by Darin Adler.
2136
2137         The process_file_data is used only from the unit tests, so it is simply moved there.
2138
2139         * Scripts/webkitpy/style/checkers/text.py:
2140         (TextChecker.check):
2141         * Scripts/webkitpy/style/checkers/text_unittest.py:
2142         (TextStyleTestCase.process_file_data):
2143         (TextStyleTestCase.assertNoError):
2144         (TextStyleTestCase.assertError):
2145
2146 2013-12-03  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2147
2148         Remove get_test() and reference test names directly instead.
2149         https://bugs.webkit.org/show_bug.cgi?id=124962
2150
2151         Reviewed by Csaba Osztrogonác.
2152
2153         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2154         (Base.__init__):
2155         (Base.get_basic_tests):
2156         (assert_exp):
2157         (MiscTests.test_multiple_results):
2158         (MiscTests.test_category_expectations):
2159         (MiscTests.test_get_modifiers):
2160         (MiscTests.test_get_expectations_string):
2161         (MiscTests.test_get_test_set):
2162         (MiscTests.test_parse_warning):
2163         (MiscTests.test_pixel_tests_flag.match):
2164
2165 2013-12-03  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2166
2167         Style Checker false pass.
2168         https://bugs.webkit.org/show_bug.cgi?id=112456
2169
2170         Reviewed by Csaba Osztrogonác.
2171
2172         * Scripts/webkitpy/style/checkers/changelog.py:
2173         (ChangeLogChecker.check_entry):
2174         simple regex fix to check "No new tests (...)."
2175         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
2176         (ChangeLogCheckerTest.test_no_new_tests):
2177
2178 2013-12-02  Filip Pizlo  <fpizlo@apple.com>
2179
2180         run-jsc-stress-tests should allow for tests that have a directory containing .js files nested within a directory containing the data
2181         https://bugs.webkit.org/show_bug.cgi?id=125130
2182
2183         Reviewed by Geoffrey Garen.
2184
2185         * Scripts/run-jsc-stress-tests:
2186
2187 2013-12-02  Samuel White  <samuel_white@apple.com>
2188
2189         AX: Add AXUIElementCountForSearchPredicate parameterized attribute.
2190         https://bugs.webkit.org/show_bug.cgi?id=124561
2191
2192         Reviewed by Chris Fleizach.
2193
2194         Added function to verify that NSAccessibilityUIElementCountForSearchPredicateParameterizedAttribute works as it should.
2195
2196         * DumpRenderTree/AccessibilityUIElement.cpp:
2197         (uiElementCountForSearchPredicateCallback):
2198         (uiElementForSearchPredicateCallback):
2199         (AccessibilityUIElement::getJSClass):
2200         * DumpRenderTree/AccessibilityUIElement.h:
2201         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2202         (AccessibilityUIElement::uiElementCountForSearchPredicate):
2203         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2204         (AccessibilityUIElement::uiElementCountForSearchPredicate):
2205         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2206         (searchPredicateParameterizedAttributeForSearchCriteria):
2207         (AccessibilityUIElement::uiElementCountForSearchPredicate):
2208         (AccessibilityUIElement::uiElementForSearchPredicate):
2209         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2210         (AccessibilityUIElement::uiElementCountForSearchPredicate):
2211         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2212         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
2213         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2214         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2215         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2216         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
2217         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2218         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
2219         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
2220         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2221
2222 2013-12-02  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2223
2224         Instead of a large 'if' block, each failure class should write it's own result in test_result_writer.py
2225         https://bugs.webkit.org/show_bug.cgi?id=124714
2226
2227         Reviewed by Ryosuke Niwa.
2228
2229         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2230         (write_test_result):
2231         * Scripts/webkitpy/layout_tests/models/test_failures.py:
2232         (TestFailure.write_failure):
2233         (FailureText):
2234         (FailureText.write_failure):
2235         (FailureAudio):
2236         (FailureAudio.write_failure):
2237         (FailureCrash.write_failure):
2238         (FailureMissingResult):
2239         (FailureTextMismatch):
2240         (FailureMissingImageHash.write_failure):
2241         (FailureMissingImage.write_failure):
2242         (FailureImageHashMismatch.write_failure):
2243         (FailureReftestMismatch.write_failure):
2244         (FailureReftestMismatchDidNotOccur.write_failure):
2245         (FailureMissingAudio):
2246         (FailureAudioMismatch):
2247
2248 2013-12-02  László Langó  <lango@inf.u-szeged.hu>
2249
2250         Remove the stderr_write attribute from StyleProcessorConfiguration
2251         https://bugs.webkit.org/show_bug.cgi?id=124703
2252
2253         Reviewed by Ryosuke Niwa.
2254
2255         Remove the stderr_write attribute from this class in checker and
2256         replace its use with calls to a logging module logger. We Should 
2257         use logging module instead of writing to stderr directly.
2258
2259         * Scripts/webkitpy/style/checker.py: Change stderr_write attribute to logging module logger.
2260         (check_webkit_style_configuration):
2261         (CheckerDispatcher.dispatch): Remove FIXME comment.
2262         (StyleProcessorConfiguration):
2263         (StyleProcessorConfiguration.__init__):
2264         (StyleProcessorConfiguration.write_style_error):
2265         * Scripts/webkitpy/style/checker_unittest.py: Update test to the modification.
2266         There is an "ERROR" prefix in log messiges from now.
2267         (StyleProcessorConfigurationTest):
2268         (StyleProcessorConfigurationTest._style_checker_configuration):
2269         (StyleProcessorConfigurationTest.test_init):
2270         (StyleProcessorConfigurationTest.test_write_style_error_emacs):
2271         (StyleProcessorConfigurationTest.test_write_style_error_vs7):
2272         (StyleProcessor_EndToEndTest.with):
2273         (StyleProcessor_EndToEndTest.test_init):
2274         (StyleProcessor_EndToEndTest.test_process):
2275         (StyleProcessor_CodeCoverageTest.setUp):
2276         * Scripts/webkitpy/style/error_handlers.py: Remove stderr_write usage and replace with logging module logger.
2277         (DefaultStyleErrorHandler.__call__):
2278         * Scripts/webkitpy/style/error_handlers_unittest.py: Update test to the modification.
2279         There is an "ERROR" prefix in log messiges from now.
2280         (DefaultStyleErrorHandlerTest):
2281         (DefaultStyleErrorHandlerTest.setUp):
2282         (DefaultStyleErrorHandlerTest._mock_increment_error_count):
2283         (DefaultStyleErrorHandlerTest._style_checker_configuration):
2284         (DefaultStyleErrorHandlerTest._check_initialized):
2285         (DefaultStyleErrorHandlerTest.test_non_reportable_error):
2286         (DefaultStyleErrorHandlerTest.test_max_reports_per_category):
2287         (DefaultStyleErrorHandlerTest.test_line_numbers):
2288
2289 2013-12-02  Brian J. Burg  <burg@cs.washington.edu>
2290
2291         Add JavaScript style checker and teach checker.py about .js files
2292         https://bugs.webkit.org/show_bug.cgi?id=125049
2293
2294         Reviewed by Joseph Pecoraro.
2295
2296         Add a JavaScript file type, extension, and checker (JSChecker).
2297         Use TextChecker for JavaScript tests, libraries, website resources,
2298         etc. and use JSChecker for files within WebInspectorUI/UserInterface.
2299
2300         Amended tests for TextChecker to reflect the rule above.
2301
2302         * Scripts/webkitpy/style/checker.py:
2303         (_all_categories): Add categories defined by JSChecker.
2304         (FileType): Add file type for JS and re-number the enum.
2305         (CheckerDispatcher._file_type): Detect .js files as JavaScript.
2306         (CheckerDispatcher._create_checker):
2307         Create a JSChecker or TextChecker depending on the file's path.
2308
2309         * Scripts/webkitpy/style/checker_unittest.py:
2310         (CheckerDispatcherDispatchTest.assert_checker_js): Added.
2311         (CheckerDispatcherDispatchTest.test_js_paths): Added.
2312         (CheckerDispatcherDispatchTest.test_text_paths): Add new test paths
2313         that end in .js but should be checked with TextChecker.
2314         * Scripts/webkitpy/style/checkers/js.py: Added.
2315         (JSChecker):
2316         (JSChecker.__init__):
2317         (JSChecker.check):
2318         * Scripts/webkitpy/style/checkers/js_unittest.py: Added.
2319         (JSTestCase):
2320         (JSTestCase.assertNoError):
2321         (JSTestCase.assertNoError.error_for_test):
2322         (JSTestCase.assertError):
2323         (JSTestCase.assertError.error_for_test):
2324         (JSTestCase.test_no_error):
2325         (JSTestCase.test_error):
2326
2327 2013-12-02  Mark Hahnenberg  <mhahnenberg@apple.com>
2328
2329         run-jsc-stress-tests always copies the VM
2330         https://bugs.webkit.org/show_bug.cgi?id=125092
2331
2332         Reviewed by Filip Pizlo.
2333
2334         This can be slow, especially with full debug builds. It should just symlink the VM into the 
2335         bundle by default and do a full copy only when asked.
2336
2337         * Scripts/run-jsc-stress-tests:
2338
2339 2013-12-02  Brent Fulgham  <bfulgham@apple.com>
2340
2341         [Win] Port run-jsc-stress-tests
2342         https://bugs.webkit.org/show_bug.cgi?id=124801
2343
2344         Reviewed by Filip Pizlo.
2345
2346         * Scripts/run-jsc-stress-tests: Gracefully handle lack of sysctl
2347         command on Windows so that stress tests can run.
2348
2349 2013-12-02  Mark Hahnenberg  <mhahnenberg@apple.com>
2350
2351         Build fix after r159955
2352
2353         * Scripts/run-jsc-stress-tests:
2354
2355 2013-12-02  Mark Hahnenberg  <mhahnenberg@apple.com>
2356
2357         run-jsc-stress-tests should be able to package its tests and move them places
2358         https://bugs.webkit.org/show_bug.cgi?id=124549
2359
2360         Reviewed by Filip Pizlo.
2361
2362         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. Was just a ruby reimplementation
2363         of grep -i -q
2364         * Scripts/run-javascriptcore-tests: Pass through the --tarball flag.
2365         * Scripts/run-jsc-stress-tests: Changed to create a bundle of tests inside the results directory.
2366         We now also copy whatever VM was specified, along with its associated framework, into this directory.
2367         All of the generated scripts now are completely relative within the results directory. This allows
2368         run-jsc-stress-tests to execute a bundle from anywhere. Also added a --tarball flag which creates a
2369         tarball of the generated results directory. Also refactored several portions of the script into
2370         separate functions to make it easier to run them conditionally depending on which mode we're running in. 
2371
2372 2013-12-02  Andrzej Badowski  <a.badowski@samsung.com>
2373
2374         [ATK] Support active state for listbox elements.
2375         https://bugs.webkit.org/show_bug.cgi?id=125009
2376
2377         Reviewed by Chris Fleizach.
2378
2379         Supplement WebKitTestRunner and DumpRenderTree to support isSelectedOptionActive.
2380
2381         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2382         (AccessibilityUIElement::isSelectedOptionActive):
2383         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2384         (WTR::AccessibilityUIElement::isSelectedOptionActive):
2385         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2386         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2387         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2388         (WTR::AccessibilityUIElement::isSelectedOptionActive):
2389         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2390         (WTR::AccessibilityUIElement::isSelectedOptionActive):
2391
2392 2013-12-02  Zan Dobersek  <zdobersek@igalia.com>
2393
2394         Unreviewed GTK gardening.
2395
2396         * Scripts/run-gtk-tests:
2397         (TestRunner): Skip two unit tests that are causing the subsequent test to crash.
2398
2399 2013-12-01  Dan Bernstein  <mitz@apple.com>
2400
2401         [Mac] Transition MiniBrowser to the Cocoa API: policy delegate   
2402         https://bugs.webkit.org/show_bug.cgi?id=125046
2403
2404         Reviewed by Sam Weinig.
2405
2406         * MiniBrowser/mac/AppDelegate.m:
2407         (-[BrowserAppDelegate newWindow:]): Added WK_API_ENABLED guards.
2408         (-[BrowserAppDelegate openDocument:]): Ditto.
2409         * MiniBrowser/mac/WK2BrowserWindowController.h: Ditto. Also moved ivar declarations from the
2410         interface to the implementation.
2411         * MiniBrowser/mac/WK2BrowserWindowController.m:
2412         (-[WK2BrowserWindowController awakeFromNib]): Changed to set the policy delegate instead of
2413         the policy client.
2414         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]):
2415         Moved policy client implementation into this delegate method.
2416         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNewWindowAction:decisionHandler:]):
2417         Ditto.
2418         (-[WK2BrowserWindowController browsingContextController:decidePolicyForResponseAction:decisionHandler:]):
2419         Ditto.
2420
2421 2013-12-01  Dan Bernstein  <mitz@apple.com>
2422
2423         [Mac] Remove the MiniBrowser injected bundle
2424         https://bugs.webkit.org/show_bug.cgi?id=125041
2425
2426         Reviewed by Anders Carlsson.
2427
2428         It had no ops!
2429
2430         * MiniBrowser/Configurations/WebBundle.xcconfig: Removed.
2431         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2432         * MiniBrowser/mac/AppDelegate.m:
2433         (-[BrowserAppDelegate init]):
2434         * MiniBrowser/mac/WebBundle/Info.plist: Removed.
2435         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed.
2436
2437 2013-11-29  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2438
2439         check-webkit-style should check for extraneous newline between config.h and primary header.
2440         https://bugs.webkit.org/show_bug.cgi?id=124821
2441
2442         Reviewed by Csaba Osztrogonác.
2443
2444         * Scripts/webkitpy/style/checkers/cpp.py:
2445         (check_include_line):
2446         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2447         (OrderOfIncludesTest.test_check_line_break_after_own_header):
2448         (OrderOfIncludesTest):
2449         (OrderOfIncludesTest.test_check_line_break_before_own_header):
2450
2451 2013-11-29  Jozsef Berta  <jberta@inf.u-szeged.hu>
2452
2453         test-webkit-scripts should show the failing tests and use an appropriate exit code
2454         https://bugs.webkit.org/show_bug.cgi?id=124840
2455
2456         Reviewed by Ryosuke Niwa.
2457
2458         A fixme in test-webkit-scripts asked that the script should display success or failiure
2459         and exit with a 0 or 1 value accordingly after all of the tests have completed.
2460
2461         * Scripts/test-webkit-scripts:
2462         (ScriptsTester.run_test_script):
2463         The outcome of the currently run script is returned to the main as a boolean value. A boolean is returned,
2464         because at this point we don't need to pass on more information other than success or failiure.
2465         (ScriptsTester.main):
2466         The return values are now stored for each script and when all tests have completed successfully,
2467         the script indicates success and returns 0. Otherwise it will display the name(s) of the failing script(s) and return 1.
2468
2469 2013-11-29  Krzysztof Czech  <k.czech@samsung.com>
2470
2471         [ATK] Added support for isAttributeSettable in AccessibilityUIElementAtk
2472         https://bugs.webkit.org/show_bug.cgi?id=124923
2473
2474         Reviewed by Mario Sanchez Prada.
2475
2476         Added missing implementation of isAttributeSettable. Using
2477         ATK_STATE_EDITABLE for checking whether attribute is settable.
2478
2479         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2480         (AccessibilityUIElement::isAttributeSettable):
2481         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2482         (WTR::AccessibilityUIElement::isAttributeSettable):
2483
2484 2013-11-28  Commit Queue  <commit-queue@webkit.org>
2485
2486         Unreviewed, rolling out r159839.
2487         http://trac.webkit.org/changeset/159839
2488         https://bugs.webkit.org/show_bug.cgi?id=124974
2489
2490         run-webkit-tests doesn't generate pretty diff (Requested by
2491         Ossy on #webkit).
2492
2493         * Scripts/webkitpy/common/prettypatch.py:
2494         (PrettyPatch.__init__):
2495         (PrettyPatch.pretty_diff):
2496         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2497         (TestResultWriter.create_text_diff_and_write_result):
2498         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2499         (summarize_results):
2500         * Scripts/webkitpy/port/base.py:
2501         (Port.__init__):
2502         (Port.pretty_patch_available):
2503         (Port.check_pretty_patch):
2504         (Port.variable):
2505         (Port.variable.pretty_patch_text):
2506         * Scripts/webkitpy/port/base_unittest.py:
2507         (PortTest.test_pretty_patch_os_error):
2508         (PortTest.test_pretty_patch_script_error):
2509
2510 2013-11-28  Antti Koivisto  <antti@apple.com>
2511
2512         Remove feature: CSS variables
2513         https://bugs.webkit.org/show_bug.cgi?id=114119
2514
2515         Reviewed by Andreas Kling.
2516
2517         * Scripts/webkitperl/FeatureList.pm:
2518
2519 2013-11-28  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2520
2521         Move PrettyPatch related code to prettypatch.py
2522         https://bugs.webkit.org/show_bug.cgi?id=124937
2523
2524         Reviewed by Ryosuke Niwa.
2525
2526         This code seems to have a better place here than in Port, since PrettyPatch already knows
2527         pretty_patch_path, and this also unifies the usage of PrettyPatch
2528
2529         * Scripts/webkitpy/common/prettypatch.py:
2530         (PrettyPatch.__init__):
2531         (PrettyPatch.pretty_diff):
2532         (PrettyPatch):
2533         (PrettyPatch.pretty_patch_available):
2534         (PrettyPatch.check_pretty_patch):
2535         (PrettyPatch.pretty_patch_text):
2536         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2537         (TestResultWriter.create_text_diff_and_write_result):
2538         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2539         (summarize_results):
2540         * Scripts/webkitpy/port/base.py:
2541         (Port.__init__):
2542         (Port.wdiff_available):
2543         (Port.check_image_diff):
2544         (Port.wdiff_text):
2545         * Scripts/webkitpy/port/base_unittest.py:
2546         (PortTest.test_pretty_patch_os_error):
2547         (PortTest.test_pretty_patch_script_error):
2548
2549 2013-11-28  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2550
2551         Checkout should own the scm object in Host
2552         https://bugs.webkit.org/show_bug.cgi?id=124943
2553
2554         Reviewed by Ryosuke Niwa.
2555
2556         * Scripts/webkitpy/common/host.py:
2557         (Host.__init__):
2558         (Host.initialize_scm):
2559         (Host.scm):
2560
2561 2013-11-26  Filip Pizlo  <fpizlo@apple.com>
2562
2563         Do bytecode validation as part of testing
2564         https://bugs.webkit.org/show_bug.cgi?id=124913
2565
2566         Reviewed by Oliver Hunt.
2567
2568         * Scripts/run-jsc-stress-tests:
2569
2570 2013-11-27  Andres Gomez  <agomez@igalia.com>
2571
2572         [GTK] Tools/Scripts/update-webkitgtk-libs fails due to missing fontutils dependencies for building the "xserver" module
2573         https://bugs.webkit.org/show_bug.cgi?id=124940
2574
2575         Reviewed by Martin Robinson.
2576
2577         xserver-font-utils is needed for building gtk port dependencies
2578         with jhbuild.
2579
2580         * gtk/install-dependencies: Added xserver-font-utils to jhbuild
2581         dependecies.
2582
2583 2013-11-27  Andres Gomez  <agomez@igalia.com>
2584
2585         [GTK] Tools/Scripts/update-webkitgtk-libs unsorted and fails because of missing "git"
2586         https://bugs.webkit.org/show_bug.cgi?id=124938
2587
2588         Reviewed by Philippe Normand.
2589
2590         Added needed git dependency for building the gtk port with
2591         jhbuild. Also, the dependencies needed for building the gtk port
2592         are now sorted alphabetically.
2593
2594         * gtk/install-dependencies: Added git as jhbuild dependency and
2595         sorted dependencies alphabetically.
2596
2597 2013-11-27  Jozsef Berta  <jberta@inf.u-szeged.hu>
2598
2599         run_webkit_tests.py: error: no such option: --wincairo
2600         https://bugs.webkit.org/show_bug.cgi?id=124927
2601
2602         Reviewed by Ryosuke Niwa.
2603
2604         * BuildSlaveSupport/build.webkit.org-config/config.json: The run_webkit_tests.py doesn't supports
2605         the layout testing on wincairo, so it is turned off.
2606
2607 2013-11-26  Marcelo Lira  <marcelo.lira@openbossa.org>
2608
2609         Nix upstreaming - Adding build files and supporting scripts
2610         https://bugs.webkit.org/show_bug.cgi?id=118367
2611
2612         Reviewed by Ryosuke Niwa.
2613
2614         * Scripts/build-webkit:
2615         * Scripts/run-nix-tests: Added.
2616         * Scripts/run-webkit-tests:
2617         * Scripts/update-webkit-libs-jhbuild:
2618         * Scripts/update-webkitnix-libs: Added.
2619         * Scripts/webkitdirs.pm:
2620         (determineArchitecture):
2621         (argumentsForConfiguration):
2622         (jscProductDir):
2623         (builtDylibPathForName):
2624         (determineIsNix):
2625         (isNix):
2626         (isAppleWebKit):
2627         (launcherPath):
2628         (launcherName):
2629         (checkRequiredSystemConfig):
2630         (copyInspectorFrontendFiles):
2631         (jhbuildWrapperPrefixIfNeeded):
2632         (buildCMakeProjectOrExit):
2633         (cmakeBasedPortName):
2634         * Scripts/webkitpy/common/config/ports.py:
2635         (DeprecatedPort.port):
2636         (EflWK2Port.build_webkit_command):
2637         (NixPort):
2638         (NixPort.build_webkit_command):
2639         * Scripts/webkitpy/port/factory.py:
2640         (platform_options):
2641         (PortFactory):
2642         * Scripts/webkitpy/port/nix.py: Added.
2643         (NixPort):
2644         (NixPort._wk2_port_name):
2645         (NixPort.determine_full_port_name):
2646         (NixPort.__init__):
2647         (NixPort._port_flag_for_scripts):
2648         (NixPort.setup_test_run):
2649         (NixPort.setup_environ_for_server):
2650         (NixPort.default_timeout_ms):
2651         (NixPort.clean_up_test_run):
2652         (NixPort._generate_all_test_configurations):
2653         (NixPort._path_to_driver):
2654         (NixPort._path_to_image_diff):
2655         (NixPort._image_diff_command):
2656         (NixPort._search_paths):
2657         (NixPort.show_results_html_file):
2658         (NixPort._port_specific_expectations_files):
2659         (NixPort.default_baseline_search_path):
2660         * Scripts/webkitpy/port/nix_unittest.py: Added.
2661         (NixPortTest):
2662         (NixPortTest._assert_search_path):
2663         (NixPortTest._assert_expectations_files):
2664         (NixPortTest.test_baseline_search_path):
2665         (NixPortTest.test_expectations_files):
2666         (NixPortTest.test_default_timeout_ms):
2667         * jhbuild/jhbuild-wrapper:
2668         (determine_platform):
2669         * nix/common.py: Added.
2670         (script_path):
2671         (top_level_path):
2672         * nix/jhbuild.modules: Added.
2673         * nix/jhbuildrc: Added.
2674
2675 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
2676
2677         Record subtest values in Dromaeo tests
2678         https://bugs.webkit.org/show_bug.cgi?id=124498
2679
2680         Reviewed by Andreas Kling.
2681
2682         Supported parsing subtest results.
2683
2684         * Scripts/webkitpy/performance_tests/perftest.py: Replaced _metrics with an ordered list of subtests, each of
2685         which contains a dictionary with its name and an ordered list of subtest's metrics.
2686         (PerfTest.__init__): Initialize _metrics as a list.
2687         (PerfTest.run): Go through each subtest and its metrics to create a list of TestMetrics.
2688         (PerfTest._run_with_driver):
2689         (PerfTest._ensure_metrics): Look for a subtest then a metric in _metrics.
2690
2691         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2692         (TestPerfTest._assert_results_are_correct): Updated the assertions per changes to _metrics.
2693         (TestPerfTest.test_parse_output): Ditto.
2694         (TestPerfTest.test_parse_output_with_subtests): Added the metric and the unit on each subtest result as well as
2695         assertions to ensure subtest results are parsed properly.
2696         (TestReplayPerfTest.test_run_with_driver_accumulates_results): Updated the assertions per changes to _metrics.
2697         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results): Dittp.
2698
2699         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2700         (_generate_results_dict): When the metric for a subtest is processed before that of the main test, the url is
2701         incorrectly suffixed with '/'. Fix this later by re-computing the url with TestPerfMetric.test_file_name when
2702         adding new results.
2703
2704         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2705         (TestWithSubtestsData): Added.
2706         (TestDriver.run_test):
2707         (MainTest.test_run_test_with_subtests): Added.
2708
2709 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
2710
2711         Enable HTML template element on Windows ports
2712         https://bugs.webkit.org/show_bug.cgi?id=124758
2713
2714         Reviewed by Andreas Kling.
2715
2716         * Scripts/webkitperl/FeatureList.pm:
2717
2718 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
2719
2720         Remove replay performance tests as it's not actively maintained
2721         https://bugs.webkit.org/show_bug.cgi?id=124764
2722
2723         Reviewed by Andreas Kling.
2724
2725         Removed the feature.
2726
2727         * Scripts/webkitpy/performance_tests/perftest.py:
2728         (SingleProcessPerfTest.__init__):
2729         (PerfTestFactory):
2730         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2731         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2732         (PerfTestsRunner._parse_args):
2733         (PerfTestsRunner._collect_tests):
2734         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2735         (MainTest.test_collect_tests_with_ignored_skipped_list):
2736         (MainTest.test_default_args):
2737         * Scripts/webkitpy/thirdparty/__init__.py:
2738         (AutoinstallImportHook.find_module):
2739         (AutoinstallImportHook._install_unittest2):
2740         * Scripts/webkitpy/thirdparty/__init___unittest.py:
2741         (ThirdpartyTest.test_imports):
2742
2743 2013-11-26  Filip Pizlo  <fpizlo@apple.com>
2744
2745         Enable aggressive DFG validation in testing
2746         https://bugs.webkit.org/show_bug.cgi?id=124911
2747
2748         Rubber stamped by Ryosuke Niwa.
2749         
2750         This enables validation testing in non-concurrent-JIT runs.
2751
2752         * Scripts/run-jsc-stress-tests:
2753
2754 2013-11-26  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2755
2756         Moved methods which belong to Checkout into checkout.py
2757         https://bugs.webkit.org/show_bug.cgi?id=124889
2758
2759         Reviewed by Ryosuke Niwa.
2760
2761         * Scripts/webkitpy/common/checkout/checkout.py:
2762         (Checkout.scripts_directory):
2763         (Checkout):
2764         (Checkout.script_path):
2765         (Checkout.commit_message_for_this_commit):
2766         (Checkout.apply_patch):
2767         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2768         (test_commit_message_for_this_commit):
2769         (CheckoutTest.test_apply_patch):
2770         * Scripts/webkitpy/common/checkout/scm/scm.py:
2771         (SCM.absolute_path):
2772         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2773         (SCMTest._setup_webkittools_scripts_symlink):
2774         * Scripts/webkitpy/common/checkout/scm/svn.py:
2775         (SVN.create_patch):
2776
2777 2013-11-25  Ryuan Choi  <ryuan.choi@samsung.com>
2778
2779         [EFL] Use Config mode of find_package for EFL 1.8
2780         https://bugs.webkit.org/show_bug.cgi?id=124555
2781
2782         Reviewed by Gyuyoung Kim.
2783
2784         * MiniBrowser/efl/CMakeLists.txt:
2785         Added optional config mode and made version requirement optional.
2786
2787 2013-11-25  Andres Gomez  <agomez@igalia.com>
2788
2789         [GTK] Search functionality in MiniBrowser provides feedback on search fail
2790         https://bugs.webkit.org/show_bug.cgi?id=122681
2791
2792         Reviewed by Mario Sanchez Prada.
2793
2794         When using the search functionality in MiniBrowser, if the search
2795         fails, the entry background color gets red to report the user
2796         about the failing condition. When the entry is cleaned or the
2797         search is again succesful the background turns back to its
2798         original color.
2799
2800         * MiniBrowser/gtk/BrowserSearchBar.c:
2801         (setFailedStyleForEntry): Added.
2802         (doSearch): Sets the entry's background to its original style if
2803         there is no text to search.
2804         (findControllerFailedToFindTextCallback): Added.
2805         (findControllerFoundTextCallback): Added.
2806         (browser_search_bar_init): Creates and adds a new CSS provider to
2807         the text entry so we can change its style based on the success
2808         condition of the search.
2809         (browserSearchBarFinalize): Frees the new CSS provider.
2810         (browser_search_bar_new): Connects the two new handlers to the
2811         "failed-to-find-text" and "found-text" signals emitted by the
2812         WebKitFindController.
2813
2814 2013-11-25  Dan Bernstein  <mitz@apple.com>
2815
2816         [Cocoa] Put most of the Cocoa API behind WK_API_ENABLED guards
2817         https://bugs.webkit.org/show_bug.cgi?id=124850
2818
2819         Reviewed by Brady Eidson.
2820
2821         Added #if WK_API_ENABLED guards around tests that use the Objective-C API.
2822
2823         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2824         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
2825         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2826         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
2827         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
2828         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
2829         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
2830
2831 2013-11-25  Commit Queue  <commit-queue@webkit.org>
2832
2833         Unreviewed, rolling out r159752 and r159754.
2834         http://trac.webkit.org/changeset/159752
2835         http://trac.webkit.org/changeset/159754
2836         https://bugs.webkit.org/show_bug.cgi?id=124847
2837
2838         Broke linux test bots. (Requested by mhahnenberg on #webkit).
2839
2840         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
2841         * Scripts/run-javascriptcore-tests:
2842         * Scripts/run-jsc-stress-tests:
2843
2844 2013-11-25  Mark Hahnenberg  <mhahnenberg@apple.com>
2845
2846         Followup fix after r159752
2847
2848         * Scripts/run-jsc-stress-tests: We need to handle Release builds too.
2849
2850 2013-11-25  Mark Hahnenberg  <mhahnenberg@apple.com>
2851
2852         run-jsc-stress-tests should be able to package its tests and move them places
2853         https://bugs.webkit.org/show_bug.cgi?id=124549
2854
2855         Reviewed by Filip Pizlo.
2856
2857         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. Was just a ruby reimplementation 
2858         of grep -i -q
2859         * Scripts/run-javascriptcore-tests: Pass through the --tarball flag.
2860         * Scripts/run-jsc-stress-tests: Changed to create a bundle of tests inside the results directory. 
2861         We now also copy whatever VM was specified, along with its associated framework, into this directory. 
2862         All of the generated scripts now are completely relative within the results directory. This allows 
2863         run-jsc-stress-tests to execute a bundle from anywhere. Also added a --tarball flag which creates a 
2864         tarball of the generated results directory. Also refactored several portions of the script into 
2865         separate functions to make it easier to run them conditionally depending on which mode we're running in.
2866
2867 2013-11-25  László Langó  <lango@inf.u-szeged.hu>
2868
2869         EWS creates 0 byte sized log files
2870         https://bugs.webkit.org/show_bug.cgi?id=107606
2871
2872         Reviewed by Ryosuke Niwa.
2873
2874         There was a modification in r138264, that tried to make less log,
2875         because some of the messeges were duplicated. After this the EWS
2876         created the log file (with the same name as the bugID) but doesn't
2877         write anything into it, even if there were errors during the build.
2878         From now only creates the log file only if there is some error.
2879
2880         * Scripts/webkitpy/tool/bot/queueengine.py:
2881         (QueueEngine.run): If the build and tests pass, there is no ScriptError raised,
2882         there is nothing to log. Open the log file only if a ScriptError was raised to
2883         avoid to make empty log files for bugs.
2884         (QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore,
2885         because of changes in r138264. Teeing is used for locally testing purposes and
2886         this feature is not used anymore.
2887         (QueueEngine._ensure_work_log_closed): Close the logfile. We don't use output
2888         teeing anymore. It is a necessary change because of QueueEngine._open_work_log
2889         change.
2890         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2891         (LoggingDelegate): The order of the callbacks was changed by this patch.
2892         (QueueEngineTest.test_trivial): Won't create log file if the queue was terminated,
2893         so we have to update this test.
2894         (QueueEngineTest.test_unexpected_error): The order of the callbacks was changed by
2895         this patch.
2896         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2897         (AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError
2898         to be able to handle it in QueueEngine.run. Without this change, the existing
2899         exception handler never run (the process_work_item method never raise ScriptError)
2900         We can get the error message only from the ScriptError at this point.
2901
2902 2013-11-22  Dean Jackson  <dino@apple.com>
2903
2904         Speculative Mountain Lion build fix.
2905
2906         * MiniBrowser/mac/AppDelegate.m:
2907         (-[BrowserAppDelegate openDocument:]):
2908
2909 2013-11-22  Anders Carlsson  <andersca@apple.com>
2910
2911         Fix Mountain Lion bug.
2912
2913         * MiniBrowser/mac/AppDelegate.m:
2914         (-[BrowserAppDelegate openDocument:]):
2915
2916 2013-11-22  Anders Carlsson  <andersca@apple.com>
2917
2918         MiniBrowser should use the blocks-based NSOpenPanel API
2919         https://bugs.webkit.org/show_bug.cgi?id=124786
2920
2921         Reviewed by Simon Fraser.
2922
2923         * MiniBrowser/mac/AppDelegate.m:
2924         (-[BrowserAppDelegate frontmostBrowserWindowController]):
2925         Account for windows that don't have a BrowserWindowController.
2926
2927         (-[BrowserAppDelegate openDocument:]):
2928
2929 2013-11-22  Commit Queue  <commit-queue@webkit.org>
2930
2931         Unreviewed, rolling out r159690.
2932         http://trac.webkit.org/changeset/159690
2933         https://bugs.webkit.org/show_bug.cgi?id=124782
2934
2935         Broke webkitpy tests (Requested by ap on #webkit).
2936
2937         * Scripts/webkitpy/tool/bot/queueengine.py:
2938         (QueueEngine.run):
2939         (QueueEngine._open_work_log):
2940         (QueueEngine._ensure_work_log_closed):
2941         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2942         (AbstractEarlyWarningSystem.review_patch):
2943
2944 2013-11-22  László Langó  <lango@inf.u-szeged.hu>
2945
2946         EWS creates 0 byte sized log files
2947         https://bugs.webkit.org/show_bug.cgi?id=107606
2948
2949         Reviewed by Ryosuke Niwa.
2950
2951         There was a modification in r138264, that tried to make less log, 
2952         because some of the messeges were duplicated. After this the EWS 
2953         created the log file (with the same name as the bugID) but doesn't 
2954         write anything into it, even if there were errors during the build. 
2955         From now only creates the log file only if there is some error.
2956
2957         * Scripts/webkitpy/tool/bot/queueengine.py:
2958         (QueueEngine.run): If the build and tests pass, there is no ScriptError raised,
2959         there is nothing to log. Open the log file only if a ScriptError was raised to
2960         avoid to make empty log files for bugs.
2961         (QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore,
2962         because of changes in r138264. Teeing is used for locally testing purposes and
2963         this feature is not used anymore.
2964         (QueueEngine._ensure_work_log_closed): Close the logfile. We don't use output 
2965         teeing anymore. It is a necessary change because of QueueEngine._open_work_log
2966         change.
2967         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2968         (AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError
2969         to be able to handle it in QueueEngine.run. Without this change, the existing
2970         exception handler never run (the process_work_item method never raise ScriptError)
2971         We can get the error message only from the ScriptError at this point.
2972
2973 2013-11-21  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2974
2975         Remove ENABLE_WORKERS
2976         https://bugs.webkit.org/show_bug.cgi?id=105784
2977
2978         Reviewed by Darin Adler.
2979
2980         * Scripts/webkitperl/FeatureList.pm:
2981
2982 2013-11-21  Darin Adler  <darin@apple.com>
2983
2984         Try to fix buildbot Dashboard for people who have not hidden anything.
2985
2986         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2987         Add a null check for hidden platforms.
2988
2989 2013-11-21  Peter Szanka  <h868064@stud.u-szeged.hu>
2990
2991         Remove chrome/chromium related things from webkitpy.
2992         https://bugs.webkit.org/show_bug.cgi?id=124493
2993
2994         Reviewed by Darin Adler.
2995
2996         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2997         (PortTest.assert_mock_port_works):
2998         * Scripts/webkitpy/port/base.py:
2999         (Port.to.setup_environ_for_server):
3000         * Scripts/webkitpy/port/mac_unittest.py:
3001         (test_tests_for_other_platforms):
3002         * Scripts/webkitpy/port/mock_drt.py:
3003         (MockTestShell.output_for_test):
3004         * Scripts/webkitpy/tool/bot/irc_command.py:
3005         (Restart.execute):
3006         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
3007         (IRCBotTest.test_help):
3008
3009 2013-11-21  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
3010
3011         In filereader.py, process_file() should throw instead of exiting directly when the file doesn't exist
3012         https://bugs.webkit.org/show_bug.cgi?id=124717
3013
3014         Reviewed by Ryosuke Niwa.
3015
3016         * Scripts/webkitpy/style/filereader.py:
3017         (TextFileReader.process_file):
3018         * Scripts/webkitpy/style/filereader_unittest.py:
3019         (TextFileReaderTest.test_process_file__does_not_exist):
3020
3021 2013-11-21  Mark Rowe  <mrowe@apple.com>
3022
3023         <https://webkit.org/b/124702> Stop overriding VALID_ARCHS.
3024
3025         All modern versions of Xcode set it appropriately for our needs.
3026
3027         Reviewed by Alexey Proskuryakov.
3028
3029         * MiniBrowser/Configurations/Base.xcconfig:
3030         * WebKitTestRunner/Configurations/Base.xcconfig:
3031
3032 2013-11-21  Nick Diego Yamane  <nick.yamane@openbossa.org>
3033
3034         webkitdirs::checkForArgumentAndRemoveFromArrayRef() removed wrong element
3035         https://bugs.webkit.org/show_bug.cgi?id=124676
3036
3037         Reviewed by Daniel Bates.
3038
3039         checkForArgumentAndRemoveFromArrayRef functions was removing wrong
3040         elements when there were more then one occurrence of that argument.
3041         E.g: Checking for 'a' in {a, b, a, c}, the resulting array would be
3042         {b, a}, when it should be {b, c}.
3043
3044         * Scripts/webkitdirs.pm:
3045         (checkForArgumentAndRemoveFromArrayRef): bugfix mentioned above.
3046         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
3047         Added; Unit tests for webkitdirs::checkForArgumentAndRemoveFromArrayRef function.
3048
3049 2013-11-21  Ryosuke Niwa  <rniwa@webkit.org>
3050
3051         Update build-webkit after r159550.
3052
3053         * Scripts/webkitperl/FeatureList.pm:
3054
3055 2013-11-21  Lucas Forschler  <lforschler@apple.com>
3056
3057         Bring a new bot online, replacing the previous ones.
3058         
3059         Unreviewed.
3060
3061         * BuildSlaveSupport/build.webkit.org-config/config.json:
3062
3063 2013-11-21  Dean Jackson  <dino@apple.com>
3064
3065         Don't fetch hidden platforms on build.webkit.org/dashboard
3066         https://bugs.webkit.org/show_bug.cgi?id=124750
3067
3068         Reviewed by Tim Horton.
3069
3070         If a platform is hidden, don't fetch its data. If it
3071         becomes unhidden, try to fetch immediately (unless
3072         you've recently fetched).
3073
3074         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3075         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3076
3077 2013-11-21  Commit Queue  <commit-queue@webkit.org>
3078
3079         Unreviewed, rolling out r159633.
3080         http://trac.webkit.org/changeset/159633
3081         https://bugs.webkit.org/show_bug.cgi?id=124726
3082
3083         it broke 10 webkitpy tests (Requested by dino_ on #webkit).
3084
3085         * Scripts/webkitpy/style/checker.py:
3086         (check_webkit_style_configuration):
3087         (CheckerDispatcher.dispatch):
3088         (StyleProcessorConfiguration):
3089         (StyleProcessorConfiguration.__init__):
3090         (StyleProcessorConfiguration.write_style_error):
3091
3092 2013-11-21  László Langó  <lango@inf.u-szeged.hu>
3093
3094         Remove the stderr_write attribute from StyleProcessorConfiguration.
3095         https://bugs.webkit.org/show_bug.cgi?id=124703
3096
3097         Reviewed by Brent Fulgham.
3098
3099         * Scripts/webkitpy/style/checker.py:
3100         (check_webkit_style_configuration):
3101         (CheckerDispatcher.dispatch):
3102         (StyleProcessorConfiguration):
3103         (StyleProcessorConfiguration.__init__):
3104         (StyleProcessorConfiguration.write_style_error):
3105
3106 2013-11-21  Ryosuke Niwa  <rniwa@webkit.org>
3107
3108         PerfTestRunner._generate_results_dict shouldn't depend on test objects
3109         https://bugs.webkit.org/show_bug.cgi?id=124623
3110
3111         Removed the dependency on test objects from results JSON generation.
3112         This allows single test.run to return metrics for multiple tests
3113
3114         Reviewed by Antti Koivisto.
3115
3116         * Scripts/webkitpy/performance_tests/perftest.py:
3117         (PerfTestMetric.__init__): Takes the test path and test name.
3118         (PerfTestMetric.path): Added.
3119         (PerfTestMetric.test_file_name): Added.
3120         (PerfTest.run): Accumulate PerfTestMetric objects instead of raw values.
3121         (PerfTest._ensure_metrics): Instantiate PerfTestMetric with the test path and test name.
3122         The path is going to have the names of subtests at the end once we support them.
3123
3124         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3125         (TestPerfTestMetric.test_init_set_missing_unit): Specify the test path and test name.
3126         (TestPerfTestMetric.test_init_set_time_metric): Ditto.
3127         (TestPerfTestMetric.test_has_values): Ditto.
3128         (TestPerfTestMetric.test_append): Ditto.
3129
3130         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3131         (_generate_results_dict): Only use metrics.
3132         (_run_tests_set): Accumulate metrics as supposed to (test, metrics) pairs.
3133
3134 2013-11-21  Manuel Rego Casasnovas  <rego@igalia.com>
3135
3136         REGRESSION(r159599): webkitdirs.pm spits out warnings at lines 851 and 852
3137         https://bugs.webkit.org/show_bug.cgi?id=124697
3138
3139         Reviewed by Ryosuke Niwa.
3140
3141         * Scripts/webkitdirs.pm:
3142         (checkForArgumentAndRemoveFromARGVGettingValue): Fix check of array size
3143         before trying to access to the first element.
3144
3145 2013-11-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3146
3147         [GTK] Mark all deprecated symbols in GObject DOM bindings
3148         https://bugs.webkit.org/show_bug.cgi?id=124406
3149
3150         Reviewed by Gustavo Noronha Silva.
3151
3152         * Scripts/webkitpy/style/checker.py: Add special case for
3153         WebKitDOMDeprecated.
3154         * gtk/generate-gtkdoc:
3155         (get_webkit2_options): Use the prefix of the methods as namespace,
3156         since this is what gtkdoc expects to sort the index.
3157         (get_webkit1_options): Ditto.
3158         (get_webkitdom_options): Ditto.
3159         * gtk/generate-webkitdom-doc-files:
3160         (WebKitDOMDocGenerator): Add a global list of deleted objects.
3161         (WebKitDOMDocGenerator.write_deleted_classes): New method to write
3162         the documentation for classes that are deprecated because they
3163         have been removed.
3164         (WebKitDOMDocGeneratorDocs.write_deleted_classes): Add sections
3165         for deleted classes too.
3166         (WebKitDOMDocGeneratorSections.__init__): Build a list of
3167         deprecated symbols using the given symbols file.
3168         (WebKitDOMDocGeneratorSections._deleted_class): Returns the
3169         deleted class corresponding to the given function.
3170         (WebKitDOMDocGeneratorSections._deprecated_symbols): Builds a
3171         dictionary of deprecated symbols for every class.
3172         (WebKitDOMDocGeneratorSections.write_section): Add also the
3173         deprecated symbols in every section.
3174         (WebKitDOMDocGeneratorSections.write_deleted_classes): Add
3175         sections for deleted classes too.
3176
3177 2013-11-20  László Langó  <lango@inf.u-szeged.hu>
3178
3179         check-webkit-style should support C++11 rvalue references.
3180         https://bugs.webkit.org/show_bug.cgi?id=123406
3181
3182         Reviewed by Brent Fulgham.
3183
3184         * Scripts/webkitpy/style/checkers/cpp.py:
3185         (check_style):
3186         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3187         (Cpp11StyleTest):
3188         (Cpp11StyleTest.test_rvaule_reference_at_end_of_line):
3189
3190 2013-11-20  Dean Jackson  <dino@apple.com>
3191
3192         Allow settings to be shown/hidden on build.webkit.org/dashboard
3193         https://bugs.webkit.org/show_bug.cgi?id=124694
3194
3195         Reviewed by Tim Horton.
3196
3197         In preparation for more options/buttons, allow the page to
3198         show or hide all the interactive things using a little gear icon
3199         in the top left corner.
3200
3201         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3202         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
3203         (Settings.prototype.toggleSettingsDisplay):
3204         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3205         (div.cellButton.hide):
3206         (div.cellButton.unhide):
3207         (.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide):
3208         (.settings):
3209         (.settings:hover):
3210         (.settings-visible .settings):
3211
3212 2013-11-20  Dean Jackson  <dino@apple.com>
3213
3214         No need to base64 SVG on build.webkit.org/dashboard
3215         https://bugs.webkit.org/show_bug.cgi?id=124687
3216
3217         Reviewed by Tim Horton.
3218
3219         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3220         (.status-line.good .bubble.pictogram):
3221
3222 2013-11-20  Dean Jackson  <dino@apple.com>
3223
3224         Make links look more like links on build.webkit.org/dashboard
3225         https://bugs.webkit.org/show_bug.cgi?id=124686
3226
3227         Reviewed by Tim Horton.
3228
3229         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:
3230         (.queue-view .queueLabel:hover):
3231         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3232         (.status-line.linked .label:hover):
3233
3234 2013-11-20  Nick Diego Yamane  <nick.yamane@openbossa.org>
3235
3236         Modify webkitdirs to reuse checkForArgumentAndRemoveFromARGV
3237         https://bugs.webkit.org/show_bug.cgi?id=124581
3238
3239         Reviewed by Daniel Bates.
3240
3241         Some subroutines are replicating code from checkForArgument**
3242         functions instead of reusing them as is being done by all other functions.
3243
3244         * Scripts/webkitdirs.pm:
3245         (determineXcodeSDK): Added.
3246         (determinePassedConfiguration): Added.
3247         (determinePassedArchitecture): Added.
3248         (checkForArgumentAndRemoveFromARGV): Added.
3249         (checkForArgumentAndRemoveFromARGVGettingValue): Added.
3250
3251 2013-11-20  Jozsef Berta  <jberta@inf.u-szeged.hu>
3252
3253         Delete baseline optimizer
3254         https://bugs.webkit.org/show_bug.cgi?id=122333
3255
3256         Reviewed by Ryosuke Niwa.
3257
3258         * Scripts/webkitpy/common/checkout/baselineoptimizer.py: Removed.
3259         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py: Removed.
3260         * Scripts/webkitpy/tool/commands/rebaseline.py:
3261         (RebaselineTest.execute):
3262         (AbstractParallelRebaselineCommand._files_to_add):
3263         (AbstractParallelRebaselineCommand._rebaseline):
3264         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3265         (TestRebaselineJson.test_rebaseline_all):
3266         (TestRebaselineJson.test_rebaseline_debug):
3267         (TestRebaselineExpectations.disabled_test_overrides_are_included_correctly):
3268
3269 2013-11-20  Anders Carlsson  <andersca@apple.com>
3270
3271         Enable PageLoadTest assertions again
3272         https://bugs.webkit.org/show_bug.cgi?id=124681
3273
3274         Reviewed by Tim Horton.
3275
3276         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3277         Actually install all-content-in-one-iframe.html, noticed while debugging this assertion.
3278
3279 2013-11-20  Mark Rowe  <mrowe@apple.com>
3280
3281         Remove some obsolete logic from WebKit.app.
3282
3283         Reviewed by Alexey Proskuryakov.
3284
3285         * WebKitLauncher/WebKitNightlyEnabler.m:
3286         (poseAsWebKitApp): Remove a pre-10.6 codepath.
3287         (enableWebKitNightlyBehaviour): Remove a 10.4-specific codepath.
3288
3289 2013-11-20  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
3290
3291         Moved stray urls from svn.py and statusserver.py into common.config.urls
3292         https://bugs.webkit.org/show_bug.cgi?id=124650
3293
3294         Reviewed by Ryosuke Niwa.
3295
3296         * Scripts/webkitpy/common/checkout/scm/svn.py:
3297         (SVNRepository):
3298         * Scripts/webkitpy/common/config/urls.py:
3299         * Scripts/webkitpy/common/net/statusserver.py:
3300         (StatusServer.__init__):
3301         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3302         (_generate_results_dict):
3303
3304 2013-11-20  Commit Queue  <commit-queue@webkit.org>
3305
3306         Unreviewed, rolling out r159496.
3307         http://trac.webkit.org/changeset/159496
3308         https://bugs.webkit.org/show_bug.cgi?id=124641
3309
3310         It caused warning and build break with cmake lower than 2.8.8
3311         (Requested by ryuan on #webkit).
3312
3313         * MiniBrowser/efl/CMakeLists.txt:
3314
3315 2013-11-20  Gabor Rapcsanyi  <rgabor@webkit.org>
3316
3317         [EFL] libseccomp-2.0.0 doesn't support ARM architecture
3318         https://bugs.webkit.org/show_bug.cgi?id=124412
3319
3320         Reviewed by Gyuyoung Kim.
3321
3322         Update libseccomp to a newer 2.1.0 version.
3323
3324         * efl/jhbuild.modules:
3325
3326 2013-11-19  Mark Rowe  <mrowe@apple.com>
3327
3328         <rdar://problem/15487072> Modernize WebKit.app's OS X version checking logic.
3329
3330         Gestalt is deprecated on recent OS X versions so we should switch off it.
3331
3332         Reviewed by Sam Weinig.
3333
3334         * WebKitLauncher/main.m:
3335         (currentMacOSXVersion): Retrieve the version string from SystemVersion.plist.
3336         (currentMacOSXMajorVersion): Split the version string at the periods, retrieve the first
3337         two components, then join them back up.
3338         (main): Switch to using currentMacOSXMajorVersion to make it clearer which part of
3339         the version we care about.
3340
3341 2013-11-19  Commit Queue  <commit-queue@webkit.org>
3342
3343         Unreviewed, rolling out r159538.
3344         http://trac.webkit.org/changeset/159538
3345         https://bugs.webkit.org/show_bug.cgi?id=124627
3346
3347         it broke run-jsc-stress-tests (Requested by mhahnenberg on
3348         #webkit).
3349
3350         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
3351         * Scripts/run-javascriptcore-tests:
3352         * Scripts/run-jsc-stress-tests:
3353
3354 2013-11-19  Mark Hahnenberg  <mhahnenberg@apple.com>
3355
3356         run-jsc-stress-tests should be able to package its tests and move them places
3357         https://bugs.webkit.org/show_bug.cgi?id=124549
3358
3359         Reviewed by Geoff Garen and Filip Pizlo.
3360
3361         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. This script was just a ruby reimplementation 
3362         of grep -i -q 
3363         * Scripts/run-javascriptcore-tests: Pass through the --make-bundle flag.
3364         * Scripts/run-jsc-stress-tests: Added the new concept of a "bundle", which is a collection of all tests and any
3365         other files that those tests require to run in any environment along with a fixed root directory into which these
3366         files and their expected directory structure are cloned. The default Bundle class is basically 
3367         a no-op so that it functions like run-jsc-stress-tests prior to this patch. MovableBundle is a Bundle that knows 
3368         how to translate local paths to bundle paths and does all the work of moving each test file into the right place 
3369         inside the .tests directory. After all the test files have been created in jsc-stress-results MovableBundle 
3370         creates a tarball of the entire directory for easy relocation. The --make-bundle flag causes run-jsc-stress-tests 
3371         to use MovableBundle instead of just Bundle. 
3372
3373 2013-11-19  Dan Bernstein  <mitz@apple.com>
3374
3375         <rdar://problem/15139479> Reenable the JSC Objective-C API tests on Mountain Lion once the bots are running Xcode 5
3376
3377         Rubber-stamped by Mark Rowe.
3378
3379         Reverted r156840.
3380
3381         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
3382
3383 2013-11-19  Ryosuke Niwa  <rniwa@webkit.org>
3384
3385         Yet another build fix. Just allow any character.
3386         There are just too many special characters to be listed here.
3387
3388         * Scripts/webkitpy/performance_tests/perftest.py:
3389         (PerfTest._lines_to_ignore_in_parser_result):
3390         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3391         (TestPerfTest.test_parse_output_with_subtests)
3392
3393 2013-11-19  Ryosuke Niwa  <rniwa@webkit.org>
3394
3395         Another build fix. Allow ':' in subtest names.
3396
3397         * Scripts/webkitpy/performance_tests/perftest.py:
3398         (PerfTest._lines_to_ignore_in_parser_result):
3399         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3400         (TestPerfTest.test_parse_output_with_subtests)
3401
3402 2013-11-19  Ryuan Choi  <ryuan.choi@samsung.com>
3403
3404         [EFL] Use Config mode of find_package for EFL 1.8
3405         https://bugs.webkit.org/show_bug.cgi?id=124555
3406
3407         Reviewed by Gyuyoung Kim.
3408
3409         * MiniBrowser/efl/CMakeLists.txt: Introduced a config mode to find elementary.
3410
3411 2013-11-19  Ryosuke Niwa  <rniwa@webkit.org>
3412
3413         Build fix. Subtest names need to be more permissive.
3414
3415         * Scripts/webkitpy/performance_tests/perftest.py:
3416         (PerfTest._lines_to_ignore_in_parser_result):
3417         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3418         (TestPerfTest.test_parse_output_with_subtests)
3419
3420 2013-11-18  Mark Rowe  <mrowe@apple.com>
3421
3422         Use hw.activecpu for determining how many processes to spawn.
3423
3424         It's documented as the preferred way to determine the number of threads
3425         or processes to create in a SMP aware application.
3426
3427         Rubber-stamped by Tim Horton.
3428
3429         * Scripts/copy-webkitlibraries-to-product-directory:
3430         * Scripts/run-jsc-stress-tests:
3431         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3432
3433 2013-11-18  Tim Horton  <timothy_horton@apple.com>
3434
3435         build.webkit.org/dashboard builder headers should link to the builder page
3436         https://bugs.webkit.org/show_bug.cgi?id=124553
3437
3438         Reviewed by Timothy Hatcher.
3439
3440         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3441         (BuildbotQueue.prototype.get overviewURL):
3442         Add overviewURL(), which returns the URL to the builder overview page, with the last 50 builds shown.
3443
3444         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3445         (BuildbotBuilderQueueView.prototype.update.appendBuildArchitecture):
3446         (BuildbotBuilderQueueView.prototype.update):
3447         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3448         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3449         (BuildbotTesterQueueView.prototype.update.appendBuild):
3450         (BuildbotTesterQueueView.prototype.update):
3451         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:
3452         (.queue-view .queueLabel):
3453         (.queue-view .queueLabel:not(:first-child)):
3454         Make the header a link instead of a label, and wire it up to overviewURL.
3455
3456 2013-11-18  Samuel White  <samuel_white@apple.com>
3457
3458         AX: Add ability to fetch only visible table rows.
3459         https://bugs.webkit.org/show_bug.cgi?id=124430
3460
3461         Reviewed by Chris Fleizach.
3462
3463         Adding method to fetch array of AccessibilityUIElements to help with test brevity and test breakage. Specifically, we
3464         have a good deal of churn any time we add or update an element attribute. This happens because the number of tests
3465         that rely on a simple element description text dump to verify a single attribute is non trivial. So any time you
3466         change add an attribute, you have to update all the tests that are now implicitly verifying this new attribute. But
3467         as the test guidelines state, our tests should be more focused and specific about what they test.
3468
3469         * DumpRenderTree/AccessibilityUIElement.cpp:
3470         (uiElementArrayAttributeValueCallback):
3471         (AccessibilityUIElement::uiElementArrayAttributeValue):
3472         (AccessibilityUIElement::getJSClass):
3473         * DumpRenderTree/AccessibilityUIElement.h:
3474         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3475         (AccessibilityUIElement::uiElementArrayAttributeValue):
3476         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3477         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
3478         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3479         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3480         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3481         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
3482         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3483         (WTR::AccessibilityUIElement::getUIElementsWithAttribute):
3484         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
3485
3486 2013-11-18  Ryosuke Niwa  <rniwa@webkit.org>
3487
3488         Simplify and reformat the output of performance tests inside test runners
3489         https://bugs.webkit.org/show_bug.cgi?id=124496
3490
3491         Reviewed by Antti Koivisto.
3492
3493         As a preparation to support subtests for Dromaeo and DoYouEvenBench, simplify the output
3494         performance tests generate. Instead of spitting out noise in PerfTestRunner (runner.js)
3495         and ignoring it in PerfTest._filter_output (perftest.py), simply avoid generating it in
3496         the first place.
3497
3498         Also modernize the output to adopt "metric" concept better and make it forward compatible
3499         with subtests.
3500
3501         With this patch, performance tests written using runner.js only produces empty lines or
3502         lines of the following format inside test runners (DumpRenderTree and WebKitTestRunner):
3503         <subtest name> -> [<value 1>, <value 2>, ...]
3504         :<metric name> -> [<value 1>, <value 2>, ...]
3505
3506         This greatly simplifies the parsing logic inside PerfTest._run_with_driver.
3507
3508         * Scripts/webkitpy/performance_tests/perftest.py:
3509         (PerfTest): Removed a bunch of regular expressions that are no longer used.
3510         (PerfTest._run_with_driver): Just parse the values and description and treat everything
3511         else as errors.
3512
3513         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3514         (TestPerfTest.test_parse_output): Removed the junk.
3515         (TestPerfTest._assert_failed_on_line): Extracted from test_parse_output_with_failing_line,
3516         which was removed in favor of the tests below.
3517         (TestPerfTest.test_parse_output_with_running_five_times): Added.
3518         (TestPerfTest.test_parse_output_with_detailed_info): Added.
3519         (TestPerfTest.test_parse_output_with_statistics): Added.
3520         (TestPerfTest.test_parse_output_with_description): Removed the junk.
3521         (TestPerfTest.test_parse_output_with_subtests): Ditto.
3522         (TestSingleProcessPerfTest.test_use_only_one_process): Ditto.
3523
3524         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3525         (EventTargetWrapperTestData): Ditto.
3526         (SomeParserTestData): Ditto.
3527         (MemoryTestData): Ditto.
3528
3529 2013-11-18  Tim Horton  <timothy_horton@apple.com>
3530
3531         Occasionally, hundreds of tests fail with small text diffs on Mavericks
3532         https://bugs.webkit.org/show_bug.cgi?id=124312
3533
3534         Reviewed by Simon Fraser.
3535
3536         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3537         (Manager._set_up_run):
3538         * Scripts/webkitpy/port/base.py:
3539         (Port.to.reset_preferences):
3540         * Scripts/webkitpy/port/mac.py:
3541         (MacPort.reset_preferences):
3542         Delete DumpRenderTree and WebKitTestRunner defaults domains before running tests,
3543         returning some of the functionality of 158652 after 159364 removed it.
3544
3545 2013-11-18  Tim Horton  <timothy_horton@apple.com>
3546
3547         Checkmarks are shifted down on iPhone at build.webkit.org/dashboard
3548         https://bugs.webkit.org/show_bug.cgi?id=122909
3549
3550         Reviewed by Alexey Proskuryakov.
3551
3552         Put the checkmark SVG in the CSS file as a data URI so it loads immediately.
3553
3554         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3555         (.status-line .bubble):
3556         (.status-line.good .bubble.pictogram):
3557
3558 2013-11-18  Ryosuke Niwa  <rniwa@webkit.org>
3559
3560         Remove _lines_to_ignore_in_stderr, which was only used in Chromium port
3561         https://bugs.webkit.org/show_bug.cgi?id=124499
3562
3563         Reviewed by Csaba Osztrogonác.
3564
3565         Removed the code. I didn't like this hack back when it was added, and I don't like it today.
3566
3567         * Scripts/webkitpy/performance_tests/perftest.py:
3568         (PerfTest._should_ignore_line):
3569         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3570         (TestPerfTest): Removed the unit test.
3571
3572 2013-11-17  Filip Pizlo  <fpizlo@apple.com>
3573
3574         Unreviewed, fix this script for older Rubies where Pathname doesn't coerce to String
3575         quite as easily.
3576         
3577         With help from Andy Trick.
3578
3579         * Scripts/export-llvm-build:
3580
3581 2013-11-15  Filip Pizlo  <fpizlo@apple.com>
3582
3583         FTL should have an explicit notion of bytecode liveness
3584         https://bugs.webkit.org/show_bug.cgi?id=124181
3585
3586         Reviewed by Mark Hahnenberg.
3587
3588         * Scripts/run-jsc-stress-tests:
3589
3590 2013-11-16  Dan Bernstein  <mitz@apple.com>
3591
3592         No way for policy client to determine if a the response’s MIME type can be shown
3593         https://bugs.webkit.org/show_bug.cgi?id=124445
3594
3595         Reviewed by Sam Weinig.
3596
3597         * MiniBrowser/mac/WK2BrowserWindowController.m:
3598         (decidePolicyForResponse): Added canShowMIMEType parameter.
3599         (-[WK2BrowserWindowController awakeFromNib]): Updated for changes in the policy client.
3600
3601         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3602         (TestWebKitAPI::decidePolicyForResponse): Added canShowMIMEType parameter.
3603
3604         * WebKitTestRunner/TestController.cpp:
3605         (WTR::TestController::createWebViewWithOptions): Updated for changes in the policy client.
3606         (WTR::TestController::decidePolicyForResponse): Added canShowMIMEType parameter.
3607         * WebKitTestRunner/TestController.h:
3608
3609 2013-11-16  Tim Horton  <timothy_horton@apple.com>
3610
3611         Checkmarks are shifted down on iPhone at build.webkit.org/dashboard
3612         https://bugs.webkit.org/show_bug.cgi?id=122909
3613
3614         Reviewed by Timothy Hatcher.
3615
3616         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/checkmark.svg: Added.
3617         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
3618         (StatusLineView.prototype.set repeatCount):
3619         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3620         (.status-line.good .bubble.pictogram):
3621         Use an SVG image instead of an obscure font for the checkboxes so they
3622         render identically on all platforms.
3623
3624 2013-11-15  Tim Horton  <timothy_horton@apple.com>
3625
3626         Occasionally, hundreds of tests fail with small text diffs on Mavericks
3627         https://bugs.webkit.org/show_bug.cgi?id=124312
3628
3629         Reviewed by Alexey Proskuryakov.
3630
3631         Try reverting the part of r158652 that deleted all of the persistent
3632         defaults, in the thought that there might be some sort of race between
3633         processes causing some settings to be left in the wrong state.
3634
3635         * DumpRenderTree/mac/DumpRenderTree.mm:
3636         (setDefaultsToConsistentValuesForTesting):
3637         * WebKitTestRunner/mac/main.mm:
3638         (setDefaultsToConsistentValuesForTesting):
3639
3640 2013-11-15  Dan Bernstein  <mitz@apple.com>
3641
3642         Give the policy client the originating frame of a navigation action
3643         https://bugs.webkit.org/show_bug.cgi?id=124431
3644
3645         Reviewed by Anders Carlsson.
3646
3647         * MiniBrowser/mac/WK2BrowserWindowController.m:
3648         (decidePolicyForNavigationAction): Added originatingFrame parameter.
3649         (-[WK2BrowserWindowController awakeFromNib]): Updated for the new version of the policy
3650         client.
3651
3652         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
3653         (TestWebKitAPI::decidePolicyForNavigationAction): Added originatingFrame parameter.
3654         (TestWebKitAPI::setPagePolicyClient): Updated for the new version of the policy client.
3655
3656         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3657         (TestWebKitAPI::decidePolicyForNavigationAction): Added originatingFrame parameter.
3658         (TestWebKitAPI::TEST): Updated for the new version of the policy client.
3659
3660         * WebKitTestRunner/TestController.cpp:
3661         (WTR::TestController::createWebViewWithOptions): Updated for the new version of the policy
3662         client.
3663         (WTR::TestController::decidePolicyForNavigationAction): Added originatingFrame parameter.
3664         * WebKitTestRunner/TestController.h:
3665
3666 2013-11-15  Tim Horton  <timothy_horton@apple.com>
3667
3668         build.webkit.org/dashboard should provide a way to focus on a subset of bots
3669         https://bugs.webkit.org/show_bug.cgi?id=122676
3670
3671         Reviewed by Timothy Hatcher.
3672
3673         Add a small 'hide' button next to every platform logo, and a 'show all'
3674         button which only appears when at least one platform is hidden. Hidden
3675         platforms persist using localStorage.
3676
3677         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
3678         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3679         (updateHiddenPlatforms):
3680         (documentReady.unhideButton):
3681         (documentReady.hideButton):
3682         (documentReady):
3683         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js: Added.
3684         (Settings.prototype.setObject):
3685         (Settings.prototype.getObject):
3686         (Settings.prototype.addSettingListener):
3687         (Settings.prototype.fireSettingListener):
3688         (Settings.prototype.toggleHiddenPlatform):
3689         (Settings.prototype.clearHiddenPlatforms):
3690         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3691         (div.cellButton):
3692         (div.cellButton.hide):
3693         (.hidden):
3694         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
3695
3696 2013-11-15  Jer Noble  <jer.noble@apple.com>
3697
3698         MediaTime addition and subtraction operators have errors when the rhs is infinite.
3699         https://bugs.webkit.org/show_bug.cgi?id=124413
3700
3701         Reviewed by Eric Carlson.
3702
3703         Add a test for operator+ and operator- where an infinite value appears
3704         on the right-hand side:
3705         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3706         (TestWebKitAPI::TEST):
3707
3708         Add a LLDB summary provider for MediaTime which displays the rational
3709         time as well as the value in seconds:
3710         * lldb/lldb_webkit.py:
3711         (__lldb_init_module):
3712         (WTFMediaTime_SummaryProvider):
3713         (WTFHashTableProvider.has_children):
3714         (WTFMediaTimeProvider):
3715         (WTFMediaTimeProvider.__init__):
3716         (WTFMediaTimeProvider.timeValue):
3717         (WTFMediaTimeProvider.timeScale):
3718         (WTFMediaTimeProvider.isInvalid):
3719         (WTFMediaTimeProvider.isPositiveInfinity):
3720         (WTFMediaTimeProvider.isNegativeInfinity):
3721         (WTFMediaTimeProvider.isIndefinite):
3722
3723 2013-11-15  Tim Horton  <timothy_horton@apple.com>
3724
3725         Make it possible to select revision numbers on build.webkit.org/dashboard
3726         https://bugs.webkit.org/show_bug.cgi?id=124400
3727
3728         Reviewed by Timothy Hatcher.
3729
3730         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3731         (BuildbotQueueView.prototype.revisionLinksForIteration):
3732         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3733         (.selectable):
3734         Add a child span to the trac link, which has '-webkit-user-select: all' on it.
3735         This way, a Dashboard user can highlight revision numbers for easy copying,
3736         and doesn't even have to be precise about the selection.
3737
3738 2013-11-15  Tim Horton  <timothy_horton@apple.com>
3739
3740         Adjust and add retina versions of EFL and GTK build.webkit.org/dashboard icons
3741         https://bugs.webkit.org/show_bug.cgi?id=124399
3742
3743         Reviewed by Gustavo Noronha Silva.
3744
3745         Add new EFL and GTK icons (derived from Wikipedia's SVGs) to make new 1x and 2x icons,
3746         with the icons adjusted to have solid backgrounds, to not be squished, and to not
3747         intersect the ring, similar to the Mac icons.
3748
3749         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png:
3750         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Added.
3751         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png:
3752         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK@2x.png: Added.
3753         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3754         (documentReady.hideButton):
3755         (documentReady):
3756         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3757         (table.queue-grid tr.platform.linux-gtk img.logo):
3758         (table.queue-grid tr.platform.linux-efl img.logo):
3759
3760 2013-11-15  Stephane Jadaud  <sjadaud@sii.fr>
3761
3762         [GStreamer] Add support for Media Source API
3763         https://bugs.webkit.org/show_bug.cgi?id=99065
3764
3765         Reviewed by Philippe Normand.
3766
3767         * Scripts/webkitperl/FeatureList.pm:
3768
3769 2013-11-15  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3770
3771         [GTK] Bumping GStreamer version to 1.2.1 for the dependencies
3772         https://bugs.webkit.org/show_bug.cgi?id=124360
3773
3774         Reviewed by Philippe Normand.
3775
3776         * gtk/jhbuild.modules: Bumped GStreamer version up to 1.2.1
3777
3778 2013-11-14  Brent Fulgham  <bfulgham@apple.com>
3779
3780         [Win] Improve support for command line builds of 64-bit JSC
3781         https://bugs.webkit.org/show_bug.cgi?id=124380
3782
3783         Reviewed by David Kilzer.
3784
3785         * Scripts/webkitdirs.pm:
3786         (argumentsForConfiguration): Recognize all flavors of Debug and Release (i.e., 'Debug',
3787         'Debug|Win32', 'Debug|x64') when passing arguments to child processes.
3788         (determinePassedConfiguration): Don't suffix configuration with "|Win32" or "|x64". That's
3789         what the "$configurationForVisualStudio" value is for.
3790
3791 2013-11-14  Oliver Hunt  <oliver@apple.com>
3792
3793         Make CLoop easier to build, and make it work
3794         https://bugs.webkit.org/show_bug.cgi?id=124359
3795
3796         Reviewed by Geoffrey Garen.
3797
3798         Add --cloop support to forcibly enable to CLoop build
3799
3800         * Scripts/build-jsc:
3801         * Scripts/build-webkit:
3802
3803 2013-11-14  Lucas Forschler  <lforschler@apple.com>
3804
3805         Add webkit slave.
3806
3807         Unreviewed.
3808
3809         * BuildSlaveSupport/build.webkit.org-config/config.json:
3810
3811 2013-11-14  Tim Horton  <timothy_horton@apple.com>
3812
3813         build.webkit.org/dashboard can’t open different results in two new tabs
3814         https://bugs.webkit.org/show_bug.cgi?id=124383
3815
3816         Reviewed by Alexey Proskuryakov.
3817
3818         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3819         (BuildbotQueueView.prototype.revisionLinksForIteration):
3820         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
3821         (StatusLineView.prototype._clicked):
3822         Use _blank (which is effectively open-in-new-tab, in Safari) instead of _new (which isn't a
3823         real pseudo-target and instead acts as a named target and will end up causing all link clicks
3824         to open in the same secondary tab).
3825
3826 2013-11-14  Anders Carlsson  <andersca@apple.com>
3827
3828         Remove duplicate entry.
3829
3830         * Scripts/webkitpy/common/config/contributors.json:
3831
3832 2013-11-14  Krzysztof Czech  <k.czech@samsung.com>
3833
3834         [ATK] Change WKTR/DRT AX methods to use nullptr 
3835         https://bugs.webkit.org/show_bug.cgi?id=124352
3836
3837         Reviewed by Anders Carlsson.
3838
3839         Change WKTR/DRT accessibility related methods to use nullptr.
3840
3841         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
3842         (AccessibilityController::AccessibilityController):
3843         (AccessibilityController::elementAtPoint):
3844         (AccessibilityController::removeNotificationListener):
3845         (AccessibilityController::childElementById):
3846         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp:
3847         (AccessibilityNotificationHandler::AccessibilityNotificationHandler):
3848         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3849         (AccessibilityUIElement::elementAtPoint):
3850         (AccessibilityUIElement::linkedUIElementAtIndex):
3851         (AccessibilityUIElement::getChildAtIndex):
3852         (AccessibilityUIElement::titleUIElement):
3853         (AccessibilityUIElement::parentElement):
3854         (AccessibilityUIElement::subrole):
3855         (AccessibilityUIElement::roleDescription):
3856         (AccessibilityUIElement::orientation):
3857         (AccessibilityUIElement::ariaDropEffects):
3858         (AccessibilityUIElement::uiElementForSearchPredicate):
3859         (AccessibilityUIElement::cellForColumnAndRow):
3860         (AccessibilityUIElement::disclosedRowAtIndex):
3861         (AccessibilityUIElement::ariaOwnsElementAtIndex):
3862         (AccessibilityUIElement::ariaFlowToElementAtIndex):
3863         (AccessibilityUIElement::selectedRowAtIndex):
3864         (AccessibilityUIElement::rowAtIndex):
3865         (AccessibilityUIElement::disclosedByRow):
3866         (AccessibilityUIElement::removeNotificationListener):
3867         (AccessibilityUIElement::classList):
3868         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3869         (WTR::AccessibilityController::logAccessibilityEvents):
3870         (WTR::AccessibilityController::resetToConsistentState):
3871         (WTR::childElementById):
3872         (WTR::AccessibilityController::accessibleElementById):
3873         (WTR::AccessibilityController::removeNotificationListener):
3874         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3875         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
3876         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
3877         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3878         (WTR::AccessibilityUIElement::elementAtPoint):
3879         (WTR::AccessibilityUIElement::childAtIndex):
3880         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
3881         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
3882         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
3883         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
3884         (WTR::AccessibilityUIElement::rowAtIndex):
3885         (WTR::AccessibilityUIElement::selectedChildAtIndex):
3886         (WTR::AccessibilityUIElement::selectedRowAtIndex):
3887         (WTR::AccessibilityUIElement::titleUIElement):
3888         (WTR::AccessibilityUIElement::parentElement):
3889         (WTR::AccessibilityUIElement::disclosedByRow):
3890         (WTR::AccessibilityUIElement::uiElementAttributeValue):
3891         (WTR::AccessibilityUIElement::orientation):
3892         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
3893         (WTR::AccessibilityUIElement::cellForColumnAndRow):
3894         (WTR::AccessibilityUIElement::horizontalScrollbar):
3895         (WTR::AccessibilityUIElement::verticalScrollbar):
3896         (WTR::AccessibilityUIElement::removeNotificationListener):
3897         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
3898         (WTR::AccessibilityUIElement::previousTextMarker):
3899         (WTR::AccessibilityUIElement::nextTextMarker):
3900         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
3901         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
3902         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
3903         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
3904         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
3905         (WTR::AccessibilityUIElement::textMarkerForPoint):
3906         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
3907         (WTR::AccessibilityUIElement::textMarkerForIndex):
3908         (WTR::AccessibilityUIElement::supportedActions):
3909         (WTR::AccessibilityUIElement::pathDescription):
3910         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
3911         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
3912         (WTR::AccessibilityUIElement::classList):
3913
3914 2013-11-14  Éva Balázsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
3915
3916         run-perf-tests should warn loudly if you're using a Debug build.
3917         https://bugs.webkit.org/show_bug.cgi?id=105236
3918
3919         Reviewed by Csaba Osztrogonác.
3920
3921         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3922         (PerfTestsRunner.run):
3923
3924 2013-11-14  Éva Balázsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
3925
3926         Fix Tools/Scripts/webkitpy/port/factory.py --help to display which configuration is default
3927         https://bugs.webkit.org/show_bug.cgi?id=124143
3928
3929         Reviewed by Csaba Osztrogonác.
3930
3931         * Scripts/webkitpy/port/factory.py:
3932         (configuration_options):
3933
3934 2013-11-13  Anders Carlsson  <andersca@apple.com>
3935
3936         Add a Vector constructor that takes an std::initializer_list
3937         https://bugs.webkit.org/show_bug.cgi?id=124287
3938
3939         Reviewed by Antti Koivisto.
3940
3941         * TestWebKitAPI/Tests/WTF/Vector.cpp:
3942         (TestWebKitAPI::TEST):
3943
3944 2013-11-13  Mario Sanchez Prada  <mario.prada@samsung.com>
3945
3946         Unreviewed GTK gardening. Updated rebaseline unit tests to include WK2 bot.
3947
3948         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3949         (TestRebaselineTest.test_baseline_directory): Updated.
3950
3951 2013-11-13  Krzysztof Czech  <k.czech@samsung.com>
3952
3953         [ATK] Support compilation of EFL/GTK without accessibility
3954         https://bugs.webkit.org/show_bug.cgi?id=122448
3955
3956         Reviewed by Chris Fleizach.
3957
3958         Added missing HAVE(ACCESSIBILITY) guards and stubs to ATK's related files,
3959         so that in case of turning off the HAVE_ACCESSIBILITY macro EFL/GTK would compile properly.
3960
3961         * DumpRenderTree/AccessibilityController.h:
3962         * DumpRenderTree/AccessibilityUIElement.h:
3963         * DumpRenderTree/atk/AccessibilityCallbacks.h:
3964         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp:
3965         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h:
3966         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3967         (WTR::AccessibilityController::rootElement):
3968         (WTR::AccessibilityController::focusedElement):
3969         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3970         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3971         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3972         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h:
3973         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3974         * WebKitTestRunner/PlatformEfl.cmake:
3975
3976 2013-11-12  Ryuan Choi  <ryuan.choi@samsung.com>
3977
3978         [EFL] Added libxss-dev to install-dependencies
3979         https://bugs.webkit.org/show_bug.cgi?id=124254
3980
3981         Reviewed by Gyuyoung Kim.
3982
3983         libxss-dev is required to build EFL packages.
3984         see building part in http://www.enlightenment.org/p.php?p=contribute
3985
3986         * efl/install-dependencies: Added libxss-dev to parameter of apt-get command.
3987
3988 2013-11-12  Tim Horton  <timothy_horton@apple.com>
3989
3990         After http://trac.webkit.org/changeset/159109, update
3991         rebaseline_unittest to use the new GTK bot names.
3992
3993         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3994         (TestRebaselineTest.test_baseline_directory):
3995
3996 2013-11-12  Denis Nomiyama  <d.nomiyama@samsung.com>
3997
3998         [GTK] Update GTK builders in Tools/Scripts/webkitpy/port/builders.py
3999         https://bugs.webkit.org/show_bug.cgi?id=124144
4000
4001         Reviewed by Gustavo Noronha Silva.
4002
4003         Updated the list of GTK builders in Tools/Scripts/webkitpy/port/builders.py
4004         according to http://build.webkit.org/builders.
4005
4006         * Scripts/webkitpy/port/builders.py:
4007
4008 2013-11-11  Samuel White  <samuel_white@apple.com>
4009
4010         AX: support helpText() in DumpRenderTree
4011         https://bugs.webkit.org/show_bug.cgi?id=40194
4012
4013         Reviewed by Chris Fleizach.
4014
4015         Implemented stubbed helpText methods so we can move aria-help.html back to LayoutTests/accessibility.
4016
4017         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
4018         (AccessibilityUIElement::helpText):
4019
4020 2013-11-11  Anders Carlsson  <andersca@apple.com>
4021
4022         Remove block based APIs from the WebKit2 C API
4023         https://bugs.webkit.org/show_bug.cgi?id=124157
4024
4025         Reviewed by Sam Weinig.
4026
4027         Update for WK2 changes.
4028
4029         * MiniBrowser/mac/WK2BrowserWindowController.m:
4030         (dumpSource):
4031         (-[WK2BrowserWindowController dumpSourceToConsole:]):
4032
4033 2013-11-11  Tamas Gergely  <gertom@inf.u-szeged.hu>
4034
4035         The feeder queue will not feed patches older than one week.
4036         https://bugs.webkit.org/show_bug.cgi?id=107152
4037
4038         Reviewed by Csaba Osztrogonác.
4039
4040         The feeder queue will not feed patches older than one week.
4041         Unit test added to this scenario.
4042
4043         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4044         (BugzillaQueries._parse_attachment_ids_request_query):
4045           Handle date parameter.
4046         (BugzillaQueries):
4047         (BugzillaQueries._fetch_attachment_ids_request_query):
4048           Propagate date.
4049         (BugzillaQueries.fetch_attachment_ids_from_review_queue):
4050           Propagate date.
4051         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
4052         (MockBugzillaQueries.fetch_attachment_ids_from_review_queue):
4053           Handle date.
4054         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
4055         (test_request_page_parsing):
4056           Unit test added.
4057         * Scripts/webkitpy/tool/bot/feeders.py:
4058         (EWSFeeder.feed):
4059           Query patch ids with date parameter (now - 1 week).
4060
4061 2013-11-11  Tamas Gergely  <gertom@inf.u-szeged.hu>
4062
4063         Do not shut down ImageDiff server after every diff during the tests.
4064         https://bugs.webkit.org/show_bug.cgi?id=124140
4065
4066         Reviewed by Csaba Osztrogonác.
4067
4068         There was a FIXME: There is no need to shut down the ImageDiff
4069         server after every diff. Shutdown is removed from that point.
4070
4071         * Scripts/webkitpy/port/image_diff.py:
4072         (ImageDiffer._read):
4073
4074 2013-11-08  Matthew Hanson  <matthew_hanson@apple.com>
4075
4076         Unreviewed. Added myself as a contributor.
4077
4078         * Scripts/webkitpy/common/config/contributors.json:
4079
4080 2013-11-08  Krzysztof Czech  <k.czech@samsung.com>
4081
4082         [GTK] accessibility/aria-link-supports-press.html is failing
4083         https://bugs.webkit.org/show_bug.cgi?id=98355
4084
4085         Reviewed by Mario Sanchez Prada.
4086
4087         Checking "jump" action for link elements. Action "jump" occurs when a link 
4088         element is pressed/clicked.
4089
4090         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
4091         (AccessibilityUIElement::isPressActionSupported):
4092         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4093         (WTR::AccessibilityUIElement::isPressActionSupported):
4094
4095 2013-11-08  Przemyslaw Szymanski  <p.szymanski3@samsung.com>
4096
4097         [JHBUILD] Jhbuild Makefile build bug workaround
4098         https://bugs.webkit.org/show_bug.cgi?id=123971
4099
4100         Reviewed by Ryosuke Niwa.
4101
4102         After Jhbuild repository is cloned (for instance when you use
4103         Tools/Scripts/update-webkitefl-libs) it is built from sources.
4104         If you have GREP_OPTIONS grep env variable set (for instance
4105         GREP_OPTIONS=-n) then it is jhbuild build error. Makefile.plain
4106         uses shell grep. For specific GREP_OPTIONS grep output will be
4107         different than expected one by Jhbuild and there is an error
4108         with Jhbuild build. Jhbuild will not be built and then WebKit
4109         source also will not be built. This patch is a workaround to this
4110         issue. It disables GREP_OPTIONS for Jhbuild build time.
4111
4112         * jhbuild/jhbuild-wrapper:
4113         (install_jhbuild):
4114
4115 2013-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
4116
4117         [GTK] Ignore deprecated macros when generating gtk-doc
4118         https://bugs.webkit.org/show_bug.cgi?id=123988
4119
4120         Reviewed by Philippe Normand.
4121
4122         * gtk/generate-gtkdoc:
4123         (get_common_options): Ignore also WEBKIT_DEPRECATED and
4124         WEBKIT_DEPRECATED_FOR decorators.
4125
4126 2013-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
4127
4128         [GTK] Pass the library namespace to gtkdoc-mkdb
4129         https://bugs.webkit.org/show_bug.cgi?id=123900
4130
4131         Reviewed by Martin Robinson.
4132
4133         This fixes the generation of the index of symbols in the API
4134         documentation.
4135
4136         * gtk/generate-gtkdoc:
4137         (get_webkit2_options): Define namespace as WebKit.
4138         (get_webkit1_options): Ditto.
4139         (get_webkitdom_options): Define namespace as WebKitDOM.
4140         * gtk/gtkdoc.py:
4141         (GTKDoc.__init__): Add namespace option.
4142         (GTKDoc._run_gtkdoc_mkdb): Pass namespace to mkdb if present.
4143
4144 2013-11-07  Chris Fleizach  <cfleizach@apple.com>
4145
4146         Modify email order list for James Craig so his primary email is first.
4147
4148         * Scripts/webkitpy/common/config/contributors.json:
4149
4150 2013-11-07  Nick Diego Yamane  <nick.yamane@openbossa.org>
4151
4152         [Gtk] Disable LTO when building cairo
4153         https://bugs.webkit.org/show_bug.cgi?id=123954
4154
4155         Reviewed by Martin Robinson.
4156
4157         Cairo always uses LTO, when it detects compiler support.
4158         LTO is buggy in many/all versions of GCC and shouldn't be enabled by
4159         default. This patch disables LTO when building cairo library.
4160         - See: https://bugs.freedesktop.org/show_bug.cgi?id=60852
4161
4162         With gcc 4.7.3, for example, the build fails with the following message:
4163         'lto1: fatal error: LTO_tags out of range: Range is 0 to 361, value is 15872'
4164
4165         * gtk/jhbuild.modules:
4166
4167 2013-11-07  Samuel White  <samuel_white@apple.com>
4168
4169         AX: DRT AccessibilityUIElement::isFocused methods should be finished.
4170         https://bugs.webkit.org/show_bug.cgi?id=123774
4171
4172         Reviewed by Chris Fleizach.
4173
4174         Implemented AccessibilityUIElement::isFocused methods and removed FIXMEs.
4175
4176         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4177         (AccessibilityUIElement::isFocused):
4178         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4179         (WTR::AccessibilityUIElement::isFocused):
4180
4181 2013-11-07  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
4182
4183         Removed retrieveQMakespecVar function
4184         https://bugs.webkit.org/show_bug.cgi?id=123996
4185
4186         Reviewed by Csaba Osztrogonác.
4187
4188         * Scripts/webkitdirs.pm:
4189
4190 2013-11-07  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
4191
4192         Removed QMake related filters
4193         https://bugs.webkit.org/show_bug.cgi?id=123992
4194
4195         Reviewed by Csaba Osztrogonác.
4196
4197         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
4198         (TestRebaseline.test_rebaseline):
4199         (TestRebaselineExpectations.test_rebaseline_expectations):
4200
4201 2013-11-07  Nick Diego Yamane  <nick.yamane@openbossa.org>
4202
4203         [Efl] Disable LTO when building cairo
4204         https://bugs.webkit.org/show_bug.cgi?id=123947
4205
4206         Reviewed by Gyuyoung Kim.
4207
4208         Cairo always uses LTO, when it detects compiler support.
4209         LTO is buggy in many/all versions of GCC and shouldn't be enabled by
4210         default. This patch disables LTO when building cairo library.
4211         - See: https://bugs.freedesktop.org/show_bug.cgi?id=60852
4212
4213         With gcc 4.7.3, for example, the build fails with the following message:
4214         'lto1: fatal error: LTO_tags out of range: Range is 0 to 361, value is 15872'
4215
4216         * efl/jhbuild.modules:
4217
4218 2013-11-07  Mario Sanchez Prada  <mario.prada@samsung.com>
4219
4220         AX: [ATK] Video and audio elements are not properly exposed
4221         https://bugs.webkit.org/show_bug.cgi?id=123894
4222
4223         Reviewed by Chris Fleizach.
4224
4225         Update DRT and WKTR to handle the ATK_ROLE_EMBEDDED role.
4226
4227         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: Updated.
4228         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Updated.
4229
4230 2013-11-07  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
4231
4232         Change git_commit_from_svn_revision() to work in a pure git checkout
4233         https://bugs.webkit.org/show_bug.cgi?id=111668
4234
4235         Reviewed by Ryosuke Niwa.
4236
4237         * Scripts/webkitpy/common/checkout/scm/git.py:
4238         (Git.git_commit_from_svn_revision):
4239
4240 2013-11-06  Jer Noble  <jer.noble@apple.com>
4241
4242         Unreviewed webkitpy unit test fix; update baselines after r158765
4243
4244         * Scripts/webkitpy/port/win_unittest.py:
4245         (WinPortTest.test_baseline_search_path):
4246
4247 2013-11-06  Jer Noble  <jer.noble@apple.com>
4248
4249         [Win] run-webkit-tests on the win platform should fall back to mac-mountainlion, not mac-lion.
4250         https://bugs.webkit.org/show_bug.cgi?id=123905
4251
4252         Reviewed by Brent Fulgham.
4253
4254         Now that the mac-lion results have been removed, the win port should fall back to
4255         the mac-mountainlion results.
4256
4257         * Scripts/webkitpy/port/win.py:
4258         (WinPort.default_baseline_search_path):
4259
4260 2013-11-06  Anders Carlsson  <andersca@apple.com>
4261
4262         Fix a Mountain Lion test failure.
4263
4264         NSURLRequest doesn't conform to NSSecureCoding on Mountain Lion, so don't try to test encoding it.
4265
4266         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
4267         (TestWebKitAPI::TEST):
4268
4269 2013-11-06  Krzysztof Czech  <k.czech@samsung.com>
4270
4271         [ATK] Implement tables-related attributesOf*() functions for AccessibilityUIElement
4272         https://bugs.webkit.org/show_bug.cgi?id=118969
4273
4274         Reviewed by Mario Sanchez Prada.
4275
4276         Added missing implementation of attributesOfColumnHeaders, attributesOfRowHeaders, attributesOfVisibleCells.
4277
4278         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
4279         (AccessibilityUIElement::attributesOfChildren):
4280         (AccessibilityUIElement::attributesOfColumnHeaders):
4281         (AccessibilityUIElement::attributesOfRowHeaders):
4282         (AccessibilityUIElement::attributesOfVisibleCells):
4283         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4284         (WTR::AccessibilityUIElement::attributesOfChildren):
4285         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
4286         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
4287         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
4288
4289 2013-11-05  Benjamin Poulain  <benjamin@webkit.org>
4290
4291         [WK2] Add a WebKit2 API for Geolocation's highAccuracy
4292         https://bugs.webkit.org/show_bug.cgi?id=123786
4293
4294         Reviewed by Darin Adler.
4295
4296         Add basic testing for the Geolocation API (start, stop and change accuracy).
4297
4298         * TestWebKitAPI/GNUmakefile.am:
4299         * TestWebKitAPI/PlatformEfl.cmake:
4300         * TestWebKitAPI/PlatformGTK.cmake:
4301         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4302         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp: Added.
4303         (TestWebKitAPI::operator<<):
4304         (TestWebKitAPI::GeolocationStateTracker::~GeolocationStateTracker):
4305         (TestWebKitAPI::GeolocationStateTracker::eventsChanged):
4306         (TestWebKitAPI::GeolocationStateTracker::startUpdatingCallback):
4307         (TestWebKitAPI::GeolocationStateTracker::stopUpdatingCallback):
4308         (TestWebKitAPI::GeolocationStateTracker::setEnableHighAccuracyCallback):
4309         (TestWebKitAPI::decidePolicyForGeolocationPermissionRequestCallBack):
4310         (TestWebKitAPI::setupGeolocationProvider):
4311         (TestWebKitAPI::setupView):
4312         (TestWebKitAPI::GeolocationBasicStateTracker::GeolocationBasicStateTracker):
4313         (TestWebKitAPI::GeolocationBasicStateTracker::eventsChanged):
4314         (TestWebKitAPI::GeolocationBasicWithHighAccuracyStateTracker::GeolocationBasicWithHighAccuracyStateTracker):
4315         (TestWebKitAPI::GeolocationBasicWithHighAccuracyStateTracker::eventsChanged):