ff25d9fd792f8d272664e10d0d52706d43851a29
[WebKit-https.git] / Tools / ChangeLog
1 2014-05-05  Pratik Solanki  <psolanki@apple.com>
2
3         Update framework locations in package-root
4         https://bugs.webkit.org/show_bug.cgi?id=132571
5
6         Reviewed by Simon Fraser.
7
8         * Scripts/package-root:
9
10 2014-05-05  Ryuan Choi  <ryuan.choi@samsung.com>
11
12         [EFL][WK2] Refactor favicon database APIs
13         https://bugs.webkit.org/show_bug.cgi?id=132519
14
15         Reviewed by Gyuyoung Kim.
16
17         * MiniBrowser/efl/main.c: Use ewk_favicon_database_icon_get instead of ewk_view_favicon_get.
18         (update_view_favicon):
19         (on_icon_changed_cb):
20         (window_free):
21         (on_url_changed):
22         (window_create):
23         (on_view_favicon_changed): Deleted.
24
25 2014-05-02  Mark Rowe  <mrowe@apple.com>
26
27         <https://webkit.org/b/132505> Make it possible to tell copy-webkitlibraries-to-product-directory which OS X version to copy for
28
29         Reviewed by Dan Bernstein.
30
31         * Scripts/copy-webkitlibraries-to-product-directory: Add an --osx-version argument and use the passed value
32         when determining which LLVM archive to extract.
33
34 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
35
36         Add Jeremy as a committer.
37         https://bugs.webkit.org/show_bug.cgi?id=132492
38
39         Reviewed by Jer Noble.
40
41         Add myself as a committer.
42
43         * Scripts/webkitpy/common/config/contributors.json:
44
45 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
46
47         Add Jeremy as a committer.
48         https://bugs.webkit.org/show_bug.cgi?id=132492
49
50         Reviewed by Jer Noble.
51
52         Add Jeremy Jones to the committers file.
53
54         * Scripts/webkitpy/common/config/contributors.json:
55
56 2014-05-02  Brian J. Burg  <burg@cs.washington.edu>
57
58         Hard to figure out how to run a single test with run-api-tests
59         https://bugs.webkit.org/show_bug.cgi?id=116332
60
61         Reviewed by Alexey Proskuryakov.
62
63         * Scripts/run-api-tests: add two examples to the help message.
64
65 2014-05-02  Simon Fraser  <simon.fraser@apple.com>
66
67         Fix several memory leaks found by code inspection
68         https://bugs.webkit.org/show_bug.cgi?id=132472
69
70         Reviewed by Geoffrey Garen.
71         
72         Fix memory leaks.
73
74         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
75         (TestWebKitAPI::TEST):
76         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
77         (WTR::InjectedBundlePage::willSendRequestForFrame):
78         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
79         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
80
81 2014-05-02  Filip Pizlo  <fpizlo@apple.com>
82
83         DFGAbstractInterpreter should not claim Int52 arithmetic creates Int52s
84         https://bugs.webkit.org/show_bug.cgi?id=132446
85
86         Reviewed by Mark Hahnenberg.
87         
88         Test the FTL by default now that it's enabled by default.
89
90         * Scripts/run-javascriptcore-tests:
91
92 2014-05-01  Ryuan Choi  <ryuan.choi@samsung.com>
93
94         [EFL][WK1] Drop ewk_view_setting_tiled_backingstore APIs
95         https://bugs.webkit.org/show_bug.cgi?id=132240
96
97         Reviewed by Anders Carlsson.
98
99         Removed ewk_view_setting_tiled_backingstore related code.
100
101         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
102         (DumpRenderTreeChrome::createView):
103         (shouldUseTiledBackingStore): Deleted.
104         * EWebLauncher/main.c:
105         (windowCreate):
106         (parseUserArguments):
107
108 2014-05-01  Anders Carlsson  <andersca@apple.com>
109
110         window.testRunner.keepWebHistory() should update the UI process state
111         https://bugs.webkit.org/show_bug.cgi?id=132440
112
113         Reviewed by Dan Bernstein.
114
115         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
116         (WTR::InjectedBundle::postSetAddsVisitedLinks):
117         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
118         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
119         (WTR::TestRunner::keepWebHistory):
120         * WebKitTestRunner/TestInvocation.cpp:
121         (WTR::TestInvocation::invoke):
122         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
123
124 2014-05-01  David Kilzer  <ddkilzer@apple.com>
125
126         Really remove ENABLE_PLUGIN_PROXY_FOR_VIDEO
127         <http://webkit.org/b/132432>
128
129         Reviewed by Tim Horton.
130
131         * Scripts/webkitperl/FeatureList.pm: Remove support for
132         --plugin-proxy-for-video switch.
133
134 2014-04-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
135
136         Kernel sysctl interface hw.activecpu don't exists on Linux.
137         https://bugs.webkit.org/show_bug.cgi?id=132286
138
139         Reviewed by Filip Pizlo.
140
141         * Scripts/run-jsc-stress-tests: Redirect stderr to null when
142         calling sysctl over hw.activecpu
143
144 2014-04-30  Anders Carlsson  <andersca@apple.com>
145
146         Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework
147         https://bugs.webkit.org/show_bug.cgi?id=132399
148         <rdar://problem/15920046>
149
150         Reviewed by Dan Bernstein.
151
152         * Scripts/check-for-webkit-framework-include-consistency:
153         Allos WAK headers in WebKitLegacy as well as WebKit.
154
155         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
156         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
157         Update header imports.
158
159 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
160
161         [iOS WK2] Add test URL to crash reports for the UI process, clean up project
162         https://bugs.webkit.org/show_bug.cgi?id=131954
163
164         Reviewed by Darin Adler.
165         
166         WebKitTestRunner was adding application-specific information to crash reports
167         to log the test path, but only in the web process. Fix it to also do this
168         for the UI process, for both iOS and OS X.
169         
170         Moved InjectedBundlePageMac.mm to InjectedBundlePageCocoa.mm and compile it for
171         both iOS and OS X.
172         
173         Factored crash reprorter-related code into CrashReporterInfo, and call it from
174         a new TestController::platformWillRunTest() function on Mac and iOS.
175         
176         Also remove Xcode-added unit test junk from the project.
177
178         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
179         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
180         * WebKitTestRunner/TestController.cpp:
181         (WTR::TestController::runTest):
182         * WebKitTestRunner/TestController.h:
183         * WebKitTestRunner/TestInvocation.cpp:
184         (WTR::TestInvocation::url):
185         * WebKitTestRunner/TestInvocation.h:
186         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
187         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Removed.
188         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Removed.
189         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Removed.
190         * WebKitTestRunner/cocoa/CrashReporterInfo.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
191         * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Renamed from Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm.
192         (WTR::testPathFromURL):
193         (WTR::setCrashReportApplicationSpecificInformationToURL):
194         * WebKitTestRunner/efl/TestControllerEfl.cpp:
195         (WTR::TestController::platformWillRunTest):
196         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
197         (WTR::TestController::platformWillRunTest):
198         * WebKitTestRunner/ios/TestControllerIOS.mm:
199         (WTR::TestController::platformWillRunTest):
200         (WTR::TestController::setHidden):
201         * WebKitTestRunner/mac/TestControllerMac.mm:
202         (WTR::TestController::platformWillRunTest):
203
204 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
205
206         Fix DRT assertion about mock scrollbars, which doesn't apply to iOS.
207
208         Reviewed by Tim Horton.
209
210         * DumpRenderTree/mac/DumpRenderTree.mm:
211         (resetWebPreferencesToConsistentValues):
212         (prepareConsistentTestingEnvironment):
213
214 2014-04-30  Anders Carlsson  <andersca@apple.com>
215
216         check-for-inappropriate-macros-in-external-headers should get the product name, not the project name
217         https://bugs.webkit.org/show_bug.cgi?id=132397
218
219         Reviewed by Dan Bernstein.
220
221         * Scripts/check-for-inappropriate-macros-in-external-headers:
222
223 2014-04-29  Martin Robinson  <mrobinson@igalia.com>
224
225         [GTK] Make it easier to run CMake for downstreams
226         https://bugs.webkit.org/show_bug.cgi?id=132370
227
228         Reviewed by Carlos Garcia Campos.
229
230         * Scripts/webkitdirs.pm:
231         (generateBuildSystemFromCMakeProject): Pass -DDEVELOPER_MODE when building
232         the GTK+ port.
233
234 2014-04-29  Stephanie Lewis  <slewis@apple.com>
235
236         <rdar://problem/16765765> Use JSON::PP in perl scripts instead of JSON.
237         
238         Rubber stamped by Jessie Berlin.
239
240         JSON.pm was removed from our tools setup.
241
242         * Scripts/generate-coverage-data:
243
244 2014-04-29  Filip Pizlo  <fpizlo@apple.com>
245
246         Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)
247         https://bugs.webkit.org/show_bug.cgi?id=112840
248
249         Rubber stamped by Geoffrey Garen.
250
251         * Scripts/build-jsc: Enable it on Mac.
252         * Scripts/build-webkit: Enable it on Mac.
253         * Scripts/export-llvm-build: Make it slightly easier to export the build if you've done a "make install".
254
255 2014-04-28  Sam Weinig  <sam@webkit.org>
256
257         REGRESSION (r167751): svn-create-patch is very slow
258         https://bugs.webkit.org/show_bug.cgi?id=132300
259
260         Reviewed by Alexey Proskuryakov.
261
262         * Scripts/svn-create-patch:
263         Change default behavior of svn-create-patch to no longer run the style checker. It can still be run
264         by calling `svn-create-patch --style`.
265
266 2014-04-29  Enrique Ocaña González  <eocanha@igalia.com>
267
268         Generate Eclipse project + ninja build for GTK+ if Eclipse in available in the PATH
269         https://bugs.webkit.org/show_bug.cgi?id=132190
270
271         Reviewed by Gustavo Noronha Silva.
272
273         * Scripts/webkitdirs.pm:
274         (canUseEclipse): Test if Eclipse is in the path. This is the same method used to test
275             if ninja is in the path.
276         (generateBuildSystemFromCMakeProject): Use the eclipse generator if possible, fallback
277             to the previous ninja generator if not.
278
279 2014-04-29  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
280
281         check-webkit-style should understand --git-index
282         https://bugs.webkit.org/show_bug.cgi?id=125364
283
284         Reviewed by Csaba Osztrogonác.
285
286         * Scripts/webkitpy/common/checkout/scm/git.py:
287         (Git.create_patch): The command now supports the --cached option.
288         * Scripts/webkitpy/style/main.py:
289         (CheckWebKitStyle.main): Passing the --git-index option.
290         * Scripts/webkitpy/style/optparser.py:
291         (CommandOptionValues.__init__): The git-index option is switched off by default.
292         (CommandOptionValues.__eq__): Equality check for the new option.
293         (ArgumentParser._create_option_parser):Adding the --git-index option
294         (ArgumentParser.parse):
295         * Scripts/webkitpy/style/optparser_unittest.py: New tests for the --git-index option
296         (CommandOptionValuesTest.test_init): 
297         (CommandOptionValuesTest.test_eq):
298
299 2014-04-28  Michael Saboff  <msaboff@apple.com>
300
301         Crash in platform/mac/accessibility/table-visible-rows.html
302         https://bugs.webkit.org/show_bug.cgi?id=132146
303
304         Reviewed by Filip Pizlo.
305
306         Instead of creating a local JSValueRef array on the stack and passing that to
307         JSObjectMakeArray(), changed to create an empty JSArray and then populate the
308         values using the JSObjectSetPropertyAtIndex() API.
309
310         * DumpRenderTree/AccessibilityUIElement.cpp:
311         (elementsForRangeCallback):
312         (convertElementsToObjectArray):
313         * DumpRenderTree/mac/TestRunnerMac.mm:
314         (originsArrayToJS):
315         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
316         (WTR::EventSendingController::contextClick):
317         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
318         (WTR::stringArrayToJS):
319         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
320         (WTR::convertElementsToObjectArray):
321
322 2014-04-28  Filip Pizlo  <fpizlo@apple.com>
323
324         Make sure that the coverage of our tests doesn't change much if we change the thresholds now and in the future, but making
325         "no-cjit" runs force the old-school threshold.
326
327         Rubber stamped by Mark Hahnenberg.
328
329         * Scripts/run-jsc-stress-tests:
330
331 2014-04-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
332
333         [GTK] install-dependencies should also install ruby-json and ruby-highline
334         https://bugs.webkit.org/show_bug.cgi?id=132292
335
336         Reviewed by Philippe Normand.
337
338         * gtk/install-dependencies: Install ruby json and highline packages.
339
340 2014-04-27  Joonghun Park  <jh718.park@samsung.com>
341
342         [EFL] Remove indexedDB's dependency on leveldb and disable indexedDB
343         https://bugs.webkit.org/show_bug.cgi?id=132176
344
345         Reviewed by Gyuyoung Kim.
346
347         EFL port will use sqlite to support indexedDB. So, this patch removes levelDB dependency
348         and turn off indexedDB feature until the sqlite implementation is introduced.
349
350         * Scripts/webkitperl/FeatureList.pm:
351
352 2014-04-25  James Craig  <jcraig@apple.com>
353
354         Set prepare-Changelog flag so that it no longer runs check-webkit-style by default
355         https://bugs.webkit.org/show_bug.cgi?id=132209
356
357         Reviewed by Daniel Bates.
358
359         Set default to --no-style to avoid additional spew from false positives in check-webkit-style.
360         Run check-webkit-style before generating changelogs to avoid additional spurious errors.
361
362         * Scripts/prepare-ChangeLog:
363         (main): 
364
365 2014-04-25  Michael Saboff  <msaboff@apple.com>
366
367         Crash in platform/mac/accessibility/table-visible-rows.html
368         https://bugs.webkit.org/show_bug.cgi?id=132146
369
370         Reviewed by Mark Lam.
371
372         Changed to use a local JSValueRef array temporary instead of a
373         std::make_unique<JSValueRef[]> when making an array of JSValues so that the temporary
374         JSValues are visited during garbage collection when the stack is scanned.  Otherwise,
375         the temporary values could be collected.
376
377         * DumpRenderTree/AccessibilityUIElement.cpp:
378         (convertElementsToObjectArray):
379         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
380         (WTR::EventSendingController::contextClick):
381         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
382         (WTR::convertElementsToObjectArray):
383
384 2014-04-24  Eduardo Lima Mitev  <elima@igalia.com>
385
386         Unreviewed GTK gardening
387
388         * Scripts/run-gtk-tests: Skips one flaky accesibility test in WK2API suite
389         (TestRunner):
390
391 2014-04-24  László Langó  <llango.u-szeged@partner.samsung.com>
392
393         prepare-ChangeLog reports as deleted methods that has not been removed.
394         https://bugs.webkit.org/show_bug.cgi?id=131733
395
396         Reviewed by Ryosuke Niwa.
397
398         * Scripts/prepare-ChangeLog:
399         (originalFile): Set merge base to origin/master by default.
400
401 2014-04-23  James Craig  <jcraig@apple.com>
402
403         prepare-Changelog and svn-create-patch should optionally run check-webkit-style.
404         https://bugs.webkit.org/show_bug.cgi?id=131115
405
406         Reviewed by Daniel Bates.
407
408         Added [--[no-]style] param to run check-webkit-style as part of prepare-Changelog and svn-create-patch.
409
410         * Scripts/commit-log-editor: Added --no-style.
411         * Scripts/prepare-ChangeLog: Primary patch.
412         (main): Primary patch.
413         (createPatchCommand): Added --no-style.
414         * Scripts/svn-create-patch: Primary patch.
415         * Scripts/webkit-tools-completion.sh: Added --style and --no-style.
416         * Scripts/webkitpy/common/checkout/scm/svn.py: Added --no-style.
417         (SVN.create_patch): Added --no-style.
418
419 2014-04-23  Anders Carlsson  <andersca@apple.com>
420
421         Try to fix iOS build.
422
423         * DumpRenderTree/mac/DumpRenderTree.mm:
424
425 2014-04-23  Alexey Proskuryakov  <ap@apple.com>
426
427         Eliminate internals.setMockScrollbarsEnabled()
428         https://bugs.webkit.org/show_bug.cgi?id=132085
429
430         Reviewed by Tim Horton.
431
432         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues):
433         No need to reset the preference, there is no way it can change.
434
435 2014-04-23  James Craig  <jcraig@apple.com>
436
437         Unreviewed. Moving myself from Contributors to Committers list.
438
439         * Scripts/webkitpy/common/config/contributors.json:
440
441 2014-04-23  Tim Horton  <timothy_horton@apple.com>
442
443         Mock scrollbars don't always work in DumpRenderTree
444         https://bugs.webkit.org/show_bug.cgi?id=132082
445
446         Reviewed by Alexey Proskuryakov.
447
448         * DumpRenderTree/mac/DumpRenderTree.mm:
449         (prepareConsistentTestingEnvironment):
450         Set the mock scrollbar setting before creating the WebView, as this setting
451         cannot be dynamically changed, so any scrollbars that are created during
452         WebView initialization and are not replaced before snapshotting will end
453         up being platform scrollbars instead of mock ones.
454         WebKitTestRunner already sets this preference before creating WKViews,
455         so we're just matching its behavior.
456
457 2014-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
458
459         [GTK] ShadowRoot API was removed in r164131
460         https://bugs.webkit.org/show_bug.cgi?id=132059
461
462         Reviewed by Gustavo Noronha Silva.
463
464         Add WebKitDOMShadowRoot to the list of deleted classes to generate
465         the API docs.
466
467         * gtk/webkitdom.py:
468         (WebKitDOMDocGenerator):
469
470 2014-04-23  Lorenzo Tilve  <ltilve@igalia.com>
471
472         [GTK] run-webkit-tests script is failing to invoke run-launcher
473         https://bugs.webkit.org/show_bug.cgi?id=132051
474
475         Reviewed by Philippe Normand.
476
477         After the WK1 support was dropped, if run-webkit-tests is executed
478         without --no-show-results parameter, the launcher is being called
479         using a -2 parameter that is it causing the run-launcher to break.
480
481         * Scripts/webkitpy/port/gtk.py:
482         (GtkPort.show_results_html_file):
483
484 2014-04-22  Tim Horton  <timothy_horton@apple.com>
485
486         DumpRenderTree generates black snapshots on some platforms
487         https://bugs.webkit.org/show_bug.cgi?id=132029
488         <rdar://problem/16679363>
489
490         Reviewed by Simon Fraser.
491
492         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
493         (createBitmapContextFromWebView):
494         DRT checks with the WebView to determine whether it can use the window's
495         backing store directly or (because of compositing) needs to take a WindowServer
496         snapshot. However, on some platforms and in some situations, the window can
497         be layer backed without the WebView necessarily currently being composited.
498         We should check with the window in addition to the WebView before going
499         ahead and using its backing store.
500
501 2014-04-22  Tim Horton  <timothy_horton@apple.com>
502
503         DumpRenderTree generates white snapshots on some platforms
504         https://bugs.webkit.org/show_bug.cgi?id=132026
505         <rdar://problem/16679363>
506
507         Reviewed by Simon Fraser.
508
509         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
510         Link DRT against QuartzCore.
511
512         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
513         (createBitmapContextFromWebView):
514         Force CoreAnimation to synchronously update layers in a more explicit
515         way that doesn't depend on AppKit behavior. This is very similar to what
516         WebKitTestRunner does (indirectly) during its force repaint.
517
518 2014-04-22  Brent Fulgham  <bfulgham@apple.com>
519
520         [Win] Support Python 2.7 in Cygwin
521         https://bugs.webkit.org/show_bug.cgi?id=132023
522
523         Reviewed by Michael Saboff.
524
525         * Scripts/webkitdirs.pm:
526         (checkInstalledTools): Remove check for Python 2.7, since
527         it now works properly.
528
529 2014-04-22  Filip Pizlo  <fpizlo@apple.com>
530
531         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
532         https://bugs.webkit.org/show_bug.cgi?id=130867
533         <rdar://problem/16432456> 
534
535         Reviewed by Mark Hahnenberg.
536
537         * Scripts/build-webkit:
538         * Scripts/copy-webkitlibraries-to-product-directory:
539
540 2014-04-22  Gustavo Noronha Silva  <gns@gnome.org>
541
542         [GTK] Fails to build documentation when output is redirected
543         https://bugs.webkit.org/show_bug.cgi?id=131178
544
545         Reviewed by Martin Robinson.
546
547         * gtk/generate-gtkdoc: set the output for stdout and stderr to UTF-8
548         explicitly to avoid encoding issues when they are redirected.
549
550 2014-04-22  ChangSeok Oh  <changseok.oh@collabora.com>
551
552         [GTK] YCM choose a newer compile_commands.json in between Release or Debug
553         https://bugs.webkit.org/show_bug.cgi?id=131911
554
555         Reviewed by Martin Robinson.
556
557         common.get_build_path returns release path even though Debug configuration
558         is newer than Release. So YouCompleteMe is used to refer old build setup inadvertently.
559
560         * gtk/ycm_extra_conf.py:
561         (get_build_path): Compare modified time of Release and Debug. And return a recent modified path.
562         (FlagsForFile):
563
564 2014-04-21  Brent Fulgham  <bfulgham@apple.com>
565
566         Unreviewed build fix.
567
568         * DumpRenderTree/mac/EventSendingController.mm:
569         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
570         Correct a typo that prevented tests from working properly.
571
572 2014-04-21  Martin Robinson  <mrobinson@igalia.com>
573
574         [GTK] Should have the ability to output composited contents during layout testing
575         https://bugs.webkit.org/show_bug.cgi?id=131864
576
577         Reviewed by Philippe Normand.
578
579         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
580         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Add a path that paints the widget contents
581         to an image surface. We run the main loop a bit to match the implementation from WebKit1 and EFL.
582         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
583         (WTR::PlatformWebView::windowSnapshotImage): Use the new UI-process path on GTK+.
584
585 2014-04-21  Sam Weinig  <sam@webkit.org>
586
587         Attempt to fix the tests.
588
589         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
590         (-[DidFailProvisionalNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
591         Add policy handler to override the new default of denying loads that NSURLConnection cannot handle.
592
593 2014-04-21  Filip Pizlo  <fpizlo@apple.com>
594
595         Unreviewed test gardening, make no-eager runs run everything except eager (as opposed to
596         being the same as a "quick run", which is meant for genuinely slow tests).
597
598         * Scripts/run-jsc-stress-tests:
599
600 2014-04-21  Darin Adler  <darin@apple.com>
601
602         Add HashSet::takeAny
603         https://bugs.webkit.org/show_bug.cgi?id=131928
604
605         Reviewed by Benjamin Poulain.
606
607         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Added a test for takeAny.
608
609 2014-04-20  Dan Bernstein  <mitz@apple.com>
610
611         Fixed a test timing out after r167572.
612
613         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
614         (-[NavigationDelegate webView:didFinishNavigation:]): Renamed from
615         -webView:didFinishLoadingNavigation:.
616
617 2014-04-20  Commit Queue  <commit-queue@webkit.org>
618
619         Unreviewed, rolling out r167510.
620         https://bugs.webkit.org/show_bug.cgi?id=131915
621
622         broke GTK Debug bot (Requested by philn on #webkit).
623
624         Reverted changeset:
625
626         "[GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force
627         it when running layout tests"
628         https://bugs.webkit.org/show_bug.cgi?id=131472
629         http://trac.webkit.org/changeset/167510
630
631 2014-04-18  Martin Robinson  <mrobinson@igalia.com>
632
633         [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
634         https://bugs.webkit.org/show_bug.cgi?id=131472
635
636         Reviewed by Philippe Normand.
637
638         * Scripts/webkitpy/port/gtk.py:
639         (GtkPort.setup_environ_for_server): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
640         when running WebKitTestRunner with run-webkit-tests.
641         * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
642         installed.
643         * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
644         how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
645         calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
646         deal.
647
648 2014-04-18  Alexey Proskuryakov  <ap@apple.com>
649
650         DownloadDecideDestinationCrash API test uses an incorrect value for path
651         https://bugs.webkit.org/show_bug.cgi?id=131845
652         <rdar://problem/15925560>
653
654         Reviewed by Enrica Casucci.
655
656         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
657         (TestWebKitAPI::decideDestinationWithSuggestedFilename):
658
659 2014-04-17  Alexey Proskuryakov  <ap@apple.com>
660
661         [Mac] AttributedStringTest API tests fail with async text input
662         https://bugs.webkit.org/show_bug.cgi?id=131833
663
664         Reviewed by Enrica Casucci.
665
666         Don't run sync NSTextInputClient tests where we don't implement these calls.
667
668         * TestWebKitAPI/Tests/mac/AttributedString.mm:
669         (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
670         (TestWebKitAPI::AttributedStringTest_CustomFont::runSyncTest):
671         (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
672         (TestWebKitAPI::AttributedStringTest_Strikethrough::runSyncTest):
673         (TestWebKitAPI::AttributedStringTest_CustomFont::runTest): Deleted.
674         (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest): Deleted.
675
676 2014-04-18  Philippe Normand  <pnormand@igalia.com>
677
678         Remove NETWORK_INFO support
679         https://bugs.webkit.org/show_bug.cgi?id=131841
680
681         Reviewed by Gyuyoung Kim.
682
683         * Scripts/webkitperl/FeatureList.pm:
684
685 2014-04-17  ChangSeok Oh  <changseok.oh@collabora.com>
686
687         [GTK] YouCompleteMe doesn't work for cmake build system.
688         https://bugs.webkit.org/show_bug.cgi?id=131591
689
690         Reviewed by Martin Robinson.
691
692         Add cmake build system support for YouCompleteMe. It should work regardless of
693         using make or ninja. In addition, autotools related code is removed since it's
694         not used anymore in WebKit.
695
696         * Scripts/webkitdirs.pm:
697         (generateBuildSystemFromCMakeProject):
698         * gtk/ycm_extra_conf.py:
699         (transform_relative_paths_to_absolute_paths):
700         (FlagsForFile):
701
702 2014-04-17  Anders Carlsson  <andersca@apple.com>
703
704         Fix build.
705
706         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
707         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
708         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
709
710 2014-04-17  Anders Carlsson  <andersca@apple.com>
711
712         Remove unused API enums
713         https://bugs.webkit.org/show_bug.cgi?id=131836
714
715         Reviewed by Tim Horton.
716
717         * MiniBrowser/mac/WK2BrowserWindowController.m:
718         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
719
720 2014-04-16  Brent Fulgham  <bfulgham@apple.com>
721
722         [Win] A few final cleanups to the DataObject classes.
723         https://bugs.webkit.org/show_bug.cgi?id=131784
724
725         Reviewed by Anders Carlsson.
726
727         * DumpRenderTree/win/DRTDataObject.cpp:
728         (DRTDataObject::clearData): Use 'last()' method.
729         * DumpRenderTree/win/UIDelegate.cpp:
730         (DRTUndoStack::pop): Use 'takeLast()' method.
731
732 2014-04-17  Andres Gomez  <agomez@igalia.com>
733
734         [Win] cygwin to keep installing curl 7.33.0-1 and subversion 1.7.14-1
735         https://bugs.webkit.org/show_bug.cgi?id=131365
736
737         Reviewed by Brent Fulgham.
738
739         The cygwin installer is now downloading the wanted versions for
740         the local installation given to the setup wizard.
741
742         * CygwinDownloader/cygwin-downloader.py:
743         * CygwinDownloader/cygwin-downloader.zip:
744
745 2014-04-17  Adrian Perez de Castro  <aperez@igalia.com>
746
747         [GTK] Make run-webkit-tests always use WKTR
748         https://bugs.webkit.org/show_bug.cgi?id=131737
749
750         Reviewed by Darin Adler.
751
752         Now that the GTK+ port only has support for WebKit2, instruct
753         run-webkit-tests to always use WKTR. This avoids needing to pass
754         flag "-2" every time.
755
756         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 
757         (_set_up_derived_options): Always set webkit_test_runner when
758         the platform is GTK+.
759
760 2014-04-17  Brendan Long  <b.long@cablelabs.com>
761
762         [Gtk] Install ninja-build in Tools/gtk/install-dependencies
763         https://bugs.webkit.org/show_bug.cgi?id=131760
764
765         Reviewed by Philippe Normand.
766
767         * gtk/install-dependencies: Install ninja-build when it's available.
768
769 2014-04-16  peavo@outlook.com  <peavo@outlook.com>
770
771         [Win] run-javascriptcore-tests fails to run.
772         https://bugs.webkit.org/show_bug.cgi?id=131761
773
774         Reviewed by Brent Fulgham.
775
776         * Scripts/build-jsc: For now, don't try to build bmalloc on Windows.
777
778 2014-04-16  Andres Gomez  <agomez@igalia.com>
779
780         [Win] Pass default parameters to cygwin setup wizard
781         https://bugs.webkit.org/show_bug.cgi?id=131361
782
783         Reviewed by Brent Fulgham.
784
785         Added some parameters to the cygwin setup wizard so the user
786         doesn't really have to do any interaction.
787
788         * CygwinDownloader/cygwin-downloader.py:
789         * CygwinDownloader/cygwin-downloader.zip:
790
791 2014-04-15  Brent Fulgham  <bfulgham@apple.com>
792
793         [Win] Eliminate use of deleteAllValues in Windows Files
794         https://bugs.webkit.org/show_bug.cgi?id=131631
795
796         Reviewed by Darin Adler.
797
798         Switch to std::unique_ptr for memory lifetime. Get rid of
799         deleteAllValues now that it is no longer needed. Use ranged
800         for loops where possible.
801
802         * DumpRenderTree/win/DRTDataObject.cpp:
803         (WCEnumFormatEtc::WCEnumFormatEtc):
804         (DRTDataObject::~DRTDataObject):
805         (DRTDataObject::GetData):
806         (DRTDataObject::QueryGetData):
807         (DRTDataObject::SetData):
808         (DRTDataObject::clearData):
809         * DumpRenderTree/win/DRTDataObject.h:
810         * DumpRenderTree/win/UIDelegate.cpp:
811         (DRTUndoObject::DRTUndoObject):
812         (DRTUndoObject::~DRTUndoObject):
813         (DRTUndoStack::~DRTUndoStack):
814         (DRTUndoStack::clear):
815         (DRTUndoStack::pop):
816         (DRTUndoManager::DRTUndoManager):
817         (DRTUndoManager::redo):
818         (DRTUndoManager::undo):
819         (UIDelegate::UIDelegate):
820         (UIDelegate::resetUndoManager):
821         * DumpRenderTree/win/UIDelegate.h:
822
823 2014-04-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
824
825         [GTK] Unreviewed GTK gardening.
826
827         Update list of skipped unit tests:
828
829           Skip test: WebKit2Gtk/TestWebKitWebView:/webkit2/WebKitWebView/page-visibility
830
831           Unskip tests: WebKit2/TestWebKit2:WebKit2.ResizeReversePaginatedWebView
832           and WebKit2/TestWebKit2:WebKit2.ScrollPinningBehaviors
833
834         * Scripts/run-gtk-tests:
835         (TestRunner):
836
837 2014-04-16  Tim Horton  <timothy_horton@apple.com>
838
839         check-webkit-style doesn't check code style in .mm or .m files
840         https://bugs.webkit.org/show_bug.cgi?id=131708
841
842         Reviewed by Darin Adler.
843
844         * Scripts/webkitpy/style/checker.py:
845         * Scripts/webkitpy/style/checker_unittest.py:
846         (CheckerDispatcherDispatchTest.test_cpp_paths):
847         (CheckerDispatcherDispatchTest.test_text_paths):
848         Check .mm and .m files as C++.
849
850         * Scripts/webkitpy/style/checkers/cpp.py:
851         (check_spacing):
852         Add an override for our ordinary "missing spaces around =" for @synthesize,
853         which should look like "@synthesize propertyName=_varName;"
854
855         Add an override for "missing space before {" for blocks' "^{".
856
857         Don't follow the "extra space before [" rule for Objective-C, because
858         it breaks this rule in a multitude of ways because of method calls.
859
860         (check_braces):
861         Don't complain about { not being on the end of the previous line if
862         the previous line starts with "- (" or "+ (", which would indicate a
863         Objective-C method definition.
864
865 2014-04-16  Darin Adler  <darin@apple.com>
866
867         Make Vector::takeLast work with move-only types (and optimize for types where move is faster)
868         https://bugs.webkit.org/show_bug.cgi?id=131735
869
870         Reviewed by Alexey Proskuryakov.
871
872         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added a test for Vector::takeLast with move only types.
873         Fixed invocations of EXPECT macros so the expected value is on the left, and the test result
874         is on the right. This can be confusing since our JavaScript test framework does it the opposite
875         way, but gtest works better this way.
876
877 2014-04-15  Hyowon Kim  <hw1008.kim@samsung.com>
878
879         [EFL] Fix problems with the pixel dump.
880         https://bugs.webkit.org/show_bug.cgi?id=131265
881
882         Reviewed by Gyuyoung Kim.
883
884         Painting and compositing paths of WebKit-EFL were totally modified from r166768.
885         However pixel dump codes still call deprecated functions like ewk_view_paint(),
886         which causes that nothing is drawn.
887
888         This patch adds new member functions to AcceleratedCompositingContext to support pixel dump.
889         One of new functions is AcceleratedCompositingContext::extractImageData(),
890         which replaces deprecated function calls. Besides the extractImageData() is invoked by
891         ewk_view_screenshot_contents_get() in order to take the visible content displayed on the EFL webview.
892
893         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
894         (createBitmapContextFromWebView): Add to call DumpRenderTreeSupportEfl::forcePaint().
895
896 2014-04-15  Filip Pizlo  <fpizlo@apple.com>
897
898         Update LLVM export scrpt to handle the build directory being different from the
899         source directory.
900
901         Rubber stamped by Geoffrey Garen.
902
903         * Scripts/export-llvm-build:
904
905 2014-04-15  Ryosuke Niwa  <rniwa@webkit.org>
906
907         Update the hyperlink to waterfall views of perf bots on build.webkit.org
908         https://bugs.webkit.org/show_bug.cgi?id=131695
909
910         Reviewed by Antti Koivisto.
911
912         Updated.
913
914         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
915
916 2014-04-15  Carlos Garcia Campos  <cgarcia@igalia.com>
917
918         [GTK] Reduce the binary size by compressing the text based web inspector resources
919         https://bugs.webkit.org/show_bug.cgi?id=121545
920
921         Reviewed by Gustavo Noronha Silva.
922
923         Compress text based files when compiling inspector resources. It
924         reduces the binary size in 3MB.
925
926         * gtk/generate-inspector-gresource-manifest.py:
927         (find_all_files_in_directory):
928         (is_compressible):
929
930 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
931
932         Remove Gtk WebKit1 tester.
933
934         Gtk WebKit1 port no longer exists, and dashboard was trying to load its tester
935         results over and over as fast as it could.
936
937         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
938         (WebKitBuildbot):
939
940 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
941
942         Wrong link for webkitpy tests results in dashboard popover
943         https://bugs.webkit.org/show_bug.cgi?id=131664
944
945         Reviewed by Timothy Hatcher.
946
947         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
948         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
949         Use a correct link.
950
951 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
952
953         Update webkitpy regression test result that started to fail after http://trac.webkit.org/r167243
954
955         I'm not sure whether the changes are desirable, but am not suspicious enough to roll out.
956
957         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
958         (CommitMessageForThisCommitTest):
959
960 2014-04-14  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
961
962         Fix commit-log-editor bug revealed by r165447
963         https://bugs.webkit.org/show_bug.cgi?id=130676
964
965         Reviewed by Csaba Osztrogonác.
966
967         * Scripts/commit-log-editor:
968         (createCommitMessage): Omitting empty Source/JavaScriptCore:... blocks.
969         Add \n before the first block too, because the longest common prefix now ends with only one newline.
970         (removeLongestCommonPrefixEndingInNewline): The longest common prefix ends with only one newline,
971         now the last block of the common prefix isn't duplicated below. Changing the function name accordingly.
972
973 2014-04-13  Darin Adler  <darin@apple.com>
974
975         userVisibleString should not try to "encode" host names
976         https://bugs.webkit.org/show_bug.cgi?id=131587
977         rdar://problem/14686849
978
979         Reviewed by Alexey Proskuryakov.
980
981         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added URLExtras.mm.
982
983         * TestWebKitAPI/Tests/mac/URLExtras.mm: Added. A few tests for WebCoreNSURLExtras.
984         Coverage is tiny at this point; we could add a lot more cases!
985
986 2014-04-13  Jaehun Lim  <ljaehun.lim@samsung.com>
987
988         Use #include instead of #import
989         https://bugs.webkit.org/show_bug.cgi?id=131604
990
991         Reviewed by Darin Adler.
992
993         Fix "warning: #import is a deprecated GCC extension [-Wdeprecated]".
994
995         * TestWebKitAPI/Tests/WTF/StringView.cpp:
996
997 2014-04-12  Filip Pizlo  <fpizlo@apple.com>
998
999         Make slow-stress tests run faster by running fewer VM variants.
1000
1001         Rubber stamped by Geoffrey Garen.
1002
1003         * Scripts/run-javascriptcore-tests:
1004         * Scripts/run-jsc-stress-tests:
1005
1006 2014-04-10  Zan Dobersek  <zdobersek@igalia.com>
1007
1008         [CMake] Add missing WTF unit tests
1009         https://bugs.webkit.org/show_bug.cgi?id=131459
1010
1011         Reviewed by Martin Robinson.
1012
1013         * TestWebKitAPI/CMakeLists.txt: Add a few missing source files
1014         that should be compiled into the TestWTF binary.
1015
1016 2014-04-10  Brendan Long  <b.long@cablelabs.com>
1017
1018         [Gtk] run-launcher doesn't work by default
1019         https://bugs.webkit.org/show_bug.cgi?id=131494
1020
1021         Reviewed by Philippe Normand.
1022
1023         * Scripts/run-launcher: Always use MiniBrowser for WebKitGTK.
1024         * Scripts/webkitdirs.pm:
1025         (launcherName): Same.
1026         * Scripts/webkitpy/style/checker.py: Remove reference to GtkLauncher.
1027         * gtk/common.py:
1028         (get_build_path.is_valid_build_directory): Same.
1029         * gtk/manifest.txt: Same.
1030
1031 2014-04-09  Commit Queue  <commit-queue@webkit.org>
1032
1033         Unreviewed, rolling out r167046.
1034         https://bugs.webkit.org/show_bug.cgi?id=131479
1035
1036         Caused 300+ failures on Mavericks WK1 tester (Requested by ap
1037         on #webkit).
1038
1039         Reverted changeset:
1040
1041         "Remove "System Font" from whitelisted DRT fonts and char
1042         width calculations"
1043         https://bugs.webkit.org/show_bug.cgi?id=131411
1044         http://trac.webkit.org/changeset/167046
1045
1046 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
1047
1048         Remove "System Font" from whitelisted DRT fonts and char width calculations
1049         https://bugs.webkit.org/show_bug.cgi?id=131411
1050
1051         Reviewed by Tim Horton.
1052
1053         Covered by existing tests.
1054
1055         * DumpRenderTree/mac/DumpRenderTree.mm:
1056         (allowedFontFamilySet):
1057
1058 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
1059
1060         systemHiddenFontFamilySet in DRT is unnecessary
1061         https://bugs.webkit.org/show_bug.cgi?id=131414
1062
1063         Reviewed by Tim Horton.
1064
1065         It doesn't seem to affect test results on my machine.
1066
1067         * DumpRenderTree/mac/DumpRenderTree.mm:
1068         (drt_NSFontManager_availableFonts):
1069         (systemHiddenFontFamilySet): Deleted.
1070
1071 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
1072
1073         [Win] Unreviewed test fix: Don't double-release BSTR.
1074
1075         * DumpRenderTree/win/DumpRenderTree.cpp:
1076         (dump): Remove unneeded call to SysFreeString now that we are
1077         using _bstr_t for this variable.
1078
1079 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
1080
1081         [Win] Various DumpRenderTree Fixes.
1082         https://bugs.webkit.org/show_bug.cgi?id=131446.
1083
1084         Reviewed by Tim Horton.
1085
1086         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1087         (AccessibilityUIElement::title): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1088         (AccessibilityUIElement::description): Ditto.
1089         (AccessibilityUIElement::helpText): Ditto.
1090         (AccessibilityUIElement::intValue): Ditto.
1091         (AccessibilityUIElement::isPressActionSupported): Ditto.
1092         (AccessibilityUIElement::accessibilityValue): Ditto.
1093         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1094         (DRTDesktopNotificationPresenter::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1095         (DRTDesktopNotificationPresenter::AddRef): Ditto.
1096         (DRTDesktopNotificationPresenter::Release): Ditto.
1097         (DRTDesktopNotificationPresenter::showDesktopNotification): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1098         (DRTDesktopNotificationPresenter::cancelDesktopNotification): Ditto.
1099         (DRTDesktopNotificationPresenter::notificationDestroyed): Ditto.
1100         (DRTDesktopNotificationPresenter::checkNotificationPermission): Ditto.
1101         (DRTDesktopNotificationPresenter::requestNotificationPermission): Ditto.
1102         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
1103         * DumpRenderTree/win/DumpRenderTree.cpp:
1104         (dumpFrameScrollPosition): Ditto.
1105         (dumpFramesAsText): Ditto.
1106         (compareHistoryItems): Ditto.
1107         (dumpHistoryItem): Ditto.
1108         (dump): Ditto.
1109         (resetDefaultsToConsistentValues): Ditto.
1110         (resetWebViewToConsistentStateBeforeTesting): Ditto.
1111         (runTest): Ditto.
1112         (createWebViewAndOffscreenWindow): Ditto.
1113         * DumpRenderTree/win/EditingDelegate.cpp:
1114         (EditingDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1115         (EditingDelegate::AddRef): Ditto.
1116         (EditingDelegate::Release): Ditto.
1117         (dumpPath): Switch to _bstr_t. Use JSStringCreateWithBSTR
1118         (EditingDelegate::shouldBeginEditingInDOMRange): Get rid of uneeded STDMETHODCALLTYPE declaration.
1119         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
1120         (EditingDelegate::shouldInsertNode): Ditto.
1121         (EditingDelegate::shouldInsertText): Ditto.
1122         (EditingDelegate::shouldDeleteDOMRange): Ditto.
1123         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
1124         (EditingDelegate::shouldApplyStyle): Ditto.
1125         (EditingDelegate::shouldChangeTypingStyle): Ditto.
1126         (EditingDelegate::doPlatformCommand): Ditto.
1127         (EditingDelegate::webViewDidBeginEditing): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1128         (EditingDelegate::webViewDidChange): Ditto.
1129         (EditingDelegate::webViewDidEndEditing): Ditto.
1130         (EditingDelegate::webViewDidChangeTypingStyle): Ditto.
1131         (EditingDelegate::webViewDidChangeSelection): Ditto.
1132         (EditingDelegate::checkSpellingOfString): Ditto.
1133         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1134         (descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1135         (FrameLoadDelegate::FrameLoadDelegate): Ditto.
1136         (FrameLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1137         (FrameLoadDelegate::AddRef): Ditto.
1138         (FrameLoadDelegate::Release): Ditto.
1139         (FrameLoadDelegate::didStartProvisionalLoadForFrame): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1140         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
1141         (FrameLoadDelegate::didFailProvisionalLoadWithError): Ditto.
1142         (FrameLoadDelegate::didCommitLoadForFrame): Ditto.
1143         (FrameLoadDelegate::didReceiveTitle): Ditto.
1144         (FrameLoadDelegate::didChangeIcons): Ditto.
1145         (delegatesWithDelayedWork): Ditto.
1146         (FrameLoadDelegate::didFinishLoadForFrame): Ditto.
1147         (FrameLoadDelegate::didFailLoadWithError): Ditto.
1148         (FrameLoadDelegate::willPerformClientRedirectToURL): Ditto.
1149         (FrameLoadDelegate::didCancelClientRedirectForFrame): Ditto.
1150         (FrameLoadDelegate::willCloseFrame): Ditto.
1151         (FrameLoadDelegate::didFinishDocumentLoadForFrame): Ditto.
1152         (FrameLoadDelegate::didHandleOnloadEventsForFrame): Ditto.
1153         (FrameLoadDelegate::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
1154         (FrameLoadDelegate::didDisplayInsecureContent): Ditto.
1155         (FrameLoadDelegate::didRunInsecureContent): Ditto.
1156         * DumpRenderTree/win/FrameLoadDelegate.h:
1157         * DumpRenderTree/win/HistoryDelegate.cpp:
1158         (HistoryDelegate::didNavigateWithNavigationData): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1159         (HistoryDelegate::updateHistoryTitle): Ditto.
1160         (HistoryDelegate::populateVisitedLinksForWebView): Ditto.
1161         * DumpRenderTree/win/PolicyDelegate.cpp:
1162         (dumpPath):
1163         (PolicyDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1164         (PolicyDelegate::AddRef): Ditto.
1165         (PolicyDelegate::Release): Ditto.
1166         (PolicyDelegate::decidePolicyForNavigationAction): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1167         (PolicyDelegate::unableToImplementPolicyWithError): Ditto.
1168         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1169         (ResourceLoadDelegate::descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1170         (ResourceLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1171         (ResourceLoadDelegate::AddRef): Ditto.
1172         (ResourceLoadDelegate::Release): Ditto.
1173         (ResourceLoadDelegate::identifierForInitialRequest): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1174         (ResourceLoadDelegate::removeIdentifierForRequest): Ditto.
1175         (ResourceLoadDelegate::willSendRequest): Ditto.
1176         (ResourceLoadDelegate::didReceiveAuthenticationChallenge): Ditto.
1177         (ResourceLoadDelegate::didReceiveResponse): Ditto.
1178         (ResourceLoadDelegate::didFinishLoadingFromDataSource): Ditto.
1179         (ResourceLoadDelegate::didFailLoadingWithError): Ditto.
1180         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
1181         (TestRunner::queueLoad): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1182         (TestRunner::setUserStyleSheetLocation): Ditto.
1183         (TestRunner::execCommand): Ditto.
1184         (TestRunner::overridePreference): Ditto.
1185         (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
1186         * DumpRenderTree/win/TextInputControllerWin.cpp: Ditto.
1187         (TextInputController::setMarkedText): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1188         (TextInputController::insertText): Ditto.
1189         * DumpRenderTree/win/UIDelegate.cpp:
1190         (UIDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1191         (UIDelegate::AddRef): Ditto.
1192         (UIDelegate::Release): Ditto.
1193         (UIDelegate::hasCustomMenuImplementation): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1194         (UIDelegate::trackCustomPopupMenu): Ditto.
1195         (UIDelegate::registerUndoWithTarget): Ditto.
1196         (UIDelegate::removeAllActionsWithTarget): Ditto.
1197         (UIDelegate::setActionTitle): Ditto.
1198         (UIDelegate::undo): Ditto.
1199         (UIDelegate::redo): Ditto.
1200         (UIDelegate::canUndo): Ditto.
1201         (UIDelegate::canRedo): Ditto.
1202         (UIDelegate::printFrame): Ditto.
1203         (UIDelegate::ftpDirectoryTemplatePath): Ditto.
1204         (UIDelegate::webViewHeaderHeight): Ditto.
1205         (UIDelegate::webViewFooterHeight): Ditto.
1206         (UIDelegate::drawHeaderInRect): Ditto.
1207         (UIDelegate::drawFooterInRect): Ditto.
1208         (UIDelegate::webViewPrintingMarginRect): Ditto.
1209         (UIDelegate::canRunModal): Ditto.
1210         (UIDelegate::createModalDialog): Ditto.
1211         (UIDelegate::runModal): Ditto.
1212         (UIDelegate::isMenuBarVisible): Ditto.
1213         (UIDelegate::setMenuBarVisible): Ditto.
1214         (UIDelegate::runDatabaseSizeLimitPrompt): Ditto.
1215         (UIDelegate::paintCustomScrollbar): Ditto.
1216         (UIDelegate::paintCustomScrollCorner): Ditto.
1217         (UIDelegate::setFrame): Ditto.
1218         (UIDelegate::webViewFrame): Ditto.
1219         (UIDelegate::runJavaScriptAlertPanelWithMessage): Ditto.
1220         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
1221         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
1222         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
1223         (UIDelegate::webViewAddMessageToConsole): Ditto.
1224         (UIDelegate::doDragDrop): Ditto.
1225         (UIDelegate::webViewGetDlgCode): Ditto.
1226         (UIDelegate::createWebViewWithRequest): Ditto.
1227         (UIDelegate::webViewClose): Ditto.
1228         (UIDelegate::webViewFocus): Ditto.
1229         (UIDelegate::webViewUnfocus): Ditto.
1230         (UIDelegate::webViewPainted): Ditto.
1231         (UIDelegate::exceededDatabaseQuota): Ditto.
1232         (UIDelegate::embeddedViewWithArguments): Ditto.
1233         (UIDelegate::webViewClosing): Ditto.
1234         (UIDelegate::webViewSetCursor): Ditto.
1235         (UIDelegate::webViewDidInvalidate): Ditto.
1236         (UIDelegate::setStatusText): Ditto.
1237         (UIDelegate::desktopNotificationsDelegate): Ditto.
1238         (UIDelegate::drawBackground): Ditto.
1239         (UIDelegate::decidePolicyForGeolocationRequest): Ditto.
1240         (UIDelegate::didPressMissingPluginButton): Ditto.
1241         * DumpRenderTree/win/WorkQueueItemWin.cpp: Ditto.
1242         (LoadItem::invoke):  Switch to _bstr_t. Use JSStringCreateWithBSTR.
1243         (LoadHTMLStringItem::invoke): Ditto.
1244         (ScriptItem::invoke): Ditto.
1245
1246 2014-04-09  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
1247
1248         Stylechecker: False positive on inline asm code.
1249         https://bugs.webkit.org/show_bug.cgi?id=130570
1250
1251         Reviewed by Csaba Osztrogonác.
1252
1253         Disable stylechecking in asm blocks.
1254
1255         * Scripts/webkitpy/style/checkers/cpp.py:
1256         (process_line):
1257         (_InlineASMState):
1258         (_InlineASMState.__init__):
1259         (_InlineASMState.process_line):
1260         (_InlineASMState.isInside):
1261         (_process_lines):
1262         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1263         (WebKitStyleTest.test_member_initialization_list):
1264
1265 2014-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1266
1267         [GTK] Move WebKit1 unit tests resources used by WebKit2 unit tests to WebKit2 resources dir
1268         https://bugs.webkit.org/show_bug.cgi?id=131029
1269
1270         Reviewed by Philippe Normand.
1271
1272         Add blank.ico and test.pdf to resources dir of WebKit2Gtk unit
1273         tests and remove the getWebKit1TestResoucesDir() method.
1274
1275         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1276         (testDownloadLocalFile): Use Test::getResourcesDir().
1277         (testDownloadLocalFileError): Ditto.
1278         (serverCallback): Ditto.
1279         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1280         (serverCallback): Ditto.
1281         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1282         (httpServerCallback): Ditto.
1283         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1284         (serverCallback): Ditto.
1285         * TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico: Added.
1286         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf: Added.
1287         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1288         (Test::getWebKit1TestResoucesDir): Deleted.
1289
1290 2014-04-09  Alexey Proskuryakov  <ap@apple.com>
1291
1292         [WK2] HTTP authentication regression tests fail
1293         https://bugs.webkit.org/show_bug.cgi?id=81627
1294         <rdar://problem/11079296>
1295
1296         Reviewed by Anders Carlsson.
1297
1298         * WebKitTestRunner/TestController.h:
1299         * WebKitTestRunner/TestController.cpp:
1300         (WTR::TestController::createWebViewWithOptions): Added canAuthenticateAgainstProtectionSpaceInFrame
1301         to pageLoaderClient structure.
1302         (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true
1303         for password based authentication (we do get server trust challenges on some tests,
1304         which WKTR can't handle).
1305         When this client call is not implemented or returns false, didReceiveAuthenticationChallengeInFrame
1306         calls won't be made, at least on CFNetwork based platforms.
1307         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Changed the output
1308         to omit <unknown>. The resource is always unknown with WK2, and it doesn't really
1309         make sense to associate auth requests with individual resources - there can be
1310         multiple resources loading at once from the same protection space, so WebKit1 API
1311         that had a resource identifier was inherently racy.
1312
1313 2014-04-09  Ryuan Choi  <ryuan.choi@samsung.com>
1314
1315         [EFL] Change font path for DumpRenderTree and WebKitTestRunner
1316         https://bugs.webkit.org/show_bug.cgi?id=131427
1317
1318         Reviewed by Gyuyoung Kim.
1319
1320         Since r166973, font path was changed.
1321
1322         * DumpRenderTree/PlatformEfl.cmake:
1323         * WebKitTestRunner/PlatformEfl.cmake:
1324
1325 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
1326
1327         Fix the build-jsc build
1328         https://bugs.webkit.org/show_bug.cgi?id=131410
1329
1330         Reviewed by Michael Saboff.
1331
1332         * Scripts/build-jsc: Make sure to build bmalloc before WTF, since
1333         WTF depends on it.
1334
1335 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
1336
1337         [GTK] Remove WebKit1 unit tests
1338         https://bugs.webkit.org/show_bug.cgi?id=131359
1339
1340         Reviewed by Anders Carlsson.
1341
1342         Remove all WebKit1 GTK+ unit tests, in preparation for removing the WebKit1 port
1343         entirely. We also remove the list of skipped WebKi1 tests from run-gtk-tests, as
1344         they were inadvertently left in http://trac.webkit.org/changeset/166504.
1345
1346         * CMakeLists.txt: No longer load the WebKit1 unit test CMakeLists.txt file.
1347         * Scripts/run-gtk-tests: Remove skipped WebKit1 unit tests.
1348         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Removed.
1349         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Removed.
1350         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Removed.
1351         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Removed.
1352         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Removed.
1353         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Removed.
1354         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Removed.
1355         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Removed.
1356         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Removed.
1357         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Removed.
1358         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Removed.
1359         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Removed.
1360         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Removed.
1361         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Removed.
1362         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Removed.
1363         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Removed.
1364         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Removed.
1365         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Removed.
1366         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Removed.
1367         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Removed.
1368         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Removed.
1369         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Removed.
1370         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Removed.
1371         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Removed.
1372         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Removed.
1373         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Removed.
1374         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Removed.
1375         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Removed.
1376         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Removed.
1377         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Removed.
1378         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Removed.
1379         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Removed.
1380         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Removed.
1381         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Removed.
1382         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Removed.
1383         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Removed.
1384
1385 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
1386
1387         Unreviewed gardening (Take 2): Prevent users from attempting
1388         to build with known invalid cURL. 
1389
1390         * Scripts/webkitdirs.pm:
1391         (checkInstalledTools): Check for 7.34.0 (the broken version), not
1392         7.33.0 (the known good version).
1393
1394 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
1395
1396         [GTK] Remove DumpRenderTree and GtkLauncher
1397         https://bugs.webkit.org/show_bug.cgi?id=131373
1398
1399         Reviewed by Andreas Kling.
1400
1401         Remove the GTK+ port of DumpRenderTree and GtkLauncher. These tools are
1402         no longer necessary now that WebKit1 GTK+ will be removed.
1403
1404         * CMakeLists.txt:
1405         * DumpRenderTree/PlatformGTK.cmake: Removed.
1406         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Removed.
1407         * DumpRenderTree/gtk/DumpRenderTree.cpp: Removed.
1408         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Removed.
1409         * DumpRenderTree/gtk/EditingCallbacks.cpp: Removed.
1410         * DumpRenderTree/gtk/EditingCallbacks.h: Removed.
1411         * DumpRenderTree/gtk/EventSender.cpp: Removed.
1412         * DumpRenderTree/gtk/EventSender.h: Removed.
1413         * DumpRenderTree/gtk/GCControllerGtk.cpp: Removed.
1414         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Removed.
1415         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Removed.
1416         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Removed.
1417         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Removed.
1418         * DumpRenderTree/gtk/TextInputController.cpp: Removed.
1419         * DumpRenderTree/gtk/TextInputController.h: Removed.
1420         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Removed.
1421         * GtkLauncher/CMakeLists.txt: Removed.
1422         * GtkLauncher/LauncherInspectorWindow.c: Removed.
1423         * GtkLauncher/LauncherInspectorWindow.h: Removed.
1424         * GtkLauncher/main.c: Removed.
1425         * GtkLauncher/simple.svg: Removed.
1426         * GtkLauncher/text.html: Removed.
1427         * WebKitTestRunner/PlatformGTK.cmake:
1428         * WebKitTestRunner/gtk/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/gtk/fonts/AHEM____.TTF.
1429         * WebKitTestRunner/gtk/fonts/FontWithNoValidEncoding.fon: Renamed from Tools/DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon.
1430         * WebKitTestRunner/gtk/fonts/fonts.conf: Renamed from Tools/DumpRenderTree/gtk/fonts/fonts.conf.
1431
1432 2014-04-08  Mark Rowe  <mrowe@apple.com>
1433
1434         XPC services launched by Safari have wrong DYLD_FRAMEWORK_PATH set when launched via run-safari / debug-safari
1435         <https://webkit.org/b/131388> / <rdar://problem/16291687>
1436
1437         Reviewed by Alexey Proskuryakov.
1438
1439         * Scripts/webkitdirs.pm:
1440         (runMacWebKitApp): Set __XPC_DYLD_FRAMEWORK_PATH to the absolute path to the built products directory.
1441         (execMacWebKitAppForDebugging): Ditto.
1442
1443 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
1444
1445         Build bmalloc on iOS too
1446         https://bugs.webkit.org/show_bug.cgi?id=131381
1447
1448         Reviewed by Andreas Kling.
1449
1450         * Scripts/build-webkit:
1451
1452 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
1453
1454         Unreviewed gardening: Prevent users from attempting
1455         to build with known invalid cURL.
1456
1457         * Scripts/webkitdirs.pm:
1458         (checkInstalledTools): Block build attempts with bad
1459         Cygwin tool set.
1460
1461 2014-04-07  Geoffrey Garen  <ggaren@apple.com>
1462
1463         Build bmalloc on Mac
1464         https://bugs.webkit.org/show_bug.cgi?id=131333
1465
1466         Reviewed by Mark Rowe.
1467
1468         * Scripts/build-webkit: Add the bmalloc target if we're on Mac.
1469         (Note: Just testing Mac is not good enough because in this
1470         script 'Mac' means 'Mac or iOS'.)
1471
1472 2014-03-30  Filip Pizlo  <fpizlo@apple.com>
1473
1474         Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running
1475         https://bugs.webkit.org/show_bug.cgi?id=130951
1476
1477         Reviewed by Geoffrey Garen.
1478
1479         * Scripts/run-javascriptcore-tests:
1480
1481 2014-04-06  Darin Adler  <darin@apple.com>
1482
1483         Rework CSS calc logic, fixing some reference count mistakes in Length
1484         https://bugs.webkit.org/show_bug.cgi?id=131280
1485
1486         Reviewed by Andreas Kling.
1487
1488         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added CalculationValue.cpp.
1489         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp: Added.
1490
1491 2014-04-04  Brian J. Burg  <burg@cs.washington.edu>
1492
1493         Enable WEB_REPLAY for PLATFORM(MAC)
1494         https://bugs.webkit.org/show_bug.cgi?id=130700
1495
1496         Reviewed by Timothy Hatcher.
1497
1498         * Scripts/webkitperl/FeatureList.pm: Set the default for WEB_REPLAY for OS X engineering builds.
1499
1500 2014-04-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1501
1502         [CMake] Include X11's include dirs in TestNetscapePlugin
1503         https://bugs.webkit.org/show_bug.cgi?id=131270
1504
1505         Reviewed by Martin Robinson.
1506
1507         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Include X11_INCLUDE_DIR since
1508         TestNetscapePlugin includes WebCore code that includes X headers.
1509
1510 2014-04-05  David Kilzer  <ddkilzer@apple.com>
1511
1512         REGRESSION (r166529): Fix build after renaming TileCache to LegacyTileCache
1513         <http://webkit.org/b/130986>
1514
1515         * Scripts/check-for-inappropriate-objc-class-names: Add 'Legacy'
1516         prefix to TileCache class names in exception list.
1517
1518 2014-04-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1519
1520         [GTK] kill-old-processes should kill dbus-daemon processes
1521         https://bugs.webkit.org/show_bug.cgi?id=127352
1522
1523         Reviewed by Martin Robinson.
1524
1525         * BuildSlaveSupport/kill-old-processes:
1526         (main):
1527
1528 2014-04-04  Andres Gomez  <agomez@igalia.com>
1529
1530         [Win] Update obsolete packages in cygwin
1531         https://bugs.webkit.org/show_bug.cgi?id=126264
1532
1533         Reviewed by Brent Fulgham.
1534
1535         Removed "apache" and "minires" as the first has been replaced by
1536         "lighttpd" and the second is now integrated into
1537         "cygwin". Replaced the transitional and now obsolete "gcc" package
1538         with "gcc-g++" and ensure that "python" stays at version "2.6.8"
1539         since the newer version available is "2.7.3" which breaks the
1540         build due to some funniness with environment variable handling.
1541
1542         * CygwinDownloader/cygwin-downloader.py:
1543         * CygwinDownloader/cygwin-downloader.zip:
1544
1545 2014-04-03  Joseph Pecoraro  <pecoraro@apple.com>
1546
1547         check-webkit-style: Improve warnings on Objective-C @property syntax
1548         https://bugs.webkit.org/show_bug.cgi?id=131200
1549
1550         Reviewed by Dan Bernstein.
1551
1552         * Scripts/webkitpy/style/checkers/cpp.py:
1553         (check_spacing):
1554         (CppChecker):
1555         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1556         (CppStyleTest.test_spacing_in_objective_c_properties):
1557
1558 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
1559
1560         Unreviewed. Moving my name to commiter section
1561
1562         * Scripts/webkitpy/common/config/contributors.json:
1563
1564 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
1565
1566         Unreviewed. Add myself as a committer.
1567
1568         * Scripts/webkitpy/common/config/contributors.json:
1569
1570 2014-04-03  Andrzej Badowski  <a.badowski@samsung.com>
1571
1572         [EFL][WK2] Replacing zoom functionality of MiniBrowser from scale_set to page_zoom_set.
1573         https://bugs.webkit.org/show_bug.cgi?id=130391
1574
1575         Reviewed by Gyuyoung Kim.
1576
1577         Change the implementation of the zoom functionality from ewk_view_scale_set
1578         to ewk_view_page_zoom_set.
1579
1580         * MiniBrowser/efl/main.c:
1581
1582 2014-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1583
1584         [webkitpy] perf profiler does not understand --call-graph argument
1585         https://bugs.webkit.org/show_bug.cgi?id=131132
1586
1587         Reviewed by Ryosuke Niwa.
1588
1589         New versions of perf profiler have changed the argument from --call-graph to -g.
1590
1591         * Scripts/webkitpy/common/system/profiler.py:
1592         (Perf.wrapper_arguments): Use -g instead of --call-graph.
1593         * Scripts/webkitpy/port/driver_unittest.py:
1594         (DriverTest.test_profiler_as_wrapper): Update test accordingly.
1595
1596 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1597
1598         Add EFL WK2 performance bot to build.webkit.org
1599         https://bugs.webkit.org/show_bug.cgi?id=131034
1600
1601         Fix after r166707, use "Perf" instead of "perf" for consistency.
1602
1603         Reviewed by Csaba Osztrogonác.
1604
1605         * BuildSlaveSupport/build.webkit.org-config/config.json:
1606
1607 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1608
1609         Add EFL WK2 performance bot to build.webkit.org
1610         https://bugs.webkit.org/show_bug.cgi?id=131034
1611
1612         Reviewed by Csaba Osztrogonác.
1613
1614         * BuildSlaveSupport/build.webkit.org-config/config.json:
1615
1616 2014-04-02  Ryuan Choi  <ryuan.choi@samsung.com>
1617
1618         [EFL][WK1] Use Evas_Touch_Point_State instead of Ewk_Touch_Point_Type
1619         https://bugs.webkit.org/show_bug.cgi?id=131151
1620
1621         Reviewed by Gyuyoung Kim.
1622
1623         * DumpRenderTree/efl/EventSender.cpp: Replace Ewk_Touch_Point_Type to Evas_Touch_Point_State.
1624         (TouchEventInfo::TouchEventInfo):
1625         (sendTouchEvent):
1626         (addTouchPointCallback):
1627         (updateTouchPointCallback):
1628         (cancelTouchPointCallback):
1629         (releaseTouchPointCallback):
1630
1631 2014-04-02  David Kilzer  <ddkilzer@apple.com>
1632
1633         filter-build-webkit: Ignore xcodebuild warnings when compiling with newer builds of clang
1634         <http://webkit.org/b/131045>
1635
1636         Reviewed by Daniel Bates.
1637
1638         * Scripts/filter-build-webkit:
1639         (shouldIgnoreLine): Ignore DVTAssertions related to new builds
1640         of clang, plus debug data for all DVTAssertions.
1641
1642 2014-04-01  Dean Jackson  <dino@apple.com>
1643
1644         Load Media Controls js/css from bundle
1645         https://bugs.webkit.org/show_bug.cgi?id=131086
1646
1647         Reviewed by Eric Carlson.
1648
1649         We're now putting CSS files into the bundle, so remove the test for them.
1650
1651         * Scripts/check-for-inappropriate-files-in-framework:
1652
1653 2014-04-02  Martin Hock  <mhock@apple.com>
1654
1655         Unify private browsing with sessions.
1656         https://bugs.webkit.org/show_bug.cgi?id=130099
1657
1658         Reviewed by Alexey Proskuryakov.
1659
1660         Add an API test for ephemeral sessions similar to PrivateBrowsingPushStateNoHistoryCallback.
1661         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1662         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
1663         (TestWebKitAPI::didNavigateWithNavigationData):
1664         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1665         (TestWebKitAPI::TEST):
1666
1667         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Also test to make sure private browsing can be disabled.
1668         (TestWebKitAPI::didNavigateWithoutNavigationData):
1669         (TestWebKitAPI::didNavigateWithNavigationData):
1670         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1671         (TestWebKitAPI::TEST):
1672
1673 2014-04-02  Martin Robinson  <mrobinson@igalia.com>
1674
1675         REGRESSION(r165704): [GTK] Inspector resources not correctly generated
1676         https://bugs.webkit.org/show_bug.cgi?id=130343
1677
1678         Reviewed by Gustavo Noronha Silva.
1679
1680         * gtk/generate-inspector-gresource-manifest.py: Instead of hard-coding the file list, accept a list
1681         of directories on the command line and look for all appropriate files in those directories for the
1682         GResource archive. Also make archive paths relative to those directories.
1683         (find_all_files_in_directory): This helper looks for all the appropriate files in a given directory.
1684         (find_all_files_in_directory.select_file): Whether or not to add the file to the archive.
1685
1686 2014-04-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1687
1688         [webkitpy] Avoid multiple "Preparing rollout for bug" log messages
1689         https://bugs.webkit.org/show_bug.cgi?id=131106
1690
1691         Reviewed by Csaba Osztrogonác.
1692
1693         * Scripts/webkitpy/tool/commands/download.py:
1694         (AbstractRolloutPrepCommand._prepare_state):
1695         * Scripts/webkitpy/tool/commands/download_unittest.py:
1696         (test_prepare_rollout):
1697         (test_create_rollout):
1698         (test_create_rollout_resolved):
1699         (test_rollout):
1700
1701 2014-04-02  Krzysztof Wolanski  <k.wolanski@samsung.com>
1702
1703         [EFL] Add option to use separate web process for new window in MiniBrowser
1704         https://bugs.webkit.org/show_bug.cgi?id=130190
1705
1706         Reviewed by Gyuyoung Kim.
1707
1708         New created window (CTRL + n) will be open in separated web process.
1709         This option is enabled by adding a flag (S/separate-process) with launching
1710         MiniBrowser.
1711
1712         * MiniBrowser/efl/main.c:
1713         (elm_main):
1714
1715 2014-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1716
1717         [GTK] Move NEWS file to a new location
1718         https://bugs.webkit.org/show_bug.cgi?id=130901
1719
1720         Reviewed by Brent Fulgham.
1721
1722         * gtk/manifest.txt: Update the NEWS file path.
1723
1724 2014-04-01  Anders Carlsson  <andersca@apple.com>
1725
1726         Fix build.
1727
1728         * MiniBrowser/mac/WK2BrowserWindowController.m:
1729         (-[WK2BrowserWindowController awakeFromNib]):
1730         (-[WK2BrowserWindowController dealloc]):
1731         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
1732
1733 2014-04-01  Brent Fulgham  <bfulgham@apple.com>
1734
1735         Unreviewed test gardening.
1736
1737         * Scripts/webkitpy/port/base_unittest.py:
1738         (PortTest.test_build_path): Handle the Debug case so we don't get webkitpy-test failures on our test bots.
1739
1740 2014-04-01  Zoltan Horvath  <zoltan@webkit.org>
1741
1742         [CSS Exclusions] Remove exclusions parsing support
1743         https://bugs.webkit.org/show_bug.cgi?id=131046
1744
1745         Reviewed by David Hyatt.
1746
1747         * Scripts/webkitperl/FeatureList.pm:
1748
1749 2014-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
1750
1751         [GTK] Remove last reference to GTK+ WK1 EWS
1752         https://bugs.webkit.org/show_bug.cgi?id=131058
1753
1754         Reviewed by Martin Robinson.
1755
1756         In r166427 WK1 GTK+ bots and EWS where removed, but this file was missing.
1757
1758         * QueueStatusServer/config/queues.py: Remove reference to GTK+ WK1 EWS.
1759
1760 2014-04-01  Lucas Forschler  <lforschler@apple.com>
1761
1762         Add a 32bit JSC builder/tester.
1763         https://bugs.webkit.org/show_bug.cgi?id=131054
1764         
1765         Reviewed by Michael Saboff.
1766
1767         * BuildSlaveSupport/build.webkit.org-config/config.json:
1768         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1769         (Compile32bitJSC):
1770         (Run32bitJSCTests):
1771         (Run32bitJSCTests.countFailures):
1772         (BuildAndTest32bitJSCFactory):
1773         (BuildAndTest32bitJSCFactory.__init__):
1774
1775 2014-04-01  Martin Robinson  <mrobinson@igalia.com>
1776
1777         [GTK] No longer build WebKit1 gtkdoc
1778         https://bugs.webkit.org/show_bug.cgi?id=130970
1779
1780         Reviewed by Anders Carlsson.
1781
1782         * gtk/common.py:
1783         (gtk_version_of_pkg_config_file): Deleted.
1784         * gtk/generate-gtkdoc:
1785         (get_gtkdoc_module_paths): We no longer need to worry about GTK+ 2, since it
1786         was only applicable for WebKit1.
1787         (get_generator_for_config): No longer look for the WebKit1 configuration file.
1788
1789 2014-04-01  Mario Sanchez Prada  <mario.prada@samsung.com>
1790
1791         [GTK] Running minibrowser with url crashes in debug build
1792         https://bugs.webkit.org/show_bug.cgi?id=130492
1793
1794         Reviewed by Martin Robinson.
1795
1796         Update "uri-scheme" test not to use invalid URIs in it, so we
1797         don't get a mistmatch when comparing the original URI stored in
1798         the test class with the one returned by the WebKitWebView.
1799
1800         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1801         (testWebContextURIScheme): Update the test.
1802
1803 2014-04-01  Mihai Tica  <mitica@adobe.com>
1804
1805         Unreviewed: Add myself as a commiter to the contributors list.
1806
1807         * Scripts/webkitpy/common/config/contributors.json:
1808
1809 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
1810
1811         [EFL][WK2] Extract the control of page background out of color_set
1812         https://bugs.webkit.org/show_bug.cgi?id=127539
1813
1814         Reviewed by Gyuyoung Kim.
1815
1816         Added an option(C) to change background color.
1817
1818         * MiniBrowser/efl/main.c:
1819         (window_create):
1820         (elm_main):
1821
1822 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
1823
1824         Unreviewed build fix on the EFL port with latest EFL libraries since r166149
1825
1826         * ImageDiff/PlatformEfl.cmake: Added ECORE_IMF_INCLUDE_DIRS to include dirs
1827
1828 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
1829
1830         Unreviewed test correction after r166530.
1831
1832         * DumpRenderTree/mac/DumpRenderTree.mm:
1833         (setDefaultsToConsistentValuesForTesting): No need to change preference for all tests. We set the proper
1834         fine-grained setting for swipe tests. This prevents existing tests from breaking.
1835
1836 2014-03-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1837
1838         Remove the trigger for webkit1 tests on the gtk-linux-64-release bot
1839         https://bugs.webkit.org/show_bug.cgi?id=130987
1840
1841         r166427 removed the WebKit1 GTK+ bots, so we don't longer need to
1842         trigger the webkit1 bot tests on the gtk-linux-64-release bot.
1843
1844         Reviewed by Martin Robinson.
1845
1846         * BuildSlaveSupport/build.webkit.org-config/config.json:
1847
1848 2014-03-31  Dean Jackson  <dino@apple.com>
1849
1850         Remove WEB_ANIMATIONS
1851         https://bugs.webkit.org/show_bug.cgi?id=130989
1852
1853         Reviewed by Simon Fraser.
1854
1855         Remove this feature flag until we plan to implement.
1856
1857         * Scripts/webkitperl/FeatureList.pm:
1858
1859 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
1860
1861         Reduced Latched Scroll Test Flakiness
1862         https://bugs.webkit.org/show_bug.cgi?id=130983
1863
1864         Reviewed by Darin Adler.
1865
1866         * DumpRenderTree/mac/DumpRenderTree.mm:
1867         (setDefaultsToConsistentValuesForTesting): Test user should have 'high resolution' scrolling.
1868         * DumpRenderTree/mac/EventSendingController.mm:
1869         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Generate mouse wheel events
1870         with high resolution flags turned on.
1871         * WebKitTestRunner/mac/EventSenderProxy.mm:
1872         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
1873
1874 2014-03-31  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1875
1876         run-webkit-tests should have a --no-timeout option
1877         https://bugs.webkit.org/show_bug.cgi?id=128286
1878
1879         Reviewed by Joseph Pecoraro.
1880
1881         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1882         (Worker._run_test): Renaming _run_test_with_timeout()
1883         (Worker._run_test_with_or_without_timeout): Renaming _run_test_with_timeout(), because tests can now run without timeout.
1884         (Worker._run_test_in_another_thread): Passing the --no-timeout option to the driver
1885         (Worker._run_test_in_this_thread):
1886         (Worker._run_test_with_timeout): Deleted.
1887         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1888         (parse_args): Added the --no-timeout option
1889
1890 2014-03-31  Samuel White  <samuel_white@apple.com>
1891
1892         AX: Need ability to get line range for text marker.
1893         https://bugs.webkit.org/show_bug.cgi?id=130906
1894
1895         Reviewed by Chris Fleizach.
1896
1897         Added a new function in DRT and TestRunner to test that AXLineTextMarkerRangeForTextMarker works as expected.
1898
1899         * DumpRenderTree/AccessibilityUIElement.cpp:
1900         (lineTextMarkerRangeForTextMarkerCallback):
1901         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1902         (AccessibilityUIElement::getJSClass):
1903         * DumpRenderTree/AccessibilityUIElement.h:
1904         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1905         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1906         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1907         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1908         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1909         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1910         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1911         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1912         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1913         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1914         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1915         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1916
1917 2014-03-31  Filip Pizlo  <fpizlo@apple.com>
1918
1919         More validation for FTL inline caches
1920         https://bugs.webkit.org/show_bug.cgi?id=130948
1921
1922         Reviewed by Geoffrey Garen.
1923
1924         * Scripts/run-jsc-stress-tests:
1925
1926 2014-03-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1927
1928         [GTK] Do not run WebKit1 unit tests by default
1929         https://bugs.webkit.org/show_bug.cgi?id=130968
1930
1931         Reviewed by Martin Robinson.
1932
1933         * Scripts/run-gtk-tests:
1934         (TestRunner):
1935
1936 2014-03-31  Martin Robinson  <mrobinson@igalia.com>
1937
1938         [GTK] Remove scripts code only applicable to autotools
1939         https://bugs.webkit.org/show_bug.cgi?id=130841
1940
1941         Reviewed by Anders Carlsson.
1942
1943         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1944         (_should_file_trigger_build): Update file list to reflect GTK+ CMake port.
1945         * Scripts/webkitpy/common/config/watchlist: Remove the GTK+ build watchlist.
1946         * Scripts/webkitpy/style/checker.py: The GNUmakefile doesn't exist any longer.
1947         * gtk/find-make-dist-errors: Removed.
1948         * gtk/generate-feature-defines-files: Removed.
1949         * gtk/manifest.txt: No longer need to consider autotools files.
1950
1951 2014-03-30  Andy Estes  <aestes@apple.com>
1952
1953         Fix two failing layout tests on Mountain Lion after r166466.
1954
1955         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1956         (-[DownloadDelegate _downloadDidStart:]):
1957
1958 2014-03-30  Andy Estes  <aestes@apple.com>
1959
1960         [Cocoa] Add an originatingWebView property to _WKDownload
1961         https://bugs.webkit.org/show_bug.cgi?id=130945
1962
1963         Reviewed by Anders Carlsson.
1964
1965         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1966         (-[DownloadDelegate _downloadDidStart:]):
1967         (-[OriginatingWebViewDownloadDelegate initWithWebView:]):
1968         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
1969         (TEST):
1970
1971 2014-03-28  Filip Pizlo  <fpizlo@apple.com>
1972
1973         Land the stackmap register liveness glue with the uses of the liveness disabled
1974         https://bugs.webkit.org/show_bug.cgi?id=130924
1975
1976         Reviewed by Oliver Hunt.
1977
1978         * Scripts/run-jsc-stress-tests:
1979
1980 2014-03-29  Alexey Proskuryakov  <ap@apple.com>
1981
1982         Update WebKit1.StringTruncator for Mountain Lion.
1983
1984         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Looks like one subtest was failing
1985         due to different font metrics on 10.8.
1986
1987 2014-03-28  Darin Adler  <darin@apple.com>
1988
1989         Fix recently-introduced off-by-one error in centerTruncateToBuffer
1990         https://bugs.webkit.org/show_bug.cgi?id=130889
1991
1992         Reviewed by Alexey Proskuryakov.
1993
1994         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringTruncator.mm.
1995         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Added. One test for each of the
1996         WebStringTruncator methods; should be good for a start. These are dependent on the
1997         metrics of Helvetica 12, but I am hoping that will be consistent across OS X machines.
1998
1999 2014-03-28  Martin Hock  <mhock@apple.com>
2000
2001         Unreviewed. Add myself as a committer.
2002
2003         * Scripts/webkitpy/common/config/contributors.json:
2004
2005 2014-03-28  Martin Robinson  <mrobinson@igalia.com>
2006
2007         Remove WebKit1 GTK+ bots
2008         https://bugs.webkit.org/show_bug.cgi?id=130904
2009
2010         Reviewed by Anders Carlsson.
2011
2012         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove references to GTK+ WebKit1 test bot and ensure
2013         all bots are testing WebKit2 only.
2014         * Scripts/webkitpy/common/config/ews.json: Remove references to GTK+ WK1 EWS.
2015         * Scripts/webkitpy/common/config/ports.py: Remove references to GTK+ WK1 bots.
2016         * Scripts/webkitpy/common/config/ports_unittest.py: Ditto.
2017         * Scripts/webkitpy/port/builders.py: Ditto.
2018         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
2019         * TestResultServer/static-dashboards/builders.jsonp: Ditto.
2020
2021 2014-03-28  Timothy Hatcher  <timothy@apple.com>
2022
2023         Remove Brian Burg's apple.com email address.
2024
2025         * Scripts/webkitpy/common/config/contributors.json:
2026
2027 2014-03-28  David Kilzer  <ddkilzer@apple.com>
2028
2029         bisect-builds should print Trac 'changeset' URL if only one build is detected
2030         <http://webkit.org/b/130903>
2031
2032         Reviewed by Dan Bernstein.
2033
2034         * Scripts/bisect-builds:
2035         (printTracLink): Print a direct link to the Trac 'changeset'
2036         URL if there is only one revision in the range.
2037
2038 2014-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2039
2040         [EFL] Bump glib version from 2.36 to 2.38 
2041         https://bugs.webkit.org/show_bug.cgi?id=130886
2042
2043         Reviewed by Csaba Osztrogonác.
2044
2045         There is a build break on EFL port when using glib 2.36 ver. To fix it,
2046         we need to bump glib version up to 2.38 as gtk port.
2047
2048         * efl/jhbuild.modules:
2049
2050 2014-03-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2051
2052         <https://webkit.org/b/42704> WebKitTestRunner needs to print history delegate information
2053
2054         Provide an implementation of WKContextHistoryClient that logs when called for tests in
2055         the globalhistory directory.
2056
2057         Reviewed by Sam Weinig.
2058
2059         * WebKitTestRunner/TestController.cpp:
2060         (WTR::TestController::TestController):
2061         (WTR::TestController::initialize): Set the history client.
2062         (WTR::TestController::resetStateToConsistentValues): Disable logging of history client callbacks.
2063         (WTR::TestController::didNavigateWithNavigationData): Log information about the navigation. Some portions
2064         of the output are hard-coded to match WebKit1's results for now since they're fixed in our existing tests
2065         and we don't yet have API to access the data in question.
2066         (WTR::TestController::didPerformClientRedirect):
2067         (WTR::TestController::didPerformServerRedirect):
2068         (WTR::TestController::didUpdateHistoryTitle):
2069         * WebKitTestRunner/TestController.h:
2070         (WTR::TestController::setShouldLogHistoryClientCallbacks):
2071         * WebKitTestRunner/TestInvocation.cpp:
2072         (WTR::shouldLogHistoryClientCallbacks): Log history client callbacks for tests in a globalhistory directory.
2073         (WTR::TestInvocation::invoke):
2074
2075 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
2076
2077         Revert http://trac.webkit.org/changeset/166386 because it broke builds.
2078
2079         * Scripts/build-webkit:
2080         * Scripts/copy-webkitlibraries-to-product-directory:
2081
2082 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
2083
2084         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
2085         https://bugs.webkit.org/show_bug.cgi?id=130867
2086         <rdar://problem/16432456> 
2087
2088         Reviewed by Mark Hahnenberg.
2089
2090         * Scripts/build-webkit:
2091         * Scripts/copy-webkitlibraries-to-product-directory:
2092
2093 2014-03-26  Andy Estes  <aestes@apple.com>
2094
2095         [Cocoa] Expose DownloadClient::didFail() and DownloadClient::didCancel()
2096         https://bugs.webkit.org/show_bug.cgi?id=130805
2097
2098         Reviewed by Dan Bernstein.
2099
2100         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2101         (-[DownloadDelegate _download:didReceiveResponse:]):
2102         (-[DownloadDelegate _downloadDidFinish:]):
2103         (runTest):
2104         (TEST):
2105         (-[FailingDownloadDelegate _downloadDidFinish:]):
2106         (-[FailingDownloadDelegate _download:didFailWithError:]):
2107         (-[FailingDownloadDelegate _downloadDidCancel:]):
2108         (-[CancelledDownloadDelegate _downloadDidStart:]):
2109         (-[CancelledDownloadDelegate _downloadDidFinish:]):
2110         (-[CancelledDownloadDelegate _download:didFailWithError:]):
2111         (-[CancelledDownloadDelegate _downloadDidCancel:]):
2112         (-[DownloadDelegate initWithSourceURL:]): Deleted.
2113         (-[DownloadDelegate sourceURL]): Deleted.
2114         (runTestWithNavigationDelegate): Deleted.
2115
2116 2014-03-26  Anders Carlsson  <andersca@apple.com>
2117
2118         Change MiniBrowser to hold on to window controllers instead of windows
2119         https://bugs.webkit.org/show_bug.cgi?id=130797
2120
2121         Reviewed by Oliver Hunt.
2122
2123         * MiniBrowser/mac/AppDelegate.h:
2124         * MiniBrowser/mac/AppDelegate.m:
2125         (-[BrowserAppDelegate init]):
2126         (-[BrowserAppDelegate newWindow:]):
2127         (-[BrowserAppDelegate browserWindowWillClose:]):
2128         (-[BrowserAppDelegate applicationWillTerminate:]):
2129         (-[BrowserAppDelegate frontmostBrowserWindowController]):
2130
2131 2014-03-26  Commit Queue  <commit-queue@webkit.org>
2132
2133         Unreviewed, rolling out r166264.
2134         https://bugs.webkit.org/show_bug.cgi?id=130785
2135
2136         Broke some window.opener tests for WK2 Mavericks (Requested by
2137         brrian__ on #webkit).
2138
2139         Reverted changeset:
2140
2141         "Web Replay: resource unique identifiers should be unique-per-
2142         frame, not globally"
2143         https://bugs.webkit.org/show_bug.cgi?id=130632
2144         http://trac.webkit.org/changeset/166264
2145
2146 2014-03-26  Zoltan Horvath  <zoltan@webkit.org>
2147
2148         [CSS Shapes] Remove shape-inside support
2149         https://bugs.webkit.org/show_bug.cgi?id=130698
2150
2151         Reviewed by David Hyatt.
2152
2153         * Scripts/webkitperl/FeatureList.pm:
2154
2155 2014-02-27  Gurpreet Kaur  <k.gurpreet@samsung.com>
2156
2157         Unreviewed. Add myself as a committer.
2158
2159         * Scripts/webkitpy/common/config/contributors.json:
2160
2161 2014-03-26  Tomas Popela  <tpopela@redhat.com>
2162
2163         run-launcher is Perl script so use elsif and not elif
2164         https://bugs.webkit.org/show_bug.cgi?id=130771
2165
2166         Reviewed by Carlos Garcia Campos.
2167
2168         * Scripts/run-launcher:
2169
2170 2014-03-26  Krzysztof Czech  <k.czech@samsung.com>
2171
2172         [ATK] Utilize new AtkValue interface coming in ATK 2.11.92
2173         https://bugs.webkit.org/show_bug.cgi?id=130575
2174
2175         Reviewed by Mario Sanchez Prada.
2176
2177         Change ATK version to 2.11.92. Adjust current implementation.
2178
2179         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2180         (AccessibilityUIElement::intValue):
2181         (AccessibilityUIElement::minValue):
2182         (AccessibilityUIElement::maxValue):
2183         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2184         (WTR::AccessibilityUIElement::intValue):
2185         (WTR::AccessibilityUIElement::minValue):
2186         (WTR::AccessibilityUIElement::maxValue):
2187         * efl/jhbuild.modules:
2188         * gtk/jhbuild.modules:
2189
2190 2014-03-12  Philippe Normand  <pnormand@igalia.com>
2191
2192         [GTK] The gnumake package is no longer needed in jhbuild
2193         https://bugs.webkit.org/show_bug.cgi?id=130121
2194
2195         Reviewed by Martin Robinson.
2196
2197         For GTK build-webkit now relies on cmake and ninja/gnumake. Even
2198         for a debug build cmake/system-gnumake worked just fine for me.
2199
2200         * gtk/jhbuild.modules: Removed gnumake.
2201         * gtk/patches/make-3.82-arg-list-length.patch: Removed.
2202         * gtk/patches/make-3.82-parallel-build.patch: Removed.
2203
2204 2014-03-25  Andy Estes  <aestes@apple.com>
2205
2206         Fix a failing API test on Mountain Lion and remove temporary debug logging.
2207
2208         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2209         (-[DownloadDelegate _download:didReceiveData:]):
2210         (-[DownloadDelegate _downloadDidFinish:]):
2211
2212 2014-03-25  Brian Burg  <bburg@apple.com>
2213
2214         Web Replay: resource unique identifiers should be unique-per-frame, not globally
2215         https://bugs.webkit.org/show_bug.cgi?id=130623
2216
2217         Reviewed by Timothy Hatcher.
2218
2219         The resource loader callback dumping routines assumed that resource identifiers
2220         were globally unique. Its map of resource identifiers to URLs must also track the
2221         frame associated with the resource.
2222
2223         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2224         (WTR::dumpResourceURL): Additionally take a WKBundleFrameRef argument, and use the
2225         opaque pointer as part of the key for assignedUrlsCache. The frame pointer is
2226         stable as long as the frame is valid.
2227         (WTR::InjectedBundlePage::didInitiateLoadForResource):
2228         (WTR::InjectedBundlePage::willSendRequestForFrame):
2229         (WTR::InjectedBundlePage::didReceiveResponseForResource):
2230         (WTR::InjectedBundlePage::didFinishLoadForResource):
2231         (WTR::InjectedBundlePage::didFailLoadForResource):
2232
2233 2014-03-25  Andy Estes  <aestes@apple.com>
2234
2235         Fix one API test expectation failure on Mountain Lion, and add additional logging to help diagnose another.
2236
2237         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2238         (-[DownloadDelegate _download:didReceiveResponse:]):
2239         (-[DownloadDelegate _download:didReceiveData:]):
2240
2241 2014-03-25  Andy Estes  <aestes@apple.com>
2242
2243         Add some debug logging to an API test that's failing on Mountain Lion.
2244
2245         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2246         (-[DownloadDelegate _download:didReceiveResponse:]):
2247         (-[DownloadDelegate _downloadDidFinish:]):
2248
2249 2014-03-25  Anders Carlsson  <andersca@apple.com>
2250
2251         Add goBack: and goForward: IBActions and move stopLoading: to a new WKIBActions category on WKWebView
2252         https://bugs.webkit.org/show_bug.cgi?id=130732
2253
2254         Reviewed by Tim Horton.
2255
2256         * MiniBrowser/mac/WK2BrowserWindowController.m:
2257         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
2258
2259 2014-03-25  Martin Robinson  <mrobinson@igalia.com>
2260
2261         [GTK] Remove the autotools build
2262         https://bugs.webkit.org/show_bug.cgi?id=130717
2263
2264         Reviewed by Anders Carlsson.
2265
2266         * DumpRenderTree/config.h: Remove references to the autotools configure file.
2267         * GNUmakefile.am: Removed.
2268         * GtkLauncher/GNUmakefile.am: Removed.
2269         * GtkLauncher/main.c: Remove references to the autotools configure file.
2270         * MiniBrowser/gtk/BrowserDownloadsBar.c: Ditto.
2271         * MiniBrowser/gtk/BrowserSearchBar.c: Ditto.
2272         * MiniBrowser/gtk/BrowserWindow.c: Ditto.
2273         * MiniBrowser/gtk/GNUmakefile.am: Removed.
2274         * MiniBrowser/gtk/main.c: Remove references to the autotools configure file.
2275         * Scripts/build-webkit: No longer handle autotools.
2276         * Scripts/run-gtk-tests: Ditto.
2277         (TestRunner._setup_testing_environment):
2278         * Scripts/run-launcher: Ditto.
2279         * Scripts/webkitdirs.pm: Ditto.
2280         * Scripts/webkitpy/common/config/contributionareas.py: Remove autotools as a contribution area.
2281         * Scripts/webkitpy/common/config/contributors.json: Ditto.
2282         * Scripts/webkitpy/port/gtk.py: No longer handle autotools.
2283         * Scripts/webkitpy/style/checker.py:
2284         * TestWebKitAPI/GNUmakefile.am: Removed.
2285         * TestWebKitAPI/config.h: Remove references to the autotools configure file.
2286         * WebKitTestRunner/GNUmakefile.am: Removed.
2287         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Ditto.
2288         * gtk/GNUmakefile.am: Removed.
2289         * gtk/common.py: Remove checks for the autotools build.
2290         * gtk/symbols.filter: Renamed from Source/autotools/symbols.filter.
2291
2292 2014-03-25  László Langó  <llango.u-szeged@partner.samsung.com>
2293
2294         prepare-ChangeLog throws false positive warnings for modified files.
2295         https://bugs.webkit.org/show_bug.cgi?id=130687
2296
2297         Reviewed by Darin Adler.
2298
2299         * Scripts/prepare-ChangeLog:
2300         (originalFile): Ignore git commit paremeter.
2301         We don't need this to get the unmodified file.
2302         (extractLineRangeBeforeChange):
2303         Simplify the if statement. Follow-up after r166189.
2304
2305 2014-03-25  Gabor Rapcsanyi  <rgabor@webkit.org>
2306
2307         [EFL] Add ARM64 build support
2308         https://bugs.webkit.org/show_bug.cgi?id=130506
2309
2310         Rubber stamped by Gyuyoung Kim.
2311
2312         * Scripts/webkitdirs.pm:
2313         (isARM): Detect aarch64 as ARM.
2314
2315 2014-03-25  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2316
2317         [webkitpy] Improve _parse_bug_description to recognize more descriptions
2318         https://bugs.webkit.org/show_bug.cgi?id=130137
2319
2320         Reviewed by Csaba Osztrogonác.
2321
2322         * Scripts/webkitpy/common/checkout/changelog.py:
2323         (ChangeLogEntry._parse_bug_description):
2324         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2325         (test_parse_log_entries_from_changelog):
2326         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2327         (CheckoutTest.test_commit_info_for_revision):
2328
2329 2014-03-24  Andy Estes  <aestes@apple.com>
2330
2331         Fix the iOS build of TestWebKitAPI.
2332
2333         * TestWebKitAPI/Configurations/Base.xcconfig:
2334         * TestWebKitAPI/PlatformUtilities.h:
2335
2336 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
2337
2338         Fix prepare-ChangeLog after r166156.
2339         https://bugs.webkit.org/show_bug.cgi?id=130674
2340
2341         Reviewed by Darin Adler.
2342
2343         * Scripts/prepare-ChangeLog:
2344         (generateFunctionLists):
2345         (extractLineRangeBeforeChange):
2346
2347 2014-03-24  Andy Estes  <aestes@apple.com>
2348
2349         [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
2350         https://bugs.webkit.org/show_bug.cgi?id=129322
2351
2352         Reviewed by Anders Carlsson.
2353
2354         Add an API test suite for _WKDownload.
2355
2356         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2357         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Added.
2358         (-[DownloadDelegate initWithSourceURL:]):
2359         (-[DownloadDelegate sourceURL]):
2360         (-[DownloadDelegate _downloadDidStart:]):
2361         (-[DownloadDelegate _download:didReceiveResponse:]):
2362         (-[DownloadDelegate _download:didReceiveData:]):
2363         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
2364         (-[DownloadDelegate _downloadDidFinish:]):
2365         (TEST):
2366         (runTestWithNavigationDelegate):
2367         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2368         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2369
2370 2014-03-24  Joseph Pecoraro  <pecoraro@apple.com>
2371
2372         filter-build-webkit: reduce unfiltered output
2373         https://bugs.webkit.org/show_bug.cgi?id=130485
2374
2375         Reviewed by Brent Fulgham.
2376
2377         * Scripts/filter-build-webkit:
2378         (shouldIgnoreLine):
2379
2380 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
2381
2382         prepare-ChangeLog should list functions that have been removed too.
2383         https://bugs.webkit.org/show_bug.cgi?id=130508
2384
2385         Reviewed by Darin Adler.
2386
2387         The prepare-ChangeLog does not list the deleted functions in the Changelog.
2388         We have to read the functions and the line ranges of them from the source
2389         before the change, then search for overlaps between them and the changed
2390         line ranges from diff.
2391
2392         * Scripts/prepare-ChangeLog:
2393         (originalFile): Get original source command.
2394         (generateFunctionLists): Collect deleted functions too.
2395         (generateFunctionListsByRanges): Duplicated code is moved to a separate subroutine.
2396         (extractLineRangeBeforeChange): Extract line ranges from the original source to get
2397         deleted functions ranges too.
2398         (extractLineRange): Renamed to extractLineRangeAfterChange.
2399
2400 2014-03-23  Hyowon Kim  <hw1008.kim@samsung.com>
2401
2402         Move all EFL typedefs into EflTypedefs.h.
2403         https://bugs.webkit.org/show_bug.cgi?id=130511
2404
2405         Reviewed by Gyuyoung Kim.
2406
2407         * TestWebKitAPI/PlatformWebView.h: Remove EFL typedefs.
2408         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
2409         * WebKitTestRunner/PlatformWebView.h: Ditto.
2410
2411 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
2412
2413         Don't flush compositing layers within FrameView::willPaintContents()
2414         https://bugs.webkit.org/show_bug.cgi?id=130627
2415         <rdar://problem/16368869>
2416
2417         Reviewed by Sam Weinig.
2418         
2419         Fix DRT to correctly render tests with layers now that FrameView::paintContents
2420         does not flush.
2421         
2422         Move the -[WebView displayIfNeeded] from -[FrameLoadDelegate webView:didFinishLoadForFrame:]
2423         into an explicit function called before dumping. 
2424         
2425         Then explicitly call _flushCompositingChanges to ensure that GraphicsLayer changes
2426         are flushed to CA. They will be pushed to the window by snapshotting.
2427
2428         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2429         Fix weird path to IOKit.framework.
2430         * DumpRenderTree/mac/DumpRenderTree.mm:
2431         (updateDisplay):
2432         (dump):
2433         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2434         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): Fix parameter name.
2435         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Remove display call.
2436
2437 2014-03-21  David Kilzer  <ddkilzer@apple.com>
2438
2439         fix-blink-patch: tool to fix up renamed directory paths in Blink
2440         <http://webkit.org/b/130609>
2441
2442         Reviewed by Ryosuke Niwa.
2443
2444         Usage: cat blink.patch | fix-blink-patch | svn-apply
2445
2446         * Scripts/fix-blink-patch: Added.
2447
2448 2014-03-21  Darin Adler  <darin@apple.com>
2449
2450         Remove use of deprecatedCharacters in WebKit API tests
2451         https://bugs.webkit.org/show_bug.cgi?id=130602
2452
2453         Reviewed by Antti Koivisto.
2454
2455         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2456         (TestWebKitAPI::expectBuilderContent): Use characters8/16 instead of deprecatedCharacters.
2457         (TestWebKitAPI::expectEmpty): Use characters8.
2458         (TestWebKitAPI::TEST): Use characters8 instead of deprecatedCharacters in most cases.
2459
2460         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2461         Removed the test that is entirely about 16-bit conversion since that's basically a test of
2462         the deprecatedCharacters function itself, which we are about to delete.
2463
2464 2014-03-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2465
2466         [webkitpy] Fix has_valid_reviewer()
2467         https://bugs.webkit.org/show_bug.cgi?id=130589
2468
2469         Reviewed by Csaba Osztrogonác.
2470
2471         * Scripts/webkitpy/common/checkout/changelog.py:
2472         (ChangeLogEntry.has_valid_reviewer):
2473         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2474         (test_has_valid_reviewer):
2475         * Scripts/webkitpy/common/config/committers.py:
2476         (CommitterList._reviewer_only):
2477         (CommitterList.committer_by_name):
2478         (CommitterList.reviewer_by_email):
2479         (CommitterList):
2480         (CommitterList.reviewer_by_name):
2481
2482 2014-03-21  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
2483
2484         Add cache support for jhbuild
2485         https://bugs.webkit.org/show_bug.cgi?id=130588
2486
2487         Reviewed by Csaba Osztrogonác.
2488
2489         * jhbuild/jhbuildrc_common.py:
2490         (init): Jhbuild can now save the dependencies locally, if the JHBUILD_MIRROR environment variable is set.
2491
2492 2014-03-21  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2493
2494         [CMake] Add support for MAX_CPU_LOAD translated to -l in ninja and make
2495         https://bugs.webkit.org/show_bug.cgi?id=130504
2496
2497         Reviewed by Martin Robinson.
2498
2499         * Scripts/build-webkit: Add the maxCPULoad() to the makeArgs in
2500         CMake if not specified.
2501         * Scripts/webkitdirs.pm:
2502         (determineMaxCPULoad): Read MAX_CPU_LOAD as maxCPULoad.
2503         (maxCPULoad): determineMaxCPULoad and return maxCPULoad.
2504
2505 2014-03-21  Andreas Kling  <akling@apple.com>
2506
2507         RetainPtr API test should use CFArray instead of CFString for testing.
2508         <rdar://problem/16384899>
2509
2510         Unreviewed bot fix.
2511
2512         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
2513         (TestWebKitAPI::TEST):
2514         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
2515         (TestWebKitAPI::TEST):
2516
2517 2014-03-20  Hyowon Kim  <hw1008.kim@samsung.com>
2518
2519         Move to using std::unique_ptr for EFL objects.
2520         https://bugs.webkit.org/show_bug.cgi?id=129853
2521
2522         Reviewed by Gyuyoung Kim.
2523
2524         EflUniquePtr is a template alias of std::unique_ptr
2525         with a custom deleter for each Efl Objects, which is motivated by GUniquePtr.
2526         This patch replaces uses of OwnPtr and PassOwnPtr for Efl objects with EflUniquePtr.
2527
2528         * DumpRenderTree/efl/DumpRenderTree.cpp:
2529         (main):
2530         * ImageDiff/efl/ImageDiff.cpp:
2531         (initEfl):
2532         (main):
2533
2534 2014-03-20  Ryuan Choi  <ryuan.choi@samsung.com>
2535
2536         Unreviewed buildfix after r165983 for non Cocoa platforms
2537
2538         Renamed WKPreferencesPrivate.h to WKPreferencesRefPrivate.h
2539
2540         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
2541         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2542         * WebKitTestRunner/TestController.cpp:
2543
2544 2014-03-20  Zan Dobersek  <zdobersek@igalia.com>
2545
2546         [GTK][CMake] Add support for building with Clang
2547         https://bugs.webkit.org/show_bug.cgi?id=130260
2548
2549         Reviewed by Martin Robinson.
2550
2551         * TestWebKitAPI/CMakeLists.txt: When building with Clang TestWebKitAPI should be
2552         built with GTEST_HAS_TR1_TUPLE defined to 0 to avoid build failures occuring in the
2553         included GTest framework headers.
2554         * gtk/generate-gtkdoc:
2555         (prepare_environment_for_gtkdoc_generation): Don't modify the CFLAGS env anymore
2556         in case of using Clang since that is now set by the CMake rule.
2557
2558 2014-03-19  Simon Fraser  <simon.fraser@apple.com>
2559
2560         Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser
2561         https://bugs.webkit.org/show_bug.cgi?id=130476
2562
2563         Reviewed by Anders Carlsson.
2564         
2565         Hook up page/text zoom in MiniBrowser, make reload work, remove some logging.
2566
2567         * MiniBrowser/mac/WK1BrowserWindowController.m:
2568         (-[WK1BrowserWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2569         Remove log.
2570         * MiniBrowser/mac/WK2BrowserWindowController.m:
2571         (-[WK2BrowserWindowController awakeFromNib]):
2572         (-[WK2BrowserWindowController validateMenuItem:]):
2573         (-[WK2BrowserWindowController reload:]):
2574         Hook up reload.
2575         (-[WK2BrowserWindowController toggleZoomMode:]):
2576         (-[WK2BrowserWindowController resetZoom:]):
2577         (-[WK2BrowserWindowController canResetZoom]):
2578         (-[WK2BrowserWindowController currentZoomFactor]):
2579         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
2580         (-[WK2BrowserWindowController canZoomIn]):
2581         (-[WK2BrowserWindowController canZoomOut]):
2582
2583 2014-03-19  Alexey Proskuryakov  <ap@apple.com>
2584
2585         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
2586         https://bugs.webkit.org/show_bug.cgi?id=130463
2587
2588         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Disable the test.
2589
2590 2014-03-18  Samuel White  <samuel_white@apple.com>
2591
2592         AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
2593         https://bugs.webkit.org/show_bug.cgi?id=130250
2594
2595         Reviewed by Chris Fleizach.
2596
2597         Added ability to toggle enhanced accessibility on and off to support tests that require it.
2598
2599         * DumpRenderTree/AccessibilityController.cpp:
2600         (enableEnhancedAccessibilityCallback):
2601         (getEnhancedAccessibilityEnabledCallback):
2602         (AccessibilityController::getJSClass):
2603         * DumpRenderTree/AccessibilityController.h:
2604         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
2605         (AccessibilityController::enableEnhancedAccessibility):
2606         (AccessibilityController::enhancedAccessibilityEnabled):
2607         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2608         (AccessibilityController::enableEnhancedAccessibility):
2609         (AccessibilityController::enhancedAccessibilityEnabled):
2610         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2611         (AccessibilityController::enableEnhancedAccessibility):
2612         (AccessibilityController::enhancedAccessibilityEnabled):
2613         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2614         (AccessibilityController::enableEnhancedAccessibility):
2615         (AccessibilityController::enhancedAccessibilityEnabled):
2616         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2617         (WTR::AccessibilityController::enableEnhancedAccessibility):
2618         (WTR::AccessibilityController::enhancedAccessibilityEnabled):
2619         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2620         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2621
2622 2014-03-18  Filip Pizlo  <fpizlo@apple.com>
2623
2624         Unreviewed, add some contributors, and fix Nadav's entry (he's not really a reviewer
2625         yet).
2626
2627         * Scripts/webkitpy/common/config/contributors.json:
2628
2629 2014-03-18  Joseph Pecoraro  <pecoraro@apple.com>
2630
2631         Web Inspector: Remove stale ReportMemoryUsagePlugin
2632         https://bugs.webkit.org/show_bug.cgi?id=130405
2633
2634         Reviewed by Andreas Kling.
2635
2636         This clang plugin looks like it was used for the old Inspector memory
2637         instrumentation that was removed. So the tool can be removed.
2638
2639         * clang/ReportMemoryUsagePlugin/CMakeLists.txt: Removed.
2640         * clang/ReportMemoryUsagePlugin/Makefile: Removed.
2641         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Removed.
2642         * clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Removed.
2643
2644 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2645
2646         webkit-patch land shouldn't add a reviewer for unreviewed build fixes
2647         https://bugs.webkit.org/show_bug.cgi?id=130220
2648
2649         Reviewed by Csaba Osztrogonác.
2650
2651         * Scripts/webkitpy/common/checkout/changelog.py:
2652         (ChangeLog.set_reviewer):
2653         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2654         (test_set_reviewer):
2655
2656 2014-03-17  Filip Pizlo  <fpizlo@apple.com>
2657
2658         More FTL enabling.
2659
2660         Rubber stamped by Dan Bernstein.
2661
2662         * Tools/Scripts/build-webkit:
2663
2664 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2665
2666         Renable pagination mode in WK2 MiniBrowser
2667         https://bugs.webkit.org/show_bug.cgi?id=130374
2668
2669         Reviewed by Anders Carlsson.
2670         
2671         Put the implementation of togglePaginationMode: back, and correctly
2672         enable the menu item.
2673
2674         * MiniBrowser/mac/WK2BrowserWindowController.m:
2675         (-[WK2BrowserWindowController validateMenuItem:]):
2676         (-[WK2BrowserWindowController isPaginated]):
2677         (-[WK2BrowserWindowController togglePaginationMode:]):
2678
2679 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2680
2681         Add --reset option to Tools/Scripts/set-webkit-configuration script
2682         https://bugs.webkit.org/show_bug.cgi?id=130401
2683
2684         Reviewed by Csaba Osztrogonác.
2685
2686         * Scripts/set-webkit-configuration:
2687
2688 2014-03-18  Alberto Garcia  <berto@igalia.com>
2689
2690         [GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
2691         https://bugs.webkit.org/show_bug.cgi?id=130388
2692
2693         Reviewed by Sergio Villar Senin.
2694
2695         * Scripts/webkitdirs.pm:
2696         (shouldRemoveCMakeCache): make sure that the build directory
2697         exists before attempting to create a file in it.
2698
2699 2014-03-18  Robert Plociennik  <r.plociennik@samsung.com>
2700
2701         [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
2702         https://bugs.webkit.org/show_bug.cgi?id=130336
2703
2704         Reviewed by Gyuyoung Kim.
2705
2706         Compilation with gcc 4.8.x results in 'invalid suffix on literal; C++11
2707         requires a space between literal and string macro [-Wliteral-suffix]'
2708         warning treated as error.
2709
2710         This patch applies a solution from r162448 to the EFL port.
2711
2712         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
2713         * efl/jhbuild.modules: Added appropriate patch section.
2714
2715 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
2716
2717         webkitpy test rebaseline.
2718
2719         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2720         (MainTest.test_default_args):
2721
2722 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
2723
2724         --profile should imply --test-runner-count=1 in run-perf-tests
2725         https://bugs.webkit.org/show_bug.cgi?id=130375
2726
2727         Reviewed by Benjamin Poulain.
2728
2729         Use the test runner count of 1 when --profile is specified but not --test-runner-count.
2730
2731         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2732         (PerfTestsRunner._parse_args): Use -1 as the default value.
2733         (PerfTestsRunner._collect_tests): If --test-runner-count is set (i.e. it's a positive value),
2734         then use that value. Otherwise, if it's never set and --profile is present, test-runner-count
2735         should be 1.
2736
2737 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2738
2739         Address some style nits.
2740
2741         * MiniBrowser/mac/WK2BrowserWindowController.m:
2742
2743 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2744
2745         Add transparent window support back into MiniBrowser
2746         https://bugs.webkit.org/show_bug.cgi?id=130363
2747
2748         Reviewed by Anders Carlsson.
2749         
2750         Re-enable transparent window support for WK2.
2751
2752         * MiniBrowser/mac/WK2BrowserWindowController.m:
2753         (-[WK2BrowserWindowController validateMenuItem:]):
2754         (-[WK2BrowserWindowController toggleTransparentWindow:]):
2755
2756 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2757
2758         Fix the 32-bit build; make the open panel make a WK1 window.
2759
2760         * MiniBrowser/mac/AppDelegate.m:
2761         (-[BrowserAppDelegate openDocument:]):
2762
2763 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2764
2765         Convert MiniBrowser to use WKWebView API
2766         https://bugs.webkit.org/show_bug.cgi?id=130061
2767
2768         Reviewed by Anders Carlsson.
2769         
2770         Convert the MiniBrowser WK2 window to use WebKit2 API as much
2771         as possible.
2772         
2773         Some functionality was removed temporarily:
2774             - text zoom, page zoom
2775             - reload
2776             - pagination mode
2777             - transparent window
2778             - dumping source
2779             - window.open support
2780             - beforeUnload panel
2781             - find in page
2782
2783         * MiniBrowser/mac/AppDelegate.h:
2784         * MiniBrowser/mac/AppDelegate.m:
2785         (-[BrowserAppDelegate init]):
2786         (-[BrowserAppDelegate newWindow:]):
2787         (-[BrowserAppDelegate applicationWillTerminate:]):
2788         (-[BrowserAppDelegate openDocument:]):
2789         * MiniBrowser/mac/WK2BrowserWindowController.h:
2790         * MiniBrowser/mac/WK2BrowserWindowController.m:
2791         (-[WK2BrowserWindowController awakeFromNib]):
2792         (-[WK2BrowserWindowController dealloc]):
2793         (-[WK2BrowserWindowController fetch:]):
2794         (-[WK2BrowserWindowController validateMenuItem:]):
2795         (-[WK2BrowserWindowController reload:]):
2796         (-[WK2BrowserWindowController goBack:]):
2797         (-[WK2BrowserWindowController goForward:]):
2798         (-[WK2BrowserWindowController toggleZoomMode:]):
2799         (-[WK2BrowserWindowController resetZoom:]):
2800         (-[WK2BrowserWindowController canResetZoom]):
2801         (-[WK2BrowserWindowController dumpSourceToConsole:]):
2802         (-[WK2BrowserWindowController togglePaginationMode:]):
2803         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
2804         (-[WK2BrowserWindowController windowShouldClose:]):
2805         (-[WK2BrowserWindowController applicationTerminating]):
2806         (-[WK2BrowserWindowController currentZoomFactor]):
2807         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
2808         (-[WK2BrowserWindowController toggleTransparentWindow:]):
2809         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
2810         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2811         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2812         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
2813         (-[WK2BrowserWindowController find:]):
2814         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
2815         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
2816         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
2817         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
2818         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
2819         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
2820         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
2821         * WebKitTestRunner/PlatformWebView.h:
2822         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2823         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2824
2825 2014-03-17  Zan Dobersek  <zdobersek@igalia.com>
2826
2827         Use RunLoop objects through references instead of pointers
2828         https://bugs.webkit.org/show_bug.cgi?id=130313
2829
2830         Reviewed by Andreas Kling.
2831
2832         Adjust the code accordingly now that RunLoop::current() and RunLoop::main()
2833         return RunLoop reference instead of a pointer.
2834
2835         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
2836         (loadedCallback):
2837         (clickedCallback):
2838
2839 2014-03-17  Tim Horton  <timothy_horton@apple.com>
2840
2841         sort-export-file --help doesn't work (missing 'use')
2842         https://bugs.webkit.org/show_bug.cgi?id=130338
2843
2844         Reviewed by Anders Carlsson.
2845
2846         * Scripts/sort-export-file:
2847         Add a missing 'use', and fix a typo in an error message.
2848
2849 2014-03-17  Martin Robinson  <mrobinson@igalia.com>
2850
2851         [GTK][CMake] Ensure that HAVE_GTK_UNIX_PRINTING is defined when appropriate
2852         https://bugs.webkit.org/show_bug.cgi?id=130155
2853
2854         Reviewed by Philippe Normand.
2855
2856         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add GTK_UNIX_PRINT flags to the build.
2857
2858 2014-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2859
2860         [GTK] MiniBrowser fails to load injected bundle lib
2861         https://bugs.webkit.org/show_bug.cgi?id=130332
2862
2863         Reviewed by Anders Carlsson.
2864
2865         This is because WEBKIT_INJECTED_BUNDLE_PATH env var is set too late.
2866
2867         * MiniBrowser/gtk/main.c:
2868         (main): Make sure WEBKIT_INJECTED_BUNDLE_PATH is set before a web
2869         process is spawn.
2870
2871 2014-03-16  Kim Byung Jun  <bj1987.kim@samsung.com>
2872
2873         [EFL] Enable TOUCH_SLIDER macro
2874         https://bugs.webkit.org/show_bug.cgi?id=130185
2875
2876         Reviewed by Gyuyoung Kim.
2877
2878         * Scripts/webkitperl/FeatureList.pm:
2879
2880 2014-03-16  Zan Dobersek  <zdobersek@igalia.com>
2881
2882         [GTK][CMake] Build with -fno-rtti
2883         https://bugs.webkit.org/show_bug.cgi?id=130261
2884
2885         Reviewed by Martin Robinson.
2886
2887         * TestWebKitAPI/CMakeLists.txt: Build TestWebKitAPI with GTEST_HAS_RTTI macro
2888         defined to 0 to prevent typeid use in included GTest headers.
2889
2890 2014-03-16  Brian Burg  <bburg@apple.com>
2891
2892         Web Inspector: vended backend commands file should be generated as part of the build
2893         https://bugs.webkit.org/show_bug.cgi?id=130110
2894
2895         Reviewed by Timothy Hatcher.
2896
2897         * Scripts/build-webkit: build WebInspectorUI after WebCore but before WebKit.
2898
2899 2014-03-16  Diego Pino García  <dpino@igalia.com>
2900
2901         [GTK] Minibrowser: Add shortcuts for reloading page and reloading page ignoring cache
2902         https://bugs.webkit.org/show_bug.cgi?id=128999
2903
2904         Reviewed by Philippe Normand.
2905
2906         * MiniBrowser/gtk/BrowserWindow.c:
2907         (reloadPage):
2908         (reloadPageIgnoringCache):
2909         (browser_window_init):
2910
2911 2014-03-15  Martin Robinson  <mrobinson@igalia.com>
2912
2913         [GTK] Improve ninja detection in webkitdirs.pm
2914         https://bugs.webkit.org/show_bug.cgi?id=129902
2915
2916         Reviewed by Daniel Bates.
2917
2918         * Scripts/webkitdirs.pm:
2919         (canUseNinja): Use which instead of trying to invoke ninja directly. This also allows
2920         us to look for ninja-build as well.
2921
2922 2014-03-14  Maciej Stachowiak  <mjs@apple.com>
2923
2924         Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers
2925         https://bugs.webkit.org/show_bug.cgi?id=130276
2926         <rdar://problem/16266927>
2927         
2928         Reviewed by Simon Fraser.
2929
2930         * BuildSlaveSupport/build-launcher-app:
2931         * BuildSlaveSupport/build-launcher-dmg:
2932         * DumpRenderTree/DumpRenderTree.h:
2933         * DumpRenderTree/DumpRenderTreePrefix.h:
2934         * DumpRenderTree/GCController.cpp:
2935         * DumpRenderTree/GCController.h:
2936         * DumpRenderTree/JavaScriptThreading.cpp:
2937         * DumpRenderTree/JavaScriptThreading.h:
2938         * DumpRenderTree/PixelDumpSupport.cpp:
2939         * DumpRenderTree/PixelDumpSupport.h:
2940         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
2941         * DumpRenderTree/TestRunner.cpp:
2942         * DumpRenderTree/TestRunner.h:
2943         * DumpRenderTree/WorkQueue.cpp:
2944         * DumpRenderTree/WorkQueue.h:
2945         * DumpRenderTree/WorkQueueItem.h:
2946         * DumpRenderTree/atk/AccessibilityCallbacks.h:
2947         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
2948         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
2949         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
2950         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2951         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2952         * DumpRenderTree/efl/EditingCallbacks.cpp:
2953         * DumpRenderTree/efl/EditingCallbacks.h:
2954         * DumpRenderTree/efl/EventSender.cpp:
2955         * DumpRenderTree/efl/EventSender.h:
2956         * DumpRenderTree/efl/GCControllerEfl.cpp:
2957         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
2958         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2959         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2960         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
2961         * DumpRenderTree/gtk/EditingCallbacks.cpp:
2962         * DumpRenderTree/gtk/EditingCallbacks.h:
2963         * DumpRenderTree/gtk/EventSender.cpp:
2964         * DumpRenderTree/gtk/EventSender.h:
2965         * DumpRenderTree/gtk/GCControllerGtk.cpp:
2966         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
2967         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
2968         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h:
2969         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2970         * DumpRenderTree/gtk/TextInputController.cpp:
2971         * DumpRenderTree/gtk/TextInputController.h:
2972         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL:
2973         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
2974         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2975         * DumpRenderTree/mac/AppleScriptController.h:
2976         * DumpRenderTree/mac/AppleScriptController.m:
2977         * DumpRenderTree/mac/CheckedMalloc.cpp:
2978         * DumpRenderTree/mac/CheckedMalloc.h:
2979         * DumpRenderTree/mac/DumpRenderTree.mm:
2980         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
2981         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2982         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2983         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
2984         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2985         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2986         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2987         * DumpRenderTree/mac/EditingDelegate.h:
2988         * DumpRenderTree/mac/EditingDelegate.mm:
2989         * DumpRenderTree/mac/EventSendingController.h:
2990         * DumpRenderTree/mac/EventSendingController.mm:
2991         * DumpRenderTree/mac/FrameLoadDelegate.h:
2992         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2993         * DumpRenderTree/mac/GCControllerMac.mm:
2994         * DumpRenderTree/mac/MockWebNotificationProvider.h:
2995         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
2996         * DumpRenderTree/mac/NavigationController.h:
2997         * DumpRenderTree/mac/NavigationController.m:
2998         * DumpRenderTree/mac/ObjCController.h:
2999         * DumpRenderTree/mac/ObjCController.m:
3000         * DumpRenderTree/mac/ObjCPlugin.h:
3001         * DumpRenderTree/mac/ObjCPlugin.m:
3002         * DumpRenderTree/mac/ObjCPluginFunction.h:
3003         * DumpRenderTree/mac/ObjCPluginFunction.m:
3004         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3005         * DumpRenderTree/mac/PolicyDelegate.h:
3006         * DumpRenderTree/mac/PolicyDelegate.mm:
3007         * DumpRenderTree/mac/ResourceLoadDelegate.h:
3008         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3009         * DumpRenderTree/mac/TestRunnerMac.mm:
3010         * DumpRenderTree/mac/TextInputController.h:
3011         * DumpRenderTree/mac/TextInputController.m:
3012         * DumpRenderTree/mac/UIDelegate.h:
3013         * DumpRenderTree/mac/UIDelegate.mm:
3014         * DumpRenderTree/mac/WorkQueueItemMac.mm:
3015         * DumpRenderTree/win/DRTDataObject.cpp:
3016         * DumpRenderTree/win/DRTDataObject.h:
3017         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
3018         * DumpRenderTree/win/DRTDropSource.cpp:
3019         * DumpRenderTree/win/DRTDropSource.h:
3020         * DumpRenderTree/win/DraggingInfo.h:
3021         * DumpRenderTree/win/DumpRenderTree.cpp:
3022         * DumpRenderTree/win/DumpRenderTreeWin.h:
3023         * DumpRenderTree/win/EditingDelegate.cpp:
3024         * DumpRenderTree/win/EditingDelegate.h:
3025         * DumpRenderTree/win/EventSender.cpp:
3026         * DumpRenderTree/win/EventSender.h:
3027         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3028         * DumpRenderTree/win/FrameLoadDelegate.h:
3029         * DumpRenderTree/win/GCControllerWin.cpp:
3030         * DumpRenderTree/win/HistoryDelegate.cpp:
3031         * DumpRenderTree/win/HistoryDelegate.h:
3032         * DumpRenderTree/win/MD5.cpp:
3033         * DumpRenderTree/win/MD5.h:
3034         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3035         * DumpRenderTree/win/PolicyDelegate.cpp:
3036         * DumpRenderTree/win/PolicyDelegate.h:
3037         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3038         * DumpRenderTree/win/ResourceLoadDelegate.h:
3039         * DumpRenderTree/win/TestRunnerWin.cpp:
3040         * DumpRenderTree/win/TextInputController.cpp:
3041         * DumpRenderTree/win/TextInputController.h:
3042         * DumpRenderTree/win/TextInputControllerWin.cpp:
3043         * DumpRenderTree/win/UIDelegate.cpp:
3044         * DumpRenderTree/win/UIDelegate.h:
3045         * DumpRenderTree/win/WorkQueueItemWin.cpp:
3046         * EWebLauncher/main.c:
3047         * GtkLauncher/main.c:
3048         * ImageDiff/efl/ImageDiff.cpp:
3049         * ImageDiff/gtk/ImageDiff.cpp:
3050         * MiniBrowser/gtk/main.c:
3051         * Scripts/SpacingHeuristics.pm:
3052         * Scripts/VCSUtils.pm:
3053         * Scripts/bisect-builds:
3054         * Scripts/build-dumprendertree:
3055         * Scripts/build-jsc:
3056         * Scripts/build-webkit:
3057         * Scripts/check-dom-results:
3058         * Scripts/check-for-exit-time-destructors:
3059         * Scripts/check-for-global-initializers:
3060         * Scripts/commit-log-editor:
3061         * Scripts/compare-timing-files:
3062         * Scripts/debug-minibrowser:
3063         * Scripts/debug-safari:
3064         * Scripts/do-file-rename:
3065         * Scripts/find-extra-includes:
3066         * Scripts/generate-coverage-data:
3067         * Scripts/make-script-test-wrappers:
3068         * Scripts/malloc-tree:
3069         * Scripts/old-run-webkit-tests:
3070         * Scripts/parse-malloc-history:
3071         * Scripts/report-include-statistics:
3072         * Scripts/resolve-ChangeLogs:
3073         * Scripts/run-bindings-tests:
3074         * Scripts/run-iexploder-tests:
3075         * Scripts/run-javascriptcore-tests:
3076         * Scripts/run-jsc:
3077         * Scripts/run-launcher:
3078         * Scripts/run-leaks:
3079         * Scripts/run-mangleme-tests:
3080         * Scripts/run-minibrowser:
3081         * Scripts/run-pageloadtest:
3082         * Scripts/run-regexp-tests:
3083         * Scripts/run-safari:
3084         * Scripts/run-sunspider:
3085         * Scripts/run-webkit-app:
3086         * Scripts/sampstat:
3087         * Scripts/set-webkit-configuration:
3088         * Scripts/sort-Xcode-project-file:
3089         * Scripts/sort-export-file:
3090         * Scripts/split-file-by-class:
3091         * Scripts/sunspider-compare-results:
3092         * Scripts/svn-apply:
3093         * Scripts/svn-create-patch:
3094         * Scripts/svn-unapply:
3095         * Scripts/test-webkit-scripts:
3096         * Scripts/update-javascriptcore-test-results:
3097         * Scripts/update-webkit:
3098         * Scripts/update-webkit-auxiliary-libs:
3099         * Scripts/update-webkit-dependency:
3100         * Scripts/update-webkit-localizable-strings:
3101         * Scripts/update-webkit-support-libs:
3102         * Scripts/update-webkit-wincairo-libs:
3103         * Scripts/webkit-build-directory:
3104         * Scripts/webkitdirs.pm:
3105         (installedSafariPath):
3106         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
3107         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
3108         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
3109         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
3110         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
3111         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
3112         * Scripts/webkitperl/features.pm:
3113         * Scripts/webkitperl/httpd.pm:
3114         * Scripts/webkitpy/bindings/main.py:
3115         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
3116         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3117         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3118         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3119         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
3120         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
3121         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
3122         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3123         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
3124         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h:
3125         * WebKitTestRunner/PixelDumpSupport.cpp:
3126         * WebKitTestRunner/PixelDumpSupport.h:
3127         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3128         * WinLauncher/WinLauncher.cpp:
3129         * WinLauncher/WinLauncher.h:
3130         * WinLauncher/stdafx.cpp:
3131         * WinLauncher/stdafx.h:
3132
3133 2014-03-14  Filip Pizlo  <fpizlo@apple.com>
3134
3135         Sometimes we need to be explicit about the SDK when running ranlib on Darwin
3136         https://bugs.webkit.org/show_bug.cgi?id=130265
3137
3138         Reviewed by Michael Saboff.
3139
3140         * Scripts/build-webkit:
3141         * Scripts/copy-webkitlibraries-to-product-directory:
3142
3143 2014-03-14  Landry Breuil  <landry@openbsd.org>
3144
3145         Recognize openbsd/netbsd and am64 archs in Tools/Scripts.
3146         Also allow to set MAKE in the environment.
3147         https://bugs.webkit.org/show_bug.cgi?id=129991
3148
3149         Reviewed by Andreas Kling.
3150
3151         * Scripts/webkitdirs.pm:
3152         (determineArchitecture):
3153         (determineNumberOfCPUs):
3154         (isBSD):
3155         (buildAutotoolsProject):
3156         * Scripts/webkitpy/common/system/platforminfo.py:
3157         (PlatformInfo.__init__):
3158         (PlatformInfo.is_openbsd):
3159         (PlatformInfo):
3160         (PlatformInfo.is_netbsd):
3161         (PlatformInfo._determine_os_name):
3162
3163 2014-03-14  Dean Jackson  <dino@apple.com>
3164
3165         Remove libWebKitSystemInterfaceLion.a
3166         https://bugs.webkit.org/show_bug.cgi?id=130254
3167
3168         Reviewed by Geoffrey Garen and Andreas Kling.
3169
3170         No need to copy the Lion libraries into the build.
3171
3172         * Scripts/copy-webkitlibraries-to-product-directory:
3173
3174 2014-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3175
3176         [EFL][MiniBrowser] Revise help messages of command line parameters
3177         https://bugs.webkit.org/show_bug.cgi?id=130222
3178
3179         Reviewed by Csaba Osztrogonác.
3180
3181         Correct the default value description and make help messages to be consistent.
3182
3183         * MiniBrowser/efl/main.c:
3184
3185 2014-03-12  Sergio Villar Senin  <svillar@igalia.com>
3186
3187         Rename DEFINE_STATIC_LOCAL to DEPRECATED_DEFINE_STATIC_LOCAL
3188         https://bugs.webkit.org/show_bug.cgi?id=129612
3189
3190         Reviewed by Darin Adler.
3191
3192         For new code use static NeverDestroyed<T> instead.
3193
3194         * DumpRenderTree/JavaScriptThreading.cpp:
3195         (javaScriptThreadsMutex):
3196         (javaScriptThreads):
3197         * DumpRenderTree/efl/EventSender.cpp:
3198         (touchPointList):
3199         (delayedEventQueue):
3200         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3201         (delegatesWithDelayedWork):
3202         * Scripts/check-for-exit-time-destructors:
3203         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
3204         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
3205         (testsMap):
3206
3207 2014-03-13  Sanghyup Lee  <sh53.lee@samsung.com>
3208
3209         [EFL][WK2] Fix compilation warning in Minibrowser
3210         https://bugs.webkit.org/show_bug.cgi?id=130132
3211
3212         Reviewed by Csaba Osztrogonác.
3213
3214         Replace mktemp() with mkstemp() to fix compilation warning in MiniBrowser.
3215
3216         * MiniBrowser/efl/main.c:
3217         (on_download_request):
3218
3219 2014-03-13  Filip Pizlo  <fpizlo@apple.com>
3220
3221         FTL should support IsBlah
3222         https://bugs.webkit.org/show_bug.cgi?id=130202
3223
3224         Reviewed by Geoffrey Garen.
3225         
3226         Running existing JSRegress tests with noInline gives us coverage for these
3227         changes. Chances are, this will also give coverage for other interesting things
3228         as well.
3229
3230         * Scripts/run-jsc-stress-tests:
3231
3232 2014-03-12  Brian Burg  <bburg@apple.com>
3233
3234         Web Inspector: Remove unused callId parameter from evaluateInWebInspector
3235         https://bugs.webkit.org/show_bug.cgi?id=129744
3236
3237         Reviewed by Timothy Hatcher.
3238
3239         * DumpRenderTree/TestRunner.cpp:
3240         (evaluateInWebInspectorCallback):
3241         * DumpRenderTree/TestRunner.h:
3242         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3243         (TestRunner::evaluateInWebInspector):
3244         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3245         (TestRunner::evaluateInWebInspector):
3246         * DumpRenderTree/mac/TestRunnerMac.mm:
3247         (TestRunner::evaluateInWebInspector):
3248         * DumpRenderTree/win/TestRunnerWin.cpp:
3249         (TestRunner::evaluateInWebInspector):
3250         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3251         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3252         (WTR::TestRunner::evaluateInWebInspector):
3253         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3254
3255 2014-03-13  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
3256
3257         [GTK] build-webkit shouldn't show error message when ninja isn't installed
3258         https://bugs.webkit.org/show_bug.cgi?id=130129
3259
3260         Reviewed by Csaba Osztrogonác.
3261
3262         * Scripts/webkitdirs.pm:
3263         (canUseNinja): Redirecting stderr to /dev/null
3264
3265 2014-03-13  Andres Gomez  <agomez@igalia.com>
3266
3267         [GTK] "Tools/jhbuild/jhbuild-wrapper --gtk" build fails even after running Tools/gtk/install-dependencies due to missing proper libxml2 python bindings
3268         https://bugs.webkit.org/show_bug.cgi?id=130092
3269
3270         Reviewed by Csaba Osztrogonác.
3271
3272         Added "python-dev" as dependency for deb based distros. It is
3273         already present for rpm based distros. This dependency will allow
3274         libxml2 to generate its python bindings, needed by gtk-doc.
3275
3276         * gtk/install-dependencies:
3277
3278 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3279
3280         Unreviewed. Fix GTK+ cmake build after r165488.
3281
3282         * MiniBrowser/gtk/CMakeLists.txt: Add CMAKE_BINARY_DIR to include dirs.
3283
3284 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3285
3286         [GTK][CMAKE] Remove compile warnings about GTK+ deprecated API
3287         https://bugs.webkit.org/show_bug.cgi?id=130014
3288
3289         Reviewed by Martin Robinson.
3290
3291         Include cmake or autotools config header.
3292
3293         * MiniBrowser/gtk/BrowserDownloadsBar.c:
3294         * MiniBrowser/gtk/BrowserSearchBar.c:
3295         * MiniBrowser/gtk/BrowserWindow.c:
3296         * MiniBrowser/gtk/main.c:
3297
3298 2014-03-12  Commit Queue  <commit-queue@webkit.org>
3299
3300         Unreviewed, rolling out r165471.
3301         https://bugs.webkit.org/show_bug.cgi?id=130139
3302
3303         Didn't really fix the issue and broke another bot (Requested
3304         by mrobinson on #webkit).
3305
3306         Reverted changeset:
3307
3308         "[CMake] Newer versions of CMake cannot find older versions of
3309         Freetype"
3310         https://bugs.webkit.org/show_bug.cgi?id=130107
3311         http://trac.webkit.org/changeset/165471
3312
3313 2014-03-11  Filip Pizlo  <fpizlo@apple.com>
3314
3315         It should be possible to build WebKit with FTL on iOS
3316         https://bugs.webkit.org/show_bug.cgi?id=130116
3317
3318         Reviewed by Dan Bernstein.
3319
3320         * Scripts/build-webkit:
3321         * Scripts/copy-webkitlibraries-to-product-directory:
3322
3323 2014-03-12  Brent Fulgham  <bfulgham@apple.com>
3324
3325         [Win] Remove use of QTSDK
3326         https://bugs.webkit.org/show_bug.cgi?id=130049
3327
3328         Reviewed by Darin Adler.
3329
3330         * DumpRenderTree/win/DumpRenderTree.cpp:
3331         (initialize): Remove QuickTime code.
3332         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't grab logs from
3333         building QTMovieWin.
3334
3335 2014-03-12  Martin Robinson  <mrobinson@igalia.com>
3336
3337         [GTK][CMAKE] Too verbose build output
3338         https://bugs.webkit.org/show_bug.cgi?id=130076
3339
3340         Reviewed by Carlos Garcia Campos.
3341
3342         Instead of building with cmake --build which isn't smart about pretty printing and
3343         colors, we build with a script which calls the proper build command.
3344
3345         * Scripts/webkitdirs.pm:
3346         (buildCMakeGeneratedProject): For GTK+ call the script that we generate during
3347         the CMake configuration pass.
3348
3349 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
3350
3351         [CMake] Newer versions of CMake cannot find older versions of Freetype
3352         https://bugs.webkit.org/show_bug.cgi?id=130107
3353
3354         Reviewed by Gustavo Noronha Silva.
3355
3356         * gtk/jhbuildrc: Work around a bug in newer CMakes by giving the FREETYPE_DIR hint
3357         to CMake during jhbuild initialization.
3358
3359 2014-03-12  Zalan Bujtas  <zalan@apple.com>
3360
3361         Add hiDPI support for compositing content in DumpRenderTree/WebKitTestRunner
3362         https://bugs.webkit.org/show_bug.cgi?id=129961
3363
3364         Reviewed by Simon Fraser.
3365
3366         Now scaled content can go through the window capturing mechanism too for compositing content.
3367         AppleMagnifiedMode is redundant.
3368
3369         * DumpRenderTree/mac/DumpRenderTree.mm:
3370         (setDefaultsToConsistentValuesForTesting):
3371         (runTest):
3372         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3373         (createBitmapContextFromWebView):
3374         * WebKitTestRunner/PlatformWebView.h:
3375         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3376         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3377         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3378         (WTR::PlatformWebView::didInitializeClients):
3379         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3380         (WTR::PlatformWebView::forceWindowFramesChanged):
3381         * WebKitTestRunner/mac/main.mm:
3382         (setDefaultsToConsistentValuesForTesting):
3383
3384 2014-03-12  Anton Obzhirov  <a.obzhirov@samsung.com>
3385
3386         Unreviewed. Add myself as a committer.
3387
3388         * Scripts/webkitpy/common/config/contributors.json:
3389
3390 2014-03-12  Ryuan Choi  <ryuan.choi@samsung.com>
3391
3392         Unreviewed build fix on the EFL port when used lower version of ATK
3393
3394         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3395         (WTR::AccessibilityUIElement::y): Fixed typo.
3396
3397 2014-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
3398
3399         Some images are blank in the rebaseline server UI
3400         https://bugs.webkit.org/show_bug.cgi?id=130104
3401
3402         Reviewed by Tim Horton.
3403
3404         Let the server check for images in the 'retries' directory
3405         if it can't find an image otherwise.
3406
3407         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3408         (RebaselineHTTPRequestHandler.test_result):
3409
3410 2014-03-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3411
3412         [GTK][CMake] --update-gtk has no effect
3413         https://bugs.webkit.org/show_bug.cgi?id=130088
3414
3415         Reviewed by Philippe Normand.
3416
3417         * Scripts/webkitdirs.pm:
3418         (buildCMakeProjectOrExit): call update-webkitgtk-libs if --update-gtk has been passed
3419         as an argument.
3420
3421 2014-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
3422
3423         Add "System Font" to the list of whitelisted DRT fonts
3424         https://bugs.webkit.org/show_bug.cgi?id=130046
3425
3426         Reviewed by Darin Adler.
3427
3428         * DumpRenderTree/mac/DumpRenderTree.mm:
3429         (allowedFontFamilySet):
3430         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3431
3432 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
3433
3434         [GTK] The jhbuild environment should set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_PATH
3435         https://bugs.webkit.org/show_bug.cgi?id=130064
3436
3437         Reviewed by Philippe Normand.
3438
3439         * efl/jhbuildrc: Remove duplicated code.
3440         * gtk/jhbuildrc: Remove duplicated code.
3441         * jhbuild/jhbuildrc_common.py:
3442         (init): Move duplicated code from jhbuildrc's and extend setting CMake environment variables to
3443         GTK+. We always set the CMAKE_LIBRARY_PATH, which should be harmless for EFL 32-bit systems.
3444         and is apparently necessary for GTK+.
3445
3446 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
3447
3448         check-webkit-style failed to complain about missing braces
3449         https://bugs.webkit.org/show_bug.cgi?id=34189
3450
3451         Reviewed by Ryosuke Niwa.
3452
3453         * Scripts/webkitpy/style/checkers/cpp.py:
3454         (check_braces):
3455         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3456         (WebKitStyleTest.test_braces):
3457
3458 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
3459
3460         Remove Qt cruft from style checker.
3461         https://bugs.webkit.org/show_bug.cgi?id=130085
3462
3463         Reviewed by Csaba Osztrogonác.
3464
3465         There is no 'foreach' keyword in c++. That was a Qt feature
3466         added in: http://trac.webkit.org/changeset/46113
3467         Qt was removed from WebKit, so we should remove the checks
3468         of this keyword from check-webkit-style scripts.
3469
3470         * Scripts/webkitpy/style/checkers/cpp.py:
3471         (check_spacing_for_function_call):
3472         (check_spacing):
3473         (check_braces):
3474         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3475         (CppStyleTest.test_mismatching_spaces_in_parens):
3476         (CppStyleTest.test_spacing_for_fncall):
3477         (WebKitStyleTest.test_braces):
3478
3479 2014-03-11  Martin Hodovan  <mhodovan@inf.u-szeged.hu>
3480
3481         [GTK] update-webkitgtk-libs needs itstool
3482         https://bugs.webkit.org/show_bug.cgi?id=130082
3483
3484         After http://trac.webkit.org/changeset/165110 WebKitGTK+ uses gtk-doc 1.20.
3485         itstool is a dependency of building gtk-doc from version 1.19, so it should
3486         be added to Tools/gtk/install-dependencies script, too.
3487
3488         Reviewed by Philippe Normand.
3489
3490         * gtk/install-dependencies:
3491
3492 2014-03-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3493
3494         webkitbot rollout ChangeLogs should be nicer
3495         https://bugs.webkit.org/show_bug.cgi?id=122654
3496
3497         Reviewed by Csaba Osztrogonác.
3498
3499         Added bug urls and descriptions of rolled out patches to the rollout changelog
3500         if they are present in the original changelog. Additionally removed the list of
3501         changed files and functions.
3502
3503         * Scripts/webkitpy/common/checkout/changelog.py:
3504         (ChangeLog.update_with_unreviewed_message): Cut off the list of modified files.
3505         * Scripts/webkitpy/common/checkout/checkout.py:
3506         (Checkout._changelog_data_for_revision): Store bug description.
3507         * Scripts/webkitpy/common/checkout/checkout_mock.py:
3508         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3509         (CheckoutTest.test_commit_info_for_revision):
3510         * Scripts/webkitpy/common/checkout/commitinfo.py:
3511         (CommitInfo.bug_description): Added.
3512         (CommitInfo.to_json):
3513         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
3514         (CommitInfoTest.test_commit_info_creation):
3515         * Scripts/webkitpy/tool/commands/download.py:
3516         (AbstractRolloutPrepCommand._prepare_state): Store bug ids and descriptions of rolled
3517         out patches for creating rollout changelog.
3518         (CreateRollout._prepare_state): Remove obsolete comments and code, the bug id that
3519         caused the regression is stored in state["bug_blocked"] now.
3520         * Scripts/webkitpy/tool/commands/download_unittest.py:
3521         (test_prepare_rollout):
3522         (test_create_rollout_multiple_revision):
3523         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3524         (PrepareChangeLogForRevert._message_for_revert): Add bug urls and descriptions of
3525         rolled out patches to the changelog.
3526         (PrepareChangeLogForRevert.run):
3527         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
3528         (UpdateChangeLogsForRevertTest):
3529         (test_message_for_revert):
3530         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
3531         (ReopenBugAfterRollout.run):
3532
3533 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
3534
3535         [ATK] Adjust WKTR/DRT to use new API from ATK 2.11.90
3536         https://bugs.webkit.org/show_bug.cgi?id=130021
3537
3538         Reviewed by Mario Sanchez Prada.
3539
3540         Replace deprecated functions to use new API from ATK 2.11.90.
3541
3542         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3543         (AccessibilityUIElement::x):
3544         (AccessibilityUIElement::y):
3545         (AccessibilityUIElement::width):
3546         (AccessibilityUIElement::height):
3547         (AccessibilityUIElement::clickPointX):
3548         (AccessibilityUIElement::clickPointY):
3549         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3550         (WTR::AccessibilityUIElement::x):
3551         (WTR::AccessibilityUIElement::y):
3552         (WTR::AccessibilityUIElement::width):
3553         (WTR::AccessibilityUIElement::height):
3554         (WTR::AccessibilityUIElement::clickPointX):
3555         (WTR::AccessibilityUIElement::clickPointY):
3556
3557 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
3558
3559         [ATK] Expose aria-posinset and aria-setsize through object attributes
3560         https://bugs.webkit.org/show_bug.cgi?id=130011
3561
3562         Reviewed by Chris Fleizach.
3563
3564         Added missing implementation of numberAttributeValue both to WKTR and DRT.
3565
3566         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3567         (AccessibilityUIElement::numberAttributeValue):
3568         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3569         (WTR::AccessibilityUIElement::numberAttributeValue):
3570
3571 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
3572
3573         [Win] Unreviewed build fix.
3574
3575         Some bad Windows code was committed at some point that prevents the Apple Windows port
3576         from finding its runtime dependencies reliably.
3577
3578         * win/DLLLauncher/DLLLauncherMain.cpp:
3579         (appleApplicationSupportDirectory): Restored this function.
3580         (modifyPath): Update to use appleApplicationSupportDirectory function.
3581
3582 2014-03-10  Zoltan Horvath  <zoltan@webkit.org>
3583
3584         Let the user define the full address of the performance-site-server for uploading results
3585         https://bugs.webkit.org/show_bug.cgi?id=129819
3586
3587         Reviewed by Ryosuke Niwa.
3588
3589         Currently perftestsrunner.py assumes that the server uses https protocol all the time, which
3590         can be confusing. It's more straightforward, if you need to define explicitly the server's full
3591         address along with the protocol, when you're using this parameter. I added HTTPS as the default
3592         protocol for now, in order to avoid breaking the perf bots.
3593
3594         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3595         (_upload_json):
3596         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3597         (MainTest.test_upload_json):
3598
3599 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
3600
3601         [Win] Pass environment to Pre-Build, Pre-Link, and Post-Build Stages.
3602         https://bugs.webkit.org/show_bug.cgi?id=130023
3603
3604         Reviewed by Dean Jackson.
3605
3606         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add missing
3607         /SAFESEH flag to DLL launcher process.
3608
3609 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
3610
3611         RunGtkWebKitGObjectDOMBindingsAPIBreakTests should be added to the BuildAndTestFactory not the TestFactory
3612         https://bugs.webkit.org/show_bug.cgi?id=129980
3613
3614         Reviewed by Carlos Garcia Campos.
3615
3616         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add RunGtkWebKitGObjectDOMBindingsAPIBreakTests to the correct factory.
3617
3618 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
3619
3620         [GTK] Remove the WebView source-mode WebKit1 test
3621         https://bugs.webkit.org/show_bug.cgi?id=129976
3622
3623         Reviewed by Carlos Garcia Campos.
3624
3625         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Remove the source-mode test.
3626
3627 2014-03-08  Martin Robinson  <mrobinson@igalia.com>
3628
3629         Unreviewed build fix for GTKbuild after the switch to CMake
3630
3631         * gtk/common.py:
3632         (is_cmake_build): Like r165284, we need to assume CMake by default, since the
3633         test-only bot doesn't have any build files.
3634
3635 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
3636
3637         [GTK] built-product-archive does not handle GTK+ CMake build
3638         https://bugs.webkit.org/show_bug.cgi?id=129941
3639
3640         * BuildSlaveSupport/built-product-archive:
3641         (archiveBuiltProduct): Fix the build by adding support to built-product-archive for
3642         the CMake build.
3643
3644 2014-03-07  Lorenzo Tilve  <ltilve@igalia.com>
3645
3646         [GTK] Include CMake into install-dependencies script
3647         https://bugs.webkit.org/show_bug.cgi?id=129909
3648
3649         Reviewed by Martin Robinson.
3650
3651         As since r165267 buid-webkit uses CMake by default, the dependency
3652         with 'cmake' package should be introduced.
3653
3654         * gtk/install-dependencies: Ditto.
3655
3656 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
3657
3658         REGRESSION(165267): Broke a webkitpy unit tests
3659         https://bugs.webkit.org/show_bug.cgi?id=129904
3660
3661         Reviewed by Jon Honeycutt.
3662
3663         * Scripts/webkitpy/port/gtk.py: Flip the default test to assume CMake by default.
3664         (GtkPort._is_cmake_build):
3665
3666 2014-03-07  Andres Gomez  <agomez@igalia.com>
3667
3668         [GTK] webkit-patch setup-git-clone fails even after running Tools/gtk/install-dependencies
3669         https://bugs.webkit.org/show_bug.cgi?id=129893
3670
3671         Reviewed by Martin Robinson.
3672
3673         Added "git-svn" as dependency for deb based distros and,
3674         additionally, "subversion" for rpm based distros.
3675
3676         * gtk/install-dependencies:
3677
3678 2014-03-07  Roger Fong  <roger_fong@apple.com>
3679
3680         Remove dummy setSystemWebGLLoadPolicy client method.
3681         https://bugs.webkit.org/show_bug.cgi?id=129873.
3682
3683         Reviewed by Dean Jackson.
3684
3685         * WebKitTestRunner/TestController.cpp:
3686         (WTR::TestController::createWebViewWithOptions):
3687
3688 2014-03-07  Mark Hahnenberg  <mhahnenberg@apple.com>
3689
3690         run-jsc-stress-tests doesn't eagerly report test failures when using the shell runner
3691         https://bugs.webkit.org/show_bug.cgi?id=129886
3692
3693         Reviewed by Mark Lam.
3694
3695         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added a "verbose" mode to the shell runner.
3696         If we're in verbose mode, then we don't redirect any output when running each test. If we're not
3697         in verbose mode then we redirect stdout to /dev/null and allow any stderr output through.
3698         * Scripts/run-jsc-stress-tests: Redirect any sort of error output to stderr so that it will 
3699         make it through when in non-verbose mode.
3700
3701 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
3702
3703         [GTK] buid-webkit should use CMake by default
3704         https://bugs.webkit.org/show_bug.cgi?id=129855
3705
3706         Reviewed by Carlos Garcia Campos.
3707
3708         Make the CMake build the default GTK+ build when using build-webkit. This will
3709         ensure that all bots are using CMake. We do this by swapping --gtk and --gtkcmake,
3710         so that we have --gtk and --gtkautotools.
3711
3712         * Scripts/webkitdirs.pm: Swap --gtkcmake/--gtk for --gtk/--gtkautotools.
3713         * Scripts/webkitpy/port/gtk.py: Ditto.
3714
3715 2014-03-06  Martin Robinson  <mrobinson@igalia.com>
3716
3717         [CMake] [GTK] Build with ninja when it is available
3718         https://bugs.webkit.org/show_bug.cgi?id=129805
3719
3720         Reviewed by Philippe Normand.
3721
3722         * Scripts/webkitdirs.pm:
3723         (canUseNinja): Added this helper which tries to execute Ninja, in an effort to determine
3724         if it's available on the system.
3725         (cmakeGeneratedBuildfile): Return the path to the generated build file. Only Unix support ATM.
3726         (generateBuildSystemFromCMakeProject): For GTK+ compile with Ninja when possible.
3727
3728 2014-03-06  Filip Pizlo  <fpizlo@apple.com>
3729
3730         If the FTL is build-time enabled then it should be run-time enabled.
3731
3732         Rubber stamped by Geoffrey Garen.
3733
3734         * Scripts/run-jsc-stress-tests:
3735
3736 2014-03-06  Mark Hahnenberg  <mhahnenberg@apple.com>
3737
3738         detectFailures in run-jsc-stress-tests can report everything was ok if too many tests fail
3739         https://bugs.webkit.org/show_bug.cgi?id=129837
3740
3741         Reviewed by Michael Saboff.
3742
3743         ls test_fail_* can fail if there are too many files that match. We then swallow that error, which makes everything seem ok.
3744         The fix is to use find instead of ls like we do in shell-runner.sh.
3745
3746         * Scripts/run-jsc-stress-tests:
3747
3748 2014-03-06  Joseph Pecoraro  <pecoraro@apple.com>
3749
3750         filter-build-webkit should not strip .o
3751         https://bugs.webkit.org/show_bug.cgi?id=129614
3752
3753         Reviewed by Dean Jackson.
3754
3755         This makes it much easier to jump from the failing output at
3756         the end back up to the compile errors earlier in the output.
3757
3758         * Scripts/filter-build-webkit:
3759
3760 2014-03-06  Anders Carlsson  <andersca@apple.com>
3761
3762         Build WebKit2 before building WebKit
3763         https://bugs.webkit.org/show_bug.cgi?id=129831
3764         <rdar://problem/15920020>
3765
3766         Reviewed by Dan Bernstein.
3767
3768         * Scripts/build-webkit:
3769         Always build WebKit2 and make sure to build it before WebKit when building on Mac.
3770
3771 2014-03-06  ChangSeok Oh  <changseok.oh@collabora.com>
3772
3773         make-3.82 fails to build on ARM/Linux
3774         https://bugs.webkit.org/show_bug.cgi?id=107926
3775
3776         Reviewed by Martin Robinson.
3777
3778         Some ARM/Linux systems don't support PAGE_SIZE macro so that it causes a build failure.
3779         The related bug reporting is here. https://lists.debian.org/debian-kernel/2014/02/msg00274.html
3780         To avoid this, I propose to use sysconf(_SC_PAGESIZE) instead of PAGE_SIZE
3781         where it is not defined. See more details, http://linux.die.net/man/2/getpagesize
3782
3783         * gtk/patches/make-3.82-arg-list-length.patch:
3784
3785 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3786
3787         [GTK] Close the page when the view is disposed instead of when finalized
3788         https://bugs.webkit.org/show_bug.cgi?id=129783
3789
3790         Reviewed by Sergio Villar Senin.
3791
3792         Add test case but disabled for now because it's affetected by bug #129684.
3793
3794         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
3795         (testProcessPerWebView):
3796
3797 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3798
3799         [GTK] MiniBrowser crashes when opening several urls passed as command line options
3800         https://bugs.webkit.org/show_bug.cgi?id=129738
3801
3802         Reviewed by Sergio Villar Senin.
3803
3804         The problem is that we are calling g_object_unref() for the
3805         WebKitWebSettings everytime we set it to a WebKitWebView, but the
3806         view only increases the reference counter when the settings is not
3807         the same it currently has. We should release our reference once.
3808
3809         * MiniBrowser/gtk/main.c:
3810         (createBrowserWindow):
3811         (main):
3812
3813 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
3814
3815         [GTK][CMake] Tarball is created with wrong tarball paths
3816         https://bugs.webkit.org/show_bug.cgi?id=129496
3817
3818         Reviewed by Daniel Bates.
3819
3820         * gtk/make-dist.py:
3821         (Manifest.__init__): I inadvertently inverted the logic of these checks when
3822         landing the original patch with some suggestions from the reviewer. With the
3823         checks corrected, the tarball path is constructed properly.
3824
3825 2014-03-05  Jae Hyun Park  <jaepark@webkit.org>
3826
3827         Unreviewed. Update my email in contributors.json
3828
3829         * Scripts/webkitpy/common/config/contributors.json:
3830
3831 2014-03-05  Dean Jackson  <dino@apple.com>
3832
3833         [WebGL] Use WKSI to see what the system policy for WebGL is
3834         https://bugs.webkit.org/show_bug.cgi?id=129722
3835         <rdar://problem/15790542>
3836
3837         Reviewed by Tim Horton.
3838
3839         Dummy entry for setSystemWebGLLoadPolicy.
3840
3841         * WebKitTestRunner/TestController.cpp:
3842         (WTR::TestController::createWebViewWithOptions):
3843
3844 2014-03-03  Martin Robinson  <mrobinson@igalia.com>
3845
3846         [GTK][CMake] Generate documentation for the DOM bindings
3847         https://bugs.webkit.org/show_bug.cgi?id=126211
3848
3849         Reviewed by Carlos Garcia Campos.
3850
3851         * gtk/GNUmakefile.am: No longer generation sections and SGML files in the makefile.
3852         * gtk/generate-gtkdoc: Call the code from webkitdom.py to generate sections and SGML files.
3853         * gtk/generate-webkitdom-doc-files: Removed.
3854         * gtk/webkitdom.py: Moved WebKit GObject DOM bindings doc generation code here, so
3855         that it can be called by generate-gtkdoc.
3856
3857 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
3858
3859         [GTK][CMake] build-webkit should rerun cmake if the Makefile is missing
3860         https://bugs.webkit.org/show_bug.cgi?id=129380
3861
3862         Reviewed by Philippe Normand.
3863
3864         * Scripts/webkitdirs.pm:
3865         (generateBuildSystemFromCMakeProject): Check for the existence of the Makefile before
3866         skipping CMake execution.
3867
3868 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
3869
3870         [GTK] The jhbuild environment should have the latest stable release of gtk-doc
3871         https://bugs.webkit.org/show_bug.cgi?id=129651
3872
3873         Reviewed by Philippe Normand.
3874
3875         * gtk/jhbuild.modules: Add gtk-doc to the list of modules.
3876
3877 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
3878
3879         [GTK] Give the WebKit GObject DOM bindings API break detection it's own buildbot bubble
3880         https://bugs.webkit.org/show_bug.cgi?id=129637
3881
3882         Reviewed by Carlos Garcia Campos.
3883
3884         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3885         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests): Added this test runner.
3886         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.commandComplete): Run the breakage test command and scan the output.
3887         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand): Return failure if there is missing API (an API break).
3888         New API typically just requires a rebaseline and isn't necessarily a faiulre.
3889         (TestFactory.__init__): Add the test for GTK+.
3890         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add a unit test for the new bubble.
3891
3892 2014-03-05  Krzysztof Czech  <k.czech@samsung.com>
3893
3894         [ATK] Expose missing functionalities of AtkTableCell to AT
3895         https://bugs.webkit.org/show_bug.cgi?id=129492
3896
3897         Reviewed by Mario Sanchez Prada.
3898
3899         Reducing some code by using new API of AtkTableCell.
3900
3901         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3902         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3903
3904 2014-03-04  Alex Christensen  <achristensen@webkit.org>
3905
3906         Preparing to run layout tests on Wincairo.
3907         https://bugs.webkit.org/show_bug.cgi?id=129709
3908
3909         Reviewed by Brent Fulgham.
3910
3911         * Scripts/webkitdirs.pm:
3912         (setPathForRunningWebKitApp):
3913         Add GStreamer directory for WinCairo running layout tests.
3914         * win/DLLLauncher/DLLLauncherMain.cpp:
3915         (modifyPath):
3916         Added the WinCairo bin32 or bin64 directory for running WinLauncher.
3917
3918 2014-03-04  Martin Robinson  <mrobinson@igalia.com>
3919
3920         [GTK] Simplify the GObject DOM bindings API break check into one step
3921         https://bugs.webkit.org/show_bug.cgi?id=129571
3922
3923         Reviewed by Carlos Garcia Campos.
3924
3925         * GNUmakefile.am: Add the API break check to 'make check.'
3926         * gtk/check-for-webkitdom-api-breaks: Added. A combination of the two removed scripts.
3927         * gtk/check-gdom-symbols: Removed.
3928         * gtk/webkitdom.py: Added.
3929         (header_name_list_from_gtkdoc_config_file): Gets the names of all headers from the gtkdoc config file.
3930         (get_all_webkitdom_symbol_files): Find the symbol files from the names.
3931
3932 2014-03-03  Simon Fraser  <simon.fraser@apple.com>
3933
3934         Add Jeremy Jones to the contributors list as a contributor.
3935
3936         * Scripts/webkitpy/common/config/contributors.json:
3937
3938 2014-03-03  Adenilson Cavalcanti  <cavalcantii@gmail.com>
3939
3940         Unreviewed. Update contact email.
3941         https://bugs.webkit.org/show_bug.cgi?id=129610
3942
3943         * Scripts/webkitpy/common/config/contributors.json:
3944
3945 2014-03-02  Brian Burg  <bburg@apple.com>
3946
3947         Web Inspector model tests load wrong inspector page under WebKitTestRunner
3948         https://bugs.webkit.org/show_bug.cgi?id=129460
3949
3950         Reviewed by Dan Bernstein.
3951
3952         Don't unconditionally open the inspector before running an inspector test.
3953         Instead, the test should request that the inspector open when it's ready.
3954
3955         This change was lost during a rebase, but is the same change made to
3956         DumpRenderTree.
3957
3958         * WebKitTestRunner/TestInvocation.cpp:
3959         (WTR::TestInvocation::invoke): 
3960
3961 2014-03-02  Darin Adler  <darin@apple.com>
3962
3963         Split TextIteratorBehavior into a separate header
3964         https://bugs.webkit.org/show_bug.cgi?id=129578
3965
3966         Reviewed by Sam Weinig.
3967
3968         * Scripts/sort-export-file: Added special cases to the script so you can just paste link errors
3969         from WebKit in and the script will add them in as unconditional exports. This makes the "add"
3970         task easy, but the remove is still a bit of a pain.
3971
3972 2014-03-02  Darin Adler  <darin@apple.com>
3973
3974         Sort Mac platform export files so they merge better
3975         https://bugs.webkit.org/show_bug.cgi?id=129581
3976
3977         Reviewed by Sam Weinig.
3978
3979         * Scripts/sort-export-file: Added. Quickly whipped together script that sorts
3980         Mac export files in a "canonical" order for this project.
3981
3982 2014-02-28  Zalan Bujtas  <zalan@apple.com>
3983
3984         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
3985         https://bugs.webkit.org/show_bug.cgi?id=129438
3986
3987         Reviewed by Simon Fraser.
3988
3989         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
3990         offscreen window. It makes testing subpixel rendering and positioning possible.
3991
3992         Both the offscreen window's and WebKit's scaling are set accordingly.
3993
3994         * DumpRenderTree/mac/DumpRenderTree.mm:
3995         (createWebViewAndOffscreenWindow): cleanup
3996         (destroyWebViewAndOffscreenWindow): cleanup
3997         (dumpRenderTree):
3998         (changeWindowScaleIfNeeded):
3999         (runTest):
4000         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
4001         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
4002         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup
4003         * WebKitTestRunner/PlatformWebView.h:
4004         * WebKitTestRunner/TestInvocation.cpp:
4005         (WTR::changeWindowScaleIfNeeded):
4006         (WTR::TestInvocation::invoke):
4007         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
4008         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
4009         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
4010         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
4011         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4012         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
4013         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4014         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
4015
4016 2014-02-28  Anders Carlsson  <andersca@apple.com>
4017
4018         Remove logging.
4019
4020         Reviewed by Dan Bernstein.
4021
4022         * MiniBrowser/mac/WK2BrowserWindowController.m:
4023         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]):
4024
4025 2014-02-28  Daniel Bates  <dabates@apple.com>
4026
4027         [iOS] DumpRenderTree Perl Support may build against wrong SDK and toolchain
4028         https://bugs.webkit.org/show_bug.cgi?id=129163
4029
4030         Reviewed by David Kilzer.
4031
4032         Fixes an issue where DumpRenderTree Perl Support may build with the specified
4033         iOS Simulator SDK and toolchain instead of using the OS X SDK and toolchain.
4034         This issue manifests itself in a build failure when building the IPhoneSimulatorNotification
4035         bundle.
4036
4037         Currently we build DumpRenderTree Perl Support with respect to the variable SDKROOT,
4038         which is specified either explicitly when building with MAKE(1) or implicitly by
4039         build-{dumprendertree, webkit}. Instead we should always build Perl Support using
4040         the OS X SDK and toolchain since the built products are only applicable to OS X.
4041
4042         * DumpRenderTree/ios/PerlSupport/Makefile:
4043
4044 2014-02-28  Commit Queue  <commit-queue@webkit.org>
4045
4046         Unreviewed, rolling out r164859.
4047         http://trac.webkit.org/changeset/164859
4048         https://bugs.webkit.org/show_bug.cgi?id=129483
4049
4050         caused WK1 crashes (DumpRenderTree) (Requested by zalan on
4051         #webkit).
4052
4053         * DumpRenderTree/mac/DumpRenderTree.mm:
4054         (createWebViewAndOffscreenWindow):
4055         (dumpRenderTree):
4056         (runTest):
4057         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
4058         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
4059         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
4060         * WebKitTestRunner/PlatformWebView.h:
4061         * WebKitTestRunner/TestInvocation.cpp:
4062         (WTR::TestInvocation::invoke):
4063         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
4064         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
4065         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4066         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4067         (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
4068
4069 2014-02-28  Zalan Bujtas  <zalan@apple.com>
4070
4071         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
4072         https://bugs.webkit.org/show_bug.cgi?id=129438
4073
4074         Reviewed by Simon Fraser.
4075
4076         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
4077         offscreen window. It makes testing subpixel rendering and positioning possible.
4078
4079         Both the offscreen window's and WebKit's scaling are set accordingly.
4080
4081         * DumpRenderTree/mac/DumpRenderTree.mm:
4082         (createWebViewAndOffscreenWindow): unrelated cleanup.
4083         (destroyWebViewAndOffscreenWindow): unrelated cleanup.
4084         (dumpRenderTree):
4085         (changeOffscreenWindowScaleIfNeeded):
4086         (runTest):
4087         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
4088         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
4089         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup.
4090         * WebKitTestRunner/PlatformWebView.h:
4091         * WebKitTestRunner/TestInvocation.cpp:
4092         (WTR::changeOffscreenWindowScaleIfNeeded):
4093         (WTR::TestInvocation::invoke):
4094         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4095         (WTR::PlatformWebView::changeOffscreenWindowScaleIfNeeded):
4096
4097 2014-02-27  Brian Burg  <bburg@apple.com>
4098
4099         Web Inspector: model tests should use a special Test.html inspector page
4100         https://bugs.webkit.org/show_bug.cgi?id=129190
4101
4102         Reviewed by Timothy Hatcher.
4103
4104         Remove code that immediately opens the Web Inspector based on the file path of the test.
4105         Instead, the test page should request that the inspector open inside its `test()` method.
4106
4107         This change is necessary because otherwise, the inspector would be opened too early for
4108         InspectorController::isUnderTest to get set in time, so the normal Web Inspector page
4109         will get loaded instead of the minimal test page.
4110
4111         * DumpRenderTree/efl/DumpRenderTree.cpp:
4112         (createTestRunner):
4113         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4114         (runTest):
4115         * DumpRenderTree/mac/DumpRenderTree.mm:
4116         (runTest):
4117         * DumpRenderTree/win/DumpRenderTree.cpp:
4118         (runTest):
4119
4120 2014-02-27  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
4121
4122         check-webkit-style indentation false alarm in WebKit/win/WebNodeHighlight.cpp
4123         https://bugs.webkit.org/show_bug.cgi?id=127076
4124
4125         Reviewed by Anders Carlsson.
4126
4127         Avoid match for :: as start of a member initialization list. Modify expression to match
4128         after a colon either non-colon character or end of line.
4129
4130         * Scripts/webkitpy/style/checkers/cpp.py:
4131         (check_member_initialization_list):
4132         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4133         (WebKitStyleTest.test_member_initialization_list):
4134
4135 2014-02-27  Renata Hodovan  <rhodovan.u-szeged@partner.samsung.com>
4136
4137         Unreviewed. Update my email addresses in contributors.json.
4138
4139         * Scripts/webkitpy/common/config/contributors.json:
4140
4141 2014-02-27  Alberto Garcia  <berto@igalia.com>
4142
4143         [gtk-doc] UnicodeEncodeError: 'ascii' codec can't encode character
4144         https://bugs.webkit.org/show_bug.cgi?id=128927
4145
4146         Reviewed by Philippe Normand.
4147
4148         Encode manually the data for sys.{stdout,stderr}.write.
4149
4150         * gtk/gtkdoc.py:
4151         (GTKDoc._run_command):
4152
4153 2014-02-27  Andres Gomez  <agomez@igalia.com>
4154
4155         Unreviewed. Add myself to watchlists
4156
4157         * Scripts/webkitpy/common/config/watchlist: Add myself to
4158         watchlists.
4159
4160 2014-02-27  Andres Gomez  <agomez@igalia.com>
4161
4162         Unreviewed, rolling out r164790.
4163         http://trac.webkit.org/changeset/164790
4164
4165         Revert r164790 because of erroneous commit log
4166
4167         * Scripts/webkitpy/common/config/watchlist:
4168
4169 2014-02-27  Krzysztof Czech  <k.czech@samsung.com>
4170
4171         [ATK] Utilize AtkTableCell to expose directly AccessibilityTableCell to AT
4172         https://bugs.webkit.org/show_bug.cgi?id=129250
4173
4174         Reviewed by Mario Sanchez Prada.
4175
4176         Changing version of ATK to 2.11.90, because it introduces AtkTableCell interface.
4177         Implementing methods so that we could test column/row headers represented as an array of cells.
4178
4179         * DumpRenderTree/AccessibilityUIElement.cpp:
4180         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
4181         (AccessibilityUIElement::columnHeaders):
4182         (AccessibilityUIElement::rowHeaders):
4183         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Adding empty stubs, to not break compilation.
4184         (AccessibilityUIElement::columnHeaders):
4185         (AccessibilityUIElement::rowHeaders):
4186         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4187         (WTR::AccessibilityUIElement::rowHeaders):
4188         (WTR::AccessibilityUIElement::columnHeaders):
4189         * efl/jhbuild.modules:
4190         * gtk/jhbuild.modules:
4191
4192 2014-02-27  Andres Gomez  <agomez@igalia.com>
4193
4194         Unreviewed. Add myself to watchlists
4195
4196         * Scripts/webkitpy/common/config/watchlist: Add myself to
4197         watchlists.
4198
4199 2014-02-27  Andres Gomez  <agomez@igalia.com>
4200
4201         Unreviewed. Add myself as a committer.
4202
4203         * Scripts/webkitpy/common/config/contributors.json:
4204
4205 2014-02-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>
4206
4207         Unreviewed. Add Víctor Jáquez and myself to watchlists
4208
4209         * Scripts/webkitpy/common/config/watchlist: Add Víctor Jáquez and
4210         myself to watchlists.
4211
4212 2014-02-26  Julien Brianceau  <jbriance@cisco.com>
4213
4214         Unreviewed. Add myself as a committer.
4215
4216         * Scripts/webkitpy/common/config/contributors.json:
4217
4218 2014-02-26  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
4219
4220         Unreviewed. Moved myself to the list of committers.
4221
4222         * Scripts/webkitpy/common/config/contributors.json:
4223
4224 2014-02-24  Martin Robinson  <mrobinson@igalia.com>
4225
4226         [GTK] Reduplicate common.top_level_path in scripts
4227         https://bugs.webkit.org/show_bug.cgi?id=129291
4228
4229         Reviewed by Philippe Normand.
4230
4231         Duplicate common.top_level_path and avoid polluting many scripts with awkward system
4232         path manipulation and weird dependencies on the jhbuild infrastructure.
4233
4234         * Scripts/run-gtk-tests: Use common again.
4235         (TestRunner._setup_testing_environment): Ditto.
4236         * gtk/check-gdom-symbols: Ditto.
4237         * gtk/common.py:
4238         (top_level_path): Re-add top_level_path..
4239         (get_build_path): Use the builtin top_level_path again.
4240         * gtk/find-make-dist-errors: Use common again.
4241         (get_missing_headers): Ditto.
4242         * gtk/generate-inspector-gresource-manifest.py: Ditto.
4243
4244 2014-02-26  Mark Hahnenberg  <mhahnenberg@apple.com>
4245
4246         runscript: line 42: /bin/ls: Argument list too long
4247         https://bugs.webkit.org/show_bug.cgi?id=129376
4248
4249         Reviewed by Michael Saboff.
4250
4251         The "test_script_*" can expand to more things than can be passed as arguments on the command line. 
4252         We should use find instead, which generates the list of files rather than expanding them all on 
4253         the command line and spitting them back out.
4254
4255         * Scripts/jsc-stress-test-helpers/shell-runner.sh: 
4256
4257 2014-02-26  Martin Robinson  <mrobinson@igalia.com>
4258
4259         ENABLE_PROMISES is improperly specified as ENABLE_PROMISE in Features.pm
4260         https://bugs.webkit.org/show_bug.cgi?id=129377
4261
4262         Reviewed by Csaba Osztrogonác.
4263
4264         * Scripts/webkitperl/FeatureList.pm: Properly specify the promises feature as ENABLE_PROMISES.
4265
4266 2014-02-26  Manuel Rego Casasnovas  <rego@igalia.com>
4267
4268         [GTK] Re-enable gtk-doc in EWS
4269         https://bugs.webkit.org/show_bug.cgi?id=128369
4270
4271         Reviewed by Carlos Garcia Campos.
4272
4273         Enable again gtk-doc generation in EWS once bug #128417 has been fixed.
4274
4275         * Scripts/webkitpy/common/config/ports.py:
4276         (GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
4277         (GtkWK2Port.build_webkit_command): Ditto.
4278         * Scripts/webkitpy/common/config/ports_unittest.py:
4279         (DeprecatedPortTest.test_gtk_port): Ditto.
4280         (DeprecatedPortTest.test_gtk_wk2_port): Ditto.
4281
4282 2014-02-26  Martin Robinson  <mrobinson@igalia.com>
4283
4284         [GTK] generate-gtkdoc can fail with WebKit1 or WebKit2 only builds
4285         https://bugs.webkit.org/show_bug.cgi?id=129319
4286
4287         Reviewed by Carlos Garcia Campos.
4288
4289         * gtk/generate-gtkdoc:
4290         (get_generator_for_config): Properly handle the situation where the pkgconfig file is missing.
4291
4292 2014-02-25  Mihai Maerean  <mmaerean@adobe.com>
4293
4294         Unreviewed. Add myself as a committer.
4295
4296         * Scripts/webkitpy/common/config/contributors.json:
4297
4298 2014-02-25  Sergio Villar Senin  <svillar@igalia.com>
4299
4300         [CSS Grid Layout] Add ENABLE flag
4301         https://bugs.webkit.org/show_bug.cgi?id=129153
4302
4303         Reviewed by Simon Fraser.
4304
4305         Added ENABLE_CSS_GRID_LAYOUT feature flag. It's on by default for
4306         all ports for developer builds.
4307
4308         * Scripts/webkitperl/FeatureList.pm:
4309
4310 2014-02-25  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
4311
4312         Added myself as a committer.
4313
4314         Unreviewed.
4315
4316         * Scripts/webkitpy/common/config/contributors.json:
4317
4318 2014-02-25  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
4319
4320         Unreviewed. Moved myself to the list of committers.
4321
4322         * Scripts/webkitpy/common/config/contributors.json:
4323
4324 2014-02-25  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
4325
4326         Move myself to the committers list.
4327
4328         Unreviewed.
4329
4330         * Scripts/webkitpy/common/config/contributors.json:
4331
4332 2014-02-25  László Langó  <llango.u-szeged@partner.samsung.com>
4333
4334         Unreviewed. Add myself as a committer.
4335
4336         * Scripts/webkitpy/common/config/contributors.json:
4337
4338 2014-02-25  Commit Queue  <commit-queue@webkit.org>
4339
4340         Unreviewed, rolling out r164639.
4341         http://trac.webkit.org/changeset/164639
4342         https://bugs.webkit.org/show_bug.cgi?id=129302
4343
4344         gtk-doc still have problems in EWS (Requested by rego on
4345         #webkit).
4346
4347         * Scripts/webkitpy/common/config/ports.py:
4348         (GtkPort.build_webkit_command):
4349         (GtkWK2Port.build_webkit_command):
4350         * Scripts/webkitpy/common/config/ports_unittest.py:
4351         (DeprecatedPortTest.test_gtk_port):
4352         (DeprecatedPortTest.test_gtk_wk2_port):
4353
4354 2014-02-25  Manuel Rego Casasnovas  <rego@igalia.com>
4355
4356         [GTK] Re-enable gtk-doc in EWS
4357         https://bugs.webkit.org/show_bug.cgi?id=128369