Fix EFL jhbuild module build on Ubuntu 15.10
[WebKit-https.git] / Tools / ChangeLog
1 2015-11-02  Csaba Osztrogonác  <ossy@webkit.org>
2
3         Fix EFL jhbuild module build on Ubuntu 15.10
4         https://bugs.webkit.org/show_bug.cgi?id=150621
5
6         Reviewed by Gyuyoung Kim.
7
8         * efl/jhbuild.modules:
9         * efl/patches/efl-remove-XPrint.patch: Added.
10
11 2015-11-02  Carlos Garcia Campos  <cgarcia@igalia.com>
12
13         [GLIB] Remove delete on destroy GMainLoopSources
14         https://bugs.webkit.org/show_bug.cgi?id=150771
15
16         Reviewed by Žan Doberšek.
17
18         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp:
19         (TestWebKitAPI::TEST): Remove DeleteOnDestroy unit tests.
20         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
21         (WebViewTest::wait): Use g_timeout_add instead of GMainLoopSource.
22
23 2015-11-01  Yusuke Suzuki  <utatane.tea@gmail.com>
24
25         [ES6] Support Generator Syntax
26         https://bugs.webkit.org/show_bug.cgi?id=150769
27
28         Reviewed by Geoffrey Garen.
29
30         Added ENABLE_ES6_GENERATORS flag.
31
32         * Scripts/webkitperl/FeatureList.pm:
33
34 2015-11-01  Alexey Proskuryakov  <ap@apple.com>
35
36         Sort EWS bots in popovers
37         https://bugs.webkit.org/show_bug.cgi?id=150782
38
39         Reviewed by Darin Adler.
40
41         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js:
42         (BubbleQueueView.prototype._popoverContentForBubbleQueue):
43
44 2015-10-31  Filip Pizlo  <fpizlo@apple.com>
45
46         B3::reduceStrength's DCE should be more agro and less wrong
47         https://bugs.webkit.org/show_bug.cgi?id=150748
48
49         Reviewed by Geoffrey Garen.
50
51         Add an LLVM version of testb3's "testComplex".
52
53         * ReducedFTL/ComplexTest.cpp: Added.
54
55 2015-11-01  Commit Queue  <commit-queue@webkit.org>
56
57         Unreviewed, rolling out r191831.
58         https://bugs.webkit.org/show_bug.cgi?id=150774
59
60         The new test fails (Requested by ap on #webkit).
61
62         Reverted changeset:
63
64         "Begin work on supporting reply blocks in
65         _WKRemoteObjectRegistry"
66         https://bugs.webkit.org/show_bug.cgi?id=150739
67         http://trac.webkit.org/changeset/191831
68
69 2015-10-31  Andreas Kling  <akling@apple.com>
70
71         Add a debug overlay with information about web process resource usage.
72         <https://webkit.org/b/150599>
73
74         Reviewed by Darin Adler.
75
76         Add a menu item to the MiniBrowser so we can toggle the resource usage overlay on/off.
77
78         * MiniBrowser/mac/SettingsController.h:
79         * MiniBrowser/mac/SettingsController.m:
80         (-[SettingsController _populateMenu]):
81         (-[SettingsController validateMenuItem:]):
82         (-[SettingsController toggleShowResourceUsageOverlay:]):
83         (-[SettingsController resourceUsageOverlayVisible]):
84         * MiniBrowser/mac/WK2BrowserWindowController.m:
85         (-[WK2BrowserWindowController didChangeSettings]):
86
87 2015-10-31  Lucas Forschler  <lforschler@apple.com>
88
89         Teach the CompileWebKit step to look for additional arguments.
90         
91         Unreviewed config change.
92
93         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
94         (CompileWebKit.start):
95
96 2015-10-30  Anders Carlsson  <andersca@apple.com>
97
98         Begin work on supporting reply blocks in _WKRemoteObjectRegistry
99         https://bugs.webkit.org/show_bug.cgi?id=150739
100
101         Reviewed by Tim Horton.
102
103         Add a test. We only test the encoding right now.
104
105         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
106         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
107         (TEST):
108         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
109         (-[RemoteObjectRegistryPlugIn sayHello:completionHandler:]):
110
111 2015-10-30  Lucas Forschler  <lforschler@apple.com>
112
113         Add CMAke builder to build.webkit.org
114         https://bugs.webkit.org/show_bug.cgi?id=150738
115         
116         Reviewed by Alex Christensen.
117
118         * BuildSlaveSupport/build.webkit.org-config/config.json:
119
120 2015-10-30  Brent Fulgham  <bfulgham@apple.com>
121
122         [Win] build-jsc and run-javascriptcore-tests do not work
123         https://bugs.webkit.org/show_bug.cgi?id=150700
124
125         Reviewed by Mark Lam.
126         
127         Correct our build system so that it expects Windows to be using CMake,
128         and to build the correct sub-projects for our JSC helper scripts.
129
130         * Scripts/build-jsc: Make sure to build the testapi harness when
131           building for Windows.
132         * Scripts/build-webkit:
133           (1) Use the existing 'cmakeBasedPortName()'
134           (2) Use File::Spec rather than hard-coding path delimeters.
135           (3) Refer to Visual Studio 14.0, rather than the unsupported 12.0.
136         method rather than hard-coding the name based on conditional.
137         * Scripts/copy-webkitlibraries-to-product-directory: Don't try to grab
138           LLVM libraries on Apple Windows build.
139         * Scripts/run-javascriptcore-tests:
140         (testapiPath): Use File::Spec rather than hard-coding path delimeters.
141         * Scripts/run-jsc: Ditto.
142         * Scripts/webkitdirs.pm:
143         (cmakeBasedPortName): Update to return the right value for the Apple
144         Windows port and the WinCairo port.
145         (isCMakeBuild): Expect CMake build for all Windows ports.
146
147 2015-10-30  Carlos Garcia Campos  <cgarcia@igalia.com>
148
149         [JHBuild] Do not try to update the dependencies if jhbuild configuration hasn't changed
150         https://bugs.webkit.org/show_bug.cgi?id=150665
151
152         Reviewed by Csaba Osztrogonác.
153
154         We check it only to wipe the directory or not, but we are still
155         tryihng to update every module even when the configuration hasn't
156         changed. This is problematic because it makes the whole build fail
157         when any repository fails to checkout an already checked out
158         revision, because the server is down for example. This is even
159         more problematic for the bots that skip perfectly valid revisions.
160         It's still possible to force an update passing --force command
161         line argument.
162
163         * Scripts/update-webkit-libs-jhbuild:
164         (deleteJhbuildMd5): Delete the md5sum files if exist.
165         (runJhbuild): Return early if the md5sum files haven't
166         changed. Only write them after a successful build and delete them
167         if the build fails to ensure we don't skip next run.
168
169 2015-10-30  Philippe Normand  <pnormand@igalia.com>
170
171         [GTK] Fix MacCLang build errors in Tools
172         https://bugs.webkit.org/show_bug.cgi?id=150031
173
174         Reviewed by Carlos Garcia Campos.
175
176         * TestWebKitAPI/PlatformWebView.h: Fix PlatformWindow typedef on OSX flavor of the GTK port.
177         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp: Include WKView.h for WKViewCreate().
178         * WebKitTestRunner/PlatformWebView.h: Fix PlatformWindow typedef on OSX flavor of the GTK port.
179         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Include WKView.h for WKViewCreate().
180
181 2015-10-29  Hunseop Jeong  <hs85.jeong@samsung.com>
182
183         [EFL] MiniBrowser didn't work after r191749.
184         https://bugs.webkit.org/show_bug.cgi?id=150706
185
186         Reviewed by Alex Christensen.
187
188         Renamed jhbuildWrapperPrefixIfNeeded to wrapperPrefixIfNeeded in r191749.
189
190         * Scripts/run-minibrowser:
191
192 2015-10-29  Commit Queue  <commit-queue@webkit.org>
193
194         Unreviewed, rolling out r191766.
195         https://bugs.webkit.org/show_bug.cgi?id=150707
196
197         Problem with Cygwin build (Requested by bfulgham_ on #webkit).
198
199         Reverted changeset:
200
201         "[Win] build-jsc and run-javascriptcore-tests do not work"
202         https://bugs.webkit.org/show_bug.cgi?id=150700
203         http://trac.webkit.org/changeset/191766
204
205 2015-10-29  Brent Fulgham  <bfulgham@apple.com>
206
207         [Win] build-jsc and run-javascriptcore-tests do not work
208         https://bugs.webkit.org/show_bug.cgi?id=150700
209
210         Reviewed by Mark Lam.
211         
212         Correct our build system so that it expects Windows to be using CMake,
213         and to build the correct sub-projects for our JSC helper scripts.
214
215         * Scripts/build-jsc: Make sure to build the testapi harness when
216           building for Windows.
217         * Scripts/build-webkit:
218           (1) Use the existing 'cmakeBasedPortName()'
219           (2) Use File::Spec rather than hard-coding path delimeters.
220           (3) Refer to Visual Studio 14.0, rather than the unsupported 12.0.
221         method rather than hard-coding the name based on conditional.
222         * Scripts/run-javascriptcore-tests:
223         (testapiPath): Use File::Spec rather than hard-coding path delimeters.
224         * Scripts/run-jsc: Ditto.
225         * Scripts/webkitdirs.pm:
226         (cmakeBasedPortName): Update to return the right value for the Apple
227         Windows port and the WinCairo port.
228         (isCMakeBuild): Expect CMake build for all Windows ports.
229
230 2015-10-29  Alex Christensen  <achristensen@webkit.org>
231
232         Fix build-jsc on Mac after r191749.
233
234         * Scripts/build-jsc:
235         Use isCMakeBuild to determine if we are building with CMake instead of cmakeBasedPortName.
236
237 2015-10-29  Alex Christensen  <achristensen@webkit.org>
238
239         Fix Mac CMake build
240         https://bugs.webkit.org/show_bug.cgi?id=150686
241
242         Reviewed by Filip Pizlo.
243
244         * Scripts/build-webkit:
245         * Scripts/webkitdirs.pm:
246         (isCachedArgumentfileOutOfDate):
247         (wrapperPrefixIfNeeded):
248         (generateBuildSystemFromCMakeProject):
249         (buildCMakeGeneratedProject):
250         (cmakeBasedPortName):
251         (determineIsCMakeBuild):
252         (isCMakeBuild):
253         (promptUser):
254         (jhbuildWrapperPrefixIfNeeded): Deleted.
255
256 2015-10-29  Lucas Forschler  <lforschler@apple.com>
257
258         Teach JSC bots to build 32bit instead of x86_64
259         
260         Reviewed by Mark Lam.
261
262         * BuildSlaveSupport/build.webkit.org-config/config.json:
263
264 2015-10-29  Per Arne Vollan  <peavo@outlook.com>
265
266         [WinCairo] Fall back to AppleWin results in layout tests.
267         https://bugs.webkit.org/show_bug.cgi?id=150672
268
269         Reviewed by Alex Christensen.
270
271         * Scripts/webkitpy/port/win.py:
272         (WinCairoPort):
273         (WinCairoPort.default_baseline_search_path):
274
275 2015-10-28  Keith Rollin  <krollin@apple.com>
276
277         Do not sanitize user input for input[type=url]
278         https://bugs.webkit.org/show_bug.cgi?id=150346
279         <rdar://problem/23243240>
280
281         Reviewed by Brent Fulgham.
282
283         The Windows version of DumpRenderTree's eventSender.keyDown handler
284         simulates user-entry by decomposing the given character into a virtual
285         key code and a set of modifier keys. The code that determines if the
286         shift key should be simulated only worked if the character was an
287         upper case character. Extend this support to also include symbols that
288         (on the U.S. keyboard) require holding down the shift key.
289
290         This change allows fast/forms/input-user-input-sanitization.html
291         to succeed, which requires us to simulate the entering of '@' and ':'.
292
293         * DumpRenderTree/win/EventSender.cpp:
294         (keyDownCallback):
295
296 2015-10-28  Alex Christensen  <achristensen@webkit.org>
297
298         Compile and link with CMake on Mac
299         https://bugs.webkit.org/show_bug.cgi?id=150632
300
301         Reviewed by Tim Horton.
302
303         * TestWebKitAPI/PlatformMac.cmake:
304
305 2015-10-28  Xabier Rodriguez Calvar  <calvaris@igalia.com>
306
307         Unreviewed.
308
309         * Scripts/webkitpy/common/config/watchlist: Removed dead files from Streams API watchlist.
310
311 2015-10-28  Per Arne Vollan  <peavo@outlook.com>
312
313         Add WinCairo to list of ports in run-webkit-tests.
314         https://bugs.webkit.org/show_bug.cgi?id=150625
315
316         Reviewed by Brent Fulgham.
317
318         * Scripts/webkitpy/common/config/ports.py:
319         (DeprecatedPort.port):
320         (WinPort.run_webkit_tests_command):
321         (WinCairoPort):
322         (GtkWK2Port):
323         * Scripts/webkitpy/port/factory.py:
324         (PortFactory):
325         * Scripts/webkitpy/port/win.py:
326         (WinPort.find_system_pid):
327         (WinCairoPort):
328
329 2015-10-27  Alexey Proskuryakov  <ap@apple.com>
330
331         WebKitTestRunner leaks in generateWhitelist()
332         https://bugs.webkit.org/show_bug.cgi?id=150563
333
334         Reviewed by Andreas Kling.
335
336         * WebKitTestRunner/mac/TestControllerMac.mm:
337         (WTR::generateWhitelist):
338
339 2015-10-27  Anders Carlsson  <andersca@apple.com>
340
341         Add an API test for _WKRemoteObjectRegistry
342         https://bugs.webkit.org/show_bug.cgi?id=150597
343
344         Reviewed by Andreas Kling.
345
346         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
347         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Added.
348         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm: Added.
349         (TEST):
350         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm: Added.
351         (-[RemoteObjectRegistryPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
352         (-[RemoteObjectRegistryPlugIn sayHello:]):
353
354 2015-10-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
355
356         Add myself to the reviewers list
357         https://bugs.webkit.org/show_bug.cgi?id=150581
358
359         Unreviewed.
360
361         * Scripts/webkitpy/common/config/contributors.json:
362
363 2015-10-26  Ryan Haddad  <ryanhaddad@apple.com>
364
365         Adding myself to contributors.json
366
367         * Scripts/webkitpy/common/config/contributors.json:
368
369 2015-10-26  Tim Horton  <timothy_horton@apple.com>
370
371         Don't expose the whitelist/blacklist in _WKUserStyleSheet
372         https://bugs.webkit.org/show_bug.cgi?id=150566
373
374         Reviewed by Anders Carlsson.
375
376         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
377         (TEST):
378
379 2015-10-26  Philippe Normand  <pnormand@igalia.com>
380
381         Unreviewed, rolling out r191576.
382
383         broke
384
385         Reverted changeset:
386
387         "[GStreamer] Bump internal jhbuild versions to 1.6.0"
388         https://bugs.webkit.org/show_bug.cgi?id=149594
389         http://trac.webkit.org/changeset/191576
390
391 2015-10-26  ChangSeok Oh  <changseok.oh@collabora.com>
392
393         [GStreamer] Bump internal jhbuild versions to 1.6.0
394         https://bugs.webkit.org/show_bug.cgi?id=149594
395
396         Reviewed by Philippe Normand.
397
398         Bump up whole gstreamer libraries to 1.6.0. Relevant patches are no more
399         useful so they are removed accordingly.
400
401         * gtk/jhbuild.modules:
402         * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Removed.
403         * gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Removed.
404         * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
405
406 2015-10-25  Alexey Proskuryakov  <ap@apple.com>
407
408         API tests fail on El Capitan after r191543
409         https://bugs.webkit.org/show_bug.cgi?id=150547
410
411         Reviewed by Dan Bernstein.
412
413         * Scripts/run-api-tests: (listAllTests): Add appropriate arch arguments in one more place.
414
415 2015-10-24  Tim Horton  <timothy_horton@apple.com>
416
417         Add a way to add user style sheets to WKUserContentController
418         https://bugs.webkit.org/show_bug.cgi?id=150531
419         <rdar://problem/23191691>
420
421         Reviewed by Darin Adler.
422
423         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
424         (TEST):
425
426 2015-10-24  Tim Horton  <timothy_horton@apple.com>
427
428         Expose more information about the exception in WKErrorJavaScriptExceptionOccurred errors
429         https://bugs.webkit.org/show_bug.cgi?id=150525
430
431         Reviewed by Darin Adler.
432
433         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
434         (TEST):
435         Test the various new keys.
436
437 2015-10-24  Frederic Wang  <fred.wang@free.fr>
438
439         check-webkit-style complains about missing operator whitespace inside character literal
440         https://bugs.webkit.org/show_bug.cgi?id=150396
441
442         Reviewed by Darin Adler.
443
444         * Scripts/webkitpy/style/checkers/cpp.py: Improve matching of C++ character literal.
445         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
446         (WebKitStyleTest.test_spacing): Add a test to verify that the spacing for the character literal 'OS/2' is not tested.
447
448 2015-10-23  Michael Saboff  <msaboff@apple.com>
449
450         REGRESSION (r179357-r179359): WebContent Crash using AOL Mail @ com.apple.JavascriptCore JSC::linkPolymorphicCall(JSC::ExecState*, JSC::CallLinkInfo&, JSC::CallVariant, JSC::RegisterPreservationMode) + 1584
451         https://bugs.webkit.org/show_bug.cgi?id=150513
452
453         Reviewed by Saam Barati.
454
455         Added a new test function, failNextNewCodeBlock() to simplify the writing of a regression test.
456
457         * DumpRenderTree/TestRunner.cpp:
458         (simulateWebNotificationClickCallback):
459         (failNextCodeBlock):
460         (numberOfDFGCompiles):
461         (TestRunner::staticFunctions):
462         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
463         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
464         (WTR::TestRunner::setBlockAllPlugins):
465         (WTR::TestRunner::failNextCodeBlock):
466         (WTR::TestRunner::numberOfDFGCompiles):
467         * WebKitTestRunner/InjectedBundle/TestRunner.h:
468
469 2015-10-23  Anders Carlsson  <andersca@apple.com>
470
471         Simplify the WebKitLegacy menu conversion code
472         https://bugs.webkit.org/show_bug.cgi?id=150509
473
474         Reviewed by Andreas Kling.
475
476         Implement the context menu delegate method so we'll test that code path.
477
478         * MiniBrowser/mac/WK1BrowserWindowController.m:
479         (-[WK1BrowserWindowController webView:contextMenuItemsForElement:defaultMenuItems:]):
480
481 2015-10-23  Per Arne Vollan  <peavo@outlook.com>
482
483         [WinCairo] Improve test results for fast layouttests.
484         https://bugs.webkit.org/show_bug.cgi?id=150464
485
486         Reviewed by Alex Christensen.
487
488         Set custom device scale factor to 1.0.
489
490         * DumpRenderTree/win/DumpRenderTree.cpp:
491         (createWebViewAndOffscreenWindow):
492
493 2015-10-23  Mark Salisbury  <mark.salisbury@hp.com>
494
495         [GTK] update-webkitgtk-libs should use mesa tarball
496
497         https://bugs.webkit.org/show_bug.cgi?id=150470
498
499         update-webkitgtk-libs downloads all build dependencies; in fixing
500         bug 148941 mesa was switched from ftp to git access.  Now an http
501         tarball is available, which is preferred over accessing via git.
502
503         Reviewed by Philippe Normand
504
505         * gtk/jhbuild.modules:
506         Mesa access changed to http tarball.
507
508 2015-10-22  Sam Weinig  <sam@webkit.org>
509
510         Navigations on the same host (but with different schemes and ports) should not trigger universal links
511         <rdar://problem/22811325>
512         https://bugs.webkit.org/show_bug.cgi?id=150481
513
514         Reviewed by Dan Bernstein.
515
516         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
517         Update test to test that navigations on the same host but with different schemes does not
518         trigger universal links, but that changes in the host do.
519
520 2015-10-22  Ryosuke Niwa  <rniwa@webkit.org>
521
522         REGRESSION (r181972): Scroll position changes to top of youtube page when switching tabs
523         https://bugs.webkit.org/show_bug.cgi?id=150428
524
525         Reviewed by Antti Koivisto.
526
527         Added a regression test using WebKit API test.
528
529         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
530         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm: Added.
531         (TestWebKitAPI::didFinishLoadForFrame):
532         (TestWebKitAPI::TEST):
533
534 2015-10-22  Carlos Garcia Campos  <cgarcia@igalia.com>
535
536         Unreviewed. Fix GTK+ build after r191423.
537
538         Add WebKitDOMHTMLBaseFontElement to the list of deleted classes.
539
540         * gtk/webkitdom.py:
541         (WebKitDOMDocGenerator):
542
543 2015-10-22  Aakash Jain  <aakash_jain@apple.com>
544
545         [Win][EFL][GTK] webkitpy test failed after r191374.
546         https://bugs.webkit.org/show_bug.cgi?id=150433
547
548         Reviewed by Alexey Proskuryakov.
549
550         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
551         (CrashLogsTest.test_find_all_log_darwin): Check platform before running test.
552         (CrashLogsTest.test_find_log_darwin): Same.
553
554 2015-10-21  Brian Burg  <bburg@apple.com>
555
556         Unreviewed, update watchlist for JS builtins.
557
558         Add a category for JS builtins code generator, similar to other generators.
559
560         Add a nag message to rebaseline builtins generator tests when touching
561         code generator files in Source/JavaScriptCore/Scripts/builtins/.
562
563         * Scripts/webkitpy/common/config/watchlist:
564
565 2015-10-21  Brian Burg  <bburg@apple.com>
566
567         Restructure generate-js-bindings script to be modular and testable
568         https://bugs.webkit.org/show_bug.cgi?id=149929
569
570         Reviewed by Alex Christensen.
571
572         Add a stub shell script and basic webkitpy support for running builtins
573         generator tests.
574
575         * Scripts/run-builtins-generator-tests: Added.
576         (main):
577         * Scripts/webkitpy/codegen/__init__.py: Added.
578         * Scripts/webkitpy/codegen/main.py: Added.
579
580             The only interesting difference here from the inspector protocol
581             generator equivalent is that this implementation decodes the target
582             framework and output mode (combined or separate) from the test's file name.
583
584         (BuiltinsGeneratorTests):
585         (BuiltinsGeneratorTests.__init__):
586         (BuiltinsGeneratorTests.generate_from_js_builtins):
587         (BuiltinsGeneratorTests.write_error_file):
588         (BuiltinsGeneratorTests.detect_changes):
589         (BuiltinsGeneratorTests.run_tests):
590         (BuiltinsGeneratorTests.main):
591
592 2015-10-21  Aakash Jain  <aakash_jain@apple.com>
593
594         run-webkit-tests does not copy all crash logs for layout test failures on Mac
595         https://bugs.webkit.org/show_bug.cgi?id=150407
596         <rdar://problem/22239750>
597
598         Reviewed by Alexey Proskuryakov.
599
600         * Scripts/webkitpy/port/mac.py:
601         (MacPort._merge_crash_logs): Merge unique crash logs from two dictionaries.
602         (MacPort._look_for_all_crash_logs_in_log_dir): Get the crash logs from
603         the log directory.
604         (MacPort.look_for_new_crash_logs): Uses above method to get crash logs
605         from log directory and merge them with the list of already crashed tests.
606
607 2015-10-21  Filip Pizlo  <fpizlo@apple.com>
608
609         Failures in PutStackSinkingPhase should be less severe
610         https://bugs.webkit.org/show_bug.cgi?id=150400
611
612         Reviewed by Geoffrey Garen.
613
614         Add a test mode for no PutStackSinkingPhase.
615
616         * Scripts/run-jsc-stress-tests:
617
618 2015-10-21  Nan Wang  <n_wang@apple.com>
619
620         AX: Expose table size and cell indexes on iOS
621         https://bugs.webkit.org/show_bug.cgi?id=150366
622
623         Reviewed by Chris Fleizach.
624
625         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
626         (AccessibilityUIElement::rowCount):
627         (AccessibilityUIElement::columnCount):
628         (AccessibilityUIElement::indexInTable):
629         (AccessibilityUIElement::numberAttributeValue):
630         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
631         (WTR::AccessibilityUIElement::numberAttributeValue):
632         (WTR::AccessibilityUIElement::rowCount):
633         (WTR::AccessibilityUIElement::columnCount):
634         (WTR::AccessibilityUIElement::indexInTable):
635
636 2015-10-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
637
638         W3C test importer should not import reference files as regular tests
639         https://bugs.webkit.org/show_bug.cgi?id=150331
640
641         Reviewed by Darin Adler.
642
643         Updated test_parser to return information that a file can be a referencefile or a manual test.
644         Updated test importer to skip those files.
645         Updated/Added test parser unit tests accordingly.
646
647         Updated test importer to import all not-test files, as they are usually used by tests and lead to test failing or timing out.
648         Updated test importer to log these 'resource' files that are not in a resources folder, and suggest to import script user
649         to mark these files as Skip, since they are not direct tests. 
650
651         * Scripts/webkitpy/w3c/test_importer.py:
652         (TestImporter.__init__):
653         (TestImporter.find_importable_tests):
654         (TestImporter.import_tests):
655         * Scripts/webkitpy/w3c/test_parser.py:
656         (TestParser.analyze_test):
657         * Scripts/webkitpy/w3c/test_parser_unittest.py:
658         (test_analyze_non_html_file):
659         (test_reference_test):
660
661 2015-10-20  Aakash Jain  <aakash_jain@apple.com>
662
663         run-webkit-tests does not copy all crash logs for layout test failures on iOS
664         https://bugs.webkit.org/show_bug.cgi?id=150056
665         <rdar://problem/9280656>
666
667         Reviewed by Alexey Proskuryakov.
668
669         * Scripts/webkitpy/common/system/crashlogs.py:
670         (CrashLogs.find_all_logs): Generic method to find all crash logs.
671         (CrashLogs._find_all_logs_darwin): Darwin based method to find all crash logs.
672         It iterates through log directory and returns all the logs based on timestamp.
673         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
674         (CrashLogsTest.create_crash_logs_darwin): Creates sample crash logs and verify them.
675         (CrashLogsTest.test_find_all_log_darwin): Testcase for above find_all_logs method
676         (CrashLogsTest.test_find_log_darwin): Restructured to share code with other methods.
677         * Scripts/webkitpy/layout_tests/controllers/manager.py:
678         (Manager.run): Modified start_time to start counting before simulator launch
679         so that we can capture crashes during simualator launch.
680         (Manager._look_for_new_crash_logs): Browse through list of crashes and append
681         any test which is not already marked as CRASH to the run_results.
682         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
683         (TestExpectationsModel.get_expectations_string): return PASS in case there
684         are no expectations defined for this test.
685         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
686         (summarize_results): Add other_crashes in a separte category in full_results.json.
687         * Scripts/webkitpy/port/ios.py:
688         (IOSSimulatorPort._merge_crash_logs): Merge unique crash logs from two dictionaries.
689         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Get the crash logs
690         from the log directory.
691         (IOSSimulatorPort.look_for_new_crash_logs): Uses above method to get crash
692         logs from log directory and merge them with the list of already crashed tests.
693
694 2015-10-20  Dana Burkart  <dburkart@apple.com>
695
696         Fix the build
697
698         Unreviewed.
699
700         My previous patch was missing a necessary space character.
701
702         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
703
704 2015-10-20  Dana Burkart  <dburkart@apple.com>
705
706         svn-apply fails to apply binary diffs in some cases
707         https://bugs.webkit.org/show_bug.cgi?id=64647
708
709         Reviewed by Daniel Bates.
710
711         * Scripts/VCSUtils.pm:
712         (decodeGitBinaryPatchDeltaSize): Modified.
713         We need to handle the case where the binary diff is the last in the patch; so we match on "-- \n" or "\Z".
714         * Tools/Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl: Added.
715
716 2015-10-20  Alexey Proskuryakov  <ap@apple.com>
717
718         Mac Debug EWS never finishes when there are failures
719         https://bugs.webkit.org/show_bug.cgi?id=150334
720
721         Reviewed by Daniel Bates.
722
723         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
724         * Scripts/webkitpy/tool/commands/queues.py:
725
726 2015-10-20  Philippe Normand  <pnormand@igalia.com>
727
728         [GTK] Enable OpenWebRTC test video/audio sources in tests
729
730         This is needed because we can't expect the buildbots to have
731         webcam/mic devices plugged in.
732
733         Rubber-stamped by Carlos Garcia Campos.
734
735         * Scripts/run-gtk-tests:
736         (TestRunner._setup_testing_environment):
737         * Scripts/webkitpy/port/gtk.py:
738         (GtkPort.setup_environ_for_server):
739
740 2015-10-20  Yoav Weiss  <yoav@yoav.ws>
741
742         Rename the PICTURE_SIZES flag to CURRENTSRC
743         https://bugs.webkit.org/show_bug.cgi?id=150275
744
745         Reviewed by Dean Jackson.
746
747         * Scripts/webkitperl/FeatureList.pm:
748
749 2015-10-19  Hunseop Jeong  <hs85.jeong@samsung.com>
750
751         Unreviewed, add myself to the committers list.
752
753         * Scripts/webkitpy/common/config/contributors.json:
754
755 2015-10-19  Alexey Proskuryakov  <ap@apple.com>
756
757         Add new EWS queues to bot watcher's dashboard
758         https://bugs.webkit.org/show_bug.cgi?id=150297
759
760         Reviewed by Darin Adler.
761
762         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
763         (BubbleQueueServer):
764
765 2015-10-19  ChangSeok Oh  <changseok.oh@collabora.com>
766
767         REGRESSION(r190262): User media unit test failures after r190262
768         https://bugs.webkit.org/show_bug.cgi?id=149580
769
770         Reviewed by Carlos Garcia Campos.
771
772         The test failures on usermedia-permission-requests and WebKit2.UserMediaBasic have gone.
773         So we do not need to skip them anymore.
774
775         * Scripts/run-gtk-tests:
776         (TestRunner): Deleted.
777
778 2015-10-19  Csaba Osztrogonác  <ossy@webkit.org>
779
780         Add historical addresses to contributors.json
781         https://bugs.webkit.org/show_bug.cgi?id=150227
782
783         Reviewed by Darin Adler.
784
785         * Scripts/webkitpy/common/config/contributors.json:
786
787 2015-10-18  Sungmann Cho  <sungmann.cho@navercorp.com>
788
789         [Win] Change the DLL name in MiniBrowserLib.vcxproj to match webkit.org/b/150124.
790         https://bugs.webkit.org/show_bug.cgi?id=150307
791
792         Reviewed by Brent Fulgham.
793
794         The DLL build rules have been changed to generate "{Name}Lib.DLL",
795         but these changes have not yet been applied to the Visual Studio builds.
796
797         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj:
798
799 2015-10-16  Andreas Kling  <akling@apple.com>
800
801         [EFL, AppleWin] WTF.ConcatenateCharacterArrayAndEmptyString API test failed
802         <https://webkit.org/b/150153>
803
804         Unreviewed.
805
806         Just use simple arrays of LChar and UChar for this test instead of creating String
807         objects and then getting the characters8()/characters16() from them, since that
808         doesn't guarantee null-termination (the bug.)
809
810         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
811         (TestWebKitAPI::TEST):
812         (TestWebKitAPI::build): Deleted.
813
814 2015-10-16  Tim Horton  <timothy_horton@apple.com>
815
816         WebKit2.AutoLayoutIntegration API test is failing on some of the bots
817         https://bugs.webkit.org/show_bug.cgi?id=150255
818
819         Reviewed by Simon Fraser.
820
821         * Scripts/run-api-tests:
822         (runTest):
823         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
824         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:]):
825         (-[AutoLayoutWKWebView layoutAtMinimumWidth:andExpectContentSizeChange:]):
826         (-[AutoLayoutWKWebView load:expectingContentSize:]): Deleted.
827         (-[AutoLayoutWKWebView expectContentSizeChange:]): Deleted.
828         Don't set the layout size until after the load finishes and we're waiting
829         for the reply, so that there is no race between the new size coming in
830         and us waiting for it.
831
832 2015-10-16  Anders Carlsson  <andersca@apple.com>
833
834         WebEditingDelegate should be a formal protocol
835         https://bugs.webkit.org/show_bug.cgi?id=150254
836         <rdar://problem/23149847>
837
838         Reviewed by Dan Bernstein.
839
840         * DumpRenderTree/mac/EditingDelegate.h:
841         Conform to the WebEditingDelegate protocol.
842
843 2015-10-16  Tim Horton  <timothy_horton@apple.com>
844
845         Hook up autolayout intrinsic sizing for WKWebView
846         https://bugs.webkit.org/show_bug.cgi?id=150219
847         <rdar://problem/20016905>
848
849         Reviewed by Simon Fraser.
850
851         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
852         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm: Added.
853         (-[AutoLayoutNavigationDelegate webView:didFinishNavigation:]):
854         (-[AutoLayoutWKWebView load:expectingContentSize:]):
855         (-[AutoLayoutWKWebView expectContentSizeChange:]):
856         (-[AutoLayoutWKWebView invalidateIntrinsicContentSize]):
857         (TEST):
858         Add a variety of tests, including one which catches the bug that
859         the WebCore part of this patch fixes.
860
861 2015-10-15  Csaba Osztrogonác  <ossy@webkit.org>
862
863         Update the help message of --system-malloc
864         https://bugs.webkit.org/show_bug.cgi?id=150169
865
866         Reviewed by Geoffrey Garen.
867
868         * Scripts/webkitperl/FeatureList.pm:
869
870 2015-10-15  Youenn Fablet  <youenn.fablet@crf.canon.fr>
871
872         Update ImportExpectations according currently imported wpt tests
873         https://bugs.webkit.org/show_bug.cgi?id=150158
874
875         Reviewed by Chris Dumez.
876
877         * Scripts/webkitpy/w3c/test_downloader.py:
878         (TestDownloader.copy_tests): ensuring that directories marked as [ Skip ] are not copied.
879
880 2015-10-15  Eunmi Lee  <eunmi15.lee@samsung.com>
881
882         Unreviewed, Update my email address.
883
884         * Scripts/webkitpy/common/config/contributors.json:
885
886 2015-10-15  Carlos Garcia Campos  <cgarcia@igalia.com>
887
888         [GTK] Test WebKit2.RestoreSessionStateContainingFormData fails
889         https://bugs.webkit.org/show_bug.cgi?id=84960
890
891         Reviewed by Žan Doberšek.
892
893         * Scripts/run-gtk-tests:
894         (TestRunner): Unskip tests using SessionState.
895         * TestWebKitAPI/PlatformGTK.cmake: Add
896         WKPageCopySessionStateWithFiltering test.
897
898 2015-10-14  Carlos Garcia Campos  <cgarcia@igalia.com>
899
900         [GTK] Missing return value on TestWebExtensions.cpp:193
901         https://bugs.webkit.org/show_bug.cgi?id=149755
902
903         Unreviewed. Add missing return value.
904
905         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
906         (permissionRequestCallback):
907
908 2015-10-14  Andy Estes  <aestes@apple.com>
909
910         [iOS] build-dumprendertree does not build ImageDiff
911         https://bugs.webkit.org/show_bug.cgi?id=150152
912
913         Reviewed by Tim Horton.
914
915         run-webkit-tests attempts to build the tools it requires by calling build-dumprendertree and build-webkittestrunner.
916         On iOS, build-dumprendertree builds the DumpRenderTree.app target, which does not contain the ImageDiff target
917         as a dependent. If you haven't built ImageDiff by other means (say, because you built the 'All Source' scheme in
918         WebKit.xcworkspace), tests that rely on image diffing won't work properly.
919
920         There's actually no reason to build the DumpRenderTree.app target on iOS; the default aggregate target works
921         fine on that platform, and results in ImageDiff being built.
922
923         * Scripts/build-dumprendertree:
924
925 2015-10-14  Brent Fulgham  <bfulgham@apple.com>
926
927         [Win] Enforce launcher/library naming scheme
928         https://bugs.webkit.org/show_bug.cgi?id=150124
929
930         Reviewed by Alex Christensen.
931
932         * DumpRenderTree/PlatformWin.cmake: Use 'Lib' suffix for DLLs.
933         * MiniBrowser/win/CMakeLists.txt: Ditto.
934         * TestWebKitAPI/PlatformWin.cmake: Ditto.
935         * win/DLLLauncher/DLLLauncherMain.cpp:
936         (wWinMain): Look for a DLL named {name}Lib.dll, rather than the
937         original {name}.dll.
938
939 2015-10-14  Andreas Kling  <akling@apple.com>
940
941         REGRESSION(r190882): Concatenating a character array and an empty string is broken.
942         <https://webkit.org/b/150135>
943
944         Reviewed by Geoffrey Garen.
945
946         Add a new WTF API test that covers this issue.
947
948         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
949         (TestWebKitAPI::build):
950         (TestWebKitAPI::TEST):
951
952 2015-10-14  Alex Christensen  <achristensen@webkit.org>
953
954         Add SPI for reloading without content blockers
955         https://bugs.webkit.org/show_bug.cgi?id=150058
956         rdar://problem/22742222
957
958         Reviewed by Sam Weinig.
959
960         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
961         (WTR::TestController::cocoaResetStateToConsistentValues):
962         * WebKitTestRunner/mac/TestControllerMac.mm:
963         (WTR::TestController::platformConfigureViewForTest):
964
965 2015-10-14  Mark Lam  <mark.lam@apple.com>
966
967         Rename some JSC option names to be more uniform.
968         https://bugs.webkit.org/show_bug.cgi?id=150127
969
970         Reviewed by Geoffrey Garen.
971
972         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
973         * Scripts/run-jsc-stress-tests:
974
975 2015-10-14  Anders Carlsson  <andersca@apple.com>
976
977         Change the bundle app cache APIs to take a page
978         https://bugs.webkit.org/show_bug.cgi?id=150123
979
980         Reviewed by Sam Weinig.
981
982         Update APIs.
983
984         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
985         (WTR::InjectedBundle::beginTesting):
986         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
987         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
988         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
989         (WTR::TestRunner::clearAllApplicationCaches):
990         (WTR::TestRunner::clearApplicationCacheForOrigin):
991         (WTR::TestRunner::setAppCacheMaximumSize):
992         (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
993         (WTR::TestRunner::originsWithApplicationCache):
994
995 2015-10-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
996
997         Update web-platform-tests tools to the latest revision
998         https://bugs.webkit.org/show_bug.cgi?id=149645
999
1000         Reviewed by Darin Adler.
1001
1002         Disabling git submodules information conversion to json install file for web-platform-tests.
1003         Disabling related python unit tests.
1004         The tools submodules contain submodules and the conversion tool does not support that yet.
1005
1006         Updating wpt launcher script to aling it with web-platform-test main script.
1007
1008         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1009         (main):
1010         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
1011         (TestWebPlatformTestServer.test_corrupted_subserver_files): Deleted.
1012         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1013         (TestImporterTest.test_submodules_generation):
1014
1015 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
1016
1017         More debug queue build fixing.
1018
1019         Preserve the build style in one more place. Changed mock build_style from "both"
1020         to "release", as we don't support testing both debug and release.
1021
1022         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1023         (MockCommitQueue.archive_last_test_results):
1024         (MockCommitQueue):
1025         (MockCommitQueue.build_style):
1026         (MockCommitQueue.did_pass_testing_ews):
1027         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1028         (PatchAnalysisTask._test):
1029         (PatchAnalysisTask._build_and_test_without_patch):
1030         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1031         (EarlyWarningSystemTest._default_expected_logs):
1032         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1033
1034 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
1035
1036         More debug queue build fixing.
1037
1038         Add build_style argument to derived classes as well.
1039
1040         * Scripts/webkitpy/common/config/ports.py:
1041         (MacPort):
1042         (MacPort.run_webkit_tests_command):
1043         (WinPort.run_bindings_tests_command):
1044         (WinPort):
1045         (WinPort.run_webkit_tests_command):
1046         (GtkWK2Port.build_webkit_command):
1047         (GtkWK2Port):
1048         (GtkWK2Port.run_webkit_tests_command):
1049
1050 2015-10-13  Myles C. Maxfield  <mmaxfield@apple.com>
1051
1052         [iOS] Build fix
1053
1054         Unreviewed.
1055
1056         Mach-O section names are limited to 16 characters.
1057
1058         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1059         * DumpRenderTree/mac/DumpRenderTree.mm:
1060         (activateFontsIOS):
1061
1062 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
1063
1064         Build fix for mac-debug EWS queue.
1065
1066         Unreviewed.
1067
1068         Pass --debug to run-webkit-tests.
1069
1070         While at it, removed unsupported run_webkit_unit_tests_command. All the test steps
1071         will need to be substantially modified to work in EWS, so the dummy implementation
1072         was not helpful.
1073
1074         * Scripts/webkitpy/common/config/ports.py:
1075         (DeprecatedPort.run_javascriptcore_tests_command):
1076         (DeprecatedPort):
1077         (DeprecatedPort.run_webkit_tests_command):
1078         (DeprecatedPort.run_python_unittests_command):
1079         (DeprecatedPort.run_webkit_unit_tests_command): Deleted.
1080         * Scripts/webkitpy/common/config/ports_mock.py:
1081         (MockPort.run_javascriptcore_tests_command):
1082         (MockPort):
1083         (MockPort.run_webkit_tests_command):
1084         (MockPort.run_bindings_tests_command):
1085         (MockPort.run_webkit_unit_tests_command): Deleted.
1086         * Scripts/webkitpy/tool/commands/download_unittest.py:
1087         * Scripts/webkitpy/tool/steps/runtests.py:
1088         (RunTests.run):
1089         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1090         (RunTestsTest.test_webkit_run_unit_tests):
1091         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1092         (StepsTest.test_runtests_args):
1093
1094 2015-10-13  Brent Fulgham  <bfulgham@apple.com>
1095
1096         [Win] Generate Crash Traces
1097         https://bugs.webkit.org/show_bug.cgi?id=150103
1098
1099         Reviewed by Daniel Bates.
1100
1101         We were using an exception filter to try to emit "#CRASHED" to stderr
1102         when a test program crashed. However, the modern Python implementation
1103         seems capable of recognizing crashes on its own. Furthermore, registering
1104         the exception handler was preventing the JIT debugger (NTSD) from
1105         automatically attaching to the crashing program, so we were not getting
1106         crash traces.
1107         
1108         * DumpRenderTree/win/DumpRenderTree.cpp:
1109         (main): Don't register an exception filter.
1110         (exceptionFilter): Deleted.
1111         * Scripts/webkitpy/common/system/crashlogs.py:
1112         (CrashLogs): Add another regular expression to handle a second crash trace
1113         syntax I encountered during testing.
1114         (CrashLogs._find_newest_log_win): If the old regular expression doesn't match,
1115         try the new one. The PID found by the new expression is in hexadecimal, so
1116         convert it to an integer before returning it.
1117         * Scripts/webkitpy/port/driver.py:
1118         (Driver._check_for_driver_crash_or_unresponsiveness): Windows was not recognizing
1119         the "#CRASHED" state because it was appending '\r\n', rather than just '\r'. Instead,
1120         check for "#CRASHED" after stripping off the EOL characters.
1121         * Scripts/webkitpy/port/win.py:
1122         (WinPort.setup_crash_log_saving): Put back the '-e %ld' flag in the debugger
1123         invocation. This is apparently used to signal an event when the debugger is finished.
1124
1125 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
1126
1127         Mac Debug and 32-bit queues should be separate
1128         https://bugs.webkit.org/show_bug.cgi?id=150092
1129
1130         Reviewed by Lucas Forschler.
1131
1132         * QueueStatusServer/config/queues.py:
1133         * QueueStatusServer/model/queues.py:
1134         (Queue._capitalize_after_dash):
1135         (Queue._caplitalize_after_dash): Deleted.
1136         * Scripts/webkitpy/common/config/ews.json:
1137
1138 2015-10-13  Sergio Villar Senin  <svillar@igalia.com>
1139
1140         [GTK] Fix build for ENABLE_TOUCH_EVENTS=OFF
1141         https://bugs.webkit.org/show_bug.cgi?id=150085
1142
1143         Reviewed by Carlos Garcia Campos.
1144
1145         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1146
1147 2015-10-13  Sebastian Dröge  <sebastian@centricular.com>
1148
1149         Unreviewed, add myself to the committers list.
1150
1151         * Scripts/webkitpy/common/config/contributors.json:
1152
1153 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
1154
1155         Update bot watcher's dashboard to reflect that EWS is on iOS 9 now
1156         https://bugs.webkit.org/show_bug.cgi?id=149983
1157
1158         Reviewed by Dan Bates.
1159
1160         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1161         (BubbleQueueServer):
1162         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1163
1164 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
1165
1166         Fix webkitpy tests after r190922.
1167
1168         * Scripts/webkitpy/common/config/ews.json:
1169         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1170         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1171
1172 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
1173
1174         Add a Mac debug EWS queue
1175         https://bugs.webkit.org/show_bug.cgi?id=150069
1176
1177         Reviewed by Geoffrey Garen.
1178
1179         * QueueStatusServer/config/queues.py:
1180         * Scripts/webkitpy/common/config/ews.json:
1181         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1182         (AbstractEarlyWarningSystem):
1183         (AbstractEarlyWarningSystem.archive_last_test_results):
1184         (AbstractEarlyWarningSystem.build_style):
1185         (AbstractEarlyWarningSystem.refetch_patch):
1186         (AbstractEarlyWarningSystem.load_ews_classes):
1187
1188 2015-10-12  Mario Sanchez Prada  <mario@endlessm.com>
1189
1190         [GTK] Update jhbuild's version of harfbuzz
1191         https://bugs.webkit.org/show_bug.cgi?id=149749
1192
1193         Reviewed by Martin Robinson.
1194
1195         Update harfbuzz to 0.9.35, following the lead of Debian Stable.
1196
1197         * gtk/jhbuild.modules: Updated details for harfbuzz.
1198
1199 2015-10-12  Mario Sanchez Prada  <mario@endlessm.com>
1200
1201         [GTK] Media tests crashing with gst-plugins-bad 1.4.4 and cpp 5.2
1202         https://bugs.webkit.org/show_bug.cgi?id=150026
1203
1204         Reviewed by Philippe Normand.
1205
1206         Backport upstream patch from gst-plugins-bad so that the right version
1207         of FAAD2 can be found with newer versions of cpp, so that gst-plugins-bad
1208         gets compiled properly, avoiding crashes on runtime while running tests.
1209
1210         * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Added.
1211         * gtk/jhbuild.modules: Referenced the newly added patch for gst-plugins-bad.
1212
1213 2015-10-11  Myles C. Maxfield  <mmaxfield@apple.com>
1214
1215         Test font-variant-* and font-feature-settings with mocked preinstalled fonts
1216         https://bugs.webkit.org/show_bug.cgi?id=149777
1217
1218         Reviewed by Simon Fraser.
1219
1220         Include FontWithFeatures in DumpRenderTree and WebKitTestRunner. Add it
1221         to the list of tests to preinstall at startup time.
1222
1223         Also, update the generation of the 'name' table in the FontWithFeatures font.
1224
1225         * DumpRenderTree/mac/DumpRenderTree.mm:
1226         (allowedFontFamilySet):
1227         (activateTestingFonts):
1228         (activateFontsIOS):
1229         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1230         (Generator::generate):
1231         (Generator::appendCFFTable):
1232         (Generator::appendNameSubtable):
1233         (Generator::appendNAMETable):
1234         * FontWithFeatures/FontWithFeatures/main.cpp:
1235         (main):
1236         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1237         (WTR::allowedFontFamilySet):
1238         (WTR::activateFonts):
1239         * WebKitTestRunner/mac/TestControllerMac.mm:
1240         (WTR::allowedFontFamilySet):
1241
1242 2015-10-11  Jinyoung Hur  <hur.ims@navercorp.com>
1243
1244         Unreviewed. Add Jinyoung Hur as a committer. 
1245
1246         * Scripts/webkitpy/common/config/contributors.json:
1247
1248 2015-10-10  Dan Bernstein  <mitz@apple.com>
1249
1250         [iOS] Remove unnecessary iOS version checks
1251         https://bugs.webkit.org/show_bug.cgi?id=150002
1252
1253         Reviewed by Alexey Proskuryakov.
1254
1255         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1256         (-[HIDEventGenerator _createIOHIDEventType:]):
1257         (-[HIDEventGenerator _sendHIDEvent:]):
1258         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
1259         * WebKitTestRunner/ios/UIKitSPI.h:
1260
1261 2015-10-09  Myles C. Maxfield  <mmaxfield@apple.com>
1262
1263         Unreviewed, rolling out r190689
1264         https://bugs.webkit.org/show_bug.cgi?id=149992
1265
1266         Fixed in other repository.
1267
1268         Reverted changesets:
1269
1270         "Unreviewed, rolling out r190572, r190593, r190594, and r190639."
1271         https://bugs.webkit.org/show_bug.cgi?id=149897
1272
1273 2015-10-09  Brian Burg  <bburg@apple.com>
1274
1275         Teach webkitperl how to figure out IOS versions from the SDK
1276         https://bugs.webkit.org/show_bug.cgi?id=149963
1277
1278         Reviewed by Daniel Bates.
1279
1280         It should be easier to check the major and minor version of IOS SDKs.
1281
1282         * Scripts/copy-webkitlibraries-to-product-directory: use iosVersion().
1283         * Scripts/webkitdirs.pm:
1284         (splitVersionString): Added.
1285         (determineOSXVersion): Use splitVersionString.
1286         (determineIOSVersion): Added. Look at the SDK version and make a tuple.
1287         (iosVersion): Added.
1288
1289 2015-10-09  Simon Fraser  <simon.fraser@apple.com>
1290
1291         [iOS WK2] Fix some leaks in TestRunnerWKWebView and UIScriptContext
1292         https://bugs.webkit.org/show_bug.cgi?id=149960
1293
1294         Reviewed by Tim Horton.
1295         
1296         Use adoptWK(), and null out some members (file is not using ARC).
1297
1298         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
1299         (UIScriptContext::uiScriptComplete):
1300         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1301         (-[TestRunnerWKWebView dealloc]):
1302
1303 2015-10-09  Csaba Osztrogonác  <ossy@webkit.org>
1304
1305         Remove ENABLE_SUID_SANDBOX_LINUX cruft
1306         https://bugs.webkit.org/show_bug.cgi?id=149954
1307
1308         Reviewed by Darin Adler.
1309
1310         * Scripts/webkitperl/FeatureList.pm:
1311
1312 2015-10-09  Daniel Bates  <dabates@apple.com>
1313
1314         Make iOS builders generate debug information in a separate dSYM file
1315         https://bugs.webkit.org/show_bug.cgi?id=149696
1316
1317         Reviewed by Darin Adler.
1318
1319         Similar to the Mac builders, the iOS builders should write debug information
1320         into a separate dSYM file instead of including such information in the binary
1321         itself (default Xcode behavior)
1322
1323         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1324         (CompileWebKit.start):
1325
1326 2015-10-09  Csaba Osztrogonác  <ossy@webkit.org>
1327
1328         Fix webkitpy tests after r190779
1329         https://bugs.webkit.org/show_bug.cgi?id=149949
1330
1331         Reviewed by Ryosuke Niwa.
1332
1333         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1334         (BenchmarkResults.format):
1335         (BenchmarkResults._format_values):
1336
1337 2015-10-08  Dewei Zhu  <dewei_zhu@apple.com>
1338
1339         Extend run-benchmark script to support human-readable results conversion.
1340         https://bugs.webkit.org/show_bug.cgi?id=149944
1341
1342         Reviewed by Ryosuke Niwa.
1343
1344         Add '--read-results-json' and '--no-adjust-unit' options.
1345         '--read-results-json' option converts result file to human readable format.
1346         '--no-adjust-unit' option skips scientific notation convertion.
1347         '--platform' defaults to 'osx' and '--browser' defaults to 'safari'.
1348
1349         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1350         (BenchmarkResults.format):
1351         (BenchmarkResults._format_tests):
1352         (BenchmarkResults._format_values):
1353         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1354         (BenchmarkRunner.__init__):
1355         (BenchmarkRunner._run_benchmark):
1356         (BenchmarkRunner._dump):
1357         (BenchmarkRunner.show_results):
1358         (BenchmarkRunner._show_results): Deleted.
1359         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1360         (parse_args):
1361         (start):
1362
1363 2015-10-08  Daniel Bates  <dabates@apple.com>
1364
1365         Add iOS 9 device builder to WebKit Bot Watcher's Dashboard
1366         https://bugs.webkit.org/show_bug.cgi?id=149945
1367
1368         Reviewed by Dan Bernstein.
1369
1370         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9.png: Added.
1371         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9@2x.png: Added.
1372         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1373         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1374         (WebKitBuildbot):
1375         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1376         (table.queue-grid tr.platform.ios-9 img.logo):
1377
1378 2015-10-08  Daniel Bates  <dabates@apple.com>
1379
1380         Teach build-webkit to install LLVM binaries for iOS when building for device with the public iOS SDK
1381         https://bugs.webkit.org/show_bug.cgi?id=149943
1382
1383         Reviewed by Dan Bernstein.
1384
1385         Following the addition of the LLVM binaries for iOS in changeset r190759 (bug #149913) we should
1386         teach build-webkit to install them when building for iOS device using the public iOS SDK. 
1387
1388         * Scripts/build-webkit:
1389
1390 2015-10-08  Daniel Bates  <dabates@apple.com>
1391
1392         Add LLVM binaries for iOS 9 device
1393         https://bugs.webkit.org/show_bug.cgi?id=149913
1394
1395         Reviewed by Filip Pizlo.
1396
1397         Implement support for building LLVM for ARM64-based iOS devices.
1398
1399         * Scripts/build-jsc: Enable the FTL when building for Mac or iOS device.
1400         * Scripts/copy-webkitlibraries-to-product-directory: Move logic to clean
1401         an existing build earlier in the file such that remove previously built
1402         libraries before building/copying new ones (if applicable).
1403         (fileContains): Moved function outside of if-block.
1404         (isContentOfFileEqualToString): Renamed; formerly named fileContentsEquals().
1405         (buildLLVM): Added. Extracted machinery to build LLVM into this function and
1406         added logic to build LLVM for ARM64-based iOS devices.
1407         (symlinkLLVMLibrariesIfNeeded): Added. Extracted machinery to symlink the built
1408         LLVM into the WebKitBuild directory.
1409
1410 2015-10-08  Alexey Proskuryakov  <ap@apple.com>
1411
1412         Crash-only queues on bot watcher's dashboard should not have non-crashing tests in popovers
1413         https://bugs.webkit.org/show_bug.cgi?id=149848
1414
1415         Reviewed by Darin Adler.
1416
1417         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1418
1419 2015-10-07  Brent Fulgham  <bfulgham@apple.com>
1420
1421         [Win] Support 64-bit Build and Testing
1422         https://bugs.webkit.org/show_bug.cgi?id=149904
1423
1424         Reviewed by Daniel Bates.
1425
1426         Extend our existing scripts to support 64-bit build and test operations on
1427         Windows.
1428
1429         * Scripts/build-dumprendertree: We don't need to build DRT on its own;
1430         Windows always builds the whole stack.
1431         * Scripts/webkit-build-directory: Add an option to return the location of
1432         the executable files produced by a specific configuration. This change is
1433         actually useful for Gtk and EFL, too.
1434         * Scripts/webkitdirs.pm:
1435         (executableProductDir): Added. This function appends the proper binary
1436         path to the productDir. This is useful for Windows, Gtk, and EFL ports.
1437         (jscProductDir): Use the new 'executableProductDir' method.
1438         (setPathForRunningWebKitApp): Ditto.
1439         (runSafari): Ditto.
1440         (runMiniBrowser): Ditto.
1441         * Scripts/webkitpy/port/factory.py:
1442         (configuration_options): Add a 64-bit option, used on Windows to specify
1443         which binary target should be used for testing.
1444         * Scripts/webkitpy/port/win.py:
1445         (WinPort._port_flag_for_scripts): Added. Supply the 64-bit flag to child
1446         processes when needed.
1447         (WinPort._build_path): Add the correct binary target path to _build_path.
1448         (WinPort._ntsd_location): Check 32-bit paths when running 32-bit tests,
1449         64-bit paths for 64-bit tests.
1450         (WinPort.setup_crash_log_saving): Remove '-e %ld' argument, since the
1451         NTSD debugger does not understand this argument.
1452
1453 2015-10-07  Myles C. Maxfield  <mmaxfield@apple.com>
1454
1455         Test font-variant-* and font-feature-settings with TrueType fonts
1456         https://bugs.webkit.org/show_bug.cgi?id=149776
1457
1458         Reviewed by Simon Fraser.
1459
1460         This test extends our existing FontWithFeatures project to be able to generate a
1461         TrueType font. This font is conceptually similar as the existing OpenType font,
1462         except the feature -> character mapping is different.
1463
1464         The font itself only supports the following characters:
1465         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
1466         However, the shape of these letters are either an X or a check mark.
1467         The letter "A" always is a check mark.
1468         The letter "B" always is an X.
1469         Each font feature has an letter associated with it. When the font feature is enabled,
1470         that letter is shown as a check mark. For example, when
1471         "kLowerCaseType / kLowerCaseSmallCapsSelector" is enabled, "S" is shown as a check
1472         mark.
1473
1474         Here are the mappings of font features to letters:
1475         kLigaturesType / kCommonLigaturesOnSelector: C
1476         kLigaturesType / kContextualLigaturesOnSelector: D
1477         kLigaturesType / kRareLigaturesOnSelector: G
1478         kLigaturesType / kHistoricalLigaturesOnSelector: I
1479         kContextualAlternatesType / kContextualAlternatesOnSelector: L
1480         kVerticalPositionType / kInferiorsSelector: O
1481         kVerticalPositionType / kSuperiorsSelector: P
1482         kLowerCaseType / kLowerCaseSmallCapsSelector: S
1483         kUpperCaseType / kUpperCaseSmallCapsSelector: V
1484         kLowerCaseType / kLowerCasePetiteCapsSelector: T
1485         kUpperCaseType / kUpperCasePetiteCapsSelector: W
1486         kLetterCaseType / 14: Y
1487         kStyleOptionsType / kTitlingCapsSelector: a
1488         kNumberCaseType / kUpperCaseNumbersSelector: c
1489         kNumberCaseType / kLowerCaseNumbersSelector: d
1490         kNumberSpacingType / kProportionalNumbersSelector: f
1491         kNumberSpacingType / kMonospacedNumbersSelector: g
1492         kFractionsType / kDiagonalFractionsSelector: i
1493         kFractionsType / kVerticalFractionsSelector: j
1494         kVerticalPositionType / kOrdinalsSelector: Q
1495         kTypographicExtrasType / kSlashedZeroOnSelector: k
1496         kLigaturesType / kHistoricalLigaturesOnSelector: K
1497         kCharacterShapeType / kJIS1978CharactersSelector: m
1498         kCharacterShapeType / kJIS1983CharactersSelector: n
1499         kCharacterShapeType / kJIS1990CharactersSelector: o
1500         kCharacterShapeType / kJIS2004CharactersSelector: p
1501         kCharacterShapeType / kSimplifiedCharactersSelector: q
1502         kCharacterShapeType / kTraditionalCharactersSelector: r
1503         kTextSpacingType / kMonospacedTextSelector: t
1504         kTextSpacingType / kProportionalTextSelector: u
1505         kRubyKanaType / kRubyKanaOnSelector: v
1506
1507         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
1508         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1509         (CFFBuilder::moveTo):
1510         (CFFBuilder::lineTo):
1511         (GLYFBuilder::GLYFBuilder):
1512         (GLYFBuilder::takeResult):
1513         (GLYFBuilder::moveTo):
1514         (GLYFBuilder::lineTo):
1515         (GLYFBuilder::closePath):
1516         (GLYFBuilder::writePoint):
1517         (GLYFBuilder::append16):
1518         (generateBoxCharString):
1519         (generateCheckCharString):
1520         (generateXCharString):
1521         (itemForGlyph):
1522         (Generator::generate):
1523         (Generator::insertSelector):
1524         (Generator::insertFeature):
1525         (Generator::generateFeatureDescription):
1526         (Generator::appendCFFTable):
1527         (Generator::appendGLYFTable):
1528         (Generator::appendLOCATable):
1529         (Generator::appendFEATTable):
1530         (Generator::appendMetamorphosisChain):
1531         (Generator::appendMORXTable):
1532         (Generator::appendHEADTable):
1533         (Generator::appendHMTXTable):
1534         (Generator::appendNameSubtable):
1535         (Generator::append2ByteASCIIString):
1536         (Generator::appendNAMETable):
1537         (generateFont):
1538         (CFFBuilder::curveToCubic): Deleted.
1539         (charStringForGlyph): Deleted.
1540         * FontWithFeatures/FontWithFeatures/FontCreator.h:
1541         * FontWithFeatures/FontWithFeatures/main.cpp:
1542         (constructFontWithTrueTypeFeature):
1543         (constructFontWithOpenTypeFeature):
1544         (drawText):
1545         (main):
1546         (drawTextWithFeature): Deleted.
1547
1548 2015-10-07  Commit Queue  <commit-queue@webkit.org>
1549
1550         Unreviewed, rolling out r190572, r190593, r190594, and
1551         r190639.
1552         https://bugs.webkit.org/show_bug.cgi?id=149897
1553
1554         Breaks Mavericks build (Requested by litherum on #webkit).
1555
1556         Reverted changesets:
1557
1558         "Allow WKRetainPtrs to be used as keys in hashing data
1559         structures"
1560         https://bugs.webkit.org/show_bug.cgi?id=149762
1561         http://trac.webkit.org/changeset/190572
1562
1563         "REGRESSION(189668?): http/tests/notifications/events.html
1564         flakily asserts or times out"
1565         https://bugs.webkit.org/show_bug.cgi?id=149218
1566         http://trac.webkit.org/changeset/190593
1567
1568         "Prospective Mavericks build fix."
1569         http://trac.webkit.org/changeset/190594
1570
1571         "Post-review cleanup after r190572."
1572         http://trac.webkit.org/changeset/190639
1573
1574 2015-10-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1575
1576         [GTK] Add autocleanups
1577         https://bugs.webkit.org/show_bug.cgi?id=149588
1578
1579         Reviewed by Darin Adler.
1580
1581         * TestWebKitAPI/Tests/WebKit2Gtk/AutocleanupsTest.cpp: Added.
1582         (AutocleanupsTest::create):
1583         (AutocleanupsTest::testWebProcessAutocleanups):
1584         (registerTests):
1585         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1586         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp: Added.
1587         (testUIProcessAutocleanups):
1588         (testWebProcessAutocleanups):
1589         (beforeAll):
1590         (afterAll):
1591
1592 2015-10-06  Brian Burg  <bburg@apple.com>
1593
1594         Unreviewed, try to fix the iOS 8 build after r190368.
1595
1596         On older versions, IOHIDEventCreateForceEvent is not available.
1597
1598         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1599         (-[HIDEventGenerator _createIOHIDEventType:]): Add another guard for force events.
1600
1601 2015-10-06  Keith Miller  <keith_miller@apple.com>
1602
1603         Add gmalloc option to run-javascriptcore-tests.
1604         https://bugs.webkit.org/show_bug.cgi?id=149858
1605
1606         Reviewed by Geoffrey Garen.
1607
1608         run-javascriptcore-tests takes a new option --gmalloc with an optional string argument, the path to the gmalloc dylib.
1609         If no argument is provided then /usr/lib/libgmalloc.dylib is used by default.
1610
1611         * Scripts/run-javascriptcore-tests:
1612
1613 2015-10-06  Myles C. Maxfield  <mmaxfield@apple.com>
1614
1615         Post-review cleanup after r190572.
1616
1617         Unreviewed.
1618
1619         * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp:
1620
1621 2015-10-06  Brent Fulgham  <bfulgham@apple.com>
1622
1623         [Win] Unreviewed build correction.
1624
1625         * TestWebKitAPI/PlatformWin.cmake: We don't need to link to all of these libraries. Most
1626         are soft-linked at runtime.
1627
1628 2015-10-06  Keith Miller  <keith_miller@apple.com>
1629
1630         Fix run-javascriptcore-tests/run-jsc-stress-tests to work with rootless, add a --quick option and deprecate the Mozilla driver.
1631         https://bugs.webkit.org/show_bug.cgi?id=149815
1632
1633         Reviewed by Filip Pizlo.
1634
1635         Rootless has an issue where it will strip any environment variables that start with DYLD starting a perl/ruby/python script.
1636         Now, run-jsc-stress-tests takes an new argument, --env-vars, that will set the specified environment variables before
1637         running tests. Additionally, I added a quick option that only runs default and the NoCJITValidate versions of each test.
1638         Finally, I removed the calls to the mozilla jsDriver.pl since the run-jsc-stress-tests runner runs the same test suite
1639         so should just use one test runner.
1640
1641         * Scripts/run-javascriptcore-tests:
1642         (runJSCStressTests):
1643         (runMozillaTests): Deleted.
1644         (defaultJsDriverArgsForMozillaTests): Deleted.
1645         * Scripts/run-jsc-stress-tests:
1646
1647 2015-10-06  Mark Salisbury  <mark.salisbury@hp.com>
1648
1649         [GTK] Make update-webkitgtk-libs work behind firewall
1650
1651         update-webkitgtk-libs can work behind a firewall with changes to
1652         a few packages.  Where outbound git and active FTP connections
1653         fail, using http protocol succeeds.  Most packages are
1654         already accessed using http.
1655
1656         https://bugs.webkit.org/show_bug.cgi?id=148941
1657
1658         Reviewed by Martin Robinson.
1659
1660         Tools
1661         * gtk/jhbuild.modules:
1662             Replace git URLs with http.  Remove no longer used ftp repositories.
1663             Update argument for libxml2's autogen.sh script (--without-python
1664             is ignored; --with-python=no is correct).
1665         * jhbuild/jhbuild-wrapper:
1666             Instead of connecting to git://git.gnome.org/jhbuild, connect to
1667             http://git.gnome.org/browse/jhbuild.
1668
1669 2015-10-06  Daniel Bates  <dbates@webkit.org>
1670
1671         Enable XSLT when building WebKit for iOS using the public iOS SDK
1672         https://bugs.webkit.org/show_bug.cgi?id=149827
1673
1674         Reviewed by Alexey Proskuryakov.
1675
1676         Teach script configure-xcode-for-ios-development to copy the OS X XSLT headers to the iPhoneOS
1677         and iPhoneSimulator SDKs so as to support building WebKit for iOS with XSLT. A person must
1678         run this script before building WebKit for iOS or the build will fail because one or more XSLT
1679         headers cannot be found.
1680
1681         * Scripts/configure-xcode-for-ios-development:
1682         (copyMissingXSLTHeadersToSDKIfNeeded): Added.
1683
1684 2015-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
1685
1686         REGRESSION(189668?): http/tests/notifications/events.html flakily asserts or times out
1687         https://bugs.webkit.org/show_bug.cgi?id=149218
1688
1689         Reviewed by Alexey Proskuryakov.
1690
1691         Because of r189668, WebKitTestRunner now tears down and recreates its WKNotificationManagerRef
1692         when the TestOptions change. Previously, WebNotificationProvider only could handle a single
1693         WKNotificationManagerRef. Because the ower of the WKNotificationManagerRef is reference counted,
1694         and AppKit internally retains some objects which end up retaining the WKNotificationManagerRef,
1695         the old WKNotificationManager may not be destroyed before the new one is created. Therefore,
1696         WebNotificationProvider must be updated to appropriately handle multiple
1697         WKNotificationManagerRefs in flight at the same time.
1698
1699         * WebKitTestRunner/WebNotificationProvider.cpp:
1700         (WTR::WebNotificationProvider::~WebNotificationProvider):
1701         (WTR::WebNotificationProvider::showWebNotification):
1702         (WTR::WebNotificationProvider::closeWebNotification):
1703         (WTR::WebNotificationProvider::addNotificationManager):
1704         (WTR::WebNotificationProvider::removeNotificationManager):
1705         (WTR::WebNotificationProvider::simulateWebNotificationClick):
1706         (WTR::WebNotificationProvider::reset):
1707         * WebKitTestRunner/WebNotificationProvider.h:
1708
1709 2015-10-05  Daniel Bates  <dabates@apple.com>
1710
1711         Disable Bitcode when building for iOS device
1712         https://bugs.webkit.org/show_bug.cgi?id=149818
1713
1714         Reviewed by Alexey Proskuryakov.
1715
1716         Xcode 7 generates bitcode for iOS device apps by default. Do not generate bitcode
1717         when building for iOS device.
1718
1719         * Scripts/webkitdirs.pm:
1720         (XcodeOptions):
1721
1722 2015-10-05  Daniel Bates  <dabates@apple.com>
1723
1724         [iOS] Make it possible to build WebKit using iphoneos SDK without a developer certificate installed
1725         https://bugs.webkit.org/show_bug.cgi?id=140828
1726         <rdar://problem/19520599>
1727
1728         Reviewed by Alexey Proskuryakov.
1729
1730         Support building WebKit for iOS device without an iOS Developer certificate installed. Otherwise,
1731         we will pass CODE_SIGN_IDENTITY="iPhone Developer: " to Xcode to find a iOS Developer certificate
1732         to use. To use a specific installed iOS Developer certificate, explicitly pass CODE_SIGN_IDENTITY
1733         to build-webkit.
1734
1735         * Scripts/webkitdirs.pm:
1736         (XcodeOptions): Cleaned up code. When building for iOS device, pass to Xcode CODE_SIGN_IDENTITY="iPhone Developer: "
1737         to code sign using the installed iOS development certificate (if it exists - we assume there is only one such certificate).
1738         Otherwise, pass CODE_SIGN_IDENTITY="" and CODE_SIGNING_REQUIRED=NO to Xcode to disable code signing.
1739         (hasIOSDevelopmentCertificate): Added.
1740
1741 2015-10-05  Daniel Bates  <dabates@apple.com>
1742
1743         DumpRenderTree built with public iOS SDK crashes under -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
1744         https://bugs.webkit.org/show_bug.cgi?id=149766
1745
1746         Reviewed by Alexey Proskuryakov.
1747
1748         Create network storage testing session on iOS.
1749
1750         Currently we do not create a network storage testing session on iOS. A network storage testing session always
1751         has an associated cookie store. When WebKit is built without USE(CFNETWORK), NetworkStorageSession::defaultStorageSession().cookieStorage()
1752         returns nullptr because the caller is expected to interact with NSHTTPCookieStorage instead of querying
1753         NetworkStorageSession for the cookie store. When WebKit is built with USE(CFNETWORK) accessing
1754         NetworkStorageSession::defaultStorageSession().cookieStorage() returns a valid cookie store (creating one if
1755         it does not exist). Instead we should make use of NetworkStorageSession::switchToNewTestingSession() to
1756         create a network storage testing session when building DumpRenderTree for iOS so as to ensure a consistent
1757         testing environment regardless of whether we built with USE(CFNETWORK). This will also make the behavior of
1758         DumpRenderTree on iOS more consistent with the behavior of DumpRenderTree on Mac.
1759
1760         As a side effect of this change DumpRenderTree no longer crashes in -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
1761         when WebKit is built without USE(CFNETWORK) because NetworkStorageSession::defaultStorageSession().cookieStorage()
1762         returns a non-null pointer to a cookie store.
1763
1764         * DumpRenderTree/mac/DumpRenderTree.mm:
1765         (prepareConsistentTestingEnvironment):
1766
1767 2015-10-05  Simon Fraser  <simon.fraser@apple.com>
1768
1769         Fix the iOS 8 build again, where -[UIApplication _enqueueHIDEvent:] is not
1770         available.
1771
1772         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1773         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
1774
1775 2015-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
1776
1777         Allow WKRetainPtrs to be used as keys in hashing data structures
1778         https://bugs.webkit.org/show_bug.cgi?id=149762
1779
1780         Reviewed by Anders Carlsson.
1781
1782         * TestWebKitAPI/PlatformGTK.cmake:
1783         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1784         * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp: Added.
1785         (TestWebKitAPI::TEST):
1786
1787 2015-10-05  Simon Fraser  <simon.fraser@apple.com>
1788
1789         Fix the iOS 8 build, where -[UIApplication _enqueueHIDEvent:] is not
1790         available, and tidy up the #ifdefs in the UIKitSPI header.
1791
1792         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1793         (-[HIDEventGenerator _sendHIDEvent:]):
1794         * WebKitTestRunner/ios/UIKitSPI.h:
1795
1796 2015-10-04  Zan Dobersek  <zdobersek@igalia.com>
1797
1798         [GTK] Remove duplicate entries in WebKitTestRunner_SOURCES
1799         https://bugs.webkit.org/show_bug.cgi?id=149792
1800
1801         Reviewed by Martin Robinson.
1802
1803         * WebKitTestRunner/PlatformGTK.cmake: Don't list build targets
1804         for WebKitTestRunner multiple times.
1805
1806 2015-10-04  Daniel Bates  <dabates@apple.com>
1807
1808         Fix the Apple Internal iOS build after <http://trac.webkit.org/changeset/190515>
1809         (https://bugs.webkit.org/show_bug.cgi?id=149753)
1810
1811         For now, support calling build-layouttestrelay without --ios-simulator so long
1812         as we are building on a Mac.
1813
1814         * Scripts/build-layouttestrelay:
1815
1816 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
1817
1818         Support Trac 1.0.x XML timeline link format
1819         https://bugs.webkit.org/show_bug.cgi?id=149786
1820
1821         Reviewed by Lucas Forschler.
1822
1823         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1824         (Trac.prototype._convertCommitInfoElementToObject):
1825
1826 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
1827
1828         Fix some errors on bot watcher's dashboard
1829         https://bugs.webkit.org/show_bug.cgi?id=149789
1830
1831         Reviewed by Lucas Forschler.
1832
1833         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1834         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): We may not get to layout
1835         tests step, in which case layoutTestResults.tooManyFailures would raise an exception.
1836
1837 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
1838
1839         Bot watcher's dashboard builders should turn yellow when svn fails
1840         https://bugs.webkit.org/show_bug.cgi?id=149791
1841
1842         Reviewed by Lucas Forschler.
1843
1844         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1845         (BuildbotBuilderQueueView.prototype.appendBuilderQueueStatus):
1846         (BuildbotBuilderQueueView.prototype.update):
1847
1848 2015-10-02  Daniel Bates  <dabates@apple.com>
1849
1850         Add iOS 9 Simulator builders and testers to WebKit Bot Watcher's Dashboard
1851         https://bugs.webkit.org/show_bug.cgi?id=149769
1852
1853         Reviewed by Alexey Proskuryakov.
1854
1855         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png: Added.
1856         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png: Added.
1857         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1858         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1859         (WebKitBuildbot):
1860         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1861         (table.queue-grid tr.platform.ios-simulator-9 img.logo):
1862
1863 2015-10-02  Ryosuke Niwa  <rniwa@webkit.org>
1864
1865         REGRESSION(r190370): Speedometer spits out an extra console message
1866         https://bugs.webkit.org/show_bug.cgi?id=149720
1867
1868         Unreviewed. Temporarily ignore the console error message.
1869
1870         * Scripts/webkitpy/performance_tests/perftest.py:
1871         (PerfTest._filter_output):
1872
1873 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
1874
1875         Provide "--no-ninja" option to avoid using Ninja
1876         https://bugs.webkit.org/show_bug.cgi?id=149757
1877
1878         Reviewed by Alex Christensen.
1879
1880         Add a new command line argument understood by webkitdirs.pm so
1881         that we can conditionally avoid using Ninja. This is an
1882         'opt-out' argument, so no existing Ninja users should be affected.
1883         
1884         * Scripts/webkitdirs.pm:
1885         (canUseNinja): Check for option and block ninja if present.
1886
1887 2015-10-02  Aakash Jain  <aakash_jain@apple.com>
1888
1889         Flakiness dashboard should support OS X El Capitan
1890         https://bugs.webkit.org/show_bug.cgi?id=149648
1891
1892         Reviewed by Alexey Proskuryakov.
1893
1894         * TestResultServer/static-dashboards/flakiness_dashboard.js: Fix the broken dashboard for ElCapitan.
1895
1896 2015-10-02  Daniel Bates  <dabates@apple.com>
1897
1898         Fix run-webkit-tests --ios-simulator after <http://trac.webkit.org/changeset/190515>
1899         (https://bugs.webkit.org/show_bug.cgi?id=149753)
1900
1901         For now, pass --ios-simulator.
1902
1903         * Scripts/webkitpy/port/ios.py:
1904         (IOSSimulatorPort._build_relay):
1905
1906 2015-10-02  Simon Fraser  <simon.fraser@apple.com>
1907
1908         Remove a "nullable" that breaks the iOS 8 build.
1909
1910         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1911         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]):
1912
1913 2015-10-02  Daniel Bates  <dabates@apple.com>
1914
1915         LayoutTestRelay is not built and archived when building for iOS Simulator
1916         https://bugs.webkit.org/show_bug.cgi?id=149753
1917
1918         Reviewed by Alexey Proskuryakov and Andy Estes.
1919
1920         Towards running layout tests on the iOS Simulator test bots, we need to teach scripts build-webkit
1921         and built-product-archive to build the Mac tool LayoutTestRelay and include this tool in the built
1922         product archive when building for iOS Simulator, respectively.
1923
1924         * BuildSlaveSupport/built-product-archive:
1925         (main): Pass the full platform name (options.platform) to archiveBuiltProduct() so that it can
1926         differentiate between iOS device and iOS Simulator platforms.
1927         (webkitBuildDirectoryForConfigurationAndPlatform): Extracted logic to run the script webkit-build-directory
1928         from determineWebKitBuildDirectories() into this function so that it can be used by both
1929         determineWebKitBuildDirectories() and archiveBuiltProduct().
1930         (determineWebKitBuildDirectories): Moved logic to execute the script webkit-build-directory from here to
1931         webkitBuildDirectoryForConfigurationAndPlatform().
1932         (createZip): Added parameter embedParentDirectoryNameOnDarwin (defaults to False) to specify whether
1933         we should call ditto(1) with --keepParent to embed the parent directory name in the zip archive. This
1934         argument is only applicable when building on Darwin. We only pass embedParentDirectoryNameOnDarwin=True
1935         when making an archive for a Mac or iOS device build. For iOS Simulator builds we archive two directories
1936         and we do not want to keep the parent directory because it is a placeholder directory used as a workaround
1937         for the limitation that ditto(1) can only accept a single directory to archive on its command line.
1938         (archiveBuiltProduct): Modified to take the full platform name as an argument. Added logic for iOS.
1939         For iOS device builds we use the same logic as for a Mac build and archive the configuration-specific
1940         build directory. For iOS Simulator builds we archive the configuration-specific iOS build directory,
1941         LayoutTestRelay and LayoutTestRelay.dSYM (if it exists) from the configuration-specific Mac build.
1942         * Scripts/build-layouttestrelay:
1943             - Remove unnecessary include of Perl module POSIX.
1944             - Only build LayoutTestRelay when building for iOS Simulator (i.e. --ios-simulator is passed).
1945         * Scripts/build-webkit:
1946             - Invoke script build-layouttestrelay when building for iOS Simulator.
1947
1948 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
1949
1950         [Win] Unreviewed test fix.
1951
1952         You cannot run 'run-webkit-tests' from the command line because it does not know
1953         to append the binary subdirectory (bin32/bin64). We don't see this on our builders
1954         because they explicitly set use the 'root' argument to provide the full path to
1955         the test binaries.
1956
1957         * Scripts/webkitpy/port/win.py:
1958         (WinPort._build_path): Added.
1959
1960 2015-10-02  Alex Christensen  <achristensen@webkit.org>
1961
1962         Reloading without content blockers doesn't apply to resource loads after the main frame finishes
1963         https://bugs.webkit.org/show_bug.cgi?id=149430
1964         rdar://problem/22742222
1965
1966         Reviewed by Geoffrey Garen.
1967
1968         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1969         (WTR::TestController::cocoaResetStateToConsistentValues):
1970         * WebKitTestRunner/mac/TestControllerMac.mm:
1971         (WTR::TestController::platformConfigureViewForTest):
1972         Test what happens when you disable content blockers from the SPI.
1973
1974 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
1975
1976         [Win] Unreviewed build fix for run-api-tests
1977
1978         * Scripts/run-api-tests:
1979         (testToolPaths): Windows run needs to specify the binary path.
1980
1981 2015-10-01  Daniel Bates  <dabates@apple.com>
1982
1983         Another attempt to fix the Windows builders after <https://trac.webkit.org/changeset/190387>
1984         (https://bugs.webkit.org/show_bug.cgi?id=149695)
1985
1986         Following r190424 we can now rely on webkit-build-directory to return the path to
1987         the correct configuration-specific build directory on Windows.
1988
1989         * BuildSlaveSupport/built-product-archive:
1990         (archiveBuiltProduct):
1991
1992 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
1993
1994         [Win] Unreviewed build fix.
1995
1996         * Scripts/webkitdirs.pm:
1997         (setupAppleWinEnv): Use 64-bit build tools if available
1998
1999 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
2000
2001         [Win] Fix TestWebKitAPI build under CMake.
2002
2003         Reviewed by Alex Christensen.
2004
2005         * TestWebKitAPI/PlatformWin.cmake: Add missing link command
2006         for Psapi.lib.
2007
2008 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
2009
2010         [Win] Fix behavior of webkit-build-directory script
2011         https://bugs.webkit.org/show_bug.cgi?id=149718
2012
2013         Reviewed by Alex Christensen.
2014
2015         * Scripts/webkitdirs.pm:
2016         (determineConfigurationProductDir): Do not include the binary
2017         sub-directory in the configuration product directory output.
2018         (jscProductDir): Append correct binary path for Windows build.
2019         (setPathForRunningWebKitApp): Include properly binary subdirectories.
2020         (runSafari): Update for revised productDir behavior.
2021         (runMiniBrowser): Ditto.
2022
2023 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
2024
2025         Stop building LayoutTestRelay for now. It's a Mac project, but build-webkit tries to
2026         use iOS SDK, like with all the others.
2027
2028         * Scripts/build-webkit:
2029
2030 2015-10-01  Daniel Bates  <dabates@apple.com>
2031
2032         Attempt to fix the iOS 9 Simulator testers
2033
2034         Add dependency DumpRenderTree.app to target All of project DumpRenderTree so that we
2035         build DumpRenderTree.app, if applicable. Also, teach build-webkit to build project
2036         LayoutTestRelay when building for iOS Simulator.
2037
2038         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2039         * Scripts/build-webkit:
2040
2041 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2042
2043         [GTK] Websites with invalid auth header keep loading forever
2044         https://bugs.webkit.org/show_bug.cgi?id=149710
2045
2046         Reviewed by Martin Robinson.
2047
2048         Add test case to check that we can authenticate sites with an
2049         empty realm.
2050
2051         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
2052         (testWebViewAuthenticationEmptyRealm):
2053         (serverCallback):
2054         (beforeAll):
2055
2056 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
2057
2058         [Mac] Make run-api-tests work with System Integrity Protection
2059         https://bugs.webkit.org/show_bug.cgi?id=149711
2060         rdar://problem/22928202
2061
2062         Reviewed by Dan Bernstein.
2063
2064         * Scripts/run-api-tests:
2065         (runTest):
2066         (archCommandLineArgumentsForRestrictedEnvironmentVariables):
2067
2068 2015-10-01  Daniel Bates  <dabates@apple.com>
2069
2070         Attempt to fix the Windows build after <https://trac.webkit.org/changeset/190387>
2071         (https://bugs.webkit.org/show_bug.cgi?id=149695)
2072
2073         For some reason built-product-archive hardcodes the assumption that we build for 32-bit Windows.
2074         For now, use the path to the top-level WebKit build directory instead of using the configuration-
2075         specific build directory.
2076
2077         * BuildSlaveSupport/built-product-archive:
2078         (archiveBuiltProduct):
2079
2080 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
2081
2082         [EFL] Fix the openwebrtc and gst-plugins-openwebrtc build with clang
2083         https://bugs.webkit.org/show_bug.cgi?id=145837
2084
2085         Reviewed by Philippe Normand.
2086
2087         * efl/jhbuild.modules:
2088         * efl/patches/openwebrtc-clang-warning-fix.patch: Added.
2089         * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Added.
2090
2091 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2092
2093         Unreviewed. Fix the iOS build after r190407.
2094
2095         * WebKitTestRunner/ios/IOKitSPI.h:
2096
2097 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2098
2099         Implement keyboard event sending for iOS in WebKitTestRunner
2100         https://bugs.webkit.org/show_bug.cgi?id=149676
2101
2102         Reviewed by Simon Fraser.
2103
2104         Adds support for generating and sending key events in WebKitTestRunner. This is accomplished in a similar
2105         way as touch events, using IOHIDEvent machinery. Also adds callbacks to the UIScriptController JS API that
2106         allows us to run code when the keyboard is shown or hidden.
2107
2108         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Adds the typeCharacter JS interface.
2109         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
2110         (WTR::UIScriptController::setDidShowKeyboardCallback):
2111         (WTR::UIScriptController::didShowKeyboardCallback):
2112         (WTR::UIScriptController::setDidHideKeyboardCallback):
2113         (WTR::UIScriptController::didHideKeyboardCallback):
2114         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
2115         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
2116         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
2117         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
2118         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2119         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2120         (-[TestRunnerWKWebView initWithFrame:configuration:]): Registers the TestRunnerWKWebView to listen to
2121                 the notifications that the keyboard has been raised or lowered.
2122         (-[TestRunnerWKWebView _keyboardDidShow:]):
2123         (-[TestRunnerWKWebView _keyboardDidHide:]):
2124         * WebKitTestRunner/ios/HIDEventGenerator.h:
2125         * WebKitTestRunner/ios/HIDEventGenerator.m:
2126         (-[HIDEventGenerator _sendIOHIDKeyboardEvent:usage:isKeyDown:]): Helper to send a HID keyboard event.
2127         (shouldWrapWithShiftKeyEventForCharacter): Helper used to generate key events.
2128         (hidUsageCodeForCharacter): Ditto.
2129         (-[HIDEventGenerator keyDown:completionBlock:]): Synthesizes and sends HIDKeyboardEvents, triggering
2130                 a keyDown event in WebKit.
2131         * WebKitTestRunner/ios/IOKitSPI.h:
2132         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2133
2134 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2135
2136         Unreviewed, rolling out r190399.
2137
2138         Tests are still failing even after r190362
2139
2140         Reverted changeset:
2141
2142         "Unreviewed. Unskip GTK+ user media unit tests after r190362."
2143         http://trac.webkit.org/changeset/190399
2144
2145 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
2146
2147         [jhbuild] switch to new upstream usrsctp library
2148         https://bugs.webkit.org/show_bug.cgi?id=149494
2149
2150         Reviewed by Philippe Normand.
2151
2152         * efl/jhbuild.modules:
2153         * gtk/jhbuild.modules:
2154
2155 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2156
2157         Unreviewed. Unskip GTK+ user media unit tests after r190362.
2158
2159         They should pass now.
2160
2161         * Scripts/run-gtk-tests:
2162         (TestRunner):
2163
2164 2015-09-30  Daniel Bates  <dabates@apple.com>
2165
2166         Another attempt to fix the build after <https://trac.webkit.org/changeset/190387>
2167         (https://bugs.webkit.org/show_bug.cgi?id=149695)
2168
2169         * BuildSlaveSupport/built-product-archive:
2170         (determineWebKitBuildDirectories): Substitute _configurationBuildDirectory for _buildDirectory.
2171         (extractBuiltProduct): Substitute _topLevelBuildDirectory for _buildDirectory.
2172
2173 2015-09-30  Daniel Bates  <dabates@apple.com>
2174
2175         Attempt to fix the build after <https://trac.webkit.org/changeset/190387>
2176         (https://bugs.webkit.org/show_bug.cgi?id=149695)
2177
2178         Actually, we need to pass --configuration to script webkit-build-directory to have
2179         it return the path to the configuration-specific build directory.
2180
2181         * BuildSlaveSupport/built-product-archive:
2182         (determineWebKitBuildDirectories):
2183
2184 2015-09-30  Daniel Bates  <dabates@apple.com>
2185
2186         built-product-archive archives incorrect build directory for iOS port
2187         https://bugs.webkit.org/show_bug.cgi?id=149695
2188
2189         Reviewed by Darin Adler.
2190
2191         Fixes an issue where the script built-product-archive archives a non-existent
2192         build directory for the iOS port. Without loss of generality, the script assumes
2193         the path to the Release configuration build for iOS is in directory WebKitBuild/Release.
2194         But the built products for this configuration are in directory WebKitBuild/Release-iphonesimulator.
2195
2196         Currently the script built-product-archive calls `webkit-build-directory --top-level ...`
2197         to determine the top-level build directory and computes the configuration-specific
2198         build directory to be the concatenation of the the top-level build directory and
2199         the configuration (e.g. Release). This is incorrect. Instead we should call
2200         webkit-build-directory omitting the flag --top-level to compute the path to the
2201         configuration-specific build directory.
2202
2203         * BuildSlaveSupport/built-product-archive: Fix up the style such that we use single quoted literals.
2204         (main): Renamed global variable _buildDirectory to _topLevelBuildDirectory to better describe
2205         its purpose and added global variable _configurationBuildDirectory to store the path
2206         to the configuration-specific build directory. Ensure that we have a non-empty string
2207         for both the top-level and configuration-specific build directories.
2208         (determineWebKitBuildDirectories): Formerly named determineWebKitBuildDirectory.
2209         Compute the configuration-specific build directory and store it in the global variable
2210         _configurationBuildDirectory.
2211         (archiveBuiltProduct): Modified to use _configurationBuildDirectory.
2212         (extractBuiltProduct): Modified to use _configurationBuildDirectory and _topLevelBuildDirectory
2213         as needed.
2214         (determineWebKitBuildDirectory): Deleted.
2215
2216 2015-09-30  Hunseop Jeong  <hs85.jeong@samsung.com>
2217
2218         [EFL] css3/device-adapt/* tests failed after r190335.
2219         https://bugs.webkit.org/show_bug.cgi?id=149655
2220
2221         Reviewed by Simon Fraser.
2222
2223         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
2224         overwritten by updatePlatformSpecificViewOptionsForTest after r190335.
2225
2226         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2227         (WTR::shouldUseFixedLayout):
2228
2229 2015-09-30  Dewei Zhu  <dewei_zhu@apple.com>
2230
2231         Extend JetStream timeout for slow devices.
2232
2233         Reviewed by Chris Dumez.
2234
2235         Extend JetStream timeout to 20 minutes.
2236
2237         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
2238
2239 2015-09-30  Daniel Bates  <dabates@apple.com>
2240
2241         Rename iOS builders/testers to include version
2242         https://bugs.webkit.org/show_bug.cgi?id=149685
2243
2244         Reviewed by Simon Fraser.
2245
2246         Substitute "Apple iOS 9" for "Apple iOS" in the names of iOS builders/testers so as
2247         make it clear to a reader the version of iOS these builders/testers are using.
2248
2249         * BuildSlaveSupport/build.webkit.org-config/config.json:
2250         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2251
2252 2015-09-30  Daniel Bates  <dabates@apple.com>
2253
2254         Add iOS criterion for triggering a build
2255         https://bugs.webkit.org/show_bug.cgi?id=149679
2256
2257         Rubber-stamped by Alexey Proskuryakov.
2258
2259         First pass at defining criterion for triggering an iOS build.
2260
2261         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2262         (_should_file_trigger_build):
2263         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2264         (ShouldBuildTest):
2265         (ShouldBuildTest.test_should_build):
2266
2267 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
2268
2269         [iOS] Allow tests to generate user gestures for UI testing
2270         https://bugs.webkit.org/show_bug.cgi?id=149653
2271
2272         Reviewed by Tim Horton.
2273
2274         Expose functionality in UIScriptController to allow for testing single- and double-tap,
2275         and to listen for completion of scrolling and zooming in the WKWebView.
2276         
2277         Tap generation is done using synthetic IOHIDEvents, via a new HIDEventGenerator class
2278         which hides the complexity of creating these events. Event dispatch is asynchronous.
2279         We detect when the last event has been handled by dispatching a vendor-specific event,
2280         which is detected via -_handleHIDEvent: in our UIApplication subclass.
2281         
2282         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Link with IOKit.
2283         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Two new properties
2284         for 'will begin zooming' and 'did end zooming' callbacks, and functions to dispatch
2285         single and double taps.
2286         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
2287         (UIScriptContext::registerCallback): Used to store the callbacks for zooming.
2288         Unlike the "task" callbacks, these are persistent, but we store them in the same hash map.
2289         (UIScriptContext::unregisterCallback):
2290         (UIScriptContext::callbackWithID):
2291         (UIScriptContext::fireCallback):
2292         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
2293         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
2294         (WTR::UIScriptController::setWillBeginZoomingCallback): Cross-platform code.
2295         (WTR::UIScriptController::willBeginZoomingCallback): Ditto.
2296         (WTR::UIScriptController::setDidEndZoomingCallback):
2297         (WTR::UIScriptController::didEndZoomingCallback):
2298         (WTR::UIScriptController::singleTapAtPoint): Non-iOS stub.
2299         (WTR::UIScriptController::doubleTapAtPoint): Ditto.
2300         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
2301         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
2302         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
2303         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2304         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Properties for the zooming callbacks.
2305         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2306         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]): Dispatch the zooming callback.
2307         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]): Ditto.
2308         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]): Ditto.
2309         (-[TestRunnerWKWebView onDidEndZooming:]): Deleted.
2310         * WebKitTestRunner/ios/HIDEventGenerator.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
2311         * WebKitTestRunner/ios/HIDEventGenerator.m: Added.
2312         (simpleDragCurve):
2313         (calculateNextLocation):
2314         (delayBetweenMove):
2315         (+[HIDEventGenerator sharedHIDEventGenerator]):
2316         (+[HIDEventGenerator nextEventCallbackID]):
2317         (-[HIDEventGenerator init]):
2318         (-[HIDEventGenerator _createIOHIDEventType:]):
2319         (-[HIDEventGenerator _sendHIDEvent:]):
2320         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
2321         (-[HIDEventGenerator _updateTouchPoints:count:]):
2322         (-[HIDEventGenerator touchDownAtPoints:touchCount:]):
2323         (-[HIDEventGenerator touchDown:touchCount:]):
2324         (-[HIDEventGenerator touchDown:]):
2325         (-[HIDEventGenerator liftUpAtPoints:touchCount:]):
2326         (-[HIDEventGenerator liftUp:touchCount:]):
2327         (-[HIDEventGenerator liftUp:]):
2328         (-[HIDEventGenerator moveToPoints:touchCount:duration:]):
2329         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
2330         (-[HIDEventGenerator tap:completionBlock:]):
2331         (-[HIDEventGenerator doubleTap:completionBlock:]):
2332         (-[HIDEventGenerator twoFingerTap:completionBlock:]):
2333         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2334         (-[HIDEventGenerator pinchCloseWithStartPoint:endPoint:duration:completionBlock:]):
2335         (-[HIDEventGenerator pinchOpenWithStartPoint:endPoint:duration:completionBlock:]):
2336         (-[HIDEventGenerator markerEventReceived:]):
2337         * WebKitTestRunner/ios/IOKitSPI.h: Added.
2338         * WebKitTestRunner/ios/UIKitSPI.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
2339         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2340         (WTR::globalToContentCoordinates):
2341         (WTR::UIScriptController::singleTapAtPoint):
2342         (WTR::UIScriptController::doubleTapAtPoint):
2343         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
2344         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
2345         * WebKitTestRunner/ios/mainIOS.mm:
2346         (-[WebKitTestRunnerApp _handleHIDEvent:]):
2347
2348 2015-09-30  Dana Burkart  <dburkart@apple.com>
2349
2350         git-add-reviewer should trim trailing spaces/newlines
2351         https://bugs.webkit.org/show_bug.cgi?id=149513
2352
2353         Reviewed by Darin Adler.
2354
2355         * Scripts/git-add-reviewer:
2356         (nonInteractive):
2357
2358 2015-09-30  Eric Carlson  <eric.carlson@apple.com>
2359
2360         REGRESSION(r190262): User media unit test failures after r190262
2361         https://bugs.webkit.org/show_bug.cgi?id=149580
2362
2363         Reviewed by Darin Adler.
2364
2365         * WebKitTestRunner/TestController.cpp:
2366         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Fix parameter
2367           order to WKUserMediaPermissionRequestAllow.
2368
2369 2015-09-30  Daniel Bates  <dabates@apple.com>
2370
2371         Add iOS builders and testers
2372         https://bugs.webkit.org/show_bug.cgi?id=149549
2373
2374         Reviewed by Alexey Proskuryakov.
2375
2376         Adds definitions for 64-bit iOS Simulator release builders and testers and a iOS device
2377         builder that builds universal release binaries for armv7, armv7s and arm64 architectures.
2378
2379         * BuildSlaveSupport/build.webkit.org-config/config.json: Add definitions for builders and testers.
2380         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Update unit tests.
2381
2382 2015-09-30  Timothy Hatcher  <timothy@apple.com>
2383
2384         Give WebKitLauncher the get-task-allow entitlement to allow it to work on El Capitan
2385         https://bugs.webkit.org/show_bug.cgi?id=149674
2386
2387         Reviewed by Lucas Forschler.
2388
2389         * WebKitLauncher/WebKitLauncher.entitlements: Added.
2390         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2391
2392 2015-09-30  Jason Marcell  <jmarcell@apple.com>
2393
2394         BuildbotQueueView.prototype._appendPendingRevisionCount should skip repositories that don't
2395         have an associated trac instance.
2396         https://bugs.webkit.org/show_bug.cgi?id=149673
2397
2398         Reviewed by Alexey Proskuryakov.
2399
2400         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2401         (BuildbotQueueView.prototype._appendPendingRevisionCount): Skip repositories that don't
2402         have an associated trac instance.
2403
2404 2015-09-30  Daniel Bates  <dabates@apple.com>
2405
2406         Prioritize testing latest build request on iOS test bots
2407         https://bugs.webkit.org/show_bug.cgi?id=149669
2408
2409         Reviewed by Darin Adler.
2410
2411         We should prioritize testing of the latest build request on the iOS test bots
2412         as we do for Mac and Windows test bots.
2413
2414         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2415         (loadBuilderConfig):
2416
2417 2015-09-30  Daniel Bates  <dabates@apple.com>
2418
2419         Add buildbot category for iOS builders and testers
2420         https://bugs.webkit.org/show_bug.cgi?id=149667
2421
2422         Reviewed by Darin Adler.
2423
2424         Group iOS builders and testers under category iOS and add dashboard and console hyperlinks
2425         for iOS to the build.webkit.org home page.
2426
2427         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2428         (loadBuilderConfig):
2429         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2430
2431 2015-09-30  Daniel Bates  <dabates@apple.com>
2432
2433         Actually fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
2434         (https://bugs.webkit.org/show_bug.cgi?id=149539)
2435
2436         I inadvertently didn't remove the ONLY_ACTIVE_ARCH=NO flag when building on a Mac
2437         in <http://trac.webkit.org/changeset/190351>.
2438
2439         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2440         (CompileWebKit.start):
2441
2442 2015-09-30  Daniel Bates  <dabates@apple.com>
2443
2444         Attempt to fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
2445         (https://bugs.webkit.org/show_bug.cgi?id=149539)
2446
2447         {32, 64}-bit Mac builders should not try to build project {Plugin.64, Plugin.32},
2448         respectively; only pass ONLY_ACTIVE_ARCH=NO when building for iOS.
2449
2450         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2451         (CompileWebKit.start):
2452
2453 2015-09-30  Lucas Forschler  <lforschler@apple.com>
2454
2455         bot210 was configured for a queue instead of bot126.
2456         
2457         Unreviewed config.json fix.
2458         
2459         * BuildSlaveSupport/build.webkit.org-config/config.json:
2460
2461 2015-09-30  Lucas Forschler  <lforschler@apple.com>
2462
2463         Bring El Capitan buildbot infrastructure online.
2464         https://bugs.webkit.org/show_bug.cgi?id=149605
2465         
2466         Reviewed by Darin Adler.
2467
2468         * BuildSlaveSupport/build.webkit.org-config/config.json:
2469
2470 2015-09-30  Tomas Popela  <tpopela@redhat.com>
2471
2472         [GTK] Deprecation warnings in DOMNodeTest
2473         https://bugs.webkit.org/show_bug.cgi?id=149663
2474
2475         After the webkit_dom_document_get_elements_by_tag_name deprecation we
2476         need to update the tests to use webkit_dom_document_query_selector_all
2477         to avoid compilation warnings.
2478
2479         Also add a new test for webkit_dom_document_get_elements_by_tag_name_as_html_collection
2480         (the suggested replacement for the deprecated function).
2481
2482         Reviewed by Carlos Garcia Campos.
2483
2484         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2485         (WebKitDOMNodeTest::testTagNamesNodeList):
2486         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
2487         (registerTests):
2488         (WebKitDOMNodeTest::testTagNames): Deleted.
2489         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
2490         (prepareDOMForTagNamesTests):
2491         (testWebKitDOMNodeTagNamesNodeList):
2492         (testWebKitDOMNodeTagNamesHTMLCollection):
2493         (beforeAll):
2494         (testWebKitDOMNodeTagNames): Deleted.
2495
2496 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
2497
2498         WebKitTestRunner fails to apply "useFlexibleViewport" when it's specified in a file comment
2499         https://bugs.webkit.org/show_bug.cgi?id=149650
2500
2501         Reviewed by Tim Horton.
2502         
2503         TestInvocation::invoke() consulted shouldMakeViewportFlexible(), but that only
2504         looks at the file path, and not the custom options that come from file comments.
2505         
2506         Fix by computing TestOptions before making the TestInvocation, and setting them
2507         as const TestInvocation data. This meant changing various call sites to take
2508         the std::string pathOrURL, rather than the TestInvocation itself.
2509         
2510         Also initialize TestInvocation with a WKURLRef, rather than a std::string.
2511
2512         * WebKitTestRunner/CMakeLists.txt:
2513         * WebKitTestRunner/TestController.cpp:
2514         (WTR::TestController::ensureViewSupportsOptionsForTest):
2515         (WTR::testPath):
2516         (WTR::createTestURL):
2517         (WTR::updateTestOptionsFromTestHeader):
2518         (WTR::TestController::testOptionsForTest):
2519         (WTR::TestController::updateWebViewSizeForTest):
2520         (WTR::TestController::updateWindowScaleForTest):
2521         (WTR::TestController::runTest):
2522         * WebKitTestRunner/TestController.h:
2523         * WebKitTestRunner/TestInvocation.cpp:
2524         (WTR::TestInvocation::TestInvocation):
2525         (WTR::TestInvocation::invoke):
2526         (WTR::createWKURL): Deleted.
2527         (WTR::TestInvocation::shouldMakeViewportFlexible): Deleted.
2528         (WTR::TestInvocation::shouldUseFixedLayout): Deleted.
2529         * WebKitTestRunner/TestInvocation.h:
2530         (WTR::TestInvocation::options):
2531         * WebKitTestRunner/TestOptions.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
2532         (WTR::pathContains):
2533         (WTR::shouldMakeViewportFlexible):
2534         (WTR::shouldUseFixedLayout):
2535         (WTR::isSVGTestPath):
2536         (WTR::isHiDPITestPath):
2537         (WTR::TestOptions::TestOptions):
2538         * WebKitTestRunner/TestOptions.h:
2539         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2540         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2541         (WTR::pathContains):
2542         (WTR::shouldUseFixedLayout):
2543         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2544         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2545         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2546         * WebKitTestRunner/ios/TestControllerIOS.mm:
2547         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2548         * WebKitTestRunner/mac/TestControllerMac.mm:
2549         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2550
2551 2015-09-29  Aakash Jain  <aakash_jain@apple.com>
2552
2553         Flakiness dashboard should support OS X El Capitan
2554         https://bugs.webkit.org/show_bug.cgi?id=149648
2555
2556         Reviewed by Alexey Proskuryakov.
2557
2558         * QueueStatusServer/app.yaml: We do not need to maintain SVN revision here because of 
2559         difference between new appscale and old Google App Engine implementation.
2560         * TestResultServer/app.yaml: Same.
2561         * TestResultServer/static-dashboards/builders.jsonp: Added OSX El Capitan support.
2562
2563 2015-09-29  Daniel Bates  <dabates@apple.com>
2564
2565         configure-xcode-for-ios-development does not work with Xcode 7
2566         https://bugs.webkit.org/show_bug.cgi?id=149640
2567
2568         Reviewed by Alexey Proskuryakov.
2569
2570         When Xcode 7 is installed, running configure-xcode-for-ios-development dies with an error
2571         because it cannot find the Xcode specification files for iOS simulator and device. These
2572         files have moved to a new location in Xcode 7 distribution. Moreover we must add the
2573         relevant definitions to the Xcode 7 specification files directly as opposed to creating
2574         new specification files with the added definitions (as we did in older versions of Xcode)
2575         in order for Xcode 7 to honor these definitions.
2576
2577         * Scripts/configure-xcode-for-ios-development: Sorted forward declarations.
2578         (updateXcodeSpecificationFilesForSDKIfNeeded): Added.
2579         (updateXcode7SpecificationFile): Added.
2580         (createLegacyXcodeSpecificationFilesForSDKIfNeeded): Formerly named createXcodeSpecificationFilesForSDKIfNeeded.
2581         (writeXcodeSpecification): Moved congratulations line to caller so as to write out the
2582         appropriate success message.
2583         (mergeXcodeSpecificationWithSpecificationAndId): Formerly named createXcodeSpecificationFromSpecificationAndId.
2584         (createXcodeSpecificationFilesForSDKIfNeeded): Deleted.
2585         (createXcodeSpecificationFromSpecificationAndId): Deleted.
2586
2587 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
2588
2589         [Win] Allow 'prepare-ChangeLog' to be used without Cygwin
2590         https://bugs.webkit.org/show_bug.cgi?id=149639
2591
2592         Reviewed by Alex Christensen.
2593
2594         * Scripts/VCSUtils.pm:
2595         (exitStatus): Use 'isWindows()' method.
2596         (isSVNVersion16OrNewer): 'eval' is not needed here, and just causes
2597         an error. This method could probably just go away.
2598         (normalizePath): Leave Windows (or Unix) paths as platform paths, rather than
2599         always changing to Unix style. 
2600         (unixPath): Added. Needed so Windows can always show a Unix path in the
2601         ChangeLog file.
2602         (changeLogName): Work around the fact that 'getpwuid' is not available on
2603         a pure Windows build of Perl.
2604         * Scripts/prepare-ChangeLog:
2605         (generateFunctionLists): Normalize path received from 'svn' in case it's a Unix
2606         path on Windows.
2607         (svnUpdateCommand): Added helper function. Needed because Windows Perl does not
2608         support using arrays for 'open' arguments.
2609         (resolveChangeLogsPath): Ditto.
2610         (resolveConflictedChangeLogs): Use new helper functions.
2611         (generateNewChangeLogs): Force Windows to use Unix paths in ChangeLog output.
2612         (diffCommand): Use double-quotes for paths, since Windows doesn't understand single
2613         quotes. Unix systems are happy either way.
2614         (statusCommand): Ditto.
2615         * Scripts/webkitdirs.pm:
2616         (launcherName): Drive-by fix. WinLauncher was renamed to MiniBrowser some time ago.
2617
2618 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
2619
2620         [Win] Unreviewed 64-bit build fix after switch to CMake.
2621
2622         * Scripts/webkitdirs.pm:
2623         (determineIsWin64FromArchitecture): Added.
2624
2625 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2626
2627         printing does not use minimum page zoom factor
2628         https://bugs.webkit.org/show_bug.cgi?id=108507
2629
2630         Reviewed by Darin Adler.
2631
2632         WebKitTestRunner always takes the snapshots from the UI process
2633         (expect for IOS), so in the case of printing, the layout in the
2634         web view is not the expected one. When printing, we need to take
2635         the snapshot in the web process and ensure it's rendered with a
2636         PrintContext.
2637
2638         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2639         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
2640         kWKSnapshotOptionsPrinting option to
2641         WKBundlePageCreateSnapshotWithOptions() when printing.
2642
2643 2015-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2644
2645         [WTR] Pixel tests generate the snapshots twice in Web and UI processes
2646         https://bugs.webkit.org/show_bug.cgi?id=149595
2647
2648         Reviewed by Tim Horton.
2649
2650         All ports except IOS implement
2651         PlatformWebView::windowSnapshotImage() to generate the snapshot
2652         for the pixel tests in the UI process. But we are still generating
2653         a snapshot for pixel tests in the Web process too, that is passed
2654         to the UI process but ignored.
2655         Whether a pixel result is needed or not, is only known by the web
2656         process depending on whether the test called dumpAsText with
2657         dumpPixels == true or not. Since the pixels are now dump in the UI
2658         process, we need to pass that information to the UI process when
2659         the test is done. For that we set a PixelResultIsPending bool
2660         parameter to the Done message, and we only add the PixelResult
2661         when UI process doesn't need to generate the pixels dump.
2662
2663         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2664         (WTR::InjectedBundle::didReceiveMessageToPage): Set
2665         m_pixelResultIsPending to false on reset.
2666         (WTR::InjectedBundle::done): Add PixelResultIsPending parameter to the
2667         Done message, and set the PixelResult if m_pixelResultIsPending is false.
2668         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2669         (WTR::InjectedBundle::setPixelResult): Set m_pixelResultIsPending to false.
2670         (WTR::InjectedBundle::setNeedsPixelResult): Set m_pixelResultIsPending.
2671         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2672         (WTR::InjectedBundlePage::dump): Only create a snapshot for IOS
2673         port.
2674         * WebKitTestRunner/TestInvocation.cpp:
2675         (WTR::TestInvocation::dumpResults): Use either the pixel result
2676         from the web process or generate a pixel result from the web view
2677         if need it.
2678         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2679         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
2680         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
2681         is created by the caller now, but the CG implementation needs to
2682         know if it's a Web or UI process snapshot.
2683         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2684         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2685         cairo surface for the given image.
2686         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2687         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2688         CGContext for the given image.
2689
2690 2015-09-28  Dean Johnson  <dean_johnson@apple.com>
2691
2692         Fix JS errors on dashboard metrics page
2693         https://bugs.webkit.org/show_bug.cgi?id=149608
2694
2695         Reviewed by Alexey Proskuryakov.
2696
2697         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Updated to use Settings.
2698         (initPlatformsByFamily): 
2699         (updateHiddenPlatforms):
2700         (parsePlatformFamily): Deleted.
2701         (updateToggleButtons): Deleted.
2702         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2703         (updateHiddenPlatforms): Added to remove errors.
2704         (initPlatformsByFamily): Added to remove errors.
2705         (unhiddenQueues): Updated to use Settings.
2706         (documentReady): Added logic to add toggle buttons to the settings menu.
2707         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
2708         (Settings.prototype.parsePlatformFamily): Moved duplicate logic from Main.js and
2709         MetricsMain.js to Settings.
2710         (Settings.prototype.updateToggleButtons): Moved duplicate logic from Main.js and
2711         MetricsMain.js to Settings.
2712         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
2713         (QueueView.prototype._updateHiddenState): Updated to use Settings.
2714
2715 2015-09-28  Aakash Jain  <aakash_jain@apple.com>
2716
2717         Appscale query fails because of missing index
2718         https://bugs.webkit.org/show_bug.cgi?id=149609
2719
2720         Reviewed by Darin Adler.
2721
2722         * QueueStatusServer/index.yaml: Added the required index.
2723
2724 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
2725
2726         [Win] Fix the 64-bit build after switch to cmake.
2727
2728         Reviewed by Alex Christensen.
2729
2730         * Scripts/webkitdirs.pm:
2731         (generateBuildSystemFromCMakeProject): Use correct arguments for cmake to
2732         run a 64-bit build.
2733
2734 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
2735
2736         [Win] Allow Windows to run test-webkitpy without Cygwin
2737         https://bugs.webkit.org/show_bug.cgi?id=149602
2738
2739         Reviewed by Alex Christensen.
2740
2741         These changes mostly shift from hard-coded paths using UNIX-style
2742         separators to Python's "os.path.join" syntax that uses the correct
2743         path separator for each platform.
2744         
2745         * Scripts/webkitpy/common/system/path.py:
2746         (cygpath): Don't pass paths through Cygpath on native Windows.
2747         * Scripts/webkitpy/port/win.py:
2748         (WinPort._path_to_apache): Use os.path.join.
2749         (WinPort._ntsd_location): Support 64-bit environment (ProgramW6432 doesn't exist
2750         in 64-bit environments).
2751         * Scripts/webkitpy/style/checker.py: Use os.path.join.
2752         * Scripts/webkitpy/style/checker_unittest.py:
2753         (GlobalVariablesTest.test_path_rules_specifier.assertNoCheck): Use os.path.join.
2754         (GlobalVariablesTest.test_path_rules_specifier): Ditto.
2755         (GlobalVariablesTest): Ditto.
2756         (GlobalVariablesTest.test_max_reports_per_category): Ditto.
2757         (CheckerDispatcherSkipTest.test_should_skip_with_warning): Ditto.
2758         (CheckerDispatcherDispatchTest.test_js_paths): Ditto.
2759         (CheckerDispatcherDispatchTest.test_json_paths): Ditto.
2760         (CheckerDispatcherDispatchTest.test_python_paths): Ditto.
2761         (CheckerDispatcherDispatchTest.test_text_paths): Ditto.
2762         (CheckerDispatcherDispatchTest.test_xml_paths): Ditto.
2763         (StyleProcessor_CodeCoverageTest._create_carriage_checker_class): Ditto.
2764         (StyleProcessor_CodeCoverageTest): Ditto.
2765         (StyleProcessor_CodeCoverageTest.test_should_process__skip_without_warning): Ditto.
2766         (StyleProcessor_CodeCoverageTest.test_should_process__skip_with_warning): Ditto.
2767         (StyleProcessor_CodeCoverageTest.test_should_process__true_result): Ditto.
2768         * Scripts/webkitpy/w3c/test_parser_unittest.py: Uses os.path.join rather than
2769         manual string concatenation of paths.
2770
2771 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
2772
2773         Add bugzilla addresses of committers to contributors.json
2774         https://bugs.webkit.org/show_bug.cgi?id=149520
2775
2776         Reviewed by Darin Adler.
2777
2778         * Scripts/webkitpy/common/config/contributors.json:
2779
2780 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
2781
2782         validate-committer-lists -b shouldn't need edituser privileges
2783         https://bugs.webkit.org/show_bug.cgi?id=149519
2784
2785         Reviewed by Darin Adler.
2786
2787         * Scripts/validate-committer-lists:
2788         (CommitterListBugzillaChecker._has_invalid_bugzilla_email):
2789         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2790         (BugzillaQueries.is_invalid_bugzilla_email):
2791         (BugzillaQueries): Deleted.
2792         (BugzillaQueries.fetch_logins_matching_substring): Deleted.
2793
2794 2015-09-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2795
2796         Unreviewed. Gardening: skip media stream tests failing after r190262.
2797
2798         * Scripts/run-gtk-tests:
2799         (TestRunner):
2800
2801 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
2802
2803         [Mac] USE_INTERNAL_SDK is used undefined in tools projects
2804         https://bugs.webkit.org/show_bug.cgi?id=149571
2805
2806         Reviewed by Dan Bernstein.
2807
2808         Use the same pattern as in Source directory configurations (so, also get rid of AspenFamily.xcconfig). 
2809
2810         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2811         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2812         * LayoutTestRelay/Configurations/Base.xcconfig:
2813         * MiniBrowser/Configurations/Base.xcconfig:
2814         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2815         * TestWebKitAPI/Configurations/Base.xcconfig:
2816         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2817         * WebEditingTester/Configurations/Base.xcconfig:
2818         * WebEditingTester/Configurations/DebugRelease.xcconfig:
2819         * WebKitTestRunner/Configurations/Base.xcconfig:
2820         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2821         * WebKitTestRunner/iOS.xcconfig: Removed.
2822
2823 2015-09-25  Eric Carlson  <eric.carlson@apple.com>
2824
2825         Clean up user media request internal API
2826         https://bugs.webkit.org/show_bug.cgi?id=149527
2827
2828         Reviewed by Tim Horton.
2829
2830         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
2831         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): Update for API changes.
2832
2833         * WebKitTestRunner/TestController.cpp:
2834         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Ditto.
2835
2836 2015-09-25  Simon Fraser  <simon.fraser@apple.com>
2837
2838         [iOS WK2] Add viewport tests and fix runUIScript() timing issues
2839         https://bugs.webkit.org/show_bug.cgi?id=149577
2840
2841         Reviewed by Tim Horton.
2842         
2843         When calling testRunner.runUIScript() from a page load event, the script could run
2844         in the UI process before the current remote layer tree transaction had been handled
2845         there. This meant that runUIScript() could query state which was about to change.
2846         
2847         Fix by delaying the execution of the UI script until a layer tree transaction has
2848         been handled by the UI process, leveraging the existing DrawingAreaProxy::dispatchAfterEnsuringDrawing().
2849
2850         * WebKitTestRunner/TestInvocation.cpp:
2851         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2852         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
2853         * WebKitTestRunner/TestInvocation.h:
2854
2855 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
2856
2857         [Mac] Media tests start to time out after a few days of bot uptime
2858         https://bugs.webkit.org/show_bug.cgi?id=149468
2859
2860         Reviewed by Darin Adler.
2861
2862         Delete cache directory in addition to the temporary one. Don't delete /private/tmp/MediaCache,
2863         as it's not longer used by tests. Set TMPDIR and DIRHELPER_USER_DIR_SUFFIX to make
2864         all temporary and cache files go to a custom location.
2865
2866         * Scripts/webkitpy/port/base.py:
2867         * Scripts/webkitpy/port/driver.py:
2868         * Scripts/webkitpy/port/mac.py:
2869         * Scripts/webkitpy/port/win.py:
2870         (WinPort._driver_tempdir_for_environment): Deleted unused function.
2871
2872 2015-09-25  Dan Bernstein  <mitz@apple.com>
2873
2874         Removed MiniBrowser.entitlements.
2875
2876         Rubber-stamped by Anders Carlsson.
2877
2878         The entitlements weren’t used anyway.
2879
2880         * MiniBrowser/MiniBrowser.entitlements: Removed.
2881         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2882
2883 2015-09-24  Daniel Bates  <dabates@apple.com>
2884
2885         Add WebKitSystemInterface for iOS 9.0
2886         https://bugs.webkit.org/show_bug.cgi?id=149550
2887
2888         Rubber-stamped by Alexey Proskuryakov.
2889
2890         * Scripts/copy-webkitlibraries-to-product-directory:
2891
2892 2015-09-24  Daniel Bates  <dabates@apple.com>
2893
2894         Support building for arbitrary architectures
2895         https://bugs.webkit.org/show_bug.cgi?id=149539
2896
2897         Reviewed by Alexey Proskuryakov.
2898
2899         Teach buildbot to pass the architectures associated with the builder to build-webkit
2900         when building on OS X and iOS. As a side effect of this change we now support building
2901         universal binaries when multiples architectures are specified.
2902
2903         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2904         (CompileWebKit.start):
2905
2906 2015-09-24  Daniel Bates  <dabates@apple.com>
2907
2908         Fix the build after <http://trac.webkit.org/changeset/190212>
2909         (http://trac.webkit.org/changeset/190212)
2910
2911         I inadvertently did not remove the fullPlatform argument from one of the callers of archiveBuiltProduct().
2912
2913         * BuildSlaveSupport/built-product-archive:
2914         (main):
2915
2916 2015-09-24  Daniel Bates  <dabates@apple.com>
2917
2918         Support running unit tests on iOS Simulator test bot
2919         https://bugs.webkit.org/show_bug.cgi?id=149536
2920
2921         Reviewed by Alexey Proskuryakov.
2922
2923         Implements support for running unit tests on a iOS test bot. At the time of writing,
2924         the script run-api-tests supports running unit tests on Mac, Windows and iOS Simulator.
2925
2926         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2927         (RunUnitTests.start): Append appropriate command line flag when invoking script run-api-tests.
2928         (TestFactory.__init__): Add step RunUnitTests when the test bot is for the iOS Simulator platform.
2929
2930 2015-09-24  Daniel Bates  <dabates@apple.com>
2931
2932         Add support infrastructure for OpenSource iOS builders and testers
2933         https://bugs.webkit.org/show_bug.cgi?id=149534
2934
2935         Reviewed by Darin Adler.
2936
2937         Towards setting up OpenSource iOS build bots, teach buildbot and its support
2938         scripts about iOS.
2939
2940         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2941         (appendCustomBuildFlags): Require the caller to pass parameter fullPlatform and append
2942         --ios-simulator or --device for a builder/tester whose full platform name begins with
2943         "ios-simulator" or "ios", respectively.
2944         (RunJavaScriptCoreTests.start): Pass the full platform name to appendCustomBuildFlags().
2945         * BuildSlaveSupport/built-product-archive:
2946         (main): Pass the full platform name to determineWebKitBuildDirectory().
2947         (determineWebKitBuildDirectory): Call script webkit-build-directory with the appropriate
2948         command line flag when building for iOS.
2949         (archiveBuiltProduct): Use the same logic for iOS as we do for Mac. Also, remove unused
2950         parameter fullPlatform. This parameter was originally added in r125066 to support the
2951         Chromium Android port, which has since been removed from the OpenSource WebKit Project.
2952         (extractBuiltProduct): Use the same logic for iOS as we do for Mac.
2953         * BuildSlaveSupport/clean-build:
2954         (main): Call script webkit-build-directory with the appropriate command line flag when
2955         building for iOS.
2956         * BuildSlaveSupport/delete-stale-build-files:
2957         (main): Use the same logic for iOS as we do for Mac.
2958         (webkitBuildDirectory): Call script webkit-build-directory with the appropriate command line
2959         flag when building for iOS.
2960         * BuildSlaveSupport/test-result-archive:
2961         (archiveTestResults): Use the same logic for iOS as we do for Mac.
2962
2963 2015-09-24  Daniel Bates  <dabates@apple.com>
2964
2965         Remove Chromium-specific changes to script built-product-archive
2966         https://bugs.webkit.org/show_bug.cgi?id=149530
2967
2968         Rubber-stamped by Csaba Osztrogonác.
2969
2970         Reverts changes made in r113074 and r113067 to support Chromium testers. The
2971         Chromium code has long since been removed from the OpenSource WebKit Project.
2972
2973         * BuildSlaveSupport/built-product-archive:
2974         (createZipManually):
2975         (createZip):
2976         (archiveBuiltProduct):
2977
2978 2015-09-24  Dan Bernstein  <mitz@apple.com>
2979
2980         Build fix.
2981
2982         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2983
2984 2015-09-24  Mark Lam  <mark.lam@apple.com>
2985
2986         Unreviewed. Make Lucas Forschler a WebKit reviewer.
2987
2988         * Scripts/webkitpy/common/config/contributors.json:
2989
2990 2015-09-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2991
2992         Unreviewed. Fix GObject DOM API breaks after r190120.
2993
2994         Bring back code removed in r169931 to handle documentation of
2995         deleted classes.
2996
2997         * gtk/webkitdom.py:
2998         (WebKitDOMDocGenerator):
2999         (WebKitDOMDocGenerator.write_deleted_classes):
3000         (WebKitDOMDocGenerator.generate):
3001         (write_deleted_classes):
3002         (WebKitDOMDocGeneratorSections._deleted_class):
3003         (WebKitDOMDocGeneratorSections._deleted_class.in):
3004         (WebKitDOMDocGeneratorSections.write_deleted_classes):
3005         (WebKitDOMDocGeneratorSections.write_deleted_classes.with):
3006
3007 2015-09-23  Myles C. Maxfield  <mmaxfield@apple.com>
3008
3009         [Cocoa] [Font Features] Implement font-variant-*
3010         https://bugs.webkit.org/show_bug.cgi?id=148413
3011
3012         Reviewed by Darin Adler.
3013
3014         Update test font to use "lnum" feature.
3015
3016         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
3017         (Generator::appendGSUBTable):
3018
3019 2015-09-22  Andy Estes  <aestes@apple.com>
3020
3021         ContentFiltering.AllowDownloadAfterAddData is very flaky
3022         https://bugs.webkit.org/show_bug.cgi?id=148885
3023         <rdar://problem/22729563>
3024
3025         Reviewed by Alexey Proskuryakov.
3026
3027         The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:,
3028         but there is no guarantee of this. For tests that should allow a download, spin the runloop until
3029         -_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures.
3030
3031         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3032         (downloadTest):
3033
3034 2015-09-22  Alexey Proskuryakov  <ap@apple.com>
3035
3036         Mavericks: Media tests start to time out after a few days of bot uptime
3037         https://bugs.webkit.org/show_bug.cgi?id=149468
3038
3039         Reviewed by Chris Dumez.
3040
3041         * Scripts/webkitpy/port/base.py:
3042         * Scripts/webkitpy/port/driver.py:
3043         * Scripts/webkitpy/port/mac.py:
3044
3045 2015-09-22  Nan Wang  <n_wang@apple.com>
3046
3047         Unreviewed, add myself to the committers list.
3048
3049         * Scripts/webkitpy/common/config/contributors.json:
3050
3051 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
3052
3053         Remove 'nullable' to fix older iOS builds.
3054
3055         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3056         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
3057
3058 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
3059
3060         [Win] Show tiled drawing debug overlay on Windows
3061         https://bugs.webkit.org/show_bug.cgi?id=149426
3062
3063         Reviewed by Dean Jackson.
3064
3065         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Add new menu option.
3066         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Ditto.
3067         * MiniBrowser/win/Common.cpp:
3068         (::ToggleMenuItem): Recognize new menu item and toggle the 'showTiledScrollingIndicator'
3069         flag if needed.
3070         * MiniBrowser/win/MiniBrowser.h: Update to use new IWebPreferencesPrivate3 class.
3071
3072 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
3073
3074         [Win] Use command-line argument to launch in regular or High DPI mode.
3075         https://bugs.webkit.org/show_bug.cgi?id=149417
3076
3077         Reviewed by Dean Jackson.
3078
3079         * MiniBrowser/win/Common.cpp:
3080         (parseCommandLine): Ignore the '--highDPI' argument. It's used at the
3081         very start of execution, before the MiniBrowser.dll is loaded.
3082         * win/DLLLauncher/DLLLauncherMain.cpp:
3083         (shouldUseHighDPI): Check for '--highDPI', and use this mode if
3084         present. On WinCairo, always use High DPI.
3085
3086 2015-09-21  Ryosuke Niwa  <rniwa@webkit.org>
3087
3088         32-bit Mac build fix attempt after r190065.
3089
3090         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3091
3092 2015-09-21  Alexey Proskuryakov  <ap@apple.com>
3093
3094         [OS X] Update for Xcode 7.0 on Yosemite
3095         https://bugs.webkit.org/show_bug.cgi?id=149389
3096
3097         Reviewed by Dan Bernstein.
3098
3099         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
3100         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
3101         Removed unneeded declarations - conforming to a protocol is sufficient.
3102
3103         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3104         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
3105         Changed the definitions to be compiled whenever the SDK requires it (so we will have
3106         dead code compiled in when building for 10.10 with 10.11 SDK, somewhat unfortunately).
3107
3108 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
3109
3110         Add the ability for tests to run script in the UI process in WebKitTestRunner
3111         https://bugs.webkit.org/show_bug.cgi?id=149356
3112
3113         Reviewed by Tim Horton.
3114
3115         This change adds testRunner.runUIScript(script, callback), which allows a test
3116         to execute script in a JSContext which runs in the UI process. That context
3117         has bindings exposed through the UIScriptController interface; currently one test
3118         function, and some iOS-specific functions are included. UIScriptController can be
3119         async with a callback, and runUIScript() itself is asynchronous. When the UI 
3120         script is complete, it calls uiController.uiScriptComplete(result), where 'result'
3121         is a string passed back to the web process, and given to the runUIScript()
3122         callback function.
3123         
3124         Thanks to Gyuyoung Kim for help with the Gtk/Efl build.
3125
3126         * WebKitTestRunner/DerivedSources.make: Build UIScriptController.idl.
3127         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add runUIScript().
3128         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3129         (WTR::InjectedBundle::didReceiveMessageToPage): When the UI-side script is
3130         complete, call back into TestRunner.
3131         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3132         (WTR::nextUIScriptCallbackID):
3133         (WTR::TestRunner::runUIScript): Post a message to the injected bundle to run the UI script.
3134         (WTR::TestRunner::runUIScriptCallback): When the UI script is done, execute its callback function.
3135         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3136         * WebKitTestRunner/PlatformWebView.h:
3137         * WebKitTestRunner/TestController.cpp:
3138         (WTR::updateTestOptionsFromTestHeader):
3139         (WTR::TestController::testOptionsForTest): Support "useFlexibleViewport" as a test argument.
3140         (WTR::shouldUseFixedLayout): Deleted. Moved to a TestInvocation function.
3141         * WebKitTestRunner/TestInvocation.cpp:
3142         (WTR::TestInvocation::shouldUseFixedLayout):
3143         (WTR::TestInvocation::shouldUseThreadedScrolling):
3144         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3145         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3146         (WTR::TestInvocation::runUISideScript): Run the UI-side script!
3147         (WTR::TestInvocation::uiScriptDidComplete): Send a message back to the injected bundle.
3148         * WebKitTestRunner/TestInvocation.h:
3149         * WebKitTestRunner/TestOptions.h:
3150         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3151         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3152         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
3153         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Added.
3154         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
3155         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
3156         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
3157         (-[TestRunnerWKWebView onDidEndZooming:]): Allow a test to hook into the end of zooming.
3158         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3159         (WTR::PlatformWebView::PlatformWebView): Make a TestRunnerWKWebView on iOS.
3160         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Added.
3161         (WTR::UIScriptController::doAsyncTask):
3162         (WTR::UIScriptController::zoomToScale):
3163         (WTR::UIScriptController::zoomScale):
3164         (WTR::UIScriptController::minimumZoomScale):
3165         (WTR::UIScriptController::maximumZoomScale):
3166         (WTR::UIScriptController::contentVisibleRect):
3167         * WebKitTestRunner/mac/EventSenderProxy.mm:
3168         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3169         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Deleted.
3170         * WebKitTestRunner/mac/TestControllerMac.mm:
3171         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
3172         (WTR::shouldUseThreadedScrolling): Deleted. Moved to TestInvocation.
3173         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
3174         * WebKitTestRunner/uiscriptcontext/UIScriptContext.cpp: Added. Owns the JS context in the UI process.
3175         (UIScriptContext::UIScriptContext):
3176         (UIScriptContext::~UIScriptContext):
3177         (UIScriptContext::runUIScript): Entrypoint to running the UI script. If the script didn't do anything
3178         asynchronous, call the callback.
3179         (UIScriptContext::nextTaskCallbackID):
3180         (UIScriptContext::prepareForAsyncTask): Do setup for one async task (i.e. a UIScriptController function
3181         that has a callback). Has to store the callbackID of the script, so code called from the completion
3182         callback knows which UI script invoked it.
3183         (UIScriptContext::asyncTaskComplete): Called when one task is finished.
3184         (UIScriptContext::uiScriptComplete):
3185         (UIScriptContext::objectFromRect): Make a JS object from a rect.
3186         * WebKitTestRunner/uiscriptcontext/UIScriptContext.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
3187         (WTR::UIScriptContext::hasOutstandingAsyncTasks):
3188         * WebKitTestRunner/uiscriptcontext/UIScriptController.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
3189         (WTR::UIScriptController::UIScriptController):
3190         (WTR::UIScriptController::makeWindowObject):
3191         (WTR::UIScriptController::wrapperClass):
3192         (WTR::UIScriptController::doAsyncTask):
3193         (WTR::UIScriptController::zoomToScale):
3194         (WTR::UIScriptController::zoomScale):
3195         (WTR::UIScriptController::minimumZoomScale):
3196         (WTR::UIScriptController::maximumZoomScale):
3197         (WTR::UIScriptController::contentVisibleRect):
3198         (WTR::UIScriptController::uiScriptComplete):
3199         * WebKitTestRunner/uiscriptcontext/UIScriptController.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
3200         (WTR::UIScriptController::create):
3201         * WebKitTestRunner/uiscriptcontext/bindings/UIScriptController.idl: Copied from Tools/WebKitTestRunner/TestOptions.h.
3202
3203 2015-09-21  Tim Horton  <timothy_horton@apple.com>
3204
3205         Turn on threaded scrolling by default in the tests
3206         https://bugs.webkit.org/show_bug.cgi?id=149377
3207
3208         Reviewed by Simon Fraser.
3209
3210         * WebKitTestRunner/mac/TestControllerMac.mm:
3211         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
3212         (WTR::shouldUseThreadedScrolling): Deleted.
3213         Turn on threaded scrolling by default.
3214
3215 2015-09-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3216
3217         [GTK] run-gtk-tests doesn't provide feedback about crashing google tests
3218         https://bugs.webkit.org/show_bug.cgi?id=149252
3219
3220         Reviewed by Darin Adler.
3221
3222         In case of glib tests the test runner notifies about tests
3223         crashing, but for google tests we don't get any feedback, which
3224         means that in case of a test crashing we get a list of **PASS**
3225         messages and at the summary we are notified that the test suite
3226         has failed, but it's impossible to know which test cases have failed.
3227
3228         * Scripts/run-gtk-tests:
3229         (TestRunner._run_google_test): Add a **CRASH** message if test
3230         case crashed.
3231
3232 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
3233
3234         WebKitTestRunner can leak user content script results between tests
3235         https://bugs.webkit.org/show_bug.cgi?id=149391
3236
3237         Reviewed by Sam Weinig.
3238
3239         Move WKBundlePageRemoveAllUserContent call so that it's executed before loading
3240         about:blank, and thus about:blank doesn't have unintended side effects.
3241
3242         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3243         (WTR::InjectedBundle::beginTesting):
3244         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3245         (WTR::InjectedBundlePage::resetAfterTest):
3246
3247 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
3248
3249         [Mac, iOS] AccessibilityController doesn't uninstall global notification handler
3250         https://bugs.webkit.org/show_bug.cgi?id=149384
3251
3252         Reviewed by Chris Fleizach.
3253
3254         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
3255         (AccessibilityController::addNotificationListener): Fixed a leak, and cleaned up the code.
3256         (AccessibilityController::platformResetToConsistentState): Actually remove the handler,
3257         regardless of whether someone else holds a reference (we also call -stopListening in
3258         -dealloc).
3259
3260         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3261         (AccessibilityController::platformResetToConsistentState):
3262         (AccessibilityController::addNotificationListener):
3263         Ditto.
3264
3265 2015-09-20  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3266
3267         Remove XHR_TIMEOUT compilation guard
3268         https://bugs.webkit.org/show_bug.cgi?id=149260
3269
3270         Reviewed by Benjamin Poulain.
3271
3272         * Scripts/webkitperl/FeatureList.pm:
3273
3274 2015-09-19  Dan Bernstein  <mitz@apple.com>
3275
3276         Attempted build fix.
3277
3278         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
3279
3280 2015-09-18  Commit Queue  <commit-queue@webkit.org>
3281
3282         Unreviewed, rolling out r189908.
3283         https://bugs.webkit.org/show_bug.cgi?id=149368
3284
3285         Broke run-webkit-tests --pixel (Requested by ap on #webkit).
3286
3287         Reverted changeset:
3288
3289         "printing does not use minimum page zoom factor"
3290         https://bugs.webkit.org/show_bug.cgi?id=108507
3291         http://trac.webkit.org/changeset/189908
3292
3293 2015-09-18  Andy Estes  <aestes@apple.com>
3294
3295         [iOS] did{Start,Finish}LoadForQuickLookDocumentInMainFrame is never called on WKNavigationDelegate
3296         https://bugs.webkit.org/show_bug.cgi?id=149360
3297
3298         Reviewed by Tim Horton.
3299
3300         Added an API test.
3301
3302         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3303         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Added.
3304         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3305         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3306         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]):
3307         (TEST):
3308         * TestWebKitAPI/ios/pages.pages: Added.
3309
3310 2015-09-18  Nan Wang  <n_wang@apple.com>
3311
3312         AX: Implement ARIA 1.1 @aria-current on iOS
3313         https://bugs.webkit.org/show_bug.cgi?id=149297
3314
3315         Reviewed by Chris Fleizach.
3316
3317         Added support to test aria-current on iOS.
3318
3319         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3320         (AccessibilityUIElement::stringAttributeValue):
3321         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3322         (WTR::AccessibilityUIElement::stringAttributeValue):
3323
3324 2015-09-18  Alexey Proskuryakov  <ap@apple.com>
3325
3326         iOS WebKitTestRunner frequently crashes in WKContextGetIconDatabase
3327         https://bugs.webkit.org/show_bug.cgi?id=149352
3328
3329         Reviewed by Simon Fraser.
3330
3331         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
3332         m_context can be null. This may indicate a bug in webkitpy too, but
3333         WebKitTestRunner should handle this situation nicely, there is nothing intrinsically
3334         wrong with opening and immediately closing it.
3335
3336 2015-09-18  Daniel Bates  <dabates@apple.com>
3337
3338         isGitSVNDirectory() returns true when Git is not installed
3339         https://bugs.webkit.org/show_bug.cgi?id=149351
3340
3341         Reviewed by Alexey Proskuryakov.
3342
3343         Fixes an issue where VCSUtils::isGitSVNDirectory() returns true for any arbitrary directory if
3344         Git is not installed on the machine.
3345
3346         * Scripts/VCSUtils.pm:
3347         (isGitSVNDirectory): Ensure that `git config --get svn-remote.svn.fetch 2>& 1` exits with
3348         status code 0 (success).
3349
3350 2015-09-18  Alex Christensen  <achristensen@webkit.org>
3351
3352         Prevent build-webkit from building four times on Windows 
3353         https://bugs.webkit.org/show_bug.cgi?id=149336
3354
3355         Reviewed by Brent Fulgham.
3356
3357         * Scripts/build-webkit:
3358         Move the Windows code out of the for loop iterating over each subdirectory to be build.
3359         They're built all at once.
3360         * Scripts/webkitdirs.pm:
3361         (buildVisualStudioProject):
3362         (cmakeGeneratedBuildfile):
3363         Don't generate the Visual Studio solution if it already exists.
3364         It will run CMake again if necessary.
3365
3366 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
3367
3368         [iOS WK2] WTR fails to set the key window in the UIKit sense
3369         https://bugs.webkit.org/show_bug.cgi?id=149325
3370
3371         Reviewed by Tim Horton.
3372
3373         -[WebKitTestRunnerWindow isKeyWindow] just returned _platformWebView->windowIsKey().
3374         This causes UIKit to bypass code that actually sets the key window, resulting in
3375         [UIAppliation sharedApplication].keyWindow always being nil.
3376
3377         Fix by PlatformWebView::setWindowIsKey() actually call -makeKeyWindow, and having
3378         -[WebKitTestRunnerWindow isKeyWindow] call super.
3379
3380         * WebKitTestRunner/PlatformWebView.h:
3381         (WTR::PlatformWebView::setWindowIsKey): Deleted.
3382         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3383         (WTR::PlatformWebView::setWindowIsKey):
3384         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3385         (WTR::PlatformWebView::setWindowIsKey):
3386         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3387         (-[WebKitTestRunnerWindow isKeyWindow]):
3388         (WTR::PlatformWebView::PlatformWebView):
3389         (WTR::PlatformWebView::~PlatformWebView):
3390         (WTR::PlatformWebView::setWindowIsKey):
3391         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3392         (WTR::PlatformWebView::setWindowIsKey):
3393
3394 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
3395
3396         [iOS WK2] When loading viewport tests, use the normal web page viewport configuration
3397         https://bugs.webkit.org/show_bug.cgi?id=149321
3398
3399         Reviewed by Tim Horton.
3400         
3401         InjectedBundlePage::platformDidStartProvisionalLoadForFrame() unconditionally 
3402         enabled the "testing" viewport configuration, which disables page scaling.
3403         
3404         If we're running viewport tests, we want the normal web page configuration.
3405         Do that by passing a flag in the dictionary sent to InjectedBundle::beginTesting(),
3406         based on whether the test is in a "viewport" directory.
3407
3408         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3409         (WTR::InjectedBundle::beginTesting):
3410         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
3411         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Deleted.
3412         * WebKitTestRunner/TestInvocation.cpp:
3413         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
3414         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
3415         (WTR::TestInvocation::shouldMakeViewportFlexible):
3416         (WTR::TestInvocation::invoke):
3417         * WebKitTestRunner/TestInvocation.h:
3418         * WebKitTestRunner/ios/TestControllerIOS.mm:
3419         (WTR::TestController::platformConfigureViewForTest):
3420         (WTR::shouldMakeViewportFlexible): Deleted.
3421
3422 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
3423
3424         Give iOS WebKitTestRunner a launch storyboard
3425         https://bugs.webkit.org/show_bug.cgi?id=149314
3426
3427         Reviewed by Dan Bates.
3428         
3429         Add a launch storyboard to iOS WebKitTestRunner so that Springboard recognizes
3430         that it's been built for specific device configurations, and puts the window
3431         at the top of the screen. This simplifies coordinate conversions in a future patch.
3432
3433         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3434         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
3435         * WebKitTestRunner/ios/Launch.storyboard: Added.
3436
3437 2015-09-17  Myles C. Maxfield  <mmaxfield@apple.com>
3438
3439         Update licence in r189890
3440         https://bugs.webkit.org/show_bug.cgi?id=149306
3441
3442         Reviewed by Dean Jackson.
3443
3444         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
3445         * FontWithFeatures/FontWithFeatures/FontCreator.h:
3446         * FontWithFeatures/FontWithFeatures/main.cpp:
3447
3448 2015-09-17  Mark Lam  <mark.lam@apple.com>
3449
3450         Add the ability to skip JIT stress tests in run-javascriptcore-tests.
3451         https://bugs.webkit.org/show_bug.cgi?id=149285
3452
3453         Reviewed by Saam Barati.
3454
3455         Just need to add an option to pass --no-jit to run-jsc-stress-test.
3456
3457         * Scripts/run-javascriptcore-tests:
3458         (runJSCStressTests):
3459
3460 2015-09-17  Alex Christensen  <achristensen@webkit.org>
3461
3462         Switch AppleWin build to use CMake
3463         https://bugs.webkit.org/show_bug.cgi?id=149163
3464
3465         Reviewed by Brent Fulgham.
3466
3467         * Scripts/build-webkit:
3468         * Scripts/run-api-tests:
3469         (runTest):
3470         (listAllTests):
3471         (prepareEnvironmentForRunningTestTool):
3472         (testToolPaths):
3473         (testToolPath): Deleted.
3474         Run the API tests as separate executables on Windows.
3475         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
3476         * Scripts/webkitdirs.pm:
3477         (checkRequiredSystemConfig):
3478         (jhbuildWrapperPrefixIfNeeded):
3479         (generateBuildSystemFromCMakeProject):
3480         Fix configuration quirks.
3481
3482 2015-09-17  Dean Johnson  <dean_johnson@apple.com>
3483
3484         Added toggle options for hiding and showing certain platform families on the dashboard.
3485         https://bugs.webkit.org/show_bug.cgi?id=148403
3486
3487         Reviewed by David Kilzer.
3488
3489         This patch removes "hiddenPlatforms" from use in the code and local storage. We also removed
3490         individual hide/show buttons for platforms because we've added toggle options to hide/show entire
3491         families. Examples of these are "mac", "ios", and "linux". "Show All Platforms" was also removed
3492         in lieu of an "all" button in the toggle menu.
3493
3494         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3495         (parsePlatformFamily): Helper function to parse out a platform family.
3496         (initPlatformsByFamily): Initializes platformsByFamily, which organizes platforms on the
3497         page by platformsByFamily[<family>] = <list of platforms belonging to that family>.
3498         (updateToggleButtons): Updates the status of the toggle buttons.
3499         (updateHiddenPlatforms): Changed to work with the new implementation of hiding/showing platforms.
3500         (documentReady): Added creation of toggle buttons.
3501         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
3502         (unhiddenQueues): Updated to search by platform family instead of the individual platform name.
3503         (documentReady): Changed hiddenPlatforms => hiddenPlatformFamilies.
3504         (updateHiddenPlatforms): Deleted. After removing the individual hide button code, 
3505         this did the exact same thing as the updateHiddenPlatforms in Scripts/Main.js so it was removed.
3506         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
3507         (QueueView): Updated to use hiddenPlatformFamilies.
3508         (QueueView.prototype._updateHiddenState): Updated to use hiddenPlatformFamilies.
3509         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
3510         (Settings.prototype.toggleHiddenPlatformFamily): Renamed function and some variables.
3511         (Settings.prototype.clearHiddenPlatformFamilies): Now uses hiddenPlatformFamilies for events.
3512         (Settings.prototype.toggleHiddenPlatform): Deleted.
3513         (Settings.prototype.clearHiddenPlatforms): Deleted.
3514         (Settings.prototype.toggleShowPlatformFamily): Deleted.
3515         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3516         (div.cellButton, div.accessibilityButton, div.platformFamilyToggleButton):
3517         (div.cellButton.unhide, div.accessibilityButton.unhide, div.platformFamilyToggleButton.unhide):
3518         (.settings-visible div.settingsWrapper.hide, .settings-visible div.settingsWrapper):
3519         (table.queue-grid tr.headers th):
3520         (div.settingsWrapper.hide):
3521         (div.settingsWrapper):
3522         (div.familyToggleWrapper):
3523         (div.platformFamilyToggleButton):
3524         (div.platformFamilyShowToggleButton:not(:last-child)):
3525         (div.familyShown):
3526         (div.accessibilityButton):
3527         (div.cellButton, div.accessibilityButton): Added platformFamilyToggleButton class.
3528         (div.cellButton.unhide, div.accessibilityButton.unhide): Added platformFamilyToggleButton class.
3529         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide): Added
3530         platformFamilyToggleButton and settingsWrapper class.
3531         (.accessibilityButton): Deleted.
3532
3533 2015-09-17  Tim Horton  <timothy_horton@apple.com>
3534
3535         Add a test ensuring that scrolling in the middle of a page can't start a swipe gesture
3536         https://bugs.webkit.org/show_bug.cgi?id=148904
3537
3538         Reviewed by Myles Maxfield.
3539
3540         * WebKitTestRunner/TestController.cpp:
3541         (WTR::parseBooleanTestHeaderValue):
3542         (WTR::updateViewOptionsFromTestHeader):
3543         Check for the key "useThreadedScrolling".
3544         Add some code to check for "true" and "false" for boolean options.
3545
3546         (WTR::TestController::viewOptionsForTest):
3547         Apply the test's overrides last, even after the platform's.
3548
3549 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
3550
3551         printing does not use minimum page zoom factor
3552         https://bugs.webkit.org/show_bug.cgi?id=108507
3553
3554         Reviewed by Darin Adler.
3555
3556         WebKitTestRunner always takes the snapshots from the UI process
3557         (expect for IOS), so in the case of printing, the layout in the
3558         web view is not the expected one. When printing, we need to take
3559         the snapshot in the web process and ensure it's rendered with a
3560         PrintContext.
3561
3562         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3563         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
3564         kWKSnapshotOptionsPrinting option to
3565         WKBundlePageCreateSnapshotWithOptions() when printing. When not
3566         printing, don't even create the snapshot, since it will be ignored
3567         by the UI process that always creates its own from the WebView (expect for IOS platform)
3568         * WebKitTestRunner/TestInvocation.cpp:
3569         (WTR::TestInvocation::dumpResults): Use always the snapshot image
3570         received from the web process if any when comparing pixel
3571         results. Now we only receive a snapshot from the web process in
3572         case of printing, or when platform is IOS. Otherwhise, generate
3573         the snapshot from the WebView as usual.
3574         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
3575         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
3576         is created by the caller now, but the CG implementation needs to
3577         know if it's a Web or UI process snapshot.
3578         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
3579         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
3580         cairo surface for the given image.
3581         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3582         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
3583         CGContext for the given image.
3584
3585 2015-09-16  Myles C. Maxfield  <mmaxfield@apple.com>
3586
3587         Create a font which can be used for testing font features
3588         https://bugs.webkit.org/show_bug.cgi?id=149237
3589
3590         Reviewed by Simon Fraser.
3591
3592         This patch adds a new project in the Tools/ directory which generates a font which can
3593         be used for testing font features. This is a standalone project consisting of two files:
3594         1. A file which actually generates the byte vector representing the font. This file has
3595         a single public function: std::vector<uint8_t> generateFont(). This file is not platform
3596         specific, and only relies on the C++ STL.
3597         2. A file with a main() which calls generateFont() and writes out the font, as well as
3598         uses the font to render some demonstration text into a .png file. This file is platform
3599         specific.
3600
3601         The font itself only supports the following characters:
3602         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
3603         However, the shape of these letters are either an X or a check mark.
3604
3605         The letter "A" always is a check mark.