fe7ca33f83b19ddc9a6c21f2717424cb7a70a07c
[WebKit-https.git] / Tools / ChangeLog
1 2012-03-11  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
2
3         [Qt] [WK2] Support threaded renderer in WK2
4         https://bugs.webkit.org/show_bug.cgi?id=76661
5
6         Remove disabling of threaded rendering.
7
8         Reviewed by Noam Rosenthal.
9
10         * MiniBrowser/qt/main.cpp:
11         (main):
12
13 2012-03-09  Zan Dobersek  <zandobersek@gmail.com>
14
15         [WK2] run-perf-tests should be able to run with WTR
16         https://bugs.webkit.org/show_bug.cgi?id=80042
17
18         Reviewed by Martin Robinson.
19
20         Add an option to PerfTestRunner to use WebKitTestRunner instead of
21         DumpRenderTree and add the '--no-timeout' flag to WebKitTestRunner
22         to avoid timing out when running performance tests.
23
24         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
25         (PerfTestsRunner._parse_args):
26         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
27         (WTR::InjectedBundle::InjectedBundle): Initialize m_useWaitToDumpWatchdogTimer
28         to true.
29         (WTR::InjectedBundle::didReceiveMessage): Unpack the 'BeginTest' message
30         as a dictionary containing DumpPixels and UseWaitToDumpWatchdogTimer keys.
31         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
32         (WTR::InjectedBundle::useWaitToDumpWatchdogTimer): Make m_useWaitToDumpWatchdogTimer
33         publicly accessible.
34         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
35         (WTR::LayoutTestController::waitUntilDone): Only initialize the watchdog if it
36         is required.
37         * WebKitTestRunner/TestController.cpp:
38         (WTR::TestController::TestController): Initialize m_useWaitToDumpWatchdogTimer
39         to true.
40         (WTR::TestController::initialize): Set m_useWaitToDumpWatchdogTimer to false
41         if '--no-timeout' option is present.
42         (WTR::TestController::runUntil): Translate TimeoutDuration to a proper timeout
43         value, or -1.0 if timeout should not occur.
44         * WebKitTestRunner/TestController.h:
45         (WTR::TestController::useWaitToDumpWatchdogTimer): Make m_useWaitToDumpWatchdogTimer
46         publicly accessible.
47         * WebKitTestRunner/TestInvocation.cpp:
48         (WTR::TestInvocation::invoke): Pack the 'BeginTest' message as a dictionary,
49         containing DumpPixels and UseWaitToDumpWatchdogTimer keys and corresponding values.
50         Waiting for final message should not time out if not necessary.
51         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
52         (WTR::TestController::platformRunUntil): Only set up a timeout if necessary.
53         * WebKitTestRunner/qt/TestControllerQt.cpp:
54         (WTR::TestController::platformRunUntil): Ditto.
55         * WebKitTestRunner/mac/TestControllerMac.mm:
56         (WTR::TestController::platformRunUntil): Add a FIXME, indicating functionality
57         is missing.
58         * WebKitTestRunner/win/TestControllerWin.cpp:
59         (WTR::TestController::platformRunUntil): Ditto.
60
61 2012-03-09  Jon Lee  <jonlee@apple.com>
62
63         Rename NotificationPresenter to NotificationClient
64         https://bugs.webkit.org/show_bug.cgi?id=80488
65         <rdar://problem/10965558>
66
67         Reviewed by Kentaro Hara.
68
69         Refactor to use renamed WebCore::NotificationClient.
70         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
71         (DRTDesktopNotificationPresenter::checkNotificationPermission):
72
73 2012-03-07  James Robinson  <jamesr@chromium.org>
74
75         [chromium] Deprecate renderDirectlyToWebView parameter of WebViewClient::createGraphicsContext3D()
76         https://bugs.webkit.org/show_bug.cgi?id=80523
77
78         Reviewed by Darin Fisher.
79
80         * DumpRenderTree/chromium/WebViewHost.cpp:
81         (WebViewHost::createGraphicsContext3D):
82         * DumpRenderTree/chromium/WebViewHost.h:
83         (WebViewHost):
84
85 2012-03-09  Eric Seidel  <eric@webkit.org>
86
87         build-webkit should build Source/WTF on Mac
88         https://bugs.webkit.org/show_bug.cgi?id=80728
89
90         Reviewed by Adam Barth.
91
92         We'll add other ports to this list in future commits.
93
94         * Scripts/build-webkit:
95
96 2012-03-09  Jon Lee  <jonlee@apple.com>
97
98         Add support for ENABLE(LEGACY_NOTIFICATIONS)
99         https://bugs.webkit.org/show_bug.cgi?id=80497
100
101         Reviewed by Adam Barth.
102
103         Prep for b80472: Update API for Web Notifications
104         * Scripts/build-webkit:
105         * qmake/mkspecs/features/features.prf:
106
107 2012-03-09  Ashod Nakashian  <ashodnakashian@yahoo.com>
108
109         Bash scripts should support LF endings only
110         https://bugs.webkit.org/show_bug.cgi?id=79509
111
112         Reviewed by David Kilzer.
113
114         * EWSTools/boot.sh: Added properties svn:executable and svn:eol-style.
115         * EWSTools/start-queue.sh: Added property svn:eol-style.
116         * Scripts/webkit-tools-completion.sh: Added properties svn:executable and svn:eol-style.
117         * WebKitTestRunner/win/build-generated-files.sh: Added properties svn:executable and svn:eol-style.
118         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added property svn:eol-style.
119         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added property svn:eol-style.
120
121 2012-03-09  Ionut Biru  <ibiru@archlinux.org>
122
123         [BUILD] use detected python to run generate-gtkdoc
124         https://bugs.webkit.org/show_bug.cgi?id=80695
125
126         Reviewed by Gustavo Noronha Silva.
127
128         * GNUmakefile.am: Use $(PYTHON) instead of plain `python`
129
130 2012-03-09  Nat Duca  <nduca@chromium.org>
131
132         Make check-webkit-style complain about "no new tests" lines in changelogs
133         https://bugs.webkit.org/show_bug.cgi?id=80582
134
135         Reviewed by David Levin.
136
137         * Scripts/webkitpy/style/checkers/changelog.py:
138         (ChangeLogChecker.check_entry):
139         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
140         (ChangeLogCheckerTest.test_no_new_tests):
141
142 2012-03-09  Sheriff Bot  <webkit.review.bot@gmail.com>
143
144         Unreviewed, rolling out r110250.
145         http://trac.webkit.org/changeset/110250
146         https://bugs.webkit.org/show_bug.cgi?id=80682
147
148         It made NRWT ignore test_expectations.txt on Qt-WK2 and ignore
149         qt-linux at all. (Requested by Ossy on #webkit).
150
151         * Scripts/old-run-webkit-tests:
152         * Scripts/webkitpy/layout_tests/port/qt.py:
153         (QtPort):
154         (QtPort.determine_full_port_name):
155         (QtPort.baseline_search_path):
156         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
157         (QtPortTest):
158         (QtPortTest._assert_search_path):
159         (QtPortTest.test_baseline_search_path):
160
161 2012-03-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
162
163         [Qt] Use Qt's module system for install rules and depending on QtWebKit
164
165         Instead of rolling our own install rules we now use the same approach as
166         every other Qt module, by loading qt_module.prf and qt_module_config.prf.
167
168         This ensures that we follow the same semantics as the rest of Qt on
169         what sort of config options are enabled by default (create_cmake eg.).
170         It also allows us to use QT += webkit instead of the workaround we had
171         with CONFIG += qtwebkit.
172
173         We do however force Qt to always treat our build as a non-developer build,
174         so the libraries will end up in the WebKit lib directory instead of the
175         qtbase directory (as with a normal developer-build). This allows us to
176         keep the webkit-build self-contained. If Qt is a developer build we still
177         copy the module file manually to Qt, so that you don't have to install
178         WebKit to make it available.
179
180         For non-developer builds of Qt, it is still possible to use the built
181         WebKit libraries without having to install them, by having the variable
182         QMAKE_EXTRA_MODULE_FORWARDS set in the project's .qmake.cache file,
183         pointing to $WEBKITOUTUTDIR/$CONFIGURATION/modules.
184
185         https://bugs.webkit.org/show_bug.cgi?id=80590
186
187         Reviewed by Simon Hausmann.
188
189         * DumpRenderTree/qt/DumpRenderTree.pro:
190         * MiniBrowser/qt/BrowserWindow.cpp:
191         * MiniBrowser/qt/MiniBrowser.pro:
192         * MiniBrowser/qt/MiniBrowserApplication.cpp:
193         * MiniBrowser/qt/UrlLoader.cpp:
194         * QtTestBrowser/QtTestBrowser.pro:
195         * Tools.pro:
196         * WebKitTestRunner/InjectedBundle/Target.pri:
197         * WebKitTestRunner/Target.pri:
198         * qmake/mkspecs/features/default_post.prf:
199         * qmake/mkspecs/features/default_pre.prf:
200         * qmake/mkspecs/features/functions.prf:
201         * qmake/mkspecs/features/qtwebkit-private.prf: Removed.
202         * qmake/mkspecs/features/qtwebkit.prf:
203         * qmake/mkspecs/features/rpath.prf:
204         * qmake/mkspecs/modules/qt_webkit.pri: Removed.
205         * qmake/qt_webkit.pri: Added.
206
207 2012-03-08  Igor Oliveira  <igor.o@sisa.samsung.com>
208
209         Unreviewed. Update my email.
210
211         * Scripts/webkitpy/common/config/committers.py:
212
213 2012-03-08  Xianzhu Wang  <wangxianzhu@chromium.org>
214
215         Recent changes to chromium.py etc. broke chromium_android.py
216         https://bugs.webkit.org/show_bug.cgi?id=80623
217
218         Reviewed by Dirk Pranke.
219
220         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
221         (ChromiumAndroidDriver.__init__):
222         (ChromiumAndroidDriver._start):
223
224 2012-03-08  Xianzhu Wang  <wangxianzhu@chromium.org>
225
226         [Chromium] Exception running reftest with --no-pixel-tests
227         https://bugs.webkit.org/show_bug.cgi?id=80642
228
229         Reviewed by Dirk Pranke.
230
231         * Scripts/webkitpy/layout_tests/port/chromium.py:
232         (ChromiumDriver.__init__):
233         (ChromiumDriver._wrapper_options):
234
235 2012-03-08  Rafael Brandao  <rafael.lobo@openbossa.org>
236
237         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
238         https://bugs.webkit.org/show_bug.cgi?id=72489
239
240         Reviewed by Dirk Pranke.
241
242         NRWT: The default platform name for Qt combined with --webkit-test-runner is now
243         "qt-5.0-wk2" instead of "qt-linux" and that name is now prefered for tests.
244         --platform will override the platform name and then we'll use it.
245
246         ORWT: We check for qt version and use platform name "qt-4.8" if the version is lower
247         than 5.0.0, and then we choose between "qt-5.0-wk1" and "qt-5.0-wk2". --platform will
248         override it in the end.
249
250         * Scripts/old-run-webkit-tests:
251         * Scripts/webkitpy/layout_tests/port/qt.py:
252         (QtPort):
253         (QtPort.determine_full_port_name):
254         (QtPort.baseline_search_path):
255         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
256         (QtPortTest):
257         (QtPortTest._assert_search_path):
258         (QtPortTest.test_baseline_search_path):
259
260 2012-03-08  Beth Dakin  <bdakin@apple.com>
261
262         https://bugs.webkit.org/show_bug.cgi?id=80463
263         RenderImage is using the wrong origin when calling addRelevantRepaintedObject
264         -and corresponding-
265         <rdar://problem/10970221>
266
267         Reviewed by Dan Bernstein.
268
269         New test!
270         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
271         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp: Added.
272         (TestWebKitAPI):
273         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
274         (TestWebKitAPI::setPageLoaderClient):
275         (TestWebKitAPI::TEST):
276         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp: Added.
277         (TestWebKitAPI):
278         (NewFirstVisuallyNonEmptyLayoutForImagesTest):
279         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::NewFirstVisuallyNonEmptyLayoutForImagesTest):
280         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::didCreatePage):
281         * TestWebKitAPI/Tests/WebKit2/lots-of-images.html: Added.
282
283 2012-03-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
284
285         [Qt] Prospective Windows build fix
286
287         Don't assume that windows-builds will always run inside a cmd.exe shell.
288
289         * qmake/mkspecs/features/default_pre.prf:
290
291 2012-03-08  Dan Bernstein  <mitz@apple.com>
292
293         <rdar://problem/10981173> Dashboard regions should not be in device space
294
295         Reviewed by John Sullivan.
296
297         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
298         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm: Added.
299         (-[DeviceScaleFactorInDashboardRegionsUIDelegate webView:dashboardRegionsChanged:]):
300         (TestWebKitAPI):
301         (TestWebKitAPI::TEST):
302
303 2012-03-08  Dirk Pranke  <dpranke@chromium.org>
304
305         webkit-patch works oddly on local Git branches
306         https://bugs.webkit.org/show_bug.cgi?id=76958
307
308         Reviewed by Ojan Vafai.
309
310         This change makes the '-g' flag to webkit-patch behave a
311         little more consistently with git. The 'HEAD..' syntax
312         is changed to 'HEAD....' (four dots), so as to not
313         collide with the underlying git syntax. We also generalize
314         the syntax to support any refname, so 'foo....' means
315         diff against foo and include working copy changes.
316
317         This change also adds the 'UPSTREAM' shortcut to identify
318         whatever the current upstream/tracking branch is; this is
319         useful if you have multiple local branches stacked up.
320
321         * Scripts/webkitpy/common/checkout/scm/git.py:
322         (Git._branch_from_ref):
323         (Git):
324         (Git._current_branch):
325         (Git._upstream_branch):
326         (Git.merge_base):
327         (Git._commit_on_branch):
328         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
329         (GitSVNTest._second_local_commit):
330         (GitSVNTest._two_local_commits):
331         (GitSVNTest.test_commit_with_message_git_commit_range):
332         (GitSVNTest.test_upstream_branch):
333         (GitSVNTest.test_create_patch_working_copy_only):
334         (GitSVNTest.test_changed_files_local_plus_working_copy):
335         (GitSVNTest.test_changed_files_working_copy_only):
336         (GitSVNTest.test_changed_files_upstream):
337         * Scripts/webkitpy/tool/steps/options.py:
338         (Options):
339
340 2012-03-08  John Sullivan  <sullivan@apple.com>
341
342         Made extract-localizable-strings ignore NSLocalizedFileSizeDescription
343
344         Reviewed by Eric Carlson.
345
346         * Scripts/extract-localizable-strings:
347         Added NSLocalizedFileSizeDescription to allowed list of tokens that start
348         with NSLocalized. Also improved an error message to include the troublesome token.
349
350 2012-03-08  Sheriff Bot  <webkit.review.bot@gmail.com>
351
352         Unreviewed, rolling out r110115.
353         http://trac.webkit.org/changeset/110115
354         https://bugs.webkit.org/show_bug.cgi?id=80581
355
356         broke test-webkitpy (Requested by philn-tp on #webkit).
357
358         * Scripts/old-run-webkit-tests:
359         * Scripts/webkitpy/layout_tests/port/qt.py:
360         (QtPort):
361         (QtPort.determine_full_port_name):
362         (QtPort.baseline_search_path):
363
364 2012-03-08  Kentaro Hara  <haraken@chromium.org>
365
366         Unreviewed. Added myself to watchlist.
367
368         * Scripts/webkitpy/common/config/watchlist:
369
370 2012-03-07  Jessie Berlin  <jberlin@apple.com>
371
372         Clean Windows build fails after r110033
373         https://bugs.webkit.org/show_bug.cgi?id=80553
374
375         Rubber-stamped by Jon Honeycutt and Eric Seidel.
376
377         Add the new JavaScriptCore include directory to some more vsprops files.
378
379         * DumpRenderTree/win/ImageDiffCommon.vsprops:
380         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
381         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
382
383 2012-03-07  Rafael Brandao  <rafael.lobo@openbossa.org>
384
385         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
386         https://bugs.webkit.org/show_bug.cgi?id=72489
387
388         Reviewed by Dirk Pranke.
389
390         NRWT: The default platform name for Qt combined with --webkit-test-runner is now
391         "qt-5.0-wk2" instead of "qt-linux" and that name is now prefered for tests.
392         --platform will override the platform name and then we'll use it.
393
394         ORWT: We check for qt version and use platform name "qt-4.8" if the version is lower
395         than 5.0.0, and then we choose between "qt-5.0-wk1" and "qt-5.0-wk2". --platform will
396         override it in the end.
397
398         * Scripts/old-run-webkit-tests:
399         * Scripts/webkitpy/layout_tests/port/qt.py:
400         (QtPort):
401         (QtPort.determine_full_port_name):
402         (QtPort.baseline_search_path):
403
404 2012-03-07  Hugo Parente Lima  <hugo.lima@openbossa.org>
405
406         [Qt][WK2] MiniBrowser on desktop does not react to click events
407         https://bugs.webkit.org/show_bug.cgi?id=80314
408
409         Reviewed by Kenneth Rohde Christiansen.
410
411         Do not enable touch mocking on desktop mode.
412
413         * MiniBrowser/qt/MiniBrowserApplication.cpp:
414         (MiniBrowserApplication::handleUserOptions):
415
416 2012-03-07  Ojan Vafai  <ojan@chromium.org>
417
418         Automatically move to the next test after rebaseline in the results view
419         https://bugs.webkit.org/show_bug.cgi?id=80527
420
421         Reviewed by Dimitri Glazkov.
422
423         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
424         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
425
426 2012-03-07  Ojan Vafai  <ojan@chromium.org>
427
428         garden-o-matic rebaseline is broken for ports that don't have a fallback port
429         https://bugs.webkit.org/show_bug.cgi?id=80526
430
431         Reviewed by Adam Barth.
432
433         Passing "None" as the fallback port throws an error in "webkit-patch rebaseline-test"
434         since there is no "None" port.
435
436         * Scripts/webkitpy/tool/servers/gardeningserver.py:
437         (GardeningHTTPRequestHandler.rebaseline):
438         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
439         (GardeningServerTest.test_rebaseline):
440
441 2012-03-07  James Robinson  <jamesr@chromium.org>
442
443         [chromium] Remove the TestWebPlugin's use of implicit FBO for offscreen contexts
444         https://bugs.webkit.org/show_bug.cgi?id=80521
445
446         Reviewed by Kenneth Russell.
447
448         Switches TestWebPlugin from using a context created by WebViewClient::createGraphicsContext3D(..., false) over
449         to an explicitly offscreen context with explicitly managed texture / FBO, so we can deprecate the
450         renderDirectlyToHostWindow flag from WebViewClient::createGraphicsContext3D.
451
452         Covered by platform/chromium/compositing/plugins/*
453
454         * DumpRenderTree/chromium/TestWebPlugin.cpp:
455         (TestWebPlugin::TestWebPlugin):
456         (TestWebPlugin::initialize):
457         (TestWebPlugin::updateGeometry):
458         (TestWebPlugin::initScene):
459         (TestWebPlugin::destroyScene):
460         * DumpRenderTree/chromium/TestWebPlugin.h:
461         (TestWebPlugin):
462         * DumpRenderTree/chromium/WebViewHost.cpp:
463         (WebViewHost::createPlugin):
464
465 2012-03-07  Philippe Normand  <pnormand@igalia.com>
466
467         [GTK] remove webkitpy dependency in run-gtk-tests
468         https://bugs.webkit.org/show_bug.cgi?id=80500
469
470         Reviewed by Martin Robinson.
471
472         Replace Executive calls with bare subprocess calls.
473
474         * Scripts/run-gtk-tests:
475         (TestRunner):
476         (TestRunner._lookup_atspi2_binary):
477         (TestRunner.run):
478         (TestRunner.run.run_for_real):
479
480 2012-03-07  Philippe Normand  <pnormand@igalia.com>
481
482         Unreviewed, GTK build fix after r110059.
483
484         * Scripts/run-gtk-tests:
485         (TestRunner._check_if_tests_have_timed_out):
486         (TestRunner.run.run_tests):
487         (TestRunner):
488
489 2012-03-07  Philippe Normand  <pnormand@igalia.com>
490
491         [GTK] race condition in run-gtk-tests
492         https://bugs.webkit.org/show_bug.cgi?id=80495
493
494         Reviewed by Martin Robinson.
495
496         Refactored the script to wait the a11y dbus service becomes
497         available before starting the tests.
498
499         * Scripts/run-gtk-tests:
500         (TestRunner._lookup_atspi2_binary):
501         (TestRunner):
502         (TestRunner._wait_dbus_service_and_run):
503         (TestRunner._wait_dbus_service_and_run.on_name_appeared):
504         (TestRunner._wait_dbus_service_and_run.on_name_vanished):
505         (TestRunner.run):
506         (TestRunner.run.bailout):
507         (TestRunner.run.run_for_real):
508
509 2012-03-07  Dinu Jacob  <dinu.jacob@nokia.com>
510
511         [Qt] REGRESSION(r109575) Broke tap-to-zoom gesture
512         https://bugs.webkit.org/show_bug.cgi?id=80425
513
514         Reviewed by Simon Hausmann.
515
516         Set startScreenPos in mock touch point
517
518         * MiniBrowser/qt/MiniBrowserApplication.cpp:
519         (MiniBrowserApplication::notify):
520         * MiniBrowser/qt/MiniBrowserApplication.h:
521         (MiniBrowserApplication):
522
523 2012-03-07  Simon Hausmann  <simon.hausmann@nokia.com>
524
525         [Qt] Windows build fix.
526
527         Reviewed by Tor Arne Vestbø.
528
529         Pass the -j parameter only to "make", not "nmake".
530
531         * Scripts/webkitdirs.pm:
532         (buildQMakeProjects):
533
534 2012-03-07  Simon Hausmann  <simon.hausmann@nokia.com>
535
536         [Qt] Fix compilation without QtQuick1
537         https://bugs.webkit.org/show_bug.cgi?id=80503
538
539         Reviewed by Tor Arne Vestbø.
540
541         Introduce HAVE_QQUICK1 as feature and added haveQtModule
542         as convenience function.
543
544         * qmake/mkspecs/features/features.prf:
545         * qmake/mkspecs/features/functions.prf:
546
547 2012-03-07  Zoltan Horvath  <zoltan@webkit.org>
548
549         [Qt] Add qmake config tests for JPEG and PNG library
550         https://bugs.webkit.org/show_bug.cgi?id=80398
551
552         Add JPEG and PNG library tests to config.tests and
553         add error() abort to WebCore.pri if tests don't work.
554
555         Reviewed by Tor Arne Vestbø.
556
557         * qmake/config.tests/libjpeg/libjpeg.cpp: Added.
558         (main):
559         * qmake/config.tests/libjpeg/libjpeg.pro: Added.
560         * qmake/config.tests/libpng/libpng.cpp: Added.
561         (main):
562         * qmake/config.tests/libpng/libpng.pro: Added.
563         * qmake/sync.profile:
564
565 2012-03-07  Byungwoo Lee  <bw80.lee@samsung.com>
566
567         [EFL] Build warning: Fix warn_unused_result warnings.
568         https://bugs.webkit.org/show_bug.cgi?id=79194
569
570         Reviewed by Filip Pizlo.
571
572         Fixed build warning which is getting generated when not using return
573         value of a fuction, especially declared with warn_unused_result
574         attribute.
575
576         * DumpRenderTree/efl/ImageDiff.cpp:
577         (printImage):
578
579 2012-03-07  Kangil Han  <kangil.han@samsung.com>
580
581         [DRT] Remove PlainTextController implementations.
582         https://bugs.webkit.org/show_bug.cgi?id=79959
583
584         Reviewed by Hajime Morita.
585
586         PlainTextController usages in existing tests have been
587         replaced by internals API by bug 78570.
588         So this patch will remove PlainTextController implementations
589         to avoid further usage in new tests.
590
591         * DumpRenderTree/DumpRenderTree.gypi:
592         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
593         * DumpRenderTree/chromium/PlainTextController.cpp: Removed.
594         * DumpRenderTree/chromium/PlainTextController.h: Removed.
595         * DumpRenderTree/chromium/TestShell.cpp:
596         (TestShell::TestShell):
597         (TestShell::bindJSObjectsToWindow):
598         * DumpRenderTree/chromium/TestShell.h:
599         (TestShell):
600         * DumpRenderTree/gtk/DumpRenderTree.cpp:
601         (webViewWindowObjectCleared):
602         * DumpRenderTree/gtk/PlainTextController.cpp: Removed.
603         * DumpRenderTree/gtk/PlainTextController.h: Removed.
604         * DumpRenderTree/mac/FrameLoadDelegate.mm:
605         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
606         * DumpRenderTree/mac/PlainTextController.h: Removed.
607         * DumpRenderTree/mac/PlainTextController.mm: Removed.
608         * DumpRenderTree/qt/DumpRenderTree.pro:
609         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
610         (WebCore::DumpRenderTree::DumpRenderTree):
611         (WebCore::DumpRenderTree::initJSObjects):
612         * DumpRenderTree/qt/DumpRenderTreeQt.h:
613         (DumpRenderTree):
614         * DumpRenderTree/qt/PlainTextControllerQt.cpp: Removed.
615         * DumpRenderTree/qt/PlainTextControllerQt.h: Removed.
616         * GNUmakefile.am:
617
618 2012-03-06  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
619
620         [EFL][DRT] Implements LayoutTestController's setPopupBlockingEnabled.
621         https://bugs.webkit.org/show_bug.cgi?id=80137
622
623         Reviewed by Eric Seidel.
624
625         Adds implementation LayoutTestController's setPopupBlockingEnabled.
626         To pass popup-blocking-click-in-iframe.html EventSender should not
627         repeat click events in idler's function. EventSender allows to
628         asynchronously send click event through ecore_idler_add.
629         This event will be called repeatedly as long as it return true.
630         Click event should be called only once by returning ECORE_CALLBACK_CANCEL.
631
632         * DumpRenderTree/efl/EventSender.cpp:
633         (sendMouseEvent): Changed return value from bool to void because it always returns true.
634         (sendClick): Idler is deleted by returning ECORE_CALLBACK_CANCEL.
635         (mouseDownCallback): Remove unnecessary checking of return value.
636         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
637         (LayoutTestController::setPopupBlockingEnabled):
638
639 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
640
641         rebaseline_chromium_webkit_tests is obsolete and should be removed
642         https://bugs.webkit.org/show_bug.cgi?id=80347
643
644         Reviewed by Tony Chang.
645
646         * Scripts/rebaseline-chromium-webkit-tests: Removed.
647         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py: Removed.
648         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py: Removed.
649
650 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
651
652         test_start_cmd (webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer) is broken
653         https://bugs.webkit.org/show_bug.cgi?id=80468
654
655         Unreviewed, build fix.
656
657         Fixing a bug revealed by r80443 when we fixed filesystem.copyfile().
658
659         * Scripts/webkitpy/layout_tests/servers/http_server.py:
660         (Lighttpd._prepare_config):
661
662 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
663
664         remove chromium_gpu ports
665         https://bugs.webkit.org/show_bug.cgi?id=80345
666
667         Reviewed by Ojan Vafai.
668
669         This change leaves in the 'graphics_type' distinction in the
670         test_expectations; removing that will require more updates and a
671         pass over test_expectations.txt, so I'm separating that out.
672
673         * Scripts/webkitpy/layout_tests/port/builders.py:
674         * Scripts/webkitpy/layout_tests/port/chromium.py:
675         (ChromiumPort):
676         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: Removed.
677         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py: Removed.
678         * Scripts/webkitpy/layout_tests/port/factory.py:
679         (PortFactory):
680         (PortFactory.get):
681         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
682         (FactoryTest.test_qt):
683         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
684         (TestRebaseline.test_rebaseline_expectations):
685
686 2012-03-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
687
688         undefined reference to JSC::IdentifierTable::~IdentifierTable() on EFL port
689         https://bugs.webkit.org/show_bug.cgi?id=80282
690
691         Reviewed by Antonio Gomes.
692
693         Remove transitive library dependencies; they are especially
694         dangerous when one ends up linking against WTF, JSC and then WTF
695         again, since some symbols will not be defined.
696
697         Passing --no-copy-dt-needed-entries and --as-needed to the linker
698         (which some recent Linux distros do by default) makes the issue
699         even more evident.
700
701         * DumpRenderTree/efl/CMakeLists.txt: Do not link directly to WTF,
702         as the other libraries have the needed symbols. Explicitly link
703         against fontconfig.
704
705 2012-03-06  Dean Jackson  <dino@apple.com>
706
707         filter-build-webkit needs more filters
708         https://bugs.webkit.org/show_bug.cgi?id=80440
709
710         Reviewed by Joseph Pecoraro.
711
712         Added as many missing filters as I could find for Apple
713         builds. Plus a few minor style updates.
714
715         * Scripts/filter-build-webkit:
716         (printLine):
717
718 2012-03-06  Ojan Vafai  <ojan@chromium.org>
719
720         Copying old baselines throws an error if the new directory doesn't exist
721         https://bugs.webkit.org/show_bug.cgi?id=80443
722
723         Reviewed by Adam Barth.
724
725         Existing tests cover the new code with the fix to filesystem_mock.
726
727         * Scripts/webkitpy/common/system/filesystem_mock.py:
728         (MockFileSystem.copyfile):
729         Fix the mock to better match python's copyfile semantics.
730
731         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
732         (Rebaseliner._create_html_baseline_files):
733         * Scripts/webkitpy/tool/commands/rebaseline.py:
734         (RebaselineTest._copy_existing_baseline):
735
736 2012-03-05  Ojan Vafai  <ojan@chromium.org>
737
738         Add a mechanism to rebaseline new ports
739         https://bugs.webkit.org/show_bug.cgi?id=80355
740
741         Reviewed by Adam Barth.
742
743         For a test that's only failing on a new port, we want
744         to first copy the existing result into the location for the
745         port it's replacing in order to not break that port.
746
747         For example, bringing up the chromium-lion port, if we just
748         stick the results in the chromium-mac directory, the snow leopard
749         will start failing. Instead, we first copy the existing result
750         to the chromium-mac-snowleopard directory.
751
752         * Scripts/webkitpy/layout_tests/port/builders.py:
753         (builder_path_for_port_name):
754         (fallback_port_name_for_new_port):
755         * Scripts/webkitpy/tool/commands/rebaseline.py:
756         (RebaselineTest):
757         (RebaselineTest._copy_existing_baseline):
758         (RebaselineTest._rebaseline_test):
759         (RebaselineTest.execute):
760         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
761         (TestRebaseline.test_rebaseline_test):
762         (TestRebaseline):
763         (TestRebaseline.test_rebaseline_and_copy_test):
764         (test_rebaseline_and_copy_test_no_existing_result):
765         (test_rebaseline_and_copy_test_with_lion_result):
766         (test_rebaseline_and_copy_no_overwrite_test):
767         * Scripts/webkitpy/tool/servers/gardeningserver.py:
768         (GardeningHTTPRequestHandler.rebaseline):
769         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
770         (GardeningServerTest.test_rebaseline):
771         (GardeningServerTest):
772         (GardeningServerTest.test_rebaseline_new_port):
773
774 2012-03-06  Beth Dakin  <bdakin@apple.com>
775
776         https://bugs.webkit.org/show_bug.cgi?id=80351
777         InlineTextBox is using the wrong origin when calling 
778         addRelevantRepaintedObject
779         -and corresponding-
780         <rdar://problem/10970221>
781
782         Reviewed by Sam Weinig.
783
784         This test has actually been broken since revision 109273. This change makes 
785         the test pass again, and it makes it specifically exercise the fix for this 
786         bug.
787         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
788         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
789         (TestWebKitAPI::TEST):
790
791         Adjust comments in the other tests to reflect the API changes from 109273.
792         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
793         (TestWebKitAPI::TEST):
794         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
795         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage):
796         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
797         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage):
798         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
799         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::didCreatePage):
800         * TestWebKitAPI/Tests/WebKit2/lots-of-text.html: Added.
801
802 2012-03-06  Hans Wennborg  <hans@chromium.org>
803
804         Speech JavaScript API: add SpeechRecognitionError
805         https://bugs.webkit.org/show_bug.cgi?id=80410
806
807         Chromium: enable the runtime flag for scripted speech so we can run
808         the layout tests for it.
809
810         Reviewed by Adam Barth.
811
812         * DumpRenderTree/chromium/TestShell.cpp:
813         (TestShell::TestShell):
814
815 2012-03-06  Sami Kyostila  <skyostil@chromium.org>
816
817         Enable universal newlines in chromium android layout test runner
818         https://bugs.webkit.org/show_bug.cgi?id=80418
819
820         Reviewed by Adam Barth.
821
822         The Chromium Android layout test runner uses the 'adb' program to
823         communicate with the Android device. Adb uses CRLF ('\r\n') to delimit
824         output lines from the test runner, while the test expectation files are
825         written with LF ('\n') delimiters. This causes the results to have
826         spurious whitespace differences, making them more difficult to
827         interpret.
828
829         The fix is to enable universal newlines for the DumpRenderTree pipe,
830         causing the output to only contain LF newlines like on other platforms.
831
832         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
833         (ChromiumAndroidDriver._start):
834
835 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
836
837         [Qt] Revert r109900, it was completly busted
838
839         HAVE_FOO does _not_ have a WTF_ prefix, go figure.
840
841         We still leave in the HAVE(FOO) in QtInitializeTestFonts.cpp, instead
842         of manual define checks.
843
844         Reviewed by Ossy.
845
846         * DumpRenderTree/qt/DumpRenderTree.pro:
847         * QtTestBrowser/QtTestBrowser.pro:
848         * WebKitTestRunner/InjectedBundle/Target.pri:
849         * qmake/mkspecs/features/features.prf:
850
851 2012-03-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
852
853         [Qt] Use config test to determine if the compiler supports -MD
854
855         We used to assume that unix systems building against Qt5 would have
856         a compiler that supported -MD. Although this was usually the case,
857         we failed to take into account broken tools for distributed builds
858         (e.g. teambuilder or icecream) which would end up producing .d files
859         in the root of the build dir instead of along-side the object file.
860
861         Now that we use a config-test to determine the support, we'll capture
862         those cases, unless distributed builds are enabled after the initial
863         build-webkit run.
864
865         Reviewed by Csaba Osztrogonác.
866
867         * Tools.pro:
868         * qmake/config.tests/gccdepends/empty.cpp: Added.
869         * qmake/config.tests/gccdepends/gccdepends.pro: Added.
870         * qmake/mkspecs/features/default_pre.prf:
871         * qmake/mkspecs/features/features.prf:
872         * qmake/mkspecs/features/unix/default_pre.prf:
873         * qmake/sync.profile:
874
875 2012-03-06  Csaba Osztrogonác  <ossy@webkit.org>
876
877         REGRESSION(r109294): It broke the unittest of master.cfg
878         https://bugs.webkit.org/show_bug.cgi?id=80253
879
880         Reviewed by Tor Arne Vestbø.
881
882         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Use json instead of simplejson.
883         (BuildBotConfigLoader._create_mock_passwords_dict):
884         (BuildBotConfigLoader._mock_open):
885         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules):
886         (BuildBotConfigLoader.load_config):
887
888 2012-03-06  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
889
890         Qt API test buildstep throws exception after buildmaster update
891         https://bugs.webkit.org/show_bug.cgi?id=80249
892
893         This patch based on Peter Gal's work.
894
895         Reviewed by Csaba Osztrogonác.
896
897         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
898         (RunQtAPITests):
899         (BuildAndTestFactory.__init__): Enable API tests on the Qt platform again.
900
901 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
902
903         [Qt] Use correct define names for HAVE(FOO) style optional dependencies
904
905         Reviewed by Simon Hausmann.
906         Reviewed by Ossy.
907
908         * DumpRenderTree/qt/DumpRenderTree.pro:
909         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
910         (WebKit::initializeTestFonts):
911         * QtTestBrowser/QtTestBrowser.pro:
912         * WebKitTestRunner/InjectedBundle/Target.pri:
913         * qmake/mkspecs/features/features.prf:
914
915 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
916
917         [Qt] Don't add recursive qmake_all target if there are no subdirs to recurse
918
919         Reviewed by Ossy.
920
921         * qmake/mkspecs/features/default_post.prf:
922
923 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
924
925         [Qt] Make sure clean builds are followed by make qmake && make if needed
926
927         On non-GNUmake systems we have to run make qmake so that the generated
928         sources are generated before we run qmake on the target pro files. This
929         is achieved by using the 'incremental' target.
930
931         Reviewed by Ossy.
932
933         * Scripts/webkitdirs.pm:
934         (buildQMakeProjects):
935
936 2012-03-06  Filip Pizlo  <fpizlo@apple.com>
937
938         DumpRenderTree should support preciseTime()
939         https://bugs.webkit.org/show_bug.cgi?id=80397
940
941         Reviewed by Gavin Barraclough.
942
943         * DumpRenderTree/LayoutTestController.cpp:
944         (preciseTimeCallback):
945         (LayoutTestController::staticFunctions):
946
947 2012-03-06  Sheriff Bot  <webkit.review.bot@gmail.com>
948
949         Unreviewed, rolling out r109887.
950         http://trac.webkit.org/changeset/109887
951         https://bugs.webkit.org/show_bug.cgi?id=80402
952
953         It broke the build (Requested by Ossy on #webkit).
954
955         * DumpRenderTree/qt/DumpRenderTree.pro:
956         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
957         (WebKit::initializeTestFonts):
958         * QtTestBrowser/QtTestBrowser.pro:
959         * WebKitTestRunner/InjectedBundle/Target.pri:
960         * qmake/mkspecs/features/features.prf:
961
962 2012-03-06  Sheriff Bot  <webkit.review.bot@gmail.com>
963
964         Unreviewed, rolling out r109837.
965         http://trac.webkit.org/changeset/109837
966         https://bugs.webkit.org/show_bug.cgi?id=80399
967
968         breaks Mac Productions builds, too late to try and fix it
969         tonight (Requested by eseidel on #webkit).
970
971         * Scripts/build-webkit:
972
973 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
974
975         [Qt] Use correct define names for HAVE(FOO) style optional dependencies
976
977         Reviewed by Simon Hausmann.
978
979         * DumpRenderTree/qt/DumpRenderTree.pro:
980         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
981         (WebKit::initializeTestFonts):
982         * QtTestBrowser/QtTestBrowser.pro:
983         * WebKitTestRunner/InjectedBundle/Target.pri:
984         * qmake/mkspecs/features/features.prf:
985
986 2012-03-06  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
987
988         [Qt] Create EWS to build WebKit2
989         https://bugs.webkit.org/show_bug.cgi?id=80277
990
991         Reviewed by Csaba Osztrogonác.
992
993         * QueueStatusServer/model/queues.py:
994         (Queue):
995         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
996         (QtWK2EWS):
997         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
998         (EarlyWarningSytemTest.test_builder_ewses):
999
1000 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1001
1002         Unreviewed, rolling out r109733.
1003         http://trac.webkit.org/changeset/109733
1004         https://bugs.webkit.org/show_bug.cgi?id=80378
1005
1006         It broke Qt5 build system (Requested by Ossy on #webkit).
1007
1008         * Tools.pro:
1009         * qmake/config.tests/gccdepends/empty.cpp: Removed.
1010         * qmake/config.tests/gccdepends/gccdepends.pro: Removed.
1011         * qmake/mkspecs/features/default_pre.prf:
1012         * qmake/mkspecs/features/features.prf:
1013         * qmake/mkspecs/features/unix/default_pre.prf:
1014         * qmake/sync.profile:
1015
1016 2012-03-05  Eric Seidel  <eric@webkit.org>
1017
1018         Update JavaScriptCore files to use fully-qualified WTF include path
1019         https://bugs.webkit.org/show_bug.cgi?id=79960
1020
1021         Reviewed by Adam Barth.
1022
1023         Build WTF/WTF.xcodeproj by default on Mac.
1024
1025         * Scripts/build-webkit:
1026
1027 2012-03-05  Dirk Pranke  <dpranke@chromium.org>
1028
1029         There should be a way to disable optimizer in webkit-patch rebaseline-expectations
1030         https://bugs.webkit.org/show_bug.cgi?id=69590
1031
1032         Reviewed by Ryosuke Niwa.
1033
1034         Adds a --no-optimize flag to webkit-patch rebaseline-expectations
1035         to skip the 'optimize-expectations' step.
1036
1037         * Scripts/webkitpy/tool/commands/rebaseline.py:
1038         (RebaselineExpectations.__init__):
1039         (RebaselineExpectations.execute):
1040         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1041
1042 2012-03-05  Kent Tamura  <tkent@chromium.org>
1043
1044         [Chromium] Add new popup type: PagePopup
1045         https://bugs.webkit.org/show_bug.cgi?id=80106
1046
1047         Reviewed by Darin Fisher.
1048
1049         * DumpRenderTree/chromium/WebViewHost.cpp:
1050         (WebViewHost::createPopupMenu):
1051
1052 2012-03-05  Jessie Berlin  <jberlin@apple.com>
1053
1054         Add myself as a reviewer.
1055
1056         * Scripts/webkitpy/common/config/committers.py:
1057         Also, add my IRC nick so it is easier to find and yell at me.
1058
1059 2012-03-05  Robert Kroeger  <rjkroege@chromium.org>
1060
1061         Correctly compute the positions of GestureScroll* events on
1062         Chromium.
1063         https://bugs.webkit.org/show_bug.cgi?id=80075
1064
1065         Reviewed by Adam Barth.
1066
1067         * DumpRenderTree/chromium/EventSender.cpp:
1068         (EventSender::reset):
1069         (EventSender::gestureEvent):
1070         * DumpRenderTree/chromium/EventSender.h:
1071         (EventSender):
1072
1073 2012-03-05  Dirk Pranke  <dpranke@chromium.org>
1074
1075         flakiness dashboard doesn't display baselines for virtual tests correctly
1076         https://bugs.webkit.org/show_bug.cgi?id=80341
1077
1078         Reviewed by Ojan Vafai.
1079
1080         If the test is part of a virtual test suite, we need to look for
1081         baselines in the underlying fallback path for the actual test
1082         being run, as well as baselines for the virtual version.
1083
1084         This patch adds code to handle both branches and also pulls the
1085         mapping of the test suites up into a constant.
1086
1087         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1088         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1089         (testLookupVirtualTestSuite):
1090         (testBaseTest):
1091
1092 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1093
1094         Unreviewed, rolling out r109760.
1095         http://trac.webkit.org/changeset/109760
1096         https://bugs.webkit.org/show_bug.cgi?id=80320
1097
1098         Caused many GTK+ tests to crash (Requested by mrobinson on
1099         #webkit).
1100
1101         * gtk/jhbuild.modules:
1102
1103 2012-03-05  Charlie Reis  <creis@chromium.org>
1104
1105         [chromium] Pass WebNavigationPolicy to WebViewClient::createView
1106         https://bugs.webkit.org/show_bug.cgi?id=80057
1107
1108         Reviewed by Darin Fisher.
1109
1110         * DumpRenderTree/chromium/WebViewHost.cpp:
1111         (WebViewHost::createView):
1112         * DumpRenderTree/chromium/WebViewHost.h:
1113         (WebViewHost):
1114
1115 2012-03-05  Martin Robinson  <mrobinson@igalia.com>
1116
1117         [soup] Crash while loading http://www.jusco.cn
1118         https://bugs.webkit.org/show_bug.cgi?id=68238
1119
1120         Reviewed by Philippe Normand.
1121
1122         * gtk/jhbuild.modules: Bumped the libsoup and glib dependencies
1123         in the jhbuild file.
1124
1125 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1126
1127         Unreviewed, rolling out r109748.
1128         http://trac.webkit.org/changeset/109748
1129         https://bugs.webkit.org/show_bug.cgi?id=80296
1130
1131         Made some tests crash, will fix and recommit (Requested by
1132         noamr on #webkit).
1133
1134         * MiniBrowser/qt/main.cpp:
1135         (main):
1136
1137 2012-03-05  Zan Dobersek  <zandobersek@gmail.com>
1138
1139         [GTK] plugins/netscape-plugin-page-cache-works.html fails
1140         https://bugs.webkit.org/show_bug.cgi?id=74409
1141
1142         Reviewed by Martin Robinson.
1143
1144         Add support for overriding the page-cache-for-plugins preference
1145         through DumpRenderTreeSupport.
1146
1147         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1148         (booleanFromValue): A helper function to convert a string to boolean.
1149         (LayoutTestController::overridePreference):
1150
1151 2012-03-05  Rob Buis  <rbuis@rim.com>
1152
1153         [BlackBerry] Update Tools/DumpRenderTree
1154         https://bugs.webkit.org/show_bug.cgi?id=80287
1155
1156         Reviewed by Antonio Gomes.
1157
1158         Update so we are sure we can build our implementation of DRT.
1159
1160         * DumpRenderTree/DumpRenderTree.h: include DumpRenderTreeBlackBerry.h.
1161         * DumpRenderTree/PixelDumpSupport.cpp: include PixelDumpSupportBlackBerry.h.
1162         * DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp:
1163         (AccessibilityController::addNotificationListener): add missing hook.
1164         (AccessibilityController::removeNotificationListener): add missing hook.
1165         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1166         (AccessibilityUIElement::isSelectedOptionActive): add missing hook.
1167         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1168         (LayoutTestController::setMockSpeechInputDumpRect): add missing hook.
1169         (LayoutTestController::simulateDesktopNotificationClick): add missing hook.
1170
1171 2012-03-05  No'am Rosenthal  <noam.rosenthal@nokia.com>
1172
1173         [Qt] [WK2] Support threaded renderer in WK2
1174         https://bugs.webkit.org/show_bug.cgi?id=76661
1175
1176         Remove the QML_NO_THREADED_RENDERER environment variable from MiniBrowser.
1177
1178         Reviewed by Kenneth Rohde Christiansen.
1179
1180         * MiniBrowser/qt/main.cpp:
1181         (main):
1182
1183 2012-03-05  Alexander Færøy  <alexander.faeroy@nokia.com>
1184
1185         Unreviewed. Add myself to committer list.
1186
1187         * Scripts/webkitpy/common/config/committers.py:
1188
1189 2012-03-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1190
1191         [Qt] Use config test to determine if the compiler supports -MD
1192
1193         We used to assume that unix systems building against Qt5 would have
1194         a compiler that supported -MD. Although this was usually the case,
1195         we failed to take into account broken tools for distributed builds
1196         (e.g. teambuilder or icecream) which would end up producing .d files
1197         in the root of the build dir instead of along-side the object file.
1198
1199         Now that we use a config-test to determine the support, we'll capture
1200         those cases, unless distributed builds are enabled after the initial
1201         build-webkit run.
1202
1203         Reviewed by Csaba Osztrogonác.
1204
1205         * Tools.pro:
1206         * qmake/config.tests/gccdepends/empty.cpp: Added.
1207         * qmake/config.tests/gccdepends/gccdepends.pro: Added.
1208         * qmake/mkspecs/features/default_pre.prf:
1209         * qmake/mkspecs/features/features.prf:
1210         * qmake/mkspecs/features/unix/default_pre.prf:
1211         * qmake/sync.profile:
1212
1213 2012-03-05  Csaba Osztrogonác  <ossy@webkit.org>
1214
1215         Qt API test buildstep throws exception after buildmaster update
1216         https://bugs.webkit.org/show_bug.cgi?id=80249
1217
1218         Reviewed by Zoltan Herczeg.
1219
1220         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Disable API tests on the Qt bot temporarily.
1221         (BuildAndTestFactory.__init__):
1222
1223 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
1224
1225         [GTK] Unit tests are noisy when run under jhbuild
1226         https://bugs.webkit.org/show_bug.cgi?id=80241
1227
1228         Reviewed by Philippe Normand.
1229
1230         Force the 'memory' backend in GSettings so that each unit
1231         test doesn't produce a warning when it's forced to fall back
1232         to the 'memory' backend.
1233
1234         * Scripts/run-gtk-tests:
1235         (TestRunner.run): Force the 'memory' backend.
1236
1237 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
1238
1239         [GTK] "Console: undefined @0: ReferenceError: Can't find variable: WebInspector" during testwebinspector
1240         https://bugs.webkit.org/show_bug.cgi?id=80235
1241
1242         Reviewed by Philippe Normand.
1243
1244         * Scripts/run-gtk-tests:
1245         (TestRunner.run): Use the WEBKIT_INSPECTOR_PATH environment variable so that
1246         inspector resources path determination is shared by all tests.
1247
1248 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
1249
1250         [GTK] REGRESSION: r108278 broke some tests that expect focus
1251         https://bugs.webkit.org/show_bug.cgi?id=79084
1252
1253         Reviewed by Philippe Normand.
1254
1255         Grab focus when dumping test results and also when sending
1256         events. During the course of testing, the WebView may lose
1257         focus and this seems to snap it back when tests demand it.
1258
1259         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1260         (dump): Grab focus.
1261         * DumpRenderTree/gtk/EventSender.cpp:
1262         (dispatchEvent): Ditto.
1263
1264 2012-03-04  Charles Wei  <charles.wei@torchmobile.com.cn>
1265
1266         Unreviewed, Add myself to committer list.
1267         https://bugs.webkit.org/show_bug.cgi?id=80232
1268
1269         * Scripts/webkitpy/common/config/committers.py:
1270
1271 2012-03-04  Anders Carlsson  <andersca@apple.com>
1272
1273         Newer versions of clang fail to compile WebKit.
1274
1275         Fix build.
1276
1277         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1278         (descriptionOfValue):
1279         (AccessibilityUIElement::rowIndexRange):
1280         (AccessibilityUIElement::columnIndexRange):
1281         (AccessibilityUIElement::selectedTextRange):
1282         * DumpRenderTree/mac/EditingDelegate.mm:
1283         (-[DOMRange dump]):
1284         * DumpRenderTree/mac/PolicyDelegate.mm:
1285         (-[PolicyDelegate webView:unableToImplementPolicyWithError:frame:]):
1286         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1287         (-[NSError _drt_descriptionSuitableForTestResult]):
1288         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1289         (WTR::descriptionOfValue):
1290         (WTR::AccessibilityUIElement::rowIndexRange):
1291         (WTR::AccessibilityUIElement::columnIndexRange):
1292         (WTR::AccessibilityUIElement::selectedTextRange):
1293
1294 2012-03-03  Simon Hausmann  <simon.hausmann@nokia.com>
1295
1296         [Qt] Fix static_libs_as_shared build
1297         https://bugs.webkit.org/show_bug.cgi?id=80214
1298
1299         Reviewed by Tor Arne Vestbø.
1300
1301         * WebKitTestRunner/qt/main.cpp:
1302         (main): Set the correct environment variable for choosing the theme in the
1303         web process.
1304
1305 2012-03-03  Hans Wennborg  <hans@chromium.org>
1306
1307         Implement Speech JavaScript API
1308         https://bugs.webkit.org/show_bug.cgi?id=80019
1309
1310         Reviewed by Adam Barth.
1311
1312         Add ENABLE_SCRIPTED_SPEECH.
1313
1314         * Scripts/build-webkit:
1315         * qmake/mkspecs/features/features.prf:
1316
1317 2012-03-02  Alexey Proskuryakov  <ap@apple.com>
1318
1319         Fix commit queue, remove duplicate entry.
1320
1321         * Scripts/webkitpy/common/config/committers.py:
1322
1323 2012-03-02  Stephen Chenney  <schenney@chromium.org>
1324
1325         Unreviewed, add myself as a committer
1326
1327         * Scripts/webkitpy/common/config/committers.py:
1328
1329 2012-03-02  Ojan Vafai  <ojan@chromium.org>
1330
1331         Add the Chromium Lion canary bot to the flakiness dashboard.
1332         * TestResultServer/static-dashboards/builders.js:
1333
1334 2012-03-02  Dirk Pranke  <dpranke@chromium.org>
1335
1336         links for virtual tests are broken in the flakiness dashboard
1337         https://bugs.webkit.org/show_bug.cgi?id=80180
1338
1339         Reviewed by Ojan Vafai.
1340
1341         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1342         (linkHTMLToOpenWindow):
1343         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1344         (testLinkHTMLToOpenWindow): added.
1345
1346 2012-03-02  Philippe Normand  <pnormand@igalia.com>
1347
1348         [GTK] security/block-test.html baselines differ from mac
1349         https://bugs.webkit.org/show_bug.cgi?id=78343
1350
1351         Reviewed by Martin Robinson.
1352
1353         Improved the FrameLoader error heuristics to match mac behavior a
1354         bit more.
1355
1356         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1357         (pathFromSoupURI): Handle ftp urls the same as http urls.
1358         (descriptionSuitableForTestResult): Map WebKitPolicyError to WebKitErrorDomain.
1359
1360 2012-03-02  Andras Becsi  <andras.becsi@nokia.com>
1361
1362         [Qt][WK2] Fix typo in patch committed in r109575
1363
1364         Unreviewed typo fix.
1365
1366         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1367         (MiniBrowserApplication::notify): Cache the position
1368         in floating point coordinates.
1369
1370 2012-03-02  Andras Becsi  <andras.becsi@nokia.com>
1371
1372         [Qt][WK2] Infinite loop on history navigation, when panning
1373         https://bugs.webkit.org/show_bug.cgi?id=79119
1374
1375         Reviewed by Simon Hausmann.
1376
1377         Make the touch mocking more robust by creating touch events
1378         directly and sending them synchronously to the browser window.
1379         If the sent touch event was not accepted we propagate the
1380         original mouse event to its target.
1381         This way we make sure we only send either a touch or a mouse
1382         event and do not end up in an infinite loop between our mocking
1383         code and the Qt5 automatic mouse event synthesizing.
1384
1385         * MiniBrowser/qt/BrowserWindow.cpp:
1386         (BrowserWindow::updateVisualMockTouchPoints):
1387         * MiniBrowser/qt/BrowserWindow.h:
1388         (BrowserWindow):
1389         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1390         (touchRectForPosition):
1391         (MiniBrowserApplication::notify):
1392         (MiniBrowserApplication::sendTouchEvent):
1393         * MiniBrowser/qt/MiniBrowserApplication.h:
1394         (MiniBrowserApplication):
1395
1396 2012-03-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1397
1398         [Qt] Use 'all' as default target when debug_and_release is in effect
1399
1400         When debug_and_release is enabled, in combination with build_all,
1401         qmake will generate an aggregate makefile that calls make on both
1402         the debug and the release makefiles, but with the 'all' target.
1403
1404         In this case we can't use 'first' as the default target, as the
1405         extra targets would then not be run, so we append extra targets
1406         to 'all' instead.
1407
1408         Reviewed by Simon Hausmann.
1409
1410         * qmake/mkspecs/features/default_post.prf:
1411
1412 2012-03-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1413
1414         [Qt] Make sure activeBuildConfig() returns the right config
1415
1416         Using isActiveConfig fails, as that only checks if the given
1417         argument is in CONFIG, not the order.
1418
1419         Reviewed by Simon Hausmann.
1420
1421         * qmake/mkspecs/features/functions.prf:
1422
1423 2012-03-02  Simon Hausmann  <simon.hausmann@nokia.com>
1424
1425         [Qt] Fix tests run with WTR not using QStyle theme
1426         https://bugs.webkit.org/show_bug.cgi?id=80147
1427
1428         Reviewed by Csaba Osztrogonác.
1429
1430         * WebKitTestRunner/qt/main.cpp:
1431         (main): Set environment variable for web process to use QStyle theme.
1432
1433 2012-03-02  Philippe Normand  <pnormand@igalia.com>
1434
1435         Unreviewed, remove debug print call.
1436
1437         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1438         (descriptionSuitableForTestResult):
1439
1440 2012-03-02  Robert Kroeger  <rjkroege@chromium.org>
1441
1442         Updated EventSender to send complete gesture events.
1443         https://bugs.webkit.org/show_bug.cgi?id=80075
1444
1445         Reviewed by Adam Barth.
1446
1447         * DumpRenderTree/chromium/EventSender.cpp:
1448         (EventSender::gestureEvent): set additional parameters in sent events.
1449
1450 2012-03-01  Kalev Lember  <kalevlember@gmail.com>
1451
1452         WebKitTestRunner: Explicitly include unistd.h for gcc 4.7
1453         https://bugs.webkit.org/show_bug.cgi?id=80033
1454
1455         Reviewed by Gustavo Noronha Silva.
1456
1457         GCC 4.7 no longer includes unistd.h from most of the standard C++
1458         header files, so we need to explicitly include it for getcwd().
1459
1460         * WebKitTestRunner/TestInvocation.cpp: Make sure unistd.h gets included
1461         not only on Mac, but on all Unix platforms.
1462
1463 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
1464
1465         Actually look at the args in driver_input :(.
1466
1467         Unreviewed, build fix.
1468
1469         * Scripts/webkitpy/layout_tests/port/chromium.py:
1470         (ChromiumDriver.run_test):
1471
1472 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
1473
1474         Fix typo in flag used to run gpu virtual suites.
1475
1476         Unreviewed, build fix.
1477
1478         * Scripts/webkitpy/layout_tests/port/chromium.py:
1479         (ChromiumPort.virtual_test_suites):
1480
1481 2012-03-01  Adam Barth  <abarth@webkit.org>
1482
1483         Unreviewed, rolling out r109317.
1484         http://trac.webkit.org/changeset/109317
1485
1486         Let's try watchlists again now that we're using a pure git
1487         working copy
1488
1489         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1490         (StyleQueueTask.run):
1491         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1492
1493 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
1494
1495         webkitpy: test_run_test_pause_before_testing is failing after r109482
1496         https://bugs.webkit.org/show_bug.cgi?id=80084
1497
1498         Unreviewed, build fix.
1499
1500         Fixes the test string compare to ignore the time spent running
1501         the tests.
1502
1503         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1504         (test_run_test_pause_before_testing):
1505
1506 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
1507
1508         nrwt: virtual tests aren't being run
1509         https://bugs.webkit.org/show_bug.cgi?id=80083
1510
1511         Reviewed by Eric Seidel.
1512
1513         If we tried to run all of the tests by default (and
1514         didn't specify any paths), the virtual tests weren't
1515         picked up.
1516
1517         * Scripts/webkitpy/layout_tests/port/base.py:
1518         (Port._virtual_tests):
1519         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1520         (PortTest.test_tests):
1521         * Scripts/webkitpy/layout_tests/port/test.py:
1522         (TestPort.virtual_test_suites):
1523
1524 2012-03-01  Ryosuke Niwa  <rniwa@webkit.org>
1525
1526         run-perf-tests should report the test runtime
1527         https://bugs.webkit.org/show_bug.cgi?id=80078
1528
1529         Reviewed by Hajime Morita.
1530
1531         Record and output the aggreated test run time.
1532
1533         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1534         (PerfTestsRunner._run_single_test):
1535
1536 2012-03-01  Michael Nordman  <michaeln@google.com>
1537
1538         [chromium] Use webkit_support to create session storage namespaces in DRT.
1539         https://bugs.webkit.org/show_bug.cgi?id=79933
1540
1541         Reviewed by Tony Chang.
1542
1543         * DumpRenderTree/chromium/WebViewHost.cpp:
1544         (WebViewHost::createSessionStorageNamespace):
1545
1546 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
1547
1548         nrwt: test_isfile, test_isdir, and test_exists don't work for virtual tests
1549         https://bugs.webkit.org/show_bug.cgi?id=80048
1550
1551         Reviewed by Adam Barth.
1552
1553         * Scripts/webkitpy/layout_tests/port/base.py:
1554         (Port.test_isfile):
1555         (Port.test_isdir):
1556         (Port):
1557         (Port.test_exists):
1558         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1559         (PortTest.test_test_exists):
1560         (PortTest):
1561         (PortTest.test_test_isfile):
1562         (PortTest.test_test_isdir):
1563         * Scripts/webkitpy/layout_tests/port/test.py:
1564         (TestPort.virtual_test_suites):
1565         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1566         (MainTest.test_virtual):
1567
1568 2012-03-01  Kalev Lember  <kalevlember@gmail.com>
1569
1570         [GTK] Avoid building any parts of WebKitTestRunner when WK2 is disabled
1571         https://bugs.webkit.org/show_bug.cgi?id=80031
1572
1573         Reviewed by Gustavo Noronha Silva.
1574
1575         Only build the libTestRunnerInjectedBundle.la convenience library when
1576         ENABLE_WEBKIT2 is defined.
1577
1578         * WebKitTestRunner/GNUmakefile.am:
1579
1580 2012-03-01  Philippe Normand  <pnormand@igalia.com>
1581
1582         Unreviewed, second attempt to fix GTK NRWT after r109242.
1583
1584         * Scripts/webkitpy/layout_tests/port/gtk.py:
1585         (GtkDriver._start):
1586
1587 2012-03-01  Philippe Normand  <pnormand@igalia.com>
1588
1589         Unreviewed, GTK NRWT build fix attempt after r109242.
1590
1591         * Scripts/webkitpy/layout_tests/port/gtk.py:
1592         (GtkDriver._start):
1593
1594 2012-03-01  Kentaro Hara  <haraken@chromium.org>
1595
1596         REGRESSION(r109036): run-bindings-tests fails because resolve-supplemental.pl was renamed
1597         https://bugs.webkit.org/show_bug.cgi?id=80008
1598
1599         Reviewed by Adam Barth.
1600
1601         In r109036, I forgot to rename "resolve-supplemental.pl" in run-bindings-tests
1602         to "preprocess-idls.pl". This patch renames it.
1603
1604         Test: Confirm that run-bindings-tests runs.
1605
1606         * Scripts/webkitpy/bindings/main.py:
1607         (BindingsTests.generate_supplemental_dependency):
1608
1609 2012-02-29  Simon Hausmann  <simon.hausmann@nokia.com>
1610
1611         [Qt][WK2] QQuickWebView::event should lookup faster which events QQuickWebPage can handle
1612         https://bugs.webkit.org/show_bug.cgi?id=78047
1613
1614         Reviewed by Kenneth Rohde Christiansen.
1615
1616         Send events for the webview through the QQuickCanvas instead of directly to the item. Direct
1617         sending to the item requires the QObject::event re-implementation to dispatch to the correct
1618         event handling function. However QQuickItem::event doesn't do that. Instead QQuickCanvas calls
1619         the event handlers directly, and with the removal of our own dispatching we need to go through
1620         that code path.
1621
1622         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1623         (WTR::PlatformWebView::sendEvent):
1624         (WTR::PlatformWebView::postEvent):
1625
1626 2012-02-29  Adam Barth  <abarth@webkit.org>
1627
1628         Disable watchlist.  It's been spamming CCs.
1629
1630         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1631         (StyleQueueTask.run):
1632         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1633
1634 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
1635
1636         need to clone the gpu baselines and expectations into the new "virtual" dir
1637         https://bugs.webkit.org/show_bug.cgi?id=79956
1638
1639         Reviewed by Adam Barth.
1640
1641         * Scripts/webkitpy/layout_tests/port/chromium.py:
1642         (ChromiumPort.virtual_test_suites):
1643
1644 2012-02-29  Mark Rowe  <mrowe@apple.com>
1645
1646         Switch to using json rather than simplejson now that the master is using Python 2.7.
1647
1648         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1649         (loadBuilderConfig):
1650
1651 2012-02-29  David Levin  <levin@chromium.org>
1652
1653         [chromium] Add the ability to turn off autoresize.
1654         https://bugs.webkit.org/show_bug.cgi?id=77452
1655
1656         Reviewed by Darin Fisher.
1657
1658         * DumpRenderTree/chromium/LayoutTestController.cpp:
1659         (LayoutTestController::LayoutTestController): Expose a way to turn off auto-resize.
1660         (LayoutTestController::enableAutoResizeMode): Ditto and adjust to new WebKit api.
1661         (LayoutTestController::disableAutoResizeMode):  Ditto.
1662         * DumpRenderTree/chromium/LayoutTestController.h: Ditto.
1663
1664 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
1665
1666         nrwt: make --print trace work with virtual tests
1667         https://bugs.webkit.org/show_bug.cgi?id=79952
1668
1669         Reviewed by Adam Barth.
1670
1671         * Scripts/webkitpy/layout_tests/views/printing.py:
1672         (Printer._print_test_trace):
1673         (Printer._print_baseline):
1674
1675 2012-02-28  Brian Weinstein  <bweinstein@apple.com>
1676
1677         WebKit2: didNewFirstVisuallyNonEmptyLayout should be sent to injected bundle
1678         https://bugs.webkit.org/show_bug.cgi?id=79849
1679
1680         Reviewed by Beth Dakin.
1681
1682         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1683         (WTR::InjectedBundlePage::InjectedBundlePage): Add an entry to the struct.
1684
1685 2012-02-29  Lucas Forschler  <lforschler@apple.com>
1686
1687         Removed unused Apple buildslaves from the master configuration
1688         https://bugs.webkit.org/show_bug.cgi?id=79925
1689
1690         Reviewed by Stephanie Lewis.
1691
1692         * BuildSlaveSupport/build.webkit.org-config/config.json:
1693
1694 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
1695
1696         nrwt: implement simple 'virtual test suite' support
1697         https://bugs.webkit.org/show_bug.cgi?id=79737
1698
1699         Reviewed by Adam Barth.
1700
1701         Add very basic support for 'virtual test suites' to NRWT:
1702         a virtual suite is a directory that may contain new baselines,
1703         contains a pointer to a "base" directory of tests, and an
1704         optional list of command line arguments to pass to DRT;
1705         it gives us a way to run all of the tests in a given directory
1706         multiple times with multiple (potentially differing) sets of
1707         results and baselines.
1708
1709         This patch implements the support needed for this feature, and
1710         some basic tests, but no actual port will use the feature yet.
1711
1712         This is probably the simplest implementation possible - the
1713         list of virtual suites will be hard-coded into the port's
1714         implementation. One can imagine a more data-driven approach
1715         where the suite instructions are stored in a manifest file
1716         either in LayoutTests (all suites in one file), or per-port,
1717         or per-directory. If this feature ends up being useful we
1718         should probably add something like that so people don't have
1719         to hunt around in the code to add suites.
1720
1721         * Scripts/webkitpy/layout_tests/port/base.py:
1722         (Port.__init__):
1723         (Port.expected_filename):
1724         (Port.tests):
1725         (Port):
1726         (Port._real_tests):
1727         (Port._driver_class):
1728         (Port.virtual_test_suites):
1729         (Port.virtual_suite):
1730         (Port.virtual_suite.VirtualTestSuite):
1731         (Port.virtual_suite.VirtualTestSuite.__init__):
1732         (Port.virtual_suite.VirtualTestSuite.__repr__):
1733         (Port.populated_virtual_test_suites):
1734         (Port._virtual_tests):
1735         (Port.lookup_virtual_test_base):
1736         (Port.lookup_virtual_test_args):
1737         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1738         (PortTest.test_find_with_skipped_directories):
1739         * Scripts/webkitpy/layout_tests/port/driver.py:
1740         (DriverInput.__init__):
1741         (DriverProxy.run_test):
1742         * Scripts/webkitpy/layout_tests/port/test.py:
1743         (TestPort.virtual_test_suites):
1744         (TestDriver.run_test):
1745         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1746         (MainTest.test_all):
1747         (MainTest.test_virtual):
1748
1749 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
1750
1751         nrwt: support more than two drivers in DriverProxy
1752         https://bugs.webkit.org/show_bug.cgi?id=79736
1753
1754         Reviewed by Adam Barth.
1755
1756         Now that we can support per-test command lines for
1757         Drivers, modify DriverProxy to keep a map of running
1758         drivers for each needed command-line; this will allow
1759         us to transparently maintain a pool of appropriately
1760         configured DRTs without having to constantly start and stop
1761         them.
1762
1763         Note that this potentially raises a garbage collection
1764         problem - the number of running DRTs will grow with the
1765         number of different sets of command line args. For now
1766         this is no worse than the current code - if you're running
1767         with pixel tests, you will only need one DRT per worker,
1768         and if you aren't, you'll need two (one for text-only tests,
1769         and one for reftests).
1770
1771         An alternative would be to only ever have one running driver,
1772         and restart the driver as the command line changes, but this
1773         might (?) slow down execution in the text-only case - we
1774         should benchmark this because it would be simpler and possibly
1775         allow us to eliminate DriverProxy altogether.
1776
1777         * Scripts/webkitpy/layout_tests/port/driver.py:
1778         (DriverProxy.__init__):
1779         (DriverProxy):
1780         (DriverProxy._make_driver):
1781         (DriverProxy.run_test):
1782         (DriverProxy.has_crashed):
1783         (DriverProxy.stop):
1784         (DriverProxy.cmd_line):
1785         (DriverProxy._cmd_line_as_key):
1786
1787 2012-02-29  Adrienne Walker  <enne@google.com>
1788
1789         Unreviewed, add myself as a reviewer
1790
1791         * Scripts/webkitpy/common/config/committers.py:
1792
1793 2012-02-29  Greg Billock  <gbillock@google.com>
1794
1795         Add more tests for web intents
1796         https://bugs.webkit.org/show_bug.cgi?id=79527
1797
1798         Reviewed by Adam Barth.
1799
1800         * DumpRenderTree/chromium/LayoutTestController.cpp:
1801         (LayoutTestController::LayoutTestController):
1802         (LayoutTestController::sendWebIntentResponse):
1803         * DumpRenderTree/chromium/LayoutTestController.h:
1804         (LayoutTestController):
1805         * DumpRenderTree/chromium/WebViewHost.h:
1806         (WebViewHost):
1807         (WebViewHost::currentIntentRequest):
1808
1809 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
1810
1811         nrwt: port/Driver needs to support per-test command line args
1812         https://bugs.webkit.org/show_bug.cgi?id=79733
1813
1814         Reviewed by Adam Barth.
1815
1816         As part of removing the 'gpu' configurations and adding support
1817         for 'virtual test suites', the Driver classes need to support
1818         per-test command lines (since different tests will need to be
1819         run with different command line options).
1820
1821         The per-test args are not yet used, so this change should have
1822         no visible effects and need no additional testing.
1823
1824         * Scripts/webkitpy/layout_tests/port/base.py:
1825         (Port.driver_cmd_line):
1826         * Scripts/webkitpy/layout_tests/port/chromium.py:
1827         (ChromiumDriver.cmd_line):
1828         (ChromiumDriver._start):
1829         (ChromiumDriver.start):
1830         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1831         (ChromiumDriverTest.test_two_drivers.MockDriver.cmd_line):
1832         (ChromiumDriverTest):
1833         (ChromiumDriverTest.test_two_drivers):
1834         * Scripts/webkitpy/layout_tests/port/driver.py:
1835         (Driver.cmd_line):
1836         (DriverProxy.__init__):
1837         (DriverProxy.start):
1838         (DriverProxy.cmd_line):
1839         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
1840         (DriverTest.test_virtual_driver_methods):
1841         * Scripts/webkitpy/layout_tests/port/gtk.py:
1842         (GtkDriver.cmd_line):
1843         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1844         * Scripts/webkitpy/layout_tests/port/test.py:
1845         (TestPort._path_to_driver):
1846         (TestDriver.cmd_line):
1847         (TestDriver.start):
1848         * Scripts/webkitpy/layout_tests/port/webkit.py:
1849         (WebKitDriver.cmd_line):
1850         (WebKitDriver._start):
1851         (WebKitDriver.run_test):
1852         (WebKitDriver.start):
1853         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1854         (WebKitDriverTest.test_no_timeout):
1855         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1856         (PerfTestsRunner._run_tests_set):
1857         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1858         (test_run_test_pause_before_testing):
1859
1860 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
1861
1862         perftestsrunner can call printer.write() after printer.cleanup()
1863         https://bugs.webkit.org/show_bug.cgi?id=79872
1864
1865         Reviewed by Ryosuke Niwa.
1866
1867         This patch fixes a unittest that was incorrectly calling
1868         PerfTestsRunner.run() twice (which led to a weird state in the
1869         printer object).
1870
1871         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1872         (MainTest.test_run_with_upload_json):
1873
1874 2012-02-29  Balazs Kelemen  <kbalazs@webkit.org>
1875
1876         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
1877         https://bugs.webkit.org/show_bug.cgi?id=76546
1878
1879         Reviewed by Simon Hausmann.
1880
1881         Revert the workaround introduced in r107868 and reintroduce
1882         the qml binding so we can test the code path that we are more
1883         interested in. The reason that it did not work before is that
1884         we don't have an active platform window which we now workaround
1885         by propagating the resize through QWindowSystemInterface.
1886
1887         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1888         (WTR::WrapperWindow::handleStatusChanged):
1889         (WTR::PlatformWebView::resizeTo):
1890
1891 2012-02-29  Gabor Rapcsanyi  <rgabor@webkit.org>
1892
1893         [GTK] Small fix for cross compilation to not generate gtkdoc.
1894
1895         Rubber-stamped by Csaba Osztrogonác.
1896
1897         * Scripts/webkitdirs.pm:
1898         (isCrossCompilation):
1899
1900 2012-02-28  Lucas Forschler  <lforschler@apple.com>
1901
1902         Fix a typo in config.json
1903         linx -> linux
1904         
1905         * BuildSlaveSupport/build.webkit.org-config/config.json:
1906
1907 2012-02-28  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1908
1909         [Qt] Allow read/write to the WebView.url property
1910         https://bugs.webkit.org/show_bug.cgi?id=77554
1911
1912         Reviewed by Tor Arne Vestbø.
1913
1914         Fix MiniBrowser to use WebView.url property and remove WebView.load usage.
1915
1916         * MiniBrowser/qt/qml/BrowserWindow.qml:
1917
1918 2012-02-28  Dan Winship  <danw@gnome.org>
1919
1920         [GTK] make tests explicitly request GSettingsBackendMemory
1921         https://bugs.webkit.org/show_bug.cgi?id=79788
1922
1923         Reviewed by Martin Robinson.
1924
1925         Explicitly request the fallback memory-based GSettings backend; if
1926         other backends are available then we don't want to use them,
1927         because they would make tests depend on the user's preferences.
1928         And if other backends aren't available, we don't need glib to
1929         print a warning about that fact.
1930
1931         * Scripts/webkitpy/layout_tests/port/gtk.py:
1932         (GtkPort.setup_environ_for_server):
1933
1934 2012-02-28  Sheriff Bot  <webkit.review.bot@gmail.com>
1935
1936         Unreviewed, rolling out r109110.
1937         http://trac.webkit.org/changeset/109110
1938         https://bugs.webkit.org/show_bug.cgi?id=79806
1939
1940         webkitpy makes it too easy to add wkb.ug URLs to ChangeLogs
1941         (Requested by aroben on #webkit).
1942
1943         * Scripts/webkitpy/common/checkout/changelog.py:
1944         (parse_bug_id):
1945         (parse_bug_id_from_changelog):
1946         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1947         * Scripts/webkitpy/common/config/urls.py:
1948
1949 2012-02-28  Adam Roben  <aroben@webkit.org>
1950
1951         Add my new email address
1952
1953         Fixes <http://wkb.ug/79797> Adam Roben's email address in webkitpy is soon to be incorrect
1954
1955         Reviewed by Anders Carlsson.
1956
1957         * Scripts/webkitpy/common/config/committers.py:
1958
1959 2012-02-28  Adam Roben  <aroben@apple.com>
1960
1961         Teach webkitpy about wkb.ug URLs
1962
1963         Fixes <http://wkb.ug/79799> webkit-patch can't find bug numbers from ChangeLog entries that
1964         use wkb.ug URLs
1965
1966         Reviewed by Anders Carlsson.
1967
1968         * Scripts/webkitpy/common/checkout/changelog.py:
1969         (parse_bug_id):
1970         (parse_bug_id_from_changelog):
1971         Fall back to the tiny URL format if neither the short nor long URL formats work.
1972
1973         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1974         (ChangeLogTest.test_parse_bug_id_from_changelog): Added tests for the above changes.
1975
1976         * Scripts/webkitpy/common/config/urls.py: Added bug_url_tiny, which can be used to match
1977         wkb.ug URLs.
1978
1979 2012-02-28  János Badics  <dicska@gmail.com>
1980
1981         [Qt] build-webkit does not detect the number of CPUs
1982         https://bugs.webkit.org/show_bug.cgi?id=76445
1983
1984         Based on Seo Sanghyeon's work (modification:
1985         Automatically determine the number of CPUs for make
1986         only if -j make argument haven't already been specified.)
1987
1988         Reviewed by Csaba Osztrogonác.
1989
1990         * Scripts/webkitdirs.pm:
1991         (buildQMakeProjects):
1992
1993 2012-02-28  Kent Tamura  <tkent@chromium.org>
1994
1995         Update a pattern for forms files of watchlist
1996         https://bugs.webkit.org/show_bug.cgi?id=79767
1997
1998         Reviewed by Kentaro Hara.
1999
2000         * Scripts/webkitpy/common/config/watchlist:
2001         Catches the following files with the "Forms" pattern.
2002         - HTMLDatListElement.*
2003         - HTMLKeygenElement.*
2004         - HTMLLegendElement.*
2005         - HTMLOutputElement.*
2006         - FormAssociatedElement.*
2007         - SliderThumbElement.*
2008         - TextControlInnerElements.*
2009         - RenderFileUploadControl.*
2010
2011 2012-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2012
2013         Unreviewed, rolling out r109041.
2014         http://trac.webkit.org/changeset/109041
2015         https://bugs.webkit.org/show_bug.cgi?id=79741
2016
2017         Broke Chromium Win build (Requested by bashi on #webkit).
2018
2019         * DumpRenderTree/chromium/LayoutTestController.cpp:
2020         (LayoutTestController::LayoutTestController):
2021         * DumpRenderTree/chromium/LayoutTestController.h:
2022         (LayoutTestController):
2023         * DumpRenderTree/chromium/WebViewHost.h:
2024
2025 2012-02-27  James Robinson  <jamesr@chromium.org>
2026
2027         [chromium] Remove media tests from ChromiumGpu configurations
2028         https://bugs.webkit.org/show_bug.cgi?id=79720
2029
2030         Reviewed by Adam Barth.
2031
2032         We no longer need to run the media/ tests in both GPU and non-GPU configurations since we can exercise the GPU
2033         composited playback path via tests in the compositing/ directory.
2034
2035         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2036         (_default_tests_paths):
2037         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2038         (ChromiumGpuTest.test_default_tests_paths):
2039         (ChromiumGpuTest.test_test_files):
2040
2041 2012-02-27  Dirk Pranke  <dpranke@chromium.org>
2042
2043         nrwt: log multiline stderr/crash output properly
2044         https://bugs.webkit.org/show_bug.cgi?id=79722
2045
2046         Reviewed by Adam Barth.
2047
2048         This cleans up some nits in the log output to make things
2049         slightly easier to read (every line gets timestamped, etc.).
2050
2051         Also tweaks the log message for pixel hash mismatches.
2052
2053         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2054         (SingleTestRunner._handle_error):
2055         (SingleTestRunner._compare_image):
2056
2057 2012-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2058
2059         Touch the master.cfg to force a reconfig.
2060
2061         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2062         (BuildAndTestLeaksFactory):
2063         (NewBuildAndTestFactory):
2064
2065 2012-02-27  Jacky Jiang  <zhajiang@rim.com>
2066
2067         [BlackBerry] Upstream BlackBerry API web page related files
2068         https://bugs.webkit.org/show_bug.cgi?id=74380
2069
2070         Reviewed by Antonio Gomes.
2071
2072         Adapt to the removing of WebPage::mainFrame(), use
2073         DumpRenderTreeSupport::corePage() and its mainFrame() instead.
2074
2075         No new tests as this patch doesn't change behavior.
2076
2077         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2078         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
2079         (BlackBerry::WebKit::DumpRenderTree::runTests):
2080
2081 2012-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2082
2083         Add Windows and Linux Chromium perf bots
2084         https://bugs.webkit.org/show_bug.cgi?id=79418
2085
2086         Reviewed by Tony Chang.
2087
2088         Add Chromium Win and Linux perf bots. Also replace Chromium Mac by
2089         the dedicated perf bot slave (uses the same hardware).
2090
2091         * BuildSlaveSupport/build.webkit.org-config/config.json:
2092
2093 2012-02-27  Xianzhu Wang  <wangxianzhu@chromium.org>
2094
2095         Undefined variable 'current' when running chromium_android.py
2096         https://bugs.webkit.org/show_bug.cgi?id=79696
2097
2098         Reviewed by Adam Barth.
2099
2100         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2101         (ChromiumAndroidDriver._read_prompt):
2102
2103 2012-02-27  Greg Billock  <gbillock@google.com>
2104
2105         Add more tests for web intents
2106         https://bugs.webkit.org/show_bug.cgi?id=79527
2107
2108         Reviewed by Adam Barth.
2109
2110         * DumpRenderTree/chromium/LayoutTestController.cpp:
2111         (LayoutTestController::LayoutTestController):
2112         (LayoutTestController::sendWebIntentResponse):
2113         * DumpRenderTree/chromium/LayoutTestController.h:
2114         (LayoutTestController):
2115         * DumpRenderTree/chromium/WebViewHost.h:
2116         (WebViewHost):
2117         (WebViewHost::currentIntentRequest):
2118
2119 2012-02-27  Xianzhu Wang  <wangxianzhu@chromium.org>
2120
2121         Chromium-Android layout test script: the adb shell prompt is not always '# '
2122         https://bugs.webkit.org/show_bug.cgi?id=79506
2123
2124         Reviewed by Adam Barth.
2125
2126         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2127         (ChromiumAndroidDriver._start):
2128         (ChromiumAndroidDriver._read_prompt):
2129
2130 2012-02-27  Dan Bernstein  <mitz@apple.com>
2131
2132         Added a test for <rdar://problem/9557598> REGRESSION (WebKit2): Non-activating links sometimes don’t work
2133         https://bugs.webkit.org/show_bug.cgi?id=79607
2134
2135         Reviewed by Adele Peterson.
2136
2137         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
2138         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm: Added.
2139         (TestWebKitAPI::AcceptsFirstMouse::url):
2140         (TestWebKitAPI::AcceptsFirstMouse::didLoadURL):
2141         (TestWebKitAPI::AcceptsFirstMouse::runTest):
2142         (TestWebKitAPI::TEST_F):
2143         * TestWebKitAPI/Tests/mac/acceptsFirstMouse.html: Added.
2144
2145 2012-02-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2146
2147         Unreviewed. Fix make distcheck.
2148
2149         * GNUmakefile.am: Fix typo.
2150
2151 2012-02-27  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2152
2153         [Qt] Use USE() macro instead of ENABLE() for using the Qt image decoder
2154
2155         Reviewed by Kenneth Rohde Christiansen..
2156
2157         * qmake/mkspecs/features/features.prf:
2158
2159 2012-02-27  Hao Zheng  <zhenghao@chromium.org>
2160
2161         Add a ChromiumGpuAndroid port.
2162         https://bugs.webkit.org/show_bug.cgi?id=79628
2163
2164         Reviewed by Adam Barth.
2165
2166         Android does have a gpu port, so revert r107697.
2167
2168         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2169         (ChromiumAndroidPort.__init__):
2170         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2171         (ChromiumGpuAndroidPort):
2172         (ChromiumGpuAndroidPort.__init__):
2173         (ChromiumGpuAndroidPort.baseline_search_path):
2174         (ChromiumGpuAndroidPort.default_child_processes):
2175         (ChromiumGpuAndroidPort.tests):
2176         * Scripts/webkitpy/layout_tests/port/factory.py:
2177         (PortFactory):
2178
2179 2012-02-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2180
2181         Change Build bot with BuildAndTest bot for EFL port.
2182         https://bugs.webkit.org/show_bug.cgi?id=77518
2183
2184         Reviewed by Ryosuke Niwa.
2185
2186         EFL build bot starts to support layout test.
2187
2188         * BuildSlaveSupport/build.webkit.org-config/config.json:
2189         * BuildSlaveSupport/built-product-archive:
2190         (archiveBuiltProduct):
2191         (extractBuiltProduct):
2192         * BuildSlaveSupport/test-result-archive:
2193         (archiveTestResults):
2194         * Scripts/webkitdirs.pm: Enable SHARED_CORE option when ENABLE_DRT is enable in EFL port.
2195         (generateBuildSystemFromCMakeProject):
2196
2197 2012-02-24  Darin Fisher  <darin@chromium.org>
2198
2199         Add watchlist for ChromiumPlatformApi matching Source/Platform/chromium/public/
2200
2201         Reviewed by James Robinson.
2202
2203         * Scripts/webkitpy/common/config/watchlist:
2204
2205 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
2206
2207         webkitpy: changelog_unittest test_fuzzy_reviewer_match is slow
2208         https://bugs.webkit.org/show_bug.cgi?id=79258
2209
2210         Reviewed by Ryosuke Niwa.
2211
2212         Split the fuzzy matching into separate functions so that they
2213         can be sharded and run in parallel.
2214
2215         Also, fix a bug in the svn_blame_regexp that was causing us
2216         to require ChangeLog lines to have at least one space after the
2217         author, making the code require trailing whitespace in the
2218         changelog in some places (this was making my life harder because
2219         I have my text editor set to strip trailing whitespace in python
2220         files, and that was causing test_parse_log_entries_from_changelog() to fail
2221         when the whitespace on line 275 was removed).
2222
2223         * Scripts/webkitpy/common/checkout/changelog.py:
2224         (ChangeLog):
2225         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2226         (test_fuzzy_reviewer_match__none):
2227         (test_fuzzy_reviewer_match_adam_barth):
2228         (test_fuzzy_reviewer_match_darin_adler_et_al):
2229         (test_fuzzy_reviewer_match_dimitri_glazkov):
2230         (test_fuzzy_reviewer_match_george_staikos):
2231         (test_fuzzy_reviewer_match_mark_rowe):
2232
2233 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
2234
2235         webkitpy: committers_unittest fuzzy matching is really slow
2236         https://bugs.webkit.org/show_bug.cgi?id=79179
2237
2238         Reviewed by Ryosuke Niwa.
2239
2240         Break the fuzzy matching tests into individual routines for
2241         each contributor so that the intent is a little clearer, so
2242         that it's easier to test individual names (and identify
2243         duplicate tests), and so that we can eventually run
2244         them in parallel.
2245
2246         Also, mark most of them as 'integration' tests so that they
2247         can be skipped if we want to go fast (we leave a few as
2248         regular tests for functional coverage).
2249
2250         * Scripts/webkitpy/common/config/committers_unittest.py:
2251         (CommittersTest):
2252         (CommittersTest.test_contributors_by_fuzzy_match):
2253         (CommittersTest.integration_test_contributors__none):
2254         (CommittersTest.integration_test_contributors__none_2):
2255         (CommittersTest.integration_test_contributors__none_3):
2256         (CommittersTest.integration_test_contributors_ada_chan):
2257         (CommittersTest.integration_test_contributors_adele_peterson):
2258         (CommittersTest.integration_test_contributors_alexey_proskuryakov):
2259         (CommittersTest.integration_test_contributors_alice_liu):
2260         (CommittersTest.integration_test_contributors_alp_toker):
2261         (CommittersTest.integration_test_contributors_anders_carlsson):
2262         (CommittersTest.integration_test_contributors_antti_koivisto):
2263         (CommittersTest.integration_test_contributors_beth_dakin):
2264         (CommittersTest.integration_test_contributors_brady_eidson):
2265         (CommittersTest.integration_test_contributors_cameron_zwarich):
2266         (CommittersTest.integration_test_contributors_chris_blumenberg):
2267         (CommittersTest.integration_test_contributors_dan_bernstein):
2268         (CommittersTest.integration_test_contributors_dan_bernstein_2):
2269         (CommittersTest.integration_test_contributors_darin_adler):
2270         (CommittersTest.integration_test_contributors_david_harrison):
2271         (CommittersTest.integration_test_contributors_david_harrison_2):
2272         (CommittersTest.integration_test_contributors_david_hyatt):
2273         (CommittersTest.integration_test_contributors_david_kilzer):
2274         (CommittersTest.integration_test_contributors_don_melton):
2275         (CommittersTest.integration_test_contributors_eric_seidel):
2276         (CommittersTest.integration_test_contributors_geoffrey_garen):
2277         (CommittersTest.integration_test_contributors_greg_bolsinga):
2278         (CommittersTest.integration_test_contributors_holger_freyther):
2279         (CommittersTest.integration_test_contributors_jon_sullivan):
2280         (CommittersTest.integration_test_contributors_jon_honeycutt):
2281         (CommittersTest.integration_test_contributors_joseph_pecoraro):
2282         (CommittersTest.integration_test_contributors_ken_kocienda):
2283         (CommittersTest.integration_test_contributors_kenneth_russell):
2284         (CommittersTest.integration_test_contributors_kevin_decker):
2285         (CommittersTest.integration_test_contributors_kevin_mccullough):
2286         (CommittersTest.integration_test_contributors_lars_knoll):
2287         (CommittersTest.integration_test_contributors_lars_weintraub):
2288         (CommittersTest.integration_test_contributors_maciej_stachowiak):
2289         (CommittersTest.integration_test_contributors_mark_rowe):
2290         (CommittersTest.integration_test_contributors_nikolas_zimmermann):
2291         (CommittersTest.integration_test_contributors_oliver_hunt):
2292         (CommittersTest.integration_test_contributors_rniwa):
2293         (CommittersTest.disabled_integration_test_contributors_simon_fraser):
2294         (CommittersTest.integration_test_contributors_steve_falkenburg):
2295         (CommittersTest.integration_test_contributors_sam_weinig):
2296         (CommittersTest.integration_test_contributors_tim_omernick):
2297         (CommittersTest.integration_test_contributors_timothy_hatcher):
2298         (CommittersTest.integration_test_contributors_tor_arne_vestbo):
2299         (CommittersTest.integration_test_contributors_vicki_murley):
2300         (CommittersTest.integration_test_contributors_zack_rusin):
2301
2302 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
2303
2304         webkitpy: should autoinstall coverage
2305         https://bugs.webkit.org/show_bug.cgi?id=79535
2306
2307         Reviewed by Eric Seidel.
2308
2309         We should automatically print the coverage report after the run, too.
2310
2311         * Scripts/webkitpy/test/main.py:
2312         (Tester._run_tests):
2313         * Scripts/webkitpy/thirdparty/__init__.py:
2314         (AutoinstallImportHook.find_module):
2315         (AutoinstallImportHook._install_coverage):
2316
2317 2012-02-24  Pablo Flouret  <pablof@motorola.com>
2318
2319         Fix copypasta in build-webkit's --vibration option description
2320         https://bugs.webkit.org/show_bug.cgi?id=79528
2321
2322         Reviewed by Andreas Kling.
2323
2324         * Scripts/build-webkit:
2325
2326 2012-02-24  Antonio Gomes  <agomes@rim.com>
2327
2328         Adding myself to ScrollingCoordinator watchlist
2329         https://bugs.webkit.org/show_bug.cgi?id=79525
2330
2331         Reviewed by Rob Buis.
2332
2333         * Scripts/webkitpy/common/config/watchlist:
2334
2335 2012-02-24  Darin Fisher  <darin@chromium.org>
2336
2337         Update watchlist for ChromiumPublicApi to include Platform/chromium/public/
2338
2339         Reviewed by Adam Barth.
2340
2341         * Scripts/webkitpy/common/config/watchlist:
2342
2343 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
2344
2345         webkitpy: config_unittest is sensitive to other tests that might've already run
2346         https://bugs.webkit.org/show_bug.cgi?id=79382
2347
2348         Reviewed by Adam Barth.
2349
2350         If another test runs prior to config_unittest and pokes the
2351         cached configuration, the first test in config_unittest might
2352         fail; the tearDown() will then allow subsequent tests to pass.
2353         Clearing the configuration prior to each test makes things
2354         slightly slower but safer.
2355
2356         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2357         (ConfigTest.setUp):
2358
2359 2012-02-24  David Kilzer  <ddkilzer@apple.com>
2360
2361         Use xcrun to find compiler paths for Generate Derived Sources build phase script
2362         <http://webkit.org/b/79512>
2363
2364         Reviewed by Dan Bernstein.
2365
2366         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2367         (Generate Derived Sources): Use xcrun to find the path to the
2368         compiler since that works on both iOS and OS X.
2369
2370 2012-02-24  James Robinson  <jamesr@chromium.org>
2371
2372         Create a watchlist for ScrollingCoordinator changes
2373         https://bugs.webkit.org/show_bug.cgi?id=79511
2374
2375         Reviewed by Anders Carlsson.
2376
2377         * Scripts/webkitpy/common/config/watchlist:
2378
2379 2012-02-24  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
2380
2381         [EFL][DRT] Implement setValueForUser and setAutofilled.
2382         https://bugs.webkit.org/show_bug.cgi?id=79237
2383
2384         Reviewed by Andreas Kling.
2385
2386         Adds missing implementation setValueForUser and setAutofilled to EFL's LayoutTestController.
2387         Those implementations are related with input fields and allow to pass following tests:
2388         fast/forms/onchange-setvalueforuser.html
2389         fast/forms/input-autofilled.html
2390         fast/forms/reset-autofilled.html
2391
2392         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2393         (LayoutTestController::setValueForUser):
2394         (LayoutTestController::setAutofilled):
2395
2396 2012-02-24  Zoltan Horvath  <zoltan@webkit.org>
2397
2398         [Qt] Allow to use WebCore imagedecoders
2399         https://bugs.webkit.org/show_bug.cgi?id=32410
2400
2401         Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.
2402
2403         Reviewed by Simon Hausmann.
2404
2405         * qmake/mkspecs/features/features.prf:
2406
2407 2012-02-24  Balazs Kelemen  <kbalazs@webkit.org>
2408
2409         [Qt] Add Qt5 way to force 96 DPI for tests
2410         https://bugs.webkit.org/show_bug.cgi?id=79364
2411
2412         Reviewed by Simon Hausmann.
2413
2414         * DumpRenderTree/qt/main.cpp:
2415         (main):
2416         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2417         (WTR::activateFonts):
2418
2419 2012-02-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2420
2421         [GTK] MiniBrowser should reload the view then the reload button is clicked
2422         https://bugs.webkit.org/show_bug.cgi?id=79472
2423
2424         Reviewed by Philippe Normand.
2425
2426         * MiniBrowser/gtk/BrowserWindow.c:
2427         (reloadCallback): Call webkit_web_view_reload().
2428         (browser_window_init): Connect reload item clicked even to
2429         reloadCallback instead of activateUriEntryCallback.
2430
2431 2012-02-24  Kentaro Hara  <haraken@chromium.org>
2432
2433         Add performance tests for DOM attribute getters and setters
2434         https://bugs.webkit.org/show_bug.cgi?id=79208
2435
2436         Reviewed by Ryosuke Niwa.
2437
2438         We want to allow perf tests to output info messages
2439         that do not affect the test results. To accomplish this,
2440         this patch modifies perftestsrunner.py so that it ignores
2441         a line that starts from "Info:".
2442
2443         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2444         (PerfTestsRunner):
2445
2446 2012-02-24  Andrew Lo  <anlo@rim.com>
2447
2448         [BlackBerry] Enable requestAnimationFrame
2449         https://bugs.webkit.org/show_bug.cgi?id=79408
2450
2451         Enable requestAnimationFrame for BlackBerry.
2452
2453         Reviewed by Rob Buis.
2454
2455         * Scripts/build-webkit:
2456
2457 2012-02-24  Adam Barth  <abarth@webkit.org>
2458
2459         style-queue tries to apply the patch twice
2460         https://bugs.webkit.org/show_bug.cgi?id=79459
2461
2462         Reviewed by Eric Seidel.
2463
2464         Previously, we applied the patch using both apply-patch and
2465         check-style.  This patch introduces a check-style-local to mirror the
2466         apply-watchlist-local, which operates on the current working diff.
2467
2468         This patch also cleans up some other bugs I found by running the queue
2469         locally for a while.  The queue still prints out a slightly
2470         less-than-ideal message on the bugs when it find an error, but it's ok
2471         for now.  We'll need to iterate a bit.
2472
2473         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
2474         (StyleQueueTask.validate):
2475         (StyleQueueTask._check_style):
2476         * Scripts/webkitpy/tool/commands/download.py:
2477         (CheckStyleLocal):
2478         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2479         (EarlyWarningSytemTest._default_expected_stderr):
2480         (EarlyWarningSytemTest._test_testing_ews):
2481         * Scripts/webkitpy/tool/commands/queues.py:
2482         (AbstractReviewQueue.handle_script_error):
2483         (StyleQueue.review_patch):
2484         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2485         * Scripts/webkitpy/tool/commands/queuestest.py:
2486         (QueuesTest.assert_queue_outputs):
2487
2488 2012-02-23  Adam Barth  <abarth@webkit.org>
2489
2490         should_proceed_with_work_item is unused and can be removed
2491         https://bugs.webkit.org/show_bug.cgi?id=79416
2492
2493         Reviewed by Eric Seidel.
2494
2495         We used to use this function to check whether the tree is red.  Now, we
2496         don't use external measures of whether to proceed with work items.
2497         Instead, we analyze them with the idea in mind that the tree might be
2498         red.
2499
2500         * Scripts/webkitpy/tool/bot/queueengine.py:
2501         (QueueEngineDelegate.next_work_item):
2502         (QueueEngine.run):
2503         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2504         (LoggingDelegate):
2505         (LoggingDelegate.next_work_item):
2506         (RaisingDelegate.process_work_item):
2507         (QueueEngineTest.test_terminating_error):
2508         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2509         (AbstractEarlyWarningSystem.__init__):
2510         * Scripts/webkitpy/tool/commands/queues.py:
2511         (AbstractQueue.next_work_item):
2512         (FeederQueue.next_work_item):
2513         (CommitQueue.next_work_item):
2514         (AbstractReviewQueue.next_work_item):
2515         (StyleQueue.__init__):
2516         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2517         (FeederQueueTest.test_feeder_queue):
2518         (CommitQueueTest.test_commit_queue):
2519         (test_commit_queue_failure):
2520         (test_commit_queue_failure_with_failing_tests):
2521         (test_rollout):
2522         (test_rollout_lands):
2523         (StyleQueueTest.test_style_queue_with_style_exception):
2524         (test_style_queue_with_watch_list_exception):
2525         * Scripts/webkitpy/tool/commands/queuestest.py:
2526         (QueuesTest.assert_queue_outputs):
2527         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2528         (SheriffBot.next_work_item):
2529
2530 2012-02-23  Adrienne Walker  <enne@google.com>
2531
2532         Unreviewed, add Stephen Chenney to committers.py as a contributor.
2533
2534         * Scripts/webkitpy/common/config/committers.py:
2535
2536 2012-02-23  Adam Barth  <abarth@webkit.org>
2537
2538         style-queue logs bogus messages to the QueueStatusServer
2539         https://bugs.webkit.org/show_bug.cgi?id=79424
2540
2541         Reviewed by Eric Seidel.
2542
2543         Copy/paste error.
2544
2545         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
2546         (StyleQueueTask._check_style):
2547         (StyleQueueTask._apply_watch_list):
2548         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2549
2550 2012-02-23  Eric Seidel  <eric@webkit.org>
2551
2552         Use self._filesystem in more places in the SCM classes
2553         https://bugs.webkit.org/show_bug.cgi?id=79415
2554
2555         Reviewed by Adam Barth.
2556
2557         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
2558         (SCMDetectorTest.test_detect_scm_system):
2559         * Scripts/webkitpy/common/checkout/scm/git.py:
2560         (Git.find_checkout_root):
2561         (Git.to_object_name):
2562         * Scripts/webkitpy/common/checkout/scm/scm.py:
2563         (SCM.__init__):
2564         (SCM.in_working_directory):
2565         * Scripts/webkitpy/common/checkout/scm/svn.py:
2566         (SVN.find_uuid):
2567         (SVN.find_checkout_root):
2568
2569 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2570
2571         Unreviewed, rolling out r108685.
2572         http://trac.webkit.org/changeset/108685
2573         https://bugs.webkit.org/show_bug.cgi?id=79414
2574
2575         Broke Chromium builds (Requested by enne on #webkit).
2576
2577         * qmake/mkspecs/features/features.prf:
2578
2579 2012-02-23  Adam Barth  <abarth@webkit.org>
2580
2581         style-queue shouldn't spam bugs if it fails to update its working copy
2582         https://bugs.webkit.org/show_bug.cgi?id=79412
2583
2584         Reviewed by Eric Seidel.
2585
2586         This patch moves style-queue over to the new PatchAnalysisTask
2587         infrastructure, which is smarter about retrying patches when update
2588         fails.
2589
2590         * Scripts/webkitpy/common/system/executive_mock.py:
2591         (MockExecutive.run_and_throw_if_fail):
2592         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
2593         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2594         (UnableToApplyPatch):
2595         (UnableToApplyPatch.__init__):
2596         (PatchAnalysisTask.__init__):
2597         * Scripts/webkitpy/tool/bot/stylequeuetask.py: Added.
2598         (StyleQueueTaskDelegate):
2599         (StyleQueueTaskDelegate.parent_command):
2600         (StyleQueueTask):
2601         (StyleQueueTask.validate):
2602         (StyleQueueTask._check_style):
2603         (StyleQueueTask._apply_watch_list):
2604         (StyleQueueTask.run):
2605         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2606         * Scripts/webkitpy/tool/commands/queues.py:
2607         (StyleQueue):
2608         (StyleQueue.should_proceed_with_work_item):
2609         (StyleQueue.review_patch):
2610         (StyleQueue.run_command):
2611         (StyleQueue.command_passed):
2612         (StyleQueue.command_failed):
2613         (StyleQueue.expected_failures):
2614         (StyleQueue.refetch_patch):
2615         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2616         (StyleQueueTest.test_style_queue_with_style_exception):
2617         (test_style_queue_with_watch_list_exception):
2618
2619 2012-02-23  Zoltan Horvath  <zoltan@webkit.org>
2620
2621         [Qt] Allow to use WebCore imagedecoders
2622         https://bugs.webkit.org/show_bug.cgi?id=32410
2623
2624         Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.
2625
2626         Reviewed by Simon Hausmann.
2627
2628         * qmake/mkspecs/features/features.prf:
2629
2630 2012-02-23  Eric Seidel  <eric@webkit.org>
2631
2632         Remove old broken find_checkout_root tests now that find_checkout_root is gone
2633         https://bugs.webkit.org/show_bug.cgi?id=79405
2634
2635         Reviewed by Adam Barth.
2636
2637         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py: Added.
2638         (SCMDetectorTest):
2639         (SCMDetectorTest.test_find_checkout_root):
2640         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2641         (SVNTestRepository.tear_down):
2642
2643 2012-02-23  Michael Brüning  <michael.bruning@nokia.com>
2644
2645         [Qt][WK2] Implement proxy authentication dialog.
2646         https://bugs.webkit.org/show_bug.cgi?id=79350
2647
2648         Reviewed by Simon Hausmann.
2649
2650         * MiniBrowser/qt/MiniBrowser.qrc:
2651         * MiniBrowser/qt/qml/BrowserWindow.qml:
2652         * MiniBrowser/qt/qml/ProxyAuthenticationDialog.qml: Added.
2653
2654 2012-02-23  Kevin Ollivier  <kevino@theolliviers.com>
2655
2656         [wx] Build fix, add recently added source dirs.
2657
2658         * waf/build/settings.py:
2659
2660 2012-02-23  Simon Hausmann  <simon.hausmann@nokia.com>
2661
2662         [Qt] Add support for touch cancellation
2663         https://bugs.webkit.org/show_bug.cgi?id=79348
2664
2665         Reviewed by Kenneth Rohde Christiansen.
2666
2667         Added straight-forward touch cancellation event sending to Qt WK1 DRT
2668         and WK2 WTR.
2669
2670         * DumpRenderTree/qt/EventSenderQt.cpp:
2671         (EventSender::touchCancel):
2672         (EventSender::cancelTouchPoint):
2673         * DumpRenderTree/qt/EventSenderQt.h:
2674         (EventSender):
2675         * WebKitTestRunner/EventSenderProxy.h:
2676         (EventSenderProxy):
2677         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2678         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2679         (WTR::EventSendingController::touchCancel):
2680         (WTR):
2681         (WTR::EventSendingController::cancelTouchPoint):
2682         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2683         (EventSendingController):
2684         * WebKitTestRunner/TestController.cpp:
2685         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2686         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
2687         (WTR::EventSenderProxy::touchCancel):
2688         (WTR):
2689         (WTR::EventSenderProxy::cancelTouchPoint):
2690
2691 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2692
2693         Unreviewed, rolling out r108626.
2694         http://trac.webkit.org/changeset/108626
2695         https://bugs.webkit.org/show_bug.cgi?id=79370
2696
2697         broke qt-wk2 bot, somehow the workaround does not work on the
2698         bot (Requested by Ossy on #webkit).
2699
2700         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2701         (WTR::WrapperWindow::handleStatusChanged):
2702         (WTR::PlatformWebView::resizeTo):
2703
2704 2012-02-23  ChangSeok Oh  <shivamidow@gmail.com>
2705
2706         [GTK] DRT doesn't support scheduleAsynchronousKeyDown.
2707         https://bugs.webkit.org/show_bug.cgi?id=78481
2708
2709         Reviewed by Gustavo Noronha Silva.
2710
2711         Extracted shareable code from keyDownCallback and then added createKeyPressEvent
2712         to create gdk press key event.
2713         Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly
2714         and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown.
2715
2716         * DumpRenderTree/gtk/EventSender.cpp:
2717         (scheduleAsynchronousClickCallback):
2718         (createKeyPressEvent):
2719         (sendKeyDown):
2720         (keyDownCallback):
2721         (sendAsynchronousKeyDown):
2722         (scheduleAsynchronousKeyDownCallback):
2723
2724 2012-02-23  Balazs Kelemen  <kbalazs@webkit.org>
2725
2726         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
2727         https://bugs.webkit.org/show_bug.cgi?id=76546
2728
2729         Reviewed by Simon Hausmann.
2730
2731         Co-authored with Simon Hausmann.
2732
2733         Revert the workaround introduced in r107868 and reintroduce
2734         the qml binding so we can test the code path that we are more
2735         interested in. The reason that it did not work before is that
2736         we don't have an active platform window which we now workaround
2737         by propagating the resize through QWindowSystemInterface.
2738
2739         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2740         (WTR::WrapperWindow::handleStatusChanged):
2741         (WTR::PlatformWebView::resizeTo):
2742
2743 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2744
2745         Unreviewed, rolling out r108577.
2746         http://trac.webkit.org/changeset/108577
2747         https://bugs.webkit.org/show_bug.cgi?id=79359
2748
2749         It doesn't work as expected (Requested by Ossy on #webkit).
2750
2751         * DumpRenderTree/qt/EventSenderQt.cpp:
2752         (EventSender::postEvent):
2753         * DumpRenderTree/qt/EventSenderQt.h:
2754         (EventSender):
2755
2756 2012-02-23  Philippe Normand  <pnormand@igalia.com>
2757
2758         [GTK] FullScreen signals
2759         https://bugs.webkit.org/show_bug.cgi?id=76181
2760
2761         Reviewed by Martin Robinson.
2762
2763         Use the two new entering/leaving fullscreen signals to hide/show
2764         the tool bar, the status bar and ask the user's permission before
2765         entering fullscreen.
2766
2767         * GtkLauncher/main.c:
2768         (webViewFullscreenMessageWindowClose):
2769         (webViewWindowStateEvent):
2770         (hide_widget):
2771         (show_widget):
2772         (webViewEnteringFullScreen):
2773         (webViewLeavingFullScreen):
2774         (createBrowser):
2775         (createWindow):
2776
2777 2012-02-22  Dongwoo Im  <dw.im@samsung.com>
2778
2779         [EFL] Fix to launch the EWebLauncher using the script, run-launcher.
2780         https://bugs.webkit.org/show_bug.cgi?id=79076
2781
2782         Reviewed by Andreas Kling.
2783
2784         * Scripts/webkitdirs.pm: Fix the path of libewebkit.so.
2785         (builtDylibPathForName):
2786
2787 2012-02-22  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2788
2789         [Qt] Add eventSender.gestureTap
2790         https://bugs.webkit.org/show_bug.cgi?id=66173
2791
2792         Reviewed by Kenneth Rohde Christiansen.
2793
2794         * DumpRenderTree/qt/EventSenderQt.cpp:
2795         (EventSender::gestureTap):
2796         * DumpRenderTree/qt/EventSenderQt.h:
2797
2798 2012-02-22  Brady Eidson  <beidson@apple.com>
2799
2800         <rdar://problem/10406044> and https://bugs.webkit.org/show_bug.cgi?id=79279
2801         Synchronous ShouldGoToBackForwardListItem causes lots of WebProcess hangs
2802
2803         Reviewed by Anders Carlsson.
2804
2805         Update our tools to the new form of the PageLoadClient.
2806
2807         * MiniBrowser/mac/BrowserWindowController.m:
2808         (-[BrowserWindowController awakeFromNib]): 
2809
2810         * WebKitTestRunner/TestController.cpp:
2811         (WTR::TestController::initialize):
2812
2813 2012-02-22  Daniel Bates  <dbates@webkit.org>
2814
2815         new-run-webkit-tests shouldn't restore Safari state on Lion when showing results
2816         https://bugs.webkit.org/show_bug.cgi?id=79277
2817
2818         Reviewed by Adam Barth.
2819
2820         Pass command line argument no-saved-state to run-safari to disable Safari
2821         state restoration for the session on OS 10.7.
2822
2823         * Scripts/webkitpy/layout_tests/port/mac.py:
2824         (MacPort.show_results_html_file):
2825         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2826         (test_show_results_html_file):
2827
2828 2012-02-22  Kalev Lember  <kalevlember@gmail.com>
2829
2830         Explicitly include unistd.h in TestNetscapePlugIn for GCC 4.7
2831         https://bugs.webkit.org/show_bug.cgi?id=77759
2832
2833         Reviewed by Tony Chang.
2834
2835         Fixes build with gcc 4.7.
2836
2837         r100432 added the include only for ANDROID; this changes the ifdef to
2838         also cover other unix platforms. On Fedora 17 the gcc 4.7 compiler no
2839         longer implicitly includes unistd.h from standard headers and other
2840         unix platforms are likely to get gcc 4.7 as well in the future.
2841
2842         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2843
2844 2012-02-22  Philippe Normand  <pnormand@igalia.com>
2845
2846         Unreviewed, rolling out r108522.
2847         http://trac.webkit.org/changeset/108522
2848         https://bugs.webkit.org/show_bug.cgi?id=76181
2849
2850         Broke 4 fullscreen tests on GTK.
2851
2852         * GtkLauncher/main.c:
2853         (createBrowser):
2854         (createWindow):
2855
2856 2012-02-20  Philippe Normand  <pnormand@igalia.com>
2857
2858         [GTK] FullScreen signals
2859         https://bugs.webkit.org/show_bug.cgi?id=76181
2860
2861         Reviewed by Martin Robinson.
2862
2863         Use the two new entering/leaving fullscreen signals to hide/show
2864         the tool bar, the status bar and ask the user's permission before
2865         entering fullscreen.
2866
2867         * GtkLauncher/main.c:
2868         (webViewFullscreenMessageWindowClose):
2869         (webViewWindowStateEvent):
2870         (hide_widget):
2871         (show_widget):
2872         (webViewEnteringFullScreen):
2873         (webViewLeavingFullScreen):
2874         (createBrowser):
2875         (createWindow):
2876
2877 2012-02-22  Rob Flack  <flackr@chromium.org>
2878
2879         Update Linux ChromiumOS builders in flakiness dashboard.
2880         https://bugs.webkit.org/show_bug.cgi?id=79238
2881
2882         Reviewed by Ojan Vafai.
2883
2884         * TestResultServer/static-dashboards/builders.js:
2885
2886 2012-02-22  Dirk Pranke  <dpranke@chromium.org>
2887
2888         webkitpy: test_function_length_check_definition_huge_lines is slow
2889         https://bugs.webkit.org/show_bug.cgi?id=79185
2890
2891         Reviewed by Adam Barth.
2892
2893         This test takes ~3 seconds to run, apparently because we're
2894         running a test on a 10,000 line function :). Dropping the
2895         function length to 640 still exercises the code path and
2896         provides a 10x speedup.
2897
2898         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2899         (CppStyleTest):
2900         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines):
2901
2902 2012-02-22  Dirk Pranke  <dpranke@chromium.org>
2903
2904         webkitpy: speed up FileLockTest.test_lock_lifecycle
2905         https://bugs.webkit.org/show_bug.cgi?id=79189
2906
2907         Reviewed by Adam Barth.
2908
2909         The unit test had a second lock trying to acquire a
2910         lock already held, and a hard-coded timeout of one second.
2911         I have changed the timeouts to a tenth of a second (which
2912         is probably still fine) and changed the hard-spin on
2913         the lock to a slow-spin every hundredth of a second.
2914
2915         * Scripts/webkitpy/common/system/file_lock.py:
2916         (FileLock.acquire_lock):
2917         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
2918         (FileLockTest.setUp):
2919         (FileLockTest.test_stuck_lock):
2920
2921 2012-02-22  Gabor Rapcsanyi  <rgabor@webkit.org>
2922
2923         build-webkit should use environment variable at number of CPU
2924         detection on all platform
2925         https://bugs.webkit.org/show_bug.cgi?id=79227
2926
2927         Reviewed by Martin Robinson.
2928
2929         * Scripts/webkitdirs.pm:
2930         (determineNumberOfCPUs):
2931
2932 2012-02-22  Mihnea Ovidenie  <mihnea@adobe.com>
2933
2934         [Qt] REGRESSION(r108108): It made 3 fast/repaint tests fail
2935         https://bugs.webkit.org/show_bug.cgi?id=78960
2936
2937         Reviewed by Csaba Osztrogonác.
2938
2939         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2940         (LayoutTestController::overridePreference):
2941
2942 2012-02-22  Hao Zheng  <zhenghao@chromium.org>
2943
2944         [chromium] Build WebKit with MEDIA_STREAM disabled.
2945         https://bugs.webkit.org/show_bug.cgi?id=79214
2946
2947         Reviewed by Kent Tamura.
2948
2949         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
2950         * DumpRenderTree/chromium/WebUserMediaClientMock.h:
2951         * DumpRenderTree/chromium/WebViewHost.cpp:
2952         (WebViewHost::createMediaPlayer):
2953         * DumpRenderTree/chromium/WebViewHost.h:
2954         (WebViewHost):
2955
2956 2012-02-22  Zeno Albisser  <zeno@webkit.org>
2957
2958         [Qt][WK2][Mac] WebKitTestRunner does not build with clang.
2959         https://bugs.webkit.org/show_bug.cgi?id=79124
2960
2961         WebKitTestRunnerPrefix.h should also be included
2962         when building with clang.
2963
2964         Reviewed by Kenneth Rohde Christiansen.
2965
2966         * WebKitTestRunner/Target.pri:
2967
2968 2012-02-20  Roland Steiner  <rolandsteiner@chromium.org>
2969
2970         <style scoped>: Add runtime-flag
2971         https://bugs.webkit.org/show_bug.cgi?id=79074
2972
2973         Enable the runtime-flag for DRT. 
2974
2975         Reviewed by Dimitri Glazkov.
2976
2977         * DumpRenderTree/chromium/TestShell.cpp:
2978         (TestShell::TestShell):
2979
2980 2012-02-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2981
2982         Unreviewed, rolling out r107351.
2983         http://trac.webkit.org/changeset/107351
2984         https://bugs.webkit.org/show_bug.cgi?id=53600
2985
2986         Several issues introduced in WebKitGTK+ API
2987
2988         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2989         (createWebView):
2990         * GtkLauncher/main.c:
2991         (createWebViewCb):
2992         (createBrowser):
2993         (createWindow):
2994         (main):
2995
2996 2012-02-21  Filip Pizlo  <fpizlo@apple.com>
2997
2998         JSC should be a triple-tier VM
2999         https://bugs.webkit.org/show_bug.cgi?id=75812
3000         <rdar://problem/10079694>
3001
3002         Reviewed by Gavin Barraclough.
3003
3004         Changed EFL's build system to include a new directory in JavaScriptCore.
3005
3006         * DumpRenderTree/efl/CMakeLists.txt:
3007
3008 2012-02-21  Daniel Cheng  <dcheng@chromium.org>
3009
3010         [chromium] Fix image drag out on Chromium
3011         https://bugs.webkit.org/show_bug.cgi?id=79158
3012
3013         Reviewed by Tony Chang.
3014
3015         * DumpRenderTree/chromium/EventSender.cpp:
3016         (EventSender::dumpFilenameBeingDragged):
3017         (EventSender::beginDragWithFiles):
3018         * DumpRenderTree/chromium/WebViewHost.cpp:
3019         (addDRTFakeFileToDataObject):
3020
3021 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
3022
3023         webkitpy: speed up hot filesystem_mock functions
3024         https://bugs.webkit.org/show_bug.cgi?id=79159
3025
3026         Reviewed by Adam Barth.
3027
3028         Profiling run_webkit_tests_integrationtest.py revealed that
3029         isdir(), normpath(), and join() are called a lot and were very
3030         slow.This patch speeds them up substantially, shaving 20 seconds
3031         off of the execution time.
3032
3033         * Scripts/webkitpy/common/system/filesystem_mock.py:
3034         (MockFileSystem.isdir):
3035         (MockFileSystem._slow_but_correct_join):
3036         (MockFileSystem.join):
3037         (MockFileSystem.listdir):
3038         (MockFileSystem._slow_but_correct_normpath):
3039         (MockFileSystem.normpath):
3040         (MockFileSystem.write_binary_file):
3041         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
3042         (MockFileSystemTest.quick_check):
3043         (MockFileSystemTest):
3044         (MockFileSystemTest.test_join):
3045         (MockFileSystemTest.test_normpath):
3046         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
3047         (get_test_config): Call write_binary_file() instead of updating
3048           filesystem.files directly, so that we create directories as
3049           needed.
3050
3051 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
3052
3053         nrwt: make the delay between starting workers configurable per-port
3054         https://bugs.webkit.org/show_bug.cgi?id=79148
3055
3056         Reviewed by Eric Seidel.
3057
3058         Because of bug 79147, we have to sleep a bit in between starting
3059         DRTs; however, doing so across the board slows down the Test
3060         port. Making this configurable shaves 10 seconds off of
3061         run_webkit_tests_integrationtest.py
3062         
3063         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3064         (Manager._run_tests):
3065         * Scripts/webkitpy/layout_tests/port/base.py:
3066         (Port.worker_startup_delay_secs):
3067         * Scripts/webkitpy/layout_tests/port/test.py:
3068         (TestPort.worker_startup_delay_secs):
3069
3070 2012-02-21  Jon Lee  <jonlee@apple.com>
3071
3072         Bring notifications support to WK1 mac
3073         https://bugs.webkit.org/show_bug.cgi?id=78783
3074         <rdar://problem/10610578>
3075
3076         Reviewed by Anders Carlsson.
3077
3078         * DumpRenderTree/mac/UIDelegate.mm: Refactor WebGeolocationPolicyListener to WebAllowDenyPolicyListener.
3079         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
3080         (-[UIDelegate timerFired]):
3081
3082 2012-02-21  Kentaro Hara  <haraken@chromium.org>
3083
3084         Enable the IDL attribute checker in run-bindings-tests
3085         https://bugs.webkit.org/show_bug.cgi?id=79091
3086
3087         Reviewed by Adam Barth.
3088
3089         We have enabled the IDL attribute checker in Chromium in r108322.
3090         This patch enables the IDL attribute checker in run-bindings-tests.
3091
3092         No tests. I manually checked that [Custommm], [CallWith=],
3093         [CallWith=ScriptExecutionContext|Foo] in TestObj.idl cause
3094         run-bindings-tests failures.
3095
3096         * Scripts/webkitpy/bindings/main.py:
3097         (BindingsTests.generate_supplemental_dependency):
3098
3099 2012-02-21  Rafael Weinstein  <rafaelw@chromium.org>
3100
3101         Add rafaelw as a committer.
3102
3103         Unreviewed.
3104
3105         * Scripts/webkitpy/common/config/committers.py:
3106
3107 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
3108
3109         webkitpy: update names after deleting message_broker
3110         https://bugs.webkit.org/show_bug.cgi?id=79000
3111
3112         Reviewed by Eric Seidel.
3113
3114         Part 3 of 3 in deleting message_broker.py; this change just
3115         adjusts the names for the newly merged symbols so that they are
3116         private as appropriate.
3117
3118         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3119         (get):
3120         (_Broker):
3121         (_BrokerConnection):
3122         (_BrokerConnection.__init__):
3123         (AbstractWorker.__init__):
3124         (_ManagerConnection):
3125         (_ManagerConnection.__init__):
3126         (_WorkerConnection):
3127         (_WorkerConnection.__init__):
3128
3129 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
3130
3131         webkitpy: merge message_broker.py into manager_worker_broker.py
3132         https://bugs.webkit.org/show_bug.cgi?id=78999
3133
3134         Reviewed by Tony Chang.
3135
3136         This is pretty much a straight cut-and-paste of one file into
3137         another (broken up so that docstrings and imports are in the
3138         right place).
3139
3140         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3141         (BrokerClient):
3142         (BrokerClient.is_done):
3143         (BrokerClient.name):
3144         (Broker):
3145         (Broker.__init__):
3146         (Broker.add_topic):
3147         (Broker._get_queue_for_topic):
3148         (Broker.post_message):
3149         (Broker.run_message_loop):
3150         (Broker.run_all_pending):
3151         (Broker._run_loop):
3152         (Broker._dispatch_message):
3153         (_Message):
3154         (_Message.loads):
3155         (_Message.__init__):
3156         (_Message.dumps):
3157         (_Message.__repr__):
3158         (BrokerConnection):
3159         (BrokerConnection.__init__):
3160         (BrokerConnection.run_message_loop):
3161         (BrokerConnection.post_message):
3162         (BrokerConnection.raise_exception):
3163         * Scripts/webkitpy/layout_tests/controllers/message_broker.py: Removed.
3164
3165 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
3166
3167         webkitpy: prepare to delete message_broker.py
3168         https://bugs.webkit.org/show_bug.cgi?id=78997
3169
3170         Reviewed by Eric Seidel.
3171
3172         This is part 1 of 3 changes to fix bug 78187. This change
3173         prepares the code for merging message_broker.py into
3174         manager_worker_broker.py; the tests in message_broker_unittest
3175         are merged into manager_worker_broker_unittest, the symbols
3176         needed by the tests are exported from manager_worker_broker.py,
3177         and manager_worker_broker itself is updated to refer to the
3178         symbols directly (without the module prefix).
3179
3180         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3181         (get):
3182         (AbstractWorker):
3183         (AbstractWorker.__init__):
3184         (_ManagerConnection):
3185         (_ManagerConnection.__init__):
3186         (_WorkerConnection):
3187         (_WorkerConnection.__init__):
3188         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3189         (InterfaceTest.test_brokerclient_is_abstract):
3190         (InterfaceTest.test_brokerclient_is_abstract.methods):
3191         (MessageTest):
3192         (MessageTest.test__no_body):
3193         (MessageTest.test__body):
3194         * Scripts/webkitpy/layout_tests/controllers/message_broker_unittest.py: Removed.
3195
3196 2012-02-21  Sam Weinig  <sam@webkit.org>
3197
3198         Attempt to fix the Snow Leopard build.
3199
3200         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3201         * MiniBrowser/Configurations/Base.xcconfig:
3202         * TestWebKitAPI/Configurations/Base.xcconfig:
3203         * WebKitTestRunner/Configurations/Base.xcconfig:
3204
3205 2012-02-21  Sam Weinig  <sam@webkit.org>
3206
3207         Use libc++ when building with Clang on Mac
3208         https://bugs.webkit.org/show_bug.cgi?id=78981
3209
3210         Reviewed by Dan Bernstein.
3211
3212         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3213         * MiniBrowser/Configurations/Base.xcconfig:
3214         * TestWebKitAPI/Configurations/Base.xcconfig:
3215         * WebKitTestRunner/Configurations/Base.xcconfig:
3216
3217 2012-02-21  Adam Roben  <aroben@apple.com>
3218
3219         Roll out r108309, r108323, and r108326
3220
3221         They broke the 32-bit Lion build.
3222
3223         Original bugs is <http://webkit.org/b/75812> <rdar://problem/10079694>.
3224
3225         * DumpRenderTree/efl/CMakeLists.txt:
3226
3227 2012-02-21  Andras Becsi  <andras.becsi@nokia.com>
3228
3229         [Qt][WK2] Get rid of the dependency to QtWidgets
3230         https://bugs.webkit.org/show_bug.cgi?id=76276
3231
3232         Reviewed by Simon Hausmann.
3233
3234         * MiniBrowser/qt/MiniBrowser.pro:
3235         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3236         (MiniBrowserApplication::MiniBrowserApplication):
3237         (MiniBrowserApplication::notify):
3238         (MiniBrowserApplication::sendTouchEvent):
3239         * MiniBrowser/qt/MiniBrowserApplication.h:
3240         (MiniBrowserApplication):
3241         * QtTestBrowser/locationedit.h:
3242         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3243         (WTR::activateFonts):
3244         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3245
3246 2012-02-20  Adam Barth  <abarth@webkit.org>
3247
3248         mastercfg_unittest.py fails without simplejson
3249         https://bugs.webkit.org/show_bug.cgi?id=79070
3250
3251         Reviewed by Csaba Osztrogonác.
3252
3253         Now that we require Python 2.6 (and higher) we can import json rather
3254         than simplejson.  We still need to use the simplejson name because
3255         that's what the master.cfg script expects.
3256
3257         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3258         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules):
3259
3260 2012-02-20  Filip Pizlo  <fpizlo@apple.com>
3261
3262         JSC should be a triple-tier VM
3263         https://bugs.webkit.org/show_bug.cgi?id=75812
3264         <rdar://problem/10079694>
3265
3266         Reviewed by Gavin Barraclough.
3267
3268         Changed EFL's build system to include a new directory in JavaScriptCore.
3269
3270         * DumpRenderTree/efl/CMakeLists.txt:
3271
3272 2012-02-20  Kenichi Ishibashi  <bashi@chromium.org>
3273
3274         Update pywebsocket to 0.7.2
3275         https://bugs.webkit.org/show_bug.cgi?id=79066
3276
3277         This version includes vendor-prefixed deflate-frame extension support.
3278
3279         Reviewed by Kent Tamura.
3280
3281         * Scripts/webkitpy/thirdparty/__init__.py:
3282         (AutoinstallImportHook._install_pywebsocket):
3283
3284 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
3285
3286         [UNIX] Plugin information fields are not interpreted as UTF-8
3287         https://bugs.webkit.org/show_bug.cgi?id=78635
3288
3289         Reviewed by Gustavo Noronha Silva.
3290
3291         Interpret plugin metadata as UTF8 aways. This matches the behavior
3292         of Chromium and the Totem plugin.
3293
3294         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3295         (NPP_GetValue): Include a UTF-8 character in the description string for testing purposes.
3296
3297 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
3298
3299         [GTK] [Qt] Move the unix forwarding headers for TestNetscapePlugin to the TestNetscapePlugin directory
3300         https://bugs.webkit.org/show_bug.cgi?id=78935
3301
3302         Reviewed by Gustavo Noronha Silva.
3303
3304         Move the TestNetscapePlugin headers to a more appropriate directory and update
3305         the build files to match.
3306
3307         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h.
3308         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h.
3309         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h.
3310         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update build.
3311         * GNUmakefile.am: Ditto.
3312
3313 2012-02-20  Kihong Kwon  <kihong.kwon@samsung.com>
3314
3315         Add a new API for the Vibration API(W3C).
3316         https://bugs.webkit.org/show_bug.cgi?id=72010
3317
3318         Reviewed by Hajime Morita.
3319
3320         * Scripts/build-webkit: Enable ENABLE_VIBRATION feature.
3321
3322 2012-02-20  János Badics  <dicska@gmail.com>
3323
3324         [Qt] run-qtwebkit-tests doesn't consider timeouts as failures
3325         https://bugs.webkit.org/show_bug.cgi?id=71816
3326
3327         RunQtAPITests will notify if a timeout occurs during testing.
3328         Added unittest to the master.cfg
3329
3330         Reviewed by Csaba Osztrogonác.
3331
3332         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3333         (RunQtAPITests.evaluateCommand):
3334         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3335         (RunQtAPITestsTest):
3336         (RunQtAPITestsTest.assertResults):
3337         (RunQtAPITestsTest.test_timeout):
3338         (test_success):
3339         (test_failure):
3340         (test_timeout_and_failure):
3341
3342 2012-02-20  Andy Wingo  <wingo@igalia.com>
3343
3344         Add wingo as a committer.
3345
3346         Unreviewed.
3347
3348         * Scripts/webkitpy/common/config/committers.py: Add myself to the
3349         committers list.
3350
3351 2012-02-20  Jochen Eisinger  <jochen@chromium.org>
3352
3353         [chromium] check that we're not running multiple modal dialogs at the same time
3354         https://bugs.webkit.org/show_bug.cgi?id=78486
3355
3356         Reviewed by Kent Tamura.
3357
3358         * DumpRenderTree/chromium/TestShell.cpp:
3359         (TestShell::TestShell):
3360         * DumpRenderTree/chromium/TestShell.h:
3361         (TestShell::setIsDisplayingModalDialog):
3362         (TestShell::isDisplayingModalDialog):
3363         (TestShell):
3364         * DumpRenderTree/chromium/WebViewHost.cpp:
3365         (WebViewHost::runModal):
3366
3367 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
3368
3369         Fix WebKit2GTK+ for 'make distcheck'.
3370
3371         Instead of conditionally including WebKit2 GNUmakefiles, always
3372         include them and conditionally activate the final targets.
3373
3374         * MiniBrowser/gtk/GNUmakefile.am:
3375         * WebKitTestRunner/GNUmakefile.am:
3376
3377 2012-02-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3378
3379         Enable video option for EFL port in build-webkit.
3380         https://bugs.webkit.org/show_bug.cgi?id=79006
3381
3382         Reviewed by Daniel Bates.
3383
3384         * Scripts/build-webkit:
3385
3386 2012-02-19  JungJik Lee  <jungjik.lee@samsung.com>
3387
3388         [EFL] Use modifier keys to execute pre-rendering.
3389         https://bugs.webkit.org/show_bug.cgi?id=77933
3390
3391         Reviewed by Chang Shu.
3392
3393         Use modifier key to execute pre-rendering instead of using reserved function keys.
3394
3395         * EWebLauncher/main.c:
3396         (on_key_down):
3397
3398 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
3399
3400         Fix one more dangling reference to worker_connection.name, delete unused code.
3401
3402         Unreviewed, build fix.
3403
3404         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3405         (Manager.update):
3406         (_WorkerState.__init__):
3407
3408 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
3409
3410         Add a change that should've been in r108005.
3411
3412         Unreviewed, build fix.
3413
3414         In the refactoring/cleanup in r108005 I should've changed the
3415         implementation of WorkerConnection to make it match BrokerClient
3416         (and everything else) so that objects had a name() method
3417         instead of a name property.
3418
3419         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3420         (Manager._run_tests):
3421         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3422         (_WorkerConnection.__init__):
3423         (_WorkerConnection.name):
3424         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3425         (_TestWorker.__init__):
3426         (_TestsMixin.name):
3427         (_TestsMixin.test_name):
3428         (_TestsMixin.test_cancel):
3429         (_TestsMixin.test_unknown_message):
3430
3431 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
3432
3433         webkitpy: remove webkitpy.common.array_stream
3434         https://bugs.webkit.org/show_bug.cgi?id=78952
3435
3436         Reviewed by Eric Seidel.
3437
3438         Turns out array_stream didn't really do anything that StringIO
3439         didn't do (at least as of Python 2.6). This change removes it
3440         and updates all of the callers. Where possible, I changed the
3441         test assertions in order to capture the intent more clearly,
3442         e.g., instead of calling self.assertTrue('foo' in stream.get()),
3443         we have self.assertContainsLine(stream, 'foo'), and instead of
3444         self.assertTrue(stream.empty()), we have self.assertEmpty(stream) -
3445         the latter isn't that much more readable, but StringIO doesn't
3446         export an empty() method.
3447
3448         * Scripts/webkitpy/common/array_stream.py: Removed.
3449         * Scripts/webkitpy/common/array_stream_unittest.py: Removed.
3450         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3451         (passing_run):
3452         (run_and_capture):
3453         (StreamTestingMixin):
3454         (StreamTestingMixin.assertContains):
3455         (StreamTestingMixin.assertContainsLine):
3456         (StreamTestingMixin.assertEmpty):
3457         (StreamTestingMixin.assertNotEmpty):
3458         (LintTest):
3459         (LintTest.test_lint_test_files):
3460         (LintTest.test_lint_test_files__errors):
3461         (MainTest):
3462         (MainTest.test_child_process_1):
3463         (MainTest.test_child_processes_2):
3464         (MainTest.test_child_processes_min):
3465         (MainTest.test_help_printing):
3466         (MainTest.test_hung_thread):
3467         (MainTest.test_no_tests_found):
3468         (MainTest.test_no_tests_found_2):
3469         (MainTest.test_repeat_each_iterations_num_tests):
3470         (MainTest.test_test_list):
3471         (MainTest.test_unexpected_failures):
3472         (MainTest.test_worker_model__inline_with_child_processes):
3473         (MainTest.test_additional_platform_directory):
3474         (RebaselineTest):
3475         (RebaselineTest.assertBaselines):
3476         (RebaselineTest.test_reset_results):
3477         (RebaselineTest.test_missing_results):
3478         (RebaselineTest.test_new_baseline):
3479         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3480         (MeteredStream.update):
3481         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
3482         (TestMeteredStream.test_regular):
3483         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3484         (TestUtilityFunctions.assertEmpty):
3485         (TestUtilityFunctions):
3486         (TestUtilityFunctions.assertNotEmpty):
3487         (TestUtilityFunctions.assertWritten):
3488         (TestUtilityFunctions.test_configure_logging):
3489         (Testprinter.assertEmpty):
3490         (Testprinter):
3491         (Testprinter.assertNotEmpty):
3492         (Testprinter.assertWritten):
3493         (Testprinter.reset):
3494         (Testprinter.get_printer):
3495         (Testprinter.test_help_printer):
3496         (Testprinter.do_switch_tests.do_helper):
3497         (Testprinter.test_print_one_line_summary):
3498         (Testprinter.test_print_test_result):
3499         (Testprinter.test_print_progress):
3500         (Testprinter.test_write_nothing):
3501         (Testprinter.test_write_misc):
3502         (Testprinter.test_write_everything):
3503         (Testprinter.test_write_verbose):
3504         (Testprinter.test_print_unexpected_results):
3505         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3506         (MainTest.assertWritten):
3507         (create_runner):
3508         (test_run_test_set):
3509         (test_run_test_set_kills_drt_per_run):
3510         (test_run_test_set_for_parser_tests):
3511         (test_run_test_set_with_json_output):
3512         (test_run_test_set_with_json_source):
3513         (test_run_test_set_with_multiple_repositories):
3514         (test_upload_json):
3515
3516 2012-02-18  Kevin Ollivier  <kevino@theolliviers.com>
3517
3518         [wx] Add the WebCore/page/scrolling directory to the build dirs.
3519
3520         * waf/build/settings.py:
3521
3522 2012-02-18  Kevin Ollivier  <kevino@theolliviers.com>
3523
3524         [wx] Unreviewed build fix. Don't error out or hang if we have
3525         downloaded dependencies but server update check fails.
3526
3527         * waf/build/build_utils.py:
3528         (download_if_newer):
3529
3530 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
3531
3532         The new run-webkit-tests needs to dump out pixel hash failures even if the pixel test passes.
3533         https://bugs.webkit.org/show_bug.cgi?id=69444
3534
3535         Reviewed by Tony Chang.
3536
3537         Currently if a test's image checksum doesn't match the checksum
3538         in the baseline, but the images themselves match according to
3539         ImageDiff, new-run-webkit-tests ignores the problem. This is
3540         probably bad, but it's not yet clear what the right thing to do
3541         is. This patch will log a warning to stderr, at least (but the
3542         test will still pass).
3543
3544         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3545         (SingleTestRunner._compare_image):
3546         (SingleTestRunner._run_reftest):
3547         * Scripts/webkitpy/layout_tests/port/test.py:
3548         (unit_test_list):
3549         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3550
3551 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
3552
3553         NRWT does not report failure for a skipped test
3554         https://bugs.webkit.org/show_bug.cgi?id=78750
3555
3556         Reviewed by Eric Seidel.
3557
3558         If a test is listed in a Skipped file and you run it anyway
3559         with --force, and the test fails, currently NRWT will print
3560         "test ran as expected"; this is confusing, because you probably
3561         expect the test to fail and yet this might lead you to think the
3562         test passed. This patch changes the expected behavior to "PASS",
3563         so tests that fail will be reported.
3564
3565         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3566         (result_was_expected):
3567         (TestExpectationParser):
3568         (TestExpectationParser.expectation_for_skipped_test):
3569         (TestExpectations):
3570         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3571         (test_add_skipped_tests):
3572         * Scripts/webkitpy/layout_tests/port/test.py:
3573         (unit_test_list): Add some tests that are expected to be in a Skipped file.
3574         (TestPort.skipped_tests): This adds actual integration test coverage of Skipped files.
3575
3576 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
3577
3578         webkitpy: fix test code after bug 78181
3579         https://bugs.webkit.org/show_bug.cgi?id=78870
3580
3581         Reviewed by Adam Barth.
3582
3583         I forgot to update the test code as per Tony's suggestion in
3584         bug 78181 (r108005). This change does that, and in doing so
3585         it revealed a subtle bug in _InlineWorkerConnection.run() that
3586         I am fixing as part of this (_alive would not be cleared if an
3587         exception was thrown).
3588
3589         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3590         (_InlineWorkerConnection.run):
3591         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3592         (_TestWorker.__init__):
3593         (_TestWorker.handle_stop):
3594         (_TestWorker.handle_test):
3595         (_TestWorker.run):
3596         (_TestsMixin.handle_exception):
3597         (_TestsMixin.test_unknown_message):
3598
3599 2012-02-17  Adam Roben  <aroben@apple.com>
3600
3601         Mac build fix after r108119
3602
3603         * DumpRenderTree/mac/DumpRenderTree.mm:
3604         (runThread):
3605         (runPthread):
3606         (testThreadIdentifierMap):
3607         Updated to match current WTF threading APIs.
3608
3609 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
3610
3611         revert r107147 - breaks webkit-patch on Mac SL
3612         https://bugs.webkit.org/show_bug.cgi?id=78866
3613
3614         Reviewed by Adam Barth.
3615
3616         It appears that zipfile.ExtractAll is broken on Python 2.6.1,
3617         which is the version that ships on Mac SL. Reverting this
3618         change until we no longer have to worry about that version.
3619
3620         * Scripts/webkitpy/common/system/autoinstall.py:
3621         (AutoInstaller):
3622         (AutoInstaller._extract_all): Added a comment about SL.
3623         (AutoInstaller._unzip):
3624
3625 2012-02-17  Mihnea Ovidenie  <mihnea@adobe.com>
3626
3627         CSS regions enabled by default
3628         https://bugs.webkit.org/show_bug.cgi?id=78525
3629
3630         Reviewed by David Hyatt.
3631
3632         Add a runtime preference to enable/disable regions functionality at runtime(WebKitCSSRegionsEnabled).
3633         CSSRegions are still enabled by default.
3634         In DRT, use layoutTestController.overridePreference("WebKitCSSRegionsEnabled", "0") to disable the css regions functionality.
3635
3636         * DumpRenderTree/chromium/LayoutTestController.cpp:
3637         (LayoutTestController::overridePreference):
3638         * DumpRenderTree/chromium/WebPreferences.cpp:
3639         (WebPreferences::reset):
3640         (WebPreferences::applyTo):
3641         * DumpRenderTree/chromium/WebPreferences.h:
3642         (WebPreferences):
3643         * DumpRenderTree/mac/DumpRenderTree.mm:
3644         (resetDefaultsToConsistentValues):
3645
3646 2012-02-17  Maciej Stachowiak  <mjs@apple.com>
3647
3648         Some API tests erroneously use = instead of == (causing build failures)
3649         https://bugs.webkit.org/show_bug.cgi?id=78915
3650
3651         Reviewed by Sam Weinig.
3652
3653         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3654         (TestWebKitAPI::decidePolicyForNavigationAction): Replace an = with an ==
3655         (TestWebKitAPI::decidePolicyForNewWindowAction): ditto
3656
3657 2012-02-17  Peter Beverloo  <peter@chromium.org>
3658
3659         [Chromium] Include TestShellLinux.cpp in the build for Android
3660         https://bugs.webkit.org/show_bug.cgi?id=78865
3661
3662         Reviewed by Eric Seidel.
3663
3664         Android will be re-using the TestShellLinux.cpp file. I already
3665         added this r104033, but it seems to have gotten lost in the
3666         recent refactorings.
3667
3668         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3669
3670 2012-02-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3671
3672         Unreviewed, disable video build on EFL until it can be
3673         supported by EFL build bot.
3674
3675         * Scripts/build-webkit:
3676
3677 2012-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3678
3679         [GTK] Implement zoom in/out in MiniBrowser
3680         https://bugs.webkit.org/show_bug.cgi?id=75253
3681
3682         Reviewed by Gustavo Noronha Silva.
3683
3684         * MiniBrowser/gtk/BrowserWindow.c:
3685         (browserWindowCanZoomIn):
3686         (browserWindowCanZoomOut):
3687         (browserWindowUpdateZoomActions):
3688         (webViewZoomLevelChanged):
3689         (zoomInCallback):
3690         (zoomOutCallback):
3691         (browser_window_init):
3692         (browserWindowConstructed):
3693
3694 2012-02-17  Nikolas Zimmermann  <nzimmermann@rim.com>
3695
3696         layoutTestController.display() is flaky for SVG tests
3697         https://bugs.webkit.org/show_bug.cgi?id=78021
3698
3699         Reviewed by Adam Roben.
3700
3701         Apply the same fix to DRT/Win, as previously applied to DRT/Mac.
3702         Size the web view before running the test, not when dumping.
3703         All platforms handle this correctly now.
3704
3705         * DumpRenderTree/win/DumpRenderTree.cpp:
3706         (dump):
3707         (sizeWebViewForCurrentTest):
3708         (runTest):
3709
3710 2012-02-16  Carlos Garcia Campos  <cgarcia@igalia.com>
3711
3712         [GTK] Make install is broken when building without --enable-gtk-doc
3713         https://bugs.webkit.org/show_bug.cgi?id=78828
3714
3715         Reviewed by Martin Robinson.
3716
3717         * gtk/generate-gtkdoc:
3718         (rebase_installed_docs): Check documentation has been generated
3719         before trying to rebase it.
3720
3721 2012-02-16  Dirk Pranke  <dpranke@chromium.org>
3722
3723         nrwt: simplify worker interface
3724         https://bugs.webkit.org/show_bug.cgi?id=78181
3725