fdf70c002246a2b6a59d33bc65fd0acb1772a801
[WebKit-https.git] / Tools / ChangeLog
1 2011-09-21  Xianzhu Wang  <wangxianzhu@chromium.org>
2
3         Ensure TestWebKitAPI works on mac, win, chromium-mac and chromium-linux
4         https://bugs.webkit.org/show_bug.cgi?id=68206
5
6         Reviewed by Tony Chang.
7
8         * Scripts/webkitdirs.pm:
9         (determineBaseProductDir): add support for chromium-mac
10         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
11         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
12
13 2011-09-21  Adam Barth  <abarth@webkit.org>
14
15         garden-o-matic command should explain that it is starting a local server
16         https://bugs.webkit.org/show_bug.cgi?id=68486
17
18         Reviewed by Dimitri Glazkov.
19
20         In the user study, both participants didn't understand why the
21         garden-o-matic command appeared to hang.  This patch adds an
22         explaination of what's going on.  It also adds a confirmation prompt
23         before launching the browser to give the user a chance to read the
24         text.  If that's too much of a speed bump, we can iterate.
25
26         * Scripts/webkitpy/tool/commands/gardenomatic.py:
27
28 2011-09-21  Chang Shu  <cshu@webkit.org>
29
30         [Qt] Implement KeyDown function for WebKit2 EventSender.
31         https://bugs.webkit.org/show_bug.cgi?id=56485
32
33         Implement the KeyDown function on Qt platform.
34
35         Reviewed by Andreas Kling.
36
37         * WebKitTestRunner/PlatformWebView.h:
38         * WebKitTestRunner/TestController.cpp:
39         (WTR::TestController::TestController):
40         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
41         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Added.
42         (WTR::getModifiers):
43         (WTR::EventSenderProxy::keyDown):
44         (buildModifierFlags):
45         (EventSenderProxy::keyDown):
46         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
47         (WTR::PlatformWebView::sendEvent):
48         * WebKitTestRunner/qt/WebKitTestRunner.pro:
49
50 2011-09-20  Adam Barth  <abarth@webkit.org>
51
52         garden-o-matic unit test fail because Safari 5.1 doesn't enumerate dictionaries in the same order as V8
53         https://bugs.webkit.org/show_bug.cgi?id=68496
54
55         Reviewed by Dimitri Glazkov.
56
57         This patch adds a bunch of sorting to make sure things happen in a
58         predictable order in both JavaScriptCore and V8.  We've talked before
59         about whether these two JavaScript engines should enumerate
60         dictionaries in the same order, but the consensus has been that they
61         shouldn't.  Personally, I disagree with that consensus, but such is life.
62
63         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
64         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
65         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
66         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
67
68 2011-09-20  Adam Barth  <abarth@webkit.org>
69
70         garden-o-matic doesn't work in Safari 5.1 because Safari 5.1 lacks Function.prototype.bind
71         https://bugs.webkit.org/show_bug.cgi?id=68495
72
73         Reviewed by Dimitri Glazkov.
74
75         This patch adds an implementation of Function.prototype.bind if the browser lacks one.
76
77         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
78
79 2011-09-20  Eric Seidel  <eric@webkit.org>
80
81         [NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
82         https://bugs.webkit.org/show_bug.cgi?id=65781
83
84         Reviewed by Ryosuke Niwa.
85
86         Instead of making NRWT create the symlink, I made DumpRenderTree smart enough
87         to resolve the passed in url relative to the absolute url for the test.
88         For http tests, since the test url is an http url, we can't resolve relative
89         to the test path, and thus use a new LOCAL_RESOURCE_ROOT environment variable
90         for resolving.
91
92         I believe this is a better approach than the on used in the Qt and Chromium DRT's
93         (which resolves the path relative to the built location of the DRT executable)
94         and we should move this new code into a shared location in a follow-up patch.
95
96         It turns out that there was a second use for pathToLocalResource, used by one
97         test (http/tests/plugins/post-url-file.html) used for getting a path to /tmp.
98         To support this test I made the new pathToLocalResource smart enough to map
99         /tmp to DUMPRENDERTREE_TEMP (which is already defined for all ports).
100
101         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
102         (LayoutTestController::pathToLocalResource):
103         * Scripts/webkitpy/layout_tests/port/webkit.py: Set LOCAL_RESOURCE_ROOT for use by DRT.
104
105 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
106
107         Need to specify a django version, instead of using default
108         https://bugs.webkit.org/show_bug.cgi?id=68398
109
110         Reviewed by Eric Seidel.
111
112         * QueueStatusServer/__init__.py:
113         * QueueStatusServer/main.py:
114
115 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
116
117         Update committers.py with a few more contributor contacts
118         https://bugs.webkit.org/show_bug.cgi?id=68487
119
120         Reviewed by Eric Seidel.
121
122         * Scripts/webkitpy/common/config/committers.py:
123
124 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
125
126         Fix webkitpy unit tests after 95547 and 95549
127         https://bugs.webkit.org/show_bug.cgi?id=68483
128
129         Reviewed by Adam Barth.
130         
131         Fix tests for ChangeLog.touched_files() and ChangeLog.parse_entries_from_file().
132
133         * Scripts/webkitpy/common/checkout/changelog_unittest.py: While testing
134         parse_entries_from_file(), use StringIO and entry.reviewer_text().
135         While testing parse_latest_entry_from_file(), expect the correct
136         touched_files() list.
137
138 2011-09-20  Adam Barth  <abarth@webkit.org>
139
140         garden-o-matic makes it hard to compare images when scroll bars appear
141         https://bugs.webkit.org/show_bug.cgi?id=68482
142
143         Reviewed by Eric Seidel.
144
145         Because we autoscale image width, the images rescale if we overflow
146         vertically and get a scrollbar.  That makes it hard to compare two sets
147         of images.  This patch reserves space for the scrollbar so we won't
148         have the layout change.
149
150         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
151
152 2011-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
153
154         Unreviewed, rolling out r95565.
155         http://trac.webkit.org/changeset/95565
156         https://bugs.webkit.org/show_bug.cgi?id=68470
157
158         Broke builds (Requested by andersca on #webkit).
159
160         * MiniBrowser/gtk/BrowserWindow.c:
161         (mouseDidMoveOverElement):
162
163 2011-09-20  Nayan Kumar K  <nayankk@motorola.com>
164
165         Get hover'ed element URL from HitTest.
166         
167         mouseDidMoveOverElement now gets the hover'ed element link using
168         WKHitTestResult API's.
169         https://bugs.webkit.org/show_bug.cgi?id=68426
170
171         Reviewed by Anders Carlsson.
172
173         * MiniBrowser/gtk/BrowserWindow.c:
174         (mouseDidMoveOverElement):
175
176 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
177
178         Changelog class should have a method to return all entries
179         https://bugs.webkit.org/show_bug.cgi?id=68399
180         
181         Implement ChangeLog.parse_entries_from_file(). This method returns a generator
182         of ChangeLogEntry objects, ordered from the latest to the oldest entry in the file.
183
184         Reviewed by Ryosuke Niwa.
185
186         * Scripts/webkitpy/common/checkout/changelog.py: Copy parse_latest_entry_from_file()
187         and adapt it to become a generator.
188         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Add test case.
189
190 2011-09-20  Jarred Nicholls  <jarred@sencha.com>
191
192         [Qt] Permit qrc resources to load in QWebSettings::setUserStyleSheetUrl()
193         https://bugs.webkit.org/show_bug.cgi?id=51159
194
195         Permit any URL with a local scheme to set a user style sheet. Allow qrc
196         resource URLs as arguments to QWebSettings::setUserStyleSheetUrl().
197         
198         Add DRT/WKTR qrc resource to test loading user style sheets from a qrc URL.
199
200         Reviewed by Kenneth Rohde Christiansen.
201
202         * DumpRenderTree/qt/DumpRenderTree.pro:
203         * DumpRenderTree/qt/DumpRenderTree.qrc: Added.
204         * DumpRenderTree/qt/resources/user.css: Added.
205         (body):
206         * WebKitTestRunner/qt/WebKitTestRunner.pro:
207         * WebKitTestRunner/qt/WebKitTestRunner.qrc: Added.
208         * WebKitTestRunner/qt/resources/user.css: Added.
209         (body):
210
211 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
212
213         ChangeLogEntry class should contain a list of touched files
214         https://bugs.webkit.org/show_bug.cgi?id=68115
215
216         Reviewed by Eric Seidel.
217         
218         Add method to return the list of files touched in a ChangeLog entry.
219
220         * Scripts/webkitpy/common/checkout/changelog.py: Add
221         touched_files_regexp and touched_files() method.
222         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Implement
223         unit tests for touched_files() method.
224
225 2011-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
226
227         Unreviewed, rolling out r95526 and r95541.
228         http://trac.webkit.org/changeset/95526
229         http://trac.webkit.org/changeset/95541
230         https://bugs.webkit.org/show_bug.cgi?id=68443
231
232         It broke 6 tests (Requested by ossy_ on #webkit).
233
234         * DumpRenderTree/qt/main.cpp:
235         (main):
236         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
237         (WTR::activateFonts):
238
239 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
240
241         Fix patch and bug numbering in the mocktool simulation code
242         https://bugs.webkit.org/show_bug.cgi?id=68374
243
244         Reviewed by Adam Barth.
245
246         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
247         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
248         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
249         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
250         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
251         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
252         * Scripts/webkitpy/tool/commands/download_unittest.py:
253         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
254         * Scripts/webkitpy/tool/commands/queries_unittest.py:
255         * Scripts/webkitpy/tool/commands/queues_unittest.py:
256         * Scripts/webkitpy/tool/commands/queuestest.py:
257         * Scripts/webkitpy/tool/commands/upload_unittest.py:
258         * Scripts/webkitpy/tool/mocktool.py:
259         * Scripts/webkitpy/tool/steps/steps_unittest.py:
260         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
261
262 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
263
264         [Qt] Don't override default QApplication font for DRT and WTR
265
266         Revision 95526 moved the relevant code below the QApplication
267         constructor, to fix a potential crash, and that made the code
268         take effect, breaking 6 tests.
269
270         We should rely on the QWebSettings to set default fonts, and
271         this QApplication::setFont() is a relic from when we didn't
272         have that option, so we remove the code.
273
274         Reviewed by Csaba Osztrogonác.
275
276         * DumpRenderTree/qt/main.cpp:
277         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
278
279 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
280
281         WebKitTestRunner: Provide usage if run without arguments
282
283         If WTR is run without either one or more filenames, or
284         a '-' to indicate server mode, we don't need to start
285         up the test machinery. Doing so might actually crash,
286         as we'll exit the application immedeatly after anyways.
287
288         Reviewed by Simon Hausmann.
289
290         * WebKitTestRunner/TestController.cpp:
291         (WTR::TestController::initialize):
292
293 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
294
295         [Qt] Don't use QFont before initializing QApplication
296
297         Could potentially result in crash.
298
299         Reviewed by Simon Hausmann.
300
301         * DumpRenderTree/qt/main.cpp:
302         (main):
303
304 2011-09-19  Adam Barth  <abarth@webkit.org>
305
306         Always enable ENABLE(EVENTSOURCE)
307         https://bugs.webkit.org/show_bug.cgi?id=68414
308
309         Reviewed by Eric Seidel.
310
311         * Scripts/build-webkit:
312
313 2011-09-19  David Levin  <levin@chromium.org>
314
315         Sheriffbot rollout should be more intuitive.
316         https://bugs.webkit.org/show_bug.cgi?id=68415
317
318         Reviewed by Adam Barth.
319
320         * Scripts/webkitpy/tool/bot/irc_command.py: Add support for revert and comma separated args.
321         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Add parsing tests for comma separated args
322           and a few others cases.
323         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Verify that revert works.
324
325 2011-09-19  David Levin  <levin@chromium.org>
326
327         check-webkit-style generates bogus warning for StructuredExceptionHandlerSupressor.h
328         https://bugs.webkit.org/show_bug.cgi?id=68391
329
330         Reviewed by Darin Adler.
331
332         * Scripts/webkitpy/style/checkers/cpp.py: Skip __asm lines when doing style checks on a line.
333         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added a test for this.
334
335 2011-09-19  Alexis Menard  <alexis.menard@openbossa.org>
336
337         Style checker should not check public Qt WK2 API for parameter_name.
338         https://bugs.webkit.org/show_bug.cgi?id=68359
339
340         Reviewed by Andreas Kling.
341
342         The public Qt WK2 APIs have different rules than WebKit for parameters of methods in h files.
343         Add an exception in the style checker to disable the check. Also added the test for it.
344
345         * Scripts/webkitpy/style/checker.py:
346         * Scripts/webkitpy/style/checker_unittest.py:
347
348 2011-09-19  Leandro Pereira  <leandro@profusion.mobi>
349
350         GTK DRT leaks memory while comparing history items
351         https://bugs.webkit.org/show_bug.cgi?id=68086
352
353         Reviewed by Martin Robinson.
354         
355         webkit_web_history_item_get_target() returns a g_strdup()'d string,
356         so memory must be freed before compareHistoryItems() returns.
357
358         * DumpRenderTree/gtk/DumpRenderTree.cpp:
359         (compareHistoryItems): Use GOwnPtr to manage memory automatically.
360
361 2011-09-19  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
362
363         Buildbot marks a nrwt bot red when tests are missing results
364         https://bugs.webkit.org/show_bug.cgi?id=64812
365
366         Reviewed by Ryosuke Niwa.
367
368         * Scripts/webkitpy/layout_tests/controllers/manager.py:
369         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
370
371 2011-09-19  Jessie Berlin  <jberlin@apple.com>
372
373         Sites that use history pushState or replaceState are recorded in history in Private Browsing
374         mode.
375         https://bugs.webkit.org/show_bug.cgi?id=68208
376
377         Reviewed by Brady Eidson.
378
379         Add a test that the WKContextDidNavigateWithNavigationDataCallback (which is invoked by
380         updateGlobalHistory) is not called in Private Browsing when the page does history.pushState.
381
382         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Added.
383         (TestWebKitAPI::didNavigateWithNavigationData):
384         This is a context history client callback, so it should not be called when in Private
385         Browsing. Add a call to FAIL().
386         (TestWebKitAPI::didSameDocumentNavigationForFrame):
387         This is a page load client callback that happens after the didNavigateWithNavigationData
388         callback. End the test.
389         (TestWebKitAPI::TEST):
390         Enable Private Browsing and load a page that uses history.pushState.
391
392         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
393         Add PrivateBrowsingPushStateNoHistoryCallback.cpp and push-state.html.
394         * TestWebKitAPI/Tests/WebKit2/push-state.html: Added.
395         Ditto.
396         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
397         Ditto.
398         * TestWebKitAPI/win/copy-resources.cmd:
399         Ditto.
400
401 2011-09-16  Elliot Poger  <epoger@google.com>
402
403         add non-CG Webkit-Mac builds to flakiness dashboard
404         https://bugs.webkit.org/show_bug.cgi?id=68265
405
406         Reviewed by Adam Barth.
407
408         As Chromium-on-Mac approaches the switchover from Core Graphics to
409         Skia, we need to add the Skia version to the flakiness dashboard.
410
411         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
412         * TestResultServer/static-dashboards/builders.js:
413         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
414
415 2011-09-16  Jochen Eisinger  <jochen@chromium.org>
416
417         Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter
418         https://bugs.webkit.org/show_bug.cgi?id=68071
419
420         Reviewed by Adam Barth.
421
422         * DumpRenderTree/chromium/WebPermissions.cpp:
423         (WebPermissions::allowImage):
424         * DumpRenderTree/chromium/WebPermissions.h:
425
426 2011-09-16  Tom Zakrajsek  <tomz@codeaurora.org>
427
428         update-webkit-chromium should retry the gclient call if it fails once
429         https://bugs.webkit.org/show_bug.cgi?id=68252
430
431         Reviewed by Adam Barth.
432
433         * Scripts/update-webkit-chromium:
434
435 2011-09-16  Rob Buis  <rbuis@rim.com>
436
437         Add Eli's rim address and change the nick.
438
439         * Scripts/webkitpy/common/config/committers.py:
440
441 2011-09-16  Anders Carlsson  <andersca@apple.com>
442
443         Add back the WKHitTestResultRef parameter to mouseDidMoveOverElement in an ABI preserving way
444         https://bugs.webkit.org/show_bug.cgi?id=68269
445
446         Reviewed by Geoffrey Garen.
447
448         Update client function signatures.
449
450         * MiniBrowser/gtk/BrowserWindow.c:
451         (browserWindowUIClientInit):
452         * MiniBrowser/mac/BrowserWindowController.m:
453         (mouseDidMoveOverElement):
454         (-[BrowserWindowController awakeFromNib]):
455         * MiniBrowser/win/BrowserView.cpp:
456         (BrowserView::create):
457         * WebKitTestRunner/TestController.cpp:
458         (WTR::TestController::createOtherPage):
459         (WTR::TestController::initialize):
460
461 2011-09-16  Anders Carlsson  <andersca@apple.com>
462
463         Temporarily remove the WKHitTestResultRef parameter to avoid breaking the WK2 ABI/API
464         https://bugs.webkit.org/show_bug.cgi?id=68266
465
466         Reviewed by John Sullivan.
467
468         * MiniBrowser/mac/BrowserWindowController.m:
469         (mouseDidMoveOverElement):
470
471 2011-09-16  Vincent Scheib  <scheib@chromium.org>
472
473         Add Vincent Scheib to the committers list.
474
475         * Scripts/webkitpy/common/config/committers.py:
476
477 2011-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>
478
479         Unreviewed, rolling out r95285.
480         http://trac.webkit.org/changeset/95285
481         https://bugs.webkit.org/show_bug.cgi?id=68247
482
483         It broke a webkitpy test (Requested by ossy on #webkit).
484
485         * Scripts/webkitpy/layout_tests/controllers/manager.py:
486
487 2011-09-16  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
488
489         Buildbot marks a nrwt bot red when tests are missing results
490         https://bugs.webkit.org/show_bug.cgi?id=64812
491
492         Reviewed by Dirk Pranke.
493
494         * Scripts/webkitpy/layout_tests/controllers/manager.py:
495
496 2011-09-16  Martin Robinson  <mrobinson@igalia.com>
497
498         [GTK] Disable WebKit2 by default in configure.ac, but enable it with build-webkit
499         https://bugs.webkit.org/show_bug.cgi?id=68178
500
501         Reviewed by Xan Lopez.
502
503         Add a work-around to enable WebKit2 when using build-webkit.
504
505         * Scripts/webkitdirs.pm:
506         (buildAutotoolsProject): 
507
508 2011-09-15  James Robinson  <jamesr@chromium.org>
509
510         Add Antoine Labour and Shawn Singh to the contributors-but-not-committers list.
511
512         * Scripts/webkitpy/common/config/committers.py:
513
514 2011-09-15  Tom Zakrajsek  <tomz@codeaurora.org>
515
516         UpdateChangeLogsWithReviewer should be able to determine reviewer of latest reviewed patch in a bug
517         https://bugs.webkit.org/show_bug.cgi?id=68003
518
519         Reviewed by Adam Barth.
520
521         * Scripts/webkitpy/tool/mocktool.py:
522         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
523         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
524
525 2011-09-15  Tom Zakrajsek  <tomz@codeaurora.org>
526
527         Python version check is confusing in test-webkitpy
528         https://bugs.webkit.org/show_bug.cgi?id=68004
529
530         Reviewed by Adam Barth.
531
532         * Scripts/test-webkitpy:
533
534 2011-09-15  Eric Seidel  <eric@webkit.org>
535
536         Reviewed by Adam Barth.
537
538         webkit-patch should be able to find users and add them to bugzilla groups
539         https://bugs.webkit.org/show_bug.cgi?id=63351
540
541         These are both very basic commands.  But it's now possible to find
542         all users matching a regexp, as well as add all users matching a regexp
543         to a set of groups.
544
545         bugzilla.py already knew how to find users (for validate-committer-lists)
546         but now it has the ability to modify the user records.
547
548         I split some of the logic out into a new EditUsersParser class
549         to try and reduce the amount of code in Bugzilla/BugzillaQueries.
550
551         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
552         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
553         * Scripts/webkitpy/tool/commands/__init__.py:
554         * Scripts/webkitpy/tool/commands/adduserstogroups.py: Added.
555         * Scripts/webkitpy/tool/commands/findusers.py: Added.
556
557 2011-09-15  Eric Seidel  <eric@webkit.org>
558
559         Remove ENABLE(SVG_AS_IMAGE) since all major ports have it on by default
560         https://bugs.webkit.org/show_bug.cgi?id=68182
561
562         Reviewed by Adam Barth.
563
564         * Scripts/build-webkit:
565         * waf/build/settings.py:
566
567 2011-09-15  Eric Seidel  <eric@webkit.org>
568
569         Unreviewed.  Make contributor email look-up case-insensitive.
570
571         validate-committer-list was incorrectly reporting that "chang.shu@nokia.com"
572         was missing from committers.py due to case sensitivity.
573
574         This also includes a test expectations update to committers_unittest.py
575         after my previous change.
576
577         * Scripts/webkitpy/common/config/committers.py:
578         * Scripts/webkitpy/common/config/committers_unittest.py:
579         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
580
581 2011-09-15  Eric Seidel  <eric@webkit.org>
582
583         Unreviewed.  Updated this based on webkit-patch suggest-nominations and validate-committer-list output.
584
585         Add a bunch of email aliases to committers.py for regular contributors
586         who are committing using other email addresses than they have listed in the file.
587
588         * Scripts/webkitpy/common/config/committers.py:
589
590 2011-09-15  Eric Seidel  <eric@webkit.org>
591
592         Remove ENABLE_SVG_ANIMATION as all major ports have it on by default
593         https://bugs.webkit.org/show_bug.cgi?id=68022
594
595         Reviewed by Ryosuke Niwa.
596
597         * Scripts/build-webkit:
598         * waf/build/settings.py:
599
600 2011-09-15  Anders Carlsson  <andersca@apple.com>
601
602         Fix Mac build by including config.h where needed.
603
604         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
605         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
606         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
607         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
608         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
609         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
610         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
611         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
612         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
613         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
614         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
615         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
616         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
617         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
618         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
619         * TestWebKitAPI/mac/main.mm:
620
621 2011-09-15  Xianzhu Wang  <wangxianzhu@chromium.org>
622
623         Let TestWebKitAPI work for chromium
624         https://bugs.webkit.org/show_bug.cgi?id=67756
625
626         Reviewed by Sam Weinig.
627
628         * Scripts/build-api-tests:
629         * Scripts/run-api-tests:
630         (isSupportedPlatform):
631         (runTest):
632         (populateTests):
633         * Scripts/webkitdirs.pm:
634         (determineBaseProductDir):
635         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
636         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
637         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
638         * TestWebKitAPI/InjectedBundleController.cpp:
639         * TestWebKitAPI/InjectedBundleMain.cpp:
640         * TestWebKitAPI/JavaScriptTest.cpp:
641         * TestWebKitAPI/PlatformUtilities.cpp:
642         * TestWebKitAPI/TestWebKitAPI.gypi: Added.
643         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
644         * TestWebKitAPI/TestWebKitAPIPrefix.h: Removed.
645         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
646         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
647         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
648         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
649         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
650         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
651         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
652         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
653         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
654         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
655         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
656         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
657         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
658         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
659         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
660         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
661         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
662         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
663         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
664         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
665         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
666         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
667         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
668         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
669         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp:
670         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
671         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
672         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
673         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
674         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp:
675         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
676         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
677         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
678         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
679         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
680         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
681         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
682         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
683         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
684         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
685         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
686         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
687         * TestWebKitAPI/TestsController.cpp:
688         * TestWebKitAPI/config.h: Copied from TestWebKitAPI/TestWebKitAPIPrefix.h.
689         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp:
690         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
691         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
692         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
693         * TestWebKitAPI/win/main.cpp:
694
695 2011-09-15  Jochen Eisinger  <jochen@chromium.org>
696
697         [chromium] extract normalization of LayoutTests URLs to a method of TestShell
698         https://bugs.webkit.org/show_bug.cgi?id=68145
699
700         This will allow for other classes in DumpRenderTree to reuse this functionality
701
702         Reviewed by David Levin.
703
704         * DumpRenderTree/chromium/TestShell.cpp:
705         (normalizeLayoutTestURLInternal):
706         (dumpHistoryItem):
707         (TestShell::normalizeLayoutTestURL):
708         * DumpRenderTree/chromium/TestShell.h:
709
710 2011-09-14  Ada Chan  <adachan@apple.com>
711
712         Add test for WKBundleFrameCopyWebArchive().
713         https://bugs.webkit.org/show_bug.cgi?id=67857
714
715         Reviewed by Anders Carlsson.
716
717         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp: Added.
718         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Do some basic sanity checks to make sure
719         the returned data is a valid webarchive.
720         (TestWebKitAPI::setInjectedBundleClient):
721         (TestWebKitAPI::didFinishLoadForFrame):
722         (TestWebKitAPI::TEST): Load simple.html in a WebView.  Wait for it to finish loading, and then ask the
723         injected bundle for the webarchive and check the returned webarchive.
724         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp: Added.
725         (TestWebKitAPI::WebArchiveTest::WebArchiveTest):
726         (TestWebKitAPI::WebArchiveTest::didReceiveMessage): Handle the "GetWebArchive" message and return
727         the web archive.
728
729         Add files to project.
730         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Also let Visual Studio reorder a file.
731         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
732         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
733
734 2011-09-14  Ryosuke Niwa  <rniwa@webkit.org>
735
736         committers.py should support multiple IRC nicknames
737         https://bugs.webkit.org/show_bug.cgi?id=68110
738
739         Reviewed by Eric Seidel.
740
741         Add multiple IRC nickname support to committers.py
742
743         * Scripts/webkitpy/common/config/committers.py:
744         * Scripts/webkitpy/common/config/committers_unittest.py:
745         * Scripts/webkitpy/tool/bot/irc_command.py:
746         * Scripts/webkitpy/tool/bot/sheriff.py:
747
748 2011-09-14  Jon Lee  <jonlee@apple.com>
749
750         Implement globalFlag for WebKitTestRunner
751         https://bugs.webkit.org/show_bug.cgi?id=68033
752         <rdar://problem/10119204>
753
754         Reviewed by Sam Weinig.
755
756         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Porting globalFlag from DRT
757         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
758         (WTR::LayoutTestController::LayoutTestController): initialize m_globalFlag to false
759         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: add m_globalFlag
760         (WTR::LayoutTestController::globalFlag): simple getter
761         (WTR::LayoutTestController::setGlobalFlag): simple setter
762
763 2011-09-13  Eric Seidel  <eric@webkit.org>
764
765         Remove ENABLE_SVG_USE as <use> is required by HTML5
766         https://bugs.webkit.org/show_bug.cgi?id=68019
767
768         Reviewed by Ryosuke Niwa.
769
770         * Scripts/build-webkit:
771         * waf/build/settings.py:
772
773 2011-09-14  Ryosuke Niwa  <rniwa@webkit.org>
774
775         Remove Jan Erik Hanssen (added in my r95078) from the list for now
776         since I can't confirm acceptable his committership.
777
778         * Scripts/webkitpy/common/config/committers.py:
779
780 2011-09-14  Jochen Eisinger  <jochen@chromium.org>
781
782         [chromium] Remove obsolete WebViewClient methods from DumpRenderTree.
783         https://bugs.webkit.org/show_bug.cgi?id=68066
784
785         Reviewed by Adam Barth.
786
787         * DumpRenderTree/chromium/WebViewHost.cpp:
788         * DumpRenderTree/chromium/WebViewHost.h:
789
790 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
791
792         committers.py is missing some contributors
793         https://bugs.webkit.org/show_bug.cgi?id=68059
794
795         Reviewed by Adam Barth.
796
797         Add David Barr, Jan Erik Hanssen, and Kim Grönholm.
798
799         Also add nicks of Alejandro G. Castro, Collin Jackson, and Matt Lilek.
800
801         * Scripts/webkitpy/common/config/committers.py:
802
803 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
804
805         Fix webkit python test after r95061.
806
807         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
808
809 2011-09-13  Xianzhu Wang  <wangxianzhu@chromium.org>
810
811         Add myself as a contributor. No review needed.
812
813         * Scripts/webkitpy/common/config/committers.py:
814
815 2011-09-13  Adam Barth  <abarth@webkit.org>
816
817         garden-o-matic has unfriendly error messages when the local server is not available
818         https://bugs.webkit.org/show_bug.cgi?id=68042
819
820         Reviewed by Dimitri Glazkov.
821
822         This patch moves us from using alert to showing the error inline in the
823         progress dialog.
824
825         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
826         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
827         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
828         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
829         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
830
831 2011-09-13  Adam Barth  <abarth@webkit.org>
832
833         FailureGrid in garden-o-matic should link to the builder's waterfall page
834         https://bugs.webkit.org/show_bug.cgi?id=68036
835
836         Reviewed by Dimitri Glazkov.
837
838         One of the users in the user study thought the configurations names in
839         the failure grid would link to the underlying bots.  That makes sense,
840         so this patch adds the behavior.
841
842         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
843         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
844         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
845         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
846
847 2011-09-13  Adam Barth  <abarth@webkit.org>
848
849         garden-o-matic should be able to mark failures as expected
850         https://bugs.webkit.org/show_bug.cgi?id=68027
851
852         Reviewed by Dimitri Glazkov.
853
854         All the back-end infrastructure exists for this operation.  This patch
855         just adds some UI to the front-end and wires that UI up to the back
856         end.  This exact UI will likely need some more polish, but this should
857         be a reasonable first cut.
858
859         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
860         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
861         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
862         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
863         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
864
865 2011-09-13  Adam Barth  <abarth@webkit.org>
866
867         garden-o-matic should tell you about the progress of your rebaseline
868         https://bugs.webkit.org/show_bug.cgi?id=67967
869
870         Reviewed by Dimitri Glazkov.
871
872         This patch adds ui.MessageBox, which is a light wrapper around jQuery
873         UI's dialog widget.  We then use ui.MessageBox to show status messages
874         about in-progress rebaselines.  As each baseline is downloaded, the
875         MessageBox updates.  This UI replaces our temporary "alert"-based UI.
876
877         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
878         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
879         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
880         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
881         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
882         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
883
884 2011-09-13  Leandro Pereira  <leandro@profusion.mobi>
885
886         GTK DumpRenderTree uses inefficient idioms to iterate over G[S]Lists
887         https://bugs.webkit.org/show_bug.cgi?id=68024
888
889         Reviewed by Gustavo Noronha Silva.
890         
891         Using g_list_count() and g_list_nth_data() together on a loop is
892         inneficient since they're both O(n). Iterate over lists in a saner
893         way.
894
895         * DumpRenderTree/gtk/DumpRenderTree.cpp:
896         (dumpHistoryItem): Reduce the scope for the 'kids' variable, and
897         iterate on it using g_list_next(). Free the list after done with it.
898         (dumpBackForwardListForWebView): Instead of appending (which is
899         expensive in GLists) history items and then iterating from the tail
900         of the itemsToPrint list, prepend items and walk forwards as usual.
901         (dumpBackForwardListForAllWebViews): Walk the list in a saner way,
902         remove the (unneeded) viewList variable.
903
904 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
905
906         Add Eric's IRC nick.
907
908         * Scripts/webkitpy/common/config/committers.py:
909
910 2011-09-13  Anders Carlsson  <andersca@apple.com>
911
912         Disable C++ exceptions when building with clang
913         https://bugs.webkit.org/show_bug.cgi?id=68031
914         <rdar://problem/9556880>
915
916         Reviewed by Mark Rowe.
917
918         * MiniBrowser/Configurations/Base.xcconfig:
919         * TestWebKitAPI/Configurations/Base.xcconfig:
920         * WebKitTestRunner/Configurations/Base.xcconfig:
921
922 2011-09-13  Ojan Vafai  <ojan@chromium.org>
923
924         [chromium] fix flakiness dashboard for chromium interactive tests
925         https://bugs.webkit.org/show_bug.cgi?id=68029
926
927         Reviewed by Tony Chang.
928
929         * TestResultServer/static-dashboards/flakiness_dashboard.html:
930         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
931
932 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
933
934         Add Alice and Aryeh to the list of contributors.
935
936         * Scripts/webkitpy/common/config/committers.py:
937
938 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
939
940         sheriffbot whois should also tell us email addresses
941         https://bugs.webkit.org/show_bug.cgi?id=67975
942
943         Reviewed by Eric Seidel and David Levin.
944
945         Taught sheriffbot how to tell us contributor's email addresses.
946
947         * Scripts/webkitpy/tool/bot/irc_command.py:
948         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
949
950 2011-09-13  Eric Seidel  <eric@webkit.org>
951
952         Remove ENABLE_SVG_FOREIGN_OBJECT as it is a required part of HTML5
953         https://bugs.webkit.org/show_bug.cgi?id=68018
954
955         Reviewed by Ryosuke Niwa.
956
957         * Scripts/build-webkit:
958         * waf/build/settings.py:
959
960 2011-09-13  Chang Shu  <cshu@webkit.org>
961
962         [WK2] [Mac] Implement KeyDown function for WebKit2 EventSender.
963         https://bugs.webkit.org/show_bug.cgi?id=57515
964
965         The code change in WebKitTestRunner first sends keydown event from InjectedBundle to
966         TestController synchronously. The latter then sends simulated event to WebKit2 module,
967         which is synchronous, too.
968
969         Reviewed by Darin Adler.
970
971         * WebKitTestRunner/EventSenderProxy.h: Added.
972         (WTR::EventSenderProxy::EventSenderProxy):
973         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
974         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
975         (WTR::EventSendingController::keyDown):
976         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
977         * WebKitTestRunner/PlatformWebView.h:
978         (WTR::PlatformWebView::platformWindow):
979         * WebKitTestRunner/TestController.cpp:
980         (WTR::TestController::TestController):
981         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
982         * WebKitTestRunner/TestController.h:
983         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
984         * WebKitTestRunner/mac/EventSenderProxy.mm: Added.
985         (WTR::buildModifierFlags):
986         (WTR::EventSenderProxy::keyDown):
987
988 2011-09-12  Leandro Pereira  <leandro@profusion.mobi>
989
990         [EFL] DRT: Add DumpRenderTreeEfl.h
991         https://bugs.webkit.org/show_bug.cgi?id=63993
992
993         Reviewed by Eric Seidel.
994         
995         This header contains some global variables used by EFL's
996         DumpRenderTree implementation.
997
998         * DumpRenderTree/DumpRenderTree.h: Include DumpRenderTreeEfl.h when
999         appropriate.
1000         * DumpRenderTree/efl/DumpRenderTreeEfl.h: Added.
1001
1002 2011-09-12  Raphael Kubo da Costa  <kubo@profusion.mobi>
1003
1004         [EFL] Send the right key names for PageUp and PageDown.
1005         https://bugs.webkit.org/show_bug.cgi?id=67044
1006
1007         Reviewed by Kenneth Rohde Christiansen.
1008
1009         PlatformKeyboardEventEfl uses "Prior" and "Next" to refer to PageUp and
1010         PageDown (which is close to the defines in WindowsKeyboardCodes.h).
1011         However, EventSender was sending "Page_Up" and "Page_Down", so tests
1012         such as editing/input/page-up-down-scrolls.html were timing out due to
1013         the right key down events not being sent.
1014
1015         * DumpRenderTree/efl/EventSender.cpp:
1016         (keyPadNameFromJSValue):
1017         (keyNameFromJSValue):
1018
1019 2011-09-12  Eric Seidel  <eric@webkit.org>
1020
1021         sheriffbot whois is case sensitive
1022         https://bugs.webkit.org/show_bug.cgi?id=67972
1023
1024         Reviewed by Adam Barth.
1025
1026         I also fixed a typo in the "More than 5 contributors" message
1027         from my previous commit.
1028
1029         * Scripts/webkitpy/common/config/committers.py:
1030         * Scripts/webkitpy/common/config/committers_unittest.py:
1031         * Scripts/webkitpy/tool/bot/irc_command.py:
1032         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1033
1034 2011-09-12  Eric Seidel  <eric@webkit.org>
1035
1036         sheriffbot whois should be smarter
1037         https://bugs.webkit.org/show_bug.cgi?id=67971
1038
1039         Reviewed by Adam Barth.
1040
1041         This makes sheriffbot whois basically grep the committers list
1042         making it much easier to find a contributor by name.
1043
1044         Unfortunately the current unittests depend on the real committers.py
1045         file, so as we add more eric's to the project, this unittest result will
1046         change.  I think that's OK for now.  We'll fix it when it breaks.
1047
1048         * Scripts/webkitpy/common/config/committers.py:
1049         * Scripts/webkitpy/tool/bot/irc_command.py:
1050         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1051
1052 2011-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1053
1054         Unreviewed, rolling out r94976.
1055         http://trac.webkit.org/changeset/94976
1056         https://bugs.webkit.org/show_bug.cgi?id=67953
1057
1058         Broke a bunch of security/load& tests (Requested by rniwa on
1059         #webkit).
1060
1061         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1062         (LayoutTestController::pathToLocalResource):
1063
1064 2011-09-12  Eric Seidel  <eric@webkit.org>
1065
1066         Rubber-stamped by Adam Barth.
1067
1068         Remove the "the tree is burning!" warning previously shown
1069         when landing patches.  It was a dream.  But it's just noise now.
1070
1071         Some bots will require a restart to notice the removal of the option
1072         so I've left the --ignore-builders option in for now.
1073
1074         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1075         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1076         * Scripts/webkitpy/tool/commands/download.py:
1077         * Scripts/webkitpy/tool/commands/download_unittest.py:
1078         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1079         * Scripts/webkitpy/tool/steps/__init__.py:
1080         * Scripts/webkitpy/tool/steps/commit.py:
1081         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py: Removed.
1082         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
1083
1084 2011-09-12  Eric Seidel  <eric@webkit.org>
1085
1086         [NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
1087         https://bugs.webkit.org/show_bug.cgi?id=65781
1088
1089         Reviewed by Ryosuke Niwa.
1090
1091         Instead of making NRWT create the symlink, I just made DumpRenderTree smart enough
1092         to resolve the passed in url relative to the absolute url for the test.
1093
1094         I believe this is a better approach than the on used in the Qt and Chromium DRT's
1095         (which resolves the path relative to the built location of the DRT executable)
1096         and we should move this new code into a shared location in a follow-up patch.
1097
1098         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1099         (LayoutTestController::pathToLocalResource):
1100
1101 2011-09-12  Eric Seidel  <eric@webkit.org>
1102
1103         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
1104         https://bugs.webkit.org/show_bug.cgi?id=67530
1105
1106         Reviewed by Adam Barth.
1107
1108         I believe I've fixed the bug in the original patch which prompted the rollout.
1109         The previous patch was using the wrong deadline for the initial read,
1110         subtracting time.time() twice from the deadline value.
1111
1112         * Scripts/webkitpy/layout_tests/port/webkit.py:
1113         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1114
1115 2011-09-12  Balazs Kelemen  <kbalazs@webkit.org>
1116
1117         [Qt][WK2] WebKitTestRunner does not produce crash logs
1118         https://bugs.webkit.org/show_bug.cgi?id=67714
1119
1120         Reviewed by Chang Shu.
1121
1122         Added a simple way of generating backtrace on crash
1123         to the web process. The implementation is similar what
1124         we have in DRT. It depends on GNU libc functionality
1125         so it is only enabled where we are running in such an environment.
1126
1127         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
1128         (WTR::printBacktrace):
1129         (WTR::crashHandler):
1130         (WTR::InjectedBundle::platformInitialize):
1131
1132 2011-09-11  Filip Pizlo  <fpizlo@apple.com>
1133
1134         Added my IRC nick to the committers file.
1135
1136         * Scripts/webkitpy/common/config/committers.py:
1137
1138 2011-09-01  Filip Pizlo  <fpizlo@apple.com>
1139
1140         The executable allocator makes it difficult to free individual
1141         chunks of executable memory
1142         https://bugs.webkit.org/show_bug.cgi?id=66363
1143
1144         Reviewed by Oliver Hunt.
1145         
1146         Introduced a best-fit, balanced-tree based allocator. The allocator
1147         required a balanced tree that does not allocate memory and that
1148         permits the removal of individual nodes directly (as opposed to by
1149         key); neither AVLTree nor WebCore's PODRedBlackTree supported this.
1150         Changed all references to executable code to use a reference counted
1151         handle.
1152
1153         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1154         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp: Added.
1155         (TestWebKitAPI::TEST_F):
1156         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp: Added.
1157         (TestWebKitAPI::Pair::findExact):
1158         (TestWebKitAPI::Pair::remove):
1159         (TestWebKitAPI::Pair::findLeastGreaterThanOrEqual):
1160         (TestWebKitAPI::Pair::assertFoundAndRemove):
1161         (TestWebKitAPI::Pair::assertEqual):
1162         (TestWebKitAPI::Pair::assertSameValuesForKey):
1163         (TestWebKitAPI::Pair::testDriver):
1164         (TestWebKitAPI::TEST_F):
1165
1166 2011-09-10  Andy Estes  <aestes@apple.com>
1167
1168         Move myself from committers_unable_to_review to reviewers_list.
1169
1170         * Scripts/webkitpy/common/config/committers.py:
1171
1172 2011-09-10  Kevin Ollivier  <kevino@theolliviers.com>
1173
1174         [wx] Unreviewed build fix. MSW build fixes.
1175
1176         * DumpRenderTree/config.h:
1177         * waf/build/wxpresets.py:
1178
1179 2011-09-10  Andreas Kling  <kling@webkit.org>
1180
1181         Crash beneath WKURLIsEqual() when reloading in MiniBrowser.
1182         https://bugs.webkit.org/show_bug.cgi?id=59328
1183
1184         Reviewed by Kenneth Rohde Christiansen.
1185
1186         * MiniBrowser/mac/BrowserWindowController.m:
1187         (-[BrowserWindowController updateProvisionalURLForFrame:]): Add missing null check.
1188
1189 2011-09-10  Adam Barth  <abarth@webkit.org>
1190
1191         Build fix for Android.  DumpRenderTree is a client of the WebKit API
1192         and does not have access to notImplemented().
1193
1194         * DumpRenderTree/chromium/TestShellAndroid.cpp:
1195         (openStartupDialog):
1196
1197 2011-09-09  Alexey Proskuryakov  <ap@apple.com>
1198
1199         Add a script to create a monolithic script-test
1200         https://bugs.webkit.org/show_bug.cgi?id=67747
1201
1202         Reviewed by Darin Adler.
1203
1204         * Scripts/make-new-script-test: Added.
1205
1206 2011-09-09  Luiz Agostini  <luiz@webkit.org>
1207
1208         Adding myself to the reviewers list.
1209
1210         * Scripts/webkitpy/common/config/committers.py:
1211
1212 2011-09-09  Ryosuke Niwa  <rniwa@webkit.org>
1213
1214         Buildbot may use RunWebKitTest's evaluateCommand on bots that run nrwt
1215         https://bugs.webkit.org/show_bug.cgi?id=67855
1216
1217         Reviewed by Dirk Pranke.
1218
1219         The bug was caused by the fact some ports use RunWebKitTests instead of NewRunWebKitTests to run tests,
1220         and using RunWebKitTests.evaluateCommand after calling _parseNewRunWebKitTestsOutput.
1221
1222         Fixed the bug by merging evaluateCommand of RunWebKitTests and NewRunWebKitTests.
1223
1224         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1225
1226 2011-09-09  Mark Hahnenberg  <mhahnenberg@apple.com>
1227
1228         Add myself to committers.py
1229         https://bugs.webkit.org/show_bug.cgi?id=67853
1230
1231         Reviewed by Darin Adler.
1232
1233         * Scripts/webkitpy/common/config/committers.py:
1234
1235 2011-09-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1236
1237         [Qt] Remove common.pri
1238         https://bugs.webkit.org/show_bug.cgi?id=67814
1239
1240         Reviewed by Andreas Kling.
1241
1242         * Tools.pro:
1243
1244 2011-09-09  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1245
1246         [NRWT] the nrwt check httpd with --no-http option
1247         https://bugs.webkit.org/show_bug.cgi?id=67835
1248
1249         Reviewed by Tony Chang.
1250
1251         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1252         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1253
1254 2011-09-09  Hao Zheng  <zhenghao@chromium.org>
1255
1256         [chromium] Implement DRT support for Android.
1257         https://bugs.webkit.org/show_bug.cgi?id=67590
1258
1259         Reviewed by Tony Chang.
1260
1261         Add 2 mechanism to make DRT interaction more robust on Android:
1262         - Send 'QUIT' to DRT to make it stop.
1263         - Wait until receiving '#READY' from DRT, so that DRT won't miss any
1264         input commands before it starts.
1265         And LayoutTestController.cpp needs to include <cctype> for 'tolower'
1266         and <clocale> for 'LC_ALL' to compile on Android.
1267
1268         Also change to use sigaction instead of signal for TestShellGtk.cpp,
1269         as signal() man page recommends using sigaction().
1270
1271         * DumpRenderTree/DumpRenderTree.gypi:
1272         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1273         (main):
1274         * DumpRenderTree/chromium/LayoutTestController.cpp:
1275         * DumpRenderTree/chromium/TestShellAndroid.cpp: Added.
1276         (AlarmHandler):
1277         (TestShell::waitTestFinished):
1278         (platformInit):
1279         (openStartupDialog):
1280         (checkLayoutTestSystemDependencies):
1281         * DumpRenderTree/chromium/TestShellGtk.cpp:
1282         (AlarmHandler):
1283         (TestShell::waitTestFinished):
1284
1285 2011-09-09  Kevin Ollivier  <kevino@theolliviers.com>
1286
1287         [wx] Unreviewed build fix. Add Source/JavaScriptCore/dfg directory to the build.
1288
1289         * waf/build/settings.py:
1290
1291 2011-09-09  Sheriff Bot  <webkit.review.bot@gmail.com>
1292
1293         Unreviewed, rolling out r94851.
1294         http://trac.webkit.org/changeset/94851
1295         https://bugs.webkit.org/show_bug.cgi?id=67847
1296
1297         It broke a webkitpy test (Requested by ossy on #webkit).
1298
1299         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1300
1301 2011-09-09  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1302
1303         [NRWT] the nrwt check httpd with --no-http option
1304         https://bugs.webkit.org/show_bug.cgi?id=67835
1305
1306         Reviewed by Csaba Osztrogonác.
1307
1308         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1309
1310 2011-09-08  Brian Weinstein  <bweinstein@apple.com>
1311
1312         WebKit2: Assertion when calling didPerform*Redirect on null source/destination URL string
1313         https://bugs.webkit.org/show_bug.cgi?id=67794
1314         <rdar://problem/9892024>
1315         
1316         Add a test that we don't send a didPerformServerRedirect when a load is cancelled from willSendRequest.
1317
1318         Reviewed by Brady Eidson.
1319
1320         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp: Added.
1321         (TestWebKitAPI::didFinishLoadForFrame): Set flags on whether we've loaded the main frame, iframe, or both.
1322         (TestWebKitAPI::didPerformServerRedirect): Set a flag for whether we've performed a server redirect.
1323         (TestWebKitAPI::TEST): Set up a WKPageLoaderClient and WKContextHistoryClient, and load simple-iframe.html.
1324             Once both frames have loaded (main frame and blocked iframe), make sure that we have never called
1325             didPerformServerRedirect.
1326
1327         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp: Added.
1328         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::LoadCanceledNoServerRedirectCallbackTest): Initialize
1329             our InjectedBundleTest.
1330         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::willSendRequestForFrame): If we are dealing with a request
1331             from the main frame (the main resource in simple-iframe.html), allow it. If not (dealing with the iframe), block
1332             the request.
1333         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::didCreatePage): Set up the WKBundlePageResourceLoadClient.
1334
1335         * TestWebKitAPI/Tests/WebKit2/simple-iframe.html: Added.
1336         
1337         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
1338         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
1339         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Ditto.
1340         * TestWebKitAPI/win/copy-resources.cmd: Ditto.
1341
1342 2011-09-08  David Levin  <levin@chromium.org>
1343
1344         check-webkit-style: Ref|Own Ptr& should be allowed as a parameter.
1345         https://bugs.webkit.org/show_bug.cgi?id=67797
1346
1347         Reviewed by Eric Seidel.
1348
1349         * Scripts/webkitpy/style/checkers/cpp.py: Allow Ref/Own Ptr when it ends with &.
1350         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test cases for this.
1351
1352 2011-09-08  Fady Samuel  <fsamuel@chromium.org>
1353
1354         Fixed Layout Mode should be adjustable from layoutTestController for testing on Chromium platforms
1355         https://bugs.webkit.org/show_bug.cgi?id=67723
1356
1357         Reviewed by Adam Barth.
1358
1359         * DumpRenderTree/chromium/EventSender.h:
1360         * DumpRenderTree/chromium/LayoutTestController.cpp:
1361         (LayoutTestController::LayoutTestController):
1362         (LayoutTestController::enableFixedLayoutMode):
1363         (LayoutTestController::setFixedLayoutSize):
1364         * DumpRenderTree/chromium/LayoutTestController.h:
1365
1366 2011-09-07  Matthew Delaney  <mdelaney@apple.com>
1367
1368         Add standalone script that filters the output of build-webkit to be more human-readable
1369         https://bugs.webkit.org/show_bug.cgi?id=44081
1370
1371         Reviewed by Daniel Bates.
1372
1373         * Scripts/filter-build-webkit: Added. Just need to feed it the output of
1374         a build script (e.g. build-webkit) and it spits out a prettier version.
1375         * Scripts/VCSUtils.pm: Refactored "possiblyColored" out of run-api-tests into VCSUtils.
1376         * Scripts/run-api-tests: Now includes VCSUtils to use "possiblyColored"
1377
1378 2011-09-07  Noel Gordon  <noel.gordon@gmail.com>
1379
1380         Add myself to committers.py                 
1381         https://bugs.webkit.org/show_bug.cgi?id=67696
1382
1383         Reviewed by Kent Tamura.
1384
1385         * Scripts/webkitpy/common/config/committers.py:
1386
1387 2011-09-07  Adam Barth  <abarth@webkit.org>
1388
1389         rebaseline button in garden-o-matic details view should work
1390         https://bugs.webkit.org/show_bug.cgi?id=67738
1391
1392         Reviewed by Dimitri Glazkov.
1393
1394         This patch wires up the rebaseline button in garden-o-matic results
1395         details view.  The button is current per-test, so there isn't a way to
1396         rebaseline individual bots.  This is a place to start.  If we decide we
1397         want per-bot rebaselining, we'll need to think of some better UI.
1398
1399         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1400         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
1401         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1402         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1403
1404 2011-09-07  Eric Seidel  <eric@webkit.org>
1405
1406         Teach the PortFactory object how to pass along executive/user/filesystem to port objects (which fixes the failing rebaseline_test on bots)
1407         https://bugs.webkit.org/show_bug.cgi?id=67737
1408
1409         Reviewed by Adam Barth.
1410
1411         I got a little over-eager when deprecating host.port_factory in the previous commit.
1412         Turns out that Host.port_factory was already the "modern" port/factory.py
1413         it was just the Module object.  I un-deprecated the variable, and changed it from
1414         being the module to being an actual PortFactory, passing it a host object.
1415         I also taught PortFactory how to set user/executive/filesystem in the kwargs
1416         when instantiating a new Port object.
1417         This magically fixed the test_rebaseline test, since its now no longer talking
1418         to the real filesystem.
1419
1420         * Scripts/webkitpy/common/host.py:
1421         * Scripts/webkitpy/layout_tests/port/factory.py:
1422         * Scripts/webkitpy/tool/commands/queries.py:
1423         * Scripts/webkitpy/tool/mocktool.py:
1424
1425 2011-09-07  Eric Seidel  <eric@webkit.org>
1426
1427         Add a new PortFactory class for creating new-style ports and deprecate the old PortFactory
1428         https://bugs.webkit.org/show_bug.cgi?id=67734
1429
1430         Reviewed by Adam Barth.
1431
1432         Right now every place that creates a Port object has to be very careful
1433         to pass in a MockSCM/MockUser/MockFilesystem when appropriate.
1434         The correct fix is for port/factory.py (which creates most port objects)
1435         to know how to pass these in automatically.  However, currently all port/factory.py
1436         functions are free functions instead of being on an object.  This patch
1437         adds a new PortFactory object and deprecates the PortFactory for the old-style Port objects.
1438
1439         In a follow-up patch I will add PortFactory to the Host object and teach PortFactory how to
1440         pass along the proper scm/user/filesystem to the Port object.
1441
1442         * Scripts/webkitpy/common/host.py:
1443         * Scripts/webkitpy/layout_tests/port/factory.py:
1444         * Scripts/webkitpy/tool/commands/queries.py:
1445         * Scripts/webkitpy/tool/mocktool.py:
1446
1447 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
1448
1449         Unreviewed, rolling out r94441.
1450         http://trac.webkit.org/changeset/94441
1451         https://bugs.webkit.org/show_bug.cgi?id=67731
1452
1453         "MacEWSes are backed up due to new machines not able to reach
1454         git.webkit.org.  Disabling tests for now" (Requested by
1455         eseidel2 on #webkit).
1456
1457         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1458
1459 2011-09-07  Elliot Poger  <epoger@google.com>
1460
1461         filter test_expectations properly for chromium-mac vs chromium-cg-mac
1462         https://bugs.webkit.org/show_bug.cgi?id=67324
1463
1464         Reviewed by Dirk Pranke.
1465
1466         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1467         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1468         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1469         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1470         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1471
1472 2011-09-07  Eric Boren  <borenet@gmail.com>
1473
1474         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
1475         https://bugs.webkit.org/show_bug.cgi?id=66800
1476
1477         Reviewed by Darin Fisher.
1478
1479         * DumpRenderTree/chromium/EventSender.cpp:
1480         (EventSender::sendCurrentTouchEvent):
1481
1482 2011-09-07  Jarred Nicholls  <jarred@sencha.com>
1483
1484         [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
1485         https://bugs.webkit.org/show_bug.cgi?id=67254
1486
1487         Reviewed by Csaba Osztrogonác.
1488
1489         Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
1490         derived from the running location of DumpRenderTree binary.
1491
1492         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1493         (LayoutTestController::pathToLocalResource):
1494         (LayoutTestController::setUserStyleSheetLocation): pass the url through pathToLocalResource
1495
1496 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
1497
1498         REGRESSION(r94288) build-webkit doesn't work on Symbian
1499         https://bugs.webkit.org/show_bug.cgi?id=67706
1500
1501         * Scripts/webkitdirs.pm: Disable automatic clean build on Symbian, because it doesn't support shadow build.
1502         (buildQMakeProject):
1503
1504 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
1505
1506         REGRESSION(r94288) build-webkit doesn't work on Windows
1507         https://bugs.webkit.org/show_bug.cgi?id=67646
1508
1509         Roll back r94655 with a small fix.
1510
1511         * Scripts/webkitdirs.pm:
1512         (buildQMakeProject):
1513
1514 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
1515
1516         Unreviewed, rolling out r94635.
1517         http://trac.webkit.org/changeset/94635
1518         https://bugs.webkit.org/show_bug.cgi?id=67704
1519
1520         Linux Touch build is failing to compile this change.
1521         (Requested by loislo on #webkit).
1522
1523         * DumpRenderTree/chromium/EventSender.cpp:
1524         (EventSender::sendCurrentTouchEvent):
1525
1526 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
1527
1528         Unreviewed, rolling out r94655.
1529         http://trac.webkit.org/changeset/94655
1530         https://bugs.webkit.org/show_bug.cgi?id=67703
1531
1532         It broke Leopard debug bot (Requested by ossy on #webkit).
1533
1534         * Scripts/webkitdirs.pm:
1535
1536 2011-09-07  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1537
1538         REGRESSION(r94288) build-webkit doesn't work on Windows
1539         https://bugs.webkit.org/show_bug.cgi?id=67646
1540
1541         Reviewed by Csaba Osztrogonác.
1542
1543         * Scripts/webkitdirs.pm:
1544
1545 2011-09-06  Eric Boren  <borenet@gmail.com>
1546
1547         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
1548         https://bugs.webkit.org/show_bug.cgi?id=66800
1549
1550         Reviewed by Darin Fisher.
1551
1552         * DumpRenderTree/chromium/EventSender.cpp:
1553         (EventSender::sendCurrentTouchEvent):
1554
1555 2011-09-06  Adam Barth  <abarth@webkit.org>
1556
1557         garden-o-matic details view should having working rebaseline and next/previous buttons
1558         https://bugs.webkit.org/show_bug.cgi?id=67659
1559
1560         Reviewed by Dimitri Glazkov.
1561
1562         This patch wires up basic back/forward buttons that let you traverse
1563         through the results we're examining in the details view.  This ended up
1564         being more code than I expected, but I wanted to keep all the state
1565         information in the DOM itself.
1566
1567         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1568         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
1569         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1570
1571 2011-09-01  Dirk Pranke  <dpranke@chromium.org>
1572
1573         fix MockFileSystem.glob(), refactor filesystem tests
1574         https://bugs.webkit.org/show_bug.cgi?id=67462
1575
1576         Reviewed by Eric Seidel.
1577
1578         In debugging why my proposed change for MockFileSystem.glob()
1579         in bug 66228 didn't work, I stumbled across two real bugs
1580         that cancelled each other out for the unit tests. I fixed those
1581         (glob shouldn't recurse into subdirs, and we weren't populating
1582         self.dirs from self.files properly).
1583
1584         I have also created a "mixin" class for tests that can be shared
1585         between the real filesystem and the mock filesystem - MockFileSystem
1586         is being used enough it needs its own tests.
1587
1588         * Scripts/webkitpy/common/system/filesystem_mock.py:
1589         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py: Added.
1590         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1591
1592 2011-09-06  Anders Carlsson  <andersca@apple.com>
1593
1594         Move NPAPI headers in bridge to plugins
1595         https://bugs.webkit.org/show_bug.cgi?id=67661
1596
1597         Update forwarding headers.
1598
1599         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
1600         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
1601
1602 2011-09-06  Tony Chang  <tony@chromium.org>
1603
1604         [chromium] Check in 'build' for compiled binaries first
1605         https://bugs.webkit.org/show_bug.cgi?id=67549
1606
1607         Reviewed by Dirk Pranke.
1608
1609         I'm working on moving the windows build output to a common location
1610         rather than relative to the sln file.  Because of that, we need to
1611         check those build locations first for DumpRenderTree.exe.
1612
1613         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1614
1615 2011-09-06  Adam Barth  <abarth@webkit.org>
1616
1617         Use a hierarchial structure for the garden-o-matic results view
1618         https://bugs.webkit.org/show_bug.cgi?id=67620
1619
1620         Reviewed by Dimitri Glazkov.
1621
1622         This patch re-organizes the results view to use a hierachial structure
1623         for selection.  At the top-level are sections for each test.  Expanding
1624         the test section shows a tab selector for builders.
1625
1626         This structure prepares us for wiring up various actions to this view.
1627
1628         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1629         (.):
1630         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1631         ():
1632         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1633         (.):
1634         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
1635         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1636         (.results-view>.toolbar):
1637         (.results-view>.toolbar ul.actions):
1638         (.results-view>.toolbar ul.actions li):
1639         (.results-grid table):
1640         (.results-grid table td, .results-view table th):
1641         (.results-grid table th):
1642         (.results-grid .text-result):
1643         (.results-grid .image-result):
1644
1645 2011-09-06  Adam Barth  <abarth@webkit.org>
1646
1647         garden-o-matic's base.probe generates spam in the JavaScript console
1648         https://bugs.webkit.org/show_bug.cgi?id=67622
1649
1650         Reviewed by Dimitri Glazkov.
1651
1652         Now that we have CORS set up on the buildbot, we can use XMLHttpRequest
1653         instead of HTMLScriptElement to test whether results exist.  This
1654         reduces the console.log spam and saves bandwidth because we can use a
1655         HEAD request instead of a GET request.
1656
1657         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
1658
1659 2011-09-05  Adam Barth  <abarth@webkit.org>
1660
1661         Add a tab to garden-o-matic for viewing expected failures
1662         https://bugs.webkit.org/show_bug.cgi?id=67619
1663
1664         Reviewed by Dimitri Glazkov.
1665
1666         This patch adds a basic tab to garden-o-matic that shows all the tests
1667         failing on the bots, including the expected failures.  This patch
1668         mostly involves refactoring existing classes to allow new subclasses.
1669
1670         This view is useful for when gardeners mark tests as expected to fail
1671         and then rebaseline them later.
1672
1673         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1674         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
1675         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
1676         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
1677         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1678         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1679         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1680
1681 2011-09-05  Adam Barth  <abarth@webkit.org>
1682
1683         Fix global variable leak in garden-o-matic
1684         https://bugs.webkit.org/show_bug.cgi?id=67617
1685
1686         Reviewed by Dimitri Glazkov.
1687
1688         Caught by running the unit tests with noglobals turned on.
1689
1690         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1691
1692 2011-09-05  Balazs Kelemen  <kbalazs@webkit.org>
1693
1694         [Qt][WK2] Add pixel test support
1695         https://bugs.webkit.org/show_bug.cgi?id=66283
1696
1697         Reviewed by Andreas Kling.
1698
1699         Implemented pixel result generation by reusing the logic
1700         that we have in DumpRenderTree.
1701         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1702         (WTR::dumpImage):
1703         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1704
1705 2011-09-04  Robin Dunn  <robin@alldunn.com>
1706
1707         [wx] Enable wxWebKit to run using the wxGC Cairo backend on platforms other than GTK.
1708         https://bugs.webkit.org/show_bug.cgi?id=67577
1709
1710         Reviewed by Kevin Ollivier.
1711
1712         * waf/build/settings.py:
1713
1714 2011-09-03  Kevin Ollivier  <kevino@theolliviers.com>
1715
1716         [wx] Unreviewed build fix. Add wtf/dtoa directory to build.
1717
1718         * waf/build/settings.py:
1719
1720 2011-09-03  Dan Bernstein  <mitz@apple.com>
1721
1722         32-bit build fix.
1723
1724         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1725         (TestWebKitAPI::Util::toSTD):
1726
1727 2011-09-03  Dan Bernstein  <mitz@apple.com>
1728
1729         Move testStringByEvaluatingJavaScriptFromString() from DumpRenderTree to TestWebKitAPI
1730         https://bugs.webkit.org/show_bug.cgi?id=67559
1731
1732         Reviewed by Darin Adler.
1733
1734         * DumpRenderTree/mac/DumpRenderTree.mm:
1735         (dumpRenderTree): Moved testStringByEvaluatingJavaScriptFromString() from here and removed
1736         the call to it.
1737         * TestWebKitAPI/PlatformUtilities.h: Declared Util::toSTD(NSString *)
1738         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringByEvaluatingJavaScriptFromString.mm.
1739         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm: Added.
1740         (TestWebKitAPI::TEST): Added. Moved testStringByEvaluatingJavaScriptFromString() to here.
1741         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1742         (TestWebKitAPI::Util::toSTD): Added.
1743
1744 2011-09-03  Adam Barth  <abarth@webkit.org>
1745
1746         garden-o-matic results view should have a better results selector
1747         https://bugs.webkit.org/show_bug.cgi?id=67542
1748
1749         Reviewed by Dimitri Glazkov.
1750
1751         This patch adds a basic grid-based results selector to the results
1752         view.  Currently, this grid just shows how the tests fail on the
1753         various bots.  A future patch will let you select which failure to view
1754         and to mark the failures for rebaselining.
1755
1756         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1757         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1758           - Add some more basic functions for manipulating dictionaries.
1759         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1760         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1761         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
1762
1763 2011-09-03  Adam Barth  <abarth@webkit.org>
1764
1765         garden-o-matic results view should show Actual and Expected results for text failures
1766         https://bugs.webkit.org/show_bug.cgi?id=67536
1767
1768         Reviewed by Eric Seidel.
1769
1770         In the past, we didn't show actual and expected text results (we just
1771         showed the diff) because we didn't have the awesome six-by-two results
1772         grid.  Now that we do, we can move show these results.
1773
1774         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1775         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1776           - Fixed some typos that were preventing these unit tests from running.
1777         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1778         (.):
1779         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
1780           - Report -actual.txt and -expected.txt as possible results URLs.
1781
1782 2011-09-03  Adam Barth  <abarth@webkit.org>
1783
1784         garden-o-matic shows "ghost" failures that are already fixed
1785         https://bugs.webkit.org/show_bug.cgi?id=67535
1786
1787         Reviewed by Eric Seidel.
1788
1789         About 10% of writes fail to stick on test-results.appspot.com.  This
1790         patch causes us to fetch the full_results.json blob directly from
1791         build.chromium.org rather than relying upon AppEngine.
1792
1793         Unforuntately, we still need to get historical information from
1794         AppEngine.  That will take several patches to fix becuase I need to
1795         change the bots to write the full_results.json file to the
1796         build-specific directory in addition to the zip file.
1797
1798         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1799         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
1800         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1801
1802 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1803
1804         Unreviewed, rolling out r94458.
1805         http://trac.webkit.org/changeset/94458
1806         https://bugs.webkit.org/show_bug.cgi?id=67558
1807
1808         Caused appcache test to fail on various bots (Requested by
1809         rniwa on #webkit).
1810
1811         * Scripts/webkitpy/layout_tests/port/webkit.py:
1812         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1813
1814 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1815
1816         Unreviewed, rolling out r94453.
1817         http://trac.webkit.org/changeset/94453
1818         https://bugs.webkit.org/show_bug.cgi?id=67557
1819
1820         Caused appcache test to fail on various bots (Requested by
1821         rniwa on #webkit).
1822
1823         * Scripts/webkitpy/layout_tests/port/webkit.py:
1824
1825 2011-09-02  Michael Saboff  <msaboff@apple.com>
1826
1827         Add JSC:RegExp functional tests
1828         https://bugs.webkit.org/show_bug.cgi?id=67339
1829
1830         New perl script to build JavaScriptCore and run the RegExp tests.
1831
1832         Reviewed by Gavin Barraclough.
1833
1834         * Scripts/run-regexp-tests: Added.
1835
1836 2011-09-02  Michael Saboff  <msaboff@apple.com>
1837
1838         Add JSC:RegExp functional tests
1839         https://bugs.webkit.org/show_bug.cgi?id=67339
1840
1841         New perl script to build JavaScriptCore and run the RegExp tests.
1842
1843         Reviewed by Gavin Barraclough.
1844
1845         * Scripts/run-regexp-tests: Added.
1846
1847 2011-09-02  Eric Seidel  <eric@webkit.org>
1848
1849         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
1850         https://bugs.webkit.org/show_bug.cgi?id=67530
1851
1852         Unreviewed.  Fixing typo from previous commit.
1853
1854         Turns out there was *no* unittesting of WebKitDriver.  Added a basic test of _read_block
1855         which exercises the code I previously made a typo in.
1856
1857         * Scripts/webkitpy/layout_tests/port/webkit.py:
1858         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1859
1860 2011-09-02  Eric Seidel  <eric@webkit.org>
1861
1862         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
1863         https://bugs.webkit.org/show_bug.cgi?id=67530
1864
1865         Reviewed by Adam Barth.
1866
1867         No functional change, just reshuffling code.
1868
1869         * Scripts/webkitpy/layout_tests/port/webkit.py:
1870
1871 2011-09-02  Darin Adler  <darin@apple.com>
1872
1873         Added Subversion ignore for .pyc generated files.
1874
1875         * Scripts/webkitpy/layout_tests/models: Added property svn:ignore.
1876         * Scripts/webkitpy/layout_tests/servers: Added property svn:ignore.
1877         * Scripts/webkitpy/tool/servers: Added property svn:ignore.
1878
1879 2011-09-02  Adam Barth  <abarth@webkit.org>
1880
1881         Enable testing on mac-ews
1882         https://bugs.webkit.org/show_bug.cgi?id=67505
1883
1884         Reviewed by Eric Seidel.
1885
1886         This patch enables testing on the Mac EWS, which should help
1887         contributors not turn the Mac bots red.
1888
1889         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1890
1891 2011-09-01  Beth Dakin  <bdakin@apple.com>
1892
1893         https://bugs.webkit.org/show_bug.cgi?id=67451
1894         Add a test for going back to a cached page after changing the device scale factor
1895
1896         Reviewed by Adam Roben.
1897
1898         New test DeviceScaleFactorOnBack.mm inherits from WebKitAgnosticTest.
1899         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1900         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm: Added.
1901         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
1902         (TestWebKitAPI::DeviceScaleFactorOnBack::didLoadURL):
1903         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
1904         (TestWebKitAPI::DeviceScaleFactorOnBack::initializeView):
1905         (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
1906         (TestWebKitAPI::TEST_F):
1907
1908         Added new function to WebKitAgnosticTest to goBack. Separated 
1909         waitForLoadToFinish() into its own function (instead of being a part of 
1910         loadAndWaitUntilFinished()) so that it can be called from goBack as 
1911         well. Also added initializeView() so we can set the cache model.
1912         * TestWebKitAPI/mac/WebKitAgnosticTest.h:
1913         (TestWebKitAPI::WebKitAgnosticTest::initializeView):
1914         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1915         (TestWebKitAPI::WebKitAgnosticTest::WebKitAgnosticTest):
1916         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
1917         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
1918         (TestWebKitAPI::WebKitAgnosticTest::loadURL):
1919         (TestWebKitAPI::WebKitAgnosticTest::goBack):
1920         (TestWebKitAPI::WebKitAgnosticTest::waitForLoadToFinish):
1921
1922 2011-09-02  Anders Carlsson  <andersca@apple.com>
1923
1924         Build fix.
1925
1926         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp:
1927         (PrivateBrowsing::ScriptableObject::pluginTest):
1928
1929 2011-09-02  Anders Carlsson  <andersca@apple.com>
1930
1931         Move private browsing test to a PluginTest subclass
1932         https://bugs.webkit.org/show_bug.cgi?id=67498
1933
1934         Reviewed by Darin Adler.
1935
1936         * DumpRenderTree/DumpRenderTree.gypi:
1937         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1938         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1939         (pluginGetProperty):
1940         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1941         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1942         (PluginTest::NPP_SetValue):
1943         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1944         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp: Added.
1945         (PrivateBrowsing::PrivateBrowsing):
1946         (PrivateBrowsing::privateBrowsingEnabled):
1947         (PrivateBrowsing::cachedPrivateBrowsingEnabled):
1948         (PrivateBrowsing::ScriptableObject::hasProperty):
1949         (PrivateBrowsing::ScriptableObject::getProperty):
1950         (PrivateBrowsing::ScriptableObject::pluginTest):
1951         (PrivateBrowsing::NPP_New):
1952         (PrivateBrowsing::NPP_GetValue):
1953         (PrivateBrowsing::NPP_SetValue):
1954         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1955         (NPP_New):
1956         (NPP_SetValue):
1957         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1958         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1959         * GNUmakefile.am:
1960
1961 2011-09-02  Csaba Osztrogonác  <ossy@webkit.org>
1962
1963         [Qt] Build dependency problems
1964         https://bugs.webkit.org/show_bug.cgi?id=38054
1965
1966         Trivial fix after r94288.
1967
1968         Rubber-stamped by Andras Becsi.
1969
1970         * Scripts/webkitdirs.pm: We should read the whole defaults.txt, not only the first two lines.
1971         (buildQMakeProject):
1972
1973 2011-09-02  Andras Becsi  <andras.becsi@nokia.com>
1974
1975         Remove my old e-mail address and add my new one.
1976
1977         Rubber-stamped by Tor Arne Vestbø.
1978
1979         * Scripts/webkitpy/common/config/committers.py:
1980
1981 2011-09-02  Philippe Normand  <pnormand@igalia.com>
1982
1983         [GTK] run-gtk-tests leaves a zombie Xvfb process
1984         https://bugs.webkit.org/show_bug.cgi?id=67389
1985
1986         Reviewed by Martin Robinson.
1987
1988         * Scripts/run-gtk-tests: Properly close STDIN and STDERR on the
1989         child process instead of doing shell redirection.
1990
1991 2011-09-01  Mark Rowe  <mrowe@apple.com>
1992
1993         Fix the build by adding some more missing return types.
1994
1995         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1996         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1997
1998 2011-09-01  Eric Seidel  <eric@webkit.org>
1999
2000         REGRESSION (NRWT): Leaks Viewer can't load leaks from test runs that used NRWT
2001         https://bugs.webkit.org/show_bug.cgi?id=66228
2002
2003         Reviewed by Dirk Pranke.
2004
2005         ORWT used $(PROCESS)$(NUMBER)-leaks.txt for leaks filenames.
2006         The LeaksViewer tool globs for all *-leaks.txt files.
2007         This patch makes NRWT output $(PROCESS)-$(PID)-leaks.txt which should match.
2008
2009         In order to test this I had to fix a limitation in our MockFileSystem.glob
2010         method.  However, doing so uncovered a typo and bug in the integration tests.
2011         I've disabled the offending integration tests.
2012
2013         * Scripts/webkitpy/common/system/filesystem_mock.py:
2014         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
2015         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
2016
2017 2011-09-01  Dominic Mazzoni  <dmazzoni@google.com>
2018
2019         Adds a LayoutTestController method to make it possible to test
2020         starting speech input via an API call.
2021         https://bugs.webkit.org/show_bug.cgi?id=60170
2022
2023         Reviewed by Dimitri Glazkov.
2024
2025         * DumpRenderTree/LayoutTestController.h:
2026         * DumpRenderTree/chromium/LayoutTestController.cpp:
2027         (LayoutTestController::LayoutTestController):
2028         (LayoutTestController::startSpeechInput):
2029         * DumpRenderTree/chromium/LayoutTestController.h:
2030         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2031         (LayoutTestController::startSpeechInput):
2032         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2033         (LayoutTestController::startSpeechInput):
2034         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2035         (LayoutTestController::startSpeechInput):
2036         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2037         (LayoutTestController::startSpeechInput):
2038         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2039         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2040         (LayoutTestController::startSpeechInput):
2041         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2042         (LayoutTestController::startSpeechInput):
2043
2044 2011-09-01  Tim Horton  <hortont424@gmail.com>
2045
2046         Fix TestWebKitAPI build on clang-2.0
2047
2048         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2049
2050 2011-09-01  Adam Barth  <abarth@webkit.org>
2051
2052         Remove unused "extension" parameter from rebaseline gardeningserver handler
2053         https://bugs.webkit.org/show_bug.cgi?id=67384
2054
2055         Reviewed by James Robinson.
2056
2057         This parameter hasn't done anything in a while.
2058
2059         * Scripts/webkitpy/tool/commands/rebaseline.py:
2060         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2061         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2062
2063 2011-09-01  Eric Seidel  <eric@webkit.org>
2064
2065         Unreviewed.
2066
2067         Fix a typo in unittests.  Unfortunately fixing it
2068         caused several assertions.  Just disabling the test
2069         instead, since it was providing no value before due to the typo.
2070
2071         * Scripts/webkitpy/layout_tests/port/test.py:
2072
2073 2011-09-01  Adam Barth  <abarth@webkit.org>
2074
2075         Add a "rebaseline" button to the garden-o-matic summary page
2076         https://bugs.webkit.org/show_bug.cgi?id=67382
2077
2078         Reviewed by Dimitri Glazkov.
2079
2080         As much as we might wish folks to not rebaseline entire test groups at
2081         once, the truth is that doing so is a common operation.  Adding a
2082         button for this operation is likely to make folks happy.
2083
2084         This patch also cleans up a bunch of plumbing surrounding failureInfo
2085         objects.
2086
2087         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2088         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
2089         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2090         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
2091         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2092         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
2093         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
2094         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
2095         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2096         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2097
2098 2011-09-01  Adam Barth  <abarth@webkit.org>
2099
2100         garden-o-matic should let the gardener assign blame for a group of test failures
2101         https://bugs.webkit.org/show_bug.cgi?id=67379
2102
2103         Reviewed by Dimitri Glazkov.
2104
2105         If a group of test failures has a large revision range, the gardener
2106         might wish to blame a specific revision for the failure.  Currently,
2107         this only effect of assigning blame in this way is to hide the other
2108         suspect commits.
2109
2110         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2111         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
2112         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2113
2114 2011-09-01  Adam Barth  <abarth@webkit.org>
2115
2116         Hide garden-o-matic failure table until hover
2117         https://bugs.webkit.org/show_bug.cgi?id=67376
2118
2119         Reviewed by Dimitri Glazkov.
2120
2121         This patch removes the failure table for build failures (because it
2122         does not make sense) and hides the failure table for test groups until
2123         the user hovers over the test failure block, reducing visual noise.
2124
2125         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2126         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2127         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
2128
2129 2011-09-01  Adam Barth  <abarth@webkit.org>
2130
2131         Switch garden-o-matic from commitData.title to commitData.summary
2132         https://bugs.webkit.org/show_bug.cgi?id=67375
2133
2134         Reviewed by Dimitri Glazkov.
2135
2136         commitData.title is a string provided by Trac, which isn't great in all
2137         cases.  commitData.summary is my attempt to find the most important
2138         one-line summary of the commit.  This patch switches garden-o-matic
2139         over to summary.
2140
2141         Also, this patch tweaks a bunch of CSS to tighten up the summary page
2142         and reduce visual noise.
2143
2144         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2145         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2146         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
2147
2148 2011-09-01  Adam Barth  <abarth@webkit.org>
2149
2150         Group failing tests in garden-o-matic if there are more than three in a folder
2151         https://bugs.webkit.org/show_bug.cgi?id=67373
2152
2153         Reviewed by Dimitri Glazkov.
2154
2155         Sometimes a failure will cause many tests in a given directory to fail.
2156         When that happens, it's better to list the directory as a single item
2157         (with a count) rather than spamming all the test names.
2158
2159         (This patch also updates a bunch of unit test expected results after my last commit.)
2160
2161         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2162         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
2163         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
2164         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2165         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2166
2167 2011-09-01  Adam Barth  <abarth@webkit.org>
2168
2169         Lower the visual noise from the failing builders display
2170         https://bugs.webkit.org/show_bug.cgi?id=67369
2171
2172         Reviewed by Dimitri Glazkov.
2173
2174         This patch ensures that the "Building" row in the failing builders
2175         display is always last and dims it by 50% to reduce visual noise.  This
2176         lets the gardener focus on the actual failures.
2177
2178         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2179         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2180         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css: Added.
2181
2182 2011-09-01  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2183
2184         [Qt] Build dependency problems
2185         https://bugs.webkit.org/show_bug.cgi?id=38054
2186
2187         Make clean build after the defines are changed.
2188
2189         Reviewed by Csaba Osztrogonác.
2190
2191         * Scripts/webkitdirs.pm:
2192         (buildQMakeProject):
2193
2194 2011-08-31  Adam Barth  <abarth@webkit.org>
2195
2196         Move DumpRenderTree to WebKitPlatformSupport
2197         https://bugs.webkit.org/show_bug.cgi?id=67331
2198
2199         Reviewed by Darin Fisher.
2200
2201         This patch update DumpRenderTree to account for the WebKitClient =>
2202         WebKitPlatformSupport rename.
2203
2204         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2205         (NotificationPresenter::show):
2206         * DumpRenderTree/chromium/Task.cpp:
2207         (postTask):
2208
2209 2011-08-31  Eric Seidel  <eric@webkit.org>
2210
2211         Add queues.webkit.org/active-bots page to make it easy to see which bots are down
2212         https://bugs.webkit.org/show_bug.cgi?id=67314
2213
2214         Reviewed by Adam Barth.
2215
2216         Very simple page.  Just lists all the bots, what queue they belong to and what we last heard from them.
2217         If we haven't heard from a bot in the last 500 messages (last day or so), then it won't show up here.
2218         This makes it very easy for me to see which of my cr-jail bots might be down at any one time.
2219
2220         I also moved a bunch of code into dashboard.css which belonged there.
2221
2222         * QueueStatusServer/handlers/activebots.py: Added.
2223         * QueueStatusServer/main.py:
2224         * QueueStatusServer/stylesheets/dashboard.css:
2225         (.queue_bubble):
2226         (.queue_name):
2227         (.last_heard_from):
2228         (.status_text):
2229         (.alive):
2230         (.behind):
2231         (.dead):
2232         * QueueStatusServer/templates/activebots.html: Added.
2233         * QueueStatusServer/templates/dashboard.html:
2234         * QueueStatusServer/templates/recentstatus.html:
2235
2236 2011-08-31  Oliver Hunt  <oliver@apple.com>
2237
2238         Move CheckedArithmeticOperations.cpp to the intended location
2239
2240         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2241         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp: Renamed from Tools/TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp.
2242
2243 2011-08-31  Elliot Poger  <epoger@google.com>
2244
2245         add unittest to validate the complete set of Chromium configurations
2246         https://bugs.webkit.org/show_bug.cgi?id=67211
2247
2248         Reviewed by Adam Barth.
2249
2250         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2251
2252 2011-08-31  Nico Weber  <thakis@chromium.org>
2253
2254         Make ScrollAnimator(Chromium)?Mac check scrollAnimatorEnabled()
2255         https://bugs.webkit.org/show_bug.cgi?id=67297
2256
2257         Reviewed by Tony Chang.
2258
2259         Explicitly disable smooth scrolling in chromium's DRT.
2260
2261         * DumpRenderTree/chromium/WebPreferences.cpp:
2262         (WebPreferences::applyTo):
2263
2264 2011-08-31  Oliver Hunt  <oliver@apple.com>
2265
2266         Add Checked<> tests to windows build
2267
2268         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2269
2270 2011-08-30  Oliver Hunt  <oliver@apple.com>
2271
2272         Add support for checked arithmetic
2273         https://bugs.webkit.org/show_bug.cgi?id=67095
2274
2275         Reviewed by Sam Weinig.
2276
2277         Add test cases for Checked<>
2278
2279         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2280         * TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp: Added.
2281
2282 2011-08-31  Adam Barth  <abarth@webkit.org>
2283
2284         Move summary.html to garden-o-matic.html.
2285
2286         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html.
2287         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js.
2288         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Removed.
2289         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Removed.
2290
2291 2011-08-31  Noel Gordon  <noel.gordon@gmail.com>
2292
2293         [chromium] DRT linux should pass nativeKeyCode to plugins
2294         https://bugs.webkit.org/show_bug.cgi?id=66679
2295
2296         Reviewed by Tony Chang.
2297
2298         * DumpRenderTree/chromium/EventSender.cpp:
2299         (EventSender::keyDown):  Call a Chromium Linux GTK helper routine that returns the
2300         (simulated) nativeKeyCode for the given input keyboard code.
2301
2302 2011-08-31  Adam Barth  <abarth@webkit.org>
2303
2304         Tighen up UI for garden-o-matic tab strip
2305         https://bugs.webkit.org/show_bug.cgi?id=67266
2306
2307         Reviewed by Dimitri Glazkov.
2308
2309         This patch add CSS to move the tab strip to the edges of the page and
2310         to remove some gratuitous border-radius.
2311
2312         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
2313         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
2314
2315 2011-08-31  Adam Barth  <abarth@webkit.org>
2316
2317         garden-o-matic results view shouldn't be horrifically ugly
2318         https://bugs.webkit.org/show_bug.cgi?id=67264
2319
2320         Reviewed by Dimitri Glazkov.
2321
2322         Minor tweak to the results view CSS to make it fit in better with the new tabbed UI.
2323
2324         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2325         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2326         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
2327
2328 2011-08-31  Adam Barth  <abarth@webkit.org>
2329
2330         garden-o-matic needs a tabstrip
2331         https://bugs.webkit.org/show_bug.cgi?id=67263
2332
2333         Reviewed by Dimitri Glazkov.
2334
2335         This patch adds a basic tabstrip to garden-o-matic.  The results
2336         details view now opens in the "Results" tab, and the user can flip back
2337         and forth between the Summary and the Results tab quickly.  There's
2338         also a stub for a "Commits" tab, which is disabled.
2339
2340         This patch isn't the most beautiful in the world, but it gets the ball
2341         rolling on a multi-modal UI.
2342
2343         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2344         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
2345         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2346         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
2347         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
2348
2349 2011-08-31  Ai Makabi  <makabi@google.com>
2350
2351         Extract reference links from reftest test file.
2352         https://bugs.webkit.org/show_bug.cgi?id=66838
2353
2354         Reviewed by Shinichiro Hamaji.
2355
2356         * Scripts/webkitpy/layout_tests/reftests/__init__.py: Added.
2357         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py: Added.
2358         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py: Added.
2359
2360 2011-08-03  Philippe Normand  <pnormand@igalia.com>
2361
2362         [webkitpy] missing log import in common/net/resultsjsonparser.py
2363         https://bugs.webkit.org/show_bug.cgi?id=65606
2364
2365         Reviewed by Martin Robinson.
2366
2367         * Scripts/webkitpy/common/net/resultsjsonparser.py: Import the logging module.
2368
2369 2011-08-30  Philippe Normand  <pnormand@igalia.com>
2370
2371         [stylechecker] complains about NULL usage in some gst_structure_ calls
2372         https://bugs.webkit.org/show_bug.cgi?id=67194
2373
2374         Reviewed by Martin Robinson.
2375
2376         Don't warn about NULL in some gst_structure_ calls. 0 can't be
2377         used for these, a proper sentinel is required.
2378
2379         * Scripts/webkitpy/style/checkers/cpp.py:
2380         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2381
2382 2011-08-30  Adam Barth  <abarth@webkit.org>
2383
2384         Remove old-style UI from garden-o-matic
2385         https://bugs.webkit.org/show_bug.cgi?id=67257
2386
2387         Reviewed by Dimitri Glazkov.
2388
2389         This code is nowhere near as awesome as the new hotness.  Let's remove
2390         it so it doesn't weigh us down.
2391
2392         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Removed.
2393         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Removed.
2394         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2395         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2396         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Removed.
2397         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Removed.
2398
2399 2011-08-30  Takashi Toyoshima  <toyoshim@chromium.org>
2400
2401         [WebSocket] update pywebsocket to 0.6b5.
2402         https://bugs.webkit.org/show_bug.cgi?id=66924
2403
2404         Reviewed by Kent Tamura.
2405
2406         pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
2407         Now, pywebsocket 0.6b5 supports full features of Hybi-10 specification.
2408         0.6b3 or later supports a closing handshake handler and it is useful to
2409         verify client's closing handshake implementation.
2410         0.6b4 supports AbortedByUserException. It is useful to eliminate
2411         unnecessary server warning messages on intended abnormal closures.
2412         0.6b5 supports Python 2.5.1 or Mac 10.5.
2413
2414         * Scripts/webkitpy/thirdparty/__init__.py:
2415         Update download URL and directory path.
2416
2417 2011-08-30  Dan Bernstein  <mitz@apple.com>
2418
2419         Test for <rdar://problem/9281695> Add text search API for getting the DOM range of a text match
2420         https://bugs.webkit.org/show_bug.cgi?id=67230
2421
2422         Reviewed by Darin Adler.
2423
2424         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2425         * TestWebKitAPI/Tests/mac/DOMRangeOfString.html: Added.
2426         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm: Added.
2427         (-[DOMRangeOfStringFrameLoadDelegate webView:didFinishLoadForFrame:]):
2428         (TestWebKitAPI::TEST):
2429
2430 2011-08-30  Aaron Colwell  <acolwell@chromium.org>
2431
2432         Add MediaSource API to HTMLMediaElement
2433         https://bugs.webkit.org/show_bug.cgi?id=64731
2434
2435         Reviewed by Eric Carlson.
2436
2437         * Scripts/build-webkit:
2438
2439 2011-08-30  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2440
2441         Emit last progress notification before calling dispatchDidFinishLoad
2442         https://bugs.webkit.org/show_bug.cgi?id=28851
2443
2444         Reviewed by Adam Barth.
2445
2446         Implement dumpProgressFinishedCallback() in the layoutTestController for Qt,
2447         Chromium and GTK ports. The first two were simple changes.
2448
2449         Some refactoring was needed in GTK port to assure that the dumps are emitted
2450         correctly and the processing after the page load finished is in the right place.
2451
2452         To detect the load finished, we use the callback for the "load-status" notifier
2453         signal of the top loading frame. And we use the deprecated "load-finished" signal
2454         for dumping (if enabled) the progress finished expected output.
2455
2456         * DumpRenderTree/LayoutTestController.cpp:
2457         (LayoutTestController::LayoutTestController):
2458         (dumpProgressFinishedCallbackCallback):
2459         (LayoutTestController::staticFunctions):
2460         * DumpRenderTree/LayoutTestController.h:
2461         (LayoutTestController::dumpProgressFinishedCallback):
2462         (LayoutTestController::setDumpProgressFinishedCallback):
2463         * DumpRenderTree/chromium/LayoutTestController.cpp:
2464         (LayoutTestController::LayoutTestController):
2465         (LayoutTestController::dumpProgressFinishedCallback):
2466         (LayoutTestController::reset):
2467         * DumpRenderTree/chromium/LayoutTestController.h:
2468         (LayoutTestController::shouldDumpProgressFinishedCallback):
2469         (LayoutTestController::setShouldDumpProgressFinishedCallback):
2470         * DumpRenderTree/chromium/WebViewHost.cpp:
2471         (WebViewHost::didStopLoading):
2472         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2473         (webViewLoadFinished):
2474         (topLoadingFrameLoadFinished):
2475         (webFrameLoadStatusNotified):
2476         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2477         (LayoutTestController::reset):
2478         (LayoutTestController::dumpProgressFinishedCallback):
2479         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2480
2481 2011-08-30  Filip Pizlo  <fpizlo@apple.com>
2482
2483         JavaScriptCore does not have a good mechanism for performance
2484         regression testing
2485         https://bugs.webkit.org/show_bug.cgi?id=67177
2486
2487         Reviewed by Darin Adler.
2488         
2489         Added a new script, which allows for testing one, two, or more VMs
2490         at once on SunSpider, V8, and Kraken benchmarks.  Benchmark/VM runs
2491         are interleaved at random to minimize systematics.  The results
2492         that bencher prints includes all possible relevant information about
2493         how bencher was invoked.  Bencher can be easily used to measure
2494         performance changes down to fractions of a percent.
2495         
2496         Bencher also includes experimental support for running benchmarks in
2497         a DumpRenderTree release build.  This works in SunSpider and V8, but
2498         not yet in Kraken.  Running benchmarks in DumpRenderTree more
2499         closely mimics the performance when running in browser.
2500
2501         * Scripts/bencher: Added.
2502
2503 2011-08-29  Alexey Proskuryakov  <ap@apple.com>
2504
2505         DumpRenderTree should begin each test with an empty cookie store
2506         https://bugs.webkit.org/show_bug.cgi?id=63545
2507         <rdar://problem/5666907>
2508
2509         Reviewed by Darin Adler.
2510
2511         * DumpRenderTree/mac/DumpRenderTree.mm:
2512         (resetDefaultsToConsistentValues):
2513         (setDefaultsToConsistentValuesForTesting):
2514         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2515         (LayoutTestController::setAlwaysAcceptCookies):
2516         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2517         (WTR::InjectedBundle::beginTesting):
2518         Use new SPIs to manipulate sessions.
2519
2520 2011-08-30  Sheriff Bot  <webkit.review.bot@gmail.com>
2521
2522         Unreviewed, rolling out r94055 and r94057.
2523         http://trac.webkit.org/changeset/94055
2524         http://trac.webkit.org/changeset/94057
2525         https://bugs.webkit.org/show_bug.cgi?id=67191
2526
2527         Many failures on Mac 10.5 (Requested by toyoshim on #webkit).
2528
2529         * Scripts/webkitpy/thirdparty/__init__.py:
2530
2531 2011-08-30  Adam Barth  <abarth@webkit.org>
2532
2533         Chromium Android should not be a core builder
2534         https://bugs.webkit.org/show_bug.cgi?id=67184
2535
2536         Reviewed by Ryosuke Niwa.
2537
2538         This bot hasn't been consistently green yet because it has never actually run!
2539
2540         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2541         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2542
2543 2011-08-30  Takashi Toyoshima  <toyoshim@chromium.org>
2544
2545         [WebSocket] update pywebsocket to 0.6b4.
2546         https://bugs.webkit.org/show_bug.cgi?id=66924
2547
2548         Reviewed by Kent Tamura.
2549
2550         pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
2551         Now, pywebsocket 0.6b4 supports full features of Hybi-10 specification.
2552         0.6b3 or later supports a closing handshake handler and it is useful to
2553         verify client's closing handshake implementation.
2554         0.6b4 supports AbortedByUserException. It is useful to eliminate
2555         unnecessary server warning messages on intended abnormal closures.
2556
2557         * Scripts/webkitpy/thirdparty/__init__.py:
2558         Update download URL and directory path.
2559
2560 2011-08-29  Tom Zakrajsek  <tomz@codeaurora.org>
2561
2562         sheriffbot "usage" help statements are wrong
2563         https://bugs.webkit.org/show_bug.cgi?id=67170
2564
2565         Reviewed by Adam Barth.
2566
2567         * Scripts/webkitpy/tool/bot/irc_command.py:
2568         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2569         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2570
2571 2011-08-29  Adam Barth  <abarth@webkit.org>
2572
2573         Add support for chomium-mac (non-CoreGraphics) baselines
2574         https://bugs.webkit.org/show_bug.cgi?id=67163
2575
2576         Reviewed by Eric Seidel.
2577
2578         This patch teaches the non-CG chromium-mac bots to look at non-CG
2579         baselines.  However, the patch still leaves CG as the default set of
2580         baselines.
2581
2582         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
2583         * Scripts/webkitpy/common/config/build.py:
2584         * Scripts/webkitpy/common/config/build_unittest.py:
2585         * Scripts/webkitpy/layout_tests/port/builders.py:
2586         * Scripts/webkitpy/layout_tests/port/chromium.py:
2587         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2588         * Scripts/webkitpy/layout_tests/port/factory.py:
2589         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2590         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2591         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2592         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2593
2594 2011-08-29  Shawn Singh  <shawnsingh@chromium.org>
2595
2596         Small fix in chromium port of new-run-webkit-tests.
2597         https://bugs.webkit.org/show_bug.cgi?id=67078
2598
2599         Reviewed by Dirk Pranke.
2600
2601         * Scripts/webkitpy/layout_tests/port/chromium.py:
2602
2603 2011-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
2604
2605         Unreviewed, rolling out r93987, r93992, r93995, r93998, and
2606         r93999.
2607         http://trac.webkit.org/changeset/93987
2608         http://trac.webkit.org/changeset/93992
2609         http://trac.webkit.org/changeset/93995
2610         http://trac.webkit.org/changeset/93998
2611         http://trac.webkit.org/changeset/93999
2612         https://bugs.webkit.org/show_bug.cgi?id=67147
2613
2614         Many failing tests (Requested by ap on #webkit).
2615
2616         * DumpRenderTree/mac/DumpRenderTree.mm:
2617         (setDefaultsToConsistentValuesForTesting):
2618         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2619         (WTR::InjectedBundle::beginTesting):
2620
2621 2011-08-26  Alexey Proskuryakov  <ap@apple.com>
2622
2623         DumpRenderTree should begin each test with an empty cookie store
2624         https://bugs.webkit.org/show_bug.cgi?id=63545
2625         <rdar://problem/5666907>
2626
2627         Reviewed by Darin Adler.
2628
2629         * DumpRenderTree/mac/DumpRenderTree.mm:
2630         (setDefaultsToConsistentValuesForTesting):
2631         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2632         (WTR::InjectedBundle::beginTesting):
2633         Tell WebCore to use a temporary session, starting with a clean cookie store.
2634
2635 2011-08-23  Chris Marrin  <cmarrin@apple.com>
2636
2637         [mac] requestAnimationFrame support for mac port
2638         https://bugs.webkit.org/show_bug.cgi?id=59146
2639
2640         Reviewed by Simon Fraser.
2641
2642         Add support for request-animation-callback flag
2643
2644         * Scripts/build-webkit:
2645
2646 2011-08-27  Peter Beverloo  <peter@chromium.org>
2647
2648         Add a build bot for Chromium with OS(ANDROID)
2649         https://bugs.webkit.org/show_bug.cgi?id=66687
2650
2651         Reviewed by Adam Barth.
2652
2653         * BuildSlaveSupport/build.webkit.org-config/config.json:
2654
2655 2011-08-27  Peter Beverloo  <peter@chromium.org>
2656
2657         Update the master build bot configuration script to properly
2658         deal with the --chromium-android switch.
2659         https://bugs.webkit.org/show_bug.cgi?id=66687
2660
2661         The --chromium-android switch is needed when running
2662         update-webkit-chromium and build-webkit, as it'll tell the
2663         scripts to pull in the right dependencies and cross-compile
2664         WebKit using the Android NDK.
2665
2666         Reviewed by Adam Barth.
2667
2668         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2669
2670 2011-08-27  Peter Beverloo  <peter@chromium.org>
2671
2672         Teach the update and build scripts how to handle dependencies
2673         and cross-compiling rules for the Chromium port on OS(ANDROID).
2674         https://bugs.webkit.org/show_bug.cgi?id=66687
2675
2676         Reviewed by Adam Barth.
2677
2678         * Scripts/build-webkit:
2679         * Scripts/update-webkit:
2680         * Scripts/update-webkit-chromium:
2681         * Scripts/webkitdirs.pm:
2682         (argumentsForConfiguration):
2683         (isChromium):
2684         (isChromiumAndroid):
2685         (determineIsChromiumAndroid):
2686         (buildChromium):
2687
2688 2011-08-26  Adam Barth  <abarth@webkit.org>
2689
2690         garden-o-matic should let me know that I need to run the local server
2691         https://bugs.webkit.org/show_bug.cgi?id=66985
2692
2693         Reviewed by Dimitri Glazkov.
2694
2695         The patch triggers an alert dialog whenever the user tries to use a
2696         feature that requires the local server.
2697
2698         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2699         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
2700         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
2701
2702 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
2703
2704         garden-o-matic summary view should have pretty commit data information.
2705         https://bugs.webkit.org/show_bug.cgi?id=67069
2706
2707         Reviewed by Adam Barth.
2708
2709         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added support for styling commit data.
2710         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Changed tests.
2711         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Defined global anchor color.
2712         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Styled commit data.
2713
2714 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
2715
2716         Tweak the use of Open Sans in garden-o-matic summary view to make it look decent on Windows and Linux.
2717         https://bugs.webkit.org/show_bug.cgi?id=67066
2718
2719         Reviewed by Adam Barth.
2720
2721         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Tweaked.
2722         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
2723
2724 2011-08-26  Raphael Kubo da Costa  <kubo@profusion.mobi>
2725
2726         [DRT] Include cairo.h in PixelDumpSupportCairo.h for EFL too.
2727         https://bugs.webkit.org/show_bug.cgi?id=67041
2728
2729         Reviewed by Martin Robinson.
2730
2731         This is a follow-up to r89053: EFL's PixelDumpSupportEfl.cpp includes
2732         PixelDumpSupportCairo.h, but the latter was #including cairo.h only
2733         when the GTK+ port was being built.
2734
2735         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
2736
2737 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
2738
2739         Clean up and line up layout in garden-o-matic summary view.
2740         https://bugs.webkit.org/show_bug.cgi?id=67057
2741
2742         1) Renamed ui.notifications.TestFailures to ui.notifications.TestsFailing to match BuildersFailing;
2743         2) Rearranged DOM structure a bit to accommodate recent changes;
2744         3) Added minimal CSS to line things up.
2745
2746         Reviewed by Adam Barth.
2747
2748         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Renamed TestFailures to TestsFailing.
2749         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added mocks for BuildersFailing.
2750         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Renamed TestFailures to TestsFailing.
2751         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Updated tests.
2752         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed DOM structure.
2753         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
2754         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked common appearance.
2755         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added minimal layout/style.
2756         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added Google Web Fonts hook.
2757         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
2758
2759 2011-08-26  Alice Liu  <alice.liu@apple.com>
2760
2761         https://bugs.webkit.org/show_bug.cgi?id=66823
2762         Add the request info to the WebPageProxy::CreateNewPage message
2763
2764         Reviewed by Anders Carlsson.
2765
2766         Update function declarations with additional parameter:
2767         * MiniBrowser/gtk/BrowserWindow.c:
2768         (createNewPage):
2769         * MiniBrowser/mac/BrowserWindowController.m:
2770         (createNewPage):
2771         * MiniBrowser/win/BrowserView.cpp:
2772         (createNewPage):
2773         * WebKitTestRunner/TestController.cpp:
2774         (WTR::TestController::createOtherPage):
2775         * WebKitTestRunner/TestController.h:
2776
2777 2011-08-26  Noel Gordon  <noel.gordon@gmail.com>
2778
2779         Make show-pretty-diff work on linux
2780         https://bugs.webkit.org/show_bug.cgi?id=67017
2781
2782         Reviewed by Adam Barth.
2783
2784         * Scripts/show-pretty-diff:
2785
2786 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
2787
2788         Reorganize garden-o-matic CSS files to match JS-built views.
2789         https://bugs.webkit.org/show_bug.cgi?id=66998
2790
2791         Reviewed by Adam Barth.
2792
2793         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Added.
2794         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added.
2795         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css: Added.
2796         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Removed.
2797         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Changed to use new CSS files.
2798         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
2799
2800 2011-08-25  Adam Barth  <abarth@webkit.org>
2801
2802         garden-o-matic should be able to roll out patches
2803         https://bugs.webkit.org/show_bug.cgi?id=66982
2804
2805         Reviewed by Dimitri Glazkov.
2806
2807         This patch just wires the rollout event through the controller to the
2808         local server, which is already set up to perform rollouts.
2809
2810         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2811         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2812         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2813         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2814
2815 2011-08-25  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
2816
2817         [Qt] [WK2] Assert in computeViewportAttributes when MiniBrowser started with -touch
2818         https://bugs.webkit.org/show_bug.cgi?id=66951
2819
2820         Reviewed by Andreas Kling.
2821
2822         Function computeViewportAttributes() gets called when height is still 0 because MiniBrowser sets
2823         width and height one by one and setWidth cause geometryChange event in QTouchWebView. 
2824
2825         * MiniBrowser/qt/BrowserView.cpp:
2826         (BrowserView::resizeEvent):
2827
2828 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
2829
2830         garden-o-matic summary view should provide information on builders still in flight.
2831         https://bugs.webkit.org/show_bug.cgi?id=66992
2832
2833         Reviewed by Adam Barth.
2834
2835         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Added grabbing the list of in-flight builders.
2836         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Added buildersInFlightForRevision.
2837         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Added tests.
2838         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Split off updating builder results to own method.
2839         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
2840
2841 2011-08-25  Adam Barth  <abarth@webkit.org>
2842
2843         webkit-patch rebaseline-expectations don't work when run outside the root
2844         https://bugs.webkit.org/show_bug.cgi?id=66966
2845
2846         Reviewed by Eric Seidel.
2847
2848         Turns out tool.path() used to be relative, which caused problems when
2849         running webkit-patch outside the root directory.  This patch makes it
2850         absolute.  I checked all callers, and they all appear to want this
2851         behavior.
2852
2853         It was unclear to me how to test this change because we only really
2854         have a testing strategy for webkitpy, not for the main script.
2855
2856         * Scripts/webkit-patch:
2857
2858 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
2859
2860         garden-o-matic summary needs a mock view that could be used for working on styling
2861         https://bugs.webkit.org/show_bug.cgi?id=66971
2862
2863         Reviewed by Adam Barth.
2864
2865         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added.
2866         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added.
2867
2868 2011-08-25  Anders Carlsson  <andersca@apple.com>
2869
2870         Return the correct value for NPNVsupportsCarbonBool
2871         https://bugs.webkit.org/show_bug.cgi?id=66964
2872
2873         Add a test.
2874
2875         Reviewed by Adam Roben.
2876
2877         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2878         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Added.
2879         (SupportsCarbonEventModel::SupportsCarbonEventModel):
2880         (SupportsCarbonEventModel::testConvert):
2881         (SupportsCarbonEventModel::runTest):
2882         (SupportsCarbonEventModel::NPP_New):
2883
2884 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
2885
2886         garden-o-matic summary view should not be broken.
2887
2888         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
2889         (table.comparison): Added more specificity.
2890
2891 2011-08-25  Adam Barth  <abarth@webkit.org>
2892
2893         This command has been broken for a while.  This patch updates the
2894         callsite to the new API.
2895
2896         * Scripts/webkitpy/tool/commands/rebaseline.py:
2897
2898 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
2899
2900         garden-o-matic needs a way to report where and how tests are failing in the summary view.
2901         https://bugs.webkit.org/show_bug.cgi?id=66955
2902
2903         Introduce FailureGrid, your one-stop failure-indicating destination. 
2904
2905         Reviewed by Adam Barth.
2906
2907         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added new scripts.
2908         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Added.
2909         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Added.
2910         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Updated to use FailureGrid.
2911         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
2912         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added new scripts.
2913
2914 2011-08-25  Igor Oliveira  <igor.oliveira@openbossa.org>
2915
2916         Add myself to the committers list
2917         https://bugs.webkit.org/show_bug.cgi?id=66941
2918
2919         Reviewed by Andreas Kling.
2920
2921         * Scripts/webkitpy/common/config/committers.py:
2922
2923 2011-08-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2924
2925         Unreviewed, rolling out r93767.
2926         http://trac.webkit.org/changeset/93767
2927         https://bugs.webkit.org/show_bug.cgi?id=66931
2928
2929         Broke Qt bot. (Requested by yutak on #webkit).
2930
2931         * Scripts/webkitpy/thirdparty/__init__.py:
2932
2933 2011-08-25  Takashi Toyoshima  <toyoshim@chromium.org>
2934
2935         [WebSocket] update pywebsocket to 0.6b3 which supports closing handshake test
2936         https://bugs.webkit.org/show_bug.cgi?id=66924
2937
2938         Reviewed by Kent Tamura.
2939
2940         * Scripts/webkitpy/thirdparty/__init__.py:
2941
2942 2011-08-24  Adam Barth  <abarth@webkit.org>
2943
2944         The user can't close the details view in garden-o-matic
2945         https://bugs.webkit.org/show_bug.cgi?id=66911
2946
2947         Reviewed by Dimitri Glazkov.
2948
2949         In addition to adding a close button, this patch changes the test
2950         selector to use a <select> element and refactors the test selector to
2951         share code with the builder selector.
2952
2953         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2954         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
2955         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
2956         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2957
2958 2011-08-24  James Robinson  <jamesr@chromium.org>
2959
2960         [chromium] Stacktrace not in test output when a test crashes
2961         https://bugs.webkit.org/show_bug.cgi?id=66806
2962
2963         Reviewed by Dirk Pranke.
2964
2965         Appends the .error and .text output when a test crashes since on chromium the .text contains the actual stack
2966         trace.
2967
2968         * Scripts/webkitpy/layout_tests/port/chromium.py:
2969
2970 2011-08-24  Adam Barth  <abarth@webkit.org>
2971
2972         Remove empty directory.
2973
2974         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui: Removed.
2975
2976 2011-08-24  Adam Barth  <abarth@webkit.org>
2977
2978         Finish writing up details-view in garden-o-matic
2979         https://bugs.webkit.org/show_bug.cgi?id=66891
2980
2981         Reviewed by Dimitri Glazkov.
2982
2983         This patch mostly just copies a bunch of CSS from main.css to
2984         summary.css.  Presumably we'll delete main.css soon.
2985
2986         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2987         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
2988         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
2989         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
2990         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
2991
2992 2011-08-24  James Robinson  <jamesr@chromium.org>
2993
2994         Some compositing LayoutTests flakily crashing on Mac 10.6
2995         https://bugs.webkit.org/show_bug.cgi?id=66740
2996
2997         Reviewed by Adam Barth.
2998
2999         Null-check obj->pluginTest before dereferencing it. This can be null in chromium if the plugin load fails, for
3000         example if the test attempts to load a PDF plugin the load will fail since we don't have such a thing in the
3001         chromium configuration.
3002
3003         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3004         (NPP_Destroy):
3005
3006 2011-08-24  Anton D'Auria  <adauria@apple.com>
3007
3008         No review necessary.
3009
3010         Adding myself to list of committers.
3011
3012         * Scripts/webkitpy/common/config/committers.py:
3013
3014 2011-08-24  Avi Drissman  <avi@google.com>
3015
3016         Crash when restoring NSGraphicsContext when running the Chromium GPU layout tests on Mac
3017         https://bugs.webkit.org/show_bug.cgi?id=66875
3018
3019         Reviewed by James Robinson.
3020
3021         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
3022         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3023
3024 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
3025
3026         Make notifications appear in time order again.
3027         https://bugs.webkit.org/show_bug.cgi?id=66815
3028
3029         Reviewed by Adam Barth.
3030
3031         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added setting index of the notification.
3032         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated the test.
3033
3034 2011-08-23  James Robinson  <jamesr@chromium.org>
3035
3036         [chromium] Need a way to test lost compositor context recovery
3037         https://bugs.webkit.org/show_bug.cgi?id=66820
3038
3039         Reviewed by Kenneth Russell.
3040
3041         Exposes a LayoutTestController interface in chromium to simulate a
3042         lost compositor context.
3043
3044         * DumpRenderTree/chromium/LayoutTestController.cpp:
3045         (LayoutTestController::LayoutTestController):
3046         (LayoutTestController::loseCompositorContext):
3047         * DumpRenderTree/chromium/LayoutTestController.h:
3048
3049 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
3050
3051         Change garden-o-matic frontend builder array to be a configuration map.
3052         https://bugs.webkit.org/show_bug.cgi?id=66816
3053
3054         Reviewed by Adam Barth.
3055
3056         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Made kBuilders a map, with value being a configuration object.
3057         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Adjusted callsites to expect a map.
3058         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Ditto.
3059         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Ditto.
3060         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Ditto.
3061
3062 2011-08-23  Cary Clark  <caryclark@google.com>
3063
3064         Turn WebCanvas into CGContext before drawing scrollbar (DRT using Skia on Mac)
3065         https://bugs.webkit.org/show_bug.cgi?id=66803
3066
3067         This fixes the WebKit Canaries, in particular avoids a crash on tests
3068         like css1/basic/comments.html.
3069
3070         Reviewed by James Robinson.
3071
3072         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
3073         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3074         The NSGraphicsContext call graphicsContextWithGraphicsPort takes a void*
3075         parameter, so it took a WebCanvas* (mapped to SkCanvas* in Skia-land)
3076         and treated it as if it were a CGContextRef.
3077
3078 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
3079
3080         Fix mergeChangeLogs test on native windows
3081         https://bugs.webkit.org/show_bug.cgi?id=66797
3082
3083         Reviewed by Adam Roben.
3084
3085         Windows has no /tmp/ directory and the "TMPDIR" environment variable isn't set in the default setup.
3086         Add the "TEMP" environment variable as additional source for the temporary directory used in writeTempFile.
3087
3088         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
3089         (writeTempFile):
3090
3091 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
3092
3093         garden-o-matic relative time is wrong and updates too frequently.
3094         https://bugs.webkit.org/show_bug.cgi?id=66802
3095
3096         Reviewed by Adam Barth.
3097
3098         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Changed to account for rounding correctly.
3099         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Updated tests.
3100         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Upped the interval to 1 minute.
3101
3102 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
3103
3104         Add missing quotes around filenames in mergeChangeLogs
3105         https://bugs.webkit.org/show_bug.cgi?id=66794
3106
3107         Reviewed by Adam Roben.
3108
3109         * Scripts/VCSUtils.pm:
3110         (mergeChangeLogs):
3111
3112 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
3113
3114         webkit-perl tests fail on win32 Perl due to lack of list form of pipe open implementation
3115         https://bugs.webkit.org/show_bug.cgi?id=49080
3116
3117         Reviewed by Adam Roben.
3118
3119         Use the string form of pipe open instead (like we do at all other places).
3120
3121         * Scripts/VCSUtils.pm:
3122         (mergeChangeLogs):
3123
3124 2011-08-23  Adam Barth  <abarth@webkit.org>
3125
3126         garden-o-matic summary should be able to examine failures
3127         https://bugs.webkit.org/show_bug.cgi?id=66748
3128
3129         Reviewed by Dimitri Glazkov.
3130
3131         This patch refactors a bunch of code from summary.js to independent
3132         controllers in controllers.js.  This patch also contains the first
3133         iteration of binding the "examine" event to a the behavior showing the
3134         details view for the tests.  There's more work to do here to make this
3135         work properly (and elegantly), but this patch is a start.
3136
3137         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3138         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
3139         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3140         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
3141         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
3142         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3143         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3144         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
3145         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
3146
3147 2011-08-23  Adam Barth  <abarth@webkit.org>
3148
3149         webkitpy/common/config/build.py shouldn't mention non-existant Android directory
3150         https://bugs.webkit.org/show_bug.cgi?id=66737
3151
3152         Reviewed by Steve Block.
3153
3154         This directory doesn't exist anymore now that the Android port shares
3155         more code with Chromium.
3156
3157         * Scripts/webkitpy/common/config/build.py:
3158
3159 2011-08-22  Eric Seidel  <eric@webkit.org>
3160
3161         Hack start-queue.sh in an attempt to resurrect the cr-jail-1 cr-mac-ews bot.
3162         I won't have ssh access to the bot again for a couple days, so
3163         attempting to fix by changing this script.  If this doesn't
3164         work we'll just live with the it hung for now.
3165
3166         Unreviewed.
3167
3168         * EWSTools/start-queue.sh:
3169
3170 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
3171
3172         webkit-patch rebaseline-expectations command should not rearrange the entire test_expectations.txt file.
3173         https://bugs.webkit.org/show_bug.cgi?id=66727
3174
3175         Reviewed by Adam Barth.
3176
3177         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Made it possible to run TestExpectationSerializer without a TestConfigurationConverter,
3178             in which case the serializer treats all expectations as unparsed.
3179         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added unit tests.
3180
3181 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
3182
3183         Update unit test expectations after r93530.
3184
3185         * Scripts/webkitpy/layout_tests/port/factory_unittest.py: Updated.
3186         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
3187
3188 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
3189
3190         [Chromium] Expand CPU/GPU/Skia/CG into a matrix in graphics_type.
3191         https://bugs.webkit.org/show_bug.cgi?id=66705
3192
3193         Reviewed by Adam Barth.
3194
3195         * Scripts/webkitpy/layout_tests/port/chromium.py: Added plumbing for CG graphics types.
3196         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Adjusted unit test.
3197
3198 2011-08-22  James Robinson  <jamesr@chromium.org>
3199
3200         [chromium] Update builder names for chromium gpu bots due to CG switchover
3201         https://bugs.webkit.org/show_bug.cgi?id=66693
3202
3203         Reviewed by Dirk Pranke.
3204
3205         Update the port and builder names for the chromium mac gpu bots to
3206         account for the CG transition.
3207
3208         * Scripts/webkitpy/layout_tests/port/builders.py:
3209
3210 2011-08-22  Dirk Pranke  <dpranke@chromium.org>
3211
3212         fix the GPU bot names on the layout test dashboard
3213         https://bugs.webkit.org/show_bug.cgi?id=66697
3214
3215         Reviewed by Dimitri Glazkov.
3216
3217         * TestResultServer/static-dashboards/builders.js:
3218
3219 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
3220
3221         garden-o-matic's relative time display should be updated regularly.
3222         https://bugs.webkit.org/show_bug.cgi?id=66682
3223
3224         Reviewed by Adam Barth.
3225
3226         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Moved Time to ui.Time, added code for regular updates.
3227         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed to use ui.Time.
3228         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Added tests.
3229
3230 2011-08-22  Xianzhu Wang  <wangxianzhu@chromium.org>
3231
3232         Pass --makeargs of build-webkit to chromium linux builder
3233         https://bugs.webkit.org/show_bug.cgi?id=66361
3234
3235         Reviewed by Tony Chang.
3236
3237         * Scripts/build-webkit:
3238         * Scripts/webkitdirs.pm:
3239         (buildChromiumMakefile):
3240         (buildChromium):
3241
3242 2011-08-22  Peter Beverloo  <peter@chromium.org>
3243
3244         Add myself to the contributor list.
3245         https://bugs.webkit.org/show_bug.cgi?id=66674
3246
3247         Reviewed by Tony Gentilcore.
3248
3249         * Scripts/webkitpy/common/config/committers.py:
3250
3251 2011-08-22  Balazs Kelemen  <kbalazs@webkit.org>
3252
3253         [Qt] ImageDiff does not consider --tolerance
3254         https://bugs.webkit.org/show_bug.cgi?id=66299
3255
3256         Reviewed by Csaba Osztrogonác.
3257
3258         * DumpRenderTree/qt/ImageDiff.cpp:
3259         (main):
3260
3261 2011-08-22  Csaba Osztrogonác  <ossy@webkit.org>
3262
3263         Update contributor list.
3264
3265         Reviewed by Zoltan Herczeg.
3266
3267         * Scripts/webkitpy/common/config/committers.py:
3268
3269 2011-08-22  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
3270
3271         [ORWT] Fix --reset-results --add-platform-exceptions combo
3272         https://bugs.webkit.org/show_bug.cgi?id=65464
3273
3274         Reviewed by Csaba Osztrogonác.
3275
3276         * Scripts/old-run-webkit-tests:
3277
3278 2011-08-20  Adam Barth  <abarth@webkit.org>
3279
3280         garden-o-matic summary.html should have UI for examining failures
3281         https://bugs.webkit.org/show_bug.cgi?id=66625
3282
3283         Reviewed by Dimitri Glazkov.
3284
3285         This patch introduces the notion of UI actions and converts our
3286         existing manual <button> manipulation with this new abstraction.  The
3287         patch also adds an Examine button to failure notifications.  In a
3288         future patch, I'll add a controller that wires this button up to
3289         something useful.
3290
3291         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3292         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
3293         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: Added.
3294         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js: Added.
3295         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3296         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3297         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3298         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
3299
3300 2011-08-20  Adam Barth  <abarth@webkit.org>
3301
3302         garden-o-matic summary page should indiciate compile failures
3303         https://bugs.webkit.org/show_bug.cgi?id=66624
3304
3305         Reviewed by Dimitri Glazkov.
3306
3307         This patch creates a notification-based UI for build failures.  The new
3308         UI displays the same information that used to be displayed in the
3309         infobar.  There's lots of room for improvement in surfacing more
3310         information, but this is a start.
3311
3312         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
3313         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3314         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3315
3316 2011-08-19  James Robinson  <jamesr@chromium.org>
3317
3318         [chromium] Default to experimental-fully-parallel mode for chromium gpu port
3319         https://bugs.webkit.org/show_bug.cgi?id=66606
3320
3321         Reviewed by Dirk Pranke.
3322
3323         The chromium GPU configuration does not (currently) contain any tests
3324         incompatible with --experimental-fully-parallel, and this flag is a
3325         significan speedup because of the directory canvas/philip/tests which
3326         contains 802 tests in the same directory. Setting this option by
3327         default on this configuration is a 2x speed in release, 44s to 22s,
3328         and a 3x speedup in debug, 223s to 77s, on linux on a 16 core machine.
3329
3330         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3331         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3332         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3333
3334 2011-08-19  Sheriff Bot  <webkit.review.bot@gmail.com>
3335
3336         Unreviewed, rolling out r93426.
3337         http://trac.webkit.org/changeset/93426
3338         https://bugs.webkit.org/show_bug.cgi?id=66607
3339
3340         Broke the Mac build by not building gtest.framework anymore
3341         (Requested by andersca on #webkit).
3342
3343         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3344
3345 2011-08-19  James Robinson  <jamesr@chromium.org>
3346
3347         [chromium] Chromium GPU layout tests should use the normal process number selection, not force 1 worker
3348         https://bugs.webkit.org/show_bug.cgi?id=66603
3349
3350         Reviewed by Dirk Pranke.
3351
3352         The various ChromiumGpu ports should use the same child worker
3353         selection logic as other ports so they can run with full
3354         parallelization on multicore systems.
3355
3356         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3357         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3358
3359 2011-08-19  Alok Priyadarshi  <alokp@chromium.org>
3360
3361         [chromium] Remove dependency of WebThemeControlDRTWin on skia::PlatformCanvas
3362         https://bugs.webkit.org/show_bug.cgi?id=66570
3363
3364         Reviewed by Mihai Parparita.
3365
3366         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
3367         (WebThemeControlDRTWin::draw):
3368         (WebThemeControlDRTWin::drawTextField):
3369         (WebThemeControlDRTWin::drawProgressBar):
3370         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
3371
3372 2011-08-18  Dmitry Lomov  <dslomov@google.com>
3373
3374         TestWebKitAPI breaks on Windows due to fast malloc incompatibility.
3375         https://bugs.webkit.org/show_bug.cgi?id=66521
3376
3377         This patch ensures that gtest uses new and delete operators that are defined in JavaScriptCore.
3378
3379         Reviewed by David Levin.
3380
3381         * TestWebKitAPI/Tests/WTF/StringOperators.cpp: Removed redefinition of JS_EXPORTDATA.
3382
3383 2011-08-19  Adam Roben  <aroben@apple.com>
3384
3385         Add project file changes I left out in r93417
3386
3387         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3388
3389 2011-08-19  Adam Roben  <aroben@apple.com>
3390
3391         Add a helper class for swizzling ObjC instance methods to TestWebKitAPI
3392
3393         Fixes <http://webkit.org/b/66565> TestWebKitAPI needs a way to override instance methods of
3394         NSScreen
3395
3396         Reviewed by Anders Carlsson.
3397
3398         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
3399
3400         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
3401         (-[SimpleObject setValue:]): Original implementation.
3402
3403         (TestWebKitAPI::setValue2):
3404         (TestWebKitAPI::setValue3):
3405         Swizzled implementations.
3406
3407         (TestWebKitAPI::TEST): Test that we can swizzle and re-swizzle and un-swizzle an ObjC
3408         instance method.
3409
3410         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Added.
3411         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
3412         (TestWebKitAPI::InstanceMethodSwizzler::InstanceMethodSwizzler): Swizzle the method.
3413         (TestWebKitAPI::InstanceMethodSwizzler::~InstanceMethodSwizzler): Unswizzle the method.
3414
3415 2011-08-19  Tom Zakrajsek  <tomz@codeaurora.org>
3416
3417         Fix _path_to_apache() error reporting
3418         https://bugs.webkit.org/show_bug.cgi?id=66486
3419
3420         Reviewed by Ryosuke Niwa.
3421
3422         * Scripts/webkitpy/layout_tests/port/webkit.py:
3423
3424 2011-08-19  Adam Roben  <aroben@apple.com>
3425
3426         Windows build fix after r93404
3427
3428         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Added missing #include.
3429
3430 2011-08-19  Tony Gentilcore  <tonyg@chromium.org>
3431
3432         Add leandrogracia to the committers list
3433         https://bugs.webkit.org/show_bug.cgi?id=66552
3434
3435         Also fix line endings in file.
3436
3437         No reviewed required.
3438
3439         * Scripts/webkitpy/common/config/committers.py:
3440
3441 2011-08-19  Amruth Raj  <amruthraj@motorola.com>
3442
3443         Fix compilation issue in WebKitTestRunner
3444         https://bugs.webkit.org/show_bug.cgi?id=66554
3445
3446         Reviewed by Martin Robinson.
3447
3448         * WebKitTestRunner/PixelDumpSupport.cpp:
3449
3450 2011-08-19  Adam Roben  <aroben@apple.com>
3451
3452         Pull some of DynamicDeviceScaleFactor's code up into a shareable base class
3453
3454         This will make it easier to write other WebKit-agnostic tests
3455
3456         Fixes <http://webkit.org/b/66558> Would like to be able to reuse DynamicDeviceScaleFactor's
3457         code in other WebKit-agnostic tests
3458
3459         Reviewed by Anders Carlsson.
3460
3461         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
3462
3463         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Fixed copyright. Moved a bunch of
3464         code to WebKitAgnosticTest.h/mm. Changed to inherit from WebKitAgnosticTest.
3465         (TestWebKitAPI::DynamicDeviceScaleFactor::url): Simple getter.
3466         (TestWebKitAPI::DynamicDeviceScaleFactor::didLoadURL): Calls through to runTest.
3467         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Removed loading code which
3468         WebKitAgnosticTest handles for us.
3469         (TestWebKitAPI::TEST_F): Removed view-creation code which WebKitAgnosticTest handles for us.
3470
3471         * TestWebKitAPI/mac/WebKitAgnosticTest.h: Added. Code came from DynamicDeviceScaleFactor.
3472         (TestWebKitAPI::WebKitAgnosticTest::loadAndWaitUntilDone): Code came from
3473         DynamicDeviceScaleFactor::runTest.
3474
3475         * TestWebKitAPI/mac/WebKitAgnosticTest.mm: Copied from Tools/TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm.
3476         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test): Code came from
3477         DynamicDeviceScaleFactor.WebKit.
3478         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test): Code came from
3479         DynamicDeviceScaleFactor.WebKit2.
3480
3481 2011-08-19  Adam Roben  <aroben@apple.com>
3482
3483         Clean up #includes in TestWebKitAPI
3484
3485         Fixes <http://webkit.org/b/66556> TestWebKitAPI's prefix header isn't very helpful
3486
3487         Reviewed by Anders Carlsson.
3488
3489         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added wtf/Platform.h. Added gtest/gtest.h for C++
3490         files and WebKit/WebKit.h for ObjC files.
3491
3492         * TestWebKitAPI/InjectedBundleController.cpp:
3493         * TestWebKitAPI/JavaScriptTest.h:
3494         * TestWebKitAPI/PlatformUtilities.h:
3495         * TestWebKitAPI/PlatformWebView.h:
3496         * TestWebKitAPI/Test.h:
3497         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3498         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
3499         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
3500         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
3501         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
3502         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
3503         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
3504         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
3505         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
3506         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
3507         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
3508         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
3509         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
3510         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
3511         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
3512         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
3513         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
3514         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
3515         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
3516         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
3517         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3518         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3519         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
3520         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
3521         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
3522         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
3523         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3524         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
3525         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
3526         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
3527         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
3528         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
3529         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
3530         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
3531         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
3532         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
3533         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
3534         * TestWebKitAPI/TestsController.cpp:
3535         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3536         Removed now-unnecessary #includes. Moved #includes of Test.h in with the rest of the
3537         #includes since it is no longer a special header.
3538
3539 2011-08-18  Dirk Pranke  <dpranke@chromium.org>
3540
3541         new-run-webkit-tests hung while acquiring http lock on snow leopard bots
3542         https://bugs.webkit.org/show_bug.cgi?id=64886
3543
3544         Temporarily disable the http locking to work around the issue.
3545         I'm not actually sure if this is going to work or improve things
3546         much.
3547
3548         Reviewed by Ryosuke Niwa.
3549
3550         * Scripts/webkitpy/layout_tests/port/mac.py:
3551
3552 2011-08-18  Tony Chang  <tony@chromium.org>
3553
3554         add embedded png checksums to WebKitTestRunner
3555         https://bugs.webkit.org/show_bug.cgi?id=66494
3556
3557         Looks like WebKitTestRunner has never supported embedded checksums.  This copies
3558         some code from DRT and adds it to the WebKitTestRunner.
3559
3560         Reviewed by Darin Adler.
3561
3562         * WebKitTestRunner/CyclicRedundancyCheck.cpp: Copied from Tools/DumpRenderTree
3563         * WebKitTestRunner/CyclicRedundancyCheck.h: Copied from Tools/DumpRenderTree
3564         * WebKitTestRunner/GNUmakefile.am: Add new files
3565         * WebKitTestRunner/PixelDumpSupport.cpp: Copied from Tools/DumpRenderTree
3566         * WebKitTestRunner/PixelDumpSupport.h: Copied from Tools/DumpRenderTree
3567         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add new files
3568         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
3569         (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
3570         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3571         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3572         (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
3573         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3574         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Add new files
3575
3576 2011-08-18  Shawn Singh  <shawnsingh@chromium.org>
3577
3578         https://bugs.webkit.org/show_bug.cgi?id=47240
3579
3580         Fixed a cygwin path problem in the chromium port of diff_image;
3581         Also made the return values of the diff_image function more consistent.
3582
3583         Reviewed by Dirk Pranke.
3584
3585         * Scripts/webkitpy/layout_tests/port/chromium.py:
3586
3587 2011-08-17  Alejandro G. Castro  <alex@igalia.com>
3588
3589         [GTK] Fix compilation problems with deprecations in gtk+
3590         https://bugs.webkit.org/show_bug.cgi?id=66073
3591
3592         Reviewed by Martin Robinson.
3593
3594         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3595         (main): G_CONST_RETURN was deprecated
3596         * GtkLauncher/main.c:
3597         (createWindow): Added gtk_box_new conditional compilation for
3598         gtk+-3.
3599         * MiniBrowser/gtk/BrowserWindow.c:
3600         (browser_window_init): Replaced gtk_vbox_new with gtk_box_new, we
3601         are just supporting gtk+-3 for WebKit2.
3602
3603 2011-08-18  Anders Carlsson  <andersca@apple.com>
3604
3605         Fix libc++ C++0x build
3606         https://bugs.webkit.org/show_bug.cgi?id=66479
3607
3608         Reviewed by Adam Roben.
3609
3610         Add missing includes.
3611
3612         * DumpRenderTree/LayoutTestController.cpp:
3613         * DumpRenderTree/mac/CheckedMalloc.cpp:
3614
3615 2011-08-18  Adam Roben  <aroben@apple.com>
3616
3617         Test that WebKit updates style when a WebView is moved between differently-scaled windows
3618
3619         Test for <http://webkit.org/b/66412> <rdar://problem/9971958> WebKit doesn't react when a
3620         WebView is moved between windows with different backing scale factors
3621
3622         Reviewed by Anders Carlsson.
3623
3624         * TestWebKitAPI/JavaScriptTest.cpp:
3625         (TestWebKitAPI::runJSTest): Moved a little bit of code from here...
3626         (TestWebKitAPI::compareJSResult): ...to here. Also made the error message more similar to
3627         gtest's built-in error messages.
3628
3629         * TestWebKitAPI/JavaScriptTest.h: Added overloads of runJSTest that take a WebView * and
3630         WKView * for convenience on Mac. Added compareJSResult helper function for implementing
3631         those overloads.
3632
3633         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
3634
3635         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Added.
3636         (-[FrameLoadDelegate initWithDidFinishLoadBoolean:]): Simple initializer.
3637         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Record that the load finished.
3638         (TestWebKitAPI::didFinishLoadForFrame): Record that the load finished.
3639         (TestWebKitAPI::setPageLoaderClient): Set up the client.
3640         (TestWebKitAPI::DynamicDeviceScaleFactor::DynamicDeviceScaleFactor): Simple constructor.
3641         (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow): Creates a
3642         SyntheticBackingScaleFactorWindow and returns it.
3643         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Loads devicePixelRatio.html and checks
3644         that WebKit uses the correct scale factor when the WebView is not in a window, is put in a
3645         window, is moved to a differently-scaled window, and is taken out of the window.
3646         (TestWebKitAPI::DynamicDeviceScaleFactor::loadURL): Helper function with overloads for
3647         WebKit1 and WebKit2.
3648         (TestWebKitAPI::TEST_F): Runs the test, with overloads for WebKit1 and WebKit2.
3649
3650         * TestWebKitAPI/Tests/mac/devicePixelRatio.html: Added.
3651
3652         * TestWebKitAPI/mac/JavaScriptTestMac.mm: Added.
3653         (TestWebKitAPI::runJSTest): Fairly simple overloads for WebView * and WKView *.
3654
3655         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.h: Added.
3656         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m: Added.
3657         (-[SyntheticBackingScaleFactorWindow initWithContentRect:styleMask:backing:defer:]): Simple
3658         initializer.
3659         (-[SyntheticBackingScaleFactorWindow setBackingScaleFactor:]): Simple setter.
3660
3661         (-[SyntheticBackingScaleFactorWindow backingScaleFactor]):
3662         (-[SyntheticBackingScaleFactorWindow userSpaceScaleFactor]):
3663         Overrides of NSWindow methods that WebKit uses to determine the device scale factor.
3664
3665 2011-08-18  Dmitry Lomov  <dslomov@google.com>
3666
3667         https://bugs.webkit.org/show_bug.cgi?id=66425
3668         check-webkit-style should detect incorrectly formatted file change descriptions.
3669         Description, if present, should be separated from colon with a space.
3670
3671         Reviewed by David Levin.
3672
3673         * Scripts/webkitpy/style/checkers/changelog.py: Fix.
3674         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Unit tests.
3675
3676 2011-08-18  Adam Barth  <abarth@webkit.org>
3677
3678         webkit-patch pretty-diff should be shown in main help
3679         https://bugs.webkit.org/show_bug.cgi?id=66404
3680
3681         Reviewed by Dimitri Glazkov.
3682
3683         As requested by dglazkov.
3684
3685         * Scripts/webkitpy/tool/commands/prettydiff.py:
3686
3687 2011-08-17  Dmitry Lomov  <dslomov@google.com>
3688
3689         https://bugs.webkit.org/show_bug.cgi?id=66400
3690         Fix TestWebKitAPI build on Mac OS.
3691
3692         Reviewed by David Levin.
3693
3694         * TestWebKitAPI/Configurations/Base.xcconfig: Added ICU headers to the HEADER_SEARCH_PATH.
3695
3696 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
3697
3698         garden-o-matic spring cleaning: move scripts, styles, and images in the respective directories.
3699         https://bugs.webkit.org/show_bug.cgi?id=66427
3700
3701         Reviewed by Adam Barth.
3702
3703         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js: Removed.
3704         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Removed.
3705         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js: Removed.
3706         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Removed.
3707         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js: Removed.
3708         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js: Removed.
3709         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js: Removed.
3710         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js: Removed.
3711         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js: Removed.
3712         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js: Removed.
3713         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js: Removed.
3714         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js: Removed.
3715         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js: Removed.
3716         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js: Removed.
3717         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js: Removed.
3718         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js: Removed.
3719         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js: Removed.
3720         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js: Removed.
3721         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css: Removed.
3722         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js: Removed.
3723         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js: Removed.
3724         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Removed.
3725         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Removed.
3726         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js: Removed.
3727         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Removed.
3728         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js: Removed.
3729         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Removed.
3730         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed.
3731         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed.
3732         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js: Removed.
3733         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js: Removed.
3734         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Removed.
3735         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js: Removed.
3736         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js: Removed.
3737         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js: Removed.
3738         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Removed.
3739         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Removed.
3740         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Removed.
3741         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png: Removed.
3742         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png: Removed.
3743         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3744         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images: Added.
3745         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png.
3746         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png.
3747         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
3748         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css: Removed.
3749         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Removed.
3750         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Removed.
3751         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Removed.
3752         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js: Removed.
3753         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js: Removed.
3754         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html:
3755         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js: Removed.
3756         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js: Removed.
3757         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
3758         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js.
3759         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js.
3760         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js.
3761         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js.
3762         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js.
3763         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js.
3764         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js.
3765         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js.
3766         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js.
3767         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js.
3768         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js.
3769         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestHistoryAnalyzer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js.
3770         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestResultsLoader.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js.
3771         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NRWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js.
3772         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js.
3773         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js.
3774         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ORWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js.
3775         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/PersistentCache.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js.
3776         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js.
3777         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js.
3778         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js.
3779         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js.
3780         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js.
3781         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js.
3782         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js.
3783         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js.
3784         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js.
3785         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js.
3786         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/bugzilla_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js.
3787         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js.
3788         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js.
3789         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js.
3790         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js.
3791         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js.
3792         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.
3793         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js.
3794         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js.
3795         ():
3796         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js.
3797         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js.
3798         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js.
3799         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js.
3800         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js.
3801         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js.
3802         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/trac_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js.
3803         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js.
3804         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js.
3805         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js.
3806         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js.
3807         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js.
3808         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/TestFailures.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css.
3809         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/main.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css.
3810         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
3811         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Removed.
3812         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js: Removed.
3813         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js: Removed.
3814         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Removed.
3815         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js: Removed.
3816         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html:
3817         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js: Removed.
3818
3819 2011-08-17  Jochen Eisinger  <jochen@chromium.org>
3820
3821         Make SVNTest.test_svn_apply use the same timezone logic as VCSUtils.pm
3822         https://bugs.webkit.org/show_bug.cgi?id=65877
3823
3824         Reviewed by Eric Seidel.
3825
3826         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3827
3828 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
3829
3830         Remove base.keys and replace it with Object.keys.
3831         https://bugs.webkit.org/show_bug.cgi?id=66422
3832
3833         Reviewed by Adam Barth.
3834
3835         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed base.keys.
3836         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed unit tests for it.
3837         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Replaced with Object.keys
3838
3839 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
3840
3841         garden-o-matic Summary view should have items in descending chronological order.
3842         https://bugs.webkit.org/show_bug.cgi?id=66403
3843
3844         Reviewed by Adam Barth.
3845
3846         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Renamed "push" to "add" for clarity, cleaned up some stuff.
3847         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Rewrote add to insert DOM elements in order.
3848         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added unit tests.
3849
3850 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
3851
3852         Fix a few errors in garden-o-matic frontend unit tests.
3853         https://bugs.webkit.org/show_bug.cgi?id=66421
3854
3855         Reviewed by Adam Barth.
3856
3857         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Changed my excellent test to view time as variable continuum.
3858         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Tweaked the test to accommodate new builder names.
3859         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Hurriedly covered up my prior sins.
3860
3861 2011-08-17  Adam Barth  <abarth@webkit.org>
3862
3863         Update Tools to account for (CG) being added to Chromium builder names
3864         https://bugs.webkit.org/show_bug.cgi?id=66410
3865
3866         Reviewed by Adam Barth.
3867
3868         Some of these names will change back once we turn on Skia bots.
3869
3870         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js:
3871         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
3872         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
3873         * Scripts/webkitpy/layout_tests/port/builders.py:
3874         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3875         * TestResultServer/static-dashboards/builders.js:
3876         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3877
3878 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
3879
3880         Wire up relative time to garden-o-matic summary view.
3881         https://bugs.webkit.org/show_bug.cgi?id=66343
3882
3883         Reviewed by Adam Barth.
3884
3885         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Add time to the commitData object. 
3886         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Adjusted unit tests.
3887         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up relative date.
3888         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated unit tests.
3889         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Adjusted unit tests.
3890
3891 2011-08-17  Adam Roben  <aroben@apple.com>
3892
3893         Make run-api-tests run tests in alphabetical order
3894
3895         Fixes <http://webkit.org/b/66401> run-api-tests runs tests in a semi-random order
3896
3897         Reviewed by David Kilzer.
3898
3899         * Scripts/run-api-tests:
3900         (runAllTests):
3901         (runAllTestsInSuite):
3902         Sort the lists of tests and suites before iterating over them.
3903
3904 2011-08-17  Adam Barth  <abarth@webkit.org>
3905
3906         garden-o-matic should be able to rebaseline expected failures
3907         https://bugs.webkit.org/show_bug.cgi?id=66204
3908
3909         Reviewed by Dimitri Glazkov.
3910
3911         This patch introduces a new view for displaying expect, actual, and
3912         differences between results.  The new view also has a fledgling
3913         controller that handles some basic operations.  The new view is
3914         exercised by rebaseline.html, which lets you rebaselines expected
3915         failures, but the new view is not fully integrated into
3916         garden-o-matic.html
3917
3918         More patches will be required to make this stuff fully working, but
3919         this patch was already somewhat spiraling out of control.  Hopefully
3920         this patch will serve as a good starting point for further development.
3921
3922         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Added.
3923         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Added.
3924         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Added.
3925         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3926         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
3927         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
3928         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html: Added.
3929         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
3930         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
3931         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
3932         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js:
3933         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Added.
3934
3935 2011-08-16  Chang Shu  <cshu@webkit.org>
3936
3937         Support reset in WebCore::Internals
3938         https://bugs.webkit.org/show_bug.cgi?id=66307
3939
3940         Reviewed by Dimitri Glazkov.
3941
3942         Added call to resetInternalsObject in DRT.
3943
3944         * DumpRenderTree/chromium/TestShell.cpp:
3945         (TestShell::resetTestController):
3946         * DumpRenderTree/mac/DumpRenderTree.mm:
3947         (resetWebViewToConsistentStateBeforeTesting):
3948         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3949         (WebCore::WebPage::resetSettings):
3950
3951 2011-08-17  Alexis Menard  <alexis.menard@openbossa.org>
3952
3953         Add a new build slave for the Qt port on Mac OS SnowLeopard.
3954         https://bugs.webkit.org/show_bug.cgi?id=66392
3955
3956         Modify the config file to include the new build slave.
3957
3958         Reviewed by Adam Roben.
3959
3960         * BuildSlaveSupport/build.webkit.org-config/config.json:
3961
3962 2011-08-17  Sam White  <samuel.white@rochester.edu>
3963
3964         AccessibilityObject levels are inconsistent
3965         https://bugs.webkit.org/show_bug.cgi?id=66180
3966         
3967         Added the ability to get numeric attribute values using numberAttributeValue. This
3968         function complements the existing stringAttributeValue and boolAttributeValue functions.
3969         The addition of numberAttributeValue was necessary because the stringAttributeValue
3970         function does a type check and will only return strings. This limitation made it
3971         impossible to get values for attributes that returned an NSNumber.
3972
3973         Reviewed by Chris Fleizach.
3974
3975         * DumpRenderTree/AccessibilityUIElement.cpp:
3976         (numberAttributeValueCallback):
3977         (AccessibilityUIElement::getJSClass):
3978         * DumpRenderTree/AccessibilityUIElement.h:
3979         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3980         (AccessibilityUIElement::numberAttributeValue):
3981         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3982         (AccessibilityUIElement::numberAttributeValue):
3983         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3984         (AccessibilityUIElement::numberAttributeValue):
3985
3986 2011-08-17  Adam Roben  <aroben@apple.com>
3987
3988         Tell Trac logs always to display all specified revisions in a single page
3989
3990         Trac imposes a default limit of 100 revisions per log page. We need to tell it to allow more
3991         revisions than that.
3992
3993         Fixes <http://webkit.org/b/66373> Links to Trac from TestFailures page don't always show all
3994         relevant revisions
3995
3996         Reviewed by Daniel Bates.
3997
3998         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
3999         (trac.logURL): Add a limit parameter to the log URL that allows all revisions to be seen in
4000         a single page.
4001
4002         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
4003         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js:
4004         Updated tests for the above.
4005
4006 2011-08-17  Adam Roben  <aroben@apple.com>
4007
4008         Fix TestFailures's link to file a bug about TestFailures itself
4009
4010         Fixes <http://webkit.org/b/66387> REGRESSION (r92135): TestFailures page's link to file a
4011         bug about itself is broken
4012
4013         Reviewed by Dan Bates.
4014
4015         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
4016         (ViewController.prototype._domForAuxiliaryUIElements): Added a path separator to separate
4017         the host from the path.
4018
4019 2011-08-17  Adam Roben  <aroben@apple.com>
4020
4021         Teach TestFailures to ignore unbelievably short test runs
4022
4023         Fixes <http://webkit.org/b/66385> TestFailures page thinks all tests passed in
4024         http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14956
4025
4026         Reviewed by Dan Bates.
4027
4028         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
4029         (Builder.prototype.getNumberOfFailingTests): If it looks like all tests passed, but
4030         run-webkit-tests took less than 10 seconds to run, assume that some weird error occurred
4031         that caused it not to run any tests at all (as happened for a while due to
4032         <http://webkit.org/b/64988>). Bumped the cache version to evict old, buggy cached data.
4033
4034         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
4035         Test for the above.
4036
4037         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
4038         (LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy cached data.
4039
4040 2011-08-16  Adam Barth  <abarth@webkit.org>
4041
4042         Add a CG qualifier similar to the GPU qualifier
4043         https://bugs.webkit.org/show_bug.cgi?id=66359
4044
4045         Reviewed by Eric Seidel.
4046
4047         Once we have a Skia configuration on Chromium Mac, we'll use this CG
4048         qualifier to note that expectations apply only to the CG configuration.
4049
4050         * Scripts/webkitpy/layout_tests/port/chromium.py:
4051         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
4052
4053 2011-08-16  Eric Seidel  <eric@webkit.org>
4054
4055         REGRESSION(92717): WinPort needs to parse version information from port_name
4056         https://bugs.webkit.org/show_bug.cgi?id=66325
4057
4058         Unreviewed.  Fixing an exception/typo seen on the bots (and testing to make sure it works).
4059
4060         * Scripts/webkitpy/layout_tests/port/mac.py:
4061         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
4062
4063 2011-08-16  Adam Barth  <abarth@webkit.org>
4064
4065         Change webkit-patch analyze-baselines to print in a more unix-friendly way
4066         https://bugs.webkit.org/show_bug.cgi?id=66349
4067
4068         Reviewed by James Robinson.
4069
4070         As requested by jamesr.
4071
4072         * Scripts/webkitpy/tool/commands/rebaseline.py:
4073
4074 2011-08-16  Eric Seidel  <eric@webkit.org>
4075
4076         REGRESSION(92717): WinPort needs to parse version information from port_name
4077         https://bugs.webkit.org/show_bug.cgi?id=66325
4078
4079         Reviewed by Adam Barth.
4080
4081         WinPort didn't have any port_name parsing logic.
4082         Seemed it was best to just share the logic from MacPort.
4083         Sharing the logic from MacPort seemed easiest with a shared superclass.
4084         Once I created ApplePort (the superclass) there was a bunch of logic to share.
4085         I found LeakDetector was just in the way when switching back and forth
4086         between win.py and mac.py so I moved it into its own file.
4087
4088         The only logic change here is that WinPort should now be
4089         able to parse port_name values like MacPort (and other ports)
4090         can.  The fact that ports do this in their constructors is
4091         wrong and a source of many bugs.  But at least now WinPort
4092         matches the status-quo.
4093
4094         * Scripts/webkitpy/layout_tests/port/apple.py: Added.
4095         * Scripts/webkitpy/layout_tests/port/leakdetector.py: Added.
4096         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py: Added.
4097         * Scripts/webkitpy/layout_tests/port/mac.py:
4098         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
4099         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
4100         * Scripts/webkitpy/layout_tests/port/win.py:
4101         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
4102
4103 2011-08-16  Adam Barth  <abarth@webkit.org>
4104
4105         Add webkit-patch analyze-baselines, as requested by jamesr.
4106
4107         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
4108         * Scripts/webkitpy/tool/commands/rebaseline.py:
4109
4110 2011-08-16  Adam Barth  <abarth@webkit.org>
4111
4112         Fold bulk-optimize-baselines into optimize-baselines
4113         https://bugs.webkit.org/show_bug.cgi?id=66345
4114
4115         Reviewed by James Robinson.
4116
4117         bulk-optimize-baselines is now a superset of optimize-baselines, so
4118         they can be combined.
4119
4120         * Scripts/webkitpy/tool/commands/rebaseline.py:
4121
4122 2011-08-16  Adam Barth  <abarth@webkit.org>
4123
4124         Move chromium-mac to chromium-cg-mac to prepare for Skia switchover
4125         https://bugs.webkit.org/show_bug.cgi?id=66334
4126
4127         Reviewed by Tony Chang.
4128
4129         This patch moves us closer to switching the Chromium port from
4130         CoreGraphics to Skia.  This patch teaches our tools that the current
4131         Chromium Mac configuration is actually chromium-cg-mac, which makes
4132         room for a future chromium-mac configuration that uses Skia.
4133
4134         Shortly after this patch lands, I'll do a server-side move of the
4135         chromium-mac and chromium-mac-leopard directories to chromium-cg-mac
4136         and chromium-cg-mac-leopard.
4137
4138         * BuildSlaveSupport/build.webkit.org-config/config.json:
4139         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
4140         * Scripts/webkitpy/common/config/build.py:
4141         * Scripts/webkitpy/common/config/build_unittest.py:
4142         * Scripts/webkitpy/layout_tests/port/base.py:
4143         * Scripts/webkitpy/layout_tests/port/builders.py:
4144         * Scripts/webkitpy/layout_tests/port/chromium.py:
4145         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
4146         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
4147         * Scripts/webkitpy/layout_tests/port/dryrun.py:
4148         * Scripts/webkitpy/layout_tests/port/factory.py:
4149         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
4150         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
4151         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
4152         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
4153         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
4154         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
4155         * TestResultServer/static-dashboards/flakiness_dashboard.html:
4156
4157 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
4158
4159         garden-o-matic frontend needs a friendly relative time description method.
4160         https://bugs.webkit.org/show_bug.cgi?id=66324
4161
4162         Reviewed by Adam Barth.
4163
4164         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added base.relativizeTime method.
4165         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added unit tests.
4166         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up Time widget to use it.
4167
4168 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
4169
4170         Summary view should not add multiple entries for the same test failure.
4171         https://bugs.webkit.org/show_bug.cgi?id=66318
4172
4173         Reviewed by Adam Barth.
4174
4175         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added a simplistic updating button.
4176         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added ways to check for
4177             equality of ui.notifications.FailingTest, and whether ui.notifications.TestFailures already contains a given failure analysis.
4178         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
4179
4180 2011-08-16  Adam Roben  <aroben@apple.com>
4181
4182         Teach TestFailures that tests that have failed or passed many times in a row are not flaky
4183
4184         The basic strategy here is that once a test has failed or passed many times in a row we
4185         never again consider it as a possibly flaky test. It's a simple strategy but seems to result
4186         in many fewer false positives than our current behavior.
4187
4188         Fixes <http://webkit.org/b/66327> TestFailures page considers far too many tests to be
4189         flaky, including tests that failed for a while but then were fixed
4190
4191         Reviewed by Dan Bates.
4192
4193         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:
4194         (FlakyLayoutTestDetector): Initialize new _buildCount property, which is used to track the
4195         number of non-too-many-failure builds we've seen.
4196         (FlakyLayoutTestDetector.prototype.incorporateTestResults): Don't track tests which haven't
4197         failed in the _maximumFailOrPassCount most recent builds. For other not-yet-considered-flaky
4198         tests, keep track of how many times they have passed or failed in a row. If they pass or
4199         fail more than _maximumFailOrPassCount times, consider them to be non-flaky. (Once a test is
4200         considered flaky it doesn't matter how many times it passes or fails.)
4201
4202         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js:
4203         Added tests for the above.
4204
4205 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
4206
4207         garden-o-matic needs a summary view with actions for each problem.
4208         https://bugs.webkit.org/show_bug.cgi?id=66144
4209
4210         Reviewed by Adam Barth.
4211
4212         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added notifications tests.
4213         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added.
4214         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added.
4215         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added.
4216         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Added.
4217         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added.
4218
4219 2011-08-16  Dean Jackson  <dino@apple.com>
4220
4221         Adding Ted "hober" O'Connor as a non-committing contributor.
4222
4223         * Scripts/webkitpy/common/config/committers.py:
4224
4225 2011-08-16  Adam Roben  <aroben@apple.com>
4226
4227         Teach TestFailures how to interpret unfinished test runs
4228
4229         Fixes <http://webkit.org/b/66309> TestFailures thinks all tests passed in
4230         http://build.webkit.org/builders/Lion%20Intel%20Debug%20(Tests)/builds/136
4231
4232         Reviewed by David Kilzer.
4233
4234         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
4235         (Builder.prototype.getNumberOfFailingTests): Look for "isFinished" in the layout-test step
4236         rather than "isStarted" so that we don't count builds for which the test run never finished.
4237         Bumped the ca