fde6576e6ae60ab96a275786891eeb057f55913f
[WebKit-https.git] / Tools / ChangeLog
1 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2
3         Unreviewed, rolling out r190399.
4
5         Tests are still failing even after r190362
6
7         Reverted changeset:
8
9         "Unreviewed. Unskip GTK+ user media unit tests after r190362."
10         http://trac.webkit.org/changeset/190399
11
12 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
13
14         [jhbuild] switch to new upstream usrsctp library
15         https://bugs.webkit.org/show_bug.cgi?id=149494
16
17         Reviewed by Philippe Normand.
18
19         * efl/jhbuild.modules:
20         * gtk/jhbuild.modules:
21
22 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
23
24         Unreviewed. Unskip GTK+ user media unit tests after r190362.
25
26         They should pass now.
27
28         * Scripts/run-gtk-tests:
29         (TestRunner):
30
31 2015-09-30  Daniel Bates  <dabates@apple.com>
32
33         Another attempt to fix the build after <https://trac.webkit.org/changeset/190387>
34         (https://bugs.webkit.org/show_bug.cgi?id=149695)
35
36         * BuildSlaveSupport/built-product-archive:
37         (determineWebKitBuildDirectories): Substitute _configurationBuildDirectory for _buildDirectory.
38         (extractBuiltProduct): Substitute _topLevelBuildDirectory for _buildDirectory.
39
40 2015-09-30  Daniel Bates  <dabates@apple.com>
41
42         Attempt to fix the build after <https://trac.webkit.org/changeset/190387>
43         (https://bugs.webkit.org/show_bug.cgi?id=149695)
44
45         Actually, we need to pass --configuration to script webkit-build-directory to have
46         it return the path to the configuration-specific build directory.
47
48         * BuildSlaveSupport/built-product-archive:
49         (determineWebKitBuildDirectories):
50
51 2015-09-30  Daniel Bates  <dabates@apple.com>
52
53         built-product-archive archives incorrect build directory for iOS port
54         https://bugs.webkit.org/show_bug.cgi?id=149695
55
56         Reviewed by Darin Adler.
57
58         Fixes an issue where the script built-product-archive archives a non-existent
59         build directory for the iOS port. Without loss of generality, the script assumes
60         the path to the Release configuration build for iOS is in directory WebKitBuild/Release.
61         But the built products for this configuration are in directory WebKitBuild/Release-iphonesimulator.
62
63         Currently the script built-product-archive calls `webkit-build-directory --top-level ...`
64         to determine the top-level build directory and computes the configuration-specific
65         build directory to be the concatenation of the the top-level build directory and
66         the configuration (e.g. Release). This is incorrect. Instead we should call
67         webkit-build-directory omitting the flag --top-level to compute the path to the
68         configuration-specific build directory.
69
70         * BuildSlaveSupport/built-product-archive: Fix up the style such that we use single quoted literals.
71         (main): Renamed global variable _buildDirectory to _topLevelBuildDirectory to better describe
72         its purpose and added global variable _configurationBuildDirectory to store the path
73         to the configuration-specific build directory. Ensure that we have a non-empty string
74         for both the top-level and configuration-specific build directories.
75         (determineWebKitBuildDirectories): Formerly named determineWebKitBuildDirectory.
76         Compute the configuration-specific build directory and store it in the global variable
77         _configurationBuildDirectory.
78         (archiveBuiltProduct): Modified to use _configurationBuildDirectory.
79         (extractBuiltProduct): Modified to use _configurationBuildDirectory and _topLevelBuildDirectory
80         as needed.
81         (determineWebKitBuildDirectory): Deleted.
82
83 2015-09-30  Hunseop Jeong  <hs85.jeong@samsung.com>
84
85         [EFL] css3/device-adapt/* tests failed after r190335.
86         https://bugs.webkit.org/show_bug.cgi?id=149655
87
88         Reviewed by Simon Fraser.
89
90         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
91         overwritten by updatePlatformSpecificViewOptionsForTest after r190335.
92
93         * WebKitTestRunner/efl/TestControllerEfl.cpp:
94         (WTR::shouldUseFixedLayout):
95
96 2015-09-30  Dewei Zhu  <dewei_zhu@apple.com>
97
98         Extend JetStream timeout for slow devices.
99
100         Reviewed by Chris Dumez.
101
102         Extend JetStream timeout to 20 minutes.
103
104         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
105
106 2015-09-30  Daniel Bates  <dabates@apple.com>
107
108         Rename iOS builders/testers to include version
109         https://bugs.webkit.org/show_bug.cgi?id=149685
110
111         Reviewed by Simon Fraser.
112
113         Substitute "Apple iOS 9" for "Apple iOS" in the names of iOS builders/testers so as
114         make it clear to a reader the version of iOS these builders/testers are using.
115
116         * BuildSlaveSupport/build.webkit.org-config/config.json:
117         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
118
119 2015-09-30  Daniel Bates  <dabates@apple.com>
120
121         Add iOS criterion for triggering a build
122         https://bugs.webkit.org/show_bug.cgi?id=149679
123
124         Rubber-stamped by Alexey Proskuryakov.
125
126         First pass at defining criterion for triggering an iOS build.
127
128         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
129         (_should_file_trigger_build):
130         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
131         (ShouldBuildTest):
132         (ShouldBuildTest.test_should_build):
133
134 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
135
136         [iOS] Allow tests to generate user gestures for UI testing
137         https://bugs.webkit.org/show_bug.cgi?id=149653
138
139         Reviewed by Tim Horton.
140
141         Expose functionality in UIScriptController to allow for testing single- and double-tap,
142         and to listen for completion of scrolling and zooming in the WKWebView.
143         
144         Tap generation is done using synthetic IOHIDEvents, via a new HIDEventGenerator class
145         which hides the complexity of creating these events. Event dispatch is asynchronous.
146         We detect when the last event has been handled by dispatching a vendor-specific event,
147         which is detected via -_handleHIDEvent: in our UIApplication subclass.
148         
149         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Link with IOKit.
150         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Two new properties
151         for 'will begin zooming' and 'did end zooming' callbacks, and functions to dispatch
152         single and double taps.
153         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
154         (UIScriptContext::registerCallback): Used to store the callbacks for zooming.
155         Unlike the "task" callbacks, these are persistent, but we store them in the same hash map.
156         (UIScriptContext::unregisterCallback):
157         (UIScriptContext::callbackWithID):
158         (UIScriptContext::fireCallback):
159         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
160         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
161         (WTR::UIScriptController::setWillBeginZoomingCallback): Cross-platform code.
162         (WTR::UIScriptController::willBeginZoomingCallback): Ditto.
163         (WTR::UIScriptController::setDidEndZoomingCallback):
164         (WTR::UIScriptController::didEndZoomingCallback):
165         (WTR::UIScriptController::singleTapAtPoint): Non-iOS stub.
166         (WTR::UIScriptController::doubleTapAtPoint): Ditto.
167         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
168         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
169         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
170         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
171         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Properties for the zooming callbacks.
172         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
173         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]): Dispatch the zooming callback.
174         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]): Ditto.
175         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]): Ditto.
176         (-[TestRunnerWKWebView onDidEndZooming:]): Deleted.
177         * WebKitTestRunner/ios/HIDEventGenerator.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
178         * WebKitTestRunner/ios/HIDEventGenerator.m: Added.
179         (simpleDragCurve):
180         (calculateNextLocation):
181         (delayBetweenMove):
182         (+[HIDEventGenerator sharedHIDEventGenerator]):
183         (+[HIDEventGenerator nextEventCallbackID]):
184         (-[HIDEventGenerator init]):
185         (-[HIDEventGenerator _createIOHIDEventType:]):
186         (-[HIDEventGenerator _sendHIDEvent:]):
187         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
188         (-[HIDEventGenerator _updateTouchPoints:count:]):
189         (-[HIDEventGenerator touchDownAtPoints:touchCount:]):
190         (-[HIDEventGenerator touchDown:touchCount:]):
191         (-[HIDEventGenerator touchDown:]):
192         (-[HIDEventGenerator liftUpAtPoints:touchCount:]):
193         (-[HIDEventGenerator liftUp:touchCount:]):
194         (-[HIDEventGenerator liftUp:]):
195         (-[HIDEventGenerator moveToPoints:touchCount:duration:]):
196         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
197         (-[HIDEventGenerator tap:completionBlock:]):
198         (-[HIDEventGenerator doubleTap:completionBlock:]):
199         (-[HIDEventGenerator twoFingerTap:completionBlock:]):
200         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
201         (-[HIDEventGenerator pinchCloseWithStartPoint:endPoint:duration:completionBlock:]):
202         (-[HIDEventGenerator pinchOpenWithStartPoint:endPoint:duration:completionBlock:]):
203         (-[HIDEventGenerator markerEventReceived:]):
204         * WebKitTestRunner/ios/IOKitSPI.h: Added.
205         * WebKitTestRunner/ios/UIKitSPI.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
206         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
207         (WTR::globalToContentCoordinates):
208         (WTR::UIScriptController::singleTapAtPoint):
209         (WTR::UIScriptController::doubleTapAtPoint):
210         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
211         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
212         * WebKitTestRunner/ios/mainIOS.mm:
213         (-[WebKitTestRunnerApp _handleHIDEvent:]):
214
215 2015-09-30  Dana Burkart  <dburkart@apple.com>
216
217         git-add-reviewer should trim trailing spaces/newlines
218         https://bugs.webkit.org/show_bug.cgi?id=149513
219
220         Reviewed by Darin Adler.
221
222         * Scripts/git-add-reviewer:
223         (nonInteractive):
224
225 2015-09-30  Eric Carlson  <eric.carlson@apple.com>
226
227         REGRESSION(r190262): User media unit test failures after r190262
228         https://bugs.webkit.org/show_bug.cgi?id=149580
229
230         Reviewed by Darin Adler.
231
232         * WebKitTestRunner/TestController.cpp:
233         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Fix parameter
234           order to WKUserMediaPermissionRequestAllow.
235
236 2015-09-30  Daniel Bates  <dabates@apple.com>
237
238         Add iOS builders and testers
239         https://bugs.webkit.org/show_bug.cgi?id=149549
240
241         Reviewed by Alexey Proskuryakov.
242
243         Adds definitions for 64-bit iOS Simulator release builders and testers and a iOS device
244         builder that builds universal release binaries for armv7, armv7s and arm64 architectures.
245
246         * BuildSlaveSupport/build.webkit.org-config/config.json: Add definitions for builders and testers.
247         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Update unit tests.
248
249 2015-09-30  Timothy Hatcher  <timothy@apple.com>
250
251         Give WebKitLauncher the get-task-allow entitlement to allow it to work on El Capitan
252         https://bugs.webkit.org/show_bug.cgi?id=149674
253
254         Reviewed by Lucas Forschler.
255
256         * WebKitLauncher/WebKitLauncher.entitlements: Added.
257         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
258
259 2015-09-30  Jason Marcell  <jmarcell@apple.com>
260
261         BuildbotQueueView.prototype._appendPendingRevisionCount should skip repositories that don't
262         have an associated trac instance.
263         https://bugs.webkit.org/show_bug.cgi?id=149673
264
265         Reviewed by Alexey Proskuryakov.
266
267         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
268         (BuildbotQueueView.prototype._appendPendingRevisionCount): Skip repositories that don't
269         have an associated trac instance.
270
271 2015-09-30  Daniel Bates  <dabates@apple.com>
272
273         Prioritize testing latest build request on iOS test bots
274         https://bugs.webkit.org/show_bug.cgi?id=149669
275
276         Reviewed by Darin Adler.
277
278         We should prioritize testing of the latest build request on the iOS test bots
279         as we do for Mac and Windows test bots.
280
281         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
282         (loadBuilderConfig):
283
284 2015-09-30  Daniel Bates  <dabates@apple.com>
285
286         Add buildbot category for iOS builders and testers
287         https://bugs.webkit.org/show_bug.cgi?id=149667
288
289         Reviewed by Darin Adler.
290
291         Group iOS builders and testers under category iOS and add dashboard and console hyperlinks
292         for iOS to the build.webkit.org home page.
293
294         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
295         (loadBuilderConfig):
296         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
297
298 2015-09-30  Daniel Bates  <dabates@apple.com>
299
300         Actually fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
301         (https://bugs.webkit.org/show_bug.cgi?id=149539)
302
303         I inadvertently didn't remove the ONLY_ACTIVE_ARCH=NO flag when building on a Mac
304         in <http://trac.webkit.org/changeset/190351>.
305
306         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
307         (CompileWebKit.start):
308
309 2015-09-30  Daniel Bates  <dabates@apple.com>
310
311         Attempt to fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
312         (https://bugs.webkit.org/show_bug.cgi?id=149539)
313
314         {32, 64}-bit Mac builders should not try to build project {Plugin.64, Plugin.32},
315         respectively; only pass ONLY_ACTIVE_ARCH=NO when building for iOS.
316
317         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
318         (CompileWebKit.start):
319
320 2015-09-30  Lucas Forschler  <lforschler@apple.com>
321
322         bot210 was configured for a queue instead of bot126.
323         
324         Unreviewed config.json fix.
325         
326         * BuildSlaveSupport/build.webkit.org-config/config.json:
327
328 2015-09-30  Lucas Forschler  <lforschler@apple.com>
329
330         Bring El Capitan buildbot infrastructure online.
331         https://bugs.webkit.org/show_bug.cgi?id=149605
332         
333         Reviewed by Darin Adler.
334
335         * BuildSlaveSupport/build.webkit.org-config/config.json:
336
337 2015-09-30  Tomas Popela  <tpopela@redhat.com>
338
339         [GTK] Deprecation warnings in DOMNodeTest
340         https://bugs.webkit.org/show_bug.cgi?id=149663
341
342         After the webkit_dom_document_get_elements_by_tag_name deprecation we
343         need to update the tests to use webkit_dom_document_query_selector_all
344         to avoid compilation warnings.
345
346         Also add a new test for webkit_dom_document_get_elements_by_tag_name_as_html_collection
347         (the suggested replacement for the deprecated function).
348
349         Reviewed by Carlos Garcia Campos.
350
351         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
352         (WebKitDOMNodeTest::testTagNamesNodeList):
353         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
354         (registerTests):
355         (WebKitDOMNodeTest::testTagNames): Deleted.
356         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
357         (prepareDOMForTagNamesTests):
358         (testWebKitDOMNodeTagNamesNodeList):
359         (testWebKitDOMNodeTagNamesHTMLCollection):
360         (beforeAll):
361         (testWebKitDOMNodeTagNames): Deleted.
362
363 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
364
365         WebKitTestRunner fails to apply "useFlexibleViewport" when it's specified in a file comment
366         https://bugs.webkit.org/show_bug.cgi?id=149650
367
368         Reviewed by Tim Horton.
369         
370         TestInvocation::invoke() consulted shouldMakeViewportFlexible(), but that only
371         looks at the file path, and not the custom options that come from file comments.
372         
373         Fix by computing TestOptions before making the TestInvocation, and setting them
374         as const TestInvocation data. This meant changing various call sites to take
375         the std::string pathOrURL, rather than the TestInvocation itself.
376         
377         Also initialize TestInvocation with a WKURLRef, rather than a std::string.
378
379         * WebKitTestRunner/CMakeLists.txt:
380         * WebKitTestRunner/TestController.cpp:
381         (WTR::TestController::ensureViewSupportsOptionsForTest):
382         (WTR::testPath):
383         (WTR::createTestURL):
384         (WTR::updateTestOptionsFromTestHeader):
385         (WTR::TestController::testOptionsForTest):
386         (WTR::TestController::updateWebViewSizeForTest):
387         (WTR::TestController::updateWindowScaleForTest):
388         (WTR::TestController::runTest):
389         * WebKitTestRunner/TestController.h:
390         * WebKitTestRunner/TestInvocation.cpp:
391         (WTR::TestInvocation::TestInvocation):
392         (WTR::TestInvocation::invoke):
393         (WTR::createWKURL): Deleted.
394         (WTR::TestInvocation::shouldMakeViewportFlexible): Deleted.
395         (WTR::TestInvocation::shouldUseFixedLayout): Deleted.
396         * WebKitTestRunner/TestInvocation.h:
397         (WTR::TestInvocation::options):
398         * WebKitTestRunner/TestOptions.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
399         (WTR::pathContains):
400         (WTR::shouldMakeViewportFlexible):
401         (WTR::shouldUseFixedLayout):
402         (WTR::isSVGTestPath):
403         (WTR::isHiDPITestPath):
404         (WTR::TestOptions::TestOptions):
405         * WebKitTestRunner/TestOptions.h:
406         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
407         * WebKitTestRunner/efl/TestControllerEfl.cpp:
408         (WTR::pathContains):
409         (WTR::shouldUseFixedLayout):
410         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
411         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
412         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
413         * WebKitTestRunner/ios/TestControllerIOS.mm:
414         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
415         * WebKitTestRunner/mac/TestControllerMac.mm:
416         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
417
418 2015-09-29  Aakash Jain  <aakash_jain@apple.com>
419
420         Flakiness dashboard should support OS X El Capitan
421         https://bugs.webkit.org/show_bug.cgi?id=149648
422
423         Reviewed by Alexey Proskuryakov.
424
425         * QueueStatusServer/app.yaml: We do not need to maintain SVN revision here because of 
426         difference between new appscale and old Google App Engine implementation.
427         * TestResultServer/app.yaml: Same.
428         * TestResultServer/static-dashboards/builders.jsonp: Added OSX El Capitan support.
429
430 2015-09-29  Daniel Bates  <dabates@apple.com>
431
432         configure-xcode-for-ios-development does not work with Xcode 7
433         https://bugs.webkit.org/show_bug.cgi?id=149640
434
435         Reviewed by Alexey Proskuryakov.
436
437         When Xcode 7 is installed, running configure-xcode-for-ios-development dies with an error
438         because it cannot find the Xcode specification files for iOS simulator and device. These
439         files have moved to a new location in Xcode 7 distribution. Moreover we must add the
440         relevant definitions to the Xcode 7 specification files directly as opposed to creating
441         new specification files with the added definitions (as we did in older versions of Xcode)
442         in order for Xcode 7 to honor these definitions.
443
444         * Scripts/configure-xcode-for-ios-development: Sorted forward declarations.
445         (updateXcodeSpecificationFilesForSDKIfNeeded): Added.
446         (updateXcode7SpecificationFile): Added.
447         (createLegacyXcodeSpecificationFilesForSDKIfNeeded): Formerly named createXcodeSpecificationFilesForSDKIfNeeded.
448         (writeXcodeSpecification): Moved congratulations line to caller so as to write out the
449         appropriate success message.
450         (mergeXcodeSpecificationWithSpecificationAndId): Formerly named createXcodeSpecificationFromSpecificationAndId.
451         (createXcodeSpecificationFilesForSDKIfNeeded): Deleted.
452         (createXcodeSpecificationFromSpecificationAndId): Deleted.
453
454 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
455
456         [Win] Allow 'prepare-ChangeLog' to be used without Cygwin
457         https://bugs.webkit.org/show_bug.cgi?id=149639
458
459         Reviewed by Alex Christensen.
460
461         * Scripts/VCSUtils.pm:
462         (exitStatus): Use 'isWindows()' method.
463         (isSVNVersion16OrNewer): 'eval' is not needed here, and just causes
464         an error. This method could probably just go away.
465         (normalizePath): Leave Windows (or Unix) paths as platform paths, rather than
466         always changing to Unix style. 
467         (unixPath): Added. Needed so Windows can always show a Unix path in the
468         ChangeLog file.
469         (changeLogName): Work around the fact that 'getpwuid' is not available on
470         a pure Windows build of Perl.
471         * Scripts/prepare-ChangeLog:
472         (generateFunctionLists): Normalize path received from 'svn' in case it's a Unix
473         path on Windows.
474         (svnUpdateCommand): Added helper function. Needed because Windows Perl does not
475         support using arrays for 'open' arguments.
476         (resolveChangeLogsPath): Ditto.
477         (resolveConflictedChangeLogs): Use new helper functions.
478         (generateNewChangeLogs): Force Windows to use Unix paths in ChangeLog output.
479         (diffCommand): Use double-quotes for paths, since Windows doesn't understand single
480         quotes. Unix systems are happy either way.
481         (statusCommand): Ditto.
482         * Scripts/webkitdirs.pm:
483         (launcherName): Drive-by fix. WinLauncher was renamed to MiniBrowser some time ago.
484
485 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
486
487         [Win] Unreviewed 64-bit build fix after switch to CMake.
488
489         * Scripts/webkitdirs.pm:
490         (determineIsWin64FromArchitecture): Added.
491
492 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
493
494         printing does not use minimum page zoom factor
495         https://bugs.webkit.org/show_bug.cgi?id=108507
496
497         Reviewed by Darin Adler.
498
499         WebKitTestRunner always takes the snapshots from the UI process
500         (expect for IOS), so in the case of printing, the layout in the
501         web view is not the expected one. When printing, we need to take
502         the snapshot in the web process and ensure it's rendered with a
503         PrintContext.
504
505         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
506         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
507         kWKSnapshotOptionsPrinting option to
508         WKBundlePageCreateSnapshotWithOptions() when printing.
509
510 2015-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
511
512         [WTR] Pixel tests generate the snapshots twice in Web and UI processes
513         https://bugs.webkit.org/show_bug.cgi?id=149595
514
515         Reviewed by Tim Horton.
516
517         All ports except IOS implement
518         PlatformWebView::windowSnapshotImage() to generate the snapshot
519         for the pixel tests in the UI process. But we are still generating
520         a snapshot for pixel tests in the Web process too, that is passed
521         to the UI process but ignored.
522         Whether a pixel result is needed or not, is only known by the web
523         process depending on whether the test called dumpAsText with
524         dumpPixels == true or not. Since the pixels are now dump in the UI
525         process, we need to pass that information to the UI process when
526         the test is done. For that we set a PixelResultIsPending bool
527         parameter to the Done message, and we only add the PixelResult
528         when UI process doesn't need to generate the pixels dump.
529
530         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
531         (WTR::InjectedBundle::didReceiveMessageToPage): Set
532         m_pixelResultIsPending to false on reset.
533         (WTR::InjectedBundle::done): Add PixelResultIsPending parameter to the
534         Done message, and set the PixelResult if m_pixelResultIsPending is false.
535         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
536         (WTR::InjectedBundle::setPixelResult): Set m_pixelResultIsPending to false.
537         (WTR::InjectedBundle::setNeedsPixelResult): Set m_pixelResultIsPending.
538         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
539         (WTR::InjectedBundlePage::dump): Only create a snapshot for IOS
540         port.
541         * WebKitTestRunner/TestInvocation.cpp:
542         (WTR::TestInvocation::dumpResults): Use either the pixel result
543         from the web process or generate a pixel result from the web view
544         if need it.
545         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
546         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
547         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
548         is created by the caller now, but the CG implementation needs to
549         know if it's a Web or UI process snapshot.
550         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
551         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
552         cairo surface for the given image.
553         * WebKitTestRunner/cg/TestInvocationCG.cpp:
554         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
555         CGContext for the given image.
556
557 2015-09-28  Dean Johnson  <dean_johnson@apple.com>
558
559         Fix JS errors on dashboard metrics page
560         https://bugs.webkit.org/show_bug.cgi?id=149608
561
562         Reviewed by Alexey Proskuryakov.
563
564         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Updated to use Settings.
565         (initPlatformsByFamily): 
566         (updateHiddenPlatforms):
567         (parsePlatformFamily): Deleted.
568         (updateToggleButtons): Deleted.
569         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
570         (updateHiddenPlatforms): Added to remove errors.
571         (initPlatformsByFamily): Added to remove errors.
572         (unhiddenQueues): Updated to use Settings.
573         (documentReady): Added logic to add toggle buttons to the settings menu.
574         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
575         (Settings.prototype.parsePlatformFamily): Moved duplicate logic from Main.js and
576         MetricsMain.js to Settings.
577         (Settings.prototype.updateToggleButtons): Moved duplicate logic from Main.js and
578         MetricsMain.js to Settings.
579         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
580         (QueueView.prototype._updateHiddenState): Updated to use Settings.
581
582 2015-09-28  Aakash Jain  <aakash_jain@apple.com>
583
584         Appscale query fails because of missing index
585         https://bugs.webkit.org/show_bug.cgi?id=149609
586
587         Reviewed by Darin Adler.
588
589         * QueueStatusServer/index.yaml: Added the required index.
590
591 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
592
593         [Win] Fix the 64-bit build after switch to cmake.
594
595         Reviewed by Alex Christensen.
596
597         * Scripts/webkitdirs.pm:
598         (generateBuildSystemFromCMakeProject): Use correct arguments for cmake to
599         run a 64-bit build.
600
601 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
602
603         [Win] Allow Windows to run test-webkitpy without Cygwin
604         https://bugs.webkit.org/show_bug.cgi?id=149602
605
606         Reviewed by Alex Christensen.
607
608         These changes mostly shift from hard-coded paths using UNIX-style
609         separators to Python's "os.path.join" syntax that uses the correct
610         path separator for each platform.
611         
612         * Scripts/webkitpy/common/system/path.py:
613         (cygpath): Don't pass paths through Cygpath on native Windows.
614         * Scripts/webkitpy/port/win.py:
615         (WinPort._path_to_apache): Use os.path.join.
616         (WinPort._ntsd_location): Support 64-bit environment (ProgramW6432 doesn't exist
617         in 64-bit environments).
618         * Scripts/webkitpy/style/checker.py: Use os.path.join.
619         * Scripts/webkitpy/style/checker_unittest.py:
620         (GlobalVariablesTest.test_path_rules_specifier.assertNoCheck): Use os.path.join.
621         (GlobalVariablesTest.test_path_rules_specifier): Ditto.
622         (GlobalVariablesTest): Ditto.
623         (GlobalVariablesTest.test_max_reports_per_category): Ditto.
624         (CheckerDispatcherSkipTest.test_should_skip_with_warning): Ditto.
625         (CheckerDispatcherDispatchTest.test_js_paths): Ditto.
626         (CheckerDispatcherDispatchTest.test_json_paths): Ditto.
627         (CheckerDispatcherDispatchTest.test_python_paths): Ditto.
628         (CheckerDispatcherDispatchTest.test_text_paths): Ditto.
629         (CheckerDispatcherDispatchTest.test_xml_paths): Ditto.
630         (StyleProcessor_CodeCoverageTest._create_carriage_checker_class): Ditto.
631         (StyleProcessor_CodeCoverageTest): Ditto.
632         (StyleProcessor_CodeCoverageTest.test_should_process__skip_without_warning): Ditto.
633         (StyleProcessor_CodeCoverageTest.test_should_process__skip_with_warning): Ditto.
634         (StyleProcessor_CodeCoverageTest.test_should_process__true_result): Ditto.
635         * Scripts/webkitpy/w3c/test_parser_unittest.py: Uses os.path.join rather than
636         manual string concatenation of paths.
637
638 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
639
640         Add bugzilla addresses of committers to contributors.json
641         https://bugs.webkit.org/show_bug.cgi?id=149520
642
643         Reviewed by Darin Adler.
644
645         * Scripts/webkitpy/common/config/contributors.json:
646
647 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
648
649         validate-committer-lists -b shouldn't need edituser privileges
650         https://bugs.webkit.org/show_bug.cgi?id=149519
651
652         Reviewed by Darin Adler.
653
654         * Scripts/validate-committer-lists:
655         (CommitterListBugzillaChecker._has_invalid_bugzilla_email):
656         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
657         (BugzillaQueries.is_invalid_bugzilla_email):
658         (BugzillaQueries): Deleted.
659         (BugzillaQueries.fetch_logins_matching_substring): Deleted.
660
661 2015-09-26  Carlos Garcia Campos  <cgarcia@igalia.com>
662
663         Unreviewed. Gardening: skip media stream tests failing after r190262.
664
665         * Scripts/run-gtk-tests:
666         (TestRunner):
667
668 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
669
670         [Mac] USE_INTERNAL_SDK is used undefined in tools projects
671         https://bugs.webkit.org/show_bug.cgi?id=149571
672
673         Reviewed by Dan Bernstein.
674
675         Use the same pattern as in Source directory configurations (so, also get rid of AspenFamily.xcconfig). 
676
677         * DumpRenderTree/mac/Configurations/Base.xcconfig:
678         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
679         * LayoutTestRelay/Configurations/Base.xcconfig:
680         * MiniBrowser/Configurations/Base.xcconfig:
681         * MiniBrowser/Configurations/DebugRelease.xcconfig:
682         * TestWebKitAPI/Configurations/Base.xcconfig:
683         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
684         * WebEditingTester/Configurations/Base.xcconfig:
685         * WebEditingTester/Configurations/DebugRelease.xcconfig:
686         * WebKitTestRunner/Configurations/Base.xcconfig:
687         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
688         * WebKitTestRunner/iOS.xcconfig: Removed.
689
690 2015-09-25  Eric Carlson  <eric.carlson@apple.com>
691
692         Clean up user media request internal API
693         https://bugs.webkit.org/show_bug.cgi?id=149527
694
695         Reviewed by Tim Horton.
696
697         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
698         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): Update for API changes.
699
700         * WebKitTestRunner/TestController.cpp:
701         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Ditto.
702
703 2015-09-25  Simon Fraser  <simon.fraser@apple.com>
704
705         [iOS WK2] Add viewport tests and fix runUIScript() timing issues
706         https://bugs.webkit.org/show_bug.cgi?id=149577
707
708         Reviewed by Tim Horton.
709         
710         When calling testRunner.runUIScript() from a page load event, the script could run
711         in the UI process before the current remote layer tree transaction had been handled
712         there. This meant that runUIScript() could query state which was about to change.
713         
714         Fix by delaying the execution of the UI script until a layer tree transaction has
715         been handled by the UI process, leveraging the existing DrawingAreaProxy::dispatchAfterEnsuringDrawing().
716
717         * WebKitTestRunner/TestInvocation.cpp:
718         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
719         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
720         * WebKitTestRunner/TestInvocation.h:
721
722 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
723
724         [Mac] Media tests start to time out after a few days of bot uptime
725         https://bugs.webkit.org/show_bug.cgi?id=149468
726
727         Reviewed by Darin Adler.
728
729         Delete cache directory in addition to the temporary one. Don't delete /private/tmp/MediaCache,
730         as it's not longer used by tests. Set TMPDIR and DIRHELPER_USER_DIR_SUFFIX to make
731         all temporary and cache files go to a custom location.
732
733         * Scripts/webkitpy/port/base.py:
734         * Scripts/webkitpy/port/driver.py:
735         * Scripts/webkitpy/port/mac.py:
736         * Scripts/webkitpy/port/win.py:
737         (WinPort._driver_tempdir_for_environment): Deleted unused function.
738
739 2015-09-25  Dan Bernstein  <mitz@apple.com>
740
741         Removed MiniBrowser.entitlements.
742
743         Rubber-stamped by Anders Carlsson.
744
745         The entitlements weren’t used anyway.
746
747         * MiniBrowser/MiniBrowser.entitlements: Removed.
748         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
749
750 2015-09-24  Daniel Bates  <dabates@apple.com>
751
752         Add WebKitSystemInterface for iOS 9.0
753         https://bugs.webkit.org/show_bug.cgi?id=149550
754
755         Rubber-stamped by Alexey Proskuryakov.
756
757         * Scripts/copy-webkitlibraries-to-product-directory:
758
759 2015-09-24  Daniel Bates  <dabates@apple.com>
760
761         Support building for arbitrary architectures
762         https://bugs.webkit.org/show_bug.cgi?id=149539
763
764         Reviewed by Alexey Proskuryakov.
765
766         Teach buildbot to pass the architectures associated with the builder to build-webkit
767         when building on OS X and iOS. As a side effect of this change we now support building
768         universal binaries when multiples architectures are specified.
769
770         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
771         (CompileWebKit.start):
772
773 2015-09-24  Daniel Bates  <dabates@apple.com>
774
775         Fix the build after <http://trac.webkit.org/changeset/190212>
776         (http://trac.webkit.org/changeset/190212)
777
778         I inadvertently did not remove the fullPlatform argument from one of the callers of archiveBuiltProduct().
779
780         * BuildSlaveSupport/built-product-archive:
781         (main):
782
783 2015-09-24  Daniel Bates  <dabates@apple.com>
784
785         Support running unit tests on iOS Simulator test bot
786         https://bugs.webkit.org/show_bug.cgi?id=149536
787
788         Reviewed by Alexey Proskuryakov.
789
790         Implements support for running unit tests on a iOS test bot. At the time of writing,
791         the script run-api-tests supports running unit tests on Mac, Windows and iOS Simulator.
792
793         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
794         (RunUnitTests.start): Append appropriate command line flag when invoking script run-api-tests.
795         (TestFactory.__init__): Add step RunUnitTests when the test bot is for the iOS Simulator platform.
796
797 2015-09-24  Daniel Bates  <dabates@apple.com>
798
799         Add support infrastructure for OpenSource iOS builders and testers
800         https://bugs.webkit.org/show_bug.cgi?id=149534
801
802         Reviewed by Darin Adler.
803
804         Towards setting up OpenSource iOS build bots, teach buildbot and its support
805         scripts about iOS.
806
807         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
808         (appendCustomBuildFlags): Require the caller to pass parameter fullPlatform and append
809         --ios-simulator or --device for a builder/tester whose full platform name begins with
810         "ios-simulator" or "ios", respectively.
811         (RunJavaScriptCoreTests.start): Pass the full platform name to appendCustomBuildFlags().
812         * BuildSlaveSupport/built-product-archive:
813         (main): Pass the full platform name to determineWebKitBuildDirectory().
814         (determineWebKitBuildDirectory): Call script webkit-build-directory with the appropriate
815         command line flag when building for iOS.
816         (archiveBuiltProduct): Use the same logic for iOS as we do for Mac. Also, remove unused
817         parameter fullPlatform. This parameter was originally added in r125066 to support the
818         Chromium Android port, which has since been removed from the OpenSource WebKit Project.
819         (extractBuiltProduct): Use the same logic for iOS as we do for Mac.
820         * BuildSlaveSupport/clean-build:
821         (main): Call script webkit-build-directory with the appropriate command line flag when
822         building for iOS.
823         * BuildSlaveSupport/delete-stale-build-files:
824         (main): Use the same logic for iOS as we do for Mac.
825         (webkitBuildDirectory): Call script webkit-build-directory with the appropriate command line
826         flag when building for iOS.
827         * BuildSlaveSupport/test-result-archive:
828         (archiveTestResults): Use the same logic for iOS as we do for Mac.
829
830 2015-09-24  Daniel Bates  <dabates@apple.com>
831
832         Remove Chromium-specific changes to script built-product-archive
833         https://bugs.webkit.org/show_bug.cgi?id=149530
834
835         Rubber-stamped by Csaba Osztrogonác.
836
837         Reverts changes made in r113074 and r113067 to support Chromium testers. The
838         Chromium code has long since been removed from the OpenSource WebKit Project.
839
840         * BuildSlaveSupport/built-product-archive:
841         (createZipManually):
842         (createZip):
843         (archiveBuiltProduct):
844
845 2015-09-24  Dan Bernstein  <mitz@apple.com>
846
847         Build fix.
848
849         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
850
851 2015-09-24  Mark Lam  <mark.lam@apple.com>
852
853         Unreviewed. Make Lucas Forschler a WebKit reviewer.
854
855         * Scripts/webkitpy/common/config/contributors.json:
856
857 2015-09-24  Carlos Garcia Campos  <cgarcia@igalia.com>
858
859         Unreviewed. Fix GObject DOM API breaks after r190120.
860
861         Bring back code removed in r169931 to handle documentation of
862         deleted classes.
863
864         * gtk/webkitdom.py:
865         (WebKitDOMDocGenerator):
866         (WebKitDOMDocGenerator.write_deleted_classes):
867         (WebKitDOMDocGenerator.generate):
868         (write_deleted_classes):
869         (WebKitDOMDocGeneratorSections._deleted_class):
870         (WebKitDOMDocGeneratorSections._deleted_class.in):
871         (WebKitDOMDocGeneratorSections.write_deleted_classes):
872         (WebKitDOMDocGeneratorSections.write_deleted_classes.with):
873
874 2015-09-23  Myles C. Maxfield  <mmaxfield@apple.com>
875
876         [Cocoa] [Font Features] Implement font-variant-*
877         https://bugs.webkit.org/show_bug.cgi?id=148413
878
879         Reviewed by Darin Adler.
880
881         Update test font to use "lnum" feature.
882
883         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
884         (Generator::appendGSUBTable):
885
886 2015-09-22  Andy Estes  <aestes@apple.com>
887
888         ContentFiltering.AllowDownloadAfterAddData is very flaky
889         https://bugs.webkit.org/show_bug.cgi?id=148885
890         <rdar://problem/22729563>
891
892         Reviewed by Alexey Proskuryakov.
893
894         The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:,
895         but there is no guarantee of this. For tests that should allow a download, spin the runloop until
896         -_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures.
897
898         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
899         (downloadTest):
900
901 2015-09-22  Alexey Proskuryakov  <ap@apple.com>
902
903         Mavericks: Media tests start to time out after a few days of bot uptime
904         https://bugs.webkit.org/show_bug.cgi?id=149468
905
906         Reviewed by Chris Dumez.
907
908         * Scripts/webkitpy/port/base.py:
909         * Scripts/webkitpy/port/driver.py:
910         * Scripts/webkitpy/port/mac.py:
911
912 2015-09-22  Nan Wang  <n_wang@apple.com>
913
914         Unreviewed, add myself to the committers list.
915
916         * Scripts/webkitpy/common/config/contributors.json:
917
918 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
919
920         Remove 'nullable' to fix older iOS builds.
921
922         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
923         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
924
925 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
926
927         [Win] Show tiled drawing debug overlay on Windows
928         https://bugs.webkit.org/show_bug.cgi?id=149426
929
930         Reviewed by Dean Jackson.
931
932         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Add new menu option.
933         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Ditto.
934         * MiniBrowser/win/Common.cpp:
935         (::ToggleMenuItem): Recognize new menu item and toggle the 'showTiledScrollingIndicator'
936         flag if needed.
937         * MiniBrowser/win/MiniBrowser.h: Update to use new IWebPreferencesPrivate3 class.
938
939 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
940
941         [Win] Use command-line argument to launch in regular or High DPI mode.
942         https://bugs.webkit.org/show_bug.cgi?id=149417
943
944         Reviewed by Dean Jackson.
945
946         * MiniBrowser/win/Common.cpp:
947         (parseCommandLine): Ignore the '--highDPI' argument. It's used at the
948         very start of execution, before the MiniBrowser.dll is loaded.
949         * win/DLLLauncher/DLLLauncherMain.cpp:
950         (shouldUseHighDPI): Check for '--highDPI', and use this mode if
951         present. On WinCairo, always use High DPI.
952
953 2015-09-21  Ryosuke Niwa  <rniwa@webkit.org>
954
955         32-bit Mac build fix attempt after r190065.
956
957         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
958
959 2015-09-21  Alexey Proskuryakov  <ap@apple.com>
960
961         [OS X] Update for Xcode 7.0 on Yosemite
962         https://bugs.webkit.org/show_bug.cgi?id=149389
963
964         Reviewed by Dan Bernstein.
965
966         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
967         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
968         Removed unneeded declarations - conforming to a protocol is sufficient.
969
970         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
971         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
972         Changed the definitions to be compiled whenever the SDK requires it (so we will have
973         dead code compiled in when building for 10.10 with 10.11 SDK, somewhat unfortunately).
974
975 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
976
977         Add the ability for tests to run script in the UI process in WebKitTestRunner
978         https://bugs.webkit.org/show_bug.cgi?id=149356
979
980         Reviewed by Tim Horton.
981
982         This change adds testRunner.runUIScript(script, callback), which allows a test
983         to execute script in a JSContext which runs in the UI process. That context
984         has bindings exposed through the UIScriptController interface; currently one test
985         function, and some iOS-specific functions are included. UIScriptController can be
986         async with a callback, and runUIScript() itself is asynchronous. When the UI 
987         script is complete, it calls uiController.uiScriptComplete(result), where 'result'
988         is a string passed back to the web process, and given to the runUIScript()
989         callback function.
990         
991         Thanks to Gyuyoung Kim for help with the Gtk/Efl build.
992
993         * WebKitTestRunner/DerivedSources.make: Build UIScriptController.idl.
994         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add runUIScript().
995         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
996         (WTR::InjectedBundle::didReceiveMessageToPage): When the UI-side script is
997         complete, call back into TestRunner.
998         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
999         (WTR::nextUIScriptCallbackID):
1000         (WTR::TestRunner::runUIScript): Post a message to the injected bundle to run the UI script.
1001         (WTR::TestRunner::runUIScriptCallback): When the UI script is done, execute its callback function.
1002         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1003         * WebKitTestRunner/PlatformWebView.h:
1004         * WebKitTestRunner/TestController.cpp:
1005         (WTR::updateTestOptionsFromTestHeader):
1006         (WTR::TestController::testOptionsForTest): Support "useFlexibleViewport" as a test argument.
1007         (WTR::shouldUseFixedLayout): Deleted. Moved to a TestInvocation function.
1008         * WebKitTestRunner/TestInvocation.cpp:
1009         (WTR::TestInvocation::shouldUseFixedLayout):
1010         (WTR::TestInvocation::shouldUseThreadedScrolling):
1011         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1012         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1013         (WTR::TestInvocation::runUISideScript): Run the UI-side script!
1014         (WTR::TestInvocation::uiScriptDidComplete): Send a message back to the injected bundle.
1015         * WebKitTestRunner/TestInvocation.h:
1016         * WebKitTestRunner/TestOptions.h:
1017         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1018         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1019         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
1020         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Added.
1021         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
1022         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
1023         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
1024         (-[TestRunnerWKWebView onDidEndZooming:]): Allow a test to hook into the end of zooming.
1025         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1026         (WTR::PlatformWebView::PlatformWebView): Make a TestRunnerWKWebView on iOS.
1027         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Added.
1028         (WTR::UIScriptController::doAsyncTask):
1029         (WTR::UIScriptController::zoomToScale):
1030         (WTR::UIScriptController::zoomScale):
1031         (WTR::UIScriptController::minimumZoomScale):
1032         (WTR::UIScriptController::maximumZoomScale):
1033         (WTR::UIScriptController::contentVisibleRect):
1034         * WebKitTestRunner/mac/EventSenderProxy.mm:
1035         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1036         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Deleted.
1037         * WebKitTestRunner/mac/TestControllerMac.mm:
1038         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1039         (WTR::shouldUseThreadedScrolling): Deleted. Moved to TestInvocation.
1040         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
1041         * WebKitTestRunner/uiscriptcontext/UIScriptContext.cpp: Added. Owns the JS context in the UI process.
1042         (UIScriptContext::UIScriptContext):
1043         (UIScriptContext::~UIScriptContext):
1044         (UIScriptContext::runUIScript): Entrypoint to running the UI script. If the script didn't do anything
1045         asynchronous, call the callback.
1046         (UIScriptContext::nextTaskCallbackID):
1047         (UIScriptContext::prepareForAsyncTask): Do setup for one async task (i.e. a UIScriptController function
1048         that has a callback). Has to store the callbackID of the script, so code called from the completion
1049         callback knows which UI script invoked it.
1050         (UIScriptContext::asyncTaskComplete): Called when one task is finished.
1051         (UIScriptContext::uiScriptComplete):
1052         (UIScriptContext::objectFromRect): Make a JS object from a rect.
1053         * WebKitTestRunner/uiscriptcontext/UIScriptContext.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
1054         (WTR::UIScriptContext::hasOutstandingAsyncTasks):
1055         * WebKitTestRunner/uiscriptcontext/UIScriptController.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
1056         (WTR::UIScriptController::UIScriptController):
1057         (WTR::UIScriptController::makeWindowObject):
1058         (WTR::UIScriptController::wrapperClass):
1059         (WTR::UIScriptController::doAsyncTask):
1060         (WTR::UIScriptController::zoomToScale):
1061         (WTR::UIScriptController::zoomScale):
1062         (WTR::UIScriptController::minimumZoomScale):
1063         (WTR::UIScriptController::maximumZoomScale):
1064         (WTR::UIScriptController::contentVisibleRect):
1065         (WTR::UIScriptController::uiScriptComplete):
1066         * WebKitTestRunner/uiscriptcontext/UIScriptController.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
1067         (WTR::UIScriptController::create):
1068         * WebKitTestRunner/uiscriptcontext/bindings/UIScriptController.idl: Copied from Tools/WebKitTestRunner/TestOptions.h.
1069
1070 2015-09-21  Tim Horton  <timothy_horton@apple.com>
1071
1072         Turn on threaded scrolling by default in the tests
1073         https://bugs.webkit.org/show_bug.cgi?id=149377
1074
1075         Reviewed by Simon Fraser.
1076
1077         * WebKitTestRunner/mac/TestControllerMac.mm:
1078         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1079         (WTR::shouldUseThreadedScrolling): Deleted.
1080         Turn on threaded scrolling by default.
1081
1082 2015-09-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1083
1084         [GTK] run-gtk-tests doesn't provide feedback about crashing google tests
1085         https://bugs.webkit.org/show_bug.cgi?id=149252
1086
1087         Reviewed by Darin Adler.
1088
1089         In case of glib tests the test runner notifies about tests
1090         crashing, but for google tests we don't get any feedback, which
1091         means that in case of a test crashing we get a list of **PASS**
1092         messages and at the summary we are notified that the test suite
1093         has failed, but it's impossible to know which test cases have failed.
1094
1095         * Scripts/run-gtk-tests:
1096         (TestRunner._run_google_test): Add a **CRASH** message if test
1097         case crashed.
1098
1099 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
1100
1101         WebKitTestRunner can leak user content script results between tests
1102         https://bugs.webkit.org/show_bug.cgi?id=149391
1103
1104         Reviewed by Sam Weinig.
1105
1106         Move WKBundlePageRemoveAllUserContent call so that it's executed before loading
1107         about:blank, and thus about:blank doesn't have unintended side effects.
1108
1109         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1110         (WTR::InjectedBundle::beginTesting):
1111         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1112         (WTR::InjectedBundlePage::resetAfterTest):
1113
1114 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
1115
1116         [Mac, iOS] AccessibilityController doesn't uninstall global notification handler
1117         https://bugs.webkit.org/show_bug.cgi?id=149384
1118
1119         Reviewed by Chris Fleizach.
1120
1121         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
1122         (AccessibilityController::addNotificationListener): Fixed a leak, and cleaned up the code.
1123         (AccessibilityController::platformResetToConsistentState): Actually remove the handler,
1124         regardless of whether someone else holds a reference (we also call -stopListening in
1125         -dealloc).
1126
1127         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1128         (AccessibilityController::platformResetToConsistentState):
1129         (AccessibilityController::addNotificationListener):
1130         Ditto.
1131
1132 2015-09-20  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1133
1134         Remove XHR_TIMEOUT compilation guard
1135         https://bugs.webkit.org/show_bug.cgi?id=149260
1136
1137         Reviewed by Benjamin Poulain.
1138
1139         * Scripts/webkitperl/FeatureList.pm:
1140
1141 2015-09-19  Dan Bernstein  <mitz@apple.com>
1142
1143         Attempted build fix.
1144
1145         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1146
1147 2015-09-18  Commit Queue  <commit-queue@webkit.org>
1148
1149         Unreviewed, rolling out r189908.
1150         https://bugs.webkit.org/show_bug.cgi?id=149368
1151
1152         Broke run-webkit-tests --pixel (Requested by ap on #webkit).
1153
1154         Reverted changeset:
1155
1156         "printing does not use minimum page zoom factor"
1157         https://bugs.webkit.org/show_bug.cgi?id=108507
1158         http://trac.webkit.org/changeset/189908
1159
1160 2015-09-18  Andy Estes  <aestes@apple.com>
1161
1162         [iOS] did{Start,Finish}LoadForQuickLookDocumentInMainFrame is never called on WKNavigationDelegate
1163         https://bugs.webkit.org/show_bug.cgi?id=149360
1164
1165         Reviewed by Tim Horton.
1166
1167         Added an API test.
1168
1169         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1170         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Added.
1171         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1172         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1173         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]):
1174         (TEST):
1175         * TestWebKitAPI/ios/pages.pages: Added.
1176
1177 2015-09-18  Nan Wang  <n_wang@apple.com>
1178
1179         AX: Implement ARIA 1.1 @aria-current on iOS
1180         https://bugs.webkit.org/show_bug.cgi?id=149297
1181
1182         Reviewed by Chris Fleizach.
1183
1184         Added support to test aria-current on iOS.
1185
1186         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1187         (AccessibilityUIElement::stringAttributeValue):
1188         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1189         (WTR::AccessibilityUIElement::stringAttributeValue):
1190
1191 2015-09-18  Alexey Proskuryakov  <ap@apple.com>
1192
1193         iOS WebKitTestRunner frequently crashes in WKContextGetIconDatabase
1194         https://bugs.webkit.org/show_bug.cgi?id=149352
1195
1196         Reviewed by Simon Fraser.
1197
1198         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
1199         m_context can be null. This may indicate a bug in webkitpy too, but
1200         WebKitTestRunner should handle this situation nicely, there is nothing intrinsically
1201         wrong with opening and immediately closing it.
1202
1203 2015-09-18  Daniel Bates  <dabates@apple.com>
1204
1205         isGitSVNDirectory() returns true when Git is not installed
1206         https://bugs.webkit.org/show_bug.cgi?id=149351
1207
1208         Reviewed by Alexey Proskuryakov.
1209
1210         Fixes an issue where VCSUtils::isGitSVNDirectory() returns true for any arbitrary directory if
1211         Git is not installed on the machine.
1212
1213         * Scripts/VCSUtils.pm:
1214         (isGitSVNDirectory): Ensure that `git config --get svn-remote.svn.fetch 2>& 1` exits with
1215         status code 0 (success).
1216
1217 2015-09-18  Alex Christensen  <achristensen@webkit.org>
1218
1219         Prevent build-webkit from building four times on Windows 
1220         https://bugs.webkit.org/show_bug.cgi?id=149336
1221
1222         Reviewed by Brent Fulgham.
1223
1224         * Scripts/build-webkit:
1225         Move the Windows code out of the for loop iterating over each subdirectory to be build.
1226         They're built all at once.
1227         * Scripts/webkitdirs.pm:
1228         (buildVisualStudioProject):
1229         (cmakeGeneratedBuildfile):
1230         Don't generate the Visual Studio solution if it already exists.
1231         It will run CMake again if necessary.
1232
1233 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
1234
1235         [iOS WK2] WTR fails to set the key window in the UIKit sense
1236         https://bugs.webkit.org/show_bug.cgi?id=149325
1237
1238         Reviewed by Tim Horton.
1239
1240         -[WebKitTestRunnerWindow isKeyWindow] just returned _platformWebView->windowIsKey().
1241         This causes UIKit to bypass code that actually sets the key window, resulting in
1242         [UIAppliation sharedApplication].keyWindow always being nil.
1243
1244         Fix by PlatformWebView::setWindowIsKey() actually call -makeKeyWindow, and having
1245         -[WebKitTestRunnerWindow isKeyWindow] call super.
1246
1247         * WebKitTestRunner/PlatformWebView.h:
1248         (WTR::PlatformWebView::setWindowIsKey): Deleted.
1249         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1250         (WTR::PlatformWebView::setWindowIsKey):
1251         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1252         (WTR::PlatformWebView::setWindowIsKey):
1253         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1254         (-[WebKitTestRunnerWindow isKeyWindow]):
1255         (WTR::PlatformWebView::PlatformWebView):
1256         (WTR::PlatformWebView::~PlatformWebView):
1257         (WTR::PlatformWebView::setWindowIsKey):
1258         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1259         (WTR::PlatformWebView::setWindowIsKey):
1260
1261 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
1262
1263         [iOS WK2] When loading viewport tests, use the normal web page viewport configuration
1264         https://bugs.webkit.org/show_bug.cgi?id=149321
1265
1266         Reviewed by Tim Horton.
1267         
1268         InjectedBundlePage::platformDidStartProvisionalLoadForFrame() unconditionally 
1269         enabled the "testing" viewport configuration, which disables page scaling.
1270         
1271         If we're running viewport tests, we want the normal web page configuration.
1272         Do that by passing a flag in the dictionary sent to InjectedBundle::beginTesting(),
1273         based on whether the test is in a "viewport" directory.
1274
1275         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1276         (WTR::InjectedBundle::beginTesting):
1277         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1278         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Deleted.
1279         * WebKitTestRunner/TestInvocation.cpp:
1280         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
1281         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
1282         (WTR::TestInvocation::shouldMakeViewportFlexible):
1283         (WTR::TestInvocation::invoke):
1284         * WebKitTestRunner/TestInvocation.h:
1285         * WebKitTestRunner/ios/TestControllerIOS.mm:
1286         (WTR::TestController::platformConfigureViewForTest):
1287         (WTR::shouldMakeViewportFlexible): Deleted.
1288
1289 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
1290
1291         Give iOS WebKitTestRunner a launch storyboard
1292         https://bugs.webkit.org/show_bug.cgi?id=149314
1293
1294         Reviewed by Dan Bates.
1295         
1296         Add a launch storyboard to iOS WebKitTestRunner so that Springboard recognizes
1297         that it's been built for specific device configurations, and puts the window
1298         at the top of the screen. This simplifies coordinate conversions in a future patch.
1299
1300         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1301         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
1302         * WebKitTestRunner/ios/Launch.storyboard: Added.
1303
1304 2015-09-17  Myles C. Maxfield  <mmaxfield@apple.com>
1305
1306         Update licence in r189890
1307         https://bugs.webkit.org/show_bug.cgi?id=149306
1308
1309         Reviewed by Dean Jackson.
1310
1311         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1312         * FontWithFeatures/FontWithFeatures/FontCreator.h:
1313         * FontWithFeatures/FontWithFeatures/main.cpp:
1314
1315 2015-09-17  Mark Lam  <mark.lam@apple.com>
1316
1317         Add the ability to skip JIT stress tests in run-javascriptcore-tests.
1318         https://bugs.webkit.org/show_bug.cgi?id=149285
1319
1320         Reviewed by Saam Barati.
1321
1322         Just need to add an option to pass --no-jit to run-jsc-stress-test.
1323
1324         * Scripts/run-javascriptcore-tests:
1325         (runJSCStressTests):
1326
1327 2015-09-17  Alex Christensen  <achristensen@webkit.org>
1328
1329         Switch AppleWin build to use CMake
1330         https://bugs.webkit.org/show_bug.cgi?id=149163
1331
1332         Reviewed by Brent Fulgham.
1333
1334         * Scripts/build-webkit:
1335         * Scripts/run-api-tests:
1336         (runTest):
1337         (listAllTests):
1338         (prepareEnvironmentForRunningTestTool):
1339         (testToolPaths):
1340         (testToolPath): Deleted.
1341         Run the API tests as separate executables on Windows.
1342         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
1343         * Scripts/webkitdirs.pm:
1344         (checkRequiredSystemConfig):
1345         (jhbuildWrapperPrefixIfNeeded):
1346         (generateBuildSystemFromCMakeProject):
1347         Fix configuration quirks.
1348
1349 2015-09-17  Dean Johnson  <dean_johnson@apple.com>
1350
1351         Added toggle options for hiding and showing certain platform families on the dashboard.
1352         https://bugs.webkit.org/show_bug.cgi?id=148403
1353
1354         Reviewed by David Kilzer.
1355
1356         This patch removes "hiddenPlatforms" from use in the code and local storage. We also removed
1357         individual hide/show buttons for platforms because we've added toggle options to hide/show entire
1358         families. Examples of these are "mac", "ios", and "linux". "Show All Platforms" was also removed
1359         in lieu of an "all" button in the toggle menu.
1360
1361         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1362         (parsePlatformFamily): Helper function to parse out a platform family.
1363         (initPlatformsByFamily): Initializes platformsByFamily, which organizes platforms on the
1364         page by platformsByFamily[<family>] = <list of platforms belonging to that family>.
1365         (updateToggleButtons): Updates the status of the toggle buttons.
1366         (updateHiddenPlatforms): Changed to work with the new implementation of hiding/showing platforms.
1367         (documentReady): Added creation of toggle buttons.
1368         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
1369         (unhiddenQueues): Updated to search by platform family instead of the individual platform name.
1370         (documentReady): Changed hiddenPlatforms => hiddenPlatformFamilies.
1371         (updateHiddenPlatforms): Deleted. After removing the individual hide button code, 
1372         this did the exact same thing as the updateHiddenPlatforms in Scripts/Main.js so it was removed.
1373         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
1374         (QueueView): Updated to use hiddenPlatformFamilies.
1375         (QueueView.prototype._updateHiddenState): Updated to use hiddenPlatformFamilies.
1376         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
1377         (Settings.prototype.toggleHiddenPlatformFamily): Renamed function and some variables.
1378         (Settings.prototype.clearHiddenPlatformFamilies): Now uses hiddenPlatformFamilies for events.
1379         (Settings.prototype.toggleHiddenPlatform): Deleted.
1380         (Settings.prototype.clearHiddenPlatforms): Deleted.
1381         (Settings.prototype.toggleShowPlatformFamily): Deleted.
1382         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1383         (div.cellButton, div.accessibilityButton, div.platformFamilyToggleButton):
1384         (div.cellButton.unhide, div.accessibilityButton.unhide, div.platformFamilyToggleButton.unhide):
1385         (.settings-visible div.settingsWrapper.hide, .settings-visible div.settingsWrapper):
1386         (table.queue-grid tr.headers th):
1387         (div.settingsWrapper.hide):
1388         (div.settingsWrapper):
1389         (div.familyToggleWrapper):
1390         (div.platformFamilyToggleButton):
1391         (div.platformFamilyShowToggleButton:not(:last-child)):
1392         (div.familyShown):
1393         (div.accessibilityButton):
1394         (div.cellButton, div.accessibilityButton): Added platformFamilyToggleButton class.
1395         (div.cellButton.unhide, div.accessibilityButton.unhide): Added platformFamilyToggleButton class.
1396         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide): Added
1397         platformFamilyToggleButton and settingsWrapper class.
1398         (.accessibilityButton): Deleted.
1399
1400 2015-09-17  Tim Horton  <timothy_horton@apple.com>
1401
1402         Add a test ensuring that scrolling in the middle of a page can't start a swipe gesture
1403         https://bugs.webkit.org/show_bug.cgi?id=148904
1404
1405         Reviewed by Myles Maxfield.
1406
1407         * WebKitTestRunner/TestController.cpp:
1408         (WTR::parseBooleanTestHeaderValue):
1409         (WTR::updateViewOptionsFromTestHeader):
1410         Check for the key "useThreadedScrolling".
1411         Add some code to check for "true" and "false" for boolean options.
1412
1413         (WTR::TestController::viewOptionsForTest):
1414         Apply the test's overrides last, even after the platform's.
1415
1416 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1417
1418         printing does not use minimum page zoom factor
1419         https://bugs.webkit.org/show_bug.cgi?id=108507
1420
1421         Reviewed by Darin Adler.
1422
1423         WebKitTestRunner always takes the snapshots from the UI process
1424         (expect for IOS), so in the case of printing, the layout in the
1425         web view is not the expected one. When printing, we need to take
1426         the snapshot in the web process and ensure it's rendered with a
1427         PrintContext.
1428
1429         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1430         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
1431         kWKSnapshotOptionsPrinting option to
1432         WKBundlePageCreateSnapshotWithOptions() when printing. When not
1433         printing, don't even create the snapshot, since it will be ignored
1434         by the UI process that always creates its own from the WebView (expect for IOS platform)
1435         * WebKitTestRunner/TestInvocation.cpp:
1436         (WTR::TestInvocation::dumpResults): Use always the snapshot image
1437         received from the web process if any when comparing pixel
1438         results. Now we only receive a snapshot from the web process in
1439         case of printing, or when platform is IOS. Otherwhise, generate
1440         the snapshot from the WebView as usual.
1441         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
1442         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
1443         is created by the caller now, but the CG implementation needs to
1444         know if it's a Web or UI process snapshot.
1445         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1446         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
1447         cairo surface for the given image.
1448         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1449         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
1450         CGContext for the given image.
1451
1452 2015-09-16  Myles C. Maxfield  <mmaxfield@apple.com>
1453
1454         Create a font which can be used for testing font features
1455         https://bugs.webkit.org/show_bug.cgi?id=149237
1456
1457         Reviewed by Simon Fraser.
1458
1459         This patch adds a new project in the Tools/ directory which generates a font which can
1460         be used for testing font features. This is a standalone project consisting of two files:
1461         1. A file which actually generates the byte vector representing the font. This file has
1462         a single public function: std::vector<uint8_t> generateFont(). This file is not platform
1463         specific, and only relies on the C++ STL.
1464         2. A file with a main() which calls generateFont() and writes out the font, as well as
1465         uses the font to render some demonstration text into a .png file. This file is platform
1466         specific.
1467
1468         The font itself only supports the following characters:
1469         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
1470         However, the shape of these letters are either an X or a check mark.
1471
1472         The letter "A" always is a check mark.
1473         The letter "B" always is an X.
1474         Without any font features turned on, the rest of the letters are shown as X.
1475
1476         Each font feature has an letter associated with it. When the font feature is enabled,
1477         that letter is shown as a check mark. For example, when "smcp" is enabled, "J" is shown
1478         as a check mark.
1479
1480         Here are the mappings of font features to letters:
1481         liga: C
1482         clig: D
1483         dlig: E
1484         hlig: F
1485         calt: G
1486         subs: H
1487         sups: I
1488         smcp: J
1489         c2sc: K
1490         pcap: L
1491         c2pc: M
1492         unic: N
1493         titl: O
1494         onum: P
1495         pnum: Q
1496         tnum: R
1497         frac: S
1498         afrc: T
1499         ordn: U
1500         zero: V
1501         hist: W
1502         jp78: X
1503         jp83: Y
1504         jp90: Z
1505         jp04: a
1506         smpl: b
1507         trad: c
1508         fwid: d
1509         pwid: e
1510         ruby: f
1511
1512         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj: Added.
1513         * FontWithFeatures/FontWithFeatures/FontCreator.cpp: Added.
1514         (integralLog2):
1515         (roundDownToPowerOfTwo):
1516         (isFourByteAligned):
1517         (clampTo):
1518         (append32):
1519         (writeCFFEncodedNumber):
1520         (CFFBuilder::CFFBuilder):
1521         (CFFBuilder::takeResult):
1522         (CFFBuilder::moveTo):
1523         (CFFBuilder::lineTo):
1524         (CFFBuilder::curveToCubic):
1525         (CFFBuilder::closePath):
1526         (CFFBuilder::writePoint):
1527         (generateBoxCharString):
1528         (generateCheckCharString):
1529         (generateXCharString):
1530         (charStringForGlyph):
1531         (Generator::generate):
1532         (Generator::Placeholder::Placeholder):
1533         (Generator::Placeholder::populate):
1534         (Generator::Placeholder::~Placeholder):
1535         (Generator::placeholder):
1536         (Generator::append16):
1537         (Generator::append32):
1538         (Generator::append32BitCode):
1539         (Generator::overwrite16):
1540         (Generator::overwrite32):
1541         (Generator::appendCFFTable):
1542         (Generator::appendSubstitutionSubtable):
1543         (Generator::appendScriptSubtable):
1544         (Generator::appendGSUBTable):
1545         (Generator::appendOS2Table):
1546         (Generator::appendFormat12CMAPTable):
1547         (Generator::appendFormat4CMAPTable):
1548         (Generator::appendCMAPTable):
1549         (Generator::appendHEADTable):
1550         (Generator::appendHHEATable):
1551         (Generator::appendHMTXTable):
1552         (Generator::appendMAXPTable):
1553         (Generator::appendNAMETable):
1554         (Generator::appendPOSTTable):
1555         (Generator::calculateChecksum):
1556         (Generator::appendTable):
1557         (generateFont):
1558         * FontWithFeatures/FontWithFeatures/FontCreator.h: Added.
1559         * FontWithFeatures/FontWithFeatures/main.cpp: Added.
1560         (drawTextWithFeature):
1561         (main):
1562
1563 2015-09-16  Commit Queue  <commit-queue@webkit.org>
1564
1565         Unreviewed, rolling out r189875 and r189878.
1566         https://bugs.webkit.org/show_bug.cgi?id=149235
1567
1568         cygwin cmake build not ready yet (Requested by alexchristensen
1569         on #webkit).
1570
1571         Reverted changesets:
1572
1573         "Switch AppleWin build to use CMake"
1574         https://bugs.webkit.org/show_bug.cgi?id=149163
1575         http://trac.webkit.org/changeset/189875
1576
1577         "Cygwin build fix after r189875"
1578         http://trac.webkit.org/changeset/189878
1579
1580 2015-09-16  Alex Christensen  <achristensen@webkit.org>
1581
1582         Cygwin build fix after r189875
1583
1584         * Scripts/build-webkit:
1585         * Scripts/webkitdirs.pm:
1586         (jhbuildWrapperPrefixIfNeeded):
1587         (generateBuildSystemFromCMakeProject):
1588         Make things work with cygwin and cmake.
1589
1590 2015-09-16  Alex Christensen  <achristensen@webkit.org>
1591
1592         Switch AppleWin build to use CMake
1593         https://bugs.webkit.org/show_bug.cgi?id=149163
1594
1595         Reviewed by Brent Fulgham.
1596
1597         * Scripts/build-webkit:
1598         Build with CMake.
1599         * Scripts/run-api-tests:
1600         (runTest):
1601         (listAllTests):
1602         (prepareEnvironmentForRunningTestTool):
1603         (testToolPaths):
1604         (testToolPath): Deleted.
1605         Run the API tests as separate executables on Windows.
1606         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
1607
1608 2015-09-16  Alexey Proskuryakov  <ap@apple.com>
1609
1610         Add newer build.webkit.org pages to robots.txt
1611         https://bugs.webkit.org/show_bug.cgi?id=149219
1612
1613         Reviewed by Darin Adler.
1614
1615         Indexing bot watcher's dashboard can't be good.
1616
1617         * BuildSlaveSupport/build.webkit.org-config/public_html/robots.txt:
1618
1619 2015-09-16  Alex Christensen  <achristensen@webkit.org>
1620
1621         Rollout r189851 and 189853 because they didn’t actually fix the permissions issue
1622
1623         * BuildSlaveSupport/built-product-archive:
1624         (unzipArchive):
1625
1626 2015-09-16  Csaba Osztrogonác  <ossy@webkit.org>
1627
1628         [EFL] Fix the help message of separated web process option of MiniBrowser
1629         https://bugs.webkit.org/show_bug.cgi?id=149212
1630
1631         Reviewed by Gyuyoung Kim.
1632
1633         * MiniBrowser/efl/main.c:
1634
1635 2015-09-16  Alex Christensen  <achristensen@webkit.org>
1636
1637         Fix python syntax after r189851.
1638
1639         * BuildSlaveSupport/built-product-archive:
1640         (unzipArchive):
1641         For loops need a colon.
1642
1643 2015-09-15  Alex Christensen  <achristensen@webkit.org>
1644
1645         Fix Windows test bots after changing to non-cygwin build
1646         https://bugs.webkit.org/show_bug.cgi?id=149196
1647
1648         Reviewed by Daniel Bates.
1649
1650         * BuildSlaveSupport/built-product-archive:
1651         (unzipArchive):
1652         Using different versions of python makes what I think is https://bugs.python.org/issue15795
1653         prevent us from executing files from the archive on the test bots.
1654
1655 2015-09-15  Ryosuke Niwa  <rniwa@webkit.org>
1656
1657         Add ShadowRoot interface and Element.prototype.attachShadow
1658         https://bugs.webkit.org/show_bug.cgi?id=149187
1659
1660         Reviewed by Antti Koivisto.
1661
1662         * Scripts/webkitperl/FeatureList.pm:
1663
1664 2015-09-15  Aakash Jain  <aakash_jain@apple.com>
1665
1666         Appscale queue status json output lacks bots
1667         https://bugs.webkit.org/show_bug.cgi?id=149194
1668         <rdar://problem/22171089>
1669
1670         Reviewed by Alexey Proskuryakov.
1671
1672         * QueueStatusServer/handlers/queuestatusjson.py:
1673         (QueueStatusJSON._bots): Order the results by date so as to get latest events, this was default in AppEngine.
1674         * QueueStatusServer/index.yaml: Index according to appscale requirements.
1675
1676 2015-09-15  Brent Fulgham  <bfulgham@apple.com>
1677
1678         [Win] Provide a means for viewing the layer tree
1679         https://bugs.webkit.org/show_bug.cgi?id=149165
1680
1681         Reviewed by Simon Fraser.
1682
1683         Update MiniBrowser with a new Debug menu option that will
1684         dump the current layer tree to the debug console.
1685         
1686         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc:
1687         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h:
1688         * MiniBrowser/win/Common.cpp:
1689         (WndProc): Add handler for 'Print Layer Tree' menu option.
1690         * MiniBrowser/win/MiniBrowser.cpp:
1691         (MiniBrowser::printLayerTree): Added Handler.
1692         * MiniBrowser/win/MiniBrowser.h:
1693
1694 2015-09-14  Myles C. Maxfield  <mmaxfield@apple.com>
1695
1696         WebKitTestRunner declarative language setting is broken for iOS
1697         https://bugs.webkit.org/show_bug.cgi?id=149119
1698
1699         Unreviewed.
1700
1701         In all of the patches on webkit.org/b/189669, my patch to get this working on iOS was
1702         lost in the final version which got committed. This simply implements the existing
1703         OS X behavior on iOS.
1704
1705         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
1706         (WTR::InjectedBundle::platformInitialize):
1707
1708 2015-09-14  Dewei Zhu  <dewei_zhu@apple.com>
1709
1710         Unreviewed, add myself to committers list.
1711
1712         * Scripts/webkitpy/common/config/contributors.json:
1713
1714 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
1715
1716         [Cocoa] Allow testing with the system language
1717         https://bugs.webkit.org/show_bug.cgi?id=148671
1718
1719         Reviewed by Anders Carlsson and Alexey Proskuryakov.
1720
1721         React to tests marked with language=lang1,lang2,etc in their header.
1722         Once this information is parsed, pass it to
1723         WKContextConfigurationSetOverrideLanguages().
1724
1725         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1726         (WTR::InjectedBundle::platformInitialize): Don't clobber the language
1727         list.
1728         * WebKitTestRunner/TestController.cpp:
1729         (WTR::TestController::createWebViewWithOptions): Call
1730         WKContextConfigurationSetOverrideLanguages().
1731         (WTR::updateTestOptionsFromTestHeader): Inspect the language option.
1732         * WebKitTestRunner/TestOptions.h:
1733         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1734         (WTR::PlatformWebView::viewSupportsOptions): Cause a differing language
1735         option to restart the web process.
1736         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1737         (WTR::PlatformWebView::viewSupportsOptions): Ditto.
1738
1739 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
1740
1741         [WKTR] Allow changing the WKContextConfiguration between successive tests
1742         https://bugs.webkit.org/show_bug.cgi?id=148833
1743
1744         Reviewed by Tim Horton.
1745
1746         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
1747         However, there are certain tests which require specifying options in this object. This patch makes
1748         our existing code for recreating the test runner web view also recreate the WKContext.
1749
1750         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
1751         class.
1752
1753         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
1754         * WebKitTestRunner/PlatformWebView.h:
1755         (WTR::PlatformWebView::options):
1756         * WebKitTestRunner/TestController.cpp:
1757         (WTR::TestController::initialize):
1758         (WTR::TestController::generateContextConfiguration):
1759         (WTR::TestController::generatePageConfiguration):
1760         (WTR::TestController::createWebViewWithOptions):
1761         (WTR::TestController::ensureViewSupportsOptionsForTest):
1762         (WTR::updateContextConfigurationOptionsFromTestHeader):
1763         (WTR::TestController::contextConfigurationOptionsForTest):
1764         (WTR::TestController::platformCreateWebView):
1765         (WTR::TestController::platformCreateOtherPage):
1766         (WTR::updateViewOptionsFromTestHeader): Deleted.
1767         (WTR::TestController::viewOptionsForTest): Deleted.
1768         * WebKitTestRunner/TestController.h:
1769         (WTR::TestController::injectedBundlePath):
1770         (WTR::TestController::testPluginDirectory):
1771         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1772         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1773         (WTR::TestController::platformCreateWebView):
1774         (WTR::TestController::platformCreateOtherPage):
1775         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1776         (WTR::PlatformWebView::PlatformWebView):
1777         (WTR::PlatformWebView::viewSupportsOptions):
1778         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1779         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1780         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1781         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1782         (WTR::PlatformWebView::PlatformWebView):
1783         (WTR::PlatformWebView::viewSupportsOptions):
1784         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1785         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1786         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1787         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1788         (WTR::PlatformWebView::PlatformWebView):
1789         (WTR::PlatformWebView::viewSupportsOptions):
1790         * WebKitTestRunner/ios/TestControllerIOS.mm:
1791         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1792         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1793         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1794         (WTR::PlatformWebView::PlatformWebView):
1795         (WTR::PlatformWebView::viewSupportsOptions):
1796         * WebKitTestRunner/mac/TestControllerMac.mm:
1797         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1798         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1799
1800 2015-09-11  Michael Saboff  <msaboff@apple.com>
1801
1802         LayoutTestHelper crashes if a color profile isn't set for a 3rd party monitor
1803         https://bugs.webkit.org/show_bug.cgi?id=149083
1804
1805         Reviewed by Alexey Proskuryakov.
1806
1807         Check to make sure that we have a valid factoryProfile CFDictionaryRef before using it.
1808
1809         * DumpRenderTree/mac/LayoutTestHelper.m:
1810         (colorProfileURLForDisplay):
1811
1812 2015-09-11  Saam barati  <sbarati@apple.com>
1813
1814         There should be a defaultSpotCheck-like mode that doesn't run the MaximalFlushInsertionPhase in run-jsc-stress-tests
1815         https://bugs.webkit.org/show_bug.cgi?id=149058
1816
1817         Reviewed by Geoffrey Garen.
1818
1819         * Scripts/run-jsc-stress-tests:
1820
1821 2015-09-10  Commit Queue  <commit-queue@webkit.org>
1822
1823         Unreviewed, rolling out r189595.
1824         https://bugs.webkit.org/show_bug.cgi?id=149052
1825
1826         The tests still fail (Requested by ap on #webkit).
1827
1828         Reverted changeset:
1829
1830         "Spurious output on Windows tests: AQMEIOManager::FindIOUnit:
1831         error -1"
1832         https://bugs.webkit.org/show_bug.cgi?id=142929
1833         http://trac.webkit.org/changeset/189595
1834
1835 2015-09-10  Alexey Proskuryakov  <ap@apple.com>
1836
1837         Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
1838         https://bugs.webkit.org/show_bug.cgi?id=142929
1839
1840         Reviewed by Brent Fulgham.
1841
1842         Silence the logging. We'll track fixing the root cause in Radar.
1843
1844         * Scripts/webkitpy/port/mac.py:
1845         (MacPort.stderr_patterns_to_strip): Added a FIXME.
1846
1847         * Scripts/webkitpy/port/win.py:
1848         (WinPort.logging_patterns_to_strip): Added.
1849
1850 2015-09-09  Andy Estes  <aestes@apple.com>
1851
1852         [iOS] Teach run-webkit-tests how to parse simulator runtimes when version numbers contain a revision
1853         https://bugs.webkit.org/show_bug.cgi?id=149022
1854
1855         Reviewed by Daniel Bates.
1856
1857         Simulator runtime versions can contain a revision number (e.g. 8.4.1), but the regex for matching runtimes
1858         did not account for this.
1859
1860         * Scripts/webkitpy/xcode/simulator.py:
1861         (Simulator): Optionally matched a revision at the end of a runtime version number.
1862         * Scripts/webkitpy/xcode/simulator_unittest.py: Added a test.
1863
1864 2015-09-09  Andy Estes  <aestes@apple.com>
1865
1866         [iOS] Teach run-webkit-tests how to parse `simctl list` when a tvOS SDK is installed
1867         https://bugs.webkit.org/show_bug.cgi?id=149029
1868         <rdar://problem/22432624>
1869
1870         Reviewed by Daniel Bates.
1871
1872         * Scripts/webkitpy/xcode/simulator.py:
1873         (Simulator): Taught to parse tvOS runtimes.
1874         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
1875
1876 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
1877
1878         Fix bit rot on bot watcher's dashboard page
1879         https://bugs.webkit.org/show_bug.cgi?id=149012
1880
1881         Reviewed by Tim Horton.
1882
1883         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1884         The code path used by the metrics page was trying to add properties to an undefined.
1885
1886         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1887         Silence an expection that would occur when the step has no logs. This should never
1888         happen, but it did (perhaps buildbot was misconfigured for a while).
1889
1890 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
1891
1892         Update LayoutTestRelay xcconfig file.
1893
1894         Rubber-stamped by Dan Bernstein.
1895
1896         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1897
1898 2015-09-09  Saam barati  <sbarati@apple.com>
1899
1900         DFG should have a debugging option that runs a phase that flushes all locals
1901         https://bugs.webkit.org/show_bug.cgi?id=148916
1902
1903         Reviewed by Filip Pizlo.
1904
1905         * Scripts/run-jsc-stress-tests:
1906
1907 2015-09-09  Commit Queue  <commit-queue@webkit.org>
1908
1909         Unreviewed, rolling out r189530 and r189534.
1910         https://bugs.webkit.org/show_bug.cgi?id=148996
1911
1912         Caused assertion failures on Yosemite (Requested by litherum
1913         on #webkit).
1914
1915         Reverted changesets:
1916
1917         "[WKTR] Allow changing the WKContextConfiguration between
1918         successive tests"
1919         https://bugs.webkit.org/show_bug.cgi?id=148833
1920         http://trac.webkit.org/changeset/189530
1921
1922         "[Cocoa] Fix the tests after r189530"
1923         http://trac.webkit.org/changeset/189534
1924
1925 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
1926
1927         [Cocoa] Fix the tests after r189530
1928
1929         Unreviewed.
1930
1931         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1932         (WTR::initializeWebViewConfiguration):
1933
1934 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
1935
1936         [WKTR] Allow changing the WKContextConfiguration between successive tests
1937         https://bugs.webkit.org/show_bug.cgi?id=148833
1938
1939         Reviewed by Tim Horton.
1940
1941         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
1942         However, there are certain tests which require specifying options in this object. This patch makes
1943         our existing code for recreating the test runner web view also recreate the WKContext.
1944
1945         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
1946         class.
1947
1948         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
1949         * WebKitTestRunner/PlatformWebView.h:
1950         (WTR::PlatformWebView::options):
1951         * WebKitTestRunner/TestController.cpp:
1952         (WTR::TestController::initialize):
1953         (WTR::TestController::generateContextConfiguration):
1954         (WTR::TestController::generatePageConfiguration):
1955         (WTR::TestController::createWebViewWithOptions):
1956         (WTR::TestController::ensureViewSupportsOptionsForTest):
1957         (WTR::updateContextConfigurationOptionsFromTestHeader):
1958         (WTR::TestController::contextConfigurationOptionsForTest):
1959         (WTR::TestController::platformCreateWebView):
1960         (WTR::TestController::platformCreateOtherPage):
1961         (WTR::updateViewOptionsFromTestHeader): Deleted.
1962         (WTR::TestController::viewOptionsForTest): Deleted.
1963         * WebKitTestRunner/TestController.h:
1964         (WTR::TestController::injectedBundlePath):
1965         (WTR::TestController::testPluginDirectory):
1966         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1967         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1968         (WTR::TestController::platformCreateWebView):
1969         (WTR::TestController::platformCreateOtherPage):
1970         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1971         (WTR::PlatformWebView::PlatformWebView):
1972         (WTR::PlatformWebView::viewSupportsOptions):
1973         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1974         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1975         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1976         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1977         (WTR::PlatformWebView::PlatformWebView):
1978         (WTR::PlatformWebView::viewSupportsOptions):
1979         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1980         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1981         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1982         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1983         (WTR::PlatformWebView::PlatformWebView):
1984         (WTR::PlatformWebView::viewSupportsOptions):
1985         * WebKitTestRunner/ios/TestControllerIOS.mm:
1986         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1987         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1988         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1989         (WTR::PlatformWebView::PlatformWebView):
1990         (WTR::PlatformWebView::viewSupportsOptions):
1991         * WebKitTestRunner/mac/TestControllerMac.mm:
1992         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
1993         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
1994
1995 2015-09-08  Daniel Bates  <dabates@apple.com>
1996
1997         [Mac] Expose Enable/Disable Accelerated Drawing in MiniBrowser
1998         https://bugs.webkit.org/show_bug.cgi?id=148980
1999
2000         Reviewed by Alexey Proskuryakov.
2001
2002         Add setting to enable/disable accelerated drawing so as to support testing
2003         this feature in MiniBrowser on Mac.
2004
2005         * MiniBrowser/mac/SettingsController.h:
2006         * MiniBrowser/mac/SettingsController.m:
2007         (-[SettingsController _populateMenu]): Add menu item.
2008         (-[SettingsController validateMenuItem:]): Update setting when menu item is toggled.
2009         (-[SettingsController toggleAcceleratedDrawingEnabled:]): Added.
2010         (-[SettingsController acceleratedDrawingEnabled]): Added.
2011         * MiniBrowser/mac/WK1BrowserWindowController.m:
2012         (-[WK1BrowserWindowController didChangeSettings]): Apply setting in WebKit1.
2013         * MiniBrowser/mac/WK2BrowserWindowController.m:
2014         (-[WK2BrowserWindowController didChangeSettings]): Apply setting in WebKit2.
2015
2016 2015-09-08  Jason Marcell  <jmarcell@apple.com>
2017
2018         Unreviewed. Added myself as a commiter in contributors.json.
2019
2020         * Scripts/webkitpy/common/config/contributors.json:
2021
2022 2015-09-08  Keith Miller  <keith_miller@apple.com>
2023
2024         Unreviewed, added myself to the list of contributors.
2025
2026         * Scripts/webkitpy/common/config/contributors.json:
2027
2028 2015-09-08  Daniel Bates  <dabates@apple.com>
2029
2030         Dashboard: Remove use of z-index for ring overlay; use DOM ordering
2031         https://bugs.webkit.org/show_bug.cgi?id=148921
2032
2033         Reviewed by Alexey Proskuryakov.
2034
2035         The ring image is positioned above the platform icon in markup and we specify the CSS
2036         property z-index for the ring image so that it is painted on top of the platform icon
2037         instead of below it (by DOM ordering). Instead we can take advantage of the transparency
2038         of the ring image, switch the order of these DOM elements and remove the use of the CSS
2039         property z-index to achieve a similar effect.
2040
2041         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2042         (documentReady): Create the platform icon image element before the ring image such that
2043         the ring image is painted on top of the platform icon.
2044         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2045         (table.queue-grid td.logo img.ring): Removed property z-index.
2046
2047 2015-09-08  Daniel Bates  <dabates@apple.com>
2048
2049         Dashboard: Remove duplicate gear icon data URLs
2050         https://bugs.webkit.org/show_bug.cgi?id=148920
2051
2052         Reviewed by Alexey Proskuryakov.
2053
2054         Currently we duplicate the SVG data URL for the gear icon up to its fill color in the CSS property
2055         background-image associated with each of the three gear icon states: collapsed (.settings), hover
2056         (.settings:hover), and expanded (.settings-visible .settings). Instead we should use the gear icon
2057         as a mask and make use of the CSS background-color to define the fill color for each of these three
2058         states.
2059
2060         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2061         (.settings): Use gear icon as mask and define CSS background-color for collapsed state. 
2062         (.settings:hover): Override CSS background-color for hover state.
2063         (.settings-visible .settings): Override CSS background-color for expanded state.
2064
2065 2015-09-07  Andy Estes  <aestes@apple.com>
2066
2067         [Mac] DebugRelease builds should link against libWebKitSystemInterfaceElCapitan.a on 10.11
2068         https://bugs.webkit.org/show_bug.cgi?id=148946
2069         <rdar://problem/22603981>
2070
2071         Reviewed by Dan Bernstein.
2072
2073         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2074         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2075
2076 2015-09-07  Hunseop Jeong  <hs85.jeong@samsung.com>
2077
2078         [EFL] Many of the css3/device-adapt/* tests failed after r188548.
2079         https://bugs.webkit.org/show_bug.cgi?id=148927
2080
2081         Reviewed by Csaba Osztrogonác.
2082
2083         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
2084         overwritten by updatePlatformSpecificViewOptionsForTest after r188548.
2085
2086         * WebKitTestRunner/TestController.cpp:
2087         (WTR::shouldUseFixedLayout): Removed the unnecessary indentations.
2088         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2089         (WTR::shouldUseFixedLayout): Return true if the test is related with 'device-adapt'.
2090
2091 2015-09-07  Andy Estes  <aestes@apple.com>
2092
2093         Fix the Production build after r189455.
2094
2095         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Somehow I added the All target using the
2096         In-App Purchase template instead of the Aggregate template. Whoops.
2097
2098 2015-09-06  Andy Estes  <aestes@apple.com>
2099
2100         WebKit.xcworkspace should be be able to build iOS platforms
2101         https://bugs.webkit.org/show_bug.cgi?id=148881
2102
2103         Reviewed by Daniel Bates.
2104
2105         Since we don't want to create platform-specific schemes, all projects in the workspace's schemes need to build
2106         for all supported platforms.
2107
2108         * MiniBrowser/Configurations/Base.xcconfig: Included iphoneos and iphonesimulator in SUPPORTED_PLATFORMS.
2109         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Excluded all source files on iOS, and linked Cocoa and WebKit on Mac.
2110         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Ditto.
2111         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Stopped linking frameworks in Link Binaries With Libraries.
2112
2113 2015-09-06  Andy Estes  <aestes@apple.com>
2114
2115         WebKitTestRunner should build for iOS using the default target
2116         https://bugs.webkit.org/show_bug.cgi?id=148918
2117
2118         Reviewed by Daniel Bates.
2119
2120         When WebKitTestRunner was ported to iOS, a separate target (WebKitTestRunnerApp) was created for building the
2121         iOS variant. This is annoying because (1) all tools that invoke xcodebuild need to be taught to build this
2122         non-default target, and (2) a single Xcode scheme cannot be used to build both Mac and iOS variants.
2123
2124         This change adds a new default target (All) and makes it work for both Mac and iOS. Files that were built for
2125         both WebKitTestRunner and WebKitTestRunnerApp are now built in a static library target (WebKitTestRunner (Library)),
2126         and both apps now link this library. Files that are specific to Mac or iOS are excluded on the other platform.
2127         WebKitTestRunnerApp.app (which should be renamed to WebKitTestRunner.app) is skipped when installing on Mac, and
2128         WebKitTestRunner is skipped when installing on iOS.
2129
2130         The target dependency graph now looks like this:
2131
2132             All
2133                 WebKitTestRunnerApp
2134                     WebKitTestRunner (Library)
2135                         WebKitTestRunnerInjectedBundle
2136                             Derived Sources
2137                 WebKitTestRunner
2138                     WebKitTestRunner (Library)
2139                         WebKitTestRunnerInjectedBundle
2140                             Derived Sources
2141
2142         * Scripts/build-webkit: Stopped building the WebKitTestRunnerApp target on iOS.
2143         * Scripts/build-webkittestrunner: Ditto.
2144         * WebKitTestRunner/Configurations/Base.xcconfig: Set SUPPORTED_PLATFORMS to macosx, iphoneos, and iphonesimulator.
2145         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Set INSTALL_PATH here since it is the same for all targets.
2146         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Stopped setting INSTALL_PATH.
2147         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Moved frameworks from the build phase to here,
2148         excluded iOS-only files, and skipped installing on iOS.
2149         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Moved frameworks from the build phase to here,
2150         excluded Mac-only files, and skipped installing on Mac.
2151         * WebKitTestRunner/Configurations/WebKitTestRunnerLibrary.xcconfig: Skipped installing always.
2152         * WebKitTestRunner/Makefile: Stopped building the WebKitTestRunnerApp target on iOS.
2153         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added new targets, removed frameworks from
2154         Link Binary With Libraries builds phases, moved common files to the WebKitTestRunner (Library) target, and added
2155         new configuration files.
2156
2157 2015-09-05  Joseph Pecoraro  <pecoraro@apple.com>
2158
2159         Web Inspector: Improve prepare-ChangeLog for multiple cases
2160         https://bugs.webkit.org/show_bug.cgi?id=148875
2161
2162         Reviewed by Timothy Hatcher.
2163
2164         * Scripts/prepare-ChangeLog:
2165         (get_function_line_ranges_for_javascript):
2166         - We were ignoring everything inside of an anonymous function expression,
2167           such as (function(){ ... }), which made InjectedScriptSource produce nothing.
2168           Better handle this by inserting a few tweaks.
2169         - Allow method syntax outside of classes as long as they are at the global level.
2170         - Avoid treating "get" and "set" as getter/setter functions in bad contexts.
2171
2172         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
2173         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
2174         (Foo.prototype.method1):
2175         (Foo.prototype.method2):
2176         (Foo.prototype.method3.innerFunction):
2177         (Foo.prototype.method3):
2178         (insideGlobalAnonymousFunctionExpression):
2179         (foo.insideGlobalFunctionExpression):
2180         (IssueWithMapGetAndSet.prototype.method1.nestedFunctionInsideMethod1):
2181         (IssueWithMapGetAndSet.prototype.method1):
2182         (IssueWithMapGetAndSet.prototype.method2):
2183         (IssueWithMapGetAndSet.prototype.method3):
2184         (IssueWithMapGetAndSet):
2185
2186 2015-09-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2187
2188         [ES6] Enable ES6 Module in JSC shell by default
2189         https://bugs.webkit.org/show_bug.cgi?id=148689
2190
2191         Reviewed by Geoffrey Garen.
2192
2193         * Scripts/run-javascriptcore-tests:
2194         (runJSCStressTests):
2195         * Scripts/run-jsc-stress-tests:
2196
2197 2015-09-04  Basile Clement  <basile_clement@apple.com>
2198
2199         Unreviewed, change my email address.
2200
2201         * Scripts/webkitpy/common/config/contributors.json:
2202
2203 2015-09-04  Beth Dakin  <bdakin@apple.com>
2204
2205         Should have a test to make sure links don't navigate after a cancelled force 
2206         click
2207         https://bugs.webkit.org/show_bug.cgi?id=148846
2208
2209         Reviewed by Tim Horton.
2210
2211         New EventSender function for a started then cancelled force click.
2212         * WebKitTestRunner/EventSenderProxy.h:
2213         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2214         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2215         (WTR::EventSendingController::mouseForceClick):
2216         (WTR::EventSendingController::startAndCancelMouseForceClick):
2217         (WTR::EventSendingController::mouseForceDown):
2218         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2219         * WebKitTestRunner/TestController.cpp:
2220         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2221         * WebKitTestRunner/mac/EventSenderProxy.mm:
2222         (WTR::EventSenderProxy::mouseForceClick):
2223         (WTR::EventSenderProxy::startAndCancelMouseForceClick):
2224         (WTR::EventSenderProxy::mouseForceDown):
2225         (WTR::EventSenderProxy::mouseMoveTo):
2226
2227 2015-09-04  Tim Horton  <timothy_horton@apple.com>
2228
2229         Add a test for r179736 (programmatic navigation during swipe causing a crash)
2230         https://bugs.webkit.org/show_bug.cgi?id=148830
2231
2232         Reviewed by Beth Dakin.
2233
2234         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2235         (WTR::InjectedBundle::beginTesting):
2236         Make sure that TestRunner callbacks don't leak between tests!
2237
2238 2015-09-04  Anders Carlsson  <andersca@apple.com>
2239
2240         It should be possible to pass relative HTTP test paths to DumpRenderTree
2241         https://bugs.webkit.org/show_bug.cgi?id=148825
2242         <rdar://problem/22583866>
2243
2244         Reviewed by Tim Horton.
2245
2246         Convert the path to an absolute path if needed.
2247
2248         * DumpRenderTree/mac/DumpRenderTree.mm:
2249         (computeTestURL):
2250
2251 2015-09-04  Jason Marcell  <jmarcell@apple.com>
2252
2253         Fix Swift unit tests for prepare-ChangeLog.
2254         https://bugs.webkit.org/show_bug.cgi?id=148817
2255
2256         Reviewed by Alexey Proskuryakov.
2257
2258         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Fixed
2259         Swift unit tests for prepare-ChangeLog.
2260
2261 2015-09-04  Lucas Forschler  <lforschler@apple.com>
2262
2263         Modifications to the webkit-nightly logic.
2264         
2265         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
2266         (updateAlertPanel):
2267         * WebKitLauncher/main.m:
2268         (displayErrorAndQuit):
2269
2270 2015-09-04  Beth Dakin  <bdakin@apple.com>
2271
2272         Speculative build fix.
2273
2274         * WebKitTestRunner/mac/EventSenderProxy.mm:
2275
2276 2015-09-04  Brian Burg  <bburg@apple.com>
2277
2278         Web Inspector: InspectorController should support multiple frontend channels
2279         https://bugs.webkit.org/show_bug.cgi?id=148538
2280
2281         Reviewed by Joseph Pecoraro.
2282
2283         InspectorClients must explicitly disconnect their frontend channel(s) from the
2284         inspected page's InspectorController.
2285
2286         To make this possible, DumpRenderTree should not destroy non-primary views until
2287         it has tried to close any abandoned Web Inspector instances. Performing teardown
2288         in the reverse order prevents disconnection of the frontend channel because that
2289         prematurely destroys the inspector frontend client.
2290
2291         * DumpRenderTree/mac/DumpRenderTree.mm:
2292         (runTest):
2293         * DumpRenderTree/win/DumpRenderTree.cpp:
2294         (runTest):
2295
2296 2015-09-04  Beth Dakin  <bdakin@apple.com>
2297
2298         Need to be able to test default behaviors on force click
2299         https://bugs.webkit.org/show_bug.cgi?id=148758
2300
2301         Reviewed by Tim Horton.
2302
2303         This patch adds a new eventSender method to do a full, completed force click, 
2304         and it re-works all of the existing force methods to dispatch their events in 
2305         such a way that they will trigger the NSImmediateAction gesture recognizer. 
2306         To do this, first we need to send the events to the app rather than straight 
2307         to the view, and also needed to tweak some state and send the events in a 
2308         delayed fashion.
2309
2310         New public function mouseForceClick() and private helper functions to make 
2311         NSEvents.
2312         * WebKitTestRunner/EventSenderProxy.h:
2313
2314         New public function mouseForceClick().
2315         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2316         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2317         (WTR::EventSendingController::mouseMoveTo):
2318         (WTR::EventSendingController::mouseForceClick):
2319         (WTR::EventSendingController::mouseForceDown):
2320         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2321         * WebKitTestRunner/TestController.cpp:
2322         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2323
2324         initPressureEventAtLocation needs to take a stageTransition and a window.
2325         * WebKitTestRunner/mac/EventSenderProxy.mm:
2326         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
2327         (-[EventSenderSyntheticEvent stageTransition]):
2328         (-[EventSenderSyntheticEvent timestamp]):
2329         (-[EventSenderSyntheticEvent _cgsEventRecord]):
2330         (-[EventSenderSyntheticEvent window]):
2331
2332         In order to enter the gesture recognizer, we need to start with a mouse down 
2333         that has a NSEventMaskPressure modifier.
2334         (WTR::EventSenderProxy::sendMouseDownToStartPressureEvents):
2335
2336         This ensures that the events queue properly for the force monitor in AppKit.
2337         (WTR::spinRunLoopForForce):
2338
2339          We need to start the pressure change events with a began.
2340         (WTR::EventSenderProxy::beginPressureEvent):
2341
2342         These functions can be used to create the NSEvent for a pressure change every 
2343         time we need one.
2344         (WTR::EventSenderProxy::pressureChangeEvent):
2345
2346         Send the right series of events to emulate a full, completed force click.
2347         (WTR::EventSenderProxy::mouseForceClick):
2348
2349         Use all of the new things for these existing functions.
2350         (WTR::EventSenderProxy::mouseForceDown):
2351         (WTR::EventSenderProxy::mouseForceUp):
2352         (WTR::EventSenderProxy::mouseForceChanged):
2353
2354         Set NSFakeForceTouchDevice to YES.
2355         * WebKitTestRunner/mac/main.mm:
2356         (setDefaultsToConsistentValuesForTesting):
2357
2358 2015-09-04  Jason Marcell  <jmarcell@apple.com>
2359
2360         prepare-ChangeLog needs to know how to parse Swift files.
2361         https://bugs.webkit.org/show_bug.cgi?id=148784
2362         <rdar://problem/22510062>
2363
2364         Reviewed by Darin Adler.
2365
2366         * Scripts/prepare-ChangeLog:
2367         (get_function_line_ranges): Added entry for get_function_line_ranges_for_swift.
2368         (get_function_line_ranges_for_swift): Added function that knows how to parse Swift code.
2369         (parseSwiftFunctionArgs): Added function that knows how to parse Swift function arguments.
2370         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
2371         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Ditto.
2372         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests.swift: Ditto.
2373         (freeFunction): Ditto.
2374         (MyClass.function): Ditto.
2375         (MyClass.functionWithArgument(_:)): Ditto.
2376         (MyClass.functionWithMoreArguments(_:arg2:)): Ditto.
2377         (MyClass.functionWithNamedFirstArgument(argument:)): Ditto.
2378         (MyClass.functionWithNamedFirstAndSecondArgument(first:second:)): Ditto.
2379         (MyClass.classFunction): Ditto.
2380         (MyClass.readWriteComputedVariable): Ditto.
2381         (MyClass.readOnlyComputedVariable): Ditto.
2382
2383 2015-09-04  Ryosuke Niwa  <rniwa@webkit.org>
2384
2385         Import css/css-color-3
2386         https://bugs.webkit.org/show_bug.cgi?id=148803
2387
2388         Reviewed by Chris Dumez.
2389
2390         Fixed a bug that the imported reference files used the same extention as tests.
2391         This would result in parsing errors if the tests were XML and references were HTML and vice versa.
2392
2393         * Scripts/webkitpy/w3c/test_importer.py:
2394         (TestImporter.find_importable_tests):
2395
2396 2015-09-03  Commit Queue  <commit-queue@webkit.org>
2397
2398         Unreviewed, rolling out r189338.
2399         https://bugs.webkit.org/show_bug.cgi?id=148785
2400
2401         Caused tons of crashes (Requested by cdumez on #webkit).
2402
2403         Reverted changeset:
2404
2405         "Web Inspector: InspectorController should support multiple
2406         frontend channels"
2407         https://bugs.webkit.org/show_bug.cgi?id=148538
2408         http://trac.webkit.org/changeset/189338
2409
2410 2015-09-03  Brian Burg  <bburg@apple.com>
2411
2412         Web Inspector: InspectorController should support multiple frontend channels
2413         https://bugs.webkit.org/show_bug.cgi?id=148538
2414
2415         Reviewed by Joseph Pecoraro.
2416
2417         InspectorClients must explicitly disconnect their frontend channel(s) from the
2418         inspected page's InspectorController.
2419
2420         To make this possible, DumpRenderTree should not destroy non-primary views until
2421         it has tried to close any abandoned Web Inspector instances. Performing teardown
2422         in the reverse order prevents disconnection of the frontend channel because that
2423         prematurely destroys the inspector frontend client.
2424
2425         * DumpRenderTree/mac/DumpRenderTree.mm:
2426         (runTest):
2427         * DumpRenderTree/win/DumpRenderTree.cpp:
2428         (runTest):
2429
2430 2015-09-03  Timothy Hatcher  <timothy@apple.com>
2431
2432         Update WebKit nightly icon to be more like Safari
2433         https://bugs.webkit.org/show_bug.cgi?id=148768
2434
2435         Reviewed by Joseph Pecoraro.
2436
2437         * WebKitLauncher/webkit.icns:
2438
2439 2015-09-03  Geoffrey Garen  <ggaren@apple.com>
2440
2441         JavaScriptCore should have some ES6 conformance tests
2442         https://bugs.webkit.org/show_bug.cgi?id=148771
2443
2444         Reviewed by Chris Dumez.
2445
2446         * Scripts/run-javascriptcore-tests:
2447         (runJSCStressTests): Added es6 as a test suite.
2448
2449         * Scripts/run-jsc-stress-tests: Added es6 as a test suite.
2450
2451         Some of these tests currently fail, so I also added a way to expect
2452         failure for now. We'll migrate failing tests to expected passes as we
2453         fix them.
2454
2455 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2456
2457         Add a test for swipe-start hysteresis
2458         https://bugs.webkit.org/show_bug.cgi?id=148756
2459
2460         Reviewed by Anders Carlsson.
2461
2462         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2463         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2464         (WTR::cacheTestRunnerCallback):
2465         (WTR::TestRunner::clearTestRunnerCallbacks):
2466         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2467         Make sure that we log if a client tries to install a callback twice
2468         (since we use .add, the second call would not work).
2469
2470         Also, add clearTestRunnerCallbacks so tests can swap out installed
2471         callbacks.
2472
2473 2015-09-03  Anders Carlsson  <andersca@apple.com>
2474
2475         DumpRenderTree should automatically compute HTTP URLs for HTTP tests
2476         https://bugs.webkit.org/show_bug.cgi?id=148746
2477         rdar://problem/22568073
2478
2479         Reviewed by Tim Horton.
2480
2481         * DumpRenderTree/mac/DumpRenderTree.mm:
2482         (computeTestURL):
2483         Compute the test URL from the passed in path or URL. Special-case paths that contain /LayoutTests/http/tests. 
2484
2485         (runTest):
2486         Call computeTestURL.
2487
2488         (testPathFromURL):
2489         Get rid of this; computeTestURL does this for us now.
2490
2491         * Scripts/webkitpy/port/driver.py:
2492         (Driver._command_from_driver_input):
2493         Don't convert HTTP test paths to URLS before passing them to DumpRenderTree on Mac. That's handled by DRT itself now.
2494
2495 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2496
2497         Swipe tests fail on Mavericks
2498         https://bugs.webkit.org/show_bug.cgi?id=148752
2499
2500         Reviewed by Beth Dakin.
2501
2502         * WebKitTestRunner/mac/EventSenderProxy.mm:
2503
2504 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2505
2506         Fix the 32-bit build
2507
2508         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2509         (WTR::PlatformWebView::setNavigationGesturesEnabled):
2510
2511 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2512
2513         Remove some logging that wasn't meant to be in the tree
2514
2515         * WebKitTestRunner/mac/EventSenderProxy.mm:
2516         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
2517
2518 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2519
2520         [Mac] Add support for testing swipes
2521         https://bugs.webkit.org/show_bug.cgi?id=148700
2522
2523         Reviewed by Beth Dakin.
2524
2525         * WebKitTestRunner/EventSenderProxy.h:
2526         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2527         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2528         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2529         (WTR::cgEventPhaseFromString):
2530         (WTR::cgEventMomentumPhaseFromString):
2531         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
2532         (WTR::EventSendingController::swipeGestureWithWheelAndMomentumPhases):
2533         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2534         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2535         (WTR::InjectedBundle::didReceiveMessageToPage):
2536         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2537         (WTR::TestRunner::installDidBeginSwipeCallback):
2538         (WTR::TestRunner::installWillEndSwipeCallback):
2539         (WTR::TestRunner::installDidEndSwipeCallback):
2540         (WTR::TestRunner::installDidRemoveSwipeSnapshotCallback):
2541         (WTR::TestRunner::callDidBeginSwipeCallback):
2542         (WTR::TestRunner::callWillEndSwipeCallback):
2543         (WTR::TestRunner::callDidEndSwipeCallback):
2544         (WTR::TestRunner::callDidRemoveSwipeSnapshotCallback):
2545         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2546         * WebKitTestRunner/TestController.cpp:
2547         (WTR::TestController::createOtherPage):
2548         (WTR::TestController::createWebViewWithOptions):
2549         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2550         (WTR::TestController::didBeginNavigationGesture):
2551         (WTR::TestController::willEndNavigationGesture):
2552         (WTR::TestController::didEndNavigationGesture):
2553         (WTR::TestController::didRemoveNavigationGestureSnapshot):
2554         * WebKitTestRunner/TestController.h:
2555         * WebKitTestRunner/TestInvocation.cpp:
2556         (WTR::TestInvocation::didBeginSwipe):
2557         (WTR::TestInvocation::willEndSwipe):
2558         (WTR::TestInvocation::didEndSwipe):
2559         (WTR::TestInvocation::didRemoveSwipeSnapshot):
2560         * WebKitTestRunner/TestInvocation.h:
2561         Add callbacks when navigation gestures didBegin/willEnd/didEnd, and
2562         when the snapshot is removed.
2563
2564         Add swipeGestureWithWheelAndMomentumPhases, just like the equivalent
2565         mouseScrollBy function.
2566
2567         * WebKitTestRunner/mac/EventSenderProxy.mm:
2568         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
2569         (-[EventSenderSyntheticEvent type]):
2570         (-[EventSenderSyntheticEvent subtype]):
2571         (-[EventSenderSyntheticEvent locationInWindow]):
2572         (-[EventSenderSyntheticEvent location]):
2573         (-[EventSenderSyntheticEvent momentumPhase]):
2574         (-[EventSenderSyntheticEvent _isTouchesEnded]):
2575         (-[EventSenderSyntheticEvent _cgsEventRecord]):
2576         Rename EventSenderPressureEvent to EventSenderSyntheticEvent and add some
2577         more adjustable values.
2578
2579         (WTR::EventSenderProxy::mouseForceDown):
2580         (WTR::EventSenderProxy::mouseForceUp):
2581         (WTR::EventSenderProxy::mouseForceChanged):
2582         Adopt EventSenderSyntheticEvent.
2583
2584         (WTR::nsEventPhaseFromCGEventPhase):
2585         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
2586         Make use of EventSenderSyntheticEvent to synthesize swipe gesture events.
2587
2588         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2589         (WTR::PlatformWebView::PlatformWebView):
2590         Enable swipe.
2591
2592 2015-09-03  Myles C. Maxfield  <mmaxfield@apple.com>
2593
2594         [WK2] Allow tagging tests with metadata which needs to be known at web process creation time
2595         https://bugs.webkit.org/show_bug.cgi?id=148723
2596
2597         Reviewed by Anders Carlsson.
2598
2599         * WebKitTestRunner/TestController.cpp:
2600         (WTR::testPath):
2601         (WTR::updateViewOptionsFromTestHeader):
2602         (WTR::TestController::viewOptionsForTest):
2603
2604 2015-09-03  Lucas Forschler  <lforschler@apple.com>
2605
2606         Test commit.
2607
2608 2015-09-02  Tim Horton  <timothy_horton@apple.com>
2609
2610         Add a modern API way to know that the navigation gesture snapshot was removed, for WebKitTestRunner
2611         https://bugs.webkit.org/show_bug.cgi?id=148693
2612
2613         Reviewed by Anders Carlsson.
2614
2615         * WebKitTestRunner/TestController.cpp:
2616         (WTR::TestController::createOtherPage):
2617         (WTR::TestController::createWebViewWithOptions):
2618
2619 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2620
2621         REGRESSION(r188548): Some tests crash after r188548 because injected bundle messages are received after the test finishes
2622         https://bugs.webkit.org/show_bug.cgi?id=148529
2623
2624         Reviewed by Darin Adler.
2625
2626         When there are pending EventSender messages after a test finishes,
2627         they could be processed in the main loop started by the
2628         resetStateToConsistentValues(), but the old EventSender has been
2629         replaced by a new one at that point. The new Eventsender can crash
2630         when processing messages that were sent to the old one. To avoid
2631         this, we return early when receiving an EventSender message and
2632         the TestController state is not RunningTest.
2633
2634         * WebKitTestRunner/TestController.cpp:
2635         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
2636         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2637
2638 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2639
2640         REGRESSION(r188548): TestController state is Resseting while tests are running after r188548
2641         https://bugs.webkit.org/show_bug.cgi?id=148528
2642
2643         Reviewed by Darin Adler.
2644
2645         Before r188548 resetStateToConsistentValues() was called in
2646         TestController::run(), before tests are run, but now it's called
2647         for every test in TestInvocation::invoke(), after m_status has
2648         changed to RunningTest.
2649
2650         * WebKitTestRunner/TestController.cpp:
2651         (WTR::TestController::resetStateToConsistentValues): Use
2652         TemporaryChange to reset m_state ot its previous value after reset
2653         is done.
2654
2655 2015-08-31  Jason Marcell  <jmarcell@apple.com>
2656
2657         Modify prepare-Changelog to be aware of files that are marked as tests as well as files
2658         that are marked as requiring corresponding tests.
2659         https://bugs.webkit.org/show_bug.cgi?id=148498
2660         <rdar://problem/21555314>
2661
2662         Reviewed by Dan Bernstein and David Kilzer.
2663
2664         * Scripts/prepare-ChangeLog: Added "attributeCache" to cache Subversion properties in order to
2665         simulate Git's attribute behevaior.
2666         (main): Added "requiresTests" array to contain files that require tests.
2667         (generateNewChangeLogs): Checks "requiresTests" array to determine whether to inject "tests"
2668         section in ChangeLog.
2669         (attributeCommand): Queries a given file for a given Git attribute value. If using Subversion,
2670         however, we check if the file or any containing folder has the given property set to "1" and
2671         return 1 if so; return 0 otherwise.
2672         (generateFileList): Adds files to "requiresTests" array if Git attribute is set to "1". Also
2673         adds files to "addedRegressionTests" array if "test" attribute is set to "1".
2674
2675 2015-08-26  Andy Estes  <aestes@apple.com>
2676
2677         [Content Filtering] Determine navigation and content policy before continuing to filter a load
2678         https://bugs.webkit.org/show_bug.cgi?id=148506
2679
2680         Reviewed by Brady Eidson.
2681
2682         Added download API tests covering every decision and decision point.
2683         Removed _WKDownload.AsynchronousDownloadPolicy in favor of these new tests.
2684
2685         * TestWebKitAPI/Configurations/Base.xcconfig: Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to the header search path.
2686         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Removed it from here.
2687         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
2688         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): Called -valueForKeyPath:, which
2689         returns an id, instead of -valueForKey:, which always returns an NSString even if the object is of another type.
2690         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added a class that can send a MockContentFilter
2691         decision and decision point as a bundle parameter.
2692         (+[MockContentFilterEnabler supportsSecureCoding]):
2693         (-[MockContentFilterEnabler copyWithZone:]):
2694         (-[MockContentFilterEnabler initWithCoder:]):
2695         (-[MockContentFilterEnabler initWithDecision:decisionPoint:]):
2696         (-[MockContentFilterEnabler encodeWithCoder:]):
2697         (configurationWithContentFilterSettings): Added a helper function to create a WKWebViewConfiguration with MockConentFilter settings.
2698         (TEST): Renamed ContentFiltering.ServerRedirect to ContentFiltering.URLAfterServerRedirect.
2699         (-[BecomeDownloadDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Decided _WKNavigationResponsePolicyBecomeDownload.
2700         (-[BecomeDownloadDelegate webView:didFailProvisionalNavigation:withError:]): Set isDone to true.
2701         (-[BecomeDownloadDelegate webView:didFinishNavigation:]): Ditto.
2702         (-[ContentFilteringDownloadDelegate _downloadDidStart:]): Set downloadDidStart to true.
2703         (downloadTest): Added a helper function to test downloads with a given decision and decision point.
2704         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added a corresponding bundle class that decodes
2705         the MockContentFilter decision and decision point, and sets these values in the MockContentFilterSettings
2706         singleton. This class is duplicated in the bundle to prevent TestWebKitAPI from having to link to WebCoreTestSupport.
2707         (+[MockContentFilterEnabler supportsSecureCoding]):
2708         (-[MockContentFilterEnabler copyWithZone:]):
2709         (-[MockContentFilterEnabler initWithCoder:]):
2710         (-[MockContentFilterEnabler dealloc]):
2711         (-[MockContentFilterEnabler encodeWithCoder:]):
2712         (-[ContentFilteringPlugIn webProcessPlugIn:initializeWithObject:]): Start observing changes to the MockContentFilterEnabler key path.
2713         (-[ContentFilteringPlugIn dealloc]): Stop observing.
2714         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]): Store a MockContentFilterEnabler in _contentFilterEnabler.
2715         (+[ServerRedirectPlugIn initialize]): Deleted.
2716         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2717         (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2718         (-[AsynchronousDownloadDelegate _downloadDidStart:]): Deleted.
2719         (TEST): Deleted.
2720
2721 2015-08-31  Filip Pizlo  <fpizlo@apple.com>
2722
2723         Skip slow lock tests on Windows/debug
2724         https://bugs.webkit.org/show_bug.cgi?id=148643
2725
2726         Reviewed by Alexey Proskuryakov.
2727
2728         The lock tests simulate a critical section by doing some floating point math, and then either
2729         make those critical sections very long or invoke them many times. This appears to be
2730         particularly slow on Windows in debug mode, maybe because Visual Studio's debug build makes
2731         that kind of computation slow.
2732
2733         These tests are almost as useful in release as they are in debug, so it's probably better to
2734         just skip the in debug on platforms where this causes timeouts.
2735
2736         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2737         (TestWebKitAPI::runLockTest):
2738         (TestWebKitAPI::skipSlow):
2739         (TestWebKitAPI::TEST):
2740
2741 2015-08-29  Chris Fleizach  <cfleizach@apple.com>
2742
2743         AX: When navigating the elements of a scrollable element with VoiceOver, the scrollTop() position of the element does not permanently change
2744         https://bugs.webkit.org/show_bug.cgi?id=125720
2745
2746         Reviewed by Daniel Bates.
2747
2748         Add support for scrollToMakeVisibleWithSubFocus and scrollToGlobalPoint.
2749
2750         * DumpRenderTree/AccessibilityUIElement.cpp:
2751         (pressCallback):
2752         (scrollToMakeVisibleWithSubFocusCallback):
2753         (scrollToGlobalPointCallback):
2754         (scrollToMakeVisibleCallback):
2755         (AccessibilityUIElement::getJSClass):
2756         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2757         (AccessibilityUIElement::scrollToMakeVisible):
2758         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2759         (AccessibilityUIElement::scrollToGlobalPoint):
2760         (AccessibilityUIElement::selectedTextRange):
2761         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2762         (AccessibilityUIElement::AccessibilityUIElement):
2763         (AccessibilityUIElement::mathPrescriptsDescription):
2764         (AccessibilityUIElement::scrollToMakeVisible):
2765         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2766         (AccessibilityUIElement::scrollToGlobalPoint):
2767         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2768         (WTR::AccessibilityUIElement::isTextMarkerValid):
2769         (WTR::AccessibilityUIElement::textMarkerForIndex):
2770         (WTR::AccessibilityUIElement::scrollToMakeVisible):
2771         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
2772         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2773         (WTR::AccessibilityUIElement::supportedActions):
2774         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
2775         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
2776         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2777         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2778         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2779         (WTR::AccessibilityUIElement::scrollToMakeVisible):
2780         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
2781         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2782         (WTR::AccessibilityUIElement::selectedTextRange):
2783         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2784         (WTR::AccessibilityUIElement::scrollToMakeVisible):
2785         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
2786         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2787         (WTR::AccessibilityUIElement::selectedTextRange):
2788
2789 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
2790
2791         Add a mysteriously nonproblematic missing comma.
2792
2793         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2794         (TestExpectationParser._collect_matching_tests):
2795         (TestExpectationParser):
2796
2797 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
2798
2799         Remove an old temporary script that has served its purpose
2800
2801         * Scripts/convert-test-expectations: Removed.
2802
2803 2015-08-28  Jer Noble  <jer.noble@apple.com>
2804
2805         [iOS] Add WebKit/WebKit2 settings to control automatic data loading
2806         https://bugs.webkit.org/show_bug.cgi?id=148579
2807
2808         Reviewed by Anders Carlsson.
2809
2810         In DumpRenderTree, set the new mediaDataLoadsAutomatically preference to YES.
2811
2812         In WebKitTestRunner, do the same for the new _mediaDataLoadsAutomatically configuration property,
2813         and also set the existing requiresUserActionForMediaPlayback configuration property to NO.
2814
2815         * DumpRenderTree/mac/DumpRenderTree.mm:
2816         (resetWebPreferencesToConsistentValues):
2817         (resetWebViewToConsistentStateBeforeTesting): 
2818         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2819         (WTR::initializeWebViewConfiguration):
2820
2821 2015-08-28  Alexey Proskuryakov  <ap@apple.com>
2822
2823         Fix run-webkit-tests --additional-env-var="DYLD_INSERT_LIBRARIES=..."
2824         https://bugs.webkit.org/show_bug.cgi?id=148592
2825
2826         Reviewed by Tim Horton.
2827
2828         * Scripts/webkitpy/port/base.py:
2829         (Port.to.setup_environ_for_server):
2830         (Port.to):
2831         (Port.to._append_value_colon_separated):
2832         (Port.to.show_results_html_file):
2833         * Scripts/webkitpy/port/ios.py:
2834         (IOSSimulatorPort.setup_environ_for_server):
2835         * Scripts/webkitpy/port/mac.py:
2836         (MacPort.setup_environ_for_server):
2837
2838 2015-08-28  Filip Pizlo  <fpizlo@apple.com>
2839
2840         LICM should be sound even if the CFG has changed
2841         https://bugs.webkit.org/show_bug.cgi?id=148259
2842
2843         Reviewed by Benjamin Poulain.
2844
2845         Add a utility for creating tests that set some uncommon option.
2846
2847         * Scripts/run-jsc-stress-tests:
2848
2849 2015-08-28  Brent Fulgham  <bfulgham@apple.com>
2850
2851         [Win] Unreviewed EWS correction.
2852
2853         * EWSTools/start-queue-win.sh: Update settings to point to VS2015.
2854
2855 2015-08-28  Jer Noble  <jer.noble@apple.com>
2856
2857         [iOS] Make the AllowsInlineMediaPlayback preference work in WebKit / WebKit2.
2858         https://bugs.webkit.org/show_bug.cgi?id=147512
2859
2860         Reviewed by Anders Carlsson.
2861
2862         Set the value of WebKitAllowsInlineMediaPlayback / WKPreferencesSetMediaPlaybackAllowsInline()
2863         to a consistent (true) value.
2864
2865         * DumpRenderTree/mac/DumpRenderTree.mm:
2866         (setDefaultsToConsistentValuesForTesting):
2867         * WebKitTestRunner/TestController.cpp:
2868         (WTR::TestController::resetPreferencesToConsistentValues):
2869
2870 2015-08-28  Tim Horton  <timothy_horton@apple.com>
2871
2872         Add navigation gesture callbacks to WKPageNavigationClient
2873         https://bugs.webkit.org/show_bug.cgi?id=148568
2874         <rdar://problem/22371346>
2875
2876         Reviewed by Anders Carlsson.
2877
2878         * WebKitTestRunner/TestController.cpp:
2879         (WTR::TestController::createOtherPage):
2880         (WTR::TestController::createWebViewWithOptions):
2881         Add some zeroes.
2882
2883 2015-08-28  Alexey Proskuryakov  <ap@apple.com>
2884
2885         [Mac] kill-old-processes should kill more processes
2886         https://bugs.webkit.org/show_bug.cgi?id=148577
2887
2888         Reviewed by Tim Horton.
2889
2890         * BuildSlaveSupport/kill-old-processes:
2891
2892 2015-08-28  Jason Marcell  <jmarcell@apple.com>
2893
2894         The status message for combined builder queues should say "all builds succeeded" if everything
2895         built correctly.
2896         https://bugs.webkit.org/show_bug.cgi?id=148535
2897
2898         Reviewed by David Kilzer and Alexey Proskuryakov.
2899
2900         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
2901         (BuildbotCombinedQueueView.prototype.update): Make status message for combined builder queues
2902         say "all builds succeeded" if everything built correctly.
2903
2904 2015-08-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2905
2906         [GTK] Simplify the internal API to create a WebView
2907         https://bugs.webkit.org/show_bug.cgi?id=148570
2908
2909         Reviewed by Žan Doberšek.
2910
2911         * TestWebKitAPI/PlatformWebView.h: Add initialize method for GTK+ too.
2912         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
2913         (TestWebKitAPI::PlatformWebView::PlatformWebView): Implement all
2914         PlatformWebView constructors that end up calling initialize with a PageConfiguration.
2915         (TestWebKitAPI::PlatformWebView::initialize): Create the WebView
2916         passing the received PageConfiguration.
2917         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2918         (WTR::PlatformWebView::PlatformWebView): Create the WebView
2919         passing the received PageConfiguration.
2920
2921 2015-08-27  Aakash Jain  <aakash_jain@apple.com>
2922
2923         iOS Simulator API tests fails as Simulator is not running
2924         https://bugs.webkit.org/show_bug.cgi?id=148501
2925         rdar://problem/22447525
2926
2927         Reviewed by Daniel Bates.
2928
2929         This change is a workaround for <rdar://problem/22388812>.
2930
2931          * Scripts/run-api-tests: Launch the iOS Simulator before starting the API Tests
2932          and quit it on program termination when running tests on the iOS port.
2933          * Scripts/webkitdirs.pm: Store string "For WebKit Development" in constant
2934          SIMULATOR_DEVICE_SUFFIX_FOR_WEBKIT_DEVELOPMENT to make it consistently reusable.
2935
2936 2015-08-27  Alex Christensen  <achristensen@webkit.org>
2937
2938         Make DLLLauncherMain executables dependent on dll
2939         https://bugs.webkit.org/show_bug.cgi?id=148548
2940
2941         Reviewed by Brent Fulgham.
2942
2943         * DumpRenderTree/CMakeLists.txt:
2944         * DumpRenderTree/PlatformWin.cmake:
2945         * MiniBrowser/win/CMakeLists.txt:
2946         * TestWebKitAPI/CMakeLists.txt:
2947         * TestWebKitAPI/PlatformWin.cmake:
2948
2949 2015-08-27  Lucas Forschler  <lforschler@apple.com>
2950
2951         Remove Mac slaves 188/189 after being replaced with 400/401.
2952         
2953         Unreviewed.
2954         
2955         * BuildSlaveSupport/build.webkit.org-config/config.json:
2956
2957 2015-08-27  Lucas Forschler  <lforschler@apple.com>
2958
2959         Add two bots to the Mac Yosemite queue.
2960         This is to eventually replace bots188/189, which will be removed after 400/401 are vetted.
2961         
2962         Unreviewed.
2963         
2964         * BuildSlaveSupport/build.webkit.org-config/config.json:
2965
2966 2015-08-27  Alex Christensen  <achristensen@webkit.org>
2967
2968         [Win CMake] Fix incremental build after r188673
2969         https://bugs.webkit.org/show_bug.cgi?id=148539
2970
2971         Reviewed by Brent Fulgham.
2972
2973         * TestWebKitAPI/PlatformWin.cmake:
2974         Copy forwarding headers from WebCore before building in case that was not yet done.
2975         It used to be done when running CMake, but now it's a build step.
2976
2977 2015-08-27  Nan Wang  <n_wang@apple.com>
2978
2979         AX: Fix accessibility/select-element-at-index.html test
2980         https://bugs.webkit.org/show_bug.cgi?id=148516
2981
2982         Reviewed by Chris Fleizach.
2983
2984         Implemented setSelectedChildAtIndex and removeSelectionAtIndex for mac.
2985
2986         * DumpRenderTree/AccessibilityUIElement.cpp:
2987         (setSelectedChildCallback):
2988         (setSelectedChildAtIndexCallback):
2989         (removeSelectionAtIndexCallback):
2990         (elementAtPointCallback):
2991         (sentenceAtOffsetCallback):
2992         (stringForSelectionCallback):
2993         (AccessibilityUIElement::getJSClass):
2994         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2995         (AccessibilityUIElement::setSelectedChild):
2996         (AccessibilityUIElement::setSelectedChildAtIndex):
2997         (AccessibilityUIElement::removeSelectionAtIndex):
2998         (AccessibilityUIElement::accessibilityValue):
2999         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3000         (WTR::AccessibilityUIElement::wordAtOffset):
3001         (WTR::AccessibilityUIElement::lineAtOffset):
3002         (WTR::AccessibilityUIElement::sentenceAtOffset):
3003         (WTR::AccessibilityUIElement::isSelectable):
3004         (WTR::AccessibilityUIElement::isMultiSelectable):
3005         (WTR::AccessibilityUIElement::setSelectedChild):
3006         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
3007         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
3008         (WTR::AccessibilityUIElement::selectedChildrenCount):
3009         (WTR::AccessibilityUIElement::selectedChildAtIndex):
3010         (WTR::AccessibilityUIElement::isExpanded):
3011         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3012         (WTR::AccessibilityUIElement::setSelectedChild):
3013         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
3014         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
3015         (WTR::AccessibilityUIElement::accessibilityValue):
3016
3017 2015-08-27  Alex Christensen  <achristensen@webkit.org>
3018
3019         Build fix after r188982
3020
3021         * MiniBrowser/win/CMakeLists.txt:
3022         The directory structure changed in the move.
3023
3024 2015-08-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3025
3026         [GTK] Unreviewed, install-dependencies should install geoclue2 on Fedora
3027
3028         geoclue-devel is for obsolete geoclue. Install geoclue2-devel instead.
3029
3030         * gtk/install-dependencies:
3031
3032 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3033
3034         Unreviewed. Mark WTF_WordLock.ContendedShortSection as slow too.
3035
3036         * Scripts/run-gtk-tests:
3037         (TestRunner):
3038
3039 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3040
3041         Fix GTK+ WTR crashes in initializeMainRunLoop()
3042
3043         Rubber-stamped by Žan Doberšek.
3044
3045         Initialize threading and main thread before
3046         RunLoop::initializeMainRunLoop(), since the GLib implementation of
3047         the RunLoop uses isMainThread() to decide whether to create a new
3048         GMainContext or use the default one. Also use RunLoop::run() and
3049         ::stop() instead of gtk_main/quit.
3050
3051         * WebKitTestRunner/TestController.cpp:
3052         (WTR::TestController::initialize):
3053         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3054         (WTR::TestController::notifyDone):
3055         (WTR::TestController::platformRunUntil):
3056
3057 2015-08-27  Filip Pizlo  <fpizlo@apple.com>
3058
3059         Unreviewed, further shorten a test that times out because it's very long
3060         running.
3061
3062         I've locally run these tests on repeat for 24 hours and found no genuine
3063         failures, like deadlocks. So, the timeouts are probably because the test
3064         machine is slow and debug is slow. We should just run this test for fewer
3065         iterations.
3066
3067         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3068         (TestWebKitAPI::TEST):
3069
3070 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
3071
3072         Unreviewed build fix attempt on EFL
3073
3074         * WebKitTestRunner/PlatformEfl.cmake:
3075
3076 2015-08-26  Alex Christensen  <achristensen@webkit.org>
3077
3078         Build fix after r188982
3079
3080         * MiniBrowser/win/CMakeLists.txt:
3081         Find .rc files in correct directory.
3082
3083 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
3084
3085         [EFL] Bump cairo version to 1.14.2
3086         https://bugs.webkit.org/show_bug.cgi?id=148474
3087
3088         Reviewed by Csaba Osztrogonác.
3089
3090         * efl/jhbuild.modules:
3091
3092 2015-08-26  Andy Estes  <aestes@apple.com>
3093
3094         Crash when following a Google search link to Twitter with Limit Adult Content enabled
3095         https://bugs.webkit.org/show_bug.cgi?id=147651
3096
3097         Rubber-stamped by Brady Eidson.
3098
3099         Taught TestRunner how to decide the navigation policy after a delay.
3100
3101         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3102         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3103         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
3104         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3105         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
3106         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3107         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
3108         * WebKitTestRunner/TestController.cpp:
3109         (WTR::TestController::initialize):
3110         (WTR::TestController::resetStateToConsistentValues):
3111         (WTR::TestController::decidePolicyForNavigationAction):
3112         * WebKitTestRunner/TestController.h:
3113         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
3114         * WebKitTestRunner/TestInvocation.cpp:
3115         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3116
3117 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
3118
3119         [Win] Rename 'WinLauncher' to 'MiniBrowser'
3120         https://bugs.webkit.org/show_bug.cgi?id=148485
3121
3122         Reviewed by Alex Christensen
3123
3124         Move the WinLauncher project and source files to a subdirectory
3125         of MiniBrowser. Globally change WinLauncher -> MiniBrowser in the
3126         source code and project files.
3127         
3128         * MiniBrowser/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj.
3129         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.ico.
3130         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.rc.
3131         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.
3132         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters.
3133         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCF.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props.
3134         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCFLite.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props.
3135         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props.
3136         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props.
3137         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc.
3138         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.
3139         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters.
3140         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props.
3141         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props.
3142         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd.
3143         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd.
3144         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props.
3145         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props.
3146         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h.
3147         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd.
3148         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd.
3149         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props.
3150         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props.
3151         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h.
3152         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.ico: Removed.
3153         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.rc: Removed.
3154         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj: Removed.
3155         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj.filters: Removed.
3156         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCF.props: Removed.
3157         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCFLite.props: Removed.
3158         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCommon.props: Removed.
3159         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherDebug.props: Removed.
3160         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.rc: Removed.
3161         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj: Removed.
3162         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
3163         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibCommon.props: Removed.
3164         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibDebug.props: Removed.
3165         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
3166         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
3167         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibProduction.props: Removed.
3168         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibRelease.props: Removed.
3169         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibResource.h: Removed.
3170         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPostBuild.cmd: Removed.
3171         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPreBuild.cmd: Removed.
3172         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherProduction.props: Removed.
3173         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherRelease.props: Removed.
3174         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherResource.h: Removed.
3175         * MiniBrowser/win: Copied from WinLauncher.
3176         * MiniBrowser/win/Common.cpp:
3177         * MiniBrowser/win/MiniBrowser.cpp: Copied from WinLauncher/WinLauncher.cpp.
3178         * MiniBrowser/win/MiniBrowser.h: Copied from WinLauncher/WinLauncher.h.
3179         * MiniBrowser/win/MiniBrowserReplace.h: Copied from WinLauncher/WinLauncherReplace.h.
3180         * MiniBrowser/win/MiniBrowserWebHost.cpp: Copied from WinLauncher/WinLauncherWebHost.cpp.
3181         * MiniBrowser/win/MiniBrowserWebHost.h: Copied from WinLauncher/WinLauncherWebHost.h.
3182         * MiniBrowser/win/PageLoadTestClient.cpp:
3183         * MiniBrowser/win/PageLoadTestClient.h:
3184         * MiniBrowser/win/ResourceLoadDelegate.cpp:
3185         * MiniBrowser/win/ResourceLoadDelegate.h:
3186         * MiniBrowser/win/WinLauncher.cpp: Removed.
3187         * MiniBrowser/win/WinLauncher.h: Removed.
3188         * MiniBrowser/win/WinLauncher.vcxproj: Removed.
3189         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.ico: Removed.
3190         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.rc: Removed.
3191         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
3192         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
3193         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
3194         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
3195         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
3196         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
3197         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
3198         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
3199         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
3200         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
3201         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
3202         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
3203         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
3204         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
3205         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
3206         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
3207         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
3208         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
3209         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
3210         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
3211         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
3212         * MiniBrowser/win/WinLauncher.vcxproj/small.ico: Removed.
3213         * MiniBrowser/win/WinLauncherReplace.h: Removed.
3214         * MiniBrowser/win/WinLauncherWebHost.cpp: Removed.
3215         * MiniBrowser/win/WinLauncherWebHost.h: Removed.
3216         * MiniBrowser/win/WinMain.cpp:
3217         * WinLauncher: Removed.
3218         * WinLauncher/AccessibilityDelegate.cpp: Removed.
3219         * WinLauncher/AccessibilityDelegate.h: Removed.
3220         * WinLauncher/CMakeLists.txt: Removed.
3221         * WinLauncher/Common.cpp: Removed.
3222         * WinLauncher/DOMDefaultImpl.cpp: Removed.
3223         * WinLauncher/DOMDefaultImpl.h: Removed.
3224         * WinLauncher/PageLoadTestClient.cpp: Removed.
3225         * WinLauncher/PageLoadTestClient.h: Removed.
3226         * WinLauncher/PrintWebUIDelegate.cpp: Removed.
3227         * WinLauncher/PrintWebUIDelegate.h: Removed.
3228         * WinLauncher/ResourceLoadDelegate.cpp: Removed.
3229         * WinLauncher/ResourceLoadDelegate.h: Removed.
3230         * WinLauncher/WebDownloadDelegate.cpp: Removed.
3231         * WinLauncher/WebDownloadDelegate.h: Removed.
3232         * WinLauncher/WinLauncher.cpp: Removed.
3233         * WinLauncher/WinLauncher.h: Removed.
3234         * WinLauncher/WinLauncher.vcxproj: Removed.
3235         * WinLauncher/WinLauncher.vcxproj/WinLauncher.ico: Removed.
3236         * WinLauncher/WinLauncher.vcxproj/WinLauncher.rc: Removed.
3237         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
3238         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
3239         * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
3240         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
3241         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
3242         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
3243         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
3244         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
3245         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
3246         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
3247         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
3248         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
3249         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
3250         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
3251         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
3252         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
3253         * WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
3254         * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
3255         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
3256         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
3257         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
3258         * WinLauncher/WinLauncher.vcxproj/small.ico: Removed.
3259         * WinLauncher/WinLauncherReplace.h: Removed.
3260         * WinLauncher/WinLauncherWebHost.cpp: Removed.
3261         * WinLauncher/WinLauncherWebHost.h: Removed.
3262         * WinLauncher/WinMain.cpp: Removed.
3263         * WinLauncher/resource.h: Removed.
3264         * WinLauncher/stdafx.cpp: Removed.
3265         * WinLauncher/stdafx.h: Removed.
3266         * win/AssembleBuildLogs/AssembleLogs.cmd:
3267
3268 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
3269
3270         [Win] Simplify menu handling code in WinLauncher
3271         https://bugs.webkit.org/show_bug.cgi?id=148461
3272
3273         Reviewed by Zalan Bujtas.
3274
3275         Revise 'ToggleMenuItem' to return a boolean value indicating if
3276         it handled the message. Revise WndProc to use this to decide if it
3277         should pass the message on to the default handler, rather than
3278         duplicating the logic in both places.
3279         
3280         * WinLauncher/Common.cpp:
3281         (ToggleMenuItem): Return true if the menu item message was handled.
3282         (WndProc): If 'ToggleMenuItem' did not handle the message, pass
3283         the message tothe default handler.
3284
3285 2015-08-26  Csaba Osztrogonác  <ossy@webkit.org>
3286
3287         Remove unused code after r188948
3288         https://bugs.webkit.org/show_bug.cgi?id=148467
3289
3290         Reviewed by Gyuyoung Kim.
3291
3292         * WebKitTestRunner/TestController.cpp:
3293         (WTR::TestController::platformPreferences): Deleted.
3294
3295 2015-08-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3296
3297         [EFL][GTK] REGRESSION(r188828): All performance tests and almost all layout tests crash
3298         https://bugs.webkit.org/show_bug.cgi?id=148377
3299
3300         Reviewed by Carlos Garcia Campos.
3301
3302         EFL and GTK don't support TestController::platformPreferences() yet which was introduced by r188828.
3303         It caused all crashes of layout test and performance test on EFL and GTK. So this patch implements
3304         TestController::platformPreferences() using WKPageGroupGetPreferences() which was previous thing for
3305         EFL and GTK at the moment.
3306
3307         * WebKitTestRunner/TestController.cpp:
3308         (WTR::TestController::platformWillRunTest):
3309         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3310         (WTR::TestController::platformPreferences):
3311         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3312         (WTR::TestController::platformPreferences):
3313
3314 2015-08-25  Nan Wang  <n_wang@apple.com>
3315
3316         AX: Enable accessibility/aria-controls.html test for mac
3317         https://bugs.webkit.org/show_bug.cgi?id=148458
3318
3319         Reviewed by Chris Fleizach.
3320
3321         Implemented ariaControlsElementAtIndex(unsigned index).
3322
3323         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3324         (AccessibilityUIElement::ariaControlsElementAtIndex):
3325         (AccessibilityUIElement::disclosedRowAtIndex):
3326         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3327         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
3328
3329 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3330
3331         Remove python tests for PassRefPtr 
3332         https://bugs.webkit.org/show_bug.cgi?id=148463
3333
3334         Reviewed by Andy Estes.
3335
3336         As we're removing uses of PassRefPtr, we need to remove all python tests for PassRefPtr as well.
3337
3338         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3339         (PassPtrTest): Deleted.
3340         (PassPtrTest.assert_pass_ptr_check): Deleted.
3341         (PassPtrTest.test_pass_ref_ptr_in_function): Deleted.
3342         (PassPtrTest.test_pass_other_type_ptr_in_function): Deleted.
3343         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
3344         (PassPtrTest.test_ref_ptr_parameter_value): Deleted.
3345         (PassPtrTest.test_ref_ptr_member_variable): Deleted.
3346         (PassPtrTest.test_ref_ptr_member_variable.Foo): Deleted.
3347
3348 2015-08-25  Andy Estes  <aestes@apple.com>
3349
3350         [iOS] run-webkit-tests fails if watchOS SDK is installed
3351         https://bugs.webkit.org/show_bug.cgi?id=148453
3352
3353         Reviewed by David Kilzer.
3354
3355         * Scripts/webkitpy/xcode/simulator.py:
3356         (Simulator): Taught Simulator how to parse watchOS runtimes and devices.
3357         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
3358
3359 2015-08-25  Aakash Jain  <aakash_jain@apple.com>
3360
3361         iOS Simulator layout-tests fail to start while cleaning a directory structure if simulator is already running
3362         https://bugs.webkit.org/show_bug.cgi?id=148197
3363         rdar://problem/22334382
3364
3365         Reviewed by Daniel Bates.
3366
3367         * BuildSlaveSupport/kill-old-processes: Add Simulator to the list of processes to kill (for iOS builders).
3368         * Scripts/webkitpy/port/ios.py:
3369         (IOSSimulatorPort): Converted bundle id com.apple.iphonesimulator to a variable SIMULATOR_BUNDLE_ID.
3370         (IOSSimulatorPort._quitIOSSimulator): Common function to quit iOS Simulator.
3371         (IOSSimulatorPort.clean_up_test_run): Quit the simulator during the cleanup.
3372         (IOSSimulatorPort.check_sys_deps): No need to quit the simulator here as its now being quit in reset_preferences().
3373         (IOSSimulatorPort.reset_preferences): Quit the simulator before trying to delete associated data directory.
3374
3375 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3376
3377         Remove PassRefPtr style check rule
3378         https://bugs.webkit.org/show_bug.cgi?id=148432
3379
3380         Reviewed by Andreas Kling.
3381
3382         PassRefPtr is being removed. Thus style rule needs to be removed as well.
3383
3384         * Scripts/webkitpy/style/checkers/cpp.py:
3385         (_check_parameter_name_against_text): Deleted.
3386         (check_function_definition_and_pass_ptr): Deleted.
3387         (check_function_definition): Deleted.
3388         (check_pass_ptr_usage): Deleted.
3389         (process_line): Deleted.
3390         (CppChecker): Deleted.
3391
3392 2015-08-25  Brent Fulgham  <bfulgham@apple.com>
3393
3394         [Win] Expose "Inverted Colors" option in WinLauncher
3395         https://bugs.webkit.org/show_bug.cgi?id=148451
3396
3397         Reviewed by Tim Horton.
3398
3399         Add the ability to toggle the "Inverted Colors" preference
3400         in WinLauncher.
3401         
3402         * WinLauncher/Common.cpp:
3403         (ToggleMenuItem): Toggle the feature when the menu item
3404         is selected.
3405         (WndProc): Recognize the new menu option.
3406         * WinLauncher/WinLauncher.cpp:
3407         (WinLauncher::setToDefaultPreferences): Launch with "Invert
3408         Colors" turned off.
3409         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu
3410         entry for "Invert Colors".
3411         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
3412
3413 2015-08-25  Nan Wang  <n_wang@apple.com>
3414
3415         [Mac] accessibility/document-attributes.html fails
3416         https://bugs.webkit.org/show_bug.cgi?id=116636
3417
3418         Reviewed by Chris Fleizach.
3419
3420         Implemented documentURI() and documentEncoding().
3421
3422         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3423         (AccessibilityUIElement::documentEncoding):
3424         (AccessibilityUIElement::documentURI):
3425         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3426         (WTR::AccessibilityUIElement::documentEncoding):
3427         (WTR::AccessibilityUIElement::documentURI):
3428
3429 2015-08-24  Brent Fulgham  <bfulgham@apple.com>
3430
3431         [Win] Unreviewed test gardening.
3432
3433         Fix another case where the logging string is constructed using the variable 'frame',
3434         but the method argument is not given a name. This causes the global 'frame' value to
3435         be used, producing incorrect output.
3436
3437         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3438         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Use 'frame'
3439         argument.
3440
3441 2015-08-24  Tim Horton  <timothy_horton@apple.com>
3442
3443         (Finally...) get rid of WKViewIOS
3444         https://bugs.webkit.org/show_bug.cgi?id=148404
3445
3446         Reviewed by Anders Carlsson.
3447
3448         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
3449         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3450         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
3451         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
3452         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
3453         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
3454         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
3455         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
3456         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
3457         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
3458         Mark tests that use WKBrowsingContextController as Mac-only.
3459
3460         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
3461         (WTR::AccessibilityController::addNotificationListener):
3462         * WebKitTestRunner/ios/mainIOS.mm:
3463         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
3464         Import UIKit instead of depending on WKView.h to do so.
3465
3466 2015-08-24  Jason Marcell  <jmarcell@apple.com>
3467
3468         Add support to dashboard for displaying Git SHA's as revisions.
3469         https://bugs.webkit.org/show_bug.cgi?id=148387
3470
3471         Reviewed by Daniel Bates.
3472
3473         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3474         (parseRevisionProperty): Added support to dashboard for displaying Git SHA's as revisions.
3475         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3476         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
3477         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Added
3478         "isSVN" property to Dashboard.Repository.(OpenSource|Internal).
3479
3480 2015-08-24  Andy Estes  <aestes@apple.com>
3481
3482         REGRESSION (r188851): WebKit2.BundleParameters fails on iOS
3483
3484         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Specify LD_RUNPATH_SEARCH_PATHS correctly for iOS.
3485
3486 2015-08-23  Andy Estes  <aestes@apple.com>
3487
3488         Addressed a missed piece of review feedback from r188851.
3489
3490         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3491
3492 2015-08-23  Andy Estes  <aestes@apple.com>
3493
3494         [Content Filtering] REGRESSION (r182356): Provisional URL is incorrect in didReceiveServerRedirectForProvisionalLoadForFrame when Content Filtering is enabled
3495         https://bugs.webkit.org/show_bug.cgi?id=147872
3496         rdar://problem/22044000
3497
3498         Reviewed by Dan Bernstein.
3499         
3500         Added an API test.
3501
3502         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Linked libWebCoreTestSupport in order to use MockContentFilter.
3503         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3504         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added.
3505         (-[ServerRedirectNavigationDelegate webView:didStartProvisionalNavigation:]): Expect the initial request URL.
3506         (-[ServerRedirectNavigationDelegate webView:didReceiveServerRedirectForProvisionalNavigation:]): Expect the redirect URL.
3507         (-[ServerRedirectNavigationDelegate webView:didCommitNavigation:]):
3508         (TEST): Tested that -[WKWebView URL] is updated after a redirect when content filtering is enabled.
3509         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added.
3510         (+[ServerRedirectPlugIn initialize]): Enable MockContentFilter.
3511         * TestWebKitAPI/cocoa/TestProtocol.h: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.h.
3512         * TestWebKitAPI/cocoa/TestProtocol.mm: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.mm.
3513
3514 2015-08-23  Andy Estes  <aestes@apple.com>
3515
3516         Fixed the 32-bit Mac build after r188844.
3517
3518         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
3519         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
3520
3521 2015-08-22  Andy Estes  <aestes@apple.com>
3522
3523         [Cocoa] API tests using the Modern WebKit API should be able to create web process plug-ins
3524         https://bugs.webkit.org/show_bug.cgi?id=148317
3525
3526         Reviewed by Dan Bernstein.
3527
3528         Added the ability for Modern WebKit API tests to create WKWebProcessPlugIns. A test can create a plug-in by
3529         creating a class that conforms to WKWebProcessPlugIn, adding it to the WebProcessPlugIn target, and using the
3530         WKWebViewConfiguration returned by +[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]
3531         when creating WKWebViews.
3532
3533         Since TestWebKitAPI relies on a bundle parameter to know which test class to instantiate in the plug-in, I also
3534         added a new API test for bundle parameters.
3535
3536         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Added. Named the bundle TestWebKitAPI.wkbundle and
3537         named its executable TestWebKitAPI.bundle.
3538         * TestWebKitAPI/PlatformUtilities.h: Declared TestPlugInClassNameParameter.
3539         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added the WebProcessPlugIn target.
3540         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm: Added.
3541         (TEST): Tested bundle parameters by verifying that parameter changes in the UI process are observed in the bundle.
3542         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm: Added.
3543         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]): Started observing changes to a
3544         bundle parameter and asked for an initial notification.
3545         (-[BundleParametersPlugIn dealloc]): Stopped observing changes to a bundle parameter.
3546         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): When a bundle parameter changes,
3547         mirror its value in the main frame's JSContext.
3548         * TestWebKitAPI/WKWebViewConfigurationExtras.h: Added.
3549         * TestWebKitAPI/WKWebViewConfigurationExtras.mm: Added.
3550         (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Created a configuration with
3551         TestWebKitAPI's bundle URL and set a bundle parameter indicating the test plug-in's class name.
3552         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Defined TestPlugInClassNameParameter.
3553         * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added. Set the principal class to WebProcessPlugIn.
3554         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm: Added.
3555         (-[WebProcessPlugIn webProcessPlugIn:initializeWithObject:]): Forwarded to a newly-created test class instance.
3556         (-[WebProcessPlugIn respondsToSelector:]): Returned YES if the test class instance response.
3557         (-[WebProcessPlugIn forwardingTargetForSelector:]): Forwarded unimplemented methods to the test class instance.
3558
3559 2015-08-23  Csaba Osztrogonác  <ossy@webkit.org>
3560
3561         URTBF after r188828.
3562
3563         * WebKitTestRunner/PlatformWebView.h:
3564
3565 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
3566
3567         build.webkit.org/dashboard: Combined queues don't turn orange on internal failure
3568         https://bugs.webkit.org/show_bug.cgi?id=148356
3569
3570         Reviewed by Darin Adler.
3571
3572         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3573         (BuildbotCombinedQueueView.prototype.update):
3574
3575 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
3576
3577         build.webkit.org/dashboard: Respect step's hidden flag
3578         https://bugs.webkit.org/show_bug.cgi?id=148357
3579
3580         Reviewed by Darin Adler.
3581
3582         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3583         (BuildbotIteration.prototype._parseData):
3584
3585 2015-08-23  Nan Wang  <n_wang@apple.com>
3586
3587         AX: Fix accessibility/deleting-iframe-destroys-axcache.html test
3588         https://bugs.webkit.org/show_bug.cgi?id=148328
3589
3590         Reviewed by Darin Adler.
3591
3592         We should only expose stringValue() when value attribute is set.
3593
3594         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3595         (AccessibilityUIElement::stringValue):
3596         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3597         (WTR::AccessibilityUIElement::stringValue):
3598
3599 2015-08-23  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3600
3601         Remove style checking rule regarding OwnPtr and PassOwnPtr
3602         https://bugs.webkit.org/show_bug.cgi?id=148360
3603
3604         Reviewed by Darin Adler.
3605
3606         OwnPtr and PassOwnPtr were totally removed though, style rule is still alive.
3607         Removed it.
3608
3609         * Scripts/do-webcore-rename:
3610         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3611         (PassPtrTest.test_pass_own_ptr_in_function): Deleted.
3612         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
3613         (PassPtrTest.test_own_ptr_parameter_value): Deleted.
3614         (WebKitStyleTest.test_names): Deleted.
3615
3616 2015-08-22  Timothy Horton  <timothy_horton@apple.com>
3617
3618         WebKitTestRunner should use WKWebView on OS X and iOS
3619         https://bugs.webkit.org/show_bug.cgi?id=143743
3620         <rdar://problem/16947123>
3621
3622         Reviewed by Anders Carlsson.
3623         Patch by Enrica Casucci and myself.
3624
3625         * WebKitTestRunner/PlatformWebView.h:
3626         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
3627         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
3628         instead of WKContext and WKPageGroup.
3629
3630         Remove the unused, always-true windowSnapshotEnabled().
3631         While technically some platforms don't have window snapshotting,
3632         they just return null instead of implementing windowSnapshotEnabled().
3633
3634         * WebKitTestRunner/TestController.h:
3635         * WebKitTestRunner/TestController.cpp:
3636         (WTR::TestController::createOtherPage):
3637         (WTR::TestController::initialize):
3638         (WTR::TestController::createWebViewWithOptions):
3639         Delegate to the various platforms for creating PlatformWebView instances,
3640         for creating WKContexts, and for accessing WKPreferences,
3641         so that they can do special things (like, use WKWebView instead!).
3642
3643         (WTR::TestController::resetPreferencesToConsistentValues):
3644         Make explicit WebKitTestRunner's desired default for two preferences
3645         which have differing defaults between the antique and modern API,
3646         for consistency's sake.
3647
3648         (WTR::TestController::resetStateToConsistentValues):
3649         Add platformResetStateToConsistentValues.
3650
3651         * WebKitTestRunner/TestInvocation.cpp:
3652         (WTR::TestInvocation::dumpResults):
3653         Adjust to the aforementioned removal of windowSnapshotEnabled().
3654
3655         * WebKitTestRunner/ios/TestControllerCocoa.mm:
3656         (WTR::TestController::platformResetStateToConsistentValues):
3657         (WTR::TestController::platformPreferences):
3658         (WTR::TestController::platformCreateWebView):
3659         (WTR::TestController::platformCreateOtherPage):
3660         (WTR::TestController::platformInitializeConfiguration):
3661         Implement the new platform functions for the Modern WebKit2 API,
3662         in a new TestControllerCocoa file that is shared between iOS and Mac.
3663         
3664         For platformMaybeCreateContext, use the trick that we know we can cast
3665         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
3666         WKWebView's configuration.
3667
3668         Ditto for WKPreferencesRef and WKPreferences.
3669
3670         Remove user content filters on the WKWebView's userContentController.
3671
3672         * WebKitTestRunner/mac/TestControllerMac.mm:
3673         * WebKitTestRunner/ios/TestControllerIOS.mm:
3674         Move code into TestControllerCocoa.
3675
3676         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3677         (WTR::InjectedBundle::beginTesting):
3678         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3679         (WTR::TestRunner::addUserScript):
3680         (WTR::TestRunner::addUserStyleSheet):
3681         Adopt WKBundlePage API for user scripts/sheets.
3682
3683         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3684         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3685         Make and keep a WKWebView instead of a WKView.
3686         
3687         * WebKitTestRunner/mac/EventSenderProxy.mm:
3688         (WTR::EventSenderProxy::mouseUp):
3689         (WTR::EventSenderProxy::mouseMoveTo):
3690         Reach inside the WKWebView to the WKView when dispatching events.
3691         This is fairly ugly and we should come up with a better solution.
3692         Also, fix some flipping and style errors.
3693
3694 2015-08-22  Michael Catanzaro  <mcatanzaro@igalia.com>
3695
3696         Unreviewed, attempt to fix GTK build after r188718
3697
3698         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3699         (WTR::PlatformWebView::PlatformWebView):
3700
3701 2015-08-21  Commit Queue  <commit-queue@webkit.org>
3702
3703         Unreviewed, rolling out r188807, r188813, and r188815.
3704         https://bugs.webkit.org/show_bug.cgi?id=148349
3705
3706         lots of 32-bit build problems, better to resolve separately
3707         and try again (Requested by thorton on #webkit).
3708
3709         Reverted changesets:
3710
3711         "WebKitTestRunner should use WKWebView on OS X and iOS"
3712         https://bugs.webkit.org/show_bug.cgi?id=143743
3713         http://trac.webkit.org/changeset/188807
3714
3715         "Stop building WebKitTestRunner for 32-bit platforms"
3716         https://bugs.webkit.org/show_bug.cgi?id=143743
3717         http://trac.webkit.org/changeset/188813
3718
3719         "Stop building WebKitTestRunner for 32-bit platforms"
3720         https://bugs.webkit.org/show_bug.cgi?id=143743
3721         http://trac.webkit.org/changeset/188815
3722
3723 2015-08-21  Tim Horton  <timothy_horton@apple.com>
3724
3725         Stop building WebKitTestRunner for 32-bit platforms
3726         https://bugs.webkit.org/show_bug.cgi?id=143743
3727         <rdar://problem/16947123>
3728
3729         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3730         This is a restriction on the valid set, not the desired set.
3731
3732 2015-08-21  Jason Marcell  <jmarcell@apple.com>
3733
3734         Make Dashboard.Branches be objects of the form (repository, "branch name") and update existing code
3735         to work with these new objects.
3736         https://bugs.webkit.org/show_bug.cgi?id=148188
3737
3738         Reviewed by Daniel Bates.
3739
3740         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3741         (Buildbot.prototype._normalizeQueueInfo): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
3742         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3743         (BuildbotCombinedQueueView): Changed to work with new branch objects which represent a
3744         (repository, "branch name")-pair.
3745         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Ditto.
3746         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3747         (BuildbotQueue): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
3748         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3749         (BuildbotQueueView.prototype._appendPendingRevisionCount): Changed to work with new branch
3750         objects which represent a (repository, "branch name")-pair.
3751         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
3752         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
3753         (BuildbotQueueView.prototype._addDividerToPopover): Ditto.
3754         (BuildbotQueueView.prototype.revisionContentForIteration): Ditto.
3755         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Renamed
3756         BuildbotQueue.branch to BuildbotQueue.branches.
3757         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3758         (WebKitBuildbot.prototype.get defaultBranches): Changed to new (repository, "branch name") format.
3759
3760 2015-08-21  Tim Horton  <timothy_horton@apple.com>
3761
3762         Stop building WebKitTestRunner for 32-bit platforms
3763         https://bugs.webkit.org/show_bug.cgi?id=143743
3764         <rdar://problem/16947123>
3765
3766         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3767         WKWebView is not available on 32-bit OS X.
3768
3769 2015-08-21  Brent Fulgham  <bfulgham@apple.com>
3770
3771         [Win] Unreviewed test correction after r188709.
3772
3773         I removed a function argument that happened to be mirrored by a global
3774         value with the same name. This prevented a compile error, but testing
3775         showed that the wrong value was being used in the function.
3776
3777         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3778         (FrameLoadDelegate::willPerformClientRedirectToURL): Put function argument
3779         back
3780
3781 2015-08-21  Timothy Horton  <timothy_horton@apple.com>
3782
3783         WebKitTestRunner should use WKWebView on OS X and iOS
3784         https://bugs.webkit.org/show_bug.cgi?id=143743
3785         <rdar://problem/16947123>
3786
3787         Reviewed by Anders Carlsson.
3788         Patch by Enrica Casucci and myself.
3789
3790         * WebKitTestRunner/PlatformWebView.h:
3791         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
3792         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
3793         instead of WKContext and WKPageGroup.
3794
3795         Remove the unused, always-true windowSnapshotEnabled().
3796         While technically some platforms don't have window snapshotting,
3797         they just return null instead of implementing windowSnapshotEnabled().
3798
3799         * WebKitTestRunner/TestController.h:
3800         * WebKitTestRunner/TestController.cpp:
3801         (WTR::TestController::createOtherPage):
3802         (WTR::TestController::initialize):
3803         (WTR::TestController::createWebViewWithOptions):
3804         Delegate to the various platforms for creating PlatformWebView instances,
3805         for creating WKContexts, and for accessing WKPreferences,
3806         so that they can do special things (like, use WKWebView instead!).
3807
3808         (WTR::TestController::resetPreferencesToConsistentValues):
3809         Make explicit WebKitTestRunner's desired default for two preferences
3810         which have differing defaults between the antique and modern API,
3811         for consistency's sake.
3812
3813         (WTR::TestController::resetStateToConsistentValues):
3814         Add platformResetStateToConsistentValues.
3815
3816         * WebKitTestRunner/TestInvocation.cpp:
3817         (WTR::TestInvocation::dumpResults):
3818         Adjust to the aforementioned removal of windowSnapshotEnabled().
3819
3820         * WebKitTestRunner/ios/TestControllerCocoa.mm:
3821         (WTR::TestController::platformResetStateToConsistentValues):
3822         (WTR::TestController::platformPreferences):
3823         (WTR::TestController::platformCreateWebView):
3824         (WTR::TestController::platformCreateOtherPage):
3825         (WTR::TestController::platformInitializeConfiguration):
3826         Implement the new platform functions for the Modern WebKit2 API,
3827         in a new TestControllerCocoa file that is shared between iOS and Mac.
3828         
3829         For platformMaybeCreateContext, use the trick that we know we can cast
3830         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
3831         WKWebView's configuration.
3832
3833         Ditto for WKPreferencesRef and WKPreferences.
3834
3835         Remove user content filters on the WKWebView's userContentController.
3836
3837         * WebKitTestRunner/mac/TestControllerMac.mm:
3838         * WebKitTestRunner/ios/TestControllerIOS.mm:
3839         Move code into TestControllerCocoa.
3840
3841         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3842         (WTR::InjectedBundle::beginTesting):
3843         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3844         (WTR::TestRunner::addUserScript):
3845         (WTR::TestRunner::addUserStyleSheet):
3846         Adopt WKBundlePage API for user scripts/sheets.
3847
3848         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3849         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3850         Make and keep a WKWebView instead of a WKView.
3851         
3852         * WebKitTestRunner/mac/EventSenderProxy.mm:
3853         (WTR::EventSenderProxy::mouseUp):
3854         (WTR::EventSenderProxy::mouseMoveTo):
3855         Reach inside the WKWebView to the WKView when dispatching events.
3856         This is fairly ugly and we should come up with a better solution.
3857         Also, fix some flipping and style errors.
3858
3859 2015-08-21  Alexey Proskuryakov  <ap@apple.com>
3860
3861         Improve how UI events are dispatched by WebKitTestRunner
3862         https://bugs.webkit.org/show_bug.cgi?id=148326
3863
3864         Reviewed by Anders Carlsson.
3865
3866         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3867         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3868         Removed asyncScrolling from mouseScrollByWithWheelAndMomentumPhases, it's now always
3869         asynchronous (and really, it has always been for the most part).
3870
3871         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3872         (WTR::EventSendingController::mouseDown): Updated for WKBundlePagePostSynchronousMessage renaming.
3873         (WTR::EventSendingController::mouseUp): Ditto.
3874         (WTR::EventSendingController::mouseMoveTo): Ditto.
3875         (WTR::EventSendingController::mouseForceDown): Ditto.
3876         (WTR::EventSendingController::mouseForceUp): Ditto.
3877         (WTR::EventSendingController::mouseForceChanged): Ditto.
3878         (WTR::EventSendingController::leapForward): Ditto.
3879         (WTR::EventSendingController::scheduleAsynchronousClick): Ditto.
3880         (WTR::EventSendingController::keyDown): Ditto.
3881         (WTR::EventSendingController::scheduleAsynchronousKeyDown): Ditto.
3882         (WTR::EventSendingController::mouseScrollBy): Force a scrolling tree commit. It used
3883         to be done in custom WebKit2 code for test wheel event handling.
3884         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases): Got rid of sync version.
3885         (WTR::EventSendingController::continuousMouseScrollBy): Added a FIXME. This one is weird.
3886         (WTR::EventSendingController::contextClick): Updated for WKBundlePagePostSynchronousMessage renaming.
3887         (WTR::EventSendingController::addTouchPoint): Ditto.
3888         (WTR::EventSendingController::updateTouchPoint): Ditto.
3889         (WTR::EventSendingController::setTouchModifier): Ditto.
3890         (WTR::EventSendingController::setTouchPointRadius): Ditto.
3891         (WTR::EventSendingController::touchStart): Ditto.
3892         (WTR::EventSendingController::touchMove): Ditto.
3893         (WTR::EventSendingController::touchEnd): Ditto.
3894         (WTR::EventSendingController::touchCancel): Ditto.
3895         (WTR::EventSendingController::clearTouchPoints): Ditto.
3896         (WTR::EventSendingController::releaseTouchPoint): Ditto.
3897         (WTR::EventSendingController::cancelTouchPoint): Ditto.
3898
3899         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3900         (WTR::InjectedBundle::postSetWindowIsKey):
3901         (WTR::InjectedBundle::postSimulateWebNotificationClick):
3902         (WTR::InjectedBundle::isGeolocationProviderActive):
3903         (WTR::InjectedBundle::shouldProcessWorkQueue):
3904         Updated for WKBundlePagePostSynchronousMessage renaming.
3905
3906         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3907         (WTR::TestRunner::secureEventInputIsEnabled): Ditto.
3908
3909         * WebKitTestRunner/TestController.cpp:
3910         (WTR::TestController::initialize): Allow handling the new test style messages.
3911         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle): Removed calls
3912         to WKPageSetShouldSendEventsSynchronously, which we no longer need.
3913         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3914         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Moved
3915         "MouseScrollBy" to async section, and got rid of WKPageSetShouldSendEventsSynchronously.
3916
3917         * WebKitTestRunner/mac/EventSenderProxy.mm:
3918         (WTR::EventSenderProxy::mouseMoveTo): Got rid of WKPageSetShouldSendEventsSynchronously.
3919         (WTR::EventSenderProxy::keyDown): Ditto.
3920         (WTR::EventSenderProxy::mouseScrollBy): Ditto.
3921         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
3922
3923 2015-08-21  Yusuke Suzuki  <utatane.tea@gmail.com>
3924
3925         Skip no-llint tests that fail due to running out of executable memory after r188969
3926         https://bugs.webkit.org/show_bug.cgi?id=148273
3927
3928         Reviewed by Michael Saboff.
3929
3930         * Scripts/run-jsc-stress-tests:
3931
3932 2015-08-21  Nan Wang  <n_wang@apple.com>
3933
3934         [Mac] accessibility/selection-states.html fails
3935         https://bugs.webkit.org/show_bug.cgi?id=116637
3936
3937         Reviewed by Chris Fleizach.
3938
3939         Implemented isSelectable() and isMultiSelectable().
3940
3941         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3942         (AccessibilityUIElement::isSelectable):
3943         (AccessibilityUIElement::isMultiSelectable):
3944         (AccessibilityUIElement::isSelectedOptionActive):
3945         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3946         (WTR::AccessibilityUIElement::isSelectable):
3947         (WTR::AccessibilityUIElement::isMultiSelectable):
3948         (WTR::AccessibilityUIElement::isVisible):
3949
3950 2015-08-21  Jason Marcell  <jmarcell@apple.com>
3951
3952         Fix iteration over repositories on bot watcher's dashboard.
3953
3954         Reviewed by Alexey Proskuryakov.
3955
3956         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3957         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Don't reuse the same index variable.
3958
3959 2015-08-20  Joonghun Park  <jh718.park@samsung.com>
3960
3961         [EFL] Revise PlatformWebView ctor according to r188718
3962         https://bugs.webkit.org/show_bug.cgi?id=148282
3963
3964         This patch change PlatformWebView ctor's argument to use WKPageConfigurationRef
3965         instead of WKContextRef and WKPageGroupRef respectively.
3966
3967         Reviewed by Gyuyoung Kim.
3968
3969         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3970         (WTR::PlatformWebView::PlatformWebView):
3971
3972 2015-08-20  Devin Rousso  <dcrousso+webkit@gmail.com>
3973
3974         Unreviewed, changed Devin Rousso's email.
3975
3976         * Scripts/webkitpy/common/config/contributors.json:
3977
3978 2015-08-20  Anders Carlsson  <andersca@apple.com>
3979
3980         Use WKPageConfigurationRef in WebKitTestRunner
3981         https://bugs.webkit.org/show_bug.cgi?id=147996
3982
3983         Reviewed by Tim Horton.
3984
3985         * WebKitTestRunner/TestController.cpp:
3986         (WTR::TestController::createOtherPage):
3987         (WTR::TestController::initialize):
3988         (WTR::TestController::createWebViewWithOptions):
3989         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3990         (-[TestRunnerWKView initWithFrame:configurationRef:useThreadedScrolling:]):
3991         (WTR::PlatformWebView::PlatformWebView):
3992         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useThreadedScrolling:]): Deleted.
3993
3994 2015-08-20  Brent Fulgham  <bfulgham@apple.com>
3995
3996         [Win] Update Windows tools for revised MIDL interfaces
3997         https://bugs.webkit.org/show_bug.cgi?id=148249
3998
3999         Reviewed by Dean Jackson.
4000
4001         This is a follow-up to Bug 148001.
4002
4003         Revise the testing software to use compatible signatures and
4004         implementations to match the requirements of the IDL generated
4005         with the SAL annotations.
4006
4007         * DumpRenderTree/win/DRTDataObject.cpp:
4008         * DumpRenderTree/win/DRTDataObject.h:
4009         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
4010         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
4011         * DumpRenderTree/win/DRTDropSource.cpp:
4012         * DumpRenderTree/win/DRTDropSource.h:
4013         * DumpRenderTree/win/DumpRenderTree.cpp:
4014         * DumpRenderTree/win/EditingDelegate.cpp:
4015         * DumpRenderTree/win/EditingDelegate.h:
4016         * DumpRenderTree/win/FrameLoadDelegate.cpp:
4017         * DumpRenderTree/win/FrameLoadDelegate.h:
4018         * DumpRenderTree/win/HistoryDelegate.cpp:
4019         * DumpRenderTree/win/HistoryDelegate.h:
4020         * DumpRenderTree/win/PolicyDelegate.cpp:
4021         * DumpRenderTree/win/PolicyDelegate.h:
4022         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
4023         * DumpRenderTree/win/ResourceLoadDelegate.h:
4024         * DumpRenderTree/win/TestRunnerWin.cpp:
4025         * DumpRenderTree/win/UIDelegate.cpp:
4026         * DumpRenderTree/win/UIDelegate.h:
4027         * WinLauncher/AccessibilityDelegate.cpp:
4028         * WinLauncher/AccessibilityDelegate.h:
4029         * WinLauncher/Common.cpp:
4030         * WinLauncher/DOMDefaultImpl.cpp:
4031         * WinLauncher/DOMDefaultImpl.h:
4032         * WinLauncher/PageLoadTestClient.cpp:
4033         * WinLauncher/PageLoadTestClient.h:
4034         * WinLauncher/PrintWebUIDelegate.cpp:
4035         * WinLauncher/PrintWebUIDelegate.h:
4036         * WinLauncher/ResourceLoadDelegate.cpp:
4037         * WinLauncher/ResourceLoadDelegate.h:
4038         * WinLauncher/WebDownloadDelegate.cpp:
4039         * WinLauncher/WebDownloadDelegate.h:
4040         * WinLauncher/WinLauncherWebHost.cpp:
4041         * WinLauncher/WinLauncherWebHost.h:
4042         * WinLauncher/WinMain.cpp:
4043         * win/DLLLauncher/DLLLauncherMain.cpp:
4044
4045 2015-08-20  Filip Pizlo  <fpizlo@apple.com>
4046
4047         Unreviewed, shorten a test that runs too long and times out.
4048
4049         * TestWebKitAPI/Tests/WTF/Lock.cpp:
4050         (TestWebKitAPI::TEST):
4051
4052 2015-08-20  Alex Christensen  <achristensen@webkit.org>
4053
4054         Clean up CMake build after r188673
4055         https://bugs.webkit.org/show_bug.cgi?id=148234
4056
4057         Reviewed by Tim Horton.
4058
4059         * DumpRenderTree/PlatformWin.cmake:
4060         * TestWebKitAPI/CMakeLists.txt:
4061         * TestWebKitAPI/PlatformWin.cmake:
4062         Define WIN_CAIRO so WinCairo executables can find the correct dlls in WebKitLibraries.
4063         gtest needs to be a static library on Windows to not crash.
4064
4065 2015-08-19  Alex Christensen  <achristensen@webkit.org>
4066
4067         CMake Windows build should not include files directly from other Source directories
4068         https://bugs.webkit.org/show_bug.cgi?id=148198
4069
4070         Reviewed by Brent Fulgham.
4071
4072         * DumpRenderTree/DumpRenderTreePrefix.h:
4073         Include cmakeconfig.h to properly define all enabled features.
4074         * DumpRenderTree/PlatformWin.cmake:
4075         * TestWebKitAPI/PlatformWin.cmake:
4076
4077 2015-08-19  Alex Christensen  <achristensen@webkit.org>
4078
4079         Build TestWTF on Mac with CMake.
4080         https://bugs.webkit.org/show_bug.cgi?id=147972
4081
4082         Reviewed by Tim Horton.
4083
4084         TestWTF only depends on gtest and WTF instead of TestWebKitAPi depending on all of WebKit.
4085         Now I can run the WTF API tests after a few seconds of building instead of waiting for all of WebKit to build.
4086
4087         * TestWebKitAPI/CMakeLists.txt:
4088         Added WTF as a dependency for platforms that do not have ForwardingHeadersForTestWebKitAPI_NAME.
4089         WTF was already a library that was linked, but having at least one item makes the syntax of add_dependencies work.
4090         * TestWebKitAPI/PlatformMac.cmake: Added.
4091         * TestWebKitAPI/config.h:
4092         Postpone some build fixes until WebKit builds completely on Mac with CMake.
4093
4094 2015-08-19  Brian Burg  <bburg@apple.com>
4095
4096         Unreviewed, add Aleksandr Skachkov to the list of contributors.
4097
4098         * Scripts/webkitpy/common/config/contributors.json:
4099
4100 2015-08-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4101
4102         REGRESSION(r188548): [GTK] Build broken.
4103         https://bugs.webkit.org/show_bug.cgi?id=148154
4104
4105         Reviewed by Martin Robinson.
4106
4107         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
4108         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
4109         Even if we don't need to add/override any settings in ViewOptions,
4110         we need to define this as an empty function to make it build.
4111
4112 2015-08-18  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
4113
4114         Fix conversion-null warning in conversion.cpp of TestWebKitAPI
4115         https://bugs.webkit.org/show_bug.cgi?id=148073
4116
4117         Reviewed by Alexey Proskuryakov.
4118
4119         * TestWebKitAPI/Tests/WTF/Condition.cpp: Use EXPECT_FALSE instead of EXPECT_EQ.
4120         (TestWebKitAPI::TEST):
4121
4122 2015-08-18  Anders Carlsson  <andersca@apple.com>
4123
4124         Fix test failure fallout from r188602 by using a V5 page ui client struct.
4125
4126         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
4127         (TestWebKitAPI::setUpClients):
4128
4129 2015-08-18  Brian Burg  <bburg@apple.com>
4130
4131         Web Inspector: load ProtocolTestStub from the WebInspectorUI bundle
4132         https://bugs.webkit.org/show_bug.cgi?id=147955
4133
4134         Reviewed by Timothy Hatcher.
4135
4136         To enable sharing of common test code between protocol and model tests,
4137         start loading the protocol TestStub.js through the WebInspectorUI bundle.
4138
4139         This patch adds the read-only getter TestRunner.inspectorTestStubURL, which
4140         protocol-test.js uses to load the inspector frontend stub into its iframe
4141         from an arbitrary local file URL.
4142
4143         * DumpRenderTree/TestRunner.cpp:
4144         (getInspectorTestStubURLCallback):
4145         (TestRunner::staticValues):
4146         * DumpRenderTree/TestRunner.h:
4147         * DumpRenderTree/mac/TestRunnerMac.mm:
4148         (SOFT_LINK_STAGED_FRAMEWORK):
4149         (TestRunner::inspectorTestStubURL):
4150         * DumpRenderTree/win/TestRunnerWin.cpp:
4151         (TestRunner::inspectorTestStubURL):
4152         * WebKitTestRunner/Configurations/Base.xcconfig:
4153         Since WebKitTestRunner now includes WebCore private headers, also search
4154         for the WebCore framework inside the WebKit umbrella framework.
4155
4156         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4157         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4158         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
4159         (WTR::TestRunner::inspectorTestStubURL):
4160         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
4161         (WTR::TestRunner::inspectorTestStubURL):
4162         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
4163         (WTR::TestRunner::inspectorTestStubURL):
4164
4165 2015-08-18  Filip Pizlo  <fpizlo@apple.com>
4166
4167         Unreviewed, fix GTK build.
4168
4169         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
4170         (TestWebKitAPI::TEST):
4171
4172 2015-08-17  Filip Pizlo  <fpizlo@apple.com>
4173
4174         Replace all remaining uses of WTF::Mutex with WTF::Lock
4175         https://bugs.webkit.org/show_bug.cgi?id=148089
4176
4177         Reviewed by Geoffrey Garen.
4178
4179         * DumpRenderTree/JavaScriptThreading.cpp:
4180         (javaScriptThreadsMutex):
4181         (runJavaScriptThread):
4182         (startJavaScriptThreads):
4183         (stopJavaScriptThreads):
4184         * TestWebKitAPI/Tests/WTF/Condition.cpp: Fixed a bug in the test that I found from turning the test into a benchmark.
4185         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
4186