fbd3953d442381aa3696462cf3c063d24c5f6dfc
[WebKit-https.git] / Tools / ChangeLog
1 2014-02-04  Filip Pizlo  <fpizlo@apple.com>
2
3         DFG PutByVal on typed arrays should detect OutOfBounds sooner
4         https://bugs.webkit.org/show_bug.cgi?id=128162
5
6         Reviewed by Mark Hahnenberg.
7         
8         Add a defautNoEagerRun, which is intended to be used for convergence tests.
9
10         * Scripts/run-jsc-stress-tests:
11
12 2014-02-04  Filip Pizlo  <fpizlo@apple.com>
13
14         export-llvm-build should work with git checkouts
15         https://bugs.webkit.org/show_bug.cgi?id=128217
16
17         Reviewed by Mark Hahnenberg.
18         
19         If svn export fails, just do ditto.
20
21         * Scripts/export-llvm-build:
22
23 2014-02-04  Carlos Garnacho  <carlosg@gnome.org>
24
25         [Automake] Add missing $(feature_defines) when generating InjectedBundle bindings
26         https://bugs.webkit.org/show_bug.cgi?id=128170
27
28         Reviewed by Carlos Garcia Campos.
29
30         * WebKitTestRunner/GNUmakefile.am: Add missing $(feature_defines) when
31         generating the InjectedBundle bindings. So the various ENABLE_* defines
32         are available there.
33
34 2014-02-04  Carlos Garnacho  <carlosg@gnome.org>
35
36         [GTK] Ensure generated events have given modifiers GDK understands
37         https://bugs.webkit.org/show_bug.cgi?id=128171
38
39         Reviewed by Carlos Garcia Campos.
40
41         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
42         (WTR::webkitModifiersToGDKModifiers): Move around
43         (WTR::EventSenderProxy::createMouseButtonEvent):
44         (WTR::EventSenderProxy::keyDown): Use webkitModifiersToGDKModifiers to
45         translate WKEventModifiers.
46
47 2014-02-04  Gabor Rapcsanyi  <rgabor@webkit.org>
48
49         Fine tuning the ARM EFL bots
50         https://bugs.webkit.org/show_bug.cgi?id=128168
51
52         Reviewed by Csaba Osztrogonác.
53
54         * BuildSlaveSupport/build.webkit.org-config/config.json: Add custom SVN mirror.
55         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
56         (WaitForSVNServer): Make it not to halt before the first repository checkout.
57         (WaitForSVNServer.evaluateCommand):
58         (Factory.__init__): Disable kill-old-processes step on EFL ARM bots, because these
59         bots run on the same machine and they kill the processes of each other.
60
61 2014-02-03  Ryosuke Niwa  <rniwa@webkit.org>
62
63         kill-old-processes doesn't kill plugin processes
64         https://bugs.webkit.org/show_bug.cgi?id=128138
65
66         Reviewed by Andreas Kling.
67
68         Add plugin process names to the list of processes to kill.
69
70         * BuildSlaveSupport/kill-old-processes:
71         (main):
72
73 2014-02-03  Dean Jackson  <dino@apple.com>
74
75         Feature flag for shape-inside
76         https://bugs.webkit.org/show_bug.cgi?id=128001
77
78         Reviewed by Simon Fraser.
79
80         Add CSS_SHAPE_INSIDE flag, and -css-shape-inside build
81         flag.
82
83         * Scripts/webkitperl/FeatureList.pm:
84
85 2014-02-03  Zoltan Horvath  <zoltan@webkit.org>
86
87         Unreviewed. Reorder my e-mail addresses in contributors.json,
88         so bugzilla will auto complete my actual bugzilla username.
89
90         * Scripts/webkitpy/common/config/contributors.json:
91
92 2014-02-03  Daniel Bates  <dabates@apple.com>
93
94         WebKit Bot Watcher's Dashboard: Defer subsequent resource loads from access-restricted build bot when
95         iteration fails to load with HTTP 401 status code
96         https://bugs.webkit.org/show_bug.cgi?id=128077
97
98         Reviewed by Alexey Proskuryakov.
99
100         Similar to the fix for <https://bugs.webkit.org/show_bug.cgi?id=127849>, we should only prompt for
101         the HTTP credentials of a build bot so long as an earlier authentication request wasn't cancelled
102         (i.e. failed with an HTTP 401 Unauthorized status code). Currently an authentication dialog will be
103         presented for an iteration each time the update queue timer fires until a person successfully
104         authenticates. Instead we should update the authentication status of the build bot on receiving an
105         HTTP 401 response code such that we defer subsequent requests to load any resource from the access-
106         restricted build bot when the queue update timer fires.
107
108         A person must explicitly click the "unauthorized" status line shown for the queue associated with the
109         iteration in the dashboard and authenticate successfully for the iteration to be loaded once an
110         authentication request for an iteration is cancelled.
111
112         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
113         (BuildbotIteration.prototype.update): Early return if the associated Buildbot was given invalid credentials.
114         Also notify the associated Buildbot and update the queue view when a load failed with an HTTP 401 status code.
115         (BuildbotIteration.prototype.loadLayoutTestResults): Ditto.
116         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
117         (BuildbotQueueView): Modified to call BuildbotQueueView.prototype._unauthorizedAccess instead of
118         QueueView.prototype._updateSoon when event BuildbotQueue.Event.UnauthorizedAccess is received.
119         (BuildbotQueueView.prototype._unauthorizedAccess): Added.
120
121 2014-02-03  Daniel Bates  <dabates@apple.com>
122
123         WebKit Bot Watcher's Dashboard: Teach JSON.load() to interpret third argument as either an
124         option dictionary or a failure callback
125         https://bugs.webkit.org/show_bug.cgi?id=128080
126
127         Reviewed by Alexey Proskuryakov.
128
129         Currently JSON.load() takes a failure callback function as its third argument and
130         an option dictionary as its fourth argument. So, a caller that wants to ignore errors
131         and pass an option dictionary must pass null or a reference to an empty function for
132         the value of third argument. Instead, we should make the third argument polymorphic for
133         convenience. Then a caller can either pass a failure callback function or an option dictionary.
134
135         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
136
137 2014-02-03  Krzysztof Czech  <k.czech@samsung.com>
138
139         [ATK] Expose aria-controls through ATK_RELATION_CONTROLLER_FOR
140         https://bugs.webkit.org/show_bug.cgi?id=127908
141
142         Reviewed by Chris Fleizach.
143
144         Updated AccessibilityUIElement both in WKTR and DRT so that aria-controls support could be tested properly.
145         Added empty stubs to not break mac builds.
146
147         * DumpRenderTree/AccessibilityUIElement.cpp:
148         (ariaControlsElementAtIndexCallback):
149         (AccessibilityUIElement::getJSClass):
150         * DumpRenderTree/AccessibilityUIElement.h:
151         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
152         (accessibilityElementAtIndex):
153         (AccessibilityUIElement::disclosedRowAtIndex):
154         (AccessibilityUIElement::ariaOwnsElementAtIndex):
155         (AccessibilityUIElement::ariaFlowToElementAtIndex):
156         (AccessibilityUIElement::ariaControlsElementAtIndex):
157         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
158         (AccessibilityUIElement::ariaControlsElementAtIndex):
159         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
160         (AccessibilityUIElement::ariaControlsElementAtIndex):
161         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
162         (AccessibilityUIElement::ariaControlsElementAtIndex):
163         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
164         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
165         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
166         (WTR::accessibilityElementAtIndex):
167         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
168         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
169         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
170         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
171         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
172         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
173         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
174         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
175
176 2014-02-02  Daniel Bates  <dabates@apple.com>
177
178         WebKit Bot Watcher's Dashboard: Access restricted queue should only prompt for HTTP credentials once per page load
179         https://bugs.webkit.org/show_bug.cgi?id=127849
180
181         I inadvertently used the equality operator instead of the identity operator when comparing the
182         value of the error HTTP status code with the numeric literal 401.
183
184         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
185         (BuildbotQueue.prototype.update):
186
187 2014-02-02  Daniel Bates  <dabates@apple.com>
188
189         Attempt to fix production dashboard after <http://trac.webkit.org/changeset/163222>
190
191         Actually pass option dictionary to JSON.load(); JSON.load() takes four arguments with the
192         last-most argument being the option dictionary.
193
194         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
195         (BuildbotIteration.prototype.update):
196
197 2014-02-01  Filip Pizlo  <fpizlo@apple.com>
198
199         JSC profiler's stub info profiling support should work again
200         https://bugs.webkit.org/show_bug.cgi?id=128057
201
202         Reviewed by Mark Lam.
203
204         * Scripts/display-profiler-output: Just make sure that there's always a space between the origin stack dump and the top bytecode index.
205
206 2014-02-01  Filip Pizlo  <fpizlo@apple.com>
207
208         JSC profiler should show reasons for jettison
209         https://bugs.webkit.org/show_bug.cgi?id=128047
210
211         Reviewed by Geoffrey Garen.
212         
213         Gave the tool a "log" command, that tells you all of the interesting things
214         that happened to a piece of bytecode, from the standpoint of optimization.
215         It's a great summary view for seeing how our tier-up machinery works.
216         
217         This uses a lot of information that was already available, plus the newly
218         added jettisonReason field.
219
220         * Scripts/display-profiler-output:
221
222 2014-01-31  Ryosuke Niwa  <rniwa@webkit.org>
223
224         Remove inline member functions of FrameSelection that access m_selection
225         https://bugs.webkit.org/show_bug.cgi?id=127986
226
227         Reviewed by Enrica Casucci.
228
229         * TestWebKitAPI/Configurations/Base.xcconfig:
230
231 2014-01-31  Anders Carlsson  <andersca@apple.com>
232
233         Another attempt at fixing the build.
234
235         * TestWebKitAPI/Configurations/Base.xcconfig:
236
237 2014-01-31  Oliver Hunt  <oliver@apple.com>
238
239         Rollout r163195 and related patches
240
241         * DumpRenderTree/CMakeLists.txt:
242         * WebKitTestRunner/CMakeLists.txt:
243         * WinCELauncher/CMakeLists.txt:
244
245 2014-01-31  Daniel Bates  <dabates@apple.com>
246
247         Attempt to fix Production Dashboard after <http://trac.webkit.org/changeset/163213>
248         (https://bugs.webkit.org/show_bug.cgi?id=127849)
249
250         Reviewed by David Farler.
251
252         Pass credentials when querying build bot iteration. 
253
254         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
255         (BuildbotIteration.prototype.update):
256         (BuildbotIteration.prototype.loadLayoutTestResults):
257
258 2014-01-31  Anders Carlsson  <andersca@apple.com>
259
260         Fix iOS build.
261
262         * TestWebKitAPI/Configurations/Base.xcconfig:
263
264 2014-01-31  Simon Fraser  <simon.fraser@apple.com>
265
266         WebKitTestRunner project doesn't show Mac as a valid destination architecture.
267         
268         Make sure that SUPPORTED_PLATFORMS is defined in Base.xcconfig.
269         
270         Also add BaseTarget.xcconfig to the project.
271
272         * WebKitTestRunner/Configurations/Base.xcconfig:
273         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
274
275 2014-01-31  Daniel Bates  <dabates@apple.com>
276
277         WebKit Bot Watcher's Dashboard: Access restricted queue should only prompt for HTTP credentials once per page load
278         https://bugs.webkit.org/show_bug.cgi?id=127849
279
280         Reviewed by Alexey Proskuryakov.
281
282         Currently whenever the dashboard updates the status of a queue whose Buildbot requires authentication
283         it will cause a browser to prompt for credentials once per update until valid credentials are provided.
284         Instead we should keep track of Buildbots that respond with an HTTP 401 Unauthorized status code to avoid
285         subsequently querying them and hence cause a browser to prompt for credentials. Together with an optional
286         hint provided when instantiating a Buildbot object as to whether it requires authentication, we can make
287         the dashboard prompt for HTTP credentials exactly once per page load for each queue whose associated
288         Buildbot requires authentication.
289
290         Queues whose Buildbot wasn't authenticated will show in the dashboard as "unauthorized". Clicking on
291         this status message will cause the browser to prompt for credentials.
292
293         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
294         (Buildbot): Initialize instance variable authenticationStatus to Buildbot.AuthenticationStatus.Unauthenticated.
295         (Buildbot.prototype.get needsAuthentication): Added.
296         (Buildbot.prototype.get authenticationStatus): Added.
297         (Buildbot.prototype.get isAuthenticated): Added.
298         (Buildbot.prototype.set isAuthenticated): Added.
299         (Buildbot.prototype.updateQueues): Added.
300         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
301         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Modified to call
302         BuildbotQueueView.prototype._appendUnauthorizedLineView() to update the view and show status of the queue as
303         "unauthorized" if the Buildbot associated with the queue is either unauthenticated or was given invalid credentials.
304         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
305         (BuildbotQueue.prototype.update): Return immediately if the associated Buildbot requires authentication.
306         Additionally, if the JSON load fails with an HTTP 401 Unauthorized access error (say, credentials were
307         invalidated) then update the authentication status of the Buildbot to avoid subsequently prompting a
308         person for credentials the next time the queue update timer fires.
309         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
310         (BuildbotQueueView): Register as a listener for event BuildbotQueue.Event.UnauthorizedAccess on each queue
311         so that the view can be updated to show status "unauthorized".
312         (BuildbotQueueView.prototype._appendUnauthorizedLineView): Added.
313         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
314         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
315         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js: Added new status, StatusLineView.Status.Unauthorized.
316         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
317         (.status-line.unauthorized .bubble): Added.
318         (.status-line.unauthorized .bubble.pictogram): Added.
319         (.status-line.unauthorized .message): Added.
320
321 2014-01-31  Filip Pizlo  <fpizlo@apple.com>
322
323         Unreviewed, really make --copy-libraries a no-able option.
324         
325         * Scripts/build-jsc:
326
327 2014-01-31  Filip Pizlo  <fpizlo@apple.com>
328
329         Unreviewed, really add the --copy-libraries option.
330
331         * Scripts/build-jsc:
332
333 2014-01-31  Filip Pizlo  <fpizlo@apple.com>
334
335         Unreviewed, fix the script for older Rubies.
336
337         * Scripts/export-llvm-build:
338
339 2014-01-31  Filip Pizlo  <fpizlo@apple.com>
340
341         Having a custom LLVM checkout should always override all other ways of getting LLVM
342         https://bugs.webkit.org/show_bug.cgi?id=128015
343
344         Reviewed by Oliver Hunt.
345
346         * Scripts/copy-webkitlibraries-to-product-directory:
347
348 2014-01-31  Daniel Bates  <dabates@apple.com>
349
350         WebKit Bot Watcher's Dashboard: Teach JSON.load() to take optional failure callback function
351         https://bugs.webkit.org/show_bug.cgi?id=127924
352
353         Reviewed by Alexey Proskuryakov.
354
355         Towards providing better error handling when a JSON load fails with a non-200 HTTP status
356         code, we should teach JSON.load() to take an optional failure callback function and invoke
357         it when either a load error or a JSON parsing error occurs.
358
359         As a side benefit of having a failure callback function a caller can separate the error handling
360         logic for a JSON load or parse error from the logic of handling a successful parsing of JSON content.
361
362         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
363         (BuildbotIteration.prototype.loadLayoutTestResults): Move JSON parser error logic into failure
364         callback function.
365         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
366         (JSON.load): Modified to take optional failure callback function called failureCallback.
367
368 2014-01-29  Oliver Hunt  <oliver@apple.com>
369
370         Make it possible to implement JS builtins in JS
371         https://bugs.webkit.org/show_bug.cgi?id=127887
372
373         Reviewed by Michael Saboff.
374
375         CMake updates
376
377         * DumpRenderTree/CMakeLists.txt:
378         * WebKitTestRunner/CMakeLists.txt:
379         * WinCELauncher/CMakeLists.txt:
380
381 2014-01-31  Filip Pizlo  <fpizlo@apple.com>
382
383         Allow more flexibility for copy-webkitlibraries-to-product-directory
384         https://bugs.webkit.org/show_bug.cgi?id=128010
385
386         Reviewed by Oliver Hunt.
387         
388         It's now the case that copy-webkitlibraries-to-product-directory does nothing by
389         default, but you can tell it to either copy WebKitSystemInterface (--wksi) or LLVM
390         (--llvm). You can also tell it where to get LLVM from.
391
392         * Scripts/build-jsc:
393         * Scripts/build-webkit:
394         * Scripts/copy-webkitlibraries-to-product-directory:
395
396 2014-01-31  David Farler  <dfarler@apple.com>
397
398         DumpRenderTree iOS fails to link: missing rowHeaders and columnHeaders in AccessibilityUIElement
399         https://bugs.webkit.org/show_bug.cgi?id=128004
400
401         Reviewed by Chris Fleizach.
402
403         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
404         (AccessibilityUIElement::columnHeaders): Stub added.
405         (AccessibilityUIElement::rowHeaders): Stub added.
406
407 2014-01-31  Zoltan Horvath  <zoltan@webkit.org>
408
409         Unreviewed. Update my contributors.json entry.
410
411         * Scripts/webkitpy/common/config/contributors.json:
412
413 2014-01-31  Anders Carlsson  <andersca@apple.com>
414
415         REGRESSION: WebKit2.PageLoadBasic API test is failing
416         https://bugs.webkit.org/show_bug.cgi?id=127892
417
418         Reviewed by Dan Bernstein.
419
420         Re-enable test.
421
422         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
423
424 2014-01-31  Csaba Osztrogonác  <ossy@webkit.org>
425
426         [jhbuild] Disable escape sequences in EWS output
427         https://bugs.webkit.org/show_bug.cgi?id=127922
428
429         Reviewed by Alexey Proskuryakov.
430
431         * Scripts/webkitpy/common/system/environment.py:
432         (Environment.disable_gcc_smartquotes):
433         (Environment):
434         (Environment.disable_jhbuild_VT100_output):
435         * Scripts/webkitpy/tool/commands/download_unittest.py:
436         * Scripts/webkitpy/tool/steps/build.py:
437         (Build.build):
438
439 2014-01-30  Martin Robinson  <mrobinson@igalia.com>
440
441         [GTK] [CMake] Add support for building against GTK+ 2
442         https://bugs.webkit.org/show_bug.cgi?id=127959
443
444         Reviewed by Anders Carlsson.
445
446         * DumpRenderTree/PlatformGTK.cmake: Use the new API version variable and don't use GTK3 directly.
447         * GtkLauncher/CMakeLists.txt: Ditto.
448         * ImageDiff/PlatformGTK.cmake: Ditto.
449         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Ditto.
450
451 2014-01-30  Anders Carlsson  <andersca@apple.com>
452
453         Add webView:didFinishLoadingNavigation: delegate method
454         https://bugs.webkit.org/show_bug.cgi?id=127976
455
456         Reviewed by Dan Bernstein.
457
458         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
459         (-[NavigationDelegate webView:didCommitNavigation:]):
460         (-[NavigationDelegate webView:didFinishLoadingNavigation:]):
461
462 2014-01-30  Anders Carlsson  <andersca@apple.com>
463
464         Add a webView:didCommitNavigation: delegate method
465         https://bugs.webkit.org/show_bug.cgi?id=127972
466
467         Reviewed by Dan Bernstein.
468
469         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
470         (-[NavigationDelegate webView:didStartProvisionalNavigation:]):
471         (-[NavigationDelegate webView:didCommitNavigation:]):
472
473 2014-01-30  Anders Carlsson  <andersca@apple.com>
474
475         Add a webView:didFailProvisionalNavigation:withError: delegate method
476         https://bugs.webkit.org/show_bug.cgi?id=127968
477
478         Reviewed by Dan Bernstein.
479
480         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
481         (-[DidFailProvisionalNavigationDelegate webView:didStartProvisionalNavigation:]):
482         (-[DidFailProvisionalNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
483         (TEST):
484
485 2014-01-30  Ryosuke Niwa  <rniwa@webkit.org>
486
487         The test server build fixes.
488
489         * TestResultServer/model/jsonresults.py:
490         (JsonResults.merge):
491         * TestResultServer/static-dashboards/flakiness_dashboard.js:
492
493 2014-01-30  Ryosuke Niwa  <rniwa@webkit.org>
494
495         NRWT shouldn't say "Finished writing JSON files" if it failed to to so
496         https://bugs.webkit.org/show_bug.cgi?id=127966
497
498         Reviewed by Alexey Proskuryakov.
499
500         Don't say "Finished writing JSON files" if we had failed to generate the JSON file.
501         Also explicitly say this is for test results server as we're generating two JSON files.
502
503         * Scripts/webkitpy/layout_tests/controllers/manager.py:
504         (Manager._upload_json_files):
505         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
506         (JSONLayoutResultsGenerator.__init__): Don't generate JSON file implicitly inside the constructor.
507         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
508         (JSONResultsGenerator.generate_json_output): Return a boolean indicating whether the generation
509         had succeeded or not.
510
511 2014-01-30  Filip Pizlo  <fpizlo@apple.com>
512
513         copy-webkitlibraries-to-product-directory should accept command-line arguments for extra work required for optional features rather than relying on environment variables
514         https://bugs.webkit.org/show_bug.cgi?id=120221
515
516         Reviewed by Mark Hahnenberg.
517
518         * Scripts/build-jsc:
519         * Scripts/build-webkit:
520         * Scripts/copy-webkitlibraries-to-product-directory:
521
522 2014-01-30  Anders Carlsson  <andersca@apple.com>
523
524         Add a webView:didStartProvisionalNavigation: delegate method
525         https://bugs.webkit.org/show_bug.cgi?id=127965
526
527         Reviewed by Dan Bernstein.
528
529         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
530         (-[NavigationDelegate webView:didStartProvisionalNavigation:]):
531         (TEST):
532
533 2014-01-30  Chris Fleizach  <cfleizach@apple.com>
534
535         WebKitTestRunner fails to link - missing rowHeaders and columnHeaders
536         https://bugs.webkit.org/show_bug.cgi?id=127917
537
538         Reviewed by Andy Estes.
539
540         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
541         (WTR::AccessibilityUIElement::rowHeaders):
542         (WTR::AccessibilityUIElement::columnHeaders):
543
544 2014-01-30  Martin Robinson  <mrobinson@igalia.com>
545
546         [GTK] [CMake] Add a "make dist" target
547         https://bugs.webkit.org/show_bug.cgi?id=116378
548
549         Reviewed by Gustavo Noronha Silva.
550
551         Added a script that reads a manifest file an produces a tarball. Also add
552         the manifest.
553
554         * gtk/make-dist.py: Added.
555         * gtk/manifest.txt: Added.
556
557 2014-01-30  David Farler  <dfarler@apple.com>
558
559         Move OTHER_LDFLAGS erasure to DumpRenderTreeLibrary.xcconfig.
560         https://bugs.webkit.org/show_bug.cgi?id=127935
561
562         Reviewed by Andy Estes.
563
564         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
565         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
566         Move OTHER_LDFLAGS erasure to the static library's xcconfig.
567
568 2014-01-30  David Farler  <dfarler@apple.com>
569
570         DumpRenderTree fails to build with ASAN: -fsanitize=address passed to static DRT target
571         https://bugs.webkit.org/show_bug.cgi?id=127935
572
573         Reviewed by Andy Estes.
574
575         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
576         Clear OTHER_LDFLAGS at the project level for the static library target.
577         No other linker flags were inherited from DebugRelease.
578
579 2014-01-30  David Farler  <dfarler@apple.com>
580
581         package-root shouldn't prefix simulator roots with the SDK path
582         http://bugs.webkit.org/show_bug.cgi?id=127923
583
584         Reviewed by Dan Bernstein.
585
586         * Scripts/package-root: Don't add an install path prefix.
587
588 2014-01-30  Gabor Rapcsanyi  <rgabor@webkit.org>
589
590         Add ARM EFL Linux builder bots to Apple buildmaster
591         https://bugs.webkit.org/show_bug.cgi?id=127472
592
593         Reviewed by Csaba Osztrogonác.
594
595         There is no ARM buildslaves after removing the Qt builders.
596
597         * BuildSlaveSupport/build.webkit.org-config/config.json:
598
599 2014-01-30  Andy Estes  <aestes@apple.com>
600
601         REGRESSION (r163037): WebKit2.PageLoadBasic API test failing on Mountain Lion
602         https://bugs.webkit.org/show_bug.cgi?id=127934
603
604         Disable the failing test on Mountain Lion.
605
606         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
607         (TestWebKitAPI::TEST):
608
609 2014-01-30  Anders Carlsson  <andersca@apple.com>
610
611         Add WKNavigationDelegate class
612         https://bugs.webkit.org/show_bug.cgi?id=127927
613
614         Reviewed by Dan Bernstein.
615
616         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
617         (TEST):
618
619 2014-01-30  David Farler  <dfarler@apple.com>
620
621         Enable iOS Tools builds by default
622         https://bugs.webkit.org/show_bug.cgi?id=127919
623
624         Reviewed by Andy Estes.
625
626         * Makefile:
627         Build all the tools except MiniBrowser on iOS
628         * Scripts/build-webkit:
629         Ditto.
630         Build WebKitTestRunnerApp target on iOS.
631
632 2014-01-30  David Farler  <dfarler@apple.com>
633
634         Make TestWebKitAPI build and run for iOS
635         https://bugs.webkit.org/show_bug.cgi?id=127925
636
637         Reviewed by Andy Estes.
638
639         * TestWebKitAPI/Configurations/Base.xcconfig:
640         - Don't warn on 64-32 bit conversion on x86_64 and arm64
641         - Don't build mac/*
642         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
643         - Link WebKit2 on all platforms
644
645 2014-01-30  David Farler  <dfarler@apple.com>
646
647         package-root should copy ./usr from the build products directory
648         https://bugs.webkit.org/show_bug.cgi?id=127878
649
650         Reviewed by Daniel Bates.
651
652         * Scripts/package-root:
653         Copy ./usr in addition to the frameworks.
654
655 2014-01-30  Andrei Bucur  <abucur@adobe.com>
656
657         Remove the ACCELERATED_COMPOSITING flag
658         https://bugs.webkit.org/show_bug.cgi?id=127833
659
660         Reviewed by Antti Koivisto.
661
662         Remove the USE(ACCELERATED_COMPOSITING) conditionals from the code base and make AC
663         mandatory.
664
665         * DumpRenderTree/efl/DumpRenderTree.cpp:
666         (initEcoreEvas):
667         * EWebLauncher/main.c:
668         (windowCreate):
669         * MiniBrowser/efl/main.c:
670         (elm_main):
671         * TestWebKitAPI/efl/PlatformWebView.cpp:
672         (TestWebKitAPI::initEcoreEvas):
673         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
674         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
675         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
676         (WTR::initEcoreEvas):
677
678 2014-01-29  Csaba Osztrogonác  <ossy@webkit.org>
679
680         Remove ENABLE(JAVASCRIPT_DEBUGGER) leftovers
681         https://bugs.webkit.org/show_bug.cgi?id=127845
682
683         Reviewed by Joseph Pecoraro.
684
685         * Scripts/webkitperl/FeatureList.pm:
686
687 2014-01-29  Anders Carlsson  <andersca@apple.com>
688
689         -[WKWebView loadRequest:] should return a WKNavigation
690         https://bugs.webkit.org/show_bug.cgi?id=127873
691
692         Reviewed by Dan Bernstein.
693
694         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
695         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm: Added.
696         (TEST):
697
698 2014-01-29  Tim Horton  <timothy_horton@apple.com>
699
700         WebKit2 View Gestures (Swipe): Update rubberBandsAt{Left,Right} when WebKit swipe is enabled
701         https://bugs.webkit.org/show_bug.cgi?id=127855
702         <rdar://problem/15933878>
703
704         Reviewed by Anders Carlsson.
705
706         * MiniBrowser/mac/WK2BrowserWindowController.m:
707         (-[WK2BrowserWindowController awakeFromNib]):
708         Enable swipe in MiniBrowser for testing purposes.
709
710 2014-01-29  Daniel Bates  <dabates@apple.com>
711
712         Fix JSONP requests made by the WebKit Bot Watcher's Dashboard following <http://trac.webkit.org/changeset/163034>
713         (https://bugs.webkit.org/show_bug.cgi?id=127784)
714
715         Use dot-notation instead of array index notation to access the dictionary value for key jsonpCallbackName
716         in the specified options dictionary.
717
718         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
719         (JSON.load):
720
721 2014-01-29  Daniel Bates  <dabates@apple.com>
722
723         WebKit Bot Watcher's Dashboard: Add support for using HTTP authentication with Buildbot
724         https://bugs.webkit.org/show_bug.cgi?id=127784
725
726         Reviewed by Alexey Proskuryakov.
727
728         Implement support for querying a Buildbot that requires HTTP authentication to access it.
729
730         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
731         (Buildbot): Add optional argument, options, to pass a dictionary of Buildbot options.
732         For now, we only support a single option, needsAuthentication, to indicate whether the
733         Buildbots requires HTTP authentication (defaults to false - HTTP authentication is
734         not required).
735         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
736         (BuildbotIteration.prototype.loadLayoutTestResults): Modified to pass JSONP callback name
737         to JSON.load() using the option dictionary.
738         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
739         (BuildbotQueue.prototype.update): Modified to pass withCredentials to JSON.load().
740         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
741         (JSON.load): Removed optional argument jsonpCallbackName and added optional argument options,
742         which is a dictionary. The argument jsonpCallbackName is now specified as an entry in the
743         options dictionary. Added boolean options withCredentials to toggle querying with HTTP
744         authentication credentials.
745
746 2014-01-29  Alexey Proskuryakov  <ap@apple.com>
747
748         build.webkit.org/dashboard links to an old failing build rather than the most recent
749         https://bugs.webkit.org/show_bug.cgi?id=127765
750         <rdar://problem/15795228>
751
752         Reviewed by Timothy Hatcher.
753
754         This patch changes builder view to not show how many failures there were in a row,
755         because it is not very relevant, and complicates the UI. Instead, we just show the
756         latest failing build and the latest successful one.
757
758         The patch also removes commit history popovers from revisions that can not be correlated
759         with any change. These popovers are only helpful in the first line, when there is
760         another line for comparison below. In this case, it's useful to see what changed
761         between the revisions, but even then, only if it was an actual failure, not a buildbot
762         exception.
763
764         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
765         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
766         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
767         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
768         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
769         (BuildbotQueueView.prototype._revisionPopoverContentForIteration):
770         (BuildbotQueueView.prototype.revisionContentForIteration):
771         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
772         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
773
774 2014-01-29  Csaba Osztrogonác  <ossy@webkit.org>
775
776         Remove ENABLE(JAVASCRIPT_DEBUGGER) guards
777         https://bugs.webkit.org/show_bug.cgi?id=127840
778
779         Reviewed by Mark Lam.
780
781         * Scripts/webkitperl/FeatureList.pm:
782
783 2014-01-29  Krzysztof Czech  <k.czech@samsung.com>
784
785         [ATK] Expose aria-describedby with ATK_RELATION_DESCRIBED_BY
786         https://bugs.webkit.org/show_bug.cgi?id=121684
787
788         Reviewed by Mario Sanchez Prada.
789
790         Implementing helpText by using relation ATK_RELATION_DESCRIBED_BY.
791
792         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
793         (AccessibilityUIElement::helpText):
794         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
795         (WTR::AccessibilityUIElement::helpText):
796
797 2014-01-27  Chris Fleizach  <cfleizach@apple.com>
798
799         AX: Support @scope in HTML tables
800         https://bugs.webkit.org/show_bug.cgi?id=127688
801
802         Reviewed by Mario Sanchez Prada.
803
804         Add support for rowHeaders and columnHeaders.
805
806         * DumpRenderTree/AccessibilityUIElement.cpp:
807         (convertElementsToObjectArray):
808         (columnHeadersCallback):
809         (rowHeadersCallback):
810         (uiElementArrayAttributeValueCallback):
811         (AccessibilityUIElement::columnHeaders):
812         (AccessibilityUIElement::rowHeaders):
813         (AccessibilityUIElement::getJSClass):
814         * DumpRenderTree/AccessibilityUIElement.h:
815         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
816         (AccessibilityUIElement::rowHeaders):
817         (AccessibilityUIElement::columnHeaders):
818         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
819         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
820         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
821         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
822         (WTR::AccessibilityUIElement::rowHeaders):
823         (WTR::AccessibilityUIElement::columnHeaders):
824         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
825         (WTR::convertElementsToObjectArray):
826         (WTR::AccessibilityUIElement::rowHeaders):
827         (WTR::AccessibilityUIElement::columnHeaders):
828         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
829
830 2014-01-28  Daniel Bates  <dabates@apple.com>
831
832         Teach Buildbot dashboard to parse alternative revision format
833         https://bugs.webkit.org/show_bug.cgi?id=127561
834
835         Reviewed by Alexey Proskuryakov.
836
837         Add support for extracting the OpenSource and Internal revision numbers when Buildbot
838         returns a dictionary for the value of property got_revision.
839
840         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
841         (isMultiCodebaseGotRevisionProperty): Added.
842         (parseRevisionProperty): Added; parses Buildbot revision property, which can either be a
843         string or a dictionary.
844         (BuildbotIteration.prototype.update.): Modified to call parseRevisionProperty() to determine
845         the OpenSource and Internal revision numbers.
846
847 2014-01-28  Adrian Perez de Castro  <aperez@igalia.com>
848
849         [GTK] Add API to allow setting the process model in WebKitWebContext
850         https://bugs.webkit.org/show_bug.cgi?id=125463
851
852         Reviewed by Carlos Garcia Campos.
853
854         Implements accessors in WebKitWebContext for the process model.
855         The default behavior is unchanged, and a single web process is
856         used. Using WEBKIT_PROCESS_MODEL_ONE_SECONDARY_PROCESS_PER_WEB_VIEW
857         as the process model will make use one web process for each
858         WebKitWebView. This also enables the network process. Setting
859         the process model must be done as early as possible, before the
860         very first web process is spawned.
861
862         * MiniBrowser/gtk/main.c:
863         (main):
864         Enable multiple process mode if the MINIBROWSER_MULTIPROCESS
865         environment variable is defined and not empty.
866         * TestWebKitAPI/GNUmakefile.am:
867         Add new TestMultiprocess test case.
868         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
869         Add new TestMultiprocess test case.
870         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp: Added.
871         (loadChanged):
872         (testMultipleSecondaryProcesses):
873         (initializeWebExtensions):
874         (beforeAll):
875         (afterAll):
876         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
877         (methodCallCallback):
878         Implement the GetProcessIdentifier D-Bus method.
879         (makeBusName):
880         Choose a different bus name when the web extension is used
881         from TestMultiprocess.
882         (webkit_web_extension_initialize_with_user_data):
883         Use makeBusName() to choose the bus name.
884
885 2014-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
886
887         [SOUP] Remove soupURIToKURL
888         https://bugs.webkit.org/show_bug.cgi?id=127104
889
890         Reviewed by Martin Robinson.
891
892         * TestWebKitAPI/GNUmakefile.am: Add soup cppflags to WebCore unit
893         tests, because URL.h now includes GUniquePtrSoup.h.
894         * TestWebKitAPI/CMakeLists.txt: Ditto.
895         * WebKitTestRunner/PlatformEfl.cmake: Add soup cppflags to WTR,
896         because URL.h now includes GUniquePtrSoup.h.
897
898 2014-01-27  Carlos Garcia Campos  <cgarcia@igalia.com>
899
900         [GTK] Make webkit_uri_scheme_request_get_web_view() work with CustomProtocols
901         https://bugs.webkit.org/show_bug.cgi?id=127614
902
903         Reviewed by Gustavo Noronha Silva.
904
905         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: Bring
906         back the custom URI scheme WebView check.
907
908 2014-01-27  Tim Horton  <timothy_horton@apple.com>
909
910         Revert yet one more tiny part of r162629 that didn't get reverted in r162883
911
912         * WebKitTestRunner/TestController.cpp:
913         (WTR::TestController::pluginLoadPolicy):
914         * WebKitTestRunner/TestController.h:
915
916 2014-01-27  Tim Horton  <timothy_horton@apple.com>
917
918         Revert one more tiny part of r162629 that didn't get reverted in r162883.
919
920         ... which was also causing test failures!
921
922         * WebKitTestRunner/TestController.cpp:
923         (WTR::TestController::createWebViewWithOptions):
924
925 2014-01-27  David Farler  <dfarler@apple.com>
926
927         iOS DumpRenderTree.app dies loading fonts
928         https://bugs.webkit.org/show_bug.cgi?id=127730
929
930         Reviewed by Daniel Bates.
931
932         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
933         - Add Ahem to the __DATA section
934         * DumpRenderTree/mac/DumpRenderTree.mm:
935         (activateFontsIOS):
936         - Load "WeightWatcher100" instead.
937
938 2014-01-27  Alexey Proskuryakov  <ap@apple.com>
939
940         [Mac] Extra logging output from run-safari --no-saved-state
941         https://bugs.webkit.org/show_bug.cgi?id=127732
942
943         Reviewed by Daniel Bates.
944
945         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp): Use an option that
946         disables saved state without logging.
947
948 2014-01-27  Tim Horton  <timothy_horton@apple.com>
949
950         Revert the parts of r162629 that add a new pluginLoadPolicy and the context menu item.
951
952         We're leaving the parts that make us use PDFPlugin instead of showing the blocked
953         plugin indicator intact, though.
954
955         * WebKitTestRunner/TestController.cpp:
956         (WTR::TestController::createWebViewWithOptions):
957
958 2014-01-27  Andy Estes  <aestes@apple.com>
959
960         Scrub WebKit API headers of WTF macros
961         https://bugs.webkit.org/show_bug.cgi?id=127706
962
963         Reviewed by David Kilzer.
964
965         * Scripts/check-for-inappropriate-macros-in-external-headers: Modified
966         the regex to require a '(' after the macro name in order to be
967         considered a match. This prevents things like 'ENABLE_SOME_FEATURE'
968         from being flagged as an ENABLE() macro.
969
970 2014-01-27  Commit Queue  <commit-queue@webkit.org>
971
972         Unreviewed, rolling out r162846.
973         http://trac.webkit.org/changeset/162846
974         https://bugs.webkit.org/show_bug.cgi?id=127695
975
976         "Broke the WebKit Bot Watcher's Dashboard; will fix offline"
977         (Requested by dydz on #webkit).
978
979         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
980         (BuildbotIteration.prototype.update.):
981
982 2014-01-27  Daniel Bates  <dabates@apple.com>
983
984         Add support for displaying results from multiple Buildbots on WebKit Bot Watcher's Dashboard
985         https://bugs.webkit.org/show_bug.cgi?id=127564
986
987         Reviewed by Alexey Proskuryakov.
988
989         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
990         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
991
992 2014-01-27  Daniel Bates  <dabates@apple.com>
993
994         Teach Buildbot dashboard to parse alternative revision format
995         https://bugs.webkit.org/show_bug.cgi?id=127561
996
997         Reviewed by Alexey Proskuryakov.
998
999         Add support for extracting the OpenSource and Internal revision numbers when Buildbot
1000         returns a dictionary for the value of property got_revision.
1001
1002         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1003         (parseRevisionProperty): Added; parses Buildbot revision property, which can either be a
1004         string or a dictionary.
1005         (BuildbotIteration.prototype.update.): Modified to call parseRevisionProperty() to determine
1006         the OpenSource and Internal revision numbers.
1007
1008 2014-01-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1009
1010         [GTK] Implement custom URI schemes with CustomProtocols
1011         https://bugs.webkit.org/show_bug.cgi?id=127091
1012
1013         Reviewed by Gustavo Noronha Silva.
1014
1015         Temporarily disable the WebKitWebView check until we figure out
1016         how to implement it with CustomProtocols.
1017
1018         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1019
1020 2014-01-26  Alexey Proskuryakov  <ap@apple.com>
1021
1022         REGRESSION(r127412): http/tests/misc/link-rel-icon-beforeload.html is broken.
1023
1024         * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::setIconDatabaseEnabled):
1025         Fixed an incorrect ifdef.
1026
1027 2014-01-26  Brendan Long  <b.long@cablelabs.com>
1028
1029         [GTK] DumpRenderTree prints out suggesting to set WEBKIT_TOP_LEVEL when fonts are missing but doesn't use it.
1030         https://bugs.webkit.org/show_bug.cgi?id=110602
1031
1032         Reviewed by Philippe Normand.
1033
1034         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1035         (getTopLevelPath): Use WEBKIT_TOP_LEVEL environment variable if it exists.
1036         (initializeFonts): Fix printing of expected font path (fontPath is guaranteed to be null here).
1037
1038 2014-01-24  Andy Estes  <aestes@apple.com>
1039
1040         [iOS] Upstream changes in Tools/DumpRenderTree
1041         https://bugs.webkit.org/show_bug.cgi?id=127412
1042
1043         Reviewed by Simon Fraser.
1044
1045         Upstream all iOS changes. Added a new target called DumpRenderTree.app,
1046         which builds the DumpRenderTree static library into an app bundle as
1047         expected by the iOS Simulator.
1048
1049         * DumpRenderTree/AccessibilityTextMarker.h:
1050         * DumpRenderTree/AccessibilityUIElement.h:
1051         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1052         * DumpRenderTree/DumpRenderTreeFileDraggingSource.h:
1053         * DumpRenderTree/DumpRenderTreePrefix.h:
1054         * DumpRenderTree/PixelDumpSupport.cpp:
1055         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1056         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1057         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
1058         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1059         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1060         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
1061         * DumpRenderTree/TestNetscapePlugIn/TestObject.h:
1062         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
1063         * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSAfterRemovingPluginElement.cpp:
1064         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
1065         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp:
1066         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
1067         * DumpRenderTree/TestNetscapePlugIn/Tests/NullNPPGetValuePointer.cpp:
1068         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
1069         * DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableNPObjectInvokeDefault.cpp:
1070         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1071         * DumpRenderTree/TestRunner.cpp:
1072         * DumpRenderTree/TestRunner.h:
1073         * DumpRenderTree/cg/ImageDiffCG.cpp:
1074         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1075         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
1076         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1077         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h: Added.
1078         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm: Added.
1079         * DumpRenderTree/ios/Info.plist: Added.
1080         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport.c: Added.
1081         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Added.
1082         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Added.
1083         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Changes: Added.
1084         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/IPhoneSimulatorNotification.xs: Added.
1085         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/MANIFEST: Added.
1086         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL: Added.
1087         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/README: Added.
1088         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm: Added.
1089         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/ppport.h: Added.
1090         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/t/IPhoneSimulatorNotification.t: Added.
1091         * DumpRenderTree/ios/PerlSupport/Makefile: Added.
1092         * DumpRenderTree/ios/PixelDumpSupportIOS.mm: Added.
1093         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
1094         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
1095         * DumpRenderTree/mac/AppleScriptController.m:
1096         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1097         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1098         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1099         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Added.
1100         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
1101         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
1102         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Added.
1103         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
1104         * DumpRenderTree/mac/DumpRenderTree.mm:
1105         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
1106         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1107         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1108         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
1109         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1110         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1111         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1112         * DumpRenderTree/mac/EditingDelegate.h:
1113         * DumpRenderTree/mac/EventSendingController.h:
1114         * DumpRenderTree/mac/EventSendingController.mm:
1115         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1116         * DumpRenderTree/mac/HistoryDelegate.h:
1117         * DumpRenderTree/mac/LayoutTestHelper.m:
1118         * DumpRenderTree/mac/MockGeolocationProvider.mm:
1119         * DumpRenderTree/mac/NavigationController.h:
1120         * DumpRenderTree/mac/ObjCPlugin.h:
1121         * DumpRenderTree/mac/ObjCPlugin.m:
1122         * DumpRenderTree/mac/ObjCPluginFunction.h:
1123         * DumpRenderTree/mac/PolicyDelegate.h:
1124         * DumpRenderTree/mac/ResourceLoadDelegate.h:
1125         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1126         * DumpRenderTree/mac/TestRunnerMac.mm:
1127         * DumpRenderTree/mac/TextInputController.h:
1128         * DumpRenderTree/mac/TextInputController.m:
1129         * DumpRenderTree/mac/UIDelegate.h:
1130         * DumpRenderTree/mac/UIDelegate.mm:
1131
1132 2014-01-25  Darin Adler  <darin@apple.com>
1133
1134         Call deprecatedCharacters instead of characters at more call sites
1135         https://bugs.webkit.org/show_bug.cgi?id=127631
1136
1137         Reviewed by Sam Weinig.
1138
1139         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1140         (TestWebKitAPI::expectBuilderContent):
1141         (TestWebKitAPI::expectEmpty):
1142         (TestWebKitAPI::TEST):
1143         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1144         (TestWebKitAPI::TEST):
1145         Use the new name.
1146
1147 2014-01-25  Anders Carlsson  <andersca@apple.com>
1148
1149         Modernize HashTable threading code
1150         https://bugs.webkit.org/show_bug.cgi?id=127621
1151
1152         Reviewed by Darin Adler.
1153
1154         Explicitly include headers that used to be brought in by HashTable.h
1155
1156         * DumpRenderTree/JavaScriptThreading.cpp:
1157
1158 2014-01-24  Eric Carlson  <eric.carlson@apple.com>
1159
1160         Unreviewed. Add Philip Jägenstedt to watch and contributor lists.
1161
1162         * Scripts/webkitpy/common/config/contributors.json:
1163         * Scripts/webkitpy/common/config/watchlist:
1164
1165 2014-01-23  David Farler  <dfarler@apple.com>
1166
1167         Make WebKitTestRunner work with iOS
1168         https://bugs.webkit.org/show_bug.cgi?id=127448
1169
1170         Reviewed by Simon Fraser.
1171
1172         Combined patch from Simon below with some additional xcconfig cleanups,
1173         rebasing and stubbing out a couple of new functions that popped up
1174         since then.
1175
1176         2013-12-03  Simon Fraser  <simon.fraser@apple.com>
1177
1178                 <rdar://problem/15515469> Get WebKitTestRunner working on iOS
1179
1180                 Get WebKitTestRunner limping on iOS. Main parts:
1181                 - Stub out lots of accessibility-related functions.
1182                 - Stub out EventSender
1183                 - Create target to make a bundled app that runs in the simulator,
1184                   and copy the injected bundle library into it.
1185                 - Make a UIWindow and WKView to load tests in
1186
1187                 It runs, load tests, and dumps results to output. More work will be
1188                 required once we can execute it via the webkitpy scripts.
1189
1190         * WebKitTestRunner/Configurations/Base.xcconfig:
1191         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1192         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
1193         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1194         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm: Added.
1195         (WTR::AccessibilityController::addNotificationListener):
1196         (WTR::AccessibilityController::removeNotificationListener):
1197         (WTR::AccessibilityController::platformName):
1198         (WTR::AccessibilityController::logAccessibilityEvents):
1199         (WTR::AccessibilityController::resetToConsistentState):
1200         (WTR::findAccessibleObjectById):
1201         (WTR::AccessibilityController::accessibleElementById):
1202         * WebKitTestRunner/InjectedBundle/ios/AccessibilityNotificationHandler.h: Added.
1203         * WebKitTestRunner/InjectedBundle/ios/AccessibilityTextMarkerIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
1204         (WTR::AccessibilityTextMarker::isEqual):
1205         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: Added.
1206         (WTR::AccessibilityUIElement::AccessibilityUIElement):
1207         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
1208         (WTR::AccessibilityUIElement::isEqual):
1209         (WTR::AccessibilityUIElement::getLinkedUIElements):
1210         (WTR::AccessibilityUIElement::getDocumentLinks):
1211         (WTR::AccessibilityUIElement::getChildren):
1212         (WTR::AccessibilityUIElement::getChildrenWithRange):
1213         (WTR::AccessibilityUIElement::childrenCount):
1214         (WTR::AccessibilityUIElement::elementAtPoint):
1215         (WTR::AccessibilityUIElement::indexOfChild):
1216         (WTR::AccessibilityUIElement::childAtIndex):
1217         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
1218         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
1219         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
1220         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
1221         (WTR::AccessibilityUIElement::rowAtIndex):
1222         (WTR::AccessibilityUIElement::selectedChildAtIndex):
1223         (WTR::AccessibilityUIElement::selectedChildrenCount):
1224         (WTR::AccessibilityUIElement::selectedRowAtIndex):
1225         (WTR::AccessibilityUIElement::titleUIElement):
1226         (WTR::AccessibilityUIElement::parentElement):
1227         (WTR::AccessibilityUIElement::disclosedByRow):
1228         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
1229         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
1230         (WTR::AccessibilityUIElement::attributesOfChildren):
1231         (WTR::AccessibilityUIElement::allAttributes):
1232         (WTR::AccessibilityUIElement::stringAttributeValue):
1233         (WTR::AccessibilityUIElement::numberAttributeValue):
1234         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
1235         (WTR::AccessibilityUIElement::uiElementAttributeValue):
1236         (WTR::AccessibilityUIElement::boolAttributeValue):
1237         (WTR::AccessibilityUIElement::isAttributeSettable):
1238         (WTR::AccessibilityUIElement::isAttributeSupported):
1239         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
1240         (WTR::AccessibilityUIElement::role):
1241         (WTR::AccessibilityUIElement::subrole):
1242         (WTR::AccessibilityUIElement::roleDescription):
1243         (WTR::AccessibilityUIElement::title):
1244         (WTR::AccessibilityUIElement::description):
1245         (WTR::AccessibilityUIElement::orientation):
1246         (WTR::AccessibilityUIElement::stringValue):
1247         (WTR::AccessibilityUIElement::language):
1248         (WTR::AccessibilityUIElement::helpText):
1249         (WTR::AccessibilityUIElement::x):
1250         (WTR::AccessibilityUIElement::y):
1251         (WTR::AccessibilityUIElement::width):
1252         (WTR::AccessibilityUIElement::height):
1253         (WTR::AccessibilityUIElement::clickPointX):
1254         (WTR::AccessibilityUIElement::clickPointY):
1255         (WTR::AccessibilityUIElement::intValue):
1256         (WTR::AccessibilityUIElement::minValue):
1257         (WTR::AccessibilityUIElement::maxValue):
1258         (WTR::AccessibilityUIElement::valueDescription):
1259         (WTR::AccessibilityUIElement::insertionPointLineNumber):
1260         (WTR::AccessibilityUIElement::isPressActionSupported):
1261         (WTR::AccessibilityUIElement::isIncrementActionSupported):
1262         (WTR::AccessibilityUIElement::isDecrementActionSupported):
1263         (WTR::AccessibilityUIElement::isEnabled):
1264         (WTR::AccessibilityUIElement::isRequired):
1265         (WTR::AccessibilityUIElement::isFocused):
1266         (WTR::AccessibilityUIElement::isSelected):
1267         (WTR::AccessibilityUIElement::isSelectedOptionActive):
1268         (WTR::AccessibilityUIElement::isIndeterminate):
1269         (WTR::AccessibilityUIElement::isExpanded):
1270         (WTR::AccessibilityUIElement::isChecked):
1271         (WTR::AccessibilityUIElement::hierarchicalLevel):
1272         (WTR::AccessibilityUIElement::classList):
1273         (WTR::AccessibilityUIElement::speak):
1274         (WTR::AccessibilityUIElement::ariaIsGrabbed):
1275         (WTR::AccessibilityUIElement::ariaDropEffects):
1276         (WTR::AccessibilityUIElement::lineForIndex):
1277         (WTR::AccessibilityUIElement::rangeForLine):
1278         (WTR::AccessibilityUIElement::rangeForPosition):
1279         (WTR::AccessibilityUIElement::boundsForRange):
1280         (WTR::AccessibilityUIElement::stringForRange):
1281         (WTR::AccessibilityUIElement::attributedStringForRange):
1282         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1283         (WTR::uiElementCountForSearchPredicate):
1284         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
1285         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1286         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1287         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1288         (WTR::AccessibilityUIElement::attributesOfColumns):
1289         (WTR::AccessibilityUIElement::attributesOfRows):
1290         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1291         (WTR::AccessibilityUIElement::attributesOfHeader):
1292         (WTR::AccessibilityUIElement::rowCount):
1293         (WTR::AccessibilityUIElement::columnCount):
1294         (WTR::AccessibilityUIElement::indexInTable):
1295         (WTR::AccessibilityUIElement::rowIndexRange):
1296         (WTR::AccessibilityUIElement::columnIndexRange):
1297         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1298         (WTR::AccessibilityUIElement::horizontalScrollbar):
1299         (WTR::AccessibilityUIElement::verticalScrollbar):
1300         (WTR::AccessibilityUIElement::scrollToMakeVisible):
1301         (WTR::AccessibilityUIElement::selectedTextRange):
1302         (WTR::AccessibilityUIElement::setSelectedTextRange):
1303         (WTR::AccessibilityUIElement::increment):
1304         (WTR::AccessibilityUIElement::decrement):
1305         (WTR::AccessibilityUIElement::showMenu):
1306         (WTR::AccessibilityUIElement::press):
1307         (WTR::AccessibilityUIElement::setSelectedChild):
1308         (WTR::AccessibilityUIElement::accessibilityValue):
1309         (WTR::AccessibilityUIElement::documentEncoding):
1310         (WTR::AccessibilityUIElement::documentURI):
1311         (WTR::AccessibilityUIElement::url):
1312         (WTR::AccessibilityUIElement::addNotificationListener):
1313         (WTR::AccessibilityUIElement::removeNotificationListener):
1314         (WTR::AccessibilityUIElement::isFocusable):
1315         (WTR::AccessibilityUIElement::isSelectable):
1316         (WTR::AccessibilityUIElement::isMultiSelectable):
1317         (WTR::AccessibilityUIElement::isVisible):
1318         (WTR::AccessibilityUIElement::isOffScreen):
1319         (WTR::AccessibilityUIElement::isCollapsed):
1320         (WTR::AccessibilityUIElement::isIgnored):
1321         (WTR::AccessibilityUIElement::hasPopup):
1322         (WTR::AccessibilityUIElement::takeFocus):
1323         (WTR::AccessibilityUIElement::takeSelection):
1324         (WTR::AccessibilityUIElement::addSelection):
1325         (WTR::AccessibilityUIElement::removeSelection):
1326         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
1327         (WTR::AccessibilityUIElement::textMarkerRangeLength):
1328         (WTR::AccessibilityUIElement::previousTextMarker):
1329         (WTR::AccessibilityUIElement::nextTextMarker):
1330         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
1331         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
1332         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
1333         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
1334         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
1335         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
1336         (WTR::AccessibilityUIElement::textMarkerForPoint):
1337         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
1338         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
1339         (WTR::AccessibilityUIElement::indexForTextMarker):
1340         (WTR::AccessibilityUIElement::isTextMarkerValid):
1341         (WTR::AccessibilityUIElement::textMarkerForIndex):
1342         (WTR::AccessibilityUIElement::startTextMarker):
1343         (WTR::AccessibilityUIElement::endTextMarker):
1344         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
1345         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
1346         (WTR::AccessibilityUIElement::pathDescription):
1347         (WTR::AccessibilityUIElement::supportedActions):
1348         * WebKitTestRunner/InjectedBundle/ios/ActivateFontsIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
1349         (WTR::activateFonts):
1350         * WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm: Added.
1351         (WTR::EventSenderProxy::EventSenderProxy):
1352         (WTR::EventSenderProxy::~EventSenderProxy):
1353         (WTR::EventSenderProxy::updateClickCountForButton):
1354         (WTR::EventSenderProxy::mouseDown):
1355         (WTR::EventSenderProxy::mouseUp):
1356         (WTR::EventSenderProxy::mouseMoveTo):
1357         (WTR::EventSenderProxy::leapForward):
1358         (WTR::EventSenderProxy::keyDown):
1359         (WTR::EventSenderProxy::mouseScrollBy):
1360         (WTR::EventSenderProxy::continuousMouseScrollBy):
1361         (WTR::EventSenderProxy::addTouchPoint):
1362         (WTR::EventSenderProxy::updateTouchPoint):
1363         (WTR::EventSenderProxy::setTouchModifier):
1364         (WTR::EventSenderProxy::setTouchPointRadius):
1365         (WTR::EventSenderProxy::touchStart):
1366         (WTR::EventSenderProxy::touchMove):
1367         (WTR::EventSenderProxy::touchEnd):
1368         (WTR::EventSenderProxy::touchCancel):
1369         (WTR::EventSenderProxy::clearTouchPoints):
1370         (WTR::EventSenderProxy::releaseTouchPoint):
1371         (WTR::EventSenderProxy::cancelTouchPoint):
1372         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
1373         (WTR::InjectedBundle::platformInitialize):
1374         * WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
1375         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
1376         * WebKitTestRunner/Makefile:
1377         * WebKitTestRunner/TestController.cpp:
1378         (WTR::TestController::initialize):
1379         * WebKitTestRunner/TestController.h:
1380         * WebKitTestRunner/TestInvocation.cpp:
1381         (WTR::TestInvocation::invoke):
1382         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1383         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1384         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Added.
1385         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Added.
1386         (-[AppDelegate application:didFinishLaunchingWithOptions:]):
1387         (-[AppDelegate applicationWillResignActive:]):
1388         (-[AppDelegate applicationDidEnterBackground:]):
1389         (-[AppDelegate applicationWillEnterForeground:]):
1390         (-[AppDelegate applicationDidBecomeActive:]):
1391         (-[AppDelegate applicationWillTerminate:]):
1392         * WebKitTestRunner/WebKitTestRunnerApp/Images.xcassets/AppIcon.appiconset/Contents.json: Added.
1393         * WebKitTestRunner/WebKitTestRunnerApp/Images.xcassets/LaunchImage.launchimage/Contents.json: Added.
1394         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist: Added.
1395         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Prefix.pch: Added.
1396         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Added.
1397         * WebKitTestRunner/WebKitTestRunnerApp/main.m: Added.
1398         (main):
1399         * WebKitTestRunner/WebKitTestRunnerAppTests-Info.plist: Added.
1400         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Added.
1401         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Added.
1402         (-[WebKitTestRunnerAppTests setUp]):
1403         (-[WebKitTestRunnerAppTests tearDown]):
1404         (-[WebKitTestRunnerAppTests testExample]):
1405         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Added.
1406         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1407         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1408         * WebKitTestRunner/iOS.xcconfig: Added.
1409         * WebKitTestRunner/ios/PlatformWebViewIOS.mm: Added.
1410         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useTiledDrawing:]):
1411         (-[TestRunnerWKView _shouldUseTiledDrawingArea]):
1412         (-[WebKitTestRunnerWindow isKeyWindow]):
1413         (-[WebKitTestRunnerWindow setFrameOrigin:]):
1414         (-[WebKitTestRunnerWindow setFrame:]):
1415         (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
1416         (-[WebKitTestRunnerWindow backingScaleFactor]):
1417         (WTR::PlatformWebView::PlatformWebView):
1418         (WTR::PlatformWebView::resizeTo):
1419         (WTR::PlatformWebView::~PlatformWebView):
1420         (WTR::PlatformWebView::page):
1421         (WTR::PlatformWebView::focus):
1422         (WTR::PlatformWebView::windowFrame):
1423         (WTR::PlatformWebView::setWindowFrame):
1424         (WTR::PlatformWebView::didInitializeClients):
1425         (WTR::PlatformWebView::addChromeInputField):
1426         (WTR::PlatformWebView::removeChromeInputField):
1427         (WTR::PlatformWebView::makeWebViewFirstResponder):
1428         (WTR::PlatformWebView::windowSnapshotImage):
1429         (WTR::PlatformWebView::viewSupportsOptions):
1430         * WebKitTestRunner/ios/TestControllerIOS.mm: Added.
1431         (WTR::TestController::notifyDone):
1432         (WTR::TestController::platformInitialize):
1433         (WTR::TestController::platformDestroy):
1434         (WTR::TestController::initializeInjectedBundlePath):
1435         (WTR::TestController::initializeTestPluginDirectory):
1436         (WTR::TestController::platformRunUntil):
1437         (WTR::TestController::platformInitializeContext):
1438         (WTR::TestController::runModal):
1439         (WTR::TestController::platformLibraryPathForTesting):
1440         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
1441         (createCFURLResponseFromResponseData):
1442         (supportedNonImageMIMETypes):
1443         * WebKitTestRunner/ios/mainIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
1444         (-[WebKitTestRunnerApp _runTestController]):
1445         (-[WebKitTestRunnerApp applicationDidFinishLaunching:]):
1446         (main):
1447
1448 2014-01-24  Enrique Ocaña González  <eocanha@igalia.com>
1449
1450         [GTK] Put cache files in XDG_CACHE_HOME
1451         https://bugs.webkit.org/show_bug.cgi?id=123458
1452
1453         Reviewed by Martin Robinson.
1454
1455         * GtkLauncher/main.c:
1456         (createBrowser):
1457
1458 2014-01-23  Max Vujovic  <mvujovic@adobe.com>
1459
1460         Remove CSS Custom Filters code and tests
1461         https://bugs.webkit.org/show_bug.cgi?id=127382
1462
1463         Reviewed by Simon Fraser.
1464
1465         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1466         (resetDefaultsToConsistentValues):
1467         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1468         (TestRunner::overridePreference):
1469
1470 2014-01-23  Tim Horton  <timothy_horton@apple.com>
1471
1472         PDFPlugin: Use PDFPlugin even if there's an external plugin installed, if it's blocked
1473         https://bugs.webkit.org/show_bug.cgi?id=127415
1474         <rdar://problem/12482452>
1475
1476         Reviewed by Sam Weinig.
1477
1478         Adopt the new page loader client plugin load callback.
1479
1480         * WebKitTestRunner/TestController.cpp:
1481         (WTR::TestController::createWebViewWithOptions):
1482         (WTR::TestController::pluginLoadPolicy):
1483         * WebKitTestRunner/TestController.h:
1484
1485 2014-01-23  peavo@outlook.com  <peavo@outlook.com>
1486
1487         [Curl] There is no way to specify cache folder.
1488         https://bugs.webkit.org/show_bug.cgi?id=125028
1489
1490         Reviewed by Brent Fulgham.
1491
1492         Enable disc cache in WinLauncher by setting cache folder location.
1493
1494         * WinLauncher/WinLauncher.cpp:
1495         (getAppDataFolder): Added function to get app data folder.
1496         (setCacheFolder): Added function to set cache folder.
1497         (createCrashReport): Use new getAppDataFolder function.
1498         (wWinMain): Use function setCacheFolder to set cache folder location.
1499
1500 2014-01-23  Daniel Bates  <dabates@apple.com>
1501
1502         build-webkit --sdk=iphonesimulator doesn't think it's building iOS
1503         https://bugs.webkit.org/show_bug.cgi?id=127379
1504
1505         Reviewed by Simon Fraser.
1506
1507         Teach build-webkit to recognize --sdk=X.
1508
1509         Currently, build-webkit recognizes --sdk X to specify X as the Xcode SDK to use, which is also
1510         considered when determining the WebKit port to build. But build-webkit advertises --sdk=X in its
1511         help message. We should teach build-webkit to recognize both --sdk X and --sdk=X to make its handling
1512         of --sdk more consistent with the handling of other build-webkit options that take a value (e.g. --prefix).
1513
1514         * Scripts/webkitdirs.pm:
1515         (checkForArgumentAndRemoveFromArrayRefGettingValue): Added.
1516         (checkForArgumentAndRemoveFromARGVGettingValue): Modified to call checkForArgumentAndRemoveFromArrayRefGettingValue().
1517         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl: Added.
1518
1519 2014-01-23  Commit Queue  <commit-queue@webkit.org>
1520
1521         Unreviewed, rolling out r162612.
1522         http://trac.webkit.org/changeset/162612
1523         https://bugs.webkit.org/show_bug.cgi?id=127488
1524
1525         broke the build (Requested by mhahnenberg on #webkit).
1526
1527         * Scripts/build-jsc:
1528         * jsc-cli/jsc-cli.xcodeproj/project.pbxproj: Removed.
1529         * jsc-cli/jsc-cli/CLIInstance.h: Removed.
1530         * jsc-cli/jsc-cli/CLIInstance.m: Removed.
1531         * jsc-cli/jsc-cli/JSModule.h: Removed.
1532         * jsc-cli/jsc-cli/JSModule.m: Removed.
1533         * jsc-cli/jsc-cli/JSRunLoopThread.h: Removed.
1534         * jsc-cli/jsc-cli/JSRunLoopThread.m: Removed.
1535         * jsc-cli/jsc-cli/ReadEvalPrintLoop.h: Removed.
1536         * jsc-cli/jsc-cli/ReadEvalPrintLoop.m: Removed.
1537         * jsc-cli/jsc-cli/RunLoopThread.h: Removed.
1538         * jsc-cli/jsc-cli/RunLoopThread.m: Removed.
1539         * jsc-cli/jsc-cli/ScriptInputSource.h: Removed.
1540         * jsc-cli/jsc-cli/ScriptInputSource.m: Removed.
1541         * jsc-cli/jsc-cli/main.m: Removed.
1542
1543 2014-01-23  Mark Hahnenberg  <mhahnenberg@apple.com>
1544
1545         Basic framework for a modern jsc CLI
1546         https://bugs.webkit.org/show_bug.cgi?id=127435
1547
1548         Reviewed by Geoffrey Garen.
1549
1550         The most basic components of a modern jsc command line interface consist of the following:
1551
1552         - A simple REPL to enter commands and receive results
1553         - The ability to define a module (which consists of various internal methods as well as a 
1554           set of externally visible methods)
1555         - The ability to load other modules at runtime
1556         - The ability to interact with the underlying platform to perform various "privileged" 
1557           functions (e.g. opening files, printing to the stdout, etc.)
1558         
1559         The basic architecture will look something like the following:
1560         - If the tool is run in REPL mode (i.e. no command line arguments), it will start the REPL 
1561           on the main thread and start a secondary thread with a run loop to handle various inputs 
1562           from the REPL thread.
1563         - If the tool is given a script to run, it will evaluate that script (and any scripts that 
1564           it might transitively load) within the run loop on the secondary thread while the main 
1565           thread blocks until it has completed.
1566
1567         * Scripts/build-jsc:
1568         * jsc-cli: Added.
1569         * jsc-cli/jsc-cli: Added.
1570         * jsc-cli/jsc-cli.xcodeproj: Added.
1571         * jsc-cli/jsc-cli.xcodeproj/project.pbxproj: Added.
1572         * jsc-cli/jsc-cli/CLIInstance.h: Added.
1573         * jsc-cli/jsc-cli/CLIInstance.m: Added.
1574         (-[CLIInstance init]):
1575         (-[CLIInstance loadFile:]):
1576         (-[CLIInstance run]):
1577         * jsc-cli/jsc-cli/JSModule.h: Added.
1578         * jsc-cli/jsc-cli/JSModule.m: Added.
1579         (coreModules):
1580         (isCoreModule):
1581         (classForModule):
1582         (coreModuleFullPath):
1583         (resolveModuleAsFile):
1584         (resolveModuleAsDirectory):
1585         (nodeModulePaths):
1586         (resolveAsNodeModule):
1587         (+[JSModule resolve:atPath:]):
1588         (globalModuleCache):
1589         (isCached):
1590         (cachedModule):
1591         (cacheModule):
1592         (+[JSModule require:atPath:]):
1593         (+[JSModule require:atPath:inContext:]):
1594         (-[JSModule platformObjectInContext:]):
1595         (-[JSModule initWithId:filename:context:]):
1596         (-[JSModule dealloc]):
1597         (-[JSModule didStartLoading]):
1598         (-[JSModule didFinishLoading]):
1599         (-[JSModule require:]):
1600         (-[JSModule exports]):
1601         * jsc-cli/jsc-cli/JSRunLoopThread.h: Added.
1602         * jsc-cli/jsc-cli/JSRunLoopThread.m: Added.
1603         (jsThreadMain):
1604         (+[JSRunLoopThread threadMain]):
1605         (-[JSRunLoopThread initWithFiles:andContext:]):
1606         (-[JSRunLoopThread startRunLoop]):
1607         (-[JSRunLoopThread start]):
1608         (-[JSRunLoopThread join]):
1609         (-[JSRunLoopThread didReceiveInput:]):
1610         (-[JSRunLoopThread performCallback:withError:]):
1611         (-[JSRunLoopThread performCallback:withArguments:]):
1612         (-[JSRunLoopThread didFinishRunLoopInitialization]):
1613         * jsc-cli/jsc-cli/ReadEvalPrintLoop.h: Added.
1614         * jsc-cli/jsc-cli/ReadEvalPrintLoop.m: Added.
1615         (-[ReadEvalPrintLoop initWithJSThread:]):
1616         (prompt):
1617         (escapeStringForOutput):
1618         (-[ReadEvalPrintLoop processNextInput]):
1619         (-[ReadEvalPrintLoop run]):
1620         * jsc-cli/jsc-cli/RunLoopThread.h: Added.
1621         * jsc-cli/jsc-cli/RunLoopThread.m: Added.
1622         (+[RunLoopThread threadMain]):
1623         (-[RunLoopThread init]):
1624         (-[RunLoopThread dealloc]):
1625         (-[RunLoopThread didFinishRunLoopInitialization]):
1626         (-[RunLoopThread start]):
1627         (-[RunLoopThread join]):
1628         * jsc-cli/jsc-cli/ScriptInputSource.h: Added.
1629         * jsc-cli/jsc-cli/ScriptInputSource.m: Added.
1630         (scriptInputSourceScheduleRoutine):
1631         (scriptInputSourcePerformRoutine):
1632         (scriptInputSourceCancelRoutine):
1633         (-[ScriptInputSource initWithContext:]):
1634         (-[ScriptInputSource dealloc]):
1635         (-[ScriptInputSource addToCurrentRunLoop]):
1636         (-[ScriptInputSource removeFromRemoteRunLoop]):
1637         (-[ScriptInputSource didReceiveScript:]):
1638         (-[ScriptInputSource didReceiveSignal]):
1639         (-[ScriptInputSource runScriptRemotely:]):
1640         (-[ScriptInputSource finishAsyncCallback:withResult:]):
1641         * jsc-cli/jsc-cli/main.m: Added.
1642         (main):
1643
1644 2014-01-23  László Langó  <llango.u-szeged@partner.samsung.com>
1645
1646         Remove a FIXME comment that is already fixed.
1647         https://bugs.webkit.org/show_bug.cgi?id=127468
1648
1649         Reviewed by Csaba Osztrogonác.
1650
1651         * Scripts/webkitpy/style/filereader.py:
1652         (TextFileReader.__init__):
1653
1654 2014-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1655
1656         [GLIB] Use GUniquePtr instead of GOwnPtr
1657         https://bugs.webkit.org/show_bug.cgi?id=127431
1658
1659         Reviewed by Martin Robinson.
1660
1661         GUniquePtr is a template alias of std::unique_ptr with a custom
1662         deleter that replaces GOwnPtr. GOwnPtr is still used for the cases
1663         where the output pointer is needed, but it will also be replaced soon.
1664
1665         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
1666         (printAccessibilityEvent):
1667         (axObjectEventListener):
1668         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1669         (indexRangeInTable):
1670         (AccessibilityUIElement::role):
1671         (AccessibilityUIElement::title):
1672         (AccessibilityUIElement::description):
1673         (AccessibilityUIElement::stringValue):
1674         (AccessibilityUIElement::language):
1675         (AccessibilityUIElement::lineForIndex):
1676         (AccessibilityUIElement::selectedTextRange):
1677         (AccessibilityUIElement::url):
1678         * DumpRenderTree/efl/AccessibilityControllerEfl.cpp:
1679         (AccessibilityController::accessibleElementById):
1680         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1681         (AccessibilityController::accessibleElementById):
1682         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1683         (getOutputDir):
1684         (getFontsPath):
1685         (initializeFonts):
1686         (dumpFramesAsText):
1687         (compareHistoryItems):
1688         (dumpHistoryItem):
1689         (soupURIToStringPreservingPassword):
1690         (resetDefaultsToConsistentValues):
1691         (temporaryDatabaseDirectory):
1692         (webViewTitleChanged):
1693         (webFrameLoadStatusNotified):
1694         (pathFromSoupURI):
1695         (convertWebResourceToURLPath):
1696         (urlSuitableForTestResult):
1697         (descriptionSuitableForTestResult):
1698         (willSendRequestCallback):
1699         (frameLoadEventCallback):
1700         * DumpRenderTree/gtk/EditingCallbacks.cpp:
1701         (dumpNodePath):
1702         (dumpRange):
1703         (shouldApplyStyle):
1704         * DumpRenderTree/gtk/EventSender.cpp:
1705         (contextClickCallback):
1706         (beginDragWithFilesCallback):
1707         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1708         (TestRunner::pathToLocalResource):
1709         (TestRunner::queueLoad):
1710         (TestRunner::removeOriginAccessWhitelistEntry):
1711         (TestRunner::setMockGeolocationPositionUnavailableError):
1712         (TestRunner::setIconDatabaseEnabled):
1713         (TestRunner::findString):
1714         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
1715         (TestRunner::overridePreference):
1716         (TestRunner::addUserScript):
1717         (TestRunner::addUserStyleSheet):
1718         (TestRunner::setTextDirection):
1719         * DumpRenderTree/gtk/TextInputController.cpp:
1720         (setMarkedTextCallback):
1721         (insertTextCallback):
1722         (doCommandCallback):
1723         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1724         (LoadHTMLStringItem::invoke):
1725         * TestWebKitAPI/PlatformGTK.cmake:
1726         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
1727         (WebKitDOMNodeTest::testTagNames):
1728         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
1729         (testBackForwardListLimitAndCache):
1730         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1731         (testContextMenuSmartSeparators):
1732         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
1733         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1734         (testDownloadLocalFile):
1735         (testDownloadLocalFileError):
1736         (addContentDispositionHTTPHeaderToResponse):
1737         (serverCallback):
1738         (testDownloadRemoteFileError):
1739         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
1740         (startTestServer):
1741         (testInspectorServerPageList):
1742         (openRemoteDebuggingSession):
1743         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
1744         (testPrintOperationPrint):
1745         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1746         (addCacheHTTPHeadersToResponse):
1747         (serverCallback):
1748         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1749         (httpsServerCallback):
1750         (httpServerCallback):
1751         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1752         (testWebViewJavaScriptDialogs):
1753         (testWebViewWindowProperties):
1754         (testWebViewFileChooserRequest):
1755         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
1756         (testWebExtensionWindowObjectCleared):
1757         (testWebExtensionIsolatedWorld):
1758         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp:
1759         (startTestServer):
1760         (checkAtspiAccessible):
1761         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1762         (serverCallback):
1763         (testClearDatabase):
1764         (testGetFaviconURI):
1765         (webkitFaviconDatabaseFinalizedCallback):
1766         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1767         (testWebContextGetPlugins):
1768         (testWebContextURIScheme):
1769         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1770         (testWebViewRunJavaScript):
1771         (testWebViewMode):
1772         (testWebViewPageVisibility):
1773         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp:
1774         (isStyleSheetInjectedForURLAtPath):
1775         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
1776         (testWebViewEditorCutCopyPasteNonEditable):
1777         (testWebViewEditorCutCopyPasteEditable):
1778         (testWebViewEditorSelectAllNonEditable):
1779         (testWebViewEditorSelectAllEditable):
1780         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1781         (sendRequestCallback):
1782         (methodCallCallback):
1783         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
1784         (TestWebKitAPI::Util::createInjectedBundlePath):
1785         (TestWebKitAPI::Util::createURLForResource):
1786         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
1787         (TestWebKitAPI::doKeyStroke):
1788         (TestWebKitAPI::doMouseButtonEvent):
1789         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
1790         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1791         (loadFailedCallback):
1792         (LoadTrackingTest::loadURI):
1793         (LoadTrackingTest::loadHtml):
1794         (LoadTrackingTest::loadPlainText):
1795         (LoadTrackingTest::loadRequest):
1796         (LoadTrackingTest::reload):
1797         (LoadTrackingTest::goBack):
1798         (LoadTrackingTest::goForward):
1799         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
1800         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
1801         (registerGResource):
1802         (removeNonEmptyDirectory):
1803         (main):
1804         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1805         (Test::getWebKit1TestResoucesDir):
1806         (Test::getResourcesDir):
1807         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:
1808         (WebKitTestBus::run):
1809         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
1810         (WebKitTestServer::WebKitTestServer):
1811         (WebKitTestServer::getURIForPath):
1812         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp:
1813         (WebProcessTestRunner::runTest):
1814         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1815         (resourceGetDataCallback):
1816         (WebViewTest::mainResourceData):
1817         (WebViewTest::mouseMoveTo):
1818         (WebViewTest::keyStroke):
1819         (WebViewTest::doMouseButtonEvent):
1820         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
1821         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1822         (WTR::AccessibilityController::accessibleElementById):
1823         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1824         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1825         (WTR::AccessibilityUIElement::role):
1826         (WTR::AccessibilityUIElement::title):
1827         (WTR::AccessibilityUIElement::description):
1828         (WTR::AccessibilityUIElement::stringValue):
1829         (WTR::AccessibilityUIElement::language):
1830         (WTR::AccessibilityUIElement::lineForIndex):
1831         (WTR::AccessibilityUIElement::selectedTextRange):
1832         (WTR::AccessibilityUIElement::url):
1833         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1834         (WTR::getOutputDir):
1835         (WTR::getFontsPath):
1836         (WTR::initializeFontConfigSetting):
1837         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1838         (WTR::topLevelPath):
1839         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1840         (WTR::TestRunner::pathToLocalResource):
1841         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1842         (WTR::TestController::initializeInjectedBundlePath):
1843         (WTR::TestController::initializeTestPluginDirectory):
1844
1845 2014-01-05  Martin Robinson  <mrobinson@igalia.com>
1846
1847         [GTK] [CMake] run-webkit-tests should support the CMake build
1848         https://bugs.webkit.org/show_bug.cgi?id=126503
1849
1850         Reviewed by Daniel Bates.
1851
1852         Update run-launcher and gtk.py to work properly when dealing with the CMake port.
1853         run-webkit-tests does not need the --gtkcmake flag, but run-launcher does.
1854
1855         * Scripts/run-launcher: Work properly with the gtkcmake flag.
1856         * Scripts/webkitpy/port/gtk.py:
1857         (GtkPort._is_cmake_build): Added this helper which looks for the CMakeCache
1858         file to detect a CMake build.
1859         (GtkPort._built_executables_path): Added this helper to locate the built executable path.
1860         (GtkPort._built_libraries_path): Added this helper to locate the built library path.
1861         (GtkPort._port_flag_for_scripts): Use --gtkcmake when appropriate.
1862         (GtkPort.setup_environ_for_server): The way CMake builds libraries differs from GTK+.
1863         (GtkPort._path_to_driver): Use the new helper.
1864         (GtkPort._path_to_image_diff): Use the new helper.
1865         (GtkPort._path_to_webcore_library): Use the new helper.
1866         (GtkPort.build_webkit_command): Use --gtkcmake when appropriate.
1867
1868 2014-01-22  Ryuan Choi  <ryuan.choi@samsung.com>
1869
1870         [EFL] Remove unnecessary smart method since ewk_view_tiled removed
1871         https://bugs.webkit.org/show_bug.cgi?id=127417
1872
1873         Reviewed by Gyuyoung Kim.
1874
1875         * EWebLauncher/main.c:
1876         (on_key_down): Removed shortcut to test pre render.
1877
1878 2014-01-22  Myles C. Maxfield  <mmaxfield@apple.com>
1879
1880         Remove CSS3_TEXT_DECORATION define
1881         https://bugs.webkit.org/show_bug.cgi?id=127333
1882
1883         This is required for unprefixing the text-decoration-* CSS properties.
1884
1885         Reviewed by Simon Fraser.
1886
1887         * Configurations/FeatureDefines.xcconfig:
1888
1889 2014-01-22  Andy Estes  <aestes@apple.com>
1890
1891         [iOS] Prepare for upstreaming DumpRenderTree changes
1892         https://bugs.webkit.org/show_bug.cgi?id=127412
1893
1894         Reviewed by Simon Fraser.
1895
1896         Unlike on Mac where DumpRenderTree is a command-line tool, on iOS it is
1897         an application bundle. Instead of upstreaming a separate target for the
1898         app that duplicates the 'Compile Sources' phase of the tool, separate
1899         out the compilation into a static library target that both the
1900         command-line tool and the app can link against. Also, perform some
1901         unrelated cleanup.
1902
1903         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Updated the
1904         project file format from 2.4- to 3.2-compatible. Removed the
1905         'Copy Headers' build phase and removed all files from the
1906         'Compile Sources' build phase of DumpRenderTree. Added some files that
1907         were missing from the project. Created a 'DumpRenderTree (Library)'
1908         target for building the static library and made the 'DumpRenderTree'
1909         target depend on it. Added a 'Compile Sources' build phase to this
1910         target that builds the same files the DumpRenderTree target used to.
1911         Created DumpRenderTreeMain.mm as the only source file of the
1912         DumpRenderTree target, since targets won't link a binary without at
1913         least one source file. Made DumpRenderTree (Library) use
1914         DumpRenderTreeLibrary.xcconfig and made LayoutTestHelper use
1915         BaseTarget.xcconfig (so that it doesn't try to link libDumpRenderTree.a).
1916         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Moved
1917         definitions of GCC_ENABLE_OBJC_EXCEPTIONS and GCC_PREFIX_HEADER from
1918         DumpRenderTree.xcconfig to here so that LayoutTestHelper can use them.
1919         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Passed
1920         -force_load $(BUILT_PRODUCTS_DIR)libDumpRenderTree.a to OTHER_LDFLAGS.
1921         This is needed to correctly link a static library containing an Objective-C
1922         category (see <https://developer.apple.com/library/mac/qa/qa1490/_index.html>).
1923         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Added.
1924         * DumpRenderTree/mac/DumpRenderTree.mm:
1925         (DumpRenderTreeMain): Renamed from main.
1926         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added declaration of DumpRenderTreeMain.
1927         * DumpRenderTree/mac/DumpRenderTreeMain.mm: Added.
1928         (main): Called DumpRenderTreeMain from main.
1929
1930 2014-01-15  Martin Robinson  <mrobinson@igalia.com>
1931
1932         [GTK][CMake] build-webkit should try harder to avoid re-running cmake
1933         https://bugs.webkit.org/show_bug.cgi?id=127073
1934
1935         Reviewed by Daniel Bates.
1936
1937         * Scripts/build-webkit: Unify all the ports that call buildCMakeProjectOrExit with
1938         the new isCMakeBuild conditional. This allows us to share more code between ports.
1939         Pass the build arguments to the removeCMakeCache function.
1940         * Scripts/webkitdirs.pm:
1941         (runAutogenForAutotoolsProjectIfNecessary): Renamed mustReRunAutogen to cachedArgumentFileOutOfDate
1942         because it's now shared with the CMake build.
1943         (cachedArgumentFileOutOfDate): Renamed.
1944         (cmakeCachePath): Added this helper which gets the CMakeCache.txt path.
1945         (shouldRemoveCMakeCache): Tries to preserve current behavior for all ports, 
1946         except GTK+ which examines the OptionsGTK.cmake and OptionsCommon.cmake file
1947         as well as checking if build-webkit has been run with different arguments.
1948         (removeCMakeCache): Call shouldRemoveCMakeCache now.
1949         (generateBuildSystemFromCMakeProject): Exit early if CMakeCache.txt exists for GTK+.
1950         (isCMakeBuild): Added.
1951
1952 2014-01-22  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
1953
1954         [EFL][GTK] Get EFL and GTK compiling with ACCESSIBILITY disabled
1955         https://bugs.webkit.org/show_bug.cgi?id=127119
1956
1957         Reviewed by Mario Sanchez Prada.
1958
1959         Guarding ACCESSIBILITY code in DumpRenderTree and WebKitTestRunner with HAVE(ACCESSIBILITY).
1960
1961         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1962         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1963         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1964         (resetDefaultsToConsistentValues):
1965         (webViewWindowObjectCleared):
1966         (main):
1967         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1968         (WTR::AccessibilityController::platformName):
1969         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1970         (WTR::AccessibilityUIElement::isIndeterminate):
1971
1972 2014-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1973
1974
1975         [GTK] Add GUniquePtr
1976         https://bugs.webkit.org/show_bug.cgi?id=127170
1977
1978         Reviewed by Gustavo Noronha Silva.
1979
1980         Add unit tests for GUniquePtr.
1981
1982         * TestWebKitAPI/GNUmakefile.am: Add new file to compilation.
1983         * TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp: Added.
1984         (log):
1985         (takeLogStr):
1986         (TestWebKitAPI::TEST):
1987
1988 2014-01-22  Jinwoo Song  <jinwoo7.song@samsung.com>
1989
1990         Remove Nix files from Tools
1991         https://bugs.webkit.org/show_bug.cgi?id=127418
1992
1993         Reviewed by Csaba Osztrogonác.
1994
1995         * Scripts/build-webkit:
1996         * Scripts/update-webkit-libs-jhbuild:
1997         * Scripts/webkitdirs.pm:
1998         (determineArchitecture):
1999         (argumentsForConfiguration):
2000         (jscProductDir):
2001         (builtDylibPathForName):
2002         (isAppleWebKit):
2003         (launcherPath):
2004         (launcherName):
2005         (checkRequiredSystemConfig):
2006         (copyInspectorFrontendFiles):
2007         (jhbuildWrapperPrefixIfNeeded):
2008         (buildCMakeProjectOrExit):
2009         (cmakeBasedPortName):
2010         * Scripts/webkitpy/common/config/ports.py:
2011         (DeprecatedPort.port):
2012         (EflWK2Port.build_webkit_command):
2013         * Scripts/webkitpy/port/factory.py:
2014         (platform_options):
2015         (PortFactory):
2016         * Scripts/webkitpy/port/nix.py: Removed.
2017         * Scripts/webkitpy/port/nix_unittest.py: Removed.
2018
2019 2014-01-21  Benjamin Poulain  <benjamin@webkit.org>
2020
2021         Add Ian and Ricky to the contributor list
2022
2023         * Scripts/webkitpy/common/config/contributors.json:
2024         I am too old to remember all those email addresses :)
2025
2026 2014-01-21  David Farler  <dfarler@apple.com>
2027
2028         Upstream package-root for iOS
2029
2030         Reviewed by Daniel bates.
2031
2032         * Scripts/package-root: Added.
2033         (usage):
2034         * Scripts/webkitdirs.pm:
2035         (XcodeSDKPath): Added function.
2036
2037 2014-01-21  Daniel Bates  <dabates@apple.com>
2038
2039         [iOS] Tools/Makefile shouldn't build modules DumpRenderTree, gtest, or TestWebKitAPI
2040         https://bugs.webkit.org/show_bug.cgi?id=127368
2041
2042         Reviewed by Tim Horton.
2043
2044         Similar to the build-webkit change in <https://bugs.webkit.org/show_bug.cgi?id=127364>,
2045         we don't want to build DumpRenderTree, gtest, or TestWebKitAPI when running make in
2046         Tools.
2047
2048         * Makefile:
2049
2050 2014-01-21  Daniel Bates  <dabates@apple.com>
2051
2052         [iOS] Don't build DumpRenderTree, gtest, or TestWebKitAPI
2053         https://bugs.webkit.org/show_bug.cgi?id=127364
2054
2055         Reviewed by Simon Fraser.
2056
2057         For now, don't build DumpRenderTree and TestWebKitAPI for iOS as these
2058         projects fail to build because we need to upstream the relevant iOS changes.
2059         Also, don't build gtest, which is a dependency of TestWebKitAPI since we
2060         aren't building TestWebKitAPI.
2061
2062         * Scripts/build-webkit:
2063
2064 2014-01-21  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2065
2066         Unreviewed, remove myself from some watchlist entries.
2067
2068         * Scripts/webkitpy/common/config/watchlist:
2069
2070 2014-01-21  Zalan Bujtas  <zalan@apple.com>
2071
2072         Use 64 as the default value for the subpixel denominator.
2073
2074         Reviewed by Simon Fraser.
2075
2076         * lldb/lldb_webkit.py:
2077         (WebCoreLayoutUnitProvider.to_string):
2078
2079 2014-01-21  ChangSeok Oh  <changseok.oh@collabora.com>
2080
2081         [GTK] Fix a c++11 compliance issue for fontconfig
2082         https://bugs.webkit.org/show_bug.cgi?id=127283
2083
2084         Reviewed by Martin Robinson.
2085
2086         fontconfig-2.8.0 is not compliant with C++11. So I propose to apply a
2087         hotfix until bumping fontconfig up.
2088
2089         * gtk/jhbuild.modules:
2090         * gtk/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
2091
2092 2014-01-21  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2093
2094         run-jsc-stress-tests should accept --child-processes option and WEBKIT_TEST_CHILD_PROCESSES env.var
2095         like run_webkit_test does
2096         https://bugs.webkit.org/show_bug.cgi?id=127349
2097
2098         Reviewed by Csaba Osztrogonác.
2099
2100         * Scripts/run-jsc-stress-tests:
2101
2102 2014-01-21  Adrian Perez de Castro  <aperez@igalia.com>
2103
2104         [GTK] Allow passing extra data to web extensions
2105         https://bugs.webkit.org/show_bug.cgi?id=125990
2106
2107         Reviewed by Carlos Garcia Campos.
2108
2109         Allow passing additional information to the injected bundle. On top
2110         of the string containing the path to the web extensions directory,
2111         a GVariant can be set with additional data using
2112         webkit_web_context_set_web_extensions_initialization_user_data().
2113         Also, a new initialize-web-extensions signal is emitted before
2114         launching a new WebProcess to allow setting different user data
2115         for each process. The GVariant is serialized as a string, passed
2116         to the injected bundle, and the injected bundle deserializes back
2117         the data, which is passed to web extensions which define the
2118         webkit_web_extension_initialize_with_user_data() function (for
2119         backwards compatibility, webkit_web_extension_initialize() is
2120         used as a fallback.)
2121
2122         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
2123         (initializeWebExtensions): Handles the initialize-web-extensions
2124         signal, and sets the web extensions directory and the initialization
2125         user data.
2126         (testWebExtensionInitializationUserData): New test case for checking
2127         the user data passed on initialization to web extensions.
2128         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2129         (methodCallCallback): Added implementation for the
2130         GetInitializationUserData D-Bus method, used by
2131         testWebExtensionInitializationUserData().
2132         (webkit_web_extension_initialize_with_user_data): Define the
2133         initialization function with the additional user data parameter.
2134
2135 2014-01-21  Siddharth Mathur  <s.mathur@ieee.org>
2136
2137         Change my email address in contributors.json.
2138
2139         Unreviewed.
2140
2141         * Scripts/webkitpy/common/config/contributors.json:
2142
2143 2014-01-21  Krzysztof Czech  <k.czech@samsung.com>
2144
2145         [ATK] Expose aria-flowto through ATK_RELATION_FLOWS_TO
2146         https://bugs.webkit.org/show_bug.cgi?id=127291
2147
2148         Reviewed by Mario Sanchez Prada.
2149
2150         Implemented AccessibilityUIElement::ariaFlowToElementAtIndex method.
2151
2152         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2153         (AccessibilityUIElement::ariaFlowToElementAtIndex):
2154         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2155         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
2156
2157 2014-01-20  Zalan Bujtas  <zalan@apple.com>
2158
2159         Force float division when calculating CSS px value.
2160
2161         Reviewed by Simon Fraser.
2162
2163         Note that in Python 3, this is the default behavior.
2164
2165         * lldb/lldb_webkit.py:
2166         (WebCoreLayoutUnitProvider.to_string):
2167
2168 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
2169
2170         build.webkit.org/dashboard should display information about patches in EWS
2171         https://bugs.webkit.org/show_bug.cgi?id=127006
2172
2173         Reviewed by Ryosuke Niwa.
2174
2175         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
2176         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Bugzilla.js: Added.
2177         (Bugzilla.prototype.detailsURLForAttachment):
2178         Added a class for Bugzilla. So far, the only thing it can do is build patch URLs,
2179         which is needed when one wants to do something with a patch EWS is stuck on.
2180
2181         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
2182         Create a Bugzilla instance.
2183
2184         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
2185         (EWS.prototype.jsonQueueLengthURL):
2186         (EWS.prototype.jsonQueueStatusURL):
2187         Build JSON ULRs here, not in EWSQueue, as this is how other classes are structured.
2188
2189         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
2190         (EWSQueue.prototype.get statusPageURL): Changed to use a URL provided by EWS instead
2191         of second guessing.
2192         (EWSQueue.prototype.get chartsPageURL): Added.
2193         (EWSQueue.prototype.get loadedDetailedStatus): Tells whether we currently have
2194         additional data already loaded (it's reset with every update).
2195         (EWSQueue.prototype.get patches): Get patch queue.
2196         (EWSQueue.prototype.get bots): Get bots.
2197         (EWSQueue.prototype.update): Changed to use a specialized cheaper URL.
2198         (EWSQueue.prototype.loadDetailedStatus): Load and transform detailed status JSON.
2199
2200         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
2201         (EWSQueueView.prototype.update.appendQueue): Add a popover is there are any patches
2202         in the queue.
2203         (EWSQueueView.prototype.addLinkToRow): A helper to build the popover.
2204         (EWSQueueView.prototype.addTextToRow): Ditto.
2205         (EWSQueueView.prototype._addQueueHeadingToPopover): Ditto.
2206         (EWSQueueView.prototype._addBotsHeadingToPopover): Ditto.
2207         (EWSQueueView.prototype._addDividerToPopover): Ditto.
2208         (EWSQueueView.prototype._timeIntervalString): A helper to format a timestamp into a
2209         relative string.
2210         (EWSQueueView.prototype._popoverContentForEWSQueue): Build the popover.
2211         (EWSQueueView.prototype._presentPopoverForEWSQueue): Start loading data, and present
2212         it when done.
2213
2214         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2215         Added rules for EWS popover. Removed a duplicate rule for build-logs-popover.
2216         Changed a few difficult to read padding styles to padding-left.
2217
2218 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
2219
2220         Fix webkitpy tests.
2221
2222         * Scripts/webkitpy/common/net/web_mock.py: (MockBrowser.set_handle_robots):
2223         Added a mock implementation, as we now call this function.
2224
2225 2014-01-20  Darin Adler  <darin@apple.com>
2226
2227         Update style checker and tests to deal with override instead of OVERRIDE
2228         https://bugs.webkit.org/show_bug.cgi?id=127175
2229
2230         Reviewed by Anders Carlsson.
2231
2232         * Scripts/webkitpy/style/checkers/cpp.py:
2233         (check_braces): Use override instead of OVERRIDE.
2234         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2235         (CppStyleTest.test_brace_at_begin_of_line): Ditto.
2236
2237 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
2238
2239         EWS should provide better information to Dashboard via JSON
2240         https://bugs.webkit.org/show_bug.cgi?id=127265
2241
2242         Reviewed by Ryosuke Niwa.
2243
2244         * QueueStatusServer/app.yaml: Updated version.
2245
2246         * QueueStatusServer/main.py:
2247         * QueueStatusServer/handlers/queuelengthjson.py:
2248         Added a way to cheaply get only the queue length, which is all the dashboard
2249         needs unless a popover is opened.
2250
2251         * QueueStatusServer/handlers/queuestatusjson.py: Updated to return more information
2252         that we will need. Changed some field names to be more meaningful. Fixed bot listing
2253         to understand that a bot can be reprurposed and used in a different queue.
2254
2255 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
2256
2257         Make uploading results to EWS work despite robots.txt
2258         https://bugs.webkit.org/show_bug.cgi?id=127296
2259
2260         Reviewed by Ryosuke Niwa.
2261
2262         * Scripts/webkitpy/common/net/statusserver.py: (StatusServer.__init__): Disable
2263         checking robots.txt.
2264
2265         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: (Bugzilla._get_browser):
2266         Removed a comment saying that we would want to stop doing this. Not checking
2267         robots.txt is more efficient than checking it.
2268
2269 2014-01-19  Ryuan Choi  <ryuan.choi@samsung.com>
2270
2271         [EFL][WK1] Remove and refactor the APIs which use single and base keyword
2272         https://bugs.webkit.org/show_bug.cgi?id=127214
2273
2274         Reviewed by Gyuyoung Kim.
2275
2276         Followed the changes of API.
2277
2278         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2279         (drtViewAdd):
2280         * EWebLauncher/main.c:
2281         (windowCreate):
2282
2283 2014-01-19  Eunmi Lee  <eunmi15.lee@samsung.com>
2284
2285         [EFL][WK2] Add touch events option to MiniBrowser.
2286         https://bugs.webkit.org/show_bug.cgi?id=127262
2287
2288         Reviewed by Gyuyoung Kim.
2289
2290         As a default, touch events are disabled and mouse events are enabled.
2291         If touch events option sets to true, touch events are enabled and mouse
2292         events are disabled.
2293
2294         * MiniBrowser/efl/main.c:
2295         (window_create):
2296         (elm_main):
2297
2298 2014-01-19  Zalan Bujtas  <zalan@apple.com>
2299
2300         Pretty print LayoutUnit, LayoutPoint, and LayoutSize in lldb and gdb.
2301         https://bugs.webkit.org/show_bug.cgi?id=126080
2302
2303         Reviewed by Sam Weinig.
2304
2305         This changes the output of printing LayoutUnits to be in px but it also
2306         preserves the original LayoutUnit value.
2307
2308         This will lead to lldb output like: (and it works even when subpixel is disabled)
2309
2310         (const WebCore::LayoutRect) $0 = {
2311             m_location = { x = 2.25px (144), y = 1px (64)}
2312             m_size = { width = 13.75px (880), height = 20px (1280) }
2313
2314
2315         And gdb output like:
2316
2317         m_frameRect = {
2318             m_location = LayoutPoint(0px (0), 0px(0)),
2319             m_size = LayoutSize(8px (512), 5px (320))
2320         }
2321
2322         This patch is based on patch by bjonesbe@adobe.com and for Blink by cbiesinger@chromium.org.
2323
2324         * gdb/webkit.py:
2325         (WebCoreLayoutUnitPrinter):
2326         (WebCoreLayoutUnitPrinter.__init__):
2327         (WebCoreLayoutUnitPrinter.to_string):
2328         (WebCoreLayoutSizePrinter):
2329         (WebCoreLayoutSizePrinter.__init__):
2330         (WebCoreLayoutSizePrinter.to_string):
2331         (WebCoreLayoutPointPrinter):
2332         (WebCoreLayoutPointPrinter.__init__):
2333         (WebCoreLayoutPointPrinter.to_string):
2334         (add_pretty_printers):
2335         * lldb/lldb_webkit.py:
2336         (__lldb_init_module):
2337         (WebCoreLayoutUnit_SummaryProvider):
2338         (WebCoreLayoutSize_SummaryProvider):
2339         (WebCoreLayoutPoint_SummaryProvider):
2340         (WebCoreLayoutUnitProvider):
2341         (WebCoreLayoutUnitProvider.__init__):
2342         (WebCoreLayoutUnitProvider.to_string):
2343         (WebCoreLayoutSizeProvider):
2344         (WebCoreLayoutSizeProvider.__init__):
2345         (WebCoreLayoutSizeProvider.get_width):
2346         (WebCoreLayoutSizeProvider.get_height):
2347         (WebCoreLayoutPointProvider):
2348         (WebCoreLayoutPointProvider.__init__):
2349         (WebCoreLayoutPointProvider.get_x):
2350         (WebCoreLayoutPointProvider.get_y):
2351
2352 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
2353
2354         Add robots.txt to http://webkit-queues.appspot.com
2355         https://bugs.webkit.org/show_bug.cgi?id=127240
2356
2357         * QueueStatusServer/app.yaml: Added required "upload" attribute for robots.txt.
2358
2359 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
2360
2361         Add robots.txt to http://webkit-queues.appspot.com
2362         https://bugs.webkit.org/show_bug.cgi?id=127240
2363
2364         Reviewed by Ryosuke Niwa.
2365
2366         * QueueStatusServer/app.yaml: Added robots.txt as a static file. Updated version.
2367
2368         * QueueStatusServer/robots.txt: Added.
2369
2370 2014-01-18  Alberto Garcia  <berto@igalia.com>
2371
2372         Tools/Scripts/test-webkitperl fails: 'tempdir' can't be called as a method
2373         https://bugs.webkit.org/show_bug.cgi?id=127217
2374
2375         Reviewed by Daniel Bates.
2376
2377         The syntax File::Temp->tempdir() was explicitly made invalid
2378         following <https://github.com/Perl-Toolchain-Gang/File-Temp/commit/c8920b2161ab6900a09e02b9410e0e4c3d74f565>
2379         which was included in File::Temp v2.30, shipped with Perl v5.18.0.
2380
2381         Use File::Temp::tempdir() instead.
2382
2383         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
2384
2385 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
2386
2387         build.webkit.org/dashboard should have image diff links in test results popovers
2388         https://bugs.webkit.org/show_bug.cgi?id=127188
2389
2390         Reviewed by Timothy Hatcher.
2391
2392         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2393         (Buildbot.prototype.layoutTestImagesURLForIteration):
2394         (Buildbot.prototype.layoutTestImageDiffURLForIteration):
2395         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2396         (BuildbotIteration.prototype.loadLayoutTestResults):
2397         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2398         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions.addFailureInfoLink):
2399         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions.addFailureInfoText):
2400         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
2401
2402 2014-01-18  Anders Carlsson  <andersca@apple.com>
2403
2404         Remove ENABLE_THREADED_HTML_PARSER defines everywhere
2405         https://bugs.webkit.org/show_bug.cgi?id=127225
2406
2407         Reviewed by Andreas Kling.
2408
2409         This concludes the removal of over 8.8 million lines of threaded parser code.
2410
2411         * Scripts/webkitperl/FeatureList.pm:
2412
2413 2014-01-17  Alexey Proskuryakov  <ap@apple.com>
2414
2415         build.webkit.org/dashboard should have diff links in test results popovers
2416         https://bugs.webkit.org/show_bug.cgi?id=126986
2417
2418         Reviewed by Tim Horton.
2419
2420         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2421         (Buildbot.prototype.layoutTestCrashLogURLForIteration):
2422         (Buildbot.prototype.layoutTestStderrURLForIteration):
2423         (Buildbot.prototype.layoutTestDiffURLForIteration):
2424         (Buildbot.prototype.layoutTestPrettyDiffURLForIteration):
2425         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2426         (BuildbotIteration.prototype.loadLayoutTestResults):
2427         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2428         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
2429
2430 2014-01-17  Matthew Hanson  <matthew_hanson@apple.com>
2431
2432         Add the bare minimum support for branches to the bot-watchers dashboard
2433         https://bugs.webkit.org/show_bug.cgi?id=127124
2434
2435         This patch simply introduces the notion of branches into the bot-watchers dashboard.
2436         Subsequent patches will build functionality on top of this simple bit of infrastructure.
2437
2438         Reviewed by Timothy Hatcher.
2439
2440         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2441         (BuildbotQueue): store the branch property in the BuildbotQueue constructor
2442         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2443         Initialize the Dashboard.Branch object
2444
2445 2014-01-17  Chris Fleizach  <cfleizach@apple.com>
2446
2447         platform/mac/accessibility/aria-multiline.html sometimes asserts in AccessibilityController::removeNotificationListener
2448         https://bugs.webkit.org/show_bug.cgi?id=127141
2449
2450         Reviewed by Alexey Proskuryakov.
2451
2452         Make sure to reset the notification handler each time.
2453
2454         * DumpRenderTree/AccessibilityController.cpp:
2455         (AccessibilityController::resetToConsistentState):
2456         * DumpRenderTree/AccessibilityController.h:
2457         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
2458         (AccessibilityController::platformResetToConsistentState):
2459         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2460         (AccessibilityController::platformResetToConsistentState):
2461         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2462         (AccessibilityController::~AccessibilityController):
2463         (AccessibilityController::platformResetToConsistentState):
2464         (AccessibilityController::removeNotificationListener):
2465         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2466         (AccessibilityController::platformResetToConsistentState):
2467
2468 2014-01-17  Alberto Garcia  <berto@igalia.com>
2469
2470         [GTK] Test /webkit/download/not-found fails in GTK Linux 64-bit Release bot
2471         https://bugs.webkit.org/show_bug.cgi?id=82329
2472
2473         Reviewed by Carlos Garcia Campos.
2474
2475         Unskip, this is working fine now.
2476
2477         * Scripts/run-gtk-tests:
2478         (TestRunner):
2479
2480 2014-01-17  Alberto Garcia  <berto@igalia.com>
2481
2482         [GTK] Test /webkit/webview/icon-uri times out in GTK Linux 64-bit Release bot
2483         https://bugs.webkit.org/show_bug.cgi?id=82328
2484
2485         Reviewed by Carlos Garcia Campos.
2486
2487         This was caused by the icon database being corrupted in the
2488         Release bot. After removing it the test works fine so it can be
2489         run again.
2490
2491         * Scripts/run-gtk-tests:
2492         (TestRunner):
2493
2494 2014-01-16  Alexey Proskuryakov  <ap@apple.com>
2495
2496         Test results popovers at http://build.webkit.org/dashboard should link to stderr
2497         https://bugs.webkit.org/show_bug.cgi?id=126929
2498
2499         Reviewed by Timothy Hatcher.
2500
2501         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2502         (Buildbot.prototype.layoutTestCrashLogURLForIteration): Renamed for consistency.
2503         (Buildbot.prototype.layoutTestStderrURLForIteration): Added.
2504
2505         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2506         (BuildbotIteration.prototype.loadLayoutTestResults): Store has_stderr attribute.
2507
2508         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2509         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
2510         Add a link to stderr output if present.
2511
2512         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2513         (.test-results-popover .additional-link): Style with light grey (will use the same style
2514         for diff links).
2515
2516 2014-01-16  Ryosuke Niwa  <rniwa@webkit.org>
2517
2518         Automate DoYouEvenBench
2519         https://bugs.webkit.org/show_bug.cgi?id=124497
2520
2521         Reviewed by Geoffrey Garen.
2522
2523         * Scripts/webkitpy/performance_tests/perftest.py:
2524         (PerfTestMetric.__init__): Added the aggregator name as an argument.
2525         (PerfTestMetric.aggregator): Added.
2526         (PerfTest._metrics_regex): Made the subtest name match non-greedy so that the metric names will be
2527         won't be eagerly parsed as a part of the subtest name. e.g. "Time" and "Total" in "a:Time:Total"
2528         should be parsed as the metric and the aggregator respectively.
2529         (PerfTest._run_with_driver): Pass in the aggregator name.
2530         (PerfTest._ensure_metrics): Ditto. Also split the subtest name by / as required by DoYouEvenBench
2531         which generates subtests of subtests within a single test file.
2532
2533         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2534         (test_parse_output_with_subtests_and_total): Added.
2535
2536         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2537         (_generate_results_dict): Add the aggregator name to the JSON when one is available.
2538
2539         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2540         (TestWithSubtestsData): Added a sub test with an aggregator and a sub-sub test.
2541
2542 2014-01-16  Chris Fleizach  <cfleizach@apple.com>
2543
2544         platform/mac/accessibility/aria-multiline.html sometimes asserts in AccessibilityController::removeNotificationListener
2545         https://bugs.webkit.org/show_bug.cgi?id=127141
2546
2547         Reviewed by Alexey Proskuryakov.
2548
2549         Don't assert that the notification handler needs to be cleaned up. Deallocing the controller should be enough to clean up as it is.
2550
2551         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2552         (AccessibilityController::~AccessibilityController):
2553
2554 2014-01-16  Ryosuke Niwa  <rniwa@webkit.org>
2555
2556         EWS shouldn't comment on Bugzilla for failing builds or style errors
2557         https://bugs.webkit.org/show_bug.cgi?id=127079
2558
2559         Reviewed by Anders Carlsson.
2560
2561         Since patch authors and reviewers could retrieve this information from bubbles,
2562         we shouldn't spam the Bugzilla with useless comments.
2563
2564         We still post style errors but not python paths we used since it's a pure noise.
2565
2566         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2567         (AbstractEarlyWarningSystem._post_reject_message_on_bug):
2568         * Scripts/webkitpy/tool/commands/queues.py:
2569         (StyleQueue.review_patch):
2570
2571 2014-01-15  Roger Fong  <roger_fong@apple.com>
2572
2573         Add support for handling WebGL load policies.
2574         https://bugs.webkit.org/show_bug.cgi?id=126935
2575         <rdar://problem/15790448>.
2576
2577         Reviewed by Timothy Horton.
2578
2579         * WebKitTestRunner/TestController.cpp: Update WKPageLoaderClient to V4.
2580         (WTR::TestController::createWebViewWithOptions):
2581
2582 2014-01-16  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2583
2584         Remove workaround for compilers not supporting explicit override control
2585         https://bugs.webkit.org/show_bug.cgi?id=127111
2586
2587         Reviewed by Anders Carlsson.
2588
2589         Now all compilers support explicit override control, this workaround can be removed.
2590
2591         * DumpRenderTree/gtk/fonts/fonts.conf:
2592         * Scripts/do-webcore-rename:
2593         Removed this rename operation from the list of contemplated future renames.
2594         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
2595         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
2596         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
2597         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
2598         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2599
2600 2014-01-16  Oliver Hunt  <oliver@apple.com>
2601
2602         Stop run-jsc from consuming stderr output
2603         https://bugs.webkit.org/show_bug.cgi?id=127115
2604
2605         Reviewed by Mark Lam.
2606
2607         Simple patch to make run-jsc easier to deal with
2608
2609         * Scripts/run-jsc:
2610
2611 2014-01-16  Eva Balazsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
2612
2613         Tools/gtk/generate-feature-defines-files doesn't work with older versions of python
2614         https://bugs.webkit.org/show_bug.cgi?id=126323
2615
2616         Reviewed by Csaba Osztrogonác.
2617
2618         * gtk/generate-feature-defines-files:
2619
2620 2014-01-16  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
2621
2622         [EFL][WK2] Implement TestController::setHidden
2623         https://bugs.webkit.org/show_bug.cgi?id=127036
2624
2625         Reviewed by Gyuyoung Kim.
2626
2627         WebKitTestRunner needs TestController::setHidden implementation to
2628         properly handle page visibility API layout tests after r161105.
2629
2630         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2631         (WTR::TestController::setHidden):
2632
2633 2014-01-16  Zan Dobersek  <zdobersek@igalia.com>
2634
2635         [GTK][MiniBrowser] The progress entry reset callback can be fired after the BrowserWindow is destroyed
2636         https://bugs.webkit.org/show_bug.cgi?id=127083
2637
2638         Reviewed by Carlos Garcia Campos.
2639
2640         When the load progress reaches 1.0 (i.e. 100%), a timeout callback is set up in webViewLoadProgressChanged.
2641         The progress entry is then reset back to 0 in that callback and the timeout source is removed.
2642
2643         The callback can be fired after the relevant BrowserWindow and its progress entry are destroyed, causing
2644         assertion failures in gtk_entry_set_progress_fraction due to an invalid GtkEntry object. To avoid that,
2645         To avoid that, the ID of the timeout source is stored on the BrowserWindow and is destroyed when the
2646         BrowserWindow object is being finalized, preventing the callback from firing.
2647
2648         * MiniBrowser/gtk/BrowserWindow.c:
2649         (resetEntryProgress):
2650         (webViewLoadProgressChanged):
2651         (browserWindowFinalize):
2652
2653 2014-01-15  Alexey Proskuryakov  <ap@apple.com>
2654
2655         DumpRenderTree doesn't disable web preferences autosave
2656         https://bugs.webkit.org/show_bug.cgi?id=127062
2657
2658         Reviewed by Dan Bernstein.
2659
2660         * DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment):
2661         Do it.
2662
2663 2014-01-15  Dean Jackson  <dino@apple.com>
2664
2665         Improve filter-build-webkit, especially for iOS builds
2666         https://bugs.webkit.org/show_bug.cgi?id=81046
2667
2668         Reviewed by Joseph Pecoraro.
2669
2670         Lots of updates to the filtering rules, mostly from the
2671         iOS build output. Other highlights include:
2672         - ignoring escape sequences for color ouput
2673         - detecting escaped spaces in file name regexps
2674
2675         * Scripts/filter-build-webkit:
2676         (shouldIgnoreLine):
2677
2678 2014-01-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2679
2680         [GTK] Web process sometimes crashes when printing in synchronous mode
2681         https://bugs.webkit.org/show_bug.cgi?id=126979
2682
2683         Reviewed by Gustavo Noronha Silva.
2684
2685         * Scripts/run-gtk-tests:
2686         (TestRunner): Unskip
2687         /webkit2/WebKitPrintOperation/close-after-print.
2688
2689 2014-01-15  ChangSeok Oh  <changseok.oh@collabora.com>
2690
2691         [EFL] Change test font installed path to webkitgtk-font-tests
2692         https://bugs.webkit.org/show_bug.cgi?id=126723
2693
2694         Reviewed by Gyuyoung Kim.
2695
2696         I'd like to change the test fonts installed directory from 'webkitgtk-test-fonts-0.0.3'
2697         to 'webkitgtk-test-fonts'. webkitgtk-test-fonts-0.0.3 doesn't match the path
2698         hard-coded in FontManagement.cpp#105
2699
2700         * DumpRenderTree/PlatformEfl.cmake:
2701         * WebKitTestRunner/PlatformEfl.cmake:
2702         * efl/jhbuild.modules:
2703
2704 2014-01-14  Ryosuke Niwa  <rniwa@webkit.org>
2705
2706         Make DoYouEvenBench runnable by run-perf-tests
2707         https://bugs.webkit.org/show_bug.cgi?id=127030
2708
2709         Reviewed by Andreas Kling.
2710
2711         Ignore console messages spit out by DoYouEvenBench and support aggregator names such as
2712         ":Total" to appear at the end of a test name. We don't do anything with it for now.
2713
2714         * Scripts/webkitpy/performance_tests/perftest.py:
2715         (PerfTest._metrics_regex): Handle aggregator names such as ":Total". We'll pass it down
2716         to the JSON in a follow up patch for the perf dashboard.
2717         (PerfTest._lines_to_ignore_in_parser_result): Added lines to ignore for DoYouEvenBench.
2718
2719 2014-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
2720
2721         [GTK] UI process crashes when the web process crashes while printing
2722         https://bugs.webkit.org/show_bug.cgi?id=126977
2723
2724         Reviewed by Gustavo Noronha Silva.
2725
2726         Add new test case to check that closing the window right after
2727         printing works. It's skipped for now, because this patch only
2728         fixes the UI process crash, but not the web process one.
2729
2730         * Scripts/run-gtk-tests:
2731         (TestRunner): Skip
2732         /webkit2/WebKitPrintOperation/close-after-print.
2733         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
2734         (testPrintOperationPrintPrinter):
2735         (findPrintToFilePrinter):
2736         (testPrintOperationPrint):
2737         (testPrintOperationErrors):
2738         (testPrintOperationCloseAfterPrint):
2739         (beforeAll):
2740
2741 2014-01-14  Brent Fulgham  <bfulgham@apple.com>
2742
2743         [WIN] Set MSBuild environment variable to avoid long-lived processes locking log files
2744         https://bugs.webkit.org/show_bug.cgi?id=127002
2745
2746         Reviewed by David Kilzer.
2747
2748         * Scripts/webkitdirs.pm:
2749         (setupAppleWinEnv): Export MSBUILDDISABLENODEREUSE=1 to the environment.
2750
2751 2014-01-14  Commit Queue  <commit-queue@webkit.org>
2752
2753         Unreviewed, rolling out r162000.
2754         http://trac.webkit.org/changeset/162000
2755         https://bugs.webkit.org/show_bug.cgi?id=127009
2756
2757         API versioning is wrong (Requested by rfong on #webkit).
2758
2759         * MiniBrowser/mac/WK2BrowserWindowController.m:
2760         (-[WK2BrowserWindowController awakeFromNib]):
2761         * WebKitTestRunner/TestController.cpp:
2762         (WTR::TestController::createOtherPage):
2763         (WTR::TestController::createWebViewWithOptions):
2764
2765 2014-01-13  Roger Fong  <roger_fong@apple.com>
2766
2767         Add support for handling WebGL load policies.
2768         https://bugs.webkit.org/show_bug.cgi?id=126935
2769         <rdar://problem/15790448>.
2770
2771         Reviewed by Brent Fulgham.
2772
2773         * MiniBrowser/mac/WK2BrowserWindowController.m:
2774         (-[WK2BrowserWindowController awakeFromNib]):
2775         * WebKitTestRunner/TestController.cpp:
2776         (WTR::TestController::createWebViewWithOptions):
2777
2778 2014-01-14  Zan Dobersek  <zdobersek@igalia.com>
2779
2780         [GTK] Skip FontConfig initialization in WebKitTestRunner if requested
2781         https://bugs.webkit.org/show_bug.cgi?id=120110
2782
2783         Reviewed by Martin Robinson.
2784
2785         Skip the FontConfig settings initialization in WebKitTestRunner if the
2786         WEBKIT_SKIP_WEBKITTESTRUNNER_FONTCONFIG_INITIALIZATION environment variable is set.
2787         This is useful when profiling the WebKitTestRunner execution, where at the startup
2788         this step takes considerable amount of time and disturbs the profiling output.
2789
2790         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2791         (WTR::initializeFontConfigSetting):
2792
2793 2014-01-14  Brian J. Burg  <burg@cs.washington.edu>
2794
2795         Add ENABLE(WEB_REPLAY) feature flag to the build system
2796         https://bugs.webkit.org/show_bug.cgi?id=126949
2797
2798         Reviewed by Joseph Pecoraro.
2799
2800         * Scripts/webkitperl/FeatureList.pm:
2801
2802 2014-01-14  László Langó  <llango.u-szeged@partner.samsung.com>
2803
2804         REGRESSION (r160085): check-webkit-style: utf8' codec can't decode byte 0x89 in position 0: invalid start byte.
2805         https://bugs.webkit.org/show_bug.cgi?id=126702
2806
2807         Reviewed by Alexey Proskuryakov.
2808
2809         Resolve regression and remove a FIXME comment that is already fixed.
2810
2811         * Scripts/webkitpy/common/system/filesystem.py:
2812         (FileSystem.open_text_file_for_reading):
2813         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2814         (RealFileSystemTest.test_read_and_write_file):
2815         * Scripts/webkitpy/style/filereader.py:
2816         (TextFileReader._read_lines):
2817         * Scripts/webkitpy/style/filereader_unittest.py:
2818         (TextFileReaderTest.test_count_delete_only_file):
2819         (TextFileReaderTest):
2820         (TextFileReaderTest.test_process_malformed_file):
2821
2822 2014-01-02  Brian Holt  <brian.holt@samsung.com>
2823
2824         [GTK] Parse Valgrind xml leak files
2825         https://bugs.webkit.org/show_bug.cgi?id=119446
2826
2827         Reviewed by Alejandro G. Castro.
2828
2829         Parse the xml files generated by Valgrind to yield useful
2830         information about the memory leaks.
2831
2832         * Scripts/webkitpy/port/gtk.py:
2833         (GtkPort.__init__):
2834         (GtkPort.setup_test_run): Clear the previous output files before new
2835         run.
2836         (GtkPort.print_leaks_summary):
2837
2838         * Scripts/webkitpy/port/leakdetector_valgrind.py: Added.
2839         Parse the xml files generated by Valgrind and summarise leaks
2840         into an easily understandable list.
2841         (get_text_of):
2842         (get_CDATA_of):
2843         (gather_frames):
2844         (ValgrindError):
2845         (ValgrindError.__init__):
2846         (ValgrindError.__str__):
2847         (ValgrindError.unique_string):
2848         (ValgrindError.error_hash):
2849         (ValgrindError.__hash__):
2850         (ValgrindError.__eq__):
2851         (LeakDetectorValgrind):
2852         (LeakDetectorValgrind.__init__):
2853         (LeakDetectorValgrind._parse_leaks_output):
2854         (LeakDetectorValgrind.leaks_files_in_results_directory):
2855         (LeakDetectorValgrind.clean_leaks_files_from_results_directory):
2856         (LeakDetectorValgrind.parse_and_print_leaks_detail):
2857
2858         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Added.
2859         (make_mock_valgrind_output):
2860         (make_mock_incomplete_valgrind_output):
2861         (make_mock_valgrind_results):
2862         (make_mock_valgrind_results_incomplete):
2863         (make_mock_valgrind_results_empty):
2864         (make_mock_valgrind_results_misformatted):
2865         (mock_run_cppfilt_command):
2866         (LeakDetectorValgrindTest):
2867         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
2868         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
2869         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
2870         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
2871         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
2872         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
2873         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
2874         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
2875
2876 2014-01-13  Lucas Forschler  <lforschler@apple.com>
2877
2878         Update the LLINT CLoop Bot build infrastructure
2879         https://bugs.webkit.org/show_bug.cgi?id=126604
2880         
2881         Unreviewed.
2882         
2883         * BuildSlaveSupport/build.webkit.org-config/config.json:
2884         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2885         (CompileLLINTCLoop):
2886         (RunLLINTCLoopTests):
2887         (BuildAndTestLLINTCLoopFactory):
2888         (BuildAndTestLLINTCLoopFactory.__init__):
2889
2890 2014-01-13  Jinwoo Song  <jinwoo7.song@samsung.com>
2891
2892         [EFL][WK2] Disable failing API tests
2893         https://bugs.webkit.org/show_bug.cgi?id=126960
2894
2895         Reviewed by Gyuyoung Kim.
2896
2897         Disable WKViewUserViewportToContents test until bug 126261 is resolved.
2898
2899         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
2900         (TestWebKitAPI::TEST):
2901
2902 2014-01-13  Daniel Batyai  <dbatyai.u-szeged@partner.samsung.com>
2903
2904         Remove wdiff
2905         https://bugs.webkit.org/show_bug.cgi?id=124766
2906
2907         Reviewed by Ryosuke Niwa.
2908
2909         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
2910         (ResultsJSONParserTest):
2911         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2912         (TestResultWriter):
2913         (TestResultWriter.create_text_diff_and_write_result):
2914         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2915         (summarize_results):
2916         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2917         (RunTest.test_output_diffs):
2918         * Scripts/webkitpy/port/base.py:
2919         (Port.__init__):
2920         (Port.driver_stop_timeout):
2921         (Port.check_image_diff):
2922         (Port.repository_paths):
2923         (Port._path_to_lighttpd_php):
2924         * Scripts/webkitpy/port/base_unittest.py:
2925         (PortTest.test_default_child_processes):
2926         (PortTest.test_pretty_patch_script_error):
2927         * Scripts/webkitpy/port/port_testcase.py:
2928         (PortTestCase.test_diff_image_crashed):
2929         * Scripts/webkitpy/port/test.py:
2930         (TestPort.operating_system):
2931
2932 2014-01-13  Martin Robinson  <mrobinson@igalia.com>
2933
2934         Build fix for the GTK+ CMake port
2935
2936         * TestWebKitAPI/PlatformGTK.cmake: The WKConnection test is no longer with us.
2937
2938 2014-01-13  Adrian Perez de Castro  <aperez@igalia.com>
2939
2940         [GTK] Add cast in call to g_object_add_weak_pointer in MiniBrowser
2941         https://bugs.webkit.org/show_bug.cgi?id=126881
2942
2943         Reviewed by Carlos Garcia Campos.
2944
2945         * MiniBrowser/gtk/BrowserWindow.c:
2946         (browser_window_new):
2947         Explicitly cast GtkWindow** to gpointer* in call to
2948         g_object_add_weak_pointer to avoid compiler warnings.
2949
2950 2014-01-13  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2951
2952         Remove parsing of old-run-webkit-tests output from master.cfg
2953         https://bugs.webkit.org/show_bug.cgi?id=126690
2954
2955         Reviewed by Csaba Osztrogonác.
2956
2957         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2958         Removed parsing of ORWT output, as it is not used anymore.
2959         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2960         Updated unit tests accordingly.
2961
2962 2014-01-13  Commit Queue  <commit-queue@webkit.org>
2963
2964         Unreviewed, rolling out r161808.
2965         http://trac.webkit.org/changeset/161808
2966         https://bugs.webkit.org/show_bug.cgi?id=126874
2967
2968         This patch make several files to be always regenerated on
2969         every make (Requested by KaL on #webkit).
2970
2971         * WebKitTestRunner/GNUmakefile.am:
2972
2973 2014-01-13  Adrian Perez de Castro  <aperez@igalia.com>
2974
2975         [GTK] Make MiniBrowser windows non-transient by default
2976         https://bugs.webkit.org/show_bug.cgi?id=126840
2977
2978         Reviewed by Carlos Garcia Campos.
2979
2980         Instead of making new browser windows transient as soon as they are
2981         created, save the pointer to the parent window and set the transient
2982         state later on when handling the "run-as-modal" signal. This makes
2983         it easier to use the MiniBrowser to do tests involving multiple
2984         windows, and will be useful as well when multi-web-process mode is
2985         enabled for the GTK port.
2986
2987         * MiniBrowser/gtk/BrowserWindow.c:
2988         (webViewRunAsModal): Set the parent window using
2989         gtk_window_set_transient_for() using the saved parent
2990         window.
2991         (browser_window_new): Save the parent window using
2992         g_object_set_data() instead of making the new window
2993         transient immediately.
2994
2995 2014-01-12  Sergio Correia  <sergio.correia@openbossa.org>
2996
2997         [EFL][WK2] Make API tests work again
2998         https://bugs.webkit.org/show_bug.cgi?id=126769
2999
3000         Reviewed by Gyuyoung Kim.
3001
3002         The EFL and WK2 test binaries are currently being generated at *TestWebKitAPI/
3003         [E]WebKit2, respectively, and this causes problems because the logic to find
3004         where WebProcess is to look in the same directory of the running process and
3005         then proceed to use LIBEXECDIR (typically /usr/loca/bin).
3006
3007         This patch introduces a WEBKIT_EXEC_PATH environment variable, inspired in the
3008         Gtk port, which allows us to look for WebProcess initially in this directory,
3009         if it's defined.
3010
3011         * TestWebKitAPI/efl/main.cpp:
3012         (main): Define WEBKIT_EXEC_PATH to be used by WebKit2 API tests.
3013
3014 2014-01-12  Daniel Bates  <dabates@apple.com>
3015
3016         [iOS] Fix the build
3017
3018         For now, ensure we build WebKit System Interface before we build WebKit.
3019         We'll remove this constraint and the constraint to build WebKit Additions
3020         in a subsequent commit.
3021
3022         * Scripts/build-webkit:
3023
3024 2014-01-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3025
3026         Unreviewed. Fix make distcheck.
3027
3028         * gtk/GNUmakefile.am: Add generate-inspector-gresource-manifest.py
3029         to EXTRA_DIST.
3030
3031 2014-01-12  Tobias Mueller  <tobiasmue@gnome.org>
3032
3033         --disable-dependency-tracking causes build failure due to missing directories
3034         https://bugs.webkit.org/show_bug.cgi?id=94488
3035
3036         Reviewed by Gustavo Noronha Silva.
3037
3038         Autotools build fix: Ensure output directory existing
3039         before generating DerivedSources. This allows for
3040         --disable-dependency-tracking to be run.
3041
3042
3043         * WebKitTestRunner/GNUmakefile.am: Added a new target of the directory in which files are meant to be stored.
3044
3045 2014-01-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3046
3047         [GTK] Fix return value of WebKitDownload::created-destination
3048         https://bugs.webkit.org/show_bug.cgi?id=126741
3049
3050         Reviewed by Martin Robinson.
3051
3052         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: Fix return
3053         value of several callbacks.
3054
3055 2014-01-11  Sam Weinig  <sam@webkit.org>
3056
3057         Add support for null StringViews
3058         https://bugs.webkit.org/show_bug.cgi?id=126827
3059
3060         Reviewed by Anders Carlsson.
3061
3062         Add new test for StringView.
3063
3064         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3065         * TestWebKitAPI/Tests/WTF/StringView.cpp: Added.
3066         (TestWebKitAPI::TEST):
3067
3068 2014-01-10  Benjamin Poulain  <bpoulain@apple.com>
3069
3070         Remove the BlackBerry port from trunk
3071         https://bugs.webkit.org/show_bug.cgi?id=126715
3072
3073         Reviewed by Anders Carlsson.
3074
3075         * DumpRenderTree/DumpRenderTree.h:
3076         * DumpRenderTree/PixelDumpSupport.cpp:
3077
3078 2014-01-10  Daniel Bates  <dabates@apple.com>
3079
3080         [iOS] Fix project build order
3081
3082         Ensure we build WebKitAdditions before WebCore (if applicable). Also, we don't
3083         build WebInspectorUI, Tools/MiniBrowser, or Tools/WebKitTestRunner on iOS at the
3084         time of writing.
3085
3086         * Scripts/build-webkit:
3087
3088 2014-01-10  Mario Sanchez Prada  <mario.prada@samsung.com>
3089
3090         Move platformName property from testRunner to accessibilityController
3091         https://bugs.webkit.org/show_bug.cgi?id=126689
3092
3093         Reviewed by Chris Fleizach.
3094
3095         Move the platformName property from the testRunner into
3096         accessibilityController, since this is a concept that has only be
3097         used by accessibility tests since it got added, and also because
3098         the real intention was not to distinguish among "ports" (mac, win,
3099         gtk, efl) but between platforms (atk, mac, win).
3100
3101         This change will be very useful to merge GTK's roles-exposed.html
3102         and Mac's role-subrole-roledescription.html into one single test,
3103         since we will be specifying in the test itself which elements are
3104         supported in which accessibility "platform". In this context,
3105         being able to check accessibilityController.platformName directly
3106         against a list of supported accessibility platforms (e.g. "atk,mac")
3107         will certainly maintain the code cleaner and simpler.
3108
3109         * DumpRenderTree/TestRunner.h:
3110         (TestRunner::platformName): Removed.
3111         * DumpRenderTree/TestRunner.cpp:
3112         (getPlatformNameCallback): Removed.
3113         (TestRunner::staticValues): Removed platformName
3114         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3115         (TestRunner::platformName): Removed.
3116         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3117         (TestRunner::platformName): Removed.
3118         * DumpRenderTree/mac/TestRunnerMac.mm:
3119         (TestRunner::platformName): Removed.
3120         * DumpRenderTree/win/TestRunnerWin.cpp:
3121         (TestRunner::platformName): Removed.
3122
3123         * DumpRenderTree/AccessibilityController.h:
3124         (AccessibilityController::platformName): Added.
3125         * DumpRenderTree/AccessibilityController.cpp:
3126         (getPlatformNameCallback): Added.
3127         (AccessibilityController::getJSClass): Added platformName.
3128         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
3129         (AccessibilityController::platformName): Added, returning "atk".
3130         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3131         (AccessibilityController::platformName): Ditto, returning "mac".
3132         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
3133         (AccessibilityController::platformName): Ditto, returning "ios".
3134         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3135         (AccessibilityController::platformName): Ditto, returning "win".
3136
3137         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3138         (platformName): Removed.
3139         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3140         (TestRunner::platformName): Removed.
3141         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
3142         (TestRunner::platformName): Removed.
3143         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
3144         (TestRunner::platformName): Removed.
3145         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3146         (TestRunner::platformName): Removed.
3147         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
3148         (TestRunner::platformName): Removed.
3149
3150         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
3151         (WTR:AccessibilityController::platformName): Added.
3152         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
3153         (platformName): Added.
3154         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3155         (WTR::AccessibilityController::platformName): Added, returning "atk".
3156         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
3157         (WTR::AccessibilityController::platformName): Added, returning "mac".
3158
3159 2014-01-10  Benjamin Poulain  <bpoulain@apple.com>
3160
3161         Remove the BlackBerry port from trunk
3162         https://bugs.webkit.org/show_bug.cgi?id=126715
3163
3164         Reviewed by Anders Carlsson.
3165
3166         * Scripts/webkitpy/common/config/watchlist:
3167
3168 2014-01-09  Benjamin Poulain  <bpoulain@apple.com>
3169
3170         Remove the BlackBerry files outside WebCore
3171         https://bugs.webkit.org/show_bug.cgi?id=126715
3172
3173         Reviewed by Anders Carlsson.
3174
3175         * DumpRenderTree/blackberry: Removed.
3176
3177 2014-01-10  Simon Fraser  <simon.fraser@apple.com>
3178
3179         Remove knowledge of Blackberry from build scripts
3180         https://bugs.webkit.org/show_bug.cgi?id=126766
3181
3182         Reviewed by Anders Carlsson.
3183         
3184         Remove isBlackBerry() and references to it, and rmeove
3185         blackberry-related stuff from the watchlist.
3186
3187         * Scripts/build-webkit:
3188         * Scripts/webkit-build-directory:
3189         * Scripts/webkitdirs.pm:
3190         (determineBaseProductDir):
3191         (argumentsForConfiguration):
3192         (builtDylibPathForName):
3193         (isAppleWebKit):
3194         (buildCMakeProjectOrExit):
3195         (cmakeBasedPortArguments):
3196         (cmakeBasedPortName):
3197         * Scripts/webkitperl/FeatureList.pm:
3198         * Scripts/webkitpy/common/config/watchlist:
3199
3200 2014-01-10  Daniel Bates  <dabates@apple.com>
3201
3202         [iOS] Fix up simulator build and enable default features
3203
3204         Rubber-stamped by Joseph Pecoraro.
3205
3206         * Scripts/webkitdirs.pm:
3207         (determineArchitecture):
3208         (determinePassedArchitecture):
3209         * Scripts/webkitperl/FeatureList.pm: Also expose command line option to toggle ENABLE_PLUGIN_PROXY_FOR_VIDEO (enabled
3210         by default only in iOS).
3211
3212 2014-01-10  Daniel Bates  <dabates@apple.com>
3213
3214         [iOS] Upstream WebCore and Tools miscellaneous changes
3215         https://bugs.webkit.org/show_bug.cgi?id=126698
3216
3217         Reviewed by David Kilzer.
3218
3219         * Scripts/check-for-inappropriate-objc-class-names:
3220         * Scripts/check-for-webkit-framework-include-consistency:
3221
3222 2014-01-09  Dan Bernstein  <mitz@apple.com>
3223
3224         [Cocoa] Promote WKBackForwardList{,Item}.h to public
3225         https://bugs.webkit.org/show_bug.cgi?id=126707
3226
3227         Reviewed by Sam Weinig.
3228
3229         * Scripts/check-for-webkit-framework-include-consistency: Account for stale private headers
3230         left behind in the build products directory after a private header is made public.
3231
3232 2014-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
3233
3234         [SOUP] Partial file left on disk after a download fails or is cancelled in WebKit2
3235         https://bugs.webkit.org/show_bug.cgi?id=126686
3236
3237         Reviewed by Martin Robinson.
3238
3239         Test that partial files are not left on disk after a download has
3240         been cancelled after the destination has been decided. To make
3241         sure the download is cancelled after the destination has been
3242         decided and before the operation finishes, we cancel the download
3243         in the destination decided callback, and we use an infinite
3244         resource that writes chunks to the response body and never
3245         completes the body.
3246
3247         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
3248         (addContentDispositionHTTPHeaderToResponse): Helper function to
3249         add the Content-Disposition to the response headers.
3250         (writeNextChunkIdle): Write next chunk to response body.
3251         (writeNextChunk): Write next chunk in an idle to avoid flooding
3252         the network with the inifnite resource.
3253         (serverCallback): Add an inifinite resource.
3254         (testDownloadRemoteFileError): Check that partial file is not
3255         present after the download has been cancelled.
3256
3257 2014-01-09  Roland Takacs  <rtakacs@inf.u-szeged.hu>
3258
3259         Move myself to the committers list.
3260
3261         Unreviewed.
3262
3263         * Scripts/webkitpy/common/config/contributors.json:
3264
3265 2014-01-08  Seokju Kwon  <seokju@webkit.org>
3266
3267         [GTK] Unreviewed build fix after r161522.
3268
3269         * TestWebKitAPI/GNUmakefile.am: Remove WKConnection.cpp and WKConnection_Bundle.cpp.
3270
3271 2014-01-08  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
3272
3273         Missleading style error when mixing system and non-system header include lines.
3274         https://bugs.webkit.org/show_bug.cgi?id=126564
3275
3276         Reviewed by Ryosuke Niwa.
3277
3278         * Scripts/webkitpy/style/checkers/cpp.py:
3279         (check_include_line):
3280         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3281         (OrderOfIncludesTest.test_check_alphabetical_include_order):
3282         (OrderOfIncludesTest.test_public_primary_header):
3283
3284 2014-01-08  Seokju Kwon  <seokju@webkit.org>
3285
3286         [EFL] Unreviewed build fix after r161522.
3287
3288         * TestWebKitAPI/CMakeLists.txt:
3289         * TestWebKitAPI/PlatformEfl.cmake:
3290
3291 2014-01-08  Anders Carlsson  <andersca@apple.com>
3292
3293         Remove WKConnectionRef tests
3294         https://bugs.webkit.org/show_bug.cgi?id=126666
3295
3296         Reviewed by Dan Bernstein.
3297
3298         The WKConnectionRef is poorly designed but thankfully not used anywhere. 
3299         Remove the API tests as a first step towards killing the entire thing.
3300
3301         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3302         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp: Removed.
3303         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp: Removed.
3304
3305 2014-01-08  Commit Queue  <commit-queue@webkit.org>
3306
3307         Unreviewed, rolling out r161512.
3308         http://trac.webkit.org/changeset/161512
3309         https://bugs.webkit.org/show_bug.cgi?id=126655
3310
3311         Broke webkitpy tests (Requested by ap on #webkit).
3312
3313         * Scripts/webkitpy/port/gtk.py:
3314         (GtkPort.__init__):
3315         (GtkPort.setup_test_run):
3316         (GtkPort._port_specific_expectations_files):
3317         * Scripts/webkitpy/port/leakdetector_valgrind.py: Removed.
3318         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Removed.
3319
3320 2014-01-08  Commit Queue  <commit-queue@webkit.org>
3321
3322         Unreviewed, rolling out r161517.
3323         http://trac.webkit.org/changeset/161517
3324         https://bugs.webkit.org/show_bug.cgi?id=126659
3325
3326         The fix didn't completely remove the problem and is now
3327         standing in the way of the rollout of the offending patch
3328         (Requested by zdobersek on #webkit).
3329
3330         * Scripts/webkitpy/port/gtk.py:
3331         (GtkPort.__init__):
3332
3333 2014-01-08  Zan Dobersek  <zdobersek@igalia.com>
3334
3335         Unreviewed. Attempting to fix webkitpy tests after r161512.
3336
3337         * Scripts/webkitpy/port/gtk.py:
3338         (GtkPort.__init__): Construct LeakDetectorValgrin only if leak detection is enabled.
3339
3340 2014-01-08  Brian Holt  <brian.holt@samsung.com>
3341
3342         [GTK] Parse Valgrind xml leak files
3343         https://bugs.webkit.org/show_bug.cgi?id=119446
3344
3345         Reviewed by Alejandro G. Castro.
3346
3347         Parse the xml files generated by Valgrind to yield useful
3348         information about the memory leaks.
3349
3350         * Scripts/webkitpy/port/gtk.py:
3351         (GtkPort.__init__):
3352         (GtkPort.setup_test_run): Clear the previous output files before new
3353         run.
3354         (GtkPort.print_leaks_summary):
3355
3356         * Scripts/webkitpy/port/leakdetector_valgrind.py: Added.
3357         Parse the xml files generated by Valgrind and summarise leaks
3358         into an easily understandable list.
3359         (get_text_of):
3360         (get_CDATA_of):
3361         (gather_frames):
3362         (ValgrindError):
3363         (ValgrindError.__init__):
3364         (ValgrindError.__str__):
3365         (ValgrindError.unique_string):
3366         (ValgrindError.error_hash):
3367         (ValgrindError.__hash__):
3368         (ValgrindError.__eq__):
3369         (LeakDetectorValgrind):
3370         (LeakDetectorValgrind.__init__):
3371         (LeakDetectorValgrind._parse_leaks_output):
3372         (LeakDetectorValgrind.leaks_files_in_results_directory):
3373         (LeakDetectorValgrind.clean_leaks_files_from_results_directory):
3374         (LeakDetectorValgrind.parse_and_print_leaks_detail):
3375
3376         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Added.
3377         (make_mock_valgrind_output):
3378         (make_mock_incomplete_valgrind_output):
3379         (make_mock_valgrind_results):
3380         (make_mock_valgrind_results_incomplete):
3381         (make_mock_valgrind_results_empty):
3382         (make_mock_valgrind_results_misformatted):
3383         (LeakDetectorValgrindTest):
3384         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
3385         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
3386         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
3387         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
3388         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
3389         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
3390         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
3391         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
3392
3393 2014-01-08  Commit Queue  <commit-queue@webkit.org>
3394
3395         Unreviewed, rolling out r161427.
3396         http://trac.webkit.org/changeset/161427
3397         https://bugs.webkit.org/show_bug.cgi?id=126645
3398
3399         Emits a stye error on any newly added files (Requested by ap
3400         on #webkit).
3401
3402         * Scripts/webkitpy/style/checkers/cpp.py:
3403         (check_style):
3404         (CppChecker):
3405         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3406         (WebKitStyleTest.test_other):
3407
3408 2014-01-08  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
3409
3410         Remove run-webkit-tests wrapper script as all platform are using NRWT now.
3411         https://bugs.webkit.org/show_bug.cgi?id=126580
3412
3413         Reviewed by Csaba Osztrogonác.
3414
3415         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3416         (RunWebKitTests): Passing --debug-rwt-logging here instead of the
3417         run-webkit-tests script.
3418         * Scripts/new-run-webkit-tests: Renamed to run-webkit-tests.
3419         * Scripts/run-webkit-tests: Removed, as it was just a temporary hack.
3420
3421 2014-01-08  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
3422
3423         Update the list of non-committer u-szeged contributors
3424         https://bugs.webkit.org/show_bug.cgi?id=126640
3425
3426         Reviewed by Csaba Osztrogonác.
3427
3428         * Scripts/webkitpy/common/config/contributors.json:
3429
3430 2014-01-08  Alberto Garcia  <berto@igalia.com>
3431
3432         Fix some compilation warnings
3433         https://bugs.webkit.org/show_bug.cgi?id=126635
3434
3435         Reviewed by Csaba Osztrogonác.
3436
3437         * GtkLauncher/main.c:
3438         (createWindow): This function is not supposed to receive any
3439         parameter, yet we are passing one.
3440
3441 2014-01-08  Brian Holt  <brian.holt@samsung.com>
3442
3443         [GTK][WK2] unskip passing unit tests
3444         https://bugs.webkit.org/show_bug.cgi?id=126637
3445
3446         Reviewed by Carlos Garcia Campos.
3447
3448         Unskip TestResources and TestAuthentication unit tests since they
3449         are passing both under Xvfb and X.
3450
3451         * Scripts/run-gtk-tests:
3452         (TestRunner):
3453
3454 2014-01-08  Alberto Garcia  <berto@igalia.com>
3455
3456         REGRESSION(r160304): [GTK] Disable libtool fast install
3457         https://bugs.webkit.org/show_bug.cgi?id=126381
3458
3459         Reviewed by Gustavo Noronha Silva.
3460
3461         Disable the libtool fast-install mode in developer/test builds.
3462
3463         In this mode binaries are generated ready to be used directly from
3464         the build tree. Otherwise they would need to be relinked when they
3465         are executed, which can take a lot of resources, particularly in
3466         debug builds.
3467
3468         * Scripts/webkitdirs.pm:
3469         (runAutogenForAutotoolsProjectIfNecessary):
3470
3471 2014-01-08  Zan Dobersek  <zdobersek@igalia.com>
3472
3473         Unreviewed GTK gardening.
3474
3475         * Scripts/run-gtk-tests:
3476         (TestRunner): Skipping the snapshot test case from the TestWebKitWebView test suite.
3477         The test is failing due to issues with Xvfb, with the problem being handled in bug #120404.
3478
3479 2014-01-07  Lucas Forschler  <lforschler@apple.com>
3480
3481         Add buildbot infrasctructure for building and testing JSC cloop
3482         https://bugs.webkit.org/show_bug.cgi?id=126604
3483
3484         Reviewed by Geoffrey Garen.
3485
3486         * BuildSlaveSupport/build.webkit.org-config/config.json:
3487         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3488         (CompileCLOOP):
3489         (RunCLOOPTests):
3490         (RunCLOOPTests.countFailures):
3491         (BuildAndTestCLOOP):
3492
3493 2014-01-07  Brian Burg  <bburg@apple.com>
3494
3495         Unreviewed. Add myself as a committer.
3496
3497         * Scripts/webkitpy/common/config/contributors.json:
3498
3499 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
3500
3501         Popovers at build.webkit.org/dashboard could have titles
3502         https://bugs.webkit.org/show_bug.cgi?id=126495
3503
3504         Reviewed by Timothy Hatcher.
3505
3506         Added titles to all popovers except for pending revisions one, which I would like
3507         to improve more (probably add an ETA).
3508
3509         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3510         (BuildbotBuilderQueueView.prototype._presentPopoverFailureLogs): Moved code for 
3511         adding a title to base class.
3512
3513         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3514         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Moved code for inserting
3515         a divider to a separate function.
3516         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Added a title.
3517         (BuildbotQueueView.prototype._presentNoChangePopover): Updated the text to match
3518         title from above function.
3519         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Renamed "contentElement"
3520         variable to "content" to match all other code.
3521         (BuildbotQueueView.prototype._addIterationHeadingToPopover): Added.
3522         (BuildbotQueueView.prototype._addDividerToPopover): Added.
3523
3524         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3525         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Add a title.
3526         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Ditto.
3527         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Ditto.
3528
3529         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3530
3531 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
3532
3533         There should be a delay when quickly switching to a different popover at build.webkit.org/dashboard
3534         https://bugs.webkit.org/show_bug.cgi?id=126472
3535
3536         Reviewed by Timothy Hatcher.
3537
3538         Added a delay when quickly switching to a different popover, making it easier to
3539         move mouse pointer from active element to its popover without accidentally opening
3540         a different popover.
3541
3542         Used this code to add a delay before creating a popover. This doesn't change UI
3543         behavior, as there was alerady a delay before it became visible, but it avoids
3544         flooding buildbot server with http requests when quickly moving the mouse over
3545         dashboard page.
3546
3547         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js:
3548         Fixed a case where popover could get stuck. If content was updated while fade-out
3549         transition was already in place, the transition was removed for no good reason.
3550
3551         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
3552         (PopoverTracker._onblur): While at it, also taught popovers to disappear on window blur.
3553
3554         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
3555         (.popover.step-in): Now that PopoverTracker has a 200ms delay of its own, reduced
3556         popover delay from 1s to 800ms.
3557
3558 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
3559
3560         Improve display of failed builds at build.webkit.org/dashboard
3561         https://bugs.webkit.org/show_bug.cgi?id=126542
3562         <rdar://problem/15753550>
3563
3564         Reviewed by Timothy Hatcher.
3565
3566         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3567         Instead of hardcoding step name, look for the first step that failed.
3568         While at it, added a popover with more links. There are multiple, and it's good
3569         to have a choice of which one to look at in each situation.
3570
3571         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3572         (BuildbotIteration.prototype.get successful): Being successful is not the opposite
3573         of having failed. Many iterations are interrupted for whatever reason internal to
3574         Buildbot, and these are suppoed to be orange, not red.
3575         (BuildbotIteration.prototype.get productive): Changed to exclude inerrupted iterations,
3576         not only WillRetry ones.
3577         (BuildbotIteration.prototype.get failed): Changed to only include iterations that
3578         actually failed, more likely indicating a problem with code base.
3579         (BuildbotIteration.prototype.get firstFailedStepName):
3580         (BuildbotIteration.prototype.failureLogURL): Expose informaiton about failure.
3581         (BuildbotIteration.prototype.get failureLogs): Ditto.
3582         (BuildbotIteration.prototype.update): Store complete results for the failed step.
3583         Not every failure stops the iteration, so we could have multiple failed steps,
3584         but let's see if seeing just the first one will be enough.
3585
3586         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3587         (BuildbotQueue.prototype.get firstRecentUnsuccessfulIteration): Updated to work in
3588         terms of successful iterations.
3589         (BuildbotQueue.prototype.get mostRecentSuccessfulIteration): Ditto.
3590
3591         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3592         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Updated to work in
3593         terms of successful iterations.
3594
3595         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3596         Removed code to create a path to build output, we now take it from results JSON.
3597
3598         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3599         Added styles for the new popover.
3600
3601 2014-01-07  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
3602
3603         defined constants should use all uppercase names with words separated by underscores.
3604         https://bugs.webkit.org/show_bug.cgi?id=126055
3605
3606         Reviewed by Alexey Proskuryakov.
3607
3608         * Scripts/webkitpy/style/checkers/cpp.py:
3609         (check_style):
3610         (CppChecker):
3611         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3612         (WebKitStyleTest.test_define_constants):
3613
3614 2014-01-07  Brian Holt  <brian.holt@samsung.com>
3615
3616         Unreviewed. Add myself as a committer.
3617
3618         * Scripts/webkitpy/common/config/contributors.json:
3619
3620 2014-01-07  Csaba Osztrogonác  <ossy@webkit.org>
3621
3622         Remove the WinCE buildbot from build.webkit.org
3623         https://bugs.webkit.org/show_bug.cgi?id=126517
3624
3625         Reviewed by Alexey Proskuryakov.
3626
3627         * BuildSlaveSupport/build.webkit.org-config/config.json:
3628         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3629         (appendCustomBuildFlags):
3630
3631 2014-01-07  Krzysztof Czech  <k.czech@samsung.com>
3632
3633         [EFL] Change ATK version to 2.11.4
3634         https://bugs.webkit.org/show_bug.cgi?id=126573
3635
3636         Reviewed by Gyuyoung Kim.
3637
3638         ATK 2.11.4 introduces some new roles, that are already being used by WebKit.
3639
3640         * efl/jhbuild.modules:
3641
3642 2014-01-07  Alberto Garcia  <berto@igalia.com>
3643
3644         [GTK][EFL] Use function jhbuildWrapperPrefixIfNeeded to run launcher
3645         https://bugs.webkit.org/show_bug.cgi?id=117275
3646
3647         Reviewed by Carlos Garcia Campos.
3648
3649         If we are not using the internal jhbuild we must not use the
3650         jhbuild-wrapper script, else it will try to download and install
3651         it.
3652
3653         * Scripts/run-launcher:
3654
3655 2014-01-07  Krzysztof Czech  <k.czech@samsung.com>
3656
3657         [ATK] Expose aria-checked mixed state as ATK_STATE_INDETERMINATE
3658         https://bugs.webkit.org/show_bug.cgi?id=125855
3659
3660         Reviewed by Mario Sanchez Prada.
3661
3662         Added new function isIndeterminate for testing aria-checked mixed state.
3663         I provided respective, but empty function in mac port. Mac testing it differently.
3664
3665         * DumpRenderTree/AccessibilityUIElement.cpp:
3666         (getIsIndeterminate):
3667         (AccessibilityUIElement::getJSClass):
3668         * DumpRenderTree/AccessibilityUIElement.h:
3669         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3670         (AccessibilityUIElement::isIndeterminate):
3671         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Added empty function.
3672         (AccessibilityUIElement::isIndeterminate):
3673         * DumpRenderTree/mac/AccessibilityUIElementMac.mm: Added empty function.
3674         (AccessibilityUIElement::isIndeterminate):
3675         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Added empty function.
3676         (AccessibilityUIElement::isIndeterminate):
3677         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3678         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3679         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3680         (WTR::AccessibilityUIElement::isIndeterminate):
3681         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3682         (WTR::AccessibilityUIElement::isIndeterminate):
3683
3684 2014-01-06  Mark Rowe  <mrowe@apple.com>
3685
3686         <https://webkit.org/b/126560> Fix incorrectness in use of some AppKit enums
3687
3688         Reviewed by Ryosuke Niwa.
3689
3690         * DumpRenderTree/mac/DumpRenderTree.mm:
3691         (-[DRTMockScroller rectForPart:]): Move to using an if with early return instead of a switch
3692         with a single case. This avoids the potential for warnings about unhandled cases.
3693         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3694         (WTR::PlatformWebView::PlatformWebView): Cast the argument to NSBackingStoreType.
3695
3696 2014-01-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3697
3698         [GTK] Move all GTK/GObject unit tests to Tools/TestWebKitAPI
3699         https://bugs.webkit.org/show_bug.cgi?id=126342
3700
3701         Reviewed by Gustavo Noronha Silva.
3702
3703         * CMakeLists.txt: Include the new unit tests subdirectories.
3704         * Scripts/run-gtk-tests: Update to refer to the new build locations.
3705         * Scripts/webkitpy/style/checker.py: Update the style checker.
3706         * Scripts/webkitpy/style/checker_unittest.py:
3707         * TestWebKitAPI/GNUmakefile.am:
3708         * TestWebKitAPI/Tests/WebKit2Gtk/AccessibilityTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/AccessibilityTestServer.cpp.
3709         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Added.
3710         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp: Added.
3711         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/DOMNodeTest.cpp.
3712         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/FrameTest.cpp.
3713         * TestWebKitAPI/Tests/WebKit2Gtk/InspectorTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/InspectorTestServer.cpp.
3714         * TestWebKitAPI/Tests/WebKit2Gtk/LoadTrackingTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/LoadTrackingTest.cpp.
3715         * TestWebKitAPI/Tests/WebKit2Gtk/LoadTrackingTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/LoadTrackingTest.h.
3716         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestAuthentication.cpp.
3717         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestBackForwardList.cpp.
3718         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestContextMenu.cpp.
3719         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestCookieManager.cpp.
3720         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMDOMWindow.cpp: Added.
3721         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestDOMNode.cpp.
3722         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestDownloads.cpp.
3723         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestFrame.cpp.
3724         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestInspector.cpp.
3725         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestInspectorServer.cpp.
3726         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestLoaderClient.cpp.
3727         * TestWebKitAPI/Tests/WebKit2Gtk/TestMain.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp.
3728         * TestWebKitAPI/Tests/WebKit2Gtk/TestMain.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestMain.h.
3729         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestPrinting.cpp.
3730         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestResources.cpp.
3731         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestSSL.cpp.
3732         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestUIClient.cpp.
3733         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebExtensions.cpp.
3734         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitAccessibility.cpp.
3735         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp.
3736         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFindController.cpp.
3737         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitPolicyClient.cpp.
3738         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitSettings.cpp.
3739         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitVersion.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitVersion.cpp.
3740         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebContext.cpp.
3741         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp.
3742         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebViewGroup.cpp.
3743         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebViewEditor.cpp.
3744         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebExtensionTest.cpp.
3745         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestBus.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestBus.cpp.
3746         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestBus.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestBus.h.
3747         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.cpp.
3748         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestServer.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.h.
3749         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.cpp.
3750         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.h.
3751         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTestRunner.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTestRunner.cpp.
3752         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTestRunner.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTestRunner.h.
3753         * TestWebKitAPI/Tests/WebKit2Gtk/WebViewTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.cpp.
3754         * TestWebKitAPI/Tests/WebKit2Gtk/WebViewTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.h.
3755         * TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/link-title.js.
3756         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/test-cert.pem.
3757         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/test-key.pem.
3758         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/webkit2gtk-tests.gresource.xml.
3759         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Added.
3760         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Renamed from Source/WebKit/gtk/tests/resources/blank.ico.
3761         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Renamed from Source/WebKit/gtk/tests/resources/test.html.
3762         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Renamed from Source/WebKit/gtk/tests/resources/test.ogg.
3763         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Renamed from Source/WebKit/gtk/tests/resources/test.pdf.
3764         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Renamed from Source/WebKit/gtk/tests/resources/test.txt.
3765         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Renamed from Source/WebKit/gtk/tests/test_utils.c.
3766         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Renamed from Source/WebKit/gtk/tests/test_utils.h.
3767         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Renamed from Source/WebKit/gtk/tests/testapplicationcache.c.
3768         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Renamed from Source/WebKit/gtk/tests/testatk.c.
3769         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Renamed from Source/WebKit/gtk/tests/testatkroles.c.
3770         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Renamed from Source/WebKit/gtk/tests/testcontextmenu.c.
3771         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Renamed from Source/WebKit/gtk/tests/testcopyandpaste.c.
3772         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Renamed from Source/WebKit/gtk/tests/testdomdocument.c.
3773         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Renamed from Source/WebKit/gtk/tests/testdomdomwindow.c.
3774         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Renamed from Source/WebKit/gtk/tests/testdomnode.c.
3775         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Renamed from Source/WebKit/gtk/tests/testdownload.c.
3776         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Renamed from Source/WebKit/gtk/tests/testfavicondatabase.c.
3777         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Renamed from Source/WebKit/gtk/tests/testglobals.c.
3778         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Renamed from Source/WebKit/gtk/tests/testhittestresult.c.
3779         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Renamed from Source/WebKit/gtk/tests/testhttpbackend.c.
3780         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Renamed from Source/WebKit/gtk/tests/testkeyevents.c.
3781         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Renamed from Source/WebKit/gtk/tests/testloading.c.
3782         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Renamed from Source/WebKit/gtk/tests/testmimehandling.c.
3783         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Renamed from Source/WebKit/gtk/tests/testnetworkrequest.c.
3784         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Renamed from Source/WebKit/gtk/tests/testnetworkresponse.c.
3785         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Renamed from Source/WebKit/gtk/tests/testwebbackforwardlist.c.
3786         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Renamed from Source/WebKit/gtk/tests/testwebdatasource.c.
3787         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Renamed from Source/WebKit/gtk/tests/testwebframe.c.
3788         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Renamed from Source/WebKit/gtk/tests/testwebhistoryitem.c.
3789         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Renamed from Source/WebKit/gtk/tests/testwebinspector.c.
3790         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Renamed from Source/WebKit/gtk/tests/testwebplugindatabase.c.
3791         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Renamed from Source/WebKit/gtk/tests/testwebresource.c.
3792         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Renamed from Source/WebKit/gtk/tests/testwebsettings.c.
3793         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Renamed from Source/WebKit/gtk/tests/testwebview.c.
3794         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Renamed from Source/WebKit/gtk/tests/testwindow.c.
3795
3796 2014-01-06  Alexey Proskuryakov  <ap@apple.com>
3797
3798         Gtk and Efl API test results confuse the dashboard
3799         https://bugs.webkit.org/show_bug.cgi?id=126535
3800
3801         Reviewed by Tim Horton.
3802
3803         Added "API tests" step as "platform api tests".
3804
3805         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3806         (Buildbot.prototype.platformAPITestResultsURLForIteration):
3807         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3808         (BuildbotIteration):
3809         (BuildbotIteration.prototype.update):
3810         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3811         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3812         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
3813
3814 2014-01-06  Tim Horton  <timothy_horton@apple.com>
3815
3816         build.webkit.org/dashboard should still function if localStorage is disabled
3817         https://bugs.webkit.org/show_bug.cgi?id=126511
3818
3819         Reviewed by Alexey Proskuryakov.
3820
3821         If localStorage is disabled, we should carry on with a warning.
3822
3823         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3824         Don't show the gear if localStorage isn't working.
3825
3826         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
3827         (QueueView.prototype._updateHiddenState):
3828         Bail if localStorage isn't working.
3829
3830         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
3831         (Settings.prototype.available):
3832
3833 2014-01-02  Roger Fong  <roger_fong@apple.com>
3834
3835         Set VSINSTALLDIR in win ews start script.
3836         https://bugs.webkit.org/show_bug.cgi?id=126407
3837
3838         Reviewed by Brent Fulgham.
3839
3840         * EWSTools/start-queue-win.sh:
3841
3842 2014-01-06  Bem Jones-Bey  <bjonesbe@adobe.com>
3843
3844         Adding myself as a reviewer.
3845
3846         Unreviewed.
3847
3848         * Scripts/webkitpy/common/config/contributors.json:
3849
3850 2014-01-06  Zan Dobersek  <zdobersek@igalia.com>
3851
3852         Unreviewed. Unbreaking JSC tests after r161328.
3853
3854         * Scripts/webkitdirs.pm:
3855         (cmakeBasedPortName): Only recognize the GTK port as CMake-based if actually building
3856         through the CMake build system (i.e. passing --gtkcmake to build-webkit).
3857
3858 2014-01-05  Martin Robinson  <mrobinson@igalia.com>
3859
3860         [GTK][CMake] Add support for building the GTK+ port with cmake to build-webkit
3861         https://bugs.webkit.org/show_bug.cgi?id=126212
3862
3863         Reviewed by Daniel Bates.
3864
3865         Allow building the GTK+ cmake port with --gtkcmake.
3866
3867         * Scripts/build-webkit: Use the new isGtkCMake function to head down the CMake path
3868         when appropriate. Skip the autotoos path when isGtkAutotools is false.
3869         * Scripts/webkitdirs.pm: Add an isGtkCMake path in addition to the newly renamed isGtkAutotools.
3870         Add isGtk which checks isGtkCMake || isGtkAutotools
3871         (determineArchitecture): Use the CMake path for GTK+ when appropriate.
3872         (argumentsForConfiguration): use --gtkcmake when appropriate.
3873         (jscProductDir): Look in the CMake directory when appropriate.
3874         (builtDylibPathForName): CMake builds the library into a different directory, so handle that.
3875         (determineIsGtkCMake): Added.
3876         (isGtkCMake): Added.
3877         (isGtkAutotools): Renamed from isGtk.
3878         (isGtk): New function which returns isGtkAutotools || isGtkCMake.
3879         (determineIsGtkAutotools): Renamed from determineIsGtk.
3880         (cmakeBasedPortName): Added a GTK+ path.
3881
3882 2014-01-04  Martin Robinson  <mrobinson@igalia.com>
3883
3884         [GTK] [CMake] Fix the video and audio build
3885         https://bugs.webkit.org/show_bug.cgi?id=126464
3886
3887         Reviewed by Philippe Normand.
3888
3889         * GtkLauncher/CMakeLists.txt: Add GStreamer includes and libraries, since GtkLauncher uses it.
3890
3891 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3892
3893         It's confusing to have two elements link to the same URL at build.webkit.org/dashboard
3894         https://bugs.webkit.org/show_bug.cgi?id=126467
3895
3896         Reviewed by Geoffrey Garen.
3897
3898         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
3899         (StatusLineView): Don't linkify the label text, the bubble is easier to target with mouse
3900         pointer, or to tap.
3901
3902 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3903
3904         build.webkit.org/dashboard says "failed build" even if it's another step that failed
3905         https://bugs.webkit.org/show_bug.cgi?id=126461
3906
3907         Reviewed by Geoffrey Garen.
3908
3909         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3910         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Link to main
3911         build page if it's not the compilation that failed. Use text from buildbot for description.
3912         Show a yellow icon if it's a different kind of failure.
3913
3914         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3915         (BuildbotIteration.prototype.update): Record whether it was compile-webkit step that failed.
3916
3917 2014-01-03  Bem Jones-Bey  <bjonesbe@adobe.com>
3918
3919         setup-git-clone fails to get email address from git
3920         https://bugs.webkit.org/show_bug.cgi?id=126446
3921
3922         Reviewed by Ryosuke Niwa.
3923
3924         The setup-git-clone command fails to get an email address from git
3925         because of a bug in VCSUtils. This patch fixes that bug, and also
3926         makes it so that when VCSUtils fails for real because of a local
3927         misconfiguration, the error message is actually presented to the user
3928         of setup-git-clone.
3929
3930         * Scripts/VCSUtils.pm:
3931         (gitConfig): Call isGit() instead of accessing $isGit directly to make
3932             sure that $isGit is properly initialized.
3933         * Scripts/webkitpy/tool/commands/setupgitclone.py:
3934         (SetupGitClone.execute): Pull out username and email acquistion to
3935             it's own method.
3936         (SetupGitClone._get_username_and_email): Catch the exception thrown
3937             when VCSUtils fails and print out the error message so that the
3938             user actually knows why the command failed.
3939
3940 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3941
3942         It feels too hard to get rid of a popover at build.webkit.org/dashboard
3943         https://bugs.webkit.org/show_bug.cgi?id=126451
3944
3945         Reviewed by Simon Fraser.
3946
3947         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
3948         (.popover.fade-out): Reduced the timeout - 200 ms is enough to not have flicker
3949         when moving the mouse from an element to its popover.
3950
3951 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3952
3953         Please add a way to quick peek at failing tests at build.webkit.org/dashboard
3954         https://bugs.webkit.org/show_bug.cgi?id=122181
3955
3956         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3957         (BuildbotQueueView.prototype._presentNoChangePopover): Update one more place for
3958         popover.present signature change.
3959
3960 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3961
3962         Please add a way to quick peek at failing tests at build.webkit.org/dashboard
3963         https://bugs.webkit.org/show_bug.cgi?id=122181
3964
3965         Reviewed by Timothy Hatcher and Timothy Horton.
3966
3967         Detailed results are saved by run-webkit-tests to full_results.json (which is actually
3968         JSONP). Dashboard will load them on demand.
3969
3970         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3971         (Buildbot.prototype.layoutTestResultsURLForIteration): Moved from WebKitBuildbot.js
3972         and made it use a function from WebKitBuildbot that builds results directory path.
3973         (Buildbot.prototype.layoutTestFullResultsURLForIteration): Added a function that builds
3974         a URL for full_results.json.
3975         (Buildbot.prototype.layoutTestCrashLogForIteration): Added a function that builds
3976         a URL for a crash log.
3977
3978         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3979         (BuildbotIteration.prototype.loadLayoutTestResults): Load and cache layout test results for
3980         the iteration.
3981
3982         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:        
3983         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Updated for changed
3984         popover API (see below).
3985         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Ditto.
3986
3987         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3988         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Added a check
3989         for iterations that were interrupted (previously, they were displayed incorrectly,
3990         often as passes). Install popover trackers for failure bubbles for which we can currently
3991         display something useful.
3992         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Build
3993         a popover for layout test regressions when we have the data loaded on demand.
3994         We have test paths, special indicators for crashes/timeouts, and links to test history
3995         at flakiness dashboard.
3996         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Show
3997         the popover for layout test regressions. Just shows "Loading..." until the data is
3998         loaded.
3999         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): List
4000         types of failures if there are multiple. There is a lot of similarity with
4001         appendBuilderQueueStatus(), but I couldn't find a good way to share the code.
4002
4003         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
4004         Create a global test history object, which is used for links in layout test popover.
4005
4006         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js:
4007         Changed the API to be more like WebInspector again, allowing for changing content
4008         of an existing popover. As the size of a popover can change, making the mouse pointer
4009         enter it without a mousenter event, install a handler for mousewheel instead, and block
4010         document scrolling from this event handler when needed.
4011
4012         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
4013         (StatusLineView.prototype.get statusBubbleElement): Added an accessor for status
4014         bubble element, making it possible to install a popover on it.
4015
4016         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
4017         (JSON.load): Added the ability to load JSONP by providing an optional callback name.
4018
4019         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4020         (WebKitBuildbot.prototype.layoutTestResultsDirectoryURLForIteration): Switched from
4021         building a complete results URL to only building one for root results path. This is
4022         the part that depends on specific buildbot installation, everything relative to it
4023         is the same.
4024
4025         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js: Added.
4026         Build a path to test history page. In the future, we may consider adding code to
4027         load the data and display it inline.
4028
4029         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
4030         Added styles for this new popover.
4031
4032         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added
4033         a new file, WebKitTestHistory.js.
4034
4035 2014-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
4036
4037         REGRESSION(r161214): [GTK] WebKit2 C API tests fail to run after r161214
4038         https://bugs.webkit.org/show_bug.cgi?id=126430
4039
4040         Reviewed by Martin Robinson.
4041
4042         * Scripts/run-gtk-tests:
4043         (TestRunner._setup_testing_environment):
4044         * gtk/common.py: Use common.tests_library_build_path() instead.
4045         (tests_library_build_path): Helper funtion that returns the path
4046         where the tests libraries are built.
4047
4048 2014-01-03  Martin Robinson  <mrobinson@igalia.com>
4049
4050         [CMake] Build TestWebKitAPI tests into a directory structure
4051         https://bugs.webkit.org/show_bug.cgi?id=126358
4052
4053         Reviewed by Gyuyoung Kim.
4054
4055         WebKitGTK+ builds the TestWebKitAPI tests into a "TestWebKitAPI" directory. This
4056         is useful for keeping the "bin" directory tidy during building and will make it easier
4057         to integrate the CMake build into the existing WebKitGTK+ scripts.
4058
4059         * TestWebKitAPI/CMakeLists.txt: Set the output directory of all TestWebKitAPI binaries
4060         and make the names simpler now that the directory identifies what category the test is in.
4061
4062 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
4063
4064         Provide a visual clue when element has a popover at build.webkit.org/dashboard
4065         https://bugs.webkit.org/show_bug.cgi?id=126281
4066
4067         Reviewed by Timothy Hatcher.
4068
4069         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
4070         (PopoverTracker): Add a class name to elements with popovers.
4071
4072         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
4073         (*): We have -webkit-user-select:none, so let's also not show text selection cursor.
4074         I might have broke that recently.
4075         (*:link): Show hand cursor over links.
4076         (.popover-tracking:hover): Put a shadow on hover over element with popovers.
4077
4078         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
4079         (.status-line .message .revision-number): Show text selection cursor on our only
4080         selectable text element.
4081         (.status-line .bubble.popover-tracking:hover): Text in a bubble looks better with
4082         a white shadow than with a dark one on hover.
4083
4084 2014-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
4085
4086         [GTK] Add API to WebKitResponsePolicyDecision to check if the MIME type can be shown
4087         https://bugs.webkit.org/show_bug.cgi?id=124652
4088
4089         Reviewed by Martin Robinson.
4090
4091         * MiniBrowser/gtk/BrowserWindow.c:
4092         (webViewDecidePolicy): Use the new API instead of
4093         webkit_web_view_can_show_mime_type().
4094
4095 2014-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
4096
4097         REGRESSION(r160304): [GTK] Disable libtool fast install
4098         https://bugs.webkit.org/show_bug.cgi?id=126381
4099
4100         Reviewed by Martin Robinson.
4101
4102         Remove -no-fast-install ld flag since fast install is now disabled
4103         globally.
4104
4105         * GNUmakefile.am:
4106         * GtkLauncher/GNUmakefile.am:
4107         * MiniBrowser/gtk/GNUmakefile.am:
4108         * TestWebKitAPI/GNUmakefile.am:
4109         * WebKitTestRunner/GNUmakefile.am:
4110
4111 2014-01-02  Ryuan Choi  <ryuan.choi@samsung.com>
4112
4113         Unreviewed. Add myself to EFL and related watch lists.
4114
4115         * Scripts/webkitpy/common/config/watchlist:
4116
4117 2014-01-02  Danilo Cesar Lemes de Paula  <danilo.cesar@collabora.co.uk>
4118
4119         [GTK] fixing ycm_extra_conf.py file
4120         https://bugs.webkit.org/show_bug.cgi?id=126371
4121
4122         It's an attempt to fix three problems with the current ycm_extra_conf file.
4123         The current implementation assumes that it's a symlink, which is not true.
4124         Usually python creates a pyc file, and this is what you get in __file__.
4125         the .pyc is not a symlink, and the current implementation doesn't work
4126         if that's the case.
4127
4128         It also assumes that the user is in the root folder.
4129         If the user is in WebkitBuild/Debug and open a file as ../../Source/* it won't work.
4130
4131         Last but not least, "elif flag in FLAGS_PRECEDING_PATHS" emits an
4132         exception since "flag" doesn't exists.
4133
4134         All those things were fixed.
4135
4136         Reviewed by Martin Robinson.
4137
4138         * gtk/ycm_extra_conf.py:
4139         (transform_relative_paths_to_absolute_paths):
4140
4141 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
4142
4143         Bindings tests results links are broken at build.webkit.org/dashboard
4144         https://bugs.webkit.org/show_bug.cgi?id=126402
4145
4146         Reviewed by Tim Horton.
4147
4148         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
4149         (Buildbot.prototype.bindingsTestResultsURLForIteration): Fixed a typo that was there
4150         since the beginning.
4151
4152 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
4153
4154         "+" is very confusing at http://build.webkit.org/dashboard
4155         https://bugs.webkit.org/show_bug.cgi?id=126400
4156
4157         Reviewed by Tim Horton.
4158
4159         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
4160         (BuildbotQueueView.prototype._appendPendingRevisionCount): Instead of listing open
4161         source and internal counts separately, simply add them. One can always open a popover
4162         for more detail.
4163
4164 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
4165
4166         Accessing Trac from build.webkit.org/dashboard should enable XMLHttpRequest.withCredentials
4167         https://bugs.webkit.org/show_bug.cgi?id=126391
4168
4169         Reviewed by Dan Bernstein.
4170
4171         Make it conditional, as trac.webkit.org doesn't work when withCredentials is enabled.
4172         One can request credentials use via Initialization.js.
4173
4174         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
4175         (Trac):
4176         (Trac.prototype.update):
4177         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
4178         (loadXML):
4179
4180 2014-01-02  Commit Queue  <commit-queue@webkit.org>
4181
4182         Unreviewed, rolling out r160846.
4183         http://trac.webkit.org/changeset/160846
4184         https://bugs.webkit.org/show_bug.cgi?id=126395
4185
4186         Breaks build scripts for Windows when Visual Studio is not
4187         installed in Program Files (Requested by rfong on #webkit).
4188
4189         * Scripts/webkitdirs.pm:
4190         (visualStudioInstallDir):
4191
4192 2014-01-02  Martin Robinson  <mrobinson@igalia.com>
4193
4194         [GTK] [CMake] run-gtk-tests should run with the cmake build
4195         https://bugs.webkit.org/show_bug.cgi?id=126341
4196
4197         Reviewed by Carlos Garcia Campos.
4198
4199         * Scripts/run-gtk-tests:
4200         (TestRunner.__init__): Use the new calling conventions for the common script.
4201         (TestRunner._setup_testing_environment): Ditto.
4202         * gtk/common.py:
4203         (set_build_types): Added set_build_types, to avoid having build_type arguments
4204         for all functions in common.
4205         (binary_build_path): Added this function which gets the path to the built binaries.
4206         (get_build_path): Removed the build_types argument.
4207         (build_path): Removed the build_types argument and call get_build_path directly now.
4208
4209 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
4210
4211         https://bugs.webkit.org/show_bug.cgi?id=126391
4212         Accessing Trac from build.webkit.org/dashboard should enable XMLHttpRequest.withCredentials
4213