fb31e7c0e921e3a3398a57f2223e2324ff21f42d
[WebKit-https.git] / Tools / ChangeLog
1 2013-10-21  Tamas Gergely  <gertom@inf.u-szeged.hu>
2
3         Run tests as if they are expected to pass when --force is given.
4         https://bugs.webkit.org/show_bug.cgi?id=112890
5
6         Reviewed by Ryosuke Niwa.
7
8         The --force switch of new-run-webkit-tests is now forces all tests to
9         be run with 'PASS' as expected result.
10
11         * Scripts/webkitpy/layout_tests/controllers/manager.py:
12         (Manager.run):
13         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
14         (TestExpectations.__init__):
15         (TestExpectations._add_expectations):
16         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
17         (parse_args):
18         (_set_up_derived_options):
19
20 2013-10-21  Mark Rowe  <mrowe@apple.com>
21
22         Add a version of WebKitSystemInterface for Mavericks.
23
24         Reviewed by Ryosuke Niwa.
25
26         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
27         * Scripts/copy-webkitlibraries-to-product-directory:
28         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
29
30 2013-10-21  Anders Carlsson  <andersca@apple.com>
31
32         Navigation policy callback not called when performing the same fragment navigation twice
33         https://bugs.webkit.org/show_bug.cgi?id=123121
34         <rdar://problem/15230466>
35
36         Reviewed by Beth Dakin.
37
38         Add a test.
39
40         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
41         * TestWebKitAPI/Tests/mac/FragmentNavigation.html: Added.
42         * TestWebKitAPI/Tests/mac/FragmentNavigation.mm: Added.
43         (+[WebKit1FragmentNavigationTestDelegate shared]):
44         (-[WebKit1FragmentNavigationTestDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
45         (-[WebKit1FragmentNavigationTestDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
46         (-[WebKit1FragmentNavigationTestDelegate webView:didFinishLoadForFrame:]):
47         (-[WebKit1FragmentNavigationTestDelegate _runNextTestWithWebView:]):
48         (TestWebKitAPI::TEST):
49
50 2013-10-21  Dan Bernstein  <mitz@apple.com>
51
52         Style checker should allow a space after the @property keyword
53         https://bugs.webkit.org/show_bug.cgi?id=123117
54
55         Reviewed by Anders Carlsson.
56
57         * Scripts/webkitpy/style/checkers/cpp.py:
58         (check_spacing_for_function_call): Allow a space between @property and the following (
59         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
60         (CppStyleTest.test_spacing_for_fncall): Added a test case.
61
62 2013-10-21  peavo@outlook.com  <peavo@outlook.com>
63
64         [WinCairo] Build does not start.
65         https://bugs.webkit.org/show_bug.cgi?id=123059
66
67         Reviewed by Csaba Osztrogonác.
68
69         The function isAppleWinWebKit() does no longer return true for WinCairo, need to add isWinCairo() checks instead.
70
71         * Scripts/build-webkit:
72
73 2013-10-21  Zan Dobersek  <zdobersek@igalia.com>
74
75         [Jhbuild] Bump the required Jhbuild revision
76         https://bugs.webkit.org/show_bug.cgi?id=123089
77
78         Reviewed by Carlos Garcia Campos.
79
80         * jhbuild/jhbuild-wrapper: Latest versions of the gnome-common tools produce failures when configuring Jhbuild
81         due to the configure.ac script using both IT_PROG_INTLTOOL and AM_GNU_GETTEXT macros. This is already fixed
82         in the Jhbuild source so a more recent revision of it should be used.
83
84 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
85
86         Mac build fix.
87
88         * DumpRenderTree/mac/DumpRenderTree.mm: Cast the length for %lu specifier.
89
90 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
91
92         Enable webaudio/ tests on DRT/Mac
93         https://bugs.webkit.org/show_bug.cgi?id=86914
94
95         Reviewed by Darin Adler.
96
97         * DumpRenderTree/ForwardingHeaders/runtime/ArrayBufferView.h: Copied from Source/WebCore/ForwardingHeaders/runtime/ArrayBufferView.h.
98         * DumpRenderTree/ForwardingHeaders/runtime/JSArrayBufferView.h: Copied from Source/WebCore/ForwardingHeaders/runtime/JSArrayBufferView.h.
99         * DumpRenderTree/ForwardingHeaders/runtime/TypedArrayInlines.h: Copied from Source/WebCore/ForwardingHeaders/runtime/TypedArrayInlines.h.
100         There is no way to efficiently get TypedArray buffer using API, so we need some internal headers.
101
102         * DumpRenderTree/TestRunner.cpp:
103         (setAudioResultCallback): 
104         (TestRunner::staticFunctions):
105         * DumpRenderTree/TestRunner.h:
106         (TestRunner::audioResult):
107         (TestRunner::setAudioResult):
108         The function has a different name and argument type now, updated accordingly.
109         Changed buffer from std::string to std::vector<char>, because it's more idiomatic.
110
111         * DumpRenderTree/mac/DumpRenderTree.mm:
112         (dumpAudio): Updated for the new name of audioResult accessor.
113         (dump): Print the result in the format webkitpy currently expects.
114
115         * WebKitTestRunner/TestInvocation.cpp:
116         (WTR::TestInvocation::dumpAudio): fwrite the whole block at once, splitting into
117         chunks made no sense.
118
119         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
120         (WTR::TestRunner::setAudioResult): Added a FIXME about getting off WKBundle SPI.
121
122         * DumpRenderTree/CMakeLists.txt: Added JavaScriptCore/parser to include search list,
123         so that "SourceProvider.h" can be found.
124
125 2013-10-19  Ryosuke Niwa  <rniwa@webkit.org>
126
127         run-webkit-tests should submit time and modifiers to the new flakiness dashboard
128         https://bugs.webkit.org/show_bug.cgi?id=123070
129
130         Reviewed by Alexey Proskuryakov.
131
132         * Scripts/webkitpy/layout_tests/controllers/manager.py:
133         (Manager.run):
134         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
135         (summarize_results): Added include_time_and_modifiers. Report test_run_time and modifiers
136         in the test expectations when this argument is set to true.
137
138 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
139
140         Mac DumpRenderTree builds without NDEBUG even in release mode
141         https://bugs.webkit.org/show_bug.cgi?id=123066
142
143         Reviewed by Dan Bernstein.
144
145         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
146         * DumpRenderTree/mac/Configurations/Base.xcconfig:
147         Use the same pattern as WebCore and WebKitTestRunner.
148
149 2013-10-19  Zan Dobersek  <zdobersek@igalia.com>
150
151         REGRESSION(r155373): Mac WK2 EWS bots is actually Mac WK1 debug
152         https://bugs.webkit.org/show_bug.cgi?id=123064
153
154         Reviewed by Ryosuke Niwa.
155
156         Revert r155373 as it is causing incorrect port/platform deduction for the Mac EWS systems.
157
158         * Scripts/webkitpy/common/config/ports.py: Added.
159         (DeprecatedPort):
160         (DeprecatedPort.name):
161         (DeprecatedPort.flag):
162         (DeprecatedPort.script_path):
163         (DeprecatedPort.script_shell_command):
164         (DeprecatedPort.port):
165         (DeprecatedPort.makeArgs):
166         (DeprecatedPort.update_webkit_command):
167         (DeprecatedPort.check_webkit_style_command):
168         (DeprecatedPort.prepare_changelog_command):
169         (DeprecatedPort.build_webkit_command):
170         (DeprecatedPort.run_javascriptcore_tests_command):
171         (DeprecatedPort.run_webkit_unit_tests_command):
172         (DeprecatedPort.run_webkit_tests_command):
173         (DeprecatedPort.run_python_unittests_command):
174         (DeprecatedPort.run_perl_unittests_command):
175         (DeprecatedPort.run_bindings_tests_command):
176         (MacPort):
177         (MacWK2Port):
178         (MacWK2Port.run_webkit_tests_command):
179         (WinPort):
180         (WinPort.run_bindings_tests_command):
181         (GtkPort):
182         (GtkPort.build_webkit_command):
183         (GtkPort.run_webkit_tests_command):
184         (GtkWK2Port):
185         (GtkWK2Port.build_webkit_command):
186         (GtkWK2Port.run_webkit_tests_command):
187         (QtPort):
188         (QtPort.build_webkit_command):
189         (QtPort.run_webkit_tests_command):
190         (QtWK2Port):
191         (QtWK2Port.build_webkit_command):
192         (QtWK2Port.run_webkit_tests_command):
193         (EflPort):
194         (EflPort.build_webkit_command):
195         (EflWK2Port):
196         (EflWK2Port.build_webkit_command):
197         * Scripts/webkitpy/common/config/ports_mock.py: Added.
198         (MockPort):
199         (MockPort.name):
200         (MockPort.check_webkit_style_command):
201         (MockPort.update_webkit_command):
202         (MockPort.build_webkit_command):
203         (MockPort.prepare_changelog_command):
204         (MockPort.run_python_unittests_command):
205         (MockPort.run_perl_unittests_command):
206         (MockPort.run_javascriptcore_tests_command):
207         (MockPort.run_webkit_unit_tests_command):
208         (MockPort.run_webkit_tests_command):
209         (MockPort.run_bindings_tests_command):
210         * Scripts/webkitpy/common/config/ports_unittest.py: Added.
211         (DeprecatedPortTest):
212         (DeprecatedPortTest.test_mac_port):
213         (DeprecatedPortTest.test_gtk_port):
214         (DeprecatedPortTest.test_gtk_wk2_port):
215         (DeprecatedPortTest.test_efl_port):
216         (DeprecatedPortTest.test_qt_port):
217         (DeprecatedPortTest.test_qt_wk2_port):
218         * Scripts/webkitpy/port/base.py:
219         (Port._port_flag_for_scripts):
220         (Port._wk2_port_name):
221         * Scripts/webkitpy/port/base_unittest.py:
222         (PortTest.test_build_path):
223         * Scripts/webkitpy/port/efl_unittest.py:
224         (EflPortTest.test_show_results_html_file):
225         * Scripts/webkitpy/port/gtk_unittest.py:
226         (GtkPortTest.test_get_crash_log):
227         * Scripts/webkitpy/port/mac_unittest.py:
228         (test_64bit):
229         * Scripts/webkitpy/port/test.py:
230         (TestPort.virtual_test_suites):
231         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
232         (FlakyTestReporter.__init__):
233         * Scripts/webkitpy/tool/bot/irc_command.py:
234         (Rollout._update_working_copy):
235         * Scripts/webkitpy/tool/commands/download_unittest.py:
236         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
237         (AbstractEarlyWarningSystem.run_command):
238         * Scripts/webkitpy/tool/commands/queues.py:
239         (PatchProcessingQueue.begin_work_queue):
240         (CommitQueue.run_command):
241         * Scripts/webkitpy/tool/main.py:
242         (WebKitPatch.__init__):
243         (WebKitPatch.deprecated_port):
244         (WebKitPatch.handle_global_options):
245         * Scripts/webkitpy/tool/mocktool.py:
246         (MockTool.__init__):
247         (MockTool.deprecated_port):
248         * Scripts/webkitpy/tool/steps/build.py:
249         (Build.build):
250         * Scripts/webkitpy/tool/steps/checkstyle.py:
251         (CheckStyle.run):
252         * Scripts/webkitpy/tool/steps/commit.py:
253         (Commit._check_test_expectations):
254         * Scripts/webkitpy/tool/steps/preparechangelog.py:
255         (PrepareChangeLog.run):
256         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
257         (PrepareChangeLogForRevert.run):
258         * Scripts/webkitpy/tool/steps/runtests.py:
259         (RunTests.run):
260         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
261         (RunTestsTest.test_webkit_run_unit_tests):
262         * Scripts/webkitpy/tool/steps/steps_unittest.py:
263         (StepsTest.test_runtests_args):
264         * Scripts/webkitpy/tool/steps/update.py:
265         (Update._update_command):
266         * Scripts/webkitpy/tool/steps/update_unittest.py:
267         (UpdateTest.test_update_command_non_interactive):
268         (UpdateTest.test_update_command_interactive):
269
270 2013-10-19  Andreas Kling  <akling@apple.com>
271
272         RefPtr::releaseNonNull() incorrectly increments the refcount.
273         <https://webkit.org/b/123063>
274
275         Add an API test to verify that no extra refs are added when calling
276         RefPtr::releaseNonNull().
277
278         Reviewed by Anders Carlsson.
279
280 2013-10-18  Rik Cabanier <cabanier@adobe.com>
281         Add Rik Cabanier to list of committers
282         https://bugs.webkit.org/show_bug.cgi?id=123031
283
284         reviewed by Dirk Schulze.
285
286         * Tools/Scripts/webkitpy/common/config/contributors.json: Added name.
287
288 2013-10-18  Denis Nomiyama  <d.nomiyama@samsung.com>
289
290         [ATK] Fix invalid signal to set objects to an unknown state "layout-complete"
291         https://bugs.webkit.org/show_bug.cgi?id=122970
292
293         Reviewed by Mario Sanchez Prada.
294
295         Removed an invalid signal to set an object state to layout-complete
296         that does not exist. It was replaced by ATK:AtkDocument:load-complete.
297
298         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
299         (axObjectEventListener): Replaced layout-complete with load-complete.
300         (connectAccessibilityCallbacks): Connect callback to new listener for
301         ATK:AtkDocument:load-complete.
302         (disconnectAccessibilityCallbacks): Disconnect callback to new listener
303         for ATK:AtkDocument:load-complete.
304         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
305         (axObjectEventListener): Replaced layout-complete with load-complete.
306         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
307         Connect callback to new listener for ATK:AtkDocument:load-complete.
308         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
309         Disconnect callback to new listener for ATK:AtkDocument:load-complete.
310
311 2013-10-18  Carlos Garcia Campos  <cgarcia@igalia.com>
312
313         [GTK] Generate API documentation for GObject DOM bindings
314         https://bugs.webkit.org/show_bug.cgi?id=121538
315
316         Reviewed by Gustavo Noronha Silva.
317
318         The .symbols file that is now generated for checking GObject DOM
319         bindings API compatibility while building can also be used to
320         generate the files needed to produce the gtk-doc
321         documentation. The new script generate-webkitdom-doc-files can
322         generate the docs.sgml and sections.txt files from the given list
323         of .symbols files.
324
325         * gtk/GNUmakefile.am: Add rules to generate webkitdomgtk-docs.sgml
326         and webkitdomgtk-sections.txt as well as rules to install the
327         generated WebKitDOMGTK documentation.
328         * gtk/generate-gtkdoc:
329         (webkitdom_docs_html_path): New helper function that returns the
330         path where the DOM API documentation has been generated.
331         (get_webkit2_options): Include DOM API docs to the list of xref
332         dependencies.
333         (get_webkit1_options): Ditto.
334         (get_webkitdom_options): Return the gtk-doc options to generate
335         the DOM API docs.
336         (get_webkitdom_options.derived_sources_path):
337         (get_webkitdom_options.src_path):
338         * gtk/generate-webkitdom-doc-files: Added.
339         (WebKitDOMDocGenerator):
340         (WebKitDOMDocGenerator.write_header):
341         (WebKitDOMDocGenerator.write_section):
342         (WebKitDOMDocGenerator.write_footer):
343         (WebKitDOMDocGeneratorDocs):
344         (WebKitDOMDocGeneratorDocs.write_header):
345         (write_section):
346         (write_footer):
347         (WebKitDOMDocGeneratorSections):
348         (WebKitDOMDocGeneratorSections.__init__):
349         (WebKitDOMDocGeneratorSections._dom_class):
350         (WebKitDOMDocGeneratorSections._dom_class_decamelize):
351         (WebKitDOMDocGeneratorSections._symbol_list):
352         (WebKitDOMDocGeneratorSections.write_section):
353
354 2013-10-17  Alex Christensen  <achristensen@webkit.org>
355
356         Run JavaScriptCore tests again on Windows.
357         https://bugs.webkit.org/show_bug.cgi?id=122787
358
359         Reviewed by Tim Horton.
360
361         * Scripts/build-jsc:
362         (buildMyProject): Use JavaScriptCore.sln to build JavaScriptCore and WTF.
363         * Scripts/run-javascriptcore-tests: Don't run stress tests on WinCairo.
364         * Scripts/webkitdirs.pm:
365         (determineConfigurationForVisualStudio):
366         (determineConfigurationProductDir):
367         Build directory should end with bin64 and configuration should end with |x64 on Win64.
368         (isAppleWinWebKit):
369         (copyInspectorFrontendFiles):
370         (setPathForRunningWebKitApp):
371         Separated WinCairo directories and options from AppleWin.
372
373 2013-10-17  Mihnea Ovidenie  <mihnea@adobe.com>
374
375         Unreviewed. Add myself as a reviewer.
376
377         * Scripts/webkitpy/common/config/contributors.json:
378
379 2013-10-17  Andreas Kling  <akling@apple.com>
380
381         Make it possible to assign a PassRef to a RefPtr.
382         <https://webkit.org/b/122943>
383
384         Added a small API test for RefPtr=(PassRef) so we know this code
385         will compile (and work.)
386
387         Reviewed by Antti Koivisto.
388
389 2013-10-16  Filip Pizlo  <fpizlo@apple.com>
390
391         We need test coverage for just the Baseline JIT
392         https://bugs.webkit.org/show_bug.cgi?id=122929
393
394         Reviewed by Sam Weinig.
395         
396         Adds no-LLInt versions of all tests. For the Mozilla tests, also add a BaselineJIT-only
397         variant.
398
399         * Scripts/run-jsc-stress-tests:
400
401 2013-10-16  Ryosuke Niwa  <rniwa@webkit.org>
402
403         Support multiple repositories in submitting results to --results-server-host
404         https://bugs.webkit.org/show_bug.cgi?id=122935
405
406         Reviewed by Anders Carlsson.
407
408         Remoevd --got-revision and added the logic to extract revision information
409         from multiple repositories as done in run-perf-tests.
410
411         * Scripts/webkitpy/layout_tests/controllers/manager.py:
412         (Manager.upload_results):
413         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
414         (parse_args):
415
416 2013-10-16  Darin Adler  <darin@apple.com>
417
418         Add PassRef and createRefCounted so we can improve creation of RefCounted objects
419         https://bugs.webkit.org/show_bug.cgi?id=122904
420
421         Reviewed by Anders Carlsson.
422
423         * TestWebKitAPI/Tests/WTF/Ref.cpp: Added some basic tests for adoptRef and PassRef.
424
425 2013-10-16  Darin Adler  <darin@apple.com>
426
427         Need tests for RefPtr self-assignment and self-move-assignment.
428
429         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Added tests.
430
431 2013-10-16  Robert Plociennik  <r.plociennik@samsung.com>
432
433         [EFL] Minibrowser can't load child window's location
434         https://bugs.webkit.org/show_bug.cgi?id=122485
435
436         Reviewed by Gyuyoung Kim.
437
438         * MiniBrowser/efl/main.c: Now calling window_create() without the url parameter
439             followed by an explicit call to ewk_view_url_set() where appropriate.
440         (on_key_down):
441         (on_window_create):
442         (window_create):
443         (elm_main):
444
445 2013-10-15  Sergio Correia  <sergio.correia@openbossa.org>
446
447         [EFL][WK2] Make SeccompFilters build again after r156349 and r156353
448         https://bugs.webkit.org/show_bug.cgi?id=122872
449
450         Reviewed by Anders Carlsson.
451
452         * TestWebKitAPI/PlatformEfl.cmake: Mark SeccompFilters API test as
453         failing.
454
455 2013-10-15  Dean Jackson  <dino@apple.com>
456
457         Add ENABLE_WEB_ANIMATIONS flag
458         https://bugs.webkit.org/show_bug.cgi?id=122871
459
460         Reviewed by Tim Horton.
461
462         Eventually might be http://dev.w3.org/fxtf/web-animations/
463         but this is just engine-internal work at the moment.
464
465         * Scripts/webkitperl/FeatureList.pm:
466
467 2013-10-15  Darin Adler  <darin@apple.com>
468
469         Add some API tests for Vector, RefPtr, and Ref
470         https://bugs.webkit.org/show_bug.cgi?id=122840
471
472         Reviewed by Andreas Kling.
473
474         * TestWebKitAPI/CMakeLists.txt: Added new files.
475         * TestWebKitAPI/GNUmakefile.am: Ditto.
476         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
477         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
478         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
479
480         * TestWebKitAPI/Tests/WTF/Ref.cpp: Added.
481         * TestWebKitAPI/Tests/WTF/RefLogger.h: Added.
482         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Added.
483         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added move-only insert tests.
484
485 2013-10-14  Roger Fong  <roger_fong@apple.com>
486
487         Adding myself to CC list for some components.
488
489         * Scripts/webkitpy/common/config/watchlist:
490
491 2013-10-13  Darin Adler  <darin@apple.com>
492
493         Deprecate or remove deleteAllValues functions; there are only a few call sites left
494         https://bugs.webkit.org/show_bug.cgi?id=122738
495
496         Reviewed by Anders Carlsson.
497
498         * DumpRenderTree/win/DRTDataObject.cpp:
499         (DRTDataObject::~DRTDataObject):
500         * DumpRenderTree/win/UIDelegate.cpp:
501         (DRTUndoStack::~DRTUndoStack):
502         (DRTUndoStack::clear):
503         Renamed deleteAllValues to deprecatedDeleteAllValues.
504
505         * Scripts/do-webcore-rename: Updated to perform this rename, as is traditional.
506
507 2013-10-13  Alexey Proskuryakov  <ap@apple.com>
508
509         build.webkit.org/dashboard incorrectly shows interrupted builds as green
510         https://bugs.webkit.org/show_bug.cgi?id=122732
511
512         Reviewed by Tim Hatcher.
513
514         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
515         (BuildbotIteration.prototype.update): Removed a special case for status 4 (EXCEPTION).
516         I don't see it occur any time in recent history, but judging from what happens for
517         status 5 (RETRY), we can just finish this function normally.
518         Record overall text description for iteration as BuildbotIteration.text.
519
520         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
521         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): If an iteration is a failure,
522         but no tests failed, make it yellow, and use buildbot-provided description for it.
523
524 2013-10-13  Alexey Proskuryakov  <ap@apple.com>
525
526         Remove Chromium specific code from flakiness dashboard
527         https://bugs.webkit.org/show_bug.cgi?id=122714
528
529         Reviewed by Sam Weinig.
530
531         Also removed code related to GPU tests and virtual suites.
532         "Fallbacks map" was chromium only too, not sure why they needed special handling there.
533
534         * TestResultServer/model/jsonresults_unittest.py:
535         * TestResultServer/static-dashboards/builders.js:
536         * TestResultServer/static-dashboards/dashboard_base.js:
537         * TestResultServer/static-dashboards/flakiness_dashboard.html:
538         * TestResultServer/static-dashboards/flakiness_dashboard.js:
539         * TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
540         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
541         * TestResultServer/static-dashboards/history.js:
542         * TestResultServer/static-dashboards/loader.js:
543         * TestResultServer/static-dashboards/ui.js:
544         * TestResultServer/templates/uploadform.html:
545
546 2013-10-11  Timothy Hatcher  <timothy@apple.com>
547
548         Remove preference support for picking the old Web Inspector.
549         https://bugs.webkit.org/show_bug.cgi?id=122655
550
551         Reviewed by Alexey Proskuryakov.
552
553         * WebKitTestRunner/TestController.cpp:
554         (WTR::TestController::resetStateToConsistentValues):
555
556 2013-10-11  Filip Pizlo  <fpizlo@apple.com>
557
558         Fix 64-bit build on everything but Windows.
559
560         Rubber stamped by Brent Fulgham.
561
562         * Scripts/webkitdirs.pm:
563         (argumentsForConfiguration):
564
565 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
566
567         Touch a file to see how auto-update works.
568
569         Rubber-stamped by Tim Hatcher.
570
571         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
572
573 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
574
575         LeaksViewer fails to present recent results list if current build is still updating svn
576         https://bugs.webkit.org/show_bug.cgi?id=122670
577
578         Fixed an obvious mistake in the previous patch.
579
580         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
581         (RecentBuildsLoader.prototype.start):
582
583 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
584
585         LeaksViewer fails to present recent results list if current build is still updating svn
586         https://bugs.webkit.org/show_bug.cgi?id=122670
587
588         Reviewed by Adam Roben.
589
590         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
591         (RecentBuildsLoader.prototype.start): Skip builds that don't have an svn revision yet.
592
593 2013-10-11  Brent Fulgham  <bfulgham@apple.com>
594
595         Unreviewed build fix for --64-bit target.
596
597         * Scripts/webkitdirs.pm:
598         (argumentsForConfiguration): Use 'isWin64' test, since @ARGV value may have
599         been removed by this point.
600         (hasArgument): Remove unused temporary.
601
602 2013-10-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
603
604         webkit-patch failure-reason has a quite low limit for 'too many failures'
605         https://bugs.webkit.org/show_bug.cgi?id=122556
606
607         Reviewed by Darin Adler.
608
609         * Scripts/webkitpy/tool/commands/queries.py:
610         (FailureReason._explain_failures_for_builder): adjust the number of too many failures
611         to match what the layout test runners use these days.
612
613 2013-10-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
614
615         webkit-patch failure-reason should allow specifying failures one is interested in
616         https://bugs.webkit.org/show_bug.cgi?id=122554
617
618         Reviewed by Darin Adler.
619
620         * Scripts/webkitpy/tool/commands/queries.py:
621         (FailureReason):
622         (FailureReason._explain_failures_for_builder): keep track of explained failures and drop out of the
623         loop if the ones we're interested in been explained.
624         (FailureReason._done_explaining): check the failures we're interested in have been explained, if any.
625         (FailureReason.execute): initialize failures to explain and the explained set.
626
627 2013-10-10  Filip Pizlo  <fpizlo@apple.com>
628
629         Make sure that DataTypes.h is in the binary drop.
630
631         Rubber stamped by Michael Saboff.
632
633         * Scripts/export-llvm-build:
634
635 2013-10-10  Filip Pizlo  <fpizlo@apple.com>
636
637         FTL: Soft-link LLVM as a workaround for LLVM's static initializers and exit-time destructors
638         https://bugs.webkit.org/show_bug.cgi?id=122566
639
640         Reviewed by Mark Rowe.
641
642         * Scripts/configure-llvm:
643
644 2013-10-10  Mark Rowe  <mrowe@apple.com>
645
646         <rdar://problem/13341666> WebKit should always build against an SDK.
647
648         Have all projects default to building against the OS X Internal SDK for the Production
649         configuration. For the Debug and Release configurations, look for UseInternalSDK.xcconfig
650         to determine whether the OS X Internal SDK should be used. If not, use the normal OS X SDK.
651
652         Reviewed by Dan Bernstein.
653
654         * DumpRenderTree/mac/Configurations/Base.xcconfig:
655         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
656         * MiniBrowser/Configurations/Base.xcconfig:
657         * MiniBrowser/Configurations/DebugRelease.xcconfig:
658         * TestWebKitAPI/Configurations/Base.xcconfig:
659         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
660         * WebKitTestRunner/Configurations/Base.xcconfig:
661         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
662
663 2013-10-10  Gustavo Noronha Silva  <gns@gnome.org>
664
665         Unreviewed gardening, the inspector protocol timeouts are also affecting TestInspectorServer.
666
667         * Scripts/run-gtk-tests:
668         (TestRunner): skip TestInspectorServer.
669
670 2013-10-10  Andres Gomez  <agomez@igalia.com>
671
672         [GTK] Provide search functionality to MiniBrowser
673         https://bugs.webkit.org/show_bug.cgi?id=117631
674
675         Reviewed by Carlos Garcia Campos.
676
677         Adds a search bar to MiniBrowser with the minimum functionality
678         and a new button to the toolbar for showing the new search
679         bar. Typical keyboard shortcuts are also added.
680
681         * MiniBrowser/gtk/BrowserSearchBar.c: Added.
682         (doSearch):
683         (searchNext):
684         (searchPrevious):
685         (searchCloseButtonClickedCallback):
686         (searchEntryMenuIconPressedCallback):
687         (searchEntryClearIconReleasedCallback):
688         (searchEntryChangedCallback):
689         (searchEntryActivatedCallback):
690         (searchPrevButtonClickedCallback):
691         (searchNextButtonClickedCallback):
692         (searchMenuCheckButtonToggledCallback):
693         (browser_search_bar_init):
694         (browserSearchBarFinalize):
695         (browser_search_bar_class_init):
696         (browser_search_bar_new):
697         (browser_search_bar_add_accelerators):
698         (browser_search_bar_open):
699         (browser_search_bar_close):
700         * MiniBrowser/gtk/BrowserSearchBar.h: Added.
701         * MiniBrowser/gtk/BrowserWindow.c:
702         (webViewEnterFullScreen): Closes new search bar.
703         (webViewLeaveFullScreen): Opens new search bar if previously
704         visible.
705         (searchCallback): Added. Shows and hides the new search bar.
706         (browser_window_init): Added search button to the toolbar.
707         (browserWindowConstructed): Creates the new search bar.
708         * MiniBrowser/gtk/GNUmakefile.am: Added new files to compilation.
709
710 2013-10-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
711
712         webkit-patch failure-reason fails with UnicodeDecodeError when name has non-ascii characters
713         https://bugs.webkit.org/show_bug.cgi?id=122552
714
715         Reviewed by Darin Adler.
716
717         * Scripts/webkitpy/common/checkout/commitinfo.py:
718         (CommitInfo.blame_string): ensure objects are made into unicode strings, not regular ones that
719         will cause UnicodeDecodeError for non-ascii characters.
720
721 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
722
723         Would like a link to dashboard from build.webkit.org main page
724         https://bugs.webkit.org/show_bug.cgi?id=122577
725
726         Reviewed by Tim Hatcher.
727
728         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added.
729
730 2013-10-09  Brent Fulgham  <bfulgham@apple.com>
731
732         [Win] Check for MathML fonts and warn user if they are missing.
733         https://bugs.webkit.org/show_bug.cgi?id=122568
734
735         Reviewed by Tim Horton.
736
737         * Scripts/webkitdirs.pm:
738         (checkRequiredSystemConfig): Use common gperf/bison/flex tests, rather than
739         Windows-specific code I added previously.
740         (fontExists): Added
741         (checkInstalledTools): Add check for MathML fonts.
742
743 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
744
745         http://build.webkit.org/dashboard/ doesn't link to webkitpy failures
746         https://bugs.webkit.org/show_bug.cgi?id=122471
747
748         Reviewed by Tim Hatcher.
749
750         Added links to webkitpy, webkitperl and bindings-tests results.
751
752         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
753         (Buildbot.prototype.apiTestResultsURLForIteration):
754         (Buildbot.prototype.webkitpyTestResultsURLForIteration):
755         (Buildbot.prototype.webkitperlTestResultsURLForIteration):
756         (Buildbot.prototype.bindingsTestResultsURLForIteration):
757         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
758         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
759
760 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
761
762         Move some functions from WebKitBuildbot to Buildbot class.
763
764         Suggested by Tim Hatcher.
765
766         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
767         (Buildbot.prototype.javascriptTestResultsURLForIteration):
768         (Buildbot.prototype.apiTestResultsURLForIteration):
769         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
770         (WebKitBuildbot.prototype.layoutTestResultsURLForIteration):
771
772 2013-10-09  Timothy Hatcher  <timothy@apple.com>
773
774         Add API tests to the Dashbord page.
775
776         https://bugs.webkit.org/show_bug.cgi?id=122283
777
778         Reviewed by Timothy Hatcher.
779
780         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
781         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
782         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
783         (WebKitBuildbot.prototype.apiTestResultsURLForIteration):
784
785 2013-10-09  Timothy Hatcher  <timothy@apple.com>
786
787         Attempt to fix faulty Dashboard iteration updating by always rebuilding test result objects.
788
789         https://bugs.webkit.org/show_bug.cgi?id=122515
790
791         Reviewed by Alexey Proskuryakov.
792
793         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
794         (BuildbotIteration.prototype.update):
795
796 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
797
798         build.webkit.org/dashboard doesn't provide a results link when there issues at multiple steps
799         https://bugs.webkit.org/show_bug.cgi?id=122573
800
801         Reviewed by Tim Hatcher.
802
803         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
804         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Provide a URL.
805
806         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
807         (Buildbot.prototype.buildPageURLForIteration): Added.
808
809 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
810
811         http://build.webkit.org/dashboard/ links to a wrong jscore-test results page
812         https://bugs.webkit.org/show_bug.cgi?id=122569
813
814         Reviewed by Tim Hatcher.
815
816         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
817         (WebKitBuildbot.prototype.javascriptTestResultsURLForIteration): "actual.html" used
818         to be produced by the old Mozilla test harness that we don't use any more.
819
820 2013-10-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
821
822         Add GTK 64 bits release to the buildbot dashboard
823         https://bugs.webkit.org/show_bug.cgi?id=122548
824
825         Reviewed by Darin Adler.
826
827         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png: Added.
828         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
829         (WebKitBuildbot): add 64 bits release wk2 and wk1 testers.
830         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
831         (table.queue-grid tr.platform.linux-gtk img.logo): use the GTK+ logo in its dashboard line.
832
833 2013-10-09  Mario Sanchez Prada  <mario.prada@samsung.com>
834
835         [ATK] Implement new API in AtkText: atk_text_get_string_at_offset()
836         https://bugs.webkit.org/show_bug.cgi?id=120638
837
838         Reviewed by Gustavo Noronha Silva.
839
840         * gtk/jhbuild.modules: Raised ATK and AT-SPI versions to 2.10.0, so we
841         can check both the old and new APIs to retrieve text at a given offset.
842
843 2013-10-08  Alex Christensen  <achristensen@webkit.org>
844
845         Improved WinLauncher.
846         https://bugs.webkit.org/show_bug.cgi?id=122536
847
848         Reviewed by Brent Fulgham.
849
850         * WinLauncher/PrintWebUIDelegate.cpp:
851         (PrintWebUIDelegate::runJavaScriptAlertPanelWithMessage): Added.
852         (PrintWebUIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
853         * WinLauncher/PrintWebUIDelegate.h: Removed stubs.
854         * WinLauncher/WinLauncher.cpp:
855         (createCrashReport): Use the executable name instead of "WinLauncher".
856         * WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Removed.
857         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link to Wininet.lib.
858         * win/DLLLauncher/DLLLauncherMain.cpp: Remove VS2005 dependency for WinCairo.
859
860 2013-10-08  Mark Lam  <mark.lam@apple.com>
861
862         Fix ruby LoadError when running run-javascriptcore-tests.
863         https://bugs.webkit.org/show_bug.cgi?id=122519.
864
865         Reviewed by Mark Hahnenberg.
866
867         The scripts needed to explicitly require 'rubygems' for older versions of ruby
868         (versions before 1.9).
869
870         * Scripts/jsc-stress-test-helpers/profiler-test-helper:
871         * Scripts/run-jsc-stress-tests:
872
873 2013-10-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
874
875         Unreviewed, add my new email to contributors.json.
876
877         * Scripts/webkitpy/common/config/contributors.json:
878
879 2013-10-08  Brent Fulgham  <bfulgham@apple.com>
880
881         Unreviewed build correction.
882
883         * Scripts/webkitpy/port/win.py:
884         (WinPort.write_registry_value): Use string representation of error message to avoid
885         format conversion problem.
886
887 2013-10-07  Brent Fulgham  <bfulgham@apple.com>
888
889         [Win] Add checks for proper build and test environment
890         https://bugs.webkit.org/show_bug.cgi?id=122466
891
892         Reviewed by Darin Adler.
893
894         This patch makes two changes:
895         1. Update webkitdirs.pm to check for some common misconfigurations and provide helpful warnings or
896            error messages so that people know what to fix to get things working.
897         2. Modify the win.py port to handle the 32-bit and 64-bit test environments, as well as making sure
898            the various environment settings are properly configured for our test environment.
899
900         * Scripts/webkitdirs.pm:
901         (checkInstalledTools): Add checks for some common Cygwin configuration problems that have
902         caused problems in the past.
903         (setupAppleWinEnv):
904         * Scripts/webkitpy/port/win.py:
905         (WinPort):
906         (WinPort.read_registry_string): Parameterize for run architecture and registry root.
907         (WinPort.write_registry_value): Parameterize registry writing by data type (string versus
908         DWORD, etc.)
909         (WinPort.write_registry_string): Revise to call new generic registry write function.
910         (WinPort.setup_crash_log_saving): Revise for new API
911         (WinPort.restore_crash_log_saving): Ditto
912         (WinPort.prevent_error_dialogs): Add new methods to prevent Windows dialogs that block our test
913         servers from running.
914         (WinPort.allow_error_dialogs): Ditto.
915         (WinPort.setup_test_run): Call new API to turn off user input dialogs on program failure.
916         (WinPort.clean_up_test_run): Call new API to reactivatea user input dialogs after test run finished.
917
918 2013-10-08  Philippe Normand  <pnormand@igalia.com>
919
920         [GStreamer] enable v4l2 plugin
921         https://bugs.webkit.org/show_bug.cgi?id=122503
922
923         Reviewed by Martin Robinson.
924
925         * gtk/jhbuild.modules: Enable the plugin, it now builds fine since
926         we updated our GStreamer version to 1.0.8.
927
928 2013-10-08  Mario Sanchez Prada  <mario.prada@samsung.com>
929
930         [ATK] Expose state of aria-invalid as ATK_STATE_INVALID_ENTRY
931         https://bugs.webkit.org/show_bug.cgi?id=122104
932
933         Reviewed by Chris Fleizach.
934
935         Updated stringAttributeValue to double check that the exposure of
936         aria-invalid as a state is consistent with its exposure as a text
937         attribute as well, when it applies (implementations of AtkText).
938
939         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
940         (AccessibilityUIElement::stringAttributeValue): Add double check.
941         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
942         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
943
944 2013-10-07  Filip Pizlo  <fpizlo@apple.com>
945
946         run-jsc-stress-tests progress meter should update more quickly on older Rubies
947         https://bugs.webkit.org/show_bug.cgi?id=122459
948
949         Reviewed by Darin Adler.
950
951         * Scripts/run-jsc-stress-tests:
952
953 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
954
955         [buildbot] parse tests that are reported as crashed correctly for GTK+
956         https://bugs.webkit.org/show_bug.cgi?id=122476
957
958         Reviewed by Martin Robinson.
959
960         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
961         (RunGtkAPITests.commandComplete): parse the crashed tests output so that is reported
962         as a failure of the API tests.
963
964 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
965
966         Unreviewed. Skipping API test that is causing the next one to crash,
967         see https://bugs.webkit.org/show_bug.cgi?id=121970.
968
969         * Scripts/run-gtk-tests:
970         (TestRunner):
971
972 2013-10-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
973
974         [GTK] run-gtk-tests does not distinguish between failure and crashes
975         https://bugs.webkit.org/show_bug.cgi?id=122135
976
977         Reviewed by Martin Robinson.
978
979         The GTK+ API test runner does not distinguish between failures and crashes. This change
980         makes it do that, so it's easier for us to spot the more important/higher priority crash
981         case.
982
983         * Scripts/run-gtk-tests:
984         (TestRunner._run_test_command): return the exit code instead of a boolean true/false,
985         so we have more information on how the process ended.
986         (TestRunner._run_test): check the exit code to distinguish between crashes and failures.
987         (TestRunner.run_tests): report crashes.
988
989 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
990
991         [GTK] Missing packages for APT on install-dependencies
992         https://bugs.webkit.org/show_bug.cgi?id=121555
993
994         Reviewed by Martin Robinson.
995
996         * gtk/install-dependencies: add packages that are needed for
997         building WebKit itself and the jhbuild dependencies.
998
999 2013-10-07  Anders Carlsson  <andersca@apple.com>
1000
1001         Fix test failures.
1002
1003         * Scripts/webkitpy/port/base.py:
1004         (Port.to.start_helper):
1005         * Scripts/webkitpy/port/mock_drt.py:
1006         (MockDRTPort.start_helper):
1007
1008 2013-10-07  Anders Carlsson  <andersca@apple.com>
1009
1010         Always force discrete mode when running layout tests
1011         https://bugs.webkit.org/show_bug.cgi?id=122465
1012
1013         Reviewed by Tim Horton.
1014
1015         This should speed up WebGL tests and hopefully prevent race conditions that may cause window server crashes from happening.
1016         
1017         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1018         Link with IOKit.
1019
1020         * DumpRenderTree/mac/LayoutTestHelper.m:
1021         (installLayoutTestColorProfile):
1022         Check installColorProfile.
1023
1024         (restoreUserColorProfile):
1025         Check installColorProfile.
1026
1027         (lockDownDiscreteGraphics):
1028         New function to force discrete graphics.
1029
1030         (main):
1031         Add '--install-color-profile' option.
1032
1033         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1034         (Manager._set_up_run):
1035         Always start the helper, but pass self._options.pixel_tests to it.
1036
1037         * Scripts/webkitpy/port/mac.py:
1038         (MacPort.start_helper):
1039         Pass --install-color-profile' to the helper if pixel_tests is true.
1040
1041 2013-10-07  Timothy Hatcher  <timothy@apple.com>
1042
1043         Properly count binding test failures as failures.
1044
1045         Fix the total for multiple failures in different steps too by avoiding undefined.
1046
1047         https://bugs.webkit.org/show_bug.cgi?id=122232
1048
1049         Reviewed by Alexey Proskuryakov.
1050
1051         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1052         (BuildbotTestResults):
1053         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1054         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1055
1056 2013-10-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1057
1058         [GTK] Fails to build with jhbuild with newer system glib
1059         https://bugs.webkit.org/show_bug.cgi?id=122132
1060
1061         Reviewed by Martin Robinson.
1062
1063         Newer glib includes new symbols that some system libraries which we depend on, such as pango, have
1064         started relying on. glib is not a dependency that should change test results, and is provided in
1065         jhbuild with the intention of supporting the other bits that do, so using a newer stable release
1066         should not be an issue.
1067
1068         * gtk/jhbuild.modules:
1069
1070 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
1071
1072         run-jsc-stress-tests shouldn't print its goofy progress meter when running on the bots
1073         https://bugs.webkit.org/show_bug.cgi?id=122437
1074
1075         Reviewed by Antoine Quint.
1076
1077         * Scripts/run-jsc-stress-tests:
1078
1079 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
1080
1081         Unreviewed, fix build on old Rubies.
1082
1083         * Scripts/run-jsc-stress-tests:
1084
1085 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
1086
1087         Unified test infrastructure via the jsc shell
1088         https://bugs.webkit.org/show_bug.cgi?id=120696
1089
1090         Reviewed by Oliver Hunt.
1091         
1092         Make run-jsc-stress-tests smart enough to be able to handle different styles of test
1093         output (silent or noisy) and different styles of test failure (just bad exit code,
1094         text diff, filtering for some magical text, etc.). This allows me to get rid of the
1095         layout-test-helper. It also allows me to switch all of the old Mozilla tests to
1096         running in run-jsc-stress-tests.
1097         
1098         Also removes all of the code paths that defended against not having shellwords. Just
1099         install the shellwords gem if you want to run tests.
1100         
1101         Also removes the non-parallel test running code. No reason for it to exist anymore.
1102         
1103         This is a massive increase in test coverage. It uncovered bugs. I fixed two of them
1104         as part of this patch, and left three more as new bugzillas.
1105
1106         * Scripts/create-mozilla-js-test-list: Added.
1107         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
1108         * Scripts/jsc-stress-test-helpers/layout-test-helper: Removed.
1109         * Scripts/run-javascriptcore-tests:
1110         * Scripts/run-jsc-stress-tests:
1111
1112 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
1113
1114         run-jsc-stress-tests should be less verbose
1115         https://bugs.webkit.org/show_bug.cgi?id=122397
1116
1117         Reviewed by Sam Weinig.
1118         
1119         It now just prints something like:
1120         
1121          965/1831 ....
1122         
1123         Where the first number is the number of tests that completed, the second number is the
1124         number of tests total, and the dots are the number of tests running right now - which is
1125         useful towards the end when you're waiting for the last slow tests to finish.
1126         
1127         It will also print out the output from failing tests and it will print a line for skipped
1128         tests (to annoy you into getting them into a shape where they can be unskipped). For
1129         example, for LayoutTests, it will print just the diff, if the test fails. It's cool.
1130
1131         * Scripts/run-jsc-stress-tests:
1132
1133 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
1134
1135         Allow skipping of run-jsc-stress-tests that are configured using yaml files
1136         https://bugs.webkit.org/show_bug.cgi?id=122385
1137
1138         Reviewed by Sam Wieinig.
1139         
1140         Make tests run via YAML be able to do the parse-for-commands trick that allows
1141         us to skip tests and do other custom per-test stuff.
1142
1143         * Scripts/jsc-stress-test-helpers/layout-test-helper:
1144         * Scripts/run-jsc-stress-tests:
1145
1146 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
1147
1148         Unreviewed, fix tests on older Rubies.
1149
1150         * Scripts/run-jsc-stress-tests:
1151
1152 2013-10-05  Anders Carlsson  <andersca@apple.com>
1153
1154         Don't filter the weak symbols.
1155
1156         * Scripts/check-for-weak-vtables-and-externals:
1157
1158 2013-10-04  Filip Pizlo  <fpizlo@apple.com>
1159
1160         Have run-javascriptcore-tests run JS LayoutTests using run-jsc-stress-tests so that it runs in parallel
1161         https://bugs.webkit.org/show_bug.cgi?id=122376
1162
1163         Reviewed by Mark Hahnenberg.
1164
1165         * Scripts/jsc-stress-test-helpers/layout-test-helper: Added.
1166         * Scripts/run-javascriptcore-tests:
1167         (printThingsFound):
1168         * Scripts/run-jsc-stress-tests:
1169
1170 2013-10-04  Filip Pizlo  <fpizlo@apple.com>
1171
1172         It should be even easier to run and debug a failing JSC stress test
1173         https://bugs.webkit.org/show_bug.cgi?id=122337
1174
1175         Reviewed by Oliver Hunt.
1176         
1177         If a test fails, you can now just say:
1178
1179         sh WebKitBuild/Debug/jsc-stress-results/regress/script-tests/emscripten-cube2hash.js.ftl-eager-no-cjit
1180
1181         and get the reproduction. You don't have to set any environment variables like before.
1182         Also if you want to debug the failing test you can now just say:
1183
1184         sh WebKitBuild/Debug/jsc-stress-results/regress/script-tests/emscripten-cube2hash.js.ftl-eager-no-cjit lldb --
1185
1186         Broadly, any arguments passed to the reproduction script are prepended to the command to
1187         run the test. This is sort of quirky and won't work for some tests (for example the
1188         profiler tests run a ruby script that runs some other stuff) but it'll work for most of
1189         them and that's good enough for now.
1190
1191         * Scripts/run-jsc-stress-tests:
1192
1193 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
1194
1195         [Windows] Correct run-path when using 64-bit binaries.
1196
1197         Reviewed by David Kilzer.
1198
1199         * Scripts/webkitdirs.pm:
1200         (determineConfigurationProductDir): If running in 64-bit mode, use the 'bin64'
1201         directory. Otherwise use the existing 'bin32' directory.
1202
1203 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
1204
1205         Teach webkitdirs.pm to honor the --64-bit flag
1206         https://bugs.webkit.org/show_bug.cgi?id=122357
1207
1208         Reviewed by David Kilzer.
1209
1210         * Scripts/webkitdirs.pm:
1211         (argumentsForConfiguration): Modify to check if --64-bit is supplied
1212         by the user.
1213         (findMatchingArguments): Added.
1214         (hasArgument): Added.
1215         (checkForArgumentAndRemoveFromArrayRef): Refactor to use the new
1216         findMatchingArguments subroutine.
1217
1218 2013-10-04  Alexey Proskuryakov  <ap@apple.com>
1219
1220         Update svn-config for new Visual Studio extensions
1221         https://bugs.webkit.org/show_bug.cgi?id=122344
1222
1223         Reviewed by Brent Fulgham.
1224
1225         * svn-config: Add new Visual Studio extensions.
1226
1227 2013-10-04  Alex Christensen  <achristensen@webkit.org>
1228
1229         Made WinLauncher have better error handling, crash reporting, and modifiability.
1230         https://bugs.webkit.org/show_bug.cgi?id=122319
1231
1232         Reviewed by Brent Fulgham.
1233
1234         * WinLauncher/WinLauncher.cpp:
1235         (WinLauncherWebHost::didFailProvisionalLoadWithError):
1236         Don't display the numerous "Cancelled" messages that are obviously from the user.
1237         (createCrashReport): Added.
1238         (dllLauncherEntryPoint):
1239         Made main loop back into while loop and write a crash report if it crashes.
1240         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1241         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
1242         Added WinLauncherReplace.h.
1243         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
1244         Added linking to DbgHelp.lib.
1245         * WinLauncher/WinLauncherReplace.h:
1246         Added to make modifying WinLauncher behaviour and appearance easy.
1247         (processCrashDump): Added.
1248
1249 2013-10-04  Dirk Pranke  <dpranke@chromium.org>
1250
1251         remove dpranke from webkitpy watchlist
1252         https://bugs.webkit.org/show_bug.cgi?id=122331
1253
1254         Reviewed by Brent Fulgham.
1255
1256         * Scripts/webkitpy/common/config/watchlist:
1257
1258 2013-10-04  Tim Horton  <timothy_horton@apple.com>
1259
1260         [mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
1261         https://bugs.webkit.org/show_bug.cgi?id=122299
1262
1263         Reviewed by Beth Dakin.
1264
1265         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1266         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
1267         The last fix didn't work; instead of trying to block, turn off threaded scrolling for all three tests.
1268
1269 2013-10-04  Alexey Proskuryakov  <ap@apple.com>
1270
1271         Watchlist is broken after <http://trac.webkit.org/r156880>
1272
1273         * Scripts/webkitpy/common/config/watchlist: Remove an incorrect change.
1274
1275 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
1276
1277         Remove Qt features from build and test tools
1278         https://bugs.webkit.org/show_bug.cgi?id=122312
1279
1280         Reviewed by Anders Carlsson.
1281
1282         * Scripts/build-dumprendertree:
1283         * Scripts/build-jsc:
1284         * Scripts/build-webkit:
1285         * Scripts/build-webkittestrunner:
1286         * Scripts/old-run-webkit-tests:
1287         (openDumpTool):
1288         (buildPlatformResultHierarchy):
1289         (buildPlatformTestHierarchy):
1290         (readSkippedFiles):
1291         * Scripts/run-launcher:
1292         * Scripts/run-qtwebkit-tests: Removed.
1293         * Scripts/run-webkit-tests:
1294         (useNewRunWebKitTests):
1295         * Scripts/update-webkit:
1296         * Scripts/webkit-build-directory:
1297         * Scripts/webkitdirs.pm:
1298         (argumentsForConfiguration):
1299         (jscProductDir):
1300         (builtDylibPathForName):
1301         (isAppleWebKit):
1302         (launcherPath):
1303         (launcherName):
1304         (checkRequiredSystemConfig):
1305         (setupCygwinEnv):
1306         (copyInspectorFrontendFiles):
1307         (setPathForRunningWebKitApp):
1308         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
1309         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1310         (BaselineOptimizerTest.test_mac_future):
1311         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
1312         (BaselineOptimizerTest.test_common_directory_includes_root):
1313         (BaselineOptimizerTest.test_virtual_ports_filtered):
1314         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1315         (test_parse_reviewer_text):
1316         * Scripts/webkitpy/common/config/watchlist:
1317         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1318         (PortTest.disabled_test_chromium_mac_lion_in_test_shell_mode):
1319         * Scripts/webkitpy/port/base.py:
1320         (Port.__init__):
1321         (Port._port_flag_for_scripts):
1322         (Port._wk2_port_name):
1323         * Scripts/webkitpy/port/builders.py:
1324         * Scripts/webkitpy/port/factory.py:
1325         (platform_options):
1326         (PortFactory):
1327         (PortFactory._default_port):
1328         * Scripts/webkitpy/port/factory_unittest.py:
1329         (FactoryTest.test_gtk):
1330         * Scripts/webkitpy/port/qt.py: Removed.
1331         * Scripts/webkitpy/port/qt_unittest.py: Removed.
1332         * Scripts/webkitpy/style/checker.py:
1333         * Scripts/webkitpy/style/checker_unittest.py:
1334         (GlobalVariablesTest.test_path_rules_specifier):
1335         * Scripts/webkitpy/style/checkers/cmake.py:
1336         (CMakeChecker):
1337         * Scripts/webkitpy/style/checkers/cpp.py:
1338         (_classify_include):
1339         (check_include_line):
1340         (check_identifier_name_in_declaration):
1341         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1342         (OrderOfIncludesTest.test_classify_include):
1343         (WebKitStyleTest.test_names):
1344         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1345         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
1346         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1347         (TestRebaselineTest.test_baseline_directory):
1348         * Scripts/webkitpy/tool/main.py:
1349         (WebKitPatch):
1350
1351 2013-10-03  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1352
1353         Unreviewed. Add myself to some watchlists.
1354
1355         * Scripts/webkitpy/common/config/watchlist:
1356
1357 2013-10-03  Ryosuke Niwa  <rniwa@webkit.org>
1358
1359         Remove Qt builders from the flakiness dashboard.
1360
1361         * TestResultServer/static-dashboards/builders.jsonp:
1362         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1363         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1364         * TestResultServer/static-dashboards/loader_unittests.js:
1365
1366 2013-10-03  Tim Horton  <timothy_horton@apple.com>
1367
1368         [mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
1369         https://bugs.webkit.org/show_bug.cgi?id=122299
1370
1371         Reviewed by Beth Dakin.
1372
1373         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
1374         Disable threaded scrolling.
1375
1376         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1377         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
1378         Synchronously wait for the scrolling thread to inform the main thread of the new scroll position.
1379
1380 2013-10-03  Anders Carlsson  <andersca@apple.com>
1381
1382         Use numeric strings in the OS version dictionary
1383         https://bugs.webkit.org/show_bug.cgi?id=122300
1384
1385         Reviewed by Mark Rowe.
1386
1387         * Scripts/webkitpy/common/system/platforminfo.py:
1388         (PlatformInfo._determine_mac_version):
1389
1390 2013-10-03  Alexey Proskuryakov  <ap@apple.com>
1391
1392         Fix LeaksViewer to load leaks results from MountainLion, not Lion.
1393
1394         Rubber-stamped by Tim Horton.
1395
1396         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1397         (LeaksViewer._displayURLPrompt):
1398
1399 2013-10-03  Dan Bernstein  <mitz@apple.com>
1400
1401         REGRESSION (r156811): Objective-C JavaScriptCore API test failing on Mountain Lion bots
1402         https://bugs.webkit.org/show_bug.cgi?id=122260
1403
1404         Reviewed by Alexey Proskuryakov.
1405
1406         For the API to work, the tests need to be compiled with a newer version of the LLVM
1407         compiler. Until the bots are updated to that version, disable the tests on 10.8.
1408
1409         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
1410
1411 2013-10-02  Mario Sanchez Prada  <mario.prada@samsung.com>
1412
1413         [ATK] Expose aria-invalid as a text attribute (not object attribute)
1414         https://bugs.webkit.org/show_bug.cgi?id=122015
1415
1416         Reviewed by Chris Fleizach.
1417
1418         Adapted DRT and WKTR to check the exposure of the aria-invalid
1419         attribute as a text attribute, instead of an object attribute.
1420
1421         Also, done some refactoring of the code to try to keep things
1422         simpler and more coherent, by defining new helper functions,
1423         simplifying code, moving static variables and functions into
1424         unnammed namespaces and so on, without altering the logic other
1425         than for checking the text attribute for aria-invalid.
1426
1427         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1428         (coreAttributeToAtkAttribute): Consider 'invalid' as the name of
1429         the attribute exposed by the ATK wrapper, not 'aria-invalid'.
1430         Also, never return an empty string if not falling through any of
1431         the cases checked here, and return the original attribute instead.
1432         (atkAttributeValueToCoreAttributeValue): New helper function to
1433         match the attributes values returned by the ATK wrapper with the
1434         values expected by the layout tests. Moved the mappings for the
1435         values of AXSortDirection here as well.
1436         (getAttributeSet): New helper function to retrieve a list of
1437         attributes (an AtkAttributeSet) from an AtkObject using the right
1438         API depending on whether we want the object attributes or the text
1439         attributes (in case the object implements AtkText).
1440         (getAttributeSetValueForId): Simplified by using getAttributeSet
1441         and atkAttributeValueToCoreAttributeValue. Also, added a new
1442         parameter to indicater whether we are interested in object
1443         attributes or text attributes.
1444         (getAtkAttributeSetAsString): Ditto.
1445         (attributesOfElement): Updated to pass the new required parameter
1446         to getAtkAttributeSetAsString, indicating that we want the object
1447         attributes in this case, for backwards compatibility.
1448         (indexRangeInTable): Moved up in the file into the unnammed namespace.
1449         (alterCurrentValue): Ditto.
1450         (AccessibilityUIElement::stringAttributeValue): After moving most
1451         of the code here to the new helper functions, simplified it by
1452         just checking whether the required attribute is provided as an
1453         object attribute or, if that's not the case, as a text attribute.
1454         (AccessibilityUIElement::isAttributeSupported): Ditto.
1455         (AccessibilityUIElement::intValue): Updated to pass the new
1456         required parameter to getAttributeSetValueForId, indicating that
1457         we want the object attributes in this case.
1458         (AccessibilityUIElement::hasPopup): Ditto.
1459
1460         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1461         (WTR::coreAttributeToAtkAttribute): Same changes than for DRT.
1462         (WTR::atkAttributeValueToCoreAttributeValue): Ditto.
1463         (WTR::getAttributeSet): Ditto.
1464         (WTR::getAttributeSetValueForId): Ditto.
1465         (WTR::getAtkAttributeSetAsString): Ditto.
1466         (WTR::attributesOfElement): Ditto.
1467         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
1468         (WTR::AccessibilityUIElement::isAttributeSupported): Ditto.
1469         (WTR::AccessibilityUIElement::intValue): Ditto.
1470         (WTR::AccessibilityUIElement::hasPopup): Ditto.
1471
1472 2013-10-02  Ryosuke Niwa  <rniwa@webkit.org>
1473
1474         EWS build fix after the Qt EWS removal.
1475
1476         * QueueStatusServer/model/attachment.py:
1477         (Attachment._calculate_queue_positions):
1478
1479 2013-10-02  Anders Carlsson  <andersca@apple.com>
1480
1481         Remove Qt code from Tools/
1482         https://bugs.webkit.org/show_bug.cgi?id=122227
1483
1484         Reviewed by Andreas Kling.
1485
1486         * DumpRenderTree/WorkQueue.cpp:
1487         * DumpRenderTree/blackberry/src.pro: Removed.
1488         * DumpRenderTree/qt/DumpRenderTree.pro: Removed.
1489         * DumpRenderTree/qt/DumpRenderTree.qrc: Removed.
1490         * DumpRenderTree/qt/DumpRenderTreeMain.cpp: Removed.
1491         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Removed.
1492         * DumpRenderTree/qt/DumpRenderTreeQt.h: Removed.
1493         * DumpRenderTree/qt/EventSenderQt.cpp: Removed.
1494         * DumpRenderTree/qt/EventSenderQt.h: Removed.
1495         * DumpRenderTree/qt/GCControllerQt.cpp: Removed.
1496         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Removed.
1497         * DumpRenderTree/qt/TestRunnerQt.cpp: Removed.
1498         * DumpRenderTree/qt/TestRunnerQt.h: Removed.
1499         * DumpRenderTree/qt/TextInputControllerQt.cpp: Removed.
1500         * DumpRenderTree/qt/TextInputControllerQt.h: Removed.
1501         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Removed.
1502         * DumpRenderTree/qt/WorkQueueItemQt.h: Removed.
1503         * DumpRenderTree/qt/fonts/AHEM____.TTF: Removed.
1504         * DumpRenderTree/qt/resources/user.css: Removed.
1505         * DumpRenderTree/qt/testplugin.cpp: Removed.
1506         * DumpRenderTree/qt/testplugin.h: Removed.
1507         * ImageDiff/ImageDiff.pro: Removed.
1508         * ImageDiff/qt/ImageDiff.cpp: Removed.
1509         * MiniBrowser/qt/BrowserWindow.cpp: Removed.
1510         * MiniBrowser/qt/BrowserWindow.h: Removed.
1511         * MiniBrowser/qt/MiniBrowser.pro: Removed.
1512         * MiniBrowser/qt/MiniBrowser.qrc: Removed.
1513         * MiniBrowser/qt/MiniBrowserApplication.cpp: Removed.
1514         * MiniBrowser/qt/MiniBrowserApplication.h: Removed.
1515         * MiniBrowser/qt/UrlLoader.cpp: Removed.
1516         * MiniBrowser/qt/UrlLoader.h: Removed.
1517         * MiniBrowser/qt/icons/checkbox_checked.png: Removed.
1518         * MiniBrowser/qt/icons/checkbox_unchecked.png: Removed.
1519         * MiniBrowser/qt/icons/contents_width.png: Removed.
1520         * MiniBrowser/qt/icons/favicon.png: Removed.
1521         * MiniBrowser/qt/icons/find.png: Removed.
1522         * MiniBrowser/qt/icons/folder.png: Removed.
1523         * MiniBrowser/qt/icons/info.png: Removed.
1524         * MiniBrowser/qt/icons/next.png: Removed.
1525         * MiniBrowser/qt/icons/plus.png: Removed.
1526         * MiniBrowser/qt/icons/previous.png: Removed.
1527         * MiniBrowser/qt/icons/refresh.png: Removed.
1528         * MiniBrowser/qt/icons/stop.png: Removed.
1529         * MiniBrowser/qt/icons/titlebar.png: Removed.
1530         * MiniBrowser/qt/icons/touch.png: Removed.
1531         * MiniBrowser/qt/icons/touchpoint.png: Removed.
1532         * MiniBrowser/qt/icons/up.png: Removed.
1533         * MiniBrowser/qt/js/MultiSelect.js: Removed.
1534         * MiniBrowser/qt/main.cpp: Removed.
1535         * MiniBrowser/qt/qml/AlertDialog.qml: Removed.
1536         * MiniBrowser/qt/qml/AuthenticationDialog.qml: Removed.
1537         * MiniBrowser/qt/qml/BrowserWindow.qml: Removed.
1538         * MiniBrowser/qt/qml/CheckBox.qml: Removed.
1539         * MiniBrowser/qt/qml/ColorChooser.qml: Removed.
1540         * MiniBrowser/qt/qml/ConfirmDialog.qml: Removed.
1541         * MiniBrowser/qt/qml/Dialog.qml: Removed.
1542         * MiniBrowser/qt/qml/DialogButton.qml: Removed.
1543         * MiniBrowser/qt/qml/DialogLineInput.qml: Removed.
1544         * MiniBrowser/qt/qml/FilePicker.qml: Removed.
1545         * MiniBrowser/qt/qml/ItemSelector.qml: Removed.
1546         * MiniBrowser/qt/qml/MockTouchPoint.qml: Removed.
1547         * MiniBrowser/qt/qml/PromptDialog.qml: Removed.
1548         * MiniBrowser/qt/qml/ProxyAuthenticationDialog.qml: Removed.
1549         * MiniBrowser/qt/qml/ScrollIndicator.qml: Removed.
1550         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Removed.
1551         * MiniBrowser/qt/raw/DerivedSources.pri: Removed.
1552         * MiniBrowser/qt/raw/MiniBrowserRaw.pro: Removed.
1553         * MiniBrowser/qt/raw/Target.pri: Removed.
1554         * MiniBrowser/qt/raw/View.cpp: Removed.
1555         * MiniBrowser/qt/raw/View.h: Removed.
1556         * MiniBrowser/qt/utils.cpp: Removed.
1557         * MiniBrowser/qt/utils.h: Removed.
1558         * QtTestBrowser/QtTestBrowser.pro: Removed.
1559         * QtTestBrowser/QtTestBrowser.qrc: Removed.
1560         * QtTestBrowser/cookiejar.cpp: Removed.
1561         * QtTestBrowser/cookiejar.h: Removed.
1562         * QtTestBrowser/favicon.png: Removed.
1563         * QtTestBrowser/fpstimer.cpp: Removed.
1564         * QtTestBrowser/fpstimer.h: Removed.
1565         * QtTestBrowser/launcherwindow.cpp: Removed.
1566         * QtTestBrowser/launcherwindow.h: Removed.
1567         * QtTestBrowser/locationedit.cpp: Removed.
1568         * QtTestBrowser/locationedit.h: Removed.
1569         * QtTestBrowser/mainwindow.cpp: Removed.
1570         * QtTestBrowser/mainwindow.h: Removed.
1571         * QtTestBrowser/qttestbrowser.cpp: Removed.
1572         * QtTestBrowser/urlloader.cpp: Removed.
1573         * QtTestBrowser/urlloader.h: Removed.
1574         * QtTestBrowser/useragentlist.txt: Removed.
1575         * QtTestBrowser/utils.cpp: Removed.
1576         * QtTestBrowser/utils.h: Removed.
1577         * QtTestBrowser/webinspector.h: Removed.
1578         * QtTestBrowser/webpage.cpp: Removed.
1579         * QtTestBrowser/webpage.h: Removed.
1580         * QtTestBrowser/webview.cpp: Removed.
1581         * QtTestBrowser/webview.h: Removed.
1582         * TestWebKitAPI/DerivedSources.pri: Removed.
1583         * TestWebKitAPI/InjectedBundle.pri: Removed.
1584         * TestWebKitAPI/PlatformWebView.h:
1585         * TestWebKitAPI/TestWebKitAPI.pri: Removed.
1586         * TestWebKitAPI/TestWebKitAPI.pro: Removed.
1587         * TestWebKitAPI/Tests.pri: Removed.
1588         * TestWebKitAPI/Tests/JavaScriptCore/JavaScriptCore.pro: Removed.
1589         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
1590         * TestWebKitAPI/Tests/WTF/WTF.pro: Removed.
1591         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro: Removed.
1592         * TestWebKitAPI/qt/InjectedBundleControllerQt.cpp: Removed.
1593         * TestWebKitAPI/qt/PlatformUtilitiesQt.cpp: Removed.
1594         * TestWebKitAPI/qt/PlatformWebViewQt.cpp: Removed.
1595         * TestWebKitAPI/qt/main.cpp: Removed.
1596         * Tools.pro: Removed.
1597         * WebKitTestRunner/DerivedSources.pri: Removed.
1598         * WebKitTestRunner/EventSenderProxy.h:
1599         * WebKitTestRunner/InjectedBundle/DerivedSources.pri: Removed.
1600         * WebKitTestRunner/InjectedBundle/InjectedBundle.pro: Removed.
1601         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1602         (WTR::InjectedBundlePage::resetAfterTest):
1603         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
1604         (WTR::InjectedBundlePage::didClearWindowForFrame):
1605         * WebKitTestRunner/InjectedBundle/Target.pri: Removed.
1606         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1607         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: Removed.
1608         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp: Removed.
1609         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp: Removed.
1610         * WebKitTestRunner/PlatformWebView.h:
1611         * WebKitTestRunner/Target.pri: Removed.
1612         * WebKitTestRunner/TestController.cpp:
1613         (WTR::TestController::resetStateToConsistentValues):
1614         * WebKitTestRunner/TestController.h:
1615         * WebKitTestRunner/WebKitTestRunner.pro: Removed.
1616         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Removed.
1617         * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Removed.
1618         * WebKitTestRunner/qt/TestControllerQt.cpp: Removed.
1619         * WebKitTestRunner/qt/TestInvocationQt.cpp: Removed.
1620         * WebKitTestRunner/qt/WebKitTestRunner.qrc: Removed.
1621         * WebKitTestRunner/qt/main.cpp: Removed.
1622         * WebKitTestRunner/qt/resources/user.css: Removed.
1623         * qmake/.qmake.cache: Removed.
1624         * qmake/.qmake.conf: Removed.
1625         * qmake/README: Removed.
1626         * qmake/config.tests/README: Removed.
1627         * qmake/config.tests/fontconfig/fontconfig.cpp: Removed.
1628         * qmake/config.tests/fontconfig/fontconfig.pro: Removed.
1629         * qmake/config.tests/gccdepends/empty.cpp: Removed.
1630         * qmake/config.tests/gccdepends/gccdepends.pro: Removed.
1631         * qmake/config.tests/glx/glx.cpp: Removed.
1632         * qmake/config.tests/glx/glx.pro: Removed.
1633         * qmake/config.tests/gnuld/gnuld.pro: Removed.
1634         * qmake/config.tests/gnuld/main.cpp: Removed.
1635         * qmake/config.tests/libXcomposite/libXcomposite.cpp: Removed.
1636         * qmake/config.tests/libXcomposite/libXcomposite.pro: Removed.
1637         * qmake/config.tests/libXrender/libXrender.cpp: Removed.
1638         * qmake/config.tests/libXrender/libXrender.pro: Removed.
1639         * qmake/config.tests/libwebp/libwebp.cpp: Removed.
1640         * qmake/config.tests/libwebp/libwebp.pro: Removed.
1641         * qmake/config.tests/libxml2/libxml2.cpp: Removed.
1642         * qmake/config.tests/libxml2/libxml2.pro: Removed.
1643         * qmake/config.tests/libxslt/libxslt.cpp: Removed.
1644         * qmake/config.tests/libxslt/libxslt.pro: Removed.
1645         * qmake/config.tests/libzlib/libzlib.cpp: Removed.
1646         * qmake/config.tests/libzlib/libzlib.pro: Removed.
1647         * qmake/dump-features.pl: Removed.
1648         * qmake/mkspecs/features/configure.prf: Removed.
1649         * qmake/mkspecs/features/default_post.prf: Removed.
1650         * qmake/mkspecs/features/default_pre.prf: Removed.
1651         * qmake/mkspecs/features/features.prf: Removed.
1652         * qmake/mkspecs/features/features.pri: Removed.
1653         * qmake/mkspecs/features/force_static_libs_as_shared.prf: Removed.
1654         * qmake/mkspecs/features/functions.prf: Removed.
1655         * qmake/mkspecs/features/gprof.prf: Removed.
1656         * qmake/mkspecs/features/mac/default_post.prf: Removed.
1657         * qmake/mkspecs/features/mac/default_pre.prf: Removed.
1658         * qmake/mkspecs/features/minimal_qt.prf: Removed.
1659         * qmake/mkspecs/features/production_build.prf: Removed.
1660         * qmake/mkspecs/features/rpath.prf: Removed.
1661         * qmake/mkspecs/features/unix/default_post.prf: Removed.
1662         * qmake/mkspecs/features/unix/default_pre.prf: Removed.
1663         * qmake/mkspecs/features/unix/icc.prf: Removed.
1664         * qmake/mkspecs/features/use_all_in_one_files.prf: Removed.
1665         * qmake/mkspecs/features/valgrind.prf: Removed.
1666         * qmake/mkspecs/features/webkit_modules.prf: Removed.
1667         * qmake/mkspecs/features/win32/default_post.prf: Removed.
1668         * qmake/mkspecs/features/win32/default_pre.prf: Removed.
1669         * qmake/mkspecs/modules/angle.prf: Removed.
1670         * qmake/mkspecs/modules/javascriptcore.prf: Removed.
1671         * qmake/mkspecs/modules/webcore.prf: Removed.
1672         * qmake/mkspecs/modules/webkit1.prf: Removed.
1673         * qmake/mkspecs/modules/webkit2.prf: Removed.
1674         * qmake/mkspecs/modules/wtf.prf: Removed.
1675
1676 2013-10-02  Tim Horton  <timothy_horton@apple.com>
1677
1678         [mac] Stop using DrawingAreaImpl on PLATFORM(MAC) 
1679         https://bugs.webkit.org/show_bug.cgi?id=121859
1680         <rdar://problem/15069359>
1681
1682         Reviewed by Anders Carlsson.
1683
1684         * WebKitTestRunner/TestInvocation.cpp:
1685         (WTR::shouldUseThreadedScrolling):
1686         (WTR::updateThreadedScrollingForCurrentTest):
1687         (WTR::TestInvocation::invoke):
1688         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1689         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useThreadedScrolling:]):
1690         (WTR::PlatformWebView::PlatformWebView):
1691         (WTR::PlatformWebView::viewSupportsOptions):
1692         Rename the tiled drawing switch to threaded scrolling, since that's really
1693         all it switches now that we use tiled drawing everywhere.
1694
1695         Use an unbuffered window, as well, to avoid snapshotting issues on some platforms
1696         and to more closely match the case we're interested in testing.
1697
1698 2013-10-02  Anders Carlsson  <andersca@apple.com>
1699
1700         Move AHEM____.TTF from qt/fonts/ to fonts/.
1701
1702         Rubber-stamped by Andreas Kling.
1703
1704         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1705         * DumpRenderTree/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/qt/fonts/AHEM____.TTF.
1706
1707 2013-10-02  Ádám Kallai  <kadam@inf.u-szeged.hu>
1708
1709         Remove Qt bots and EWS from trunk.
1710         https://bugs.webkit.org/show_bug.cgi?id=122210.
1711
1712         Reviewed by Allan Sandfeld Jensen.
1713
1714         Remove Qt buil dbots.
1715
1716         * BuildSlaveSupport/build.webkit.org-config/config.json:
1717         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1718         (appendCustomBuildFlags):
1719         (RunGtkAPITests.getText2):
1720         (Factory.__init__):
1721         (TestFactory.__init__):
1722         (BuildAndTestFactory.__init__):
1723         (loadBuilderConfig):
1724         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1725
1726 2013-10-02  Ádám Kallai  <kadam@inf.u-szeged.hu>
1727
1728         Remove Qt bots and EWS from trunk.
1729         https://bugs.webkit.org/show_bug.cgi?id=122210.
1730
1731         Reviewed by Allan Sandfeld Jensen.
1732
1733         Remove Qt EWS bots.
1734
1735         * QueueStatusServer/config/queues.py:
1736         * Scripts/webkitpy/common/config/ews.json:
1737
1738 2013-10-01  Timothy Hatcher  <timothy@apple.com>
1739
1740         Fix singular labels for test failures.
1741
1742         https://bugs.webkit.org/show_bug.cgi?id=122200
1743
1744         Reviewed by Joseph Pecoraro.
1745
1746         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1747         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1748
1749 2013-10-01  Timothy Hatcher  <timothy@apple.com>
1750
1751         Don't keep appending iterations each time the queue updates.
1752
1753         https://bugs.webkit.org/show_bug.cgi?id=122198
1754
1755         Reviewed by Joseph Pecoraro.
1756
1757         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1758         (BuildbotQueue.prototype.update):
1759
1760 2013-10-01  Timothy Hatcher  <timothy@apple.com>
1761
1762         Properly sort iterations in the Dashboard by revision for out-of-order queues.
1763
1764         https://bugs.webkit.org/show_bug.cgi?id=122196
1765
1766         Reviewed by Brent Fulgham.
1767
1768         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1769         (BuildbotIteration):
1770         (BuildbotIteration.prototype.update):
1771         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1772         (BuildbotQueue.prototype.update):
1773         (BuildbotQueue.prototype.sortIterations):
1774
1775 2013-10-01  Timothy Hatcher  <timothy@apple.com>
1776
1777         Fix some exceptions seen in the Buildbot Dashboard when looking at unloaded iterations.
1778
1779         Also fix some URLs to not have extras slashes and add a page title.
1780
1781         https://bugs.webkit.org/show_bug.cgi?id=122192
1782
1783         Reviewed by Joseph Pecoraro.
1784
1785         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1786         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1787         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1788         (WebKitBuildbot.prototype.buildLogURLForIteration):
1789         (WebKitBuildbot.prototype.layoutTestResultsURLForIteration):
1790         (WebKitBuildbot.prototype.javascriptTestResultsURLForIteration):
1791         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1792
1793 2013-10-01  Alexey Proskuryakov  <ap@apple.com>
1794
1795         [Mac] Set NSApplication current event while sending events directly to views
1796         https://bugs.webkit.org/show_bug.cgi?id=122179
1797
1798         Reviewed by Darin Adler.
1799
1800         DumpRenderTree and WebKitTestRunner send events directly to WebHMTLView or WKView,
1801         which doesn't update [NSApp currentEvent]. But there are many places in WebKit that
1802         use the current event.
1803
1804         * DumpRenderTree/mac/EventSendingController.mm:
1805         (-[EventSendingController mouseDown:withModifiers:]):
1806         (-[EventSendingController mouseUp:withModifiers:]):
1807         (-[EventSendingController mouseMoveToX:Y:]):
1808         (-[EventSendingController mouseScrollByX:andY:continuously:]):
1809         (-[EventSendingController contextClick]):
1810         (-[EventSendingController keyDown:withModifiers:withLocation:]):
1811         * WebKitTestRunner/mac/EventSenderProxy.mm:
1812         (WTR::EventSenderProxy::mouseDown):
1813         (WTR::EventSenderProxy::mouseUp):
1814         (WTR::EventSenderProxy::mouseMoveTo):
1815         (WTR::EventSenderProxy::keyDown):
1816         (WTR::EventSenderProxy::mouseScrollBy):
1817         Update the current event. We were already using the SPI in WebKit.
1818
1819 2013-10-01  Joseph Pecoraro  <pecoraro@apple.com>
1820
1821         Buildbot Dashboard: Fix JSHint issue: 'perlTestResults' used out of scope.
1822         https://bugs.webkit.org/show_bug.cgi?id=122183
1823
1824         Reviewed by Timothy Hatcher.
1825
1826         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1827         (BuildbotIteration.prototype.update):
1828
1829 2013-10-01  Timothy Hatcher  <timothy@apple.com>
1830
1831         Tweaks to the Buildbot Dashboard
1832
1833         https://bugs.webkit.org/show_bug.cgi?id=122169
1834
1835         Reviewed by Alexey Proskuryakov.
1836
1837         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1838         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
1839         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1840         (BuildbotQueueView.prototype.revisionLinksForIteration):
1841         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1842         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1843         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Added.
1844         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1845         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1846         (WebKitBuildbot.prototype.buildLogURLForIteration):
1847         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1848
1849 2013-10-01  Commit Queue  <commit-queue@webkit.org>
1850
1851         Unreviewed, rolling out r156725.
1852         http://trac.webkit.org/changeset/156725
1853         https://bugs.webkit.org/show_bug.cgi?id=122176
1854
1855         broke all the mismatch tests again (Requested by thorton on
1856         #webkit).
1857
1858         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1859         (WTR::PlatformWebView::PlatformWebView):
1860
1861 2013-10-01  Alex Christensen  <achristensen@webkit.org>
1862
1863         Implemented createWebViewWithRequest in WinLauncher.
1864         https://bugs.webkit.org/show_bug.cgi?id=122069
1865
1866         Reviewed by Brent Fulgham.
1867
1868         * WinLauncher/PrintWebUIDelegate.cpp:
1869         (PrintWebUIDelegate::createWebViewWithRequest): Added.
1870         * WinLauncher/PrintWebUIDelegate.h:
1871         Removed createWebViewWithRequest stub.
1872
1873 2013-10-01  Tim Horton  <timothy_horton@apple.com>
1874
1875         [wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
1876         https://bugs.webkit.org/show_bug.cgi?id=122006
1877         <rdar://problem/15095197>
1878
1879         Reviewed by Dean Jackson.
1880
1881         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1882         (WTR::PlatformWebView::PlatformWebView):
1883         Layer-back the root view in WebKitTestRunner's window, to work around a bug
1884         where the window server snapshot API returns blank snapshots.
1885
1886         Re-landing after r156724, this should not break everything now.
1887
1888 2013-10-01  Tim Horton  <timothy_horton@apple.com>
1889
1890         [mac] 1x emulation on Retina hardware shouldn't use SPI
1891         https://bugs.webkit.org/show_bug.cgi?id=122152
1892         <rdar://problem/15119384>
1893
1894         Reviewed by Anders Carlsson.
1895
1896         * DumpRenderTree/mac/DumpRenderTree.mm:
1897         (createWebViewAndOffscreenWindow):
1898         (main):
1899         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1900         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1901         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1902         (WTR::PlatformWebView::PlatformWebView):
1903         * WebKitTestRunner/mac/main.mm:
1904         (main):
1905         Register for AppleMagnifiedMode instead of using _setWindowResolution:displayIfChanged:.
1906
1907 2013-09-30  Sam Weinig  <sam@webkit.org>
1908
1909         check-webkit-style should not warn about use of C++11 “>>”  instead of “> >"
1910         https://bugs.webkit.org/show_bug.cgi?id=116474
1911
1912         Reviewed by Ryosuke Niwa.
1913
1914         * Scripts/webkitpy/style/checkers/cpp.py:
1915         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1916
1917 2013-09-30  Sam Weinig  <sam@webkit.org>
1918
1919         Remove support for DOMFileSystem
1920         https://bugs.webkit.org/show_bug.cgi?id=122137
1921
1922         Reviewed by Anders Carlsson.
1923
1924         * Scripts/webkitperl/FeatureList.pm:
1925         * Scripts/webkitpy/style/checkers/cpp.py:
1926         (check_spacing):
1927         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1928         (CppStyleTest.test_spacing_for_binary_ops):
1929         * qmake/mkspecs/features/features.pri:
1930
1931 2013-09-30  Mark Rowe  <mrowe@apple.com>
1932
1933         More build fixage for builds with SDKs.
1934
1935         * WebKitTestRunner/Configurations/Base.xcconfig:
1936         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
1937
1938 2013-09-30  Timothy Hatcher  <timothy@apple.com>
1939
1940         Add initial version of a new Buildbot dashboard view.
1941
1942         https://bugs.webkit.org/show_bug.cgi?id=122131
1943
1944         Reviewed by Alexey Proskuryakov.
1945
1946         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Added.
1947         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Added.
1948         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png: Added.
1949         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks@2x.png: Added.
1950         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Added.
1951         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Added.
1952         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing.png: Added.
1953         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing@2x.png: Added.
1954         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7.png: Added.
1955         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7@2x.png: Added.
1956         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8.png: Added.
1957         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8@2x.png: Added.
1958         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP.png: Added.
1959         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP@2x.png: Added.
1960         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BaseObject.js: Added.
1961         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js: Added.
1962         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js: Added.
1963         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Added.
1964         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: Added.
1965         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: Added.
1966         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js: Added.
1967         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: Added.
1968         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Added.
1969         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js: Added.
1970         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js: Added.
1971         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: Added.
1972         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotBuilderQueueView.css: Added.
1973         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css: Added.
1974         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotTesterQueueView.css: Added.
1975         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Added.
1976         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css: Added.
1977         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added.
1978
1979 2013-09-30  Benjamin Poulain  <benjamin@webkit.org>
1980
1981         Remove the code guarded by STYLE_SCOPED
1982         https://bugs.webkit.org/show_bug.cgi?id=122123
1983
1984         Reviewed by Anders Carlsson.
1985
1986         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1987         (resetDefaultsToConsistentValues):
1988         * Scripts/webkitperl/FeatureList.pm:
1989         * qmake/mkspecs/features/features.pri:
1990
1991 2013-09-30  Mark Rowe  <mrowe@apple.com>
1992
1993         Fix the build when building against an SDK.
1994
1995         Xcode helpfully prepends $(SDKROOT) to the paths in FRAMEWORK_SEARCH_PATHS when generating
1996         the compiler command lines. It can't know to do this for the system framework search paths
1997         we add manually via OTHER_CFLAGS though, so we need to prefix them with $(SDKROOT) ourself.
1998
1999         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
2000         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
2001
2002 2013-09-30  Brent Fulgham  <bfulgham@apple.com>
2003
2004         [Windows] Unreviewed test fix. Prevent crash when changing URL paths during testing.
2005
2006         A shared BSTR value (_bstr_t) was being reallocated outside the smart pointer, causing
2007         it to be double-freed.
2008
2009         * WinLauncher/WinLauncher.cpp:
2010         (EditProc): Be explicit about type passed to loadURL.
2011         (loadURL): Create a shallow copy of the BSTR so we only allocate memory if needed. Use _bstr_t so
2012         that reallocating the BSTR is done with the knowledge of the smart pointer.
2013
2014 2013-09-30  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2015
2016         [Qt] Fix force_static_libs_as_shared in WebKit2
2017         https://bugs.webkit.org/show_bug.cgi?id=121961
2018
2019         Reviewed by Csaba Osztrogonác.
2020
2021         Get rid of the unused WebKit2QML library
2022
2023         * qmake/mkspecs/features/webkit_modules.prf:
2024         * qmake/mkspecs/modules/webkit2qml.prf: Removed.
2025
2026 2013-09-30  Krzysztof Wolanski  <k.wolanski@samsung.com>
2027
2028         [EFL] Fix incorrect click counting in EventSenderProxy
2029         https://bugs.webkit.org/show_bug.cgi?id=122098
2030
2031         Reviewed by Gyuyoung Kim.
2032
2033         Previously used two types of recording time, which conflicted with each other.
2034
2035         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2036         (WTR::EventSenderProxy::mouseUp):
2037
2038 2013-09-30  Zan Dobersek  <zdobersek@igalia.com>
2039
2040         [webkitpy] Make the Xvfb screen depth overridable
2041         https://bugs.webkit.org/show_bug.cgi?id=122089
2042
2043         Reviewed by Gyuyoung Kim.
2044
2045         Make the Xvfb screen depth overridable by checking if the XVFB_SCREEN_DEPTH environment variable
2046         was set. The default value that's used if the variable wasn't set is 24.
2047
2048         * Scripts/webkitpy/port/xvfbdriver.py:
2049         (XvfbDriver._xvfb_screen_depth):
2050         (XvfbDriver._start):
2051         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
2052         (XvfbDriverTest.make_driver):
2053         (XvfbDriverTest.test_start_no_pixel_tests):
2054         (XvfbDriverTest.test_start_pixel_tests):
2055         (XvfbDriverTest.test_start_arbitrary_worker_number):
2056         (XvfbDriverTest.test_next_free_display):
2057         (XvfbDriverTest.test_start_next_worker):
2058
2059 2013-09-29  Mark Rowe  <mrowe@apple.com>
2060
2061         Fix the Lion build.
2062
2063         Ensure that C++ and Objective-C++ files build with the right compiler flags.
2064
2065         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
2066         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
2067
2068 2013-09-28  Mark Rowe  <mrowe@apple.com>
2069
2070         Fix some failures with newer versions of clang.
2071
2072         Some CoreGraphics headers generate warnings under newer versions of clang. Since they're system headers the warnings would
2073         usually be suppressed, but we're adding the frameworks to the non-system framework search path so they're no longer treated
2074         as system headers. We address this by removing the system paths from FRAMEWORK_SEARCH_PATHS and using the -iframework compiler
2075         flag in OTHER_CFLAGS to add the paths to the system framework search path. We have to set OTHER_CFLAGS at the target level
2076         in order for it to coexist with the ASAN-related OTHER_CFLAGS that's set in DebugRelease.xcconfig.
2077
2078         Reviewed by Dan Bernstein.
2079
2080         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2081         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
2082         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2083         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2084         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
2085         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
2086         * WebKitTestRunner/Configurations/Base.xcconfig:
2087         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
2088         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2089         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2090         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2091
2092 2013-09-27  Commit Queue  <commit-queue@webkit.org>
2093
2094         Unreviewed, rolling out r156569.
2095         http://trac.webkit.org/changeset/156569
2096         https://bugs.webkit.org/show_bug.cgi?id=122035
2097
2098         broke a lot of mismatch tests (Requested by thorton on
2099         #webkit).
2100
2101         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2102         (WTR::PlatformWebView::PlatformWebView):
2103
2104 2013-09-27  Alexey Proskuryakov  <ap@apple.com>
2105
2106         Don't retry failures on Apple MountainLion Release WK1 tester
2107         https://bugs.webkit.org/show_bug.cgi?id=122026
2108
2109         Reviewed by Mark Rowe.
2110
2111         * BuildSlaveSupport/build.webkit.org-config/config.json: Added --no-retry-failures
2112         on this bot.
2113
2114 2013-09-27  Alexey Proskuryakov  <ap@apple.com>
2115
2116         Don't hardcode builder specific configuration in buildbot master.cfg
2117         https://bugs.webkit.org/show_bug.cgi?id=122023
2118
2119         Reviewed by Mark Rowe.
2120
2121         * BuildSlaveSupport/build.webkit.org-config/config.json: Added an additionalArguments
2122         property to Qt Mountain Lion Release, making it run pixel tests.
2123
2124         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2125         (RunWebKitTests.start): Use additionalArguments.
2126         (RunWebKit2Tests.start): Don't hardcode individual bot behavior here.
2127
2128 2013-09-27  Tim Horton  <timothy_horton@apple.com>
2129
2130         [wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
2131         https://bugs.webkit.org/show_bug.cgi?id=122006
2132         <rdar://problem/15095197>
2133
2134         Reviewed by Dean Jackson.
2135
2136         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2137         (WTR::PlatformWebView::PlatformWebView):
2138         Layer-back the root view in WebKitTestRunner's window, to work around a bug
2139         where the window server snapshot API returns blank snapshots.
2140
2141 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
2142
2143         [GTK] GTK does not expose heading level correctly. Was: accessibility/heading-level.html is failing
2144         https://bugs.webkit.org/show_bug.cgi?id=106924
2145
2146         Reviewed by Chris Fleizach.
2147
2148         Consider headings levels as values to be returned in intValue()
2149         both in DRT and WKTR, so we can share more tests with other ports.
2150
2151         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2152         (AccessibilityUIElement::intValue): Consider headings too.
2153         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2154         (WTR::AccessibilityUIElement::intValue): Ditto.
2155
2156 2013-09-26  Darin Adler  <darin@apple.com>
2157
2158         rename KURL to URL
2159         https://bugs.webkit.org/show_bug.cgi?id=16214
2160
2161         Reviewed by Andreas Kling.
2162
2163         * many files: Renamed, using script.
2164
2165 2013-09-27  Darin Adler  <darin@apple.com>
2166
2167         Fix Python scripts test failures.
2168
2169         * Scripts/webkitpy/style/checkers/cpp.py:
2170         (_FunctionState.modifiers_and_return_type): Added this back. Used only by tests
2171         now, not by the checker itself.
2172
2173 2013-09-27  Denis Nomiyama  <d.nomiyama@samsung.com>
2174
2175         [GTK][WK2] Logging of accessibility events is not disabled between tests
2176         https://bugs.webkit.org/show_bug.cgi?id=121957
2177
2178         Reviewed by Mario Sanchez Prada.
2179
2180         Fixed an issue in AccessibilityNotificationHandler where the destructor
2181         was not disconnecting accessibility event callbacks if logging was on.
2182         The decision of disconnecting events can solely rely on the existence of
2183         notification handlers because logging uses the global notification
2184         handler.
2185
2186         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2187         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks): Fixed
2188         disconnection when logging is on.
2189
2190 2013-09-27  Patrick Gansterer  <paroga@webkit.org>
2191
2192         Add general CMakeLists.txt for DRT
2193         https://bugs.webkit.org/show_bug.cgi?id=119268
2194
2195         Reviewed by Gyuyoung Kim.
2196
2197         The new file allows better sharing between ports.
2198
2199         * CMakeLists.txt:
2200         * DumpRenderTree/CMakeLists.txt: Added.
2201         * DumpRenderTree/PlatformEfl.cmake: Added.
2202         * DumpRenderTree/efl/CMakeLists.txt: Removed.
2203
2204 2013-09-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2205
2206         [Qt] Fix force_static_libs_as_shared in WebKit2
2207         https://bugs.webkit.org/show_bug.cgi?id=121961
2208
2209         Reviewed by Csaba Osztrogonác.
2210
2211         Reenable force_static_libs_as_shared when building WebKit2.
2212
2213         * qmake/mkspecs/features/default_post.prf:
2214
2215 2013-09-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2216
2217         [Qt] Mock implementations of positioning and orientation not used
2218         https://bugs.webkit.org/show_bug.cgi?id=121956
2219
2220         Reviewed by Csaba Osztrogonác.
2221
2222         Move production_build checks to sanitizeFeatures where its value is actually known.
2223
2224         * qmake/mkspecs/features/features.prf:
2225         * qmake/mkspecs/features/features.pri:
2226
2227 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
2228
2229         [ATK] Normalize checks in entry points for DRT and WKTR
2230         https://bugs.webkit.org/show_bug.cgi?id=121959
2231
2232         Reviewed by Chris Fleizach.
2233
2234         Always check if we have a proper instance of AtkObject,
2235         implementing the interfaces that we might need for each case, at
2236         the entry point of every method of AccessibilityUIElement for ATK,
2237         and do those checks in an uniform way across DRT and WKTR, to
2238         avoid confusion and issues when modifying these files in the future.
2239
2240         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2241         (AccessibilityUIElement::getChildren): Use normalized checks.
2242         (AccessibilityUIElement::getChildrenWithRange): Ditto.
2243         (AccessibilityUIElement::rowCount): Ditto.
2244         (AccessibilityUIElement::columnCount): Ditto.
2245         (AccessibilityUIElement::childrenCount): Ditto.
2246         (AccessibilityUIElement::elementAtPoint): Ditto.
2247         (AccessibilityUIElement::getChildAtIndex): Ditto.
2248         (AccessibilityUIElement::allAttributes): Ditto.
2249         (AccessibilityUIElement::titleUIElement): Ditto.
2250         (AccessibilityUIElement::parentElement): Ditto.
2251         (AccessibilityUIElement::attributesOfChildren): Ditto.
2252         (AccessibilityUIElement::role): Ditto.
2253         (AccessibilityUIElement::title): Ditto.
2254         (AccessibilityUIElement::description): Ditto.
2255         (AccessibilityUIElement::stringValue): Ditto.
2256         (AccessibilityUIElement::language): Ditto.
2257         (AccessibilityUIElement::x): Ditto.
2258         (AccessibilityUIElement::y): Ditto.
2259         (AccessibilityUIElement::width): Ditto.
2260         (AccessibilityUIElement::height): Ditto.
2261         (AccessibilityUIElement::orientation): Ditto.
2262         (AccessibilityUIElement::intValue): Ditto.
2263         (AccessibilityUIElement::minValue): Ditto.
2264         (AccessibilityUIElement::maxValue): Ditto.
2265         (indexRangeInTable): Ditto.
2266         (AccessibilityUIElement::cellForColumnAndRow): Ditto.
2267         (AccessibilityUIElement::stringAttributeValue): Ditto.
2268         (alterCurrentValue): Ditto.
2269         (AccessibilityUIElement::press): Ditto.
2270         (AccessibilityUIElement::documentEncoding): Ditto.
2271         (AccessibilityUIElement::documentURI): Ditto.
2272         (AccessibilityUIElement::hasPopup): Ditto.
2273
2274         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2275         (WTR::indexRangeInTable): Use normalized checks.
2276         (WTR::alterCurrentValue): Ditto.
2277         (WTR::AccessibilityUIElement::getChildren): Ditto.
2278         (WTR::AccessibilityUIElement::getChildrenWithRange): Ditto.
2279         (WTR::AccessibilityUIElement::childrenCount): Ditto.
2280         (WTR::AccessibilityUIElement::elementAtPoint): Ditto.
2281         (WTR::AccessibilityUIElement::indexOfChild): Ditto.
2282         (WTR::AccessibilityUIElement::childAtIndex): Ditto.
2283         (WTR::AccessibilityUIElement::titleUIElement): Ditto.
2284         (WTR::AccessibilityUIElement::parentElement): Ditto.
2285         (WTR::AccessibilityUIElement::attributesOfChildren): Ditto.
2286         (WTR::AccessibilityUIElement::allAttributes): Ditto.
2287         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
2288         (WTR::AccessibilityUIElement::role): Ditto.
2289         (WTR::AccessibilityUIElement::title): Ditto.
2290         (WTR::AccessibilityUIElement::description): Ditto.
2291         (WTR::AccessibilityUIElement::orientation): Ditto.
2292         (WTR::AccessibilityUIElement::stringValue): Ditto.
2293         (WTR::AccessibilityUIElement::language): Ditto.
2294         (WTR::AccessibilityUIElement::x): Ditto.
2295         (WTR::AccessibilityUIElement::y): Ditto.
2296         (WTR::AccessibilityUIElement::width): Ditto.
2297         (WTR::AccessibilityUIElement::height): Ditto.
2298         (WTR::AccessibilityUIElement::intValue): Ditto.
2299         (WTR::AccessibilityUIElement::minValue): Ditto.
2300         (WTR::AccessibilityUIElement::maxValue): Ditto.
2301         (WTR::AccessibilityUIElement::rowCount): Ditto.
2302         (WTR::AccessibilityUIElement::columnCount): Ditto.
2303         (WTR::AccessibilityUIElement::cellForColumnAndRow): Ditto.
2304         (WTR::AccessibilityUIElement::press): Ditto.
2305         (WTR::AccessibilityUIElement::documentEncoding): Ditto.
2306         (WTR::AccessibilityUIElement::documentURI): Ditto.
2307         (WTR::AccessibilityUIElement::hasPopup): Ditto.
2308
2309 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
2310
2311         [ATK] accessibility/aria-sort.html is failing after r156409
2312         https://bugs.webkit.org/show_bug.cgi?id=121947
2313
2314         Reviewed by Chris Fleizach.
2315
2316         Implement AccessibilityUIElement::isSupported for the ATK
2317         platforms, just by checking whether we have an associated object
2318         attribute exposed for the wrapper object matching the required
2319         attribute in the layout test (e.g "AXSortDirection" -> "sort").
2320
2321         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2322         (AccessibilityUIElement::isAttributeSupported): Implemented.
2323         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2324         (WTR::AccessibilityUIElement::isAttributeSupported): Implemented.
2325
2326 2013-09-26  Eric Carlson  <eric.carlson@apple.com>
2327
2328         [MediaStream] make MediaStream testable
2329         https://bugs.webkit.org/show_bug.cgi?id=121967
2330
2331         Reviewed by Dean Jackson.
2332
2333         * DumpRenderTree/mac/UIDelegate.mm:
2334         (-[UIDelegate webView:decidePolicyForUserMediaRequestFromOrigin:listener:]): Add a very permissive
2335             user media request policy delegate.
2336
2337 2013-09-26  Brian J. Burg  <burg@cs.washington.edu>
2338
2339         build-webkit --inspector-frontend should copy WebInspectorUI files
2340         https://bugs.webkit.org/show_bug.cgi?id=117851
2341
2342         Reviewed by Joseph Pecoraro.
2343
2344         Change the --inspector-frontend build option to additionally build/copy 
2345         WebInspectorUI by setting it as the only project that needs to be built.
2346
2347         * Scripts/build-webkit:
2348
2349 2013-09-26  Zan Dobersek  <zdobersek@igalia.com>
2350
2351         XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
2352         https://bugs.webkit.org/show_bug.cgi?id=121951
2353
2354         Reviewed by Carlos Garcia Campos.
2355
2356         Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
2357         software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
2358         500 layout tests that trigger accelerated compositing to be used.
2359
2360         * Scripts/webkitpy/port/xvfbdriver.py:
2361         (XvfbDriver._start):
2362         * Scripts/webkitpy/port/xvfbdriver_unittest.py: Update unit test baselines.
2363         (XvfbDriverTest.test_start_no_pixel_tests):
2364         (XvfbDriverTest.test_start_pixel_tests):
2365         (XvfbDriverTest.test_start_arbitrary_worker_number):
2366         (XvfbDriverTest.test_next_free_display):
2367         (XvfbDriverTest.test_start_next_worker):
2368
2369 2013-09-26  Tim Horton  <timothy_horton@apple.com>
2370
2371         Tiled drawing should not imply threaded scrolling
2372         https://bugs.webkit.org/show_bug.cgi?id=121874
2373         <rdar://problem/15071494>
2374
2375         Reviewed by Sam Weinig.
2376
2377         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2378         (WTR::PlatformWebView::PlatformWebView):
2379         The existing tiled-drawing layout tests require threaded scrolling to be enabled.
2380
2381 2013-09-26  Commit Queue  <commit-queue@webkit.org>
2382
2383         Unreviewed, rolling out r156457.
2384         http://trac.webkit.org/changeset/156457
2385         https://bugs.webkit.org/show_bug.cgi?id=121960
2386
2387         Broke webkitpy tests. (Requested by kling on #webkit).
2388
2389         * Scripts/webkitpy/port/xvfbdriver.py:
2390         (XvfbDriver._start):
2391
2392 2013-09-26  Zan Dobersek  <zdobersek@igalia.com>
2393
2394         XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
2395         https://bugs.webkit.org/show_bug.cgi?id=121951
2396
2397         Reviewed by Carlos Garcia Campos.
2398
2399         Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
2400         software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
2401         500 layout tests that trigger accelerated compositing to be used.
2402
2403         * Scripts/webkitpy/port/xvfbdriver.py:
2404         (XvfbDriver._start):
2405
2406 2013-09-25  Alex Christensen  <achristensen@webkit.org>
2407
2408         Removed check for Apple Application Support directory in WinCairo port.
2409         https://bugs.webkit.org/show_bug.cgi?id=121869
2410
2411         Reviewed by Brent Fulgham.
2412
2413         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2414         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2415         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2416         Use DLLLauncherWinCairo.props for WinCairo ports.
2417         * win/DLLLauncher/DLLLauncherMain.cpp:
2418         (wWinMain):
2419         Don't call modifyPath to check for AAS in the WinCairo port.
2420         * win/DLLLauncher/DLLLauncherWinCairo.props: Added to define WIN_CAIRO.
2421
2422 2013-09-25  Alex Christensen  <achristensen@webkit.org>
2423
2424         Enabled AssembleBuildLogs on WinCairo port.
2425         https://bugs.webkit.org/show_bug.cgi?id=121923
2426
2427         Reviewed by Brent Fulgham.
2428
2429         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
2430         Fixed reference to README, added WinCairo configurations.
2431         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters:
2432         Fixed reference to README.
2433         * win/AssembleBuildLogs/AssembleLogs.cmd:
2434         Added ANGLE projects, skipped QTMovieWin for WinCairo, use PlatformArchitecture for Win64.
2435         * win/AssembleBuildLogs/README: Fixed spelling.
2436
2437 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
2438
2439         [WIN] Fix MSVC C4146 compiler warning
2440         https://bugs.webkit.org/show_bug.cgi?id=121838
2441
2442         Reviewed by Brent Fulgham.
2443
2444         Fix some variables from unsinged to int to fix the compiler warning
2445         "unary minus operator applied to unsigned type, result still unsigned".
2446
2447         * DumpRenderTree/WorkQueueItem.h:
2448         (BackItem::BackItem):
2449         (ForwardItem::ForwardItem):
2450         * DumpRenderTree/win/DumpRenderTree.cpp:
2451         (createWebViewAndOffscreenWindow):
2452
2453 2013-09-25  Zan Dobersek  <zdobersek@igalia.com>
2454
2455         [GTK] Switch the 64-bit Release builder to testing layout tests under WK2
2456         https://bugs.webkit.org/show_bug.cgi?id=121256
2457
2458         Reviewed by Martin Robinson.
2459
2460         Switch the GTK 64-bit Release builder to testing the layout tests under WebKit2.
2461         The GTK 64-bit Release WK2 testing builder is switched to now run layout tests under WebKit1.
2462
2463         * BuildSlaveSupport/build.webkit.org-config/config.json:
2464
2465 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
2466
2467         Add style checker for CMake lists
2468         https://bugs.webkit.org/show_bug.cgi?id=121764
2469
2470         Reviewed by Ryosuke Niwa.
2471
2472         Add an additional check to make sure that list of files are sorted.
2473         Exclude lists of include directories for now, since the order
2474         can be importent for compilation of some files.
2475
2476         * Scripts/webkitpy/style/checkers/cmake.py:
2477         (CMakeChecker.check):
2478         (CMakeChecker._check_indent):
2479         (CMakeChecker):
2480         (CMakeChecker._check_list_order):
2481         (CMakeChecker._list_item_path):
2482         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
2483         (CMakeCheckerTest.test_check):
2484
2485 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
2486
2487         CMakeChecker takes unusually long time to run
2488         https://bugs.webkit.org/show_bug.cgi?id=105662
2489
2490         Reviewed by Ryosuke Niwa.
2491
2492         Move the caching mechanism for regular expression of the C++ checker into
2493         a common file and use it for the CMake and ChangeLog checkers too.
2494
2495         * Scripts/webkitpy/style/checkers/changelog.py:
2496         (ChangeLogChecker.check_entry):
2497         * Scripts/webkitpy/style/checkers/cmake.py:
2498         (CMakeChecker._process_line):
2499         (CMakeChecker._check_no_space_cmds):
2500         (CMakeChecker._check_one_space_cmds):
2501         (CMakeChecker._check_non_lowercase_cmd):
2502         * Scripts/webkitpy/style/checkers/common.py:
2503         (match):
2504         (search):
2505         (searchIgnorecase):
2506         (sub):
2507         (subn):
2508         * Scripts/webkitpy/style/checkers/cpp.py:
2509
2510 2013-09-25  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2511
2512         [Qt] Fix build with Qt 5.2 QtPosition module
2513         https://bugs.webkit.org/show_bug.cgi?id=121089
2514
2515         Reviewed by Simon Hausmann.
2516
2517         QtLocation -> QtPositioning. Make sure we set build type before doing configure checks
2518         that might depend on them.
2519
2520         * qmake/mkspecs/features/default_pre.prf:
2521         * qmake/mkspecs/features/features.prf:
2522
2523 2013-09-25  Mario Sanchez Prada  <mario.prada@samsung.com>
2524
2525         [ATK] Fix style issues in AccessibilityUIElementAtk
2526         https://bugs.webkit.org/show_bug.cgi?id=121898
2527
2528         Reviewed by Chris Fleizach.
2529
2530         Avoid the '.f' suffix for float literals and use G_VALUE_INIT
2531         instead of { 0, { { 0 } } } to initialize a GValue.
2532
2533         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2534         (AccessibilityUIElement::clickPointX): Remove suffix.
2535         (AccessibilityUIElement::clickPointY): Ditto.
2536         (AccessibilityUIElement::intValue): Use G_VALUE_INIT and remove suffix.
2537         (AccessibilityUIElement::minValue): Ditto.
2538         (AccessibilityUIElement::maxValue): Ditto.
2539         (AccessibilityUIElement::numberAttributeValue): Remove suffix.
2540         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2541         (WTR::AccessibilityUIElement::numberAttributeValue): Remove suffix.
2542         (WTR::AccessibilityUIElement::x): Ditto.
2543         (WTR::AccessibilityUIElement::y): Ditto.
2544         (WTR::AccessibilityUIElement::width): Ditto.
2545         (WTR::AccessibilityUIElement::height): Ditto.
2546         (WTR::AccessibilityUIElement::clickPointX): Ditto.
2547         (WTR::AccessibilityUIElement::clickPointY): Ditto.
2548         (WTR::AccessibilityUIElement::intValue): Ditto.
2549         (WTR::AccessibilityUIElement::minValue): Ditto.
2550         (WTR::AccessibilityUIElement::maxValue): Ditto.
2551
2552 2013-09-25  Krzysztof Czech  <k.czech@samsung.com>
2553
2554         [EFL] accessibility/loading-iframe-sends-notification.html is failing
2555         https://bugs.webkit.org/show_bug.cgi?id=112003
2556
2557         Reviewed by Mario Sanchez Prada.
2558
2559         Enabled addNotificationListener and removeNotificationListener for EFL port.
2560
2561         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2562         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2563         (WTR::AccessibilityController::removeNotificationListener):
2564
2565 2013-09-24  Filip Pizlo  <fpizlo@apple.com>
2566
2567         Crashing under JSC::DFG::SpeculativeJIT::spill visiting citicards.com
2568         https://bugs.webkit.org/show_bug.cgi?id=121844
2569
2570         Reviewed by Mark Hahnenberg.
2571
2572         * Scripts/run-javascriptcore-tests: Be more clear about what test suite failed.
2573
2574 2013-09-24  Alexey Proskuryakov  <ap@apple.com>
2575
2576         [Mac][WK2] Multiple font tests fail is there is a global setting for font antialiasing threshold
2577         https://bugs.webkit.org/show_bug.cgi?id=121854
2578
2579         Reviewed by Anders Carlsson.
2580
2581         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2582         (WTR::InjectedBundle::platformInitialize): Post a notification to update cached
2583         settings in underlying frameworks.
2584
2585 2013-09-24  Mark Rowe  <mrowe@apple.com>
2586
2587         <rdar://problem/14971518> WebKit should build against the Xcode default toolchain when targeting OS X 10.8
2588
2589         Reviewed by Dan Bernstein.
2590
2591         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2592         * MiniBrowser/Configurations/Base.xcconfig:
2593         * TestWebKitAPI/Configurations/Base.xcconfig:
2594         * WebKitLauncher/Configurations/Base.xcconfig:
2595         * WebKitTestRunner/Configurations/Base.xcconfig:
2596
2597 2013-09-24  Denis Nomiyama  <d.nomiyama@samsung.com>
2598
2599         [ATK] Missing WTR AccessibilityController::addNotificationListener implementation
2600         https://bugs.webkit.org/show_bug.cgi?id=121674
2601
2602         Reviewed by Mario Sanchez Prada.
2603
2604         Implemented the global notification listener for
2605         AccessibilityController. The signal is generated by
2606         AXObjectCache::postPlatformNotification() and received by
2607         axObjectEventListener(). axObjectEventListener will then invoke
2608         JSObjectCallAsFunction() with the respective callback function.
2609
2610         There is no additional test for this patch since its implementation will
2611         be tested by an accessibility layout test that is currently failing
2612         (accessibility/loading-iframe-sends-notification.html).
2613
2614         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Removed
2615         stub implementations of addNotificationListener and
2616         removeNotificationListener for the GTK port.
2617         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2618         (WTR::AccessibilityController::addNotificationListener): Creates the
2619         notification handler and sets the notification function callback.
2620         (WTR::AccessibilityController::removeNotificationListener): Removes the
2621         global handler.
2622
2623 2013-09-24  Anton Obzhirov  <a.obzhirov@samsung.com>
2624
2625         [GTK] fast/images/exif-orientation-composited.html is failing
2626         https://bugs.webkit.org/show_bug.cgi?id=119731
2627
2628         Reviewed by Carlos Garcia Campos.
2629
2630         Add handling respect image orientation property in DRT.
2631
2632         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2633         (TestRunner::overridePreference):
2634
2635 2013-09-24  Zan Dobersek  <zdobersek@igalia.com>
2636
2637         [GTK] Bump the GTK+ dependency in the Wayland-specific Jhbuild moduleset
2638         https://bugs.webkit.org/show_bug.cgi?id=121787
2639
2640         Reviewed by Gustavo Noronha Silva.
2641
2642         * gtk/jhbuild-wayland.modules: Bump the GTK+ dependency that's intended for use when building
2643         with the Wayland target enabled to version 3.10.0.
2644
2645 2013-09-23  Patrick Gansterer  <paroga@webkit.org>
2646
2647         use NOMINMAX instead of #define min min
2648         https://bugs.webkit.org/show_bug.cgi?id=73563
2649
2650         Reviewed by Brent Fulgham.
2651
2652         Use NOMINMAX instead of #define min/max as a cleaner
2653         way of ensuring that Windows system header files don't
2654         define min/max as macro in the first place.
2655
2656         * DumpRenderTree/DumpRenderTreePrefix.h:
2657         * DumpRenderTree/cg/ImageDiffCG.cpp:
2658         * DumpRenderTree/config.h:
2659         * DumpRenderTree/win/ImageDiffCairo.cpp:
2660         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
2661         * WebKitTestRunner/config.h:
2662
2663 2013-09-23  Benjamin Poulain  <benjamin@webkit.org>
2664
2665         Delete TestWebKitAPI domain or some keys before running TestWebKitAPI
2666         https://bugs.webkit.org/show_bug.cgi?id=121715 & <rdar://problem/14269434>
2667
2668         Reviewed by Alexey Proskuryakov.
2669
2670         Previously, initalizing a WebPreference would change the cache model
2671         to WebCacheModelDocumentBrowser. That behavior was due to a stale
2672         preference file on disk.
2673
2674         This patch fixes the tests by resetting the default, and using the proper
2675         default values after initializing WebPreference.
2676
2677         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
2678         (TestWebKitAPI::TEST): Use the proper initial value, unrelated
2679         to the previous runs.
2680
2681         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
2682         (TestWebKitAPI::TEST): This test needs b/f cache to be enabled, so change
2683         cache model to the one required.
2684
2685         * TestWebKitAPI/ios/mainIOS.mm:
2686         (main): Reset the preferences before testing.
2687         * TestWebKitAPI/mac/mainMac.mm:
2688         (main): Ditto.
2689
2690 2013-09-23  Benjamin Poulain  <benjamin@webkit.org>
2691
2692         Delete TestWebKitAPI domain or some keys before running TestWebKitAPI
2693         https://bugs.webkit.org/show_bug.cgi?id=121715 & <rdar://problem/14269434>
2694
2695         Reviewed by Alexey Proskuryakov.
2696
2697         Previously, initalizing a WebPreference would change the cache model
2698         to WebCacheModelDocumentBrowser. That behavior was due to a stale
2699         preference file on disk.
2700
2701         This patch fixes the tests by resetting the default, and using the proper
2702         default values after initializing WebPreference.
2703
2704         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
2705         (TestWebKitAPI::TEST): Use the proper initial value, unrelated
2706         to the previous runs.
2707
2708         * TestWebKitAPI/ios/mainIOS.mm:
2709         (main): Reset the preferences before testing.
2710         * TestWebKitAPI/mac/mainMac.mm:
2711         (main): Ditto.
2712
2713 2013-09-23  Anders Carlsson  <andersca@apple.com>
2714
2715         ListHashSet should work with move-only types
2716         https://bugs.webkit.org/show_bug.cgi?id=121802
2717
2718         Reviewed by Andreas Kling.
2719
2720         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
2721         (TestWebKitAPI::TEST):
2722         Add a test for move-only types.
2723
2724 2013-09-23  Alex Christensen  <alex.christensen@flexsim.com>
2725
2726         Added --64-bit option for Windows build.
2727         https://bugs.webkit.org/show_bug.cgi?id=121799
2728
2729         Reviewed by Brent Fulgham.
2730
2731         * Scripts/webkitdirs.pm:
2732         (determinePassedConfiguration): Add "|x64" for 64-bit configuration.
2733         (isWin64): Added.
2734         (determineIsWin64): Added.
2735
2736 2013-09-23  Anders Carlsson  <andersca@apple.com>
2737
2738         ListHashSet should use std::reverse_iterator for reverse iterators
2739         https://bugs.webkit.org/show_bug.cgi?id=121795
2740
2741         Reviewed by Antti Koivisto.
2742
2743         Add test for reverse iterators.
2744
2745         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
2746         (TestWebKitAPI::TEST):
2747
2748 2013-09-23  Krzysztof Czech  <k.czech@samsung.com>
2749
2750         [EFL] accessibility/aria-invalid is failing
2751         https://bugs.webkit.org/show_bug.cgi?id=111986
2752
2753         Reviewed by Mario Sanchez Prada.
2754
2755         Adds possibility to retrieve JS context.
2756         This is part of the implementation of AccessibilityUIElement::addNotificationListener
2757         from 119883 and 120421.
2758
2759         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
2760         (axObjectEventListener):
2761         (addAccessibilityNotificationHandler):
2762         (removeAccessibilityNotificationHandler):
2763         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2764         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
2765         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
2766
2767 2013-09-20  Mark Rowe  <mrowe@apple.com>
2768
2769         <https://webkit.org/b/90090> build-webkit should verify that your tools are up-to-date
2770
2771         Enforce a minimum OS version of 10.7.5 and Xcode version of 4.6.
2772
2773         Reviewed by David Kilzer.
2774
2775         * Scripts/webkitdirs.pm:
2776         (checkRequiredSystemConfig):
2777
2778 2013-09-20  Mario Sanchez Prada  <mario.prada@samsung.com>
2779
2780         [ATK] Do not expose aria-help in ATK based platforms
2781         https://bugs.webkit.org/show_bug.cgi?id=121675
2782
2783         Reviewed by Chris Fleizach.
2784
2785         Remove the implementations for AccessibilityUIElement::helpText()
2786         from DRT and WKTR for GTK and EFL, since they are based on the
2787         AccessibilityObject::helpText() method and the 'aria-help'
2788         attributes, which is wrong since they should not depend on that
2789         but in ATK specific API (see also http://webkit.org/b/121684).
2790
2791         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2792         (AccessibilityUIElement::helpText): Added a new and empty
2793         implementation, now that we are no longer using this in ATK.
2794         * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Removed file
2795         as the only function provided here was helpText().
2796         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Ditto.
2797         * DumpRenderTree/efl/CMakeLists.txt: AccessibilityUIElementEfl.cpp
2798         removed from the list of sources to compile.
2799         * GNUmakefile.am: Likewise, but for AccessibilityUIElementGtk.cpp.
2800         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2801         (WTR::AccessibilityUIElement::helpText): Replaced old implementation
2802         based in DumpRenderTreeSupportGtk with an empty one.
2803
2804 2013-09-20  Dan Bernstein  <mitz@apple.com>
2805
2806         Make extract-localizable-strings available to WebCore clients
2807         https://bugs.webkit.org/show_bug.cgi?id=121699
2808
2809         Reviewed by Darin Adler.
2810
2811         * Scripts/extract-localizable-strings: Copied to
2812         Soure/WebCore/extract-localizaebl-strings.pl, and changed this into a shell script that
2813         executes the script from its new location. This is a temporary measure until certain code
2814         that is external to WebKit is adapted to the new location.
2815         * Scripts/update-webkit-localizable-strings: Changed to call extract-localizable-strings.pl
2816         from its new location.
2817
2818 2013-09-20  Patrick Gansterer  <paroga@webkit.org>
2819
2820         Nuke remaining VS2005 tools from the tree.
2821         https://bugs.webkit.org/show_bug.cgi?id=121691
2822
2823         Reviewed by Brent Fulgham.
2824
2825         * CLWrapper/CLWrapper.cpp: Removed.
2826         * CLWrapper/CLWrapper.sln: Removed.
2827         * CLWrapper/CLWrapper.vcproj: Removed.
2828         * MIDLWrapper/MIDLWrapper.cpp: Removed.
2829         * MIDLWrapper/MIDLWrapper.sln: Removed.
2830         * MIDLWrapper/MIDLWrapper.vcproj: Removed.
2831         * Scripts/parallelcl: Removed.
2832         * vcbin/cl.exe: Removed.
2833         * vcbin/midl.exe: Removed.
2834
2835 2013-09-20  Mario Sanchez Prada  <mario.prada@samsung.com>
2836
2837         [GTK] socket_embed_hook hitting NULL-check assertion running TestWebKit2
2838         https://bugs.webkit.org/show_bug.cgi?id=121294
2839
2840         Reviewed by Martin Robinson.
2841
2842         Provide a new patch to deal with the issue in the GTK+ module from
2843         the internal jhbuild environment. This issue has been reported
2844         upstream (see https://bugzilla.gnome.org/show_bug.cgi?id=708024).
2845
2846         * gtk/jhbuild.modules: Apply the new patch to the GTK+ module.
2847         * gtk/patches/gtk-3.6-do-not-shutdown-accessibility.patch: Added.
2848
2849 2013-09-20  Denis Nomiyama  <d.nomiyama@samsung.com>
2850
2851         [ATK][WTR] accessibility/aria-invalid.html times out
2852         https://bugs.webkit.org/show_bug.cgi?id=121668
2853
2854         Reviewed by Mario Sanchez Prada.
2855
2856         Fixed WTR::AccessibilityUIElement::stringAttributeValue() to return
2857         false in case of aria-invalid event with empty value.
2858
2859         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2860         (WTR::AccessibilityUIElement::stringAttributeValue): Returns false in
2861         case of aria-invalid event with empty value.
2862
2863 2013-09-20  Denis Nomiyama  <d.nomiyama@samsung.com>
2864
2865         [ATK] Missing WTR AccessibilityUIElement::addNotificationListener implementation
2866         https://bugs.webkit.org/show_bug.cgi?id=120421
2867
2868         Reviewed by Mario Sanchez Prada.
2869
2870         Implemented the notification listener for AccessibilityUIElement for
2871         WebKitTestRunner. The signal is generated by
2872         AXObjectCache::postPlatformNotification() and received by
2873         axObjectEventListener(). axObjectEventListener() will then invoke
2874         JSObjectCallAsFunction() with the respective callback function. The
2875         notification handlers are stored in HashMap in
2876         AccessibilityNotificationHandlerAtk.cpp.
2877
2878         Moved ATK signal handling (printAccessibilityEvent and
2879         axObjectEventListener) to AccessibilityNotificationHandlerAtk.cpp.
2880
2881         * WebKitTestRunner/CMakeLists.txt: Added InjectedBundle/atk to the
2882         include path.
2883         * WebKitTestRunner/GNUmakefile.am:
2884         Added AccessibilityNotificationHandlerAtk.cpp/h.
2885         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Moved
2886         listener IDs to AccessibilityNotificationHandlerAtk.cpp.
2887         * WebKitTestRunner/InjectedBundle/AccessibilityController.h: Moved
2888         listener IDs to AccessibilityNotificationHandlerAtk.cpp.
2889         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added a
2890         notification handler for GTK+ and EFL.
2891         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2892         Moved printAccessibilityEvent and axObjectEventListener to
2893         AccessibilityNotificationHandlerAtk.cpp.
2894         (WTR::AccessibilityController::logAccessibilityEvents): Moved listener
2895         IDs to AccessibilityNotificationHandlerAtk.cpp.
2896         (WTR::AccessibilityController::resetToConsistentState): Moved listener
2897         IDs to AccessibilityNotificationHandlerAtk.cpp.
2898         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Added.
2899         (WTR::printAccessibilityEvent): Prints accessibility events. This
2900         function was moved from AccessibilityControllerAtk.cpp.
2901         (WTR::axObjectEventListener): Callback for signals. This function was
2902         moved from AccessibilityControllerAtk.cpp.
2903         (WTR::AccessibilityNotificationHandler::AccessibilityNotificationHandler):
2904         Initialize element and function callback.
2905         (WTR::AccessibilityNotificationHandler::~AccessibilityNotificationHandler):
2906         Removes handler from HashMap and disconnects callbacks if necessary.
2907         (WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Sets
2908         logging mode and connects callbacks.
2909         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
2910         Sets the notification callback and connects callback to signals.
2911         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
2912         Removes the notification callback from HashMap.
2913         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
2914         Connects axObjectEventListener to ATK signals.
2915         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
2916         Disconnects callback.
2917         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h: Added.
2918         (WTR::AccessibilityNotificationHandler::create): Creates a new instance
2919         of AccessibilityNotificationHandler.
2920         (WTR::AccessibilityNotificationHandler::setPlatformElement): Sets the
2921         element.
2922         (WTR::AccessibilityNotificationHandler::platformElement): Gets the
2923         element.
2924         (WTR::AccessibilityNotificationHandler::notificationFunctionCallback):
2925         Gets the notification callback.
2926         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2927         (WTR::AccessibilityUIElement::addNotificationListener): Creates
2928         notification handler, set the platform element and the notification
2929         callback.
2930         (WTR::AccessibilityUIElement::removeNotificationListener): Deletes the
2931         notification handler.
2932         * WebKitTestRunner/PlatformEfl.cmake:
2933         Added AccessibilityNotificationHandlerAtk.cpp.
2934
2935 2013-09-20  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2936
2937         Update features.pri
2938         https://bugs.webkit.org/show_bug.cgi?id=121670
2939
2940         Reviewed by Jocelyn Turcotte.
2941
2942         Remove feature flags that no longer exists and new ones added to FeatureList.pm
2943
2944         * qmake/mkspecs/features/features.pri:
2945
2946 2013-09-20  Krzysztof Czech  <k.czech@samsung.com>
2947
2948         [GTK][WK2] accessibility/selection-states.html is failing
2949         https://bugs.webkit.org/show_bug.cgi?id=116972
2950
2951         Reviewed by Mario Sanchez Prada.
2952
2953         isSelectable() was not exposed in Accessibility.
2954
2955         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2956
2957 2013-09-19  Dan Bernstein  <mitz@apple.com>
2958
2959         Attempted build fix after r156114.
2960
2961         * Scripts/copy-webkitlibraries-to-product-directory: Removed references to WebCoreSQLite3.
2962
2963 2013-09-19  Alexey Proskuryakov  <ap@apple.com>
2964
2965         REGRESSION (r129451): run-safari --no-saved-state is broken
2966         https://bugs.webkit.org/show_bug.cgi?id=121566
2967
2968         Undo a last minute change that doesn't actually work.
2969
2970         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp): "-1" cannot be passed
2971         via command line, <rdar://problem/15032886>.
2972
2973 2013-09-19  Dan Bernstein  <mitz@apple.com>
2974
2975         Add a style guideline regarding spacing in range-based for loops
2976         https://bugs.webkit.org/show_bug.cgi?id=121620
2977
2978         Reviewed by Anders Carlsson.
2979
2980         * Scripts/webkitpy/style/checkers/cpp.py:
2981         (check_spacing): Added checking that there are spaces around the colon in a range-based for
2982         loop.
2983         (CppChecker): Added whitespace/colon to the categories set.
2984         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2985         (WebKitStyleTest.test_spacing): Added two tests for the new check.
2986
2987 2013-09-18  Sam Weinig  <sam@webkit.org>
2988
2989         Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in Tools
2990         https://bugs.webkit.org/show_bug.cgi?id=121588
2991
2992         Reviewed by Anders Carlsson.
2993
2994         * DumpRenderTree/TestRunner.cpp:
2995         * ImageDiff/efl/ImageDiff.cpp:
2996         * TestWebKitAPI/JavaScriptTest.cpp:
2997         * TestWebKitAPI/PlatformUtilities.cpp:
2998         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2999         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3000         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3001         * WebKitTestRunner/StringFunctions.h:
3002         * WebKitTestRunner/TestInvocation.cpp:
3003         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
3004         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3005
3006 2013-09-18  Bem Jones-Bey  <bjonesbe@adobe.com>
3007
3008         W3C Test Import script reformats test HTML
3009         https://bugs.webkit.org/show_bug.cgi?id=119159
3010
3011         Reviewed by Dirk Pranke.
3012
3013         Completely rewrite the test conversion process to minimize
3014         reformatting when adding prefixes, etc. This isn't 100% perfect, there
3015         are still places where it will end up changing the formatting, but it
3016         is much better than before. Most notably, the public interface to the
3017         test converter has changed: now one calls a method instead of creating
3018         an instance of the test converter class. This is because the test
3019         converter class now has state, so one really needs a new instance for
3020         each test.
3021
3022         Note that this also lays some simple groundwork for being able to use
3023         a MockHost in the tests.
3024
3025         * Scripts/webkitpy/w3c/test_converter.py:
3026         (convert_for_webkit):
3027         (_W3CTestConverter):
3028         (_W3CTestConverter.__init__):
3029         (_W3CTestConverter.output):
3030         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
3031         (_W3CTestConverter.convert_style_data):
3032         (_W3CTestConverter.convert_attributes_if_needed):
3033         (_W3CTestConverter.handle_starttag):
3034         (_W3CTestConverter.handle_endtag):
3035         (_W3CTestConverter.handle_startendtag):
3036         (_W3CTestConverter.handle_data):
3037         (_W3CTestConverter.handle_entityref):
3038         (_W3CTestConverter.handle_charref):
3039         (_W3CTestConverter.handle_comment):
3040         (_W3CTestConverter.handle_decl):
3041         (_W3CTestConverter.handle_pi):
3042         * Scripts/webkitpy/w3c/test_converter_unittest.py:
3043         (W3CTestConverterTest):
3044         (W3CTestConverterTest.fake_dir_path):
3045         (W3CTestConverterTest.test_read_prefixed_property_list):
3046         (verify_no_conversion_happened):
3047         * Scripts/webkitpy/w3c/test_importer.py:
3048         (TestImporter.import_tests):
3049
3050 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
3051
3052         Get rid of the jsc-test-list by moving all not-jsc-capable tests into js/dom
3053         https://bugs.webkit.org/show_bug.cgi?id=121578
3054
3055         Rubber stamped by Geoffrey Garen.
3056
3057         * Scripts/run-layout-jsc:
3058
3059 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
3060
3061         Unreviewed, fix for Ruby 1.8.
3062
3063         * Scripts/run-jsc-stress-tests:
3064
3065 2013-09-17  Filip Pizlo  <fpizlo@apple.com>
3066
3067         run-jsc-stress-tests should make it easier to look at error spew from tests
3068         https://bugs.webkit.org/show_bug.cgi?id=121531
3069
3070         Reviewed by Mark Hahnenberg.
3071         
3072         This makes two changes:
3073         
3074         - The out/err spew from each test is now saved to a .out file in jsc-stress-results.
3075         
3076         - The same spew also goes to the console but is prefixed by the test's name.
3077         
3078         This required some tee and awk hacks, and then some sh hacks to work around the fact
3079         that if you do "(foo | bar) || baz", and foo fails, then baz won't run - the ||
3080         operator will only see a failure of bar failed. So to pass output to tee and awk, I
3081         needed to do weird things.
3082
3083         * Scripts/run-jsc-stress-tests:
3084
3085 2013-09-18  Alexey Proskuryakov  <ap@apple.com>
3086
3087         REGRESSION (r129451): run-safari --no-saved-state is broken
3088         https://bugs.webkit.org/show_bug.cgi?id=121566
3089
3090         Reviewed by Mark Rowe.
3091
3092         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp):
3093         Check arguments, not the newly created empty array. Pass a value that silences warnings.
3094         While at it, removed a check for Snow Leopard.
3095
3096 2013-09-18  Alex Christensen  <achristensen@webkit.org>
3097
3098         Improved WinLauncher's URL handling.
3099         https://bugs.webkit.org/show_bug.cgi?id=121535
3100
3101         Reviewed by Brent Fulgham.
3102
3103         * WinLauncher/WinLauncher.cpp:
3104         (EditProc):
3105         Use INTERNET_MAX_URL_LENGTH instead of our MAX_URL_LENGTH.
3106         (loadURL):
3107         Prepend "http://" to URLs with no scheme.
3108
3109 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
3110
3111         DFG should support Int52 for local variables
3112         https://bugs.webkit.org/show_bug.cgi?id=121064
3113
3114         Reviewed by Oliver Hunt.
3115
3116         * Scripts/run-jsc-stress-tests:
3117
3118 2013-09-18  peavo@outlook.com  <peavo@outlook.com>
3119
3120         [Win] TestWebKitAPI does not compile.
3121         https://bugs.webkit.org/show_bug.cgi?id=121485
3122
3123         Reviewed by Brent Fulgham.
3124
3125         It is no longer possible to inherit from WebCore::BitmapImage, which the test relies on.
3126         Instead, load a bitmap, then destroy the decoded data, which will cause WebCore::frameAtIndex()
3127         to return null, which is the case we want to test.
3128
3129         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
3130         (TestWebKitAPI::TEST):
3131
3132 2013-09-18  Mario Sanchez Prada  <mario.prada@samsung.com>
3133
3134         [ATK] Expose aria-haspopup and aria-sort without the 'aria-' prefix
3135         https://bugs.webkit.org/show_bug.cgi?id=121495
3136
3137         Reviewed by Chris Fleizach.
3138
3139         Adapted DRT and WKTR to deal with the new names for the ATK object
3140         attributes being exposed for 'aria-haspopup' and 'aria-sort'.
3141
3142         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3143         (coreAttributeToAtkAttribute): Updated translation between ATK and DRT.
3144         (AccessibilityUIElement::stringAttributeValue): Ditto.
3145         (AccessibilityUIElement::hasPopup): Ditto.
3146         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3147         (WTR::coreAttributeToAtkAttribute): Updated translation between ATK and WKTR.
3148         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
3149         (WTR::AccessibilityUIElement::hasPopup): Ditto.
3150
3151 2013-09-18  Commit Queue  <commit-queue@webkit.org>
3152
3153         Unreviewed, rolling out r156019 and r156020.
3154         http://trac.webkit.org/changeset/156019
3155         http://trac.webkit.org/changeset/156020
3156         https://bugs.webkit.org/show_bug.cgi?id=121540
3157
3158         Broke tests (Requested by ap on #webkit).
3159
3160         * Scripts/run-jsc-stress-tests:
3161
3162 2013-09-17  Gwang Yoon Hwang  <ryumiel@company100.net>
3163
3164         Unreviewed. Add myself as a committer.
3165
3166         * Scripts/webkitpy/common/config/contributors.json:
3167
3168 2013-09-17  Jae Hyun Park  <jae.park@company100.net>
3169
3170         Unreviewed. Add myself as a committer.
3171
3172         * Scripts/webkitpy/common/config/contributors.json:
3173
3174 2013-09-17  Filip Pizlo  <fpizlo@apple.com>
3175
3176         DFG should support Int52 for local variables
3177         https://bugs.webkit.org/show_bug.cgi?id=121064
3178
3179         Reviewed by Oliver Hunt.
3180
3181         * Scripts/run-jsc-stress-tests:
3182
3183 2013-09-17  Alex Christensen  <alex.christensen@flexsim.com>
3184
3185         Added back and forward buttons to WinLauncher.
3186         https://bugs.webkit.org/show_bug.cgi?id=121212
3187
3188         Reviewed by Brent Fulgham.
3189
3190         * WinLauncher/WinLauncher.cpp:
3191         (resizeSubViews):
3192         Move new back and forward buttons to correct positions before URL bar.
3193         (dllLauncherEntryPoint): 
3194         Store the default button window procedure and replace with my button procedures.
3195         (EditProc): Updated style and renamed from MyEditProc.
3196         (BackButtonProc): Added.
3197         (ForwardButtonProc): Added.
3198
3199 2013-09-17  Michael Saboff  <msaboff@apple.com>
3200
3201         Unreviewed typo fix after r155999
3202
3203         Changed en_US.UTB-8 to en_US.UTF-8
3204
3205         * Scripts/run-javascriptcore-tests:
3206
3207 2013-09-17  Michael Saboff  <msaboff@apple.com>
3208
3209         run-jsc-stress-tests fails with ruby version 2
3210         https://bugs.webkit.org/show_bug.cgi?id=121521
3211
3212         Reviewed by Jessie Berlin.
3213
3214         Explicitly set LANG to en_US.UTB-8 before starting run-jsc-stress-tests.
3215
3216         * Scripts/run-javascriptcore-tests:
3217
3218 2013-09-17  Brent Fulgham  <bfulgham@apple.com>
3219
3220         [Windows] Unreviewed build fix after r155963.
3221
3222         * DumpRenderTree/win/TestRunnerWin.cpp:
3223         (TestRunner::evaluateScriptInIsolatedWorld): Pass nullptr rather than 0.
3224
3225 2013-09-17  Anders Carlsson  <andersca@apple.com>
3226
3227         Fix a typo.
3228
3229         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3230         (TestWebKitAPI::TEST):
3231
3232 2013-09-16  Anders Carlsson  <andersca@apple.com>
3233
3234         HashMap should work with move-only keys
3235         https://bugs.webkit.org/show_bug.cgi?id=121310
3236
3237         Reviewed by Darin Adler.
3238
3239         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3240         (TestWebKitAPI::TEST):
3241         Add test.
3242
3243 2013-09-17  YuTeh Shen  <shenyute@hotmail.com>
3244
3245         BrowserMarshal.h build fail
3246         https://bugs.webkit.org/show_bug.cgi?id=102938
3247
3248         Reviewed by Carlos Garcia Campos.
3249
3250         Fix variable name.
3251
3252         * MiniBrowser/gtk/GNUmakefile.am:
3253
3254 2013-09-16  Brent Fulgham  <bfulgham@apple.com>
3255
3256         [Windows] Clean up WinLauncher by using smart pointers
3257         https://bugs.webkit.org/show_bug.cgi?id=121467
3258
3259         Reviewed by Anders Carlsson.
3260
3261         * WinLauncher/PrintWebUIDelegate.cpp:
3262         (PrintWebUIDelegate::webViewPrintingMarginRect): Switch to smart pointers.
3263         * WinLauncher/WinLauncher.cpp:
3264         (WinLauncherWebHost::updateAddressBar): Use _bstr_t and smart pointers.
3265         (WinLauncherWebHost::didFailProvisionalLoadWithError): Ditto.
3266         (showLastVisitedSites): Smart pointer updates.
3267         (WinLauncherWebHost::didFinishLoadForFrame): Ditto.
3268         (setToDefaultPreferences): Ditto.
3269         (dllLauncherEntryPoint): Ditto.
3270         (PrintView): Ditto.
3271         (LaunchInspector): Ditto.
3272         (NavigateToHistory): Ditto.
3273         (MyEditProc): Ditto.
3274         (loadURL): Ditto.
3275
3276 2013-09-16  Brent Fulgham  <bfulgham@apple.com>
3277
3278         [Windows] Add rudimentary history to WinLauncher.
3279         https://bugs.webkit.org/show_bug.cgi?id=121463
3280
3281         Reviewed by Anders Carlsson.
3282
3283         * WinLauncher/WinLauncher.cpp:
3284         (updateMenuItemForHistoryItem): Added
3285         (showLastVisitedSites): Added
3286         (WinLauncherWebHost::didFinishLoadForFrame): Add history item once
3287         a new page has been visited.
3288         (dllLauncherEntryPoint): Deallocate history on exit.
3289         (NavigateToHistory): Added
3290         (WndProc): Add handler for history entries
3291         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu items to hold
3292         up to 10 history slots.
3293         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link against
3294         Windows utility library to allow use of _bstr_t type.
3295         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Add menu items
3296         to hold up to 10 history slots.
3297         * WinLauncher/stdafx.h: Add <comutil.h> to precompiled headers.
3298
3299 2013-09-16  Gustavo Noronha Silva  <gns@gnome.org>
3300
3301         [GTK] Make symbol export filter more strict, and disable for dev/test builds
3302         https://bugs.webkit.org/show_bug.cgi?id=120586
3303
3304         Reviewed by Martin Robinson.
3305
3306         * GNUmakefile.am: moved GtkLauncher and documentation builds to their own
3307         makefiles, so they can be included unconditionally.
3308         * GtkLauncher/GNUmakefile.am: added.
3309         * Scripts/webkitdirs.pm:
3310         (runAutogenForAutotoolsProjectIfNecessary): always pass --enable-developer-mode
3311         to configure, since we consider builds done through build-webkit to be development
3312         and test builds.
3313         * gtk/GNUmakefile.am: added.
3314         * gtk/common.py: do not use the Scripts directory as a reference to the top path;
3315         it's not necessary and it will not work now that the Scripts directory is not
3316         shipped in the tarball.
3317
3318 2013-09-16  Anders Carlsson  <andersca@apple.com>
3319
3320         WTF::Deque should work with move only types
3321         https://bugs.webkit.org/show_bug.cgi?id=121446
3322
3323         Reviewed by Andreas Kling.
3324
3325         * TestWebKitAPI/Tests/WTF/Deque.cpp:
3326         (TestWebKitAPI::TEST):
3327         Add a test.
3328
3329 2013-09-16  Wojciech Bielawski  <w.bielawski@samsung.com>
3330
3331         [WKTR] WebKitTestRunner's eventSender.contextClick() returns objects without implemented click() method.
3332         https://bugs.webkit.org/show_bug.cgi?id=98410
3333
3334         Reviewed by Darin Adler.
3335
3336         Add implementation of click() method of objects returned by eventSender.contextClick().
3337
3338         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3339         (MenuItemPrivateData):
3340         (WTR::menuItemClickCallback):
3341         (WTR::getMenuItemTitleCallback):
3342         (WTR::staticMenuItemFinalize):
3343         (WTR::getMenuItemClass):
3344         (WTR::EventSendingController::contextClick):
3345
3346 2013-09-15  Zan Dobersek  <zdobersek@igalia.com>
3347
3348         Make the GDB webkit.py script compatible with Python v3
3349         https://bugs.webkit.org/show_bug.cgi?id=121395
3350
3351         Reviewed by Ryosuke Niwa.
3352
3353         GDB fails to load the printing helpers from the webkit.py script if Python v3 is used. To avoid that,
3354         uses of xrange() in the script are replaced with range(), and the print statements are changed into
3355         the print() function invocations.
3356
3357         * gdb/webkit.py:
3358         (guess_string_length):
3359         (ustring_to_string):
3360         (lstring_to_string):
3361         (WTFCStringPrinter.to_string):
3362         (PrintPathToRootCommand.invoke):
3363
3364 2013-09-15  Zan Dobersek  <zdobersek@igalia.com>
3365
3366         [webkitpy] perf profiler attaches to WKTR after the WebProcess was launched
3367         https://bugs.webkit.org/show_bug.cgi?id=119631
3368
3369         Reviewed by Ryosuke Niwa.
3370
3371         The perf profiler is attached to the test runner after the test runner has been launched,
3372         but in the case of WebKitTestRunner, this is done after the WebProcess was spawned by the
3373         UIProcess, meaning that WebProcess operations will not be profiled.
3374
3375         To avoid that, the perf profiler is changed to provide a wrapper command for the test runner.
3376         This is done in the scope of already present support for wrapper scripts (such as valgrind)
3377         that are settable through the --wrapper option. This causes the perf profiler to correctly
3378         continue profiling the WebProcess after it was spawned.
3379
3380         When the profiler is launched, a wait process is launched with the profiler's pid as the
3381         argument. This ensures we can check that the profiler exited normally. If it did not, its
3382         output can be corrupted and can cause problems when that output is examined. The after-exit
3383         report is avoided in that case.
3384
3385         * Scripts/webkitpy/common/system/profiler.py:
3386         (Profiler.wrapper_arguments): The method returns an empty list by default.
3387         (Perf.__init__): Remove unnecessary member variables.
3388         (Perf.attach_to_pid): Launch the wait process with the profiler's pid as the argument.
3389         (Perf.wrapper_arguments): Used instead of attaching the profiler to the profiled process' pid,
3390         the method returns a list of arguments that should be used as a wrapper for the test runner.
3391         The arguments specify the 'perf record' command, with the output file and the instruction to
3392         construct the call graph given as well.
3393         (Perf._first_ten_lines_of_profile): Prettify the output by avoiding the unnecessary trailing
3394         whitespace in the profile lines.
3395         (Perf.profile_after_exit): Kill the profiler process through its pid if the wait process is still
3396         running. If it is running even after that, or if the profiler process produced a non-zero exit
3397         code, the method reports the profiling failure and returns. Otherwise it continues on reporting
3398         the top 10 lines of the profile and how to examine the profile further.
3399         * Scripts/webkitpy/port/driver.py:
3400         (Driver._command_wrapper): The method is now a member of the Driver class, returning the wrapper
3401         as specified by the --wrapper option if given, or the profiler wrapper if the profiler is present,
3402         or an empty list otherwise.
3403         (Driver.cmd_line):
3404         * Scripts/webkitpy/port/driver_unittest.py:
3405         (DriverTest.make_port): Adjusted so mock host or options objects can be specified
3406         for the testing-specific Port object.
3407         (DriverTest._assert_wrapper): Pass a MockOptions object with the wrapper value to the make_port method,
3408         as the Driver._command_wrapper now operates on the option's value directly rather than accepting it through
3409         a parameter.
3410         (DriverTest.test_profiler_as_wrapper): Provide a test case to check the correct profiler wrapper is used
3411         when profiling on the Linux platform with the perf profiler.
3412
3413 2013-09-14  Dan Bernstein  <mitz@apple.com>
3414
3415         [mac] Check For Framework Include Consistency build phase checks the wrong framework
3416         https://bugs.webkit.org/show_bug.cgi?id=121215
3417
3418         Reviewed by Mark Rowe.
3419
3420         * Scripts/check-for-webkit-framework-include-consistency: Replaced hard-coded paths to
3421         WebKit.framework’s Headers and PrivateHeaders directories with the current target’s
3422         public and private headers folder paths. Also tweaked the error messages’ format to make
3423         Xcode recognize them as errors.
3424
3425 2013-09-14  Alberto Garcia  <berto@igalia.com>
3426
3427         [GTK] Fails to compile if the build directory is in a different partition
3428         https://bugs.webkit.org/show_bug.cgi?id=121296
3429
3430         Reviewed by Martin Robinson.
3431
3432         Instead of using os.symlink() to install the gtk-doc templates,
3433         use os.link() first and fall back to os.symlink() if it fails.
3434
3435         * gtk/gtkdoc.py:
3436         (GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):
3437
3438 2013-09-14  Alberto Garcia  <berto@igalia.com>
3439
3440         [GTK] WebKitGTK+ is linking against libxslt in too many places
3441         https://bugs.webkit.org/show_bug.cgi?id=121356
3442
3443         Reviewed by Martin Robinson.
3444
3445         TestWebCore, WebKitTestRunner and MiniBrowser don't use libxslt,
3446         so we don't need to link against it.
3447
3448         * MiniBrowser/gtk/GNUmakefile.am:
3449         * TestWebKitAPI/GNUmakefile.am:
3450         * WebKitTestRunner/GNUmakefile.am:
3451
3452 2013-09-14  Ross Burton  <ross.burton@intel.com>
3453
3454         Uses gtk-doc tools even when --disable-gtk-doc passed
3455         https://bugs.webkit.org/show_bug.cgi?id=91239
3456
3457         Reviewed by Martin Robinson.
3458
3459         Don't run generate-gtkdoc on install if gtk-doc is disabled.
3460
3461         * GNUmakefile.am:
3462
3463 2013-09-14  Alberto Garcia  <berto@igalia.com>
3464
3465         [GTK] Fails to compile if the build directory is in a different partition
3466         https://bugs.webkit.org/show_bug.cgi?id=121296
3467
3468         Reviewed by Carlos Garcia Campos.
3469
3470         Use symlinks instead of hard links to support building on a
3471         different file system.
3472
3473         * gtk/gtkdoc.py:
3474         (GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):
3475
3476 2013-09-13  Darin Adler  <darin@apple.com>
3477
3478         Use a better name than m_invertibleCTM
3479         https://bugs.webkit.org/show_bug.cgi?id=121341
3480
3481         Reviewed by Andreas Kling.
3482
3483         * Scripts/do-webcore-rename: Updated to do this replace as we do.
3484
3485 2013-09-13  Anders Carlsson  <andersca@apple.com>
3486
3487         Pick the correct overload when a const reference is passed to appendSlowCase.
3488         https://bugs.webkit.org/show_bug.cgi?id=121326
3489
3490         Reviewed by Darin Adler.
3491
3492         * TestWebKitAPI/Tests/WTF/Vector.cpp:
3493         (TestWebKitAPI::TEST):
3494
3495 2013-09-13  Darin Adler  <darin@apple.com>
3496
3497         Rename confusingly named "runtimeObject" functions
3498         https://bugs.webkit.org/show_bug.cgi?id=121339
3499
3500         Reviewed by Sam Weinig.
3501
3502         * Scripts/do-webcore-rename: Updated to do this replace as usual.
3503
3504 2013-09-13  Filip Pizlo  <fpizlo@apple.com>
3505
3506         DFG AI assumes that ToThis can never return non-object if it is passed an object, and operationToThis will get the wrong value of isStrictMode() if there's inlining
3507         https://bugs.webkit.org/show_bug.cgi?id=121330
3508
3509         Reviewed by Mark Hahnenberg and Oliver Hunt.
3510
3511         We should run tests even if they don't have expected files yet.
3512         
3513         * Scripts/run-layout-jsc:
3514
3515 2013-09-13  Anders Carlsson  <andersca@apple.com>
3516
3517         Use nullptr instead of 0 in calls to HashMap::add
3518         https://bugs.webkit.org/show_bug.cgi?id=121322
3519
3520         Reviewed by Sam Weinig.
3521
3522         * DumpRenderTree/mac/TestRunnerMac.mm:
3523         (TestRunner::evaluateScriptInIsolatedWorld):
3524         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3525         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
3526
3527 2013-09-13  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3528
3529         [GTK] Move to the new web inspector
3530         https://bugs.webkit.org/show_bug.cgi?id=120647
3531
3532         Reviewed by Carlos Garcia Campos.
3533
3534         * GtkLauncher/main.c:
3535         (main): no longer set WEBKIT_INSPECTOR_PATH.
3536         * MiniBrowser/gtk/main.c:
3537         (main): ditto.
3538         * Scripts/old-run-webkit-tests:
3539         (openDumpTool): ditto.
3540         * Scripts/run-gtk-tests: ditto.
3541         * Scripts/webkitpy/port/gtk.py:
3542         (GtkPort.setup_environ_for_server): ditto.
3543
3544 2013-09-13  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3545
3546         [Qt] REGRESSION(r154444): xss-DENIED test results changed
3547         https://bugs.webkit.org/show_bug.cgi?id=120595
3548
3549         Reviewed by Jocelyn Turcotte.
3550
3551         Avoid overwriting Qt meta properties, which we identify by them being undeletable.
3552
3553         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3554         (DumpRenderTree::initJSObjects):
3555
3556 2013-09-13  Darin Adler  <darin@apple.com>
3557
3558         Give actions in Range class NON_SHOUTING_NAMES
3559         https://bugs.webkit.org/show_bug.cgi?id=121280
3560
3561         Reviewed by Andreas Kling.
3562
3563         * Scripts/do-webcore-rename: Updated to do this replace, keeping with
3564         the tradition of checking in the last one we did, along with other
3565         rename ideas for the future.
3566
3567 2013-09-12  Lucas Forschler  <lforschler@apple.com>
3568
3569         Create short build logs for errors and warnings.
3570         https://bugs.webkit.org/show_bug.cgi?id=120614
3571
3572         Reviewed by Ryosuke Niwa.
3573
3574         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3575             -include StringIO 
3576         (CompileWebKit.createSummary):
3577             -add a createSummary function which will parse out errors and warnings into a concise log file for quick viewing
3578
3579 2013-09-12  Roger Fong  <roger_fong@apple.com>
3580
3581         Update cygwin downloader to search for packages in the right location.
3582
3583         * CygwinDownloader/cygwin-downloader.py:
3584         * CygwinDownloader/cygwin-downloader.zip:
3585
3586 2013-09-12  Anders Carlsson  <andersca@apple.com>
3587
3588         Add rudimentary support for move-only types as values in HashMap
3589         https://bugs.webkit.org/show_bug.cgi?id=121226
3590
3591         Reviewed by Andreas Kling.
3592
3593         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3594         (TestWebKitAPI::TEST):
3595         Add a HashMap<unsigned, MoveOnly> test.
3596
3597 2013-09-12  Gabor Abraham  <abrhm@inf.u-szeged.hu>
3598
3599         Auto GDB backtrace generation for EFL/GTK/Qt bots.
3600         https://bugs.webkit.org/show_bug.cgi?id=119338
3601
3602         Reviewed by Csaba Osztrogonác.
3603
3604         * Scripts/webkitpy/port/efl.py:
3605         (EflPort.check_sys_deps):
3606         (EflPort):
3607         (EflPort._get_crash_log):
3608         * Scripts/webkitpy/port/efl_unittest.py:
3609         (EflPortTest.test_show_results_html_file):
3610         (EflPortTest):
3611         (EflPortTest.test_get_crash_log):
3612         * Scripts/webkitpy/port/gtk.py:
3613         (GtkPort._get_crash_log):
3614         * Scripts/webkitpy/port/gtk_unittest.py:
3615         (GtkPortTest.test_get_crash_log):
3616         * Scripts/webkitpy/port/linux_get_crash_log.py: Added.
3617         (GDBCrashLogGenerator):
3618         (GDBCrashLogGenerator.__init__):
3619         (GDBCrashLogGenerator._get_gdb_output):
3620         (GDBCrashLogGenerator.generate_crash_log):
3621         (GDBCrashLogGenerator.generate_crash_log.match_filename):
3622         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py: Added.
3623         (GDBCrashLogGeneratorTest):
3624         (GDBCrashLogGeneratorTest.test_generate_crash_log):
3625         (_mock_gdb_output):
3626         * Scripts/webkitpy/port/qt.py:
3627         (QtPort.default_child_processes):
3628         (QtPort):
3629         (QtPort._get_cr