[CMake] Remove WebCoreDerivedSources library target
[WebKit-https.git] / Tools / ChangeLog
1 2018-01-16  Fujii Hironori  <Hironori.Fujii@sony.com>
2
3         [CMake] Remove WebCoreDerivedSources library target
4         https://bugs.webkit.org/show_bug.cgi?id=181664
5
6         Reviewed by Carlos Garcia Campos.
7
8         * TestWebKitAPI/PlatformWPE.cmake: Do not link WebCoreDerivedSources.
9         * TestWebKitAPI/PlatformWin.cmake: Ditto.
10
11 2018-01-16  Ling Ho  <lingcherd_ho@apple.com>
12
13         Move Debug Test262, Release Test262 and Performance queues to Sierra
14         https://bugs.webkit.org/show_bug.cgi?id=181692
15
16         Unreviewed
17
18 2018-01-16  Zach Li  <zachli@apple.com>
19
20         Add pop-up policy support in website policies.
21         https://bugs.webkit.org/show_bug.cgi?id=181544.
22         rdar://problem/30521400.
23
24         Reviewed by Alex Christensen.
25
26         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
27         Added pop-up-check.html.
28
29         * TestWebKitAPI/Tests/WebKit/pop-up-check.html: Added.
30
31         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
32         (-[PopUpPoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
33         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
34         (-[PopUpPoliciesDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
35         (TEST):
36
37 2018-01-16  Wenson Hsieh  <wenson_hsieh@apple.com>
38
39         [Attachment Support] Provide the `src` of an attachment to the UI delegate when an attachment is inserted
40         https://bugs.webkit.org/show_bug.cgi?id=181638
41         <rdar://problem/36508702>
42
43         Reviewed by Dan Bernstein.
44
45         Tweak an existing API test to check that the `src` of an attachment element inserted via script matches the
46         `source` provided to the UI delegate via -[WKUIDelegate _webView:didInsertAttachment:withSource:].
47
48         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
49         (-[AttachmentUpdateObserver init]):
50         (-[AttachmentUpdateObserver sourceForIdentifier:]):
51         (-[AttachmentUpdateObserver _webView:didInsertAttachment:withSource:]):
52         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::expectSourceForIdentifier):
53         (TestWebKitAPI::TEST):
54         (-[AttachmentUpdateObserver _webView:didInsertAttachment:]): Deleted.
55
56 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
57
58         Unreviewed. Fix GTK unit tests execution in the bots after r226967.
59
60         I forgot to pass the environment to the GLibTestRunner and Xvfb was not used in the bots.
61
62         * glib/api_test_runner.py:
63         (TestRunner._run_test_glib): Pass env to GLibTestRunner.
64         * glib/glib_test_runner.py:
65         (GLibTestRunner.run): Use given env.
66
67 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
68
69         [GTK][WPE] Stop passing --verbose to run-api-tests from the bots
70         https://bugs.webkit.org/show_bug.cgi?id=181676
71
72         Reviewed by Carlos Alberto Lopez Perez.
73
74         The option was removed in r226967.
75
76         * BuildSlaveSupport/build.webkit.org-config/steps.py:
77         (RunGtkAPITests):
78         (RunWPEAPITests):
79
80 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
81
82         Unreviewed. Temporarily bring back --verbose option of api_test_runner.py.
83
84         The bots are still passing that option and the step is failing because it was removed in r226967.
85
86         * glib/api_test_runner.py:
87         (add_options):
88
89 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
90
91         [GTK][WPE] Improve the way glib tests are run
92         https://bugs.webkit.org/show_bug.cgi?id=181674
93
94         Reviewed by Žan Doberšek.
95
96         Stop using gtester external program and use our own tester from python directly. This way we no longer need to
97         parse the tests output to get the results which is causing problems in WPE bot. We can now differentiate between
98         tests failing due to an expected assert in the test and unexpected crashes.
99         This also fixes a bug in previous code where we failed to properly detect tests timing out, because gtester was
100         not showing the subtest name in stdout in case of timeouts.
101         I've lowered the default timeout from 10 to 5, since we are now properly handling the timeout for every test
102         case. I've also removed the verbose option, since it was only used by gtester and we now always show the result
103         of every test case.
104
105         * glib/api_test_runner.py:
106         (TestRunner._run_test_glib): Use GLibTestRunner.
107         (TestRunner._run_google_test): Wrote tests timing out to stdout too.
108         (add_options):
109         * glib/glib_test_runner.py: Added.
110         (TestTimeout):
111         (Message):
112         (Message.__init__):
113         (Message.create):
114         (Message.create.read_unsigned):
115         (Message.create.read_double):
116         (Message.create.read_string):
117         (GLibTestRunner):
118         (GLibTestRunner.__init__):
119         (GLibTestRunner._process_data):
120         (GLibTestRunner._process_message):
121         (GLibTestRunner._read_from_pipe):
122         (GLibTestRunner._read_from_stderr):
123         (GLibTestRunner._start_timeout):
124         (GLibTestRunner._start_timeout._alarm_handler):
125         (GLibTestRunner._stop_timeout):
126         (GLibTestRunner._subtest_start):
127         (GLibTestRunner._subtest_message):
128         (GLibTestRunner._subtest_stderr):
129         (GLibTestRunner._subtest_end):
130         (GLibTestRunner.run):
131
132 2018-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
133
134         Unreviewed, add Thibault to contributors.json
135
136         It's a bit weird to add someone here before their first contribution, but this affects
137         Bugzilla autocomplete, and that is serious business.
138
139         * Scripts/webkitpy/common/config/contributors.json:
140
141 2018-01-15  JF Bastien  <jfbastien@apple.com>
142
143         Remove makePoisonedUnique
144         https://bugs.webkit.org/show_bug.cgi?id=181630
145         <rdar://problem/36498623>
146
147         Reviewed by Mark Lam.
148
149         Update tests.
150
151         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
152         (TestWebKitAPI::TEST):
153         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
154         (TestWebKitAPI::TEST):
155
156 2018-01-15  Adrian Perez de Castro  <aperez@igalia.com>
157
158         [GTK][JHBuild] Tools/gtk/install-dependencies: Package libxfont does not exist anymore in Arch Linux
159         https://bugs.webkit.org/show_bug.cgi?id=181476
160
161         Reviewed by Michael Catanzaro.
162
163         Update to xorg-server 1.19.6 which depends on libxfont2, and change
164         the lists of packages to install libxfont2-devel (or equivalent).
165
166         * gtk/install-dependencies:
167         * gtk/jhbuild.modules:
168
169 2018-01-15  Carlos Garcia Campos  <cgarcia@igalia.com>
170
171         [GTK][WPE] Add support for unit test expectations
172         https://bugs.webkit.org/show_bug.cgi?id=181589
173
174         Reviewed by Michael Catanzaro.
175
176         We currently have a way to skip tests by annotating them in the api test runner script. The main problem of this
177         approach is that we skip tests when they fail in the bots and we never notice if they stop failing, keeping the
178         tests skipped forever. This is indeed the case of several WebKit2 C API tests. Annotating skipped tests in the
179         script itself is not a good idea either.
180
181         This patch adds a generic TestExpectations class for simple tests based on tests with subtests, like our unit
182         tests, but also WebDriver tests. It parses a json file with the tests and subtests expectations and provides
183         convenient methods to query them.
184
185         * Scripts/run-gtk-tests:
186         (GtkTestRunner): Remove all Skipped and Slow tests marked here.
187         * Scripts/run-wpe-tests:
188         (WPETestRunner): Ditto.
189         * Scripts/webkitpy/common/test_expectations.py: Added.
190         (TestExpectations):
191         (TestExpectations.__init__):
192         (TestExpectations._port_name_for_expected):
193         (TestExpectations._expected_value):
194         (TestExpectations.skipped_tests):
195         (TestExpectations.skipped_subtests):
196         (TestExpectations._expectation_value):
197         (TestExpectations.is_slow):
198         (TestExpectations.get_expectation):
199         * Scripts/webkitpy/common/test_expectations_unittest.py: Added.
200         (MockTestExpectations):
201         (MockTestExpectations.__init__):
202         (MockTestExpectations.is_skip):
203         (ExpectationsTest):
204         (assert_exp):
205         (assert_not_exp):
206         (assert_bad_exp):
207         (assert_skip):
208         (test_basic):
209         (test_skip):
210         (test_flaky):
211         (test_build_type):
212         * TestWebKitAPI/glib/TestExpectations.json: Added.
213         * glib/api_test_runner.py:
214         (TestRunner): Remove SkippedTest implementation.
215         (TestRunner.__init__): Create a TestExpectations.
216         (TestRunner._test_cases_to_skip): Use TestExpectations to check skipped tests.
217         (TestRunner._should_run_test_program): Ditto.
218         (TestRunner._run_test_glib): Use TestExpectations to check if test suite is slow.
219         (TestRunner._run_test_glib.parse_line.set_test_result): Register also tests passing.
220         (TestRunner._run_google_test): Use TestExpectations to check if test cases is slow and register tests passing.
221         (TestRunner.run_tests): Check if actual result is the expected one and register also unexpected passes.
222         (TestRunner.run_tests.report): Helper to write report to stdout.
223
224 2018-01-13  Mark Lam  <mark.lam@apple.com>
225
226         Replace all use of ConstExprPoisoned with Poisoned.
227         https://bugs.webkit.org/show_bug.cgi?id=181542
228         <rdar://problem/36442138>
229
230         Reviewed by JF Bastien.
231
232         1. Converted tests to using new uintptr_t& poison type.
233         2. Added tests for Poisoned comparison operators.
234
235         * TestWebKitAPI/CMakeLists.txt:
236         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
237         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp: Removed.
238         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
239         (TestWebKitAPI::TEST):
240         (TestWebKitAPI::initializeTestPoison): Deleted.
241         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
242         (TestWebKitAPI::TEST):
243         (TestWebKitAPI::passWithRef):
244         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
245         (TestWebKitAPI::TEST):
246         (TestWebKitAPI::f1):
247         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
248         (TestWebKitAPI::TEST):
249         (TestWebKitAPI::poisonedPtrFoo):
250         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
251         (TestWebKitAPI::TEST):
252         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
253         (TestWebKitAPI::TEST):
254
255 2018-01-13  David Kilzer  <ddkilzer@apple.com>
256
257         check-webkit-style: false positive for [whitespace/braces] with os_log format string
258         <https://webkit.org/b/181606>
259
260         Reviewed by Darin Adler.
261
262         * Scripts/webkitpy/style/checkers/cpp.py:
263         (check_spacing): Modify regular expression to ignore
264         os_log format strings like '%{public}'.
265         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
266         (CppStyleTest.test_spacing_before_braces): Add os_log
267         format string test.
268
269 2018-01-12  Wenson Hsieh  <wenson_hsieh@apple.com>
270
271         [macOS] API tests ChangeAttachmentDataUpdatesWithInPlaceDisplay and InPlaceVideoAttachmentInsertionWithinList are failing
272         https://bugs.webkit.org/show_bug.cgi?id=181626
273
274         Reviewed by Joseph Pecoraro.
275
276         Make the web view for WKAttachmentTests slightly bigger to avoid size clamping behavior introduced in r226915.
277         Additionally, write a new API test covering the change in r226915.
278
279         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
280         (webViewForTestingAttachments):
281         (TestWebKitAPI::TEST):
282
283 2018-01-12  Alex Christensen  <achristensen@webkit.org>
284
285         History state should be updated during client redirects with asynchronous policy decisions
286         https://bugs.webkit.org/show_bug.cgi?id=181358
287         <rdar://problem/35547689>
288
289         Reviewed by Andy Estes.
290
291         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
292         (-[AsyncPolicyDecisionDelegate webView:didFinishNavigation:]):
293         (-[AsyncPolicyDecisionDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
294         (TEST):
295
296 2018-01-12  Jonathan Bedard  <jbedard@apple.com>
297
298         webkitpy: Refactor simulator code (Part 4)
299         https://bugs.webkit.org/show_bug.cgi?id=180555
300         <rdar://problem/36131381>
301
302         Reviewed by Aakash Jain.
303
304         Move new_simulated_device.py to simulated_device.py.
305
306         * Scripts/webkitpy/port/ios_simulator.py: Update import statement.
307         * Scripts/webkitpy/xcode/new_simulated_device.py: Removed.
308         * Scripts/webkitpy/xcode/new_simulated_device_unittest.py: Removed.
309         * Scripts/webkitpy/xcode/simulated_device.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device.py.
310         * Scripts/webkitpy/xcode/simulated_device_unittest.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device_unittest.py.
311
312 2018-01-12  Alex Christensen  <achristensen@webkit.org>
313
314         REGRESSION (r226818): API test WebKitLegacy.LoadInvalidURLRequest is failing
315         https://bugs.webkit.org/show_bug.cgi?id=181595
316
317         This test was testing behavior of an invalid URL that WebCore parses but NSURL does not.
318         It was using example.com<> but after r226479 < and > are considered invalid by WebCore.
319         I change the < and > to $ to make this test pass and continue to test what it used to.
320
321         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html:
322         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
323         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
324
325 2018-01-11  Keith Miller  <keith_miller@apple.com>
326
327         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
328         https://bugs.webkit.org/show_bug.cgi?id=181573
329
330         Reviewed by Simon Fraser.
331
332         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
333
334 2018-01-11  Jiewen Tan  <jiewen_tan@apple.com>
335
336         [WebAuthN] Import a CBOR coder from Chromium
337         https://bugs.webkit.org/show_bug.cgi?id=181522
338         <rdar://problem/36055729>
339
340         Reviewed by Brent Fulgham.
341
342         This patch also imports all unit tests into our API tests to ensure all
343         workarounds and modification against the original codebase doesn't change
344         any original functionalities.
345
346         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
347         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp: Added.
348         (TestWebKitAPI::TEST):
349         * TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp: Added.
350         (TestWebKitAPI::TEST):
351         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp: Added.
352         (TestWebKitAPI::eq):
353         Workarounds applied.
354         (TestWebKitAPI::TEST):
355
356 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
357
358         webkitpy: Use partially disambiguated type in SimulatedDeviceManager._disambiguate_device_type
359         https://bugs.webkit.org/show_bug.cgi?id=181538
360         <rdar://problem/36440580>
361
362         Reviewed by Aakash Jain.
363
364         When disambiguating a device type, it is possible that the provided device type is sufficiently
365         ambiguous that the comparisons against complete device types without a disambiguated hardware_family
366         will result in a failure to disambiguate the type.
367
368         * Scripts/webkitpy/xcode/new_simulated_device.py:
369         (SimulatedDeviceManager._disambiguate_device_type):
370
371 2018-01-11  Brent Fulgham  <bfulgham@apple.com>
372
373         REGRESSION(r219530): ResourceLoadStatisticsPersistentStorage should be read-only in ephemeral sessions
374         https://bugs.webkit.org/show_bug.cgi?id=181136
375         <rdar://problem/36116604>
376
377         Reviewed by Chris Dumez.
378
379         Add a new API test to confirm that ResourceLoadStatistics can be turned on safely for ephemeral
380         browsing sessions.
381
382         * Scripts/run-gtk-tests:
383         (GtkTestRunner): Unskip test now that it passes.
384         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
385         (TEST): Add new WebsiteDataStoreEphemeral test.
386
387 2018-01-11  Ryan Haddad  <ryanhaddad@apple.com>
388
389         Unreviewed, rolling out r226816.
390
391         This change broke LayoutTests on the bots.
392
393         Reverted changeset:
394
395         "run-webkit-tests fails when there is a curly brace in Xcode
396         build output"
397         https://bugs.webkit.org/show_bug.cgi?id=181254
398         https://trac.webkit.org/changeset/226816
399
400 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
401
402         webkitpy: Fix flakey webserver tests
403         https://bugs.webkit.org/show_bug.cgi?id=181555
404         <rdar://problem/36448273>
405
406         Reviewed by Aakash Jain.
407
408         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
409         (LayoutTestRunnerTests.test_servers_started): Add and bind custom checks to
410         determine if a specific server is running.
411
412 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
413
414         Commit queue failed to land a bug, 'NoneType' object has no attribute 'strip'
415         https://bugs.webkit.org/show_bug.cgi?id=181561
416         <rdar://problem/36452652>
417
418         Reviewed by Aakash Jain.
419
420         BeautifulSoup.find may return None, this case should be gracefully handled.
421
422         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
423         (BugzillaQueries._parse_result_count):
424         (BugzillaQueries._fetch_bugs_from_advanced_query): Added logging.
425
426 2018-01-11  Alexey Proskuryakov  <ap@apple.com>
427
428         run-webkit-tests fails when there is a curly brace in Xcode build output
429         https://bugs.webkit.org/show_bug.cgi?id=181254
430
431         Reviewed by Daniel Bates.
432
433         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
434         (MeteredStream.write):
435
436 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
437
438         webkitpy: Reimplement simulator code (Part 3)
439         https://bugs.webkit.org/show_bug.cgi?id=180555
440         <rdar://problem/36131381>
441
442         Reviewed by Aakash Jain.
443
444         Remove old simulator code.
445
446         * Scripts/webkitpy/xcode/__init__.py: Remove import statement.
447         * Scripts/webkitpy/xcode/simulated_device.py: Removed.
448         * Scripts/webkitpy/xcode/simulator.py: Removed.
449         * Scripts/webkitpy/xcode/simulator_unittest.py: Removed.
450
451 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
452
453         [Attachment Support] Support moving attachment elements in editable areas using drag and drop
454         https://bugs.webkit.org/show_bug.cgi?id=181337
455         <rdar://problem/36324813>
456
457         Reviewed by Tim Horton.
458
459         Add 3 new API tests for attachment element dragging.
460
461         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
462         (-[TestWKWebView expectElementTag:toComeBefore:]):
463         (-[NSItemProvider expectType:withData:]):
464         (TestWebKitAPI::TEST):
465
466 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
467
468         REGRESSION(r225856): Incorrectly managing 'future' baseline_search_paths. 
469         https://bugs.webkit.org/show_bug.cgi?id=179621
470         <rdar://problem/35589585>
471
472         Unreviewed infrastructure fix.
473
474         * Scripts/webkitpy/port/mac.py:
475         (MacPort.default_baseline_search_path): Include 'future' in the version_fallback
476         list if we are the VERSION_MAX, which usually corresponds with future.
477
478 2018-01-11  Filip Pizlo  <fpizlo@apple.com>
479
480         CodeBlocks should be in IsoSubspaces
481         https://bugs.webkit.org/show_bug.cgi?id=180884
482
483         Reviewed by Saam Barati.
484         
485         Remove some less important benchmarks from the default run. Doing run-jsc-benchmarks
486         shouldn't take a long time due to benchmarks we don't optimize for.
487         
488         * Scripts/run-jsc-benchmarks:
489
490 2018-01-11  Ms2ger  <Ms2ger@igalia.com>
491
492         Test gardening for GTK.
493         https://bugs.webkit.org/show_bug.cgi?id=181477
494
495         Unreviewed test gardening.
496
497         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Correct the file name.
498         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Adjust the expected console message.
499
500 2018-01-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
501
502         Add the new JSCOnly bot to the scheduler.
503         https://bugs.webkit.org/show_bug.cgi?id=181487
504
505         Unreviewed follow-up patch after r226729
506
507         On r226729 I missed to add the new JSCOnly bot the default scheduler.
508         This is needed to make the bot automatically pick each commit for testing.
509
510         * BuildSlaveSupport/build.webkit.org-config/config.json:
511
512 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
513
514         [Attachment Support] Support dragging attachment elements out as files on iOS
515         https://bugs.webkit.org/show_bug.cgi?id=181199
516         <rdar://problem/36299316>
517
518         Reviewed by Tim Horton, Andy Estes and Joseph Pecoraro.
519
520         Add support in the drag and drop simulator for testing blob-backed attachment element dragging, and also add new
521         attachment API tests.
522
523         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
524         (-[NSItemProvider expectType:withData:]):
525         (TestWebKitAPI::TEST):
526
527         Add two new WKAttachmentTests to exercise dragging data- and file-backed blobs via attachment elements. These
528         tests first insert attachments via drop or WKWebView SPI, and then drag these attachments out and use the
529         -expectType:withData: helper to inspect the item providers created from the drag source.
530
531         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
532         (TestWebKitAPI::TEST):
533         * TestWebKitAPI/ios/DataInteractionSimulator.h:
534         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
535         (-[MockDragSession localContext]):
536         (-[MockDragSession setLocalContext:]):
537         (-[DataInteractionSimulator _resetSimulatedState]):
538         (-[DataInteractionSimulator simulateAllTouchesCanceled:]):
539         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
540         (-[DataInteractionSimulator _advanceProgress]):
541         (-[DataInteractionSimulator endDataTransfer]):
542
543         Make some tweaks to the iOS drag and drop simulator. In particular, this patch (1) adds a new hook to tell
544         WebKit that data transfers have been completed, (2) fixes incorrect drop proposal handling when returning
545         UIDropOperationForbidden by replacing _shouldPerformOperation with a UIDropProposal, and (3) teach the
546         MockDragSession to hold on to a localContext.
547
548 2018-01-11  Ali Juma  <ajuma@chromium.org>
549
550         Unreviewed. Add Ali Juma as contributor
551
552         * Scripts/webkitpy/common/config/contributors.json:
553
554 2018-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
555
556         Unreviewed. Update Selenium WebDriver imported tests.
557
558         New version of selenium uses command line options to pass driver and browser binaries to pytest instead of
559         environment variables.
560
561         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
562         (collect): Reorder the arguments to make pytest happy.
563         (run): Ditto.
564         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
565         (WebDriverSeleniumExecutor.__init__): Add driver binary, browser binary and browser args as arguments.
566
567 2018-01-11  Ling Ho  <lingcherd_ho@apple.com>
568
569         Move Commit Queue and EWS Queues to Sierra on Bot Watcher's Dasboard
570         https://bugs.webkit.org/show_bug.cgi?id=181492
571         <rdar://problem/36359679>
572
573         Reviewed by Alexey Proskuryakov. 
574
575 2018-01-10  Adrian Perez de Castro  <aperez@igalia.com>
576
577         [GTK] Tools/gtk/install-dependencies: Packages geoclue, ruby-highline, xorg-utils do not exist in Arch Linux
578         https://bugs.webkit.org/show_bug.cgi?id=181475
579
580         Reviewed by Michael Catanzaro.
581
582         * gtk/install-dependencies: Update package list for Arch Linux, extend
583         message shown at end of installation with additional tips.
584
585 2018-01-10  Wenson Hsieh  <wenson_hsieh@apple.com>
586
587         REGRESSION(r222507): Composition highlight doesn't render when using IME
588         https://bugs.webkit.org/show_bug.cgi?id=181485
589         <rdar://problem/35896516>
590
591         Reviewed by Ryosuke Niwa.
592
593         Add a `suppressUnderline` argument to TextInputController.setMarkedText. This suppresses the custom underlines
594         rendered when testing IME on iOS in WebKit2. In this new test, suppressing underline rendering is needed to
595         allow rendering composition backgrounds (see InlineTextBox::paint).
596
597         * DumpRenderTree/ios/TextInputControllerIOS.m:
598         (+[TextInputController isSelectorExcludedFromWebScript:]):
599         (+[TextInputController webScriptNameForSelector:]):
600         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
601         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
602         * DumpRenderTree/mac/TextInputControllerMac.m:
603         (+[TextInputController isSelectorExcludedFromWebScript:]):
604         (+[TextInputController webScriptNameForSelector:]):
605         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
606         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
607         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
608         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
609         (WTR::TextInputController::setMarkedText):
610         * WebKitTestRunner/InjectedBundle/TextInputController.h:
611
612 2018-01-10  JF Bastien  <jfbastien@apple.com>
613
614         Poison small JSObject derivatives which only contain pointers
615         https://bugs.webkit.org/show_bug.cgi?id=181483
616         <rdar://problem/36407127>
617
618         Reviewed by Mark Lam.
619
620         Test the new move-assign and move-copy from unique_ptr, as well as
621         nullptr_t ctors.
622
623         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
624         (TestWebKitAPI::TEST):
625         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
626         (TestWebKitAPI::TEST):
627         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
628         (TestWebKitAPI::TEST):
629
630 2018-01-10  Chris Dumez  <cdumez@apple.com>
631
632         Multiple http/wpt/beacon/contentextensions/ test are flaky.
633         https://bugs.webkit.org/show_bug.cgi?id=179256
634         <rdar://problem/35401978>
635
636         Reviewed by Alex Christensen.
637
638         Update WebKitTestRunner to set a temporary path for content extensions so that its WKTR
639         instance gets its own folder to avoid conflicts and flakiness.
640
641         * WebKitTestRunner/mac/TestControllerMac.mm:
642         (WTR::TestController::platformConfigureViewForTest):
643
644 2018-01-10  Tim Horton  <timothy_horton@apple.com>
645
646         REGRESSION (r213590): Swipe from edge to go to previous page is significantly slower than tapping back button on Twitter
647         https://bugs.webkit.org/show_bug.cgi?id=181269
648         <rdar://problem/35110344>
649
650         Reviewed by Simon Fraser.
651
652         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
653         (WTR::UIScriptController::beginBackSwipe):
654         (WTR::UIScriptController::completeBackSwipe):
655         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
656         (WTR::UIScriptController::beginBackSwipe):
657         (WTR::UIScriptController::completeBackSwipe):
658         (WTR::UIScriptController::overridePreference):
659         (WTR::UIScriptController::replaceTextAtRange):
660         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
661         (WTR::PlatformWebView::setNavigationGesturesEnabled):
662         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
663         (WTR::UIScriptController::beginBackSwipe):
664         (WTR::UIScriptController::completeBackSwipe):
665         Implement beginBackSwipe and completeBackSwipe on iOS (they already
666         exist on Mac) in terms of the new WKWebView testing SPI.
667
668 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
669
670         REGRESSION (r226715): ignore WARNING output in linter tests
671         https://bugs.webkit.org/show_bug.cgi?id=181486
672         <rdar://problem/36408847>
673
674         Reviewed by Aakash Jain.
675
676         Linter unit tests should not be interested in logs at the the INFO or WARNING levels.
677
678         * Scripts/webkitpy/common/system/outputcapture.py:
679         (OutputCapture.__init__): Pass logging level to be captured.
680         * Scripts/webkitpy/style/main_unittest.py:
681         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors): Capture logging at the ERROR level.
682         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Ditto.
683         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit): Ditto.
684         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Ditto.
685         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Ditto.
686         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Ditto.
687         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file): Ditto.
688         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit): Ditto.
689
690 2018-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
691
692         Add a JSCOnly MIPS buildbot
693         https://bugs.webkit.org/show_bug.cgi?id=181487
694
695         Reviewed by Michael Catanzaro.
696
697         Add the new bot configs definitions for the master and update the unit tests.
698
699         * BuildSlaveSupport/build.webkit.org-config/config.json:
700         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
701
702 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
703
704         REGRESSION (r226715): don't re-check number of simulators in child processes
705         https://bugs.webkit.org/show_bug.cgi?id=181484
706         <rdar://problem/36407151>
707
708         Reviewed by Aakash Jain.
709
710         * Scripts/webkitpy/port/ios_simulator.py:
711         (IOSSimulatorPort.__init__): Skip the number of simulators check if simulators
712         are already initialized.
713
714 2018-01-10  Commit Queue  <commit-queue@webkit.org>
715
716         Unreviewed, rolling out r226667 and r226673.
717         https://bugs.webkit.org/show_bug.cgi?id=181488
718
719         This caused a flaky crash. (Requested by mlewis13 on #webkit).
720
721         Reverted changesets:
722
723         "CodeBlocks should be in IsoSubspaces"
724         https://bugs.webkit.org/show_bug.cgi?id=180884
725         https://trac.webkit.org/changeset/226667
726
727         "REGRESSION (r226667): CodeBlocks should be in IsoSubspaces"
728         https://bugs.webkit.org/show_bug.cgi?id=180884
729         https://trac.webkit.org/changeset/226673
730
731 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
732
733         Follow-up fix to r226715
734         https://bugs.webkit.org/show_bug.cgi?id=180555
735         <rdar://problem/36131381>
736
737         Unreviewed infrastructure fix.
738
739         * Scripts/webkitpy/xcode/new_simulated_device.py:
740         (SimulatedDeviceManager._create_or_find_device_for_request): Use _delete instead
741         of delete.
742
743 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
744
745         webkitpy: Refactor simulator code (Part 2)
746         https://bugs.webkit.org/show_bug.cgi?id=180555
747         <rdar://problem/36131381>
748
749         Reviewed by Aakash Jain.
750
751         The patch leverages the SimulatedDeviceManager when running layout tests.
752         This patch is primarily code removal, since much of the IOSSimulatorPort
753         was dedicated to managing simulators. The removed code is either now owned by the
754         SimulatedDeviceManager (and committed in Part 1) or supported a technique to
755         boot multiple simulators which was made obsolete in Xcode 9.
756
757         * Scripts/webkitpy/layout_tests/controllers/manager.py:
758         (Manager._custom_device_for_test.in): Device names now have spaces in them,
759         strip those spaces.
760         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
761         (parse_args): Remove '--runtime' flag, this is achieved with the --version flag.
762         * Scripts/webkitpy/port/ios.py:
763         (IOSPort.__init__): The _current_device idiom is no longer required since the
764         SimulatedDeviceManager keeps track of any previously booted devices.
765         (IOSPort.target_host): Even when only a single device is used, it will be accessed
766         through the array of managed devices.
767         (IOSPort.using_multiple_devices): Deleted.
768         * Scripts/webkitpy/port/ios_device.py:
769         (IOSDevicePort.using_multiple_devices): Deleted.
770         * Scripts/webkitpy/port/ios_simulator.py:
771         (IOSSimulatorPort): Remove constants required to manage simulators, change device
772         class strings so they can be parsed by the DeviceType class.
773         (IOSSimulatorPort.__init__): Determine the number of processes to use by checking
774         the number of simulators currently booted, the number of child processes specified
775         and the maximum number of simulators supported by this system.
776         (IOSSimulatorPort._device_for_worker_number_map):Return the array of initialized
777         devices owned by the SimulatedDeviceManager.
778         (IOSSimulatorPort.ios_version): Remove support for the --runtime option.
779         (IOSSimulatorPort.default_child_processes): Use the SimulatedDeviceManager to check
780         the maximum number of supported simulators on this system.
781         (IOSSimulatorPort._create_devices): Construct a list of device requests with a
782         request for each child process and send this list to the SimulatedDeviceManager to
783         initialize the devices.
784         (IOSSimulatorPort.clean_up_test_run):
785         (IOSSimulatorPort.check_sys_deps): Check that there are simulators running the
786         specified version of iOS.
787         (IOSSimulatorPort.reset_preferences):
788         (IOSSimulatorPort.simulator_runtime): Deleted.
789         (IOSSimulatorPort.simulator_device_type): Deleted.
790         (IOSSimulatorPort._teardown_managed_simulators): Deleted.
791         (IOSSimulatorPort.use_multiple_simulator_apps): Deleted.
792         (IOSSimulatorPort._create_simulators): Deleted.
793         (IOSSimulatorPort._quit_ios_simulator): Deleted.
794         (IOSSimulatorPort._using_dedicated_simulators): Deleted.
795         (IOSSimulatorPort.using_multiple_devices): Deleted.
796         (IOSSimulatorPort._create_device): Deleted.
797         (IOSSimulatorPort.get_simulator_path): Deleted.
798         (IOSSimulatorPort._createSimulatorApps): Deleted.
799         (IOSSimulatorPort._createSimulatorApp): Deleted.
800         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
801         (TestRebaseline.test_rebaseline): Filter out commands run when determining the
802         maximum number of simulators run on this system.
803         (TestRebaselineExpectations.test_rebaseline_expectations): Ditto.
804         * Scripts/webkitpy/xcode/new_simulated_device.py:
805         (SimulatedDeviceManager._does_fulfill_request): Fixed log statement.
806
807 2018-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
808
809         WebDriver: run-webdriver-tests doesn't handle test names with a '/' correctly
810         https://bugs.webkit.org/show_bug.cgi?id=181474
811
812         Reviewed by Carlos Alberto Lopez Perez.
813
814         We use os.path.basename() to get the subtest name. If the test name contains a slash we get part of the subtest
815         name as the name.
816
817         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
818         (WebDriverTestRunnerW3C._subtest_name): Helper function to get the subtest name.
819         (WebDriverTestRunnerW3C.run): Use _subtest_name() instead of os.path.basename().
820
821 2018-01-09  Andy Estes  <aestes@apple.com>
822
823         [Xcode] Use the Apple Internal SDK if available when building ImageDiff
824         https://bugs.webkit.org/show_bug.cgi?id=181459
825
826         Reviewed by Dan Bernstein.
827
828         * ImageDiff/cg/Configurations/Base.xcconfig:
829
830 2018-01-09  Myles C. Maxfield  <mmaxfield@apple.com>
831
832         font-display:fallback can cause a visual flash (which is supposed to be impossible)
833         https://bugs.webkit.org/show_bug.cgi?id=181374
834
835         Reviewed by Simon Fraser.
836
837         The test requires Palatino.
838
839         * DumpRenderTree/mac/DumpRenderTree.mm:
840         (allowedFontFamilySet):
841         * WebKitTestRunner/mac/TestControllerMac.mm:
842         (WTR::allowedFontFamilySet):
843
844 2018-01-09  Saam Barati  <sbarati@apple.com>
845
846         Give some slack in display-profiler-outputs computation of the terminal window's number of columns
847         https://bugs.webkit.org/show_bug.cgi?id=181449
848
849         Reviewed by JF Bastien.
850
851         This allows me to Cmd+f in my terminal to search for things without
852         having the results become misaligned.
853
854         * Scripts/display-profiler-output:
855
856 2018-01-09  Basuke Suzuki  <Basuke.Suzuki@sony.com>
857
858         [webkitpy] PlatformInfo should have default argument for casual use
859         https://bugs.webkit.org/show_bug.cgi?id=180827
860
861         Reviewed by David Kilzer.
862
863         PlatformInfo should be the only way to check platform specific thing instead
864         of sys.platform or other various checks. If there is something you want to check,
865         it should be placed in PlatformInfo.
866
867         Currently to instantiate PlatformInfo, it requires arguments, which is usually
868         sys, platform and Executive(). They are straight forward and should be handled
869         by default arguments. Then we can instantiate PlatformInfo more casual.
870
871         * Scripts/webkitpy/common/system/platforminfo.py:
872         (PlatformInfo): Use relative module path import
873         (PlatformInfo.__init__):
874         (PlatformInfo.executive): Lazy instantiation of Executive()
875         (PlatformInfo.total_bytes_memory): Accessing via above property
876         (PlatformInfo.xcode_sdk_version): Ditto
877         (PlatformInfo.xcode_simctl_list): Ditto
878         (PlatformInfo.xcode_version): Ditto
879         (PlatformInfo._win_version_str): Ditto
880         * Scripts/webkitpy/common/system/systemhost.py:
881         (SystemHost.__init__):
882         * Scripts/webkitpy/common/system/user.py:
883         (User.__init__):
884
885 2018-01-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
886
887         [Win] Remove workaround for Bug 176442 after stopping MSVC 2015 support
888         https://bugs.webkit.org/show_bug.cgi?id=176443
889
890         Reviewed by Darin Adler.
891
892         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
893         (TEST):
894
895 2018-01-09  Frederic Wang  <fwang@igalia.com.fr>
896
897         check-webkit-style: Verify syntax for WK_API_AVAILABLE
898         https://bugs.webkit.org/show_bug.cgi?id=181394
899
900         Reviewed by Darin Adler.
901
902         A common syntax error for WK_API_AVAILABLE is to write ios(WK_MAC_TBA)
903         as the second parameter instead of ios(WK_IOS_TBA). This generally
904         builds for iOS on EWS but not when using the public SDK. See r224057,
905         r223207 and r226211 for example. This patch adds a basic style check
906         for that macro to prevent this kind of mistake.
907
908         * Scripts/webkitpy/style/checkers/cpp.py:
909         (check_min_versions_of_wk_api_available): New function to verify the parameters of WX_API_AVAILABLE.
910         (check_style): Run new style check.
911         (CppChecker): Add build type for the new style check.
912         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
913         (WebKitStyleTest.test_min_versions_of_wk_api_available): Add tests for the new style check.
914
915 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
916
917         [Attachment Support] Expose HTMLAttachmentElement.uniqueIdentifier to bindings
918         https://bugs.webkit.org/show_bug.cgi?id=181420
919         <rdar://problem/36365827>
920
921         Reviewed by Alex Christensen.
922
923         Adjusts some existing API tests to verify that attachment elements' uniqueIdentifiers match the uniqueIdentifier
924         of corresponding _WKAttachments.
925
926         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
927         (TestWebKitAPI::TEST):
928
929 2018-01-08  Alex Christensen  <achristensen@webkit.org>
930
931         Add WKNavigationDelegate SPI exposing WebProcess crash reason
932         https://bugs.webkit.org/show_bug.cgi?id=181410
933         <rdar://problem/36167199>
934
935         Reviewed by Wenson Hsieh.
936
937         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
938         (-[CrashReasonDelegate _webView:webContentProcessDidTerminateWithReason:]):
939         (TEST):
940
941 2018-01-08  Alex Christensen  <achristensen@webkit.org>
942
943         Add SPI for WKOpenPanelParameters._acceptedMIMETypes and _acceptedFileExtensions
944         https://bugs.webkit.org/show_bug.cgi?id=181408
945         <rdar://problem/35884960>
946
947         Reviewed by Tim Horton.
948
949         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
950         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
951
952 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
953
954         [Attachment Support] Expose file name and content type of WKAttachment
955         https://bugs.webkit.org/show_bug.cgi?id=181390
956         <rdar://problem/36336837>
957
958         Reviewed by Tim Horton.
959
960         Adjusts some existing tests in WKAttachmentTests to exercise -requestInfo:.
961
962         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
963         (-[_WKAttachment synchronouslyRequestInfo:]):
964         (-[_WKAttachment synchronouslyRequestData:]):
965
966         Reimplement this in terms of -synchronouslyRequestInfo:.
967
968         (-[_WKAttachment expectRequestedDataToBe:]):
969         (TestWebKitAPI::TEST):
970
971 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
972
973         Copying, pasting, and then deleting an attachment element breaks attachment data requests
974         https://bugs.webkit.org/show_bug.cgi?id=181365
975         <rdar://problem/36340647>
976
977         Reviewed by Tim Horton.
978
979         Adds two new attachment API tests to verify that copying and pasting an existing attachment inserts an
980         attachment element that may be edited independently of the original attachment. See WebCore/ChangeLog for more
981         detail.
982
983         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
984         (TestWebKitAPI::TEST):
985
986 2018-01-08  Youenn Fablet  <youenn@apple.com>
987
988         navigator.onLine does not work inside service workers
989         https://bugs.webkit.org/show_bug.cgi?id=181079
990         <rdar://problem/36178606>
991
992         Reviewed by Darin Adler.
993
994         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
995         (WTR::InjectedBundle::initialize): Setting service worker creation callback to inject ServiceWorkerInternals object.
996
997 2018-01-07  Saam Barati  <sbarati@apple.com>
998
999         Add total exits and total compilations sorting mode to the "full" command in display-profiler-output
1000         https://bugs.webkit.org/show_bug.cgi?id=181372
1001
1002         Reviewed by Filip Pizlo.
1003
1004         Adding these sorting modes makes it easier to analyze functions
1005         that recompile a lot and exit a lot.
1006
1007         * Scripts/display-profiler-output:
1008
1009 2018-01-06  Julien Brianceau  <julien.brianceau@gmail.com>
1010
1011         Unreviewed, remove my Cisco email from contributors.json
1012
1013         * Scripts/webkitpy/common/config/contributors.json:
1014
1015 2018-01-05  JF Bastien  <jfbastien@apple.com>
1016
1017         WebAssembly: poison JS object's secrets
1018         https://bugs.webkit.org/show_bug.cgi?id=181339
1019         <rdar://problem/36325001>
1020
1021         Reviewed by Mark Lam.
1022
1023         Update tests for swap(Poisoned<k, T>, T*)
1024
1025         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp:
1026         (TestWebKitAPI::TEST):
1027         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
1028         (TestWebKitAPI::TEST):
1029         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
1030         (TestWebKitAPI::TEST):
1031
1032 2018-01-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1033
1034         REGRESSION(r226396) DataInteractionTests: ContentEditableToContentEditable and ContentEditableToTextarea are failing
1035         https://bugs.webkit.org/show_bug.cgi?id=181359
1036
1037         Reviewed by Tim Horton.
1038
1039         Ensure that these tests still pass using older SDKs.
1040
1041         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1042         (TestWebKitAPI::TEST):
1043
1044 2018-01-05  Alex Christensen  <achristensen@webkit.org>
1045
1046         Rebase API test after r226469
1047         https://bugs.webkit.org/show_bug.cgi?id=181308
1048
1049         * TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
1050         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
1051         A URL with < or > in it is now recognized as invalid by WebKit.  This is intentional, and matches our behavior before enabling the new URLParser.
1052
1053 2018-01-05  Alex Christensen  <achristensen@webkit.org>
1054
1055         Restrict navigation-time WKWebsiteDataStore swapping to main frame navigations
1056         https://bugs.webkit.org/show_bug.cgi?id=181217
1057
1058         Reviewed by Tim Horton.
1059
1060         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1061         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1062         (TEST):
1063
1064 2018-01-05  Alex Christensen  <achristensen@webkit.org>
1065
1066         Add WKBundleFrameCreateFrameHandle
1067         https://bugs.webkit.org/show_bug.cgi?id=181232
1068         <rdar://problem/35926696>
1069
1070         Reviewed by Tim Horton.
1071
1072         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1073         * TestWebKitAPI/Tests/WebKitCocoa/FrameHandleSerialization.mm: Added.
1074         (mouseDidMoveOverElement):
1075         (-[FrameHandleSerialization webProcessPlugIn:didCreateBrowserContextController:]):
1076         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1077         (-[MouseMoveOverElementDelegate _webView:mouseDidMoveOverElement:withFlags:userInfo:]):
1078         (TEST):
1079
1080 2018-01-05  Chris Fleizach  <cfleizach@apple.com>
1081
1082         iOS: Build fix after r226432.
1083         
1084         Unreviewed. Stop duplicating speakAs symbols for iOS.
1085
1086         * DumpRenderTree/AccessibilityUIElement.cpp:
1087         (AccessibilityUIElement::speakAs):
1088
1089 2018-01-05  Javier Fernandez  <jfernandez@igalia.com>
1090
1091         Unreviewed, added myself as WebKit reviewer
1092
1093         * Scripts/webkitpy/common/config/contributors.json:
1094
1095 2018-01-05  Claudio Saavedra  <csaavedra@igalia.com>
1096
1097         WPE: Build fix after r226432.
1098
1099         Unreviewed. Rename ::speak() to ::speakAs().
1100         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
1101         (WTR::AccessibilityUIElement::speakAs):
1102         (WTR::AccessibilityUIElement::speak): Deleted.
1103
1104 2018-01-04  Chris Fleizach  <cfleizach@apple.com>
1105
1106         AX: Implement updated CSS3 Speech for 'speak' and 'speak-as' properties
1107         https://bugs.webkit.org/show_bug.cgi?id=180361
1108
1109         Reviewed by Zalan Bujtas.
1110
1111         * DumpRenderTree/AccessibilityUIElement.cpp:
1112         (speakAsCallback):
1113         (AccessibilityUIElement::speakAs):
1114         (AccessibilityUIElement::getJSClass):
1115         (speakCallback): Deleted.
1116         (AccessibilityUIElement::speak): Deleted.
1117         * DumpRenderTree/AccessibilityUIElement.h:
1118         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1119         (AccessibilityUIElement::speakAs):
1120         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1121         (AccessibilityUIElement::speakAs):
1122         (AccessibilityUIElement::speak): Deleted.
1123         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1124         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1125         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1126         (WTR::AccessibilityUIElement::speakAs):
1127         (WTR::AccessibilityUIElement::speak): Deleted.
1128         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1129         (WTR::AccessibilityUIElement::speakAs):
1130         (WTR::AccessibilityUIElement::speak): Deleted.
1131
1132 2018-01-04  Jonathan Bedard  <jbedard@apple.com>
1133
1134         REGRESSION (r226395): test-webkitperl test expectations incorrect
1135         https://bugs.webkit.org/show_bug.cgi?id=181307
1136         <rdar://problem/36306558>
1137
1138         Rubber-stamped by Aakash Jain.
1139
1140         r226395 added two lines towards the beginning of
1141         Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl, the line
1142         numbers in the test expectations need to update.
1143
1144         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
1145
1146 2018-01-04  Tim Horton  <timothy_horton@apple.com>
1147
1148         WKWebView loses minimum layout size overrides that happen while the process is terminated
1149         https://bugs.webkit.org/show_bug.cgi?id=181306
1150         <rdar://problem/34398288>
1151
1152         Reviewed by Dan Bernstein.
1153
1154         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
1155         (TEST):
1156         Add a test that calling _overrideLayoutParametersWithMinimumLayoutSize
1157         while the process is terminated results in the page getting the correct
1158         minimum layout size.
1159
1160 2018-01-04  Eric Carlson  <eric.carlson@apple.com>
1161
1162         [MediaStream] Add Mock screen capture source
1163         https://bugs.webkit.org/show_bug.cgi?id=181291
1164         <rdar://problem/36298164>
1165
1166         Reviewed by Dean Jackson.
1167
1168         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test.
1169         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
1170         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
1171
1172 2018-01-04  Lucas Forschler  <lforschler@apple.com>
1173
1174         <rdar://problem/36300930> Change proxy server setting on master config to reach s3 servers
1175
1176         Reviewed by Ling Ho.
1177
1178         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1179
1180 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1181
1182         [Attachment Support] Create attachment elements when dropping files on iOS
1183         https://bugs.webkit.org/show_bug.cgi?id=181192
1184         <rdar://problem/36280945>
1185
1186         Reviewed by Tim Horton.
1187
1188         Adds 3 new API tests to exercise different use cases of dropping content as attachment elements when the runtime
1189         switch is enabled. See below for more details.
1190
1191         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1192         (-[NSItemProvider registerData:type:]):
1193         (platformCopyPNG):
1194         (TestWebKitAPI::TEST):
1195         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1196
1197         Fix some currently failing iOS drag and drop tests. In this case, there's no reason RTFD should appear in the
1198         source item provider when dragging rich text *without* attachments, so this should have been a check for just
1199         kUTTypeRTF instead.
1200
1201         (TestWebKitAPI::TEST):
1202
1203         Tests a few cases of inserting attachment elements via drop:
1204         1.  We should distinguish between drops containing rich/plain text files from just dropping rich/plain text.
1205             Instead of inserting the contents as inline web content, this should generate attachment elements.
1206         2.  Test the fallback mechanism for inserting attachment elements. If the preferred presentation style is not
1207             explicitly set, but there's nothing WebKit would otherwise do with the dropped content, then we should fall
1208             back to inserting the content as an attachment.
1209         3.  Test that if multiple attachments and inline item providers are present, WebKit will respect the order in
1210             which they were inserted by the source (as opposed to, for instance, putting all of the attachments in front
1211             or at the end).
1212
1213         * TestWebKitAPI/cocoa/TestWKWebView.h:
1214         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1215         (-[TestWKWebView objectByEvaluatingJavaScript:]):
1216
1217         Add a helper method to return an object that represents the result of evaluating some given script, and rewrite
1218         -stringByEvaluatingJavaScript to just turn around and call this.
1219
1220         (-[TestWKWebView stringByEvaluatingJavaScript:]):
1221
1222 2018-01-03  Ting-Wei Lan  <lantw44@gmail.com>
1223
1224         Replace hard-coded paths in shebangs with #!/usr/bin/env
1225         https://bugs.webkit.org/show_bug.cgi?id=181040
1226
1227         Reviewed by Alex Christensen.
1228
1229         * BuildSlaveSupport/build-launcher-app:
1230         * BuildSlaveSupport/build-launcher-dmg:
1231         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1232         * BuildSlaveSupport/built-product-archive:
1233         * BuildSlaveSupport/clean-build:
1234         * BuildSlaveSupport/delete-stale-build-files:
1235         * BuildSlaveSupport/download-built-product:
1236         * BuildSlaveSupport/gtk/buildbot/log/run:
1237         * BuildSlaveSupport/gtk/buildbot/run:
1238         * BuildSlaveSupport/gtk/pulseaudio/run:
1239         * BuildSlaveSupport/kill-old-processes:
1240         * BuildSlaveSupport/test-result-archive:
1241         * BuildSlaveSupport/win/kill-old-processes:
1242         * Scripts/SpacingHeuristics.pm:
1243         * Scripts/add-include:
1244         * Scripts/build-api-tests:
1245         * Scripts/build-dumprendertree:
1246         * Scripts/build-imagediff:
1247         * Scripts/build-jsc:
1248         * Scripts/build-webkit:
1249         * Scripts/build-webkittestrunner:
1250         * Scripts/check-Xcode-source-file-types:
1251         * Scripts/check-dom-results:
1252         * Scripts/check-for-exit-time-destructors:
1253         * Scripts/check-for-global-initializers:
1254         * Scripts/check-for-inappropriate-objc-class-names:
1255         * Scripts/check-for-weak-vtables-and-externals:
1256         * Scripts/clean-header-guards:
1257         * Scripts/compare-timing-files:
1258         * Scripts/configure-xcode-for-ios-development:
1259         * Scripts/copy-webkitlibraries-to-product-directory:
1260         * Scripts/create-exports:
1261         * Scripts/debug-minibrowser:
1262         * Scripts/debug-safari:
1263         * Scripts/debug-test-runner:
1264         * Scripts/do-file-rename:
1265         * Scripts/do-webcore-rename:
1266         * Scripts/dump-webkit-tests-run:
1267         * Scripts/ensure-valid-python:
1268         * Scripts/execAppWithEnv:
1269         * Scripts/extract-localizable-js-strings:
1270         * Scripts/filter-build-webkit:
1271         * Scripts/find-extra-includes:
1272         * Scripts/fix-blink-patch:
1273         * Scripts/generate-coverage-data:
1274         * Scripts/git-add-reviewer:
1275         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
1276         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
1277         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz:
1278         * Scripts/make-new-script-test:
1279         * Scripts/make-script-test-wrappers:
1280         * Scripts/package-root:
1281         * Scripts/parse-malloc-history:
1282         * Scripts/report-include-statistics:
1283         * Scripts/resolve-ChangeLogs:
1284         * Scripts/run-api-tests:
1285         * Scripts/run-bindings-tests:
1286         * Scripts/run-content-extension-tester:
1287         * Scripts/run-iexploder-tests:
1288         * Scripts/run-javascriptcore-tests:
1289         * Scripts/run-jsc:
1290         * Scripts/run-leaks:
1291         * Scripts/run-mangleme-tests:
1292         * Scripts/run-minibrowser:
1293         * Scripts/run-pageloadtest:
1294         * Scripts/run-regexp-tests:
1295         * Scripts/run-safari:
1296         * Scripts/run-sunspider:
1297         * Scripts/run-test-runner:
1298         * Scripts/run-webkit-app:
1299         * Scripts/run-webkit-httpd:
1300         * Scripts/run-webkit-websocketserver:
1301         * Scripts/set-webkit-configuration:
1302         * Scripts/show-pretty-diff:
1303         * Scripts/sort-Xcode-project-file:
1304         * Scripts/split-file-by-class:
1305         * Scripts/sunspider-compare-results:
1306         * Scripts/svn-apply:
1307         * Scripts/svn-unapply:
1308         * Scripts/test-webkit-scripts:
1309         * Scripts/test-webkitperl:
1310         * Scripts/update-iexploder-cssproperties:
1311         * Scripts/update-javascriptcore-test-results:
1312         * Scripts/update-webkit:
1313         * Scripts/update-webkit-auxiliary-libs:
1314         * Scripts/update-webkit-dependency:
1315         * Scripts/update-webkit-libs-jhbuild:
1316         * Scripts/update-webkit-localizable-strings:
1317         * Scripts/update-webkit-support-libs:
1318         * Scripts/update-webkitgtk-libs:
1319         * Scripts/update-webkitwpe-libs:
1320         * Scripts/webkit-build-directory:
1321         * Scripts/webkitperl/LoadAsModule.pm:
1322         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
1323         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
1324         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl:
1325         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl:
1326         * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl:
1327         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
1328         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
1329         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
1330         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
1331         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
1332         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl:
1333         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
1334         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl:
1335         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
1336         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
1337         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
1338         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
1339         * Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl:
1340         * Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl:
1341         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl:
1342         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl:
1343         * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl:
1344         * Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl:
1345         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl:
1346         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
1347         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
1348         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl:
1349         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl:
1350         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
1351         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
1352         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
1353         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
1354         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl:
1355         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl:
1356         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl:
1357         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
1358         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
1359         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
1360         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl:
1361         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
1362         * ccache/ccache-clang:
1363         * ccache/ccache-clang++:
1364         * ccache/ccache-wrapper:
1365         * gtk/install-dependencies:
1366         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi:
1367         * iExploder/iexploder-1.3.2/htdocs/webserver.rb:
1368         * iExploder/iexploder-1.3.2/tools/lasthit.rb:
1369         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb:
1370         * iExploder/iexploder-1.3.2/tools/showtest.rb:
1371         * iExploder/iexploder-1.7.2/src/browser_harness.rb:
1372         * iExploder/iexploder-1.7.2/src/iexploder.cgi:
1373         * iExploder/iexploder-1.7.2/src/webserver.rb:
1374         * iExploder/iexploder-1.7.2/tools/lasthit.rb:
1375         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb:
1376         * wpe/install-dependencies:
1377
1378 2018-01-03  Simon Fraser  <simon.fraser@apple.com>
1379
1380         filter-build-webkit filters out useful compiler error lines
1381         https://bugs.webkit.org/show_bug.cgi?id=179864
1382
1383         Reviewed by Tim Horton.
1384
1385         Don't filter out lines that contain information about build errors by always showing lines
1386         after a line that contains "note:" or "error:".
1387
1388         * Scripts/filter-build-webkit:
1389         (shouldShowSubsequentLine):
1390         (shouldIgnoreLine):
1391
1392 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1393
1394         REGRESSION(r226366): [GTK] Broke TestBackForwardList and TestWebKitWebView
1395         https://bugs.webkit.org/show_bug.cgi?id=173915
1396
1397         Unreviewed follow-up. Fix /webkit2/WebKitWebView/session-state-with-form-data and
1398         /webkit2/WebKitWebView/submit-form. The form ID may be NULL, but we can't put NULL into a
1399         GVariant unless we use maybe types, and maybe types are incompatible with D-Bus. So use an
1400         empty string in this case.
1401
1402         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1403         (emitFormSubmissionEvent):
1404
1405 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1406
1407         [GTK] Add web process API to detect when form is submitted via JavaScript
1408         https://bugs.webkit.org/show_bug.cgi?id=173915
1409
1410         Reviewed by Carlos Garcia Campos.
1411
1412         Test it.
1413
1414         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1415         (FormSubmissionTest::FormSubmissionTest):
1416         (FormSubmissionTest::~FormSubmissionTest):
1417         (FormSubmissionTest::testFormSubmissionResult):
1418         (FormSubmissionTest::willSendDOMEventCallback):
1419         (FormSubmissionTest::willCompleteCallback):
1420         (FormSubmissionTest::runJavaScriptAndWaitUntilFormSubmitted):
1421         (testWebExtensionFormSubmissionSteps):
1422         (beforeAll):
1423         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1424         (DelayedSignal::DelayedSignal):
1425         (emitFormSubmissionEvent):
1426         (handleFormSubmissionCallback):
1427         (willSubmitFormCallback):
1428         (pageCreatedCallback):
1429
1430 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1431
1432         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/databases
1433         https://bugs.webkit.org/show_bug.cgi?id=181251
1434
1435         * Scripts/run-gtk-tests:
1436         (GtkTestRunner):
1437
1438 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1439
1440         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/ephemeral
1441         https://bugs.webkit.org/show_bug.cgi?id=181136
1442
1443         * Scripts/run-gtk-tests:
1444         (GtkTestRunner):
1445
1446 2018-01-02  Brent Fulgham  <bfulgham@apple.com>
1447
1448         [macOS, iOS] Adopt new secure coding APIs in WebKit
1449         https://bugs.webkit.org/show_bug.cgi?id=181085
1450         <rdar://problem/34837397>
1451
1452         Reviewed by Tim Horton.
1453
1454         Update API tests to use secure coding wherever possible. Currently, NSView/UIView-based classes are not
1455         capable of supporting NSSecureCoding, so pass through the current coding routines.
1456
1457         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Updated for NSSecureCoding.
1458         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
1459         (encodeAndDecode): Check if class supports the NSSecureCoding protocol and use non-secure coding
1460         routines if necessary.
1461         (TEST): Updated for NSSecureCoding.
1462         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm:
1463         (TestWebKitAPI::TEST): Updated for NSSecureCoding.
1464
1465 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
1466
1467         Remove std::chrono completely
1468         https://bugs.webkit.org/show_bug.cgi?id=181186
1469
1470         Reviewed by Alex Christensen.
1471
1472         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1473         (WTR::TestController::platformRunUntil):
1474
1475 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1476
1477         REGRESSION(r223253): Broke ResourceLoadStatistics layout tests for non-Cocoa ports
1478         https://bugs.webkit.org/show_bug.cgi?id=181231
1479
1480         Reviewed by Alex Christensen.
1481
1482         Implement TestController APIs needed by ResourceLoadStatistics tests.
1483
1484         * WebKitTestRunner/TestController.cpp:
1485         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
1486         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
1487
1488 2018-01-02  Tim Horton  <timothy_horton@apple.com>
1489
1490         Disable WKAttachmentTests if UIPasteboard.itemProviders is not available
1491         https://bugs.webkit.org/show_bug.cgi?id=181219
1492
1493         Reviewed by Wenson Hsieh.
1494
1495         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1496
1497 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1498
1499         Add a WebAuthentication runtime feature flag
1500         https://bugs.webkit.org/show_bug.cgi?id=181220
1501         <rdar://problem/36055305>
1502
1503         Reviewed by Brent Fulgham.
1504
1505         Renames the CredentialManagement runtime feature flag into WebAuthentication.
1506
1507         * DumpRenderTree/TestOptions.h:
1508         * DumpRenderTree/TestOptions.mm:
1509         (TestOptions::TestOptions):
1510         * DumpRenderTree/mac/DumpRenderTree.mm:
1511         (enableExperimentalFeatures):
1512         (setWebPreferencesForTestOptions):
1513         * WebKitTestRunner/TestController.cpp:
1514         (WTR::TestController::resetPreferencesToConsistentValues):
1515         (WTR::updateTestOptionsFromTestHeader):
1516         * WebKitTestRunner/TestOptions.h:
1517         (WTR::TestOptions::hasSameInitializationOptions const):
1518
1519 2018-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1520
1521         [Attachment Support] Don't Blob-convert images and attachments with https:, http: or data: urls
1522         https://bugs.webkit.org/show_bug.cgi?id=181143
1523         <rdar://problem/36200381>
1524
1525         Reviewed by Tim Horton.
1526
1527         Add a new API test to ensure that a copied image with a data URL does not get pasted as an attachment when
1528         attachment elements are enabled.
1529
1530         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1531         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1532         (TestWebKitAPI::TEST):
1533
1534 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1535
1536         Update Credential Management API for WebAuthentication
1537         https://bugs.webkit.org/show_bug.cgi?id=181082
1538         <rdar://problem/36055239>
1539
1540         Reviewed by Brent Fulgham.
1541
1542         Enable Credential Management API for testing.
1543
1544         * DumpRenderTree/TestOptions.h:
1545         * WebKitTestRunner/TestOptions.h:
1546
1547 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1548
1549         [GTK] Test /webkit2/WebKitWebExtension/form-controls-associated-signal is flaky
1550         https://bugs.webkit.org/show_bug.cgi?id=168194
1551
1552         Reviewed by Carlos Garcia Campos.
1553
1554         Fix an assertion and unskip the test. The order that form controls are associated is not
1555         guaranteed.
1556
1557         * Scripts/run-gtk-tests:
1558         (GtkTestRunner):
1559         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1560         (didAssociateFormControlsCallback):
1561
1562 2018-01-02  Alex Christensen  <achristensen@webkit.org>
1563
1564         Use new WebsiteDataStore passed in through decidePolicyForNavigation SPI
1565         https://bugs.webkit.org/show_bug.cgi?id=180897
1566         <rdar://problem/35535328>
1567
1568         Reviewed by Brent Fulgham.
1569
1570         Test two forms of storage to be sure we are using a different WebsiteDataStore: cookies and sessionStorage.
1571
1572         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1573         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1574         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:]):
1575         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1576         (websiteDataStoreTestWebView):
1577         (TEST):
1578
1579 == Rolled over to ChangeLog-2018-01-01 ==