* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde...
[WebKit-https.git] / Tools / ChangeLog
1 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2
3         Rubber stamped by Csaba Osztrogonac
4
5         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
6
7 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
8
9         Reviewed by Tony Chang.
10
11         new-run-webkit-tests: add a --build-directory command line argument
12
13         Official Google Chrome builds use a non-standard build directory
14         location. This patch adds a --build-directory argument that
15         allows that location to be specified on the command line. Only
16         Chromium-based builds will use this flag for now, but anyone can
17         in the future.
18
19         There are no unit tests for this since it's difficult to test
20         until mock filesystems are fully supported in the code. This was
21         tested by hand for now.
22
23         https://bugs.webkit.org/show_bug.cgi?id=52694
24
25         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
26         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
27         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
28         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
29
30 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
31
32         Not reviewed. Bot fix.
33
34         Remove an inadvertently committed debugging print.
35
36         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
37         (LayoutTestController::notifyDone):
38
39 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
40
41         Reviewed by Sam Weinig.
42
43         WebKitTestRunner should track loading more like DumpRenderTree
44         https://bugs.webkit.org/show_bug.cgi?id=52692
45
46         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
47         This makes some tests that call notifyDone multiple times pass.
48         
49         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
50         (WTR::InjectedBundle::InjectedBundle):
51         (WTR::InjectedBundle::done):
52         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
53         (WTR::InjectedBundle::topLoadingFrame):
54         (WTR::InjectedBundle::setTopLoadingFrame):
55         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
56         (WTR::InjectedBundlePage::InjectedBundlePage):
57         (WTR::InjectedBundlePage::stopLoading):
58         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
59         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
60         (WTR::InjectedBundlePage::didFinishLoadForFrame):
61         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
62         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
63         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
64         (WTR::LayoutTestController::notifyDone):
65         * WebKitTestRunner/TestController.cpp:
66         (WTR::TestController::didReceiveMessageFromInjectedBundle):
67
68 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
69
70         Reviewed by Kent Tamura.
71
72         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
73         https://bugs.webkit.org/show_bug.cgi?id=52678
74         
75         Update path now that WebKit is inside Source.
76
77         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
78
79 2011-01-18  Robert Hogan  <robert@webkit.org>
80
81         Reviewed by Simon Hausmann.
82
83         [Qt] http/tests/incremental/slow-utf8-text.pl fails
84         https://bugs.webkit.org/show_bug.cgi?id=44282
85
86         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
87         (WebCore::DumpRenderTree::dump):
88
89 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
90
91         Reviewed by Mihai Parparita.
92
93         Fix a small race condition that could cause the unit tests for
94         new-run-webkit-tests to fail in a multithreaded environment.
95         There was a small window in the code where one thread would
96         check to see if a thread had raised an exception, do something,
97         and then check to see if the thread was alive. If the other
98         thread raised an exception and exited in between these two
99         steps, the exception would be lost. Flipping the order of the
100         two checks fixes the race, since we will now always check for an
101         exception on the thread before exiting.
102
103         https://bugs.webkit.org/show_bug.cgi?id=51579
104
105         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
106
107 2011-01-18  Eric Seidel  <eric@webkit.org>
108
109         Reviewed by Adam Barth.
110
111         commit-queue dies when test archiving fails
112         https://bugs.webkit.org/show_bug.cgi?id=52617
113
114         I looked at the machine and it had 10 archives already
115         thus find_unused_name was returning None.  I've upped
116         the limit to 100 (per bug) and tested the case where
117         find_unused_name returns None (making archive return None).
118
119         * Scripts/webkitpy/common/system/workspace.py:
120         * Scripts/webkitpy/common/system/workspace_unittest.py:
121         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
122         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
123         * Scripts/webkitpy/tool/commands/queues.py:
124
125 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
126
127         Reviewed by Ojan Vafai.
128
129         Update rebaseline-chromium-webkit-tests unit tests to use a mock
130         filesystem. Also fix a couple of "with" statements missed by
131         r76050.
132
133         https://bugs.webkit.org/show_bug.cgi?id=52487
134
135         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
136
137 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
138
139         Reviewed by Martin Robinson.
140
141         [Gtk] Build fixes for gtk3 build
142         https://bugs.webkit.org/show_bug.cgi?id=52648
143
144         * DumpRenderTree/gtk/EventSender.cpp:
145         (beginDragWithFilesCallback):
146
147 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
148
149         Reviewed by Mihai Parparita.
150
151         Update rebaseline-chromium-webkit-tests to use filesystem objects
152         instead of direct references to os.path, shutil, tempfile, etc.
153
154         This patch doesn't change anything, but will allow subsequent
155         patches to change the unit tests to no longer use the real
156         filesystem.
157
158         This patch adds a bunch more methods to the filesystem object as
159         well.
160
161         https://bugs.webkit.org/show_bug.cgi?id=52482
162
163         * Scripts/webkitpy/common/system/filesystem.py:
164         * Scripts/webkitpy/common/system/filesystem_mock.py:
165         * Scripts/webkitpy/tool/commands/queues.py:
166         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
167         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
168
169 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
170
171         Reviewed by Mihai Parparita.
172
173         new-run-webkit-tests shouldn't crash when you try to run a
174         directory containing only skipped files.
175
176         https://bugs.webkit.org/show_bug.cgi?id=52478
177         
178         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
179         * Scripts/webkitpy/layout_tests/port/test.py:
180         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
181
182 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
183
184         Reviewed by Gustavo Noronha Silva.
185
186         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
187         https://bugs.webkit.org/show_bug.cgi?id=40833
188
189         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
190         GTK+ event sender.
191         (dragWithFilesDragDataGetCallback): Added.
192         (dragWithFilesDragEndCallback): Added.
193         (beginDragWithFilesCallback): Added.
194
195 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
196
197         Reviewed by Adam Barth.
198
199         ews: Add additional watcher to efl ews
200         https://bugs.webkit.org/show_bug.cgi?id=52613
201
202         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
203
204         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
205
206 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
207
208         Reviewed by Alexey Proskuryakov.
209
210         Fix some headers with missing or misspelled #ifndef guards
211         https://bugs.webkit.org/show_bug.cgi?id=52545
212
213         * DumpRenderTree/chromium/TestEventPrinter.h:
214         * DumpRenderTree/chromium/WebPreferences.h:
215
216 2011-01-17  Jessie Berlin  <jberlin@apple.com>
217
218         Reviewed by Anders Carlsson.
219
220         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
221         navigating back to an unreachable URL
222         https://bugs.webkit.org/show_bug.cgi?id=52388
223
224         Add a third parameter (unreachableURL) to queueLoadHTMLString.
225
226         * DumpRenderTree/LayoutTestController.cpp:
227         (queueLoadHTMLStringCallback):
228         (LayoutTestController::queueLoadHTMLString):
229         (LayoutTestController::queueLoadAlternateHTMLString):
230         * DumpRenderTree/LayoutTestController.h:
231
232         * DumpRenderTree/WorkQueueItem.h:
233         (LoadHTMLStringItem::LoadHTMLStringItem):
234
235         * DumpRenderTree/chromium/LayoutTestController.cpp:
236         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
237         (WorkItemLoadHTMLString::run):
238         (LayoutTestController::queueLoadHTMLString):
239
240         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
241         (LoadHTMLStringItem::invoke):
242         * DumpRenderTree/mac/WorkQueueItemMac.mm:
243         (LoadHTMLStringItem::invoke):
244         * DumpRenderTree/win/WorkQueueItemWin.cpp:
245         (LoadHTMLStringItem::invoke):
246
247 2011-01-17  Dan Bernstein  <mitz@apple.com>
248
249         Rubber-stamped by Mark Rowe.
250
251         Update xcodeproj svn:ignore to include xcuserdata.
252
253         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
254         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
255         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
256         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
257         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
258
259 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
260
261         Unreviewed fix after r75908.
262
263         Move WebKit into Source
264         https://bugs.webkit.org/show_bug.cgi?id=52530
265
266         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
267
268 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
269
270         Unreviewed.
271
272         Remove accidentally committed debug printing after r75908.
273
274         * Scripts/webkitdirs.pm:
275
276 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
277
278         Unreviewed.
279
280         Add myself to committers list
281         https://bugs.webkit.org/show_bug.cgi?id=52566
282
283         * Scripts/webkitpy/common/config/committers.py:
284
285 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
286
287         Reviewed by Jeremy Orlow.
288
289         GeolocationController should call stopUpdating on destruction
290         https://bugs.webkit.org/show_bug.cgi?id=52216
291
292         fast/dom/Geolocation/window-close-crash.html requires that a
293         Geolocation watch be started in a secondary window. Consequently,
294         we need to allow geolocation permission and provide a mock
295         geolocation position for the secondary window's
296         GeolocationClientMock.
297
298         * DumpRenderTree/chromium/LayoutTestController.cpp:
299         (LayoutTestController::setGeolocationPermission):
300         (LayoutTestController::setMockGeolocationPosition):
301         (LayoutTestController::setMockGeolocationError):
302         * DumpRenderTree/chromium/TestShell.h:
303         (TestShell::windowList):
304
305 2011-01-16  Adam Barth  <abarth@webkit.org>
306
307         Update more include paths to reflect WebKit move.
308
309         * DumpRenderTree/chromium/EventSender.cpp:
310         (EventSender::keyDown):
311         (EventSender::needsShiftModifier):
312         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
313         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
314
315 2011-01-16  Kent Tamura  <tkent@chromium.org>
316
317         Unreviewed, Chromium build fix.
318
319         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
320
321 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
322
323         Build fix for GTK+ after source directory movement.
324
325         * GNUmakefile.am: Correct include paths.
326
327 2011-01-16  Adam Barth  <abarth@webkit.org>
328
329         Teach svn-apply about WebKit move.
330
331         * Scripts/VCSUtils.pm:
332
333 2011-01-16  Adam Barth  <abarth@webkit.org>
334
335         Rubber-stamped by Eric Seidel.
336
337         Move WebKit into Source
338         https://bugs.webkit.org/show_bug.cgi?id=52530
339
340         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
341         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
342         * DumpRenderTree/qt/DumpRenderTreeQt.h:
343         * DumpRenderTree/qt/GCControllerQt.cpp:
344         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
345         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
346         * DumpRenderTree/qt/TextInputControllerQt.cpp:
347         * DumpRenderTree/wscript:
348         * QtTestBrowser/launcherwindow.h:
349         * Scripts/build-webkit:
350         * Scripts/webkitdirs.pm:
351
352 2011-01-15  Adam Barth  <abarth@webkit.org>
353
354         Teach svn-apply about WebKit2 move.
355
356         * Scripts/VCSUtils.pm:
357
358 2011-01-15  Adam Barth  <abarth@webkit.org>
359
360         Rubber-stamped by Eric Seidel.
361
362         Move WebKit2 into Source
363         https://bugs.webkit.org/show_bug.cgi?id=52438
364
365         * MiniBrowser/qt/MiniBrowser.pro:
366         * Scripts/build-webkit:
367         * Scripts/do-file-rename:
368         * Scripts/do-webcore-rename:
369         * Scripts/test-webkitpy:
370         * Scripts/webkitdirs.pm:
371         * Scripts/webkitpy/style/checker.py:
372         * WebKitTestRunner/DerivedSources.pro:
373         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
374         * WebKitTestRunner/qt/WebKitTestRunner.pro:
375
376 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
377
378         Reviewed by David Levin.
379
380         [chromium] remove obsolete createView method
381         https://bugs.webkit.org/show_bug.cgi?id=52437
382
383         * DumpRenderTree/chromium/WebViewHost.cpp:
384         (WebViewHost::createView):
385         * DumpRenderTree/chromium/WebViewHost.h:
386
387 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
388
389         Reviewed by Geoff Garen.
390
391         ShouldLoadResourceForFrame should use strings, not URLs.
392         https://bugs.webkit.org/show_bug.cgi?id=52476
393
394         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
395         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
396         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
397
398 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
399
400         Reviewed by David Levin.
401
402         Add Tony Gentilcore as a reviewer
403         https://bugs.webkit.org/show_bug.cgi?id=52480
404
405         * Scripts/webkitpy/common/config/committers.py:
406
407 2011-01-14  David Levin  <levin@chromium.org>
408
409         Reviewed by Eric Seidel.
410
411         check-webkit-style: _FunctionState should keep track of where the function name starts.
412         https://bugs.webkit.org/show_bug.cgi?id=52454
413
414         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
415         _FunctionState and logic for setting it correctly.
416         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
417
418 2011-01-14  Vincent Scheib  <scheib@chromium.org>
419
420         Reviewed by David Levin.
421
422         Add support to DumpRenderTree to use the GPU rather than software renderer
423         https://bugs.webkit.org/show_bug.cgi?id=52333
424
425         * DumpRenderTree/chromium/DumpRenderTree.cpp:
426         (main):
427         * Scripts/webkitpy/layout_tests/port/chromium.py:
428         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
429
430 2011-01-14  Tony Chang  <tony@chromium.org>
431
432         Reviewed by Kent Tamura.
433
434         [chromium] update fonts.conf to fix 6 linux tests in drt
435         https://bugs.webkit.org/show_bug.cgi?id=52411
436
437         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
438             chromium's src/webkit/tools/test_shell/resources/fonts.conf
439
440 2011-01-14  Eric Seidel  <eric@webkit.org>
441
442         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
443
444         Reviewed by Adam Barth.
445
446         Fix when running Tools/Scripts/check-webkit-style without arguments.
447         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
448
449         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
450         * Scripts/webkitpy/common/checkout/scm_unittest.py:
451
452 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
453
454         Reviewed by David Levin.
455
456         Store the tempdir object in a variable so it doesn't get deleted too early.
457         https://bugs.webkit.org/show_bug.cgi?id=51875
458
459         * Scripts/update-webkit-auxiliary-libs:
460         * Scripts/update-webkit-support-libs:
461
462 2011-01-14  Eric Seidel  <eric@webkit.org>
463
464         Unreviewed.  Make it work in python 2.5.
465
466         webkit-patch suggest-reviewers dies when ChangeLogs are missing
467         https://bugs.webkit.org/show_bug.cgi?id=49158
468
469         * Scripts/webkitpy/common/checkout/api_unittest.py:
470
471 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
472
473         Unreviewed, rolling out r75774.
474         http://trac.webkit.org/changeset/75774
475         https://bugs.webkit.org/show_bug.cgi?id=52431
476
477         gtk builds were broken (Requested by loislo2 on #webkit).
478
479         * Scripts/webkitpy/common/checkout/scm.py:
480
481 2011-01-14  David Levin  <levin@chromium.org>
482
483         Reviewed by Shinichiro Hamaji.
484
485         check-webkit-style: _FunctionState should detect pure functions.
486         https://bugs.webkit.org/show_bug.cgi?id=52428
487
488         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
489         is a pure virtual function.
490         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
491         virtual functions are correctly detected.
492
493 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
494
495         Reviewed by Yury Semikhatsky.
496
497         Just small fix for problem with check-webkit-style.
498         It just didn't work for this patch.
499         Old code can't concatenate a list of strings with None.
500
501         * Scripts/webkitpy/common/checkout/scm.py:
502
503 2011-01-13  David Levin  <levin@chromium.org>
504
505         Reviewed by Shinichiro Hamaji.
506
507         check-webkit-style: _FunctionState should use Position to know where items are.
508         https://bugs.webkit.org/show_bug.cgi?id=52424
509
510         * Scripts/webkitpy/style/checkers/cpp.py:
511         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
512         (detect_functions): Changed to pass Position's to _FunctionState.begin and
513         did some minor clean-up.
514         (*): Other changes are simply about converting to use the Position's in_FunctionState
515         instead of line numbers.
516         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
517         to verify the positions stored in _FunctionState.
518
519 2011-01-13  Eric Seidel  <eric@webkit.org>
520
521         Reviewed by David Levin.
522
523         webkit-patch suggest-reviewers dies when ChangeLogs are missing
524         https://bugs.webkit.org/show_bug.cgi?id=49158
525
526         This is not the most elegant, but it is a very safe fix to this bug.
527         One advantage of catching ScriptError like this instead of adding a
528         new added_or_modified_files or fixing all changed_files callers
529         to use a more specific change_files variant, is that we catch
530         all kinds of ScriptErrors which might cause our (non-essential)
531         suggest-reviewers code to fail out.  This should make passing
532         --suggest-reviewers to webkit-patch upload much more robust
533         and may even make it possible for us to make it default.
534
535         The root of the problem here is that SCM.changed_files includes
536         deleted ChangeLog paths (from moves, etc) which then when we ask
537         SVN/Git for the contents of the file at that revision, the command
538         errors out and Executive.run_command raises a ScriptError.
539
540         In the future we might fix this differently by making all current
541         callers of chagned_files use a more specific method for requesting
542         what types of changes they're interested in (adds, modifies, deletes, etc.)
543
544         * Scripts/webkitpy/common/checkout/api.py:
545         * Scripts/webkitpy/common/checkout/api_unittest.py:
546
547 2011-01-13  Dan Bernstein  <mitz@apple.com>
548
549         Reviewed by Alexey Proskuryakov.
550
551         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
552         https://bugs.webkit.org/show_bug.cgi?id=52419
553
554         Allow to further control the behavior of the willSendRequest delegate callback by making it
555         set a different URL in the new request.
556
557         * DumpRenderTree/LayoutTestController.cpp:
558         (addURLToRedirectCallback): Added.
559         (LayoutTestController::staticFunctions): Added addURLToRedirect.
560         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
561         (LayoutTestController::redirectionDestinationForURL): Added this getter.
562         * DumpRenderTree/LayoutTestController.h:
563         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
564         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
565         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
566         change the URL in the new request to the redirect destination.
567
568 2011-01-13  Eric Seidel  <eric@webkit.org>
569
570         Reviewed by Mihai Parparita.
571
572         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
573         https://bugs.webkit.org/show_bug.cgi?id=52416
574
575         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
576         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
577
578         I also added FIXMEs about the changed_files returning deleted files problem
579         which is causing the other most common exception for suggest-reviewers
580         (and is probably breaking sheriff-bots blame detection).
581
582         * Scripts/webkitpy/common/checkout/api.py:
583         * Scripts/webkitpy/common/checkout/api_unittest.py:
584         * Scripts/webkitpy/common/checkout/scm.py:
585
586 2011-01-13  Eric Seidel  <eric@webkit.org>
587
588         Reviewed by Adam Barth.
589
590         results archives from commit-queue are too large to upload
591         https://bugs.webkit.org/show_bug.cgi?id=52405
592
593         * Scripts/webkitpy/common/system/filesystem.py:
594         * Scripts/webkitpy/common/system/filesystem_mock.py:
595         * Scripts/webkitpy/tool/commands/queues.py:
596
597 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
598
599         Reviewed by Martin Robinson.
600
601         [gtk] Zero-sized font does not yet work
602         https://bugs.webkit.org/show_bug.cgi?id=49793
603
604         Set minimum-font-size to 0 for the DRT.
605
606         * DumpRenderTree/gtk/DumpRenderTree.cpp:
607         (resetDefaultsToConsistentValues):
608
609 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
610
611         Reviewed by Darin Adler.
612
613         Make old-run-webkit-tests more robust on buildbots
614         https://bugs.webkit.org/show_bug.cgi?id=52364
615
616         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
617
618 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
619
620         Reviewed by Darin Adler.
621
622         Make old-run-webkit-tests more robust on buildbots
623         https://bugs.webkit.org/show_bug.cgi?id=52364
624
625         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
626
627 2011-01-13  Tony Chang  <tony@chromium.org>
628
629         Reviewed by Kent Tamura.
630
631         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
632         https://bugs.webkit.org/show_bug.cgi?id=52332
633
634         Forked Info.plist is not longer needed.
635
636         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
637
638 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
639
640         Reviewed by Timothy Hatcher.
641
642         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
643         to be passed directly to WebInspector.UIString
644
645         https://bugs.webkit.org/show_bug.cgi?id=52365
646
647         * Scripts/check-inspector-strings:
648
649 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
650
651         Unreviewed, rolling out r74881.
652         http://trac.webkit.org/changeset/74881
653         https://bugs.webkit.org/show_bug.cgi?id=52357
654
655         The EFL builder has been red for days (Requested by abarth on
656         #webkit).
657
658         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
659         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
660
661 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
662
663         Reviewed by David Levin.
664
665         Add beforeunload support to WebKitTestRunner
666         https://bugs.webkit.org/show_bug.cgi?id=52353
667         
668         This makes a number of currently failing tests pass.
669
670         * WebKitTestRunner/TestController.cpp:
671         (WTR::runBeforeUnloadConfirmPanel):
672         (WTR::createOtherPage):
673         (WTR::TestController::initialize):
674
675 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
676
677         Reviewed by Sam Weinig.
678
679         Detect, identify and recover from WebProcess crashes in run-webkit-tests
680         https://bugs.webkit.org/show_bug.cgi?id=52330
681
682         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
683         a web process crash.
684         * WebKitTestRunner/TestController.cpp:
685         (WTR::TestController::initialize): Set up a processDidCrash
686         callback.
687         (WTR::TestController::processDidCrash): Report that the Web process
688         crashed.
689         * WebKitTestRunner/TestController.h:
690
691 2011-01-12  David Levin  <levin@chromium.org>
692
693         Reviewed by Shinichiro Hamaji.
694
695         check-webkit-style -- close_expression function doesn't work correctly.
696         https://bugs.webkit.org/show_bug.cgi?id=52272
697
698         * Scripts/webkitpy/style/checkers/cpp.py:
699         (Position.__str__): Added a way to convert it to a string which is useful in tests.
700         (Position.__cmp__): Added a way to compare Position which is useful in tests and
701         generally useful (for upcoming code changes).
702         (close_expression): Changed to use Position for input and output.
703         Also, fixed many bugs such as only working correctly for parenthesis,
704         not working correctly if given an offset in a line and not finding
705         the real closing element if there were multiple closing elements in
706         the same line.
707         (detect_functions): Adjusted due to the change in arguments for
708         close_expression.
709         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
710         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
711         two positions are the same.
712         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
713         (CppStyleTest.test_close_expression): Added tests to catch the issues
714         that were fixed.
715
716 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
717
718         Unreviewed, rolling out r75576.
719         http://trac.webkit.org/changeset/75576
720         https://bugs.webkit.org/show_bug.cgi?id=52304
721
722         broke rebaseline-chromium-webkit-test (Requested by thakis on
723         #webkit).
724
725         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
726         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
727         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
728         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
729         * Scripts/webkitpy/layout_tests/port/base.py:
730         * Scripts/webkitpy/layout_tests/port/chromium.py:
731         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
732         * Scripts/webkitpy/layout_tests/port/test.py:
733         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
734         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
735         * Scripts/webkitpy/style/checkers/test_expectations.py:
736         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
737
738 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
739
740         Reviewed by Darin Adler.
741
742         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
743         https://bugs.webkit.org/show_bug.cgi?id=52307
744
745         * Scripts/old-run-webkit-tests:
746
747 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
748
749         Reviewed by Martin Robinson.
750
751         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
752         https://bugs.webkit.org/show_bug.cgi?id=50867
753
754         Fixed library extention for Mac in webkitdirs.pm and type conflict in
755         TestNetscapePlugin.cpp 
756
757         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
758         * Scripts/webkitdirs.pm:
759
760 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
761
762         Reviewed by Pavel Feldman.
763
764         Add check-inspector-strings script.
765
766         https://bugs.webkit.org/show_bug.cgi?id=52295
767
768         * Scripts/check-inspector-strings: Added.
769
770 2011-01-12  Adam Roben  <aroben@apple.com>
771
772         Advertise the .testnetscape file extension on Windows
773
774         Fixes <http://webkit.org/b/52298>
775         plugins/no-mime-with-valid-extension.html fails on Windows
776
777         Reviewed by Dan Bernstein.
778
779         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
780         FileExtents field to map the .testnetscape file extension to the
781         application/x-webkit-test-netscape MIME type, just as we do on Mac.
782
783 2011-01-12  Adam Barth  <abarth@webkit.org>
784
785         Reviewed by Eric Seidel.
786
787         Make webkit-patch support subdirectories for SVN checkouts
788         https://bugs.webkit.org/show_bug.cgi?id=52261
789
790         os.relpath does not exist on Python 2.5, so we need to call our version
791         of the API.
792
793         * Scripts/webkitpy/common/checkout/scm.py:
794
795 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
796
797         Reviewed by Eric Seidel.
798
799         Close additional pages opened during a test once the test completes.
800         https://bugs.webkit.org/show_bug.cgi?id=52276
801
802         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
803         (WTR::InjectedBundle::done):
804
805 2011-01-11  David Levin  <levin@chromium.org>
806
807         Reviewed by Eric Seidel.
808
809         Errors should be separated from the command line in bot messages.
810         https://bugs.webkit.org/show_bug.cgi?id=52275
811
812         * Scripts/webkitpy/common/system/executive.py:
813         (ScriptError.message_with_output): Added a newline to separate the command
814         line from the errors.
815         * Scripts/webkitpy/common/system/executive_unittest.py:
816         (ScriptErrorTest.test_message_with_output): Added tests for the various code
817         paths in message_with_output.
818
819 2011-01-11  Eric Seidel  <eric@webkit.org>
820
821         Unreviewed.
822
823         commit-queue should know how to upload archived results (for test flakes or general failures)
824         https://bugs.webkit.org/show_bug.cgi?id=52048
825
826         The zips are mostly empty due to forgetting -r.
827         Expected diffs were not being pulled from the archive due
828         to the archive having longer paths than I realized.
829
830         * Scripts/webkitpy/common/system/workspace.py:
831         * Scripts/webkitpy/common/system/workspace_unittest.py:
832         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
833         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
834
835 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
836
837         Reviewed by Ojan Vafai.
838
839         The current modifier parsing code in test_expectations is
840         fragile and hard-coded, so it's not easy to understand the logic
841         or easily add new types of modifiers (like GPU vs. CPU testing
842         for graphics tests, or 32-bit vs. 64-bit differences).
843
844         This is the first of two patches that will add in more generic
845         support and then eliminate the GPU-specific test expectations
846         files for Chromium.
847
848         This patch adds two standalone objects for handling modifiers. The
849         rules for interpreting modifiers, precedence, and conflicts are
850         given in the docstring to the ModifierMatcher class, which
851         returns ModifierMatchResult objects.
852         
853         This patch also adds routines to the Port interface and a
854         default set of values in the base object, in order to obtain the
855         values needed on a given test run. These values are then passed
856         to the expectation parser. This also allows us to clean up the
857         logic used to lint all of the different configurations in a
858         single test_expectations.txt file.
859
860         The next patch will merge in the separate GPU expectations file.
861
862         https://bugs.webkit.org/show_bug.cgi?id=51222
863
864         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
865         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
866         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
867         * Scripts/webkitpy/layout_tests/port/base.py:
868         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
869         * Scripts/webkitpy/layout_tests/port/chromium.py:
870         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
871         * Scripts/webkitpy/layout_tests/port/test.py:
872         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
873         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
874
875 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
876
877         Reviewed by Adam Barth.
878
879         Make webkit-patch support subdirectories for SVN checkouts
880         https://bugs.webkit.org/show_bug.cgi?id=52261
881
882         * Scripts/webkitpy/common/checkout/scm.py:
883         * Scripts/webkitpy/style_references.py:
884         * Scripts/webkitpy/tool/main.py:
885         * Scripts/webkitpy/tool/steps/preparechangelog.py:
886
887 2011-01-11  Eric Seidel  <eric@webkit.org>
888
889         Unreviewed.
890
891         commit-queue should know how to upload archived results (for test flakes or general failures)
892         https://bugs.webkit.org/show_bug.cgi?id=52048
893
894         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
895         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
896
897         * Scripts/webkitpy/common/system/workspace.py:
898         * Scripts/webkitpy/common/system/workspace_unittest.py:
899         * Scripts/webkitpy/tool/commands/queues.py:
900
901 2011-01-11  Sam Weinig  <sam@webkit.org>
902
903         Roll r75474 back in.
904
905 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
906
907         Reviewed by Kenneth Rohde Christiansen.
908
909         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
910         https://bugs.webkit.org/show_bug.cgi?id=51204
911
912         * QtTestBrowser/webpage.h:
913         (QtNAMThread::QtNAMThread):
914         (QtNAMThread::networkAccessManager):
915         (QtNAMThread::run):
916
917 2011-01-11  Peter Varga  <pvarga@webkit.org>
918
919         Unreviewed.
920
921         Add myself to committers' list.
922
923         * Scripts/webkitpy/common/config/committers.py:
924
925 2011-01-11  Eric Seidel  <eric@webkit.org>
926
927         Reviewed by Adam Barth.
928
929         commit-queue should know how to upload archived results (for test flakes or general failures)
930         https://bugs.webkit.org/show_bug.cgi?id=52048
931
932         Now the queue will always upload results.  Either the entire zip, or just
933         the diffs.txt in the case of text failures.
934
935         This should make understanding flakes much easier, and paves the way
936         for having the EWS run layout tests (and upload failures).
937
938         In order to upload .zip files I had to teach bugzilla.py to autodetect
939         mime types from the filename.  Since mimetypes.py doesn't include a mapping
940         for .patch files, I have it add one before calling guess_type.
941
942         We may find that always uploading the whole zip instead of just the -diffs.txt
943         file is preferable, but for now I'm keeping the old behavior because it makes
944         quickly understanding text failures easy.
945
946         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
947         * Scripts/webkitpy/common/system/workspace.py: Added.
948         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
949         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
950         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
951         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
952         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
953         * Scripts/webkitpy/tool/commands/queues.py:
954         * Scripts/webkitpy/tool/commands/queues_unittest.py:
955
956 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
957
958         Unreviewed, rolling out r75464.
959         http://trac.webkit.org/changeset/75464
960         https://bugs.webkit.org/show_bug.cgi?id=52193
961
962         Followup rollout for 75474 (Requested by Ossy on #webkit).
963
964         * MiniBrowser/mac/BrowserWindowController.m:
965         (-[BrowserWindowController awakeFromNib]):
966         * MiniBrowser/win/BrowserView.cpp:
967         (BrowserView::create):
968         * WebKitTestRunner/TestController.cpp:
969         (WTR::createOtherPage):
970         (WTR::TestController::initialize):
971
972 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
973
974         Reviewed by Csaba Osztrogonác.
975
976         [Qt] Baseline qt_minimal configuration
977         https://bugs.webkit.org/show_bug.cgi?id=51313
978
979         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
980         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
981         QT_NO_UNDOSTACK guard.
982
983         * QtTestBrowser/launcherwindow.cpp:
984         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
985         guards.
986         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
987         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
988         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
989         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
990
991         * QtTestBrowser/launcherwindow.h:
992         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
993         * QtTestBrowser/locationedit.h: Ditto.
994
995         * QtTestBrowser/mainwindow.cpp:
996         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
997         QT_NO_UNDOSTACK guards.
998         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
999         (MainWindow::changeLocation): Ditto.
1000         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
1001         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
1002
1003         * QtTestBrowser/webpage.cpp:
1004         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
1005         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
1006
1007         * QtTestBrowser/webview.cpp:
1008         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
1009         (WebViewGraphicsBased::animatedYFlip): Ditto.
1010
1011 2011-01-10  Sam Weinig  <sam@webkit.org>
1012
1013         Fix build.
1014
1015         * MiniBrowser/mac/BrowserWindowController.m:
1016         (-[BrowserWindowController awakeFromNib]):
1017         * MiniBrowser/win/BrowserView.cpp:
1018         (BrowserView::create):
1019         * WebKitTestRunner/TestController.cpp:
1020         (WTR::createOtherPage):
1021         (WTR::TestController::initialize):
1022
1023 2011-01-10  Eric Seidel  <eric@webkit.org>
1024
1025         Reviewed by Ojan Vafai.
1026
1027         style-queue messages are way too long for big patches
1028         https://bugs.webkit.org/show_bug.cgi?id=52161
1029
1030         We definitely could build much fancier list-to-string-with-limit functions
1031         but this should be sufficient for our needs at the moment.
1032
1033         * Scripts/webkitpy/common/system/executive.py:
1034         * Scripts/webkitpy/common/system/executive_unittest.py:
1035
1036 2011-01-10  Tony Chang  <tony@chromium.org>
1037
1038         Unreviewed, rolling out r75398.
1039         http://trac.webkit.org/changeset/75398
1040         https://bugs.webkit.org/show_bug.cgi?id=52008
1041
1042         Some layout tests are crashing on Chromium Win.
1043
1044         * DumpRenderTree/chromium/WebViewHost.cpp:
1045         (WebViewHost::updatePaintRect):
1046         * DumpRenderTree/chromium/WebViewHost.h:
1047
1048 2011-01-10  Adam Roben  <aroben@apple.com>
1049
1050         Roll out r75392
1051
1052         It isn't needed now that r75289 has been rolled out.
1053
1054         * Scripts/run-javascriptcore-tests:
1055
1056 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
1057
1058         Reviewed by Anders Carlsson.
1059
1060         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
1061         https://bugs.webkit.org/show_bug.cgi?id=52160
1062
1063         * WebKitTestRunner/mac/TestControllerMac.mm:
1064         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
1065         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
1066         anyway.
1067
1068 2011-01-10  Tony Chang  <tony@chromium.org>
1069
1070         Reviewed by Mihai Parparita.
1071
1072         [chromium] fix for animated gif layout tests
1073         https://bugs.webkit.org/show_bug.cgi?id=52008
1074
1075         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
1076             to trigger gif animations.
1077         (WebViewHostPaintTask::WebViewHostPaintTask):
1078         (WebViewHostPaintTask::runIfValid):
1079         (WebViewHost::updatePaintRect):
1080         * DumpRenderTree/chromium/WebViewHost.h:
1081         (WebViewHost::taskList):
1082
1083 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
1084
1085         Reviewed by Xan Lopez.
1086
1087         [GTK] Fix gtk2 compilation for master
1088         https://bugs.webkit.org/show_bug.cgi?id=51885
1089
1090         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1091         (createBitmapContextFromWebView): Replaced the old
1092         gdk_drawable_get_size with gdk_pixmap_get_size.
1093
1094 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
1095
1096         Reviewed by Laszlo Gombos.
1097
1098         [WINCE] Reenable NPAPI after r75203
1099         https://bugs.webkit.org/show_bug.cgi?id=52109
1100
1101         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
1102         it with !isEfl(), because EFL port does not support NPAPI (yet).
1103
1104         * Scripts/build-webkit:
1105
1106 2011-01-10  Adam Roben  <aroben@apple.com>
1107
1108         Skip some asserting JS tests
1109
1110         See <http://webkit.org/b/52156>.
1111
1112         * Scripts/run-javascriptcore-tests:
1113
1114 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
1115
1116         Reviewed by Xan Lopez.
1117
1118         [GTK] build-webkit disable Blob support via arguments passed to automake
1119         https://bugs.webkit.org/show_bug.cgi?id=52097
1120
1121         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
1122         build-webkit.
1123
1124 2011-01-10  Adam Roben  <aroben@apple.com>
1125
1126         Use the same name and description for TestNetscapePlugin on Windows and
1127         Mac
1128
1129         Fixes <http://webkit.org/b/52151>
1130         fast/frames/iframe-reparenting-plugins.html fails on Windows
1131
1132         Reviewed by Steve Falkenburg.
1133
1134         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
1135         the name and description from Mac's Info.plist.
1136
1137 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
1138
1139         Reviewed by Laszlo Gombos.
1140
1141         [Qt][WK2] Guard gcc-specific syntax
1142
1143         Non-gcc based compliers choke on the "-include"
1144         syntax for preinclude, place guard around it.
1145
1146         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1147         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1148
1149 2011-01-10  Andreas Kling  <kling@webkit.org>
1150
1151         Reviewed by Simon Hausmann.
1152
1153         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
1154         https://bugs.webkit.org/show_bug.cgi?id=52111
1155
1156         When getting a createNewPage() callback from QWKPage, create the
1157         new page with the same QWKContext as the page that is passed to
1158         the callback.
1159
1160         * MiniBrowser/qt/BrowserView.h:
1161         * MiniBrowser/qt/BrowserWindow.cpp:
1162         (newPageFunction):
1163         (BrowserWindow::BrowserWindow):
1164         * MiniBrowser/qt/BrowserWindow.h:
1165
1166 2011-01-10  Andreas Kling  <kling@webkit.org>
1167
1168         Reviewed by Kenneth Rohde Christiansen.
1169
1170         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
1171
1172         BrowserView set its own useless createNewPage() callback on QWKPage.
1173         This was immediately overridden by BrowserWindow anyway, so remove
1174         the BrowserView one.
1175
1176         * MiniBrowser/qt/BrowserView.cpp:
1177         (BrowserView::BrowserView):
1178
1179 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
1180
1181         Reviewed by Jeremy Orlow.
1182
1183         [Chromium] Remove non-client-based Geolocation code
1184         https://bugs.webkit.org/show_bug.cgi?id=50921
1185
1186         * DumpRenderTree/chromium/LayoutTestController.cpp:
1187         (LayoutTestController::setGeolocationPermission):
1188         (LayoutTestController::setMockGeolocationPosition):
1189         (LayoutTestController::setMockGeolocationError):
1190         * DumpRenderTree/chromium/WebViewHost.cpp:
1191         (WebViewHost::geolocationClientMock):
1192         (WebViewHost::reset):
1193         * DumpRenderTree/chromium/WebViewHost.h:
1194
1195 2011-01-10  Eric Seidel  <eric@webkit.org>
1196
1197         Reviewed by Adam Barth.
1198
1199         Commit bot tried to land r? cq+ patch
1200         https://bugs.webkit.org/show_bug.cgi?id=36638
1201
1202         It should now be possible to post a patch with r? and cq+ and the
1203         commit-queue will correctly wait for the r+ before attempting to land the patch.
1204         (This was a feature requested by several users.)
1205
1206         One caveat: We don't actually reject r-, cq+ patches from the queue
1207         (we just ignore them), but I think that's OK for now.
1208
1209         I also noticed that setting r- once a commit-queue node had grabbed
1210         a patch would not properly cancel the landing.  That's fixed and
1211         tested in this patch.
1212
1213         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1214         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1215         * Scripts/webkitpy/tool/bot/feeders.py:
1216         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1217
1218 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
1219
1220         Reviewed by Kenneth Rohde Christiansen.
1221
1222         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
1223         https://bugs.webkit.org/show_bug.cgi?id=51934
1224
1225         When accessing the network from the destructor of QWebPage, the network access manager
1226         was already deleted because the object WebPage was already destructed.
1227
1228         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
1229         The object is now destructed in the destructor of QObject.
1230
1231         * QtTestBrowser/webpage.cpp:
1232         (WebPage::WebPage):
1233         (WebPage::setQnamThreaded):
1234         * QtTestBrowser/webpage.h:
1235         (QtNAMThread::QtNAMThread):
1236
1237 2011-01-08  Eric Seidel  <eric@webkit.org>
1238
1239         Reviewed by Ojan Vafai.
1240
1241         test_failures.py should not mention TestShell (long live DumpRenderTree!)
1242         https://bugs.webkit.org/show_bug.cgi?id=52067
1243
1244         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
1245         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
1246
1247         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1248
1249 2011-01-08  Eric Seidel  <eric@webkit.org>
1250
1251         Reviewed by Mihai Parparita.
1252
1253         commit-queue hangs when the ChangeLog diff is bad
1254         https://bugs.webkit.org/show_bug.cgi?id=52072
1255
1256         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
1257         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1258
1259 2011-01-08  Adam Barth  <abarth@webkit.org>
1260
1261         Teach svn-apply how to re-write WebCore to Source/WebCore.
1262
1263         * Scripts/VCSUtils.pm:
1264
1265 2011-01-07  Adam Barth  <abarth@webkit.org>
1266
1267         Rubber-stamped by Eric Seidel.
1268
1269         Move WebCore to Source
1270         https://bugs.webkit.org/show_bug.cgi?id=52050
1271
1272         Update the tools to understand WebCore's new location.
1273
1274         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1275         * DumpRenderTree/wscript:
1276         * GNUmakefile.am:
1277         * Scripts/build-webkit:
1278         * Scripts/do-file-rename:
1279         * Scripts/do-webcore-rename:
1280         * Scripts/generate-qt-inspector-resource:
1281         * Scripts/prepare-ChangeLog:
1282         * Scripts/run-bindings-tests:
1283         * Scripts/update-iexploder-cssproperties:
1284         * Scripts/update-sources-list.py:
1285         * Scripts/update-webkit-localizable-strings:
1286         * Scripts/webkitdirs.pm:
1287         * Scripts/webkitpy/common/config/build.py:
1288         * Scripts/webkitpy/common/config/build_unittest.py:
1289         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1290         * Scripts/webkitpy/style/checker.py:
1291         * Scripts/webkitpy/style/checker_unittest.py:
1292         * WebKitTestRunner/DerivedSources.pro:
1293         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1294         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
1295         * wx/browser/wscript:
1296         * wx/build/settings.py:
1297
1298 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
1299
1300         Reviewed by Sam Weinig.
1301
1302         Make WebKitTestRunner rest between loads more robust to avoid test crashes
1303         https://bugs.webkit.org/show_bug.cgi?id=52086
1304
1305         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1306         (WTR::InjectedBundle::didReceiveMessage):
1307         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1308         (WTR::LayoutTestController::notifyDone):
1309         * WebKitTestRunner/TestController.cpp:
1310         (WTR::TestController::resetStateToConsistentValues):
1311         (WTR::TestController::run):
1312
1313 2011-01-07  James Robinson  <jamesr@chromium.org>
1314
1315         Revert "Implement mozilla's animationTime property"
1316         https://bugs.webkit.org/show_bug.cgi?id=51952
1317
1318         This approach isn't quite right.
1319
1320         * DumpRenderTree/chromium/WebViewHost.cpp:
1321         (WebViewHost::paintInvalidatedRegion):
1322
1323 2011-01-07  Adam Roben  <aroben@apple.com>
1324
1325         Build master fix
1326
1327         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1328         (RunWebKitTests.start): Don't try to concatenate a list and a string.
1329
1330 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
1331
1332         Reviewed by Csaba Osztrogonác.
1333
1334         run-qtwebkit-tests should be able to kill a testsuite.
1335
1336         Add new option in the script that can setup a timeout for a test.
1337         If the test execution takes more then specified time then the test
1338         would be terminated.
1339
1340         [Qt] run-qtwebkit-tests needs timeout
1341         https://bugs.webkit.org/show_bug.cgi?id=51894
1342
1343         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1344         * Scripts/run-qtwebkit-tests:
1345
1346 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
1347
1348         Unreviewed fix after r75233.
1349
1350         Based on idea from Eric Seidel.
1351
1352         Add remote zip file handling to webkitpy.
1353         https://bugs.webkit.org/show_bug.cgi?id=50901
1354
1355         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
1356
1357 2011-01-07  Shane Stephens  <shanestephens@google.com>
1358
1359         Reviewed by Eric Seidel.
1360
1361         svn-apply: should support git binary delta diffs
1362         https://bugs.webkit.org/show_bug.cgi?id=38864
1363
1364         * Scripts/VCSUtils.pm:
1365         * Scripts/svn-apply:
1366
1367 2011-01-06  Julie Parent  <jparent@chromium.org>
1368
1369         Reviewed by Eric Seidel.
1370
1371         Test Result Server not removing old results.
1372         https://bugs.webkit.org/show_bug.cgi?id=52012
1373
1374         * TestResultServer/model/jsonresults.py:
1375         Fix off-by-one: Truncate if >= num_runs, not just >.
1376         * TestResultServer/model/jsonresults_unittest.py:
1377         Add unit test to test that merging in a new result with the same value
1378         as the last result causes previous result to fall off.
1379
1380 2011-01-06  James Kozianski  <koz@chromium.org>
1381
1382         Reviewed by Mihai Parparita.
1383
1384         Add classes to provide a consistent interface to a set of files.
1385         https://bugs.webkit.org/show_bug.cgi?id=50901
1386
1387         These classes allow us to write code that is agnostic to whether a
1388         particular set of files resides in a local directory or in a zip file
1389         on a remote machine.
1390
1391         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
1392         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
1393         * Scripts/webkitpy/common/system/fileset.py: Added.
1394         * Scripts/webkitpy/common/system/filesystem.py:
1395         * Scripts/webkitpy/common/system/filesystem_mock.py:
1396         * Scripts/webkitpy/common/system/zipfileset.py: Added.
1397         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
1398
1399 2011-01-06  Eric Seidel  <eric@webkit.org>
1400
1401         Reviewed by Adam Barth.
1402
1403         NetworkTransaction should log the url it is retrying
1404         https://bugs.webkit.org/show_bug.cgi?id=52043
1405
1406         * Scripts/webkitpy/common/net/networktransaction.py:
1407         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
1408
1409 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1410
1411         Windows build fix.
1412         Import os before using it.
1413
1414         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1415
1416 2011-01-06  Eric Seidel  <eric@webkit.org>
1417
1418         Reviewed by Adam Barth.
1419
1420         StyleQueue fails to report errors when patches have many files
1421         https://bugs.webkit.org/show_bug.cgi?id=52042
1422
1423         This is one of at least two errors preventing style error reporting at the moment.
1424         When we moved to passing the list of files to check explicitly,
1425         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
1426         We could change the type of the QueueStatus.message type, or we could
1427         just teach statusserver.py how to clamp values (and warn when it does).
1428         I chose the latter path.
1429
1430         * Scripts/webkitpy/common/net/statusserver.py:
1431
1432 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1433
1434         Reviewed by Stephanie Lewis.
1435         
1436         Fix syntax error in script.
1437
1438         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1439         https://bugs.webkit.org/show_bug.cgi?id=51996
1440
1441         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1442
1443 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1444
1445         Unreviewed, fixing WinCE build after r75196.
1446
1447         WinCE port does not (yet) support NPAPI.
1448
1449         * Scripts/build-webkit:
1450
1451 2011-01-06  Xan Lopez  <xlopez@igalia.com>
1452
1453         Reviewed by Darin Adler.
1454
1455         File::Spec->rel2abs in sunspider-compare-results mangles parameters
1456         https://bugs.webkit.org/show_bug.cgi?id=52015
1457
1458         * Scripts/sunspider-compare-results: call rel2abs on our arguments
1459         after the platform has been detected, otherwise the script will
1460         mangle things like '--gtk' into '/a/path/--gtk', breaking the
1461         detection.
1462
1463 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1464
1465         Reviewed by Eric Seidel.
1466
1467         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
1468         https://bugs.webkit.org/show_bug.cgi?id=51346
1469
1470         * Scripts/build-webkit:
1471
1472 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1473
1474         Reviewed by Adam Roben.
1475
1476         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1477         https://bugs.webkit.org/show_bug.cgi?id=51996
1478         
1479         After the configuration directory change, we were archiving the incorrect directory for
1480         build product, so we were running tests on the wrong binaries.
1481         
1482         This change archives the correct directory, and also unarchives it into a configuration-
1483         specific directory.
1484
1485         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
1486         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
1487
1488 2011-01-06  Eric Seidel  <eric@webkit.org>
1489
1490         Reviewed by Mihai Parparita.
1491
1492         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
1493         https://bugs.webkit.org/show_bug.cgi?id=52002
1494
1495         See an example of this here:
1496         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
1497
1498         It's due to the fact that we pass around TestFailure() instance
1499         objects and yet expect them to all compare to be the same.
1500
1501         This is bad.  We should either have shared instances of these values
1502         or we should just pass around the class names.  There are already hacks
1503         in place to make TestFailure objects pass equality tests, I just added
1504         a __hash__ implementation so they can be used in sets as expected.
1505
1506         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1507         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1508
1509 2011-01-06  Evan Martin  <evan@chromium.org>
1510
1511         Reviewed by Tony Chang.
1512
1513         [gdb] handle inaccessible memory and UChar*
1514         https://bugs.webkit.org/show_bug.cgi?id=52003
1515
1516         To pretty-print a UChar*, we just grope around in the memory
1517         looking for a terminating NUL.  We need to handle the exception
1518         that can occur when we poke into an invalid location.
1519
1520         Additionally, the logic for choosing which pretty-printer would
1521         early return before hitting the point where we'd use the UChar*
1522         printer.  (Did this ever work?  How did it regress?)
1523
1524         * gdb/webkit.py:
1525
1526 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
1527
1528         Reviewed by Ada Chan.
1529
1530         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
1531         https://bugs.webkit.org/show_bug.cgi?id=51969
1532         
1533         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
1534
1535         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1536         (WTR::InjectedBundlePage::InjectedBundlePage):
1537         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
1538         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1539
1540 2011-01-06  James Robinson  <jamesr@chromium.org>
1541
1542         Reviewed by Simon Fraser.
1543
1544         Implement mozilla's animationTime property
1545         https://bugs.webkit.org/show_bug.cgi?id=51952
1546
1547         Chromium DRT support for webkitAnimationTime.
1548
1549         * DumpRenderTree/chromium/WebViewHost.cpp:
1550         (WebViewHost::paintInvalidatedRegion):
1551
1552 2011-01-06  Julie Parent  <jparent@chromium.org>
1553
1554         Reviewed by Tony Chang.
1555
1556         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
1557         https://bugs.webkit.org/show_bug.cgi?id=51217
1558
1559         * TestResultServer/model/jsonresults.py:
1560         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
1561         Adds missing documentation.
1562         * TestResultServer/model/jsonresults_unittest.py:
1563         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
1564         Update test_merge to take a number of builds to truncate at.
1565
1566 2011-01-06  Adam Barth  <abarth@webkit.org>
1567
1568         Reviewed by Eric Seidel.
1569
1570         The EWS should log outside of the working directory
1571         https://bugs.webkit.org/show_bug.cgi?id=51986
1572
1573         This patch prepare us for using git clean -x -d -f in the EWS wrapper
1574         script, which will actually clean the working copy back to a pristine
1575         state instead of leaving untracked directories and ignored files.
1576
1577         * Scripts/webkitpy/tool/commands/queues.py:
1578         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1579
1580 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1581
1582         Windows build fix.
1583         Back out attempted change to built-product-archive.
1584
1585         * BuildSlaveSupport/built-product-archive:
1586
1587 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1588
1589         Windows build fix.
1590         Include configuration name when unpacking a build archive.
1591
1592         Needed, since we split Windows build results into configuration-specific directories
1593         under WebKitOutputDir.
1594
1595         * BuildSlaveSupport/built-product-archive:
1596
1597 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1598
1599         Reviewed by Darin Adler.
1600
1601         Debug and Release builds on Windows clobber each other
1602         https://bugs.webkit.org/show_bug.cgi?id=49185
1603
1604         Changes the structure of WebKitBuild build products directory so we
1605         completely separate each build configuration into independent directories.
1606         
1607         Although we previously had per-configuration directories for obj, this change adds
1608         per-configuration directories for bin, lib, obj, and include. Each configuration's
1609         build products are stored within a directory inside of WebKitBuild.
1610         
1611         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
1612         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
1613
1614         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
1615         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
1616         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
1617         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1618         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
1619         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
1620         * DumpRenderTree/win/ImageDiffCommon.vsprops:
1621         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
1622         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
1623         * FindSafari/FindSafari.vcproj:
1624         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
1625         * MiniBrowser/MiniBrowserPostBuild.cmd:
1626         * MiniBrowser/MiniBrowserPreBuild.cmd:
1627         * Scripts/webkitdirs.pm:
1628         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1629         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
1630         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
1631         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
1632         * TestWebKitAPI/win/copy-resources.cmd:
1633         * WebKitAPITest/WebKitAPITestCommon.vsprops:
1634         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
1635         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
1636         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1637         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
1638         * WebKitTestRunner/win/InjectedBundle.vcproj:
1639         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
1640         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
1641         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
1642         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
1643         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
1644         * WinLauncher/WinLauncherCommon.vsprops:
1645         * WinLauncher/WinLauncherPostBuild.cmd:
1646         * WinLauncher/WinLauncherPreBuild.cmd:
1647
1648 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
1649
1650         Reviewed by Ariya Hidayat.
1651
1652         [Qt] TestNetscapePlugin doesn't link on OS X
1653         https://bugs.webkit.org/show_bug.cgi?id=51948
1654
1655         Only add a dependency on libX11 on X11 systems
1656
1657         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1658
1659 2011-01-05  Jeff Miller  <jeffm@apple.com>
1660
1661         Reviewed by Adam Roben.
1662
1663         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
1664         https://bugs.webkit.org/show_bug.cgi?id=51970
1665
1666         * Scripts/webkitpy/style/checker.py:
1667         Add -readability/naming for WebKit2 C API directories.
1668
1669 2011-01-05  Eric Seidel  <eric@webkit.org>
1670
1671         Unreviewed, just fixing one more log error from my previous python patch.
1672
1673         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1674         https://bugs.webkit.org/show_bug.cgi?id=51802
1675
1676         webkit-patch failure-reason was logging about parsing errors
1677         due to my misunderstanding of how BeautifulSoup.findAll worked.
1678
1679         Fixed, and added a unit test.
1680
1681         * Scripts/webkitpy/common/net/layouttestresults.py:
1682         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1683
1684 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
1685
1686         Reviewed by Kenneth Rohde Christiansen.
1687
1688         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
1689         https://bugs.webkit.org/show_bug.cgi?id=51951
1690
1691         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
1692         to create new window from WebKit.
1693
1694         * MiniBrowser/qt/BrowserWindow.cpp:
1695         (newPageFunction):
1696         (BrowserWindow::BrowserWindow):
1697         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
1698         (BrowserWindow::newWindow):
1699         (BrowserWindow::updateUserAgentList):
1700         (BrowserWindow::showUserAgentDialog):
1701         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
1702         define the type of the backing store used for new windows.
1703         * MiniBrowser/qt/main.cpp:
1704         (main):
1705
1706 2011-01-05  Eric Seidel  <eric@webkit.org>
1707
1708         Reviewed by Ojan Vafai.
1709
1710         commit-queue should report failure type when reporting flaky tests
1711         https://bugs.webkit.org/show_bug.cgi?id=51900
1712
1713         This patch was a ridiculous amount of plumbing.  In the end I like
1714         the NRWT-style TestResult class even less.  But now we're passing
1715         a list of TestResult objects from the queue to the FlakyTestReporter.
1716         Thus the FlakyTestReporter can more easily report what type of failure
1717         occurred.
1718
1719         In the process, I found that I was not alone in finding TestResult
1720         cumbersome to use.  A bunch of code was trying to create a TestResult
1721         object with default values.  However since the constructor didn't make
1722         this easy, some places were getting it wrong (including the TestResult unit test)!
1723         I've fixed the TestResult constructor to have default values for non-essential
1724         arguments.
1725
1726         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1727         * Scripts/webkitpy/common/net/layouttestresults.py:
1728         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1729         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1730         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1731         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1732         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
1733         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
1734         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1735         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1736         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1737         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1738         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1739         * Scripts/webkitpy/tool/commands/queues.py:
1740         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1741
1742 2011-01-05  Eric Seidel  <eric@webkit.org>
1743
1744         Unreviewed.
1745
1746         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1747         https://bugs.webkit.org/show_bug.cgi?id=51802
1748
1749         Add another unit test to cover a previously missing import.
1750
1751         * Scripts/webkitpy/common/net/layouttestresults.py:
1752         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1753
1754 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
1755
1756         Reviewed by David Levin.
1757
1758         Add mihaip@chromium.org as a reviewer
1759         https://bugs.webkit.org/show_bug.cgi?id=51966
1760         
1761         Add myself as a reviewer.
1762
1763         * Scripts/webkitpy/common/config/committers.py:
1764
1765 2011-01-05  James Simonsen  <simonjam@chromium.org>
1766
1767         Unreviewed. Adding myself to the list of committers.
1768
1769         * Scripts/webkitpy/common/config/committers.py:
1770
1771 2011-01-05  Eric Seidel  <eric@webkit.org>
1772
1773         Unreviewed.
1774
1775         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1776         https://bugs.webkit.org/show_bug.cgi?id=51802
1777
1778         Fix two exceptions seen on the bots after my original commit.
1779
1780         * Scripts/webkitpy/common/net/layouttestresults.py:
1781         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1782
1783 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
1784
1785         Reviewed by Andreas Kling.
1786
1787         [Qt]Add local storage settings to QtTestBrowser command line arguments 
1788         https://bugs.webkit.org/show_bug.cgi?id=51750
1789
1790         * QtTestBrowser/main.cpp:
1791         (LauncherApplication::handleUserOptions):
1792          Local storage settings can be enable form command line arguments for
1793          QtTestBrowser.
1794
1795 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
1796
1797         Reviewed by Martin Robinson.
1798
1799         GTK: AX: DRT needs to use correct root object method.
1800         https://bugs.webkit.org/show_bug.cgi?id=51911
1801
1802         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1803         (AccessibilityController::rootElement):
1804
1805 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1806
1807         Rubber-stamped by Csaba Osztrogonác.
1808
1809         Based on idea from Péter Gál.
1810
1811         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
1812
1813 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1814
1815         Reviewed by Adam Barth.
1816
1817         sheriff-bot should be able to do multi-revision rollouts
1818         https://bugs.webkit.org/show_bug.cgi?id=51176
1819
1820         * Scripts/webkitpy/tool/bot/irc_command.py:
1821         * Scripts/webkitpy/tool/bot/sheriff.py:
1822         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1823
1824 2011-01-05  Eric Seidel  <eric@webkit.org>
1825
1826         Reviewed by Adam Barth.
1827
1828         queues.webkit.org should have per-bot status pages
1829         https://bugs.webkit.org/show_bug.cgi?id=51906
1830
1831         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
1832         statuses from a single queue.  Now that we have many bots servicing
1833         some queues (commit-queue, win-ews, etc.) its easy to have the messages
1834         you care about scroll off the end of the 15-message limit on the main page.
1835
1836         Eventually we should probably rename /queue-status to /queue or /queues,
1837         but that's fodder for another patch.
1838
1839         * QueueStatusServer/handlers/queuestatus.py:
1840         * QueueStatusServer/index.yaml:
1841         * QueueStatusServer/main.py:
1842         * QueueStatusServer/templates/includes/singlequeuestatus.html:
1843          - This probably should use a custom filter instead of hard-coding
1844            the URL scheme here, but I couldn't figure out how to easily
1845            create such a filter.  Most filters work with "strings" so we can't
1846            pass the status object.  We could add a method to the status
1847            object and call that, but that seemed a bit strange too.
1848         * QueueStatusServer/templates/queuestatus.html:
1849
1850 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1851
1852         Unreviewed. Adding myself to the list of committers.
1853
1854         * Scripts/webkitpy/common/config/committers.py:
1855
1856 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
1857
1858         Reviewed by David Levin.
1859
1860         check-webkit-style treated some macros with parentheses after #elif as function calls
1861         https://bugs.webkit.org/show_bug.cgi?id=51695
1862
1863         Ingore function call space checking in any preprocessor directives
1864         (things starting with #). Change search() to match() because 
1865         preprocessor directives are supposed to be in the beginning of lines.
1866
1867         * Scripts/webkitpy/style/checkers/cpp.py:
1868         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
1869
1870 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
1871
1872         Reviewed by Tony Chang.
1873
1874         Change the --multi-load test option to --stress-opt
1875         https://bugs.webkit.org/show_bug.cgi?id=50751
1876
1877         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1878         (runTest):
1879         (main):
1880         * DumpRenderTree/chromium/TestShell.cpp:
1881         (TestShell::TestShell):
1882         * DumpRenderTree/chromium/TestShell.h:
1883         (TestShell::stressOpt):
1884         (TestShell::setStressOpt):
1885         (TestShell::stressDeopt):
1886         (TestShell::setStressDeopt):
1887         (TestShell::javaScriptFlags):
1888         (TestShell::setJavaScriptFlags):
1889         * Scripts/webkitpy/layout_tests/port/chromium.py:
1890         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1891
1892 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
1893
1894         Reviewed by Sam Weinig.
1895
1896         WK2: Support Accessibility
1897         https://bugs.webkit.org/show_bug.cgi?id=51859
1898
1899         Use rootObject() method to get top of accessibility tree.
1900
1901         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1902         (AccessibilityController::focusedElement):
1903         (AccessibilityController::rootElement):
1904
1905 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
1906
1907         Reviewed by Darin Adler.
1908
1909         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
1910         https://bugs.webkit.org/show_bug.cgi?id=51846
1911
1912         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
1913         back to GRefPtr.
1914
1915 2011-01-04  Zhe Su  <suzhe@chromium.org>
1916
1917         Reviewed by Kenneth Russell.
1918
1919         Fix insertText, setMarkedText and unmarkText methods of
1920         TextInputController to call corresponding methods of WebKit::WebView
1921         rather than WebKit::WebFrame. This change matches the behavior of
1922         chromium browser.
1923         insertText corresponds to WebView::confirmComposition(text)
1924         setMarkedText corresponds to WebView::setComposition(...)
1925         unmarkText corresponds to WebView::confirmComposition()
1926         https://bugs.webkit.org/show_bug.cgi?id=51693
1927
1928         * DumpRenderTree/chromium/TextInputController.cpp:
1929         (TextInputController::insertText):
1930         (TextInputController::setMarkedText):
1931         (TextInputController::unmarkText):
1932
1933 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
1934
1935         Reviewed by Laszlo Gombos.
1936
1937         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
1938
1939         On Symbian productDir points to the source directory. Removing all the
1940         empty files from the productDir directory corrupts the svn repository.
1941
1942         * Scripts/build-webkit:
1943
1944 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
1945
1946         Reviewed by Adam Barth.
1947
1948         [Qt] Add SelectAll option to the context menu for the editor
1949         https://bugs.webkit.org/show_bug.cgi?id=50049
1950
1951         Set shortcut for the SelectAll action.
1952
1953         * QtTestBrowser/mainwindow.cpp:
1954         (MainWindow::buildUI):
1955
1956 2011-01-03  David Levin  <levin@chromium.org>
1957
1958         Reviewed by Eric Seidel.
1959
1960         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
1961         https://bugs.webkit.org/show_bug.cgi?id=51842
1962
1963         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
1964         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
1965
1966 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
1967
1968         Reviewed by David Kilzer.
1969
1970         [WINCE] Adds a build slave.
1971         https://bugs.webkit.org/show_bug.cgi?id=50523
1972
1973         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
1974         entry for a release build of the WinCE port.
1975         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
1976         flag to build the WinCE port.
1977
1978 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
1979
1980         Reviewed by David Kilzer.
1981
1982         Add WinCE support to build-webkit
1983         https://bugs.webkit.org/show_bug.cgi?id=51642
1984
1985         * Scripts/build-webkit:
1986         * Scripts/webkitdirs.pm:
1987
1988 2011-01-03  Eric Seidel  <eric@webkit.org>
1989
1990         Reviewed by Adam Barth.
1991
1992         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1993         https://bugs.webkit.org/show_bug.cgi?id=51802
1994
1995         I'm not the biggest fan of the test_failures or test_results classes,
1996         but it's better to have one shared set of classes, than separate ones
1997         for new vs. old run-webkit-test result handling.
1998
1999         This moves the ORWT results class "LayoutTestResults" over to using
2000         TestResult and TestFailure classes, making it easy for us to
2001         make all our sheriff-bot and other webkitpy code NRWT ready.
2002
2003         This also makes it a trivial patch to generate results.json information
2004         from ORWT results.html files (for flaky test analysis, etc.) as well
2005         as making it a one-liner to report test failure types when the
2006         commit-queue sees flaky tests.
2007
2008         This patch tried not to add new functionality, but only to replace
2009         the guts of LayoutTestResults, while adding unit tests and hoping
2010         not to break anything.
2011
2012         I also moved callers which assumed User.prompt* were static/class methods
2013         to using them as instance methods (since we'll eventually want to make them such).
2014
2015         In the process of re-writing things, I broke the rebaseline command, so I wrote
2016         a unit test to catch my breakage were I do do so again in the future.
2017
2018         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2019         * Scripts/webkitpy/common/net/layouttestresults.py:
2020         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2021         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2022         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2023         * Scripts/webkitpy/tool/commands/queries.py:
2024         * Scripts/webkitpy/tool/commands/rebaseline.py:
2025         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2026         * Scripts/webkitpy/tool/mocktool.py:
2027
2028 2011-01-03  Adam Barth  <abarth@webkit.org>
2029
2030         Reviewed by Simon Fraser.
2031
2032         webkit-patch shouldn't waste time cleaning a working directory that's already clean
2033         https://bugs.webkit.org/show_bug.cgi?id=51840
2034
2035         * Scripts/webkitpy/common/checkout/scm.py:
2036
2037 2011-01-03  Adam Barth  <abarth@webkit.org>
2038
2039         Reviewed by Simon Fraser.
2040
2041         webkit-patch should only hide update output if --quiet
2042         https://bugs.webkit.org/show_bug.cgi?id=51838
2043
2044         As requested by smfr.
2045
2046         * Scripts/webkitpy/tool/steps/update.py:
2047
2048 2011-01-03  Adam Barth  <abarth@webkit.org>
2049
2050         Reviewed by David Levin.
2051
2052         commit-queue shouldn't reject patches twice if two bots process the same patch
2053         https://bugs.webkit.org/show_bug.cgi?id=51805
2054
2055         Before raising an error, we first check whether the patch is still in
2056         the commit-queue.  This check is still racy, of course, but the time
2057         window is much smaller.
2058
2059         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2060
2061 2011-01-03  Sam Weinig  <sam@webkit.org>
2062
2063         Reviewed by Anders Carlsson.
2064
2065         Make run-api-tests less chatty.
2066         https://bugs.webkit.org/show_bug.cgi?id=51831
2067
2068         - Make script quiet by default and add --verbose option (replacing --quiet).
2069         - When not verbose, pipe stdout and stderr to devnull.
2070
2071         * Scripts/run-api-tests:
2072
2073 2011-01-03  Pratik Solanki  <psolanki@apple.com>
2074
2075         Unreviewed. Adding myself to committers.py.
2076
2077         * Scripts/webkitpy/common/config/committers.py:
2078
2079 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
2080
2081         Reviewed by Xan Lopez.
2082
2083         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
2084         https://bugs.webkit.org/show_bug.cgi?id=51806
2085
2086         Originally, the $libraryName is 'JavaScriptCore'. When building release 
2087         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
2088         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
2089         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
2090         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
2091         so make it 'WebKitBuild/Release/.libs'
2092
2093         * Scripts/webkitdirs.pm: 
2094
2095 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
2096
2097         Reviewed by Adam Barth.
2098
2099         Make EFL a core builder
2100         https://bugs.webkit.org/show_bug.cgi?id=51804
2101
2102         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2103         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2104
2105 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2106
2107         [Qt] Unreviewed fix after r74855 and r74875.
2108
2109         * BuildSlaveSupport/built-product-archive:
2110          - Create directories explicitly.
2111          - Pass shell=True to subprocess.call().
2112
2113 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2114
2115         [Qt] Unreviewed fix after r74855.
2116
2117         Move JavaScriptCore to Source
2118         https://bugs.webkit.org/show_bug.cgi?id=51604
2119
2120         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
2121
2122 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2123
2124         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
2125
2126         Move JavaScriptCore to Source
2127         https://bugs.webkit.org/show_bug.cgi?id=51604
2128
2129         * Scripts/webkitdirs.pm:
2130
2131 2011-01-02  Robert Hogan  <robert@webkit.org>
2132
2133         Unreviewed, build fix.
2134
2135         [Qt] Fix DRT build after 74855
2136
2137         * DumpRenderTree/qt/DumpRenderTree.pro:
2138
2139 2011-01-01  Adam Barth  <abarth@webkit.org>
2140
2141         Remove the assumption from the Qt and Gtk builds that every project is
2142         in the root directory.
2143
2144         * Scripts/build-webkit:
2145
2146 2011-01-01  Adam Barth  <abarth@webkit.org>
2147
2148         Reviewed by Eric Seidel.
2149
2150         Teach svn-apply how to apply patches even though JavaScriptCore has moved
2151         https://bugs.webkit.org/show_bug.cgi?id=51796
2152
2153         After this change, svn-apply will magically apply patches to
2154         JavaScriptCore/foo to Source/JavaScriptCore/foo.
2155
2156         * Scripts/VCSUtils.pm:
2157
2158 2011-01-01  Adam Barth  <abarth@webkit.org>
2159
2160         Reviewed by Eric Seidel.
2161
2162         Move JavaScriptCore to Source
2163         https://bugs.webkit.org/show_bug.cgi?id=51604
2164
2165         Update references to JavaScriptCore to point to the new location.
2166
2167         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2168         * DumpRenderTree/qt/DumpRenderTree.pro:
2169         * DumpRenderTree/qt/ImageDiff.pro:
2170         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2171         * DumpRenderTree/wscript:
2172         * Scripts/build-jsc:
2173         * Scripts/build-webkit:
2174         * Scripts/do-file-rename:
2175         * Scripts/do-webcore-rename:
2176         * Scripts/run-javascriptcore-tests:
2177         * Scripts/update-javascriptcore-test-results:
2178         * Scripts/webkitdirs.pm:
2179         * Scripts/webkitpy/common/config/build_unittest.py:
2180         * Scripts/webkitpy/style/checker.py:
2181         * Scripts/webkitpy/style/checker_unittest.py:
2182         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2183         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2184         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2185         * wx/build/settings.py:
2186
2187 2011-01-01  Adam Barth  <abarth@webkit.org>
2188
2189         Reviewed by Eric Seidel.
2190
2191         Move Sources to Source
2192         https://bugs.webkit.org/show_bug.cgi?id=51794
2193
2194         Update scripts to point to the new location.
2195
2196         * Scripts/build-webkit:
2197         * Scripts/do-file-rename:
2198         * Scripts/do-webcore-rename:
2199         * Scripts/webkitpy/common/config/build.py:
2200         * Scripts/webkitpy/common/config/build_unittest.py:
2201
2202 2010-12-31  Kent Tamura  <tkent@chromium.org>
2203
2204         Reviewed by Eric Seidel.
2205
2206         [DRT/Chromium] Enable mock spell checker on non-OSX
2207         https://bugs.webkit.org/show_bug.cgi?id=51401
2208
2209         * DumpRenderTree/chromium/WebViewHost.cpp:
2210         (WebViewHost::spellCheck):
2211
2212 2010-12-31  Adam Barth  <abarth@webkit.org>
2213
2214         Reviewed by Ariya Hidayat.
2215
2216         Remove Tools/Scripts/wkstyle
2217         https://bugs.webkit.org/show_bug.cgi?id=51774
2218
2219         This script appears to not have been touched in a while and seems to
2220         have been replaced by check-webkit-style.
2221
2222         * Scripts/wkstyle: Removed.
2223
2224 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2225
2226         Unreviewed. Coding style fix.
2227
2228         * DumpRenderTree/chromium/TestShell.h:
2229
2230 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2231
2232         Reviewed by Pavel Feldman.
2233
2234         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
2235
2236         It was a problem with Chromium DRT. DevToolsAgent object instance was
2237         attached not only to the inspected page but to the DevTools window too.
2238         As result all the inspector files were interpreted as a content of inspected page
2239         and were transfered to the DevTools scripts panel for debugging etc.
2240
2241         https://bugs.webkit.org/show_bug.cgi?id=51735
2242
2243         * DumpRenderTree/chromium/TestShell.cpp:
2244         (TestShell::TestShell):
2245         (TestShell::bindJSObjectsToWindow):
2246         (TestShell::createNewWindow):
2247         * DumpRenderTree/chromium/TestShell.h:
2248
2249 2010-12-31  Adam Barth  <abarth@webkit.org>
2250
2251         Rubber-stamped by Eric Seidel.
2252
2253         Move PageLoadTests to PerformanceTests/PageLoad
2254         https://bugs.webkit.org/show_bug.cgi?id=51771
2255
2256         Update references to PageLoadTests to point to the new location.
2257
2258         * Scripts/run-pageloadtest:
2259         * Scripts/webkitpy/common/config/build.py:
2260
2261 2010-12-31  Adam Barth  <abarth@webkit.org>
2262
2263         Rubber-stamped by Eric Seidel.
2264
2265         Move SunSpider into PerformanceTests
2266         https://bugs.webkit.org/show_bug.cgi?id=51769
2267
2268         Update these scripts to point to the new location.
2269
2270         * Scripts/run-sunspider:
2271         * Scripts/sunspider-compare-results:
2272
2273 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
2274
2275         Reviewed by Kent Tamura.
2276
2277         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
2278         https://bugs.webkit.org/show_bug.cgi?id=51728
2279         
2280         Add implementation of the Mac WebThemeEngine that uses an NSScroller
2281         to render top-level scrollbars. This makes them match the Mac port's
2282         use of an NSScrollView, which means that we'll be able to share more
2283         pixel baselines.
2284         
2285         The new rendering code will not be activated until the 
2286         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
2287         ScrollbarThemeChromiumMac.
2288
2289         * DumpRenderTree/DumpRenderTree.gypi:
2290         * DumpRenderTree/chromium/TestShellMac.mm:
2291         (platformInit):
2292         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
2293         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
2294         (+[FakeActiveWindow alwaysActiveWindow]):
2295         (+[FakeActiveWindow alwaysInactiveWindow]):
2296         (-[FakeActiveWindow initWithActiveControls:]):
2297         (-[FakeActiveWindow _hasActiveControls]):
2298         (WebThemeEngineDRTMac::paintScrollbarThumb):
2299         (stateToHIEnableState):
2300         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2301         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2302
2303 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
2304
2305         Reviewed by David Kilzer.
2306
2307         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
2308         used
2309         https://bugs.webkit.org/show_bug.cgi?id=51672
2310
2311         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
2312         with USE_SYSTEM_MALLOC=1
2313         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
2314         with USE_SYSTEM_MALLOC=1
2315
2316 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2317
2318         Reviewed by David Kilzer.
2319
2320         [Qt] [Symbian] Fix build-webkit script for Symbian
2321         https://bugs.webkit.org/show_bug.cgi?id=51509
2322
2323         Set the OUTPUT_DIR for Symbian to be the same as the source
2324         directory.
2325
2326         * Scripts/webkitdirs.pm:
2327
2328 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
2329
2330         Reviewed by Darin Adler.
2331
2332         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
2333         https://bugs.webkit.org/show_bug.cgi?id=51758
2334
2335         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
2336
2337         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
2338         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
2339
2340 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
2341
2342         Unreviewed WinCE buildfix.
2343
2344         * WinCELauncher/main.cpp: Add missing include.
2345
2346 2010-12-29  Daniel Bates  <dbates@rim.com>
2347
2348         Reviewed by Darin Adler.
2349
2350         svn-apply updates date of wrong change log entry for a change log diff that
2351         contains two consecutive entries with the same author and date
2352         https://bugs.webkit.org/show_bug.cgi?id=46061
2353
2354         Fixes an issue where the date of the wrong change log entry may be modified.
2355         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
2356         in a ChangeLog file to the top of the file.
2357
2358         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
2359         diff when it detects that the diff inserts a change log entry earlier in a
2360         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
2361         change. With the advent of the commit-queue this functionality of bailing out
2362         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
2363         Instead, we should always move the change log entry to the top of the ChangeLog file.
2364
2365         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
2366         the date line of the correct change log entry in a ChangeLog diff.
2367
2368         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
2369
2370         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
2371           Updated the following unit tests now that we move entries inserted earlier to the top:
2372           - "fixChangeLogPatch: New entry inserted in middle."
2373             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
2374
2375           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
2376             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
2377
2378         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
2379
2380 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
2381
2382         Reviewed by Eric Seidel.
2383
2384         [Qt] Fixed compatibility with gold linker on X11 platforms
2385         https://bugs.webkit.org/show_bug.cgi?id=51700
2386
2387         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2388         Linked TestNetscapePlugin with libX11 on Unix platforms
2389
2390 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2391
2392         Reviewed by Darin Adler.
2393
2394         Circular dependency in webkitpy.common.checkout.changelog module
2395         https://bugs.webkit.org/show_bug.cgi?id=50475
2396
2397         Remove automatic import of api.Checkout module when any checkout/
2398         submodule is imported (e.g.: when checkout.scm.Git is imported).
2399
2400         * Scripts/webkitpy/common/checkout/__init__.py:
2401
2402 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
2403
2404         Reviewed by Ojan Vafai.
2405
2406         prepare-ChangeLog should support the -g option for specifying the git-commit
2407         https://bugs.webkit.org/show_bug.cgi?id=51708
2408
2409         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
2410         webkit-patch, though the exact meaning of the two options remain different.
2411
2412         * Scripts/prepare-ChangeLog: Add -g.
2413
2414 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
2415
2416         Reviewed by Simon Hausmann.
2417
2418         [Qt] Fix compilation with Qt in namespace
2419         https://bugs.webkit.org/show_bug.cgi?id=51701
2420
2421         * QtTestBrowser/webview.h:
2422
2423 2010-12-28  Daniel Bates  <dbates@rim.com>
2424
2425         Reviewed by Sam Weinig.
2426
2427         Substitute // MARK: for compiler-specific #pragma mark
2428         https://bugs.webkit.org/show_bug.cgi?id=51657
2429
2430         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
2431         substituting  "// MARK:" for "#pragma mark", which provides
2432         analogous code-bookmarking functionality under Xcode.
2433
2434         Also, for consistency, we should substitute "// MARK:" for compiler-
2435         specific "#pragma mark" in the source files for the Mac port.
2436
2437         * DumpRenderTree/AccessibilityTextMarker.cpp:
2438         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
2439         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
2440         * DumpRenderTree/mac/ObjCController.m:
2441         * MiniBrowser/mac/AppDelegate.m:
2442         * MiniBrowser/mac/BrowserWindowController.m:
2443
2444 2010-12-28  Xan Lopez  <xlopez@igalia.com>
2445
2446         Reviewed by Eric Seidel.
2447
2448         Add --no-build option to run-sunspider
2449         https://bugs.webkit.org/show_bug.cgi?id=51658
2450
2451         * Scripts/run-sunspider: add --no-build flag to skip building
2452         phase.
2453
2454 2010-12-27  Daniel Bates  <dbates@rim.com>
2455
2456         Rubber-stamped by Martin Robinson.
2457
2458         Append the directory Tools/DumpRenderTree to the list of directories that
2459         do-webcore-rename should search so that it can rename DRT files and
2460         source code.
2461
2462         * Scripts/do-webcore-rename:
2463
2464 2010-12-27  Eric Seidel  <eric@webkit.org>
2465
2466         Reviewed by Adam Barth.
2467
2468         build-webkit should detect missing Java SDK and explain how to install it
2469         https://bugs.webkit.org/show_bug.cgi?id=51651
2470
2471         * Scripts/build-webkit:
2472
2473 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
2474
2475         Reviewed by Daniel Bates.
2476
2477         [GTK] Add support for build-jsc
2478         https://bugs.webkit.org/show_bug.cgi?id=51625
2479
2480         Add GTK+ support to build-jsc now that building the jsc executable as
2481         a standalone target is easy.
2482
2483         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
2484         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
2485         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
2486         and pass it along to buildAutotoolsProject.
2487
2488 2010-12-27  David Levin  <levin@chromium.org>
2489
2490         Reviewed by Eric Seidel.
2491
2492         check-webkit-style check for meaningless variable names in function declarations.
2493         https://bugs.webkit.org/show_bug.cgi?id=51523
2494
2495         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
2496         from the new check and whitespace/parens because the syntax is unusual and
2497         produced a fair number of positives for these checks.
2498         * Scripts/webkitpy/style/checkers/cpp.py:
2499         (_convert_to_lower_with_underscores): Used as a canonical form for type names
2500         and parameter names when determining if the parameter name is useless.
2501         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
2502         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
2503         format.
2504         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
2505         text or an acronym of it.
2506         (check_function_definition): Checks function definitions for meaningless variable names.
2507         (process_line): Added call to check_function_definition.
2508         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2509         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
2510         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
2511         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
2512         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
2513         because when only checking a snippet, there are a lot of bogus functions.
2514         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
2515         that I put there previously and just noticed.
2516         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
2517         check_function_definition and process_line.
2518
2519 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2520
2521         Reviewed by Martin Robinson.
2522
2523         [GTK] Disable flash plugin in GtkLauncher when using gtk3
2524         https://bugs.webkit.org/show_bug.cgi?id=51591
2525
2526         Flash plugin uses gtk2 that is incompatible with gtk3 making
2527         webkit crash when it's built with gtk3.
2528
2529         * GtkLauncher/main.c:
2530         (main):
2531
2532 2010-12-25  Adam Barth  <abarth@webkit.org>
2533
2534         Reviewed by Eric Seidel.
2535
2536         Move ANGLE to Sources/ThirdParty
2537         https://bugs.webkit.org/show_bug.cgi?id=51605
2538
2539         * Scripts/build-webkit:
2540           - Point to the new ANGLE location.
2541
2542 2010-12-26  David Levin  <levin@chromium.org>
2543
2544         Reviewed by Eric Seidel.
2545
2546         check-webkit-style should be able to parse function declaration parameters.
2547         https://bugs.webkit.org/show_bug.cgi?id=51451
2548
2549         * Scripts/webkitpy/style/checkers/cpp.py:
2550         (Position.__init__): Holds simple position information (row, column).
2551         (Parameter.__init__): Holds information about a parameter.
2552         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
2553         (SingleLineView.convert_column_to_row): Returns the original row given a column.
2554         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
2555         (find_parameter_name_index): Finds where the parameter name is.
2556         (parameter_list): Generates the list of parameters for a function.
2557         (_FunctionState.begin): Added information to allow determining the parameters
2558         on demand.
2559         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
2560         (detect_functions): Improve function detection for operator functions and
2561         determine where the parameters end and pass that to _FunctionState.begin.
2562         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2563         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
2564         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
2565         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
2566         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
2567         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
2568         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
2569         (FunctionDetectionTest.perform_function_detection): Added support for verifying
2570         the parameters found.
2571         (FunctionDetectionTest.test_function_declaration_detection): Added more function
2572         detection test to verify that we catch the operator functions.
2573         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
2574         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
2575         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
2576         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
2577         test_function_length_check_definition_severity1_for_test.
2578
2579 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
2580
2581         Unreviewed WinCE buildfix after r74334.
2582
2583         * CMakeListsWinCE.txt:
2584
2585 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2586
2587         Unreviewed, rolling out r74632.
2588         http://trac.webkit.org/changeset/74632
2589         https://bugs.webkit.org/show_bug.cgi?id=51600
2590
2591         makes test-webkitpy hang forever on GTK (Requested by philn-tp
2592         on #webkit).
2593
2594         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2595         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2596
2597 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
2598
2599         Reviewed by Kenneth Rohde Christiansen.
2600
2601         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
2602         https://bugs.webkit.org/show_bug.cgi?id=43528
2603
2604         Remove on_resize because ewk_view_fixed_layout_size_set should not be
2605         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
2606         FrameView, rendering was ignored when _ewk_view_smart_calculate was
2607         called.
2608
2609         * EWebLauncher/main.c:
2610         (browserCreate):
2611
2612 2010-12-24  Eric Seidel  <eric@webkit.org>
2613
2614         Reviewed by Adam Barth.
2615
2616         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
2617         https://bugs.webkit.org/show_bug.cgi?id=28291
2618
2619         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
2620         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
2621         to strings with find in the diff.
2622         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
2623
2624         * Scripts/webkitpy/common/checkout/api.py:
2625         * Scripts/webkitpy/common/checkout/diff_parser.py:
2626         * Scripts/webkitpy/tool/steps/abstractstep.py:
2627         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2628         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
2629         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
2630         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2631
2632 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
2633
2634         Reviewed by Kenneth Russell.
2635
2636         Modify new-run-webkit-tests to shut up and exit when all the threads
2637         are wedged so that test runs complete faster and we don't end up
2638         w/ enormous log files.
2639
2640         https://bugs.webkit.org/show_bug.cgi?id=51572
2641
2642         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2643         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2644
2645 2010-12-24  Eric Seidel  <eric@webkit.org>
2646
2647         Reviewed by David Levin.
2648
2649         commit-queue should better explain how it will re-open bugs and follow duplicate chains
2650         https://bugs.webkit.org/show_bug.cgi?id=51549
2651
2652         I've had multiple people ask me about the commit-queue's behavior
2653         regarding reporting flaky tests.  I figured it would be best to just
2654         have the queue explain itself in the bugs it files.
2655
2656         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2657         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2658
2659 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
2660
2661         Reviewed by Eric Seidel.
2662
2663         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
2664         https://bugs.webkit.org/show_bug.cgi?id=51467
2665
2666         * Scripts/webkitpy/style/checker.py:
2667         * Scripts/webkitpy/style/checker_unittest.py:
2668
2669 2010-12-23  Adam Barth  <abarth@webkit.org>
2670
2671         Rubber-stamped by Eric Seidel.
2672
2673         Move JavaScriptGlue into Sources
2674         https://bugs.webkit.org/show_bug.cgi?id=51583
2675
2676         These tools refer to JavaScriptGlue and need to be updated to its new
2677         location.
2678
2679         * Scripts/build-webkit:
2680         * Scripts/do-file-rename:
2681         * Scripts/do-webcore-rename:
2682         * Scripts/webkitpy/common/config/build.py:
2683         * Scripts/webkitpy/common/config/build_unittest.py:
2684
2685 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2686
2687         Reviewed by Eric Seidel.
2688
2689         Bug 51539 - update iexploder scripts to point to new location
2690
2691         * Scripts/run-iexploder-tests:
2692         * Scripts/update-iexploder-cssproperties:
2693
2694 2010-12-23  Evan Martin  <evan@chromium.org>
2695
2696         Reviewed by Ryosuke Niwa.
2697
2698         [chromium] LayoutTestController warning in float->int conversion
2699         https://bugs.webkit.org/show_bug.cgi?id=51553
2700
2701         Rather than reading an int, converting to a float, then getting a compiler
2702         warning on passing the float to something that expects an int, instead
2703         just pass around ints.
2704
2705         No tests, fixes a compiler warning.
2706
2707         * DumpRenderTree/chromium/LayoutTestController.cpp:
2708         (parsePageSizeParameters):
2709         (LayoutTestController::pageNumberForElementById):
2710         (LayoutTestController::numberOfPages):
2711
2712 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2713
2714         Reviewed by Darin Adler.
2715
2716         Bug 51537 - iexploder needs cleanup
2717         
2718         * iExploder/htdocs: Removed.
2719         * iExploder/htdocs/config.rb: Removed.
2720         * iExploder/htdocs/cssproperties.in: Removed.
2721         * iExploder/htdocs/cssvalues.in: Removed.
2722         * iExploder/htdocs/htmlattrs.in: Removed.
2723         * iExploder/htdocs/htmltags.in: Removed.
2724         * iExploder/htdocs/htmlvalues.in: Removed.
2725         * iExploder/htdocs/iexploder.cgi: Removed.
2726         * iExploder/htdocs/iexploder.rb: Removed.
2727         * iExploder/htdocs/index.html: Removed.
2728         * iExploder/htdocs/webserver.rb: Removed.
2729         * iExploder/iexploder-1.7.2/output: Removed.
2730         * iExploder/tools: Removed.
2731         * iExploder/tools/lasthit.rb: Removed.
2732         * iExploder/tools/osx_last_crash.rb: Removed.
2733         * iExploder/tools/showtest.rb: Removed.
2734
2735 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2736
2737         Reviewed by Kenneth Rohde Christiansen.
2738
2739         [EFL] Make 'single' the default backing store in EWebLauncher
2740         https://bugs.webkit.org/show_bug.cgi?id=51534
2741
2742         'single' is the simplest backing store and the one intended to be the
2743         default in the test browser. By mistake the tiled backing store was
2744         left as default in r72617.
2745
2746         * EWebLauncher/main.c:
2747         (browserCreate): ditto.
2748
2749 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2750
2751         Reviewed by Kenneth Rohde Christiansen.
2752
2753         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
2754         https://bugs.webkit.org/show_bug.cgi?id=51533
2755
2756         There's no point in concatenating env("HOME") with "blah", so remove
2757         option from EWebLauncher.
2758
2759         * EWebLauncher/main.c:
2760         (main): ditto.
2761
2762 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
2763
2764         Reviewed by Eric Seidel.
2765
2766         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
2767
2768         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
2769         I just discovered that we have two additional GC runs per each WebViewHost.
2770         Test_shell had no such calls.
2771         These gc runs eat 15% of cpu time.
2772
2773         https://bugs.webkit.org/show_bug.cgi?id=51479
2774
2775         * DumpRenderTree/chromium/WebViewHost.cpp:
2776         (WebViewHost::~WebViewHost):
2777
2778 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2779
2780         Reviewed by Ojan Vafai.
2781
2782         This change splits out the TestRunner class into its own file.
2783         When we fork the code for message passing, we will create a new
2784         TestRunner, and this change will allow that to be more modular.
2785
2786         While we're at it, split out TestInput and ResultSummary into
2787         their own files, to reduce the size of run_webkit_tests to
2788         something more managable.
2789
2790         https://bugs.webkit.org/show_bug.cgi?id=51092
2791
2792         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2793         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
2794         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2795         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
2796         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
2797         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2798         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2799
2800  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2801
2802         Reviewed by Ojan Vafai.
2803
2804         nrwt multiprocessing - start over, prepare to fork the code
2805  
2806         This code cleans up the signatures and implementation of the
2807         TestRunner class so we can easily fork it to run either the
2808         stable implementation or the new, unstable message-passing
2809         implementation. The two variants will have different
2810         implementations of the run_tests() method. We will switch
2811         between the two based on the setting for the '--worker-model'
2812         switch. We rename the two currently valid values to 'old-inline'
2813         and 'old-threads'.
2814
2815         https://bugs.webkit.org/show_bug.cgi?id=51081
2816
2817         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2818         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2819
2820 2010-12-22  Victor Wang  <victorw@chromium.org>
2821
2822         Reviewed by Darin Fisher.
2823
2824         [Chromium] Update chromium archive test result url in rebaseline script.
2825
2826         https://bugs.webkit.org/show_bug.cgi?id=51503
2827
2828         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2829
2830 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2831
2832         Reviewed by Alice Liu.
2833
2834         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
2835         Verified on Chrome, Safari, and IE.
2836         With this change, we will record memory from a parent browser window and all child processes.
2837
2838         * record-memory-win/main.cpp:
2839         (ProcessArgs):
2840         (PrintUsage):
2841         (getMemoryInfo):
2842         (printProcessInfo):
2843         (evalProcesses):
2844         (UseImage):
2845         (QueryContinuously):
2846         (ElapsedTime):
2847
2848 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2849
2850         Unreviewed rollout r74489, because it was missing changelog.
2851
2852         * record-memory-win/main.cpp:
2853         
2854 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
2855
2856         Adding myself as a reviewer.
2857
2858         * Scripts/webkitpy/common/config/committers.py:
2859
2860 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
2861
2862         Unreviewed.  Adding myself to committers.py.
2863
2864         * Scripts/webkitpy/common/config/committers.py:
2865
2866 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
2867
2868         Reviewed by Kenneth Rohde Christiansen.
2869
2870         TestNetscapePlugIn should use #if defined
2871         https://bugs.webkit.org/show_bug.cgi?id=51471
2872
2873         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2874         (NP_Initialize):
2875         (NPP_New):
2876
2877 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
2878
2879         Reviewed by Yury Semikhatsky.
2880
2881         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
2882
2883         DevTools window should be closed explicitly because it has custom deinitialization code.
2884
2885         https://bugs.webkit.org/show_bug.cgi?id=50722
2886
2887         * DumpRenderTree/chromium/TestShell.cpp:
2888         (TestShell::closeRemainingWindows):
2889
2890 2010-12-22  David Levin  <levin@chromium.org>
2891
2892         Reviewed by Shinichiro Hamaji.
2893
2894         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
2895         https://bugs.webkit.org/show_bug.cgi?id=51452
2896
2897         * Scripts/webkitpy/style/checkers/cpp.py:
2898         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
2899         Using the file extension if possible but falling back to the file contents if we have a header file.
2900         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
2901         (_FileState.is_c_or_objective_c):
2902         (check_using_std): Changed to using _FileState to determine the file type.
2903         (check_max_min_macros): Ditto.
2904         (check_for_null): Ditto.
2905         (check_style): Changed the parameters to various calls since they now need _FileState
2906         to determine the file type.
2907         (check_language): Added the file_state parameter so it could be passed
2908         to check_identifier_name_in_declaration.
2909         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
2910         this is an Objective C file.
2911         (_process_lines): Added information for the _FileState constructor (and moved the
2912         call to a place that had the information).
2913         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2914         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
2915         its functionality.
2916         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
2917
2918 2010-12-21  Andy Estes  <aestes@apple.com>
2919
2920         Reviewed by Mark Rowe.
2921
2922         Do not build non-Intel architectures for WebKit2-related projects.
2923         https://bugs.webkit.org/show_bug.cgi?id=51440
2924
2925         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
2926         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
2927         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2928
2929 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
2930
2931         Reviewed by Darin Fisher.
2932
2933         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
2934         https://bugs.webkit.org/show_bug.cgi?id=51406 
2935         
2936         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
2937         to WebThemeEngineDRTWin and update references everywhere.
2938
2939         * DumpRenderTree/DumpRenderTree.gypi:
2940         * DumpRenderTree/chromium/TestShellWin.cpp:
2941         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
2942         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
2943         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
2944         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
2945
2946 2010-12-21  Anders Carlsson  <andersca@apple.com>
2947
2948         Reviewed by John Sullivan.
2949
2950         Clicking missing plug-in text does not show a sheet
2951         https://bugs.webkit.org/show_bug.cgi?id=51403
2952
2953         Update for changes to the WebPageUIClient.
2954
2955         * MiniBrowser/mac/BrowserWindowController.m:
2956         (-[BrowserWindowController awakeFromNib]):
2957         * WebKitTestRunner/TestController.cpp:
2958         (WTR::createOtherPage):
2959         (WTR::TestController::initialize):
2960
2961 2010-12-21  Eric Seidel  <eric@webkit.org>
2962
2963         Reviewed by Adam Barth.
2964
2965         commit-queue will report constant failures as flaky if other tests flake
2966         https://bugs.webkit.org/show_bug.cgi?id=51272
2967
2968         This patch just removes functionality and adds testing.
2969         Previously we attempted to report flaky tests when we had
2970         two different tests fail in a row.  However, since we stop
2971         running the tests at the first failure, our code was wrong in
2972         trying to determine flakiness from the incomplete runs.
2973
2974         Originally I posted an alternate patch:
2975         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
2976         which fixed our flaky logic in this case, however it was decided
2977         that that patch would be too difficult to maintain, so now
2978         I'm just removing the broken logic.
2979
2980         This will dramatically cut-down on our flaky-test false positives
2981         at the (small) cost of the queues being unable to report
2982         any flakiness if the tree is very flaky.  (With at least one test
2983         flaking on every run, we'll never report failures anymore.)  I think
2984         this is a tradeoff worth making.
2985
2986         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2987         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2988
2989 2010-12-20  Eric Seidel  <eric@webkit.org>
2990
2991         Reviewed by Adam Barth.
2992
2993         commit-queue wrongly rejects patches when it can't update itself
2994         https://bugs.webkit.org/show_bug.cgi?id=46636
2995
2996         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2997         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2998         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2999
3000 2010-12-20  Adam Barth  <abarth@webkit.org>
3001
3002         Move web sites to Websites directory
3003         https://bugs.webkit.org/show_bug.cgi?id=51323
3004
3005         Update references to BugsSite to point to the new location.
3006
3007         This patch was never officially reviewed (because it was too large to
3008         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
3009         Rowe gave me the green light.
3010
3011         * Scripts/old-run-webkit-tests:
3012         * Scripts/webkitpy/common/config/build.py:
3013         * Scripts/webkitpy/common/config/build_unittest.py:
3014         * Scripts/webkitpy/common/prettypatch.py:
3015         * Scripts/webkitpy/layout_tests/port/base.py:
3016         * Scripts/webkitpy/style/main.py:
3017
3018 2010-12-20  Adrienne Walker  <enne@google.com>
3019
3020         Unreviewed. Adding myself to the list of committers.
3021
3022         * webkitpy/common/config/committers.py:
3023
3024 2010-12-20  Mark Rowe  <mrowe@apple.com>
3025
3026         Reviewed by Dan Bernstein.
3027
3028         <rdar://problem/8757601> Don't install header files in to the Resources directory.
3029
3030         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
3031         Resources directory.
3032
3033 2010-12-20  Eric Seidel  <eric@webkit.org>
3034
3035         Reviewed by Adam Barth.
3036
3037         commit-queue should include bot id when attaching failure diffs
3038         https://bugs.webkit.org/show_bug.cgi?id=51280
3039
3040         This is a tiny change to include the bot id in the name of the attachment.
3041         Most of this diff is just changing the unit test expectations
3042         now that I hid the comment printing when the comment is None.
3043
3044         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3045         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3046         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3047         * Scripts/webkitpy/tool/mocktool.py:
3048
3049 2010-12-20  Jeff Miller  <jeffm@apple.com>
3050
3051         Reviewed by Dan Bernstein.
3052
3053         Tools/vcbin/midl.exe needs to be rebuilt
3054         https://bugs.webkit.org/show_bug.cgi?id=51347
3055
3056         * vcbin/midl.exe: Rebuilt.
3057
3058 2010-12-20  David Levin  <levin@chromium.org>
3059
3060         Reviewed by Ariya Hidayat.
3061
3062         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
3063         https://bugs.webkit.org/show_bug.cgi?id=51343
3064
3065         Follow up from the WebKitTools -> Tools rename.
3066
3067         * Scripts/webkit-tools-completion.sh:
3068
3069 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
3070
3071         Reviewed by James Robinson.
3072
3073         new-run-webkit-tests ignores trailing EOL differences in text tests
3074         https://bugs.webkit.org/show_bug.cgi?id=36983
3075
3076         Changed the handling of new-line characters within new-run-webkit-tests
3077         to match old-run-webkit-tests.  Differences in leading and trailing empty
3078         lines in text expectation files are no longer ignored.
3079
3080         * Scripts/webkitpy/layout_tests/port/base.py:
3081         * Scripts/webkitpy/layout_tests/port/test.py:
3082         Added unit tests.  Removed old duplicate unit test entries.
3083         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3084
3085 2010-12-20  David Levin  <levin@chromium.org>
3086
3087         Reviewed by Shinichiro Hamaji.
3088
3089         check-webkit-style should detect function declarations (and trivial functions).
3090         https://bugs.webkit.org/show_bug.cgi?id=51303
3091
3092         * Scripts/webkitpy/style/checkers/cpp.py:
3093         (_FunctionState.begin): Add is_declaration and changed the line count
3094         start to begin at -1 (which will keep the results consistent, since
3095         the starting line number passed in is one less in this change).
3096         (detect_functions): changed function detection to now catch trivial
3097         functions and declarations.
3098         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
3099         of the function as this may look at return values (when processing
3100         a declaration).
3101         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3102         (FunctionDetectionTest.perform_function_detection): Basic mechanics
3103         of testing the function detection.
3104         (FunctionDetectionTest.test_basic_function_detection): Test a simple
3105         function.
3106         (FunctionDetectionTest.test_function_declaration_detection): Test a
3107         declaration.
3108         (FunctionDetectionTest.test_non_functions): A test case for a case
3109         that caused the code to fail due to the { being in quotes.
3110         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
3111         cases to help catch false alarms for return values.
3112         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
3113         we don't get false alarms for member variables either.
3114
3115 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
3116
3117         Reviewed by Antonio Gomes.
3118
3119         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
3120         https://bugs.webkit.org/show_bug.cgi?id=51319
3121
3122         * CMakeListsEfl.txt:
3123
3124 2010-12-18  Adam Barth  <abarth@webkit.org>
3125
3126         Reviewed by Sam Weinig.
3127
3128         Move WebKitExamplePlugins to Examples
3129         https://bugs.webkit.org/show_bug.cgi?id=51291
3130
3131         * Scripts/webkitpy/common/config/build.py:
3132
3133 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
3134
3135         Unreviewed Qt buildfix after r74301.
3136
3137         Rename WebKitTools to Tools
3138         https://bugs.webkit.org/show_bug.cgi?id=49861
3139
3140         * MiniBrowser/DerivedSources.pro:
3141         * MiniBrowser/qt/MiniBrowser.pro:
3142
3143 2010-12-17  Dan Bernstein  <mitz@apple.com>
3144
3145         Reviewed by Simon Fraser.
3146
3147         Rename WebKitTools to Tools
3148         https://bugs.webkit.org/show_bug.cgi?id=49861
3149
3150         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3151         * CodeCoverage/README:
3152         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3153         (WebCore::DumpRenderTree::initializeFonts):
3154         * EWSTools/start-commit-queue.sh:
3155         * EWSTools/start-queue.sh:
3156         * GNUmakefile.am:
3157         * MIDLWrapper/MIDLWrapper.cpp:
3158         (wmain):
3159         * MiniBrowser/qt/MiniBrowser.pro:
3160         * Scripts/build-api-tests:
3161         * Scripts/build-dumprendertree:
3162         * Scripts/build-webkit:
3163         * Scripts/build-webkittestrunner:
3164         * Scripts/generate-coverage-data:
3165         * Scripts/old-run-webkit-tests:
3166         * Scripts/run-api-tests:
3167         * Scripts/run-iexploder-tests:
3168         * Scripts/run-javascriptcore-tests:
3169         * Scripts/run-mangleme-tests:
3170         * Scripts/run-sunspider:
3171         * Scripts/run-webkit-websocketserver:
3172         * Scripts/sunspider-compare-results:
3173         * Scripts/test-webkitperl:
3174         * Scripts/test-webkitpy:
3175         * Scripts/update-iexploder-cssproperties:
3176         * Scripts/update-webkit:
3177         * Scripts/update-webkit-localizable-strings:
3178         * Scripts/webkitdirs.pm:
3179         * Scripts/webkitpy/common/checkout/scm.py:
3180         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3181         * Scripts/webkitpy/common/config/committervalidator.py:
3182         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
3183         * Scripts/webkitpy/common/config/ports.py:
3184         * Scripts/webkitpy/common/config/ports_unittest.py:
3185         * Scripts/webkitpy/common/system/logutils_unittest.py:
3186         * Scripts/webkitpy/common/system/ospath_unittest.py:
3187         * Scripts/webkitpy/layout_tests/port/chromium.py:
3188         * Scripts/webkitpy/layout_tests/port/config.py:
3189         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3190         * Scripts/webkitpy/layout_tests/port/http_server.py:
3191         * Scripts/webkitpy/layout_tests/port/test.py:
3192         * Scripts/webkitpy/style/checker.py:
3193         * Scripts/webkitpy/style/checker_unittest.py:
3194         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3195         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3196         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3197         * WebKitTestRunner/DerivedSources.pro:
3198         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3199         (WTR::activateFonts):
3200         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3201         * wx/build/build_utils.py:
3202
3203 2010-12-16  Antonio Gomes  <agomes@rim.com>
3204
3205         Reviewed by Martin Robinson.
3206
3207         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
3208         https://bugs.webkit.org/show_bug.cgi?id=51163
3209
3210         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
3211         GTK+'s DRT should also reset to UNIX after each test execution.
3212
3213         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3214         (resetDefaultsToConsistentValues):
3215
3216 2010-12-17  David Levin  <levin@chromium.org>
3217
3218         Reviewed by Eric Seidel.
3219
3220         check-webkit-style should understand WTF #include guards
3221         https://bugs.webkit.org/show_bug.cgi?id=44911
3222
3223         * Scripts/webkitpy/style/checkers/cpp.py:
3224         (get_header_guard_cpp_variable): modify to suggest the WTF style
3225         of header guard when appropriate.
3226         (check_for_header_guard): handle multiple return values from
3227         get_header_guard_cpp_variable
3228         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3229         (CppStyleTest.test_build_header_guard): Added tests for the WTF
3230         header style.
3231
3232 2010-12-16  David Levin  <levin@chromium.org>
3233
3234         Reviewed by Eric Seidel.
3235
3236         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
3237         https://bugs.webkit.org/show_bug.cgi?id=51210
3238
3239         The error only shows up when using python 2.6 or later.
3240
3241         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
3242         the decprecated field error,message with something equivalent.
3243
3244 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
3245
3246         Reviewed by Eric Seidel.
3247
3248         Add --exit-after-n-failures/crashes to NRWT
3249         https://bugs.webkit.org/show_bug.cgi?id=51160
3250         
3251         Abort test run (in a similar way to how control-C is handled) when
3252         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
3253         that number of unexpected failures/crashes/timeouts.
3254
3255         * Scripts/webkitpy/layout_tests/port/test.py:
3256         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3257         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3258
3259 2010-12-16  David Levin  <levin@chromium.org>
3260
3261         Reviewed by Shinichiro Hamaji.
3262
3263         check-webkit-style unit tests has some duplicate boilerplate code.
3264         https://bugs.webkit.org/show_bug.cgi?id=49519
3265
3266         * Scripts/webkitpy/style/checkers/cpp.py:
3267         (update_include_state): Replaced the "io" parameter with the global
3268         configuration _unit_test_config. This allowed not calling into
3269         functions at a low level and also not plumbing through the injection
3270         information through many levels of code.
3271         (check_for_include_what_you_use): Ditto.
3272         (process_file_data): Added the ability to set up the unit test config
3273         to allow for injection.
3274         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3275         (ErrorCollector.__init__): Added support for having a filter for errors.
3276         (ErrorCollector.__call__): Ditto.
3277         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
3278         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
3279         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
3280         functions in the cpp.py with generic processing and a filter that
3281         indicates what errors should be kept.
3282         (CppStyleTestBase.perform_multi_line_lint): Ditto.
3283         (CppStyleTestBase.perform_language_rules_check): Ditto.
3284         (CppStyleTestBase.perform_function_lengths_check): Ditto.
3285         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
3286         (CppStyleTestBase.perform_include_what_you_use): Ditto.
3287         (CppStyleTest.test_multi_line_comments): Added another
3288         error message which applies to the test case.
3289         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
3290         to not have config.h, since it is processed as a header file.
3291         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
3292         style and indentation in checked code.
3293         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
3294         Fixed line number.
3295         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
3296         Ditto.
3297
3298 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3299
3300         Unreviewed, rolling out r74136.
3301         http://trac.webkit.org/changeset/74136
3302         https://bugs.webkit.org/show_bug.cgi?id=51135
3303
3304         r74136 breaks chromium canary bots because some tests are not
3305         rebaselined correctly to resolve EOL differences (Requested by
3306         jianli on #webkit).
3307
3308         * Scripts/webkitpy/layout_tests/port/base.py:
3309         * Scripts/webkitpy/layout_tests/port/test.py:
3310         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3311
3312 2010-12-15  Adam Roben  <aroben@apple.com>
3313
3314         Teach check-webkit-style to check .vcproj and .vsprops files for XML
3315         syntax errors
3316
3317         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
3318         XML syntax errors in .vcproj/.vsprops files
3319
3320         Reviewed by Dave Levin.
3321
3322         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
3323         that should be treated as XML and that should be allowed to contain
3324         carriage returns. (These lists happen to be identical currently.)
3325         (FileType): Added a new XML type.
3326         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
3327         Just does a simple file extension check.
3328         (CheckerDispatcher._file_type): Added a case for XML files.
3329         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
3330         files (surprise!).
3331         (StyleProcessor.process): Ask the dispatcher whether we should pass the
3332         lines through the carriage checker.
3333
3334         * Scripts/webkitpy/style/checker_unittest.py:
3335         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
3336         Added. Checks a few file names to see if carriage returns are allowed
3337         or not.
3338         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
3339         other assert_checker_* functions.
3340         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3341         test_*_paths functions.
3342         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3343         test_*_paths functions.
3344         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
3345         file from this test case, as vcproj files now have a type.
3346         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
3347         Added. Similar to the other should_* functions.
3348         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
3349         Added. Checks that carriage returns aren't checked for or stripped for
3350         allowed files.
3351
3352         * Scripts/webkitpy/style/checkers/xml.py: Added.
3353         (XMLChecker.__init__): Simple init method.
3354         (XMLChecker.check): Pass each line through the expat parser, and record
3355         a style error for any errors thrown by the parser.
3356
3357         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
3358         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
3359         produce a style error.
3360         (XMLCheckerTest.assert_error): Checks that the given XML produces an
3361         error of the given category on the given line.
3362         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
3363         checking that the XMLChecker constructor works properly.
3364         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
3365         cause a style error (see, e.g., r73887).
3366         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
3367         cause a style error (see, e.g., r73773).
3368         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
3369         properly.
3370         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
3371         tags cause a style error (see, e.g., r72795).
3372         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
3373         style error.
3374
3375 2010-12-15  Lucas Forschler  <lforschler@apple.com>
3376
3377         Reviewed by Stephanie Lewis.
3378
3379         https://bugs.webkit.org/show_bug.cgi?id=51117
3380         Add a new leopard test bot
3381         really really commit to trunk this time.
3382
3383         * BuildSlaveSupport/build.webkit.org-config/config.json:
3384
3385 2010-12-15  Sam Weinig  <sam@webkit.org>
3386
3387         Reviewed by Anders Carlsson.
3388
3389         WebKit2: Can't add files to an <input type=file>
3390         https://bugs.webkit.org/show_bug.cgi?id=51087
3391
3392         * MiniBrowser/mac/BrowserWindowController.m:
3393         (runOpenPanel):
3394         (-[BrowserWindowController awakeFromNib]):
3395         Add simple implementation of runOpenPanel callback.
3396
3397         * MiniBrowser/win/BrowserView.cpp:
3398         (BrowserView::create):
3399         * WebKitTestRunner/TestController.cpp:
3400         (WTR::createOtherPage):
3401         (WTR::TestController::initialize):
3402         Stub out runOpenPanel callback. 
3403
3404 2010-12-14  Eric Seidel  <eric@webkit.org>
3405
3406         Reviewed by Adam Barth.
3407
3408         commit-queue should upload failure diffs when tests flake
3409         https://bugs.webkit.org/show_bug.cgi?id=51051
3410
3411         To make this testable I needed to pipe FileSystem down onto tool.
3412         We've wanted it there for a long time anyway.
3413
3414         This patch is kinda a big hack.  But we don't have a nice
3415         way to read results.html files.  I think this will need further
3416         revision before this code actually feels clean.
3417
3418         As part of testing this change, I had to make MockBugzilla.create_bug
3419         actually return an id (like it should) which required updating
3420         a few other unit test results (for the better).
3421
3422         The results_matching_keys change in layouttestresults/rebasline
3423         was an alternate path which I decided not to use in the end, but
3424         I left the change as it seemed an improvement.
3425
3426         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3427         * Scripts/webkitpy/common/net/layouttestresults.py:
3428         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3429         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3430         * Scripts/webkitpy/tool/commands/queues.py:
3431         * Scripts/webkitpy/tool/commands/rebaseline.py:
3432         * Scripts/webkitpy/tool/main.py:
3433         * Scripts/webkitpy/tool/mocktool.py:
3434
3435 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
3436
3437         Reviewed by James Robinson.
3438
3439         new-run-webkit-tests ignores trailing EOL differences in text tests
3440         https://bugs.webkit.org/show_bug.cgi?id=36983
3441
3442         Changed the handling of new-line characters within new-run-webkit-tests
3443         to match old-run-webkit-tests.  Differences in leading and trailing empty
3444         lines in text expectation files are no longer ignored.
3445
3446         * Scripts/webkitpy/layout_tests/port/base.py:
3447         * Scripts/webkitpy/layout_tests/port/test.py:
3448         Added unit tests.  Removed old duplicate unit test entries.
3449         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3450
3451 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3452
3453         Reviewed by Adam Barth.
3454
3455         make status-bubble white-space:nowrap so we can measure it's width without wrapping
3456         https://bugs.webkit.org/show_bug.cgi?id=51149
3457
3458         * QueueStatusServer/templates/statusbubble.html:
3459
3460 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3461
3462         Reviewed by Adam Barth.
3463
3464         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
3465         https://bugs.webkit.org/show_bug.cgi?id=51125
3466
3467         * QueueStatusServer/templates/statusbubble.html:
3468
3469 2010-12-15  Darin Adler  <darin@apple.com>
3470
3471         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
3472
3473 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3474
3475         Unreviewed, rolling out r74117.
3476         http://trac.webkit.org/changeset/74117
3477         https://bugs.webkit.org/show_bug.cgi?id=51113
3478
3479         This broke the GTK1 build. (Requested by mrobinson on
3480         #webkit).
3481
3482         * Scripts/webkitdirs.pm:
3483
3484 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
3485
3486         Reviewed by Martin Robinson.
3487
3488         Change generate-forwarding-headers.pl for GTK port usage 
3489         (https://bugs.webkit.org/show_bug.cgi?id=37369)
3490
3491         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
3492
3493 2010-12-14  Kent Tamura  <tkent@chromium.org>
3494
3495         Reviewed by Jian Li.
3496
3497         [DRT/Chromium] Remove another unnecessary error message
3498         https://bugs.webkit.org/show_bug.cgi?id=51083
3499
3500         * DumpRenderTree/chromium/WebViewHost.cpp:
3501         (WebViewHost::didInvalidateRect):
3502
3503 2010-12-14  Lucas Forschler  <lforschler@apple.com>
3504
3505         Reviewed by Stephanie Lewis.
3506
3507         Add a new Leopard Debug Test WK2 Bot
3508
3509         * BuildSlaveSupport/build.webkit.org-config/config.json:
3510
3511 2010-12-14  Ojan Vafai  <ojan@chromium.org>
3512
3513         Fix python unittests after http://trac.webkit.org/changeset/74070.
3514
3515         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3516
3517 2010-12-14  Kent Tamura  <tkent@chromium.org>
3518
3519         Reviewed by Jian Li.
3520
3521         [DRT/Chromium] Remove a unnecessary error message
3522         https://bugs.webkit.org/show_bug.cgi?id=51069
3523
3524         * DumpRenderTree/chromium/WebViewHost.cpp:
3525         (WebViewHost::paintInvalidatedRegion):
3526
3527 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
3528
3529         Reviewed by Ojan Vafai.
3530
3531         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
3532         https://bugs.webkit.org/show_bug.cgi?id=48926
3533
3534         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3535         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
3536
3537 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3538
3539         Reviewed by Eric Seidel.
3540
3541         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
3542         https://bugs.webkit.org/show_bug.cgi?id=50231
3543
3544         Guard CONFIG+=link_pkgconfig with !symbian.
3545
3546         * DumpRenderTree/qt/DumpRenderTree.pro:
3547         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3548         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3549
3550 2010-12-14  Philippe Normand  <pnormand@igalia.com>
3551
3552         Reviewed by Ojan Vafai.
3553
3554         [new-run-webkit-tests] expectations parsing is slow
3555         https://bugs.webkit.org/show_bug.cgi?id=50635
3556
3557         Avoid expensive iteration of all the tests when checking if a test
3558         file is to be skipped or not.
3559
3560         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3561         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3562         * Scripts/webkitpy/layout_tests/port/test.py:
3563
3564 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
3565
3566         Reviewed by Xan Lopez.
3567
3568         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
3569         https://bugs.webkit.org/show_bug.cgi?id=27048
3570
3571         Add support in DRT for checking whether an accessibility UI
3572         element is focusable and/or focused. Implemented for GTK.
3573
3574         * DumpRenderTree/AccessibilityUIElement.cpp:
3575         (getIsFocusedCallback): New.
3576         (getIsFocusableCallback): New.
3577         (AccessibilityUIElement::getJSClass): Add the new available
3578         callbacks for isFocused and isFocusable.
3579         * DumpRenderTree/AccessibilityUIElement.h:
3580         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3581         (AccessibilityUIElement::isFocused): New, implemented by checking
3582         whether the related AtkState value is in the object's state set.
3583         (AccessibilityUIElement::isFocusable): Ditto.
3584         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3585         (AccessibilityUIElement::isFocused): New, dummy implementation.
3586         (AccessibilityUIElement::isFocusable): Ditto.
3587         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3588         (AccessibilityUIElement::isFocused): Ditto.
3589         (AccessibilityUIElement::isFocusable): Ditto.
3590
3591 2010-12-14  Eric Seidel  <eric@webkit.org>
3592
3593         Reviewed by Ojan Vafai.
3594
3595         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
3596         https://bugs.webkit.org/show_bug.cgi?id=50715
3597
3598         This patch makes webkit-patch print the following:
3599
3600         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
3601         Install a 64-bit git for better performance, see:
3602         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
3603
3604         I wrote this mostly because I have approximately 8 machines that I use
3605         and making sure each one is using a good Git install seemed folly.
3606         webkit-patch makes a lot of git calls, so using a fast git can shave
3607         several seconds in every invocation.  See the webkit-dev thread for more info.
3608
3609         This message will print twice during 'webkit-patch upload',
3610         once from webkit-patch and once from check-webkit-style.
3611
3612         Unfortunately there is no good way to test this due to how machine-dependent
3613         the code is.  I considered writing a test for the log message, but it seemed not worth it.
3614
3615         * Scripts/webkitpy/common/checkout/scm.py:
3616
3617 2010-12-13  Eric Seidel  <eric@webkit.org>
3618
3619         Reviewed by Adam Barth.
3620
3621         FlakyTestReporter doesn't understand bots running from multiple email addresses
3622         https://bugs.webkit.org/show_bug.cgi?id=50960
3623
3624         This explains at least one of the dupes of:
3625         https://bugs.webkit.org/show_bug.cgi?id=50863
3626         that we saw filed by the commit-queue this morning.
3627         I think the other one was explained by my previous fix to result counting code.
3628
3629         Since this is really hard to test with a unit test, instead I
3630         create a new (possibly useful in the future) command
3631         which given a layout test path will return you
3632         the one bug which our tools would assume it the flaky test bug.
3633         If some other script wants to use bug-for-test we'll
3634         need to extend it with some options like --create-if-missing or similar.
3635
3636         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3637         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3638         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3639         * Scripts/webkitpy/tool/commands/__init__.py:
3640         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
3641
3642 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
3643
3644         Reviewed by James Robinson.
3645
3646         Add option to build-webkit to not build WebKit2
3647         https://bugs.webkit.org/show_bug.cgi?id=50988
3648         
3649         Add support for a --no-webkit2 option to build-webkit. It seems to save
3650         ~1 minute from clean builds and ~10 seconds from no-op builds.
3651
3652         * Scripts/build-webkit:
3653
3654 2010-12-13  Lucas Forschler  <lforschler@apple.com>
3655
3656         Reviewed by Dave Kilzer.
3657
3658         Update iexploder from 1.3.2 to 1.7.2
3659         Move 1.3.2 into its own subdir
3660         Add 1.7.2 into its own subdir
3661         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
3662
3663         * Scripts/run-iexploder-tests:
3664         * Scripts/update-iexploder-cssproperties:
3665         * iExploder/CHANGELOG.txt: Removed.
3666         * iExploder/LICENSE.txt: Removed.
3667         * iExploder/README.txt: Removed.
3668         * iExploder/htdocs: Removed.
3669         * iExploder/iexploder-1.3.2: Added.
3670         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
3671         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
3672         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
3673         * iExploder/iexploder-1.3.2/htdocs: Added.
3674         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
3675         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs