Add /T to TaskKill.exe
[WebKit-https.git] / Tools / ChangeLog
1 2011-04-13  Lucas Forschler  <lforschler@apple.com>
2
3         Reviewed by Adam Roben.
4
5         Add the /T command to taskkill.exe.
6         This will kill spawned child processes.
7         
8         * BuildSlaveSupport/win/kill-old-processes:
9
10 2011-04-13  Lucas Forschler  <lforschler@apple.com>
11
12         Reviewed by Adam Roben.
13
14         Sort kill list alphabeticaly.
15         Fixed capitalization on VcBuildHelper.  
16
17         * BuildSlaveSupport/win/kill-old-processes:
18
19 2011-04-13  Lucas Forschler  <lforschler@apple.com>
20
21         Reviewed by Adam Roben.
22
23         https://bugs.webkit.org/show_bug.cgi?id=58384
24         Update kill-old-processes to include a few new ones.
25         
26         * BuildSlaveSupport/win/kill-old-processes:
27
28 2011-04-13  Gustavo Noronha Silva  <gns@gnome.org>
29
30         Reviewed by Martin Robinson.
31
32         [GTK] PluginPackage should check whether a plugin mixes GTK+ 2 and 3 symbols itself
33         https://bugs.webkit.org/show_bug.cgi?id=58297
34
35         Do not disable flash specifically when built with GTK+ 3 -
36         PluginPackage should do the right thing while loading plugins.
37
38         * GtkLauncher/main.c:
39         (main):
40
41 2011-04-12  Kent Tamura  <tkent@chromium.org>
42
43         Reviewed by Dimitri Glazkov.
44
45         [Chromium] Add WebSettings::setValidationMessageTimerMagnification()
46         https://bugs.webkit.org/show_bug.cgi?id=57426
47
48         * DumpRenderTree/chromium/WebPreferences.cpp:
49         (WebPreferences::applyTo): Disable the validation message timer.
50
51 2011-04-12  James Kozianski  <koz@chromium.org>
52
53         Unreviewed.
54
55         Adding myself to committers.py.
56
57         * Scripts/webkitpy/common/config/committers.py:
58
59 2011-04-12  Brent Fulgham  <bfulgham@webkit.org>
60
61         Unreviewed build correction for WinCairo bot after r83639.
62         https://bugs.webkit.org/show_bug.cgi?id=51790
63
64         Correct typo for the new "update-webkit-wincairo-libs" script.
65
66         * Scripts/build-webkit: Incorrectly calling the
67           update-webkit-cairo-libs which does not exist.
68
69 2011-04-12  Alice Liu  <alice.liu@apple.com>
70
71         Reviewed by Jon Honeycutt.
72
73         A change that should have been part of http://trac.webkit.org/changeset/83628
74
75         * DumpRenderTree/win/DumpRenderTree.cpp:
76         (resetDefaultsToConsistentValues): Setting should be off for most tests. Reset to false.
77
78 2011-04-12  Dirk Pranke  <dpranke@chromium.org>
79
80         Reviewed by Tony Chang.
81
82         new-run-webkit-tests: --results-directory is relative to builddir, not $PWD
83         https://bugs.webkit.org/show_bug.cgi?id=58272
84
85         NRWT was interpreting the --results-directory cmd line arg as
86         relative to the build directory, not the current working
87         directory (ORWT uses the latter, which is much more intuitive).
88         
89         This patch fixes the base case, but includes an override for
90         Chromium that is needed until the bots can be updated.
91
92         * Scripts/webkitpy/layout_tests/port/base.py:
93         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
94         * Scripts/webkitpy/layout_tests/port/chromium.py:
95         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
96         * Scripts/webkitpy/layout_tests/port/test.py:
97         * Scripts/webkitpy/layout_tests/port/webkit.py:
98         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
99         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
100
101 2011-04-12  Philippe Normand  <pnormand@igalia.com>
102
103         Unreviewed, roll out r83621 as it broke the GTK build.
104
105         [GTK] arguments passed to build-jsc and build-webkit scripts are not taken into account
106         https://bugs.webkit.org/show_bug.cgi?id=58333
107
108         * Scripts/build-jsc:
109         * Scripts/build-webkit:
110
111 2011-04-12  Carl Lobo  <carllobo@gmail.com> and Brent Fulgham <bfulgham@webkit.org>
112
113         Reviewed by Adam Roben.
114
115         Patch to download the WinCairo dependancies as part of build-webkit.
116         https://bugs.webkit.org/show_bug.cgi?id=51790
117
118         This patch downloads the dependancies from 
119             http://idisk.mac.com/bfulgham-Public/WinCairoRequirements.zip 
120         checking the modification timestamp etc. 
121
122         * Tools/Scripts/build-webkit
123         * Tools/Scripts/update-webkit: Modified to understand the --wincairo
124           flag, and to update WinCairo dependencies when used.
125         * Tools/Scripts/update-webkit-cairo-libs: added
126         * Tools/Scripts/update-webkit-dependency: added
127         * Tools/Scripts/update-webkit-auxiliary-libs
128
129 2011-04-12  Jeff Miller  <jeffm@apple.com>
130
131         Reviewed by Adam Roben.
132
133         WebKit2: Pressing Tab in Web Inspector's console does not cycle through completion options
134         https://bugs.webkit.org/show_bug.cgi?id=56020
135
136         Don't call TranslateMessage() in the MiniBrowser or TestWebKitAPI for key messages destined for a WebKit2 view,
137         since WebKit will do this for us.  If we didn't do this, TranslateMessage() would be called twice,
138         which would generate two characters for every keypress (for example).  I didn't bother doing this for
139         WebKitTestRunner, since it doesn't get any WM_KEYDOWN events.
140         
141         Add new WebKit2/TranslateMessageGeneratesWMChar test to test expected TranslateMessage() behavior.
142
143         * MiniBrowser/win/main.cpp:
144         (shouldTranslateMessage): Added.
145         (_tWinMain): Don't call TranslateMessage() unless shouldTranslateMessage() says to.
146         * TestWebKitAPI/PlatformUtilities.h: Added shouldTranslateMessage() on Windows.
147         * TestWebKitAPI/PlatformWebView.h: Added simulateAKeyDown().
148         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp: Added.
149         (TestWebKitAPI::didNotHandleKeyEventCallback): Added.
150         (TestWebKitAPI::runAndWatchForWMChar): Added.
151         (TestWebKitAPI::TEST): Added.
152         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
153         (TestWebKitAPI::Util::run): Don't call TranslateMessage() unless shouldTranslateMessage() says to.
154         (TestWebKitAPI::Util::shouldTranslateMessage): Added.
155         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
156         (TestWebKitAPI::PlatformWebView::simulateAKeyDown): Added.
157         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added TranslateMessageGeneratesWMChar.cpp.
158
159 2011-04-12  Dirk Pranke  <dpranke@chromium.org>
160
161         Reviewed by Tony Chang.
162
163         new-run-webkit-tests: update code to use port.results_directory() instead of options.results_directory
164         https://bugs.webkit.org/show_bug.cgi?id=58290
165
166         This is some preliminary refactoring for bug 58272.
167
168         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
169         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
170         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
171         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
172         * Scripts/webkitpy/layout_tests/port/test.py:
173         * Scripts/webkitpy/layout_tests/port/chromium.py:
174         * Scripts/webkitpy/layout_tests/port/base.py:
175         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
176
177 2011-04-12  Dirk Pranke  <dpranke@chromium.org>
178
179         Reviewed by Eric Seidel.
180
181         webkitpy: fix mock_filesystem abspath to handle relative paths
182         and add filesystem.chdir() and filesystem.getcwd() to be able
183         to test this and mock it out.
184
185         https://bugs.webkit.org/show_bug.cgi?id=58288
186
187         * Scripts/webkitpy/common/system/filesystem.py:
188         * Scripts/webkitpy/common/system/filesystem_mock.py:
189         * Scripts/webkitpy/common/system/filesystem_unittest.py:
190
191 2011-04-12  Alice Liu  <alice.liu@apple.com>
192
193         Reviewed by Sam Weinig.
194
195         https://bugs.webkit.org/show_bug.cgi?id=58292
196         Provide new setting to allow site icon loading despite disabling automatic image loading in general.
197
198         * DumpRenderTree/mac/DumpRenderTree.mm:
199         (resetDefaultsToConsistentValues): Setting should be off for most tests. Reset to false.
200
201 2011-04-12  Thouraya ANDOLSI  <thouraya.andolsi@st.com>
202
203         Reviewed by Eric Seidel.
204
205         [Qt] Enable JIT build for SH4 platforms.
206         https://bugs.webkit.org/show_bug.cgi?id=58317
207
208
209         * DumpRenderTree/qt/DumpRenderTree.pro:
210         * QtTestBrowser/QtTestBrowser.pro:
211         * Scripts/webkitdirs.pm:
212
213 2011-04-12  Tony Chang  <tony@chromium.org>
214
215         Reviewed by Andreas Kling.
216
217         [Qt] embed checksums in PNGs written by Qt-DRT
218         https://bugs.webkit.org/show_bug.cgi?id=58173
219
220         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
221         (WebCore::DumpRenderTree::dump):
222
223 2011-04-12  Eric Seidel  <eric@webkit.org>
224
225         Reviewed by Adam Barth.
226
227         commit-queue should upload failure diffs when tests fail
228         https://bugs.webkit.org/show_bug.cgi?id=58348
229
230         This change was mostly just plumbing.  We were already saving
231         this information for flaky test reporting.  I just made it possible
232         for normal failures to report archives as well.
233
234         I did a little abstraction work to try and share some code between
235         flakytestreporter.py and this new code.  There is still more we could do.
236
237         In making this change I also went through and updated the various
238         places we have urls hard-coded in our python and pointed them at
239         common.config.urls.
240
241         * Scripts/webkitpy/common/checkout/scm.py:
242         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
243         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
244         * Scripts/webkitpy/common/net/statusserver.py:
245         * Scripts/webkitpy/layout_tests/port/base.py:
246         * Scripts/webkitpy/tool/bot/botinfo.py: Added.
247         * Scripts/webkitpy/tool/bot/botinfo_unittest.py: Added.
248         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
249         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
250         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
251         * Scripts/webkitpy/tool/commands/queues.py:
252
253 2011-04-12  Daniel Bates  <dbates@rim.com>
254
255         Rubber-stamped by Eric Seidel.
256
257         svn-apply and/or patch(1) has trouble applying patches that makes changes to files
258         with Windows line endings
259         https://bugs.webkit.org/show_bug.cgi?id=53625
260
261         Fixes an issue where a patch made on a SCM checkout on a Unix file system cannot be
262         applied to an SCM checkout on a Windows file system and vice-versa.
263
264         This issue manifests itself due to custom SCM settings as well as differences in
265         gitattributes support in older versions of Git (e.g. 1.7.0.3). We implement support
266         into svn-apply/unapply to compensate for differences in line endings by converting
267         the line endings in a patch to match the line endings in the target file (if it exists).
268
269         * Scripts/VCSUtils.pm:
270           - Added parseFirstEOL(), which returns the first end-of-line character(s) that appear in the
271             content read from the specified file handle. Obviously, this heuristic will not work
272             for files with mixed line endings, but I don't envision such files to be the norm. If
273             this turns out to be an issue then we can improve the heuristic.
274           - Added firstEOLInFile().
275           - Modified parsePatch() and parseDiff() to take an optional hash reference to an options hash.
276             In particular, added the hash key shouldNotUseIndexPathEOL to control whether to use the line
277             endings in the diff instead of the line endings in the target file.
278           - Extracted local variable $chunkRangeRegEx from fixChangeLogPatch() so that it can be
279             re-used in parseDiff().
280         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Modified to pass {shouldNotUseIndexPathEOL => 1}
281           to parsePatch() since these unit tests don't create mock files. Instead, created unit tests that use
282           mock files in file VCSUtils_unittest/parseDiffWithMockFiles.pl.
283         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl: Added.
284         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl: Added.
285
286 2011-04-12  Sam Weinig  <sam@webkit.org>
287
288         Reviewed by Adam Roben.
289
290         REGRESSION (r83550): Multiple http tests crashing in the web process in SQLite beneath CFNetwork on Windows 7 Release (WebKit2 Tests)
291         https://bugs.webkit.org/show_bug.cgi?id=58336
292
293         * WebKitTestRunner/TestController.cpp:
294         (WTR::TestController::resetStateToConsistentValues):
295         Remove cache clearing as that is causing tests to crash on Windows 7.
296
297 2011-04-11  Sam Weinig  <sam@webkit.org>
298
299         Reviewed by Anders Carlsson.
300
301         REGRESSION(r77974): http/tests/security/aboutBlank/security-context-window-open.html is failing
302         <rdar://problem/8981346>
303         https://bugs.webkit.org/show_bug.cgi?id=54159
304
305         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
306         (WTR::InjectedBundlePage::InjectedBundlePage):
307         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
308         (WTR::InjectedBundlePage::decidePolicyForNewWindowAction):
309         (WTR::InjectedBundlePage::decidePolicyForResponse):
310         (WTR::InjectedBundlePage::unableToImplementPolicy):
311         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
312         Add short-circuited policy client which matches WebKit1.
313
314         * WebKitTestRunner/TestController.cpp:
315         (WTR::TestController::resetStateToConsistentValues):
316         Clear the cache between tests to ensure consistent results.
317
318 2011-04-11  George Guo  <George.Guo@nokia.com>
319
320         Reviewed by Eric Seidel.
321
322         prepare-ChangeLog support email input but -h did not show the option
323         https://bugs.webkit.org/show_bug.cgi?id=58164
324
325         Add email option to -h to improve the usability
326
327         * Scripts/prepare-ChangeLog:
328
329 2011-04-11  Dimitri Glazkov  <dglazkov@chromium.org>
330
331         Reviewed by Eric Carlson.
332
333         Rename MediaControls to MediaControlRootElement.
334         https://bugs.webkit.org/show_bug.cgi?id=58250
335
336         * Scripts/do-webcore-rename: Documented the renaming.
337
338 2011-04-11  Sam Weinig  <sam@webkit.org>
339
340         Fix Windows build.
341
342         * MiniBrowser/win/BrowserView.cpp:
343         (BrowserView::create):
344
345 2011-04-11  Sam Weinig  <sam@webkit.org>
346
347         Reviewed by Anders Carlsson.
348
349         Move focus management out of WebKit via  the UIClient
350         <rdar://problem/8784068>
351         https://bugs.webkit.org/show_bug.cgi?id=58278
352
353         * MiniBrowser/mac/BrowserWindowController.m:
354         (-[BrowserWindowController awakeFromNib]):
355         * WebKitTestRunner/TestController.cpp:
356         (WTR::TestController::createOtherPage):
357         (WTR::TestController::initialize):
358         Add stubs for new UIClient functions.
359
360 2011-02-03  Martin Robinson  <mrobinson@igalia.com>
361
362         Reviewed by Eric Seidel.
363
364         [GTK] The GTK+ DRT needs an implementation of the PlainTextController
365         https://bugs.webkit.org/show_bug.cgi?id=53605
366
367         Add an implementation of the PlainTextController for the GTK+ DRT.
368
369         * DumpRenderTree/gtk/DumpRenderTree.cpp:
370         (addControllerToWindow): Added this helper method.
371         (webViewWindowObjectCleared): Use the new helper to add EventSender
372         and the PlainTextController to the window object.
373         * GNUmakefile.am: Added PlainTextController source files.
374         * DumpRenderTree/gtk/PlainTextController.cpp: Added. This will rely
375         on DumpRenderTreeSupportGtk to convert a JSValueRef into a WebKitDOMRange
376         until that functionality exists somewhere in the WebKitGTK+ stack.
377         * DumpRenderTree/gtk/PlainTextController.h: Added.
378
379 2011-04-11  Yael Aharon  <yael.aharon@nokia.com>
380
381         Unreviewed.
382
383         Adding my IRC nick.
384
385         * Scripts/webkitpy/common/config/committers.py:
386
387 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
388
389         Reviewed by Adam Roben.
390
391         new-run-webkit-tests: fix crash when running under windows cmd.exe
392         https://bugs.webkit.org/show_bug.cgi?id=58197
393
394         We would intermittently crash when running NRWT directly under
395         cmd.exe on windows because we were sharing the stdin file
396         descriptor between the python process and the http server.
397         cmd.exe really didn't like that, and there was no reason to
398         share the descriptor, so we now use a PIPE instead.
399
400         * Scripts/webkitpy/layout_tests/port/http_server.py:
401
402 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
403
404         Reviewed by Ojan Vafai.
405
406         new-run-webkit-tests: add unit tests for Port.diff_image()
407         https://bugs.webkit.org/show_bug.cgi?id=58196
408
409         Add the unit tests for the fix in bug 58195.
410
411         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
412         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
413         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
414
415 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
416
417         Reviewed by Tony Chang.
418
419         new-run-webkit-tests: implement support for audio, take two
420         https://bugs.webkit.org/show_bug.cgi?id=58195
421
422         Attempt to re-land the fix for bug 58101 (which was initially
423         landed in r83330, but rolled out). This is the same patch but
424         fixes crashes in Port.diff_image() caused by the change for
425         empty image files being None instead of ''.
426
427         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
428         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
429         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
430         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
431         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
432         * Scripts/webkitpy/layout_tests/port/base.py:
433         * Scripts/webkitpy/layout_tests/port/chromium.py:
434         * Scripts/webkitpy/layout_tests/port/dryrun.py:
435         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
436         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
437         * Scripts/webkitpy/layout_tests/port/test.py:
438         * Scripts/webkitpy/layout_tests/port/webkit.py:
439
440 2011-04-11  Mario Sanchez Prada  <msanchez@igalia.com>
441
442         Reviewed by Xan Lopez.
443
444         [GTK] Implement AccessibilityUIElement::{row|column}IndexRange in DRT
445         https://bugs.webkit.org/show_bug.cgi?id=57854
446
447         Implement missing features in GTK's DRT.
448
449         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
450         (indexRangeInTable): New helper function to get the range string
451         for the current cell inside the parent table, either from the
452         point of view of rows or columns.
453         (AccessibilityUIElement::rowIndexRange): Implemented by relying on
454         the new helper function indexRangeInTable().
455         (AccessibilityUIElement::columnIndexRange): Ditto.
456
457 2011-04-11  Mario Sanchez Prada  <msanchez@igalia.com>
458
459         Reviewed by Chris Fleizach.
460
461         [GTK] Implement AccessibilityUIElement::cellForColumnAndRow in DRT
462         https://bugs.webkit.org/show_bug.cgi?id=57826
463
464         Implement missing feature in GTK's DRT.
465
466         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
467         (AccessibilityUIElement::cellForColumnAndRow): Implemented, by
468         relying on the analogous function from the AtkTable interface.
469
470 2011-04-05  Timothy Hatcher  <timothy@apple.com>
471
472         Fix the extract-localizable-strings script errors that started after
473         WEB_UI_STRING was added to LocalizedStrings.h in WebCore.
474
475         * Scripts/extract-localizable-strings: Skip LocalizedStrings.h.
476
477 2011-04-11  Tony Chang  <tony@chromium.org>
478
479         Reviewed by Eric Seidel.
480
481         fix crc computation on 64 bit machines
482         https://bugs.webkit.org/show_bug.cgi?id=58243
483
484         unsigned long is dependenct on CPU architecture, so use unsigned which is always 32 bits
485
486         * DumpRenderTree/CyclicRedundancyCheck.cpp:
487         (makeCrcTable):
488         (computeCrc):
489         * DumpRenderTree/CyclicRedundancyCheck.h:
490         * DumpRenderTree/PixelDumpSupport.cpp:
491         (appendIntToVector):
492         (convertChecksumToPNGComment):
493
494 2011-04-10  Kimmo Kinnunen  <kimmo.t.kinnunen@nokia.com>
495
496         Reviewed by Eric Seidel.
497
498         Require no undefined symbols during compilation.
499
500         [Qt] [WK2] WebKitTestRunner, QtWebProcess and WTRInjectBundle should fail to compile when there's undefined symbols
501         https://bugs.webkit.org/show_bug.cgi?id=54896
502
503         Add -Wl,--no-undefined to catch missing symbols early.
504
505         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
506         * WebKitTestRunner/qt/WebKitTestRunner.pro:
507
508 2011-04-10  Kevin Ollivier  <kevino@theolliviers.com>
509
510         [wx] Unreviewed build fix. Remove collector dirs from the list of build dirs.
511
512         * wx/build/settings.py:
513
514 2011-04-10  Kevin Ollivier  <kevino@theolliviers.com>
515
516         [wx] Unreviewed build fix. Add Source/JavaScriptCore/heap to the list of directories.
517
518         * wx/build/settings.py:
519
520 2011-04-10  David Levin  <levin@chromium.org>
521
522         Reviewed by Dimitri Glazkov.
523
524         REGRESSION(r83384): Change to chromium.py is resulting in failures of the test framework on linux.
525         https://bugs.webkit.org/show_bug.cgi?id=58201
526
527         * Scripts/webkitpy/layout_tests/port/chromium.py: Commented out the assert for now,
528         and filed bug 58202.
529
530 2011-04-09  David Levin  <levin@chromium.org>
531
532         Unreviewed, rolling out r83394.
533         http://trac.webkit.org/changeset/83394
534         https://bugs.webkit.org/show_bug.cgi?id=53625
535
536         Patch was incorrect as noted in the bug.
537
538         * Scripts/svn-apply:
539
540 2011-04-09  David Levin  <levin@chromium.org>
541
542         Reviewed by Adam Barth.
543
544         svn-apply and/or patch(1) has trouble applying patches that makes changes to files with Windows line endings
545         https://bugs.webkit.org/show_bug.cgi?id=53625
546
547         * Scripts/svn-apply: Ensure that the portions of patches
548         which are for vcproj/vsprops files has DOS line endings.
549
550 2011-04-09  Dirk Pranke  <dpranke@chromium.org>
551
552         Reviewed by Tony Chang.
553
554         It looks like NRWT has not been stopping DRT/TestShell
555         instances properly on windows, probably for a long time.
556         This would go a long way to explaining why we often have
557         processes lying around :)
558
559         https://bugs.webkit.org/show_bug.cgi?id=57807
560
561         * Scripts/webkitpy/layout_tests/port/chromium.py:
562         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
563
564 2011-04-09  Keith Kyzivat  <keith.kyzivat@nokia.com>
565
566         Reviewed by Laszlo Gombos.
567
568         [Qt] Don't link against fontconfig or X11 if embedded
569         https://bugs.webkit.org/show_bug.cgi?id=58104
570
571         * DumpRenderTree/qt/DumpRenderTree.pro: fontconfig !included in embedded
572         * QtTestBrowser/QtTestBrowser.pro: ditto
573         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: ditto
574         * WebKitTestRunner/qt/WebKitTestRunner.pro: ditto
575
576 2011-04-08  Jon Honeycutt  <jhoneycutt@apple.com>
577
578         http/tests/loading/preload-append-scan.php is failing on Windows
579         https://bugs.webkit.org/show_bug.cgi?id=58178
580
581         Reviewed by Brian Weinstein.
582
583         * DumpRenderTree/win/DumpRenderTree.cpp:
584         (lastPathComponent):
585         Use CFURL API to find the last path component, rather than
586         PathFindFileName(), because the latter will include the query string.
587
588 2011-04-08  Jian Li  <jianli@chromium.org>
589
590         Unreviewed, rolling out r83327, r83330 since these patches are very
591         likely to break chromium webkit mac10.6 builders.
592
593         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
594         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
595         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
596         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
597         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
598         * Scripts/webkitpy/layout_tests/port/base.py:
599         * Scripts/webkitpy/layout_tests/port/chromium.py:
600         * Scripts/webkitpy/layout_tests/port/dryrun.py:
601         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
602         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
603         * Scripts/webkitpy/layout_tests/port/test.py:
604         * Scripts/webkitpy/layout_tests/port/webkit.py:
605
606 2011-04-08  Vincent Scheib  <scheib@chromium.org>
607
608         Reviewed by Eric Seidel.
609
610         add chromium-gpu-linux-x86_64 to the recognized list of ports
611         https://bugs.webkit.org/show_bug.cgi?id=58099
612
613         Add chromium-gpu-linux-x86_64 to fix assert.
614
615         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
616
617 2011-04-08  Alpha Lam  <hclam@chromium.org>
618
619         Unreviewed, rolling out r83335.
620         http://trac.webkit.org/changeset/83335
621         https://bugs.webkit.org/show_bug.cgi?id=53556
622
623         GTK and QT bots are broken
624
625         * Scripts/build-webkit:
626
627 2011-04-07  Anna Cavender  <annacc@chromium.org>
628
629         Reviewed by Eric Carlson.
630
631         Setup ENABLE(TRACK) feature define
632         https://bugs.webkit.org/show_bug.cgi?id=53556
633
634         * Scripts/build-webkit:
635
636 2011-04-08  Dirk Pranke  <dpranke@chromium.org>
637
638         Reviewed by Adam Roben.
639
640         new-run-webkit-tests: configure a NRWT test bot for Mac SL
641         https://bugs.webkit.org/show_bug.cgi?id=58114
642
643         This change removes the old new-run-webkit-tests entry and
644         updates it for a new test-only bot.
645
646         * BuildSlaveSupport/build.webkit.org-config/config.json:
647
648 2011-04-08  Dominic Cooney  <dominicc@google.com>
649
650         Reviewed by Adam Roben.
651
652         Make layoutTestController.shadowRoot return null, not undefined,
653         when its argument is invalid.
654         https://bugs.webkit.org/show_bug.cgi?id=58121
655
656         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
657         (LayoutTestController::shadowRoot):
658         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
659         (WTR::LayoutTestController::shadowRoot):
660
661 2011-04-08  Pere Martir  <pere.martir4@gmail.com>
662
663         Reviewed by Adam Roben.
664
665         Locate NSTD.EXE in 64-bit Windows
666         https://bugs.webkit.org/show_bug.cgi?id=57847
667
668         * Scripts/old-run-webkit-tests:
669
670 2011-04-08  Adam Roben  <aroben@apple.com>
671
672         Qt build fix
673
674         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Pull in stdarg.h for va_list.
675
676 2011-04-07  Adam Roben  <aroben@apple.com>
677
678         Test that NPP_SetWindow is passed a null window handle during plugin destruction on non-Mac platforms
679
680         Test for <http://webkit.org/b/47009> WebKit2 needs to call NPP_SetWindow when destroying a
681         plugin
682
683         Reviewed by Anders Carlsson.
684
685         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
686         (pluginLogWithArguments): Moved code to format and log the message here...
687         (pluginLog): ...from here.
688
689         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Added pluginLogWithArguments.
690
691         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
692         (PluginTest::log): Added. Calls through to pluginLogWithArguments.
693
694         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added log.
695
696         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp: Added.
697         (NPPSetWindowCalledDuringDestruction::setWillBeDestroyed): Records that destruction is about
698         to begin.
699         (NPPSetWindowCalledDuringDestruction::NPPSetWindowCalledDuringDestruction): Simple
700         constructor.
701         (NPPSetWindowCalledDuringDestruction::NPP_GetValue): Creates and returns a ScriptObject that
702         can be used to invoke our setWillBeDestroyed function.
703         (NPPSetWindowCalledDuringDestruction::NPP_SetWindow): Records what has happened (and logs if
704         anything unexpected happens).
705         (NPPSetWindowCalledDuringDestruction::NPP_Destroy): On Mac, logs a failure message if
706         NPP_SetWindow was called during destruction. On other platforms, logs a failure message if
707         NPP_SetWindow was *not* called during destruction.
708         (NPPSetWindowCalledDuringDestruction::ScriptObject::hasMethod): Return true for our only
709         method, setWillBeDestroyed.
710         (NPPSetWindowCalledDuringDestruction::ScriptObject::invoke): Call through to the PluginTest
711         object.
712
713         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
714         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
715         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
716         * GNUmakefile.am:
717         Added new test.
718
719         * Scripts/old-run-webkit-tests: Skip the new test when using out-of-process plugins with
720         WebKit1 on Mac, since it can't work properly due to <http://webkit.org/b/58077>.
721
722 2011-04-08  Mario Sanchez Prada  <msanchez@igalia.com>
723
724         Reviewed by Martin Robinson.
725
726         [GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement
727         https://bugs.webkit.org/show_bug.cgi?id=58039
728
729         Implement missing functions in GTK's DRT.
730
731         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
732         (AccessibilityUIElement::increment): Implemented.
733         (AccessibilityUIElement::decrement): Implemented.
734
735 2011-04-08  Dominic Cooney  <dominicc@google.com>
736
737         Reviewed by Kent Tamura.
738
739         Make WK2 layoutTestController.shadowRoot return undefined, not
740         null, when its argument is not an element.
741         https://bugs.webkit.org/show_bug.cgi?id=58121
742
743         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
744         (WTR::LayoutTestController::shadowRoot):
745
746 2011-04-07  Dirk Pranke  <dpranke@chromium.org>
747
748         Reviewed by Mihai Parparita.
749
750         Change reference port for Mac GPU baselines from
751         Leopard to SnowLeopard, XP to Win7, and Linux-x86
752         to Linux x86-64.
753
754         https://bugs.webkit.org/show_bug.cgi?id=58099
755
756         * Scripts/webkitpy/layout_tests/port/chromium.py:
757
758 2011-04-07  Andrew Scherkus  <scherkus@chromium.org>
759
760         Revert ENABLE_TRACK patch due to compile failures.
761
762         * Scripts/build-webkit:
763
764 2011-04-07  Tony Chang  <tony@chromium.org>
765
766         Reviewed by Eric Seidel.
767
768         update DRT to embed checksums in png files
769         https://bugs.webkit.org/show_bug.cgi?id=57871
770
771         We insert the bytes for the comment in printPNG rather than at encode
772         time because each platform does its own PNG encoding (either using CG
773         or cairo).  Putting this in pringPNG avoids having to duplicate this
774         code, although it's not as clean as doing it at encoding time.
775
776         We insert the comment right after the IHDR chunk of the PNG.
777
778         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
779         * DumpRenderTree/CyclicRedundancyCheck.cpp: Added.
780         (makeCrcTable): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
781         (computeCrc): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
782         * DumpRenderTree/CyclicRedundancyCheck.h: Added.
783         * DumpRenderTree/PixelDumpSupport.cpp:
784         (dumpWebViewAsPixelsAndCompareWithExpected):
785         (convertChecksumToPNGComment): Generate the bytes to insert.
786         (printPNG): Insert the png comment before the first IDAT section.
787         * DumpRenderTree/PixelDumpSupport.h:
788         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
789         (printPNG):
790         (dumpBitmap):
791         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
792         (printPNG):
793         (dumpBitmap):
794         * DumpRenderTree/win/DumpRenderTree.vcproj:
795         * GNUmakefile.am:
796
797 2011-04-07  Jeff Miller  <jeffm@apple.com>
798
799         Reviewed by Adam Roben.
800
801         Replace WKStringGetCharactersPtr() with WKStringGetCharacters()
802         https://bugs.webkit.org/show_bug.cgi?id=58058
803
804         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
805         (TestWebKitAPI::TEST): Add tests for  WKStringGetLength() and WKStringGetCharactersPtr().
806
807 2011-04-07  Chang Shu  <cshu@webkit.org>
808
809         Reviewed by Darin Adler.
810
811         WebKitTestRunner needs layoutTestController.isPageBoxVisible
812         https://bugs.webkit.org/show_bug.cgi?id=42695
813
814         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
815         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
816         (WTR::LayoutTestController::isPageBoxVisible):
817         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
818
819 2011-04-07  Adam Roben  <aroben@apple.com>
820
821         Build fix
822
823         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added a missing import.
824
825 2011-04-07  Adam Roben  <aroben@apple.com>
826
827         Move ExtractTestResults[AndLeaks]'s summarizing code back from commandComplete() to finished()
828
829         commandComplete() is never called for MasterShellCommands like ExtractTestResults[AndLeaks].
830         (Unfortunately the buildbot documentation does not make this clear.) finished() is the only
831         hook we have, so we have to do our work there. I added a new addCustomURLs method which can
832         be overridden by subclasses to provide extra URLs before we call up to the base class (after
833         which adding more URLs is no longer possible).
834
835         Really hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks
836         bot results page
837
838         Reviewed by John Sullivan.
839
840         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
841         (ExtractTestResults.addCustomURLs): Moved code to add the "view results" URL here...
842         (ExtractTestResults.finished): ...from here. This replaces commandComplete, since that
843         method is never called for MasterShellCommands.
844         (ExtractTestResultsAndLeaks.addCustomURLs): Replaced commandComplete (which is never called)
845         with this method (which is).
846
847 2011-04-07  Adam Roben  <aroben@apple.com>
848
849         Move ExtractTestResults[AndLeaks]'s summarizing code from finished() to commandComplete()
850
851         This matches how most of our other build steps work, so is good just for improving
852         consistency between build steps. It should also make it possible for
853         ExtractTestResultsAndLeaks to successfully add a URL to Leaks Viewer. (Previously we were
854         trying to do this in finished() after we had called up to the base class, but that was
855         apparently too late to add more URLs.)
856
857         Hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot
858         results page
859
860         Reviewed by John Sullivan.
861
862         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
863         (ExtractTestResults): Added a descriptionDone property so that we don't have to manually
864         call setText to get the right text to show up for this step. This matches how most of our
865         other build steps work.
866         (ExtractTestResults.commandComplete): Replaced our override of finished with this function.
867         This is how most of our other build steps work.
868         (ExtractTestResultsAndLeaks.commandComplete): Replaced our override of finished with this
869         function, to match the base class.
870
871 2011-04-07  Adam Barth  <abarth@webkit.org>
872
873         Reviewed by Maciej Stachowiak.
874
875         webkit-patch shouldn't state the whole working copy when calling check-webkit-style
876         https://bugs.webkit.org/show_bug.cgi?id=58022
877
878         Previously, we were ignoring the args variable!  This patch fixes the
879         regression introduced in http://trac.webkit.org/changeset/82771.
880
881         * Scripts/webkitpy/tool/commands/download_unittest.py:
882         * Scripts/webkitpy/tool/mocktool.py:
883         * Scripts/webkitpy/tool/steps/checkstyle.py:
884
885 2011-04-07  Maciej Stachowiak  <mjs@apple.com>
886
887         Reviewed by Adam Barth.
888
889         REGRESSION: "webkit-patch land" doesn't work correctly in SVN subdirectories
890         https://bugs.webkit.org/show_bug.cgi?id=58017
891
892         * Scripts/webkitpy/common/checkout/scm.py:
893         * Scripts/webkitpy/common/checkout/scm_unittest.py:
894
895 2011-04-06  Chang Shu  <cshu@webkit.org>
896
897         Reviewed by Darin Adler.
898
899         WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
900         https://bugs.webkit.org/show_bug.cgi?id=57984
901
902         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
903         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
904         (WTR::LayoutTestController::pageSizeAndMarginsInPixels):
905         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
906
907 2011-04-06  Chris Rogers  <crogers@google.com>
908
909         Reviewed by Tony Chang.
910
911         Add web audio support to DumpRenderTree (mac port)
912         https://bugs.webkit.org/show_bug.cgi?id=57969
913
914         * DumpRenderTree/LayoutTestController.cpp:
915         (LayoutTestController::LayoutTestController):
916         (setEncodedAudioDataCallback):
917         (LayoutTestController::staticFunctions):
918         * DumpRenderTree/LayoutTestController.h:
919         (LayoutTestController::dumpAsAudio):
920         (LayoutTestController::setDumpAsAudio):
921         (LayoutTestController::encodedAudioData):
922         (LayoutTestController::setEncodedAudioData):
923         * DumpRenderTree/mac/DumpRenderTree.mm:
924         (dumpAudio):
925         (dump):
926
927 2011-04-06  Benjamin Poulain  <benjamin.poulain@nokia.com>
928
929         Reviewed by Kenneth Rohde Christiansen.
930
931         [Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
932         https://bugs.webkit.org/show_bug.cgi?id=56086
933
934         Add the missing method.
935
936         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
937         (WebCore::DumpRenderTree::getAllPages): Add a method to return all the pages allocated for the current test.
938         * DumpRenderTree/qt/DumpRenderTreeQt.h:
939         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
940         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
941
942 2011-04-06  Dai Mikurube  <dmikurube@chromium.org>
943
944         Reviewed by David Levin.
945
946         Add QUOTA build flag for unified quota API
947         https://bugs.webkit.org/show_bug.cgi?id=57918
948
949         * Scripts/build-webkit: Added QUOTA build flag
950
951 2011-04-06  Dirk Pranke  <dpranke@chromium.org>
952
953         Reviewed by Tony Chang.
954
955         Adjust the apple webkit port's default timeout to match
956         old-run-webkit-tests at 35 seconds.
957
958         https://bugs.webkit.org/show_bug.cgi?id=37738
959
960         * Scripts/webkitpy/layout_tests/port/mac.py:
961
962 2011-04-06  Scott Cameron  <sccameron@rim.com>
963
964         Reviewed by Eric Seidel.
965
966         Remove global variable $httpdPath and replace with the return value of
967         getHTTPDPath().  Also remove unnecessary calls to getHTTPDPath().
968         https://bugs.webkit.org/show_bug.cgi?id=53499
969
970         * Scripts/run-iexploder-tests:
971         * Scripts/webkitperl/httpd.pm:
972
973 2011-04-06  Kevin Ollivier  <kevino@theolliviers.com>
974
975         Reviewed by Darin Adler.
976
977         Make sure JS_EXPORT_PRIVATE is an empty define when we aren't using the export macros.
978         
979         https://bugs.webkit.org/show_bug.cgi?id=27551
980         
981         * DumpRenderTree/config.h:
982         * WebKitAPITest/config.h:
983         * WebKitTestRunner/config.h:
984
985 2011-04-06  Tony Chang  <tony@chromium.org>
986
987         Reviewed by Darin Adler.
988
989         teach run-webkit-tests to read checksums from png files
990         https://bugs.webkit.org/show_bug.cgi?id=57993
991
992         * Scripts/old-run-webkit-tests: Read the first 2k of a .png if there's
993           no .checksum and look for the checksum in there.
994
995 2011-04-06  David Dorwin  <ddorwin@chromium.org>
996
997         Reviewed by David Levin.
998
999         Enable fullscreen layout tests for Chromium
1000         https://bugs.webkit.org/show_bug.cgi?id=55726
1001
1002         Make DumpRenderTree always run with fullscreen enabled (equivalent of --enable-fullscreen).
1003
1004         * DumpRenderTree/chromium/WebPreferences.cpp:
1005         (WebPreferences::applyTo):
1006
1007 2011-04-06  Adam Roben  <aroben@apple.com>
1008
1009         Add a "view leaks" link to builds on SnowLeopard Intel Leaks
1010
1011         Fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot results page
1012
1013         Reviewed by David Kilzer.
1014
1015         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1016         (ExtractTestResults.resultDirectoryURL): Added. Moved code to calculate the URL for the
1017         build's results directory here...
1018         (ExtractTestResults.finished): ...from here.
1019         (ExtractTestResultsAndLeaks): New class that's used by the leaks builder
1020         (ExtractTestResultsAndLeaks.finished): Calls up to the base class, but also adds a "view
1021         leaks" link to point to Leaks Viewer for this build.
1022         (TestFactory): Added ExtractTestResultsClass abstraction. This isn't overridden anywhere,
1023         but it seemed good to add for consistency with BuildAndTestFactory.
1024         (BuildAndTestFactory): Added ExtractTestResultsClass abstraction.
1025         (BuildAndTestLeaksFactory): Use ExtractTestResultsAndLeaks as our ExtractTestResultsClass so
1026         that we'll get a "view leaks" link.
1027
1028 2011-04-06  Zan Dobersek  <zandobersek@gmail.com>
1029
1030         Reviewed by Eric Seidel.
1031
1032         [Gtk] plugins/set-status.html fails
1033         https://bugs.webkit.org/show_bug.cgi?id=57844
1034
1035         Allow an empty status text to be dumped.
1036
1037         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1038         (webViewStatusBarTextChanged):
1039
1040 2011-04-06  Chang Shu  <cshu@webkit.org>
1041
1042         Reviewed by Darin Adler.
1043
1044         WebKitTestRunner needs layoutTestController.pageNumberForElementById
1045         https://bugs.webkit.org/show_bug.cgi?id=42329
1046
1047         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1048         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1049         (WTR::LayoutTestController::pageNumberForElementById):
1050         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1051
1052 2011-04-06  Sergio Villar Senin  <svillar@igalia.com>
1053
1054         Reviewed by Martin Robinson.
1055
1056         [GTK] DumpRenderTree: do not try to free NULL SoupURIs
1057         https://bugs.webkit.org/show_bug.cgi?id=57932
1058
1059         Some Layout tests have invalid URIs that do not generate valid
1060         SoupURI instances. Do not try to free those NULL SoupURIs.
1061
1062         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1063         (willSendRequestCallback):
1064
1065 2011-04-06  Csaba Osztrogonác  <ossy@webkit.org>
1066
1067         Reviewed by Andreas Kling.
1068
1069         ORWT shouldn't generate diff files for tests without expected files
1070         https://bugs.webkit.org/show_bug.cgi?id=57846
1071
1072         * Scripts/old-run-webkit-tests:
1073
1074 2011-04-05  Kevin Ollivier  <kevino@theolliviers.com>
1075
1076         [wx] Mac build fix. Handle cases where 10.4 SDK is not installed, and also add x86_64 arch
1077         to deps.
1078
1079         * wx/install-unix-extras:
1080
1081 2011-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1082
1083         Unreviewed, rolling out r82978, r82999, and r83001.
1084         http://trac.webkit.org/changeset/82978
1085         http://trac.webkit.org/changeset/82999
1086         http://trac.webkit.org/changeset/83001
1087         https://bugs.webkit.org/show_bug.cgi?id=57913
1088
1089         Does not work in Python 2.5 (Requested by abarth on #webkit).
1090
1091         * Scripts/webkitpy/common/system/executive.py:
1092         * Scripts/webkitpy/common/system/executive_unittest.py:
1093
1094 2011-04-05  Chang Shu  <cshu@webkit.org>
1095
1096         Reviewed by Darin Adler.
1097
1098         WebKitTestRunner needs layoutTestController.numberOfPages
1099         https://bugs.webkit.org/show_bug.cgi?id=42694
1100
1101         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1102         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1103         (WTR::LayoutTestController::numberOfPages):
1104         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1105
1106 2011-04-05  Tony Chang  <tony@chromium.org>
1107
1108         Reviewed by Mihai Parparita.
1109
1110         [chromium] stop putting results downloaded from WebKit Linux in chromium-linux-x86_64
1111         https://bugs.webkit.org/show_bug.cgi?id=57889
1112
1113         * Scripts/webkitpy/layout_tests/port/chromium.py:
1114         * Scripts/webkitpy/layout_tests/port/test.py:
1115         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1116
1117 2011-04-05  Adam Barth  <abarth@webkit.org>
1118
1119         Silly with statement, from the future!
1120
1121         * Scripts/webkitpy/common/system/executive.py:
1122
1123 2011-04-05  Adam Barth  <abarth@webkit.org>
1124
1125         Reviewed by Tony Chang.
1126
1127         Don't use Exception.message because it's deprecated
1128         https://bugs.webkit.org/show_bug.cgi?id=57892
1129
1130         Suppress the warning for now.  When we move to Python 3, we might need
1131         to something more dramatic.
1132
1133         * Scripts/webkitpy/common/system/executive.py:
1134
1135 2011-04-05  Mihai Parparita  <mihaip@chromium.org>
1136
1137         Reviewed by Ojan Vafai.
1138
1139         Add builders.js to dashboard file list
1140         https://bugs.webkit.org/show_bug.cgi?id=57899
1141
1142         Add file added by http://crrev.com/80538 to dashboard file list.
1143
1144         * TestResultServer/handlers/dashboardhandler.py:
1145
1146 2011-04-05  MORITA Hajime  <morrita@google.com>
1147
1148         Reviewed by Adam Barth.
1149
1150         webkit-patch should print git's stderr when git svn dcommit fail
1151         http://webkit.org/b/57861
1152
1153         * Scripts/webkitpy/common/checkout/scm.py:
1154
1155 2011-04-05  Mihai Parparita  <mihaip@chromium.org>
1156
1157         Reviewed by Tony Chang.
1158
1159         Add --baseline-search-path to NRWT
1160         https://bugs.webkit.org/show_bug.cgi?id=56233
1161         
1162         Add NRWT option to specify additional directories to look for baselines
1163         (will be used by hardware GPU bots which will have local per-bot
1164         expectations for some tests)
1165
1166         * Scripts/webkitpy/common/system/filesystem_mock.py:
1167         * Scripts/webkitpy/layout_tests/port/base.py:
1168         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1169         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1170
1171 2011-04-05  Adam Roben  <aroben@apple.com>
1172
1173         Strip off /results.html from results URLs before trying to load leaks files from them
1174
1175         r82734 changed build.webkit.org's "view results" URLs to point straight to the results.html
1176         files, rather than pointing to the directory that contains them. This is more convenient for
1177         people browsing build.webkit.org, but confused Leaks Viewer.
1178
1179         Fixes <http://webkit.org/b/57869> REGRESSION (r82734): Links in Leaks Viewer's Recent Builds
1180         list don't work
1181
1182         Reviewed by Joseph Pecoraro.
1183
1184         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1185         (RecentBuildsLoader.prototype.start): Strip off "/results.html" from the results URL.
1186
1187 2011-04-05  Carol Szabo  <carol@webkit.org>
1188
1189         Unreviewed.
1190
1191         Updated my info in committers.py
1192
1193         Scripts\webkitpy\common\config\committers.py 
1194
1195 2011-04-05  Csaba Osztrogonác  <ossy@webkit.org>
1196
1197         Reviewed by Laszlo Gombos.
1198
1199         [Qt] Make WebKitLibraries optional for building QtWebKit
1200         https://bugs.webkit.org/show_bug.cgi?id=57542
1201
1202         * Scripts/build-webkit:
1203
1204 2011-04-05  Chang Shu  <cshu@webkit.org>
1205
1206         Reviewed by Laszlo Gombos.
1207
1208         [Qt] MiniBrowser defaultUrl does not work
1209         https://bugs.webkit.org/show_bug.cgi?id=57021
1210
1211         Match the behavior and coding of MiniBrowser to QtTestBrowser.
1212         * MiniBrowser/qt/main.cpp:
1213         (main):
1214
1215 2011-04-05  Jade Han  <jade.han@nokia.com>
1216
1217         Reviewed by Laszlo Gombos.
1218
1219         [Qt] [Symbian] Disable WebKitTestRunner for Symbian
1220         https://bugs.webkit.org/show_bug.cgi?id=54977
1221
1222         This change is a preparation to enable building webkit2 for Symbian.
1223         Bug 57834 is filed to fix and enable WebKitTestRunner for Symbian.
1224
1225         * Tools.pro:
1226
1227 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
1228
1229         Reviewed by Andreas Kling.
1230
1231         [Qt] Fix timeoutTimer of MiniBrowser's UrlLoader
1232         https://bugs.webkit.org/show_bug.cgi?id=57832
1233
1234         Only QWKPage has loadFinished signal so connect to it instead of BrowserWindow.
1235
1236         * MiniBrowser/qt/UrlLoader.cpp:
1237         (UrlLoader::UrlLoader):
1238
1239 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
1240
1241         [Qt] Linux Release minimal build fix after r82919.
1242
1243         * MiniBrowser/qt/BrowserWindow.cpp:
1244         (BrowserWindow::loadURLListFromFile):
1245         * QtTestBrowser/launcherwindow.cpp:
1246         (LauncherWindow::loadURLListFromFile):
1247
1248 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
1249
1250         Reviewed by Andreas Kling.
1251
1252         [Qt] Make URL loader accessible from testbrowser's menus
1253         https://bugs.webkit.org/show_bug.cgi?id=57823
1254
1255         Add "Load URLs from file" to QtTestBrowser's and to MiniBrowser's menu.
1256
1257         * MiniBrowser/qt/BrowserWindow.cpp:
1258         (BrowserWindow::BrowserWindow):
1259         (BrowserWindow::loadURLListFromFile):
1260         (BrowserWindow::~BrowserWindow):
1261         * MiniBrowser/qt/BrowserWindow.h:
1262         * QtTestBrowser/launcherwindow.cpp:
1263         (LauncherWindow::LauncherWindow):
1264         (LauncherWindow::~LauncherWindow):
1265         (LauncherWindow::createChrome):
1266         (LauncherWindow::loadURLListFromFile):
1267         * QtTestBrowser/launcherwindow.h:
1268
1269 2011-04-04  Sam Weinig  <sam@webkit.org>
1270
1271         Reviewed by Brian Weinstein.
1272
1273         Remove duplicate API from WKContext
1274         <rdar://problem/8727879>
1275         https://bugs.webkit.org/show_bug.cgi?id=57815
1276
1277         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1278         * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Removed.
1279         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1280         Remove SendingMessagesToTheWebProcessBeforeItIsValid since the API it was testing is now removed.
1281
1282 2011-04-04  Tony Chang  <tony@chromium.org>
1283
1284         Reviewed by Ojan Vafai.
1285
1286         [chromium] don't write .checksum files if a fallback platform has an embedded checksum
1287         https://bugs.webkit.org/show_bug.cgi?id=57783
1288
1289         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1290         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1291
1292 2011-04-04  Kevin Ollivier  <kevino@theolliviers.com>
1293
1294         [wx] Unreviewed build fix, run uninstall when cleaning to remove built files
1295         from WebKitBuild.
1296
1297         * Scripts/webkitdirs.pm:
1298
1299 2011-04-04  Martin Robinson  <mrobinson@igalia.com>
1300
1301         Reviewed by Gustavo Noronha Silva.
1302
1303         [GTK] WebGL support
1304         https://bugs.webkit.org/show_bug.cgi?id=31517
1305
1306         Add support to the DRT for turning on WebGL when a layout tests requests it.
1307
1308         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1309         (LayoutTestController::overridePreference): Allow turning on WebGL from tests.
1310
1311 2011-04-04  Chang Shu  <cshu@webkit.org>
1312
1313         Reviewed by Darin Adler.
1314
1315         WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
1316         https://bugs.webkit.org/show_bug.cgi?id=57572
1317
1318         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1319         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1320         (WTR::LayoutTestController::setAllowFileAccessFromFileURLs):
1321         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1322
1323 2011-04-04  Keith Kyzivat  <keith.kyzivat@nokia.com>
1324
1325         Reviewed by Csaba Osztrogonác.
1326
1327         [Qt] DumpRenderTree breaks compilation in some uClibc environments
1328         https://bugs.webkit.org/show_bug.cgi?id=57602
1329
1330         * DumpRenderTree/qt/main.cpp:
1331         (get_backtrace):
1332
1333 2011-04-04  Kevin Ollivier  <kevino@theolliviers.com>
1334
1335         [wx] Unreviewed build fix, add new LayoutTestController method stub to wx.
1336
1337         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1338         (LayoutTestController::shadowRoot):
1339
1340 2011-04-04  Pavel Podivilov  <podivilov@chromium.org>
1341
1342         Unreviewed, fix exception in rebaseline tool.
1343
1344         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1345
1346 2011-04-02  Beth Dakin  <bdakin@apple.com>
1347
1348         Rubber-stamped by Geoff Garen.
1349
1350         For Dan!
1351         * DumpRenderTree/mac/DumpRenderTree.mm:
1352         (resetWebViewToConsistentStateBeforeTesting):
1353
1354 2011-04-02  Beth Dakin  <bdakin@apple.com>
1355
1356         Rubber-stamped by Geoff Garen.
1357
1358         Need to reset the scale, much like zoom.
1359         * DumpRenderTree/mac/DumpRenderTree.mm:
1360         (resetWebViewToConsistentStateBeforeTesting):
1361
1362 2011-04-02  Sam Weinig  <sam@webkit.org>
1363
1364         Reviewed by Beth Dakin.
1365
1366         https://bugs.webkit.org/show_bug.cgi?id=57605
1367         Frame::pageScaleFactor() should not affect getBoundingClientRect() or 
1368         getClientRects()
1369         -and corresponding-
1370         <rdar://problem/9194541>
1371
1372         Add DRT support for the scaleWebView SPI.
1373         * DumpRenderTree/mac/EventSendingController.mm:
1374         (+[EventSendingController isSelectorExcludedFromWebScript:]):
1375         (+[EventSendingController webScriptNameForSelector:]):
1376         (-[EventSendingController scalePageBy:atX:andY:]):
1377         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1378         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1379         (WTR::EventSendingController::scalePageBy):
1380         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1381         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1382         (WTR::InjectedBundlePage::reset):
1383
1384 2011-04-02  Dominic Cooney  <dominicc@google.com>
1385
1386         Reviewed by Martin Robinson.
1387
1388         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
1389         https://bugs.webkit.org/show_bug.cgi?id=57551
1390
1391         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1392         (LayoutTestController::shadowRoot):
1393
1394 2011-04-02  Patrick Gansterer  <paroga@webkit.org>
1395
1396         Reviewed by Eric Seidel.
1397
1398         Remove AbstractStep._run_script and move script names to ports.py
1399         https://bugs.webkit.org/show_bug.cgi?id=57704
1400
1401         Replace deprecated _run_script with _tool.executive.run_and_throw_if_fail.
1402
1403         * Scripts/webkitpy/common/config/ports.py:
1404         * Scripts/webkitpy/tool/commands/download_unittest.py:
1405         * Scripts/webkitpy/tool/commands/roll_unittest.py:
1406         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1407         * Scripts/webkitpy/tool/steps/abstractstep.py:
1408         * Scripts/webkitpy/tool/steps/checkstyle.py:
1409         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1410         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
1411         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1412
1413 2011-04-02  Patrick Gansterer  <paroga@webkit.org>
1414
1415         Reviewed by Eric Seidel.
1416
1417         Emulate shebang on Win32
1418         https://bugs.webkit.org/show_bug.cgi?id=55927
1419
1420         Scripts on Windows work only if they are called with the explicit interpreter.
1421         Read the first line of scripts to detect the correct executable.
1422
1423         * Scripts/webkitpy/common/config/ports.py:
1424         * Scripts/webkitpy/common/system/executive.py: Added interpreter_for_script().
1425         * Scripts/webkitpy/common/system/executive_unittest.py:
1426
1427 2011-04-01  Adam Barth  <abarth@webkit.org>
1428
1429         Reviewed by Eric Seidel.
1430
1431         apos entities shouldn't show up in ChangeLogs when using webkit-patch
1432         https://bugs.webkit.org/show_bug.cgi?id=57692
1433
1434         Previously, we were using BeautifulSoup to process XML from
1435         bugs.webkit.org, but that's incorrect.  We should be using
1436         BeautifulStoneSoup to process the XML.  We were getting the &apos;
1437         entity wrong because &apos; is an XML entity but not an HTML entity.
1438
1439         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1440         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1441
1442 2011-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1443
1444         Unreviewed, rolling out r82721.
1445         http://trac.webkit.org/changeset/82721
1446         https://bugs.webkit.org/show_bug.cgi?id=57687
1447
1448         This patch introduced assertion failures on the GTK+ bots.
1449         (Requested by mrobinson on #webkit).
1450
1451         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1452         (LayoutTestController::shadowRoot):
1453
1454 2011-04-01  Csaba Osztrogonác  <ossy@webkit.org>
1455
1456         Unreviewed buildfix.
1457
1458         [Qt][WK2] Build Webkit2 using "-2" option on Qt
1459         https://bugs.webkit.org/show_bug.cgi?id=55074
1460
1461         * Scripts/build-webkit: Ensure that "-2" isn't passed to qmake.
1462         (The isWK2() function removes it from @ARGV, but not from @options.)
1463
1464 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
1465
1466         Reviewed by Csaba Osztrogonác.
1467
1468         [Qt] [WK2] MiniBrowser.qrc not found - regression from rev 82671
1469         https://bugs.webkit.org/show_bug.cgi?id=57666
1470
1471         * MiniBrowser/qt/MiniBrowser.qrc: Renamed from Tools/MiniBrowser/MiniBrowser.qrc.
1472
1473 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
1474
1475         Reviewed by Adam Barth.
1476
1477         new-run-webkit-tests: fix feature detection, skipped platform lists on mac
1478
1479         We apparently never implemented the code to skip tests based on
1480         what was compiled into DRT. Also, change the logic used to skip
1481         platform directories to match what old-run-webkit-tests does: 
1482         skip every test not in a directory in the baseline search path.
1483
1484         https://bugs.webkit.org/show_bug.cgi?id=57662
1485
1486         * Scripts/webkitpy/layout_tests/port/mac.py:
1487         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1488         * Scripts/webkitpy/layout_tests/port/webkit.py:
1489
1490 2011-03-29  Mark Rowe  <mrowe@apple.com>
1491
1492         Reviewed by Jon Honeycutt.
1493
1494         <http://webkit.org/b/56730> new-run-webkit-tests fails on Lion seed
1495
1496         Teach new-run-webkit-tests about the concept of an unreleased version of Mac OS X.
1497
1498         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1499         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1500         * Scripts/webkitpy/layout_tests/port/mac.py:
1501         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1502
1503 2011-04-01  Chang Shu  <cshu@webkit.org>
1504
1505         Reviewed by Csaba Osztrogonác.
1506
1507         [Qt][WK2] Build Webkit2 using "-2" option on Qt
1508         https://bugs.webkit.org/show_bug.cgi?id=55074
1509
1510         * Scripts/build-webkit:
1511
1512 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
1513
1514         Reviewed by Tony Chang.
1515
1516         new-run-webkit-tests: remove spurious port version override in webkit.py
1517         base.py provides a default implementation so this is just
1518         breaking things.
1519
1520         https://bugs.webkit.org/show_bug.cgi?id=57667
1521
1522         * Scripts/webkitpy/layout_tests/port/webkit.py:
1523         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1524
1525 2011-04-01  Csaba Osztrogonác  <ossy@webkit.org>
1526
1527         Reviewed by Adam Roben.
1528
1529         Make view results on waterfall direct link to results.html
1530         https://bugs.webkit.org/show_bug.cgi?id=57671
1531
1532         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add "/results.html" to the URL.
1533         * Scripts/old-run-webkit-tests: Add links to httpd access and error logs.
1534
1535 2011-04-01  Sam Weinig  <sam@webkit.org>
1536
1537         Fix windows build.
1538
1539         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
1540         (TestWebKitAPI::TEST):
1541         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
1542         (TestWebKitAPI::flushMessages):
1543
1544 2011-04-01  Sam Weinig  <sam@webkit.org>
1545
1546         Reviewed by Adam Roben.
1547
1548         Add adoptWK to WKRetainPtr.h
1549         https://bugs.webkit.org/show_bug.cgi?id=57670
1550
1551         * TestWebKitAPI/PlatformUtilities.h:
1552         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
1553         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
1554         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
1555         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
1556         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
1557         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1558         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
1559         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
1560         (TestWebKitAPI::createSessionStateContainingFormData):
1561         * WebKitTestRunner/StringFunctions.h:
1562         Replace custom versions of adoptWK with the API on in WebKit2/WKRetainPtr.h.
1563
1564 2011-04-01  Sam Weinig  <sam@webkit.org>
1565
1566         Reviewed by Adam Roben.
1567
1568         Fix leak noticed by Adam Roben in LayoutTestController::shadowRoot.
1569
1570         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1571         (WTR::LayoutTestController::shadowRoot):
1572         Make judicious use of adoptWK().
1573
1574 2011-04-01  Sam Weinig  <sam@webkit.org>
1575
1576         Reviewed by Timothy Hatcher.
1577
1578         Fix extract-localizable-strings for macro change from UI_STRING -> WEB_UI_STRING.
1579
1580         * Scripts/extract-localizable-strings:
1581
1582 2011-04-01  Anders Carlsson  <andersca@apple.com>
1583
1584         Reviewed by Sam Weinig.
1585
1586         Shockwave plug-in doesn't accept mouse events
1587         https://bugs.webkit.org/show_bug.cgi?id=57653
1588         <rdar://problem/8483273>
1589
1590         Add a plug-in test.
1591
1592         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1593         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1594         (PluginTest::indicateTestFailure):
1595         Move code from NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject here.
1596
1597         (PluginTest::NPN_ConvertPoint):
1598         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1599         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
1600         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
1601         Call indicateTestFailure.
1602
1603         * DumpRenderTree/TestNetscapePlugIn/Tests/mac: Added.
1604         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp: Added.
1605         (ConvertPoint::ConvertPoint):
1606         (ConvertPoint::testConvert):
1607         (ConvertPoint::NPP_New):
1608
1609 2011-04-01  Dominic Cooney  <dominicc@google.com>
1610
1611         Reviewed by Martin Robinson.
1612
1613         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
1614         https://bugs.webkit.org/show_bug.cgi?id=57551
1615
1616         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1617         (LayoutTestController::shadowRoot):
1618
1619 2011-04-01  Sam Weinig  <sam@webkit.org>
1620
1621         Reviewed by Anders Carlsson.
1622
1623         WebKitTestRunner needs layoutTestController.shadowRoot
1624         https://bugs.webkit.org/show_bug.cgi?id=57661
1625
1626         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1627         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1628         (WTR::LayoutTestController::shadowRoot):
1629         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1630         Implement layoutTestController.shadowRoot for WebKit2.
1631
1632 2011-04-01  Chang Shu  <cshu@webkit.org>
1633
1634         Reviewed by Darin Adler.
1635
1636         WebKitTestRunner needs layoutTestController.setDatabaseQuota
1637         https://bugs.webkit.org/show_bug.cgi?id=57568
1638
1639         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1640         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1641         (WTR::LayoutTestController::setDatabaseQuota):
1642         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1643
1644 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
1645
1646         Reviewed by Tony Chang.
1647
1648         This patch completes the cleanup of
1649         rebaseline-chromium-webkit-tests to work with all of the
1650         variants of a platform (we can now rebaseline gpu- and non-gpu
1651         files at the same time).
1652
1653         When the rebaselining is complete, any lines declared as
1654         REBASELINE in the expectations file that matches a test that was
1655         actually rebaselined will be deleted, even if only one of the
1656         variants was actually rebaselined. This may cause odd problems,
1657         but is better than where we're at today.
1658
1659         This change removes the -g flag and deprecates -w. The -g flag is gone
1660         because GPU baselines are handled just like any other variant.
1661         The -w flag is deprecated because this tool now only works
1662         against the canaries, since that's the only place we have a full
1663         set of bots. It will be trivial to change this to
1664         build.webkit.org if we decide that's where we want them to be.
1665
1666         Also, this patch deletes a lot of cruft that is no longer needed
1667         in the test_expectations code and the port-specific code.
1668
1669         https://bugs.webkit.org/show_bug.cgi?id=55191
1670
1671         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1672         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1673         * Scripts/webkitpy/layout_tests/port/base.py:
1674         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1675         * Scripts/webkitpy/layout_tests/port/chromium.py:
1676         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1677         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1678         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1679         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1680         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1681         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1682         * Scripts/webkitpy/layout_tests/port/mac.py:
1683         * Scripts/webkitpy/layout_tests/port/test.py:
1684         * Scripts/webkitpy/layout_tests/port/webkit.py:
1685         * Scripts/webkitpy/layout_tests/port/win.py:
1686         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1687         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1688
1689 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
1690
1691         Reviewed by Adam Barth.
1692
1693         rebaseline-chromium-webkit-tests does not work correctly with
1694         version-specific baselines. This patch updates the tool to use
1695         all of the version-specific bots on the canaries, and will now
1696         attempt to rebaseline all of the versions by default, although
1697         it will not update both GPU and CPU versions.
1698         
1699         Also, it will no longer modify the test_expectations.txt file
1700         *at all*. You will have to manually delete the REBASELINE lines
1701         after running the tool and determining that it did what you
1702         wanted it to do. This should be fixed in a separate bug - see
1703         webkit bug #55191.
1704
1705         https://bugs.webkit.org/show_bug.cgi?id=55608
1706
1707         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1708         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1709         * Scripts/webkitpy/layout_tests/port/chromium.py:
1710         * Scripts/webkitpy/layout_tests/port/test.py:
1711         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1712         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1713
1714 2011-03-31  Tony Chang  <tony@chromium.org>
1715
1716         Reviewed by Ojan Vafai.
1717
1718         [chromium] update the rebaseline tool to know about pngs with checksums
1719         https://bugs.webkit.org/show_bug.cgi?id=57481
1720
1721         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Skip over .checksum files if the checksum is already in the png
1722         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1723
1724 2011-04-01  Adam Roben  <aroben@apple.com>
1725
1726         Retrieve revision numbers from the build's got_revision property in Leaks Viewer
1727
1728         Previously, we were getting the revision of the first revision that triggered a build.
1729         Choosing the last revision would have been more accurate. But got_revision is what is used
1730         everywhere else on build.webkit.org, and should work even when there were no changes that
1731         triggered a build (e.g., if someone clicked the Force Build button).
1732
1733         Fixes <http://webkit.org/b/57630> Leaks viewer gets some revision numbers wrong in the
1734         recent builds list
1735
1736         Reviewed by Anders Carlsson.
1737
1738         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1739         (RecentBuildsLoader.prototype.start): Pull the revision number out of the got_revision
1740         property, rather than out of the first (i.e., earliest) change in the sourceStamp object.
1741
1742         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
1743         (Array.prototype.first): Added this helper function to return the first element in an array
1744         that matches the given predicate, or null if no such element exists.
1745
1746 2011-03-31  Adam Roben  <aroben@apple.com>
1747
1748         Prefer (but don't require) bug URLs to be on their own line when parsing bug numbers from ChangeLogs
1749
1750         Fixes <http://webkit.org/b/57579> webkit-patch is too strict about bug URL formatting
1751
1752         Reviewed by Darin Adler.
1753
1754         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1755         (parse_bug_id_from_changelog): Fall back to parse_bug_id if we weren't able to find a bug
1756         URL on its own line.
1757
1758         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1759         (BugzillaTest.test_parse_bug_id_from_changelog): Updated expected results for test
1760         progression, and added a new test that uses a short bug URL while I was at it.
1761
1762 2011-04-01  Adam Roben  <aroben@apple.com>
1763
1764         Mark .vcproj/.vsprops/.sln files as being Windows-only
1765
1766         Fixes <http://webkit.org/b/57489> Mac builders built 82512, but shouldn't have
1767
1768         Reviewed by Anders Carlsson.
1769
1770         * Scripts/webkitpy/common/config/build.py:
1771         (_should_file_trigger_build): Added patterns to mark .vcproj/.vsprops/.sln files and .vcproj
1772         directories as Windows-only.
1773
1774         * Scripts/webkitpy/common/config/build_unittest.py:
1775         (ShoulBuildTest): Added test cases for the above.
1776
1777 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
1778
1779         Reviewed by Laszlo Gombos.
1780
1781         [Qt] Build MiniBrowser for Symbian
1782         https://bugs.webkit.org/show_bug.cgi?id=56319
1783
1784         Have MiniBrowser reference it's own copy of useragentlist.txt instead
1785         of copying QtTestBrowser's.
1786         Remove Tools/MiniBrowser/DerivedSources.pro
1787         This reduces complexity in the Tools scripts due to Symbian limitations.
1788
1789         * DerivedSources.pro:
1790         * MiniBrowser/DerivedSources.pro: Removed.
1791         * MiniBrowser/MiniBrowser.qrc:
1792         * MiniBrowser/qt/MiniBrowser.pro:
1793         * Scripts/webkitdirs.pm:
1794
1795 2011-03-31  Chang Shu  <cshu@webkit.org>
1796
1797         Reviewed by Darin Adler.
1798
1799         WebKitTestRunner needs layoutTestController.clearAllDatabases
1800         https://bugs.webkit.org/show_bug.cgi?id=42540
1801
1802         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1803         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1804         (WTR::InjectedBundle::beginTesting):
1805         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1806         (WTR::LayoutTestController::clearAllDatabases):
1807         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1808
1809 2011-03-31  Chang Shu  <cshu@webkit.org>
1810
1811         Reviewed by Darin Adler.
1812
1813         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
1814         https://bugs.webkit.org/show_bug.cgi?id=42692
1815
1816         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1817
1818 2011-03-31  Darin Adler  <darin@apple.com>
1819
1820         Reviewed by Sam Weinig.
1821
1822         Implement mouseDown, mouseUp, and mouseMoveTo in WebKitTestRunner
1823         https://bugs.webkit.org/show_bug.cgi?id=57573
1824
1825         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1826         Added real definitions for mouseDown, mouseUp, mouseMoveTo and leapForward.
1827         Removed fake definitions of keyDown and contextClick.
1828
1829         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1830         (WTR::operator==): Added. So we can compare two WKPoint structs.
1831         (WTR::parseModifier): Added.
1832         (WTR::parseModifierArray): Added.
1833         (WTR::EventSendingController::EventSendingController): Initialize the
1834         new data members.
1835         (WTR::EventSendingController::mouseDown): Added. Calls
1836         WKBundlePageSimulateMouseDown.
1837         (WTR::EventSendingController::mouseUp): Added. Calls
1838         WKBundlePageSimulateMouseUp.
1839         (WTR::EventSendingController::mouseMoveTo): Added. Calls
1840         WKBundlePageSimulateMouseMotion.
1841         (WTR::EventSendingController::leapForward): Added.
1842         (WTR::EventSendingController::updateClickCount): Added. Used by the
1843         mouseDown/Up functions to create a click count.
1844
1845         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Updated
1846         for the changes above.
1847
1848 2011-03-31  Sergio Villar Senin  <svillar@igalia.com>
1849
1850         Reviewed by Martin Robinson.
1851
1852         [GTK] implement LayoutTestController::setWillSendRequestReturnsNull
1853         https://bugs.webkit.org/show_bug.cgi?id=57362
1854
1855         Do not generate DRT output if willSendRequestReturnsNull is set.
1856
1857         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1858         (willSendRequestCallback):
1859
1860 2011-03-31  Vamshikrishna.Yellenki  <vamshi@motorola.com> and Alejandro G. Castro  <alex@igalia.com>
1861
1862         Reviewed by Martin Robinson.
1863
1864         Implement MiniBrowser for Gtk port.
1865         https://bugs.webkit.org/show_bug.cgi?id=48512
1866
1867         Initial implementation of the Gtk MiniBrowser.
1868
1869         * MiniBrowser/gtk/GNUmakefile.am: Added.
1870         * MiniBrowser/gtk/main.c: Added.
1871         (activateUriEntryCallback):
1872         (destroyCallback):
1873         (goBackCallback):
1874         (goForwardCallback):
1875         (createToolbar):
1876         (createWebView):
1877         (createWindow):
1878         (argumentToURL):
1879         (main):
1880
1881 2011-03-30  Dominic Cooney  <dominicc@google.com>
1882
1883         Reviewed by Dimitri Glazkov.
1884
1885         Adds layoutTestController.shadowRoot accessor to Mac DRT.
1886         https://bugs.webkit.org/show_bug.cgi?id=57415
1887
1888         * DumpRenderTree/LayoutTestController.cpp:
1889         (shadowRootCallback):
1890         (LayoutTestController::staticFunctions):
1891         * DumpRenderTree/LayoutTestController.h:
1892         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1893         (LayoutTestController::shadowRoot):
1894         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1895         (LayoutTestController::shadowRoot):
1896
1897 2011-03-30  Matthew Delaney  <mdelaney@apple.com>
1898
1899         Reviewed by Chris Marrin.
1900
1901         Update fast/canvas tests to avoid dumping the render tree when possible
1902         https://bugs.webkit.org/show_bug.cgi?id=57493
1903
1904         * DumpRenderTree/mac/DumpRenderTree.mm: Make DRT aware of new default values for
1905           accelerated drawing and accelerated drawing for canvas
1906
1907 2011-03-30  Adam Roben  <aroben@apple.com>
1908
1909         Stop ignoring leaks in CGGradientCreateWithColorStops
1910
1911         Fixes <rdar://problem/7888547>.
1912
1913         Rubber-stamped by John Sullivan.
1914
1915         * Scripts/old-run-webkit-tests:
1916         (countAndPrintLeaks): Removed some code to ignore those leaks.
1917
1918 2011-03-30  Timur Iskhodzhanov  <timurrrr@google.com>
1919
1920         Reviewed by Alexey Proskuryakov.
1921
1922         Add some dynamic annotations to JavaScriptCore/wtf
1923         https://bugs.webkit.org/show_bug.cgi?id=53747
1924
1925         By using these annotations we can improve the precision of finding
1926         WebKit errors using dynamic analysis tools like ThreadSanitizer and Valgrind.
1927         These annotations don't affect the compiled binaries unless USE(DYNAMIC_ANNOTATIONS) is "1".
1928
1929         These files don't add new functionality, so don't need extra tests.
1930
1931         * DumpRenderTree/ForwardingHeaders/wtf/DynamicAnnotations.h: Added.
1932
1933 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
1934
1935         Reviewed by Adam Roben.
1936
1937         Share most vsprops between Release and Production builds in releaseproduction.vsprops
1938         https://bugs.webkit.org/show_bug.cgi?id=57508
1939
1940         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
1941         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
1942         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
1943         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
1944         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
1945         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
1946         * DumpRenderTree/win/ImageDiffProduction.vsprops:
1947         * DumpRenderTree/win/ImageDiffRelease.vsprops:
1948         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
1949         * FindSafari/FindSafariProduction.vsprops:
1950         * FindSafari/FindSafariRelease.vsprops:
1951         * FindSafari/FindSafariReleaseCairoCFLite.vsprops:
1952         * FindSafari/FindSafariReleasePGO.vsprops:
1953         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
1954         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
1955         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
1956         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
1957         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
1958         * WebKitAPITest/WebKitAPITestProduction.vsprops:
1959         * WebKitAPITest/WebKitAPITestRelease.vsprops:
1960         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops:
1961         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
1962         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
1963         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
1964         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
1965         * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
1966         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
1967         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
1968         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
1969         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
1970         * WinLauncher/WinLauncherProduction.vsprops:
1971         * WinLauncher/WinLauncherRelease.vsprops:
1972         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
1973         * record-memory-win/record-memory-winProduction.vsprops:
1974         * record-memory-win/record-memory-winRelease.vsprops:
1975         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
1976
1977 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
1978
1979         Reviewed by Adam Roben.
1980
1981         Update Windows production build logic for new production configurations
1982         https://bugs.webkit.org/show_bug.cgi?id=57494
1983
1984         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
1985         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
1986         * DumpRenderTree/win/ImageDiffProduction.vsprops:
1987         * FindSafari/FindSafariProduction.vsprops:
1988         * FindSafari/FindSafariReleasePGO.vsprops:
1989         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
1990         * WebKitAPITest/WebKitAPITestProduction.vsprops:
1991         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
1992         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
1993         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
1994         * WinLauncher/WinLauncherProduction.vsprops:
1995         * record-memory-win/record-memory-winProduction.vsprops:
1996
1997 2011-03-30  Robert Hogan  <robert@webkit.org>
1998
1999         Reviewed by Antonio Gomes.
2000
2001         [Qt] Fix LoadHTMLStringItem::invoke() after r75966
2002         Unskip http/tests/navigation/go-back-to-error-page.html
2003
2004         Also add the location of DumpRenderTreeSupportQt.h
2005         to DRT's include paths.
2006
2007         https://bugs.webkit.org/show_bug.cgi?id=52614
2008
2009         * DumpRenderTree/qt/DumpRenderTree.pro:
2010         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2011         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2012         * DumpRenderTree/qt/GCControllerQt.cpp:
2013         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2014         (LayoutTestController::queueLoadHTMLString):
2015         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2016         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2017         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2018         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
2019         (LoadAlternateHTMLStringItem::invoke):
2020         * DumpRenderTree/qt/WorkQueueItemQt.h:
2021         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
2022         * QtTestBrowser/QtTestBrowser.pro:
2023         * QtTestBrowser/launcherwindow.h:
2024
2025 2011-03-30  Adam Barth  <abarth@webkit.org>
2026
2027         Reviewed by Adam Roben.
2028
2029         SheriffBot rollouts take too long
2030         https://bugs.webkit.org/show_bug.cgi?id=57498
2031
2032         We used to build before landing rollouts via the commit-queue to
2033         prevent further breakage, but now that our individual commit-queue
2034         machines are slower, building takes too long.  I can't remember the
2035         last time a rollout broke compile.  It seems like just landing the
2036         patch is the better trade-off.
2037
2038         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2039         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2040
2041 2011-03-30  Adam Barth  <abarth@webkit.org>
2042
2043         Remove platform/chromium-mac-snowleopard
2044         https://bugs.webkit.org/show_bug.cgi?id=57486
2045
2046         This directory no longer exists, so we can remove it from the fallback
2047         chain.
2048
2049         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2050
2051 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
2052
2053         Reviewed by Adam Roben.
2054
2055         Rename Windows configuration Release_LTCG to Production for clarity
2056         https://bugs.webkit.org/show_bug.cgi?id=57465
2057
2058         * DumpRenderTree/DumpRenderTree.sln:
2059         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2060         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Copied from Tools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops.
2061         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Removed.
2062         * DumpRenderTree/win/DumpRenderTree.vcproj:
2063         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Copied from Tools/DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops.
2064         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Removed.
2065         * DumpRenderTree/win/ImageDiff.vcproj:
2066         * DumpRenderTree/win/ImageDiffProduction.vsprops: Copied from Tools/DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops.
2067         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Removed.
2068         * FindSafari/FindSafari.vcproj:
2069         * FindSafari/FindSafariProduction.vsprops: Copied from Tools/FindSafari/FindSafariReleaseLTCG.vsprops.
2070         * FindSafari/FindSafariReleaseLTCG.vsprops: Removed.
2071         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops: Copied from Tools/MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops.
2072         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Removed.
2073         * MiniBrowser/MiniBrowser.vcproj:
2074         * Scripts/webkitdirs.pm:
2075         * TestWebKitAPI/win/TestWebKitAPI.sln:
2076         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2077         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
2078         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2079         * WebKitAPITest/WebKitAPITest.vcproj:
2080         * WebKitAPITest/WebKitAPITestProduction.vsprops: Copied from Tools/WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops.
2081         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Removed.
2082         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2083         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Copied from Tools/WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops.
2084         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Removed.
2085         * WebKitTestRunner/WebKitTestRunner.sln:
2086         * WebKitTestRunner/win/InjectedBundle.vcproj:
2087         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
2088         * WebKitTestRunner/win/InjectedBundleProduction.vsprops: Copied from Tools/WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops.
2089         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Removed.
2090         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2091         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops: Copied from Tools/WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops.
2092         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Removed.
2093         * WinLauncher/WinLauncher.vcproj:
2094         * WinLauncher/WinLauncherProduction.vsprops: Copied from Tools/WinLauncher/WinLauncherReleaseLTCG.vsprops.
2095         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Removed.
2096         * record-memory-win/record-memory-win.vcproj:
2097         * record-memory-win/record-memory-winProduction.vsprops: Copied from Tools/record-memory-win/record-memory-winReleaseLTCG.vsprops.
2098         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Removed.
2099
2100 2011-03-30  MORITA Hajime  <morrita@google.com>
2101
2102         Reviewed by Dimitri Glazkov.
2103
2104         [Chromium] Expose the shadow DOM to DumpRenderTree JS tests.
2105         https://bugs.webkit.org/show_bug.cgi?id=56573
2106
2107         Added LayoutTestController.shadowRoot() to Chromium DRT.
2108
2109         * DumpRenderTree/chromium/LayoutTestController.cpp:
2110         (LayoutTestController::LayoutTestController):
2111         (LayoutTestController::shadowRoot):
2112         * DumpRenderTree/chromium/LayoutTestController.h:
2113
2114 2011-03-30  Yuta Kitamura  <yutak@chromium.org>
2115
2116         Reviewed by Kent Tamura.
2117
2118         [Chromium] DumpRenderTree: Implement LayoutTestController::setPluginsEnabled
2119         https://bugs.webkit.org/show_bug.cgi?id=57430
2120
2121         * DumpRenderTree/chromium/LayoutTestController.cpp:
2122         (LayoutTestController::LayoutTestController):
2123         (LayoutTestController::setPluginsEnabled):
2124         * DumpRenderTree/chromium/LayoutTestController.h:
2125
2126 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
2127
2128         Reviewed by Adam Barth.
2129
2130         make webkit-patch upload respect -d
2131         https://bugs.webkit.org/show_bug.cgi?id=57425
2132
2133         * Scripts/webkitpy/common/checkout/scm.py:
2134         * Scripts/webkitpy/tool/steps/commit.py:
2135
2136 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
2137
2138         Reviewed by Adam Barth.
2139
2140         Make "webkit-patch --dry-run --verbose land" log the SVN command it's going to use
2141         https://bugs.webkit.org/show_bug.cgi?id=57429
2142
2143         * Scripts/webkitpy/common/checkout/scm.py:
2144
2145 2011-03-29  Sheriff Bot  <webkit.review.bot@gmail.com>
2146
2147         Unreviewed, rolling out r82383.
2148         http://trac.webkit.org/changeset/82383
2149         https://bugs.webkit.org/show_bug.cgi?id=57417
2150
2151         "nrwt isn't shutting down cleanly" (Requested by dpranke on
2152         #webkit).
2153
2154         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2155         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2156         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2157
2158 2011-03-29  Kent Tamura  <tkent@chromium.org>
2159
2160         Reviewed by Dimitri Glazkov.
2161
2162         Make validation message bubble testable
2163         https://bugs.webkit.org/show_bug.cgi?id=57290
2164
2165         * DumpRenderTree/mac/DumpRenderTree.mm:
2166         (createWebViewAndOffscreenWindow): Change a setting so that validation
2167           bubbles isn't hidden automatically.
2168
2169 2011-03-29  Dirk Pranke  <dpranke@chromium.org>
2170
2171         Reviewed by Ojan Vafai.
2172
2173         new-run-webkit-tests: use 'threads' on win instead of 'old-threads'
2174
2175         It's a bit unclear whether multiple threads or multiple
2176         processes will be a better model on windows. This change will
2177         test threads for now while we're still working out the bugs in
2178         multiple-processes.
2179
2180         https://bugs.webkit.org/show_bug.cgi?id=57410
2181
2182         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2183         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2184         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2185
2186 2011-03-29  David Levin  <levin@chromium.org>
2187
2188         Reviewed by Shinichiro Hamaji.
2189
2190         check-webkit-style confused by two ChangeLog entries in a row from same user
2191         https://bugs.webkit.org/show_bug.cgi?id=57250
2192
2193         * Scripts/webkitpy/style/checker.py: Add the line should be checked function to ChangeLogChecker.
2194         * Scripts/webkitpy/style/checker_unittest.py: Fix test due to that new function.
2195         * Scripts/webkitpy/style/checkers/changelog.py: Made this code aware of what lines were being checked.
2196           It basically assumes only one ChangeLog entry is being processed because that is the standard case and
2197           checking more than that would be very messey.
2198         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Add testing to catch the broken case.
2199         * Scripts/webkitpy/style/error_handlers.py: Added should_line_be_checked.
2200
2201 2011-03-29  Kent Tamura  <tkent@chromium.org>
2202
2203         Reviewed by Dimitri Glazkov.
2204
2205         [Mac] Enable interactive-validation tests on Mac DRT
2206         https://bugs.webkit.org/show_bug.cgi?id=57308
2207
2208         * DumpRenderTree/mac/DumpRenderTree.mm:
2209         (createWebViewAndOffscreenWindow): Enable the form interactive validation feature.
2210
2211 2011-03-29  Chang Shu  <cshu@webkit.org>
2212
2213         Reviewed by Kenneth Rohde Christiansen.
2214
2215         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
2216         https://bugs.webkit.org/show_bug.cgi?id=42692
2217
2218         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2219         (WTR::InjectedBundle::beginTesting):
2220         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2221         (WTR::LayoutTestController::setAllowUniversalAccessFromFileURLs):
2222         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2223
2224 2011-03-24  Martin Robinson  <mrobinson@igalia.com>
2225
2226         Reviewed by Xan Lopez.
2227
2228         [GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
2229         https://bugs.webkit.org/show_bug.cgi?id=57067
2230
2231         Eliminate extra spacing between the DRT GtkScrolledWindow and the DRT WebView. This
2232         will allow WebKit1GTK+ and WebKit2GTK+ to share test results. Followup commits will
2233         update DRT and pixel results as hundreds of results will need to be updated.
2234
2235         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2236         (setDefaultsToConsistentStateValuesForTesting): Eliminate spacing on the GtkScrolledWindow
2237         by overriding the theme RC/CSS files.
2238
2239 2011-03-29  Steve Falkenburg  <sfalken@apple.com>
2240
2241         Reviewed by Adam Roben.
2242
2243         Use per-configuration vsprops in tools projects to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
2244         https://bugs.webkit.org/show_bug.cgi?id=57394
2245
2246         Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
2247         InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
2248         the IDE. To avoid this, add a separate vsprops file for each project configuration that
2249         contains the required inherited property sheets.
2250
2251         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2252         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Added.
2253         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Added.
2254         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Added.
2255         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Added.
2256         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Added.
2257         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Added.
2258         * DumpRenderTree/win/DumpRenderTree.vcproj:
2259         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Added.
2260         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Added.
2261         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Added.
2262         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Added.
2263         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Added.
2264         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Added.
2265         * DumpRenderTree/win/ImageDiff.vcproj:
2266         * DumpRenderTree/win/ImageDiffDebug.vsprops: Added.
2267         * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Added.
2268         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Added.
2269         * DumpRenderTree/win/ImageDiffRelease.vsprops: Added.
2270         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Added.
2271         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Added.
2272         * FindSafari/FindSafari.vcproj:
2273         * FindSafari/FindSafariDebug.vsprops: Added.
2274         * FindSafari/FindSafariDebugAll.vsprops: Added.
2275         * FindSafari/FindSafariDebugCairoCFLite.vsprops: Added.
2276         * FindSafari/FindSafariRelease.vsprops: Added.
2277         * FindSafari/FindSafariReleaseCairoCFLite.vsprops: Added.
2278         * FindSafari/FindSafariReleaseLTCG.vsprops: Added.
2279         * FindSafari/FindSafariReleasePGO.vsprops: Added.
2280         * MiniBrowser/Configurations/MiniBrowserDebug.vsprops: Added.
2281         * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops: Added.
2282         * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops: Added.
2283         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops: Added.
2284         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops: Added.
2285         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Added.
2286         * MiniBrowser/MiniBrowser.vcproj:
2287         * WebKitAPITest/WebKitAPITest.vcproj:
2288         * WebKitAPITest/WebKitAPITestDebug.vsprops: Added.
2289         * WebKitAPITest/WebKitAPITestDebugAll.vsprops: Added.
2290         * WebKitAPITest/WebKitAPITestDebugCairoCFLite.vsprops: Added.
2291         * WebKitAPITest/WebKitAPITestRelease.vsprops: Added.
2292         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops: Added.
2293         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Added.
2294         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2295         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Added.
2296         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Added.
2297         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Added.
2298         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Added.
2299         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Added.
2300         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Added.
2301         * WebKitTestRunner/win/InjectedBundle.vcproj:
2302         * WebKitTestRunner/win/InjectedBundleDebug.vsprops: Added.
2303         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops: Added.
2304         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops: Added.
2305         * WebKitTestRunner/win/InjectedBundleRelease.vsprops: Added.
2306         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: Added.
2307         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Added.
2308         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2309         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops: Added.
2310         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops: Added.
2311         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops: Added.
2312         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: Added.
2313         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: Added.
2314         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Added.
2315         * WinLauncher/WinLauncher.vcproj:
2316         * WinLauncher/WinLauncherDebug.vsprops: Added.
2317         * WinLauncher/WinLauncherDebugAll.vsprops: Added.
2318         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Added.
2319         * WinLauncher/WinLauncherRelease.vsprops: Added.
2320         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Added.
2321         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Added.
2322         * record-memory-win/record-memory-win.vcproj:
2323         * record-memory-win/record-memory-winDebug.vsprops: Added.
2324         * record-memory-win/record-memory-winDebugAll.vsprops: Added.
2325         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Added.
2326         * record-memory-win/record-memory-winRelease.vsprops: Added.
2327         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Added.
2328         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Added.
2329
2330 2011-03-29  Adam Barth  <abarth@webkit.org>
2331
2332         Reviewed by Darin Adler.
2333
2334         test_runner2.py can crash due to undefined variable
2335         https://bugs.webkit.org/show_bug.cgi?id=57356
2336
2337         Replace reference to undefined variable with a variable that's actually
2338         defined.  AFAICT, there's no way to test this code.
2339
2340         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
2341
2342 2011-03-29  Tony Chang  <tony@chromium.org>
2343
2344         Reviewed by Eric Seidel.
2345
2346         cleanup rebaseline-chromium-webkit-tests
2347         https://bugs.webkit.org/show_bug.cgi?id=57375
2348
2349         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2350             - Split _extract_and_add_new_baselines into 3 functions
2351             - Reduce the amount of line wrapping (the file already has lines
2352               over 80 col, so may as well try to make the file consistent)
2353             - Remove unnecessary ()s
2354
2355 2011-03-29  Brent Fulgham  <bfulgham@webkit.org>
2356
2357         Reviewed by Adam Roben.
2358
2359         Make WinCairo a core builder.
2360         https://bugs.webkit.org/show_bug.cgi?id=57373
2361
2362         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Add WinCairo.
2363         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Add WinCairo.
2364
2365 2011-03-29  Timothy Hatcher  <timothy@apple.com>
2366
2367         Update update-webkit-localizable-strings to understand that WebKit and
2368         WebKit2 strings go in WebCore.
2369
2370         Also make extract-localizable-strings optionally use an exclude file. No individual
2371         warnings are produced about unlocalized strings when there is no exclude file. This
2372         is needed for WebCore, since there are too many bare strings.
2373
2374         https://webkit.org/b/57354
2375
2376         Reviewed by Sam Weinig.
2377
2378         * Scripts/extract-localizable-strings: Support "-" to mean no exclude file.
2379         * Scripts/update-webkit-localizable-strings: Update paths to scan WebCore and WebKit2.
2380
2381 2011-03-29  Darin Adler  <darin@apple.com>
2382
2383         Reviewed by Adam Roben.
2384
2385         WebKit2 bundle page needs to offer generated file hooks
2386         https://bugs.webkit.org/show_bug.cgi?id=57279
2387
2388         (Land missing part of the original patch after r82289.)
2389
2390         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2391         (WTR::InjectedBundlePage::InjectedBundlePage): Added new callbacks.
2392
2393 2011-03-29  Tony Chang  <tony@chromium.org>
2394
2395         Reviewed by Ojan Vafai.
2396
2397         [chromium] NRWT should be able to read checksums from png comments
2398         https://bugs.webkit.org/show_bug.cgi?id=57280
2399
2400         * Scripts/read-checksum-from-png: Added. Utility script to read the checksum
2401             from a file.
2402         * Scripts/webkitpy/common/system/filesystem.py: Add open_binary_file_for_reading
2403         * Scripts/webkitpy/common/system/filesystem_mock.py:
2404         * Scripts/webkitpy/layout_tests/port/base.py: When loading a checksum,
2405             if the -checksum.txt file doesn't exist, try looking in the png.
2406         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2407         * Scripts/webkitpy/layout_tests/port/test.py:
2408         * Scripts/webkitpy/layout_tests/read_checksum_from_png.py: Added. Scan the first
2409             2k for a png comment with the checksum
2410         * Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py: Added.
2411
2412 2011-03-29  Philippe Normand  <pnormand@igalia.com>
2413
2414         Rubber-stamped by Gustavo Noronha Silva.
2415
2416         [GTK] http/tests/uri/username-with-no-hostname.html fails
2417         https://bugs.webkit.org/show_bug.cgi?id=57325
2418
2419         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2420         (willSendRequestCallback): URI host value check done case-insensitively.
2421
2422 2011-03-29  Philippe Normand  <pnormand@igalia.com>
2423
2424         Reviewed by Martin Robinson.
2425
2426         [GTK] http/tests/uri/username-with-no-hostname.html fails
2427         https://bugs.webkit.org/show_bug.cgi?id=57325
2428
2429         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2430         (willSendRequestCallback): Check URI before submitting the request
2431         to WebCore.
2432
2433 2011-03-29  Noel Gordon  <noel.gordon@gmail.com>
2434
2435         Reviewed by Ojan Vafai.
2436
2437         [chromium] DRT EventSender: remove identity from dragTargetDragEnter() calls
2438         https://bugs.webkit.org/show_bug.cgi?id=57303
2439
2440         * DumpRenderTree/chromium/EventSender.cpp:
2441         (EventSender::doDragDrop):
2442         (EventSender::beginDragWithFiles):
2443
2444 2011-03-29  Zoltan Horvath  <zoltan@webkit.org>
2445
2446         Reviewed by Andreas Kling.
2447
2448         [Qt] Add -print-loaded-urls option to Qt's MiniBrowser and to QtTestBrowser
2449         https://bugs.webkit.org/show_bug.cgi?id=57314
2450
2451         Provide possibility to print loaded urls to the standard output.
2452
2453         * MiniBrowser/qt/BrowserWindow.cpp:
2454         (BrowserWindow::BrowserWindow):
2455         (BrowserWindow::printURL):
2456         * MiniBrowser/qt/BrowserWindow.h:
2457         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2458         (MiniBrowserApplication::handleUserOptions):
2459         * MiniBrowser/qt/MiniBrowserApplication.h:
2460         (WindowOptions::WindowOptions):
2461         * QtTestBrowser/launcherwindow.cpp:
2462         (LauncherWindow::initializeView):
2463         (LauncherWindow::printURL):
2464         (LauncherWindow::cloneWindow):
2465         * QtTestBrowser/launcherwindow.h:
2466         (WindowOptions::WindowOptions):
2467         * QtTestBrowser/main.cpp:
2468         (LauncherApplication::handleUserOptions):
2469
2470 2011-03-29  Gabor Loki  <loki@webkit.org>
2471
2472         Rubber-stamped by Csaba Osztrogonác.
2473
2474         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
2475         https://bugs.webkit.org/show_bug.cgi?id=56918
2476
2477         * Scripts/build-jsc: Remove duplicated --qt options to avoid passing them to qmake.
2478
2479 2011-03-28  Gabor Loki  <loki@webkit.org>
2480
2481         Reviewed by Csaba Osztrogonác.
2482
2483         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
2484         https://bugs.webkit.org/show_bug.cgi?id=56918
2485
2486         * Scripts/build-jsc:
2487         * Scripts/webkitdirs.pm:
2488
2489 2011-03-28  Andrew Foster  <andrewf@chromium.org>
2490
2491         Reviewed by Ojan Vafai.
2492
2493         webkit-patch should be more intelligent about whether a bug applies to a patch
2494         Create a new function, parse_bug_id_from_changelog() which determines
2495         that a bug is related to a patch by parsing the output generated from
2496         prepare-ChangeLog, rather than arbitrarily matching a URL to a bug in
2497         the description of a patch.
2498         https://bugs.webkit.org/show_bug.cgi?id=56989
2499
2500         * Scripts/webkitpy/common/checkout/api.py:
2501         * Scripts/webkitpy/common/checkout/changelog.py:
2502         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
2503         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2504         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2505         * Scripts/webkitpy/style/checkers/changelog.py:
2506         * Scripts/webkitpy/tool/commands/upload.py:
2507
2508 2011-03-28  Maciej Stachowiak  <mjs@apple.com>
2509
2510         Revert accidentally commited change.
2511
2512         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2513         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2514
2515 2011-03-28  Tony Chang  <tony@chromium.org>
2516
2517         Reviewed by Adam Barth.
2518
2519         [chromium] have DRT write the png checksum into a png comment
2520         https://bugs.webkit.org/show_bug.cgi?id=57255
2521
2522         * DumpRenderTree/chromium/TestShell.cpp:
2523         (TestShell::dumpImage):
2524
2525 2011-03-28  Adele Peterson  <adele@apple.com>
2526
2527         Removing Qt stub, since it doesn't use the same header as the others.
2528
2529         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2530
2531 2011-03-28  Adele Peterson  <adele@apple.com>
2532
2533         Added a few more stubs.
2534
2535         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2536         (LayoutTestController::hasGrammarMarker):
2537         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2538         (LayoutTestController::hasGrammarMarker):
2539         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2540         (LayoutTestController::hasGrammarMarker):
2541
2542 2011-03-28  Adele Peterson  <adele@apple.com>
2543
2544         Build fix.
2545
2546         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2547         (LayoutTestController::hasGrammarMarker):
2548
2549 2011-03-28  Adele Peterson  <adele@apple.com>
2550
2551         Reviewed by Eric Seidel.
2552
2553         Testing support for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
2554         https://bugs.webkit.org/show_bug.cgi?id=57173
2555
2556         * DumpRenderTree/LayoutTestController.cpp:
2557         (hasGrammarMarkerCallback): Added.
2558         (LayoutTestController::staticFunctions): Added case for hasGrammarMarker.
2559         * DumpRenderTree/LayoutTestController.h:
2560         * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Call setGrammarCheckingEnabled.
2561         * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasGrammarMarker): Added. Call new hasGrammarMarker method.
2562
2563 2011-03-28  Csaba Osztrogonác  <ossy@webkit.org>
2564
2565         Reviewed by Benjamin Poulain.
2566
2567         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
2568         https://bugs.webkit.org/show_bug.cgi?id=57087
2569
2570         Trivial typo fix after r82082.
2571
2572         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2573         (WTR::activateFonts):
2574
2575 2011-03-28  Alexis Menard  <alexis.menard@openbossa.org>
2576
2577         Reviewed by Andreas Kling.
2578
2579         Add myself to the committers list.
2580
2581         * Scripts/webkitpy/common/config/committers.py:
2582
2583 2011-03-28  Simon Fraser  <simon.fraser@apple.com>
2584
2585         Reviewed by Sam Weinig.
2586
2587         WebKit2 unfortunately uses code from WebKit, so MiniBrowser needs
2588         to link against WebKit.framework for now.
2589
2590         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2591
2592 2011-03-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
2593
2594         Reviewed by Andreas Kling.
2595
2596         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
2597         https://bugs.webkit.org/show_bug.cgi?id=57087
2598
2599         Disable QT_ASCII_CAST_WARNINGS for applications.
2600
2601         * DumpRenderTree/qt/DumpRenderTree.pro:
2602         * DumpRenderTree/qt/ImageDiff.pro:
2603         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2604         * MiniBrowser/qt/MiniBrowser.pro:
2605         * QtTestBrowser/QtTestBrowser.pro:
2606         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2607
2608 2011-03-28  Andreas Kling  <kling@webkit.org>
2609
2610         Reviewed by Kenneth Rohde Christiansen.
2611
2612         [Qt] QtTestBrowser doesn't reset its window title when opening about:blank
2613         https://bugs.webkit.org/show_bug.cgi?id=57224
2614
2615         * QtTestBrowser/mainwindow.cpp:
2616         (MainWindow::buildUI):
2617         (MainWindow::onTitleChanged):
2618         * QtTestBrowser/mainwindow.h:
2619
2620 2011-03-27  Jer Noble  <jer.noble@apple.com>
2621
2622         Reviewed by Maciej Stachowiak.
2623
2624         Full Screen: disable keyboard access by default
2625         https://bugs.webkit.org/show_bug.cgi?id=56684
2626
2627         Accept the withKeyboard parameter to supportsFullScreenForElement.
2628
2629         * DumpRenderTree/mac/UIDelegate.mm:
2630         (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
2631
2632 2011-03-27  Patrick Gansterer  <paroga@webkit.org>
2633
2634         Reviewed by David Levin.
2635
2636         check-webkit-style should check ChangeLog for a valid bug number
2637         https://bugs.webkit.org/show_bug.cgi?id=57184
2638
2639         * Scripts/webkitpy/style/checker.py:
2640         * Scripts/webkitpy/style/checker_unittest.py:
2641         * Scripts/webkitpy/style/checkers/changelog.py: Added.
2642         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Added.
2643
2644 2011-03-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
2645
2646         Reviewed by Andreas Kling.
2647
2648         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
2649         https://bugs.webkit.org/show_bug.cgi?id=57087
2650
2651         Use explicit conversion for string to avoid depending on the default codec
2652         installed by the user code.
2653
2654         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2655         (WTR::activateFonts):
2656
2657 2011-03-26  Maciej Stachowiak  <mjs@apple.com>
2658
2659         Revert inadvertantly committed changes.
2660
2661         * Scripts/old-run-webkit-tests:
2662         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2663
2664 2011-03-26  Andreas Kling  <kling@webkit.org>
2665
2666         Reviewed by Kenneth Rohde Christiansen.
2667
2668         [Qt] Show page icons (favicons) in QtTestBrowser location bar.
2669         https://bugs.webkit.org/show_bug.cgi?id=57162
2670
2671         * QtTestBrowser/QtTestBrowser.qrc:
2672         * QtTestBrowser/favicon.png: Added.
2673         * QtTestBrowser/locationedit.cpp:
2674         (defaultPageIcon):
2675         (LocationEdit::LocationEdit):
2676         (LocationEdit::setPageIcon):
2677         (LocationEdit::resizeEvent):
2678         (LocationEdit::updateInternalGeometry):
2679         * QtTestBrowser/locationedit.h:
2680         * QtTestBrowser/mainwindow.cpp:
2681         (MainWindow::buildUI):
2682         (MainWindow::onIconChanged):
2683         (MainWindow::onLoadStarted):
2684         * QtTestBrowser/mainwindow.h:
2685
2686 2011-03-23  Martin Robinson  <mrobinson@igalia.com>
2687
2688         Reviewed by Xan Lopez.
2689
2690         [GTK] Force DumpRenderTree to use 96 DPI
2691         https://bugs.webkit.org/show_bug.cgi?id=56866
2692
2693         Make sure that GTK+ is set to use 96 DPI when running tests. This ensures
2694         broader compatibility with WebKit2 and makes setting font sizes more straightforward.
2695
2696         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2697         (initializeGtkFontSettings): Set the screen resolution and GTK+ xft property to 96 DPI.
2698         (resetDefaultsToConsistentValues):Remove the call which repeatedly set the GDK screen resolution.
2699         (setDefaultsToConsistentStateValuesForTesting): Update the font sizes to reflect the new DPI.
2700
2701 2011-03-25  Andy Estes  <aestes@apple.com>
2702
2703         Reviewed by Adele Peterson.
2704
2705         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
2706         https://bugs.webkit.org/show_bug.cgi?id=49016
2707
2708         TestNetscapePlugIn needs to register support for an image MIME type so
2709         we can test that the embed tag prefers plug-ins to render image MIME
2710         types.
2711
2712         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Register image/png.
2713         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2714         (NP_GetMIMEDescription): Ditto.
2715         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Ditto.
2716
2717 2011-03-25  Jessie Berlin  <jberlin@apple.com>
2718
2719         Reviewed by Sam Weinig.
2720
2721         WebKit2: Need to be able to set and get the Cookie Storage Policy.
2722         https://bugs.webkit.org/show_bug.cgi?id=50780
2723
2724         Add a test for getting and setting the HTTP Cookie Accept Policy in WebKit2.
2725
2726         The test is named "CookieManager" so that we can eventually exercise more of the
2727         CookieManager functionality in the test.
2728
2729         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: Added.
2730         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
2731         Assert that the policy returned is equal to the policy set in
2732         didGetUserHTTPCookieAcceptPolicy, and then restore the user's policy.
2733         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
2734         Set the policy to something different than the user's policy and get the policy again.
2735         (TestWebKitAPI::didFinishLoadForFrame):
2736         Get the user's policy so that it can be restored at the end of the test.
2737         (TestWebKitAPI::TEST):
2738         Load about:blank so that the Web Process gets instatiated (needed to get the
2739         CookieManager).
2740
2741         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2742         Add CookieManager.cpp.
2743
2744 2011-03-24  Kevin Ollivier  <kevino@theolliviers.com>
2745
2746         [wx] Fix the build so that gcc-4.1 and up can be used to build on SnowLeopard.
2747
2748         * wx/build/settings.py:
2749
2750 2011-03-24  Ilya Sherman  <isherman@chromium.org>
2751
2752         Reviewed by Adam Roben.
2753
2754         Implement layoutTestController.setAutoFilled in DRT on Windows
2755         https://bugs.webkit.org/show_bug.cgi?id=56828
2756
2757         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2758         (LayoutTestController::setAutofilled): Implemented.
2759
2760 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
2761
2762         Unreviewed build correction.
2763
2764         Correct vsprops file for Debug variant of the CFLite build.
2765         Disable a CFNETWORK-specific test when building for CFLite.
2766
2767         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops:
2768         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2769
2770 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
2771
2772         Reviewed by Adam Barth.
2773
2774         fix regressions introduced in 81908 - there were a couple of
2775         code paths that only fired under python 2.5 that I missed.
2776
2777         Also change a couple of 'python' references to sys.executable
2778         in order to handle runing test-webkitpy with a binary other than
2779         something called 'python'.
2780
2781         https://bugs.webkit.org/show_bug.cgi?id=57063
2782
2783         * Scripts/webkitpy/layout_tests/port/mac.py:
2784         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2785         * Scripts/webkitpy/test/cat.py:
2786         * Scripts/webkitpy/test/echo.py:
2787
2788 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
2789
2790         Unreviewed build correction.
2791
2792         Add a stub implementation of the TestInvocation dumping logic.
2793         Update project files to reflect new file.
2794
2795         * WebKitTestRunner/cairo: Added.
2796         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added.
2797         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2798         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2799
2800 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
2801
2802         Reviewed by Tony Chang.
2803
2804         new-run-webkit-tests: clean up worker model defaults. This
2805         changes the default behavior to 'threads' instead of
2806         'old-threads', and clarifies that chromium-win-* and
2807         chromium-mac-leopard are exceptions.
2808
2809         https://bugs.webkit.org/show_bug.cgi?id=56971
2810
2811         * Scripts/webkitpy/layout_tests/port/base.py:
2812         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2813         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2814         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2815         * Scripts/webkitpy/layout_tests/port/test.py:
2816         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2817
2818 2011-03-23  Leandro Gracia Gil  <leandrogracia@chromium.org>
2819
2820         Reviewed by Darin Adler.
2821
2822         Media Stream API: fix the order of the options in build-webkit.
2823         https://bugs.webkit.org/show_bug.cgi?id=56949
2824
2825         Fix the order of the options in build-webkit.
2826
2827         * Scripts/build-webkit:
2828
2829 2011-03-23  Adam Klein  <adamk@chromium.org>
2830
2831         Reviewed by Mihai Parparita.
2832
2833         Add an option to new-run-webkit-httpd to allow overriding the location of LayoutTests directory
2834         https://bugs.webkit.org/show_bug.cgi?id=56884
2835
2836         This option will be utilized by Chromium's ui_tests to allow
2837         referencing js-test-resources from a layout test over HTTP.
2838
2839         * Scripts/new-run-webkit-httpd:
2840         Added --layout_tests_dir option.
2841         * Scripts/webkitpy/layout_tests/port/http_server.py:
2842         Plumbed through as layout_tests_dir param.
2843
2844 2011-03-23  Dirk Pranke  <dpranke@chromium.org>
2845
2846         Reviewed by Mihai Parparita.
2847
2848         new-run-webkit-tests: run tests in ascending alphabetical order per
2849         dir. This is a second attempt at the fix; the first attempt, in 
2850         r81597, broke the behavior on the old-inline and old-threads
2851         worker models.
2852
2853         https://bugs.webkit.org/show_bug.cgi?id=56760
2854
2855         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2856         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2857         * Scripts/webkitpy/layout_tests/port/test.py:
2858         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2859
2860 2011-03-23  Mario Sanchez Prada  <msanchez@igalia.com>
2861
2862         Reviewed by Martin Robinson.
2863
2864         [GTK] GTK's DRT to ouput detail's string for the 'property-change' signal
2865         https://bugs.webkit.org/show_bug.cgi?id=56953
2866
2867         Print the string for the detail of 'property-change' signal.
2868
2869         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
2870         (axObjectEventListener): Print the detail string.
2871
2872 2011-03-23  Yury Semikhatsky  <yurys@chromium.org>
2873
2874         Reviewed by Pavel Feldman.
2875
2876         [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
2877         https://bugs.webkit.org/show_bug.cgi?id=56843
2878
2879         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2880         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2881
2882 2011-03-22  Eric Seidel  <eric@webkit.org>
2883
2884         Reviewed by Adam Barth.
2885
2886         Teach update-webkit about gyp
2887         https://bugs.webkit.org/show_bug.cgi?id=56881
2888
2889         This makes it possible for someone who builds from Xcode
2890         to just run update-webkit --gyp and have the project files
2891         generated after update automatically.
2892
2893         I also added a stand-alone "generate-project-files" script
2894         wrapping Source/gyp/configure.  This makes running gyp simpler
2895         since most people will not have gyp or Source/gyp in their path.
2896
2897         * Scripts/build-webkit:
2898         * Scripts/generate-project-files: Added.
2899         * Scripts/update-webkit:
2900
2901 2011-03-22  Anton D'Auria  <adauria@apple.com>
2902
2903         Reviewed by Alexey Proskuryakov.
2904
2905         Add +[WebApplicationCache getOriginsWithCache]
2906         https://bugs.webkit.org/show_bug.cgi?id=56722
2907
2908         * DumpRenderTree/LayoutTestController.cpp:
2909         (originsWithApplicationCacheCallback):
2910         (LayoutTestController::staticFunctions):
2911         * DumpRenderTree/LayoutTestController.h:
2912         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
2913         (LayoutTestController::originsWithApplicationCache):
2914         * DumpRenderTree/chromium/LayoutTestController.h:
2915         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
2916         (LayoutTestController::originsWithApplicationCache):
2917         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Pass array of origin's database identifiers.
2918         (originsArrayToJS): Helper function for converting array of WebSecurityOrigins to a JS array of origin identifiers.
2919         (LayoutTestController::originsWithApplicationCache):
2920         (LayoutTestController::originsWithLocalStorage):
2921         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
2922         (LayoutTestController::originsWithApplicationCache):
2923         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2924         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
2925         (LayoutTestController::originsWithApplicationCache):
2926         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Added stub.
2927         (LayoutTestController::originsWithApplicationCache):
2928
2929 2011-03-22  Eric Seidel  <eric@webkit.org>
2930
2931         Reviewed by Adam Barth.
2932
2933         Add support to build-webkit for building with gyp-generated project files
2934         https://bugs.webkit.org/show_bug.cgi?id=56877
2935
2936         build-webkit is a cesspool.  This change just hacks in --gyp support for Mac.
2937         Eventually we'll want to support gyp-generated projects in a more general manner.
2938
2939         * Scripts/build-webkit:
2940
2941 2011-03-22  David Kilzer  <ddkilzer@apple.com>
2942
2943         <http://webkit.org/b/56781> Add --dsym switch to enable dsym generation when building with Xcode
2944
2945         Reviewed by Joseph Pecoraro.
2946
2947         * Scripts/build-webkit: Updated usage statement to include
2948         --dsym.
2949         * Scripts/webkitdirs.pm: Added $generateDsym variable.
2950         (generateDsym): Added. Call determineGenerateDsym() and
2951         return $generateDsym.
2952         (determineGenerateDsym): Added.  Parse @ARGV for --dsym and set
2953         $generateDsym.
2954         (argumentsForXcode): Added.  Returns additional arguments for
2955         xcodebuild based on command-line switches.
2956         (XcodeOptions): Updated to include argumentsForXcode() in the
2957         array returned.
2958
2959 2011-03-22  Adam Roben  <aroben@apple.com>
2960
2961         Make Leopard Debug bots and Windows XP Debug (Tests) core builders
2962
2963         These bots are consistently green again.
2964
2965         Fixes <http://webkit.org/b/56830> Leopard Debug bots and Windows XP Debug (Tests) should be
2966         core builders
2967
2968         Rubber-stamped by Antti Koivisto.
2969
2970         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2971         (BuildBot.__init__): Loosened the regexps for Leopard and Windows.
2972
2973         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2974         (BuildBotTest.test_builder_name_regexps): Updated expectations.
2975
2976 2011-03-21  Sheriff Bot  <webkit.review.bot@gmail.com>
2977
2978         Unreviewed, rolling out r81597.
2979         http://trac.webkit.org/changeset/81597
2980         https://bugs.webkit.org/show_bug.cgi?id=56801
2981
2982         Change results in lots of unexpected flaky on the dashboard.
2983         (Requested by pfeldman on #webkit).
2984
2985         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2986         * Scripts/webkitpy/layout_tests/port/test.py:
2987         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2988
2989 2011-03-21  Sam Weinig  <sam@webkit.org>
2990
2991         Fix failing tests on the WebKit2 bots.
2992
2993         * WebKitTestRunner/TestController.cpp:
2994         (WTR::TestController::resetStateToConsistentValues):
2995
2996 2011-03-21  Daniel Sievers  <sievers@google.com>
2997
2998         Reviewed by Simon Fraser.
2999
3000         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
3001         https://bugs.webkit.org/show_bug.cgi?id=56139
3002
3003         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3004         (main):
3005         * DumpRenderTree/chromium/LayoutTestController.cpp:
3006         (LayoutTestController::LayoutTestController):
3007         (LayoutTestController::layerTreeAsText):
3008         * DumpRenderTree/chromium/LayoutTestController.h:
3009         (LayoutTestController::setShowDebugLayerTree):
3010         * DumpRenderTree/chromium/TestShell.cpp:
3011         (TestShell::runFileTest):
3012         (TestShell::dump):
3013         * DumpRenderTree/chromium/TestShell.h:
3014         (TestParams::TestParams):
3015
3016 2011-03-21  Adam Roben  <aroben@apple.com>
3017
3018         Try again to get buildbot to show run-javascriptcore-tests's actual.html as an HTML file
3019
3020         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
3021         output as plain text
3022
3023         Reviewed by David Kilzer.
3024
3025         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3026         (RunJavaScriptCoreTests): List actual.html as one of our log files so it will get uploaded
3027         to the master.
3028         (RunJavaScriptCoreTests.commandComplete): Reading the actual.html file here won't work,
3029         since we're running on the build master, not the slave. Instead, turn the raw source of
3030         actual.html which the build slave uploaded into an HTML log.
3031
3032 2011-03-21  Dirk Pranke  <dpranke@chromium.org>
3033
3034         Reviewed by Mihai Parparita.
3035
3036         new-run-webkit-tests: run tests in ascending alphabetical order per dir
3037         https://bugs.webkit.org/show_bug.cgi?id=56760
3038
3039         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3040         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3041         * Scripts/webkitpy/layout_tests/port/test.py:
3042
3043 2011-03-21  Leandro Gracia Gil  <leandrogracia@chromium.org>
3044
3045         Reviewed by Steve Block.
3046
3047         Media Stream API patch 0: adding compilation guards.
3048         https://bugs.webkit.org/show_bug.cgi?id=56458
3049
3050         Adding options to enable the media stream API feature in Chromium.
3051
3052         * Scripts/build-webkit:
3053
3054 2011-03-21  Qi Zhang  <qi.2.zhang@nokia.com>
3055
3056         Reviewed by Laszlo Gombos.
3057
3058         [Qt] Add a command line option to capture stdout and stderr for DumpRenderTree
3059         https://bugs.webkit.org/show_bug.cgi?id=56323
3060
3061         Using freopen to redirect STDOUT and STDERR when DumpRenderTree command line provide 
3062         "--stdout" or "--stderr" option.
3063
3064         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3065         (WebCore::DumpRenderTree::~DumpRenderTree):
3066         (WebCore::DumpRenderTree::processArgsLine):
3067         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
3068         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3069         (WebCore::DumpRenderTree::setRedirectOutputFileName):
3070         (WebCore::DumpRenderTree::setRedirectErrorFileName):
3071         * DumpRenderTree/qt/main.cpp:
3072         (isOption):
3073         (takeOptionValue):
3074         (printUsage):
3075         (main):
3076
3077 2011-03-21  Adam Roben  <aroben@apple.com>
3078
3079         Fix exceptions on the buildbot due to my last change
3080
3081         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3082         (RunJavaScriptCoreTests.commandComplete): Catch exceptions due to actual.html not existing.
3083
3084 2011-03-21  Adam Roben  <aroben@apple.com>
3085
3086         Teach buildbot to treat run-javascriptcore-tests's actual.html as an HTML file
3087
3088         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
3089         output as plain text
3090
3091         Reviewed by Darin Adler.
3092
3093         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3094         (RunJavaScriptCoreTests): Removed the logfiles variable, which can only handle plaintext
3095         logs.
3096         (RunJavaScriptCoreTests.commandComplete): Use the addHTMLLog method to upload actual.html to
3097         the build master. This will correctly treat it as HTML.
3098
3099 2011-03-20  Bill Budge  <bbudge@chromium.org>
3100
3101         Reviewed by Adam Barth.
3102
3103         Rename ThreadSafeShared to ThreadSafeRefCounted
3104         https://bugs.webkit.org/show_bug.cgi?id=56714
3105
3106         No new tests. Exposes no new functionality.
3107
3108         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h.
3109         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
3110         * Scripts/do-webcore-rename:
3111
3112 2011-03-19  Anton D'Auria  <adauria@apple.com>
3113
3114         Reviewed by Dan Bernstein.
3115
3116         Add stub to LayoutTestControllerGtk.cpp to fix GTK build
3117         https://bugs.webkit.org/show_bug.cgi?id=56719
3118
3119         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Adding stub.
3120         (LayoutTestController::clearApplicationCacheForOrigin):
3121
3122 2011-03-19  Anton D'Auria  <adauria@apple.com>
3123
3124         Reviewed by Alexey Proskuryakov.
3125
3126         ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
3127         https://bugs.webkit.org/show_bug.cgi?id=56415
3128
3129         * DumpRenderTree/LayoutTestController.cpp:
3130         (clearApplicationCacheForOriginCallback):
3131         (LayoutTestController::staticFunctions):
3132         * DumpRenderTree/LayoutTestController.h:
3133         * DumpRenderTree/chromium/LayoutTestController.cpp: Adding stubs.
3134         (LayoutTestController::LayoutTestController):
3135         (LayoutTestController::clearAllApplicationCaches):
3136         (LayoutTestController::clearApplicationCacheForOrigin): 
3137         * DumpRenderTree/chromium/LayoutTestController.h:
3138         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Adding stub.
3139         (LayoutTestController::clearApplicationCacheForOrigin):
3140         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Adding stub.
3141         (LayoutTestController::clearApplicationCacheForOrigin):
3142         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3143         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Adding stub.
3144         (LayoutTestController::clearApplicationCacheForOrigin):
3145         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Adding stub.
3146         (LayoutTestController::clearApplicationCacheForOrigin):
3147
3148 2011-03-18  Dan Bernstein  <mitz@apple.com>
3149
3150         Revised build fix for r81135.
3151
3152         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
3153         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3154
3155 2011-03-18  Adam Roben  <aroben@apple.com>
3156
3157         Windows build fix
3158
3159         * WebKitTestRunner/config.h: Add a missing #endif.
3160
3161 2011-03-18  Andreas Kling  <kling@webkit.org>
3162
3163         Unbreak Qt build after r81494.
3164
3165         * WebKitTestRunner/qt/TestInvocationQt.cpp:
3166         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3167
3168 2011-03-18  Sam Weinig  <sam@webkit.org>
3169
3170         Fix windows build. This was really Adam Roben's fault. I swear!
3171
3172         * WebKitTestRunner/config.h:
3173
3174 2011-03-18  Sam Weinig  <sam@webkit.org>
3175
3176         Reviewed by Adam Roben.
3177
3178         Pixel tests don't work in WebKitTestRunner on Windows
3179         https://bugs.webkit.org/show_bug.cgi?id=56630
3180
3181         Cross-platformize (Mac and Windows CG) the pixel dumping code in WebKitTestRunner to use WebKit2
3182         built-in snapshotting instead of using the window server on the Mac.
3183
3184         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3185         (WTR::InjectedBundle::InjectedBundle):
3186         (WTR::InjectedBundle::didReceiveMessage):
3187         (WTR::InjectedBundle::beginTesting):
3188         (WTR::InjectedBundle::done):
3189         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3190         (WTR::InjectedBundle::setPixelResult):
3191         (WTR::InjectedBundle::shouldDumpPixels):
3192         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3193         (WTR::InjectedBundlePage::dump):
3194         Take the snapshot in the bundle and send it to the UIProcess for dumping.
3195
3196         * WebKitTestRunner/TestInvocation.cpp:
3197         (WTR::TestInvocation::invoke):
3198         (WTR::TestInvocation::dump):
3199         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3200         * WebKitTestRunner/TestInvocation.h:
3201         * WebKitTestRunner/cg: Added.
3202         * WebKitTestRunner/cg/TestInvocationCG.cpp: Copied from WebKitTestRunner/mac/TestInvocationMac.mm.
3203         (WTR::createCGContextFromImage):
3204         (WTR::computeMD5HashStringForContext):
3205         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3206         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
3207         Making pixel dumping code shared for CG ports. Also use the WTF/MD5 instead of platform specific code.
3208
3209         * WebKitTestRunner/win/TestInvocationWin.cpp:
3210         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3211         Keep stub for Cairo build.
3212
3213         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Added.
3214         Add CG configuration.
3215
3216         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3217         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3218         Add new files.
3219
3220 2011-03-18  Adam Roben  <aroben@apple.com>
3221
3222         Don't allow Leaks Viewer's vertical scrollbar to cover up long function names
3223
3224         Rubber-stamped by Simon Fraser.
3225
3226         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
3227         (.data-grid .data-container): Use overflow-y:auto instead of the Inspector's default
3228         overflow-y:overlay so that the scrollbar doesn't overlay the content.
3229
3230 2011-03-18  Adam Roben  <aroben@apple.com>
3231
3232         Don't ellipsize long or indented function names in Leaks Viewer
3233
3234         Fixes <http://webkit.org/b/56037> Leaks viewer needs horizontal
3235         scrollbar
3236
3237         Reviewed by Simon Fraser.
3238
3239         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
3240         (.data-grid .data-container):
3241         (.data-grid td > div, .data-grid th > div):
3242         Allow the contents to extend to the right.
3243
3244 2011-03-18  Adam Roben  <aroben@apple.com>
3245
3246         Fix some leaks in DRT seen on the leaks bot
3247
3248         Fixes <http://webkit.org/b/56638> addURLToRedirectCallback and
3249         setWillSendRequestClearHeaderCallback in DRT are leaky
3250
3251         Reviewed by Alexey Proskuryakov.
3252
3253         * DumpRenderTree/ForwardingHeaders/wtf/OwnArrayPtr.h: Added.
3254
3255         * DumpRenderTree/LayoutTestController.cpp:
3256         (addURLToRedirectCallback):
3257         (setWillSendRequestClearHeaderCallback):
3258         Use OwnArrayPtr to cause the strings to be deleted.
3259
3260 2011-03-18  Adam Roben  <aroben@apple.com>
3261
3262         Fix a NSURLCredential leak seen on the leaks bot
3263
3264         Fixes <http://webkit.org/b/56637> -[SynchronousLoader
3265         connection:didReceiveAuthenticationChallenge:] is leaky
3266
3267         Reviewed by John Sullivan.
3268
3269         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3270         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]): Use a RetainPtr to
3271         cause the NSURLCredential to be released.
3272
3273 2011-03-18  John Knottenbelt  <jknotten@chromium.org>
3274
3275         Unreviewed.
3276
3277         Remove unnecessary brackets around my email address.
3278
3279         * Scripts/webkitpy/common/config/committers.py:
3280
3281 2011-03-18  Adam Roben  <aroben@apple.com>
3282         
3283         Remove some files I accidentally added in r81454
3284
3285         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
3286         * WebKitTestRunner/cg/TestInvocationCG.cpp: Removed.
3287
3288 2011-03-18  Adam Roben  <aroben@apple.com>
3289
3290         Ignore an NSNumberFormatter leak on SnowLeopard
3291
3292         * Scripts/old-run-webkit-tests:
3293         (countAndPrintLeaks): Ignore leaks in -[NSNumberFormatter
3294         getObjectValue:forString:errorDescription:].
3295
3296 2011-03-18  Adam Roben  <aroben@apple.com>
3297
3298         Fix a leak beneath LayoutTestController::authenticateSession seen on the bots
3299
3300         Rubber-stamped by Mark Rowe.
3301
3302         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3303         (LayoutTestController::authenticateSession): Use a RetainPtr to cause the NSURLRequest to be
3304         released.
3305
3306 2011-03-17  Adam Roben  <aroben@apple.com>
3307
3308         Address a review comment I missed in r81445
3309
3310         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
3311         (LeaksParserWorker.prototype._parseLeaks): Anchor the RegExp used to find the number of
3312         leaked bytes to speed up searching on long lines.
3313
3314 2011-03-17  Adam Roben  <aroben@apple.com>
3315
3316         Mark leaky builds orange, even if all regression tests passed
3317
3318         Fixes <http://webkit.org/b/56609> SnowLeopard Intel Leaks bot appears green on
3319         build.webkit.org when all tests pass even though there are still leaks
3320
3321         Reviewed by Dan Bernstein.
3322
3323         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3324         (RunWebKitLeakTests): Set the warnOnWarnings property to True so that the entire build will
3325         be marked orange if this build step generates warnings.
3326
3327 2011-03-17  Adam Roben  <aroben@apple.com>
3328
3329         Allow values in Leaks Viewer to be shown as percentages
3330
3331         Double-clicking on a column will toggle between showing percentages and showing real values.
3332
3333         Fixes <http://webkit.org/b/56628> Would like to view values as percentages of the total
3334         number of leaked bytes in Leaks Viewer
3335
3336         Reviewed by Joe Pecoraro.
3337
3338         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
3339         (LeaksParserWorker.prototype._incorporateLeaks): Calculate the (never-shown) top-level
3340         node's totalTime, which is used in calculating percentages.
3341
3342         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
3343         (monkeyPatchInspectorObjects): Only format values as bytes if we aren't supposed to be
3344         showing them as percentages.
3345
3346 2011-03-17  Adam Roben  <aroben@apple.com>
3347
3348         Show the number of leaked bytes, not just leaked allocations, in Leaks Viewer
3349
3350         The Self and Total columns now report the number of leaked bytes. The new Calls column shows
3351         the number of leaked allocations. And the new Average column shows the average number of
3352         leaked bytes per call.
3353
3354         Fixes <http://webkit.org/b/56344> Leaks Viewer should show how many bytes were leaked, not
3355         just how many allocations
3356
3357         Reviewed by Joe Pecoraro.
3358
3359         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
3360         (LeaksParserWorker.prototype._parseLeaks): Parse the number of leaked bytes from the "Leak:"
3361         line and store it with the leak stack.
3362         (LeaksParserWorker.prototype._createNode): Initialize the averageTime and numberOfCalls
3363         properties.
3364         (LeaksParserWorker.prototype._incorporateLeaks): Updated to get the stack from the .stack
3365         property, and changed to store the number of leaked bytes in .selfTime/.totalTime.
3366         .numberOfCalls now holds the number of leaked allocations.
3367
3368         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
3369         (Preferences): Set samplingCPUProfiler to false so that the Average and Calls columns will
3370         appear.
3371         (monkeyPatchInspectorObjects): Format the values as bytes.
3372
3373 2011-03-17  Adam Roben  <aroben@apple.com>
3374
3375         Make Leaks Viewer able to count leaks in builds that didn't fail any regression tests
3376
3377         Fixes <http://webkit.org/b/56626> Leaks Viewer omits recent builds which didn't fail any
3378         regression tests
3379
3380         Reviewed by James Robinson.
3381
3382         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
3383         (RecentBuildsLoader.prototype.start): Get the number of leaks out of the "text" array, which
3384         is always populated, even when all regression tests pass.
3385
3386 2011-03-10  Hayato Ito  <hayato@chromium.org>
3387
3388         Reviewed by Tony Chang.
3389
3390         Add a check logic for reftests in case that a reftest is marked AS REBASELINE.
3391
3392         https://bugs.webkit.org/show_bug.cgi?id=56076
3393
3394         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3395
3396 2011-03-17  Adam Roben  <aroben@apple.com>
3397
3398         Skip a compositing-sensitive test when accelerated compositing is disabled
3399
3400         Reviewed by Sam Weinig.
3401
3402         * Scripts/old-run-webkit-tests: Skip media/media-document-audio-repaint.html when
3403         accelerated compositing is disabled.
3404
3405 2011-03-17  Adam Roben  <aroben@apple.com>
3406
3407         Start using PlatformSpecificScheduler for the Mac builders
3408
3409         The current set of file/directory patterns should work for Mac builders. We may discover
3410         that there are more files and directories we can exclude from the Mac builds, but they can
3411         be added later.
3412
3413         Fixes <http://webkit.org/b/56593> Mac builders do lots of unnecessary builds
3414
3415         Reviewed by Mark Rowe.
3416
3417         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the Mac builders into two
3418         PlatformSpecificSchedulers: one for Leopard, and one for SnowLeopard.
3419
3420         * Scripts/webkitpy/common/config/build.py:
3421         (_should_file_trigger_build): Allow "mac-leopard" and "mac-snowleopard" platforms, and
3422         cleaned up patterns a little bit.
3423
3424         * Scripts/webkitpy/common/config/build_unittest.py:
3425         (ShouldBuildTest): Fixed some expected results.
3426         (ShouldBuildTest.test_should_build): Start testing "mac-leopard" and "mac-snowleopard"
3427         platforms.
3428
3429 2011-03-17  Jeff Miller  <jeffm@apple.com>
3430
3431         Use a consistent set of file patterns in the svn:ignore property for all .xcodeproj directories, specifically:
3432         
3433         *.mode*
3434         *.pbxuser
3435         *.perspective*
3436         project.xcworkspace
3437         xcuserdata
3438
3439         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
3440         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
3441         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
3442         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
3443         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
3444
3445 2011-03-17  Adam Roben  <aroben@apple.com>
3446
3447         Make old-run-webkit-tests pick up mac-wk2 results when running in WebKit2 mode on Windows
3448
3449         Fixes <http://webkit.org/b/56563> Running WebKit2 tests on Windows should use results from
3450         mac-wk2
3451
3452         Reviewed by Anders Carlsson.
3453
3454         * Scripts/old-run-webkit-tests:
3455         (expectedDirectoryForTest): Clean up the code to search in extra Mac platform result
3456         directories on Windows. Add mac-wk2 to the set of extra platforms we look in on Windows when
3457         we're running in WebKit2 mode.
3458
3459 2011-03-17  Mikhail Naganov  <mnaganov@chromium.org>
3460
3461         Reviewed by Yury Semikhatsky.
3462
3463         Web Inspector: Clean up Inspector strings.
3464         https://bugs.webkit.org/show_bug.cgi?id=56557
3465
3466         Modify the script to deal correctly with "\xNN" escapes, and to
3467         check strings in Chromium's DevTools.js.
3468
3469         * Scripts/check-inspector-strings:
3470
3471 2011-03-17  Keith Kyzivat  <keith.kyzivat@nokia.com>
3472
3473         Reviewed by Benjamin Poulain.
3474
3475         Update autoinstall to install mechanize 0.2.4
3476         https://bugs.webkit.org/show_bug.cgi?id=56499
3477
3478         Newer versions of mechanize support HTTPS proxies, which is necessary
3479         for people using webkit-patch behind firewalls.
3480
3481         * Scripts/webkitpy/common/system/autoinstall.py:
3482         * Scripts/webkitpy/thirdparty/__init__.py:
3483
3484 2011-03-16  Sam Weinig  <sam@webkit.org>
3485
3486         Reviewed by Adam Roben.
3487
3488         REGRESSION (r81084): media/invalid-media-url-crash.html and editing/execCommand/indent-paragraphs.html failing on WebKit2
3489         https://bugs.webkit.org/show_bug.cgi?id=56541
3490
3491         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3492         (WTR::InjectedBundlePage::willSendRequestForFrame):
3493         Check for an empty host in addition to a null host.  This bug was introduced
3494         when porting off of the KURL code and onto the WKURLRef version.
3495
3496 2011-03-16  Sam Weinig  <sam@webkit.org>
3497
3498         Reviewed by Adam Roben.
3499
3500         Add Lucas Forschler to the list of WebKit committers.
3501
3502         * Scripts/webkitpy/common/config/committers.py:
3503
3504 2011-03-16  Sam Weinig  <sam@webkit.org>
3505
3506         Reviewed upon and dictated through Adam Roben.
3507
3508         Escape crashing function names in results.html. This fixes an issue
3509         when a crash involves a type with templates.
3510
3511         * Scripts/old-run-webkit-tests:
3512
3513 2011-03-16  Daniel Sievers  <sievers@google.com>
3514
3515         Reviewed by James Robinson.
3516
3517         Add setting to always force compositing mode
3518         https://bugs.webkit.org/show_bug.cgi?id=56156
3519
3520         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3521         (main):
3522         * DumpRenderTree/chromium/TestShell.cpp:
3523         (TestShell::TestShell):
3524         (TestShell::resetWebSettings):
3525         * DumpRenderTree/chromium/TestShell.h:
3526         (TestShell::setForceCompositingMode):
3527         * DumpRenderTree/chromium/WebPreferences.cpp:
3528         (WebPreferences::reset):
3529         (WebPreferences::applyTo):
3530         * DumpRenderTree/chromium/WebPreferences.h:
3531
3532 2011-03-15  Hayato Ito  <hayato@chromium.org>
3533
3534         Reviewed by Ojan Vafai.
3535
3536         Ignore files that will be used by reftests in old-run-webkit-tests.
3537
3538         https://bugs.webkit.org/show_bug.cgi?id=55936
3539
3540         * Scripts/old-run-webkit-tests:
3541
3542 2011-03-15  Felipe Oliveira da Silva Netto  <f.dachshund@gmail.com>
3543
3544         Reviewed by Adam Roben.
3545
3546         Function relativeScriptsDir doesn't return the correct relative
3547         Scripts directory.
3548
3549         * Scripts/webkitdirs.pm:
3550         (relativeScriptsDir): Ensure we use the directory that contains
3551         webkitdirs.pm, not the one that contains the original script that
3552         was invoked.
3553
3554 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
3555
3556         [wx] Build fixes for long linker commands on Win and method return error, plus a Mac
3557         fix to link against the Security framework after recent WebKitSystemInterface changes.
3558
3559         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3560         (LayoutTestController::originsWithLocalStorage):
3561         * wx/build/settings.py:
3562         * wx/build/waf_extensions.py:
3563
3564 2011-03-15  Sam Weinig  <sam@webkit.org>
3565
3566         Reviewed by Darin Adler.
3567
3568         Add script to convert a patch to a prettypatch and show in the default browser
3569         https://bugs.webkit.org/show_bug.cgi?id=56416
3570
3571         This can be used either like
3572             $ svn-create-patch | show-pretty-diff
3573         or
3574             $ show-pretty-diff patch.diff
3575
3576         * Scripts/show-pretty-diff: Added.
3577
3578 2011-03-15  Brian Weinstein  <bweinstein@apple.com>
3579
3580         Rubber-stamped by Adam Roben.
3581
3582         Adding myself as a reviewer.
3583
3584         * Scripts/webkitpy/common/config/committers.py:
3585
3586 2011-03-15  Anders Carlsson  <andersca@apple.com>
3587
3588         Try to fix the Windows build.
3589
3590         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
3591         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
3592
3593 2011-03-15  Anders Carlsson  <andersca@apple.com>
3594
3595         Reviewed by Sam Weinig.
3596
3597         Make sure that NP_Shutdown is always the last NPP function called
3598         https://bugs.webkit.org/show_bug.cgi?id=56391
3599
3600         Add a test that times out if an NP_Deallocate object is called after NP_Shutdown.
3601
3602         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3603         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3604         (PluginTest::PluginTest):
3605         (PluginTest::NP_Shutdown):
3606         (PluginTest::registerNPShutdownFunction):
3607         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3608         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp: Added.
3609         (NPDeallocateCalledBeforeNPShutdown::NPDeallocateCalledBeforeNPShutdown):
3610         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
3611         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::hasProperty):
3612         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::getProperty):
3613         (NPDeallocateCalledBeforeNPShutdown::NPP_New):
3614         (NPDeallocateCalledBeforeNPShutdown::NPP_GetValue):
3615         (NPDeallocateCalledBeforeNPShutdown::shutdown):
3616         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3617         (NP_Shutdown):
3618         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3619         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3620         * GNUmakefile.am:
3621
3622 2011-03-15  Ilya Sherman  <isherman@chromium.org>
3623
3624         Reviewed by Tony Chang.
3625
3626         Autofilled form elements are assigned fixed background color but not text color
3627         https://bugs.webkit.org/show_bug.cgi?id=48382
3628
3629         * DumpRenderTree/LayoutTestController.cpp:
3630         (setAutofilledCallback): Added.
3631         (LayoutTestController::staticFunctions):
3632         * DumpRenderTree/LayoutTestController.h:
3633         * DumpRenderTree/chromium/LayoutTestController.cpp:
3634         (LayoutTestController::LayoutTestController):
3635         (LayoutTestController::setAutofilled): Added.
3636         * DumpRenderTree/chromium/LayoutTestController.h:
3637         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3638         (LayoutTestController::setAutofilled): Added.
3639         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3640         (LayoutTestController::setAutofilled): Added.
3641         (LayoutTestController::setValueForUser): Style tweak.
3642         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3643         (LayoutTestController::setAutofilled): Added (stub).
3644         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3645         (LayoutTestController::setAutofilled): Added (stub).
3646
3647 2011-03-15  Dan Bernstein  <mitz@apple.com>
3648
3649         Build fix after r81135.
3650
3651         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
3652
3653 2011-03-15  Dan Bernstein  <mitz@apple.com>
3654
3655         Build fix after r81135.
3656
3657         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
3658         * WebKitTestRunner/mac/TestControllerMac.mm:
3659         * WebKitTestRunner/mac/TestInvocationMac.mm:
3660         * WebKitTestRunner/mac/main.mm:
3661
3662 2011-03-15  Balazs Kelemen  <kbalazs@webkit.org>
3663
3664         Reviewed by Adam Barth.
3665
3666         REGRESSION(80977): breaks Qt ARMv7 Linux Release bot
3667         https://bugs.webkit.org/show_bug.cgi?id=56349
3668
3669         * QtTestBrowser/QtTestBrowser.pro: Link against fontconfig
3670         on platforms where we use it. Copied from DumpRenderTree.pro.
3671
3672 2011-03-15  Dan Bernstein  <mitz@apple.com>
3673
3674         Build fix after r81135.
3675
3676         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: