Build fix after r188982
[WebKit-https.git] / Tools / ChangeLog
1 2015-08-27  Alex Christensen  <achristensen@webkit.org>
2
3         Build fix after r188982
4
5         * MiniBrowser/win/CMakeLists.txt:
6         The directory structure changed in the move.
7
8 2015-08-27  Michael Catanzaro  <mcatanzaro@igalia.com>
9
10         [GTK] Unreviewed, install-dependencies should install geoclue2 on Fedora
11
12         geoclue-devel is for obsolete geoclue. Install geoclue2-devel instead.
13
14         * gtk/install-dependencies:
15
16 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
17
18         Unreviewed. Mark WTF_WordLock.ContendedShortSection as slow too.
19
20         * Scripts/run-gtk-tests:
21         (TestRunner):
22
23 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
24
25         Fix GTK+ WTR crashes in initializeMainRunLoop()
26
27         Rubber-stamped by Žan Doberšek.
28
29         Initialize threading and main thread before
30         RunLoop::initializeMainRunLoop(), since the GLib implementation of
31         the RunLoop uses isMainThread() to decide whether to create a new
32         GMainContext or use the default one. Also use RunLoop::run() and
33         ::stop() instead of gtk_main/quit.
34
35         * WebKitTestRunner/TestController.cpp:
36         (WTR::TestController::initialize):
37         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
38         (WTR::TestController::notifyDone):
39         (WTR::TestController::platformRunUntil):
40
41 2015-08-27  Filip Pizlo  <fpizlo@apple.com>
42
43         Unreviewed, further shorten a test that times out because it's very long
44         running.
45
46         I've locally run these tests on repeat for 24 hours and found no genuine
47         failures, like deadlocks. So, the timeouts are probably because the test
48         machine is slow and debug is slow. We should just run this test for fewer
49         iterations.
50
51         * TestWebKitAPI/Tests/WTF/Lock.cpp:
52         (TestWebKitAPI::TEST):
53
54 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
55
56         Unreviewed build fix attempt on EFL
57
58         * WebKitTestRunner/PlatformEfl.cmake:
59
60 2015-08-26  Alex Christensen  <achristensen@webkit.org>
61
62         Build fix after r188982
63
64         * MiniBrowser/win/CMakeLists.txt:
65         Find .rc files in correct directory.
66
67 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
68
69         [EFL] Bump cairo version to 1.14.2
70         https://bugs.webkit.org/show_bug.cgi?id=148474
71
72         Reviewed by Csaba Osztrogonác.
73
74         * efl/jhbuild.modules:
75
76 2015-08-26  Andy Estes  <aestes@apple.com>
77
78         Crash when following a Google search link to Twitter with Limit Adult Content enabled
79         https://bugs.webkit.org/show_bug.cgi?id=147651
80
81         Rubber-stamped by Brady Eidson.
82
83         Taught TestRunner how to decide the navigation policy after a delay.
84
85         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
86         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
87         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
88         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
89         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
90         * WebKitTestRunner/InjectedBundle/TestRunner.h:
91         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
92         * WebKitTestRunner/TestController.cpp:
93         (WTR::TestController::initialize):
94         (WTR::TestController::resetStateToConsistentValues):
95         (WTR::TestController::decidePolicyForNavigationAction):
96         * WebKitTestRunner/TestController.h:
97         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
98         * WebKitTestRunner/TestInvocation.cpp:
99         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
100
101 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
102
103         [Win] Rename 'WinLauncher' to 'MiniBrowser'
104         https://bugs.webkit.org/show_bug.cgi?id=148485
105
106         Reviewed by Alex Christensen
107
108         Move the WinLauncher project and source files to a subdirectory
109         of MiniBrowser. Globally change WinLauncher -> MiniBrowser in the
110         source code and project files.
111         
112         * MiniBrowser/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj.
113         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.ico.
114         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.rc.
115         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.
116         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters.
117         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCF.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props.
118         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCFLite.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props.
119         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props.
120         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props.
121         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc.
122         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.
123         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters.
124         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props.
125         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props.
126         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd.
127         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd.
128         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props.
129         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props.
130         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h.
131         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd.
132         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd.
133         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props.
134         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props.
135         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h.
136         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.ico: Removed.
137         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.rc: Removed.
138         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj: Removed.
139         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj.filters: Removed.
140         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCF.props: Removed.
141         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCFLite.props: Removed.
142         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCommon.props: Removed.
143         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherDebug.props: Removed.
144         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.rc: Removed.
145         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj: Removed.
146         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
147         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibCommon.props: Removed.
148         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibDebug.props: Removed.
149         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
150         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
151         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibProduction.props: Removed.
152         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibRelease.props: Removed.
153         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibResource.h: Removed.
154         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPostBuild.cmd: Removed.
155         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPreBuild.cmd: Removed.
156         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherProduction.props: Removed.
157         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherRelease.props: Removed.
158         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherResource.h: Removed.
159         * MiniBrowser/win: Copied from WinLauncher.
160         * MiniBrowser/win/Common.cpp:
161         * MiniBrowser/win/MiniBrowser.cpp: Copied from WinLauncher/WinLauncher.cpp.
162         * MiniBrowser/win/MiniBrowser.h: Copied from WinLauncher/WinLauncher.h.
163         * MiniBrowser/win/MiniBrowserReplace.h: Copied from WinLauncher/WinLauncherReplace.h.
164         * MiniBrowser/win/MiniBrowserWebHost.cpp: Copied from WinLauncher/WinLauncherWebHost.cpp.
165         * MiniBrowser/win/MiniBrowserWebHost.h: Copied from WinLauncher/WinLauncherWebHost.h.
166         * MiniBrowser/win/PageLoadTestClient.cpp:
167         * MiniBrowser/win/PageLoadTestClient.h:
168         * MiniBrowser/win/ResourceLoadDelegate.cpp:
169         * MiniBrowser/win/ResourceLoadDelegate.h:
170         * MiniBrowser/win/WinLauncher.cpp: Removed.
171         * MiniBrowser/win/WinLauncher.h: Removed.
172         * MiniBrowser/win/WinLauncher.vcxproj: Removed.
173         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.ico: Removed.
174         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.rc: Removed.
175         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
176         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
177         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
178         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
179         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
180         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
181         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
182         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
183         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
184         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
185         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
186         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
187         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
188         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
189         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
190         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
191         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
192         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
193         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
194         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
195         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
196         * MiniBrowser/win/WinLauncher.vcxproj/small.ico: Removed.
197         * MiniBrowser/win/WinLauncherReplace.h: Removed.
198         * MiniBrowser/win/WinLauncherWebHost.cpp: Removed.
199         * MiniBrowser/win/WinLauncherWebHost.h: Removed.
200         * MiniBrowser/win/WinMain.cpp:
201         * WinLauncher: Removed.
202         * WinLauncher/AccessibilityDelegate.cpp: Removed.
203         * WinLauncher/AccessibilityDelegate.h: Removed.
204         * WinLauncher/CMakeLists.txt: Removed.
205         * WinLauncher/Common.cpp: Removed.
206         * WinLauncher/DOMDefaultImpl.cpp: Removed.
207         * WinLauncher/DOMDefaultImpl.h: Removed.
208         * WinLauncher/PageLoadTestClient.cpp: Removed.
209         * WinLauncher/PageLoadTestClient.h: Removed.
210         * WinLauncher/PrintWebUIDelegate.cpp: Removed.
211         * WinLauncher/PrintWebUIDelegate.h: Removed.
212         * WinLauncher/ResourceLoadDelegate.cpp: Removed.
213         * WinLauncher/ResourceLoadDelegate.h: Removed.
214         * WinLauncher/WebDownloadDelegate.cpp: Removed.
215         * WinLauncher/WebDownloadDelegate.h: Removed.
216         * WinLauncher/WinLauncher.cpp: Removed.
217         * WinLauncher/WinLauncher.h: Removed.
218         * WinLauncher/WinLauncher.vcxproj: Removed.
219         * WinLauncher/WinLauncher.vcxproj/WinLauncher.ico: Removed.
220         * WinLauncher/WinLauncher.vcxproj/WinLauncher.rc: Removed.
221         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
222         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
223         * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
224         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
225         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
226         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
227         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
228         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
229         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
230         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
231         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
232         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
233         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
234         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
235         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
236         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
237         * WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
238         * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
239         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
240         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
241         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
242         * WinLauncher/WinLauncher.vcxproj/small.ico: Removed.
243         * WinLauncher/WinLauncherReplace.h: Removed.
244         * WinLauncher/WinLauncherWebHost.cpp: Removed.
245         * WinLauncher/WinLauncherWebHost.h: Removed.
246         * WinLauncher/WinMain.cpp: Removed.
247         * WinLauncher/resource.h: Removed.
248         * WinLauncher/stdafx.cpp: Removed.
249         * WinLauncher/stdafx.h: Removed.
250         * win/AssembleBuildLogs/AssembleLogs.cmd:
251
252 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
253
254         [Win] Simplify menu handling code in WinLauncher
255         https://bugs.webkit.org/show_bug.cgi?id=148461
256
257         Reviewed by Zalan Bujtas.
258
259         Revise 'ToggleMenuItem' to return a boolean value indicating if
260         it handled the message. Revise WndProc to use this to decide if it
261         should pass the message on to the default handler, rather than
262         duplicating the logic in both places.
263         
264         * WinLauncher/Common.cpp:
265         (ToggleMenuItem): Return true if the menu item message was handled.
266         (WndProc): If 'ToggleMenuItem' did not handle the message, pass
267         the message tothe default handler.
268
269 2015-08-26  Csaba Osztrogonác  <ossy@webkit.org>
270
271         Remove unused code after r188948
272         https://bugs.webkit.org/show_bug.cgi?id=148467
273
274         Reviewed by Gyuyoung Kim.
275
276         * WebKitTestRunner/TestController.cpp:
277         (WTR::TestController::platformPreferences): Deleted.
278
279 2015-08-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
280
281         [EFL][GTK] REGRESSION(r188828): All performance tests and almost all layout tests crash
282         https://bugs.webkit.org/show_bug.cgi?id=148377
283
284         Reviewed by Carlos Garcia Campos.
285
286         EFL and GTK don't support TestController::platformPreferences() yet which was introduced by r188828.
287         It caused all crashes of layout test and performance test on EFL and GTK. So this patch implements
288         TestController::platformPreferences() using WKPageGroupGetPreferences() which was previous thing for
289         EFL and GTK at the moment.
290
291         * WebKitTestRunner/TestController.cpp:
292         (WTR::TestController::platformWillRunTest):
293         * WebKitTestRunner/efl/TestControllerEfl.cpp:
294         (WTR::TestController::platformPreferences):
295         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
296         (WTR::TestController::platformPreferences):
297
298 2015-08-25  Nan Wang  <n_wang@apple.com>
299
300         AX: Enable accessibility/aria-controls.html test for mac
301         https://bugs.webkit.org/show_bug.cgi?id=148458
302
303         Reviewed by Chris Fleizach.
304
305         Implemented ariaControlsElementAtIndex(unsigned index).
306
307         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
308         (AccessibilityUIElement::ariaControlsElementAtIndex):
309         (AccessibilityUIElement::disclosedRowAtIndex):
310         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
311         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
312
313 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
314
315         Remove python tests for PassRefPtr 
316         https://bugs.webkit.org/show_bug.cgi?id=148463
317
318         Reviewed by Andy Estes.
319
320         As we're removing uses of PassRefPtr, we need to remove all python tests for PassRefPtr as well.
321
322         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
323         (PassPtrTest): Deleted.
324         (PassPtrTest.assert_pass_ptr_check): Deleted.
325         (PassPtrTest.test_pass_ref_ptr_in_function): Deleted.
326         (PassPtrTest.test_pass_other_type_ptr_in_function): Deleted.
327         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
328         (PassPtrTest.test_ref_ptr_parameter_value): Deleted.
329         (PassPtrTest.test_ref_ptr_member_variable): Deleted.
330         (PassPtrTest.test_ref_ptr_member_variable.Foo): Deleted.
331
332 2015-08-25  Andy Estes  <aestes@apple.com>
333
334         [iOS] run-webkit-tests fails if watchOS SDK is installed
335         https://bugs.webkit.org/show_bug.cgi?id=148453
336
337         Reviewed by David Kilzer.
338
339         * Scripts/webkitpy/xcode/simulator.py:
340         (Simulator): Taught Simulator how to parse watchOS runtimes and devices.
341         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
342
343 2015-08-25  Aakash Jain  <aakash_jain@apple.com>
344
345         iOS Simulator layout-tests fail to start while cleaning a directory structure if simulator is already running
346         https://bugs.webkit.org/show_bug.cgi?id=148197
347         rdar://problem/22334382
348
349         Reviewed by Daniel Bates.
350
351         * BuildSlaveSupport/kill-old-processes: Add Simulator to the list of processes to kill (for iOS builders).
352         * Scripts/webkitpy/port/ios.py:
353         (IOSSimulatorPort): Converted bundle id com.apple.iphonesimulator to a variable SIMULATOR_BUNDLE_ID.
354         (IOSSimulatorPort._quitIOSSimulator): Common function to quit iOS Simulator.
355         (IOSSimulatorPort.clean_up_test_run): Quit the simulator during the cleanup.
356         (IOSSimulatorPort.check_sys_deps): No need to quit the simulator here as its now being quit in reset_preferences().
357         (IOSSimulatorPort.reset_preferences): Quit the simulator before trying to delete associated data directory.
358
359 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
360
361         Remove PassRefPtr style check rule
362         https://bugs.webkit.org/show_bug.cgi?id=148432
363
364         Reviewed by Andreas Kling.
365
366         PassRefPtr is being removed. Thus style rule needs to be removed as well.
367
368         * Scripts/webkitpy/style/checkers/cpp.py:
369         (_check_parameter_name_against_text): Deleted.
370         (check_function_definition_and_pass_ptr): Deleted.
371         (check_function_definition): Deleted.
372         (check_pass_ptr_usage): Deleted.
373         (process_line): Deleted.
374         (CppChecker): Deleted.
375
376 2015-08-25  Brent Fulgham  <bfulgham@apple.com>
377
378         [Win] Expose "Inverted Colors" option in WinLauncher
379         https://bugs.webkit.org/show_bug.cgi?id=148451
380
381         Reviewed by Tim Horton.
382
383         Add the ability to toggle the "Inverted Colors" preference
384         in WinLauncher.
385         
386         * WinLauncher/Common.cpp:
387         (ToggleMenuItem): Toggle the feature when the menu item
388         is selected.
389         (WndProc): Recognize the new menu option.
390         * WinLauncher/WinLauncher.cpp:
391         (WinLauncher::setToDefaultPreferences): Launch with "Invert
392         Colors" turned off.
393         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu
394         entry for "Invert Colors".
395         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
396
397 2015-08-25  Nan Wang  <n_wang@apple.com>
398
399         [Mac] accessibility/document-attributes.html fails
400         https://bugs.webkit.org/show_bug.cgi?id=116636
401
402         Reviewed by Chris Fleizach.
403
404         Implemented documentURI() and documentEncoding().
405
406         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
407         (AccessibilityUIElement::documentEncoding):
408         (AccessibilityUIElement::documentURI):
409         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
410         (WTR::AccessibilityUIElement::documentEncoding):
411         (WTR::AccessibilityUIElement::documentURI):
412
413 2015-08-24  Brent Fulgham  <bfulgham@apple.com>
414
415         [Win] Unreviewed test gardening.
416
417         Fix another case where the logging string is constructed using the variable 'frame',
418         but the method argument is not given a name. This causes the global 'frame' value to
419         be used, producing incorrect output.
420
421         * DumpRenderTree/win/FrameLoadDelegate.cpp:
422         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Use 'frame'
423         argument.
424
425 2015-08-24  Tim Horton  <timothy_horton@apple.com>
426
427         (Finally...) get rid of WKViewIOS
428         https://bugs.webkit.org/show_bug.cgi?id=148404
429
430         Reviewed by Anders Carlsson.
431
432         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
433         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
434         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
435         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
436         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
437         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
438         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
439         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
440         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
441         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
442         Mark tests that use WKBrowsingContextController as Mac-only.
443
444         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
445         (WTR::AccessibilityController::addNotificationListener):
446         * WebKitTestRunner/ios/mainIOS.mm:
447         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
448         Import UIKit instead of depending on WKView.h to do so.
449
450 2015-08-24  Jason Marcell  <jmarcell@apple.com>
451
452         Add support to dashboard for displaying Git SHA's as revisions.
453         https://bugs.webkit.org/show_bug.cgi?id=148387
454
455         Reviewed by Daniel Bates.
456
457         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
458         (parseRevisionProperty): Added support to dashboard for displaying Git SHA's as revisions.
459         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
460         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
461         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Added
462         "isSVN" property to Dashboard.Repository.(OpenSource|Internal).
463
464 2015-08-24  Andy Estes  <aestes@apple.com>
465
466         REGRESSION (r188851): WebKit2.BundleParameters fails on iOS
467
468         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Specify LD_RUNPATH_SEARCH_PATHS correctly for iOS.
469
470 2015-08-23  Andy Estes  <aestes@apple.com>
471
472         Addressed a missed piece of review feedback from r188851.
473
474         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
475
476 2015-08-23  Andy Estes  <aestes@apple.com>
477
478         [Content Filtering] REGRESSION (r182356): Provisional URL is incorrect in didReceiveServerRedirectForProvisionalLoadForFrame when Content Filtering is enabled
479         https://bugs.webkit.org/show_bug.cgi?id=147872
480         rdar://problem/22044000
481
482         Reviewed by Dan Bernstein.
483         
484         Added an API test.
485
486         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Linked libWebCoreTestSupport in order to use MockContentFilter.
487         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
488         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added.
489         (-[ServerRedirectNavigationDelegate webView:didStartProvisionalNavigation:]): Expect the initial request URL.
490         (-[ServerRedirectNavigationDelegate webView:didReceiveServerRedirectForProvisionalNavigation:]): Expect the redirect URL.
491         (-[ServerRedirectNavigationDelegate webView:didCommitNavigation:]):
492         (TEST): Tested that -[WKWebView URL] is updated after a redirect when content filtering is enabled.
493         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added.
494         (+[ServerRedirectPlugIn initialize]): Enable MockContentFilter.
495         * TestWebKitAPI/cocoa/TestProtocol.h: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.h.
496         * TestWebKitAPI/cocoa/TestProtocol.mm: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.mm.
497
498 2015-08-23  Andy Estes  <aestes@apple.com>
499
500         Fixed the 32-bit Mac build after r188844.
501
502         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
503         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
504
505 2015-08-22  Andy Estes  <aestes@apple.com>
506
507         [Cocoa] API tests using the Modern WebKit API should be able to create web process plug-ins
508         https://bugs.webkit.org/show_bug.cgi?id=148317
509
510         Reviewed by Dan Bernstein.
511
512         Added the ability for Modern WebKit API tests to create WKWebProcessPlugIns. A test can create a plug-in by
513         creating a class that conforms to WKWebProcessPlugIn, adding it to the WebProcessPlugIn target, and using the
514         WKWebViewConfiguration returned by +[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]
515         when creating WKWebViews.
516
517         Since TestWebKitAPI relies on a bundle parameter to know which test class to instantiate in the plug-in, I also
518         added a new API test for bundle parameters.
519
520         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Added. Named the bundle TestWebKitAPI.wkbundle and
521         named its executable TestWebKitAPI.bundle.
522         * TestWebKitAPI/PlatformUtilities.h: Declared TestPlugInClassNameParameter.
523         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added the WebProcessPlugIn target.
524         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm: Added.
525         (TEST): Tested bundle parameters by verifying that parameter changes in the UI process are observed in the bundle.
526         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm: Added.
527         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]): Started observing changes to a
528         bundle parameter and asked for an initial notification.
529         (-[BundleParametersPlugIn dealloc]): Stopped observing changes to a bundle parameter.
530         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): When a bundle parameter changes,
531         mirror its value in the main frame's JSContext.
532         * TestWebKitAPI/WKWebViewConfigurationExtras.h: Added.
533         * TestWebKitAPI/WKWebViewConfigurationExtras.mm: Added.
534         (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Created a configuration with
535         TestWebKitAPI's bundle URL and set a bundle parameter indicating the test plug-in's class name.
536         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Defined TestPlugInClassNameParameter.
537         * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added. Set the principal class to WebProcessPlugIn.
538         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm: Added.
539         (-[WebProcessPlugIn webProcessPlugIn:initializeWithObject:]): Forwarded to a newly-created test class instance.
540         (-[WebProcessPlugIn respondsToSelector:]): Returned YES if the test class instance response.
541         (-[WebProcessPlugIn forwardingTargetForSelector:]): Forwarded unimplemented methods to the test class instance.
542
543 2015-08-23  Csaba Osztrogonác  <ossy@webkit.org>
544
545         URTBF after r188828.
546
547         * WebKitTestRunner/PlatformWebView.h:
548
549 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
550
551         build.webkit.org/dashboard: Combined queues don't turn orange on internal failure
552         https://bugs.webkit.org/show_bug.cgi?id=148356
553
554         Reviewed by Darin Adler.
555
556         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
557         (BuildbotCombinedQueueView.prototype.update):
558
559 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
560
561         build.webkit.org/dashboard: Respect step's hidden flag
562         https://bugs.webkit.org/show_bug.cgi?id=148357
563
564         Reviewed by Darin Adler.
565
566         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
567         (BuildbotIteration.prototype._parseData):
568
569 2015-08-23  Nan Wang  <n_wang@apple.com>
570
571         AX: Fix accessibility/deleting-iframe-destroys-axcache.html test
572         https://bugs.webkit.org/show_bug.cgi?id=148328
573
574         Reviewed by Darin Adler.
575
576         We should only expose stringValue() when value attribute is set.
577
578         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
579         (AccessibilityUIElement::stringValue):
580         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
581         (WTR::AccessibilityUIElement::stringValue):
582
583 2015-08-23  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
584
585         Remove style checking rule regarding OwnPtr and PassOwnPtr
586         https://bugs.webkit.org/show_bug.cgi?id=148360
587
588         Reviewed by Darin Adler.
589
590         OwnPtr and PassOwnPtr were totally removed though, style rule is still alive.
591         Removed it.
592
593         * Scripts/do-webcore-rename:
594         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
595         (PassPtrTest.test_pass_own_ptr_in_function): Deleted.
596         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
597         (PassPtrTest.test_own_ptr_parameter_value): Deleted.
598         (WebKitStyleTest.test_names): Deleted.
599
600 2015-08-22  Timothy Horton  <timothy_horton@apple.com>
601
602         WebKitTestRunner should use WKWebView on OS X and iOS
603         https://bugs.webkit.org/show_bug.cgi?id=143743
604         <rdar://problem/16947123>
605
606         Reviewed by Anders Carlsson.
607         Patch by Enrica Casucci and myself.
608
609         * WebKitTestRunner/PlatformWebView.h:
610         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
611         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
612         instead of WKContext and WKPageGroup.
613
614         Remove the unused, always-true windowSnapshotEnabled().
615         While technically some platforms don't have window snapshotting,
616         they just return null instead of implementing windowSnapshotEnabled().
617
618         * WebKitTestRunner/TestController.h:
619         * WebKitTestRunner/TestController.cpp:
620         (WTR::TestController::createOtherPage):
621         (WTR::TestController::initialize):
622         (WTR::TestController::createWebViewWithOptions):
623         Delegate to the various platforms for creating PlatformWebView instances,
624         for creating WKContexts, and for accessing WKPreferences,
625         so that they can do special things (like, use WKWebView instead!).
626
627         (WTR::TestController::resetPreferencesToConsistentValues):
628         Make explicit WebKitTestRunner's desired default for two preferences
629         which have differing defaults between the antique and modern API,
630         for consistency's sake.
631
632         (WTR::TestController::resetStateToConsistentValues):
633         Add platformResetStateToConsistentValues.
634
635         * WebKitTestRunner/TestInvocation.cpp:
636         (WTR::TestInvocation::dumpResults):
637         Adjust to the aforementioned removal of windowSnapshotEnabled().
638
639         * WebKitTestRunner/ios/TestControllerCocoa.mm:
640         (WTR::TestController::platformResetStateToConsistentValues):
641         (WTR::TestController::platformPreferences):
642         (WTR::TestController::platformCreateWebView):
643         (WTR::TestController::platformCreateOtherPage):
644         (WTR::TestController::platformInitializeConfiguration):
645         Implement the new platform functions for the Modern WebKit2 API,
646         in a new TestControllerCocoa file that is shared between iOS and Mac.
647         
648         For platformMaybeCreateContext, use the trick that we know we can cast
649         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
650         WKWebView's configuration.
651
652         Ditto for WKPreferencesRef and WKPreferences.
653
654         Remove user content filters on the WKWebView's userContentController.
655
656         * WebKitTestRunner/mac/TestControllerMac.mm:
657         * WebKitTestRunner/ios/TestControllerIOS.mm:
658         Move code into TestControllerCocoa.
659
660         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
661         (WTR::InjectedBundle::beginTesting):
662         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
663         (WTR::TestRunner::addUserScript):
664         (WTR::TestRunner::addUserStyleSheet):
665         Adopt WKBundlePage API for user scripts/sheets.
666
667         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
668         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
669         Make and keep a WKWebView instead of a WKView.
670         
671         * WebKitTestRunner/mac/EventSenderProxy.mm:
672         (WTR::EventSenderProxy::mouseUp):
673         (WTR::EventSenderProxy::mouseMoveTo):
674         Reach inside the WKWebView to the WKView when dispatching events.
675         This is fairly ugly and we should come up with a better solution.
676         Also, fix some flipping and style errors.
677
678 2015-08-22  Michael Catanzaro  <mcatanzaro@igalia.com>
679
680         Unreviewed, attempt to fix GTK build after r188718
681
682         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
683         (WTR::PlatformWebView::PlatformWebView):
684
685 2015-08-21  Commit Queue  <commit-queue@webkit.org>
686
687         Unreviewed, rolling out r188807, r188813, and r188815.
688         https://bugs.webkit.org/show_bug.cgi?id=148349
689
690         lots of 32-bit build problems, better to resolve separately
691         and try again (Requested by thorton on #webkit).
692
693         Reverted changesets:
694
695         "WebKitTestRunner should use WKWebView on OS X and iOS"
696         https://bugs.webkit.org/show_bug.cgi?id=143743
697         http://trac.webkit.org/changeset/188807
698
699         "Stop building WebKitTestRunner for 32-bit platforms"
700         https://bugs.webkit.org/show_bug.cgi?id=143743
701         http://trac.webkit.org/changeset/188813
702
703         "Stop building WebKitTestRunner for 32-bit platforms"
704         https://bugs.webkit.org/show_bug.cgi?id=143743
705         http://trac.webkit.org/changeset/188815
706
707 2015-08-21  Tim Horton  <timothy_horton@apple.com>
708
709         Stop building WebKitTestRunner for 32-bit platforms
710         https://bugs.webkit.org/show_bug.cgi?id=143743
711         <rdar://problem/16947123>
712
713         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
714         This is a restriction on the valid set, not the desired set.
715
716 2015-08-21  Jason Marcell  <jmarcell@apple.com>
717
718         Make Dashboard.Branches be objects of the form (repository, "branch name") and update existing code
719         to work with these new objects.
720         https://bugs.webkit.org/show_bug.cgi?id=148188
721
722         Reviewed by Daniel Bates.
723
724         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
725         (Buildbot.prototype._normalizeQueueInfo): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
726         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
727         (BuildbotCombinedQueueView): Changed to work with new branch objects which represent a
728         (repository, "branch name")-pair.
729         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Ditto.
730         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
731         (BuildbotQueue): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
732         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
733         (BuildbotQueueView.prototype._appendPendingRevisionCount): Changed to work with new branch
734         objects which represent a (repository, "branch name")-pair.
735         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
736         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
737         (BuildbotQueueView.prototype._addDividerToPopover): Ditto.
738         (BuildbotQueueView.prototype.revisionContentForIteration): Ditto.
739         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Renamed
740         BuildbotQueue.branch to BuildbotQueue.branches.
741         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
742         (WebKitBuildbot.prototype.get defaultBranches): Changed to new (repository, "branch name") format.
743
744 2015-08-21  Tim Horton  <timothy_horton@apple.com>
745
746         Stop building WebKitTestRunner for 32-bit platforms
747         https://bugs.webkit.org/show_bug.cgi?id=143743
748         <rdar://problem/16947123>
749
750         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
751         WKWebView is not available on 32-bit OS X.
752
753 2015-08-21  Brent Fulgham  <bfulgham@apple.com>
754
755         [Win] Unreviewed test correction after r188709.
756
757         I removed a function argument that happened to be mirrored by a global
758         value with the same name. This prevented a compile error, but testing
759         showed that the wrong value was being used in the function.
760
761         * DumpRenderTree/win/FrameLoadDelegate.cpp:
762         (FrameLoadDelegate::willPerformClientRedirectToURL): Put function argument
763         back
764
765 2015-08-21  Timothy Horton  <timothy_horton@apple.com>
766
767         WebKitTestRunner should use WKWebView on OS X and iOS
768         https://bugs.webkit.org/show_bug.cgi?id=143743
769         <rdar://problem/16947123>
770
771         Reviewed by Anders Carlsson.
772         Patch by Enrica Casucci and myself.
773
774         * WebKitTestRunner/PlatformWebView.h:
775         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
776         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
777         instead of WKContext and WKPageGroup.
778
779         Remove the unused, always-true windowSnapshotEnabled().
780         While technically some platforms don't have window snapshotting,
781         they just return null instead of implementing windowSnapshotEnabled().
782
783         * WebKitTestRunner/TestController.h:
784         * WebKitTestRunner/TestController.cpp:
785         (WTR::TestController::createOtherPage):
786         (WTR::TestController::initialize):
787         (WTR::TestController::createWebViewWithOptions):
788         Delegate to the various platforms for creating PlatformWebView instances,
789         for creating WKContexts, and for accessing WKPreferences,
790         so that they can do special things (like, use WKWebView instead!).
791
792         (WTR::TestController::resetPreferencesToConsistentValues):
793         Make explicit WebKitTestRunner's desired default for two preferences
794         which have differing defaults between the antique and modern API,
795         for consistency's sake.
796
797         (WTR::TestController::resetStateToConsistentValues):
798         Add platformResetStateToConsistentValues.
799
800         * WebKitTestRunner/TestInvocation.cpp:
801         (WTR::TestInvocation::dumpResults):
802         Adjust to the aforementioned removal of windowSnapshotEnabled().
803
804         * WebKitTestRunner/ios/TestControllerCocoa.mm:
805         (WTR::TestController::platformResetStateToConsistentValues):
806         (WTR::TestController::platformPreferences):
807         (WTR::TestController::platformCreateWebView):
808         (WTR::TestController::platformCreateOtherPage):
809         (WTR::TestController::platformInitializeConfiguration):
810         Implement the new platform functions for the Modern WebKit2 API,
811         in a new TestControllerCocoa file that is shared between iOS and Mac.
812         
813         For platformMaybeCreateContext, use the trick that we know we can cast
814         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
815         WKWebView's configuration.
816
817         Ditto for WKPreferencesRef and WKPreferences.
818
819         Remove user content filters on the WKWebView's userContentController.
820
821         * WebKitTestRunner/mac/TestControllerMac.mm:
822         * WebKitTestRunner/ios/TestControllerIOS.mm:
823         Move code into TestControllerCocoa.
824
825         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
826         (WTR::InjectedBundle::beginTesting):
827         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
828         (WTR::TestRunner::addUserScript):
829         (WTR::TestRunner::addUserStyleSheet):
830         Adopt WKBundlePage API for user scripts/sheets.
831
832         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
833         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
834         Make and keep a WKWebView instead of a WKView.
835         
836         * WebKitTestRunner/mac/EventSenderProxy.mm:
837         (WTR::EventSenderProxy::mouseUp):
838         (WTR::EventSenderProxy::mouseMoveTo):
839         Reach inside the WKWebView to the WKView when dispatching events.
840         This is fairly ugly and we should come up with a better solution.
841         Also, fix some flipping and style errors.
842
843 2015-08-21  Alexey Proskuryakov  <ap@apple.com>
844
845         Improve how UI events are dispatched by WebKitTestRunner
846         https://bugs.webkit.org/show_bug.cgi?id=148326
847
848         Reviewed by Anders Carlsson.
849
850         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
851         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
852         Removed asyncScrolling from mouseScrollByWithWheelAndMomentumPhases, it's now always
853         asynchronous (and really, it has always been for the most part).
854
855         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
856         (WTR::EventSendingController::mouseDown): Updated for WKBundlePagePostSynchronousMessage renaming.
857         (WTR::EventSendingController::mouseUp): Ditto.
858         (WTR::EventSendingController::mouseMoveTo): Ditto.
859         (WTR::EventSendingController::mouseForceDown): Ditto.
860         (WTR::EventSendingController::mouseForceUp): Ditto.
861         (WTR::EventSendingController::mouseForceChanged): Ditto.
862         (WTR::EventSendingController::leapForward): Ditto.
863         (WTR::EventSendingController::scheduleAsynchronousClick): Ditto.
864         (WTR::EventSendingController::keyDown): Ditto.
865         (WTR::EventSendingController::scheduleAsynchronousKeyDown): Ditto.
866         (WTR::EventSendingController::mouseScrollBy): Force a scrolling tree commit. It used
867         to be done in custom WebKit2 code for test wheel event handling.
868         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases): Got rid of sync version.
869         (WTR::EventSendingController::continuousMouseScrollBy): Added a FIXME. This one is weird.
870         (WTR::EventSendingController::contextClick): Updated for WKBundlePagePostSynchronousMessage renaming.
871         (WTR::EventSendingController::addTouchPoint): Ditto.
872         (WTR::EventSendingController::updateTouchPoint): Ditto.
873         (WTR::EventSendingController::setTouchModifier): Ditto.
874         (WTR::EventSendingController::setTouchPointRadius): Ditto.
875         (WTR::EventSendingController::touchStart): Ditto.
876         (WTR::EventSendingController::touchMove): Ditto.
877         (WTR::EventSendingController::touchEnd): Ditto.
878         (WTR::EventSendingController::touchCancel): Ditto.
879         (WTR::EventSendingController::clearTouchPoints): Ditto.
880         (WTR::EventSendingController::releaseTouchPoint): Ditto.
881         (WTR::EventSendingController::cancelTouchPoint): Ditto.
882
883         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
884         (WTR::InjectedBundle::postSetWindowIsKey):
885         (WTR::InjectedBundle::postSimulateWebNotificationClick):
886         (WTR::InjectedBundle::isGeolocationProviderActive):
887         (WTR::InjectedBundle::shouldProcessWorkQueue):
888         Updated for WKBundlePagePostSynchronousMessage renaming.
889
890         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
891         (WTR::TestRunner::secureEventInputIsEnabled): Ditto.
892
893         * WebKitTestRunner/TestController.cpp:
894         (WTR::TestController::initialize): Allow handling the new test style messages.
895         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle): Removed calls
896         to WKPageSetShouldSendEventsSynchronously, which we no longer need.
897         (WTR::TestController::didReceiveMessageFromInjectedBundle):
898         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Moved
899         "MouseScrollBy" to async section, and got rid of WKPageSetShouldSendEventsSynchronously.
900
901         * WebKitTestRunner/mac/EventSenderProxy.mm:
902         (WTR::EventSenderProxy::mouseMoveTo): Got rid of WKPageSetShouldSendEventsSynchronously.
903         (WTR::EventSenderProxy::keyDown): Ditto.
904         (WTR::EventSenderProxy::mouseScrollBy): Ditto.
905         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
906
907 2015-08-21  Yusuke Suzuki  <utatane.tea@gmail.com>
908
909         Skip no-llint tests that fail due to running out of executable memory after r188969
910         https://bugs.webkit.org/show_bug.cgi?id=148273
911
912         Reviewed by Michael Saboff.
913
914         * Scripts/run-jsc-stress-tests:
915
916 2015-08-21  Nan Wang  <n_wang@apple.com>
917
918         [Mac] accessibility/selection-states.html fails
919         https://bugs.webkit.org/show_bug.cgi?id=116637
920
921         Reviewed by Chris Fleizach.
922
923         Implemented isSelectable() and isMultiSelectable().
924
925         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
926         (AccessibilityUIElement::isSelectable):
927         (AccessibilityUIElement::isMultiSelectable):
928         (AccessibilityUIElement::isSelectedOptionActive):
929         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
930         (WTR::AccessibilityUIElement::isSelectable):
931         (WTR::AccessibilityUIElement::isMultiSelectable):
932         (WTR::AccessibilityUIElement::isVisible):
933
934 2015-08-21  Jason Marcell  <jmarcell@apple.com>
935
936         Fix iteration over repositories on bot watcher's dashboard.
937
938         Reviewed by Alexey Proskuryakov.
939
940         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
941         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Don't reuse the same index variable.
942
943 2015-08-20  Joonghun Park  <jh718.park@samsung.com>
944
945         [EFL] Revise PlatformWebView ctor according to r188718
946         https://bugs.webkit.org/show_bug.cgi?id=148282
947
948         This patch change PlatformWebView ctor's argument to use WKPageConfigurationRef
949         instead of WKContextRef and WKPageGroupRef respectively.
950
951         Reviewed by Gyuyoung Kim.
952
953         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
954         (WTR::PlatformWebView::PlatformWebView):
955
956 2015-08-20  Devin Rousso  <dcrousso+webkit@gmail.com>
957
958         Unreviewed, changed Devin Rousso's email.
959
960         * Scripts/webkitpy/common/config/contributors.json:
961
962 2015-08-20  Anders Carlsson  <andersca@apple.com>
963
964         Use WKPageConfigurationRef in WebKitTestRunner
965         https://bugs.webkit.org/show_bug.cgi?id=147996
966
967         Reviewed by Tim Horton.
968
969         * WebKitTestRunner/TestController.cpp:
970         (WTR::TestController::createOtherPage):
971         (WTR::TestController::initialize):
972         (WTR::TestController::createWebViewWithOptions):
973         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
974         (-[TestRunnerWKView initWithFrame:configurationRef:useThreadedScrolling:]):
975         (WTR::PlatformWebView::PlatformWebView):
976         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useThreadedScrolling:]): Deleted.
977
978 2015-08-20  Brent Fulgham  <bfulgham@apple.com>
979
980         [Win] Update Windows tools for revised MIDL interfaces
981         https://bugs.webkit.org/show_bug.cgi?id=148249
982
983         Reviewed by Dean Jackson.
984
985         This is a follow-up to Bug 148001.
986
987         Revise the testing software to use compatible signatures and
988         implementations to match the requirements of the IDL generated
989         with the SAL annotations.
990
991         * DumpRenderTree/win/DRTDataObject.cpp:
992         * DumpRenderTree/win/DRTDataObject.h:
993         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
994         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
995         * DumpRenderTree/win/DRTDropSource.cpp:
996         * DumpRenderTree/win/DRTDropSource.h:
997         * DumpRenderTree/win/DumpRenderTree.cpp:
998         * DumpRenderTree/win/EditingDelegate.cpp:
999         * DumpRenderTree/win/EditingDelegate.h:
1000         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1001         * DumpRenderTree/win/FrameLoadDelegate.h:
1002         * DumpRenderTree/win/HistoryDelegate.cpp:
1003         * DumpRenderTree/win/HistoryDelegate.h:
1004         * DumpRenderTree/win/PolicyDelegate.cpp:
1005         * DumpRenderTree/win/PolicyDelegate.h:
1006         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1007         * DumpRenderTree/win/ResourceLoadDelegate.h:
1008         * DumpRenderTree/win/TestRunnerWin.cpp:
1009         * DumpRenderTree/win/UIDelegate.cpp:
1010         * DumpRenderTree/win/UIDelegate.h:
1011         * WinLauncher/AccessibilityDelegate.cpp:
1012         * WinLauncher/AccessibilityDelegate.h:
1013         * WinLauncher/Common.cpp:
1014         * WinLauncher/DOMDefaultImpl.cpp:
1015         * WinLauncher/DOMDefaultImpl.h:
1016         * WinLauncher/PageLoadTestClient.cpp:
1017         * WinLauncher/PageLoadTestClient.h:
1018         * WinLauncher/PrintWebUIDelegate.cpp:
1019         * WinLauncher/PrintWebUIDelegate.h:
1020         * WinLauncher/ResourceLoadDelegate.cpp:
1021         * WinLauncher/ResourceLoadDelegate.h:
1022         * WinLauncher/WebDownloadDelegate.cpp:
1023         * WinLauncher/WebDownloadDelegate.h:
1024         * WinLauncher/WinLauncherWebHost.cpp:
1025         * WinLauncher/WinLauncherWebHost.h:
1026         * WinLauncher/WinMain.cpp:
1027         * win/DLLLauncher/DLLLauncherMain.cpp:
1028
1029 2015-08-20  Filip Pizlo  <fpizlo@apple.com>
1030
1031         Unreviewed, shorten a test that runs too long and times out.
1032
1033         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1034         (TestWebKitAPI::TEST):
1035
1036 2015-08-20  Alex Christensen  <achristensen@webkit.org>
1037
1038         Clean up CMake build after r188673
1039         https://bugs.webkit.org/show_bug.cgi?id=148234
1040
1041         Reviewed by Tim Horton.
1042
1043         * DumpRenderTree/PlatformWin.cmake:
1044         * TestWebKitAPI/CMakeLists.txt:
1045         * TestWebKitAPI/PlatformWin.cmake:
1046         Define WIN_CAIRO so WinCairo executables can find the correct dlls in WebKitLibraries.
1047         gtest needs to be a static library on Windows to not crash.
1048
1049 2015-08-19  Alex Christensen  <achristensen@webkit.org>
1050
1051         CMake Windows build should not include files directly from other Source directories
1052         https://bugs.webkit.org/show_bug.cgi?id=148198
1053
1054         Reviewed by Brent Fulgham.
1055
1056         * DumpRenderTree/DumpRenderTreePrefix.h:
1057         Include cmakeconfig.h to properly define all enabled features.
1058         * DumpRenderTree/PlatformWin.cmake:
1059         * TestWebKitAPI/PlatformWin.cmake:
1060
1061 2015-08-19  Alex Christensen  <achristensen@webkit.org>
1062
1063         Build TestWTF on Mac with CMake.
1064         https://bugs.webkit.org/show_bug.cgi?id=147972
1065
1066         Reviewed by Tim Horton.
1067
1068         TestWTF only depends on gtest and WTF instead of TestWebKitAPi depending on all of WebKit.
1069         Now I can run the WTF API tests after a few seconds of building instead of waiting for all of WebKit to build.
1070
1071         * TestWebKitAPI/CMakeLists.txt:
1072         Added WTF as a dependency for platforms that do not have ForwardingHeadersForTestWebKitAPI_NAME.
1073         WTF was already a library that was linked, but having at least one item makes the syntax of add_dependencies work.
1074         * TestWebKitAPI/PlatformMac.cmake: Added.
1075         * TestWebKitAPI/config.h:
1076         Postpone some build fixes until WebKit builds completely on Mac with CMake.
1077
1078 2015-08-19  Brian Burg  <bburg@apple.com>
1079
1080         Unreviewed, add Aleksandr Skachkov to the list of contributors.
1081
1082         * Scripts/webkitpy/common/config/contributors.json:
1083
1084 2015-08-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1085
1086         REGRESSION(r188548): [GTK] Build broken.
1087         https://bugs.webkit.org/show_bug.cgi?id=148154
1088
1089         Reviewed by Martin Robinson.
1090
1091         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1092         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
1093         Even if we don't need to add/override any settings in ViewOptions,
1094         we need to define this as an empty function to make it build.
1095
1096 2015-08-18  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1097
1098         Fix conversion-null warning in conversion.cpp of TestWebKitAPI
1099         https://bugs.webkit.org/show_bug.cgi?id=148073
1100
1101         Reviewed by Alexey Proskuryakov.
1102
1103         * TestWebKitAPI/Tests/WTF/Condition.cpp: Use EXPECT_FALSE instead of EXPECT_EQ.
1104         (TestWebKitAPI::TEST):
1105
1106 2015-08-18  Anders Carlsson  <andersca@apple.com>
1107
1108         Fix test failure fallout from r188602 by using a V5 page ui client struct.
1109
1110         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
1111         (TestWebKitAPI::setUpClients):
1112
1113 2015-08-18  Brian Burg  <bburg@apple.com>
1114
1115         Web Inspector: load ProtocolTestStub from the WebInspectorUI bundle
1116         https://bugs.webkit.org/show_bug.cgi?id=147955
1117
1118         Reviewed by Timothy Hatcher.
1119
1120         To enable sharing of common test code between protocol and model tests,
1121         start loading the protocol TestStub.js through the WebInspectorUI bundle.
1122
1123         This patch adds the read-only getter TestRunner.inspectorTestStubURL, which
1124         protocol-test.js uses to load the inspector frontend stub into its iframe
1125         from an arbitrary local file URL.
1126
1127         * DumpRenderTree/TestRunner.cpp:
1128         (getInspectorTestStubURLCallback):
1129         (TestRunner::staticValues):
1130         * DumpRenderTree/TestRunner.h:
1131         * DumpRenderTree/mac/TestRunnerMac.mm:
1132         (SOFT_LINK_STAGED_FRAMEWORK):
1133         (TestRunner::inspectorTestStubURL):
1134         * DumpRenderTree/win/TestRunnerWin.cpp:
1135         (TestRunner::inspectorTestStubURL):
1136         * WebKitTestRunner/Configurations/Base.xcconfig:
1137         Since WebKitTestRunner now includes WebCore private headers, also search
1138         for the WebCore framework inside the WebKit umbrella framework.
1139
1140         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1141         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1142         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
1143         (WTR::TestRunner::inspectorTestStubURL):
1144         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1145         (WTR::TestRunner::inspectorTestStubURL):
1146         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1147         (WTR::TestRunner::inspectorTestStubURL):
1148
1149 2015-08-18  Filip Pizlo  <fpizlo@apple.com>
1150
1151         Unreviewed, fix GTK build.
1152
1153         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
1154         (TestWebKitAPI::TEST):
1155
1156 2015-08-17  Filip Pizlo  <fpizlo@apple.com>
1157
1158         Replace all remaining uses of WTF::Mutex with WTF::Lock
1159         https://bugs.webkit.org/show_bug.cgi?id=148089
1160
1161         Reviewed by Geoffrey Garen.
1162
1163         * DumpRenderTree/JavaScriptThreading.cpp:
1164         (javaScriptThreadsMutex):
1165         (runJavaScriptThread):
1166         (startJavaScriptThreads):
1167         (stopJavaScriptThreads):
1168         * TestWebKitAPI/Tests/WTF/Condition.cpp: Fixed a bug in the test that I found from turning the test into a benchmark.
1169         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1170         (TestWebKitAPI::TEST):
1171         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
1172         (TestWebKitAPI::TEST):
1173
1174 2015-08-17  Commit Queue  <commit-queue@webkit.org>
1175
1176         Unreviewed, rolling out r188539, r188544, r188552, and
1177         r188564.
1178         https://bugs.webkit.org/show_bug.cgi?id=148122
1179
1180         Broke tests and some build styles (Requested by ap on
1181         #webkit).
1182
1183         Reverted changesets:
1184
1185         "Web Inspector: load ProtocolTestStub from the WebInspectorUI
1186         bundle"
1187         https://bugs.webkit.org/show_bug.cgi?id=147955
1188         http://trac.webkit.org/changeset/188539
1189
1190         "Web Inspector: split TestStub.js into multiple files and
1191         modernize it"
1192         https://bugs.webkit.org/show_bug.cgi?id=148077
1193         http://trac.webkit.org/changeset/188544
1194
1195         "Web Inspector: InspectorTest should be a subclass of
1196         TestHarness"
1197         https://bugs.webkit.org/show_bug.cgi?id=148079
1198         http://trac.webkit.org/changeset/188552
1199
1200         "Unreviewed internal build fix attempt after r188539."
1201         http://trac.webkit.org/changeset/188564
1202
1203 2015-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
1204
1205         [OS X] Remove support for composite fonts
1206         https://bugs.webkit.org/show_bug.cgi?id=147920
1207
1208         Reviewed by Dan Bernstein.
1209
1210         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1211         * DumpRenderTree/fonts/SampleFont.sfont: Removed.
1212         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1213         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1214         * DumpRenderTree/mac/DumpRenderTree.mm:
1215         (allowedFontFamilySet): Deleted.
1216         (activateTestingFonts): Deleted.
1217         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1218         (WTR::allowedFontFamilySet): Deleted.
1219         (WTR::activateFonts): Deleted.
1220         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1221         * WebKitTestRunner/fonts/SampleFont.sfont: Removed.
1222         * WebKitTestRunner/mac/TestControllerMac.mm:
1223         (WTR::allowedFontFamilySet): Deleted.
1224
1225 2015-08-17  Jon Honeycutt  <jhoneycutt@apple.com>
1226
1227         Unreviewed internal build fix attempt after r188539.
1228
1229         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1230
1231 2015-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
1232
1233         Fix the build
1234
1235         Unreviewed.
1236
1237         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
1238
1239 2015-08-17  Alex Christensen  <achristensen@webkit.org>
1240
1241         Build Debug Suffix on Windows with CMake
1242         https://bugs.webkit.org/show_bug.cgi?id=148083
1243
1244         Reviewed by Brent Fulgham.
1245
1246         * TestWebKitAPI/CMakeLists.txt:
1247         * TestWebKitAPI/PlatformWin.cmake:
1248         Add DEBUG_SUFFIX
1249
1250 2015-08-17  Anders Carlsson  <andersca@apple.com>
1251
1252         Simplify how PlatformWebViews are created when view options change
1253         https://bugs.webkit.org/show_bug.cgi?id=148093
1254
1255         Reviewed by Sam Weinig.
1256
1257         Instead of letting each port dictate when the PlatformWebView should be recreated we now do the following:
1258
1259         TestController::ensureViewSupportsOptionsForTest gets the view options for a test by calling
1260         TestController::viewOptionsForTest, which returns a filled in ViewOptions struct for a given test. It also allows
1261         ports to add/override settings by calling TestController::updatePlatformSpecificViewOptionsForTest.
1262
1263         If the current PlatformWebView doesn't support the given view options, delete the web view and create a new one.
1264
1265         Also, get rid of the first call to TestController::createWebViewWithOptions in TestController::initialize and
1266         always rely on TestController::ensureViewSupportsOptionsForTest creating a PlatformWebView for us.
1267
1268         * WebKitTestRunner/TestController.cpp:
1269         (WTR::TestController::ensureViewSupportsOptionsForTest):
1270         (WTR::shouldUseFixedLayout):
1271         (WTR::TestController::viewOptionsForTest):
1272         (WTR::TestController::updateWebViewSizeForTest):
1273         (WTR::TestController::updateWindowScaleForTest):
1274         (WTR::TestController::configureViewForTest):
1275         (WTR::TestController::initialize): Deleted.
1276         (WTR::TestController::ensureViewSupportsOptions): Deleted.
1277         (WTR::TestController::updateLayoutTypeForTest): Deleted.
1278         (WTR::TestController::platformConfigureViewForTest): Deleted.
1279         (WTR::TestController::platformResetPreferencesToConsistentValues): Deleted.
1280         (WTR::TestController::run): Deleted.
1281         * WebKitTestRunner/TestController.h:
1282         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1283         (WTR::shouldUseFixedLayout):
1284         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
1285         (WTR::TestController::platformConfigureViewForTest):
1286         (WTR::TestController::platformResetPreferencesToConsistentValues):
1287         * WebKitTestRunner/ios/TestControllerIOS.mm:
1288         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
1289         * WebKitTestRunner/mac/TestControllerMac.mm:
1290         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
1291         (WTR::TestController::platformConfigureViewForTest):
1292
1293 2015-08-17  Sam Weinig  <sam@webkit.org>
1294
1295         API::PageConfiguration's sessionID needs to be set whenever the API::WebsiteDataStore is set
1296         https://bugs.webkit.org/show_bug.cgi?id=148097
1297
1298         Reviewed by Anders Carlsson.
1299
1300         * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp:
1301         Add tests for WebsiteDataStores in the WKPageConfiguration.
1302
1303 2015-08-17  Brian Burg  <bburg@apple.com>
1304
1305         Web Inspector: load ProtocolTestStub from the WebInspectorUI bundle
1306         https://bugs.webkit.org/show_bug.cgi?id=147955
1307
1308         Reviewed by Timothy Hatcher.
1309
1310         To enable sharing of common test code between protocol and model tests,
1311         start loading the protocol TestStub.js through the WebInspectorUI bundle.
1312
1313         This patch adds the read-only getter TestRunner.inspectorTestStubURL, which
1314         protocol-test.js uses to load the inspector frontend stub into its iframe
1315         from an arbitrary local file URL.
1316
1317         * DumpRenderTree/TestRunner.cpp:
1318         (getInspectorTestStubURLCallback):
1319         (TestRunner::staticValues):
1320         * DumpRenderTree/TestRunner.h:
1321         * DumpRenderTree/mac/TestRunnerMac.mm:
1322         (SOFT_LINK_STAGED_FRAMEWORK):
1323         (TestRunner::inspectorTestStubURL):
1324         * DumpRenderTree/win/TestRunnerWin.cpp:
1325         (TestRunner::inspectorTestStubURL):
1326         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1327         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1328         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
1329         (WTR::TestRunner::inspectorTestStubURL):
1330         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1331         (WTR::TestRunner::inspectorTestStubURL):
1332         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1333         (WTR::TestRunner::inspectorTestStubURL):
1334
1335 2015-08-17  Saam barati  <sbarati@apple.com>
1336
1337         Change email address from saambarati1@gmail.com to sbarati@apple.com
1338
1339         * Scripts/webkitpy/common/config/contributors.json:
1340
1341 2015-08-17  Jason Marcell  <jmarcell@apple.com>
1342
1343         Refactor BuildbotQueueView._presentPopoverForPendingCommits to work more generically with
1344         repositories other than "openSource" and "internal".
1345         https://bugs.webkit.org/show_bug.cgi?id=147961
1346
1347         Reviewed by Daniel Bates.
1348
1349         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1350         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Refactored to work more
1351         generically with repositories other than "openSource" and "internal".
1352
1353 2015-08-17  Alexey Proskuryakov  <ap@apple.com>
1354
1355         build.webkit.org/dashboard shows yellow when crash-only queues have too many failures
1356         https://bugs.webkit.org/show_bug.cgi?id=148081
1357
1358         Reviewed by Tim Horton.
1359
1360         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1361         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1362
1363 2015-08-11  Andy Estes  <aestes@apple.com>
1364
1365         [Cocoa] Add redirect support to CustomProtocolManager
1366         https://bugs.webkit.org/show_bug.cgi?id=147871
1367
1368         Reviewed by Dan Bernstein.
1369
1370         Updated WebKit2CustomProtocolsTest.MainResource to generate a redirect response.
1371
1372         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1373         (TestWebKitAPI::TEST): Unregesitered TestProtocol.
1374         * TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Changed scheme to http.
1375         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1376         (-[CustomProtocolsLoadDelegate browsingContextControllerDidStartProvisionalLoad:]): Expected a certain provisional URL.
1377         (-[CustomProtocolsLoadDelegate browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]): Ditto.
1378         (-[CustomProtocolsLoadDelegate browsingContextControllerDidCommitLoad:]): Expected a certain committed URL.
1379         (-[CustomProtocolsLoadDelegate browsingContextControllerDidFinishLoad:]): Expected isLoading to be false.
1380         (TestWebKitAPI::TEST): Used the new load delegate and unregistered TestProtocol.
1381         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1382         (TestWebKitAPI::TEST): Unregistered TestProtocol.
1383         * TestWebKitAPI/mac/TestProtocol.mm: Changed scheme to http.
1384         (+[TestProtocol canInitWithRequest:]): Changed to use property syntax.
1385         (-[TestProtocol startLoading]): Taught to handle redirect responses.
1386
1387 2015-08-13  Andy Estes  <aestes@apple.com>
1388
1389         [Cocoa] Downloads do not start if policy decision is made asynchronously
1390         https://bugs.webkit.org/show_bug.cgi?id=147985
1391
1392         Reviewed by Brady Eidson.
1393
1394         Added a new API test.
1395
1396         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1397         (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1398         (-[AsynchronousDownloadDelegate _downloadDidStart:]):
1399         (TEST):
1400
1401 2015-08-14  Commit Queue  <commit-queue@webkit.org>
1402
1403         Unreviewed, rolling out r187357.
1404         https://bugs.webkit.org/show_bug.cgi?id=148032
1405
1406         webkit-patch generates incorrect patches that cannot be
1407         applied (Requested by dydz on #webkit).
1408
1409         Reverted changeset:
1410
1411         "Call fixChangeLogPatch when generating patches from webkit-
1412         patch"
1413         https://bugs.webkit.org/show_bug.cgi?id=147248
1414         http://trac.webkit.org/changeset/187357
1415
1416 2015-08-14  Jason Marcell  <jmarcell@apple.com>
1417
1418         Refactor BuildbotQueueView._appendPendingRevisionCount to work more generically with repositories
1419         other than "openSource" and "internal".
1420         https://bugs.webkit.org/show_bug.cgi?id=147938
1421
1422         Reviewed by Daniel Bates.
1423
1424         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1425         (BuildbotQueueView.prototype._appendPendingRevisionCount): Refactored to work more generically with
1426         repositories other than "openSource" and "internal".
1427
1428 2015-08-14  Filip Pizlo  <fpizlo@apple.com>
1429
1430         Unreviewed, shorten another test that is timing out.
1431
1432         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1433         (TestWebKitAPI::TEST):
1434
1435 2015-08-13  Aakash Jain  <aakash_jain@apple.com>
1436
1437         AppScale: Assertion hit when hovering a webkit-queue bubble
1438         https://bugs.webkit.org/show_bug.cgi?id=147997
1439
1440         Reviewed by Alexey Proskuryakov.
1441
1442         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
1443         (BubbleQueue.prototype.loadDetailedStatus): Strip off http(s) before asserting.
1444
1445 2015-08-13  Lucas Forschler  <lforschler@apple.com>
1446
1447         Teach Scripts/copy-webkitlibraries-to-product-directory to copy the El Capitan Library.
1448         
1449         Unreviewed.
1450         
1451         * Scripts/copy-webkitlibraries-to-product-directory:
1452
1453 2015-08-13  Dewei Zhu  <dewei_zhu@apple.com>
1454
1455         Run benchmark customized Dromaeo should not assume there is an internet connection.
1456         https://bugs.webkit.org/show_bug.cgi?id=147995
1457
1458         Reviewed by Ryosuke Niwa.
1459
1460         Add several dependency js libs to local.
1461
1462         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch:
1463
1464 2015-08-13  Filip Pizlo  <fpizlo@apple.com>
1465
1466         WTF should have a compact Condition object to use with Lock
1467         https://bugs.webkit.org/show_bug.cgi?id=147986
1468
1469         Reviewed by Geoffrey Garen.
1470
1471         Add a test for WTF::Condition.
1472
1473         * TestWebKitAPI/CMakeLists.txt:
1474         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1475         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1476         * TestWebKitAPI/Tests/WTF/Condition.cpp: Added.
1477         (TestWebKitAPI::TEST):
1478         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1479         (TestWebKitAPI::runLockTest): Change the name of the thread.
1480
1481 2015-08-13  Filip Pizlo  <fpizlo@apple.com>
1482
1483         Unreviewed, shorten another test. It's timing out in debug on some bot.
1484
1485         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1486         (TestWebKitAPI::TEST):
1487
1488 2015-08-12  Filip Pizlo  <fpizlo@apple.com>
1489
1490         WTF::Lock should not suffer from the thundering herd
1491         https://bugs.webkit.org/show_bug.cgi?id=147947
1492
1493         Reviewed by Geoffrey Garen.
1494
1495         Add testing that checks that locks return to a pristine state after contention is over.
1496
1497         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1498         (TestWebKitAPI::LockInspector::isFullyReset):
1499         (TestWebKitAPI::runLockTest):
1500         (TestWebKitAPI::TEST):
1501
1502 2015-08-12  Dewei Zhu  <dewei_zhu@apple.com>
1503
1504         Benchmarks supported by run_benchmark script should not assume we have internet access.
1505         https://bugs.webkit.org/show_bug.cgi?id=147959
1506
1507         Reviewed by Ryosuke Niwa.
1508
1509         For JSBench we should not request jquery.min.js from google through the internet.
1510
1511         * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch:
1512
1513 2015-08-12  Jason Marcell  <jmarcell@apple.com>
1514
1515         Refactor BuildbotQueueView.revisionContentForIteration to work more generically with repositories
1516         other than "openSource" and "internal".
1517         https://bugs.webkit.org/show_bug.cgi?id=147796
1518
1519         Reviewed by Daniel Bates.
1520
1521         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1522         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): The "repository" parameter
1523         is now a repository object instead of the repository name, thus we don't have to pass the "trac"
1524         object in separately. Also added an assertion to see if the given repository is in iteration.revision,
1525         and another assertion that, if the previousIteration is non-null, the given repository is in
1526         previousIteration.revision.
1527         (BuildbotQueueView.prototype.revisionContentForIteration): Refactored to work more generically
1528         with repositories other than "openSource" and "internal". Also added an assertion that the returned
1529         fragment has at least one child node.
1530
1531 2015-08-12  Simon Fraser  <simon.fraser@apple.com>
1532
1533         Add a tool that dumps class and struct member layout, showing padding
1534         https://bugs.webkit.org/show_bug.cgi?id=147898
1535
1536         Reviewed by Zalan Bujtas.
1537         
1538         This 'dump-class-layout' script uses the lldb Python bindings to collect data
1539         about data member layout, and displays it.
1540         
1541         Sample output:
1542
1543               +0 { 72} WTF::ListHashSet<WebCore::URL, WebCore::URLHash>::Node
1544               +0 < 56>     WebCore::URL m_value;
1545               +0 <  8>         WTF::String m_string;
1546               +0 <  8>             WTF::RefPtr<WTF::StringImpl> m_impl;
1547               +0 <  8>                 WTF::StringImpl * m_ptr;
1548               +8 <  1>         bool:1 m_isValid;
1549               +8 <  1>         bool:1 m_protocolIsInHTTPFamily;
1550               +9 <  3>         <PADDING>
1551              +12 <  4>         int m_schemeEnd;
1552              +16 <  4>         int m_userStart;
1553              +20 <  4>         int m_userEnd;
1554              +24 <  4>         int m_passwordEnd;
1555              +28 <  4>         int m_hostEnd;
1556              +32 <  4>         int m_portEnd;
1557              +36 <  4>         int m_pathAfterLastSlash;
1558              +40 <  4>         int m_pathEnd;
1559              +44 <  4>         int m_queryEnd;
1560              +48 <  4>         int m_fragmentEnd;
1561              +52 <  4>         <PADDING>
1562              +52 <  4>     <PADDING>
1563              +56 <  8>     WTF::ListHashSetNode<WebCore::URL> * m_prev;
1564              +64 <  8>     WTF::ListHashSetNode<WebCore::URL> * m_next;
1565             Total byte size: 72
1566             Total pad bytes: 11
1567             Padding percentage: 15.28 %
1568
1569         * Scripts/dump-class-layout: Added.
1570         (webkit_build_dir):
1571         (developer_dir):
1572         (import_lldb):
1573         (find_build_directory):
1574         (verify_type):
1575         (verify_type_recursive):
1576         (dump_class):
1577         (main):
1578         (main.or):
1579
1580 2015-08-12  Alex Christensen  <achristensen@webkit.org>
1581
1582         Fix Debug CMake builds on Windows
1583         https://bugs.webkit.org/show_bug.cgi?id=147940
1584
1585         Reviewed by Chris Dumez.
1586
1587         * DumpRenderTree/PlatformWin.cmake:
1588         * TestWebKitAPI/PlatformWin.cmake:
1589         The BitmapImage test is not enabled on the AppleWin port.
1590         * WinLauncher/CMakeLists.txt:
1591         Debug builds need /NODEFAULTLIB:MSVCRTD, too.
1592
1593 2015-08-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1594
1595         Unreviewed. run-gtk-tests: Use a longer timeout for slow tests.
1596
1597         In r188125 I added a way to mark tests as slow to use a longer
1598         timeout. But it seems it was not enough for
1599         WTF_Lock.ContendedShortSection, so let's try again with a longer
1600         timeout now.
1601
1602         * Scripts/run-gtk-tests:
1603         (TestRunner._run_google_test):
1604
1605 2015-08-12  Yusuke Suzuki  <utatane.tea@gmail.com>
1606
1607         Allow --debug option in run-jsc
1608         https://bugs.webkit.org/show_bug.cgi?id=147923
1609
1610         Reviewed by Csaba Osztrogonác.
1611
1612         When `--debug` option is specified in run-jsc, it runs the JSC shell built in the debug mode.
1613
1614         * Scripts/run-jsc:
1615
1616 2015-08-11  Alex Christensen  <achristensen@webkit.org>
1617
1618         Fix test after build fix in r188286.
1619         https://bugs.webkit.org/show_bug.cgi?id=147907
1620
1621         Reviewed by Anders Carlsson.
1622
1623         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1624         sleep_for can now be used, but we need to include <thread>
1625
1626 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
1627
1628         Always use a byte-sized lock implementation
1629         https://bugs.webkit.org/show_bug.cgi?id=147908
1630
1631         Reviewed by Geoffrey Garen.
1632
1633         All previous tests of Lock are now tests of WordLock. All previous tests of ByteLock are
1634         now tests of Lock.
1635
1636         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1637         (TestWebKitAPI::runLockTest):
1638         (TestWebKitAPI::TEST):
1639
1640 2015-08-11  Alexey Proskuryakov  <ap@apple.com>
1641
1642         Make ASan build not depend on asan.xcconfig
1643         https://bugs.webkit.org/show_bug.cgi?id=147840
1644         rdar://problem/21093702
1645
1646         Reviewed by Daniel Bates.
1647
1648         * asan/asan.xcconfig:
1649         * asan/webkit-asan-ignore.txt: Removed. It's no longer needed, as unsafe functions
1650         are now marked in source code.
1651
1652 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
1653
1654         Unreviewed, shorten another test since it timed out.
1655
1656         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1657         (TestWebKitAPI::TEST):
1658
1659 2015-08-11  Mark Lam  <mark.lam@apple.com>
1660
1661         Fix names of Lock tests: should be "Contended", not "Contented".
1662         https://bugs.webkit.org/show_bug.cgi?id=147905
1663
1664         Reviewed by Saam Barati.
1665
1666         We're testing the behavior of lock contention (i.e. when threads contend), not
1667         whether the locks are happy (contented).
1668
1669         * Scripts/run-gtk-tests:
1670         (TestRunner):
1671         (TestRunner.__init__): Deleted.
1672         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1673         (TestWebKitAPI::runLockTest):
1674         (TestWebKitAPI::TEST):
1675
1676 2015-08-11  Alex Christensen  <achristensen@webkit.org>
1677
1678         Update WinCairoRequirements to VS2015.
1679
1680         * Scripts/update-webkit-wincairo-libs:
1681         Update WinCairoRequirements location.
1682
1683 2015-08-11  Jason Marcell  <jmarcell@apple.com>
1684
1685         Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac
1686         for internalTrac.
1687         https://bugs.webkit.org/show_bug.cgi?id=147805
1688
1689         Reviewed by Daniel Bates.
1690
1691         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1692         (BuildbotQueueView): Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and
1693         Dashboard.Repository.Internal.trac for internalTrac.
1694         (BuildbotQueueView.prototype._appendPendingRevisionCount): Added local variables webkitTrac
1695         and internalTrac for Dashboard.Repository.OpenSource.trac and Dashboard.Repository.Internal.trac,
1696         respectively.
1697         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
1698         (BuildbotQueueView.prototype.revisionContentForIteration): Substituted
1699         Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac for
1700         internalTrac.
1701         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Ditto.
1702         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Ditto.
1703         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
1704         (Analyzer): Ditto.
1705         (Analyzer.prototype.analyze): Ditto.
1706
1707 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
1708
1709         Unreviewed, gardening these tests to run faster so that they don't timeout on slower OSes.
1710
1711         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1712         (TestWebKitAPI::TEST):
1713
1714 2015-08-11  Brent Fulgham  <bfulgham@apple.com>
1715
1716         [Win] Switch Windows build to Visual Studio 2015
1717         https://bugs.webkit.org/show_bug.cgi?id=147887
1718         <rdar://problem/22235098>
1719
1720         Reviewed by Alex Christensen.
1721
1722         Update Visual Studio project file settings to use the current Visual
1723         Studio and compiler. Continue targeting binaries to run on our minimum
1724         supported configuration of Windows 7.
1725
1726         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1727         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
1728         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
1729         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1730         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1731         * Scripts/webkitdirs.pm: Modify our Visual Studio search routines to
1732         prefer the newer MSBuild included in Visual Studio 2015.
1733         (visualStudioInstallDir):
1734         (msBuildInstallDir):
1735         (visualStudioVersion):
1736         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1737         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1738         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
1739         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1740         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
1741         * win/record-memory/record-memory.vcxproj:
1742
1743 2015-08-11  Alex Christensen  <achristensen@webkit.org>
1744
1745         Another speculative build fix after r188280.
1746
1747         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1748         std::this_thread is too modern c++ for VS2013 and supported GCC versions, 
1749         so let's go back to usleep and I made something close to usleep, but with much lower resolution.
1750
1751 2015-08-11  Alex Christensen  <achristensen@webkit.org>
1752
1753         Unreviewed build fix after r188280.
1754
1755         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1756         Include DataLog.h, and usleep is not available on Windows, so I used what I think is the c++11 equivalent.
1757
1758 2015-08-10  Filip Pizlo  <fpizlo@apple.com>
1759
1760         WTF should have a ParkingLot for parking sleeping threads, so that locks can fit in 1.6 bits
1761         https://bugs.webkit.org/show_bug.cgi?id=147665
1762
1763         Reviewed by Mark Lam.
1764
1765         * TestWebKitAPI/CMakeLists.txt:
1766         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1767         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1768         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1769         (TestWebKitAPI::TEST):
1770         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp: Added.
1771         (TestWebKitAPI::TEST):
1772
1773 2015-08-11  Brian Burg  <bburg@apple.com>
1774
1775         webkit-patch should not explode when $EDITOR is set incorrectly
1776         https://bugs.webkit.org/show_bug.cgi?id=147884
1777
1778         Reviewed by Darin Adler.
1779
1780         If $EDITOR doesn't exist, log a warning and continue.
1781
1782         * Scripts/webkitpy/common/system/user.py: 
1783         (User.edit):
1784         (User.edit_changelog):
1785
1786 2015-08-11  Dan Bernstein  <mitz@apple.com>
1787
1788         Reverted r188255, because it turned out that delegates do nonot need this information.
1789
1790         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1791         * TestWebKitAPI/Tests/WebKit2Cocoa/PrintFrame.mm: Removed.
1792
1793 2015-08-11  Dan Bernstein  <mitz@apple.com>
1794
1795         [Cocoa] The UI delegate can't tell if printing was user-initiated
1796         https://bugs.webkit.org/show_bug.cgi?id=147869
1797
1798         Reviewed by Sam Weinig.
1799
1800         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1801         * TestWebKitAPI/Tests/WebKit2Cocoa/PrintFrame.mm: Added.
1802         (-[PrintFrameController webView:didFinishNavigation:]):
1803         (-[PrintFrameController _webView:printFrame:userInitiated:]):
1804         (TEST):
1805
1806 2015-08-10  Alex Christensen  <achristensen@webkit.org>
1807
1808         Another build fix after r188239.
1809
1810         * TestWebKitAPI/PlatformWin.cmake:
1811         Link with more libraries.
1812         * WinLauncher/CMakeLists.txt:
1813         /NODEFAULTLIB:MSVCRT is not just needed for AppleWin.
1814
1815 2015-08-10  Ryosuke Niwa  <rniwa@webkit.org>
1816
1817         Build fix after r188237.
1818
1819         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1820         (BenchmarkBuilder.__enter__):
1821
1822 2015-08-10  Dewei Zhu  <dewei_zhu@apple.com>
1823
1824         Update ReadMe and correct the way to use abstract abstract class.
1825         https://bugs.webkit.org/show_bug.cgi?id=147860
1826
1827         Reviewed by Ryosuke Niwa.
1828
1829         Update ReadMe according to recent changes. And set ABCMeta to be the __metaclass__ of BrowserDriver and HTTPServerDriver,
1830         so that all methods annotated by 'abstractmethod' will check whether they are implememnt by subclasses.
1831
1832         * Scripts/webkitpy/benchmark_runner/README.md:
1833         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1834         (BrowserDriver):
1835         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1836         (OSXBrowserDriver.restore_env):
1837         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
1838         (HTTPServerDriver):
1839         (HTTPServerDriver.set_device_id):
1840         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
1841         (SimpleHTTPServerDriver.get_return_code):
1842         (SimpleHTTPServerDriver):
1843         (SimpleHTTPServerDriver.set_device_id):
1844
1845 2015-08-10  Alex Christensen  <achristensen@webkit.org>
1846
1847         Build TestWebKitAPI with CMake on Windows
1848         https://bugs.webkit.org/show_bug.cgi?id=147851
1849
1850         Reviewed by Chris Dumez.
1851
1852         * CMakeLists.txt:
1853         * TestWebKitAPI/CMakeLists.txt:
1854         Removed TestJavaScriptCore because JavaScriptCore's API tests are elsewhere and this was just making an empty binary.
1855         Surrounded WebKit2-specific features with ENABLE_WEBKIT2 checks.
1856         Include directories after the Platform*.cmake is included because HostWindow.h needs to be found in Tools/TestWebKitAPI/win 
1857         before we look in Source/WebCore/platform, where another file named HostWindow.h exists.
1858         * TestWebKitAPI/PlatformEfl.cmake:
1859         * TestWebKitAPI/PlatformGTK.cmake:
1860         Windows needs all the binaries to be in the same directory to find gtest.dll and the other dlls.
1861         I did this without changing the directory structure of the existing EFL and GTK builds.
1862         * TestWebKitAPI/PlatformWin.cmake: Added.
1863         * TestWebKitAPI/win/main.cpp:
1864         (main):
1865         (dllLauncherEntryPoint):
1866         Added so we can launch TestWebKitAPI executables after finding the AAS directory.
1867         * WinLauncher/CMakeLists.txt:
1868         AppleWin port needs /NODEFAULTLIB:MSVCRT.
1869
1870 2015-08-10  Dewei Zhu  <dewei_zhu@apple.com>
1871
1872         Make cleanup more robust and minor code cleaning in run benchmark script.
1873         https://bugs.webkit.org/show_bug.cgi?id=147800
1874
1875         Reviewed by Ryosuke Niwa.
1876
1877         Use 'finnaly' block to make sure cleanup code is always executed.
1878
1879         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1880         (built_benchmark):
1881         (built_benchmark.__init__):
1882         (built_benchmark.__enter__):
1883         (built_benchmark.__exit__):
1884         (test_environment):
1885         (test_environment.__init__):
1886         (test_environment.__enter__):
1887         (test_environment.__exit__):
1888         (BenchmarkRunner.__init__):
1889         (BenchmarkRunner.execute):
1890         (BenchmarkRunner._dump):
1891         (BenchmarkRunner._wrap):
1892         (BenchmarkRunner): Deleted.
1893         (BenchmarkRunner._cleanup): Deleted.
1894         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1895         (BrowserDriver.close_browsers):
1896         (BrowserDriver):
1897         (BrowserDriver.restore_env):
1898         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
1899         (SimpleHTTPServerDriver.__init__): We do not actually need to know external ip address for now.
1900
1901 2015-08-10  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1902
1903         Compile warning (-Wsign-compare) on 32-bits at WebCore/platform/FileSystem.cpp
1904         https://bugs.webkit.org/show_bug.cgi?id=146414
1905
1906         Reviewed by Darin Adler.
1907
1908         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
1909         (TestWebKitAPI::TEST): Improving testing of WTF::isInBounds.
1910
1911 2015-08-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1912
1913         [GTK] Test  /webkit2/WebKitWebView/submit-form is flaky
1914         https://bugs.webkit.org/show_bug.cgi?id=147727
1915
1916         Reviewed by Sergio Villar Senin.
1917
1918         I think it was not this test in particular, but
1919         /webkit2/WebKitWebView/custom-charset that is affecting the
1920         others. This is because changing the encoding reloads the page,
1921         but we don't wait for the page to be reloaded, so when the test
1922         finishes and other test starts the web process is still reloading
1923         the page.
1924
1925         * Scripts/run-gtk-tests:
1926         (TestRunner): Unskip /webkit2/WebKitWebView/submit-form.
1927         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1928         (testWebViewCustomCharset): Wait until page is reloaded after
1929         changing the charset.
1930
1931 2015-08-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1932
1933         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/install-missing-plugins-permission-request.
1934
1935         It's timing out in the bots. My guess is that there's no installer
1936         installed in the bots and gst_install_plugins_supported() returns
1937         false, so we don't even get a permission request because no
1938         installer will be launched.
1939
1940         * Scripts/run-gtk-tests:
1941         (TestRunner):
1942
1943 2015-08-07  Alex Christensen  <achristensen@webkit.org>
1944
1945         [GTK] Another build fix after r188157.
1946
1947         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1948         (WTR::PlatformWebView::viewSupportsOptions):
1949         Name all the things correctly!
1950
1951 2015-08-07  Alex Christensen  <achristensen@webkit.org>
1952
1953         [EFL, GTK] Build fix after r188176.
1954
1955         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1956         I moved forwarding headers out of a unix subdirectory because I am using them on Windows now.
1957
1958 2015-08-07  Alex Christensen  <achristensen@webkit.org>
1959
1960         [GTK] Speculative build fix after r188157.
1961
1962         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1963         (WTR::PlatformWebView::PlatformWebView):
1964         Update parameter list.
1965
1966 2015-08-07  Alex Christensen  <achristensen@webkit.org>
1967
1968         Build more testing binaries with CMake on Windows
1969         https://bugs.webkit.org/show_bug.cgi?id=147799
1970
1971         Reviewed by Brent Fulgham.
1972
1973         * DumpRenderTree/CMakeLists.txt:
1974         Build TestNetscapePlugin.
1975         * DumpRenderTree/PlatformWin.cmake:
1976         Build ImageDiff and add files necessary for TestNetscapePlugin on Windows.
1977         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders: Added.
1978         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit: Added.
1979         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h.
1980         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h.
1981         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h.
1982         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Removed.
1983         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Removed.
1984         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Removed.
1985
1986 2015-08-07  Jason Marcell  <jmarcell@apple.com>
1987
1988         Refactor BuildbotQueue.compareIterations and BuildbotQueue.compareIterationsByRevisions to be more generic
1989         https://bugs.webkit.org/show_bug.cgi?id=147667
1990
1991         Reviewed by Daniel Bates.
1992
1993         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1994         (BuildbotQueue.prototype.compareIterations): Refactored to work more generically with repositories
1995         other than "openSource" and "internal".
1996         (BuildbotQueue.prototype.compareIterationsByRevisions): Ditto.
1997         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1998         (Dashboard.get sortedPlatforms): Added. Returns a sorted array of platforms.
1999         (Dashboard.get sortedRepositories): Added. Returns a sorted array of repositories.
2000         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2001         (documentReady): Using Dashboard.sortedPlatforms instead of sortedPlatforms.
2002         (sortedPlatforms): Deleted.
2003         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2004         (buildQueuesTable): Using Dashboard.sortedPlatforms instead of sortedPlatforms.
2005         (sortedPlatforms): Deleted.
2006         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
2007         (sortDictionariesByOrder): Added. Takes an array of dictionaries that have an "order" property
2008         and sorts them by this property returning the new sorted array.
2009
2010 2015-08-07  Filip Pizlo  <fpizlo@apple.com>
2011
2012         Lightweight locks should be adaptive
2013         https://bugs.webkit.org/show_bug.cgi?id=147545
2014
2015         Reviewed by Geoffrey Garen.
2016
2017         * TestWebKitAPI/CMakeLists.txt:
2018         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2019         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2020         * TestWebKitAPI/Tests/WTF/Lock.cpp: Added.
2021         (TestWebKitAPI::runLockTest):
2022         (TestWebKitAPI::TEST):
2023
2024 2015-08-07  Anders Carlsson  <andersca@apple.com>
2025
2026         Fix a tyop.
2027
2028         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2029         (WTR::PlatformWebView::viewSupportsOptions):
2030
2031 2015-08-07  Alexey Proskuryakov  <ap@apple.com>
2032
2033         Update AppEngine app version numbers to the latest commit.
2034
2035         * QueueStatusServer/app.yaml:
2036         * TestResultServer/app.yaml:
2037
2038 2015-08-07  Anders Carlsson  <andersca@apple.com>
2039
2040         Simplify WKTR's view options
2041         https://bugs.webkit.org/show_bug.cgi?id=147791
2042
2043         Reviewed by Sam Weinig.
2044
2045         Instead of using a WKDictionaryRef, just use a struct for the options.
2046
2047         * WebKitTestRunner/PlatformWebView.h:
2048         (WTR::PlatformWebView::options):
2049         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
2050         * WebKitTestRunner/TestController.cpp:
2051         (WTR::TestController::initialize):
2052         (WTR::TestController::createWebViewWithOptions):
2053         (WTR::TestController::ensureViewSupportsOptions):
2054         (WTR::TestController::updateLayoutTypeForTest):
2055         * WebKitTestRunner/TestController.h:
2056         * WebKitTestRunner/ViewOptions.h: Added.
2057         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2058         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2059         (WTR::PlatformWebView::PlatformWebView):
2060         (WTR::PlatformWebView::viewSupportsOptions):
2061         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2062         (WTR::PlatformWebView::viewSupportsOptions):
2063         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2064         (WTR::PlatformWebView::viewSupportsOptions):
2065         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2066         (WTR::PlatformWebView::PlatformWebView):
2067         (WTR::PlatformWebView::viewSupportsOptions):
2068         * WebKitTestRunner/mac/TestControllerMac.mm:
2069         (WTR::TestController::platformConfigureViewForTest):
2070
2071 2015-08-07  Joseph Pecoraro  <pecoraro@apple.com>
2072
2073         Running tests for a long time results in some tests running very slowly (throttling)
2074         https://bugs.webkit.org/show_bug.cgi?id=147718
2075
2076         Reviewed by Chris Dumez.
2077
2078         Follow-up, make DumpRenderTree consistent with WebKitTestRunner.
2079         Although COCOA ports default this setting to be disabled in WebKit1,
2080         we should make both test harnesses disable the setting for consistency.
2081
2082         * DumpRenderTree/mac/DumpRenderTree.mm:
2083         (resetWebPreferencesToConsistentValues):
2084
2085 2015-08-07  Ryosuke Niwa  <rniwa@webkit.org>
2086
2087         Use a specific version of Speedometer in run-benchmark
2088         https://bugs.webkit.org/show_bug.cgi?id=147769
2089
2090         Reviewed by Chris Dumez.
2091
2092         Use the current latest revision as we work towards the bug 147768 (Update frameworks in Speedometer).
2093
2094         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
2095
2096 2015-08-07  Ryosuke Niwa  <rniwa@webkit.org>
2097
2098         twisted_http_server.py should support --port
2099         https://bugs.webkit.org/show_bug.cgi?id=147771
2100
2101         Reviewed by Chris Dumez.
2102
2103         Added the option. This makes the script more useful on its own.
2104
2105         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
2106
2107 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2108
2109         [GTK] WTF unit tests are timing out in the bots
2110         https://bugs.webkit.org/show_bug.cgi?id=147777
2111
2112         Reviewed by Filip Pizlo.
2113
2114         Add a way to mark google unit tests as slow and add
2115         WTF_Lock.ContentedShortSection to the list. In case of slow test
2116         we use the double of the given timeout for that particular test.
2117
2118         * Scripts/run-gtk-tests:
2119         (TestRunner):
2120         (TestRunner._run_google_test):
2121
2122 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2123
2124         [GTK] run-gtk-tests should not stop when a google test case fails
2125         https://bugs.webkit.org/show_bug.cgi?id=147778
2126
2127         Reviewed by Philippe Normand.
2128
2129         For glib based tests we run the test runner with the -k option,
2130         but for google tests we are aborting as soon as we find a failure.
2131
2132         * Scripts/run-gtk-tests:
2133         (TestRunner._run_google_test_suite): Use a global return code that
2134         is set to 1 when any test has failed.
2135
2136 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2137
2138         [GStreamer] Do not automatically show PackageKit codec installation notifications
2139         https://bugs.webkit.org/show_bug.cgi?id=135973
2140
2141         Reviewed by Philippe Normand.
2142
2143         Handle the missing media plugins installation permission request
2144         in MiniBrowser and add a test case for the new API.
2145
2146         * MiniBrowser/gtk/BrowserWindow.c:
2147         (webViewDecidePermissionRequest):
2148         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2149         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
2150         (permissionRequestCallback):
2151         (testInstallMissingPluginsPermissionRequest):
2152         (beforeAll):
2153         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2154         (methodCallCallback):
2155
2156 2015-08-06  Joseph Pecoraro  <pecoraro@apple.com>
2157
2158         Running tests for a long time results in some tests running very slowly (throttling)
2159         https://bugs.webkit.org/show_bug.cgi?id=147718
2160
2161         Reviewed by Alexey Proskuryakov.
2162
2163         * WebKitTestRunner/TestController.cpp:
2164         (WTR::TestController::resetPreferencesToConsistentValues):
2165         Ensure throttling settings are disabled for tests for all ports, as
2166         COCOA ports default to having these setting enabled. Note, there is
2167         still other timer throttling not covered by these setting.
2168
2169 2015-08-06  Ryosuke Niwa  <rniwa@webkit.org>
2170
2171         http_server_driver and benchmark_builder should not be in run-benchmark's plan files
2172         https://bugs.webkit.org/show_bug.cgi?id=147752
2173
2174         Reviewed by Chris Dumez.
2175
2176         Removed BenchmarkBuilderFactory since we have exactly one subclass of BenchmarkBuilder.
2177
2178         Also made HTTPServerDriverFactory instantiate the appropriate HTTP server based on the platform name instead of HTTP server name.
2179         This allows us to remove --http-server-driver option from run-benchmark, which was added to support the HTTP server for iOS.
2180
2181         * Scripts/webkitpy/benchmark_runner/benchmark_builder: Removed.
2182         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py: Moved from benchmark_runner/benchmark_builder/generic_benchmark_builder.py.
2183         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Removed.
2184         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Removed.
2185         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Moved to benchmark_runner/benchmark_builder.py.
2186         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2187         (BenchmarkRunner.__init__): No longer takes http_server_driver_override as an argument since this is not handled by
2188         HTTPServerDriverFactory taking the platform name as an argument.
2189         (BenchmarkRunner.execute): Directly instantiate BenchmarkBuilder.
2190         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Removed http_server_driver and benchmark_builder.
2191         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Ditto.
2192         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Ditto.
2193         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Ditto.
2194         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan: Ditto.
2195         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Ditto.
2196         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Ditto.
2197         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Ditto.
2198         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Ditto.
2199         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py:
2200         (http_server_driver_loader): Register http server drivers via supported platform names instead of http server names.
2201         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
2202         (HTTPServerDriver): Replaced name by platforms.
2203         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
2204         (SimpleHTTPServerDriver): Ditto.
2205         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2206         (parse_args): Removed --http-server-driver option.
2207         (start): Ditto.
2208
2209 2015-08-06  Chris Dumez  <cdumez@apple.com>
2210
2211         Toggle GPS state based on page visibility to save battery
2212         https://bugs.webkit.org/show_bug.cgi?id=147685
2213
2214         Reviewed by Benjamin Poulain.
2215
2216         Add testRunner.isGeolocationProviderActive() test support function.
2217
2218         * DumpRenderTree/TestRunner.cpp:
2219         (isGeolocationProviderActiveCallback):
2220         (TestRunner::staticFunctions):
2221         * DumpRenderTree/TestRunner.h:
2222         * DumpRenderTree/mac/MockGeolocationProvider.h:
2223         * DumpRenderTree/mac/MockGeolocationProvider.mm:
2224         (-[MockGeolocationProvider isActive]):
2225         * DumpRenderTree/mac/TestRunnerMac.mm:
2226         (TestRunner::isGeolocationProviderActive):
2227         * DumpRenderTree/win/TestRunnerWin.cpp:
2228         (TestRunner::isGeolocationProviderActive):
2229         * WebKitTestRunner/GeolocationProviderMock.h:
2230         (WTR::GeolocationProviderMock::isActive):
2231         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2232         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2233         (WTR::InjectedBundle::isGeolocationProviderActive):
2234         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2235         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2236         (WTR::TestRunner::isGeolocationProviderActive):
2237         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2238         * WebKitTestRunner/TestController.cpp:
2239         (WTR::TestController::isGeolocationProviderActive):
2240         * WebKitTestRunner/TestController.h:
2241         * WebKitTestRunner/TestInvocation.cpp:
2242         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2243
2244 2015-08-06  Ryosuke Niwa  <rniwa@webkit.org>
2245
2246         Automate JSBench with run-benchmark
2247         https://bugs.webkit.org/show_bug.cgi?id=147716
2248
2249         Reviewed by Chris Dumez.
2250
2251         Added JSBench plan to run-benchmark.
2252
2253         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
2254         (GenericBenchmarkBuilder.prepare): Pass in the archive type to _fetch_remote_archive.
2255         (GenericBenchmarkBuilder._fetch_remote_archive): Added the support for extracting files from tar.gz in addition to zip.
2256         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Fixed the coding style.
2257         * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch: Added.
2258         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Fixed the coding style.
2259         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Ditto.
2260         * Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Ditto.
2261         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Ditto.
2262         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Specified the archive type.
2263         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Specified the archive type.
2264         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Ditto.
2265         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Fixed the coding style.
2266         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan: Added.
2267         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Specified the archive type.
2268         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Ditto.
2269
2270 2015-08-06  Yusuke Suzuki  <utatane.tea@gmail.com>
2271
2272         Pass-through the undefined options in run-jsc
2273         https://bugs.webkit.org/show_bug.cgi?id=147717
2274
2275         Undefined options in run-jsc is just passed to the actual jsc shell.
2276         We can execute `Tools/Scripts/run-jsc -d`.
2277
2278         Reviewed by Csaba Osztrogonác.
2279
2280         * Scripts/run-jsc:
2281
2282 2015-08-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2283
2284         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/submit-form.
2285
2286         It's flaky.
2287
2288         * Scripts/run-gtk-tests:
2289         (TestRunner):
2290
2291 2015-08-06  Csaba Osztrogonác  <ossy@webkit.org>
2292
2293         [EFL] Bump EFL version to 1.15.0
2294         https://bugs.webkit.org/show_bug.cgi?id=147450
2295
2296         Reviewed by Gyuyoung Kim.
2297
2298         * efl/jhbuild.modules:
2299
2300 2015-08-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2301
2302         Unreviewed. Unksip TestContextMenu GTK+ API test.
2303
2304         This has been skipped for a long time, and it's very
2305         unconvenient. It has never failed for me locally, so let's try
2306         again to see if it works in the bots. I'll skip it again if it
2307         keeps failing.
2308
2309         * Scripts/run-gtk-tests:
2310         (TestRunner):
2311
2312 2015-08-05  Filip Pizlo  <fpizlo@apple.com>
2313
2314         Unreviewed, roll out http://trac.webkit.org/changeset/187972.
2315
2316         * DumpRenderTree/JavaScriptThreading.cpp:
2317         (javaScriptThreadsMutex):
2318         (runJavaScriptThread):
2319         (startJavaScriptThreads):
2320         (stopJavaScriptThreads):
2321         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2322         (TestWebKitAPI::TEST):
2323         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
2324         (TestWebKitAPI::TEST):
2325
2326 2015-08-05  Alex Christensen  <achristensen@webkit.org>
2327
2328         Build DumpRenderTree with CMake.
2329         https://bugs.webkit.org/show_bug.cgi?id=147519
2330
2331         Reviewed by Brent Fulgham.
2332
2333         * CMakeLists.txt:
2334         Build the DumpRenderTree directory now that it builds successfully.
2335         * DumpRenderTree/CMakeLists.txt:
2336         Added missing source file and don't link with WebCore.lib.
2337         * DumpRenderTree/PlatformWin.cmake:
2338         Added sources to DumpRenderTreeLib and made DumpRenderTree only build DLLLauncherMain.cpp. 
2339         * WinLauncher/CMakeLists.txt:
2340         We need libcmt now that we are not linking with WebCore.lib.
2341
2342 2015-08-05  Alexey Proskuryakov  <ap@apple.com>
2343
2344         AppScale: Use https URLs for subresources and links
2345         https://bugs.webkit.org/show_bug.cgi?id=147686
2346
2347         Reviewed by Ryosuke Niwa.
2348
2349         * QueueStatusServer/filters/webkit_extras.py:
2350         * TestResultServer/static-dashboards/dashboard_base.js:
2351         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2352         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2353         * TestResultServer/static-dashboards/treemap.js:
2354         * TestResultServer/static-dashboards/ui.js:
2355
2356 2015-08-04  Filip Pizlo  <fpizlo@apple.com>
2357
2358         Rename Mutex to DeprecatedMutex
2359         https://bugs.webkit.org/show_bug.cgi?id=147675
2360
2361         Reviewed by Geoffrey Garen.
2362
2363         * DumpRenderTree/JavaScriptThreading.cpp:
2364         (javaScriptThreadsMutex):
2365         (runJavaScriptThread):
2366         (startJavaScriptThreads):
2367         (stopJavaScriptThreads):
2368         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2369         (TestWebKitAPI::TEST):
2370         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
2371         (TestWebKitAPI::TEST):
2372
2373 2015-08-05  Timothy Hatcher  <timothy@apple.com>
2374
2375         Update the WebKit nightly icon
2376         https://bugs.webkit.org/show_bug.cgi?id=147684
2377
2378         Reviewed by Sam Weinig.
2379
2380         * WebKitLauncher/webkit.icns: Replaced.
2381
2382 2015-08-05  Daniel Bates  <dabates@apple.com>
2383
2384         REGRESSION (r185111): Clicking phone numbers doesn't prompt to call sometimes
2385         https://bugs.webkit.org/show_bug.cgi?id=147678
2386         <rdar://problem/21827815>
2387
2388         Reviewed by Brady Eidson.
2389
2390         Add a test to ensure that we restore the "should open external URLs" policy on
2391         page reload after the web content process crashes.
2392
2393         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2394         * TestWebKitAPI/Tests/WebKit2/should-open-external-schemes.html: Added.
2395         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
2396         (TEST):
2397
2398 2015-08-04  Hunseop Jeong  <hs85.jeong@samsung.com>
2399
2400         [EFL] Editing tests have been broken since r186694
2401         https://bugs.webkit.org/show_bug.cgi?id=146888
2402
2403         Reviewed by Brent Fulgham.
2404
2405         Restored some codes for the context click on GTK+ and EFL port.
2406
2407         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2408         (WTR::EventSendingController::contextClick): Seperated the codes using the PLATFORM guard.
2409
2410 2015-08-04  Dewei Zhu  <dewei_zhu@apple.com>
2411
2412         Install twisted package for http server when necessary.
2413         https://bugs.webkit.org/show_bug.cgi?id=147082
2414
2415         Reviewed by Ryosuke Niwa.
2416
2417         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
2418         * Scripts/webkitpy/thirdparty/__init__.py:
2419         (AutoinstallImportHook.find_module):
2420         (AutoinstallImportHook._install_twisted):
2421
2422 2015-08-04  Brent Fulgham  <bfulgham@apple.com>
2423
2424         [Win] Update Apple Windows build for VS2015
2425         https://bugs.webkit.org/show_bug.cgi?id=147653
2426
2427         Reviewed by Dean Jackson.
2428
2429         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/PluginTest.h: If building with
2430         something older than VS2015, define snprintf as _snprintf.
2431         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
2432         Remove unneeded macro definition for snprintf.
2433         * Scripts/webkitpy/common/system/platforminfo.py:
2434         (PlatformInfo._determine_win_version): Recognize Windows 10.
2435         * Scripts/webkitpy/port/win.py:
2436         (WinPort): Ditto.
2437         * Scripts/webkitpy/port/win_unittest.py:
2438         (WinPortTest.test_baseline_search_path): Include Windows 10 in tests.
2439         (WinPortTest._assert_version): Ditto.
2440
2441 2015-08-04  Brian Burg  <bburg@apple.com>
2442
2443         Unreviewed, update email addresses in contributors.json and watchlist.
2444
2445         * Scripts/webkitpy/common/config/contributors.json:
2446         * Scripts/webkitpy/common/config/watchlist:
2447
2448 2015-08-04  Alexey Proskuryakov  <ap@apple.com>
2449
2450         Implement NPAPI redirect handling
2451         https://bugs.webkit.org/show_bug.cgi?id=138675
2452         rdar://problem/15779101
2453
2454         Patch by Jeffrey Pfau, updated and tweaked by me.
2455
2456         Reviewed by Anders Carlsson.
2457
2458         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2459         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
2460         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2461         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2462         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2463         (PluginTest::NPP_URLNotify):
2464         (PluginTest::NPP_URLRedirectNotify):
2465         (PluginTest::NPP_GetValue):
2466         (PluginTest::NPN_GetURLNotify):
2467         (PluginTest::NPN_PostURLNotify):
2468         (PluginTest::NPN_GetValue):
2469         (PluginTest::NPN_ReleaseVariantValue):
2470         (PluginTest::NPN_URLRedirectResponse):
2471         (PluginTest::NPN_ConvertPoint):
2472         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2473         * DumpRenderTree/TestNetscapePlugIn/Tests/URLRedirect.cpp: Added.
2474         (URLRedirect::URLRedirect):
2475         (URLRedirect::ScriptableObject::hasMethod):
2476         (URLRedirect::ScriptableObject::get):
2477         (URLRedirect::ScriptableObject::serviceAsync):
2478         (URLRedirect::ScriptableObject::invoke):
2479         (URLRedirect::NPP_GetValue):
2480         (URLRedirect::NPP_URLNotify):
2481         (URLRedirect::NPP_URLRedirectNotify):
2482         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2483         (NP_GetEntryPoints):
2484         (NPP_URLNotify):
2485         (NPP_URLRedirectNotify):
2486         (NPP_GetValue):
2487
2488 2015-08-04  Tim Horton  <timothy_horton@apple.com>
2489
2490         Move Matt Daiter to committers.
2491
2492         * Scripts/webkitpy/common/config/contributors.json:
2493
2494 2015-08-04  Brent Fulgham  <bfulgham@apple.com>
2495
2496         [Win] build-webkit and MSBuild fight over BuildOutput.htm, causing build failures.
2497         https://bugs.webkit.org/show_bug.cgi?id=147636
2498
2499         Reviewed by Alex Christensen.
2500         
2501         We no longer need build-webkit to manually troll the log data and pipe it to stdout; MSBuild is already doing this properly.
2502         Stop the build-webkit script from interacting with BuildOutput.htm, thereby preventing a potential build failure (especially
2503         on EWS machines)
2504
2505         * Scripts/build-webkit:
2506
2507 2015-08-04  Jason Marcell  <jmarcell@apple.com>
2508
2509         Refactor to convert openSourceRevision and internalRevision properties on BuildbotIteration into a more generic collection of revisions.
2510         https://bugs.webkit.org/show_bug.cgi?id=147280
2511
2512         Reviewed by Daniel Bates.
2513
2514         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2515         (BuildbotIteration): Removed opensourceRevision, internalRevision. Added revision.
2516         Refactored _parseData to handle repositories more generically.
2517         (parseRevisionProperty): Moved a comment up to parseRevisionProperty where it seems more relevant.
2518         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2519         (BuildbotQueue.prototype.compareIterations): Using "revision" property instead of
2520         "opensourceRevision" and "internalRevision".
2521         (BuildbotQueue.prototype.compareIterationsByRevisions): Ditto.
2522         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2523         (BuildbotQueueView.prototype._appendPendingRevisionCount): Ditto.
2524         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
2525         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Changing "internal" boolean
2526         parameter to more generic "repository" string parameter. Added "trac" parameter in order to
2527         specify the trac instance to use. Using "revision" property instead of "opensourceRevision"
2528         and "internalRevision".
2529         (BuildbotQueueView.prototype.revisionContentForIteration): Passing the repository name and trac
2530         instance to _revisionContentWithPopoverForIteration(). Using "revision" property instead of
2531         "opensourceRevision" and "internalRevision".
2532         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Adding
2533         constants for internal and opensource repositories.
2534         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2535         (Analyzer.prototype._findIndexOfLargestIterationAtOrBeforeStart): Using "revision" property
2536         instead of "opensourceRevision" and "internalRevision".
2537         (Analyzer.prototype._countPercentageOfGreen): Ditto.
2538         (Analyzer.prototype.webkitTrac.recordedCommits.forEach): Ditto.
2539         (Analyzer.prototype._countTimes): Ditto.
2540         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2541         (WebKitBuildbot.prototype.layoutTestResultsDirectoryURLForIteration): Ditto.
2542
2543 2015-08-04  Mark Lam  <mark.lam@apple.com>
2544
2545         Removed a local debugging line I accidentally left in from a previous commit.
2546
2547         Not Reviewed.
2548
2549         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2550
2551 2015-08-04  Mark Lam  <mark.lam@apple.com>
2552
2553         Unreviewed. Make Saam Barati a WebKit reviewer.
2554
2555         * Scripts/webkitpy/common/config/contributors.json:
2556
2557 2015-08-04  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2558
2559         Unreviewed, updated Streams API watchlist.
2560
2561         * Scripts/webkitpy/common/config/watchlist: Matched .*Readable.*Stream.* and .*QueuingStrategy.* in bindings/js.
2562
2563 2015-08-03  Csaba Osztrogonác  <ossy@webkit.org>
2564
2565         [CMake] Add an option to build AllInOne files
2566         https://bugs.webkit.org/show_bug.cgi?id=102647
2567
2568         Reviewed by Alex Christensen.
2569
2570         * Scripts/webkitperl/FeatureList.pm:
2571
2572 2015-08-03  Alexey Proskuryakov  <ap@apple.com>
2573
2574         AppScale: Add required indices
2575         https://bugs.webkit.org/show_bug.cgi?id=147593
2576
2577         Reviewed by Tim Horton.
2578
2579         * QueueStatusServer/index.yaml:
2580
2581 2015-08-03  Filip Pizlo  <fpizlo@apple.com>
2582
2583         Check in LLVM 3.6.2 binary drops for El Capitan
2584         https://bugs.webkit.org/show_bug.cgi?id=147582
2585
2586         Reviewed by Alexey Proskuryakov.
2587         
2588         Recognize 10.11 and use the right drops.
2589
2590         * Scripts/copy-webkitlibraries-to-product-directory:
2591
2592 2015-08-03  Alex Christensen  <achristensen@webkit.org>
2593
2594         [Win] Build fix after r187733.
2595
2596         * WinLauncher/PageLoadTestClient.cpp:
2597         (PageLoadTestClient::dumpRunStatistics):
2598         wtf/MathExtras.h is now included in HashTable.h, which #defines pow to wtf_pow.
2599
2600 2015-08-02  Benjamin Poulain  <bpoulain@apple.com>
2601
2602         Investigate HashTable::HashTable(const HashTable&) and HashTable::operator=(const HashTable&) performance for hash-based static analyses
2603         https://bugs.webkit.org/show_bug.cgi?id=118455
2604
2605         Reviewed by Filip Pizlo.
2606
2607         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2608         (TestWebKitAPI::TEST):
2609
2610 2015-07-31  Alex Christensen  <achristensen@webkit.org>
2611
2612         Prepare for VS2015
2613         https://bugs.webkit.org/show_bug.cgi?id=146579
2614
2615         Reviewed by Jon Honeycutt.
2616
2617         * WinLauncher/stdafx.h:
2618         Define __STDC_LIMIT_MACROS to have access to INTMAX_MAX.
2619
2620 2015-07-31  Csaba Osztrogonác  <ossy@webkit.org>
2621
2622         [EFL] Fix pixman build on ARM with GCC 4.9.3
2623         https://bugs.webkit.org/show_bug.cgi?id=147224
2624
2625         Reviewed by Gyuyoung Kim.
2626
2627         * efl/jhbuild.modules: Disable ARM IWMMXT fast paths as workarounding a GCC bug.
2628
2629 2015-07-30  Anders Carlsson  <andersca@apple.com>
2630
2631         Add support for window.open to WK1BrowserWindowController
2632         https://bugs.webkit.org/show_bug.cgi?id=147474
2633
2634         Reviewed by Dan Bernstein.
2635
2636         * MiniBrowser/mac/WK1BrowserWindowController.m:
2637         (-[WK1BrowserWindowController awakeFromNib]):
2638         Set javaScriptCanOpenWindowsAutomatically to YES. 
2639         If this becomes a nuisance, we can always add a menu item to toggle this.
2640
2641         (-[WK1BrowserWindowController webView:createWebViewWithRequest:]):
2642         Implement this UI delegate method.
2643
2644 2015-07-30  Anders Carlsson  <andersca@apple.com>
2645
2646         Undo stray commit.
2647
2648         * MiniBrowser/mac/WK1BrowserWindowController.m:
2649         (-[WK1BrowserWindowController awakeFromNib]):
2650         (-[WK1BrowserWindowController webView:createWebViewWithRequest:]):
2651
2652 2015-07-29  Dean Jackson  <dino@apple.com>
2653
2654         Don't use (Details) when exposing SPI
2655         https://bugs.webkit.org/show_bug.cgi?id=147426
2656         <rdar://problem/22062407>
2657
2658         Reviewed by Dan Bernstein.
2659
2660         If we are declaring the interface without any implementation,
2661         we should use class extensions.
2662
2663         * DumpRenderTree/mac/DumpRenderTree.mm:
2664         * DumpRenderTree/mac/EventSendingController.mm:
2665         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2666         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2667         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2668         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2669         * WebKitTestRunner/mac/TestControllerMac.mm:
2670
2671 2015-07-30  Aakash Jain  <aakash_jain@apple.com>
2672
2673         Replace Google App Engine with AppScale
2674         https://bugs.webkit.org/show_bug.cgi?id=147178
2675
2676         Reviewed by Daniel Bates.
2677
2678         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2679         (RunWebKitTests):
2680         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2681         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2682         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2683         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2684         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2685         (.):
2686         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2687         (BubbleQueueServer):
2688         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:
2689         (TestHistory):
2690         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2691         * QueueStatusServer/app.yaml: We must explicitly define threadsafe property when using the Python 2.7 runtime. We set threadsafe to be false because the status server code was written to be run in AppEngine's CGI environment and AppEngine's CGI programming model handles requests serially per section "Concurrent Requests and WSGI" of <https://cloud.google.com/appengine/docs/python/python25/migrate27>.
2692         * TestResultServer/app.yaml: Ditto
2693         * Scripts/webkitpy/common/config/urls.py:
2694         * TestResultServer/main.py:
2695         * TestResultServer/static-dashboards/dashboard_base.js:
2696         * TestResultServer/static-dashboards/loader.js:
2697
2698 2015-07-30  Joonghun Park  <jh718.park@samsung.com>
2699
2700         [EFL] Enable IndexedDB based on DatabaseProcess
2701         https://bugs.webkit.org/show_bug.cgi?id=147221
2702
2703         Reviewed by Csaba Osztrogonác.
2704
2705         * Scripts/webkitperl/FeatureList.pm:
2706
2707 2015-07-30  Alex Christensen  <achristensen@webkit.org>
2708
2709         Build AppleWin port with CMake
2710         https://bugs.webkit.org/show_bug.cgi?id=147385
2711
2712         Reviewed by Martin Robinson.
2713
2714         * WinLauncher/CMakeLists.txt:
2715         Link to CoreFoundation.lib and added /NODEFAULTLIB:LIBCMT to get it to link successfully.
2716
2717 2015-07-29  Andy VanWagoner  <thetalecrafter@gmail.com>
2718
2719         Implement basic types for ECMAScript Internationalization API
2720         https://bugs.webkit.org/show_bug.cgi?id=146926
2721
2722         Reviewed by Benjamin Poulain.
2723
2724         Enable flag now that the basic objects are in place.
2725
2726         * Scripts/webkitperl/FeatureList.pm: Enabled INTL
2727
2728 2015-07-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2729
2730         [GTK] Add API to set the maximum number of web processes per WebKitWebContext
2731         https://bugs.webkit.org/show_bug.cgi?id=147108
2732
2733         Reviewed by Gustavo Noronha Silva.
2734
2735         Add test case to check the web process limit.
2736
2737         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
2738         (testWebProcessLimit):
2739         (beforeAll):
2740
2741 2015-07-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2742
2743         [GTK] Missing casts in BrowserWindow.c
2744         https://bugs.webkit.org/show_bug.cgi?id=147395
2745
2746         Reviewed by Carlos Garcia Campos.
2747
2748         * MiniBrowser/gtk/BrowserWindow.c:
2749         (browserWindowSetupEditorToolbar):
2750
2751 2015-07-28  Yusuke Suzuki  <utatane.tea@gmail.com>
2752
2753         [ES6] Add ENABLE_ES6_MODULES compile time flag with the default value "false"
2754         https://bugs.webkit.org/show_bug.cgi?id=147350
2755
2756         Reviewed by Sam Weinig.
2757
2758         * Scripts/webkitperl/FeatureList.pm:
2759
2760 2015-07-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2761
2762         [Freetype] Always allow font matching for strong aliases
2763         https://bugs.webkit.org/show_bug.cgi?id=147057
2764
2765         Reviewed by Martin Robinson.
2766
2767         Create family aliases needed for the new layout tests.
2768
2769         * WebKitTestRunner/gtk/fonts/fonts.conf:
2770
2771 2015-07-28  Alexey Proskuryakov  <ap@apple.com>
2772
2773         webkitbot and WKR unnecessarily rely on webkit-queues.appspot.com
2774         https://bugs.webkit.org/show_bug.cgi?id=147359
2775
2776         Reviewed by Ryosuke Niwa.
2777
2778         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2779         (NewCommitBot.begin_work_queue):
2780         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2781         (SheriffBot.begin_work_queue):
2782
2783 2015-07-27  Alex Christensen  <achristensen@webkit.org>
2784
2785         Use Ninja on Windows.
2786         https://bugs.webkit.org/show_bug.cgi?id=147228
2787
2788         Reviewed by Martin Robinson.
2789
2790         * WinLauncher/CMakeLists.txt:
2791         WinLauncherLib must make WinLauncher.dll, not WinLauncherLib.dll.
2792         * Scripts/build-webkit:
2793         Use Ninja to build WinCairo by default, but fall back to Visual Studio if Ninja is not on the system.
2794
2795 2015-07-24  Jon Honeycutt  <jhoneycutt@apple.com>
2796
2797         Test for bug #147164 "[iOS] Keyboard bold/italic/underline keys don't
2798         highlight after being tapped to style a selection"
2799         https://bugs.webkit.org/show_bug.cgi?id=147278
2800
2801         Reviewed by Ryosuke Niwa.
2802
2803         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2804
2805         * TestWebKitAPI/Tests/mac/WordBoundaryTypingAttributes.mm: Added.
2806         (-[WordBoundaryTypingAttributesController webView:didFinishLoadForFrame:]):
2807         (TestWebKitAPI::TEST):
2808         Load a page with the string "Hello, world!", then select "world" and
2809         underline it. Test that the typing attributes for the current selection
2810         include the underline attribute.
2811
2812 2015-07-24  Hyungwook Lee  <hyungwook.lee@navercorp.com>
2813
2814         Unreviewed, updated my nick name in contributors.json
2815
2816         * Scripts/webkitpy/common/config/contributors.json:
2817
2818 2015-07-24  Chris Fleizach  <cfleizach@apple.com>
2819
2820         AX: scrollable elements do not allow 3-finger swipe
2821         https://bugs.webkit.org/show_bug.cgi?id=141893
2822
2823         Reviewed by Mario Sanchez Prada.
2824
2825         Support global notification listeners for iOS code.
2826         Fix an issue in DRT where the dictionary of data was not being passed back to the layout test for the notication callback.
2827         Implement scrollUp/Down/Left/Right.
2828
2829         * DumpRenderTree/AccessibilityController.h:
2830         * DumpRenderTree/AccessibilityUIElement.cpp:
2831         (increaseTextSelectionCallback):
2832         (scrollPageUpCallback):
2833         (scrollPageDownCallback):
2834         (scrollPageLeftCallback):
2835         (scrollPageRightCallback):
2836         (decreaseTextSelectionCallback):
2837         (getElementTextLengthCallback):
2838         (AccessibilityUIElement::getJSClass):
2839         * DumpRenderTree/AccessibilityUIElement.h:
2840         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2841         (AccessibilityController::~AccessibilityController):
2842         (AccessibilityController::elementAtPoint):
2843         (AccessibilityController::addNotificationListener):
2844         (AccessibilityController::platformResetToConsistentState):
2845         (AccessibilityController::removeNotificationListener):
2846         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2847         (AccessibilityUIElement::AccessibilityUIElement):
2848         (AccessibilityUIElement::subrole):
2849         (AccessibilityUIElement::scrollPageUp):
2850         (AccessibilityUIElement::scrollPageDown):
2851         (AccessibilityUIElement::scrollPageLeft):
2852         (AccessibilityUIElement::scrollPageRight):
2853         (AccessibilityUIElement::roleDescription):
2854         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
2855         (-[AccessibilityNotificationHandler _notificationReceived:]):
2856         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2857         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2858         (WTR::AccessibilityUIElement::linkedElement):
2859         (WTR::AccessibilityUIElement::headerElementAtIndex):
2860         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
2861         (WTR::AccessibilityUIElement::scrollPageUp):
2862         (WTR::AccessibilityUIElement::scrollPageDown):
2863         (WTR::AccessibilityUIElement::scrollPageLeft):
2864         (WTR::AccessibilityUIElement::scrollPageRight):
2865         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2866         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2867         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
2868         (WTR::AccessibilityController::addNotificationListener):
2869         (WTR::AccessibilityController::removeNotificationListener):
2870         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2871         (WTR::AccessibilityUIElement::AccessibilityUIElement):
2872         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
2873         (WTR::AccessibilityUIElement::scrollPageUp):
2874         (WTR::AccessibilityUIElement::scrollPageDown):
2875         (WTR::AccessibilityUIElement::scrollPageLeft):
2876         (WTR::AccessibilityUIElement::scrollPageRight):
2877         (WTR::AccessibilityUIElement::increaseTextSelection):
2878
2879 2015-07-24  Brent Fulgham  <bfulgham@apple.com>
2880
2881         [Win] Activate CSP_NEXT and Connect UserScript and UserStyleSheet through WebView.
2882         https://bugs.webkit.org/show_bug.cgi?id=147279
2883         <rdar://problem/21990767>
2884
2885         Reviewed by Dean Jackson.
2886
2887         * DumpRenderTree/win/TestRunnerWin.cpp:
2888         (TestRunner::addUserScript):
2889         (TestRunner::addUserStyleSheet):
2890         (TestRunner::setDeveloperExtrasEnabled):
2891
2892 2015-07-24  Basile Clement  <basile_clement@apple.com>
2893
2894         Call fixChangeLogPatch when generating patches from webkit-patch
2895         https://bugs.webkit.org/show_bug.cgi?id=147248
2896
2897         Reviewed by Geoffrey Garen.
2898
2899         When two consecutive patches are from the same author, diff tools
2900         create wrong-looking diffs for ChangeLog files where the apparent added
2901         author is actually the previous patch's author line, making it awkward
2902         to read - and things only get worse when committing a patch and a
2903         followup fix for the same bug shortly after.
2904
2905         We have a perl function in VCSUtils.pm, fixChangeLogPatch, to corrects
2906         this, which we use in perl scripts (svn-create-patch et al). But it is
2907         not used by webkit-patch, which is a python script, and thus creates
2908         "bad" diffs.
2909
2910         In the long term, we should probably port fixChangeLogPatch to python -
2911         but in the short term, let's make webkit-patch call perl to run
2912         fixChangeLogPatch. We are already making various external calls there
2913         anyway.
2914
2915         * Scripts/webkitpy/common/checkout/scm/git.py:
2916         (Git.create_patch):
2917         * Scripts/webkitpy/common/checkout/scm/scm.py:
2918         (SCM.fix_changelog_patch):
2919         * Scripts/webkitpy/common/checkout/scm/svn.py:
2920         (SVN.create_patch):
2921
2922 2015-07-24  Dean Johnson  <dean_johnson@apple.com>
2923
2924         commit-queue flags in webkit-patch are confusing
2925         https://bugs.webkit.org/show_bug.cgi?id=88694
2926
2927         Reviewed by Csaba Osztrogonác.
2928
2929         * Scripts/webkitpy/tool/steps/options.py:
2930         (Options): Updated help string to be more descriptive.
2931
2932 2015-07-23  Brent Fulgham  <bfulgham@apple.com>
2933
2934         [Win] Implement proper High DPI support features
2935         https://bugs.webkit.org/show_bug.cgi?id=146335
2936         <rdar://problem/21558269>
2937
2938         Reviewed by Alex Christensen.
2939
2940         Update WinLauncher to take device scaling factor into account.
2941
2942         * WinLauncher/Common.cpp:
2943         (resizeSubViews): Make sure toolbars and URL bar are properly sized and using
2944         a valid font.
2945         (computeFullDesktopFrame): Handle high DPI desktops.
2946         (WndProc): Make comments more precise.
2947         * WinLauncher/WinLauncher.cpp:
2948         (WinLauncher::init): Determine device scale factor at launch.
2949         (WinLauncher::updateDeviceScaleFactor): Added.
2950         * WinLauncher/WinLauncher.h:
2951         * WinLauncher/WinLauncherWebHost.h: Use C++11 initialization.
2952         * WinLauncher/WinMain.cpp: Size interface based on scaling factor.
2953         (wWinMain): Ditto.
2954         * win/DLLLauncher/DLLLauncherMain.cpp:
2955         (wWinMain): Tell Windows we understand high DPI.
2956
2957 2015-07-23  Alex Christensen  <achristensen@webkit.org>
2958
2959         [Win] Unreviewed build fix after r187169.
2960
2961         * Scripts/build-webkit:
2962         Correctly find WebKit.sln.
2963
2964 2015-07-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2965
2966         [GTK] Add API to allow executing editing commands that require an argument
2967         https://bugs.webkit.org/show_bug.cgi?id=146781
2968
2969         Reviewed by Gustavo Noronha Silva.
2970
2971         Add buttons to insert image/link to the MiniBrowser edit toolbar,
2972         and test cases for insert image/link commands too.
2973
2974         * MiniBrowser/gtk/BrowserWindow.c:
2975         (insertImageCommandCallback):
2976         (insertLinkCommandCallback):
2977         (browserWindowSetupEditorToolbar):
2978         (browserWindowConstructed):
2979         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
2980         (testWebViewEditorInsertImage):
2981         (testWebViewEditorCreateLink):
2982         (beforeAll):
2983
2984 2015-07-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2985
2986         Unregistering and re-registering a user message handler does not work
2987         https://bugs.webkit.org/show_bug.cgi?id=138142
2988
2989         Reviewed by Martin Robinson.
2990
2991         This has probably been fixed in r184846, enable the test case
2992         blocked on it.
2993
2994         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
2995         (testUserContentManagerScriptMessageReceived):
2996
2997 2015-07-22  Sukolsak Sakshuwong  <sukolsak@gmail.com>
2998
2999         Add ENABLE_WEBASSEMBLY feature flag for WebAssembly
3000         https://bugs.webkit.org/show_bug.cgi?id=147212
3001
3002         Reviewed by Filip Pizlo.
3003
3004         * Scripts/webkitperl/FeatureList.pm:
3005
3006 2015-07-22  Jon Honeycutt  <jhoneycutt@apple.com>
3007
3008         Add --ios-simulator to run-api-tests --help.
3009
3010         Rubber-stamped by Dan Bates.
3011
3012         * Scripts/run-api-tests:
3013
3014 2015-07-22  Jason Marcell  <jmarcell@apple.com>
3015
3016         Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo.
3017         https://bugs.webkit.org/show_bug.cgi?id=147043
3018
3019         Reviewed by Daniel Bates and Alexey Proskuryakov.
3020
3021         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3022         (Buildbot.prototype._normalizeQueueInfo):
3023         The _normalizeQueueInfo method now calls the defaultBranches getter instead of using hardcoded values
3024         in cases where the queue.branch property is not set and the queue is not a combined queue.
3025         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3026         (BuildbotCombinedQueueView):
3027         Ensuring uniformity of repository branches within a combined queue.
3028         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3029         (WebKitBuildbot.prototype.get defaultBranches):
3030         Added; provides a WebKit-specific implementation that sets the queue.branches dictionary to have a
3031         single entry for "openSource" as the default set of branches. Note that we intentionally omitted a
3032         base class implementation of the defaultBranches getter so as to cause a JavaScript TypeError when a
3033         sub-queue of a combined queue does not specify property branch and the derived Buildbot class does not
3034         implement defaultBranches so that a person can either update the definition of the sub-queue or
3035         implement defaultBranches in the derived Buildbot class they are using.
3036
3037 2015-07-22  Alex Christensen  <achristensen@webkit.org>
3038
3039         Switch WinCairo build to use CMake.
3040         https://bugs.webkit.org/show_bug.cgi?id=147169
3041
3042         Reviewed by Brent Fulgham.
3043
3044         * Scripts/build-webkit:
3045         * Scripts/webkitdirs.pm:
3046         (determineConfiguration):
3047         (determineArchitecture):
3048         (determinePassedConfiguration):
3049         (passedConfiguration):
3050         (jhbuildWrapperPrefixIfNeeded):
3051         (generateBuildSystemFromCMakeProject):
3052         It's CMake time!  We now use the CMake files to generate a solution in WebKitBuild/Release/WebKit.sln and build that.
3053
3054 2015-07-22  Alex Christensen  <achristensen@webkit.org>
3055
3056         Fix quirks in CMake build on Mac and Windows
3057         https://bugs.webkit.org/show_bug.cgi?id=147174
3058
3059         Reviewed by Gyuyoung Kim.
3060
3061         * CMakeLists.txt:
3062         Don't build DumpRenderTree with CMake for now (until we get that working).
3063         * WinLauncher/CMakeLists.txt:
3064         Renamed WinLauncherLauncher to WinLauncher and WinLauncher to WinLauncherLib to match the Visual Studio build.
3065
3066 2015-07-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3067
3068         [check-webkit-style] .lut.h files shouldn't raise a sorting issue
3069         https://bugs.webkit.org/show_bug.cgi?id=147146
3070
3071         Reviewed by Darin Adler.
3072
3073         * Scripts/webkitpy/style/checkers/cpp.py:
3074         (check_include_line): Avoid checking previous lines if it it is a lut.h include.
3075         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3076         (OrderOfIncludesTest.test_check_alphabetical_include_order): Added test.
3077
3078 2015-07-21  Filip Pizlo  <fpizlo@apple.com>
3079
3080         Fixed VM pool allocation should have a reserve for allocations that cannot fail
3081         https://bugs.webkit.org/show_bug.cgi?id=147154
3082         rdar://problem/21847618
3083
3084         Reviewed by Geoffrey Garen.
3085         
3086         Add a new test mode where we artificially limit JIT memory to 50KB. If our JIT OOM
3087         mitigations work, these should all pass. Prior to this patch there were >20 failures.
3088
3089         * Scripts/run-jsc-stress-tests:
3090
3091 2015-07-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3092
3093         [GTK] Add API to be notified about editor state changes
3094         https://bugs.webkit.org/show_bug.cgi?id=145875
3095
3096         Reviewed by Gustavo Noronha Silva.
3097
3098         Update the typing attributes toggle buttons state according to the
3099         editor state in MiniBrowser, and add a test case to the
3100         WebViewEditor unit tests.
3101
3102         * MiniBrowser/gtk/BrowserWindow.c:
3103         (browserWindowEditingCommandToggleButtonSetActive):
3104         (typingAttributesChanged):
3105         (browserWindowSetupEditorToolbar):
3106         (browserWindowConstructed):
3107         (browser_window_init):
3108         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
3109         (testWebViewEditorEditorStateTypingAttributes):
3110         (beforeAll):
3111
3112 2015-07-20  Tomas Popela  <tpopela@redhat.com>
3113
3114         [GTK] Add selection-changed signal to the WebKit2 API
3115         https://bugs.webkit.org/show_bug.cgi?id=137116
3116
3117         Reviewed by Carlos Garcia Campos.
3118
3119         Add a new WebProcess test TestEditor that is testing the WebKitWebEditor
3120         (namely the selection-changed signal).
3121
3122         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3123         * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp: Added.
3124         (WebKitWebEditorTest::create):
3125         (WebKitWebEditorTest::selectionChangedCallback):
3126         (WebKitWebEditorTest::testSelectionSelectAll):
3127         (WebKitWebEditorTest::testSelectionCollapse):
3128         (WebKitWebEditorTest::testSelectionModifyMove):
3129         (WebKitWebEditorTest::testSelectionModifyExtend):
3130         (WebKitWebEditorTest::testSelectionUnselect):
3131         (registerTests):
3132         * TestWebKitAPI/Tests/WebKit2Gtk/TestEditor.cpp: Added.
3133         (testWebKitWebEditorSelectionChanged):
3134         (beforeAll):
3135         (afterAll):
3136
3137 2015-07-20  Alex Christensen  <achristensen@webkit.org>
3138
3139         Resurrect CMake build on Windows.
3140         https://bugs.webkit.org/show_bug.cgi?id=147083
3141
3142         Reviewed by Gyuyoung Kim.
3143
3144         * DumpRenderTree/CMakeLists.txt:
3145         * DumpRenderTree/PlatformWin.cmake: Added.
3146         * WinLauncher/CMakeLists.txt:
3147
3148 2015-07-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3149
3150         [GTK] Enable seccomp filter API tests
3151         https://bugs.webkit.org/show_bug.cgi?id=140071
3152
3153         Reviewed by Žan Doberšek.
3154
3155         These tests will now be run by the run-gtk-tests script.
3156
3157         * TestWebKitAPI/PlatformGTK.cmake:
3158
3159 2015-07-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3160
3161         [GTK] Add seccomp filters support
3162         https://bugs.webkit.org/show_bug.cgi?id=110014
3163
3164         Reviewed by Žan Doberšek.
3165
3166         Add libseccomp to jhbuild modulesets.
3167
3168         * gtk/jhbuild.modules:
3169
3170 2015-07-18  Simon Fraser  <simon.fraser@apple.com>
3171
3172         MiniBrowser window title is just "Window" when page has no <title>
3173         https://bugs.webkit.org/show_bug.cgi?id=147076
3174
3175         Reviewed by Tim Horton.
3176         
3177         Make MiniBrowser windows show the filename from the URL if we never get a title changed
3178         notification.
3179
3180         * MiniBrowser/mac/WK1BrowserWindowController.m:
3181         (-[WK1BrowserWindowController updateTitle:]):
3182         (-[WK1BrowserWindowController webView:didCommitLoadForFrame:]):
3183         (-[WK1BrowserWindowController webView:didReceiveTitle:forFrame:]):
3184         * MiniBrowser/mac/WK2BrowserWindowController.m:
3185         (-[WK2BrowserWindowController updateTitle:]):
3186         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
3187         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
3188
3189 2015-07-17  Andy Estes  <aestes@apple.com>
3190
3191         [iOS] Further tighten the sandbox around pages fetched with Content-Disposition: attachment
3192         https://bugs.webkit.org/show_bug.cgi?id=147044
3193         rdar://problem/21567820
3194
3195         Reviewed by Brady Eidson.
3196
3197         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3198         (WTR::InjectedBundlePage::decidePolicyForResponse): Only log the message about attachments if the custom policy delegate is enabled.
3199         This matches the behavior of DumpRenderTree.
3200
3201 2015-07-17  Benjamin Poulain  <bpoulain@apple.com>
3202
3203         [Content Extensions] Term::isUniversalTransition() incorrectly expects the end-of-line assertion in character sets
3204         https://bugs.webkit.org/show_bug.cgi?id=147032
3205
3206         Reviewed by Alex Christensen.
3207
3208         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3209         Test that the useless terms are eliminated by counting
3210         the number of NFA nodes generated.
3211
3212 2015-07-17  Dan Bernstein  <mitz@apple.com>
3213
3214         Tests for <rdar://problem/21803781> The external URL policy is not reported correctly in navigation actions that create new windows
3215         https://bugs.webkit.org/show_bug.cgi?id=147040
3216
3217         Reviewed by Dean Jackson.
3218
3219         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3220         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm: Added.
3221         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:decidePolicyForNavigationAction:decisionHandler:]):
3222         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:didFinishNavigation:]):
3223         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3224         (TEST):
3225
3226 2015-07-16  Dean Johnson  <dean_johnson@apple.com>
3227
3228         webkit-patch uses incorrect credentials from keychain to login until account lockout
3229         https://bugs.webkit.org/show_bug.cgi?id=146923
3230
3231         Reviewed by Daniel Bates.
3232
3233         When `webkit-patch upload` asks for login credentials for bugs.webkit.org, if you
3234         provide incorrect credentials then ask for them to be saved to the keychain
3235         webkit-patch will then use those incorrect credentials until 5 total attempts
3236         have been made to log in. This will lock the user out of Bugzilla for a
3237         half hour.
3238
3239         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3240         (Bugzilla.authenticate): Added argument to read_credentials() that
3241         passes in whether or not to use stored credentials.
3242         * Scripts/webkitpy/common/net/credentials.py:
3243         (Credentials.read_credentials): Added optional argument 'use_stored_credentials'
3244         that specifies whether or not to use credentials stored on the system. If it
3245         does, we do not auto-fill credentials since either the credentials caused
3246         the failure, or they weren't used in the first place so there is no reason
3247         to try and use them again if a failure happened.
3248         * Scripts/webkitpy/common/net/credentials_unittest.py: Added unit test for newly added
3249         use_stored_credentials argument.
3250         (test_do_not_use_stored_credentials): Added unit test to make sure functions that
3251         retrieve username/password information from the local system (environment, Git, keychain,
3252         keyring) are never called. It also tests that we get back our mocked username and password.
3253         (test_do_not_use_stored_credentials.MockKeyring): Mock keyring
3254         (test_do_not_use_stored_credentials.MockKeyring.get_password): Assert this is never called.
3255         (test_do_not_use_stored_credentials.FakeCredentials): Mock credentials
3256         (test_do_not_use_stored_credentials.FakeCredentials._credentials_from_keychain): Assert this
3257         is never called.
3258         (test_do_not_use_stored_credentials.FakeCredentials._credentials_from_environment): Ditto
3259         (test_do_not_use_stored_credentials.FakeCredentials._offer_to_store_credentials_in_keyring): Ditto
3260         (test_do_not_use_stored_credentials.FakeUser): Mock the User class
3261         (test_do_not_use_stored_credentials.FakeUser.prompt): Returns a username to assert against.
3262         (test_do_not_use_stored_credentials.FakeUser.prompt_password): Returns a password to assert
3263         against.
3264
3265 2015-07-16  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3266
3267         Unreviewed, remove my redundant email information.
3268
3269         * Scripts/webkitpy/common/config/contributors.json:
3270
3271 2015-07-16  Hyungwook Lee  <hyungwook.lee@navercorp.com>
3272
3273         Unreviewed. Add Hyungwook Lee as a committer.
3274
3275         * Scripts/webkitpy/common/config/contributors.json:
3276
3277 2015-07-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3278
3279         Added myself to the list of contributors.
3280
3281         Reviewed by Brent Fulgham.
3282
3283         * Scripts/webkitpy/common/config/contributors.json:
3284
3285 2015-07-16  Alex Christensen  <achristensen@webkit.org>
3286
3287         [Content Extensions] Cache domain actions
3288         https://bugs.webkit.org/show_bug.cgi?id=146817
3289
3290         Reviewed by Benjamin Poulain.
3291
3292         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3293         (TestWebKitAPI::TEST_F):
3294         Test if-domain and unless-domain with multiple load types.
3295
3296 2015-07-16  Benjamin Poulain  <bpoulain@apple.com>
3297
3298         [Content extensions] Combine suffixes when generating NFAs
3299         https://bugs.webkit.org/show_bug.cgi?id=146961
3300
3301         Reviewed by Alex Christensen.
3302
3303         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3304         (TestWebKitAPI::compareContents):
3305         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
3306
3307 2015-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
3308
3309         [GTK] Input method filter is always enabled when the view is focused
3310         https://bugs.webkit.org/show_bug.cgi?id=146965
3311
3312         Reviewed by Martin Robinson.
3313
3314         Use setEnabled() instead of notifyFocusedIn() to enable input methods.
3315
3316         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp:
3317         (TestWebKitAPI::TestInputMethodFilter::TestInputMethodFilter):
3318
3319 2015-07-15  Michael Catanzaro  <mcatanzaro@igalia.com>
3320
3321         [EFL] Bump libseccomp version to 2.2.3
3322         https://bugs.webkit.org/show_bug.cgi?id=146980
3323
3324         Reviewed by Gyuyoung Kim.
3325
3326         * efl/jhbuild.modules:
3327
3328 2015-07-15  Brent Fulgham  <bfulgham@apple.com>
3329
3330         [Win] Maintain consistent COM Interfaces
3331         https://bugs.webkit.org/show_bug.cgi?id=146983
3332         <rdar://problem/21822278>
3333
3334         Reviewed by Dean Jackson.
3335
3336         Update DumpRenderTree and WinLauncher to use the properly
3337         versioned COM interface objects.
3338
3339         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3340         (AccessibilityController::rootElement):
3341         * DumpRenderTree/win/DumpRenderTree.cpp:
3342         (resetWebPreferencesToConsistentValues):
3343         (resetWebViewToConsistentStateBeforeTesting):
3344         (runTest):
3345         (createWebViewAndOffscreenWindow):
3346         * DumpRenderTree/win/EditingDelegate.cpp:
3347         (EditingDelegate::QueryInterface):
3348         (EditingDelegate::shouldEndEditingInDOMRange):
3349         (EditingDelegate::shouldInsertNode):
3350         * DumpRenderTree/win/EditingDelegate.h:
3351         * DumpRenderTree/win/EventSender.cpp:
3352         (scalePageByCallback):
3353         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3354         (FrameLoadDelegate::didCommitLoadForFrame):
3355         * DumpRenderTree/win/TestRunnerWin.cpp:
3356         (TestRunner::callShouldCloseOnWebView):
3357         (TestRunner::applicationCacheDiskUsageForOrigin):
3358         (TestRunner::clearApplicationCacheForOrigin):
3359         (TestRunner::setDefersLoading):
3360         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
3361         (TestRunner::setTabKeyCyclesThroughElements):
3362         (TestRunner::setValueForUser):
3363         (TestRunner::dispatchPendingLoadRequests):
3364         (TestRunner::setWindowIsKey):
3365         (TestRunner::execCommand):
3366         (TestRunner::addOriginAccessWhitelistEntry):
3367         (TestRunner::removeOriginAccessWhitelistEntry):
3368         (TestRunner::addUserScript):
3369         (TestRunner::addUserStyleSheet):
3370         (TestRunner::showWebInspector):
3371         (TestRunner::closeWebInspector):
3372         (TestRunner::evaluateInWebInspector):
3373         (TestRunner::setSerializeHTTPLoads):
3374         * DumpRenderTree/win/TextInputControllerWin.cpp:
3375         (TextInputController::setMarkedText):
3376         (TextInputController::hasMarkedText):
3377         (TextInputController::unmarkText):
3378         (TextInputController::markedRange):
3379         (TextInputController::insertText):
3380         (TextInputController::firstRectForCharacterRange):
3381         (TextInputController::selectedRange):
3382         * DumpRenderTree/win/UIDelegate.h:
3383         (UIDelegate::unused2):
3384         (UIDelegate::unused3):
3385         (UIDelegate::webViewScrolled):
3386         (UIDelegate::webViewShouldInterruptJavaScript):
3387         (UIDelegate::webViewReceivedFocus):
3388         (UIDelegate::unused4): Deleted.
3389         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
3390         (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
3391         * WinLauncher/PageLoadTestClient.cpp:
3392         (PageLoadTestClient::didStartProvisionalLoad):
3393         * WinLauncher/WinLauncher.cpp:
3394         (WinLauncher::init):
3395         * WinLauncher/WinLauncher.h:
3396         * WinLauncher/WinLauncherWebHost.cpp:
3397         (WinLauncherWebHost::didFinishLoadForFrame):
3398         (WinLauncherWebHost::didFirstLayoutInFrame):
3399         * WinLauncher/WinLauncherWebHost.h:
3400
3401 2015-07-15  Dean Johnson  <dean_johnson@apple.com>
3402
3403         Many test failures in scm_unittest.py
3404         https://bugs.webkit.org/show_bug.cgi?id=143967
3405
3406         Reviewed by Daniel Bates. 
3407
3408         * Scripts/webkitpy/common/checkout/scm/detection.py:
3409         (SCMDetector.detect_scm_system): Paths with symlinks are now resolved to
3410         absolute canonical file paths. Two mutually exclusive issues cause this
3411         to be a problem.
3412             1) Python's os.path.relpath() function does not return correct relative
3413             paths between two filepaths that point to the same file, if symlinks are
3414             involved.
3415                 On Mac, /tmp points to /private/tmp
3416                 ex. os.path.relpath('/tmp', '/private/tmp')
3417                     returns '../../tmp'
3418             What we want is actually just '.'
3419             2) Git does not allow file paths to trace outside of
3420             the Git repository. This means that if you have a repository in
3421             /tmp and you refer to that repository when invoking a git command as
3422             ../tmp, Git will produce errors about working outside of the repository.
3423         * Scripts/webkitpy/common/checkout/scm/git.py: Over time Git has changed
3424         its default behavior and such, needed to be updated.
3425         (Git.changed_files): '--' was added into the command so that patch_directories
3426         were taken as positional arguments.
3427         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Changed tests and setup 
3428         in the GitSVNTest class to more closely emulate the version of Git that the tests
3429         assumed a system had. Also fixed a small side-effect from the absolute canonical
3430         path fix in SCMDetector.detect_scm_system
3431         (SVNTestRepository.setup): A relative filepath was previously passed as the
3432         checkout root to SCMDetector.detect_scm_system, but is now cleaned to
3433         an absolute canonical path before being passed in. The failing test
3434         was a "sanity check" that the svn.checkout_root and scm.checkout_root
3435         were the same.
3436         (GitSVNTest._setup_git_checkout):
3437             1) Added "--prefix ''" option to `git clone` since Git changed its default
3438             behavior in version 2.0.
3439             2) The branch master was renamed to trunk to more closely emulate what
3440             tests expected when they were written. 
3441         (GitSVNTest.test_changed_files_local_plus_working_copy): Two of the three
3442         original tests failed because the tests expected the trunk branch
3443         to produce its parent's commit, whereas Git merely provides the HEAD commit
3444         for a given branch (trunk in this case). Based on other tests written
3445         in the same commit, it appears these tests were failing from the point they
3446         were written.
3447
3448 2015-07-14  Anders Carlsson  <andersca@apple.com>
3449
3450         Assertions.h should include ExportMacros.h
3451         https://bugs.webkit.org/show_bug.cgi?id=146948
3452
3453         Reviewed by Tim Horton.
3454
3455         Remove now unneeded WTF_EXPORT_PRIVATE define.
3456
3457         * DumpRenderTree/cg/ImageDiffCG.cpp:
3458
3459 2015-07-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3460
3461         [GTK] [Wayland] Build by default the X11 and Wayland targets.
3462         https://bugs.webkit.org/show_bug.cgi?id=146057
3463
3464         Reviewed by Carlos Garcia Campos.
3465
3466         * gtk/install-dependencies:
3467
3468 2015-07-10  Brent Fulgham  <bfulgham@apple.com>
3469
3470         [Mac] Unable to dismiss context menu during test runs
3471         https://bugs.webkit.org/show_bug.cgi?id=146836
3472
3473         Reviewed by Tim Horton.
3474
3475         Since Context Menus are modal, the test system would block on the displayed context menu,
3476         causing tests to fail. Instead, we should do what WK1 was doing, which is to perform the
3477         mouse click and generate the menu contents, but not ask AppKit to display it.
3478
3479         Drive-by fix: We did not handle 'escape' key presses. This is also fixed.
3480
3481         * DumpRenderTree/mac/EventSendingController.mm:
3482         (-[EventSendingController keyDown:withModifiers:withLocation:]): Handle the 'escape' character.
3483         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3484         (WTR::EventSendingController::mouseMoveTo): Keep track of the current mouse position.
3485         (WTR::EventSendingController::contextClick): Don't emit an actual context menu invocation and then
3486         copy the menu items. Instead, use WKBundlePageCopyContentMenuAtPointInWindow to do all the same
3487         work without actually calling on AppKit to display the menu.
3488         ask WebCore to do all the work EXCEPT displaying the menu.
3489         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3490         * WebKitTestRunner/mac/EventSenderProxy.mm:
3491         (WTR::EventSenderProxy::keyDown): Handle the 'escape' character.
3492
3493 2015-07-09  Filip Pizlo  <fpizlo@apple.com>
3494
3495         It should be possible to run the OSR exit fuzzer
3496         https://bugs.webkit.org/show_bug.cgi?id=146814
3497
3498         Reviewed by Mark Lam.
3499         
3500         This runs a test command to detect how many static OSR exit sites it had, and then for
3501         each exit site, it triggers three exits (earliest opportunity, last opportunity, some
3502         middle opportunity), plus a mode where the check always exits. This is an exhaustive
3503         search, so in the future it'll be very appropriate for cases where we have a simple test
3504         and we want to see what happens when you eventually exit in this test.
3505         
3506         Right now this isn't hooked into any specific tests, but I've done some spot checks on it
3507         and it seems to do the right thing.
3508
3509         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz: Added.
3510         (fail):
3511
3512 2015-07-10  Alex Christensen  <achristensen@webkit.org>
3513
3514         Add tests for r186649
3515         https://bugs.webkit.org/show_bug.cgi?id=146821
3516
3517         Reviewed by Darin Adler.
3518
3519         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3520         (TestWebKitAPI::TEST_F):
3521         (TestWebKitAPI::compareContents):
3522         (TestWebKitAPI::expectedIndex):
3523         Add some larger tests to test large jumps.
3524
3525 2015-07-09  Dewei Zhu  <dewei_zhu@apple.com>
3526
3527         Quick fix for run_benchmark script that AppKit.NSRunningApplication does not work properly
3528         https://bugs.webkit.org/show_bug.cgi?id=146820
3529
3530         Reviewed by Ryosuke Niwa.
3531
3532         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3533         (OSXBrowserDriver):
3534         (OSXBrowserDriver.close_browsers):
3535         (OSXBrowserDriver._terminiate_processes):
3536         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
3537         (OSXChromeDriver):
3538         (OSXChromeCanaryDriver):
3539         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
3540         (OSXFirefoxDriver):
3541         (OSXFirefoxNightlyDriver):
3542         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3543         (OSXSafariDriver):
3544
3545 2015-07-09  Michael Catanzaro  <mcatanzaro@igalia.com>
3546
3547         [GTK] pango should be included in the default jhbuild moduleset
3548         https://bugs.webkit.org/show_bug.cgi?id=146683
3549
3550         Reviewed by Martin Robinson.
3551
3552         Recent releases of pango 1.36 use functions that are only provided by fontconfig 2.12 when
3553         compiled against sufficiently-new versions of fontconfig. Since we depend on both pango and
3554         fontconfig, and pango depends on fontconfig, we must either add pango to our jhbuild
3555         moduleset or else upgrade fontconfig to a recent unstable release (knowing that we will have
3556         the same problem again the next time pango wants to use a new fontconfig feature), or remove
3557         fontconfig (which would make it hard to keep tests working). On the balance, adding pango is
3558         best.
3559
3560         * gtk/jhbuild-optional.modules: Remove pango
3561         * gtk/jhbuild.modules: Add pango and update to latest 1.36.8
3562
3563 2015-07-09  Devin Rousso  <drousso@apple.com>
3564
3565         Unreviewed.  Added myself as a committer.
3566
3567         * Scripts/webkitpy/common/config/contributors.json:
3568
3569 2015-07-09  Timothy Horton  <timothy_horton@apple.com>
3570
3571         Add a way to set the default URL from Minibrowser UI
3572         https://bugs.webkit.org/show_bug.cgi?id=146780
3573
3574         Reviewed by Simon Fraser.
3575
3576         * MiniBrowser/mac/AppDelegate.m:
3577         (-[BrowserAppDelegate didChangeSettings]):
3578         * MiniBrowser/mac/BrowserWindowController.h:
3579         * MiniBrowser/mac/BrowserWindowController.m:
3580         (-[BrowserWindowController fetch:]):
3581         (-[BrowserWindowController reload:]):
3582         (-[BrowserWindowController forceRepaint:]):
3583         (-[BrowserWindowController goBack:]):
3584         (-[BrowserWindowController goForward:]):