WPT server should be able to do logging even if its output folder is not created...
[WebKit-https.git] / Tools / ChangeLog
1 2017-08-14  Youenn Fablet  <youenn@apple.com>
2
3         WPT server should be able to do logging even if its output folder is not created at launch time
4         https://bugs.webkit.org/show_bug.cgi?id=175543
5
6         Reviewed by Alexey Proskuryakov.
7
8         Removing no longer used stdout/stderr member variables.
9         Creating if needed the output folder so that we can create WPT server output log folder at WPT server launch time.
10
11         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
12         (WebPlatformTestServer.__init__):
13         (WebPlatformTestServer._prepare_config):
14         (WebPlatformTestServer._spawn_process):
15         (WebPlatformTestServer._stop_running_server):
16
17 2017-08-14  Daniel Bates  <dabates@apple.com>
18
19         webkit-patch: Passing --no-review should submit patch to EWS by default
20         https://bugs.webkit.org/show_bug.cgi?id=148899
21
22         Reviewed by David Kilzer.
23
24         Make "webkit-patch upload --no-review" and "webkit-patch post-commits --no-review" submit
25         the patch(es) for EWS analysis by default. Add a new optional command line argument, --no-ews,
26         to these commands to not submit a non-reviewed patch(es) for EWS analysis.
27
28         Frequently I want to post a draft of a patch without review to have the EWS bots process
29         it to catch build and test breakage before I clean it up and post it for formal review.
30         Currently this requires using "webkit-patch upload --no-review --open-bug" to upload the
31         patch and open the bug in Safari so that I can click the Submit for EWS analysis button.
32         We should teach "webkit-patch upload" and "webkit-patch post-commits" how to do this.
33
34         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
35         (Bugzilla._parse_attachment_id_from_add_patch_to_bug_response): Add helper function to
36         parse the attachment id from the response page after adding an attachment to the bug.
37         (Bugzilla.add_patch_to_bug): Modified to parse and return the attachment id from the
38         HTTP response after uploading the patch.
39         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
40         (MockBugzilla.add_patch_to_bug): Return a dummy attachment id for testing purposes.
41         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
42         (test__parse_attachment_id_from_add_patch_to_bug_response): Added.
43         * Scripts/webkitpy/tool/commands/upload.py:
44         (Upload): Add step SubmitToEWS to the list of steps when uploading a patch. 
45         (PostCommits.__init__): Add --no-ews option to the list of applicable option flags for
46         this command.
47         (PostCommits.execute): Submit the patch to EWS, if applicable.
48         * Scripts/webkitpy/tool/commands/upload_unittest.py:
49         (test_upload): Set options.ews to False as the upload command expects this option
50         to be specified.
51         (test_upload_with_no_review_and_ews): Added.
52         * Scripts/webkitpy/tool/steps/__init__.py: Import module SubmitToEWS.
53         * Scripts/webkitpy/tool/steps/options.py:
54         (Options): Added command line option --no-ews (defaults: False - submit to EWS).
55         * Scripts/webkitpy/tool/steps/postdiff.py:
56         (PostDiff.options): Add --no-ews option to the list of applicable option flags for
57         this command.
58         (PostDiff.run): Submit the patch to EWS, if applicable.
59         * Scripts/webkitpy/tool/steps/submittoews.py: Added.
60         (SubmitToEWS):
61         (SubmitToEWS.options): Return an empty array as we this step does not have any command line options.
62         (SubmitToEWS.run): Submit the specified attachment ids for EWS analysis.
63
64 2017-08-14  Ryan Haddad  <ryanhaddad@apple.com>
65
66         Disable two flaky VideoControlsManager API tests.
67
68         Unreviewed test gardening.
69
70         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
71         (TestWebKitAPI::TEST):
72
73 2017-08-14  Tim Horton  <timothy_horton@apple.com>
74
75         Only create directory and sandbox extension handle for storage directories if they are set
76         https://bugs.webkit.org/show_bug.cgi?id=175522
77
78         Reviewed by Brady Eidson.
79
80         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
81         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDoesNotLogDuringInitialization.mm: Added.
82         (TEST):
83         Add a test that making a WKWebView with an ephemeral WKWebsiteDataStore
84         doesn't log anything to stderr.
85
86 2017-08-14  Jonathan Bedard  <jbedard@apple.com>
87
88         sub-categorize Sandbox violation logs
89         https://bugs.webkit.org/show_bug.cgi?id=175536
90         <rdar://problem/33834416>
91
92         Reviewed by David Kilzer.
93
94         * Scripts/webkitpy/common/system/crashlogs.py:
95         (CrashLogs._parse_darwin_crash_log): Add 'Sandbox-' to the log name if the log is
96         a Sandbox violation.
97         (CrashLogs._find_all_logs_darwin): Update comment.
98         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
99         (make_mock_sandbox_report_darwin): Create a Sandbox violation log for testing. 
100         (CrashLogsTest.create_crash_logs_darwin): Add Sandbox violation to list of crashes.
101         (CrashLogsTest.test_find_all_log_darwin): 8 logs in testing instead of 7.
102         (CrashLogsTest.test_duplicate_log_darwin): Check for Sandbox violation log.
103         * Scripts/webkitpy/port/darwin.py:
104         (DarwinPort._merge_crash_logs): Handle Sandbox violation case.
105
106 2017-08-14  Daniel Bates  <dabates@apple.com>
107
108         Add Automator service to copy permalink to Clipboard
109         https://bugs.webkit.org/show_bug.cgi?id=170978
110
111         Reviewed by Joseph Pecoraro.
112
113         It is helpful to reference using a hyperlink a particular line of code when having
114         a discussion on IRC or in a bug. You can get such a link by navigating to the file
115         in the Trac Browse Source viewer and selecting the line your are interested in.
116         I found myself doing this often enough that I wrote an Automator service to do it
117         for me.
118
119         This Automator service works with Xcode 8 and Xcode 9 beta 5 (9M202q) or later.
120
121         * CopyPermalink/Copy WebKit Permalink.workflow/Contents/Info.plist: Added.
122         * CopyPermalink/Copy WebKit Permalink.workflow/Contents/document.wflow: Added.
123         * CopyPermalink/README: Added.
124
125 2017-08-14  Chris Dumez  <cdumez@apple.com>
126
127         Address flakiness related to download tests
128         https://bugs.webkit.org/show_bug.cgi?id=175338
129         <rdar://problem/33865119>
130
131         Unreviewed, forgot in r220626 to reset m_shouldLogDownloadCallbacks to false
132         between tests.
133
134         * WebKitTestRunner/TestController.cpp:
135         (WTR::TestController::resetStateToConsistentValues):
136
137 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
138
139         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
140         https://bugs.webkit.org/show_bug.cgi?id=175474
141         <rdar://problem/33844628>
142
143         Reviewed by Wenson Hsieh.
144
145         Enable dataTransfer.items by default in DumpRenderTree and WebKitTestRunner for testing purposes.
146
147         * DumpRenderTree/mac/DumpRenderTree.mm:
148         (resetWebPreferencesToConsistentValues):
149         * WebKitTestRunner/TestController.cpp:
150         (WTR::TestController::resetPreferencesToConsistentValues):
151
152 2017-08-12  Chris Dumez  <cdumez@apple.com>
153
154         Address flakiness related to download tests
155         https://bugs.webkit.org/show_bug.cgi?id=175338
156
157         Reviewed by Ryosuke Niwa.
158
159         - Update WKTR so that the flag set by testRunner.waitUntilDownloadFinished()
160           is actually queried when a download completes. Previously, this would be
161           identical to a call to testRunner.waitUntilDone() because any download
162           completion would call testRunner.notifyDone().
163         - Disable logging of download callbacks by default and add a
164           testRunner.setShouldLogDownloadCallbacks(true) API to allow tests to
165           enable such logging.
166
167         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
168         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
169         (WTR::InjectedBundle::didReceiveMessageToPage):
170         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
171         (WTR::TestRunner::setShouldLogDownloadCallbacks):
172         * WebKitTestRunner/InjectedBundle/TestRunner.h:
173         * WebKitTestRunner/TestController.cpp:
174         (WTR::TestController::downloadDidStart):
175         (WTR::TestController::decideDestinationWithSuggestedFilename):
176         (WTR::TestController::downloadDidFinish):
177         (WTR::TestController::downloadDidFail):
178         (WTR::TestController::downloadDidCancel):
179         * WebKitTestRunner/TestController.h:
180         (WTR::TestController::setShouldLogDownloadCallbacks):
181         * WebKitTestRunner/TestInvocation.cpp:
182         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
183
184 2017-08-11  Jonathan Bedard  <jbedard@apple.com>
185
186         Create mock ITP data in testing to prevent grandfathering
187         https://bugs.webkit.org/show_bug.cgi?id=174720
188
189         Unreviewed follow-up fix for r220604.
190
191         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
192         (WTR::TestController::cocoaPlatformInitialize): Release resourceLogPlist.
193
194 2017-08-11  Jonathan Bedard  <jbedard@apple.com>
195
196         Create mock ITP data in testing to prevent grandfathering
197         https://bugs.webkit.org/show_bug.cgi?id=174720
198         <rdar://problem/33457779>
199
200         Reviewed by Brent Fulgham.
201
202         We don't need to be triggering grandfathering when each test runner starts. On Mac,
203         this may launch plugins which can cause layout tests to fail later if the test
204         runner does not shut-down before the plugins unload.
205
206         * WebKitTestRunner/TestController.h: Add declaration of cocoaPlatformInitialize.
207         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
208         (WTR::TestController::cocoaPlatformInitialize): Write the minimum data required to
209         prevent grandfathering from being triggered.
210         * WebKitTestRunner/ios/TestControllerIOS.mm:
211         (WTR::TestController::platformInitialize): Call cocoaPlatformInitialize.
212         * WebKitTestRunner/mac/TestControllerMac.mm:
213         (WTR::TestController::platformInitialize): Ditto.
214
215 2017-08-11  Sam Weinig  <sam@webkit.org>
216
217         WTF::Function does not allow for reference / non-default constructible return types
218         https://bugs.webkit.org/show_bug.cgi?id=175244
219         <rdar://problem/33801582>
220
221         Reviewed by Chris Dumez.
222
223         * TestWebKitAPI/Tests/WTF/Function.cpp:
224         (TestWebKitAPI::TEST):
225
226 2017-08-11  Carlos Garcia Campos  <cgarcia@igalia.com>
227
228         [Soup] Cannot access HTTPS sites using a HTTP proxy that requires authentication
229         https://bugs.webkit.org/show_bug.cgi?id=175378
230
231         Reviewed by Sergio Villar Senin.
232
233         Add two test cases to check proxy authentication.
234
235         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
236         (Tunnel::Tunnel):
237         (Tunnel::~Tunnel):
238         (Tunnel::connect):
239         (Tunnel::connected):
240         (serverCallback):
241         (ProxyAuthenticationTest::ProxyAuthenticationTest):
242         (ProxyAuthenticationTest::~ProxyAuthenticationTest):
243         (ProxyAuthenticationTest::proxyServerPortAsString):
244         (testWebViewAuthenticationProxy):
245         (testWebViewAuthenticationProxyHTTPS):
246         (beforeAll):
247
248 2017-08-11  Xabier Rodriguez Calvar  <calvaris@igalia.com>
249
250         [GStreamer][GTK][WPE] Unify GStreamer JHBuild moduleset for both GTK+ and WPE
251         https://bugs.webkit.org/show_bug.cgi?id=175428
252
253         Both ports share the GStreamer code as multimedia backend and till
254         not so long they were using different versions. Now they do use
255         the same versions and it does not make any sense anymore (and
256         neither had sense before) to have differences in the modulesets.
257
258         In this patch I created a GStreamer moduleset and referenced it
259         from both GTK+'s and WPE's. GStreamer patches were also moved there.
260
261         Reviewed by Žan Doberšek.
262
263         * gstreamer/jhbuild.modules: Added.
264         * gstreamer/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch.
265         * gstreamer/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch.
266         * gstreamer/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch.
267         * gstreamer/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch.
268         * gstreamer/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Renamed from Tools/gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch.
269         * gstreamer/patches/openh264-configure.patch: Renamed from Tools/gtk/patches/openh264-configure.patch.
270         * gtk/jhbuild.modules:
271         * wpe/jhbuild.modules:
272         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Removed.
273         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Removed.
274         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
275         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
276         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Removed.
277
278 2017-08-10  Don Olmstead  <don.olmstead@sony.com>
279
280         Unreviewed, adding Ross Kirsling to contributors.json
281
282         * Scripts/webkitpy/common/config/contributors.json:
283
284 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
285
286         Unreviewed, attempt to fix build failure with VC2017
287
288         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
289         (TEST):
290
291 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
292
293         Unreviewed, suppress warnings on GCC
294
295         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
296         (TestWebKitAPI::CheckedArithmeticTester::run):
297
298 2017-08-10  Dan Bernstein  <mitz@apple.com>
299
300         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
301         https://bugs.webkit.org/show_bug.cgi?id=173223
302
303         Reviewed by Tim Horton.
304
305         The rebuilds were happening due to a difference in the compiler options that the IDE and
306         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
307         xcodebuild pass that option, too, set INDEX_ENABLE_DATA_STORE to YES and
308         INDEX_DATA_STORE_DIR to the Index Datastore path specified in Xcode Locations preferences >
309         Advanced when a Custom Absolute path is selected.
310
311         * Scripts/webkitdirs.pm:
312         (determineBaseProductDir):
313
314 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
315
316         Run more WTF tests
317         https://bugs.webkit.org/show_bug.cgi?id=174970
318
319         Reviewed by Michael Catanzaro.
320
321         Some of WTF tests are not executed in non Apple ports while they are generic ones.
322         This patch adds these tests to non-Apple port TestWebKitAPI.
323         Currently, we do not add Signals.cpp since it depends on signal functionality.
324
325         * TestWebKitAPI/CMakeLists.txt:
326         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
327         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
328         (isHigherPriority):
329         (TEST):
330         * TestWebKitAPI/Tests/WTF/Signals.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/ThreadMessages.cpp.
331         (TEST):
332         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
333         (TEST):
334
335 2017-08-10  obinna obike  <oobike@apple.com>
336
337         Remove obsolete link from webkit-queues status page
338         https://bugs.webkit.org/show_bug.cgi?id=175337
339
340         Reviewed by Aakash Jain.
341
342         * QueueStatusServer/templates/recentstatus.html:
343         Removed the link to the ews-watcher server.
344
345 2017-08-10  Brian Burg  <bburg@apple.com>
346
347         WKPreferences should conform to NSCopying
348         https://bugs.webkit.org/show_bug.cgi?id=175303
349         <rdar://problem/33764939>
350
351         Reviewed by Dan Bernstein.
352
353         Add unit test to make sure a WKPreference and its copy are
354         not aliased to each other or affect each other's properties.
355
356         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
357         * TestWebKitAPI/Tests/WebKit2Cocoa/Copying.mm: Added.
358         (TEST):
359
360 2017-08-10  Tim Horton  <timothy_horton@apple.com>
361
362         Remove some unused lambda captures so that WebKit builds with -Wunused-lambda-capture
363         https://bugs.webkit.org/show_bug.cgi?id=175436
364         <rdar://problem/33667497>
365
366         Reviewed by Simon Fraser.
367
368         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
369         (TestWebKitAPI::TEST_F):
370
371 2017-08-10  Lucas Forschler  <lforschler@apple.com>
372
373         Fix duplicated code in r220534.
374
375         Unreviewed cleanup.
376
377         * Scripts/bisect-builds:
378
379 2017-08-08  Jiewen Tan  <jiewen_tan@apple.com>
380
381         [WebCrypto] Enable SerializedCryptoKeyWrapTest in iOS
382         https://bugs.webkit.org/show_bug.cgi?id=175344
383         <rdar://problem/28507240>
384
385         Reviewed by Alexey Proskuryakov.
386
387         Add entitlements to TestWebKitAPI project for iOS. Then add Keychain Access entitlement to the project.
388         Finally enable the existing tests for iOS.
389
390         * TestWebKitAPI/Configurations/TestWebKitAPI-iOS.entitlements: Added.
391         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
392         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
393         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm:
394
395 2017-08-10  Lucas Forschler  <lforschler@apple.com>
396
397         Write a tool to bisect WebKit builds
398         https://bugs.webkit.org/show_bug.cgi?id=174596
399
400         Reviewed by Dean Johnson and Kocsen Chung.
401
402         * Scripts/bisect-builds: Added.
403         (bisect_builds): main bisection algorithm
404         (download_archive):download an archive from S3 using existing tools
405         (extract_archive):extract an archive using existing tools
406         (find_le):Find rightmost value less than or equal to x
407         (find_ge):Find leftmost item greater than or equal to x
408         (get_api_url):generate url for the rest api/database
409         (get_indices_from_revisions):convert revisions to list indexes for bisection
410         (get_sorted_revisions):retrieve sorted revision list
411         (get_s3_location_for_revision):calculate the S3 archive storage location
412         (parse_args):parse command line arguments
413         (pick_next_build):compute the next build to bisect
414         (prompt_did_reproduce):prompt user for direction for bisection
415         (set_webkit_output_dir):set the folder for bisected builds to avoid overwriting engineering build output
416         (test_archive):Platform specific logic to test downloaded archive
417         (minified_platforms):return a list of minified platforms in the database
418         (unminified_platforms):return a list of full platforms in the database
419         (is_supported_platform):check if platform is supported
420         (validate_options):validate command line options
421         (main):
422
423 2017-08-10  Lucas Forschler  <lforschler@apple.com>
424
425         Remove bisect-builds script.
426         https://bugs.webkit.org/show_bug.cgi?id=175433
427         
428         Reviewed by Aakash Jain.
429
430         * Scripts/bisect-builds: Removed.
431
432 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
433
434         Remove ENABLE_GAMEPAD_DEPRECATED
435         https://bugs.webkit.org/show_bug.cgi?id=175361
436
437         Reviewed by Carlos Garcia Campos.
438
439         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
440
441 2017-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
442
443         REGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie
444         https://bugs.webkit.org/show_bug.cgi?id=175426
445
446         Reviewed by Carlos Garcia Campos.
447
448         * gtk/install-dependencies: libgeoclue-dev packages not really needed on Debian/Ubuntu.
449
450 2017-08-10  Ms2ger  <Ms2ger@igalia.com>
451
452         Add Ms2ger as contributor.
453         https://bugs.webkit.org/show_bug.cgi?id=175325
454
455         Reviewed by Carlos Alberto Lopez Perez.
456
457         * Scripts/webkitpy/common/config/contributors.json:
458
459 2017-08-09  Dewei Zhu  <dewei_zhu@apple.com>
460
461         Fix run-benchmark after r220483.
462         https://bugs.webkit.org/show_bug.cgi?id=175415
463         <rdar://problem/33803003>
464
465         Reviewed by Ryosuke Niwa.
466
467         Update run-benchmark script to adapt new Timeout implementation introduced in r220483.
468
469         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
470         (WebServerBenchmarkRunner._run_one_test):
471
472 2017-08-09  Chris Dumez  <cdumez@apple.com>
473
474         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
475         https://bugs.webkit.org/show_bug.cgi?id=175401
476
477         Reviewed by Brady Eidson.
478
479         * DumpRenderTree/mac/DumpRenderTree.mm:
480         (enableExperimentalFeatures):
481
482 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
483
484         [PAL] Move spi/cocoa and spi/cg directories into PAL
485         https://bugs.webkit.org/show_bug.cgi?id=175175
486
487         Reviewed by Myles C. Maxfield.
488
489         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
490         * DumpRenderTree/mac/DumpRenderTree.mm:
491         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm:
492         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
493
494         * Scripts/webkitpy/style/checker.py:
495         * Scripts/webkitpy/style/checker_unittest.py:
496         (GlobalVariablesTest.test_path_rules_specifier):
497
498         Add path rules specifiers for PassKitSPI.h and DataDetectorsCoreSPI.h
499
500         * Scripts/webkitpy/style/checkers/cpp.py:
501         (check_braces):
502         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
503         (WebKitStyleTest.test_braces.CF_OPTIONS):
504         (WebKitStyleTest.test_braces):
505
506         Prevent CF_OPTIONS() from being handled as funtion definition.
507
508 2017-08-09  Don Olmstead  <don.olmstead@sony.com>
509
510         [WTF] Move TextStream into WTF
511         https://bugs.webkit.org/show_bug.cgi?id=175211
512
513         Reviewed by Myles C. Maxfield.
514
515         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
516
517 2017-08-09  Andy Estes  <aestes@apple.com>
518
519         Part 3 of: Rename DatabaseProcess to StorageProcess
520         https://bugs.webkit.org/show_bug.cgi?id=175034
521
522         Reviewed by Brady Eidson.
523
524         * WebKitTestRunner/TestController.cpp:
525         (WTR::TestController::databaseProcessName): Updated to return
526         "com.apple.WebKit.Storage.Development" on macOS and iOS Simulator.
527
528 2017-08-09  Commit Queue  <commit-queue@webkit.org>
529
530         Unreviewed, rolling out r220466, r220477, and r220487.
531         https://bugs.webkit.org/show_bug.cgi?id=175411
532
533         This change broke existing API tests and follow up fixes did
534         not resolve all the issues. (Requested by ryanhaddad on
535         #webkit).
536
537         Reverted changesets:
538
539         https://bugs.webkit.org/show_bug.cgi?id=175244
540         http://trac.webkit.org/changeset/220466
541
542         "WTF::Function does not allow for reference / non-default
543         constructible return types"
544         https://bugs.webkit.org/show_bug.cgi?id=175244
545         http://trac.webkit.org/changeset/220477
546
547         https://bugs.webkit.org/show_bug.cgi?id=175244
548         http://trac.webkit.org/changeset/220487
549
550 2017-08-09  Sam Weinig  <sam@webkit.org>
551
552         Update for https://bugs.webkit.org/show_bug.cgi?id=175244.
553
554         Remove one addition of null Function test.
555
556 2017-08-09  Jonathan Bedard  <jbedard@apple.com>
557
558         Allow nested timeouts in webkitpy
559         https://bugs.webkit.org/show_bug.cgi?id=175390
560         <rdar://problem/33803003>
561
562         Reviewed by David Kilzer.
563
564         We need to be able to nest timeouts in webkitpy. In particular, we have a few cases where functions
565         which use timeouts also call the executive. For on-device testing, we need to have timeouts inside
566         the executive to detect and recover from any issues connecting with devices.
567
568         * Scripts/webkitpy/benchmark_runner/utils.py:
569         (TimeoutError): Deleted.
570         (timeout): Deleted.
571         * Scripts/webkitpy/common/timeout_context.py: Added.
572         (Timeout): A timeout context designed to be nested.
573         (Timeout.TimeoutData): The data required to construct an alarm for a given timeout.
574         (Timeout.TimeoutData.__init__):
575         (Timeout.default_handler): Timeout handler used if none is specified.
576         (Timeout.current): Access data about the most urgent timeout.
577         (Timeout.__init__): Construct a Timeout object with seconds and an optional handler.
578         (Timeout._bind_timeout_data_to_alarm): Given data about a timeout, initialize an alarm for that timeout.
579         (Timeout.__enter__): Un-bind all alarms. Add data for this timeout to the ordered list and bind the most
580         urgent timeout data.
581         (Timeout.__exit__): Un-bind all alarms. Remove data for this timeout from the ordered list and bind the
582         most urgent timeout data, if such data exists.
583         * Scripts/webkitpy/common/timeout_context_unittest.py: Added.
584         (TimeoutContextTests):
585         (TimeoutContextTests.test_current_timeout): Test that accessing the nearest timeout works as expected.
586         (TimeoutContextTests.test_invalid_timeout): Test a timeout of 0.
587         (TimeoutContextTests.test_timeout_data): Confirm that timeouts are constructed correctly.
588         (TimeoutContextTests.test_nested_inner_precedence): Check that a more urgent inner timeout takes precedence
589         over a less urgent outer timeout.
590         (TimeoutContextTests.test_nested_outer_precedence): Check that a more urgent outer timeout takes precedence
591         over a less urgent inner timeout.
592         (TimeoutContextTests.test_no_timeout): Test a block of code without a timeout.
593         (TimeoutContextTests.test_basic_timeout): Test a block of code expected to timeout.
594         (TimeoutContextTests.test_exception_constructor_timeout): Test a timeout where the handler is an exception.
595         (TimeoutContextTests.test_nested_inner_timeout): Confirm that a more urgent inner timeout is triggered.
596         (TimeoutContextTests.test_nested_outer_timeout): Confirm that a more urgent outer timeout is triggered.
597         * Scripts/webkitpy/port/simulator_process.py:
598         (SimulatorProcess._start): Use Timeout class.
599         * Scripts/webkitpy/xcode/simulated_device.py:
600         (SimulatedDevice.launch_app._log_debug_error): Use Timeout class.
601         (SimulatedDevice.launch_app): Ditto.
602         (SimulatedDevice.launch_app._install_timeout): Deleted.
603         * Scripts/webkitpy/xcode/simulator.py:
604         (Simulator.wait_until_device_is_booted):Use Timeout class.
605         (Simulator.wait_until_device_is_in_state): Ditto.
606
607 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
608
609         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
610         https://bugs.webkit.org/show_bug.cgi?id=175392
611         <rdar://problem/33783207>
612
613         Reviewed by Tim Horton and Megan Gardner.
614
615         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
616
617         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
618
619 2017-08-09  Sam Weinig  <sam@webkit.org>
620
621         Update for https://bugs.webkit.org/show_bug.cgi?id=175244.
622
623         * TestWebKitAPI/Tests/WTF/Function.cpp:
624         Remove tests of null Functions, as they are no longer supported.
625
626 2017-08-09  Daniel Bates  <dabates@apple.com>
627
628         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
629         https://bugs.webkit.org/show_bug.cgi?id=175247
630         <rdar://problem/33679804>
631
632         Reviewed by Brady Eidson.
633
634         Add tests for redirects.
635
636         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
637         (TEST):
638         * TestWebKitAPI/cocoa/TestProtocol.mm:
639         (createRedirectURL):
640         (-[TestProtocol startLoading]):
641
642 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
643
644         Unreviewed, rolling out r220393.
645
646         This patch regresses the performance of WebPage::editorState.
647
648         Reverted changeset:
649
650         "[iOS WK2] WKWebView schedules nonstop layout after pressing
651         cmb+b,i,u inside a contenteditable div"
652         https://bugs.webkit.org/show_bug.cgi?id=175116
653         http://trac.webkit.org/changeset/220393
654
655 2017-08-08  obinna obike  <oobike@apple.com>
656
657         Created Individual EWS Pages
658         https://bugs.webkit.org/show_bug.cgi?id=174477
659
660         Reviewed by Aakash Jain.
661
662         Created individual pages for each EWS. Changed the link within each status bubble
663         to go directly to the individual EWS page. Also added a link to original status page showing all EWSes.
664
665         * QueueStatusServer/handlers/patch.py:
666         (Patch.get): Handles the case for individual ews queue as well as for all EWS queues.
667         * QueueStatusServer/handlers/statusbubble.py:
668         (StatusBubble._build_bubble): Updated url for specific EWS.
669         * QueueStatusServer/main.py: Added a link to the individual ews in the routes dictionary.
670         * QueueStatusServer/templates/patch.html: Added a link to go directly to the page with
671         all ews queues.
672         * QueueStatusServer/templates/statusbubble.html: If you click on a statusbubble it
673         takes you directly to the individual ews page.
674
675 2017-08-08  Stephan Szabo  <stephan.szabo@sony.com>
676
677         Separate jsc stress test script writer from run-jsc-stress-tests
678         https://bugs.webkit.org/show_bug.cgi?id=175216
679
680         Reviewed by Mark Lam.
681
682         * Scripts/run-jsc-stress-tests:
683         * Scripts/webkitruby/jsc-stress-test-writer-default.rb: Added.
684
685 2017-08-08  Michael Catanzaro  <mcatanzaro@igalia.com>
686
687         Unreviewed, fix Ubuntu LTS build
688         https://bugs.webkit.org/show_bug.cgi?id=174490
689
690         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
691
692 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
693
694         [Mac WK2] WebViewImpl should hold a weak pointer to its WKWebView or WKView
695         https://bugs.webkit.org/show_bug.cgi?id=175302
696         <rdar://problem/33762116>
697
698         Reviewed by Tim Horton.
699
700         Adds a new unit test checking that delayed event processing in text input context does not cause unwanted behaviors.
701         See WebKit ChangeLog for more details.
702
703         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
704         * TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h: Renamed from Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h.
705         * TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm.
706         (-[SlowTextInputContext handleEventByInputMethod:completionHandler:]):
707         (-[SlowTextInputContext handleEvent:completionHandler:]):
708         (-[SlowInputWebView inputContext]):
709         (-[SlowInputWebView _web_superInputContext]):
710         (TEST):
711
712 2017-08-08  John Wilander  <wilander@apple.com>
713
714         Resource Load Statistics: Clear web processes' state on history removal
715         https://bugs.webkit.org/show_bug.cgi?id=175271
716         <rdar://problem/33756560>
717
718         Reviewed by Chris Dumez.
719
720         Test infrastructure for asynchronous tests of website data
721         removal for _WKWebsiteDataTypeResourceLoadStatistics.
722
723         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
724         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
725         (WTR::InjectedBundle::didReceiveMessageToPage):
726         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
727         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
728         (WTR::TestRunner::statisticsCallClearThroughWebsiteDataRemovalCallback):
729         * WebKitTestRunner/InjectedBundle/TestRunner.h:
730         * WebKitTestRunner/TestController.cpp:
731         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
732         * WebKitTestRunner/TestController.h:
733         * WebKitTestRunner/TestInvocation.cpp:
734         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
735         (WTR::TestInvocation::didClearStatisticsThroughWebsiteDataRemoval):
736         * WebKitTestRunner/TestInvocation.h:
737         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
738         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
739
740 2017-08-08  Alicia Boya García  <aboya@igalia.com>
741
742         Add Alicia Boya García as contributor
743         https://bugs.webkit.org/show_bug.cgi?id=175326
744
745         Reviewed by Michael Catanzaro.
746
747         * Scripts/webkitpy/common/config/contributors.json:
748
749 2017-08-08  Michael Catanzaro  <mcatanzaro@igalia.com>
750
751         [CMake] Properly test if compiler supports compiler flags
752         https://bugs.webkit.org/show_bug.cgi?id=174490
753
754         Reviewed by Konstantin Tokarev.
755
756         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
757         * MiniBrowser/gtk/CMakeLists.txt:
758         * TestRunnerShared/Bindings/JSWrapper.cpp:
759         (WTR::JSWrapper::initialize):
760         * TestWebKitAPI/CMakeLists.txt:
761         * TestWebKitAPI/PlatformGTK.cmake:
762         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
763         (TestWebKitAPI::CheckedArithmeticTester::run):
764         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
765         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
766         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
767         (formControlsAssociatedCallback):
768         * TestWebKitAPI/glib/CMakeLists.txt:
769         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
770         (Test::getResourcesDir):
771         * WebKitTestRunner/CMakeLists.txt:
772         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
773         (WTR::menuItemClickCallback):
774         (WTR::staticConvertMenuItemToType):
775         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
776         (WTR::TestRunner::setUseDashboardCompatibilityMode):
777         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
778         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
779         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
780         (WTR::AccessibilityUIElement::helpText const):
781         (WTR::AccessibilityUIElement::attributedStringForRange):
782         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
783         (WTR::EventSenderProxy::updateTouchPoint):
784         (WTR::EventSenderProxy::releaseTouchPoint):
785
786 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
787
788         [iOS WK2] WKWebView schedules nonstop layout after pressing cmb+b,i,u inside a contenteditable div
789         https://bugs.webkit.org/show_bug.cgi?id=175116
790         <rdar://problem/28279301>
791
792         Reviewed by Darin Adler and Ryosuke Niwa.
793
794         Introduces new testing infrastructure and API tests to test EditorState updates in the UI process. The new
795         EditorStateTests run on both iOS and Mac.
796
797         * TestWebKitAPI/EditingTestHarness.h: Added.
798         * TestWebKitAPI/EditingTestHarness.mm: Added.
799
800         EditingTestHarness is a helper object that API tests may use to apply editing commands and store EditorState
801         history. This test harness adds sugaring around various editing commands, and simplifies the process of checking
802         the state of the latest observed EditorState.
803
804         (-[EditingTestHarness initWithWebView:]):
805         (-[EditingTestHarness dealloc]):
806         (-[EditingTestHarness webView]):
807         (-[EditingTestHarness latestEditorState]):
808         (-[EditingTestHarness editorStateHistory]):
809         (-[EditingTestHarness insertText:andExpectEditorStateWith:]):
810         (-[EditingTestHarness insertHTML:andExpectEditorStateWith:]):
811         (-[EditingTestHarness selectAllAndExpectEditorStateWith:]):
812         (-[EditingTestHarness moveBackwardAndExpectEditorStateWith:]):
813         (-[EditingTestHarness moveWordBackwardAndExpectEditorStateWith:]):
814         (-[EditingTestHarness toggleBold]):
815         (-[EditingTestHarness toggleItalic]):
816         (-[EditingTestHarness toggleUnderline]):
817         (-[EditingTestHarness setForegroundColor:]):
818         (-[EditingTestHarness alignJustifiedAndExpectEditorStateWith:]):
819         (-[EditingTestHarness alignLeftAndExpectEditorStateWith:]):
820         (-[EditingTestHarness alignCenterAndExpectEditorStateWith:]):
821         (-[EditingTestHarness alignRightAndExpectEditorStateWith:]):
822         (-[EditingTestHarness insertParagraphAndExpectEditorStateWith:]):
823         (-[EditingTestHarness deleteBackwardAndExpectEditorStateWith:]):
824         (-[EditingTestHarness _execCommand:argument:expectEntries:]):
825
826         Dispatches an editing command to the web process, and blocks until a response is received. If an expected
827         entries dictionary is given, this will additionally verify that the latest EditorState contains all the expected
828         keys and values.
829
830         (-[EditingTestHarness latestEditorStateContains:]):
831         (-[EditingTestHarness _webView:editorStateDidChange:]):
832         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
833         * TestWebKitAPI/Tests/WebKit2Cocoa/EditorStateTests.mm: Added.
834         (TestWebKitAPI::setUpEditorStateTestHarness):
835         (TestWebKitAPI::TEST):
836         * TestWebKitAPI/Tests/WebKit2Cocoa/editor-state-test-harness.html: Added.
837
838 2017-08-04  Brent Fulgham  <bfulgham@apple.com>
839
840         Prevent domain from being set to a TLD
841         https://bugs.webkit.org/show_bug.cgi?id=175226
842         <rdar://problem/11079948>
843
844         Reviewed by Chris Dumez.
845
846         Extend the public suffix tests to include cases used by the
847         Public Domain 'Public Suffix List'.
848
849         * TestWebKitAPI/Tests/mac/PublicSuffix.cpp: 
850         (TestWebKitAPI::TEST):
851
852 2017-08-07  Stephan Szabo  <stephan.szabo@sony.com>
853
854         [XCode] webkit-patch should run sort-Xcode-project-file
855         https://bugs.webkit.org/show_bug.cgi?id=174036
856         <rdar://problem/33732709>
857
858         Reviewed by Simon Fraser.
859
860         * Scripts/webkitpy/common/config/ports.py:
861         * Scripts/webkitpy/tool/commands/download.py:
862         * Scripts/webkitpy/tool/commands/download_unittest.py:
863         * Scripts/webkitpy/tool/commands/upload.py:
864         * Scripts/webkitpy/tool/commands/upload_unittest.py:
865         * Scripts/webkitpy/tool/steps/__init__.py:
866         * Scripts/webkitpy/tool/steps/options.py:
867         * Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
868
869 2017-08-07  Devin Rousso  <drousso@apple.com>
870
871         Web Inspector: Preview Canvas path when viewing a recording
872         https://bugs.webkit.org/show_bug.cgi?id=174967
873
874         Reviewed by Brian Burg.
875
876         * DumpRenderTree/TestOptions.h:
877         * DumpRenderTree/TestOptions.mm:
878         (TestOptions::TestOptions):
879         * DumpRenderTree/mac/DumpRenderTree.mm:
880         (setWebPreferencesForTestOptions):
881         * WebKitTestRunner/TestController.cpp:
882         (WTR::TestController::resetPreferencesToConsistentValues):
883         (WTR::updateTestOptionsFromTestHeader):
884         * WebKitTestRunner/TestOptions.h:
885         (WTR::TestOptions::hasSameInitializationOptions const):
886         Add plumbing for new InspectorAdditions runtime flag.
887
888 2017-08-07  obinna obike  <oobike@apple.com>
889
890         Sorted EWS Queues on Patch page
891         https://bugs.webkit.org/show_bug.cgi?id=173667
892
893         Reviewed by Aakash Jain.
894
895         * QueueStatusServer/handlers/patch.py:
896         (Patch.get): Sorted queue_status.
897         * QueueStatusServer/templates/patch.html:
898         Changed queue_status.items to queue_status because it's a list.
899
900 2017-08-07  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
901
902         check-webkit-style: NS_ERROR_ENUM and NS_OPTIONS should not be handled as function definitions.
903         https://bugs.webkit.org/show_bug.cgi?id=175286
904
905         Reviewed by Myles C. Maxfield.
906
907         * Scripts/webkitpy/style/checkers/cpp.py:
908         (check_braces):
909         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
910         (WebKitStyleTest.test_braces.NS_ERROR_ENUM):
911         (WebKitStyleTest.test_braces):
912         (WebKitStyleTest.test_braces.NS_OPTIONS):
913
914 2017-08-07  Brian Burg  <bburg@apple.com>
915
916         Remove CANVAS_PATH compilation guard
917         https://bugs.webkit.org/show_bug.cgi?id=175207
918
919         Reviewed by Sam Weinig.
920
921         * Scripts/webkitperl/FeatureList.pm:
922         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
923
924 2017-08-07  Per Arne Vollan  <pvollan@apple.com>
925
926         [Win] Use Visual Studio 2017 if installed.
927         https://bugs.webkit.org/show_bug.cgi?id=175188
928
929         Reviewed by Sam Weinig.
930
931         If installed, use VS2017 to build WebKit. If not, fall back to VS2015.
932
933         * Scripts/webkitdirs.pm:
934         (visualStudioInstallDir):
935         (msBuildInstallDir):
936
937 2017-08-05  Carlos Garcia Campos  <cgarcia@igalia.com>
938
939         [GTK][WPE] Add API to provide browser information required by automation
940         https://bugs.webkit.org/show_bug.cgi?id=175130
941
942         Reviewed by Michael Catanzaro.
943
944         * MiniBrowser/gtk/main.c:
945         (automationStartedCallback): Set browser information when a new automation session is started.
946         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
947         (testAutomationSessionApplicationInfo):
948         (beforeAll):
949
950 2017-08-06  Ryan Haddad  <ryanhaddad@apple.com>
951
952         Unreviewed, rolling out r220295.
953
954         This change introduced 4 errors in webkitpy tests.
955
956         Reverted changeset:
957
958         "[XCode] webkit-patch should run sort-Xcode-project-file"
959         https://bugs.webkit.org/show_bug.cgi?id=174036
960         http://trac.webkit.org/changeset/220295
961
962 2017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
963
964         Disable API test NowPlayingControlsTests.NowPlayingControlsIOS.
965
966         Unreviewed test gardening.
967
968         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
969         (TestWebKitAPI::TEST):
970
971 2017-08-05  Filip Pizlo  <fpizlo@apple.com>
972
973         REGRESSION (r219895-219897): Number of leaks on Open Source went from 9240 to 235983 and is now at 302372
974         https://bugs.webkit.org/show_bug.cgi?id=175083
975
976         Reviewed by Oliver Hunt.
977         
978         Leaks results are super confusing if leaks runs while some VMs are destructing. This calls a new SPI
979         to wait for VM destructions to finish before running the next test. This makes it easier to 
980         understand leaks results from workers tests, and leads to fewer reported leaks.
981
982         * DumpRenderTree/mac/DumpRenderTree.mm:
983         (runTest):
984
985 2017-08-05  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
986
987         check-webkit-style: fix path-specific rules for WebKit2 rename
988         https://bugs.webkit.org/show_bug.cgi?id=175182
989
990         Reviewed by David Kilzer.
991
992         * Scripts/webkitpy/style/checker.py:
993
994 2017-08-04  Youenn Fablet  <youenn@apple.com>
995
996         [Cache API] Add Cache and CacheStorage IDL definitions
997         https://bugs.webkit.org/show_bug.cgi?id=175201
998
999         Reviewed by Brady Eidson.
1000
1001         * DumpRenderTree/mac/DumpRenderTree.mm:
1002         (enableExperimentalFeatures):
1003         (resetWebPreferencesToConsistentValues):
1004         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1005         (WTR::InjectedBundle::beginTesting):
1006         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1007         (WTR::TestRunner::setCacheAPIEnabled):
1008         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1009
1010 2017-08-04  John Wilander  <wilander@apple.com>
1011
1012         Resource Load Statistics: Report user interaction immediately, but only when needed
1013         https://bugs.webkit.org/show_bug.cgi?id=175090
1014         <rdar://problem/33685546>
1015
1016         Reviewed by Chris Dumez.
1017
1018         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1019         (WTR::InjectedBundle::beginTesting):
1020             Now calls WebCore::ResourceLoadObserver::clearState().
1021
1022 2017-08-04  Tim Horton  <timothy_horton@apple.com>
1023
1024         Add an API test for r220286
1025         https://bugs.webkit.org/show_bug.cgi?id=175206
1026
1027         Reviewed by Simon Fraser.
1028
1029         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1030         (-[AnimatedResizeWebView _webView:didChangeSafeAreaShouldAffectObscuredInsets:]):
1031         (createAnimatedResizeWebView):
1032         (TEST):
1033         Add a test to ensure that we don't call
1034         _webView:didChangeSafeAreaShouldAffectObscuredInsets: during an
1035         animated resize.
1036
1037 2017-08-04  Stephan Szabo  <stephan.szabo@sony.com>
1038
1039         [XCode] webkit-patch should run sort-Xcode-project-file
1040         https://bugs.webkit.org/show_bug.cgi?id=174036
1041
1042         Reviewed by Simon Fraser.
1043
1044         * Scripts/webkitpy/common/config/ports.py:
1045         * Scripts/webkitpy/tool/commands/download.py:
1046         * Scripts/webkitpy/tool/commands/upload.py:
1047         * Scripts/webkitpy/tool/steps/__init__.py:
1048         * Scripts/webkitpy/tool/steps/options.py:
1049         * Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
1050
1051 2017-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1052
1053         REGRESSION(r219857): run-benchmark --allplans broken
1054         https://bugs.webkit.org/show_bug.cgi?id=175186
1055
1056         Reviewed by Saam Barati.
1057
1058         r219857 forgot to update also the calls to BenchmarkRunner() that
1059         is done when the script is run with --allplans.
1060
1061         To fix this (and avoid future issues like this), let's factorize
1062         the calls to the benchhmark runner in a run_benchmark_plan()
1063         function.
1064
1065         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1066         (run_benchmark_plan):
1067         (start):
1068
1069 2017-08-04  Aakash Jain  <aakash_jain@apple.com>
1070
1071         Dashboard bubbles sometimes show failure count instead of crash count
1072         https://bugs.webkit.org/show_bug.cgi?id=175157
1073         <rdar://problem/33709009>
1074
1075         Reviewed by Alexey Proskuryakov.
1076
1077         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1078         (BuildbotTestResults.prototype.resultSummarizer): Use the regex for the precise match first.
1079
1080 2017-08-04  Joseph Pecoraro  <pecoraro@apple.com>
1081
1082         Add tests for NeverDestroyed
1083         https://bugs.webkit.org/show_bug.cgi?id=175146
1084
1085         Reviewed by Darin Adler.
1086
1087         * CMakeLists.txt:
1088         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1089         New files and sort.
1090
1091         * TestWebKitAPI/Tests/WTF/Logger.h:
1092         * TestWebKitAPI/Tests/WTF/Logger.cpp:
1093         (TestWebKitAPI::log):
1094         (TestWebKitAPI::takeLogStr):
1095         * TestWebKitAPI/Tests/WTF/RefLogger.h:
1096         * TestWebKitAPI/Tests/WTF/RefLogger.cpp:
1097         (TestWebKitAPI::log): Deleted.
1098         (TestWebKitAPI::takeLogStr): Deleted.
1099         Extract log() / takeLogStr() from RefLogger to a general Logger.h/cpp.
1100
1101         * TestWebKitAPI/Tests/WTF/LifecycleLogger.h:
1102         * TestWebKitAPI/Tests/WTF/LifecycleLogger.cpp: Added.
1103         (TestWebKitAPI::LifecycleLogger::LifecycleLogger):
1104         (TestWebKitAPI::LifecycleLogger::operator=):
1105         (TestWebKitAPI::LifecycleLogger::~LifecycleLogger):
1106         (TestWebKitAPI::LifecycleLogger::setName):
1107         (TestWebKitAPI::TEST):
1108         Add a class that logs construction / assignment / modifications.
1109
1110         * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp: Added.
1111         (TestWebKitAPI::TEST):
1112         (TestWebKitAPI::list):
1113         Test construction behavior is as expected both directly and using makeNeverDestroyed.
1114
1115 2017-08-04  Lucas Forschler  <lforschler@apple.com>
1116
1117         minification logic is not implemented for ios builds
1118         <rdar://problem/33726561>
1119
1120         Reviewed by Dean Johnson
1121
1122         * BuildSlaveSupport/built-product-archive:
1123         (minifyDirectory): refactor minifySource -> minifyDirectory
1124         (archiveBuiltProduct): add ios minification logic
1125         (minifySource): Deleted.
1126
1127 2017-08-04  Matt Lewis  <jlewis3@apple.com>
1128
1129         Unreviewed, rolling out r220271.
1130
1131         Rolling out due to Layout Test failing on iOS Simulator.
1132
1133         Reverted changeset:
1134
1135         "Remove STREAMS_API compilation guard"
1136         https://bugs.webkit.org/show_bug.cgi?id=175165
1137         http://trac.webkit.org/changeset/220271
1138
1139 2017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
1140
1141         Unreviewed, rolling out r220268.
1142
1143         This change caused assertion failures on macOS and iOS Debug
1144         WK2.
1145
1146         Reverted changeset:
1147
1148         "Resource Load Statistics: Report user interaction
1149         immediately, but only when needed"
1150         https://bugs.webkit.org/show_bug.cgi?id=175090
1151         http://trac.webkit.org/changeset/220268
1152
1153 2017-08-04  Youenn Fablet  <youenn@apple.com>
1154
1155         Remove STREAMS_API compilation guard
1156         https://bugs.webkit.org/show_bug.cgi?id=175165
1157
1158         Reviewed by Darin Adler.
1159
1160         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1161
1162 2017-08-04  John Wilander  <wilander@apple.com>
1163
1164         Resource Load Statistics: Report user interaction immediately, but only when needed
1165         https://bugs.webkit.org/show_bug.cgi?id=175090
1166         <rdar://problem/33685546>
1167
1168         Reviewed by Chris Dumez.
1169
1170         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1171         (WTR::InjectedBundle::beginTesting):
1172             Now calls WebCore::ResourceLoadObserver::clearState().
1173
1174 2017-08-03  Brian Burg  <bburg@apple.com>
1175
1176         Remove ENABLE(WEB_SOCKET) guards
1177         https://bugs.webkit.org/show_bug.cgi?id=167044
1178
1179         Reviewed by Joseph Pecoraro.
1180
1181         * Scripts/webkitperl/FeatureList.pm:
1182         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1183
1184 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1185
1186         REGRESSION(r219850): run-benchmark script broken on Linux
1187         https://bugs.webkit.org/show_bug.cgi?id=175126
1188
1189         Reviewed by Stephanie Lewis.
1190
1191         The run-benchmark script dynamically generates the list of supported
1192         browsers and platforms (currently Linux and OSX) by loading all
1193         python files from Tools/Scripts/webkitpy/benchmark_runner/browser_driver
1194         and getting the browser_name and platform variables from the
1195         classes defined there.
1196
1197         This means that this classes should not raise an exception when
1198         loaded on other platforms or otherwise they will broke the whole
1199         script. Its fine if they raise an exception when executing any of
1200         the methods they implement, but not when just loading/importing
1201         the class.
1202
1203         Move the argument variable definitions that call on the platform
1204         specific OSXBrowserDriver._screen_size() function from beeing
1205         variables that are evaluated when loading the file, to be functions
1206         that are only evaluated when the actual functionality needs to be
1207         executed.
1208
1209         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1210         (OSXChromeDriver.launch_url):
1211         (OSXChromeCanaryDriver.launch_url):
1212         (create_args):
1213         (create_chrome_options):
1214         (create_window_size_arg):
1215         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1216         (OSXFirefoxDriver.launch_url):
1217         (OSXFirefoxNightlyDriver.launch_url):
1218         (OSXFirefoxNightlyDriver.launch_driver):
1219         (create_args):
1220
1221 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
1222
1223         [PAL] Move spi/cf directory into PAL
1224         https://bugs.webkit.org/show_bug.cgi?id=175057
1225
1226         Reviewed by Antti Koivisto.
1227
1228         * Scripts/webkitpy/style/checker.py:
1229         * Scripts/webkitpy/style/checker_unittest.py:
1230         (GlobalVariablesTest.test_path_rules_specifier):
1231
1232         Ignore "readability/naming/underscores" style errors for sources
1233         under the WebCore/PAL/pal/spi directory.
1234
1235         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
1236
1237 2017-08-03  Youenn Fablet  <youenn@apple.com>
1238
1239         Remove FETCH_API compilation guard
1240         https://bugs.webkit.org/show_bug.cgi?id=175154
1241
1242         Reviewed by Chris Dumez.
1243
1244         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1245
1246 2017-08-03  Lucas Forschler  <lforschler@apple.com>
1247
1248         Enable archive minification on iOS builds
1249         https://bugs.webkit.org/show_bug.cgi?id=174718
1250         
1251         Reviewed by Aakash Jain.
1252
1253         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1254         (BuildFactory.__init__):
1255
1256 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1257
1258         [GTK][WKE] Pass the --memory-limited option on the GTK and WPE buildbots for the JSC tests.
1259         https://bugs.webkit.org/show_bug.cgi?id=175140
1260
1261         Reviewed by Alexey Proskuryakov.
1262
1263         We are having lately issues with JSC tests causing problems on
1264         the GTK+ and WPE bots due to the high amount of memory some tests
1265         need to run.
1266
1267         The best thing we can do now is to workaround this by disabling
1268         all the tests marked as memoryLimited on the GTK and WPE bots.
1269         We may revise this on the future.
1270
1271         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1272         (RunJavaScriptCoreTests.start):
1273
1274 2017-08-03  Brady Eidson  <beidson@apple.com>
1275
1276         Add SW IDLs and stub out basic functionality.
1277         https://bugs.webkit.org/show_bug.cgi?id=175115
1278
1279         Reviewed by Chris Dumez.
1280
1281         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1282
1283         * Scripts/webkitpy/bindings/main.py:
1284
1285 2017-08-03  Per Arne Vollan  <pvollan@apple.com>
1286
1287         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
1288         https://bugs.webkit.org/show_bug.cgi?id=159510
1289
1290         Reviewed by Daniel Bates.
1291
1292         Allow any https certificate when running tests.
1293
1294         * DumpRenderTree/win/DumpRenderTree.cpp:
1295         (runTest):
1296
1297 2017-08-02  Youenn Fablet  <youenn@apple.com>
1298
1299         HTTP tests with 'https' suffix are only run over HTTPS for WK2, not WK1
1300         https://bugs.webkit.org/show_bug.cgi?id=175089
1301
1302         Reviewed by Chris Dumez.
1303
1304         * DumpRenderTree/TestOptions.mm:
1305         (TestOptions::TestOptions): Using absolutePath if available.
1306         * DumpRenderTree/mac/DumpRenderTree.mm:
1307         (computeTestURL): Removing http/tests/ specific URL computation.
1308         * Scripts/webkitpy/port/driver.py:
1309         (Driver._command_from_driver_input): Making webkitpy passing HTTP urls for HTTP served tests to all test runners, including WK1.
1310
1311 2017-08-02  Lucas Forschler  <lforschler@apple.com>
1312
1313         download-built-product should allow for a proxy option
1314         https://bugs.webkit.org/show_bug.cgi?id=174875
1315
1316         Reviewed by Aakash Jain, Alexey Proskuryakov, Dean Johnson
1317
1318         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1319         (DownloadBuiltProduct.start): Teach buildbot to pass along proxy for Apple bots
1320         
1321
1322 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
1323
1324         check-webkit-style: deleting lines in a file runs the linter on the whole file
1325         https://bugs.webkit.org/show_bug.cgi?id=175078
1326
1327         Reviewed by David Kilzer.
1328
1329         Deleting lines in a file should not cause linter errors to be blamed on the patch.
1330         <https://bugs.webkit.org/show_bug.cgi?id=86142> is an example of this happening.
1331
1332         * Scripts/webkitpy/style/checkers/test_expectations.py:
1333         (TestExpectationsChecker._should_log_linter_warning): Do not log a linter error if the file it is associated with only has deleted lines
1334         * Scripts/webkitpy/style/main_unittest.py:
1335         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Added files should have every line number in the file when processing.
1336         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Test case where the file with the linter errors only contained deletes.
1337         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Added files should have every line number in the file when processing.
1338
1339 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
1340
1341         webkitpy: Allow caller to specify response to unicode encode/decode error in filesystem
1342         https://bugs.webkit.org/show_bug.cgi?id=175075
1343
1344         Reviewed by David Kilzer.
1345
1346         We have no way of handling text files with illegal unicode characters. Allow the callers of
1347         filesystem.read_text_file to specify one of Python 2.7's supported responses ('strict', 'ignore', or
1348         'replace'). See https://docs.python.org/2/howto/unicode.html for details on these responses.
1349
1350         * Scripts/webkitpy/common/system/filesystem.py:
1351         (FileSystem.read_text_file): Allow caller to specify unicode error handling.
1352         (FileSystem.write_text_file): Ditto.
1353         * Scripts/webkitpy/common/system/filesystem_mock.py:
1354         (MockFileSystem.read_text_file): Allow caller to specify unicode error handling.
1355         (MockFileSystem.write_text_file): Ditto.
1356         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1357         (RealFileSystemTest.test_read_text_file_unicode_decode_error): Test reading a file with illegal unicode content.
1358         (RealFileSystemTest.test_write_text_file_unicode_encode_error): Test writing illegal unicode content to a file.
1359
1360 2017-08-02  Aakash Jain  <aakash_jain@apple.com>
1361
1362         Intermittent exception in buildPageURLForIteration for Buildbot 0.9 dashboard
1363         https://bugs.webkit.org/show_bug.cgi?id=175072
1364
1365         Reviewed by Alexey Proskuryakov.
1366
1367         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1368         (Buildbot): Make sure this._builderNameToIDMap is always defined for Buildbot 0.9.
1369
1370 2017-08-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1371
1372         [CMake] Remove obsolete code in TestWebKitAPI/CMakeLists.txt
1373         https://bugs.webkit.org/show_bug.cgi?id=175019
1374
1375         Reviewed by Darin Adler.
1376
1377         * TestWebKitAPI/CMakeLists.txt:
1378
1379 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
1380
1381         Enabling uploading archives to S3
1382         https://bugs.webkit.org/show_bug.cgi?id=174198
1383
1384         Unreviewed unit test fix after r219235.
1385
1386         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1387
1388 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
1389
1390         Fix JSCOnly ARM buildbots after r220047
1391         https://bugs.webkit.org/show_bug.cgi?id=174993
1392
1393         Unreviewed fix after r220087.
1394
1395         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1396         (BuildAndRemoteJSCTestsFactory.__init__):
1397
1398 2017-08-01  Chris Dumez  <cdumez@apple.com>
1399
1400         Add initial support for navigator.sendBeacon
1401         https://bugs.webkit.org/show_bug.cgi?id=175007
1402         <rdar://problem/33547728>
1403
1404         Reviewed by Sam Weinig.
1405
1406         Enable the Beacon API at runtime in the context of layout tests since the
1407         feature is currently disabled by default.
1408
1409         * DumpRenderTree/mac/DumpRenderTree.mm:
1410         (enableExperimentalFeatures):
1411         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1412         (WTR::InjectedBundle::beginTesting):
1413         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1414         (WTR::TestRunner::setModernMediaControlsEnabled):
1415         (WTR::TestRunner::setBeaconAPIEnabled):
1416         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1417
1418 2017-08-01  Aakash Jain  <aakash_jain@apple.com>
1419
1420         Update Bot Watcher's Dashboard for Buildbot 0.9
1421         https://bugs.webkit.org/show_bug.cgi?id=174777
1422
1423         Reviewed by Daniel Bates.
1424
1425         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1426         (Buildbot): Check if USE_BUILDBOT_VERSION_LESS_THAN_09 is passed.
1427         (Buildbot.prototype._computeBuilderNameToIDMap): Fetch the builder name to ID mapping from buidbot and store
1428         in a dictionary.
1429         (Buildbot.prototype.buildPageURLForIteration): Updated URL as per Buildbot 0.9 format. Buildbot 0.9 currently does not support
1430         builder name in the build url. See <https://github.com/buildbot/buildbot/issues/3465>.
1431         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1432         (isMultiCodebaseGotRevisionProperty): Adapting to new data format.
1433         (parseRevisionProperty): Ditto.
1434         (BuildbotIteration.prototype.failureLogURL): Return the URL to build page if precise failure url is not available. For
1435         Buildbot 0.9, build page URL would be appropriate in most cases as per the new UI.
1436         (BuildbotIteration.prototype._parseData): Parsing the data as per new data format. Many variable names and data types
1437         have changed in Buildbot 0.9.
1438         (BuildbotIteration.prototype._adjustBuildDataForBuildbot09): Adjust the Buildbot 0.8 data to new format.
1439         (BuildbotIteration.prototype._updateIfDataAvailable): Update method for Buildbot 0.9 data. We are performing two API calls, 
1440         one for build information, another for step information of that build. We need to wait until data from both REST API calls are available.
1441         (BuildbotIteration.prototype._deprecatedUpdateWithData): Renamed from _updateWithData, used for Buildbot 0.8 data.
1442         (BuildbotIteration.prototype.get buildURL): URL to fetch build information from Buildbot. Also fetches got_revision property.
1443         (BuildbotIteration.prototype.get buildStepsURL): URL to fetch the steps information from Buildbot.
1444         (BuildbotIteration.prototype.urlFailedToLoad): Callback method to be used when URL fails to load. Made it a separate function now.
1445         (BuildbotIteration.prototype.update): Modified to support both Buildbot 0.9 and 0.8 data format.
1446         (BuildbotIteration.prototype.actualUpdate): Update method for Buildbot 0.9 data.
1447         (BuildbotIteration.prototype.deprecatedUpdate): Update method for Buildbot 0.8 data.
1448         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1449         (BuildbotQueue.prototype.get baseURL): Updated URL as per Buildbot 0.9 format.
1450         (BuildbotQueue.prototype.get allIterationsURL): Ditto.
1451         (BuildbotQueue.prototype.get overviewURL): Ditto.
1452         (BuildbotQueue.prototype.get buildsURL): URL to fetch builds data in Buildbot 0.9.
1453         (BuildbotQueue.prototype.get buildsInfoURL): Returns the appropriate URL to use to fetch builds information from
1454         Buildbot 0.8 or 0.9.
1455         (BuildbotQueue.prototype.getBuilds): Method compatible with both Buildbot 0.8 and 0.9 to get build information from data
1456         fetched from Buildbot. Also, reversing the Buildbot 0.8 data to make it similar to 0.9 data format.
1457         (BuildbotQueue.prototype.isBuildComplete): Method compatible with both Buildbot 0.8 and 0.9 to check if the build has completed.
1458         (BuildbotQueue.prototype.getIterationID):  Method compatible with both Buildbot 0.8 and 0.9 to get the Iteration ID.
1459         (BuildbotQueue.prototype.update): Supports both Buildbot 0.8 and 0.9. Buildbot 0.9 REST API doesn't have cachedBuilds and currentBuilds. 
1460         Therefore we are fetching information for fixed number of build. 
1461         Also iterating the loop incrementally since the build data is already reverse sorted.
1462         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1463         (BuildbotTestResults.prototype._parseResults): Updated as per Buildbot 0.9 format. Note that we do not
1464         need to worry about 0.8 or 0.9 data format here, since the data is already converted to 0.9 format.
1465         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1466         (WebKitBuildbot): Pass the USE_BUILDBOT_VERSION_LESS_THAN_09 flag.
1467
1468 2017-08-01  Devin Rousso  <drousso@apple.com>
1469
1470         Web Inspector: simplify WebInspector with WI
1471         https://bugs.webkit.org/show_bug.cgi?id=175058
1472
1473         Reviewed by Joseph Pecoraro.
1474
1475         * Scripts/check-inspector-strings:
1476         (extract_ui_strings):
1477         * Scripts/extract-localizable-js-strings:
1478
1479 2017-08-01  Youenn Fablet  <youenn@apple.com>
1480
1481         Layout tests with 'https' suffix should be run over HTTPS
1482         https://bugs.webkit.org/show_bug.cgi?id=174992
1483
1484         Reviewed by Chris Dumez.
1485
1486         Updating the test-name <-> uri conversion routines to use https when test names contain ".https." in them.
1487         This covers WPT tests, WPT WebKit tests and HTTP layout tests.
1488         Covered by corresponding unit tests.
1489
1490         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
1491         (run_server):
1492         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1493         (base_http_url):
1494         (base_https_url):
1495         (base_url): Deleted.
1496         * Scripts/webkitpy/port/base.py:
1497         (Port.to.web_platform_test_server_base_http_url):
1498         (Port.to):
1499         (Port.to.web_platform_test_server_base_https_url):
1500         (Port.to.web_platform_test_server_base_url): Deleted.
1501         * Scripts/webkitpy/port/driver.py:
1502         (Driver.__init__):
1503         (Driver.wpt_test_path_to_uri):
1504         (Driver):
1505         (Driver.http_test_path_to_uri):
1506         (Driver.test_to_uri):
1507         (Driver.uri_to_test):
1508         * Scripts/webkitpy/port/driver_unittest.py:
1509         (DriverTest.test_test_to_uri):
1510         (DriverTest.test_uri_to_test):
1511
1512 2017-07-26  Jiewen Tan  <jiewen_tan@apple.com>
1513
1514         Add tests to detect mistakes in backward compatibility when the structured clone algorithm is changed in the future
1515         https://bugs.webkit.org/show_bug.cgi?id=173998
1516
1517         Reviewed by Darin Adler.
1518
1519         Since the structured clone algorithm is used for data stored in persistent databases, we need tests to help us
1520         detect mistakes in backward compatibility in the future when we change it.
1521
1522         The way it works is to read from a pre-baked database and see if all the values are matched with the expectations.
1523         Surprisedly, some of structured clonable objects cannot be stored into the indexedDB. Those are FileList,
1524         ObjectReference, MessagePortReference, ArrayBufferView, ArrayBufferTransfer, NonMapProperties, NonSetProperties,
1525         SharedArrayBuffer, WasmModule, DOMPointReadOnly, DOMPoint, DOMRectReadOnly, DOMRect, DOMMatrixReadOnly, DOMMatrix,
1526         DOMQuad and Error. CryptoKey objects are not included as well as they need new API for encrypting/decrypting the
1527         internal key data slot.
1528
1529         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1530         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.mm: Added.
1531         (-[IndexedDBStructuredCloneBackwardCompatibilityMessageHandler userContentController:didReceiveScriptMessage:]):
1532         (getNextMessage):
1533         (TEST):
1534         Here is the API test that moves the pre-baked database to the location where TestWebKitAPI can read from.
1535         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3: Added.
1536         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm: Added.
1537         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal: Added.
1538         These are the pre-baked databases.
1539         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html: Added.
1540         This is the actual test that do all the reads and comparisons.
1541         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html: Added.
1542         This is the page that bakes the database. It never runs automatically. It is for someone who needs to teach
1543         IndexedDB new stuffs. Then it can be used to bake the database again.
1544
1545 2017-08-01  Brady Eidson  <beidson@apple.com>
1546
1547         API test URLSchemeHandler.Exceptions is Exiting out early on macOS Debug..
1548         https://bugs.webkit.org/show_bug.cgi?id=175030
1549
1550         Reviewed by Andy Estes.
1551
1552         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
1553         (-[TaskSchemeHandler webView:startURLSchemeTask:]): Stop calling an invalid NSError constructor.
1554
1555 2017-08-01  Brady Eidson  <beidson@apple.com>
1556
1557         Part 2 of: Rename DatabaseProcess to StorageProcess.
1558         https://bugs.webkit.org/show_bug.cgi?id=174880
1559
1560         Reviewed by Andy Estes.
1561
1562         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
1563         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
1564         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
1565         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
1566         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
1567         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
1568         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
1569         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1570
1571 2017-07-31  Csaba Osztrogonác  <ossy@webkit.org>
1572
1573         Fix JSCOnly ARM buildbots after r220047
1574         https://bugs.webkit.org/show_bug.cgi?id=174993
1575
1576         Reviewed by Saam Barati.
1577
1578         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1579         (BuildAndRemoteJSCTestsFactory.__init__):
1580
1581 2017-07-30  Yusuke Suzuki  <utatane.tea@gmail.com>
1582
1583         [WTF] Introduce Private Symbols
1584         https://bugs.webkit.org/show_bug.cgi?id=174935
1585
1586         Reviewed by Darin Adler.
1587
1588         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1589         (TestWebKitAPI::TEST):
1590
1591 2017-07-30  Darin Adler  <darin@apple.com>
1592
1593         Remove code in HTMLObjectElement attribute parsing that forces style resolution and layout
1594         https://bugs.webkit.org/show_bug.cgi?id=130653
1595
1596         Reviewed by Antti Koivisto.
1597
1598         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1599         (WTR::InjectedBundlePage::didFinishLoadForFrame): Omit now-unneeded "shouldDump" argument
1600         when calling frameDidChangeLocation.
1601         (WTR::InjectedBundlePage::frameDidChangeLocation): Removed "shouldDump" argument. This was
1602         causing WebKitTestRunner to not dump anything in cases where DumpRenderTree will dump, and
1603         thus causing mysterious failures of a couple of tests. There are two remaining issues:
1604         1) WebKitTestRunner won't run its dump code if there is no "page", and there is no such
1605         consideration in DumpRenderTree and 2) Both DumpRenderTree and WebKitTestRunner share the
1606         same logic flaw that causes "top loading frame" to get set to one of the subframes in
1607         tests where  the following sequence occurs: test calls waitUntilDone, main frame finishes
1608         loading, subframe starts loading. It would be good to clean that up some day, but for now
1609         this patch makes the two work identically rather than changing both.
1610         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for change above.
1611
1612 2017-07-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1613
1614         [WK2] Replace RetainPtr<> with auto when adopting allocated ObjC objects in DataInteractionTests
1615         https://bugs.webkit.org/show_bug.cgi?id=174963
1616
1617         Reviewed by Darin Adler.
1618
1619         Replaces several uses of RetainPtr<>s with auto. Some test cases in this file use auto, while other test cases declare using
1620         RetainPtr<>. This patch changes them to all use auto.
1621
1622         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1623         (TestWebKitAPI::TEST):
1624
1625 2017-07-30  Brady Eidson  <beidson@apple.com>
1626
1627         Add URLSchemeHandler API tests that verify the lack of URLSchemeTask object leaks.
1628         https://bugs.webkit.org/show_bug.cgi?id=174958
1629
1630         Reviewed by Darin Adler.
1631
1632         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1633         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-leaks.mm: Added.
1634         (-[LeakSchemeHandler webView:startURLSchemeTask:]):
1635         (-[LeakSchemeHandler webView:stopURLSchemeTask:]):
1636         (runUntilTasksInFlight):
1637         (TEST):
1638
1639 2017-07-28  Commit Queue  <commit-queue@webkit.org>
1640
1641         Unreviewed, rolling out r219990.
1642         https://bugs.webkit.org/show_bug.cgi?id=174961
1643
1644         "broke PLT on iOS (rdar://problem/33602751)" (Requested by
1645         estes on #webkit).
1646
1647         Reverted changeset:
1648
1649         "Part 2 of: Rename DatabaseProcess to StorageProcess."
1650         https://bugs.webkit.org/show_bug.cgi?id=174880
1651         http://trac.webkit.org/changeset/219990
1652
1653 2017-07-28  Brady Eidson  <beidson@apple.com>
1654
1655         API tests that use URLSchemeHandler are failing.
1656         https://bugs.webkit.org/show_bug.cgi?id=174950
1657
1658         Reviewed by Alex Christensen.
1659
1660         Fix the NoMIMEType test to be correct.
1661
1662         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
1663         (-[SchemeHandler initWithData:mimeType:]):
1664         (-[SchemeHandler webView:startURLSchemeTask:]):
1665         (TEST):
1666
1667 2017-07-28  Daniel Bates  <dabates@apple.com>
1668
1669         prepare-ChangeLog should not list added layout tests in PAL ChangeLog
1670         https://bugs.webkit.org/show_bug.cgi?id=174876
1671
1672         Reviewed by Alex Christensen.
1673
1674         Do not list added layout tests in the PAL ChangeLog as such tests are unlikely to be related
1675         to a PAL change. Unit tests are more appropriate for PAL changes than layout tests because
1676         they provide a more direct way to test the platform abstraction.
1677
1678         As a side effect of this change we no longer list added layout tests in WebCore/platform/gtk/po/ChangeLog.
1679
1680         * Scripts/prepare-ChangeLog:
1681         (generateNewChangeLogs): Only list added layout tests in the WebCore ChangeLog regardless
1682         of the current working directory.
1683
1684 2017-07-28  Jonathan Bedard  <jbedard@apple.com>
1685
1686         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
1687         https://bugs.webkit.org/show_bug.cgi?id=174930
1688
1689         Unreviewed test fix.
1690
1691         We need to check parentheses before printing 'const' or 'volatile' in the ChangeLog. 
1692
1693         * Scripts/prepare-ChangeLog:
1694         (get_function_line_ranges_for_cpp):
1695
1696 2017-07-28  JF Bastien  <jfbastien@apple.com>
1697
1698         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
1699         https://bugs.webkit.org/show_bug.cgi?id=174930
1700
1701         Reviewed by Daniel Bates.
1702
1703         Teach prepare-ChangeLog about C++ auto arrow return, and while I'm
1704         here also teach it about const and volatile overloads. I didn't do
1705         reference and rvalue reference overloads because we don't really
1706         use them, and the current parser throws away those characters and
1707         it doesn't seem worth making it more complex.
1708
1709         * Scripts/prepare-ChangeLog:
1710         (get_function_line_ranges_for_cpp):
1711         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
1712         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
1713         (Foo::Arrow::arrow):
1714         (Foo::Arrow::otherArrow):
1715         (Foo::Arrow::otherArrow const):
1716         (Foo::Arrow::otherArrow volatile):
1717         (Foo::Arrow::otherArrow const volatile):
1718
1719 2017-07-28  Adrian Perez de Castro  <aperez@igalia.com>
1720
1721         [GTK] Building with ENABLE_VIDEO=OFF fails
1722         https://bugs.webkit.org/show_bug.cgi?id=174940
1723
1724         Reviewed by Alex Christensen.
1725
1726         When GStreamer usage is completely disabled at build time, CMake does not query pkg-config for the GStreamer.
1727         This adds missing USE(GSTREAMER) guards in order to make testing code buildable when GStreamer usage is disabled.
1728
1729         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1730         (methodCallCallback): Add missing USE(GSTREAMER) guard.
1731
1732 2017-07-28  Claudio Saavedra  <csaavedra@igalia.com>
1733
1734         [WPE] Implement EventSenderProxy in WTR
1735         https://bugs.webkit.org/show_bug.cgi?id=173419
1736
1737         Reviewed by Žan Doberšek.
1738
1739         Add the implementation of EventSenderProxy to the WTR. This
1740         allows us to extend the coverage of the test suite in WKWPE.
1741
1742         * WebKitTestRunner/EventSenderProxy.h:
1743         * WebKitTestRunner/PlatformWPE.cmake: Add dependency on
1744         libxkbcommon needed to deal with key events.
1745         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1746         (WTR::EventSenderProxy::EventSenderProxy):
1747         (WTR::senderButtonToWPEButton):
1748         (WTR::EventSenderProxy::mouseDown):
1749         (WTR::EventSenderProxy::mouseUp):
1750         (WTR::EventSenderProxy::mouseMoveTo):
1751         (WTR::EventSenderProxy::mouseScrollBy):
1752         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
1753         (WTR::EventSenderProxy::leapForward):
1754         (WTR::wkEventModifiersToWPE):
1755         (WTR::getXKBKeySymForKeyRef):
1756         (WTR::EventSenderProxy::keyDown):
1757         (WTR::EventSenderProxy::addTouchPoint):
1758         (WTR::EventSenderProxy::updateTouchPoint):
1759         (WTR::EventSenderProxy::setTouchModifier):
1760         (WTR::EventSenderProxy::setTouchPointRadius):
1761         (WTR::EventSenderProxy::getUpdatedTouchEvents):
1762         (WTR::EventSenderProxy::removeUpdatedTouchEvents):
1763         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1764         (WTR::EventSenderProxy::touchStart):
1765         (WTR::EventSenderProxy::touchMove):
1766         (WTR::EventSenderProxy::touchEnd):
1767         (WTR::EventSenderProxy::touchCancel):
1768         (WTR::EventSenderProxy::clearTouchPoints):
1769         (WTR::EventSenderProxy::releaseTouchPoint):
1770         (WTR::EventSenderProxy::cancelTouchPoint):
1771
1772 2017-07-27  Brady Eidson  <beidson@apple.com>
1773
1774         Part 2 of: Rename DatabaseProcess to StorageProcess.
1775         https://bugs.webkit.org/show_bug.cgi?id=174880
1776
1777         Reviewed by Andy Estes.
1778
1779         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
1780         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
1781         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
1782         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
1783         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
1784         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
1785         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
1786         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1787
1788 2017-07-26  Mark Lam  <mark.lam@apple.com>
1789
1790         Add ability to only run specific tests in run-javascriptcore-tests.
1791         https://bugs.webkit.org/show_bug.cgi?id=174884
1792
1793         Reviewed by Saam Barati.
1794
1795         For example, if we only want to run testapi, we can do so as follows:
1796             $ run-javascriptcore-tests --testapi
1797
1798         Previously, specifying --testapi effectively does nothing because we run all tests
1799         by default.  Only --no-testapi had the effect of disabling the test set.  This
1800         old behavior for --testapi is not very useful or meaningful.  We're now changing
1801         it to mean that we will only run that test.
1802
1803         With this change, we can also run more than one set of tests.  For example, if we
1804         only want to run testmasm and testair, we can do so as follows:
1805             $ run-javascriptcore-tests --testmasm --testair
1806
1807         By default, if no specific test option is specified, run-javascriptcore-tests will
1808         run all tests.
1809
1810         Note that the jsc stress tests (--jsc-stress) are a different set of tests than
1811         the mozilla tests (--mozilla-tests) even though both are run via the lower level
1812         run-jsc-stress-tests test harness.  Hence, if you only specify one of the tests,
1813         the other set will not run.  For example, the following only runs the mozilla tests:
1814             $ run-javascriptcore-tests --mozilla-tests
1815
1816         Note also that --jit-stress-tests is not for choosing a different set of tests.
1817         Instead, it is used for determining whether we run JIT'ed test configurations
1818         on the jsc stress tests and mozilla tests.  As a result, specifying
1819         --jit-stress-tests will not omit other tests.  For example, the following still
1820         runs all tests:
1821             $ run-javascriptcore-tests --jit-stress-tests
1822
1823         * Scripts/run-javascriptcore-tests:
1824         (defaultStringForTestState):
1825         (enableTestOrNot):
1826         (runJSCStressTests):
1827
1828 2017-07-26  Mark Lam  <mark.lam@apple.com>
1829
1830         Make run-javascriptcore-test run testair, testb3, and testmasm.
1831         https://bugs.webkit.org/show_bug.cgi?id=174837
1832         <rdar://problem/33522927>
1833
1834         Reviewed by Saam Barati and Filip Pizlo.
1835
1836         1. Refactors code for running testapi so that we can use it to run other tests.
1837         2. Added running of testmasm, testair, testb3.
1838
1839         Note: the existing testapi invocation code does not support remote invocation of
1840         the tests (e.g. on a ARM device).  Hence, the new additions of testmasm, testair,
1841         and testb3 also do not support remote invocation.  If we wish to add remote
1842         invocation support, we should do that in a separate patch.
1843
1844         * Scripts/run-javascriptcore-tests:
1845         (testPath):
1846         (runTest):
1847         (testapiPath): Deleted.
1848
1849 2017-07-26  Aakash Jain  <aakash_jain@apple.com>
1850
1851         Remove duplicate code from Buildbot.js in dashboard
1852         https://bugs.webkit.org/show_bug.cgi?id=174870
1853
1854         Reviewed by Daniel Bates.
1855
1856         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1857         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Remove duplicate code and reuse buildPageURLForIteration() to construct URL.
1858         (Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto.
1859         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js:
1860         (MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto for tests.
1861
1862 2017-07-26  Brady Eidson  <beidson@apple.com>
1863
1864         Add test to verify certain child processes are not launched as a side effect of enabling ResourceLoadStatistics.
1865         https://bugs.webkit.org/show_bug.cgi?id=174851
1866
1867         Reviewed by Chris Dumez.
1868
1869         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
1870         (TEST):
1871
1872 2017-07-26  Brian Burg  <bburg@apple.com>
1873
1874         Remove WEB_TIMING feature flag
1875         https://bugs.webkit.org/show_bug.cgi?id=174795
1876
1877         Reviewed by Alex Christensen.
1878
1879         * Scripts/webkitperl/FeatureList.pm:
1880         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1881
1882 2017-07-26  Chris Dumez  <cdumez@apple.com>
1883
1884         Pressing the Escape key should not be a valid user gesture to enter fullscreen
1885         https://bugs.webkit.org/show_bug.cgi?id=174864
1886         <rdar://problem/33009088>
1887
1888         Reviewed by Geoffrey Garen.
1889
1890         Add support for eventSender.keyDown('escape') in DRT to match the behavior of
1891         WKTR.
1892
1893         * DumpRenderTree/mac/EventSendingController.mm:
1894         (-[EventSendingController keyDown:withModifiers:withLocation:]):
1895
1896 2017-07-26  Romain Bellessort  <romain.bellessort@crf.canon.fr>
1897
1898         Unreviewed, added Romain Bellessort to contributors.json.
1899
1900         * Scripts/webkitpy/common/config/contributors.json:
1901
1902 2017-07-26  Zan Dobersek  <zdobersek@igalia.com>
1903
1904         [WPE] WebGL2 support
1905         https://bugs.webkit.org/show_bug.cgi?id=174249
1906
1907         Reviewed by Alex Christensen.
1908
1909         * Scripts/webkitperl/FeatureList.pm:
1910         Enable WebGL2 for WPE when building through build-webkit.
1911
1912 2017-07-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1913
1914         Unreviewed. Fix GTK distcheck.
1915
1916         * gtk/make-dist.py:
1917         (ensure_version_if_possible): Use the right pkg-config filename, it's webkit2gtk not webkitgtk.
1918
1919 2017-07-25  Brady Eidson  <beidson@apple.com>
1920
1921         ResourceLoadStatistics grandfathering happens much too often.
1922         <rdar://problem/32655834> and https://bugs.webkit.org/show_bug.cgi?id=174825
1923
1924         Reviewed by Chris Dumez.
1925
1926         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1927         * TestWebKitAPI/Tests/WebKit2Cocoa/EmptyGrandfatheredResourceLoadStatistics.plist: Added.
1928         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm: Added.
1929         (TEST):
1930
1931 2017-07-25  Matthew Stewart  <matthew_r_stewart@apple.com>
1932
1933         Fix autoinstaller failing on autoinstall_everything
1934         https://bugs.webkit.org/show_bug.cgi?id=174830
1935
1936         Reviewed by Joseph Pecoraro.
1937
1938         * Scripts/webkitpy/thirdparty/__init__.py:
1939         (AutoinstallImportHook.find_module):
1940         (AutoinstallImportHook.install_chromedriver):
1941         (AutoinstallImportHook.install_geckodriver):
1942         (AutoinstallImportHook._install_chromedriver): Deleted.
1943         (AutoinstallImportHook._install_geckodriver): Deleted.
1944
1945 2017-07-25  Jonathan Bedard  <jbedard@apple.com>
1946
1947         Replace --runtime with something for both ios-simulator and ios-device
1948         https://bugs.webkit.org/show_bug.cgi?id=173775
1949         <rdar://problem/32952164>
1950
1951         Reviewed by Aakash Jain.
1952
1953         Add --version flag for both iOS simulator and iOS device.
1954
1955         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1956         (parse_args): Add --version flag and move --no-install.
1957         * Scripts/webkitpy/port/factory.py:
1958         (platform_options): Move --no-intall to run_webkit_tests.py.
1959         * Scripts/webkitpy/port/ios.py:
1960         (IOSPort):
1961         (IOSPort._is_valid_ios_version): Check that the provided version string is legal.
1962         (IOSPort.get_option): If accessing the iOS version, check that it is a valid version string.
1963         * Scripts/webkitpy/port/ios_device.py:
1964         (IOSDevicePort.ios_version): Consult --version flag before checking connected
1965         devices for iOS version.
1966         * Scripts/webkitpy/port/ios_device_unittest.py:
1967         (IOSDeviceTest.make_port): Set --version option so that we can generate test
1968         expectation paths without devices connected.
1969         (IOSDeviceTest.test_additional_platform_directory): Deleted.
1970         (IOSDeviceTest.test_baseline_searchpath): Deleted.
1971         (IOSDeviceTest.test_expectations_ordering): Deleted.
1972         * Scripts/webkitpy/port/ios_simulator.py:
1973         (IOSSimulatorPort.simulator_runtime): If no runtime is specified, use the --version
1974         flag to specify a runtime.
1975         (IOSSimulatorPort.ios_version): First check the --version flag, then the --runtime
1976         flag and then use the default runtime.
1977
1978 2017-07-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1979
1980         [GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename
1981         https://bugs.webkit.org/show_bug.cgi?id=174815
1982
1983         Reviewed by Carlos Alberto Lopez Perez.
1984
1985         Only WebKitGTK specific tests are built, but not WebKit2, WTF nor WebCore ones. We are still checking
1986         ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to
1987         use WebKit dir, while the tests are still in WebKit2 directory. This patch also removes
1988         TestWebKitAPIInjectedBundle_PATH that is unused and now makes the configure to fail (it used to be a warning, I
1989         think), probably because of a newer CMake version.
1990
1991         * CMakeLists.txt:
1992         * TestWebKitAPI/CMakeLists.txt:
1993         * TestWebKitAPI/PlatformGTK.cmake:
1994
1995 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
1996
1997         Fix BenchmarkRunner to only import selenium when needed
1998         https://bugs.webkit.org/show_bug.cgi?id=174808
1999
2000         Reviewed by Stephanie Lewis.
2001
2002         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
2003         (LinuxChromeDriver.launch_driver):
2004         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
2005         (LinuxFirefoxDriver.launch_driver):
2006         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2007         (OSXChromeDriver.launch_driver):
2008         (OSXChromeCanaryDriver.launch_driver):
2009         (create_chrome_options):
2010         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2011         (OSXFirefoxDriver.launch_driver):
2012         (OSXFirefoxNightlyDriver.launch_driver):
2013         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2014         (OSXSafariDriver.launch_driver):
2015         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
2016         (WebDriverBenchmarkRunner._run_one_test):
2017
2018 2017-07-23  Darin Adler  <darin@apple.com>
2019
2020         More NeverDestroyed and related cleanup
2021         https://bugs.webkit.org/show_bug.cgi?id=174745
2022
2023         Reviewed by Alex Christensen.
2024
2025         * DumpRenderTree/JavaScriptThreading.cpp:
2026         (javaScriptThreadsMutex): Use NeverDestroyed instead of
2027         DEPRECATED_DEFINE_STATIC_LOCAL.
2028         (javaScriptThreads): Ditto.
2029
2030 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2031
2032         Subclass Benchmark Runner script for WebDriver support
2033         https://bugs.webkit.org/show_bug.cgi?id=174390
2034
2035         Reviewed by Dewei Zhu, Stephanie Lewis.
2036
2037         Add WebServerBenchmarkRunner and WebDriverBenchmarkRunner subclasses.
2038
2039         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
2040         (BenchmarkBuilder.__init__):
2041         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2042         (BenchmarkRunner.__init__):
2043         (BenchmarkRunner._find_plan_file):
2044         (BenchmarkRunner._run_one_test.and):
2045         (BenchmarkRunner.execute):
2046         (BenchmarkRunner._get_result): Deleted.
2047         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2048         (parse_args):
2049         (start):
2050         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py: Added.
2051         (WebDriverBenchmarkRunner):
2052         (WebDriverBenchmarkRunner._get_result):
2053         (WebDriverBenchmarkRunner._run_one_test):
2054         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py: Added.
2055         (WebServerBenchmarkRunner):
2056         (WebServerBenchmarkRunner.__init__):
2057         (WebServerBenchmarkRunner._get_result):
2058         (WebServerBenchmarkRunner._run_one_test):
2059
2060 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2061
2062         Add BenchmarkRunner patches with WebDriver support for each testing plan
2063         https://bugs.webkit.org/show_bug.cgi?id=174443
2064
2065         Reviewed by Dewei Zhu, Stephanie Lewis.
2066
2067         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
2068         (BenchmarkBuilder.__enter__):
2069         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ARES-6.patch:
2070         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ContentAnimation.patch:
2071         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Dromaeo.patch:
2072         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JSBench.patch:
2073         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JetStream.patch:
2074         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Kraken.patch:
2075         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/MotionMark.patch:
2076         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Octane.patch:
2077         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Speedometer.patch:
2078         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/SunSpider.patch:
2079         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
2080         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Animometer.patch:
2081         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ContentAnimation.patch:
2082         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Dromaeo.patch:
2083         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JSBench.patch:
2084         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JetStream.patch:
2085         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Kraken.patch:
2086         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
2087         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Octane.patch:
2088         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer.patch:
2089         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/SunSpider.patch:
2090         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
2091         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
2092         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan:
2093         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan:
2094         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan:
2095         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
2096         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan:
2097         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan:
2098         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
2099         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan:
2100         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
2101         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
2102
2103 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2104
2105         Add functions to autoinstaller needed for Benchmark Runner script
2106         https://bugs.webkit.org/show_bug.cgi?id=174331
2107
2108         Reviewed by Dean Johnson, Dewei Zhu, Stephanie Lewis.
2109
2110         Adds autoinstaller functions to install selenium and webdriver binaries
2111         which will be used by the browser driver part of Benchmark Runner.
2112
2113         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2114         (BrowserDriver.restore_env):
2115         (BrowserDriver):
2116         (BrowserDriver.get_webdriver_binary_path):
2117         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
2118         (LinuxChromeDriver.launch_driver):
2119         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
2120         (LinuxFirefoxDriver.launch_driver):
2121         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2122         (OSXChromeDriver.launch_driver):
2123         (OSXChromeCanaryDriver.launch_driver):
2124         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2125         (OSXFirefoxDriver.launch_driver):
2126         (OSXFirefoxNightlyDriver.launch_driver):
2127         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2128         * Scripts/webkitpy/benchmark_runner/utils.py:
2129         (get_driver_binary_path):
2130         * Scripts/webkitpy/common/system/autoinstall.py:
2131         (AutoInstaller._unzip):
2132         * Scripts/webkitpy/thirdparty/__init__.py:
2133         (AutoinstallImportHook.find_module):
2134         (AutoinstallImportHook._install_selenium):
2135         (AutoinstallImportHook):
2136         (AutoinstallImportHook._install_chromedriver):
2137         (AutoinstallImportHook._install_geckodriver):
2138         (AutoinstallImportHook.get_latest_pypi_url):
2139         (AutoinstallImportHook.install_binary):
2140         (autoinstall_everything):
2141         (get_driver_filename):
2142         (get_os_info):
2143
2144 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2145
2146         Add WebDriver support in browser driver part of BenchmarkRunner
2147         https://bugs.webkit.org/show_bug.cgi?id=174445
2148
2149         Reviewed by Stephanie Lewis.
2150
2151         Adds a launch_driver function to each BrowserDriver subclass. This
2152         function sets up the arguments for the webdriver and launches the
2153         webdriver specific to that browser.
2154
2155         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2156         (BrowserDriver.launch_webdriver):
2157         (BrowserDriver):
2158         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
2159         (LinuxBrowserDriver.launch_webdriver):
2160         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
2161         (LinuxChromeDriver.launch_url):
2162         (LinuxChromeDriver):
2163         (LinuxChromeDriver.launch_driver):
2164         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py:
2165         (EpiphanyBrowserDriver.launch_url):
2166         (EpiphanyBrowserDriver):
2167         (EpiphanyBrowserDriver.launch_driver):
2168         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
2169         (LinuxFirefoxDriver):
2170         (LinuxFirefoxDriver.launch_url):
2171         (LinuxFirefoxDriver.launch_driver):
2172         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
2173         (GTKMiniBrowserDriver.launch_url):
2174         (GTKMiniBrowserDriver):
2175         (GTKMiniBrowserDriver.launch_driver):
2176         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2177         (OSXBrowserDriver._launch_webdriver):
2178         (OSXBrowserDriver):
2179         (OSXBrowserDriver._screen_size):
2180         (OSXBrowserDriver._insert_url):
2181         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2182         (OSXChromeDriver):
2183         (OSXChromeDriver.launch_url):
2184         (OSXChromeDriver.launch_driver):
2185         (OSXChromeCanaryDriver):
2186         (OSXChromeCanaryDriver.launch_url):
2187         (OSXChromeCanaryDriver.launch_driver):
2188         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2189         (OSXFirefoxDriver):
2190         (OSXFirefoxDriver.launch_url):
2191         (OSXFirefoxDriver.launch_driver):
2192         (OSXFirefoxNightlyDriver):
2193         (OSXFirefoxNightlyDriver.launch_url):
2194         (OSXFirefoxNightlyDriver.launch_driver):
2195         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2196         (OSXSafariDriver.launch_driver):
2197
2198 2017-07-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2199
2200         [Mac WK2] Add an API test to cover r219765 (null dereference in [WKWebView dealloc])
2201         https://bugs.webkit.org/show_bug.cgi?id=174793
2202
2203         Reviewed by Tim Horton.
2204
2205         Adds a new unit test that invokes some asynchronous NSTextInputClient SPI methods as the web view is tearing
2206         down. Without r219765, this test will dereference null and crash.
2207
2208         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2209         * TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h: Added.
2210         * TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm:
2211         (TEST):
2212
2213 2017-07-24  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2214
2215         [Win] Implement Authentication dialog in MiniBrowser
2216         https://bugs.webkit.org/show_bug.cgi?id=174662
2217
2218         Reviewed by Alex Christensen.
2219
2220         * MiniBrowser/win/Common.cpp:
2221         (CustomUserAgent):
2222         (DisplayAuthDialog):
2223         (AuthDialogProc):
2224         * MiniBrowser/win/MiniBrowserLib.rc:
2225         * MiniBrowser/win/MiniBrowserLibResource.h:
2226         * MiniBrowser/win/ResourceLoadDelegate.cpp:
2227         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2228
2229 2017-07-24  Jonathan Bedard  <jbedard@apple.com>
2230
2231         Handle case where line_numbers is None instead of an array of line numbers
2232         https://bugs.webkit.org/show_bug.cgi?id=174775
2233
2234         Reviewed by Aakash Jain.
2235
2236         Added files set line_numbers to None in process_file.
2237
2238         * Scripts/webkitpy/style/filereader.py:
2239         (TextFileReader.process_file): Handle case where line_number is set to None.
2240         * Scripts/webkitpy/style/main_unittest.py:
2241         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Test case of an added file.
2242
2243 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
2244
2245         [WPE] Add libepoxy to the Jhbuild moduleset
2246         https://bugs.webkit.org/show_bug.cgi?id=174711
2247
2248         Reviewed by Carlos Alberto Lopez Perez.
2249
2250         * wpe/jhbuild.modules: Add libepoxy 1.4.3 to WPE's Jhbuild moduleset.
2251
2252 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
2253
2254         [WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
2255         https://bugs.webkit.org/show_bug.cgi?id=174780
2256
2257         Reviewed by Carlos Garcia Campos.
2258
2259         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
2260         Manually define the EGL_CAST macro to the C++ version that uses static_cast<>
2261         in case the eglplatform.h header doesn't provide that macro. This replicates
2262         the work in WebCore's EpoxyEGL.h header, but we can't include that header here.
2263
2264 2017-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2265
2266         [iOS WK2] Remove _WKDraggableElementInfo and fold PositionInformationTests into WKRequestActivatedElementInfo
2267         https://bugs.webkit.org/show_bug.cgi?id=174758
2268
2269         Reviewed by Dan Bernstein.
2270
2271         Migrate position-information-related unit tests from the PositionInformationTests suite to
2272         WKRequestActivatedElementInfo as 2 new unit tests. See WebKit2 ChangeLog for more details.
2273
2274         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2275         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
2276         (TestWebKitAPI::checkElementTypeAndBoundingRect):
2277         (TestWebKitAPI::TEST):
2278         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm: Removed.
2279         * TestWebKitAPI/cocoa/TestWKWebView.h:
2280         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2281         (-[TestWKWebView activatedElementAtPosition:]):
2282
2283 2017-07-22  Chris Dumez  <cdumez@apple.com>
2284
2285         REGRESSION(r204565): WKObject is broken
2286         https://bugs.webkit.org/show_bug.cgi?id=174736
2287         <rdar://problem/33246169>
2288
2289         Reviewed by Dan Bernstein.
2290
2291         Add API test that used to crash.
2292
2293         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
2294         (TestWebKitAPI::TEST):
2295
2296 2017-07-22  Yusuke Suzuki  <utatane.tea@gmail.com>
2297
2298         [WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult
2299         https://bugs.webkit.org/show_bug.cgi?id=174705
2300
2301         Reviewed by Mark Lam.
2302
2303         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
2304         (TestWebKitAPI::testThreadGroup):
2305         (TestWebKitAPI::TEST):
2306
2307 2017-07-21  Jonathan Bedard  <jbedard@apple.com>
2308
2309         Fail gracefully when xcrun fails in IOSSimulatorPort constructor
2310         https://bugs.webkit.org/show_bug.cgi?id=174724
2311
2312         Reviewed by Aakash Jain.
2313
2314         * Scripts/webkitpy/port/ios_simulator.py:
2315         (IOSSimulatorPort.__init__): Ignore any errors when attempting to find a running
2316         simulator. Errors here should be treated the same as no simulators found.
2317
2318 2017-07-21  Yousuke Kimoto  <Yousuke.Kimoto@sony.com>
2319
2320         [CMake] Add an option to stop build after generating project files
2321         https://bugs.webkit.org/show_bug.cgi?id=174664
2322
2323         Reviewed by Konstantin Tokarev.
2324
2325         Add "--generate-project-only" to stop build after generating project files.
2326
2327         * Scripts/build-webkit: Add '--generate-project-only' option and a checker to stop build.
2328         * Scripts/webkitdirs.pm: Add a function to check '--generate-project-only' option and the same checker as the above
2329         (buildCMakeProjectOrExit): Add a cheker to stop build stop build after generating project files.
2330         (determineIsGenerateProjectOnly): Check if '--generate-project-only' option is specified
2331         (isGenerateProjectOnly): ditto
2332
2333 2017-07-21  Yusuke Suzuki  <utatane.tea@gmail.com>
2334
2335         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
2336         https://bugs.webkit.org/show_bug.cgi?id=174501
2337
2338         Reviewed by Darin Adler.
2339
2340         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2341         (TestWebKitAPI::TEST):
2342
2343 2017-07-20  David Quesada  <david_quesada@apple.com>
2344
2345         Add SPI to notify WKNavigationDelegate about client redirects
2346         https://bugs.webkit.org/show_bug.cgi?id=174680
2347         rdar://problem/33184886
2348
2349         Reviewed by Brady Eidson.
2350
2351         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2352         (-[DidPerformClientRedirectNavigationDelegate _webView:didPerformClientRedirectForNavigation:]):
2353         (TEST):
2354         Add API test for -[id<WKNavigationDelegatePrivate> _webView:didPerformClientRedirectForNavigation:].
2355
2356 2017-07-20  Brady Eidson  <beidson@apple.com>
2357
2358         Test WebKit2CustomProtocolsTest.ProcessPoolDestroyedDuringLoading added in r219664 fails on El Capitan.
2359         https://bugs.webkit.org/show_bug.cgi?id=174685
2360
2361         Reviewed by Andy Estes.
2362
2363         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2364         (TestWebKitAPI::TEST): Use a scoped AutodrainedPool instead of a RetainPtr<NSAutoreleasePool>.
2365
2366 2017-07-20  Brady Eidson  <beidson@apple.com>
2367
2368         Deprecate WebIconDatabase in WebKitLegacy/mac.
2369         https://bugs.webkit.org/show_bug.cgi?id=174607
2370
2371         Reviewed by Alex Christensen.
2372
2373         * DumpRenderTree/mac/TestRunnerMac.mm:
2374
2375 2017-07-20  Jonathan Bedard  <jbedard@apple.com>
2376
2377         lint-test-expectations should be run during style checking
2378         https://bugs.webkit.org/show_bug.cgi?id=173559
2379         <rdar://problem/32854941>
2380
2381         Reviewed by Aakash Jain.
2382
2383         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2384         (TestExpectationsModel._already_seen_better_match): Append returns 'None' when successful,
2385         prevents identifying errors on specific lines in a file.
2386         * Scripts/webkitpy/style/main_unittest.py:
2387         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Test for the
2388         case where a linter error is in the file modified, but the line modified is not related to
2389         the linter error.
2390
2391 2017-07-20  Brady Eidson  <beidson@apple.com>
2392
2393         Remove WebIconDatabase from WebKitLegacy/win.
2394         https://bugs.webkit.org/show_bug.cgi?id=174608
2395
2396         Reviewed by Alex Christensen.
2397
2398         * DumpRenderTree/win/DumpRenderTree.cpp:
2399         (main):
2400         * DumpRenderTree/win/TestRunnerWin.cpp:
2401         (TestRunner::setIconDatabaseEnabled):
2402
2403 2017-07-20  Zan Dobersek  <zdobersek@igalia.com>
2404
2405         [WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
2406         https://bugs.webkit.org/show_bug.cgi?id=174671
2407
2408         Reviewed by Carlos Garcia Campos.
2409
2410         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
2411         (HeadlessViewBackend::HeadlessViewBackend): Use the RunLoopDispatcher
2412         priority for this source in order to have it dispatched on the same
2413         priority as the other WebKit-controlled GSource objects.
2414
2415 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
2416
2417         lint-test-expectations should be run during style checking
2418         https://bugs.webkit.org/show_bug.cgi?id=173559
2419         <rdar://problem/32854941>
2420
2421         Reviewed by Daniel Bates.
2422
2423         Follow up fix addressing style and a few minor bugs.
2424
2425         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2426         (TestExpectationParser.__init__): Use lambda x: x instead of str
2427         (TestExpectationsModel.__init__): Make lambda x: x the default argument.
2428         (TestExpectationsModel._already_seen_better_match): Use a temporary variable to
2429         reduce the calls of _shorten_filename, fix minor bug in appending the current
2430         expectation's line number instead of the previous ones, clarify treatment of None
2431         in file-to-line-number mapping.
2432         (TestExpectations._report_warnings): Collapse call.
2433         * Scripts/webkitpy/style/checkers/test_expectations.py:
2434         (TestExpectationsChecker.lint_test_expectations):
2435         * Scripts/webkitpy/style/filereader.py: Re-write comment.
2436         (TextFileReader.process_file): Add comment explaining treatment of None in
2437         file-to-line-number mapping.
2438         (TextFileReader.delete_file): Collapse call.
2439
2440 2017-07-19  Chris Dumez  <cdumez@apple.com>
2441
2442         Unreviewed attempt to fix API test failure after r219663.
2443
2444         The test was hard-coding an exception string and the string has changed slightly
2445         in r219663.
2446
2447         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2448         (TEST):
2449
2450 2017-07-19  Megan Gardner  <megan_gardner@apple.com>
2451
2452         Don't write file URLs to iOS Pasteboard
2453         https://bugs.webkit.org/show_bug.cgi?id=174647
2454         <rdar://problem/33199730>
2455
2456         Reviewed by Wenson Hsieh.
2457
2458         Updating tests to reflect the lack of file URLs for images.
2459
2460         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2461         (checkTypeIdentifierAndIsNotOtherTypeIdentifier):
2462         (checkEstimatedSize):
2463         (TestWebKitAPI::TEST):
2464
2465 2017-07-19  Brady Eidson  <beidson@apple.com>
2466
2467         iBooks sometimes crashes when closing a book.
2468         <rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658
2469
2470         Reviewed by Oliver Hunt.
2471
2472         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2473         (-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
2474         (-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
2475         (-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
2476         (TestWebKitAPI::TEST):
2477
2478         Add a "spin the runloop X number of times" utility:
2479         * TestWebKitAPI/Utilities.h:
2480         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
2481         (TestWebKitAPI::Util::spinRunLoop):
2482
2483 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
2484
2485         lint-test-expectations should be run during style checking
2486         https://bugs.webkit.org/show_bug.cgi?id=173559
2487         <rdar://problem/32854941>
2488
2489         Reviewed by David Kilzer.
2490
2491         Running the test expectation linter requires reading both files and lines not in the
2492         patch because, for example, deletion of a test can cause a lint failure even though
2493         no test expectations where modified. This means that the linter will occasionally warn
2494         about lines which were not changed in a given patch but whose error is related to a
2495         change made in that patch.
2496
2497         * Scripts/webkitpy/common/system/filesystem_mock.py:
2498         (MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.
2499         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2500         (TestExpectationWarning): Added class to pass warnings as an object instead of a string.
2501         (TestExpectationWarning.__init__): Construct warning with file name, line number, line
2502         content, description of the error and the name of the associated test.
2503         (TestExpectationWarning.__str__): Convert to string so that existing printing code works.
2504         (TestExpectationParser.__init__): Pass shorten_filename function to
2505         TestExpectationsParser to add a deleted file to the related_files dictionary.
2506         (TestExpectationParser._check_test_exists): If the test does not exist, add the
2507         missing path to the related_files dictionary.
2508         (TestExpectationLine.__init__): Add related_files dictionary, which tracks
2509         files and line numbers related to this test expectation line. This will allow
2510         tracking linter errors in the style checker occurring across multiple files.
2511         (TestExpectationsModel._already_seen_better_match): Add redundant expectation
2512         lines to related_files dictionary.
2513         (TestExpectations.__init__): Pass self._shorten_filename to TestExpectationParser.
2514         (TestExpectations._report_warnings): Construct warning object instead of string
2515         when adding to warnings list.
2516         * Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to
2517         clean-up log.
2518         * Scripts/webkitpy/style/checker.py:
2519         (ProcessorBase.do_association_check): Add required function for processor classes.
2520         (StyleProcessor):
2521         (StyleProcessor.do_association_check): Run the TestExpectations linter when
2522         checking for errors between associated files.
2523         * Scripts/webkitpy/style/checkers/test_expectations.py:
2524         (TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
2525         (TestExpectationsChecker):
2526         (TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
2527         of modified files, the current working directory and the host, determine if the linter
2528         warning is associated with the changes.
2529         (TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
2530         style checker.
2531         * Scripts/webkitpy/style/filereader.py:
2532         (TextFileReader):
2533         (TextFileReader.__init__): Track modified files in dictionary instead of a counter.
2534         (TextFileReader.file_count): Use dictionary to determine the number of modified files.
2535         (TextFileReader.process_file): Track both the number of files changed and which lines
2536         in those files were changed.
2537         (TextFileReader.do_association_check): Run the processor's association check on all
2538         modified or deleted files processed by TextFileReader.
2539         (TextFileReader.delete_file): Track deleted files in _files dictionary.
2540         (TextFileReader.count_delete_only_file): Deleted.
2541         * Scripts/webkitpy/style/filereader_unittest.py:
2542         (TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
2543         (TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.
2544         * Scripts/webkitpy/style/main.py:
2545         (CheckWebKitStyle.main): When running the style checker on a specific list of files,
2546         explicitly run the association check on the file reader.
2547         * Scripts/webkitpy/style/main_unittest.py:
2548         (ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
2549         embedded in the style checker.
2550         (ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
2551         (ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
2552         construct the TextFileReader object with a StyleProcessor used to run style checks on
2553         specific files.
2554         (ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
2555         testing the test expectation linter inside the style checker. This host must contain a
2556         mock file system with the basic structure of test expectations.
2557         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
2558         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
2559         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
2560         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
2561         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):
2562         * Scripts/webkitpy/style/patchreader.py:
2563         (PatchReader.check): Specify which file was deleted, run the association check.
2564         * Scripts/webkitpy/style/patchreader_unittest.py:
2565         (PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
2566         (PatchReaderTest.MockTextFileReader.do_association_check): Added.
2567         (PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.
2568
2569 2017-07-19  Yusuke Suzuki  <utatane.tea@gmail.com>
2570
2571         [WTF] Implement WTF::ThreadGroup
2572         https://bugs.webkit.org/show_bug.cgi?id=174081
2573
2574         Reviewed by Mark Lam.
2575
2576         Add WTF::ThreadGroup tests.
2577
2578         * TestWebKitAPI/CMakeLists.txt:
2579         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2580         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
2581         (TestWebKitAPI::testThreadGroup):
2582         (TestWebKitAPI::TEST):
2583
2584 2017-07-18  Andy Estes  <aestes@apple.com>
2585
2586         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
2587         https://bugs.webkit.org/show_bug.cgi?id=174631
2588
2589         Reviewed by Tim Horton.
2590
2591         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2592         * MiniBrowser/Configurations/Base.xcconfig:
2593         * MobileMiniBrowser/Configurations/Base.xcconfig:
2594         * TestWebKitAPI/Configurations/Base.xcconfig:
2595         * WebKitTestRunner/Configurations/Base.xcconfig:
2596
2597 2017-07-18  Andy Estes  <aestes@apple.com>
2598
2599         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
2600         https://bugs.webkit.org/show_bug.cgi?id=174631
2601
2602         Reviewed by Sam Weinig.
2603
2604         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2605         * MiniBrowser/Configurations/Base.xcconfig:
2606         * MobileMiniBrowser/Configurations/Base.xcconfig:
2607         * TestWebKitAPI/Configurations/Base.xcconfig:
2608         * WebKitTestRunner/Configurations/Base.xcconfig:
2609
2610 2017-07-18  Daniel Bates  <dabates@apple.com>
2611
2612         lldb: Add type summary for StringView
2613         https://bugs.webkit.org/show_bug.cgi?id=174637
2614
2615         Reviewed by Sam Weinig.
2616
2617         For debugging convenience, adds a pretty-print type summary for StringView. Evaluating a
2618         StringView object will print output that has the form:
2619
2620             (WTF::StringView) $4 = { length = 2, contents = 'li' } {
2621               m_characters = 0x000000011b57abb5 "eeeeeefjh0n"
2622               m_length = 2
2623               m_is8Bit = true
2624               m_underlyingString = 0x0000614000000a90
2625             }
2626
2627         * lldb/lldb_webkit.py:
2628         (__lldb_init_module): Use WTFStringView_SummaryProvider to format StringView types.
2629         (WTFStringView_SummaryProvider):
2630         (WTFStringViewProvider):
2631         (WTFStringViewProvider.__init__):
2632         (WTFStringViewProvider.is_8bit): Access field StringView.m_is8Bit.
2633         (WTFStringViewProvider.get_length): Access field StringView.m_length.
2634         (WTFStringViewProvider.get_characters): Access field StringView.m_characters.
2635         (WTFStringViewProvider.to_string): Returns the string represented by the StringView.
2636
2637 2017-07-18  Andy Estes  <aestes@apple.com>
2638
2639         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
2640         https://bugs.webkit.org/show_bug.cgi?id=174631
2641
2642         Reviewed by Dan Bernstein.
2643
2644         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2645         * MiniBrowser/Configurations/Base.xcconfig:
2646         * MobileMiniBrowser/Configurations/Base.xcconfig:
2647         * TestWebKitAPI/Configurations/Base.xcconfig:
2648         * WebKitTestRunner/Configurations/Base.xcconfig:
2649
2650 2017-07-18  Devin Rousso  <drousso@apple.com>
2651
2652         Web Inspector: Add memoryCost to Inspector Protocol objects
2653         https://bugs.webkit.org/show_bug.cgi?id=174478
2654
2655         Reviewed by Joseph Pecoraro.
2656
2657         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2658         * TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp: Added.
2659         (TestWebKitAPI::TEST(InspectorValue, MemoryCostNull)):
2660         (TestWebKitAPI::TEST(InspectorValue, MemoryCostBoolean)):
2661         (TestWebKitAPI::TEST(InspectorValue, MemoryCostDouble)):
2662         (TestWebKitAPI::TEST(InspectorValue, MemoryCostInteger)):
2663         (TestWebKitAPI::TEST(InspectorValue, MemoryCostString)):
2664         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringEmpty)):
2665         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringNull)):
2666         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringGrowing)):
2667         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringUnicode)):
2668         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObject)):
2669         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectEmpty)):
2670         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectGrowing)):
2671         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArray)):
2672         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayEmpty)):
2673         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayGrowing)):
2674
2675 2017-07-18  Andy Estes  <aestes@apple.com>
2676
2677         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
2678         https://bugs.webkit.org/show_bug.cgi?id=174631
2679
2680         Reviewed by Darin Adler.
2681
2682         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2683         * MiniBrowser/Configurations/Base.xcconfig:
2684         * MobileMiniBrowser/Configurations/Base.xcconfig:
2685         * TestWebKitAPI/Configurations/Base.xcconfig:
2686         * WebKitTestRunner/Configurations/Base.xcconfig:
2687
2688 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2689
2690         Unreviewed, fix the iOS build.
2691
2692         I missed a spot when renaming -synchronouslyLoadHTML: to -synchronouslyLoadHTMLString:.
2693
2694         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2695         (TestWebKitAPI::TEST):
2696
2697 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2698
2699         [iOS DnD] Web process uses too much memory when beginning a drag on a very large image
2700         https://bugs.webkit.org/show_bug.cgi?id=174585
2701         <rdar://problem/33302541>
2702
2703         Reviewed by Tim Horton.
2704
2705         Adds a new test verifying that we don't try to allocate any image buffer equal to the true size of the image
2706         being dragged when initiating a drag.
2707
2708         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2709         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Added.
2710         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2711         (TestWebKitAPI::TEST):
2712         * TestWebKitAPI/cocoa/TestWKWebView.h:
2713
2714         Add a new -synchronouslyLoadHTMLString: helper that works like -synchronouslyLoadTestPage:, but takes markup.
2715
2716         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2717         (-[TestWKWebView synchronouslyLoadHTMLString:]):
2718
2719 2017-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2720
2721         [CMake] Macros in WebKitMacros.cmake should be prefixed with WEBKIT_ namespace
2722         https://bugs.webkit.org/show_bug.cgi?id=174547
2723
2724         Reviewed by Alex Christensen.
2725
2726         * DumpRenderTree/PlatformWin.cmake:
2727         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2728
2729 2017-07-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2730
2731         Update style checker to deal with "final"
2732         https://bugs.webkit.org/show_bug.cgi?id=174528
2733
2734         Reviewed by Alex Christensen.
2735         
2736         check-webkit-style shouldn't complain about an open brace to start a
2737         line after a function definition with "final" or "const final".
2738
2739         * Scripts/webkitpy/style/checkers/cpp.py:
2740         (check_braces):
2741         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2742         (CppStyleTest.test_brace_at_begin_of_line):
2743
2744 2017-07-17  Alex Christensen  <achristensen@webkit.org>
2745
2746         Modernize content extension code
2747         https://bugs.webkit.org/show_bug.cgi?id=174588
2748
2749         Reviewed by Sam Weinig.
2750
2751         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2752         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
2753         (TestWebKitAPI::testRequest):
2754         (TestWebKitAPI::makeBackend):
2755         (TestWebKitAPI::TEST_F):
2756
2757 2017-07-17  Brady Eidson  <beidson@apple.com>
2758
2759         WKHTTPCookieStore observing only works on the default cookie store.
2760         <rdar://problem/33330724> and https://bugs.webkit.org/show_bug.cgi?id=174580
2761
2762         Reviewed by Sam Weinig.
2763
2764         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2765         (runTestWithWebsiteDataStore): Refactor the cookie observing test out so it can be
2766           called for the default store, a non-persistent store, and a custom store.
2767         (TEST):
2768
2769 2017-07-16  Sam Weinig  <sam@webkit.org>
2770
2771         [Scripts] Fix missing variable warnings from svn-create-patch when there are untracked files
2772         https://bugs.webkit.org/show_bug.cgi?id=174575
2773
2774         Reviewed by Brady Eidson.
2775
2776         * Scripts/svn-create-patch:
2777         (findModificationType):
2778         Add support for more status codes. C -> conflicted, ? -> untracked, ! -> missing. Give a
2779         default value of "unknown".
2780
2781         (generateFileList):
2782         Handle all the new modification types. Abort on conflicted, missing, and unknown. Log
2783         for untracked, which matches our old behavior.
2784
2785 2017-07-17  Charlie Turner  <cturner@igalia.com>
2786
2787         Add some missing build dependencies on Fedora
2788         https://bugs.webkit.org/show_bug.cgi?id=174578
2789
2790         Unreviewed dependency update.
2791
2792         * gtk/install-dependencies:
2793
2794 2017-07-16  Brady Eidson  <beidson@apple.com>
2795
2796         Crash when a WKHTTPCookieStore outlives its owning WKWebsiteDataStore.
2797         <rdar://problem/33341730> and https://bugs.webkit.org/show_bug.cgi?id=174574
2798
2799         Reviewed by Tim Horton.
2800
2801         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2802         (-[CookieNavigationDelegate webView:didFinishNavigation:]):
2803         (TEST):
2804
2805 2017-07-16  Bernhard M. Wiedemann  <bwiedemann@suse.de>
2806
2807         [GTK] Sort inspector GResource manifest to ensure reproducible builds
2808         https://bugs.webkit.org/show_bug.cgi?id=174540
2809
2810         Reviewed by Michael Catanzaro.
2811
2812         * gtk/generate-inspector-gresource-manifest.py:
2813         (get_filenames): sort list of input files
2814
2815 2017-07-15  Brady Eidson  <beidson@apple.com>
2816
2817         Make sure all CFHTTPCookieStorageRefs we create are scheduled.
2818         <rdar://problem/33221110> and https://bugs.webkit.org/show_bug.cgi?id=174513
2819
2820         Reviewed by Tim Horton.
2821
2822         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2823         (TEST): Make this test more reliable by clearing everything beforehand.
2824
2825 2017-07-15  David Kilzer  <ddkilzer@apple.com>
2826
2827         Make it possible to extend check-webkit-style with Apple-internal checkers
2828         <https://webkit.org/b/174464>
2829         <rdar://problem/25564402>
2830
2831         Reviewed by Darin Adler.
2832
2833         * Scripts/webkitpy/style/checker.py: Import apple_additions.
2834         (_all_categories): Add categories from apple_additions() if it
2835         exists.
2836         (CheckerDispatcher._create_checker): Create python checker
2837         from apple_additions() if it exists.
2838
2839 2017-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2840
2841         [iOS WK2] Presenting an action sheet on an image map prevents selection UI from updating
2842         https://bugs.webkit.org/show_bug.cgi?id=174539
2843         <rdar://problem/33307395>
2844
2845         Reviewed by Darin Adler.
2846
2847         Adds a new unit test suite to cover action sheet popover presentation.
2848
2849         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2850         * TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Added.
2851         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm: Added.
2852         (-[ActionSheetObserver waitForActionSheetAfterBlock:]):
2853
2854         Runs the given block and waits until the UI process has indicated that it will present an action sheet.
2855
2856         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
2857         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
2858
2859         Helper class to alter the behavior of [[UIDevice currentDevice] userInterfaceIdiom] for testing.
2860
2861         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
2862         (TestWebKitAPI::TEST):
2863
2864 2017-07-15  Sam Weinig  <sam@webkit.org>
2865
2866         [Scripts] Make svn-create-patch work better when called in sub directories
2867         https://bugs.webkit.org/show_bug.cgi?id=174551
2868
2869         Reviewed by Darin Adler.
2870
2871         - Fixes manufacturePatchForAdditionWithHistory to use the correct path
2872           by ensuring that the prefix is applied as is done in generateDiff.
2873         - Silence output of explanatory lines from svn stat (" > move to ...")
2874           that show up in STDERR when running svn-create-patch.
2875         - Add verbose logging that I found useful while debugging this issue.
2876
2877         * Scripts/svn-create-patch:
2878         (findBaseUrl):
2879         (findMimeType):
2880         (findSourceFileAndRevision):
2881         (generateDiff):
2882         (generateFileList):
2883         (manufacturePatchForAdditionWithHistory):
2884
2885 2017-07-15  Jonathan Bedard  <jbedard@apple.com>
2886
2887         Unreviewed build fix after r219537.
2888
2889         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2890
2891 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
2892
2893         Add iOS 11 SPI
2894         https://bugs.webkit.org/show_bug.cgi?id=174430
2895         <rdar://problem/33269288>
2896
2897         Reviewed by Tim Horton.
2898
2899         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Define drag-and-drop API required for testing.
2900         * TestWebKitAPI/ios/DataInteractionSimulator.h: Ditto.
2901         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Ditto.
2902
2903 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
2904
2905         Failing to install on iPad simulators
2906         https://bugs.webkit.org/show_bug.cgi?id=174532
2907         <rdar://problem/33328347>
2908
2909         Reviewed by Stephanie Lewis.
2910
2911         * Scripts/webkitpy/xcode/simulated_device.py:
2912         (SimulatedDevice.install_app): Place install command in retry try-except block.
2913
2914 2017-07-14  Jeff Miller  <jeffm@apple.com>
2915
2916         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
2917         https://bugs.webkit.org/show_bug.cgi?id=174524
2918
2919         Reviewed by Sam Weinig.
2920
2921         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
2922         (TEST):
2923         Renamed TestParameter to TestParameter1.
2924         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
2925
2926         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
2927         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2928         Observe changes for two bundle parameters.
2929
2930         (-[BundleParametersPlugIn dealloc]):
2931         Remove observers for two bundle parameters.
2932
2933 2017-07-14  Commit Queue  <commit-queue@webkit.org>
2934
2935         Unreviewed, rolling out r219510.
2936         https://bugs.webkit.org/show_bug.cgi?id=174525
2937
2938         Need to revert length() == 0 check for null string (Requested
2939         by yusukesuzuki on #webkit).
2940
2941         Reverted changeset:
2942
2943         "[WTF] Newly added AtomicStringImpl should use BufferInternal
2944         static string if StringImpl is static"
2945         https://bugs.webkit.org/show_bug.cgi?id=174501
2946         http://trac.webkit.org/changeset/219510
2947
2948 2017-07-14  Jer Noble  <jer.noble@apple.com>
2949
2950         [MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
2951         https://bugs.webkit.org/show_bug.cgi?id=174514
2952
2953         Reviewed by Sam Weinig.
2954
2955         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
2956         (TestWebKitAPI::TEST_F):
2957
2958 2017-07-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2959
2960         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
2961         https://bugs.webkit.org/show_bug.cgi?id=174501
2962
2963         Reviewed by Darin Adler.
2964
2965         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2966         (TestWebKitAPI::TEST):
2967
2968 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
2969
2970         Bring mac expectations in-line with other platforms
2971         https://bugs.webkit.org/show_bug.cgi?id=174472
2972         <rdar://problem/33297388>
2973
2974         Reviewed by David Kilzer.
2975
2976         The override order for Mac test expectations does not conform to the pattern used by iOS,
2977         GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
2978
2979             platform/mac-wk2
2980             platform/wk2
2981             platform/mac-elcapitan
2982             platform/mac-sierra
2983             generic
2984
2985         After this change, El Capitan's baseline search path looks like this:
2986
2987             platform/mac-sierra-wk2
2988             platform/mac-sierra
2989             platform/mac-wk2
2990             platform/wk2
2991             generic
2992
2993         * Scripts/webkitpy/port/mac.py:
2994         (MacPort.__init__): If a specific version is specified in the port name, use that
2995         as the os version.
2996         (MacPort.default_baseline_search_path): Expectation search paths should work the
2997         same way they do on other ports. Port + version overrides port, port overrides generic
2998         and wk1/wk2 should override expectations for the two combined.
2999         * Scripts/webkitpy/port/mac_unittest.py:
3000         (MacTest.test_tests_for_other_platforms): Deleted.
3001         (MacTest._assert_search_path): Deleted.
3002         (MacTest.test_baseline_search_path): Deleted.
3003         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3004         (TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
3005         (test_rebaseline_test_and_print_scm_changes): Ditto.
3006         (test_rebaseline_and_copy_test): Ditto.
3007         (test_rebaseline_and_copy_test_no_existing_result): Ditto.
3008         (test_rebaseline_and_copy_test_with_lion_result): Ditto.
3009         (test_rebaseline_and_copy_no_overwrite_test): Ditto.
3010
3011 2017-07-13  Michael Catanzaro  <mcatanzaro@igalia.com>
3012
3013         Fix style checker unit test
3014
3015         Unreviewed WebKit2 => WebKit fixup.
3016
3017         * Scripts/webkitpy/style/checker_unittest.py:
3018         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
3019
3020 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3021
3022         Use the old WebKit/WebKit2 targets for CMake builds. (v2)
3023
3024         Unreviewed build fix.
3025
3026         r219492 missed one hunk from its partial revert of r219489.
3027         This patch reverts that hunk.
3028
3029         * TestWebKitAPI/CMakeLists.txt:
3030
3031 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3032
3033         Use the old WebKit/WebKit2 targets for CMake builds.
3034
3035         Unreviewed build fix.
3036
3037         We can update the target names to match the Framework names in a future patch.
3038         This is a partial revert of r219489.
3039
3040         * TestWebKitAPI/CMakeLists.txt:
3041         WebKitLegacy => WebKit
3042         WebKit => WebKit2
3043
3044 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3045
3046         Fix TestWebKit API.
3047         https://bugs.webkit.org/show_bug.cgi?id=174164
3048         rdar://problem/33137595
3049
3050         Reviewed by Dan Bernstein.
3051
3052         * TestWebKitAPI/CMakeLists.txt:
3053         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3054         * TestWebKitAPI/PlatformGTK.cmake:
3055
3056 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3057
3058         Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
3059         https://bugs.webkit.org/show_bug.cgi?id=174164
3060         rdar://problem/33137595
3061
3062         Reviewed by Dan Bernstein.
3063
3064         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3065         (ShouldBuildTest):
3066         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3067         * Scripts/build-webkit:
3068         * Scripts/do-file-rename:
3069         * Scripts/do-webcore-rename:
3070         * Scripts/update-webkit-localizable-strings:
3071         * Scripts/webkitpy/common/config/watchlist:
3072         * Scripts/webkitpy/style/checker.py:
3073         * Scripts/webkitpy/style/checkers/featuredefines.py:
3074         * gtk/make-dist.py:
3075         (ensure_version_if_possible):
3076         * gtk/manifest.txt.in:
3077
3078 2017-07-05  Matthew Hanson  <matthew_hanson@apple.com>
3079
3080         Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
3081         https://bugs.webkit.org/show_bug.cgi?id=174162
3082         rdar://problem/33137594
3083
3084         Reviewed by Dan Bernstein.
3085
3086         Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource tooling.
3087
3088         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3089         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
3090         * EWSTools/configure-clang-linux.sh:
3091         * Scripts/build-webkit:
3092         * Scripts/do-file-rename:
3093         * Scripts/do-webcore-rename:
3094         * Scripts/update-webkit-localizable-strings:
3095         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3096         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
3097         * Scripts/webkitpy/style/checkers/featuredefines.py:
3098         * gtk/manifest.txt.in:
3099
3100 2017-07-13  Jonathan Bedard  <jbedard@apple.com>
3101
3102         Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
3103         https://bugs.webkit.org/show_bug.cgi?id=174438
3104         <rdar://problem/33277112>
3105
3106         Reviewed by Aakash Jain.
3107
3108         Given a patch, this will convert the changes from the path to the new directory structure.
3109
3110         * Scripts/rebase-patch-after-webkit-move: Added.
3111         (append_source): Append 'Source' to the provided path.
3112         (is_editable_line): Return true if a line the script expects to modify.
3113         (needs_rebase): Return if a line needs to be rebased based on it's content.
3114         (rebase_line): Rebase the provided line.
3115         (rebase): Rebase a patch given the lines of that patch and a file to output the rebased patch to.
3116         (parse_arguments): Parse the command line arguments and return the patches to be rebased, if they
3117         were provided.
3118
3119 2017-07-12  Nan Wang  <n_wang@apple.com>
3120
3121         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
3122         https://bugs.webkit.org/show_bug.cgi?id=174393
3123         <rdar://problem/33248006>
3124
3125         Reviewed by Chris Fleizach.
3126
3127         * DumpRenderTree/AccessibilityUIElement.cpp:
3128         (textMarkerRangeMatchesTextNearMarkersCallback):
3129         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3130         (AccessibilityUIElement::getJSClass):
3131         * DumpRenderTree/AccessibilityUIElement.h:
3132         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3133         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3134         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3135         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3136         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3137         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3138         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3139         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3140
3141 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3142
3143         Unreviewed, rolling out r219409.
3144
3145         The revision caused the Windows builds to fail.
3146
3147         Reverted changeset:
3148
3149         "AX: [iOS] Implement a way to retrieve a text marker range
3150         with desired text that is closest to a position"
3151         https://bugs.webkit.org/show_bug.cgi?id=174393
3152         http://trac.webkit.org/changeset/219409
3153
3154 2017-07-12  Nan Wang  <n_wang@apple.com>
3155
3156         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
3157         https://bugs.webkit.org/show_bug.cgi?id=174393
3158         <rdar://problem/33248006>
3159
3160         Reviewed by Chris Fleizach.
3161
3162         * DumpRenderTree/AccessibilityUIElement.cpp:
3163         (textMarkerRangeMatchesTextNearMarkersCallback):
3164         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3165         (AccessibilityUIElement::getJSClass):
3166         * DumpRenderTree/AccessibilityUIElement.h:
3167         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3168         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3169         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3170         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3171         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3172         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3173         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3174         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3175
3176 2017-07-12  Emilio Cobos Álvarez  <ecobos@igalia.com>
3177
3178         Make prepare-ChangeLog -g <commit> generate a more standard ChangeLog entry.
3179         https://bugs.webkit.org/show_bug.cgi?id=174197
3180
3181         Reviewed by Darin Adler.
3182
3183         This bit me the first time I tried to submit a patch to WebKit, and still I have
3184         to manually edit the ChangeLog every time I use the script.
3185
3186         This generates a more convenient and standard ChangeLog entry.
3187
3188         * Scripts/prepare-ChangeLog:
3189         (generateNewChangeLogs):
3190
3191 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3192
3193         Unreviewed, rolling out r219401.
3194
3195         This revision rolled out the previous patch, but after talking
3196         with reviewer, a rebaseline is what was needed.Rolling back in
3197         before rebaseline.
3198
3199         Reverted changeset:
3200
3201         "Unreviewed, rolling out r219379."
3202         https://bugs.webkit.org/show_bug.cgi?id=174400
3203         http://trac.webkit.org/changeset/219401
3204
3205 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3206
3207         Unreviewed, rolling out r219379.
3208
3209         This revision caused a consistent failure in the test
3210         fast/dom/Window/property-access-on-cached-window-after-frame-
3211         removed.html.
3212
3213         Reverted changeset:
3214
3215         "Remove NAVIGATOR_HWCONCURRENCY"
3216         https://bugs.webkit.org/show_bug.cgi?id=174400
3217         http://trac.webkit.org/changeset/219379
3218
3219 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
3220
3221         [WPE] Use libepoxy
3222         https://bugs.webkit.org/show_bug.cgi?id=172104
3223
3224         Reviewed by Michael Catanzaro.
3225
3226         * WebKitTestRunner/wpe/HeadlessViewBackend.h:
3227         Include the <epoxy/egl.h> header, dropping the EGL and GLES2 inclusions.
3228
3229 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
3230
3231         [GTK][WPE] Align Jhbuild patches for GStreamer packages
3232         https://bugs.webkit.org/show_bug.cgi?id=174363
3233
3234         Reviewed by Michael Catanzaro.
3235
3236         Align the patches we apply over Jhbuild-managed GStreamer dependency packages
3237         between the GTK+ and WPE port. There's no reason for the two ports to apply
3238         different patches over same versions of GStreamer releases.
3239
3240         This aligns the two ports on this specific issue. Next we'll look into
3241         creating a single GStreamer-specific Jhbuild moduleset that will allow us
3242         to keep these patches in a single place, avoiding duplicate files.
3243
3244         * gtk/jhbuild.modules:
3245         * gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
3246         * gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch.
3247         * gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
3248         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Removed.
3249
3250 2017-07-11  Dean Jackson  <dino@apple.com>
3251
3252         Remove NAVIGATOR_HWCONCURRENCY
3253         https://bugs.webkit.org/show_bug.cgi?id=174400
3254
3255         Reviewed by Sam Weinig.
3256
3257         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3258
3259 2017-07-11  Ansh Shukla  <ansh_shukla@apple.com>
3260
3261         WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration properties
3262         https://bugs.webkit.org/show_bug.cgi?id=174239
3263
3264         Reviewed by Brady Eidson.
3265
3266         Create windows with specific features set and make sure those are properly reflected in the
3267         WKWindowFeatures object.
3268
3269         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
3270         (resetToConsistentState):
3271         (-[CheckWindowFeaturesUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3272         (TEST):
3273
3274 2017-07-11  Jonathan Bedard  <jbedard@apple.com>
3275
3276         Do not duplicate files when deleting directories with svn 1.9
3277         https://bugs.webkit.org/show_bug.cgi?id=174339
3278         <rdar://problem/33226781>
3279
3280         Reviewed by David Kilzer.
3281
3282         * Scripts/svn-create-patch:
3283         (diffOptionsForFile): No longer pass -N option, since this does not work in SVN 1.9.4.
3284         (generateFileList): Determine which files are deleted because they are part of a
3285         directory being deleted.
3286
3287 2017-07-11  Dean Jackson  <dino@apple.com>
3288
3289         Rolling out r219372.
3290
3291         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3292
3293 2017-07-11  Dean Jackson  <dino@apple.com>
3294
3295         Remove NAVIGATOR_HWCONCURRENCY
3296         https://bugs.webkit.org/show_bug.cgi?id=174400
3297
3298         Reviewed by Sam Weinig.
3299
3300         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3301
3302 2017-07-11  Lucas Forschler  <lforschler@apple.com>
3303
3304         Teach build workers to fetch archives from S3.
3305         https://bugs.webkit.org/show_bug.cgi?id=174384
3306
3307         Reviewed by Aakash Jain.
3308
3309         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3310         (DownloadBuiltProduct):
3311
3312 2017-07-11  Lucas Forschler  <lforschler@apple.com>
3313
3314         Configure buildbot to transfer all archives to S3.
3315         Previously this was Mac only, but it's time to expand!
3316         https://bugs.webkit.org/show_bug.cgi?id=174378
3317         
3318         Reviewed by Aakash Jain.
3319
3320         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3321         (BuildFactory.__init__):
3322
3323 2017-07-11  Zan Dobersek  <zdobersek@igalia.com>
3324
3325         [WPE] Bump GStreamer packages in jhbuild.modules to 1.10.5
3326         https://bugs.webkit.org/show_bug.cgi?id=174350
3327
3328         Reviewed by Xabier Rodriguez-Calvar.
3329
3330         Bump the various GStreamer dependencies listed in WPE's Jhbuild modules file
3331         to the 1.10.5 version. One gstreamer patch is added. The two gst-plugins-bad
3332         patches are removed. The patches for gst-plugins-good are updated, removing
3333         the stale ones and adding the additional changes to qtdemux, souphttpsrc and
3334         rtpbin elements that will help with the EMEv3 development.
3335
3336         * wpe/jhbuild.modules:
3337         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
3338         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
3339         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added.
3340         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
3341         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Added.
3342         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
3343         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
3344         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
3345         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
3346
3347 2017-07-10  John Wilander  <wilander@apple.com>
3348
3349         Resource Load Statistics: Prune statistics in orders of importance
3350         https://bugs.webkit.org/show_bug.cgi?id=174215
3351         <rdar://problem/33164403>
3352
3353         Reviewed by Chris Dumez.
3354
3355         Nest infrastructure. Adds these functions:
3356         1. testRunner.setStatisticsLastSeen()
3357         2. setStatisticsMaxStatisticsEntries()
3358         3. setStatisticsPruneEntriesDownTo()
3359
3360         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3361         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3362         (WTR::TestRunner::setStatisticsLastSeen):
3363         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
3364         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
3365         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3366         * WebKitTestRunner/TestController.cpp:
3367         (WTR::TestController::setStatisticsLastSeen):
3368         (WTR::TestController::setMaxStatisticsEntries):
3369         (WTR::TestController::setPruneEntriesDownTo):
3370         * WebKitTestRunner/TestController.h:
3371         * WebKitTestRunner/TestInvocation.cpp:
3372         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3373         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3374         (WTR::TestController::setStatisticsLastSeen):
3375         (WTR::TestController::setStatisticsMaxStatisticsEntries):
3376         (WTR::TestController::setStatisticsPruneEntriesDownTo):
3377
3378 2017-07-03  Brian Burg  <bburg@apple.com>
3379
3380         Web Replay: remove some unused code
3381         https://bugs.webkit.org/show_bug.cgi?id=173903
3382
3383         Rubber-stamped by Joseph Pecoraro.
3384
3385         * Scripts/run-input-generator-tests: Removed.
3386         * Scripts/webkitpy/replay/__init__.py: Removed.
3387         * Scripts/webkitpy/replay/main.py: Removed.
3388
3389 2017-07-10  Zan Dobersek  <zdobersek@igalia.com>
3390
3391         [WPE] Fix layout test baseline and TestExpectations hierarchy
3392         https://bugs.webkit.org/show_bug.cgi?id=174092
3393
3394         Reviewed by Michael Catanzaro.
3395
3396         Like for the GTK+ port, override the default_baseline_search_path() and
3397         _port_specific_expectations_files() methods in the webkitpy.port.WPEPort class.
3398         Both methods operate on a short list of search paths that defaults to 'wpe' and
3399         'wk2', along with any other user-specified platform directory.
3400
3401         The test_expectations_file_position() method is overridden for testing purposes,
3402         and relevant unit tests are added.
3403
3404         * Scripts/webkitpy/port/wpe.py:
3405         (WPEPort._search_paths):
3406         (WPEPort):
3407         (WPEPort.default_baseline_search_path):
3408         (WPEPort._port_specific_expectations_files):
3409         (WPEPort.test_expectations_file_position):
3410         * Scripts/webkitpy/port/wpe_unittest.py:
3411         (WPEPortTest.test_default_baseline_search_path):
3412         (WPEPortTest):
3413         (WPEPortTest.test_port_specific_expectations_files):
3414
3415 2017-07-10  Chris Dumez  <cdumez@apple.com>
3416
3417         Further WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore clean up
3418         https://bugs.webkit.org/show_bug.cgi?id=174301
3419
3420         Reviewed by Brent Fulgham.
3421
3422         Rename some of the testRunner API for clarity and to better match what it calls
3423         internally.
3424
3425         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3426         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3427         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
3428         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
3429         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3430         * WebKitTestRunner/TestController.cpp:
3431         (WTR::TestController::statisticsUpdateCookiePartitioning):
3432         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
3433         * WebKitTestRunner/TestController.h:
3434         * WebKitTestRunner/TestInvocation.cpp:
3435         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3436         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3437         (WTR::TestController::statisticsUpdateCookiePartitioning):
3438         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
3439
3440 2017-07-10  Charlie Turner  <cturner@igalia.com>
3441
3442         [GStreamer] Live twitch.tv videos do not play
3443         https://bugs.webkit.org/show_bug.cgi?id=174222
3444
3445         Reviewed by Michael Catanzaro.
3446
3447         Upgrade GStreamer to 1.10.5. It contains a change to typefind that
3448         fixes videos not playing on twitch.tv.
3449
3450         * gtk/jhbuild.modules:
3451
3452 2017-07-09  Zan Dobersek  <zdobersek@igalia.com>
3453
3454         Add WebGL2 configuration option to build-webkit
3455         https://bugs.webkit.org/show_bug.cgi?id=174251
3456
3457         Reviewed by Michael Catanzaro.
3458
3459         * Scripts/webkitperl/FeatureList.pm: Add the 'webgl2' option, making it possible
3460         to enable the ENABLE_WEBGL2 flag through the build-webkit script. The feature
3461         is marked as enabled for the Apple Cocoa ports.
3462
3463 2017-07-08  Chris Dumez  <cdumez@apple.com>
3464
3465         Simplify WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore
3466         https://bugs.webkit.org/show_bug.cgi?id=174290
3467
3468         Reviewed by Brent Fulgham.
3469
3470         Rename testRunner API to match the new internal API names.
3471
3472         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3473         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3474         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
3475         (WTR::TestRunner::statisticsSubmitTelemetry):
3476         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3477         * WebKitTestRunner/TestController.cpp:
3478         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
3479         (WTR::TestController::statisticsSubmitTelemetry):
3480         * WebKitTestRunner/TestController.h:
3481         * WebKitTestRunner/TestInvocation.cpp:
3482         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3483         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3484         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
3485         (WTR::TestController::statisticsSubmitTelemetry):
3486
3487 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
3488
3489         Drop NOSNIFF compile flag
3490         https://bugs.webkit.org/show_bug.cgi?id=174289
3491
3492         Reviewed by Michael Catanzaro.
3493
3494         * Scripts/webkitperl/FeatureList.pm:
3495         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3496
3497 2017-07-07  Wenson Hsieh  <wenson_hsieh@apple.com>
3498
3499         [iOS DnD] For cross-app drags, 'drop' event handlers are never invoked if dataTransfer.dropEffect is not set while dragging
3500         https://bugs.webkit.org/show_bug.cgi?id=174219
3501         <rdar://problem/32083177>
3502
3503         Reviewed by Ryosuke Niwa.
3504
3505         Add plumbing and support to mock the value of -allowsMoveOperation on the simulated UIDragDropSession objects.
3506         Setting the DataInteractionSimulator's shouldAllowMoveOperation property to NO simulates a drag operation coming
3507         in from another app out-of-process, for which move operations won't cause a drop to be performed in the first
3508         place.
3509
3510         Also tweaks 2 existing unit tests regarding file uploads via JavaScript to simulate items coming in from a
3511         different application, and adds a new test to check that if a drop area specifically requests a MOVE operation,
3512         no action is taken when dropping.
3513
3514         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html:
3515         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3516         (TestWebKitAPI::TEST):
3517         * TestWebKitAPI/ios/DataInteractionSimulator.h:
3518         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3519         (-[MockDragDropSession initWithItems:location:window:allowMove:]):
3520         (-[MockDragDropSession allowsMoveOperation]):
3521         (-[MockDataOperationSession initWithProviders:location:window:allowMove:]):
3522         (-[MockDataInteractionSession initWithWindow:allowMove:]):
3523         (-[DataInteractionSimulator initWithWebView:]):
3524         (-[DataInteractionSimulator runFrom:to:]):
3525         (-[DataInteractionSimulator _advanceProgress]):
3526         (-[MockDragDropSession initWithItems:location:window:]): Deleted.
3527         (-[MockDataOperationSession initWithProviders:location:window:]): Deleted.
3528         (-[MockDataInteractionSession initWithWindow:]): Deleted.
3529
3530 2017-07-07  Commit Queue  <commit-queue@webkit.org>
3531
3532         Unreviewed, rolling out r219238, r219239, and r219241.
3533         https://bugs.webkit.org/show_bug.cgi?id=174265
3534
3535         "fast/workers/dedicated-worker-lifecycle.html is flaky"
3536         (Requested by yusukesuzuki on #webkit).
3537
3538         Reverted changesets:
3539
3540         "[WTF] Implement WTF::ThreadGroup"
3541         https://bugs.webkit.org/show_bug.cgi?id=174081
3542         http://trac.webkit.org/changeset/219238
3543
3544         "Unreviewed, build fix after r219238"
3545         https://bugs.webkit.org/show_bug.cgi?id=174081
3546         http://trac.webkit.org/changeset/219239
3547
3548         "Unreviewed, CLoop build fix after r219238"
3549         https://bugs.webkit.org/show_bug.cgi?id=174081
3550         http://trac.webkit.org/changeset/219241
3551
3552 2017-07-07  Yusuke Suzuki  <utatane.tea@gmail.com>
3553
3554         [GTK][WPE] Enable X-Content-Type-Options: nosniff
3555         https://bugs.webkit.org/show_bug.cgi?id=174250
3556
3557         Reviewed by Carlos Alberto Lopez Perez.
3558
3559         * Scripts/webkitperl/FeatureList.pm:
3560
3561 2017-07-07  Charlie Turner  <cturner@igalia.com>
3562         [GStreamer] vid.me videos do not play
3563         https://bugs.webkit.org/show_bug.cgi?id=172240
3564
3565         Reviewed by Xabier Rodriguez-Calvar.
3566
3567         Build httpsoupsrc again for use in adaptive streaming pipelines, and
3568         have the existing libsoup build against GNOME to avoid header drift
3569         against GStreamer's linked Soup library.
3570
3571         * gtk/jhbuild.modules:
3572
3573 2017-07-06  Lucas Forschler  <lforschler@apple.com>
3574
3575         Write a support script to enable buildbot to upload to S3
3576         https://bugs.webkit.org/show_bug.cgi?id=174196
3577         
3578         Reviewed by Stephanie Lewis.
3579
3580         * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Added.
3581         (uploadToS3):
3582         (archiveExists):
3583
3584 2017-07-06  Lucas Forschler  <lforschler@apple.com>
3585
3586         Enabling uploading archives to S3.
3587         https://bugs.webkit.org/show_bug.cgi?id=174198
3588         
3589         Reviewed by Stephanie Lewis.
3590
3591         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3592         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
3593         (UploadMinifiedBuiltProduct): Upload minified archive to build master
3594         (TransferToS3): Transfer full and minified archives to S3
3595
3596 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3597
3598         [WTF] Implement WTF::ThreadGroup
3599         https://bugs.webkit.org/show_bug.cgi?id=174081
3600
3601         Reviewed by Mark Lam.
3602
3603         Add WTF::ThreadGroup tests.
3604