1 2015-04-09 Gyuyoung Kim <gyuyoung.kim@webkit.org>
3 Update my email address and expertise.
4 https://bugs.webkit.org/show_bug.cgi?id=143586
6 Unreviewed, just update my info.
8 * Scripts/webkitpy/common/config/contributors.json:
10 2015-04-09 Joseph Pecoraro <pecoraro@apple.com>
12 Flakiness Dashboard not loading insecure content if loaded with https URL
13 https://bugs.webkit.org/show_bug.cgi?id=143570
15 Reviewed by Alexey Proskuryakov.
17 * TestResultServer/app.yaml:
18 * TestResultServer/static-dashboards/loader.js:
19 Switch to https scheme.
21 2015-04-09 Csaba Osztrogonác <ossy@webkit.org>
23 [EFL][GTK] WebKit2's generate-forwarding-headers.pl runs too many times
24 https://bugs.webkit.org/show_bug.cgi?id=142907
26 Reviewed by Carlos Garcia Campos.
28 * TestWebKitAPI/PlatformEfl.cmake:
29 * TestWebKitAPI/PlatformGTK.cmake:
30 * WebKitTestRunner/PlatformEfl.cmake:
31 * WebKitTestRunner/PlatformGTK.cmake:
33 2015-04-08 Brent Fulgham <bfulgham@apple.com>
35 [Mac] Unreviewed test fix after r182584
36 https://bugs.webkit.org/show_bug.cgi?id=143452
38 Put both of these tests back to their original state now that the underlying
41 * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
42 (TestWebKitAPI::TEST):
43 * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
44 (TestWebKitAPI::TEST):
46 2015-04-08 Filip Pizlo <fpizlo@apple.com>
48 run-jsc-benchmarks geomean of preferred means shouldn't print the VMs header twice
49 https://bugs.webkit.org/show_bug.cgi?id=143553
51 Reviewed by Ryosuke Niwa.
53 Remove the spurious printVMs left over from an earlier change.
55 * Scripts/run-jsc-benchmarks:
57 2015-04-08 Brent Fulgham <bfulgham@apple.com>
59 [Mac] Unreviewed test fix after r182581
61 The behavior of control-left-click is controlled by a system preference.
62 Our test bots have this turned off.
64 * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
65 (TestWebKitAPI::TEST):
66 * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
67 (TestWebKitAPI::TEST):
69 2015-04-08 Brent Fulgham <bfulgham@apple.com>
71 [Mac] WebKit is not honoring OS preferences for secondary click behaviors
72 https://bugs.webkit.org/show_bug.cgi?id=143452
73 <rdar://problem/20437483>
75 Reviewed by Tim Horton.
77 Add a new API test to confirm that Cocoa mouse button press events are properly
78 tagged with the desired menu behavior (i.e., 'None', 'Context', or 'Action'.)
80 The WK2 test dispatches mouse down events to a PlatformWebView, and checks with
81 some registered event handlers that the expected button press and context menu
84 The WK1 unit test creates an NSEvent with the desired button press state, and then
85 uses WebCore::PlatformEventFactory::createPlatformMouseEvent to create a WebCore event.
86 We check the resulting PlatformMouseEvent for proper state.
88 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test files.
89 * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp: Added.
90 (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
91 * TestWebKitAPI/Tests/WebKit2/mouse-button-listener.html: Added.
92 * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm: Added.
93 (TestWebKitAPI::canCallMenuTypeForEvent): Helper function.
94 (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
95 * TestWebKitAPI/mac/PlatformWebViewMac.mm:
96 (TestWebKitAPI::PlatformWebView::simulateButtonClick): Added method to support firing
98 * TestWebKitAPI/mac/PlatformWebViewMac.h:
100 2015-04-08 Michael Catanzaro <mcatanzaro@igalia.com>
102 [GTK] Add pango to jhbuild-optional.modules
103 https://bugs.webkit.org/show_bug.cgi?id=143537
105 Reviewed by Martin Robinson.
107 * gtk/jhbuild-optional.modules: Add pango.
109 2015-04-08 Carlos Alberto Lopez Perez <clopez@igalia.com>
111 [XvfbDriver] Regular expression used to match running X servers fails on Fedora 22.
112 https://bugs.webkit.org/show_bug.cgi?id=143530
114 Reviewed by Žan Doberšek.
116 Assume that the default value for display (:0) is reserved and start checking on :1
117 Adjust webkitpy test and include two new test cases for this bug (display number not specified)
118 and for X server named Xorg.bin (previous bug 1376599)
120 * Scripts/webkitpy/port/xvfbdriver.py:
121 (XvfbDriver._next_free_display)
122 * Scripts/webkitpy/port/xvfbdriver_unittest.py:
123 (XvfbDriverTest.test_start_no_pixel_tests):
124 (XvfbDriverTest.test_start_pixel_tests):
125 (XvfbDriverTest.test_start_arbitrary_worker_number):
126 (XvfbDriverTest.test_next_free_display):
127 (XvfbDriverTest.test_start_next_worker):
128 2015-04-08 Alex Christensen <achristensen@webkit.org>
130 Block popups from content extensions.
131 https://bugs.webkit.org/show_bug.cgi?id=143497
133 Reviewed by Brady Eidson.
135 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
136 (TestWebKitAPI::TEST_F):
139 2015-04-08 Alex Christensen <achristensen@webkit.org> and Patrick Gansterer <paroga@webkit.org>
141 Add CMake build system for WinCairo port.
142 https://bugs.webkit.org/show_bug.cgi?id=115944
144 Reviewed by Chris Dumez.
147 * WinLauncher/CMakeLists.txt: Added.
149 2015-04-08 Carlos Garcia Campos <cgarcia@igalia.com>
151 [GTK] Crash in DOMObjectCache when a wrapped object owned by the cache is unreffed by the user
152 https://bugs.webkit.org/show_bug.cgi?id=143521
154 Reviewed by Martin Robinson.
156 Add a way to detect unexpected web process crashes to WebViewTest,
157 and a test case to testDOMCache to trigger the crash.
159 * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
160 (WebKitDOMNodeTest::testDOMCache):
161 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
162 (testWebKitWebViewProcessCrashed):
163 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
164 (WebViewTest::WebViewTest):
165 (WebViewTest::webProcessCrashed):
166 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
168 2015-04-07 Alexey Proskuryakov <ap@apple.com>
170 PageVisibilityStateWithWindowChanges should only be enabled on Yosemite
171 rdar://problem/20461342
173 * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
175 2015-04-07 Commit Queue <commit-queue@webkit.org>
177 Unreviewed, rolling out r182511.
178 https://bugs.webkit.org/show_bug.cgi?id=143507
180 caused debug test failures (Requested by alexchristensen on
185 "Block popups from content extensions."
186 https://bugs.webkit.org/show_bug.cgi?id=143497
187 http://trac.webkit.org/changeset/182511
189 2015-04-07 Alex Christensen <achristensen@webkit.org>
191 Block popups from content extensions.
192 https://bugs.webkit.org/show_bug.cgi?id=143497
194 Reviewed by Brady Eidson.
196 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
197 (TestWebKitAPI::TEST_F):
200 2015-04-07 Benjamin Poulain <benjamin@webkit.org>
202 Get the features.json files ready for open contributions
203 https://bugs.webkit.org/show_bug.cgi?id=143436
205 Reviewed by Darin Adler.
207 * Scripts/webkitpy/style/checkers/jsonchecker.py:
208 (JSONFeaturesChecker.check):
209 Extend the syntax checking a bit, but leave everything non-mandatory
210 very loose until we figure what fields are important.
212 2015-04-07 Tim Horton <timothy_horton@apple.com>
214 Expose and test fixedLayoutSize via modern WebKit SPI
215 https://bugs.webkit.org/show_bug.cgi?id=143500
217 Reviewed by Simon Fraser.
219 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
220 * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Added.
221 (-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]):
223 Add a test that verifies that fixedLayoutSize works at all, that
224 it persists through a navigation, and that turning it back off reverts to
225 laying out at the size of the view.
227 2015-04-07 Michael Catanzaro <mcatanzaro@igalia.com>
229 Unreviewed. Add myself as a committer.
231 * Scripts/webkitpy/common/config/contributors.json:
233 2015-04-07 Brent Fulgham <bfulgham@apple.com>
235 [Win] Bots complain about missing /etc/catalog
236 https://bugs.webkit.org/show_bug.cgi?id=143484
238 Reviewed by Chris Dumez.
240 The libxml2 build on Mac, iOS, and Windows does not provide the set
241 of default catalog files. We do not actually need these for our
242 purposes, but we get warnings and some bot flakiness because they
245 We can avoid both problems the same way the Mac and iOS ports do,
246 by setting the XML_CATALOG_FILES environment variable to 'empty string',
247 which avoid the warnings and bot problems.
249 * Scripts/webkitpy/port/win.py:
250 (WinPort.setup_environ_for_server): Added.
252 2015-04-06 Sam Weinig <sam@webkit.org>
254 Use content extensions in MiniBrowser.
255 https://bugs.webkit.org/show_bug.cgi?id=143446
257 Reviewed by Alex Christensen.
259 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
260 * MiniBrowser/mac/AppDelegate.h:
261 * MiniBrowser/mac/AppDelegate.m:
262 (-[BrowserAppDelegate init]):
263 (-[BrowserAppDelegate showExtensionsManager:]):
264 (-[BrowserAppDelegate userContentContoller]):
265 * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
266 * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
267 (-[ExtensionManagerWindowController init]):
268 (-[ExtensionManagerWindowController windowDidLoad]):
269 (-[ExtensionManagerWindowController add:]):
270 (-[ExtensionManagerWindowController remove:]):
271 * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
272 * MiniBrowser/mac/MainMenu.xib:
274 2015-04-07 Youenn Fablet <youenn.fablet@crf.canon.fr>
276 web-platform-tests server should retrieve the modules file relatively to its docroot path
277 https://bugs.webkit.org/show_bug.cgi?id=142742
279 Reviewed by Darin Adler.
281 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
282 (WebPlatformTestServer._install_modules): Compute the modules description file path according wpt server doc root path.
284 2015-04-06 Commit Queue <commit-queue@webkit.org>
286 Unreviewed, rolling out r182445.
287 https://bugs.webkit.org/show_bug.cgi?id=143459
289 broke 32 bit build (Requested by alexchristensen on #webkit).
293 "Use content extensions in MiniBrowser."
294 https://bugs.webkit.org/show_bug.cgi?id=143446
295 http://trac.webkit.org/changeset/182445
297 2015-04-06 Sam Weinig <sam@webkit.org>
299 Use content extensions in MiniBrowser.
300 https://bugs.webkit.org/show_bug.cgi?id=143446
302 Reviewed by Alex Christensen.
304 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
305 * MiniBrowser/mac/AppDelegate.h:
306 * MiniBrowser/mac/AppDelegate.m:
307 (-[BrowserAppDelegate init]):
308 (-[BrowserAppDelegate showExtensionsManager:]):
309 (-[BrowserAppDelegate userContentContoller]):
310 * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
311 * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
312 (-[ExtensionManagerWindowController init]):
313 (-[ExtensionManagerWindowController windowDidLoad]):
314 (-[ExtensionManagerWindowController add:]):
315 (-[ExtensionManagerWindowController remove:]):
316 * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
317 * MiniBrowser/mac/MainMenu.xib:
319 2015-04-06 Michael Catanzaro <mcatanzaro@gnome.org>
321 [GTK] install-dependencies should prefer dnf to yum
322 https://bugs.webkit.org/show_bug.cgi?id=143441
324 Reviewed by Martin Robinson.
326 Test for the existance of dnf before yum, and only try to use yum if dnf does not exist.
328 * gtk/install-dependencies:
330 2015-04-06 Andy Estes <aestes@apple.com>
332 [iOS] 'make clean' fails in Tools/WebKitTestRunner
333 https://bugs.webkit.org/show_bug.cgi?id=143455
335 Reviewed by Dan Bernstein.
337 This Makefile adds '-target WebKitTestRunnerApp' to OTHER_OPTIONS during iOS builds, but the top-level
338 Makefile.shared adds '-alltargets' for clean builds, and xcodebuild does not allow both -target and -alltargets.
340 * WebKitTestRunner/Makefile: Don't add '-target WebKitTestRunerApp' to OTHER_OPTIONS on clean builds.
342 2015-04-06 Alexey Proskuryakov <ap@apple.com>
344 WebKit1.SetAndUpdateCacheModelPreferencesChangeMix fails on some machines
345 https://bugs.webkit.org/show_bug.cgi?id=143450
347 Reviewed by Anders Carlsson.
349 * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: (TestWebKitAPI::TEST):
350 Make sure that the view is actually closed, regardless of anything else that happens beneath.
351 Also, removed unnecessary get() calls.
353 2015-04-03 Alexey Proskuryakov <ap@apple.com>
355 Reduce the dependency on Flash in regression tests
356 https://bugs.webkit.org/show_bug.cgi?id=143391
358 Reviewed by Anders Carlsson.
360 * WebKitTestRunner/TestController.cpp: (WTR::TestController::decidePolicyForPluginLoad):
361 Only allow QuickTime and the test plug-in.
363 2015-04-06 Youenn Fablet <youenn.fablet@crf.canon.fr>
365 W3C test importer should generate the modules installed dynamically to run wpt tests
366 https://bugs.webkit.org/show_bug.cgi?id=142738
368 Reviewed by Ryosuke Niwa.
370 The test importer can now generate the submodules description file based on information extracted from the corresponding git repository.
371 The implementation is done within TestDownloader and it is activated for the WPT repository.
372 LayoutTests/imported/w3c/resources/WPTModules is renamed as LayoutTests/imported/w3c/resources/web-platform-tests-modules.json for that reason.
374 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
375 (WebPlatformTestServer._install_modules): Updated to cope with path as array.
376 * Scripts/webkitpy/w3c/test_downloader.py:
377 (TestDownloader._git_submodules_status): Added so that it can be overriden for unit tests.
379 (TestDownloader._git_submodules_description): Computes submodule description.
380 (TestDownloader.generate_git_submodules_description): Write submodule description in a file.
381 * Scripts/webkitpy/w3c/test_importer.py:
382 (TestImporter.do_import): Added the possibility to post process the tests.
384 (TestImporter.generate_git_submodules_description_for_all_repositories): Enable generating module description file.
385 (TestImporter.should_convert_test_harness_links): Updated according new options format.
386 * Scripts/webkitpy/w3c/test_importer_unittest.py:
387 (TestImporterTest.import_downloaded_tests): Making use of TestDownloaderMock.
388 (TestImporterTest.import_downloaded_tests.TestDownloaderMock): Added to override submodule status gathering.
389 (TestImporterTest.import_downloaded_tests.TestDownloaderMock.__init__):
390 (TestImporterTest.import_downloaded_tests.TestDownloaderMock._git_submodules_status):
391 (TestImporterTest.test_submodules_generation): Added to check that modules description files works.
393 2015-04-05 Antti Koivisto <antti@apple.com>
395 Bloom filter should support longer hashes
396 https://bugs.webkit.org/show_bug.cgi?id=143419
398 Reviewed by Dan Bernstein.
400 * TestWebKitAPI/Tests/WTF/BloomFilter.cpp:
401 (TestWebKitAPI::generateRandomDigests):
402 (TestWebKitAPI::TEST):
404 2015-04-03 Csaba Osztrogonác <ossy@webkit.org>
406 run-jsc-stress-tests --remote should add libllvmForJSC.so to the bundle on Linux
407 https://bugs.webkit.org/show_bug.cgi?id=143372
409 Reviewed by Darin Adler.
411 * Scripts/run-jsc-stress-tests:
413 2015-04-03 Antti Koivisto <antti@apple.com>
415 Add non-counting bloom filter class
416 https://bugs.webkit.org/show_bug.cgi?id=143366
418 Reviewed by Sam Weinig.
420 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
421 * TestWebKitAPI/Tests/WTF/BloomFilter.cpp: Added.
422 (TestWebKitAPI::generateRandomHashes):
423 (TestWebKitAPI::TEST):
425 2015-04-03 Csaba Osztrogonác <ossy@webkit.org>
427 FTL JIT tests should fail if LLVM library isn't available
428 https://bugs.webkit.org/show_bug.cgi?id=143374
430 Reviewed by Mark Lam.
432 * Scripts/run-jsc-stress-tests:
434 2015-04-03 Csaba Osztrogonác <ossy@webkit.org>
436 [EFL] Speedup jhbuild with disable running autogen.sh
437 https://bugs.webkit.org/show_bug.cgi?id=143369
439 Reviewed by Gyuyoung Kim.
441 * efl/jhbuild.modules:
443 2015-04-01 Alexey Proskuryakov <ap@apple.com>
445 filter-webkit-build should filter out "created by an unsupported XCDependencyGraph build" lines
446 https://bugs.webkit.org/show_bug.cgi?id=143282
448 Reviewed by Daniel Bates.
450 * Scripts/filter-build-webkit: (shouldIgnoreLine): Do it.
452 2015-04-01 Alexey Proskuryakov <ap@apple.com>
454 When LayoutTestHelper fails to start, we continue to run the tests, ending up with mysterious failures
455 https://bugs.webkit.org/show_bug.cgi?id=143240
456 rdar://problem/19990425
458 Reviewed by Tim Horton.
460 * DumpRenderTree/mac/LayoutTestHelper.m:
461 (colorProfileURLForDisplay):
462 (saveDisplayColorProfiles):
463 Gracefully handle it when the current profile cannot be retrieved, fixing at
464 least one case when LayoutTestHelper couldn't start.
466 * Scripts/webkitpy/layout_tests/controllers/manager.py:
467 (Manager._set_up_run):
468 (Manager._force_pixel_tests_if_needed):
469 * Scripts/webkitpy/port/base.py: (Port.to.start_helper):
470 * Scripts/webkitpy/port/mac.py: (MacPort.start_helper):
471 Return and check an error from start_helper().
473 2015-04-01 Brent Fulgham <bfulgham@apple.com>
475 [Win] Run test-webkitpy as part of EWS (just like we do on other platforms)
476 https://bugs.webkit.org/show_bug.cgi?id=143321
478 Reviewed by Alexey Proskuryakov.
480 * EWSTools/start-queue-win.sh: Add commands to run 'test-webkitpy' during processing loop.
482 2015-04-01 Enrica Casucci <enrica@apple.com>
484 Injected bundle messages should be at the page level.
485 https://bugs.webkit.org/show_bug.cgi?id=143283
487 Reviewed by Alexey Proskuryakov.
489 Updating WebKitTestRunner to use the new page level messaging.
490 The author of this patch is Tim Horton, I just finished it.
492 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
493 (WTR::EventSendingController::mouseDown):
494 (WTR::EventSendingController::mouseUp):
495 (WTR::EventSendingController::mouseMoveTo):
496 (WTR::EventSendingController::leapForward):
497 (WTR::EventSendingController::scheduleAsynchronousClick):
498 (WTR::EventSendingController::keyDown):
499 (WTR::EventSendingController::scheduleAsynchronousKeyDown):
500 (WTR::EventSendingController::mouseScrollBy):
501 (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
502 (WTR::EventSendingController::continuousMouseScrollBy):
503 (WTR::EventSendingController::addTouchPoint):
504 (WTR::EventSendingController::updateTouchPoint):
505 (WTR::EventSendingController::setTouchModifier):
506 (WTR::EventSendingController::setTouchPointRadius):
507 (WTR::EventSendingController::touchStart):
508 (WTR::EventSendingController::touchMove):
509 (WTR::EventSendingController::touchEnd):
510 (WTR::EventSendingController::touchCancel):
511 (WTR::EventSendingController::clearTouchPoints):
512 (WTR::EventSendingController::releaseTouchPoint):
513 (WTR::EventSendingController::cancelTouchPoint):
514 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
515 (WTR::InjectedBundle::didReceiveMessage):
516 (WTR::InjectedBundle::didReceiveMessageToPage):
517 (WTR::InjectedBundle::done):
518 (WTR::InjectedBundle::outputText):
519 (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
520 (WTR::InjectedBundle::postAddChromeInputField):
521 (WTR::InjectedBundle::postRemoveChromeInputField):
522 (WTR::InjectedBundle::postFocusWebView):
523 (WTR::InjectedBundle::postSetBackingScaleFactor):
524 (WTR::InjectedBundle::postSetWindowIsKey):
525 (WTR::InjectedBundle::postSimulateWebNotificationClick):
526 (WTR::InjectedBundle::postSetAddsVisitedLinks):
527 (WTR::InjectedBundle::setGeolocationPermission):
528 (WTR::InjectedBundle::setMockGeolocationPosition):
529 (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
530 (WTR::InjectedBundle::setUserMediaPermission):
531 (WTR::InjectedBundle::setCustomPolicyDelegate):
532 (WTR::InjectedBundle::setHidden):
533 (WTR::InjectedBundle::setCacheModel):
534 (WTR::InjectedBundle::shouldProcessWorkQueue):
535 (WTR::InjectedBundle::processWorkQueue):
536 (WTR::InjectedBundle::queueBackNavigation):
537 (WTR::InjectedBundle::queueForwardNavigation):
538 (WTR::InjectedBundle::queueLoad):
539 (WTR::InjectedBundle::queueLoadHTMLString):
540 (WTR::InjectedBundle::queueReload):
541 (WTR::InjectedBundle::queueLoadingScript):
542 (WTR::InjectedBundle::queueNonLoadingScript):
543 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
544 (WTR::TestRunner::setHandlesAuthenticationChallenges):
545 (WTR::TestRunner::setAuthenticationUsername):
546 (WTR::TestRunner::setAuthenticationPassword):
547 (WTR::TestRunner::secureEventInputIsEnabled):
548 (WTR::TestRunner::setBlockAllPlugins):
549 * WebKitTestRunner/TestController.cpp:
550 (WTR::TestController::createWebViewWithOptions):
551 (WTR::TestController::resetStateToConsistentValues):
552 (WTR::TestController::didReceivePageMessageFromInjectedBundle):
553 (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle):
554 * WebKitTestRunner/TestController.h:
555 * WebKitTestRunner/TestInvocation.cpp:
556 (WTR::TestInvocation::invoke):
557 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
559 2015-04-01 Commit Queue <commit-queue@webkit.org>
561 Unreviewed, rolling out r182174 and r182177.
562 https://bugs.webkit.org/show_bug.cgi?id=143314
564 Try to correct EWS failures (Requested by bfulgham on
569 "Python SCM should be able to retrieve untracked files"
570 https://bugs.webkit.org/show_bug.cgi?id=143135
571 http://trac.webkit.org/changeset/182174
573 "[buildbot] clean-build script should remove untracked files
574 and revert local changes too"
575 https://bugs.webkit.org/show_bug.cgi?id=142400
576 http://trac.webkit.org/changeset/182177
578 2015-04-01 Alex Christensen <achristensen@webkit.org>
580 [Content Extensions] Properly handle regexes that match everything.
581 https://bugs.webkit.org/show_bug.cgi?id=143281
583 Reviewed by Benjamin Poulain.
585 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
586 (TestWebKitAPI::testRequest):
587 (TestWebKitAPI::makeBackend):
588 (TestWebKitAPI::TEST_F):
589 Removed duplicate code and added test.
591 2015-03-31 Benjamin Poulain <bpoulain@apple.com>
593 Content Extensions: split the state machines to minimize prefix states
594 https://bugs.webkit.org/show_bug.cgi?id=143253
596 Reviewed by Alex Christensen.
598 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
599 (TestWebKitAPI::TEST_F):
600 (TestWebKitAPI::testPatternStatus):
602 2015-03-31 Yusuke Suzuki <utatane.tea@gmail.com>
604 Clean up Identifier factories to clarify the meaning of StringImpl*
605 https://bugs.webkit.org/show_bug.cgi?id=143146
607 Reviewed by Filip Pizlo.
609 Simple API tests for StringImpl are added.
611 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
612 (TestWebKitAPI::TEST):
614 2015-03-31 Csaba Osztrogonác <ossy@webkit.org>
616 [EFL] Add AArch64 builder and tester bot to build.webkit.org
617 https://bugs.webkit.org/show_bug.cgi?id=143092
619 Reviewed by Gyuyoung Kim.
621 * BuildSlaveSupport/build.webkit.org-config/config.json:
622 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
624 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
626 2015-03-31 Youenn Fablet <youenn.fablet@crf.canon.fr>
628 [buildbot] clean-build script should remove untracked files and revert local changes too
629 https://bugs.webkit.org/show_bug.cgi?id=142400
631 Reviewed by Ryosuke Niwa.
633 This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
634 A helper routine SCM.discard_untracked_files is added for that purpose.
636 * BuildSlaveSupport/clean-build:
637 (main): Making call to Scripts/clean-webkit
638 * Scripts/clean-webkit: Added.
639 (main): Revert changes and delete untracked files.
640 * Scripts/webkitpy/common/checkout/scm/scm.py:
641 (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
642 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
643 (SCMTest._shared_test_discard_untracked_files):
644 (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
646 2015-03-31 Youenn Fablet <youenn.fablet@crf.canon.fr>
648 Python SCM should be able to retrieve untracked files
649 https://bugs.webkit.org/show_bug.cgi?id=143135
651 Reviewed by Ryosuke Niwa.
653 This patch introduces SCM.untracked_files to retrieve a list of untracked files.
654 Ignored files may be included or not in this list according boolean passed to the function.
656 * Scripts/webkitpy/common/checkout/scm/git.py:
657 (Git.untracked_files):
658 * Scripts/webkitpy/common/checkout/scm/scm.py:
659 (SCM.untracked_files):
660 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
661 (SCMTest._shared_test_untracked_files):
662 (test_untracked_files):
663 (GitSVNTest.test_untracked_files):
664 * Scripts/webkitpy/common/checkout/scm/svn.py:
665 (SVN.untracked_files):
667 2015-03-30 Alex Christensen <achristensen@webkit.org>
669 [Content Extensions] Correctly handle regular expressions matching everything
670 https://bugs.webkit.org/show_bug.cgi?id=143235
672 Reviewed by Benjamin Poulain.
674 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
675 (TestWebKitAPI::checkCompilerError):
676 (TestWebKitAPI::TEST_F):
677 Test ContentExtensionErrors.
679 2015-03-30 Alexey Proskuryakov <ap@apple.com>
681 DumpRenderTree should set NSWindowDisplayWithRunLoopObserver
682 https://bugs.webkit.org/show_bug.cgi?id=143241
683 rdar://problem/20351297
685 Reviewed by Mark Lam.
687 * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
689 2015-03-30 Gyuyoung Kim <gyuyoung.kim@samsung.com>
691 [CMake][EFL] Remove redundant library link and include path
692 https://bugs.webkit.org/show_bug.cgi?id=143221
694 Reviewed by Csaba Osztrogonác.
696 * ImageDiff/PlatformEfl.cmake: Remove unnecessary library link and include path.
698 2015-03-30 Sam Weinig <sam@webkit.org>
700 [Content Extensions] Flesh out the UserContentExtensionStore
701 https://bugs.webkit.org/show_bug.cgi?id=143123
703 Reviewed by Benjamin Poulain.
705 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
706 * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: Added.
707 Add tests for _WKUserContentExtensionStore.
709 2015-03-30 Marcos Chavarría Teijeiro <chavarria1991@gmail.com>
711 Update install-dependencies Fedora packages after r181624
712 https://bugs.webkit.org/show_bug.cgi?id=143215
714 Add json-glib, libv4l, openssl and pulseaudio development packages to
715 the Fedora list providing we need them to build WebKit dependencies
716 for this distribution.
718 Reviewed by Philippe Normand.
720 * gtk/install-dependencies:
722 2015-03-30 Commit Queue <commit-queue@webkit.org>
724 Unreviewed, rolling out r182119.
725 https://bugs.webkit.org/show_bug.cgi?id=143196
727 problem with syntax (Requested by youenn on #webkit).
731 "[buildbot] clean-build script should remove untracked files
732 and revert local changes too"
733 https://bugs.webkit.org/show_bug.cgi?id=142400
734 http://trac.webkit.org/changeset/182119
736 2015-03-30 Benjamin Poulain <benjamin@webkit.org>
738 Start the features.json files
739 https://bugs.webkit.org/show_bug.cgi?id=143207
741 Reviewed by Darin Adler.
743 I kept the style checking light. We'll have to figure
744 what is the best format for each field.
746 * Scripts/webkitpy/style/checker.py:
747 (CheckerDispatcher._create_checker):
748 * Scripts/webkitpy/style/checkers/jsonchecker.py:
749 (JSONContributorsChecker.check):
750 (JSONFeaturesChecker):
751 (JSONFeaturesChecker.check):
753 2015-03-29 Youenn Fablet <youenn.fablet@crf.canon.fr>
755 [buildbot] clean-build script should remove untracked files and revert local changes too
756 https://bugs.webkit.org/show_bug.cgi?id=142400
758 Reviewed by Ryosuke Niwa.
760 This patch cleans the WebKit folder by deleting SCM untracked files and reverting changes for tracked files.
762 * BuildSlaveSupport/clean-build:
763 (main): Adding call to Tools/Scripts/clean-webkit.
764 * Scripts/clean-webkit: Added.
765 (main): Removes untracked and changed files.
766 * Scripts/webkitpy/common/checkout/scm/git.py:
767 (Git.untracked_files): Retrieves GIT untracked files.
768 * Scripts/webkitpy/common/checkout/scm/scm.py:
769 (SCM.untracked_files): Retrieves SVN untracked files.
771 (SCM.discard_untracked_files): Deletes untracked files/folders.
772 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
773 (SCMTest._shared_test_untracked_files): Unit testing for untracked files.
774 (test_untracked_files):
775 (GitSVNTest.test_untracked_files):
776 * Scripts/webkitpy/common/checkout/scm/svn.py:
777 (SVN.untracked_files):
779 2015-03-27 Gyuyoung Kim <gyuyoung.kim@samsung.com>
781 [CMake] Remove unnecessary INCLUDE_IF_EXISTS macro
782 https://bugs.webkit.org/show_bug.cgi?id=143138
784 Reviewed by Csaba Osztrogonác.
786 INCLUDE_IF_EXISTS isn't used except for 2 places. However those uses can
787 be replaced with WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS.
789 * ImageDiff/CMakeLists.txt:
790 Use WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS() instead of INCLUDE_IF_EXISTS.
791 * WebKitTestRunner/CMakeLists.txt: ditto.
793 2015-03-27 Myles C. Maxfield <mmaxfield@apple.com>
795 Support building WTF on Windows without Cygwin
796 https://bugs.webkit.org/show_bug.cgi?id=143084
798 Reviewed by Brent Fulgham.
800 Windows without Cygwin doesn't have curl, unzip, or grep. Luckily, Perl does all of these things.
801 This patch also migrates to using File::Spec->catfile() for directory separators.
803 * Scripts/update-webkit-dependency:
805 * Scripts/update-webkit-support-libs:
807 (downloadExpectedVersionNumber):
809 (toUnixPath): Deleted.
810 * Scripts/webkitdirs.pm:
811 (determineSourceDir):
812 (windowsSourceSourceDir):
813 (windowsLibrariesDir):
815 (checkInstalledTools):
816 (buildVisualStudioProject):
818 2015-03-27 Alex Christensen <achristensen@webkit.org>
821 https://bugs.webkit.org/show_bug.cgi?id=143086
823 Reviewed by Brent Fulgham.
825 * Scripts/webkitdirs.pm:
826 (buildVisualStudioProject):
827 (runSvnUpdateAndResolveChangeLogs):
828 Use ActivePerl-friendly perl.
830 2015-03-27 Csaba Osztrogonác <ossy@webkit.org>
832 URTBF after r182059 to fix the EFL build.
834 * TestWebKitAPI/CMakeLists.txt:
836 2015-03-26 Alexey Proskuryakov <ap@apple.com>
838 Layout test results URL loads in WK1 but not WK2 minibrowser
839 https://bugs.webkit.org/show_bug.cgi?id=143117
841 Reviewed by Tim Horton.
843 * MiniBrowser/mac/WK2BrowserWindowController.m:
844 (-[WK2BrowserWindowController fetch:]): Fix this, international domain names, and
846 (-[WK2BrowserWindowController updateTextFieldFromURL:]): Ditto.
848 2015-03-26 Jer Noble <jer.noble@apple.com>
850 Add --allowed-host support to run-webkit-tests
851 https://bugs.webkit.org/show_bug.cgi?id=142938
853 Reviewed by Brent Fulgham.
855 Accept --allowed-host arguments from run-webkit-tests and pass them through to
856 DumpRenderTree and WebKitTestRunner.
858 Drive-by fix: Depending on the value of the --layout-test-dir parameter, layout test results
859 are placed in the wrong location. The argument is compared with each tests's path, and if a
860 relative path or a path with '..' was used, results are placed alongside the test. Take the
861 absolute path of the --layout-test-dir argument, collapsing path components like '..'.
863 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
865 * Scripts/webkitpy/port/base.py:
867 (Port.allowed_hosts):
868 * Scripts/webkitpy/port/driver.py:
871 2015-03-26 Jer Noble <jer.noble@apple.com>
873 [Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connect to non-localhost servers
874 https://bugs.webkit.org/show_bug.cgi?id=142931
876 Reviewed by Brent Fulgham.
878 Currently, both DRT and WKTR will refuse to allow network connections to non-localhost servers
879 over HTTP/HTTPS. For certain testing scenarios, however, it would be useful if both DRT and
880 WKTR could be allowed to make HTTP/HTTPS connections to certain, specific servers defined at
883 To allow this, add an optional argument to DRT and WKTR, --allowed-host, which will add the specified
884 hostname to a whitelist; requests to these hosts will allowed to proceed normally.
886 Drive-by fix: in InjectedBundlePage::willSendRequestForFrame, we get the top loading frame from the
887 injected bundle. But after the main resource load completes, the bundle nulls out it's pointer to the
888 top loading frame, which causes a subsequent crash when further resources are requested. Instead, get
889 the top loading frame from the page, as we do elsewhere in this class.
891 * DumpRenderTree/TestRunner.h:
892 (TestRunner::allowedHosts):
893 (TestRunner::setAllowedHosts):
894 * DumpRenderTree/mac/DumpRenderTree.mm:
895 (initializeGlobalsFromCommandLineOptions):
897 * DumpRenderTree/mac/ResourceLoadDelegate.mm:
899 (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
900 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
901 (WTR::InjectedBundle::didReceiveMessage):
902 (WTR::InjectedBundle::isAllowedHost):
903 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
904 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
905 (WTR::isAllowedHost):
906 (WTR::InjectedBundlePage::willSendRequestForFrame):
907 * WebKitTestRunner/InjectedBundle/TestRunner.h:
908 * WebKitTestRunner/Options.cpp:
909 (WTR::handleOptionAllowedHost):
910 (WTR::OptionsHandler::OptionsHandler):
911 * WebKitTestRunner/Options.h:
912 * WebKitTestRunner/TestController.cpp:
913 (WTR::TestController::initialize):
914 (WTR::TestController::resetStateToConsistentValues):
915 * WebKitTestRunner/TestController.h:
917 2015-03-26 Brady Eidson <beidson@apple.com>
919 Apply ContentExtension actions after redirects.
920 <rdar://problem/20062613> and https://bugs.webkit.org/show_bug.cgi?id=143055
922 Reviewed by Alex Christensen.
924 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
925 (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Dump the fact that the load error is kWKErrorCodeCannotShowURL
926 which is specifically interesting to a new test.
928 2015-03-26 Csaba Osztrogonác <ossy@webkit.org>
930 [EFL] Disable building libseccomp on AArch64
931 https://bugs.webkit.org/show_bug.cgi?id=143094
933 Reviewed by Gyuyoung Kim.
937 2015-03-26 Csaba Osztrogonác <ossy@webkit.org>
939 [jhbuild] git should use only 1 thread for cloning jhbuild
940 https://bugs.webkit.org/show_bug.cgi?id=143095
942 Reviewed by Gyuyoung Kim.
944 * jhbuild/jhbuild-wrapper:
947 2015-03-25 Joseph Pecoraro <pecoraro@apple.com>
949 Update prepare-ChangeLog to work with ES6 Class syntax
950 https://bugs.webkit.org/show_bug.cgi?id=143069
952 Reviewed by Timothy Hatcher.
954 * Scripts/prepare-ChangeLog:
955 (get_function_line_ranges_for_javascript):
956 Better handle ES6 Class syntax.
958 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
959 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
962 (DerivedClass.staticMethod):
963 (DerivedClass.prototype.method.nestedFunctionInsideMethod):
964 (DerivedClass.prototype.method):
965 (DerivedClass.prototype.get getter):
967 (namespace.MyClass.staticMethod):
968 (namespace.MyClass.prototype.method.nestedFunctionInsideMethod):
969 (namespace.MyClass.prototype.method):
970 (namespace.MyClass.prototype.get getter):
973 2015-03-25 Filip Pizlo <fpizlo@apple.com>
975 Use JITCompilationCanFail in more places, and make the fail path of JITCompilationMustSucceed a crash instead of attempting GC
976 https://bugs.webkit.org/show_bug.cgi?id=142993
978 Reviewed by Mark Lam.
980 Bunch of support for testing executable allocation failure.
982 * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz: Added.
984 * Scripts/run-javascriptcore-tests:
986 * Scripts/run-jsc-stress-tests:
988 2015-03-25 Myles C. Maxfield <mmaxfield@apple.com>
990 Fix Windows build from r181977.
994 * Scripts/update-webkit-dependency:
996 2015-03-25 Sam Weinig <sam@webkit.org>
998 Address additional review feedback from https://bugs.webkit.org/show_bug.cgi?id=143059.
1000 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1001 (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1003 2015-03-25 Myles C. Maxfield <mmaxfield@apple.com>
1005 Migrate update-webkit for Windows to not require Cygwin
1006 https://bugs.webkit.org/show_bug.cgi?id=143040
1008 Reviewed by Brent Fulgham.
1010 * Scripts/update-webkit-dependency:
1012 (toUnixPath): Deleted.
1013 * Scripts/webkitdirs.pm:
1015 (checkInstalledTools):
1018 2015-03-25 Sam Weinig <sam@webkit.org>
1020 [Content Extensions] Convert content extension compiling to return error codes and write its output using a client
1021 https://bugs.webkit.org/show_bug.cgi?id=143059
1023 Reviewed by Alex Christensen.
1025 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1026 (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1027 Update for new interface of compileRuleList().
1029 2015-03-25 Alex Christensen <achristensen@webkit.org>
1031 [Content Extensions] Add multi-DFA compiling and interpreting.
1032 https://bugs.webkit.org/show_bug.cgi?id=143010
1034 Reviewed by Benjamin Poulain.
1036 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1037 (TestWebKitAPI::testRequest):
1038 (TestWebKitAPI::TEST_F):
1039 Add some tests for ignore-previous-rules and large rulesets.
1041 2015-03-25 Alexey Proskuryakov <ap@apple.com>
1043 Mavericks WK1 still runs JSC tests
1044 https://bugs.webkit.org/show_bug.cgi?id=143035
1046 Reviewed by Csaba Osztrogonác.
1048 * BuildSlaveSupport/build.webkit.org-config/config.json: Bring Mavericks WK1 in line
1051 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated the tests
1054 2015-03-25 Commit Queue <commit-queue@webkit.org>
1056 Unreviewed, rolling out r181932.
1057 https://bugs.webkit.org/show_bug.cgi?id=143041
1059 The test fails most of the time on bots (Requested by ap on
1064 "[Content Extensions] Add multi-DFA compiling and
1066 https://bugs.webkit.org/show_bug.cgi?id=143010
1067 http://trac.webkit.org/changeset/181932
1069 2015-03-24 Alex Christensen <achristensen@webkit.org>
1071 [Content Extensions] Add multi-DFA compiling and interpreting.
1072 https://bugs.webkit.org/show_bug.cgi?id=143010
1074 Reviewed by Benjamin Poulain.
1076 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1077 (TestWebKitAPI::testRequest):
1078 (TestWebKitAPI::TEST_F):
1079 Add some tests for ignore-previous-rules and large rulesets.
1081 2015-03-24 Benjamin Poulain <bpoulain@apple.com>
1083 Make URL filter patterns matching consistent and add a simple canonicalization step
1084 https://bugs.webkit.org/show_bug.cgi?id=142998
1086 Reviewed by Alex Christensen.
1088 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1090 2015-03-24 Csaba Osztrogonác <ossy@webkit.org>
1092 [EFL] Add OpenWebRTC in jhbuild
1093 https://bugs.webkit.org/show_bug.cgi?id=142778
1095 Reviewed by Gyuyoung Kim.
1097 Original patch by Philippe Normand <pnormand@igalia.com>
1099 * efl/install-dependencies: Dependencies for OpenWebRTC.
1100 * efl/jhbuild.modules: build OpenWebRTC, libusrsctp, libnice and
1101 the openwebrtc gst plugins.
1103 2015-03-23 Brent Fulgham <bfulgham@apple.com>
1105 Regression(r181257): WTF_WorkQueue.Simple is flaky
1106 https://bugs.webkit.org/show_bug.cgi?id=142560
1108 Remove the check that the refCount has returned to one after the
1109 individual tasks have completed. It's too nondeterministic when
1110 the reference count will be reduced.
1112 Reviewed by Alexey Proskuryakov
1114 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1115 (TestWebKitAPI::TEST): Remove test that refCount is back to 1.
1117 2015-03-23 Gyuyoung Kim <gyuyoung.kim@samsung.com>
1119 [CMake][EFL] Put failure API test excutables into failure directory
1120 https://bugs.webkit.org/show_bug.cgi?id=142965
1122 Reviewed by Csaba Osztrogonác.
1124 Move failing WK2 API test executables to *bin/TestWebKitAPI/WebKit2/failure* directory.
1126 * TestWebKitAPI/CMakeLists.txt: Fix a typo. Change *testBaseName* with *testName*.
1127 * TestWebKitAPI/PlatformEfl.cmake: Additionally remove unnecessary SHARED_CORE and comment for SeccompFilters test.
1129 2015-03-22 Benjamin Poulain <benjamin@webkit.org>
1131 CSS Selectors: fix attribute case-insensitive matching of Contain and List
1132 https://bugs.webkit.org/show_bug.cgi?id=142932
1134 Reviewed by Darin Adler.
1136 Add tests for the new features and fix some existing tests using the
1137 stringFromUTF8() utility recently added by Dhi.
1139 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1140 (TestWebKitAPI::stringFromUTF8):
1141 * TestWebKitAPI/Tests/WTF/StringView.cpp:
1143 2015-03-22 Michael Catanzaro <mcatanzaro@igalia.com>
1145 [GTK] install-dependencies should install orc
1146 https://bugs.webkit.org/show_bug.cgi?id=142955
1148 Reviewed by Martin Robinson.
1150 Install orc, needed by openwebrtc
1152 * gtk/install-dependencies:
1154 2015-03-22 Benjamin Poulain <bpoulain@apple.com>
1156 Detect when url filter pattern with groups match the empty string
1157 https://bugs.webkit.org/show_bug.cgi?id=142930
1159 Reviewed by Sam Weinig.
1161 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1163 2015-03-22 Anders Carlsson <andersca@apple.com>
1165 _WKWebsiteDataStore should clear WebSQL databases
1166 https://bugs.webkit.org/show_bug.cgi?id=142947
1168 Reviewed by Sam Weinig.
1170 Add a variable that keeps track of the types of data we want to operate on, for easier debugging.
1172 * MiniBrowser/mac/WK2BrowserWindowController.m:
1173 (-[WK2BrowserWindowController fetchWebsiteData:]):
1174 (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
1175 (-[WK2BrowserWindowController clearWebsiteData:]):
1177 2015-03-20 Mark Hahnenberg <mhahnenb@gmail.com>
1179 GCTimer should know keep track of nested GC phases
1180 https://bugs.webkit.org/show_bug.cgi?id=142675
1182 Reviewed by Darin Adler.
1184 Adds a tool to aid in parsing the GC phase timing output into a
1185 tree-like structure based on the parent-child relationships
1186 of nested GC phases.
1188 * Scripts/parse-gc-phase-timings: Added.
1191 (Timing.__unicode__):
1195 (print_timing_node):
1196 (print_timing_tree):
1200 2015-03-20 Brent Fulgham <bfulgham@apple.com>
1202 [Win] Temporarily turn of EWS Windows tests while I debug the test failure.
1204 * Scripts/webkitpy/common/config/ews.json:
1206 2015-03-20 Philippe Normand <pnormand@igalia.com>
1208 [GTK][jhbuild] Fix flakey failures due to unstable googlecode repository
1209 https://bugs.webkit.org/show_bug.cgi?id=142867
1211 Rubber-stamped by Csaba Osztrogon.
1213 * gtk/jhbuild.modules: Use Ossy's libusrsctp Github fork. Also use
1214 a fixed revision for the openwebrtc-gst-plugins.
1216 2015-03-19 Ryosuke Niwa <rniwa@webkit.org>
1218 Unreviewed build fix. Don't try to report stats for all benchmarks.
1219 Just report the geometric mean of preferred means.
1221 * Scripts/run-jsc-benchmarks:
1223 2015-03-19 Ryosuke Niwa <rniwa@webkit.org>
1225 run-jsc-benchmarks should only report preferred mean
1226 https://bugs.webkit.org/show_bug.cgi?id=142874
1228 Reviewed by Geoffrey Garen.
1230 Just collect statistics for the preferred mean.
1232 * Scripts/run-jsc-benchmarks:
1234 2015-03-19 Alex Christensen <achristensen@webkit.org>
1236 [Content Extensions] Test regular expression parse failures.
1237 https://bugs.webkit.org/show_bug.cgi?id=142872
1239 Reviewed by Benjamin Poulain.
1241 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1242 (TestWebKitAPI::testPatternStatus):
1243 (TestWebKitAPI::TEST_F):
1244 Added tests for each parsing status.
1246 2015-03-19 Alex Christensen <achristensen@webkit.org>
1248 Fix API tests after r181754.
1250 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1251 (TestWebKitAPI::testRequest):
1253 2015-03-19 Brady Eidson <beidson@apple.com>
1255 Part of content extensions should apply css selectors
1256 https://bugs.webkit.org/show_bug.cgi?id=142604
1258 Reviewed by Alex Christensen.
1260 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1261 (WebCore::ContentExtensions::operator<<):
1263 2015-03-19 Brent Fulgham <bfulgham@apple.com>
1265 [Win] Activate tests on EWS
1266 https://bugs.webkit.org/show_bug.cgi?id=142850
1268 Reviewed by Alexey Proskuryakov.
1270 * Scripts/webkitpy/common/config/ews.json: Add me as
1271 the EWS bot watcher, and activate tests.
1273 2015-03-19 Csaba Osztrogonác <ossy@webkit.org>
1275 [GTK] Fix inspector userinterface related incremental build issue
1276 https://bugs.webkit.org/show_bug.cgi?id=142849
1278 Reviewed by Carlos Garcia Campos.
1280 * Scripts/webkitdirs.pm:
1281 (shouldRemoveCMakeCache):
1283 2015-03-18 Alex Christensen <achristensen@webkit.org>
1285 [ContentExtensions] Prepare for compiling stylesheets of selectors to be used on every page.
1286 https://bugs.webkit.org/show_bug.cgi?id=142799
1288 Reviewed by Brady Eidson.
1290 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1291 (TestWebKitAPI::testPattern):
1292 (TestWebKitAPI::TEST_F):
1293 Start testing regex failures.
1295 2015-03-18 Dhi Aurrahman <diorahman@rockybars.com>
1297 Fix StringView typos after r181525 and r181558
1298 https://bugs.webkit.org/show_bug.cgi?id=142772
1300 Reviewed by Darin Adler.
1302 Add some tests in [1] to cover the StringView::startsWith,
1303 StringView::startsWithIgnoringASCIICase, StringView::endsWith and
1304 StringView::endsWithIgnoringASCIICase implementations.
1306 * TestWebKitAPI/Tests/WTF/StringView.cpp:
1307 (TestWebKitAPI::TEST):
1309 2015-03-18 Dana Burkart <dburkart@apple.com>
1311 Remove extraneous import to fix the build.
1315 * Scripts/webkitpy/port/driver.py:
1317 2015-03-18 Dana Burkart <dburkart@apple.com>
1319 ASAN_OPTIONS=allocator_may_return_null=1 needs to be set
1320 https://bugs.webkit.org/show_bug.cgi?id=142547
1322 Reviewed by Alexey Proskuryakov.
1324 * Scripts/webkitpy/port/driver.py:
1325 (Driver._setup_environ_for_driver):
1327 2015-03-18 Alexey Proskuryakov <ap@apple.com>
1329 Tweak how AppleSystemFontOSSubversion default is added
1330 https://bugs.webkit.org/show_bug.cgi?id=142835
1332 Reviewed by Dan Bernstein.
1334 * DumpRenderTree/mac/DumpRenderTree.mm:
1335 (setDefaultsToConsistentValuesForTesting):
1337 2015-03-18 Dan Bernstein <mitz@apple.com>
1339 prepare-ChangeLog doesn't understand C string literals split across multiple lines with \
1340 https://bugs.webkit.org/show_bug.cgi?id=142815
1342 Reviewed by Darin Adler.
1344 * Scripts/prepare-ChangeLog:
1345 (get_function_line_ranges_for_cpp): If the line ends with a backslash instead of a matching
1346 quotation mark, use new variable $quotation_mark to remember what we are looking for, and
1347 keep consuming the quoted text until the matching quotation mark is reached. Emit the
1348 warning only if a line ends without a backslash before the matching quotation mark was found.
1350 2015-03-18 Joseph Pecoraro <pecoraro@apple.com>
1352 Remove unused "preprocessor" parameter to sub-CodeGenerators
1353 https://bugs.webkit.org/show_bug.cgi?id=142793
1355 Reviewed by Darin Adler.
1357 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1360 2015-03-18 Csaba Osztrogonác <ossy@webkit.org>
1362 [EFL] Bump gstreamer version to 1.4.4
1363 https://bugs.webkit.org/show_bug.cgi?id=142782
1365 Reviewed by Philippe Normand.
1367 * efl/jhbuild.modules:
1368 * efl/patches/gst-libav.patch:
1369 * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
1370 * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
1372 2015-03-17 Tim Horton <timothy_horton@apple.com>
1376 * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
1377 (WTR::InjectedBundle::platformInitialize):
1379 2015-03-17 Dean Jackson <dino@apple.com>
1381 check-webkit-style should allow "bool a : 1"
1382 https://bugs.webkit.org/show_bug.cgi?id=142794
1384 Reviewed by Brent Fulgham.
1386 We should allow member bitfields of the form:
1390 It seems that Visual Studio 8 was the last compiler that
1391 wasn't happy about not using unsigned here. We already have
1392 about 500 cases (in WebCore) where people were ignoring this rule.
1394 * Scripts/webkitpy/style/checkers/cpp.py:
1395 (check_language): Allow "bool".
1396 * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add tests.
1397 (CppStyleTest.test_enum_bitfields):
1398 (CppStyleTest.test_plain_integral_bitfields):
1400 2015-03-17 Benjamin Poulain <bpoulain@apple.com>
1402 Compile character ranges targeting the same state as range check in the bytecode
1403 https://bugs.webkit.org/show_bug.cgi?id=142759
1405 Reviewed by Alex Christensen.
1407 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1408 (TestWebKitAPI::TEST_F):
1410 2015-03-17 Youenn Fablet <youenn.fablet@crf.canon.fr>
1412 W3C test parser and converter should use test importer host
1413 https://bugs.webkit.org/show_bug.cgi?id=142729
1415 Reviewed by Bem Jones-Bey.
1417 When instantiated by TestImporter, TestParser and TestConverter are now using the same host.
1418 This enables adding more TestImporter unit testing.
1419 This patch also ensures that the git object instantiated by TestDownloader is using the
1420 same Executive and FileSystem object as TestDownloader, again to enable TestImporter/TestDownloader unit testing.
1422 * Scripts/webkitpy/common/system/filesystem_mock.py:
1423 (MockFileSystem.copytree): Fixes implementation as it creates a runtime error.
1424 * Scripts/webkitpy/w3c/test_downloader.py:
1425 (TestDownloader.git): Set the executive of the git object to the one of TestDownloader. Refactoring in a new git function for future reuse.
1426 (TestDownloader.checkout_test_repository): Making use of the new git function.
1427 * Scripts/webkitpy/w3c/test_importer.py:
1428 (TestImporter.find_importable_tests): Adding host as parameter to the parser.
1429 (TestImporter.import_tests): Adding host as parameter to the converter.
1430 * Scripts/webkitpy/w3c/test_importer_unittest.py:
1431 (TestImporterTest.create_test_download_importer): Creating a test downloader mock, to be reused by other tests.
1433 (TestImporterTest.test_harnesslinks_conversion): Adding test to check that test harness links are converted for CSS tests but not WPT tests.
1434 * Scripts/webkitpy/w3c/test_parser.py:
1435 (TestParser.__init__): Adding host as parameter constructor.
1437 2015-03-17 Carlos Garcia Campos <cgarcia@igalia.com>
1439 [GTK] WebKitDOM objects leaking
1440 https://bugs.webkit.org/show_bug.cgi?id=118788
1442 Reviewed by Darin Adler and Sergio Villar Senin.
1444 Update DOMObjectCache unit test to check that DOM objects are also
1445 released when new contents are loaded in the web view, and the old
1446 document is detached from the frame.
1448 * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
1449 (testWebKitDOMObjectCache):
1450 * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1453 2015-03-17 Youenn Fablet <youenn.fablet@crf.canon.fr>
1455 W3C test importer default import folder should be LayoutTests/imported/w3c
1456 https://bugs.webkit.org/show_bug.cgi?id=142728
1458 Reviewed by Bem Jones-Bey.
1460 * Scripts/webkitpy/w3c/test_importer.py:
1461 (parse_args): Updating the default destination option value to 'imported/w3c'.
1463 2015-03-17 Philippe Normand <pnormand@igalia.com>
1465 [GTK] basic OpenWebRTC build support
1466 https://bugs.webkit.org/show_bug.cgi?id=142393
1468 Reviewed by Carlos Garcia Campos.
1470 * gtk/jhbuild.modules: Add OpenWebRTC and its dependencies. This
1471 is not the upstream OpenWebRTC repository. This temporary fork
1472 contains a few patches needed by WebKit for audio/video rendering.
1474 2015-03-17 Gyuyoung Kim <gyuyoung.kim@samsung.com>
1476 [CMake][EFL] Build test tools only for developer mode
1477 https://bugs.webkit.org/show_bug.cgi?id=142761
1479 Reviewed by Csaba Osztrogonác.
1481 Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on production mode.
1485 2015-03-17 Joseph Pecoraro <pecoraro@apple.com>
1487 Remove never used "useLayerOnTop" bindings generator argument
1488 https://bugs.webkit.org/show_bug.cgi?id=142773
1490 Reviewed by Darin Adler.
1492 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1495 2015-03-16 Ryosuke Niwa <rniwa@webkit.org>
1497 Enable ES6 classes by default
1498 https://bugs.webkit.org/show_bug.cgi?id=142774
1500 Reviewed by Gavin Barraclough.
1502 * Scripts/webkitperl/FeatureList.pm:
1504 2015-03-16 Alexey Proskuryakov <ap@apple.com>
1506 Fix webkitpy tests after r181585.
1508 Looks like "me" cannot be anyone's email, it's a special case.
1510 * Scripts/webkitpy/common/config/contributors.json:
1512 2015-03-16 Alexey Proskuryakov <ap@apple.com>
1514 Add tolerance to WebAudio tests
1515 https://bugs.webkit.org/show_bug.cgi?id=142676
1517 Reviewed by Tim Horton.
1519 * Scripts/webkitpy/common/wavediff.py: Added. Based on Jer Noble's work.
1521 * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1522 (TestResultWriter.create_audio_diff_and_write_result):
1523 * Scripts/webkitpy/layout_tests/models/test_failures.py:
1524 (FailureAudio.write_failure):
1525 * Scripts/webkitpy/port/base.py:
1526 (Port.do_audio_results_differ):
1527 Diff audio failures.
1529 * Scripts/webkitpy/port/test.py: Added a test for the tolerance, fixed existing
1530 tests to use real parseable WAV data, and got rid of base64, which there didn't
1531 seem to have been any reason for.
1533 2015-03-16 Alexey Proskuryakov <ap@apple.com>
1535 [Mac] fast/forms/text-control-intrinsic-widths.html fails when MS Office is installed
1536 https://bugs.webkit.org/show_bug.cgi?id=142720
1538 Reviewed by Myles C. Maxfield.
1540 Activate system copies of Microsoft fonts for the current process, thus overriding
1541 any other ones that could be preferred by the system otherwise.
1543 * DumpRenderTree/mac/DumpRenderTree.mm:
1544 (activateSystemCoreWebFonts):
1546 * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1547 (WTR::activateSystemCoreWebFonts):
1548 (WTR::activateFonts):
1550 2015-03-16 Xabier Rodriguez Calvar <calvaris@igalia.com>
1552 Created Streams API watchlist
1553 https://bugs.webkit.org/show_bug.cgi?id=142684
1555 Reviewed by Benjamin Poulain.
1557 * Scripts/webkitpy/common/config/watchlist: Created StreamsAPI
1558 watchlist and added Benjamin, Youenn and me to it.
1560 2015-03-15 Benjamin Poulain <benjamin@webkit.org>
1562 CSS: fix the case-insensitive matching of the attribute selectors Begin, End and Hyphen
1563 https://bugs.webkit.org/show_bug.cgi?id=142715
1565 Reviewed by Brent Fulgham.
1567 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1568 (TestWebKitAPI::TEST):
1570 2015-03-15 Benjamin Poulain <bpoulain@apple.com>
1572 Change the exact attribute matching to be ASCII case-insensitive
1573 https://bugs.webkit.org/show_bug.cgi?id=142609
1575 Reviewed by Darin Adler.
1577 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1578 * TestWebKitAPI/Tests/WTF/StringView.cpp:
1580 2015-03-13 Youenn Fablet <youenn.fablet@crf.canon.fr>
1582 WebKit test infrastructure should automate the process of cloning W3C test suite and importing tests from it
1583 https://bugs.webkit.org/show_bug.cgi?id=134764
1585 Reviewed by Ryosuke Niwa.
1587 TestDownloader is introduced to download W3C tests from the official
1588 W3C tests repositories (https://github.com/w3c/web-platform-tests.git
1589 and https://github.com/w3c/csswg-test.git).
1590 TestDownloader clones the repositories and checkouts revisions of the tests
1591 defined in LayoutTests/imported/w3c/resources/TestRepositories.
1593 Similarly to https://codereview.chromium.org/148173016,
1594 TestDownloader copies part of the files based on the rules
1595 defined in LayoutTests/imported/w3c/resources/ImportExpectations.
1597 TestDownloader is used by TestImporter when no source directory is provided.
1599 * Scripts/webkitpy/w3c/test_downloader.py: Added.
1601 (TestDownloader.default_options):
1602 (TestDownloader.load_test_repositories):
1603 (TestDownloader.__init__):
1604 (TestDownloader.checkout_test_repository):
1605 (TestDownloader._init_paths_from_expectations):
1606 (TestDownloader._add_test_suite_paths):
1607 (TestDownloader._empty_directory):
1608 (TestDownloader.copy_tests):
1609 (TestDownloader.download_tests):
1610 * Scripts/webkitpy/w3c/test_importer.py:
1613 (TestImporter.__init__):
1614 (TestImporter.do_import):
1615 (TestImporter.test_downloader):
1616 (TestImporter.find_importable_tests.should_keep_subdir):
1617 (TestImporter.should_convert_test_harness_links):
1618 (TestImporter.import_tests):
1619 (TestImporter.write_import_log):
1621 2015-03-12 Alexey Proskuryakov <ap@apple.com>
1623 [Mavericks] Test snapshots are 1600x1200 on Retina devices
1624 https://bugs.webkit.org/show_bug.cgi?id=142630
1626 Reviewed by Tim Horton.
1628 * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
1629 Removed an ifdef that disabled the fix on Mavericks.
1631 2015-03-12 Csaba Osztrogonác <ossy@webkit.org>
1633 Remove isWK2 cruft from webkitdirs.pm after r170426
1634 https://bugs.webkit.org/show_bug.cgi?id=142618
1636 Reviewed by Daniel Bates.
1638 * Scripts/webkitdirs.pm:
1641 2015-03-12 Alexey Proskuryakov <ap@apple.com>
1643 testRunner.setAlwaysAcceptCookies does not work with NetworkProcess
1644 https://bugs.webkit.org/show_bug.cgi?id=138687
1646 Reviewed by Carlos Garcia Campos.
1648 Always change cookie policy from UI process, as changing it from WebProcess doesn't
1649 affect other processes.
1651 The implementation is imperfect, because the change happens asynchronously, but I
1652 don't expect it to be a problem in practice.
1654 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1655 (WTR::InjectedBundle::beginTesting):
1656 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1657 (WTR::TestRunner::setAlwaysAcceptCookies):
1658 * WebKitTestRunner/TestInvocation.cpp:
1659 (WTR::TestInvocation::invoke):
1660 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1662 2015-03-12 Csaba Osztrogonác <ossy@webkit.org>
1664 [EFL] Enable building EFL 1.13 with NEON support
1665 https://bugs.webkit.org/show_bug.cgi?id=142619
1667 Reviewed by Gyuyoung Kim.
1669 * efl/jhbuild.modules:
1671 2015-03-11 Alex Christensen <achristensen@webkit.org>
1673 [Content Extensions] Add resource type and load type triggers.
1674 https://bugs.webkit.org/show_bug.cgi?id=142422
1676 Reviewed by Benjamin Poulain.
1678 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1679 (TestWebKitAPI::testRequest):
1680 (TestWebKitAPI::mainDocumentRequest):
1681 (TestWebKitAPI::TEST_F):
1682 (TestWebKitAPI::testURL): Deleted.
1684 2015-03-10 Sam Weinig <sam@webkit.org>
1686 Allow adding a button in input elements for auto fill related functionality
1687 <rdar://problem/19782066>
1688 https://bugs.webkit.org/show_bug.cgi?id=142564
1690 Reviewed by Anders Carlsson.
1692 * WebKitTestRunner/TestController.cpp:
1693 (WTR::TestController::createOtherPage):
1694 (WTR::TestController::createWebViewWithOptions):
1695 Update for new callback.
1697 2015-03-11 Benjamin Poulain <bpoulain@apple.com>
1699 Add basic support for BOL and EOL assertions to the URL Filter parser
1700 https://bugs.webkit.org/show_bug.cgi?id=142568
1702 Reviewed by Alex Christensen.
1704 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1705 (TestWebKitAPI::TEST_F):
1707 2015-03-11 Carlos Garcia Campos <cgarcia@igalia.com>
1709 [GTK] Add support for handling TLS errors to MiniBrowser
1710 https://bugs.webkit.org/show_bug.cgi?id=142576
1712 Reviewed by Sergio Villar Senin.
1714 It's useful for testing TLS errors handling itself, but also to
1715 allow ignoring TLS errors when testing.
1717 * MiniBrowser/gtk/BrowserWindow.c:
1718 (webViewLoadFailedWithTLSerrors):
1719 (browserWindowConstructed):
1721 2015-03-11 Myles C. Maxfield <mmaxfield@apple.com>
1723 Use out-of-band messaging for RenderBox::firstLineBaseline() and RenderBox::inlineBlockBaseline()
1724 https://bugs.webkit.org/show_bug.cgi?id=142569
1726 Reviewed by David Hyatt.
1728 Test Optional::valueOrCompute().
1730 * TestWebKitAPI/Tests/WTF/Optional.cpp:
1731 (TestWebKitAPI::TEST):
1733 2015-03-11 Carlos Garcia Campos <cgarcia@igalia.com>
1735 [GTK] Add an option to enable MiniBrowser for non developer builds and always install it
1736 https://bugs.webkit.org/show_bug.cgi?id=126688
1738 Reviewed by Gustavo Noronha Silva.
1740 * CMakeLists.txt: Build testing tools only for developer builds,
1741 but MiniBrowser when ENABLE_MINIBROWSER option is ON.
1742 * MiniBrowser/gtk/CMakeLists.txt: Only add
1743 -DWEBKIT_INJECTED_BUNDLE_PATH to the build for developer builds,
1744 and add a rule to install the MiniBrowser.
1745 * MiniBrowser/gtk/main.c:
1746 (main): Only set WEBKIT_INJECTED_BUNDLE_PATH env var for developer
1749 2015-03-11 Brent Fulgham <bfulgham@apple.com>
1751 Add some DateMath tests to TestWebKitAPI
1752 https://bugs.webkit.org/show_bug.cgi?id=142565
1754 Reviewed by Alexey Proskuryakov.
1756 * TestWebKitAPI/CMakeLists.txt: Add new DateMath.cpp file.
1757 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
1758 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
1759 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto."
1760 * TestWebKitAPI/Tests/WTF/DateMath.cpp: Added.
1762 2015-03-10 Brent Fulgham <bfulgham@apple.com>
1764 Regression(r181257): WTF_WorkQueue.Simple is flaky
1765 https://bugs.webkit.org/show_bug.cgi?id=142560
1767 Unreviewed attempt to improve test stability.
1769 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Check the reference count for
1770 the WorkQueue a little later to redue flakiness.
1772 2015-03-10 Myles C. Maxfield <mmaxfield@apple.com>
1774 Migrate from SystemUIFontSelect to AppleSystemFontOSSubversion
1775 https://bugs.webkit.org/show_bug.cgi?id=142555
1777 Reviewed by Simon Fraser.
1779 * DumpRenderTree/mac/DumpRenderTree.mm:
1780 (setDefaultsToConsistentValuesForTesting):
1781 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1782 (WTR::InjectedBundle::platformInitialize):
1784 2015-03-10 Alex Christensen <achristensen@webkit.org>
1786 Use unsigned for HashSet size.
1787 https://bugs.webkit.org/show_bug.cgi?id=142518
1789 Reviewed by Benjamin Poulain.
1791 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1792 (TestWebKitAPI::TEST):
1793 * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1794 (TestWebKitAPI::testInitialCapacity):
1795 * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
1796 (TestWebKitAPI::TEST):
1798 2015-03-10 Daniel Bates <dabates@apple.com>
1800 [iOS] Add WebKitSystemInterface for iOS 8.2
1801 https://bugs.webkit.org/show_bug.cgi?id=142505
1803 Rubber-stamped by Anders Carlsson.
1805 Make copy-webkitlibraries-to-product-directory install libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a.
1806 I inadvertently forgot to add libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a to script
1807 copy-webkitlibraries-to-product-directory in r181286.
1809 * Scripts/copy-webkitlibraries-to-product-directory:
1811 2015-03-10 Benjamin Poulain <bpoulain@apple.com>
1813 Extend URL filter's Term definition to support groups/subpatterns
1814 https://bugs.webkit.org/show_bug.cgi?id=142519
1816 Reviewed by Alex Christensen.
1818 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1819 (TestWebKitAPI::testURL):
1821 2015-03-06 Jer Noble <jer.noble@apple.com>
1823 Add an option to run-webkit-tests to override the LayoutTests/ directory
1824 https://bugs.webkit.org/show_bug.cgi?id=142418
1826 Reviewed by David Kilzer.
1828 Add an arugment to run-webkit-tests which, when set, overrides the port's default LayoutTests
1829 directory. The base port will parse the options during initialization and store the override
1830 location if present. layout_tests_dir() will return this overridden location if set.
1832 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1834 * Scripts/webkitpy/port/base.py:
1836 (Port.layout_tests_dir):
1838 2015-03-09 Martin Robinson <mrobinson@igalia.com>
1840 [CMake] Enable WorkQueue tests for CMake ports
1841 https://bugs.webkit.org/show_bug.cgi?id=142473
1843 Reviewed by Darin Adler.
1845 * TestWebKitAPI/CMakeLists.txt: Add the WorkQueue tests source file to
1846 the list of source files.
1847 * Tools/TestWebKitAPI/PlatformEfl.cmake: Add the DispatchQueueEfl directory
1848 to the list of include directories for EFL.
1850 2015-03-09 David Kilzer <ddkilzer@apple.com>
1852 Attempt to fix timeouts on iOS Simulator layout tests
1854 * Scripts/webkitpy/port/ios.py:
1855 (IOSSimulatorPort.setup_test_run): Most layout test runs on iOS
1856 Simulator end after the first 50 tests time out. Some analysis
1857 this past weekend shows that the 'Booted' status in the output
1858 of `xcrun simctl list` is not sufficient (and watching the test
1859 run shows that SpringBoard hasn't fully started to the point
1860 where it's displaying icons on the home screen). The workaround
1861 until we have a better fix is to add an arbitrary timeout to let
1862 SpringBoard finish launching. In practice, 15 seconds is
1863 probably enough, but 30 seconds should nearly always work.
1865 2015-03-09 Per Arne Vollan <peavo@outlook.com>
1867 Unreviewed. Add myself as a committer.
1869 * Scripts/webkitpy/common/config/contributors.json:
1871 2015-03-09 David Kilzer <ddkilzer@apple.com>
1873 Attempt to fix WTF_WorkQueue.TwoQueues timeout test failure
1875 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1876 (TestWebKitAPI::TEST): Change delay from 50ns to 50ms, and add
1877 an expectation that will fail if we hit the race condition.
1878 This test is inherently racy and will deadlock if the first job
1879 for queue2 takes the mutex lock before the second job for
1882 2015-03-08 Brent Fulgham <bfulgham@apple.com>
1884 [Win] WTF::WorkQueue does not balance ref/deref properly
1885 https://bugs.webkit.org/show_bug.cgi?id=142471
1887 Reviewed by Antti Koivisto.
1889 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1890 (TestWebKitAPI::TEST): Check that the refcount is correct.
1892 2015-03-08 Gyuyoung Kim <gyuyoung.kim@samsung.com>
1894 Do not show passing test result on output of EFL layout test
1895 https://bugs.webkit.org/show_bug.cgi?id=142380
1897 Reviewed by Darin Adler.
1899 To show passing tests has caused inconvenience when we detect problem tests
1900 in output of layout test. So this patch applies '--debug-rwt-logging' except for EFL port
1901 in order not to show passing tests in the output of EFL layout test.
1903 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1904 (RunWebKitTests.start):
1906 2015-03-08 Brent Fulgham <bfulgham@apple.com>
1908 Unreviewed build fix.
1910 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1911 (TestWebKitAPI::TEST): Remove two unused variables.
1913 2015-03-08 Brent Fulgham <bfulgham@apple.com>
1915 Add some WorkQueue tests to TestWebKitAPI
1916 https://bugs.webkit.org/show_bug.cgi?id=142447
1918 Reviewed by Sam Weinig.
1920 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1921 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1922 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1923 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Added.
1924 (TestWebKitAPI::simpleTest):
1925 (TestWebKitAPI::longTest):
1926 (TestWebKitAPI::thirdTest):
1927 (TestWebKitAPI::finishedTests):
1928 (TestWebKitAPI::TEST):
1929 (TestWebKitAPI::longTest2):
1931 2015-03-08 Carlos Garcia Campos <cgarcia@igalia.com>
1933 Remove willDestroyFrame in WKBundlePageLoaderClient
1934 https://bugs.webkit.org/show_bug.cgi?id=142389
1936 Reviewed by Anders Carlsson.
1938 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1939 (WTR::InjectedBundlePage::InjectedBundlePage):
1941 2015-03-07 Brent Fulgham <bfulgham@apple.com>
1943 [Win] Increase TestWebKitAPI Test Coverage[Win] Increase TestWebKitAPI Test Coverage
1944 https://bugs.webkit.org/show_bug.cgi?id=142433
1946 Reviewed by Darin Adler.
1948 Include more TestWebKitAPI tests when building for Windows. Also
1949 fix a build error in MetaAllocator.cpp caused by one of the
1950 Microsoft headers #defining 'small'.
1952 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1953 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1954 * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1956 2015-03-06 Sam Weinig <sam@webkit.org>
1958 [Content Extensions] Move compiling of content extensions to the UIProcess
1959 https://bugs.webkit.org/show_bug.cgi?id=142402
1961 Reviewed by Benjamin Poulain.
1963 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1964 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: Copied from Tools/TestWebKitAPI/Tests/WebCore/ContentFilter.cpp.
1965 (TestWebKitAPI::InMemoryCompiledContentExtension::create):
1966 (TestWebKitAPI::InMemoryCompiledContentExtension::~InMemoryCompiledContentExtension):
1967 (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
1968 (TestWebKitAPI::TEST_F):
1969 * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Removed.
1970 Update test for new name (ContentFilter -> ContentExtensions) and API (CompiledContentExtension
1973 2015-03-06 Brent Fulgham <bfulgham@apple.com>
1975 [Win] Correct Windows build.
1977 Rubberstamped by Michael Saboff
1979 * win/AssembleBuildLogs/AssembleLogs.cmd: Correct cut/paste error
1982 2015-03-06 Carlos Garcia Campos <cgarcia@igalia.com>
1984 [GTK] Test /webkit2/WebKitWebView/sync-request-on-max-conns might fail after finished
1985 https://bugs.webkit.org/show_bug.cgi?id=142385
1987 Reviewed by Sergio Villar Senin.
1989 Use stack allocated GMainLoopSources to make sure they are
1990 cancelled automatically if the test finishes before they have
1993 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1994 (testWebViewSyncRequestOnMaxConns):
1996 2015-03-06 Csaba Osztrogonác <ossy@webkit.org>
1998 Remove Mountain Lion libraries since ML isn't supported
1999 https://bugs.webkit.org/show_bug.cgi?id=142332
2001 Reviewed by Darin Adler.
2003 * Scripts/copy-webkitlibraries-to-product-directory:
2005 2015-03-06 Carlos Alberto Lopez Perez <clopez@igalia.com> and Youenn Fablet <youenn.fablet@crf.canon.fr>
2007 Layout tests imported/w3c/web-platform-tests certificates should not be tracked on WebKit VCS
2008 https://bugs.webkit.org/show_bug.cgi?id=142083
2010 Reviewed by Simon Fraser.
2012 Modifying on the fly wpt config.json to set the directory where to generate/read certificates as a subfolder of the layout test results folder.
2014 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2015 (WebPlatformTestServer._copy_webkit_test_files):
2017 2015-03-06 Csaba Osztrogonác <ossy@webkit.org>
2019 setup-git-clone fails due to the failure to download python-irclib-0.4.8
2020 https://bugs.webkit.org/show_bug.cgi?id=141946
2022 Reviewed by Ryosuke Niwa.
2024 Check in ircbot.py and irclib.py to avoid network problems in the future.
2026 * Scripts/webkitpy/common/net/irc/ircbot.py:
2027 * Scripts/webkitpy/thirdparty/__init__.py:
2028 (AutoinstallImportHook.find_module):
2029 (AutoinstallImportHook._install_irc): Deleted.
2030 * Scripts/webkitpy/thirdparty/__init___unittest.py:
2031 (ThirdpartyTest.test_imports):
2032 * Scripts/webkitpy/thirdparty/irc/__init__.py: Added.
2033 * Scripts/webkitpy/thirdparty/irc/ircbot.py: Added.
2034 * Scripts/webkitpy/thirdparty/irc/irclib.py: Added.
2036 2015-03-06 David Kilzer <ddkilzer@apple.com>
2038 Dashboard: Perf bot status is missing for Apple {Mavericks,Yosemite} Release builds
2040 See also fix to config.json in r181097.
2042 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2043 (WebKitBuildbot): Add missing "WK2" to the names of the perf
2046 2015-03-06 Csaba Osztrogonác <ossy@webkit.org>
2048 run-jsc-stress-tests should determine the architecture from ELF binaries
2049 https://bugs.webkit.org/show_bug.cgi?id=142335
2051 Reviewed by Darin Adler.
2053 * Scripts/run-jsc-stress-tests:
2055 2015-03-05 David Kilzer <ddkilzer@apple.com>
2057 [iOS] TestExpectations for ios-simulator-wk2 should fall back to 'wk2' after 'ios-simulator'
2058 <http://webkit.org/b/142226>
2060 Reviewed by Darin Adler.
2062 * Scripts/webkitpy/port/ios.py:
2063 (IOSSimulatorPort.default_baseline_search_path): Switch the
2064 TestExpectations order of ios-simulator-wk2 from this:
2065 ios-simulator-wk2, wk2, ios-simulator
2067 ios-simulator-wk2, ios-simualtor, wk2
2069 2015-03-05 Brent Fulgham <bfulgham@apple.com>
2071 [Win] Provide tiered logging from MSBuild -- Errors on top, Warnings after
2072 https://bugs.webkit.org/show_bug.cgi?id=142370
2074 Reviewed by Dean Jackson.
2076 * Scripts/webkitdirs.pm:
2077 (buildVisualStudioProject): Tell MSBuild to output log files to two separate
2078 logs, one for warnings, the other for errors.
2079 * win/AssembleBuildLogs/AssembleLogs.cmd: Combine the error and warning logs
2080 into the standard BuildOutput.htm document.
2082 2015-03-05 David Kilzer <ddkilzer@apple.com>
2084 Dashboard has trouble parsing iOS test output
2085 <http://webkit.org/b/142364>
2087 Reviewed by Alex Christensen.
2089 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2090 (BuildbotTestResults.prototype._parseResults.resultSummarizer):
2091 Add fallback path to build a regex using 'matchString' so that
2092 it matches anywhere in the line. In practice, 'matchString' is
2093 a prefix for the label following the number.
2095 2015-03-05 Alex Christensen <achristensen@webkit.org>
2097 Fix linker warnings in TestWebKitAPI.
2098 https://bugs.webkit.org/show_bug.cgi?id=141912
2100 Reviewed by David Kilzer.
2102 * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2103 Do not export TearDownTestCase or SetUpTestCase symbols.
2105 2015-03-05 Brent Fulgham <bfulgham@apple.com>
2107 [Win] Unreviewed EWS fix.
2109 * Scripts/webkitdirs.pm:
2110 (buildVisualStudioProject): Dial logging back to 'ErrorsOnly' to see if that makes
2111 the EWS output more usable.
2113 2015-03-05 Chris Dumez <cdumez@apple.com>
2115 Regression(r173761): ASSERTION FAILED: !is8Bit() in StringImpl::characters16()
2116 https://bugs.webkit.org/show_bug.cgi?id=142350
2118 Reviewed by Michael Saboff and Benjamin Poulain.
2120 Add API test for WTFString::hasInfixStartingAt() to make sure it doesn't
2121 crash if the string is 8-bit but the pattern is 16-bit (and vice-versa).
2123 * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2124 (TestWebKitAPI::TEST):
2126 2015-03-05 Brent Fulgham <bfulgham@apple.com>
2128 [Win] Ensure build target directory exists when launching MSBuild
2129 https://bugs.webkit.org/show_bug.cgi?id=142360
2131 Reviewed by Dean Jackson.
2133 Create the build output directory (if it doesn't exist) before
2134 launching MSBuild so that it can immediately begin writing logs.
2136 * Scripts/webkitdirs.pm:
2137 (buildVisualStudioProject):
2139 2015-03-05 Chris Dumez <cdumez@apple.com>
2141 run-webkit-tests and run-perf-tests should use WebKitTestRunner by default
2142 https://bugs.webkit.org/show_bug.cgi?id=142325
2144 Reviewed by Csaba Osztrogonác.
2146 run-webkit-tests and run-perf-tests now use WebKitTestRunner by default.
2147 As a result, "--webkit-test-runner / -2" parameters are replaced by
2148 "--dump-render-tree / -1" so developers can run DumpRenderTree rather
2149 than WebKitTestRunner.
2151 * BuildSlaveSupport/build.webkit.org-config/config.json:
2152 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2154 (RunWebKit1Tests.start):
2155 (RunWebKit1LeakTests):
2156 (RunWebKit1LeakTests.start):
2157 (RunAndUploadPerfTestsWebKit1):
2158 (RunAndUploadPerfTestsWebKit1.start):
2160 (TestWebKit1LeaksFactory):
2161 (TestWebKit1LeaksFactory.__init__):
2162 (TestWebKit1Factory):
2163 (TestWebKit1AllButJSCFactory):
2164 (TestAllButJSCFactory):
2165 (BuildAndPerfTestWebKit1Factory):
2166 (BuildAndPerfTestWebKit1Factory.__init__):
2167 (BuildAndPerfTestFactory):
2168 (BuildAndPerfTestFactory.__init__):
2169 (DownloadAndPerfTestWebKit1Factory):
2170 (DownloadAndPerfTestWebKit1Factory.__init__):
2171 (DownloadAndPerfTestFactory):
2172 (DownloadAndPerfTestFactory.__init__):
2173 (RunWebKitLeakTests): Deleted.
2174 (RunWebKitLeakTests.start): Deleted.
2175 (RunWebKit2Tests): Deleted.
2176 (RunWebKit2Tests.start): Deleted.
2177 (RunAndUploadPerfTestsWebKit2): Deleted.
2178 (RunAndUploadPerfTestsWebKit2.start): Deleted.
2179 (TestLeaksFactory): Deleted.
2180 (TestLeaksFactory.__init__): Deleted.
2181 (TestWebKit2Factory): Deleted.
2182 (TestWebKit2AndJSCFactory): Deleted.
2183 (BuildAndPerfTestWebKit2Factory): Deleted.
2184 (BuildAndPerfTestWebKit2Factory.__init__): Deleted.
2185 (DownloadAndPerfTestWebKit2Factory): Deleted.
2186 (DownloadAndPerfTestWebKit2Factory.__init__): Deleted.
2187 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2189 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2190 (PerfTestsRunner._parse_args):
2191 * Scripts/webkitpy/port/port_testcase.py:
2192 (PortTestCase.test_build_driver):
2194 2015-03-05 Brent Fulgham <bfulgham@apple.com>
2196 [Win] Switch to MSBuild so we get more useful stdout logging in buildbot
2197 https://bugs.webkit.org/show_bug.cgi?id=140845
2199 Reviewed by David Kilzer.
2201 Update 'webkitdirs.pm' to locate the MSBuild used with Visual Studio 2013
2202 and generate suitable build commands to drive a full build from our
2203 existing solution files.
2205 * Scripts/webkitdirs.pm:
2206 (msBuildInstallDir): Added.
2207 (determineConfigurationForVisualStudio): Revise to use MSBuild command
2208 line arguments to drive the build.
2209 (setupCygwinEnv): Warn user if MSBuild cannot be located.
2210 (buildVisualStudioProject): Revise to use MSBuild command line arguments
2211 to specify build architecture.
2212 * win/AssembleBuildLogs/AssembleLogs.cmd: MSBuild doesn't produce individual
2213 output logs, so don't attempt to consolidate them. Also: Drive-by fix: Don't
2214 bother looking for CoreUI or SafariTheme build logs.
2216 2015-03-05 Csaba Osztrogonác <ossy@webkit.org>
2218 [buildbot] mastercfg_unittest.py should be runnable easily
2219 https://bugs.webkit.org/show_bug.cgi?id=142219
2221 Reviewed by Chris Dumez.
2223 Buildbot 0.8.6p1 runs on build.webkit org with Twisted 12.1.0, which is
2224 the last Twisted version works together with this buildbot version.
2226 * Scripts/webkitpy/common/system/autoinstall.py:
2227 (AutoInstaller): Added prepend_to_search_path argument to be able
2228 to prefer autoinstalled package to system package.
2229 (AutoInstaller.__init__):
2230 (AutoInstaller._set_up_target_dir):
2231 (AutoInstaller._extract_tar): Renamed from _extract_targz, now it works with tar.bz2 too.
2232 (AutoInstaller._prepare_package):
2233 (AutoInstaller._extract_targz): Renamed to _extract_tar.
2234 * Scripts/webkitpy/thirdparty/__init__.py:
2235 (AutoinstallImportHook._install_buildbot): Autoinstall Twisted 12.1.0.
2237 2015-03-05 Lukasz Bialek <l.bialek@samsung.com>
2239 [EFL][WK2] Crash when "Download Linked File" from MiniBrowser context menu is clicked
2240 https://bugs.webkit.org/show_bug.cgi?id=131162
2242 Reviewed by Gyuyoung Kim.
2244 * MiniBrowser/efl/main.c:
2245 (on_download_request):
2246 (on_download_finished):
2247 (on_download_failed):
2249 Adapt download callbacks to new callback mechanism
2251 2015-03-05 Carlos Garcia Campos <cgarcia@igalia.com>
2253 Unreviewed. Fix /webkit2/WebKitWebResource/mime-type after r180927.
2255 In r180927 we updated the libsoup version used by the jhbuild. In
2256 this new version the sniffer uses image/x-icon instead of
2257 image/vnd.microsoft.icon for blank.ico resource.
2259 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2260 (testWebResourceMimeType):
2262 2015-03-05 Carlos Garcia Campos <cgarcia@igalia.com>
2264 [SOUP] Check TLS errors as soon as they are set in the SoupMessage
2265 https://bugs.webkit.org/show_bug.cgi?id=142244
2267 Reviewed by Sergio Villar Senin.
2269 Check that the SSL server doesn't process any request in case of
2270 TLS errors when the policy is set to FAIL.
2272 * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2273 (testTLSErrorsPolicy):
2274 (testTLSErrorsRedirect):
2275 (testTLSErrorsHTTPAuth):
2276 (testLoadFailedWithTLSErrors):
2277 (testSubresourceLoadFailedWithTLSErrors):
2278 (httpsServerCallback):
2280 2015-03-05 Pawel Forysiuk <p.forysiuk@samsung.com>
2282 [EFL] REGRESSION (r178685): ASSERTION FAILED: !parameters.mediaKeyStorageDirectory.isEmpty()
2283 https://bugs.webkit.org/show_bug.cgi?id=141154
2285 Reviewed by Jer Noble.
2287 Unlike GTK, EFL port enables ENABLE_ENCRYPTED_MEDIA_V2 build option by default.
2289 For the sake of completeness WebKitTestRunner should specify temporary
2290 folder for MediaKeysStorageDirecory as well as IndexedDB, LocalStorage, etc.
2292 Default non legacy paths are set up in ProcessPoolConfiguration constructor.
2293 They use WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
2294 to get data storage paths. Only Mac port has an actual implementation of it.
2295 However, WebKitTestRunner overrides them in favour of unique temporary dir
2296 which is taken from libraryPathForTesting().
2298 Since WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
2299 is not implemented for EFL and GTK ports it returns an empty string.
2300 All default data folders besides MediaKeys are overridden in TestRunner
2301 code with unique temporary folders derived from DUMPRENDERTREE_TEMP
2304 GTK port does not enable encrypted keys by default so
2305 WebMediaKeyStorageManager::initialize() code path is never triggered.
2307 * WebKitTestRunner/TestController.cpp:
2308 (WTR::TestController::initialize): Set MediaKeysStorageDirectory for all
2311 2015-03-05 Csaba Osztrogonác <ossy@webkit.org>
2313 [buildbot] Add regression test to check which builder runs which tests
2314 https://bugs.webkit.org/show_bug.cgi?id=142166
2316 Reviewed by Alexey Proskuryakov.
2318 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2319 (BuildStepsConstructorTest.createTest):
2321 (BuildStepsTest.generateTests):
2322 (BuildStepsTest.createTest):
2323 (BuildStepsTest.createTest.doTest):
2324 (BuildStepsTest.test_unnecessary_expected_results):
2326 2015-03-04 Commit Queue <commit-queue@webkit.org>
2328 Unreviewed, rolling out r181054.
2329 https://bugs.webkit.org/show_bug.cgi?id=142320
2331 Broke the api tests (Requested by sundiamonde on #webkit).
2335 "Fix linker warnings in TestWebKitAPI."
2336 https://bugs.webkit.org/show_bug.cgi?id=141912
2337 http://trac.webkit.org/changeset/181054
2339 2015-03-04 Alex Christensen <achristensen@webkit.org>
2341 Fix linker warnings in TestWebKitAPI.
2342 https://bugs.webkit.org/show_bug.cgi?id=141912
2344 Reviewed by David Kilzer.
2346 * TestWebKitAPI/Configurations/Base.xcconfig:
2347 Use GCC_SYMBOLS_PRIVATE_EXTERN like we do in WebCore.
2349 2015-03-04 Alexey Proskuryakov <ap@apple.com>
2351 [Mac] Set SystemUIFontSelect in DRT and WKTR
2352 https://bugs.webkit.org/show_bug.cgi?id=142303
2354 Reviewed by Myles C. Maxfield.
2356 * DumpRenderTree/mac/DumpRenderTree.mm:
2357 (setDefaultsToConsistentValuesForTesting):
2358 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2359 (WTR::InjectedBundle::platformInitialize):
2361 2015-03-04 Chris Dumez <cdumez@apple.com>
2363 Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
2364 https://bugs.webkit.org/show_bug.cgi?id=142314
2365 <rdar://problem/20046835>
2367 Reviewed by Ryosuke Niwa.
2369 Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
2370 to get WK2 code coverage.
2372 * BuildSlaveSupport/build.webkit.org-config/config.json:
2374 2015-03-04 Alex Christensen <achristensen@webkit.org>
2376 Move content extensions test to properly named directory.
2377 https://bugs.webkit.org/show_bug.cgi?id=142299
2379 Reviewed by Tim Horton.
2381 * WebKitTestRunner/mac/TestControllerMac.mm:
2382 (WTR::TestController::platformConfigureViewForTest):
2384 2015-03-04 Youenn Fablet <youenn.fablet@crf.canon.fr>
2386 W3C test importer should use filesystem instead of os.walk
2387 https://bugs.webkit.org/show_bug.cgi?id=142085
2389 Reviewed by Bem Jones-Bey.
2391 Added FileSystem.dirs_under to remove the use of os.walk in test importer.
2392 Added MockFileSystem.dirs_under and MockFileSystem.getsize to enable unit testing of test importer.
2393 Added unit test for FileSystem.dirs_under and MockFileSystem.dirs_under.
2395 Made use of FileSystem.dirs_under within TestImporter.find_importable_tests.
2396 Added a unit test to check that test importer is now black-box testable using a Mock system.
2398 * Scripts/webkitpy/common/system/filesystem.py:
2399 (FileSystem.dirs_under): Returns a list of filtered sub-directories.
2400 (FileSystem.dirs_under.filter_all):
2401 * Scripts/webkitpy/common/system/filesystem_mock.py:
2402 (MockFileSystem.dirs_under):
2403 (MockFileSystem.dirs_under.filter_all):
2404 (MockFileSystem.getsize):
2405 * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
2406 (MockFileSystemTest.test_dirs_under):
2407 (MockFileSystemTest.test_dirs_under.filter_dir):
2408 * Scripts/webkitpy/common/system/filesystem_unittest.py:
2409 (RealFileSystemTest.test_sep):
2410 (RealFileSystemTest):
2411 (RealFileSystemTest.test_dirs_under):
2412 (RealFileSystemTest.test_dirs_under.filter_this_dir):
2413 * Scripts/webkitpy/w3c/test_importer.py:
2414 (TestImporter.do_import):
2415 (TestImporter.find_importable_tests.should_keep_subdir):
2416 (TestImporter.find_importable_tests):
2417 (TestImporter.should_keep_subdir): Deleted.
2418 (TestImporter.should_skip_file): Deleted.
2419 * Scripts/webkitpy/w3c/test_importer_unittest.py:
2420 (TestImporterTest.test_import_dir_with_empty_init_py): Added test to ensure empty __init__.py are no longer empty once imported.
2422 2015-03-04 Timothy Horton <timothy_horton@apple.com>
2424 [WebEditingTester] Add support for the find and replace bar
2425 https://bugs.webkit.org/show_bug.cgi?id=142247
2427 Reviewed by Enrica Casucci.
2429 While it's not hooked up yet in WKWebView, adding support for the
2430 find bar to WebEditingTester will help us implement that functionality.
2432 * WebEditingTester/AppDelegate.h:
2433 * WebEditingTester/AppDelegate.m:
2434 (-[WebEditingAppDelegate performTextFinderAction:]):
2435 * WebEditingTester/MainMenu.xib:
2436 Receive performTextFinderAction: and forward it to the frontmost WebDocumentController.
2438 * WebEditingTester/WK2WebDocumentController.m:
2439 (-[WK2WebDocumentController awakeFromNib]):
2440 (-[WK2WebDocumentController performTextFinderAction:]):
2441 (-[WK2WebDocumentController findBarView]):
2442 (-[WK2WebDocumentController setFindBarView:]):
2443 (-[WK2WebDocumentController isFindBarVisible]):
2444 (-[WK2WebDocumentController setFindBarVisible:]):
2445 (-[WK2WebDocumentController findBarViewDidChangeHeight]):
2446 (-[WK2WebDocumentController layout]):
2447 Implement performTextFinderAction: for WebKit2, and have a NSTextFinder
2448 pointing at the WKWebView (currently nothing will work, but the bar will
2449 show up). Install and uninstall the bar as needed.
2451 * WebEditingTester/WebDocument.xib:
2452 Don't use a full-size content view. There's no need, and it makes find
2455 * WebEditingTester/WebDocumentController.h:
2456 * WebEditingTester/WebDocumentController.m:
2457 (-[WebDocumentController performTextFinderAction:]):
2459 2015-03-03 Sam Weinig <sam@webkit.org>
2461 [Content Extensions] Split parsing and compiling of content extensions into their own files
2462 https://bugs.webkit.org/show_bug.cgi?id=142259
2464 Reviewed by Anders Carlsson.
2466 Add basic unit test for the content filter compiler.
2468 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2469 * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Added.
2470 (WebCore::ContentExtensions::operator<<):
2471 (TestWebKitAPI::ContentFilterTest::SetUp):
2472 (TestWebKitAPI::TEST_F):
2474 2015-03-04 Matthew Mirman <mmirman@apple.com>
2476 Cleaned up BuildAndTestFactory to not be a near duplicate of TestFactory
2477 https://bugs.webkit.org/show_bug.cgi?id=142230
2479 Reviewed by Csaba Osztrogonác.
2481 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2483 (TestFactory.getProduct): Added
2484 (TestFactory.__init__): moved downloader to getProduct
2485 (BuildAndTestFactory):
2486 (BuildAndTestFactory.getProduct): Added
2487 (BuildAndTestFactory.__init__): made to call TestFactory.__init__ and append steps to the end.
2488 (BuildAndTestWebKit2Factory): Deleted. Wasn't used anywhere.
2490 2015-03-04 Debarshi Ray <debarshir@gnome.org>
2492 [GTK] WebView should hold a reference on WebContext because non-default contexts are a reality
2493 https://bugs.webkit.org/show_bug.cgi?id=142225
2495 Reviewed by Carlos Garcia Campos.
2497 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2498 (testWebViewWebContextLifetime):
2501 2015-03-03 David Kilzer <ddkilzer@apple.com>
2503 [iOS] Crash logs can't be found on ios-simulator because WebKitTestRunner returns the wrong process name
2504 <http://webkit.org/b/142243>
2506 Reviewed by Alexey Proskuryakov.
2508 * WebKitTestRunner/TestController.cpp:
2509 (WTR::TestController::webProcessName):
2510 (WTR::TestController::networkProcessName):
2511 - Return the same process name on iOS and Mac because they both
2512 use the same process name for local engineering builds.
2514 2015-03-03 David Kilzer <ddkilzer@apple.com>
2516 check-webkit-style: Add exception for FrameworkSoftLink.h header order
2517 <http://webkit.org/b/141872>
2519 Reviewed by Alex Christensen.
2521 * Scripts/webkitpy/style/checkers/cpp.py: Remove unneeded
2522 semi-colons in various places and fix whitespace.
2523 (_IncludeState): Add _SOFT_LINK_HEADER and _SOFT_LINK_SECTION
2525 (_IncludeState.__init__): Add self._visited_soft_link_section
2526 boolean state variable.
2527 (_IncludeState.visited_soft_link_section): Getter for
2528 self._visited_soft_link_section.
2529 (_IncludeState.check_next_include_order): Update state machine
2530 for soft-link headers. Add check that soft-link headers always
2532 (_classify_include): Add check for soft-link header type.
2533 (check_include_line): Return early if there is a soft-link
2536 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2537 (OrderOfIncludesTest.test_public_primary_header): Add tests for
2538 including soft-link headers.
2539 (OrderOfIncludesTest.test_classify_include): Add test for
2540 _SOFT_LINK_HEADER type.
2542 2015-03-03 Alexey Proskuryakov <ap@apple.com>
2544 build.webkit.org/dashboard: Don't repeatedly handle each test type
2545 https://bugs.webkit.org/show_bug.cgi?id=142211
2547 Reviewed by Tim Horton and Matt Hanson.
2549 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2550 (Buildbot.prototype.javascriptTestResultsURLForIteration): Deleted.
2551 (Buildbot.prototype.apiTestResultsURLForIteration): Deleted.
2552 (Buildbot.prototype.platformAPITestResultsURLForIteration): Deleted.
2553 (Buildbot.prototype.webkitpyTestResultsURLForIteration): Deleted.
2554 (Buildbot.prototype.webkitperlTestResultsURLForIteration): Deleted.
2555 (Buildbot.prototype.bindingsTestResultsURLForIteration): Deleted.
2556 Removed functions that build a link to test step results. The buildbot provides
2557 these links in JSON.
2559 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2560 (BuildbotIteration): Put failing tests into an array, instead of named variables.
2561 (BuildbotIteration.ProductiveSteps): Removed step names that are not used on build.webkit.org.
2562 We can easily add them to the map as needed.
2563 (BuildbotIteration.TestSteps): Added a list of test steps to be displayed by test queues.
2564 (BuildbotIteration.prototype._parseData): Moved code for parsing step results away
2565 to BuildbotTestResults class. We used to parse here, build an intermediate data structure,
2566 and then build a BuildbotTestResults object, which was strange.
2567 (BuildbotIteration.prototype.loadLayoutTestResults): Ditto.
2569 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2570 Corrected an unrelated assertion that was buggy, and kept firing.
2572 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2573 (BuildbotTestResults):
2574 (BuildbotTestResults.prototype._parseResults.resultSummarizer):
2575 (BuildbotTestResults.prototype._parseResults):
2576 (BuildbotTestResults.prototype.addFullLayoutTestResults):
2577 Moved the code for parsing JSON results for a single step here.
2579 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2580 (BuildbotTesterQueueView.prototype._testStepFailureDescription):
2581 (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount):
2582 (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
2583 (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Deleted.
2584 (BuildbotTesterQueueView.prototype.update): Deleted.
2585 (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Deleted.
2586 Updated for the new data structures. One behavior change is that we now display individual
2587 counts when multiple test kinds fail, e.g. "1 javascript test failure, 83+ layout
2588 test failures, 3 platform api test failures".
2590 2015-03-03 Matthew Mirman <mmirman@apple.com>
2592 JSC tests should not be repeated twice for each branch builder, and should if possible have their own queue.
2593 https://bugs.webkit.org/show_bug.cgi?id=142094
2595 Reviewed by Csaba Osztrogonác.
2597 * BuildSlaveSupport/build.webkit.org-config/config.json: Added bots 155 and 157
2598 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2600 (TestFactory.__init__): Made running of JSC tests conditional.
2601 (TestAllButJSCFactory):
2602 (TestJSCFactory): Added.
2603 (TestJSCFactory.__init__):
2604 (TestWebKit2AndJSCFactory): Added factory to not run JSC tests on WebKit2.
2606 2015-03-03 David Kilzer <ddkilzer@apple.com>
2608 `build-webkit --help` is wrong about how to build for the iOS simulator
2609 <http://webkit.org/b/142223>
2611 Reviewed by Csaba Osztrogonác.
2613 * Scripts/build-webkit: Fix help.
2615 2015-03-03 Carlos Garcia Campos <cgarcia@igalia.com>
2617 Unreviewed. Bump libsoup version to 2.49.91.1 to fix 32 bit build.
2619 * gtk/jhbuild.modules:
2621 2015-03-03 Carlos Garcia Campos <cgarcia@igalia.com>
2623 [SOUP] Synchronous XMLHttpRequests can time out when we reach the max connections limit
2624 https://bugs.webkit.org/show_bug.cgi?id=141508
2626 Reviewed by Sergio Villar Senin.
2628 Add a unit test to check that synchronous XHRs load even if the
2629 maximum connection limits are reached.
2631 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2632 (testWebViewSyncRequestOnMaxConns):
2635 * gtk/jhbuild.modules: Bump libsoup version to 2.49.91.
2637 2015-03-02 Alexey Proskuryakov <ap@apple.com>
2639 Update the name of ASan build step.
2641 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2643 2015-03-02 Jer Noble <jer.noble@apple.com>
2645 [WK1][WK2][Mac] Fullscreen animation is incorrect when page is scaled.
2646 https://bugs.webkit.org/show_bug.cgi?id=142121
2648 Reviewed by Simon Fraser.
2650 Add a test which changes the WebView's page scale, then enters fullscreen mode, and verifies
2651 that the initial and final screen rects for the web content are as expected.
2653 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2654 * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.html: Added.
2655 * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm: Added.
2656 (-[FullscreenStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
2657 (runJavaScriptAlert):
2658 (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
2659 (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
2660 (TestWebKitAPI::FullscreenZoomInitialFrame::setPageScale):
2661 (TestWebKitAPI::FullscreenZoomInitialFrame::sendMouseDownEvent):
2662 (TestWebKitAPI::FullscreenZoomInitialFrame::runTest):
2663 (TestWebKitAPI::TEST_F):
2665 2015-03-01 David Kilzer <ddkilzer@apple.com>
2667 LayoutTestRealy: Prepend __XPC_ to the key, not the value!
2671 LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
2672 <http://webkit.org/b/142145>
2674 * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2675 (-[LTRelayController _environmentVariables]): Fix think-o.
2677 2015-03-01 David Kilzer <ddkilzer@apple.com>
2679 LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
2680 <http://webkit.org/b/142145>
2682 Reviewed by Simon Fraser.
2684 * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2685 (-[LTRelayController _environmentVariables]): Add.
2686 (-[LTRelayController launchApp]): Use -_environmentVariables.
2688 2015-02-28 David Kilzer <ddkilzer@apple.com>
2690 [iOS] Stop running webkit-build-directory on every layout test
2692 This was originally fixed by David Farler for Bug 135409 in
2695 * Scripts/webkitpy/port/ios.py:
2696 (IOSSimulatorPort.relay_path): Mark as @memoized so it doesn't
2697 run webkit-build-directory every time it's called.
2699 2015-02-28 Youenn Fablet <youenn.fablet@crf.canon.fr>
2701 W3C importer should use filesystem instead of shutil/host
2702 https://bugs.webkit.org/show_bug.cgi?id=142012
2704 Reviewed by Bem Jones-Bey.
2706 Removed direct use of python shutil and os, except for os.walk which will require its own fix.
2708 * Scripts/webkitpy/w3c/test_importer.py:
2710 (TestImporter.do_import):
2711 (TestImporter.find_importable_tests):
2712 (TestImporter.import_tests):
2713 (TestImporter.remove_deleted_files):
2714 (TestImporter.write_import_log):
2716 2015-02-28 Youenn Fablet <youenn.fablet@crf.canon.fr>
2718 W3C test importer should use filesystem to read and write files
2719 https://bugs.webkit.org/show_bug.cgi?id=142084
2721 Reviewed by Bem Jones-Bey.
2723 Use of FileSystem.write_binary_file, read_text_file and write_text_file in lieu of open().
2725 * Scripts/webkitpy/w3c/test_importer.py:
2726 (TestImporter.import_tests):
2727 (TestImporter.remove_deleted_files):
2728 (TestImporter.write_import_log):
2730 2015-02-27 Sam Weinig <sam@webkit.org>
2732 Add WebKit2 SPI to create a DOM File object
2733 https://bugs.webkit.org/show_bug.cgi?id=142109
2735 Reviewed by Tim Horton.
2737 Add a test for WKBundleFileHandleRef.
2739 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2740 * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle.cpp: Added.
2741 (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2742 (TestWebKitAPI::didFinishLoadForFrame):
2743 (TestWebKitAPI::TEST):
2744 * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle_Bundle.cpp: Added.
2745 (TestWebKitAPI::WKBundleFileHandleTest::WKBundleFileHandleTest):
2746 * TestWebKitAPI/Tests/WebKit2/bundle-file.html: Added.
2748 2015-02-27 Michael Saboff <msaboff@apple.com>
2750 Add ability for run-jsc-benchmarks to set library path from test binary when run on a build bot
2751 https://bugs.webkit.org/show_bug.cgi?id=142112
2753 Reviewed by Filip Pizlo.
2755 Added check for VMs in the form of <someDir>/{DumpRenderTree,webkitTestRunner,jsc} and use
2756 <someDir> as the library path.
2758 * Scripts/run-jsc-benchmarks:
2760 2015-02-27 Alex Christensen <achristensen@webkit.org>
2762 [WinCairo] Unreviewed build fix.
2764 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
2765 Use TestWebKitAPIPrefix.h like in TestWebKitAPICommon.props.
2767 2015-02-27 Anders Carlsson <andersca@apple.com>
2769 Add infrastructure for handling website data in the network process
2770 https://bugs.webkit.org/show_bug.cgi?id=142092
2772 Reviewed by Andreas Kling.
2774 Add a menu item that will fetch all website data, delete the returned data records, and
2775 fetch all website data again so we can confirm that it's all empty.
2777 * MiniBrowser/mac/WK2BrowserWindowController.m:
2778 (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
2780 2015-02-26 Brent Fulgham <bfulgham@apple.com>
2782 [Win] Remove remaining SafariTheme cruft
2783 https://bugs.webkit.org/show_bug.cgi?id=142075
2785 Reviewed by Anders Carlsson.
2787 Remove reference to SafariTheme-switching preference.
2789 * DumpRenderTree/win/DumpRenderTree.cpp:
2790 (resetWebPreferencesToConsistentValues):
2791 (prepareConsistentTestingEnvironment):
2793 2015-02-26 Doug Russell <d_russell@apple.com>
2795 AX: Expose caret browsing preference to accessibility API
2796 https://bugs.webkit.org/show_bug.cgi?id=141862
2798 Reviewed by Chris Fleizach.
2800 Exposing the caret browsing setting on WebCore::Frame via the accessibility API would allow assistive tech apps to enable it contextually (for example, when the assistive tech app is running).
2801 Enabling caret browsing when assistive tech apps are running greatly improves the reliability of keyboard navigation on the web. Most especially in cases where selection would be disrupted by focus events.
2803 * DumpRenderTree/AccessibilityUIElement.cpp:
2804 (setBoolAttributeValueCallback):
2805 (selectedTextMarkerRangeCallback):
2806 (resetSelectedTextMarkerRangeCallback):
2807 (AccessibilityUIElement::setBoolAttributeValue):
2808 (AccessibilityUIElement::selectedTextMarkerRange):
2809 (AccessibilityUIElement::resetSelectedTextMarkerRange):
2810 (AccessibilityUIElement::getJSClass):
2811 * DumpRenderTree/AccessibilityUIElement.h:
2812 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2813 (AccessibilityUIElement::setBoolAttributeValue):
2814 (AccessibilityUIElement::selectedTextMarkerRange):
2815 (AccessibilityUIElement::resetSelectedTextMarkerRange):
2816 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2817 (WTR::AccessibilityUIElement::selectedTextMarkerRange):
2818 (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
2819 (WTR::AccessibilityUIElement::setBoolAttributeValue):
2820 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2821 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2822 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2823 (WTR::AccessibilityUIElement::setBoolAttributeValue):
2824 (WTR::AccessibilityUIElement::selectedTextMarkerRange):
2825 (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
2827 2015-02-26 Brent Fulgham <bfulgham@apple.com>
2829 [Win] Remove WebKitExportGenerator project (and related)
2830 https://bugs.webkit.org/show_bug.cgi?id=142035
2832 Reviewed by Dean Jackson.
2834 * win/AssembleBuildLogs/AssembleLogs.cmd: Don't look for a
2835 build log from WebKitExportGenerator.
2837 2015-02-26 Csaba Osztrogonác <ossy@webkit.org>
2839 [EFL] Bump EFL version to 1.13.0
2840 https://bugs.webkit.org/show_bug.cgi?id=141708
2842 Reviewed by Gyuyoung Kim.
2844 * efl/jhbuild.modules:
2846 2015-02-26 Sam Weinig <sam@webkit.org>
2848 Check in missing WebEditingTester.xcconfig file.
2850 * WebEditingTester/Configurations/WebEditingTester.xcconfig: Added.
2852 2015-02-26 Csaba Osztrogonác <ossy@webkit.org>
2854 [webkitpy] Remove skipped file related crufts
2855 https://bugs.webkit.org/show_bug.cgi?id=142046
2857 Reviewed by Ryosuke Niwa.
2859 * Scripts/webkitpy/port/base.py:
2860 (Port.skipped_layout_tests):
2861 (Port._tests_from_skipped_file_contents): Deleted.
2863 (Port._expectations_from_skipped_files): Deleted.
2864 * Scripts/webkitpy/port/mac_unittest.py:
2865 (MacTest.test_default_timeout_ms):
2867 (test_tests_from_skipped_file_contents): Deleted.
2869 2015-02-26 Brent Fulgham <bfulgham@apple.com>
2871 [Win] Unreviewed WinCairo build fix after r180653.
2873 TestWebKitAPI should know about proper WEBCORE_EXPORT definitions.
2875 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2876 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
2877 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
2878 * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Added.
2879 * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Added.
2881 2015-02-25 Brent Fulgham <bfulgham@apple.com>
2883 [Win] Use WEBCORE_EXPORT instead of Definition file
2884 https://bugs.webkit.org/show_bug.cgi?id=141734
2886 Reviewed by Alex Christensen.
2888 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2889 Use a precompiled header so we can define our export macros properly.
2890 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
2891 Visual studio automatic update stuff.
2892 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
2893 Set up Precompiled Header use for project..
2894 * DumpRenderTree/win/DumpRenderTreePrefix.cpp: Added.
2895 * DumpRenderTree/DumpRenderTreePrefix.h: Update with proper export
2896 declarations for building DumpRenderTree as a client of
2899 2015-02-25 Mark Lam <mark.lam@apple.com>
2901 ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack.
2902 <https://webkit.org/b/141672>
2904 Reviewed by Alexey Proskuryakov.
2906 ASan does not like the fact that we memcpy the stack for GC scans. So,
2907 we're working around this by using our own memcpy (asanUnsafeMemcpy)
2908 implementation that we can tell ASan to ignore.
2910 Also removed the previous added directive to ignore *tryCopyOtherThreadStack*
2911 which isn't effective for working around this issue.
2913 * asan/webkit-asan-ignore.txt:
2915 2015-02-25 Benjamin Poulain <bpoulain@apple.com>
2917 CodeBlock crashes when dumping op_push_name_scope
2918 https://bugs.webkit.org/show_bug.cgi?id=141953
2920 Reviewed by Filip Pizlo.
2922 * Scripts/run-jsc-stress-tests:
2924 2015-02-25 Youenn Fablet <youenn.fablet@crf.canon.fr>
2926 W3C test importer should use argparse instead of optparse
2927 https://bugs.webkit.org/show_bug.cgi?id=142013
2929 Reviewed by Bem Jones-Bey.
2931 * Scripts/webkitpy/w3c/test_importer.py:
2932 (main): Updating according argparse.
2933 (parse_args): Moving from optparse to argparse.
2935 2015-02-25 Brady Eidson <beidson@apple.com>
2937 Get rid of TestInvocation::pathOrURL
2938 https://bugs.webkit.org/show_bug.cgi?id=142021
2940 Reviewed by Tim Horton.
2942 The pathOrURL string is a relative path used as an argument to WebKitTestRunner,
2943 but most code that uses it expected an absolute path.
2945 This gets rid of the member and replaces all uses with a more descriptive "urlContains" method.
2947 * WebKitTestRunner/TestController.cpp:
2948 (WTR::TestController::updateWebViewSizeForTest):
2949 (WTR::TestController::updateWindowScaleForTest):
2950 (WTR::shouldUseFixedLayout):
2951 (WTR::TestController::updateLayoutTypeForTest):
2953 * WebKitTestRunner/TestInvocation.cpp:
2954 (WTR::TestInvocation::TestInvocation):
2955 (WTR::TestInvocation::urlContains):
2956 (WTR::TestInvocation::shouldLogFrameLoadDelegates):
2957 (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
2958 (WTR::TestInvocation::invoke):
2959 (WTR::shouldLogFrameLoadDelegates): Deleted.
2960 (WTR::shouldLogHistoryClientCallbacks): Deleted.
2961 * WebKitTestRunner/TestInvocation.h:
2962 (WTR::TestInvocation::pathOrURL): Deleted.
2964 * WebKitTestRunner/ios/TestControllerIOS.mm:
2965 (WTR::shouldMakeViewportFlexible):
2966 (WTR::TestController::platformConfigureViewForTest):
2968 * WebKitTestRunner/mac/TestControllerMac.mm:
2969 (WTR::shouldUseThreadedScrolling):
2970 (WTR::TestController::platformConfigureViewForTest):
2972 2015-02-25 Brady Eidson <beidson@apple.com>
2974 Layout test support for user content filters
2975 https://bugs.webkit.org/show_bug.cgi?id=142018
2977 Reviewed by Tim Horton.
2979 * WebKitTestRunner/TestController.cpp:
2980 (WTR::TestController::resetStateToConsistentValues): Clear all user content filters between tests.
2982 * WebKitTestRunner/mac/TestControllerMac.mm:
2983 (WTR::TestController::platformConfigureViewForTest): For all tests with usercontentfilter/ in their path try to load a matching .json
2984 file before loading the test itself.
2986 2015-02-24 Sam Weinig <sam@webkit.org>
2988 Convert WebEditingTester to use xcconfig files
2989 https://bugs.webkit.org/show_bug.cgi?id=141879
2991 Reviewed by Darin Adler.
2993 Add xcconfig files to WebEditingTester based on the ones used by MiniBrowser.
2995 * WebEditingTester/Configurations: Added.
2996 * WebEditingTester/Configurations/Base.xcconfig: Added.
2997 * WebEditingTester/Configurations/DebugRelease.xcconfig: Added.
2998 * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3000 2015-02-24 Andy Estes <aestes@apple.com>
3002 Teach MiniBrowser how to disable per-window web processes
3003 https://bugs.webkit.org/show_bug.cgi?id=141988
3005 Reviewed by Darin Adler.
3007 * MiniBrowser/mac/AppDelegate.m:
3008 (defaultConfiguration): Created a _WKProcessPoolConfiguration with maximumProcessCount == 1 if per-window web processes are disabled.
3009 * MiniBrowser/mac/SettingsController.h:
3010 * MiniBrowser/mac/SettingsController.m:
3011 (-[SettingsController _populateMenu]): Added a new Settings menu item.
3012 (-[SettingsController validateMenuItem:]): Validated the new Settings menu item.
3013 (-[SettingsController togglePerWindowWebProcessesDisabled:]): Displayed an alert informing the user that MiniBrowser must be restarted for the setting to take effect.
3014 (-[SettingsController perWindowWebProcessesDisabled]): Returned the value from user defaults.
3016 2015-02-24 Alexey Proskuryakov <ap@apple.com>
3018 Bot watcher's dashboard sometimes hits an assertion: data.num_missing === this.layoutTestResults.testsWithMissingResults.length
3019 https://bugs.webkit.org/show_bug.cgi?id=141889
3021 Reviewed by Darin Adler.
3023 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3025 2015-02-24 Yusuke Suzuki <utatane.tea@gmail.com>
3027 REGRESSION(r179429): Can't type comments in Facebook
3028 https://bugs.webkit.org/show_bug.cgi?id=141859
3030 Reviewed by Brent Fulgham.
3032 Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
3034 * DumpRenderTree/mac/DumpRenderTree.mm:
3035 (resetWebPreferencesToConsistentValues):
3036 * DumpRenderTree/win/DumpRenderTree.cpp:
3037 (resetWebPreferencesToConsistentValues):
3038 * WebKitTestRunner/TestController.cpp:
3039 (WTR::TestController::resetPreferencesToConsistentValues):
3041 2015-02-24 Michael Catanzaro <mcatanzaro@igalia.com>
3043 Crash loading local file with WebPageProxy::loadAlternateHTMLString
3044 https://bugs.webkit.org/show_bug.cgi?id=141867
3046 Reviewed by Anders Carlsson.
3048 * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
3049 (TestWebKitAPI::loadAlternateHTMLString): Split most of this test into a function so it can
3050 be shared with the new test.
3051 (TestWebKitAPI::TEST): Add a cross-platform test for this crash.
3052 * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Add a GTK+ test for this crash.
3053 (testLoadAlternateHTMLForLocalPage):
3056 2015-02-24 David Kilzer <ddkilzer@apple.com>
3058 [iOS] Implement WTR::activateFonts() to fix missing fonts in WebKit2 test runs
3059 <http://webkit.org/b/141900>
3061 Reviewed by Myles C. Maxfield.
3063 * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
3064 (OTHER_LDFLAGS_BASE): Link to CoreText.framework.
3065 * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm: Rename from Tools/WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm.
3066 - Rename to share code with iOS.
3067 - Add USE(APPKIT) around AppKit-specific headers and code.
3068 - Fix a check-webkit-style warning.
3069 * WebKitTestRunner/InjectedBundle/ios/ActivateFontsIOS.mm: Remove.
3070 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3071 - Rename mac/ActivateFonts.mm to cocoa/ActivateFontsCocoa.mm.
3072 - Remove ios/ActivateFontsIOS.mm.
3073 - Fix InjectedBundle/cocoa group to represent the directory on
3074 disk. Includes a change to InjectedBundlePageCocoa.mm.
3076 2015-02-23 Commit Queue <commit-queue@webkit.org>
3078 Unreviewed, rolling out r180547 and r180550.
3079 https://bugs.webkit.org/show_bug.cgi?id=141957
3081 Broke 10 Windows tests. (Requested by bfulgham_ on #webkit).
3083 Reverted changesets:
3085 "REGRESSION(r179429): Can't type comments in Facebook"
3086 https://bugs.webkit.org/show_bug.cgi?id=141859
3087 http://trac.webkit.org/changeset/180547
3089 "Constructor returning null should construct an object instead
3091 https://bugs.webkit.org/show_bug.cgi?id=141640
3092 http://trac.webkit.org/changeset/180550
3094 2015-02-23 Yusuke Suzuki <utatane.tea@gmail.com>
3096 REGRESSION(r179429): Can't type comments in Facebook
3097 https://bugs.webkit.org/show_bug.cgi?id=141859
3099 Reviewed by Geoffrey Garen.
3101 Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
3103 * DumpRenderTree/mac/DumpRenderTree.mm:
3104 (resetWebPreferencesToConsistentValues):
3105 * WebKitTestRunner/TestController.cpp:
3106 (WTR::TestController::resetPreferencesToConsistentValues):
3108 2015-02-23 KwangHyuk Kim <hyuki.kim@samsung.com>
3111 https://bugs.webkit.org/show_bug.cgi?id=141909
3113 Reviewed by Gyuyoung Kim.
3115 Fix eo errors that occur whenever minibrowser is launched.
3116 - elm_obj_entry_text_style_user_push can only be applied for elm_entry
3117 - elm_obj_win_resize_object_add's first parameter should be elm_win
3119 * MiniBrowser/efl/main.c:
3122 2015-02-23 Ryosuke Niwa <rniwa@webkit.org>
3124 Unreviewed build fix after r180535. Removed the test case that wasn't compiling.
3126 * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3127 (TestWebKitAPI::TEST):
3129 2015-02-23 Brent Fulgham <bfulgham@apple.com>
3131 WTF::WeakPtr should rename 'forgot' to 'clear' and support nullptr assignment
3132 https://bugs.webkit.org/show_bug.cgi?id=141935
3134 Reviewed by Myles C. Maxfield.
3136 * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3137 (TestWebKitAPI::TEST): Updated for 'clear' method rename, and added a few
3138 tests for assigning from nullptr.
3140 2015-02-23 Brent Fulgham <bfulgham@apple.com>
3142 WTF::WeakPtr should have a 'forget' method.
3143 https://bugs.webkit.org/show_bug.cgi?id=141923
3145 Reviewed by Myles C. Maxfield.
3147 * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3148 (TestWebKitAPI::TEST): Added 'Forget' tests case.
3150 2015-02-23 Alexey Proskuryakov <ap@apple.com>
3152 build.webkit.org/dashboard CrashOnly queues should not show two green bubbles
3153 https://bugs.webkit.org/show_bug.cgi?id=141920
3155 Reviewed by Tim Horton.
3157 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3158 (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3159 Do the same thing as we do for regular green bubbles.
3161 2015-02-23 Alexey Proskuryakov <ap@apple.com>
3163 Bot watcher's dashboard doesn't show a popover for commit history when all commits were to another branch
3164 https://bugs.webkit.org/show_bug.cgi?id=141925
3166 Reviewed by Tim Horton.
3168 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3169 (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
3171 2015-02-23 Anders Carlsson <andersca@apple.com>
3173 Add API for fetching website data records to _WKWebsiteDataStore
3174 https://bugs.webkit.org/show_bug.cgi?id=141926
3176 Reviewed by Beth Dakin.
3178 * MiniBrowser/mac/MainMenu.xib:
3179 * MiniBrowser/mac/WK2BrowserWindowController.m:
3180 (-[WK2BrowserWindowController fetchWebsiteData:]):
3181 Add menu item to fetch and dump website data.
3183 2015-02-23 David Kilzer <ddkilzer@apple.com>
3185 [iOS] run-webkit-tests --leaks is broken because IOSSimulatorPort has no is_snowleopard attribute
3186 <http://webkit.org/b/141884>
3188 Reviewed by Alexey Proskuryakov.
3190 * Scripts/webkitpy/port/leakdetector.py:
3191 (LeakDetector._callstacks_to_exclude_from_leaks): Remove
3192 snowleopard, lion and older leaks. Add known leak for
3193 mavericks, but check Port.operating_system before calling
3195 * Scripts/webkitpy/port/mac.py:
3196 (MacPort.is_snowleopard): Delete.
3197 (MacPort.is_lion): Delete.
3198 (MacPort.is_mavericks): Add.
3200 2015-02-23 Alexey Proskuryakov <ap@apple.com>
3202 build.webkit.org/dashboard should filter out commits to other branches
3203 https://bugs.webkit.org/show_bug.cgi?id=140362
3205 Reviewed by Tim Horton.
3207 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3209 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3210 (BuildbotQueueView.prototype._presentPopoverForPendingCommits):
3211 (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
3212 (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration):
3213 (BuildbotQueueView.prototype.revisionContentForIteration):
3214 (BuildbotQueueView.prototype._appendPendingRevisionCount): Deleted.
3215 (BuildbotQueueView.prototype._popoverLinesForCommitRange): Deleted.
3216 (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Deleted.
3217 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3218 (Trac.prototype.get oldestRecordedRevisionNumber):
3219 (Trac.prototype.commitsOnBranch):
3220 (Trac.prototype._xmlTimelineURL):
3221 (Trac.prototype._convertCommitInfoElementToObject):
3222 (Trac.prototype._update):
3223 (Trac.prototype.startPeriodicUpdates):
3224 (Trac.prototype.loadMoreHistoricalData):
3225 (Trac.prototype.update): Deleted.
3227 2015-02-21 Youenn Fablet <youenn.fablet@crf.canon.fr>
3229 Tests don't work on some bots: Failed to stop wptwk
3230 https://bugs.webkit.org/show_bug.cgi?id=141235
3232 Reviewed by Ryosuke Niwa.
3234 Logging of server subprocesses in launcher script.
3235 Killing of server subprocesses when stopping/before starting.
3236 Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore.
3238 * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
3239 (main): Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore. Added logging in a file of server subprocesses to clean them in case of abnormal shutdown.
3240 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3241 (WebPlatformTestServer.__init__):
3242 (WebPlatformTestServer._stop_running_subservers): Kill server subprocesses based on file created by wpt launcher.
3243 (WebPlatformTestServer):
3244 (WebPlatformTestServer.stop): Overriden to ensure killing subprocesses in case of orphaned process.
3245 (WebPlatformTestServer._stop_running_server): Killing of wpt launcher process after regular shutdown.
3246 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
3247 (TestWebPlatformTestServer.test_server_closes_previously_spawned_instance): Reworked the test to call start/stop with an existing pid file.
3248 (TestWebPlatformTestServer.test_import_web_platform_test_modules): No change.
3249 (TestWebPlatformTestServer):
3250 (TestWebPlatformTestServer.test_corrupted_subserver_files): Checked that server subprocess cleaning does not throw in case of bad server pid file.
3252 2015-02-20 Timothy Horton <timothy_horton@apple.com>
3254 [WebEditingTester] Allow dropping HTML files on the app
3255 https://bugs.webkit.org/show_bug.cgi?id=141834
3257 Reviewed by Simon Fraser.
3259 * WebEditingTester/AppDelegate.m:
3260 (-[WebEditingAppDelegate openDocument:]):
3261 (-[WebEditingAppDelegate application:openFile:]):
3262 Implement application:openFile:, factoring file loading code out of openDocument.
3264 * WebEditingTester/Info.plist:
3265 Register as an editor for HTML files.
3267 * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3268 Enrica is not an organization.
3270 2015-02-20 Timothy Horton <timothy_horton@apple.com>
3272 [WebEditingTester] Expand "WK" to "WebKit" in a few places
3273 https://bugs.webkit.org/show_bug.cgi?id=141833
3275 Reviewed by Anders Carlsson.
3277 * WebEditingTester/AppDelegate.h:
3278 * WebEditingTester/AppDelegate.m:
3279 (-[WebEditingAppDelegate newEditor:]):
3280 (-[WebEditingAppDelegate toggleUseWebKit2ByDefault:]):
3281 (-[WebEditingAppDelegate validateMenuItem:]):
3282 (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
3283 (-[WebEditingAppDelegate applicationDidFinishLaunching:]): Deleted.
3284 (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
3285 (-[WebEditingAppDelegate showOperations:]): Deleted.
3286 * WebEditingTester/MainMenu.xib:
3287 The WK abbreviation is unnaturally grating in menu items for some reason.
3289 2015-02-20 Timothy Horton <timothy_horton@apple.com>
3291 [WebEditingTester] Add a custom protocol for loading canned content
3292 https://bugs.webkit.org/show_bug.cgi?id=141830
3294 Reviewed by Enrica Casucci.
3296 Add a canned:// protocol handler, which can be used to emulate behaviors
3297 in WebKit client apps (like Mail) that use custom protocol handlers,
3298 which can have important effects on editing (mostly, the URLs are only
3299 valid inside of the client application, but not when copied/dragged out).
3301 For now, we only support two canned files:
3303 canned://dice is a PNG of dice (stolen from LayoutTests/)
3304 canned://text is the string "canned text" served as text/html
3306 In the future we could support things like very large (generated) files,
3307 progressive loading, etc. to further simulate conditions in other apps.
3309 * WebEditingTester/AppDelegate.m:
3310 (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
3311 Register the protocol with CFNetwork, and the scheme with WebKit2.
3313 * WebEditingTester/Canned Content/dice.png: Added.
3314 * WebEditingTester/CannedContent.h: Added.
3315 * WebEditingTester/CannedContent.m: Added.
3316 (-[CannedContent initWithRequest:cachedResponse:client:]):
3317 (+[CannedContent canonicalRequestForRequest:]):
3318 (+[CannedContent canInitWithRequest:]):
3319 We only want to handle canned:// URLs.
3321 (-[CannedContent startLoading]):
3322 For now, immediately load the two files we know about.
3323 Otherwise, immediately fail the load.
3325 (-[CannedContent stopLoading]):
3326 * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3328 2015-02-20 Timothy Horton <timothy_horton@apple.com>
3330 [WebEditingTester] Implement an open panel
3331 https://bugs.webkit.org/show_bug.cgi?id=141829
3333 Reviewed by Simon Fraser.
3335 * WebEditingTester/AppDelegate.m:
3336 (-[WebEditingAppDelegate _useWebKit1ForOpeningDocument:]):
3337 (-[WebEditingAppDelegate _useWebKit2ForOpeningDocument:]):
3338 (-[WebEditingAppDelegate openDocument:]):
3339 Add an open panel (with radio buttons to pick which WebKit to open with).
3340 Loads the file as an HTML string.
3342 2015-02-20 Simon Fraser <simon.fraser@apple.com>
3344 [WebEditingTester] @properties, dot syntax, and remember the window position
3345 https://bugs.webkit.org/show_bug.cgi?id=141843
3347 Reviewed by Tim Horton.
3349 Modernize a bit with more dot syntax, use @property for the web views,
3350 and give the main window an Autosave name so it remembers the widow position.
3352 * WebEditingTester/WK1WebDocumentController.m:
3353 (-[WK1WebDocumentController awakeFromNib]):
3354 (-[WK1WebDocumentController loadHTMLString:]):
3355 * WebEditingTester/WK2WebDocumentController.m:
3356 (-[WK2WebDocumentController awakeFromNib]):
3357 * WebEditingTester/WebDocument.xib:
3359 2015-02-20 Timothy Horton <timothy_horton@apple.com>
3361 [WebEditingTester] Hook up key equivalents for new window action
3362 https://bugs.webkit.org/show_bug.cgi?id=141828
3364 Reviewed by Enrica Casucci.
3366 * WebEditingTester/AppDelegate.h:
3367 * WebEditingTester/AppDelegate.m:
3368 (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
3369 (-[WebEditingAppDelegate newEditor:]):
3370 (-[WebEditingAppDelegate _defaultWebDocumentControllerClass]):
3371 (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
3372 (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
3373 (defaultConfiguration): Deleted.
3374 (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
3375 Move WKWebViewConfiguration setup into WK2WebDocumentController.
3376 Remove unused application termination code.
3377 Update new-window menu item key equivalents when launching and when
3378 changing the use-WebKit2-by-default setting.
3379 Make WebDocumentController subclasses all initialized the same way,
3380 and use that to factor out alloc/init.
3381 Rename loadContent to loadHTMLString for future use.
3383 * WebEditingTester/MainMenu.xib:
3384 Add default key equivalents.
3385 Cmd-N will always make the default kind of window (controlled by the pref).
3386 Cmd-Opt-N will always make the other kind.
3387 The menu items are configured as alternates so they only show up if you
3388 press alt (just like in MiniBrowser).
3390 * WebEditingTester/WK1WebDocumentController.m:
3391 (-[WK1WebDocumentController loadHTMLString:]):
3392 (-[WK1WebDocumentController loadContent]): Deleted.
3393 * WebEditingTester/WK2WebDocumentController.h:
3394 * WebEditingTester/WK2WebDocumentController.m:
3395 (defaultConfiguration):
3396 (-[WK2WebDocumentController awakeFromNib]):
3397 (-[WK2WebDocumentController loadHTMLString:]):
3398 (-[WK2WebDocumentController initWithConfiguration:]): Deleted.
3399 (-[WK2WebDocumentController dealloc]): Deleted.
3400 * WebEditingTester/WebDocumentController.h:
3401 * WebEditingTester/WebDocumentController.m:
3402 (-[WebDocumentController init]):
3403 (-[WebDocumentController initWithWindow:]):
3404 (+[WebDocumentController defaultEditingSource]):
3405 (-[WebDocumentController loadHTMLString:]):
3406 (-[WebDocumentController windowDidLoad]): Deleted.
3407 (-[WebDocumentController defaultEditingSource]): Deleted.
3408 (-[WebDocumentController applicationTerminating]): Deleted.
3409 (-[WebDocumentController loadContent]): Deleted.
3411 2015-02-20 Timothy Horton <timothy_horton@apple.com>
3413 [WebEditingTester] ARC-ify WebEditingTester
3414 https://bugs.webkit.org/show_bug.cgi?id=141827
3416 Reviewed by Sam Weinig.
3418 * WebEditingTester/AppDelegate.m:
3419 (-[WebEditingAppDelegate showOperations:]):
3420 * WebEditingTester/EditingOperations.m:
3421 (editingOperations):
3422 * WebEditingTester/WK1WebDocumentController.m:
3423 (-[WK1WebDocumentController dealloc]): Deleted.
3424 * WebEditingTester/WK2WebDocumentController.m:
3425 (-[WK2WebDocumentController dealloc]): Deleted.
3426 * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3427 Turn on ARC and remove a few retain/release/autorelease calls.
3428 We don't need to implement dealloc in either document controller
3429 because WebView and WKWebView's UIDelegate property does not hold a
3432 2015-02-20 Timothy Horton <timothy_horton@apple.com>
3434 [WebEditingTester] Factor out list of editing operations
3435 https://bugs.webkit.org/show_bug.cgi?id=141826
3437 Reviewed by Sam Weinig.
3439 * WebEditingTester/AppDelegate.m:
3440 (-[WebEditingAppDelegate showOperations:]):
3441 * WebEditingTester/EditingOperations.h: Added.
3442 * WebEditingTester/EditingOperations.m: Added.
3443 (editingOperations):
3444 * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3445 Move EditingOperations array to its own file, and make it an NSArray
3446 instead of a C array. Adjust accordingly in showOperations:.
3448 2015-02-20 Michael Saboff <msaboff@apple.com>
3450 DFG JIT needs to check for stack overflow at the start of Program and Eval execution
3451 https://bugs.webkit.org/show_bug.cgi?id=141676
3453 Reviewed by Filip Pizlo.
3455 Set the newly added --maximumEvalCacheableSourceLength option for eager test runs. This is needed
3456 to allow the eval out of stack tests to tier up. Without this option, we don't cache the likely
3457 large string expression that we want to eval.
3459 * Scripts/run-jsc-stress-tests:
3461 2015-02-19 Daniel Bates <dabates@apple.com>
3463 REGRESSION (r180239): run-webkit-test fails to boot simulator device that was booted by previous test run
3464 https://bugs.webkit.org/show_bug.cgi?id=141815
3465 <rdar://problem/19893933>
3467 Reviewed by Simon Fraser.
3469 Fixes an issue where run-webkit-tests would fail to boot the WebKit Tester simulator device if it
3470 was booted by iOS Simulator in a previous run of run-webkit-test.
3472 * Scripts/webkitpy/port/ios.py:
3473 (IOSSimulatorPort.check_sys_deps): Added logic moved from IOSSimulatorPort.setup_test_run().
3474 (IOSSimulatorPort.setup_test_run): Moved logic to quit the iOS Simulator app and wait for the
3475 testing device to be in the shutdown state from here to IOSSimulatorPort.check_sys_deps().
3477 2015-02-19 David Kilzer <ddkilzer@apple.com>
3479 check-webkit-style: do not warn about missing primary header for *SoftLink.cpp files
3480 <http://webkit.org/b/141799>
3482 Reviewed by Alex Christensen.
3484 * Scripts/webkitpy/style/checkers/cpp.py:
3485 (_IncludeState.check_next_include_order): Don't emit a warning
3486 if the primary header exists and the source file name ends with
3487 "SoftLink.cpp". Add 'filename' argument to method.
3488 (check_include_line): Pass in 'filename'.
3490 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3491 (OrderOfIncludesTest.test_check_next_include_order__no_config):
3492 (OrderOfIncludesTest.test_check_next_include_order__no_self):
3493 (OrderOfIncludesTest.test_check_next_include_order__likely_then_config):
3494 (OrderOfIncludesTest.test_check_next_include_order__other_then_config):
3495 (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely):
3496 - Add test filename arguments for calls to
3497 check_next_include_order().
3498 (OrderOfIncludesTest.test_primary_header): Add test for a file
3499 name ending in "SoftLink.cpp".
3501 2015-02-18 Enrica Casucci <enrica@apple.com>
3503 Add new tool to test editable Webviews.
3504 https://bugs.webkit.org/show_bug.cgi?id=141772
3506 Reviewed by Tim Horton.
3508 Adding WebEditingTester, a Cocoa application to
3509 test WK1 and Wk2 views in editable mode.
3511 * WebEditingTester: Added.
3512 * WebEditingTester/AppDelegate.h: Added.
3513 * WebEditingTester/AppDelegate.m: Added.
3514 (-[WebEditingAppDelegate init]):
3515 (defaultConfiguration):
3516 (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
3517 (-[WebEditingAppDelegate applicationWillTerminate:]):
3518 (-[WebEditingAppDelegate newEditor:]):
3519 (-[WebEditingAppDelegate showOperations:]):
3520 (-[WebEditingAppDelegate useWebKit2ByDefault]):
3521 (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
3522 (-[WebEditingAppDelegate validateMenuItem:]):
3523 * WebEditingTester/Info.plist: Added.
3524 * WebEditingTester/MainMenu.xib: Added.
3525 * WebEditingTester/WK1WebDocumentController.h: Added.
3526 * WebEditingTester/WK1WebDocumentController.m: Added.
3527 (-[WK1WebDocumentController awakeFromNib]):
3528 (-[WK1WebDocumentController loadContent]):
3529 (-[WK1WebDocumentController dealloc]):
3530 (-[WK1WebDocumentController pasteAsMarkup:]):
3531 * WebEditingTester/WK2WebDocumentController.h: Added.
3532 * WebEditingTester/WK2WebDocumentController.m: Added.
3533 (-[WK2WebDocumentController initWithConfiguration:]):
3534 (-[WK2WebDocumentController pasteAsMarkup:]):
3535 (-[WK2WebDocumentController awakeFromNib]):
3536 (-[WK2WebDocumentController dealloc]):
3537 (-[WK2WebDocumentController loadContent]):
3538 * WebEditingTester/WebDocument.xib: Added.
3539 * WebEditingTester/WebDocumentController.h: Added.
3540 * WebEditingTester/WebDocumentController.m: Added.
3541 (-[WebDocumentController initWithWindow:]):
3542 (-[WebDocumentController windowDidLoad]):
3543 (-[WebDocumentController defaultEditingSource]):
3544 (-[WebDocumentController applicationTerminating]):
3545 (-[WebDocumentController loadContent]):
3546 * WebEditingTester/WebEditingTester.xcodeproj: Added.
3547 * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj: Added.
3548 * WebEditingTester/main.m: Added.
3551 2015-02-18 Csaba Osztrogonác <ossy@webkit.org>
3553 Run JSC tests on ARM EFL bots
3554 https://bugs.webkit.org/show_bug.cgi?id=141165
3556 Reviewed by Alexey Proskuryakov.
3558 * BuildSlaveSupport/build.webkit.org-config/config.json:
3559 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3560 (RunJavaScriptCoreTests.countFailures):
3561 (RunRemoteJavaScriptCoreTests):
3562 (RunRemoteJavaScriptCoreTests.start):
3563 (BuildAndRemoteJSCTestsFactory):
3564 (BuildAndRemoteJSCTestsFactory.__init__):
3566 2015-02-18 Alexey Proskuryakov <ap@apple.com>
3568 Streamline unexported function build fixes
3569 https://bugs.webkit.org/show_bug.cgi?id=141761
3571 Reviewed by Alex Christensen.
3573 * Scripts/check-for-weak-vtables-and-externals: (readXcode5SymbolsToIgnore): Deleted.
3574 We don't need to ignore symbols that are not exported due to the .unexp file.
3576 2015-02-18 Timothy Horton <timothy_horton@apple.com>
3578 Remove more references to WebCore.exp.in
3579 https://bugs.webkit.org/show_bug.cgi?id=141747
3581 Reviewed by Alexey Proskuryakov.
3583 * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3586 2015-02-17 Myles C. Maxfield <mmaxfield@apple.com>
3588 Windows test results should not fall back to mac-mountainlion after r180176
3589 https://bugs.webkit.org/show_bug.cgi?id=141719
3591 Reviewed by Brent Fulgham.
3593 * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3594 (_should_file_trigger_build):
3595 * Scripts/webkitpy/port/win.py:
3596 (WinPort.default_baseline_search_path):
3597 * Scripts/webkitpy/port/win_unittest.py:
3598 (WinPortTest.test_baseline_search_path):
3600 2015-02-17 Daniel Bates <dabates@apple.com>
3602 [iOS] run-webkit-tests should check that simctl can boot and shutdown simulator device before running tests
3603 https://bugs.webkit.org/show_bug.cgi?id=141718
3605 Reviewed by Alex Christensen.
3607 We should only run layout tests if simctl can successfully boot and shutdown the testing device.
3609 * Scripts/webkitpy/port/ios.py:
3610 (IOSSimulatorPort.check_sys_deps): Modified to call Simulator.check_simulator_device_and_erase_if_needed().
3611 Log a error and return False if we are unable to boot the simulator device so that the caller can take
3612 appropriate action, say exit(3) before running any layout tests.
3613 * Scripts/webkitpy/xcode/simulator.py:
3614 (Simulator._boot_and_shutdown_simulator_device): Added. Boot and then shut down the simulator device
3615 with the specified UDID.
3616 (Simulator.check_simulator_device_and_erase_if_needed): Added. Checks that simulator device
3617 with the specified UDID can successfully boot and shut down. We make at most two attempts to
3618 boot and shut down the device, erasing the device between tries so as to restore the device
3619 to a known good state.
3621 2015-02-17 Daniel Bates <dabates@apple.com>
3623 run_webkit_tests.py should not know about iOS Simulator details
3624 https://bugs.webkit.org/show_bug.cgi?id=141711
3626 Reviewed by Alex Christensen.
3628 Run_webkit_tests.py should only parse the iOS-specific command
3629 line options --runtime and --device-type. Let the port-specific
3630 logic in ios.py validate the parsed options and instantiate
3631 internal data structures.
3633 Currently run_webkit_tests.py parses the iOS-specific command
3634 line options --runtime and --device-type, validates them, and
3635 instantiates internal data structures from the parsed strings.
3636 Instead the validation logic and instantiation of internal
3637 data structures should be handled by the iOS port object.
3639 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3640 (_set_up_derived_options): Remove logic to validate --runtime and --device-type
3641 and instantiate internal data structures for them.
3642 * Scripts/webkitpy/port/driver.py:
3643 (IOSSimulatorDriver.cmd_line): Modified to reference IOSSimulatorPort.simulator_runtime
3644 and IOSSimulatorPort.simulator_device_type for the iOS Simulator runtime and device type,
3646 * Scripts/webkitpy/port/ios.py: Sort the list of imports.
3647 (IOSSimulatorPort.simulator_runtime): Added. Instantiates a Runtime
3648 object from --runtime, if specified. Otherwise, instantiates a Runtime
3649 object for the latest installed iphonesimulator SDK version.
3650 (IOSSimulatorPort.simulator_device_type): Added. Instantiates a DeviceType
3651 object from --device-type, if specified. Otherwise, instantiates
3652 a DeviceType object for a iPhone 5 or iPhone 5s when on a 32-bit and 64-bit
3653 machine, respectively.
3654 (IOSSimulatorPort.check_sys_deps): Added. Validate if the chosen iOS simulator
3655 runtime is available to use.
3656 (IOSSimulatorPort.testing_device): Modified to make use of properties simulator_device_type
3657 and simulator_runtime for the iOS Simulator device type and runtime, respectively.
3658 * Scripts/webkitpy/xcode/simulator.py:
3659 (Runtime.from_version_string): Added. Turns around and calls Runtime.from_identifier()
3660 with a runtime identifier for the specified iOS version.
3662 2015-02-17 Dana Burkart <dburkart@apple.com>
3664 ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack
3665 https://bugs.webkit.org/show_bug.cgi?id=141672
3667 Reviewed by David Kilzer.