[EFL][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalReso...
[WebKit-https.git] / Tools / ChangeLog
1 2012-06-07  Joshua Lock  <joshua.lock@intel.com>
2
3         [EFL][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
4         https://bugs.webkit.org/show_bug.cgi?id=67255
5
6         Reviewed by Dirk Pranke.
7
8         Implement pathToLocalResource to redirect file:///tmp URL's to
9         DUMPRENDERTREE_TEMP and file:///tmp/LayoutTests to point to the
10         LayoutTests sub-directory of the WebKit source tree.
11
12         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
13         (LayoutTestController::pathToLocalResource):
14
15 2012-06-07  Tony Payne  <tpayne@chromium.org>
16
17         [chromium] Allow LayoutTests under new git workflow
18         https://bugs.webkit.org/show_bug.cgi?id=88575
19
20         On Windows, chromium indirects through git.bat. Adds the same hack that
21         is currently used for discovering svn.bat to support the new git
22         workflow.
23
24         Reviewed by Dirk Pranke.
25
26         * Scripts/webkitpy/common/checkout/scm/git.py:
27         (Git): Replaces all hard-coded references to 'git' with the class
28         variable executable_name.
29         (Git._check_git_architecture):
30         (Git.in_working_directory):
31         (Git.find_checkout_root):
32         (Git.read_git_config):
33         (Git.discard_local_commits):
34         (Git.local_commits):
35         (Git.working_directory_is_clean):
36         (Git.clean_working_directory):
37         (Git.status_command):
38         (Git.add_list):
39         (Git.delete_list):
40         (Git.exists):
41         (Git._current_branch):
42         (Git.changed_files):
43         (Git._changes_files_for_commit):
44         (Git.revisions_changing_file):
45         (Git.conflicted_files):
46         (Git.svn_revision):
47         (Git.create_patch):
48         (Git._run_git_svn_find_rev):
49         (Git.contents_at_revision):
50         (Git.diff_for_file):
51         (Git.show_head):
52         (Git.committer_email_for_revision):
53         (Git.apply_reverse_diff):
54         (Git.revert_files):
55         (Git.commit_with_message):
56         (Git._commit_on_branch):
57         (Git.svn_commit_log):
58         (Git.last_svn_commit_log):
59         (Git.svn_blame):
60         (Git._branch_ref_exists):
61         (Git.delete_branch):
62         (Git.remote_merge_base):
63         (Git.commit_locally_with_message):
64         (Git.push_local_commits_to_server):
65         (Git.commit_ids_from_commitish_arguments):
66         (Git.commit_message_for_local_commit):
67         (Git.files_changed_summary_for_commit):
68         * Scripts/webkitpy/common/host.py:
69         (Host._engage_awesome_windows_hacks): Adds an awesome 'git.bat' hack
70         that duplicates the logic in the existing 'svn.bat' hack.
71
72 2012-06-07  Ojan Vafai  <ojan@chromium.org>
73
74         Style build architectures like build versions for non-layout test failures
75         https://bugs.webkit.org/show_bug.cgi?id=88590
76
77         Reviewed by Tony Chang.
78
79         Since we show the list of failing tests after the architecture, we want the
80         buildtype and architecture to be grouped together visually.
81
82         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
83         (.effects a.failing-builder>span.architecture):
84
85 2012-06-07  Xianzhu Wang  <wangxianzhu@chromium.org>
86
87         [Chromium] Remove header dependency of ImageDiff to WTF
88         https://bugs.webkit.org/show_bug.cgi?id=88422
89
90         Reviewed by Ryosuke Niwa.
91
92         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
93         * DumpRenderTree/chromium/ImageDiff.cpp:
94         (untestedCompareImages):
95
96 2012-06-07  Dongwoo Im  <dw.im@samsung.com>
97
98         [EFL] [DRT] DRT enables WebAudio when WebAudio feature is enabled.
99         https://bugs.webkit.org/show_bug.cgi?id=88491
100
101         Reviewed by Dirk Pranke.
102
103         DRT should enable WebAudio when WebAudio feature is enabled,
104         so that the WebAudio feature could be tested by the Layouttest.
105
106         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Enable WebAudio when WebAudio feature is enabled.
107         (LayoutTestController::overridePreference):
108
109 2012-06-07  Dirk Pranke  <dpranke@chromium.org>
110
111         webkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes for the failure in question
112         https://bugs.webkit.org/show_bug.cgi?id=88581
113
114         Reviewed by Ojan Vafai.
115
116         webkit-paptch rebaseline-expectations was ignoring what the
117         expected results for a test were and pulling down all the result
118         files from a bot. This could lead to us pulling down old,
119         incorrect .txt or .png files. With this patch we will now only
120         pull down expectations of the appropriate file types (so an
121         IMAGE failure will only pull the png and not the txt file).
122
123         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
124         (has_pixel_failures):
125         (suffixes_for_expectations):
126         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
127         (FunctionsTest.test_suffixes_for_expectations):
128         * Scripts/webkitpy/tool/commands/rebaseline.py:
129         (AbstractRebaseliningCommand.__init__):
130         (RebaselineExpectations._is_supported_port):
131         (RebaselineExpectations._update_expectations_file):
132         (RebaselineExpectations._tests_to_rebaseline):
133         (RebaselineExpectations._rebaseline_port):
134         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
135         (test_overrides_are_included_correctly):
136
137 2012-06-07  Ojan Vafai  <ojan@chromium.org>
138
139         Fix recent null pointer error regression in the flakiness dashboard
140         https://bugs.webkit.org/show_bug.cgi?id=88573
141
142         Reviewed by Dirk Pranke.
143
144         * TestResultServer/static-dashboards/builders.js:
145         (requestBuilderList):
146         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
147
148 2012-06-07  Konrad Piascik  <kpiascik@rim.com>
149
150         Add Konrad Piascik to committers.py
151         https://bugs.webkit.org/show_bug.cgi?id=88560
152
153         Unreviewed.
154
155         * Scripts/webkitpy/common/config/committers.py:
156
157 2012-06-07  Tony Chang  <tony@chromium.org>
158
159         [chromium] Win mock scrollbars appear to overflow by a pixel to the right and bottom
160         https://bugs.webkit.org/show_bug.cgi?id=77368
161
162         Reviewed by Ojan Vafai.
163
164         It doesn't look like we ever get a rect with width or height of 0.
165         I ran css1, css2.1, fast/forms, and tables without any crashes.
166
167         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
168         (webRectToSkIRect): Correctly convert a WebRect to a SkIRect.
169
170 2012-06-07  Dirk Pranke  <dpranke@chromium.org>
171
172         run-webkit-tests --lint-test-files gives an error when run on linux
173         https://bugs.webkit.org/show_bug.cgi?id=88551
174
175         Reviewed by Ojan Vafai.
176
177         We weren't mapping the expectations properly for the
178         google-chrome ports.
179
180         * Scripts/webkitpy/layout_tests/port/base.py:
181         (Port.path_to_test_expectations_file):
182         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
183         (TestGoogleChromePort.test_path_to_expectations):
184
185 2012-06-07  Daniel Erat  <derat@chromium.org>
186
187         [chromium] Add LayoutTestController::setTextSubpixelPositioning() for Linux.
188         https://bugs.webkit.org/show_bug.cgi?id=88263
189
190         Reviewed by Tony Chang.
191
192         * DumpRenderTree/chromium/LayoutTestController.cpp:
193         (LayoutTestController::LayoutTestController):
194         (LayoutTestController::reset):
195         (LayoutTestController::setTextSubpixelPositioning):
196         * DumpRenderTree/chromium/LayoutTestController.h:
197         (LayoutTestController):
198         * DumpRenderTree/chromium/fonts.conf:
199
200 2012-06-07  Zan Dobersek  <zandobersek@gmail.com>
201
202         [Gtk] Assertions in gtk_widget_draw when acquiring pixel output
203         https://bugs.webkit.org/show_bug.cgi?id=88060
204
205         Reviewed by Martin Robinson.
206
207         Spin the main loop before acquiring the pixel content. This ensures things
208         like late size allocations are finished before calling gtk_widget_draw,
209         avoiding assertions and subsequent empty pixel results.
210
211         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
212         (createBitmapContextFromWebView):
213
214 2012-06-06  Kenneth Rohde Christiansen  <kenneth@webkit.org>
215
216         [Qt] Improve the visual of the viewport info box
217         https://bugs.webkit.org/show_bug.cgi?id=88410
218
219         Reviewed by Tor Arne Vestbø.
220
221         Improve the visual and make it possible to see the content more easy.
222
223         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
224
225 2012-06-06  Mariusz Grzegorczyk  <mariusz.g@samsung.com>
226
227         [EFL][WK2] Compile webkit1 and webkit2 by default.
228         https://bugs.webkit.org/show_bug.cgi?id=85041
229
230         Reviewed by Chang Shu.
231
232         Compile webkit1 and webkit2 while running Tools/Scripts/build-webkit --efl.
233         Webkit2 build can be skipped by adding --no-webkit2 option to build-webkit script.
234
235         * Scripts/build-webkit:
236
237 2012-06-06  Sheriff Bot  <webkit.review.bot@gmail.com>
238
239         Unreviewed, rolling out r119662.
240         http://trac.webkit.org/changeset/119662
241         https://bugs.webkit.org/show_bug.cgi?id=88487
242
243         Broke builds (Requested by rniwa on #webkit).
244
245         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
246         * DumpRenderTree/chromium/ImageDiff.cpp:
247         (untestedCompareImages):
248
249 2012-06-06  Xianzhu Wang  <wangxianzhu@chromium.org>
250
251         [Chromium] Remove header dependency of ImageDiff to WTF
252         https://bugs.webkit.org/show_bug.cgi?id=88422
253
254         Reviewed by Adam Barth.
255
256         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
257         * DumpRenderTree/chromium/ImageDiff.cpp:
258         (untestedCompareImages):
259
260 2012-06-06  Amy Ousterhout  <aousterh@chromium.org>
261
262         [WebKit] DeviceOrientation cleanup
263         https://bugs.webkit.org/show_bug.cgi?id=88406
264
265         Reviewed by Kent Tamura.
266
267         Updated LayoutTestController to use new public default constructor in WebDeviceOrientation.h.
268
269         * DumpRenderTree/chromium/LayoutTestController.cpp:
270         (LayoutTestController::setMockDeviceOrientation):
271
272 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
273
274         webkitpy: add support for an ordered dict of test expectations
275         https://bugs.webkit.org/show_bug.cgi?id=87802
276
277         Reviewed by Ojan Vafai.
278
279         As per https://bugs.webkit.org/show_bug.cgi?id=65834 we want to
280         support a cascaded list of test expectations files. An easy way
281         to think of this is as an ordered dictionary of name -> contents
282         for files, where the name is usually a path on disk (I say
283         usually because we want to support other kinds of expectations
284         like the compile-time skips for unsupported features in
285         webkit.py, and we want to continue to support "in-memory" test
286         expectations that don't require a filesystem).
287
288         Conveniently there is an OrderedDict implementation in Python
289         2.7+ and it is available as a backport, so the first step in
290         adding this support is to use that implementation. Subsequent
291         patches will update the test_expectations.py module (and other
292         callers) to access the dict directly.
293
294         This patch just changes the base internal implementation and
295         provides wrappers for compatibility. The derived ports
296         (WebKitPort, TestPort, etc.) still need to be updated.
297
298         * Scripts/webkitpy/layout_tests/port/base.py:
299         (Port._expectations_dict):
300         (Port.test_expectations):
301         (Port):
302         (Port._expectations_overrides_dict):
303         (Port.test_expectations_overrides):
304         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
305         (PortTestCase.test_expectations_ordering):
306         (PortTestCase):
307         (PortTestCase.test_expectations_overrides_ordering):
308         * Scripts/webkitpy/thirdparty/ordered_dict.py: Added.
309         (OrderedDict):
310         (OrderedDict.__init__):
311         (OrderedDict.clear):
312         (OrderedDict.__setitem__):
313         (OrderedDict.__delitem__):
314         (OrderedDict.__iter__):
315         (OrderedDict.__reversed__):
316         (OrderedDict.popitem):
317         (OrderedDict.__reduce__):
318         (OrderedDict.__repr__):
319         (OrderedDict.copy):
320         (OrderedDict.fromkeys):
321
322 2012-06-06  Mario Sanchez Prada  <msanchez@igalia.com>
323
324         Unreviewed gardening. Unit test fails on GTK 64bit debug bot.
325
326         * gtk/run-api-tests:
327         (TestRunner): Skip TestWebKitAPI/WTF/TestHashMap.
328
329 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
330
331         nrwt should look in 'out' for binaries on chromium win to support ninja
332         https://bugs.webkit.org/show_bug.cgi?id=88273
333
334         Reviewed by Tony Chang.
335
336         This patch standardizes the search algorithm the chromium ports
337         use to figure out which driver to run. We will look in a
338         chromium location before a webkit location (e.g., in
339         Source/WebKit/chromium/out before out/) and we will look in the
340         "legacy" directory (xcodebuild) before the directory ninja uses
341         (out).
342
343         Unfortunately due to the way the test code is set up testing the
344         properly requires some duplication of test code. I will fix that
345         in a followup patch.
346
347         * Scripts/webkitpy/layout_tests/port/chromium.py:
348         (ChromiumPort):
349         (ChromiumPort._static_build_path):
350         (ChromiumPort._build_path):
351         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
352         (ChromiumLinuxPort):
353         (ChromiumLinuxPort._determine_driver_path_statically):
354         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
355         (ChromiumLinuxPortTest.test_build_path):
356         (ChromiumLinuxPortTest):
357         (ChromiumLinuxPortTest.test_driver_name_option):
358         (ChromiumLinuxPortTest.path_to_image_diff):
359         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
360         (ChromiumMacPort):
361         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
362         (ChromiumMacPortTest.test_build_path):
363         (ChromiumMacPortTest):
364         (ChromiumMacPortTest.test_driver_name_option):
365         (ChromiumMacPortTest.path_to_image_diff):
366         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
367         (ChromiumPortTest.test_overrides_and_builder_names):
368         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
369         (ChromiumWinPort):
370         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
371         (ChromiumWinTest.test_build_path):
372         (ChromiumWinTest.test_operating_system):
373         (ChromiumWinTest):
374         (ChromiumWinTest.test_driver_name_option):
375         (ChromiumWinPortTest.path_to_image_diff):
376         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
377         (PortTestCase.assert_build_path):
378
379 2012-06-06  Jessie Berlin  <jberlin@apple.com>
380
381         Remove very red Windows WebKit2 testers
382         https://bugs.webkit.org/show_bug.cgi?id=88452
383
384         Reviewed by Steve Falkenburg.
385
386         Remove the Windows 7 Release WK2 testers so that the hardware can be repurposed. We are
387         need to focus on getting the WK1 testers green.
388
389         * BuildSlaveSupport/build.webkit.org-config/config.json:
390
391 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
392
393         get rebaselining tools to kinda work with the skia overrides file
394         https://bugs.webkit.org/show_bug.cgi?id=88456
395
396         Reviewed by Ryosuke Niwa.
397
398         Update rebaseline-expectations so that we read in the overrides
399         when looking for tests to rebaseline, but don't read in the
400         overrides when we are writing the expectations file back out.
401         This prevents the overrides from getting written into the main
402         file. This is kind of a hack but will have to do until we
403         support multiple expectations files properly.
404
405         * Scripts/webkitpy/tool/commands/rebaseline.py:
406         (RebaselineExpectations._expectations):
407         (RebaselineExpectations._update_expectations_file):
408         (RebaselineExpectations._tests_to_rebaseline):
409         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
410         (test_overrides_are_included_correctly):
411
412 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
413
414         webkitpy: two manager_worker_broker_unittest tests are broken
415         https://bugs.webkit.org/show_bug.cgi?id=88445
416
417         Reviewed by Ojan Vafai.
418
419         These tests were never updated when we removed the
420         --worker-model argument, and we were passing 'inline' instead of
421         1 (for the number of workers) :(. As a result we were creating
422         multiprocessing queues unnecessarily and that was failing on cygwin.
423
424         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
425         (InterfaceTest.test_managerconnection_is_abstract):
426         (InterfaceTest.test_workerconnection_is_abstract):
427
428 2012-06-06  Ryosuke Niwa  <rniwa@webkit.org>
429
430         REGRESSION(r117789): "webkit-patch rebaseline-expectations" copies contents in skia_test_expectations.txt into test_expectations.txt
431         https://bugs.webkit.org/show_bug.cgi?id=87406
432
433         Reviewed by Dirk Pranke.
434
435         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
436         (TestExpectations.__init__):
437         * Scripts/webkitpy/tool/commands/rebaseline.py:
438         (RebaselineTest._update_expectations_file):
439         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
440         (test_rebaseline_does_not_include_overrides):
441
442 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
443
444         webkitpy: perf tests unit tests fail on chromium win
445         https://bugs.webkit.org/show_bug.cgi?id=88279
446
447         Reviewed by Ryosuke Niwa.
448
449         I'm seeing weird failures running the unit tests in my win32
450         checkout, and we don't really expect webpagereplay to work on
451         win32 anyway, so I'm skipping the import of that module for now
452         and adding a warning.
453
454         * Scripts/run-perf-tests:
455         * Scripts/webkitpy/performance_tests/perftest.py:
456
457 2012-06-06  Yong Li <yoli@rim.com>
458
459         Unreviewed. Update my email address in committers.py.
460
461         * Scripts/webkitpy/common/config/committers.py:
462
463 2012-06-06  Robert Kroeger  <rjkroege@chromium.org>
464
465         Add Robert Kroeger  to commiters.py
466         https://bugs.webkit.org/show_bug.cgi?id=88415
467
468         Unreviewed.
469
470         * Scripts/webkitpy/common/config/committers.py:
471
472 2012-06-06  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
473
474         [EFL][DRT] http/tests/globalhistory testcases do not pass
475         https://bugs.webkit.org/show_bug.cgi?id=82579
476
477         Reviewed by Csaba Osztrogonác.
478
479         DRT has provided callbacks for ewk_view "global history delegate" signals.
480
481         * DumpRenderTree/efl/DumpRenderTree.cpp:
482         (isGlobalHistoryTest): Aux function to ident global history testcase.
483         (createLayoutTestController):
484         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
485         (DumpRenderTreeChrome::createView):
486         (DumpRenderTreeChrome::onTitleChanged): Handles also some global history testcases.
487         (DumpRenderTreeChrome::onWebViewNavigatedWithData): New callback function.
488         (DumpRenderTreeChrome::onWebViewServerRedirect): Ditto.
489         (DumpRenderTreeChrome::onWebViewClientRedirect): Ditto.
490         (DumpRenderTreeChrome::onWebViewPopulateVisitedLinks): Ditto.
491         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
492         (DumpRenderTreeChrome):
493
494 2012-06-06  János Badics  <jbadics@inf.u-szeged.hu>
495
496         [Qt] run-qtwebkit-tests hangs with -j1
497         run-qtwebkit-tests used to hang when wk2 API tests were run with -j1 and --timeout.
498         This could happen due to an uncancelled timer after results were returned. This timer was
499         started only if --timeout was set.
500         https://bugs.webkit.org/show_bug.cgi?id=85475
501
502         Reviewed by Csaba Osztrogonác.
503
504         * Scripts/run-qtwebkit-tests:
505         (run_test):
506
507 2012-06-06  Michael Brüning  <michael.bruning@nokia.com>
508
509         [Qt][WK2] Add preferredMinimumContentsWidth to the viewport info in MiniBrowser.
510         https://bugs.webkit.org/show_bug.cgi?id=88327
511
512         Reviewed by Kenneth Rohde Christiansen.
513
514         * MiniBrowser/qt/MiniBrowser.qrc: Added contents_width.png.
515         * MiniBrowser/qt/icons/contents_width.png: Added.
516         * MiniBrowser/qt/qml/BrowserWindow.qml: Added button for toggling preferredMinimumContentsWidth.
517         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Added display of preferredMinimumContentsWidth.
518
519 2012-06-05  Jon Lee  <jonlee@apple.com>
520
521         Buildbot fix.
522
523         * BuildSlaveSupport/build.webkit.org-config/master.cfg: We lose the type attribute earlier
524         in the function. Store in a local variable.
525         (loadBuilderConfig):
526
527 2012-06-05  Jon Lee  <jonlee@apple.com>
528
529         Buildbot fix.
530
531         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
532         (loadBuilderConfig):
533
534 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
535
536         webkitpy: clean up win-specific path handling and tests
537         https://bugs.webkit.org/show_bug.cgi?id=88281
538
539         Reviewed by Adam Barth.
540
541         There was a bunch of inconsistent logic for handling path
542         conversions for win32 and cygwin paths due to us sometimes
543         looking at sys.platform and sometimes using mock hosts. This
544         patch cleans everything up so that we are required to pass
545         PlatformInfo objects to the path module and stop trying to do
546         different things when running on cygwin or win32 hosts (except
547         in the path_unittest module itself).
548
549         This may slightly reduce test coverage for the win32 code paths
550         but will be a lot easier to follow and maintain.
551
552         * Scripts/webkitpy/common/system/path.py:
553         (abspath_to_uri):
554         (_convert_path):
555         * Scripts/webkitpy/common/system/path_unittest.py:
556         (AbspathTest.platforminfo):
557         (AbspathTest.test_abspath_to_uri_cygwin):
558         (AbspathTest.test_abspath_to_uri_unixy):
559         (AbspathTest.test_abspath_to_uri_win):
560         (AbspathTest.test_abspath_to_uri_escaping_unixy):
561         (AbspathTest.test_abspath_to_uri_escaping_cygwin):
562         (AbspathTest.test_stop_cygpath_subprocess):
563         * Scripts/webkitpy/common/system/platforminfo.py:
564         (PlatformInfo.__init__):
565         (PlatformInfo.is_cygwin):
566         * Scripts/webkitpy/common/system/platforminfo_mock.py:
567         (MockPlatformInfo.is_cygwin):
568         * Scripts/webkitpy/layout_tests/port/base.py:
569         (Port.to.show_results_html_file):
570         * Scripts/webkitpy/layout_tests/port/driver.py:
571         (Driver.test_to_uri):
572         (Driver.uri_to_test):
573         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
574         (DriverTest.test_test_to_uri):
575         (DriverTest.test_uri_to_test):
576         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
577         (MockDRTPortTest.make_port):
578         (MockDRTTest.input_line):
579         (MockChromiumDRTTest.test_pixeltest__fails):
580         * Scripts/webkitpy/layout_tests/port/test.py:
581         * Scripts/webkitpy/layout_tests/port/win.py:
582         (WinPort.show_results_html_file):
583         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
584         (MainTest.test_unexpected_failures):
585         (MainTest.test_results_directory_absolute):
586         (MainTest.test_results_directory_default):
587         (MainTest.test_results_directory_relative):
588
589 2012-06-05  Jon Lee  <jonlee@apple.com>
590
591         Workaround buildbot bug when merging build requests.
592         https://bugs.webkit.org/show_bug.cgi?id=88158
593
594         Reviewed by Mark Rowe.
595
596         For expediency, we still want testers to pick the latest build to test, but to ensure
597         that the builders are reporting the correct revision number, we should let the building bots
598         run as they normally would. That is, the builder picks the oldest revision, and merges
599         subsequent requests. Because merged requests get appended to the list of changes for a given
600         build, the last change in that list is also the latest change. When we used pickLatestBuild
601         for the builders, this was not the case (it would always report the penultimate change).
602
603         http://trac.buildbot.net/ticket/2309 is tracking the buildbot bug.
604
605         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove the mergeRequests override
606         for all Apple builders.
607         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Have only non-building bots pick
608         the latest build to run.
609         (loadBuilderConfig):
610
611 2012-06-05  Jessie Berlin  <jberlin@apple.com>
612
613         [Win] DumpRenderTree should call resetInternalsObject
614         https://bugs.webkit.org/show_bug.cgi?id=88346
615
616         Reviewed by Simon Fraser.
617
618         Invoke it on Windows in the same place it is invoked on Mac.
619
620         * DumpRenderTree/win/DumpRenderTree.cpp:
621         (resetWebViewToConsistentStateBeforeTesting):
622
623 2012-06-05  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
624
625         [GTK] Fix two more memory leaks in DRT
626         https://bugs.webkit.org/show_bug.cgi?id=88255
627
628         Reviewed by Martin Robinson.
629
630         Fixed memory leaks in GTK's DRT code.
631
632         * DumpRenderTree/gtk/DumpRenderTree.cpp:
633         (dumpHistoryItem): webkit_web_history_item_get_target() returns a
634         g_strdup()'d string. So, use GOwnPtr to manage memory automatically.
635         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
636         (createBitmapContextFromWebView): Free the cairo surface.
637
638 2012-06-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
639
640         [Qt] Building when a top directory is named Source
641         https://bugs.webkit.org/show_bug.cgi?id=77727
642
643         Reviewed by Tor Arne Vestbø.
644
645         Change regex to only replace the last instance of OUT_PWD.
646
647         * qmake/mkspecs/features/default_pre.prf:
648
649 2012-06-05  Dongwoo Im  <dw.im@samsung.com>
650
651         Add 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'.
652         https://bugs.webkit.org/show_bug.cgi?id=73176
653
654         Reviewed by Adam Barth.
655
656         Two more APIs are added in Custom Scheme Handler specification.
657         http://dev.w3.org/html5/spec/Overview.html#custom-handlers
658         One is 'isProtocolHandlerRegistered' to query whether the specific URL
659         is registered or not.
660         The other is 'unregisterProtocolHandler' to remove the registered URL.
661
662         * Scripts/webkitperl/FeatureList.pm: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
663
664 2012-06-05  Mario Sanchez Prada  <msanchez@igalia.com>
665
666         [GTK][WK2] Implement API for Geolocation permission requests in the GTK port
667         https://bugs.webkit.org/show_bug.cgi?id=83879
668
669         Reviewed by Carlos Garcia Campos.
670
671         Make minibrowser connect to the new 'permission requests' signal
672         to allow users handle the Geolocation permission requests.
673
674         * MiniBrowser/gtk/BrowserWindow.c:
675         (geolocationRequestDialogCallback): Callback for the dialog asking
676         the user for allowing or not geolocation permission requests.
677         (webViewDecidePermissionRequest): Launch a dialog to ask the user
678         whether to allow or deny geolocation permission requests.
679         (browserWindowConstructed): Connect to 'permission-request' signal.
680
681 2012-06-04  Chase Phillips  <cmp@google.com>
682
683         Make a builder group support+expect multiple loads.
684         https://bugs.webkit.org/show_bug.cgi?id=88260
685
686         Change BuilderGroup to allow expecting multiple
687         loads.  This allows merging results for a given set
688         of builders into one group.
689
690         Add a test that verifies that the group count
691         increments correctly based on successful and failed
692         list loads.
693
694         Reviewed by Ojan Vafai.
695
696         * TestResultServer/static-dashboards/builders.js:
697         (BuilderGroup):
698         (BuilderGroup.prototype.setbuilder):
699         (BuilderGroup.prototype.append):
700         (BuilderGroup.prototype.loaded):
701         (requestBuilderList.xhr.onload):
702         (requestBuilderList.xhr.onerror):
703         (onErrorLoadingBuilderList):
704         (loadBuildersList):
705         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
706         (test):
707         * TestResultServer/static-dashboards/run-unittests.html:
708
709 2012-06-04  Ryosuke Niwa  <rniwa@webkit.org>
710
711         Python test fix attempt for Chromium Windows.
712
713         * Scripts/webkitpy/layout_tests/port/driver.py:
714         (Driver.uri_to_test):
715
716 2012-06-04  Hugo Parente Lima  <hugo.lima@openbossa.org>
717
718         Turn LEGACY_VIEWPORT_ADAPTION USE flag into an ENABLE flag.
719         https://bugs.webkit.org/show_bug.cgi?id=88243
720
721         Reviewed by Adam Barth.
722
723         * qmake/mkspecs/features/features.prf:
724
725 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
726
727         webkitpy.layout_tests.port.server_process_unittest.TestServerProcess.test_basic is flaky
728         https://bugs.webkit.org/show_bug.cgi?id=88280
729
730         Unreviewed, build fix.
731
732         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
733         (TestServerProcess.test_basic):
734
735 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
736
737         test-webkitpy is hanging under cygwin
738         https://bugs.webkit.org/show_bug.cgi?id=88269
739
740         Reviewed by Ryosuke Niwa.
741
742         The 'multiprocessing' module doesn't work correctly under Cygwin yet,
743         so we need to skip any tests that use it.
744
745         * Scripts/webkitpy/common/system/executive.py:
746         (Executive.run_in_parallel):
747         * Scripts/webkitpy/common/system/executive_unittest.py:
748         (ExecutiveTest.test_run_in_parallel):
749
750 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
751
752         test-webkitpy is failing on win32 after r115054
753         https://bugs.webkit.org/show_bug.cgi?id=88264
754
755         Reviewed by Ryosuke Niwa.
756
757         The failing http_server test was improperly suppressed (the
758         tuple was missing a comma, and so wasn't a tuple at all, just a
759         string) and so we were skipping *all* tests on win32. The right
760         way to skip a single test is to disable it inside the test
761         itself.
762
763         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
764         (TestHttpServer.test_start_cmd):
765         * Scripts/webkitpy/test/test_finder.py:
766         (TestFinder._default_names):
767         * Scripts/webkitpy/test/main.py:
768         (Tester.run): Add error message if we don't find any tests to run.
769         * Scripts/webkitpy/test/main_unittest.py:
770             
771
772 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
773
774         [GTK] Memory leaks in AccessibilityUIElementGtk.cpp
775         https://bugs.webkit.org/show_bug.cgi?id=88215
776
777         Reviewed by Martin Robinson.
778
779         Fixed memory leaks in AccessibilityUIElement by using GOwnPtr
780         for newly allocated strings.
781
782         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
783         (attributeSetToString):
784         (AccessibilityUIElement::allAttributes):
785
786 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
787
788         [GTK] Memory leaks in DumpRenderTree.cpp
789         https://bugs.webkit.org/show_bug.cgi?id=88213
790
791         Reviewed by Martin Robinson.
792
793         Fixed memory leaks in DumpRenderTree.
794
795         * DumpRenderTree/gtk/DumpRenderTree.cpp:
796         (appendString): Accepts const gchar* as the second argument.
797         (dumpFramesAsText): Free the string returned by g_strdup_printf().
798         (dumpHistoryItem): Free the string returned by g_uri_parse_scheme().
799
800 2012-06-04  David Dorwin  <ddorwin@chromium.org>
801
802         Enable Chromium media player to instantiate a plugin
803         https://bugs.webkit.org/show_bug.cgi?id=87399
804
805         Reviewed by Kent Tamura.
806
807         Adds WebHelperPlugin, an off-screen widget that contains an <object> tag.
808
809         * DumpRenderTree/chromium/WebViewHost.cpp:
810         (WebViewHost::createPopupMenu):
811
812 2012-06-04  Mario Sanchez Prada  <msanchez@igalia.com>
813
814         [GTK][WK2] Implement geolocation provider for the GTK port
815         https://bugs.webkit.org/show_bug.cgi?id=83877
816
817         Reviewed by Carlos Garcia Campos.
818
819         * gtk/generate-gtkdoc:
820         (get_webkit2_options): Ignore WebKitGeolocationProvider files.
821
822 2012-06-04  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
823
824         [EFL] Reset "WebKitTabToLinksPreferenceKey" in DumpRenderTreeChrome::resetDefaultsToConsistentValues
825         https://bugs.webkit.org/show_bug.cgi?id=87668
826
827         Reviewed by Ryosuke Niwa.
828
829         Layout test controller "WebKitTabToLinksPreferenceKey" setting should be reset to false
830         otherwise LayoutTests/fast/html/tab-order.html is failing as it has a link inside the test description which might 
831         be included in focus chain (if "WebKitTabToLinksPreferenceKey" setting is set to true). 
832
833         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
834         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
835
836 2012-06-04  Tomasz Morawski  <t.morawski@samsung.com>
837
838         [EFL] Refactor ewk_view_context_paint code.
839         https://bugs.webkit.org/show_bug.cgi?id=85588
840
841         Reviewed by Hajime Morita.
842
843         * DumpRenderTree/efl/CMakeLists.txt: Added include directory.
844
845 2012-06-04  Christophe Dumez  <christophe.dumez@intel.com>
846
847         [EFL] Compilation warning in DumpRenderTreeView.cpp on 64-Bit
848         https://bugs.webkit.org/show_bug.cgi?id=87869
849
850         Reviewed by Andreas Kling.
851
852         Replace %lld by PRId64 macro to print an int64_t value and silent a
853         compilation warning on 64-Bit.
854
855         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
856         (onExceededApplicationCacheQuota):
857
858 2012-06-03  Varun Jain  <varunjain@google.com>
859
860         [chromium] Add new gesture type (two finger tap) that triggers context menu.
861         https://bugs.webkit.org/show_bug.cgi?id=88173
862
863         Reviewed by Adam Barth.
864
865         * DumpRenderTree/chromium/EventSender.cpp:
866         (EventSender::EventSender):
867         (EventSender::gestureTwoFingerTap):
868         (EventSender::gestureEvent):
869         * DumpRenderTree/chromium/EventSender.h:
870         (EventSender):
871
872 2012-06-02  Zeno Albisser  <zeno@webkit.org>
873
874         Fix and enable WebGL for WebKit2 on Qt.
875         https://bugs.webkit.org/show_bug.cgi?id=86214
876
877         Enable WebGL by default for Qt MiniBrowser.
878
879         Reviewed by Noam Rosenthal.
880
881         * MiniBrowser/qt/qml/BrowserWindow.qml:
882
883 2012-06-02  Ryosuke Niwa  <rniwa@webkit.org>
884
885         Teach svn-apply how to apply changes in test_expectations.txt to TestExpectations
886         https://bugs.webkit.org/show_bug.cgi?id=88164
887
888         Reviewed by Kentaro Hara.
889
890         Just like r74856, adjust git/svn headers from test_expectations.txt to TestExpectations.
891         Also replace all occurrences of /test_expectations.txt: by /TestExpectations: in change log entries.
892
893         * Scripts/VCSUtils.pm:
894         (adjustPathForRecentRenamings):
895         (fixChangeLogPatch):
896
897 2012-06-01  Ryosuke Niwa  <rniwa@webkit.org>
898
899         Rename test_expectations.txt to TestExpectations
900         https://bugs.webkit.org/show_bug.cgi?id=86690
901
902         Reviewed by Dirk Pranke.
903
904         Make webkitpy aware of both test_expectations.txt and TestExpectations while we rename files.
905         We can the code to read test_expectations.txt once we've successfully transitioned.
906
907         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
908         (TestExpectationParser._check_path_does_not_exist):
909         (TestExpectationParser._tokenize):
910         (TestExpectations): Removed TEST_LIST, which is not used anywhere.
911         * Scripts/webkitpy/layout_tests/port/base.py:
912         (Port.path_to_test_expectations_file): Moved from WebKitPort and ChromiumPort. Returns the path to
913         test_expectations.txt if one exists and the path to TestExpectations otherwise.
914         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
915         (PortTest.test_virtual_methods): path_to_test_expectations_file and test_expectations are no longer
916         virtual.
917         * Scripts/webkitpy/layout_tests/port/chromium.py:
918         (ChromiumPort.path_from_chromium_base):
919         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
920         (ChromiumAndroidPort.test_expectations):
921         * Scripts/webkitpy/layout_tests/port/test.py:
922         (add_unit_tests_to_mock_filesystem): Use TestExpectations instead of test_expectations.txt.
923         (TestPort.__init__):
924         * Scripts/webkitpy/layout_tests/port/webkit.py:
925         (WebKitPort.baseline_search_path):
926         (WebKitPort.test_expectations):
927         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added some test cases. We should move these
928         tests to base as a follow up.
929         (WebKitPortTest.test_path_to_test_expectations_file):
930         (test_test_expectations):
931         (test_legacy_test_expectations):
932         * Scripts/webkitpy/style/checker.py:
933         (CheckerDispatcher.should_skip_without_warning): Replace the check for legacy drt_expectations.txt
934         with one for TestExpectations.
935         * Scripts/webkitpy/style/checkers/test_expectations.py:
936         (TestExpectationsChecker): Accept both test_expectations.txt and TestExpectations in warning outputs.
937         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
938         (TestExpectationsTestCase._expect_port_for_expectations_path): Test both TestExpectations and
939         test_expectations.txt.
940         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
941         (TestExpectationsTestCase.assert_lines_lint):
942         * Scripts/webkitpy/tool/commands/queries.py:
943         (PrintExpectations.__init__):
944         * Scripts/webkitpy/tool/commands/rebaseline.py:
945         (RebaselineExpectations):
946         * Scripts/webkitpy/tool/steps/commit.py:
947         (Commit._check_test_expectations):
948         * Scripts/webkitpy/tool/steps/commit_unittest.py:
949         (CommitTest._test_check_test_expectations): Extracted from test_check_test_expectations.
950         (CommitTest.test_check_test_expectations): For TestExpectations.
951         (CommitTest.test_check_legacy_test_expectations): For test_expectations.txt
952         * TestResultServer/static-dashboards/dashboard_base.js:
953         (requestExpectationsFile): Look for TestExpectations first, and fallback to test_expectations.txt.
954         Error only when neither exists.
955         * TestResultServer/static-dashboards/flakiness_dashboard.js:
956         (processMissingAndExtraExpectations):
957         (htmlForTestsWithExpectationsButNoFailures):
958         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
959
960 2012-06-01  Xianzhu Wang  <wangxianzhu@chromium.org>
961
962         Remove dependency from ImageDiff to WTF
963         https://bugs.webkit.org/show_bug.cgi?id=88147
964
965         Reviewed by Adam Barth.
966
967         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
968
969 2012-06-01  Dirk Pranke  <dpranke@chromium.org>
970
971         NRWT seems to leak (more?) temp dirs
972         https://bugs.webkit.org/show_bug.cgi?id=88126
973
974         Re-land r119297 with chromium fix (weren't calling the
975         super() method if not in --test-shell mode in start().
976         Add unit tests to chromium_unittest as well to check.
977
978         * Scripts/webkitpy/layout_tests/port/chromium.py:
979         (ChromiumDriver.start):
980         * Scripts/webkitpy/layout_tests/port/webkit.py:
981         (WebKitDriver.__del__):
982         (WebKitDriver._start):
983         (WebKitDriver.run_test):
984         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
985         (WebKitDriverTest.test_check_for_driver_crash):
986         (WebKitDriverTest.test_stop_cleans_up_properly):
987         (WebKitDriverTest):
988         (WebKitDriverTest.test_two_starts_cleans_up_properly):
989         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
990         (ChromiumDriverTest.test_stop_cleans_up_properly):
991         (ChromiumDriverTest.test_two_starts_cleans_up_properly):
992
993 2012-06-01  Tim Horton  <timothy_horton@apple.com>
994
995         Lots of "failed download-built-product" on Apple bots
996         https://bugs.webkit.org/show_bug.cgi?id=88158
997
998         Reviewed by Jessie Berlin.
999         
1000         Disable mergeRequests on all Apple builders. This is a speculative fix.
1001
1002         * BuildSlaveSupport/build.webkit.org-config/config.json:
1003
1004 2012-06-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1005
1006         Unreviewed, rolling out r119297.
1007         http://trac.webkit.org/changeset/119297
1008         https://bugs.webkit.org/show_bug.cgi?id=88156
1009
1010         May have broken Chromium bots (Requested by rniwa on #webkit).
1011
1012         * Scripts/webkitpy/layout_tests/port/webkit.py:
1013         (WebKitDriver.__del__):
1014         (WebKitDriver.run_test):
1015         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1016         (WebKitDriverTest.test_check_for_driver_crash):
1017         (WebKitDriverTest.test_stop_cleans_up_properly):
1018
1019 2012-06-01  Dirk Pranke  <dpranke@chromium.org>
1020
1021         nrwt seems to leak tmpdirs
1022         https://bugs.webkit.org/show_bug.cgi?id=88126
1023
1024         Reviewed by Ojan Vafai.
1025
1026         Fix leak possibly introduced in r118979 - we now will
1027         make sure we clean up any stale temp directories during the
1028         start routine and attempt to clean up again in __del__. It
1029         turns out that asserting in __del__ logs a message but is
1030         caught by the runtime, so it's mostly useless.
1031
1032         * Scripts/webkitpy/layout_tests/port/webkit.py:
1033         (WebKitDriver.__del__):
1034         (WebKitDriver._start):
1035         (WebKitDriver.run_test):
1036         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1037         (WebKitDriverTest.test_check_for_driver_crash):
1038         (WebKitDriverTest.test_stop_cleans_up_properly):
1039         (WebKitDriverTest):
1040         (WebKitDriverTest.test_two_starts_cleans_up_properly):
1041
1042 2012-06-01  Michael Saboff  <msaboff@apple.com>
1043
1044         WebFrame::_stringByEvaluatingJavaScriptFromString methods don't handle nil string
1045         https://bugs.webkit.org/show_bug.cgi?id=88109
1046
1047         Reviewed by Geoffrey Garen.
1048
1049         Additional test case.
1050
1051         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
1052         (TestWebKitAPI::TEST):
1053
1054 2012-06-01  Simon Hausmann  <simon.hausmann@nokia.com>
1055
1056         [Qt] Use -Werror only in developer builds
1057
1058         Rubber-stamped by Tor Arne Vestbø.
1059
1060         In production builds -Werror with custom toolchains and wierd system
1061         headers, -Werror is of no use and just creates confusion. So use it
1062         only if Qt is configured with -developer-build.
1063
1064         * qmake/mkspecs/features/default_pre.prf: Move qt_developer_build determination here...
1065         * qmake/mkspecs/features/unix/default_post.prf: ... so that we can use it here to do -Werror
1066         only if qt_developer_build is set.
1067
1068 2012-06-01  Jochen Eisinger  <jochen@chromium.org>
1069
1070         [watchlist] Add myself to loader and v8 bindings changes
1071         https://bugs.webkit.org/show_bug.cgi?id=88112
1072
1073         Reviewed by Adam Barth.
1074
1075         * Scripts/webkitpy/common/config/watchlist:
1076
1077 2012-06-01  Jacky Jiang  <zhajiang@rim.com>
1078
1079         Adding Jacky Jiang to committers.py
1080         https://bugs.webkit.org/show_bug.cgi?id=88122
1081
1082         Reviewed by Rob Buis.
1083
1084         Adding myself to committers.py as a Committer.
1085
1086         * Scripts/webkitpy/common/config/committers.py:
1087
1088 2012-06-01  Jessie Berlin  <jberlin@apple.com>
1089
1090         Fix Windows build.
1091
1092         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
1093
1094 2012-06-01  Jessie Berlin  <jberlin@apple.com>
1095
1096         Windows WK2 MouseMoveAfterCrash API test failing
1097         https://bugs.webkit.org/show_bug.cgi?id=69982
1098
1099         Disable the test on Windows to get the bots greener.
1100
1101         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
1102         (TestWebKitAPI::TEST):
1103
1104 2012-06-01  Christophe Dumez  <christophe.dumez@intel.com>
1105
1106         [EFL] EFL port does not enable WEB_INTENTS_TAG flag
1107         https://bugs.webkit.org/show_bug.cgi?id=86866
1108
1109         Reviewed by Adam Barth.
1110
1111         Catch new "intent,service,register" signal on the frame and print out
1112         information about the Web Intent service in EFL's DumpRenderTree.
1113
1114         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1115         (DumpRenderTreeChrome::createView):
1116         (DumpRenderTreeChrome::onFrameCreated):
1117         (DumpRenderTreeChrome::onFrameIntentServiceRegistration):
1118         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1119         (DumpRenderTreeChrome):
1120
1121 2012-06-01  Martin Robinson  <mrobinson@igalia.com>
1122
1123         The ChangeLog parser cannot handle reviewers with initials in their name
1124         https://bugs.webkit.org/show_bug.cgi?id=87864
1125
1126         Reviewed by Ryosuke Niwa.
1127
1128         Add support in the ChangeLog parser for reviewer names that have
1129         initials in them.
1130
1131         * Scripts/webkitpy/common/checkout/changelog.py:
1132         (ChangeLogEntry): Add a new group of regular expressions that need a backreference
1133         in the replacement string. This allows for matching the word characters before a
1134         period, without totally throwing them away.
1135         (ChangeLogEntry._parse_reviewer_text): Use the new regular expression.
1136         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1137         (test_fuzzy_reviewer_match_initial): Add a test for a reviewer name that has an initial.
1138
1139 2012-06-01  Christophe Dumez  <christophe.dumez@intel.com>
1140
1141         [EFL] EFL's LayoutTestController needs to implement deliverWebIntent
1142         https://bugs.webkit.org/show_bug.cgi?id=86865
1143
1144         Reviewed by Adam Barth.
1145
1146         Add deliverWebIntent method to LayoutTestController and provide
1147         implementation for EFL port.
1148
1149         * DumpRenderTree/LayoutTestController.cpp:
1150         (deliverWebIntentCallback):
1151         (LayoutTestController::staticFunctions):
1152         * DumpRenderTree/LayoutTestController.h:
1153         (LayoutTestController):
1154         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1155         (LayoutTestController::deliverWebIntent):
1156         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1157         (LayoutTestController::deliverWebIntent):
1158         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1159         (LayoutTestController::deliverWebIntent):
1160         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1161         (LayoutTestController::deliverWebIntent):
1162         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1163         (LayoutTestController::deliverWebIntent):
1164         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1165         (LayoutTestController::deliverWebIntent):
1166
1167 2012-06-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1168
1169         [Qt] Make Qt Creator aware of files in webkitpy/perl for easy editing
1170
1171         Reviewed by Simon Hausmann.
1172
1173         * Tools.pro:
1174
1175 2012-06-01  Ryosuke Niwa  <rniwa@webkit.org>
1176
1177         Add public page loading performance tests using web-page-replay
1178         https://bugs.webkit.org/show_bug.cgi?id=84008
1179
1180         Reviewed by Dirk Pranke.
1181
1182         Add the primitive implementation of replay performance tests. We use web-page-replay (http://code.google.com/p/web-page-replay/)
1183         to cache data locally. Each replay test is represented by a text file with .replay extension containing a single URL.
1184         To hash out bugs and isolate them from the rest of performance tests, replay tests are hidden behind --replay flag.
1185
1186         Run "run-perf-tests --replay PerformanceTests/Replay" after changing the system network preference to forward HTTP and HTTPS requests
1187         to localhost:8080 and localhost:8443 respectively (i.e. configure the system as if there are HTTP proxies at ports 8080 and 8443)
1188         excluding: *.webkit.org, *.googlecode.com, *.sourceforge.net, pypi.python.org, and www.adambarth.com for thirdparty Python dependencies.
1189         run-perf-tests starts web-page-replay, which provides HTTP proxies at ports 8080 and 8443 to replay pages.
1190
1191         * Scripts/webkitpy/layout_tests/port/driver.py:
1192         (Driver.is_external_http_test): Added.
1193         * Scripts/webkitpy/layout_tests/port/webkit.py:
1194         (WebKitDriver._command_from_driver_input): Allow test names that starts with http:// or https://.
1195         * Scripts/webkitpy/performance_tests/perftest.py:
1196         (PerfTest.__init__): Takes port.
1197         (PerfTest.prepare): Added. Overridden by ReplayPerfTest.
1198         (PerfTest):
1199         (PerfTest.run): Calls run_single.
1200         (PerfTest.run_single): Extracted from PageLoadingPerfTest.run.
1201         (ChromiumStylePerfTest.__init__):
1202         (PageLoadingPerfTest.__init__):
1203         (PageLoadingPerfTest.run):
1204         (ReplayServer): Added. Responsible for starting and stopping replay.py in the web-page-replay.
1205         (ReplayServer.__init__):
1206         (ReplayServer.wait_until_ready): Wait until port 8080 is ready. I have tried looking at the piped output from web-page-replay
1207         but it caused a dead lock on some web pages.
1208         (ReplayServer.stop):
1209         (ReplayServer.__del__):
1210         (ReplayPerfTest):
1211         (ReplayPerfTest.__init__):
1212         (ReplayPerfTest._start_replay_server):
1213         (ReplayPerfTest.prepare): Creates test.wpr and test-expected.png to cache the page when a replay test is ran for the first time.
1214         The subsequent runs of the same test will just use test.wpr.
1215         (ReplayPerfTest.run_single):
1216         (PerfTestFactory):
1217         (PerfTestFactory.create_perf_test):
1218         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1219         (MainTest.test_parse_output):
1220         (MainTest.test_parse_output_with_failing_line):
1221         (TestPageLoadingPerfTest.test_run):
1222         (TestPageLoadingPerfTest.test_run_with_bad_output):
1223         (TestReplayPerfTest):
1224         (TestReplayPerfTest.ReplayTestPort):
1225         (TestReplayPerfTest.ReplayTestPort.__init__):
1226         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver):
1227         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver.run_test):
1228         (TestReplayPerfTest.ReplayTestPort._driver_class):
1229         (TestReplayPerfTest.MockReplayServer):
1230         (TestReplayPerfTest.MockReplayServer.__init__):
1231         (TestReplayPerfTest.MockReplayServer.stop):
1232         (TestReplayPerfTest._add_file):
1233         (TestReplayPerfTest._setup_test):
1234         (TestReplayPerfTest.test_run_single):
1235         (TestReplayPerfTest.test_run_single.run_test):
1236         (TestReplayPerfTest.test_run_single_fails_without_webpagereplay):
1237         (TestReplayPerfTest.test_prepare_fails_when_wait_until_ready_fails):
1238         (TestReplayPerfTest.test_run_single_fails_when_output_has_error):
1239         (TestReplayPerfTest.test_run_single_fails_when_output_has_error.run_test):
1240         (TestReplayPerfTest.test_prepare):
1241         (TestReplayPerfTest.test_prepare.run_test):
1242         (TestReplayPerfTest.test_prepare_calls_run_single):
1243         (TestReplayPerfTest.test_prepare_calls_run_single.run_single):
1244         (TestPerfTestFactory.test_regular_test):
1245         (TestPerfTestFactory.test_inspector_test):
1246         (TestPerfTestFactory.test_page_loading_test):
1247         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1248         (PerfTestsRunner):
1249         (PerfTestsRunner._parse_args): Added --replay flag to enable replay tests.
1250         (PerfTestsRunner._collect_tests): Collect .replay files when replay tests are enabled.
1251         (PerfTestsRunner._collect_tests._is_test_file):
1252         (PerfTestsRunner.run): Exit early if one of calls to prepare() fails.
1253         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1254         (create_runner):
1255         (run_test):
1256         (_tests_for_runner):
1257         (test_run_test_set):
1258         (test_run_test_set_kills_drt_per_run):
1259         (test_run_test_pause_before_testing):
1260         (test_run_test_set_for_parser_tests):
1261         (test_run_test_set_with_json_output):
1262         (test_run_test_set_with_json_source):
1263         (test_run_test_set_with_multiple_repositories):
1264         (test_run_with_upload_json):
1265         (test_upload_json):
1266         (test_upload_json.MockFileUploader.upload_single_text_file):
1267         (_add_file):
1268         (test_collect_tests):
1269         (test_collect_tests_with_multile_files):
1270         (test_collect_tests_with_multile_files.add_file):
1271         (test_collect_tests_with_skipped_list):
1272         (test_collect_tests_with_page_load_svg):
1273         (test_collect_tests_should_ignore_replay_tests_by_default):
1274         (test_collect_tests_with_replay_tests):
1275         (test_parse_args):
1276         * Scripts/webkitpy/thirdparty/__init__.py: Added the dependency for web-page-replay version 1.1.1.
1277         (AutoinstallImportHook.find_module):
1278         (AutoinstallImportHook._install_webpagereplay):
1279
1280 2012-05-31  Yaron Friedman  <yfriedman@chromium.org>
1281
1282         Support building the Android port of chromium with Ninja
1283         https://bugs.webkit.org/show_bug.cgi?id=87545
1284
1285         Reviewed by Adam Barth.
1286
1287         Ensures that shared libraries are looked up in a generator-agnostic
1288         way and that output is placed in the correct directory.
1289
1290         Depends on http://codereview.chromium.org/10386188/
1291
1292         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1293
1294 2012-05-31  Ryosuke Niwa  <rniwa@webkit.org>
1295
1296         [Chromium] Chromium DRT should be able to load external resources
1297         https://bugs.webkit.org/show_bug.cgi?id=87893
1298
1299         Reviewed by Dirk Pranke.
1300
1301         Allow external resources to be loaded when the main frame's URL is also an external resource.
1302         This change is analogous to r118231 for Mac port.
1303
1304         * DumpRenderTree/chromium/WebViewHost.cpp:
1305         (blockRequest):
1306         (isLocalhost):
1307         (hostIsUsedBySomeTestsToGenerateError):
1308         (WebViewHost::willSendRequest):
1309
1310 2012-05-31  Anders Carlsson  <andersca@apple.com>
1311
1312         Build fixes.
1313
1314         Disable the C++11 extensions warning.
1315
1316         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1317         * TestWebKitAPI/Configurations/Base.xcconfig:
1318         * WebKitTestRunner/Configurations/Base.xcconfig:
1319
1320 2012-05-31  Alexey Proskuryakov  <ap@apple.com>
1321
1322         [WK2] window.internals settings are not reset between tests
1323         https://bugs.webkit.org/show_bug.cgi?id=87783
1324
1325         Reviewed by Mihai Parparita.
1326
1327         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1328         (WTR::InjectedBundle::done): Call resetAfterTest().
1329
1330         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1331         (WTR::InjectedBundlePage::prepare): Renamed from "reset" for clarity.
1332         (WTR::InjectedBundlePage::resetAfterTest): Added a function that resets internals.
1333         This needs to be done after a tets, because the code assumes that there is an object
1334         with this name in global scope.
1335
1336         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1337
1338 2012-05-31  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1339
1340         [EFL][DRT] EFL's DRT navigation_policy_decision implementation
1341         https://bugs.webkit.org/show_bug.cgi?id=85006
1342
1343         Reviewed by Tor Arne Vestbø.
1344
1345         Added navigation_policy_decision implementation for DumpRenderTreeView.
1346         Added LayoutTestController::setCustomPolicyDelegate implementation.
1347         Modified LayoutTestController::waitForPolicyDelegate.
1348
1349         * DumpRenderTree/efl/DumpRenderTree.cpp:
1350         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1351         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1352         * DumpRenderTree/efl/DumpRenderTreeEfl.h:
1353         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1354         (navigationTypeToString): aux function
1355         (onNavigationPolicyDecision): navigation_policy_decision implementation
1356         (drtViewAdd):
1357         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1358         (LayoutTestController::setCustomPolicyDelegate):
1359         (LayoutTestController::waitForPolicyDelegate):
1360
1361 2012-05-31  Jussi Kukkonen  <jussi.kukkonen@intel.com>
1362
1363         [EFL][DRT] LayoutTestController does not implement clearApplicationCacheForOrigin
1364         https://bugs.webkit.org/show_bug.cgi?id=86195
1365
1366         Reviewed by Gustavo Noronha Silva.
1367
1368         Implement clearApplicationCacheForOrigin in EFL
1369         LayoutTestController.
1370
1371         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1372         (LayoutTestController::clearApplicationCacheForOrigin):
1373
1374 2012-05-31  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1375
1376         [Qt] Simplify QT_VERSION_CHECKS for Qt5 by introducing HAVE(QT5)
1377         https://bugs.webkit.org/show_bug.cgi?id=87955
1378
1379         Reviewed by Simon Hausmann.
1380
1381         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1382         * DumpRenderTree/qt/EventSenderQt.cpp:
1383         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
1384         * DumpRenderTree/qt/main.cpp:
1385         * QtTestBrowser/cookiejar.cpp:
1386         * QtTestBrowser/launcherwindow.cpp:
1387         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1388         * qmake/mkspecs/features/default_post.prf:
1389
1390 2012-05-31  Zoltan Horvath  <zoltan@webkit.org>
1391
1392         [Qt] Don't enforce the version of libpng for the config test when passing the option to the linker
1393
1394         Rubber-stamped by Kenneth Rohde Christiansen.
1395
1396         * qmake/config.tests/libpng/libpng.pro:
1397
1398 2012-05-30  Peter Beverloo  <peter@chromium.org>
1399
1400         [Chromium] Automatically install 64-bit linker for Android
1401         https://bugs.webkit.org/show_bug.cgi?id=79780
1402
1403         Reviewed by Adam Barth.
1404
1405         Change the update-webkit-chromium script to check whether the 64-bit
1406         linker needs to be installed as part of the update process. The actual
1407         code for doing these checks and "installing" it has been added to the
1408         webkitdirs.pm script.
1409
1410         The linker itself is part of the third_party/aosp repository, which
1411         will be pulled in through the DEPS change.
1412
1413         * Scripts/update-webkit-chromium:
1414         * Scripts/webkitdirs.pm:
1415         (chromiumInstall64BitAndroidLinkerIfNeeded):
1416         (chromiumReplaceAndroidLinkerIfNeeded):
1417
1418 2012-05-30  Stephanie Lewis  <slewis@apple.com>
1419
1420         https://bugs.webkit.org/show_bug.cgi?id=87803
1421         Layout tests often fail trying to stat nonexistent logs 
1422
1423         Reviewed by Dirk Pranke.
1424
1425         CrashReporter removes logs using a heuristic to conserve space.  Wrap a 
1426         try/catch block around accessing the logs as a precaution.
1427
1428         * Scripts/webkitpy/common/system/crashlogs.py:
1429         (CrashLogs._find_newest_log_darwin):
1430
1431 2012-05-30  Gavin Peters  <gavinp@chromium.org>
1432
1433         Add a LayoutTest for prerender remove after stop.
1434         https://bugs.webkit.org/show_bug.cgi?id=87860
1435
1436         These very boring mocks in DumpRenderTree mean that the basic Prerendering API
1437         can be tested by LayoutTests now.
1438
1439         Reviewed by Adam Barth.
1440
1441         * DumpRenderTree/DumpRenderTree.gypi:
1442         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Added.
1443         (MockWebPrerenderingSupport::MockWebPrerenderingSupport):
1444         (MockWebPrerenderingSupport::~MockWebPrerenderingSupport):
1445         (MockWebPrerenderingSupport::add):
1446         (MockWebPrerenderingSupport::cancel):
1447         (MockWebPrerenderingSupport::abandon):
1448         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Added.
1449         (MockWebPrerenderingSupport):
1450         * DumpRenderTree/chromium/TestShell.cpp:
1451         (TestShell::initialize):
1452         * DumpRenderTree/chromium/TestShell.h:
1453         (TestShell):
1454         * DumpRenderTree/chromium/WebViewHost.cpp:
1455         (WebViewHost::willAddPrerender):
1456         (WebViewHost::setWebWidget):
1457         * DumpRenderTree/chromium/WebViewHost.h:
1458         (WebViewHost):
1459
1460 2012-05-30  Stephanie Lewis  <slewis@apple.com>
1461
1462         https://bugs.webkit.org/show_bug.cgi?id=87717
1463         Unresponsive WebProcesses can be mistaken for WebProcess crashes.
1464
1465         Reviewed by Dirk Pranke.
1466
1467         Change the error message from #CRASHED to #UNRESPONSIVE PROCESS
1468         If there isn't a crash log found for the process add a message saying
1469         the process was unresponsive.
1470
1471         * Scripts/webkitpy/layout_tests/port/webkit.py:
1472         (WebKitDriver.__init__):
1473         (WebKitDriver._check_for_driver_crash):
1474         (WebKitDriver.run_test):
1475         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1476         (WebKitDriverTest.test_check_for_driver_crash.assert_crash):
1477         (WebKitDriverTest):
1478         (WebKitDriverTest.test_check_for_driver_crash):
1479         * WebKitTestRunner/TestController.cpp:
1480         (WTR):
1481         (WTR::TestController::runTest):
1482
1483 2012-05-30  Stephanie Lewis  <slewis@apple.com>
1484
1485         https://bugs.webkit.org/show_bug.cgi?id=87714
1486         Mac crash logs can take a really long time to be written out.
1487
1488         Reviewed by Dirk Pranke.
1489
1490         Make a second pass looking for crash logs after the tests have completed running.
1491
1492         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1493         (use_trac_links_in_results_html):
1494         (Manager.run):
1495         * Scripts/webkitpy/layout_tests/port/base.py:
1496         (Port.repository_paths):
1497         (Port.look_for_new_crash_logs):
1498         * Scripts/webkitpy/layout_tests/port/mac.py:
1499         (MacPort.look_for_new_crash_logs):
1500         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1501         (test_get_crash_log):
1502         (test_look_for_new_crash_logs):
1503         (test_look_for_new_crash_logs.fake_time_cb):
1504
1505 2012-05-30  Kevin Ollivier  <kevino@theolliviers.com>
1506
1507         [wx] Fix 2.9 issues with c_str() type by using the wx fprintf wrapper.
1508
1509         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1510         (LayoutWebViewEventHandler::OnAlertEvent):
1511         (LayoutWebViewEventHandler::OnConfirmEvent):
1512         (LayoutWebViewEventHandler):
1513         (LayoutWebViewEventHandler::OnPromptEvent):
1514         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
1515         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
1516
1517 2012-05-30  Ojan Vafai  <ojan@chromium.org>
1518
1519         Only give lint errors for -expected.png png files that lack a checksum
1520         https://bugs.webkit.org/show_bug.cgi?id=87875
1521
1522         Reviewed by Tony Chang.
1523
1524         We have other pngs in the tree, e.g. for the inspector, that legitimately
1525         lack a checksum.
1526
1527         * Scripts/webkitpy/style/checkers/png.py:
1528         (PNGChecker.check):
1529         * Scripts/webkitpy/style/checkers/png_unittest.py:
1530         (PNGCheckerTest.test_check):
1531
1532 2012-05-30  Dirk Pranke  <dpranke@chromium.org>
1533
1534         nrwt: seems to leak temp dirs
1535         https://bugs.webkit.org/show_bug.cgi?id=87795
1536
1537         Reviewed by Ojan Vafai.
1538
1539         There appears to be a bug where the chromium bots are creating
1540         temporary directories and not cleaning them up that started
1541         after the switch to WebKitDriver. It's possible that __del__
1542         wasn't getting called in a timely manner (or at all), and it's
1543         generally bad style to rely on __del__ being called, so this
1544         code changes things so that we create a temp dir in
1545         driver.start() and remove it in driver.stop(). We could be
1546         paranoid and leave the __del__ code in, but there doesn't seem
1547         to be much advantage to it. If there are bugs that result in
1548         drivers being started but not stopped, we have other problems.
1549
1550         * Scripts/webkitpy/common/system/filesystem_mock.py:
1551         (MockFileSystem.__init__):
1552         (MockFileSystem._mktemp):
1553         (MockFileSystem.mkdtemp):
1554         * Scripts/webkitpy/layout_tests/port/webkit.py:
1555         (WebKitDriver.__init__):
1556         (WebKitDriver._start):
1557         (WebKitDriver.stop):
1558         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1559         (WebKitDriverTest.test_check_for_driver_crash):
1560         (WebKitDriverTest):
1561         (WebKitDriverTest.test_creating_a_port_does_not_write_to_the_filesystem):
1562         (WebKitDriverTest.test_stop_cleans_up_properly):
1563
1564 2012-05-30  Christophe Dumez  <christophe.dumez@intel.com>
1565
1566         [EFL] EFL's DRT should print the number of MessagePorts for new each new intent
1567         https://bugs.webkit.org/show_bug.cgi?id=86841
1568
1569         Reviewed by Adam Barth.
1570
1571         Print the number of MessagePorts for each new intent in EFL's DRT.
1572         This output is expected by several Web Intents test cases.
1573
1574         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1575         (DumpRenderTreeChrome::onFrameIntentNew):
1576
1577 2012-05-30  Kevin Ollivier  <kevino@theolliviers.com>
1578
1579         [wx] Unreviewed build fix after removal of setJavaScriptProfilingEnabled.
1580
1581         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1582
1583 2012-05-30  Christophe Dumez  <christophe.dumez@intel.com>
1584
1585         [EFL] Ewk_Intent_Request's postResult/postFailure should take serialized script values in argument
1586         https://bugs.webkit.org/show_bug.cgi?id=87829
1587
1588         Reviewed by Adam Barth.
1589
1590         EFL's LayoutTestController now makes uses of the new helper method in
1591         DumpRenderTreeSupportEfl in order to send the intent response. This is
1592         now needed because the Ewk_Intent_Request postResult / postFailure
1593         methods were made private.
1594
1595         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1596         (LayoutTestController::sendWebIntentResponse):
1597
1598 2012-05-30  Xueqing Huang  <huangxueqing@baidu.com>
1599
1600         eventSender.beginDragWithFiles should be implemented in Windows, which blocked drag and drop related tests.
1601         https://bugs.webkit.org/show_bug.cgi?id=86296
1602
1603         Reviewed by Tony Chang.
1604
1605         * DumpRenderTree/win/DRTDataObject.cpp: Added.
1606         (cfHDropFormat):
1607         (cfFileNameWFormat):
1608         (cfUrlWFormat):
1609         (WCEnumFormatEtc):
1610         (WCEnumFormatEtc::WCEnumFormatEtc):
1611         (WCEnumFormatEtc::QueryInterface):
1612         (WCEnumFormatEtc::AddRef):
1613         (WCEnumFormatEtc::Release):
1614         (WCEnumFormatEtc::Next):
1615         (WCEnumFormatEtc::Skip):
1616         (WCEnumFormatEtc::Reset):
1617         (WCEnumFormatEtc::Clone):
1618         (DRTDataObject::createInstance):
1619         (DRTDataObject::DRTDataObject):
1620         (DRTDataObject::~DRTDataObject):
1621         (DRTDataObject::QueryInterface):
1622         (DRTDataObject::AddRef):
1623         (DRTDataObject::Release):
1624         (DRTDataObject::GetData):
1625         (DRTDataObject::GetDataHere):
1626         (DRTDataObject::QueryGetData):
1627         (DRTDataObject::GetCanonicalFormatEtc):
1628         (DRTDataObject::SetData):
1629         (DRTDataObject::CopyMedium):
1630         (DRTDataObject::EnumFormatEtc):
1631         (DRTDataObject::DAdvise):
1632         (DRTDataObject::DUnadvise):
1633         (DRTDataObject::EnumDAdvise):
1634         (DRTDataObject::clearData):
1635         * DumpRenderTree/win/DRTDataObject.h: Added.
1636         (DRTDataObject):
1637         * DumpRenderTree/win/DRTDropSource.cpp: Added.
1638         (DRTDropSource::DRTDropSource):
1639         (DRTDropSource::~DRTDropSource):
1640         (DRTDropSource::QueryInterface):
1641         (DRTDropSource::AddRef):
1642         (DRTDropSource::Release):
1643         (DRTDropSource::createInstance):
1644         (DRTDropSource::QueryContinueDrag):
1645         (DRTDropSource::GiveFeedback):
1646         * DumpRenderTree/win/DRTDropSource.h: Added.
1647         (DRTDropSource):
1648         * DumpRenderTree/win/DumpRenderTree.vcproj:
1649         * DumpRenderTree/win/EventSender.cpp:
1650         (beginDragWithFilesCallback):
1651
1652 2012-05-30  Marcelo Lira  <marcelo.lira@openbossa.org>
1653
1654         WebKit2: Implement layoutTestController.setPluginsEnabled() in WebKitTestRunner.
1655         https://bugs.webkit.org/show_bug.cgi?id=58593
1656
1657         Adds the ability to change the pluginsEnabled flag in WebCore::Settings
1658         to WebKitTestRunner's LayoutTestController. The flag is modified via the
1659         public C API of the WebProcess.
1660
1661         Reviewed by Darin Adler.
1662
1663         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1664         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1665         (WTR::LayoutTestController::setPluginsEnabled): Just calls the
1666         WKBundleSetPluginsEnabled function in the public C API of WebProcess.
1667         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1668
1669 2012-05-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1670
1671         [EFL][DRT] http/tests/navigation/new-window-redirect-history.html does not pass
1672         https://bugs.webkit.org/show_bug.cgi?id=87848
1673
1674         Reviewed by Csaba Osztrogonác.
1675
1676         The reason was that DumpRenderTreeChrome::extraViews() returned copy of the vector
1677         and dumpBackForwardListForWebViews() used iterators belonging actually to different vectors
1678         (browser->extraViews().begin() and browser->extraViews().end()) as if they had belonged to the same vector.
1679
1680         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1681         (DumpRenderTreeChrome::extraViews):
1682         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1683         (DumpRenderTreeChrome):
1684
1685 2012-05-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1686
1687         [EFL][DRT] EFL's DRT needs "postProgressFinishedNotification" message
1688         https://bugs.webkit.org/show_bug.cgi?id=87833
1689
1690         Reviewed by Tor Arne Vestbø.
1691
1692         Print "postProgressFinishedNotification" message if frame load finished 
1693         to unskip http/tests/loading/progress-finished-callback.html.
1694
1695         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1696         (DumpRenderTreeChrome::onFrameLoadFinished):
1697
1698 2012-05-30  Mariusz Grzegorczyk  <mariusz.g@samsung.com>, Ryuan Choi  <ryuan.choi@samsung.com>
1699
1700         [EFL][WK2] Fix WebKit2-EFL build
1701         https://bugs.webkit.org/show_bug.cgi?id=83693
1702
1703         Reviewed by Carlos Garcia Campos.
1704
1705         * CMakeLists.txt:  Guard Webkit1 related codes with ENABLE_WEBKIT.
1706
1707 2012-05-29  János Badics  <jbadics@inf.u-szeged.hu>
1708
1709         [Qt] Modified ORWT and NRWT to check for test expectations in platform/qt-5.0-wk1 too
1710         (They only used to check for Skipped in platform/qt-5.0-wk1)
1711         https://bugs.webkit.org/show_bug.cgi?id=87376
1712
1713         Reviewed by Csaba Osztrogonác.
1714
1715         * Scripts/old-run-webkit-tests:
1716         (buildPlatformResultHierarchy):
1717         * Scripts/webkitpy/layout_tests/port/qt.py:
1718         (QtPort.baseline_search_path):
1719
1720 2012-05-29  Ojan Vafai  <ojan@chromium.org>
1721
1722         Add a linter error for pngs that lack an embedded checksum
1723         https://bugs.webkit.org/show_bug.cgi?id=87793
1724
1725         Reviewed by Dirk Pranke.
1726
1727         * Scripts/read-checksum-from-png:
1728         * Scripts/webkitpy/common/read_checksum_from_png.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png.py.
1729         (read_checksum):
1730         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py.
1731         (ReadChecksumFromPngTest):
1732         (ReadChecksumFromPngTest.test_read_checksum):
1733         * Scripts/webkitpy/layout_tests/port/base.py:
1734         * Scripts/webkitpy/style/checkers/png.py:
1735         (PNGChecker.check):
1736         * Scripts/webkitpy/style/checkers/png_unittest.py:
1737         (PNGCheckerTest.test_check):
1738
1739 2012-05-29  Stephanie Lewis  <slewis@apple.com>
1740
1741         https://bugs.webkit.org/show_bug.cgi?id=87720
1742         WebProcess is often killed due to being unresponsive on the bots
1743
1744         Reviewed by Alexey Proskuryakov.
1745
1746         Blind attempt to improve flakiness on the bots by reducing the number
1747         of crashes due to an unresponsive process.  This helped on my personal machine
1748         under stress conditions.  I don't have enough cores to hit the problem
1749         under normal conditions.
1750
1751         * WebKitTestRunner/TestController.cpp:
1752         (WTR):
1753
1754 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
1755
1756         webkitpy: rename 'rm' to 'delete' in rebaseline scm output
1757         https://bugs.webkit.org/show_bug.cgi?id=87779
1758
1759         Reviewed by Eric Seidel.
1760
1761         Update output to match the names in scm.py as per
1762         https://bugs.webkit.org/show_bug.cgi?id=87451#c26 .
1763
1764         * Scripts/webkitpy/tool/commands/rebaseline.py:
1765         (RebaselineTest.execute):
1766         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1767         (test_rebaseline_test_and_print_scm_changes):
1768         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1769         (GardeningServerTest.test_rebaselineall):
1770
1771 2012-05-29  Stephanie Lewis  <slewis@apple.com>
1772
1773         https://bugs.webkit.org/show_bug.cgi?id=87711
1774
1775         Reviewed by Jessie Berlin.
1776
1777         Remove Snowleopard testers so the hardware can be repurposed.  The lion bots
1778         are better maintained.
1779
1780         * BuildSlaveSupport/build.webkit.org-config/config.json:
1781
1782 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
1783
1784         webkit-patch optimize-baselines should add/delete files in batches from the vcs
1785         https://bugs.webkit.org/show_bug.cgi?id=87538
1786
1787         Reviewed by Ojan Vafai.
1788
1789         Invoking git and svn on one file at a time is kinda slow. We
1790         should batch the add and rm operations together.
1791
1792         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
1793         (BaselineOptimizer._move_baselines):
1794
1795 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
1796
1797         garden-o-matic should rebaseline baselines in parallel
1798         https://bugs.webkit.org/show_bug.cgi?id=87451
1799
1800         Reviewed by Ojan Vafai.
1801                                                                                
1802         This modifies garden-o-matic so that we will fetch all                  
1803         of the baselines in parallel from the bots, and then                    
1804         optimize the baselines serially (since that should be fairly            
1805         quick and we get into trouble if we optimize in parallel due            
1806         to concurrent access to the source control system).                     
1807
1808         This change adds a flag to webkit-patch rebaseline-test (--print-scm-changes)
1809         so that the files that need to be modified in the SCM are returned to 
1810         garden-o-matic rather than actually added or removed. This is done so that
1811         we can run multiple rebaseline-tests in parallel (we can't modify the SCM
1812         concurrently). In order to safely return the files (as a JSON dict) I
1813         needed to shift all of the logging in rebaseline-test to use the logging
1814         module (and hence log to stderr).
1815
1816         I also had to stub out a line in chromium.py that would get confused if
1817         the skia overrides file didn't exist in a mock checkout.
1818
1819         * Scripts/webkitpy/common/system/executive.py:
1820         (Executive.popen):
1821         (Executive):
1822         (Executive.run_in_parallel):
1823         (_run_command_thunk):
1824         * Scripts/webkitpy/common/system/executive_mock.py:
1825         (MockExecutive.run_in_parallel):
1826         * Scripts/webkitpy/common/system/executive_unittest.py:
1827         (ExecutiveTest.test_run_in_parallel):
1828         * Scripts/webkitpy/layout_tests/port/chromium.py:
1829         (ChromiumPort._expectations_file_contents):
1830         * Scripts/webkitpy/tool/commands/rebaseline.py:
1831         (AbstractRebaseliningCommand.__init__):
1832         (RebaselineTest.__init__):
1833         (RebaselineTest._copy_existing_baseline):
1834         (RebaselineTest._save_baseline):
1835         (RebaselineTest):
1836         (RebaselineTest._add_to_scm):
1837         (RebaselineTest._rebaseline_test):
1838         (RebaselineTest.execute):
1839         (RebaselineExpectations._rebaseline_port):
1840         (RebaselineExpectations.execute):
1841         (Rebaseline._builder_to_pull_from):
1842         (Rebaseline.execute):
1843         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1844         (test_rebaseline_updates_expectations_file):
1845         (test_rebaseline_test):
1846         (test_rebaseline_test_and_print_scm_changes):
1847         (test_rebaseline_and_copy_test):
1848         (test_rebaseline_and_copy_test_no_existing_result):
1849         (test_rebaseline_and_copy_test_with_lion_result):
1850         (test_rebaseline_and_copy_no_overwrite_test):
1851         (test_rebaseline_expectations):
1852         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1853         (GardeningHTTPRequestHandler._rebaseline_commands):
1854         (GardeningHTTPRequestHandler):
1855         (GardeningHTTPRequestHandler._files_to_add):
1856         (GardeningHTTPRequestHandler._optimize_baselines):
1857         (GardeningHTTPRequestHandler.rebaselineall):
1858         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1859         (GardeningServerTest._post_to_path):
1860         (GardeningServerTest.test_rebaselineall):
1861         (GardeningServerTest.test_rebaselineall.run_command):
1862
1863 2012-05-29  Benjamin Poulain  <bpoulain@apple.com>
1864
1865         Fix the type of dispatch_time() offset
1866
1867         Rubber-stamped by Joseph Pecoraro.
1868
1869         In r118631, I erroneously used the type NSTimeInterval for the delta of dispatch_time().
1870
1871         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1872         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1873
1874 2012-05-29  Arvid Nilsson  <anilsson@rim.com>
1875
1876         2012-05-29  Arvid Nilsson  <anilsson@rim.com>
1877
1878         [BlackBerry] OpenGL content is not rendered on simulator
1879         https://bugs.webkit.org/show_bug.cgi?id=87721
1880
1881         Reviewed by George Staikos.
1882
1883         Fixed by enabling GLES2 support in simulator builds.
1884
1885         To experiment with building without OpenGL support, you can set the
1886         DISABLE_GLES2 environment variable to a non-empty string and rebuild.
1887
1888         PR #150695
1889
1890         * Scripts/webkitdirs.pm:
1891         (blackberryCMakeArguments):
1892
1893 2012-05-29  David Barr  <davidbarr@chromium.org>
1894
1895         Introduce ENABLE_CSS_IMAGE_RESOLUTION compile flag
1896         https://bugs.webkit.org/show_bug.cgi?id=87685
1897
1898         Reviewed by Eric Seidel.
1899
1900         Add a configuration option for CSS image-resolution support, disabling it by default.
1901
1902         * Scripts/webkitperl/FeatureList.pm:
1903         * qmake/mkspecs/features/features.pri:
1904
1905 2012-05-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1906
1907         [Qt] Don't add cxx-flags to QMAKE_CFLAGS
1908
1909         Prevents warnings such as: "command line option ‘-Wno-c++0x-compat’ is
1910             valid for C++/ObjC++ but not for C [enabled by default]"
1911
1912         Reviewed by Simon Hausmann.
1913
1914         * qmake/mkspecs/features/unix/default_post.prf:
1915
1916 2012-05-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1917
1918         [Qt] Sync up favicon-implementation with WebView url changes in r118158
1919
1920         https://bugs.webkit.org/show_bug.cgi?id=87133
1921
1922         We now base64-encode the page url in the image-provider url, so that any
1923         normalization done by QUrl will not mess up the page-url. The logic of
1924         creating and parsing the provider-url has been moved into the image
1925         provider, to keep it in one place.
1926
1927         We were also releasing icons (even ones we hadn't retained), which we can't
1928         do since we don't know when the icon url is no longer in use.
1929
1930         Reviewed-by Simon Hausmann.
1931
1932         * MiniBrowser/qt/icons/favicon.png:
1933         * MiniBrowser/qt/qml/BrowserWindow.qml:
1934
1935 2012-05-29  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1936
1937         [EFL] Refactoring. Get rid of unnecessary singleCharacterString() function
1938         https://bugs.webkit.org/show_bug.cgi?id=87654
1939
1940         Reviewed by Csaba Osztrogonác.
1941
1942         Event sender provides strings for all the key events.
1943         Also KeyEventInfo constructor parameters order was changed to simplify the case when
1944         a key event has empty string.
1945
1946         * DumpRenderTree/efl/EventSender.cpp:
1947         (KeyEventInfo::KeyEventInfo):
1948         (keyPadNameFromJSValue):
1949         (keyNameFromJSValue):
1950
1951 2012-05-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1952
1953         [Qt] Cancel potential url-edit when going back/forward
1954
1955         Reviewed by Kenneth Rohde Christiansen.
1956
1957         * MiniBrowser/qt/qml/BrowserWindow.qml:
1958
1959 2012-05-29  Christophe Dumez  <christophe.dumez@intel.com>
1960
1961         [EFL] Compilation warning in DumpRenderTreeView.cpp
1962         https://bugs.webkit.org/show_bug.cgi?id=87636
1963
1964         Reviewed by Filip Pizlo.
1965
1966         Fix compilation error in DumpRenderTreeView.cpp due to wrong format
1967         specifier in printf. Also fix the return type for
1968         onExceededApplicationCacheQuota callback.
1969
1970         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1971         (onExceededApplicationCacheQuota):
1972
1973 2012-05-29  Hironori Bono  <hbono@chromium.org>
1974
1975         Adding Hironori Bono to committers.py.
1976         https://bugs.webkit.org/show_bug.cgi?id=87697
1977
1978         * Scripts/webkitpy/common/config/committers.py:
1979
1980 2012-05-28  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
1981
1982         [BlackBerry] http authenticate dialog popup only once no matter authentication pass or fail
1983         https://bugs.webkit.org/show_bug.cgi?id=80135
1984
1985         Reviewed by Rob Buis.
1986
1987         Implemented interface function didReceiveAuthenticationChallenge in class
1988         DumpRenderTree.
1989
1990         Resubmit the patch reverted by r115104 after the digest infinite loop
1991         issue for BlackBerry porting get identified and fixed.
1992
1993         Internally reviewed by Joe Mason <jmason@rim.com>
1994
1995         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1996         (drtCredentialDescription):
1997         (BlackBerry::WebKit::DumpRenderTree::didReceiveAuthenticationChallenge):
1998         (WebKit):
1999         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
2000         (WebCore):
2001         (DumpRenderTree):
2002
2003 2012-05-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2004
2005         WebKitTestRunner needs to support layoutTestController.setJavaScriptProfilingEnabled
2006         https://bugs.webkit.org/show_bug.cgi?id=42328
2007
2008         Reviewed by Eric Seidel.
2009
2010         Removed unneeded setJavaScriptProfilingEnabled function from DRT after its
2011         move to windows.internals.settings.
2012
2013         * DumpRenderTree/LayoutTestController.cpp:
2014         (LayoutTestController::staticFunctions):
2015         * DumpRenderTree/LayoutTestController.h:
2016         (LayoutTestController):
2017         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2018         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2019         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2020         (DRTDevToolsAgent):
2021         * DumpRenderTree/chromium/LayoutTestController.cpp:
2022         (LayoutTestController::LayoutTestController):
2023         * DumpRenderTree/chromium/LayoutTestController.h:
2024         (LayoutTestController):
2025         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2026         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2027         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2028         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2029         * DumpRenderTree/mac/DumpRenderTree.mm:
2030         (resetWebViewToConsistentStateBeforeTesting):
2031         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2032         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2033         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2034         (LayoutTestController):
2035         * DumpRenderTree/win/DumpRenderTree.cpp:
2036         (resetWebViewToConsistentStateBeforeTesting):
2037         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2038         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2039         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2040         (LayoutTestController):
2041
2042 2012-05-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2043
2044         Move allowRoundingHacks to Internals interface
2045         https://bugs.webkit.org/show_bug.cgi?id=87328
2046
2047         Reviewed by Hajime Morita.
2048
2049         Remove allowRoundingHacks functions, because it is able to work in the
2050         cross-port way through the Internals interface.
2051
2052         * DumpRenderTree/LayoutTestController.cpp:
2053         (LayoutTestController::staticFunctions):
2054         * DumpRenderTree/LayoutTestController.h:
2055         (LayoutTestController):
2056         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2057         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2058         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2059         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2060         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2061         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2062
2063 2012-05-28  Luke Macpherson  <macpherson@chromium.org>
2064
2065         Fix mac build with older XCode by defining NSEC_PER_MSEC.
2066         https://bugs.webkit.org/show_bug.cgi?id=87616
2067
2068         Reviewed by Hajime Morita.
2069
2070         The following patch introduced the use of NSEC_PER_MSEC which is not defined for older XCode versions.
2071         http://trac.webkit.org/changeset/118631/trunk/Tools/DumpRenderTree/mac/FrameLoadDelegate.mm
2072         Patch just adds a #ifndef / #define check.
2073
2074         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2075         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2076
2077 2012-05-27  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2078
2079         [EFL] Enable blob support for the EFL port
2080         https://bugs.webkit.org/show_bug.cgi?id=85363
2081
2082         Reviewed by Hajime Morita.
2083
2084         Enable Blob support by default for the EFL port.
2085
2086         * Scripts/webkitperl/FeatureList.pm:
2087
2088 2012-05-27  Benjamin Poulain  <bpoulain@apple.com>
2089
2090         When pages are loaded from AppCache with DeferredLoading, willSendRequest() is never called
2091         https://bugs.webkit.org/show_bug.cgi?id=87582
2092
2093         Reviewed by Darin Adler.
2094
2095         Extend DumpRenderTree to support loading the main resource deferred with a delay. This makes it
2096         possible to test pages in a similar way as they are loaded in Browsers.
2097
2098         * DumpRenderTree/LayoutTestController.cpp:
2099         (LayoutTestController::LayoutTestController):
2100         (setUseDeferredFrameLoadingCallback):
2101         (LayoutTestController::staticFunctions):
2102         * DumpRenderTree/LayoutTestController.h:
2103         (LayoutTestController::useDeferredFrameLoading):
2104         (LayoutTestController::setUseDeferredFrameLoading):
2105         (LayoutTestController):
2106         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2107         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2108
2109 2012-05-27  David Barton  <dbarton@mathscribe.com>
2110
2111         [watchlist] Improve MathML rule
2112         https://bugs.webkit.org/show_bug.cgi?id=87592
2113
2114         Reviewed by Adam Barth.
2115
2116         The old rule "filename": r".*mathml" works fine because "filename" is a prefix match,
2117         but if this changed the rule would be slow. We protect against this, clarify the rule,
2118         and make it more similar to existing rules.
2119
2120         * Scripts/webkitpy/common/config/watchlist:
2121
2122 2012-05-27  David Barton  <dbarton@mathscribe.com>
2123
2124         [watchlist] Add myself & a rule for MathML
2125         https://bugs.webkit.org/show_bug.cgi?id=87586
2126
2127         Reviewed by Adam Barth.
2128
2129         * Scripts/webkitpy/common/config/watchlist:
2130
2131 2012-05-26  David Kilzer  <ddkilzer@apple.com>
2132
2133         Use xcrun to find path to nm for Mac port
2134         <http://webkit.org/b/87588>
2135
2136         Reviewed by Dan Bernstein.
2137
2138         * Scripts/webkitpy/layout_tests/port/mac.py:
2139         (MacPort.nm_command): Add. Tries to find a path for the nm
2140         command using xcrun.  Falls back to returning 'nm'.
2141         * Scripts/webkitpy/layout_tests/port/webkit.py:
2142         (WebKitPort.nm_command): Add. Returns 'nm'.
2143         (WebKitPort._webcore_symbols_string): Call self.nm_command().
2144
2145 2012-05-25  Lynn Neir  <lynn.neir@skype.net>
2146
2147         Added windows implementation in DRT for TextInputController, https://bugs.webkit.org/show_bug.cgi?id=32021
2148
2149         Reviewed by Eric Seidel.
2150
2151         * DumpRenderTree/win/DumpRenderTree.vcproj:
2152         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2153         (FrameLoadDelegate::FrameLoadDelegate):
2154         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
2155         * DumpRenderTree/win/FrameLoadDelegate.h:
2156         (FrameLoadDelegate):
2157         * DumpRenderTree/win/TextInputController.cpp: Added.
2158         (setMarkedTextCallback):
2159         (hasMarkedTextCallback):
2160         (unmarkTextCallback):
2161         (markedRangeCallback):
2162         (insertTextCallback):
2163         (firstRectForCharacterRangeCallback):
2164         (selectedRangeCallback):
2165         (TextInputController::makeWindowObject):
2166         (TextInputController::getJSClass):
2167         (TextInputController::staticValues):
2168         (TextInputController::staticFunctions):
2169         * DumpRenderTree/win/TextInputController.h: Added.
2170         (TextInputController):
2171         * DumpRenderTree/win/TextInputControllerWin.cpp: Added.
2172         (TextInputController::setMarkedText):
2173         (TextInputController::hasMarkedText):
2174         (TextInputController::unmarkText):
2175         (TextInputController::markedRange):
2176         (TextInputController::insertText):
2177         (TextInputController::firstRectForCharacterRange):
2178         (TextInputController::selectedRange):
2179
2180 2012-05-25  Dirk Pranke  <dpranke@chromium.org>
2181
2182         webkitpy: change scm.add(), scm.delete() to accept multiple paths
2183         https://bugs.webkit.org/show_bug.cgi?id=87528
2184
2185         Reviewed by Ojan Vafai.
2186
2187         launching git or svn for individual files can be slow; this
2188         change will hand multiple paths at once to git and svn so they
2189         can be added in a batch.
2190
2191         * Scripts/webkitpy/common/checkout/scm/git.py:
2192         (Git.add_list):
2193         (Git.delete_list):
2194         * Scripts/webkitpy/common/checkout/scm/scm.py:
2195         (SCM.add):
2196         (SCM):
2197         (SCM.add_list):
2198         (SCM.delete):
2199         (SCM.delete_list):
2200         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2201         (MockSCM.add):
2202         (MockSCM):
2203         (MockSCM.add_list):
2204         (MockSCM.delete):
2205         (MockSCM.delete_list):
2206         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2207         (_shared_test_exists):
2208         (_shared_test_added_files):
2209         (_test_delete_list):
2210         * Scripts/webkitpy/common/checkout/scm/svn.py:
2211         (SVN.add_list):
2212         (SVN.delete_list):
2213
2214 2012-05-25  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2215
2216         [NRWT] Add unit testing for perf tests on locked shards
2217         https://bugs.webkit.org/show_bug.cgi?id=87489
2218
2219         Reviewed by Dirk Pranke.
2220
2221         Adding utests that makes sure that perf tests are running in locked
2222         shards and by passing --no-http won't break NRWT (r118421).
2223
2224         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2225         (ShardingTests):
2226         (ShardingTests.test_shard_by_dir):
2227         (ShardingTests.test_shard_every_file):
2228         (ShardingTests.test_shard_in_two):
2229         (ShardingTests.test_multiple_locked_shards):
2230         (LockCheckingManager):
2231         (LockCheckingManager.__init__):
2232         (LockCheckingManager.handle_finished_list):
2233         (ManagerTest.test_http_locking):
2234         (ManagerTest):
2235         (ManagerTest.test_perf_locking):
2236         * Scripts/webkitpy/layout_tests/port/test.py:
2237
2238 2012-05-25  Jessie Berlin  <jberlin@apple.com>
2239
2240         [Win] fast/events/keydown-leftright-keys.html failing since introduction in r118001
2241         https://bugs.webkit.org/show_bug.cgi?id=87511
2242
2243         Reviewed by Alexey Proskuryakov.
2244
2245         Update the Windows implementation of keyDown to match the Mac one changed in r118001.
2246
2247         * DumpRenderTree/win/EventSender.cpp:
2248         (keyDownCallback):
2249
2250 2012-05-25  Ken Buchanan  <kenrb@chromium.org>
2251
2252         Adding Ken Buchanan to committers.py
2253         https://bugs.webkit.org/show_bug.cgi?id=87443
2254
2255         Unreviewed.
2256
2257         Adding self to committers.py as a Committer.
2258
2259         * Scripts/webkitpy/common/config/committers.py:
2260
2261 2012-05-25  Csaba Osztrogonác  <ossy@webkit.org>
2262
2263         [Qt] Buildfix for newer Qt5
2264         https://bugs.webkit.org/show_bug.cgi?id=87257
2265
2266         Reviewed by Simon Hausmann.
2267
2268         * MiniBrowser/qt/MiniBrowserApplication.h: QtDeclarative -> QtQml renaming.
2269
2270 2012-05-25  Csaba Osztrogonác  <ossy@webkit.org>
2271
2272         [Qt] Unreviewed fix after r118484.
2273
2274         Enable CSS_EXCLUSIONS and CSS_REGIONS.
2275         They were enabled uncoditinally before r118484.
2276
2277         * qmake/mkspecs/features/features.pri:
2278
2279 2012-05-24  Tim Horton  <timothy_horton@apple.com>
2280
2281         Add feature defines for web-facing parts of CSS Regions and Exclusions
2282         https://bugs.webkit.org/show_bug.cgi?id=87442
2283         <rdar://problem/10887709>
2284
2285         Reviewed by Dan Bernstein.
2286
2287         * Scripts/webkitperl/FeatureList.pm:
2288
2289 2012-05-24  Hironori Bono  <hbono@chromium.org>
2290
2291         Enable grammar checking on Chromium when we paste text (Take 2)
2292         https://bugs.webkit.org/show_bug.cgi?id=74393
2293
2294         Reviewed by Ryosuke Niwa.
2295
2296         This change enables grammar checking on Chromium and implements a mock grammar
2297         checker to fix a failing test.
2298
2299         * DumpRenderTree/DumpRenderTree.gypi:
2300         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
2301         (MockGrammarCheck::checkGrammarOfString):
2302         * DumpRenderTree/chromium/MockGrammarCheck.h: Added.
2303         (WebKit):
2304         (MockGrammarCheck):
2305         * DumpRenderTree/chromium/WebViewHost.cpp:
2306         (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.
2307
2308 2012-05-24  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2309
2310         [EFL] [DRT] Add support for WebKitOfflineWebApplicationCacheEnabled preference
2311         https://bugs.webkit.org/show_bug.cgi?id=86842
2312
2313         Reviewed by Antonio Gomes.
2314
2315         Add support for overriding the application cache support preference
2316         through EFL's LayoutTestController.
2317
2318         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2319         (LayoutTestController::overridePreference):
2320
2321 2012-05-24  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2322
2323         [EFL] Remove unnecessary extra call to set developer extras setting on the test startup
2324         https://bugs.webkit.org/show_bug.cgi?id=85209
2325
2326         Reviewed by Antonio Gomes.
2327
2328         Set developer extras setting called twice on the test startup. Hence, removing
2329         an unnecessary extra call which set wrong value. 
2330
2331         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2332         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2333
2334 2012-05-24  Dirk Pranke  <dpranke@chromium.org>
2335
2336         garden-o-matic should not fetch from debug bots if it also knows about the release bots
2337         https://bugs.webkit.org/show_bug.cgi?id=86916
2338
2339         Reviewed by Adam Barth.
2340
2341         Note that if release and debug are failing differently, debug
2342         will be ignored ...
2343
2344         Note: also change the use of a fake port name from
2345         "mock-port-name" to "test-mac-leopard" to make it more friendly
2346         to the port factory ("mock" actually is a real port).
2347
2348         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2349         (GardeningHTTPRequestHandler._builders_to_fetch_from):
2350         (GardeningHTTPRequestHandler.rebaselineall):
2351         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2352         (GardeningServerTest.test_rebaselineall):
2353         (GardeningServerTest.test_rebaseline_new_port):
2354
2355 2012-05-24  Dirk Pranke  <dpranke@chromium.org>
2356
2357         nrwt: fix baseline search path for official chrome builders
2358         https://bugs.webkit.org/show_bug.cgi?id=87432
2359
2360         Reviewed by Tony Chang.
2361
2362         The official chrome builders need to use the win7 and SL
2363         baseline paths, not the XP and Leopard paths. Linux is correct.
2364
2365         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2366         (GoogleChromeMacPort.determine_full_port_name):
2367         (GoogleChromeWinPort.determine_full_port_name):
2368         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2369         (TestGoogleChromePort._verify_baseline_search_path_startswith):
2370         (TestGoogleChromePort.test_get_google_chrome_port):
2371
2372 2012-05-24  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2373
2374         [NRWT] REGRESSION(r116021): Assertion when running with --no-http
2375         https://bugs.webkit.org/show_bug.cgi?id=86800
2376
2377         Reviewed by Dirk Pranke.
2378
2379         Don't launch a HTTP server with lock based only on the existence of
2380         locked shards since we now run perf on locked shards too.
2381
2382         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2383         (Manager._run_tests):
2384
2385 2012-05-24  Jochen Eisinger  <jochen@chromium.org>
2386
2387         Add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
2388         https://bugs.webkit.org/show_bug.cgi?id=87128
2389
2390         Reviewed by Dirk Pranke.
2391
2392         * Scripts/webkitpy/layout_tests/port/base.py:
2393         (Port.driver_name):
2394         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2395         (ChromiumLinuxPort._path_to_driver):
2396         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2397         (ChromiumPortTest.test_driver_name_option):
2398         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2399         (ChromiumWinPort._path_to_driver):
2400         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2401         (parse_args):
2402
2403 2012-05-24  John Mellor  <johnme@chromium.org>
2404
2405         Font Boosting: Add compile flag and runtime setting
2406         https://bugs.webkit.org/show_bug.cgi?id=87394
2407
2408         Reviewed by Adam Barth.
2409
2410         Add ENABLE_FONT_BOOSTING.
2411
2412         * Scripts/webkitperl/FeatureList.pm:
2413         * qmake/mkspecs/features/features.pri:
2414
2415 2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2416
2417         [EFL] [DRT] keyboard-related tests do not pass
2418         https://bugs.webkit.org/show_bug.cgi?id=85369
2419
2420         Reviewed by Gustavo Noronha Silva.
2421
2422         Add SHIFT modifier for capital letters as VK_ 
2423         codes do not distinguish between lows and caps and also to be consistent
2424         with other ports which send caps as lowercase letters with the shift key down.
2425
2426         * DumpRenderTree/efl/EventSender.cpp:
2427         (keyNameFromJSValue): 
2428
2429 2012-05-24  Alexey Proskuryakov  <ap@apple.com>
2430
2431         [WK2] Let the client give local files universal access on a case by case basis
2432         https://bugs.webkit.org/show_bug.cgi?id=87174
2433         <rdar://problem/11024330>
2434
2435         Reviewed by Maciej Stachowiak.
2436
2437         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage):
2438         Added initialization of a new structure member to prevent build failure.
2439
2440 2012-05-24  Raphael Kubo da Costa  <rakuco@webkit.org>
2441
2442         [EFL] Modify keycode conversion functions to return keycodes with location information after r118001.
2443         https://bugs.webkit.org/show_bug.cgi?id=87203
2444
2445         Reviewed by Andreas Kling.
2446
2447         Add the required changes to make
2448         fast/events/keydown-leftright-keys.html pass after r118001.
2449
2450         * DumpRenderTree/efl/EventSender.cpp:
2451         (keyNameFromJSValue): Translate "{left,right}{Shift,Alt,Control}"
2452         into the proper X11 keysym definitions.
2453
2454 2012-05-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2455
2456         Unreviewed, rolling out r118352.
2457         http://trac.webkit.org/changeset/118352
2458         https://bugs.webkit.org/show_bug.cgi?id=87390
2459
2460         Caused 6 editing/spelling tests crash/fail on chromium in
2461         debug. (Requested by vsevik on #webkit).
2462
2463         * DumpRenderTree/DumpRenderTree.gypi:
2464         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Removed.
2465         * DumpRenderTree/chromium/MockGrammarCheck.h: Removed.
2466         * DumpRenderTree/chromium/WebViewHost.cpp:
2467         (WebViewHost::finishLastTextCheck):
2468
2469 2012-05-24  Peter Beverloo  <peter@chromium.org>
2470
2471         Add John Mellor as a contributor
2472         https://bugs.webkit.org/show_bug.cgi?id=87389
2473
2474         Reviewed by Kenneth Rohde Christiansen.
2475
2476         John will be working on Font Boosting and is very involved with various
2477         web-facing subjects of Chrome for Android, such as viewport.
2478
2479         * Scripts/webkitpy/common/config/committers.py:
2480
2481 2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2482
2483         [EFL][DRT] LayoutTestController's setCacheModel() implementation
2484         https://bugs.webkit.org/show_bug.cgi?id=86840
2485
2486         Reviewed by Csaba Osztrogonác.
2487
2488         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2489         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Reset dead decoded data deletion interval.
2490         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2491         (LayoutTestController::setCacheModel): Implementation added.
2492
2493 2012-05-24  Hironori Bono  <hbono@chromium.org>
2494
2495         Enable grammar checking on Chromium when we paste text.
2496         https://bugs.webkit.org/show_bug.cgi?id=74393
2497
2498         Reviewed by Hajime Morita.
2499
2500         This change enables grammar checking on Chromium and implements a mock grammar
2501         checker to fix a failing test.
2502
2503         * DumpRenderTree/DumpRenderTree.gypi:
2504         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
2505         (MockGrammarCheck::checkGrammarOfString):
2506         * DumpRenderTree/chromium/MockGrammarCheck.h: Added.
2507         (WebKit):
2508         (MockGrammarCheck):
2509         * DumpRenderTree/chromium/WebViewHost.cpp:
2510         (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.
2511
2512 2012-05-24  Csaba Osztrogonác  <ossy@webkit.org>
2513
2514         [Qt] Unreviewed fix, add ENABLE_CSS3_FLEXBOX after r118304.
2515
2516         * qmake/mkspecs/features/features.pri:
2517
2518 2012-05-24  Christophe Dumez  <christophe.dumez@intel.com>
2519
2520         [EFL] EFL's LayoutTestController needs to implement sendWebIntentResponse
2521         https://bugs.webkit.org/show_bug.cgi?id=86867
2522
2523         Reviewed by Adam Barth.
2524
2525         Add implementation for sendWebIntentResponse() in EFL's
2526         LayoutTestController and add empty implementation for other ports.
2527
2528         * DumpRenderTree/LayoutTestController.cpp:
2529         (sendWebIntentResponseCallback):
2530         (LayoutTestController::staticFunctions):
2531         * DumpRenderTree/LayoutTestController.h:
2532         (LayoutTestController):
2533         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2534         (LayoutTestController::sendWebIntentResponse):
2535         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2536         (DumpRenderTreeChrome::currentIntentRequest):
2537         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2538         (DumpRenderTreeChrome::onFrameIntentNew):
2539         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2540         (DumpRenderTreeChrome):
2541         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2542         (LayoutTestController::sendWebIntentResponse):
2543         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2544         (LayoutTestController::sendWebIntentResponse):
2545         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2546         (LayoutTestController::sendWebIntentResponse):
2547         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2548         (LayoutTestController::sendWebIntentResponse):
2549         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2550         (LayoutTestController::sendWebIntentResponse):
2551
2552 2012-05-24  Christophe Dumez  <christophe.dumez@intel.com>
2553
2554         [EFL] The EFL port has no support for title directionality
2555         https://bugs.webkit.org/show_bug.cgi?id=86462
2556
2557         Reviewed by Gustavo Noronha Silva.
2558
2559         Update "title,changed" signal handlers in DRT and EWebLauncher to
2560         reflect the change from const char* to Ewk_Text_With_Direction* type
2561         for the title.
2562
2563         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2564         (DumpRenderTreeChrome::onTitleChanged):
2565         * EWebLauncher/main.c:
2566         (title_set):
2567         (on_title_changed):
2568         (on_key_down):
2569
2570 2012-05-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2571
2572         Change EFL debug build name with more detail one
2573         https://bugs.webkit.org/show_bug.cgi?id=87254
2574
2575         Reviewed by Ryosuke Niwa.
2576
2577         EFL Linux Debug buildbot name needs to be consistent with other EFL buildbot name.
2578         In addition, remove efl-linux-debug triggerable since nobody uses it.
2579
2580         * BuildSlaveSupport/build.webkit.org-config/config.json:
2581
2582 2012-05-23  Kangil Han  <kangil.han@samsung.com>
2583
2584         [EFL][DRT] Fix WebCore library path and rebaseline result
2585         https://bugs.webkit.org/show_bug.cgi?id=86355
2586
2587         Reviewed by Dirk Pranke.
2588
2589         Currently EFL DRT uses wrong WebCore library path when running DRT.
2590         Therefore, this patch adjusted the path correctly.
2591
2592         * Scripts/webkitpy/layout_tests/port/efl.py:
2593         (EflPort._path_to_webcore_library):
2594
2595 2012-05-23  Ojan Vafai  <ojan@chromium.org>
2596
2597         add back the ability to disable flexbox
2598         https://bugs.webkit.org/show_bug.cgi?id=87147
2599
2600         Reviewed by Tony Chang.
2601
2602         * Scripts/webkitperl/FeatureList.pm:
2603
2604 2012-05-23  Tony Chang  <tony@chromium.org>
2605
2606         Remove the Chromium Grid Layout bot from the waterfall
2607         https://bugs.webkit.org/show_bug.cgi?id=87311
2608
2609         Reviewed by Ryosuke Niwa.
2610
2611         I removed the compiler define in r117613, so we don't need a separate
2612         bot to compile/test this code.
2613
2614         * BuildSlaveSupport/build.webkit.org-config/config.json:
2615
2616 2012-05-23  Ian Vollick  <vollick@chromium.org>
2617
2618         Add vollick to list of contributors.
2619         https://bugs.webkit.org/show_bug.cgi?id=87305
2620
2621         Reviewed by Adam Barth.
2622
2623         * Scripts/webkitpy/common/config/committers.py:
2624
2625 2012-05-23  Xianzhu Wang  <wangxianzhu@chromium.org>
2626
2627         [Chromium-Android] Fix chromium_android_unittest
2628         https://bugs.webkit.org/show_bug.cgi?id=87196
2629
2630         Reviewed by Tony Chang.
2631
2632         Update unit tests after ChromiumAndroidPort supported apk based
2633         DumpRenderTree.
2634
2635         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2636         (ChromiumAndroidPortTest):
2637         (ChromiumAndroidPortTest.mock_run_command_fn): Moved out from test_get_last_stacktrace so that other tests can use it as a common command line handler.
2638         (ChromiumAndroidPortTest.test_get_last_stacktrace):
2639         (ChromiumAndroidPortTest.test_get_crash_log): Added to test our overridden _get_crash_log()
2640         (ChromiumAndroidDriverTest):
2641         (ChromiumAndroidDriverTest.setUp):
2642         (ChromiumAndroidDriverTest.test_cmd_line): Added to test our overridden cmd_line()
2643         (ChromiumAndroidDriverTest.test_write_command_and_read_line): Added test of unexpected EOF (indicating crash on Android)
2644
2645 2012-05-23  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2646
2647         [watchlist] Add myself and create a watch rule to catch Attribute related patches
2648         https://bugs.webkit.org/show_bug.cgi?id=87303
2649
2650         Reviewed by Alexis Menard.
2651
2652         * Scripts/webkitpy/common/config/watchlist:
2653
2654 2012-05-23  Dirk Pranke  <dpranke@chromium.org>
2655
2656         garden-o-matic should not fetch from debug bots if it also knows about the release bots
2657         https://bugs.webkit.org/show_bug.cgi?id=86916
2658
2659         Reviewed by Adam Barth.
2660
2661         This change pushes all of the logic for rebaselining a cluster
2662         of failures (a list of tests failing a list of suffixes on a
2663         list of bots) onto the server, so there is a single call from
2664         the web page; we will then be able to optimize the performance
2665         of the rebaselining better.
2666
2667         Also remove the 'optimizebaseline' entry point on garden-o-matic
2668         (and the client-side call) since we don't need it any more.
2669
2670         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2671         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
2672         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2673         (GardeningHTTPRequestHandler.rebaselineall):
2674         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2675
2676 2012-05-21  Ryosuke Niwa  <rniwa@webkit.org>
2677
2678         Mac DRT should be able to load external URLs for replay performance tests
2679         https://bugs.webkit.org/show_bug.cgi?id=86191
2680
2681         Reviewed by Alexey Proskuryakov.
2682
2683         Let external URL requests go through if the test file is not a local file or hosted at localhost.
2684         e.g. "DumpRenderTree http://webkit.org/" as supposed to "DumpRenderTree test.html" or
2685         "DumpRenderTree http://localhost:8000/".
2686
2687         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2688         (isLocalhost):
2689         (hostIsUsedBySomeTestsToGenerateError):
2690         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2691
2692 2012-05-23  Malcolm MacLeod <malcolm.macleod@tshwanedje.com>
2693
2694         [wx] In wxWebKit release builds on MSW, keep release settings but also build the 
2695         debug symbols for easier debugging.
2696         https://bugs.webkit.org/show_bug.cgi?id=87151
2697
2698         Reviewed by Kevin Ollivier.
2699
2700         * waf/build/settings.py:
2701         (common_configure):
2702
2703 2012-05-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2704
2705         Unreviewed. Move myself to reviewers.
2706
2707         * Scripts/webkitpy/common/config/committers.py:
2708
2709 2012-05-23  Dongwoo Im  <dw.im@samsung.com>
2710
2711         [EFL] Implements the registerProtocolHandler method and option.
2712         https://bugs.webkit.org/show_bug.cgi?id=73638
2713
2714         Reviewed by Andreas Kling.
2715
2716         * Scripts/webkitperl/FeatureList.pm: Turn on the ENABLE_REGISTER_PROTOCOL_HANDLER option as default on EFL port.
2717
2718 2012-05-23  Zan Dobersek  <zandobersek@gmail.com>
2719
2720         [Gtk] EventSender should properly handle (left|right)(control|shift|alt) after r118001
2721         https://bugs.webkit.org/show_bug.cgi?id=87221
2722
2723         Reviewed by Martin Robinson.
2724
2725         Convert leftAlt, leftControl, leftShift, rightAlt, rightControl and
2726         rightShift key names into proper GDK key symbols.
2727
2728         * DumpRenderTree/gtk/EventSender.cpp:
2729         (createKeyPressEvent):
2730
2731 2012-04-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2732
2733         [Qt] Make the web view's url property follow the active url
2734
2735         https://bugs.webkit.org/show_bug.cgi?id=77554
2736
2737         Update  the location bar in the minibrowser to behave
2738         a bit more like normal browsers in terms of when the url will change
2739         and how active focus is handled.
2740
2741         Reviewed by Simon Hausmann.
2742
2743         * MiniBrowser/qt/qml/BrowserWindow.qml:
2744
2745 2012-05-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
2746
2747         [Qt] Remove references to $$QT_SOURCE_TREE
2748
2749         With a modularized Qt, it's ambigious. What we really want is qtbase,
2750         which qtcore is a proxy for (we assume it will always live in qtbase).
2751
2752         Reviewed by Tor Arne Vestbø.
2753
2754         * DumpRenderTree/qt/DumpRenderTree.pro:
2755
2756 2012-05-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
2757
2758         [Qt] Fix qmake conditional for c++-11 compat warnings
2759
2760         Reviewed by Tor Arne Vestbø.
2761
2762         * qmake/mkspecs/features/unix/default_post.prf:
2763
2764 2012-05-23  Christophe Dumez  <christophe.dumez@intel.com>
2765
2766         [EFL] EFL's DRT does not print didFailProvisionalLoadWithError messages
2767         https://bugs.webkit.org/show_bug.cgi?id=85956
2768
2769         Reviewed by Gustavo Noronha Silva.
2770
2771         Catch new "load,provisional,failed" signal and print
2772         didFailProvisionalLoadWithError messages when LayoutTestController's
2773         dumpFrameLoadCallbacks() returns true. Also make sure the
2774         didFailLoadWithError message is not printed in case of provisional
2775         load failure.
2776
2777         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2778         (DumpRenderTreeChrome::createView):
2779         (DumpRenderTreeChrome::onFrameCreated):
2780         (DumpRenderTreeChrome::onFrameProvisionalLoadFailed):
2781         (DumpRenderTreeChrome::onFrameLoadError):
2782         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2783         (DumpRenderTreeChrome):
2784
2785 2012-05-23  Christophe Dumez  <christophe.dumez@intel.com>
2786
2787         [EFL] EFL's DRT needs to call Settings::setValidationMessageTimerMagnification(-1)
2788         https://bugs.webkit.org/show_bug.cgi?id=86366
2789
2790         Reviewed by Antonio Gomes.
2791
2792         Call Settings::setValidationMessageTimerMagnification(-1) between the tests.
2793
2794         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2795         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2796
2797 2012-05-22  Darin Adler  <darin@apple.com>
2798
2799         * Scripts/webkitpy/thirdparty/mod_pywebsocket: Added property svn:ignore.
2800         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake: Added property svn:ignore.
2801
2802 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2803
2804         [Chromium-Android] Run DumpRenderTree as an apk (C++ and gyp part)
2805         https://bugs.webkit.org/show_bug.cgi?id=86922
2806
2807         Because we have new platformInit() in TestShellAndroid.cpp, and
2808         we still need the timeout part in TestShellLinux.cpp, TestShellLinux.cpp
2809         is split into TestShellPosix.cpp and TestShellX11.cpp.
2810
2811         Reviewed by Kent Tamura.
2812
2813         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2814         * DumpRenderTree/DumpRenderTree.gypi:
2815         * DumpRenderTree/chromium/TestShellAndroid.cpp: Added. Handles command lines to redirect stdin/stdout/stderr.
2816         (platformInit):
2817         * DumpRenderTree/chromium/TestShellGtk.cpp: Removed. Merged into TestShellX11.cpp
2818         * DumpRenderTree/chromium/TestShellLinux.cpp: Removed. Split into TestShellPosix.cpp and TestShellX11.cpp.
2819         * DumpRenderTree/chromium/TestShellPosix.cpp: Split from TestShellLinux.cpp, containing the timeout handling part, compiled when os_posix=1 (excluding mac).
2820         (AlarmHandler):
2821         (TestShell::waitTestFinished):
2822         * DumpRenderTree/chromium/TestShellX11.cpp: Split from TestShellLinux.cpp, containing the fontconfig part, compiled when use_x11=1
2823         (openStartupDialog): from TestShellGtk.cpp
2824         (checkLayoutTestSystemDependencies): from TestShellGtk.cpp.
2825         (setupFontconfig):
2826         (platformInit):
2827
2828 2012-05-22  Kangil Han  <kangil.han@samsung.com>
2829
2830         [EFL][DRT] Implement touch event
2831         https://bugs.webkit.org/show_bug.cgi?id=86720
2832
2833         Reviewed by Hajime Morita.
2834
2835         Currently EFL DRT doesn't support touch event.
2836         Therefore, this patch enabled it and implemented some eventSender function callbacks.
2837
2838         * DumpRenderTree/efl/EventSender.cpp:
2839         (TouchEventInfo::TouchEventInfo):
2840         (TouchEventInfo):
2841         (touchPointList):
2842         (sendTouchEvent):
2843         (addTouchPointCallback):
2844         (touchStartCallback):
2845         (updateTouchPointCallback):
2846         (touchMoveCallback):
2847         (cancelTouchPointCallback):
2848         (touchCancelCallback):
2849         (releaseTouchPointCallback):
2850         (touchEndCallback):
2851         (clearTouchPointsCallback):
2852         (setTouchModifierCallback):
2853         * Scripts/webkitperl/FeatureList.pm:
2854
2855 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2856
2857         [Chromium-Android] Fix chromium_android_unittest
2858         https://bugs.webkit.org/show_bug.cgi?id=87196
2859
2860         Not reviewed.
2861         Temporarily disable chromium_android_unittest.
2862
2863         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2864         (ChromiumAndroidPortTest):
2865         (ChromiumAndroidDriverTest):
2866
2867 2012-05-22  Jessie Berlin  <jberlin@apple.com>
2868
2869         WebKitTestRunner needs an implementation of layoutTestController.setDefersLoading
2870         https://bugs.webkit.org/show_bug.cgi?id=64313
2871
2872         Reviewed by Jon Honeycutt.
2873
2874         Add it.
2875
2876         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2877         Make sure to generate the binding.
2878
2879         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2880         (WTR::LayoutTestController::setDefersLoading):
2881         Call WKBundlePageSetDefersLoading.
2882         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2883
2884 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2885
2886         [Chromium-Android] Run DumpRenderTree as an apk (python part)
2887         https://bugs.webkit.org/show_bug.cgi?id=86923
2888
2889         chromium_android.py is modified to support running DumpRenderTree as
2890         an apk, so that we can run the tests (e.g. video) requiring features
2891         implemented in Java on Android.
2892
2893         Reviewed by Adam Barth.
2894
2895         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2896         (ChromiumAndroidPort.__init__):
2897         (ChromiumAndroidPort.default_child_processes):
2898         (ChromiumAndroidPort.check_wdiff):
2899         (ChromiumAndroidPort.check_build):
2900         (ChromiumAndroidPort.start_helper):
2901         (ChromiumAndroidPort.skipped_layout_tests):
2902         (ChromiumAndroidPort):
2903         (ChromiumAndroidPort._path_to_driver):
2904         (ChromiumAndroidPort._get_crash_log):
2905         (ChromiumAndroidPort._push_executable):
2906         (ChromiumAndroidPort._run_adb_command):
2907         (ChromiumAndroidPort._get_last_stacktrace):
2908         (ChromiumAndroidPort._get_logcat):
2909         (ChromiumAndroidPort._setup_performance):
2910         (ChromiumAndroidDriver):
2911         (ChromiumAndroidDriver.__init__):
2912         (ChromiumAndroidDriver._command_wrapper):
2913         (ChromiumAndroidDriver.cmd_line):
2914         (ChromiumAndroidDriver._file_exists_on_device):
2915         (ChromiumAndroidDriver._deadlock_detector):
2916         (ChromiumAndroidDriver._start):
2917         (ChromiumAndroidDriver.run_test):
2918         (ChromiumAndroidDriver.stop):
2919         (ChromiumAndroidDriver._write_command_and_read_line):
2920         (ChromiumAndroidDriver._output_image):
2921         (ChromiumAndroidDriver._get_stderr):
2922
2923 2012-05-22  Joshua Bell  <jsbell@chromium.org>
2924
2925         [Chromium] Reverting r118084 - webkit_tests failing on chromium mac.
2926
2927         Unreviewed gardening.
2928
2929         * Scripts/webkitpy/layout_tests/port/base.py:
2930         (Port.driver_name):
2931         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2932         (ChromiumLinuxPort._path_to_driver):
2933         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2934         (ChromiumPortTest.test_overrides_and_builder_names):
2935         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2936         (ChromiumWinPort._path_to_driver):
2937         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2938         (parse_args):
2939
2940 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2941
2942         [Chromium] Move conditions in DumpRenderTree.gypi into DumpRenderTree.gyp
2943         https://bugs.webkit.org/show_bug.cgi?id=87176
2944
2945         Reviewed by Tony Chang.
2946
2947         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2948         * DumpRenderTree/DumpRenderTree.gypi:
2949
2950 2012-05-22  Jochen Eisinger  <jochen@chromium.org>
2951
2952         [chromium] add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
2953         https://bugs.webkit.org/show_bug.cgi?id=87128
2954
2955         Reviewed by Dirk Pranke.
2956
2957         * Scripts/webkitpy/layout_tests/port/base.py:
2958         (Port.driver_name):
2959         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2960         (ChromiumLinuxPort._path_to_driver):
2961         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2962         (ChromiumPortTest.test_driver_name_option):
2963         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2964         (ChromiumWinPort._path_to_driver):
2965         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2966         (parse_args):
2967
2968 2012-05-22  Jessie Berlin  <jberlin@apple.com>
2969
2970         WTR fix after r118001.
2971
2972         Rubber-stamped by Alexey Proskuryakov.
2973
2974         Update the WTR implementation of keyDown to match the DRT one changed in r118001.
2975
2976         * WebKitTestRunner/mac/EventSenderProxy.mm:
2977         (WTR::EventSenderProxy::keyDown):
2978
2979 2012-05-22  Kausalya Madhusudhanan  <kmadhusu@chromium.org>
2980
2981         [Chromium] Use overloaded printBegin() webkit API to support auto fit to page functionality.
2982         https://bugs.webkit.org/show_bug.cgi?id=86684
2983
2984         Reviewed by Darin Fisher.
2985
2986         * DumpRenderTree/chromium/LayoutTestController.cpp:
2987         (LayoutTestController::numberOfPages):
2988         * DumpRenderTree/chromium/WebViewHost.cpp:
2989         (WebViewHost::printPage):
2990
2991 == Rolled over to ChangeLog-2012-05-22 ==