f4d7701a85dd7281ef0f787264a8faf7719e7666
[WebKit-https.git] / Tools / ChangeLog
1 2011-08-12  Andy Estes  <aestes@apple.com>
2
3         allowRoundingHacksCallback uses the wrong argument for 'thisObject'.
4         https://bugs.webkit.org/show_bug.cgi?id=66158
5
6         Reviewed by Dan Bernstein.
7
8         * DumpRenderTree/LayoutTestController.cpp:
9         (allowRoundingHacksCallback): The third argument is the 'this'
10         JSObjectRef, not the second.
11
12 2011-08-12  Andy Estes  <aestes@apple.com>
13
14         Cancel in onbeforeunload dialog sometime causes a button to stop working.
15         https://bugs.webkit.org/show_bug.cgi?id=26211
16
17         Reviewed by Alexey Proskuryakov.
18
19         Implement a new LayoutTestController method that a test can call to set
20         the return value of DumpRenderTree's beforeunload UI delegate.
21
22         * DumpRenderTree/LayoutTestController.cpp:
23         (LayoutTestController::LayoutTestController): Initialize
24         m_shouldStayOnPageAfterHandlingBeforeUnload.
25         (setShouldStayOnPageAfterHandlingBeforeUnloadCallback): Call
26         LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload().
27         (LayoutTestController::staticFunctions): Register
28         'setShouldStayOnPageAfterHandlingBeforeUnload' as a static function.
29         * DumpRenderTree/LayoutTestController.h: 
30         (LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload):
31         (LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
32         * DumpRenderTree/chromium/LayoutTestController.cpp:
33         (LayoutTestController::LayoutTestController): Initialize
34         m_shouldStayOnPageAfterHandlingBeforeUnload and bind
35         'setShouldStayOnPageAfterHandlingBeforeUnload' to its c++ setter.
36         (LayoutTestController::reset): Reset
37         m_shouldStayOnPageAfterHandlingBeforeUnload to false.
38         (LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
39         Set m_shouldStayOnPageAfterHandlingBeforeUnload to the value passed in
40         from JavaScript.
41         * DumpRenderTree/chromium/LayoutTestController.h:
42         (LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload):
43         * DumpRenderTree/chromium/WebViewHost.cpp:
44         (WebViewHost::runModalBeforeUnloadDialog): Add the correct logging and
45         return the inverse of
46         LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload().
47         * DumpRenderTree/mac/UIDelegate.mm:
48         (-[UIDelegate webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:]): Ditto.
49         * DumpRenderTree/win/UIDelegate.cpp:
50         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
51         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
52         Define setShouldStayOnPageAfterHandlingBeforeUnload().
53         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
54         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue): Post a message
55         to the Test Controller telling it what value it should return in its
56         onbeforeunload UI delegate.
57         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
58         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
59         (WTR::LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
60         Call InjectedBundle::postNewBeforeUnloadReturnValue().
61         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
62         * WebKitTestRunner/TestController.cpp:
63         (WTR::TestController::TestController): Initialize
64         m_beforeUnloadReturnValue to true.
65         (WTR::runBeforeUnloadConfirmPanel): Add the correct logging and return
66         the value of TestController::beforeUnloadReturnValue().
67         (WTR::TestController::resetStateToConsistentValues): Reset
68         m_beforeUnloadReturnValue to true.
69         * WebKitTestRunner/TestController.h:
70         (WTR::TestController::beforeUnloadReturnValue):
71         (WTR::TestController::setBeforeUnloadReturnValue):
72         * WebKitTestRunner/TestInvocation.cpp:
73         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the
74         message posted from the injected bundle by retrieving the message body
75         as a WKBoolean and calling TestController::setBeforeUnloadReturnValue().
76
77 2011-08-12  Sam Weinig  <sam@webkit.org>
78
79         Move compiler specific macros to their own header
80         https://bugs.webkit.org/show_bug.cgi?id=66119
81
82         Reviewed by Anders Carlsson.
83
84         * DumpRenderTree/ForwardingHeaders/wtf/Compiler.h: Added.
85
86 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
87
88         Add a way to extend DOM objects in garden-o-matic.
89         https://bugs.webkit.org/show_bug.cgi?id=66096
90
91         Reviewed by Adam Barth.
92
93         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added base.extends.
94         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added tests.
95
96 2011-08-11  MORITA Hajime  <morrita@google.com>
97
98         [Chromium][DRT] editing/spelling/spelling-backspace-between-lines.html fails
99         https://bugs.webkit.org/show_bug.cgi?id=45438
100
101         Reviewed by Kent Tamura.
102
103         MockSpellCheck was assuming the input of spellCheckWord() is a word.
104         But it can be a series of word. This change made spellCheckWord()
105         understand simple word boundary which appears in tests.
106         
107         * DumpRenderTree/chromium/MockSpellCheck.cpp:
108         (MockSpellCheck::spellCheckWord):
109
110 2011-08-11  Mark Rowe  <mrowe@apple.com>
111
112         Rework some Makefile logic to remove a double-negative.
113
114         Reviewed by Jon Honeycutt.
115
116         * DumpRenderTree/mac/PerlSupport/Makefile:
117
118 2011-08-11  Anders Carlsson  <andersca@apple.com>
119
120         Add a FIXME.
121
122         * TestWebKitAPI/TestsController.cpp:
123         (TestWebKitAPI::TestsController::TestsController):
124
125 2011-08-11  Anders Carlsson  <andersca@apple.com>
126
127         Initialize threading before running any tests
128         https://bugs.webkit.org/show_bug.cgi?id=66112
129
130         Reviewed by Adam Barth.
131
132         * TestWebKitAPI/TestsController.cpp:
133         (TestWebKitAPI::TestsController::TestsController):
134
135 2011-08-11  Adam Barth  <abarth@webkit.org>
136
137         Add unexpected-passes.html to TestFailures for marking tests as passing
138         https://bugs.webkit.org/show_bug.cgi?id=66102
139
140         Reviewed by Dimitri Glazkov.
141
142         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
143         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
144             - Move some code into the library so it can be shared.
145         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
146         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
147         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
148             - Add round-trip unit tests.
149         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Added.
150         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js: Added.
151             - I'm not entirely sure this feature should remain a separate HTML
152               file, but it seemed better than cluttering up the main HTML file
153               with too much extra stuff.
154         * Scripts/webkitpy/tool/servers/gardeningserver.py:
155         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
156             - The gardening server couldn't handle adding PASS expectations.  Now it can.
157
158 2011-08-11  Eric Seidel  <eric@webkit.org>
159
160         NRWT has wrong fallback order for Mac now that Lion exists
161         https://bugs.webkit.org/show_bug.cgi?id=66093
162
163         Reviewed by Adam Barth.
164
165         ORWT used a different system for fallback orders than NRWT did.
166         I moved win.py to match ORWT fallback orders in bug 64486.
167         This bug moves mac.py to match ORWT fallback order
168         and adds 'lion' as a supported OS version.
169
170         Because ChromiumMac shares OS version detection code with AppleMac
171         this also added support for 'lion' to chromium mac.  Hopefully that's a good thing.
172
173         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
174         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
175         * Scripts/webkitpy/layout_tests/port/mac.py:
176         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
177         * Scripts/webkitpy/layout_tests/port/win.py:
178
179 2011-08-11  Adam Barth  <abarth@webkit.org>
180
181         Update test results now that we use absolute URLs.
182
183         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
184
185 2011-08-11  Adam Barth  <abarth@webkit.org>
186
187         garden-o-matic should be able to determine when tests unexpectedly pass
188         https://bugs.webkit.org/show_bug.cgi?id=66092
189
190         Reviewed by Dimitri Glazkov.
191
192         This patch just contains the library methods for extracting this
193         information.  I'll add some UI in a subsequent patch.
194
195         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
196         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
197
198 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
199
200         New expectation entries should be placed next to existing ones.
201         https://bugs.webkit.org/show_bug.cgi?id=66066
202
203         Reviewed by Adam Barth.
204
205         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added the notion of insertion point,
206             which is computed as the last found reference to the same test.
207         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added and adjusted unit tests.
208
209 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
210
211         Unreviewed, rolling out r92847.
212         http://trac.webkit.org/changeset/92847
213         https://bugs.webkit.org/show_bug.cgi?id=65986
214
215         Broke check-webkit-style
216
217         * Scripts/webkitpy/style/checker.py:
218         * Scripts/webkitpy/style/checker_unittest.py:
219
220 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
221
222         Unreviewed, rolling out r92847.
223         http://trac.webkit.org/changeset/92847
224         https://bugs.webkit.org/show_bug.cgi?id=65986
225
226         Broke check-webkit-style
227
228         * Scripts/webkitpy/style/checker.py:
229         * Scripts/webkitpy/style/checker_unittest.py:
230
231 2011-08-11  Pierre Rossi  <pierre.rossi@gmail.com>
232
233         [Qt] autotests shouldn't require config.h in the style check
234         https://bugs.webkit.org/show_bug.cgi?id=65986
235
236         Remove the include rules from the style-check for Qt tests.
237         Since for the most part it's just a matter of using the
238         API provided by QtWebKit, enforcing the WebCore set of rules
239         only seems to make sense in the case of MIMESniffing.
240
241         Reviewed by Benjamin Poulain.
242
243         * Scripts/webkitpy/style/checker.py:
244         * Scripts/webkitpy/style/checker_unittest.py:
245
246 2011-08-11  Zsolt Fehér  <h490267@stud.u-szeged.hu>
247
248         [WK2] Implement waitForPolicyDelegate
249         https://bugs.webkit.org/show_bug.cgi?id=42330
250
251         Reviewed by Csaba Osztrogonác.
252
253         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
254         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
255         (WTR::navigationTypeToString):
256         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
257         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
258         (WTR::LayoutTestController::LayoutTestController):
259         (WTR::LayoutTestController::setCustomPolicyDelegate):
260         (WTR::LayoutTestController::waitForPolicyDelegate):
261         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
262         (WTR::LayoutTestController::isPolicyDelegateEnabled):
263         (WTR::LayoutTestController::isPolicyDelegatePermissive):
264
265 2011-08-11  Adam Barth  <abarth@webkit.org>
266
267         rebaseline-expectations should use the release bots, not the debug
268         bots.  The debug bots don't all run all the tests.  Also, delay
269         updating test_expectations a long as possible to avoid clearing out
270         lines that we'll need for other ports.
271
272         * Scripts/webkitpy/layout_tests/port/builders.py:
273         * Scripts/webkitpy/tool/commands/rebaseline.py:
274         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
275
276 2011-08-10  Ryosuke Niwa  <rniwa@webkit.org>
277
278         r92792 inadvertently removed PlatformSpecificScheduler for all Snow Leopard bots.
279         Revert it partially so that the remaining Snow Leopard bots can fulfill their duty.
280
281         * BuildSlaveSupport/build.webkit.org-config/config.json:
282
283 2011-08-10  Eric Seidel  <eric@webkit.org>
284
285         new-run-webkit-test's WinPort has no fallback logic
286         https://bugs.webkit.org/show_bug.cgi?id=64486
287
288         Unreviewed.
289
290         Turns out that we've long had a subtle bug whereby if you didn't
291         already have DumpRenderTree built, we might end up running unsupported tests
292         because the DumpRenderTree --print-supported-features check would silently fail.
293
294         When I moved the call from using popen to using Executive.run_command, this silent
295         failure became noisy.  (Breaking some bots.)
296
297         This re-orders our steps so that we always build DRT before collecting expectations,
298         as well as adds a warning message when DumpRenderTree can't be found.
299
300         * Scripts/webkitpy/layout_tests/port/webkit.py:
301         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
302
303 2011-08-10  Eric Seidel  <eric@webkit.org>
304
305         new-run-webkit-test's WinPort has no fallback logic
306         https://bugs.webkit.org/show_bug.cgi?id=64486
307
308         Unreviewed.  Fix test-webkitpy under Python 2.5.
309
310         * Scripts/webkitpy/layout_tests/port/win.py:
311
312 2011-08-10  Benjamin Poulain  <benjamin@webkit.org>
313
314         [Qt][WK2] MiniBrowser is firing twice the QDesktopWebView::mousePressEvent method
315         https://bugs.webkit.org/show_bug.cgi?id=65875
316
317         Reviewed by Kenneth Rohde Christiansen.
318
319         For some reason, QWidget send fake mouse event on some platform, under certains conditions.
320
321         This causes mouse events to be sent twice in some cases. We work around the problem
322         by defining the first touch point to be a primary touch point (case which hit some
323         weird condition in QWidget, skipping the generation of fake mouse events).
324
325         * MiniBrowser/qt/MiniBrowserApplication.cpp:
326         (MiniBrowserApplication::notify):
327
328 2011-08-10  David Hyatt  <hyatt@apple.com>
329
330         https://bugs.webkit.org/show_bug.cgi?id=66004
331
332         Remove the regions and exclusions bots and also the flags in build-webkit, since I'm just turning
333         the code on by default.
334
335         Reviewed by Adam Roben.
336
337         * BuildSlaveSupport/build.webkit.org-config/config.json:
338         * Scripts/build-webkit:
339
340 2011-08-10  Oliver Hunt  <oliver@apple.com>
341
342         JSEvaluteScript does not return the correct object when given JSONP data
343         https://bugs.webkit.org/show_bug.cgi?id=66003
344
345         Reviewed by Gavin Barraclough.
346
347         Add a test case.
348
349         * DumpRenderTree/mac/DumpRenderTree.mm:
350         (testStringByEvaluatingJavaScriptFromString):
351
352 2011-08-10  Eric Seidel  <eric@webkit.org>
353
354         WIN: NRWT runs compositing tests on configurations that don't support compositing
355         https://bugs.webkit.org/show_bug.cgi?id=64472
356
357         Reviewed by Adam Barth.
358
359         I think the code was just wrong.  It was never splitting the string
360         into list pieces before.
361         I've now tested the supported_features code and theoretically it
362         should now work with Windows DRT.
363
364         I also made the list-lookup functions always return lists, to make
365         it possible to clean up the list-transform code in the future
366         (I opted not to do that cleanup in this patch, but at least now
367         both types of feature lookup functions match return types.)
368
369         * Scripts/webkitpy/layout_tests/port/webkit.py:
370         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
371
372 2011-08-10  Eric Seidel  <eric@webkit.org>
373
374         Clean up ChromiumDriver a little
375         https://bugs.webkit.org/show_bug.cgi?id=65995
376
377         Unreviewed.
378
379         Fix NRWT for chromium.  Silly python.
380
381         * Scripts/webkitpy/layout_tests/port/chromium.py:
382
383 2011-08-10  Eric Seidel  <eric@webkit.org>
384
385         Clean up ChromiumDriver a little
386         https://bugs.webkit.org/show_bug.cgi?id=65995
387
388         Reviewed by Adam Barth.
389
390         - We no longer support threading, so remove threading specific code.
391         - Add FIXMEs about using ServerProcess instead.
392         - Condense option-mapping if-cascade into a for loop.
393         - Unindent long if blocks by using early return.
394         - Unwrap lines which are needlessly wrapped.
395
396         There should be no functional changes here, just code cleanup/dead-code removal.
397
398         * Scripts/webkitpy/layout_tests/port/chromium.py:
399
400 2011-08-10  Dimitri Glazkov  <dglazkov@chromium.org>
401
402         Unmuddle construction options for TestConfiguration.
403         https://bugs.webkit.org/show_bug.cgi?id=65988
404
405         The TestConfiguration instance is now constructed only using actual values.
406         Port-based construction is split into a "from_port" class method.
407
408         Reviewed by Eric Seidel.
409
410         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added TestConfiguration.from_port
411         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Adjusted code to accommodate the change.
412         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
413         * Scripts/webkitpy/layout_tests/port/base.py: Ditto.
414         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Ditto.
415
416 2011-08-10  Eric Seidel  <eric@webkit.org>
417
418         Leaks bot shows python logging prefixes as part of summary display
419         https://bugs.webkit.org/show_bug.cgi?id=65931
420
421         Reviewed by Adam Barth.
422
423         The big part of this change is adding a unittesting system for
424         master.cfg, so mere-mortals can make changes to build.webkit.org
425         with greatly-reduced risk of breaking the world.
426
427         Turns out that in typing up my trival logging fix I made 2 typos,
428         so hopefully the hour spent getting master.cfg to load was worth it. :)
429
430         I also tried to make mastercfg_unittest run as part of test-webkitpy
431         but right now test-webkitpy requires that unittest files be located in
432         a module-name-compatible directory.  'build.webkit.org-config' is not
433         a valid module name.
434
435         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
436          - Fixed _parseNewRunWebKitTestsOutput to strip NRWT's python formatter prefix
437            by using a new _strip_python_logging_prefix function.
438          - Also fixed this function to file to work with a more modern
439            simplejson version (which returns unicode objects instead of str objects)
440            and filed a related bug with buildbot.net due to their handling of unicode builder names.
441         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Added.
442          - BuildBotConfigLoader is a huge pile of code just to get master.cfg to load.
443          - The actual tiny unittest of the new _parseNewRunWebKitTestsOutput logic.
444         * Scripts/webkitpy/thirdparty/__init__.py:
445          - Add autoinstallation of buildbot (and jinja2) for use by mastercfg_unittest.py
446
447 2011-08-09  Dimitri Glazkov  <dglazkov@chromium.org>
448
449         garden-o-matic should extrapolate failures given a set of known results
450         https://bugs.webkit.org/show_bug.cgi?id=65882
451
452         Reviewed by Adam Barth.
453
454         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Spuriously covered my old sins.
455         * Scripts/webkitpy/layout_tests/port/builders.py: Augmented builders dictionary to contain build coverage specifiers,
456             adjusted all call sites.
457         * Scripts/webkitpy/tool/servers/gardeningserver.py: Added BuildCoverageExtrapolator, a thing that
458             makes wider net for specific failures.
459         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added unit tests.
460
461 2011-08-10  Adam Barth  <abarth@webkit.org>
462
463         The URL we were computing for retrieving baselines was missing a slash
464         character because our mocks had an extra slash character.  I've
465         corrected both the code and the mock.
466
467         * Scripts/webkitpy/tool/commands/rebaseline.py:
468         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
469         * Scripts/webkitpy/tool/mocktool.py:
470
471 2011-08-09  Adam Barth  <abarth@webkit.org>
472
473         Move the quote mark to the right place.
474
475         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
476
477 2011-08-09  Adam Barth  <abarth@webkit.org>
478
479         garden-o-matic should use huerstics to narrow regression range
480         https://bugs.webkit.org/show_bug.cgi?id=65948
481
482         Reviewed by Dimitri Glazkov.
483
484         When analyzing a regression range, if one of the commit messages
485         mentions the test in question, we now hueristically assume that
486         revision caused the failure.  (I'm shamelessly stealing this idea from
487         TestFailures.)
488
489         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
490
491 2011-07-13  Eric Seidel  <eric@webkit.org>
492
493         new-run-webkit-test's WinPort has no fallback logic
494         https://bugs.webkit.org/show_bug.cgi?id=64486
495
496         Reviewed by Adam Roben.
497
498         I've tried to write a patch for bug 64439 twice now, and both times
499         I've ended up re-writing half the port system.  So I'm breaking
500         things up into smaller pieces, this being the first.
501
502         WinPort still does not have any port_name parsing, so when instantiated
503         with the name "win-xp" (i.e. by the rebaseline server) it will just behave as the 'win' port.
504         I'll fix this in a second pass when I standardize port_name parsing for all webkit ports.
505
506         Otherwise this should "just work" for windows.  I've not been able to test the
507         version detection on my mac, but the unit tests show the code behaving as designed.
508
509         * Scripts/webkitpy/layout_tests/port/win.py:
510         * Scripts/webkitpy/layout_tests/port/win_unittest.py: Added.
511
512 2011-08-09  Adam Barth  <abarth@webkit.org>
513
514         Teach build.webkit.org's garden-o-matic how to talk to the local server
515         https://bugs.webkit.org/show_bug.cgi?id=65940
516
517         Reviewed by Dimitri Glazkov.
518
519         After this patch, the version of garden-o-matic on build.webkit.org is
520         fully functional.  It can interact with the local server via CORS.
521
522         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
523         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
524         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
525         * Scripts/webkitpy/tool/commands/gardenomatic.py:
526         * Scripts/webkitpy/tool/servers/gardeningserver.py:
527
528 2011-08-09  Adam Barth  <abarth@webkit.org>
529
530         Enable CORS for garden-o-matic
531         https://bugs.webkit.org/show_bug.cgi?id=65936
532
533         Reviewed by Dimitri Glazkov.
534
535         This patch will allow the hosted instance of garden-o-matic to
536         communicate with the local server.
537
538         * Scripts/webkitpy/tool/servers/gardeningserver.py:
539         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
540
541 2011-08-09  Adam Barth  <abarth@webkit.org>
542
543         Upgrade jquery in TestFailures
544         https://bugs.webkit.org/show_bug.cgi?id=65935
545
546         Reviewed by Dimitri Glazkov.
547
548         Upgrade to a newer version of jQuery with better support for CORS and CSP.
549
550         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
551         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
552         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
553
554 2011-08-09  Sheriff Bot  <webkit.review.bot@gmail.com>
555
556         Unreviewed, rolling out r92683.
557         http://trac.webkit.org/changeset/92683
558         https://bugs.webkit.org/show_bug.cgi?id=65921
559
560          "Breaks Qt --minimal build. Revert pending update of the Qt
561         minimal configuration" (Requested by simathur on #webkit).
562
563         * QtTestBrowser/cookiejar.cpp:
564         (TestBrowserCookieJar::TestBrowserCookieJar):
565         * QtTestBrowser/launcherwindow.cpp:
566         (LauncherWindow::createChrome):
567         (LauncherWindow::setDiskCache):
568         * QtTestBrowser/main.cpp:
569         (LauncherApplication::handleUserOptions):
570         * QtTestBrowser/webpage.cpp:
571         (WebPage::openUrlInDefaultBrowser):
572
573 2011-08-09  Siddharth Mathur  <siddharth.mathur@nokia.com>
574
575         [Qt] Simplify code by removing QT_NO_DESKTOPSERVICES and QT_NO_NETWORKDISKCACHE
576         https://bugs.webkit.org/show_bug.cgi?id=65880
577
578         Reviewed by Andreas Kling.
579
580         QDesktopServices and QNetworkDiskCache have been around for a while now. Kill flags which 
581         check for their feature flags. Assume that any reasonable Qt build provides them. 
582         * QtTestBrowser/cookiejar.cpp:
583         (TestBrowserCookieJar::TestBrowserCookieJar):
584         * QtTestBrowser/launcherwindow.cpp:
585         (LauncherWindow::createChrome):
586         (LauncherWindow::setDiskCache):
587         * QtTestBrowser/main.cpp:
588         (LauncherApplication::handleUserOptions):
589         * QtTestBrowser/webpage.cpp:
590         (WebPage::openUrlInDefaultBrowser):
591
592 2011-08-09  Adam Barth  <abarth@webkit.org>
593
594         BaselineOptimizer created the wrong baseline for fast/js/regexp-overflow.html
595         https://bugs.webkit.org/show_bug.cgi?id=65891
596
597         Reviewed by Eric Seidel.
598
599         The problem was that platform/chromium contained a bogus expectation
600         file that needed to be removed, but by the time we got around to
601         removing it, we'd already moved the correct baseline into its place.
602         After this patch, we copy the gold results into memory before
603         reshuffling things on disk (and we delete bad things before adding good
604         things).
605
606         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
607         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
608
609 2011-08-08  Adam Barth  <abarth@webkit.org>
610
611         Chromium Windows bots can't figure out what SVN revision they're running
612         https://bugs.webkit.org/show_bug.cgi?id=65893
613
614         Reviewed by Eric Seidel.
615
616         The comment in _engage_awesome_windows_hacks explains why we're making
617         this change.  It's ugly and rediculous, but this approach seems better
618         than using shell=True when calling popen.
619
620         * Scripts/webkitpy/common/checkout/scm/svn.py:
621         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
622
623 2011-08-08  Adam Barth  <abarth@webkit.org>
624
625         Remove deduplicate-tests
626         https://bugs.webkit.org/show_bug.cgi?id=65886
627
628         Reviewed by Tony Chang.
629
630         This script is redundant with "webkit-patch bulk-optimize-baselines",
631         which can find many more duplicates than deduplicate-tests because
632         bulk-optimize-baselines can move results around whereas
633         deduplicate-tests can only remove results.
634
635         * Scripts/deduplicate-tests: Removed.
636         * Scripts/webkitpy/to_be_moved/deduplicate_tests.py: Removed.
637         * Scripts/webkitpy/to_be_moved/deduplicate_tests_unittest.py: Removed.
638
639 2011-08-08  Adam Barth  <abarth@webkit.org>
640
641         scm.delete should delete empty parent directories as well
642         https://bugs.webkit.org/show_bug.cgi?id=65878
643
644         Reviewed by Eric Seidel.
645
646         This behavior makes SVN match GIT (which has no concept of empty
647         directories).  This bug comes up a lot when optimizing baselines, which
648         often create empty directories when we're able to optimize everything
649         out of a given folder.
650
651         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
652         * Scripts/webkitpy/common/checkout/scm/svn.py:
653
654 2011-08-08  Lucas Forschler  <lforschler@apple.com>
655
656         Add triggers for Lion WK2 test bots.
657
658         Reviewed by Stephanie Lewis.
659
660         * BuildSlaveSupport/build.webkit.org-config/config.json:
661
662 2011-08-08  Adam Barth  <abarth@webkit.org>
663
664         bulk-optimize-baselines should take directories on the command line
665         https://bugs.webkit.org/show_bug.cgi?id=65879
666
667         Reviewed by Dimitri Glazkov.
668
669         Passing lists of tests via stdin is a pain.  It's easier if the command
670         takes a list of tests on the command line, like run-webkit-tests.
671
672         * Scripts/webkitpy/tool/commands/rebaseline.py:
673
674 2011-08-08  Adam Barth  <abarth@webkit.org>
675
676         Deprecate rebaseline-chromium-webkit-tests
677         https://bugs.webkit.org/show_bug.cgi?id=65873
678
679         Reviewed by Dimitri Glazkov.
680
681         This script never worked correctly and now is redundant with more
682         modern infrastructure for rebaselining tests.  This patch deprecates
683         the script in order to flush out any issues with the new tools.  Once
684         folks are happy with the new tools, we'll delete this script.
685
686         * Scripts/rebaseline-chromium-webkit-tests:
687
688 2011-08-08  Dimitri Glazkov  <dglazkov@chromium.org>
689
690         garden-o-matic should only touch expectations that need updating.
691         https://bugs.webkit.org/show_bug.cgi?id=65876
692
693         Reviewed by Adam Barth.
694
695         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added reconstitute_only_these to TestExpectationSerializer.list_to_string,
696             so that a caller could influence which lines to serialize from values.
697         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests.
698         * Scripts/webkitpy/tool/servers/gardeningserver.py: Started using reconstitute_only_these.
699         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added tests.
700
701 2011-08-08  Dimitri Glazkov  <dglazkov@chromium.org>
702
703         TestExpectationsEditor should return a list of updated expectations.
704         https://bugs.webkit.org/show_bug.cgi?id=65872
705
706         Reviewed by Adam Barth.
707
708         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added a list to store lines that are being updated.
709         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed tests to account for updated lines.
710
711 2011-08-08  Jochen Eisinger  <jochen@chromium.org>
712
713         Fix SCM webkitpy unit test failures
714         https://bugs.webkit.org/show_bug.cgi?id=65823
715
716         Reviewed by Eric Seidel.
717
718         * Scripts/webkitpy/common/checkout/scm/git.py:
719         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
720
721 2011-08-08  Eric Seidel  <eric@webkit.org>
722
723         Move the --leaks bot back over to NRWT now that I'm back
724         from vacation and able to debug it.
725
726         Unreviewed.
727
728         * Scripts/run-webkit-tests:
729         (usingWebKit2):
730         (useNewRunWebKitTests):
731
732 2011-08-05  Dimitri Glazkov  <dglazkov@chromium.org>
733
734         Wire up updating expectations in garden-o-matic.
735         https://bugs.webkit.org/show_bug.cgi?id=65794
736
737         Reviewed by Adam Barth.
738
739         * Scripts/webkitpy/layout_tests/port/factory.py: Moved _port_for_builder from rebaseline.py to here, rename to get_from_builder_name.
740         * Scripts/webkitpy/tool/commands/rebaseline.py: Adapted callsites to new location.
741         * Scripts/webkitpy/tool/servers/gardeningserver.py: Added GardeningExpectationsUpdater, which knows how to update expectations.
742         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added loads of tests.
743
744 2011-08-08  Jochen Eisinger  <jochen@chromium.org>
745
746         webkit-patch doesn't get along with renamed files
747         https://bugs.webkit.org/show_bug.cgi?id=48075
748
749         Possibly a bit heavy handed - I removed all instances of -C and
750         changed every instance of -M with '--no-renames' in git.py. This
751         forces git to not try to tell us about renames at all, which is
752         ultimately the behaviour we want. The old file is shown deleted,
753         then the new file is shown added, followed by any changes that
754         occurred. Also gets rid of the problem where deleting one file
755         and adding another file which has similar content would
756         unexpectedly show up as a rename, and fall out of a diff.
757
758         Based on a patch by Wyatt Carss.
759
760         Reviewed by Eric Seidel.
761
762         * Scripts/webkitpy/common/checkout/scm/git.py:
763
764 2011-08-07  Sam White  <samuel.white@rochester.edu>
765
766         Add the ability to search the AccessibilityObject cache
767         https://bugs.webkit.org/show_bug.cgi?id=64994
768         
769         Added testing support for AccessibilityObject cache searching. Currently,
770         only the mac platform is full supported and has had API exposed. Other
771         platforms have only have this new functionality stubbed. Full implementation
772         is a job suited only for an accessibility expert of each respective platform.
773
774         Reviewed by Chris Fleizach.
775
776         * DumpRenderTree/AccessibilityUIElement.cpp:
777         (uiElementForSearchPredicateCallback):
778         (AccessibilityUIElement::getJSClass):
779         * DumpRenderTree/AccessibilityUIElement.h:
780         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
781         (AccessibilityUIElement::uiElementForSearchPredicate):
782         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
783         (AccessibilityUIElement::uiElementForSearchPredicate):
784         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
785         (AccessibilityUIElement::uiElementForSearchPredicate):
786
787 2011-08-06  Adam Barth  <abarth@webkit.org>
788
789         Remove dead code in webkitpy
790         https://bugs.webkit.org/show_bug.cgi?id=65818
791
792         Reviewed by Dimitri Glazkov.
793
794         This code was added to support the rebaseline2 command six months ago,
795         but the rebaseline2 command was never finished and no one else has used
796         this code since it was landed.  This patch removes the dead code.  If
797         we revive rebaseline2, then we can revert this patch and recover the
798         code.  Until then, this code is just dead weight.
799
800         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
801         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
802         * Scripts/webkitpy/common/net/testoutput.py: Removed.
803         * Scripts/webkitpy/common/net/testoutput_unittest.py: Removed.
804         * Scripts/webkitpy/common/net/testoutputset.py: Removed.
805         * Scripts/webkitpy/common/net/testoutputset_unittest.py: Removed.
806         * Scripts/webkitpy/common/system/directoryfileset.py: Removed.
807         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Removed.
808         * Scripts/webkitpy/layout_tests/port/base.py:
809         * Scripts/webkitpy/layout_tests/port/chromium.py:
810         * Scripts/webkitpy/layout_tests/port/webkit.py:
811
812 2011-08-06  Adam Barth  <abarth@webkit.org>
813
814         webkit-patch optimize-baselines can't handle promotions to base results directory
815         https://bugs.webkit.org/show_bug.cgi?id=65819
816
817         Reviewed by Dimitri Glazkov.
818
819         This bug came up when testing the optimizer on some editing baselines.
820
821         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
822         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
823
824 2011-08-06  Adam Barth  <abarth@webkit.org>
825
826         Add a small command to optimize baselines in bulk.
827
828         * Scripts/webkitpy/tool/commands/rebaseline.py:
829
830 2011-08-05  Dimitri Glazkov  <dglazkov@chromium.org>
831
832         Fix unit test breakage by plumbing convert_404_to_None in MockWeb.
833
834         * Scripts/webkitpy/tool/mocktool.py: Added missing parameter to MockWeb.get_binary
835
836 2011-08-05  Dimitri Glazkov  <dglazkov@chromium.org>
837
838         Garden-o-matic updateexpectations needs a unit test.
839         https://bugs.webkit.org/show_bug.cgi?id=65780
840
841         Reviewed by Adam Barth.
842
843         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added unit test.
844
845 2011-08-05  Anders Carlsson  <andersca@apple.com>
846
847         Future proof an Objective-C test
848         https://bugs.webkit.org/show_bug.cgi?id=65788
849
850         Reviewed by Dan Bernstein.
851
852         Add isObjectInstanceOf to ObjCController.
853
854         * DumpRenderTree/mac/ObjCController.m:
855         (+[ObjCController isSelectorExcludedFromWebScript:]):
856         (+[ObjCController webScriptNameForSelector:]):
857         (-[ObjCController isObject:instanceOf:]):
858
859 2011-08-05  Adam Barth  <abarth@webkit.org>
860
861         trac.js needs unittests
862         https://bugs.webkit.org/show_bug.cgi?id=65673
863
864         Reviewed by Dimitri Glazkov.
865
866         This tests also have somewhat large fixtures.  I've trimmed the example
867         XML down a bunch while still hitting interesting cases in the parsing.
868
869         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
870         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Added.
871
872 2011-08-05  Adam Barth  <abarth@webkit.org>
873
874         Rebuild rebaseline-chromium-webkit-tests on top of modern infrastructure
875         https://bugs.webkit.org/show_bug.cgi?id=65759
876
877         Reviewed by Dimitri Glazkov.
878
879         rebaseline-chromium-webkit-tests doesn't really fit into webkitpy's
880         architecture, is poorly tested, and has a bunch of quirks.  This patch
881         rebuilds the core functionality of rebaseline-chromium-webkit-tests on
882         top of more modern infrastructure.  In the process, we get more code
883         re-use and better testing.
884
885         Once we're satisfied with this new implementation, we can delete the
886         old implementation.
887
888         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
889         * Scripts/webkitpy/common/net/web.py:
890         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
891         * Scripts/webkitpy/layout_tests/port/builders.py:
892         * Scripts/webkitpy/layout_tests/port/chromium.py:
893         * Scripts/webkitpy/layout_tests/port/factory.py:
894         * Scripts/webkitpy/layout_tests/port/webkit.py:
895         * Scripts/webkitpy/tool/commands/rebaseline.py:
896         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
897
898 2011-08-05  Anders Carlsson  <andersca@apple.com>
899
900         Remove PluginHalter
901         https://bugs.webkit.org/show_bug.cgi?id=65729
902
903         Reviewed by Darin Adler.
904
905         Remove call to set the allowed plug-in run time.
906
907         * DumpRenderTree/mac/DumpRenderTree.mm:
908         (resetDefaultsToConsistentValues):
909
910 2011-08-05  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
911
912         Unreviewed build fix for Qt-Minimal buildbot
913
914         Use ~/.QtTestBrowser for the cookiejar when QDesktopServices
915         is disabled.
916
917         Rubber-stamped by Holger Freyther.
918
919         * QtTestBrowser/cookiejar.cpp:
920         (TestBrowserCookieJar::TestBrowserCookieJar):
921
922 2011-08-05  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
923
924         [Qt] QtTestBrowser: Add support for saving cookies on disk
925         https://bugs.webkit.org/show_bug.cgi?id=65328
926
927         Simple cookiejar that saves cookies on disk.
928
929         Added menu options to clear cookies (Edit->Clear cookies) and
930         disable disk cookies (Settings->[ ]Save Cookies on Disk).
931
932         Option -no-disk-cookies is also available.
933
934         Reviewed by Andreas Kling.
935
936         * QtTestBrowser/QtTestBrowser.pro:
937         * QtTestBrowser/cookiejar.cpp: Added.
938         * QtTestBrowser/cookiejar.h: Added.
939         * QtTestBrowser/launcherwindow.cpp:
940         * QtTestBrowser/launcherwindow.h:
941         * QtTestBrowser/main.cpp:
942
943 2011-08-04  Adam Barth  <abarth@webkit.org>
944
945         model.js needs some unit testing
946         https://bugs.webkit.org/show_bug.cgi?id=65730
947
948         Reviewed by Dimitri Glazkov.
949
950         These tests do not cover all the functions exported by the model
951         module.  We'll need to add the remaining ones in the future.
952
953         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Added.
954         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
955
956 2011-08-04  Adam Barth  <abarth@webkit.org>
957
958         Another speculative fix for the "svn revision on Windows" problem.
959
960         * Scripts/webkitpy/common/checkout/scm/git.py:
961
962 2011-08-04  Mark Rowe  <mrowe@apple.com>
963
964         Future-proof Xcode configuration settings.
965
966         * DumpRenderTree/mac/Configurations/Base.xcconfig:
967         * DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig:
968         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
969         * MiniBrowser/Configurations/Base.xcconfig:
970         * MiniBrowser/Configurations/CompilerVersion.xcconfig:
971         * MiniBrowser/Configurations/DebugRelease.xcconfig:
972         * TestWebKitAPI/Configurations/Base.xcconfig:
973         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
974         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
975         * WebKitTestRunner/Configurations/Base.xcconfig:
976         * WebKitTestRunner/Configurations/CompilerVersion.xcconfig:
977         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
978
979 2011-08-04  Adam Barth  <abarth@webkit.org>
980
981         Fancier debug logging.
982
983         * Scripts/webkitpy/layout_tests/controllers/manager.py:
984
985 2011-08-04  David Levin  <levin@chromium.org>
986
987         [chromium] Fix assertion failure in ThreadIdentifierData::identifier in TestShell.
988         https://bugs.webkit.org/show_bug.cgi?id=65685
989
990         Reviewed by Dmitry Titov.
991
992         * DumpRenderTree/chromium/WebViewHost.cpp:
993         (WebViewHost::WebViewHost): Intialize WTF threading before
994         anything in WTF is used. Usually this is done by WebViewImpl::WebViewImpl
995         but in some cases code may use WTF without creating WebViewImpl and
996         WTF code functionality may call WTF::currentThread, which requires
997         this initialization now.
998
999 2011-08-04  Adam Barth  <abarth@webkit.org>
1000
1001         An educated guess at causing the Windows bots on build.webkit.org to
1002         find the SVN revision number.
1003
1004         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1005         * Scripts/webkitpy/layout_tests/port/base.py:
1006
1007 2011-08-04  Adam Barth  <abarth@webkit.org>
1008
1009         More logging to help debug the "no SVN rev on Chromium Windows bots"
1010         bug.  My current theory is that we're trying to detect the SCM system
1011         in the wrong directory.
1012
1013         * Scripts/webkitpy/layout_tests/port/base.py:
1014
1015 2011-08-04  Dimitri Glazkov  <dglazkov@chromium.org>
1016
1017         Speed up webkit-patch optimize-expectations significantly by not collecting test files.
1018         https://bugs.webkit.org/show_bug.cgi?id=65697
1019
1020         I neglected to realize that collecting test names is not necessary for this operation.
1021
1022         Reviewed by Adam Barth.
1023
1024         * Scripts/webkitpy/tool/commands/expectations.py: Changed to pass an empty list of test files.
1025
1026 2011-08-04  Adam Barth  <abarth@webkit.org>
1027
1028         checkout_unittest.js should have better coverage of checkout.js
1029         https://bugs.webkit.org/show_bug.cgi?id=65671
1030
1031         Reviewed by Dimitri Glazkov.
1032
1033         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
1034             - Remove unused functions.
1035         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
1036             - Test remaining public functions in the checkout module.
1037
1038 2011-08-04  Dmitry Lomov  <dslomov@google.com>
1039
1040         https://bugs.webkit.org/show_bug.cgi?id=65706
1041         Run run-unit-tests on release mode test bots.
1042         Reenabling after 61812 is fixed.
1043
1044         Reviewed by Adam Roben.
1045
1046         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1047
1048 2011-08-04  Adam Barth  <abarth@webkit.org>
1049
1050         builders.js needs unit tests
1051         https://bugs.webkit.org/show_bug.cgi?id=65670
1052
1053         Reviewed by Dimitri Glazkov.
1054
1055         This test requires somewhat large test fixtures, but using real
1056         examples seemed better than trimming them down too much.
1057
1058         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js:
1059         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Added.
1060         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
1061             - Note: trac_unittests.js doesn't exist (yet!).
1062
1063 2011-08-04  Alexis Menard  <alexis.menard@openbossa.org>
1064
1065         [Qt] Make navigation actions properly usable in QML.
1066         https://bugs.webkit.org/show_bug.cgi?id=65624
1067
1068         Fix compilation after the introduction of QWebNavigationController.
1069
1070         Reviewed by Benjamin Poulain.
1071
1072         * MiniBrowser/qt/BrowserView.cpp:
1073         (BrowserView::navigationAction):
1074
1075 2011-08-04  Adam Barth  <abarth@webkit.org>
1076
1077         Another subtle bug due to lack of testing in main.js.  :(
1078
1079         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
1080
1081 2011-08-04  Adam Barth  <abarth@webkit.org>
1082
1083         Fix types.  Sadly, main.js has no test coverage.  (I need to think
1084         about how to test this part of the code.)
1085
1086         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
1087
1088 2011-08-04  Adam Barth  <abarth@webkit.org>
1089
1090         bugzilla.js is missing unit tests
1091         https://bugs.webkit.org/show_bug.cgi?id=65656
1092
1093         Reviewed by Adam Roben.
1094
1095         Testing makes perfect.
1096
1097         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js: Added.
1098         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js:
1099         (NetworkSimulator.prototype.runTest.get if):
1100         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
1101
1102 2011-08-04  Adam Barth  <abarth@webkit.org>
1103
1104         Add missing license blocks to garden-o-matic
1105         https://bugs.webkit.org/show_bug.cgi?id=65654
1106
1107         Reviewed by Dimitri Glazkov.
1108
1109         This patch is entirely boilerplate.
1110
1111         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
1112         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
1113         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js:
1114         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js:
1115         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
1116         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
1117         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
1118         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1119         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
1120         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
1121         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
1122         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js:
1123         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js:
1124         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
1125         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
1126         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
1127         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
1128         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
1129
1130 2011-08-04  Adam Barth  <abarth@webkit.org>
1131
1132         garden-o-matic needs a way to mock out the network
1133         https://bugs.webkit.org/show_bug.cgi?id=65653
1134
1135         Reviewed by Dimitri Glazkov.
1136
1137         This patch introduces the net module, which is a useful mock point for
1138         abstracting away the network.  Future patches will use this
1139         infrastructure to test some currently untested code.
1140
1141         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
1142         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
1143         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
1144         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js:
1145         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
1146         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1147         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
1148         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js: Added.
1149         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js: Added.
1150         (NetworkSimulator):
1151         (NetworkSimulator.prototype.scheduleCallback):
1152         (NetworkSimulator.prototype.runTest):
1153         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
1154         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
1155         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
1156         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1157
1158 2011-08-03  Adam Barth  <abarth@webkit.org>
1159
1160         Use failureInfo more pervasively in garden-o-matic
1161         https://bugs.webkit.org/show_bug.cgi?id=65650
1162
1163         Reviewed by Dimitri Glazkov.
1164
1165         These three variable appears in concert together many places.  This
1166         patch unifies the remaining uses into being failureInfo objects, which
1167         saves some marshalling.
1168
1169         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
1170         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
1171         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
1172         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
1173         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
1174
1175 2011-08-03  Adam Barth  <abarth@webkit.org>
1176
1177         garden-o-matic should be able to update expecations from the details pane
1178         https://bugs.webkit.org/show_bug.cgi?id=65648
1179
1180         Reviewed by Dimitri Glazkov.
1181
1182         The new button queues up the updates, which get executed all at once.
1183
1184         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1185         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
1186         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
1187
1188 2011-08-03  Adam Barth  <abarth@webkit.org>
1189
1190         Add UI to garden-o-matic for updating expectations
1191         https://bugs.webkit.org/show_bug.cgi?id=65644
1192
1193         Reviewed by Dimitri Glazkov.
1194
1195         The patch plumbs the UI back to the gardening server, but the gardening
1196         server endpoint is just a stub at this point.
1197
1198         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
1199         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1200         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
1201         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
1202         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1203         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
1204
1205 2011-08-03  Adam Barth  <abarth@webkit.org>
1206
1207         garden-o-matic details view should queue rebaselines for later execution
1208         https://bugs.webkit.org/show_bug.cgi?id=65636
1209
1210         Reviewed by Dimitri Glazkov.
1211
1212         This patch doesn't contain any confirmation UI, but we'll probably want
1213         that at some point.
1214
1215         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
1216         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1217         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
1218         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
1219
1220 2011-08-03  Kentaro Hara  <haraken@google.com>
1221
1222         Implement EventSender.scalePageBy()
1223         https://bugs.webkit.org/show_bug.cgi?id=58013
1224
1225         Reviewed by Darin Fisher.
1226
1227         Implemented EventSender.scalePageBy(f, x, y), which scales a page by a factor of f
1228         and then sets a scroll position to (x, y). Enabled the tests that had been waiting
1229         for the implementation of EventSender.scalePageBy(f, x, y).
1230
1231         Tests: compositing/scaling/tiled-layer-recursion.html
1232                fast/repaint/scale-page-shrink.html
1233                fast/dom/Element/scale-page-client-rects.html
1234                fast/dom/Range/scale-page-client-rects.html
1235                fast/events/scroll-in-scaled-page-with-overflow-hidden.html
1236                fast/dom/Element/scale-page-bounding-client-rect.html
1237                fast/dom/Range/scale-page-bounding-client-rect.html
1238
1239         * DumpRenderTree/chromium/EventSender.cpp:
1240         (EventSender::EventSender): Added bindings for scalePageBy().
1241         (EventSender::scalePageBy): A wrapper method for scalePage() in WebView.
1242         * DumpRenderTree/chromium/EventSender.h:
1243         * DumpRenderTree/chromium/TestShell.cpp:
1244         (TestShell::resetTestController): Resets the scale factor to 1.
1245
1246 2011-08-03  David Levin  <levin@chromium.org>
1247
1248         Rename WEBKIT_API to WEBKIT_EXPORT in check-webkit-style.
1249         https://bugs.webkit.org/show_bug.cgi?id=65652
1250
1251         Reviewed by Adam Barth.
1252
1253         * Scripts/webkitpy/style/checkers/cpp.py:
1254         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1255
1256 2011-08-03  Filip Pizlo  <fpizlo@apple.com>
1257
1258         Adding Filip Pizlo to committer list.
1259
1260         Unreviewed.
1261
1262         * Scripts/webkitpy/common/config/committers.py:
1263
1264 2011-08-03  Dimitri Glazkov  <dglazkov@chromium.org>
1265
1266         Add "optimize-expectations" command to webkit-patch.
1267         https://bugs.webkit.org/show_bug.cgi?id=65633
1268
1269         For now, only operates on Chromium test_expectations.txt and does not report errors/warnings.
1270
1271         Reviewed by Adam Barth.
1272
1273         * Scripts/webkitpy/tool/commands/__init__.py: Added command.
1274         * Scripts/webkitpy/tool/commands/expectations.py: Added.
1275
1276 2011-08-03  Dimitri Glazkov  <dglazkov@chromium.org>
1277
1278         Allow multiple bug identifiers in test expectations.
1279         https://bugs.webkit.org/show_bug.cgi?id=65642
1280
1281         Reviewed by Adam Barth.
1282
1283         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Tweaked to allow multiple bug ids.
1284         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests.
1285
1286 2011-08-03  Dimitri Glazkov  <dglazkov@chromium.org>
1287
1288         Teach BuilderToPort to distinguish between Release and Debug builders.
1289         https://bugs.webkit.org/show_bug.cgi?id=65628
1290
1291         Reviewed by Adam Barth.
1292
1293         * Scripts/webkitpy/tool/commands/rebaseline.py: Added a smart options object and passed it to port factory.
1294         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Added tests.
1295
1296 2011-08-03  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1297
1298         [Qt] Fix running qmltests for WK2 in the bot
1299         https://bugs.webkit.org/show_bug.cgi?id=65621
1300
1301         Reviewed by Csaba Osztrogonác.
1302
1303         The path for QML_IMPORT_PATH was assuming we were running the WK1 tests,
1304         but now there's the case for WK2 UIProcess tests as well.
1305
1306         * Scripts/run-qtwebkit-tests: add both possible paths to the QML_IMPORT_PATH.
1307
1308 2011-08-02  Dimitri Glazkov  <dglazkov@chromium.org>
1309
1310         Add a way to edit test expectations.
1311         https://bugs.webkit.org/show_bug.cgi?id=64922
1312
1313         Implements a TestExpectationsEditor, which provides a standard way to
1314         update and remove test expectations.
1315
1316         Reviewed by Adam Barth.
1317
1318         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed TestExpectationSerializer to skip lines that match no test configurations,
1319             added TestExpectationLine.is_flaky, added BugManager, a simple interface to be fleshed out later, and a TestExpectationsEditor, the big
1320             enchilada.
1321         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Loads of tests to capture desired behavior.
1322
1323 2011-08-03  Andreas Kling  <kling@webkit.org>
1324
1325         [Qt] MiniBrowser: Unbreak load progress indication.
1326         https://bugs.webkit.org/show_bug.cgi?id=65614
1327
1328         Reviewed by Kenneth Rohde Christiansen.
1329
1330         loadProgress() was renamed to loadProgressChanged().
1331
1332         * MiniBrowser/qt/BrowserWindow.cpp:
1333         (BrowserWindow::BrowserWindow):
1334         (BrowserWindow::onLoadProgressChanged):
1335         * MiniBrowser/qt/BrowserWindow.h:
1336
1337 2011-08-03  Martin Robinson  <mrobinson@igalia.com>
1338
1339         Build fix for WebKit2GTK+.
1340
1341         * WebKitTestRunner/GNUmakefile.am: Include libInternals as one of
1342         of the library dependencies of the injected bundle.
1343
1344 2011-08-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1345
1346         [GTK] Install web and plugin processes in libexecdir instead of bindir
1347         https://bugs.webkit.org/show_bug.cgi?id=65600
1348
1349         Reviewed by Martin Robinson.
1350
1351         Set WEBKIT_EXEC_PATH environment variable to use web and plugin
1352         process from current directory instead of the intalled ones.
1353
1354         * MiniBrowser/gtk/GNUmakefile.am:
1355         * MiniBrowser/gtk/main.c:
1356         (main):
1357         * WebKitTestRunner/GNUmakefile.am:
1358         * WebKitTestRunner/gtk/main.cpp:
1359         (main):
1360
1361 2011-08-02  Anders Carlsson  <andersca@apple.com>
1362
1363         Add mac-lion platform to old-run-webkit-tests
1364         https://bugs.webkit.org/show_bug.cgi?id=65577
1365
1366         * Scripts/old-run-webkit-tests:
1367         * Scripts/webkitdirs.pm:
1368         (isLion):
1369
1370 2011-08-02  Alexandru Chiculita  <achicu@adobe.com>
1371
1372         Buildbot: The Properties object has no "hasProperty" method in buildbot 8.3
1373         https://bugs.webkit.org/show_bug.cgi?id=65554
1374
1375         Using "has_key" instead of "hasProperty" in order to support buildbot 8.3.
1376
1377         Reviewed by Adam Roben.
1378
1379         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1380
1381 2011-08-02  Jochen Eisinger  <jochen@chromium.org>
1382
1383         Implement WebPermissionClient::allowPlugins for layout tests
1384         https://bugs.webkit.org/show_bug.cgi?id=33991
1385
1386         Reviewed by Adam Barth.
1387
1388         * DumpRenderTree/chromium/LayoutTestController.cpp:
1389         (LayoutTestController::LayoutTestController):
1390         (LayoutTestController::setPluginsAllowed):
1391         * DumpRenderTree/chromium/LayoutTestController.h:
1392         * DumpRenderTree/chromium/WebPermissions.cpp:
1393         (WebPermissions::allowPlugins):
1394         (WebPermissions::setPluginsAllowed):
1395         (WebPermissions::reset):
1396         * DumpRenderTree/chromium/WebPermissions.h:
1397
1398 2011-08-02  Adam Barth  <abarth@webkit.org>
1399
1400         TestFailures unit tests leak a global variable
1401         https://bugs.webkit.org/show_bug.cgi?id=65500
1402
1403         Reviewed by Adam Roben.
1404
1405         qunit detects the leak if you check the "noglobals" box on run-unittests.html.
1406
1407         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
1408
1409 2011-08-02  Alexandru Chiculita  <achicu@adobe.com>
1410
1411         CSS Regions build bot should archive and upload output files
1412         https://bugs.webkit.org/show_bug.cgi?id=65200
1413
1414         Until now the buildbots would only upload the result archive if the 'trigger' parameters was specified. The
1415         upload was needed, because the testbots needed to download and use the archive. For CSS Regions we don't have
1416         a testbot yet, but we want to save the archive on the server for manual testing. Added new parameter
1417         in config.json, called "upload" that when set to "true" will force the upload to the buildmaster server.
1418
1419         The "features" argument is now taken into account when determining the name of the archive on the server. That
1420         was needed in order to avoid the CSS Regions Mac buildbot overwrite the SnowLeopard Mac build.
1421
1422         Reviewed by Adam Roben.
1423
1424         * BuildSlaveSupport/build.webkit.org-config/config.json:
1425         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1426
1427 2011-08-02  Patrick Gansterer  <paroga@webkit.org>
1428
1429         Fix _win32_check_running_pid on 64bit windows python
1430         https://bugs.webkit.org/show_bug.cgi?id=64950
1431
1432         Reviewed by Adam Roben.
1433
1434         Use the correct types for the PROCESSENTRY32 struct.
1435         th32DefaultHeapID is declared as ULONG_PTR and not as DWORD.
1436         Using 32bit for pointers instead of 64bit results in an ERROR_BAD_LENGTH
1437         failure, when calling the Process32First function.
1438         This is covered by the executive unittest.
1439
1440         * Scripts/webkitpy/common/system/executive.py:
1441
1442 2011-08-01  Adam Barth  <abarth@webkit.org>
1443
1444         garden-o-matic should call optimize-baselines when rebaselining tests
1445         https://bugs.webkit.org/show_bug.cgi?id=65499
1446
1447         Reviewed by Dimitri Glazkov.
1448
1449         I took the opportunity to modernize this code to use some of our more
1450         powerful primitives from base.
1451
1452         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
1453         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js:
1454         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
1455         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1456         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1457
1458 2011-08-01  Stephanie Lewis  <slewis@apple.com>
1459
1460         Finish reconfiguration started by Lucas Forschler
1461         Reconfigured slaves:
1462         Removed Leopard Intel Release (Build)
1463         Removed Leopard Intel Release (Tests)
1464         Remove apple-pixel-1
1465         Added Lion slaves from disabled Leopard slaves
1466
1467         Added builders:
1468         Lion Intel Release (Build)
1469         Lion Intel Debug (Build)
1470         Lion Intel Release (Tests)
1471         Lion Intel Release WK2 (Tests)
1472         Lion Intel Debug (Tests)
1473         Lion Intel Debug WK2 (Tests)
1474
1475         Added triggers:
1476         lion-intel-debug-tests
1477         lion-intel-debug-test-wk2
1478         lion-intel-release-tests
1479         lion-intel-release-tests-wk2
1480         
1481         Removed trigger:
1482         leopard-intel-release-tests
1483
1484         Added PlatformSpecificScheduler:
1485         mac-lion
1486
1487         Added "mac-lion" to build.py and build_unitttest.py
1488
1489         Reviewed by Mark Rowe.
1490
1491         * BuildSlaveSupport/build.webkit.org-config/config.json:
1492         * Scripts/webkitpy/common/config/build.py:
1493         * Scripts/webkitpy/common/config/build_unittest.py:
1494
1495  
1496 2011-08-01  Adam Barth  <abarth@webkit.org>
1497
1498         webkit-patch needs to be able to "optimize" the storage of baselines on disk
1499         https://bugs.webkit.org/show_bug.cgi?id=65418
1500
1501         Reviewed by Dimitri Glazkov.
1502
1503         If we're not careful when rebaselining tests, we can end up with lots
1504         of duplicate expected results files in the tree.  This patch adds a
1505         webkit-patch command that optimizes the storage of expected results on
1506         disk.
1507
1508         This command is similar to deduplicate-tests, except that it can move
1509         test results around rather than just remove duplicate results.
1510
1511         Unfortunately, this problem is very tricky because the baseline search
1512         structure is a hypergraph.  This patch include a huerstic optimizer
1513         that appears to work on a bunch of examples I've tried.  We'll likely
1514         need to refine it as gain experience.
1515
1516         * Scripts/webkitpy/common/system/filesystem.py:
1517         * Scripts/webkitpy/tool/commands/rebaseline.py:
1518
1519 2011-08-01  Dimitri Glazkov  <dglazkov@chromium.org>
1520
1521         Teach TestExpectationSerializer about parsed expectations.
1522         https://bugs.webkit.org/show_bug.cgi?id=65444
1523
1524         This is a bit largish in size, but the essentials are:
1525         * TestExpectationSerializer, given a parsed TestExpectationLine, can now spit out a pretty string.
1526         * We now store original content of the expectation line on TestExpectationLine.
1527         * Lots of tests.
1528
1529         Reviewed by Adam Barth.
1530
1531         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Fixed an issue where we didn't
1532             populate macros correctly, also fixed an issue where we incorrectly returned an empty list
1533             for all configurations.
1534         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added tests for those.
1535         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Removed vestiges of code long gone,
1536             refactored TestExpectationsSerializer to recognize and correctly serialize parsed TestExpectationLine instances,
1537             changed to store and use TestExpectationLine.original_string.
1538         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests.
1539
1540 2011-08-01  Adam Barth  <abarth@webkit.org>
1541
1542         Remove unused functionality from gardeningserver
1543         https://bugs.webkit.org/show_bug.cgi?id=65479
1544
1545         Reviewed by Dimitri Glazkov.
1546
1547         We now handle these operations directly from the front-end.  That means
1548         they work even without the gardening server running!
1549
1550         Also, add some missing files to the list of static files.
1551
1552         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1553         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1554
1555 2011-08-01  Dimitri Glazkov  <dglazkov@chromium.org>
1556
1557         Introduce SpecifierSorter, a thing that knows how specifiers should be ordered.
1558         https://bugs.webkit.org/show_bug.cgi?id=65413
1559
1560         Reviewed by Adam Barth.
1561
1562         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added SpecifierSorter and converted
1563             existing code to use it.
1564         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added unit tests and cleaned up a bit.
1565
1566 2011-08-01  Adam Barth  <abarth@webkit.org>
1567
1568         Refactor bugzilla.js for use by garden-o-matic
1569         https://bugs.webkit.org/show_bug.cgi?id=65450
1570
1571         Reviewed by Dimitri Glazkov.
1572
1573         This patch refactors bugzilla.js to use the AsynchronousCache and
1574         updates the style to use a module instead of an object.  This patch
1575         then fixes all the existing code that uses this class to use the new
1576         API style.
1577
1578         This main benefit of this patch is we remove the tricky manual caching
1579         and this code is now available to use in garden-o-matic (since the
1580         dependency on Utilities.js is now gone).
1581
1582         I ran all the unit tests and poked around in TestFailures a bit to see
1583         that everything seemed to be working properly.
1584
1585         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
1586         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js:
1587         (FailingTestsBugForm):
1588         (FailingTestsBugForm.prototype._createBugTitle):
1589         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
1590         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js:
1591         (FlakyTestBugForm):
1592         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js:
1593         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js:
1594         (NewBugForm):
1595         (NewBugForm.prototype.domElement):
1596         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js:
1597         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js:
1598         (TestRelatedBugForm):
1599         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js:
1600         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1601         (ViewController.prototype._displayBuilder.start):
1602         (ViewController.prototype._displayBuilder):
1603         (ViewController.prototype._domForAuxiliaryUIElements):
1604         (ViewController.prototype._domForNewAndExistingBugs.bugzilla.quickSearch):
1605         (ViewController.prototype._domForPossiblyFlakyTests.flakyList.appendChildren):
1606         (ViewController.prototype._domForPossiblyFlakyTests):
1607         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
1608         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1609         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
1610
1611 2011-08-01  Adam Barth  <abarth@webkit.org>
1612
1613         garden-o-matic shouldn't require local server to determine if compile failed
1614         https://bugs.webkit.org/show_bug.cgi?id=65446
1615
1616         Reviewed by Dimitri Glazkov.
1617
1618         This patch adds some basic bindings for the buildbot JSON API.  I
1619         wanted to use Buildbot.js an Builder.js from the original TestFailures,
1620         but they make a number of WebKit-specific assumptions.  We'll
1621         eventually need to reconcile these pieces of code.
1622
1623         I should really add tests for this code, but that will require me to
1624         build a better mock network.  I'll be happy to do that in a follow-up
1625         patch.
1626
1627         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js: Added.
1628             - It's very unclear to me whether didFail is correct.  Supposedly
1629               the first entry here is the exit code of the step, which is 0 on
1630               success.  I suspect we'll need to improve this function over time.
1631         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1632         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
1633         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
1634
1635 2011-08-01  Adam Barth  <abarth@webkit.org>
1636
1637         garden-o-matic should show all failures, even ones that it can't find a regression range for
1638         https://bugs.webkit.org/show_bug.cgi?id=65447
1639
1640         Reviewed by Dimitri Glazkov.
1641
1642         Previously, we just wouldn't display test failures that we couldn't
1643         identify a regression range for (or whose regression range had fallen
1644         off the page).  This patch just displays them at the end of the list,
1645         which is slightly (but not much) better.
1646
1647         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
1648
1649 2011-08-01  Jeff Miller  <jeffm@apple.com>
1650
1651         Windows build fix after r92096.
1652
1653         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Use #include, not #import, and don't include Foundation.h.
1654         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Add InjectedBundleControllerWin.cpp.
1655
1656 2011-07-31  Anders Carlsson  <andersca@apple.com>
1657
1658         DownloadDecideDestinationCrash WebKit2 API tests crashes
1659         https://bugs.webkit.org/show_bug.cgi?id=65442
1660
1661         Reviewed by Sam Weinig.
1662
1663         Copy the 18-characters.html file to the destination directory so we won't
1664         crash trying to make an URL for it.
1665
1666         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1667
1668 2011-07-31  Anders Carlsson  <andersca@apple.com>
1669
1670         Fix SpacebarScrolling WebKit2 API test
1671         https://bugs.webkit.org/show_bug.cgi?id=65431
1672
1673         Reviewed by Sam Weinig.
1674
1675         Add a way to do platform-specific bundle initialization, and use it to disable smooth
1676         scrolling. Also make it possible for a test to load the injected bundle without actually running
1677         a test from it.
1678
1679         * TestWebKitAPI/InjectedBundleController.cpp:
1680         (TestWebKitAPI::InjectedBundleController::initialize):
1681         * TestWebKitAPI/InjectedBundleController.h:
1682         * TestWebKitAPI/PlatformUtilities.cpp:
1683         (TestWebKitAPI::Util::createContextWithInjectedBundle):
1684         * TestWebKitAPI/PlatformUtilities.h:
1685         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1686         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1687         (TestWebKitAPI::TEST):
1688         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm: Added.
1689         (TestWebKitAPI::InjectedBundleController::platformInitialize):
1690         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Added.
1691         (TestWebKitAPI::InjectedBundleController::platformInitialize):
1692         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1693
1694 2011-07-31  Dimitri Glazkov  <dglazkov@chromium.org>
1695
1696         Use set comparison to find duplicate or overlapping specifiers in test expectations.
1697         https://bugs.webkit.org/show_bug.cgi?id=65430
1698
1699         Reviewed by Adam Barth.
1700
1701         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed to use set comparisons, because length
1702             of a set is wrong.
1703         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Added some unit tests to actually catch
1704             regressions.
1705
1706 2011-07-31  Xan Lopez  <xlopez@igalia.com>
1707
1708         Group dependencies CFLAGS together.
1709
1710         * GNUmakefile.am: ditto.
1711
1712 2011-07-31  Daniel Bates  <dbates@webkit.org>
1713
1714         Attempt to fix the GTK build after <http://trac.webkit.org/changeset/92059>
1715         (https://bugs.webkit.org/show_bug.cgi?id=65419).
1716
1717         * GNUmakefile.am: Add $(CAIRO_CFLAGS) to libWebCoreInternals_la_CPPFLAGS.
1718
1719 2011-07-30  Patrick Gansterer  <paroga@webkit.org>
1720
1721         Fix ports_unittest.py on native windows
1722         https://bugs.webkit.org/show_bug.cgi?id=64959
1723
1724         Reviewed by Adam Barth.
1725
1726         Replace WebKitPort.script_path with WebKitPort.script_shell_command.
1727         The latter includes the interpreter executable required on native windows.
1728
1729         * Scripts/webkitpy/common/config/ports_unittest.py:
1730
1731 2011-07-30  Adam Barth  <abarth@webkit.org>
1732
1733         Properly escape regular expressions.  (Maybe these shouldn't be regular
1734         expressions?)
1735
1736         * Scripts/webkitpy/tool/commands/rebaseline.py:
1737
1738 2011-07-30  Adam Barth  <abarth@webkit.org>
1739
1740         Add support for Win7 to garden-o-matic.
1741
1742         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
1743         * Scripts/webkitpy/tool/commands/rebaseline.py:
1744
1745 2011-07-30  Adam Barth  <abarth@webkit.org>
1746
1747         garden-o-matic regression ranges expand after fast bots start passing
1748         https://bugs.webkit.org/show_bug.cgi?id=65406
1749
1750         Reviewed by Dimitri Glazkov.
1751
1752         Once the gardener has fixed a problem, the fast bots pick up the fix,
1753         which means we end up using the slow bots to compute the regression
1754         range.  Unfortunately, the slow bots give us large regression ranges,
1755         leading to this strange effect where the regression range quality
1756         degrades as fixes roll in.
1757
1758         This patch causes us to remember the previous regression ranges we've
1759         seen and to use that information in the future, as long as it's
1760         consistent with the new information we receive.
1761
1762         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
1763
1764 2011-07-30  Adam Barth  <abarth@webkit.org>
1765
1766         garden-o-matic should have a Refresh button to update its display
1767         https://bugs.webkit.org/show_bug.cgi?id=65403
1768
1769         Reviewed by Dimitri Glazkov.
1770
1771         The refresh button should be faster and less disruptive than the browser's reload button.
1772
1773         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1774         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
1775
1776 2011-07-30  Adam Barth  <abarth@webkit.org>
1777
1778         garden-o-matic should look for the "patch by" line in revisions ostensibly authored by the commit-queue
1779         https://bugs.webkit.org/show_bug.cgi?id=65231
1780
1781         Reviewed by Dimitri Glazkov.
1782
1783         The human readable name is easier to understand, especially when the patch is landed by the commit-queue.
1784
1785         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
1786
1787 2011-07-30  Adam Barth  <abarth@webkit.org>
1788
1789         garden-o-matic should strikeout revisions that have been rolled out
1790         https://bugs.webkit.org/show_bug.cgi?id=65227
1791
1792         Reviewed by Dimitri Glazkov.
1793
1794         This helps gardeners keep track of which problems have been solved.
1795
1796         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
1797         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
1798         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
1799         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
1800
1801 2011-07-30  Adam Barth  <abarth@webkit.org>
1802
1803         Add missing files to the server.
1804
1805         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1806
1807 2011-07-29  Adam Barth  <abarth@webkit.org>
1808
1809         Actually import the logging module!
1810
1811         * Scripts/webkitpy/common/checkout/scm/git.py:
1812
1813 2011-07-29  Adam Barth  <abarth@webkit.org>
1814
1815         More debug logging.  Maybe we're running the git version of this
1816         function somehow?  (That would explain why it doesn't work!)
1817
1818         * Scripts/webkitpy/common/checkout/scm/git.py:
1819
1820 2011-07-29  Adam Barth  <abarth@webkit.org>
1821
1822         Add some temporary debug logging messages to try to understand why the
1823         windows bots can't figure out their current SVN revision.
1824
1825         * Scripts/webkitpy/common/checkout/scm/svn.py:
1826
1827 2011-07-29  Adam Barth  <abarth@webkit.org>
1828
1829         Chromium try servers should use downstream test_expectations
1830         https://bugs.webkit.org/show_bug.cgi?id=65390
1831
1832         Reviewed by Dirk Pranke.
1833
1834         Otherwise the try servers will report bogus failures.
1835
1836         * Scripts/webkitpy/layout_tests/port/chromium.py:
1837
1838 2011-07-29  Dimitri Glazkov  <dglazkov@chromium.org>
1839
1840         Fix an error in macro collapsing, refactor code to be pretty.
1841         https://bugs.webkit.org/show_bug.cgi?id=65387
1842
1843         My set math was wrong.
1844
1845         Reviewed by Adam Barth.
1846
1847         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Moved collapsing into a classmethod, fixed the math to be correct.
1848         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added unit tests.
1849
1850 2011-07-27  Ryuan Choi  <ryuan.choi@samsung.com>
1851
1852         Style bot complains about EFL-specific forward declaration naming.
1853         https://bugs.webkit.org/show_bug.cgi?id=64680
1854
1855         Exclude EFL-specific forward declarations from indentifiers with underscores checks.
1856
1857         Reviewed by Adam Barth.
1858
1859         * Scripts/webkitpy/style/checkers/cpp.py:
1860         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1861
1862 2011-07-27  Adam Roben  <aroben@apple.com>
1863
1864         Use wacky !svn/bc URLs consistently in Leaks Viewer
1865
1866         This ensures that any resources loaded via relative URLs will still get pulled from the same
1867         revision of Subversion.
1868
1869         Fixes <http://webkit.org/b/65267> Focus/exclude button glyphs don't load on Leaks Viewer
1870
1871         Reviewed by David Kilzer.
1872
1873         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Use the
1874         !svn/bc-style URL for inspector.css, too, just like we do for all other resources we pull
1875         from Subversion.
1876
1877 2011-07-27  Raphael Kubo da Costa  <kubo@profusion.mobi>
1878
1879         [EFL] Drop WorkQueueItemEfl.h in favour of the general WorkQueueItem.h
1880         https://bugs.webkit.org/show_bug.cgi?id=65269
1881
1882         Reviewed by Kent Tamura.
1883
1884         WorkQueueItemEfl.h was being included by efl's
1885         LayoutTestControllerEfl.cpp, however the top-level
1886         LayoutTestController still included WorkQueueItem.h, causing a lot of
1887         type mismatches when running the WorkQueueItem code.
1888
1889         We can stick to the original WorkQueueItem header by making a few
1890         changes to EFL's LayoutTestController.
1891
1892         This should make tests such as
1893         fast/loader/non-deferred-substitute-load.html stop crashing.
1894
1895         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1896         (LayoutTestController::queueLoad):
1897         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
1898         (LoadItem::invoke):
1899         (LoadHTMLStringItem::invoke):
1900         (ScriptItem::invoke):
1901         * DumpRenderTree/efl/WorkQueueItemEfl.h: Removed.
1902
1903 2011-07-27  Dimitri Glazkov  <dglazkov@chromium.org>
1904
1905         Re-add unit tests I accidentally zapped in r91878.
1906
1907         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Re-added unit tests.
1908
1909 2011-07-27  Dimitri Glazkov  <dglazkov@chromium.org>
1910
1911         Replace SpecificityCalculator with TestConfiguration-driven logic.
1912         https://bugs.webkit.org/show_bug.cgi?id=65206
1913
1914         Use our newly-acquired ability to expand modifiers into a set of
1915         matching TestConfiguration instances to calculate specificity and
1916         determine whether expectation applies to a given test configuration.
1917
1918         Also, store bug modifier on TestExpectationsLine.
1919
1920         Reviewed by Adam Barth.
1921
1922         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Replaced the logic of calculating specificity with
1923             test configuration matching, removed a bunch of code.
1924         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Removed a bunch of tests that aren't useful anymore.
1925
1926
1927 2011-07-27  Dimitri Glazkov  <dglazkov@chromium.org>
1928
1929         Allow ports to specify their own test expectation specifier macros.
1930         https://bugs.webkit.org/show_bug.cgi?id=65291
1931
1932         Reviewed by Adam Barth.
1933
1934         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed SpecificityCalculator to use port macros.
1935         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
1936         * Scripts/webkitpy/layout_tests/port/base.py: Added configuration_specifier_macros to retrieve the macros.
1937         * Scripts/webkitpy/layout_tests/port/chromium.py: Overrode it to return Chromium's macros.
1938         * Scripts/webkitpy/layout_tests/port/test.py: Added test macros.
1939
1940 2011-07-27  Dimitri Glazkov  <dglazkov@chromium.org>
1941
1942         Allow TestConfigurationConverter report conversion errors.
1943         https://bugs.webkit.org/show_bug.cgi?id=65287
1944
1945         Also, fix a few miscellaneous testing issues.
1946
1947         Reviewed by Adam Barth.
1948
1949         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added a way to report unknown modifier errors.
1950         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added a test for reporting errors.
1951         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Fixed an error where an invalid TestConfiguration instance
1952             was created. 'default' is not a valid build type.
1953         * Scripts/webkitpy/layout_tests/port/test.py: Ditto. '' is not a valid version.
1954
1955 2011-07-27  Dimitri Glazkov  <dglazkov@chromium.org>
1956
1957         Teach all ports about their test configurations.
1958         https://bugs.webkit.org/show_bug.cgi?id=65278
1959
1960         Each Port object should return a valid set of all TestConfiguration instances,
1961         available for this port.
1962
1963         Reviewed by Philippe Normand.
1964
1965         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Removed TestConfiguration.all_test_configurations,
1966             since it is different for each port.
1967         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Removed related test.
1968         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed SpecificityCalculator to take a list of
1969             all test configurations as a param.
1970         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Adjusted arguments accordingly.
1971         * Scripts/webkitpy/layout_tests/port/base.py: Forced all ports to override generation of all test configurations.
1972         * Scripts/webkitpy/layout_tests/port/chromium.py: Implemented _generate_all_test_configurations for the port.
1973         * Scripts/webkitpy/layout_tests/port/gtk.py: Ditto.
1974         * Scripts/webkitpy/layout_tests/port/mac.py: Ditto.
1975         * Scripts/webkitpy/layout_tests/port/qt.py: Ditto.
1976         * Scripts/webkitpy/layout_tests/port/win.py:
1977         * Scripts/webkitpy/layout_tests/port/port_testcase.py: Added an extra test to ensure we're generating a good set.
1978         * Scripts/webkitpy/layout_tests/port/test.py: Implemented a fixed-in-time all_test_configurations for testing.
1979         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added a mock all_test_configurations implementation.
1980         * Scripts/webkitpy/layout_tests/port/win_unittest.py: Added a unit test for the port.
1981
1982 2011-07-27  Benjamin Poulain  <benjamin@webkit.org>
1983
1984         [WK2][Qt] Move from QGraphicsView to Qt Scene Graph
1985         https://bugs.webkit.org/show_bug.cgi?id=62969
1986
1987         Reviewed by Andreas Kling.
1988
1989         Co-authored with Simon Hausmann  <simon.hausmann@nokia.com>
1990
1991         With the scene graph, the interface to have a window on screen is
1992         QSGCanvas. QGraphicsView is not used, and openGL is an enforced
1993         dependency.
1994
1995         Both the BrowserView and the WebKitTest runner are changed from
1996         QGraphicsView to QSGCanvas.
1997
1998         * MiniBrowser/qt/BrowserView.cpp:
1999         (BrowserView::BrowserView):
2000         (BrowserView::resizeEvent):
2001         (BrowserView::view):
2002         * MiniBrowser/qt/BrowserView.h:
2003         * MiniBrowser/qt/BrowserWindow.cpp:
2004         (BrowserWindow::BrowserWindow):
2005         (BrowserWindow::urlChanged):
2006         (BrowserWindow::~BrowserWindow):
2007         * MiniBrowser/qt/BrowserWindow.h:
2008         * MiniBrowser/qt/MiniBrowser.pro:
2009         * MiniBrowser/qt/main.cpp:
2010         (main):
2011         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2012         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2013         (WTR::WebView::WebView):
2014         (WTR::PlatformWebView::PlatformWebView):
2015         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2016
2017 2011-07-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2018
2019         Unreviewed, rolling out r91792.
2020         http://trac.webkit.org/changeset/91792
2021         https://bugs.webkit.org/show_bug.cgi?id=65242
2022
2023         It broke NRWT on Qt and GTK (Requested by Ossy_night on
2024         #webkit).
2025
2026         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
2027         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
2028         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2029         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2030         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2031         * Scripts/webkitpy/layout_tests/port/test.py:
2032
2033 2011-07-26  Adam Barth  <abarth@webkit.org>
2034
2035         Switch to an older idiom that works on Python 2.5.
2036
2037         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
2038
2039 2011-07-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2040
2041         Add an exception to coding style check for EFL port.
2042         https://bugs.webkit.org/show_bug.cgi?id=65162
2043
2044         Add an exception of whitespace/declaration for EFL port. Because,
2045         '*' operator is next to variable in EFL coding style.
2046
2047         Reviewed by Kent Tamura.
2048
2049         * Scripts/webkitpy/style/checker.py:
2050
2051 2011-07-26  Keith Kyzivat  <keith.kyzivat@nokia.com>
2052
2053         [Qt] Add option to turn on disk caching in QtTestBrowser
2054         https://bugs.webkit.org/show_bug.cgi?id=65007
2055
2056         Reviewed by Noam Rosenthal.
2057
2058         Add menu item and command line option to turn on disk caching in
2059         QtTestBrowser. Simple QNetworkDiskCache added to the page's
2060         QNetworkAccssManager.
2061
2062         * QtTestBrowser/launcherwindow.cpp:
2063         (LauncherWindow::initializeView):
2064         (LauncherWindow::createChrome):
2065         (LauncherWindow::setDiskCache):
2066         * QtTestBrowser/launcherwindow.h:
2067         (WindowOptions::WindowOptions):
2068         * QtTestBrowser/main.cpp:
2069         (LauncherApplication::handleUserOptions):
2070
2071 2011-07-26  Sadrul Habib Chowdhury  <sadrul@chromium.org>
2072
2073         Add support for download='filename' attribute in anchors.
2074         https://bugs.webkit.org/show_bug.cgi?id=64580
2075
2076         Reviewed by Adam Barth.
2077
2078         * DumpRenderTree/chromium/WebViewHost.cpp:
2079         (WebViewHost::loadURLExternally):
2080         * DumpRenderTree/chromium/WebViewHost.h:
2081
2082 2011-07-26  Dan Bernstein  <mitz@apple.com>
2083
2084         Rubber-stamped by Anders Carlsson.
2085
2086         Update DumpRenderTree and API tests for the pictograph font family preference.
2087
2088         * DumpRenderTree/mac/DumpRenderTree.mm:
2089         (resetDefaultsToConsistentValues):
2090         * DumpRenderTree/win/DumpRenderTree.cpp:
2091         (resetDefaultsToConsistentValues):
2092         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2093         (TestWebKitAPI::TEST):
2094         * WebKitTestRunner/TestController.cpp:
2095         (WTR::TestController::resetStateToConsistentValues):
2096
2097 2011-07-26  Dimitri Glazkov  <dglazkov@chromium.org>
2098
2099         Replace SpecificityCalculator with TestConfiguration-driven logic.
2100         https://bugs.webkit.org/show_bug.cgi?id=65206
2101
2102         Use our newly-acquired ability to expand modifiers into a set of
2103         matching TestConfiguration instances to calculate specificity and
2104         determine whether expectation applies to a given test configuration.
2105
2106         Also, store bug modifier on TestExpectationsLine.
2107
2108         Reviewed by Adam Barth.
2109
2110         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added a way to report unknown modifier errors.
2111         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added a test for reporting errors.
2112         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Replaced the logic of calculating specificity with
2113             test configuration matching, removed a bunch of code.
2114         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Removed a bunch of tests that aren't useful anymore.
2115         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Fixed an error where an invalid TestConfiguration instance
2116             was created. 'default' is not a valid build type.
2117         * Scripts/webkitpy/layout_tests/port/test.py: Ditto. '' is not a valid version.
2118
2119 2011-07-26  Adam Barth  <abarth@webkit.org>
2120
2121         Increase the information density in garden-o-matic
2122         https://bugs.webkit.org/show_bug.cgi?id=65141
2123
2124         Reviewed by Dimitri Glazkov.
2125
2126         This patch changes lets us show each revision on a single line,
2127         allowing use to show an entire day's worth of commits at once.
2128
2129         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
2130         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
2131         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
2132
2133 2011-07-26  Dimitri Glazkov  <dglazkov@chromium.org>
2134
2135         TestConfigurationConverter should not barf on invalid specifiers.
2136         https://bugs.webkit.org/show_bug.cgi?id=65194
2137
2138         Reviewed by Adam Barth.
2139
2140         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Refactored TestConfigurationConverter.to_config_set a bit,
2141             made it return empty set whenever an invalid specifier is encountered.
2142         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added corresponding tests.
2143
2144 2011-07-26  Dimitri Glazkov  <dglazkov@chromium.org>
2145
2146         Introduce a way to convert between specifier lists and TestConfiguration sets.
2147         https://bugs.webkit.org/show_bug.cgi?id=65094
2148
2149         Add TestConfigurationConverter, a facility to convert:
2150         1) a set of specifiers into a set of TestConfiguration instances;
2151         2) a set of TestConfiguration instances into a list of sets of specifiers.
2152
2153         Reviewed by Adam Barth.
2154
2155         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added TestConfigurationConverter.
2156         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added tests for it.
2157
2158 2011-07-26  Alexandru Chiculita  <achicu@adobe.com>
2159
2160         CSS Regions build bot should build with "--css-regions" and "--css-exclusion" flags
2161         https://bugs.webkit.org/show_bug.cgi?id=65171
2162
2163         Added "features" parameter in config.json for "builder" objects. The parameter is optional and must be an array. All the items
2164         of the array will be passed to the build-webkit script. The items will automatically be prefixed with "--".
2165
2166         Reviewed by Adam Roben.
2167
2168         * BuildSlaveSupport/build.webkit.org-config/config.json:
2169         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2170
2171 2011-07-26  Chris Rogers  <crogers@google.com>
2172
2173         Avoid outputting #EOF twice for web audio tests in chromium DRT
2174         https://bugs.webkit.org/show_bug.cgi?id=65201
2175
2176         Reviewed by Dirk Pranke.
2177
2178         * DumpRenderTree/chromium/TestShell.cpp:
2179         (TestShell::dump):
2180
2181 2011-07-26  Adam Barth  <abarth@webkit.org>
2182
2183         Windows bots on build.chromium.org can't figure out the head_svn_revision
2184         https://bugs.webkit.org/show_bug.cgi?id=65156
2185
2186         Reviewed by Tony Chang.
2187
2188         This patch is a bit of a guess as to the issue based on the
2189         investigation in https://bugs.webkit.org/show_bug.cgi?id=65148.  I'm
2190         not sure whether it will fix the issue, but it seems worth a try.
2191
2192         * Scripts/webkitpy/common/checkout/scm/svn.py:
2193
2194 2011-07-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2195
2196         Unreviewed. Fix WebKitGtk build with GTK+ 3.x after r91707.
2197
2198         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
2199         (getPreferredSizeMethod):
2200
2201 2011-07-26  MORITA Hajime  <morrita@google.com>
2202
2203         [Chromium][DRT] MockSpellCheck.cpp should be clang clean
2204         https://bugs.webkit.org/show_bug.cgi?id=65166
2205
2206         Reviewed by Kent Tamura.
2207
2208         * DumpRenderTree/chromium/MockSpellCheck.cpp:
2209         (MockSpellCheck::spellCheckWord): -Wsign-compare warning.
2210
2211 2011-07-25  Patrick Gansterer  <paroga@webkit.org>
2212
2213         Ignore line endings in ChangeLogTests
2214         https://bugs.webkit.org/show_bug.cgi?id=64956
2215
2216         Reviewed by Adam Barth.
2217
2218         Split the lines of the ChangeLog text before comparing them.
2219         This fixes 3 tests on windows, since only the content importent.
2220
2221         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2222         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
2223
2224 2011-07-25  Adam Barth  <abarth@webkit.org>
2225
2226         Add some debug logging to NRWT to diagnose why the windows bots can't determine their SVN revision
2227         https://bugs.webkit.org/show_bug.cgi?id=65148
2228
2229         Reviewed by Tony Chang.
2230
2231         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2232
2233 2011-07-25  Ojan Vafai  <ojan@chromium.org>
2234
2235         Tweak whitespace wrapping to improve readability.
2236         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2237
2238 2011-07-25  Ojan Vafai  <ojan@chromium.org>
2239
2240         Minor tweak to wrap label elements as atomic units.
2241
2242         * TestResultServer/static-dashboards/dashboard_base.js:
2243         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2244
2245 2011-07-25  Ojan Vafai  <ojan@chromium.org>
2246
2247         always show flakiness details on the builder page
2248         https://bugs.webkit.org/show_bug.cgi?id=65139
2249
2250         Reviewed by Tony Chang.
2251
2252         In order to simplify the UI, we hide the flakiness details by default,
2253         but there's no actual use-case for this page without the flakiness details.
2254         So get rid of that option and always show the flakiness details.
2255
2256         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2257
2258 2011-07-25  Ojan Vafai  <ojan@chromium.org>
2259
2260         simplify the UI of the header above the test list table
2261         https://bugs.webkit.org/show_bug.cgi?id=65136
2262
2263         Reviewed by Adam Barth.
2264
2265         Use checkboxes instead of links since this is really about which tests to include.
2266         Ends up using less text and put the checkboxes to the right of the header instead of below it.
2267
2268         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2269         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2270
2271 2011-07-25  Chris Rogers  <crogers@google.com>
2272
2273         Update new-run-webkit-tests to accomodate binary audio data
2274         https://bugs.webkit.org/show_bug.cgi?id=65135
2275
2276         Reviewed by Dirk Pranke.
2277
2278         * Scripts/webkitpy/layout_tests/port/chromium.py:
2279
2280 2011-07-25  Chris Rogers  <crogers@google.com>
2281
2282         Update Chromium DRT to output binary (instead of base64-encoded) data for web audio testing
2283         https://bugs.webkit.org/show_bug.cgi?id=65039
2284
2285         Reviewed by Tony Chang.
2286
2287         * DumpRenderTree/chromium/LayoutTestController.cpp:
2288         (LayoutTestController::LayoutTestController):
2289         (LayoutTestController::setAudioData):
2290         * DumpRenderTree/chromium/LayoutTestController.h:
2291         (LayoutTestController::audioData):
2292         * DumpRenderTree/chromium/TestEventPrinter.cpp:
2293         (DRTPrinter::handleAudioHeader):
2294         (TestShellPrinter::handleAudioHeader):
2295         * DumpRenderTree/chromium/TestShell.cpp:
2296         (TestShell::dump):
2297
2298 2011-06-07  Martin Robinson  <mrobinson@igalia.com>
2299
2300         Reviewed by Gustavo Noronha Silva.
2301
2302         [GTK] Use WebCore scrollbars for the DRT instead of GtkScrolledWindow
2303         https://bugs.webkit.org/show_bug.cgi?id=62252
2304
2305         Add a new subclass of WebKitWebView that overrides the size request to
2306         return 1 pixel by 1 pixel. This ensure that it operates properly when
2307         not packed into a GtkScrolledWindow. Also construct the WebKitWebView
2308         with self-scrolling set to true.
2309
2310         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2311         (webInspectorInspectWebView): Use the new SelfScrollingWebKitWebview class here.
2312         (createWebView): Ditto.
2313         (main): Pack the widget into a GtkBox instead of a GtkScrolledWindow.
2314         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Added.
2315         (self_scrolling_webkit_web_view_class_init):
2316         (self_scrolling_webkit_web_view_init):
2317         (self_scrolling_webkit_web_view_new):
2318         (sizeRequestMethod):
2319         (getPreferredSizeMethod):
2320         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Added.
2321         * GNUmakefile.am: Added SelfScrollingWebKitWebView files to the source list.
2322
2323 2011-07-25  Ojan Vafai  <ojan@chromium.org>
2324
2325         by default hide tests that have passes for all recorded runs
2326         https://bugs.webkit.org/show_bug.cgi?id=65127
2327
2328         Reviewed by Adam Barth.
2329
2330         This is part of simplifying the default views of the dashboard to
2331         make it show less information for the common use cases.
2332
2333         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2334         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2335
2336 2011-07-25  Ojan Vafai  <ojan@chromium.org>
2337
2338         stop generating expectations.json now that it's unused
2339         https://bugs.webkit.org/show_bug.cgi?id=65130
2340
2341         Reviewed by Adam Barth.
2342
2343         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2344         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2345         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2346         * TestResultServer/handlers/menu.py:
2347         * TestResultServer/static-dashboards/dashboard_base.js:
2348         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2349
2350 2011-07-25  Ojan Vafai  <ojan@chromium.org>
2351
2352         don't show builders in the flakiness dashboard that have stopped running a given test suite
2353         https://bugs.webkit.org/show_bug.cgi?id=65126
2354
2355         Reviewed by Mihai Parparita.
2356
2357         * TestResultServer/static-dashboards/dashboard_base.js:
2358
2359 2011-07-25  Adam Barth  <abarth@webkit.org>
2360
2361         Overhaul garden-o-matic frontend to integrate revision history and failures
2362         https://bugs.webkit.org/show_bug.cgi?id=65089
2363
2364         Reviewed by Dimitri Glazkov.
2365
2366         This is a major overhaul of the garden-o-matic frontend.  The new UI
2367         integrates the revision history information with failures.  Failures
2368         appear in context adjacent to the revisions that caused them (which are
2369         highlighted).  Each buildbot receives a collumn to the left, which
2370         indicates which revisions that bot has tested and whether that bot
2371         showed the indicated failures.
2372
2373         Failures are selectable with checkboxes, and can then either be
2374         examined or rebaselined.
2375
2376         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
2377         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
2378         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2379         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
2380         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2381         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
2382         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
2383         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
2384         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
2385
2386 2011-07-25  Holger Hans Peter Freyther  <zecke@selfish.org>
2387
2388         [buildbot] Add Qt Linux MIPSEL Configuration
2389         https://bugs.webkit.org/show_bug.cgi?id=65116
2390
2391         Reviewed by Adam Roben.
2392
2393         Introduce a Qt Linux MIPS EL build slave. The configuration
2394         is a build only configuration.
2395
2396         * BuildSlaveSupport/build.webkit.org-config/config.json: Add MIPS buildbot.
2397
2398 2011-07-25  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2399
2400         [Qt][WK2] Add multi-point touch mocking to MiniBrowser
2401         https://bugs.webkit.org/show_bug.cgi?id=64374
2402
2403         Reviewed by Benjamin Poulain.
2404
2405         Each mouse button generate a touch point. The touch point stay
2406         virtually on screen if the mouse release happened while the Ctrl
2407         modifier was pressed.
2408
2409         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2410         (MiniBrowserApplication::notify):
2411         * MiniBrowser/qt/MiniBrowserApplication.h:
2412
2413 2011-07-25  Balazs Kelemen  <kbalazs@webkit.org>
2414
2415         [Qt][WK2] Use NRWT for Qt-WK2
2416         https://bugs.webkit.org/show_bug.cgi?id=65097
2417
2418         Reviewed by Andreas Kling.
2419
2420         * Scripts/run-webkit-tests:
2421         (useNewRunWebKitTests):
2422
2423 2011-07-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2424
2425         Unreviewed, rolling out r91635.
2426         http://trac.webkit.org/changeset/91635
2427         https://bugs.webkit.org/show_bug.cgi?id=65083
2428
2429         It broke the minimal build (Requested by Ossy___OFFLINE on
2430         #webkit).
2431
2432         * QtTestBrowser/launcherwindow.cpp:
2433         (LauncherWindow::initializeView):
2434         (LauncherWindow::createChrome):
2435         * QtTestBrowser/launcherwindow.h:
2436         (WindowOptions::WindowOptions):
2437         * QtTestBrowser/main.cpp:
2438         (LauncherApplication::handleUserOptions):
2439
2440 2011-07-24  Adam Barth  <abarth@webkit.org>
2441
2442         Rename garden-o-matic "alert" to "infobar" and increase the width to 100%.
2443
2444         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
2445         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2446         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
2447         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2448         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
2449         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
2450
2451 2011-07-23  Dimitri Glazkov  <dglazkov@chromium.org>
2452
2453         TestConfiguration should be hashable and comparable for equality.
2454         https://bugs.webkit.org/show_bug.cgi?id=65070
2455
2456         Reviewed by Adam Barth.
2457
2458         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added __hash__ and __eq__ methods.
2459         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added unit tests.
2460
2461 2011-07-23  Dimitri Glazkov  <dglazkov@chromium.org>
2462
2463         Extract TestConfiguration from base and write a few unit tests to capture current behavior.
2464         https://bugs.webkit.org/show_bug.cgi?id=65066
2465
2466         Reviewed by Adam Barth.
2467
2468         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added.
2469         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added.
2470         * Scripts/webkitpy/layout_tests/port/base.py: Moved code to test_configuration.py
2471
2472 2011-07-23  Alok Priyadarshi  <alokp@chromium.org>
2473
2474         Switching off acceleration for small canvas broke gpu tests
2475         https://bugs.webkit.org/show_bug.cgi?id=65053
2476
2477         Reviewed by Stephen White.
2478
2479         * DumpRenderTree/chromium/WebPreferences.cpp:
2480         (WebPreferences::reset):
2481         (WebPreferences::applyTo):
2482         * DumpRenderTree/chromium/WebPreferences.h:
2483
2484 2011-07-23  Keith Kyzivat  <keith.kyzivat@nokia.com>
2485
2486         [Qt] Add option to turn on disk caching in QtTestBrowser
2487         https://bugs.webkit.org/show_bug.cgi?id=65007
2488
2489         Reviewed by Noam Rosenthal.
2490
2491         Add menu item and command line option to turn on disk caching in
2492         QtTestBrowser. Simple QNetworkDiskCache added to the page's
2493         QNetworkAccssManager.
2494
2495         * QtTestBrowser/launcherwindow.cpp:
2496         (LauncherWindow::initializeView):
2497         (LauncherWindow::createChrome):
2498         (LauncherWindow::setDiskCache):
2499         * QtTestBrowser/launcherwindow.h:
2500         (WindowOptions::WindowOptions):
2501         * QtTestBrowser/main.cpp:
2502         (LauncherApplication::handleUserOptions):
2503
2504 2011-07-22  Ojan Vafai  <ojan@chromium.org>
2505
2506         Don't match 'DEBUG' when trying to filter BUG modifiers.
2507         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2508         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2509
2510 2011-07-22  Ojan Vafai  <ojan@chromium.org>
2511
2512         Fix issue loading gtests since there's no g_expectations.
2513         Also, make filing a bug file a webkit.org bug, not a crbug since
2514         the link is only shown for layout tests.
2515         * TestResultServer/static-dashboards/dashboard_base.js:
2516         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2517
2518 2011-07-22  Ojan Vafai  <ojan@chromium.org>
2519
2520         pull test expectations into the dashboard from wvn.webkit.org
2521         https://bugs.webkit.org/show_bug.cgi?id=65054
2522
2523         Reviewed by Adam Barth.
2524
2525         Now that svn.webkit.org supports cors headers, we can just grab the txt
2526         file from there instead of generating a JSON file that we upload
2527         to appengine. We'll stop generating the JSON file in a followup patch.
2528
2529         * TestResultServer/static-dashboards/dashboard_base.js:
2530         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2531         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2532
2533 2011-07-22  Adam Barth  <abarth@webkit.org>
2534
2535         Fix typo so the tool works on a case-sensitive file system.
2536
2537         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2538
2539 2011-07-22  Adam Barth  <abarth@webkit.org>
2540
2541         garden-o-matic should know what patches are landing
2542         https://bugs.webkit.org/show_bug.cgi?id=64978
2543
2544         Reviewed by Dimitri Glazkov.
2545
2546         This patch adds a display of the recently committed patches to
2547         garden-o-matic.  The UI needs iteration, but this patch establishes the
2548         plumbing.
2549
2550         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
2551             - Teach trac how to extract more information from the commit log.
2552         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
2553             - Add a data attribute for storing the revision.
2554         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2555             - Add a container for the recent commit history.
2556         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
2557             - CSS for displaying non-ugly commit history.
2558         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2559             - Wire up trac to the UI container.
2560         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
2561             - A basic, compact display for a list of commits.
2562
2563 2011-07-22  Ojan Vafai  <ojan@chromium.org>
2564
2565         Fix bug when switching from layout-tests to another test-type if
2566         ToT webkit.org is the selected group.
2567         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2568
2569 2011-07-22  Ojan Vafai  <ojan@chromium.org>
2570
2571         Add back in line accidentally deleted in http://trac.webkit.org/changeset/91612.
2572         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2573
2574 2011-07-22  Ojan Vafai  <ojan@chromium.org>
2575
2576         simplify the flakiness dashboard to only show modifiers/expectations for the current builder
2577         https://bugs.webkit.org/show_bug.cgi?id=65049
2578
2579         Reviewed by Tony Chang.
2580
2581         This communicates less information, but probably makes the dashboard more usable.
2582         Also make it show that bug lines that don't point to bug numbers still
2583         show up in the bugs column (e.g. BUG_TONY) and stop showing the extra/missing
2584         columns in any view. The data is still used, but only in the view that updates
2585         the test_expectations.txt file.
2586
2587         * TestResultServer/static-dashboards/dashboard_base.js:
2588         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2589         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2590
2591 2011-07-21  Ojan Vafai  <ojan@chromium.org>
2592
2593         hook in the rest of the bots to the dashboard now they run NRWT
2594         https://bugs.webkit.org/show_bug.cgi?id=64985
2595
2596         Reviewed by Adam Barth.
2597
2598         * TestResultServer/static-dashboards/builders.js:
2599
2600 2011-07-22  Alexey Proskuryakov  <ap@apple.com>
2601
2602         Adding Tim Horton to contributor list for Bugzilla auto-completion. He is CC'ed quite frequently.
2603
2604         Unreviewed.
2605
2606         * Scripts/webkitpy/common/config/committers.py:
2607
2608 2011-07-22  Michal Pakula vel Rutka  <m.pakula@samsung.com>
2609
2610         [EFL] ewk_frame_hit_test_new enchancement
2611         https://bugs.webkit.org/show_bug.cgi?id=64260
2612
2613         Apply changes done in ewk_frame_hit_test_new in EWebLauncher:
2614         Replacing Ewk_Hit_Test_Result_Context structure 'flags'
2615         in hit test output to by enum 'context'.
2616
2617         Reviewed by Antonio Gomes.
2618
2619         * EWebLauncher/main.c:
2620         (on_key_down):
2621
2622 2011-07-21  Adam Roben  <aroben@apple.com>
2623
2624         Fix typo in TestFailures
2625
2626         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
2627
2628 2011-07-21  Ojan Vafai  <ojan@chromium.org>
2629
2630         simplify gtest display now that we strip modifiers from the JSON
2631         https://bugs.webkit.org/show_bug.cgi?id=64990
2632
2633         Reviewed by Adam Barth.
2634
2635         Now that names are normalized, we can remove all the code that
2636         handles gtest name changes (e.g. for adding modifiers like DISABLED_).
2637         Instead, if you try to list a test with a modifier in it, we need
2638         to strip the modifier so we get the normalized value.
2639
2640         We also get rid of the concept of extra/missing expectations for gtests.
2641         In a patch soon, we'll stop showing extra/missing expectations from the UI
2642         entirely and only leave it for the special updating test_expectations.txt
2643         view of the dashboard, which doesn't apply to gtests.
2644
2645         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2646         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2647
2648 2011-07-21  Adam Barth  <abarth@webkit.org>
2649
2650         Refactor Trac.js for use in garden-o-matic
2651         https://bugs.webkit.org/show_bug.cgi?id=64998
2652
2653         Reviewed by Adam Roben.
2654
2655         This patch refactors Trac.js to match the architecture and style of
2656         garden-o-matic.  I've also factored AsynchronousCache out of Trac (and
2657         moved it to base) because it was redundant with some other code we
2658         already had.
2659
2660         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js:
2661         (FailingTestsBugForm):
2662         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
2663         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
2664         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
2665         (ViewController.prototype._displayBuilder.start):
2666         (ViewController.prototype._displayBuilder):
2667         (ViewController.prototype._domForRegressionRange.trac.getCommitDataForRevisionRange):
2668         (ViewController.prototype._domForRegressionRange):
2669         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
2670         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
2671         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
2672         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
2673         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2674
2675 2011-07-21  Ojan Vafai  <ojan@chromium.org>
2676
2677         Fix issue throwing a 500 to the bots. We were modifying
2678         the dictionary during an iteration over it's keys and would get
2679         RuntimeError: dictionary changed size during iteration
2680
2681         * TestResultServer/model/jsonresults.py:
2682
2683 2011-07-21  Adam Barth  <abarth@webkit.org>
2684
2685         ORWT fails to consume some NRWT arguments
2686         https://bugs.webkit.org/show_bug.cgi?id=64988
2687
2688         Reviewed by Adam Roben.
2689
2690         * Scripts/old-run-webkit-tests:
2691
2692 2011-07-21  Adam Barth  <abarth@webkit.org>
2693
2694         Merge TestFailures and garden-o-matic unit tests harness
2695         https://bugs.webkit.org/show_bug.cgi?id=64984
2696
2697         Reviewed by Adam Roben.
2698
2699         One unit testing framework is better than two.
2700
2701         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-more-unittests.html: Removed.
2702         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2703
2704 2011-07-21  Adam Barth  <abarth@webkit.org>
2705
2706         Rubber-stamped by Adam Roben.
2707
2708         Move garden-o-matic files into the same directory as TestFailures to
2709         make it easier to integrate the codebases.
2710
2711         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/base.js.
2712         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js.
2713         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js.
2714         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/checkout_unittests.js.
2715         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/config.js.
2716         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-green.png.
2717         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-red.png.
2718         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/index.html.
2719         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.css.
2720         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.js.
2721         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/partytime.gif: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/partytime.gif.
2722         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results.js.
2723         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js.
2724         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-more-unittests.html: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html.
2725         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js.
2726         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js.
2727         * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
2728         * Scripts/webkitpy/tool/commands/gardenomatic.py:
2729         * Scripts/webkitpy/tool/servers/data/gardeningserver: Removed.
2730         * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js: Removed.
2731         * Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js: Removed.
2732         * Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js: Removed.
2733         * Scripts/webkitpy/tool/servers/data/gardeningserver/checkout_unittests.js: Removed.
2734         * Scripts/webkitpy/tool/servers/data/gardeningserver/config.js: Removed.
2735         * Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-green.png: Removed.
2736         * Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-red.png: Removed.
2737         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html: Removed.
2738         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css: Removed.
2739         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js: Removed.
2740         * Scripts/webkitpy/tool/servers/data/gardeningserver/partytime.gif: Removed.
2741         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js: Removed.
2742         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js: Removed.
2743         * Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html: Removed.
2744         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js: Removed.
2745         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js: Removed.
2746         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2747
2748 2011-07-19  Ojan Vafai  <ojan@chromium.org>
2749
2750         fix links on the flakiness dashboard
2751         https://bugs.webkit.org/show_bug.cgi?id=64832
2752
2753         Reviewed by Tony Chang.
2754
2755         Make them actual anchor tags and linkify the test name instead of
2756         adding an extra link. Also simplify the update view since we now
2757         show the linkified test name.
2758
2759         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2760
2761 2011-07-21  Adam Barth  <abarth@webkit.org>
2762
2763         webkit.org builders should upload results to test-results AppEngine instance
2764         https://bugs.webkit.org/show_bug.cgi?id=64979
2765
2766         Reviewed by Adam Roben.
2767
2768         The master just needs to pass some flags to NRWT.  This patch also lets
2769         ORWT consume the flags (ignoring them) so we can pass the flags
2770         unconditionally.
2771
2772         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2773         * Scripts/old-run-webkit-tests:
2774
2775 2011-07-21  Ojan Vafai  <ojan@chromium.org>
2776
2777         normalize gtest names in the result json
2778         https://bugs.webkit.org/show_bug.cgi?id=64971
2779
2780         Reviewed by Eric Seidel.
2781
2782         This will make the resulting JSON smaller and make the
2783         flakiness dashboard much more sane (e.g. we won't need to
2784         show you the FLAKY_ version and the normal version).
2785
2786         * TestResultServer/model/jsonresults.py:
2787         * TestResultServer/model/jsonresults_unittest.py:
2788
2789 2011-07-21  Eric Seidel  <eric@webkit.org>
2790
2791         Unreviewed.  Reenable ORWT for the --leaks bot.
2792         Something is still wrong with the leaks summarizing
2793         but I'm about to head out on vacation for 2 weeks,
2794         so it's best to just revert back to ORWT until I'm back.
2795
2796         * Scripts/run-webkit-tests:
2797         (usingLeaks):
2798         (useNewRunWebKitTests):
2799
2800 2011-07-21  Ojan Vafai  <ojan@chromium.org>
2801
2802         cleanup jsonresults.py style in preparation for making some changes
2803         https://bugs.webkit.org/show_bug.cgi?id=64968
2804
2805         Reviewed by Adam Barth.
2806
2807         No code changes. Unittest still passes. Mostly just removing
2808         useless comments and 80 character wrapping.
2809
2810         * TestResultServer/model/jsonresults.py:
2811         * TestResultServer/model/jsonresults_unittest.py:
2812
2813 2011-07-21  Adam Barth  <abarth@webkit.org>
2814
2815         Add missing column header.
2816
2817         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
2818
2819 2011-07-21  Eric Seidel  <eric@webkit.org>
2820
2821         Unreviewed.  Just fixing (and unittesting) a previous typo.
2822
2823         Fix typo in print_leaks_summary regexp which was causing
2824         leaks summarizing to fail on the --leaks bot.
2825
2826         * Scripts/webkitpy/layout_tests/port/mac.py:
2827         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2828
2829 2011-07-21  Adam Barth  <abarth@webkit.org>
2830
2831         garden-o-matic should be able to rebaseline many tests at once
2832         https://bugs.webkit.org/show_bug.cgi?id=64963
2833
2834         Reviewed by Dimitri Glazkov.
2835
2836         This patch contains some UI for rebaselining tests in bulk.  I don't
2837         expect this UI to be the final UI, but the underlying infrastructure
2838         will be useful.
2839
2840         * Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js:
2841         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
2842         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
2843         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
2844         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
2845
2846 2011-07-21  Adam Barth  <abarth@webkit.org>
2847
2848         garden-o-matic has trouble when the same test fails in different ways on diffrent bots
2849         https://bugs.webkit.org/show_bug.cgi?id=64830
2850
2851         Unreviewed.  (Missing the patch is blocking me from fixing the tree.)
2852
2853         This patch is just some minor bug fixes.  One of the bugs results from
2854         the sadness of having two representations (a list and a space-separated
2855         string) for the set of failure types.
2856
2857         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
2858         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
2859         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
2860         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
2861
2862 2011-07-20  Ryosuke Niwa  <rniwa@webkit.org>
2863
2864         Buildbot marks a nrwt bot red when tests are missing results
2865         https://bugs.webkit.org/show_bug.cgi?id=64812
2866
2867         Reviewed by Adam Barth.
2868
2869         The bug was caused by multiple expressions matching on the single output.
2870         Fixed it by exiting the loop as soon as one expression matches.
2871
2872         Because the regular expression for 'failures' is most general,
2873         moved it to the end of the list to avoid it catching other cases.
2874
2875         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2876
2877 2011-07-20  Chang Shu  <cshu@webkit.org>
2878
2879         Adding myself to the reviewers list; No review needed.
2880
2881         * Scripts/webkitpy/common/config/committers.py:
2882
2883 2011-07-20  Eric Seidel  <eric@webkit.org>
2884
2885         new-run-webkit-tests --leaks does not restart DumpRenderTree often enough
2886         https://bugs.webkit.org/show_bug.cgi?id=64912
2887
2888         Reviewed by Adam Barth.
2889
2890         The bug was that set_default_option only works if the option's value
2891         is "None".  So I fixed --batch-size to default to None instead of 0
2892         (which kinda makes sense).
2893
2894         * Scripts/webkitpy/layout_tests/controllers/worker.py:
2895         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2896
2897 2011-07-20  Eric Seidel  <eric@webkit.org>
2898
2899         Make kill-old-processes kill httpd on mac
2900         https://bugs.webkit.org/show_bug.cgi?id=64898
2901
2902         Reviewed by Adam Barth.
2903
2904         * BuildSlaveSupport/kill-old-processes:
2905          - The line endings seem to have flipped again,
2906            Thus making this diff gigantic.  The only line
2907            changed is the "httpd" line.  I suspect we'll need
2908            to set the line ending style from an svn checkout.
2909
2910 2011-07-20  Ojan Vafai  <ojan@chromium.org>
2911
2912         show a list of average test times in the treemap
2913         https://bugs.webkit.org/show_bug.cgi?id=64899
2914
2915         Reviewed by Adam Roben.
2916
2917         For now, you click a link and it replaces the treemap
2918         with a reverse sorted list of directories based on
2919         average test runtime within that directory.
2920
2921         To cut some of the noise, we don't show directories
2922         that only have one test in them or where the average
2923         runtime is less than 100ms.
2924
2925         * TestResultServer/static-dashboards/treemap.html:
2926
2927 2011-07-20  Eric Seidel  <eric@webkit.org>
2928
2929         Teach build.webkit.org how to identify leaks in NRWT output
2930         https://bugs.webkit.org/show_bug.cgi?id=64891
2931
2932         Reviewed by Adam Barth.
2933
2934         This was the last remaining piece blocking turning on
2935         NRWT for the leaks bot, so I did that in this change too.
2936         If for some reason we see trouble on the bots, I'll
2937         revert that part of this change.
2938
2939         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2940         * Scripts/run-webkit-tests:
2941
2942 2011-07-20  Ojan Vafai  <ojan@chromium.org>
2943
2944         make the treemap display more human friendly
2945         https://bugs.webkit.org/show_bug.cgi?id=64896
2946
2947         Reviewed by Tony Chang.
2948
2949         * TestResultServer/static-dashboards/treemap.html:
2950
2951 2011-07-20  Eric Seidel  <eric@webkit.org>
2952
2953         Move HttpLock to using a FileSystem object
2954         https://bugs.webkit.org/show_bug.cgi?id=64885
2955
2956         Reviewed by Adam Barth.
2957
2958         I made a typo in my previous change, taking the value
2959         of read_text_file(pid_file) and setting it to lock_pid_file
2960         instead of current_pid.  Fixed now. :)
2961
2962         In order to test my new change I had to overhaul the unittests
2963         for this class to create a separate set of tests which work off
2964         of Mock objects instead of the real filesystem.
2965
2966         Since Executive doesn't yet wrap os.getpid() I added a FIXME
2967         in several places where we're currently calling os.getpid().  I
2968         felt adding Executive.getpid was outside of the scope of this change
2969         but once it exists some of this code will be much simpler to mock.
2970
2971         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2972         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
2973         * Scripts/webkitpy/tool/mocktool.py:
2974
2975 2011-07-20  Adam Roben  <aroben@apple.com>
2976
2977         Fix typo in TestFailures's Bugzilla constants
2978
2979         This was preventing the "Version" field from being pre-filled when filing new bugs.
2980
2981         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js:
2982
2983 2011-07-20  Eric Seidel  <eric@webkit.org>
2984
2985         Move HttpLock to using a FileSystem object
2986         https://bugs.webkit.org/show_bug.cgi?id=64885
2987
2988         Reviewed by Adam Barth.
2989
2990         There is no functional change here.  Just moving off
2991         of direct os.foo calls to their filesystem equivalent.
2992
2993         This makes it possible to now unittest HttpLock using a
2994         MockFileSystem instead of needing to talk to the filesystem directly.
2995
2996         This also will have changed any port test cases which were using a
2997         mock file system to now have an HttpLock based on a mock filesystem
2998         instead.  I saw no change in the unittests so it's possible
2999         we're not testing that configuration (or more likely that it "just works").
3000
3001         * Scripts/webkitpy/layout_tests/port/base.py:
3002         * Scripts/webkitpy/layout_tests/port/http_lock.py:
3003         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
3004
3005 2011-07-20  Adam Barth  <abarth@webkit.org>
3006
3007         NRWT results uses too much space per run
3008         https://bugs.webkit.org/show_bug.cgi?id=64845
3009
3010         Reviewed by Ojan Vafai.
3011
3012         Removing these files saves about 750K per build.
3013
3014         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3015
3016 2011-07-20  Zan Dobersek  <zandobersek@gmail.com>
3017
3018         [Gtk] [NRWT] Xvfb produces a lot of stderr output
3019         https://bugs.webkit.org/show_bug.cgi?id=64669
3020
3021         Reviewed by Philippe Normand.
3022
3023         Redirect the stderr output of the driver's Xvfb process
3024         to /dev/null to suppress unneeded output.
3025
3026         * Scripts/webkitpy/layout_tests/port/gtk.py:
3027
3028 2011-07-19  Eric Seidel  <eric@webkit.org>
3029
3030         parse-malloc-history always exits 1, causing NRWT to fail
3031         https://bugs.webkit.org/show_bug.cgi?id=64835
3032
3033         Reviewed by Adam Barth.
3034
3035         ORWT just never checked the return code. :)
3036
3037         * Scripts/parse-malloc-history:
3038         (main):
3039         * Scripts/webkitpy/layout_tests/port/mac.py:
3040
3041 2011-07-19  Kevin Ollivier  <kevino@theolliviers.com>
3042
3043         [wx] Unreviewed build fix, don't add the debug prefix as 2.9 no longer uses one.
3044
3045         * waf/build/wxpresets.py:
3046
3047 2011-07-19  Eric Seidel  <eric@webkit.org>
3048
3049         new-run-webkit-tests should only enable MallocStackLogging for DRT
3050         https://bugs.webkit.org/show_bug.cgi?id=64792
3051
3052         Reviewed by Adam Barth.
3053
3054         The previous code would enable it for all servers launched
3055         by the port, which included Apache, the python websocket server
3056         as well as ImageDiff.  Now only DumpRenderTree will have
3057         MallocStackLogging enabled or the GuardMalloc library injected.
3058
3059         I also cleaned up the websocket_server code to use filesystem
3060         while I was in it.
3061
3062         I also made DRT restart every 1000 tests when running with
3063         --leaks enabled.  I believe this made the --leaks run slightly
3064         faster, but it still takes over an hour on my machine. :(
3065
3066         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3067         * Scripts/webkitpy/layout_tests/port/base.py:
3068         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3069         * Scripts/webkitpy/layout_tests/port/gtk.py:
3070         * Scripts/webkitpy/layout_tests/port/mac.py:
3071         * Scripts/webkitpy/layout_tests/port/qt.py:
3072         * Scripts/webkitpy/layout_tests/port/server_process.py:
3073         * Scripts/webkitpy/layout_tests/port/webkit.py:
3074         * Scripts/webkitpy/layout_tests/servers/http_server.py:
3075         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
3076
3077 2011-07-19  Ojan Vafai  <ojan@chromium.org>
3078
3079         remove the concept of platform fallbacks
3080         https://bugs.webkit.org/show_bug.cgi?id=64829
3081
3082         Reviewed by Adam Barth.
3083         
3084         In the process, wrote tests for this code and fixed a pretty major
3085         bug (now covered by the test).
3086
3087         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3088         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3089
3090 2011-07-19  Ojan Vafai  <ojan@chromium.org>
3091
3092         cleanup some of the PLATFORM logic in the flakiness dashboard
3093         https://bugs.webkit.org/show_bug.cgi?id=64821
3094
3095         Reviewed by Adam Barth.
3096
3097         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3098         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3099
3100 2011-07-19  Ojan Vafai  <ojan@chromium.org>
3101
3102         cleanup some of the PLATFORM logic in the flakiness dashboard
3103         https://bugs.webkit.org/show_bug.cgi?id=64821
3104
3105         Reviewed by Adam Barth.
3106
3107         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3108         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3109
3110 2011-07-19  Dimitri Glazkov  <dglazkov@chromium.org>
3111
3112         Store line number on TestExpectationLine.
3113         https://bugs.webkit.org/show_bug.cgi?id=64800
3114
3115         Reviewed by Adam Barth.
3116
3117         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Refactored to store line number on TestExpectationLine instances.
3118
3119 2011-07-19  Ojan Vafai  <ojan@chromium.org>
3120
3121         fix flakiness dashboard for XP bots with XP in the name instead of WIN
3122         https://bugs.webkit.org/show_bug.cgi?id=64826
3123
3124         Reviewed by Mihai Parparita.
3125
3126         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3127         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3128
3129 2011-07-19  Cary Clark  <caryclark@google.com>
3130
3131         add myself to committers.py
3132         https://bugs.webkit.org/show_bug.cgi?id=64816
3133
3134         No review needed.
3135
3136         * Scripts/webkitpy/common/config/committers.py:
3137
3138 2011-07-19  Daniel Bates  <dbates@webkit.org>
3139
3140         Rename variable isEmptyTextPatch in svn-{apply, unapply}
3141         https://bugs.webkit.org/show_bug.cgi?id=64648
3142
3143         Reviewed by Adam Roben.
3144
3145         Rename the variable isEmptyTextPatch to hasTextChunks, which is
3146         more descriptive and makes its usage read well in control statements.
3147
3148         * Scripts/svn-apply:
3149         (patch):
3150         * Scripts/svn-unapply:
3151         (patch):
3152
3153 2011-07-19  Adam Roben  <aroben@apple.com>
3154
3155         Make TestFailures show existing bugs and a new bug link for flaky tests
3156
3157         Fixes <http://webkit.org/b/63728> TestFailures page should make it easy to file bugs about
3158         flaky tests
3159         and
3160         <http://webkit.org/b/63830> TestFailures page doesn't show related bugs for possibly-flaky
3161         tests, but should
3162
3163         Reviewed by Sam Weinig.
3164
3165         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js:
3166         Added. This is what's used to file new bugs about flaky tests.
3167         (FlakyTestBugForm): Calls up to the base class, stores the arguments, and sets our
3168         title, description, and URL.
3169
3170         (FlakyTestBugForm.prototype._createBugDescription):
3171         (FlakyTestBugForm.prototype._createBugTitle):
3172         These do what they say.
3173
3174         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js:
3175         Added. Tests of the above.
3176
3177         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
3178         (#failure-history > li):
3179         (#possibly-flaky-tests > li):
3180         (#failure-history > li, #possibly-flaky-tests > li):
3181         (#possibly-flaky-tests > li > :first-child):
3182         (.flakiness-examples-list):
3183         Styling to account for the new elements.
3184
3185         (.expandable):
3186         (.expanded > .expandable):
3187         Generalized the .flakiness-example-list code to a generic .expandable class. Removed the
3188         transition properties because we can't transition to/from 'auto' (but really would like
3189         to!).
3190
3191         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
3192         (ViewController.prototype._displayBuilder): Moved code to create the FailingTestsBugForm
3193         here from _domForNewAndExistingBugs. Updated for changes to _domForPossiblyFlakyTests.
3194         (ViewController.prototype._domForNewAndExistingBugs): Changed to take a NewBugForm as an
3195         argument instead of creating one ourselves.
3196         (ViewController.prototype._domForPossiblyFlakyTests): Changed to take all analyzed builds as
3197         an argument instead of just the number of analyzed builds. Put the examples list inside a
3198         container <div>, which is also used to hold the new/existing bugs UI. Removed code to deal
3199         with animating the height of the examples list; we don't do this anymore because it's hard
3200         to make it work correctly with the asynchronous loading of existing bugs. When we populate
3201         the examples list, also set up the new/existing bug UI.
3202
3203         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
3204         FlakyTestBugForm.
3205
3206         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
3207         Pull in FlakyTestBugForm and its tests.
3208
3209 2011-07-19  Ryosuke Niwa  <rniwa@webkit.org>
3210
3211         Buildbot marks a nrwt bot red when tests are missing results
3212         https://bugs.webkit.org/show_bug.cgi?id=64812
3213
3214         Reviewed by Tony Chang.
3215
3216         Added "missing results" label for tests that are missing results.
3217
3218         buildbot Now reports shows a label "X missing results" on a run when X tests were missing
3219         expected results on that run.
3220
3221         Also rephrased "X failed" and "X were flaky" to "X failures" and "X flakes".
3222
3223         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3224
3225 2011-07-19  Adam Roben  <aroben@apple.com>
3226
3227         Extract some of FailingTestsBugForm's code into a base class
3228
3229         Prep work for fixing <http://webkit.org/b/63728> TestFailures page should make it easy to
3230         file bugs about flaky tests
3231
3232         Reviewed by Sam Weinig.
3233
3234         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js:
3235         Moved BugzillaConstants to new WebKitBugzilla file. Moved a bunch of other code from here to
3236         TestRelatedBugForm.js.
3237
3238         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
3239         Moved some tests to TestRelatedBugForm_unittests.js.
3240
3241         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js: Added.
3242         (TestRelatedBugForm):
3243         (TestRelatedBugForm.prototype.domElement):
3244         (TestRelatedBugForm.prototype._computeOperatingSystem):
3245         (TestRelatedBugForm.prototype._computePlatform):
3246         Code came from FailingTestsBugForm.
3247
3248         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js:
3249         Added. Tests came from FailingTestsBugForm_unittests.js
3250
3251         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js:
3252         Added. Code came from FailingTestsBugForm.js.
3253
3254         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
3255         TestRelatedBugForm.js and WebKitBugzilla.js. Moved Bugzilla.js out of the list of files that
3256         need to be pulled in early for parsing reasons.
3257
3258         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
3259         Pull in TestRelatedBugForm and tests and WebKitBugzilla.
3260
3261 2011-07-19  Sam Weinig  <sam@webkit.org>
3262
3263         Remove obsolete Mac NRWT test bots
3264         https://bugs.webkit.org/show_bug.cgi?id=64806
3265
3266         Reviewed by Adam Roben.
3267
3268         Remove "Leopard Intel Release (NRWT)" and "SnowLeopard Intel Release (NRWT)"
3269         which have been disconnected for some time and have been obsoleted by
3270         the main testers using NRWT.
3271
3272         * BuildSlaveSupport/build.webkit.org-config/config.json:
3273
3274 2011-07-19  Sam Weinig  <sam@webkit.org>
3275
3276         webkit-patch rebaseline crashes on use
3277         https://bugs.webkit.org/show_bug.cgi?id=64775
3278
3279         Reviewed by Adam Roben.
3280
3281         Fix incorrectly spelled attribute name.
3282
3283         * Scripts/webkitpy/common/net/layouttestresults.py:
3284         The attribute is test_name, not filename.
3285
3286         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3287         Add test for tests_matching_failure_types.
3288
3289 2011-07-18  Eric Seidel  <eric@webkit.org>
3290
3291         new-run-webkit-tests should support --leaks
3292         https://bugs.webkit.org/show_bug.cgi?id=63832
3293
3294         Reviewed by Dirk Pranke.
3295
3296         This may not be sufficient to actually transition over the leaks bot,
3297         but this is a huge step in the right direction.
3298
3299         I had to make parse-malloc-history understand being passed more than
3300         one file (to avoid the silly cat | nonsense in old-run-webkit-tests).
3301
3302         I removed some dead code relating to previous iterations of our crash detection.
3303
3304         I created a new class "LeakDetector" to encapsulate all this logic.
3305         Eventually we should consider pulling that class out of mac.py and
3306         sharing with other ports.  However given that ORWT has had
3307         --leaks support on Mac for almost 7 years and no other port has added
3308         it, leaves me to believe we're in no rush to move LeakDetector.
3309
3310         I've tested --leaks locally.  I suspect there are more bugs to shake out
3311         but it seems to work well enough to start.
3312
3313         I also added support for --guard-malloc, but have not tested it much.  It
3314         should be viewed as experimental at this time.
3315
3316         I also fixed various os.path uses to self._filesystem as I was reading
3317         through the various files to understand how best to fix this bug.
3318
3319         * Scripts/old-run-webkit-tests:
3320         (parseLeaksandPrintUniqueLeaks):
3321         * Scripts/parse-malloc-history:
3322         (main):
3323         * Scripts/webkitpy/common/system/crashlogs.py:
3324         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3325         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3326         * Scripts/webkitpy/layout_tests/port/base.py:
3327         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3328         * Scripts/webkitpy/layout_tests/port/gtk.py:
3329         * Scripts/webkitpy/layout_tests/port/mac.py:
3330         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3331         * Scripts/webkitpy/layout_tests/port/server_process.py:
3332         * Scripts/webkitpy/layout_tests/port/webkit.py:
3333         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3334
3335 2011-07-19  Adam Barth  <abarth@webkit.org>
3336
3337         garden-o-matic should have a "Triage Failures" button for iterating over failures
3338         https://bugs.webkit.org/show_bug.cgi?id=64769
3339
3340         Reviewed by Eric Seidel.
3341
3342         This patch adds some global static state and refactors things a bit so
3343         that we can iterate over all the failures in the details pane.
3344
3345         * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
3346             - Add a generic callback iterator to iterate through a series of
3347               callbacks. We use this to iterate through the failures we want to
3348               display the details of.
3349         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
3350             - Add a toolbar for the results summary and change the buttons to
3351               be real buttons.
3352         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
3353             - Make the detail pane 75% of the window.
3354             - Make the buttons pretty.
3355             - Allow the failure type badges to apply to the details pane as well.
3356         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
3357             - Restructure how we bring up the details pane so we can iterate
3358               through a bunch of failures.
3359             - Remove the transition between results details because it's
3360               annoying when you want to click through a bunch of failures.
3361         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
3362             - Add some more structure to the title bar for the results details
3363               so it's clearer which results we're currently displaying.
3364
3365 2011-07-19  Adam Barth  <abarth@webkit.org>
3366
3367         garden-o-matic should live update as conditions change on the buildbot
3368         https://bugs.webkit.org/show_bug.cgi?id=64646
3369
3370         Reviewed by Eric Seidel.
3371
3372         This patch causes the garden-o-matic display to update every 10 minutes
3373         to show the latest failures.  This patch required a moderately large
3374         refactoring of main.js to make the display incremental instead of
3375         all-at-once.
3376
3377         * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
3378         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
3379         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
3380         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
3381
3382 2011-07-18  Tab Atkins  <jackalmage@gmail.com>
3383
3384         Tab Atkins is not in committers.py (as a non-committer)
3385         https://bugs.webkit.org/show_bug.cgi?id=64770
3386
3387         Reviewed by Eric Seidel.
3388
3389         * Scripts/webkitpy/common/config/committers.py:
3390
3391 2011-07-18  Ojan Vafai  <ojan@chromium.org>
3392
3393         Load ToT chromium bots by default in the flakiness dashboard
3394         https://bugs.webkit.org/show_bug.cgi?id=64756
3395
3396         Reviewed by Adam Barth.
3397
3398         For now, these are the most useful bots to look at. Eventually,
3399         we may want to load the build.webkit.org bots by default once
3400         most of the bots there upload results.
3401
3402         * TestResultServer/static-dashboards/dashboard_base.js:
3403
3404 2011-07-13  Jon Honeycutt  <jhoneycutt@apple.com>
3405
3406         Focus and selection events are not fired when a <select>'s selection
3407         changes
3408         https://bugs.webkit.org/show_bug.cgi?id=64504
3409         <rdar://problem/9319881>
3410
3411         Reviewed by Alice Liu.
3412
3413         * DumpRenderTree/AccessibilityController.h:
3414         Added m_notificationsEventHook for addNotificationListener().
3415         m_allEventsHook will now be used for setLogAccessibilityEvents().
3416
3417         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3418         (AccessibilityController::AccessibilityController):
3419         Initialize m_notificationsEventHook.
3420         (AccessibilityController::~AccessibilityController):
3421         Turn off logging of all accessibility events. If
3422         m_notificationsEventHook is non-null, unhook it.
3423         (logEventProc):
3424         Add handling of EVENT_OBJECT_SELECTION.
3425         (AccessibilityController::setLogAccessibilityEvents):
3426         If the state of logging is not changing, return early. If we're turning
3427         off logging, unhook m_allEventsHook, and zero it out. Otherwise, add a
3428         hook for all events.
3429         (AccessibilityController::addNotificationListener):
3430         Use m_notificationsEventHook rather than m_allEventsHook.
3431
3432 2011-07-18  Eric Seidel  <eric@webkit.org>
3433
3434         webkit-patch apply-attachment does not work when not called from the root of the checkout
3435         https://bugs.webkit.org/show_bug.cgi?id=64751
3436
3437         Unreviewed.  Just updating unit test results after bug 64751.
3438
3439         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3440         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3441
3442 2011-07-18  Adam Barth  <abarth@webkit.org>
3443
3444         simplejson has trouble on chromium-linux
3445         https://bugs.webkit.org/show_bug.cgi?id=64757
3446
3447         Reviewed by Eric Seidel.
3448
3449         Use the native JSON, if available.
3450
3451         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3452
3453 2011-07-18  Ojan Vafai  <ojan@chromium.org>
3454
3455         update the flakiness dashboard to understand the new platforms/formats in test_expectations
3456         https://bugs.webkit.org/show_bug.cgi?id=64743
3457
3458         Reviewed by Adam Barth.
3459
3460         The test expectations format changed a long time ago and the flakiness dashboard
3461         was never updated to match.
3462
3463         * TestResultServer/static-dashboards/dashboard_base.js:
3464         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3465         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3466         * TestResultServer/static-dashboards/timeline_explorer.html:
3467
3468 2011-07-18  Eric Seidel  <eric@webkit.org>
3469
3470         webkit-patch apply-attachment does not work when not called from the root of the checkout
3471         https://bugs.webkit.org/show_bug.cgi?id=64751
3472
3473         Reviewed by Adam Barth.
3474
3475         Last week I removed a os.chdir in EnsureWorkingDirectoryClean, which
3476         is a step that we run for most commands (as one of the earliest steps).
3477         EnsureWorkingDirectoryClean was incorrectly calling os.chdir to change
3478         the CWD to the checkout root.  This magically made a bunch of otherwise
3479         wrong code work.
3480
3481         When I realized that apply-attachment no longer worked as expected today,
3482         I went and fixed the bug, then realizing that we were not testing
3483         what the cwd was when running various commands.  I fixed our MockExecutive
3484         to always log what the cwd is and fixed a whole bunch of places
3485         where we needed to be setting the cwd.
3486
3487         Hopefully this will solve our cwd problems once and for-all, and webkit-patch
3488         will again correctly work when called from any directory (including outside
3489         of a webkit checkout).
3490
3491         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3492         * Scripts/webkitpy/common/system/executive.py:
3493         * Scripts/webkitpy/common/system/workspace_unittest.py:
3494         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3495         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3496         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3497         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3498         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3499         * Scripts/webkitpy/tool/bot/irc_command.py:
3500         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3501         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3502         * Scripts/webkitpy/tool/commands/download_unittest.py:
3503         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3504         * Scripts/webkitpy/tool/commands/queues.py:
3505         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3506         * Scripts/webkitpy/tool/commands/queuestest.py:
3507         * Scripts/webkitpy/tool/mocktool.py:
3508         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3509         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3510         * Scripts/webkitpy/tool/steps/build.py:
3511         * Scripts/webkitpy/tool/steps/checkstyle.py:
3512         * Scripts/webkitpy/tool/steps/editchangelog.py:
3513         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3514         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3515         * Scripts/webkitpy/tool/steps/runtests.py:
3516         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3517         * Scripts/webkitpy/tool/steps/update.py:
3518
3519 2011-07-18  Adam Barth  <abarth@webkit.org>
3520
3521         Increase information garden-o-matic information density by switching to a table
3522         https://bugs.webkit.org/show_bug.cgi?id=64642
3523
3524         Reviewed by Dimitri Glazkov.
3525
3526         The old layout couldn't handle the large number of failures we had
3527         today.  This patch switches garden-o-matic to a table-based layout,
3528         which can handle many more failures gracefully.  (I expect we'll need
3529         more UI iterations.)
3530
3531         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
3532         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
3533         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
3534         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
3535
3536 2011-07-18  Adam Barth  <abarth@webkit.org>
3537
3538         garden-o-matic should be able to determine when compile breaks
3539         https://bugs.webkit.org/show_bug.cgi?id=64190
3540
3541         Reviewed by Dimitri Glazkov.
3542
3543         This patch adds a red-ish box to the top of the page whenever there is
3544         a compile error on the bots.  The box automatically opens and closes as
3545         appropriate and links to the waterfall display.  In the future, we
3546         might want to compute a regression range.
3547
3548         * Scripts/webkitpy/tool/servers/data/gardeningserver/config.js:
3549             - Add the build-only bots to the config.  We use these to check
3550               whether the build failed, which is faster than waiting for the
3551               tester bots to cycle.
3552         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
3553             - Add DOM for the alert bar.
3554         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
3555             - CSS to support the alert bar.
3556         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
3557             - Wiring up events to poll the buildbot to see whether compile has
3558               failed.
3559         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
3560             - Infrastructure for fetching and parsing the buildbot status JSON
3561               blob.  This code could be better factored for testability.  :(
3562         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
3563             - UI for displaying compile errors.
3564         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
3565
3566 2011-07-18  Sheriff Bot  <webkit.review.bot@gmail.com>
3567
3568         Unreviewed, rolling out r91132 and r91135.
3569         http://trac.webkit.org/changeset/91132
3570         http://trac.webkit.org/changeset/91135
3571         https://bugs.webkit.org/show_bug.cgi?id=64681
3572
3573         Broke GTK and Chromium debug bots (Requested by rniwa on
3574         #webkit).
3575
3576         * DumpRenderTree/AccessibilityController.h:
3577         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3578         (AccessibilityController::AccessibilityController):
3579         (AccessibilityController::~AccessibilityController):
3580         (logEventProc):
3581         (AccessibilityController::setLogAccessibilityEvents):
3582         (AccessibilityController::addNotificationListener):
3583
3584 2011-07-17  Philippe Normand  <pnormand@igalia.com>
3585
3586         test-webkitpy failing with Python 2.5
3587         https://bugs.webkit.org/show_bug.cgi?id=64594
3588
3589         Reviewed by Eric Seidel.
3590
3591         Updated simplejson to version 2.1.6 that fixes an issue when
3592         dumping slashes. Also use cgi.parse_qs instead of the urlparse
3593         version to be compatible with Python2.5. Verified the fix with
3594         test-webkitpy on python 2.5 and python 2.6.
3595
3596         * Scripts/webkitpy/thirdparty/simplejson/README.txt:
3597         * Scripts/webkitpy/thirdparty/simplejson/__init__.py:
3598         * Scripts/webkitpy/thirdparty/simplejson/_speedups.c:
3599         (json_PyOS_string_to_double):
3600         (_convertPyInt_AsSsize_t):
3601         (_convertPyInt_FromSsize_t):
3602         (ascii_escape_char):
3603         (ascii_escape_unicode):
3604         (ascii_escape_str):
3605         (raise_errmsg):
3606         (join_list_unicode):
3607         (join_list_string):
3608         (_build_rval_index_tuple):
3609         (scanstring_str):
3610         (scanstring_unicode):
3611         (py_scanstring):
3612         (py_encode_basestring_ascii):