f44e585acdfcd79df739f86e9cb6600a48699bf5
[WebKit-https.git] / Tools / ChangeLog
1 2012-01-19  Ben Wells  <benwells@chromium.org>
2
3         Add support for window.print to chromium DRT
4         https://bugs.webkit.org/show_bug.cgi?id=76479
5
6         When used in a test window.print goes into print mode and then
7         straight out again. This will allow the afterprint event to be
8         tested by having the afterprint event happen before the dump
9         happens.
10
11         Reviewed by Mihai Parparita.
12
13         * DumpRenderTree/chromium/WebViewHost.cpp:
14         (WebViewHost::printPage):
15         * DumpRenderTree/chromium/WebViewHost.h:
16
17 2012-01-18  Enrica Casucci  <enrica@apple.com>
18
19         editingAttributedStringFromRange in WebHTMLConverter does not handle NSUnderlineStyleAttributeName.
20         https://bugs.webkit.org/show_bug.cgi?id=76588
21         <rdar://problem/9325183>
22
23         Added test.
24         
25         Reviewed by Dan Bernstein.
26
27         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
28         (TestWebKitAPI::TEST):
29
30 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
31
32         [Qt] Do full incremental builds until bots use update-webkit
33
34         Rubber-stamped by Simon Hausmann.
35
36         * Scripts/webkitdirs.pm:
37         (buildQMakeProjects):
38
39 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
40
41         Fix the Qt build
42
43         Unreviewed build fix.
44
45         * Scripts/webkitdirs.pm:
46         (buildQMakeProjects):
47
48 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
49
50         [Qt] Make build-webkit always do safe incremental builds after update-webkit
51
52         When building against Qt5 with GCC we would just run 'make' in the build dir,
53         and rely on the dependency files output by GCC (-MD) to handle dependency
54         tracking, but that fails for special-cases like adding a Q_OBJECT macro
55         to a header.
56
57         To guarantee that an incrmental build will work, we have to run 'make qmake',
58         which we now do on every build-webkit that's followed by a successful run
59         of update-webkit. The reasoning is that update-webkit can result in such
60         potential corner-cases being applied, and since we can't know for sure
61         unless we inspect the diff and account for all the corner cases we assume
62         the worst and always run 'make qmake'.
63
64         After a succesful run of build-webkit we proceed to do just 'make' for any
65         subsequent runs, since we assume that the developer knows what kind of
66         changes he/she is doing, and when a 'make qmake' is needed.
67
68         Reviewed by Simon Hausmann.
69
70         * Scripts/update-webkit:
71         * Scripts/webkitdirs.pm:
72         (determineCurrentSVNRevision):
73         (currentSVNRevision):
74         (buildQMakeProjects):
75         * qmake/mkspecs/features/default_post.prf:
76
77 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
78
79         run-perf-tests should support Skipped list
80         https://bugs.webkit.org/show_bug.cgi?id=76594
81
82         Reviewed by Adam Barth.
83
84         Add a support for Skipped list in run-perf-tests; also skip files in resources directories.
85
86         * Scripts/webkitpy/layout_tests/port/base.py:
87         (Port.perf_tests_dir):
88         (Port.skipped_perf_tests):
89         (Port.skips_perf_test):
90         (Port.relative_perf_test_filename):
91         * Scripts/webkitpy/layout_tests/port/test.py:
92         (TestPort.perf_tests_dir):
93         * Scripts/webkitpy/layout_tests/port/webkit.py:
94         (WebKitPort._expectations_from_skipped_files):
95         (WebKitPort):
96         (WebKitPort.skipped_layout_tests):
97         (WebKitPort.skipped_perf_tests):
98         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
99         (PerfTestsRunner._collect_tests):
100         (PerfTestsRunner.run):
101         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
102         (test_run_test_set_with_json_output):
103         (test_run_test_set_with_json_source):
104         (test_collect_tests_with_skipped_list):
105         (test_collect_tests_with_skipped_list.add_file):
106
107 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
108
109         Fix path to chromium_src_dir introduced in previous change.
110
111         Unreviewed, build fix.
112
113         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
114
115 2012-01-18  Alexey Proskuryakov  <ap@apple.com>
116
117         Need infrastructure to test Content-Disposition filename encoding support
118         https://bugs.webkit.org/show_bug.cgi?id=76572
119         <rdar://problem/6421825>
120
121         Reviewed by Sam Weinig.
122
123         Made policy delegate log suggested file name when resource has Content-Disposition: attachment.
124
125         WebKitTestRunner does not have a policy delegate yet, bug 42546.
126
127         * DumpRenderTree/mac/PolicyDelegate.mm:
128         (dispositionTypeFromContentDispositionHeader):
129         (-[PolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
130
131 2012-01-18  Ojan Vafai  <ojan@chromium.org>
132
133         Fix tests from http://trac.webkit.org/changeset/105332.
134
135         The code assumed that if you passed an options object with a configuration
136         attribute that it would have a valid value. A bunch of the testing mocks
137         do things like having a configuration value of None.
138
139         * Scripts/webkitpy/layout_tests/port/base.py:
140         (Port.__init__):
141
142 2012-01-18  Ojan Vafai  <ojan@chromium.org>
143
144         Shave 0.5 seconds off check-webkit-style runtime for test_expectations.txt
145         https://bugs.webkit.org/show_bug.cgi?id=76576
146
147         Reviewed by Adam Barth.
148
149         Avoid calling default_configuration in base.py. We don't need it for
150         checking test_expectations.txt style. It takes ~0.5 seconds to run on my
151         Mac Pro. It's the call to "perl Tools/Scripts/webkit-build-directory --top-level"
152         from common.executive.
153
154         At some point someone should probably look into why that call is so slow
155         since it's on the critical path for run-webkit-tests and build-webkit startup.
156
157         * Scripts/webkitpy/layout_tests/port/base.py:
158         (Port.__init__):
159         * Scripts/webkitpy/style/checkers/test_expectations.py:
160         (TestExpectationsChecker._determine_port_from_exepectations_path):
161
162 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
163
164         [chromium] move Tools.gyp, switch build-webkit --chromium to All.gyp
165         https://bugs.webkit.org/show_bug.cgi?id=76505
166
167         Reviewed by Tony Chang.
168
169         Update chromium build script to use All.gyp instead of WebKit.gyp
170
171         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Renamed from Source/WebKit/chromium/Tools.gyp.
172         * Scripts/webkitdirs.pm:
173
174 2012-01-18  Sam Weinig  <sam@webkit.org>
175
176         Don’t hardcode the path to ‘make‘.
177
178         Reviewed by Dan Bernstein.
179
180         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
181
182 2012-01-18  Joshua Bell  <jsbell@chromium.org>
183
184         Adding myself to committers.py
185         https://bugs.webkit.org/show_bug.cgi?id=76569
186
187         Unreviewed.
188
189         * Scripts/webkitpy/common/config/committers.py:
190
191 2012-01-18  Adam Barth  <abarth@webkit.org>
192
193         Up the cap on test failures tolerated by the EWS so the mac-ews can run to completion
194         https://bugs.webkit.org/show_bug.cgi?id=76567
195
196         Reviewed by Eric Seidel.
197
198         Current the AppleMac port has slightly more failures than we allow on
199         the EWS, causing the mac-ews to spin.  This patch ups the limit a bit,
200         which should hopefully let the mac-ews run to completion.  Once
201         AppleMac has fewer failures, we can lower the cap again.
202
203         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
204         (LayoutTestResultsReaderTest.test_layout_test_results):
205         * Scripts/webkitpy/tool/steps/runtests.py:
206         (RunTests):
207         * Scripts/webkitpy/tool/steps/steps_unittest.py:
208
209 2012-01-18  Eric Carlson  <eric.carlson@apple.com>
210
211         Provide access to user's list of preferred languages
212         https://bugs.webkit.org/show_bug.cgi?id=76138
213
214         Reviewed by Alexey Proskuryakov.
215
216         * GNUmakefile.am: Add JSInternalsCustom.cpp.
217
218 2012-01-18  Adam Barth  <abarth@webkit.org>
219
220         Add Chromium Linux GPU 32 to the list of allowed Chromium Linux
221         configurations.
222
223         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
224         (ChromiumLinuxPort.__init__):
225
226 2012-01-18  Dominic Mazzoni  <dmazzoni@google.com>
227
228         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
229         https://bugs.webkit.org/show_bug.cgi?id=73460
230
231         Reviewed by Chris Fleizach.
232
233         * DumpRenderTree/AccessibilityUIElement.h:
234         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
235         (AccessibilityUIElement::AccessibilityUIElement):
236         (AccessibilityUIElement::scrollToMakeVisibleCallback):
237         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
238         (AccessibilityUIElement::scrollToGlobalPointCallback):
239         * DumpRenderTree/chromium/AccessibilityUIElement.h:
240         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
241         (AccessibilityUIElement::scrollToMakeVisible):
242         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
243         (AccessibilityUIElement::scrollToGlobalPoint):
244         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
245         (AccessibilityUIElement::scrollToMakeVisible):
246         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
247         (AccessibilityUIElement::scrollToGlobalPoint):
248         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
249         (AccessibilityUIElement::scrollToMakeVisible):
250         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
251         (AccessibilityUIElement::scrollToGlobalPoint):
252
253 2012-01-17  Enrica Casucci  <enrica@apple.com>
254
255         Missing NSForegroundColorAttributeName should be treated as black instead of transparent.
256         https://bugs.webkit.org/show_bug.cgi?id=76490
257         <rdar://problem/9460733>
258
259         Added TestWebKitAPI test.
260         
261         Reviewed by Dan Bernstein.
262
263         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new test file.
264         * TestWebKitAPI/Tests/mac/InspectorBar.mm: Added test that calls
265         changeAttributes to the WebView.
266         
267 2012-01-18  Balazs Kelemen  <kbalazs@webkit.org>
268
269         [Qt] Consolidate layout test crash logging
270         https://bugs.webkit.org/show_bug.cgi?id=75088
271
272         Reviewed by Simon Hausmann.
273
274         Move backtrace generating logic into WTFReportBacktrace
275         and add a way to deinstall signal handlers if we know
276         that we have already printed the backtrace.
277
278         * DumpRenderTree/qt/main.cpp:
279         (crashHandler):
280         (setupSignalHandlers):
281         (WTFCrashHook):
282         (main):
283         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
284         (WTR::crashHandler):
285         (WTR::setupSignalHandlers):
286         (WTR::crashHook):
287         (WTR::InjectedBundle::platformInitialize):
288
289 2012-01-18  Ilya Tikhonovsky  <loislo@chromium.org>
290
291         Unreviewed build fix after r105256.
292
293         There was a cyclic dependency between self._port and self._host assigments.
294
295         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
296         (PerfTestsRunner.__init__):
297
298 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
299
300         Add new watchlist rule for the Qt build system
301
302         Reviewed by Simon Hausmann.
303
304         * Scripts/webkitpy/common/config/watchlist:
305
306 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
307
308         [Qt] Move OTHER_FILES from WebKit.pro to Tools.pro
309
310         Reviewed by Simon Hausmann.
311
312         * Tools.pro:
313
314 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
315
316         [Qt] Allow building only a subset of the WebKit sub-projects
317
318         Fixes build-jsc, broken in r104825.
319
320         We no longer need the intermediate buildQMakeQtProject(), as we're the
321         only port using qmake, and buildQMakeProject is now highly Qt specific.
322
323         <http://webkit.org/b/76179>
324
325         Reviewed by Simon Hausmann.
326
327         * Scripts/build-jsc:
328         * Scripts/build-webkit:
329         * Scripts/webkitdirs.pm:
330         (buildQMakeProjects):
331
332 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
333
334         run-perf-tests should generate a json file that summaries the result
335         https://bugs.webkit.org/show_bug.cgi?id=76504
336
337         Reviewed by Adam Barth.
338
339         Add an ability to generate a json file to run-perf-test in the preparation for perf bots.
340         New option --outout-json-path specifies the json file's path, and --source-json-path specifies
341         another json file to be merged into the generated json file.
342
343         Also fixed a bug that --build wasn't set by default.
344
345         * Scripts/webkitpy/layout_tests/port/test.py:
346         (TestPort.webkit_base):
347         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
348         (PerfTestsRunner.__init__):
349         (PerfTestsRunner):
350         (PerfTestsRunner._parse_args):
351         (PerfTestsRunner.run):
352         (PerfTestsRunner._generate_json_if_specified):
353         (PerfTestsRunner._process_chromium_style_test_result):
354         (PerfTestsRunner._process_parser_test_result):
355         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
356         (MainTest):
357         (create_runner):
358         (test_run_test_set):
359         (test_run_test_set_for_parser_tests):
360         (test_run_test_set_with_summary_json):
361         (test_collect_tests):
362         (test_parse_args):
363
364 2012-01-17  Sheriff Bot  <webkit.review.bot@gmail.com>
365
366         Unreviewed, rolling out r105244.
367         http://trac.webkit.org/changeset/105244
368         https://bugs.webkit.org/show_bug.cgi?id=76518
369
370         broke Chromium Mac (Requested by rolandsteiner on #webkit).
371
372         * DumpRenderTree/AccessibilityUIElement.h:
373         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
374         (AccessibilityUIElement::AccessibilityUIElement):
375         * DumpRenderTree/chromium/AccessibilityUIElement.h:
376         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
377         (AccessibilityUIElement::removeSelection):
378         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
379         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
380         (AccessibilityUIElement::removeSelection):
381
382 2012-01-17  Dominic Mazzoni  <dmazzoni@google.com>
383
384         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
385         https://bugs.webkit.org/show_bug.cgi?id=73460
386
387         Reviewed by Chris Fleizach.
388
389         * DumpRenderTree/AccessibilityUIElement.h:
390         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
391         (AccessibilityUIElement::AccessibilityUIElement):
392         (AccessibilityUIElement::scrollToMakeVisibleCallback):
393         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
394         (AccessibilityUIElement::scrollToGlobalPointCallback):
395         * DumpRenderTree/chromium/AccessibilityUIElement.h:
396         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
397         (AccessibilityUIElement::scrollToMakeVisible):
398         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
399         (AccessibilityUIElement::scrollToGlobalPoint):
400         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
401         (AccessibilityUIElement::scrollToMakeVisible):
402         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
403         (AccessibilityUIElement::scrollToGlobalPoint):
404         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
405         (AccessibilityUIElement::scrollToMakeVisible):
406         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
407         (AccessibilityUIElement::scrollToGlobalPoint):
408
409 2012-01-17  Adam Barth  <abarth@webkit.org>
410
411         Enable tests on the mac-ews
412         https://bugs.webkit.org/show_bug.cgi?id=76502
413
414         Reviewed by Simon Fraser.
415
416         Apple now has five machines running the mac-ews.  Lucas Forschler has
417         asked that we try enabling tests to see if we have enough bandwidth.
418
419         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
420         (MacEWS):
421
422 2012-01-17  Sanjoy Das  <sanjoy@playingwithpointers.com>
423
424         Add a check-webkit-style exception for GDBInterface.cpp
425         https://bugs.webkit.org/show_bug.cgi?id=76187
426
427         Add an exception for Source/JavaScriptCore/jit/GDBInterface.cpp so
428         that it does not fail the style check.
429
430         Reviewed by Martin Robinson.
431
432         * Scripts/webkitpy/style/checker.py: Tell the style checker to not run
433         readability/naming tests on
434         Source/JavaScriptCore/jit/GDBInterface.cpp.
435         * Scripts/webkitpy/style/checker_unittest.py:
436         (GlobalVariablesTest.test_path_rules_specifier): Add a test for
437         the above exception.
438
439 2012-01-17  Hajime Morrita  <morrita@chromium.org>
440
441         https://bugs.webkit.org/show_bug.cgi?id=76245
442         [Mac][DRT] should allow query string for the file URL.
443
444         Reviewed by Tony Chang.
445
446         Taught DRT about file:// as a url instead of a file path.
447         We are now able to use a path file:///foo/bar.html?baz as a url
448         with which DRT opens "/foo/bar.html" with "baz" as a query string.
449
450         * DumpRenderTree/mac/DumpRenderTree.mm:
451         (runTest):
452
453 2012-01-17  Ojan Vafai  <ojan@chromium.org>
454
455         Check style on test_expectations.txt files before commit
456         https://bugs.webkit.org/show_bug.cgi?id=76484
457
458         Reviewed by Adam Barth.
459
460         Unlike other style rules, if you get the syntax of the test_expectations.txt
461         file wrong, the layout tests won't run. Also, this check is simple and only
462         slows down committing if you actually modify one of the test_expectations.txt files.
463
464         * Scripts/webkitpy/tool/steps/commit.py:
465         (Commit._check_test_expectations):
466         (Commit.run):
467         * Scripts/webkitpy/tool/steps/commit_unittest.py: Added.
468         (CommitTest):
469         (CommitTest.test_check_test_expectations):
470
471 2012-01-17  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
472
473         [Qt] Debug build fails with debug qt5
474         https://bugs.webkit.org/show_bug.cgi?id=76463
475
476         Reviewed by Simon Hausmann.
477
478         Add QNetworkCookie include in order to satisfy sizeof in QTypeInfo in debug builds.
479
480         * QtTestBrowser/cookiejar.h:
481
482 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
483
484         webkitpy: fix json import on linux
485         https://bugs.webkit.org/show_bug.cgi?id=76481
486
487         Reviewed by Adam Barth.
488
489         For some reason, the version of simplejson autoinstalled on my linux
490         box seems to be broken. We should really only be using
491         simplejson if json isn't available anyway, so this change looks
492         for json first.
493
494         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
495         (JSONGeneratorTest.test_test_timings_trie):
496
497 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
498
499         Fix failures in test-webkitpy caused by r105177.
500
501         Unreviewed, build fix.
502
503         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
504         (ChromiumLinuxPort._determine_driver_path_statically):
505         (ChromiumLinuxPort._static_build_path):
506
507 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
508
509         webkitpy: make PortFactory.get() be fully data-driven
510         https://bugs.webkit.org/show_bug.cgi?id=76360
511
512         Reviewed by Eric Seidel.
513
514         Refactor PortFactory.get() to be fully data-driven.
515
516         * Scripts/webkitpy/layout_tests/port/factory.py:
517         (PortFactory):
518         (PortFactory._default_port):
519         (PortFactory.get):
520         (PortFactory.get.in):
521         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
522         (FactoryTest.assert_port):
523
524 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
525
526         webkitpy: add determine_full_port_name(), clean up port.__init__()
527         https://bugs.webkit.org/show_bug.cgi?id=76357
528
529         Reviewed by Adam Barth.
530
531         Each Port class is now required to implement a 'port_name' field
532         that will match the start of all ports constructed by this class and
533         a 'determine_full_port_name' field that will make the port
534         fully-qualified.
535
536         * Scripts/webkitpy/layout_tests/port/apple.py:
537         (ApplePort.__init__):
538         * Scripts/webkitpy/layout_tests/port/base.py:
539         (Port):
540         (Port.determine_port_name):
541         (Port.__init__):
542         * Scripts/webkitpy/layout_tests/port/chromium.py:
543         (ChromiumPort.for):
544         (ChromiumPort.__init__):
545         (ChromiumPort):
546         (ChromiumPort._chromium_base_dir):
547         (ChromiumPort.path_from_chromium_base):
548         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
549         (ChromiumGpuLinuxPort):
550         (ChromiumGpuLinuxPort.__init__):
551         (ChromiumGpuMacPort):
552         (ChromiumGpuMacPort.__init__):
553         (ChromiumGpuWinPort):
554         (ChromiumGpuWinPort.__init__):
555         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
556         (ChromiumLinuxPort):
557         (ChromiumLinuxPort.determine_port_name):
558         (ChromiumLinuxPort.__init__):
559         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
560         (ChromiumMacPort):
561         (ChromiumMacPort.determine_port_name):
562         (ChromiumMacPort.__init__):
563         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
564         (ChromiumWinPort):
565         (ChromiumWinPort.determine_port_name):
566         (ChromiumWinPort.__init__):
567         * Scripts/webkitpy/layout_tests/port/dryrun.py:
568         (DryRunPort):
569         (DryRunPort.determine_port_name):
570         (DryRunPort.__init__):
571         * Scripts/webkitpy/layout_tests/port/efl.py:
572         (EflPort):
573         * Scripts/webkitpy/layout_tests/port/factory.py:
574         (PortFactory):
575         (PortFactory._default_port):
576         (PortFactory.get):
577         (PortFactory.get.in):
578         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
579         (FactoryTest.assert_port):
580         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
581         (GoogleChromeLinux32Port):
582         (GoogleChromeLinux32Port.determine_port_name):
583         (GoogleChromeLinux64Port):
584         (GoogleChromeLinux64Port.determine_port_name):
585         (GoogleChromeMacPort):
586         (GoogleChromeMacPort.determine_port_name):
587         (GoogleChromeWinPort):
588         (GoogleChromeWinPort.determine_port_name):
589         * Scripts/webkitpy/layout_tests/port/gtk.py:
590         (GtkPort):
591         * Scripts/webkitpy/layout_tests/port/mac.py:
592         (MacPort):
593         (MacPort.determine_port_name):
594         (MacPort.__init__):
595         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
596         (test_versions):
597         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
598         (MockDRTPort):
599         (MockDRTPort.determine_port_name):
600         (MockDRTPort.__init__):
601         (MockDRT):
602         (MockDRT.determine_port_name):
603         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
604         (PortTestCase.make_port):
605         * Scripts/webkitpy/layout_tests/port/qt.py:
606         (QtPort):
607         (QtPort.determine_port_name):
608         (QtPort.__init__):
609         * Scripts/webkitpy/layout_tests/port/test.py:
610         (TestPort):
611         (TestPort.determine_port_name):
612         (TestPort.__init__):
613         * Scripts/webkitpy/layout_tests/port/webkit.py:
614         (WebKitPort.__init__):
615         * Scripts/webkitpy/layout_tests/port/win.py:
616         (WinPort):
617         (WinPort.determine_port_name):
618         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
619         (get_test_baselines.AllPlatformsPort.__init__):
620         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
621         (get_test_config.TestMacPort):
622         (get_test_config):
623
624 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
625
626         webkitpy: clean up port code in preparation for static port names
627         https://bugs.webkit.org/show_bug.cgi?id=76356
628
629         Reviewed by Adam Barth.
630
631         To fix bug 76215 and be able to determine appropriate port names
632         in webkitpy without actually constructing Port objects, we need
633         to shuffle some logic in the chromium ports to be able to figure
634         out whether we built DRT in 32 or 64-bit mode.
635
636         * Scripts/webkitpy/layout_tests/port/chromium.py:
637         (ChromiumPort):
638         (ChromiumPort._chromium_base_dir):
639         (ChromiumPort.__init__):
640         (ChromiumPort.path_from_chromium_base):
641         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
642         (ChromiumLinuxPort):
643         (ChromiumLinuxPort._determine_driver_path_statically):
644         (ChromiumLinuxPort._static_build_path):
645         (ChromiumLinuxPort._determine_architecture):
646         (ChromiumLinuxPort.__init__):
647         (ChromiumLinuxPort._build_path):
648
649 2012-01-17  Hao Zheng  <zhenghao@chromium.org>
650
651         Do not remove pixel failures for ref tests.
652         https://bugs.webkit.org/show_bug.cgi?id=76243
653
654         Reviewed by Tony Chang.
655
656         'NRWT --no-pixel-tests' complains when reftests are expected to
657         be image mismatch.
658
659         * Scripts/webkitpy/layout_tests/controllers/manager.py:
660         (Manager._update_summary_with_result):
661         * Scripts/webkitpy/layout_tests/models/test_failures.py:
662         (is_reftest_failure):
663         (determine_result_type):
664
665 2012-01-17  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
666
667         REGRESSION(r81225): ORWT should ignore reftests
668         https://bugs.webkit.org/show_bug.cgi?id=67936
669
670         Reviewed by Csaba Osztrogonác.
671
672         * Scripts/old-run-webkit-tests:
673         (isUsedInReftest): $filename should be the first parameter
674         (findTestsToRun): run test if it isn't reftest
675
676 2012-01-17  Gustavo Noronha Silva  <gns@gnome.org>
677
678         Unreviewed. Fix python unit test I broke with r105142
679
680         * Scripts/webkitpy/common/config/ports_unittest.py:
681         (WebKitPortTest.test_gtk_port):
682
683 2012-01-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
684
685         [Qt] Don't set the 'primary' flag when mocking touch-points in MiniBrowser
686
687         Qt 5 no longer has that flag.
688
689         Reviewed by Simon Hausmann.
690
691         * MiniBrowser/qt/MiniBrowserApplication.cpp:
692         (MiniBrowserApplication::notify):
693
694 2012-01-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
695
696         GTK+ EWS needs to run update-webkitgtk-libs after applying a patch
697         https://bugs.webkit.org/show_bug.cgi?id=75857
698
699         Reviewed by Adam Barth.
700
701         * Scripts/webkitdirs.pm:
702         (buildAutotoolsProject): move cleaning the build to happen early,
703         and handle --update-gtk right after that
704         * Scripts/webkitpy/common/config/ports.py:
705         (GtkPort.build_webkit_command): pass --update-gtk as an option to
706         build-webkit, so that it is used in the EWS
707
708 2012-01-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
709
710         [Qt] Don't add _debug postfix to targets when building debug only
711
712         Reviewed by Simon Hausmann.
713
714         * qmake/mkspecs/features/default_post.prf:
715         * qmake/mkspecs/features/functions.prf:
716
717 2012-01-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
718
719         [Qt] Add more files to project-files for easier navigation in Qt Creator
720
721         Reviewed by Simon Hausmann.
722
723         * Tools.pro:
724         * qmake/config.tests/README: Added.
725
726 2012-01-17  Philippe Normand  <pnormand@igalia.com>
727
728         [GTK] fast/dom/constructed-objects-prototypes.html fails
729         https://bugs.webkit.org/show_bug.cgi?id=75432
730
731         Reviewed by Martin Robinson.
732
733         * Scripts/build-webkit: Enable video-track in GTK.
734
735 2012-01-16  Takashi Toyoshima  <toyoshim@chromium.org>
736
737         Add toyoshim as a committer.
738         https://bugs.webkit.org/show_bug.cgi?id=76390
739
740         Reviewed by Hajime Morita.
741
742         * Scripts/webkitpy/common/config/committers.py:
743
744 2012-01-16  Brent Fulgham  <bfulgham@webkit.org>
745
746         [WinCairo] Build fix after r104155. Several debug targets were not
747         properly including the '*Common' property sheets.
748
749         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops:
750         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops:
751         * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops:
752         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops:
753         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops:
754
755 2012-01-16  Csaba Osztrogonác  <ossy@webkit.org>
756
757         REGRESSION(r105072): It broke committers_unittest.py
758         https://bugs.webkit.org/show_bug.cgi?id=76396
759
760         Reviewed by Adam Barth.
761
762         * Scripts/webkitpy/common/config/committers_unittest.py:
763         (CommittersTest._assert_fuzz_match): It should handle more names.
764         (CommittersTest.test_contributors_by_fuzzy_match_with_legacy_names): Fix the testcase.
765
766 2012-01-16  Mario Sanchez Prada  <msanchez@igalia.com>
767
768         [GTK] Include gtk+3 in the jhbuild modules
769         https://bugs.webkit.org/show_bug.cgi?id=76284
770
771         Reviewed by Philippe Normand.
772
773         * gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
774
775 2012-01-16  Dan Winship  <danw@gnome.org>
776
777         Add myself as a committer
778
779         Unreviewed
780
781         * Scripts/webkitpy/common/config/committers.py:
782
783 2012-01-16  Raphael Kubo da Costa  <kubo@profusion.mobi>
784
785         Unreviewed; fix the build when --as-needed and --no-copy-dt-needed-entries are passed to the linker.
786
787         Some recent versions of a few Linux distributions have started passing
788         --as-needed and --no-copy-dt-needed-entries by default to the linker,
789         which broke the build when SHARED_CORE was turned on, as libwtf_efl.so
790         needed a few symbols from libjavascriptcore_efl.so.
791
792         * DumpRenderTree/efl/CMakeLists.txt: Explicitly pass WTF_LIBRARY_NAME
793         before JavaScriptCore_LIBRARY_NAME in DumpRenderTree_LIBRARIES so the
794         libraries are searched in the right order by the linker.
795
796 2012-01-16  Philippe Normand  <pnormand@igalia.com>
797
798         [GTK] set audio resources path in NRTW
799         https://bugs.webkit.org/show_bug.cgi?id=76380
800
801         Reviewed by Martin Robinson.
802
803         * Scripts/webkitpy/layout_tests/port/gtk.py:
804         (GtkPort.setup_environ_for_server): Set $AUDIO_RESOURCES_PATH so
805         the uninstalled audio resources are used during webaudio tests.
806
807 2012-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
808
809         [GTK] ldflags and cflags should take precedence over the existing flags in gtkdoc.py
810         https://bugs.webkit.org/show_bug.cgi?id=76369
811
812         Reviewed by Xan Lopez.
813
814         If there's an installed version of webkit and there are new
815         symbols in the build tree, gtkdoc-scanobj fails due to undefined
816         references, because the env ldflags are given before the local
817         ones.
818
819         * gtk/gtkdoc.py:
820         (GTKDoc._run_gtkdoc_scangobj):
821
822 2012-01-15  Pablo Flouret  <pablof@motorola.com>
823
824         Fix compilation errors on build-webkit --debug --no-video on mac.
825         https://bugs.webkit.org/show_bug.cgi?id=75867
826
827         Reviewed by Philippe Normand.
828
829         Add --[no-]video-track to build-webkit, since video track feature
830         depends on video.
831
832         * Scripts/build-webkit:
833
834 2012-01-14  James Robinson  <jamesr@chromium.org>
835
836         [chromium] Failing webkit_unit_tests does not make the cr-linux EWS bubble red
837         https://bugs.webkit.org/show_bug.cgi?id=76313
838
839         Reviewed by Adam Barth.
840
841         The exit code of this script should be the exit code of webkit_unit_tests. Tested manually.
842
843         * Scripts/run-chromium-webkit-unit-tests:
844
845 2012-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
846
847         Unreviewed, rolling out r105017.
848         http://trac.webkit.org/changeset/105017
849         https://bugs.webkit.org/show_bug.cgi?id=76333
850
851         broke the build (Requested by philn-tp on #webkit).
852
853         * gtk/jhbuild.modules:
854
855 2012-01-14  Mario Sanchez Prada  <msanchez@igalia.com>
856
857         [GTK] Include gtk+3 in the jhbuild modules
858         https://bugs.webkit.org/show_bug.cgi?id=76284
859
860         Reviewed by Philippe Normand.
861
862         * gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
863
864 2012-01-13  Adam Barth  <abarth@webkit.org>
865
866         Remove --dry-run support from webkit-patch
867         https://bugs.webkit.org/show_bug.cgi?id=76300
868
869         Reviewed by Dirk Pranke.
870
871         This is the rest of the patch from Bug 76300.  I landed it separtely
872         because main.py had some stray conflict markers that I needed to clean
873         up first.
874
875         * Scripts/webkitpy/test/main.py:
876         (Tester.parse_args):
877         (Tester._run_tests):
878
879 2012-01-13  Adam Barth  <abarth@webkit.org>
880
881         test-webkitpy does not run
882         https://bugs.webkit.org/show_bug.cgi?id=76318
883
884         Unreviewed.
885
886         Looks like some conflict markers got left in the file.
887
888         * Scripts/webkitpy/test/main.py:
889         (Tester.run):
890
891 2012-01-13  Adam Barth  <abarth@webkit.org>
892
893         Remove --dry-run support from webkit-patch
894         https://bugs.webkit.org/show_bug.cgi?id=76300
895
896         Reviewed by Dirk Pranke.
897
898         We don't use this functionality for anything, and it doesn't really
899         work.  Someone in #webkit tried using it and and got sad/confused.  We
900         should just remove it.
901
902         * Scripts/webkitpy/common/checkout/scm/git.py:
903         (Git.push_local_commits_to_server):
904         * Scripts/webkitpy/common/checkout/scm/scm.py:
905         (SCM.__init__):
906         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
907         (_shared_test_commit_with_message):
908         (GitSVNTest.test_commit_text_parsing):
909         * Scripts/webkitpy/common/checkout/scm/svn.py:
910         (SVN.commit_with_message):
911         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
912         (Bugzilla.__init__):
913         (Bugzilla.quips):
914         (Bugzilla.authenticate):
915         (Bugzilla.add_attachment_to_bug):
916         (Bugzilla.add_patch_to_bug):
917         (Bugzilla.create_bug):
918         (Bugzilla.clear_attachment_flags):
919         (Bugzilla.set_flag_on_attachment):
920         (Bugzilla.obsolete_attachment):
921         (Bugzilla.add_cc_to_bug):
922         (Bugzilla.post_comment_to_bug):
923         (Bugzilla.close_bug_as_fixed):
924         (Bugzilla.reassign_bug):
925         (reopen_bug):
926         * Scripts/webkitpy/test/main.py:
927         (Tester.parse_args):
928         (Tester.run_tests):
929
930 2012-01-13  David Levin  <levin@chromium.org>
931
932         check-webkit-style: should encourage the use of Own* classes for Windows DC.
933         https://bugs.webkit.org/show_bug.cgi?id=76227
934
935         Reviewed by Dirk Pranke.
936
937         * Scripts/webkitpy/style/checkers/cpp.py:
938         (check_for_leaky_patterns): The new check.
939         (process_line): Added a call to the new check.
940         (CppChecker): Added the new error type.
941         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
942         (CppStyleTestBase):
943         (CppStyleTestBase.perform_leaky_pattern_check):
944         The check for only leaky pattern errors.
945         (LeakyPatternTest): Test cases.
946
947 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
948
949         test-webkitpy: clean up handling of test directories, QueueStatusServer
950         https://bugs.webkit.org/show_bug.cgi?id=76238
951
952         Reviewed by Adam Barth.
953
954         This patch cleans up a bunch of hacks related to how we find all
955         of the python unit tests and set up the sys.path variable in
956         test-webkitpy.
957
958         This patch changes how test-webkitpy works slightly in that we
959         will now look for test files under Tools/Scripts and Source/WebKit2/Scripts
960         rather than just Tools/Scripts/webkitpy and Source/WebKit2/Scripts/webkit.
961         This greatly simplifies the mapping of paths to module names and
962         appears to have no significant performance impact or other drawbacks.
963
964         There are other ways that we could remove all of the hacks and
965         still have a more flexible mapping of paths to module names, but
966         the ones I've thought of so far add a decent amount of complexity to
967         the implementation and don't seem to buy us much.
968         
969         * QueueStatusServer/__init__.py:
970         * Scripts/test-webkitpy:
971         * Scripts/webkitpy/test/main.py:
972         (Tester._modules_from_paths):
973         (Tester._is_module):
974
975 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
976
977         test-webkitpy: should support classes and individual test names as well as modules
978         https://bugs.webkit.org/show_bug.cgi?id=76233
979
980         Reviewed by Adam Barth.
981
982         The default unittest.main() supports a list of individual
983         TestCase classes or individual tests as well as modules. This
984         change adds support for the same to test-webkitpy, so now you
985         can say
986
987           % test-wekbitpy webkitpy.test.cat_unittest.CatTest
988
989         and
990
991           % test-wekbitpy webkitpy.test.cat_unittest.CatTest.test_basic
992
993         in addition to
994
995           % test-wekbitpy webkitpy.test.cat_unittest
996
997         * Scripts/test-webkitpy:
998         * Scripts/webkitpy/test/cat_unittest.py:
999         * Scripts/webkitpy/test/main.py:
1000         (Tester.parse_args):
1001         (Tester.run):
1002         (Tester):
1003         (Tester._find_modules):
1004         (Tester._exclude):
1005         (Tester._run_tests):
1006         (Tester._is_module):
1007         (Tester._log_exception):
1008
1009 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
1010
1011         test-webkitpy: add basic code coverage support
1012         https://bugs.webkit.org/show_bug.cgi?id=76201
1013
1014         Reviewed by Adam Barth.
1015
1016         This test adds basic code coverage support to test-webkitpy; if
1017         you pass the -c flag, we will generate a new coverage file. We
1018         can start simply with this and add more features as necessary.
1019
1020         This patch requires coverage to be already installed on the
1021         machine. I am not auto-installing this for now.
1022
1023         * Scripts/webkitpy/test/main.py:
1024         (Tester.parse_args):
1025         (Tester.run_tests):
1026
1027 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
1028
1029         StatusBubbleTest.test_build_bubble is failing
1030         https://bugs.webkit.org/show_bug.cgi?id=76222
1031
1032         Reviewed by Adam Barth.
1033
1034         * QueueStatusServer/handlers/statusbubble_unittest.py:
1035         (StatusBubbleTest.test_build_bubble):
1036
1037 2012-01-13  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1038
1039         nrwt should use multiple http shards
1040         https://bugs.webkit.org/show_bug.cgi?id=75958
1041
1042         Add --max-locked-shards option to the nrwt for manual set
1043         the maximum number of the locked shards
1044
1045         Reviewed by Dirk Pranke.
1046
1047         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1048         (Manager._max_locked_shards):
1049         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1050         (ShardingTests.get_shards):
1051         (ShardingTests.test_multiple_locked_shards):
1052         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1053         (parse_args):
1054
1055 2012-01-13  Raphael Kubo da Costa  <kubo@profusion.mobi>
1056
1057         prepare-ChangeLog: Look for a text editor in a few more variables.
1058         https://bugs.webkit.org/show_bug.cgi?id=76289
1059
1060         Reviewed by Ryosuke Niwa.
1061
1062         A text editor was looked for only in the CHANGE_LOG_EDITOR and
1063         CHANGE_LOG_EDIT_APPLICATION environment variables before falling back
1064         to the OS X-specific open(1) command.
1065
1066         As there does not seem to be a common way of looking for a text editor
1067         among the scripts in Tools/Scripts right now, just look at $VISUAL and
1068         $EDITOR (set much more often than the other variables in Unix systems)
1069         before falling back to open(1).
1070
1071         * Scripts/prepare-ChangeLog:
1072         (openChangeLogs):
1073
1074 2012-01-13  Gabor Rapcsanyi  <rgabor@webkit.org>
1075
1076         [GTK] gtkdoc.py ignoring LDFLAGS and CFLAGS environment variables
1077         https://bugs.webkit.org/show_bug.cgi?id=76269
1078
1079         Reviewed by Martin Robinson.
1080
1081         * gtk/gtkdoc.py:
1082         (GTKDoc._run_gtkdoc_scangobj):
1083
1084 2012-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1085
1086         [Qt][WK2]REGRESSION(r104881):It broke hundreds of tests
1087         https://bugs.webkit.org/show_bug.cgi?id=76247
1088
1089         Reviewed by Kenneth Rohde Christiansen.
1090
1091         * WebKitTestRunner/TestController.cpp:
1092         (WTR::TestController::resetStateToConsistentValues): Disable mock scrollbars on Qt by default. (workaround)
1093
1094 2012-01-13  Hajime Morrita  <morrita@chromium.org>
1095
1096         [Mac][DRT] Should support --no-timeout
1097         https://bugs.webkit.org/show_bug.cgi?id=76242
1098
1099         Reviewed by Darin Adler.
1100
1101         * DumpRenderTree/mac/DumpRenderTree.mm:
1102         (initializeGlobalsFromCommandLineOptions): Added "--no-timeout" to the options list.
1103         (setWaitToDumpWatchdog): Added to encapsulate the waitToDumpWatchdog global variable.
1104         (shouldSetWaitToDumpWatchdog): Added to check the useTimeoutWatchdog flag set by the option.
1105         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1106         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1107         (LayoutTestController::setWaitToDump): Now calls shouldSetWaitToDumpWatchdog() to check the flag.
1108
1109 2012-01-12  Simon Fraser  <simon.fraser@apple.com>
1110
1111         Mitigate scrollbar differences when running pixel tests
1112         https://bugs.webkit.org/show_bug.cgi?id=67217
1113
1114         Reviewed by Dan Bernstein.
1115         
1116         Enable mock scrollbars by default for tests.
1117
1118         * DumpRenderTree/mac/DumpRenderTree.mm:
1119         (resetDefaultsToConsistentValues):
1120         * WebKitTestRunner/TestController.cpp:
1121         (WTR::TestController::resetStateToConsistentValues):
1122
1123 2012-01-12  Ryosuke Niwa  <rniwa@webkit.org>
1124
1125         Need a script to run tests in PerformanceTests
1126         https://bugs.webkit.org/show_bug.cgi?id=76132
1127
1128         Reviewed by Adam Barth.
1129
1130         Add run-perf-tests to run performance tests using parser/resources/runner.js.
1131         Unfortunately, there isn't an easy way of telling which test uses which format
1132         so hard-code directory that uses Chromium perf-bot style (only inspector perf. tests for now).
1133
1134         All test outputs are re-formatted to match Chromium perf-bot style.
1135
1136         * Scripts/run-inspector-perf-tests.py:
1137         * Scripts/run-perf-tests: Added.
1138         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1139         (PerfTestsRunner):
1140         (PerfTestsRunner.__init__):
1141         (PerfTestsRunner._collect_tests):
1142         (PerfTestsRunner.run):
1143         (PerfTestsRunner._print_status):
1144         (PerfTestsRunner._run_tests_set):
1145         (PerfTestsRunner._process_chromium_style_test_result):
1146         (PerfTestsRunner._should_ignore_line_in_parser_test_result):
1147         (PerfTestsRunner._process_parser_test_result):
1148         (PerfTestsRunner._run_single_test):
1149         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1150         (MainTest.TestDriver.run_test):
1151         (create_runner):
1152         (run_test):
1153         (test_run_test_set):
1154         (test_run_test_set_for_parser_tests):
1155         (test_collect_tests):
1156
1157 2012-01-12  Dirk Pranke  <dpranke@chromium.org>
1158
1159         webkitpy: clean up port unit tests in preparation for making port_name mandatory
1160         https://bugs.webkit.org/show_bug.cgi?id=76123
1161
1162         Reviewed by Adam Barth.
1163
1164         This change updates the unit tests to be more consistent in how
1165         ports are created, in preparation for making port_name a
1166         mandatory parameter to the constructor and removing any version
1167         interpretation from it.
1168
1169         There should be no functional changes in this patch, but some
1170         tests that are no longer relevant have been removed or reworked.
1171
1172         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1173         (PortTest.test_get_option__default):
1174         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1175         (ChromiumLinuxPortTest):
1176         (ChromiumLinuxPortTest.assert_architecture):
1177         (ChromiumLinuxPortTest.test_determine_architecture_fails):
1178         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1179         (ChromiumMacPortTest):
1180         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1181         (ChromiumPortTest):
1182         (ChromiumPortTest.test_all_test_configurations):
1183         (ChromiumPortTest.TestMacPort.__init__):
1184         (ChromiumPortTest.TestLinuxPort.__init__):
1185         (ChromiumPortTest.TestWinPort.__init__):
1186         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1187         (ChromiumWinTest):
1188         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
1189         (EflPortTest):
1190         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1191         (GtkPortTest):
1192         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1193         (MacTest):
1194         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1195         (MockDRTPortTest):
1196         (MockDRTPortTest.make_port):
1197         * Scripts/webkitpy/layout_tests/port/qt.py:
1198         (QtPort._port_flag_for_scripts):
1199         (QtPort.__init__):
1200         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1201         (QtPortTest):
1202         (QtPortTest._assert_search_path):
1203         (QtPortTest.test_baseline_search_path):
1204         (QtPortTest.test_operating_system):
1205         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1206         (WebKitPortTest):
1207         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1208         (WinPortTest):
1209         (WinPortTest._assert_search_path):
1210         (WinPortTest.test_baseline_search_path):
1211         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
1212         (get_test_config.TestMacPort.__init__):
1213
1214 2012-01-12  Dirk Pranke  <dpranke@chromium.org>
1215
1216         test-webkitpy: clean up logging and provide a real --help message
1217         https://bugs.webkit.org/show_bug.cgi?id=76142
1218
1219         Reviewed by Adam Barth.
1220
1221         This test is mostly more refactoring - it calls objects in
1222         unittest directly instead of routing through unittest.main() --
1223         in order to gain more control over the logging and to provide a
1224         correct --help message. This will also give us a better
1225         foundation for adding more feautures down the road.
1226
1227         This patch adds different levels of logging controlled by the
1228         '-s', '-q', and '-v' options (see --help for details), and
1229         removes the --verbose-logging option.
1230
1231         * Scripts/test-webkitpy:
1232         * Scripts/webkitpy/test/main.py:
1233         (Tester):
1234         (Tester.clean_packages):
1235         (Tester.__init__):
1236         (Tester.parse_args):
1237         (Tester.configure):
1238         (Tester._configure_logging):
1239         (Tester.find_modules):
1240         (Tester._exclude):
1241         (Tester._modules_from_paths):
1242         (Tester.run_tests):
1243
1244 2012-01-12  Simon Hausmann  <simon.hausmann@nokia.com>
1245
1246         Make the new WTF module build on Qt
1247         https://bugs.webkit.org/show_bug.cgi?id=76163
1248
1249         Reviewed by Tor Arne Vestbø.
1250
1251         * qmake/mkspecs/modules/wtf.prf: Pull in WTF from the new location.
1252
1253 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
1254
1255         Unreviewed, mac DumpRenderTree fix.
1256
1257         * DumpRenderTree/mac/UIDelegate.mm:
1258         (-[UIDelegate webView:addMessageToConsole:withSource:]):
1259
1260 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
1261
1262         WebKitTestRunner should not print console message line number when it is equal to zero.
1263         https://bugs.webkit.org/show_bug.cgi?id=76167
1264
1265         Reviewed by Csaba Osztrogonác.
1266
1267         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1268         (WTR::InjectedBundlePage::willAddMessageToConsole):
1269
1270 2012-01-11  Vsevolod Vlasov  <vsevik@chromium.org>
1271
1272         Make default console messages line numbers consistent.
1273         https://bugs.webkit.org/show_bug.cgi?id=74075
1274
1275         Reviewed by Pavel Feldman.
1276
1277         Unset line numbers are not printed to console now.
1278         Added Source/WebCore/inspector to efl DumpRenderTree include path.
1279
1280         * DumpRenderTree/chromium/WebViewHost.cpp:
1281         (WebViewHost::didAddMessageToConsole):
1282         * DumpRenderTree/efl/CMakeLists.txt:
1283         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1284         (onConsoleMessage):
1285         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1286         (webViewConsoleMessage):
1287         * DumpRenderTree/mac/UIDelegate.mm:
1288         (-[UIDelegate webView:addMessageToConsole:withSource:]):
1289         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1290         (WebCore::WebPage::javaScriptConsoleMessage):
1291         * DumpRenderTree/win/UIDelegate.cpp:
1292         (UIDelegate::webViewAddMessageToConsole):
1293         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1294         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
1295
1296 2012-01-10  Dirk Pranke  <dpranke@chromium.org>
1297
1298         test-webkitpy: push more logic into webkitpy.test.main, clean up code
1299         https://bugs.webkit.org/show_bug.cgi?id=76021
1300
1301         Reviewed by Eric Seidel.
1302
1303         I plan to add more functionality to test-webkitpy, but it is
1304         difficult to hack on now; this patch is the first of two that
1305         brings test-webkitpy more inline with current coding style by
1306         pushing more logic into the webkitpy.test.main.Tester class (so
1307         that it will be testable itself).
1308         
1309         There should be no functional changes in this patch.
1310
1311         * Scripts/test-webkitpy:
1312         (_path_from_webkit_root):
1313         * Scripts/webkitpy/test/main.py:
1314         (Tester):
1315         (Tester.init):
1316         (Tester.configure_logging):
1317         (Tester.configure_logging.filter):
1318         (Tester.clean_packages):
1319         (Tester.run_tests):
1320
1321 2012-01-11  Wei Jia  <wjia@chromium.org>
1322
1323         implement layout tests for <video> with media stream
1324         https://bugs.webkit.org/show_bug.cgi?id=74882
1325
1326         Reviewed by Kent Tamura.
1327
1328         * DumpRenderTree/DumpRenderTree.gypi:
1329         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp: Added.
1330         (WebKit::WebUserMediaClientMock::create):
1331         (WebKit::WebUserMediaClientMock::IsMockStream):
1332         (WebKit::WebUserMediaClientMock::requestUserMedia):
1333         (WebKit::WebUserMediaClientMock::cancelUserMediaRequest):
1334         * DumpRenderTree/chromium/WebUserMediaClientMock.h: Added.
1335         (WebKit::WebUserMediaClientMock::~WebUserMediaClientMock):
1336         (WebKit::WebUserMediaClientMock::WebUserMediaClientMock):
1337         * DumpRenderTree/chromium/WebViewHost.cpp:
1338         (WebViewHost::userMediaClient):
1339         (WebViewHost::userMediaClientMock):
1340         (WebViewHost::createMediaPlayer):
1341         (WebViewHost::mediaStreamUtil):
1342         (WebViewHost::testMediaStreamClient):
1343         * DumpRenderTree/chromium/WebViewHost.h:
1344
1345 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
1346
1347         Unreviewed, build fix.
1348
1349         Fix chromium-win's version remapping to work correctly on Win 7 SP1.
1350
1351         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1352         (ChromiumWinPort.__init__):
1353
1354 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1355
1356         Sheriffbot build fix. Don't emit empty lines on IRC.
1357
1358         * Scripts/webkitpy/tool/bot/irc_command.py:
1359         (LastGreenRevision.execute):
1360
1361 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1362
1363         last-green-revision should report the revision that succeeded on all bots
1364         https://bugs.webkit.org/show_bug.cgi?id=76109
1365
1366         Reviewed by Adam Barth.
1367
1368         Add an algorithm to find the last known good revision among the specified bots. For a revision to be
1369         considered green by this algorithm, all matching builders must have a successful run at the revision
1370         or two consecutive successful runs before and after the revision.
1371
1372         Also fixed a bug in irc_command that the result wasn't posted on IRC properly and a bug in queries.py
1373         that resulted in an exception when the user didn't pass BUILDER_NAME argument.
1374
1375         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1376         (BuildBot._revisions_for_builder):
1377         (BuildBot):
1378         (BuildBot._find_green_revision):
1379         (BuildBot.last_green_revision):
1380         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
1381         (MockBuildBot.last_green_revision):
1382         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1383         (test_revisions_for_builder):
1384         (test_find_green_revision):
1385         (test_last_green_revision):
1386         * Scripts/webkitpy/tool/bot/irc_command.py:
1387         (LastGreenRevision.execute):
1388         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1389         (SheriffIRCBotTest.test_lgr):
1390         * Scripts/webkitpy/tool/commands/queries.py:
1391         (LastGreenRevision):
1392
1393 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
1394
1395         Unreviewed, fix build bustage on win32 introduced by r104725.
1396
1397         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1398         (MockDRTPortTest.make_port):
1399         (MockChromiumDRTTest.test_pixeltest__fails):
1400
1401 2012-01-11  Jochen Eisinger  <jochen@chromium.org>
1402
1403         [Chromium] mimic the (old) behavior of the mac port for (re)setting the color profile
1404         https://bugs.webkit.org/show_bug.cgi?id=75618
1405
1406         Eventually, we should get away from setting the display's color profile, as the mac port is doing now.
1407
1408         Reviewed by Tony Chang.
1409
1410         * DumpRenderTree/chromium/LayoutTestHelper.mm:
1411         (installLayoutTestColorProfile):
1412         (restoreUserColorProfile):
1413         (main):
1414
1415 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
1416
1417         test-webkitpy: fix -v and eliminate some spurious warnings
1418         https://bugs.webkit.org/show_bug.cgi?id=76099
1419
1420         Reviewed by Adam Barth.
1421
1422         when we added support for --xml output, we broke the -v flag.
1423
1424         Also, fix the code to swallow a harmless warning from
1425         VCSUtils.pm and fix a deprecated warning in jsonchecker.py.
1426
1427         test-webkitpy is now silent again except for the one known
1428         logging issue.
1429
1430         * Scripts/webkitpy/common/checkout/checkout.py:
1431         (Checkout.commit_message_for_this_commit):
1432         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1433         (test_commit_message_for_this_commit):
1434         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1435         (JSONChecker.check):
1436         (JSONChecker.line_number_from_json_exception):
1437         * Scripts/webkitpy/test/main.py:
1438         (Tester.run_tests):
1439
1440 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
1441
1442         webkitpy: webkitpy.layout_tests.port tests should only use MockSystemHost, not MockHost
1443         https://bugs.webkit.org/show_bug.cgi?id=76084
1444
1445         Reviewed by Adam Barth.
1446
1447         This will help make it easier to catch layering violations. This
1448         change just refactors test code; there are no changes to
1449         production code.
1450
1451         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1452         (PortTest.make_port):
1453         (PortTest.test_find_no_paths_specified):
1454         (PortTest.test_find_one_test):
1455         (PortTest.test_find_glob):
1456         (PortTest.test_find_with_skipped_directories):
1457         (PortTest.test_find_with_skipped_directories_2):
1458         (PortTest.test_parse_reftest_list):
1459         (PortTest.test_httpd_returns_error_code):
1460         (PortTest.test_virtual_methods):
1461         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1462         (ChromiumGpuTest.assert_port_works):
1463         (ChromiumGpuTest._assert_baseline_path):
1464         (ChromiumGpuTest.test_graphics_type):
1465         (ChromiumGpuTest.test_default_tests_paths.test_paths):
1466         (ChromiumGpuTest.test_test_files):
1467         (ChromiumGpuTest.test_test_files.test_paths):
1468         (ChromiumGpuTest):
1469         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1470         (ChromiumLinuxPortTest.assert_architecture):
1471         (ChromiumLinuxPortTest.test_check_illegal_port_names):
1472         (ChromiumLinuxPortTest.test_determine_architecture_fails):
1473         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
1474         (DriverTest.make_port):
1475         (DriverTest):
1476         (DriverTest.assertVirtual):
1477         (DriverTest._assert_wrapper):
1478         (DriverTest.test_virtual_driver_methods):
1479         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1480         (MockDRTPortTest.make_port):
1481         (MockDRTPortTest.test_port_name_in_constructor):
1482         (MockDRTTest.assertTest):
1483         (MockDRTTest.test_main):
1484         (MockChromiumDRTTest.test_pixeltest__fails):
1485         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1486         (QtPortTest._assert_search_path):
1487         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1488         (TestWebKitPort.__init__):
1489         (WebKitPortUnitTests.test_default_options):
1490         (test_runtime_feature_list):
1491         (test_test_expectations):
1492
1493 2012-01-11  Ojan Vafai  <ojan@chromium.org>
1494
1495         Style skipped tests in the flakiness dashboard
1496         https://bugs.webkit.org/show_bug.cgi?id=76091
1497
1498         Reviewed by Tony Chang.
1499
1500         * TestResultServer/static-dashboards/dashboard_base.js:
1501         Removed "FLAKY" from this list since we don't ever mark individual runs
1502         as flaky. Also deleted an outdated line.
1503         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1504
1505 2012-01-11  Ojan Vafai  <ojan@chromium.org>
1506
1507         Remove gtest normalization code from the test results server
1508         https://bugs.webkit.org/show_bug.cgi?id=76089
1509
1510         Reviewed by Tony Chang.
1511
1512         The normalization now happens on the gtest side.
1513
1514         * TestResultServer/model/jsonresults.py:
1515         (JsonResults.merge):
1516         * TestResultServer/model/jsonresults_unittest.py:
1517         (JsonResultsTest.test_gtest):
1518
1519 2012-01-11  Ojan Vafai  <ojan@chromium.org>
1520
1521         Be more aggressive about deleting unnecessary results from the test-results-server json files
1522         https://bugs.webkit.org/show_bug.cgi?id=76086
1523
1524         Reviewed by Tony Chang.
1525
1526         Remove any tests that only contain skip/pass/nodata values whose runtime
1527         is less than 5 seconds.
1528
1529         * TestResultServer/model/jsonresults.py:
1530         (JsonResults._normalize_results_json):
1531         * TestResultServer/model/jsonresults_unittest.py:
1532         (JsonResultsTest.test_merge_remove_test):
1533         (JsonResultsTest.test_merge_keep_test_with_all_pass_but_slow_time):
1534
1535 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1536
1537         last-green-revision should give us per-bot information
1538         https://bugs.webkit.org/show_bug.cgi?id=76011
1539
1540         Reviewed by Adam Barth.
1541
1542         Rewrote last-green-revision command. Instead of finding a revision for which all bots succeeded,
1543         we report the latest green run on each bot from the last 100 runs.
1544
1545         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1546         (BuildBot._fetch_builder_page):
1547         (BuildBot):
1548         (BuildBot._green_revision_for_builder):
1549         (BuildBot.last_green_revision):
1550         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1551         (test_green_revision_for_builder):
1552         (test_last_green_revision):
1553         * Scripts/webkitpy/tool/bot/irc_command.py:
1554         (LastGreenRevision.execute):
1555         * Scripts/webkitpy/tool/commands/queries.py:
1556         (LastGreenRevision.execute):
1557
1558 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
1559
1560         webkitpy: clean up version detection in webkitpy.layout_tests.port
1561         https://bugs.webkit.org/show_bug.cgi?id=76016
1562
1563         Reviewed by Adam Barth.
1564
1565         This change updates the code in webkitpy.layout_tests.port to
1566         use the new os_name and os_version fields on host.platform. This
1567         gets layout_tests.port out of the version parsing business. Most
1568         of the diffs are just cleaning up test code to accomodate the
1569         changes.
1570
1571         * Scripts/webkitpy/common/system/executive_mock.py:
1572         (MockExecutive):
1573         (MockExecutive.ignore_error):
1574         (MockExecutive2):
1575         (MockExecutive2.ignore_error):
1576         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1577         (MockPlatformInfo.is_mac):
1578         (MockPlatformInfo.is_linux):
1579         (MockPlatformInfo.is_win):
1580         * Scripts/webkitpy/common/system/systemhost_mock.py:
1581         (MockSystemHost.__init__):
1582         * Scripts/webkitpy/layout_tests/port/apple.py:
1583         (ApplePort.__init__):
1584         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1585         (ChromiumMacPort.__init__):
1586         (ChromiumMacPort.check_wdiff):
1587         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1588         (ChromiumMacPortTest):
1589         (ChromiumMacPortTest.assert_name):
1590         (ChromiumMacPortTest.test_versions):
1591         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1592         (ChromiumPortTest.test_all_test_configurations):
1593         (ChromiumPortTest.TestMacPort.__init__):
1594         (ChromiumPortTest.TestLinuxPort.__init__):
1595         (ChromiumPortTest.TestWinPort.__init__):
1596         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1597         (ChromiumWinPort.__init__):
1598         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1599         (ChromiumWinTest):
1600         (ChromiumWinTest.assert_name):
1601         (ChromiumWinTest.test_versions):
1602         (ChromiumWinTest.test_baseline_path):
1603         (ChromiumWinTest.test_build_path):
1604         * Scripts/webkitpy/layout_tests/port/factory.py:
1605         (PortFactory._port_name_from_arguments_and_options):
1606         (PortFactory.get):
1607         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1608         (FactoryTest):
1609         (FactoryTest.setUp):
1610         (FactoryTest.assert_port):
1611         (FactoryTest.test_mac):
1612         (FactoryTest.test_win):
1613         (FactoryTest.test_google_chrome):
1614         (FactoryTest.test_gtk):
1615         (FactoryTest.test_qt):
1616         (FactoryTest.test_chromium_gpu):
1617         (FactoryTest.test_chromium_gpu_linux):
1618         (FactoryTest.test_chromium_gpu_mac):
1619         (FactoryTest.test_chromium_gpu_win):
1620         (FactoryTest.test_chromium_mac):
1621         (FactoryTest.test_chromium_linux):
1622         (FactoryTest.test_chromium_win):
1623         (FactoryTest.test_unknown_specified):
1624         (FactoryTest.test_unknown_default):
1625         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1626         (TestGoogleChromePort):
1627         (TestGoogleChromePort._verify_baseline_path):
1628         (TestGoogleChromePort._verify_expectations_overrides):
1629         (TestGoogleChromePort.test_get_google_chrome_port):
1630         * Scripts/webkitpy/layout_tests/port/mac.py:
1631         (MacPort):
1632         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1633         (MacTest):
1634         (assert_name):
1635         (test_tests_for_other_platforms):
1636         (test_version):
1637         (test_versions):
1638         (test_is_version_methods):
1639         (test_setup_environ_for_server):
1640         (_assert_search_path):
1641         (test_show_results_html_file):
1642         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1643         (PortTestCase):
1644         (PortTestCase.make_port):
1645         * Scripts/webkitpy/layout_tests/port/win.py:
1646         (WinPort):
1647         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1648         (WinPortTest):
1649         (WinPortTest.test_show_results_html_file):
1650         (WinPortTest._assert_search_path):
1651         (WinPortTest._assert_version):
1652
1653 2012-01-11  Hugo Parente Lima  <hugo.lima@openbossa.org>
1654
1655         [Qt][WK2] Remove workaround introduced into bug 75470
1656         https://bugs.webkit.org/show_bug.cgi?id=75889
1657
1658         Reviewed by Tor Arne Vestbø.
1659
1660         * MiniBrowser/qt/qml/BrowserWindow.qml:
1661
1662 2012-01-10  Dmitry Lomov  <dslomov@google.com>
1663
1664         [Chromium] Remove obsolete references to WebWorker class.
1665         https://bugs.webkit.org/show_bug.cgi?id=76020
1666
1667         Reviewed by David Levin.
1668
1669         * DumpRenderTree/chromium/TestWebWorker.h: Removed.
1670         * DumpRenderTree/chromium/WebViewHost.cpp:
1671         * DumpRenderTree/chromium/WebViewHost.h:
1672
1673 2012-01-11  Csaba Osztrogonác  <ossy@webkit.org>
1674
1675         [Qt] Some css3 filter tests are failing after r104698
1676         https://bugs.webkit.org/show_bug.cgi?id=76055
1677
1678         Reviewed by Simon Hausmann.
1679
1680         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1681         (LayoutTestController::overridePreference): Add WebKitAcceleratedCompositingEnabled preference.
1682
1683 2012-01-11  Tony Chang  <tony@chromium.org>
1684
1685         Don't remove 0 byte files when running build-webkit --chromium
1686         https://bugs.webkit.org/show_bug.cgi?id=75997
1687
1688         Reviewed by Csaba Osztrogonác.
1689
1690         If QTDIR is set, isQt() is true even when running build-webkit --chromium.
1691
1692         * Scripts/webkitdirs.pm:
1693         (determineIsQt):
1694
1695 2012-01-10  David Kilzer  <ddkilzer@apple.com>
1696
1697         Add TestWebKitAPI tests for KURL
1698         <http://webkit.org/b/75774>
1699
1700         Reviewed by Adam Barth.
1701
1702         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add a
1703         WebCore folder and KURL.cpp source file to the project.
1704         * TestWebKitAPI/Tests/WebCore/KURL.cpp: Added.
1705         (TestWebKitAPI::WebCore::SetUp): Initialize the main thread
1706         during setup since this test doesn't go through WebKit or
1707         WebKit2.
1708         (TestWebKitAPI::TEST_F): Add two basic tests.
1709
1710 2012-01-10  David Kilzer  <ddkilzer@apple.com>
1711
1712         Extract common code for comparing WTF::String objects into WTFStringUtilities.h
1713
1714         Reviewed by Adam Barth.
1715
1716         Needed for: <http://webkit.org/b/75774> Add TestWebKitAPI tests for KURL
1717
1718         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
1719         WTFStringUtilities.h to the project.
1720         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Update to use
1721         WTFStringUtilities.h.
1722         * TestWebKitAPI/WTFStringUtilities.h: Added.
1723         (WTF::operator<<):
1724
1725 2012-01-10  Vincent Scheib  <scheib@chromium.org>
1726
1727         Clarify run-webkit-tests options reset-results and new-baseline
1728         https://bugs.webkit.org/show_bug.cgi?id=75993
1729
1730         Reviewed by Dirk Pranke.
1731
1732         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1733         (parse_args):
1734
1735 2012-01-10  Simon Fraser  <simon.fraser@apple.com>
1736
1737         Disabled mock scrollbars should draw differently
1738         https://bugs.webkit.org/show_bug.cgi?id=75995
1739
1740         Reviewed by James Robinson.
1741
1742         When the scrollbar is disabled, paint the entire track of
1743         mock scrollbars with a lighter gray, and hide the thumb.
1744
1745         * DumpRenderTree/mac/DumpRenderTree.mm:
1746         (-[DRTMockScroller drawKnob]):
1747         (-[DRTMockScroller drawRect:]):
1748
1749 2012-01-10  James Robinson  <jamesr@chromium.org>
1750
1751         [chromium] Run webkit_unit_tests as part of webkit-patch build-and-test
1752         https://bugs.webkit.org/show_bug.cgi?id=75988
1753
1754         Reviewed by Adam Barth.
1755
1756         * Scripts/webkitpy/common/config/ports.py:
1757         (WebKitPort.run_webkit_unit_tests_command):
1758         (WebKitPort):
1759         (ChromiumPort.run_webkit_unit_tests_command):
1760         (ChromiumPort):
1761         * Scripts/webkitpy/common/config/ports_mock.py:
1762         (MockPort.run_webkit_unit_tests_command):
1763         * Scripts/webkitpy/tool/commands/download_unittest.py:
1764         (DownloadCommandsTest.test_build_and_test):
1765         (test_land):
1766         (test_land_red_builders):
1767         * Scripts/webkitpy/tool/steps/runtests.py:
1768         (RunTests.run):
1769         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1770
1771 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
1772
1773         webkitpy: add os_name, os_version to platforminfo
1774         https://bugs.webkit.org/show_bug.cgi?id=75931
1775
1776         Reviewed by Eric Siedel.
1777
1778         As a first step in cleaning up the version parsing logic in
1779         webkitpy.layout_tests.port, this adds common routines for
1780         getting the os_name and os_version fields to the PlatformInfo
1781         class. Nothing uses them yet but I've added FIXME's to some of
1782         the code that needs to be deleted in the port files.
1783
1784         * Scripts/webkitpy/common/system/platforminfo.py:
1785         (PlatformInfo.__init__):
1786         (PlatformInfo):
1787         (PlatformInfo._determine_os_name):
1788         (PlatformInfo._determine_mac_version):
1789         (PlatformInfo._determine_linux_version):
1790         (PlatformInfo._determine_win_version):
1791         (PlatformInfo.display_name):
1792         (PlatformInfo.total_bytes_memory):
1793         (PlatformInfo._compute_bytes_from_vm_stat_output):
1794         (PlatformInfo.free_bytes_memory):
1795         * Scripts/webkitpy/common/system/platforminfo_unittest.py: Added.
1796         (TestPlatformInfo):
1797         (TestPlatformInfo.make_info):
1798         (TestPlatformInfo.make_info.mock_run_command):
1799         (TestPlatformInfo.setUp):
1800         (TestPlatformInfo.tearDown):
1801         (TestPlatformInfo.test_basic):
1802         (TestPlatformInfo.integration_test_basic):
1803         (TestPlatformInfo.test_display_name_mac):
1804         (TestPlatformInfo.test_display_name_win32):
1805         (TestPlatformInfo.test_memory_mac):
1806         (TestPlatformInfo.test_memory_win32):
1807         (TestPlatformInfo.test_determine_os_name):
1808         (TestPlatformInfo.test_determine_mac_version):
1809         (TestPlatformInfo.test_determine_linux_version):
1810         (TestPlatformInfo.test_determine_win_version_from_tuple):
1811         (TestPlatformInfo.test_determine_win_version_from_cmd):
1812         * Scripts/webkitpy/layout_tests/port/apple.py:
1813         (ApplePort.__init__):
1814         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1815         (ChromiumMacPort.__init__):
1816         * Scripts/webkitpy/layout_tests/port/mac.py:
1817         (MacPort):
1818         * Scripts/webkitpy/layout_tests/port/win.py:
1819         (WinPort):
1820
1821 2012-01-10  Adam Roben  <aroben@apple.com>
1822
1823         Make it possible to type data: URLs into MiniBrowser on Windows
1824
1825         Fixes <http://webkit.org/b/75084> Crash when trying to navigate to a data: URL in
1826         MiniBrowser on Windows
1827
1828         Reviewed by Darin Adler.
1829
1830         * MiniBrowser/win/BrowserWindow.cpp:
1831         (BrowserWindow::handleMessage): Instead of checking for an "http://" prefix when deciding
1832         whether to prepend "http://", just look for whether the typed URL contains a colon. If it
1833         does, we assume it already has a scheme and don't modify it.
1834
1835 2012-01-10  Adam Roben  <aroben@apple.com>
1836
1837         Make MiniBrowser automatically escape invalid URL characters typed in its URL field
1838
1839         Fixes <http://webkit.org/b/75086> Crash when typing a data: URL containing double-quotes in
1840         MiniBrowser on Windows
1841
1842         Reviewed by Darin Adler.
1843
1844         * MiniBrowser/win/BrowserView.cpp:
1845         (BrowserView::goToURL): Pass the typed string through
1846         CFURLCreateStringByAddingPercentEscapes before trying to create a URL from it.
1847
1848 2012-01-10  Ben Wells  <benwells@chromium.org>
1849
1850         Adding myself (benwells) to committers.py
1851         https://bugs.webkit.org/show_bug.cgi?id=75971
1852
1853         Reviewed by Ojan Vafai.
1854
1855         * Scripts/webkitpy/common/config/committers.py:
1856
1857 2012-01-10  Mario Sanchez Prada  <msanchez@igalia.com>
1858
1859         AX: support helpText() in DumpRenderTree
1860         https://bugs.webkit.org/show_bug.cgi?id=40193
1861
1862         Reviewed by Chris Fleizach.
1863
1864         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1865         (AccessibilityUIElement::helpText): Implemented.
1866
1867 2012-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1868
1869         Unreviewed, rolling out r104572.
1870         http://trac.webkit.org/changeset/104572
1871         https://bugs.webkit.org/show_bug.cgi?id=75967
1872
1873         It broke zillion tests (Requested by Ossy on #webkit).
1874
1875         * DumpRenderTree/qt/EventSenderQt.cpp:
1876         (EventSender::EventSender):
1877         (EventSender::sendOrQueueEvent):
1878         (EventSender::replaySavedEvents):
1879         (EventSender::eventFilter):
1880         * DumpRenderTree/qt/EventSenderQt.h:
1881
1882 2012-01-10  Hugo Parente Lima  <hugo.lima@openbossa.org>
1883
1884         [Qt] fast/events/dont-loose-last-event test fails on WK1
1885         https://bugs.webkit.org/show_bug.cgi?id=73894
1886
1887         Reviewed by Simon Hausmann.
1888
1889         Empty the entire event queue when requested besides using
1890         sendEvent instead of postEvent to make sure all events were
1891         delivered.
1892         This commit also removes not working DRT code to handle drag and drop,
1893         for more refs see: https://bugs.webkit.org/show_bug.cgi?id=31332
1894
1895         * DumpRenderTree/qt/EventSenderQt.cpp:
1896         (EventSender::EventSender):
1897         (EventSender::sendOrQueueEvent):
1898         (EventSender::replaySavedEvents):
1899         * DumpRenderTree/qt/EventSenderQt.h:
1900
1901 2012-01-10  No'am Rosenthal  <noam.rosenthal@nokia.com>
1902
1903         [Qt] Enable CSS_FILTERS in Qt build
1904         https://bugs.webkit.org/show_bug.cgi?id=75777
1905
1906         Add the CSS_FILTERS feature flag to Qt.
1907
1908         Reviewed by Kenneth Rohde Christiansen.
1909
1910         * qmake/mkspecs/features/features.prf:
1911
1912 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
1913
1914         [Qt] Unreviewed -Werror build fix.
1915
1916         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1917         (MiniBrowserApplication::MiniBrowserApplication): Re-order initialization to match
1918         declaration.
1919
1920 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
1921
1922         [Qt] Remove dependency to uitools
1923         https://bugs.webkit.org/show_bug.cgi?id=75952
1924
1925         Reviewed by Tor Arne Vestbø.
1926
1927         QUiLoader is used for creating QLabel/QProgressBar widgets for
1928         a layout test, to verify some widget embedding feature. Unfortunately
1929         in Qt 5, QUiLoader is part of qttools, which depends on webkit, which
1930         depends on qttools. Since we don't really _need_ QUiLoader for our tests,
1931         let's break the circular dependency.
1932
1933         * DumpRenderTree/qt/DumpRenderTree.pro:
1934         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1935         (WebCore::WebPage::createPlugin):
1936         * QtTestBrowser/QtTestBrowser.pro:
1937         * QtTestBrowser/launcherwindow.h:
1938         * QtTestBrowser/webpage.cpp:
1939         (WebPage::createPlugin):
1940         * qmake/mkspecs/features/minimal_qt.prf:
1941         * qmake/mkspecs/features/uitools.prf: Removed.
1942
1943 2012-01-10  Alexander Færøy  <alexander.faeroy@nokia.com>
1944
1945         [Qt] Don't expose m_windowOptions as part of the public interface in MiniBrowserApplication
1946         https://bugs.webkit.org/show_bug.cgi?id=75894
1947
1948         Reviewed by Tor Arne Vestbø.
1949
1950         * MiniBrowser/qt/MiniBrowserApplication.h:
1951         (MiniBrowserApplication::windowOptions):
1952         * MiniBrowser/qt/main.cpp:
1953         (main):
1954
1955 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
1956
1957         [Qt] DRT crashes with Qt 5
1958         https://bugs.webkit.org/show_bug.cgi?id=75951
1959
1960         Reviewed by Ossy.
1961
1962         * DumpRenderTree/qt/fonts.conf: Add missing last-resort font fallback for Qt 5 where
1963         Qt relies on font-config to define the default font family.
1964
1965 2012-01-10  Csaba Osztrogonác  <ossy@webkit.org>
1966
1967         [Qt] REGRESSION(r100130): Clean build feature is broken.
1968         https://bugs.webkit.org/show_bug.cgi?id=75863
1969
1970         Reviewed by Tor Arne Vestbø.
1971
1972         * Scripts/webkitdirs.pm:
1973         (buildQMakeProject):
1974
1975 2012-01-10  Zeno Albisser  <zeno@webkit.org>
1976
1977         [Qt][WK2] Fix keyboard shortcuts in MiniBrowser.
1978         https://bugs.webkit.org/show_bug.cgi?id=75885
1979
1980         In QML events are propagated through parents. But since the
1981         WebView may consume key events, a shortcut might never reach
1982         the top QtQuickItem.
1983         Therefore an application wide event handling function in C++
1984         needs to take care of shortcuts for MiniBrowser.
1985
1986         Reviewed by Kenneth Rohde Christiansen.
1987
1988         * MiniBrowser/qt/BrowserWindow.cpp:
1989         (BrowserWindow::reload):
1990         (BrowserWindow::focusAddressBar):
1991         * MiniBrowser/qt/BrowserWindow.h:
1992         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1993         (MiniBrowserApplication::notify):
1994         * MiniBrowser/qt/qml/BrowserWindow.qml:
1995
1996 2012-01-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1997
1998         Add --efl alias for --platform=efl to run-webkit-test
1999         https://bugs.webkit.org/show_bug.cgi?id=75937
2000
2001         Reviewed by Andreas Kling.
2002         
2003         * Scripts/run-webkit-tests: Add --efl alias.
2004         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --efl alias.
2005         (parse_args):
2006
2007 2012-01-09  Dan Bernstein  <mitz@apple.com>
2008
2009         -[DOMRange renderedImageForcingBlackText:] fails with non-user-selectable text
2010         https://bugs.webkit.org/show_bug.cgi?id=75920
2011
2012         Reviewed by Darin Adler.
2013
2014         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
2015         (TestWebKitAPI::TEST): Added a test for a range in a
2016         -webkit-user-select: none; block.
2017
2018 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
2019
2020         webkitpy.layout_tests.port.mock_drt_unittest.MockChromiumDRTTest has been failing on cr-win
2021         https://bugs.webkit.org/show_bug.cgi?id=75884
2022
2023         Reviewed by Ryosuke Niwa.
2024
2025         Fix regression introduced (revealed?) in r104340. Chromium file         
2026         url syntax is different on win32 and the test results weren't           
2027         expecting that.                                                         
2028
2029         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2030         (TestExpectations._report_errors):
2031         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2032         (test_parse_error_nonfatal):
2033         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2034         (MockDRTTest.input_line):
2035         (MockChromiumDRTTest.test_pixeltest__fails):
2036         * Scripts/webkitpy/layout_tests/port/test.py:
2037         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2038         (TestRebaseliner.make_rebaseliner):
2039         (TestRebaseliner.test_one_platform):
2040         (TestRebaseliner.test_all_platforms):
2041         (TestRebaseliner.test_png_file_with_comment):
2042         (TestRebaseliner.test_png_file_with_comment_remove_old_checksum):
2043         (TestRebaseliner.test_png_file_with_comment_as_duplicate):
2044         (TestRealMain.test_all_platforms):
2045
2046 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
2047
2048         Fix regression in test-webkitpy introduced by removing the webkitpy/python24 directory.
2049
2050         Unreviewed, build fix.
2051
2052         test-webkitpy had a built-in self-test routine to verify that
2053         deleting the .pyc files worked correctly. When I removed the
2054         python24 directory in r104482, I broke the self-test.
2055
2056         I have deleted the self-test for now. Since I am reworking
2057         test-webkitpy I will make sure the new version is adequately
2058         tested.
2059
2060         * Scripts/test-webkitpy:
2061         (configure_logging):
2062         (_clean_pyc_files):
2063         (_clean_packages):
2064         (init):
2065
2066 2012-01-09  Justin Novosad  <junov@chromium.org>
2067
2068         [Chromium] remove all references to the legacy accelerated 2d Canvas
2069         implementation
2070         https://bugs.webkit.org/show_bug.cgi?id=75108
2071
2072         Purging an old settings flag that is no longer referenced
2073
2074         Reviewed by Darin Fisher.
2075
2076         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2077         (main):
2078         * DumpRenderTree/chromium/TestShell.cpp:
2079         (TestShell::TestShell):
2080         (TestShell::resetWebSettings):
2081         * DumpRenderTree/chromium/TestShell.h:
2082         (TestShell::setAccelerated2dCanvasEnabled):
2083         * DumpRenderTree/chromium/WebPreferences.cpp:
2084         (WebPreferences::reset):
2085         (WebPreferences::applyTo):
2086         * DumpRenderTree/chromium/WebPreferences.h:
2087
2088 2012-01-09  Adam Roben  <aroben@apple.com>
2089
2090         Convert Cygwin paths to Windows paths before passing them to DRT
2091
2092         Fixes <http://webkit.org/b/64468> <rdar://problem/10663409> WIN: DumpRenderTree hangs under
2093         NRWT
2094
2095         I couldn't find a way to test this because I couldn't figure out how to override the
2096         cygpath function as it is used by WebKitDriver.
2097
2098         Reviewed by Dirk Pranke.
2099
2100         * Scripts/webkitpy/layout_tests/port/webkit.py:
2101         (WebKitDriver._command_from_driver_input): On Cygwin, convert the test's path to a
2102         Windows-style path before passing it to DRT.
2103
2104 2012-01-06  Dirk Pranke  <dpranke@chromium.org>
2105
2106         webkitpy: revamp version checking
2107         https://bugs.webkit.org/show_bug.cgi?id=75765
2108
2109         Reviewed by Adam Barth.
2110
2111         The version-checking code in webkitpy/python24/versioning seems really
2112         awkward and overdesigned, especially since we don't support python 2.4
2113         any more.
2114
2115         In addition, I am tired of getting warnings about Python 2.6 being "a
2116         newer release than what is supported" :).
2117
2118         I'm taking a page from the depot_tools python code and just creating a
2119         new webkitpy.common.version_check module that will print a message on
2120         stderr and call sys.exit() if we're running an unsupported version.
2121
2122         * Scripts/check-webkit-style:
2123         * Scripts/new-run-webkit-httpd:
2124         * Scripts/new-run-webkit-tests:
2125         * Scripts/rebaseline-chromium-webkit-tests:
2126         * Scripts/test-webkitpy:
2127         (configure_logging):
2128         (init):
2129         * Scripts/webkit-patch:
2130         (main):
2131         * Scripts/webkitpy/common/system/executive.py:
2132         (Executive._child_process_encoding):
2133         (Executive._should_encode_child_process_arguments):
2134         * Scripts/webkitpy/common/version_check.py: Copied from Tools/Scripts/rebaseline-chromium-webkit-tests.
2135         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2136         * Scripts/webkitpy/python24/__init__.py: Removed.
2137         * Scripts/webkitpy/python24/versioning.py: Removed.
2138         * Scripts/webkitpy/python24/versioning_unittest.py: Removed.
2139
2140 2012-01-09  Adam Barth  <abarth@webkit.org>
2141
2142         Remove Chromium Mac CG from the flakiness dashboard
2143         https://bugs.webkit.org/show_bug.cgi?id=75873
2144
2145         Reviewed by Ojan Vafai.
2146
2147         This configuration no longer exists.
2148
2149         * TestResultServer/static-dashboards/builders.js:
2150         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2151         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2152         (testOverrideJustBuildType):
2153         (testPlatformAndBuildType):
2154
2155 2012-01-06  Adam Roben  <aroben@apple.com>
2156
2157         Print an error message when NRWT can't run Apache
2158
2159         Fixes <http://webkit.org/b/75712> NRWT mysteriously exits when Apache returns an error code
2160
2161         Reviewed by Dirk Pranke.
2162
2163         * Scripts/webkitpy/layout_tests/port/base.py:
2164         (Port.check_httpd): Print an error message when Apache returns an error code instead of
2165         failing silently.
2166
2167         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2168         (PortTest.test_check_httpd_success): Test that we don't print anything when we successfully
2169         run Apache.
2170         (PortTest.test_httpd_returns_error_code): Test that we print an error message when Apache
2171         fails.
2172
2173 2012-01-09  Gabor Rapcsanyi  <rgabor@webkit.org>
2174
2175         [Gtk][ARM] Cross compiler buildbot is failing after r103040
2176         https://bugs.webkit.org/show_bug.cgi?id=75846
2177
2178         Reviewed by Philippe Normand.
2179
2180         * Scripts/webkitdirs.pm:
2181         (runAutogenForAutotoolsProjectIfNecessary):
2182
2183 2012-01-09  Alexander Færøy  <ahf@0x90.dk>
2184
2185         [Qt] Add support for dynamically enabling and disabling touch mocking in the Qt MiniBrowser
2186         https://bugs.webkit.org/show_bug.cgi?id=75807
2187
2188         This patch adds a new icon to navigationbar of the Qt MiniBrowser
2189         which allows you to dynamically toggle whether touch mocking is
2190         enabled or disabled.
2191
2192         Reviewed by Tor Arne Vestbø.
2193
2194         * MiniBrowser/qt/MiniBrowser.qrc:
2195         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2196         (MiniBrowserApplication::notify):
2197         * MiniBrowser/qt/MiniBrowserApplication.h:
2198         (WindowOptions::WindowOptions):
2199         (WindowOptions::touchMockingEnabled):
2200         (WindowOptions::setTouchMockingEnabled):
2201         * MiniBrowser/qt/icons/touch.png: Added.
2202         * MiniBrowser/qt/qml/BrowserWindow.qml:
2203
2204 2012-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2205
2206         Unreviewed. Fix make distcheck issues.
2207
2208         * MiniBrowser/gtk/GNUmakefile.am:
2209
2210 2012-01-08  Sheriff Bot  <webkit.review.bot@gmail.com>
2211
2212         Unreviewed, rolling out r104421.
2213         http://trac.webkit.org/changeset/104421
2214         https://bugs.webkit.org/show_bug.cgi?id=75816
2215
2216         Need to rebaseline some tests on Linux (Requested by noamr on
2217         #webkit).
2218
2219         * qmake/mkspecs/features/features.prf:
2220
2221 2012-01-08  Adam Barth  <abarth@webkit.org>
2222
2223         Remove support for Chromium Mac CG from garden-o-matic
2224         https://bugs.webkit.org/show_bug.cgi?id=75814
2225
2226         Reviewed by Eric Seidel.
2227
2228         This configuration no longer exists.  This patch is mostly a matter of
2229         updating config.js and removing the examples from the unit tests.
2230
2231         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2232         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2233         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2234         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
2235         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2236
2237 2012-01-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
2238
2239         [Qt] Enable CSS_FILTERS in Qt build
2240         https://bugs.webkit.org/show_bug.cgi?id=75777
2241
2242         Add the CSS_FILTERS feature flag to Qt.
2243
2244         Reviewed by Kenneth Rohde Christiansen.
2245
2246         * qmake/mkspecs/features/features.prf:
2247
2248 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
2249
2250         Categorize bots by ports instead of core/non-core separation
2251         https://bugs.webkit.org/show_bug.cgi?id=75766
2252
2253         Reviewed by Eric Seidel.
2254
2255         Rename categorizes so as to preserve the original ordering of bots per Eric's suggestion
2256         (Chromium still comes before GTK and Qt).
2257
2258         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2259         (loadBuilderConfig):
2260         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2261
2262 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
2263
2264         Remove the concept of core builders from webkitpy
2265         https://bugs.webkit.org/show_bug.cgi?id=75809
2266
2267         Reviewed by Ryosuke Niwa.
2268
2269         Treat all bots equally since core/non-core sepration has been removed from build.webkit.org,
2270         and remove the relevant code.
2271
2272         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2273         (BuildBot.__init__):
2274         (BuildBot._matches_regexps):
2275         (BuildBot._builder_statuses_with_names_matching_regexps):
2276         (BuildBot.builder_statuses):
2277         (BuildBot.failure_map):
2278         (BuildBot._latest_builds_from_builders):
2279         (BuildBot.last_green_revision):
2280         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
2281         (MockBuildBot.builder_statuses):
2282         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2283         (test_status_parsing):
2284         (test_last_green_revision):
2285         (test_last_green_revision.mock_builds_from_builders):
2286
2287 2012-01-08  Adam Barth  <abarth@webkit.org>
2288
2289         Remove Chromium Mac CG concept from webkitpy
2290         https://bugs.webkit.org/show_bug.cgi?id=75810
2291
2292         Reviewed by Ryosuke Niwa.
2293
2294         This configuration no longer exists.  We can remove all the supporting
2295         code from webkitpy.
2296
2297         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
2298         (BaselineOptimizerTest.test_move_baselines):
2299         (BaselineOptimizerTest.test_chromium_covers_mac_win_linux):
2300         (BaselineOptimizerTest.test_chromium_mac_redundant_with_apple_mac):
2301         (BaselineOptimizerTest.test_common_directory_includes_root):
2302         (BaselineOptimizerTest.test_complex_shadowing):
2303         * Scripts/webkitpy/common/config/build.py:
2304         (_should_file_trigger_build):
2305         * Scripts/webkitpy/common/config/build_unittest.py:
2306         (ShouldBuildTest):
2307         * Scripts/webkitpy/layout_tests/port/builders.py:
2308         * Scripts/webkitpy/layout_tests/port/chromium.py:
2309         (ChromiumPort):
2310         (ChromiumPort._generate_all_test_configurations):
2311         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2312         (_default_tests_paths):
2313         (ChromiumGpuLinuxPort.tests):
2314         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2315         (ChromiumGpuTest.integration_test_chromium_gpu_mac):
2316         (ChromiumGpuTest.assert_port_works):
2317         (ChromiumGpuTest.test_baseline_paths):
2318         (ChromiumGpuTest.test_graphics_type):
2319         (ChromiumGpuTest.test_default_tests_paths):
2320         (ChromiumGpuTest.test_test_files):
2321         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2322         (ChromiumMacPort):
2323         (ChromiumMacPort.__init__):
2324         (ChromiumMacPort.baseline_search_path):
2325         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2326         (ChromiumMacPortTest.test_graphics_type):
2327         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2328         (ChromiumPortTest.test_all_test_configurations):
2329         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2330         * Scripts/webkitpy/layout_tests/port/factory.py:
2331         (PortFactory._port_name_from_arguments_and_options):
2332         (PortFactory.get):
2333         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2334         (FactoryTest.test_chromium_gpu_mac):
2335         (FactoryTest.test_chromium_mac):
2336         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2337         (GetGoogleChromePortTest._verify_expectations_overrides):
2338         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2339         (MockChromiumDRTTest.test_chromium_parse_options):
2340         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2341         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2342         (test_url_fetcher):
2343         (test_zip_factory):
2344         (test_archive):
2345         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2346         (TestRebaseline.test_rebaseline_expectations):
2347
2348 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
2349
2350         Categorize bots by ports instead of core/non-core separation
2351         https://bugs.webkit.org/show_bug.cgi?id=75766
2352
2353         Reviewed by Adam Barth.
2354
2355         Get rid of the concept of core/non-core builders, and categorize build bots by ports instead.
2356
2357         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2358         (loadBuilderConfig):
2359         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2360
2361 2012-01-08  Sheriff Bot  <webkit.review.bot@gmail.com>
2362
2363         Unreviewed, rolling out r104403.
2364         http://trac.webkit.org/changeset/104403
2365         https://bugs.webkit.org/show_bug.cgi?id=75803
2366
2367         It broke all tests on Qt5 (Requested by Ossy_weekend on
2368         #webkit).
2369
2370         * qmake/mkspecs/features/features.prf:
2371
2372 2012-01-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
2373
2374         [Qt] Enable CSS_FILTERS in Qt build
2375         https://bugs.webkit.org/show_bug.cgi?id=75777
2376
2377         Add the CSS_FILTERS feature flag to Qt.
2378
2379         Reviewed by Kenneth Rohde Christiansen.
2380
2381         * qmake/mkspecs/features/features.prf:
2382
2383 2012-01-04  Kentaro Hara  <haraken@chromium.org>
2384
2385         Rewrite the CSS parser of prepare-ChangeLog with unittests.
2386         https://bugs.webkit.org/show_bug.cgi?id=75202
2387
2388         Reviewed by David Kilzer.
2389
2390         The current CSS parser can just parse simple CSSes like
2391
2392             foo bar baz {
2393                 property1: value;
2394                 property2: value;
2395             }
2396
2397         , and cannot parse comments nor a CSS in which a selector and {
2398         appears in different lines. This patch rewrites the CSS parser
2399         (i.e. get_selector_line_ranges_for_css()) so that it can parse more CSSes
2400         shown in css_unittests.css.
2401
2402         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css
2403
2404         * Scripts/prepare-ChangeLog:
2405         (get_selector_line_ranges_for_css):
2406         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2407         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Added.
2408         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css: Added.
2409         (element1):
2410         (element2):
2411         (element3):
2412         (element4.p):
2413         (element5.p.q.r.s):
2414         (element6#p):
2415         (element7 element8):
2416         (element9.p element10.q):
2417         (element11#p element12#q):
2418         (element13, element14):
2419         (.p):
2420         (#p):
2421         (.p element15 #q element16.r element17#s):
2422         (element18:target):
2423         (element19):
2424         (element20):
2425         (element21):
2426         (element22):
2427
2428 2012-01-04  Kentaro Hara  <haraken@chromium.org>
2429
2430         The Perl parser of prepare-ChangeLog can parse here-documents
2431         https://bugs.webkit.org/show_bug.cgi?id=73208
2432
2433         Reviewed by David Kilzer.
2434
2435         Currently prepare-ChangeLog cannot recognize here-documents in Perl,
2436         which results in wrong subroutine names in ChangeLogs.
2437         With this patch, prepare-ChangeLog can judge whether the line of "}"
2438         is the end of a subroutine or a line inside a here-document.
2439
2440         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
2441
2442         * Scripts/prepare-ChangeLog:
2443         (get_function_line_ranges_for_perl):
2444         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
2445         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
2446         Added test cases for here-documents.
2447         (func7):
2448         (func8):
2449         (func9):
2450         (func10):
2451         (func11):
2452         (func12):
2453         (func13):
2454         (func14):
2455         (func15):
2456         (func16):
2457
2458 2012-01-08  Kentaro Hara  <haraken@chromium.org>
2459
2460         Add unittests for the JavaScript parser of prepare-ChangeLog
2461         https://bugs.webkit.org/show_bug.cgi?id=75201
2462
2463         Reviewed by David Kilzer.
2464
2465         javascript_unittests.js is a unittest for get_function_line_ranges_for_javascript()
2466         of prepare-ChangeLog.
2467
2468         * Scripts/prepare-ChangeLog:
2469         (get_function_line_ranges_for_javascript): Before this patch, a string found was just
2470         omitted from parsing. Thus,
2471
2472             str = "foo"
2473             function func() {
2474             }
2475
2476         was recognized as equivalent to
2477
2478             str = function func() {
2479             }
2480
2481         This patch replaces a string with a dummy identifier 'string_appeared_here'
2482         to tell the parser that a string appeared there.
2483
2484         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2485         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Added.
2486         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js: Added.
2487         (func1):
2488         (func2):
2489         (func3):
2490         (func4):
2491         (func5):
2492         (func6):
2493         (func7):
2494         (func8):
2495         (func9):
2496         (func10):
2497         (func11):
2498         (func12):
2499         (funcOverloaded):
2500         (Func1.prototype.get x1):
2501         (Func1.prototype.get x2):
2502         (Func1.prototype.set x1):
2503         (Func1.prototype.set x3):
2504         (Func2.prototype.func13):
2505         (Func2.prototype.func14):
2506         (Func2.prototype.func15):
2507         (func16.func17):
2508         (func16.func18):
2509         (func16.func19):
2510         (func16):
2511
2512 2012-01-08  David Levin  <levin@chromium.org>
2513
2514         [chromium] Add layout test support for autosize code in FrameView.
2515         https://bugs.webkit.org/show_bug.cgi?id=73631
2516
2517         Reviewed by Dmitry Titov.
2518
2519         * DumpRenderTree/chromium/LayoutTestController.cpp:
2520         (LayoutTestController::LayoutTestController): Expose the new autoresize method.
2521         (LayoutTestController::reset): Set the autoresize mode back to false.
2522         (LayoutTestController::enableAutoResizeMode): A way to turn on autoresizing from javascript code in DumpRenderTree.
2523         * DumpRenderTree/chromium/LayoutTestController.h:
2524         * DumpRenderTree/chromium/WebViewHost.cpp:
2525         (WebViewHost::didAutoResize): Handle the autoresize callback so that the outer bounds change appropriately.
2526         * DumpRenderTree/chromium/WebViewHost.h:
2527
2528 2012-01-07  Zan Dobersek  <zandobersek@gmail.com>
2529
2530         [WK2][GTK] Each test takes roughly half a second to load
2531         https://bugs.webkit.org/show_bug.cgi?id=70699
2532
2533         Reviewed by Martin Robinson.
2534
2535         Set the XDG_CACHE_HOME environment variable when testing with
2536         WebKitTestRunner. This way the testing is started with a non-existing
2537         application cache. If the cache exists and is not empty, the emptying
2538         and vacuuming that is performed before every test can consume a lot of
2539         time.
2540
2541         This is just a temporary workaround until it becomes possible to set
2542         a desired directory to be used as the application cache location through
2543         WebKitWebContext.
2544
2545         * Scripts/webkitpy/layout_tests/port/gtk.py:
2546         (GtkPort.setup_environ_for_server):
2547
2548 2012-01-07  Zan Dobersek  <zandobersek@gmail.com>
2549
2550         [GTK] Enable requestAnimationFrame in build-webkit
2551         https://bugs.webkit.org/show_bug.cgi?id=75773
2552
2553         Reviewed by Martin Robinson.
2554
2555         Enable requestAnimationFrame for the Gtk port.
2556
2557         * Scripts/build-webkit:
2558
2559 2012-01-06  Jarred Nicholls  <jarred@sencha.com>
2560
2561         Unreviewed build-webkit fix for Chromium to properly use make if gyp generates Makefiles.
2562
2563         * Scripts/webkitdirs.pm:
2564         (buildChromium):
2565         Missing parentheses.
2566
2567 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
2568
2569         Fix DRT build on case-sensitive file systems.
2570
2571         Fix case of include of WebDynamicScrollBarsView.h
2572         
2573         * DumpRenderTree/mac/DumpRenderTree.mm:
2574
2575 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
2576
2577         Pixel results from DumpRenderTree and WebKitTestRunner don't match because of colorspace issues
2578         https://bugs.webkit.org/show_bug.cgi?id=75662
2579
2580         Reviewed by Dan Bernstein.
2581         
2582         The pixel results generated by DumpRenderTree and WebKitTestRunner differed because
2583         of color profile issues. Fix by keeping everything in device RGB and ensuring that the
2584         test window uses the main display's color space, so that the pixel values in the bitmap
2585         that gets checksummed are identical to the CSS colors.
2586         
2587         Removed the code that switches the display profile in DRT, since that is no longer required.
2588
2589         * DumpRenderTree/PixelDumpSupport.h: Remove unused function declarations.
2590         * DumpRenderTree/mac/DumpRenderTree.mm:
2591         (crashHandler): Remove code that switches display profiles.
2592         (prepareConsistentTestingEnvironment): Ditto.
2593         (dumpRenderTree): Ditto.
2594         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Ditto.
2595         (createBitmapContext): Use DeviceRGB for the bitmap colorspace.
2596         (createBitmapContextFromWebView): Add comment about the colorspace handling.
2597         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2598         (WTR::createCGContextFromImage): Use a RetainPtr, add comment.
2599         (WTR::computeMD5HashStringForContext): Simplify the #ifdefs around the braces.
2600         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2601         (WTR::PlatformWebView::PlatformWebView): Set the window's colorspace to that of the main display.
2602         (WTR::PlatformWebView::windowSnapshotImage): Add comment about colorspaces.
2603
2604 2012-01-06  David Kilzer  <ddkilzer@apple.com>
2605
2606         run-api-tests: specify individual suites and tests on the command-line
2607
2608         Reviewed by Adam Roben.
2609
2610         Fixes: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
2611
2612         The run-api-tests script will now accept a list of arguments on
2613         the command-line that are used as prefix filters.  To run all
2614         tests in a suite that starts with "WTF" (WTF and WTF_Vector)
2615         use:
2616
2617             $ run-api-tests WTF
2618
2619         To run only the tests in the "WTF" suite, not the "WTF_Vector"
2620         suite, use:
2621
2622             $ run-api-tests WTF.
2623
2624         * Scripts/run-api-tests: Filter tests if any prefix arguments
2625         are passed on the command-line.
2626
2627 2012-01-06  David Kilzer  <ddkilzer@apple.com>
2628
2629         run-api-tests: change internal representation of tests to array of "SuiteName.TestName" strings
2630
2631         Reviewed by Adam Roben.
2632
2633         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
2634
2635         * Scripts/run-api-tests:
2636         (dumpTestsBySuite): Update to accept array of tests instead of
2637         hash data structure.
2638         (runTestsBySuite): Ditto.
2639         (listAllTests): Rename from populateTests().  Update to return
2640         an array of tests instad of the hash data structure.
2641
2642 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
2643
2644         webkitpy: clean up test/uri conversion routines
2645         https://bugs.webkit.org/show_bug.cgi?id=75648
2646
2647         Reviewed by Eric Seidel.
2648
2649         This change moves test_to_uri and uri_to_test from the Port
2650         class to the Driver class (the routines were only being
2651         called by the drivers), and removes a bunch of stale and/or
2652         busted logic.
2653
2654         * Scripts/webkitpy/layout_tests/port/base.py:
2655         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2656         * Scripts/webkitpy/layout_tests/port/chromium.py:
2657         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2658         * Scripts/webkitpy/layout_tests/port/driver.py:
2659         (is_http_test):
2660         (test_to_uri):
2661         (uri_to_test):
2662         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2663         (run_one_test):
2664         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2665         (MockDRTTest.input_line):
2666         (input_line):
2667         (expected_output):
2668         * Scripts/webkitpy/layout_tests/port/test.py:
2669         * Scripts/webkitpy/layout_tests/port/webkit.py:
2670         (_command_from_driver_input):
2671
2672 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
2673
2674         Mitigate scrollbar differences when running pixel tests
2675         https://bugs.webkit.org/show_bug.cgi?id=67217
2676
2677         Reviewed by Dan Bernstein.
2678         
2679         Add an NSScroller subclass that draws mock scrollbars identically
2680         to the WebCore mock scrollbar theme, and register it with the
2681         WebDynamicScrollbarsView.
2682
2683         * DumpRenderTree/mac/DumpRenderTree.mm:
2684         (-[DRTMockScroller rectForPart:]):
2685         (-[DRTMockScroller drawKnob]):
2686         (-[DRTMockScroller drawRect:]):
2687         (registerMockScrollbars):
2688         (prepareConsistentTestingEnvironment):
2689
2690 2012-01-05  Jon Lee  <jonlee@apple.com>
2691
2692         Update DRT on Mac to draw resize handles on text areas.
2693
2694         Reviewed by John Sullivan.
2695
2696         Enable resize handles on text areas so that we don't have to create two different sets of pixel test results,
2697         between WK1 and WK2. This will require rebaselining existing textarea pixel tests.
2698
2699         * DumpRenderTree/mac/DumpRenderTree.mm:
2700         (resetDefaultsToConsistentValues):
2701
2702 2012-01-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2703
2704         [Qt] Move listing of include paths and libs to pri files in sources
2705
2706         Includepaths are sometimes modified by non-Qt contributors so keeping
2707         them in files inside Sources makes it more likely that they are updated
2708         along with project files for the other ports.
2709
2710         Using pri files instead of prf files for this also has the benefit that
2711         the include() from the main target file can be parsed and followed by
2712         Qt Creator -- something that does not work with load().
2713
2714         Dependency from a target to a library through the WEBKIT variable are
2715         handled through forwarding-files in Tools/qmake/mkspecs/modules, which
2716         set the source root of the module and include the right pri file.
2717
2718         Ideally we'd use the variant of include() that takes an optional
2719         namespace to read the variables into, or the fromfile() function,
2720         but both of these add an overhead of about 40% on the total qmake
2721         runtime, due to making a deep copy of all the variables in the
2722         project or re-reading all the prf files from scratch.
2723
2724         Reviewed by Simon Hausmann.
2725         Reviewed by Ossy.
2726
2727         * qmake/mkspecs/features/default_post.prf:
2728         * qmake/mkspecs/modules/javascriptcore.prf: Added.
2729         * qmake/mkspecs/modules/webcore.prf: Added.
2730         * qmake/mkspecs/modules/webkit2.prf: Added.
2731         * qmake/mkspecs/modules/wtf.prf: Added.
2732
2733 2012-01-06  JungJik Lee  <jungjik.lee@samsung.com>
2734
2735         [EFL] Add pre-render handling code in EWebLauncher.
2736         https://bugs.webkit.org/show_bug.cgi?id=73430
2737
2738         Reviewed by Zoltan Herczeg.
2739
2740         Add pre-render handling code by pressing Insert key.
2741
2742         * EWebLauncher/main.c:
2743         (on_key_down):
2744
2745 2012-01-06  Csaba Osztrogonác  <ossy@webkit.org>
2746
2747         NRWT should use test_expectation.txt on wk2 platforms
2748         https://bugs.webkit.org/show_bug.cgi?id=75417
2749
2750         Reviewed by Dirk Pranke.
2751
2752         * Scripts/webkitpy/layout_tests/port/webkit.py:
2753         (path_to_test_expectations_file):
2754         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2755         (test_path_to_test_expectations_file):
2756
2757 2012-01-05  Jochen Eisinger  <jochen@chromium.org>
2758
2759         Don't hardcode expected file URIs in as they depend on the platform
2760         https://bugs.webkit.org/show_bug.cgi?id=75666
2761
2762         Reviewed by Dirk Pranke.
2763
2764         * Scripts/webkitpy/layout_tests/port/win.py:
2765         (WinPort.show_results_html_file):
2766         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2767         (MainTest.test_unexpected_failures):
2768         (MainTest.test_results_directory_default):
2769         (MainTest.test_results_directory_relative):
2770
2771 2012-01-05  Anders Carlsson  <andersca@apple.com>
2772
2773         Crash when trying to invalidate the NPRuntimeObjectMap for a plug-in in a subframe
2774         https://bugs.webkit.org/show_bug.cgi?id=75667
2775         <rdar://problem/10389454>
2776
2777         Reviewed by Kevin Decker.
2778
2779         Add an evaluate method to the plug-in test scriptable object that can be used to evaluate a given JS string.
2780
2781         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2782         (PluginTest::executeScript):
2783         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2784         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp:
2785         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasMethod):
2786         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::invoke):
2787         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasProperty):
2788
2789 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
2790
2791         webkitpy: clean up port factory methods
2792         https://bugs.webkit.org/show_bug.cgi?id=75590
2793
2794         Reviewed by Eric Seidel.
2795
2796         This change consolidates much of the "factory method" logic
2797         of determining which port objects to create for a given set
2798         of configurations by merging the separate factory methods in
2799         chromium_gpu and google_chrome into PortFactory so that at least
2800         all of the logic is in one place.
2801
2802         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2803         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2804         * Scripts/webkitpy/layout_tests/port/factory.py:
2805         (_port_name_from_arguments_and_options):
2806         (get):
2807         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2808         (test_google_chrome):
2809         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2810         (GoogleChromeLinux32Port):
2811         (GoogleChromeLinux32Port.baseline_search_path):
2812         (test_expectations_overrides):
2813         (architecture):
2814         (GoogleChromeLinux64Port):
2815         (GoogleChromeLinux64Port.baseline_search_path):
2816         (GoogleChromeMacPort):
2817         (GoogleChromeMacPort.baseline_search_path):
2818         (GoogleChromeWinPort):
2819         (GoogleChromeWinPort.baseline_search_path):
2820         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2821         (_verify_baseline_path):
2822
2823 2012-01-05  Jochen Eisinger  <jochen@chromium.org>
2824
2825         Replace webkitpy.common.system.filesystem.file_path_as_url with webkitpy.common.system.path.abspath_to_uri
2826         https://bugs.webkit.org/show_bug.cgi?id=75617
2827
2828         Reviewed by Dirk Pranke.
2829
2830         * Scripts/webkitpy/common/system/filesystem.py:
2831         (FileSystem.exists):
2832         * Scripts/webkitpy/common/system/filesystem_mock.py:
2833         (MockFileSystem.exists):
2834         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2835         (GenericFileSystemTests.teardown_generic_test_dir):
2836         * Scripts/webkitpy/layout_tests/port/base.py:
2837         (Port.to.show_results_html_file):
2838         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2839         (MainTest.test_results_directory_absolute):
2840
2841 2012-01-05  Adam Roben  <aroben@apple.com>
2842
2843         Remove some unnecessary code from old-run-webkit-tests
2844
2845         Thanks to r104187/r104188, we no longer need to set PATH before launching DumpRenderTree or
2846         WebKitTestRunner.
2847
2848         Fixes <http://webkit.org/b/75640> ORWT unnecessarily sets PATH before launching DRT/WTR on
2849         Windows
2850
2851         Reviewed by Eric Seidel.
2852
2853         * Scripts/old-run-webkit-tests:
2854         (top level):
2855         (openDumpTool):
2856         Removed calls to setPathForRunningWebKitApp.
2857
2858 2012-01-05  Adam Roben  <aroben@apple.com>
2859
2860         Teach NRWT to use run-safari to open results.html on Apple's Windows port
2861
2862         NRWT was trying to use User.open_url, which doesn't work on Cygwin. But run-safari is
2863         better, since we always want to open results.html using the user's build of WebKit, not
2864         whatever their default browser is.
2865
2866         Fixes <http://webkit.org/b/75629> <rdar://problem/10648621> NRWT fails to open results.html
2867         for Apple's Windows port
2868
2869         Reviewed by Eric Seidel.
2870
2871         * Scripts/webkitpy/layout_tests/port/win.py:
2872         (WinPort.show_results_html_file): Changed to use run_safari, like MacPort does. Also removed
2873         an obsolete comment.
2874
2875         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2876         (WinPortTest.test_show_results_html_file): Updated expected results.
2877
2878 2012-01-05  Adam Roben  <aroben@apple.com>
2879
2880         Prepend Safari.exe's path to the command-line passed to CreateProcess
2881
2882         Safari expects the first argument in the command-line to be the path to Safari.exe itself.
2883         This is how things get set up when Safari is launched normally (e.g., by Explorer). Safari
2884         thus ignores the first argument when looking for command-line arguments. WebKitLauncherWin
2885         was not including the path to Safari.exe in the command-line, so Safari was ignoring the
2886         first argument that WebKitLauncherWin was trying to pass to it.
2887
2888         Fixes <http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by Safari
2889
2890         Reviewed by Steve Falkenburg.
2891
2892         * WebKitLauncherWin/WebKitLauncherWin.cpp:
2893         (_tWinMain): Construct a command-line for CreateProcess that first contains a double-quoted
2894         path to Safari.exe, then contains any arguments that were passed to WebKitLauncherWin.
2895
2896 2012-01-05  Adam Roben  <aroben@apple.com>
2897
2898         Stop using explicit memory management in WebKitLauncherWin
2899
2900         We now use stack-allocated STL objects instead.
2901
2902         Prep work for <http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by
2903         Safari
2904
2905         Reviewed by Steve Falkenburg.
2906
2907         * WebKitLauncherWin/WebKitLauncherWin.cpp:
2908         (getStringValue):
2909         (applePathFromRegistry):
2910         (safariInstallDir):
2911         (safariBrowserExe):
2912         (_tWinMain):
2913         Changed to use stack-allocated STL objects instead of malloc/free.
2914
2915 2012-01-05  Adam Roben  <aroben@apple.com>
2916
2917         Turn WebKitTestRunner into a stub .exe launcher and a .dll that contains all the real code
2918
2919         This allows us to add the Safari and Apple Application Support directories to PATH before
2920         trying to load WebKit so that SafariTheme.dll, CoreGraphics.dll and friends can be found.
2921
2922         Fixes <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
2923         Windows port of DumpRenderTree/WebKitTestRunner
2924
2925         Reviewed by Steve Falkenburg.
2926
2927         * WebKitTestRunner/WebKitTestRunner.sln: Added WebKitTestRunnerLauncher and
2928         ImageDiffLauncher, which I forgot to add to this .sln when that project was created.
2929
2930         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2931         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2932         Changed to build WebKitTestRunner.dll instead of WebKitTestRunner.exe.
2933
2934         * WebKitTestRunner/win/WebKitTestRunnerLauncher.vcproj: Copied from
2935         Tools/WebKitTestRunner/win/WebKitTestRunner.vcproj but changed to build
2936         the stub launcher.
2937
2938         * WebKitTestRunner/win/WebKitTestRunnerLauncherCommon.vsprops: Added.
2939         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebug.vsprops: Added.
2940         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugAll.vsprops: Added.
2941         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops: Added.
2942         * WebKitTestRunner/win/WebKitTestRunnerLauncherProduction.vsprops: Added.
2943         * WebKitTestRunner/win/WebKitTestRunnerLauncherRelease.vsprops: Added.
2944         * WebKitTestRunner/win/WebKitTestRunnerLauncherReleaseCairoCFLite.vsprops: Added.
2945
2946         * WebKitTestRunner/win/main.cpp:
2947         (dllLauncherEntryPoint): Renamed from main. This is what the stub launcher calls.
2948
2949 2012-01-05  Adam Roben  <aroben@apple.com>
2950
2951         Turn DumpRenderTree into a stub .exe launcher and a .dll that contains all the real code
2952
2953         This allows us to add the Safari and Apple Application Support directories to PATH before
2954         trying to load WebKit so that SafariTheme.dll, CoreGraphics.dll and friends can be found.
2955
2956         Part of <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
2957         Windows port of DumpRenderTree/WebKitTestRunner
2958
2959         Reviewed by Steve Falkenburg.
2960
2961         * DumpRenderTree/DumpRenderTree.sln: Added DumpRenderTreeLauncher and ImageDiffLauncher,
2962         which I forgot to add to this .sln when that project was created.
2963
2964         * DumpRenderTree/win/DumpRenderTree.cpp:
2965         (dllLauncherEntryPoint): Renamed from main. This is what the stub launcher calls.
2966
2967         * DumpRenderTree/win/DumpRenderTree.vcproj:
2968         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2969         Changed to build DumpRenderTree.dll instead of DumpRenderTree.exe.
2970
2971         * DumpRenderTree/win/DumpRenderTreeLauncher.vcproj: Added.
2972         * DumpRenderTree/win/DumpRenderTreeLauncherCommon.vsprops: Added.
2973         * DumpRenderTree/win/DumpRenderTreeLauncherDebug.vsprops: Added.
2974         * DumpRenderTree/win/DumpRenderTreeLauncherDebugAll.vsprops: Added.
2975         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops: Added.
2976         * DumpRenderTree/win/DumpRenderTreeLauncherProduction.vsprops: Added.
2977         * DumpRenderTree/win/DumpRenderTreeLauncherRelease.vsprops: Added.
2978         * DumpRenderTree/win/DumpRenderTreeLauncherReleaseCairoCFLite.vsprops: Added.
2979
2980         * win/DLLLauncher/DLLLauncherMain.cpp:
2981         (modifyPath): Moved code to modify PATH here from main/wWinMain. Changed to also prepend
2982         Safari's directory to PATH so that SafariTheme.dll can be found.
2983
2984         (main):
2985         (wWinMain):
2986         Changed to use the new modifyPath function.
2987
2988 2012-01-05  Alexander Færøy  <alexander.faeroy@nokia.com>
2989
2990         [Qt] Never enable FontConfig on Mac OS X
2991         https://bugs.webkit.org/show_bug.cgi?id=75616
2992
2993         Reviewed by Tor Arne Vestbø.
2994
2995         * qmake/mkspecs/features/features.prf:
2996
2997 2012-01-05  Alpha Lam  <hclam@chromium.org>
2998
2999         Unreviewed, rolling out r104159.
3000         http://trac.webkit.org/changeset/104159
3001         https://bugs.webkit.org/show_bug.cgi?id=75590
3002
3003         Chromium port GPU tests cannot be executed.
3004
3005         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3006         (get):
3007         (_default_tests_paths):
3008         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3009         (ChromiumGpuTest.assert_port_works):
3010         * Scripts/webkitpy/layout_tests/port/factory.py:
3011         (PortFactory._port_name_from_arguments_and_options):
3012         (PortFactory):
3013         (PortFactory._get_kwargs):
3014         (PortFactory.get):
3015         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3016         (FactoryTest.test_google_chrome.names):
3017         (FactoryTest.test_google_chrome):
3018         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3019         (GetGoogleChromePort):
3020         (GetGoogleChromePort.GoogleChromeLinux32Port):
3021         (GetGoogleChromePort.GoogleChromeLinux32Port.baseline_search_path):
3022         (GetGoogleChromePort.GoogleChromeLinux32Port.test_expectations_overrides):
3023         (GetGoogleChromePort.GoogleChromeLinux32Port.architecture):
3024         (GetGoogleChromePort.GoogleChromeLinux64Port):
3025         (GetGoogleChromePort.GoogleChromeLinux64Port.baseline_search_path):
3026         (GetGoogleChromePort.GoogleChromeLinux64Port.test_expectations_overrides):
3027         (GetGoogleChromePort.GoogleChromeLinux64Port.architecture):
3028         (GetGoogleChromePort.GoogleChromeMacPort):
3029         (GetGoogleChromePort.GoogleChromeMacPort.baseline_search_path):
3030         (GetGoogleChromePort.GoogleChromeMacPort.test_expectations_overrides):
3031         (GetGoogleChromePort.GoogleChromeWinPort):
3032         (GetGoogleChromePort.GoogleChromeWinPort.baseline_search_path):
3033         (GetGoogleChromePort.GoogleChromeWinPort.test_expectations_overrides):
3034         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3035         (GetGoogleChromePortTest._verify_baseline_path):
3036         (GetGoogleChromePortTest._verify_expectations_overrides):
3037
3038 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
3039
3040         webkitpy: clean up port factory methods
3041         https://bugs.webkit.org/show_bug.cgi?id=75590
3042
3043         Reviewed by Eric Seidel.
3044
3045         This change consolidates much of the "factory method" logic
3046         of determining which port objects to create for a given set
3047         of configurations by merging the separate factory methods in
3048         chromium_gpu and google_chrome into PortFactory so that at least
3049         all of the logic is in one place.
3050
3051         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3052         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3053         * Scripts/webkitpy/layout_tests/port/factory.py:
3054         (_port_name_from_arguments_and_options):
3055         (get):
3056         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3057         (test_google_chrome):
3058         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3059         (GoogleChromeLinux32Port):
3060         (GoogleChromeLinux32Port.baseline_search_path):
3061         (test_expectations_overrides):
3062         (architecture):
3063         (GoogleChromeLinux64Port):
3064         (GoogleChromeLinux64Port.baseline_search_path):
3065         (GoogleChromeMacPort):
3066         (GoogleChromeMacPort.baseline_search_path):
3067         (GoogleChromeWinPort):
3068         (GoogleChromeWinPort.baseline_search_path):
3069         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3070         (_verify_baseline_path):
3071
3072 2012-01-04  Adam Roben  <aroben@apple.com>
3073
3074         Turn ImageDiff into a stub .exe launcher and a .dll that contains all the real code
3075
3076         This allows us to add the Apple Application Support directory to PATH before trying to load
3077         WebKit so that CoreGraphics.dll and friends can be found.
3078
3079         Fixes <http://webkit.org/b/75572> ImageDiff.exe can't be run without first munging PATH
3080
3081         Reviewed by Anders Carlsson.
3082
3083         * DumpRenderTree/win/ImageDiff.vcproj:
3084         * DumpRenderTree/win/ImageDiffCommon.vsprops:
3085         Changed to build ImageDiff.dll instead of ImageDiff.exe.
3086
3087         * DumpRenderTree/win/ImageDiffLauncher.vcproj: Copied from
3088         Tools/DumpRenderTree/win/ImageDiff.vcproj but changed to build the stub launcher.
3089
3090         * DumpRenderTree/win/ImageDiffLauncherCommon.vsprops: Added.
3091         * DumpRenderTree/win/ImageDiffLauncherDebug.vsprops: Added.
3092         * DumpRenderTree/win/ImageDiffLauncherDebugAll.vsprops: Added.
3093         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops: Added.
3094         * DumpRenderTree/win/ImageDiffLauncherProduction.vsprops: Added.
3095         * DumpRenderTree/win/ImageDiffLauncherRelease.vsprops: Added.
3096         * DumpRenderTree/win/ImageDiffLauncherReleaseCairoCFLite.vsprops: Added.
3097
3098         * DumpRenderTree/win/ImageDiffWin.cpp: Added.
3099         (dllLauncherEntryPoint): This function is called by the stub launcher and just calls through
3100         to main.
3101
3102         * win/DLLLauncher/DLLLauncherMain.cpp:
3103         (main):
3104         (wWinMain):
3105         Added support for launching console programs. When USE_CONSOLE_ENTRY_POINT is defined, the
3106         stub launcher acts as a console program and calls a console version of
3107         dllLauncherEntryPoint.
3108
3109 2012-01-04  Adam Roben  <aroben@apple.com>
3110
3111         Turn MiniBrowser into a stub .exe launcher and a .dll that contains all the real code
3112
3113         This allows us to add the Apple Application Support directory to PATH before trying to load
3114         WebKit so that CoreGraphics.dll and friends can be found.
3115
3116         Fixes <http://webkit.org/b/68576> <rdar://problem/10163853> MiniBrowser fails to launch when
3117         double-clicked
3118
3119         Reviewed by Anders Carlsson.
3120
3121         * MiniBrowser/MiniBrowser.vcproj:
3122         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
3123         Changed to build MiniBrowser.dll instead of MiniBrowser.exe.
3124
3125         * MiniBrowser/Configurations/MiniBrowserLauncherCommon.vsprops: Added.
3126         * MiniBrowser/Configurations/MiniBrowserLauncherDebug.vsprops: Added.
3127         * MiniBrowser/Configurations/MiniBrowserLauncherDebugAll.vsprops: Added.
3128         * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops: Added.
3129         * MiniBrowser/Configurations/MiniBrowserLauncherProduction.vsprops: Added.
3130         * MiniBrowser/Configurations/MiniBrowserLauncherRelease.vsprops: Added.
3131         * MiniBrowser/Configurations/MiniBrowserLauncherReleaseCairoCFLite.vsprops: Added.
3132
3133         * MiniBrowser/MiniBrowserLauncher.vcproj: Copied from Tools/MiniBrowser/MiniBrowser.vcproj
3134         but changed to build the stub launcher.
3135
3136         * MiniBrowser/win/main.cpp: Moved the /manifestdependency code to DLLLauncherMain.cpp, since
3137         it needs to be compiled into the .exe instead of the .dll.
3138         (DllMain): Added. We use this to store the DLL's HINSTANCE.
3139         (dllLauncherEntryPoint): Renamed from _tWinMain. This is what gets called by the
3140         DLLLauncherMain code.
3141
3142         * win/DLLLauncher/DLLLauncherMain.cpp: Moved the /manifestdependency code from MiniBrowser
3143         to here.
3144
3145 2012-01-04  Adam Roben  <aroben@apple.com>
3146
3147         Make WinLauncher's window frame respond to clicks/drags again
3148
3149         Fixes <http://webkit.org/b/75562> REGRESSION (r84990): Can't drag WinLauncher by its title
3150         bar when Aero is disabled
3151
3152         Reviewed by Brent Fulgham.
3153
3154         * WinLauncher/WinLauncher.cpp:
3155         (WndProc): Always call up to our parent wndproc when we don't handle WM_NCHITTEST ourselves.
3156         Also removed an unnecessary "break" keyword.
3157
3158 2012-01-04  Adam Roben  <aroben@apple.com>
3159
3160         Turn WinLauncher into a stub .exe launcher and a .dll that contains all the real code
3161
3162         This allows us to add the Apple Application Support directory to PATH before trying to load
3163         WebKit so that CoreGraphics.dll and friends can be found. Eventually all our WebKit apps
3164         should use this mechanism.
3165
3166         Fixes <http://webkit.org/b/68578> <rdar://problem/10163861> WinLauncher fails to launch when
3167         double-clicked
3168
3169         Reviewed by Anders Carlsson.
3170
3171         * WinLauncher/WinLauncher.cpp: Removed InitInstance.
3172         (DllMain): Added. Stores the DLL HINSTANCE in the global hInst variable. This used to be
3173         done by the now-removed InitInstance function.
3174         (dllLauncherEntryPoint): Renamed from _tWinMain. This is the function that our stub launcher
3175         calls. Merged code from InitInstance into this function, and change to use the global hInst
3176         variable, which corresponds to WinLauncher.dll, rather than the HINSTANCE passed into this
3177         function, which corresponds to WinLauncher.exe.
3178
3179         * WinLauncher/WinLauncher.vcproj:
3180         * WinLauncher/WinLauncherCommon.vsprops:
3181         Changed to build WinLauncher.dll instead of WinLauncher.exe.
3182
3183         * WinLauncher/WinLauncherLauncher.rc: Added.
3184         * WinLauncher/WinLauncherLauncherResource.h: Added.
3185         This just references the WinLauncher.ico file to set the application icon (though it looks
3186         like that's a default icon).
3187
3188         * WinLauncher/WinLauncherLauncher.vcproj: Copied from Tools/WinLauncher/WinLauncher.vcproj
3189         but changed to build WinLauncher.exe using the new DLLLauncherMain.cpp file.
3190
3191         * WinLauncher/WinLauncherLauncherCommon.vsprops: Added.
3192         * WinLauncher/WinLauncherLauncherDebug.vsprops: Added.
3193         * WinLauncher/WinLauncherLauncherDebugAll.vsprops: Added.
3194         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops: Added.
3195         * WinLauncher/WinLauncherLauncherProduction.vsprops: Added.
3196         * WinLauncher/WinLauncherLauncherRelease.vsprops: Added.
3197         * WinLauncher/WinLauncherLauncherReleaseCairoCFLite.vsprops: Added.
3198
3199         * win/DLLLauncher/DLLLauncherMain.cpp: Added.
3200         (enableTerminationOnHeapCorruption): Uses HeapSetInformation to tell Windows to kill the
3201         program if it detects heap corruption.
3202         (getStringValue): Helper function to read a string value from the registry.
3203         (applePathFromRegistry): Helper function to read the InstallDir for a given Apple
3204         application from the registry.
3205         (appleApplicationSupportDirectory): Helper function to return the path to the Apple
3206         Application Support directory.
3207         (copyEnvironmentVariable): Helper function to copy an environment variable's value.
3208         (prependPath): Helper function to prepend a directory to the PATH.
3209         (fatalError): Helper function to display an error to the user.
3210         (wWinMain): Add Apple Application Support to the PATH, then load our DLL and call its
3211         dllLauncherEntryPoint function.
3212
3213 2012-01-05  Kentaro Hara  <haraken@chromium.org>
3214
3215         prepare-ChangeLog cannot parse python code that nests classes and defs
3216         https://bugs.webkit.org/show_bug.cgi?id=75524
3217
3218         Reviewed by Ryosuke Niwa.
3219
3220         This patch fixes the python parser of prepare-ChangeLog so that it can parse
3221         python code that nests classes and defs, like this:
3222
3223         class C:
3224             pass
3225             def f():
3226                 pass
3227             pass
3228
3229         Also, this patch fixes the python parser so that it inserts a dummy line
3230         at the end of the file to pop out all popped scopes.
3231
3232         * Scripts/prepare-ChangeLog:
3233         (get_function_line_ranges_for_python):
3234
3235         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py:
3236         Added test cases that nest classes and defs.
3237         (func7):
3238         (func7.func8):
3239         (func7.func8.func9):
3240         (Class2):
3241         (Class2.Class3):
3242         (Class2.Class3.Class4):
3243         (Class5):
3244         (Class5.func10):
3245         (Class5.func11):
3246         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt:
3247
3248 2012-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3249
3250         [GTK] Rename webkit_web_view_load_alternate_html as webkit_web_view_replace_content in WebKit2 GTK+
3251         https://bugs.webkit.org/show_bug.cgi?id=75433
3252
3253         Reviewed by Martin Robinson.
3254
3255         * MiniBrowser/gtk/BrowserWindow.c:
3256         (webViewLoadFailed): Reset the progress bar when load fails.
3257         (browserWindowConstructed): Connect to load-failed signal.
3258
3259 2012-01-04  Dan Bernstein  <mitz@apple.com>
3260
3261         Add a --target-web-process option to the debug-* scripts. When specified, the scripts will
3262         start WebProcess under gdb and WebProcess will then run the client executable.
3263
3264         This is the Tools part of fixing <http://webkit.org/b/75444> Debugging WebProcess requires running a UI process first and waiting to attach
3265
3266         Reviewed by Anders Carlsson.
3267
3268         * Scripts/webkitdirs.pm:
3269         (shouldTargetWebProcess): Added.
3270         (determineShouldTargetWebProcess): Added. Checks for --target-web-process.
3271         (execMacWebKitAppForDebugging): Changed to target gdb at WebProcess and pass the path to the
3272         app using the -client-executable option if targeting the web process.
3273
3274 2012-01-04  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
3275
3276         Adding myself to committers list.
3277
3278         Unreviewed.
3279
3280         * Scripts/webkitpy/common/config/committers.py:
3281
3282 2012-01-04  David Kilzer  <ddkilzer@apple.com>
3283
3284         Revert fix for Bug 75064: TestWebKitAPI: initialize the main thread before running tests
3285
3286         This reverts commit r103546.
3287
3288         * TestWebKitAPI/TestsController.cpp:
3289         (TestWebKitAPI::TestsController::TestsController):
3290
3291 2012-01-04  James Robinson  <jamesr@chromium.org>
3292
3293         [chromium] Move WebMimeRegistry and dependencies to Source/Platform
3294         https://bugs.webkit.org/show_bug.cgi?id=74583
3295
3296         Reviewed by Darin Fisher.
3297
3298         Teaches the WEBKIT_EXPORT check about the chromium WebKit platform API header location.
3299
3300         * Scripts/webkitpy/style/checkers/cpp.py:
3301         (check_function_definition):
3302
3303 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3304
3305         [Qt] Fix link order of static libraries and unbreak QtWin32
3306
3307         We were keeping the correct static link order between the intermediate
3308         WebKit libraries, but not the internal dependencies for each of those
3309         libraries. The load() will in some instances mess with LIBS, so we need
3310         to ensure that the dependent libraries are added after the library we
3311         are linking against.
3312
3313         Reviewed by Simon Hausmann.
3314
3315         * qmake/mkspecs/features/default_post.prf:
3316
3317 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3318
3319         [Qt] Introduce new qmake variable 'WEBKIT' for signaling dependencies
3320
3321         The custom qmake variable 'WEBKIT' is used for signaling that a
3322         target depends in some way on other subproject of the WebKit
3323         project. For now this is limited to the set of intermediate
3324         libraries: wtf, javascriptcore, webcore, and webkit2.
3325
3326         This replaces the previous convension of using load(foo) for
3327         just include paths, and CONFIG += foo to also link against foo.
3328
3329         Adding a dependency results in additional include paths being
3330         available, and potentially linking to the library. This is
3331         decided by the build system based on conditions such as what
3332         kind of target is being built and the general build config.
3333
3334         An advantage to his approach is that it simplifies the individual
3335         foo.prf files, for example by allowing us to use INCLUDEPATH +=
3336         and LIBS += as normal instead of prepending.
3337
3338         Reviewed by Simon Hausmann.
3339
3340         * DumpRenderTree/qt/DumpRenderTree.pro:
3341         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3342         * QtTestBrowser/QtTestBrowser.pro:
3343         * WebKitTestRunner/InjectedBundle/Target.pri:
3344         * WebKitTestRunner/Target.pri:
3345         * qmake/README:
3346         * qmake/mkspecs/features/default_post.prf:
3347         * qmake/mkspecs/features/functions.prf:
3348         * qmake/mkspecs/features/javascriptcore.prf:
3349         * qmake/mkspecs/features/qtwebkit.prf:
3350         * qmake/mkspecs/features/webcore.prf:
3351         * qmake/mkspecs/features/webkit2.prf:
3352         * qmake/mkspecs/features/wtf.prf:
3353
3354 2012-01-04  Alexander Færøy  <ahf@0x90.dk>
3355
3356         [Qt] Add UI for JavaScript Prompt dialog in the Qt MiniBrowser
3357         https://bugs.webkit.org/show_bug.cgi?id=75488
3358
3359         Reviewed by Tor Arne Vestbø.
3360
3361         * MiniBrowser/qt/MiniBrowser.qrc:
3362         * MiniBrowser/qt/qml/BrowserWindow.qml:
3363         * MiniBrowser/qt/qml/Dialog.qml:
3364         * MiniBrowser/qt/qml/DialogLineInput.qml: Copied from Tools/MiniBrowser/qt/qml/Dialog.qml.
3365         * MiniBrowser/qt/qml/PromptDialog.qml: Copied from Tools/MiniBrowser/qt/qml/Dialog.qml.
3366
3367 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3368
3369         [Qt] Use rpath for WTR's InjectedBundle to pick up the right QtWebKit
3370
3371         It wasn't really a problem at runtime since the right QtWebKit was
3372         already loaded as a dependency of the web process, but the ldd output
3373         would still be busted.
3374
3375         Reviewed by Simon Hausmann.
3376
3377         * WebKitTestRunner/InjectedBundle/Target.pri:
3378
3379 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3380
3381         [Qt] Move use of $$qtLibraryTarget() to a single place
3382
3383         Reviewed by Kenneth Rohde Christiansen.
3384
3385         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3386         * WebKitTestRunner/InjectedBundle/Target.pri:
3387         * qmake/mkspecs/features/default_post.prf:
3388         * qmake/mkspecs/features/webcore.prf:
3389
3390 2012-01-04  Mary Wu  <mary.wu@torchmobile.com.cn>
3391
3392         Enable DOWNLOAD_ATTRIBUTE in BlackBerry porting
3393         https://bugs.webkit.org/show_bug.cgi?id=75238
3394
3395         Reviewed by Antonio Gomes.
3396
3397         Add ENABLE_DOWNLOAD_ATTRIBUTE webkit feature into the build script so that 
3398         it could initiate download directly if it has the download attribute in the link 
3399         and doesn't need to open new blank page for the target="_blank". Enabling this 
3400         feature in the BlackBerry porting also prepares for later blob feature implementation.
3401
3402         * Scripts/build-webkit: Modified to handle ENABLE_DOWNLOAD_ATTRIBUTE. Make it default on
3403         for the BlackBerry porting.
3404
3405 2012-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3406
3407         [GTK] Fix a runtime warning when hovering hyperlink auditing setting in MiniBroweser settings dialog
3408         https://bugs.webkit.org/show_bug.cgi?id=75475
3409
3410         Reviewed by Martin Robinson.
3411
3412         The problem is that the property blurb contains <a ping> and tree
3413         view uses gtk_tooltip_set_markup() internally, so we need to
3414         escape the text.
3415
3416         * MiniBrowser/gtk/BrowserSettingsDialog.c:
3417         (browserSettingsDialogConstructed): Escape property blurb before
3418         storing it in the GtkTreeModel.
3419
3420 2012-01-03  Jochen Eisinger  <jochen@chromium.org>
3421
3422         When showing results.html pass a correct URL to webbrowser.open
3423         https://bugs.webkit.org/show_bug.cgi?id=75438
3424
3425         Reviewed by Adam Barth.
3426
3427         * Scripts/webkitpy/common/system/filesystem.py:
3428         (file_path_as_url):
3429         * Scripts/webkitpy/common/system/filesystem_mock.py:
3430         (file_path_as_url):
3431         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3432         (test_file_path_as_url):
3433         * Scripts/webkitpy/layout_tests/port/base.py:
3434         (show_results_html_file):
3435         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3436         (test_show_results_html_file):
3437         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3438         (test_results_directory_relative):
3439
3440 2012-01-03  Ojan Vafai  <ojan@chromium.org>
3441
3442         shrink the header on the flakiness dashboard
3443         https://bugs.webkit.org/show_bug.cgi?id=65153
3444
3445         Reviewed by Adam Roben.
3446
3447         Move some of the "show" links to be to the right of the header
3448         instead of below the header when they content they're showing
3449         is hidden. That way we don't waste vertical space on them.
3450
3451         No new tests. This code is covered by existing tests.
3452
3453         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3454
3455 2012-01-03  Ryosuke Niwa  <rniwa@webkit.org>
3456
3457         Add a tool to analyze change logs
3458         https://bugs.webkit.org/show_bug.cgi?id=72243
3459
3460         Reviewed by Eric Seidel.
3461
3462         Add the initial implementation of analyze-changelog command. This version supports parsing multiple changelogs
3463         in a single directory and summarizes the result in json files. It also copies summary.html to the output directory
3464         for visualizing json files.
3465
3466         Usage: webkit-patch analyze-changelog [--changelog-count N] <CHANGELOG_DIR> <OUTPUT_DIR>
3467         where CHANGELOG_DIR is the directory to look for changelogs, OUTPUT_DIR is the directory into which the tool
3468         generates json files, and N is the number of changelogs to parse.
3469
3470         * Scripts/webkitpy/common/config/contributionareas.py: Added names().
3471         * Scripts/webkitpy/common/system/filesystem_mock.py: Added readline and iterator support to ReadableTextFileObject.
3472         * Scripts/webkitpy/tool/commands/__init__.py:
3473         * Scripts/webkitpy/tool/commands/analyzechangelog.py: Added.
3474         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py: Added.
3475         * Scripts/webkitpy/tool/commands/data/summary.html: Added.
3476         * Scripts/webkitpy/tool/steps/options.py:
3477
3478 2012-01-03  Ryosuke Niwa  <rniwa@webkit.org>
3479
3480         Add a tool to analyze change logs
3481         https://bugs.webkit.org/show_bug.cgi?id=72243
3482
3483         Reviewed by Eric Seidel.
3484
3485         Add the initial implementation of analyze-changelog command. This version supports parsing multiple changelogs
3486         in a single directory and summarizes the result in json files. It also copies summary.html to the output directory
3487         for visualizing json files.
3488
3489         Usage: webkit-patch analyze-changelog [--changelog-count N] <CHANGELOG_DIR> <OUTPUT_DIR>
3490         where CHANGELOG_DIR is the directory to look for changelogs, OUTPUT_DIR is the directory into which the tool
3491         generates json files, and N is the number of changelogs to parse.
3492
3493         * Scripts/webkitpy/common/config/contributionareas.py: Added names().
3494         * Scripts/webkitpy/common/system/filesystem_mock.py: Added readline and iterator support to ReadableTextFileObject.
3495         * Scripts/webkitpy/tool/commands/__init__.py:
3496         * Scripts/webkitpy/tool/commands/analyzechangelog.py: Added.
3497         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py: Added.
3498         * Scripts/webkitpy/tool/commands/data/summary.html: Added.
3499         * Scripts/webkitpy/tool/steps/options.py:
3500
3501 2012-01-03  Adam Roben  <aroben@apple.com>
3502
3503         Make Port subclasses override the operating_system method rather than setting an attribute
3504
3505         Without this patch, any use of Port.operating_system() within a port's __init__ method would
3506         return the default value ("mac"). This was confusing the version-checking logic inside
3507         ApplePort.__init__ on Windows.
3508
3509         Fixes <http://webkit.org/b/75479> <rdar://problem/10637385> REGRESSION (r102161): NRWT
3510         crashes on launch on Windows 7 SP1
3511
3512         Reviewed by Eric Seidel.
3513
3514         * Scripts/webkitpy/layout_tests/port/apple.py:
3515         (ApplePort.__init__): Replaced uses of self._operating_system with self.operating_system().
3516
3517         * Scripts/webkitpy/layout_tests/port/base.py:
3518         (Port.__init__): Removed code that set the self._operating_system attribute. Subclasses
3519         should now override the operating_system method instead.
3520         (Port.operating_system): Changed to always return "mac". Subclasses should override to
3521         return something else.
3522
3523         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3524         (ChromiumLinuxPort.__init__):
3525         (ChromiumLinuxPort.operating_system):
3526         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3527         (ChromiumMacPort.__init__):
3528         (ChromiumMacPort.operating_system):
3529         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3530         (ChromiumWinPort.__init__):
3531         (ChromiumWinPort.operating_system):
3532         * Scripts/webkitpy/layout_tests/port/mac.py:
3533         (MacPort.__init__):
3534         (MacPort.operating_system):
3535         * Scripts/webkitpy/layout_tests/port/win.py:
3536         (WinPort.__init__):
3537         (WinPort.operating_system):
3538         Changed to override the operating_system method rather than setting the _operating_system
3539         attribute, since setting the attribute isn't sufficient for code inside __init__ methods.
3540
3541         * Scripts/webkitpy/layout_tests/port/qt.py:
3542         (QtPort.__init__):
3543         (QtPort._path_to_webcore_library):
3544         Changed to use self.operating_system() instead of self._operating_system, for consistency
3545         with other Port-related code.
3546
3547         (QtPort.operating_system): Added this override of Port.operating_system that returns the
3548         value we determined in our __init__ method.
3549
3550         * Scripts/webkitpy/layout_tests/port/test.py:
3551         (TestPort.operating_system): Added this override of Port.operating_system that returns the
3552         value we determined in our __init__ method.
3553
3554         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3555         (PortTest.test_operating_system):
3556         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3557         (ChromiumLinuxPortTest.test_operating_system):
3558         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3559         (ChromiumMacPortTest.test_operating_system):
3560         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3561         (ChromiumWinPortTest.test_operating_system):
3562         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3563         (MacPortTest.test_operating_system):
3564         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3565         (QtPortTest.test_operating_system):
3566         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3567         (WinPortTest.test_operating_system):
3568         Test that all ports return the expected operating system string.
3569
3570 2012-01-03  Mario Sanchez Prada  <msanchez@igalia.com>
3571
3572         [GTK] run-gtk-test should ignore files with names without a "test" or "Test" prefix
3573         https://bugs.webkit.org/show_bug.cgi?id=75474
3574
3575         Reviewed by Philippe Normand.
3576
3577         * Scripts/run-gtk-tests: Ignore files whose name does not start
3578         with a "test" (for WK1's API tests) or a "Test" prefix (for WK2).
3579
3580 2012-01-03  Alexander Færøy  <alexander.faeroy@nokia.com>
3581
3582         [Qt] Add UI for JavaScript Confirmation dialog in the Qt MiniBrowser
3583         https://bugs.webkit.org/show_bug.cgi?id=75472
3584
3585         Reviewed by Tor Arne Vestbø.
3586
3587         * MiniBrowser/qt/MiniBrowser.pro:
3588         * MiniBrowser/qt/MiniBrowser.qrc:
3589         * MiniBrowser/qt/qml/BrowserWindow.qml:
3590         * MiniBrowser/qt/qml/ConfirmDialog.qml: Added.
3591
3592 2012-01-03  Alexander Færøy  <alexander.faeroy@nokia.com>
3593
3594         [Qt] Add UI for JavaScript Alert dialog in the Qt MiniBrowser
3595         https://bugs.webkit.org/show_bug.cgi?id=75471
3596
3597         Reviewed by Tor Arne Vestbø.
3598
3599         Add simple UI for JavaScript Alert dialogs. This patch also adds a
3600         simple DialogButton QML type and a Dialog QML type which will be
3601         reusable for other JavaScript dialogs.
3602
3603         * MiniBrowser/qt/MiniBrowser.qrc:
3604         * MiniBrowser/qt/qml/AlertDialog.qml: Added.
3605         * MiniBrowser/qt/qml/BrowserWindow.qml:
3606         * MiniBrowser/qt/qml/Dialog.qml: Added.
3607         * MiniBrowser/qt/qml/DialogButton.qml: Added.
3608
3609 2012-01-03  Rafael Brandao  <rafael.lobo@openbossa.org>
3610
3611         [Qt][WK2] MiniBrowser doesn't show url bar
3612         https://bugs.webkit.org/show_bug.cgi?id=75470
3613
3614         Reviewed by Tor Arne Vestbø.
3615
3616         * MiniBrowser/qt/qml/BrowserWindow.qml: Remove clipping until it is fixed
3617         on QtDeclarative (QTBUG-23422).
3618
3619 2012-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3620
3621         [GTK] Simplify loader client WebKit2 GTK+ API
3622         https://bugs.webkit.org/show_bug.cgi?id=74605
3623
3624         Reviewed by Gustavo Noronha Silva.
3625
3626         * gtk/generate-gtkdoc: Ignore WebKitWebLoaderClient since it's now
3627         private API.
3628
3629 2012-01-03  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3630
3631         [Qt] Clean up detection of fontconfig
3632
3633         We decide in features.prf whether or not fontconfig is available, and
3634         set the HAVE_FONTCONFIG define accordingly. All leaf project files
3635         should use this define to decide whether or not to link against
3636         fontconfig, not do their own detection.
3637
3638         We don't need to add link_pkgconfig to CONFIG in each project file,
3639         as we selectivly enable that configuration in defaults_post when
3640         needed.
3641
3642         Reviewed by Ossy.
3643
3644         * DumpRenderTree/qt/DumpRenderTree.pro:
3645         * QtTestBrowser/QtTestBrowser.pro:
3646         * WebKitTestRunner/InjectedBundle/Target.pri:
3647         * qmake/mkspecs/features/unix/default_post.prf:
3648         * qmake/mkspecs/features/unix/default_pre.prf:
3649
3650 2012-01-03  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3651
3652         [Qt] Introduce qmake replace function for the active build config
3653
3654         Reviewed by Ossy.
3655
3656         * qmake/mkspecs/features/default_post.prf:
3657         * qmake/mkspecs/features/functions.prf:
3658
3659 2012-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3660
3661         [GTK] Use gdk_screen_get_monitor_workarea() when available for screenAvailableRect()