API test WTF.StaticStringImpl crashing in TestWebKitAPI::WTF_StaticStringImpl_Test...
[WebKit-https.git] / Tools / ChangeLog
1 2017-05-04  Mark Lam  <mark.lam@apple.com>
2
3         API test WTF.StaticStringImpl crashing in TestWebKitAPI::WTF_StaticStringImpl_Test::TestBody() + 3188
4         https://bugs.webkit.org/show_bug.cgi?id=171702
5
6         Reviewed by Filip Pizlo.
7
8         The test was supposed to use the MAKE_STATIC_STRING_IMPL macro.  I had previously
9         changed it to instantiate an automatic StaticStringImpl (i.e. stack allocated) to
10         confirm that the test will detect a regression.  Unfortunately, I forgot to
11         change it back to using MAKE_STATIC_STRING_IMPL before I landed the test.
12         This patch fixes that.
13
14         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
15         (TestWebKitAPI::neverDestroyedString):
16
17 2017-05-04  Ryan Haddad  <ryanhaddad@apple.com>
18
19         Disable failing API test WebKit2.ResizeWithHiddenContentDoesNotHang.
20         https://bugs.webkit.org/show_bug.cgi?id=170195
21
22         Unreviewed test gardening.
23
24         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
25         (TEST):
26
27 2017-05-04  Don Olmstead  <don.olmstead@am.sony.com>
28
29         [Win] Remove redundant macros that are set in the CMake config
30         https://bugs.webkit.org/show_bug.cgi?id=171571
31
32         Reviewed by Brent Fulgham.
33
34         * DumpRenderTree/config.h:
35         * MiniBrowser/win/stdafx.h:
36         * TestWebKitAPI/config.h:
37
38 2017-05-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
39
40         Add testRunner.display() to force displaying the web page for testing
41         https://bugs.webkit.org/show_bug.cgi?id=171694
42
43         Reviewed by Simon Fraser.
44
45         Unlike testRunner.displayAndTrackRepaints(), this new function forces 
46         drawing the web page but without track repaints.
47
48         * DumpRenderTree/TestRunner.cpp:
49         (displayCallback):
50         (TestRunner::staticFunctions):
51         * DumpRenderTree/TestRunner.h:
52         * DumpRenderTree/mac/TestRunnerMac.mm:
53         (TestRunner::display):
54         * DumpRenderTree/win/TestRunnerWin.cpp:
55         (TestRunner::display):
56         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
57         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
58         (WTR::TestRunner::display):
59         * WebKitTestRunner/InjectedBundle/TestRunner.h:
60
61 2017-05-04  Mark Lam  <mark.lam@apple.com>
62
63         NeverDestroyed<String>(ASCIILiteral(...)) is not thread safe.
64         https://bugs.webkit.org/show_bug.cgi?id=171586
65         <rdar://problem/31873190>
66
67         Reviewed by Yusuke Suzuki.
68
69         API test for exercising StaticStringImpl and the MAKE_STATIC_STRING_IMPL macro.
70
71         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
72         (TestWebKitAPI::neverDestroyedString):
73         (TestWebKitAPI::getNeverDestroyedStringAtStackDepth):
74         (TestWebKitAPI::TEST):
75
76 2017-05-04  Wenson Hsieh  <wenson_hsieh@apple.com>
77
78         [WK2] Add support for keeping the selection in a focused editable element when dragging begins
79         https://bugs.webkit.org/show_bug.cgi?id=171585
80         <rdar://problem/31544320>
81
82         Reviewed by Beth Dakin and Zalan Bujtas.
83
84         Adds 1 new unit test and tweaks existing tests to check that when first responder status is lost after beginning
85         a drag while editing, content is still moved (and not copied) when performing data interaction on a different
86         element. ContentEditableMoveParagraphs checks that content can be shifted within a single element via a move
87         operation rather than a copy.
88
89         See WebCore ChangeLog for more details.
90
91         Tests:  DataInteractionSimulator.ContentEditableToContentEditable
92                 DataInteractionSimulator.ContentEditableToTextarea
93                 DataInteractionSimulator.ContentEditableMoveParagraphs
94                 DataInteractionSimulator.TextAreaToInput
95
96         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
97         * TestWebKitAPI/Tests/WebKit2Cocoa/two-paragraph-contenteditable.html: Added.
98         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
99         (TestWebKitAPI::TEST):
100         * TestWebKitAPI/ios/DataInteractionSimulator.h:
101         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
102         (-[DataInteractionSimulator initWithWebView:]):
103         (-[DataInteractionSimulator dealloc]):
104         (-[DataInteractionSimulator _advanceProgress]):
105         (-[DataInteractionSimulator waitForInputSession]):
106         (-[DataInteractionSimulator _webView:focusShouldStartInputSession:]):
107         (-[DataInteractionSimulator _webView:didStartInputSession:]):
108
109 2017-05-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
110
111         Rename TestRunner.display() to TestRunner::displayAndTrackRepaints()
112         https://bugs.webkit.org/show_bug.cgi?id=171641
113
114         Reviewed by Simon Fraser.
115
116         The plan is to add back the TestRunner.display() which does the display
117         only without track repaints.
118
119         * DumpRenderTree/DumpRenderTree.h:
120         * DumpRenderTree/TestRunner.cpp:
121         (displayAndTrackRepaintsCallback):
122         (TestRunner::staticFunctions):
123         (displayCallback): Deleted.
124         (displayInvalidatedRegionCallback): Deleted.
125         * DumpRenderTree/TestRunner.h:
126         * DumpRenderTree/mac/DumpRenderTree.mm:
127         (displayWebView):
128         (displayAndTrackRepaintsWebView):
129         * DumpRenderTree/mac/TestRunnerMac.mm:
130         (TestRunner::displayAndTrackRepaints):
131         (TestRunner::display): Deleted.
132         * DumpRenderTree/win/TestRunnerWin.cpp:
133         (TestRunner::displayAndTrackRepaints):
134         (TestRunner::display): Deleted.
135         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
136         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
137         (WTR::TestRunner::displayAndTrackRepaints):
138         (WTR::TestRunner::display): Deleted.
139         * WebKitTestRunner/InjectedBundle/TestRunner.h:
140
141 2017-05-04  Brady Eidson  <beidson@apple.com>
142
143         [ios-simulator] API test WebKit2.WebsiteDataStoreCustomPaths is failing.
144         https://bugs.webkit.org/show_bug.cgi?id=171513
145
146         Unreviewed gardening.
147
148         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
149         (TEST): Skip the failing parts of the test on iOS for now.
150
151 2017-05-03  Jonathan Bedard  <jbedard@apple.com>
152
153         Make ImageDiff stand-alone
154         https://bugs.webkit.org/show_bug.cgi?id=168939
155
156         Reviewed by David Kilzer.
157
158         Create ImageDiff without dependencies on bmalloc and WTF so that it exists as a
159         stand-alone project. Note that this change does not eliminate the ImageDiff inside
160         the DumpRenderTree project.
161
162         * ImageDiff/ImageDiff.xcodeproj: Added.
163         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj: Added.
164         * ImageDiff/Makefile: Use ImageDiff project.
165         * ImageDiff/PlatformMac.cmake: Added.
166         * ImageDiff/PlatformWin.cmake: Added.
167         * ImageDiff/cg: Added.
168         * ImageDiff/cg/Configurations: Added.
169         * ImageDiff/cg/Configurations/Base.xcconfig: Copied from Tools/DumpRenderTree/mac/Configurations/Base.xcconfig.
170         * ImageDiff/cg/Configurations/DebugRelease.xcconfig: Copied from Tools/DumpRenderTree/mac/Configurations/DebugRelease.xcconfig.
171         * ImageDiff/cg/Configurations/ImageDiff.xcconfig: Copied from Tools/DumpRenderTree/mac/Configurations/ImageDiff.xcconfig.
172         * ImageDiff/cg/ImageDiff.cpp: Copied from Tools/DumpRenderTree/cg/ImageDiffCG.cpp.
173         (createImageFromStdin): Stop using RetainPtr.
174         (createDifferenceImage): Ditto.
175         (main): Ditto.
176         * Scripts/build-imagediff: Stop building WTF and bmalloc.
177
178 2017-05-04  Sam Weinig  <sam@webkit.org>
179
180         Remove support for legacy Notifications
181         https://bugs.webkit.org/show_bug.cgi?id=171487
182
183         Reviewed by Jon Lee.
184
185         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
186         (DRTDesktopNotificationPresenter::checkNotificationPermission):
187         * Scripts/webkitperl/FeatureList.pm:
188         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
189         Remove use and definition of ENABLE_LEGACY_NOTIFICATIONS.
190
191 2017-05-04  Andy Estes  <aestes@apple.com>
192
193         Give +testwebkitapi_configurationWithTestPlugInClassName: a shorter name
194         https://bugs.webkit.org/show_bug.cgi?id=171673
195
196         Reviewed by Dan Bernstein.
197
198         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm:
199         (TEST):
200         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
201         (TEST):
202         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
203         (TEST):
204         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
205         (TEST):
206         * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm:
207         (TEST):
208         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
209         (configurationWithContentFilterSettings):
210         (-[LazilyLoadPlatformFrameworksController init]):
211         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
212         (TEST):
213         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptions.mm:
214         (runTestWithWidth):
215         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorld.mm:
216         (TEST):
217         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
218         (TestWebKitAPI::TEST):
219         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
220         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
221         (+[WKWebViewConfiguration _test_configurationWithTestPlugInClassName:]):
222         (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Renamed to
223         +_test_configurationWithTestPlugInClassName:
224
225 2017-05-04  Eric Carlson  <eric.carlson@apple.com>
226
227         [MediaStream] Allow host application to enable/disable media capture
228         https://bugs.webkit.org/show_bug.cgi?id=171292
229         <rdar://problem/31821492>
230
231         Reviewed by Jer Noble.
232
233         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
234         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Added.
235         (-[UserMediaMessageHandler userContentController:didReceiveScriptMessage:]):
236         (-[UserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
237         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
238         (MediaCaptureDisabledTest::SetUp):
239         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
240         (TEST_F):
241         * TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Added.
242
243 2017-05-04  Caio Lima  <ticaiolima@gmail.com>
244
245         Unreviewed, Adding self to contributors.json
246
247         * Scripts/webkitpy/common/config/contributors.json: Added name.
248
249 2017-05-04  Konstantin Tokarev  <annulen@yandex.ru>
250
251         Fix compilation with ICU 59.1
252         https://bugs.webkit.org/show_bug.cgi?id=171612
253
254         Reviewed by Mark Lam.
255
256         ICU 59.1 has broken source compatibility. Now it defines UChar as
257         char16_t, which does not allow automatic type conversion from unsigned
258         short in C++ code.
259
260         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
261         (UIScriptContext::tryToCompleteUIScriptForCurrentParentCallback):
262
263 2017-05-04  Andy Estes  <aestes@apple.com>
264
265         [Cocoa] Add an optional width parameter to -[WKWebProcessPlugInNodeHandle renderedImageWithOptions:]
266         https://bugs.webkit.org/show_bug.cgi?id=171646
267         <rdar://problem/30306321>
268
269         Reviewed by Tim Horton.
270
271         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptions.mm:
272         (runTestWithWidth):
273         (TEST):
274         (-[RenderedImageWithOptionsObject didRenderImageWithSize:]): Deleted.
275         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptionsPlugIn.mm:
276         (-[RenderedImageWithOptionsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
277         (-[RenderedImageWithOptionsPlugIn webProcessPlugInBrowserContextController:didFinishLoadForFrame:]):
278         (-[RenderedImageWithOptionsPlugIn renderImageWithWidth:completionHandler:]):
279         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptionsProtocol.h:
280
281 2017-05-04  Adrian Perez de Castro  <aperez@igalia.com>
282
283         [GTK] Fontconfig 2.11.2 in JHBuild does not build with glibc 2.25+ or gperf 3.1+
284         https://bugs.webkit.org/show_bug.cgi?id=171649
285
286         Reviewed by Carlos Garcia Campos.
287
288         Add two patches picked from the upstream repository to fix building of
289         the Fontconfig module in JHBuild. Additionally, this needed a patch to
290         add "autogen.sh" as it is not included in release tarballs. Also:
291         building the module with srcdir!=builddir prevents "fcobjshash.gperf"
292         being regenerated (which is needed) so this is disabled for the
293         Fontconfig module.
294
295         * gtk/jhbuild.modules:
296         * gtk/patches/fontconfig-2.11.1-add-autogen.patch: Added.
297         * gtk/patches/fontconfig-Avoid-conflicts-with-integer-width-macros-from-TS-18661-1-2014.patch: Added.
298         * gtk/patches/fontconfig-Fix-the-build-issue-with-gperf-3.1.patch: Added.
299
300 2017-05-04  Commit Queue  <commit-queue@webkit.org>
301
302         Unreviewed, rolling out r216172.
303         https://bugs.webkit.org/show_bug.cgi?id=171654
304
305         FTBFS for iOS due to missing WebPageProxy::stopMediaCapture()
306         implementation. (Requested by ddkilzer on #webkit).
307
308         Reverted changeset:
309
310         "[MediaStream] Allow host application to enable/disable media
311         capture"
312         https://bugs.webkit.org/show_bug.cgi?id=171292
313         http://trac.webkit.org/changeset/216172
314
315 2017-05-04  Carlos Garcia Campos  <cgarcia@igalia.com>
316
317         [GTK] Bump GStreamer version to 1.10.4 in jhbuild
318         https://bugs.webkit.org/show_bug.cgi?id=171595
319
320         Reviewed by Xabier Rodriguez-Calvar.
321
322         * gtk/jhbuild.modules:
323         * gtk/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
324         * gtk/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
325         * gtk/patches/gst-plugins-good-0001-rtpbin-pipeline-gets-an-EOS-when-any-rtpsources-byes.patch: Removed.
326         * gtk/patches/gst-plugins-good-0002-rtpbin-avoid-generating-errors-when-rtcp-messages-ar.patch: Removed.
327         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
328         * gtk/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
329         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
330
331 2017-05-03  Saam Barati  <sbarati@apple.com>
332
333         How we build polymorphic cases is wrong when making a call from Wasm
334         https://bugs.webkit.org/show_bug.cgi?id=171527
335
336         Reviewed by JF Bastien.
337
338         * Scripts/run-jsc-stress-tests:
339
340 2017-05-03  Eric Carlson  <eric.carlson@apple.com>
341
342         [MediaStream] Allow host application to enable/disable media capture
343         https://bugs.webkit.org/show_bug.cgi?id=171292
344         <rdar://problem/31821492>
345
346         Reviewed by Jer Noble.
347
348         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
349         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Added.
350         (-[UserMediaMessageHandler userContentController:didReceiveScriptMessage:]):
351         (-[UserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
352         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
353         (MediaCaptureDisabledTest::SetUp):
354         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
355         (TEST_F):
356         * TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Added.
357
358 2017-05-03  John Wilander  <wilander@apple.com>
359
360         Resource Load Statistics: Remove all statistics for modifiedSince website data removals
361         https://bugs.webkit.org/show_bug.cgi?id=171584
362         <rdar://problem/24702576>
363
364         Reviewed by Brent Fulgham.
365
366         New function to call the clear function that takes a modifiedSince parameter.
367
368         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
369         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
370         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
371         * WebKitTestRunner/InjectedBundle/TestRunner.h:
372         * WebKitTestRunner/TestController.cpp:
373         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
374         * WebKitTestRunner/TestController.h:
375         * WebKitTestRunner/TestInvocation.cpp:
376         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
377
378 2017-05-03  Commit Queue  <commit-queue@webkit.org>
379
380         Unreviewed, rolling out r216160 and r216161.
381         https://bugs.webkit.org/show_bug.cgi?id=171640
382
383         These changes broke the iOS build. (Requested by mlewis13 on
384         #webkit).
385
386         Reverted changesets:
387
388         "[MediaStream] Allow host application to enable/disable media
389         capture"
390         https://bugs.webkit.org/show_bug.cgi?id=171292
391         http://trac.webkit.org/changeset/216160
392
393         "[MediaStream] Allow host application to enable/disable media
394         capture"
395         https://bugs.webkit.org/show_bug.cgi?id=171292
396         http://trac.webkit.org/changeset/216161
397
398 2017-05-03  Eric Carlson  <eric.carlson@apple.com>
399
400         [MediaStream] Allow host application to enable/disable media capture
401         https://bugs.webkit.org/show_bug.cgi?id=171292
402         <rdar://problem/31821492>
403
404         Reviewed by Jer Noble.
405
406         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
407         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Added.
408         (-[UserMediaMessageHandler userContentController:didReceiveScriptMessage:]):
409         (-[UserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
410         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
411         (MediaCaptureDisabledTest::SetUp):
412         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
413         (TEST_F):
414         * TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Added.
415
416 2017-04-26  Jiewen Tan  <jiewen_tan@apple.com>
417
418         [WebCrypto] Add an api test for testing wrapping/unwrapping serialized crypto keys
419         https://bugs.webkit.org/show_bug.cgi?id=171350
420         <rdar://problem/28600836>
421
422         Patched by Brady Eidson.
423
424         Reviewed by Brent Fulgham.
425
426         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
427         * TestWebKitAPI/Tests/WebKit2/NavigationClientDefaultCrypto.cpp: Added.
428         (TestWebKitAPI::runJavaScriptAlert):
429         (TestWebKitAPI::decidePolicyForNavigationAction):
430         (TestWebKitAPI::decidePolicyForNavigationResponse):
431         (TestWebKitAPI::TEST):
432         * TestWebKitAPI/Tests/WebKit2/navigation-client-default-crypto.html: Added.
433
434 2017-05-03  Simon Fraser  <simon.fraser@apple.com>
435
436         Have WKWebView call _updateVisibleContentRects for the current transaction if possible, rather than always delaying
437         https://bugs.webkit.org/show_bug.cgi?id=171619
438         https://bugs.webkit.org/show_bug.cgi?id=170195
439
440         Reviewed by Tim Horton.
441
442         Re-enable WebKit2.ResizeWithHiddenContentDoesNotHang.
443
444         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
445         (TEST):
446
447 2017-05-03  Michael Catanzaro  <mcatanzaro@igalia.com>
448
449         YouTube user agent quirk breaks new YouTube
450         https://bugs.webkit.org/show_bug.cgi?id=171603
451
452         Reviewed by Carlos Garcia Campos.
453
454         Remove the YouTube quirk test.
455
456         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
457         (TestWebKitAPI::TEST):
458
459 2017-05-03  Said Abou-Hallawa  <sabouhallawa@apple.com>
460
461         Async image decoding should be disabled for snapshots, printing and preview
462         https://bugs.webkit.org/show_bug.cgi?id=171467
463
464         Reviewed by Simon Fraser.
465
466         Add a API test for snapshotting with large images. Ensure the images are
467         drawn correctly which implies they should have been synchronously decoded.
468
469         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
470         * TestWebKitAPI/Tests/WebKit2/large-red-square-image.html: Added.
471         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewSnapshot.mm:
472         (TEST):
473
474 2017-05-03  Chris Dumez  <cdumez@apple.com>
475
476         [WK2] Extend processDidCrash delegate to let the client know the reason for the crash
477         https://bugs.webkit.org/show_bug.cgi?id=171565
478         <rdar://problem/31204417>
479
480         Reviewed by Sam Weinig.
481
482         Add API test coverage.
483
484         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
485         * TestWebKitAPI/Tests/WebKit2/ProcessDidCrashWithReason.cpp: Added.
486         (TestWebKitAPI::didFinishNavigation):
487         (TestWebKitAPI::didCrashWithReason):
488         (TestWebKitAPI::TEST):
489
490 2017-05-02  David Kilzer  <ddkilzer@apple.com>
491
492         check-webkit-style should also keep js-test-post[-async].js in sync
493         <https://webkit.org/b/171568>
494
495         Reviewed by Joseph Pecoraro.
496
497         * Scripts/webkitpy/style/checker.py:
498         (_NEVER_SKIPPED_JS_FILES): Add new list that just contains
499         JavaScript files not to be skipped.
500         (_NEVER_SKIPPED_FILES): Update to use _NEVER_SKIPPED_JS_FILES.
501         (CheckerDispatcher._create_checker): Update to use
502         _NEVER_SKIPPED_JS_FILES.
503
504         * Scripts/webkitpy/style/checkers/jstest.py:
505         (ALL_JS_TEST_FUNCTION_FILES): Rename from ALL_JS_TEST_FILES.
506         This is the list of files containing functions that need to be
507         kept in sync.
508         (KEEP_JS_TEST_FILES_IN_SYNC): Change to list-of-lists format so
509         we can keep more sets of files in sync between
510         LayoutTests/resources and LayoutTests/http/tests/resources.
511         (JSTestChecker.check): Update to use KEEP_JS_TEST_FILES_IN_SYNC
512         as list of lists.  Update for ALL_JS_TEST_FUNCTION_FILES rename.
513         (JSTestChecker.check_js_test_files): Add 'file_group' argument
514         for list of files to check instead of using
515         KEEP_JS_TEST_FILES_IN_SYNC.
516         (JSTestChecker.check_js_test_functions): Update for
517         ALL_JS_TEST_FUNCTION_FILES rename.
518
519         * Scripts/webkitpy/style/checkers/jstest_unittest.py:
520         (JSTestCheckerTestCase):
521         (JSTestCheckerTestCase.test_map_functions_to_dict):
522         - Add test case for map_functions_to_dict() in jstest.py.
523
524 2017-05-02  Aakash Jain  <aakash_jain@apple.com>
525
526         ews should indicate in logs when it fails to fetch the attachment
527         https://bugs.webkit.org/show_bug.cgi?id=171583
528
529         Reviewed by Alexey Proskuryakov.
530
531         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
532         (Bugzilla.fetch_attachment): Added log statement.
533
534 2017-05-02  David Kilzer  <ddkilzer@apple.com>
535
536         Rolling out jstest_unittest.py so it can be reviewed
537
538         Follow-up fix for:
539         check-webkit-style should keep JavaScript test functions in sync
540         <https://webkit.org/b/171424>
541
542         * Scripts/webkitpy/style/checkers/jstest_unittest.py: Remove.
543
544 2017-05-02  David Kilzer  <ddkilzer@apple.com>
545
546         check-webkit-style should keep JavaScript test functions in sync
547         <https://webkit.org/b/171424>
548
549         Reviewed by Joseph Pecoraro.
550
551         Add a new JSTestChecker for check-webkit-style that keeps these
552         two files in sync:
553
554             LayoutTests/http/tests/resources/js-test-pre.js
555             LayoutTests/resources/js-test-pre.js
556
557         And keeps implementations of shouldBe(), shouldNotBe(),
558         shouldNotThrow(), and shouldThrow() in sync across multiple
559         files (with the ability to add more functions later):
560
561             JSTests/stress/resources/standalone-pre.js
562             LayoutTests/http/tests/resources/js-test-pre.js
563             LayoutTests/resources/js-test-pre.js
564             LayoutTests/resources/js-test.js
565             LayoutTests/resources/standalone-pre.js
566
567         * Scripts/webkitpy/style/checker.py: Remove unused import.  Add
568         import for JSTestChecker.
569         (_NEVER_SKIPPED_FILES): Add array of file names that are never
570         skipped regardless of other rules.
571         (_all_categories): Add JSTestChecker categories.
572         (CheckerDispatcher.should_skip_without_warning): Use
573         _NEVER_SKIPPED_FILES.
574         (CheckerDispatcher._create_checker): Return JSTestChecker for
575         the files to check.
576
577         * Scripts/webkitpy/style/checkers/jstest.py: Add.
578         (map_functions_to_dict): Parse JavaScript source by splitting on
579         /^function\s+/ regex.  This is good enough for the sanity checks
580         to keep function implementations in sync.
581         (strip_blank_lines_and_comments): Strips blank lines and lines
582         with comments from the end of a chunk of text representing a
583         function.
584         (JSTestChecker): New checker.
585         (JSTestChecker.__init__):
586         (JSTestChecker.check):
587         (JSTestChecker.check_js_test_files): Keeps whole files in sync.
588         (JSTestChecker.check_js_test_functions): Keeps individual
589         functions in sync.
590
591         * Scripts/webkitpy/style/checkers/jstest_unittest.py: Add test
592         case.
593         (JSTestTestCase):
594         (JSTestTestCase.test_map_functions_to_dict):
595
596 2017-05-02  Joanmarie Diggs  <jdiggs@igalia.com>
597
598         AX: Update implementation of aria-orientation
599         https://bugs.webkit.org/show_bug.cgi?id=171166
600
601         Reviewed by Chris Fleizach.
602
603         Return "AXUnknownOrientation" when ATK_STATE_VERTICAL and ATK_STATE_HORIZONTAL
604         are both absent from the state set. Before we were returning an empty string
605         which was not consistent with what the Mac port does, thus making shared tests
606         harder.
607
608         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
609         (WTR::AccessibilityUIElement::orientation):
610
611 2017-05-01  David Kilzer  <ddkilzer@apple.com>
612
613         Stop using sprintf() in JavaScriptCore debugger
614         <https://webkit.org/b/171512>
615
616         Reviewed by Keith Miller.
617
618         * Scripts/webkitpy/style/checker.py:
619         (_PATH_RULES_SPECIFIER): Ignore some formatting checkers since
620         Source/JavaScriptCore/disassembler/udis86/ is generated code.
621
622 2017-05-01  Timothy Horton  <timothy_horton@apple.com>
623
624         Expose viewport-fit instead of clip-to-safe-area
625         https://bugs.webkit.org/show_bug.cgi?id=171503
626         <rdar://problem/31918249>
627
628         Reviewed by Simon Fraser.
629
630         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
631         (WTR::UIScriptController::setSafeAreaInsets):
632         (WTR::UIScriptController::setObscuredInsets): Deleted.
633         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
634         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
635         (WTR::UIScriptController::setSafeAreaInsets):
636         (WTR::UIScriptController::setObscuredInsets): Deleted.
637         * TestRunnerShared/UIScriptContext/UIScriptController.h:
638         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
639         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
640         (-[TestRunnerWKWebView setOverrideSafeAreaInsets:]):
641         (-[TestRunnerWKWebView _safeAreaInsetsForFrame:inSuperview:]):
642         * WebKitTestRunner/ios/TestControllerIOS.mm:
643         (WTR::TestController::platformResetStateToConsistentValues):
644         * WebKitTestRunner/ios/UIKitSPI.h:
645         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
646         (WTR::UIScriptController::setSafeAreaInsets):
647         (WTR::UIScriptController::setObscuredInsets): Deleted.
648         Expose a safe area inset setter instead of obscured insets.
649
650 2017-05-01  Wenson Hsieh  <wenson_hsieh@apple.com>
651
652         Unreviewed, fix the build on a new internal SDK
653
654         Replace usages of NSItemProviderRepresentationVisibilityAll with
655         UIItemProviderRepresentationOptionsVisibilityAll.
656
657         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
658         (-[UIItemProvider registerDataRepresentationForTypeIdentifier:withData:]):
659         (TestWebKitAPI::TEST):
660
661 2017-05-01  David Kilzer  <ddkilzer@apple.com>
662
663         [Cocoa] Replace uses of [get…Class() alloc] in TestWebKitAPI
664         <https://webkit.org/b/171493>
665
666         Reviewed by Dan Bernstein.
667
668         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
669         Remove UIKit soft-link since TestWebKitAPI links to
670         UIKit.framework.
671         (TestWebKitAPI::WebKit1_AudioSessionCategoryIOS_Test): Use
672         UIWindow and UIWebView classes directly.
673         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
674         Remove UIKit soft-link since TestWebKitAPI links to
675         UIKit.framework.
676         (RequiresUserActionForPlaybackTest::createWebView): Use UIWindow
677         class directly.
678
679 2017-05-01  Brady Eidson  <beidson@apple.com>
680
681         Update names in WKURLSchemeHandler/WKURLSchemeHandlerTask APIs.
682         <rdar://problem/31824838> and https://bugs.webkit.org/show_bug.cgi?id=171508
683
684         Reviewed by Andy Estes.
685
686         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
687         (-[SchemeHandler webView:startURLSchemeTask:]):
688         (-[SchemeHandler webView:stopURLSchemeTask:]):
689         (-[SchemeHandler webView:startTask:]): Deleted.
690         (-[SchemeHandler webView:stopTask:]): Deleted.
691
692 2017-05-01  Jason Marcell  <jmarcell@apple.com>
693
694         Add a new function for getting the Git hash for a pure git directory.
695         https://bugs.webkit.org/show_bug.cgi?id=171450
696
697         Reviewed by David Kilzer.
698
699         * Scripts/VCSUtils.pm:
700         (gitHashForDirectory):
701
702 2017-05-01  Joanmarie Diggs  <jdiggs@igalia.com>
703
704         [ATK] Expose values of aria-rowcount, aria-colcount, aria-rowindex, aria-colindex, aria-rowspan, and aria-colspan as object attributes
705         https://bugs.webkit.org/show_bug.cgi?id=171496
706
707         Reviewed by Chris Fleizach.
708
709         Add new attribute names so that the values of the object attributes can be tested.
710
711         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
712         (WTR::AccessibilityUIElement::numberAttributeValue):
713
714 2017-05-01  Beth Dakin  <bdakin@apple.com>
715
716         On-screen panel for candidate bar is in the wrong place when the caret is at the 
717         start of a paragraph
718         https://bugs.webkit.org/show_bug.cgi?id=171453
719         -and corresponding-
720         rdar://problem/29779764
721
722         Reviewed by Tim Horton.
723
724         This test hard-codes the y-coordinate for the expected candidateRect. 
725         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
726         (TEST):
727
728 2017-05-01  David Kilzer  <ddkilzer@apple.com>
729
730         check-webkit-style: Enable sprintf(), strcat(), strcpy() and printf() format checks
731         <https://webkit.org/b/171494>
732
733         Reviewed by Brent Fulgham.
734
735         * Scripts/webkitpy/style/checkers/cpp.py:
736         (check_language): Change categories for certain checkers from
737         'runtime/printf' to 'security/printf' so they are no longer
738         filtered.
739         (CppChecker.categories): Add 'security/printf'.
740         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
741         (CppStyleTest.test_insecure_string_operations): Add new test for
742         sprintf(), strcat() and strcpy().
743         (CppStyleTest.test_format_strings): Update test results for new
744         'security/printf' category use.
745
746 2017-05-01  Joanmarie Diggs  <jdiggs@igalia.com>
747
748         AX: [GTK] Add support to query for aria-current
749         https://bugs.webkit.org/show_bug.cgi?id=149016
750
751         Reviewed by Chris Fleizach.
752
753         Implement support for "AXARIACurrent" string attribute value.
754
755         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
756
757 2017-05-01  David Kilzer  <ddkilzer@apple.com>
758
759         REGRESSION (r216000): test-webkitpy fails after adding new soft-linked class checker
760
761         Unreviewed.
762
763         Follow-up fix for:
764         [Cocoa] Have check-webkit-style advise against use of [get…Class() alloc]
765         https://bugs.webkit.org/show_bug.cgi?id=171486
766
767         * Scripts/webkitpy/style/checkers/cpp.py:
768         (check_soft_link_class_alloc): Use (\w+) instead of ([^\s]+) to
769         match and capture the function name.  The latter also mistakenly
770         matches C-preprocessor directives.
771         (CppChecker.categories): Add 'runtime/soft-linked-alloc', which
772         is a requirement for the CppChecker class.
773
774 2017-05-01  Carlos Garcia Campos  <cgarcia@igalia.com>
775
776         [GTK] Add automation session API
777         https://bugs.webkit.org/show_bug.cgi?id=171428
778
779         Reviewed by Carlos Alberto Lopez Perez.
780
781         Add an automation mode to MiniBrowser using the new API and add a unit test too.
782
783         * MiniBrowser/gtk/BrowserWindow.c:
784         (webViewTitleChanged):
785         (webViewDecidePolicy):
786         (newTabCallback):
787         (openPrivateWindow):
788         (browserWindowFinalize):
789         (browser_window_init):
790         (browser_window_get_or_create_web_view_for_automation):
791         * MiniBrowser/gtk/BrowserWindow.h:
792         * MiniBrowser/gtk/main.c:
793         (createBrowserTab):
794         (createWebViewForAutomationCallback):
795         (automationStartedCallback):
796         (main):
797         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
798         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp: Added.
799         (testAutomationSessionRequestSession):
800         (beforeAll):
801         (afterAll):
802
803 2017-04-30  Dan Bernstein  <mitz@apple.com>
804
805         [Cocoa] Have check-webkit-style advise against use of [get…Class() alloc]
806         https://bugs.webkit.org/show_bug.cgi?id=171486
807
808         Reviewed by Sam Weinig.
809
810         * Scripts/webkitpy/style/checkers/cpp.py:
811         (check_soft_link_class_alloc): Added. Looks for [get…Class() alloc] and suggests
812           alloc…Instance() instead.
813         (check_style): Invoke new check.
814
815 2017-04-30  Brady Eidson  <beidson@apple.com>
816
817         More fixing after r215991
818         https://bugs.webkit.org/show_bug.cgi?id=171483
819
820         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
821         (TEST):
822
823 2017-04-30  Brady Eidson  <beidson@apple.com>
824
825         Updates to _WKWebsiteDataStoreConfiguration cookie storage location SPI.
826         <rdar://problem/31906397> and https://bugs.webkit.org/show_bug.cgi?id=171483
827
828         Reviewed by Geoff Garen (and kind of Andy Estes).
829
830         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
831         (TEST):
832
833 2017-04-30  Joanmarie Diggs  <jdiggs@igalia.com>
834
835         [ATK] Implement support for aria-autocomplete
836         https://bugs.webkit.org/show_bug.cgi?id=171167
837
838         Reviewed by Chris Fleizach.
839
840         Add "AXSupportsAutoCompletion" attribute so the presence of
841         ATK_STATE_SUPPORTS_AUTOCOMPLETION can be tested.
842
843         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
844         (WTR::AccessibilityUIElement::boolAttributeValue):
845
846 2017-04-30  Joanmarie Diggs  <jdiggs@igalia.com>
847
848         [ATK] ARIA treegrid role should be exposed as ATK_ROLE_TREE_TABLE; not ATK_ROLE_TABLE
849         https://bugs.webkit.org/show_bug.cgi?id=171170
850
851         Reviewed by Chris Fleizach.
852
853         Add "AXInterfaceTable" attribute to test which elements implement AtkTable.
854
855         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
856         (WTR::AccessibilityUIElement::boolAttributeValue):
857
858 2017-04-30  Joanmarie Diggs  <jdiggs@igalia.com>
859
860         [ATK] Emit object:state-changed:busy event when aria-busy value changes
861         https://bugs.webkit.org/show_bug.cgi?id=171181
862
863         Reviewed by Chris Fleizach.
864
865         Add handler for AXElementBusyChanged notifications.
866
867         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
868
869 2017-04-29  Aakash Jain  <aakash_jain@apple.com>
870
871         Use PEP8 style guide for raising exceptions in webkitpy.
872         https://bugs.webkit.org/show_bug.cgi?id=171439
873
874         Reviewed by Daniel Bates.
875
876         As per https://www.python.org/dev/peps/pep-0008/
877         "When raising an exception in Python 2, use raise ValueError('message') 
878         instead of the older form raise ValueError, 'message'"
879
880         * Scripts/webkitpy/common/net/irc/ircbot.py: Using new style for raising exceptions.
881         * Scripts/webkitpy/common/thread/messagepump.py: Same.
882         * Scripts/webkitpy/tool/bot/queueengine.py: Same.
883         * Scripts/webkitpy/tool/commands/queues.py: Same.
884         * Scripts/webkitpy/tool/commands/stepsequence.py: Same.
885         * Scripts/webkitpy/tool/multicommandtool.py: Same.
886         * Scripts/webkitpy/tool/steps/abstractstep.py: Same.
887
888 2017-04-28  Simon Fraser  <simon.fraser@apple.com>
889
890         Add system trace points for Document::updateTouchEventRegions()
891         https://bugs.webkit.org/show_bug.cgi?id=171470
892         rdar://problem/31901239
893
894         Reviewed by Tim Horton.
895
896         Add trace markers for updateTouchEventRegions.
897
898         * Tracing/SystemTracePoints.plist:
899
900 2017-04-28  Jonathan Bedard  <jbedard@apple.com>
901
902         webkitpy: Add apple_additions to webkitpy to insert Internal tools
903         https://bugs.webkit.org/show_bug.cgi?id=170461
904         <rdar://problem/31433077>
905
906         Reviewed by Daniel Bates.
907
908         Allow a package to be pulled in by run-webkit-tests which provides an interface to
909         run layout tests on an iOS device.  If this package is not available, throw an
910         exception when attempting to run layout tests on an iOS device.
911
912         * Scripts/webkitpy/port/config.py:
913         (apple_additions): Import apple_additions package.
914         * Scripts/webkitpy/port/device.py:
915         (Device.install_dylibs): Pass a directory with all the frameworks and dylibs to be
916         installed on a device.
917         (Device.prepare_for_testing): Pass a list of ports to forward from the device to the
918         host, the bundle id of the app to be used for testing and a path to the layout test
919         directory to be mounted on the device.
920         (Device.finished_testing):
921         * Scripts/webkitpy/port/factory.py:
922         (platform_options): Add apple_additions platform options if apple_additions exists.
923         * Scripts/webkitpy/port/ios.py:
924         (IOSPort.setup_test_run): Install dylibs and frameworks on the device, pass ports
925         to forward, the bundle ID of the testing app and the layout tests directory to
926         each device.
927         * Scripts/webkitpy/port/ios_device.py:
928         (IOSDevicePort):
929         (IOSDevicePort.default_child_processes): Query apple_additions for the number of child
930         processes to be run.
931         (IOSDevicePort.using_multiple_devices): Always assume multiple devices are used. When
932         a single device is used, it is still accessed through an array.
933         (IOSDevicePort._device_for_worker_number_map): Query apple_additions for the device
934         for worker number map.
935         (IOSDevicePort._driver_class): Query apple_additions for the test driver.
936         (IOSDevicePort.determine_full_port_name): Use class variable over hard-coded string.
937         (IOSDevicePort.check_for_leaks): No implementation for iOSDevicePort.
938         (IOSDevicePort.look_for_new_crash_logs): Ditto.
939         (IOSDevicePort.look_for_new_samples): Ditto.
940         (IOSDevicePort.sample_process): Ditto.
941         (IOSDevicePort._build_driver_flags): Use class variable over hard-coded string.
942         (IOSDevicePort._create_devices): Check that devices are available for testing and check
943         that we have enough devices for each child process.
944         (IOSDevicePort.clean_up_test_run): Have apple_additions preform any needed clean up.
945         * Scripts/webkitpy/port/ios_device_unittest.py:
946         (IOSDeviceTest.test_operating_system):
947         (IOSDeviceTest.test_spindump): Override method from DarwinTest.
948         (IOSDeviceTest.test_sample_process): Ditto.
949         (IOSDeviceTest.test_sample_process_exception): Ditto.
950
951 2017-04-28  Wenson Hsieh  <wenson_hsieh@apple.com>
952
953         Fix and re-enable data interaction unit tests
954         https://bugs.webkit.org/show_bug.cgi?id=171446
955         <rdar://problem/31820646>
956
957         Reviewed by Tim Horton.
958
959         Enables all DataInteractionTests, and adjusts file upload tests to no longer write to a temporary file before
960         registering with the UIItemProvider, and instead just register data directly via
961         -registerDataRepresentationForTypeIdentifier:visibility:loadHandler:.
962
963         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
964         (TestWebKitAPI::TEST):
965         (temporaryURLForDataInteractionFileLoad): Deleted.
966         (cleanUpDataInteractionTemporaryPath): Deleted.
967         (-[UIItemProvider registerFileRepresentationForTypeIdentifier:withData:filename:]): Deleted.
968         * TestWebKitAPI/ios/DataInteractionSimulator.h:
969         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
970
971 2017-04-28  Brady Eidson  <beidson@apple.com>
972
973         Teach the DatabaseProcess to be fully SessionID aware
974         https://bugs.webkit.org/show_bug.cgi?id=171451
975
976         Reviewed by Geoffrey Garen.
977
978         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
979
980 2017-04-28  Jonathan Bedard  <jbedard@apple.com>
981
982         Unreviewed follow-up to r214705.
983
984         shut.copytree will fail if given a file as an argument instead of a directory.
985
986         * Scripts/webkitpy/common/system/filesystem.py:
987         (FileSystem.copy_to_base_host): Use copytree when source is a directory and copyfile
988         when source is a file.
989         (FileSystem.copy_from_base_host): Ditto.
990
991 2017-04-28  Chris Dumez  <cdumez@apple.com>
992
993         Update DOMTokenList.replace() to match the latest DOM specification
994         https://bugs.webkit.org/show_bug.cgi?id=171388
995
996         Reviewed by Alex Christensen.
997
998         Add API test coverage for new Vector API.
999
1000         * TestWebKitAPI/Tests/WTF/Vector.cpp:
1001         (TestWebKitAPI::TEST):
1002
1003 2017-04-28  Jonathan Bedard  <jbedard@apple.com>
1004
1005         WebKitTestRunner/DumpRenderTree prevent device from sleeping
1006         https://bugs.webkit.org/show_bug.cgi?id=170731
1007
1008         Reviewed by Alex Christensen.
1009
1010         While running layout tests on a device, the device should not be put asleep.
1011
1012         * DumpRenderTree/mac/DumpRenderTree.mm:
1013         (dumpRenderTree): Disable idle timer.
1014         * WebKitTestRunner/ios/TestControllerIOS.mm:
1015         (WTR::TestController::platformInitialize): Ditto.
1016
1017 2017-04-28  Brady Eidson  <beidson@apple.com>
1018
1019         Start of support for multiple WebsiteDataStore/SessionIDs per process
1020         https://bugs.webkit.org/show_bug.cgi?id=171422
1021
1022         Reviewed by Geoffrey Garen.
1023
1024         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1025         (TEST):
1026
1027 2017-04-28  Youenn Fablet  <youenn@apple.com>
1028
1029         Adding a runtime flag specific to MediaDevices
1030         https://bugs.webkit.org/show_bug.cgi?id=171433
1031
1032         Reviewed by Geoffrey Garen.
1033
1034         Updating WTR and DRT as peer connection and media stream runtime flags are enabled by default.
1035         Setting media devices runtime flag to true for WTR and DRT.
1036
1037         * DumpRenderTree/mac/DumpRenderTree.mm:
1038         (enableExperimentalFeatures):
1039         (resetWebPreferencesToConsistentValues):
1040         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp:
1041         (TestWebKitAPI::TEST):
1042         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
1043         (TestWebKitAPI::TEST):
1044         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1045         (WTR::InjectedBundle::beginTesting):
1046         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1047         (WTR::TestRunner::setMediaDevicesEnabled):
1048         (WTR::TestRunner::setMediaStreamEnabled): Deleted.
1049         (WTR::TestRunner::setPeerConnectionEnabled): Deleted.
1050         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1051         * WebKitTestRunner/TestController.cpp:
1052         (WTR::TestController::resetPreferencesToConsistentValues):
1053
1054 2017-04-28  Dean Jackson  <dino@apple.com>
1055
1056         [WebGPU] Label MTLCommandQueues with a prefix for internal telemetry
1057         https://bugs.webkit.org/show_bug.cgi?id=171441
1058         <rdar://problem/31826915>
1059
1060         Reviewed by Tim Horton.
1061
1062         Add an API test for GPUCommandQueue, exercising creation
1063         and setting the label.
1064
1065         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1066         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Added.
1067         (TestWebKitAPI::TEST_F):
1068
1069 2017-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
1070
1071         [ATK] aria-modal="true" should be exposed via ATK_STATE_MODAL
1072         https://bugs.webkit.org/show_bug.cgi?id=171188
1073
1074         Reviewed by Chris Fleizach.
1075
1076         Add "AXModal" attribute string so that we can test the state's exposure.
1077
1078         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1079         (WTR::AccessibilityUIElement::boolAttributeValue):
1080
1081 2017-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
1082
1083         [ATK] GridCellRole should implement AtkTableCell (regression?)
1084         https://bugs.webkit.org/show_bug.cgi?id=171179
1085
1086         Reviewed by Chris Fleizach.
1087
1088         Add new "AXInterfaceTableCell" attribute so that we can test whether or
1089         not there is an implementation of AtkTableCell (i.e. without risking false
1090         negatives from bugs in the interface's implementation).
1091
1092         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1093         (WTR::AccessibilityUIElement::boolAttributeValue):
1094
1095 2017-04-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1096
1097         Move UUID from WebCore/platform to WTF
1098         https://bugs.webkit.org/show_bug.cgi?id=171372
1099
1100         Reviewed by Michael Catanzaro.
1101
1102         * WebKitTestRunner/TestController.cpp:
1103
1104 2017-04-27  Alex Christensen  <achristensen@webkit.org>
1105
1106         Add stub SPI for setting cookie storage path on _WKWebsiteDataStoreConfiguration
1107         https://bugs.webkit.org/show_bug.cgi?id=171399
1108
1109         Reviewed by Brady Eidson.
1110
1111         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.html:
1112         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1113         (TEST):
1114
1115 2017-04-27  Ryan Haddad  <ryanhaddad@apple.com>
1116
1117         Disable flaky API test WKWebView.SetOverrideContentSecurityPolicyWithEmptyStringForPageWithCSP.
1118         https://bugs.webkit.org/show_bug.cgi?id=167914
1119
1120         Unreviewed test gardening.
1121
1122         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm:
1123         (TEST):
1124
1125 2017-04-26  Saam Barati  <sbarati@apple.com>
1126
1127         Add some more testing modes for Wasm tests now that we have tier up
1128         https://bugs.webkit.org/show_bug.cgi?id=171360
1129
1130         Reviewed by Keith Miller.
1131
1132         Lets enable the FTL on all Wasm tests. Let's also run each
1133         test with and without CJIT.
1134
1135         * Scripts/run-jsc-stress-tests:
1136
1137 2017-04-26  Aakash Jain  <aakash_jain@apple.com>
1138
1139         JSC EWS Patch Relevance skips few JSC scripts
1140         https://bugs.webkit.org/show_bug.cgi?id=171351
1141
1142         Reviewed by Alexey Proskuryakov.
1143
1144         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
1145         (CheckPatchRelevance): Added few jsc related scripts.
1146
1147 2017-04-26  Youenn Fablet  <youenn@apple.com>
1148
1149         Test importer should delete obsolete files based on w3c-import.log
1150         https://bugs.webkit.org/show_bug.cgi?id=171348
1151
1152         Reviewed by Chris Dumez.
1153
1154         * Scripts/webkitpy/w3c/test_importer.py:
1155         (TestImporter.do_import): Removing dangling -expected.txt files in regular import mode.
1156         (TestImporter.remove_deleted_files): Fixing according w3c-import.log current format.
1157         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1158         (test_remove_obsolete_content):
1159
1160 2017-04-26  Jonathan Bedard  <jbedard@apple.com>
1161
1162         REGRESSION (r213926): We're sometimes trying to start WebKitTestRunner without proper DYLD variables
1163         <rdar://problem/31816459>
1164
1165         Unreviewed infrastructure fix.
1166
1167         Some of our iOS Simulator bots are slow and will register crashes due to an incorrect
1168         DYLD_FRAMEWORK_PATH when installing an app.
1169
1170         * Scripts/webkitpy/port/ios.py:
1171         (IOSPort.setup_test_run): Pass DYLD_FRAMEWORK_PATH to app on install.
1172
1173 2017-04-26  Joanmarie Diggs  <jdiggs@igalia.com>
1174
1175         [ATK] Elements with a defined, non-false value for aria-current should expose ATK_STATE_ACTIVE
1176         https://bugs.webkit.org/show_bug.cgi?id=171163
1177
1178         Reviewed by Chris Fleizach.
1179
1180         Add support for state-change notifications for ATK_STATE_ACTIVE.
1181
1182         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1183
1184 2017-04-26  Jonathan Bedard  <jbedard@apple.com>
1185
1186         webkitpy: Teardown iOS Simulators on exit if managed Simulators are still running
1187         https://bugs.webkit.org/show_bug.cgi?id=171293
1188
1189         Reviewed by Aakash Jain.
1190
1191         We should make an effort to teardown simulators which we booted even when an exception is
1192         thrown while booting. Make some IOSSimulatorPort functions into static methods and register
1193         one of these functions to be run at exit to ensure any devices webkitpy is managing gets
1194         torn down.
1195
1196         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1197         (Manager._set_up_run): Rely on exit handlers to teardown, not exceptions.
1198         * Scripts/webkitpy/port/ios_simulator.py:
1199         (IOSSimulatorPort._teardown_managed_simulators): Function run on exit which will kill all
1200         iOS simulators and teardown and managed devices.
1201         (IOSSimulatorPort._create_simulators): Register teardown function.
1202         (IOSSimulatorPort.clean_up_test_run): Move device teardown to _teardown_managed_simulators.
1203         (IOSSimulatorPort._remove_device): Deleted.
1204
1205 2017-04-26  Joanmarie Diggs  <jdiggs@igalia.com>
1206
1207         [ATK] Implement support for new ARIA 1.1 values of aria-haspopup
1208         https://bugs.webkit.org/show_bug.cgi?id=171164
1209
1210         Reviewed by Chris Fleizach.
1211
1212         hasPopup() should return whether or not ATK_STATE_HAS_POPUP is in the
1213         AtkStateSet; not what is found in the AtkObject's attributes.
1214
1215         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1216         (WTR::AccessibilityUIElement::hasPopup):
1217
1218 2017-04-25  Alex Christensen  <achristensen@webkit.org>
1219
1220         Encoded filename should be decoded for WKContentExtension.identifier
1221         https://bugs.webkit.org/show_bug.cgi?id=171316
1222
1223         Reviewed by Andy Estes.
1224
1225         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1226         * TestWebKitAPI/Tests/WebKit2Cocoa/WKContentExtensionStore.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm.
1227         (TEST_F):
1228         * TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm: Removed.
1229
1230 2017-04-25  Alex Christensen  <achristensen@webkit.org>
1231
1232         REGRESSION(206450): WebKit2PlatformMouseEvent m_modifierFlags not set
1233         https://bugs.webkit.org/show_bug.cgi?id=171297
1234         <rdar://problem/31530719>
1235
1236         Reviewed by Geoffrey Garen.
1237
1238         * TestWebKitAPI/PlatformWebView.h:
1239         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1240         * TestWebKitAPI/Tests/WebKit2/EventModifiers.cpp: Added.
1241         (TestWebKitAPI::didFinishLoadForFrame):
1242         (TestWebKitAPI::mouseDidMoveOverElement):
1243         (TestWebKitAPI::setClients):
1244         (TestWebKitAPI::TEST):
1245         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1246         (TestWebKitAPI::PlatformWebView::simulateRightClick):
1247         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
1248
1249 2017-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1250
1251         Unreviewed, temporarily disable the data interaction unit tests.
1252
1253         The API around data interaction will change significantly in the near future, and
1254         these tests will begin to fail. These will be reenabled once the bots are on an SDK
1255         that supports the updated data interaction API.
1256
1257         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1258         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1259         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1260
1261 2017-04-25  Brent Fulgham  <bfulgham@apple.com>
1262
1263         Limit allowed size of document.title to avoid locking WebKit clients
1264         https://bugs.webkit.org/show_bug.cgi?id=165113
1265         <rdar://problem/28324389>
1266
1267         Reviewed by Darin Adler.
1268
1269         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
1270         * TestWebKitAPI/Tests/WebKit2/LimitTitleSize.cpp: Added.
1271         * TestWebKitAPI/Tests/WebKit2/set-long-title.html: Added.
1272         * TestWebKitAPI/Tests/mac/LimitTitleSize.mm: Added.
1273
1274 2017-04-25  John Wilander  <wilander@apple.com>
1275
1276         Resource Load Statistics: Introduce shorter time-to-live for cookie partition whitelisting
1277         https://bugs.webkit.org/show_bug.cgi?id=171295
1278         <rdar://problem/31823818>
1279
1280         Reviewed by Brent Fulgham.
1281
1282         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1283         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1284         (WTR::TestRunner::setStatisticsTimeToLiveCookiePartitionFree):
1285         (WTR::TestRunner::statisticsFireShouldPartitionCookiesHandler):
1286         (WTR::TestRunner::statisticsFireShouldPartitionCookiesHandlerForOneDomain):
1287         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1288         * WebKitTestRunner/TestController.cpp:
1289         (WTR::TestController::setStatisticsTimeToLiveCookiePartitionFree):
1290         (WTR::TestController::statisticsFireShouldPartitionCookiesHandler):
1291         (WTR::TestController::statisticsFireShouldPartitionCookiesHandlerForOneDomain):
1292         * WebKitTestRunner/TestController.h:
1293         * WebKitTestRunner/TestInvocation.cpp:
1294         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1295
1296 2017-04-25  Tim Horton  <timothy_horton@apple.com>
1297
1298         Try to fix the WKTR build after r215758
1299
1300         * Scripts/build-webkittestrunner:
1301
1302 2017-04-25  Daniel Bates  <dabates@apple.com>
1303
1304         Remove more EFL code
1305         https://bugs.webkit.org/show_bug.cgi?id=171288
1306
1307         Rubber-stamped by Simon Fraser.
1308
1309         The EFL port is no longer in the WebKit OpenSource Project repository. Remove more code
1310         that was part of the EFL port.
1311
1312         * CMakeLists.txt:
1313         * DumpRenderTree/AccessibilityController.h:
1314         * DumpRenderTree/AccessibilityUIElement.cpp:
1315         (AccessibilityUIElement::getJSClass):
1316         * DumpRenderTree/AccessibilityUIElement.h:
1317         * DumpRenderTree/DumpRenderTree.h:
1318         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
1319         * ImageDiff/efl/ImageDiff.cpp: Removed.
1320         * MiniBrowser/efl/CMakeLists.txt: Removed.
1321         * MiniBrowser/efl/main.c: Removed.
1322         * Scripts/build-dumprendertree:
1323         * Scripts/build-jsc:
1324         * Scripts/build-webkit:
1325         * Scripts/build-webkittestrunner:
1326         * Scripts/run-minibrowser:
1327         * Scripts/update-webkit-libs-jhbuild:
1328         * Scripts/update-webkitefl-libs: Removed.
1329         * Scripts/webkitdirs.pm:
1330         (argumentsForConfiguration):
1331         (extractNonMacOSHostConfiguration):
1332         (executableProductDir):
1333         (builtDylibPathForName):
1334         (determinePortName):
1335         (launcherPath):
1336         (launcherName):
1337         (getJhbuildPath):
1338         (wrapperPrefixIfNeeded):
1339         (generateBuildSystemFromCMakeProject):
1340         (buildCMakeProjectOrExit):
1341         (isEfl): Deleted.
1342         * Scripts/webkitperl/FeatureList.pm:
1343         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
1344         * Scripts/webkitpy/common/config/ports.py:
1345         (DeprecatedPort.port):
1346         (GtkWK2Port.run_webkit_tests_command):
1347         (EflWK2Port): Deleted.
1348         (EflWK2Port.build_webkit_command): Deleted.
1349         * Scripts/webkitpy/port/builders.py:
1350         * Scripts/webkitpy/port/efl.py: Removed.
1351         * Scripts/webkitpy/port/efl_unittest.py: Removed.
1352         * Scripts/webkitpy/port/factory.py:
1353         (platform_options):
1354         (PortFactory):
1355         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1356         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
1357         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1358         (TestRebaselineTest.test_baseline_directory):
1359         (TestRebaselineExpectations.test_rebaseline_expectations):
1360         * TestWebKitAPI/PlatformEfl.cmake: Removed.
1361         * TestWebKitAPI/PlatformWebView.h:
1362         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1363         (TestWebKitAPI::TEST):
1364         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: Removed.
1365         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Removed.
1366         * TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Removed.
1367         * TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Removed.
1368         * TestWebKitAPI/efl/InjectedBundleController.cpp: Removed.
1369         * TestWebKitAPI/efl/PlatformUtilities.cpp: Removed.
1370         * TestWebKitAPI/efl/PlatformWebView.cpp: Removed.
1371         * TestWebKitAPI/efl/main.cpp: Removed.
1372         * WebKitTestRunner/EventSenderProxy.h:
1373         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1374         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
1375         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1376         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1377         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1378         (WTR::EventSendingController::contextClick):
1379         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1380         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1381         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
1382         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
1383         * WebKitTestRunner/InjectedBundle/efl/ActivateFontsEfl.cpp: Removed.
1384         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp: Removed.
1385         * WebKitTestRunner/InjectedBundle/efl/FontManagement.h: Removed.
1386         * WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp: Removed.
1387         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp: Removed.
1388         * WebKitTestRunner/PlatformEfl.cmake: Removed.
1389         * WebKitTestRunner/PlatformWebView.h:
1390         * WebKitTestRunner/TestController.cpp:
1391         (WTR::TestController::resetStateToConsistentValues):
1392         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Removed.
1393         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Removed.
1394         * WebKitTestRunner/efl/TestControllerEfl.cpp: Removed.
1395         * WebKitTestRunner/efl/main.cpp: Removed.
1396         * efl/install-dependencies: Removed.
1397         * efl/jhbuild-optional.modules: Removed.
1398         * efl/jhbuild.modules: Removed.
1399         * efl/jhbuildrc: Removed.
1400         * efl/patches/evas-fix-build-with-giflib5.patch: Removed.
1401         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Removed.
1402         * efl/patches/gst-libav.patch: Removed.
1403         * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
1404         * efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
1405         * efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
1406         * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Removed.
1407         * gtk/manifest.txt.in:
1408
1409 2017-04-25  Daniel Bates  <dabates@apple.com>
1410
1411         [Cocoa][Win] Enable of X-Content-Type-Options: nosniff header
1412         https://bugs.webkit.org/show_bug.cgi?id=136452
1413         <rdar://problem/23412620>
1414
1415         Reviewed by Brent Fulgham.
1416
1417         Enable X-Content-Type-Options: nosniff on Mac, iOS and Windows platforms.
1418
1419         * Scripts/webkitperl/FeatureList.pm: Also do not enable nosniff on EFL
1420         as the EFL port is no longer in the WebKit OpenSource repository.
1421         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1422
1423 2017-04-25  Zan Dobersek  <zdobersek@igalia.com>
1424
1425         Unreviewed follow-up to r215739 and r215740.
1426
1427         * gtk/jhbuild.modules: List the libgcrypt patch that has to be applied.
1428         This (and r215740) was supposed to land in r215739, but I managed to
1429         specify the previous version of the patch.
1430
1431 2017-04-25  Zan Dobersek  <zdobersek@igalia.com>
1432
1433         Unreviewed follow-up to r215739.
1434
1435         * gtk/patches/libgcrypt-use-only-dev-urandom-for-testing.patch: Add the missing
1436         libgcrypt patch that enforces the use of /dev/urandom.
1437
1438 2017-04-25  Zan Dobersek  <zdobersek@igalia.com>
1439
1440         [GTK] Add libgpg-error, libgcrypt libraries to JHBuild
1441         https://bugs.webkit.org/show_bug.cgi?id=171270
1442
1443         Reviewed by Michael Catanzaro.
1444
1445         * gtk/jhbuild.modules: Add the latest stable versions of libgpg-error and libgcrypt
1446         libraries to the webkitgtk-testing-dependencies metamodule. This will help people
1447         that use systems that don't yet provide libgcrypt >= 1.7.0.
1448
1449 2017-04-25  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1450
1451         [GTK] Improve an unit test for the JHBuild wrapper.
1452         https://bugs.webkit.org/show_bug.cgi?id=168036
1453
1454         Unreviewed follow-up patch after r215727
1455
1456         * Scripts/webkitpy/port/base_unittest.py:
1457         (test_jhbuild_wrapper): Improve the unit test by ensuring the directory
1458         wasn't there before calling MockFileSystem.maybe_make_directory(), and
1459         also that it exists after calling it.
1460
1461 2017-04-25  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1462
1463         [GTK] ImageDiff should be run by jhbuild-wrapper in case of using jhbuild
1464         https://bugs.webkit.org/show_bug.cgi?id=168036
1465
1466         Reviewed by Michael Catanzaro.
1467
1468         Call ImageDiff with the JHBuild wrapper if we should use it.
1469         Also add some unit tests for the JHBuild wrapper feature.
1470
1471         * Scripts/webkitpy/port/base.py:
1472         (Port._should_use_jhbuild): Use self._filesystem instead of os.path to allow mock testing.
1473         * Scripts/webkitpy/port/base_unittest.py:
1474         (test_jhbuild_wrapper): Add a test for port._should_use_jhbuild()
1475         * Scripts/webkitpy/port/image_diff.py:
1476         (ImageDiffer._start): The actual fix, use the wrapper if we should.
1477         * Scripts/webkitpy/port/image_diff_unittest.py: Removed. This two tests are now integrated in port_testcase
1478         * Scripts/webkitpy/port/port_testcase.py:
1479         (PortTestCase):
1480         (PortTestCase.test_diff_image): Test the command with wrapper and without it.
1481         (PortTestCase.test_diff_image_passed): Moved from image_diff_unittest.py
1482         (PortTestCase.test_diff_image_failed): Moved from image_diff_unittest.py
1483
1484 2017-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1485
1486         Support reading NSURL titles from the pasteboard when performing data interaction
1487         https://bugs.webkit.org/show_bug.cgi?id=171156
1488         <rdar://problem/31356937>
1489
1490         Reviewed by Tim Horton.
1491
1492         Adds a new unit test, DataInteractionTests.ExternalSourceTitledNSURL.
1493
1494         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1495         (TestWebKitAPI::TEST):
1496
1497 2017-04-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1498
1499         Respect fidelity order when reading web content from item providers
1500         https://bugs.webkit.org/show_bug.cgi?id=171155
1501         <rdar://problem/31356937>
1502
1503         Reviewed by Tim Horton.
1504
1505         Adds a new unit test (DataInteractionTests.RespectsExternalSourceFidelityRankings). See WebCore ChangeLog for
1506         more details.
1507
1508         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1509         (TestWebKitAPI::TEST):
1510
1511 2017-04-24  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1512
1513         SyntaxError fix after r215702.
1514         https://bugs.webkit.org/show_bug.cgi?id=168944
1515
1516         Unreviewed "build" fix.
1517
1518         * BuildSlaveSupport/built-product-archive:
1519         (archiveBuiltProduct):
1520
1521 2017-04-24  Jonathan Bedard  <jbedard@apple.com>
1522
1523         Package ImageDiff built with host SDK
1524         https://bugs.webkit.org/show_bug.cgi?id=168944
1525         <rdar://problem/30745642>
1526
1527         Reviewed by David Kilzer.
1528
1529         iOS Simulator and iOS device should archive the ImageDiff built for the host
1530         machine.
1531
1532         * BuildSlaveSupport/built-product-archive:
1533         (determineWebKitBuildDirectories): Add _hostBuildDirectory for iOS.
1534         (archiveBuiltProduct): Archive Mac products for iOS so that ImageDiff is included.
1535
1536 2017-04-24  Keith Miller  <keith_miller@apple.com>
1537
1538         ThreadMessage API tests failing on release bots
1539         https://bugs.webkit.org/show_bug.cgi?id=171246
1540
1541         Reviewed by Saam Barati.
1542
1543         Need to make sure that C++ doesn't optimize away our spin loop.
1544
1545         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
1546         (runThreadMessageTest):
1547         (TEST):
1548
1549 2017-04-24  Alex Christensen  <achristensen@webkit.org>
1550
1551         Reduce copies and allocations in SharedBuffer::append
1552         https://bugs.webkit.org/show_bug.cgi?id=170956
1553
1554         Reviewed by Andreas Kling.
1555
1556         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
1557         (TestWebKitAPI::TEST_F):
1558
1559 2017-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1560
1561         [GTK] Switch to use ENABLE_REMOTE_INSPECTOR instead of ENABLE_INSPECTOR_SERVER for the remote inspector
1562         https://bugs.webkit.org/show_bug.cgi?id=166680
1563
1564         Reviewed by Michael Catanzaro.
1565
1566         Update remote inspector unit tests.
1567
1568         * TestWebKitAPI/Tests/WebKit2Gtk/InspectorTestServer.cpp:
1569         (main):
1570         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
1571         (connectToInspectorServer):
1572         (waitUntilInspectorServerIsReady):
1573         (startTestServer):
1574         (testInspectorServerPageList):
1575         (beforeAll):
1576
1577 2017-04-23  Youenn Fablet  <youenn@apple.com>
1578
1579         Add a tool to update expected.txt files from EWS bot results
1580         https://bugs.webkit.org/show_bug.cgi?id=169538
1581
1582         Reviewed by Ryosuke Niwa.
1583
1584         This script updates expected-txt files from bugzilla posted EWS results.
1585         It uses mac-wk2 as the generic baseline and adds platform-specific results if other ports
1586         have results different from the generic baseline.
1587
1588         * Scripts/update-test-expectations-from-bugzilla: Added.
1589         * Scripts/webkitpy/common/net/bugzilla/test_expectation_updater.py: Added.
1590         * Scripts/webkitpy/common/net/bugzilla/test_expectation_updater_unittest.py: Added.
1591         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Adding helper routines.
1592
1593 2017-04-22  Youenn Fablet  <youenn@apple.com>
1594
1595         Add an option to import tip-of-tree WPT tests
1596         https://bugs.webkit.org/show_bug.cgi?id=171152
1597
1598         Reviewed by Joseph Pecoraro.
1599
1600         Adding a '-t' option to import tip of tree WPT tests.
1601         Updating importer based on the fact that csswg-test is no longer a thing. 
1602
1603         * Scripts/webkitpy/w3c/test_downloader.py:
1604         (TestDownloader.download_tests):
1605         * Scripts/webkitpy/w3c/test_importer.py:
1606         (configure_logging):
1607         (TestImporter.do_import):
1608         (TestImporter.write_import_log):
1609
1610 2017-04-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1611
1612         File inputs only accept UTI types that can be inserted into contenteditable areas when dropping
1613         https://bugs.webkit.org/show_bug.cgi?id=171177
1614         <rdar://problem/31765379>
1615
1616         Reviewed by Andy Estes.
1617
1618         Tests uploading a JSON file to a file input.
1619
1620         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1621         (TestWebKitAPI::TEST):
1622
1623 2017-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1624
1625         Support writing link titles to the pasteboard when beginning data interaction on a link
1626         https://bugs.webkit.org/show_bug.cgi?id=171154
1627         <rdar://problem/31356937>
1628
1629         Reviewed by Andy Estes.
1630
1631         Augments an existing unit test, DataInteractionTests.LinkToInput, to also check that the fetching the NSURL from
1632         the source UIItemProvider generated by performing data interaction results in an NSURL with the _title attribute
1633         matching the title of the link.
1634
1635         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1636         (TestWebKitAPI::TEST):
1637
1638 2017-04-21  Michael Catanzaro  <mcatanzaro@igalia.com>
1639
1640         Unreviewed, rolling out r215608.
1641
1642         Hundreds of test failures on GTK bot
1643
1644         Reverted changeset:
1645
1646         "Reduce copies and allocations in SharedBuffer::append"
1647         https://bugs.webkit.org/show_bug.cgi?id=170956
1648         http://trac.webkit.org/changeset/215608
1649
1650 2017-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1651
1652         [WK2] Add delegate hooks for overriding unhanded data interaction operations
1653         https://bugs.webkit.org/show_bug.cgi?id=171005
1654         <rdar://problem/31669646>
1655
1656         Reviewed by Tim Horton.
1657
1658         Adds a new API test checking that normal WebKit behavior when vending updated data interaction operations may
1659         be overridden, resulting in a data interaction operation being performed when it otherwise would not have. Also
1660         adjusts for some changes in WebKit2 (See WebKit2 ChangeLog for more details).
1661
1662         New API test:
1663         DataInteractionTests.OverrideDataInteractionOperation
1664
1665         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1666         (-[UIItemProvider registerDataRepresentationForTypeIdentifier:withData:]):
1667         (TestWebKitAPI::TEST):
1668         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1669         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1670         (-[DataInteractionSimulator initWithWebView:]):
1671         (-[DataInteractionSimulator dealloc]):
1672         (-[DataInteractionSimulator _webView:dataInteractionOperationWasHandled:forSession:itemProviders:]):
1673         (-[DataInteractionSimulator _webView:willUpdateDataInteractionOperationToOperation:forSession:]):
1674         (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]): Deleted.
1675
1676 2017-04-21  Ryan Haddad  <ryanhaddad@apple.com>
1677
1678         Temporarily disable two flaky API tests.
1679
1680         Unreviewed test gardening.
1681
1682         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
1683         (TEST):
1684         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
1685         (TEST):
1686
1687 2017-04-21  Keith Miller  <keith_miller@apple.com>
1688
1689         Unreviewed, rolling out r215634.
1690
1691         underlying build issues should have been fixed
1692
1693         Reverted changeset:
1694
1695         "Unreviewed, rolling out r215620 and r215623."
1696         https://bugs.webkit.org/show_bug.cgi?id=171139
1697         http://trac.webkit.org/changeset/215634
1698
1699 2017-04-21  Aakash Jain  <aakash_jain@apple.com>
1700
1701         Bubbles on dashboard doesn't turn red for test262 failures
1702         https://bugs.webkit.org/show_bug.cgi?id=171129
1703
1704         Reviewed by Alexey Proskuryakov.
1705
1706         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Added test262-test.
1707
1708 2017-04-21  Commit Queue  <commit-queue@webkit.org>
1709
1710         Unreviewed, rolling out r215620 and r215623.
1711         https://bugs.webkit.org/show_bug.cgi?id=171139
1712
1713         broke arm64 build (Requested by keith_miller on #webkit).
1714
1715         Reverted changesets:
1716
1717         "Add signaling API"
1718         https://bugs.webkit.org/show_bug.cgi?id=170976
1719         http://trac.webkit.org/changeset/215620
1720
1721         "Unreviewed, fix Cloop build."
1722         http://trac.webkit.org/changeset/215623
1723
1724 2017-04-20  Keith Miller  <keith_miller@apple.com>
1725
1726         Add signaling API
1727         https://bugs.webkit.org/show_bug.cgi?id=170976
1728
1729         Reviewed by Filip Pizlo.
1730
1731         Add tests for ThreadMessages.
1732
1733         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1734         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp: Added.
1735         (runThreadMessageTest):
1736         (TEST):
1737
1738 2017-04-20  Conrad Shultz  <conrad_shultz@apple.com>
1739
1740         commit-log-editor should respect the git editor if one is set
1741         https://bugs.webkit.org/show_bug.cgi?id=171085
1742         <rdar://problem/31745506>
1743
1744         Reviewed by Daniel Bates.
1745
1746         * Scripts/commit-log-editor:
1747         If Git is available, consider GIT_LOG_EDITOR and any global Git editor preference when
1748         deciding which editor to present. We examine the global editor preference since that may be
1749         set automatically by installers or third-party tools.
1750
1751 2017-04-21  Alex Christensen  <achristensen@webkit.org>
1752
1753         Reduce copies and allocations in SharedBuffer::append
1754         https://bugs.webkit.org/show_bug.cgi?id=170956
1755
1756         Reviewed by Andreas Kling.
1757
1758         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
1759         (TestWebKitAPI::TEST_F):
1760
1761 2017-04-20  Konstantin Tokarev  <annulen@yandex.ru>
1762
1763         [cmake] Define FORWARDING_HEADERS_DIR in WebKitFS and use it everywhere
1764         https://bugs.webkit.org/show_bug.cgi?id=171071
1765
1766         Reviewed by Michael Catanzaro.
1767
1768         "${DERIVED_SOURCES_DIR}/ForwardingHeaders" path occurs very often in the
1769         build system files. GTK-specifc FORWARDING_HEADERS_DIR variable should
1770         be available for all ports.
1771
1772         * DumpRenderTree/PlatformMac.cmake:
1773         * MiniBrowser/mac/CMakeLists.txt:
1774         * MiniBrowser/win/CMakeLists.txt:
1775         * TestWebKitAPI/PlatformJSCOnly.cmake:
1776         * TestWebKitAPI/PlatformMac.cmake:
1777         * TestWebKitAPI/PlatformWin.cmake:
1778         * WebKitTestRunner/PlatformMac.cmake:
1779
1780 2017-04-20  Joseph Pecoraro  <pecoraro@apple.com>
1781
1782         Test262 bot does not go red with failures
1783         https://bugs.webkit.org/show_bug.cgi?id=171044
1784
1785         Reviewed by Aakash Jain.
1786
1787         The piped output of run-jsc-stress-tests is different from
1788         its non-piped output. Switch to parsing the correct output.
1789
1790         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1791         (RunTest262Tests.countFailures):
1792         Just count the number of lines that start with "FAIL:".
1793
1794         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1795         (RunTest262TestsTest.test_no_regressions_output):
1796         (test_failure_output):
1797         (test_failures_output):
1798         Updated tests with new sample output produced partially from bots and
1799         locally. In cases of failure the return code of run-jsc-stress-tests
1800         is still 0 so update the expected return code in the tests.
1801
1802 2017-04-20  Brady Eidson  <beidson@apple.com>
1803
1804         WebContent process becomes unresponsive after returning nil from async version of -webView:createWebViewWithConfiguration:...
1805         <rdar://problem/31739023> and https://bugs.webkit.org/show_bug.cgi?id=171090
1806
1807         Reviewed by Andy Estes.
1808
1809         * TestWebKitAPI/Tests/WebKit2/open-and-close-window.html:
1810         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
1811         (resetToConsistentState):
1812         (-[OpenAndCloseWindowUIDelegate webViewDidClose:]):
1813         (-[OpenAndCloseWindowUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1814         (TEST):
1815         (-[OpenAndCloseWindowUIDelegateAsync _webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:completionHandler:]):
1816
1817 2017-04-20  Wenson Hsieh  <wenson_hsieh@apple.com>
1818
1819         [ios-simulator] PositionInformationTests API tests are timing out
1820         https://bugs.webkit.org/show_bug.cgi?id=171089
1821
1822         Rubber-stamped by Tim Horton.
1823
1824         Addresses failures observed in the new position information tests added in r215573 by only running them if the
1825         DATA_INTERACTION feature flag is enabled.
1826
1827         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
1828
1829 2017-04-20  Brady Eidson  <beidson@apple.com>
1830
1831         Skip WebKit2.OpenAndCloseWindowAsyncCallbackException for now.
1832         https://bugs.webkit.org/show_bug.cgi?id=171083
1833
1834         Unreviewed.
1835
1836         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
1837
1838 2017-04-20  Brady Eidson  <beidson@apple.com>
1839
1840         Add CompletionHandlerCallChecker to SPI added in r215545.
1841         https://bugs.webkit.org/show_bug.cgi?id=171067
1842
1843         Reviewed by Dan Bernstein.
1844
1845         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
1846         (TEST):
1847         (-[OpenAndCloseWindowUIDelegateAsync _webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:completionHandler:]):
1848
1849 2017-04-20  Wenson Hsieh  <wenson_hsieh@apple.com>
1850
1851         [WK2] -[WKContentView doAfterPositionInformationUpdate:atPosition:] should be robust against synchronous reentrancy
1852         https://bugs.webkit.org/show_bug.cgi?id=170922
1853         <rdar://problem/31634990>
1854
1855         Reviewed by Tim Horton.
1856
1857         Adds six new unit tests for retrieving interaction information at a given position in the UI process. See
1858         WebKit2 ChangeLog for more details.
1859
1860         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
1861         (-[_WKDraggableElementInfo expectToBeLink:image:atPoint:]):
1862         (TestWebKitAPI::TEST):
1863         (TestWebKitAPI::expectCGPointsToBeEqual): Deleted.
1864
1865 2017-04-20  Xan Lopez  <xlopez@igalia.com>
1866
1867         [GTK][jhbuild] Update glib and glib-networking to the latest stable versions
1868         https://bugs.webkit.org/show_bug.cgi?id=170942
1869
1870         Reviewed by Carlos Garcia Campos.
1871
1872         Update glib and glib-networking to the last stable releases. This
1873         is needed to get working TLS certificate verification at all at
1874         least in Fedora.
1875
1876         * gtk/install-dependencies: add libmount, needed for newer glib.
1877         * gtk/jhbuild.modules: update glib and glib-networking to last
1878         stable releases.
1879
1880 2017-04-20  Joanmarie Diggs  <jdiggs@igalia.com>
1881
1882         [ATK] Implement support for DPub ARIA roles
1883         https://bugs.webkit.org/show_bug.cgi?id=170679
1884
1885         Reviewed by Chris Fleizach.
1886
1887         Add DPub ARIA landmark roles to roleToString().
1888
1889         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1890
1891 2017-04-19  Joseph Pecoraro  <pecoraro@apple.com>
1892
1893         Remove WebKitTestRunner code for enabling features that are already enabled by default
1894         https://bugs.webkit.org/show_bug.cgi?id=171033
1895
1896         Reviewed by Ryosuke Niwa.
1897
1898         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1899         (WTR::InjectedBundle::beginTesting):
1900         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1901         (WTR::TestRunner::setShadowDOMEnabled): Deleted.
1902         (WTR::TestRunner::setCustomElementsEnabled): Deleted.
1903         (WTR::TestRunner::setFetchAPIEnabled): Deleted.
1904         (WTR::TestRunner::setDownloadAttributeEnabled): Deleted.
1905         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1906
1907 2017-04-19  Youenn Fablet  <youenn@apple.com>
1908
1909         [Mac] Allow customizing H264 encoder
1910         https://bugs.webkit.org/show_bug.cgi?id=170829
1911
1912         Reviewed by Alex Christensen.
1913
1914         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1915
1916 2017-04-19  Brady Eidson  <beidson@apple.com>
1917
1918         Add asynchronous equivalent of -[<WKUIDelegate> webView:createWebViewWithConfiguration:...].
1919         <rdar://problem/30699851> and https://bugs.webkit.org/show_bug.cgi?id=171018
1920
1921         Reviewed by Tim Horton.
1922
1923         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
1924         (TEST):
1925         (-[OpenAndCloseWindowUIDelegateAsync webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1926         (-[OpenAndCloseWindowUIDelegateAsync _webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:completionHandler:]):
1927
1928 2017-04-19  Brady Eidson  <beidson@apple.com>
1929
1930         REGRESSION (r213168): An extra Web Content process is spun up on launch and is never closed.
1931         <rdar://problem/30774839> and https://bugs.webkit.org/show_bug.cgi?id=171002
1932
1933         Reviewed by Alex Christensen.
1934
1935         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1936         * TestWebKitAPI/Tests/WebKit2Cocoa/InitialWarmedProcessUsed.mm: Added.
1937
1938 2017-04-19  Brent Fulgham  <bfulgham@apple.com>
1939
1940         [WK2] Run tests with ResourceLoadStatistics enabled
1941         https://bugs.webkit.org/show_bug.cgi?id=170952
1942
1943         Reviewed by Andy Estes.
1944
1945         Excercise the load statistics code during tests.
1946
1947         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1948         (WTR::initializeWebViewConfiguration):
1949
1950 2017-04-19  Bill Ming  <mbbill@gmail.com>
1951
1952         close_fds should be set to False on Windows.
1953         https://bugs.webkit.org/show_bug.cgi?id=170838
1954
1955         Reviewed by Brent Fulgham.
1956
1957         * Scripts/webkitpy/common/system/executive.py:
1958         (Executive._should_close_fds):
1959
1960 2017-04-19  David Kilzer  <ddkilzer@apple.com>
1961
1962         Stop using strcpy() in WebKit::EnvironmentUtilities::stripValuesEndingWithString()
1963         <https://webkit.org/b/170994>
1964         <rdar://problem/29889932>
1965
1966         Reviewed by Brent Fulgham.
1967
1968         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1969         (EnvironmentUtilitiesTest.cpp): Add to TestWebKitAPILibrary
1970         target.
1971         * TestWebKitAPI/Tests/WebKit2/EnvironmentUtilitiesTest.cpp: Add.
1972         (TestWebKitAPI::strip): Helper method to set/get environment
1973         variable for testing.
1974         (TestWebKitAPI::WebKit2_StripValuesEndingWithString_Test): Add
1975         tests.
1976
1977 2017-04-19  JF Bastien  <jfbastien@apple.com>
1978
1979         WebAssembly: add script which can import GCC torture tests
1980         https://bugs.webkit.org/show_bug.cgi?id=170740
1981
1982         Reviewed by Saam Barati.
1983
1984         Add a script which can import the GCC torture tests and create a
1985         yaml file to run them as part of jsc's WebAssembly regression
1986         tests.
1987
1988         This patch doesn't commit the tests themselves because they're
1989         licensed differently.
1990
1991         * Scripts/run-jsc-stress-tests: learn how to run
1992         Emscripten-generated .js+.wasm files, and do a bit of cleanup on
1993         the options because WebAssembly is enabled by default.
1994         * Scripts/update-wasm-gcc-torture.py: Added.
1995         (parse_args):
1996         (update_lkgr):
1997         (untar_torture):
1998         (list_js_files):
1999         (waterfall_known_failures):
2000         (create_yaml):
2001         (main):
2002
2003 2017-04-19  Youenn Fablet  <youenn@apple.com>
2004
2005         Import web-platform-tests/tools
2006         https://bugs.webkit.org/show_bug.cgi?id=170718
2007
2008         Reviewed by Alex Christensen.
2009
2010         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
2011         (main):
2012         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2013         (WebPlatformTestServer.ports_to_forward):
2014         (WebPlatformTestServer._prepare_config):
2015         (WebPlatformTestServer._install_modules): Deleted.
2016         * Scripts/webkitpy/w3c/test_importer.py:
2017         (TestImporter.write_html_files_for_templated_js_tests):
2018
2019 2017-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2020
2021         [WK2] Add infrastructure and unit tests for file uploads using data interaction
2022         https://bugs.webkit.org/show_bug.cgi?id=170903
2023         <rdar://problem/31314689>
2024
2025         Reviewed by Tim Horton.
2026
2027         Adds 5 new unit tests covering different cases of uploading files through data interaction, as well as
2028         infrastructure for simulating UIItemProviders that load file data. Makes a few adjustments to the
2029         DataInteractionSimulator along the way, detailed in the per-method annotations below. See
2030         <https://bugs.webkit.org/show_bug.cgi?id=170880> for more details about the change this patch is testing.
2031
2032         New tests:
2033         DataInteractionTests.ExternalSourceImageToFileInput
2034         DataInteractionTests.ExternalSourceHTMLToUploadArea
2035         DataInteractionTests.ExternalSourceImageAndHTMLToSingleFileInput
2036         DataInteractionTests.ExternalSourceImageAndHTMLToMultipleFileInput
2037         DataInteractionTests.ExternalSourceImageAndHTMLToUploadArea
2038
2039         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2040         (testIconImage):
2041         (temporaryURLForDataInteractionFileLoad):
2042         (cleanUpDataInteractionTemporaryPath):
2043
2044         Creates and tears down temporary file directories for testing data interaction.
2045
2046         (-[UIItemProvider registerFileRepresentationForTypeIdentifier:withData:filename:]):
2047         (TestWebKitAPI::TEST):
2048         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2049         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2050
2051         Make necessary changes to be able to test what happens when data interaction ends over an element with no
2052         operation. Previously, we would always simulate performing a data interaction operation when ending the
2053         simulation, but this causes us to wait indefinitely for a data operation response to arrive in the UI process.
2054         Instead, we need to note whether or not the content view is allowing data interaction, and only perform an
2055         operation and wait for the -didPerform call if the operation was allowed. Otherwise, we immediately transition
2056         the phase to Cancelled and end the run.
2057
2058         (-[DataInteractionSimulator _resetSimulatedState]):
2059         (-[DataInteractionSimulator runFrom:to:]):
2060         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
2061         (-[DataInteractionSimulator _advanceProgress]):
2062         (-[DataInteractionSimulator externalItemProviders]):
2063         (-[DataInteractionSimulator setExternalItemProviders:]):
2064
2065         Previously, we hard-coded DataInteractionSimulator to only support a single external item provider. In order to
2066         test the scenario where multiple files are being "data interacted" into a file-type input, we generalize this to
2067         take multiple item providers.
2068
2069         (-[DataInteractionSimulator externalItemProvider]): Deleted.
2070         (-[DataInteractionSimulator setExternalItemProvider:]): Deleted.
2071
2072 2017-04-18  John Wilander  <wilander@apple.com>
2073
2074         Make WebCore::topPrivatelyControlledDomain() return "localhost" for localhost
2075         https://bugs.webkit.org/show_bug.cgi?id=170798
2076         <rdar://problem/31595108>
2077
2078         Reviewed by Alex Christensen.
2079
2080         * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
2081         (TestWebKitAPI::TEST_F):
2082             Added two negative test cases for WebCore::isPublicSuffix().
2083             Added test cases with mixed case domains, localhost, and
2084             non-ASCII for WebCore::topPrivatelyControlledDomain().
2085
2086 2017-04-18  Jonathan Bedard  <jbedard@apple.com>
2087
2088         Unreviewed, rolling out r215346 and 215361.
2089
2090         The problem these changes were fixing was addressed in
2091         <https://trac.webkit.org/changeset/215416/webkit>.
2092
2093         Reverted changesets:
2094
2095         "webkitpy: Ignore previously launched pid when system is under
2096         stress"
2097         https://bugs.webkit.org/show_bug.cgi?id=170741
2098         http://trac.webkit.org/changeset/215346
2099         http://trac.webkit.org/changeset/215361
2100
2101 2017-04-17  Alex Christensen  <achristensen@webkit.org>
2102
2103         Allow Variants of RetainPtrs
2104         https://bugs.webkit.org/show_bug.cgi?id=170923
2105
2106         Reviewed by Tim Horton and Sam Weinig.
2107
2108         * TestWebKitAPI/Tests/WTF/Variant.cpp:
2109         (TestWebKitAPI::TEST):
2110         Add tests for RetainPtr and for another class with overloaded operator& to verify such classes can
2111         work in Variants.
2112
2113 2017-04-17  Brady Eidson  <beidson@apple.com>
2114
2115         Make WKHTTPCookieStore public.
2116         <rdar://problem/31024691> and https://bugs.webkit.org/show_bug.cgi?id=170920
2117
2118         Reviewed by Geoffrey Garen.
2119
2120         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2121         (TEST):
2122
2123 2017-04-17  Youenn Fablet  <youenn@apple.com>
2124
2125         Disable outdated WritableStream API
2126         https://bugs.webkit.org/show_bug.cgi?id=170749
2127         <rdar://problem/31446233>
2128
2129         Reviewed by Alex Christensen.
2130
2131         Replacing READABLE_STREAM_API, READABLE_BYTE_STREAM_API and WRITABLE_STREAM_API compilation flag by:
2132         - A STREAMS_API compilation flag.
2133         - A ReadableByteStreamAPI and WritableStreamAPI runtime flags, turned off except for RWT and DRT.
2134
2135         * DumpRenderTree/mac/DumpRenderTree.mm:
2136         (enableExperimentalFeatures):
2137         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2138         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2139         (WTR::InjectedBundle::beginTesting):
2140         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2141         (WTR::TestRunner::setFetchAPIEnabled):
2142         (WTR::TestRunner::setWritableStreamAPIEnabled):
2143         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
2144         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2145
2146 2017-04-17  Tim Horton  <timothy_horton@apple.com>
2147
2148         Provide a viewport parameter to disable clipping to the safe area
2149         https://bugs.webkit.org/show_bug.cgi?id=170766
2150         <rdar://problem/31564634>
2151
2152         Reviewed by Beth Dakin.
2153
2154         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2155         (WTR::UIScriptController::setObscuredInsets):
2156         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2157         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2158         (WTR::UIScriptController::setObscuredInsets):
2159         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2160         * WebKitTestRunner/ios/TestControllerIOS.mm:
2161         (WTR::TestController::platformResetStateToConsistentValues):
2162         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2163         (WTR::UIScriptController::setObscuredInsets):
2164         Add a UIScriptController mechanism to install obscured insets
2165         on the web view.
2166
2167 2017-04-17  Dan Bernstein  <mitz@apple.com>
2168
2169         [Cocoa] Move isNullFunctionPointer down into WTF
2170         https://bugs.webkit.org/show_bug.cgi?id=170892
2171
2172         Reviewed by Sam Weinig.
2173
2174         * TestWebKitAPI/Configurations/TestWTF.xcconfig:
2175         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2176         * TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp: Added.
2177         (TestWebKitAPI::TEST):
2178         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS-v2.tbd: Added.
2179         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS.tbd: Added.
2180         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-macOS-v2.tbd: Added.
2181         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-macOS.tbd: Added.
2182
2183 2017-04-17  Jonathan Bedard  <jbedard@apple.com>
2184
2185         webkitpy: Correct poll when killing ServerProcess
2186
2187         Unreviewed infrastructure fix.
2188
2189         * Scripts/webkitpy/port/server_process.py:
2190         (ServerProcess._kill): A polled process equaling 'None' means the process is running.
2191
2192 2017-04-17  Eric Carlson  <eric.carlson@apple.com>
2193
2194         [MediaStream] Enable getUserMedia API test
2195         https://bugs.webkit.org/show_bug.cgi?id=170901
2196         <rdar://problem/31656594>
2197
2198         Reviewed by Youenn Fablet.
2199
2200         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add test.
2201
2202         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
2203         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
2204         (TestWebKitAPI::TEST): Enable capture with mock devices.
2205         * TestWebKitAPI/Tests/WebKit2/getUserMedia.html: Update to mediaDevices.getUserMedia
2206
2207 2017-04-17  Xan Lopez  <xan@igalia.com>
2208
2209         [GTK] Update the Fedora dependencies for WebKitGTK+
2210         https://bugs.webkit.org/show_bug.cgi?id=170590
2211
2212         Reviewed by Carlos Alberto Lopez Perez.
2213
2214         * gtk/install-dependencies: add a bunch of modules necessary to
2215         get a proper set of GStreamer codecs for WebRTC.
2216
2217 2017-04-16  Sam Weinig  <sam@webkit.org>
2218
2219         [WebIDL] Switch IDLAttributes.txt over to a more structured format so that more information can be added for each attribute
2220         https://bugs.webkit.org/show_bug.cgi?id=170843
2221
2222         Reviewed by Chris Dumez.
2223
2224         * DumpRenderTree/DerivedSources.make:
2225         * WebKitTestRunner/DerivedSources.make:
2226         * Scripts/webkitpy/bindings/main.py:
2227         (BindingsTests.generate_from_idl):
2228         Pass IDLAttributes.json, as it is now mandatory to have one.
2229
2230 2017-04-14  Mark Lam  <mark.lam@apple.com>
2231
2232         Update architectures in xcconfig files.
2233         https://bugs.webkit.org/show_bug.cgi?id=170867
2234         <rdar://problem/31628104>
2235
2236         Reviewed by Joseph Pecoraro.
2237
2238         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2239         * MobileMiniBrowser/Configurations/Base.xcconfig:
2240         * TestWebKitAPI/Configurations/Base.xcconfig:
2241         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2242         * WebKitTestRunner/Configurations/Base.xcconfig:
2243
2244 2017-04-14  Brady Eidson  <beidson@apple.com>
2245
2246         Fix basic WKURLSchemeHandler bugs.
2247         <rdar://problem/30647559> and https://bugs.webkit.org/show_bug.cgi?id=170862
2248
2249         Reviewed by Andy Estes.
2250
2251         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2252         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm: Added.
2253         (-[SchemeHandler initWithData:mimeType:]):
2254         (-[SchemeHandler dealloc]):
2255         (-[SchemeHandler webView:startTask:]):
2256         (-[SchemeHandler webView:stopTask:]):
2257         (TEST):
2258
2259 2017-04-14  Bill Ming  <mbbill@gmail.com>
2260
2261         webkit-patch failed to detect git repository
2262         https://bugs.webkit.org/show_bug.cgi?id=170859
2263
2264         Reviewed by Daniel Bates.
2265
2266         Windows cmd does not accept single quoted path. So, using
2267         double quotes here will provide better platform compatibility.
2268
2269         * Scripts/VCSUtils.pm:
2270         (isGitDirectory):
2271         (isGitSVNDirectory):
2272         (svnRevisionForDirectory):
2273         (svnInfoForPath):
2274
2275 2017-04-14  Ryan Haddad  <ryanhaddad@apple.com>
2276
2277         Unreviewed, rolling out r215374.
2278
2279         This change causes LayoutTests to exit early with crashes on
2280         Sierra.
2281
2282         Reverted changeset:
2283
2284         "webkitpy: Ignore previously launched pid when system is under
2285         stress"
2286         https://bugs.webkit.org/show_bug.cgi?id=170741
2287         http://trac.webkit.org/changeset/215374
2288
2289 2017-04-14  Dan Bernstein  <mitz@apple.com>
2290
2291         [ios-simulator] API test WebKit2.AdditionalReadAccessAllowedURLs is failing
2292         https://bugs.webkit.org/show_bug.cgi?id=170856
2293
2294         Disabled the newly-added test in the Simulator, which doesn’t enforce sandboxing.
2295
2296         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm:
2297
2298 2017-04-14  Jonathan Bedard  <jbedard@apple.com>
2299
2300         webkitpy: Ignore previously launched pid when system is under stress
2301         https://bugs.webkit.org/show_bug.cgi?id=170741
2302
2303         Unreviewed infrastructure fix.
2304
2305         Drivers are destroyed between failing layout tests, which is not necessary and
2306         prevents the work-around implemented in https://bugs.webkit.org/show_bug.cgi?id=170741.
2307
2308         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2309         (Worker._kill_driver): Do not destroy drivers when they are stopped.
2310         * Scripts/webkitpy/port/driver.py:
2311         (Driver.stop): Reset driver values set in initializer.
2312
2313 2017-04-14  Andy Estes  <aestes@apple.com>
2314
2315         [ios-simulator] API test WebKit2.WKWebProcessPlugInRangeHandle timing out
2316         https://bugs.webkit.org/show_bug.cgi?id=167594
2317
2318         Re-enabled this API test now that webkit.org/b/161967 is fixed.
2319
2320         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
2321         (TEST):
2322
2323 2017-04-14  Andy Estes  <aestes@apple.com>
2324
2325         [ios-simulator] API test WebKit2.DataDetectionReferenceDate timing out
2326         https://bugs.webkit.org/show_bug.cgi?id=161967
2327
2328         Reviewed by Alexey Proskuryakov.
2329
2330         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
2331         (TEST): Re-enabled WebKit2.DataDetectionReferenceDate.
2332
2333 2017-04-14  Ryan Haddad  <ryanhaddad@apple.com>
2334
2335         Unreviewed, rolling out r215363.
2336
2337         This change causes LayoutTests to exit early with crashes.
2338
2339         Reverted changeset:
2340
2341         "webkitpy: Ignore previously launched pid when system is under
2342         stress"
2343         https://bugs.webkit.org/show_bug.cgi?id=170741
2344         http://trac.webkit.org/changeset/215363
2345
2346 2017-04-14  Jonathan Bedard  <jbedard@apple.com>
2347
2348         webkitpy: Ignore previously launched pid when system is under stress
2349         https://bugs.webkit.org/show_bug.cgi?id=170741
2350
2351         Unreviewed infrastructure fix.
2352
2353         Drivers are destroyed between failing layout tests, which is not necessary and
2354         prevents the work-around implemented in https://bugs.webkit.org/show_bug.cgi?id=170741.
2355
2356         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2357         (Worker._kill_driver): Do not destroy drivers when they are stopped.
2358
2359 2017-04-14  Jonathan Bedard  <jbedard@apple.com>
2360
2361         webkitpy: Ignore previously launched pid when system is under stress
2362         https://bugs.webkit.org/show_bug.cgi?id=170741
2363
2364         Unreviewed infrastructure fix.
2365
2366         Server processes are destroyed in the driver, which is not necessary and prevents
2367         the work-around implemented in https://bugs.webkit.org/show_bug.cgi?id=170741.
2368
2369         * Scripts/webkitpy/port/driver.py:
2370         (Driver.run_test): Do not destroy server process.
2371         (Driver._start): Only create the server process if it is None.
2372         (Driver.stop): Do not destroy server process.
2373
2374 2017-04-13  Dan Bernstein  <mitz@apple.com>
2375
2376         [Cocoa] Allow clients to specify in _WKProcessPoolConfiguration additional directory sandbox extensions
2377         https://bugs.webkit.org/show_bug.cgi?id=170387
2378
2379         Reviewed by Sam Weinig.
2380
2381         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2382         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm: Added.
2383         (TEST):
2384         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLsPlugin.mm: Added.
2385         (-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2386         (-[AdditionalReadAccessAllowedURLsPlugIn dealloc]):
2387         (-[AdditionalReadAccessAllowedURLsPlugIn readStringFromURL:completionHandler:]):
2388         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLsProtocol.h: Added.
2389
2390 2017-04-13  Jonathan Bedard  <jbedard@apple.com>
2391
2392         webkitpy: Ignore previously launched pid when system is under stress
2393         https://bugs.webkit.org/show_bug.cgi?id=170741
2394
2395         Reviewed by David Kilzer.
2396
2397         We have seen cases where xcrun simctl launch will return a pid of a previous
2398         process and the process will appear to be running even though it is crashing.
2399         Ensure that the PID that simulator_process is receiving is not the pid of the
2400         previously run process.
2401
2402         * Scripts/webkitpy/port/simulator_process.py:
2403         (SimulatorProcess._start): Check to make sure we aren't receiving an old PID.
2404
2405 2017-04-13  Jonathan Bedard  <jbedard@apple.com>
2406
2407         Build ImageDiff with host SDK
2408         https://bugs.webkit.org/show_bug.cgi?id=168531
2409
2410         Reviewed by David Kilzer.
2411
2412         ImageDiff should be built and run with the host SDK, not the target SDK.
2413         Build ImageDiff twice, once for the target SDK and once for the host
2414         as an intermediate step towards building for only the host SDK.
2415
2416         * ImageDiff/Makefile: Added.
2417         * Makefile: Add ImageDiff to list of targets.
2418         * Scripts/build-imagediff: Build bmalloc and WTF for the host.
2419         * Scripts/build-webkit: Build ImageDiff for host.
2420         * Scripts/webkitdirs.pm: Export extractNonMacOSHostConfiguration.
2421         (extractNonMacOSHostConfiguration): Remove non-host configuration data from the array.
2422         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl: Added.
2423         * Scripts/webkitpy/port/base.py:
2424         (Port.check_build): Attempt to build image diff if not found.
2425         (Port.check_image_diff): Enable logging flag.
2426         (Port._build_image_diff): Allow webkitpy to build image-diff during testing.
2427
2428 2017-04-12  Alex Christensen  <achristensen@webkit.org>
2429
2430         Clean up SharedBuffer public functions
2431         https://bugs.webkit.org/show_bug.cgi?id=170795
2432
2433         Reviewed by Andreas Kling.
2434
2435         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
2436         (TestWebKitAPI::TEST_F):
2437
2438 2017-04-12  Dan Bernstein  <mitz@apple.com>
2439
2440         [Mac] Future-proof .xcconfig files
2441         https://bugs.webkit.org/show_bug.cgi?id=170802
2442
2443         Reviewed by Tim Horton.
2444
2445         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2446         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2447         * MiniBrowser/Configurations/Base.xcconfig:
2448         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2449         * TestWebKitAPI/Configurations/Base.xcconfig:
2450         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2451         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2452         * WebKitTestRunner/Configurations/Base.xcconfig:
2453         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2454
2455 2017-04-12  Alex Christensen  <achristensen@webkit.org>
2456
2457         Remove unused SharedBuffer::wrapCFDataArray
2458         https://bugs.webkit.org/show_bug.cgi?id=170794
2459
2460         Reviewed by Brady Eidson.
2461
2462         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
2463         (TestWebKitAPI::TEST_F):
2464
2465 2017-04-12  Yusuke Suzuki  <utatane.tea@gmail.com>
2466
2467         [WTF] Introduce Thread class and use RefPtr<Thread> and align Windows Threading implementation semantics to Pthread one
2468         https://bugs.webkit.org/show_bug.cgi?id=170502
2469
2470         Reviewed by Mark Lam.
2471
2472         Mechanical change. Use Thread:: APIs.
2473
2474         * DumpRenderTree/JavaScriptThreading.cpp:
2475         (runJavaScriptThread):
2476         (startJavaScriptThreads):
2477         (stopJavaScriptThreads):
2478         * DumpRenderTree/mac/DumpRenderTree.mm:
2479         (testThreadIdentifierMap):
2480         * TestWebKitAPI/Tests/WTF/Condition.cpp:
2481         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2482         (TestWebKitAPI::runLockTest):
2483         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2484
2485 2017-04-12  Alex Christensen  <achristensen@webkit.org>
2486
2487         Modernize vector adoption
2488         https://bugs.webkit.org/show_bug.cgi?id=170758
2489
2490         Reviewed by Geoffrey Garen.
2491
2492         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
2493         (TestWebKitAPI::TEST_F):
2494
2495 2017-04-11  Dean Jackson  <dino@apple.com>
2496
2497         Disable outdated WritableStream API
2498         https://bugs.webkit.org/show_bug.cgi?id=170749
2499         <rdar://problem/31446233>
2500
2501         Reviewed by Tim Horton.
2502
2503         The API we implement is no longer accurate. Disable it until we
2504         are compatible with the new specification
2505
2506         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2507
2508 2017-04-11  David Quesada  <david_quesada@apple.com>
2509
2510         Add SPI for handling geolocation authorization requests
2511         https://bugs.webkit.org/show_bug.cgi?id=170362
2512         rdar://problem/17508627
2513
2514         Reviewed by Alex Christensen.
2515
2516         Add API tests for the new WKUIDelegate SPI for allowing or denying websites permission
2517         to use geolocation. Adopt the new WKProcessPool._coreLocationProvider property to
2518         provide a stub object to simulate the various configurations of geolocation permissions:
2519         1. The app doesn't have permission to use geolocation.
2520         2. The app is allowed to use geolocation, but the UI delegate denies the web view permission.
2521         3. The app is allowed to use geolocation, and the UI delegate allows the web view permission.
2522
2523         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2524         * TestWebKitAPI/Tests/WebKit2Cocoa/Geolocation.mm: Added.
2525         (-[TestCoreLocationProvider setListener:]):
2526         (-[TestCoreLocationProvider requestGeolocationAuthorization]):
2527         (-[TestCoreLocationProvider start]):
2528         (-[TestCoreLocationProvider stop]):
2529         (-[TestCoreLocationProvider setEnableHighAccuracy:]):
2530         (expectException):
2531         (-[GeolocationTestUIDelegate _webView:requestGeolocationAuthorizationForURL:frame:decisionHandler:]):
2532         (-[GeolocationTestUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2533         (TestWebKitAPI::TEST):
2534         * TestWebKitAPI/Tests/WebKit2Cocoa/GeolocationGetCurrentPositionResult.html: Added.
2535
2536 2017-04-10  Matt Rajca  <mrajca@apple.com>
2537
2538         Change autoplay state to "prevented" when media is paused due to restrictions.
2539         https://bugs.webkit.org/show_bug.cgi?id=170686
2540
2541         Reviewed by Alex Christensen.
2542
2543         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2544         * TestWebKitAPI/Tests/WebKit2/autoplay-muted-with-controls.html: Added test.
2545         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2546         (TEST):
2547
2548 2017-04-11  Yusuke Suzuki  <utatane.tea@gmail.com>
2549
2550         [WebCore][JSC] ResourceUsageData.{timeOfNextEdenCollection,timeOfNextFullCollection} should be MonotonicTime
2551         https://bugs.webkit.org/show_bug.cgi?id=170725
2552
2553         Reviewed by Sam Weinig.
2554
2555         * TestWebKitAPI/Tests/WTF/Time.cpp:
2556         (TestWebKitAPI::TEST):
2557
2558 2017-04-10  Alex Christensen  <achristensen@webkit.org>
2559
2560         Revert r215217
2561         https://bugs.webkit.org/show_bug.cgi?id=170703
2562
2563         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2564
2565 2017-04-10  Alex Christensen  <achristensen@webkit.org>
2566
2567         Continue enabling WebRTC
2568         https://bugs.webkit.org/show_bug.cgi?id=170703
2569
2570         Reviewed by Youenn Fablet.
2571
2572         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2573
2574 2017-04-10  Kocsen Chung  <kocsen_chung@apple.com>
2575
2576         Have parseRevisionProperty use default repo name as the Buildbot key.
2577         https://bugs.webkit.org/show_bug.cgi?id=170696
2578
2579         Reviewed by Daniel Bates.
2580
2581         Previously, we needed to set a key and a fallbackKey when addressing
2582         Buildbot data for Internal. That is no longer necessary as we can make a safe assumption
2583         that the repo name maps exactly to that key for every repository other
2584         than WebKit.
2585
2586         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2587         Set `key = repositoryName` and only use fallback keys when dealing with WebKit.
2588
2589 2017-04-10  Aakash Jain  <aakash_jain@apple.com>
2590
2591         Add test262 JavaScriptCore tests to dashboard
2592         https://bugs.webkit.org/show_bug.cgi?id=170711
2593
2594         Rubber-stamped by Joseph Pecoraro.
2595
2596         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2597         (WebKitBuildbot): Added test262 JSC tests to dashboard.
2598
2599 2017-04-10  Alex Christensen  <achristensen@webkit.org>
2600
2601         REGRESSION(r195479) First main resource load in new WebProcess bypasses content extensions
2602         https://bugs.webkit.org/show_bug.cgi?id=170707
2603         <rdar://problem/27788755>
2604
2605         Reviewed by Tim Horton.
2606
2607         * TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm:
2608         (-[ContentExtensionDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2609         (TEST_F):
2610         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2611         (-[ContentBlockingWebsitePoliciesDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2612         (-[ContentBlockingWebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2613         (TEST):
2614
2615 2017-04-10  Alex Christensen  <achristensen@webkit.org>
2616
2617         Add API to get available content extension identifiers in a WKContentExtensionStore
2618         https://bugs.webkit.org/show_bug.cgi?id=170093
2619
2620         Reviewed by Geoffrey Garen.
2621
2622         * TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm:
2623         (TEST_F):
2624
2625 2017-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
2626
2627         Refactor DataInteractionTests.UnresponsivePageDoesNotHangUI to not check against a fixed time interval
2628         https://bugs.webkit.org/show_bug.cgi?id=170658
2629
2630         Reviewed by Tim Horton.
2631
2632         Uses ignoreSynchronousMessagingTimeoutsForTesting to ensure that this test times out if data interaction
2633         preparation is synchronous, or passes if it is asynchronous.
2634
2635         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2636         (TestWebKitAPI::TEST):
2637         * TestWebKitAPI/cocoa/TestWKWebView.h:
2638         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2639         (-[TestWKWebView initWithFrame:]):
2640         (-[TestWKWebView initWithFrame:configuration:processPoolConfiguration:]):
2641         (-[TestWKWebView _setUpTestWindow:]):
2642
2643 2017-04-10  Brent Fulgham  <bfulgham@apple.com>
2644
2645         [WK2][macOS] Block access to Apple Events before launch.
2646         https://bugs.webkit.org/show_bug.cgi?id=170626
2647         <rdar://problem/16079334>
2648
2649         Reviewed by Alexey Proskuryakov.
2650
2651         Add a new TestWebKitAPI test that fails if Apple Events are sent.
2652
2653         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2654         * TestWebKitAPI/Tests/WebKit2/mac/InjectedBundleAppleEvent.cpp: Added.
2655         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2656         (TestWebKitAPI::didFinishLoadForFrame):
2657         (TestWebKitAPI::TEST):
2658         * TestWebKitAPI/Tests/WebKit2/mac/InjectedBundleAppleEvent_Bundle.cpp: Added.
2659         (TestWebKitAPI::InjectedBundleAppleEventTest::InjectedBundleAppleEventTest):
2660         (TestWebKitAPI::InjectedBundleAppleEventTest::didCreatePage):
2661
2662 2017-04-10  Guillaume Emont  <guijemont@igalia.com>
2663
2664         [JSC] Do not run FTL stress tests on MIPS
2665         https://bugs.webkit.org/show_bug.cgi?id=170684
2666
2667         Reviewed by Carlos Alberto Lopez Perez.
2668
2669         run-jsc-stress-tests does not correctly detect MIPS platforms, and its
2670         logic to detect if the platform supports FTL ignores that MIPS does
2671         not support FTL. This adds detection of MIPS (with the magic number
2672         determined empirically) and fixes the determination of whether we
2673         support FTL.
2674
2675         * Scripts/run-jsc-stress-tests:
2676
2677 2017-04-10  Jonathan Bedard  <jbedard@apple.com>
2678
2679         webkitpy: Increase estimate for processes run by iOS Simulators
2680         https://bugs.webkit.org/show_bug.cgi?id=170678
2681         <rdar://problem/31534061>
2682
2683         Reviewed by Aakash Jain.
2684
2685         Previously, it was estimated that each simulated iOS device would run about 100
2686         processes.  With newer versions of iOS, this is closer to 125.
2687
2688         * Scripts/webkitpy/port/ios_simulator.py:
2689         (IOSSimulatorPort): Increase process estimate from 100 to 125.
2690
2691 2017-04-10  Adrian Perez de Castro  <aperez@igalia.com>
2692
2693         [GTK] Misplaced right click menu on web page due to deprecated gtk_menu_popup()
2694         https://bugs.webkit.org/show_bug.cgi?id=170553
2695
2696         Reviewed by Michael Catanzaro.
2697
2698         Use gtk_menu_popup_at_pointer() and gtk_menu_popup_at_rect() when
2699         building with GTK+ 3.22 or newer. This allows the Wayland GTK+ backend
2700         to properly position popup menus, and also avoids using functions
2701         which were deprecated starting at that GTK+ release.
2702
2703         * MiniBrowser/gtk/BrowserSearchBar.c:
2704         (searchEntryMenuIconPressedCallback):
2705         Update MiniBrowser to use gtk_menu_popup_at_pointer().
2706
2707 2017-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
2708
2709         REGRESSION (r214403): fast/events/drag-to-navigate.html and fast/events/only-valid-drop-targets-receive-file-drop.html failing
2710         https://bugs.webkit.org/show_bug.cgi?id=170677
2711         <rdar://problem/31512633>
2712
2713         Reviewed by Tim Horton.
2714
2715         Fixes two drag and drop LayoutTests by introducing and enabling a TestOptions switch (enableDragDestinationActionLoad)
2716         to allow dropping URLs to trigger page navigation.
2717
2718         * DumpRenderTree/TestOptions.h:
2719         * DumpRenderTree/TestOptions.mm:
2720         (TestOptions::TestOptions):
2721         * DumpRenderTree/mac/DumpRenderTree.mm:
2722         (resetWebViewToConsistentStateBeforeTesting):
2723         * DumpRenderTree/mac/UIDelegate.h:
2724         * DumpRenderTree/mac/UIDelegate.mm:
2725         (-[UIDelegate resetToConsistentStateBeforeTesting:]):
2726         (-[UIDelegate webView:dragDestinationActionMaskForDraggingInfo:]):
2727
2728 2017-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2729
2730         update-webkit-dependency should report $response->message for diagnose
2731         https://bugs.webkit.org/show_bug.cgi?id=170666
2732
2733         Reviewed by Alex Christensen.
2734
2735         * Scripts/update-webkit-dependency: Print $response->message to STDERR if an error happens.
2736
2737 2017-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
2738
2739         Data interaction on an image enclosed by an anchor should vend the anchor's URL
2740         https://bugs.webkit.org/show_bug.cgi?id=170660
2741         <rdar://problem/31043220>
2742
2743         Reviewed by Tim Horton.
2744
2745         Adds two new unit tests covering cases where data interaction is triggered from an image nested underneath an
2746         anchor. In one of the tests, the link has an href, and in the other, its href is missing, in which case we
2747         should fall back to the image URL instead. Also fixes a related unit test that was trying to check selection
2748         rects, but should not be.
2749
2750         See WebCore ChangeLog for more details.
2751
2752         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2753         * TestWebKitAPI/Tests/WebKit2Cocoa/image-in-link-and-input.html: Added.
2754         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2755         (TestWebKitAPI::TEST):
2756
2757 2017-04-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2758
2759         [GTK] Remove the GDK dependency from ImageDiff
2760         https://bugs.webkit.org/show_bug.cgi?id=85299
2761
2762         Reviewed by Žan Doberšek.
2763
2764         Add a cairo only implementation of ImageDiff. We currently have 3 different implementations of ImageDiff: the
2765         Gdk based one used by GTK+ port, the cairo based one used by WinCairo and the CG based one. Most of the code is
2766         actually common in all of them, but it's duplicated. So, I've taken advantage of this patch to refactor the
2767         ImageDiff code to share the common implementation. This patch adds the cross-platform code, and the cairo
2768         implementation and enables it in the GTK+ port. In follow up patches we can move WinCairo to this implementation
2769         and also add CG implementation.
2770
2771         * ImageDiff/CMakeLists.txt:
2772         * ImageDiff/Cairo.cmake: Added.
2773         * ImageDiff/ImageDiff.cpp: Added.
2774         (main):
2775         * ImageDiff/PlatformGTK.cmake:
2776         * ImageDiff/PlatformImage.cpp: Added.
2777         (ImageDiff::PlatformImage::isCompatible):
2778         (ImageDiff::PlatformImage::difference):
2779         * ImageDiff/PlatformImage.h: Added.
2780         * ImageDiff/cairo/PlatformImageCairo.cpp: Added.
2781         (ImageDiff::PlatformImage::createFromStdin):
2782         (ImageDiff::PlatformImage::createFromDiffData):
2783         (ImageDiff::PlatformImage::PlatformImage):
2784         (ImageDiff::PlatformImage::~PlatformImage):
2785         (ImageDiff::PlatformImage::width):
2786         (ImageDiff::PlatformImage::height):
2787         (ImageDiff::PlatformImage::rowBytes):
2788         (ImageDiff::PlatformImage::hasAlpha):
2789         (ImageDiff::PlatformImage::pixels):
2790         (ImageDiff::PlatformImage::writeAsPNGToStdout):
2791         * ImageDiff/gtk/ImageDiff.cpp: Removed.
2792
2793 2017-04-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2794
2795         REGRESSION(r214426): [GTK] Test media/video-click-dblckick-standalone.html started to fail in the bots after r214426
2796         https://bugs.webkit.org/show_bug.cgi?id=170667
2797
2798         Reviewed by Žan Doberšek.
2799
2800         In r214666 we disabled modern media controls runtime feature for the GTK+ port, but layout tests still override
2801         that value.
2802
2803         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2804         (WTR::TestController::updatePlatformSpecificTestOptionsForTest): Disable modern media controls.
2805
2806 2017-04-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2807
2808         WTR: Avoid conversion from platform image to WKImage and then to platform image again when dumping pixel results
2809         https://bugs.webkit.org/show_bug.cgi?id=170653
2810
2811         Reviewed by Tim Horton.
2812
2813         When dumping pixels from a web view snapshot, we create a platform image that is then converted to a WKImage,
2814         which is a ShareableBitmap, so the image is rendered into a graphics context. Then we immediately extract the
2815         platform image back from the WKImage to dump the pixels. We could avoid that conversion by taking the web
2816         snapshot from TestInvocation::dumpPixelsAndCompareWithExpected().
2817
2818         * WebKitTestRunner/PlatformWebView.h: Add PlatformImage typedef and use it as return value of windowSnapshotImage().
2819         * WebKitTestRunner/TestInvocation.cpp:
2820         (WTR::TestInvocation::dumpResults): Pass the WKImage to dumpPixelsAndCompareWithExpected() only when pixel
2821         results were created in the web process.
2822         * WebKitTestRunner/TestInvocation.h: Make WKImage a default paramater of dumpPixelsAndCompareWithExpected().
2823         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2824         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create the cairo surface from the given WKimage in case
2825         of web contents snapshot, and use PlatformWebView::windowSnapshotImage() in case of web view snapshot.
2826         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2827         (WTR::createCGContextFromCGImage): Changed to receive a CGImageRef and renamed.
2828         (WTR::createCGContextFromImage): Get the CGImageRef from the WKImage and call createCGContextFromCGImage().
2829         (WTR::paintRepaintRectOverlay): It receives now the image size instead of the WKImage.
2830         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create the CGContextRef from the WKImage in case of web
2831         contents snpashot, and use PlatformWebView::windowSnapshotImage() in case of web view snapshot.
2832         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2833         (WTR::PlatformWebView::windowSnapshotImage): Return the cairo surface instead of creating a WKImage. Also use
2834         RGB24 format to match what mac does (kCGWindowImageShouldBeOpaque).
2835         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2836         (WTR::PlatformWebView::windowSnapshotImage): Return the CGImageRef instead of creating a WKImage.
2837         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2838         (WTR::PlatformWebView::windowSnapshotImage): Ditto.
2839
2840 2017-04-10  Chris Dumez  <cdumez@apple.com>
2841
2842         Drop Timer::startOneShot() overload taking a double
2843         https://bugs.webkit.org/show_bug.cgi?id=170659
2844
2845         Reviewed by Yusuke Suzuki.
2846
2847         Drop Timer::startOneShot() overload taking a double as people should use Seconds type now.
2848
2849         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2850         (TestWebKitAPI::TEST):
2851         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2852         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2853
2854 2017-04-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2855
2856         [WK2] Add infrastructure to perform actions after an asynchronous position information request finishes
2857         https://bugs.webkit.org/show_bug.cgi?id=170658
2858         <rdar://problem/31431450>
2859
2860         Reviewed by Tim Horton.
2861
2862         Adds a new test verifying that when a web page is unresponsive, the process of preparing for data interaction
2863         does not also cause the UI process to spin. We assume here that the call to prepare must be asynchronous, so it
2864         should complete before the unresponsiveness timeout is triggered.
2865
2866         See WebKit2 ChangeLog for more details.
2867
2868         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2869         (TestWebKitAPI::TEST):
2870
2871 2017-04-09  Chris Dumez  <cdumez@apple.com>
2872
2873         Drop Timer::startRepeating() overload taking a double
2874         https://bugs.webkit.org/show_bug.cgi?id=170656
2875
2876         Reviewed by Yusuke Suzuki.
2877
2878         Drop Timer::startRepeating() overload taking a double as people should use Seconds type now.
2879
2880         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2881         (TestWebKitAPI::TEST):
2882
2883 2017-04-09  Youenn Fablet  <youenn@apple.com>
2884
2885         Resync WPT tests up to 23cd07d4685d81024b7440e042f8bbdb33e7ddec
2886         https://bugs.webkit.org/show_bug.cgi?id=170647
2887
2888         Reviewed by Sam Weinig.
2889
2890         * Scripts/webkitpy/common/checkout/scm/git.py:
2891         (Git.fetch): Fetching origin remote in case there is more than one.
2892
2893 2017-04-08  Simon Fraser  <simon.fraser@apple.com>
2894
2895         Update CSSProperties.json with correct fill-and-stroke status, and other cleanup
2896         https://bugs.webkit.org/show_bug.cgi?id=170643
2897
2898         Reviewed by Chris Dumez.
2899         
2900         Update the CSSProperties.json style checker to allow:
2901             - comments in codegen_properties
2902             - obsolete-category and obsolete-url in specification blocks
2903             - renamed "done" to "supported"
2904             
2905         Fix some references to codegen_properties to be codegen-properties.
2906
2907         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2908         (JSONCSSPropertiesChecker.validate_status_type):
2909         (JSONCSSPropertiesChecker.validate_property_specification):
2910         (JSONCSSPropertiesChecker.check_codegen_properties):
2911
2912 2017-04-08  Youenn Fablet  <youenn@apple.com>
2913
2914         WebRTC tests gardening
2915         https://bugs.webkit.org/show_bug.cgi?id=170508
2916
2917         Reviewed by Eric Carlson.
2918
2919         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2920
2921 2017-04-07  Keith Miller  <keith_miller@apple.com>
2922
2923         Add a PriorityQueue class
2924         https://bugs.webkit.org/show_bug.cgi?id=170579
2925
2926         Reviewed by Saam Barati.
2927
2928         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2929         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp: Added.
2930         (operator  _z ):
2931         (enqueue):
2932         (dequeue):
2933         (TEST):
2934         (compareMove):
2935
2936 2017-04-07  Ryosuke Niwa  <rniwa@webkit.org>
2937
2938         Replace ES6SampleBench by ARES-6 in run-benchmark
2939         https://bugs.webkit.org/show_bug.cgi?id=170585
2940
2941         Reviewed by Saam Barati.
2942
2943         Updated the plan file for ES6SampleBench to run ARES-6 instead. Also increased the number of iterations
2944         from 4 to 8 to match teh default, and reduced the number of browser instances to use from 5 to 3.
2945
2946         * Scripts/webkitpy/benchmark_runner/data/patches/ARES-6.patch: Renamed from ES6SampleBench.patch.
2947         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan: Renamed from es6bench.plan.
2948
2949 2017-04-07  Myles C. Maxfield  <mmaxfield@apple.com>
2950
2951         REGRESSION(r211382): Complex text with justification erroneously overflows containers
2952         https://bugs.webkit.org/show_bug.cgi?id=170399
2953         <rdar://problem/31442008>
2954
2955         Reviewed by Simon Fraser.
2956
2957         Check for the invariant that the sum of the advances is equal to m_totalWidth.
2958
2959         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2960         (TestWebKitAPI::TEST_F):
2961
2962 2017-04-07  Ryan Haddad  <ryanhaddad@apple.com>
2963
2964         [ios-simulator] API test WebKit2.WKWebProcessPlugInRangeHandle timing out
2965         https://bugs.webkit.org/show_bug.cgi?id=167594
2966
2967         Unreviewed test gardening.
2968
2969         Disable this test because it is still timing out on the bots.
2970
2971         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
2972         (TEST):
2973
2974 2017-04-07  Jonathan Bedard  <jbedard@apple.com>
2975
2976         REGRESSION (r214553): Allow layout-tests to be run from Xcode without re-directing stdout, stdin and stderr
2977         https://bugs.webkit.org/show_bug.cgi?id=170601
2978         <rdar://problem/31492696>
2979
2980         Reviewed by Simon Fraser.
2981
2982         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
2983         (setUpIOSLayoutTestCommunication): Skip TCP setup if no port is in the environment.
2984         (tearDownIOSLayoutTestCommunication): Only teardown if TCP was used.
2985
2986 2017-04-07  Aakash Jain  <aakash_jain@apple.com>
2987
2988         Add support for test262 JavaScriptCore tests
2989         https://bugs.webkit.org/show_bug.cgi?id=170523
2990
2991         Reviewed by Daniel Bates.
2992
2993         * BuildSlaveSupport/build.webkit.org-config/config.json: Added bot433 and bot434.
2994         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2995         (RunTest262Tests): Added class to run Test262 tests.
2996         (RunTest262Tests.start): Added.
2997         (RunTest262Tests.countFailures): Method to count the failures.
2998         (Test262Factory): Added Test262 factory class.
2999         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3000         (RunTest262TestsTest): Added unit tests.
3001         (RunTest262TestsTest.assertResults): Helper method.
3002         (RunTest262TestsTest.test_no_regressions_output): Added test case.
3003         (test_failure_output): Same. 
3004         (test_failures_output): Same.
3005
3006 2017-04-07  Caio Lima  <ticaiolima@gmail.com>
3007
3008         [JSC] Change --debug option to --debugger
3009         https://bugs.webkit.org/show_bug.cgi?id=170587
3010
3011         Reviewed by Keith Miller.
3012
3013         * Scripts/run-jsc:
3014
3015         This patch is changing the new debugger flag for Tools/Scripts/run-jsc
3016         to --debugger to avoid shadowing --debug flag used to run JSC with
3017         Debug build.
3018
3019 2017-04-07  Brent Fulgham  <bfulgham@apple.com>
3020
3021         WebKit should percent encode single quotes in query strings
3022         https://bugs.webkit.org/show_bug.cgi?id=170561
3023         <rdar://problem/7415154>
3024
3025         Reviewed by Alex Christensen.
3026
3027         Add a test case for single-quote in the URL query string.
3028
3029         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3030
3031 2017-04-06  Myles C. Maxfield  <mmaxfield@apple.com>
3032
3033         Make FontWithFeatures test font pass OTS
3034         https://bugs.webkit.org/show_bug.cgi?id=169788
3035
3036         Reviewed by Tim Horton.
3037
3038         OTS, or the OpenType Sanitizer, is a check which tells if fonts are properly formed.
3039         Previously, our FontWithFeatures test font did not pass this check. This patch updates
3040         the font to pass the checks. Now, we can use this font on other platforms, and
3041         contribute the font to the W3C for testing the CSS Fonts level 3 spec.
3042
3043         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
3044         (Generator::appendCFFTable):
3045         (Generator::Feature::operator<):
3046         (Generator::appendGSUBTable):
3047         (Generator::appendOS2Table):
3048         (Generator::appendFormat4CMAPTable):
3049         (Generator::appendHEADTable):
3050         (Generator::appendHHEATable):
3051         (Generator::NameRecord::operator<):
3052         (Generator::appendNameSubtable):
3053         (Generator::appendNAMETable):
3054
3055 2017-04-06  Alexey Proskuryakov  <ap@apple.com>
3056
3057         Disable flaky WebKit2.ResizeWithHiddenContentDoesNotHang
3058         for https://bugs.webkit.org/show_bug.cgi?id=170195
3059
3060         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
3061
3062 2017-04-06  Ryan Haddad  <ryanhaddad@apple.com>
3063
3064         Unreviewed, rolling out r215046.
3065
3066         This change broke internal builds.
3067
3068         Reverted changeset:
3069
3070         "WebRTC tests gardening"
3071         https://bugs.webkit.org/show_bug.cgi?id=170508
3072         http://trac.webkit.org/changeset/215046
3073
3074 2017-04-06  Youenn Fablet  <youenn@apple.com>
3075
3076         WebRTC tests gardening
3077         https://bugs.webkit.org/show_bug.cgi?id=170508
3078
3079         Reviewed by Eric Carlson.
3080
3081         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3082
3083 2017-04-06  Jonathan Bedard  <jbedard@apple.com>
3084
3085         REGRESSION: Simulators failing to install after launch_app times out
3086         <rdar://problem/31478107>
3087
3088         Unreviewed infrastructure fix.
3089
3090         * Scripts/webkitpy/xcode/simulated_device.py:
3091         (SimulatedDevice.launch_app._install_timeout): Raise RuntimeError, not Exception.
3092
3093 2017-04-05  Joseph Pecoraro  <pecoraro@apple.com>
3094
3095         test262: module test progressions need updated expectations (@@iterator changes)
3096         https://bugs.webkit.org/show_bug.cgi?id=170535
3097
3098         Reviewed by Saam Barati.
3099
3100         * Scripts/run-jsc-stress-tests:
3101         Add :failDueToOutdatedOrBadTest to distinguish between a test failure
3102         in JavaScriptCore or an outdated or incorrect test262 test.
3103
3104 2017-04-05  Joseph Pecoraro  <pecoraro@apple.com>
3105
3106         Remove run-jsc-stress-tests benign warning about otool '-S' switch
3107         https://bugs.webkit.org/show_bug.cgi?id=170527
3108
3109         Reviewed by Aakash Jain.
3110
3111         * Scripts/run-jsc-stress-tests:
3112         The switch is not necessary and produces an error.
3113
3114 2017-04-05  Jonathan Bedard  <jbedard@apple.com>
3115
3116         webkitpy: Add pid logging for simulator processes
3117         https://bugs.webkit.org/show_bug.cgi?id=170505
3118
3119         Reviewed by Alexey Proskuryakov.
3120
3121         * Scripts/webkitpy/port/simulator_process.py:
3122         (SimulatorProcess._start.handler): Add pid to exception.
3123         (SimulatorProcess._start): Ditto.
3124         * Scripts/webkitpy/xcode/simulated_device.py:
3125         (SimulatedDevice.launch_app): Log pid when the process fails to launch and when
3126         a pid is successfully returned.
3127
3128 2017-04-05  Ryan Haddad  <ryanhaddad@apple.com>
3129
3130         Unreviewed, rolling out r214932.
3131
3132         This change broke an internal build.
3133
3134         Reverted changeset:
3135
3136         "[ios-simulator] API test WebKit2.DataDetectionReferenceDate
3137         timing out"
3138         https://bugs.webkit.org/show_bug.cgi?id=161967
3139         http://trac.webkit.org/changeset/214932
3140
3141 2017-04-05  Ryan Haddad  <ryanhaddad@apple.com>
3142
3143         Unreviewed, rolling out r214962.
3144
3145         Roll r214937 back in because it wasn't at fault for the build
3146         breakage.
3147
3148         Reverted changeset:
3149
3150         "Unreviewed, rolling out r214937."
3151         https://bugs.webkit.org/show_bug.cgi?id=170365
3152         http://trac.webkit.org/changeset/214962
3153
3154 2017-04-05  Ryan Haddad  <ryanhaddad@apple.com>
3155
3156         Unreviewed, rolling out r214937.
3157
3158         This change broke an internal build.
3159
3160         Reverted changeset:
3161
3162         "REGRESSION (r202472): Data Detection overwrites existing
3163         links in detected ranges"
3164         https://bugs.webkit.org/show_bug.cgi?id=170365
3165         http://trac.webkit.org/changeset/214937
3166
3167 2017-04-05  Jonathan Bedard  <jbedard@apple.com>
3168
3169         Increase timeouts for simulator testing
3170         Unreviewed infrastructure fix.
3171
3172         r214895 was not sufficient, increasing timeouts again.
3173
3174         * Scripts/webkitpy/xcode/simulated_device.py:
3175         (SimulatedDevice.install_app): Increase timeout from 3 to 10 seconds.
3176
3177 2017-04-05  Aakash Jain  <aakash_jain@apple.com>
3178
3179         Formatting fix to remove extra space.
3180
3181         Unreviewed formatting fix.
3182
3183         * Scripts/webkitdirs.pm:
3184         (isEmbeddedWebKit): Remove extra space.
3185
3186 2017-04-05  Aakash Jain  <aakash_jain@apple.com>
3187
3188         Rename isIOSLikeWebKit to isEmbeddedWebKit.
3189
3190         Rubber-stamped by Alexey Proskuryakov. 
3191
3192         * Scripts/webkitdirs.pm:
3193         (isEmbeddedWebKit): Added
3194         (isIOSLikeWebKit): Deleted.
3195
3196 2017-04-05  Alex Christensen  <achristensen@webkit.org>
3197
3198         Fix CMake build.
3199
3200         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:
3201         * TestRunnerShared/spi/CoreGraphicsSPI.h: Removed.
3202         * TestRunnerShared/spi/CoreGraphicsTestSPI.h: Copied from Tools/TestRunnerShared/spi/CoreGraphicsSPI.h.
3203         There is a CoreGraphicsSPI.h in WebCore and the CMake build was finding the wrong one.
3204         Since we just inherit the include paths from WebCore in the CMake build and since this SPI is only used for testing,
3205         I just renamed CoreGraphicsSPI.h to CoreGraphicsTestSPI.h to avoid any name collisions.
3206         * WebKitTestRunner/PlatformMac.cmake:
3207         Add some missing files.
3208         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3209
3210 2017-04-05  Keith Miller  <keith_miller@apple.com>
3211
3212         Add debug option to run-jsc script
3213         https://bugs.webkit.org/show_bug.cgi?id=170503
3214
3215         Reviewed by Yusuke Suzuki.
3216
3217         Adds a new option to the run-jsc script so that when passed
3218         "--debug" it will wrap the jsc call with an lldb invocation. If
3219         someone wishes to use a different debugger they can set the
3220         DEBUGGER environment variable. Additionally, run-jsc now exits
3221         with the exit status of the jsc call.
3222
3223         * Scripts/run-jsc:
3224
3225 2017-04-05  Andy Estes  <aestes@apple.com>
3226
3227         REGRESSION (r202472): Data Detection overwrites existing links in detected ranges
3228         https://bugs.webkit.org/show_bug.cgi?id=170365
3229         <rdar://problem/29205721>
3230
3231         Reviewed by Tim Horton.
3232
3233         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
3234         (expectLinkCount): Changed to only query links with the x-apple-data-detectors attribute.
3235         (TEST): Re-enabled the test, which now passes.
3236
3237 2017-04-05  Andy Estes  <aestes@apple.com>
3238
3239         [ios-simulator] API test WebKit2.WKWebProcessPlugInRangeHandle timing out
3240         https://bugs.webkit.org/show_bug.cgi?id=167594
3241
3242         Re-enabled this API test now that webkit.org/b/161967 is fixed.
3243
3244         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
3245         (TEST):
3246
3247 2017-04-05  Andy Estes  <aestes@apple.com>
3248
3249         [ios-simulator] API test WebKit2.DataDetectionReferenceDate timing out
3250         https://bugs.webkit.org/show_bug.cgi?id=161967
3251
3252         Reviewed by Alexey Proskuryakov.
3253
3254         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
3255         (TEST): Re-enabled WebKit2.DataDetectionReferenceDate.
3256
3257 2017-04-04  Simon Fraser  <simon.fraser@apple.com>
3258
3259         Various settings in Minibrowser are off by default, and should be on
3260         https://bugs.webkit.org/show_bug.cgi?id=170465
3261         rdar://problem/31421543
3262
3263         Reviewed by Tim Horton.
3264
3265         Explicitly set preferences that should be on by default to enabled, if they have not been
3266         set previously.
3267
3268         * MiniBrowser/mac/SettingsController.m:
3269         (-[SettingsController init]):
3270
3271 2017-04-04  JF Bastien  <jfbastien@apple.com>
3272
3273         Add JF Bastien as reviewer
3274         https://bugs.webkit.org/show_bug.cgi?id=170481
3275
3276         Reviewed by Mark Lam.
3277
3278         * Scripts/webkitpy/common/config/contributors.json:
3279
3280 2017-04-04  Jonathan Bedard  <jbedard@apple.com>
3281
3282         Increase timeouts for simulator testing
3283
3284         Unreviewed infrastructure fix.
3285
3286         * Scripts/webkitpy/port/simulator_process.py:
3287         (SimulatorProcess._start): Increase timeout from 3 to 6 seconds.
3288         * Scripts/webkitpy/xcode/simulated_device.py:
3289         (SimulatedDevice.install_app): Increase timeout from 1 to 3 seconds.
3290
3291 2017-04-04  Tim Horton  <timothy_horton@apple.com>
3292
3293         [Mac] -[WKWebView findMatchesForString:relativeToMatch:findOptions:maxResults:resultCollector:] invokes the resultCollector with didWrap = NO even when it wraps
3294         https://bugs.webkit.org/show_bug.cgi?id=165801
3295         <rdar://problem/29649535>
3296
3297         Reviewed by Wenson Hsieh.
3298
3299         * TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm:
3300         (TEST):
3301         Add some tests for wrapping finds.
3302
3303 2017-04-03  Joseph Pecoraro  <pecoraro@apple.com>
3304
3305         Add some new patterns to filter-build-webkit
3306         https://bugs.webkit.org/show_bug.cgi?id=170429
3307
3308         Reviewed by Alexey Proskuryakov.
3309
3310         * Scripts/filter-build-webkit:
3311         (setOutputFormatOption):
3312
3313 2017-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
3314
3315         Data interaction should register type identifiers in order of priority
3316         https://bugs.webkit.org/show_bug.cgi?id=170428
3317         <rdar://problem/30633296>
3318
3319         Reviewed by Tim Horton.
3320
3321         Augments existing unit tests to check for the existence and priority of type identifiers in the UIItemProviders
3322         created upon starting data interaction. Also fixes a race condition in one of the unit tests and adds a new unit
3323         test for data interaction from a textarea to an input.
3324
3325         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3326         (checkTypeIdentifierPrecedesOtherTypeIdentifier):
3327         (TestWebKitAPI::TEST):
3328         * TestWebKitAPI/ios/DataInteractionSimulator.h:
3329         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3330         (-[DataInteractionSimulator _advanceProgress]):
3331         (-[DataInteractionSimulator sourceItemProviders]):
3332         (-[DataInteractionSimulator _webView:showCustomSheetForElement:]):
3333
3334 2017-04-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3335
3336         [GTK][JHBuild] Update mesa repository url for tarballs
3337         https://bugs.webkit.org/show_bug.cgi?id=170431
3338
3339         Reviewed by Michael Catanzaro.
3340
3341         * gtk/jhbuild.modules:
3342
3343 2017-04-03  Joseph Pecoraro  <pecoraro@apple.com>
3344
3345         TestWebKitAPI: Warning: Multiple build commands for Ahem.ttf
3346         https://bugs.webkit.org/show_bug.cgi?id=170430
3347
3348         Reviewed by Alexey Proskuryakov.
3349
3350         * TestWebKitAPI/Tests/mac/Ahem.ttf: Removed.
3351         Eliminate one of the copies of Ahem.ttf.
3352
3353         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3354         Once eliminated, there is now only one Ahem.ttf that is copied
3355         to the Resources bundle. Drive-by sort the project file.
3356
3357 2017-04-03  Simon Fraser  <simon.fraser@apple.com>
3358
3359         Allow MiniBrowser windows to receive local file drags again
3360         https://bugs.webkit.org/show_bug.cgi?id=170422
3361
3362         Reviewed by Wenson Hsieh.
3363
3364         Adopt the new UIDelegate SPI to allow drops.
3365
3366         * MiniBrowser/mac/WK2BrowserWindowController.m:
3367         (-[WK2BrowserWindowController _webView:dragDestinationActionMaskForDraggingInfo:]):
3368
3369 2017-04-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3370
3371         [GTK][JHBuild] Fetch libvpx from a release tarball instead of git
3372         https://bugs.webkit.org/show_bug.cgi?id=170426
3373
3374         Reviewed by Michael Catanzaro.
3375
3376         * gtk/jhbuild.modules:
3377
3378 2017-04-03  Nan Wang  <n_wang@apple.com>
3379
3380         AX: Expose link children when doing search predication on iOS
3381         https://bugs.webkit.org/show_bug.cgi?id=170424
3382         <rdar://problem/31413335>
3383
3384         Reviewed by Chris Fleizach.
3385
3386         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3387         (AccessibilityUIElement::uiElementForSearchPredicate):
3388         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3389         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
3390
3391 2017-04-03  Brian Burg  <bburg@apple.com>
3392
3393         run-safari should support launching with custom language and locale
3394         https://bugs.webkit.org/show_bug.cgi?id=170397
3395
3396         Reviewed by Alexey Proskuryakov.
3397
3398         Hook up -AppleLanguages and -AppleLocale to command line options.
3399
3400         * Scripts/webkitdirs.pm:
3401         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded):
3402         (argumentsForRunAndDebugMacWebKitApp):
3403
3404 2017-04-03  Jonathan Bedard  <jbedard@apple.com>
3405
3406         webkitpy: Provide option to skip install
3407         https://bugs.webkit.org/show_bug.cgi?id=170344
3408
3409         Reviewed by Alexey Proskuryakov.
3410
3411         Installing can take time for on device testing.  Provide an option to skip install
3412         and use whatever driver is currently installed on the device or simulator.
3413
3414         * Scripts/webkitpy/port/base.py:
3415         (Port.check_build): Do not check driver if skipping install.
3416         * Scripts/webkitpy/port/factory.py:
3417         (platform_options): Add '--no-install' option.
3418         * Scripts/webkitpy/port/ios.py:
3419         (IOSPort.setup_test_run): Check install option before installing.
3420
3421 2017-04-03  Keith Miller  <keith_miller@apple.com>
3422
3423         WebAssembly: Update spec tests
3424         https://bugs.webkit.org/show_bug.cgi?id=170361
3425
3426         Rubber-stamped by Saam Barati.
3427
3428         Update the runner to know the new wasm spec test harness code.
3429
3430         * Scripts/run-jsc-stress-tests:
3431
3432 2017-04-01  Alexey Proskuryakov  <ap@apple.com>
3433
3434         Rolling back <https://trac.webkit.org/r214697>, as it made WebKit2.DataDetectionReferenceDate time out.
3435
3436         Was REGRESSION (r202472): Data Detection overwrites existing links in detected ranges
3437         https://bugs.webkit.org/show_bug.cgi?id=170365
3438
3439         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
3440
3441 2017-04-01  Csaba Osztrogonác  <ossy@webkit.org>
3442
3443         Mac cmake buildfix after 214586.
3444         https://bugs.webkit.org/show_bug.cgi?id=170381
3445
3446         Unreviewed speculative buildfix.
3447
3448         * WebKitTestRunner/PlatformMac.cmake:
3449
3450 2017-04-01  Csaba Osztrogonác  <ossy@webkit.org>
3451
3452         Unreviewed speculative Mac cmake buildfix after r214586, just for fun.
3453         https://bugs.webkit.org/show_bug.cgi?id=161675
3454
3455         * WebKitTestRunner/PlatformMac.cmake:
3456
3457 2017-03-31  Jonathan Bedard  <jbedard@apple.com>
3458
3459         webkitpy: Add target host concept
3460         https://bugs.webkit.org/show_bug.cgi?id=170186
3461         <rdar://problem/31301797>
3462
3463         Reviewed by Alexey Proskuryakov.
3464
3465         Adding the idea of a target host. Target hosts are objects conforming to the
3466         structure of the SystemHost object in Scripts/webkitpy/common/system/systemhost.py
3467         Target hosts are the hosts associated with a worker process.
3468
3469         * Scripts/webkitpy/common/system/filesystem.py:
3470         (FileSystem.map_base_host_path): Convert a path from an absolute path on the base
3471         host to an absolute path on this host.
3472         (FileSystem.move_to_base_host): Move file from this host to the base host.
3473         (FileSystem.move_from_base_host): Move file from the base host to this host.
3474         (FileSystem.copy_to_base_host): Copy file from this host to the base host.
3475         (FileSystem.copy_from_base_host): Copy file from the base host to this host.
3476         * Scripts/webkitpy/common/system/filesystem_mock.py:
3477         (MockFileSystem.map_base_host_path): Convert a path from an absolute path on the base
3478         host to an absolute path on this host.
3479         (MockFileSystem.move_to_base_host): Move file from this host to the base host.
3480         (MockFileSystem.move_from_base_host): Move file from the base host to this host.
3481         (MockFileSystem.copy_to_base_host): Copy file from this host to the base host.
3482         (MockFileSystem.copy_from_base_host): Copy file from the base host to this host.
3483         * Scripts/webkitpy/port/base.py:
3484         (Port.target_host): Return host determined by worker number.
3485         (Port.abspath_for_test): Accept optional target_host argument to return location
3486         of test on a target host.
3487         (Port._driver_tempdir): Accept optional target_host argument to return a temporary
3488         directory on a target host.
3489         (Port.sample_process): Accept optional target_host argument to sample process on
3490         a target host.
3491         * Scripts/webkitpy/port/darwin.py:
3492         (DarwinPort.sample_process): Run sample process on target host.
3493         (DarwinPort.sample_file_path): Accept directory for file.
3494         (DarwinPort.spindump_file_path): Ditto.
3495         * Scripts/webkitpy/port/darwin_testcase.py:
3496         (DarwinTest.test_spindump): Check file movement.
3497         (DarwinTest.test_sample_process): Ditto.
3498         (DarwinTest.test_sample_process_exception):
3499         * Scripts/webkitpy/port/driver.py:
3500         (Driver.__init__): Add and set self._target_host variable.
3501         (Driver._start): Pass target host to _driver_tempdir().
3502         (Driver.stop): Call the target host's rmtree.
3503         (Driver._check_for_driver_timeout): Pass target host to sample_process.
3504         (Driver._check_for_driver_crash_or_unresponsiveness): Ditto.
3505         (Driver._command_from_driver_input): Pass target host to abspath_for_test and map
3506         layout test directory to target host.
3507         * Scripts/webkitpy/port/ios.py:
3508         (IOSPort):
3509         (IOSPort.target_host): Replaced device_for_worker_number.
3510         (IOSPort.setup_test_run): Replace device_for_worker_number with target_host.
3511         (IOSPort.device_for_worker_number): Replaced with target_host.
3512         * Scripts/webkitpy/port/server_process.py:
3513         (ServerProcess.__init__): Accept target_host instead of worker_number.
3514         (ServerProcess._start): Replace _host with _target_host.
3515         (ServerProcess._handle_timeout): Ditto.
3516         (ServerProcess._kill): Ditto.
3517         * Scripts/webkitpy/port/simulator_process.py:
3518         (SimulatorProcess.__init__): Accept target_host instead of worker_number.
3519         (SimulatorProcess._start): Replace _device with _target_host.
3520         (SimulatorProcess.stop): Ditto.
3521         (SimulatorProcess._kill): Deleted.
3522
3523 2017-03-31  Jonathan Bedard  <jbedard@apple.com>
3524
3525         Unreviewed fix after r214569
3526         https://bugs.webkit.org/show_bug.cgi?id=170255
3527
3528         Unreviewed infrastructure fix.
3529
3530         * Scripts/webkitpy/port/ios.py:
3531         (IOSPort.clean_up_test_run): Check if the device is defined before teardown.
3532
3533 2017-03-31  Andy Estes  <aestes@apple.com>
3534
3535         REGRESSION (r202472): Data Detection overwrites existing links in detected ranges
3536         https://bugs.webkit.org/show_bug.cgi?id=170365
3537         <rdar://problem/29205721>
3538
3539         Reviewed by Tim Horton.
3540
3541         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
3542         (expectLinkCount): Changed to only query links with the x-apple-data-detectors attribute.
3543         (TEST): Re-enabled the test, which now passes.
3544
3545 2017-03-31  Tim Horton  <timothy_horton@apple.com>
3546
3547         Mail can get stuck underneath FindController::findStringMatches after searching in a long message
3548         https://bugs.webkit.org/show_bug.cgi?id=170326
3549         <rdar://problem/30330395>
3550
3551         Reviewed by Simon Fraser.
3552
3553         * TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm:
3554         (TEST):
3555
3556 2017-03-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3557
3558         Unreviewed. Fix WTR crashes in GTK+ port after r214413.
3559
3560         Fixes: http/tests/ssl/upgrade-origin-usage.html
3561                http/tests/websocket/tests/hybi/network-process-crash-error.html
3562                http/tests/websocket/tests/hybi/simple-wss.html
3563
3564         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3565         (WTR::TestController::platformContext): Return the context.
3566
3567 2017-03-30  Sam Weinig  <sam@webkit.org>
3568
3569         Expose the WKView SPI, _prepareForMoveToWindow:withCompletionHandler as WKWebView SPI
3570         https://bugs.webkit.org/show_bug.cgi?id=170315
3571
3572         Reviewed by Simon Fraser.
3573
3574         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3575         * TestWebKitAPI/Tests/WebKit2Cocoa/PrepareForMoveToWindow.mm: Added.
3576         Add test showing the completion handler is called.
3577
3578 2017-03-30  Filip Pizlo  <fpizlo@apple.com>
3579
3580         Air should support linear scan for optLevel<2
3581         https://bugs.webkit.org/show_bug.cgi?id=170161
3582
3583         Reviewed by Saam Barati.
3584         
3585         This makes us run a bunch of JS tests at optLevel=1 to force testing of this new compiler
3586         pipeline.
3587
3588         * Scripts/run-jsc-stress-tests:
3589
3590 2017-03-30  Aakash Jain  <aakash_jain@apple.com>
3591
3592         Support tvOS and watchOS in webkitdirs.pm
3593         https://bugs.webkit.org/show_bug.cgi?id=170267
3594
3595         Reviewed by Alexey Proskuryakov.
3596
3597         * Scripts/webkitdirs.pm:
3598         (determineXcodeSDK): Evaluate sdk for tvos and watchos.
3599         (xcodeSDKPlatformName): Added support for tvos and watchos.
3600         (determinePortName): Same.
3601         (isAppleCocoaWebKit): Same.
3602         (willUseAppleTVDeviceSDK): Added.
3603         (willUseAppleTVSimulatorSDK): Added.
3604         (willUseWatchDeviceSDK): Added.
3605         (willUseWatchSimulatorSDK): Added.
3606         (isTVOSWebKit): Added.
3607         (isWATCHOSWebKit): Added.
3608         (isIOSLikeWebKit): Added.
3609
3610 2017-03-30  Wenson Hsieh  <wenson_hsieh@apple.com>
3611
3612         [WK2] Touches should not cancel when showing a custom action sheet while data interaction is active
3613         https://bugs.webkit.org/show_bug.cgi?id=170291
3614         <rdar://problem/31301388>
3615
3616         Reviewed by Tim Horton.
3617
3618         Adds support for testing how the custom action sheet presentation codepath interacts with data interaction, as
3619         well as a new unit test. In this case, we force data interaction to fail if touches are canceled on the
3620         shared UIApplication, and verify that data interaction completes successfully.
3621
3622         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3623         (TestWebKitAPI::TEST):
3624         * TestWebKitAPI/ios/DataInteractionSimulator.h:
3625         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3626         (-[DataInteractionSimulatorApplication _cancelAllTouches]):
3627         (-[DataInteractionSimulator initWithWebView:]):
3628         (-[DataInteractionSimulator simulateAllTouchesCanceled:]):
3629         (-[DataInteractionSimulator runFrom:to:]):
3630         (-[DataInteractionSimulator _advanceProgress]):
3631         (-[DataInteractionSimulator _webView:showCustomSheetForElement:]):
3632
3633 2017-03-30  Per Arne Vollan  <pvollan@apple.com>
3634
3635         [Win] Pass close_fds = True in Python popen call.
3636         https://bugs.webkit.org/show_bug.cgi?id=170172
3637
3638         Reviewed by Brent Fulgham.
3639
3640         This was previously not supported on Windows, but in Python 2.7.10 it is.
3641
3642         * Scripts/webkitpy/common/system/executive.py:
3643         (Executive._should_close_fds):
3644         * Scripts/webkitpy/port/server_process.py:
3645         (ServerProcess._start):
3646
3647 2017-03-30  Aakash Jain  <aakash_jain@apple.com>
3648
3649         Change my status to be a WebKit reviewer.
3650
3651         Unreviewed status update edit.
3652
3653         * Scripts/webkitpy/common/config/contributors.json:
3654
3655 2017-03-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3656
3657         Change my status to be a WebKit reviewer.
3658
3659         Unreviewed status update edit.
3660
3661         * Scripts/webkitpy/common/config/contributors.json:
3662
3663 2017-03-29  Tim Horton  <timothy_horton@apple.com>