[Chromium] Enable AtomicString && CString && WTFString && StringImpl unit tests
[WebKit-https.git] / Tools / ChangeLog
1 2012-08-23  Julien Chaffraix  <jchaffraix@webkit.org>
2
3         [Chromium] Enable AtomicString && CString && WTFString && StringImpl unit tests
4         https://bugs.webkit.org/show_bug.cgi?id=94871
5
6         Reviewed by Benjamin Poulain.
7
8         * TestWebKitAPI/TestWebKitAPI.gypi:
9         Added the missing files to Chromium's build system.
10
11 2012-08-23  Raphael Kubo da Costa  <rakuco@webkit.org>
12
13         [watchlist] Unreviewed, subscribe to WebKit2-EFL bugs.
14
15         * Scripts/webkitpy/common/config/watchlist:
16
17 2012-08-23  Ryosuke Niwa  <rniwa@webkit.org>
18
19         Replay tests take forever to load
20         https://bugs.webkit.org/show_bug.cgi?id=94764
21
22         Reviewed by Adam Barth.
23
24         Don't load about:blank at the beginning. This appears to clog the DRT.
25
26         * Scripts/webkitpy/performance_tests/perftest.py:
27         (ReplayPerfTest.run_single):
28         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
29         (TestReplayPerfTest.test_run_single):
30         (TestReplayPerfTest.test_run_single_fails_when_output_has_error):
31
32 2012-08-23  Kenneth Russell  <kbr@google.com>
33
34         Unreviewed, rolling out r126497.
35         http://trac.webkit.org/changeset/126497
36         https://bugs.webkit.org/show_bug.cgi?id=94764
37
38         Caused webkitpy-test step to start failing.
39
40         * Scripts/webkitpy/performance_tests/perftest.py:
41         (ReplayPerfTest.run_single):
42
43 2012-08-23  Emil A Eklund  <eae@chromium.org>
44
45         Add saturation arithmetic support to FractionalLayoutUnit
46         https://bugs.webkit.org/show_bug.cgi?id=94364
47
48         Reviewed by Benjamin Poulain.
49
50         Add test for new saturatedArithmetic functions.
51
52         * TestWebKitAPI/CMakeLists.txt:
53         * TestWebKitAPI/GNUmakefile.am:
54         * TestWebKitAPI/TestWebKitAPI.gypi:
55         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
56         * TestWebKitAPI/Tests/WTF/SaturatedArithmeticOperations.cpp: Added.
57         (TestWebKitAPI):
58         (TestWebKitAPI::TEST):
59         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
60
61 2012-08-23  Ryosuke Niwa  <rniwa@webkit.org>
62
63         Replay tests take forever to load
64         https://bugs.webkit.org/show_bug.cgi?id=94764
65
66         Reviewed by Adam Barth.
67
68         Don't load about:blank at the beginning. This appears to clog the DRT.
69
70         * Scripts/webkitpy/performance_tests/perftest.py:
71         (ReplayPerfTest.run_single):
72
73 2012-08-23  Wei Jia  <wjia@chromium.org>
74
75         create different WebKit::WebMediaPlayer based on URL
76         https://bugs.webkit.org/show_bug.cgi?id=91301
77
78         Reviewed by Adam Barth.
79
80         Pass URL to createMediaPlayer. This corresponds to change in base
81         class WebKit::WebFrameClient.
82
83         * DumpRenderTree/chromium/WebViewHost.cpp:
84         (WebViewHost::createMediaPlayer): add URL as additional argument.
85         * DumpRenderTree/chromium/WebViewHost.h:
86         (WebViewHost):
87
88 2012-08-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
89
90         Unreviewed, upgrade gyuyoung to reviewer.
91         http://lists.webkit.org/pipermail/webkit-dev/2012-August/022004.html
92
93         * Scripts/webkitpy/common/config/committers.py:
94
95 2012-08-23  Carlos Garcia Campos  <cgarcia@igalia.com>
96
97         REGRESSION(r126306): it broke the plugin process
98         https://bugs.webkit.org/show_bug.cgi?id=94797
99
100         Reviewed by Xan Lopez.
101
102         * GNUmakefile.am:
103
104 2012-08-23  Ryuan Choi  <ryuan.choi@samsung.com>
105
106         [EFL] Add url bar to EWebLauncher and MiniBrowser/Efl.
107         https://bugs.webkit.org/show_bug.cgi?id=63966
108
109         Reviewed by Kenneth Rohde Christiansen.
110
111         EWebLauncher and MiniBrowser/Efl did not have functionality that users
112         navigates the site which they want.
113         This patch adds the urlbar and functionality to load url which users want.
114
115         * CMakeLists.txt:
116         Added to share urlbar theme for both EWebLauncher and MiniBrowser/Efl.
117         * EWebLauncher/CMakeLists.txt:
118         Added urlbar.c and dependency of urlbar theme.
119         In addition, changed macro name to THEME_DIR to share the code easily.
120         * EWebLauncher/ControlTheme/CMakeLists.txt: Added for urlbar theme.
121         * EWebLauncher/ControlTheme/entry.edc: Implemented urlbar theme.
122         * EWebLauncher/main.c:
123         Implemented to use the urlbar.
124         In addition, remove unnecessary border of webview to control webview and urlbar easily.
125         (_ELauncher):
126         (on_url_changed):
127         (browserCreate):
128         (closeWindow):
129         (findThemePath):
130         * EWebLauncher/url_bar.c: Implemented functionality of the urlbar.
131         (_url_bar_url_get_with_protocol):
132         (on_urlbar_key_down):
133         (on_urlbar_mouse_down):
134         (on_urlbar_focus_out):
135         (url_bar_add):
136         (url_bar_del):
137         (url_bar_url_set):
138         * EWebLauncher/url_bar.h: Added.
139         * MiniBrowser/efl/CMakeLists.txt:
140         * MiniBrowser/efl/main.c: Implemented to use the urlbar.
141         (_MiniBrowser):
142         (on_url_changed):
143         (browserCreate):
144
145 2012-08-23  Balazs Kelemen  <kbalazs@webkit.org>
146
147         [nrwt, WTR] Remove workaround for timeout handing from r126062
148         https://bugs.webkit.org/show_bug.cgi?id=94609
149
150         Reviewed by Dirk Pranke.
151
152         Don't try to reset state if a timeout occured but inform
153         the harness that the web process is no longer reliable.
154
155         * Scripts/webkitpy/layout_tests/port/driver.py:
156         (Driver.run_test): Remove the workaround. Furthermore, handle the case when
157         the pid is unknown.
158         * WebKitTestRunner/TestController.cpp:
159         (WTR::TestController::run):
160         * WebKitTestRunner/TestInvocation.cpp:
161         (WTR::TestInvocation::invoke):
162         (WTR::TestInvocation::dumpWebProcessUnresponsiveness):
163         * WebKitTestRunner/TestInvocation.h:
164         (TestInvocation):
165
166 2012-08-23  Ádám Kallai  <kadam@inf.u-szeged.hu>
167
168         Unreviewed. Adding myself to committers list.
169
170         * Scripts/webkitpy/common/config/committers.py:
171
172 2012-08-22  Alexis Menard  <alexis@webkit.org>
173
174         Unreviewed update of my email.
175
176         * Scripts/webkitpy/common/config/committers.py:
177         * Scripts/webkitpy/common/config/watchlist:
178
179 2012-08-22  Dirk Pranke  <dpranke@chromium.org>
180
181         Fix typos in r126374
182         https://bugs.webkit.org/show_bug.cgi?id=94665
183         Unreviewed, build fix.
184
185         Fix two issues that snuck in, one that caused a crash if there
186         were no baselines to optimize and one that occurred as a result
187         of failing to rename a variable when I changed the recursion to
188         a loop in the previous patch.
189
190         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
191         (BaselineOptimizer._optimize_by_pushing_results_up):
192
193 2012-08-22  Dirk Pranke  <dpranke@chromium.org>
194
195         Baseline optimizer should try to optimize per-port if global optimization fails
196         https://bugs.webkit.org/show_bug.cgi?id=94665
197
198         Reviewed by Adam Barth.
199
200         Add a fallback strategy for optimizing baselines if the default
201         one fails; this one simply attempts to shift baselines up in the
202         tree and consolidates them if a parent and child in the fallback
203         path have the same result. This strategy is somewhat flawed in
204         that we will always put something in a parent dir even if we
205         "shouldn't"; for example, if chromium-mac produces a different
206         result from chromium-win and chromium-linux, then the new
207         algorithm will move the mac result into platform/chromium,
208         leaving chromium-mac empty. This result is still correct, but
209         perhaps confusing.
210
211         I haven't done much testing of this algorithm yet, so it's not
212         clear how many cases where this does a better job than the
213         default algorithm and how many it'll do a worse job.
214
215         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
216         (BaselineOptimizer._find_optimal_result_placement):
217         (BaselineOptimizer._optimize_by_most_specific_common_directory):
218         (BaselineOptimizer):
219         (BaselineOptimizer._optimize_by_pushing_results_up):
220         (BaselineOptimizer._find_in_fallbackpath):
221         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
222         (BaselineOptimizerTest.test_platform_mac_different):
223
224 2012-08-22  Dirk Pranke  <dpranke@chromium.org>
225
226         add debug info, another test to webkit-patch optimize-baselines
227         https://bugs.webkit.org/show_bug.cgi?id=94762
228
229         Reviewed by Adam Barth.
230
231         This patch adds more debug logging for optimize-baselines so
232         that you can tell the before and after states and figure out
233         what the command is actually deciding to do.
234
235         Also, this command adds a (disabled) test for the problem in bug
236         94665. It's disabled because we don't have the fix yet (that
237         will be posted in a patch to that bug).
238
239         There should be no functional changes in this patch apart from
240         the additional logging.
241
242         Note that adding the debug logging exposed a bug in
243         filesystem_mock.relpath() (that would return None if the path
244         wasn't a subpath of the start); the real relpath computes a
245         relpath with parent dirs. Fixing this revealed a bad check in
246         the style checker's change_directory() call which was checking
247         for None.
248
249         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
250         (BaselineOptimizer._find_optimal_result_placement):
251         (BaselineOptimizer):
252         (BaselineOptimizer._optimize_by_most_specific_common_directory):
253         (BaselineOptimizer._move_baselines):
254         (BaselineOptimizer.optimize):
255         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
256         (BaselineOptimizerTest.disabled_test_platform_mac_different):
257         * Scripts/webkitpy/common/system/filesystem.py:
258         (FileSystem):
259         * Scripts/webkitpy/common/system/filesystem_mock.py:
260         (MockFileSystem):
261         (MockFileSystem.__init__):
262         (MockFileSystem.relpath):
263         * Scripts/webkitpy/common/system/filesystem_unittest.py:
264         (RealFileSystemTest.test_sep):
265         * Scripts/webkitpy/style/main.py:
266         (change_directory):
267
268 2012-08-22  Alejandro Piñeiro  <apinheiro@igalia.com>
269
270         Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not ROLE_PUSH_BUTTON
271         https://bugs.webkit.org/show_bug.cgi?id=73819
272
273         Reviewed by Chris Fleizach.
274
275         Added a new role, Toggle Button, based on whether aria-pressed is present.
276         http://www.w3.org/TR/wai-aria/states_and_properties#aria-pressed
277
278         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
279         (roleToString): added "ToggleButton" string for WebAccessibilityRoleToggleButton
280
281 2012-08-23  Victor Carbune  <victor@rosedu.org>
282
283         Add myself to the committer list
284         https://bugs.webkit.org/show_bug.cgi?id=94659
285
286         Reviewed by James Robinson.
287
288         Added my email and IRC handle.
289
290         * Scripts/webkitpy/common/config/committers.py:
291
292 2012-08-22  Scott Graham  <scottmg@chromium.org>
293
294         Don't unconditionally define NOMINMAX on Windows
295         https://bugs.webkit.org/show_bug.cgi?id=94742
296
297         Reviewed by Adrienne Walker.
298
299         Avoids a warning when building on Windows when NOMINMAX is defined
300         elsewhere or on the command line.
301
302         * TestWebKitAPI/config.h:
303
304 2012-08-22  Zan Dobersek  <zandobersek@gmail.com>
305
306         REGRESSION(r126189): Reftest mismatches are (again) run through ImageDiff with 0.1 tolerance
307         https://bugs.webkit.org/show_bug.cgi?id=94704
308
309         Reviewed by Dirk Pranke.
310
311         Use tolerance=0 when acquiring diff image of reftest output.
312
313         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
314         (SingleTestRunner._compare_output_with_reference):
315
316 2012-08-22  Tommy Widenflycht  <tommyw@google.com>
317
318         [chromium] MediaStream API: Add MockWebRTCPeerConnectionHandler
319         https://bugs.webkit.org/show_bug.cgi?id=93091
320
321         Reviewed by Adam Barth.
322
323         Add a skeleton MockWebRTCPeerConnectionHandler to DumpRenderTree,
324         to complete the infrastructure for RTCPeerConnection.
325
326         * DumpRenderTree/DumpRenderTree.gypi:
327         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
328         (MockWebKitPlatformSupport::createRTCPeerConnectionHandler):
329         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h:
330         (MockWebKitPlatformSupport):
331         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
332         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
333         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
334         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
335         (MockWebRTCPeerConnectionHandler::initialize):
336         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
337         (WebKit):
338         (MockWebRTCPeerConnectionHandler):
339         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
340
341 2012-08-21  Ryosuke Niwa  <rniwa@webkit.org>
342
343         Merge TestExpectationSerializer into TestExpectationLine
344         https://bugs.webkit.org/show_bug.cgi?id=94638
345
346         Reviewed by Dimitri Glazkov.
347
348         Moved all methods except, list_to_string which was moved to TestExpectations
349         from TestExpectationSerializer to TestExpectationLine and removed TestExpectationSerializer.
350
351         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
352         (TestExpectationEditorTests.assert_remove_roundtrip):
353         (TestExpectationEditorTests.assert_update_roundtrip):
354         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
355         (ParseError.__repr__):
356         (TestExpectationLine):
357         (TestExpectationLine.create_passing_expectation):
358         (TestExpectationLine.to_string): Moved from TestExpectationSerializer.
359         (TestExpectationLine.to_csv): Ditto.
360         (TestExpectationLine._serialize_parsed_expectations): Ditto.
361         (TestExpectationLine._serialize_parsed_modifiers): Ditto.
362         (TestExpectationLine._format_line):
363         (TestExpectations.remove_configuration_from_test):
364         (TestExpectations.remove_rebaselined_tests):
365         (TestExpectations.add_skipped_tests):
366         (TestExpectations):
367         (TestExpectations.list_to_string): Moved from TestExpectationSerializer.
368         (TestExpectations.list_to_string.serialize):
369         (TestExpectations.list_to_string.nones_out):
370         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
371         (TestExpectationSerializationTests): Renamed from TestExpectationSerializerTests.
372         (TestExpectationSerializationTests.__init__):
373         (TestExpectationSerializationTests.assert_round_trip):
374         (TestExpectationSerializationTests.assert_list_round_trip):
375         (TestExpectationSerializationTests.test_unparsed_to_string):
376         (TestExpectationSerializationTests.test_unparsed_list_to_string):
377         (TestExpectationSerializationTests.test_parsed_to_string):
378         (TestExpectationSerializationTests.test_serialize_parsed_expectations):
379         (TestExpectationSerializationTests.test_serialize_parsed_modifier_string):
380         (TestExpectationSerializationTests.test_format_line):
381         (TestExpectationSerializationTests.test_reconstitute_only_these):
382         * Scripts/webkitpy/tool/commands/expectations.py:
383         (OptimizeExpectations.execute):
384         * Scripts/webkitpy/tool/commands/queries.py:
385         (PrintExpectations.execute):
386         (PrintExpectations._format_lines):
387         * Scripts/webkitpy/tool/servers/gardeningserver.py:
388         (GardeningExpectationsUpdater.update_expectations):
389
390 2012-08-22  Alexandre Elias  <aelias@chromium.org>
391
392         Unreviewed, add aelias@chromium.org to committers
393
394         I (aelias@chromium.org) have been approved for commit access and Apple
395         has confirmed receipt of my committer agreement.
396
397         * Scripts/webkitpy/common/config/committers.py:
398
399 2012-08-22  Alexey Proskuryakov  <ap@apple.com>
400
401         [WK2] Support posting injected bundle messages to a page
402         https://bugs.webkit.org/show_bug.cgi?id=94630
403
404         Reviewed by Sam Weinig.
405
406         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
407         * TestWebKitAPI/InjectedBundleController.cpp:
408         (TestWebKitAPI::InjectedBundleController::initialize):
409         (TestWebKitAPI::InjectedBundleController::didReceiveMessageToPage):
410         * TestWebKitAPI/InjectedBundleController.h:
411         * TestWebKitAPI/InjectedBundleTest.h:
412         (TestWebKitAPI::InjectedBundleTest::didReceiveMessageToPage):
413         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
414         (WTR::InjectedBundle::didReceiveMessage):
415         (WTR::InjectedBundle::didReceiveMessageToPage):
416         (WTR::InjectedBundle::initialize):
417         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
418         Updated for new client API call.
419
420 2012-08-22  Dominic Mazzoni  <dmazzoni@google.com>
421
422         REGRESSION (r125710): accessibility/accessibility-node-reparent.html, accessibility/accessibility-node-memory-management.html failing on GTK Linux
423         https://bugs.webkit.org/show_bug.cgi?id=94200
424
425         Reviewed by Chris Fleizach.
426
427         Adds reference counting for AtkObjects referenced by
428         AccessibilityUIElementGtk. This prevents bogus results and
429         assertion failures on AccessibilityUIElements whose underlying
430         object has been deleted (as opposed to just made defunct).
431
432         This fixes two tests that were previously failing because of this bug.
433
434         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
435         (AccessibilityUIElement::AccessibilityUIElement):
436         (AccessibilityUIElement::~AccessibilityUIElement):
437
438 2012-08-22  Gustavo Noronha Silva  <gns@gnome.org>
439
440         [GTK] Split WebCore/platform into a separate library
441         https://bugs.webkit.org/show_bug.cgi?id=94435
442
443         Reviewed by Martin Robinson.
444
445         More people have been reporting problems when linking WebCore because
446         the command line limit is being exceeded. Splitting WebCore a bit more
447         is in order.
448
449         * GNUmakefile.am: link libWebCorePlatform into DRT
450
451 2012-08-22  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
452
453         Unreviewed buildfix for Qt-minimal after r126291
454
455         Disable smooth scrolling when request-animation-frame has been disabled either
456         explicitly or as part of --minimal.
457
458         * qmake/mkspecs/features/features.prf:
459
460 2012-08-22  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
461
462         [Qt] Optionally support smooth-scrolling on all platforms
463         https://bugs.webkit.org/show_bug.cgi?id=74926
464
465         Reviewed by Simon Hausmann.
466
467         Enabled SMOOTH_SCROLLING on Qt, and expose the enable scroll animator
468         setting in QtTestBrowser so it can be tested.
469
470         * QtTestBrowser/launcherwindow.cpp:
471         (LauncherWindow::createChrome):
472         (LauncherWindow::toggleScrollAnimator):
473         * QtTestBrowser/launcherwindow.h:
474         (WindowOptions::WindowOptions):
475         (WindowOptions):
476         (LauncherWindow):
477         * qmake/mkspecs/features/features.pri:
478
479 2012-08-22  Dominik Röttsches  <dominik.rottsches@intel.com>
480
481         Unreviewed, adding myself to committers.py.
482
483         * Scripts/webkitpy/common/config/committers.py:
484
485 2012-08-21  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
486
487         [GTK] contextClick and getMenuItemTitle callbacks are leaky in DRT's EventSender
488         https://bugs.webkit.org/show_bug.cgi?id=94669
489
490         Reviewed by Carlos Garcia Campos.
491
492         Fix memory leaks in DRT's EventSender code.
493
494         * DumpRenderTree/gtk/EventSender.cpp:
495         (getMenuItemTitleCallback): Use JSRetainPtr and don't leak.
496         (contextClickCallback): Use GOwnPtr to manage memory of a
497         newly-allocated list automatically.
498
499 2012-08-21  Dirk Pranke  <dpranke@chromium.org>
500
501         Add mountain lion to perf-tests, layout tests
502         https://bugs.webkit.org/show_bug.cgi?id=94553
503
504         Reviewed by Adam Barth.
505
506         This patch adds support for the 'mac-mountainlion' platform and
507         stamps out the last references to 'mac-leopard' as a supported
508         name.
509         
510         This patch does a small amount of refactoring to try and make
511         things a little clearer how we treat the "most recent version"
512         specially for baselines and skipped files, and so you only
513         should have to touch the VERSION_FALLBACK_ORDER constants on the
514         ports, but unfortunately changing this list changes a bunch of
515         the unit tests which are doing exact matches for correctness, so
516         you have to touch more than a couple files :(. There's probably
517         still more refactoring that can be done so that we don't have to
518         do all of this functional testing to feel completely correct.
519
520         * Scripts/webkitpy/common/system/platforminfo.py:
521         (PlatformInfo._determine_mac_version):
522         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
523         (TestPlatformInfo.test_os_version):
524         * Scripts/webkitpy/layout_tests/port/apple.py:
525         (ApplePort.__init__):
526         (ApplePort):
527         (ApplePort._skipped_file_search_paths):
528         (ApplePort._generate_all_test_configurations):
529         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
530         (ChromiumMacPort):
531         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
532         (FactoryTest.test_mac):
533         * Scripts/webkitpy/layout_tests/port/mac.py:
534         (MacPort):
535         (MacPort._build_driver_flags):
536         (MacPort.should_retry_crashes):
537         (MacPort.default_baseline_search_path):
538         (MacPort.operating_system):
539         (MacPort.default_child_processes):
540         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
541         (MacTest):
542         (MacTest.test_skipped_file_search_paths):
543         (test_versions):
544         (test_baseline_search_path):
545         * Scripts/webkitpy/layout_tests/port/win.py:
546         (WinPort):
547         (WinPort.default_baseline_search_path):
548
549 2012-08-21  Zan Dobersek  <zandobersek@gmail.com>
550
551         [GTK] fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html is failing
552         https://bugs.webkit.org/show_bug.cgi?id=94617
553
554         Reviewed by Martin Robinson.
555
556         Set the 'enable-file-access-from-file-uris' setting to true when
557         resetting default values. The other ports do this as well, giving
558         documents with local security origin permission to load other
559         local resources.
560
561         * DumpRenderTree/gtk/DumpRenderTree.cpp:
562         (resetDefaultsToConsistentValues):
563
564 2012-08-21  Kent Tamura  <tkent@chromium.org>
565
566         [Chromium] DRT produces wrong back-forward list
567         https://bugs.webkit.org/show_bug.cgi?id=94575
568
569         Reviewed by Adam Barth.
570
571         DRT clears its history state before running every tests. However
572         HistoryController in WebCore isn't reset. So, it is possible that
573         'isNewNavigation' flag is false even though the navigation should be
574         handled as "new" for DRT.
575
576         This change might fix a problem of
577         fast/forms/select/select-state-restore.html (Bug 90207).
578
579         * DumpRenderTree/chromium/WebViewHost.cpp:
580         (WebViewHost::updateForCommittedLoad):
581         Treat the first page load (m_pageID == -1) as new navigation except for about:blank.
582         Without this change, a navigation entry for this loading won't be recorded.
583
584 2012-08-21  Thiago Marcos P. Santos  <thiago.santos@intel.com>
585
586         [EFL] Enable CSS Text Decoration by default
587         https://bugs.webkit.org/show_bug.cgi?id=94483
588
589         Reviewed by Kenneth Rohde Christiansen.
590
591         * Scripts/webkitperl/FeatureList.pm:
592
593 2012-08-21  Benjamin Poulain  <bpoulain@apple.com>
594
595         Store CString data in the CStringBuffer to avoid the double indirection
596         https://bugs.webkit.org/show_bug.cgi?id=94562
597
598         Reviewed by Darin Adler.
599
600         Add test coverage for WTF::CString.
601
602         * TestWebKitAPI/CMakeLists.txt:
603         * TestWebKitAPI/GNUmakefile.am:
604         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
605         * TestWebKitAPI/Tests/WTF/CString.cpp:
606
607 2012-08-21  Dirk Pranke  <dpranke@chromium.org>
608
609         Text Autosizing: ::first-letter pseudo-element is incorrectly sized
610         https://bugs.webkit.org/show_bug.cgi?id=94540
611
612         Reviewed by Ojan Vafai.
613
614         Revert the changes in bugs 94517 and 94396 so that we are
615         actually looking for stderr output from ImageDiff and doing
616         image compares on ref tests on the wk2 ports again.
617
618         Also, do an actual diff_image() call if the hash checks fail on
619         reftests, and only fail the test if we get real diffs (or don't,
620         for mismatches).
621
622         Lastly, clean up the log messages to be more helpful.
623
624         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
625         (SingleTestRunner._compare_image):
626         (SingleTestRunner._compare_output_with_reference):
627         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
628         (write_test_result):
629
630 2012-08-21  Dirk Pranke  <dpranke@chromium.org>
631
632         _compare_image() swaps actual and expected images by mistake
633         https://bugs.webkit.org/show_bug.cgi?id=94567
634
635         Reviewed by Ojan Vafai.
636
637         Re-work the code so that we consistently pass (expected, actual)
638         across all of the compare/diff routines.
639
640         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
641         (SingleTestRunner._run_compare_test):
642         (SingleTestRunner._compare_output):
643         (SingleTestRunner._compare_text):
644         (SingleTestRunner._compare_audio):
645         (SingleTestRunner._compare_image):
646         (SingleTestRunner._run_reftest):
647         (SingleTestRunner._compare_output_with_reference):
648         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
649         (write_test_result):
650
651 2012-08-21  Adam Barth  <abarth@webkit.org>
652
653         Unreviewed. Move the commit-queue to building release only. Previously,
654         we built debug too, but for some reason the debug build doesn't work on
655         the bots. We can re-enable debug builds once we fix the underlying
656         problem.
657
658         * Scripts/webkitpy/tool/commands/queues.py:
659         (CommitQueue.build_style):
660         * Scripts/webkitpy/tool/commands/queues_unittest.py:
661
662 2012-08-21  Ryosuke Niwa  <rniwa@webkit.org>
663
664         TestExpectationsParser doesn't warn about test files that don't exist.
665         https://bugs.webkit.org/show_bug.cgi?id=94632
666
667         Reviewed by Dirk Pranke.
668
669         Exit early and warn when the test file doesn't exist as well when a test directory doesn't exist.
670
671         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
672         (TestExpectationParser._parse_line):
673         (TestExpectationParser._check_test_exists):
674         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
675         (test_parse_warning):
676
677 2012-08-20  Ryosuke Niwa  <rniwa@webkit.org>
678
679         Move free functions in test_expectations to TestExpectations class
680         https://bugs.webkit.org/show_bug.cgi?id=94557
681
682         Reviewed by Dirk Pranke.
683
684         Moved test_result_was_expected, test_remove_pixel_failures, and test_suffixes_for_expectations into TestExpectations
685         to allow further refactoring.
686
687         * Scripts/webkitpy/common/net/resultsjsonparser.py:
688         (JSONTestResult.did_run_as_expected):
689         (JSONTestResult._tokenize):
690         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
691         (TestExpectations):
692         (TestExpectations.result_was_expected):
693         (TestExpectations.remove_pixel_failures):
694         (TestExpectations.has_pixel_failures):
695         (TestExpectations.suffixes_for_expectations):
696         (TestExpectations.matches_an_expected_result):
697         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
698         (MockBugManager.create_bug):
699         (test_result_was_expected):
700         (test_remove_pixel_failures):
701         (test_suffixes_for_expectations):
702         * Scripts/webkitpy/tool/commands/rebaseline.py:
703         (RebaselineExpectations._tests_to_rebaseline):
704
705 2012-08-21  Simon Hausmann  <simon.hausmann@nokia.com>
706
707         Unreviewed build fix for newer Qt 5: The meaning of private_includes changed to be fully
708         self-contained. The module name is not appended automatically anymore.
709
710         * qmake/qt_webkit.pri:
711
712 2012-08-20  Xianzhu Wang  <wangxianzhu@chromium.org>
713
714         [Chromium-Android] Add stop_when_done parameter to ChromiumAndroidDriver.run_test()
715         https://bugs.webkit.org/show_bug.cgi?id=94558
716
717         Reviewed by Dirk Pranke.
718
719         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
720         (ChromiumAndroidDriver.run_test):
721
722 2012-08-20  Ryosuke Niwa  <rniwa@webkit.org>
723
724         Cleanup TestExpectationParser.parse
725         https://bugs.webkit.org/show_bug.cgi?id=94545
726
727         Reviewed by Dirk Pranke.
728
729         Refactor TestExpectations to simplify the code.
730
731         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
732         (TestExpectationParser.parse): Merged _tokenize_list.
733         (TestExpectationParser._parse_line): Removed the call to _check_modifiers_against_expectations
734         since the check is now done in _parser_modifiers.
735         (TestExpectationParser._parse_modifiers): Merged _check_modifiers_against_expectations.
736         (TestExpectationParser._tokenize_line): Renamed from _tokenize.
737         (TestExpectationParser._split_space_separated): No longer calls lower() on all modifiers.
738         This is done on a local variable in _parse_modifiers, preserving the original case.
739         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier): Check the existence
740         of 'rebaseline' against parsed modifiers.
741         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
742         (TestExpectationParserTests._tokenize):
743         (TestExpectationParserTests.test_tokenize_valid_with_comment): Preserves case.
744         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers): Ditto.
745         (TestExpectationSerializerTests._tokenize):
746         (TestExpectationSerializerTests.assert_list_round_trip): Call parse since _tokenize_list has
747         been merged into parse.
748         * Scripts/webkitpy/tool/commands/queries_unittest.py:
749         (PrintExpectationsTest.test_csv): Preserves the case.
750
751 2012-08-20  Gustavo Noronha Silva  <gns@gnome.org>
752
753         [jhbuild] EFL now runs jhbuild update for every build
754         https://bugs.webkit.org/show_bug.cgi?id=94267
755
756         Reviewed by Martin Robinson.
757
758         Try to fix WinCE build by returning the empty string instead of
759         env when no jhbuild infrastructure is found.
760
761         * Scripts/webkitdirs.pm:
762         (jhbuildWrapperPrefixIfNeeded):
763
764 2012-08-20  Benjamin Poulain  <benjamin@webkit.org>
765
766         Add a watcher for WTF changes
767
768         Unreviewed.
769
770         Add myself as a watcher for changes in WTF.
771
772         * Scripts/webkitpy/common/config/watchlist:
773
774 2012-08-20  Thiago Marcos P. Santos  <thiago.santos@intel.com>
775
776         [EFL] Move jhbuild dependencies based on SVN to tarballs
777         https://bugs.webkit.org/show_bug.cgi?id=90374
778
779         Reviewed by Kenneth Rohde Christiansen.
780
781         Moved all the dependencies based on SVN to tarballs taken from a
782         equivalent snapshot from the official git mirror. This will make
783         update-webkitefl not dependent on network connection after the first
784         run. The bots will not fail if EFL SVN server in unreachable.
785         The reason why git mirror is not used directly is to minimize the
786         total size of source code we need to download.
787
788         * efl/jhbuild.modules:
789
790 2012-08-20  Simon Fraser  <simon.fraser@apple.com>
791
792         Lots of "error, test and reference image have different properties" in pixel test output
793         https://bugs.webkit.org/show_bug.cgi?id=92578
794
795         Reviewed by Dirk Pranke.
796
797         Improve ImageDiff's error reporting when test result image and expected image
798         differ in their properties.
799
800         * DumpRenderTree/cg/ImageDiffCG.cpp:
801
802 2012-08-20  Nate Chapin  <japhet@chromium.org>
803
804         Unsafe vsprintf usage in TestNetscapePlugin
805         https://bugs.webkit.org/show_bug.cgi?id=94522
806
807         Reviewed by Adam Barth.
808
809         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
810         (pluginLogWithArguments): Using vsnprintf instead of vsprintf to ensure we don't overflow
811             the message buffer.
812         (testDocumentOpen):
813         (testWindowOpen):
814
815 2012-08-20  George Staikos  <staikos@webkit.org>
816
817         [BlackBerry] Enable XHR Response BLOB
818         https://bugs.webkit.org/show_bug.cgi?id=94525
819
820         Reviewed by Rob Buis.
821
822         Turn on the XHR response blob feature for the BlackBerry port.
823
824         * Scripts/webkitperl/FeatureList.pm: Add the feature and enable it.
825
826 2012-08-20  Dirk Pranke  <dpranke@chromium.org>
827
828         Fix change for timeout detection to not crash if we have no output :)
829         https://bugs.webkit.org/show_bug.cgi?id=94505
830
831         Unreviewed, build fix.
832
833         * Scripts/webkitpy/layout_tests/port/driver.py:
834         (Driver.run_test):
835
836 2012-08-20  Dirk Pranke  <dpranke@chromium.org>
837
838         temporarily disable ImageDiff on WK2 ports for ref tests
839         https://bugs.webkit.org/show_bug.cgi?id=94517
840
841         Reviewed by Brady Eidson.
842
843         ImageDiff appears to be unable to handle the pngs returned from
844         WebKitTestRunner, so we disable checking images by default
845         for ref tests on wk2 ports (unless pixel tests is explicitly enabled).
846
847         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
848         (SingleTestRunner._compare_output_with_reference):
849
850 2012-08-20  Dirk Pranke  <dpranke@chromium.org>
851
852         Add missing FIXME: to previous change.
853         https://bugs.webkit.org/show_bug.cgi?id=94505
854
855         Reviewed by Ojan Vafai.
856
857         * Scripts/webkitpy/layout_tests/port/driver.py:
858         (Driver.run_test):
859
860 2012-08-20  Dirk Pranke  <dpranke@chromium.org>
861
862         Intermittenly, many WebKit2 tests have results from the wrong test compared to the test just run, giving false failures.
863         https://bugs.webkit.org/show_bug.cgi?id=94505
864
865         Reviewed by Ojan Vafai.
866
867         It looks like if the webprocess times out, WTR may tell NRWT
868         that the test completed, but not properly reset its internal
869         state, and then return stale output for subsequent tests.
870
871         This patch modifies NRWT temporarily to check for
872         "Timed out waiting for final message from web process" in stdout
873         and treat that as a timeout (and thus kill WTR); this seems
874         to solve the cascade of failures, but of course there's probably
875         still a bug in WTR that needs to be fixed.
876
877         * Scripts/webkitpy/layout_tests/port/driver.py:
878         (Driver.run_test):
879
880 2012-08-20  Dirk Pranke  <dpranke@chromium.org>
881
882         NRWT reports unexpected EOF
883         https://bugs.webkit.org/show_bug.cgi?id=94387
884
885         Reviewed by Adam Barth.
886
887         Stop logging "Unexpected EOF" when we are reading the last few
888         bytes from stdout/stderr after stopping the subprocess.
889
890         * Scripts/webkitpy/layout_tests/port/server_process.py:
891         (ServerProcess._wait_for_data_and_update_buffers_using_select):
892         (ServerProcess.stop):
893
894 2012-08-20  Brady Eidson  <beidson@apple.com>
895
896         Temporarily disable the 20+ crash and 500+ failure options on WK2 bots.
897         https://bugs.webkit.org/show_bug.cgi?id=94506
898
899         Reviewed by Dirk Pranke.
900
901         When running WK2 tests, don't add the "abort early" command line options.
902
903         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
904         (ConfigureBuild.start):
905         (RunWebKitTests):
906         (RunWebKitTests.start):
907         (RunWebKit2Tests.start):
908
909 2012-08-19  Stephanie Lewis  <slewis@apple.com>
910
911         Add mountain lion to build config.
912         https://bugs.webkit.org/show_bug.cgi?id=94441
913
914         Reviewed by Adam Barth.
915
916         Add Mountain Lion to the build trigger configurations.
917
918         * Scripts/webkitpy/common/config/build.py:
919         (_should_file_trigger_build):
920         * Scripts/webkitpy/common/config/build_unittest.py:
921         (ShouldBuildTest):
922         (ShouldBuildTest.test_should_build):
923
924 2012-08-17  Kiran Muppala  <cmuppala@apple.com>
925
926         Add self to webkit contributors list
927         https://bugs.webkit.org/show_bug.cgi?id=94409
928
929         Reviewed by Dirk Pranke.
930
931         Add name, email and irc handle to webkit contributors list.
932
933         * Scripts/webkitpy/common/config/committers.py:
934
935 2012-08-17  Ryosuke Niwa  <rniwa@webkit.org>
936
937         Perfalizer should differentiate results with and without the patch
938         https://bugs.webkit.org/show_bug.cgi?id=94399
939
940         Reviewed by Dirk Pranke.
941
942         Add "with 12345" and "without 12345" descriptions in results JSON so that graphs in
943         the results page are labled accordingly.
944
945         Also use _build_without_patch when building without a patch so that we get the right error message.
946
947         * Scripts/webkitpy/tool/commands/perfalizer.py:
948         (PerfalizerTask.run):
949         (PerfalizerTask._run_perf_test):
950         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
951         (PerfalizerTaskTest._create_and_run_perfalizer.run_perf_test):
952
953 2012-08-17  Dirk Pranke  <dpranke@chromium.org>
954
955         nrwt: don't fail tests if ImageDiff fails on the wk2 ports
956         https://bugs.webkit.org/show_bug.cgi?id=94396
957
958         Reviewed by Ryosuke Niwa.
959
960         It appears that WTR is generating PNGs that ImageDiff doesn't
961         like, and so we're getting lots of "can not get ImageDiff"
962         errors (see bug 81962). The change in r124581 made this a test
963         failure, and this is causing the WK2 bots to frequently abort
964         with 500+ failures. 
965
966         This change makes ImageDiff errors not be test failures just for
967         WK2 for now until we can better triage what's going on.
968
969         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
970         (SingleTestRunner._compare_image):
971
972 2012-08-17  James Robinson  <jamesr@chromium.org>
973
974         [chromium] Add a style check for #include "cc/..." in chromium files
975         https://bugs.webkit.org/show_bug.cgi?id=94382
976
977         Reviewed by Adam Barth.
978
979         Adds a style check to make sure new chromium code follows the correct convention for including cc files.
980
981         * Scripts/webkitpy/style/checkers/cpp.py:
982         (check_include_line):
983         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
984         (OrderOfIncludesTest.test_check_cc_includes):
985
986 2012-08-17  Ojan Vafai  <ojan@chromium.org>
987
988         Delete some dead code from the flakiness dashboard
989         https://bugs.webkit.org/show_bug.cgi?id=94380
990
991         Reviewed by Dirk Pranke.
992
993         This code became dead in one of the refactors of how we handle BuilderGroups.
994         There's no bug here, it's just dead code.
995         * TestResultServer/static-dashboards/builders.js:
996         (requestBuilderList):
997         (loadBuildersList):
998
999 2012-08-17  Jochen Eisinger  <jochen@chromium.org>
1000
1001         [chromium] Add content shell bots to the flakiness dashboard
1002         https://bugs.webkit.org/show_bug.cgi?id=94369
1003
1004         Reviewed by Ojan Vafai.
1005
1006         The bots are named $OS (Content Shell).
1007
1008         * TestResultServer/static-dashboards/builders.js:
1009         (isChromiumWebkitTipOfTreeTestRunner):
1010         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1011
1012 2012-08-17  Shadi Khalek  <shadi@chromium.org>
1013
1014         Add AV perf layout tests to webkit flakiness dashboard
1015         https://bugs.webkit.org/show_bug.cgi?id=94255
1016
1017         Reviewed by Ojan Vafai.
1018
1019         Added missing mappings to LEGACY_BUILDER_MASTERS_TO_GROUPS.
1020         The isChromiumDepsAVTestRunner() filter does not work on current builder names. 
1021         It assumes the new names they are getting renamed to (AV Linux, AV Win7).
1022
1023         * TestResultServer/static-dashboards/builders.js:
1024         (isChromiumTipOfTreeAVTestRunner):
1025         (loadBuildersList):
1026
1027 2012-08-17  Milian Wolff  <milian.wolff@kdab.com>
1028
1029         [Qt] QtWebKit fails to build with OpenGL support on QNX
1030         https://bugs.webkit.org/show_bug.cgi?id=93278
1031
1032         Reviewed by Noam Rosenthal.
1033
1034         Change the order in which we define WTF_USE_3D_GRAPHICS and ENABLE_WEBGL.
1035         First, we now defined WTF_USE_3D_GRAPHICS=1, but only if QT_CONFIG
1036         contains opengl. Furthermore, we disable this feature on win32-* as usual,
1037         but now also disable it on QNX.
1038
1039         Then, we set ENABLE_WEBGL=1 but only if we previously set WTF_USE_3D_GRAPHICS=1.
1040
1041         * qmake/mkspecs/features/features.prf:
1042
1043 2012-08-16  Gustavo Noronha Silva  <gns@gnome.org>
1044
1045         [jhbuild] EFL now runs jhbuild update for every build
1046         https://bugs.webkit.org/show_bug.cgi?id=94267
1047
1048         Reviewed by Dirk Pranke.
1049
1050         This change makes EFL's approach to jhbuild more in line with the one
1051         used by WebKitGTK+. update-webkitefl-libs will only be called by build-
1052         webkit if --update-efl is given explicitly. The EWS bot will do that
1053         from now on.
1054
1055         * Scripts/webkitdirs.pm:
1056         (jhbuildWrapperPrefixIfNeeded): return jhbuild wrapper only if the
1057         Dependencies directory exists also for EFL
1058         (generateBuildSystemFromCMakeProject): no longer run update-webkitefl-libs
1059         (buildCMakeProjectOrExit): build update-webkitefl-libs if --update-efl is
1060         given
1061         * Scripts/webkitpy/common/config/ports.py:
1062         (EflPort.build_webkit_command): make EWS bots pass --update-efl to build-webkit
1063         * Scripts/webkitpy/common/config/ports_unittest.py:
1064         (DeprecatedPortTest.test_efl_port): add unit testing for EFL port
1065
1066 2012-08-16  Kent Tamura  <tkent@chromium.org>
1067
1068         Add forms-bugs@chromium.org as a contributor.
1069
1070         * Scripts/webkitpy/common/config/committers.py:
1071
1072 2012-08-16  Gustavo Noronha Silva  <gns@gnome.org>
1073
1074         Unreviewed warning fix, sys.argv is a python construct.
1075
1076         * Scripts/update-webkitefl-libs:
1077
1078 2012-08-16  Dirk Pranke  <dpranke@chromium.org>
1079
1080         NRWT cutting off the output from LayoutTest run under Valgrind
1081         https://bugs.webkit.org/show_bug.cgi?id=94011
1082
1083         Reviewed by Ojan Vafai.
1084
1085         Make NRWT work with valgrind again ... I needed to rework the
1086         driver infrastructure so that we could get the stderr written
1087         between a test completing and a process being stopped and
1088         associate it with the DriverOutput for the test; this meant that
1089         run_test() needed to stop the driver at the end of the test
1090         directly if/when appropriate. This also entailed reworking
1091         run_test() so that we would gather stderr and stdout
1092         consistently regardless of whether this was a normal test, or
1093         stop_when_done, or a crash or timeout.
1094
1095         Also, I had to rework the process_stop_time() (and renamed it to
1096         driver_stop_timeout) so that it would be longer if --time-out-ms
1097         was long as well (so that valgrind would get enough time to
1098         run), and I reworked driver.stop(kill_directly=True) to just
1099         driver.stop(timeout=0.0).
1100
1101         Lastly, adding the new stop_when_done parameter entailed
1102         touching a lot of test mock functions :(.
1103
1104         This change appeared to be well-covered by existing tests.
1105
1106         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1107         (Worker._run_test):
1108         (Worker._run_test_with_timeout):
1109         (Worker._run_test_in_another_thread):
1110         (Worker._run_test_in_another_thread.SingleTestThread.run):
1111         (Worker._run_test_in_this_thread):
1112         (Worker._run_single_test):
1113         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1114         (run_single_test):
1115         (SingleTestRunner.__init__):
1116         (SingleTestRunner._run_compare_test):
1117         (SingleTestRunner._run_rebaseline):
1118         (SingleTestRunner._run_reftest):
1119         * Scripts/webkitpy/layout_tests/port/base.py:
1120         (Port.driver_stop_timeout):
1121         (Port.variable.default_configuration):
1122         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1123         (ChromiumAndroidPort.driver_stop_timeout):
1124         (ChromiumAndroidDriver.stop):
1125         * Scripts/webkitpy/layout_tests/port/driver.py:
1126         (Driver.run_test):
1127         (Driver.stop):
1128         (DriverProxy.run_test):
1129         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
1130         (DriverTest.test_check_for_driver_crash.FakeServerProcess.stop):
1131         * Scripts/webkitpy/layout_tests/port/server_process.py:
1132         (ServerProcess.write):
1133         (ServerProcess._wait_for_data_and_update_buffers_using_select):
1134         (ServerProcess.stop):
1135         (ServerProcess.kill):
1136         (ServerProcess):
1137         (ServerProcess._kill):
1138         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
1139         (TrivialMockPort.__init__):
1140         (MockProc.wait):
1141         (TestServerProcess.test_basic):
1142         * Scripts/webkitpy/layout_tests/port/test.py:
1143         (TestDriver.run_test):
1144         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1145         (get_tests_run.RecordingTestDriver.run_test):
1146         * Scripts/webkitpy/performance_tests/perftest.py:
1147         (PerfTest.run_single):
1148         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1149         (TestPageLoadingPerfTest.MockDriver.run_test):
1150         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver.run_test):
1151         (TestReplayPerfTest.test_run_single.run_test):
1152         (TestReplayPerfTest.test_run_single_fails_when_output_has_error.run_test):
1153         (TestReplayPerfTest.test_prepare.run_test):
1154         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1155         (MainTest.TestDriver.run_test):
1156
1157 2012-08-16  Roger Fong  <roger_fong@apple.com>
1158
1159         Typo in old-run-webkit-tests script from https://bugs.webkit.org/show_bug.cgi?id=93904.
1160         https://bugs.webkit.org/show_bug.cgi?id=94228
1161
1162         Reviewed by Tim Horton.
1163
1164         I previously made the change but made a typo that causes the script not ignore mismatch ref tests.
1165
1166         * Scripts/old-run-webkit-tests:
1167         (isUsedInReftest):
1168
1169 2012-08-16  Peter Beverloo  <peter@chromium.org>
1170
1171         [Chromium] Pass the --strip-binary argument to the apk test generator
1172         https://bugs.webkit.org/show_bug.cgi?id=94224
1173
1174         Reviewed by Adam Barth.
1175
1176         The native test generator currently relies on the $STRIP environment
1177         variable to be available, which it shouldn't do. Instead, pass it as an
1178         argument to the script. The $STRIP variable is being deprecated.
1179
1180         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1181         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1182
1183 2012-08-16  Xiaobo Wang  <xbwang@torchmobile.com.cn>
1184
1185         [BlackBerry] Update format of JS console message to keep consistent with other ports.
1186         https://bugs.webkit.org/show_bug.cgi?id=94058
1187
1188         Reviewed by Yong Li.
1189         Reviewed internally by George Staikos.
1190
1191         1. Remove line number if it's zero.
1192         2. Print only file name for "file://" URL.
1193
1194         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1195         (BlackBerry::WebKit::DumpRenderTree::addMessageToConsole):
1196
1197 2012-08-16  Simon Hausmann  <simon.hausmann@nokia.com>
1198
1199         [Qt] Make DRT results more reliable on X11
1200
1201         Reviewed by Jocelyn Turcotte.
1202
1203         Disable desktop setting awareness, to prevent QApplication on X11 from reading palette settings from
1204         the running desktop environment.
1205
1206         * DumpRenderTree/qt/main.cpp:
1207         (main):
1208
1209 2012-08-16  Pierre Rossi  <pierre.rossi@gmail.com>
1210
1211         [Qt] Remove FontQt4, HAVE_QRAWFONT flag and the related dead code
1212         https://bugs.webkit.org/show_bug.cgi?id=93960
1213
1214         Reviewed by Simon Hausmann.
1215
1216         Following the removal of Qt 4 support from trunk in r124879.
1217
1218         * qmake/mkspecs/features/features.prf:
1219
1220 2012-08-16  Taiju Tsuiki  <tzik@chromium.org>
1221
1222         Add deleteFileSystem support to DumpRenderTree for chromium
1223         https://bugs.webkit.org/show_bug.cgi?id=94071
1224
1225         Reviewed by Kent Tamura.
1226
1227         * DumpRenderTree/chromium/WebViewHost.cpp:
1228         (WebViewHost::deleteFileSystem): Added
1229         * DumpRenderTree/chromium/WebViewHost.h:
1230         (WebViewHost):
1231
1232 2012-08-15  Ryosuke Niwa  <rniwa@webkit.org>
1233
1234         Rename LayoutTestController to TestRunner in WebKitTestRunner
1235         https://bugs.webkit.org/show_bug.cgi?id=93942
1236
1237         Reviewed by Simon Fraser.
1238
1239         Renamed the class and relevant files.
1240
1241         * WebKitTestRunner/CMakeLists.txt:
1242         * WebKitTestRunner/DerivedSources.make:
1243         * WebKitTestRunner/GNUmakefile.am:
1244         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Removed.
1245         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Copied from Tools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl.
1246         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
1247         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1248         (WTR::InjectedBundle::didReceiveMessage):
1249         (WTR::InjectedBundle::beginTesting):
1250         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1251         (WTR::InjectedBundle::testRunner):
1252         (InjectedBundle):
1253         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1254         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Removed.
1255         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Removed.
1256         * WebKitTestRunner/InjectedBundle/Target.pri:
1257         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp.
1258         * WebKitTestRunner/InjectedBundle/TestRunner.h: Copied from Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h.
1259         (TestRunner):
1260         * WebKitTestRunner/InjectedBundle/efl/LayoutTestControllerEfl.cpp: Removed.
1261         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/efl/LayoutTestControllerEfl.cpp.
1262         (WTR::waitToDumpWatchdogTimerCallback):
1263         (WTR::TestRunner::platformInitialize):
1264         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
1265         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1266         (WTR::TestRunner::pathToLocalResource):
1267         (WTR::TestRunner::platformName):
1268         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp: Removed.
1269         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp.
1270         (WTR::waitToDumpWatchdogTimerCallback):
1271         (WTR::TestRunner::platformInitialize):
1272         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
1273         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1274         (WTR::TestRunner::pathToLocalResource):
1275         (WTR::TestRunner::platformName):
1276         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm: Removed.
1277         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm.
1278         (WTR::TestRunner::platformInitialize):
1279         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
1280         (WTR::waitUntilDoneWatchdogTimerFired):
1281         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1282         (WTR::TestRunner::pathToLocalResource):
1283         (WTR::TestRunner::platformName):
1284         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: Removed.
1285         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp.
1286         (WTR::WatchdogTimerHelper::timerFired):
1287         (WTR::TestRunner::platformInitialize):
1288         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
1289         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1290         (WTR::TestRunner::pathToLocalResource):
1291         (WTR::TestRunner::platformName):
1292         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp: Removed.
1293         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp.
1294         (WTR::TestRunner::platformInitialize):
1295         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
1296         (WTR::waitToDumpWatchdogTimerFired):
1297         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1298         (WTR::TestRunner::pathToLocalResource):
1299         (WTR::TestRunner::platformName):
1300         * WebKitTestRunner/PlatformEfl.cmake:
1301         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1302         * WebKitTestRunner/win/InjectedBundle.vcproj:
1303
1304 2012-08-15  Xianzhu Wang  <wangxianzhu@chromium.org>
1305
1306         [Chromium-Android] DumpRenderTree timeouts before NRWT timeouts
1307         https://bugs.webkit.org/show_bug.cgi?id=94155
1308
1309         Reviewed by Dirk Pranke.
1310
1311         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1312         (ChromiumAndroidPort.create_driver): Force no_timeout=True
1313
1314 2012-08-15  Ryosuke Niwa  <rniwa@webkit.org>
1315
1316         Add a hyperlink to perf-o-matic from build.webkit.org/root.html
1317         https://bugs.webkit.org/show_bug.cgi?id=93749
1318
1319         Reviewed by Csaba Osztrogonác.
1320
1321         Added the hyperlink to webkit-perf.appspot.com. Also added hyperlinks to the waterfall display
1322         of performance tests.
1323
1324         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1325
1326 2012-08-15  Bruno de Oliveira Abinader  <bruno.abinader@basyskom.com>
1327
1328         [css3-text] Add CSS3 Text decoration compile flag
1329         https://bugs.webkit.org/show_bug.cgi?id=93863
1330
1331         Reviewed by Julien Chaffraix.
1332
1333         This patch handles the compile flag implementation, which will come disabled by
1334         default, thus not exposing the CSS3 text decoration features to the web, unless
1335         when explicitly enabling it with "--css3-text-decoration" build parameter.
1336
1337         * Scripts/webkitperl/FeatureList.pm:
1338         * qmake/mkspecs/features/features.pri:
1339
1340 2012-08-15  Beth Dakin  <bdakin@apple.com>
1341
1342         https://bugs.webkit.org/show_bug.cgi?id=93693
1343         [WK2] REGRESSION(125091): pixel results don't sow scrollbars 
1344         anymore
1345
1346         Reviewed by Sam Weinig.
1347
1348         Use new API WKBundlePageCreateSnapshotWithOptions().
1349         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1350         (WTR::InjectedBundlePage::dump):
1351
1352 2012-08-15  Alexey Proskuryakov  <ap@apple.com>
1353
1354         Add rfong to Bugzilla CC "contributor" list.
1355
1356         * Scripts/webkitpy/common/config/committers.py:
1357
1358 2012-08-15  Scott Graham  <scottmg@chromium.org>
1359
1360         Rename window.internals.fastMallocStatistics to mallocStatistics
1361         https://bugs.webkit.org/show_bug.cgi?id=94033
1362
1363         Reviewed by Adam Barth.
1364
1365         * GNUmakefile.am:
1366         * Scripts/webkitpy/performance_tests/perftest.py:
1367         (PerfTest):
1368         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1369         (test_run_memory_test):
1370
1371 2012-08-15  Peter Beverloo  <peter@chromium.org>
1372
1373         Fix a warning in TestWebKitAPI's MediaTime test-suite
1374         https://bugs.webkit.org/show_bug.cgi?id=94096
1375
1376         Reviewed by Adam Barth.
1377
1378         This warning is visible when building the file with certain GCC versions,
1379         including the one used by Chromium for Android. The warning is visible in
1380         the cr-android build bot output:
1381
1382         MediaTime.cpp:152: warning: this decimal constant is unsigned only in ISO C90
1383
1384         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1385         (TestWebKitAPI::TEST):
1386
1387 2012-08-15  Kevin Funk  <kevin.funk@kdab.com>
1388
1389         Fix the 'git log' call in VCSUtils.pm for Windows
1390         https://bugs.webkit.org/show_bug.cgi?id=94113
1391
1392         Reviewed by Kenneth Rohde Christiansen.
1393
1394         Failed because of invalid enquoting characters.
1395
1396         * Scripts/VCSUtils.pm:
1397
1398 2012-08-14  Gustavo Noronha Silva  <gns@gnome.org>
1399
1400         [jhbuild] move md5sum checking to update-webkit-libs-jhbuild
1401         https://bugs.webkit.org/show_bug.cgi?id=93208
1402
1403         Reviewed by Martin Robinson.
1404
1405         This change makes the md5sum check and saving be done by the script
1406         that performs the dependencies update. build-webkit no longer prefixes
1407         calls to commands with jhbuild-wrapper if jhbuild has not been
1408         bootstrapped by the developer and --update-gtk is not given.
1409
1410         * Scripts/update-webkit-libs-jhbuild:
1411         (getMD5HashForFile): moved from webkitdirs.
1412         (jhbuildConfigurationChanged): ditto.
1413         (saveJhbuildMd5): ditto.
1414         (cleanJhbuild): ditto, and changed to run jhbuild clean before removing
1415         jhbuild.
1416         * Scripts/webkitdirs.pm:
1417         (runAutogenForAutotoolsProjectIfNecessary): use jhbuildWrapperPrefixIfNeeded.
1418         (buildAutotoolsProject): ditto.
1419         (jhbuildWrapperPrefixIfNeeded): add a code branch for GTK+.
1420         (generateBuildSystemFromCMakeProject): call update-webkitefl-libs
1421         unconditionally for EFL.
1422         * jhbuild/jhbuild-wrapper:
1423         (update_webkit_libs_jhbuild): removed, jhbuild-wrapper no longer runs the
1424         update script itself
1425         (ensure_jhbuild): remove update call.
1426
1427 2012-08-15  Christophe Dumez  <christophe.dumez@intel.com>
1428
1429         [WK2] Add support for Web Intents MessagePorts
1430         https://bugs.webkit.org/show_bug.cgi?id=89072
1431
1432         Reviewed by Kenneth Rohde Christiansen.
1433
1434         Use WKBundleIntent instead of WebIntentData in
1435         WebKitTestRunner. WTR now prints the number of
1436         MessagePorts in received Web intents as
1437         expected by the following layout tests:
1438         webintents/web-intents-invoke-port.html
1439         webintents/web-intents-obj-constructor.html
1440
1441         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1442         (WTR::InjectedBundlePage::didReceiveIntentForFrame):
1443         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1444         (WTR::LayoutTestController::deliverWebIntent):
1445
1446 2012-08-14  Ryosuke Niwa  <rniwa@webkit.org>
1447
1448         Build fix after r125516. Revert the erroneous rename since we need to keep exposing
1449         layoutTestController in Chromium port as explained r124785.
1450
1451         * DumpRenderTree/chromium/TestShell.cpp:
1452         (TestShell::bindJSObjectsToWindow):
1453
1454 2012-08-14  Dan Bernstein  <mitz@apple.com>
1455
1456         fast/events/overflow-scroll-fake-mouse-move.html and fast/events/frame-scroll-fake-mouse-move.html are failing in WebKit1
1457         https://bugs.webkit.org/show_bug.cgi?id=94045
1458
1459         Reviewed by Geoff Garen.
1460
1461         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1462         (-[DumpRenderTreeWindow _hasKeyAppearance]): Added. Returns [self isKeyWindow]. This is
1463         needed now that WebView uses -_hasKeyAppearance instead of -isKeyWindow.
1464
1465 2012-08-14  Alexey Proskuryakov  <ap@apple.com>
1466
1467         [WK2] Fix some typos in MiniBrowser
1468         https://bugs.webkit.org/show_bug.cgi?id=94047
1469
1470         Reviewed by Jon Honeycutt.
1471
1472         * MiniBrowser/mac/AppDelegate.m:
1473         (didReceiveMessageFromInjectedBundle): (-[BrowserAppDelegate init]):
1474         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1475         (didReceiveMessage):
1476         (WKBundleInitialize):
1477
1478 2012-08-14  Roger Fong  <roger_fong@apple.com>
1479
1480         old-run-webkit-tests should skip all file extensions for ref tests, not just .html.
1481         https://bugs.webkit.org/show_bug.cgi?id=93904
1482
1483         Reviewed by Tim Horton.
1484
1485         old-run-webkit-tests ref test only skipped .html test.
1486         They need to skip .html, .shtml, .xml, .xhtml, .pl, .htm, .php, .svg, .mht.
1487         
1488         * Scripts/old-run-webkit-tests:
1489         (isUsedInReftest): Skip all extensions for ref tests.
1490
1491 2012-08-14  Lauro Neto  <lauro.neto@openbossa.org>
1492
1493         Convert signals/slots to Q_* macros.
1494
1495         [Qt] Use Q_SLOTS and Q_SIGNALS instead of slots and signals
1496         https://bugs.webkit.org/show_bug.cgi?id=93996
1497
1498         Reviewed by Kenneth Rohde Christiansen.
1499
1500         Change usage of keyword-conflicting 'signals' and 'slots' for
1501         Q_SIGNALS and Q_SLOTS macro.
1502
1503         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1504         (NetworkAccessManager):
1505         (WebPage):
1506         * DumpRenderTree/qt/EventSenderQt.h:
1507         (EventSender):
1508         * DumpRenderTree/qt/GCControllerQt.h:
1509         (GCController):
1510         * DumpRenderTree/qt/TestRunnerQt.h:
1511         (TestRunner):
1512         * DumpRenderTree/qt/TextInputControllerQt.h:
1513         (TextInputController):
1514         * MiniBrowser/qt/BrowserWindow.h:
1515         (BrowserWindow):
1516         * MiniBrowser/qt/MiniBrowserApplication.h:
1517         (WindowOptions):
1518         * MiniBrowser/qt/UrlLoader.h:
1519         (UrlLoader):
1520         * QtTestBrowser/cookiejar.h:
1521         (TestBrowserCookieJar):
1522         * QtTestBrowser/fpstimer.h:
1523         (FpsTimer):
1524         * QtTestBrowser/launcherwindow.h:
1525         (LauncherWindow):
1526         * QtTestBrowser/locationedit.h:
1527         (LocationEdit):
1528         * QtTestBrowser/mainwindow.h:
1529         (MainWindow):
1530         * QtTestBrowser/urlloader.h:
1531         (UrlLoader):
1532         * QtTestBrowser/webinspector.h:
1533         (WebInspector):
1534         * QtTestBrowser/webpage.h:
1535         (WebPage):
1536         * QtTestBrowser/webview.h:
1537         (WebViewGraphicsBased):
1538         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1539         (WatchdogTimerHelper):
1540         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1541         (WrapperWindow):
1542         * WebKitTestRunner/qt/main.cpp:
1543         (Launcher):
1544
1545 2012-08-14  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1546
1547         WebKitTestRunner needs layoutTestController.dumpResourceLoadCallbacks
1548         https://bugs.webkit.org/show_bug.cgi?id=42332
1549
1550         Reviewed by Kenneth Rohde Christiansen.
1551
1552         Added Resource Callbacks logging. Several aux dumping functions are added.
1553
1554         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1555         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1556         (WTR::isFileScheme):
1557         (WTR):
1558         (WTR::pathSuitableForTestResult):
1559         (WTR::urlSuitableForTestResult):
1560         (WTR::InjectedBundlePage::resetAfterTest):
1561         (WTR::dumpRequestDescriptionSuitableForTestResult):
1562         (WTR::dumpResponseDescriptionSuitableForTestResult):
1563         (WTR::dumpErrorDescriptionSuitableForTestResult):
1564         (WTR::InjectedBundlePage::didInitiateLoadForResource):
1565         (WTR::InjectedBundlePage::willSendRequestForFrame):
1566         (WTR::InjectedBundlePage::didReceiveResponseForResource):
1567         (WTR::InjectedBundlePage::didFinishLoadForResource):
1568         (WTR::InjectedBundlePage::didFailLoadForResource):
1569         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1570         (WTR::LayoutTestController::LayoutTestController):
1571         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1572         (WTR::LayoutTestController::dumpResourceLoadCallbacks):
1573         (WTR::LayoutTestController::shouldDumpResourceLoadCallbacks):
1574         (LayoutTestController):
1575
1576 2012-08-14  Alexis Menard  <alexis.menard@openbossa.org>
1577
1578         Update INdT build bot to Mountain Lion.
1579         https://bugs.webkit.org/show_bug.cgi?id=93963
1580
1581         Reviewed by Csaba Osztrogonác.
1582
1583         We updated the machine as well as the OS as the Qt port is now running
1584         on top of Qt5.
1585
1586         * BuildSlaveSupport/build.webkit.org-config/config.json:
1587
1588 2012-08-14  Peter Beverloo  <peter@chromium.org>
1589
1590         [Chromium] Remove unneeded build logic for Android
1591         https://bugs.webkit.org/show_bug.cgi?id=93962
1592
1593         Reviewed by Dimitri Glazkov.
1594
1595         The Android SDK and NDK have been checked in to the Chromium tree, which
1596         allows WebKit to leverage those as well. They will already be pulled in
1597         through a DEPS change made last week, and by not setting the ANDROID_NDK_ROOT
1598         environment variable, the envsetup.sh will set the project files up
1599         appropriately for us.
1600
1601         * Scripts/webkitdirs.pm:
1602
1603 2012-08-14  Sergio Villar Senin  <svillar@igalia.com>
1604
1605         [WK2] [GTK] Plugin tests failing in WK2 bot
1606         https://bugs.webkit.org/show_bug.cgi?id=93954
1607
1608         Reviewed by Carlos Garcia Campos.
1609
1610         Plugin tests are failing in the WK2 bot because we aren't exporting
1611         the Netscape plugin when creating the product archive.
1612
1613         * BuildSlaveSupport/built-product-archive: added TestNetscapePlugin
1614         to the list of directories to export.
1615         (archiveBuiltProduct):
1616
1617 2012-08-14  Peter Beverloo  <peter@chromium.org>
1618
1619         [Chromium] Fix apk generation for the Android platform
1620         https://bugs.webkit.org/show_bug.cgi?id=93841
1621
1622         Unreviewed build fix.
1623
1624         APK generation was broken as the configuration file assumed compilation
1625         would only occur in the Chromium tree. Pass the path to Chromium's source
1626         base directory as a property to ant.
1627
1628         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1629         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1630
1631 2012-08-14  Sergio Villar Senin  <svillar@igalia.com>
1632
1633         [GTK] REGRESSION (r122428) WebKit2APITests/TestWebKitFindController fails "next" test
1634         https://bugs.webkit.org/show_bug.cgi?id=91083
1635
1636         Reviewed by Carlos Garcia Campos.
1637
1638         Unskipped a couple of API tests that should work fine from now on.
1639
1640         * Scripts/run-gtk-tests:
1641         (TestRunner):
1642
1643 2012-08-14  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1644
1645         [NRWT] Compare results between different platforms
1646         https://bugs.webkit.org/show_bug.cgi?id=90555
1647
1648         Reviewed by Dirk Pranke.
1649
1650         * Scripts/webkitpy/layout_tests/port/base.py:
1651         (Port.baseline_search_path):
1652         (Port):
1653         (Port.compare_baseline):
1654         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1655         (parse_args):
1656
1657 2012-08-13  Ryosuke Niwa  <rniwa@webkit.org>
1658
1659         Rename LayoutTestController to TestRunner in DumpRenderTree
1660         https://bugs.webkit.org/show_bug.cgi?id=93758
1661
1662         Reviewed by Tony Chang.
1663
1664         Renamed LayoutTestController to TestRunner. For Chromium port, it's renamed to DRTTestRunner
1665         since it already has TestRunner class shared between DumpRenderTree and content_shell.
1666
1667         * DumpRenderTree/DumpRenderTree.h:
1668         * DumpRenderTree/PixelDumpSupport.cpp:
1669         * DumpRenderTree/StorageTrackerDelegate.h:
1670         * DumpRenderTree/StorageTrackerDelegate.mm:
1671         * DumpRenderTree/TestRunner.cpp:
1672         * DumpRenderTree/TestRunner.h:
1673         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1674         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1675         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1676         * DumpRenderTree/chromium/DRTTestRunner.h:
1677         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1678         * DumpRenderTree/chromium/NotificationPresenter.h:
1679         * DumpRenderTree/chromium/TestShell.cpp:
1680         * DumpRenderTree/chromium/TestShell.h:
1681         * DumpRenderTree/chromium/WebPermissions.cpp:
1682         * DumpRenderTree/chromium/WebPermissions.h:
1683         * DumpRenderTree/chromium/WebViewHost.cpp:
1684         * DumpRenderTree/chromium/WebViewHost.h:
1685         * DumpRenderTree/efl/DumpRenderTree.cpp:
1686         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1687         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1688         * DumpRenderTree/efl/EditingCallbacks.cpp:
1689         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1690         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1691         * DumpRenderTree/gtk/EditingCallbacks.cpp:
1692         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1693         * DumpRenderTree/mac/DumpRenderTree.mm:
1694         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1695         * DumpRenderTree/mac/EditingDelegate.mm:
1696         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1697         * DumpRenderTree/mac/HistoryDelegate.mm:
1698         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1699         * DumpRenderTree/mac/PolicyDelegate.h:
1700         * DumpRenderTree/mac/PolicyDelegate.mm:
1701         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1702         * DumpRenderTree/mac/TestRunnerMac.mm:
1703         * DumpRenderTree/mac/UIDelegate.mm:
1704         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1705         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1706         * DumpRenderTree/qt/TestRunnerQt.cpp:
1707         * DumpRenderTree/qt/TestRunnerQt.h:
1708         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1709         * DumpRenderTree/win/DumpRenderTree.cpp:
1710         * DumpRenderTree/win/EditingDelegate.cpp:
1711         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1712         * DumpRenderTree/win/HistoryDelegate.cpp:
1713         * DumpRenderTree/win/PolicyDelegate.h:
1714         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1715         * DumpRenderTree/win/TestRunnerWin.cpp:
1716         * DumpRenderTree/win/UIDelegate.cpp:
1717         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1718         * DumpRenderTree/wx/TestRunnerWx.cpp:
1719
1720 2012-08-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1721
1722         [GTK] String returned by g_path_get_dirname() must be freed
1723         https://bugs.webkit.org/show_bug.cgi?id=93885
1724
1725         Reviewed by Philippe Normand.
1726
1727         Fix a memory leak in GTK's DRT code.
1728
1729         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1730         (pathFromSoupURI): Free the string returned by g_path_get_dirname().
1731
1732 2012-08-14  Zan Dobersek  <zandobersek@gmail.com>
1733
1734         Unreviewed GTK build fix after r125508.
1735
1736         Do the renaming in GNUmakefile.am as well, LayoutTestController -> TestRunner.
1737
1738         * GNUmakefile.am:
1739
1740 2012-08-13  Ryosuke Niwa  <rniwa@webkit.org>
1741
1742         Rename files that declare and define LayoutTestController in DumpRenderTree
1743         https://bugs.webkit.org/show_bug.cgi?id=93899
1744
1745         Reviewed by Tony Chang.
1746
1747         Renamed files and fixed style errors.
1748
1749         * DumpRenderTree/DumpRenderTree.gypi:
1750         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1751         * DumpRenderTree/LayoutTestController.cpp: Removed.
1752         * DumpRenderTree/LayoutTestController.h: Removed.
1753         * DumpRenderTree/PixelDumpSupport.cpp:
1754         * DumpRenderTree/StorageTrackerDelegate.mm:
1755         * DumpRenderTree/TestRunner.cpp: Copied from Tools/DumpRenderTree/LayoutTestController.cpp.
1756         * DumpRenderTree/TestRunner.h: Copied from Tools/DumpRenderTree/LayoutTestController.h.
1757         (LayoutTestController):
1758         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1759         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp: Removed.
1760         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Copied from Tools/DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp.
1761         * DumpRenderTree/chromium/DRTTestRunner.cpp: Copied from Tools/DumpRenderTree/chromium/LayoutTestController.cpp.
1762         * DumpRenderTree/chromium/DRTTestRunner.h: Copied from Tools/DumpRenderTree/chromium/LayoutTestController.h.
1763         * DumpRenderTree/chromium/LayoutTestController.cpp: Removed.
1764         * DumpRenderTree/chromium/LayoutTestController.h: Removed.
1765         * DumpRenderTree/chromium/TestShell.cpp:
1766         * DumpRenderTree/chromium/TestShell.h:
1767         * DumpRenderTree/chromium/WebPermissions.cpp:
1768         * DumpRenderTree/chromium/WebViewHost.cpp:
1769         * DumpRenderTree/efl/CMakeLists.txt:
1770         * DumpRenderTree/efl/DumpRenderTree.cpp:
1771         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1772         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1773         * DumpRenderTree/efl/EditingCallbacks.cpp:
1774         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Removed.
1775         * DumpRenderTree/efl/TestRunnerEfl.cpp: Copied from Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp.
1776         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1777         * DumpRenderTree/gtk/EditingCallbacks.cpp:
1778         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Removed.
1779         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Copied from Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp.
1780         * DumpRenderTree/mac/DumpRenderTree.mm:
1781         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1782         * DumpRenderTree/mac/EditingDelegate.mm:
1783         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1784         * DumpRenderTree/mac/HistoryDelegate.mm:
1785         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Removed.
1786         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1787         * DumpRenderTree/mac/PolicyDelegate.mm:
1788         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1789         * DumpRenderTree/mac/TestRunnerMac.mm: Copied from Tools/DumpRenderTree/mac/LayoutTestControllerMac.mm.
1790         * DumpRenderTree/mac/UIDelegate.mm:
1791         * DumpRenderTree/qt/DumpRenderTree.pro:
1792         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1793         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Removed.
1794         * DumpRenderTree/qt/LayoutTestControllerQt.h: Removed.
1795         * DumpRenderTree/qt/TestRunnerQt.cpp: Copied from Tools/DumpRenderTree/qt/LayoutTestControllerQt.cpp.
1796         * DumpRenderTree/qt/TestRunnerQt.h: Copied from Tools/DumpRenderTree/qt/LayoutTestControllerQt.h.
1797         (WebCore):
1798         (LayoutTestController):
1799         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
1800         (LayoutTestController::dumpSelectionRect):
1801         (LayoutTestController::setCallCloseOnWebViews):
1802         (LayoutTestController::addDisallowedURL):
1803         (LayoutTestController::abortModal):
1804         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1805         * DumpRenderTree/win/DumpRenderTree.cpp:
1806         * DumpRenderTree/win/DumpRenderTree.vcproj:
1807         * DumpRenderTree/win/EditingDelegate.cpp:
1808         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1809         * DumpRenderTree/win/HistoryDelegate.cpp:
1810         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Removed.
1811         * DumpRenderTree/win/PolicyDelegate.cpp:
1812         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1813         * DumpRenderTree/win/TestRunnerWin.cpp: Copied from Tools/DumpRenderTree/win/LayoutTestControllerWin.cpp.
1814         (LayoutTestController::setUserStyleSheetEnabled):
1815         (resolveCygwinPath):
1816         * DumpRenderTree/win/UIDelegate.cpp:
1817         * DumpRenderTree/wscript:
1818         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1819         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Removed.
1820         * DumpRenderTree/wx/TestRunnerWx.cpp: Copied from Tools/DumpRenderTree/wx/LayoutTestControllerWx.cpp.
1821
1822 2012-08-13  Alex Christensen  <alex.christensen@flexsim.com>
1823
1824         Windows 64 bit compliance
1825         https://bugs.webkit.org/show_bug.cgi?id=93275
1826
1827         Reviewed by Brent Fulgham.
1828
1829         Fixed a few compile and link problems for Win64
1830
1831         * WinLauncher/WinLauncher.cpp:
1832         * win/DLLLauncher/DLLLauncherMain.cpp:
1833
1834 2012-08-13  MORITA Hajime  <morrita@google.com>
1835
1836         Unreviewed update for webcomponents-bugzilla address.
1837
1838         * Scripts/webkitpy/common/config/committers.py:
1839
1840 2012-08-11  Raphael Kubo da Costa  <rakuco@webkit.org>
1841
1842         [CMake] Rewrite FindLibSoup2.cmake.
1843         https://bugs.webkit.org/show_bug.cgi?id=93191
1844
1845         Reviewed by Rob Buis.
1846
1847         * DumpRenderTree/efl/CMakeLists.txt: Use LIBSOUP_FOO instead of
1848         LIBSOUP24_FOO, and do not use LIBSOUP24_LDFLAGS, as it is not
1849         needed anymore.
1850         * EWebLauncher/CMakeLists.txt: Ditto.
1851         * MiniBrowser/efl/CMakeLists.txt: Ditto.
1852         * TestWebKitAPI/PlatformEfl.cmake: Ditto.
1853         * WebKitTestRunner/CMakeLists.txt: Ditto.
1854         * WebKitTestRunner/PlatformEfl.cmake: Ditto.
1855
1856 2012-08-13  Brady Eidson  <beidson@apple.com>
1857
1858         With asynchronous plug-in initialization, WebProcess and PluginProcess can deadlock
1859         <rdar://problem/12062125> and https://bugs.webkit.org/show_bug.cgi?id=93894
1860
1861         Reviewed by Alexey Proskuryakov.
1862
1863         Add a test that calls out to NPP_Evaluate for some JS inside of NPP_New.
1864
1865         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1866         * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSWithinNPP_New.cpp: Added.
1867         (EvaluteJSWithinNPP_New):
1868         (EvaluteJSWithinNPP_New::EvaluteJSWithinNPP_New):
1869         (EvaluteJSWithinNPP_New::NPP_New):
1870
1871 2012-08-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1872
1873         Unreviewed, rolling out r125422.
1874         http://trac.webkit.org/changeset/125422
1875         https://bugs.webkit.org/show_bug.cgi?id=93902
1876
1877         Broke the Android canary build (Requested by fmalita on
1878         #webkit).
1879
1880         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1881         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1882
1883 2012-08-13  Raphael Kubo da Costa  <rakuco@webkit.org>
1884
1885         [CMake] Remove glib-related Find modules and write single new one instead.
1886         https://bugs.webkit.org/show_bug.cgi?id=93786
1887
1888         Reviewed by Rob Buis.
1889
1890         * DumpRenderTree/efl/CMakeLists.txt: Use GLIB_* instead of Glib_*.
1891         * EWebLauncher/CMakeLists.txt: Ditto.
1892         * MiniBrowser/efl/CMakeLists.txt: Ditto.
1893         * WebKitTestRunner/PlatformEfl.cmake: Ditto.
1894
1895 2012-08-13  Peter Beverloo  <peter@chromium.org>
1896
1897         [Chromium] Fix apk generation for the Android platform
1898         https://bugs.webkit.org/show_bug.cgi?id=93841
1899
1900         Reviewed by Dimitri Glazkov.
1901
1902         APK generation was broken as the configuration file assumed compilation
1903         would only occur in the Chromium tree. Pass the path to Chromium's source
1904         base directory as a property to ant.
1905
1906         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1907         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1908
1909 2012-08-13  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1910
1911         [WK2] [WTR] InjectedBundlePage::didFailLoadForResource invokes wrong callback
1912         https://bugs.webkit.org/show_bug.cgi?id=93825
1913
1914         Reviewed by Antonio Gomes.
1915
1916         Corrected from didFinishLoadForResource() invoke to didFailLoadForResource() invoke. 
1917
1918         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1919         (WTR::InjectedBundlePage::didFailLoadForResource):
1920
1921 2012-08-13  Kwang Yul Seo  <skyul@company100.net>
1922
1923         [Qt] Add gprof.prf to build WebKit with gprof enabled
1924         https://bugs.webkit.org/show_bug.cgi?id=90283
1925
1926         Reviewed by Eric Seidel.
1927
1928         * qmake/mkspecs/features/functions.prf:
1929         gprof does not support profiling a shared library.
1930         To profile WebKit, applications must link QtWebKit statically.
1931
1932         * qmake/mkspecs/features/gprof.prf: Added.
1933         Add -pg option to both QMAKE_CXXFLAGS and QMAKE_LFLAGS.
1934
1935 2012-08-13  KwangYong Choi  <ky0.choi@samsung.com>
1936
1937         [TestNetscapePlugin][X11] Additional key up event handler routine is required
1938         https://bugs.webkit.org/show_bug.cgi?id=91357
1939
1940         Reviewed by Eric Seidel.
1941
1942         Fixed key up event handler routine to pass http/tests/plugins/plugin-document-
1943         has-focus.html on X11 architecture. The test can not be done without this patch.
1944         All other ports implemented it already.
1945
1946         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1947         (handleEventX11): Modified key up event handler for X11
1948
1949 2012-08-13  Christophe Dumez  <christophe.dumez@intel.com>
1950
1951         [EFL][WK2] Replace Skipped list by TestExpectations
1952         https://bugs.webkit.org/show_bug.cgi?id=93796
1953
1954         Reviewed by Kenneth Rohde Christiansen.
1955
1956         Enable cascaded TestExpectations for EFL port so
1957         that we can use TestExpectations in WK2-EFL.
1958
1959         * Scripts/webkitpy/layout_tests/port/efl.py:
1960         (EflPort._search_paths):
1961         (EflPort):
1962         (EflPort.expectations_files):
1963
1964 2012-08-13  Peter Gal  <galpeter@inf.u-szeged.hu>
1965
1966         REGRESSION(r125153): It broke the 'Unexpected no expected results' case
1967         https://bugs.webkit.org/show_bug.cgi?id=93789
1968
1969         Reviewed by Csaba Osztrogonác.
1970
1971         Fix the regex, so the text won't be a capturing group.
1972
1973         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1974         (RunWebKitTests._parseNewRunWebKitTestsOutput):
1975
1976 2012-08-12  MORITA Hajime  <morrita@google.com>
1977
1978         Unreviewed, added a proxy address to contributors_who_are_not_committers.
1979
1980         * Scripts/webkitpy/common/config/committers.py:
1981
1982 2012-08-12  Loïc Yhuel  <loic.yhuel@softathome.com>
1983
1984         [Qt] Make it possible to build without QtTest/QtPrintSupport
1985         https://bugs.webkit.org/show_bug.cgi?id=93492
1986
1987         Reviewed by Tor Arne Vestbø.
1988
1989         * DumpRenderTree/qt/DumpRenderTree.pro: Optional printsupport
1990         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1991         (WebCore):
1992         (WebCore::DumpRenderTree::dryRunPrint): Does nothing if no printsupport
1993         * QtTestBrowser/QtTestBrowser.pro: Optional printsupport
1994         * QtTestBrowser/launcherwindow.cpp:
1995         (LauncherWindow::createChrome): No print menu if no printsupport
1996         (LauncherWindow::print): Does nothing if no printsupport
1997         * QtTestBrowser/launcherwindow.h:
1998         * Tools.pro: Disable DRT/WTR if QtTest not present
1999         * qmake/mkspecs/features/default_pre.prf: printsupport no more mandatory
2000         * qmake/mkspecs/features/features.prf: Qt module availability tests
2001
2002 2012-08-12  Csaba Osztrogonác  <ossy@webkit.org>
2003
2004         master.cfg unittest cleanup: Show DeprecationWarnings with python >= 2.7 too
2005         https://bugs.webkit.org/show_bug.cgi?id=90161
2006
2007         Reviewed by Eric Seidel.
2008
2009         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2010
2011 2012-08-12  Simon Hausmann  <simon.hausmann@nokia.com>
2012
2013         [Qt] Unreviewed trivial build fix: Newer Qt versions don't implicitly include qwindowsysteminterface.h
2014         through the QTestLib headers anymore.
2015
2016         * DumpRenderTree/qt/EventSenderQt.cpp:
2017         * WebKitTestRunner/Target.pri:
2018         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
2019
2020 2012-08-11  Sam Weinig  <sam@webkit.org>
2021
2022         Remove ability to run MiniBrowser in threaded mode, it hasn't worked for a long time
2023         https://bugs.webkit.org/show_bug.cgi?id=93774
2024
2025         Reviewed by Dan Bernstein.
2026
2027         Remove support for opening windows using the shared thread WKContextRef. WKContextGetSharedThreadContext()
2028         is going away, due to not working for a long time, and the first step is removing all the callers.
2029
2030         While here, remove the BrowserStatisticsWindow, which was not providing interesting information.
2031
2032         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2033         * MiniBrowser/mac/AppDelegate.h:
2034         * MiniBrowser/mac/AppDelegate.m:
2035         (-[BrowserAppDelegate init]):
2036         (-[BrowserAppDelegate newWindow:]):
2037         (-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):
2038         * MiniBrowser/mac/BrowserStatisticsWindow.xib: Removed.
2039         * MiniBrowser/mac/BrowserStatisticsWindowController.h: Removed.
2040         * MiniBrowser/mac/BrowserStatisticsWindowController.m: Removed.
2041         * MiniBrowser/mac/MainMenu.xib:
2042         * MiniBrowser/win/BrowserView.cpp:
2043         (BrowserView::create):
2044
2045 2012-08-11  Sam Weinig  <sam@webkit.org>
2046
2047         Enable XPC Service based WebProcess with runtime flag
2048         https://bugs.webkit.org/show_bug.cgi?id=93773
2049
2050         Reviewed by Dan Bernstein.
2051
2052         Convert --use-web-process-xpc-service passed to run-safari (and similar scripts)
2053         to setting WEBKIT_USE_XPC_SERVICE_FOR_WEB_PROCESS=YES in the environment and setting
2054         up __XPC_DYLD_FRAMEWORK_PATH and __XPC_DYLD_INSERT_LIBRARIES variables. NOTE: using
2055         the XPC service is not the default code path.
2056
2057         * Scripts/webkitdirs.pm:
2058         (shouldUseXPCServiceForWebProcess):
2059         (determineShouldUseXPCServiceForWebProcess):
2060         Add functions to extract --use-web-process-xpc-service from ARGV and set a
2061         global variable.
2062
2063         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded):
2064         Add help text for --use-web-process-xpc-service.
2065
2066         (runMacWebKitApp):
2067         Set the WEBKIT_USE_XPC_SERVICE_FOR_WEB_PROCESS environment variable and DYLD
2068         if --use-web-process-xpc-service was passed on the command line.
2069
2070         (execMacWebKitAppForDebugging):
2071         Set the WEBKIT_USE_XPC_SERVICE_FOR_WEB_PROCESS environment variable and DYLD
2072         if --use-web-process-xpc-service was passed on the command line. Also, bail
2073         if both --use-web-process-xpc-service and --target-web-process are passed on
2074         the command line, as we don't currently support using both.
2075
2076 2012-08-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2077
2078         [EFL] Bump harfbuzz dependency to v0.9.2
2079         https://bugs.webkit.org/show_bug.cgi?id=93762
2080
2081         Reviewed by Eric Seidel.
2082
2083         EFL port has used harfbuzz 0.9.0 ver. However, the 0.9.2 version was released on 10th Aug 2012.
2084         In addition, 0.9.0 ver. was disappeared. So, EFL port needs to use 0.9.2 ver. from now on.
2085
2086         * efl/jhbuild.modules:
2087
2088 2012-08-10  Ryosuke Niwa  <rniwa@webkit.org>
2089
2090         run-perf-tests should upload memory statistics to perf-o-matic
2091         https://bugs.webkit.org/show_bug.cgi?id=93690
2092
2093         Reviewed by Dirk Pranke.
2094
2095         Upload JS Heap and FastMalloc results for a test X/Y as: X/Y:JSHeap and X/Y:FastMalloc.
2096         Note "JS Heap" is converted to the CamelCase JSHeap.
2097
2098         Also did some refactoring in PerfTest.parse_output and PerfTestRunnerTest and updated
2099         some helps in PerfTest.parse_output per arv's comments.
2100
2101         * Scripts/webkitpy/performance_tests/perftest.py:
2102         (PerfTest):
2103         (PerfTest.parse_output): Include JSHeap and FastMalloc statistics in results as well as of Time.
2104         Also refactored it to avoid hard-coding indices in _result_classes and moved complied regular
2105         exressions out of the function to avoid re-compiling them every time the method runs.
2106         (PerfTest.output_statistics): Convert ':' to ': ' as well as '/'.
2107         (ChromiumStylePerfTest.parse_output): Removed an unused variable.
2108         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2109         (PerfTestsRunner._parse_args): Uploaded some helps per arv's feedback.
2110         (PerfTestsRunner._output_json_path): Extracted from _generate_and_show_results to be used in
2111         PerfTestRunnerTest.create_runner.
2112         (PerfTestsRunner._generate_and_show_results):
2113         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2114         (create_runner): Extracted runner.load_output_json from various tests.
2115         (test_run_memory_test): Added.
2116         (PerfTestRunner): Extracted _event_target_wrapper_and_inspector_results from various tests.
2117         (test_run_with_json_output):
2118         (test_run_with_description):
2119         (test_run_generates_json_by_default):
2120         (test_run_generates_and_show_results_page):
2121         (test_run_with_json_source):
2122         (test_run_with_multiple_repositories):
2123
2124 2012-08-10  Benjamin Poulain  <bpoulain@apple.com>
2125
2126         Add support for String initialization from literal to WTFString
2127         https://bugs.webkit.org/show_bug.cgi?id=93426
2128
2129         Reviewed by Anders Carlsson.
2130
2131         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2132         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2133         (TestWebKitAPI::TEST):
2134         * TestWebKitAPI/Tests/WTF/WTFString.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/StringImpl.cpp.
2135         (TestWebKitAPI):
2136         (TestWebKitAPI::TEST):
2137
2138 2012-08-10  Xianzhu Wang  <wangxianzhu@chromium.org>
2139
2140         NRWT crashes when DRT with --encode-binary crashes just before it dumps pixels
2141         https://bugs.webkit.org/show_bug.cgi?id=93728
2142
2143         Reviewed by Dirk Pranke.
2144
2145         * Scripts/webkitpy/layout_tests/port/driver.py:
2146         (ContentBlock.decode_content): Check self.content is not None before calling base64.b64decode().
2147
2148 2012-08-10  Xianzhu Wang  <wangxianzhu@chromium.org>
2149
2150         [Chromium-Android][NRWT] Executable might not be pushed correctly when there are multiple builds
2151         https://bugs.webkit.org/show_bug.cgi?id=93688
2152
2153         Reviewed by Dirk Pranke.
2154
2155         There might be other better methods, but this change is the smallest.
2156         I think the chance of equal timestamp can be ignored because we flock
2157         to avoid concurrent linkers.
2158
2159         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2160         (ChromiumAndroidDriver._push_executable): Changed '<' to '!=' to compare the timestamp.
2161
2162 2012-08-09  Xianzhu Wang  <wangxianzhu@chromium.org>
2163
2164         [Chromium-Android] Skip layout tests directories that are not applicable
2165         https://bugs.webkit.org/show_bug.cgi?id=93670
2166
2167         Reviewed by Dirk Pranke.
2168
2169         Added back ChromiumAndroidPort.skipped_layout_tests to skip some whole directories.
2170         The method is more convenient to skip whole directories than SKIP in TestExpectations
2171         because its higher priority. Will still use TestExpectations to skip individual tests.
2172
2173         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2174         (ChromiumAndroidPort.skipped_layout_tests):
2175
2176 2012-08-09  Elliott Sprehn  <esprehn@chromium.org>
2177
2178         Add myself to the Contributor list.
2179         https://bugs.webkit.org/show_bug.cgi?id=93653
2180
2181         Reviewed by Dirk Pranke.
2182
2183         Add my email to the contributor list.
2184
2185         * Scripts/webkitpy/common/config/committers.py:
2186
2187 2012-08-09  Dirk Pranke  <dpranke@chromium.org>
2188
2189         nrwt: should log progress like ninja does
2190         https://bugs.webkit.org/show_bug.cgi?id=93563
2191
2192         Reviewed by Ojan Vafai.
2193
2194         This change modifies the output of nrwt in the
2195         non--debug-rwt-logging modes.
2196
2197         In non-verbose mode, the output changes from:
2198           "Testing (50%): 96 ran as expected, 4 didn't, 100 left"
2199         to:
2200           "[100/200] foo.html (+4)"
2201         or:
2202           "[100/200] foo.html failed  unexpectedly (text diff)"
2203
2204         which indicates the earliest test currently running (optionally plus the
2205         count of other currently-executing tests if we're running tests in parallel)
2206         or the result of said test.
2207
2208         If the test produces unexpected results, that line is flushed
2209         rather than erased (so we no longer need the %d didn't running
2210         tally).
2211
2212         In --verbose mode, the output is similar, but every test gets a
2213         line (and tests are logged in order of them being started, not
2214         order of them being completed) (and in --details mode, the
2215         first line of each test matches --verbose but the other lines
2216         are unchanged).
2217         
2218         The overall result should be easier to read and is simpler to
2219         implement as well (apart from managing the number of tests that
2220         have started but not completed, which is slightly annoying).
2221
2222         This also matches the output style for test-webkitpy, more-or-less.
2223
2224         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2225         (LayoutTestRunner.run_tests):
2226         (LayoutTestRunner._update_summary_with_result):
2227         (LayoutTestRunner._handle_started_test):
2228         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
2229         (FakePrinter):
2230         (FakePrinter.print_started_test):
2231         (FakePrinter.print_finished_test):
2232         * Scripts/webkitpy/layout_tests/views/printing.py:
2233         (Printer.__init__):
2234         (Printer.print_started_test):
2235         (Printer.print_finished_test):
2236         (Printer._print_test_trace):
2237         (Printer._print_progress):
2238         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2239         (test_details):
2240
2241 2012-08-09  Alexey Proskuryakov  <ap@apple.com>
2242
2243         [WK2] Add a process model constant for multiple processes
2244         https://bugs.webkit.org/show_bug.cgi?id=93642
2245
2246         Reviewed by Anders Carlsson.
2247
2248         * MiniBrowser/mac/AppDelegate.h: Updated process model enum to match WebKit.
2249
2250 2012-08-09  Ryosuke Niwa  <rniwa@webkit.org>
2251
2252         Build fix after r125178.
2253
2254         * Scripts/webkitpy/performance_tests/perftest.py:
2255         (PerfTest.parse_output): Don't include non-time results in the JSON output.
2256         * Scripts/webkitpy/performance_tests/perftest_unittest.py: Updated the test outputs so to match
2257         actual test outputs.
2258         (MainTest.test_parse_output):
2259         (MainTest.test_parse_output_with_failing_line):
2260         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: Ditto.
2261
2262 2012-08-09  Zoltan Horvath  <zoltan@webkit.org>
2263
2264         JSHeap and FastMallocStatistics based memory measurement for performance-tests
2265         https://bugs.webkit.org/show_bug.cgi?id=90858
2266
2267         Reviewed by Ryosuke Niwa.
2268
2269         Measure the memory usage of the performancetests with the help of the windows.memory.usedJSHeapSize
2270         object and the window.internals.fastMallocStatistics() function call.
2271
2272         * Scripts/webkitpy/performance_tests/perftest.py:
2273         (PerfTest):
2274         (PerfTest.parse_output):
2275         (PerfTest.output_statistics):
2276
2277 2012-08-09  Csaba Osztrogonác  <ossy@webkit.org>
2278
2279         [Qt][Win] Build system bug revealed by r124835
2280         https://bugs.webkit.org/show_bug.cgi?id=93339
2281
2282         Reviewed by Tor Arne Vestbø.
2283
2284         Don't add "LC_ALL=c" on Windows in svnRevisionForDirectory() and in pathRelativeToSVNRepositoryRootForPath().
2285
2286         * Scripts/VCSUtils.pm:
2287         (isWindows): Copied from webkitdirs.pm.
2288         (svnRevisionForDirectory):
2289         (pathRelativeToSVNRepositoryRootForPath):
2290
2291 2012-08-08  Dirk Pranke  <dpranke@chromium.org>
2292
2293         update bot parsing of new-run-webkit-tests' output
2294         https://bugs.webkit.org/show_bug.cgi?id=93537
2295
2296         Reviewed by Ryosuke Niwa.
2297
2298         This change updates the way we parse the output from
2299         new-run-webkit-tests on the bots so that we can show a summary
2300         of the results properly after I re-land the changes that were
2301         reverted in r124994 and r124870.
2302
2303         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2304         (RunWebKitTests._parseNewRunWebKitTestsOutput):
2305
2306 2012-08-08  Shane Stephens  <shanestephens@google.com>
2307
2308         Compile flag for CSS Hierarchies
2309         https://bugs.webkit.org/show_bug.cgi?id=92433
2310
2311         Reviewed by Tony Chang.
2312
2313         * Scripts/webkitperl/FeatureList.pm:
2314         * qmake/mkspecs/features/features.pri:
2315
2316 2012-08-08  Benjamin Poulain  <bpoulain@apple.com>
2317
2318         Use char* instead of LChar* for the public interface of String construction from literals
2319         https://bugs.webkit.org/show_bug.cgi?id=93402
2320
2321         Reviewed by Michael Saboff.
2322
2323         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2324         (TestWebKitAPI::TEST):
2325
2326 2012-08-08  Dirk Pranke  <dpranke@chromium.org>
2327
2328         nrwt: rename finder.py to layout_test_finder.py
2329         https://bugs.webkit.org/show_bug.cgi?id=93557
2330
2331         Reviewed by Ryosuke Niwa.
2332
2333         One last cleanup per old review feedback from rniwa.
2334
2335         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py: Renamed from Tools/Scripts/webkitpy/layout_tests/controllers/finder.py.
2336         (LayoutTestFinder):
2337         (LayoutTestFinder.__init__):
2338         (LayoutTestFinder.find_tests):
2339         (LayoutTestFinder._strip_test_dir_prefixes):
2340         (LayoutTestFinder._strip_test_dir_prefix):
2341         (LayoutTestFinder._read_test_names_from_file):
2342         (LayoutTestFinder._strip_comments):
2343         (LayoutTestFinder.skip_tests):
2344         (LayoutTestFinder.split_into_chunks):
2345         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2346
2347 2012-08-08  Ryosuke Niwa  <rniwa@webkit.org>
2348
2349         Add Perf EWS IRC bot
2350         https://bugs.webkit.org/show_bug.cgi?id=92913
2351
2352         Reviewed by Dirk Pranke.
2353
2354         Adds the preliminary implementation of perfalizer, a IRC bot that runs performance tests
2355         based on IRC requests.
2356
2357         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2358         (MockSCM.head_svn_revision): The actual implementation returns string, so match that.
2359         (MockSCM.svn_revision): Ditto.
2360         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2361         (Bugzilla.add_attachment_to_bug): Added mimetype.
2362         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
2363         (MockBugzilla.add_attachment_to_bug): Ditto.
2364         * Scripts/webkitpy/common/system/filesystem.py:
2365         (FileSystem.copytree): Added.
2366         * Scripts/webkitpy/common/system/filesystem_mock.py:
2367         (MockFileSystem.copytree): Added.
2368         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: Rebaselined tests
2369         that had assumed revision numbers were integers.
2370         (test_run_with_json_output):
2371         (test_run_with_description):
2372         (test_run_generates_json_by_default):
2373         (test_run_generates_and_show_results_page):
2374         (test_run_with_json_source):
2375         (test_run_with_multiple_repositories):
2376         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2377         * Scripts/webkitpy/tool/commands/__init__.py:
2378         * Scripts/webkitpy/tool/commands/perfalizer.py: Added.
2379         (PerfalizerTask):
2380         (PerfalizerTask.__init__):
2381         (PerfalizerTask._copy_build_product_without_patch):
2382         (PerfalizerTask.run):
2383         (PerfalizerTask.parent_command):
2384         (PerfalizerTask.run_webkit_patch):
2385         (PerfalizerTask._json_path):
2386         (PerfalizerTask._results_page_path):
2387         (PerfalizerTask._run_perf_test):
2388         (PerfalizerTask.run_command):
2389         (PerfalizerTask.command_passed):
2390         (PerfalizerTask.command_failed):
2391         (PerfalizerTask.refetch_patch):
2392         (PerfalizerTask.expected_failures):
2393         (PerfalizerTask.build_style):
2394         (PerfTest): IRC command.
2395         (PerfTest.execute):
2396         (Perfalizer): IRC bot.
2397         (Perfalizer.begin_work_queue):
2398         (Perfalizer.work_item_log_path):
2399         (Perfalizer._is_old_failure):
2400         (Perfalizer.next_work_item):
2401         (Perfalizer.process_work_item):
2402         (Perfalizer.handle_unexpected_error):
2403         (Perfalizer.handle_script_error):
2404         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py: Added.
2405         (PerfalizerTaskTest):
2406         (PerfalizerTaskTest._create_and_run_perfalizer):
2407         (PerfalizerTaskTest._create_and_run_perfalizer.logger):
2408         (PerfalizerTaskTest._create_and_run_perfalizer.run_webkit_patch):
2409         (PerfalizerTaskTest._create_and_run_perfalizer.run_perf_test):
2410         (PerfalizerTaskTest.test_run):
2411         (PerfalizerTaskTest.test_run_with_clean_fails):
2412         (PerfalizerTaskTest.test_run_with_update_fails):
2413         (PerfalizerTaskTest.test_run_with_build_fails):
2414         (PerfalizerTaskTest.test_run_with_perf_test_fails):
2415         (PerfalizerTaskTest.test_run_without_results_page):
2416         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2417         (AbstractPatchQueueTest.test_upload_results_archive_for_patch): Rebaselined.
2418         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2419         (test_attach_to_bug): Ditto.
2420         (test_attach_to_bug_no_description_or_comment): Ditto.
2421
2422 2012-08-08  Dirk Pranke  <dpranke@chromium.org>
2423
2424         webkit-patch rebaseline-expectations needs to support multiple expectations files
2425         https://bugs.webkit.org/show_bug.cgi?id=89051
2426
2427         Reviewed by Adam Barth.
2428
2429         fixed the bug described above, added unit test in
2430         test_expectations_unittest, and updated the tool tests
2431         to not contain all of the "missing skia expectations" warnings.
2432
2433         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2434         (TestExpectations.remove_rebaselined_tests):
2435         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
2436         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2437         (RebaseliningTest.assertRemove):
2438         (RebaseliningTest.test_remove):
2439         * Scripts/webkitpy/tool/commands/rebaseline.py:
2440         (RebaselineExpectations._update_expectations_files):
2441         (RebaselineExpectations.execute):
2442         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2443         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
2444         (test_rebaseline_expectations):
2445
2446 2012-08-08  Alexey Proskuryakov  <ap@apple.com>
2447
2448         [WK2] MiniBrowser crashes on quit if any windows were previously closed
2449         https://bugs.webkit.org/show_bug.cgi?id=93529
2450
2451         Reviewed by John Sullivan.
2452
2453         * MiniBrowser/mac/AppDelegate.h:
2454         * MiniBrowser/mac/AppDelegate.m:
2455         (-[BrowserAppDelegate init]):
2456         (-[BrowserAppDelegate newWindow:]):
2457         (-[BrowserAppDelegate browserWindowWillClose:]):
2458         (-[BrowserAppDelegate applicationWillTerminate:]):
2459         (-[BrowserAppDelegate frontmostBrowserWindowController]):
2460         Track browser windows explicitly, not relying on [NSApp windows]. Closed windows
2461         are not automatically removed from the list until deallocated, so a refcounting
2462         error can result in working on a closed window.
2463
2464         * MiniBrowser/mac/BrowserWindowController.m:
2465         (-[BrowserWindowController dealloc]): Moved code from -windowWillClose: here.
2466         Releasing data members is -dealloc's job.
2467         (-[BrowserWindowController windowWillClose:]): Notify BrowserAppDelegate that
2468         the window is no longer open. Autorelease self, making sure that WKView and
2469         then WebPageProxy get released.
2470         (-[BrowserWindowController applicationTerminating]): Don't release _webView.pageRef.
2471         WKView is responsible for its lifetime.
2472         (closePage): Ditto.
2473
2474 2012-08-08  Xianzhu Wang  <wangxianzhu@chromium.org>
2475
2476         [Chromium-Android] Apply all Linux layout test expectations
2477         https://bugs.webkit.org/show_bug.cgi?id=92653
2478
2479         Reviewed by Adam Barth.
2480
2481         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2482         (ChromiumAndroidPort.skipped_layout_tests): Removed. Skip these tests in TestExpectations instead.
2483
2484 2012-08-08  Josh Hawn  <jhawn@apple.com>
2485
2486         Add MountainLion WebKit Bots.
2487         https://bugs.webkit.org/show_bug.cgi?id=93417
2488
2489         Reviewed by Stephanie Lewis.
2490
2491         Mountain Lion is now available, so we've added the appropriate Apple bots,
2492         mirroring the configuration of the Lion bots.
2493
2494         * BuildSlaveSupport/build.webkit.org-config/config.json:
2495         Added 10 "apple-mini-###" slaves.
2496         Added MountainLion Builders and Schedulers.
2497
2498 2012-08-08  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2499
2500         [WK2] Coding style violation was brought with r125031
2501         https://bugs.webkit.org/show_bug.cgi?id=93503
2502
2503         Reviewed by Alexey Proskuryakov.
2504
2505         WKURLResponseCopyMimeType is corrected to WKURLResponseCopyMIMEType.
2506
2507         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2508         (WTR::InjectedBundlePage::didReceiveResponseForResource):
2509         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2510         (WTR::LayoutTestController::dumpProgressFinishedCallback): Removed trailing whitespace that was brought with the same revision.
2511
2512 2012-08-08  Peter Beverloo  <peter@chromium.org>
2513
2514         Buildmaster changes in preparation of a Chromium Android tester
2515         https://bugs.webkit.org/show_bug.cgi?id=92251
2516
2517         Reviewed by Adam Barth.
2518
2519         Slightly update the build master's configuration in preparation of adding
2520         a Chromium Android tester.
2521
2522         The change in built-product-archive is required as the out/ directory
2523         for Android has a number of unstripped .so binaries and unaligned APKs,
2524         causing the default release.zip file to be 2.7 gigabytes. By excluding
2525         these file types, the file is only 59.7 megabytes. We can't disable
2526         them for all of Chromium, as Mac and Linux do use their .so files.
2527
2528         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2529         (ArchiveBuiltProduct): Pass the full platform name instead of just the
2530             generic type, i.e. chromium-android instead of chromium.
2531         (ExtractBuiltProduct): Dito, stay consistent for this script.
2532         (RunUnitTests): Pass --chromium-android as well as --chromium. Since we
2533             now read the full platform name, stay on the safe side with 'win'
2534             even though there (as far as I know) is no win-* platform.
2535         (RunChromiumWebKitUnitTests): Dito. The platform wasn't being passed
2536             at all, but we'll be needing different handling here.
2537         (unitTestsSupported): Next to refactoring work required, as we'll be
2538             running this test on a device, there is no reason to disable this
2539             in the master's configuration.
2540         * BuildSlaveSupport/built-product-archive:
2541         (main): Determine the generic platform.
2542         (archiveBuiltProduct): Use an identical set of ignorePatterns, but
2543             extend the list with .so, .pak and -unaligned.apk for Android.
2544
2545 2012-08-08  Adam Barth  <abarth@webkit.org>
2546
2547         Unreviewed. Stop running tests on the mac-ews while we wait for more
2548         hardware. As requested by lforschler.
2549
2550         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2551
2552 2012-08-08  Peter Beverloo  <peter@chromium.org>
2553
2554         The cr-android EWS should actually be building Chromium for Android
2555         https://bugs.webkit.org/show_bug.cgi?id=93489
2556
2557         Reviewed by Adam Barth.
2558
2559         The cr-android EWS bots should be building Chromium for Android, which
2560         requires some additional flags to Chromium's default configuration.
2561
2562         * Scripts/webkitdirs.pm:
2563         (buildChromium):
2564         * Scripts/webkitpy/common/config/ports.py:
2565         (DeprecatedPort.port):
2566         (ChromiumAndroidPort):
2567         (ChromiumAndroidPort.update_webkit_command):
2568         (ChromiumAndroidPort.build_webkit_command):
2569         * Scripts/webkitpy/common/config/ports_unittest.py:
2570         (DeprecatedPortTest.test_chromium_android_port):
2571         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2572         (ChromiumAndroidEWS):
2573         * Scripts/webkitpy/tool/steps/update_unittest.py:
2574         (UpdateTest.test_update_command_non_interactive):
2575         (UpdateTest.test_update_command_interactive):
2576
2577 2012-08-08  Alexey Proskuryakov  <ap@apple.com>
2578
2579         [WK2] MiniBrowser crashes on window.open()
2580         https://bugs.webkit.org/show_bug.cgi?id=93413
2581
2582         Reviewed by Dan Bernstein.
2583
2584         * MiniBrowser/mac/BrowserWindowController.m: (createNewPage): This is a "create"
2585         API, so it needs to return a retained result.
2586
2587         * MiniBrowser/mac/WebBundle/WebBundleMain.m: (didClearWindowObjectForFrame):
2588         When this function is called, URL appears to be poorly defined. Sometimes, it's
2589         the new URL, other times it's the old one. An "old" URL is null in a new page.
2590
2591 2012-08-08  Loïc Yhuel  <loic.yhuel@softathome.com>
2592
2593         [Qt] Compile errors with OpenGLES2
2594         https://bugs.webkit.org/show_bug.cgi?id=93206
2595
2596         Reviewed by Noam Rosenthal.
2597
2598         Fix build with OpenGLES2 on Linux desktop
2599
2600         * qmake/mkspecs/features/features.prf: Don't use GLX with OpenGLES2
2601
2602 2012-08-08  Peter Beverloo  <peter@chromium.org>
2603
2604         Introduce cr-android bots in the EWS system
2605         https://bugs.webkit.org/show_bug.cgi?id=93472
2606
2607         Reviewed by Adam Barth.
2608
2609         This adds the queue to the EWS scripts. Two builders are ready to be
2610         attached to the queue. All webkitpy tests pass with this change applied.
2611
2612         * QueueStatusServer/model/queues.py:
2613         (Queue):
2614         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2615         (ChromiumAndroidEWS):
2616         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2617         (EarlyWarningSytemTest.test_builder_ewses):
2618
2619 2012-08-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2620
2621         Unreviewed. Fix GTK+ build with GTK2 after r121475.
2622
2623         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp: Add missing
2624         include required when building with GTK2.
2625
2626 2012-08-08  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2627
2628         [WK2] [WTR] Provide Resource Response dumping.
2629         https://bugs.webkit.org/show_bug.cgi?id=93454
2630
2631         Reviewed by Kenneth Rohde Christiansen.
2632
2633         Added missing dumpResourceResponseMIMETypes() method to testRunner. Provided resource response dumping.
2634
2635         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2636         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2637         (WTR::InjectedBundlePage::didReceiveResponseForResource):
2638         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2639         (WTR::LayoutTestController::LayoutTestController):
2640         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2641         (WTR::LayoutTestController::dumpProgressFinishedCallback):
2642         (WTR::LayoutTestController::dumpResourceResponseMIMETypes):
2643         (WTR::LayoutTestController::shouldDumpResourceResponseMIMETypes):
2644         (LayoutTestController):
2645
2646 2012-08-08  Simon Hausmann  <simon.hausmann@nokia.com>
2647
2648         [Qt][Win] Fix compilation of DumpRenderTree
2649         https://bugs.webkit.org/show_bug.cgi?id=93461
2650
2651         Reviewed by Tor Arne Vestbø.
2652
2653         DRT includes stdint.h, for which we have wrappers in Source/JavaScriptCore/os-win32. Use these not only
2654         for libraries but any building template.
2655
2656         * qmake/mkspecs/features/default_post.prf:
2657
2658 2012-08-08  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2659
2660         [WK2] [WTR] Refactoring: LayoutTestController::shouldDumpProgressFinishedCallback() should be const
2661         https://bugs.webkit.org/show_bug.cgi?id=93457
2662
2663         Reviewed by Csaba Osztrogonác.
2664
2665         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2666         (WTR::LayoutTestController::shouldDumpProgressFinishedCallback): Added constness.
2667
2668 2012-08-07  Csaba Osztrogonác  <ossy@webkit.org>
2669
2670         Unreviewed typo fix after r124988.
2671
2672         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2673         (TestExpectations):
2674
2675 2012-08-07  YoungTaeck Song  <youngtaeck.song@samsung.com>
2676
2677         [WK2][EFL] Implement accelerated compositing on WK2 Efl port
2678         https://bugs.webkit.org/show_bug.cgi?id=89840
2679
2680         Reviewed by Noam Rosenthal.
2681
2682         Implement accelerated composition with TiledBackingStore on WK2 Efl port.
2683         Add OPENGL_LIBRARIES in CMakeList.txt.
2684
2685         * MiniBrowser/efl/CMakeLists.txt:
2686         * WebKitTestRunner/PlatformEfl.cmake:
2687
2688 2012-08-07  Csaba Osztrogonác  <ossy@webkit.org>
2689
2690         [NRWT] REGRESSION(r124967): New tests without expected results handled as failures
2691         https://bugs.webkit.org/show_bug.cgi?id=93434
2692
2693         Reviewed by Tony Chang.
2694
2695         Change back "missing results" to "no expected result found", because master.cfg's results parser expects it.
2696
2697         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2698         (TestExpectations):
2699
2700 2012-08-07  Csaba Osztrogonác  <ossy@webkit.org>
2701
2702         buildbot: Remove the configuration of hfreyther*
2703         https://bugs.webkit.org/show_bug.cgi?id=91849
2704
2705         Unreviewed typo fix after r123757.
2706
2707         * BuildSlaveSupport/build.webkit.org-config/config.json:
2708
2709 2012-08-07  Dirk Pranke  <dpranke@chromium.org>
2710
2711         REGRESSION: PrettyPatchTest.test_pretty_diff_encodings has been failing on Chromium Windows
2712         https://bugs.webkit.org/show_bug.cgi?id=93192
2713
2714         Unreviewed, build fix.
2715
2716         Disabling the test for now as PrettyPatch is just broken on win32.
2717
2718         * Scripts/webkitpy/common/prettypatch_unittest.py:
2719         (test_pretty_diff_encodings):
2720
2721 2012-08-07  Dirk Pranke  <dpranke@chromium.org>
2722
2723         [NRWT] Would like an output mode similar to ORWT verbose one
2724         https://bugs.webkit.org/show_bug.cgi?id=88702
2725
2726         Reviewed by Ryosuke Niwa.
2727
2728         Change the --verbose logging for new-run-webkit-tests so that
2729         it matches ORWT more; we just print one line per test. Use
2730         --debug-rwt-logging to get the full debug stream (aka old ORWT
2731         --verbose).
2732
2733         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2734         (TestExpectations):
2735         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2736         (_set_up_derived_options):
2737         (parse_args):
2738         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2739         (MainTest.test_retrying_and_flaky_tests):
2740         * Scripts/webkitpy/layout_tests/views/printing.py:
2741         (print_options):
2742         (Printer._print_result_summary_entry):
2743         (Printer._print_one_line_summary):
2744         (Printer._print_test_result):
2745         (Printer._print_baseline):
2746         (Printer._print_unexpected_results):
2747
2748 2012-08-07  Dirk Pranke  <dpranke@chromium.org>
2749
2750         nrwt: handle errors from image diff better
2751         https://bugs.webkit.org/show_bug.cgi?id=92934
2752
2753         Reviewed by Ojan Vafai.
2754
2755         Re-land the change in r124801 with a fix ... in the case where
2756         the ImageDiff is passed a tolerance and passes the fuzzy check,
2757         we were returning the wrong value (missing an empty error
2758         string) and crashing; this patch fixes that and adds a test for
2759         that case (TestImageDiffer.test_image_diff_passed).
2760
2761         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2762         (SingleTestRunner._compare_image):
2763         (SingleTestRunner._compare_output_with_reference):
2764         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2765         (write_test_result):
2766         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
2767         (TestResultWriterTest.test_reftest_diff_image.ImageDiffTestPort.diff_image):
2768         (TestResultWriterTest):
2769         * Scripts/webkitpy/layout_tests/port/base.py:
2770         (Port.diff_image):
2771         * Scripts/webkitpy/layout_tests/port/chromium.py:
2772         (ChromiumPort.diff_image):
2773         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
2774         (ChromiumPortTestCase.test_diff_image_crashed):
2775         * Scripts/webkitpy/layout_tests/port/image_diff.py:
2776         (ImageDiffer.diff_image):
2777         (ImageDiffer._read):
2778         * Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:
2779         (TestImageDiffer.test_diff_image):
2780         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2781         (MockDRTPortTest.test_diff_image_crashed):
2782         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2783         (PortTestCase.test_diff_image):
2784         (PortTestCase.test_diff_image_crashed):
2785         (PortTestCase.test_diff_image_crashed.make_proc):
2786         * Scripts/webkitpy/layout_tests/port/server_process_mock.py:
2787         (MockServerProcess.__init__):
2788         * Scripts/webkitpy/layout_tests/port/test.py:
2789         (TestPort.diff_image):
2790         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2791         (MainTest.test_tolerance.ImageDiffTestPort.diff_image):
2792
2793 2012-08-07  Dirk Pranke  <dpranke@chromium.org>
2794
2795         nrwt: --no-build isn't working
2796         https://bugs.webkit.org/show_bug.cgi?id=93415
2797
2798         Reviewed by Ryosuke Niwa.
2799
2800         Turns out our optimization to avoid calling
2801         webkit-build-directory N times for each worker broke --no-build.
2802
2803         Fixing, and adding a test.
2804
2805         Also, the gtk port wasn't using the default check_build() logic,
2806         but I don't know why not. Removing their custom hook and will
2807         verify that this is okay in the review ...
2808
2809         * Scripts/webkitpy/layout_tests/port/base.py:
2810         (Port.__init__):
2811         (Port.check_build):
2812         (Port._build_path):
2813         * Scripts/webkitpy/layout_tests/port/gtk.py:
2814         (GtkPort._path_to_image_diff):
2815         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2816         (MockDRTPortTest.test_check_build):
2817         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2818         (test_path_to_apache_config_file):
2819         (test_check_build):
2820         (test_check_build.build_driver_called):
2821
2822 2012-08-07  Ryosuke Niwa  <rniwa@webkit.org>
2823
2824         run-perf-tests should support --no-show-results
2825         https://bugs.webkit.org/show_bug.cgi?id=93409
2826
2827         Reviewed by Dirk Pranke.
2828
2829         Add the support for --no-show-results.
2830
2831         Also replace only local paths to jquery and flot instead of embedding them.
2832         The results page is still standalone in that it tries to load scripts
2833         from both webkit.org and local filesystem.
2834
2835         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2836         (PerfTestsRunner._parse_args):
2837         (PerfTestsRunner.run):
2838         (PerfTestsRunner._generate_and_show_results):
2839         (PerfTestsRunner._generate_output_files):
2840         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2841         (create_runner_and_setup_results_template):
2842         (test_run_generates_and_show_results_page):
2843         (test_run_respects_no_show_results):
2844
2845 2012-08-07  Dirk Pranke  <dpranke@chromium.org>
2846
2847         test-webkitpy hangs in a new checkout on snow leopard
2848         https://bugs.webkit.org/show_bug.cgi?id=93301
2849
2850         Reviewed by Ryosuke Niwa.
2851
2852         This change works around what appears to be a bug in Python
2853         2.6.1 (the version that ships on Mac Snow Leopard) that causes
2854         the multiprocessing module to hang after we use the
2855         autoinstaller; I'm guessing it's some sort of python sockets
2856         issue. I was unable to reproduce this with 2.6.5 or newer
2857         versions of Python.
2858
2859         * Scripts/webkitpy/common/system/autoinstall.py:
2860         (AutoInstaller.install):
2861         * Scripts/webkitpy/test/main.py:
2862         (Tester._run_tests):
2863         * Scripts/webkitpy/thirdparty/__init__.py:
2864         (AutoinstallImportHook._install_mechanize):
2865         (AutoinstallImportHook._install_pep8):
2866         (AutoinstallImportHook._install_pylint):
2867         (AutoinstallImportHook._install_buildbot):
2868         (AutoinstallImportHook._install_coverage):
2869         (AutoinstallImportHook._install_eliza):
2870         (AutoinstallImportHook._install_irc):
2871         (AutoinstallImportHook._install_webpagereplay):
2872         (AutoinstallImportHook._install):
2873         (autoinstall_everything):
2874
2875 2012-08-07  Xianzhu Wang  <wangxianzhu@chromium.org>
2876
2877         [Chromium-Android][NRWT] Fix 2 FIXMEs in chromium_android.py
2878         https://bugs.webkit.org/show_bug.cgi?id=93381
2879
2880         Reviewed by Adam Barth.
2881
2882         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2883         (ChromiumAndroidDriver.__init__):
2884         (ChromiumAndroidDriver._push_executable): Remove temporary lines as the chromium change has been landed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150371
2885         (ChromiumAndroidDriver._setup_performance): Update all scaling governor files.
2886         (ChromiumAndroidDriver._teardown_performance): Update all scaling governor files.
2887
2888 2012-08-07  W. James MacLean  <wjmaclean@chromium.org>
2889
2890         [chromium] Add support to DumpRenderTree [EventSender] for GestureTapDown events.
2891         https://bugs.webkit.org/show_bug.cgi?id=93286
2892
2893         Reviewed by James Robinson.
2894
2895         Adds support to generate GestureTapDown events from EventSender, to facilitate
2896         link highlighting layout tests.
2897  
2898         Added a GestureTapEvent to one existing test, more tests to follow when LinkHighlight CLs start to land.
2899
2900         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
2901         (EventSender::EventSender):
2902         (EventSender::gestureTapDown):
2903         (EventSender::gestureEvent):
2904         * DumpRenderTree/chromium/TestRunner/EventSender.h:
2905         (EventSender):
2906
2907 2012-08-07  Marcelo Lira  <marcelo.lira@openbossa.org>
2908
2909         [Qt] Add support for the Gamepad API
2910         https://bugs.webkit.org/show_bug.cgi?id=90637
2911
2912         Reviewed by Alexis Menard.
2913
2914         If the libudev library is present, the GAMEPAD flag is
2915         turned on by default for the Qt port.
2916
2917         * Scripts/webkitperl/FeatureList.pm:
2918         * qmake/mkspecs/features/features.prf:
2919
2920 2012-08-07  Rob Buis  <rbuis@rim.com>
2921
2922         [BlackBerry] Turn on CSS Variables
2923         https://bugs.webkit.org/show_bug.cgi?id=93376
2924
2925         Reviewed by Antonio Gomes.
2926
2927         Turn on CSS Variables for BlackBerry port.
2928
2929         * Scripts/webkitperl/FeatureList.pm:
2930
2931 2012-08-07  No'am Rosenthal  <noam.rosenthal@nokia.com>
2932
2933         [Qt] Make it possible to build without QtQuick
2934
2935         Reviewed by Simon Hausmann.
2936
2937         * Tools.pro:
2938         * qmake/mkspecs/features/features.prf:
2939
2940 2012-08-02  Simon Hausmann  <simon.hausmann@nokia.com>
2941
2942         [Qt] Remove Qt 4 specific code paths
2943         https://bugs.webkit.org/show_bug.cgi?id=88161
2944
2945         Reviewed by Kenneth Rohde Christiansen.
2946
2947         * DumpRenderTree/qt/DumpRenderTree.pro:
2948         * DumpRenderTree/qt/EventSenderQt.cpp:
2949         (EventSender::touchCancel):
2950         (EventSender::sendTouchEvent):
2951         * DumpRenderTree/qt/EventSenderQt.h:
2952         (EventSender):
2953         * DumpRenderTree/qt/ImageDiff.pro:
2954         * DumpRenderTree/qt/main.cpp:
2955         (main):
2956         * QtTestBrowser/QtTestBrowser.pro:
2957         * QtTestBrowser/cookiejar.cpp:
2958         (TestBrowserCookieJar::TestBrowserCookieJar):
2959         * QtTestBrowser/launcherwindow.cpp:
2960         (LauncherWindow::setDiskCache):
2961         * qmake/configure.pri:
2962         * qmake/mkspecs/features/default_post.prf:
2963         * qmake/mkspecs/features/default_pre.prf:
2964         * qmake/mkspecs/features/features.prf:
2965         * qmake/mkspecs/features/functions.prf:
2966         * qmake/mkspecs/features/qtwebkit.prf: Removed.
2967         * qmake/mkspecs/features/unix/default_pre.prf:
2968
2969 2012-08-07  Andras Becsi  <andras.becsi@nokia.com>
2970
2971         [Qt][WK2] MiniBrowser should only synthesize multiple touch points if Ctrl is pressed
2972         https://bugs.webkit.org/show_bug.cgi?id=93277
2973
2974         Reviewed by Jocelyn Turcotte.
2975
2976         MiniBrowser's multi-touch mocking does not check if Ctrl is pressed
2977         when registering multiple touch points based on pressed mouse buttons
2978         and sends inconsistent touch events to the WebView which triggers an
2979         assert in the pinch gesture recognizer.
2980         MiniBrowserApplication::updateTouchPoint should only register multiple
2981         touch points if the Ctrl button is pressed else it should ignore the
2982         update request.
2983
2984         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2985         (MiniBrowserApplication::updateTouchPoint):
2986
2987 2012-08-07  Csaba Osztrogonác  <ossy@webkit.org>
2988
2989         REGRESSION(r124800): It broke NRWT result parsing of build.webkit.org
2990         https://bugs.webkit.org/show_bug.cgi?id=93346
2991
2992         Rubber-stamped by Simon Hausmann.
2993
2994         Change back "unexpected" to "Unexpected", because master.cfg's results parser expects it.
2995
2996         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2997         (MainTest.test_retrying_and_flaky_tests):
2998         * Scripts/webkitpy/layout_tests/views/printing.py:
2999         (Printer._print_unexpected_results):
3000
3001 2012-08-06  Balazs Kelemen  <kbalazs@webkit.org>
3002
3003         [NRWT] runs platform specific tests that it shouldn't with --force
3004         https://bugs.webkit.org/show_bug.cgi?id=91089
3005
3006         Reviewed by Dirk Pranke.
3007
3008         Ignore other platform's directories from platform/.
3009
3010         * Scripts/webkitpy/layout_tests/port/base.py:
3011         (Port._expanded_paths):
3012         * Scripts/webkitpy/layout_tests/port/test.py:
3013         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3014         (MainTest.test_platform_tests_are_found):
3015         Updated integration test in accordance to the new behavior.
3016
3017 2012-08-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3018
3019         [EFL] Enable link prefetch
3020         https://bugs.webkit.org/show_bug.cgi?id=93281
3021
3022         Reviewed by Kentaro Hara.
3023
3024         * Scripts/webkitperl/FeatureList.pm: Enable LINK_PREFETCH feature.
3025
3026 2012-08-06  Sheriff Bot  <webkit.review.bot@gmail.com>
3027
3028         Unreviewed, rolling out r124801.
3029         http://trac.webkit.org/changeset/124801
3030         https://bugs.webkit.org/show_bug.cgi?id=93338
3031
3032         It broke NRWT (Requested by Ossy on #webkit).
3033
3034         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3035         (SingleTestRunner._compare_image):
3036         (SingleTestRunner._compare_output_with_reference):
3037         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3038         (write_test_result):
3039         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
3040         (TestResultWriterTest.test_reftest_diff_image.ImageDiffTestPort.diff_image):
3041         (TestResultWriterTest):
3042         * Scripts/webkitpy/layout_tests/port/base.py:
3043         (Port.diff_image):
3044         * Scripts/webkitpy/layout_tests/port/chromium.py:
3045         (ChromiumPort.diff_image):
3046         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
3047         (ChromiumPortTestCase.test_diff_image):
3048         * Scripts/webkitpy/layout_tests/port/image_diff.py:
3049         (ImageDiffer.diff_image):
3050         (ImageDiffer._read):
3051         * Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:
3052         (TestImageDiffer.test_diff_image):
3053         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3054         (MockDRTPortTest.test_diff_image):
3055         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3056         (PortTestCase.test_diff_image):
3057         * Scripts/webkitpy/layout_tests/port/server_process_mock.py:
3058         (MockServerProcess.__init__):
3059         * Scripts/webkitpy/layout_tests/port/test.py:
3060         (TestPort.diff_image):
3061         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3062         (MainTest.test_tolerance.ImageDiffTestPort.diff_image):
3063
3064 2012-08-06  Wei James  <james.wei@intel.com>
3065
3066         [Chromium]duplicated command line options in Android LayoutTest
3067         https://bugs.webkit.org/show_bug.cgi?id=93233
3068
3069         Reviewed by Tony Chang.
3070
3071         Duplicated options found in Android layout test command line:
3072         --encode-binary and --enable-hardware-gpu.
3073
3074         If there are multiple ChromiumAndroidPort instances,
3075         these two options will be appended for multiple times.
3076
3077         * Scripts/webkitpy/layout_tests/port/base.py:
3078         (Port.additional_drt_flag):
3079         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3080         (ChromiumAndroidPort.__init__):
3081         (ChromiumAndroidPort.additional_drt_flag):
3082         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3083         (ChromiumAndroidTwoPortsTest):
3084         (ChromiumAndroidTwoPortsTest.test_options_with_two_ports):
3085         * Scripts/webkitpy/layout_tests/port/driver.py:
3086         (Driver.cmd_line):
3087
3088 2012-08-03  Brady Eidson  <beidson@apple.com>
3089
3090         Out-of-process plug-ins should support asynchronous initialization
3091         <rdar://problem/10598594> and https://bugs.webkit.org/show_bug.cgi?id=92919
3092
3093         Reviewed by Anders Carlsson.
3094
3095         Add a plug-in with an NPP_New that takes 550ms (a reasonable trade-off between a solid test and a slow running test)
3096         for testing asynchronous plug-in initialization.
3097
3098         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3099         * DumpRenderTree/TestNetscapePlugIn/Tests/SlowNPPNew.cpp: Copied from Source/WebKit2/Shared/Plugins/PluginProcessCreationParameters.h.
3100         (SlowNPPNew):
3101         (SlowNPPNew::SlowNPPNew):
3102         (SlowNPPNew::NPP_New):
3103
3104 2012-08-06  Xianzhu Wang  <wangxianzhu@chromium.org>
3105
3106         [Chromium-Android] Virtual test suites fail
3107         https://bugs.webkit.org/show_bug.cgi?id=92515
3108
3109         Reviewed by Dirk Pranke.
3110
3111         The failure is because our bypassing of DriverProxy.
3112         Repeat the logic of virtual tests in DriverProxy in ChromiumAndroidDriver
3113         and restart DRT when the command line changes.
3114
3115         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3116         (ChromiumAndroidDriver.__init__):
3117         (ChromiumAndroidDriver.cmd_line): Added comments about why we override this and have _drt_cmd_line().
3118         (ChromiumAndroidDriver.run_test): Repeat the logic of virtual tests in DriverProxy.
3119         (ChromiumAndroidDriver.start): Restart DRT when the command line changes.
3120         (ChromiumAndroidDriver._start_once):
3121
3122 2012-08-06  Xianzhu Wang  <wangxianzhu@chromium.org>
3123
3124         Remove NRWT --shard-ref-tests
3125         https://bugs.webkit.org/show_bug.cgi?id=91539
3126
3127         This is basically a revert of "[Chromium-Android] Run ref tests together to avoid expensive driver restarts"
3128         (https://bugs.webkit.org/show_bug.cgi?id=91533, http://trac.webkit.org/changeset/122914),
3129         with some conflicts resolved (because of refactory of Manager/LayoutTestRunner/Sharder classes).
3130
3131         Reviewed by Dirk Pranke.
3132
3133         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3134         (LayoutTestRunner.run_tests):
3135         (Sharder.shard_tests):
3136         (Sharder._shard_in_two):
3137         (Sharder._shard_by_directory):
3138         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
3139         (SharderTests):
3140         (SharderTests.get_test_input):
3141         (SharderTests.get_shards):
3142         (SharderTests.test_shard_by_dir):
3143         (SharderTests.test_shard_in_two):
3144         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3145         (Manager._test_input_for_file):
3146         (Manager._test_is_slow):
3147         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3148         (ChromiumAndroidPort.__init__):
3149         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3150         (parse_args):
3151
3152 2012-08-06  Luciano Wolf  <luciano.wolf@openbossa.org>
3153
3154         [Qt] Default sizes for input-text and text-area are different when running DRT/WTR
3155         https://bugs.webkit.org/show_bug.cgi?id=91990
3156
3157         Reviewed by Kenneth Rohde Christiansen.
3158
3159         Initializing TestFonts information into WTR binary. Doing it 
3160         later leads to wrong font names usage (Dejavu Serif instead
3161         of Liberation Serif).
3162
3163         * WebKitTestRunner/Target.pri:
3164         * WebKitTestRunner/qt/main.cpp:
3165         (main):
3166
3167 2012-08-06  Jeff Timanus  <twiz@chromium.org>
3168
3169         Add twiz@{chromium|google}.org to the set of non-committer contributors.
3170         https://bugs.webkit.org/show_bug.cgi?id=93288
3171
3172         Reviewed by Adam Barth.
3173
3174         * Scripts/webkitpy/common/config/committers.py:
3175
3176 2012-08-06  Adam Barth  <abarth@webkit.org>
3177
3178         REGRESSION(124789): EWS errors out because --print option is missing
3179         https://bugs.webkit.org/show_bug.cgi?id=93299
3180
3181         Unreviewed.
3182
3183         The --print option doesn't exist anymore.  Let's try --quiet instead.
3184
3185         * Scripts/webkitpy/tool/steps/runtests.py:
3186         (RunTests.run):
3187         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3188
3189 2012-08-06  Ryosuke Niwa  <rniwa@webkit.org>
3190
3191         run-webkit-tests should have ability to add description to its JSON output
3192         https://bugs.webkit.org/show_bug.cgi?id=93296
3193
3194         Reviewed by Dirk Pranke.
3195
3196         Add --description option.
3197
3198         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3199         (PerfTestsRunner._parse_args):
3200         (PerfTestsRunner._generate_and_show_results):
3201         (PerfTestsRunner._generate_results_dict):
3202         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3203         (test_run_with_description):
3204
3205 2012-08-06  Dirk Pranke  <dpranke@chromium.org>
3206
3207         nrwt: handle errors from image diff better
3208         https://bugs.webkit.org/show_bug.cgi?id=92934
3209
3210         Reviewed by Ojan Vafai.
3211
3212         Currently if ImageDiff crashes, returns a weird exit code, or
3213         produces any stderr output, it's basically swallowed. This
3214         change ensures that we log errors to stderr, and also appends
3215         the error to the stderr for the test (so it'll show up in
3216         results.html).
3217
3218         Most importantly, it'll cause diff_image() to fail and we'll
3219         report ImageHashMismatch ... this may be kinda untrue, but I
3220         think it's better than ignoring the error.
3221
3222         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3223         (SingleTestRunner._compare_image):
3224         (SingleTestRunner._compare_output_with_reference):
3225         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3226         (write_test_result):
3227         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
3228         (TestResultWriterTest.test_reftest_diff_image.ImageDiffTestPort.diff_image):
3229         (TestResultWriterTest):
3230         * Scripts/webkitpy/layout_tests/port/base.py:
3231         (Port.diff_image):
3232         * Scripts/webkitpy/layout_tests/port/chromium.py:
3233         (ChromiumPort.diff_image):
3234         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
3235         (ChromiumPortTestCase.test_diff_image_crashed):
3236         * Scripts/webkitpy/layout_tests/port/driver.py:
3237         (Driver.run_test):
3238         * Scripts/webkitpy/layout_tests/port/image_diff.py:
3239         (ImageDiffer.diff_image):
3240         (ImageDiffer._read):
3241         * Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:
3242         (TestImageDiffer.test_diff_image):
3243         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3244         (MockDRTPortTest.test_diff_image_crashed):
3245         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3246         (PortTestCase.test_diff_image):
3247         (PortTestCase):
3248         (PortTestCase.test_diff_image_crashed):
3249         (PortTestCase.test_diff_image_crashed.make_proc):
3250         * Scripts/webkitpy/layout_tests/port/server_process_mock.py:
3251         (MockServerProcess.__init__):
3252         * Scripts/webkitpy/layout_tests/port/test.py:
3253         (TestPort.diff_image):
3254         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3255         (MainTest.test_tolerance.ImageDiffTestPort.diff_image):
3256
3257 2012-08-06  Dirk Pranke  <dpranke@chromium.org>
3258
3259         nrwt: clean up printing.py
3260         https://bugs.webkit.org/show_bug.cgi?id=93026
3261
3262         Reviewed by Dirk Pranke.
3263
3264         This patch cleans up the implementation of printing.py now
3265         that we're not using all the original complexity.
3266
3267         There should be no changes in functionality and everything
3268         should be covered by the existing tests.
3269
3270         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3271         (LayoutTestRunner.run_tests):
3272         * Scripts/webkitpy/layout_tests/views/printing.py:
3273         (Printer.__init__):
3274         (Printer.__del__):
3275         (Printer.print_config):
3276         (Printer.print_found):
3277         (Printer.print_expected):
3278         (Printer.print_workers_and_shards):
3279         (Printer):
3280         (Printer._print_expected_results_of_type):
3281         (Printer.print_results):
3282         (Printer._print_timing_statistics):
3283         (Printer._print_aggregate_test_statistics):
3284         (Printer._print_individual_test_times):
3285         (Printer._print_test_list_timing):
3286         (Printer._print_directory_timings):
3287         (Printer._print_statistics_for_test_timings):
3288         (Printer._print_result_summary):
3289         (Printer._print_result_summary_entry):
3290         (Printer._print_one_line_summary):
3291         (Printer.print_finished_test):
3292         (Printer._print_test_result):
3293         (Printer._print_test_trace):
3294         (Printer._print_baseline):
3295         (Printer._print_unexpected_test_result):
3296         (Printer._print_progress):
3297         (Printer._print_unexpected_results):
3298         (Printer._print_unexpected_results.add_result):
3299         (Printer._print_quiet):
3300         (Printer._print_default):
3301         (Printer._print_debug):
3302         (Printer._print_for_bot):
3303         (Printer.write_update):
3304         (Printer.writeln):
3305         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3306         (Testprinter.get_printer):
3307         (Testprinter.test_print_config):
3308         (Testprinter.test_print_one_line_summary):
3309         (Testprinter.test_print_unexpected_results):
3310         (test_details):
3311
3312 2012-08-06  Dirk Pranke  <dpranke@chromium.org>
3313
3314         change bots to pass --debug-rwt-logging instead of --verbose to new-run-webkit-tests
3315         https://bugs.webkit.org/show_bug.cgi?id=93043
3316
3317         Reviewed by Ryosuke Niwa.
3318
3319         in preparation for the cleanup of the logging flags in new-run-webkit-tests.
3320
3321         * Scripts/run-webkit-tests:
3322
3323 2012-08-06  Dirk Pranke  <dpranke@chromium.org>
3324
3325         nrwt: clean up logging, part 1
3326         https://bugs.webkit.org/show_bug.cgi?id=93018
3327
3328         Reviewed by Ojan Vafai.
3329
3330         remove --print, --help-printing from nrwt, add three new options:
3331         --quiet, which just logs warnings,errors, and unexpected results
3332         --debug-rwt-logging, a new name for --verbose
3333         --details, to get the old --print trace-everything behavior
3334
3335         This patch does not implement the new "one line per test"
3336         --verbose behavior specified in bug 88702, and there's a bunch
3337         of internal cleanup I can do in printing.py that I'll defer to
3338         a later patch to make things easier to review.
3339
3340         This patch deletes a lot of unit tests that are no longer
3341         necessary since there aren't so many logging combinations.
3342
3343         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3344         (run):
3345         (main):
3346         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3347         (parse_args):
3348         (passing_run):
3349         (StreamTestingMixin.assertContains):
3350         (MainTest.test_child_processes_2):
3351         (MainTest.test_child_processes_min):
3352         (MainTest.test_full_results_html):
3353         (MainTest.test_no_tests_found):
3354         (MainTest.test_no_tests_found_2):
3355         (MainTest.test_repeat_each_iterations_num_tests):
3356         (MainTest.test_additional_platform_directory):
3357         (RebaselineTest.assertBaselines):
3358         * Scripts/webkitpy/layout_tests/views/printing.py:
3359         (print_options):
3360         (Printer.__init__):
3361         (Printer.enabled):
3362         (Printer.print_unexpected_results):
3363         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3364         (TestUtilityFunctions.test_print_options):
3365         (Testprinter.get_result_summary):
3366         (Testprinter.test_configure_and_cleanup):
3367         (Testprinter.test_print_config):
3368         (Testprinter.test_print_one_line_summary):
3369         (Testprinter.test_print_unexpected_results):
3370         (test_details):
3371         (test_default):
3372         (test_quiet):
3373         (test_verbose):
3374
3375 2012-08-06  Xianzhu Wang  <wangxianzhu@chromium.org>
3376
3377         [Chromium-Android] Store test executable, data and fonts in /data/local/tmp
3378         https://bugs.webkit.org/show_bug.cgi?id=91910
3379
3380         /data/local/tmp is a directory with permission 0777 by default.
3381         Place DumpRenderTree resources here so that both the native test app and
3382         the NRWT script can access them even if adb shell isn't running as root.
3383
3384         Reviewed by Adam Barth.
3385
3386         * DumpRenderTree/chromium/TestShellAndroid.cpp:
3387         (createFIFO): Set fifo mode to 0666 to allow unrooted adb shell to access.
3388         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3389         (ChromiumAndroidPort.driver_cmd_line):
3390         (ChromiumAndroidDriver.__init__):
3391         (ChromiumAndroidDriver._setup_test):
3392         (ChromiumAndroidDriver._push_executable):
3393         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3394         (ChromiumAndroidPortTest.make_port):
3395         (ChromiumAndroidPortTest.test_expectations_files):
3396         (ChromiumAndroidDriverTest.test_drt_cmd_line):
3397
3398 2012-08-06  Abhishek Arya  <inferno@chromium.org>
3399
3400         [Chromium] Re-expose layoutTestController as various fuzzers depend on it
3401         https://bugs.webkit.org/show_bug.cgi?id=93282
3402
3403         Reviewed by Ryosuke Niwa.
3404
3405         Unfortunately, various fuzzers used in the Chromium project still depends on
3406         window.layoutTestController. Re-expose the object while they're making the transition.
3407
3408         * DumpRenderTree/chromium/TestShell.cpp:
3409         (TestShell::bindJSObjectsToWindow):
3410
3411 2012-08-06  Balazs Kelemen  <kbalazs@webkit.org>
3412
3413         WTR should be able to load external resources
3414         https://bugs.webkit.org/show_bug.cgi?id=89382
3415
3416         Reviewed by Ryosuke Niwa.
3417
3418         Allow to load an external resource as the main frame
3419         and allow all subsequent external loads for such a main
3420         frame. This behavior is necessary for being able to run
3421         performance tests (https://bugs.webkit.org/show_bug.cgi?id=84008).
3422
3423         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3424         (WTR::isLocalHost):
3425         (WTR):
3426         (WTR::isHTTPOrHTTPSScheme):
3427         (WTR::InjectedBundlePage::willSendRequestForFrame):
3428
3429 2012-08-06  Balazs Kelemen  <kbalazs@webkit.org>
3430
3431         [WK2] REGRESSION(124596) lot of web process unresponsiveness appears on Apple bots
3432         https://bugs.webkit.org/show_bug.cgi?id=93120
3433
3434         Reviewed by Csaba Osztrogonác.
3435
3436         Set the short timeout back to 15 seconds and add more time to WebKitTestRunner
3437         so it will be able to detect an unresponsive web process.
3438
3439         * Scripts/webkitpy/layout_tests/port/base.py:
3440         (Port.default_timeout_ms):
3441         * WebKitTestRunner/TestController.cpp:
3442         (WTR):
3443
3444 2012-08-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3445
3446         Unreviewed. Fix make distcheck.
3447
3448         * GNUmakefile.am: Add jhbuildutils.py to EXTRA_DIST.
3449
3450 2012-08-06  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3451
3452         [EFL] EFL's LayoutTestController needs removeAllVisitedLinks implementation
3453         https://bugs.webkit.org/show_bug.cgi?id=82724
3454
3455         Reviewed by Csaba Osztrogonác.
3456
3457         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3458         (LayoutTestController::removeAllVisitedLinks):
3459
3460 2012-08-06  Mario Sanchez Prada  <msanchez@igalia.com>
3461
3462         [WK2][GTK] Implement a new spell checker API for WebKit2GTK+
3463         https://bugs.webkit.org/show_bug.cgi?id=90268
3464
3465         Reviewed by Martin Robinson.
3466
3467         Ignore WebKitTextChecker.* private files for gtk-doc.
3468
3469         * gtk/generate-gtkdoc:
3470         (get_webkit2_options):
3471
3472 2012-08-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3473
3474         Unreviewed. Roll out r124728 because of build bot test fail.
3475
3476         * Scripts/webkitpy/common/config/watchlist:
3477
3478 2012-08-05  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3479
3480         Unreviewed. Change my email address for watch list.
3481
3482         * Scripts/webkitpy/common/config/watchlist:
3483
3484 2012-08-04  Nico Weber  <thakis@chromium.org>
3485
3486         [Chromium Mac] Tests are exiting early due to failures to load missingImage.png
3487         https://bugs.webkit.org/show_bug.cgi?id=93186
3488
3489         Reviewed by Ryosuke Niwa.
3490
3491         Add missingImage.png to DumpRenderTree.app's Resource folder.
3492         Depends on http://crrev.com/150037 rolling into webkit first.
3493
3494         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3495
3496 2012-08-03  Ryosuke Niwa  <rniwa@webkit.org>
3497
3498         Stop exposing window.layoutTestController in layout tests in favor of window.testRunner
3499         https://bugs.webkit.org/show_bug.cgi?id=93173
3500
3501         Reviewed by Adam Barth.
3502
3503         Don't expose window.layoutTestController since all layout tests use window.testRunner
3504         instead of window.layoutTestController as of r124685.
3505
3506         We can safely rename classes and files to use TestRunner once this patch is landed.
3507
3508         * DumpRenderTree/LayoutTestController.cpp:
3509         (LayoutTestController::makeWindowObject):
3510         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3511         (notifyTestCompletion):
3512         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3513         (PluginTest::waitUntilDone):
3514         (PluginTest::notifyDone):
3515         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
3516         (ConvertPoint::NPP_SetWindow):
3517         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3518         (handleEventCarbon):
3519         (handleEventCocoa):
3520         (handleEventWin):
3521         * DumpRenderTree/chromium/TestShell.cpp:
3522         (TestShell::bindJSObjectsToWindow):
3523         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3524         (WebCore::DumpRenderTree::initJSObjects):
3525         * Scripts/bencher:
3526         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3527         (WTR::LayoutTestController::makeWindowObject):
3528
3529 2012-08-04  Ilya Tikhonovsky  <loislo@chromium.org>
3530
3531         Unreviewed: Web Inspector: extend instrumenting methods set in ReportMemoryUsage clang plugin
3532         Three methods addString, addVectorPtr and addInstrumentedVectorPtr were added to the list of instrumentation methods.
3533
3534         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
3535         (clang::ReportMemoryUsageConsumer::ReportMemoryUsageConsumer):
3536
3537 2012-08-03  Yaron Friedman  <yfriedman@chromium.org>
3538
3539         [Chrome-Android] - Prepare apk tests for switch to checked in SDK.
3540         https://bugs.webkit.org/show_bug.cgi?id=92931
3541
3542         Reviewed by Adam Barth.
3543
3544         Pass Android-specific gyp variables to the native test generator,
3545         avoiding any dependencies on environment variables during build time.
3546
3547         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3548         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3549
3550 2012-08-03  Rick Byers  <rbyers@chromium.org>
3551
3552         Double tap gesture should send dblclick event
3553         https://bugs.webkit.org/show_bug.cgi?id=92412
3554
3555         Reviewed by Adam Barth.
3556
3557         Enable EventSender to set the tap count on tap gesture events.  The
3558         delta X/Y parameters were not actually being used anymore (used to be
3559         used for radius information).
3560
3561         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
3562         (EventSender::gestureEvent):
3563
3564 2012-08-03  Ryosuke Niwa  <rniwa@webkit.org>
3565
3566         run-perf-tests should generate JSON output and results page by default
3567         https://bugs.webkit.org/show_bug.cgi?id=93042
3568
3569         Reviewed by Eric Seidel.
3570
3571         Generate results JSON and page named PerfTestResults.json and PerfTestResults.html by default.
3572
3573         * Scripts/webkitpy/layout_tests/port/base.py:
3574         (Port.perf_results_directory): Added.
3575         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3576         (PerfTestsRunner): Added _DEFAULT_JSON_FILENAME.
3577         (PerfTestsRunner._parse_args): Added --no-results option in the case a user doens't want to generate
3578         results JSON or results page.
3579         (PerfTestsRunner.run):
3580         (PerfTestsRunner._generate_and_show_results): Extracted from run. Set the default json file path using
3581         port's perf_results_directory and call show_results_html_file at the end if the results page is generated.
3582         (PerfTestsRunner._generate_results_dict): Renamed from _generate_output to disambiguate it from
3583         _generate_and_show_results.
3584         (PerfTestsRunner._generate_output_files): Takes results page's path instead of a boolean indicating
3585         whether results page should be generated or not.
3586         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3587         (create_runner_and_setup_results_template):
3588         (test_run_respects_results_output): Added.
3589         (test_run_generates_json_by_default): Added.
3590         (test_run_generates_and_show_results_page): Added a check to ensure show_results_html_file is called.
3591
3592 2012-08-03  Sheriff Bot  <webkit.review.bot@gmail.com>
3593
3594         Unreviewed, rolling out r124628.
3595         http://trac.webkit.org/changeset/124628
3596         https://bugs.webkit.org/show_bug.cgi?id=93155
3597
3598         Causes random crashes of DRT on Chromium bots (Requested by
3599         dimich on #webkit).
3600
3601         * DumpRenderTree/DumpRenderTree.gypi:
3602         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
3603         (MockWebKitPlatformSupport::createMediaStreamCenter):
3604         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h:
3605         (MockWebKitPlatformSupport):
3606         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
3607         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
3608         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp: Removed.
3609         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h: Removed.
3610
3611 2012-08-03  Brady Eidson  <beidson@apple.com>
3612
3613         Small part of "Out-of-process plug-ins should support asynchronous initialization."
3614         <rdar://problem/10598594> and https://bugs.webkit.org/show_bug.cgi?id=92919
3615
3616         Reviewed by Anders Carlsson.
3617
3618         * WebKitTestRunner/TestController.cpp:
3619         (WTR::TestController::resetStateToConsistentValues): Reset all preferences related to asynchronous plugin initialization.
3620
3621 2012-08-02  Jeffrey Pfau  <jpfau@apple.com>
3622
3623         Add API for enabling blanket third-party data blocking
3624         https://bugs.webkit.org/show_bug.cgi?id=93022
3625
3626         Reviewed by Anders Carlsson.
3627
3628         Added test for default setting of new third-party storage blocking API.
3629
3630         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3631         (TestWebKitAPI::TEST):
3632
3633 2012-08-03  Arvid Nilsson  <anilsson@rim.com>
3634
3635         Unreviewed, adding self to committers.py after becoming committer.
3636
3637         * Scripts/webkitpy/common/config/committers.py:
3638
3639 2012-08-03  Ádám Kallai  <kadam@inf.u-szeged.hu>
3640
3641         Limited the number of queried cached build infos in URLs used by Garden-o-matic.
3642         https://bugs.webkit.org/show_bug.cgi?id=92992.
3643
3644         Reviewed by Adam Barth.
3645
3646         I added a limit to the cached builds that are included in the URL to avoid too long URLs in Garden-o-matic.
3647
3648         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: