f2c5053b12b969e553d95414ad2ad223f0f78061
[WebKit-https.git] / Tools / ChangeLog
1 2017-08-09  Sam Weinig  <sam@webkit.org>
2
3         Update for https://bugs.webkit.org/show_bug.cgi?id=175244.
4
5         * TestWebKitAPI/Tests/WTF/Function.cpp:
6         Remove tests of null Functions, as they are no longer supported.
7
8 2017-08-09  Daniel Bates  <dabates@apple.com>
9
10         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
11         https://bugs.webkit.org/show_bug.cgi?id=175247
12         <rdar://problem/33679804>
13
14         Reviewed by Brady Eidson.
15
16         Add tests for redirects.
17
18         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
19         (TEST):
20         * TestWebKitAPI/cocoa/TestProtocol.mm:
21         (createRedirectURL):
22         (-[TestProtocol startLoading]):
23
24 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
25
26         Unreviewed, rolling out r220393.
27
28         This patch regresses the performance of WebPage::editorState.
29
30         Reverted changeset:
31
32         "[iOS WK2] WKWebView schedules nonstop layout after pressing
33         cmb+b,i,u inside a contenteditable div"
34         https://bugs.webkit.org/show_bug.cgi?id=175116
35         http://trac.webkit.org/changeset/220393
36
37 2017-08-08  obinna obike  <oobike@apple.com>
38
39         Created Individual EWS Pages
40         https://bugs.webkit.org/show_bug.cgi?id=174477
41
42         Reviewed by Aakash Jain.
43
44         Created individual pages for each EWS. Changed the link within each status bubble
45         to go directly to the individual EWS page. Also added a link to original status page showing all EWSes.
46
47         * QueueStatusServer/handlers/patch.py:
48         (Patch.get): Handles the case for individual ews queue as well as for all EWS queues.
49         * QueueStatusServer/handlers/statusbubble.py:
50         (StatusBubble._build_bubble): Updated url for specific EWS.
51         * QueueStatusServer/main.py: Added a link to the individual ews in the routes dictionary.
52         * QueueStatusServer/templates/patch.html: Added a link to go directly to the page with
53         all ews queues.
54         * QueueStatusServer/templates/statusbubble.html: If you click on a statusbubble it
55         takes you directly to the individual ews page.
56
57 2017-08-08  Stephan Szabo  <stephan.szabo@sony.com>
58
59         Separate jsc stress test script writer from run-jsc-stress-tests
60         https://bugs.webkit.org/show_bug.cgi?id=175216
61
62         Reviewed by Mark Lam.
63
64         * Scripts/run-jsc-stress-tests:
65         * Scripts/webkitruby/jsc-stress-test-writer-default.rb: Added.
66
67 2017-08-08  Michael Catanzaro  <mcatanzaro@igalia.com>
68
69         Unreviewed, fix Ubuntu LTS build
70         https://bugs.webkit.org/show_bug.cgi?id=174490
71
72         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
73
74 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
75
76         [Mac WK2] WebViewImpl should hold a weak pointer to its WKWebView or WKView
77         https://bugs.webkit.org/show_bug.cgi?id=175302
78         <rdar://problem/33762116>
79
80         Reviewed by Tim Horton.
81
82         Adds a new unit test checking that delayed event processing in text input context does not cause unwanted behaviors.
83         See WebKit ChangeLog for more details.
84
85         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
86         * TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h: Renamed from Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h.
87         * TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm.
88         (-[SlowTextInputContext handleEventByInputMethod:completionHandler:]):
89         (-[SlowTextInputContext handleEvent:completionHandler:]):
90         (-[SlowInputWebView inputContext]):
91         (-[SlowInputWebView _web_superInputContext]):
92         (TEST):
93
94 2017-08-08  John Wilander  <wilander@apple.com>
95
96         Resource Load Statistics: Clear web processes' state on history removal
97         https://bugs.webkit.org/show_bug.cgi?id=175271
98         <rdar://problem/33756560>
99
100         Reviewed by Chris Dumez.
101
102         Test infrastructure for asynchronous tests of website data
103         removal for _WKWebsiteDataTypeResourceLoadStatistics.
104
105         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
106         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
107         (WTR::InjectedBundle::didReceiveMessageToPage):
108         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
109         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
110         (WTR::TestRunner::statisticsCallClearThroughWebsiteDataRemovalCallback):
111         * WebKitTestRunner/InjectedBundle/TestRunner.h:
112         * WebKitTestRunner/TestController.cpp:
113         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
114         * WebKitTestRunner/TestController.h:
115         * WebKitTestRunner/TestInvocation.cpp:
116         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
117         (WTR::TestInvocation::didClearStatisticsThroughWebsiteDataRemoval):
118         * WebKitTestRunner/TestInvocation.h:
119         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
120         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
121
122 2017-08-08  Alicia Boya García  <aboya@igalia.com>
123
124         Add Alicia Boya García as contributor
125         https://bugs.webkit.org/show_bug.cgi?id=175326
126
127         Reviewed by Michael Catanzaro.
128
129         * Scripts/webkitpy/common/config/contributors.json:
130
131 2017-08-08  Michael Catanzaro  <mcatanzaro@igalia.com>
132
133         [CMake] Properly test if compiler supports compiler flags
134         https://bugs.webkit.org/show_bug.cgi?id=174490
135
136         Reviewed by Konstantin Tokarev.
137
138         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
139         * MiniBrowser/gtk/CMakeLists.txt:
140         * TestRunnerShared/Bindings/JSWrapper.cpp:
141         (WTR::JSWrapper::initialize):
142         * TestWebKitAPI/CMakeLists.txt:
143         * TestWebKitAPI/PlatformGTK.cmake:
144         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
145         (TestWebKitAPI::CheckedArithmeticTester::run):
146         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
147         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
148         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
149         (formControlsAssociatedCallback):
150         * TestWebKitAPI/glib/CMakeLists.txt:
151         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
152         (Test::getResourcesDir):
153         * WebKitTestRunner/CMakeLists.txt:
154         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
155         (WTR::menuItemClickCallback):
156         (WTR::staticConvertMenuItemToType):
157         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
158         (WTR::TestRunner::setUseDashboardCompatibilityMode):
159         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
160         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
161         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
162         (WTR::AccessibilityUIElement::helpText const):
163         (WTR::AccessibilityUIElement::attributedStringForRange):
164         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
165         (WTR::EventSenderProxy::updateTouchPoint):
166         (WTR::EventSenderProxy::releaseTouchPoint):
167
168 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
169
170         [iOS WK2] WKWebView schedules nonstop layout after pressing cmb+b,i,u inside a contenteditable div
171         https://bugs.webkit.org/show_bug.cgi?id=175116
172         <rdar://problem/28279301>
173
174         Reviewed by Darin Adler and Ryosuke Niwa.
175
176         Introduces new testing infrastructure and API tests to test EditorState updates in the UI process. The new
177         EditorStateTests run on both iOS and Mac.
178
179         * TestWebKitAPI/EditingTestHarness.h: Added.
180         * TestWebKitAPI/EditingTestHarness.mm: Added.
181
182         EditingTestHarness is a helper object that API tests may use to apply editing commands and store EditorState
183         history. This test harness adds sugaring around various editing commands, and simplifies the process of checking
184         the state of the latest observed EditorState.
185
186         (-[EditingTestHarness initWithWebView:]):
187         (-[EditingTestHarness dealloc]):
188         (-[EditingTestHarness webView]):
189         (-[EditingTestHarness latestEditorState]):
190         (-[EditingTestHarness editorStateHistory]):
191         (-[EditingTestHarness insertText:andExpectEditorStateWith:]):
192         (-[EditingTestHarness insertHTML:andExpectEditorStateWith:]):
193         (-[EditingTestHarness selectAllAndExpectEditorStateWith:]):
194         (-[EditingTestHarness moveBackwardAndExpectEditorStateWith:]):
195         (-[EditingTestHarness moveWordBackwardAndExpectEditorStateWith:]):
196         (-[EditingTestHarness toggleBold]):
197         (-[EditingTestHarness toggleItalic]):
198         (-[EditingTestHarness toggleUnderline]):
199         (-[EditingTestHarness setForegroundColor:]):
200         (-[EditingTestHarness alignJustifiedAndExpectEditorStateWith:]):
201         (-[EditingTestHarness alignLeftAndExpectEditorStateWith:]):
202         (-[EditingTestHarness alignCenterAndExpectEditorStateWith:]):
203         (-[EditingTestHarness alignRightAndExpectEditorStateWith:]):
204         (-[EditingTestHarness insertParagraphAndExpectEditorStateWith:]):
205         (-[EditingTestHarness deleteBackwardAndExpectEditorStateWith:]):
206         (-[EditingTestHarness _execCommand:argument:expectEntries:]):
207
208         Dispatches an editing command to the web process, and blocks until a response is received. If an expected
209         entries dictionary is given, this will additionally verify that the latest EditorState contains all the expected
210         keys and values.
211
212         (-[EditingTestHarness latestEditorStateContains:]):
213         (-[EditingTestHarness _webView:editorStateDidChange:]):
214         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
215         * TestWebKitAPI/Tests/WebKit2Cocoa/EditorStateTests.mm: Added.
216         (TestWebKitAPI::setUpEditorStateTestHarness):
217         (TestWebKitAPI::TEST):
218         * TestWebKitAPI/Tests/WebKit2Cocoa/editor-state-test-harness.html: Added.
219
220 2017-08-04  Brent Fulgham  <bfulgham@apple.com>
221
222         Prevent domain from being set to a TLD
223         https://bugs.webkit.org/show_bug.cgi?id=175226
224         <rdar://problem/11079948>
225
226         Reviewed by Chris Dumez.
227
228         Extend the public suffix tests to include cases used by the
229         Public Domain 'Public Suffix List'.
230
231         * TestWebKitAPI/Tests/mac/PublicSuffix.cpp: 
232         (TestWebKitAPI::TEST):
233
234 2017-08-07  Stephan Szabo  <stephan.szabo@sony.com>
235
236         [XCode] webkit-patch should run sort-Xcode-project-file
237         https://bugs.webkit.org/show_bug.cgi?id=174036
238         <rdar://problem/33732709>
239
240         Reviewed by Simon Fraser.
241
242         * Scripts/webkitpy/common/config/ports.py:
243         * Scripts/webkitpy/tool/commands/download.py:
244         * Scripts/webkitpy/tool/commands/download_unittest.py:
245         * Scripts/webkitpy/tool/commands/upload.py:
246         * Scripts/webkitpy/tool/commands/upload_unittest.py:
247         * Scripts/webkitpy/tool/steps/__init__.py:
248         * Scripts/webkitpy/tool/steps/options.py:
249         * Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
250
251 2017-08-07  Devin Rousso  <drousso@apple.com>
252
253         Web Inspector: Preview Canvas path when viewing a recording
254         https://bugs.webkit.org/show_bug.cgi?id=174967
255
256         Reviewed by Brian Burg.
257
258         * DumpRenderTree/TestOptions.h:
259         * DumpRenderTree/TestOptions.mm:
260         (TestOptions::TestOptions):
261         * DumpRenderTree/mac/DumpRenderTree.mm:
262         (setWebPreferencesForTestOptions):
263         * WebKitTestRunner/TestController.cpp:
264         (WTR::TestController::resetPreferencesToConsistentValues):
265         (WTR::updateTestOptionsFromTestHeader):
266         * WebKitTestRunner/TestOptions.h:
267         (WTR::TestOptions::hasSameInitializationOptions const):
268         Add plumbing for new InspectorAdditions runtime flag.
269
270 2017-08-07  obinna obike  <oobike@apple.com>
271
272         Sorted EWS Queues on Patch page
273         https://bugs.webkit.org/show_bug.cgi?id=173667
274
275         Reviewed by Aakash Jain.
276
277         * QueueStatusServer/handlers/patch.py:
278         (Patch.get): Sorted queue_status.
279         * QueueStatusServer/templates/patch.html:
280         Changed queue_status.items to queue_status because it's a list.
281
282 2017-08-07  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
283
284         check-webkit-style: NS_ERROR_ENUM and NS_OPTIONS should not be handled as function definitions.
285         https://bugs.webkit.org/show_bug.cgi?id=175286
286
287         Reviewed by Myles C. Maxfield.
288
289         * Scripts/webkitpy/style/checkers/cpp.py:
290         (check_braces):
291         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
292         (WebKitStyleTest.test_braces.NS_ERROR_ENUM):
293         (WebKitStyleTest.test_braces):
294         (WebKitStyleTest.test_braces.NS_OPTIONS):
295
296 2017-08-07  Brian Burg  <bburg@apple.com>
297
298         Remove CANVAS_PATH compilation guard
299         https://bugs.webkit.org/show_bug.cgi?id=175207
300
301         Reviewed by Sam Weinig.
302
303         * Scripts/webkitperl/FeatureList.pm:
304         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
305
306 2017-08-07  Per Arne Vollan  <pvollan@apple.com>
307
308         [Win] Use Visual Studio 2017 if installed.
309         https://bugs.webkit.org/show_bug.cgi?id=175188
310
311         Reviewed by Sam Weinig.
312
313         If installed, use VS2017 to build WebKit. If not, fall back to VS2015.
314
315         * Scripts/webkitdirs.pm:
316         (visualStudioInstallDir):
317         (msBuildInstallDir):
318
319 2017-08-05  Carlos Garcia Campos  <cgarcia@igalia.com>
320
321         [GTK][WPE] Add API to provide browser information required by automation
322         https://bugs.webkit.org/show_bug.cgi?id=175130
323
324         Reviewed by Michael Catanzaro.
325
326         * MiniBrowser/gtk/main.c:
327         (automationStartedCallback): Set browser information when a new automation session is started.
328         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
329         (testAutomationSessionApplicationInfo):
330         (beforeAll):
331
332 2017-08-06  Ryan Haddad  <ryanhaddad@apple.com>
333
334         Unreviewed, rolling out r220295.
335
336         This change introduced 4 errors in webkitpy tests.
337
338         Reverted changeset:
339
340         "[XCode] webkit-patch should run sort-Xcode-project-file"
341         https://bugs.webkit.org/show_bug.cgi?id=174036
342         http://trac.webkit.org/changeset/220295
343
344 2017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
345
346         Disable API test NowPlayingControlsTests.NowPlayingControlsIOS.
347
348         Unreviewed test gardening.
349
350         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
351         (TestWebKitAPI::TEST):
352
353 2017-08-05  Filip Pizlo  <fpizlo@apple.com>
354
355         REGRESSION (r219895-219897): Number of leaks on Open Source went from 9240 to 235983 and is now at 302372
356         https://bugs.webkit.org/show_bug.cgi?id=175083
357
358         Reviewed by Oliver Hunt.
359         
360         Leaks results are super confusing if leaks runs while some VMs are destructing. This calls a new SPI
361         to wait for VM destructions to finish before running the next test. This makes it easier to 
362         understand leaks results from workers tests, and leads to fewer reported leaks.
363
364         * DumpRenderTree/mac/DumpRenderTree.mm:
365         (runTest):
366
367 2017-08-05  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
368
369         check-webkit-style: fix path-specific rules for WebKit2 rename
370         https://bugs.webkit.org/show_bug.cgi?id=175182
371
372         Reviewed by David Kilzer.
373
374         * Scripts/webkitpy/style/checker.py:
375
376 2017-08-04  Youenn Fablet  <youenn@apple.com>
377
378         [Cache API] Add Cache and CacheStorage IDL definitions
379         https://bugs.webkit.org/show_bug.cgi?id=175201
380
381         Reviewed by Brady Eidson.
382
383         * DumpRenderTree/mac/DumpRenderTree.mm:
384         (enableExperimentalFeatures):
385         (resetWebPreferencesToConsistentValues):
386         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
387         (WTR::InjectedBundle::beginTesting):
388         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
389         (WTR::TestRunner::setCacheAPIEnabled):
390         * WebKitTestRunner/InjectedBundle/TestRunner.h:
391
392 2017-08-04  John Wilander  <wilander@apple.com>
393
394         Resource Load Statistics: Report user interaction immediately, but only when needed
395         https://bugs.webkit.org/show_bug.cgi?id=175090
396         <rdar://problem/33685546>
397
398         Reviewed by Chris Dumez.
399
400         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
401         (WTR::InjectedBundle::beginTesting):
402             Now calls WebCore::ResourceLoadObserver::clearState().
403
404 2017-08-04  Tim Horton  <timothy_horton@apple.com>
405
406         Add an API test for r220286
407         https://bugs.webkit.org/show_bug.cgi?id=175206
408
409         Reviewed by Simon Fraser.
410
411         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
412         (-[AnimatedResizeWebView _webView:didChangeSafeAreaShouldAffectObscuredInsets:]):
413         (createAnimatedResizeWebView):
414         (TEST):
415         Add a test to ensure that we don't call
416         _webView:didChangeSafeAreaShouldAffectObscuredInsets: during an
417         animated resize.
418
419 2017-08-04  Stephan Szabo  <stephan.szabo@sony.com>
420
421         [XCode] webkit-patch should run sort-Xcode-project-file
422         https://bugs.webkit.org/show_bug.cgi?id=174036
423
424         Reviewed by Simon Fraser.
425
426         * Scripts/webkitpy/common/config/ports.py:
427         * Scripts/webkitpy/tool/commands/download.py:
428         * Scripts/webkitpy/tool/commands/upload.py:
429         * Scripts/webkitpy/tool/steps/__init__.py:
430         * Scripts/webkitpy/tool/steps/options.py:
431         * Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
432
433 2017-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
434
435         REGRESSION(r219857): run-benchmark --allplans broken
436         https://bugs.webkit.org/show_bug.cgi?id=175186
437
438         Reviewed by Saam Barati.
439
440         r219857 forgot to update also the calls to BenchmarkRunner() that
441         is done when the script is run with --allplans.
442
443         To fix this (and avoid future issues like this), let's factorize
444         the calls to the benchhmark runner in a run_benchmark_plan()
445         function.
446
447         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
448         (run_benchmark_plan):
449         (start):
450
451 2017-08-04  Aakash Jain  <aakash_jain@apple.com>
452
453         Dashboard bubbles sometimes show failure count instead of crash count
454         https://bugs.webkit.org/show_bug.cgi?id=175157
455         <rdar://problem/33709009>
456
457         Reviewed by Alexey Proskuryakov.
458
459         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
460         (BuildbotTestResults.prototype.resultSummarizer): Use the regex for the precise match first.
461
462 2017-08-04  Joseph Pecoraro  <pecoraro@apple.com>
463
464         Add tests for NeverDestroyed
465         https://bugs.webkit.org/show_bug.cgi?id=175146
466
467         Reviewed by Darin Adler.
468
469         * CMakeLists.txt:
470         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
471         New files and sort.
472
473         * TestWebKitAPI/Tests/WTF/Logger.h:
474         * TestWebKitAPI/Tests/WTF/Logger.cpp:
475         (TestWebKitAPI::log):
476         (TestWebKitAPI::takeLogStr):
477         * TestWebKitAPI/Tests/WTF/RefLogger.h:
478         * TestWebKitAPI/Tests/WTF/RefLogger.cpp:
479         (TestWebKitAPI::log): Deleted.
480         (TestWebKitAPI::takeLogStr): Deleted.
481         Extract log() / takeLogStr() from RefLogger to a general Logger.h/cpp.
482
483         * TestWebKitAPI/Tests/WTF/LifecycleLogger.h:
484         * TestWebKitAPI/Tests/WTF/LifecycleLogger.cpp: Added.
485         (TestWebKitAPI::LifecycleLogger::LifecycleLogger):
486         (TestWebKitAPI::LifecycleLogger::operator=):
487         (TestWebKitAPI::LifecycleLogger::~LifecycleLogger):
488         (TestWebKitAPI::LifecycleLogger::setName):
489         (TestWebKitAPI::TEST):
490         Add a class that logs construction / assignment / modifications.
491
492         * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp: Added.
493         (TestWebKitAPI::TEST):
494         (TestWebKitAPI::list):
495         Test construction behavior is as expected both directly and using makeNeverDestroyed.
496
497 2017-08-04  Lucas Forschler  <lforschler@apple.com>
498
499         minification logic is not implemented for ios builds
500         <rdar://problem/33726561>
501
502         Reviewed by Dean Johnson
503
504         * BuildSlaveSupport/built-product-archive:
505         (minifyDirectory): refactor minifySource -> minifyDirectory
506         (archiveBuiltProduct): add ios minification logic
507         (minifySource): Deleted.
508
509 2017-08-04  Matt Lewis  <jlewis3@apple.com>
510
511         Unreviewed, rolling out r220271.
512
513         Rolling out due to Layout Test failing on iOS Simulator.
514
515         Reverted changeset:
516
517         "Remove STREAMS_API compilation guard"
518         https://bugs.webkit.org/show_bug.cgi?id=175165
519         http://trac.webkit.org/changeset/220271
520
521 2017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
522
523         Unreviewed, rolling out r220268.
524
525         This change caused assertion failures on macOS and iOS Debug
526         WK2.
527
528         Reverted changeset:
529
530         "Resource Load Statistics: Report user interaction
531         immediately, but only when needed"
532         https://bugs.webkit.org/show_bug.cgi?id=175090
533         http://trac.webkit.org/changeset/220268
534
535 2017-08-04  Youenn Fablet  <youenn@apple.com>
536
537         Remove STREAMS_API compilation guard
538         https://bugs.webkit.org/show_bug.cgi?id=175165
539
540         Reviewed by Darin Adler.
541
542         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
543
544 2017-08-04  John Wilander  <wilander@apple.com>
545
546         Resource Load Statistics: Report user interaction immediately, but only when needed
547         https://bugs.webkit.org/show_bug.cgi?id=175090
548         <rdar://problem/33685546>
549
550         Reviewed by Chris Dumez.
551
552         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
553         (WTR::InjectedBundle::beginTesting):
554             Now calls WebCore::ResourceLoadObserver::clearState().
555
556 2017-08-03  Brian Burg  <bburg@apple.com>
557
558         Remove ENABLE(WEB_SOCKET) guards
559         https://bugs.webkit.org/show_bug.cgi?id=167044
560
561         Reviewed by Joseph Pecoraro.
562
563         * Scripts/webkitperl/FeatureList.pm:
564         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
565
566 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
567
568         REGRESSION(r219850): run-benchmark script broken on Linux
569         https://bugs.webkit.org/show_bug.cgi?id=175126
570
571         Reviewed by Stephanie Lewis.
572
573         The run-benchmark script dynamically generates the list of supported
574         browsers and platforms (currently Linux and OSX) by loading all
575         python files from Tools/Scripts/webkitpy/benchmark_runner/browser_driver
576         and getting the browser_name and platform variables from the
577         classes defined there.
578
579         This means that this classes should not raise an exception when
580         loaded on other platforms or otherwise they will broke the whole
581         script. Its fine if they raise an exception when executing any of
582         the methods they implement, but not when just loading/importing
583         the class.
584
585         Move the argument variable definitions that call on the platform
586         specific OSXBrowserDriver._screen_size() function from beeing
587         variables that are evaluated when loading the file, to be functions
588         that are only evaluated when the actual functionality needs to be
589         executed.
590
591         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
592         (OSXChromeDriver.launch_url):
593         (OSXChromeCanaryDriver.launch_url):
594         (create_args):
595         (create_chrome_options):
596         (create_window_size_arg):
597         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
598         (OSXFirefoxDriver.launch_url):
599         (OSXFirefoxNightlyDriver.launch_url):
600         (OSXFirefoxNightlyDriver.launch_driver):
601         (create_args):
602
603 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
604
605         [PAL] Move spi/cf directory into PAL
606         https://bugs.webkit.org/show_bug.cgi?id=175057
607
608         Reviewed by Antti Koivisto.
609
610         * Scripts/webkitpy/style/checker.py:
611         * Scripts/webkitpy/style/checker_unittest.py:
612         (GlobalVariablesTest.test_path_rules_specifier):
613
614         Ignore "readability/naming/underscores" style errors for sources
615         under the WebCore/PAL/pal/spi directory.
616
617         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
618
619 2017-08-03  Youenn Fablet  <youenn@apple.com>
620
621         Remove FETCH_API compilation guard
622         https://bugs.webkit.org/show_bug.cgi?id=175154
623
624         Reviewed by Chris Dumez.
625
626         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
627
628 2017-08-03  Lucas Forschler  <lforschler@apple.com>
629
630         Enable archive minification on iOS builds
631         https://bugs.webkit.org/show_bug.cgi?id=174718
632         
633         Reviewed by Aakash Jain.
634
635         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
636         (BuildFactory.__init__):
637
638 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
639
640         [GTK][WKE] Pass the --memory-limited option on the GTK and WPE buildbots for the JSC tests.
641         https://bugs.webkit.org/show_bug.cgi?id=175140
642
643         Reviewed by Alexey Proskuryakov.
644
645         We are having lately issues with JSC tests causing problems on
646         the GTK+ and WPE bots due to the high amount of memory some tests
647         need to run.
648
649         The best thing we can do now is to workaround this by disabling
650         all the tests marked as memoryLimited on the GTK and WPE bots.
651         We may revise this on the future.
652
653         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
654         (RunJavaScriptCoreTests.start):
655
656 2017-08-03  Brady Eidson  <beidson@apple.com>
657
658         Add SW IDLs and stub out basic functionality.
659         https://bugs.webkit.org/show_bug.cgi?id=175115
660
661         Reviewed by Chris Dumez.
662
663         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
664
665         * Scripts/webkitpy/bindings/main.py:
666
667 2017-08-03  Per Arne Vollan  <pvollan@apple.com>
668
669         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
670         https://bugs.webkit.org/show_bug.cgi?id=159510
671
672         Reviewed by Daniel Bates.
673
674         Allow any https certificate when running tests.
675
676         * DumpRenderTree/win/DumpRenderTree.cpp:
677         (runTest):
678
679 2017-08-02  Youenn Fablet  <youenn@apple.com>
680
681         HTTP tests with 'https' suffix are only run over HTTPS for WK2, not WK1
682         https://bugs.webkit.org/show_bug.cgi?id=175089
683
684         Reviewed by Chris Dumez.
685
686         * DumpRenderTree/TestOptions.mm:
687         (TestOptions::TestOptions): Using absolutePath if available.
688         * DumpRenderTree/mac/DumpRenderTree.mm:
689         (computeTestURL): Removing http/tests/ specific URL computation.
690         * Scripts/webkitpy/port/driver.py:
691         (Driver._command_from_driver_input): Making webkitpy passing HTTP urls for HTTP served tests to all test runners, including WK1.
692
693 2017-08-02  Lucas Forschler  <lforschler@apple.com>
694
695         download-built-product should allow for a proxy option
696         https://bugs.webkit.org/show_bug.cgi?id=174875
697
698         Reviewed by Aakash Jain, Alexey Proskuryakov, Dean Johnson
699
700         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
701         (DownloadBuiltProduct.start): Teach buildbot to pass along proxy for Apple bots
702         
703
704 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
705
706         check-webkit-style: deleting lines in a file runs the linter on the whole file
707         https://bugs.webkit.org/show_bug.cgi?id=175078
708
709         Reviewed by David Kilzer.
710
711         Deleting lines in a file should not cause linter errors to be blamed on the patch.
712         <https://bugs.webkit.org/show_bug.cgi?id=86142> is an example of this happening.
713
714         * Scripts/webkitpy/style/checkers/test_expectations.py:
715         (TestExpectationsChecker._should_log_linter_warning): Do not log a linter error if the file it is associated with only has deleted lines
716         * Scripts/webkitpy/style/main_unittest.py:
717         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Added files should have every line number in the file when processing.
718         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Test case where the file with the linter errors only contained deletes.
719         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Added files should have every line number in the file when processing.
720
721 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
722
723         webkitpy: Allow caller to specify response to unicode encode/decode error in filesystem
724         https://bugs.webkit.org/show_bug.cgi?id=175075
725
726         Reviewed by David Kilzer.
727
728         We have no way of handling text files with illegal unicode characters. Allow the callers of
729         filesystem.read_text_file to specify one of Python 2.7's supported responses ('strict', 'ignore', or
730         'replace'). See https://docs.python.org/2/howto/unicode.html for details on these responses.
731
732         * Scripts/webkitpy/common/system/filesystem.py:
733         (FileSystem.read_text_file): Allow caller to specify unicode error handling.
734         (FileSystem.write_text_file): Ditto.
735         * Scripts/webkitpy/common/system/filesystem_mock.py:
736         (MockFileSystem.read_text_file): Allow caller to specify unicode error handling.
737         (MockFileSystem.write_text_file): Ditto.
738         * Scripts/webkitpy/common/system/filesystem_unittest.py:
739         (RealFileSystemTest.test_read_text_file_unicode_decode_error): Test reading a file with illegal unicode content.
740         (RealFileSystemTest.test_write_text_file_unicode_encode_error): Test writing illegal unicode content to a file.
741
742 2017-08-02  Aakash Jain  <aakash_jain@apple.com>
743
744         Intermittent exception in buildPageURLForIteration for Buildbot 0.9 dashboard
745         https://bugs.webkit.org/show_bug.cgi?id=175072
746
747         Reviewed by Alexey Proskuryakov.
748
749         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
750         (Buildbot): Make sure this._builderNameToIDMap is always defined for Buildbot 0.9.
751
752 2017-08-02  Michael Catanzaro  <mcatanzaro@igalia.com>
753
754         [CMake] Remove obsolete code in TestWebKitAPI/CMakeLists.txt
755         https://bugs.webkit.org/show_bug.cgi?id=175019
756
757         Reviewed by Darin Adler.
758
759         * TestWebKitAPI/CMakeLists.txt:
760
761 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
762
763         Enabling uploading archives to S3
764         https://bugs.webkit.org/show_bug.cgi?id=174198
765
766         Unreviewed unit test fix after r219235.
767
768         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
769
770 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
771
772         Fix JSCOnly ARM buildbots after r220047
773         https://bugs.webkit.org/show_bug.cgi?id=174993
774
775         Unreviewed fix after r220087.
776
777         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
778         (BuildAndRemoteJSCTestsFactory.__init__):
779
780 2017-08-01  Chris Dumez  <cdumez@apple.com>
781
782         Add initial support for navigator.sendBeacon
783         https://bugs.webkit.org/show_bug.cgi?id=175007
784         <rdar://problem/33547728>
785
786         Reviewed by Sam Weinig.
787
788         Enable the Beacon API at runtime in the context of layout tests since the
789         feature is currently disabled by default.
790
791         * DumpRenderTree/mac/DumpRenderTree.mm:
792         (enableExperimentalFeatures):
793         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
794         (WTR::InjectedBundle::beginTesting):
795         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
796         (WTR::TestRunner::setModernMediaControlsEnabled):
797         (WTR::TestRunner::setBeaconAPIEnabled):
798         * WebKitTestRunner/InjectedBundle/TestRunner.h:
799
800 2017-08-01  Aakash Jain  <aakash_jain@apple.com>
801
802         Update Bot Watcher's Dashboard for Buildbot 0.9
803         https://bugs.webkit.org/show_bug.cgi?id=174777
804
805         Reviewed by Daniel Bates.
806
807         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
808         (Buildbot): Check if USE_BUILDBOT_VERSION_LESS_THAN_09 is passed.
809         (Buildbot.prototype._computeBuilderNameToIDMap): Fetch the builder name to ID mapping from buidbot and store
810         in a dictionary.
811         (Buildbot.prototype.buildPageURLForIteration): Updated URL as per Buildbot 0.9 format. Buildbot 0.9 currently does not support
812         builder name in the build url. See <https://github.com/buildbot/buildbot/issues/3465>.
813         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
814         (isMultiCodebaseGotRevisionProperty): Adapting to new data format.
815         (parseRevisionProperty): Ditto.
816         (BuildbotIteration.prototype.failureLogURL): Return the URL to build page if precise failure url is not available. For
817         Buildbot 0.9, build page URL would be appropriate in most cases as per the new UI.
818         (BuildbotIteration.prototype._parseData): Parsing the data as per new data format. Many variable names and data types
819         have changed in Buildbot 0.9.
820         (BuildbotIteration.prototype._adjustBuildDataForBuildbot09): Adjust the Buildbot 0.8 data to new format.
821         (BuildbotIteration.prototype._updateIfDataAvailable): Update method for Buildbot 0.9 data. We are performing two API calls, 
822         one for build information, another for step information of that build. We need to wait until data from both REST API calls are available.
823         (BuildbotIteration.prototype._deprecatedUpdateWithData): Renamed from _updateWithData, used for Buildbot 0.8 data.
824         (BuildbotIteration.prototype.get buildURL): URL to fetch build information from Buildbot. Also fetches got_revision property.
825         (BuildbotIteration.prototype.get buildStepsURL): URL to fetch the steps information from Buildbot.
826         (BuildbotIteration.prototype.urlFailedToLoad): Callback method to be used when URL fails to load. Made it a separate function now.
827         (BuildbotIteration.prototype.update): Modified to support both Buildbot 0.9 and 0.8 data format.
828         (BuildbotIteration.prototype.actualUpdate): Update method for Buildbot 0.9 data.
829         (BuildbotIteration.prototype.deprecatedUpdate): Update method for Buildbot 0.8 data.
830         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
831         (BuildbotQueue.prototype.get baseURL): Updated URL as per Buildbot 0.9 format.
832         (BuildbotQueue.prototype.get allIterationsURL): Ditto.
833         (BuildbotQueue.prototype.get overviewURL): Ditto.
834         (BuildbotQueue.prototype.get buildsURL): URL to fetch builds data in Buildbot 0.9.
835         (BuildbotQueue.prototype.get buildsInfoURL): Returns the appropriate URL to use to fetch builds information from
836         Buildbot 0.8 or 0.9.
837         (BuildbotQueue.prototype.getBuilds): Method compatible with both Buildbot 0.8 and 0.9 to get build information from data
838         fetched from Buildbot. Also, reversing the Buildbot 0.8 data to make it similar to 0.9 data format.
839         (BuildbotQueue.prototype.isBuildComplete): Method compatible with both Buildbot 0.8 and 0.9 to check if the build has completed.
840         (BuildbotQueue.prototype.getIterationID):  Method compatible with both Buildbot 0.8 and 0.9 to get the Iteration ID.
841         (BuildbotQueue.prototype.update): Supports both Buildbot 0.8 and 0.9. Buildbot 0.9 REST API doesn't have cachedBuilds and currentBuilds. 
842         Therefore we are fetching information for fixed number of build. 
843         Also iterating the loop incrementally since the build data is already reverse sorted.
844         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
845         (BuildbotTestResults.prototype._parseResults): Updated as per Buildbot 0.9 format. Note that we do not
846         need to worry about 0.8 or 0.9 data format here, since the data is already converted to 0.9 format.
847         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
848         (WebKitBuildbot): Pass the USE_BUILDBOT_VERSION_LESS_THAN_09 flag.
849
850 2017-08-01  Devin Rousso  <drousso@apple.com>
851
852         Web Inspector: simplify WebInspector with WI
853         https://bugs.webkit.org/show_bug.cgi?id=175058
854
855         Reviewed by Joseph Pecoraro.
856
857         * Scripts/check-inspector-strings:
858         (extract_ui_strings):
859         * Scripts/extract-localizable-js-strings:
860
861 2017-08-01  Youenn Fablet  <youenn@apple.com>
862
863         Layout tests with 'https' suffix should be run over HTTPS
864         https://bugs.webkit.org/show_bug.cgi?id=174992
865
866         Reviewed by Chris Dumez.
867
868         Updating the test-name <-> uri conversion routines to use https when test names contain ".https." in them.
869         This covers WPT tests, WPT WebKit tests and HTTP layout tests.
870         Covered by corresponding unit tests.
871
872         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
873         (run_server):
874         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
875         (base_http_url):
876         (base_https_url):
877         (base_url): Deleted.
878         * Scripts/webkitpy/port/base.py:
879         (Port.to.web_platform_test_server_base_http_url):
880         (Port.to):
881         (Port.to.web_platform_test_server_base_https_url):
882         (Port.to.web_platform_test_server_base_url): Deleted.
883         * Scripts/webkitpy/port/driver.py:
884         (Driver.__init__):
885         (Driver.wpt_test_path_to_uri):
886         (Driver):
887         (Driver.http_test_path_to_uri):
888         (Driver.test_to_uri):
889         (Driver.uri_to_test):
890         * Scripts/webkitpy/port/driver_unittest.py:
891         (DriverTest.test_test_to_uri):
892         (DriverTest.test_uri_to_test):
893
894 2017-07-26  Jiewen Tan  <jiewen_tan@apple.com>
895
896         Add tests to detect mistakes in backward compatibility when the structured clone algorithm is changed in the future
897         https://bugs.webkit.org/show_bug.cgi?id=173998
898
899         Reviewed by Darin Adler.
900
901         Since the structured clone algorithm is used for data stored in persistent databases, we need tests to help us
902         detect mistakes in backward compatibility in the future when we change it.
903
904         The way it works is to read from a pre-baked database and see if all the values are matched with the expectations.
905         Surprisedly, some of structured clonable objects cannot be stored into the indexedDB. Those are FileList,
906         ObjectReference, MessagePortReference, ArrayBufferView, ArrayBufferTransfer, NonMapProperties, NonSetProperties,
907         SharedArrayBuffer, WasmModule, DOMPointReadOnly, DOMPoint, DOMRectReadOnly, DOMRect, DOMMatrixReadOnly, DOMMatrix,
908         DOMQuad and Error. CryptoKey objects are not included as well as they need new API for encrypting/decrypting the
909         internal key data slot.
910
911         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
912         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.mm: Added.
913         (-[IndexedDBStructuredCloneBackwardCompatibilityMessageHandler userContentController:didReceiveScriptMessage:]):
914         (getNextMessage):
915         (TEST):
916         Here is the API test that moves the pre-baked database to the location where TestWebKitAPI can read from.
917         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3: Added.
918         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm: Added.
919         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal: Added.
920         These are the pre-baked databases.
921         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html: Added.
922         This is the actual test that do all the reads and comparisons.
923         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html: Added.
924         This is the page that bakes the database. It never runs automatically. It is for someone who needs to teach
925         IndexedDB new stuffs. Then it can be used to bake the database again.
926
927 2017-08-01  Brady Eidson  <beidson@apple.com>
928
929         API test URLSchemeHandler.Exceptions is Exiting out early on macOS Debug..
930         https://bugs.webkit.org/show_bug.cgi?id=175030
931
932         Reviewed by Andy Estes.
933
934         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
935         (-[TaskSchemeHandler webView:startURLSchemeTask:]): Stop calling an invalid NSError constructor.
936
937 2017-08-01  Brady Eidson  <beidson@apple.com>
938
939         Part 2 of: Rename DatabaseProcess to StorageProcess.
940         https://bugs.webkit.org/show_bug.cgi?id=174880
941
942         Reviewed by Andy Estes.
943
944         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
945         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
946         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
947         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
948         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
949         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
950         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
951         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
952
953 2017-07-31  Csaba Osztrogonác  <ossy@webkit.org>
954
955         Fix JSCOnly ARM buildbots after r220047
956         https://bugs.webkit.org/show_bug.cgi?id=174993
957
958         Reviewed by Saam Barati.
959
960         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
961         (BuildAndRemoteJSCTestsFactory.__init__):
962
963 2017-07-30  Yusuke Suzuki  <utatane.tea@gmail.com>
964
965         [WTF] Introduce Private Symbols
966         https://bugs.webkit.org/show_bug.cgi?id=174935
967
968         Reviewed by Darin Adler.
969
970         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
971         (TestWebKitAPI::TEST):
972
973 2017-07-30  Darin Adler  <darin@apple.com>
974
975         Remove code in HTMLObjectElement attribute parsing that forces style resolution and layout
976         https://bugs.webkit.org/show_bug.cgi?id=130653
977
978         Reviewed by Antti Koivisto.
979
980         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
981         (WTR::InjectedBundlePage::didFinishLoadForFrame): Omit now-unneeded "shouldDump" argument
982         when calling frameDidChangeLocation.
983         (WTR::InjectedBundlePage::frameDidChangeLocation): Removed "shouldDump" argument. This was
984         causing WebKitTestRunner to not dump anything in cases where DumpRenderTree will dump, and
985         thus causing mysterious failures of a couple of tests. There are two remaining issues:
986         1) WebKitTestRunner won't run its dump code if there is no "page", and there is no such
987         consideration in DumpRenderTree and 2) Both DumpRenderTree and WebKitTestRunner share the
988         same logic flaw that causes "top loading frame" to get set to one of the subframes in
989         tests where  the following sequence occurs: test calls waitUntilDone, main frame finishes
990         loading, subframe starts loading. It would be good to clean that up some day, but for now
991         this patch makes the two work identically rather than changing both.
992         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for change above.
993
994 2017-07-30  Wenson Hsieh  <wenson_hsieh@apple.com>
995
996         [WK2] Replace RetainPtr<> with auto when adopting allocated ObjC objects in DataInteractionTests
997         https://bugs.webkit.org/show_bug.cgi?id=174963
998
999         Reviewed by Darin Adler.
1000
1001         Replaces several uses of RetainPtr<>s with auto. Some test cases in this file use auto, while other test cases declare using
1002         RetainPtr<>. This patch changes them to all use auto.
1003
1004         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1005         (TestWebKitAPI::TEST):
1006
1007 2017-07-30  Brady Eidson  <beidson@apple.com>
1008
1009         Add URLSchemeHandler API tests that verify the lack of URLSchemeTask object leaks.
1010         https://bugs.webkit.org/show_bug.cgi?id=174958
1011
1012         Reviewed by Darin Adler.
1013
1014         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1015         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-leaks.mm: Added.
1016         (-[LeakSchemeHandler webView:startURLSchemeTask:]):
1017         (-[LeakSchemeHandler webView:stopURLSchemeTask:]):
1018         (runUntilTasksInFlight):
1019         (TEST):
1020
1021 2017-07-28  Commit Queue  <commit-queue@webkit.org>
1022
1023         Unreviewed, rolling out r219990.
1024         https://bugs.webkit.org/show_bug.cgi?id=174961
1025
1026         "broke PLT on iOS (rdar://problem/33602751)" (Requested by
1027         estes on #webkit).
1028
1029         Reverted changeset:
1030
1031         "Part 2 of: Rename DatabaseProcess to StorageProcess."
1032         https://bugs.webkit.org/show_bug.cgi?id=174880
1033         http://trac.webkit.org/changeset/219990
1034
1035 2017-07-28  Brady Eidson  <beidson@apple.com>
1036
1037         API tests that use URLSchemeHandler are failing.
1038         https://bugs.webkit.org/show_bug.cgi?id=174950
1039
1040         Reviewed by Alex Christensen.
1041
1042         Fix the NoMIMEType test to be correct.
1043
1044         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
1045         (-[SchemeHandler initWithData:mimeType:]):
1046         (-[SchemeHandler webView:startURLSchemeTask:]):
1047         (TEST):
1048
1049 2017-07-28  Daniel Bates  <dabates@apple.com>
1050
1051         prepare-ChangeLog should not list added layout tests in PAL ChangeLog
1052         https://bugs.webkit.org/show_bug.cgi?id=174876
1053
1054         Reviewed by Alex Christensen.
1055
1056         Do not list added layout tests in the PAL ChangeLog as such tests are unlikely to be related
1057         to a PAL change. Unit tests are more appropriate for PAL changes than layout tests because
1058         they provide a more direct way to test the platform abstraction.
1059
1060         As a side effect of this change we no longer list added layout tests in WebCore/platform/gtk/po/ChangeLog.
1061
1062         * Scripts/prepare-ChangeLog:
1063         (generateNewChangeLogs): Only list added layout tests in the WebCore ChangeLog regardless
1064         of the current working directory.
1065
1066 2017-07-28  Jonathan Bedard  <jbedard@apple.com>
1067
1068         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
1069         https://bugs.webkit.org/show_bug.cgi?id=174930
1070
1071         Unreviewed test fix.
1072
1073         We need to check parentheses before printing 'const' or 'volatile' in the ChangeLog. 
1074
1075         * Scripts/prepare-ChangeLog:
1076         (get_function_line_ranges_for_cpp):
1077
1078 2017-07-28  JF Bastien  <jfbastien@apple.com>
1079
1080         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
1081         https://bugs.webkit.org/show_bug.cgi?id=174930
1082
1083         Reviewed by Daniel Bates.
1084
1085         Teach prepare-ChangeLog about C++ auto arrow return, and while I'm
1086         here also teach it about const and volatile overloads. I didn't do
1087         reference and rvalue reference overloads because we don't really
1088         use them, and the current parser throws away those characters and
1089         it doesn't seem worth making it more complex.
1090
1091         * Scripts/prepare-ChangeLog:
1092         (get_function_line_ranges_for_cpp):
1093         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
1094         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
1095         (Foo::Arrow::arrow):
1096         (Foo::Arrow::otherArrow):
1097         (Foo::Arrow::otherArrow const):
1098         (Foo::Arrow::otherArrow volatile):
1099         (Foo::Arrow::otherArrow const volatile):
1100
1101 2017-07-28  Adrian Perez de Castro  <aperez@igalia.com>
1102
1103         [GTK] Building with ENABLE_VIDEO=OFF fails
1104         https://bugs.webkit.org/show_bug.cgi?id=174940
1105
1106         Reviewed by Alex Christensen.
1107
1108         When GStreamer usage is completely disabled at build time, CMake does not query pkg-config for the GStreamer.
1109         This adds missing USE(GSTREAMER) guards in order to make testing code buildable when GStreamer usage is disabled.
1110
1111         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1112         (methodCallCallback): Add missing USE(GSTREAMER) guard.
1113
1114 2017-07-28  Claudio Saavedra  <csaavedra@igalia.com>
1115
1116         [WPE] Implement EventSenderProxy in WTR
1117         https://bugs.webkit.org/show_bug.cgi?id=173419
1118
1119         Reviewed by Žan Doberšek.
1120
1121         Add the implementation of EventSenderProxy to the WTR. This
1122         allows us to extend the coverage of the test suite in WKWPE.
1123
1124         * WebKitTestRunner/EventSenderProxy.h:
1125         * WebKitTestRunner/PlatformWPE.cmake: Add dependency on
1126         libxkbcommon needed to deal with key events.
1127         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1128         (WTR::EventSenderProxy::EventSenderProxy):
1129         (WTR::senderButtonToWPEButton):
1130         (WTR::EventSenderProxy::mouseDown):
1131         (WTR::EventSenderProxy::mouseUp):
1132         (WTR::EventSenderProxy::mouseMoveTo):
1133         (WTR::EventSenderProxy::mouseScrollBy):
1134         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
1135         (WTR::EventSenderProxy::leapForward):
1136         (WTR::wkEventModifiersToWPE):
1137         (WTR::getXKBKeySymForKeyRef):
1138         (WTR::EventSenderProxy::keyDown):
1139         (WTR::EventSenderProxy::addTouchPoint):
1140         (WTR::EventSenderProxy::updateTouchPoint):
1141         (WTR::EventSenderProxy::setTouchModifier):
1142         (WTR::EventSenderProxy::setTouchPointRadius):
1143         (WTR::EventSenderProxy::getUpdatedTouchEvents):
1144         (WTR::EventSenderProxy::removeUpdatedTouchEvents):
1145         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1146         (WTR::EventSenderProxy::touchStart):
1147         (WTR::EventSenderProxy::touchMove):
1148         (WTR::EventSenderProxy::touchEnd):
1149         (WTR::EventSenderProxy::touchCancel):
1150         (WTR::EventSenderProxy::clearTouchPoints):
1151         (WTR::EventSenderProxy::releaseTouchPoint):
1152         (WTR::EventSenderProxy::cancelTouchPoint):
1153
1154 2017-07-27  Brady Eidson  <beidson@apple.com>
1155
1156         Part 2 of: Rename DatabaseProcess to StorageProcess.
1157         https://bugs.webkit.org/show_bug.cgi?id=174880
1158
1159         Reviewed by Andy Estes.
1160
1161         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
1162         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
1163         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
1164         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
1165         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
1166         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
1167         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
1168         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1169
1170 2017-07-26  Mark Lam  <mark.lam@apple.com>
1171
1172         Add ability to only run specific tests in run-javascriptcore-tests.
1173         https://bugs.webkit.org/show_bug.cgi?id=174884
1174
1175         Reviewed by Saam Barati.
1176
1177         For example, if we only want to run testapi, we can do so as follows:
1178             $ run-javascriptcore-tests --testapi
1179
1180         Previously, specifying --testapi effectively does nothing because we run all tests
1181         by default.  Only --no-testapi had the effect of disabling the test set.  This
1182         old behavior for --testapi is not very useful or meaningful.  We're now changing
1183         it to mean that we will only run that test.
1184
1185         With this change, we can also run more than one set of tests.  For example, if we
1186         only want to run testmasm and testair, we can do so as follows:
1187             $ run-javascriptcore-tests --testmasm --testair
1188
1189         By default, if no specific test option is specified, run-javascriptcore-tests will
1190         run all tests.
1191
1192         Note that the jsc stress tests (--jsc-stress) are a different set of tests than
1193         the mozilla tests (--mozilla-tests) even though both are run via the lower level
1194         run-jsc-stress-tests test harness.  Hence, if you only specify one of the tests,
1195         the other set will not run.  For example, the following only runs the mozilla tests:
1196             $ run-javascriptcore-tests --mozilla-tests
1197
1198         Note also that --jit-stress-tests is not for choosing a different set of tests.
1199         Instead, it is used for determining whether we run JIT'ed test configurations
1200         on the jsc stress tests and mozilla tests.  As a result, specifying
1201         --jit-stress-tests will not omit other tests.  For example, the following still
1202         runs all tests:
1203             $ run-javascriptcore-tests --jit-stress-tests
1204
1205         * Scripts/run-javascriptcore-tests:
1206         (defaultStringForTestState):
1207         (enableTestOrNot):
1208         (runJSCStressTests):
1209
1210 2017-07-26  Mark Lam  <mark.lam@apple.com>
1211
1212         Make run-javascriptcore-test run testair, testb3, and testmasm.
1213         https://bugs.webkit.org/show_bug.cgi?id=174837
1214         <rdar://problem/33522927>
1215
1216         Reviewed by Saam Barati and Filip Pizlo.
1217
1218         1. Refactors code for running testapi so that we can use it to run other tests.
1219         2. Added running of testmasm, testair, testb3.
1220
1221         Note: the existing testapi invocation code does not support remote invocation of
1222         the tests (e.g. on a ARM device).  Hence, the new additions of testmasm, testair,
1223         and testb3 also do not support remote invocation.  If we wish to add remote
1224         invocation support, we should do that in a separate patch.
1225
1226         * Scripts/run-javascriptcore-tests:
1227         (testPath):
1228         (runTest):
1229         (testapiPath): Deleted.
1230
1231 2017-07-26  Aakash Jain  <aakash_jain@apple.com>
1232
1233         Remove duplicate code from Buildbot.js in dashboard
1234         https://bugs.webkit.org/show_bug.cgi?id=174870
1235
1236         Reviewed by Daniel Bates.
1237
1238         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1239         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Remove duplicate code and reuse buildPageURLForIteration() to construct URL.
1240         (Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto.
1241         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js:
1242         (MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto for tests.
1243
1244 2017-07-26  Brady Eidson  <beidson@apple.com>
1245
1246         Add test to verify certain child processes are not launched as a side effect of enabling ResourceLoadStatistics.
1247         https://bugs.webkit.org/show_bug.cgi?id=174851
1248
1249         Reviewed by Chris Dumez.
1250
1251         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
1252         (TEST):
1253
1254 2017-07-26  Brian Burg  <bburg@apple.com>
1255
1256         Remove WEB_TIMING feature flag
1257         https://bugs.webkit.org/show_bug.cgi?id=174795
1258
1259         Reviewed by Alex Christensen.
1260
1261         * Scripts/webkitperl/FeatureList.pm:
1262         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1263
1264 2017-07-26  Chris Dumez  <cdumez@apple.com>
1265
1266         Pressing the Escape key should not be a valid user gesture to enter fullscreen
1267         https://bugs.webkit.org/show_bug.cgi?id=174864
1268         <rdar://problem/33009088>
1269
1270         Reviewed by Geoffrey Garen.
1271
1272         Add support for eventSender.keyDown('escape') in DRT to match the behavior of
1273         WKTR.
1274
1275         * DumpRenderTree/mac/EventSendingController.mm:
1276         (-[EventSendingController keyDown:withModifiers:withLocation:]):
1277
1278 2017-07-26  Romain Bellessort  <romain.bellessort@crf.canon.fr>
1279
1280         Unreviewed, added Romain Bellessort to contributors.json.
1281
1282         * Scripts/webkitpy/common/config/contributors.json:
1283
1284 2017-07-26  Zan Dobersek  <zdobersek@igalia.com>
1285
1286         [WPE] WebGL2 support
1287         https://bugs.webkit.org/show_bug.cgi?id=174249
1288
1289         Reviewed by Alex Christensen.
1290
1291         * Scripts/webkitperl/FeatureList.pm:
1292         Enable WebGL2 for WPE when building through build-webkit.
1293
1294 2017-07-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1295
1296         Unreviewed. Fix GTK distcheck.
1297
1298         * gtk/make-dist.py:
1299         (ensure_version_if_possible): Use the right pkg-config filename, it's webkit2gtk not webkitgtk.
1300
1301 2017-07-25  Brady Eidson  <beidson@apple.com>
1302
1303         ResourceLoadStatistics grandfathering happens much too often.
1304         <rdar://problem/32655834> and https://bugs.webkit.org/show_bug.cgi?id=174825
1305
1306         Reviewed by Chris Dumez.
1307
1308         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1309         * TestWebKitAPI/Tests/WebKit2Cocoa/EmptyGrandfatheredResourceLoadStatistics.plist: Added.
1310         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm: Added.
1311         (TEST):
1312
1313 2017-07-25  Matthew Stewart  <matthew_r_stewart@apple.com>
1314
1315         Fix autoinstaller failing on autoinstall_everything
1316         https://bugs.webkit.org/show_bug.cgi?id=174830
1317
1318         Reviewed by Joseph Pecoraro.
1319
1320         * Scripts/webkitpy/thirdparty/__init__.py:
1321         (AutoinstallImportHook.find_module):
1322         (AutoinstallImportHook.install_chromedriver):
1323         (AutoinstallImportHook.install_geckodriver):
1324         (AutoinstallImportHook._install_chromedriver): Deleted.
1325         (AutoinstallImportHook._install_geckodriver): Deleted.
1326
1327 2017-07-25  Jonathan Bedard  <jbedard@apple.com>
1328
1329         Replace --runtime with something for both ios-simulator and ios-device
1330         https://bugs.webkit.org/show_bug.cgi?id=173775
1331         <rdar://problem/32952164>
1332
1333         Reviewed by Aakash Jain.
1334
1335         Add --version flag for both iOS simulator and iOS device.
1336
1337         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1338         (parse_args): Add --version flag and move --no-install.
1339         * Scripts/webkitpy/port/factory.py:
1340         (platform_options): Move --no-intall to run_webkit_tests.py.
1341         * Scripts/webkitpy/port/ios.py:
1342         (IOSPort):
1343         (IOSPort._is_valid_ios_version): Check that the provided version string is legal.
1344         (IOSPort.get_option): If accessing the iOS version, check that it is a valid version string.
1345         * Scripts/webkitpy/port/ios_device.py:
1346         (IOSDevicePort.ios_version): Consult --version flag before checking connected
1347         devices for iOS version.
1348         * Scripts/webkitpy/port/ios_device_unittest.py:
1349         (IOSDeviceTest.make_port): Set --version option so that we can generate test
1350         expectation paths without devices connected.
1351         (IOSDeviceTest.test_additional_platform_directory): Deleted.
1352         (IOSDeviceTest.test_baseline_searchpath): Deleted.
1353         (IOSDeviceTest.test_expectations_ordering): Deleted.
1354         * Scripts/webkitpy/port/ios_simulator.py:
1355         (IOSSimulatorPort.simulator_runtime): If no runtime is specified, use the --version
1356         flag to specify a runtime.
1357         (IOSSimulatorPort.ios_version): First check the --version flag, then the --runtime
1358         flag and then use the default runtime.
1359
1360 2017-07-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1361
1362         [GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename
1363         https://bugs.webkit.org/show_bug.cgi?id=174815
1364
1365         Reviewed by Carlos Alberto Lopez Perez.
1366
1367         Only WebKitGTK specific tests are built, but not WebKit2, WTF nor WebCore ones. We are still checking
1368         ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to
1369         use WebKit dir, while the tests are still in WebKit2 directory. This patch also removes
1370         TestWebKitAPIInjectedBundle_PATH that is unused and now makes the configure to fail (it used to be a warning, I
1371         think), probably because of a newer CMake version.
1372
1373         * CMakeLists.txt:
1374         * TestWebKitAPI/CMakeLists.txt:
1375         * TestWebKitAPI/PlatformGTK.cmake:
1376
1377 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
1378
1379         Fix BenchmarkRunner to only import selenium when needed
1380         https://bugs.webkit.org/show_bug.cgi?id=174808
1381
1382         Reviewed by Stephanie Lewis.
1383
1384         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
1385         (LinuxChromeDriver.launch_driver):
1386         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
1387         (LinuxFirefoxDriver.launch_driver):
1388         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1389         (OSXChromeDriver.launch_driver):
1390         (OSXChromeCanaryDriver.launch_driver):
1391         (create_chrome_options):
1392         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1393         (OSXFirefoxDriver.launch_driver):
1394         (OSXFirefoxNightlyDriver.launch_driver):
1395         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1396         (OSXSafariDriver.launch_driver):
1397         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
1398         (WebDriverBenchmarkRunner._run_one_test):
1399
1400 2017-07-23  Darin Adler  <darin@apple.com>
1401
1402         More NeverDestroyed and related cleanup
1403         https://bugs.webkit.org/show_bug.cgi?id=174745
1404
1405         Reviewed by Alex Christensen.
1406
1407         * DumpRenderTree/JavaScriptThreading.cpp:
1408         (javaScriptThreadsMutex): Use NeverDestroyed instead of
1409         DEPRECATED_DEFINE_STATIC_LOCAL.
1410         (javaScriptThreads): Ditto.
1411
1412 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
1413
1414         Subclass Benchmark Runner script for WebDriver support
1415         https://bugs.webkit.org/show_bug.cgi?id=174390
1416
1417         Reviewed by Dewei Zhu, Stephanie Lewis.
1418
1419         Add WebServerBenchmarkRunner and WebDriverBenchmarkRunner subclasses.
1420
1421         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1422         (BenchmarkBuilder.__init__):
1423         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1424         (BenchmarkRunner.__init__):
1425         (BenchmarkRunner._find_plan_file):
1426         (BenchmarkRunner._run_one_test.and):
1427         (BenchmarkRunner.execute):
1428         (BenchmarkRunner._get_result): Deleted.
1429         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1430         (parse_args):
1431         (start):
1432         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py: Added.
1433         (WebDriverBenchmarkRunner):
1434         (WebDriverBenchmarkRunner._get_result):
1435         (WebDriverBenchmarkRunner._run_one_test):
1436         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py: Added.
1437         (WebServerBenchmarkRunner):
1438         (WebServerBenchmarkRunner.__init__):
1439         (WebServerBenchmarkRunner._get_result):
1440         (WebServerBenchmarkRunner._run_one_test):
1441
1442 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
1443
1444         Add BenchmarkRunner patches with WebDriver support for each testing plan
1445         https://bugs.webkit.org/show_bug.cgi?id=174443
1446
1447         Reviewed by Dewei Zhu, Stephanie Lewis.
1448
1449         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1450         (BenchmarkBuilder.__enter__):
1451         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ARES-6.patch:
1452         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ContentAnimation.patch:
1453         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Dromaeo.patch:
1454         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JSBench.patch:
1455         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JetStream.patch:
1456         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Kraken.patch:
1457         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/MotionMark.patch:
1458         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Octane.patch:
1459         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Speedometer.patch:
1460         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/SunSpider.patch:
1461         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
1462         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Animometer.patch:
1463         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ContentAnimation.patch:
1464         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Dromaeo.patch:
1465         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JSBench.patch:
1466         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JetStream.patch:
1467         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Kraken.patch:
1468         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
1469         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Octane.patch:
1470         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer.patch:
1471         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/SunSpider.patch:
1472         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
1473         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
1474         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan:
1475         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan:
1476         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan:
1477         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
1478         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan:
1479         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan:
1480         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
1481         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan:
1482         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
1483         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
1484
1485 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
1486
1487         Add functions to autoinstaller needed for Benchmark Runner script
1488         https://bugs.webkit.org/show_bug.cgi?id=174331
1489
1490         Reviewed by Dean Johnson, Dewei Zhu, Stephanie Lewis.
1491
1492         Adds autoinstaller functions to install selenium and webdriver binaries
1493         which will be used by the browser driver part of Benchmark Runner.
1494
1495         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1496         (BrowserDriver.restore_env):
1497         (BrowserDriver):
1498         (BrowserDriver.get_webdriver_binary_path):
1499         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
1500         (LinuxChromeDriver.launch_driver):
1501         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
1502         (LinuxFirefoxDriver.launch_driver):
1503         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1504         (OSXChromeDriver.launch_driver):
1505         (OSXChromeCanaryDriver.launch_driver):
1506         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1507         (OSXFirefoxDriver.launch_driver):
1508         (OSXFirefoxNightlyDriver.launch_driver):
1509         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1510         * Scripts/webkitpy/benchmark_runner/utils.py:
1511         (get_driver_binary_path):
1512         * Scripts/webkitpy/common/system/autoinstall.py:
1513         (AutoInstaller._unzip):
1514         * Scripts/webkitpy/thirdparty/__init__.py:
1515         (AutoinstallImportHook.find_module):
1516         (AutoinstallImportHook._install_selenium):
1517         (AutoinstallImportHook):
1518         (AutoinstallImportHook._install_chromedriver):
1519         (AutoinstallImportHook._install_geckodriver):
1520         (AutoinstallImportHook.get_latest_pypi_url):
1521         (AutoinstallImportHook.install_binary):
1522         (autoinstall_everything):
1523         (get_driver_filename):
1524         (get_os_info):
1525
1526 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
1527
1528         Add WebDriver support in browser driver part of BenchmarkRunner
1529         https://bugs.webkit.org/show_bug.cgi?id=174445
1530
1531         Reviewed by Stephanie Lewis.
1532
1533         Adds a launch_driver function to each BrowserDriver subclass. This
1534         function sets up the arguments for the webdriver and launches the
1535         webdriver specific to that browser.
1536
1537         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1538         (BrowserDriver.launch_webdriver):
1539         (BrowserDriver):
1540         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
1541         (LinuxBrowserDriver.launch_webdriver):
1542         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
1543         (LinuxChromeDriver.launch_url):
1544         (LinuxChromeDriver):
1545         (LinuxChromeDriver.launch_driver):
1546         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py:
1547         (EpiphanyBrowserDriver.launch_url):
1548         (EpiphanyBrowserDriver):
1549         (EpiphanyBrowserDriver.launch_driver):
1550         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
1551         (LinuxFirefoxDriver):
1552         (LinuxFirefoxDriver.launch_url):
1553         (LinuxFirefoxDriver.launch_driver):
1554         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
1555         (GTKMiniBrowserDriver.launch_url):
1556         (GTKMiniBrowserDriver):
1557         (GTKMiniBrowserDriver.launch_driver):
1558         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1559         (OSXBrowserDriver._launch_webdriver):
1560         (OSXBrowserDriver):
1561         (OSXBrowserDriver._screen_size):
1562         (OSXBrowserDriver._insert_url):
1563         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1564         (OSXChromeDriver):
1565         (OSXChromeDriver.launch_url):
1566         (OSXChromeDriver.launch_driver):
1567         (OSXChromeCanaryDriver):
1568         (OSXChromeCanaryDriver.launch_url):
1569         (OSXChromeCanaryDriver.launch_driver):
1570         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1571         (OSXFirefoxDriver):
1572         (OSXFirefoxDriver.launch_url):
1573         (OSXFirefoxDriver.launch_driver):
1574         (OSXFirefoxNightlyDriver):
1575         (OSXFirefoxNightlyDriver.launch_url):
1576         (OSXFirefoxNightlyDriver.launch_driver):
1577         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1578         (OSXSafariDriver.launch_driver):
1579
1580 2017-07-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1581
1582         [Mac WK2] Add an API test to cover r219765 (null dereference in [WKWebView dealloc])
1583         https://bugs.webkit.org/show_bug.cgi?id=174793
1584
1585         Reviewed by Tim Horton.
1586
1587         Adds a new unit test that invokes some asynchronous NSTextInputClient SPI methods as the web view is tearing
1588         down. Without r219765, this test will dereference null and crash.
1589
1590         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1591         * TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h: Added.
1592         * TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm:
1593         (TEST):
1594
1595 2017-07-24  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1596
1597         [Win] Implement Authentication dialog in MiniBrowser
1598         https://bugs.webkit.org/show_bug.cgi?id=174662
1599
1600         Reviewed by Alex Christensen.
1601
1602         * MiniBrowser/win/Common.cpp:
1603         (CustomUserAgent):
1604         (DisplayAuthDialog):
1605         (AuthDialogProc):
1606         * MiniBrowser/win/MiniBrowserLib.rc:
1607         * MiniBrowser/win/MiniBrowserLibResource.h:
1608         * MiniBrowser/win/ResourceLoadDelegate.cpp:
1609         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
1610
1611 2017-07-24  Jonathan Bedard  <jbedard@apple.com>
1612
1613         Handle case where line_numbers is None instead of an array of line numbers
1614         https://bugs.webkit.org/show_bug.cgi?id=174775
1615
1616         Reviewed by Aakash Jain.
1617
1618         Added files set line_numbers to None in process_file.
1619
1620         * Scripts/webkitpy/style/filereader.py:
1621         (TextFileReader.process_file): Handle case where line_number is set to None.
1622         * Scripts/webkitpy/style/main_unittest.py:
1623         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Test case of an added file.
1624
1625 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
1626
1627         [WPE] Add libepoxy to the Jhbuild moduleset
1628         https://bugs.webkit.org/show_bug.cgi?id=174711
1629
1630         Reviewed by Carlos Alberto Lopez Perez.
1631
1632         * wpe/jhbuild.modules: Add libepoxy 1.4.3 to WPE's Jhbuild moduleset.
1633
1634 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
1635
1636         [WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
1637         https://bugs.webkit.org/show_bug.cgi?id=174780
1638
1639         Reviewed by Carlos Garcia Campos.
1640
1641         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
1642         Manually define the EGL_CAST macro to the C++ version that uses static_cast<>
1643         in case the eglplatform.h header doesn't provide that macro. This replicates
1644         the work in WebCore's EpoxyEGL.h header, but we can't include that header here.
1645
1646 2017-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1647
1648         [iOS WK2] Remove _WKDraggableElementInfo and fold PositionInformationTests into WKRequestActivatedElementInfo
1649         https://bugs.webkit.org/show_bug.cgi?id=174758
1650
1651         Reviewed by Dan Bernstein.
1652
1653         Migrate position-information-related unit tests from the PositionInformationTests suite to
1654         WKRequestActivatedElementInfo as 2 new unit tests. See WebKit2 ChangeLog for more details.
1655
1656         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1657         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
1658         (TestWebKitAPI::checkElementTypeAndBoundingRect):
1659         (TestWebKitAPI::TEST):
1660         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm: Removed.
1661         * TestWebKitAPI/cocoa/TestWKWebView.h:
1662         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1663         (-[TestWKWebView activatedElementAtPosition:]):
1664
1665 2017-07-22  Chris Dumez  <cdumez@apple.com>
1666
1667         REGRESSION(r204565): WKObject is broken
1668         https://bugs.webkit.org/show_bug.cgi?id=174736
1669         <rdar://problem/33246169>
1670
1671         Reviewed by Dan Bernstein.
1672
1673         Add API test that used to crash.
1674
1675         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
1676         (TestWebKitAPI::TEST):
1677
1678 2017-07-22  Yusuke Suzuki  <utatane.tea@gmail.com>
1679
1680         [WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult
1681         https://bugs.webkit.org/show_bug.cgi?id=174705
1682
1683         Reviewed by Mark Lam.
1684
1685         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
1686         (TestWebKitAPI::testThreadGroup):
1687         (TestWebKitAPI::TEST):
1688
1689 2017-07-21  Jonathan Bedard  <jbedard@apple.com>
1690
1691         Fail gracefully when xcrun fails in IOSSimulatorPort constructor
1692         https://bugs.webkit.org/show_bug.cgi?id=174724
1693
1694         Reviewed by Aakash Jain.
1695
1696         * Scripts/webkitpy/port/ios_simulator.py:
1697         (IOSSimulatorPort.__init__): Ignore any errors when attempting to find a running
1698         simulator. Errors here should be treated the same as no simulators found.
1699
1700 2017-07-21  Yousuke Kimoto  <Yousuke.Kimoto@sony.com>
1701
1702         [CMake] Add an option to stop build after generating project files
1703         https://bugs.webkit.org/show_bug.cgi?id=174664
1704
1705         Reviewed by Konstantin Tokarev.
1706
1707         Add "--generate-project-only" to stop build after generating project files.
1708
1709         * Scripts/build-webkit: Add '--generate-project-only' option and a checker to stop build.
1710         * Scripts/webkitdirs.pm: Add a function to check '--generate-project-only' option and the same checker as the above
1711         (buildCMakeProjectOrExit): Add a cheker to stop build stop build after generating project files.
1712         (determineIsGenerateProjectOnly): Check if '--generate-project-only' option is specified
1713         (isGenerateProjectOnly): ditto
1714
1715 2017-07-21  Yusuke Suzuki  <utatane.tea@gmail.com>
1716
1717         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
1718         https://bugs.webkit.org/show_bug.cgi?id=174501
1719
1720         Reviewed by Darin Adler.
1721
1722         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1723         (TestWebKitAPI::TEST):
1724
1725 2017-07-20  David Quesada  <david_quesada@apple.com>
1726
1727         Add SPI to notify WKNavigationDelegate about client redirects
1728         https://bugs.webkit.org/show_bug.cgi?id=174680
1729         rdar://problem/33184886
1730
1731         Reviewed by Brady Eidson.
1732
1733         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1734         (-[DidPerformClientRedirectNavigationDelegate _webView:didPerformClientRedirectForNavigation:]):
1735         (TEST):
1736         Add API test for -[id<WKNavigationDelegatePrivate> _webView:didPerformClientRedirectForNavigation:].
1737
1738 2017-07-20  Brady Eidson  <beidson@apple.com>
1739
1740         Test WebKit2CustomProtocolsTest.ProcessPoolDestroyedDuringLoading added in r219664 fails on El Capitan.
1741         https://bugs.webkit.org/show_bug.cgi?id=174685
1742
1743         Reviewed by Andy Estes.
1744
1745         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1746         (TestWebKitAPI::TEST): Use a scoped AutodrainedPool instead of a RetainPtr<NSAutoreleasePool>.
1747
1748 2017-07-20  Brady Eidson  <beidson@apple.com>
1749
1750         Deprecate WebIconDatabase in WebKitLegacy/mac.
1751         https://bugs.webkit.org/show_bug.cgi?id=174607
1752
1753         Reviewed by Alex Christensen.
1754
1755         * DumpRenderTree/mac/TestRunnerMac.mm:
1756
1757 2017-07-20  Jonathan Bedard  <jbedard@apple.com>
1758
1759         lint-test-expectations should be run during style checking
1760         https://bugs.webkit.org/show_bug.cgi?id=173559
1761         <rdar://problem/32854941>
1762
1763         Reviewed by Aakash Jain.
1764
1765         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1766         (TestExpectationsModel._already_seen_better_match): Append returns 'None' when successful,
1767         prevents identifying errors on specific lines in a file.
1768         * Scripts/webkitpy/style/main_unittest.py:
1769         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Test for the
1770         case where a linter error is in the file modified, but the line modified is not related to
1771         the linter error.
1772
1773 2017-07-20  Brady Eidson  <beidson@apple.com>
1774
1775         Remove WebIconDatabase from WebKitLegacy/win.
1776         https://bugs.webkit.org/show_bug.cgi?id=174608
1777
1778         Reviewed by Alex Christensen.
1779
1780         * DumpRenderTree/win/DumpRenderTree.cpp:
1781         (main):
1782         * DumpRenderTree/win/TestRunnerWin.cpp:
1783         (TestRunner::setIconDatabaseEnabled):
1784
1785 2017-07-20  Zan Dobersek  <zdobersek@igalia.com>
1786
1787         [WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
1788         https://bugs.webkit.org/show_bug.cgi?id=174671
1789
1790         Reviewed by Carlos Garcia Campos.
1791
1792         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
1793         (HeadlessViewBackend::HeadlessViewBackend): Use the RunLoopDispatcher
1794         priority for this source in order to have it dispatched on the same
1795         priority as the other WebKit-controlled GSource objects.
1796
1797 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
1798
1799         lint-test-expectations should be run during style checking
1800         https://bugs.webkit.org/show_bug.cgi?id=173559
1801         <rdar://problem/32854941>
1802
1803         Reviewed by Daniel Bates.
1804
1805         Follow up fix addressing style and a few minor bugs.
1806
1807         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1808         (TestExpectationParser.__init__): Use lambda x: x instead of str
1809         (TestExpectationsModel.__init__): Make lambda x: x the default argument.
1810         (TestExpectationsModel._already_seen_better_match): Use a temporary variable to
1811         reduce the calls of _shorten_filename, fix minor bug in appending the current
1812         expectation's line number instead of the previous ones, clarify treatment of None
1813         in file-to-line-number mapping.
1814         (TestExpectations._report_warnings): Collapse call.
1815         * Scripts/webkitpy/style/checkers/test_expectations.py:
1816         (TestExpectationsChecker.lint_test_expectations):
1817         * Scripts/webkitpy/style/filereader.py: Re-write comment.
1818         (TextFileReader.process_file): Add comment explaining treatment of None in
1819         file-to-line-number mapping.
1820         (TextFileReader.delete_file): Collapse call.
1821
1822 2017-07-19  Chris Dumez  <cdumez@apple.com>
1823
1824         Unreviewed attempt to fix API test failure after r219663.
1825
1826         The test was hard-coding an exception string and the string has changed slightly
1827         in r219663.
1828
1829         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1830         (TEST):
1831
1832 2017-07-19  Megan Gardner  <megan_gardner@apple.com>
1833
1834         Don't write file URLs to iOS Pasteboard
1835         https://bugs.webkit.org/show_bug.cgi?id=174647
1836         <rdar://problem/33199730>
1837
1838         Reviewed by Wenson Hsieh.
1839
1840         Updating tests to reflect the lack of file URLs for images.
1841
1842         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1843         (checkTypeIdentifierAndIsNotOtherTypeIdentifier):
1844         (checkEstimatedSize):
1845         (TestWebKitAPI::TEST):
1846
1847 2017-07-19  Brady Eidson  <beidson@apple.com>
1848
1849         iBooks sometimes crashes when closing a book.
1850         <rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658
1851
1852         Reviewed by Oliver Hunt.
1853
1854         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1855         (-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
1856         (-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
1857         (-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
1858         (TestWebKitAPI::TEST):
1859
1860         Add a "spin the runloop X number of times" utility:
1861         * TestWebKitAPI/Utilities.h:
1862         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
1863         (TestWebKitAPI::Util::spinRunLoop):
1864
1865 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
1866
1867         lint-test-expectations should be run during style checking
1868         https://bugs.webkit.org/show_bug.cgi?id=173559
1869         <rdar://problem/32854941>
1870
1871         Reviewed by David Kilzer.
1872
1873         Running the test expectation linter requires reading both files and lines not in the
1874         patch because, for example, deletion of a test can cause a lint failure even though
1875         no test expectations where modified. This means that the linter will occasionally warn
1876         about lines which were not changed in a given patch but whose error is related to a
1877         change made in that patch.
1878
1879         * Scripts/webkitpy/common/system/filesystem_mock.py:
1880         (MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.
1881         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1882         (TestExpectationWarning): Added class to pass warnings as an object instead of a string.
1883         (TestExpectationWarning.__init__): Construct warning with file name, line number, line
1884         content, description of the error and the name of the associated test.
1885         (TestExpectationWarning.__str__): Convert to string so that existing printing code works.
1886         (TestExpectationParser.__init__): Pass shorten_filename function to
1887         TestExpectationsParser to add a deleted file to the related_files dictionary.
1888         (TestExpectationParser._check_test_exists): If the test does not exist, add the
1889         missing path to the related_files dictionary.
1890         (TestExpectationLine.__init__): Add related_files dictionary, which tracks
1891         files and line numbers related to this test expectation line. This will allow
1892         tracking linter errors in the style checker occurring across multiple files.
1893         (TestExpectationsModel._already_seen_better_match): Add redundant expectation
1894         lines to related_files dictionary.
1895         (TestExpectations.__init__): Pass self._shorten_filename to TestExpectationParser.
1896         (TestExpectations._report_warnings): Construct warning object instead of string
1897         when adding to warnings list.
1898         * Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to
1899         clean-up log.
1900         * Scripts/webkitpy/style/checker.py:
1901         (ProcessorBase.do_association_check): Add required function for processor classes.
1902         (StyleProcessor):
1903         (StyleProcessor.do_association_check): Run the TestExpectations linter when
1904         checking for errors between associated files.
1905         * Scripts/webkitpy/style/checkers/test_expectations.py:
1906         (TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
1907         (TestExpectationsChecker):
1908         (TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
1909         of modified files, the current working directory and the host, determine if the linter
1910         warning is associated with the changes.
1911         (TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
1912         style checker.
1913         * Scripts/webkitpy/style/filereader.py:
1914         (TextFileReader):
1915         (TextFileReader.__init__): Track modified files in dictionary instead of a counter.
1916         (TextFileReader.file_count): Use dictionary to determine the number of modified files.
1917         (TextFileReader.process_file): Track both the number of files changed and which lines
1918         in those files were changed.
1919         (TextFileReader.do_association_check): Run the processor's association check on all
1920         modified or deleted files processed by TextFileReader.
1921         (TextFileReader.delete_file): Track deleted files in _files dictionary.
1922         (TextFileReader.count_delete_only_file): Deleted.
1923         * Scripts/webkitpy/style/filereader_unittest.py:
1924         (TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
1925         (TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.
1926         * Scripts/webkitpy/style/main.py:
1927         (CheckWebKitStyle.main): When running the style checker on a specific list of files,
1928         explicitly run the association check on the file reader.
1929         * Scripts/webkitpy/style/main_unittest.py:
1930         (ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
1931         embedded in the style checker.
1932         (ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
1933         (ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
1934         construct the TextFileReader object with a StyleProcessor used to run style checks on
1935         specific files.
1936         (ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
1937         testing the test expectation linter inside the style checker. This host must contain a
1938         mock file system with the basic structure of test expectations.
1939         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
1940         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
1941         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
1942         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
1943         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):
1944         * Scripts/webkitpy/style/patchreader.py:
1945         (PatchReader.check): Specify which file was deleted, run the association check.
1946         * Scripts/webkitpy/style/patchreader_unittest.py:
1947         (PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
1948         (PatchReaderTest.MockTextFileReader.do_association_check): Added.
1949         (PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.
1950
1951 2017-07-19  Yusuke Suzuki  <utatane.tea@gmail.com>
1952
1953         [WTF] Implement WTF::ThreadGroup
1954         https://bugs.webkit.org/show_bug.cgi?id=174081
1955
1956         Reviewed by Mark Lam.
1957
1958         Add WTF::ThreadGroup tests.
1959
1960         * TestWebKitAPI/CMakeLists.txt:
1961         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1962         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
1963         (TestWebKitAPI::testThreadGroup):
1964         (TestWebKitAPI::TEST):
1965
1966 2017-07-18  Andy Estes  <aestes@apple.com>
1967
1968         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
1969         https://bugs.webkit.org/show_bug.cgi?id=174631
1970
1971         Reviewed by Tim Horton.
1972
1973         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1974         * MiniBrowser/Configurations/Base.xcconfig:
1975         * MobileMiniBrowser/Configurations/Base.xcconfig:
1976         * TestWebKitAPI/Configurations/Base.xcconfig:
1977         * WebKitTestRunner/Configurations/Base.xcconfig:
1978
1979 2017-07-18  Andy Estes  <aestes@apple.com>
1980
1981         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
1982         https://bugs.webkit.org/show_bug.cgi?id=174631
1983
1984         Reviewed by Sam Weinig.
1985
1986         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1987         * MiniBrowser/Configurations/Base.xcconfig:
1988         * MobileMiniBrowser/Configurations/Base.xcconfig:
1989         * TestWebKitAPI/Configurations/Base.xcconfig:
1990         * WebKitTestRunner/Configurations/Base.xcconfig:
1991
1992 2017-07-18  Daniel Bates  <dabates@apple.com>
1993
1994         lldb: Add type summary for StringView
1995         https://bugs.webkit.org/show_bug.cgi?id=174637
1996
1997         Reviewed by Sam Weinig.
1998
1999         For debugging convenience, adds a pretty-print type summary for StringView. Evaluating a
2000         StringView object will print output that has the form:
2001
2002             (WTF::StringView) $4 = { length = 2, contents = 'li' } {
2003               m_characters = 0x000000011b57abb5 "eeeeeefjh0n"
2004               m_length = 2
2005               m_is8Bit = true
2006               m_underlyingString = 0x0000614000000a90
2007             }
2008
2009         * lldb/lldb_webkit.py:
2010         (__lldb_init_module): Use WTFStringView_SummaryProvider to format StringView types.
2011         (WTFStringView_SummaryProvider):
2012         (WTFStringViewProvider):
2013         (WTFStringViewProvider.__init__):
2014         (WTFStringViewProvider.is_8bit): Access field StringView.m_is8Bit.
2015         (WTFStringViewProvider.get_length): Access field StringView.m_length.
2016         (WTFStringViewProvider.get_characters): Access field StringView.m_characters.
2017         (WTFStringViewProvider.to_string): Returns the string represented by the StringView.
2018
2019 2017-07-18  Andy Estes  <aestes@apple.com>
2020
2021         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
2022         https://bugs.webkit.org/show_bug.cgi?id=174631
2023
2024         Reviewed by Dan Bernstein.
2025
2026         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2027         * MiniBrowser/Configurations/Base.xcconfig:
2028         * MobileMiniBrowser/Configurations/Base.xcconfig:
2029         * TestWebKitAPI/Configurations/Base.xcconfig:
2030         * WebKitTestRunner/Configurations/Base.xcconfig:
2031
2032 2017-07-18  Devin Rousso  <drousso@apple.com>
2033
2034         Web Inspector: Add memoryCost to Inspector Protocol objects
2035         https://bugs.webkit.org/show_bug.cgi?id=174478
2036
2037         Reviewed by Joseph Pecoraro.
2038
2039         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2040         * TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp: Added.
2041         (TestWebKitAPI::TEST(InspectorValue, MemoryCostNull)):
2042         (TestWebKitAPI::TEST(InspectorValue, MemoryCostBoolean)):
2043         (TestWebKitAPI::TEST(InspectorValue, MemoryCostDouble)):
2044         (TestWebKitAPI::TEST(InspectorValue, MemoryCostInteger)):
2045         (TestWebKitAPI::TEST(InspectorValue, MemoryCostString)):
2046         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringEmpty)):
2047         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringNull)):
2048         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringGrowing)):
2049         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringUnicode)):
2050         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObject)):
2051         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectEmpty)):
2052         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectGrowing)):
2053         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArray)):
2054         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayEmpty)):
2055         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayGrowing)):
2056
2057 2017-07-18  Andy Estes  <aestes@apple.com>
2058
2059         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
2060         https://bugs.webkit.org/show_bug.cgi?id=174631
2061
2062         Reviewed by Darin Adler.
2063
2064         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2065         * MiniBrowser/Configurations/Base.xcconfig:
2066         * MobileMiniBrowser/Configurations/Base.xcconfig:
2067         * TestWebKitAPI/Configurations/Base.xcconfig:
2068         * WebKitTestRunner/Configurations/Base.xcconfig:
2069
2070 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2071
2072         Unreviewed, fix the iOS build.
2073
2074         I missed a spot when renaming -synchronouslyLoadHTML: to -synchronouslyLoadHTMLString:.
2075
2076         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2077         (TestWebKitAPI::TEST):
2078
2079 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2080
2081         [iOS DnD] Web process uses too much memory when beginning a drag on a very large image
2082         https://bugs.webkit.org/show_bug.cgi?id=174585
2083         <rdar://problem/33302541>
2084
2085         Reviewed by Tim Horton.
2086
2087         Adds a new test verifying that we don't try to allocate any image buffer equal to the true size of the image
2088         being dragged when initiating a drag.
2089
2090         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2091         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Added.
2092         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2093         (TestWebKitAPI::TEST):
2094         * TestWebKitAPI/cocoa/TestWKWebView.h:
2095
2096         Add a new -synchronouslyLoadHTMLString: helper that works like -synchronouslyLoadTestPage:, but takes markup.
2097
2098         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2099         (-[TestWKWebView synchronouslyLoadHTMLString:]):
2100
2101 2017-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2102
2103         [CMake] Macros in WebKitMacros.cmake should be prefixed with WEBKIT_ namespace
2104         https://bugs.webkit.org/show_bug.cgi?id=174547
2105
2106         Reviewed by Alex Christensen.
2107
2108         * DumpRenderTree/PlatformWin.cmake:
2109         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2110
2111 2017-07-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2112
2113         Update style checker to deal with "final"
2114         https://bugs.webkit.org/show_bug.cgi?id=174528
2115
2116         Reviewed by Alex Christensen.
2117         
2118         check-webkit-style shouldn't complain about an open brace to start a
2119         line after a function definition with "final" or "const final".
2120
2121         * Scripts/webkitpy/style/checkers/cpp.py:
2122         (check_braces):
2123         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2124         (CppStyleTest.test_brace_at_begin_of_line):
2125
2126 2017-07-17  Alex Christensen  <achristensen@webkit.org>
2127
2128         Modernize content extension code
2129         https://bugs.webkit.org/show_bug.cgi?id=174588
2130
2131         Reviewed by Sam Weinig.
2132
2133         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2134         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
2135         (TestWebKitAPI::testRequest):
2136         (TestWebKitAPI::makeBackend):
2137         (TestWebKitAPI::TEST_F):
2138
2139 2017-07-17  Brady Eidson  <beidson@apple.com>
2140
2141         WKHTTPCookieStore observing only works on the default cookie store.
2142         <rdar://problem/33330724> and https://bugs.webkit.org/show_bug.cgi?id=174580
2143
2144         Reviewed by Sam Weinig.
2145
2146         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2147         (runTestWithWebsiteDataStore): Refactor the cookie observing test out so it can be
2148           called for the default store, a non-persistent store, and a custom store.
2149         (TEST):
2150
2151 2017-07-16  Sam Weinig  <sam@webkit.org>
2152
2153         [Scripts] Fix missing variable warnings from svn-create-patch when there are untracked files
2154         https://bugs.webkit.org/show_bug.cgi?id=174575
2155
2156         Reviewed by Brady Eidson.
2157
2158         * Scripts/svn-create-patch:
2159         (findModificationType):
2160         Add support for more status codes. C -> conflicted, ? -> untracked, ! -> missing. Give a
2161         default value of "unknown".
2162
2163         (generateFileList):
2164         Handle all the new modification types. Abort on conflicted, missing, and unknown. Log
2165         for untracked, which matches our old behavior.
2166
2167 2017-07-17  Charlie Turner  <cturner@igalia.com>
2168
2169         Add some missing build dependencies on Fedora
2170         https://bugs.webkit.org/show_bug.cgi?id=174578
2171
2172         Unreviewed dependency update.
2173
2174         * gtk/install-dependencies:
2175
2176 2017-07-16  Brady Eidson  <beidson@apple.com>
2177
2178         Crash when a WKHTTPCookieStore outlives its owning WKWebsiteDataStore.
2179         <rdar://problem/33341730> and https://bugs.webkit.org/show_bug.cgi?id=174574
2180
2181         Reviewed by Tim Horton.
2182
2183         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2184         (-[CookieNavigationDelegate webView:didFinishNavigation:]):
2185         (TEST):
2186
2187 2017-07-16  Bernhard M. Wiedemann  <bwiedemann@suse.de>
2188
2189         [GTK] Sort inspector GResource manifest to ensure reproducible builds
2190         https://bugs.webkit.org/show_bug.cgi?id=174540
2191
2192         Reviewed by Michael Catanzaro.
2193
2194         * gtk/generate-inspector-gresource-manifest.py:
2195         (get_filenames): sort list of input files
2196
2197 2017-07-15  Brady Eidson  <beidson@apple.com>
2198
2199         Make sure all CFHTTPCookieStorageRefs we create are scheduled.
2200         <rdar://problem/33221110> and https://bugs.webkit.org/show_bug.cgi?id=174513
2201
2202         Reviewed by Tim Horton.
2203
2204         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2205         (TEST): Make this test more reliable by clearing everything beforehand.
2206
2207 2017-07-15  David Kilzer  <ddkilzer@apple.com>
2208
2209         Make it possible to extend check-webkit-style with Apple-internal checkers
2210         <https://webkit.org/b/174464>
2211         <rdar://problem/25564402>
2212
2213         Reviewed by Darin Adler.
2214
2215         * Scripts/webkitpy/style/checker.py: Import apple_additions.
2216         (_all_categories): Add categories from apple_additions() if it
2217         exists.
2218         (CheckerDispatcher._create_checker): Create python checker
2219         from apple_additions() if it exists.
2220
2221 2017-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2222
2223         [iOS WK2] Presenting an action sheet on an image map prevents selection UI from updating
2224         https://bugs.webkit.org/show_bug.cgi?id=174539
2225         <rdar://problem/33307395>
2226
2227         Reviewed by Darin Adler.
2228
2229         Adds a new unit test suite to cover action sheet popover presentation.
2230
2231         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2232         * TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Added.
2233         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm: Added.
2234         (-[ActionSheetObserver waitForActionSheetAfterBlock:]):
2235
2236         Runs the given block and waits until the UI process has indicated that it will present an action sheet.
2237
2238         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
2239         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
2240
2241         Helper class to alter the behavior of [[UIDevice currentDevice] userInterfaceIdiom] for testing.
2242
2243         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
2244         (TestWebKitAPI::TEST):
2245
2246 2017-07-15  Sam Weinig  <sam@webkit.org>
2247
2248         [Scripts] Make svn-create-patch work better when called in sub directories
2249         https://bugs.webkit.org/show_bug.cgi?id=174551
2250
2251         Reviewed by Darin Adler.
2252
2253         - Fixes manufacturePatchForAdditionWithHistory to use the correct path
2254           by ensuring that the prefix is applied as is done in generateDiff.
2255         - Silence output of explanatory lines from svn stat (" > move to ...")
2256           that show up in STDERR when running svn-create-patch.
2257         - Add verbose logging that I found useful while debugging this issue.
2258
2259         * Scripts/svn-create-patch:
2260         (findBaseUrl):
2261         (findMimeType):
2262         (findSourceFileAndRevision):
2263         (generateDiff):
2264         (generateFileList):
2265         (manufacturePatchForAdditionWithHistory):
2266
2267 2017-07-15  Jonathan Bedard  <jbedard@apple.com>
2268
2269         Unreviewed build fix after r219537.
2270
2271         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2272
2273 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
2274
2275         Add iOS 11 SPI
2276         https://bugs.webkit.org/show_bug.cgi?id=174430
2277         <rdar://problem/33269288>
2278
2279         Reviewed by Tim Horton.
2280
2281         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Define drag-and-drop API required for testing.
2282         * TestWebKitAPI/ios/DataInteractionSimulator.h: Ditto.
2283         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Ditto.
2284
2285 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
2286
2287         Failing to install on iPad simulators
2288         https://bugs.webkit.org/show_bug.cgi?id=174532
2289         <rdar://problem/33328347>
2290
2291         Reviewed by Stephanie Lewis.
2292
2293         * Scripts/webkitpy/xcode/simulated_device.py:
2294         (SimulatedDevice.install_app): Place install command in retry try-except block.
2295
2296 2017-07-14  Jeff Miller  <jeffm@apple.com>
2297
2298         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
2299         https://bugs.webkit.org/show_bug.cgi?id=174524
2300
2301         Reviewed by Sam Weinig.
2302
2303         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
2304         (TEST):
2305         Renamed TestParameter to TestParameter1.
2306         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
2307
2308         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
2309         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2310         Observe changes for two bundle parameters.
2311
2312         (-[BundleParametersPlugIn dealloc]):
2313         Remove observers for two bundle parameters.
2314
2315 2017-07-14  Commit Queue  <commit-queue@webkit.org>
2316
2317         Unreviewed, rolling out r219510.
2318         https://bugs.webkit.org/show_bug.cgi?id=174525
2319
2320         Need to revert length() == 0 check for null string (Requested
2321         by yusukesuzuki on #webkit).
2322
2323         Reverted changeset:
2324
2325         "[WTF] Newly added AtomicStringImpl should use BufferInternal
2326         static string if StringImpl is static"
2327         https://bugs.webkit.org/show_bug.cgi?id=174501
2328         http://trac.webkit.org/changeset/219510
2329
2330 2017-07-14  Jer Noble  <jer.noble@apple.com>
2331
2332         [MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
2333         https://bugs.webkit.org/show_bug.cgi?id=174514
2334
2335         Reviewed by Sam Weinig.
2336
2337         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
2338         (TestWebKitAPI::TEST_F):
2339
2340 2017-07-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2341
2342         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
2343         https://bugs.webkit.org/show_bug.cgi?id=174501
2344
2345         Reviewed by Darin Adler.
2346
2347         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2348         (TestWebKitAPI::TEST):
2349
2350 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
2351
2352         Bring mac expectations in-line with other platforms
2353         https://bugs.webkit.org/show_bug.cgi?id=174472
2354         <rdar://problem/33297388>
2355
2356         Reviewed by David Kilzer.
2357
2358         The override order for Mac test expectations does not conform to the pattern used by iOS,
2359         GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
2360
2361             platform/mac-wk2
2362             platform/wk2
2363             platform/mac-elcapitan
2364             platform/mac-sierra
2365             generic
2366
2367         After this change, El Capitan's baseline search path looks like this:
2368
2369             platform/mac-sierra-wk2
2370             platform/mac-sierra
2371             platform/mac-wk2
2372             platform/wk2
2373             generic
2374
2375         * Scripts/webkitpy/port/mac.py:
2376         (MacPort.__init__): If a specific version is specified in the port name, use that
2377         as the os version.
2378         (MacPort.default_baseline_search_path): Expectation search paths should work the
2379         same way they do on other ports. Port + version overrides port, port overrides generic
2380         and wk1/wk2 should override expectations for the two combined.
2381         * Scripts/webkitpy/port/mac_unittest.py:
2382         (MacTest.test_tests_for_other_platforms): Deleted.
2383         (MacTest._assert_search_path): Deleted.
2384         (MacTest.test_baseline_search_path): Deleted.
2385         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2386         (TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
2387         (test_rebaseline_test_and_print_scm_changes): Ditto.
2388         (test_rebaseline_and_copy_test): Ditto.
2389         (test_rebaseline_and_copy_test_no_existing_result): Ditto.
2390         (test_rebaseline_and_copy_test_with_lion_result): Ditto.
2391         (test_rebaseline_and_copy_no_overwrite_test): Ditto.
2392
2393 2017-07-13  Michael Catanzaro  <mcatanzaro@igalia.com>
2394
2395         Fix style checker unit test
2396
2397         Unreviewed WebKit2 => WebKit fixup.
2398
2399         * Scripts/webkitpy/style/checker_unittest.py:
2400         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
2401
2402 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
2403
2404         Use the old WebKit/WebKit2 targets for CMake builds. (v2)
2405
2406         Unreviewed build fix.
2407
2408         r219492 missed one hunk from its partial revert of r219489.
2409         This patch reverts that hunk.
2410
2411         * TestWebKitAPI/CMakeLists.txt:
2412
2413 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
2414
2415         Use the old WebKit/WebKit2 targets for CMake builds.
2416
2417         Unreviewed build fix.
2418
2419         We can update the target names to match the Framework names in a future patch.
2420         This is a partial revert of r219489.
2421
2422         * TestWebKitAPI/CMakeLists.txt:
2423         WebKitLegacy => WebKit
2424         WebKit => WebKit2
2425
2426 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
2427
2428         Fix TestWebKit API.
2429         https://bugs.webkit.org/show_bug.cgi?id=174164
2430         rdar://problem/33137595
2431
2432         Reviewed by Dan Bernstein.
2433
2434         * TestWebKitAPI/CMakeLists.txt:
2435         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2436         * TestWebKitAPI/PlatformGTK.cmake:
2437
2438 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
2439
2440         Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
2441         https://bugs.webkit.org/show_bug.cgi?id=174164
2442         rdar://problem/33137595
2443
2444         Reviewed by Dan Bernstein.
2445
2446         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2447         (ShouldBuildTest):
2448         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2449         * Scripts/build-webkit:
2450         * Scripts/do-file-rename:
2451         * Scripts/do-webcore-rename:
2452         * Scripts/update-webkit-localizable-strings:
2453         * Scripts/webkitpy/common/config/watchlist:
2454         * Scripts/webkitpy/style/checker.py:
2455         * Scripts/webkitpy/style/checkers/featuredefines.py:
2456         * gtk/make-dist.py:
2457         (ensure_version_if_possible):
2458         * gtk/manifest.txt.in:
2459
2460 2017-07-05  Matthew Hanson  <matthew_hanson@apple.com>
2461
2462         Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
2463         https://bugs.webkit.org/show_bug.cgi?id=174162
2464         rdar://problem/33137594
2465
2466         Reviewed by Dan Bernstein.
2467
2468         Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource tooling.
2469
2470         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2471         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
2472         * EWSTools/configure-clang-linux.sh:
2473         * Scripts/build-webkit:
2474         * Scripts/do-file-rename:
2475         * Scripts/do-webcore-rename:
2476         * Scripts/update-webkit-localizable-strings:
2477         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2478         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
2479         * Scripts/webkitpy/style/checkers/featuredefines.py:
2480         * gtk/manifest.txt.in:
2481
2482 2017-07-13  Jonathan Bedard  <jbedard@apple.com>
2483
2484         Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
2485         https://bugs.webkit.org/show_bug.cgi?id=174438
2486         <rdar://problem/33277112>
2487
2488         Reviewed by Aakash Jain.
2489
2490         Given a patch, this will convert the changes from the path to the new directory structure.
2491
2492         * Scripts/rebase-patch-after-webkit-move: Added.
2493         (append_source): Append 'Source' to the provided path.
2494         (is_editable_line): Return true if a line the script expects to modify.
2495         (needs_rebase): Return if a line needs to be rebased based on it's content.
2496         (rebase_line): Rebase the provided line.
2497         (rebase): Rebase a patch given the lines of that patch and a file to output the rebased patch to.
2498         (parse_arguments): Parse the command line arguments and return the patches to be rebased, if they
2499         were provided.
2500
2501 2017-07-12  Nan Wang  <n_wang@apple.com>
2502
2503         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
2504         https://bugs.webkit.org/show_bug.cgi?id=174393
2505         <rdar://problem/33248006>
2506
2507         Reviewed by Chris Fleizach.
2508
2509         * DumpRenderTree/AccessibilityUIElement.cpp:
2510         (textMarkerRangeMatchesTextNearMarkersCallback):
2511         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2512         (AccessibilityUIElement::getJSClass):
2513         * DumpRenderTree/AccessibilityUIElement.h:
2514         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2515         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2516         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2517         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2518         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2519         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2520         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2521         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2522
2523 2017-07-12  Matt Lewis  <jlewis3@apple.com>
2524
2525         Unreviewed, rolling out r219409.
2526
2527         The revision caused the Windows builds to fail.
2528
2529         Reverted changeset:
2530
2531         "AX: [iOS] Implement a way to retrieve a text marker range
2532         with desired text that is closest to a position"
2533         https://bugs.webkit.org/show_bug.cgi?id=174393
2534         http://trac.webkit.org/changeset/219409
2535
2536 2017-07-12  Nan Wang  <n_wang@apple.com>
2537
2538         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
2539         https://bugs.webkit.org/show_bug.cgi?id=174393
2540         <rdar://problem/33248006>
2541
2542         Reviewed by Chris Fleizach.
2543
2544         * DumpRenderTree/AccessibilityUIElement.cpp:
2545         (textMarkerRangeMatchesTextNearMarkersCallback):
2546         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2547         (AccessibilityUIElement::getJSClass):
2548         * DumpRenderTree/AccessibilityUIElement.h:
2549         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2550         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2551         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2552         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2553         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2554         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2555         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2556         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2557
2558 2017-07-12  Emilio Cobos Álvarez  <ecobos@igalia.com>
2559
2560         Make prepare-ChangeLog -g <commit> generate a more standard ChangeLog entry.
2561         https://bugs.webkit.org/show_bug.cgi?id=174197
2562
2563         Reviewed by Darin Adler.
2564
2565         This bit me the first time I tried to submit a patch to WebKit, and still I have
2566         to manually edit the ChangeLog every time I use the script.
2567
2568         This generates a more convenient and standard ChangeLog entry.
2569
2570         * Scripts/prepare-ChangeLog:
2571         (generateNewChangeLogs):
2572
2573 2017-07-12  Matt Lewis  <jlewis3@apple.com>
2574
2575         Unreviewed, rolling out r219401.
2576
2577         This revision rolled out the previous patch, but after talking
2578         with reviewer, a rebaseline is what was needed.Rolling back in
2579         before rebaseline.
2580
2581         Reverted changeset:
2582
2583         "Unreviewed, rolling out r219379."
2584         https://bugs.webkit.org/show_bug.cgi?id=174400
2585         http://trac.webkit.org/changeset/219401
2586
2587 2017-07-12  Matt Lewis  <jlewis3@apple.com>
2588
2589         Unreviewed, rolling out r219379.
2590
2591         This revision caused a consistent failure in the test
2592         fast/dom/Window/property-access-on-cached-window-after-frame-
2593         removed.html.
2594
2595         Reverted changeset:
2596
2597         "Remove NAVIGATOR_HWCONCURRENCY"
2598         https://bugs.webkit.org/show_bug.cgi?id=174400
2599         http://trac.webkit.org/changeset/219379
2600
2601 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
2602
2603         [WPE] Use libepoxy
2604         https://bugs.webkit.org/show_bug.cgi?id=172104
2605
2606         Reviewed by Michael Catanzaro.
2607
2608         * WebKitTestRunner/wpe/HeadlessViewBackend.h:
2609         Include the <epoxy/egl.h> header, dropping the EGL and GLES2 inclusions.
2610
2611 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
2612
2613         [GTK][WPE] Align Jhbuild patches for GStreamer packages
2614         https://bugs.webkit.org/show_bug.cgi?id=174363
2615
2616         Reviewed by Michael Catanzaro.
2617
2618         Align the patches we apply over Jhbuild-managed GStreamer dependency packages
2619         between the GTK+ and WPE port. There's no reason for the two ports to apply
2620         different patches over same versions of GStreamer releases.
2621
2622         This aligns the two ports on this specific issue. Next we'll look into
2623         creating a single GStreamer-specific Jhbuild moduleset that will allow us
2624         to keep these patches in a single place, avoiding duplicate files.
2625
2626         * gtk/jhbuild.modules:
2627         * gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
2628         * gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch.
2629         * gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
2630         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Removed.
2631
2632 2017-07-11  Dean Jackson  <dino@apple.com>
2633
2634         Remove NAVIGATOR_HWCONCURRENCY
2635         https://bugs.webkit.org/show_bug.cgi?id=174400
2636
2637         Reviewed by Sam Weinig.
2638
2639         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2640
2641 2017-07-11  Ansh Shukla  <ansh_shukla@apple.com>
2642
2643         WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration properties
2644         https://bugs.webkit.org/show_bug.cgi?id=174239
2645
2646         Reviewed by Brady Eidson.
2647
2648         Create windows with specific features set and make sure those are properly reflected in the
2649         WKWindowFeatures object.
2650
2651         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
2652         (resetToConsistentState):
2653         (-[CheckWindowFeaturesUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2654         (TEST):
2655
2656 2017-07-11  Jonathan Bedard  <jbedard@apple.com>
2657
2658         Do not duplicate files when deleting directories with svn 1.9
2659         https://bugs.webkit.org/show_bug.cgi?id=174339
2660         <rdar://problem/33226781>
2661
2662         Reviewed by David Kilzer.
2663
2664         * Scripts/svn-create-patch:
2665         (diffOptionsForFile): No longer pass -N option, since this does not work in SVN 1.9.4.
2666         (generateFileList): Determine which files are deleted because they are part of a
2667         directory being deleted.
2668
2669 2017-07-11  Dean Jackson  <dino@apple.com>
2670
2671         Rolling out r219372.
2672
2673         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2674
2675 2017-07-11  Dean Jackson  <dino@apple.com>
2676
2677         Remove NAVIGATOR_HWCONCURRENCY
2678         https://bugs.webkit.org/show_bug.cgi?id=174400
2679
2680         Reviewed by Sam Weinig.
2681
2682         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2683
2684 2017-07-11  Lucas Forschler  <lforschler@apple.com>
2685
2686         Teach build workers to fetch archives from S3.
2687         https://bugs.webkit.org/show_bug.cgi?id=174384
2688
2689         Reviewed by Aakash Jain.
2690
2691         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2692         (DownloadBuiltProduct):
2693
2694 2017-07-11  Lucas Forschler  <lforschler@apple.com>
2695
2696         Configure buildbot to transfer all archives to S3.
2697         Previously this was Mac only, but it's time to expand!
2698         https://bugs.webkit.org/show_bug.cgi?id=174378
2699         
2700         Reviewed by Aakash Jain.
2701
2702         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2703         (BuildFactory.__init__):
2704
2705 2017-07-11  Zan Dobersek  <zdobersek@igalia.com>
2706
2707         [WPE] Bump GStreamer packages in jhbuild.modules to 1.10.5
2708         https://bugs.webkit.org/show_bug.cgi?id=174350
2709
2710         Reviewed by Xabier Rodriguez-Calvar.
2711
2712         Bump the various GStreamer dependencies listed in WPE's Jhbuild modules file
2713         to the 1.10.5 version. One gstreamer patch is added. The two gst-plugins-bad
2714         patches are removed. The patches for gst-plugins-good are updated, removing
2715         the stale ones and adding the additional changes to qtdemux, souphttpsrc and
2716         rtpbin elements that will help with the EMEv3 development.
2717
2718         * wpe/jhbuild.modules:
2719         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
2720         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
2721         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added.
2722         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
2723         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Added.
2724         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
2725         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
2726         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
2727         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
2728
2729 2017-07-10  John Wilander  <wilander@apple.com>
2730
2731         Resource Load Statistics: Prune statistics in orders of importance
2732         https://bugs.webkit.org/show_bug.cgi?id=174215
2733         <rdar://problem/33164403>
2734
2735         Reviewed by Chris Dumez.
2736
2737         Nest infrastructure. Adds these functions:
2738         1. testRunner.setStatisticsLastSeen()
2739         2. setStatisticsMaxStatisticsEntries()
2740         3. setStatisticsPruneEntriesDownTo()
2741
2742         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2743         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2744         (WTR::TestRunner::setStatisticsLastSeen):
2745         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
2746         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
2747         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2748         * WebKitTestRunner/TestController.cpp:
2749         (WTR::TestController::setStatisticsLastSeen):
2750         (WTR::TestController::setMaxStatisticsEntries):
2751         (WTR::TestController::setPruneEntriesDownTo):
2752         * WebKitTestRunner/TestController.h:
2753         * WebKitTestRunner/TestInvocation.cpp:
2754         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2755         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2756         (WTR::TestController::setStatisticsLastSeen):
2757         (WTR::TestController::setStatisticsMaxStatisticsEntries):
2758         (WTR::TestController::setStatisticsPruneEntriesDownTo):
2759
2760 2017-07-03  Brian Burg  <bburg@apple.com>
2761
2762         Web Replay: remove some unused code
2763         https://bugs.webkit.org/show_bug.cgi?id=173903
2764
2765         Rubber-stamped by Joseph Pecoraro.
2766
2767         * Scripts/run-input-generator-tests: Removed.
2768         * Scripts/webkitpy/replay/__init__.py: Removed.
2769         * Scripts/webkitpy/replay/main.py: Removed.
2770
2771 2017-07-10  Zan Dobersek  <zdobersek@igalia.com>
2772
2773         [WPE] Fix layout test baseline and TestExpectations hierarchy
2774         https://bugs.webkit.org/show_bug.cgi?id=174092
2775
2776         Reviewed by Michael Catanzaro.
2777
2778         Like for the GTK+ port, override the default_baseline_search_path() and
2779         _port_specific_expectations_files() methods in the webkitpy.port.WPEPort class.
2780         Both methods operate on a short list of search paths that defaults to 'wpe' and
2781         'wk2', along with any other user-specified platform directory.
2782
2783         The test_expectations_file_position() method is overridden for testing purposes,
2784         and relevant unit tests are added.
2785
2786         * Scripts/webkitpy/port/wpe.py:
2787         (WPEPort._search_paths):
2788         (WPEPort):
2789         (WPEPort.default_baseline_search_path):
2790         (WPEPort._port_specific_expectations_files):
2791         (WPEPort.test_expectations_file_position):
2792         * Scripts/webkitpy/port/wpe_unittest.py:
2793         (WPEPortTest.test_default_baseline_search_path):
2794         (WPEPortTest):
2795         (WPEPortTest.test_port_specific_expectations_files):
2796
2797 2017-07-10  Chris Dumez  <cdumez@apple.com>
2798
2799         Further WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore clean up
2800         https://bugs.webkit.org/show_bug.cgi?id=174301
2801
2802         Reviewed by Brent Fulgham.
2803
2804         Rename some of the testRunner API for clarity and to better match what it calls
2805         internally.
2806
2807         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2808         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2809         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
2810         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
2811         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2812         * WebKitTestRunner/TestController.cpp:
2813         (WTR::TestController::statisticsUpdateCookiePartitioning):
2814         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
2815         * WebKitTestRunner/TestController.h:
2816         * WebKitTestRunner/TestInvocation.cpp:
2817         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2818         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2819         (WTR::TestController::statisticsUpdateCookiePartitioning):
2820         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
2821
2822 2017-07-10  Charlie Turner  <cturner@igalia.com>
2823
2824         [GStreamer] Live twitch.tv videos do not play
2825         https://bugs.webkit.org/show_bug.cgi?id=174222
2826
2827         Reviewed by Michael Catanzaro.
2828
2829         Upgrade GStreamer to 1.10.5. It contains a change to typefind that
2830         fixes videos not playing on twitch.tv.
2831
2832         * gtk/jhbuild.modules:
2833
2834 2017-07-09  Zan Dobersek  <zdobersek@igalia.com>
2835
2836         Add WebGL2 configuration option to build-webkit
2837         https://bugs.webkit.org/show_bug.cgi?id=174251
2838
2839         Reviewed by Michael Catanzaro.
2840
2841         * Scripts/webkitperl/FeatureList.pm: Add the 'webgl2' option, making it possible
2842         to enable the ENABLE_WEBGL2 flag through the build-webkit script. The feature
2843         is marked as enabled for the Apple Cocoa ports.
2844
2845 2017-07-08  Chris Dumez  <cdumez@apple.com>
2846
2847         Simplify WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore
2848         https://bugs.webkit.org/show_bug.cgi?id=174290
2849
2850         Reviewed by Brent Fulgham.
2851
2852         Rename testRunner API to match the new internal API names.
2853
2854         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2855         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2856         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
2857         (WTR::TestRunner::statisticsSubmitTelemetry):
2858         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2859         * WebKitTestRunner/TestController.cpp:
2860         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2861         (WTR::TestController::statisticsSubmitTelemetry):
2862         * WebKitTestRunner/TestController.h:
2863         * WebKitTestRunner/TestInvocation.cpp:
2864         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2865         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2866         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2867         (WTR::TestController::statisticsSubmitTelemetry):
2868
2869 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
2870
2871         Drop NOSNIFF compile flag
2872         https://bugs.webkit.org/show_bug.cgi?id=174289
2873
2874         Reviewed by Michael Catanzaro.
2875
2876         * Scripts/webkitperl/FeatureList.pm:
2877         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2878
2879 2017-07-07  Wenson Hsieh  <wenson_hsieh@apple.com>
2880
2881         [iOS DnD] For cross-app drags, 'drop' event handlers are never invoked if dataTransfer.dropEffect is not set while dragging
2882         https://bugs.webkit.org/show_bug.cgi?id=174219
2883         <rdar://problem/32083177>
2884
2885         Reviewed by Ryosuke Niwa.
2886
2887         Add plumbing and support to mock the value of -allowsMoveOperation on the simulated UIDragDropSession objects.
2888         Setting the DataInteractionSimulator's shouldAllowMoveOperation property to NO simulates a drag operation coming
2889         in from another app out-of-process, for which move operations won't cause a drop to be performed in the first
2890         place.
2891
2892         Also tweaks 2 existing unit tests regarding file uploads via JavaScript to simulate items coming in from a
2893         different application, and adds a new test to check that if a drop area specifically requests a MOVE operation,
2894         no action is taken when dropping.
2895
2896         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html:
2897         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2898         (TestWebKitAPI::TEST):
2899         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2900         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2901         (-[MockDragDropSession initWithItems:location:window:allowMove:]):
2902         (-[MockDragDropSession allowsMoveOperation]):
2903         (-[MockDataOperationSession initWithProviders:location:window:allowMove:]):
2904         (-[MockDataInteractionSession initWithWindow:allowMove:]):
2905         (-[DataInteractionSimulator initWithWebView:]):
2906         (-[DataInteractionSimulator runFrom:to:]):
2907         (-[DataInteractionSimulator _advanceProgress]):
2908         (-[MockDragDropSession initWithItems:location:window:]): Deleted.
2909         (-[MockDataOperationSession initWithProviders:location:window:]): Deleted.
2910         (-[MockDataInteractionSession initWithWindow:]): Deleted.
2911
2912 2017-07-07  Commit Queue  <commit-queue@webkit.org>
2913
2914         Unreviewed, rolling out r219238, r219239, and r219241.
2915         https://bugs.webkit.org/show_bug.cgi?id=174265
2916
2917         "fast/workers/dedicated-worker-lifecycle.html is flaky"
2918         (Requested by yusukesuzuki on #webkit).
2919
2920         Reverted changesets:
2921
2922         "[WTF] Implement WTF::ThreadGroup"
2923         https://bugs.webkit.org/show_bug.cgi?id=174081
2924         http://trac.webkit.org/changeset/219238
2925
2926         "Unreviewed, build fix after r219238"
2927         https://bugs.webkit.org/show_bug.cgi?id=174081
2928         http://trac.webkit.org/changeset/219239
2929
2930         "Unreviewed, CLoop build fix after r219238"
2931         https://bugs.webkit.org/show_bug.cgi?id=174081
2932         http://trac.webkit.org/changeset/219241
2933
2934 2017-07-07  Yusuke Suzuki  <utatane.tea@gmail.com>
2935
2936         [GTK][WPE] Enable X-Content-Type-Options: nosniff
2937         https://bugs.webkit.org/show_bug.cgi?id=174250
2938
2939         Reviewed by Carlos Alberto Lopez Perez.
2940
2941         * Scripts/webkitperl/FeatureList.pm:
2942
2943 2017-07-07  Charlie Turner  <cturner@igalia.com>
2944         [GStreamer] vid.me videos do not play
2945         https://bugs.webkit.org/show_bug.cgi?id=172240
2946
2947         Reviewed by Xabier Rodriguez-Calvar.
2948
2949         Build httpsoupsrc again for use in adaptive streaming pipelines, and
2950         have the existing libsoup build against GNOME to avoid header drift
2951         against GStreamer's linked Soup library.
2952
2953         * gtk/jhbuild.modules:
2954
2955 2017-07-06  Lucas Forschler  <lforschler@apple.com>
2956
2957         Write a support script to enable buildbot to upload to S3
2958         https://bugs.webkit.org/show_bug.cgi?id=174196
2959         
2960         Reviewed by Stephanie Lewis.
2961
2962         * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Added.
2963         (uploadToS3):
2964         (archiveExists):
2965
2966 2017-07-06  Lucas Forschler  <lforschler@apple.com>
2967
2968         Enabling uploading archives to S3.
2969         https://bugs.webkit.org/show_bug.cgi?id=174198
2970         
2971         Reviewed by Stephanie Lewis.
2972
2973         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2974         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
2975         (UploadMinifiedBuiltProduct): Upload minified archive to build master
2976         (TransferToS3): Transfer full and minified archives to S3
2977
2978 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2979
2980         [WTF] Implement WTF::ThreadGroup
2981         https://bugs.webkit.org/show_bug.cgi?id=174081
2982
2983         Reviewed by Mark Lam.
2984
2985         Add WTF::ThreadGroup tests.
2986
2987         * TestWebKitAPI/CMakeLists.txt:
2988         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2989         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
2990         (TestWebKitAPI::TEST):
2991
2992 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
2993
2994         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
2995         https://bugs.webkit.org/show_bug.cgi?id=174150
2996
2997         Reviewed by Mark Lam.
2998
2999         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
3000         (TestWebKitAPI::TEST):
3001         * TestWebKitAPI/TestsController.cpp:
3002         (TestWebKitAPI::TestsController::TestsController):
3003
3004 2017-07-06  Lucas Forschler  <lforschler@apple.com>
3005
3006         Enabling uploading archives to S3.
3007         https://bugs.webkit.org/show_bug.cgi?id=174198
3008         
3009         Reviewed by Lucas Forschler.
3010
3011         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3012         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
3013         (UploadMinifiedBuiltProduct): Upload minified archive to build master
3014         (TransferToS3): Transfer full and minified archives to S3
3015
3016 2017-07-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3017
3018         [GTK][WPE] kill-old-process should kill more webkit related process
3019         https://bugs.webkit.org/show_bug.cgi?id=174220
3020
3021         Reviewed by Michael Catanzaro.
3022
3023         Generate list of possible webkit-related process names and add
3024         them to the list of process to kill.
3025         Also update the possible system related process for GTK+/WPE.
3026
3027         * BuildSlaveSupport/kill-old-processes:
3028         (listAllWebKitPrograms):
3029         (main):
3030
3031 2017-07-06  Chris Dumez  <cdumez@apple.com>
3032
3033         FileMonitor should not be ref counted
3034         https://bugs.webkit.org/show_bug.cgi?id=174166
3035
3036         Reviewed by Brent Fulgham.
3037
3038         Update the API tests to reflect the API change.
3039
3040         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
3041         (TestWebKitAPI::TEST_F):
3042
3043 2017-07-06  Commit Queue  <commit-queue@webkit.org>
3044
3045         Unreviewed, rolling out r219194.
3046         https://bugs.webkit.org/show_bug.cgi?id=174207
3047
3048         it broke some layout tests (Requested by clopez on #webkit).
3049
3050         Reverted changeset:
3051
3052         "[GStreamer] vid.me videos do not play"
3053         https://bugs.webkit.org/show_bug.cgi?id=172240
3054         http://trac.webkit.org/changeset/219194
3055
3056 2017-07-06  Matt Lewis  <jlewis3@apple.com>
3057
3058         Unreviewed, rolling out r219178.
3059
3060         This caused a consistent failure with the API test
3061         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
3062
3063         Reverted changeset:
3064
3065         "[WTF] Clean up StringStatics.cpp by using
3066         LazyNeverDestroyed<> for Atoms"
3067         https://bugs.webkit.org/show_bug.cgi?id=174150
3068         http://trac.webkit.org/changeset/219178
3069
3070 2017-07-06  Alicia Boya García  <aboya@igalia.com>
3071
3072         Add CWD to Perl library path (no longer the default since 5.26.0)
3073         https://bugs.webkit.org/show_bug.cgi?id=174200
3074
3075         Reviewed by Michael Catanzaro.
3076
3077         * Scripts/webkitpy/tool/commands/setupgitclone.py:
3078         (SetupGitClone._get_username_and_email):
3079
3080 2017-07-06  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3081
3082         Unreviewed, update my email address.
3083
3084         * Scripts/webkitpy/common/config/contributors.json:
3085
3086 2017-07-06  Charlie Turner  <cturner@igalia.com>
3087         [GStreamer] vid.me videos do not play
3088         https://bugs.webkit.org/show_bug.cgi?id=172240
3089
3090         Reviewed by Xabier Rodriguez-Calvar.
3091
3092         Build httpsoupsrc again for use in adaptive streaming pipelines, and
3093         have the existing libsoup build against GNOME to avoid header drift
3094         against GStreamer's linked Soup library.
3095
3096         * gtk/jhbuild.modules:
3097
3098 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
3099
3100         [WTF] Move SoftLinking.h into WTF
3101         https://bugs.webkit.org/show_bug.cgi?id=174000
3102
3103         Reviewed by Alex Christensen.
3104
3105         * DumpRenderTree/mac/TestRunnerMac.mm:
3106         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3107         (test_primary_header):
3108         (ErrorCollector.__init__): Deleted.
3109         (ErrorCollector.__call__): Deleted.
3110         (ErrorCollector.results): Deleted.
3111         (ErrorCollector.result_list): Deleted.
3112         (ErrorCollector.verify_all_categories_are_seen): Deleted.
3113         (MockIo.open): Deleted.
3114         (CppFunctionsTest.test_convert_to_lower_with_underscores): Deleted.
3115         (CppFunctionsTest.test_create_acronym): Deleted.
3116         (CppFunctionsTest.test_is_c_or_objective_c): Deleted.
3117         (CppFunctionsTest.test_parameter): Deleted.
3118         (CppFunctionsTest.test_single_line_view): Deleted.
3119         (CppFunctionsTest.test_create_skeleton_parameters): Deleted.
3120         (CppFunctionsTest.test_find_parameter_name_index): Deleted.
3121         (CppFunctionsTest.test_parameter_list): Deleted.
3122         (CppFunctionsTest.test_check_parameter_against_text): Deleted.
3123         (CppStyleTestBase.process_file_data): Deleted.
3124         (CppStyleTestBase.perform_lint): Deleted.
3125         (CppStyleTestBase.perform_single_line_lint): Deleted.
3126         (CppStyleTestBase.perform_multi_line_lint): Deleted.
3127         (CppStyleTestBase.perform_language_rules_check): Deleted.
3128         (CppStyleTestBase.perform_function_lengths_check): Deleted.
3129         (CppStyleTestBase.perform_pass_ptr_check): Deleted.
3130         (CppStyleTestBase.perform_leaky_pattern_check): Deleted.
3131         (CppStyleTestBase.perform_include_what_you_use): Deleted.
3132         (CppStyleTestBase.perform_header_guard_check): Deleted.
3133         (CppStyleTestBase.assert_lint): Deleted.
3134         (CppStyleTestBase.assert_lint_one_of_many_errors_re): Deleted.
3135         (CppStyleTestBase.assert_multi_line_lint): Deleted.
3136         (CppStyleTestBase.assert_multi_line_lint_re): Deleted.
3137         (CppStyleTestBase.assert_language_rules_check): Deleted.
3138         (CppStyleTestBase.assert_include_what_you_use): Deleted.
3139         (CppStyleTestBase.assert_header_guard): Deleted.
3140         (CppStyleTestBase.assert_blank_lines_check): Deleted.
3141         (CppStyleTestBase.assert_positions_equal): Deleted.
3142         (FunctionDetectionTest.test_basic_function_detection): Deleted.
3143         (FunctionDetectionTest.test_function_declaration_detection): Deleted.
3144         (FunctionDetectionTest.test_pure_function_detection): Deleted.
3145         (FunctionDetectionTest.test_override_and_final_function_detection): Deleted.
3146         (FunctionDetectionTest.test_ignore_macros): Deleted.
3147         (FunctionDetectionTest.test_non_functions): Deleted.
3148         (FunctionDetectionTest.test_non_functions.Stuff): Deleted.
3149         (FunctionDetectionTest.test_parameter_list): Deleted.
3150         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack): Deleted.
3151         (CppStyleTest.test_asm_lines_ignored): Deleted.
3152         (CppStyleTest.test_get_line_width): Deleted.
3153         (CppStyleTest.test_find_next_multi_line_comment_start): Deleted.
3154         (CppStyleTest.test_find_next_multi_line_comment_end): Deleted.
3155         (CppStyleTest.test_remove_multi_line_comments_from_range): Deleted.
3156         (CppStyleTest.test_position): Deleted.
3157         (CppStyleTest.test_rfind_in_lines): Deleted.
3158         (CppStyleTest.test_close_expression): Deleted.
3159         (CppStyleTest.test_spaces_at_end_of_line): Deleted.
3160         (CppStyleTest.test_cstyle_cast): Deleted.
3161         (CppStyleTest.test_runtime_casting): Deleted.
3162         (CppStyleTest.test_runtime_selfinit): Deleted.
3163         (CppStyleTest.test_runtime_rtti): Deleted.
3164         (CppStyleTest.test_static_cast_readability): Deleted.
3165         (CppStyleTest.test_check_for_unnamed_params): Deleted.
3166         (CppStyleTest.void): Deleted.
3167         (CppStyleTest.test_deprecated_cast): Deleted.
3168         (CppStyleTest.test_mock_method): Deleted.
3169         (CppStyleTest.test_sizeof_type): Deleted.
3170         (CppStyleTest.cases): Deleted.
3171         (CppStyleTest.for): Deleted.
3172         (CppStyleTest.test_typedef_for_pointer_to_function): Deleted.
3173         (CppStyleTest.test_typedef_for_pointer_to_function.void): Deleted.
3174         (CppStyleTest.test_include_what_you_use_no_implementation_files): Deleted.
3175         (CppStyleTest.test_include_what_you_use): Deleted.
3176         (CppStyleTest.test_files_belong_to_same_module): Deleted.
3177         (CppStyleTest.test_cleanse_line): Deleted.
3178         (CppStyleTest.test_multi_line_comments): Deleted.
3179         (CppStyleTest.test_multi_line_comments.Foo): Deleted.
3180         (CppStyleTest.test_multiline_strings): Deleted.
3181         (CppStyleTest.test_platformh_comments): Deleted.
3182         (CppStyleTest.test_explicit_single_argument_constructors): Deleted.
3183         (CppStyleTest.test_explicit_single_argument_constructors.Foo): Deleted.
3184         (CppStyleTest.test_explicit_single_argument_constructors.Qualifier): Deleted.
3185         (CppStyleTest.test_explicit_single_argument_constructors.definition): Deleted.
3186         (CppStyleTest.test_slash_star_comment_on_single_line): Deleted.
3187         (CppStyleTest.test_suspicious_usage_of_if): Deleted.
3188         (CppStyleTest.test_suspicious_usage_of_memset): Deleted.
3189         (CppStyleTest.test_check_posix_threading): Deleted.
3190         (CppStyleTest.test_insecure_string_operations): Deleted.
3191         (CppStyleTest.test_format_strings): Deleted.
3192         (CppStyleTest.test_insecure_temp_file): Deleted.
3193         (CppStyleTest.test_variable_length_array_detection): Deleted.
3194         (CppStyleTest.test_braces): Deleted.
3195         (CppStyleTest.test_check_check): Deleted.
3196         (CppStyleTest.test_brace_at_begin_of_line): Deleted.
3197         (CppStyleTest.test_mismatching_spaces_in_parens): Deleted.
3198         (CppStyleTest.test_spacing_for_fncall): Deleted.
3199         (CppStyleTest.test_spacing_for_fncall.foo): Deleted.
3200         (CppStyleTest.test_spacing_before_braces): Deleted.
3201         (CppStyleTest.test_spacing_between_braces): Deleted.
3202         (CppStyleTest.test_spacing_before_brackets): Deleted.
3203         (CppStyleTest.test_cpp_lambda_functions): Deleted.
3204         (CppStyleTest.test_objective_c_block): Deleted.
3205         (CppStyleTest.test_objective_c_block_as_argument): Deleted.
3206         (CppStyleTest.test_spacing_around_else): Deleted.
3207         (CppStyleTest.test_spacing_for_binary_ops): Deleted.
3208         (CppStyleTest.test_spacing_for_binary_ops.hash_map): Deleted.
3209         (CppStyleTest.test_operator_methods): Deleted.
3210         (CppStyleTest.test_spacing_in_objective_c_properties): Deleted.
3211         (CppStyleTest.test_spacing_before_last_semicolon): Deleted.
3212         (CppStyleTest.test_static_or_global_stlstrings): Deleted.
3213         (CppStyleTest.test_no_spaces_in_function_calls): Deleted.
3214         (CppStyleTest.test_one_spaces_between_code_and_comments): Deleted.
3215         (CppStyleTest.test_one_spaces_after_punctuation_in_comments): Deleted.
3216         (CppStyleTest.test_space_after_comment_marker): Deleted.
3217         (CppStyleTest.test_newline_at_eof): Deleted.
3218         (CppStyleTest.test_newline_at_eof.do_test): Deleted.
3219         (CppStyleTest.test_extra_newlines_at_eof): Deleted.
3220         (CppStyleTest.test_extra_newlines_at_eof.do_test): Deleted.
3221         (CppStyleTest.test_invalid_utf8): Deleted.
3222         (CppStyleTest.test_invalid_utf8.do_test): Deleted.
3223         (CppStyleTest.test_is_blank_line): Deleted.
3224         (CppStyleTest.test_blank_lines_check): Deleted.
3225         (CppStyleTest.test_allow_blank_line_before_closing_namespace): Deleted.
3226         (CppStyleTest.test_allow_blank_line_before_if_else_chain): Deleted.
3227         (CppStyleTest.test_else_on_same_line_as_closing_braces): Deleted.
3228         (CppStyleTest.test_else_clause_not_on_same_line_as_else): Deleted.
3229         (CppStyleTest.test_comma): Deleted.
3230         (CppStyleTest.test_declaration): Deleted.
3231         (CppStyleTest.test_pointer_reference_marker_location): Deleted.
3232         (CppStyleTest.test_indent): Deleted.
3233         (CppStyleTest.test_indent.Foo): Deleted.
3234         (CppStyleTest.test_not_alabel): Deleted.
3235         (CppStyleTest.test_tab): Deleted.
3236         (CppStyleTest.test_unnamed_namespaces_in_headers): Deleted.
3237         (CppStyleTest.test_build_class): Deleted.
3238         (CppStyleTest.test_build_class.definitions): Deleted.
3239         (CppStyleTest.test_build_class.Foo): Deleted.
3240         (CppStyleTest.test_build_class.DERIVE_FROM_GOO): Deleted.
3241         (CppStyleTest.test_build_end_comment): Deleted.
3242         (CppStyleTest.test_build_forward_decl): Deleted.
3243         (CppStyleTest.test_build_forward_decl.Foo): Deleted.
3244         (CppStyleTest.test_build_header_guard): Deleted.
3245         (CppStyleTest.test_build_header_guard.Foo_h): Deleted.
3246         (CppStyleTest.test_build_header_guard.Foo_h.for): Deleted.
3247         (CppStyleTest.test_build_printf_format): Deleted.
3248         (CppStyleTest.test_runtime_printf_format): Deleted.
3249         (CppStyleTest.assert_lintLogCodeOnError): Deleted.
3250         (CppStyleTest.test_build_storage_class): Deleted.
3251         (CppStyleTest.test_build_storage_class.unsignedLongLong): Deleted.
3252         (CppStyleTest.test_build_storage_class.declaration): Deleted.
3253         (CppStyleTest.test_build_storage_class.after): Deleted.
3254         (CppStyleTest.test_build_storage_class.is): Deleted.
3255         (CppStyleTest.test_legal_copyright): Deleted.
3256         (CppStyleTest.test_invalid_increment): Deleted.
3257         (CppStyleTest.test_enum_bitfields): Deleted.
3258         (CppStyleTest.test_plain_integral_bitfields): Deleted.
3259         (CleansedLinesTest.test_init_empty): Deleted.
3260         (CleansedLinesTest.test_collapse_strings): Deleted.
3261         (OrderOfIncludesTest.tearDown): Deleted.
3262         (OrderOfIncludesTest.test_check_next_include_order__no_config): Deleted.
3263         (OrderOfIncludesTest.test_check_next_include_order__no_self): Deleted.
3264         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config): Deleted.
3265         (OrderOfIncludesTest.test_check_next_include_order__other_then_config): Deleted.
3266         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely): Deleted.
3267         (OrderOfIncludesTest.test_check_alphabetical_include_order): Deleted.
3268         (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines): Deleted.
3269         (OrderOfIncludesTest.test_check_line_break_after_own_header): Deleted.
3270         (OrderOfIncludesTest.test_check_line_break_before_own_header): Deleted.
3271         (OrderOfIncludesTest.test_check_preprocessor_in_include_section): Deleted.
3272         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.BAZ): Deleted.
3273         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.FOOBAR): Deleted.
3274         (OrderOfIncludesTest.test_primary_header): Deleted.
3275         (OrderOfIncludesTest.test_public_primary_header): Deleted.
3276         (OrderOfIncludesTest.test_check_wtf_includes): Deleted.
3277         (OrderOfIncludesTest.test_classify_include): Deleted.
3278         (OrderOfIncludesTest.test_try_drop_common_suffixes): Deleted.
3279         (CheckForFunctionLengthsTest.tearDown): Deleted.
3280         (CheckForFunctionLengthsTest.set_min_confidence): Deleted.
3281         (CheckForFunctionLengthsTest.assert_function_lengths_check): Deleted.
3282         (CheckForFunctionLengthsTest.trigger_lines): Deleted.
3283         (CheckForFunctionLengthsTest.trigger_test_lines): Deleted.
3284         (CheckForFunctionLengthsTest.assert_function_length_check_definition): Deleted.
3285         (CheckForFunctionLengthsTest.assert_function_length_check_definition_ok): Deleted.
3286         (CheckForFunctionLengthsTest.assert_function_length_check_at_error_level): Deleted.
3287         (CheckForFunctionLengthsTest.assert_function_length_check_below_error_level): Deleted.
3288         (CheckForFunctionLengthsTest.assert_function_length_check_above_error_level): Deleted.
3289         (CheckForFunctionLengthsTest.function_body): Deleted.
3290         (CheckForFunctionLengthsTest.function_body_with_blank_lines): Deleted.
3291         (CheckForFunctionLengthsTest.function_body_with_no_lints): Deleted.
3292         (CheckForFunctionLengthsTest.test_function_length_check_declaration): Deleted.
3293         (CheckForFunctionLengthsTest.test_function_length_check_declaration_with_block_following): Deleted.
3294         (CheckForFunctionLengthsTest.test_function_length_check_class_definition): Deleted.
3295         (CheckForFunctionLengthsTest.test_function_length_check_class_definition.Test): Deleted.
3296         (CheckForFunctionLengthsTest.test_function_length_check_trivial): Deleted.
3297         (CheckForFunctionLengthsTest.test_function_length_check_empty): Deleted.
3298         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity0): Deleted.
3299         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity0): Deleted.
3300         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity0): Deleted.
3301         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1v0): Deleted.
3302         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1v0): Deleted.
3303         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1): Deleted.
3304         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1): Deleted.
3305         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity1): Deleted.
3306         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_indented): Deleted.
3307         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_blanks): Deleted.
3308         (CheckForFunctionLengthsTest.test_function_length_check_complex_definition_severity1): Deleted.
3309         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_test): Deleted.
3310         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_split_line_test): Deleted.
3311         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Deleted.
3312         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_embedded_no_lints): Deleted.
3313         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_no_lint): Deleted.
3314         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity2): Deleted.
3315         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity2): Deleted.
3316         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity2): Deleted.
3317         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity3): Deleted.
3318         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity3): Deleted.
3319         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity3): Deleted.
3320         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity4): Deleted.
3321         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity4): Deleted.
3322         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity4): Deleted.
3323         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity5): Deleted.
3324         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity5): Deleted.
3325         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity5): Deleted.
3326         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines): Deleted.
3327         (CheckForFunctionLengthsTest.test_function_length_not_determinable): Deleted.
3328         (NoNonVirtualDestructorsTest.test_no_error): Deleted.
3329         (NoNonVirtualDestructorsTest.test_no_error.Foo): Deleted.
3330         (NoNonVirtualDestructorsTest.test_no_error.MyClass): Deleted.
3331         (NoNonVirtualDestructorsTest.test_no_error.Qualified): Deleted.
3332         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed): Deleted.
3333         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed.Foo): Deleted.
3334         (NoNonVirtualDestructorsTest.test_enum_casing): Deleted.
3335         (NoNonVirtualDestructorsTest.test_enum_casing.Foo): Deleted.
3336         (NoNonVirtualDestructorsTest.test_enum_casing.Enum123): Deleted.
3337         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon): Deleted.
3338         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass): Deleted.
3339         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum): Deleted.
3340         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed): Deleted.
3341         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed.Foo): Deleted.
3342         (NoNonVirtualDestructorsTest.test_no_warn_when_derived): Deleted.
3343         (NoNonVirtualDestructorsTest.test_no_warn_when_derived.Foo): Deleted.
3344         (NoNonVirtualDestructorsTest.test_internal_braces): Deleted.
3345         (NoNonVirtualDestructorsTest.test_internal_braces.Foo): Deleted.
3346         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor): Deleted.
3347         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo): Deleted.
3348         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo.Goo): Deleted.
3349         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Goo): Deleted.
3350         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor): Deleted.
3351         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo): Deleted.
3352         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo.Goo): Deleted.
3353         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor): Deleted.
3354         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor.Qualified): Deleted.
3355         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error): Deleted.
3356         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error.Foo): Deleted.
3357         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error): Deleted.
3358         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error.Foo): Deleted.
3359         (LeakyPatternTest.assert_leaky_pattern_check): Deleted.
3360         (LeakyPatternTest.test_get_dc): Deleted.
3361         (LeakyPatternTest.test_get_dc.HWndDC): Deleted.
3362         (LeakyPatternTest.test_own_get_dc): Deleted.
3363         (LeakyPatternTest.test_create_dc): Deleted.
3364         (LeakyPatternTest.test_create_compatible_dc): Deleted.
3365         (WebKitStyleTest.test_indentation): Deleted.
3366         (WebKitStyleTest.test_indentation.Foo): Deleted.
3367         (WebKitStyleTest.test_indentation.Document): Deleted.
3368         (WebKitStyleTest.test_spacing): Deleted.
3369         (WebKitStyleTest.test_line_breaking): Deleted.
3370         (WebKitStyleTest.test_braces): Deleted.
3371         (WebKitStyleTest.test_braces.MyClass): Deleted.
3372         (WebKitStyleTest.test_braces.NS_ENUM): Deleted.
3373         (WebKitStyleTest.test_braces.CPP11EnumClass): Deleted.
3374         (WebKitStyleTest.test_braces.SOMETHING): Deleted.
3375         (WebKitStyleTest.test_null_false_zero): Deleted.
3376         (WebKitStyleTest.test_directive_indentation): Deleted.
3377         (WebKitStyleTest.test_using_std): Deleted.
3378         (WebKitStyleTest.test_using_namespace): Deleted.
3379         (WebKitStyleTest.test_max_macro): Deleted.
3380         (WebKitStyleTest.test_min_macro): Deleted.
3381         (WebKitStyleTest.test_wtf_move): Deleted.
3382         (WebKitStyleTest.test_ctype_fucntion): Deleted.
3383         (WebKitStyleTest.test_names): Deleted.
3384         (WebKitStyleTest.test_names.HTMLDocument): Deleted.
3385         (WebKitStyleTest.test_names.WebWindowFadeAnimation): Deleted.
3386         (WebKitStyleTest.test_names.declarations): Deleted.
3387         (WebKitStyleTest.test_names.struct): Deleted.
3388         (WebKitStyleTest.test_names.VectorType): Deleted.
3389         (WebKitStyleTest.test_parameter_names): Deleted.
3390         (WebKitStyleTest.test_comments): Deleted.
3391         (WebKitStyleTest.test_webkit_export_check): Deleted.
3392         (WebKitStyleTest.test_member_initialization_list): Deleted.
3393         (WebKitStyleTest.test_member_initialization_list.MyClass): Deleted.
3394         (WebKitStyleTest.test_other): Deleted.
3395         (CppCheckerTest.mock_handle_style_error): Deleted.
3396         (CppCheckerTest._checker): Deleted.
3397         (CppCheckerTest.test_init): Deleted.
3398         (CppCheckerTest.test_eq): Deleted.
3399         (CppCheckerTest.test_eq.mock_handle_style_error2): Deleted.
3400         (CppCheckerTest.test_ne): Deleted.
3401         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
3402         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
3403         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3404         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3405         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3406         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3407
3408 2017-07-05  Saam Barati  <sbarati@apple.com>
3409
3410         NewArray in FTLLowerDFGToB3 does not handle speculating on doubles when having a bad time
3411         https://bugs.webkit.org/show_bug.cgi?id=174188
3412         <rdar://problem/30581423>
3413
3414         Reviewed by Mark Lam.
3415
3416         * Scripts/run-jsc-stress-tests:
3417
3418 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3419
3420         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
3421         https://bugs.webkit.org/show_bug.cgi?id=174150
3422
3423         Reviewed by Mark Lam.
3424
3425         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
3426         (TestWebKitAPI::TEST):
3427
3428 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
3429
3430         Remove copy of ICU headers from WebKit
3431         https://bugs.webkit.org/show_bug.cgi?id=116407
3432
3433         Reviewed by Alex Christensen.
3434
3435         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3436         * TestWebKitAPI/Configurations/Base.xcconfig:
3437         * WebKitTestRunner/Configurations/Base.xcconfig:
3438
3439 2017-07-05  Chris Dumez  <cdumez@apple.com>
3440
3441         Regression(r218821): Bad cast to WebKit::DiagnosticLoggingClient in WKWebView's _setDiagnosticLoggingDelegate
3442         https://bugs.webkit.org/show_bug.cgi?id=174163
3443         <rdar://problem/33067518>
3444
3445         Reviewed by Alex Christensen.
3446
3447         Add API test coverage.
3448
3449         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3450         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDiagnosticLogging.mm: Added.
3451         (TEST):
3452
3453 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3454
3455         When dragging a selection, clearing the selection in dragstart should not crash the web process
3456         https://bugs.webkit.org/show_bug.cgi?id=174142
3457         <rdar://problem/33067501>
3458
3459         Reviewed by Tim Horton.
3460
3461         Adds a unit test checking that the web process does not crash when the selection is cleared while a selection
3462         drag is starting up.
3463
3464         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3465         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-clear-selection.html: Added.
3466         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3467         (TestWebKitAPI::TEST):
3468
3469 2017-07-05  Daniel Bates  <dabates@apple.com>
3470
3471         Do not pass API::FrameInfo for source frame or clear out page of target frame on
3472         API navigation
3473         https://bugs.webkit.org/show_bug.cgi?id=174170
3474         <rdar://problem/33140328>
3475
3476         Reviewed by Brady Eidson.
3477
3478         Update tests as needed for the behavior change.
3479
3480         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
3481         (TEST):
3482
3483 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
3484
3485         Add WebKitPrivateFrameworkStubs for iOS 11
3486         https://bugs.webkit.org/show_bug.cgi?id=173988
3487
3488         Reviewed by David Kilzer.
3489
3490         * DumpRenderTree/mac/Configurations/Base.xcconfig: iphoneos and iphonesimulator
3491         should use the same directory for private framework stubs.
3492         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
3493
3494 2017-07-05  Eric Carlson  <eric.carlson@apple.com>
3495
3496         [MediaStream] Protect request and web view during gUM client callback
3497         https://bugs.webkit.org/show_bug.cgi?id=174096
3498         <rdar://problem/32833102>
3499
3500         Reviewed by Youenn Fablet.
3501
3502         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3503         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
3504
3505 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3506
3507         Unreviewed, guard iOS 11-dependent UIPasteboardTests to be iOS 11+ only
3508
3509         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
3510
3511 2017-07-05  Matt Lewis  <jlewis3@apple.com>
3512
3513         Unreviewed, rolling out r219128.
3514
3515         Spoke with engineer who originally submitted, Patch for APi
3516         test to follow.
3517
3518         Reverted changeset:
3519
3520         "Unreviewed, rolling out r219070."
3521         https://bugs.webkit.org/show_bug.cgi?id=174082
3522         http://trac.webkit.org/changeset/219128
3523
3524 2017-07-05  Matt Lewis  <jlewis3@apple.com>
3525
3526         Unreviewed, rolling out r219070.
3527
3528         This revision caused consistent failures of the API test
3529         UIPasteboardTests.DoNotPastePlainTextAsURL on iOS.
3530
3531         Reverted changeset:
3532
3533         "Pasting single words copied to UIPasteboard inserts URLs in
3534         editable areas"
3535         https://bugs.webkit.org/show_bug.cgi?id=174082
3536         http://trac.webkit.org/changeset/219070
3537
3538 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3539
3540         Remove unused EFL logo from bot watcher dashboard
3541         https://bugs.webkit.org/show_bug.cgi?id=174136
3542
3543         Reviewed by Alexey Proskuryakov.
3544
3545         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Removed.
3546         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Removed.
3547
3548 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3549
3550         [GTK] Add more GTK bots to dashboard
3551         https://bugs.webkit.org/show_bug.cgi?id=174129
3552
3553         Reviewed by Carlos Alberto Lopez Perez.
3554
3555         We have a bunch of GTK bots that I never look at because they're not on the dashboard. Add
3556         them.
3557
3558         This also changes the sort order to put WPE above GTK so that it's not buried under all the
3559         less-essential GTK bots.
3560
3561         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3562         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3563         (WebKitBuildbot):
3564
3565 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3566
3567         [WPE] Add WPE to bot watcher dashboard
3568         https://bugs.webkit.org/show_bug.cgi?id=174119
3569
3570         Reviewed by Alexey Proskuryakov.
3571
3572         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/CREDIT: Added.
3573         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png: Added.
3574         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png: Added.
3575         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3576         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3577         (WebKitBuildbot):
3578         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3579         (table.queue-grid tr.platform.linux-wpe img.logo):
3580
3581 2017-07-03  Lucas Forschler  <lforschler@apple.com>
3582
3583         https://bugs.webkit.org/show_bug.cgi?id=174105
3584         
3585         Reviewed by Stephanie Lewis.
3586
3587         * BuildSlaveSupport/built-product-archive:
3588         (main): Add a -minify parser option
3589         (createZip): Pass along the optional Minify argument if requested
3590         (minifySource): This will trim down archives, logic limited to Mac platform.
3591
3592 2017-07-03  Matt Rajca  <mrajca@apple.com>
3593
3594         Add/remove appropriate media element behavior restrictions when updateWebsitePolicies is called
3595         https://bugs.webkit.org/show_bug.cgi?id=174103
3596
3597         Reviewed by Alex Christensen.
3598
3599         Added an API test.
3600
3601         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Expose a pause method.
3602         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
3603         (TEST): Added test.
3604         * TestWebKitAPI/cocoa/TestWKWebView.h:
3605         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3606         (-[TestWKWebView stringByEvaluatingJavaScript:]): Don't simulate a user gesture when invoking the script.
3607
3608 2017-07-03  Matt Lewis  <jlewis3@apple.com>
3609
3610         Unreviewed, rolling out r219103.
3611
3612         Caused multiple build failures.
3613
3614         Reverted changeset:
3615
3616         "Remove copy of ICU headers from WebKit"
3617         https://bugs.webkit.org/show_bug.cgi?id=116407
3618         http://trac.webkit.org/changeset/219103
3619
3620 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
3621
3622         Remove copy of ICU headers from WebKit
3623         https://bugs.webkit.org/show_bug.cgi?id=116407
3624
3625         Reviewed by Alex Christensen.
3626
3627         Use WTF's copy of ICU headers.
3628
3629         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3630         * TestWebKitAPI/Configurations/Base.xcconfig:
3631         * WebKitTestRunner/Configurations/Base.xcconfig:
3632
3633 2017-07-03  Brady Eidson  <beidson@apple.com>
3634
3635         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
3636         https://bugs.webkit.org/show_bug.cgi?id=174073
3637
3638         Reviewed by Andy Estes.
3639
3640         * DumpRenderTree/mac/TestRunnerMac.mm:
3641         (TestRunner::setIconDatabaseEnabled): Call new SPI for this setting instead of WebIconDatabase stuff.
3642
3643         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:
3644         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
3645
3646 2017-07-03  Matt Lewis  <jlewis3@apple.com>
3647
3648         Unreviewed, rolling out r219083.
3649
3650         The revision caused an API failure on all testing platforms.
3651
3652         Reverted changeset:
3653
3654         "[MediaStream] Protect request and web view during gUM client
3655         callback"
3656         https://bugs.webkit.org/show_bug.cgi?id=174096
3657         http://trac.webkit.org/changeset/219083
3658
3659 2017-07-03  Jonathan Bedard  <jbedard@apple.com>
3660
3661         webkitpy: Properly number duplicated crashlogs
3662         https://bugs.webkit.org/show_bug.cgi?id=172002
3663
3664         Reviewed by Aakash Jain.
3665
3666         * Scripts/webkitpy/common/system/crashlogs.py:
3667         (CrashLogs._find_all_logs_darwin): Number multiple crash logs for a single process with
3668         an increasing integer.
3669         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
3670         (CrashLogsTest.create_crash_logs_darwin): Create duplicated crashlog for testing.
3671         (CrashLogsTest.test_find_all_log_darwin): Now 7 Darwin logs instead of 5.
3672         (CrashLogsTest.test_duplicate_log_darwin): Test that duplicated logs are correctly numbered.
3673
3674 2017-07-03  Ryosuke Niwa  <rniwa@webkit.org>
3675
3676         WebContent processes crash when the network process crashes with pending connection requests
3677         https://bugs.webkit.org/show_bug.cgi?id=174065
3678         <rdar://problem/30359835>
3679
3680         Reviewed by Tim Horton.
3681
3682         Add a API to ensure UI process tries to relaunch a new network process when the network process
3683         crashes with pending network connection requests.
3684
3685         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3686         * TestWebKitAPI/Tests/WebKit2/NetworkProcessCrashWithPendingConnection.mm: Added.
3687         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3688         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3689         (-[TestNavigationDelegate webViewWebContentProcessDidTerminate:]): Added.
3690
3691 2017-07-03  Eric Carlson  <eric.carlson@apple.com>
3692
3693         [MediaStream] Protect request and web view during gUM client callback
3694         https://bugs.webkit.org/show_bug.cgi?id=174096
3695         <rdar://problem/32833102>
3696
3697         Reviewed by Youenn Fablet.
3698
3699         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3700         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
3701
3702 2017-07-03  Andy Estes  <aestes@apple.com>
3703
3704         [Xcode] Add an experimental setting to build with ccache
3705         https://bugs.webkit.org/show_bug.cgi?id=173875
3706
3707         Reviewed by Tim Horton.
3708
3709         On systems that already have ccache(1) installed, this patch adds experimental support for
3710         it to Xcode builds. It can be enabled with the WK_USE_CCACHE build setting.
3711
3712         When ccache is enabled, CC is overridden to invoke Tools/ccache/ccache-clang. This script
3713         finds the "-isysroot" argument to determine the active SDK, uses xcrun(1) and the SDK to
3714         find the toolchain from which to run clang, and then invokes ccache with the required
3715         arguments.
3716
3717         ccache is invoked with CCACHE_SLOPPINESS="pch_defines,time_macros", which is required for
3718         precompiled headers to work properly [1].
3719
3720         LDPLUSPLUS is overridden to invoke Tools/ccache/ccache-clang++. It behaves the same as
3721         ccache-clang, except it tells ccache to execute clang++ instead of clang. This is important
3722         during linking.
3723         
3724         [1] https://ccache.samba.org/manual.html#_precompiled_headers
3725
3726         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
3727         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
3728         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
3729         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
3730         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Ditto.
3731         * ccache/README.md: Added.
3732         * ccache/ccache-clang: Added.
3733         * ccache/ccache-clang++: Added.
3734         * ccache/ccache.xcconfig: Added. Overrides CC and LDPLUSPLUS when WK_USE_CACHE=YES.
3735
3736 2017-07-03  Alex Christensen  <achristensen@webkit.org>
3737
3738         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
3739         https://bugs.webkit.org/show_bug.cgi?id=174051
3740
3741         Reviewed by Tim Horton.
3742
3743         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3744         (TestWebKitAPI::TEST_F):
3745
3746 2017-07-03  Matt Lewis  <jlewis3@apple.com>
3747
3748         Unreviewed, rolling out r219024.
3749
3750         This patch cause 3 didferent test to fail.
3751
3752         Reverted changeset:
3753
3754         "REGRESSION(r215096) Queries of URLs with non-special schemes
3755         should not percent-encode single quotes"
3756         https://bugs.webkit.org/show_bug.cgi?id=174051
3757         http://trac.webkit.org/changeset/219024
3758
3759 2017-07-03  Chris Dumez  <cdumez@apple.com>
3760
3761         Drop ResourceLoadStatisticsStore's statisticsLock
3762         https://bugs.webkit.org/show_bug.cgi?id=174080
3763
3764         Reviewed by Brent Fulgham.
3765
3766         Port WebKitTestRunner to new Asynchronous Cocoa SPI.
3767
3768         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3769         (WTR::TestController::isStatisticsPrevalentResource):
3770         (WTR::TestController::isStatisticsHasHadUserInteraction):
3771         (WTR::TestController::isStatisticsGrandfathered):
3772
3773 2017-07-03  Wenson Hsieh  <wenson_hsieh@apple.com>
3774
3775         Pasting single words copied to UIPasteboard inserts URLs in editable areas
3776         https://bugs.webkit.org/show_bug.cgi?id=174082
3777         <rdar://problem/33046992>
3778
3779         Reviewed by Tim Horton.
3780
3781         Adds 3 new unit tests to UIPasteboardTests to test cases of pasting plain text and URLs.
3782
3783         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
3784         (TestWebKitAPI::setUpWebViewForPasteboardTests):
3785         (TestWebKitAPI::TEST):
3786
3787 2017-07-02  Brady Eidson  <beidson@apple.com>
3788
3789         Add API test for all parts of WebKit1 API related to favicons.
3790         https://bugs.webkit.org/show_bug.cgi?id=174069
3791
3792         Reviewed by Andy Estes.
3793
3794         These two API tests cover all WebKit1 API related to icons.
3795         
3796         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3797         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm: Added.
3798         (mainResourceData):
3799         (defaultFaviconData):
3800         (customFaviconData):
3801         (imageFromData):
3802         (+[IconLoadingProtocol canInitWithRequest:]):
3803         (+[IconLoadingProtocol canonicalRequestForRequest:]):
3804         (-[IconLoadingProtocol startLoading]):
3805         (-[IconLoadingProtocol stopLoading]):
3806         (-[IconLoadingFrameLoadDelegate webView:didReceiveIcon:forFrame:]):
3807         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
3808         (TestWebKitAPI::TEST):
3809
3810 2017-07-01  Dan Bernstein  <mitz@apple.com>
3811
3812         [iOS] Remove code only needed when building for iOS 9.x
3813         https://bugs.webkit.org/show_bug.cgi?id=174068
3814
3815         Reviewed by Tim Horton.
3816
3817         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3818         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3819         (WTR::initializeWebViewConfiguration):
3820         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3821         (-[HIDEventGenerator _createIOHIDEventType:]):
3822
3823 2017-07-01  Brady Eidson  <beidson@apple.com>
3824
3825         When setting a custom cookie storage location on a WKWebsiteDataStore, cookies aren't actually removed.
3826         <rdar://problem/32410662> and https://bugs.webkit.org/show_bug.cgi?id=174035
3827
3828         Reviewed by Alex Christensen.
3829
3830         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
3831
3832 2017-07-01  Dan Bernstein  <mitz@apple.com>
3833
3834         [macOS] Remove code only needed when building for OS X Yosemite
3835         https://bugs.webkit.org/show_bug.cgi?id=174067
3836
3837         Reviewed by Tim Horton.
3838
3839         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3840         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3841         * DumpRenderTree/mac/DumpRenderTree.mm:
3842         (setDefaultsToConsistentValuesForTesting):
3843         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3844         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
3845         * MiniBrowser/Configurations/Base.xcconfig:
3846         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3847         * TestWebKitAPI/Configurations/Base.xcconfig:
3848         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3849         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3850         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
3851         (TestWebKitAPI::TEST_F):
3852         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
3853         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
3854         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
3855         (TestWebKitAPI::TEST_F):
3856         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
3857         (TestWebKitAPI::TEST):
3858         * WebKitTestRunner/Configurations/Base.xcconfig:
3859         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3860         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3861         (WTR::InjectedBundle::platformInitialize):
3862         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
3863         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
3864
3865 2017-07-01  Chris Dumez  <cdumez@apple.com>
3866
3867         Replace ResourceLoadStatisticsStore C API with Cocoa SPI
3868         https://bugs.webkit.org/show_bug.cgi?id=174060
3869
3870         Reviewed by Brent Fulgham.
3871
3872         Port WebKitTestRunner over to the new Cocoa SPI.
3873
3874         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3875         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
3876         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
3877         Drop calls to the WKResourceLoadStatisticsStore C API here. Those were
3878         no-ops since this code runs in the WebContent process, not the
3879         UIProcess.
3880
3881         * WebKitTestRunner/TestController.cpp:
3882         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3883
3884 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
3885
3886         Unreviewed mac build fix.
3887
3888         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
3889         (TestWebKitAPI::TEST):
3890
3891 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
3892
3893         Add API to get WKActivatedElementInfo
3894         https://bugs.webkit.org/show_bug.cgi?id=174001
3895         <rdar://problem/29165518>
3896         
3897         Tests for now SPI to get activatedElementInfo.
3898
3899         Reviewed by Tim Horton.
3900
3901         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3902         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm: Added.
3903         (TestWebKitAPI::TEST):
3904
3905 2017-06-30  Chris Dumez  <cdumez@apple.com>
3906
3907         Move store logic from WebResourceLoadStatisticsManager to WebResourceLoadStatisticsStore
3908         https://bugs.webkit.org/show_bug.cgi?id=174038
3909
3910         Reviewed by Brent Fulgham.
3911
3912         Fix typo in API name.
3913
3914         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3915         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3916         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
3917         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3918         * WebKitTestRunner/TestController.cpp:
3919         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
3920         * WebKitTestRunner/TestController.h:
3921         * WebKitTestRunner/TestInvocation.cpp:
3922         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3923
3924 2017-06-30  Alex Christensen  <achristensen@webkit.org>
3925
3926         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
3927         https://bugs.webkit.org/show_bug.cgi?id=174051
3928         <rdar://problem/33002846>
3929
3930         Reviewed by Tim Horton.
3931
3932         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3933         (TestWebKitAPI::TEST_F):
3934
3935 2017-06-30  Daniel Bates  <dabates@apple.com>
3936
3937         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
3938         https://bugs.webkit.org/show_bug.cgi?id=165160
3939         <rdar://problem/29451999>
3940
3941         Reviewed by Brady Eidson.
3942
3943         Add tests to ensure that -[WKFrameInfo webView] is computed correctly for the source and target frame
3944         for navigations and window creation.
3945
3946         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3947         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm: Added. Derived from file ShouldOpenExternalURLsInNewWindowActions.mm.
3948         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
3949         (-[DecidePolicyForNavigationActionController webView:didFinishNavigation:]):
3950         (-[DecidePolicyForNavigationActionController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3951         (TEST):
3952
3953 2017-06-29  Jer Noble  <jer.noble@apple.com>
3954
3955         Make Legacy EME API controlled by RuntimeEnabled setting.
3956         https://bugs.webkit.org/show_bug.cgi?id=173994
3957
3958         Reviewed by Sam Weinig.
3959
3960         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3961
3962 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
3963
3964         Follow-up fix for r218996
3965
3966         Unreviewed infrastructure fix.
3967
3968         Repeated calls to 'ios_version' make the log noisy, memoize the function.
3969
3970         * Scripts/webkitpy/port/ios_simulator.py:
3971         (IOSSimulatorPort): Memoize ios_version().
3972
3973 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
3974
3975         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
3976         https://bugs.webkit.org/show_bug.cgi?id=174017
3977         <rdar://problem/32959782>
3978
3979         Reviewed by Simon Fraser.
3980
3981         Add a new test verifying that the drag caret is visually contained within the bounds of an iframe. Before these
3982         changes, the caret would appear outside of the iframe.
3983
3984         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3985         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-in-iframe.html: Added.
3986         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3987         (checkDragCaretRectIsContainedInRect):
3988         (TestWebKitAPI::TEST):
3989         * TestWebKitAPI/ios/DataInteractionSimulator.h:
3990         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3991         (-[DataInteractionSimulator _resetSimulatedState]):
3992         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
3993         (-[DataInteractionSimulator _advanceProgress]):
3994         (-[DataInteractionSimulator lastKnownDragCaretRect]):
3995
3996 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
3997
3998         Add support for different versions of iOS when loading test expectations
3999         https://bugs.webkit.org/show_bug.cgi?id=173774
4000         <rdar://problem/32951132>
4001
4002         Rubber-stamped by Aakash Jain.
4003
4004         When running layout tests, we should support multiple version of iOS the same way we do Mac.
4005
4006         * Scripts/webkitpy/port/ios.py:
4007         (IOSPort.default_baseline_search_path): Add ios-<major version> test expectation.
4008         (IOSPort.test_expectations_file_position): Added new file expectations, increment expected file position.
4009         (IOSPort.ios_version): iOS ports must define a function to retrieve the iOS version.
4010         * Scripts/webkitpy/port/ios_device.py:
4011         (IOSDevicePort.ios_version): Ask connected devices for implementation.
4012         * Scripts/webkitpy/port/ios_device_unittest.py:
4013         (IOSDeviceTest.test_additional_platform_directory): Skip test until bug 173775 is finished.
4014         (IOSDeviceTest.test_baseline_searchpath): Ditto.
4015         (IOSDeviceTest.test_expectations_ordering): Ditto.
4016         * Scripts/webkitpy/port/ios_simulator.py:
4017         (IOSSimulatorPort.ios_version): If a runtime is specified, ask the runtime for the iOS version. Otherwise,
4018         ask the platform.
4019
4020 2017-06-30  Jacobo Aragunde Pérez  <jaragunde@igalia.com>
4021
4022         Fontconfig build breaks with glibc 2.15+
4023         https://bugs.webkit.org/show_bug.cgi?id=174019
4024
4025         Reviewed by Carlos Alberto Lopez Perez.
4026
4027         Apply patch by Khem Raj adapted to fontconfig 2.11.1.
4028
4029         * wpe/jhbuild.modules:
4030         * wpe/patches/fontconfig-avoid-conflicts-with-integer-width-macros-from-TS-18.patch: Added.
4031
4032 2017-06-29  Wenson Hsieh  <wenson_hsieh@apple.com>
4033
4034         [iOS DnD] Web content process crashes when the selection is moved far offscreen in dragstart
4035         https://bugs.webkit.org/show_bug.cgi?id=174010
4036         <rdar://problem/32597802>
4037
4038         Reviewed by Tim Horton.
4039
4040         Adds a new API test to ensure that we don't crash trying to dereference a null RefPtr when the TextIndicator
4041         snapshot fails for any reason.
4042
4043         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4044         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-change-selection-offscreen.html: Added.
4045         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
4046         (TestWebKitAPI::TEST):
4047
4048 2017-06-29  Chris Fleizach  <cfleizach@apple.com>
4049
4050         AX: Cannot call setValue() on contenteditable or ARIA text controls
4051         https://bugs.webkit.org/show_bug.cgi?id=173520
4052
4053         Reviewed by Ryosuke Niwa.
4054
4055         Add setValue() method to WKTR (already existed in DRT).
4056
4057         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
4058         (WTR::AccessibilityUIElement::setValue):
4059         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
4060         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
4061         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4062         (WTR::AccessibilityUIElement::setValue):
4063
4064 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
4065
4066         getBoundingClientRect returns wrong value for combination of page zoom and scroll
4067         https://bugs.webkit.org/show_bug.cgi?id=173841
4068         rdar://problem/32983841
4069
4070         Reviewed by Dean Jackson.
4071
4072         Make "Zoom In" and "Zoom Out" work correctly in the WebKit1 window. Previously they
4073         always did text zooming.
4074
4075         * MiniBrowser/mac/WK1BrowserWindowController.m:
4076         (-[WK1BrowserWindowController zoomIn:]):
4077         (-[WK1BrowserWindowController zoomOut:]):
4078         (-[WK1BrowserWindowController canResetZoom]):
4079         (-[WK1BrowserWindowController resetZoom:]):
4080
4081 2017-06-29  John Wilander  <wilander@apple.com>
4082
4083         Fix for intermittent Layout Test fail http/tests/loading/resourceLoadStatistics/telemetry-generation.html
4084         https://bugs.webkit.org/show_bug.cgi?id=173940
4085         <rdar://problem/33018125>
4086
4087         Reviewed by Brent Fulgham.
4088
4089         This change allows the TestController to turn off
4090         regular resource load statistics telemetry submission
4091         and to manually control when telemetry is calculated
4092         and submitted.
4093
4094         * WebKitTestRunner/TestController.cpp:
4095         (WTR::TestController::initialize):
4096             Turns off automatic resource load statistics telemetry submission.
4097
4098 2017-06-29  Commit Queue  <commit-queue@webkit.org>
4099
4100         Unreviewed, rolling out r218512.
4101         https://bugs.webkit.org/show_bug.cgi?id=173981
4102
4103         "It changes the behavior of the JS API's JSEvaluateScript
4104         which breaks TurboTax" (Requested by saamyjoon on #webkit).
4105
4106         Reverted changeset:
4107
4108         "test262: Completion values for control flow do not match the
4109         spec"
4110         https://bugs.webkit.org/show_bug.cgi?id=171265
4111         http://trac.webkit.org/changeset/218512
4112
4113 2017-06-29  Jonathan Bedard  <jbedard@apple.com>
4114
4115         Add WebKitSystemInterface for iOS 11
4116         https://bugs.webkit.org/show_bug.cgi?id=173936
4117
4118         Reviewed by Lucas Forschler.
4119
4120         * Scripts/copy-webkitlibraries-to-product-directory: Copy iOS 11 WebKitSystemInterface libraries. 
4121
4122 2017-06-28  Keith Miller  <keith_miller@apple.com>
4123
4124         VMTraps has some races
4125         https://bugs.webkit.org/show_bug.cgi?id=173941
4126
4127         Reviewed by Michael Saboff.
4128
4129         Add new testing mode for testing the Watchdog with our stress
4130         tests.
4131
4132         * Scripts/run-jsc-stress-tests:
4133
4134 2017-06-29  Carlos Garcia Campos  <cgarcia@igalia.com>
4135
4136         [GTK][WPE] Implement API::IconLoadingClient and rework WebKitFaviconDatabase to use IconDatabase directly
4137         https://bugs.webkit.org/show_bug.cgi?id=173877
4138
4139         Reviewed by Brady Eidson.
4140
4141         Update favicons unit test to ensure we wait until the database is updated in testGetFavicon() before starting
4142         the next tests.
4143
4144         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
4145         (testGetFavicon):
4146
4147 2017-06-28  Tim Horton  <timothy_horton@apple.com>
4148
4149         MobileSafari was constantly using 10-15% CPU viewing a PDF
4150         https://bugs.webkit.org/show_bug.cgi?id=173944
4151         <rdar://problem/33039910>
4152
4153         Reviewed by Simon Fraser.
4154
4155         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4156         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewStablePresentationUpdateCallback.mm:
4157         Add a test that we ever call the stable presentation update callback
4158         when we have a WKPDFView up, instead of infinitely looping.
4159
4160 2017-06-28  Alex Christensen  <achristensen@webkit.org>
4161
4162         Prevent displaying URLs with small capital letters
4163         https://bugs.webkit.org/show_bug.cgi?id=173949
4164         <rdar://problem/32952058>
4165
4166         Reviewed by Brent Fulgham.
4167
4168         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
4169         (TestWebKitAPI::TEST):
4170
4171 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
4172
4173         Unreviewed test fix.
4174
4175         Disable the file monitor tests on iOS because the 'system' API is unavailable on that platform.
4176
4177         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: 
4178
4179 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
4180
4181         Teach ResourceLoadStatistics to recognize changes in the file system
4182         https://bugs.webkit.org/show_bug.cgi?id=173800
4183         <rdar://problem/32937842>
4184
4185         Reviewed by Chris Dumez.
4186
4187         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4188         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: Added.
4189         (TestWebKitAPI::FileMonitorTest::tempFilePath):
4190         (TestWebKitAPI::handleFileModification):
4191         (TestWebKitAPI::handleFileDeletion):
4192         (TestWebKitAPI::resetTestState):
4193         (TestWebKitAPI::TEST_F):
4194
4195 2017-06-28  Brady Eidson  <beidson@apple.com>
4196
4197         DocumentLoader should always notify the client if there are pending icon loads when the load is stopped.
4198         https://bugs.webkit.org/show_bug.cgi?id=173874
4199
4200         Reviewed by Alex Christensen.
4201
4202         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
4203
4204 2017-06-28  Don Olmstead  <don.olmstead@sony.com>
4205
4206         Unreviewed, adding Don Olmstead to contributors.json
4207
4208         * Scripts/webkitpy/common/config/contributors.json:
4209
4210 2017-06-28  Alex Christensen  <achristensen@webkit.org>
4211
4212         WebsitePolicies given with navigation policy for redirects should apply to the provisional document
4213         https://bugs.webkit.org/show_bug.cgi?id=173886
4214         <rdar://problem/32543191>
4215
4216         Reviewed by Andy Estes.
4217
4218         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
4219         (ParsedRange::ParsedRange):
4220         (-[TestSchemeHandler initWithVideoData:]):
4221         (-[TestSchemeHandler webView:startURLSchemeTask:]):
4222         (-[TestSchemeHandler webView:stopURLSchemeTask:]):
4223         (TEST):
4224
4225 2017-06-27  JF Bastien  <jfbastien@apple.com>
4226
4227         WebAssembly: running out of executable memory should throw OoM
4228         https://bugs.webkit.org/show_bug.cgi?id=171537
4229         <rdar://problem/32963338>
4230
4231         Reviewed by Saam Barati.
4232
4233         * Scripts/run-jsc-stress-tests: add a configuration which runs the
4234         tests under limited executable memory and avoids non-WebAssembly
4235         code generation so that we more reliably run out of executable
4236         memory in WebAssembly.
4237
4238 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
4239
4240         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
4241         https://bugs.webkit.org/show_bug.cgi?id=173854
4242         <rdar://problem/32236827>
4243
4244         Reviewed by Ryosuke Niwa and Tim Horton.
4245
4246         Adds a new test to check that an image can be dragged out of a contenteditable and dropped.
4247
4248         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4249         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-target.html: Added.
4250         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
4251         (TestWebKitAPI::TEST):
4252
4253 2017-06-27  Don Olmstead  <don.olmstead@sony.com>
4254
4255         [PAL] Add symbol export macros for PAL
4256         https://bugs.webkit.org/show_bug.cgi?id=171519
4257
4258         Reviewed by Konstantin Tokarev.
4259
4260         * DumpRenderTree/config.h: