Web Inspector: Make localizedString.js diff and commit friendly (UTF16 -> UTF8)
[WebKit-https.git] / Tools / ChangeLog
1 2016-08-27  Joseph Pecoraro  <pecoraro@apple.com>
2
3         Web Inspector: Make localizedString.js diff and commit friendly (UTF16 -> UTF8)
4         https://bugs.webkit.org/show_bug.cgi?id=28685
5         <rdar://problem/16460975>
6
7         Reviewed by Darin Adler.
8
9         * Scripts/extract-localizable-js-strings:
10         * Scripts/update-webkit-localizable-strings:
11         WebInspectorUI localizedStrings.js is now UTF-8. Other clients of
12         this script still use UTF-16, so keep that the default.
13
14 2016-08-27  Alexey Proskuryakov  <ap@apple.com>
15
16         REGRESSION (r204052): Popovers on bot watcher's dashboard are broken
17         https://bugs.webkit.org/show_bug.cgi?id=161254
18
19         Reviewed by Darin Adler.
20
21         Simplify the CSS. My understanding that the CSS was correct, and the root cause
22         is tracked in bug 160478.
23
24         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
25
26 2016-08-27  Simon Fraser  <simon.fraser@apple.com>
27
28         Add run-webkit-tests --print-expectations to show expectations for all or a subset of tests
29         https://bugs.webkit.org/show_bug.cgi?id=161217
30
31         Reviewed by Ryosuke Niwa.
32
33         "run-webkit-tests --print-expectations" runs the same logic as running the tests, but
34         dumps out the lists of tests that would be run and skipped, and, for each, the entry
35         in TestExpectations that determines the expected outcome of the test.
36
37         This is an improved version of webkit-patch print-expectations.
38
39         See bug for sample output.
40
41         * Scripts/webkitpy/layout_tests/controllers/manager.py:
42         (Manager._print_expectations_for_subset): Print out the list of tests and expected
43         outcome for some subset of tests.
44         (Manager.print_expectations): Do the same splitting by device class that running tests
45         does, and for each subset of tests, call _print_expectations_for_subset.
46         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
47         (TestExpectationParser.expectation_for_skipped_test): Set the flag
48         expectation_line.not_applicable_to_current_platform
49         (TestExpectationLine.__init__): Init not_applicable_to_current_platform to False
50         (TestExpectationLine.expected_behavior): line.expectation is ['PASS'] by default,
51         even for skipped tests. This function returns a list relevant for display, taking the skipped
52         modifier into account.
53         (TestExpectationLine.create_passing_expectation): expectations is normally a list, not a set.
54         (TestExpectations.readable_filename_and_line_number): Return something printable for 
55         lines with and without filenames
56         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
57         (main): Handle options.print_expectations
58         (parse_args): Add support for --print-expectations
59         (_print_expectations):
60         * Scripts/webkitpy/port/ios.py:
61         (IOSSimulatorPort.default_child_processes): Make this a debug log.
62
63 2016-08-26  Dan Bernstein  <mitz@apple.com>
64
65         Keep trying to fix the build after r205057.
66
67         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
68
69 2016-08-26  Dan Bernstein  <mitz@apple.com>
70
71         Keep trying to fix the build after r205057.
72
73         * MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m: Don’t try to import nonexistent
74           config.h. This file is only meant to be built with Xcode anyway.
75         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard: Make this compile
76           with Xcode 7.3 and deploy to iOS 9.0.
77         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard: Ditto.
78         * MobileMiniBrowser/MobileMiniBrowser/TabViewController.m: Don’t try to import config.h.
79         * MobileMiniBrowser/MobileMiniBrowser/WebViewController.m: Ditto.
80
81 2016-08-26  Dan Bernstein  <mitz@apple.com>
82
83         Start trying to fix the build after r205057.
84
85         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
86
87 2016-08-26  Alexey Proskuryakov  <ap@apple.com>
88
89         Remove Yosemite Leaks from the flakiness dashboard
90         https://bugs.webkit.org/show_bug.cgi?id=161253
91
92         Reviewed by Anders Carlsson.
93
94         * TestResultServer/static-dashboards/builders.jsonp:
95
96 2016-08-26  Sam Weinig  <sam@webkit.org>
97
98         Remove support for ENABLE_LEGACY_WEB_AUDIO
99         https://bugs.webkit.org/show_bug.cgi?id=161262
100
101         Reviewed by Anders Carlsson.
102
103         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
104
105 2016-08-26  Jer Noble  <jer.noble@apple.com>
106
107         Add a test harness for running UI tests on the iOS Simulator
108         https://bugs.webkit.org/show_bug.cgi?id=161265
109
110         Reviewed by Simon Fraser.
111
112         Add a new iOS Simulator application which uses WKWebView to implement a basic browser, and which
113         can serve as a test harness for WebKit UI tests.
114
115         Also add a basic media playback test which verifies that a <video> element will begin playing in
116         fullscreen on an iPhone device, but will play inline on an iPad device.
117
118         * Makefile: Add MobileMiniBrowser as a Module for iOS builds.
119         * MobileMiniBrowser/Configurations/Base.xcconfig: Added.
120         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Added.
121         * MobileMiniBrowser/Configurations/MobileMiniBrowser.xcconfig: Added.
122         * MobileMiniBrowser/Makefile: Added.
123         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj: Added.
124         * MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h: Added.
125         * MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m: Added.
126         (-[AppDelegate application:didFinishLaunchingWithOptions:]):
127         (-[AppDelegate applicationWillResignActive:]):
128         (-[AppDelegate applicationDidEnterBackground:]):
129         (-[AppDelegate applicationWillEnterForeground:]):
130         (-[AppDelegate applicationDidBecomeActive:]):
131         (-[AppDelegate applicationWillTerminate:]):
132         * MobileMiniBrowser/MobileMiniBrowser/Assets.xcassets/AppIcon.appiconset/Contents.json: Added.
133         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard: Added.
134         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard: Added.
135         * MobileMiniBrowser/MobileMiniBrowser/Info.plist: Added.
136         * MobileMiniBrowser/MobileMiniBrowser/TabViewController.h: Added.
137         * MobileMiniBrowser/MobileMiniBrowser/TabViewController.m: Added.
138         (-[TabViewController dealloc]):
139         (-[TabViewController viewDidLoad]):
140         (-[TabViewController observeValueForKeyPath:ofObject:change:context:]):
141         (-[TabViewController tableView:cellForRowAtIndexPath:]):
142         (-[TabViewController tableView:numberOfRowsInSection:]):
143         (-[TabViewController numberOfSectionsInTableView:]):
144         (-[TabViewController tableView:canEditRowAtIndexPath:]):
145         (-[TabViewController tableView:canMoveRowAtIndexPath:]):
146         (-[TabViewController tableView:commitEditingStyle:forRowAtIndexPath:]):
147         (-[TabViewController tableView:didSelectRowAtIndexPath:]):
148         * MobileMiniBrowser/MobileMiniBrowser/WebViewController.h: Added.
149         * MobileMiniBrowser/MobileMiniBrowser/WebViewController.m: Added.
150         (-[WebViewController viewDidLoad]):
151         (-[WebViewController didReceiveMemoryWarning]):
152         (-[WebViewController reload:]):
153         (-[WebViewController goBack:]):
154         (-[WebViewController goForward:]):
155         (-[WebViewController urlFieldEditingBegan:]):
156         (-[WebViewController navigateTo:]):
157         (-[WebViewController showTabs:]):
158         (-[WebViewController selectWebViewAtIndex:]):
159         (-[WebViewController removeWebViewAtIndex:]):
160         (-[WebViewController addWebView]):
161         (-[WebViewController createWebView]):
162         (-[WebViewController removeWebView:]):
163         (-[WebViewController setCurrentWebView:]):
164         (-[WebViewController webView:didFailNavigation:withError:]):
165         (-[WebViewController observeValueForKeyPath:ofObject:change:context:]):
166         * MobileMiniBrowser/MobileMiniBrowser/main.m: Added.
167         (main):
168         * MobileMiniBrowser/MobileMiniBrowserUITests/Info.plist: Added.
169         * MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m: Added.
170         (-[MobileMiniBrowserUITests setUp]):
171         (-[MobileMiniBrowserUITests tearDown]):
172         (-[MobileMiniBrowserUITests testBasicVideoPlayback]):
173
174 2016-08-26  Aakash Jain  <aakash_jain@apple.com>
175
176         webkit-queues queue-status page should should list more recent statuses
177         https://bugs.webkit.org/show_bug.cgi?id=161220
178
179         Reviewed by Daniel Bates.
180
181         * QueueStatusServer/handlers/queuestatus.py:
182         (QueueStatus._fetch_statuses): Increase the number of recent statuses from 15 to 50.
183
184 2016-08-26  Dan Bernstein  <mitz@apple.com>
185
186         [Cocoa] Infinite recursion calling -charValue on a WKNSNumber
187         https://bugs.webkit.org/show_bug.cgi?id=161258
188
189         Reviewed by Anders Carlsson.
190
191         * TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm:
192         (TestWebKitAPI::TEST):
193
194 2016-08-26  Csaba Osztrogonác  <ossy@webkit.org>
195
196         Fix the ENABLE(WEBASSEMBLY) build on Linux
197         https://bugs.webkit.org/show_bug.cgi?id=161197
198
199         Reviewed by Mark Lam.
200
201         * Scripts/build-jsc:
202
203 2016-08-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
204
205         [GTK] run-gtk-tests should use the driver environment for checking the accessibility bus
206         https://bugs.webkit.org/show_bug.cgi?id=161149
207
208         Reviewed by Carlos Garcia Campos.
209
210         Add a new function for waiting for the accesibility bus. It sets
211         the test environment variables before starting the GLib mainloop.
212         And restores the previous environment after it has finished.
213         It also adds a timeout (5 seconds) to abort in case it has not
214         been able to detect the accesibility bus before the timeout expires.
215
216         * Scripts/run-gtk-tests:
217         (TestRunner):
218         (TestRunner._wait_for_accessibility_bus):
219         (TestRunner._wait_for_accessibility_bus.timeout_accessibility_bus):
220         (TestRunner._start_accessibility_daemons):
221         (TestRunner._get_tests_from_google_test_suite): Run this command also with the driver test environment.
222
223 2016-08-26  Per Arne Vollan  <pvollan@apple.com>
224
225         [Win] Warning fix.
226         https://bugs.webkit.org/show_bug.cgi?id=161236
227
228         Reviewed by Brent Fulgham.
229
230         The & operator in the Test struct has no body.
231
232         * TestWebKitAPI/Tests/WTF/Vector.cpp:
233         (TestWebKitAPI::TEST):
234
235 2016-08-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
236
237         [GTK] run-gtk-tests should use webkitpy.port.gtk and webkitpy.port.xvfbdriver
238         https://bugs.webkit.org/show_bug.cgi?id=160736
239
240         Reviewed by Carlos Garcia Campos.
241
242         This plugs run-gtk-tests into the webkitpy testing infrastructure.
243         As a benefit of this, run-gtk-tests now can be executed over any of
244         the existing supported gtk test display servers (xvfb, weston-over-xvfb,
245         or native xorg). A new command line switch --wayland is added for
246         run-gtk-tests.
247
248         * Scripts/run-gtk-tests:
249         (TestRunner.__init__): Remove the --display command line switch, its not longer useful.
250         Add a --wayland command line switch.
251         (TestRunner._start_accessibility_daemons):
252         (TestRunner):
253         (TestRunner.__init__):
254         (TestRunner._run_xvfb): Deleted.
255         (TestRunner._create_driver):
256         (TestRunner._setup_testing_environment): Delete the environment variable definitions that
257         are now done by driver._setup_environ_for_test().
258         (TestRunner._tear_down_testing_environment):
259         * Scripts/webkitpy/port/driver.py:
260         (Driver.__init__): Define self._server_name in the constructor of the base class.
261         It is used by several functions, so it makes sense to store once the value here.
262         (Driver._setup_environ_for_test): Factorize setting the environment for a given test.
263         (Driver._start): Get the environment from self._setup_environ_for_test()
264         * Scripts/webkitpy/port/driver_unittest.py:
265         (DriverTest):
266         (DriverTest.test_setup_environ_for_test): Add unittest for driver._setup_environ_for_test()
267         * Scripts/webkitpy/port/gtk.py: Move the inspection of the env var USE_NATIVE_XDISPLAY to the constructor.
268         (GtkPort.__init__):
269         (GtkPort._driver_class):
270         * Scripts/webkitpy/port/westondriver.py: Define and use self._setup_environ_for_test()
271         (WestonDriver._setup_environ_for_test):
272         (WestonDriver._start):
273         * Scripts/webkitpy/port/xorgdriver.py: Define and use self._setup_environ_for_test()
274         (XorgDriver._setup_environ_for_test):
275         (XorgDriver._start):
276         * Scripts/webkitpy/port/xvfbdriver.py: Define and use self._setup_environ_for_test()
277         (XvfbDriver._setup_environ_for_test):
278         (XvfbDriver._start):
279
280 2016-08-26  Csaba Osztrogonác  <ossy@webkit.org>
281
282         [EFL][GTK] REGRESSION(204877): Fix the clean build
283         https://bugs.webkit.org/show_bug.cgi?id=161240
284
285         Reviewed by Carlos Garcia Campos.
286
287         * WebKitTestRunner/PlatformEfl.cmake:
288         * WebKitTestRunner/PlatformGTK.cmake:
289
290 2016-08-26  Aakash Jain  <aakash_jain@apple.com>
291
292         EWS should indicate which bot processed the patch
293         https://bugs.webkit.org/show_bug.cgi?id=161222
294
295         Reviewed by Daniel Bates.
296
297         * QueueStatusServer/handlers/statusbubble.py:
298         (StatusBubble._build_bubble): Display the bot id in status bubble. Also removed "Started processing" message since
299         after bug fix of 161223, bots send the "Started processing patch" message and it would be displayed in Recent messages.
300         Also added "Started processing patch" message to progress_statuses.
301         I might consider displaying bot id in other statuses as well later on.
302
303 2016-08-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
304
305         [EFL] Change homepage url to www.ewebkit.org on MiniBrowser
306         https://bugs.webkit.org/show_bug.cgi?id=161184
307
308         Reviewed by Carlos Garcia Campos.
309
310         * MiniBrowser/efl/main.c: Set www.ewebkit.org.
311
312 2016-08-25  Aakash Jain  <aakash_jain@apple.com>
313
314         ews queues should update status server when they start processing patch
315         https://bugs.webkit.org/show_bug.cgi?id=161223
316
317         Reviewed by Daniel Bates.
318
319         * Scripts/webkitpy/tool/commands/queues.py:
320         (AbstractReviewQueue.process_work_item): Update status server that the bot started processing the patch.
321         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
322         (EarlyWarningSystemTest._default_expected_logs): Updated the unit test accordingly.
323         * Scripts/webkitpy/tool/commands/queues_unittest.py:
324         (StyleQueueTest.test_style_queue_with_style_exception): Same.
325         (test_style_queue_with_watch_list_exception): Same.
326         (test_non_valid_patch): Same.
327
328 2016-08-25  Alex Christensen  <achristensen@webkit.org>
329
330         CMake build fix.
331
332         * DumpRenderTree/PlatformMac.cmake:
333
334 2016-08-25  Alex Christensen  <achristensen@webkit.org>
335
336         Fix URLParserTest with GuardMalloc
337         https://bugs.webkit.org/show_bug.cgi?id=161214
338         rdar://problem/28014390
339
340         Reviewed by Tim Horton.
341
342         The CString returned by String::utf8 was going out of scope before we were doing a string comparison on its data.
343         This just does the comparison of the CStrings instead to keep them in scope during the comparison.
344
345         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
346         (TestWebKitAPI::eq):
347         (TestWebKitAPI::checkURL):
348         (TestWebKitAPI::checkURLDifferences):
349         (TestWebKitAPI::s): Deleted.
350
351 2016-08-25  Wenson Hsieh  <wenson_hsieh@apple.com>
352
353         Dragging against the end of the inline media scrubber causes the media scrubber to hide
354         https://bugs.webkit.org/show_bug.cgi?id=161207
355
356         Reviewed by Eric Carlson.
357
358         Tweaks an existing WebKit API test covering this behavior change. After some discussion, rather than hide media
359         controls in this case, we should actually continue showing them. This is because seeking due to user gestures
360         similar to "scrubbing" are indistinguishable from gestures that immediately seek to the end.
361
362         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
363         (TestWebKitAPI::TEST):
364
365 2016-08-25  Daniel Bates  <dabates@apple.com>
366
367         Watch more things.
368
369         * Scripts/webkitpy/common/config/watchlist:
370
371 2016-08-25  Daniel Bates  <dabates@apple.com>
372
373         Fix test failure on GTK Linux bots after <http://trac.webkit.org/changeset/204695>
374         (https://bugs.webkit.org/show_bug.cgi?id=148437)
375
376         Remove use of module File::Slurp as it is not part of the standard Perl 5 distribution
377         and is not installed on the GTK Linux bots.
378
379         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
380         (writeFileWithContent): Added.
381
382 2016-08-25  Per Arne Vollan  <pvollan@apple.com>
383
384         [Win] run-api-tests is failing.
385         https://bugs.webkit.org/show_bug.cgi?id=161140
386
387         Reviewed by Brent Fulgham.
388
389         Since the move constructor is called 3 more times on Windows, we will have 3 more destructor calls.
390
391         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
392         (TestWebKitAPI::TEST):
393
394 2016-08-24  Per Arne Vollan  <pvollan@apple.com>
395
396         [Win] run-api-tests is failing.
397         https://bugs.webkit.org/show_bug.cgi?id=161140
398
399         Reviewed by Brent Fulgham.
400
401         The number of times the move constructor is called is different on Windows in this test. This seems
402         to be caused by differences in MSVC's implementation of lambdas or std functions like std::make_tuple.
403
404         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
405         (TestWebKitAPI::TEST):
406
407 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
408
409         Fix iOS DRT build.
410
411         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
412         (WTR::UIScriptController::zoomToScale):
413
414 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
415
416         [iOS DRT] Hook up uiController.zoomToScale() for DRT
417         https://bugs.webkit.org/show_bug.cgi?id=161173
418
419         Reviewed by Tim Horton.
420         
421         Make a UIWebScrollView subclass, DumpRenderTreeWebScrollView, which has an internal delegate to get
422         UIScrollView delegate callbacks. Store the zoomToScaleCompletionHandler on it.
423         
424         UIScriptController::zoomToScale() has to bounce the zoom to the main thread (no poking UIKit from
425         the WebThread!), but queue up the callback first.
426
427         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
428         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
429         (-[DumpRenderTreeWebScrollView initWithFrame:]):
430         (-[DumpRenderTreeWebScrollView dealloc]):
431         (-[DumpRenderTreeWebScrollView zoomToScale:animated:completionHandler:]):
432         (-[DumpRenderTreeWebScrollView completedZoomToScale]):
433         (-[DumpRenderTreeWebScrollViewDelegate initWithScrollView:]):
434         (-[DumpRenderTreeWebScrollViewDelegate viewForZoomingInScrollView:]): All UIScrollView delegates need to implement this.
435         (-[DumpRenderTreeWebScrollViewDelegate scrollViewDidEndZooming:withView:atScale:]):
436         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
437         (WTR::UIScriptController::zoomToScale):
438         * DumpRenderTree/mac/DumpRenderTree.mm:
439         (createWebViewAndOffscreenWindow):
440         * TestRunnerShared/UIScriptContext/UIScriptController.h:
441         (WTR::UIScriptController::context):
442
443 2016-08-24  Ryan Haddad  <ryanhaddad@apple.com>
444
445         Attempt to fix Windows build after r204918.
446
447         Unreviewed build fix.
448
449         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
450         (ResourceLoadDelegate::willSendRequest):
451
452 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
453
454         [iOS DRT] Get basic viewport tests working in DRT
455         https://bugs.webkit.org/show_bug.cgi?id=161160
456
457         Reviewed by Tim Horton.
458         
459         Hook up enough of UIScriptController in iOS DRT to be able to read viewport
460         scale, and get the contentVisibleRect.
461         
462         Requires exposing a bit of UIWebBrowserView SPI from UIKit, which in turn
463         requires typing the gWebBrowserView as a DumpRenderTreeBrowserView * everywhere.
464         
465         One test has different results between DRT and WTR, but DRT behavior seems to differ
466         from UIWebView here, so just give it a WK1-specific result.
467
468         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
469         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
470         (-[DumpRenderTreeBrowserView documentVisibleRect]):
471         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
472         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
473         (WTR::UIScriptController::zoomScale):
474         (WTR::UIScriptController::minimumZoomScale):
475         (WTR::UIScriptController::maximumZoomScale):
476         (WTR::UIScriptController::contentVisibleRect):
477         * DumpRenderTree/mac/DumpRenderTree.mm:
478         (createWebViewAndOffscreenWindow):
479         * DumpRenderTree/mac/DumpRenderTreeMac.h:
480
481 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
482
483         Minor project rearrangement.
484
485         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
486
487 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
488
489         [iOS DRT] Make iOS DRT use the same window size as WebKitTestRunner for flexible viewport tests
490         https://bugs.webkit.org/show_bug.cgi?id=161124
491
492         Reviewed by Daniel Bates.
493         
494         Use the main UIScreen's bounds for the size of the window in flexible viewport mode,
495         and remove the 'phoneBrowserAddressBarOffset' hack, so that it matches WTR.
496         
497         Remove some unnecessary zero initializations of static variables.
498         
499         Change _setVisibleSize to use the window size, which should not be a behavior change
500         because this it just used for text autosizing, which is disabled by default,
501         and only the width is consulted.
502
503         * DumpRenderTree/mac/DumpRenderTree.mm:
504         (adjustWebDocumentForFlexibleViewport):
505         (adjustWebDocumentForStandardViewport):
506         (createWebViewAndOffscreenWindow):
507
508 2016-08-24  Jonathan Bedard  <jbedard@apple.com>
509
510         WebKit2 needs layoutTestController.setDeferMainResourceDataLoad
511         https://bugs.webkit.org/show_bug.cgi?id=42777
512
513         Reviewed by Darin Adler.
514
515         The setDeferMainResourceDataLoad method was not correctly tested in DumpRenderTree and would pass even when setDeterMainResourceDataLoad was not called.  Removed function and test.
516
517         * DumpRenderTree/TestRunner.cpp:
518         (setDeferMainResourceDataLoadCallback): Removed setDeferMainResourceDataLoad.
519         * DumpRenderTree/TestRunner.h:
520         (TestRunner::deferMainResourceDataLoad): Ditto.
521         (TestRunner::setDeferMainResourceDataLoad): Ditto.
522         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Ditto.
523
524 2016-08-23  Anders Carlsson  <andersca@apple.com>
525
526         Add enum traits and use them in the IPC::Decoder
527         https://bugs.webkit.org/show_bug.cgi?id=161103
528
529         Reviewed by Sam Weinig.
530
531         Add API test.
532
533         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
534         * TestWebKitAPI/Tests/WTF/EnumTraits.cpp: Added.
535         (TestWebKitAPI::TEST):
536
537 2016-08-24  Filip Pizlo  <fpizlo@apple.com>
538
539         Unreviewed, roll out r204901, r204897, r204866, r204856, r204854.
540
541         * DumpRenderTree/TestRunner.cpp:
542         * DumpRenderTree/mac/DumpRenderTree.mm:
543         (DumpRenderTreeMain):
544         * Scripts/run-jsc-stress-tests:
545         * TestWebKitAPI/Tests/WTF/Vector.cpp:
546         (TestWebKitAPI::TEST):
547
548 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
549
550         Try to fix Production builds.
551         
552         PRODUCTION_FRAMEWORKS_DIR was undefined here.
553
554         * DumpRenderTree/mac/Configurations/Base.xcconfig:
555
556 2016-08-24  Dan Bernstein  <mitz@apple.com>
557
558         Add a convenience function for creating a WKFrameHandleRef from a WKFrameRef without going through WKFrameInfoRef
559         https://bugs.webkit.org/show_bug.cgi?id=161152
560
561         Reviewed by Anders Carlsson.
562
563         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
564         * TestWebKitAPI/Tests/WebKit2/FrameHandle.cpp: Added.
565         (TestWebKitAPI::didFinishLoadForFrame):
566         (TestWebKitAPI::TEST):
567
568 2016-08-24  Nan Wang  <n_wang@apple.com>
569
570         AX: Add test for line text marker range on iOS
571         https://bugs.webkit.org/show_bug.cgi?id=161108
572         <rdar://problem/27976405>
573
574         Reviewed by Chris Fleizach.
575
576         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
577         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
578         (AccessibilityUIElement::textMarkerRangeForElement):
579         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
580         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
581         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
582
583 2016-08-24  Per Arne Vollan  <pvollan@apple.com>
584
585         [Win] Warning fixes.
586         https://bugs.webkit.org/show_bug.cgi?id=161079
587
588         Reviewed by Brent Fulgham.
589
590         * MiniBrowser/win/WebDownloadDelegate.cpp:
591         * MiniBrowser/win/WinMain.cpp:
592         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
593         (TestWebKitAPI::TEST):
594
595 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
596
597         Fix Windows DRT build.
598
599         * DumpRenderTree/win/TestRunnerWin.cpp:
600         (TestRunner::mainFrameJSContext):
601
602 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
603
604         Try to fix Windows build.
605         
606         Pass Tools/DumpRenderTree/Bindings as the working directory for the generate_bindings.pl
607         so that perl finds CodeGeneratorDumpRenderTree.pm.
608
609         * DumpRenderTree/CMakeLists.txt:
610
611 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
612
613         Hook up UIScriptController in DumpRenderTree
614         https://bugs.webkit.org/show_bug.cgi?id=161064
615
616         Reviewed by Sam Weinig.
617
618         Add a skeleton implementation of UIScriptController to DumpRenderTree, building for both
619         Mac and iOS. Currently this is sufficient to test doAsyncTask(), enabling two tests
620         in fast/harness which test this.
621
622         Add a DerivedSources target to DumpRenderTree to invoke DerivedSources.make.
623
624         Move related code shared between WTR and DRT into Tools/TestRunnerShared, and cleanse it of
625         WK2-isms. Fix the makefiles to refer to the new location.
626
627         Hook up TestRunner::runUIScript() for DumpRenderTree, which requires keeping track of callbacks
628         by ID and firing them once they are complete.
629
630         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm: Added (copied from WTR).
631         * DumpRenderTree/CMakeLists.txt:
632         * DumpRenderTree/DerivedSources.make: Copied from Tools/WebKitTestRunner/DerivedSources.make.
633         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
634         * DumpRenderTree/TestRunner.cpp:
635         (runUIScriptCallback):
636         (TestRunner::staticFunctions):
637         (TestRunner::cacheTestRunnerCallback):
638         (TestRunner::callTestRunnerCallback):
639         (TestRunner::clearTestRunnerCallbacks):
640         (nextUIScriptCallbackID):
641         (TestRunner::runUIScript):
642         (TestRunner::callUIScriptCallback):
643         (TestRunner::uiScriptDidComplete):
644         (TestRunner::cleanup):
645         * DumpRenderTree/TestRunner.h:
646         * DumpRenderTree/ios/UIScriptControllerIOS.mm: Added.
647         * DumpRenderTree/mac/Configurations/Base.xcconfig: DerivedSources.make needs WEBCORE_PRIVATE_HEADERS_DIR to be defined.
648         * DumpRenderTree/mac/DumpRenderTree.mm:
649         (runTest):
650         * DumpRenderTree/mac/TestRunnerMac.mm:
651         (TestRunner::mainFrameJSContext):
652         * DumpRenderTree/mac/UIScriptControllerMac.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h.
653         (WTR::UIScriptController::doAsyncTask):
654         * DumpRenderTree/win/DumpRenderTree.cpp:
655         * TestRunnerShared/Bindings/JSWrappable.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h.
656         (WTR::JSWrappable::~JSWrappable):
657         (WTR::JSValueMakeStringOrNull):
658         * TestRunnerShared/Bindings/JSWrapper.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp.
659         (WTR::JSWrapper::wrap):
660         (WTR::JSWrapper::unwrap):
661         (WTR::unwrapObject):
662         (WTR::JSWrapper::initialize):
663         (WTR::JSWrapper::finalize):
664         * TestRunnerShared/Bindings/JSWrapper.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h.
665         (WTR::toJS):
666         (WTR::setProperty):
667         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: Renamed from Tools/WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl.
668         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptContext.cpp.
669         * TestRunnerShared/UIScriptContext/UIScriptContext.h: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptContext.h.
670         (WTR::UIScriptContext::currentParentCallbackIsPendingCompletion):
671         * TestRunnerShared/UIScriptContext/UIScriptController.cpp: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptController.cpp.
672         * TestRunnerShared/UIScriptContext/UIScriptController.h: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptController.h.
673         * WebKitTestRunner/CMakeLists.txt:
674         * WebKitTestRunner/DerivedSources.make:
675         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
676         (WTR::JSWrappable::~JSWrappable): Deleted.
677         (WTR::JSValueMakeStringOrNull): Deleted.
678         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
679         (WTR::JSWrapper::wrap): Deleted.
680         (WTR::JSWrapper::unwrap): Deleted.
681         (WTR::unwrapObject): Deleted.
682         (WTR::JSWrapper::initialize): Deleted.
683         (WTR::JSWrapper::finalize): Deleted.
684         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:
685         (WTR::toJS): Deleted.
686         (WTR::setProperty): Deleted.
687         * WebKitTestRunner/TestInvocation.cpp:
688         (WTR::TestInvocation::runUISideScript):
689         (WTR::TestInvocation::uiScriptDidComplete):
690         * WebKitTestRunner/TestInvocation.h:
691         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp: Moved
692         * WebKitTestRunner/UIScriptContext/UIScriptContext.h: Moved
693         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp: Moved
694         * WebKitTestRunner/UIScriptContext/UIScriptController.h: Moved
695         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
696         * WebKitTestRunner/config.h:
697         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
698         (WTR::UIScriptController::contentVisibleRect):
699
700 2016-08-23  Saam Barati  <sbarati@apple.com>
701
702         JSC should have a "microbenchmarks" directory instead of "regress" directory
703         https://bugs.webkit.org/show_bug.cgi?id=161096
704
705         Rubber stamped by Mark Lam.
706
707         This patch moves LayoutTests/js/regress/script-tests to the JSTests/microbenchmarks
708         directory and removes all the related html and txt files. I did this because
709         that directory was only there for microbenchmarks, and not for "regression"
710         tests. I also changed the various scripts to point to it.
711
712         * Scripts/run-javascriptcore-tests:
713         (runJSCStressTests):
714         * Scripts/run-jsc-benchmarks:
715
716 2016-08-23  Alex Christensen  <achristensen@webkit.org>
717
718         Fix EFL build.
719
720         * TestWebKitAPI/CMakeLists.txt:
721         Include new directory.
722
723 2016-08-22  Filip Pizlo  <fpizlo@apple.com>
724
725         Butterflies should be allocated in Auxiliary MarkedSpace instead of CopiedSpace and we should rewrite as much of the GC as needed to make this not a regression
726         https://bugs.webkit.org/show_bug.cgi?id=160125
727
728         Reviewed by Geoffrey Garen.
729
730         * DumpRenderTree/TestRunner.cpp: Rewire some #includes.
731         * Scripts/run-jsc-stress-tests: New test flag!
732
733 2016-08-23  Brady Eidson  <beidson@apple.com>
734
735         WK2 Gamepad layout test support.
736         https://bugs.webkit.org/show_bug.cgi?id=134671
737
738         Reviewed by Alex Christensen.
739         
740         Have the injected bundle expose the MockGamepadProvider to the UI process, which will then 
741         feed back into the UIGamepadProvider.
742         
743         Also, fool NSApplication into treating the most recently created "isKeyWindow" of the test windows
744         as the actual keyWindow for the test runner, which will allow the view to get gamepad updates.
745
746         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
747         
748         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
749         (WTR::TestRunner::setMockGamepadDetails):
750         (WTR::TestRunner::setMockGamepadAxisValue):
751         (WTR::TestRunner::setMockGamepadButtonValue):
752         
753         * WebKitTestRunner/PlatformWebView.h:
754         
755         * WebKitTestRunner/TestController.cpp:
756         (WTR::TestController::initialize):
757         
758         * WebKitTestRunner/TestInvocation.cpp:
759         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
760         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Deleted.
761         
762         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
763         
764         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
765         (-[WebKitTestRunnerWindow initWithFrame:]):
766         (-[WebKitTestRunnerWindow dealloc]):
767         (WTR::PlatformWebView::keyWindow):
768         
769         * WebKitTestRunner/ios/TestControllerIOS.mm:
770         (WTR::wtr_NSApplication_keyWindow):
771         (WTR::TestController::platformInitialize):
772         
773         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
774         (+[WebKitTestRunnerWindow _WTR_keyWindow]):
775         (-[WebKitTestRunnerWindow initWithContentRect:styleMask:backing:defer:]):
776         (-[WebKitTestRunnerWindow dealloc]):
777         (WTR::PlatformWebView::keyWindow):
778         
779         * WebKitTestRunner/mac/TestControllerMac.mm:
780         (WTR::wtr_NSApplication_keyWindow):
781         (WTR::TestController::platformInitialize):
782         * WebKitTestRunner/mac/main.mm:
783
784 2016-08-23  Alexey Proskuryakov  <ap@apple.com>
785
786         REGRESSION (PHP 5.6): http/tests/misc/bad-charset-alias.html fails
787         https://bugs.webkit.org/show_bug.cgi?id=161047
788         rdar://problem/27434307
789
790         Reviewed by Lucas Forschler.
791
792         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: Specify a php.ini file.
793
794 2016-08-23  Chris Dumez  <cdumez@apple.com>
795
796         Unreviewed, rolling out r204243.
797
798         Caused some layout test failures
799
800         Reverted changeset:
801
802         "Write API test to cover crash fix in r204135"
803         https://bugs.webkit.org/show_bug.cgi?id=160587
804         http://trac.webkit.org/changeset/204243
805
806 2016-08-23  Rawinder Singh  <rawinder.singh-webkit@cisra.canon.com.au>
807
808         Order feature option list in FeatureList.pm
809         https://bugs.webkit.org/show_bug.cgi?id=161074
810
811         Reviewed by Michael Catanzaro.
812
813         Reorder features in alphabetical order based on command line option. Also, sort variables in alphabetical order.
814
815         * Scripts/webkitperl/FeatureList.pm:
816
817 2016-08-22  Dewei Zhu  <dewei_zhu@apple.com>
818
819         Stop python icon bouncing in the dock while running browser benchmarks.
820         https://bugs.webkit.org/show_bug.cgi?id=161066
821
822         Reviewed by Ryosuke Niwa.
823
824         Bouncing python icon may impact browser benchmark results.
825         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
826         (OSXBrowserDriver.prepare_env):
827         (OSXBrowserDriver.restore_env):
828
829 2016-08-22  Simon Fraser  <simon.fraser@apple.com>
830
831         <select> menu on iPad causes shifting of hit-testing areas
832         https://bugs.webkit.org/show_bug.cgi?id=150079
833
834         Reviewed by Tim Horton.
835
836         -isAssistingNode (aka the poorly named isEditable) is input into WebPageProxy::computeCustomFixedPositionRect(),
837         so when it changes we have to update visible rects. We were doing this on focus, but failing
838         to do it on blur.
839
840         Added the ability to test by:
841         1. Making it possible to initiate an animated scroll in the UI process
842         2. Adding callbacks for starting and ending interaction with a form control. Sadly
843         the "ending interaction" for <select> popovers on iPad isn't late enough, since we
844         have no way currently to know when the dimming view behind the popover animates out,
845         so for now the test keeps trying to tap a button.
846
847         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
848         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
849         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
850         (WTR::UIScriptController::setDidStartFormControlInteractionCallback):
851         (WTR::UIScriptController::didStartFormControlInteractionCallback):
852         (WTR::UIScriptController::setDidEndFormControlInteractionCallback):
853         (WTR::UIScriptController::didEndFormControlInteractionCallback):
854         (WTR::UIScriptController::scrollToOffset):
855         (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
856         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
857         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
858         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
859         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
860         (-[TestRunnerWKWebView dealloc]):
861         (-[TestRunnerWKWebView didStartFormControlInteraction]):
862         (-[TestRunnerWKWebView didEndFormControlInteraction]):
863         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
864         (WTR::contentOffsetBoundedInValidRange):
865         (WTR::UIScriptController::scrollToOffset):
866         (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
867         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
868
869 2016-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
870
871         [EFL][GTK] Script process-linux-coredump is not needed, switch back to use the kernel core dumper instead.
872         https://bugs.webkit.org/show_bug.cgi?id=160927
873
874         Reviewed by Daniel Bates.
875
876         * Scripts/process-linux-coredump: Removed.
877         * Scripts/webkitpy/port/efl.py:
878         (EflPort._get_crash_log):
879         * Scripts/webkitpy/port/gtk.py:
880         (GtkPort._get_crash_log):
881         * Scripts/webkitpy/port/linux_get_crash_log.py:
882         (GDBCrashLogGenerator.__init__):
883         (GDBCrashLogGenerator.generate_crash_log):
884         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
885         (GDBCrashLogGeneratorTest.test_generate_crash_log):
886
887 2016-08-22  Jonathan Bedard  <jbedard@apple.com>
888
889         check-webkit-style does not work with Lambda functions in C++
890         https://bugs.webkit.org/show_bug.cgi?id=160910
891
892         Reviewed by Darin Adler.
893
894         This change eliminates false positives on correctly styled lambda functions and includes a few basic checks on capture list.
895
896         * Scripts/webkitpy/style/checkers/cpp.py:
897         (regex_for_lambda_functions): Added function which checks if a string is the start of a lambda function.
898         (check_for_non_standard_constructs): Added lambda function check.
899         (check_spacing_for_function_call): Added lambda function check.
900         (check_braces): Added lambda function check.
901         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
902         (CppStyleTest.test_lambda_functions): Added test function for lambda function style checks.
903
904 2016-08-21  Alex Christensen  <achristensen@webkit.org>
905
906         URLParser should parse IPv4 addresses
907         https://bugs.webkit.org/show_bug.cgi?id=161023
908
909         Reviewed by Darin Adler.
910
911         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
912         (TestWebKitAPI::TEST_F):
913         (TestWebKitAPI::checkURLDifferences):
914         We are already getting differences between the old URL::parse and the new URLParser.
915         (TestWebKitAPI::shouldFail):
916
917 2016-08-21  Daniel Bates  <dabates@apple.com>
918
919         prepare-ChangeLog lists unmodified functions as modified and marks functions with few changes as deleted
920         https://bugs.webkit.org/show_bug.cgi?id=148437
921
922         Reviewed by Dan Bernstein.
923
924         * Scripts/prepare-ChangeLog:
925         (diffCommand): When using a Subversion checkout, generate a unified diff without any context lines.
926         This matches our behavior when using a Git checkout. The function overlap logic in generateFunctionListsByRanges()
927         assumes that its line ranges were from a unified diff without any context lines.
928         (extractLineRangeAfterChange): A deleted line should be represented with a ("begin line number", "end line number") = ("new starting line number", "new starting line number").
929         (extractLineRangeBeforeChange): An added line should be represented with a ("begin line number", "end line number") = ("original starting line number", "original starting line number").
930         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Update expected results
931         based on changes to extractLineRangeAfterChange() and extractLineRangeBeforeChange().
932         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl: Added.
933         (discardOutput): Convenience function invokes the specified function redirecting standard output and standard error
934         to /dev/null for the duration of the function call.
935
936 2016-08-20  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
937
938         [EFL] Remove unnecessary a patch to mute ecore warnings
939         https://bugs.webkit.org/show_bug.cgi?id=160997
940
941         Reviewed by Darin Adler.
942
943         There is no warning messages during the layout test and perf test
944         after bumping efl version from 1.17 to 1.18. Remove it.
945
946         * efl/patches/ecore_remove_warnings.patch: Removed.
947
948 2016-08-20  Simon Fraser  <simon.fraser@apple.com>
949
950         REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
951         https://bugs.webkit.org/show_bug.cgi?id=160985
952
953         Re-land r204672, but don't check the result of 'xcrun simctl shutdown', because
954         device shutdown seems to happen as result of killing Simulator.apps, and we're racing
955         with that.
956
957         * Scripts/webkitpy/layout_tests/views/printing.py:
958         (Printer.print_config):
959         * Scripts/webkitpy/port/base.py:
960         (Port.driver_cmd_line_for_logging):
961         (Port.driver_cmd_line): Deleted.
962         * Scripts/webkitpy/port/driver.py:
963         (IOSSimulatorDriver.cmd_line):
964         * Scripts/webkitpy/port/ios.py:
965         (IOSSimulatorPort.__init__):
966         (IOSSimulatorPort.driver_cmd_line_for_logging):
967         (IOSSimulatorPort._create_simulators):
968         (IOSSimulatorPort.setup_test_run):
969         (IOSSimulatorPort._quit_ios_simulator):
970         (IOSSimulatorPort.clean_up_test_run):
971         (IOSSimulatorPort._create_device):
972         (IOSSimulatorPort):
973         (IOSSimulatorPort._remove_device):
974         (IOSSimulatorPort._testing_device):
975         (IOSSimulatorPort.device_id_for_worker_number):
976         (IOSSimulatorPort._set_device_class): Deleted.
977         (IOSSimulatorPort.testing_device): Deleted.
978         * Scripts/webkitpy/port/port_testcase.py:
979         (PortTestCase.test_driver_cmd_line):
980         * Scripts/webkitpy/xcode/simulator.py:
981         (Device.shutdown):
982         (Device):
983         (Device.delete):
984         (Device.reset):
985         (Simulator):
986         (Simulator.create_device):
987         (Simulator.remove_device):
988         (Simulator.device_number):
989         (Simulator.device_state_description):
990         (Simulator.wait_until_device_is_in_state):
991
992 2016-08-19  Ryan Haddad  <ryanhaddad@apple.com>
993
994         Unreviewed, rolling out r204659.
995
996         This change appears to have caused ios-simulator LayoutTests
997         to fail when shutting down the simulator
998
999         Reverted changeset:
1000
1001         "REGRESSION (r204477): Running LayoutTests on ios-simulator
1002         became ~15 minutes slower"
1003         https://bugs.webkit.org/show_bug.cgi?id=160985
1004         http://trac.webkit.org/changeset/204659
1005
1006 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
1007
1008         Build fix for non-USE_SIM_SERVICE_CONTEXT builds
1009         * LayoutTestRelay/LayoutTestRelay/main.m: (main):
1010
1011 2016-08-18  Simon Fraser  <simon.fraser@apple.com>
1012
1013         REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
1014         https://bugs.webkit.org/show_bug.cgi?id=160985
1015
1016         Reviewed by Alexey Proskuryakov.
1017         
1018         r204477 removed @memoized on a couple of ios.py functions, causing them to instantiate
1019         a Simulator() on every call, which causes 'xcrun simctl list' to run. The functions
1020         must not be @memoized, because their return value depends on the value of simulator_device_type().
1021         
1022         Fix by adding some global state in simulator.py that tracks the created devices 
1023         in a worker number -> Device dictionary. Explicitly create devices in _create_simulators(),
1024         and delete them in clean_up_test_run().
1025         
1026         Also explicitly called 'xcrun simctl shutdown' to shut down devices, since it seems
1027         that killing the Simulator apps isn't enough.
1028         
1029         Simulator tracks the devices in a global dictionary, since state needs to persist
1030         across different instances of IOSSimulatorPort.
1031         
1032         Annoyingly, the "Command line:" dumping tried to access a device before we'd done
1033         any setup. Rather than implicitly creating a device here (which the old code did),
1034         override the more clearly named driver_cmd_line_for_logging() in IOSSimulatorPort
1035         and set flag to say that device_id_for_worker_number() doesn't need to return a real
1036         device id.
1037
1038         * Scripts/webkitpy/layout_tests/views/printing.py:
1039         (print_options):
1040         (Printer.print_config):
1041         * Scripts/webkitpy/port/base.py:
1042         (Port.driver_cmd_line_for_logging):
1043         (Port.driver_cmd_line): Deleted.
1044         * Scripts/webkitpy/port/driver.py:
1045         (IOSSimulatorDriver.cmd_line):
1046         * Scripts/webkitpy/port/ios.py:
1047         (IOSSimulatorPort.__init__):
1048         (IOSSimulatorPort.driver_cmd_line_for_logging):
1049         (IOSSimulatorPort._create_simulators):
1050         (IOSSimulatorPort.setup_test_run):
1051         (IOSSimulatorPort.clean_up_test_run):
1052         (IOSSimulatorPort._create_device):
1053         (IOSSimulatorPort):
1054         (IOSSimulatorPort._remove_device):
1055         (IOSSimulatorPort._testing_device):
1056         (IOSSimulatorPort.device_id_for_worker_number):
1057         (IOSSimulatorPort._set_device_class): Deleted.
1058         (IOSSimulatorPort.testing_device): Deleted.
1059         * Scripts/webkitpy/port/port_testcase.py:
1060         (PortTestCase.test_driver_cmd_line):
1061         * Scripts/webkitpy/xcode/simulator.py:
1062         (Device.shutdown):
1063         (Device.delete):
1064         (Device.reset):
1065         (Simulator.create_device):
1066         (Simulator.remove_device):
1067         (Simulator.device_number):
1068         (Simulator.device_state_description):
1069         (Simulator.wait_until_device_is_in_state):
1070
1071 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
1072
1073         Adopt SimServiceContext in LayoutTestRelay
1074         https://bugs.webkit.org/show_bug.cgi?id=161000
1075         <rdar://problem/25765594>
1076
1077         Reviewed by Daniel Bates.
1078
1079         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
1080         * LayoutTestRelay/LayoutTestRelay/main.m:
1081
1082 2016-08-19  Lucas Forschler  <lforschler@apple.com>
1083
1084         Remove Yosemite Leaks bot after http://trac.webkit.org/projects/webkit/changeset/204629
1085
1086         Reviewed by Kocsen Chung.
1087
1088         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1089         (WebKitBuildbot):
1090
1091 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
1092
1093         Partial revert of r203811 - this key is not needed.
1094
1095         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: (-[LTRelayController installApp]):
1096
1097 2016-08-19  Daniel Bates  <dabates@apple.com>
1098
1099         Another attempt to fix the iOS 9.3 build
1100
1101         Define WK_EMPTY_, WK_NOT_, and WK_NOT_YES.
1102
1103         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1104         * WebKitTestRunner/Configurations/Base.xcconfig:
1105
1106 2016-08-19  Lucas Forschler  <lforschler@apple.com>
1107
1108         Remove Yosemite Leaks bot from config.json
1109         
1110         Reviewed by Alexey Proskuryakov.
1111
1112         * BuildSlaveSupport/build.webkit.org-config/config.json:
1113
1114 2016-08-18  Dan Bernstein  <mitz@apple.com>
1115
1116         [Cocoa] API::Number needs to be wrapped by an NSNumber
1117         https://bugs.webkit.org/show_bug.cgi?id=160977
1118         <rdar://problem/27877735>
1119
1120         Reviewed by Anders Carlsson.
1121
1122         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1123         * TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm: Added.
1124         (TestWebKitAPI::TEST):
1125
1126 2016-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
1127
1128         [Cocoa] Migrate off of deprecated CoreGraphics API CGContextSelectFont() and CGContextShowTextAtPoint()
1129         https://bugs.webkit.org/show_bug.cgi?id=160895
1130
1131         Reviewed by Dean Jackson.
1132
1133         Link to the existing CoreText framework.
1134
1135         * DumpRenderTree/PlatformWin.cmake:
1136         * TestWebKitAPI/PlatformWin.cmake:
1137
1138 2016-08-17  Brent Fulgham  <bfulgham@apple.com>
1139
1140         [Win] Remove old libraries from build inputs
1141         https://bugs.webkit.org/show_bug.cgi?id=160949
1142
1143         Reviewed by Dean Jackson.
1144
1145         Modify the download script to remove the old 'icuuc.lib' and
1146         'icuin.lib' files for Windows builds.
1147
1148         * Scripts/update-webkit-auxiliary-libs:
1149
1150 2016-08-17  Jonathan Bedard  <jbedard@apple.com>
1151
1152         Extra logging for crash reason
1153         https://bugs.webkit.org/show_bug.cgi?id=160943
1154
1155         Reviewed by Alexey Proskuryakov.
1156
1157         A number of tests have been erroneously marked as crashed, this should help diagnose these false crashes.
1158
1159         * Scripts/webkitpy/port/server_process.py:
1160         (ServerProcess.write): Add extra logging to determine why a process has been marked as crashed.
1161         (ServerProcess._wait_for_data_and_update_buffers_using_select): Ditto.
1162         (ServerProcess.has_crashed): Ditto.
1163
1164 2016-08-17  Dan Bernstein  <mitz@apple.com>
1165
1166         [Cocoa] -[NSString isEqualToString:] returns NO for any WKNSString argument
1167         https://bugs.webkit.org/show_bug.cgi?id=160938
1168         <rdar://problem/27876652>
1169
1170         Reviewed by Anders Carlsson.
1171
1172         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1173         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm: Added.
1174         (TestWebKitAPI::TEST):
1175
1176 2016-08-17  Chris Fleizach  <cfleizach@apple.com>
1177
1178         AX: Support abbreviations in iOS
1179         https://bugs.webkit.org/show_bug.cgi?id=160907
1180
1181         Reviewed by Joanmarie Diggs.
1182
1183         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1184         (AccessibilityUIElement::stringAttributeValue):
1185         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1186         (WTR::AccessibilityUIElement::stringAttributeValue):
1187
1188 2016-08-17  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
1189
1190         [EFL] Bump efl version from 1.17 to 1.18
1191         https://bugs.webkit.org/show_bug.cgi?id=160899
1192
1193         Reviewed by Antonio Gomes.
1194
1195         To use efl-1.18, EFL port needs to update install dependencies as well.
1196
1197         * efl/install-dependencies:
1198         * efl/jhbuild.modules:
1199
1200 2016-08-17  Per Arne Vollan  <pvollan@apple.com>
1201
1202         [Win] Add tests for linked fonts.
1203         https://bugs.webkit.org/show_bug.cgi?id=160898
1204
1205         Reviewed by Brent Fulgham.
1206
1207         Add tests for https://trac.webkit.org/changeset/204502.
1208
1209         * TestWebKitAPI/PlatformWin.cmake:
1210         * TestWebKitAPI/Tests/WebCore/win/LinkedFonts.cpp: Added.
1211         (TestWebKitAPI::TEST):
1212
1213 2016-08-16  Daniel Bates  <dabates@apple.com>
1214
1215         prepare-ChangeLog: Extract logic from generateFunctionLists() into a function that takes a delegate object
1216         https://bugs.webkit.org/show_bug.cgi?id=160924
1217
1218         Reviewed by Stephanie Lewis.
1219
1220         Towards adding unit tests for generateFunctionLists() we move its logic into actuallyGenerateFunctionLists()
1221         and have actuallyGenerateFunctionLists() take a delegate object to use to query the file system and SCM.
1222         We modify generateFunctionLists() to call actuallyGenerateFunctionLists(). This will make is possible to
1223         test the generate function list machinery without requiring a SCM checkout by substituting a delegate
1224         object that mocks out the file system and SCM operations.
1225
1226         * Scripts/VCSUtils.pm:
1227         (parseDiffStartLine): Parses an SVN or Git start line and returns the path to the target file.
1228         * Scripts/prepare-ChangeLog:
1229         (generateFunctionLists): Move functionality to actually generate the function lists to actuallyGenerateFunctionLists(),
1230         abstracting the logic to query the file system and SCM into functions on a delegate object that
1231         we pass to it.
1232         (actuallyGenerateFunctionLists): Extracted from generateFunctionLists().
1233         (diffHeaderFormat): Deleted.
1234
1235 2016-08-16  Alex Christensen  <achristensen@webkit.org>
1236
1237         URLParser should parse URLs without credentials
1238         https://bugs.webkit.org/show_bug.cgi?id=160913
1239
1240         Reviewed by Brady Eidson.
1241
1242         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1243         (TestWebKitAPI::s):
1244         (TestWebKitAPI::checkURL):
1245         (TestWebKitAPI::TEST_F):
1246
1247 2016-08-16  Anders Carlsson  <andersca@apple.com>
1248
1249         Add WTF::ScopeExit
1250         https://bugs.webkit.org/show_bug.cgi?id=160908
1251
1252         Reviewed by Geoffrey Garen.
1253
1254         * TestWebKitAPI/CMakeLists.txt:
1255         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1256         * TestWebKitAPI/Tests/WTF/Scope.cpp: Added.
1257         (TestWebKitAPI::TEST):
1258
1259 2016-08-16  Aakash Jain  <aakash_jain@apple.com>
1260
1261         EWS logs file are rotated too quickly
1262         https://bugs.webkit.org/show_bug.cgi?id=160724
1263
1264         Reviewed by Daniel Bates.
1265
1266         Currently we are rotating the log file after 10 iterations of queue. If the queue
1267         doesn't have any pending patches, these iterations result in very small amount of 
1268         logs (1 KB log file). Even if the queue process some patches, logs are few KBs.
1269         This results in a lot of log files in a day. This patch ensures that we rotate the
1270         log file when its file size is greater than or equal to 100 KB.
1271
1272         * EWSTools/start-queue-mac.sh: Added check for file size before rotating log file.
1273
1274 2016-08-16  Daniel Bates  <dabates@apple.com>
1275
1276         WKSI static library should be named by major iOS revision, not individual updates
1277         https://bugs.webkit.org/show_bug.cgi?id=160727
1278         <rdar://problem/22274848>
1279
1280         Reviewed by Alexey Proskuryakov.
1281
1282         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1283         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1284         * Scripts/copy-webkitlibraries-to-product-directory:
1285         * WebKitTestRunner/Configurations/Base.xcconfig:
1286         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1287
1288 2016-08-16  Simon Fraser  <simon.fraser@apple.com>
1289
1290         Make it possible to test iOS select elements, and add iPhone and iPad tests for them
1291         https://bugs.webkit.org/show_bug.cgi?id=160909
1292
1293         Reviewed by Enrica Casucci.
1294         
1295         Add functions to UIScriptController to dismiss the form accessory view for iOS,
1296         and to programmatically pick a row from a <select> picker.
1297
1298         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
1299         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1300         (WTR::UIScriptController::dismissFormAccessoryView):
1301         (WTR::UIScriptController::selectFormAccessoryPickerRow):
1302         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1303         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1304         (WTR::UIScriptController::dismissFormAccessoryView):
1305         (WTR::UIScriptController::selectFormAccessoryPickerRow):
1306
1307 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
1308
1309         [iOS] Add iPad viewport and form tests, and revert the iPad-testing part of r202132
1310         https://bugs.webkit.org/show_bug.cgi?id=160878
1311
1312         Reviewed by Tim Horton.
1313         
1314         Remove testing-specific "forceIPadStyleZoomOnInputFocus" behavior added in r202132
1315         now that we have the ability to run tests in the iPad simulator.
1316
1317         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
1318         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1319         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
1320         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
1321         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1322         * WebKitTestRunner/ios/TestControllerIOS.mm:
1323         (WTR::TestController::platformResetStateToConsistentValues): Deleted.
1324         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1325         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
1326         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
1327
1328 2016-08-15  Anders Carlsson  <andersca@apple.com>
1329
1330         Add an address-of operator to RetainPtr
1331         https://bugs.webkit.org/show_bug.cgi?id=160879
1332
1333         Reviewed by Tim Horton.
1334
1335         Test HashMap and HashSet with an object whose operator& is deleted.
1336
1337         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1338         Sort the Xcode project.
1339
1340         * TestWebKitAPI/Tests/WTF/DeletedAddressOfOperator.h: Added.
1341         (DeletedAddressOfOperator::DeletedAddressOfOperator):
1342         (DeletedAddressOfOperator::value):
1343         (DeletedAddressOfOperator::operator==):
1344         (WTF::HashTraits<DeletedAddressOfOperator>::constructDeletedValue):
1345         (WTF::HashTraits<DeletedAddressOfOperator>::isDeletedValue):
1346         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::hash):
1347         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::equal):
1348         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1349         (TestWebKitAPI::TEST):
1350         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1351         (TestWebKitAPI::TEST):
1352
1353 2016-08-16  Jonathan Bedard  <jbedard@apple.com>
1354
1355         False crashes in fast/text/emoji-gender-* tests
1356         https://bugs.webkit.org/show_bug.cgi?id=160779
1357
1358         Reviewed by Alexey Proskuryakov.
1359
1360         Fix from <rdar://problem/27786762>, where timed out tests falsely report as crashed.
1361
1362         * Scripts/webkitpy/port/driver.py:
1363         (Driver._check_for_driver_crash_or_unresponsiveness): Change call to ‘write’ to disable crash flag.
1364         * Scripts/webkitpy/port/driver_unittest.py: Added 3 variable to test version of ‘write.’
1365         * Scripts/webkitpy/port/server_process.py:
1366         (ServerProcess.write): Allow caller to disable crash flag on exception.
1367
1368 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
1369
1370         webkitpy error in TestRunResults.merge()
1371         https://bugs.webkit.org/show_bug.cgi?id=160882
1372
1373         Reviewed by Daniel Bates.
1374         
1375         The argument to TestRunResults.merge() can be None if there are no device-specifc
1376         initial results or retry results in Manager.run(), so just return early in that case.
1377
1378         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1379         (TestRunResults.merge):
1380
1381 2016-08-15  Sam Weinig  <sam@webkit.org>
1382
1383         Speed up compile times by not including wtf/Variant.h so much
1384         https://bugs.webkit.org/show_bug.cgi?id=160847
1385
1386         Reviewed by Alex Christensen and Saam Barati.
1387
1388         * TestWebKitAPI/Tests/WTF/Variant.cpp:
1389         (TestWebKitAPI::TEST):
1390         Explicitly use std::experimental::variant.
1391
1392 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
1393
1394         Allow a port to run tests with a custom device setup
1395         https://bugs.webkit.org/show_bug.cgi?id=160833
1396
1397         Reviewed by Daniel Bates.
1398
1399         These changes allow the IOSSimulator port to run tests in iPad mode.
1400
1401         This is made possible by allowing a platform to define CUSTOM_DEVICE_CLASSES,
1402         in this case 'ipad'. When specified, any test in a directory with a suffix that matches
1403         a custom device will be collected into a set, and run in that device's environment after
1404         the other tests have run.
1405
1406         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1407         (Manager._custom_device_for_test): If the test contains a directory matching a
1408         custom device suffix, return that custom device.
1409         (Manager._set_up_run): Push the custom device class, if any, into options so
1410         that the Worker can get to it.
1411         (Manager.run): Go through the list of tests, and break it down into device-generic
1412         tests, and tests for each device class. _run_test_subset is then called for
1413         each collection of tests, and the results merged.
1414         (Manager._run_test_subset): Some lines unwrapped.
1415         (Manager._end_test_run):
1416         (Manager._run_tests):
1417         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1418         (SingleTestRunner.__init__): Unwrapped a line.
1419         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1420         (TestRunResults.merge): Add this function to merge TestRunResults
1421         * Scripts/webkitpy/layout_tests/views/printing.py:
1422         (Printer.print_workers_and_shards): Print the custom device, if any.
1423         * Scripts/webkitpy/port/base.py:
1424         (Port): Base port has empty array of custom devices.
1425         (Port.setup_test_run): Add device_class argument.
1426         * Scripts/webkitpy/port/driver.py:
1427         (DriverInput.__repr__):
1428         (Driver.check_driver.implementation):
1429         * Scripts/webkitpy/port/efl.py:
1430         (EflPort.setup_test_run):
1431         * Scripts/webkitpy/port/gtk.py:
1432         (GtkPort.setup_test_run):
1433         * Scripts/webkitpy/port/ios.py:
1434         (IOSSimulatorPort): Add CUSTOM_DEVICE_CLASSES for ipad.
1435         (IOSSimulatorPort.__init__):
1436         (IOSSimulatorPort.simulator_device_type): Use a device name from the DEVICE_CLASS_MAP
1437         based on the custom device class.
1438         (IOSSimulatorPort._set_device_class):
1439         (IOSSimulatorPort._create_simulators): Factor some code into this function.
1440         (IOSSimulatorPort.setup_test_run):
1441         (IOSSimulatorPort.testing_device):
1442         (IOSSimulatorPort.reset_preferences): This used to create the simulator apps, but that
1443         seemed wrong for this function. That was moved to setup_test_run().
1444         (IOSSimulatorPort.check_sys_deps): This function used to create testing devices,
1445         but this happened too early, before we knew which kind of devices to create. Devices
1446         are now created in setup_test_run().
1447         * Scripts/webkitpy/port/win.py:
1448         (WinPort.setup_test_run):
1449
1450 2016-08-15  Daniel Bates  <dabates@apple.com>
1451
1452         Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
1453         private frameworks and libraries
1454         https://bugs.webkit.org/show_bug.cgi?id=155931
1455         <rdar://problem/25807989>
1456
1457         Reviewed by Dan Bernstein.
1458
1459         Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
1460         where X is the major version of the active iOS SDK.
1461
1462         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1463         * WebKitTestRunner/Configurations/Base.xcconfig:
1464
1465 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
1466
1467         Add a setting and preferences to enable visual viewport mode
1468         https://bugs.webkit.org/show_bug.cgi?id=160843
1469
1470         Reviewed by Sam Weinig.
1471         
1472         Pref and a menu item to toggle visualViewportEnabled for WebKits 1 and 2.
1473
1474         * MiniBrowser/mac/SettingsController.h:
1475         * MiniBrowser/mac/SettingsController.m:
1476         (-[SettingsController _populateMenu]):
1477         (-[SettingsController validateMenuItem:]):
1478         (-[SettingsController visualViewportEnabled]):
1479         (-[SettingsController toggleVisualViewportEnabled:]):
1480         * MiniBrowser/mac/WK1BrowserWindowController.m:
1481         (-[WK1BrowserWindowController didChangeSettings]):
1482         * MiniBrowser/mac/WK2BrowserWindowController.m:
1483         (-[WK2BrowserWindowController didChangeSettings]):
1484
1485 2016-08-15  Konstantin Tokarev  <annulen@yandex.ru>
1486
1487         Allow using make-dist with non-GTK ports
1488         https://bugs.webkit.org/show_bug.cgi?id=160842
1489
1490         Reviewed by Michael Catanzaro.
1491
1492         This patch adds support for setting base name of tarball and argument
1493         passed to cmake's -DPORT= via command line arguments.
1494
1495         * gtk/make-dist.py:
1496         (Distcheck.configure):
1497         (Distcheck.check):
1498         (get_tarball_root_and_output_filename_from_arguments):
1499
1500 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1501
1502         [GTK] Install script lacks gstreamer related dependencies
1503         https://bugs.webkit.org/show_bug.cgi?id=160814
1504
1505         Reviewed by Carlos Garcia Campos.
1506
1507         * gtk/install-dependencies: Fedora case had already listed this dependencies,
1508         but both Arch and Debian/Ubuntu were missing them.
1509
1510 2016-08-13  Konstantin Tokarev  <annulen@yandex.ru>
1511
1512         make-dist.py should not allow unknown rules in manifest
1513         https://bugs.webkit.org/show_bug.cgi?id=160841
1514
1515         Reviewed by Carlos Garcia Campos.
1516
1517         * gtk/make-dist.py:
1518         (Manifest.process_line):
1519
1520 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1521
1522         [EFL][GTK] Install script not working on Debian 9 (testing) and Ubuntu 16.10
1523         https://bugs.webkit.org/show_bug.cgi?id=160809
1524
1525         Reviewed by Carlos Garcia Campos.
1526
1527         * efl/install-dependencies: Factorize the previous logic for handling the php5/7
1528         case, and use it also for the new package names of libpng and libgeoclue.
1529         * gtk/install-dependencies: Ditto.
1530
1531 2016-08-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1532
1533         Skip to check directories existence in build-webkit
1534         https://bugs.webkit.org/show_bug.cgi?id=160691
1535
1536         Reviewed by Alex Christensen.
1537
1538         CMake checks if directories are there itself. So CMake ports
1539         don't need to check it in the build-webkit script.
1540
1541         * Scripts/build-webkit:
1542         * Scripts/webkitdirs.pm:
1543         (determineSourceDir):
1544         (isCMakeBuild):
1545
1546 2016-08-12  Alex Christensen  <achristensen@webkit.org>
1547
1548         Make URLParser work with URLs missing URL parts
1549         https://bugs.webkit.org/show_bug.cgi?id=160824
1550
1551         Reviewed by Brady Eidson.
1552
1553         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1554         (TestWebKitAPI::s):
1555         (TestWebKitAPI::checkURL):
1556         (TestWebKitAPI::TEST_F):
1557         (TestWebKitAPI::eq): Deleted.
1558
1559 2016-08-12  John Wilander  <wilander@apple.com>
1560
1561         Add HashCountedSet API tests to TestWTFLibrary target
1562         https://bugs.webkit.org/show_bug.cgi?id=160815
1563
1564         Reviewed by Alex Christensen.
1565
1566         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1567             Added HashCountedSet.cpp and sorted the file reference section
1568             according to UNIX sort.
1569
1570 2016-08-12  Ryosuke Niwa  <rniwa@webkit.org>
1571
1572         run-benchmark should run JetStream 1.1 instead of 1.0.1
1573         https://bugs.webkit.org/show_bug.cgi?id=160816
1574
1575         Reviewed by Filip Pizlo.
1576
1577         Use the latest JetStream 1.1 in run-benchmark.
1578
1579         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1580         (BenchmarkBuilder.__exit__):
1581         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Updated to apply against 1.1 directory.
1582         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Updated to use r190897, which is the last
1583         change to JetStream directory.
1584
1585 2016-08-12  Alex Christensen  <achristensen@webkit.org>
1586
1587         Initial URLParser implementation
1588         https://bugs.webkit.org/show_bug.cgi?id=160811
1589
1590         Reviewed by Brady Eidson.
1591
1592         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1593         (TestWebKitAPI::eq):
1594         (TestWebKitAPI::checkURL):
1595         (TestWebKitAPI::TEST_F):
1596
1597 2016-08-12  Brady Eidson  <beidson@apple.com>
1598
1599         Fix the 32-bit Mac build after:
1600         Add WK2 ExperimentalFeature support to MiniBrowser
1601         https://bugs.webkit.org/show_bug.cgi?id=160788
1602
1603         Unreviewed.
1604
1605         Sprinkle "#if WK_API_ENABLED"s liberally.
1606         
1607         * MiniBrowser/mac/AppDelegate.m:
1608         (defaultConfiguration):
1609         * MiniBrowser/mac/SettingsController.m:
1610         (-[SettingsController _populateMenu]):
1611         (-[SettingsController validateMenuItem:]):
1612
1613 2016-08-12  Philippe Normand  <pnormand@igalia.com>
1614
1615         [GStreamer][OWR] Video rendering fixes
1616         https://bugs.webkit.org/show_bug.cgi?id=160764
1617
1618         Reviewed by Xabier Rodriguez-Calvar.
1619
1620         * gtk/jhbuild.modules: Bump to current OpenWebRTC master.
1621
1622 2016-08-12  Per Arne Vollan  <pvollan@apple.com>
1623
1624         Add missing return statement in convertFast function added in r204376.
1625
1626         Unreviewed.
1627
1628         * Scripts/webkitpy/common/system/path.py:
1629         (_CygPath.convertFast):
1630
1631 2016-08-11  Brady Eidson  <beidson@apple.com>
1632
1633         Add WK2 ExperimentalFeature support to MiniBrowser.
1634         https://bugs.webkit.org/show_bug.cgi?id=160788
1635
1636         Reviewed by Alex Christensen.
1637
1638         * MiniBrowser/mac/AppDelegate.h:
1639         * MiniBrowser/mac/AppDelegate.m:
1640         (defaultConfiguration):
1641         (defaultPreferences):
1642         
1643         * MiniBrowser/mac/SettingsController.m:
1644         (-[SettingsController _populateMenu]):
1645         (-[SettingsController validateMenuItem:]):
1646         (-[SettingsController toggleExperimentalFeature:]):
1647
1648 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
1649
1650         Keep EWS logs for longer
1651         https://bugs.webkit.org/show_bug.cgi?id=160776
1652
1653         Reviewed by Daniel Bates.
1654
1655         * EWSTools/start-queue-mac.sh: Keep logs for 30 days instead of 14 days.
1656
1657 2016-08-11  Simon Fraser  <simon.fraser@apple.com>
1658
1659         iOS DRT/WTR project cleanup
1660         https://bugs.webkit.org/show_bug.cgi?id=160778
1661
1662         Reviewed by Tim Horton.
1663
1664         Move TARGETED_DEVICE_FAMILY from the project to an xcconfig file.
1665
1666         Remove AppDelegate.* which were unused.
1667
1668         Exclude ios/Launch.storyboard on more platforms.
1669
1670         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1671         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1672         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1673         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1674         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Removed.
1675         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Removed.
1676         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Deleted.
1677
1678 2016-08-11  Alex Christensen  <achristensen@webkit.org>
1679
1680         Fix Yosemite bots' cookie accept policies after r204365.
1681         https://bugs.webkit.org/show_bug.cgi?id=160758
1682
1683         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
1684         (TEST):
1685         This makes the test fully clean up after itself.
1686
1687 2016-08-11  Alex Christensen  <achristensen@webkit.org>
1688
1689         Fix Yosemite bots' cookie accept policies after r204365.
1690         https://bugs.webkit.org/show_bug.cgi?id=160758
1691
1692         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
1693         (TEST):
1694         I didn't restore the cookieAcceptPolicy of the sharedHTTPCookieStorage after changing it with this API test.
1695         On Yosemite, this is changing the cookieAcceptPolicy that DumpRenderTree uses.
1696         On more recent Cocoa platforms, it is only changing the cookieAcceptPolicy that TestWebKitAPI uses, which isn't
1697         causing any problems because there are no other API tests that do anything with cookies.
1698         My solution will be to restore the original cookieAcceptPolicy after running this API test to clean up,
1699         but first I am committing this patch setting the cookieAcceptPolicy to NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain
1700         to reset any bots that have run tests since r204365.  I will commit a followup that sets it to originalCookieAcceptPolicy.
1701
1702 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
1703
1704         EWS should check if the patch is still valid before executing every major step
1705         https://bugs.webkit.org/show_bug.cgi?id=160739
1706         rdar://problem/27768813
1707
1708         Reviewed by Alexey Proskuryakov.
1709
1710         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1711         (CommitQueueTask.run): validate method is now executed in base class.
1712         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1713         (EarlyWarningSystemTask.run): validate method is now executed in base class.
1714         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1715         (StyleQueueTask.validate): Raise an PatchIsNotValid exception instead of returning False.
1716         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1717         (PatchAnalysisTask._run_command): validate the patch before executing any command. This is to ensure
1718         that we do not waste time on any patch which has become invalid (e.g.: obsolete, r-).
1719         * Scripts/webkitpy/tool/commands/perfalizer.py:
1720         (PerfalizerTask.validate): Added.
1721         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1722         (test_manual_reject_during_processing): Updated test case.
1723
1724 2016-08-11  Alex Christensen  <achristensen@webkit.org>
1725
1726         Add URLParser stub
1727         https://bugs.webkit.org/show_bug.cgi?id=160770
1728
1729         Reviewed by Sam Weinig.
1730
1731         * TestWebKitAPI/PlatformGTK.cmake:
1732         * TestWebKitAPI/PlatformWin.cmake:
1733         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1734         * TestWebKitAPI/Tests/WebCore/URLParser.cpp: Added.
1735         (TestWebKitAPI::TEST_F):
1736
1737 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1738
1739         [iOS DRT] Allow DRT to be iPad-sized in the iPad simulator
1740         https://bugs.webkit.org/show_bug.cgi?id=160761
1741
1742         Reviewed by Tim Horton.
1743
1744         Give iOS DRT a Launch storyboard.
1745
1746         Have it use a UIViewController so future forms testing works correctly.
1747
1748         Add TARGETED_DEVICE_FAMILY = "1,2" to the build settings for the .app, so that it
1749         can run in iPad mode.
1750
1751         Remove empty InfoPlist.strings files.
1752
1753         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1754         * DumpRenderTree/ios/Info.plist:
1755         * DumpRenderTree/ios/Launch.storyboard: Added.
1756         * DumpRenderTree/mac/DumpRenderTree.mm:
1757         (createWebViewAndOffscreenWindow):
1758         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1759         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Removed.
1760         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1761         (WTR::PlatformWebView::PlatformWebView): Drive-by leak fix.
1762
1763 2016-08-11  Per Arne Vollan  <pvollan@apple.com>
1764
1765         [Win] Unable to reliably run tests in parallel
1766         https://bugs.webkit.org/show_bug.cgi?id=140914
1767
1768         Reviewed by Brent Fulgham.
1769
1770         The cygpath utility function can fail badly when running with multiple DumpRenderTree
1771         processes. We can use string replacement to convert the Cygwin path to a Windows path
1772         instead.
1773
1774         * Scripts/webkitpy/common/system/path.py:
1775         (cygpathFast):
1776         * Scripts/webkitpy/port/driver.py:
1777         (Driver._command_from_driver_input):
1778
1779 2016-08-10  Alex Christensen  <achristensen@webkit.org>
1780
1781         Fix crash when changing cookie accept policy after r204327
1782         https://bugs.webkit.org/show_bug.cgi?id=160758
1783
1784         Reviewed by Simon Fraser.
1785
1786         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1787         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Added.
1788         (-[CookieAcceptPolicyMessageHandler userContentController:didReceiveScriptMessage:]):
1789         (TEST):
1790         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Added.
1791
1792 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1793
1794         [iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
1795         https://bugs.webkit.org/show_bug.cgi?id=160757
1796
1797         Reviewed by Tim Horton.
1798
1799         When programmatically creating the test UIWindow, make a root UIViewController and parent
1800         the WKWebView in its view. This makes the app more like a normal UIKit application.
1801         
1802         Move the WKWebView down 20px to avoid the status bar.
1803         
1804         Give the UIWindow a gray background so it's obvious where the window and view positioned.
1805
1806         Sorted the project file. Removed the link to UIKit which showed red, and wasn't necessary.
1807         
1808         Remove duplicate references to Launch.storyboard.
1809
1810         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1811         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Add license.
1812         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Add license.
1813         (-[AppDelegate applicationWillResignActive:]): Deleted.
1814         (-[AppDelegate applicationDidEnterBackground:]): Deleted.
1815         (-[AppDelegate applicationWillEnterForeground:]): Deleted.
1816         (-[AppDelegate applicationDidBecomeActive:]): Deleted.
1817         (-[AppDelegate applicationWillTerminate:]): Deleted.
1818         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1819         (WTR::viewRectForWindowRect):
1820         (WTR::PlatformWebView::PlatformWebView):
1821         (WTR::PlatformWebView::setWindowFrame):
1822
1823 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1824
1825         [iOS WK2] Use the simulated device's screen size, rather than a harcoded size
1826         https://bugs.webkit.org/show_bug.cgi?id=160748
1827
1828         Reviewed by Tim Horton.
1829         
1830         Use the main UIScreen's bounds for the window size if we're using a flexible viewport. This
1831         opens the door for tests using other device sizes.
1832
1833         * WebKitTestRunner/ios/TestControllerIOS.mm:
1834         (WTR::TestController::platformConfigureViewForTest):
1835
1836 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1837
1838         Sort the feature flags in the FEATURE_DEFINES lines
1839         https://bugs.webkit.org/show_bug.cgi?id=160742
1840
1841         Reviewed by Anders Carlsson.
1842         
1843         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1844
1845 2016-08-09  Simon Fraser  <simon.fraser@apple.com>
1846
1847         Logging and other minor improvements to iOS webkitpy
1848         https://bugs.webkit.org/show_bug.cgi?id=160722
1849
1850         Reviewed by Dan Bates.
1851
1852         Fix --debug-rwt-logging to log all the calls to simctl as well as device state information,
1853         to make it easier to debug launching issues.
1854
1855         Have reset_preferences() reset the device, rather than just nuking the data
1856         directory (which broke some versions of the simulator).
1857
1858         Make the Simulator.app launch in the background with open -g.
1859
1860         Wait for the simulator device to be in a known state in some more places.
1861
1862         * Scripts/webkitpy/port/ios.py:
1863         (IOSSimulatorPort.setup_test_run):
1864         (IOSSimulatorPort._quit_ios_simulator):
1865         (IOSSimulatorPort.clean_up_test_run):
1866         (IOSSimulatorPort.setup_environ_for_server):
1867         (IOSSimulatorPort.reset_preferences):
1868         * Scripts/webkitpy/xcode/simulator.py:
1869         (Device.create):
1870         (Device.delete):
1871         (Device):
1872         (Device.reset):
1873         (Simulator.wait_until_device_is_booted):
1874         (Simulator.wait_until_device_is_in_state):
1875         (Simulator):
1876         (Simulator.delete_device):
1877         (Simulator.reset_device):
1878         (Simulator.lookup_or_create_device):
1879
1880 2016-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1881
1882         [GTK][EFL] ALSA_CARD environment variable is not passed for layout tests.
1883         https://bugs.webkit.org/show_bug.cgi?id=160697
1884
1885         Reviewed by Antonio Gomes.
1886
1887         * Scripts/webkitpy/port/base.py:
1888         (Port.to.setup_environ_for_server): Add ALSA_CARD and sort the Linux
1889         list of environment variables to copy.
1890
1891 2016-08-09  George Ruan  <gruan@apple.com>
1892
1893         Implement functionality of media capture on iOS
1894         https://bugs.webkit.org/show_bug.cgi?id=158945
1895         <rdar://problem/26893343>
1896
1897         Reviewed by Tim Horton.
1898
1899         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Enable Media
1900         Capture feature on iOS.
1901
1902 2016-08-09  Saam Barati  <sbarati@apple.com>
1903
1904         Parser<LexerType>::parseFunctionInfo() has the wrong info about captured vars when a function is not cached.
1905         https://bugs.webkit.org/show_bug.cgi?id=160671
1906         <rdar://problem/27756112>
1907
1908         Reviewed by Mark Lam.
1909
1910         * Scripts/run-jsc-stress-tests:
1911
1912 2016-08-09  Alexey Proskuryakov  <ap@apple.com>
1913
1914         Make directory reading code in iOSSimulatorDevices() more strict
1915         https://bugs.webkit.org/show_bug.cgi?id=160702
1916
1917         Reviewed by Tim Horton.
1918
1919         * Scripts/webkitdirs.pm:
1920         (iOSSimulatorDevices):
1921
1922 2016-08-06  Sam Weinig  <sam@webkit.org>
1923
1924         Replace NodeOrString with std::variant<RefPtr<Node>, String>
1925         https://bugs.webkit.org/show_bug.cgi?id=160638
1926
1927         Reviewed by Anders Carlsson.
1928
1929         * TestWebKitAPI/CMakeLists.txt:
1930         * TestWebKitAPI/Tests/WTF/Variant.cpp:
1931         Add additional tests for the initial state of std::variant and using
1932         makeVisitor for visiting.
1933
1934 2016-08-09  Aakash Jain  <aakash_jain@apple.com>
1935
1936         EWS logging should ensure the logging to file is stopped on queue termination
1937         https://bugs.webkit.org/show_bug.cgi?id=160698
1938         rdar://problem/24464570
1939
1940         Reviewed by Daniel Bates.
1941
1942         * Scripts/webkitpy/tool/bot/queueengine.py:
1943         (QueueEngine._stopping): Stop logging to file on queue termination.
1944         (QueueEngine._begin_logging): Configure the Python logger to log to file.
1945         * Scripts/webkitpy/common/system/logutils.py:
1946         (configure_logger_to_log_to_file): Return the handler so as to enable caller to remove it later.
1947         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1948         (QueueEngineTest._run_engine): Removed extra newline character to improve log readability.
1949         * Scripts/webkitpy/tool/commands/queues.py:
1950         (AbstractQueue._log_directory): Reverting to os.path.join as we don't have host object.
1951         (AbstractQueue.queue_log_path): Same.
1952         (AbstractQueue.begin_work_queue): Removed logging initialization, it is now being done in QueueEngine.
1953         (AbstractQueue.__init__): Removed host parameter, not required anymore, it was required by logging initialization
1954         which moved to QueueEngine now.
1955         (PatchProcessingQueue.__init__): Same.
1956         (CommitQueue.__init__): Same.
1957         (AbstractReviewQueue.__init__): Same.
1958         (StyleQueue.__init__): Same.
1959         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1960         (TestCommitQueue): Removed host parameter.
1961         (TestCommitQueue.__init__): Same.
1962         (AbstractPatchQueueTest.test_next_patch): Same.
1963         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
1964         (test_commit_queue_failure): Same.
1965         (mock_run_webkit_patch):
1966         (MockCommitQueueTask.results_from_patch_test_run): Same.
1967         (test_rollout_lands): Same.
1968         (test_non_valid_patch): Same.
1969         (test_auto_retry): Same.
1970         (test_style_queue_with_watch_list_exception): Same.
1971         (TestQueue.__init__): Deleted.
1972         (TestReviewQueue.__init__): Deleted.
1973         (TestFeederQueue.__init__): Deleted.
1974
1975 2016-08-09  Konstantin Tokarev  <annulen@yandex.ru>
1976
1977         webkit-gtk tarball fails to build due to missing files
1978         https://bugs.webkit.org/show_bug.cgi?id=160684
1979
1980         Reviewed by Alex Christensen.
1981
1982         * gtk/manifest.txt.in: Added back spi directories.
1983
1984 2016-08-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1985
1986         [GTK] Build the jhbuild with -O2 optimization level by default
1987         https://bugs.webkit.org/show_bug.cgi?id=160544
1988
1989         Reviewed by Michael Catanzaro.
1990
1991         * gtk/jhbuildrc: Pass -O2 when building the JHBuild, as also -g1
1992         which don't increases the required disk space significatively and
1993         provides better debug information than no passing it.
1994
1995 2016-08-09  Csaba Osztrogonác  <ossy@webkit.org>
1996
1997         Allow more --cmakeargs option in build-jsc and build-webkit
1998         https://bugs.webkit.org/show_bug.cgi?id=160340
1999
2000         Reviewed by Michael Catanzaro.
2001
2002         * Scripts/build-jsc:
2003         * Scripts/build-webkit:
2004
2005 2016-08-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2006
2007         Do not check if WebKitLibraries folder exists on EFL and GTK
2008         https://bugs.webkit.org/show_bug.cgi?id=160659
2009
2010         Reviewed by Csaba Osztrogonác.
2011
2012         Though WebKitLibraries is only needed by mac and win ports,
2013         EFL and GTK ports have checked whether it exists.
2014
2015         * Scripts/build-webkit:
2016
2017 2016-08-08  Aakash Jain  <aakash_jain@apple.com>
2018
2019         Some EWS console logs doesn't go to log file
2020         https://bugs.webkit.org/show_bug.cgi?id=160585
2021         rdar://problem/24464570
2022
2023         Reviewed by Daniel Bates.
2024
2025         * Scripts/webkitpy/common/system/logutils.py:
2026         (FileSystemHandler._open): Ensure that we open logfile in append mode in order to avoid
2027         any possible overwriting.
2028         * Scripts/webkitpy/common/system/filesystem.py:
2029         (FileSystem.open_text_file_for_writing): Add should_append parameter to append to file.
2030         * Scripts/webkitpy/common/system/filesystem_mock.py:
2031         (MockFileSystem.open_text_file_for_writing): Same.
2032         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2033         (RealFileSystemTest.test_read_and_write_text_file): Removed unused variable 'hex_equivalent'.
2034         (RealFileSystemTest.test_append_to_text_file): Added new unit test for testing append functionality.
2035         * Scripts/webkitpy/tool/commands/queues.py:
2036         (AbstractQueue.begin_work_queue): Configure the logger for overall webkitpy to log to file.
2037         This will ensure that all the sub-modules inside webkitpy will log to file.
2038
2039 2016-08-08  Simon Fraser  <simon.fraser@apple.com>
2040
2041         Have the iOS platform interit from the Apple platform in webkitpy
2042         https://bugs.webkit.org/show_bug.cgi?id=160672
2043
2044         Reviewed by Dan Bates.
2045         
2046         The IOSSimulatorPort used to inherit from Port, rather than ApplePort.
2047         Fix this, and move duplicated code from IOSSimulatorPort and MacPort into
2048         ApplePort.
2049         
2050         Since WinPort also inherits from ApplePort, it needs to stub out some things
2051         that are unavailable on Windows (leaks, sampling).
2052         
2053         Some SnowLeopard-related code and the associated test were removed.
2054
2055         * Scripts/webkitpy/port/apple.py:
2056         (ApplePort.__init__):
2057         (ApplePort):
2058         (ApplePort._make_leak_detector):
2059         (ApplePort.default_timeout_ms):
2060         (ApplePort.supports_per_test_timeout):
2061         (ApplePort.should_retry_crashes):
2062         (ApplePort._generate_all_test_configurations):
2063         (ApplePort.check_for_leaks):
2064         (ApplePort.print_leaks_summary):
2065         (ApplePort._path_to_webcore_library):
2066         (ApplePort.show_results_html_file):
2067         (ApplePort._merge_crash_logs):
2068         (ApplePort._look_for_all_crash_logs_in_log_dir):
2069         (ApplePort._get_crash_log):
2070         (ApplePort.look_for_new_crash_logs):
2071         (ApplePort.sample_process):
2072         (ApplePort.sample_file_path):
2073         (ApplePort.look_for_new_samples):
2074         (ApplePort._path_to_helper):
2075         (ApplePort.determine_full_port_name): Deleted.
2076         * Scripts/webkitpy/port/ios.py:
2077         (IOSSimulatorPort):
2078         (IOSSimulatorPort.__init__):
2079         (IOSSimulatorPort.default_timeout_ms): Deleted.
2080         (IOSSimulatorPort.supports_per_test_timeout): Deleted.
2081         (IOSSimulatorPort.should_retry_crashes): Deleted.
2082         (IOSSimulatorPort.check_for_leaks): Deleted.
2083         (IOSSimulatorPort.print_leaks_summary): Deleted.
2084         (IOSSimulatorPort._path_to_webcore_library): Deleted.
2085         (IOSSimulatorPort.show_results_html_file): Deleted.
2086         (IOSSimulatorPort.sample_file_path): Deleted.
2087         (IOSSimulatorPort._merge_crash_logs): Deleted.
2088         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Deleted.
2089         (IOSSimulatorPort.look_for_new_crash_logs): Deleted.
2090         (IOSSimulatorPort.look_for_new_samples): Deleted.
2091         (IOSSimulatorPort.sample_process): Deleted.
2092         (IOSSimulatorPort._path_to_helper): Deleted.
2093         (IOSSimulatorPort.make_command): Deleted.
2094         * Scripts/webkitpy/port/mac.py:
2095         (MacPort.__init__):
2096         (MacPort.make_command):
2097         (MacPort._build_java_test_support):
2098         (MacPort): Deleted.
2099         (MacPort.default_timeout_ms): Deleted.
2100         (MacPort.supports_per_test_timeout): Deleted.
2101         (MacPort.should_retry_crashes): Deleted.
2102         (MacPort.default_child_processes): Deleted.
2103         (MacPort.check_for_leaks): Deleted.
2104         (MacPort.print_leaks_summary): Deleted.
2105         (MacPort._path_to_webcore_library): Deleted.
2106         (MacPort.show_results_html_file): Deleted.
2107         (MacPort.sample_file_path): Deleted.
2108         (MacPort._merge_crash_logs): Deleted.
2109         (MacPort._look_for_all_crash_logs_in_log_dir): Deleted.
2110         (MacPort.look_for_new_crash_logs): Deleted.
2111         (MacPort.look_for_new_samples): Deleted.
2112         (MacPort.sample_process): Deleted.
2113         (MacPort._path_to_helper): Deleted.
2114         * Scripts/webkitpy/port/mac_unittest.py:
2115         (MacTest.test_default_child_processes): Deleted.
2116         * Scripts/webkitpy/port/win.py:
2117         (WinPort.look_for_new_samples):
2118         (WinPort):
2119         (WinPort.sample_process):
2120         (WinPort._make_leak_detector):
2121         (WinPort.check_for_leaks):
2122         (WinPort.print_leaks_summary):
2123         (WinPort._path_to_webcore_library):
2124
2125 2016-08-08  Matt Baker  <mattbaker@apple.com>
2126
2127         Unreviewed: moved myself to the reviewers list.
2128
2129         * Scripts/webkitpy/common/config/contributors.json:
2130
2131 2016-08-08  Chris Dumez  <cdumez@apple.com>
2132
2133         Update API tests in mac/SetDocumentURI.mm after r204247
2134         https://bugs.webkit.org/show_bug.cgi?id=160660
2135
2136         Reviewed by Alex Christensen.
2137
2138         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
2139         (TestWebKitAPI::TEST):
2140
2141 2016-08-08  Jonathan Bedard  <jbedard@apple.com>
2142
2143         run-webkit-tests should trigger a spindump when WebContent process is unresponsive
2144         https://bugs.webkit.org/show_bug.cgi?id=159827
2145
2146         Reviewed by Daniel Bates.
2147
2148         This change was spurred by a process hang which occurred between tests and did
2149         not produce a meaningful crashlog.
2150
2151         * Scripts/webkitpy/port/driver.py:
2152         (Driver._check_for_driver_crash_or_unresponsiveness): Notify test controller when finished through stdin.
2153
2154          * Scripts/webkitpy/port/ios.py:
2155         (IOSSimulatorPort):
2156         (IOSSimulatorPort.sample_process): Attempt spindump, but use sample if spindump fails.
2157         * Scripts/webkitpy/port/mac.py:
2158         (MacPort):
2159         (MacPort.sample_process): Attempt spindump, but use sample if spindump fails.
2160
2161         * Scripts/webkitpy/port/mac_unittest.py: Changed expected values to match spindump calls, added specific spindump test.
2162         * Scripts/webkitpy/port/driver_unittest.py: Added dummy write function.
2163
2164         * WebKitTestRunner/TestController.h:
2165         (WTR::TestController::usingServerMode): Added accessor for m_usingServerMode.
2166         * WebKitTestRunner/TestInvocation.cpp:
2167         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Wait for stdin before continuing when in server mode.
2168
2169 2016-08-07  Dan Bernstein  <mitz@apple.com>
2170
2171         [Cocoa] Reply block leaks if the remote object doesn’t call it
2172         https://bugs.webkit.org/show_bug.cgi?id=160642
2173
2174         Reviewed by Sam Weinig.
2175
2176         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Declared a new method.
2177         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
2178         (TEST): Added a test case that checks that the reply block is released even when it’s not
2179           called.
2180         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
2181         (-[RemoteObjectRegistryPlugIn doNotCallCompletionHandler:]): Implement new method by not
2182           calling the completion handler.
2183
2184 2016-08-07  Chris Dumez  <cdumez@apple.com>
2185
2186         Write API test to cover crash fix in r204135
2187         https://bugs.webkit.org/show_bug.cgi?id=160587
2188
2189         Reviewed by Darin Adler.
2190
2191         Add API test to cover crash fix in r204135. This reproduces the crash
2192         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
2193         callback.
2194
2195         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2196         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
2197         (TEST):
2198
2199 2016-08-06  Chris Dumez  <cdumez@apple.com>
2200
2201         Unreviewed, rolling out r204226.
2202
2203         Broke some API tests
2204
2205         Reverted changeset:
2206
2207         "Write API test to cover crash fix in r204135"
2208         https://bugs.webkit.org/show_bug.cgi?id=160587
2209         http://trac.webkit.org/changeset/204226
2210
2211 2016-08-06  Aakash Jain  <aakash_jain@apple.com>
2212
2213         EWS Style Queue fails to process patches which fails validation
2214         https://bugs.webkit.org/show_bug.cgi?id=160632
2215
2216         Reviewed by Alexey Proskuryakov.
2217
2218         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
2219         (StyleQueueTask.validate): Add more information about validation failure.
2220         (StyleQueueTask.run): Pass the error details in the PatchIsNotValid exception.
2221         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2222         (test_non_valid_patch): Add a unit test to test the above code path.
2223
2224 2016-08-06  Sam Weinig  <sam@webkit.org>
2225
2226         WTF needs a variant implementation
2227         https://bugs.webkit.org/show_bug.cgi?id=160618
2228
2229         Reviewed by Darin Adler.
2230
2231         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2232         * TestWebKitAPI/Tests/WTF/Variant.cpp: Added.
2233         Add tests for the variant implementation.
2234
2235 2016-08-06  Chris Dumez  <cdumez@apple.com>
2236
2237         Write API test to cover crash fix in r204135
2238         https://bugs.webkit.org/show_bug.cgi?id=160587
2239
2240         Reviewed by Darin Adler.
2241
2242         Add API test to cover crash fix in r204135. This reproduces the crash
2243         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
2244         callback.
2245
2246         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2247         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
2248         (TEST):
2249
2250 2016-08-05  Tim Horton  <timothy_horton@apple.com>
2251
2252         run-api-tests should use a headed simulator
2253         https://bugs.webkit.org/show_bug.cgi?id=160611
2254
2255         Reviewed by Sam Weinig.
2256
2257         CADisplayLink doesn't work in a headless simulator, but is
2258         vital for the proper functioning of WebKit2 painting on iOS.
2259         So, we should not use a headless simulator.
2260
2261         * Scripts/run-api-tests:
2262         Launch a simulator app, don't just boot the simulator.
2263
2264         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
2265         Re-enable a test that works now.
2266
2267 2016-08-05  Dan Bernstein  <mitz@apple.com>
2268
2269         [Cocoa] WKRemoteObjectCoder doesn’t handle NSRange
2270         https://bugs.webkit.org/show_bug.cgi?id=160589
2271
2272         Reviewed by Tim Horton.
2273
2274         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
2275         (remoteObjectInterface): Fixed a mistake in the set of allowed classes in one of the reply
2276           blocks, which wasn’t caught because the test wasn’t run correctly.
2277         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
2278         (TEST): Fixed the -selectionAndClickInformationForClickAtPoint:completionHandler: test, and
2279           added a test that sends over an NSRange.
2280         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
2281         (-[RemoteObjectRegistryPlugIn takeRange:completionHandler:]): Added. Calls the completion
2282           handler with the range‘s location and length.
2283
2284 2016-08-05  Enrica Casucci  <enrica@apple.com>
2285
2286         Fixing tests failing after r204175.
2287
2288         Unreviewed.
2289
2290         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:
2291
2292 2016-08-05  Enrica Casucci  <enrica@apple.com>
2293
2294         Build fix after 204053.
2295
2296         Unreviewed.
2297
2298         * TestWebKitAPI/Configurations/Base.xcconfig:
2299         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
2300         (-[MockContentFilterEnabler initWithCoder:]):
2301         (-[MockContentFilterEnabler dealloc]):
2302
2303 2016-08-05  Konstantin Tokarev  <annulen@yandex.ru>
2304
2305         Print test name in "Last character read from DRT..." error message.
2306         https://bugs.webkit.org/show_bug.cgi?id=160559
2307
2308         Reviewed by Michael Catanzaro.
2309
2310         * Scripts/webkitpy/port/driver.py:
2311         (Driver.run_test):
2312         (Driver._read_first_block):
2313         (Driver._read_optional_image_block):
2314         (Driver._read_block):
2315         * Scripts/webkitpy/port/driver_unittest.py:
2316         (DriverTest.test_read_block):
2317         (DriverTest.test_read_binary_block):
2318         (DriverTest.test_read_base64_block):
2319
2320 2016-08-05  Commit Queue  <commit-queue@webkit.org>
2321
2322         Unreviewed, rolling out r204123.
2323         https://bugs.webkit.org/show_bug.cgi?id=160597
2324
2325         Caused layout test timeouts on Windows. (Requested by perarne
2326         on #webkit).
2327
2328         Reverted changeset:
2329
2330         "[Win] Unable to reliably run tests in parallel"
2331         https://bugs.webkit.org/show_bug.cgi?id=140914
2332         http://trac.webkit.org/changeset/204123
2333
2334 2016-08-04  Saam Barati  <sbarati@apple.com>
2335
2336         Restore CodeBlock jettison code to jettison when a CodeBlock has been alive for a long time
2337         https://bugs.webkit.org/show_bug.cgi?id=151241
2338
2339         Reviewed by Benjamin Poulain.
2340
2341         * Scripts/run-jsc-stress-tests:
2342
2343 2016-08-04  Dean Johnson  <dean_johnson@apple.com>
2344
2345         UI improvements to Flakiness Dashboard.
2346         https://bugs.webkit.org/show_bug.cgi?id=153295
2347
2348         Reviewed by Alexey Proskuryakov.
2349
2350         * TestResultServer/static-dashboards/flakiness_dashboard.css:
2351         (td.options-container): Center text in most fields.
2352         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2353         (createBugHTML): Text/Grammar updates.
2354         (tableHeaders): Ditto.
2355         (htmlForSingleTestRow): Ditto.
2356         (headerForTestTableHtml): Ditto.
2357         * TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.
2358         (ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.
2359
2360 2016-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2361
2362         [GTK] install-dependencies script misses libxslt as build-dependency and some python libs for the run-benchmark script
2363         https://bugs.webkit.org/show_bug.cgi?id=160518
2364
2365         Reviewed by Michael Catanzaro.
2366
2367         * Scripts/webkitpy/thirdparty/__init__.py:
2368         (AutoinstallImportHook._install_twisted): Twisted requires zope.interface.
2369         * gtk/install-dependencies:
2370
2371 2016-08-04  Alexey Proskuryakov  <ap@apple.com>
2372
2373         Optimize bot watcher's dashboard a little
2374         https://bugs.webkit.org/show_bug.cgi?id=160515
2375         rdar://problem/26096900
2376
2377         Reviewed by Lucas Forschler.
2378
2379         Made re-sorting after loading an iteration more efficient.
2380
2381         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2382         (BuildbotIteration.prototype._updateWithData):
2383         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2384         (BuildbotQueue.prototype.updateIterationPosition):
2385
2386 2016-08-04  Per Arne Vollan  <pvollan@apple.com>
2387
2388         [Win] Unable to reliably run tests in parallel
2389         https://bugs.webkit.org/show_bug.cgi?id=140914
2390
2391         Reviewed by Brent Fulgham.
2392
2393         The cygpath utility function can fail badly when running with multiple DumpRenderTree
2394         processes. We can use string replacement to convert the Cygwin path to a Windows path
2395         instead.
2396  
2397         * Scripts/webkitpy/common/system/path.py:
2398         (cygpathFast):
2399         * Scripts/webkitpy/port/driver.py:
2400         (Driver._command_from_driver_input):
2401
2402 2016-08-03  Aakash Jain  <aakash_jain@apple.com>
2403
2404         Document instructions for increasing process and file limits
2405         https://bugs.webkit.org/show_bug.cgi?id=160528
2406         rdar://problem/24777576
2407
2408         Reviewed by Alexey Proskuryakov.
2409
2410         * Scripts/webkitpy/port/ios.py:
2411         (IOSSimulatorPort.default_child_processes):
2412
2413 2016-08-03  Anders Carlsson  <andersca@apple.com>
2414
2415         Remove the Objective-C bindings generator
2416         https://bugs.webkit.org/show_bug.cgi?id=160526
2417
2418         Reviewed by Sam Weinig.
2419
2420         * Scripts/run-bindings-tests:
2421         Update test.
2422
2423 2016-08-03  Tim Horton  <timothy_horton@apple.com>
2424
2425         Revise a TestWebKitAPI comment to mention the actual underlying problem
2426
2427         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
2428         Note that this is because of https://bugs.webkit.org/show_bug.cgi?id=160516
2429
2430 2016-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2431
2432         Benchmark test content-animation timeouts always
2433         https://bugs.webkit.org/show_bug.cgi?id=160057
2434
2435         Reviewed by Simon Fraser.
2436
2437         * Scripts/webkitpy/benchmark_runner/data/plans/Skipped: Added.
2438         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2439         (start):
2440
2441 2016-08-02  Nan Wang  <n_wang@apple.com>
2442
2443         AX: Simulated touch events are not working on iOS
2444         https://bugs.webkit.org/show_bug.cgi?id=160395
2445         <rdar://problem/27633597>
2446
2447         Reviewed by Chris Fleizach.
2448
2449         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2450         (WTR::AccessibilityUIElement::press):
2451         (WTR::AccessibilityUIElement::setSelectedChild):
2452
2453 2016-08-02  Filip Pizlo  <fpizlo@apple.com>
2454
2455         run-javascriptcore-tests should accept multiple --extra-tests
2456         https://bugs.webkit.org/show_bug.cgi?id=160486
2457
2458         Reviewed by Saam Barati.
2459         
2460         We want to be able to pass --extra-tests multiple times, to supply an arbitrary number of extra
2461         test suites. This does it by using GetOpt::Long's array support.
2462
2463         * Scripts/run-javascriptcore-tests:
2464         (runJSCStressTests):
2465
2466 2016-08-02  Enrica Casucci  <enrica@apple.com>
2467
2468         Allow building with content filtering disabled.
2469         https://bugs.webkit.org/show_bug.cgi?id=160454
2470
2471         Reviewed by Simon Fraser.
2472
2473         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2474
2475 2016-08-02  Brady Eidson  <beidson@apple.com>
2476
2477         Removing IndexedDB WebsiteData can fail for some users.
2478         https://bugs.webkit.org/show_bug.cgi?id=160463
2479
2480         Reviewed by Alex Christensen.
2481
2482         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
2483
2484 2016-08-01  Alex Christensen  <achristensen@webkit.org>
2485
2486         _WKDownloadDelegate.didReceiveResponse should be called before decideDestinationWithSuggestedFilename
2487         https://bugs.webkit.org/show_bug.cgi?id=160437
2488         <rdar://problem/27578272>
2489
2490         Reviewed by Brady Eidson.
2491
2492         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2493         (-[DownloadDelegate _download:didReceiveResponse:]):
2494         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
2495         (runTest):
2496         Add a boolean to make sure that didReceiveResponse is called before decideDestinationWithSuggestedFilename.
2497
2498 2016-08-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2499
2500         [Tools] The GDB backtrace report tool don't checks the gdb return code.
2501         https://bugs.webkit.org/show_bug.cgi?id=160414
2502
2503         Reviewed by Michael Catanzaro.
2504
2505         * Scripts/webkitpy/port/linux_get_crash_log.py:
2506         (GDBCrashLogGenerator._wait_for_corefile):
2507
2508 2016-08-01  Youenn Fablet  <youenn@apple.com>
2509
2510         Make wpt server generate its certificates in layout test results folder
2511         https://bugs.webkit.org/show_bug.cgi?id=160422
2512
2513         Reviewed by Chris Dumez.
2514
2515         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2516         (WebPlatformTestServer._copy_webkit_test_files): Setting certificate folder to layout tests results directory.
2517
2518 2016-08-01  Jonathan Bedard  <jbedard@apple.com>
2519
2520         Function Call on NULL Object
2521         https://bugs.webkit.org/show_bug.cgi?id=160325
2522
2523         Reviewed by Darin Adler.
2524
2525         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2526         (WTR::InjectedBundle::didReceiveMessageToPage): Changed removeAllWebNotificationPermissions() call to static function call.
2527         * WebKitTestRunner/InjectedBundle/TestRunner.h: Made all web-notification functions static.
2528
2529 2016-08-01  Keith Miller  <keith_miller@apple.com>
2530
2531         We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
2532         https://bugs.webkit.org/show_bug.cgi?id=160372
2533
2534         Rubber stamped by Geoffrey Garen.
2535
2536         This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
2537         a new top level directory, JSTests. Having the tests in the Source directory
2538         was both confusing an inconvenient for people that just want to checkout the
2539         source code of WebKit. Since there is no other obvious place to put all the
2540         JavaScript tests a new top level directory seemed the most sensible.
2541
2542         * Scripts/import-test262-tests:
2543         * Scripts/run-javascriptcore-tests:
2544         * Scripts/update-javascriptcore-test-res:
2545
2546 2016-07-31  Nan Wang  <n_wang@apple.com>
2547
2548         AX: Add a check for touch event listener on iOS accessibility object
2549         https://bugs.webkit.org/show_bug.cgi?id=160388
2550
2551         Reviewed by Chris Fleizach.
2552
2553         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2554         (AccessibilityUIElement::boolAttributeValue):
2555         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2556         (WTR::AccessibilityUIElement::boolAttributeValue):
2557
2558 2016-07-30  Manuel Rego Casasnovas  <rego@igalia.com>
2559
2560         Unreviewed: add myself to the reviewers list.
2561
2562         * Scripts/webkitpy/common/config/contributors.json:
2563
2564 2016-07-29  Alexey Proskuryakov  <ap@apple.com>
2565
2566         Undo r203939, and copy over a rule that clips the logos.
2567
2568         Sierra wasn't the only logo without transparency.
2569
2570         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
2571         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
2572         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2573
2574 2016-07-29  Alan Sien Wei Hshieh  <hshieh@apple.com>
2575
2576         The Sierra asset at build.webkit.org/dashboard/images/Sierra*.png has a white background
2577         https://bugs.webkit.org/show_bug.cgi?id=160377
2578
2579         Reviewed by Brian Weinstein.
2580
2581         Update assets to remove the white background and use a transparent background instead.
2582
2583         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
2584         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
2585
2586 2016-07-29  David Kilzer  <ddkilzer@apple.com>
2587
2588         Ignore most check-webkit-style checks for ANGLE project
2589         <https://webkit.org/b/160333>
2590
2591         Reviewed by Daniel Bates.
2592
2593         * Scripts/webkitpy/style/checker.py: Ignore all checkers except:
2594         - No tabs.
2595         - No spaces at the end of lines.
2596         - No carriage returns (DOS line endings).
2597
2598 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
2599
2600         Media controls are not displayed for some autoplaying videos at certain browser dimensions
2601         https://bugs.webkit.org/show_bug.cgi?id=160360
2602         <rdar://problem/27179484>
2603
2604         Reviewed by Myles C. Maxfield.
2605
2606         Adds two tests verifying that videos may be considered main content as long as they
2607         are large enough and cover a majority of the mainframe's viewport.
2608
2609         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2610         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2611         (TestWebKitAPI::TEST):
2612         * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Added.
2613         * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Added.
2614
2615 2016-07-29  Mark Lam  <mark.lam@apple.com>
2616
2617         Gardening: removed unused variable.
2618
2619         Not reviewed.
2620
2621         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2622         (TestWebKitAPI::TEST):
2623
2624 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
2625
2626         Add TestWebKitAPI support for interacting with media controls
2627         https://bugs.webkit.org/show_bug.cgi?id=160342
2628         <rdar://problem/27610246>
2629
2630         Reviewed by Beth Dakin.
2631
2632         Adds support for testing interaction with some media controls, as well as a basic test
2633         verifying that media control teardown after interaction does not result in a crash.
2634
2635         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2636         (-[WKWebView mouseDownAtPoint:]):
2637         (-[WKWebView performAfterLoading:]):
2638         (TestWebKitAPI::TEST):
2639
2640 2016-07-29  Jonathan Bedard  <jbedard@apple.com>
2641
2642         Crash Log Clobbering on Unbound Crashes
2643         https://bugs.webkit.org/show_bug.cgi?id=160198
2644         <rdar://problem/27472618>
2645
2646         Reviewed by Alexey Proskuryakov.
2647
2648         * Scripts/webkitpy/common/system/crashlogs.py:
2649         (CrashLogs): Fix header order.
2650         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2651         (TestResultWriter.output_filename): Only remove file extension if it is clearly a file extension.
2652
2653 2016-07-29  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2654
2655         Update for contributors.json
2656         https://bugs.webkit.org/show_bug.cgi?id=160294
2657
2658         * Scripts/webkitpy/common/config/contributors.json:
2659
2660 2016-07-28  Myles C. Maxfield  <mmaxfield@apple.com>
2661
2662         Remove deprecated SPI for video inline / fullscreen controls
2663         https://bugs.webkit.org/show_bug.cgi?id=160318
2664
2665         Reviewed by Tim Horton.
2666
2667         * DumpRenderTree/mac/DumpRenderTree.mm:
2668         (setDefaultsToConsistentValuesForTesting): Deleted.
2669         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2670         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
2671         * WebKitTestRunner/TestController.cpp:
2672         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
2673         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2674         (WTR::initializeWebViewConfiguration): Deleted.
2675
2676 2016-07-28  Daniel Bates  <dabates@apple.com>
2677
2678         [iOS] TestWebKitAPI bundle targets are not code signed
2679         https://bugs.webkit.org/show_bug.cgi?id=160328
2680         <rdar://problem/27409246>
2681
2682         Reviewed by Andy Estes.
2683
2684         Workaround <rdar://problem/27459890> by explicitly defining Xcode build settings
2685         CODE_SIGNING_ALLOWED and AD_HOC_CODE_SIGNING_ALLOWED to be YES so as to allow the
2686         the TestWebKitAPI bundle targets to be code signed when building for the iOS simulator.
2687
2688         * TestWebKitAPI/Configurations/Base.xcconfig:
2689
2690 2016-07-28  Tim Horton  <timothy_horton@apple.com>
2691
2692         Disable WebKit2.ResizeWithHiddenContentDoesNotHang for now
2693
2694         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
2695         (animatedResizeWebView):
2696         (TEST):
2697         This test times out only when run in the WebKit Testing simulator environment,
2698         but not in a fresh simulator. Disabling to keep the bots green while under investigation.
2699
2700 2016-07-28  Tim Horton  <timothy_horton@apple.com>
2701
2702         Frequent animation lags when interacting with Safari (sidebar, tab switching, etc.)
2703         https://bugs.webkit.org/show_bug.cgi?id=160289
2704         <rdar://problem/27553464>
2705
2706         Reviewed by Simon Fraser.
2707
2708         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2709         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2710         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Added.
2711         (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]):
2712         (-[AnimatedResizeWebView _endAnimatedResize]):
2713         (animatedResizeWebView):
2714         (TEST):
2715         * TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Added.
2716         Add two tests that ensure that hidden-content and animated resizes
2717         don't cause unnecessary synchronous waits. Only the hidden-content
2718         one fails before my patch, but it seemed reasonable to add both anyway.
2719
2720 2016-07-28  David Kilzer  <ddkilzer@apple.com>
2721
2722         webkit-patch upload --suggest-reviewers shouldn't break in the presence of deleted or moved files
2723         <https://webkit.org/b/83342>
2724
2725         Reviewed by Ryosuke Niwa.
2726
2727         * Scripts/webkitpy/common/checkout/scm/git.py:
2728         (Git.revisions_changing_file): Remove code to raise an exception
2729         when the file doesn't exist.  If a file was moved or renamed,
2730         then this caused the script to terminate, which was very
2731         frustrating when you wanted a list of reviewers.
2732         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2733         (SCMTest._shared_test_revisions_changing_file): Update test
2734         expectation to return an empty list of revisions.
2735         (test_create_patch_is_full_patch): Drive-by fix when running all
2736         webkitpy tests (including scm tests).
2737         * Scripts/webkitpy/common/checkout/scm/svn.py:
2738         (SVN.revisions_changing_file): Catch ScriptError exceptions and
2739         return an empty array of revisions if this occurs.
2740
2741 2016-07-28  Aakash Jain  <aakash_jain@apple.com>
2742
2743         EWS error message "Error: * did not process patch" should include explanation
2744         https://bugs.webkit.org/show_bug.cgi?id=159903
2745         <rdar://problem/27410788>
2746
2747         Reviewed by Alexey Proskuryakov.
2748
2749         * QueueStatusServer/handlers/statusbubble.py:
2750         (StatusBubble._build_bubble): Display more detailed error message on bubbles when patch
2751         is not processed.
2752         * QueueStatusServer/handlers/processingtimesjson.py:
2753         (ProcessingTimesJSON._resultFromFinalStatus): Updated error message to match with rest
2754         of the code.
2755         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2756         (CommitQueueTask.validate): Add more information about validation failure.
2757         (CommitQueueTask.run): Pass the error details in the PatchIsNotValid exception.
2758         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
2759         (EarlyWarningSystemTask.validate): Add more information about validation failure.
2760         (EarlyWarningSystemTask.run): Pass the error details in the PatchIsNotValid exception.
2761         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2762         (PatchIsNotValid.__init__): Add the failure_message argument.
2763         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2764         (AbstractEarlyWarningSystem.review_patch): Re-word the error message and include
2765         failure details.
2766         * Scripts/webkitpy/tool/commands/queues.py:
2767         (CommitQueue.process_work_item): Same.
2768         (StyleQueue.review_patch): Same.
2769         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2770         (test_non_valid_patch): Updated test-cases messages to match the above changes.
2771
2772 2016-07-27  Alexey Proskuryakov  <ap@apple.com>
2773
2774         LayoutTestRelay should wait for WebKitTestRunnerApp installation to complete
2775         https://bugs.webkit.org/show_bug.cgi?id=160262
2776
2777         Reviewed by Daniel Bates.
2778
2779         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2780         (-[LTRelayController installApp]):
2781
2782 2016-07-27  Ryan Haddad  <ryanhaddad@apple.com>
2783
2784         Disable WebCoreNSURLSessionTest API tests on ios-simulator
2785         https://bugs.webkit.org/show_bug.cgi?id=160225
2786
2787         Reviewed by Alexey Proskuryakov.
2788
2789         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
2790
2791 2016-07-27  Miguel Gomez  <magomez@igalia.com>
2792
2793         [GTK] Fix some video/canvas tests that should be passing
2794         https://bugs.webkit.org/show_bug.cgi?id=160023
2795
2796         Reviewed by Carlos Garcia Campos.
2797
2798         Add a platform identifier to the TestRunner's page user agent when the tests are run on the
2799         EFL or GTK platforms.
2800
2801         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2802         (WTR::TestController::platformConfigureViewForTest):
2803         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2804         (WTR::TestController::platformConfigureViewForTest):
2805
2806 2016-07-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2807
2808         [Tools] The built product doesn't contains the dwo files when DEBUG_FISSION is enabled.
2809         https://bugs.webkit.org/show_bug.cgi?id=160247
2810
2811         Reviewed by Michael Catanzaro.
2812
2813         * BuildSlaveSupport/built-product-archive:
2814         (createZip):
2815         (dirContainsdwo):
2816         (archiveBuiltProduct):
2817
2818 2016-07-26  Alex Christensen  <achristensen@webkit.org>
2819
2820         Fix tests after r203743.
2821         https://bugs.webkit.org/show_bug.cgi?id=156947
2822
2823         * WebKitTestRunner/TestController.cpp:
2824         (WTR::TestController::resetStateToConsistentValues):
2825         Reset the new boolean m_rejectsProtectionSpaceAndContinueForAuthenticationChallenges.
2826
2827 2016-07-26  Myles C. Maxfield  <mmaxfield@apple.com>
2828
2829         [iPhone] Playing a video on tudou.com plays only sound, no video
2830         https://bugs.webkit.org/show_bug.cgi?id=160178
2831         <rdar://problem/27535468>
2832
2833         Reviewed by Dan Bernstein.
2834
2835         * DumpRenderTree/mac/DumpRenderTree.mm:
2836         (setDefaultsToConsistentValuesForTesting):
2837         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2838         (RequiresUserActionForPlaybackTest::SetUp):
2839         * WebKitTestRunner/TestController.cpp:
2840         (WTR::TestController::resetPreferencesToConsistentValues):
2841         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2842         (WTR::initializeWebViewConfiguration):
2843
2844 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
2845
2846         Allow LOG macros to be used outside the namespace, and other logging cleanup
2847         https://bugs.webkit.org/show_bug.cgi?id=160216
2848
2849         Reviewed by Anders Carlsson.
2850         
2851         initializeLoggingChannelsIfNecessary -> initializeLogChannelsIfNecessary
2852
2853         * DumpRenderTree/TestRunner.cpp:
2854         * DumpRenderTree/mac/DumpRenderTree.mm:
2855         (resetWebViewToConsistentStateBeforeTesting):
2856
2857 2016-07-26  David Kilzer <ddkilzer@apple.com>
2858
2859         Networking process crash due to missing -[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:] implementation
2860         https://bugs.webkit.org/show_bug.cgi?id=156947
2861         <rdar://problem/23325160>
2862
2863         Reviewed by Alex Christensen.
2864
2865         * DumpRenderTree/TestRunner.cpp:
2866         (TestRunner::TestRunner):
2867         (setRejectsProtectionSpaceAndContinueForAuthenticationChallengesCallback):
2868         * DumpRenderTree/TestRunner.h:
2869         (TestRunner::rejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2870         (TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2871         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2872         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
2873         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2874         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2875         (WTR::TestRunner::queueNonLoadingScript):
2876         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2877         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2878         * WebKitTestRunner/TestController.cpp:
2879         (WTR::TestController::didReceiveAuthenticationChallenge):
2880         * WebKitTestRunner/TestController.h:
2881         (WTR::TestController::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2882         * WebKitTestRunner/TestInvocation.cpp:
2883         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2884         Add TestRunner.setRejectsProtectionSpaceAndContinueForAuthenticationChallenges to use for testing.
2885
2886 2016-07-26  David Kilzer  <ddkilzer@apple.com>
2887
2888         check-for-exit-time-destructors should be usable outside Xcode
2889         <https://webkit.org/b/160195>
2890
2891         Reviewed by Darin Adler.
2892
2893         * Scripts/check-for-exit-time-destructors: Update to parse
2894         -h|--help switch, or to take one argument to a binary to check
2895         for exit time destructors on the command-line.  The clang
2896         compiler will find these at compile-time with the
2897         -Wexit-time-destructors switch, but this script will check for
2898         them after-the-fact.
2899
2900 2016-07-26  Lucas Forschler  <lforschler@apple.com>
2901
2902         Test svn.webkit.org functionality after maintenance.
2903
2904 2016-07-25  Brady Eidson  <beidson@apple.com>
2905
2906         Modern IDB: Make sure IndexedDB works from file:// url documents by default
2907         https://bugs.webkit.org/show_bug.cgi?id=153783
2908
2909         Reviewed by Alex Christensen.
2910
2911         Previously, to grant IndexedDB access to file:// urls for testing purposes, 
2912         we had to call the SPI [WKWebViewConfiguration _setAllowUniversalAccessFromFileURLs:].
2913         
2914         As of https://trac.webkit.org/changeset/203695 this is no longer required.
2915         
2916         Change the relevant API tests to make sure this continues to be no longer required.
2917
2918         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
2919         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
2920         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
2921         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
2922         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
2923         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
2924
2925 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2926
2927         Media controls should not be displayed for a video until it starts playing
2928         https://bugs.webkit.org/show_bug.cgi?id=160092
2929         <rdar://problem/26986673>
2930
2931         Reviewed by Beth Dakin.
2932
2933         Verify that multiple videos do or don't show the media controller depending on whether videos
2934         are playing. Also tweaks an existing API test (VideoControlsManagerSingleLargeVideo) that was
2935         passing because we were always showing media controls for large videos with audio, even if they
2936         had not played back yet. This change ensures that large videos with audio show media controls
2937         only after they begin to play back, and not by virtue of being large enough for main content.
2938
2939         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2940         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2941         (TestWebKitAPI::TEST):
2942         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
2943         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: Added.
2944         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio.html: Added.
2945
2946 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2947
2948         Media controls on apple.com don't disappear when movie finishes playing
2949         https://bugs.webkit.org/show_bug.cgi?id=160068
2950         <rdar://problem/26668526>
2951
2952         Reviewed by Darin Adler.
2953
2954         Adds new API tests. Please see WebCore ChangeLog for more details.
2955
2956         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2957         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2958         (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]):
2959         (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
2960         (TestWebKitAPI::TEST):
2961         (-[DidPlayMessageHandler initWithWKWebView:]): Deleted.
2962         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
2963         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: Added.
2964         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: Added.
2965         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: Added.
2966
2967 2016-07-25  Philippe Normand  <pnormand@igalia.com>
2968
2969         Unreviewed, fix test-webkitpy after r203674.
2970
2971         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2972         (GDBCrashLogGeneratorTest.test_generate_crash_log):
2973
2974 2016-07-24  Philippe Normand  <pnormand@igalia.com>
2975
2976         Unreviewed, forgot to commit this file in r203674.
2977
2978         * Scripts/process-linux-coredump: Added.
2979         (main):
2980
2981 2016-07-25  Philippe Normand  <pnormand@igalia.com>
2982
2983         Improve GDB backtrace generation for GTK/EFL
2984         https://bugs.webkit.org/show_bug.cgi?id=128928
2985
2986         Reviewed by Carlos Garcia Campos.
2987
2988         The PID of the crashed process is now correctly supplied to the
2989         crash log reporter. The kernel core_pattern needs to be updated
2990         after this change to something like:
2991
2992         echo "|/home/phil/WebKit/Tools/Scripts/process-linux-coredump /tmp/core-pid_%p.dump" > /proc/sys/kernel/core_pattern
2993
2994         * Scripts/process-linux-coredump: Added.
2995         (main): Minimal python script reading coredump data on stdin and writing it to a file in /tmp/.
2996         * Scripts/webkitpy/port/efl.py:
2997         (EflPort._get_crash_log): Supply path of the process-linux-coredump script.
2998         * Scripts/webkitpy/port/gtk.py:
2999         (GtkPort._get_crash_log): Ditto.
3000         * Scripts/webkitpy/port/linux_get_crash_log.py:
3001         (GDBCrashLogGenerator.__init__): New argument for supplying the path of a coredump processor script.
3002         (GDBCrashLogGenerator.generate_crash_log): Update error message, the core_pattern should now be set to pipe coredumps to a script.
3003         (GDBCrashLogGenerator): Deleted.
3004         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
3005         (GDBCrashLogGeneratorTest.test_generate_crash_log): Update test expectations.
3006         * WebKitTestRunner/TestController.cpp:
3007         (WTR::TestController::networkProcessDidCrash): Supply PID of crash process.
3008         (WTR::TestController::databaseProcessDidCrash): Ditto.
3009         (WTR::TestController::processDidCrash): Ditto.
3010
3011 2016-07-23  Youenn Fablet  <youenn@apple.com>
3012
3013         WPT stash server should be kept running when launching wpt server
3014         https://bugs.webkit.org/show_bug.cgi?id=160052
3015
3016         Reviewed by Sam Weinig.
3017
3018         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
3019         (main): waiting to read stdin while stash server is started.
3020
3021 2016-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3022
3023         Media controls should be displayed for media in media documents
3024         https://bugs.webkit.org/show_bug.cgi?id=160104
3025         <rdar://problem/27438936>
3026
3027         Reviewed by Myles C. Maxfield.
3028
3029         Verifies that even a small video with audio in a media document gets media controls.
3030
3031         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3032         (TestWebKitAPI::TEST):
3033
3034 2016-07-22  Michael Saboff  <msaboff@apple.com>
3035
3036         REGRESSION(203616): no FTL testing was inadvertently removed
3037         https://bugs.webkit.org/show_bug.cgi?id=160100
3038
3039         Rubber-stamped by Filip Pizlo.
3040
3041         Added runNoFTL back into the set of tests we run on FTL enabled platforms.
3042         Renamed runLayoutTestNoFTL to runLayoutTestDefault.  Restructured the test
3043         logic for the runLayout and runNoisy variants to match the run test logic,
3044         that is we always invoke runXXXDefault and invoke runXXXNoFTL for FTL
3045         enabled platforms.
3046
3047         * Scripts/run-jsc-stress-tests:
3048
3049 2016-07-22  Brady Eidson  <beidson@apple.com>
3050
3051         Removing IndexedDatabases that have stored blobs doesn't remove the blob files.
3052         https://bugs.webkit.org/show_bug.cgi?id=160089
3053
3054         Reviewed by Darin Adler.
3055
3056         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3057         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm: Added.
3058         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobToBeDeleted.html: Added.
3059
3060 2016-07-22  Konstantin Tokarev  <annulen@yandex.ru>
3061
3062         [GTK] Improved exclusion patterns in make-dist.py manifest.
3063         https://bugs.webkit.org/show_bug.cgi?id=160094
3064
3065         Reviewed by Michael Catanzaro.
3066
3067         * gtk/manifest.txt.in:
3068         Exclude Platform*.cmake files for more ports.
3069         Removed obsolete .gyp and .pro.user patterns.
3070         Exclude 'Configurations' and 'spi' directories.
3071         Exclude CMakeLists.txt.user (Qt Creator IDE).
3072
3073 2016-07-22  Michael Saboff  <msaboff@apple.com>
3074
3075         Don't run FTL related JSC stress tests on non-FTL platforms
3076         https://bugs.webkit.org/show_bug.cgi?id=160033
3077
3078         Reviewed by Mark Lam.
3079
3080         Added check for running tests on platforms that don't enable FTL to not run FTL tests.
3081         Refactored several of the runXXX test methods to always runXXXDefault and made those
3082         runXXXDefault to pass FTL_OPTIONS.  For platforms that don't enable the FTL, FTL_OPTIONS
3083         doesn't cause a problem.
3084
3085         * Scripts/run-jsc-stress-tests:
3086
3087 2016-07-22  Per Arne Vollan  <pvollan@apple.com>
3088
3089         IWebView::mainFrame crashes if called after IWebView::close
3090         https://bugs.webkit.org/show_bug.cgi?id=32868
3091
3092         Reviewed by Brent Fulgham.
3093
3094         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
3095         (TestWebKitAPI::TEST_F): Added test.
3096
3097 2016-07-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3098
3099         [GTK] Enable threaded compositor by default
3100         https://bugs.webkit.org/show_bug.cgi?id=160079
3101
3102         Reviewed by Žan Doberšek.
3103
3104         * Scripts/webkitperl/FeatureList.pm:
3105
3106 2016-07-22  Youenn Fablet  <youenn@apple.com>
3107
3108         run-builtins-generator-tests should be able to test WebCore builtins wrapper with more than one file
3109         https://bugs.webkit.org/show_bug.cgi?id=159921
3110
3111         Reviewed by Brian Burg.
3112
3113         Updated builtin generator test runner to generate WebCore wrapper files based on all WebCore valid separate files.
3114
3115         * Scripts/webkitpy/codegen/main.py:
3116         (BuiltinsGeneratorTests.generate_from_js_builtins): Passing a list of builtin files to the script.
3117         (BuiltinsGeneratorTests):
3118         (BuiltinsGeneratorTests.single_builtin_test): Added to handle the case of single builtin generation.
3119         (BuiltinsGeneratorTests.wrappers_builtin_test): Added to handle the case of WebCore wrappers builtin generation.
3120         (BuiltinsGeneratorTests.run_test): Helper routine to run a test in reset mode or normal check mode.
3121         (BuiltinsGeneratorTests.run_tests): Updated to add WebCore wrappers builtin generation test.
3122
3123 2016-07-21  Dan Bernstein  <mitz@apple.com>
3124
3125         [Mac] webkitdirs.pm contains unused code to support outdated OS X and Xcode versions
3126         https://bugs.webkit.org/show_bug.cgi?id=160072
3127
3128         Reviewed by Andy Estes.
3129
3130         * Scripts/webkitdirs.pm:
3131         (readXcodeUserDefault): Changed to take a defaults key rather than a suffix. Removed support
3132           for old Xcode versions.
3133         (determineBaseProductDir): Removed support for old Xcode versions. Updated for the change
3134           to readXcodeUserDefault.
3135         (debugger): Deleted. This was only used for Darwin, where LLDB is now the only supported
3136           debugger.
3137         (determineDebugger): Ditto.
3138         (checkRequiredSystemConfig): Updated to require at least OS X Yosemite v10.10.5 and Xcode
3139           7.0.
3140         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Removed --use-gdb and --use-lldb
3141           switches.
3142         (execMacWebKitAppForDebugging): Removed support for GDB.
3143
3144 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
3145
3146         Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
3147         https://bugs.webkit.org/show_bug.cgi?id=160066
3148
3149         Reviewed by Dean Jackson.
3150
3151         * DumpRenderTree/mac/DumpRenderTree.mm:
3152         (setDefaultsToConsistentValuesForTesting): Deleted.
3153         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
3154         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
3155         * WebKitTestRunner/TestController.cpp:
3156         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
3157         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3158         (WTR::initializeWebViewConfiguration): Deleted.
3159
3160 2016-07-21  Chelsea Pugh  <cpugh@apple.com>
3161
3162         [iOS] Apps using WKWebView will crash if they set the scroll view's delegate and don't nil it out later
3163         https://bugs.webkit.org/show_bug.cgi?id=159980
3164         rdar://problem/27450825
3165
3166         Reviewed by Dan Bernstein.
3167
3168         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3169         * TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm: Added.
3170         (-[TestDelegateForScrollView dealloc]): Update delegateIsDeallocated to true so that we can tell
3171         when our delegate has hit -dealloc.
3172         (TestWebKitAPI::TEST): Ensure that after an object has been set as the scroll view's delegate,
3173         and has then been deallocated, that the scroll view's delegate is nil and the deallocated delegate
3174         will not be messaged.
3175
3176 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
3177
3178         Follow-up patch to r203520
3179         https://bugs.webkit.org/show_bug.cgi?id=159967
3180         <rdar://problem/26964090>
3181
3182         Unreviewed.
3183
3184         * DumpRenderTree/mac/DumpRenderTree.mm:
3185         (setDefaultsToConsistentValuesForTesting):
3186         * WebKitTestRunner/TestController.cpp:
3187         (WTR::TestController::resetPreferencesToConsistentValues):
3188
3189 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
3190
3191         [iPhone] Playing a video on tudou.com plays only sound, no video
3192         https://bugs.webkit.org/show_bug.cgi?id=159967
3193         <rdar://problem/26964090>
3194
3195         Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson.
3196
3197         Migrate tests to use new SPI.
3198
3199         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
3200         (RequiresUserActionForPlaybackTest::SetUp):
3201         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3202         (WTR::initializeWebViewConfiguration):
3203
3204 2016-07-21  Csaba Osztrogonác  <ossy@webkit.org>
3205
3206         Clarify testing mode names in run-jsc-stress-tests
3207         https://bugs.webkit.org/show_bug.cgi?id=160021
3208
3209         Reviewed by Mark Lam.
3210
3211         Default should mean really default, not default with disabled FTL, renamed
3212         - runMozillaTestDefault to runMozillaTestNoFTL
3213         - runMozillaTestDefaultFTL to runMozillaTestDefault
3214         - runDefault to runNoFTL
3215         - runDefaultFTL to runDefault
3216         - runLayoutTestDefault to runLayoutTestNoFTL
3217         - runLayoutTestDefaultFTL to runLayoutTestDefault
3218         - runNoisyTestDefault to runNoisyTestNoFTL
3219         - runNoisyTestDefaultFTL to runNoisyTestDefault
3220
3221         * Scripts/run-jsc-stress-tests:
3222
3223 2016-07-21  Yongjun Zhang  <yongjun_zhang@apple.com>
3224
3225         WebBackForwardList's currentIndex could get out of bounds when filtering items.
3226         https://bugs.webkit.org/show_bug.cgi?id=159986
3227
3228         Add a test to verify filtering out 2 items from a 3-item list will set the currentIndex
3229         to 0.
3230
3231         Reviewed by Dan Bernstein.
3232
3233         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3234         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: Added.
3235         (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]):
3236         (TEST):
3237
3238 2016-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3239
3240         [GTK] Web view background colors don't work in accelerated compositing mode
3241         https://bugs.webkit.org/show_bug.cgi?id=159455
3242
3243         Reviewed by Michael Catanzaro.
3244
3245         Set always RGBA visual to the view widget when setting a background color.
3246
3247         * MiniBrowser/gtk/BrowserWindow.c:
3248         (browser_window_set_background_color):
3249
3250 2016-07-20  Youenn Fablet  <youenn@apple.com>
3251
3252         Bots should run built-ins generator tests
3253         https://bugs.webkit.org/show_bug.cgi?id=159971
3254
3255         Reviewed by Alexey Proskuryakov.
3256
3257         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3258         (RunBuiltinsTests): New step to run built-in generator tests.
3259         (TestFactory.__init__): Adding an additional step for bultin generator tests.
3260         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Rebasing expectations.
3261         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Adding additional step for proper display.
3262
3263 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
3264
3265         Revert temporary fix r203417
3266         https://bugs.webkit.org/show_bug.cgi?id=160001
3267
3268         Reviewed by Alexey Proskuryakov.
3269
3270         * EWSTools/start-queue-mac.sh: Revert the temporary fix.
3271
3272 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
3273
3274         REGRESSION(r148588): ews classes might get garbage collected
3275         https://bugs.webkit.org/show_bug.cgi?id=159990
3276
3277         Reviewed by Ryosuke Niwa.
3278
3279         * Scripts/webkitpy/tool/commands/__init__.py: Store the loaded ews classes
3280         in a variable so that they do not get garbage collected.
3281
3282 2016-07-20  Jeremy Jones  <jeremyj@apple.com>
3283
3284         Add API test for layout constraints after exit fullscreen
3285         https://bugs.webkit.org/show_bug.cgi?id=159900
3286
3287         Reviewed by Jon Lee.
3288
3289         Added Fullscreen.LaytoutConstraints API test. 
3290         Tests fix from https://bugs.webkit.org/show_bug.cgi?id=159731
3291
3292         This test compares layout constraints on the web view before and after fullscreen to make sure 
3293         they are preserved.
3294
3295         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.html: Added.
3296         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm: Added.
3297         (-[FullscreenStateChangeMessageHandler userContentController:didReceiveScriptMessage:]):
3298         (TestWebKitAPI::TEST):
3299
3300 2016-07-20  Ryan Haddad  <ryanhaddad@apple.com>
3301
3302         Disable two failing API tests.
3303
3304         Unreviewed test gardening.
3305
3306         * TestWebKitAPI/Tests/mac/CandidateTests.mm:
3307         (TestWebKitAPI::TEST):
3308
3309 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3310
3311         Unreviewed iOS build fix.
3312
3313         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Only import Carbon.h on Mac.
3314
3315 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3316
3317         Media controls don't appear when pausing a small autoplaying video
3318         https://bugs.webkit.org/show_bug.cgi?id=159972
3319         <rdar://problem/27180657>
3320
3321         Reviewed by Beth Dakin.
3322
3323         Adds a new test that verifies media controls show up when pausing a small autoplayed video. Also adds mechanisms
3324         for simulating basic user interaction in VideoControlsManager.
3325
3326         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3327         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3328         (-[WKWebView mouseDownAtPoint:]):
3329         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
3330         (-[OnLoadMessageHandler initWithWKWebView:handler:]):
3331         (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]):
3332         (TestWebKitAPI::TEST):
3333         * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: Added.
3334
3335 2016-07-20  Per Arne Vollan  <pvollan@apple.com>
3336
3337         [Win] MathML fonts are not found.
3338         https://bugs.webkit.org/show_bug.cgi?id=159920
3339
3340         Reviewed by Alex Christensen.
3341
3342         When looking up a font in the registry, use the /v option of the Windows 'reg query' command to query
3343         for a specific registry key value.
3344
3345         * Scripts/webkitdirs.pm:
3346         (fontExists):
3347
3348 2016-07-20  Joseph Pecoraro  <pecoraro@apple.com>
3349
3350         Improve prepare-ChangeLog for @media blocks
3351         https://bugs.webkit.org/show_bug.cgi?id=159907
3352
3353         Reviewed by Timothy Hatcher.
3354
3355         * Scripts/prepare-ChangeLog:
3356         (get_selector_line_ranges_for_css):
3357         Get a range for @media blocks just like a selector.
3358             Start Line = line with '{'
3359             End line = line with '}'
3360             Name = "@media ..."
3361
3362         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt:
3363         Improved error messages for unbalanced portions.
3364
3365         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt:
3366         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css:
3367         (.media-query::before):
3368         (@media only screen and (max-width: 980px)):
3369         (.media-query a):
3370         (@media (-webkit-min-device-pixel-ratio: 2)):
3371         (.both a):
3372         (.both b):
3373         (.media-query b):
3374         (.media-query::after):
3375
3376 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
3377
3378         Fix expectedFailErrorHandler in run-jsc-stress-tests
3379         https://bugs.webkit.org/show_bug.cgi?id=159811
3380
3381         Reviewed by Yusuke Suzuki.
3382
3383         * Scripts/run-jsc-stress-tests:
3384
3385 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
3386
3387         Unreviewed Mac cmake buildfix after r203426. Just for fun.
3388
3389         * TestWebKitAPI/PlatformMac.cmake:
3390
3391 2016-07-19  Filip Pizlo  <fpizlo@apple.com>
3392
3393         The default testing mode should not involve disabling the FTL JIT
3394         https://bugs.webkit.org/show_bug.cgi?id=159929
3395
3396         Rubber stamped by Mark Lam and Saam Barati.
3397         
3398         It used to be the case that most actively maintained ports did not have the FTL JIT enabled.
3399         Heck, for most of the FTL's initial development, it wasn't enabled anywhere. So, testing the
3400         FTL was not the default. You had to enable it with an option.
3401         
3402         For some reason we have kept this arrangement even though the FTL JIT is now the default on
3403         all of the major ports. This has become a serious pain. For example, it's useful to be able
3404         to say that a test should only run in the default config that is representative of what a
3405         normal user would see if they ran JSC. Clearly, this would be a config that does not
3406         explicitly disable the FTL JIT on the command line. However, if you try to specify this then
3407         your test won't run at all if the --ftl-jit option is not passed. That's dangerous!
3408         
3409         So, this change gets rid of all of this logic. I think it's better to get rid of it then to
3410         try to fix it, because:
3411         
3412         - I don't know what the fix would look like. Presumably it would ensure that ports that don't
3413           have the FTL enabled never run any tests that explicitly disable the FTL, since that
3414           doesn't do anything. The code is not really structured to allow this.
3415         
3416         - It benefits a minority of clients. Three build bots run tests in a config that has the FTL
3417           disabled in testing. On the other hand there are already build bots that do FTL tests
3418           despite having the FTL disabled by virtue of being a 32-bit platform. So, maybe rather than
3419           preserving this broken feature, we should create something that (a) acknowledges the fact
3420           that the FTL is the default on those platforms that support it and (b) avoids running
3421           no-ftl tests on precisely those platforms that don't have FTL.
3422         
3423         - To the extent that some bots benefited from disabling FTL tests, they were doing it by
3424           relying on a feature that was never meant to stick around. The FTL JIT is meant to be the
3425           default configuration. Disabling the FTL JIT is the non-default. So, we shouldn't be
3426           pretending that the FTL JIT is not the default just because some bots used that as an
3427           optimization.
3428         
3429         This change allows me to speed up some debug tests and paint some bots green.
3430
3431         * Scripts/run-javascriptcore-tests:
3432         (runJSCStressTests):
3433         * Scripts/run-jsc-stress-tests:
3434
3435 2016-07-19  Alex Christensen  <achristensen@webkit.org>
3436
3437         Fix API test after r203426.
3438         https://bugs.webkit.org/show_bug.cgi?id=159949
3439
3440         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3441         (TEST):
3442         If there is website data already on disk, the initial count after putting the AppCache data in place will not be exactly 1.
3443         This is no problem.  We want to verify that it is a nonzero number and that it decrements by one when we remove the 1 AppCache data.
3444
3445 2016-07-19  Andy Estes  <aestes@apple.com>
3446
3447         Move WebKitErrorFrameLoadBlockedByContentFilter from WebKitErrors.h to WebKitErrorsPrivate.h
3448         https://bugs.webkit.org/show_bug.cgi?id=159956
3449
3450         Reviewed by Dan Bernstein.
3451
3452         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Included WKErrorRef.h.
3453         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3454         Used kWKErrorCodeFrameLoadBlockedByContentFilter instead of WebKitErrorFrameLoadBlockedByContentFilter.
3455         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Included WebKitErrorsPrivate.h instead of WebKitErrors.h.
3456
3457 2016-07-19  Alex Christensen  <achristensen@webkit.org>
3458
3459         Add regression test for r203392
3460         https://bugs.webkit.org/show_bug.cgi?id=159949
3461
3462         Reviewed by Brady Eidson.
3463
3464         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3465         (fileSize):
3466         (swizzledBundleIdentifierWebBookmarksD):
3467         (defaultApplicationCacheDirectory):
3468         (TEST):
3469         (swizzledBundleIdentifierMobileSafari): Deleted.
3470         This actually tests that webbookmarksd uses the path quirk in WebsiteDataStore::defaultApplicationCacheDirectory.
3471         I wanted to verify that it uses the same path as MobileSafari, but swizzling out the bundleIdentifier twice caused
3472         problems with the static bools that are set once in RuntimeApplicationChecks.mm.
3473
3474 2016-07-19  Alex Christensen  <achristensen@webkit.org>
3475
3476         Add regression test for r203392
3477         https://bugs.webkit.org/show_bug.cgi?id=159949
3478
3479         Reviewed by Brady Eidson.
3480
3481         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3482         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db: Added.
3483         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-shm: Added.
3484         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-wal: Added.
3485         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3486         (TEST):
3487         (fileSize):
3488         (swizzledBundleIdentifierMobileSafari):
3489         (swizzledBundleIdentifierWebBookmarksD):
3490         (defaultApplicationCacheDirectory):
3491         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.h: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.h.
3492         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.mm: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.mm.
3493         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Removed.
3494         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Removed.
3495
3496 2016-07-19  Keith Miller  <keith_miller@apple.com>
3497
3498         Test262 should have a file with the revision and url
3499         https://bugs.webkit.org/show_bug.cgi?id=159937
3500
3501         Reviewed by Mark Lam.
3502
3503         The import script should update the information from
3504         the path to the test262 repository it gets.
3505
3506         * Scripts/import-test262-tests:
3507
3508 2016-07-19  Alexey Proskuryakov  <ap@apple.com>
3509
3510         Temporary workaround for iOS EWS failing after the fix for bug 159539.
3511         To be deleted once the root cause is found and addressed.
3512
3513         * EWSTools/start-queue-mac.sh:
3514
3515 2016-07-19  Frederic Wang  <fwang@igalia.com>
3516
3517         [win] Fixup the register name for STIX Math and Latin Modern Math
3518
3519         Unreviewed follow-up of r203406
3520
3521         * Scripts/webkitdirs.pm:
3522         (checkInstalledTools):
3523
3524 2016-07-19  Frederic Wang  <fwang@igalia.com>
3525
3526         [win] Update the list of MathML fonts
3527         https://bugs.webkit.org/show_bug.cgi?id=156838
3528
3529         The set of recommended math fonts is now described at
3530         https://trac.webkit.org/wiki/MathML/Fonts
3531         We update the Perl script to use the latest list of fonts.
3532
3533         Reviewed by Brent Fulgham.
3534
3535         * Scripts/webkitdirs.pm:
3536         (checkInstalledTools):
3537
3538 2016-07-19  Per Arne Vollan  <pvollan@apple.com>
3539
3540         [Win] The test fast/scrolling/overflow-scroll-past-max.html is timing out.
3541         https://bugs.webkit.org/show_bug.cgi?id=159342
3542
3543         Reviewed by Darin Adler.
3544
3545         Implement required functions in event sender.
3546
3547         * DumpRenderTree/PlatformWin.cmake:
3548         * DumpRenderTree/win/EventSender.cpp:
3549         (monitorWheelEvents): Added.
3550         (callAfterScrollingCompletes): Added.
3551
3552 2016-07-19  Youenn Fablet  <youenn@apple.com>
3553
3554         Add new aliases to http test server
3555         https://bugs.webkit.org/show_bug.cgi?id=159878
3556
3557         Reviewed by Darin Adler.
3558
3559         Adding testharness.css, testharness.js and testharnessreport.js new aliases to http test servers.
3560         Adding explicitly these links to perl script.
3561         Extracting default alias in an aliases.json file.
3562         Reading that file from python scripts to initialize aliases from that file.
3563
3564         Python script changes covered by unit tests and changed layout test.
3565
3566         * Scripts/webkitperl/httpd.pm:
3567         (getDefaultConfigForTestDirectory): Adding 3 new aliases
3568         * Scripts/webkitpy/layout_tests/servers/aliases.json: Added.
3569         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3570         (LayoutTestApacheHttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
3571         Adding -c directives for each alias.
3572         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
3573         (TestLayoutTestApacheHttpd.test_start_cmd): Adding aliases.json mock-up file.
3574         * Scripts/webkitpy/layout_tests/servers/http_server.py:
3575         (Lighttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
3576         Adding alias directive for each alias.
3577         (Lighttpd._prepare_config):
3578         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
3579         (HttpServerBase.__init__): Adding tests_dir member with a default value being layout tests directory.
3580         (HttpServerBase.aliases): Computing of alias from the json file, paths to the real files being relative to
3581         layout tests directory.
3582         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
3583         (TestHttpServer.test_start_cmd): Adding aliases.json mock-up file and updating test expectation.
3584         (TestHttpServer.test_win32_start_and_stop): Adding aliases.json mock-up file.
3585
3586 2016-07-18  Aakash Jain  <aakash_jain@apple.com>
3587
3588         EWS console logs doesn't go to log file
3589         https://bugs.webkit.org/show_bug.cgi?id=159539
3590         <rdar://problem/24464570>
3591
3592         Reviewed by David Kilzer.
3593
3594         * Scripts/webkitpy/common/system/logutils.py:
3595         (configure_logger_to_log_to_file): Added method to configure the logger to log to file.
3596         (FileSystemHandler): Added class which uses logging.FileHandler as base class and supports writing
3597         to filesystem. It also supports passing MockFilesystem.
3598         (FileSystemHandler.__init__): Initialize the class and calls base class __init__.
3599         (FileSystemHandler._open): Overrides the base class _open method to use filesystem object.
3600         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3601         (AbstractEarlyWarningSystemTest.test_failing_tests_message): Added MockHost() parameter.
3602         (_test_ews): Same.
3603         * Scripts/webkitpy/tool/commands/queues.py:
3604         (AbstractQueue.begin_work_queue): Configure the logger to log to file.
3605         (AbstractQueue._log_directory): Using filesystem object instead of os.
3606         (AbstractQueue.queue_log_path): Same.
3607         (AbstractQueue.__init__): Passed host parameter.
3608         (PatchProcessingQueue.__init__): Same.
3609         (CommitQueue.__init__): Same.
3610         (AbstractReviewQueue.__init__): Same.
3611         (StyleQueue.__init__): Same.
3612         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3613         (TestCommitQueue): Passed MockHost() as host.
3614         (TestCommitQueue.__init__): Same.
3615         (TestQueue.__init__): Same.
3616         (TestReviewQueue.__init__): Same.
3617