Tools/ChangeLog

   1 2012-03-22  Martin Robinson  <mrobinson@igalia.com>
   2
   3         [check-webkit-style] Alphabetical sorting errors in headers are reported for the line after the first out of order header
   4         https://bugs.webkit.org/show_bug.cgi?id=81986
   5
   6         Reviewed by David Levin.
   7
   8         Track whether or not errors are filtered in error handlers. If an
   9         alphabetical sorting error is reported for a header and filtered, try
  10         reporting it for the other potential source of the error. This ensures
  11         that the style bot can still find new sorting errors in both potential
  12         situations:
  13
  14             #include <foo.h> <-- 1. edited line
  15             #include <baz.h> <-- 2. edited line
  16
  17         * Scripts/webkitpy/style/checkers/cpp.py:
  18         (check_include_line): Potentially report the error for both lines,
  19         if the first error is filtered.
  20         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Implement a new style of
  21         test that allows only reporting errors for certain lines. This verifies that
  22         when one line of an ordering error is filtered, the error is reported on the
  23         other line.
  24         (ErrorCollector.__init__):
  25         (ErrorCollector.__call__):
  26         (CppStyleTestBase.perform_lint):
  27         (CppStyleTestBase.perform_language_rules_check):
  28         (CppStyleTestBase.assert_language_rules_check):
  29         (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines):
  30         Added a new test that verifies that when one line of the two lines of an ordering
  31         error occur, the error is reported on the other line.
  32         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
  33         (MockErrorHandler.__call__): Report True because the error is handled.
  34         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
  35         (ErrorCollector.__call__): Ditto.
  36         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
  37         (MockErrorHandler.__call__): Ditto.
  38         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
  39         (TestErrorHandler.__call__): Ditto.
  40         * Scripts/webkitpy/style/checkers/xml_unittest.py:
  41         (MockErrorHandler.__call__): Ditto.
  42         * Scripts/webkitpy/style/error_handlers.py:
  43         (DefaultStyleErrorHandler.__call__): Report True if the error is handled
  44         and False if it is filtered.
  45
  46 2012-03-23  Patrick Gansterer  <paroga@webkit.org>
  47
  48         Build fix for WinCE after r111778.
  49
  50         * WinCELauncher/CMakeLists.txt:
  51
  52 2012-03-23  Peter Beverloo  <peter@chromium.org>
  53
  54         Unreviewed buildfix for the Chromium Android builder.
  55
  56         Disable the ImageDiff target for now. Android needs to build this for
  57         host rather than for target (as other configurations do), but since the
  58         WTF move the dependency chain got significantly more complicated.
  59
  60         I'll work out a proper fix in the following bug, but since several
  61         things are broken due to this, this buildfix should be landed first.
  62         https://bugs.webkit.org/show_bug.cgi?id=82039
  63
  64         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  65
  66 2012-03-23  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
  67
  68         [EFL][DRT] Implement LayoutTestController's methods related with editing.
  69         https://bugs.webkit.org/show_bug.cgi?id=80136
  70
  71         Reviewed by Ryosuke Niwa.
  72
  73         Implements EFL's LayoutTestController methods e.i. setSmartInsertDeleteEnabled,
  74         setSelectTrailingWhitespaceEnabled.
  75
  76         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  77         (LayoutTestController::setSmartInsertDeleteEnabled):
  78         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
  79
  80 2012-03-22  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
  81
  82         Convert hasGrammarMarker to use Internals interface
  83         https://bugs.webkit.org/show_bug.cgi?id=82004
  84
  85         Reviewed by Ryosuke Niwa.
  86
  87         Remove hasGrammarMarker functions, because it is able to work in the
  88         cross-port way through the Internals interface.
  89
  90         * DumpRenderTree/LayoutTestController.cpp:
  91         (LayoutTestController::staticFunctions):
  92         * DumpRenderTree/LayoutTestController.h:
  93         (LayoutTestController):
  94         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  95         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  96         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  97         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  98         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  99         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
 100
 101 2012-03-22  Adam Barth  <abarth@webkit.org>
 102
 103         sync-master-with-upstream creates non-linear git history
 104         https://bugs.webkit.org/show_bug.cgi?id=82006
 105
 106         Reviewed by Julien Chaffraix.
 107
 108         Previously this script would create a merge commit at the HEAD of
 109         origin/master, causing your fork of WebKit to diverge from upstream.
 110         The new version of this script pushes directly from upstream to origin
 111         (without round-tripping through any local branches), avoiding this
 112         problem.
 113
 114         * Scripts/sync-master-with-upstream:
 115
 116 2012-03-22  Gustavo Noronha Silva  <gns@gnome.org>
 117
 118         Unreviewed build fix. Add knowledge of the WTF project to
 119         the autotools build system scripts so that build-jsc works
 120         correctly for GTK+.
 121
 122         * Scripts/webkitdirs.pm:
 123         (buildAutotoolsProject): handle the WTF project, build the
 124         libWTF.la target.
 125         (buildGtkProject): add WTF to the list of supported projects.
 126
 127 2012-03-22  Eric Seidel  <eric@webkit.org>
 128
 129         Make svn-apply re-write JavaScriptCore/wtf to WTF/wtf
 130         https://bugs.webkit.org/show_bug.cgi?id=81984
 131
 132         Reviewed by Adam Barth.
 133
 134         * Scripts/VCSUtils.pm:
 135         (adjustPathForRecentRenamings):
 136
 137 2012-03-22  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
 138
 139         [CMake] Fix build-jsc after r111778 and r111797.
 140         https://bugs.webkit.org/show_bug.cgi?id=82001
 141
 142         Reviewed by Filip Pizlo.
 143
 144         Contrary to the comment in build-jsc, buildCMakeProjectOrExit()
 145         does return if no error occurred, and build-jsc failed with
 146         "building not defined for this platform".
 147
 148         * Scripts/build-jsc: Always exit after caling
 149         buildCMakeProjectOrExit().
 150         * Scripts/webkitdirs.pm:
 151         (buildCMakeProjectOrExit): Return 0 if no error occurred.
 152
 153 2012-03-22  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
 154
 155         [CMake] Unreviewed build fix after r111778.
 156
 157         * DumpRenderTree/efl/CMakeLists.txt: Replace
 158         ${JAVASCRIPTCORE_DIR}/wtf with ${WTF_DIR}/wtf in the include
 159         paths.
 160         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Use the right
 161         wtf include.
 162         * DumpRenderTree/efl/WorkQueueItemEfl.cpp: Ditto.
 163         * WinCELauncher/CMakeLists.txt: Replace ${JAVASCRIPTCORE_DIR}/wtf
 164         with ${WTF_DIR}/wtf in the include paths.
 165
 166 2012-03-22  Filip Pizlo  <fpizlo@apple.com>
 167
 168         Tools/Scripts/build-jsc doesn't work after WTF move
 169         https://bugs.webkit.org/show_bug.cgi?id=81999
 170
 171         Reviewed by Eric Seidel.
 172
 173         For ports that require WTF and JSC to be built as two projects and where
 174         the machinery to build both does not already exist, teach the tool to do
 175         so for us.
 176
 177         * Scripts/build-jsc:
 178         (buildMyProject):
 179
 180 2012-03-22  Ojan Vafai  <ojan@chromium.org>
 181
 182         Fix accidental missing line in r111793.
 183
 184         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
 185         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
 186         Remove base.values. It was unused and duplicates the builtin Object.values.
 187         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
 188         Accidentally deleted this line before committing r111793.
 189
 190 2012-03-22  Ojan Vafai  <ojan@chromium.org>
 191
 192         Move garden-o-matic progress feedback from non-modal dialogs to a status console anchored to the bottom of the page
 193         https://bugs.webkit.org/show_bug.cgi?id=81983
 194
 195         Reviewed by Adam Barth.
 196
 197         The dialogs get in the way if you are doing multiple rebaselines. Also,
 198         a number of people didn't realize that you could do multiple rebaselines
 199         in parallel. A non-modal dialog is just confusing.
 200
 201         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
 202         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
 203         If we're only rebaselining 1 test, show the test name in the initial message. Otherwise,
 204         show the number of tests being rebaselined.
 205
 206         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
 207         Turn MessageBox into StatusArea. StatusArea is a singleton and messages in the StatusArea are grouped
 208         by ID. That way, the results of each UI action (e.g. clicking rebaseline) are grouped together
 209         into a single area.
 210
 211         Once addFinalMessage has been called for all IDs, we show the close button. Clicking close
 212         also serves to clear all teh content in the StatusArea.
 213
 214         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
 215         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
 216
 217 2012-03-22  Tony Chang  <tony@chromium.org>
 218
 219         Unreviewed, fix chromium build after wtf move.
 220
 221         Only use newwtf, remove references to wtf.
 222
 223         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
 224
 225 2012-03-22  Csaba Osztrogonác  <ossy@webkit.org>
 226
 227         Actually move WTF files to their new home
 228         https://bugs.webkit.org/show_bug.cgi?id=81844
 229
 230         [Qt] Unreviewed buildfix after r111778.
 231
 232         * DumpRenderTree/qt/DumpRenderTree.pro:
 233
 234 2012-03-22  Dan Bernstein  <mitz@apple.com>
 235
 236         Font fallback in WebKitTestRunner depends on user settings
 237         https://bugs.webkit.org/show_bug.cgi?id=81978
 238
 239         Reviewed by Jessie Berlin.
 240
 241         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
 242         (WTR::InjectedBundle::platformInitialize): Added an AppleLanguages key
 243         with a value consisting of the array ("en") to the override defaults
 244         dictionary. This is the same value used in DumpRenderTree, and it
 245         ensures that font fallback follows a consistent path that is not
 246         affected by the language preferences of the user running the test.
 247
 248 2012-03-22  Andy Estes  <aestes@apple.com>
 249
 250         check-for-inappropriate-objc-class-names should ignore the class defined by libarclite.
 251         https://bugs.webkit.org/show_bug.cgi?id=81971
 252
 253         Reviewed by Dan Bernstein.
 254
 255         Xcode will automatically link ObjC binaries against libarclite in some
 256         cases, which defines a class called __ARCLite__.
 257         check-for-inappropriate-objc-class-names shouldn't complain about this
 258         class name.
 259
 260         * Scripts/check-for-inappropriate-objc-class-names:
 261
 262 2012-03-22  Dirk Pranke  <dpranke@chromium.org>
 263
 264         new-run-webkit-tests blames the wrong test for crashing
 265         https://bugs.webkit.org/show_bug.cgi?id=81951
 266
 267         Reviewed by Adam Barth.
 268
 269         NRWT wasn't extracting the WebProcess pid correct; should've
 270         used re.search instead of re.match :(. Add more tests!
 271
 272         * Scripts/webkitpy/layout_tests/port/mac.py:
 273         (MacPort._get_crash_log):
 274         * Scripts/webkitpy/layout_tests/port/webkit.py:
 275         (WebKitDriver.has_crashed):
 276         (WebKitDriver._check_for_driver_crash):
 277         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
 278         (WebKitDriverTest.test_no_timeout):
 279         (WebKitDriverTest):
 280         (WebKitDriverTest.test_check_for_driver_crash):
 281         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess):
 282         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.__init__):
 283         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.pid):
 284         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.name):
 285         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.has_crashed):
 286         (WebKitDriverTest.test_check_for_driver_crash.assert_crash):
 287
 288 2012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
 289
 290         [EFL] [DRT] Implement LayoutTestController::markerTextForListItem()
 291         https://bugs.webkit.org/show_bug.cgi?id=81512
 292
 293         Adding missing implementation markerTextForListItem to EFL's
 294         LayoutTestController so that we can unskip related tests from
 295         the skip list.
 296
 297         Reviewed by Antonio Gomes.
 298
 299         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
 300         (LayoutTestController::markerTextForListItem): Implemented.
 301
 302 2012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
 303
 304         [EFL] Enable view mode media feature layout tests
 305         https://bugs.webkit.org/show_bug.cgi?id=81205
 306
 307         Adding missing implementation setViewModeMediaFeature to EFL's
 308         LayoutTestController so that we can unskip view mode
 309         media feature layout tests.
 310
 311         Reviewed by Antonio Gomes.
 312
 313         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
 314         (LayoutTestController::setViewModeMediaFeature): Implemented.
 315
 316 2012-03-22  Dirk Pranke  <dpranke@chromium.org>
 317
 318         nrwt: crash while stopping layout test helper on apple mac lion
 319         https://bugs.webkit.org/show_bug.cgi?id=81949
 320
 321         Reviewed by Eric Seidel.
 322
 323         stop_helper() didn't work right if the helper process wasn't
 324         still running or didn't respond properly to being shut down. Fix
 325         this and add some tests. Also add code to MockExecutive() to be
 326         able to mock executive.popen() properly.
 327
 328         * Scripts/webkitpy/common/system/executive_mock.py:
 329         (MockProcess.__init__):
 330         (MockProcess.wait):
 331         (MockExecutive.__init__):
 332         (MockExecutive.popen):
 333         * Scripts/webkitpy/common/system/systemhost_mock.py:
 334         (MockSystemHost.__init__):
 335         * Scripts/webkitpy/layout_tests/port/mac.py:
 336         (MacPort.start_helper):
 337         (MacPort.stop_helper):
 338         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
 339         (test_get_crash_log):
 340         (test_helper_starts):
 341         (test_helper_fails_to_start):
 342         (test_helper_fails_to_stop):
 343         (test_helper_fails_to_stop.bad_waiter):
 344
 345 2012-03-22  Gustavo Noronha Silva  <gns@gnome.org>
 346
 347         [GTK] Add make to the jhbuild moduleset
 348         https://bugs.webkit.org/show_bug.cgi?id=81769
 349
 350         Reviewed by Martin Robinson.
 351
 352         Mostly based on a patch by Carlos Garcia Campos <cgarcia@igalia.com>.
 353         Add GNU make with custom patches to fix several issues:
 354
 355         - make-3.82-arg-list-length.patch: Patch by Ralf Wildenhues to
 356           fix the argument list limit of GNU make when running make
 357           distcheck.
 358         - make-3.82-parallel-build.patch: Patch by Kamil Mierzejewski
 359           and Jeremy Devenport to fix parallel build issues present in
 360           GNU make 3.82
 361
 362         * gtk/jhbuild.modules: Added make with patches.
 363         * gtk/patches/make-3.82-arg-list-length.patch: Added.
 364         * gtk/patches/make-3.82-parallel-build.patch: Added.
 365
 366 2012-03-22  Kevin Ollivier  <kevino@theolliviers.com>
 367
 368         [wx] Unreviewed. Adding Source/WTF to the build and updating
 369         waf port list.
 370
 371         * DumpRenderTree/wscript:
 372         * waf/build/settings.py:
 373
 374 2012-03-22  Dirk Pranke  <dpranke@chromium.org>
 375
 376         Re-land fix for r81603 yet again (!) with latest build fix.
 377         https://bugs.webkit.org/show_bug.cgi?id=81603
 378
 379         Unreviewed, build fix.
 380
 381         The latest problem was a bad sprintf() in
 382         BasePort._get_crash_log(). I've reworked that routine and added
 383         unit tests for coverage.
 384
 385         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
 386         (SingleTestRunner._handle_error):
 387         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
 388         (write_test_result):
 389         (TestResultWriter.write_crash_log):
 390         * Scripts/webkitpy/layout_tests/port/base.py:
 391         (Port.diff_text):
 392         (Port._get_crash_log):
 393         * Scripts/webkitpy/layout_tests/port/chromium.py:
 394         (ChromiumDriver.run_test):
 395         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
 396         (ChromiumDriverTest.test_crash_log):
 397         * Scripts/webkitpy/layout_tests/port/driver.py:
 398         (DriverOutput.__init__):
 399         * Scripts/webkitpy/layout_tests/port/mac.py:
 400         (MacPort.is_lion):
 401         (MacPort._get_crash_log):
 402         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
 403         (test_default_child_processes):
 404         (test_get_crash_log):
 405         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
 406         (MockDRTPortTest.test_get_crash_log):
 407         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
 408         (PortTestCase.test_get_crash_log):
 409         * Scripts/webkitpy/layout_tests/port/test.py:
 410         (TestDriver.run_test):
 411         * Scripts/webkitpy/layout_tests/port/webkit.py:
 412         (WebKitDriver.__init__):
 413         (WebKitDriver._start):
 414         (WebKitDriver.has_crashed):
 415         (WebKitDriver._check_for_driver_crash):
 416         (WebKitDriver.run_test):
 417
 418 2012-03-22  Alexander Færøy  <alexander.faeroy@nokia.com>
 419
 420         [Qt] Enable support for handling database quota's in the MiniBrowser
 421         https://bugs.webkit.org/show_bug.cgi?id=81928
 422
 423         Reviewed by Simon Hausmann.
 424
 425         * MiniBrowser/qt/qml/BrowserWindow.qml:
 426
 427 2012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
 428
 429         [EFL] Implement LayoutTestController::setEditingBehavior
 430         https://bugs.webkit.org/show_bug.cgi?id=81124
 431
 432         Adding missing implementation setEditingBehavior to EFL's
 433         LayoutTestController. This implementation allows us to
 434         unskip some tests from the skip list.
 435
 436         Reviewed by Martin Robinson.
 437
 438         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
 439         (LayoutTestController::setEditingBehavior): Implemented.
 440
 441 2012-03-22  Carlos Garcia Campos  <cgarcia@bb-webkit-rel-64.local.igalia.com>
 442
 443         [GTK] Use the angle-bracket form to include wtf headers
 444         https://bugs.webkit.org/show_bug.cgi?id=81884
 445
 446         Reviewed by Eric Seidel.
 447
 448         Use #include <wtf/foo> instead of #include "foo".
 449
 450         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
 451         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
 452         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 453         * DumpRenderTree/gtk/EditingCallbacks.cpp:
 454         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
 455         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
 456
 457 2012-03-22  Alexander Færøy  <alexander.faeroy@nokia.com>
 458
 459         Unreviewed, add Michael Brüning and Allan Jensen to committers.py.
 460
 461         * Scripts/webkitpy/common/config/committers.py:
 462
 463 2012-03-22  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
 464
 465         [Qt] Enable FAST_MOBILE_SCROLLING when scrolling is delegated.
 466         https://bugs.webkit.org/show_bug.cgi?id=81889
 467
 468         Reviewed by Kenneth Rohde Christiansen.
 469
 470         Enable FAST_MOBILE_SCROLLING feature.
 471
 472         * qmake/mkspecs/features/features.prf:
 473
 474 2012-03-22  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
 475
 476         [EFL] DRT: Do not pass a relative path to DOWNLOADED_FONTS_DIR.
 477         https://bugs.webkit.org/show_bug.cgi?id=81900
 478
 479         Reviewed by Gustavo Noronha Silva.
 480
 481         r111598 added the DOWNLOADED_FONTS_DIR define, but it used a relative
 482         path which assumed a certain directory structure for the build
 483         directory which may noy be true.
 484
 485         Instead, hardcode the path to the downloaded fonts starting from the
 486         top-level source directory. While this solution is also far from
 487         perfect, it makes it more consistent and reliable, and easier to
 488         tackle at once with the rest of bug 81475.
 489
 490         * DumpRenderTree/efl/CMakeLists.txt:
 491
 492 2012-03-22  Carlos Garcia Campos  <cgarcia@igalia.com>
 493
 494         [GTK] Allow to run any jhbuild command with jhbuild-wrapper script
 495         https://bugs.webkit.org/show_bug.cgi?id=81888
 496
 497         Reviewed by Philippe Normand.
 498
 499         * Scripts/update-webkit-libs-jhbuild:
 500         (runJhbuild): Helper function to run jhbuild with a given command.
 501         Instead of running jhbuild directly, use the jhbuild-wrapper, so
 502         that we don't need to run it first to check whether jhbuild is
 503         installed or not.
 504         * efl/run-with-jhbuild: Call jhbuild-wrapper with run command.
 505         * gtk/run-with-jhbuild: Ditto.
 506         * jhbuild/jhbuild-wrapper: Allow to execute any jhbuild command,
 507         not only run.
 508
 509 2012-03-22  Philippe Normand  <pnormand@igalia.com>
 510
 511         Unreviewed, test-webkitpy fix after r111661.
 512
 513         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
 514         (MainTest.test_crash_log):
 515         (MainTest.test_web_process_crash_log):
 516
 517 2012-03-22  Philippe Normand  <pnormand@igalia.com>
 518
 519         Unreviewed, test-webkitpy fix after r111642.
 520
 521         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
 522         (ChromiumDriverTest.setUp):
 523         (ChromiumDriverTest.test_two_drivers):
 524
 525 2012-03-22  Csaba Osztrogonác  <ossy@webkit.org>
 526
 527         webkitpy: clean up actually getting crash logs from DRT/WTR crashes
 528         https://bugs.webkit.org/show_bug.cgi?id=81603
 529
 530         Unreviewed rolling out r111609 and part of r111615,
 531         because it broke NRWT on Qt-WK2 platform.
 532
 533         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
 534         (SingleTestRunner._handle_error):
 535         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
 536         (write_test_result):
 537         (TestResultWriter.write_crash_report):
 538         * Scripts/webkitpy/layout_tests/port/base.py:
 539         (Port.is_crash_reporter):
 540         (Port._driver_class):
 541         * Scripts/webkitpy/layout_tests/port/chromium.py:
 542         (ChromiumDriver.run_test):
 543         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
 544         (ChromiumDriverTest.test_crashed_process_name):
 545         * Scripts/webkitpy/layout_tests/port/driver.py:
 546         (DriverOutput.__init__):
 547         * Scripts/webkitpy/layout_tests/port/mac.py:
 548         (MacPort):
 549         (MacPort.is_crash_reporter):
 550         (MacPort.release_http_lock):
 551         * Scripts/webkitpy/layout_tests/port/test.py:
 552         (TestDriver.run_test):
 553         * Scripts/webkitpy/layout_tests/port/webkit.py:
 554         (WebKitDriver.__init__):
 555         (WebKitDriver._start):
 556         (WebKitDriver.has_crashed):
 557         (WebKitDriver._check_for_driver_crash):
 558         (WebKitDriver.run_test):
 559
 560 2012-03-22  Csaba Osztrogonác  <ossy@webkit.org>
 561
 562         [Qt] Add full platforms to Qt buildslaves
 563         https://bugs.webkit.org/show_bug.cgi?id=81877
 564
 565         Reviewed by Ryosuke Niwa.
 566
 567         * BuildSlaveSupport/build.webkit.org-config/config.json:
 568
 569 2012-03-21  Johnny Ding  <jnd@chromium.org>
 570
 571         Customize layout test timeout value for different ports.
 572         https://bugs.webkit.org/show_bug.cgi?id=79859
 573
 574         Reviewed by Ojan Vafai.
 575
 576         * Scripts/webkitpy/layout_tests/controllers/manager.py:
 577         (Manager):
 578         * Scripts/webkitpy/layout_tests/port/base.py:
 579         (Port.default_test_timeout_ms):
 580         * Scripts/webkitpy/layout_tests/port/chromium.py:
 581         (ChromiumDriver.stop):
 582         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
 583         (ChromiumAndroidPort.default_test_timeout_ms):
 584         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 585         (_set_up_derived_options):
 586
 587 2012-03-21  Mark Rowe  <mrowe@apple.com>
 588
 589         Fix the build.
 590
 591         Ensure that our test tools don't try and use RTTI unnecessarily.
 592
 593         * DumpRenderTree/mac/Configurations/Base.xcconfig:
 594         * TestWebKitAPI/Configurations/Base.xcconfig:
 595         * WebKitTestRunner/Configurations/Base.xcconfig:
 596
 597 2012-03-21  Adam Barth  <abarth@webkit.org>
 598
 599         WebKit should have some scripts to smooth interactions with GitHub
 600         https://bugs.webkit.org/show_bug.cgi?id=81842
 601
 602         Reviewed by Eric Seidel.
 603
 604         These scripts support the workflow in
 605         https://trac.webkit.org/wiki/UsingGitHub by automating the
 606         configuration and syncing operations needed for a GitHub fork of WebKit
 607         to track the main WebKit repository.
 608
 609         * Scripts/configure-github-as-upstream: Added.
 610         * Scripts/sync-master-with-upstream: Added.
 611
 612 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
 613
 614         WTR - log the pid of a crashing WebProcess
 615         https://bugs.webkit.org/show_bug.cgi?id=81575
 616
 617         Reviewed by Alexey Proskuryakov.
 618
 619         This allows run-webkit-tests to find the right crash log for a
 620         given crashed WebProcess in WebKit2.
 621
 622         * WebKitTestRunner/TestController.cpp:
 623         (WTR::exceededDatabaseQuota):
 624         (WTR::TestController::createOtherPage):
 625         (WTR::TestController::initialize):
 626         (WTR::TestController::resetStateToConsistentValues):
 627         (WTR::TestController::runTest):
 628         (WTR::TestController::processDidCrash):
 629
 630 2012-03-21  Enrica Casucci  <enrica@apple.com>
 631
 632         WebKitURLWithTitles pasteboard format should support URLs containing Emoji characters.
 633         https://bugs.webkit.org/show_bug.cgi?id=81835
 634         <rdar://problem/11082749>
 635
 636         Reviewed by Brady Eidson.
 637
 638         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html:
 639         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
 640         (TestWebKitAPI::contextMenuCopyLink):
 641
 642 2012-03-21  Alexandru Chiculita  <achicu@adobe.com>
 643
 644         [CSS Shaders] Make CSS Shaders compile on Chromium
 645         https://bugs.webkit.org/show_bug.cgi?id=81435
 646
 647         Reviewed by Stephen White.
 648
 649         I've added WebKitCSSCustomFilterEnabled support for the layoutTestController.overridePreference function.
 650
 651         * DumpRenderTree/chromium/LayoutTestController.cpp:
 652         (LayoutTestController::overridePreference):
 653         * DumpRenderTree/chromium/WebPreferences.cpp:
 654         (WebPreferences::reset):
 655         (WebPreferences::applyTo):
 656         * DumpRenderTree/chromium/WebPreferences.h:
 657         (WebPreferences):
 658
 659 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
 660
 661         fix regression on gtk port introduced by r111609
 662         https://bugs.webkit.org/show_bug.cgi?id=81839
 663
 664         Reviewed by Philippe Normand.
 665
 666         r111609 should've initialized a couple of missing fields in
 667         WebKitDriver, and also should've checked for method overrides
 668         in the other ports :(.
 669
 670         * Scripts/webkitpy/layout_tests/port/gtk.py:
 671         (GtkDriver._start):
 672         * Scripts/webkitpy/layout_tests/port/webkit.py:
 673         (WebKitDriver.__init__):
 674         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
 675         (MainTest.test_crash_log):
 676         (MainTest.test_web_process_crash_log):
 677
 678 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
 679
 680         webkitpy: clean up actually getting crash logs from DRT/WTR crashes
 681         https://bugs.webkit.org/show_bug.cgi?id=81603
 682
 683         Reviewed by Adam Barth.
 684
 685         Add a new _get_crash_log() overridable method on the Port
 686         object to customize how we fetch crash logs per port.
 687         Mac will now slow-spin with a timeout waiting for the crash log, rather
 688         than waiting for the ReportCrash process to exit (it appears
 689         that the mac will manage multiple crashes with a single
 690         ReportCrash process, the process waits around longer than
 691         necessary, presumably to avoid thrashing if processes are
 692         repeatedly crashing).
 693
 694         Also, add the DriverOutput should contain the crash log and other info,
 695         which is created in a port-specific manner but can then be
 696         treated generically. Previously single_test_runner would get
 697         told that something crashed and attempt to do something to get
 698         the crash log, but it didn't have the information it needed to
 699         od the right thing; better to make the driver hand back the
 700         right info.
 701
 702         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
 703         (SingleTestRunner._handle_error):
 704         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
 705         (write_test_result):
 706         (TestResultWriter.write_crash_log):
 707         * Scripts/webkitpy/layout_tests/port/base.py:
 708         (Port.diff_text):
 709         (Port._get_crash_log):
 710         * Scripts/webkitpy/layout_tests/port/chromium.py:
 711         (ChromiumDriver.run_test):
 712         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
 713         (ChromiumDriverTest.test_crash_log):
 714         * Scripts/webkitpy/layout_tests/port/driver.py:
 715         (DriverOutput.__init__):
 716         * Scripts/webkitpy/layout_tests/port/mac.py:
 717         (MacPort.is_lion):
 718         (MacPort._get_crash_log):
 719         * Scripts/webkitpy/layout_tests/port/test.py:
 720         (TestDriver.run_test):
 721         * Scripts/webkitpy/layout_tests/port/webkit.py:
 722         (WebKitDriver.__init__):
 723         (WebKitDriver._start):
 724         (WebKitDriver.has_crashed):
 725         (WebKitDriver._check_for_driver_crash):
 726         (WebKitDriver.run_test):
 727
 728 2012-03-21  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
 729
 730         [EFL] Use jhbuild downloaded fonts instead of hardcoded system font paths
 731         https://bugs.webkit.org/show_bug.cgi?id=81507
 732
 733         Now that we're only loading from one directory, no need to
 734         iterate over a list of directories anymore.
 735
 736         Reviewed by Martin Robinson.
 737
 738         * DumpRenderTree/efl/CMakeLists.txt:
 739         * DumpRenderTree/efl/FontManagement.cpp:
 740         (addFontDirectory):
 741         (addFontsToEnvironment):
 742
 743 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
 744
 745         webkitpy: get ServerProcess out of the reportcrash business
 746         https://bugs.webkit.org/show_bug.cgi?id=81600
 747
 748         Unreviewed, build fix.
 749
 750         Re-land r111307 and r111293 with another fix for a crash in NRWT;
 751         we need to check if the driver has crashed before attempting to
 752         read from it.
 753
 754
 755         * Scripts/webkitpy/layout_tests/port/server_process.py:
 756         (ServerProcess._reset):
 757         (ServerProcess._handle_possible_interrupt):
 758         (ServerProcess.write):
 759         (ServerProcess.read_stdout):
 760         (ServerProcess.has_crashed):
 761         (ServerProcess._read):
 762         (ServerProcess.stop):
 763         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
 764         (TrivialMockPort.check_for_leaks):
 765         (TestServerProcess.test_broken_pipe):
 766         * Scripts/webkitpy/layout_tests/port/webkit.py:
 767         (WebKitPort._read_image_diff):
 768         (WebKitDriver.has_crashed):
 769         (WebKitDriver._check_for_driver_crash):
 770         (WebKitDriver.run_test):
 771         (WebKitDriver._read_block):
 772         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
 773         (MockServerProcess.__init__):
 774         (MockServerProcess):
 775         (MockServerProcess.has_crashed):
 776
 777 2012-03-21  Zeno Albisser  <zeno@webkit.org>
 778
 779         [Qt][Mac] ranlib segfaults when creating symbol tables for libWebCore.a.
 780         https://bugs.webkit.org/show_bug.cgi?id=81750
 781
 782         Building WebCore on mac currently creates an archive that is bigger than
 783         4GB. But ranlib fails to create a symbol table for such a big archive,
 784         even on 64bit machines.
 785         Therefore we start using SVGAllInOne.cpp when building debug
 786         on mac. This reduces the size of the archive by about 300MB.
 787
 788         Reviewed by Tor Arne Vestbø.
 789
 790         * qmake/mkspecs/features/mac/default_pre.prf:
 791
 792 2012-03-21  Szilard Ledan  <szledan@inf.u-szeged.hu>
 793
 794         Updated the address list of committers.py.
 795
 796         Reviewed by Csaba Osztrogonác.
 797
 798         * Scripts/webkitpy/common/config/committers.py:
 799
 800 2012-03-21  W. James MacLean  <wjmaclean@chromium.org>
 801
 802         Updating my nick in committers file.
 803
 804         Unreviewed.
 805
 806         * Scripts/webkitpy/common/config/committers.py:
 807
 808 2012-03-21  Peter Beverloo  <peter@chromium.org>
 809
 810         [Chromium] Remove Android build-fix when the proper fix rolled into WebKit
 811         https://bugs.webkit.org/show_bug.cgi?id=80861
 812
 813         Reviewed by Tony Chang.
 814
 815         Remove most Android-specific logic from webkitdirs.pm in favor of
 816         handling this during project generation time.
 817
 818         * Scripts/webkitdirs.pm:
 819         (buildChromiumMakefile):
 820
 821 2012-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
 822
 823         [GTK] Allow running javascript from location bar in MiniBrowser
 824         https://bugs.webkit.org/show_bug.cgi?id=81331
 825
 826         Reviewed by Martin Robinson.
 827
 828         * MiniBrowser/gtk/BrowserWindow.c:
 829         (activateUriEntryCallback): Use browser_window_load_uri().
 830         (browser_window_load_uri): Check whether uri starts with
 831         javascript: and run the given script, or just call
 832         webkit_web_view_load_uri() to load the given uri.
 833         * MiniBrowser/gtk/BrowserWindow.h:
 834         * MiniBrowser/gtk/main.c:
 835         (createBrowserWindow): Use browser_window_load_uri().
 836
 837 2012-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
 838
 839         [GTK] Add webkit_web_view_run_javascript() to WebKit2 GTK+
 840         https://bugs.webkit.org/show_bug.cgi?id=75543
 841
 842         Reviewed by Martin Robinson.
 843
 844         * MiniBrowser/gtk/GNUmakefile.am: Add javascriptcore_cppflags to
 845         MiniBrowser CPP flags.
 846
 847 2012-03-20  Eric Seidel  <eric@webkit.org>
 848
 849         Move wtf/Platform.h from JavaScriptCore to Source/WTF/wtf
 850         https://bugs.webkit.org/show_bug.cgi?id=80911
 851
 852         Reviewed by Adam Barth.
 853
 854         Update include paths for Source/WTF.
 855
 856         * DumpRenderTree/efl/CMakeLists.txt:
 857         * DumpRenderTree/qt/DumpRenderTree.pro:
 858         * QtTestBrowser/QtTestBrowser.pro:
 859         * Scripts/build-webkit: Build Source/WTF on AppleWin as well.
 860
 861 2012-03-20  Adam Barth  <abarth@webkit.org>
 862
 863         svn-apply should move inflight patches from WebCore/webaudio to WebCore/Modules/webaudio
 864         https://bugs.webkit.org/show_bug.cgi?id=81567
 865
 866         Reviewed by Eric Seidel.
 867
 868         This temporary measure should help us avoid disrupting the folks
 869         working on WebAudio when we move the webaudio directory to Modules.
 870
 871         * Scripts/VCSUtils.pm:
 872         (adjustPathForRecentRenamings):
 873         (parseGitDiffHeader):
 874         (parseSvnDiffHeader):
 875
 876 2012-03-20  Dirk Pranke  <dpranke@chromium.org>
 877
 878         Unreviewed, rolling out r111453.
 879         http://trac.webkit.org/changeset/111453
 880         https://bugs.webkit.org/show_bug.cgi?id=81600
 881
 882         still broken
 883
 884         * Scripts/webkitpy/layout_tests/port/server_process.py:
 885         (ServerProcess._reset):
 886         (ServerProcess.handle_interrupt):
 887         (ServerProcess.write):
 888         (ServerProcess._check_for_crash):
 889         (ServerProcess._handle_timeout):
 890         (ServerProcess._check_for_abort):
 891         (ServerProcess._read):
 892         (ServerProcess.stop):
 893         (ServerProcess):
 894         (ServerProcess.set_crashed):
 895         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
 896         (TrivialMockPort.is_crash_reporter):
 897         (TestServerProcess.test_broken_pipe):
 898         * Scripts/webkitpy/layout_tests/port/webkit.py:
 899         (WebKitPort._read_image_diff):
 900         (WebKitDriver.has_crashed):
 901         (WebKitDriver._check_for_driver_crash):
 902         (WebKitDriver):
 903         (WebKitDriver._detected_crash):
 904         (WebKitDriver._subprocess_crashed):
 905         (WebKitDriver._crashed_process_name):
 906         (WebKitDriver.run_test):
 907         (WebKitDriver._read_block):
 908         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
 909         (MockServerProcess.__init__):
 910
 911 2012-03-20  Dirk Pranke  <dpranke@chromium.org>
 912
 913         webkitpy: get ServerProcess out of the reportcrash business
 914         https://bugs.webkit.org/show_bug.cgi?id=81600
 915
 916         Unreviewed, build fix.
 917
 918         Re-land r111307 and r111293 with fix for crash in NRWT; I
 919         was failing to set the crashing process name.
 920
 921         * Scripts/webkitpy/layout_tests/port/server_process.py:
 922         (ServerProcess._reset):
 923         (ServerProcess._handle_possible_interrupt):
 924         (ServerProcess.write):
 925         (ServerProcess.read_stdout):
 926         (ServerProcess.has_crashed):
 927         (ServerProcess._read):
 928         (ServerProcess.stop):
 929         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
 930         (TrivialMockPort.check_for_leaks):
 931         (TestServerProcess.test_broken_pipe):
 932         * Scripts/webkitpy/layout_tests/port/webkit.py:
 933         (WebKitPort._read_image_diff):
 934         (WebKitDriver.has_crashed):
 935         (WebKitDriver._check_for_driver_crash):
 936         (WebKitDriver.run_test):
 937         (WebKitDriver._read_block):
 938         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
 939         (MockServerProcess.__init__):
 940         (MockServerProcess):
 941         (MockServerProcess.has_crashed):
 942
 943 2012-03-20  Tim Horton  <timothy_horton@apple.com>
 944
 945         [mac] Restore color space switching code to run-webkit-tests
 946         https://bugs.webkit.org/show_bug.cgi?id=80571
 947         <rdar://problem/11008529>
 948
 949         Reviewed by Simon Fraser.
 950
 951         http://trac.webkit.org/changeset/111429 broke tools build on Snow Leopard.
 952
 953         Use the old CM* API on Snow Leopard, since CGDisplayCreateUUIDFromDisplayID
 954         didn't exist until Lion.
 955
 956         * DumpRenderTree/mac/LayoutTestHelper.m:
 957         (installLayoutTestColorProfile):
 958         (restoreUserColorProfile):
 959
 960 2012-03-20  Adele Peterson  <adele@apple.com>
 961
 962         Update the last test to use EXPECT_WK_STREQ.
 963
 964         Reviewed by Dan Bernstein.
 965
 966         * TestWebKitAPI/Tests/mac/AttributedString.mm: (TestWebKitAPI::TEST):
 967
 968 2012-03-20  Adele Peterson  <adele@apple.com>
 969
 970         "Attempt to insert nil value " exception when calling attributed string APIs on content with a custom font
 971         https://bugs.webkit.org/show_bug.cgi?id=81630
 972         <rdar://problem/10650660>
 973
 974         Reviewed by Alexey Proskuryakov.
 975
 976         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 977         * TestWebKitAPI/Tests/mac/Ahem.ttf: Added.
 978         * TestWebKitAPI/Tests/mac/AttributedString.mm: Added.
 979         (-[AttributedStringTest webView:didFinishLoadForFrame:]):
 980         (TestWebKitAPI):
 981         (TestWebKitAPI::didFinishLoadForFrame):
 982         (TestWebKitAPI::TEST):
 983         * TestWebKitAPI/Tests/mac/attributedStringCustomFont.html: Added.
 984
 985 2012-03-20  Eric Seidel  <eric@webkit.org>
 986
 987         Add link on queues.webkit.org to kov's fancy queue-depth graph
 988         https://bugs.webkit.org/show_bug.cgi?id=81690
 989
 990         Reviewed by Adam Barth.
 991
 992         * QueueStatusServer/templates/recentstatus.html:
 993
 994 2012-03-20  Tim Horton  <timothy_horton@apple.com>
 995
 996         [mac] Restore color space switching code to run-webkit-tests
 997         https://bugs.webkit.org/show_bug.cgi?id=80571
 998         <rdar://problem/11008529>
 999
1000         Reviewed by Simon Fraser.
1001
1002         Make use of the layout test helper hooks to restore the Mac system-wide
1003         color profile switching code. This makes WkTR and DRT results match, and
1004         causes the main display's color profile to not affect results on Lion.
1005
1006         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1007         * DumpRenderTree/mac/LayoutTestHelper.m: Added.
1008         (installLayoutTestColorProfile):
1009         (restoreUserColorProfile):
1010         (simpleSignalHandler):
1011         (main):
1012         * Scripts/webkitpy/layout_tests/port/mac.py:
1013         (MacPort.release_http_lock):
1014         (MacPort):
1015         (MacPort._path_to_helper):
1016         (MacPort.start_helper):
1017         (MacPort.stop_helper):
1018         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1019         (WTR::PlatformWebView::PlatformWebView):
1020         (WTR::PlatformWebView::windowSnapshotImage):
1021
1022 2012-02-24  Darin Fisher  <darin@chromium.org>
1023
1024         Add more Chromium WebKit API reviewers
1025         https://bugs.webkit.org/show_bug.cgi?id=81576
1026
1027         Reviewed by Adam Barth and David Levin.
1028
1029         Simplify watchlist to lump all WebKit API into one.
1030
1031         * Scripts/webkitpy/common/config/watchlist:
1032
1033 2012-03-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1034
1035         Convert hasSpellingMarker to use Internals interface.
1036         https://bugs.webkit.org/show_bug.cgi?id=81300
1037
1038         Reviewed by Ryosuke Niwa.
1039
1040         Remove hasSpellingMarker functions, because it is able to work in the
1041         cross-port way through the Internals interface.
1042
1043         * DumpRenderTree/LayoutTestController.cpp:
1044         (LayoutTestController::staticFunctions):
1045         * DumpRenderTree/LayoutTestController.h:
1046         (LayoutTestController):
1047         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1048         * DumpRenderTree/chromium/LayoutTestController.cpp:
1049         (LayoutTestController::LayoutTestController):
1050         * DumpRenderTree/chromium/LayoutTestController.h:
1051         (LayoutTestController):
1052         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1053         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1054         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1055         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1056         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1057         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1058         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1059
1060 2012-03-20  Csaba Osztrogonác  <ossy@webkit.org>
1061
1062         Add new Qt-WK2 performance tester bot to build.webkit.org
1063         https://bugs.webkit.org/show_bug.cgi?id=80842
1064
1065         Reviewed by Ryosuke Niwa.
1066
1067         * BuildSlaveSupport/build.webkit.org-config/config.json:
1068         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1069         (RunAndUploadPerfTestsWebKit2):
1070         (RunAndUploadPerfTestsWebKit2.start):
1071         (BuildAndPerfTestWebKit2Factory):
1072         (BuildAndPerfTestWebKit2Factory.__init__):
1073         (DownloadAndPerfTestWebKit2Factory):
1074         (DownloadAndPerfTestWebKit2Factory.__init__):
1075
1076 2012-03-20  Peter Beverloo  <peter@chromium.org>
1077
1078         [Chromium] Update to Android NDK r7b
1079         https://bugs.webkit.org/show_bug.cgi?id=81005
1080
1081         Reviewed by Adam Barth.
1082
1083         Update to version r7b of the Android NDK, release notes of which are
1084         available on the following page:
1085         http://developer.android.com/sdk/ndk/index.html
1086
1087         * Scripts/update-webkit-chromium:
1088
1089 2012-03-20  Csaba Osztrogonác  <ossy@webkit.org>
1090
1091         x86 GCC bug triggers a compilation error in generated copy constructor of CollapsedBorderValue
1092         https://bugs.webkit.org/show_bug.cgi?id=81502
1093
1094         Unreviewed.
1095
1096         * qmake/mkspecs/features/unix/default_post.prf: Reenable Werror after r111171.
1097
1098 2012-03-19  Jessie Berlin  <jberlin@apple.com>
1099
1100         Unreviewed; roll out http://trac.webkit.org/changeset/111307 and http://trac.webkit.org/changeset/111293
1101         because they broke running the layout tests on mac.
1102
1103         * Scripts/webkitpy/layout_tests/port/webkit.py:
1104         (WebKitDriver._check_for_driver_crash):
1105
1106 2012-03-16  Martin Robinson  <mrobinson@igalia.com>
1107
1108         [GTK] Allow running run-gtk-tests during 'make distcheck'
1109         https://bugs.webkit.org/show_bug.cgi?id=81415
1110
1111         Reviewed by Philippe Normand.
1112
1113         Modify the build and run-gtk-tests so that it can run during 'make distcheck'
1114
1115         * GNUmakefile.am: Distribute run-gtk-tests during 'make dist' and make it the
1116         main command run during 'make check.'
1117         * Scripts/run-gtk-tests: Refactored run-gtk-tests so that jhbuild is no longer
1118         a requirement to run it. If jhbuild isn't around it will simply not start the
1119         SPI daemons and skip the WebKit2 accessibility test. Remove test runs from the
1120         main loop and simply use the main loop in a synchronous method to start SPI
1121         daemons. Did a bunch of general cleanup around these tasks.
1122
1123 2012-03-19  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1124
1125         jhbuild: Use the multiprocessing module to get the number of CPUs.
1126         https://bugs.webkit.org/show_bug.cgi?id=81585
1127
1128         Reviewed by Martin Robinson.
1129
1130         Now that support for Python 2.5 has been dropped, we can safely
1131         use multiprocessing.cpu_count() to obtain the current number of
1132         CPUs in the system instead of running a webkitperl script for
1133         that.
1134
1135         * efl/common.py:
1136         (top_level_path):
1137         * efl/jhbuildrc:
1138         * gtk/common.py:
1139         (build_path):
1140         * gtk/jhbuildrc:
1141
1142 2012-03-19  Ojan Vafai  <ojan@chromium.org>
1143
1144         We should only add a live event listener once, not once per TestSelector.
1145         Adding one per TestSelector would cause accordion('option', 'active') to
1146         incorrectly be "false" if you examine multiple sets of tests.
1147
1148         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1149
1150 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
1151
1152         Fix typo introduced in r111293.
1153
1154         Unreviewed, build fix.
1155
1156         * Scripts/webkitpy/layout_tests/port/webkit.py:
1157         (WebKitDriver._check_for_driver_crash):
1158
1159 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
1160
1161         webkitpy: get ServerProcess out of the reportcrash business
1162         https://bugs.webkit.org/show_bug.cgi?id=81600
1163
1164         Reviewed by Adam Barth.
1165
1166         ServerProcess was half-aware that ReportCrash might run
1167         sometimes, and that the process ServerProcess was talking to
1168         might have its own crashing subprocesses; neither of these
1169         things really worked right and it made the logic convoluted, so
1170         this change makes handling crashes completely separate from the
1171         server_process code, so that it can focus on just I/O to the
1172         subprocess.
1173
1174         There should be no functional changes resulting from this patch.
1175
1176         * Scripts/webkitpy/layout_tests/port/server_process.py:
1177         (ServerProcess._reset):
1178         (ServerProcess._handle_possible_interrupt):
1179         (ServerProcess.write):
1180         (ServerProcess.read_stdout):
1181         (ServerProcess.has_crashed):
1182         (ServerProcess._read):
1183         (ServerProcess.stop):
1184         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
1185         (TrivialMockPort.check_for_leaks):
1186         (TestServerProcess.test_broken_pipe):
1187         * Scripts/webkitpy/layout_tests/port/webkit.py:
1188         (WebKitPort._read_image_diff):
1189         (WebKitDriver.has_crashed):
1190         (WebKitDriver._check_for_driver_crash):
1191         (WebKitDriver.run_test):
1192         (WebKitDriver._read_block):
1193         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1194         (MockServerProcess.__init__):
1195         (MockServerProcess):
1196         (MockServerProcess.has_crashed):
1197
1198 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
1199
1200         webkitpy: crashlog parsing is broken
1201         https://bugs.webkit.org/show_bug.cgi?id=81586
1202
1203         Reviewed by Adam Barth.
1204
1205         Seeking on a file opened through codecs() appears to not work
1206         correctly (at least on SL).
1207
1208         The code was more complicated than it needed to be, so I have
1209         revamped it to just read a full crashlog at once and then look
1210         for matches.
1211
1212         I have also added the ability to optionally propagate
1213         errors back (which can be helpful to debug races when ReportCrash is
1214         still running and you need to see that you couldn't open some
1215         files, rather than just ignoring them).
1216
1217         * Scripts/webkitpy/common/system/crashlogs.py:
1218         (CrashLogs.find_newest_log):
1219         (CrashLogs._find_newest_log_darwin):
1220         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
1221         (CrashLogsTest.test_find_log_darwin):
1222
1223 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
1224
1225         webkitpy: clean up some port._filesystem references to not reference private members
1226         https://bugs.webkit.org/show_bug.cgi?id=81595
1227
1228         Reviewed by Eric Seidel.
1229
1230         There should be no functional changes in this patch, just some
1231         refactoring. Also, fixes a minor nit in write_image_diff_files(()
1232
1233         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1234         (SingleTestRunner.__init__):
1235         (SingleTestRunner._run_compare_test):
1236         (SingleTestRunner._run_rebaseline):
1237         (SingleTestRunner._save_baseline_data):
1238         (SingleTestRunner._handle_error):
1239         (SingleTestRunner._run_reftest):
1240         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1241         (write_test_result):
1242         (TestResultWriter.__init__):
1243         (TestResultWriter._make_output_directory):
1244         (TestResultWriter.output_filename):
1245         (TestResultWriter._output_testname):
1246         (TestResultWriter.write_output_files):
1247         (TestResultWriter.write_stderr):
1248         (TestResultWriter.write_crash_report):
1249         (TestResultWriter.create_text_diff_and_write_result):
1250         (TestResultWriter.write_image_diff_files):
1251         (copy_file):
1252         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
1253         (TestResultWriterTest.test_reftest_diff_image):
1254
1255 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
1256
1257         webkitpy: fix nit - incorrect reference to DRT in test_expectations.py
1258         https://bugs.webkit.org/show_bug.cgi?id=81598
1259
1260         Reviewed by Eric Seidel.
1261
1262         "DumpRenderTree" shouldn't be hard-coded here, since some other
1263         process may actually be crashing (WebKitTestRunner, WebProcess, etc.)
1264
1265         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1266         (TestExpectations):
1267
1268 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
1269
1270         webkitpy: allow instance data in TestFailure objects
1271         https://bugs.webkit.org/show_bug.cgi?id=81580
1272
1273         Reviewed by Tony Chang.
1274
1275         Current TestFailures are basically enums, but it would be nice,
1276         especially for crashes, if they contained the name and pid of
1277         the process that crashed.
1278
1279         * Scripts/webkitpy/layout_tests/models/test_failures.py:
1280         (TestFailure.message):
1281         (FailureTimeout.message):
1282         (FailureCrash):
1283         (FailureCrash.__init__):
1284         (FailureCrash.message):
1285         (FailureMissingResult.message):
1286         (FailureTextMismatch.message):
1287         (FailureMissingImageHash.message):
1288         (FailureMissingImage.message):
1289         (FailureImageHashMismatch.message):
1290         (FailureImageHashIncorrect.message):
1291         (FailureReftestMismatch.message):
1292         (FailureReftestMismatchDidNotOccur.message):
1293         (FailureReftestNoImagesGenerated.message):
1294         (FailureMissingAudio.message):
1295         (FailureAudioMismatch.message):
1296         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
1297         (TestFailuresTest.test_equals):
1298         (TestFailuresTest):
1299         (TestFailuresTest.test_crashes):
1300
1301 2012-03-19  Brady Eidson  <beidson@apple.com>
1302
1303         <rdar://problem/10917120> and https://bugs.webkit.org/show_bug.cgi?id=81066
1304         Crash in 3rd party WebKit apps under XHR/Cache code
1305
1306         Reviewed by Antti Koivisto.
1307
1308         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1309         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.html: Added.
1310         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm: Added.
1311         (-[MemoryCachePruneTestResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1312         (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1313         (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
1314         (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
1315         (TestWebKitAPI):
1316         (TestWebKitAPI::TEST):
1317
1318 2012-03-19  Brady Eidson  <beidson@apple.com>
1319
1320         <rdar://problem/10848575> and https://bugs.webkit.org/show_bug.cgi?id=81516
1321         REGRESSION (r107435) URLs copied from WebKit apps aren't in the right pasteboard format
1322
1323         Reviewed by Enrica Casucci.
1324
1325         Bring up a context menu on a link, copy the link, then verify the pasteboard contents
1326         are in the correct format.
1327
1328         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1329         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html: Added.
1330         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm: Added.
1331         (-[ContextMenuCanCopyURLDelegate webView:didFinishLoadForFrame:]):
1332         (TestWebKitAPI::contextMenuCopyLink):
1333         (TestWebKitAPI::TEST):
1334
1335 2012-03-19  Ojan Vafai  <ojan@chromium.org>
1336
1337         Make the selected item in the accordion a link to the flakiness dashboard
1338         https://bugs.webkit.org/show_bug.cgi?id=81571
1339
1340         Reviewed by Dimitri Glazkov.
1341
1342         Also, make it so that you can select the text of the link, instead of the current behavior
1343         of acting as if you had clicked on the accordion header.
1344
1345         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1346         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1347
1348 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
1349
1350         NRWT runs some tests that are skipped with -i command line option
1351         https://bugs.webkit.org/show_bug.cgi?id=81535
1352
1353         Reviewed by Ojan Vafai.
1354
1355         This change modifies the interaction of Skipped files and
1356         test_expectations files so that entries in Skipped files (and
1357         the -i command line) override *everything* in the expectations
1358         file.
1359
1360         Specifically, a directory in a Skipped file will cause all of
1361         the tests in the dir to be skipped even if individual tests in
1362         the dir are listed in the test_expectations.txt.
1363
1364         Skipped files also override anything in an overrides files.
1365
1366         This seems to make more intuitive sense, since if you list
1367         something in the Skips file (and even more specify it on the
1368         command line) you probably want it to be universally applied.
1369
1370         Theoretically we could add more precedence levels and have full
1371         paths in an expectations file override dirs in a Skipped file
1372         (but not the command line), but I don't know yet that that level
1373         of complexity is justified.
1374
1375         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1376         (TestExpectations.__init__):
1377         (TestExpectations._add_skipped_tests):
1378         (TestExpectations._add_test):
1379         (TestExpectations._add_expectations):
1380         (TestExpectations._add_expectation_line):
1381         (TestExpectations._already_seen_better_match):
1382         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1383         (test_more_specific_override_resets_skip):
1384         (SkippedTests):
1385         (SkippedTests.get_exp):
1386         (SkippedTests.assert_exp):
1387         (SkippedTests.test_skipped_tests_work):
1388         (SkippedTests.test_duplicate_skipped_test_fails_lint):
1389         (SkippedTests.test_skipped_file_overrides_expectations):
1390         (SkippedTests.test_skipped_dir_overrides_expectations):
1391         (SkippedTests.test_skipped_file_overrides_overrides):
1392         (SkippedTests.test_skipped_dir_overrides_overrides):
1393
1394 2012-03-19  Eric Seidel  <eric@webkit.org>
1395
1396         Fix WTF header include discipline in Chromium WebKit
1397         https://bugs.webkit.org/show_bug.cgi?id=81281
1398
1399         Reviewed by James Robinson.
1400
1401         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1402         * Scripts/update-webkit-chromium: Made it possible to run this from a directory other than the root.
1403
1404 2012-03-19  Andy Chen  <andchen@rim.com>
1405
1406         [BlackBerry] Add new layout test for text match marker
1407         https://bugs.webkit.org/show_bug.cgi?id=81531
1408
1409         Make the LayoutTestControllerBlackBerry::findString to test the
1410         BlackBerry port implementation.
1411
1412         Reviewed by Rob Buis.
1413
1414         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1415         (LayoutTestController::findString):
1416
1417 2012-03-19  Ojan Vafai  <ojan@chromium.org>
1418
1419         Don't show WONTFIX tests in garden-o-matic
1420         https://bugs.webkit.org/show_bug.cgi?id=81554
1421
1422         Reviewed by Dimitri Glazkov.
1423
1424         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1425         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
1426
1427 2012-03-19  Chris Fleizach  <cfleizach@apple.com>
1428
1429         platform/mac/accessibility/selected-rows-table.html failing on Lion Intel Debug WebKit2 testers
1430         https://bugs.webkit.org/show_bug.cgi?id=81530
1431
1432         Reviewed by Jessie Berlin.
1433
1434         Add rowAtIndex to WebKitTestRunner.
1435
1436         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1437         (WTR::AccessibilityUIElement::rowAtIndex):
1438         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1439         (AccessibilityUIElement):
1440         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1441         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1442         (WTR):
1443         (WTR::AccessibilityUIElement::rowAtIndex):
1444
1445 2012-03-19  Ojan Vafai  <ojan@chromium.org>
1446
1447         Change garden-o-matic All Failures tab to Expected Failures
1448         https://bugs.webkit.org/show_bug.cgi?id=81540
1449
1450         Reviewed by Dimitri Glazkov.
1451
1452         Also, fix some broken unittests that had just gotten stale.
1453
1454         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1455         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
1456         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
1457         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
1458         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1459         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
1460         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1461         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
1462         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1463         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1464
1465 2012-03-19  Hao Zheng  <zhenghao@chromium.org>
1466
1467         [chromium] DRT crashes at shutdown.
1468         https://bugs.webkit.org/show_bug.cgi?id=81504
1469
1470         Reviewed by James Robinson.
1471
1472         WebCompositor must be destroyed after WebView is properly destroyed,
1473         or some compositor objects like CCLayerTreeHost may not be destroyed.
1474         However, it is really hard to make the destruction order correct
1475         explicitly in ~TestShell. So move it out to DumpRenderTree.
1476
1477         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1478         (main):
1479         * DumpRenderTree/chromium/TestShell.cpp:
1480         (TestShell::~TestShell):
1481
1482 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
1483
1484         add dpranke to webkitpy watchlist
1485         https://bugs.webkit.org/show_bug.cgi?id=81433
1486
1487         Reviewed by Benjamin Poulain.
1488
1489         * Scripts/webkitpy/common/config/watchlist:
1490
1491 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
1492
1493         test-webkitpy is failing on SL/Python 2.6.1
1494         https://bugs.webkit.org/show_bug.cgi?id=81533
1495
1496         Reviewed by Ojan Vafai.
1497
1498         It appears that itertools.combinations() is buggy in 2.6.1; this
1499         backports the implementation from 2.7.
1500
1501         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
1502         (TestConfigurationConverter.collapse_macros):
1503         (TestConfigurationConverter):
1504         (TestConfigurationConverter.combinations):
1505
1506 2012-03-19  David Michael Barr  <davidbarr@google.com>
1507
1508         Optimize the cleanup sequence in the start-queue.sh script
1509         https://github.com/abarth/webkit/pull/1
1510
1511         Reviewed by Adam Barth.
1512
1513         Updating the working copy is an expensive operation
1514         for a repository the size of WebKit.
1515         Attempt to reset only to the target revision.
1516
1517         * EWSTools/start-queue.sh:
1518
1519 2012-03-19  Raphael Kubo da Costa  <kubo@profusion.mobi>
1520
1521         Adjust architecture type of the EFL build bot.
1522         https://bugs.webkit.org/show_bug.cgi?id=81452
1523
1524         Reviewed by Tony Chang.
1525
1526         * BuildSlaveSupport/build.webkit.org-config/config.json: The
1527         buildslave is a 64-bit machine, therefore describe it as being
1528         x86_64, not i386.
1529
1530 2012-03-19  Alexander Færøy  <alexander.faeroy@nokia.com>
1531
1532         [Qt] printLoadedUrls prints "Object" instead of the actual URL.
1533         https://bugs.webkit.org/show_bug.cgi?id=81514
1534
1535         Reviewed by Simon Hausmann.
1536
1537         * MiniBrowser/qt/qml/BrowserWindow.qml:
1538
1539 2012-03-19  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1540
1541         [EFL] jhbuild: Set CMAKE_PREFIX_PATH in jhbuildrc.
1542         https://bugs.webkit.org/show_bug.cgi?id=81491
1543
1544         Reviewed by Philippe Normand.
1545
1546         For the find_path(), find_library() etc CMake calls to find the
1547         dependencies built with jhbuild, CMAKE_PREFIX_PATH must be properly
1548         set, otherwise CMake cannot know the dependencies exist and will only
1549         look in the standard directories.
1550
1551         * efl/jhbuildrc: Set the CMAKE_PREFIX_PATH environment variable with
1552         the jhbuild Root directory.
1553
1554 2012-03-19  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1555
1556         [EFL] Add XDG env vars to jhbuildrc
1557         https://bugs.webkit.org/show_bug.cgi?id=81510
1558
1559         Needed to ensure correct glib behaviour in jhbuild environment.
1560
1561         Reviewed by Philippe Normand.
1562
1563         * efl/jhbuildrc:
1564
1565 2012-03-19  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
1566
1567         Select best target for tap gesture.
1568         https://bugs.webkit.org/show_bug.cgi?id=78801
1569
1570         Reviewed by Kenneth Rohde Christiansen.
1571
1572         Add TOUCH_ADJUSTMENT to enabled features.
1573
1574         * qmake/mkspecs/features/features.prf:
1575
1576 2012-03-19  Robert Kroeger  <rjkroege@chromium.org>
1577
1578         [chromium] synthesize wheel events for fling on main thread
1579         https://bugs.webkit.org/show_bug.cgi?id=81458
1580
1581         Added the ability to dispatch GestureFlingStart and GestureFlingCancel from EventSender.
1582
1583         Reviewed by James Robinson.
1584
1585         * DumpRenderTree/chromium/EventSender.cpp:
1586         (EventSender::EventSender):
1587         (EventSender::gestureFlingCancel):
1588         (EventSender::gestureFlingStart):
1589         * DumpRenderTree/chromium/EventSender.h:
1590         (EventSender):
1591
1592 2012-03-19  Alexander Færøy  <alexander.faeroy@nokia.com>
1593
1594         [Qt] Add command line option to set the user agent in the MiniBrowser
1595         https://bugs.webkit.org/show_bug.cgi?id=81508
1596
1597         Reviewed by Simon Hausmann.
1598
1599         * MiniBrowser/qt/BrowserWindow.cpp:
1600         (BrowserWindow::BrowserWindow):
1601         (BrowserWindow::webViewExperimental):
1602         * MiniBrowser/qt/BrowserWindow.h:
1603         (BrowserWindow):
1604         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1605         (printHelp):
1606         (MiniBrowserApplication::handleUserOptions):
1607         * MiniBrowser/qt/MiniBrowserApplication.h:
1608         (WindowOptions::WindowOptions):
1609         (WindowOptions::setUserAgent):
1610         (WindowOptions::userAgent):
1611         (WindowOptions):
1612
1613 2012-03-19  Alexander Færøy  <alexander.faeroy@nokia.com>
1614
1615         [Qt] Remove dead user agent code from the MiniBrowser.
1616
1617         Reviewed by Simon Hausmann.
1618
1619         * MiniBrowser/qt/BrowserWindow.cpp:
1620         * MiniBrowser/qt/BrowserWindow.h:
1621         (BrowserWindow):
1622         * MiniBrowser/qt/MiniBrowser.qrc:
1623         * MiniBrowser/qt/useragentlist.txt: Removed.
1624
1625 2012-03-19  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1626
1627         jhbuild: Call jhbuild's autogen.sh via bash.
1628         https://bugs.webkit.org/show_bug.cgi?id=81485
1629
1630         Reviewed by Philippe Normand.
1631
1632         jhbuild's autogen.sh uses "/bin/bash" in the shebang line, however
1633         this is usually true only on Linux systems, and even then bash for
1634         some reason might not be available in that location. It is safer to
1635         call bash directly and pass autogen.sh to it instead.
1636
1637         * jhbuild/jhbuild-wrapper:
1638         (install_jhbuild):
1639
1640 2012-03-19  Philippe Normand  <pnormand@igalia.com>
1641
1642         [GTK] Prefix run-launcher with run-with-jhbuild
1643         https://bugs.webkit.org/show_bug.cgi?id=81503
1644
1645         Reviewed by Hajime Morita.
1646
1647         * Scripts/run-launcher:
1648
1649 2012-03-19  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1650
1651         [EFL] Prefix run-launcher with run-with-jhbuild
1652         https://bugs.webkit.org/show_bug.cgi?id=80026
1653
1654         Reviewed by Hajime Morita.
1655
1656         * Scripts/run-launcher:
1657
1658 2012-03-18  Csaba Osztrogonác  <ossy@webkit.org>
1659
1660         [Qt] Unreviewed. Disable -Werror on x86 until proper fix.
1661         https://bugs.webkit.org/show_bug.cgi?id=81498
1662
1663         * qmake/mkspecs/features/unix/default_post.prf:
1664
1665 2012-03-17  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1666
1667         Unreviewed; switch to using my FreeBSD.org email address, the
1668         other one is going to disappear soon.
1669
1670         * Scripts/webkitpy/common/config/committers.py:
1671         * Scripts/webkitpy/common/config/watchlist:
1672
1673 2012-03-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
1674
1675         Unreviewed; fix webkitpy unit test failures after r111116.
1676
1677         It turns out that cmd_line in the patch in bug 80025 had the right
1678         signature when it was submitted, but r109242 added a few more
1679         required parameters, and since the method (and EflDriver) did not
1680         exist at the time we ended up committing a broken method.
1681
1682         * Scripts/webkitpy/layout_tests/port/efl.py:
1683         (EflDriver.cmd_line): Add the `pixel_tests' and `per_test_args'
1684         arguments.
1685
1686 2012-03-17  Charles Wei  <charles.wei@torchmobile.com.cn>
1687
1688         [BlackBerry] Enable Web Timing for performance profiling and improvement.
1689         https://bugs.webkit.org/show_bug.cgi?id=81085
1690
1691         Reviewed by Rob Buis.
1692
1693         * Scripts/build-webkit:
1694
1695 2012-03-17  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1696
1697         Add a dependencies installation step for EFL to buildbot master.cfg
1698         https://bugs.webkit.org/show_bug.cgi?id=81337
1699
1700         Reviewed by Gustavo Noronha Silva.
1701
1702         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1703         (InstallEflDependencies):
1704         (Factory.__init__):
1705
1706 2012-03-17  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1707
1708         [EFL] Prefixing run-webkit-tests with run-with-jhbuild
1709         https://bugs.webkit.org/show_bug.cgi?id=80025
1710
1711         Reviewed by Gustavo Noronha Silva.
1712
1713         * Scripts/webkitpy/layout_tests/port/efl.py:
1714         (EflDriver):
1715         (EflDriver.cmd_line):
1716         (EflPort._driver_class):
1717
1718 2012-03-17  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1719
1720         [EFL] Add and use run-with-jhbuild and update-webkitefl-libs scripts for EFL
1721         https://bugs.webkit.org/show_bug.cgi?id=79904
1722
1723         build-webkit --efl will use jhbuild for fetching and building dependencies.
1724
1725         Reviewed by Gustavo Noronha Silva.
1726
1727         * Scripts/update-webkitefl-libs: Added.
1728         * Scripts/webkitdirs.pm:
1729         (jhbuildWrapperPrefixIfNeeded):
1730         (generateBuildSystemFromCMakeProject):
1731         (buildCMakeGeneratedProject):
1732         * efl/common.py: Added.
1733         (script_path):
1734         (top_level_path):
1735         (number_of_cpus):
1736         * efl/jhbuild.modules: Added.
1737         * efl/jhbuildrc: Added.
1738         * efl/run-with-jhbuild: Added.
1739
1740 2012-03-16  Stephanie Lewis  <slewis@apple.com>
1741
1742         https://bugs.webkit.org/show_bug.cgi?id=81065
1743         <rdar://problem/10944309> CrashTracer: [USER] 111 crashes in WebProcess at WebKitTestRunnerInjectedBundle: WTR::InjectedBundle::done + 142
1744         Fix crash preventing WebKitTestRunner from working in Release.
1745         WebKitTestRunner used ostringstream to collect output from the test.  ostringstream is incompatible with our
1746         FastMalloc overrides.  When copying strings out ostringstream a new string is allocated with FastMalloc because
1747         the allocation is inlined.  When that string is freed is uses the system malloc because that call is not inlined.
1748
1749         I removed ostringstream in favor of StringBuilder.
1750
1751         Properly set NDEBUG on Release builds so we don't crash when when we free the strings StringBuilder created.
1752
1753         Reviewed by Geoff Garen.
1754
1755         Add DEBUG_DEFINES to set NDEBUG on release builds.
1756         * WebKitTestRunner/Configurations/Base.xcconfig:
1757         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1758
1759         Remove ostringstream member in favor of StringBuilder.
1760         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1761         (WTR::InjectedBundle::initialize):
1762         (WTR::InjectedBundle::beginTesting):
1763         (WTR::InjectedBundle::done):
1764         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1765         (WTF):
1766         (WTR::InjectedBundle::stringBuilder):
1767         (InjectedBundle):
1768
1769         Append output to StringBuilder.
1770         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1771         (WTR::hasPrefix):
1772         (WTR::dumpPath):
1773         (WTR::rangeToStr):
1774         (WTR::styleDecToStr):
1775         (WTR::frameToStr):
1776         (WTR::dumpFrameScrollPosition):
1777         (WTR::dumpFrameText):
1778         (WTR::dumpDescendantFramesText):
1779         (WTR::InjectedBundlePage::dump):
1780         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1781         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1782         (WTR::InjectedBundlePage::willSendRequestForFrame):
1783         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1784         (WTR::lastFileURLPathComponent):
1785         (WTR::InjectedBundlePage::willAddMessageToConsole):
1786         (WTR::InjectedBundlePage::willSetStatusbarText):
1787         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
1788         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
1789         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
1790         (WTR::InjectedBundlePage::shouldBeginEditing):
1791         (WTR::InjectedBundlePage::shouldEndEditing):
1792         (WTR::InjectedBundlePage::shouldInsertNode):
1793         (WTR::InjectedBundlePage::shouldInsertText):
1794         (WTR::InjectedBundlePage::shouldDeleteRange):
1795         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
1796         (WTR::InjectedBundlePage::shouldApplyStyle):
1797         (WTR::InjectedBundlePage::didBeginEditing):
1798         (WTR::InjectedBundlePage::didEndEditing):
1799         (WTR::InjectedBundlePage::didChange):
1800         (WTR::InjectedBundlePage::didChangeSelection):
1801         (WTR::InjectedBundlePage::supportsFullScreen):
1802         (WTR::InjectedBundlePage::enterFullScreenForElement):
1803         (WTR::InjectedBundlePage::exitFullScreenForElement):
1804         (WTR::InjectedBundlePage::beganEnterFullScreen):
1805         (WTR::InjectedBundlePage::beganExitFullScreen):
1806         (WTR::dumpBackForwardListItem):
1807         (WTR::InjectedBundlePage::dumpBackForwardList):
1808         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1809         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired):
1810         (WTR::LayoutTestController::dumpConfigurationForViewport):
1811
1812         Convert between WTF::String and WKStringRef.
1813         * WebKitTestRunner/StringFunctions.h:
1814         (WTR::toWTFString):
1815         (WTR):
1816         * WebKitTestRunner/TestInvocation.cpp:
1817         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1818
1819 2012-03-16  Eric Seidel  <eric@webkit.org>
1820
1821         Add a land-from-url command
1822         https://bugs.webkit.org/show_bug.cgi?id=81411
1823
1824         Reviewed by Adam Barth.
1825
1826         Very basic so far.  The goal is to make it landing smarter
1827         so that users don't have to bother to parse out the ids out of the urls.
1828
1829         * Scripts/webkitpy/common/config/urls.py:
1830         (parse_bug_id):
1831         (parse_attachment_id):
1832         * Scripts/webkitpy/common/config/urls_unittest.py:
1833         (URLsTest.test_parse_bug_id):
1834         (URLsTest):
1835         (URLsTest.test_parse_attachment_id):
1836         * Scripts/webkitpy/tool/commands/download.py:
1837         (ProcessURLsMixin):
1838         (ProcessURLsMixin._fetch_list_of_patches_to_process):
1839         (LandFromURL):
1840         * Scripts/webkitpy/tool/commands/download_unittest.py:
1841         (test_land_from_bug):
1842         (test_land_from_url):
1843
1844 2012-03-16  Dave Tharp  <dtharp@codeaurora.org>
1845
1846         build-webkit launcher instructions use wrong relative path for Qt
1847         https://bugs.webkit.org/show_bug.cgi?id=81357
1848
1849         Reviewed by Eric Seidel.
1850
1851         Ensure we are at the proper directory before generating run-launcher
1852         instructions.
1853
1854         * Scripts/build-webkit:
1855
1856 2012-03-16  Brady Eidson  <beidson@apple.com>
1857
1858         <rdar://problem/11027997> and https://bugs.webkit.org/show_bug.cgi?id=81412
1859         REGRESSION (r107435) Copy a link and paste to Mail: Nothing is pasted
1860
1861         Reviewed by Geoff Garen.
1862
1863         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1864         * TestWebKitAPI/Tests/mac/WebViewCanPasteURL.mm: Added.
1865
1866 2012-03-16  Ojan Vafai  <ojan@chromium.org>
1867
1868         Mark wontfix tests in full_results.json so we can ignore them in garden-o-matic
1869         https://bugs.webkit.org/show_bug.cgi?id=81407
1870
1871         Reviewed by Adam Barth.
1872
1873         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1874         (summarize_results):
1875         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1876         (ResultSummaryTest.summarized_results):
1877         (ResultSummaryTest.test_no_svn_revision):
1878         (ResultSummaryTest.test_svn_revision):
1879         (ResultSummaryTest):
1880         (ResultSummaryTest.test_summarized_results_wontfix):
1881
1882 2012-03-16  Ojan Vafai  <ojan@chromium.org>
1883
1884         Have webkit-patch rebaseline-test update test_expectations.txt
1885         https://bugs.webkit.org/show_bug.cgi?id=81054
1886
1887         Recommit http://trac.webkit.org/changeset/110783 now that
1888         http://trac.webkit.org/changeset/111034 has landed.
1889
1890         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1891         (TestExpectations.remove_configuration_from_test):
1892         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1893         (RemoveConfigurationsTest):
1894         (RemoveConfigurationsTest.test_remove):
1895         (test_remove_line):
1896         * Scripts/webkitpy/tool/commands/rebaseline.py:
1897         (RebaselineTest._update_expectations_file):
1898         (RebaselineTest._rebaseline_test_and_update_expectations):
1899         (RebaselineTest):
1900         (RebaselineTest.execute):
1901         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1902         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
1903         (test_rebaseline_updates_expectations_file):
1904
1905 2012-03-15  Ojan Vafai  <ojan@chromium.org>
1906
1907         Specifier collapsing when writing test expectations lines gets a number of cases wrong
1908         https://bugs.webkit.org/show_bug.cgi?id=81309
1909
1910         Reviewed by Dimitri Glazkov.
1911
1912         I've run this over all the lines in the current Chromium test_expectations.txt file,
1913         so I'm relatively confident we now cover all the cases.
1914
1915         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
1916         (TestConfigurationConverter.__init__):
1917         (TestConfigurationConverter.collapse_macros):
1918         (TestConfigurationConverter.collapse_macros.collapse_individual_specifier_set):
1919         (TestConfigurationConverter):
1920         (TestConfigurationConverter.intersect_combination):
1921         (TestConfigurationConverter.symmetric_difference):
1922         (TestConfigurationConverter.to_specifiers_list):
1923         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
1924         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
1925         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
1926         (make_mock_all_test_configurations_set):
1927         (TestConfigurationConverterTest.test_symmetric_difference):
1928         (TestConfigurationConverterTest.test_to_config_set):
1929         (TestConfigurationConverterTest.test_macro_expansion):
1930         (TestConfigurationConverterTest.test_to_specifier_lists):
1931         (TestConfigurationConverterTest.test_converter_macro_collapsing):
1932         * Scripts/webkitpy/layout_tests/port/chromium.py:
1933         (ChromiumPort):
1934         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1935         (ChromiumAndroidPort.__init__):
1936         The android port uses "arm" as it's architecture, which is technically correct,
1937         but considerably complicates making collapsing work. We probably should kill
1938         the concept of architecture entirely. The benefits are not worth the code
1939         complexity.
1940
1941         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1942         (ChromiumPortTest.test_all_test_configurations):
1943         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1944         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
1945         (test_rebaseline_updates_expectations_file):
1946
1947 2012-03-16  Dinu Jacob  <dinu.jacob@nokia.com>
1948
1949         [Qt][Wk2] Assertion Failure and crash on file upload
1950         https://bugs.webkit.org/show_bug.cgi?id=80854
1951
1952         Reviewed by Simon Hausmann.
1953
1954         Added filePicker to WebView using experimental API.
1955
1956         * MiniBrowser/qt/MiniBrowser.qrc:
1957         * MiniBrowser/qt/icons/folder.png: Added.
1958         * MiniBrowser/qt/icons/titlebar.png: Added.
1959         * MiniBrowser/qt/icons/up.png: Added.
1960         * MiniBrowser/qt/qml/BrowserWindow.qml:
1961         * MiniBrowser/qt/qml/FilePicker.qml: Added.
1962
1963 2012-03-16  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1964
1965         Updating email for committer.py script.
1966
1967         * Scripts/webkitpy/common/config/committers.py:
1968
1969 2012-03-16  Robert Kroeger  <rjkroege@chromium.org>
1970
1971         [chromium] DRT: Add support for sending gesture scrolls without a begin
1972         https://bugs.webkit.org/show_bug.cgi?id=81292
1973
1974         Reviewed by Kent Tamura.
1975
1976         * DumpRenderTree/chromium/EventSender.cpp:
1977         (EventSender::EventSender):
1978         (EventSender::gestureScrollFirstPoint):
1979         * DumpRenderTree/chromium/EventSender.h:
1980         (EventSender):
1981
1982 2012-03-02  Carlos Garcia Campos  <cgarcia@igalia.com> and Sergio Villar Senin  <svillar@igalia.com>
1983
1984         [GTK] WebKitIconDatabase doesn't keep icons cached
1985         https://bugs.webkit.org/show_bug.cgi?id=56200
1986
1987         Reviewed by Martin Robinson.
1988
1989         Add support for favicons in GtkLauncher.
1990
1991         * GtkLauncher/main.c:
1992         (activateUriEntryCb):
1993         (iconLoadedCb):
1994         (createBrowser):
1995
1996 2012-03-16  Adam Barth  <abarth@webkit.org>
1997
1998         Remove sheriff-bot's last-green-revision command
1999         https://bugs.webkit.org/show_bug.cgi?id=81314
2000
2001         Reviewed by Eric Seidel.
2002
2003         This command is a cruel joke.  WebKit doesn't really ever have a
2004         last-green-revision.
2005
2006         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2007         (BuildBot._find_green_revision):
2008         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
2009         (MockBuildBot.builder_statuses):
2010         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2011         (test_find_green_revision):
2012         * Scripts/webkitpy/tool/bot/irc_command.py:
2013         (IRCCommand.execute):
2014         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2015         (SheriffIRCBotTest.test_help):
2016         * Scripts/webkitpy/tool/commands/queries.py:
2017         (PatchesToReview.execute):
2018
2019 2012-03-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2020
2021         [Qt] Make gccdepends test aware of broken icecream deps generation
2022
2023         Icecream seems to build the files without passing -o to gcc with
2024         the original destination path, which means the target name in the
2025         dependency file is wrong.
2026
2027         Also, echo something to the final file instead of just touching it,
2028         so it's not deleted on every build.
2029
2030         Reviewed by Simon Hausmann.
2031
2032         * qmake/config.tests/gccdepends/gccdepends.pro:
2033
2034 2012-03-16  Kihong Kwon  <kihong.kwon@samsung.com>
2035
2036         Support for Battery Status API
2037         https://bugs.webkit.org/show_bug.cgi?id=62698
2038
2039         Add include directory and file.
2040         http://www.w3.org/TR/battery-status/
2041
2042         Reviewed by Adam Barth.
2043
2044         * Scripts/build-webkit:
2045
2046 2012-03-16  Kishore Bolisetty  <kbolisetty@innominds.com>
2047
2048         check-webkit-style fails on LayoutTests/platform/efl/test_expectations.txt
2049         https://bugs.webkit.org/show_bug.cgi?id=81007
2050
2051         Reviewed by Adam Barth.
2052
2053         A dedidcated build slave is available for efl on build.webkit.org.
2054         This change add's an entry for the elf port in list of available port builders.
2055         This is required because test_expectations.py when triggered, looks for a valid port object for the specified port.
2056
2057         * Scripts/webkitpy/layout_tests/port/builders.py:
2058
2059 2012-03-16  Adam Barth  <abarth@webkit.org>
2060
2061         [webkitpy] StatusServer.next_work_item has an incorrectly named local variable
2062         https://bugs.webkit.org/show_bug.cgi?id=81302
2063
2064         Reviewed by Eric Seidel.
2065
2066         This is a trivial patch, but the variable name turned up in a grep of
2067         webkitpy and looks like copy pasta.
2068
2069         * Scripts/webkitpy/common/net/statusserver.py:
2070         (StatusServer.next_work_item):
2071
2072 2012-03-16  Andrew Lo  <anlo@rim.com>
2073
2074         [BlackBerry] Enable PAGE_VISIBILITY_API
2075         https://bugs.webkit.org/show_bug.cgi?id=81257
2076
2077         Enable Page Visibility API for BlackBerry.
2078
2079         Reviewed by Rob Buis.
2080
2081         * Scripts/build-webkit:
2082
2083 2012-03-16  Zan Dobersek  <zandobersek@gmail.com>
2084
2085         [Gtk] Add computedStyleIncludingVisitedInfo to DumpRenderTreeSupport
2086         https://bugs.webkit.org/show_bug.cgi?id=81232
2087
2088         Reviewed by Philippe Normand.
2089
2090         Use the newly-added helper method in DumpRenderTreeSupportGtk.
2091
2092         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2093         (LayoutTestController::computedStyleIncludingVisitedInfo):
2094
2095 2012-03-15  Eric Seidel  <eric@webkit.org>
2096
2097         Move parse_bug_id into config/urls in preparation for re-use elsewhere.
2098         https://bugs.webkit.org/show_bug.cgi?id=81313
2099
2100         Reviewed by Adam Barth.
2101
2102         * Scripts/webkitpy/common/checkout/changelog.py:
2103         (parse_bug_id_from_changelog):
2104         * Scripts/webkitpy/common/config/urls.py:
2105         (parse_bug_id):
2106         * Scripts/webkitpy/common/config/urls_unittest.py: Copied from Tools/Scripts/webkitpy/common/config/urls.py.
2107         (URLsTest):
2108         (URLsTest.test_parse_bug_id):
2109         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2110         (test_parse_bug_id):
2111         * Scripts/webkitpy/tool/bot/irc_command.py:
2112         (_post_error_and_check_for_bug_url):
2113         * Scripts/webkitpy/tool/bot/sheriff.py:
2114         (Sheriff.post_rollout_patch):
2115         (Sheriff.post_chromium_deps_roll):
2116
2117 2012-03-15  Adam Barth  <abarth@webkit.org>
2118
2119         The commit-queue should fast-track patches that have already passed the testing EWS bots
2120         https://bugs.webkit.org/show_bug.cgi?id=81305
2121
2122         Reviewed by Eric Seidel.
2123
2124         If a patch has already passed the testing EWS bots (currently only the
2125         chromium-ews bot), we should be able to land the patch without running
2126         the tests again.  This patch is somewhat risky in that the tests might
2127         have been broken between when the EWS bots ran and when the
2128         commit-queue is processing the patch.  If that turns out to be a
2129         problem in practice, we'll tighten up this fast-track in some way,
2130         likely by making sure that the pass status is recent.
2131
2132         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2133         (CommitQueueTaskDelegate.did_pass_testing_ews):
2134         (CommitQueueTask._did_pass_tests_recently):
2135         (CommitQueueTask.run):
2136         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2137         (MockCommitQueue.did_pass_testing_ews):
2138         (test_fast_success_case):
2139         * Scripts/webkitpy/tool/commands/queues.py:
2140         (CommitQueue.did_pass_testing_ews):
2141         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2142         (test_did_pass_testing_ews):
2143
2144 2012-03-15  Kentaro Hara  <haraken@chromium.org>
2145
2146         [PerformanceTests] run-perf-tests should output correct units
2147         https://bugs.webkit.org/show_bug.cgi?id=78303
2148
2149         Reviewed by Ryosuke Niwa.
2150
2151         Previously run-perf-tests just supported "ms" for units.
2152         Consequently, Dromaeo perf tests had been reporting runs/s as "ms".
2153         This patch fixes run-perf-tests so that they can support custom units.
2154         The default unit is "ms".
2155
2156         The test result looks like this:
2157
2158         $ ./Tools/Scripts/run-perf-tests Dromaeo/dom-attr.html
2159         RESULT Dromaeo: dom-attr= 6465.9525483 runs/s
2160         median= 0.0 runs/s, stdev= 24.2983433436 runs/s, min= 6435.87649402 runs/s, max= 6515.63693392 runs/s
2161
2162         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2163         (PerfTestsRunner._process_parser_test_result):
2164
2165 2012-03-15  Brent Fulgham  <bfulgham@webkit.org>
2166
2167         [WinCairo] Unreviewed build change after wtf path changes.
2168
2169         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Updated include
2170         directories to look at the private header directory to find 'wtf'.
2171
2172 2012-03-15  Kent Tamura  <tkent@chromium.org>
2173
2174         REGRESSION(r110595): webkit-patch suggest-reviewers doesn't work
2175         https://bugs.webkit.org/show_bug.cgi?id=81293
2176
2177         Reviewed by Adam Barth.
2178
2179         r110595 introduced new format of the author field of ChangeLog entry:
2180         "Adam Barth  <abarth@webkit.org> && Benjamin Poulain  <bpoulain@apple.com>"
2181         Updte chanelog.py to support it.
2182
2183         * Scripts/webkitpy/common/checkout/changelog.py:
2184         (ChangeLogEntry._split_contributor_names):
2185         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2186         (test_parse_authors):
2187
2188 2012-03-15  Lynn Neir  <lynn.neir@skype.net>
2189
2190         Implement LayoutTestController::setValueForUser on Windows https://bugs.webkit.org/show_bug.cgi?id=55834
2191
2192         Implemented setValueForUser in both DumpRenderTree and WebKitTestRunner.
2193
2194         Reviewed by Jessie Berlin.
2195
2196         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2197         (LayoutTestController::setValueForUser):
2198         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2199         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2200         (WTR::LayoutTestController::setValueForUser):
2201         (WTR):
2202         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2203         (LayoutTestController):
2204
2205 2012-03-15  Adam Barth  <abarth@webkit.org>
2206
2207         Update the start-queue.sh script to match what we're using on the bots
2208         https://bugs.webkit.org/show_bug.cgi?id=81277
2209
2210         Reviewed by Eric Seidel.
2211
2212         Over time we've added more magic git commands to clean up the local repo after
2213         it has been borked in various ways. The idea behind this sequence is to clear
2214         out any changes in the working copy and then to rebuild the master branch from
2215         origin/master.
2216
2217         This patch also removes the watchdog timer that we've stopped using on the
2218         bots.
2219
2220         This patch was reviewed on <https://github.com/eseidel/webkit/pull/1>.
2221         Note: Eric and I are experimenting with GitHub to see if it might be
2222         useful for WebKit.  If you have thoughts on this topic, please feel
2223         free to grab Eric or me on #webkit to chat.  I assume that he and I are
2224         the only ones who care about this file so using this alternative
2225         process for this patch shouldn't cause any trouble.
2226
2227         * EWSTools/start-queue.sh:
2228
2229 2012-03-15  Adam Barth  <abarth@webkit.org>
2230
2231         The commit-queue can hang when the test_expectations.txt style check fails during commit
2232         https://bugs.webkit.org/show_bug.cgi?id=81251
2233
2234         Reviewed by Eric Seidel.
2235
2236         We forgot to check the --non-interactive flag, so we end up prompting
2237         the "user" who doesn't exist on the bot.  We might consider teaching
2238         the User class about non-interactive if we have this sort of bug again.
2239
2240         * Scripts/webkitpy/tool/steps/commit.py:
2241         (Commit.options):
2242         (Commit._check_test_expectations):
2243         (Commit.run):
2244         * Scripts/webkitpy/tool/steps/commit_unittest.py:
2245         (CommitTest.test_check_test_expectations):
2246
2247 2012-03-15  Jessie Berlin  <jberlin@apple.com>
2248
2249         fast/dom/Window/window-properties.html and fast/dom/prototype-inheritance-2.html failing on
2250         Mac WK2 because WebAudio is not enabled
2251         https://bugs.webkit.org/show_bug.cgi?id=81259
2252
2253         Reviewed by Dan Bernstein.
2254
2255         Enable WebAudio so that it appears in the window object in the tests.
2256         The webaudio tests are all still skipped in the Mac Skipped list.
2257
2258         * WebKitTestRunner/TestController.cpp:
2259         (WTR::TestController::resetStateToConsistentValues):
2260
2261 2012-03-15  David Levin  <levin@chromium.org>
2262
2263         Various autoresize fixes.
2264         https://bugs.webkit.org/show_bug.cgi?id=81199
2265
2266         Reviewed by Darin Fisher.
2267
2268         * DumpRenderTree/chromium/LayoutTestController.cpp:
2269         (LayoutTestController::reset): Stop using the deprecated api that was removed.
2270
2271 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2272
2273         [GTK] Actually use --release and --debug command line options in run-gtk-test
2274         https://bugs.webkit.org/show_bug.cgi?id=81234
2275
2276         Reviewed by Philippe Normand.
2277
2278         Actually handle --release and --debug command line options to
2279         create the build directory, falling back to current hack to detect
2280         whether it's a Release or Debug build when both options are missed.
2281
2282         * Scripts/run-gtk-tests:
2283         (TestRunner.__init__): Receive options too.
2284         (TestRunner._get_top_level_directory): Helper function to get the
2285         top level directory.
2286         (TestRunner._get_build_directory): Helper function to get the
2287         build directory depending on --release/--debug command line
2288         options or gessing it if both options are missing.
2289         (TestRunner._ensure_accessibility_daemon_is_running): Use
2290         self-options now.
2291         (TestRunner.run): Ditto.
2292         (TestRunner.run.run_tests): Pass options to the constructor
2293         instead of run().
2294
2295 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2296
2297         [GTK] Run unit tests with --verbose in the bots
2298         https://bugs.webkit.org/show_bug.cgi?id=81230
2299
2300         Reviewed by Martin Robinson.
2301
2302         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2303         (RunGtkAPITests): Add --verbose to run-gtk-test command.
2304
2305 2012-03-15  Kevin Ollivier  <kevino@theolliviers.com>
2306
2307         Move wx port to using export macros
2308         https://bugs.webkit.org/show_bug.cgi?id=77279
2309
2310         Reviewed by Hajime Morita.
2311
2312         * waf/build/settings.py:
2313         (common_configure):
2314
2315 2012-03-15  Philippe Normand  <pnormand@igalia.com>
2316
2317         Unreviewed, GTK build fix attempt after r110845.
2318
2319         * Scripts/run-gtk-tests: Added --release and --debug options.
2320
2321 2012-03-15  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
2322
2323         Parametrize run-with-jhbuild and update-webkitgtk-libs with platform --gtk/--efl
2324         https://bugs.webkit.org/show_bug.cgi?id=79673
2325
2326         Preparatory work for bringing jhbuild enabled build to EFL port.
2327
2328         Reviewed by Philippe Normand.
2329
2330         * Scripts/update-webkit-libs-jhbuild: Copied from Tools/Scripts/update-webkitgtk-libs.
2331         * Scripts/update-webkitgtk-libs:
2332         * gtk/run-with-jhbuild:
2333         * jhbuild/jhbuild-wrapper: Copied from Tools/gtk/run-with-jhbuild.
2334         (top_level_path):
2335         (jhbuild_installed):
2336         (jhbuild_cloned):
2337         (jhbuild_at_expected_revision):
2338         (update_jhbuild):
2339         (clone_jhbuild):
2340         (install_jhbuild):
2341         (update_webkit_libs_jhbuild):
2342         (determine_platform):
2343         (ensure_jhbuild):
2344
2345 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2346
2347         [GTK] Add command line options to run-gtk-tests script
2348         https://bugs.webkit.org/show_bug.cgi?id=81218
2349
2350         Reviewed by Philippe Normand.
2351
2352         Following command line options have been added:
2353
2354         -v, --verbose: to run gtester with --verbose. That would be used
2355         by the bots to make it easier to know which test case it failing.
2356
2357         --display: to use a different display for Xvfb
2358
2359         It's also possible to pass one or more tests as arguments.
2360
2361         * Scripts/run-gtk-tests:
2362         (TestRunner.__init__): Receive command line arguments.
2363         (TestRunner._get_tests): Get all the tests or the ones passed by
2364         command line arguments.
2365         (TestRunner._ensure_accessibility_daemon_is_running): Use display
2366         command line argument.
2367         (TestRunner.run): Pas command line options.
2368         (TestRunner.run.run_tests): Pass command line arguments.
2369
2370 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2371
2372         [GTK] WebKit2APITests/TestPrinting timeout in the bots
2373         https://bugs.webkit.org/show_bug.cgi?id=81211
2374
2375         Reviewed by Philippe Normand.
2376
2377         Add gtk+ patch to fix timeout in the bots. A similar patch has
2378         already landed in updatream gtk+, see
2379         http://git.gnome.org/browse/gtk+/commit/?id=5ebfad5d091f4c9d9c6e60364fad4c60842f027f
2380
2381         * gtk/jhbuild.modules:
2382         * gtk/patches/gtk+-3.0.12-gtkprinter.patch: Added.
2383
2384 2012-03-14  Gustavo Noronha Silva  <gns@gnome.org>
2385
2386         sheriffbot should also be addressable with a comma in addition to colon
2387         https://bugs.webkit.org/show_bug.cgi?id=81101
2388
2389         Reviewed by Adam Barth.
2390
2391         * Scripts/webkitpy/common/net/irc/ircbot.py:
2392         (IRCBot.on_pubmsg):
2393
2394 2012-03-15  Alexander Færøy  <alexander.faeroy@nokia.com>
2395
2396         [Qt] MiniBrowser scroll indicators should not scroll out of view
2397         https://bugs.webkit.org/show_bug.cgi?id=81131
2398
2399         Reviewed by Kenneth Rohde Christiansen.
2400
2401         * MiniBrowser/qt/qml/ScrollIndicator.qml:
2402
2403 2012-03-14  Chris Fleizach  <cfleizach@apple.com>
2404
2405         AX: ARIA tables need to support selected rows attribute/select rows changed notification
2406         https://bugs.webkit.org/show_bug.cgi?id=79821
2407
2408         Reviewed by Beth Dakin.
2409
2410         * DumpRenderTree/AccessibilityUIElement.cpp:
2411         (rowAtIndexCallback):
2412         (AccessibilityUIElement::getJSClass):
2413         * DumpRenderTree/AccessibilityUIElement.h:
2414         (AccessibilityUIElement):
2415         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
2416         (AccessibilityUIElement::rowAtIndex):
2417         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2418         (AccessibilityUIElement::rowAtIndex):
2419         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2420         (AccessibilityUIElement::rowAtIndex):
2421         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2422         (AccessibilityUIElement::rowAtIndex):
2423
2424 2012-03-14  Tim Horton  <timothy_horton@apple.com>
2425
2426         NRWT should respect --additional-platform-directory's Skipped list
2427         https://bugs.webkit.org/show_bug.cgi?id=81172
2428
2429         Reviewed by Timothy Hatcher.
2430
2431         Respect the Skipped file inside all paths included via the --additional-platform-directory option. Test results
2432         from said path are already used, but the Skipped file is ignored.
2433
2434         * Scripts/webkitpy/layout_tests/port/webkit.py:
2435         (WebKitPort._skipped_file_search_paths):
2436         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2437         (test_skipped_file_search_paths):
2438
2439 2012-03-14  Ojan Vafai  <ojan@chromium.org>
2440
2441         Unreviewed, rolling out r110783.
2442         http://trac.webkit.org/changeset/110783
2443         https://bugs.webkit.org/show_bug.cgi?id=81054
2444
2445         Caused existing test expectation lines to expand to one for
2446         each test configuration.
2447
2448         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2449         (TestExpectations.has_warnings):
2450         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2451         (test_macro_overrides):
2452         * Scripts/webkitpy/tool/commands/rebaseline.py:
2453         (RebaselineTest._save_baseline):
2454         (RebaselineTest._rebaseline_test):
2455         (RebaselineTest.execute):
2456         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2457         (TestRebaseline.test_tests_to_update):
2458
2459 2012-03-13  Jon Lee  <jonlee@apple.com>
2460
2461         Separate NOTIFICATIONS and LEGACY_NOTIFICATIONS
2462         https://bugs.webkit.org/show_bug.cgi?id=80922
2463         <rdar://problem/11035082>
2464
2465         Reviewed by Jian Li.
2466
2467         You can include either NOTIFICATIONS or LEGACY_NOTIFICATIONS and have a complete API.
2468         LEGACY_NOTIFICATIONS should cover all of the previous functionality, and NOTIFICATIONS will cover the
2469         new API. Therefore, APIs that are common between the two will have:
2470         #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
2471
2472         This patch initially sets both to be exactly the same. As other bugs with patches begin to migrate to
2473         the new API, the defines will begin to split. This allows ports to decide which set of APIs to include.
2474
2475         Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
2476         * DumpRenderTree/chromium/LayoutTestController.cpp:
2477         (LayoutTestController::grantDesktopNotificationPermission):
2478         (LayoutTestController::simulateDesktopNotificationClick):
2479         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2480         * DumpRenderTree/chromium/TestShell.cpp:
2481         (TestShell::TestShell):
2482         (TestShell::resetTestController):
2483         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2484         (DRTDesktopNotificationPresenter::checkNotificationPermission):
2485
2486 2012-03-13  Ojan Vafai  <ojan@chromium.org>
2487
2488         Have webkit-patch rebaseline-test update test_expectations.txt
2489         https://bugs.webkit.org/show_bug.cgi?id=81054
2490
2491         Reviewed by Dirk Pranke.
2492
2493         This will allow us to use the All Failures tab in garden-o-matic
2494         to rebaseline tests without making test_expectations.txt stale.
2495
2496         It's conservative and only removes lines if the test is
2497         not flaky and fails in a way the rebaseline would fix (e.g.
2498         CRASH/TIMEOUT will not be touched).
2499
2500         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2501         (TestExpectations.remove_configuration_from_test):
2502         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2503         (RemoveConfigurationsTest):
2504         (RemoveConfigurationsTest.test_remove):
2505         (test_remove_line):
2506         * Scripts/webkitpy/tool/commands/rebaseline.py:
2507         (RebaselineTest._is_supported_port):
2508         (RebaselineTest):
2509         (RebaselineTest._update_expectations_file):
2510         (RebaselineTest._rebaseline_test_and_update_expectations):
2511         (RebaselineTest.execute):
2512         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2513         (TestRebaseline.test_rebaseline_updates_expectations_file):
2514
2515 2012-03-14  Jessie Berlin  <jberlin@apple.com>
2516
2517         Crash in WKTR under addChromeInputField due to using 0 as a key in a HashMap
2518         https://bugs.webkit.org/show_bug.cgi?id=81167
2519
2520         Reviewed by Sam Weinig.
2521
2522         Do not use 0 as a key in a HashMap.
2523
2524         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2525         cacheLayoutTestControllerCallback uses the enum as keys for the callback map.
2526
2527 2012-03-14  Ojan Vafai  <ojan@chromium.org>
2528
2529         Add the chromium lion bot to garden-o-matic and remove
2530         the platform_move_to in builders.py since the Chromium Lion
2531         port is now a normal port.
2532
2533         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2534         * Scripts/webkitpy/layout_tests/port/builders.py:
2535
2536 2012-03-14  Dirk Pranke  <dpranke@chromium.org>
2537
2538         Fix regression/crash introduced in r110724 - bad type passed from skipped_tests() by default.
2539
2540         Unreviewed, build fix.
2541
2542         * Scripts/webkitpy/layout_tests/port/base.py:
2543         (Port.skipped_tests):
2544
2545 2012-03-14  Dirk Pranke  <dpranke@chromium.org>
2546
2547         Please add a way to manually skip some tests in NRWT
2548         https://bugs.webkit.org/show_bug.cgi?id=81019
2549
2550         Reviewed by Ojan Vafai.
2551
2552         This patch implements the -i / --ignore-tests flag from ORWT
2553         and refactors the test_expectations.py code slightly to handle
2554         it.
2555
2556         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2557         (Manager.parse_expectations):
2558         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2559         (TestExpectations.__init__):
2560         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2561         (test_add_skipped_tests):
2562         (test_add_skipped_tests_duplicate):
2563         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2564         (parse_args):
2565         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2566         (MainTest.test_ignore_tests):
2567         (MainTest.test_ignore_tests.assert_ignored):
2568
2569 2012-03-14  Dirk Pranke  <dpranke@chromium.org>
2570
2571         nrwt: run with no args on lion, is putting baselines in platform/mac-lion, not platform/mac
2572         https://bugs.webkit.org/show_bug.cgi?id=81028
2573
2574         Reviewed by Ojan Vafai.
2575
2576         The mac port had incorrect lookups for 'mac-lion' and
2577         'mac-future' in some places. This patch fixes that and adds a
2578         bunch of tests.
2579
2580         * Scripts/webkitpy/layout_tests/port/mac.py:
2581         (MacPort.baseline_path):
2582         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2583         (MacTest.assert_skipped_file_search_paths):
2584         (MacTest.test_skipped_file_search_paths):
2585         (_assert_search_path):
2586         (test_baseline_search_path):
2587         * Scripts/webkitpy/layout_tests/port/webkit.py:
2588         (WebKitPort._skipped_file_search_paths):
2589
2590 2012-03-13  Jer Noble  <jer.noble@apple.com>
2591
2592         Lion Intel Debug WebKit2 Tests crashing under [WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]
2593         https://bugs.webkit.org/show_bug.cgi?id=81056
2594
2595         Reviewed by Jessie Berlin.
2596
2597         Intercept beganEnterFullScreen and beganExitFullScreen and turn them into no-ops (plus logging).
2598
2599         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2600         (WTR::InjectedBundlePage::InjectedBundlePage):
2601         (WTR::InjectedBundlePage::beganEnterFullScreen):
2602         (WTR::InjectedBundlePage::beganExitFullScreen):
2603
2604 2012-03-14  Alexander Færøy  <alexander.faeroy@nokia.com>
2605
2606         The width and height of the scroll indicators in the MiniBrowser does
2607         not consider the offset margins.
2608         https://bugs.webkit.org/show_bug.cgi?id=81112
2609
2610         Reviewed by Kenneth Rohde Christiansen.
2611
2612         This patch fixes the issue by withdrawing two times the anchor
2613         margins.
2614
2615         * MiniBrowser/qt/qml/ScrollIndicator.qml:
2616
2617 2012-03-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2618
2619         [EFL] Implement LayoutTestController::clearBackForwardList
2620         https://bugs.webkit.org/show_bug.cgi?id=80142
2621
2622         Adding missing implementation clearBackForwardList to EFL's
2623         LayoutTestController. This implementation allows us to unskip
2624         tests connected with history.
2625
2626         Reviewed by Antonio Gomes.
2627
2628         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2629         (LayoutTestController::clearBackForwardList): Implemented.
2630
2631 2012-03-13  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2632
2633         [EFL][DRT] Expose window.internals object
2634         https://bugs.webkit.org/show_bug.cgi?id=79900
2635
2636         Exposes window.internals for EFL's DRT. Makes possible to
2637         remove some tests from the skip list.
2638
2639         Reviewed by Antonio Gomes.
2640
2641         * DumpRenderTree/efl/CMakeLists.txt:
2642         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2643         (DumpRenderTreeChrome::onWindowObjectCleared):
2644
2645 2012-03-13  Adam Barth  <abarth@webkit.org> && Benjamin Poulain  <bpoulain@apple.com>
2646
2647         Always enable ENABLE(CLIENT_BASED_GEOLOCATION)
2648         https://bugs.webkit.org/show_bug.cgi?id=78853
2649
2650         Reviewed by Adam Barth.
2651
2652         * Scripts/build-webkit:
2653         * qmake/mkspecs/features/features.prf:
2654
2655 2012-03-12  Antonio Gomes  <agomes@rim.com>
2656
2657         Convert nodesFromRect tests to use Internals interface
2658         https://bugs.webkit.org/show_bug.cgi?id=80886
2659
2660         Reviewed by Ryosuke Niwa.
2661
2662         This clean up allows to remove port specific bits of each
2663         DRT implementation that supports testing Document::nodesFromRect,
2664         in favor of making use of the 'Internals' interface to test it.
2665
2666         This makes its code conveniently more expansible and cleaner.
2667
2668         Also removed stubs from Win and EFL DRTs.
2669
2670         * DumpRenderTree/LayoutTestController.cpp:
2671         (LayoutTestController::staticFunctions):
2672         * DumpRenderTree/LayoutTestController.h:
2673         (LayoutTestController):
2674         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2675         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2676         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2677         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2678         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2679         (LayoutTestController):
2680         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2681
2682 2012-03-13  Ojan Vafai  <ojan@chromium.org>
2683
2684         Rebaselining for a new port doesn't work right with multiple fallback ports
2685         https://bugs.webkit.org/show_bug.cgi?id=80932
2686
2687         Reviewed by Adam Barth.
2688
2689         Since chromium-leopard also falls back to mac-leopard, we need to
2690         copy the existing result for both chromium-leopard and chromium-snowleopard
2691         before doing lion rebaselines.
2692
2693         * Scripts/webkitpy/layout_tests/port/builders.py:
2694         (fallback_port_names_for_new_port):
2695         * Scripts/webkitpy/tool/commands/rebaseline.py:
2696         (RebaselineTest):
2697         (RebaselineTest._copy_existing_baseline):
2698         (RebaselineTest._rebaseline_test):
2699         (RebaselineTest.execute):
2700         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2701         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2702         (GardeningHTTPRequestHandler.rebaseline):
2703         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2704         (GardeningServerTest.test_rebaseline_new_port):
2705
2706 2012-03-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2707
2708         [Qt] Tweak minibrowser UI
2709
2710         Add some margins to the scroll indicators, and set a dark background
2711         color so you see the page dimensions.
2712
2713         Reviewed by Antonio Gomes.
2714
2715         * MiniBrowser/qt/qml/BrowserWindow.qml:
2716         * MiniBrowser/qt/qml/ScrollIndicator.qml:
2717
2718 2012-03-13  ChangSeok Oh  <shivamidow@gmail.com>
2719
2720         [EFL] [DRT] Implement scheduleAsynchronousKeyDown.
2721         https://bugs.webkit.org/show_bug.cgi?id=79601
2722
2723         Reviewed by Gustavo Noronha Silva.
2724
2725         Extracted shareable code from keyDownCallback and then added createKeyEventInfo.
2726         createKeyEventInfo creates a new structure KeyEventInfo that has keyName and modifiers
2727         and is taken over to sendKeyDown.
2728         Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly
2729         and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown.
2730
2731         * DumpRenderTree/efl/EventSender.cpp:
2732         (KeyEventInfo::KeyEventInfo):
2733         (KeyEventInfo):
2734         (createKeyEventInfo):
2735         (sendKeyDown):
2736         (keyDownCallback):
2737         (sendAsynchronousKeyDown):
2738         (scheduleAsynchronousKeyDownCallback):
2739
2740 2012-03-12  Ojan Vafai  <ojan@chromium.org>
2741
2742         webkit-patch optimize-baselines sometimes creates a mac-future result
2743         https://bugs.webkit.org/show_bug.cgi?id=80717
2744
2745         Reviewed by Adam Barth.
2746
2747         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
2748         (_baseline_search_hypergraph):
2749         (BaselineOptimizer._find_optimal_result_placement):
2750         (BaselineOptimizer._filter_virtual_ports):
2751         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
2752         (BaselineOptimizerTest.test_no_add_mac_future):
2753
2754 2012-03-12  Jessie Berlin  <jberlin@apple.com>
2755
2756         More Windows build fixing.
2757
2758         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2759
2760 2012-03-12  Jessie Berlin  <jberlin@apple.com>
2761
2762         More Windows build fixing.
2763
2764         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2765         * DumpRenderTree/win/EditingDelegate.cpp:
2766         * DumpRenderTree/win/EventSender.cpp:
2767         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2768         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2769         * DumpRenderTree/win/UIDelegate.cpp:
2770
2771 2012-03-12  Dirk Pranke  <dpranke@chromium.org>
2772
2773         remove the 'gpu' group from the flakiness dashboard
2774         https://bugs.webkit.org/show_bug.cgi?id=80353
2775
2776         Reviewed by Adam Barth.
2777
2778         Since those bots are obsolete, we don't need this any more.
2779
2780         * TestResultServer/static-dashboards/builders.js:
2781         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2782         (testPlatformAndBuildType):
2783         (testHtmlForTestTypeSwitcherGroup):
2784
2785 2012-03-12  Dirk Pranke  <dpranke@chromium.org>
2786
2787         remove graphics_type from webkitpy.layout_tests.models.test_configuration
2788         https://bugs.webkit.org/show_bug.cgi?id=80643
2789
2790         Reviewed by Ojan Vafai.
2791
2792         Now that the chromium-gpu ports are gone, there's no need for
2793         the graphics_type CPU/GPU distinction. Most of this change is
2794         just updating tests accordingly.
2795
2796         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
2797         (TestExpectationEditorTests):
2798         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
2799         (TestConfiguration.__init__):
2800         (TestConfiguration.category_order):
2801         (TestConfiguration.__str__):
2802         (TestConfiguration.__repr__):
2803         (TestConfiguration.__hash__):
2804         (TestConfigurationConverter.to_specifiers_list):
2805         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
2806         (make_mock_all_test_configurations_set):
2807         (TestConfigurationTest.test_items):
2808         (TestConfigurationTest.test_keys):
2809         (TestConfigurationTest.test_str):
2810         (TestConfigurationTest.test_repr):
2811         (TestConfigurationTest.test_hash):
2812         (TestConfigurationTest.test_hash.query_unknown_key):
2813         (TestConfigurationTest.test_eq):
2814         (TestConfigurationTest.test_values):
2815         (SpecifierSorterTest.test_specifier_priority):
2816         (SpecifierSorterTest.test_sort_specifiers):
2817         (TestConfigurationConverterTest.test_to_config_set):
2818         (TestConfigurationConverterTest.test_macro_expansion):
2819         (TestConfigurationConverterTest.test_to_specifier_lists):
2820         (TestConfigurationConverterTest.test_converter_macro_collapsing):
2821         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2822         (test_error_on_different_build_type):
2823         (TestExpectationSerializerTests.test_parsed_to_string):
2824         (TestExpectationSerializerTests.test_reconstitute_only_these):
2825         * Scripts/webkitpy/layout_tests/port/apple.py:
2826         (ApplePort._generate_all_test_configurations):
2827         * Scripts/webkitpy/layout_tests/port/base.py:
2828         (Port.__init__):
2829         (Port.name):
2830         (Port.version):
2831         (Port.test_configuration):
2832         * Scripts/webkitpy/layout_tests/port/builders.py:
2833         * Scripts/webkitpy/layout_tests/port/chromium.py:
2834         (ChromiumPort):
2835         (ChromiumPort._generate_all_test_configurations):
2836         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2837         (ChromiumLinuxPort.__init__):
2838         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2839         (ChromiumLinuxPortTest.test_check_illegal_port_names):
2840         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2841         (ChromiumMacPortTest.test_baseline_path):
2842         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2843         (ChromiumPortTest.test_all_test_configurations):
2844         * Scripts/webkitpy/layout_tests/port/efl.py:
2845         (EflPort._generate_all_test_configurations):
2846         * Scripts/webkitpy/layout_tests/port/gtk.py:
2847         (GtkPort._generate_all_test_configurations):
2848         * Scripts/webkitpy/layout_tests/port/qt.py:
2849         (QtPort._generate_all_test_configurations):
2850         * Scripts/webkitpy/layout_tests/port/test.py:
2851         (TestPort.all_test_configurations):
2852         (TestPort._all_build_types):
2853         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2854         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2855         (BuildCoverageExtrapolatorTest.test_extrapolate):
2856         (GardeningExpectationsUpdaterTest.test_unknown_failure_type):
2857         (GardeningExpectationsUpdaterTest.test_add_new_expectation):
2858         (GardeningExpectationsUpdaterTest.test_replace_old_expectation):
2859         (GardeningExpectationsUpdaterTest.test_pass_expectation):
2860         (GardeningExpectationsUpdaterTest.test_supplement_old_expectation):
2861         (GardeningExpectationsUpdaterTest.test_spurious_updates):
2862
2863 2012-03-12  Dirk Pranke  <dpranke@chromium.org>
2864
2865         _runtime_feature_list isn't supported on Apple Mac DRT
2866         https://bugs.webkit.org/show_bug.cgi?id=80906
2867
2868         Reviewed by Eric Seidel.
2869
2870         It looks like this feature is actually only supported on the Win
2871         DRT port, so this patch reworks the code to make that clearer
2872         and reduce unnecessary overrides.
2873
2874         * Scripts/webkitpy/layout_tests/port/efl.py:
2875         (EflPort._path_to_webcore_library):
2876         * Scripts/webkitpy/layout_tests/port/gtk.py:
2877         (GtkPort._path_to_webcore_library):
2878         * Scripts/webkitpy/layout_tests/port/qt.py:
2879         (QtPort._skipped_file_search_paths):
2880         * Scripts/webkitpy/layout_tests/port/webkit.py:
2881         (WebKitPort._runtime_feature_list):
2882         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2883         (TestWebKitPort.__init__):
2884         (TestWebKitPort.all_test_configurations):
2885         (test_skipped_directories_for_features):
2886         * Scripts/webkitpy/layout_tests/port/win.py:
2887         (WinPort):
2888         (WinPort._runtime_feature_list):
2889         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2890         (WinPortTest.test_operating_system):
2891         (WinPortTest):
2892         (WinPortTest.test_runtime_feature_list):
2893
2894 2012-03-12  Peter Beverloo  <peter@chromium.org>
2895
2896         [Chromium] Temporary build-fix for the Android bot
2897         https://bugs.webkit.org/show_bug.cgi?id=80862
2898
2899         Reviewed by Adam Barth.
2900
2901         Manually set the environmental variables required to compile source
2902         files through the Android NDK instead of relying on the envsetup.sh
2903         script. A proper fix will be landed to Chromium ASAP, and following
2904         a Chromium roll into WebKit this code will be removed.
2905
2906         * Scripts/webkitdirs.pm:
2907         (buildChromiumMakefile):
2908
2909 2012-03-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2910
2911         [Qt] Use right construct to detect config_test_gccdepends
2912
2913         Reviewed by Andreas Kling.
2914
2915         * qmake/mkspecs/features/default_pre.prf:
2916
2917 2012-03-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2918
2919         [Qt] Expose location of WebKit's bin and imports dir through module file
2920
2921         Reviewed by Andreas Kling.
2922
2923         * qmake/qt_webkit.pri:
2924
2925 2012-03-12  Andras Becsi  <andras.becsi@nokia.com>
2926
2927         [Qt][WK2] Add support for rudimentary scroll indicators in MiniBrowser
2928         https://bugs.webkit.org/show_bug.cgi?id=80832
2929
2930         Reviewed by Tor Arne Vestbø.
2931
2932         Add a basic scroll indicator component to MiniBrowser so that it
2933         behaves similar to the ScrollDecorator QML component.
2934
2935         * MiniBrowser/qt/MiniBrowser.qrc:
2936         * MiniBrowser/qt/qml/BrowserWindow.qml:
2937         * MiniBrowser/qt/qml/ScrollIndicator.qml: Added.
2938
2939 2012-03-12  C Anthony Risinger  <anthony@xtfx.me>
2940
2941         [GTK] r110296 included an extra $ in @$(AM_V_GEN)
2942         https://bugs.webkit.org/show_bug.cgi?id=80809
2943
2944         Reviewed by Philippe Normand.
2945
2946         * GNUmakefile.am: Add `$` to @(AM_V_GEN), else /bin/sh syntax error
2947
2948 2012-03-12  Ming Xie  <mxie@rim.com>
2949
2950         [BlackBerry] build-webkit doesn't recognize "--cmakearg" for the BlackBerry port
2951         https://bugs.webkit.org/show_bug.cgi?id=80812
2952
2953         Reviewed by Rob Buis.
2954
2955         * Scripts/build-webkit: Add $cmakeArgs to buildCMakeProjectOrExit()
2956         * Scripts/webkitdirs.pm:
2957         (blackberryCMakeArguments): Remove "PUBLIC_BUILD=0" define
2958
2959
2960 2012-03-12  Simon Hausmann  <simon.hausmann@nokia.com>
2961
2962         [Qt] Fix build with newer Qt 5.
2963
2964         Reviewed by Tor Arne Vestbø.
2965
2966         Newer Qt 5 renames QDeclarativeFoo to QQmlFoo and provides backwards compatible
2967         renames, which however do trigger a #warning. Until we _require_ a newer Qt 5
2968         we should disable -Werror.
2969
2970         Also load(moc) for the availability of QMAKE_MOC in various derived sources. The
2971         implicit load was removed recently.
2972
2973         * qmake/mkspecs/features/default_pre.prf:
2974         * qmake/mkspecs/features/unix/default_post.prf:
2975
2976 2012-03-11  Maciej Stachowiak  <mjs@apple.com>
2977
2978         Add --instruments option to sunspider to profile with Instruments
2979         https://bugs.webkit.org/show_bug.cgi?id=80783
2980
2981         Reviewed by Filip Pizlo.
2982
2983         * Scripts/run-sunspider:
2984
2985 2012-03-11  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
2986
2987         [Qt] [WK2] Support threaded renderer in WK2
2988         https://bugs.webkit.org/show_bug.cgi?id=76661
2989
2990         Remove disabling of threaded rendering.
2991
2992         Reviewed by Noam Rosenthal.
2993
2994         * MiniBrowser/qt/main.cpp:
2995         (main):
2996
2997 2012-03-09  Zan Dobersek  <zandobersek@gmail.com>
2998
2999         [WK2] run-perf-tests should be able to run with WTR
3000         https://bugs.webkit.org/show_bug.cgi?id=80042
3001
3002         Reviewed by Martin Robinson.
3003
3004         Add an option to PerfTestRunner to use WebKitTestRunner instead of
3005         DumpRenderTree and add the '--no-timeout' flag to WebKitTestRunner
3006         to avoid timing out when running performance tests.
3007
3008         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3009         (PerfTestsRunner._parse_args):
3010         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3011         (WTR::InjectedBundle::InjectedBundle): Initialize m_useWaitToDumpWatchdogTimer
3012         to true.
3013         (WTR::InjectedBundle::didReceiveMessage): Unpack the 'BeginTest' message
3014         as a dictionary containing DumpPixels and UseWaitToDumpWatchdogTimer keys.
3015         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3016         (WTR::InjectedBundle::useWaitToDumpWatchdogTimer): Make m_useWaitToDumpWatchdogTimer
3017         publicly accessible.
3018         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3019         (WTR::LayoutTestController::waitUntilDone): Only initialize the watchdog if it
3020         is required.
3021         * WebKitTestRunner/TestController.cpp:
3022         (WTR::TestController::TestController): Initialize m_useWaitToDumpWatchdogTimer
3023         to true.
3024         (WTR::TestController::initialize): Set m_useWaitToDumpWatchdogTimer to false
3025         if '--no-timeout' option is present.
3026         (WTR::TestController::runUntil): Translate TimeoutDuration to a proper timeout
3027         value, or -1.0 if timeout should not occur.
3028         * WebKitTestRunner/TestController.h:
3029         (WTR::TestController::useWaitToDumpWatchdogTimer): Make m_useWaitToDumpWatchdogTimer
3030         publicly accessible.
3031         * WebKitTestRunner/TestInvocation.cpp:
3032         (WTR::TestInvocation::invoke): Pack the 'BeginTest' message as a dictionary,
3033         containing DumpPixels and UseWaitToDumpWatchdogTimer keys and corresponding values.
3034         Waiting for final message should not time out if not necessary.
3035         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3036         (WTR::TestController::platformRunUntil): Only set up a timeout if necessary.
3037         * WebKitTestRunner/qt/TestControllerQt.cpp:
3038         (WTR::TestController::platformRunUntil): Ditto.
3039         * WebKitTestRunner/mac/TestControllerMac.mm:
3040         (WTR::TestController::platformRunUntil): Add a FIXME, indicating functionality
3041         is missing.
3042         * WebKitTestRunner/win/TestControllerWin.cpp:
3043         (WTR::TestController::platformRunUntil): Ditto.
3044
3045 2012-03-09  Jon Lee  <jonlee@apple.com>
3046
3047         Rename NotificationPresenter to NotificationClient
3048         https://bugs.webkit.org/show_bug.cgi?id=80488
3049         <rdar://problem/10965558>
3050
3051         Reviewed by Kentaro Hara.
3052
3053         Refactor to use renamed WebCore::NotificationClient.
3054         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
3055         (DRTDesktopNotificationPresenter::checkNotificationPermission):
3056
3057 2012-03-07  James Robinson  <jamesr@chromium.org>
3058
3059         [chromium] Deprecate renderDirectlyToWebView parameter of WebViewClient::createGraphicsContext3D()
3060         https://bugs.webkit.org/show_bug.cgi?id=80523
3061
3062         Reviewed by Darin Fisher.
3063
3064         * DumpRenderTree/chromium/WebViewHost.cpp:
3065         (WebViewHost::createGraphicsContext3D):
3066         * DumpRenderTree/chromium/WebViewHost.h:
3067         (WebViewHost):
3068
3069 2012-03-09  Eric Seidel  <eric@webkit.org>
3070
3071         build-webkit should build Source/WTF on Mac
3072         https://bugs.webkit.org/show_bug.cgi?id=80728
3073
3074         Reviewed by Adam Barth.
3075
3076         We'll add other ports to this list in future commits.
3077
3078         * Scripts/build-webkit:
3079
3080 2012-03-09  Jon Lee  <jonlee@apple.com>
3081
3082         Add support for ENABLE(LEGACY_NOTIFICATIONS)
3083         https://bugs.webkit.org/show_bug.cgi?id=80497
3084
3085         Reviewed by Adam Barth.
3086
3087         Prep for b80472: Update API for Web Notifications
3088         * Scripts/build-webkit:
3089         * qmake/mkspecs/features/features.prf:
3090
3091 2012-03-09  Ashod Nakashian  <ashodnakashian@yahoo.com>
3092
3093         Bash scripts should support LF endings only
3094         https://bugs.webkit.org/show_bug.cgi?id=79509
3095
3096         Reviewed by David Kilzer.
3097
3098         * EWSTools/boot.sh: Added properties svn:executable and svn:eol-style.
3099         * EWSTools/start-queue.sh: Added property svn:eol-style.
3100         * Scripts/webkit-tools-completion.sh: Added properties svn:executable and svn:eol-style.
3101         * WebKitTestRunner/win/build-generated-files.sh: Added properties svn:executable and svn:eol-style.
3102         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added property svn:eol-style.
3103         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added property svn:eol-style.
3104
3105 2012-03-09  Ionut Biru  <ibiru@archlinux.org>
3106
3107         [BUILD] use detected python to run generate-gtkdoc
3108         https://bugs.webkit.org/show_bug.cgi?id=80695
3109
3110         Reviewed by Gustavo Noronha Silva.
3111
3112         * GNUmakefile.am: Use $(PYTHON) instead of plain `python`
3113
3114 2012-03-09  Nat Duca  <nduca@chromium.org>
3115
3116         Make check-webkit-style complain about "no new tests" lines in changelogs
3117         https://bugs.webkit.org/show_bug.cgi?id=80582
3118
3119         Reviewed by David Levin.
3120
3121         * Scripts/webkitpy/style/checkers/changelog.py:
3122         (ChangeLogChecker.check_entry):
3123         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
3124         (ChangeLogCheckerTest.test_no_new_tests):
3125
3126 2012-03-09  Sheriff Bot  <webkit.review.bot@gmail.com>
3127
3128         Unreviewed, rolling out r110250.
3129         http://trac.webkit.org/changeset/110250
3130         https://bugs.webkit.org/show_bug.cgi?id=80682
3131
3132         It made NRWT ignore test_expectations.txt on Qt-WK2 and ignore
3133         qt-linux at all. (Requested by Ossy on #webkit).
3134
3135         * Scripts/old-run-webkit-tests:
3136         * Scripts/webkitpy/layout_tests/port/qt.py:
3137         (QtPort):
3138         (QtPort.determine_full_port_name):
3139         (QtPort.baseline_search_path):
3140         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3141         (QtPortTest):
3142         (QtPortTest._assert_search_path):
3143         (QtPortTest.test_baseline_search_path):
3144
3145 2012-03-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3146
3147         [Qt] Use Qt's module system for install rules and depending on QtWebKit
3148
3149         Instead of rolling our own install rules we now use the same approach as
3150         every other Qt module, by loading qt_module.prf and qt_module_config.prf.
3151
3152         This ensures that we follow the same semantics as the rest of Qt on
3153         what sort of config options are enabled by default (create_cmake eg.).
3154         It also allows us to use QT += webkit instead of the workaround we had
3155         with CONFIG += qtwebkit.
3156
3157         We do however force Qt to always treat our build as a non-developer build,
3158         so the libraries will end up in the WebKit lib directory instead of the
3159         qtbase directory (as with a normal developer-build). This allows us to
3160         keep the webkit-build self-contained. If Qt is a developer build we still
3161         copy the module file manually to Qt, so that you don't have to install
3162         WebKit to make it available.
3163
3164         For non-developer builds of Qt, it is still possible to use the built
3165         WebKit libraries without having to install them, by having the variable
3166         QMAKE_EXTRA_MODULE_FORWARDS set in the project's .qmake.cache file,
3167         pointing to $WEBKITOUTUTDIR/$CONFIGURATION/modules.
3168
3169         https://bugs.webkit.org/show_bug.cgi?id=80590
3170
3171         Reviewed by Simon Hausmann.
3172
3173         * DumpRenderTree/qt/DumpRenderTree.pro:
3174         * MiniBrowser/qt/BrowserWindow.cpp:
3175         * MiniBrowser/qt/MiniBrowser.pro:
3176         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3177         * MiniBrowser/qt/UrlLoader.cpp:
3178         * QtTestBrowser/QtTestBrowser.pro:
3179         * Tools.pro:
3180         * WebKitTestRunner/InjectedBundle/Target.pri:
3181         * WebKitTestRunner/Target.pri:
3182         * qmake/mkspecs/features/default_post.prf:
3183         * qmake/mkspecs/features/default_pre.prf:
3184         * qmake/mkspecs/features/functions.prf:
3185         * qmake/mkspecs/features/qtwebkit-private.prf: Removed.
3186         * qmake/mkspecs/features/qtwebkit.prf:
3187         * qmake/mkspecs/features/rpath.prf:
3188         * qmake/mkspecs/modules/qt_webkit.pri: Removed.
3189         * qmake/qt_webkit.pri: Added.
3190
3191 2012-03-08  Igor Oliveira  <igor.o@sisa.samsung.com>
3192
3193         Unreviewed. Update my email.
3194
3195         * Scripts/webkitpy/common/config/committers.py:
3196
3197 2012-03-08  Xianzhu Wang  <wangxianzhu@chromium.org>
3198
3199         Recent changes to chromium.py etc. broke chromium_android.py
3200         https://bugs.webkit.org/show_bug.cgi?id=80623
3201
3202         Reviewed by Dirk Pranke.
3203
3204         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3205         (ChromiumAndroidDriver.__init__):
3206         (ChromiumAndroidDriver._start):
3207
3208 2012-03-08  Xianzhu Wang  <wangxianzhu@chromium.org>
3209
3210         [Chromium] Exception running reftest with --no-pixel-tests
3211         https://bugs.webkit.org/show_bug.cgi?id=80642
3212
3213         Reviewed by Dirk Pranke.
3214
3215         * Scripts/webkitpy/layout_tests/port/chromium.py:
3216         (ChromiumDriver.__init__):
3217         (ChromiumDriver._wrapper_options):
3218
3219 2012-03-08  Rafael Brandao  <rafael.lobo@openbossa.org>
3220
3221         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
3222         https://bugs.webkit.org/show_bug.cgi?id=72489
3223
3224         Reviewed by Dirk Pranke.
3225
3226         NRWT: The default platform name for Qt combined with --webkit-test-runner is now
3227         "qt-5.0-wk2" instead of "qt-linux" and that name is now prefered for tests.
3228         --platform will override the platform name and then we'll use it.
3229
3230         ORWT: We check for qt version and use platform name "qt-4.8" if the version is lower
3231         than 5.0.0, and then we choose between "qt-5.0-wk1" and "qt-5.0-wk2". --platform will
3232         override it in the end.
3233
3234         * Scripts/old-run-webkit-tests:
3235         * Scripts/webkitpy/layout_tests/port/qt.py:
3236         (QtPort):
3237         (QtPort.determine_full_port_name):
3238         (QtPort.baseline_search_path):
3239         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3240         (QtPortTest):
3241         (QtPortTest._assert_search_path):
3242         (QtPortTest.test_baseline_search_path):
3243
3244 2012-03-08  Beth Dakin  <bdakin@apple.com>
3245
3246         https://bugs.webkit.org/show_bug.cgi?id=80463
3247         RenderImage is using the wrong origin when calling addRelevantRepaintedObject
3248         -and corresponding-
3249         <rdar://problem/10970221>
3250
3251         Reviewed by Dan Bernstein.
3252
3253         New test!
3254         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3255         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp: Added.
3256         (TestWebKitAPI):
3257         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
3258         (TestWebKitAPI::setPageLoaderClient):
3259         (TestWebKitAPI::TEST):
3260         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp: Added.
3261         (TestWebKitAPI):
3262         (NewFirstVisuallyNonEmptyLayoutForImagesTest):
3263         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::NewFirstVisuallyNonEmptyLayoutForImagesTest):
3264         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::didCreatePage):
3265         * TestWebKitAPI/Tests/WebKit2/lots-of-images.html: Added.
3266
3267 2012-03-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3268
3269         [Qt] Prospective Windows build fix
3270
3271         Don't assume that windows-builds will always run inside a cmd.exe shell.
3272
3273         * qmake/mkspecs/features/default_pre.prf:
3274
3275 2012-03-08  Dan Bernstein  <mitz@apple.com>
3276
3277         <rdar://problem/10981173> Dashboard regions should not be in device space
3278
3279         Reviewed by John Sullivan.
3280
3281         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3282         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm: Added.
3283         (-[DeviceScaleFactorInDashboardRegionsUIDelegate webView:dashboardRegionsChanged:]):
3284         (TestWebKitAPI):
3285         (TestWebKitAPI::TEST):
3286
3287 2012-03-08  Dirk Pranke  <dpranke@chromium.org>
3288
3289         webkit-patch works oddly on local Git branches
3290         https://bugs.webkit.org/show_bug.cgi?id=76958
3291
3292         Reviewed by Ojan Vafai.
3293
3294         This change makes the '-g' flag to webkit-patch behave a
3295         little more consistently with git. The 'HEAD..' syntax
3296         is changed to 'HEAD....' (four dots), so as to not
3297         collide with the underlying git syntax. We also generalize
3298         the syntax to support any refname, so 'foo....' means
3299         diff against foo and include working copy changes.
3300
3301         This change also adds the 'UPSTREAM' shortcut to identify
3302         whatever the current upstream/tracking branch is; this is
3303         useful if you have multiple local branches stacked up.
3304
3305         * Scripts/webkitpy/common/checkout/scm/git.py:
3306         (Git._branch_from_ref):
3307         (Git):
3308         (Git._current_branch):
3309         (Git._upstream_branch):
3310         (Git.merge_base):
3311         (Git._commit_on_branch):
3312         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3313         (GitSVNTest._second_local_commit):
3314         (GitSVNTest._two_local_commits):
3315         (GitSVNTest.test_commit_with_message_git_commit_range):
3316         (GitSVNTest.test_upstream_branch):
3317         (GitSVNTest.test_create_patch_working_copy_only):
3318         (GitSVNTest.test_changed_files_local_plus_working_copy):
3319         (GitSVNTest.test_changed_files_working_copy_only):
3320         (GitSVNTest.test_changed_files_upstream):
3321         * Scripts/webkitpy/tool/steps/options.py:
3322         (Options):
3323
3324 2012-03-08  John Sullivan  <sullivan@apple.com>
3325
3326         Made extract-localizable-strings ignore NSLocalizedFileSizeDescription
3327
3328         Reviewed by Eric Carlson.
3329
3330         * Scripts/extract-localizable-strings:
3331         Added NSLocalizedFileSizeDescription to allowed list of tokens that start
3332         with NSLocalized. Also improved an error message to include the troublesome token.
3333
3334 2012-03-08  Sheriff Bot  <webkit.review.bot@gmail.com>
3335
3336         Unreviewed, rolling out r110115.
3337         http://trac.webkit.org/changeset/110115
3338         https://bugs.webkit.org/show_bug.cgi?id=80581
3339
3340         broke test-webkitpy (Requested by philn-tp on #webkit).
3341
3342         * Scripts/old-run-webkit-tests:
3343         * Scripts/webkitpy/layout_tests/port/qt.py:
3344         (QtPort):
3345         (QtPort.determine_full_port_name):
3346         (QtPort.baseline_search_path):
3347
3348 2012-03-08  Kentaro Hara  <haraken@chromium.org>
3349
3350         Unreviewed. Added myself to watchlist.
3351
3352         * Scripts/webkitpy/common/config/watchlist:
3353
3354 2012-03-07  Jessie Berlin  <jberlin@apple.com>
3355
3356         Clean Windows build fails after r110033
3357         https://bugs.webkit.org/show_bug.cgi?id=80553
3358
3359         Rubber-stamped by Jon Honeycutt and Eric Seidel.
3360
3361         Add the new JavaScriptCore include directory to some more vsprops files.
3362
3363         * DumpRenderTree/win/ImageDiffCommon.vsprops:
3364         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
3365         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
3366
3367 2012-03-07  Rafael Brandao  <rafael.lobo@openbossa.org>
3368
3369         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
3370         https://bugs.webkit.org/show_bug.cgi?id=72489
3371
3372         Reviewed by Dirk Pranke.
3373
3374         NRWT: The default platform name for Qt combined with --webkit-test-runner is now
3375         "qt-5.0-wk2" instead of "qt-linux" and that name is now prefered for tests.
3376         --platform will override the platform name and then we'll use it.
3377
3378         ORWT: We check for qt version and use platform name "qt-4.8" if the version is lower
3379         than 5.0.0, and then we choose between "qt-5.0-wk1" and "qt-5.0-wk2". --platform will
3380         override it in the end.
3381
3382         * Scripts/old-run-webkit-tests:
3383         * Scripts/webkitpy/layout_tests/port/qt.py:
3384         (QtPort):
3385         (QtPort.determine_full_port_name):
3386         (QtPort.baseline_search_path):
3387
3388 2012-03-07  Hugo Parente Lima  <hugo.lima@openbossa.org>
3389
3390         [Qt][WK2] MiniBrowser on desktop does not react to click events
3391         https://bugs.webkit.org/show_bug.cgi?id=80314
3392
3393         Reviewed by Kenneth Rohde Christiansen.
3394
3395         Do not enable touch mocking on desktop mode.
3396
3397         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3398         (MiniBrowserApplication::handleUserOptions):
3399
3400 2012-03-07  Ojan Vafai  <ojan@chromium.org>
3401
3402         Automatically move to the next test after rebaseline in the results view
3403         https://bugs.webkit.org/show_bug.cgi?id=80527
3404
3405         Reviewed by Dimitri Glazkov.
3406
3407         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3408         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3409
3410 2012-03-07  Ojan Vafai  <ojan@chromium.org>
3411
3412         garden-o-matic rebaseline is broken for ports that don't have a fallback port
3413         https://bugs.webkit.org/show_bug.cgi?id=80526
3414
3415         Reviewed by Adam Barth.
3416
3417         Passing "None" as the fallback port throws an error in "webkit-patch rebaseline-test"
3418         since there is no "None" port.
3419
3420         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3421         (GardeningHTTPRequestHandler.rebaseline):
3422         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3423         (GardeningServerTest.test_rebaseline):
3424
3425 2012-03-07  James Robinson  <jamesr@chromium.org>
3426
3427         [chromium] Remove the TestWebPlugin's use of implicit FBO for offscreen contexts
3428         https://bugs.webkit.org/show_bug.cgi?id=80521
3429
3430         Reviewed by Kenneth Russell.
3431
3432         Switches TestWebPlugin from using a context created by WebViewClient::createGraphicsContext3D(..., false) over
3433         to an explicitly offscreen context with explicitly managed texture / FBO, so we can deprecate the
3434         renderDirectlyToHostWindow flag from WebViewClient::createGraphicsContext3D.
3435
3436         Covered by platform/chromium/compositing/plugins/*
3437
3438         * DumpRenderTree/chromium/TestWebPlugin.cpp:
3439         (TestWebPlugin::TestWebPlugin):
3440         (TestWebPlugin::initialize):
3441         (TestWebPlugin::updateGeometry):
3442         (TestWebPlugin::initScene):
3443         (TestWebPlugin::destroyScene):
3444         * DumpRenderTree/chromium/TestWebPlugin.h:
3445         (TestWebPlugin):
3446         * DumpRenderTree/chromium/WebViewHost.cpp:
3447         (WebViewHost::createPlugin):
3448
3449 2012-03-07  Philippe Normand  <pnormand@igalia.com>
3450
3451         [GTK] remove webkitpy dependency in run-gtk-tests
3452         https://bugs.webkit.org/show_bug.cgi?id=80500
3453
3454         Reviewed by Martin Robinson.
3455
3456         Replace Executive calls with bare subprocess calls.
3457
3458         * Scripts/run-gtk-tests:
3459         (TestRunner):
3460         (TestRunner._lookup_atspi2_binary):
3461         (TestRunner.run):
3462         (TestRunner.run.run_for_real):
3463
3464 2012-03-07  Philippe Normand  <pnormand@igalia.com>
3465
3466         Unreviewed, GTK build fix after r110059.
3467
3468         * Scripts/run-gtk-tests:
3469         (TestRunner._check_if_tests_have_timed_out):
3470         (TestRunner.run.run_tests):
3471         (TestRunner):
3472
3473 2012-03-07  Philippe Normand  <pnormand@igalia.com>
3474
3475         [GTK] race condition in run-gtk-tests
3476         https://bugs.webkit.org/show_bug.cgi?id=80495
3477
3478         Reviewed by Martin Robinson.
3479
3480         Refactored the script to wait the a11y dbus service becomes
3481         available before starting the tests.
3482
3483         * Scripts/run-gtk-tests:
3484         (TestRunner._lookup_atspi2_binary):
3485         (TestRunner):
3486         (TestRunner._wait_dbus_service_and_run):
3487         (TestRunner._wait_dbus_service_and_run.on_name_appeared):
3488         (TestRunner._wait_dbus_service_and_run.on_name_vanished):
3489         (TestRunner.run):
3490         (TestRunner.run.bailout):
3491         (TestRunner.run.run_for_real):
3492
3493 2012-03-07  Dinu Jacob  <dinu.jacob@nokia.com>
3494
3495         [Qt] REGRESSION(r109575) Broke tap-to-zoom gesture
3496         https://bugs.webkit.org/show_bug.cgi?id=80425
3497
3498         Reviewed by Simon Hausmann.
3499
3500         Set startScreenPos in mock touch point
3501
3502         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3503         (MiniBrowserApplication::notify):
3504         * MiniBrowser/qt/MiniBrowserApplication.h:
3505         (MiniBrowserApplication):
3506
3507 2012-03-07  Simon Hausmann  <simon.hausmann@nokia.com>
3508
3509         [Qt] Windows build fix.
3510
3511         Reviewed by Tor Arne Vestbø.
3512
3513         Pass the -j parameter only to "make", not "nmake".
3514
3515         * Scripts/webkitdirs.pm:
3516         (buildQMakeProjects):
3517
3518 2012-03-07  Simon Hausmann  <simon.hausmann@nokia.com>
3519
3520         [Qt] Fix compilation without QtQuick1
3521         https://bugs.webkit.org/show_bug.cgi?id=80503
3522
3523         Reviewed by Tor Arne Vestbø.
3524
3525         Introduce HAVE_QQUICK1 as feature and added haveQtModule
3526         as convenience function.
3527
3528         * qmake/mkspecs/features/features.prf:
3529         * qmake/mkspecs/features/functions.prf:
3530
3531 2012-03-07  Zoltan Horvath  <zoltan@webkit.org>
3532
3533         [Qt] Add qmake config tests for JPEG and PNG library
3534         https://bugs.webkit.org/show_bug.cgi?id=80398
3535
3536         Add JPEG and PNG library tests to config.tests and
3537         add error() abort to WebCore.pri if tests don't work.
3538
3539         Reviewed by Tor Arne Vestbø.
3540
3541         * qmake/config.tests/libjpeg/libjpeg.cpp: Added.
3542         (main):
3543         * qmake/config.tests/libjpeg/libjpeg.pro: Added.
3544         * qmake/config.tests/libpng/libpng.cpp: Added.
3545         (main):
3546         * qmake/config.tests/libpng/libpng.pro: Added.
3547         * qmake/sync.profile:
3548
3549 2012-03-07  Byungwoo Lee  <bw80.lee@samsung.com>
3550
3551         [EFL] Build warning: Fix warn_unused_result warnings.
3552         https://bugs.webkit.org/show_bug.cgi?id=79194
3553
3554         Reviewed by Filip Pizlo.
3555
3556         Fixed build warning which is getting generated when not using return
3557         value of a fuction, especially declared with warn_unused_result
3558         attribute.
3559
3560         * DumpRenderTree/efl/ImageDiff.cpp:
3561         (printImage):
3562
3563 2012-03-07  Kangil Han  <kangil.han@samsung.com>
3564
3565         [DRT] Remove PlainTextController implementations.
3566         https://bugs.webkit.org/show_bug.cgi?id=79959
3567
3568         Reviewed by Hajime Morita.
3569
3570         PlainTextController usages in existing tests have been
3571         replaced by internals API by bug 78570.
3572         So this patch will remove PlainTextController implementations
3573         to avoid further usage in new tests.
3574
3575         * DumpRenderTree/DumpRenderTree.gypi:
3576         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3577         * DumpRenderTree/chromium/PlainTextController.cpp: Removed.
3578         * DumpRenderTree/chromium/PlainTextController.h: Removed.
3579         * DumpRenderTree/chromium/TestShell.cpp:
3580         (TestShell::TestShell):
3581         (TestShell::bindJSObjectsToWindow):
3582         * DumpRenderTree/chromium/TestShell.h:
3583         (TestShell):
3584         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3585         (webViewWindowObjectCleared):
3586         * DumpRenderTree/gtk/PlainTextController.cpp: Removed.
3587         * DumpRenderTree/gtk/PlainTextController.h: Removed.
3588         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3589         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
3590         * DumpRenderTree/mac/PlainTextController.h: Removed.
3591         * DumpRenderTree/mac/PlainTextController.mm: Removed.
3592         * DumpRenderTree/qt/DumpRenderTree.pro:
3593         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3594         (WebCore::DumpRenderTree::DumpRenderTree):
3595         (WebCore::DumpRenderTree::initJSObjects):
3596         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3597         (DumpRenderTree):
3598         * DumpRenderTree/qt/PlainTextControllerQt.cpp: Removed.
3599         * DumpRenderTree/qt/PlainTextControllerQt.h: Removed.
3600         * GNUmakefile.am:
3601
3602 2012-03-06  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
3603
3604         [EFL][DRT] Implements LayoutTestController's setPopupBlockingEnabled.
3605         https://bugs.webkit.org/show_bug.cgi?id=80137
3606
3607         Reviewed by Eric Seidel.
3608
3609         Adds implementation LayoutTestController's setPopupBlockingEnabled.
3610         To pass popup-blocking-click-in-iframe.html EventSender should not
3611         repeat click events in idler's function. EventSender allows to
3612         asynchronously send click event through ecore_idler_add.
3613         This event will be called repeatedly as long as it return true.
3614         Click event should be called only once by returning ECORE_CALLBACK_CANCEL.
3615
3616         * DumpRenderTree/efl/EventSender.cpp:
3617         (sendMouseEvent): Changed return value from bool to void because it always returns true.
3618         (sendClick): Idler is deleted by returning ECORE_CALLBACK_CANCEL.
3619         (mouseDownCallback): Remove unnecessary checking of return value.
3620         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3621         (LayoutTestController::setPopupBlockingEnabled):
3622
3623 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
3624
3625         rebaseline_chromium_webkit_tests is obsolete and should be removed
3626         https://bugs.webkit.org/show_bug.cgi?id=80347
3627
3628         Reviewed by Tony Chang.
3629
3630         * Scripts/rebaseline-chromium-webkit-tests: Removed.
3631         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py: Removed.
3632         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py: Removed.
3633
3634 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
3635
3636         test_start_cmd (webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer) is broken
3637         https://bugs.webkit.org/show_bug.cgi?id=80468
3638
3639         Unreviewed, build fix.
3640
3641         Fixing a bug revealed by r80443 when we fixed filesystem.copyfile().
3642
3643         * Scripts/webkitpy/layout_tests/servers/http_server.py:
3644         (Lighttpd._prepare_config):
3645
3646 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
3647
3648         remove chromium_gpu ports
3649         https://bugs.webkit.org/show_bug.cgi?id=80345
3650
3651         Reviewed by Ojan Vafai.
3652
3653         This change leaves in the 'graphics_type' distinction in the
3654         test_expectations; removing that will require more updates and a
3655         pass over test_expectations.txt, so I'm separating that out.
3656
3657         * Scripts/webkitpy/layout_tests/port/builders.py:
3658         * Scripts/webkitpy/layout_tests/port/chromium.py:
3659         (ChromiumPort):
3660         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: Removed.
3661         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py: Removed.
3662         * Scripts/webkitpy/layout_tests/port/factory.py:
3663         (PortFactory):
3664         (PortFactory.get):
3665         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3666         (FactoryTest.test_qt):
3667         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3668         (TestRebaseline.test_rebaseline_expectations):
3669
3670 2012-03-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
3671
3672         undefined reference to JSC::IdentifierTable::~IdentifierTable() on EFL port
3673         https://bugs.webkit.org/show_bug.cgi?id=80282
3674
3675         Reviewed by Antonio Gomes.
3676
3677         Remove transitive library dependencies; they are especially
3678         dangerous when one ends up linking against WTF, JSC and then WTF
3679         again, since some symbols will not be defined.
3680
3681         Passing --no-copy-dt-needed-entries and --as-needed to the linker
3682         (which some recent Linux distros do by default) makes the issue
3683         even more evident.
3684
3685         * DumpRenderTree/efl/CMakeLists.txt: Do not link directly to WTF,
3686         as the other libraries have the needed symbols. Explicitly link
3687         against fontconfig.
3688
3689 2012-03-06  Dean Jackson  <dino@apple.com>
3690
3691         filter-build-webkit needs more filters
3692         https://bugs.webkit.org/show_bug.cgi?id=80440
3693
3694         Reviewed by Joseph Pecoraro.
3695
3696         Added as many missing filters as I could find for Apple
3697         builds. Plus a few minor style updates.
3698
3699         * Scripts/filter-build-webkit:
3700         (printLine):
3701
3702 2012-03-06  Ojan Vafai  <ojan@chromium.org>
3703
3704         Copying old baselines throws an error if the new directory doesn't exist
3705         https://bugs.webkit.org/show_bug.cgi?id=80443
3706
3707         Reviewed by Adam Barth.
3708
3709         Existing tests cover the new code with the fix to filesystem_mock.
3710
3711         * Scripts/webkitpy/common/system/filesystem_mock.py:
3712         (MockFileSystem.copyfile):
3713         Fix the mock to better match python's copyfile semantics.
3714
3715         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3716         (Rebaseliner._create_html_baseline_files):
3717         * Scripts/webkitpy/tool/commands/rebaseline.py:
3718         (RebaselineTest._copy_existing_baseline):
3719
3720 2012-03-05  Ojan Vafai  <ojan@chromium.org>
3721
3722         Add a mechanism to rebaseline new ports
3723         https://bugs.webkit.org/show_bug.cgi?id=80355
3724
3725         Reviewed by Adam Barth.
3726
3727         For a test that's only failing on a new port, we want
3728         to first copy the existing result into the location for the
3729         port it's replacing in order to not break that port.
3730
3731         For example, bringing up the chromium-lion port, if we just
3732         stick the results in the chromium-mac directory, the snow leopard
3733         will start failing. Instead, we first copy the existing result
3734         to the chromium-mac-snowleopard directory.
3735
3736         * Scripts/webkitpy/layout_tests/port/builders.py:
3737         (builder_path_for_port_name):
3738         (fallback_port_name_for_new_port):
3739         * Scripts/webkitpy/tool/commands/rebaseline.py:
3740         (RebaselineTest):
3741         (RebaselineTest._copy_existing_baseline):
3742         (RebaselineTest._rebaseline_test):
3743         (RebaselineTest.execute):
3744         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3745         (TestRebaseline.test_rebaseline_test):
3746         (TestRebaseline):
3747         (TestRebaseline.test_rebaseline_and_copy_test):
3748         (test_rebaseline_and_copy_test_no_existing_result):
3749         (test_rebaseline_and_copy_test_with_lion_result):
3750         (test_rebaseline_and_copy_no_overwrite_test):
3751         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3752         (GardeningHTTPRequestHandler.rebaseline):
3753         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3754         (GardeningServerTest.test_rebaseline):
3755         (GardeningServerTest):
3756         (GardeningServerTest.test_rebaseline_new_port):
3757
3758 2012-03-06  Beth Dakin  <bdakin@apple.com>
3759
3760         https://bugs.webkit.org/show_bug.cgi?id=80351
3761         InlineTextBox is using the wrong origin when calling
3762         addRelevantRepaintedObject
3763         -and corresponding-
3764         <rdar://problem/10970221>
3765
3766         Reviewed by Sam Weinig.
3767
3768         This test has actually been broken since revision 109273. This change makes
3769         the test pass again, and it makes it specifically exercise the fix for this
3770         bug.
3771         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3772         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
3773         (TestWebKitAPI::TEST):
3774
3775         Adjust comments in the other tests to reflect the API changes from 109273.
3776         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
3777         (TestWebKitAPI::TEST):
3778         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
3779         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage):
3780         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
3781         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage):
3782         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
3783         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::didCreatePage):
3784         * TestWebKitAPI/Tests/WebKit2/lots-of-text.html: Added.
3785
3786 2012-03-06  Hans Wennborg  <hans@chromium.org>
3787
3788         Speech JavaScript API: add SpeechRecognitionError
3789         https://bugs.webkit.org/show_bug.cgi?id=80410
3790
3791         Chromium: enable the runtime flag for scripted speech so we can run
3792         the layout tests for it.
3793
3794         Reviewed by Adam Barth.
3795
3796         * DumpRenderTree/chromium/TestShell.cpp:
3797         (TestShell::TestShell):
3798
3799 2012-03-06  Sami Kyostila  <skyostil@chromium.org>
3800
3801         Enable universal newlines in chromium android layout test runner
3802         https://bugs.webkit.org/show_bug.cgi?id=80418
3803
3804         Reviewed by Adam Barth.
3805
3806         The Chromium Android layout test runner uses the 'adb' program to
3807         communicate with the Android device. Adb uses CRLF ('\r\n') to delimit
3808         output lines from the test runner, while the test expectation files are
3809         written with LF ('\n') delimiters. This causes the results to have
3810         spurious whitespace differences, making them more difficult to
3811         interpret.
3812
3813         The fix is to enable universal newlines for the DumpRenderTree pipe,
3814         causing the output to only contain LF newlines like on other platforms.
3815
3816         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3817         (ChromiumAndroidDriver._start):
3818
3819 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3820
3821         [Qt] Revert r109900, it was completly busted
3822
3823         HAVE_FOO does _not_ have a WTF_ prefix, go figure.
3824
3825         We still leave in the HAVE(FOO) in QtInitializeTestFonts.cpp, instead
3826         of manual define checks.
3827
3828         Reviewed by Ossy.
3829
3830         * DumpRenderTree/qt/DumpRenderTree.pro:
3831         * QtTestBrowser/QtTestBrowser.pro:
3832         * WebKitTestRunner/InjectedBundle/Target.pri:
3833         * qmake/mkspecs/features/features.prf:
3834
3835 2012-03-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3836
3837         [Qt] Use config test to determine if the compiler supports -MD
3838
3839         We used to assume that unix systems building against Qt5 would have
3840         a compiler that supported -MD. Although this was usually the case,
3841         we failed to take into account broken tools for distributed builds
3842         (e.g. teambuilder or icecream) which would end up producing .d files
3843         in the root of the build dir instead of along-side the object file.
3844
3845         Now that we use a config-test to determine the support, we'll capture
3846         those cases, unless distributed builds are enabled after the initial
3847         build-webkit run.
3848
3849         Reviewed by Csaba Osztrogonác.
3850
3851         * Tools.pro:
3852         * qmake/config.tests/gccdepends/empty.cpp: Added.
3853         * qmake/config.tests/gccdepends/gccdepends.pro: Added.
3854         * qmake/mkspecs/features/default_pre.prf:
3855         * qmake/mkspecs/features/features.prf:
3856         * qmake/mkspecs/features/unix/default_pre.prf:
3857         * qmake/sync.profile:
3858
3859 2012-03-06  Csaba Osztrogonác  <ossy@webkit.org>
3860
3861         REGRESSION(r109294): It broke the unittest of master.cfg
3862         https://bugs.webkit.org/show_bug.cgi?id=80253
3863
3864         Reviewed by Tor Arne Vestbø.
3865
3866         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Use json instead of simplejson.
3867         (BuildBotConfigLoader._create_mock_passwords_dict):
3868         (BuildBotConfigLoader._mock_open):
3869         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules):
3870         (BuildBotConfigLoader.load_config):
3871
3872 2012-03-06  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3873
3874         Qt API test buildstep throws exception after buildmaster update
3875         https://bugs.webkit.org/show_bug.cgi?id=80249
3876
3877         This patch based on Peter Gal's work.
3878
3879         Reviewed by Csaba Osztrogonác.
3880
3881         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3882         (RunQtAPITests):
3883         (BuildAndTestFactory.__init__): Enable API tests on the Qt platform again.
3884
3885 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3886
3887         [Qt] Use correct define names for HAVE(FOO) style optional dependencies
3888
3889         Reviewed by Simon Hausmann.
3890         Reviewed by Ossy.
3891
3892         * DumpRenderTree/qt/DumpRenderTree.pro:
3893         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
3894         (WebKit::initializeTestFonts):
3895         * QtTestBrowser/QtTestBrowser.pro:
3896         * WebKitTestRunner/InjectedBundle/Target.pri:
3897         * qmake/mkspecs/features/features.prf:
3898
3899 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3900
3901         [Qt] Don't add recursive qmake_all target if there are no subdirs to recurse
3902
3903         Reviewed by Ossy.
3904
3905         * qmake/mkspecs/features/default_post.prf:
3906
3907 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3908
3909         [Qt] Make sure clean builds are followed by make qmake && make if needed
3910
3911         On non-GNUmake systems we have to run make qmake so that the generated
3912         sources are generated before we run qmake on the target pro files. This
3913         is achieved by using the 'incremental' target.
3914
3915         Reviewed by Ossy.
3916
3917         * Scripts/webkitdirs.pm:
3918         (buildQMakeProjects):
3919
3920 2012-03-06  Filip Pizlo  <fpizlo@apple.com>
3921
3922         DumpRenderTree should support preciseTime()
3923         https://bugs.webkit.org/show_bug.cgi?id=80397
3924
3925         Reviewed by Gavin Barraclough.
3926
3927         * DumpRenderTree/LayoutTestController.cpp:
3928         (preciseTimeCallback):
3929         (LayoutTestController::staticFunctions):
3930
3931 2012-03-06  Sheriff Bot  <webkit.review.bot@gmail.com>
3932
3933         Unreviewed, rolling out r109887.
3934         http://trac.webkit.org/changeset/109887
3935         https://bugs.webkit.org/show_bug.cgi?id=80402
3936
3937         It broke the build (Requested by Ossy on #webkit).
3938
3939         * DumpRenderTree/qt/DumpRenderTree.pro:
3940         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
3941         (WebKit::initializeTestFonts):
3942         * QtTestBrowser/QtTestBrowser.pro:
3943         * WebKitTestRunner/InjectedBundle/Target.pri:
3944         * qmake/mkspecs/features/features.prf:
3945
3946 2012-03-06  Sheriff Bot  <webkit.review.bot@gmail.com>
3947
3948         Unreviewed, rolling out r109837.
3949         http://trac.webkit.org/changeset/109837
3950         https://bugs.webkit.org/show_bug.cgi?id=80399
3951
3952         breaks Mac Productions builds, too late to try and fix it
3953         tonight (Requested by eseidel on #webkit).
3954
3955         * Scripts/build-webkit:
3956
3957 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3958
3959         [Qt] Use correct define names for HAVE(FOO) style optional dependencies
3960
3961         Reviewed by Simon Hausmann.
3962
3963         * DumpRenderTree/qt/DumpRenderTree.pro:
3964         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
3965         (WebKit::initializeTestFonts):
3966         * QtTestBrowser/QtTestBrowser.pro:
3967         * WebKitTestRunner/InjectedBundle/Target.pri:
3968         * qmake/mkspecs/features/features.prf:
3969
3970 2012-03-06  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3971
3972         [Qt] Create EWS to build WebKit2
3973         https://bugs.webkit.org/show_bug.cgi?id=80277
3974
3975         Reviewed by Csaba Osztrogonác.
3976
3977         * QueueStatusServer/model/queues.py:
3978         (Queue):
3979         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3980         (QtWK2EWS):
3981         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3982         (EarlyWarningSytemTest.test_builder_ewses):
3983
3984 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
3985
3986         Unreviewed, rolling out r109733.
3987         http://trac.webkit.org/changeset/109733
3988         https://bugs.webkit.org/show_bug.cgi?id=80378
3989
3990         It broke Qt5 build system (Requested by Ossy on #webkit).
3991
3992         * Tools.pro:
3993         * qmake/config.tests/gccdepends/empty.cpp: Removed.
3994         * qmake/config.tests/gccdepends/gccdepends.pro: Removed.
3995         * qmake/mkspecs/features/default_pre.prf:
3996         * qmake/mkspecs/features/features.prf:
3997         * qmake/mkspecs/features/unix/default_pre.prf:
3998         * qmake/sync.profile:
3999
4000 2012-03-05  Eric Seidel  <eric@webkit.org>
4001
4002         Update JavaScriptCore files to use fully-qualified WTF include path
4003         https://bugs.webkit.org/show_bug.cgi?id=79960
4004
4005         Reviewed by Adam Barth.
4006
4007         Build WTF/WTF.xcodeproj by default on Mac.
4008
4009         * Scripts/build-webkit:
4010
4011 2012-03-05  Dirk Pranke  <dpranke@chromium.org>
4012
4013         There should be a way to disable optimizer in webkit-patch rebaseline-expectations
4014         https://bugs.webkit.org/show_bug.cgi?id=69590
4015
4016         Reviewed by Ryosuke Niwa.
4017
4018         Adds a --no-optimize flag to webkit-patch rebaseline-expectations
4019         to skip the 'optimize-expectations' step.
4020
4021         * Scripts/webkitpy/tool/commands/rebaseline.py:
4022         (RebaselineExpectations.__init__):
4023         (RebaselineExpectations.execute):
4024         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
4025
4026 2012-03-05  Kent Tamura  <tkent@chromium.org>
4027
4028         [Chromium] Add new popup type: PagePopup
4029         https://bugs.webkit.org/show_bug.cgi?id=80106
4030
4031         Reviewed by Darin Fisher.
4032
4033         * DumpRenderTree/chromium/WebViewHost.cpp:
4034         (WebViewHost::createPopupMenu):
4035
4036 2012-03-05  Jessie Berlin  <jberlin@apple.com>
4037
4038         Add myself as a reviewer.
4039
4040         * Scripts/webkitpy/common/config/committers.py:
4041         Also, add my IRC nick so it is easier to find and yell at me.
4042
4043 2012-03-05  Robert Kroeger  <rjkroege@chromium.org>
4044
4045         Correctly compute the positions of GestureScroll* events on
4046         Chromium.
4047         https://bugs.webkit.org/show_bug.cgi?id=80075
4048
4049         Reviewed by Adam Barth.
4050
4051         * DumpRenderTree/chromium/EventSender.cpp:
4052         (EventSender::reset):
4053         (EventSender::gestureEvent):
4054         * DumpRenderTree/chromium/EventSender.h:
4055         (EventSender):
4056
4057 2012-03-05  Dirk Pranke  <dpranke@chromium.org>
4058
4059         flakiness dashboard doesn't display baselines for virtual tests correctly
4060         https://bugs.webkit.org/show_bug.cgi?id=80341
4061
4062         Reviewed by Ojan Vafai.
4063
4064         If the test is part of a virtual test suite, we need to look for
4065         baselines in the underlying fallback path for the actual test
4066         being run, as well as baselines for the virtual version.
4067
4068         This patch adds code to handle both branches and also pulls the
4069         mapping of the test suites up into a constant.
4070
4071         * TestResultServer/static-dashboards/flakiness_dashboard.html:
4072         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
4073         (testLookupVirtualTestSuite):
4074         (testBaseTest):
4075
4076 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
4077
4078         Unreviewed, rolling out r109760.
4079         http://trac.webkit.org/changeset/109760
4080         https://bugs.webkit.org/show_bug.cgi?id=80320
4081
4082         Caused many GTK+ tests to crash (Requested by mrobinson on
4083         #webkit).
4084
4085         * gtk/jhbuild.modules:
4086
4087 2012-03-05  Charlie Reis  <creis@chromium.org>
4088
4089         [chromium] Pass WebNavigationPolicy to WebViewClient::createView
4090         https://bugs.webkit.org/show_bug.cgi?id=80057
4091
4092         Reviewed by Darin Fisher.
4093
4094         * DumpRenderTree/chromium/WebViewHost.cpp:
4095         (WebViewHost::createView):
4096         * DumpRenderTree/chromium/WebViewHost.h:
4097         (WebViewHost):
4098
4099 2012-03-05  Martin Robinson  <mrobinson@igalia.com>
4100
4101         [soup] Crash while loading http://www.jusco.cn
4102         https://bugs.webkit.org/show_bug.cgi?id=68238
4103
4104         Reviewed by Philippe Normand.
4105
4106         * gtk/jhbuild.modules: Bumped the libsoup and glib dependencies
4107         in the jhbuild file.
4108
4109 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
4110
4111         Unreviewed, rolling out r109748.
4112         http://trac.webkit.org/changeset/109748
4113         https://bugs.webkit.org/show_bug.cgi?id=80296
4114
4115         Made some tests crash, will fix and recommit (Requested by
4116         noamr on #webkit).
4117
4118         * MiniBrowser/qt/main.cpp:
4119         (main):
4120
4121 2012-03-05  Zan Dobersek  <zandobersek@gmail.com>
4122
4123         [GTK] plugins/netscape-plugin-page-cache-works.html fails
4124         https://bugs.webkit.org/show_bug.cgi?id=74409
4125
4126         Reviewed by Martin Robinson.
4127
4128         Add support for overriding the page-cache-for-plugins preference
4129         through DumpRenderTreeSupport.
4130
4131         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4132         (booleanFromValue): A helper function to convert a string to boolean.
4133         (LayoutTestController::overridePreference):
4134
4135 2012-03-05  Rob Buis  <rbuis@rim.com>
4136
4137         [BlackBerry] Update Tools/DumpRenderTree
4138         https://bugs.webkit.org/show_bug.cgi?id=80287
4139
4140         Reviewed by Antonio Gomes.
4141
4142         Update so we are sure we can build our implementation of DRT.
4143
4144         * DumpRenderTree/DumpRenderTree.h: include DumpRenderTreeBlackBerry.h.
4145         * DumpRenderTree/PixelDumpSupport.cpp: include PixelDumpSupportBlackBerry.h.
4146         * DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp:
4147         (AccessibilityController::addNotificationListener): add missing hook.
4148         (AccessibilityController::removeNotificationListener): add missing hook.
4149         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
4150         (AccessibilityUIElement::isSelectedOptionActive): add missing hook.
4151         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
4152         (LayoutTestController::setMockSpeechInputDumpRect): add missing hook.
4153         (LayoutTestController::simulateDesktopNotificationClick): add missing hook.
4154
4155 2012-03-05  No'am Rosenthal  <noam.rosenthal@nokia.com>
4156
4157         [Qt] [WK2] Support threaded renderer in WK2
4158         https://bugs.webkit.org/show_bug.cgi?id=76661
4159
4160         Remove the QML_NO_THREADED_RENDERER environment variable from MiniBrowser.
4161
4162         Reviewed by Kenneth Rohde Christiansen.
4163
4164         * MiniBrowser/qt/main.cpp:
4165         (main):
4166
4167 2012-03-05  Alexander Færøy  <alexander.faeroy@nokia.com>
4168
4169         Unreviewed. Add myself to committer list.
4170
4171         * Scripts/webkitpy/common/config/committers.py:
4172
4173 2012-03-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4174
4175         [Qt] Use config test to determine if the compiler supports -MD
4176
4177         We used to assume that unix systems building against Qt5 would have
4178         a compiler that supported -MD. Although this was usually the case,
4179         we failed to take into account broken tools for distributed builds
4180         (e.g. teambuilder or icecream) which would end up producing .d files
4181         in the root of the build dir instead of along-side the object file.
4182
4183         Now that we use a config-test to determine the support, we'll capture
4184         those cases, unless distributed builds are enabled after the initial
4185         build-webkit run.
4186
4187         Reviewed by Csaba Osztrogonác.
4188
4189         * Tools.pro:
4190         * qmake/config.tests/gccdepends/empty.cpp: Added.
4191         * qmake/config.tests/gccdepends/gccdepends.pro: Added.
4192         * qmake/mkspecs/features/default_pre.prf:
4193         * qmake/mkspecs/features/features.prf:
4194         * qmake/mkspecs/features/unix/default_pre.prf:
4195         * qmake/sync.profile:
4196
4197 2012-03-05  Csaba Osztrogonác  <ossy@webkit.org>
4198
4199         Qt API test buildstep throws exception after buildmaster update
4200         https://bugs.webkit.org/show_bug.cgi?id=80249
4201
4202         Reviewed by Zoltan Herczeg.
4203
4204         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Disable API tests on the Qt bot temporarily.
4205         (BuildAndTestFactory.__init__):
4206
4207 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
4208
4209         [GTK] Unit tests are noisy when run under jhbuild
4210         https://bugs.webkit.org/show_bug.cgi?id=80241
4211
4212         Reviewed by Philippe Normand.
4213
4214         Force the 'memory' backend in GSettings so that each unit
4215         test doesn't produce a warning when it's forced to fall back
4216         to the 'memory' backend.
4217
4218         * Scripts/run-gtk-tests:
4219         (TestRunner.run): Force the 'memory' backend.
4220
4221 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
4222
4223         [GTK] "Console: undefined @0: ReferenceError: Can't find variable: WebInspector" during testwebinspector
4224         https://bugs.webkit.org/show_bug.cgi?id=80235
4225
4226         Reviewed by Philippe Normand.
4227
4228         * Scripts/run-gtk-tests:
4229         (TestRunner.run): Use the WEBKIT_INSPECTOR_PATH environment variable so that
4230         inspector resources path determination is shared by all tests.
4231
4232 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
4233
4234         [GTK] REGRESSION: r108278 broke some tests that expect focus
4235         https://bugs.webkit.org/show_bug.cgi?id=79084
4236
4237         Reviewed by Philippe Normand.
4238
4239         Grab focus when dumping test results and also when sending
4240         events. During the course of testing, the WebView may lose
4241         focus and this seems to snap it back when tests demand it.
4242
4243         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4244         (dump): Grab focus.
4245         * DumpRenderTree/gtk/EventSender.cpp:
4246         (dispatchEvent): Ditto.
4247
4248 2012-03-04  Charles Wei  <charles.wei@torchmobile.com.cn>
4249
4250         Unreviewed, Add myself to committer list.
4251         https://bugs.webkit.org/show_bug.cgi?id=80232
4252
4253         * Scripts/webkitpy/common/config/committers.py:
4254
4255 2012-03-04  Anders Carlsson  <andersca@apple.com>
4256
4257         Newer versions of clang fail to compile WebKit.
4258
4259         Fix build.
4260
4261         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4262         (descriptionOfValue):
4263         (AccessibilityUIElement::rowIndexRange):
4264         (AccessibilityUIElement::columnIndexRange):
4265         (AccessibilityUIElement::selectedTextRange):
4266         * DumpRenderTree/mac/EditingDelegate.mm:
4267         (-[DOMRange dump]):
4268         * DumpRenderTree/mac/PolicyDelegate.mm:
4269         (-[PolicyDelegate webView:unableToImplementPolicyWithError:frame:]):
4270         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
4271         (-[NSError _drt_descriptionSuitableForTestResult]):
4272         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4273         (WTR::descriptionOfValue):
4274         (WTR::AccessibilityUIElement::rowIndexRange):
4275         (WTR::AccessibilityUIElement::columnIndexRange):
4276         (WTR::AccessibilityUIElement::selectedTextRange):
4277
4278 2012-03-03  Simon Hausmann  <simon.hausmann@nokia.com>
4279
4280         [Qt] Fix static_libs_as_shared build
4281         https://bugs.webkit.org/show_bug.cgi?id=80214
4282
4283         Reviewed by Tor Arne Vestbø.
4284
4285         * WebKitTestRunner/qt/main.cpp:
4286         (main): Set the correct environment variable for choosing the theme in the
4287         web process.
4288
4289 2012-03-03  Hans Wennborg  <hans@chromium.org>
4290
4291         Implement Speech JavaScript API
4292         https://bugs.webkit.org/show_bug.cgi?id=80019
4293
4294         Reviewed by Adam Barth.
4295
4296         Add ENABLE_SCRIPTED_SPEECH.
4297
4298         * Scripts/build-webkit:
4299         * qmake/mkspecs/features/features.prf:
4300
4301 2012-03-02  Alexey Proskuryakov  <ap@apple.com>
4302
4303         Fix commit queue, remove duplicate entry.
4304
4305         * Scripts/webkitpy/common/config/committers.py:
4306
4307 2012-03-02  Stephen Chenney  <schenney@chromium.org>
4308
4309         Unreviewed, add myself as a committer
4310
4311         * Scripts/webkitpy/common/config/committers.py:
4312
4313 2012-03-02  Ojan Vafai  <ojan@chromium.org>
4314
4315         Add the Chromium Lion canary bot to the flakiness dashboard.
4316         * TestResultServer/static-dashboards/builders.js:
4317
4318 2012-03-02  Dirk Pranke  <dpranke@chromium.org>
4319
4320         links for virtual tests are broken in the flakiness dashboard
4321         https://bugs.webkit.org/show_bug.cgi?id=80180
4322
4323         Reviewed by Ojan Vafai.
4324
4325         * TestResultServer/static-dashboards/flakiness_dashboard.html:
4326         (linkHTMLToOpenWindow):
4327         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
4328         (testLinkHTMLToOpenWindow): added.
4329
4330 2012-03-02  Philippe Normand  <pnormand@igalia.com>
4331
4332         [GTK] security/block-test.html baselines differ from mac
4333         https://bugs.webkit.org/show_bug.cgi?id=78343
4334
4335         Reviewed by Martin Robinson.
4336
4337         Improved the FrameLoader error heuristics to match mac behavior a
4338         bit more.
4339
4340         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4341         (pathFromSoupURI): Handle ftp urls the same as http urls.
4342         (descriptionSuitableForTestResult): Map WebKitPolicyError to WebKitErrorDomain.
4343
4344 2012-03-02  Andras Becsi  <andras.becsi@nokia.com>
4345
4346         [Qt][WK2] Fix typo in patch committed in r109575
4347
4348         Unreviewed typo fix.
4349
4350         * MiniBrowser/qt/MiniBrowserApplication.cpp:
4351         (MiniBrowserApplication::notify): Cache the position
4352         in floating point coordinates.
4353
4354 2012-03-02  Andras Becsi  <andras.becsi@nokia.com>
4355
4356         [Qt][WK2] Infinite loop on history navigation, when panning
4357         https://bugs.webkit.org/show_bug.cgi?id=79119
4358
4359         Reviewed by Simon Hausmann.
4360
4361         Make the touch mocking more robust by creating touch events
4362         directly and sending them synchronously to the browser window.
4363         If the sent touch event was not accepted we propagate the
4364         original mouse event to its target.
4365         This way we make sure we only send either a touch or a mouse
4366         event and do not end up in an infinite loop between our mocking
4367         code and the Qt5 automatic mouse event synthesizing.
4368