Make run-javascriptcore-test run testair, testb3, and testmasm.
[WebKit-https.git] / Tools / ChangeLog
1 2017-07-26  Mark Lam  <mark.lam@apple.com>
2
3         Make run-javascriptcore-test run testair, testb3, and testmasm.
4         https://bugs.webkit.org/show_bug.cgi?id=174837
5         <rdar://problem/33522927>
6
7         Reviewed by Saam Barati and Filip Pizlo.
8
9         1. Refactors code for running testapi so that we can use it to run other tests.
10         2. Added running of testmasm, testair, testb3.
11
12         Note: the existing testapi invocation code does not support remote invocation of
13         the tests (e.g. on a ARM device).  Hence, the new additions of testmasm, testair,
14         and testb3 also do not support remote invocation.  If we wish to add remote
15         invocation support, we should do that in a separate patch.
16
17         * Scripts/run-javascriptcore-tests:
18         (testPath):
19         (runTest):
20         (testapiPath): Deleted.
21
22 2017-07-26  Aakash Jain  <aakash_jain@apple.com>
23
24         Remove duplicate code from Buildbot.js in dashboard
25         https://bugs.webkit.org/show_bug.cgi?id=174870
26
27         Reviewed by Daniel Bates.
28
29         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
30         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Remove duplicate code and reuse buildPageURLForIteration() to construct URL.
31         (Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto.
32         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js:
33         (MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto for tests.
34
35 2017-07-26  Brady Eidson  <beidson@apple.com>
36
37         Add test to verify certain child processes are not launched as a side effect of enabling ResourceLoadStatistics.
38         https://bugs.webkit.org/show_bug.cgi?id=174851
39
40         Reviewed by Chris Dumez.
41
42         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
43         (TEST):
44
45 2017-07-26  Brian Burg  <bburg@apple.com>
46
47         Remove WEB_TIMING feature flag
48         https://bugs.webkit.org/show_bug.cgi?id=174795
49
50         Reviewed by Alex Christensen.
51
52         * Scripts/webkitperl/FeatureList.pm:
53         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
54
55 2017-07-26  Chris Dumez  <cdumez@apple.com>
56
57         Pressing the Escape key should not be a valid user gesture to enter fullscreen
58         https://bugs.webkit.org/show_bug.cgi?id=174864
59         <rdar://problem/33009088>
60
61         Reviewed by Geoffrey Garen.
62
63         Add support for eventSender.keyDown('escape') in DRT to match the behavior of
64         WKTR.
65
66         * DumpRenderTree/mac/EventSendingController.mm:
67         (-[EventSendingController keyDown:withModifiers:withLocation:]):
68
69 2017-07-26  Romain Bellessort  <romain.bellessort@crf.canon.fr>
70
71         Unreviewed, added Romain Bellessort to contributors.json.
72
73         * Scripts/webkitpy/common/config/contributors.json:
74
75 2017-07-26  Zan Dobersek  <zdobersek@igalia.com>
76
77         [WPE] WebGL2 support
78         https://bugs.webkit.org/show_bug.cgi?id=174249
79
80         Reviewed by Alex Christensen.
81
82         * Scripts/webkitperl/FeatureList.pm:
83         Enable WebGL2 for WPE when building through build-webkit.
84
85 2017-07-26  Carlos Garcia Campos  <cgarcia@igalia.com>
86
87         Unreviewed. Fix GTK distcheck.
88
89         * gtk/make-dist.py:
90         (ensure_version_if_possible): Use the right pkg-config filename, it's webkit2gtk not webkitgtk.
91
92 2017-07-25  Brady Eidson  <beidson@apple.com>
93
94         ResourceLoadStatistics grandfathering happens much too often.
95         <rdar://problem/32655834> and https://bugs.webkit.org/show_bug.cgi?id=174825
96
97         Reviewed by Chris Dumez.
98
99         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
100         * TestWebKitAPI/Tests/WebKit2Cocoa/EmptyGrandfatheredResourceLoadStatistics.plist: Added.
101         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm: Added.
102         (TEST):
103
104 2017-07-25  Matthew Stewart  <matthew_r_stewart@apple.com>
105
106         Fix autoinstaller failing on autoinstall_everything
107         https://bugs.webkit.org/show_bug.cgi?id=174830
108
109         Reviewed by Joseph Pecoraro.
110
111         * Scripts/webkitpy/thirdparty/__init__.py:
112         (AutoinstallImportHook.find_module):
113         (AutoinstallImportHook.install_chromedriver):
114         (AutoinstallImportHook.install_geckodriver):
115         (AutoinstallImportHook._install_chromedriver): Deleted.
116         (AutoinstallImportHook._install_geckodriver): Deleted.
117
118 2017-07-25  Jonathan Bedard  <jbedard@apple.com>
119
120         Replace --runtime with something for both ios-simulator and ios-device
121         https://bugs.webkit.org/show_bug.cgi?id=173775
122         <rdar://problem/32952164>
123
124         Reviewed by Aakash Jain.
125
126         Add --version flag for both iOS simulator and iOS device.
127
128         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
129         (parse_args): Add --version flag and move --no-install.
130         * Scripts/webkitpy/port/factory.py:
131         (platform_options): Move --no-intall to run_webkit_tests.py.
132         * Scripts/webkitpy/port/ios.py:
133         (IOSPort):
134         (IOSPort._is_valid_ios_version): Check that the provided version string is legal.
135         (IOSPort.get_option): If accessing the iOS version, check that it is a valid version string.
136         * Scripts/webkitpy/port/ios_device.py:
137         (IOSDevicePort.ios_version): Consult --version flag before checking connected
138         devices for iOS version.
139         * Scripts/webkitpy/port/ios_device_unittest.py:
140         (IOSDeviceTest.make_port): Set --version option so that we can generate test
141         expectation paths without devices connected.
142         (IOSDeviceTest.test_additional_platform_directory): Deleted.
143         (IOSDeviceTest.test_baseline_searchpath): Deleted.
144         (IOSDeviceTest.test_expectations_ordering): Deleted.
145         * Scripts/webkitpy/port/ios_simulator.py:
146         (IOSSimulatorPort.simulator_runtime): If no runtime is specified, use the --version
147         flag to specify a runtime.
148         (IOSSimulatorPort.ios_version): First check the --version flag, then the --runtime
149         flag and then use the default runtime.
150
151 2017-07-25  Carlos Garcia Campos  <cgarcia@igalia.com>
152
153         [GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename
154         https://bugs.webkit.org/show_bug.cgi?id=174815
155
156         Reviewed by Carlos Alberto Lopez Perez.
157
158         Only WebKitGTK specific tests are built, but not WebKit2, WTF nor WebCore ones. We are still checking
159         ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to
160         use WebKit dir, while the tests are still in WebKit2 directory. This patch also removes
161         TestWebKitAPIInjectedBundle_PATH that is unused and now makes the configure to fail (it used to be a warning, I
162         think), probably because of a newer CMake version.
163
164         * CMakeLists.txt:
165         * TestWebKitAPI/CMakeLists.txt:
166         * TestWebKitAPI/PlatformGTK.cmake:
167
168 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
169
170         Fix BenchmarkRunner to only import selenium when needed
171         https://bugs.webkit.org/show_bug.cgi?id=174808
172
173         Reviewed by Stephanie Lewis.
174
175         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
176         (LinuxChromeDriver.launch_driver):
177         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
178         (LinuxFirefoxDriver.launch_driver):
179         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
180         (OSXChromeDriver.launch_driver):
181         (OSXChromeCanaryDriver.launch_driver):
182         (create_chrome_options):
183         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
184         (OSXFirefoxDriver.launch_driver):
185         (OSXFirefoxNightlyDriver.launch_driver):
186         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
187         (OSXSafariDriver.launch_driver):
188         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
189         (WebDriverBenchmarkRunner._run_one_test):
190
191 2017-07-23  Darin Adler  <darin@apple.com>
192
193         More NeverDestroyed and related cleanup
194         https://bugs.webkit.org/show_bug.cgi?id=174745
195
196         Reviewed by Alex Christensen.
197
198         * DumpRenderTree/JavaScriptThreading.cpp:
199         (javaScriptThreadsMutex): Use NeverDestroyed instead of
200         DEPRECATED_DEFINE_STATIC_LOCAL.
201         (javaScriptThreads): Ditto.
202
203 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
204
205         Subclass Benchmark Runner script for WebDriver support
206         https://bugs.webkit.org/show_bug.cgi?id=174390
207
208         Reviewed by Dewei Zhu, Stephanie Lewis.
209
210         Add WebServerBenchmarkRunner and WebDriverBenchmarkRunner subclasses.
211
212         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
213         (BenchmarkBuilder.__init__):
214         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
215         (BenchmarkRunner.__init__):
216         (BenchmarkRunner._find_plan_file):
217         (BenchmarkRunner._run_one_test.and):
218         (BenchmarkRunner.execute):
219         (BenchmarkRunner._get_result): Deleted.
220         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
221         (parse_args):
222         (start):
223         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py: Added.
224         (WebDriverBenchmarkRunner):
225         (WebDriverBenchmarkRunner._get_result):
226         (WebDriverBenchmarkRunner._run_one_test):
227         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py: Added.
228         (WebServerBenchmarkRunner):
229         (WebServerBenchmarkRunner.__init__):
230         (WebServerBenchmarkRunner._get_result):
231         (WebServerBenchmarkRunner._run_one_test):
232
233 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
234
235         Add BenchmarkRunner patches with WebDriver support for each testing plan
236         https://bugs.webkit.org/show_bug.cgi?id=174443
237
238         Reviewed by Dewei Zhu, Stephanie Lewis.
239
240         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
241         (BenchmarkBuilder.__enter__):
242         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ARES-6.patch:
243         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ContentAnimation.patch:
244         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Dromaeo.patch:
245         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JSBench.patch:
246         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JetStream.patch:
247         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Kraken.patch:
248         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/MotionMark.patch:
249         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Octane.patch:
250         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Speedometer.patch:
251         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/SunSpider.patch:
252         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
253         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Animometer.patch:
254         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ContentAnimation.patch:
255         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Dromaeo.patch:
256         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JSBench.patch:
257         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JetStream.patch:
258         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Kraken.patch:
259         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
260         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Octane.patch:
261         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer.patch:
262         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/SunSpider.patch:
263         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
264         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
265         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan:
266         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan:
267         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan:
268         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
269         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan:
270         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan:
271         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
272         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan:
273         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
274         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
275
276 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
277
278         Add functions to autoinstaller needed for Benchmark Runner script
279         https://bugs.webkit.org/show_bug.cgi?id=174331
280
281         Reviewed by Dean Johnson, Dewei Zhu, Stephanie Lewis.
282
283         Adds autoinstaller functions to install selenium and webdriver binaries
284         which will be used by the browser driver part of Benchmark Runner.
285
286         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
287         (BrowserDriver.restore_env):
288         (BrowserDriver):
289         (BrowserDriver.get_webdriver_binary_path):
290         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
291         (LinuxChromeDriver.launch_driver):
292         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
293         (LinuxFirefoxDriver.launch_driver):
294         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
295         (OSXChromeDriver.launch_driver):
296         (OSXChromeCanaryDriver.launch_driver):
297         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
298         (OSXFirefoxDriver.launch_driver):
299         (OSXFirefoxNightlyDriver.launch_driver):
300         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
301         * Scripts/webkitpy/benchmark_runner/utils.py:
302         (get_driver_binary_path):
303         * Scripts/webkitpy/common/system/autoinstall.py:
304         (AutoInstaller._unzip):
305         * Scripts/webkitpy/thirdparty/__init__.py:
306         (AutoinstallImportHook.find_module):
307         (AutoinstallImportHook._install_selenium):
308         (AutoinstallImportHook):
309         (AutoinstallImportHook._install_chromedriver):
310         (AutoinstallImportHook._install_geckodriver):
311         (AutoinstallImportHook.get_latest_pypi_url):
312         (AutoinstallImportHook.install_binary):
313         (autoinstall_everything):
314         (get_driver_filename):
315         (get_os_info):
316
317 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
318
319         Add WebDriver support in browser driver part of BenchmarkRunner
320         https://bugs.webkit.org/show_bug.cgi?id=174445
321
322         Reviewed by Stephanie Lewis.
323
324         Adds a launch_driver function to each BrowserDriver subclass. This
325         function sets up the arguments for the webdriver and launches the
326         webdriver specific to that browser.
327
328         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
329         (BrowserDriver.launch_webdriver):
330         (BrowserDriver):
331         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
332         (LinuxBrowserDriver.launch_webdriver):
333         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
334         (LinuxChromeDriver.launch_url):
335         (LinuxChromeDriver):
336         (LinuxChromeDriver.launch_driver):
337         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py:
338         (EpiphanyBrowserDriver.launch_url):
339         (EpiphanyBrowserDriver):
340         (EpiphanyBrowserDriver.launch_driver):
341         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
342         (LinuxFirefoxDriver):
343         (LinuxFirefoxDriver.launch_url):
344         (LinuxFirefoxDriver.launch_driver):
345         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
346         (GTKMiniBrowserDriver.launch_url):
347         (GTKMiniBrowserDriver):
348         (GTKMiniBrowserDriver.launch_driver):
349         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
350         (OSXBrowserDriver._launch_webdriver):
351         (OSXBrowserDriver):
352         (OSXBrowserDriver._screen_size):
353         (OSXBrowserDriver._insert_url):
354         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
355         (OSXChromeDriver):
356         (OSXChromeDriver.launch_url):
357         (OSXChromeDriver.launch_driver):
358         (OSXChromeCanaryDriver):
359         (OSXChromeCanaryDriver.launch_url):
360         (OSXChromeCanaryDriver.launch_driver):
361         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
362         (OSXFirefoxDriver):
363         (OSXFirefoxDriver.launch_url):
364         (OSXFirefoxDriver.launch_driver):
365         (OSXFirefoxNightlyDriver):
366         (OSXFirefoxNightlyDriver.launch_url):
367         (OSXFirefoxNightlyDriver.launch_driver):
368         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
369         (OSXSafariDriver.launch_driver):
370
371 2017-07-24  Wenson Hsieh  <wenson_hsieh@apple.com>
372
373         [Mac WK2] Add an API test to cover r219765 (null dereference in [WKWebView dealloc])
374         https://bugs.webkit.org/show_bug.cgi?id=174793
375
376         Reviewed by Tim Horton.
377
378         Adds a new unit test that invokes some asynchronous NSTextInputClient SPI methods as the web view is tearing
379         down. Without r219765, this test will dereference null and crash.
380
381         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
382         * TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h: Added.
383         * TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm:
384         (TEST):
385
386 2017-07-24  Basuke Suzuki  <Basuke.Suzuki@sony.com>
387
388         [Win] Implement Authentication dialog in MiniBrowser
389         https://bugs.webkit.org/show_bug.cgi?id=174662
390
391         Reviewed by Alex Christensen.
392
393         * MiniBrowser/win/Common.cpp:
394         (CustomUserAgent):
395         (DisplayAuthDialog):
396         (AuthDialogProc):
397         * MiniBrowser/win/MiniBrowserLib.rc:
398         * MiniBrowser/win/MiniBrowserLibResource.h:
399         * MiniBrowser/win/ResourceLoadDelegate.cpp:
400         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
401
402 2017-07-24  Jonathan Bedard  <jbedard@apple.com>
403
404         Handle case where line_numbers is None instead of an array of line numbers
405         https://bugs.webkit.org/show_bug.cgi?id=174775
406
407         Reviewed by Aakash Jain.
408
409         Added files set line_numbers to None in process_file.
410
411         * Scripts/webkitpy/style/filereader.py:
412         (TextFileReader.process_file): Handle case where line_number is set to None.
413         * Scripts/webkitpy/style/main_unittest.py:
414         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Test case of an added file.
415
416 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
417
418         [WPE] Add libepoxy to the Jhbuild moduleset
419         https://bugs.webkit.org/show_bug.cgi?id=174711
420
421         Reviewed by Carlos Alberto Lopez Perez.
422
423         * wpe/jhbuild.modules: Add libepoxy 1.4.3 to WPE's Jhbuild moduleset.
424
425 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
426
427         [WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
428         https://bugs.webkit.org/show_bug.cgi?id=174780
429
430         Reviewed by Carlos Garcia Campos.
431
432         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
433         Manually define the EGL_CAST macro to the C++ version that uses static_cast<>
434         in case the eglplatform.h header doesn't provide that macro. This replicates
435         the work in WebCore's EpoxyEGL.h header, but we can't include that header here.
436
437 2017-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
438
439         [iOS WK2] Remove _WKDraggableElementInfo and fold PositionInformationTests into WKRequestActivatedElementInfo
440         https://bugs.webkit.org/show_bug.cgi?id=174758
441
442         Reviewed by Dan Bernstein.
443
444         Migrate position-information-related unit tests from the PositionInformationTests suite to
445         WKRequestActivatedElementInfo as 2 new unit tests. See WebKit2 ChangeLog for more details.
446
447         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
448         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
449         (TestWebKitAPI::checkElementTypeAndBoundingRect):
450         (TestWebKitAPI::TEST):
451         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm: Removed.
452         * TestWebKitAPI/cocoa/TestWKWebView.h:
453         * TestWebKitAPI/cocoa/TestWKWebView.mm:
454         (-[TestWKWebView activatedElementAtPosition:]):
455
456 2017-07-22  Chris Dumez  <cdumez@apple.com>
457
458         REGRESSION(r204565): WKObject is broken
459         https://bugs.webkit.org/show_bug.cgi?id=174736
460         <rdar://problem/33246169>
461
462         Reviewed by Dan Bernstein.
463
464         Add API test that used to crash.
465
466         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
467         (TestWebKitAPI::TEST):
468
469 2017-07-22  Yusuke Suzuki  <utatane.tea@gmail.com>
470
471         [WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult
472         https://bugs.webkit.org/show_bug.cgi?id=174705
473
474         Reviewed by Mark Lam.
475
476         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
477         (TestWebKitAPI::testThreadGroup):
478         (TestWebKitAPI::TEST):
479
480 2017-07-21  Jonathan Bedard  <jbedard@apple.com>
481
482         Fail gracefully when xcrun fails in IOSSimulatorPort constructor
483         https://bugs.webkit.org/show_bug.cgi?id=174724
484
485         Reviewed by Aakash Jain.
486
487         * Scripts/webkitpy/port/ios_simulator.py:
488         (IOSSimulatorPort.__init__): Ignore any errors when attempting to find a running
489         simulator. Errors here should be treated the same as no simulators found.
490
491 2017-07-21  Yousuke Kimoto  <Yousuke.Kimoto@sony.com>
492
493         [CMake] Add an option to stop build after generating project files
494         https://bugs.webkit.org/show_bug.cgi?id=174664
495
496         Reviewed by Konstantin Tokarev.
497
498         Add "--generate-project-only" to stop build after generating project files.
499
500         * Scripts/build-webkit: Add '--generate-project-only' option and a checker to stop build.
501         * Scripts/webkitdirs.pm: Add a function to check '--generate-project-only' option and the same checker as the above
502         (buildCMakeProjectOrExit): Add a cheker to stop build stop build after generating project files.
503         (determineIsGenerateProjectOnly): Check if '--generate-project-only' option is specified
504         (isGenerateProjectOnly): ditto
505
506 2017-07-21  Yusuke Suzuki  <utatane.tea@gmail.com>
507
508         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
509         https://bugs.webkit.org/show_bug.cgi?id=174501
510
511         Reviewed by Darin Adler.
512
513         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
514         (TestWebKitAPI::TEST):
515
516 2017-07-20  David Quesada  <david_quesada@apple.com>
517
518         Add SPI to notify WKNavigationDelegate about client redirects
519         https://bugs.webkit.org/show_bug.cgi?id=174680
520         rdar://problem/33184886
521
522         Reviewed by Brady Eidson.
523
524         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
525         (-[DidPerformClientRedirectNavigationDelegate _webView:didPerformClientRedirectForNavigation:]):
526         (TEST):
527         Add API test for -[id<WKNavigationDelegatePrivate> _webView:didPerformClientRedirectForNavigation:].
528
529 2017-07-20  Brady Eidson  <beidson@apple.com>
530
531         Test WebKit2CustomProtocolsTest.ProcessPoolDestroyedDuringLoading added in r219664 fails on El Capitan.
532         https://bugs.webkit.org/show_bug.cgi?id=174685
533
534         Reviewed by Andy Estes.
535
536         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
537         (TestWebKitAPI::TEST): Use a scoped AutodrainedPool instead of a RetainPtr<NSAutoreleasePool>.
538
539 2017-07-20  Brady Eidson  <beidson@apple.com>
540
541         Deprecate WebIconDatabase in WebKitLegacy/mac.
542         https://bugs.webkit.org/show_bug.cgi?id=174607
543
544         Reviewed by Alex Christensen.
545
546         * DumpRenderTree/mac/TestRunnerMac.mm:
547
548 2017-07-20  Jonathan Bedard  <jbedard@apple.com>
549
550         lint-test-expectations should be run during style checking
551         https://bugs.webkit.org/show_bug.cgi?id=173559
552         <rdar://problem/32854941>
553
554         Reviewed by Aakash Jain.
555
556         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
557         (TestExpectationsModel._already_seen_better_match): Append returns 'None' when successful,
558         prevents identifying errors on specific lines in a file.
559         * Scripts/webkitpy/style/main_unittest.py:
560         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Test for the
561         case where a linter error is in the file modified, but the line modified is not related to
562         the linter error.
563
564 2017-07-20  Brady Eidson  <beidson@apple.com>
565
566         Remove WebIconDatabase from WebKitLegacy/win.
567         https://bugs.webkit.org/show_bug.cgi?id=174608
568
569         Reviewed by Alex Christensen.
570
571         * DumpRenderTree/win/DumpRenderTree.cpp:
572         (main):
573         * DumpRenderTree/win/TestRunnerWin.cpp:
574         (TestRunner::setIconDatabaseEnabled):
575
576 2017-07-20  Zan Dobersek  <zdobersek@igalia.com>
577
578         [WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
579         https://bugs.webkit.org/show_bug.cgi?id=174671
580
581         Reviewed by Carlos Garcia Campos.
582
583         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
584         (HeadlessViewBackend::HeadlessViewBackend): Use the RunLoopDispatcher
585         priority for this source in order to have it dispatched on the same
586         priority as the other WebKit-controlled GSource objects.
587
588 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
589
590         lint-test-expectations should be run during style checking
591         https://bugs.webkit.org/show_bug.cgi?id=173559
592         <rdar://problem/32854941>
593
594         Reviewed by Daniel Bates.
595
596         Follow up fix addressing style and a few minor bugs.
597
598         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
599         (TestExpectationParser.__init__): Use lambda x: x instead of str
600         (TestExpectationsModel.__init__): Make lambda x: x the default argument.
601         (TestExpectationsModel._already_seen_better_match): Use a temporary variable to
602         reduce the calls of _shorten_filename, fix minor bug in appending the current
603         expectation's line number instead of the previous ones, clarify treatment of None
604         in file-to-line-number mapping.
605         (TestExpectations._report_warnings): Collapse call.
606         * Scripts/webkitpy/style/checkers/test_expectations.py:
607         (TestExpectationsChecker.lint_test_expectations):
608         * Scripts/webkitpy/style/filereader.py: Re-write comment.
609         (TextFileReader.process_file): Add comment explaining treatment of None in
610         file-to-line-number mapping.
611         (TextFileReader.delete_file): Collapse call.
612
613 2017-07-19  Chris Dumez  <cdumez@apple.com>
614
615         Unreviewed attempt to fix API test failure after r219663.
616
617         The test was hard-coding an exception string and the string has changed slightly
618         in r219663.
619
620         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
621         (TEST):
622
623 2017-07-19  Megan Gardner  <megan_gardner@apple.com>
624
625         Don't write file URLs to iOS Pasteboard
626         https://bugs.webkit.org/show_bug.cgi?id=174647
627         <rdar://problem/33199730>
628
629         Reviewed by Wenson Hsieh.
630
631         Updating tests to reflect the lack of file URLs for images.
632
633         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
634         (checkTypeIdentifierAndIsNotOtherTypeIdentifier):
635         (checkEstimatedSize):
636         (TestWebKitAPI::TEST):
637
638 2017-07-19  Brady Eidson  <beidson@apple.com>
639
640         iBooks sometimes crashes when closing a book.
641         <rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658
642
643         Reviewed by Oliver Hunt.
644
645         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
646         (-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
647         (-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
648         (-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
649         (TestWebKitAPI::TEST):
650
651         Add a "spin the runloop X number of times" utility:
652         * TestWebKitAPI/Utilities.h:
653         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
654         (TestWebKitAPI::Util::spinRunLoop):
655
656 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
657
658         lint-test-expectations should be run during style checking
659         https://bugs.webkit.org/show_bug.cgi?id=173559
660         <rdar://problem/32854941>
661
662         Reviewed by David Kilzer.
663
664         Running the test expectation linter requires reading both files and lines not in the
665         patch because, for example, deletion of a test can cause a lint failure even though
666         no test expectations where modified. This means that the linter will occasionally warn
667         about lines which were not changed in a given patch but whose error is related to a
668         change made in that patch.
669
670         * Scripts/webkitpy/common/system/filesystem_mock.py:
671         (MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.
672         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
673         (TestExpectationWarning): Added class to pass warnings as an object instead of a string.
674         (TestExpectationWarning.__init__): Construct warning with file name, line number, line
675         content, description of the error and the name of the associated test.
676         (TestExpectationWarning.__str__): Convert to string so that existing printing code works.
677         (TestExpectationParser.__init__): Pass shorten_filename function to
678         TestExpectationsParser to add a deleted file to the related_files dictionary.
679         (TestExpectationParser._check_test_exists): If the test does not exist, add the
680         missing path to the related_files dictionary.
681         (TestExpectationLine.__init__): Add related_files dictionary, which tracks
682         files and line numbers related to this test expectation line. This will allow
683         tracking linter errors in the style checker occurring across multiple files.
684         (TestExpectationsModel._already_seen_better_match): Add redundant expectation
685         lines to related_files dictionary.
686         (TestExpectations.__init__): Pass self._shorten_filename to TestExpectationParser.
687         (TestExpectations._report_warnings): Construct warning object instead of string
688         when adding to warnings list.
689         * Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to
690         clean-up log.
691         * Scripts/webkitpy/style/checker.py:
692         (ProcessorBase.do_association_check): Add required function for processor classes.
693         (StyleProcessor):
694         (StyleProcessor.do_association_check): Run the TestExpectations linter when
695         checking for errors between associated files.
696         * Scripts/webkitpy/style/checkers/test_expectations.py:
697         (TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
698         (TestExpectationsChecker):
699         (TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
700         of modified files, the current working directory and the host, determine if the linter
701         warning is associated with the changes.
702         (TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
703         style checker.
704         * Scripts/webkitpy/style/filereader.py:
705         (TextFileReader):
706         (TextFileReader.__init__): Track modified files in dictionary instead of a counter.
707         (TextFileReader.file_count): Use dictionary to determine the number of modified files.
708         (TextFileReader.process_file): Track both the number of files changed and which lines
709         in those files were changed.
710         (TextFileReader.do_association_check): Run the processor's association check on all
711         modified or deleted files processed by TextFileReader.
712         (TextFileReader.delete_file): Track deleted files in _files dictionary.
713         (TextFileReader.count_delete_only_file): Deleted.
714         * Scripts/webkitpy/style/filereader_unittest.py:
715         (TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
716         (TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.
717         * Scripts/webkitpy/style/main.py:
718         (CheckWebKitStyle.main): When running the style checker on a specific list of files,
719         explicitly run the association check on the file reader.
720         * Scripts/webkitpy/style/main_unittest.py:
721         (ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
722         embedded in the style checker.
723         (ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
724         (ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
725         construct the TextFileReader object with a StyleProcessor used to run style checks on
726         specific files.
727         (ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
728         testing the test expectation linter inside the style checker. This host must contain a
729         mock file system with the basic structure of test expectations.
730         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
731         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
732         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
733         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
734         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):
735         * Scripts/webkitpy/style/patchreader.py:
736         (PatchReader.check): Specify which file was deleted, run the association check.
737         * Scripts/webkitpy/style/patchreader_unittest.py:
738         (PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
739         (PatchReaderTest.MockTextFileReader.do_association_check): Added.
740         (PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.
741
742 2017-07-19  Yusuke Suzuki  <utatane.tea@gmail.com>
743
744         [WTF] Implement WTF::ThreadGroup
745         https://bugs.webkit.org/show_bug.cgi?id=174081
746
747         Reviewed by Mark Lam.
748
749         Add WTF::ThreadGroup tests.
750
751         * TestWebKitAPI/CMakeLists.txt:
752         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
753         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
754         (TestWebKitAPI::testThreadGroup):
755         (TestWebKitAPI::TEST):
756
757 2017-07-18  Andy Estes  <aestes@apple.com>
758
759         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
760         https://bugs.webkit.org/show_bug.cgi?id=174631
761
762         Reviewed by Tim Horton.
763
764         * DumpRenderTree/mac/Configurations/Base.xcconfig:
765         * MiniBrowser/Configurations/Base.xcconfig:
766         * MobileMiniBrowser/Configurations/Base.xcconfig:
767         * TestWebKitAPI/Configurations/Base.xcconfig:
768         * WebKitTestRunner/Configurations/Base.xcconfig:
769
770 2017-07-18  Andy Estes  <aestes@apple.com>
771
772         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
773         https://bugs.webkit.org/show_bug.cgi?id=174631
774
775         Reviewed by Sam Weinig.
776
777         * DumpRenderTree/mac/Configurations/Base.xcconfig:
778         * MiniBrowser/Configurations/Base.xcconfig:
779         * MobileMiniBrowser/Configurations/Base.xcconfig:
780         * TestWebKitAPI/Configurations/Base.xcconfig:
781         * WebKitTestRunner/Configurations/Base.xcconfig:
782
783 2017-07-18  Daniel Bates  <dabates@apple.com>
784
785         lldb: Add type summary for StringView
786         https://bugs.webkit.org/show_bug.cgi?id=174637
787
788         Reviewed by Sam Weinig.
789
790         For debugging convenience, adds a pretty-print type summary for StringView. Evaluating a
791         StringView object will print output that has the form:
792
793             (WTF::StringView) $4 = { length = 2, contents = 'li' } {
794               m_characters = 0x000000011b57abb5 "eeeeeefjh0n"
795               m_length = 2
796               m_is8Bit = true
797               m_underlyingString = 0x0000614000000a90
798             }
799
800         * lldb/lldb_webkit.py:
801         (__lldb_init_module): Use WTFStringView_SummaryProvider to format StringView types.
802         (WTFStringView_SummaryProvider):
803         (WTFStringViewProvider):
804         (WTFStringViewProvider.__init__):
805         (WTFStringViewProvider.is_8bit): Access field StringView.m_is8Bit.
806         (WTFStringViewProvider.get_length): Access field StringView.m_length.
807         (WTFStringViewProvider.get_characters): Access field StringView.m_characters.
808         (WTFStringViewProvider.to_string): Returns the string represented by the StringView.
809
810 2017-07-18  Andy Estes  <aestes@apple.com>
811
812         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
813         https://bugs.webkit.org/show_bug.cgi?id=174631
814
815         Reviewed by Dan Bernstein.
816
817         * DumpRenderTree/mac/Configurations/Base.xcconfig:
818         * MiniBrowser/Configurations/Base.xcconfig:
819         * MobileMiniBrowser/Configurations/Base.xcconfig:
820         * TestWebKitAPI/Configurations/Base.xcconfig:
821         * WebKitTestRunner/Configurations/Base.xcconfig:
822
823 2017-07-18  Devin Rousso  <drousso@apple.com>
824
825         Web Inspector: Add memoryCost to Inspector Protocol objects
826         https://bugs.webkit.org/show_bug.cgi?id=174478
827
828         Reviewed by Joseph Pecoraro.
829
830         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
831         * TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp: Added.
832         (TestWebKitAPI::TEST(InspectorValue, MemoryCostNull)):
833         (TestWebKitAPI::TEST(InspectorValue, MemoryCostBoolean)):
834         (TestWebKitAPI::TEST(InspectorValue, MemoryCostDouble)):
835         (TestWebKitAPI::TEST(InspectorValue, MemoryCostInteger)):
836         (TestWebKitAPI::TEST(InspectorValue, MemoryCostString)):
837         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringEmpty)):
838         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringNull)):
839         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringGrowing)):
840         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringUnicode)):
841         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObject)):
842         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectEmpty)):
843         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectGrowing)):
844         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArray)):
845         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayEmpty)):
846         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayGrowing)):
847
848 2017-07-18  Andy Estes  <aestes@apple.com>
849
850         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
851         https://bugs.webkit.org/show_bug.cgi?id=174631
852
853         Reviewed by Darin Adler.
854
855         * DumpRenderTree/mac/Configurations/Base.xcconfig:
856         * MiniBrowser/Configurations/Base.xcconfig:
857         * MobileMiniBrowser/Configurations/Base.xcconfig:
858         * TestWebKitAPI/Configurations/Base.xcconfig:
859         * WebKitTestRunner/Configurations/Base.xcconfig:
860
861 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
862
863         Unreviewed, fix the iOS build.
864
865         I missed a spot when renaming -synchronouslyLoadHTML: to -synchronouslyLoadHTMLString:.
866
867         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
868         (TestWebKitAPI::TEST):
869
870 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
871
872         [iOS DnD] Web process uses too much memory when beginning a drag on a very large image
873         https://bugs.webkit.org/show_bug.cgi?id=174585
874         <rdar://problem/33302541>
875
876         Reviewed by Tim Horton.
877
878         Adds a new test verifying that we don't try to allocate any image buffer equal to the true size of the image
879         being dragged when initiating a drag.
880
881         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
882         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Added.
883         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
884         (TestWebKitAPI::TEST):
885         * TestWebKitAPI/cocoa/TestWKWebView.h:
886
887         Add a new -synchronouslyLoadHTMLString: helper that works like -synchronouslyLoadTestPage:, but takes markup.
888
889         * TestWebKitAPI/cocoa/TestWKWebView.mm:
890         (-[TestWKWebView synchronouslyLoadHTMLString:]):
891
892 2017-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
893
894         [CMake] Macros in WebKitMacros.cmake should be prefixed with WEBKIT_ namespace
895         https://bugs.webkit.org/show_bug.cgi?id=174547
896
897         Reviewed by Alex Christensen.
898
899         * DumpRenderTree/PlatformWin.cmake:
900         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
901
902 2017-07-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
903
904         Update style checker to deal with "final"
905         https://bugs.webkit.org/show_bug.cgi?id=174528
906
907         Reviewed by Alex Christensen.
908         
909         check-webkit-style shouldn't complain about an open brace to start a
910         line after a function definition with "final" or "const final".
911
912         * Scripts/webkitpy/style/checkers/cpp.py:
913         (check_braces):
914         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
915         (CppStyleTest.test_brace_at_begin_of_line):
916
917 2017-07-17  Alex Christensen  <achristensen@webkit.org>
918
919         Modernize content extension code
920         https://bugs.webkit.org/show_bug.cgi?id=174588
921
922         Reviewed by Sam Weinig.
923
924         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
925         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
926         (TestWebKitAPI::testRequest):
927         (TestWebKitAPI::makeBackend):
928         (TestWebKitAPI::TEST_F):
929
930 2017-07-17  Brady Eidson  <beidson@apple.com>
931
932         WKHTTPCookieStore observing only works on the default cookie store.
933         <rdar://problem/33330724> and https://bugs.webkit.org/show_bug.cgi?id=174580
934
935         Reviewed by Sam Weinig.
936
937         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
938         (runTestWithWebsiteDataStore): Refactor the cookie observing test out so it can be
939           called for the default store, a non-persistent store, and a custom store.
940         (TEST):
941
942 2017-07-16  Sam Weinig  <sam@webkit.org>
943
944         [Scripts] Fix missing variable warnings from svn-create-patch when there are untracked files
945         https://bugs.webkit.org/show_bug.cgi?id=174575
946
947         Reviewed by Brady Eidson.
948
949         * Scripts/svn-create-patch:
950         (findModificationType):
951         Add support for more status codes. C -> conflicted, ? -> untracked, ! -> missing. Give a
952         default value of "unknown".
953
954         (generateFileList):
955         Handle all the new modification types. Abort on conflicted, missing, and unknown. Log
956         for untracked, which matches our old behavior.
957
958 2017-07-17  Charlie Turner  <cturner@igalia.com>
959
960         Add some missing build dependencies on Fedora
961         https://bugs.webkit.org/show_bug.cgi?id=174578
962
963         Unreviewed dependency update.
964
965         * gtk/install-dependencies:
966
967 2017-07-16  Brady Eidson  <beidson@apple.com>
968
969         Crash when a WKHTTPCookieStore outlives its owning WKWebsiteDataStore.
970         <rdar://problem/33341730> and https://bugs.webkit.org/show_bug.cgi?id=174574
971
972         Reviewed by Tim Horton.
973
974         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
975         (-[CookieNavigationDelegate webView:didFinishNavigation:]):
976         (TEST):
977
978 2017-07-16  Bernhard M. Wiedemann  <bwiedemann@suse.de>
979
980         [GTK] Sort inspector GResource manifest to ensure reproducible builds
981         https://bugs.webkit.org/show_bug.cgi?id=174540
982
983         Reviewed by Michael Catanzaro.
984
985         * gtk/generate-inspector-gresource-manifest.py:
986         (get_filenames): sort list of input files
987
988 2017-07-15  Brady Eidson  <beidson@apple.com>
989
990         Make sure all CFHTTPCookieStorageRefs we create are scheduled.
991         <rdar://problem/33221110> and https://bugs.webkit.org/show_bug.cgi?id=174513
992
993         Reviewed by Tim Horton.
994
995         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
996         (TEST): Make this test more reliable by clearing everything beforehand.
997
998 2017-07-15  David Kilzer  <ddkilzer@apple.com>
999
1000         Make it possible to extend check-webkit-style with Apple-internal checkers
1001         <https://webkit.org/b/174464>
1002         <rdar://problem/25564402>
1003
1004         Reviewed by Darin Adler.
1005
1006         * Scripts/webkitpy/style/checker.py: Import apple_additions.
1007         (_all_categories): Add categories from apple_additions() if it
1008         exists.
1009         (CheckerDispatcher._create_checker): Create python checker
1010         from apple_additions() if it exists.
1011
1012 2017-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1013
1014         [iOS WK2] Presenting an action sheet on an image map prevents selection UI from updating
1015         https://bugs.webkit.org/show_bug.cgi?id=174539
1016         <rdar://problem/33307395>
1017
1018         Reviewed by Darin Adler.
1019
1020         Adds a new unit test suite to cover action sheet popover presentation.
1021
1022         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1023         * TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Added.
1024         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm: Added.
1025         (-[ActionSheetObserver waitForActionSheetAfterBlock:]):
1026
1027         Runs the given block and waits until the UI process has indicated that it will present an action sheet.
1028
1029         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
1030         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1031
1032         Helper class to alter the behavior of [[UIDevice currentDevice] userInterfaceIdiom] for testing.
1033
1034         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1035         (TestWebKitAPI::TEST):
1036
1037 2017-07-15  Sam Weinig  <sam@webkit.org>
1038
1039         [Scripts] Make svn-create-patch work better when called in sub directories
1040         https://bugs.webkit.org/show_bug.cgi?id=174551
1041
1042         Reviewed by Darin Adler.
1043
1044         - Fixes manufacturePatchForAdditionWithHistory to use the correct path
1045           by ensuring that the prefix is applied as is done in generateDiff.
1046         - Silence output of explanatory lines from svn stat (" > move to ...")
1047           that show up in STDERR when running svn-create-patch.
1048         - Add verbose logging that I found useful while debugging this issue.
1049
1050         * Scripts/svn-create-patch:
1051         (findBaseUrl):
1052         (findMimeType):
1053         (findSourceFileAndRevision):
1054         (generateDiff):
1055         (generateFileList):
1056         (manufacturePatchForAdditionWithHistory):
1057
1058 2017-07-15  Jonathan Bedard  <jbedard@apple.com>
1059
1060         Unreviewed build fix after r219537.
1061
1062         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1063
1064 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
1065
1066         Add iOS 11 SPI
1067         https://bugs.webkit.org/show_bug.cgi?id=174430
1068         <rdar://problem/33269288>
1069
1070         Reviewed by Tim Horton.
1071
1072         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Define drag-and-drop API required for testing.
1073         * TestWebKitAPI/ios/DataInteractionSimulator.h: Ditto.
1074         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Ditto.
1075
1076 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
1077
1078         Failing to install on iPad simulators
1079         https://bugs.webkit.org/show_bug.cgi?id=174532
1080         <rdar://problem/33328347>
1081
1082         Reviewed by Stephanie Lewis.
1083
1084         * Scripts/webkitpy/xcode/simulated_device.py:
1085         (SimulatedDevice.install_app): Place install command in retry try-except block.
1086
1087 2017-07-14  Jeff Miller  <jeffm@apple.com>
1088
1089         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
1090         https://bugs.webkit.org/show_bug.cgi?id=174524
1091
1092         Reviewed by Sam Weinig.
1093
1094         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
1095         (TEST):
1096         Renamed TestParameter to TestParameter1.
1097         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
1098
1099         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
1100         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1101         Observe changes for two bundle parameters.
1102
1103         (-[BundleParametersPlugIn dealloc]):
1104         Remove observers for two bundle parameters.
1105
1106 2017-07-14  Commit Queue  <commit-queue@webkit.org>
1107
1108         Unreviewed, rolling out r219510.
1109         https://bugs.webkit.org/show_bug.cgi?id=174525
1110
1111         Need to revert length() == 0 check for null string (Requested
1112         by yusukesuzuki on #webkit).
1113
1114         Reverted changeset:
1115
1116         "[WTF] Newly added AtomicStringImpl should use BufferInternal
1117         static string if StringImpl is static"
1118         https://bugs.webkit.org/show_bug.cgi?id=174501
1119         http://trac.webkit.org/changeset/219510
1120
1121 2017-07-14  Jer Noble  <jer.noble@apple.com>
1122
1123         [MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
1124         https://bugs.webkit.org/show_bug.cgi?id=174514
1125
1126         Reviewed by Sam Weinig.
1127
1128         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
1129         (TestWebKitAPI::TEST_F):
1130
1131 2017-07-14  Yusuke Suzuki  <utatane.tea@gmail.com>
1132
1133         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
1134         https://bugs.webkit.org/show_bug.cgi?id=174501
1135
1136         Reviewed by Darin Adler.
1137
1138         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1139         (TestWebKitAPI::TEST):
1140
1141 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
1142
1143         Bring mac expectations in-line with other platforms
1144         https://bugs.webkit.org/show_bug.cgi?id=174472
1145         <rdar://problem/33297388>
1146
1147         Reviewed by David Kilzer.
1148
1149         The override order for Mac test expectations does not conform to the pattern used by iOS,
1150         GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
1151
1152             platform/mac-wk2
1153             platform/wk2
1154             platform/mac-elcapitan
1155             platform/mac-sierra
1156             generic
1157
1158         After this change, El Capitan's baseline search path looks like this:
1159
1160             platform/mac-sierra-wk2
1161             platform/mac-sierra
1162             platform/mac-wk2
1163             platform/wk2
1164             generic
1165
1166         * Scripts/webkitpy/port/mac.py:
1167         (MacPort.__init__): If a specific version is specified in the port name, use that
1168         as the os version.
1169         (MacPort.default_baseline_search_path): Expectation search paths should work the
1170         same way they do on other ports. Port + version overrides port, port overrides generic
1171         and wk1/wk2 should override expectations for the two combined.
1172         * Scripts/webkitpy/port/mac_unittest.py:
1173         (MacTest.test_tests_for_other_platforms): Deleted.
1174         (MacTest._assert_search_path): Deleted.
1175         (MacTest.test_baseline_search_path): Deleted.
1176         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1177         (TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
1178         (test_rebaseline_test_and_print_scm_changes): Ditto.
1179         (test_rebaseline_and_copy_test): Ditto.
1180         (test_rebaseline_and_copy_test_no_existing_result): Ditto.
1181         (test_rebaseline_and_copy_test_with_lion_result): Ditto.
1182         (test_rebaseline_and_copy_no_overwrite_test): Ditto.
1183
1184 2017-07-13  Michael Catanzaro  <mcatanzaro@igalia.com>
1185
1186         Fix style checker unit test
1187
1188         Unreviewed WebKit2 => WebKit fixup.
1189
1190         * Scripts/webkitpy/style/checker_unittest.py:
1191         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
1192
1193 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1194
1195         Use the old WebKit/WebKit2 targets for CMake builds. (v2)
1196
1197         Unreviewed build fix.
1198
1199         r219492 missed one hunk from its partial revert of r219489.
1200         This patch reverts that hunk.
1201
1202         * TestWebKitAPI/CMakeLists.txt:
1203
1204 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1205
1206         Use the old WebKit/WebKit2 targets for CMake builds.
1207
1208         Unreviewed build fix.
1209
1210         We can update the target names to match the Framework names in a future patch.
1211         This is a partial revert of r219489.
1212
1213         * TestWebKitAPI/CMakeLists.txt:
1214         WebKitLegacy => WebKit
1215         WebKit => WebKit2
1216
1217 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1218
1219         Fix TestWebKit API.
1220         https://bugs.webkit.org/show_bug.cgi?id=174164
1221         rdar://problem/33137595
1222
1223         Reviewed by Dan Bernstein.
1224
1225         * TestWebKitAPI/CMakeLists.txt:
1226         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1227         * TestWebKitAPI/PlatformGTK.cmake:
1228
1229 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1230
1231         Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
1232         https://bugs.webkit.org/show_bug.cgi?id=174164
1233         rdar://problem/33137595
1234
1235         Reviewed by Dan Bernstein.
1236
1237         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1238         (ShouldBuildTest):
1239         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1240         * Scripts/build-webkit:
1241         * Scripts/do-file-rename:
1242         * Scripts/do-webcore-rename:
1243         * Scripts/update-webkit-localizable-strings:
1244         * Scripts/webkitpy/common/config/watchlist:
1245         * Scripts/webkitpy/style/checker.py:
1246         * Scripts/webkitpy/style/checkers/featuredefines.py:
1247         * gtk/make-dist.py:
1248         (ensure_version_if_possible):
1249         * gtk/manifest.txt.in:
1250
1251 2017-07-05  Matthew Hanson  <matthew_hanson@apple.com>
1252
1253         Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
1254         https://bugs.webkit.org/show_bug.cgi?id=174162
1255         rdar://problem/33137594
1256
1257         Reviewed by Dan Bernstein.
1258
1259         Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource tooling.
1260
1261         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1262         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
1263         * EWSTools/configure-clang-linux.sh:
1264         * Scripts/build-webkit:
1265         * Scripts/do-file-rename:
1266         * Scripts/do-webcore-rename:
1267         * Scripts/update-webkit-localizable-strings:
1268         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1269         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
1270         * Scripts/webkitpy/style/checkers/featuredefines.py:
1271         * gtk/manifest.txt.in:
1272
1273 2017-07-13  Jonathan Bedard  <jbedard@apple.com>
1274
1275         Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
1276         https://bugs.webkit.org/show_bug.cgi?id=174438
1277         <rdar://problem/33277112>
1278
1279         Reviewed by Aakash Jain.
1280
1281         Given a patch, this will convert the changes from the path to the new directory structure.
1282
1283         * Scripts/rebase-patch-after-webkit-move: Added.
1284         (append_source): Append 'Source' to the provided path.
1285         (is_editable_line): Return true if a line the script expects to modify.
1286         (needs_rebase): Return if a line needs to be rebased based on it's content.
1287         (rebase_line): Rebase the provided line.
1288         (rebase): Rebase a patch given the lines of that patch and a file to output the rebased patch to.
1289         (parse_arguments): Parse the command line arguments and return the patches to be rebased, if they
1290         were provided.
1291
1292 2017-07-12  Nan Wang  <n_wang@apple.com>
1293
1294         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
1295         https://bugs.webkit.org/show_bug.cgi?id=174393
1296         <rdar://problem/33248006>
1297
1298         Reviewed by Chris Fleizach.
1299
1300         * DumpRenderTree/AccessibilityUIElement.cpp:
1301         (textMarkerRangeMatchesTextNearMarkersCallback):
1302         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1303         (AccessibilityUIElement::getJSClass):
1304         * DumpRenderTree/AccessibilityUIElement.h:
1305         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1306         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1307         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1308         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1309         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1310         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1311         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1312         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1313
1314 2017-07-12  Matt Lewis  <jlewis3@apple.com>
1315
1316         Unreviewed, rolling out r219409.
1317
1318         The revision caused the Windows builds to fail.
1319
1320         Reverted changeset:
1321
1322         "AX: [iOS] Implement a way to retrieve a text marker range
1323         with desired text that is closest to a position"
1324         https://bugs.webkit.org/show_bug.cgi?id=174393
1325         http://trac.webkit.org/changeset/219409
1326
1327 2017-07-12  Nan Wang  <n_wang@apple.com>
1328
1329         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
1330         https://bugs.webkit.org/show_bug.cgi?id=174393
1331         <rdar://problem/33248006>
1332
1333         Reviewed by Chris Fleizach.
1334
1335         * DumpRenderTree/AccessibilityUIElement.cpp:
1336         (textMarkerRangeMatchesTextNearMarkersCallback):
1337         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1338         (AccessibilityUIElement::getJSClass):
1339         * DumpRenderTree/AccessibilityUIElement.h:
1340         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1341         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1342         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1343         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1344         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1345         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1346         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1347         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1348
1349 2017-07-12  Emilio Cobos Álvarez  <ecobos@igalia.com>
1350
1351         Make prepare-ChangeLog -g <commit> generate a more standard ChangeLog entry.
1352         https://bugs.webkit.org/show_bug.cgi?id=174197
1353
1354         Reviewed by Darin Adler.
1355
1356         This bit me the first time I tried to submit a patch to WebKit, and still I have
1357         to manually edit the ChangeLog every time I use the script.
1358
1359         This generates a more convenient and standard ChangeLog entry.
1360
1361         * Scripts/prepare-ChangeLog:
1362         (generateNewChangeLogs):
1363
1364 2017-07-12  Matt Lewis  <jlewis3@apple.com>
1365
1366         Unreviewed, rolling out r219401.
1367
1368         This revision rolled out the previous patch, but after talking
1369         with reviewer, a rebaseline is what was needed.Rolling back in
1370         before rebaseline.
1371
1372         Reverted changeset:
1373
1374         "Unreviewed, rolling out r219379."
1375         https://bugs.webkit.org/show_bug.cgi?id=174400
1376         http://trac.webkit.org/changeset/219401
1377
1378 2017-07-12  Matt Lewis  <jlewis3@apple.com>
1379
1380         Unreviewed, rolling out r219379.
1381
1382         This revision caused a consistent failure in the test
1383         fast/dom/Window/property-access-on-cached-window-after-frame-
1384         removed.html.
1385
1386         Reverted changeset:
1387
1388         "Remove NAVIGATOR_HWCONCURRENCY"
1389         https://bugs.webkit.org/show_bug.cgi?id=174400
1390         http://trac.webkit.org/changeset/219379
1391
1392 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
1393
1394         [WPE] Use libepoxy
1395         https://bugs.webkit.org/show_bug.cgi?id=172104
1396
1397         Reviewed by Michael Catanzaro.
1398
1399         * WebKitTestRunner/wpe/HeadlessViewBackend.h:
1400         Include the <epoxy/egl.h> header, dropping the EGL and GLES2 inclusions.
1401
1402 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
1403
1404         [GTK][WPE] Align Jhbuild patches for GStreamer packages
1405         https://bugs.webkit.org/show_bug.cgi?id=174363
1406
1407         Reviewed by Michael Catanzaro.
1408
1409         Align the patches we apply over Jhbuild-managed GStreamer dependency packages
1410         between the GTK+ and WPE port. There's no reason for the two ports to apply
1411         different patches over same versions of GStreamer releases.
1412
1413         This aligns the two ports on this specific issue. Next we'll look into
1414         creating a single GStreamer-specific Jhbuild moduleset that will allow us
1415         to keep these patches in a single place, avoiding duplicate files.
1416
1417         * gtk/jhbuild.modules:
1418         * gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
1419         * gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch.
1420         * gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
1421         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Removed.
1422
1423 2017-07-11  Dean Jackson  <dino@apple.com>
1424
1425         Remove NAVIGATOR_HWCONCURRENCY
1426         https://bugs.webkit.org/show_bug.cgi?id=174400
1427
1428         Reviewed by Sam Weinig.
1429
1430         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1431
1432 2017-07-11  Ansh Shukla  <ansh_shukla@apple.com>
1433
1434         WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration properties
1435         https://bugs.webkit.org/show_bug.cgi?id=174239
1436
1437         Reviewed by Brady Eidson.
1438
1439         Create windows with specific features set and make sure those are properly reflected in the
1440         WKWindowFeatures object.
1441
1442         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
1443         (resetToConsistentState):
1444         (-[CheckWindowFeaturesUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1445         (TEST):
1446
1447 2017-07-11  Jonathan Bedard  <jbedard@apple.com>
1448
1449         Do not duplicate files when deleting directories with svn 1.9
1450         https://bugs.webkit.org/show_bug.cgi?id=174339
1451         <rdar://problem/33226781>
1452
1453         Reviewed by David Kilzer.
1454
1455         * Scripts/svn-create-patch:
1456         (diffOptionsForFile): No longer pass -N option, since this does not work in SVN 1.9.4.
1457         (generateFileList): Determine which files are deleted because they are part of a
1458         directory being deleted.
1459
1460 2017-07-11  Dean Jackson  <dino@apple.com>
1461
1462         Rolling out r219372.
1463
1464         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1465
1466 2017-07-11  Dean Jackson  <dino@apple.com>
1467
1468         Remove NAVIGATOR_HWCONCURRENCY
1469         https://bugs.webkit.org/show_bug.cgi?id=174400
1470
1471         Reviewed by Sam Weinig.
1472
1473         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1474
1475 2017-07-11  Lucas Forschler  <lforschler@apple.com>
1476
1477         Teach build workers to fetch archives from S3.
1478         https://bugs.webkit.org/show_bug.cgi?id=174384
1479
1480         Reviewed by Aakash Jain.
1481
1482         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1483         (DownloadBuiltProduct):
1484
1485 2017-07-11  Lucas Forschler  <lforschler@apple.com>
1486
1487         Configure buildbot to transfer all archives to S3.
1488         Previously this was Mac only, but it's time to expand!
1489         https://bugs.webkit.org/show_bug.cgi?id=174378
1490         
1491         Reviewed by Aakash Jain.
1492
1493         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1494         (BuildFactory.__init__):
1495
1496 2017-07-11  Zan Dobersek  <zdobersek@igalia.com>
1497
1498         [WPE] Bump GStreamer packages in jhbuild.modules to 1.10.5
1499         https://bugs.webkit.org/show_bug.cgi?id=174350
1500
1501         Reviewed by Xabier Rodriguez-Calvar.
1502
1503         Bump the various GStreamer dependencies listed in WPE's Jhbuild modules file
1504         to the 1.10.5 version. One gstreamer patch is added. The two gst-plugins-bad
1505         patches are removed. The patches for gst-plugins-good are updated, removing
1506         the stale ones and adding the additional changes to qtdemux, souphttpsrc and
1507         rtpbin elements that will help with the EMEv3 development.
1508
1509         * wpe/jhbuild.modules:
1510         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
1511         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
1512         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added.
1513         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
1514         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Added.
1515         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
1516         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
1517         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
1518         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
1519
1520 2017-07-10  John Wilander  <wilander@apple.com>
1521
1522         Resource Load Statistics: Prune statistics in orders of importance
1523         https://bugs.webkit.org/show_bug.cgi?id=174215
1524         <rdar://problem/33164403>
1525
1526         Reviewed by Chris Dumez.
1527
1528         Nest infrastructure. Adds these functions:
1529         1. testRunner.setStatisticsLastSeen()
1530         2. setStatisticsMaxStatisticsEntries()
1531         3. setStatisticsPruneEntriesDownTo()
1532
1533         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1534         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1535         (WTR::TestRunner::setStatisticsLastSeen):
1536         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
1537         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
1538         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1539         * WebKitTestRunner/TestController.cpp:
1540         (WTR::TestController::setStatisticsLastSeen):
1541         (WTR::TestController::setMaxStatisticsEntries):
1542         (WTR::TestController::setPruneEntriesDownTo):
1543         * WebKitTestRunner/TestController.h:
1544         * WebKitTestRunner/TestInvocation.cpp:
1545         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1546         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1547         (WTR::TestController::setStatisticsLastSeen):
1548         (WTR::TestController::setStatisticsMaxStatisticsEntries):
1549         (WTR::TestController::setStatisticsPruneEntriesDownTo):
1550
1551 2017-07-03  Brian Burg  <bburg@apple.com>
1552
1553         Web Replay: remove some unused code
1554         https://bugs.webkit.org/show_bug.cgi?id=173903
1555
1556         Rubber-stamped by Joseph Pecoraro.
1557
1558         * Scripts/run-input-generator-tests: Removed.
1559         * Scripts/webkitpy/replay/__init__.py: Removed.
1560         * Scripts/webkitpy/replay/main.py: Removed.
1561
1562 2017-07-10  Zan Dobersek  <zdobersek@igalia.com>
1563
1564         [WPE] Fix layout test baseline and TestExpectations hierarchy
1565         https://bugs.webkit.org/show_bug.cgi?id=174092
1566
1567         Reviewed by Michael Catanzaro.
1568
1569         Like for the GTK+ port, override the default_baseline_search_path() and
1570         _port_specific_expectations_files() methods in the webkitpy.port.WPEPort class.
1571         Both methods operate on a short list of search paths that defaults to 'wpe' and
1572         'wk2', along with any other user-specified platform directory.
1573
1574         The test_expectations_file_position() method is overridden for testing purposes,
1575         and relevant unit tests are added.
1576
1577         * Scripts/webkitpy/port/wpe.py:
1578         (WPEPort._search_paths):
1579         (WPEPort):
1580         (WPEPort.default_baseline_search_path):
1581         (WPEPort._port_specific_expectations_files):
1582         (WPEPort.test_expectations_file_position):
1583         * Scripts/webkitpy/port/wpe_unittest.py:
1584         (WPEPortTest.test_default_baseline_search_path):
1585         (WPEPortTest):
1586         (WPEPortTest.test_port_specific_expectations_files):
1587
1588 2017-07-10  Chris Dumez  <cdumez@apple.com>
1589
1590         Further WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore clean up
1591         https://bugs.webkit.org/show_bug.cgi?id=174301
1592
1593         Reviewed by Brent Fulgham.
1594
1595         Rename some of the testRunner API for clarity and to better match what it calls
1596         internally.
1597
1598         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1599         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1600         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
1601         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
1602         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1603         * WebKitTestRunner/TestController.cpp:
1604         (WTR::TestController::statisticsUpdateCookiePartitioning):
1605         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
1606         * WebKitTestRunner/TestController.h:
1607         * WebKitTestRunner/TestInvocation.cpp:
1608         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1609         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1610         (WTR::TestController::statisticsUpdateCookiePartitioning):
1611         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
1612
1613 2017-07-10  Charlie Turner  <cturner@igalia.com>
1614
1615         [GStreamer] Live twitch.tv videos do not play
1616         https://bugs.webkit.org/show_bug.cgi?id=174222
1617
1618         Reviewed by Michael Catanzaro.
1619
1620         Upgrade GStreamer to 1.10.5. It contains a change to typefind that
1621         fixes videos not playing on twitch.tv.
1622
1623         * gtk/jhbuild.modules:
1624
1625 2017-07-09  Zan Dobersek  <zdobersek@igalia.com>
1626
1627         Add WebGL2 configuration option to build-webkit
1628         https://bugs.webkit.org/show_bug.cgi?id=174251
1629
1630         Reviewed by Michael Catanzaro.
1631
1632         * Scripts/webkitperl/FeatureList.pm: Add the 'webgl2' option, making it possible
1633         to enable the ENABLE_WEBGL2 flag through the build-webkit script. The feature
1634         is marked as enabled for the Apple Cocoa ports.
1635
1636 2017-07-08  Chris Dumez  <cdumez@apple.com>
1637
1638         Simplify WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore
1639         https://bugs.webkit.org/show_bug.cgi?id=174290
1640
1641         Reviewed by Brent Fulgham.
1642
1643         Rename testRunner API to match the new internal API names.
1644
1645         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1646         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1647         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
1648         (WTR::TestRunner::statisticsSubmitTelemetry):
1649         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1650         * WebKitTestRunner/TestController.cpp:
1651         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1652         (WTR::TestController::statisticsSubmitTelemetry):
1653         * WebKitTestRunner/TestController.h:
1654         * WebKitTestRunner/TestInvocation.cpp:
1655         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1656         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1657         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1658         (WTR::TestController::statisticsSubmitTelemetry):
1659
1660 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1661
1662         Drop NOSNIFF compile flag
1663         https://bugs.webkit.org/show_bug.cgi?id=174289
1664
1665         Reviewed by Michael Catanzaro.
1666
1667         * Scripts/webkitperl/FeatureList.pm:
1668         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1669
1670 2017-07-07  Wenson Hsieh  <wenson_hsieh@apple.com>
1671
1672         [iOS DnD] For cross-app drags, 'drop' event handlers are never invoked if dataTransfer.dropEffect is not set while dragging
1673         https://bugs.webkit.org/show_bug.cgi?id=174219
1674         <rdar://problem/32083177>
1675
1676         Reviewed by Ryosuke Niwa.
1677
1678         Add plumbing and support to mock the value of -allowsMoveOperation on the simulated UIDragDropSession objects.
1679         Setting the DataInteractionSimulator's shouldAllowMoveOperation property to NO simulates a drag operation coming
1680         in from another app out-of-process, for which move operations won't cause a drop to be performed in the first
1681         place.
1682
1683         Also tweaks 2 existing unit tests regarding file uploads via JavaScript to simulate items coming in from a
1684         different application, and adds a new test to check that if a drop area specifically requests a MOVE operation,
1685         no action is taken when dropping.
1686
1687         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html:
1688         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1689         (TestWebKitAPI::TEST):
1690         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1691         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1692         (-[MockDragDropSession initWithItems:location:window:allowMove:]):
1693         (-[MockDragDropSession allowsMoveOperation]):
1694         (-[MockDataOperationSession initWithProviders:location:window:allowMove:]):
1695         (-[MockDataInteractionSession initWithWindow:allowMove:]):
1696         (-[DataInteractionSimulator initWithWebView:]):
1697         (-[DataInteractionSimulator runFrom:to:]):
1698         (-[DataInteractionSimulator _advanceProgress]):
1699         (-[MockDragDropSession initWithItems:location:window:]): Deleted.
1700         (-[MockDataOperationSession initWithProviders:location:window:]): Deleted.
1701         (-[MockDataInteractionSession initWithWindow:]): Deleted.
1702
1703 2017-07-07  Commit Queue  <commit-queue@webkit.org>
1704
1705         Unreviewed, rolling out r219238, r219239, and r219241.
1706         https://bugs.webkit.org/show_bug.cgi?id=174265
1707
1708         "fast/workers/dedicated-worker-lifecycle.html is flaky"
1709         (Requested by yusukesuzuki on #webkit).
1710
1711         Reverted changesets:
1712
1713         "[WTF] Implement WTF::ThreadGroup"
1714         https://bugs.webkit.org/show_bug.cgi?id=174081
1715         http://trac.webkit.org/changeset/219238
1716
1717         "Unreviewed, build fix after r219238"
1718         https://bugs.webkit.org/show_bug.cgi?id=174081
1719         http://trac.webkit.org/changeset/219239
1720
1721         "Unreviewed, CLoop build fix after r219238"
1722         https://bugs.webkit.org/show_bug.cgi?id=174081
1723         http://trac.webkit.org/changeset/219241
1724
1725 2017-07-07  Yusuke Suzuki  <utatane.tea@gmail.com>
1726
1727         [GTK][WPE] Enable X-Content-Type-Options: nosniff
1728         https://bugs.webkit.org/show_bug.cgi?id=174250
1729
1730         Reviewed by Carlos Alberto Lopez Perez.
1731
1732         * Scripts/webkitperl/FeatureList.pm:
1733
1734 2017-07-07  Charlie Turner  <cturner@igalia.com>
1735         [GStreamer] vid.me videos do not play
1736         https://bugs.webkit.org/show_bug.cgi?id=172240
1737
1738         Reviewed by Xabier Rodriguez-Calvar.
1739
1740         Build httpsoupsrc again for use in adaptive streaming pipelines, and
1741         have the existing libsoup build against GNOME to avoid header drift
1742         against GStreamer's linked Soup library.
1743
1744         * gtk/jhbuild.modules:
1745
1746 2017-07-06  Lucas Forschler  <lforschler@apple.com>
1747
1748         Write a support script to enable buildbot to upload to S3
1749         https://bugs.webkit.org/show_bug.cgi?id=174196
1750         
1751         Reviewed by Stephanie Lewis.
1752
1753         * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Added.
1754         (uploadToS3):
1755         (archiveExists):
1756
1757 2017-07-06  Lucas Forschler  <lforschler@apple.com>
1758
1759         Enabling uploading archives to S3.
1760         https://bugs.webkit.org/show_bug.cgi?id=174198
1761         
1762         Reviewed by Stephanie Lewis.
1763
1764         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1765         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
1766         (UploadMinifiedBuiltProduct): Upload minified archive to build master
1767         (TransferToS3): Transfer full and minified archives to S3
1768
1769 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1770
1771         [WTF] Implement WTF::ThreadGroup
1772         https://bugs.webkit.org/show_bug.cgi?id=174081
1773
1774         Reviewed by Mark Lam.
1775
1776         Add WTF::ThreadGroup tests.
1777
1778         * TestWebKitAPI/CMakeLists.txt:
1779         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1780         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
1781         (TestWebKitAPI::TEST):
1782
1783 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
1784
1785         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
1786         https://bugs.webkit.org/show_bug.cgi?id=174150
1787
1788         Reviewed by Mark Lam.
1789
1790         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1791         (TestWebKitAPI::TEST):
1792         * TestWebKitAPI/TestsController.cpp:
1793         (TestWebKitAPI::TestsController::TestsController):
1794
1795 2017-07-06  Lucas Forschler  <lforschler@apple.com>
1796
1797         Enabling uploading archives to S3.
1798         https://bugs.webkit.org/show_bug.cgi?id=174198
1799         
1800         Reviewed by Lucas Forschler.
1801
1802         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1803         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
1804         (UploadMinifiedBuiltProduct): Upload minified archive to build master
1805         (TransferToS3): Transfer full and minified archives to S3
1806
1807 2017-07-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1808
1809         [GTK][WPE] kill-old-process should kill more webkit related process
1810         https://bugs.webkit.org/show_bug.cgi?id=174220
1811
1812         Reviewed by Michael Catanzaro.
1813
1814         Generate list of possible webkit-related process names and add
1815         them to the list of process to kill.
1816         Also update the possible system related process for GTK+/WPE.
1817
1818         * BuildSlaveSupport/kill-old-processes:
1819         (listAllWebKitPrograms):
1820         (main):
1821
1822 2017-07-06  Chris Dumez  <cdumez@apple.com>
1823
1824         FileMonitor should not be ref counted
1825         https://bugs.webkit.org/show_bug.cgi?id=174166
1826
1827         Reviewed by Brent Fulgham.
1828
1829         Update the API tests to reflect the API change.
1830
1831         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1832         (TestWebKitAPI::TEST_F):
1833
1834 2017-07-06  Commit Queue  <commit-queue@webkit.org>
1835
1836         Unreviewed, rolling out r219194.
1837         https://bugs.webkit.org/show_bug.cgi?id=174207
1838
1839         it broke some layout tests (Requested by clopez on #webkit).
1840
1841         Reverted changeset:
1842
1843         "[GStreamer] vid.me videos do not play"
1844         https://bugs.webkit.org/show_bug.cgi?id=172240
1845         http://trac.webkit.org/changeset/219194
1846
1847 2017-07-06  Matt Lewis  <jlewis3@apple.com>
1848
1849         Unreviewed, rolling out r219178.
1850
1851         This caused a consistent failure with the API test
1852         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
1853
1854         Reverted changeset:
1855
1856         "[WTF] Clean up StringStatics.cpp by using
1857         LazyNeverDestroyed<> for Atoms"
1858         https://bugs.webkit.org/show_bug.cgi?id=174150
1859         http://trac.webkit.org/changeset/219178
1860
1861 2017-07-06  Alicia Boya García  <aboya@igalia.com>
1862
1863         Add CWD to Perl library path (no longer the default since 5.26.0)
1864         https://bugs.webkit.org/show_bug.cgi?id=174200
1865
1866         Reviewed by Michael Catanzaro.
1867
1868         * Scripts/webkitpy/tool/commands/setupgitclone.py:
1869         (SetupGitClone._get_username_and_email):
1870
1871 2017-07-06  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1872
1873         Unreviewed, update my email address.
1874
1875         * Scripts/webkitpy/common/config/contributors.json:
1876
1877 2017-07-06  Charlie Turner  <cturner@igalia.com>
1878         [GStreamer] vid.me videos do not play
1879         https://bugs.webkit.org/show_bug.cgi?id=172240
1880
1881         Reviewed by Xabier Rodriguez-Calvar.
1882
1883         Build httpsoupsrc again for use in adaptive streaming pipelines, and
1884         have the existing libsoup build against GNOME to avoid header drift
1885         against GStreamer's linked Soup library.
1886
1887         * gtk/jhbuild.modules:
1888
1889 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
1890
1891         [WTF] Move SoftLinking.h into WTF
1892         https://bugs.webkit.org/show_bug.cgi?id=174000
1893
1894         Reviewed by Alex Christensen.
1895
1896         * DumpRenderTree/mac/TestRunnerMac.mm:
1897         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1898         (test_primary_header):
1899         (ErrorCollector.__init__): Deleted.
1900         (ErrorCollector.__call__): Deleted.
1901         (ErrorCollector.results): Deleted.
1902         (ErrorCollector.result_list): Deleted.
1903         (ErrorCollector.verify_all_categories_are_seen): Deleted.
1904         (MockIo.open): Deleted.
1905         (CppFunctionsTest.test_convert_to_lower_with_underscores): Deleted.
1906         (CppFunctionsTest.test_create_acronym): Deleted.
1907         (CppFunctionsTest.test_is_c_or_objective_c): Deleted.
1908         (CppFunctionsTest.test_parameter): Deleted.
1909         (CppFunctionsTest.test_single_line_view): Deleted.
1910         (CppFunctionsTest.test_create_skeleton_parameters): Deleted.
1911         (CppFunctionsTest.test_find_parameter_name_index): Deleted.
1912         (CppFunctionsTest.test_parameter_list): Deleted.
1913         (CppFunctionsTest.test_check_parameter_against_text): Deleted.
1914         (CppStyleTestBase.process_file_data): Deleted.
1915         (CppStyleTestBase.perform_lint): Deleted.
1916         (CppStyleTestBase.perform_single_line_lint): Deleted.
1917         (CppStyleTestBase.perform_multi_line_lint): Deleted.
1918         (CppStyleTestBase.perform_language_rules_check): Deleted.
1919         (CppStyleTestBase.perform_function_lengths_check): Deleted.
1920         (CppStyleTestBase.perform_pass_ptr_check): Deleted.
1921         (CppStyleTestBase.perform_leaky_pattern_check): Deleted.
1922         (CppStyleTestBase.perform_include_what_you_use): Deleted.
1923         (CppStyleTestBase.perform_header_guard_check): Deleted.
1924         (CppStyleTestBase.assert_lint): Deleted.
1925         (CppStyleTestBase.assert_lint_one_of_many_errors_re): Deleted.
1926         (CppStyleTestBase.assert_multi_line_lint): Deleted.
1927         (CppStyleTestBase.assert_multi_line_lint_re): Deleted.
1928         (CppStyleTestBase.assert_language_rules_check): Deleted.
1929         (CppStyleTestBase.assert_include_what_you_use): Deleted.
1930         (CppStyleTestBase.assert_header_guard): Deleted.
1931         (CppStyleTestBase.assert_blank_lines_check): Deleted.
1932         (CppStyleTestBase.assert_positions_equal): Deleted.
1933         (FunctionDetectionTest.test_basic_function_detection): Deleted.
1934         (FunctionDetectionTest.test_function_declaration_detection): Deleted.
1935         (FunctionDetectionTest.test_pure_function_detection): Deleted.
1936         (FunctionDetectionTest.test_override_and_final_function_detection): Deleted.
1937         (FunctionDetectionTest.test_ignore_macros): Deleted.
1938         (FunctionDetectionTest.test_non_functions): Deleted.
1939         (FunctionDetectionTest.test_non_functions.Stuff): Deleted.
1940         (FunctionDetectionTest.test_parameter_list): Deleted.
1941         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack): Deleted.
1942         (CppStyleTest.test_asm_lines_ignored): Deleted.
1943         (CppStyleTest.test_get_line_width): Deleted.
1944         (CppStyleTest.test_find_next_multi_line_comment_start): Deleted.
1945         (CppStyleTest.test_find_next_multi_line_comment_end): Deleted.
1946         (CppStyleTest.test_remove_multi_line_comments_from_range): Deleted.
1947         (CppStyleTest.test_position): Deleted.
1948         (CppStyleTest.test_rfind_in_lines): Deleted.
1949         (CppStyleTest.test_close_expression): Deleted.
1950         (CppStyleTest.test_spaces_at_end_of_line): Deleted.
1951         (CppStyleTest.test_cstyle_cast): Deleted.
1952         (CppStyleTest.test_runtime_casting): Deleted.
1953         (CppStyleTest.test_runtime_selfinit): Deleted.
1954         (CppStyleTest.test_runtime_rtti): Deleted.
1955         (CppStyleTest.test_static_cast_readability): Deleted.
1956         (CppStyleTest.test_check_for_unnamed_params): Deleted.
1957         (CppStyleTest.void): Deleted.
1958         (CppStyleTest.test_deprecated_cast): Deleted.
1959         (CppStyleTest.test_mock_method): Deleted.
1960         (CppStyleTest.test_sizeof_type): Deleted.
1961         (CppStyleTest.cases): Deleted.
1962         (CppStyleTest.for): Deleted.
1963         (CppStyleTest.test_typedef_for_pointer_to_function): Deleted.
1964         (CppStyleTest.test_typedef_for_pointer_to_function.void): Deleted.
1965         (CppStyleTest.test_include_what_you_use_no_implementation_files): Deleted.
1966         (CppStyleTest.test_include_what_you_use): Deleted.
1967         (CppStyleTest.test_files_belong_to_same_module): Deleted.
1968         (CppStyleTest.test_cleanse_line): Deleted.
1969         (CppStyleTest.test_multi_line_comments): Deleted.
1970         (CppStyleTest.test_multi_line_comments.Foo): Deleted.
1971         (CppStyleTest.test_multiline_strings): Deleted.
1972         (CppStyleTest.test_platformh_comments): Deleted.
1973         (CppStyleTest.test_explicit_single_argument_constructors): Deleted.
1974         (CppStyleTest.test_explicit_single_argument_constructors.Foo): Deleted.
1975         (CppStyleTest.test_explicit_single_argument_constructors.Qualifier): Deleted.
1976         (CppStyleTest.test_explicit_single_argument_constructors.definition): Deleted.
1977         (CppStyleTest.test_slash_star_comment_on_single_line): Deleted.
1978         (CppStyleTest.test_suspicious_usage_of_if): Deleted.
1979         (CppStyleTest.test_suspicious_usage_of_memset): Deleted.
1980         (CppStyleTest.test_check_posix_threading): Deleted.
1981         (CppStyleTest.test_insecure_string_operations): Deleted.
1982         (CppStyleTest.test_format_strings): Deleted.
1983         (CppStyleTest.test_insecure_temp_file): Deleted.
1984         (CppStyleTest.test_variable_length_array_detection): Deleted.
1985         (CppStyleTest.test_braces): Deleted.
1986         (CppStyleTest.test_check_check): Deleted.
1987         (CppStyleTest.test_brace_at_begin_of_line): Deleted.
1988         (CppStyleTest.test_mismatching_spaces_in_parens): Deleted.
1989         (CppStyleTest.test_spacing_for_fncall): Deleted.
1990         (CppStyleTest.test_spacing_for_fncall.foo): Deleted.
1991         (CppStyleTest.test_spacing_before_braces): Deleted.
1992         (CppStyleTest.test_spacing_between_braces): Deleted.
1993         (CppStyleTest.test_spacing_before_brackets): Deleted.
1994         (CppStyleTest.test_cpp_lambda_functions): Deleted.
1995         (CppStyleTest.test_objective_c_block): Deleted.
1996         (CppStyleTest.test_objective_c_block_as_argument): Deleted.
1997         (CppStyleTest.test_spacing_around_else): Deleted.
1998         (CppStyleTest.test_spacing_for_binary_ops): Deleted.
1999         (CppStyleTest.test_spacing_for_binary_ops.hash_map): Deleted.
2000         (CppStyleTest.test_operator_methods): Deleted.
2001         (CppStyleTest.test_spacing_in_objective_c_properties): Deleted.
2002         (CppStyleTest.test_spacing_before_last_semicolon): Deleted.
2003         (CppStyleTest.test_static_or_global_stlstrings): Deleted.
2004         (CppStyleTest.test_no_spaces_in_function_calls): Deleted.
2005         (CppStyleTest.test_one_spaces_between_code_and_comments): Deleted.
2006         (CppStyleTest.test_one_spaces_after_punctuation_in_comments): Deleted.
2007         (CppStyleTest.test_space_after_comment_marker): Deleted.
2008         (CppStyleTest.test_newline_at_eof): Deleted.
2009         (CppStyleTest.test_newline_at_eof.do_test): Deleted.
2010         (CppStyleTest.test_extra_newlines_at_eof): Deleted.
2011         (CppStyleTest.test_extra_newlines_at_eof.do_test): Deleted.
2012         (CppStyleTest.test_invalid_utf8): Deleted.
2013         (CppStyleTest.test_invalid_utf8.do_test): Deleted.
2014         (CppStyleTest.test_is_blank_line): Deleted.
2015         (CppStyleTest.test_blank_lines_check): Deleted.
2016         (CppStyleTest.test_allow_blank_line_before_closing_namespace): Deleted.
2017         (CppStyleTest.test_allow_blank_line_before_if_else_chain): Deleted.
2018         (CppStyleTest.test_else_on_same_line_as_closing_braces): Deleted.
2019         (CppStyleTest.test_else_clause_not_on_same_line_as_else): Deleted.
2020         (CppStyleTest.test_comma): Deleted.
2021         (CppStyleTest.test_declaration): Deleted.
2022         (CppStyleTest.test_pointer_reference_marker_location): Deleted.
2023         (CppStyleTest.test_indent): Deleted.
2024         (CppStyleTest.test_indent.Foo): Deleted.
2025         (CppStyleTest.test_not_alabel): Deleted.
2026         (CppStyleTest.test_tab): Deleted.
2027         (CppStyleTest.test_unnamed_namespaces_in_headers): Deleted.
2028         (CppStyleTest.test_build_class): Deleted.
2029         (CppStyleTest.test_build_class.definitions): Deleted.
2030         (CppStyleTest.test_build_class.Foo): Deleted.
2031         (CppStyleTest.test_build_class.DERIVE_FROM_GOO): Deleted.
2032         (CppStyleTest.test_build_end_comment): Deleted.
2033         (CppStyleTest.test_build_forward_decl): Deleted.
2034         (CppStyleTest.test_build_forward_decl.Foo): Deleted.
2035         (CppStyleTest.test_build_header_guard): Deleted.
2036         (CppStyleTest.test_build_header_guard.Foo_h): Deleted.
2037         (CppStyleTest.test_build_header_guard.Foo_h.for): Deleted.
2038         (CppStyleTest.test_build_printf_format): Deleted.
2039         (CppStyleTest.test_runtime_printf_format): Deleted.
2040         (CppStyleTest.assert_lintLogCodeOnError): Deleted.
2041         (CppStyleTest.test_build_storage_class): Deleted.
2042         (CppStyleTest.test_build_storage_class.unsignedLongLong): Deleted.
2043         (CppStyleTest.test_build_storage_class.declaration): Deleted.
2044         (CppStyleTest.test_build_storage_class.after): Deleted.
2045         (CppStyleTest.test_build_storage_class.is): Deleted.
2046         (CppStyleTest.test_legal_copyright): Deleted.
2047         (CppStyleTest.test_invalid_increment): Deleted.
2048         (CppStyleTest.test_enum_bitfields): Deleted.
2049         (CppStyleTest.test_plain_integral_bitfields): Deleted.
2050         (CleansedLinesTest.test_init_empty): Deleted.
2051         (CleansedLinesTest.test_collapse_strings): Deleted.
2052         (OrderOfIncludesTest.tearDown): Deleted.
2053         (OrderOfIncludesTest.test_check_next_include_order__no_config): Deleted.
2054         (OrderOfIncludesTest.test_check_next_include_order__no_self): Deleted.
2055         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config): Deleted.
2056         (OrderOfIncludesTest.test_check_next_include_order__other_then_config): Deleted.
2057         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely): Deleted.
2058         (OrderOfIncludesTest.test_check_alphabetical_include_order): Deleted.
2059         (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines): Deleted.
2060         (OrderOfIncludesTest.test_check_line_break_after_own_header): Deleted.
2061         (OrderOfIncludesTest.test_check_line_break_before_own_header): Deleted.
2062         (OrderOfIncludesTest.test_check_preprocessor_in_include_section): Deleted.
2063         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.BAZ): Deleted.
2064         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.FOOBAR): Deleted.
2065         (OrderOfIncludesTest.test_primary_header): Deleted.
2066         (OrderOfIncludesTest.test_public_primary_header): Deleted.
2067         (OrderOfIncludesTest.test_check_wtf_includes): Deleted.
2068         (OrderOfIncludesTest.test_classify_include): Deleted.
2069         (OrderOfIncludesTest.test_try_drop_common_suffixes): Deleted.
2070         (CheckForFunctionLengthsTest.tearDown): Deleted.
2071         (CheckForFunctionLengthsTest.set_min_confidence): Deleted.
2072         (CheckForFunctionLengthsTest.assert_function_lengths_check): Deleted.
2073         (CheckForFunctionLengthsTest.trigger_lines): Deleted.
2074         (CheckForFunctionLengthsTest.trigger_test_lines): Deleted.
2075         (CheckForFunctionLengthsTest.assert_function_length_check_definition): Deleted.
2076         (CheckForFunctionLengthsTest.assert_function_length_check_definition_ok): Deleted.
2077         (CheckForFunctionLengthsTest.assert_function_length_check_at_error_level): Deleted.
2078         (CheckForFunctionLengthsTest.assert_function_length_check_below_error_level): Deleted.
2079         (CheckForFunctionLengthsTest.assert_function_length_check_above_error_level): Deleted.
2080         (CheckForFunctionLengthsTest.function_body): Deleted.
2081         (CheckForFunctionLengthsTest.function_body_with_blank_lines): Deleted.
2082         (CheckForFunctionLengthsTest.function_body_with_no_lints): Deleted.
2083         (CheckForFunctionLengthsTest.test_function_length_check_declaration): Deleted.
2084         (CheckForFunctionLengthsTest.test_function_length_check_declaration_with_block_following): Deleted.
2085         (CheckForFunctionLengthsTest.test_function_length_check_class_definition): Deleted.
2086         (CheckForFunctionLengthsTest.test_function_length_check_class_definition.Test): Deleted.
2087         (CheckForFunctionLengthsTest.test_function_length_check_trivial): Deleted.
2088         (CheckForFunctionLengthsTest.test_function_length_check_empty): Deleted.
2089         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity0): Deleted.
2090         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity0): Deleted.
2091         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity0): Deleted.
2092         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1v0): Deleted.
2093         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1v0): Deleted.
2094         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1): Deleted.
2095         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1): Deleted.
2096         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity1): Deleted.
2097         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_indented): Deleted.
2098         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_blanks): Deleted.
2099         (CheckForFunctionLengthsTest.test_function_length_check_complex_definition_severity1): Deleted.
2100         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_test): Deleted.
2101         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_split_line_test): Deleted.
2102         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Deleted.
2103         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_embedded_no_lints): Deleted.
2104         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_no_lint): Deleted.
2105         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity2): Deleted.
2106         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity2): Deleted.
2107         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity2): Deleted.
2108         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity3): Deleted.
2109         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity3): Deleted.
2110         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity3): Deleted.
2111         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity4): Deleted.
2112         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity4): Deleted.
2113         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity4): Deleted.
2114         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity5): Deleted.
2115         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity5): Deleted.
2116         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity5): Deleted.
2117         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines): Deleted.
2118         (CheckForFunctionLengthsTest.test_function_length_not_determinable): Deleted.
2119         (NoNonVirtualDestructorsTest.test_no_error): Deleted.
2120         (NoNonVirtualDestructorsTest.test_no_error.Foo): Deleted.
2121         (NoNonVirtualDestructorsTest.test_no_error.MyClass): Deleted.
2122         (NoNonVirtualDestructorsTest.test_no_error.Qualified): Deleted.
2123         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed): Deleted.
2124         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed.Foo): Deleted.
2125         (NoNonVirtualDestructorsTest.test_enum_casing): Deleted.
2126         (NoNonVirtualDestructorsTest.test_enum_casing.Foo): Deleted.
2127         (NoNonVirtualDestructorsTest.test_enum_casing.Enum123): Deleted.
2128         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon): Deleted.
2129         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass): Deleted.
2130         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum): Deleted.
2131         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed): Deleted.
2132         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed.Foo): Deleted.
2133         (NoNonVirtualDestructorsTest.test_no_warn_when_derived): Deleted.
2134         (NoNonVirtualDestructorsTest.test_no_warn_when_derived.Foo): Deleted.
2135         (NoNonVirtualDestructorsTest.test_internal_braces): Deleted.
2136         (NoNonVirtualDestructorsTest.test_internal_braces.Foo): Deleted.
2137         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor): Deleted.
2138         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo): Deleted.
2139         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo.Goo): Deleted.
2140         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Goo): Deleted.
2141         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor): Deleted.
2142         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo): Deleted.
2143         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo.Goo): Deleted.
2144         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor): Deleted.
2145         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor.Qualified): Deleted.
2146         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error): Deleted.
2147         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error.Foo): Deleted.
2148         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error): Deleted.
2149         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error.Foo): Deleted.
2150         (LeakyPatternTest.assert_leaky_pattern_check): Deleted.
2151         (LeakyPatternTest.test_get_dc): Deleted.
2152         (LeakyPatternTest.test_get_dc.HWndDC): Deleted.
2153         (LeakyPatternTest.test_own_get_dc): Deleted.
2154         (LeakyPatternTest.test_create_dc): Deleted.
2155         (LeakyPatternTest.test_create_compatible_dc): Deleted.
2156         (WebKitStyleTest.test_indentation): Deleted.
2157         (WebKitStyleTest.test_indentation.Foo): Deleted.
2158         (WebKitStyleTest.test_indentation.Document): Deleted.
2159         (WebKitStyleTest.test_spacing): Deleted.
2160         (WebKitStyleTest.test_line_breaking): Deleted.
2161         (WebKitStyleTest.test_braces): Deleted.
2162         (WebKitStyleTest.test_braces.MyClass): Deleted.
2163         (WebKitStyleTest.test_braces.NS_ENUM): Deleted.
2164         (WebKitStyleTest.test_braces.CPP11EnumClass): Deleted.
2165         (WebKitStyleTest.test_braces.SOMETHING): Deleted.
2166         (WebKitStyleTest.test_null_false_zero): Deleted.
2167         (WebKitStyleTest.test_directive_indentation): Deleted.
2168         (WebKitStyleTest.test_using_std): Deleted.
2169         (WebKitStyleTest.test_using_namespace): Deleted.
2170         (WebKitStyleTest.test_max_macro): Deleted.
2171         (WebKitStyleTest.test_min_macro): Deleted.
2172         (WebKitStyleTest.test_wtf_move): Deleted.
2173         (WebKitStyleTest.test_ctype_fucntion): Deleted.
2174         (WebKitStyleTest.test_names): Deleted.
2175         (WebKitStyleTest.test_names.HTMLDocument): Deleted.
2176         (WebKitStyleTest.test_names.WebWindowFadeAnimation): Deleted.
2177         (WebKitStyleTest.test_names.declarations): Deleted.
2178         (WebKitStyleTest.test_names.struct): Deleted.
2179         (WebKitStyleTest.test_names.VectorType): Deleted.
2180         (WebKitStyleTest.test_parameter_names): Deleted.
2181         (WebKitStyleTest.test_comments): Deleted.
2182         (WebKitStyleTest.test_webkit_export_check): Deleted.
2183         (WebKitStyleTest.test_member_initialization_list): Deleted.
2184         (WebKitStyleTest.test_member_initialization_list.MyClass): Deleted.
2185         (WebKitStyleTest.test_other): Deleted.
2186         (CppCheckerTest.mock_handle_style_error): Deleted.
2187         (CppCheckerTest._checker): Deleted.
2188         (CppCheckerTest.test_init): Deleted.
2189         (CppCheckerTest.test_eq): Deleted.
2190         (CppCheckerTest.test_eq.mock_handle_style_error2): Deleted.
2191         (CppCheckerTest.test_ne): Deleted.
2192         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
2193         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2194         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2195         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2196         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2197         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2198
2199 2017-07-05  Saam Barati  <sbarati@apple.com>
2200
2201         NewArray in FTLLowerDFGToB3 does not handle speculating on doubles when having a bad time
2202         https://bugs.webkit.org/show_bug.cgi?id=174188
2203         <rdar://problem/30581423>
2204
2205         Reviewed by Mark Lam.
2206
2207         * Scripts/run-jsc-stress-tests:
2208
2209 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2210
2211         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
2212         https://bugs.webkit.org/show_bug.cgi?id=174150
2213
2214         Reviewed by Mark Lam.
2215
2216         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2217         (TestWebKitAPI::TEST):
2218
2219 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
2220
2221         Remove copy of ICU headers from WebKit
2222         https://bugs.webkit.org/show_bug.cgi?id=116407
2223
2224         Reviewed by Alex Christensen.
2225
2226         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2227         * TestWebKitAPI/Configurations/Base.xcconfig:
2228         * WebKitTestRunner/Configurations/Base.xcconfig:
2229
2230 2017-07-05  Chris Dumez  <cdumez@apple.com>
2231
2232         Regression(r218821): Bad cast to WebKit::DiagnosticLoggingClient in WKWebView's _setDiagnosticLoggingDelegate
2233         https://bugs.webkit.org/show_bug.cgi?id=174163
2234         <rdar://problem/33067518>
2235
2236         Reviewed by Alex Christensen.
2237
2238         Add API test coverage.
2239
2240         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2241         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDiagnosticLogging.mm: Added.
2242         (TEST):
2243
2244 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2245
2246         When dragging a selection, clearing the selection in dragstart should not crash the web process
2247         https://bugs.webkit.org/show_bug.cgi?id=174142
2248         <rdar://problem/33067501>
2249
2250         Reviewed by Tim Horton.
2251
2252         Adds a unit test checking that the web process does not crash when the selection is cleared while a selection
2253         drag is starting up.
2254
2255         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2256         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-clear-selection.html: Added.
2257         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2258         (TestWebKitAPI::TEST):
2259
2260 2017-07-05  Daniel Bates  <dabates@apple.com>
2261
2262         Do not pass API::FrameInfo for source frame or clear out page of target frame on
2263         API navigation
2264         https://bugs.webkit.org/show_bug.cgi?id=174170
2265         <rdar://problem/33140328>
2266
2267         Reviewed by Brady Eidson.
2268
2269         Update tests as needed for the behavior change.
2270
2271         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
2272         (TEST):
2273
2274 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
2275
2276         Add WebKitPrivateFrameworkStubs for iOS 11
2277         https://bugs.webkit.org/show_bug.cgi?id=173988
2278
2279         Reviewed by David Kilzer.
2280
2281         * DumpRenderTree/mac/Configurations/Base.xcconfig: iphoneos and iphonesimulator
2282         should use the same directory for private framework stubs.
2283         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2284
2285 2017-07-05  Eric Carlson  <eric.carlson@apple.com>
2286
2287         [MediaStream] Protect request and web view during gUM client callback
2288         https://bugs.webkit.org/show_bug.cgi?id=174096
2289         <rdar://problem/32833102>
2290
2291         Reviewed by Youenn Fablet.
2292
2293         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2294         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
2295
2296 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2297
2298         Unreviewed, guard iOS 11-dependent UIPasteboardTests to be iOS 11+ only
2299
2300         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2301
2302 2017-07-05  Matt Lewis  <jlewis3@apple.com>
2303
2304         Unreviewed, rolling out r219128.
2305
2306         Spoke with engineer who originally submitted, Patch for APi
2307         test to follow.
2308
2309         Reverted changeset:
2310
2311         "Unreviewed, rolling out r219070."
2312         https://bugs.webkit.org/show_bug.cgi?id=174082
2313         http://trac.webkit.org/changeset/219128
2314
2315 2017-07-05  Matt Lewis  <jlewis3@apple.com>
2316
2317         Unreviewed, rolling out r219070.
2318
2319         This revision caused consistent failures of the API test
2320         UIPasteboardTests.DoNotPastePlainTextAsURL on iOS.
2321
2322         Reverted changeset:
2323
2324         "Pasting single words copied to UIPasteboard inserts URLs in
2325         editable areas"
2326         https://bugs.webkit.org/show_bug.cgi?id=174082
2327         http://trac.webkit.org/changeset/219070
2328
2329 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2330
2331         Remove unused EFL logo from bot watcher dashboard
2332         https://bugs.webkit.org/show_bug.cgi?id=174136
2333
2334         Reviewed by Alexey Proskuryakov.
2335
2336         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Removed.
2337         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Removed.
2338
2339 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2340
2341         [GTK] Add more GTK bots to dashboard
2342         https://bugs.webkit.org/show_bug.cgi?id=174129
2343
2344         Reviewed by Carlos Alberto Lopez Perez.
2345
2346         We have a bunch of GTK bots that I never look at because they're not on the dashboard. Add
2347         them.
2348
2349         This also changes the sort order to put WPE above GTK so that it's not buried under all the
2350         less-essential GTK bots.
2351
2352         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2353         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2354         (WebKitBuildbot):
2355
2356 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2357
2358         [WPE] Add WPE to bot watcher dashboard
2359         https://bugs.webkit.org/show_bug.cgi?id=174119
2360
2361         Reviewed by Alexey Proskuryakov.
2362
2363         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/CREDIT: Added.
2364         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png: Added.
2365         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png: Added.
2366         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2367         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2368         (WebKitBuildbot):
2369         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2370         (table.queue-grid tr.platform.linux-wpe img.logo):
2371
2372 2017-07-03  Lucas Forschler  <lforschler@apple.com>
2373
2374         https://bugs.webkit.org/show_bug.cgi?id=174105
2375         
2376         Reviewed by Stephanie Lewis.
2377
2378         * BuildSlaveSupport/built-product-archive:
2379         (main): Add a -minify parser option
2380         (createZip): Pass along the optional Minify argument if requested
2381         (minifySource): This will trim down archives, logic limited to Mac platform.
2382
2383 2017-07-03  Matt Rajca  <mrajca@apple.com>
2384
2385         Add/remove appropriate media element behavior restrictions when updateWebsitePolicies is called
2386         https://bugs.webkit.org/show_bug.cgi?id=174103
2387
2388         Reviewed by Alex Christensen.
2389
2390         Added an API test.
2391
2392         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Expose a pause method.
2393         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2394         (TEST): Added test.
2395         * TestWebKitAPI/cocoa/TestWKWebView.h:
2396         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2397         (-[TestWKWebView stringByEvaluatingJavaScript:]): Don't simulate a user gesture when invoking the script.
2398
2399 2017-07-03  Matt Lewis  <jlewis3@apple.com>
2400
2401         Unreviewed, rolling out r219103.
2402
2403         Caused multiple build failures.
2404
2405         Reverted changeset:
2406
2407         "Remove copy of ICU headers from WebKit"
2408         https://bugs.webkit.org/show_bug.cgi?id=116407
2409         http://trac.webkit.org/changeset/219103
2410
2411 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
2412
2413         Remove copy of ICU headers from WebKit
2414         https://bugs.webkit.org/show_bug.cgi?id=116407
2415
2416         Reviewed by Alex Christensen.
2417
2418         Use WTF's copy of ICU headers.
2419
2420         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2421         * TestWebKitAPI/Configurations/Base.xcconfig:
2422         * WebKitTestRunner/Configurations/Base.xcconfig:
2423
2424 2017-07-03  Brady Eidson  <beidson@apple.com>
2425
2426         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
2427         https://bugs.webkit.org/show_bug.cgi?id=174073
2428
2429         Reviewed by Andy Estes.
2430
2431         * DumpRenderTree/mac/TestRunnerMac.mm:
2432         (TestRunner::setIconDatabaseEnabled): Call new SPI for this setting instead of WebIconDatabase stuff.
2433
2434         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:
2435         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
2436
2437 2017-07-03  Matt Lewis  <jlewis3@apple.com>
2438
2439         Unreviewed, rolling out r219083.
2440
2441         The revision caused an API failure on all testing platforms.
2442
2443         Reverted changeset:
2444
2445         "[MediaStream] Protect request and web view during gUM client
2446         callback"
2447         https://bugs.webkit.org/show_bug.cgi?id=174096
2448         http://trac.webkit.org/changeset/219083
2449
2450 2017-07-03  Jonathan Bedard  <jbedard@apple.com>
2451
2452         webkitpy: Properly number duplicated crashlogs
2453         https://bugs.webkit.org/show_bug.cgi?id=172002
2454
2455         Reviewed by Aakash Jain.
2456
2457         * Scripts/webkitpy/common/system/crashlogs.py:
2458         (CrashLogs._find_all_logs_darwin): Number multiple crash logs for a single process with
2459         an increasing integer.
2460         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2461         (CrashLogsTest.create_crash_logs_darwin): Create duplicated crashlog for testing.
2462         (CrashLogsTest.test_find_all_log_darwin): Now 7 Darwin logs instead of 5.
2463         (CrashLogsTest.test_duplicate_log_darwin): Test that duplicated logs are correctly numbered.
2464
2465 2017-07-03  Ryosuke Niwa  <rniwa@webkit.org>
2466
2467         WebContent processes crash when the network process crashes with pending connection requests
2468         https://bugs.webkit.org/show_bug.cgi?id=174065
2469         <rdar://problem/30359835>
2470
2471         Reviewed by Tim Horton.
2472
2473         Add a API to ensure UI process tries to relaunch a new network process when the network process
2474         crashes with pending network connection requests.
2475
2476         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2477         * TestWebKitAPI/Tests/WebKit2/NetworkProcessCrashWithPendingConnection.mm: Added.
2478         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2479         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2480         (-[TestNavigationDelegate webViewWebContentProcessDidTerminate:]): Added.
2481
2482 2017-07-03  Eric Carlson  <eric.carlson@apple.com>
2483
2484         [MediaStream] Protect request and web view during gUM client callback
2485         https://bugs.webkit.org/show_bug.cgi?id=174096
2486         <rdar://problem/32833102>
2487
2488         Reviewed by Youenn Fablet.
2489
2490         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2491         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
2492
2493 2017-07-03  Andy Estes  <aestes@apple.com>
2494
2495         [Xcode] Add an experimental setting to build with ccache
2496         https://bugs.webkit.org/show_bug.cgi?id=173875
2497
2498         Reviewed by Tim Horton.
2499
2500         On systems that already have ccache(1) installed, this patch adds experimental support for
2501         it to Xcode builds. It can be enabled with the WK_USE_CCACHE build setting.
2502
2503         When ccache is enabled, CC is overridden to invoke Tools/ccache/ccache-clang. This script
2504         finds the "-isysroot" argument to determine the active SDK, uses xcrun(1) and the SDK to
2505         find the toolchain from which to run clang, and then invokes ccache with the required
2506         arguments.
2507
2508         ccache is invoked with CCACHE_SLOPPINESS="pch_defines,time_macros", which is required for
2509         precompiled headers to work properly [1].
2510
2511         LDPLUSPLUS is overridden to invoke Tools/ccache/ccache-clang++. It behaves the same as
2512         ccache-clang, except it tells ccache to execute clang++ instead of clang. This is important
2513         during linking.
2514         
2515         [1] https://ccache.samba.org/manual.html#_precompiled_headers
2516
2517         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
2518         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
2519         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
2520         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
2521         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Ditto.
2522         * ccache/README.md: Added.
2523         * ccache/ccache-clang: Added.
2524         * ccache/ccache-clang++: Added.
2525         * ccache/ccache.xcconfig: Added. Overrides CC and LDPLUSPLUS when WK_USE_CACHE=YES.
2526
2527 2017-07-03  Alex Christensen  <achristensen@webkit.org>
2528
2529         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
2530         https://bugs.webkit.org/show_bug.cgi?id=174051
2531
2532         Reviewed by Tim Horton.
2533
2534         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2535         (TestWebKitAPI::TEST_F):
2536
2537 2017-07-03  Matt Lewis  <jlewis3@apple.com>
2538
2539         Unreviewed, rolling out r219024.
2540
2541         This patch cause 3 didferent test to fail.
2542
2543         Reverted changeset:
2544
2545         "REGRESSION(r215096) Queries of URLs with non-special schemes
2546         should not percent-encode single quotes"
2547         https://bugs.webkit.org/show_bug.cgi?id=174051
2548         http://trac.webkit.org/changeset/219024
2549
2550 2017-07-03  Chris Dumez  <cdumez@apple.com>
2551
2552         Drop ResourceLoadStatisticsStore's statisticsLock
2553         https://bugs.webkit.org/show_bug.cgi?id=174080
2554
2555         Reviewed by Brent Fulgham.
2556
2557         Port WebKitTestRunner to new Asynchronous Cocoa SPI.
2558
2559         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2560         (WTR::TestController::isStatisticsPrevalentResource):
2561         (WTR::TestController::isStatisticsHasHadUserInteraction):
2562         (WTR::TestController::isStatisticsGrandfathered):
2563
2564 2017-07-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2565
2566         Pasting single words copied to UIPasteboard inserts URLs in editable areas
2567         https://bugs.webkit.org/show_bug.cgi?id=174082
2568         <rdar://problem/33046992>
2569
2570         Reviewed by Tim Horton.
2571
2572         Adds 3 new unit tests to UIPasteboardTests to test cases of pasting plain text and URLs.
2573
2574         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2575         (TestWebKitAPI::setUpWebViewForPasteboardTests):
2576         (TestWebKitAPI::TEST):
2577
2578 2017-07-02  Brady Eidson  <beidson@apple.com>
2579
2580         Add API test for all parts of WebKit1 API related to favicons.
2581         https://bugs.webkit.org/show_bug.cgi?id=174069
2582
2583         Reviewed by Andy Estes.
2584
2585         These two API tests cover all WebKit1 API related to icons.
2586         
2587         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2588         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm: Added.
2589         (mainResourceData):
2590         (defaultFaviconData):
2591         (customFaviconData):
2592         (imageFromData):
2593         (+[IconLoadingProtocol canInitWithRequest:]):
2594         (+[IconLoadingProtocol canonicalRequestForRequest:]):
2595         (-[IconLoadingProtocol startLoading]):
2596         (-[IconLoadingProtocol stopLoading]):
2597         (-[IconLoadingFrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2598         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
2599         (TestWebKitAPI::TEST):
2600
2601 2017-07-01  Dan Bernstein  <mitz@apple.com>
2602
2603         [iOS] Remove code only needed when building for iOS 9.x
2604         https://bugs.webkit.org/show_bug.cgi?id=174068
2605
2606         Reviewed by Tim Horton.
2607
2608         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2609         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2610         (WTR::initializeWebViewConfiguration):
2611         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2612         (-[HIDEventGenerator _createIOHIDEventType:]):
2613
2614 2017-07-01  Brady Eidson  <beidson@apple.com>
2615
2616         When setting a custom cookie storage location on a WKWebsiteDataStore, cookies aren't actually removed.
2617         <rdar://problem/32410662> and https://bugs.webkit.org/show_bug.cgi?id=174035
2618
2619         Reviewed by Alex Christensen.
2620
2621         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2622
2623 2017-07-01  Dan Bernstein  <mitz@apple.com>
2624
2625         [macOS] Remove code only needed when building for OS X Yosemite
2626         https://bugs.webkit.org/show_bug.cgi?id=174067
2627
2628         Reviewed by Tim Horton.
2629
2630         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2631         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2632         * DumpRenderTree/mac/DumpRenderTree.mm:
2633         (setDefaultsToConsistentValuesForTesting):
2634         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2635         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
2636         * MiniBrowser/Configurations/Base.xcconfig:
2637         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2638         * TestWebKitAPI/Configurations/Base.xcconfig:
2639         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2640         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2641         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2642         (TestWebKitAPI::TEST_F):
2643         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
2644         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
2645         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2646         (TestWebKitAPI::TEST_F):
2647         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
2648         (TestWebKitAPI::TEST):
2649         * WebKitTestRunner/Configurations/Base.xcconfig:
2650         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2651         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2652         (WTR::InjectedBundle::platformInitialize):
2653         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
2654         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
2655
2656 2017-07-01  Chris Dumez  <cdumez@apple.com>
2657
2658         Replace ResourceLoadStatisticsStore C API with Cocoa SPI
2659         https://bugs.webkit.org/show_bug.cgi?id=174060
2660
2661         Reviewed by Brent Fulgham.
2662
2663         Port WebKitTestRunner over to the new Cocoa SPI.
2664
2665         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2666         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2667         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2668         Drop calls to the WKResourceLoadStatisticsStore C API here. Those were
2669         no-ops since this code runs in the WebContent process, not the
2670         UIProcess.
2671
2672         * WebKitTestRunner/TestController.cpp:
2673         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2674
2675 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
2676
2677         Unreviewed mac build fix.
2678
2679         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
2680         (TestWebKitAPI::TEST):
2681
2682 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
2683
2684         Add API to get WKActivatedElementInfo
2685         https://bugs.webkit.org/show_bug.cgi?id=174001
2686         <rdar://problem/29165518>
2687         
2688         Tests for now SPI to get activatedElementInfo.
2689
2690         Reviewed by Tim Horton.
2691
2692         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2693         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm: Added.
2694         (TestWebKitAPI::TEST):
2695
2696 2017-06-30  Chris Dumez  <cdumez@apple.com>
2697
2698         Move store logic from WebResourceLoadStatisticsManager to WebResourceLoadStatisticsStore
2699         https://bugs.webkit.org/show_bug.cgi?id=174038
2700
2701         Reviewed by Brent Fulgham.
2702
2703         Fix typo in API name.
2704
2705         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2706         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2707         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2708         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2709         * WebKitTestRunner/TestController.cpp:
2710         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2711         * WebKitTestRunner/TestController.h:
2712         * WebKitTestRunner/TestInvocation.cpp:
2713         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2714
2715 2017-06-30  Alex Christensen  <achristensen@webkit.org>
2716
2717         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
2718         https://bugs.webkit.org/show_bug.cgi?id=174051
2719         <rdar://problem/33002846>
2720
2721         Reviewed by Tim Horton.
2722
2723         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2724         (TestWebKitAPI::TEST_F):
2725
2726 2017-06-30  Daniel Bates  <dabates@apple.com>
2727
2728         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
2729         https://bugs.webkit.org/show_bug.cgi?id=165160
2730         <rdar://problem/29451999>
2731
2732         Reviewed by Brady Eidson.
2733
2734         Add tests to ensure that -[WKFrameInfo webView] is computed correctly for the source and target frame
2735         for navigations and window creation.
2736
2737         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2738         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm: Added. Derived from file ShouldOpenExternalURLsInNewWindowActions.mm.
2739         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
2740         (-[DecidePolicyForNavigationActionController webView:didFinishNavigation:]):
2741         (-[DecidePolicyForNavigationActionController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2742         (TEST):
2743
2744 2017-06-29  Jer Noble  <jer.noble@apple.com>
2745
2746         Make Legacy EME API controlled by RuntimeEnabled setting.
2747         https://bugs.webkit.org/show_bug.cgi?id=173994
2748
2749         Reviewed by Sam Weinig.
2750
2751         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2752
2753 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
2754
2755         Follow-up fix for r218996
2756
2757         Unreviewed infrastructure fix.
2758
2759         Repeated calls to 'ios_version' make the log noisy, memoize the function.
2760
2761         * Scripts/webkitpy/port/ios_simulator.py:
2762         (IOSSimulatorPort): Memoize ios_version().
2763
2764 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
2765
2766         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
2767         https://bugs.webkit.org/show_bug.cgi?id=174017
2768         <rdar://problem/32959782>
2769
2770         Reviewed by Simon Fraser.
2771
2772         Add a new test verifying that the drag caret is visually contained within the bounds of an iframe. Before these
2773         changes, the caret would appear outside of the iframe.
2774
2775         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2776         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-in-iframe.html: Added.
2777         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2778         (checkDragCaretRectIsContainedInRect):
2779         (TestWebKitAPI::TEST):
2780         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2781         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2782         (-[DataInteractionSimulator _resetSimulatedState]):
2783         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
2784         (-[DataInteractionSimulator _advanceProgress]):
2785         (-[DataInteractionSimulator lastKnownDragCaretRect]):
2786
2787 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
2788
2789         Add support for different versions of iOS when loading test expectations
2790         https://bugs.webkit.org/show_bug.cgi?id=173774
2791         <rdar://problem/32951132>
2792
2793         Rubber-stamped by Aakash Jain.
2794
2795         When running layout tests, we should support multiple version of iOS the same way we do Mac.
2796
2797         * Scripts/webkitpy/port/ios.py:
2798         (IOSPort.default_baseline_search_path): Add ios-<major version> test expectation.
2799         (IOSPort.test_expectations_file_position): Added new file expectations, increment expected file position.
2800         (IOSPort.ios_version): iOS ports must define a function to retrieve the iOS version.
2801         * Scripts/webkitpy/port/ios_device.py:
2802         (IOSDevicePort.ios_version): Ask connected devices for implementation.
2803         * Scripts/webkitpy/port/ios_device_unittest.py:
2804         (IOSDeviceTest.test_additional_platform_directory): Skip test until bug 173775 is finished.
2805         (IOSDeviceTest.test_baseline_searchpath): Ditto.
2806         (IOSDeviceTest.test_expectations_ordering): Ditto.
2807         * Scripts/webkitpy/port/ios_simulator.py:
2808         (IOSSimulatorPort.ios_version): If a runtime is specified, ask the runtime for the iOS version. Otherwise,
2809         ask the platform.
2810
2811 2017-06-30  Jacobo Aragunde Pérez  <jaragunde@igalia.com>
2812
2813         Fontconfig build breaks with glibc 2.15+
2814         https://bugs.webkit.org/show_bug.cgi?id=174019
2815
2816         Reviewed by Carlos Alberto Lopez Perez.
2817
2818         Apply patch by Khem Raj adapted to fontconfig 2.11.1.
2819
2820         * wpe/jhbuild.modules:
2821         * wpe/patches/fontconfig-avoid-conflicts-with-integer-width-macros-from-TS-18.patch: Added.
2822
2823 2017-06-29  Wenson Hsieh  <wenson_hsieh@apple.com>
2824
2825         [iOS DnD] Web content process crashes when the selection is moved far offscreen in dragstart
2826         https://bugs.webkit.org/show_bug.cgi?id=174010
2827         <rdar://problem/32597802>
2828
2829         Reviewed by Tim Horton.
2830
2831         Adds a new API test to ensure that we don't crash trying to dereference a null RefPtr when the TextIndicator
2832         snapshot fails for any reason.
2833
2834         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2835         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-change-selection-offscreen.html: Added.
2836         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2837         (TestWebKitAPI::TEST):
2838
2839 2017-06-29  Chris Fleizach  <cfleizach@apple.com>
2840
2841         AX: Cannot call setValue() on contenteditable or ARIA text controls
2842         https://bugs.webkit.org/show_bug.cgi?id=173520
2843
2844         Reviewed by Ryosuke Niwa.
2845
2846         Add setValue() method to WKTR (already existed in DRT).
2847
2848         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2849         (WTR::AccessibilityUIElement::setValue):
2850         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2851         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2852         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2853         (WTR::AccessibilityUIElement::setValue):
2854
2855 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
2856
2857         getBoundingClientRect returns wrong value for combination of page zoom and scroll
2858         https://bugs.webkit.org/show_bug.cgi?id=173841
2859         rdar://problem/32983841
2860
2861         Reviewed by Dean Jackson.
2862
2863         Make "Zoom In" and "Zoom Out" work correctly in the WebKit1 window. Previously they
2864         always did text zooming.
2865
2866         * MiniBrowser/mac/WK1BrowserWindowController.m:
2867         (-[WK1BrowserWindowController zoomIn:]):
2868         (-[WK1BrowserWindowController zoomOut:]):
2869         (-[WK1BrowserWindowController canResetZoom]):
2870         (-[WK1BrowserWindowController resetZoom:]):
2871
2872 2017-06-29  John Wilander  <wilander@apple.com>
2873
2874         Fix for intermittent Layout Test fail http/tests/loading/resourceLoadStatistics/telemetry-generation.html
2875         https://bugs.webkit.org/show_bug.cgi?id=173940
2876         <rdar://problem/33018125>
2877
2878         Reviewed by Brent Fulgham.
2879
2880         This change allows the TestController to turn off
2881         regular resource load statistics telemetry submission
2882         and to manually control when telemetry is calculated
2883         and submitted.
2884
2885         * WebKitTestRunner/TestController.cpp:
2886         (WTR::TestController::initialize):
2887             Turns off automatic resource load statistics telemetry submission.
2888
2889 2017-06-29  Commit Queue  <commit-queue@webkit.org>
2890
2891         Unreviewed, rolling out r218512.
2892         https://bugs.webkit.org/show_bug.cgi?id=173981
2893
2894         "It changes the behavior of the JS API's JSEvaluateScript
2895         which breaks TurboTax" (Requested by saamyjoon on #webkit).
2896
2897         Reverted changeset:
2898
2899         "test262: Completion values for control flow do not match the
2900         spec"
2901         https://bugs.webkit.org/show_bug.cgi?id=171265
2902         http://trac.webkit.org/changeset/218512
2903
2904 2017-06-29  Jonathan Bedard  <jbedard@apple.com>
2905
2906         Add WebKitSystemInterface for iOS 11
2907         https://bugs.webkit.org/show_bug.cgi?id=173936
2908
2909         Reviewed by Lucas Forschler.
2910
2911         * Scripts/copy-webkitlibraries-to-product-directory: Copy iOS 11 WebKitSystemInterface libraries. 
2912
2913 2017-06-28  Keith Miller  <keith_miller@apple.com>
2914
2915         VMTraps has some races
2916         https://bugs.webkit.org/show_bug.cgi?id=173941
2917
2918         Reviewed by Michael Saboff.
2919
2920         Add new testing mode for testing the Watchdog with our stress
2921         tests.
2922
2923         * Scripts/run-jsc-stress-tests:
2924
2925 2017-06-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2926
2927         [GTK][WPE] Implement API::IconLoadingClient and rework WebKitFaviconDatabase to use IconDatabase directly
2928         https://bugs.webkit.org/show_bug.cgi?id=173877
2929
2930         Reviewed by Brady Eidson.
2931
2932         Update favicons unit test to ensure we wait until the database is updated in testGetFavicon() before starting
2933         the next tests.
2934
2935         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
2936         (testGetFavicon):
2937
2938 2017-06-28  Tim Horton  <timothy_horton@apple.com>
2939
2940         MobileSafari was constantly using 10-15% CPU viewing a PDF
2941         https://bugs.webkit.org/show_bug.cgi?id=173944
2942         <rdar://problem/33039910>
2943
2944         Reviewed by Simon Fraser.
2945
2946         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2947         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewStablePresentationUpdateCallback.mm:
2948         Add a test that we ever call the stable presentation update callback
2949         when we have a WKPDFView up, instead of infinitely looping.
2950
2951 2017-06-28  Alex Christensen  <achristensen@webkit.org>
2952
2953         Prevent displaying URLs with small capital letters
2954         https://bugs.webkit.org/show_bug.cgi?id=173949
2955         <rdar://problem/32952058>
2956
2957         Reviewed by Brent Fulgham.
2958
2959         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
2960         (TestWebKitAPI::TEST):
2961
2962 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
2963
2964         Unreviewed test fix.
2965
2966         Disable the file monitor tests on iOS because the 'system' API is unavailable on that platform.
2967
2968         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: 
2969
2970 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
2971
2972         Teach ResourceLoadStatistics to recognize changes in the file system
2973         https://bugs.webkit.org/show_bug.cgi?id=173800
2974         <rdar://problem/32937842>
2975
2976         Reviewed by Chris Dumez.
2977
2978         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2979         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: Added.
2980         (TestWebKitAPI::FileMonitorTest::tempFilePath):
2981         (TestWebKitAPI::handleFileModification):
2982         (TestWebKitAPI::handleFileDeletion):
2983         (TestWebKitAPI::resetTestState):
2984         (TestWebKitAPI::TEST_F):
2985
2986 2017-06-28  Brady Eidson  <beidson@apple.com>
2987
2988         DocumentLoader should always notify the client if there are pending icon loads when the load is stopped.
2989         https://bugs.webkit.org/show_bug.cgi?id=173874
2990
2991         Reviewed by Alex Christensen.
2992
2993         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
2994
2995 2017-06-28  Don Olmstead  <don.olmstead@sony.com>
2996
2997         Unreviewed, adding Don Olmstead to contributors.json
2998
2999         * Scripts/webkitpy/common/config/contributors.json:
3000
3001 2017-06-28  Alex Christensen  <achristensen@webkit.org>
3002
3003         WebsitePolicies given with navigation policy for redirects should apply to the provisional document
3004         https://bugs.webkit.org/show_bug.cgi?id=173886
3005         <rdar://problem/32543191>
3006
3007         Reviewed by Andy Estes.
3008
3009         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
3010         (ParsedRange::ParsedRange):
3011         (-[TestSchemeHandler initWithVideoData:]):
3012         (-[TestSchemeHandler webView:startURLSchemeTask:]):
3013         (-[TestSchemeHandler webView:stopURLSchemeTask:]):
3014         (TEST):
3015
3016 2017-06-27  JF Bastien  <jfbastien@apple.com>
3017
3018         WebAssembly: running out of executable memory should throw OoM
3019         https://bugs.webkit.org/show_bug.cgi?id=171537
3020         <rdar://problem/32963338>
3021
3022         Reviewed by Saam Barati.
3023
3024         * Scripts/run-jsc-stress-tests: add a configuration which runs the
3025         tests under limited executable memory and avoids non-WebAssembly
3026         code generation so that we more reliably run out of executable
3027         memory in WebAssembly.
3028
3029 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3030
3031         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
3032         https://bugs.webkit.org/show_bug.cgi?id=173854
3033         <rdar://problem/32236827>
3034
3035         Reviewed by Ryosuke Niwa and Tim Horton.
3036
3037         Adds a new test to check that an image can be dragged out of a contenteditable and dropped.
3038
3039         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3040         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-target.html: Added.
3041         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3042         (TestWebKitAPI::TEST):
3043
3044 2017-06-27  Don Olmstead  <don.olmstead@sony.com>
3045
3046         [PAL] Add symbol export macros for PAL
3047         https://bugs.webkit.org/show_bug.cgi?id=171519
3048
3049         Reviewed by Konstantin Tokarev.
3050
3051         * DumpRenderTree/config.h:
3052         * TestWebKitAPI/CMakeLists.txt:
3053         * TestWebKitAPI/config.h:
3054         * WebKitTestRunner/config.h:
3055
3056 2017-06-27  John Wilander  <wilander@apple.com>
3057
3058         Resource Load Statistics: Add telemetry
3059         https://bugs.webkit.org/show_bug.cgi?id=173499
3060         <rdar://problem/32826094>
3061
3062         Reviewed by Brent Fulgham.
3063
3064         Adds three new testRunner functions:
3065         - installStatisticsDidRunTelemetryCallback()
3066         - statisticsFireTelemetryHandler()
3067         - setStatisticsNotifyPagesWhenTelemetryWasCaptured()
3068
3069         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3070         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3071         (WTR::InjectedBundle::didReceiveMessageToPage):
3072         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3073         (WTR::TestRunner::installStatisticsDidRunTelemetryCallback):
3074         (WTR::TestRunner::statisticsDidRunTelemetryCallback):
3075         (WTR::TestRunner::statisticsFireTelemetryHandler):
3076         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
3077         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3078         * WebKitTestRunner/TestController.cpp:
3079         (WTR::TestController::resetStateToConsistentValues):
3080         (WTR::TestController::statisticsFireTelemetryHandler):
3081         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
3082         * WebKitTestRunner/TestController.h:
3083         * WebKitTestRunner/TestInvocation.cpp:
3084         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3085
3086 2017-06-27  Ting-Wei Lan  <lantw44@gmail.com>
3087
3088         Add missing includes to fix compilation error on FreeBSD
3089         https://bugs.webkit.org/show_bug.cgi?id=172919
3090
3091         Reviewed by Mark Lam.
3092
3093         * ImageDiff/cairo/PlatformImageCairo.cpp:
3094
3095 2017-06-26  Jonathan Bedard  <jbedard@apple.com>
3096
3097         Unreviewed, rolling out r218783.
3098
3099         Causing accessibility/mac/setting-attributes-is-
3100         asynchronous.html to crash consistently on mac-wk2 Debug
3101
3102         Reverted changeset:
3103
3104         "AX: Cannot call setValue() on contenteditable or ARIA text
3105         controls"
3106         https://bugs.webkit.org/show_bug.cgi?id=173520
3107         http://trac.webkit.org/changeset/218783
3108
3109 2017-06-26  Yusuke Suzuki  <utatane.tea@gmail.com>
3110
3111         [WTF] Drop Thread::create(obsolete things) API since we can use lambda
3112         https://bugs.webkit.org/show_bug.cgi?id=173825
3113
3114         Reviewed by Saam Barati.
3115
3116         * DumpRenderTree/JavaScriptThreading.cpp:
3117         (runJavaScriptThread):
3118         (startJavaScriptThreads):
3119         * DumpRenderTree/mac/DumpRenderTree.mm:
3120         (runThread):
3121         (runPthread):
3122         (testThreadIdentifierMap):
3123
3124 2017-06-26  David Kilzer  <ddkilzer@apple.com>
3125
3126         [TestWebKitAPI] Fix false-positive bad release warnings found by clang static analyzer
3127         <https://webkit.org/b/173837>
3128
3129         Reviewed by Geoffrey Garen.
3130
3131         The clang static analyzer can't reason about objects that are
3132         assigned to a delegate as +1 retained, and then released
3133         later in a different method when the delegate is cleared.
3134
3135         Instead, use a common idiom where the object setting the
3136         delegate retains it as an instance variable on initialization.
3137         Then the same object clears the delegate and releases its
3138         instance variable during teardown.
3139
3140         Also add EXPECT_TRUE() tests to make sure the delegate objects
3141         match before teardown.
3142
3143         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
3144         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
3145         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
3146         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
3147         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
3148         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::teardownView):
3149
3150 2017-06-26  David Kilzer  <ddkilzer@apple.com>
3151
3152         [TestWebKitAPI] REGRESSION (r218750): Fix leak of NSURLResponse in WKURLSchemeHandler-1.mm
3153         <https://webkit.org/b/173836>
3154
3155         Reviewed by Brady Eidson.
3156
3157         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
3158         (-[RedirectSchemeHandler webView:startURLSchemeTask:]): Use
3159         adoptNS() to fix the leak.  Also use auto/adoptNS() for other
3160         objects in this test.
3161
3162 2017-06-26  Joanmarie Diggs  <jdiggs@igalia.com>
3163
3164         [ATK] Add support for aria-details and aria-errormessage
3165         https://bugs.webkit.org/show_bug.cgi?id=172588
3166
3167         Reviewed by Chris Fleizach.
3168
3169         Add additional methods to test ARIA properties which are exposed via
3170         AtkRelation. Also bump minimum versions of at-spi2-core and at-spi2-atk
3171         to versions which support the details and error-message relation types.
3172
3173         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3174         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
3175         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
3176         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
3177         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
3178         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3179         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3180         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
3181         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
3182         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
3183         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
3184         * gtk/jhbuild.modules:
3185
3186 2017-06-26  Carlos Garcia Campos  <cgarcia@igalia.com>
3187
3188         Unreviewed. Add libfii to GTK+ install dependencies script.
3189
3190         * gtk/install-dependencies:
3191
3192 2017-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
3193
3194         Unreviewed, rolling out r215190.
3195
3196         Broke product select element on GNOME Bugzilla
3197
3198         Reverted changeset:
3199
3200         "[GTK] Misplaced right click menu on web page due to
3201         deprecated gtk_menu_popup()"
3202         https://bugs.webkit.org/show_bug.cgi?id=170553
3203         http://trac.webkit.org/changeset/215190
3204
3205 2017-06-24  Joseph Pecoraro  <pecoraro@apple.com>
3206
3207         Remove Reflect.enumerate
3208         https://bugs.webkit.org/show_bug.cgi?id=173806
3209
3210         Reviewed by Yusuke Suzuki.
3211
3212         * Scripts/run-jsc-stress-tests:
3213
3214 2017-06-24  Chris Fleizach  <cfleizach@apple.com>
3215
3216         AX: Cannot call setValue() on contenteditable or ARIA text controls
3217         https://bugs.webkit.org/show_bug.cgi?id=173520
3218
3219         Reviewed by Ryosuke Niwa.
3220
3221         Add setValue() method to WKTR (already existed in DRT).
3222
3223         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3224         (WTR::AccessibilityUIElement::setValue):
3225         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3226         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3227         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3228         (WTR::AccessibilityUIElement::setValue):
3229
3230 2017-06-23  Keith Miller  <keith_miller@apple.com>
3231
3232         Switch VMTraps to use halt instructions rather than breakpoint instructions
3233         https://bugs.webkit.org/show_bug.cgi?id=173677
3234
3235         Reviewed by JF Bastien.
3236
3237         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
3238         (TEST):
3239
3240 2017-06-23  Youenn Fablet  <youenn@apple.com>
3241
3242         Set getUserMedia permission to true by default on WTR
3243         https://bugs.webkit.org/show_bug.cgi?id=173610
3244
3245         Reviewed by Alex Christensen.
3246
3247         Adding a way to reset the getUserMedia permission to pending.
3248
3249         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3250         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3251         (WTR::InjectedBundle::setUserMediaPermissionAsUnset):
3252         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3253         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3254         (WTR::TestRunner::setUserMediaPermissionAsUnset):
3255         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3256         * WebKitTestRunner/TestController.cpp:
3257         (WTR::TestController::resetStateToConsistentValues):
3258         (WTR::TestController::setUserMediaPermissionAsUnset):
3259         * WebKitTestRunner/TestController.h:
3260         * WebKitTestRunner/TestInvocation.cpp:
3261         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3262
3263 2017-06-23  Alex Christensen  <achristensen@webkit.org>
3264
3265         Add SPI to WKURLSchemeTask for redirection
3266         https://bugs.webkit.org/show_bug.cgi?id=173730
3267
3268         Reviewed by Brady Eidson.
3269
3270         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
3271         (-[SchemeHandler webView:startURLSchemeTask:]):
3272         (-[SchemeHandler webView:stopURLSchemeTask:]):
3273         (TEST):
3274         (-[RedirectSchemeHandler webView:startURLSchemeTask:]):
3275         (-[RedirectSchemeHandler webView:stopURLSchemeTask:]):
3276         (-[RedirectSchemeHandler webView:didReceiveServerRedirectForProvisionalNavigation:]):
3277         (-[RedirectSchemeHandler webView:decidePolicyForNavigationResponse:decisionHandler:]):
3278         (-[RedirectSchemeHandler userContentController:didReceiveScriptMessage:]):
3279
3280 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3281
3282         [WPE] Use JSC API to send script messages from web extension in tests
3283         https://bugs.webkit.org/show_bug.cgi?id=173757
3284
3285         Reviewed by Žan Doberšek.
3286
3287         The GTK+ uses DOM bindings to send the messages. We can just build the message string and use JSEvaluateScript
3288         to run postMessage().
3289
3290         Fixes: /wpe/WebKitSecurityManager/file-xhr
3291                /wpe/WebKitConsoleMessage/console-api
3292                /wpe/WebKitConsoleMessage/js-exception
3293                /wpe/WebKitConsoleMessage/network-error
3294                /wpe/WebKitConsoleMessage/security-error
3295
3296         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
3297         (testWebKitConsoleMessageSecurityError): Remove ifdefs.
3298         (beforeAll): Ditto.
3299         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
3300         (testWebContextSecurityFileXHR): Ditto.
3301         (beforeAll): Ditto.
3302         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3303         (consoleMessageSentCallback): Use JSEvaluateScript in WPE. We need to escape the '"' in the message string.
3304         (pageCreatedCallback): Remove ifdefs.
3305
3306 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3307
3308         Unreviewed. Fix WPE /wpe/WebKitWebView/javascript-dialogs and /wpe/WebKitWebView/window-properties
3309
3310         Skip onbeforeunload dialog tests for now in WPE since we don't have a implemention for
3311         simulateUserInteraction(). And do not expect changes in "geometry" property of WebKitWindowProperties that
3312         doesn't exist yet in WPE.
3313
3314         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3315         (testWebViewJavaScriptDialogs):
3316         (testWebViewWindowProperties):
3317
3318 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3319
3320         [GTK] Upgrade pixman and cairo in jhbuild
3321         https://bugs.webkit.org/show_bug.cgi?id=173710
3322
3323         Reviewed by Carlos Alberto Lopez Perez.
3324
3325         * gtk/jhbuild.modules:
3326
3327 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3328
3329         REGRESSION(r218686): [GTK] Several unit tests are failing after r218686 in the bots
3330         https://bugs.webkit.org/show_bug.cgi?id=173711
3331
3332         Reviewed by Carlos Alberto Lopez Perez.
3333
3334         I can't reproduce it locally, but it's complaining about a g_setenv() and I only added one in r218686 to recover
3335         the XDG_RUNTIME_DIR, because it's required by Wayland to work. So, I guess that env var is not set in the bots.
3336
3337         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3338         (WebKitTestBus::run): Ensure value is not nullptr before calling g_setenv().
3339
3340 2017-06-22  David Kilzer  <ddkilzer@apple.com>
3341
3342         REGRESSION (r218419): 7 leaks in PluginLoadClientPolicies.mm
3343         <https://webkit.org/b/173721>
3344
3345         Reviewed by Joseph Pecoraro.
3346
3347         Use RetainPtr<> to create NSMutableDictionary and NSNumber
3348         objects to fix leaks and to avoid the autoreleasepool.
3349
3350         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm:
3351         (TEST):
3352
3353 2017-06-22  Matt Lewis  <jlewis3@apple.com>
3354
3355         Unreviewed, rolling out r218633.
3356
3357         The test is failing frequently on Sierra Debug and Windows
3358
3359         Reverted changeset:
3360
3361         "AX: Cannot call setValue() on contenteditable or ARIA text
3362         controls"
3363         https://bugs.webkit.org/show_bug.cgi?id=173520
3364         http://trac.webkit.org/changeset/218633
3365
3366 2017-06-22  David Kilzer  <ddkilzer@apple.com>
3367
3368         [TestWebKitAPI] Fix misuse of -[NSData dataWithBytesNoCopy:length:] with global variables
3369         <https://webkit.org/b/173690>
3370
3371         Reviewed by Chris Dumez.
3372
3373         Per documentation, -[NSData dataWithBytesNoCopy:length:] takes
3374         ownership of malloc()-ed memory, then frees it when it's
3375         released.  These tests were passing global variables into the
3376         method, which is not malloc()-ed memory, which violates the API
3377         contract.
3378
3379         The fix is to switch to use
3380         -[NSData dataWithBytesNoCopy:length:freeWhenDone:] and to pass
3381         NO for the last argument.
3382
3383         Caught by the clang static analyzer.
3384
3385         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
3386         (TEST):
3387         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
3388         (TEST):
3389
3390 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3391
3392         [GTK] Upgrade Harfbuzz to version 1.4.2
3393         https://bugs.webkit.org/show_bug.cgi?id=173592
3394
3395         Reviewed by Carlos Alberto Lopez Perez.
3396
3397         * gtk/jhbuild.modules:
3398
3399 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3400
3401         [WPE] Update WPEBackend-mesa
3402         https://bugs.webkit.org/show_bug.cgi?id=173705
3403
3404         Reviewed by Carlos Alberto Lopez Perez.
3405
3406         A crash has been fixed, needed for unit tests to work.
3407
3408         * wpe/jhbuild.modules:
3409
3410 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3411
3412         Remove unused coordinated graphics C API
3413         https://bugs.webkit.org/show_bug.cgi?id=173706
3414
3415         Reviewed by Žan Doberšek.
3416
3417         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp: Removed.
3418         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp: Removed.
3419         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Removed.
3420         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: Removed.
3421         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Removed.
3422         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Removed.
3423
3424 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3425
3426         [WPE] Build glib API tests
3427         https://bugs.webkit.org/show_bug.cgi?id=173702
3428
3429         Reviewed by Žan Doberšek.
3430
3431         Many of the tests pass without problems, others need to be investigated, and some others are known issues. The
3432         main difference between the GTK+ and WPE WebKitWebView is that in GTK+ it's a GtkWidget, so initially
3433         unowned. The tests assume that webkit_web_view_new methods return a floating reference. This patch adds
3434         Test::adoptView() method that returns a GRefPtr<WebKitWebView> with a different implementation in GTK+ and
3435         WPE. In the case of GTK+, it sinks the floating reference, while in WPE it simply adopts the reference. Another
3436         difference is that in GTK+ the web view is initially hidden and needs to be added to a window to make it
3437         visible. Also, some tests need the web view to be realized to work, and others need that the view is added to a
3438         toplevel window, instead of a popup window. All those things are not needed at all in WPE. I've added several
3439         #ifdefs with FIXME comments for the things that we know don't work in WPE yet, for example, because we haven't
3440         implemented the methods to send events to the web view. Those will be removed eventually when we fix the issues
3441         and implement the missing features.
3442
3443         * CMakeLists.txt:
3444         * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp:
3445         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
3446         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3447         (testAutomationSessionRequestSession):
3448         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
3449         (testWebKitWebViewSessionState):
3450         (testWebKitWebViewSessionStateWithFormData):
3451         (testWebKitWebViewNavigationAfterSessionRestore):
3452         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
3453         (beforeAll):
3454         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3455         (testCookieManagerEphemeral):
3456         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
3457         (testBlobDownload):
3458         (beforeAll):
3459         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
3460         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3461         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
3462         (testProcessPerWebView):
3463         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
3464         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3465         (testWebViewCreateNavigationData):
3466         (testWebViewJavaScriptDialogs):
3467         (testWebViewWindowProperties):
3468         (testWebViewMouseTarget):
3469         (testWebViewGeolocationPermissionRequests):
3470         (testWebViewUserMediaPermissionRequests):
3471         (testWebViewAudioOnlyUserMediaPermissionRequests):
3472         (testWebViewFileChooserRequest):
3473         (beforeAll):
3474         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
3475         (beforeAll):
3476         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
3477         (testPrivateBrowsing):
3478         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
3479         (testFindControllerHide):
3480         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
3481         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3482         (testWebKitSettings):
3483         (beforeAll):
3484         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3485         (testWebViewNewWithUserContentManager):
3486         (beforeAll):
3487         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
3488         (testWebContextEphemeral):
3489         (testWebContextProxySettings):
3490         (beforeAll):
3491         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3492         (testWebViewWebContext):
3493         (testWebViewWebContextLifetime):
3494         (testWebViewEphemeral):
3495         (testWebViewSettings):
3496         (testWebViewCanShowMIMEType):
3497         (testWebViewPageVisibility):
3498         (testWebViewIsPlayingAudio):
3499         (beforeAll):
3500         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
3501         (testWebsiteDataEphemeral):
3502         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3503         (documentLoadedCallback):
3504         (pageCreatedCallback):
3505         (methodCallCallback):
3506         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h:
3507         * TestWebKitAPI/glib/CMakeLists.txt:
3508         * TestWebKitAPI/glib/PlatformGTK.cmake:
3509         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
3510         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
3511         (main):
3512         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3513         (Test::adoptView):
3514         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3515         (WebKitTestBus::run):
3516         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
3517         (WebViewTest::~WebViewTest):
3518         (WebViewTest::initializeWebView):
3519         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
3520         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp: Added.
3521         (WebViewTest::platformDestroy):
3522         (WebViewTest::platformInitializeWebView):
3523         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
3524         (WebViewTest::resizeView):
3525         (WebViewTest::hideView):
3526         (parentWindowMapped):
3527         (WebViewTest::showInWindow):
3528         (WebViewTest::showInWindowAndWaitUntilMapped):
3529         (WebViewTest::mouseMoveTo):
3530         (WebViewTest::clickMouseButton):
3531         (WebViewTest::emitPopupMenuSignal):
3532         (WebViewTest::keyStroke):
3533         (WebViewTest::doMouseButtonEvent):
3534         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp: Copied from Tools/TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h.
3535         (WebViewTest::platformDestroy):
3536         (WebViewTest::platformInitializeWebView):
3537         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
3538         (WebViewTest::resizeView):
3539         (WebViewTest::hideView):
3540         (WebViewTest::mouseMoveTo):
3541         (WebViewTest::clickMouseButton):
3542         (WebViewTest::keyStroke):
3543
3544 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3545
3546         [GTK] Move WebKit2 GLib API tests to glib directories
3547         https://bugs.webkit.org/show_bug.cgi?id=173642
3548
3549         Reviewed by Žan Doberšek.
3550
3551         * CMakeLists.txt:
3552         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Removed.
3553         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Removed.
3554         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp.
3555         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp.
3556         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp.
3557         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp.
3558         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp.
3559         (testWebKitConsoleMessageNetworkError):
3560         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp.
3561         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp.
3562         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp.
3563         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp.
3564         (testLoadFromGResource):
3565         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp.
3566         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp.
3567         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp.
3568         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp.
3569         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp.
3570         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp.
3571         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp.
3572         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp.
3573         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp.
3574         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp.
3575         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp.
3576         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp.
3577         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp.
3578         (testWebViewRunJavaScript):
3579         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp.
3580         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp.
3581         (registerGResource):
3582         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp.
3583         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h.
3584         * TestWebKitAPI/Tests/WebKitGLib/resources/blank.ico: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico.
3585         * TestWebKitAPI/Tests/WebKitGLib/resources/boring.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html.
3586         * TestWebKitAPI/Tests/WebKitGLib/resources/link-title.js: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js.
3587         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg.
3588         * TestWebKitAPI/Tests/WebKitGLib/resources/simple.json: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json.
3589         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem.
3590         * TestWebKitAPI/Tests/WebKitGLib/resources/test-key.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem.
3591         * TestWebKitAPI/Tests/WebKitGLib/resources/test.pdf: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf.
3592         * TestWebKitAPI/Tests/WebKitGLib/resources/track.ogg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/track.ogg.
3593         * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml: Added.
3594         * TestWebKitAPI/glib/CMakeLists.txt: Added.
3595         * TestWebKitAPI/glib/PlatformGTK.cmake: Added.
3596         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp.
3597         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h.
3598         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp.
3599         (registerGResource):
3600         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h.
3601         (Test::getResourcesDir):
3602         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp.