f0c9b9f4e07721829a3caaf6f86f32c77dd2f273
[WebKit-https.git] / Tools / ChangeLog
1 2011-11-17  Adam Roben  <aroben@apple.com>
2
3         Remove extra quoting of call stacks and types passed to run-leaks by NRWT
4
5         Fixes <http://webkit.org/b/72623> REGRESSION (NRWT): run-webkit-tests --leaks reports leaks
6         that are supposed to be ignored
7
8         Reviewed by Adam Barth.
9
10         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
11         (LeakDetector._leaks_args): Removed extra quoting of call stacks and types. Quoting is only
12         required when passing arguments via the shell (which we aren't doing here). It is not
13         required by Perl's option-parsing code (as the comment I removed mistakenly claimed).
14
15         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
16         (LeakDetectorTest.test_leaks_args): Updated expectations.
17
18 2011-11-17  Philippe Normand  <pnormand@igalia.com>
19
20         Unreviewed, run-bindings-tests fix after r91028.
21
22         * Scripts/run-bindings-tests: Use scm.detection module.
23
24 2011-11-17  Jochen Eisinger  <jochen@chromium.org>
25
26         Silence a warning about control reaching the end of a non-void function
27         https://bugs.webkit.org/show_bug.cgi?id=72616
28
29         Reviewed by Tony Gentilcore.
30
31         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
32         (AccessibilityUIElement::verticalScrollbar):
33
34 2011-11-17  Adam Roben  <aroben@apple.com>
35
36         Ignore some leaks in frameworks we link against on Lion
37
38         Fixes <http://webkit.org/b/72609> Lion Leaks bot complains about a bunch of leaks that
39         aren't WebKit's fault
40
41         Reviewed by Antti Koivisto.
42
43         * Scripts/old-run-webkit-tests:
44         (countAndPrintLeaks):
45         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
46         (LeakDetector._callstacks_to_exclude_from_leaks):
47         Added some call stacks to exclude on Lion that represent leaks in lower-level frameworks.
48
49         * Scripts/webkitpy/layout_tests/port/mac.py:
50         (MacPort.is_lion): Added.
51
52         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
53         (MacPortTest.test_is_version_methods): Added tests for the is_leopard/is_snowleopard/is_lion
54         methods.
55
56 2011-11-17  Philippe Normand  <pnormand@igalia.com>
57
58         [GTK] Disable ref tests
59         https://bugs.webkit.org/show_bug.cgi?id=72599
60
61         Reviewed by Xan Lopez.
62
63         * Scripts/webkitpy/layout_tests/port/gtk.py: Enforce disabled ref
64         tests to avoid massive flakiness.
65
66 2011-11-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
67
68         [Qt] Move WebKit2 C++ APIs to private API and build QML extension plugin on top of that
69
70         A new extension object has been added to QQuickWebView (the same approach should be used
71         for other API classes that need experimental APIs). The QML extension mechanism is then
72         built on top of the experimental object.
73
74         https://bugs.webkit.org/show_bug.cgi?id=72522
75
76         Reviewed by Simon Hausmann.
77
78         * MiniBrowser/qt/BrowserWindow.cpp:
79         (BrowserWindow::BrowserWindow):
80         (BrowserWindow::webView):
81         * MiniBrowser/qt/BrowserWindow.h:
82         * MiniBrowser/qt/UrlLoader.cpp:
83         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
84         * qmake/mkspecs/features/default_post.prf:
85         * qmake/mkspecs/features/default_pre.prf:
86         * qmake/mkspecs/features/qtwebkit-private.prf: Added.
87         * qmake/mkspecs/features/qtwebkit.prf:
88
89 2011-11-17  Adam Barth  <abarth@webkit.org>
90
91         Move test_results_uploader.py out of layout_package
92         https://bugs.webkit.org/show_bug.cgi?id=72590
93
94         Reviewed by Eric Seidel.
95
96         Most of the lines of code in this file are wrong, but I've restrained
97         myself and only changed a few of them to generalized this class to the
98         common package.
99
100         This is part of a series of patches to remove layout_package.
101
102         * Scripts/webkitpy/common/net/file_uploader.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py.
103         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
104         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py: Removed.
105
106 2011-11-17  Adam Barth  <abarth@webkit.org>
107
108         Unreviewed. Fix style nits in printing.py.
109
110         * Scripts/webkitpy/layout_tests/views/printing.py:
111
112 2011-11-17  Adam Barth  <abarth@webkit.org>
113
114         Minor style nits in run_webkit_tests.py
115         https://bugs.webkit.org/show_bug.cgi?id=72583
116
117         Reviewed by Eric Seidel.
118
119         This patch just fixes some minor style issues as I work my way back
120         into this code.
121
122         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
123
124 2011-11-17  Adam Barth  <abarth@webkit.org>
125
126         Move test_result_writer out of layout_package
127         https://bugs.webkit.org/show_bug.cgi?id=72586
128
129         Rubber-stamped by Eric Seidel.
130
131         This is part of a series of patches to remove layout_package.
132
133         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
134         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py.
135         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Removed.
136         * Scripts/webkitpy/tool/commands/rebaseline.py:
137
138 2011-11-17  Adam Barth  <abarth@webkit.org>
139
140         svn-apply shouldn't magically move files into Source anymore
141         https://bugs.webkit.org/show_bug.cgi?id=72579
142
143         Reviewed by Eric Seidel.
144
145         The Source directory has existed for long enough that we don't need
146         svn-apply to magically re-write old-style patches anymore.
147
148         * Scripts/VCSUtils.pm:
149         (parseGitDiffHeader):
150         (parseSvnDiffHeader):
151
152 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
153
154         Add a list of contribution areas
155         https://bugs.webkit.org/show_bug.cgi?id=72566
156
157         Reviewed by Eric Seidel.
158
159         Added ContributionAreas class.
160
161         * Scripts/webkitpy/common/config/contributionareas.py: Added.
162         * Scripts/webkitpy/common/config/contributionareas_unittest.py: Added.
163
164 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
165
166         Refactor ChangeLogTest.test_parse_reviewer_text
167         https://bugs.webkit.org/show_bug.cgi?id=72572
168
169         Reviewed by Eric Seidel.
170
171         Refactored the test code by introduing two helper functions.
172
173         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
174
175 2011-11-16  Eric Seidel  <eric@webkit.org>
176
177         Add SCMDetector object to make scm detection mockable
178         https://bugs.webkit.org/show_bug.cgi?id=72247
179
180         Reviewed by Adam Barth.
181
182         I think SCM detection may eventually be rolled into Checkout,
183         but this patch at least makes it possible to mock code-paths
184         which rely on scm detection.
185         In the process of replacing callers of these free-functions
186         I found that one of the functions was no longer used,
187         and that one of the callers could instead just use the SCM
188         object it already had access to through port.host.scm().
189         I also discovered that I was not calling Host._initialize_scm()
190         and thus host.scm() was always returning None!
191
192         * Scripts/check-webkit-style:
193         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
194         * Scripts/webkitpy/common/checkout/deps.py:
195         * Scripts/webkitpy/common/checkout/scm/__init__.py:
196         * Scripts/webkitpy/common/checkout/scm/detection.py:
197         * Scripts/webkitpy/common/checkout/scm/git.py:
198         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
199         * Scripts/webkitpy/common/checkout/scm/svn.py:
200         * Scripts/webkitpy/common/host.py:
201         * Scripts/webkitpy/common/host_mock.py:
202         * Scripts/webkitpy/layout_tests/controllers/manager.py:
203         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
204         * Scripts/webkitpy/layout_tests/port/base.py:
205         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
206         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
207         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
208         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
209
210 2011-11-16  Mark Rowe  <mrowe@apple.com>
211
212         Fix the build.
213
214         The C++ standard library interferes with Objective-C exceptions when built with -fno-exceptions.
215         Apply the workaround that we use in other projects to WebKitTestRunner.
216
217         * WebKitTestRunner/Configurations/Base.xcconfig: Use the prefix header for all targets.
218         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
219         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Work around the C++ standard library obnoxiousness.
220
221 2011-11-16  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
222
223         [Qt] Fix build after WTR AX support
224         https://bugs.webkit.org/show_bug.cgi?id=72560
225
226         Reviewed by Geoffrey Garen.
227
228         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
229         * WebKitTestRunner/InjectedBundle/Target.pri:
230
231 2011-11-16  Tony Chang  <tony@chromium.org>
232
233         repurpose the flexbox bot for grid layout
234         https://bugs.webkit.org/show_bug.cgi?id=72557
235
236         Reviewed by Ryosuke Niwa.
237
238         Since new flexbox is enabled everywhere, we don't need this bot
239         anymore.  However, work on grid layout has begun, so we can use this
240         bot to compile with ENABLE_CSS_GRID_LAYOUT.
241
242         * BuildSlaveSupport/build.webkit.org-config/config.json: Just rename
243         the bot on the waterfall, I will change the slave config to enable
244         the compile flag and tests.
245
246 2011-11-11  Adrienne Walker  <enne@google.com>
247
248         [chromium] Expose mock scrollbars to window.internals
249         https://bugs.webkit.org/show_bug.cgi?id=72195
250
251         Reviewed by James Robinson.
252
253         Because mock scrollbars are a global setting, reset between runs.
254
255         * DumpRenderTree/chromium/WebPreferences.cpp:
256         (WebPreferences::applyTo):
257
258 2011-11-16  James Robinson  <jamesr@chromium.org>
259
260         [chromium] Enable video and canvas 2d compositing triggers by default for layout tests in the compositing directory
261         https://bugs.webkit.org/show_bug.cgi?id=72562
262
263         Reviewed by Dirk Pranke.
264
265         * DumpRenderTree/chromium/TestShell.cpp:
266         (TestShell::runFileTest):
267
268 2011-11-16  Tony Chang  <tony@chromium.org>
269
270         [NRWT] speculative fix for multiple subprocess test on cygwin
271         https://bugs.webkit.org/show_bug.cgi?id=72518
272
273         Reviewed by Adam Barth.
274
275         * Scripts/webkitpy/layout_tests/port/chromium.py: cygwin probably
276             tries to emulate posix fd behavior.
277         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
278
279 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
280
281         Revert r100509; change was committed twice (first time as r100491).
282         Unreviewed, build fix.
283
284         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
285
286 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
287
288         Run a dummy test in the gpu configurations if there's nothing to do.
289         https://bugs.webkit.org/show_bug.cgi?id=72498
290
291         Reviewed by James Robinson.
292
293         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
294
295 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
296
297         contributors_by_fuzzy_match is super slow
298         https://bugs.webkit.org/show_bug.cgi?id=72540
299
300         Reviewed by Eric Seidel.
301
302         Make contributors_by_name do case insensitive search using a dictionary.
303
304         Also call contributors_by_name first in contributors_by_fuzzy_match now that it's fast
305         because that's the most common case.
306
307         * Scripts/webkitpy/common/config/committers.py:
308         * Scripts/webkitpy/common/config/committers_unittest.py:
309
310 2011-11-16  David Levin  <levin@chromium.org>
311
312         check-webkit-style should recognize functions even if they have OVERRIDE after them.
313         https://bugs.webkit.org/show_bug.cgi?id=72515
314
315         Reviewed by Adam Barth.
316
317         * Scripts/webkitpy/style/checkers/cpp.py:
318         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
319
320 2011-11-16  Tony Chang  <tony@chromium.org>
321
322         [NRWT] refactor drivers to require pixel_tests param
323         https://bugs.webkit.org/show_bug.cgi?id=72517
324
325         Reviewed by Ojan Vafai.
326
327         No tests, just a refactoring.
328
329         * Scripts/webkitpy/layout_tests/port/chromium.py:
330         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
331         * Scripts/webkitpy/layout_tests/port/webkit.py:
332         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
333
334 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
335
336         Run a dummy test in the gpu configurations if there's nothing to do.
337         https://bugs.webkit.org/show_bug.cgi?id=72498
338
339         Reviewed by James Robinson.
340
341         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
342
343 2011-11-16  Chris Fleizach  <cfleizach@apple.com>
344
345         WebKitTestRunner needs to support accessibility-related DRT APIs
346         https://bugs.webkit.org/show_bug.cgi?id=42131
347
348         Reviewed by Beth Dakin.
349
350         Port the AX code in DRT to WKTestRunner by using IDL.
351
352         * DumpRenderTree/AccessibilityUIElement.cpp:
353         (horizontalScrollbarCallback):
354         (verticalScrollbarCallback):
355         (AccessibilityUIElement::horizontalScrollbar):
356         (AccessibilityUIElement::verticalScrollbar):
357         (AccessibilityUIElement::getJSClass):
358         * DumpRenderTree/AccessibilityUIElement.h:
359         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
360         (AccessibilityUIElement::horizontalScrollbar):
361         (AccessibilityUIElement::verticalScrollbar):
362         * WebKitTestRunner/DerivedSources.make:
363         * WebKitTestRunner/GNUmakefile.am:
364         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Added.
365         (WTR::AccessibilityController::create):
366         (WTR::AccessibilityController::AccessibilityController):
367         (WTR::AccessibilityController::~AccessibilityController):
368         (WTR::AccessibilityController::makeWindowObject):
369         (WTR::AccessibilityController::wrapperClass):
370         (WTR::AccessibilityController::rootElement):
371         (WTR::AccessibilityController::focusedElement):
372         (WTR::AccessibilityController::elementAtPoint):
373         * WebKitTestRunner/InjectedBundle/AccessibilityController.h: Added.
374         (WTR::AccessibilityController::logFocusEvents):
375         (WTR::AccessibilityController::logValueChangeEvents):
376         (WTR::AccessibilityController::logScrollingStartEvents):
377         (WTR::AccessibilityController::logAccessibilityEvents):
378         (WTR::AccessibilityController::addNotificationListener):
379         (WTR::AccessibilityController::notificationReceived):
380         (WTR::AccessibilityController::resetToConsistentState):
381         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: Added.
382         (WTR::AccessibilityTextMarker::create):
383         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
384         (WTR::AccessibilityTextMarker::~AccessibilityTextMarker):
385         (WTR::AccessibilityTextMarker::platformTextMarker):
386         (WTR::AccessibilityTextMarker::wrapperClass):
387         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.h: Added.
388         (WTR::AccessibilityTextMarker::isEqual):
389         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: Added.
390         (WTR::AccessibilityTextMarkerRange::create):
391         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
392         (WTR::AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
393         (WTR::AccessibilityTextMarkerRange::platformTextMarkerRange):
394         (WTR::AccessibilityTextMarkerRange::wrapperClass):
395         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.h: Added.
396         (WTR::AccessibilityTextMarkerRange::isEqual):
397         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: Added.
398         (WTR::AccessibilityUIElement::create):
399         (WTR::AccessibilityUIElement::wrapperClass):
400         (WTR::AccessibilityUIElement::isValid):
401         (WTR::AccessibilityUIElement::AccessibilityUIElement):
402         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
403         (WTR::AccessibilityUIElement::isEqual):
404         (WTR::AccessibilityUIElement::elementAtPoint):
405         (WTR::AccessibilityUIElement::childAtIndex):
406         (WTR::AccessibilityUIElement::indexOfChild):
407         (WTR::AccessibilityUIElement::childrenCount):
408         (WTR::AccessibilityUIElement::titleUIElement):
409         (WTR::AccessibilityUIElement::parentElement):
410         (WTR::AccessibilityUIElement::takeFocus):
411         (WTR::AccessibilityUIElement::takeSelection):
412         (WTR::AccessibilityUIElement::addSelection):
413         (WTR::AccessibilityUIElement::removeSelection):
414         (WTR::AccessibilityUIElement::allAttributes):
415         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
416         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
417         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
418         (WTR::AccessibilityUIElement::attributesOfChildren):
419         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
420         (WTR::AccessibilityUIElement::increment):
421         (WTR::AccessibilityUIElement::decrement):
422         (WTR::AccessibilityUIElement::showMenu):
423         (WTR::AccessibilityUIElement::press):
424         (WTR::AccessibilityUIElement::stringAttributeValue):
425         (WTR::AccessibilityUIElement::uiElementAttributeValue):
426         (WTR::AccessibilityUIElement::numberAttributeValue):
427         (WTR::AccessibilityUIElement::boolAttributeValue):
428         (WTR::AccessibilityUIElement::isAttributeSupported):
429         (WTR::AccessibilityUIElement::isAttributeSettable):
430         (WTR::AccessibilityUIElement::isActionSupported):
431         (WTR::AccessibilityUIElement::role):
432         (WTR::AccessibilityUIElement::subrole):
433         (WTR::AccessibilityUIElement::roleDescription):
434         (WTR::AccessibilityUIElement::title):
435         (WTR::AccessibilityUIElement::description):
436         (WTR::AccessibilityUIElement::language):
437         (WTR::AccessibilityUIElement::stringValue):
438         (WTR::AccessibilityUIElement::accessibilityValue):
439         (WTR::AccessibilityUIElement::helpText):
440         (WTR::AccessibilityUIElement::orientation):
441         (WTR::AccessibilityUIElement::x):
442         (WTR::AccessibilityUIElement::y):
443         (WTR::AccessibilityUIElement::width):
444         (WTR::AccessibilityUIElement::height):
445         (WTR::AccessibilityUIElement::intValue):
446         (WTR::AccessibilityUIElement::minValue):
447         (WTR::AccessibilityUIElement::maxValue):
448         (WTR::AccessibilityUIElement::valueDescription):
449         (WTR::AccessibilityUIElement::insertionPointLineNumber):
450         (WTR::AccessibilityUIElement::selectedTextRange):
451         (WTR::AccessibilityUIElement::isEnabled):
452         (WTR::AccessibilityUIElement::isRequired):
453         (WTR::AccessibilityUIElement::isFocused):
454         (WTR::AccessibilityUIElement::isFocusable):
455         (WTR::AccessibilityUIElement::isSelected):
456         (WTR::AccessibilityUIElement::isSelectable):
457         (WTR::AccessibilityUIElement::isMultiSelectable):
458         (WTR::AccessibilityUIElement::setSelectedChild):
459         (WTR::AccessibilityUIElement::selectedChildrenCount):
460         (WTR::AccessibilityUIElement::selectedChildAtIndex):
461         (WTR::AccessibilityUIElement::isExpanded):
462         (WTR::AccessibilityUIElement::isChecked):
463         (WTR::AccessibilityUIElement::isVisible):
464         (WTR::AccessibilityUIElement::isOffScreen):
465         (WTR::AccessibilityUIElement::isCollapsed):
466         (WTR::AccessibilityUIElement::isIgnored):
467         (WTR::AccessibilityUIElement::hasPopup):
468         (WTR::AccessibilityUIElement::hierarchicalLevel):
469         (WTR::AccessibilityUIElement::clickPointX):
470         (WTR::AccessibilityUIElement::clickPointY):
471         (WTR::AccessibilityUIElement::documentEncoding):
472         (WTR::AccessibilityUIElement::documentURI):
473         (WTR::AccessibilityUIElement::url):
474         (WTR::AccessibilityUIElement::speak):
475         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
476         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
477         (WTR::AccessibilityUIElement::attributesOfColumns):
478         (WTR::AccessibilityUIElement::attributesOfRows):
479         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
480         (WTR::AccessibilityUIElement::attributesOfHeader):
481         (WTR::AccessibilityUIElement::indexInTable):
482         (WTR::AccessibilityUIElement::rowIndexRange):
483         (WTR::AccessibilityUIElement::columnIndexRange):
484         (WTR::AccessibilityUIElement::rowCount):
485         (WTR::AccessibilityUIElement::columnCount):
486         (WTR::AccessibilityUIElement::selectedRowAtIndex):
487         (WTR::AccessibilityUIElement::disclosedByRow):
488         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
489         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
490         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
491         (WTR::AccessibilityUIElement::ariaIsGrabbed):
492         (WTR::AccessibilityUIElement::ariaDropEffects):
493         (WTR::AccessibilityUIElement::lineForIndex):
494         (WTR::AccessibilityUIElement::rangeForLine):
495         (WTR::AccessibilityUIElement::boundsForRange):
496         (WTR::AccessibilityUIElement::setSelectedTextRange):
497         (WTR::AccessibilityUIElement::stringForRange):
498         (WTR::AccessibilityUIElement::attributedStringForRange):
499         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
500         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
501         (WTR::AccessibilityUIElement::cellForColumnAndRow):
502         (WTR::AccessibilityUIElement::horizontalScrollbar):
503         (WTR::AccessibilityUIElement::verticalScrollbar):
504         (WTR::AccessibilityUIElement::addNotificationListener):
505         (WTR::AccessibilityUIElement::removeNotificationListener):
506         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
507         (WTR::AccessibilityUIElement::textMarkerRangeLength):
508         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
509         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
510         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
511         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
512         (WTR::AccessibilityUIElement::textMarkerForPoint):
513         (WTR::AccessibilityUIElement::previousTextMarker):
514         (WTR::AccessibilityUIElement::nextTextMarker):
515         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
516         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added.
517         (WTR::AccessibilityUIElement::platformUIElement):
518         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl: Added.
519         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl: Added.
520         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl: Added.
521         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: Added.
522         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
523         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
524         (WTR::InjectedBundle::beginTesting):
525         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
526         (WTR::InjectedBundle::accessibilityController):
527         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
528         (WTR::InjectedBundlePage::didClearWindowForFrame):
529         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
530         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp:
531         (WTR::LayoutTestController::platformName):
532         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerMac.mm: Added.
533         (WTR::AccessibilityTextMarker::isEqual):
534         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerRangeMac.mm: Added.
535         (WTR::AccessibilityTextMarkerRange::isEqual):
536         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: Added.
537         (+[NSString stringWithJSStringRef:]):
538         (-[NSString createJSStringRef]):
539         (-[AccessibilityNotificationHandler initWithPlatformElement:]):
540         (-[AccessibilityNotificationHandler dealloc]):
541         (-[AccessibilityNotificationHandler _notificationReceived:]):
542         (-[AccessibilityNotificationHandler setCallback:]):
543         (WTR::AccessibilityUIElement::AccessibilityUIElement):
544         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
545         (WTR::AccessibilityUIElement::isEqual):
546         (WTR::descriptionOfValue):
547         (WTR::attributesOfElement):
548         (WTR::concatenateAttributeAndValue):
549         (WTR::convertNSArrayToVector):
550         (WTR::descriptionOfElements):
551         (WTR::AccessibilityUIElement::getLinkedUIElements):
552         (WTR::AccessibilityUIElement::getDocumentLinks):
553         (WTR::AccessibilityUIElement::getChildren):
554         (WTR::AccessibilityUIElement::getChildrenWithRange):
555         (WTR::AccessibilityUIElement::childrenCount):
556         (WTR::AccessibilityUIElement::elementAtPoint):
557         (WTR::AccessibilityUIElement::indexOfChild):
558         (WTR::AccessibilityUIElement::childAtIndex):
559         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
560         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
561         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
562         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
563         (WTR::AccessibilityUIElement::selectedChildAtIndex):
564         (WTR::AccessibilityUIElement::selectedChildrenCount):
565         (WTR::AccessibilityUIElement::selectedRowAtIndex):
566         (WTR::AccessibilityUIElement::titleUIElement):
567         (WTR::AccessibilityUIElement::parentElement):
568         (WTR::AccessibilityUIElement::disclosedByRow):
569         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
570         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
571         (WTR::AccessibilityUIElement::attributesOfChildren):
572         (WTR::AccessibilityUIElement::allAttributes):
573         (WTR::AccessibilityUIElement::stringAttributeValue):
574         (WTR::AccessibilityUIElement::numberAttributeValue):
575         (WTR::AccessibilityUIElement::uiElementAttributeValue):
576         (WTR::AccessibilityUIElement::boolAttributeValue):
577         (WTR::AccessibilityUIElement::isAttributeSettable):
578         (WTR::AccessibilityUIElement::isAttributeSupported):
579         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
580         (WTR::AccessibilityUIElement::role):
581         (WTR::AccessibilityUIElement::subrole):
582         (WTR::AccessibilityUIElement::roleDescription):
583         (WTR::AccessibilityUIElement::title):
584         (WTR::AccessibilityUIElement::description):
585         (WTR::AccessibilityUIElement::orientation):
586         (WTR::AccessibilityUIElement::stringValue):
587         (WTR::AccessibilityUIElement::language):
588         (WTR::AccessibilityUIElement::helpText):
589         (WTR::AccessibilityUIElement::x):
590         (WTR::AccessibilityUIElement::y):
591         (WTR::AccessibilityUIElement::width):
592         (WTR::AccessibilityUIElement::height):
593         (WTR::AccessibilityUIElement::clickPointX):
594         (WTR::AccessibilityUIElement::clickPointY):
595         (WTR::AccessibilityUIElement::intValue):
596         (WTR::AccessibilityUIElement::minValue):
597         (WTR::AccessibilityUIElement::maxValue):
598         (WTR::AccessibilityUIElement::valueDescription):
599         (WTR::AccessibilityUIElement::insertionPointLineNumber):
600         (WTR::AccessibilityUIElement::isActionSupported):
601         (WTR::AccessibilityUIElement::isEnabled):
602         (WTR::AccessibilityUIElement::isRequired):
603         (WTR::AccessibilityUIElement::isFocused):
604         (WTR::AccessibilityUIElement::isSelected):
605         (WTR::AccessibilityUIElement::isExpanded):
606         (WTR::AccessibilityUIElement::isChecked):
607         (WTR::AccessibilityUIElement::hierarchicalLevel):
608         (WTR::AccessibilityUIElement::speak):
609         (WTR::AccessibilityUIElement::ariaIsGrabbed):
610         (WTR::AccessibilityUIElement::ariaDropEffects):
611         (WTR::AccessibilityUIElement::lineForIndex):
612         (WTR::AccessibilityUIElement::rangeForLine):
613         (WTR::AccessibilityUIElement::boundsForRange):
614         (WTR::AccessibilityUIElement::stringForRange):
615         (WTR::AccessibilityUIElement::attributedStringForRange):
616         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
617         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
618         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
619         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
620         (WTR::AccessibilityUIElement::attributesOfColumns):
621         (WTR::AccessibilityUIElement::attributesOfRows):
622         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
623         (WTR::AccessibilityUIElement::attributesOfHeader):
624         (WTR::AccessibilityUIElement::rowCount):
625         (WTR::AccessibilityUIElement::columnCount):
626         (WTR::AccessibilityUIElement::indexInTable):
627         (WTR::AccessibilityUIElement::rowIndexRange):
628         (WTR::AccessibilityUIElement::columnIndexRange):
629         (WTR::AccessibilityUIElement::cellForColumnAndRow):
630         (WTR::AccessibilityUIElement::horizontalScrollbar):
631         (WTR::AccessibilityUIElement::verticalScrollbar):
632         (WTR::AccessibilityUIElement::selectedTextRange):
633         (WTR::AccessibilityUIElement::setSelectedTextRange):
634         (WTR::AccessibilityUIElement::increment):
635         (WTR::AccessibilityUIElement::decrement):
636         (WTR::AccessibilityUIElement::showMenu):
637         (WTR::AccessibilityUIElement::press):
638         (WTR::AccessibilityUIElement::setSelectedChild):
639         (WTR::AccessibilityUIElement::accessibilityValue):
640         (WTR::AccessibilityUIElement::documentEncoding):
641         (WTR::AccessibilityUIElement::documentURI):
642         (WTR::AccessibilityUIElement::url):
643         (WTR::AccessibilityUIElement::addNotificationListener):
644         (WTR::AccessibilityUIElement::removeNotificationListener):
645         (WTR::AccessibilityUIElement::isFocusable):
646         (WTR::AccessibilityUIElement::isSelectable):
647         (WTR::AccessibilityUIElement::isMultiSelectable):
648         (WTR::AccessibilityUIElement::isVisible):
649         (WTR::AccessibilityUIElement::isOffScreen):
650         (WTR::AccessibilityUIElement::isCollapsed):
651         (WTR::AccessibilityUIElement::isIgnored):
652         (WTR::AccessibilityUIElement::hasPopup):
653         (WTR::AccessibilityUIElement::takeFocus):
654         (WTR::AccessibilityUIElement::takeSelection):
655         (WTR::AccessibilityUIElement::addSelection):
656         (WTR::AccessibilityUIElement::removeSelection):
657         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
658         (WTR::AccessibilityUIElement::textMarkerRangeLength):
659         (WTR::AccessibilityUIElement::previousTextMarker):
660         (WTR::AccessibilityUIElement::nextTextMarker):
661         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
662         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
663         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
664         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
665         (WTR::AccessibilityUIElement::textMarkerForPoint):
666         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
667         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
668         (WTR::LayoutTestController::platformName):
669         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
670         (WTR::LayoutTestController::platformName):
671         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
672         (WTR::LayoutTestController::platformName):
673         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
674         * WebKitTestRunner/win/InjectedBundle.vcproj:
675
676 2011-11-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
677
678         [Qt] Fix use of config.tests
679
680         We were checking @buildArgs to determine if the optional argument was
681         passed or not, but this is not the right way to do that in Perl. The
682         right way is to not use a prototype for the function, and to pass
683         the list as a reference (to avoid list expansion). That way we can
684         check the number of arguments, and choose the right code path based
685         on that.
686
687         We were also missing a default-value of 0 for any feature that's not
688         set in features.prf.
689
690         Reviewed by Kenneth Rohde Christiansen.
691
692         * Scripts/build-webkit:
693         * Scripts/webkitdirs.pm:
694         (qtFeatureDefaults):
695         (buildQMakeProject):
696
697 2011-11-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
698
699         [Qt] Prospective fix for broken plugin tests
700
701         Don't hide symbols for the NPAPI test plugin
702
703         Rubber-stamped by Andreas Kling.
704
705         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
706
707 2011-11-16  Adam Roben  <aroben@apple.com>
708
709         Move filenames/line numbers off to the right edge in Leaks Viewer
710
711         Fixes <http://webkit.org/b/72510> Callstacks in Leaks Viewer are a little hard to read
712         because filenames/line numbers are right next to function names
713
714         Reviewed by Andreas Kling.
715
716         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js:
717         (LeaksParserImpl.prototype._createNode): Separate the filename and line number out from the
718         function name. Use the filename as the profile node's URL (we don't have enough info to
719         compute a real URL currently) and the line number as the profile node's line number so the
720         Inspector code will put them on the right side of the callstack graph.
721
722         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
723         (WebInspector.displayNameForURL): Stubbed this out. For now we don't ever get any URLs
724         passed here, just filenames.
725
726         (WebInspector.linkifyURLAsNode):
727         (WebInspector.linkifyResourceAsNode):
728         Copied and slightly modified from inspector.js.
729
730 2011-11-16  Adam Roben  <aroben@apple.com>
731
732         Make Leaks Viewer load builds from the new Lion Leaks bot
733
734         Fixes <http://webkit.org/b/72507> REGRESSION: Leaks Viewer no longer shows recent leaky builds
735
736         Reviewed by Andreas Kling.
737
738         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
739         (LeaksViewer._displayURLPrompt): Use the Lion Leaks bot instead of the nonexistent
740         SnowLeopard one.
741
742 2011-11-16  Raphael Kubo da Costa  <kubo@profusion.mobi>
743
744         [EFL] Clean up the offline apps-related functions in ewk_settings.
745         https://bugs.webkit.org/show_bug.cgi?id=72132
746
747         Reviewed by Kenneth Rohde Christiansen.
748
749         `ewk_settings_cache' and `ewk_view_setting_cache' are too common
750         prefixes for code that is related only to the HTML5 app cache
751         features.
752
753         Use `ewk_settings_application_cache' and
754         `ewk_view_setting_application_cache' instead.
755
756         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
757         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
758
759 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
760
761         [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
762
763         Reviewed by Tor Arne Vestbø.
764
765         * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
766         magic here where we handle all TEMPLATE = lib .pro files (except plugins).
767         * WebKitTestRunner/InjectedBundle/Target.pri: Mark the injected bundle as plugin, which also
768         removes the .so.0.0.0 and just produces .so.
769
770 2011-11-16  Peter Beverloo  <peter@chromium.org>
771
772         Explicitly include unistd.h in TestNetscapePlugIn
773         https://bugs.webkit.org/show_bug.cgi?id=72385
774
775         This is needed for the sleep() call in the indicateTestFailure method,
776         which seems to be implicitly available for other platforms. This is not
777         the case on Android.
778
779         Reviewed by Steve Block.
780
781         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
782
783 2011-11-16  Peter Beverloo  <peter@chromium.org>
784
785         [Chromium] Update the Android NDK version being pulled in by update-webkit-chromium
786         https://bugs.webkit.org/show_bug.cgi?id=72384
787
788         Update to Android NDK r7, which was released last Friday. This adds
789         support for RTTI and the -mimplicit-it gcc flag, which are required to
790         respectively build ICU and Skia.
791
792         Reviewed by Steve Block.
793
794         * Scripts/update-webkit-chromium:
795         * Scripts/webkitdirs.pm:
796         (buildChromiumMakefile):
797
798 2011-11-16  Simon Hausmann  <simon.hausmann@nokia.com>
799
800         Unreviewed, rolling out r100266.
801         http://trac.webkit.org/changeset/100266
802
803         Broke WTR.
804
805         * qmake/mkspecs/features/default_post.prf:
806
807 2011-11-16  Eric Seidel  <eric@webkit.org>
808
809         check-webkit-style broken by r99773: "Could not determine the port"
810         https://bugs.webkit.org/show_bug.cgi?id=72275
811
812         Reviewed by Adam Barth.
813
814         I will continue engaging hacks, until windows improves.
815
816         * Scripts/webkitpy/common/host.py:
817          - Host uses self.executive instead of self._executive like Port does.
818          - I wanted to test this, but it mutates global state -- thus impossible to unittest at this time.
819
820 2011-11-16  Eric Seidel  <eric@webkit.org>
821
822         check-webkit-style broken by r99773: "Could not determine the port"
823         https://bugs.webkit.org/show_bug.cgi?id=72275
824
825         Reviewed by Adam Barth.
826
827         Engage windows hacks harder.
828
829         This is a speculative fix for ChromiumWin.  We're now
830         creating an SCM object much earlier, so we need to
831         engage our "awesome" windows hacks earlier.
832
833         * Scripts/webkitpy/common/host.py:
834         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
835
836 2011-11-15  Darin Adler  <darin@apple.com>
837
838         DRT's uiElementAttributeValueCallback function is leaky
839         https://bugs.webkit.org/show_bug.cgi?id=72453
840
841         Reviewed by Dan Bernstein.
842
843         * DumpRenderTree/AccessibilityUIElement.cpp:
844         (uiElementAttributeValueCallback): Use JSRetainPtr and don't leak.
845
846 2011-11-14  Ryosuke Niwa  <rniwa@webkit.org>
847
848         Implement edit-distance based reviewer recognition algorithm
849         https://bugs.webkit.org/show_bug.cgi?id=72351
850
851         Reviewed by Eric Seidel.
852
853         Implement an algorithm to recognize reviewer's name based on its edit distance (or more precisely
854         its Levenshtein distance) to each reviewer's full name, first, last and middle names, and IRC nicknames.
855         Furthermore, we cap the maximum edit distance at len(name) - 1 to avoid matching a bogus string like
856         "build fix" to a reviewer's name (e.g. with with edit distance 9).
857
858         This algorithm is implemented in CommitterList.contributors_by_fuzzy_match. The function to compute
859         the edit distance is implemented in edit_distance.py.
860
861         Also moved _has_valid_reviewer from ValidateReviewer to ChangeLogEntry because we can no longer rely
862         on the presence of ChangeLogEntry.reviewer() to verify that reviewer string is nicely formatted.
863
864         * Scripts/webkitpy/common/checkout/changelog.py:
865         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
866         * Scripts/webkitpy/common/config/committers.py:
867         * Scripts/webkitpy/common/config/committers_unittest.py:
868         * Scripts/webkitpy/common/editdistance.py: Added.
869         * Scripts/webkitpy/common/editdistance_unittest.py: Added.
870         * Scripts/webkitpy/tool/steps/validatereviewer.py:
871         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: Removed.
872
873 2011-11-15  Tony Chang  <tony@chromium.org>
874
875         Skip a failing webkitpy test on cygwin.
876
877         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
878
879 2011-11-15  Sam Weinig  <sam@webkit.org>
880
881         TestWebKitAPI should not put its resources in the root products directory
882         https://bugs.webkit.org/show_bug.cgi?id=72446
883
884         Reviewed by Anders Carlsson.
885
886         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
887         Change the copy resources phase to place the resources in a TestWebKitAPI.resources
888         directory.
889
890         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
891         (TEST_F):
892         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
893         (TestWebKitAPI::TEST):
894         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
895         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
896         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
897         (TestWebKitAPI::DynamicDeviceScaleFactor::url):
898         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
899         (TestWebKitAPI::Util::createURLForResource):
900         Update calls to retrieve files from the bundle to look in the newly
901         created subdirectory.
902
903 2011-11-15  Tony Chang  <tony@chromium.org>
904
905         Fix a webkitpy test caused by renaming the accelerate-video flag in r100355.
906
907         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
908
909 2011-11-15  Tony Chang  <tony@chromium.org>
910
911         Unreviewed, fix test-webkitpy tests.  Move the check for image results
912         earlier.
913
914         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
915         * Scripts/webkitpy/layout_tests/port/webkit.py:
916
917 2011-11-15  James Robinson  <jamesr@chromium.org>
918
919         [chromium] Fix flag name in chromium DumpRenderTree for accelerated video trigger
920         https://bugs.webkit.org/show_bug.cgi?id=72444
921
922         Reviewed by Adam Barth.
923
924         * DumpRenderTree/chromium/DumpRenderTree.cpp:
925
926 2011-11-15  Tony Chang  <tony@chromium.org>
927
928         Unreviewed, better fix for ref tests failures on SL Intel bot.
929         Revert the previous change and return None if pixel results from
930         either the test page or the expected page is missing.
931
932         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
933         * Scripts/webkitpy/layout_tests/port/webkit.py:
934
935 2011-11-15  James Robinson  <jamesr@chromium.org>
936
937         [chromium] Merge chromium-gpu layout test configurations into non-gpu versions
938         https://bugs.webkit.org/show_bug.cgi?id=72402
939
940         Reviewed by Dirk Pranke.
941
942         Allows the compositing layout tests to run in the normal layout test run. This sets the default compositing
943         triggers in DumpRenderTree to more closely match what we use in Chromium. There are two exceptions, canvas 2d
944         and video (media) are still controlled by an explicit trigger so that they are true when platform=chromium-gpu
945         and false otherwise, so that we can run the same set of tests in both configurations. This isn't necessary for
946         the normal compositing triggers since we currently run the compositing tests in only one configuration - with
947         compositing enabled.
948
949         Since the compositing tests are currently marked WONTFIX SKIP on non-GPU platforms in test_expectations.txt this
950         patch should not impact any tests.
951
952         * DumpRenderTree/chromium/DumpRenderTree.cpp:
953         (main):
954         * DumpRenderTree/chromium/TestShell.cpp:
955         (TestShell::TestShell):
956         (TestShell::resetWebSettings):
957         * DumpRenderTree/chromium/TestShell.h:
958         (TestShell::setAcceleratedCompositingForVideoEnabled):
959         * DumpRenderTree/chromium/WebPreferences.cpp:
960         (WebPreferences::reset):
961         (WebPreferences::applyTo):
962         * DumpRenderTree/chromium/WebPreferences.h:
963         * Scripts/webkitpy/layout_tests/port/chromium.py:
964         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
965         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
966
967 2011-11-15  Tony Chang  <tony@chromium.org>
968
969         Unreviewed, try to fix ref tests failures on SL Intel bot.
970         It looks like ImageDiff isn't returning an image diff.
971
972         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
973
974 2011-11-15  Tony Chang  <tony@chromium.org>
975
976         Unreviewed fix of ref-tests on GTK+.
977         If a driver is never started, _xvfb_process is never set.
978
979         * Scripts/webkitpy/layout_tests/port/gtk.py:
980
981 2011-11-14  Tony Chang  <tony@chromium.org>
982
983         [NRWT] Reftests should run even when pixel tests are disabled.
984         https://bugs.webkit.org/show_bug.cgi?id=60605
985
986         Reviewed by Dirk Pranke.
987
988         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Only skip ref tests if --no-ref-tests is passed.
989             Also add an assert to make sure we get image hashes back when running ref tests.
990         * Scripts/webkitpy/layout_tests/controllers/worker.py: Use Driver.has_crashed() instead of poll().
991         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
992         * Scripts/webkitpy/layout_tests/port/chromium.py: Use DriverProxy.
993         * Scripts/webkitpy/layout_tests/port/driver.py: Add DriverProxy which does the work
994             of starting a pixel driver if needed.  It handles the logic of sending the test
995             to the correct driver.  Also renamed Driver.poll() to Driver.has_crashed().
996         * Scripts/webkitpy/layout_tests/port/dryrun.py:
997         * Scripts/webkitpy/layout_tests/port/test.py: Switch to using DriverProxy so we get test coverage.
998         * Scripts/webkitpy/layout_tests/port/webkit.py:
999         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --no-ref-tests.
1000         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Test --no-ref-tests.
1001
1002 2011-11-15  David Kilzer  <ddkilzer@apple.com>
1003
1004         Don't use File::Slurp for run-leaks unit tests
1005         <http://webkit.org/b/72356>
1006
1007         Reviewed by Daniel Bates.
1008
1009         * Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Added.
1010         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
1011         Extracted common package logic into RunLeaks.pm.  Fixed call to
1012         RunLeaks::parseLeaksOutput().
1013         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
1014         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
1015
1016 2011-11-15  Peter Kasting  <pkasting@google.com>
1017
1018         Handle svn 1.7 when detecting whether a directory is in an svn checkout.
1019         https://bugs.webkit.org/show_bug.cgi?id=72349
1020
1021         Reviewed by Adam Roben.
1022
1023         * Scripts/VCSUtils.pm:
1024         (isSVNDirectory):
1025
1026 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
1027
1028         [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
1029
1030         Reviewed by Tor Arne Vestbø.
1031
1032         * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
1033         magic here where we handle all TEMPLATE = lib .pro files.
1034
1035 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
1036
1037         [Qt] Unreviewed prospective --minimal build fix.
1038
1039         * DumpRenderTree/qt/DumpRenderTree.pro: Avoid USE_SYSTEM_MALLOC=0
1040         and USE_SYSTEM_MALLOC=1 appearing in DEFINES at the same time.
1041
1042 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
1043
1044         [Qt] Unreviewed --minimal build fix.
1045
1046         * Scripts/build-webkit: Add to DEFINES+= from @options only if there is
1047         a define. The "coverage" option doesn't have one, causing "DEFINES+= =0"
1048         to make moc's preprocessor abort.
1049
1050 2011-11-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
1051
1052         build-webkit: Accept --cmakearg to pass additional arguments to CMake.
1053         https://bugs.webkit.org/show_bug.cgi?id=72156
1054
1055         Reviewed by Daniel Bates.
1056
1057         Similar to --makearg and --qmakearg, --cmakearg lets one pass
1058         additional arguments to CMake (eg. --cmakearg="-DFOO=bar").
1059
1060         * Scripts/build-webkit:
1061         * Scripts/webkitdirs.pm:
1062         (generateBuildSystemFromCMakeProject):
1063
1064 2011-11-14  Ryosuke Niwa  <rniwa@webkit.org>
1065
1066         Improve ChangeLogEntry's reviewer parsing algorithm part 2
1067         https://bugs.webkit.org/show_bug.cgi?id=72340
1068
1069         Reviewed by Eric Seidel.
1070
1071         This patch improves the recognition of NOBODY, wrestler names, and parenthesized clauses,
1072         and prepares ChangeLogEntry to support edit-distance-based reviewer-name recognition.
1073
1074         * Scripts/webkitpy/common/checkout/changelog.py:
1075         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1076
1077 2011-11-14  Eric Seidel  <eric@webkit.org>
1078
1079         check-webkit-style broken by r99773: "Could not determine the port"
1080         https://bugs.webkit.org/show_bug.cgi?id=72275
1081
1082         Reviewed by Adam Barth.
1083
1084         The TestExpectationsChecker was using a generic try/except block
1085         which caught all exceptions, so we didn't notice that failing
1086         to pass a Host to PortFactory was causing an exception in port instantiation.
1087         I've factored out the "lookup the port" logic into a separate function
1088         which I've now unittested.  This should fix the bug and prevent
1089         others like it from occuring the the future.
1090
1091         * Scripts/webkitpy/style/checkers/test_expectations.py:
1092         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1093
1094 2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>
1095
1096         Add --css-grid-layout to build-webkit and the build systems
1097         https://bugs.webkit.org/show_bug.cgi?id=72320
1098
1099         Reviewed by Ojan Vafai.
1100
1101         * Scripts/build-webkit:
1102         Added the option.
1103
1104 2011-11-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1105
1106         Unreviewed, rolling out r100192.
1107         http://trac.webkit.org/changeset/100192
1108         https://bugs.webkit.org/show_bug.cgi?id=72328
1109
1110         Caused infinite tests to fail (Requested by abarth on
1111         #webkit).
1112
1113         * Scripts/webkitpy/layout_tests/port/base.py:
1114         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1115
1116 2011-11-14  Tony Chang  <tony@chromium.org>
1117
1118         Remove the CSS3_FLEXBOX compile time flag and enable on all ports
1119         https://bugs.webkit.org/show_bug.cgi?id=72196
1120
1121         Reviewed by Ojan Vafai.
1122
1123         * Scripts/build-webkit:
1124
1125 2011-11-14  John Yani  <vanuan@gmail.com>
1126
1127         new-run-webkit-tests should not be locale dependent https://bugs.webkit.org/show_bug.cgi?id=68691
1128         Override LOCALE to en_US.
1129
1130         Reviewed by Eric Seidel.
1131
1132         * Scripts/webkitpy/layout_tests/port/base.py:
1133
1134 2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>
1135
1136         [Chromium] build-webkit silently drops the features flags
1137         https://bugs.webkit.org/show_bug.cgi?id=72293
1138
1139         Reviewed by Tony Chang.
1140
1141         Chromium still ignores @features but now we give a warning!
1142
1143         * Scripts/build-webkit: Check if one of the features is different
1144         from the default and print a warning in this case.
1145
1146 2011-11-14  David Kilzer  <ddkilzer@apple.com>
1147
1148         run-leaks does not work on Lion?
1149         <http://webkit.org/b/71059>
1150         <rdar://problem/10428527>
1151
1152         Reviewed by Adam Roben.
1153
1154         The output of leaks(1) changed again in Lion to move the
1155         "leaks Report Version: 2.0" line from the first line of the
1156         output to just above the "Process " lines that run-leaks is
1157         interested in parsing.  This required using a more generic
1158         algorithm to find the start of the "Process " lines.
1159
1160         * Scripts/run-leaks:
1161         (parseLeaksOutput): Make the code to skip headers more generic.
1162         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Added.
1163         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Added.
1164         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Added.
1165
1166 2011-11-14  Lei Zhang  <thestig@chromium.org>
1167
1168         Missing include in Tools/DumpRenderTree/chromium/AccessibilityUIElement.h:
1169         https://bugs.webkit.org/show_bug.cgi?id=72088
1170
1171         Reviewed by Tony Chang.
1172
1173         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1174
1175 2011-11-14  Andrew Scherkus  <scherkus@chromium.org>
1176
1177         [Chromium] Skip media layout tests on chromium-gpu-cg-mac-leopard platform
1178         https://bugs.webkit.org/show_bug.cgi?id=72147
1179
1180         Reviewed by Adam Barth.
1181
1182         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1183
1184 2011-11-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1185
1186         [Qt] Move the QtWebKit module file to match the layout of Qt's mkspecs
1187
1188         Reviewed by Simon Hausmann.
1189
1190         * qmake/mkspecs/modules/qt_webkit.pri: Renamed from Tools/qmake/qt_webkit.pri.
1191
1192 2011-11-14  Simon Hausmann  <simon.hausmann@nokia.com>
1193
1194         [Qt] Disable plugins on X11 for WK2
1195
1196         Reviewed by Kenneth Rohde Christiansen.
1197
1198         Currently plugins are in-process and they crash in the likely case of
1199         a plugin installation that uses Qt 4, which beautifully clashes with the
1200         Qt 5 based QtWebProcess.
1201
1202         * qmake/mkspecs/features/features.prf:
1203
1204 2011-11-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1205
1206         [Qt] Add support for config tests for Qt 5
1207
1208         This allows us to build and run configure-tests at build
1209         time to determine if a given platform feature is available.
1210
1211         Reviewed by Simon Hausmann.
1212
1213         * Scripts/build-webkit:
1214         * Scripts/webkitdirs.pm:
1215         (qtFeatureDefaults):
1216         * qmake/configure.pro: Added.
1217         * qmake/mkspecs/features/features.prf:
1218         * qmake/sync.profile: Added.
1219
1220 2011-11-11  Pierre Rossi  <pierre.rossi@gmail.com>
1221
1222         [Qt] Remove the QStyle dependency in Qt's mobile theme
1223         https://bugs.webkit.org/show_bug.cgi?id=67773
1224
1225         This refactoring splits up RenderThemeQt with two
1226         subclasses, a QStyle-backed one, and a Mobile version
1227         that uses the old mobile theme for now.
1228
1229         QStyle availability is detected at compile time, and
1230         its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
1231         environment variable.
1232
1233         Reviewed by Simon Hausmann.
1234
1235         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1236         (WTR::activateFonts):
1237         * qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
1238         based on availability of QtWidgets.
1239         * qmake/mkspecs/features/webcore.prf: cleanup.
1240
1241 2011-11-14  Tony Gentilcore  <tonyg@chromium.org>
1242
1243         Unreviewed, rolling out r100116.
1244         http://trac.webkit.org/changeset/100116
1245
1246         r100104 was rolled out, so no longer needed
1247
1248         * Scripts/run-bindings-tests:
1249
1250 2011-11-14  Tony Gentilcore  <tonyg@chromium.org>
1251
1252         Unreviewed, rolling out r100104.
1253         http://trac.webkit.org/changeset/100104
1254         https://bugs.webkit.org/show_bug.cgi?id=72247
1255
1256         broke windows builds
1257
1258         * Scripts/check-webkit-style:
1259         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1260         * Scripts/webkitpy/common/checkout/deps.py:
1261         * Scripts/webkitpy/common/checkout/scm/__init__.py:
1262         * Scripts/webkitpy/common/checkout/scm/detection.py:
1263         * Scripts/webkitpy/common/checkout/scm/git.py:
1264         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1265         * Scripts/webkitpy/common/checkout/scm/svn.py:
1266         * Scripts/webkitpy/common/host.py:
1267         * Scripts/webkitpy/common/host_mock.py:
1268         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1269         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1270         * Scripts/webkitpy/layout_tests/port/base.py:
1271         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1272         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1273         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1274         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1275
1276 2011-11-14  Philippe Normand  <pnormand@igalia.com>
1277
1278         Unreviewed, build fix after r100104. run-binding-tests broke.
1279
1280         * Scripts/run-bindings-tests: Explicitely use scm.detection.
1281
1282 2011-11-13  Eric Seidel  <eric@webkit.org>
1283
1284         Add SCMDetector object to make scm detection mockable
1285         https://bugs.webkit.org/show_bug.cgi?id=72247
1286
1287         Reviewed by Adam Barth.
1288
1289         I think SCM detection may eventually be rolled into Checkout,
1290         but this patch at least makes it possible to mock code-paths
1291         which rely on scm detection.
1292         In the process of replacing callers of these free-functions
1293         I found that one of the functions was no longer used,
1294         and that one of the callers could instead just use the SCM
1295         object it already had access to through port.host.scm().
1296         I also discovered that I was not calling Host._initialize_scm()
1297         and thus host.scm() was always returning None!
1298
1299         * Scripts/check-webkit-style:
1300         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1301         * Scripts/webkitpy/common/checkout/deps.py:
1302         * Scripts/webkitpy/common/checkout/scm/__init__.py:
1303         * Scripts/webkitpy/common/checkout/scm/detection.py:
1304         * Scripts/webkitpy/common/checkout/scm/git.py:
1305         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1306         * Scripts/webkitpy/common/checkout/scm/svn.py:
1307         * Scripts/webkitpy/common/host.py:
1308         * Scripts/webkitpy/common/host_mock.py:
1309         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1310         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1311         * Scripts/webkitpy/layout_tests/port/base.py:
1312         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1313         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1314         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1315         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1316
1317 2011-11-13  Gavin Peters  <gavinp@chromium.org>
1318
1319         command line control of webcore log channels in chromium DumpRenderTree
1320         https://bugs.webkit.org/show_bug.cgi?id=72126
1321         
1322         The option --webcore-log-channels=<foo>,<bar>,<quux> is the same as
1323         what chromium takes.
1324
1325         Reviewed by Kent Tamura.
1326
1327         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1328         (main):
1329
1330 2011-11-12  Ariya Hidayat  <ariya@sencha.com>
1331
1332         [Qt] Fix minor config typo in the build tool documentation
1333         https://bugs.webkit.org/show_bug.cgi?id=72194
1334
1335         Reviewed by Andreas Kling.
1336
1337         * qmake/README:
1338
1339 2011-11-11  Stephen Chenney  <schenney@chromium.org>
1340
1341         [Chromium] DRT does not have LayoutTestController.pageSizeAndMarginsInPixels
1342         https://bugs.webkit.org/show_bug.cgi?id=49257
1343
1344         Adds the remaining missing layout test functionality for printing.
1345
1346         Reviewed by Darin Fisher.
1347
1348         * DumpRenderTree/chromium/LayoutTestController.cpp:
1349         (LayoutTestController::LayoutTestController): Add bindings for new JS methods
1350         (parsePageNumber): Method to parse JS arguments for a page number
1351         (parsePageNumberSizeMargins): Method to parse JS arguments for page size and margins
1352         (LayoutTestController::pageSizeAndMarginsInPixels): Get the page size and margins for a given page.
1353         (LayoutTestController::isPageBoxVisible): get the visibility status for printing
1354         (LayoutTestController::pageProperty): get a specific CSS property when in printing mode
1355         * DumpRenderTree/chromium/LayoutTestController.h: Add declarations for new methods
1356
1357 2011-11-11  Darin Adler  <darin@apple.com>
1358
1359         Remove all releaseRef implementations except for RetainPtr
1360         https://bugs.webkit.org/show_bug.cgi?id=71423
1361
1362         Reviewed by Julien Chaffraix.
1363
1364         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
1365         (createXMLStringFromWebArchiveData): Use leakRef instead of releaseRef.
1366
1367 2011-11-11  Ryosuke Niwa  <rniwa@webkit.org>
1368
1369         Make ChangeLogEntry's reviewer parsing algorithm support last 4 WebCore change logs
1370         https://bugs.webkit.org/show_bug.cgi?id=72090
1371
1372         Reviewed by Eric Seidel.
1373
1374         Significantly improve ChangeLogEntry's reviewer parsing algorithm. This version can successfully parse
1375         ChangeLog, ChangeLog-2011-10-19, ChangeLog-2011-06-04, ChangeLog-2011-02-16, and ChangeLog-2010-12-06.
1376
1377         yay! r100002.
1378
1379         * Scripts/webkitpy/common/checkout/changelog.py:
1380         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1381
1382 2011-11-11  Tony Chang  <tony@chromium.org>
1383
1384         Remove --force from gclient sync.  The bots seem to have made it past
1385         the update step.
1386
1387         * Scripts/update-webkit:
1388
1389 2011-11-11  Tony Chang  <tony@chromium.org>
1390
1391         Add --force to gclient sync. Once the cq bots cycle, we can remove
1392         this since it slows down the normal sync.
1393
1394         * Scripts/update-webkit:
1395
1396 2011-11-11  Marc-Antoine Ruel  <maruel@chromium.org>
1397
1398         When --force is used, also use --reset
1399         https://bugs.webkit.org/show_bug.cgi?id=72129
1400
1401         Reviewed by Dimitri Glazkov.
1402
1403         * Scripts/update-webkit-chromium:
1404
1405 2011-11-11  Tony Chang  <tony@chromium.org>
1406
1407         allow two chromium drivers to run at the same time in NRWT
1408         https://bugs.webkit.org/show_bug.cgi?id=72067
1409
1410         Reviewed by Dirk Pranke.
1411
1412         * Scripts/webkitpy/layout_tests/port/chromium.py: close_fds=True on
1413             posix prevents the subprocesses from sharing the same fd for stdin.
1414             Sharing the same fd prevents us from closing the files unless all references
1415             to the fd are closed.
1416         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: In addition
1417             to adding a test for this, speed up a test (from 3sec to 0) by fixing
1418             the timeout override. It looks like it regressed in r95875.
1419
1420 2011-11-11  Sheriff Bot  <webkit.review.bot@gmail.com>
1421
1422         Unreviewed, rolling out r99964.
1423         http://trac.webkit.org/changeset/99964
1424         https://bugs.webkit.org/show_bug.cgi?id=72124
1425
1426         Broke too many Qt tests (Requested by tronical_ on #webkit).
1427
1428         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1429         (WTR::activateFonts):
1430         * qmake/mkspecs/features/features.prf:
1431         * qmake/mkspecs/features/webcore.prf:
1432
1433 2011-11-11  Pierre Rossi  <pierre.rossi@gmail.com>
1434
1435         [Qt] Remove the QStyle dependency in Qt's mobile theme
1436         https://bugs.webkit.org/show_bug.cgi?id=67773
1437
1438         This refactoring splits up RenderThemeQt with two
1439         subclasses, a QStyle-backed one, and a Mobile version
1440         that uses the old mobile theme for now.
1441
1442         QStyle availability is detected at compile time, and
1443         its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
1444         environment variable.
1445
1446         Reviewed by Simon Hausmann.
1447
1448         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1449         (WTR::activateFonts):
1450         * qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
1451         based on availability of QtWidgets.
1452         * qmake/mkspecs/features/webcore.prf: cleanup.
1453
1454 2011-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1455
1456         [Qt] Add missing include to PlatformWebViewQt
1457
1458         Reviewed by Simon Hausmann.
1459
1460         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1461
1462 2011-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1463
1464         [Qt] Fix incremental builds on Windows after buildsystem refactor
1465
1466         The qmake rules to ensure that we run make on the derived sources
1467         before running qmake on the target were inside a unix-scope, which
1468         resulted in flakey builds on Windows.
1469
1470         We now generate a rule on all platforms that ensures that "make qmake"
1471         will always run make on the derived sources. In addition, on platforms
1472         that have GNU make (where "make incremental" does not run "make qmake",
1473         but only "make"), we add a similar rule that ensures that any time the
1474         target makefile is regenerated we first run qmake and make on the derived
1475         sources. This rule relies on GNU make's order-only-prerequisites to
1476         not trigger a qmake-run of the target every time we run make.
1477
1478         https://bugs.webkit.org/show_bug.cgi?id=71778
1479
1480         Reviewed by Simon Hausmann.
1481
1482         * qmake/mkspecs/features/functions.prf:
1483
1484 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
1485
1486         [Qt][WK2] Remove QWebNavigationController
1487         https://bugs.webkit.org/show_bug.cgi?id=72113
1488
1489         Reviewed by Andreas Kling.
1490
1491         Adapt to the move of the QWebNavigationController functions/properties to
1492         QQuickWebView.
1493
1494         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1495         * MiniBrowser/qt/qml/BrowserWindow.qml:
1496
1497 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
1498
1499         [Qt] Build system tweak
1500
1501         Reviewed by Tor Arne Vestbø.
1502
1503         Be a good qmake citizen, return true from our linkStaticLibrary
1504         "test" function.
1505
1506         * qmake/mkspecs/features/functions.prf:
1507
1508 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
1509
1510         [Qt] Add support for QT += webkit-private
1511
1512         Reviewed by Tor Arne Vestbø.
1513
1514         * qmake/qt_webkit.pri: Declare private headers.
1515
1516 2011-11-11  Philippe Normand  <pnormand@igalia.com>
1517
1518         Unreviewed, build fix attempt after r99907. Since that revision
1519         GTK layout tests were not running at all...
1520
1521         * Scripts/webkitpy/layout_tests/port/gtk.py:
1522
1523 2011-11-10  Andrew Scherkus  <scherkus@chromium.org>
1524
1525         [Chromium] only run media GPU layout tests on platforms supporting accelerated compositing
1526         https://bugs.webkit.org/show_bug.cgi?id=72001
1527
1528         Reviewed by Dirk Pranke.
1529
1530         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1531
1532 2011-11-05  Filip Pizlo  <fpizlo@apple.com>
1533
1534         bencher script should support remote benchmarking
1535         https://bugs.webkit.org/show_bug.cgi?id=71618
1536
1537         Rubber-stamped by Geoff Garen.
1538         
1539         Added the following features:
1540         
1541         - Benchmark report tells you the hostname and machine model (according to
1542           'sysctl hw.model') of the machine you did the run on, and svn revision number
1543           (according to 'svn info') of the VMs you're testing.
1544         
1545         - The --remote option. You give this an ssh-style hostname (i.e. user@host is
1546           acceptable, in addition to just host, in which case your username is used)
1547           and it automatically packages the build directories of the VMs you're testing,
1548           sends them to the remote machine along with your copy of the bencher script
1549           and all of the options you passed.  This pretty much seamlessly allows you
1550           to run a set of benchmarks on any machine that is sufficiently compatible with
1551           yours (i.e. similar OS) and that has the appropriate ~/.bencher file, which
1552           must now include a tempPath setting that tells bencher where to put files
1553           when that machine is used as a slave in a remote benchmarking run.
1554           
1555         - Added yet another way of specifying which benchmarks to run. This was sort of
1556           necessary for --remote to work as expected. Previously, you either said what
1557           suites to exclude (for example --exclude-sunspider) or that you only wanted
1558           to run one suite to the exclusion of others (--sunspider-only). But it's
1559           often better to just be able to specify the list of suites you want. This is
1560           now supported. You can say, for example, --v8 --sunspider, which means, just
1561           run V8 and SunSpider. This is equivalent to saying --exclude-kraken, which is
1562           still supported.
1563
1564         * Scripts/bencher:
1565
1566 2011-11-10  Tony Chang  <tony@chromium.org>
1567
1568         Lazily start DRT instances in NRWT
1569         https://bugs.webkit.org/show_bug.cgi?id=72038
1570
1571         Reviewed by Eric Seidel.
1572
1573         Just a refactoring, no new tests.
1574
1575         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1576         * Scripts/webkitpy/layout_tests/port/chromium.py:
1577         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1578         * Scripts/webkitpy/layout_tests/port/test.py:
1579         * Scripts/webkitpy/layout_tests/port/webkit.py:
1580
1581 2011-11-10  Ryosuke Niwa  <rniwa@webkit.org>
1582
1583         ChangeLog mistakenly recognizes any string between '*' and ':' as touched files
1584         https://bugs.webkit.org/show_bug.cgi?id=72057
1585
1586         Reviewed by Eric Seidel.
1587
1588         Make the regular expression more explicit.
1589
1590         * Scripts/webkitpy/common/checkout/changelog.py:
1591         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1592
1593 2011-11-10  Balazs Kelemen  <kbalazs@webkit.org>
1594
1595         [Qt] X11 plugins need to be reworked for Qt5
1596         https://bugs.webkit.org/show_bug.cgi?id=70023
1597
1598         Reviewed by Simon Hausmann.
1599
1600         Rework our basic plugin support in a way that does
1601         not need a bridge between Qt and X. The solution is
1602         based on getting the content drawed by the plugin
1603         from the server as an image and creating a QImage
1604         from it.
1605
1606         * qmake/mkspecs/features/features.prf: Enable X11
1607         plugins if Qt is built with the xcb-xlib backend.
1608
1609 2011-11-10  Simon Hausmann  <simon.hausmann@nokia.com>
1610
1611         [Qt] Fix keyboard related layout tests after API refactoring
1612
1613         Reviewed by Tor Arne Vestbø.
1614
1615         Send key events to the handling page item, not the view.
1616
1617         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1618         (WTR::PlatformWebView::sendEvent):
1619         (WTR::PlatformWebView::postEvent):
1620
1621 2011-11-10  Alexandre Mazari  <amazari@igalia.com>
1622
1623         [GTK] Make the ENABLE(FEATURE) macro work in DRT
1624         https://bugs.webkit.org/show_bug.cgi?id=71940
1625
1626         Reviewed by Philippe Normand.
1627
1628         * GNUmakefile.am:
1629         Add webcore_cppflags to Programs_DumpRenderTree_CPP so
1630         ENABLE_* variables are part of the environment.
1631
1632 2011-11-10  Simon Hausmann  <simon.hausmann@nokia.com>
1633
1634         [Qt] Fix focus related layout tests after API refactoring
1635
1636         Reviewed by Tor Arne Vestbø.
1637
1638         Make sure the focus is set on the page now, not on the view
1639         (which doesn't actually handle the focus).
1640
1641         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1642         (WTR::WrapperWindow::WrapperWindow):
1643         (WTR::WrapperWindow::handleStatusChanged):
1644
1645 2011-11-10  Alexis Menard  <alexis.menard@openbossa.org>
1646
1647         [Qt] Merge QTouchWebView and QDesktopWebView into one class
1648         https://bugs.webkit.org/show_bug.cgi?id=71355
1649
1650         Reviewed by Kenneth Rohde Christiansen.
1651
1652         Make MiniBrowser and WebKitTestRunner work again after the
1653         merge.
1654
1655         * MiniBrowser/qt/BrowserWindow.cpp:
1656         (BrowserWindow::BrowserWindow):
1657         (BrowserWindow::webView):
1658         * MiniBrowser/qt/MiniBrowser.pro:
1659         * MiniBrowser/qt/MiniBrowser.qrc:
1660         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1661         * MiniBrowser/qt/main.cpp:
1662         * MiniBrowser/qt/qml/BrowserWindow.qml:
1663         * MiniBrowser/qt/qml/DesktopView.qml: Removed.
1664         * MiniBrowser/qt/qml/TouchView.qml: Removed.
1665         * WebKitTestRunner/PlatformWebView.h:
1666         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1667         (WTR::PlatformWebView::PlatformWebView):
1668
1669 2011-11-10  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1670
1671         [Qt] Change semantics of the haveQt() function to match API promises
1672
1673         Having Qt 5 does not imply that we have Qt 4, from an API point of
1674         view, as a major version can in theory break BC/SC. Our minimum
1675         version of Qt 4 will always be the latest released version of Qt 4,
1676         so the only place we should use haveQt(4, x) is when checking for
1677         the minimum requirements.
1678
1679         Reviewed by Simon Hausmann.
1680
1681         * qmake/mkspecs/features/default_pre.prf:
1682         * qmake/mkspecs/features/features.prf:
1683         * qmake/mkspecs/features/functions.prf:
1684
1685 2011-11-07  Kaustubh Atrawalkar  <kaustubh@motorola.com> and Sergio Villar Senin  <svillar@igalia.com>
1686
1687         [WK2] [GTK] Implement a MouseDown/MouseUp/MouseMoveTo/MouseScrollBy/LeapForward functions for WebKit2 EventSender
1688         https://bugs.webkit.org/show_bug.cgi?id=69411
1689
1690         Reviewed by Martin Robinson.
1691
1692         * WebKitTestRunner/EventSenderProxy.h:
1693         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1694         * WebKitTestRunner/TestController.cpp:
1695         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1696         use the EventSender instead of WebProcess Event Simulation.
1697         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1698         (WTR::WTREventQueueItem::WTREventQueueItem):
1699         (WTR::EventSenderProxy::EventSenderProxy):
1700         (WTR::getMouseButtonModifiers):
1701         (WTR::eventSenderButtonToGDKButton):
1702         (WTR::EventSenderProxy::createMouseButtonEvent):
1703         (WTR::EventSenderProxy::updateClickCountForButton):
1704         (WTR::EventSenderProxy::replaySavedEvents):
1705         (WTR::EventSenderProxy::sendOrQueueEvent):
1706         (WTR::webkitModifiersToGDKModifiers):
1707         (WTR::getGDKKeySymForKeyRef):
1708         (WTR::EventSenderProxy::keyDown):
1709         (WTR::EventSenderProxy::mouseDown):
1710         (WTR::EventSenderProxy::mouseUp):
1711         (WTR::EventSenderProxy::mouseMoveTo):
1712         (WTR::EventSenderProxy::mouseScrollBy):
1713         (WTR::EventSenderProxy::leapForward):
1714
1715 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
1716
1717         [Qt] Enable exports and constructor functions in static libs
1718
1719         Reviewed by Tor Arne Vestbø.
1720
1721         * qmake/mkspecs/features/functions.prf: Use --whole-archive and their
1722         mac/win32-msvc equivalents when linking static libraries into a shared
1723         library or executable.
1724
1725 2011-11-09  Hayato Ito  <hayato@chromium.org>
1726
1727         [NRWT] Make results.html aware of reference filename in reftests.
1728         https://bugs.webkit.org/show_bug.cgi?id=71574
1729
1730         Reviewed by Ryosuke Niwa.
1731
1732         If a reference filename is different from the default one, include that in result summary
1733         so results.html can link to the correct reference file.
1734
1735         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1736         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1737
1738 2011-11-09  Kevin Ollivier  <kevino@theolliviers.com>
1739
1740         [wx] Unreviewed build fix. Update project files and
1741         add LTC stubs for new methods.
1742
1743         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1744         (LayoutTestController::addChromeInputField):
1745         (LayoutTestController::removeChromeInputField):
1746         (LayoutTestController::focusWebView):
1747         (LayoutTestController::setBackingScaleFactor):
1748         * waf/build/settings.py:
1749
1750 2011-11-09  Kevin Ollivier  <kevino@theolliviers.com>
1751
1752         [wx] Unreviewed build fix. Support XCode 4 when building deps.
1753
1754         * wx/install-unix-extras:
1755
1756 2011-11-09  Eric Seidel  <eric@webkit.org>
1757
1758         Remove the concept of platform-dependent unittests
1759         https://bugs.webkit.org/show_bug.cgi?id=71963
1760
1761         Unreviewed.  Fix test-webkitpy on cygwin.
1762
1763         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1764
1765 2011-11-09  Dana Jansens  <danakj@chromium.org>
1766
1767         Add cc-bugs group to watch changes in chromium graphics
1768         https://bugs.webkit.org/show_bug.cgi?id=71690
1769
1770         Reviewed by David Levin.
1771
1772         * Scripts/webkitpy/common/config/committers.py: Make new Account superclass for non-contributor watch accounts
1773         * Scripts/webkitpy/common/config/committers_unittest.py: Test the Account superclass
1774         * Scripts/webkitpy/common/config/watchlist: Add cc-bugs@google.com to watch list
1775         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Check for Accounts also, but require it to be the bugzilla email for any Account/Contributor/etc.
1776
1777 2011-11-09  Eric Seidel  <eric@webkit.org>
1778
1779         Remove more platform-dependent unittests
1780         https://bugs.webkit.org/show_bug.cgi?id=71971
1781
1782         Reviewed by Adam Barth.
1783
1784         Tests which only run on a couple platforms will break.
1785         All tests should run on all platforms where possible.
1786
1787         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1788         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1789         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1790         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1791
1792 2011-11-09  Ojan Vafai  <ojan@chromium.org>
1793
1794         Merge in results to the test results server even if build numbers conflict
1795         https://bugs.webkit.org/show_bug.cgi?id=71967
1796
1797         Reviewed by Tony Chang.
1798
1799         This was initially meant to be a sanity check that we don't
1800         enter duplicate runs, but it turns out that we can reasonably get
1801         in these situations when a builder is clobbered (e.g. the build
1802         numbers start over again from 0).
1803
1804         * TestResultServer/model/jsonresults.py:
1805         * TestResultServer/model/jsonresults_unittest.py:
1806
1807 2011-11-09  Eric Seidel  <eric@webkit.org>
1808
1809         Remove the concept of platform-dependent unittests
1810         https://bugs.webkit.org/show_bug.cgi?id=71963
1811
1812         Reviewed by Adam Barth.
1813
1814         These have been the source of never-ending sadness.
1815         We'd change behavior and forget to update results in
1816         some unittests because they were only run on certain platforms.
1817         This change removes a large source of these platform-dependent
1818         unittests, which was caused by the port_maker stuff.
1819
1820         It's possible that this change will break test-webkitpy
1821         on some platforms, but that will be a one-time cost.
1822         I will fix the breakage by removing the platform-dependantness
1823         of any such broken tests.
1824
1825         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1826         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1827         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1828         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1829         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1830         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1831         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
1832         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1833         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1834         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1835         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1836         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1837         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1838
1839 2011-11-09  Eric Seidel  <eric@webkit.org>
1840
1841         Make the Port object have a Host
1842         https://bugs.webkit.org/show_bug.cgi?id=71961
1843
1844         Reviewed by Adam Barth.
1845
1846         This has been a long time coming.
1847         Now that Port has a Host object, it's very easy
1848         to write unittests which use a properly mocked Port.
1849         Soon we will remove the executive, filesystem and user
1850         members of Port and get everything through the Host.
1851
1852         Note how in many callsites we're actually removing
1853         explicit mocks, since we're now always going to get the
1854         correct Executive/User/FileSystem from the
1855         Host and callsites don't need to be careful to pass each one.
1856
1857         This is prep-work for adding a new Environment member to
1858         Host and needing to be able to access the Environment
1859         member from Port functions w/o needing to pass an Environment
1860         object (or appropriate Mock) every place we create a Port object.
1861         Now that we have a single Host object to reach out through, its
1862         simple to add additional functionality (like Environment) while
1863         keeping our unittests properly mocked.
1864
1865         * Scripts/webkitpy/common/host.py:
1866         * Scripts/webkitpy/common/net/credentials_unittest.py:
1867         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1868         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1869         * Scripts/webkitpy/layout_tests/port/apple.py:
1870         * Scripts/webkitpy/layout_tests/port/base.py:
1871         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1872         * Scripts/webkitpy/layout_tests/port/chromium.py:
1873         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1874         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1875         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1876         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1877         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1878         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1879         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1880         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1881         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1882         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1883         * Scripts/webkitpy/layout_tests/port/efl.py:
1884         * Scripts/webkitpy/layout_tests/port/factory.py:
1885         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1886         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1887         * Scripts/webkitpy/layout_tests/port/gtk.py:
1888         * Scripts/webkitpy/layout_tests/port/mac.py:
1889         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1890         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1891         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1892         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1893         * Scripts/webkitpy/layout_tests/port/qt.py:
1894         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1895         * Scripts/webkitpy/layout_tests/port/test.py:
1896         * Scripts/webkitpy/layout_tests/port/webkit.py:
1897         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1898         * Scripts/webkitpy/layout_tests/port/win.py:
1899         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1900         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1901         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
1902         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1903         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
1904
1905 2011-11-09  Dominic Mazzoni  <dmazzoni@google.com>
1906
1907         [Chromium] Implement AccessibilityUIElement::insertionPointLineNumberGetterCallback
1908         https://bugs.webkit.org/show_bug.cgi?id=71561
1909
1910         Reviewed by Dimitri Glazkov.
1911
1912         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1913         (AccessibilityUIElement::insertionPointLineNumberGetterCallback):
1914
1915 2011-11-09  Benjamin Poulain  <bpoulain@apple.com>
1916
1917         Implement dumpProgressFinishedCallback() for Mac layoutTestController
1918         https://bugs.webkit.org/show_bug.cgi?id=66772
1919
1920         Reviewed by Simon Fraser.
1921
1922         When dumpProgressFinishedCallback is enabled, DumpRenderTree should output
1923         "postProgressFinishedNotification" on FrameLoaderClient::postProgressFinishedNotification().
1924
1925         On Mac, the FrameLoaderClient post a notification. This patch add handling for this notification
1926         in the FrameLoadDelegate and print the output in response to the notification.
1927
1928         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1929         (-[FrameLoadDelegate init]):
1930         (-[FrameLoadDelegate dealloc]):
1931         (-[FrameLoadDelegate webViewProgressFinishedNotification:]):
1932
1933 2011-11-09  Philippe Normand  <pnormand@igalia.com>
1934
1935         [GTK][DRT] window internals object is not reset after each test
1936         https://bugs.webkit.org/show_bug.cgi?id=71890
1937
1938         Reviewed by Martin Robinson.
1939
1940         Call WebCoreTestSupport::resetInternalsObject without going
1941         through DumpRenderTreeSupport.
1942
1943         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1944         (runTest):
1945
1946 2011-11-09  Beth Dakin  <bdakin@apple.com>
1947
1948         Build fix.
1949
1950         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1951         (AccessibilityUIElement::uiElementAttributeValue):
1952
1953 2011-11-09  Beth Dakin  <bdakin@apple.com>
1954
1955         Speculative build fix.
1956
1957         * DumpRenderTree/AccessibilityUIElement.h:
1958
1959 2011-11-09  Julien Chaffraix  <jchaffraix@webkit.org>
1960
1961         Unreviewed build fix.
1962
1963         * DumpRenderTree/AccessibilityUIElement.cpp:
1964         (AccessibilityUIElement::makeJSAccessibilityUIElement):
1965         A bad merge added this check that is making the bots sad.
1966
1967 2011-11-09  Chris Fleizach  <cfleizach@apple.com>
1968
1969         AX: crash when accessing selectedTab in a tab list
1970         https://bugs.webkit.org/show_bug.cgi?id=70938
1971
1972         Reviewed by Beth Dakin.
1973
1974         Add the ability to retrieve an element through an arbitrary attribute.
1975
1976         * DumpRenderTree/AccessibilityUIElement.cpp:
1977         (uiElementAttributeValueCallback):
1978         (AccessibilityUIElement::uiElementAttributeValue):
1979         (AccessibilityUIElement::getJSClass):
1980         * DumpRenderTree/AccessibilityUIElement.h:
1981         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1982         (AccessibilityUIElement::uiElementAttributeValue):
1983
1984 2011-11-09  Andy Wingo  <wingo@igalia.com>
1985
1986         Add webkitdirs.pm:getArchitecture implementation for GTK
1987         https://bugs.webkit.org/show_bug.cgi?id=71370
1988
1989         Reviewed by Xan Lopez.
1990
1991         * Scripts/webkitdirs.pm (determineArchitecture): Add an
1992         implementation for ports using autotools, so that a vanilla
1993         `run-javascriptcore-tests --gtk' invocation doesn't pass --32-bit
1994         to build-jsc on x86-64 machines.
1995
1996 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
1997
1998         Unreviewed, rolling out r99707.
1999         http://trac.webkit.org/changeset/99707
2000
2001         Re-enable until we can disable it together with tests in one
2002         shot.
2003
2004         * qmake/mkspecs/features/features.prf:
2005
2006 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2007
2008         [Qt] Disable use of QtUiTools if the library/module is not found
2009
2010         We rely on the lookup order of prf files to inject our own uitools.prf
2011         that will verify that QtUiTools is in fact present before allowing the
2012         CONFIG += uitools to have any effect.
2013
2014         Reviewed by Simon Hausmann.
2015
2016         * DumpRenderTree/qt/DumpRenderTree.pro:
2017         * QtTestBrowser/QtTestBrowser.pro:
2018         * qmake/mkspecs/features/uitools.prf: Added.
2019
2020 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2021
2022         Unreviewed, rolling out r99701.
2023         http://trac.webkit.org/changeset/99701
2024
2025         Breaks Qt mac build
2026
2027         * qmake/mkspecs/features/functions.prf:
2028
2029 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2030
2031         [Qt] Prospective build fix for Win32/Mac with xmlpatterns
2032
2033         Reviewed by Tor Arne Vestbø.
2034
2035         * qmake/mkspecs/features/features.prf: Disable XSLT support initially.
2036         We default to XSLT support if qxmlpatterns is available. However qxmlpatterns
2037         is not up to the task of full XSLT support, so we should disable it.
2038
2039 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2040
2041         [Qt] Enable exports and constructor functions in static libs
2042
2043         Reviewed by Tor Arne Vestbø.
2044
2045         * qmake/mkspecs/features/functions.prf: Use --whole-archive and their
2046         mac/win32-msvc equivalents when linking static libraries into a shared
2047         library or executable.
2048
2049 2011-11-09  Philippe Normand  <pnormand@igalia.com>
2050
2051         [GTK][DRT] window internals object is not reset after each test
2052         https://bugs.webkit.org/show_bug.cgi?id=71890
2053
2054         Reviewed by Xan Lopez.
2055
2056         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2057         (runTest): reset the Internals object after each test.
2058
2059 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2060
2061         [Qt] Detect presence of QtUiTools and enable it only when available
2062
2063         The disable_uitools option was a workaround for missing detection.
2064
2065         Reviewed by Simon Hausmann.
2066
2067         * QtTestBrowser/QtTestBrowser.pro:
2068         * qmake/mkspecs/features/default_post.prf:
2069         * qmake/mkspecs/features/default_pre.prf:
2070
2071 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2072
2073         [Qt] Don't override config for the build_pass of debug_and_release
2074
2075         Qmake will parse the profile once for each configuration (debug and
2076         release), with the build_pass option set. In that situation we don't
2077         want to override what qmake is setting explicitly, otherwise the
2078         debug-step will end up hitting all the release-scopes.
2079
2080         Reviewed by Simon Hausmann.
2081
2082         * qmake/mkspecs/features/default_pre.prf:
2083
2084 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2085
2086         [Qt] Unbreak the Qt build (copy & paste mistake - oops)
2087
2088         * qmake/mkspecs/features/functions.prf:
2089
2090 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2091
2092         [Qt] Centralize duplicated code for linking the static libs
2093
2094         Reviewed by Tor Arne Vestbø.
2095
2096         * qmake/mkspecs/features/functions.prf:
2097         * qmake/mkspecs/features/javascriptcore.prf:
2098         * qmake/mkspecs/features/webcore.prf:
2099         * qmake/mkspecs/features/webkit2.prf:
2100
2101 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2102
2103         [Qt] Build system cleanup
2104         https://bugs.webkit.org/show_bug.cgi?id=71815
2105
2106         Reviewed by Kenneth Rohde Christiansen.
2107
2108         * WebKitTestRunner/InjectedBundle/Target.pri: We don't need to link against the webkit2
2109         static library.
2110         * qmake/mkspecs/features/javascriptcore.prf: The wtf sources pull in a glib dependency
2111         (ownPtr functions for glib types). Propagate that to everyone using javascriptcore.
2112
2113 2011-11-08  Hayato Ito  <hayato@chromium.org>
2114
2115         [NRWT] Make single_test_runner aware of reference filename of test_input.
2116         https://bugs.webkit.org/show_bug.cgi?id=71567
2117
2118         Reviewed by Ryosuke Niwa.
2119
2120         Make single_test_runner honor a reference filename of given test_input so that
2121         we can use any file as reference html, instead of depending on implicit naming convention.
2122         The typical use case is to support w3c reftests.
2123
2124         No tests since no functional changes until there is a client.
2125         Test should be easily written with future clients.
2126
2127         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2128         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2129         * Scripts/webkitpy/layout_tests/models/test_failures.py:
2130         * Scripts/webkitpy/layout_tests/models/test_input.py:
2131
2132 2011-11-08  Lucas Forschler  <lforschler@apple.com>
2133
2134         https://bugs.webkit.org/show_bug.cgi?id=71839
2135         Update the leaks bot OS to Lion.
2136         Update the config.json to reflect the update.
2137
2138         Reviewed by Stephanie Lewis.
2139
2140         * BuildSlaveSupport/build.webkit.org-config/config.json:
2141
2142 2011-11-08  Sheriff Bot  <webkit.review.bot@gmail.com>
2143
2144         Unreviewed, rolling out r99626.
2145         http://trac.webkit.org/changeset/99626
2146         https://bugs.webkit.org/show_bug.cgi?id=71866
2147
2148         "C++ exceptions cannot be disabled without influencing the
2149         Objective-C exceptions" (Requested by benjaminp on #webkit).
2150
2151         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2152
2153 2011-11-08  Benjamin Poulain  <bpoulain@apple.com>
2154
2155         [Mac] Disable C++ exceptions from DumpRenderTree
2156         https://bugs.webkit.org/show_bug.cgi?id=71834
2157
2158         Reviewed by Darin Adler.
2159
2160         DumpRenderTree Mac does not handle C++ exceptions. When such exception
2161         happens, it tends to cause the AutoReleasePool stack to be corrupted,
2162         which leads to crashes long after the exception was raised.
2163
2164         This patch disabled C++ exceptions in order to catch the problems where
2165         they happen when a C++ exception is raised.
2166
2167         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2168
2169 2011-11-08  Julien Chaffraix  <jchaffraix@webkit.org>
2170
2171         Moved myself to the reviewer list (yay!).
2172
2173         * Scripts/webkitpy/common/config/committers.py:
2174
2175 2011-11-08  Zeno Albisser  <zeno@webkit.org>
2176
2177         Added myself as a committer.
2178
2179         * Scripts/webkitpy/common/config/committers.py:
2180
2181 2011-11-08  Andy Wingo  <wingo@igalia.com>
2182
2183         Skip some ECMAScript tests that fail on Linux in some time zones.
2184         https://bugs.webkit.org/show_bug.cgi?id=71371
2185
2186         Reviewed by Martin Robinson.
2187
2188         * Scripts/run-javascriptcore-tests: Skip some more tests.
2189
2190 2011-11-08  Csaba Osztrogonác  <ossy@webkit.org>
2191
2192         [Qt] Unreviewed trivial fix after build system refactoring.
2193
2194         * Scripts/run-qtwebkit-tests: Fix path of QtWebProcess for QML tests.
2195
2196 2011-11-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2197
2198         [Qt] Don't set OBJECTS_DIR and DEFINES in default_pre
2199
2200         If a pro file needs to access the OBJECTS_DIR it should use the
2201         form ${QMAKE_VAR_OBJECTS_DIR} to ensure the value is evaluated
2202         after defaults_post has been processed.
2203
2204         Setting DEFINES in defaults_pre is also bad, as any DEFINES=foo on
2205         the command line will override whatever we set in defaults_pre.
2206
2207         Reviewed by Simon Hausmann.
2208
2209         * qmake/mkspecs/features/default_post.prf:
2210         * qmake/mkspecs/features/default_pre.prf:
2211
2212 2011-11-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2213
2214         [Qt] Prevent duplicated sources in SOURCES/OBJECTIVE_SOURCES
2215
2216         Reviewed by Simon Hausmann.
2217
2218         * qmake/mkspecs/features/default_post.prf:
2219
2220 2011-11-07  Zeno Albisser  <zeno.albisser@nokia.com>
2221
2222         [Qt][WK2] MiniBrowser should use urlFromUserInput()
2223         https://bugs.webkit.org/show_bug.cgi?id=71680
2224
2225         Use urlFromUserInput() / QUrl::fromUserInput() to automatically
2226         complete urls in MiniBrowser.
2227
2228         Reviewed by Tor Arne Vestbø.
2229
2230         * MiniBrowser/qt/BrowserWindow.cpp:
2231         (BrowserWindow::BrowserWindow):
2232         (BrowserWindow::load):
2233         * MiniBrowser/qt/qml/BrowserWindow.qml:
2234         * MiniBrowser/qt/utils.cpp:
2235         (Utils::urlFromUserInput):
2236         * MiniBrowser/qt/utils.h:
2237         (Utils::Utils):
2238
2239 2011-11-07  Yuqiang Xian  <yuqiang.xian@intel.com>
2240
2241         Added myself as a committer.
2242
2243         * Scripts/webkitpy/common/config/committers.py:
2244
2245 2011-11-07  Csaba Osztrogonác  <ossy@webkit.org>
2246
2247         Unreviewed webkitpy test fix after r99512.
2248
2249         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2250         Xianzhu Wang is now a committer, so we can't nominate him as a committer anymore.
2251
2252 2011-11-07  Xianzhu Wang  <wangxianzhu@chromium.org>
2253
2254         Added myself as a committer.
2255
2256         * Scripts/webkitpy/common/config/committers.py:
2257
2258 2011-11-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2259
2260         Unreviewed, rolling out r99470.
2261         http://trac.webkit.org/changeset/99470
2262         https://bugs.webkit.org/show_bug.cgi?id=71740
2263
2264         "Broke test-webkitpy" (Requested by eseidel2 on #webkit).
2265
2266         * Scripts/webkitpy/common/config/watchlist:
2267
2268 2011-11-07  Tony Chang  <tony@chromium.org>
2269
2270         [chromium] update flakiness dashboard to reflect current bots
2271
2272         Reviewed by Ojan Vafai.
2273
2274         * TestResultServer/static-dashboards/builders.js: Remove (deps) debug
2275             bots and merged linux debug bots into a single bot.
2276         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2277         (setupExpectationsTest):
2278
2279 2011-11-07  Dana Jansens  <danakj@chromium.org>
2280
2281         Add cc-bugs group to watch changes in chromium graphics
2282         https://bugs.webkit.org/show_bug.cgi?id=71690
2283
2284         Reviewed by James Robinson.
2285
2286         * Scripts/webkitpy/common/config/watchlist:
2287
2288 2011-11-07  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
2289
2290         [NRWT] Parsing of test_expectations.txt should be agnostic to newline at end
2291         https://bugs.webkit.org/show_bug.cgi?id=70912
2292
2293         Reviewed by Ojan Vafai.
2294
2295         * Scripts/webkitpy/layout_tests/port/webkit.py: Add newline at the end of test_expectations.txt.
2296         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Make up the test_test_expectations method for the updated webkit.py.
2297
2298 2011-11-07  Eric Seidel  <eric@webkit.org>
2299
2300         new-run-webkit-tests: support --repeat-each feature from old-run-webkit-tests
2301         https://bugs.webkit.org/show_bug.cgi?id=62199
2302
2303         Reviewed by Dirk Pranke.
2304
2305         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2306         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2307         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2308
2309 2011-11-07  Fady Samuel  <fsamuel@chromium.org>
2310
2311         [Chromium] Rename WebView::scalePage to WebView::setPageScaleFactor to match WebCore
2312         https://bugs.webkit.org/show_bug.cgi?id=71485
2313
2314         Reviewed by Darin Fisher.
2315
2316         * DumpRenderTree/chromium/EventSender.cpp:
2317         (EventSender::scalePageBy):
2318         * DumpRenderTree/chromium/TestShell.cpp:
2319         (TestShell::resetTestController):
2320
2321 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2322
2323         [Qt] Put the jsc binary in 'bin' instead of leaving it deep in the build tree
2324
2325         Allows us to not package up the whole Source/JavaScriptCore directory for the
2326         buildbots.
2327
2328         Reviewed-by Simon Hausmann.
2329
2330         * BuildSlaveSupport/built-product-archive:
2331         * Scripts/webkitdirs.pm:
2332         (jscProductDir):
2333
2334 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2335
2336         [Qt] Ensure we always export symbols for the QtWebKit API when building WebKit
2337
2338         Reviewed-by Simon Hausmann.
2339
2340         * qmake/mkspecs/features/default_post.prf:
2341
2342 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2343
2344         [Qt] Sanitize qmake paths correctly before comparing
2345
2346         The qmake function toSanitizedPath had a bug causing empty paths on MinGW,
2347         which caused us to always generate derived webcore sources, but never build
2348         them. The bug has been fixed, and we now also sanitize paths for the injected
2349         bundle derived sources.
2350
2351         Reviewed by Simon Hausmann.
2352
2353         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
2354         * qmake/mkspecs/features/functions.prf:
2355
2356 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2357
2358         [Qt] Print right order for changing feature defines
2359
2360         Reviewed by Simon Hausmann.
2361
2362         * Scripts/webkitdirs.pm:
2363         (buildQMakeProject):
2364
2365 2011-11-06  Csaba Osztrogonác  <ossy@webkit.org>
2366
2367         [Qt] Unreviewed trivial fix after build system refactoring.
2368
2369         * Scripts/run-qtwebkit-tests: Fix qml_import_path.
2370
2371 2011-11-06  Eric Seidel  <eric@webkit.org>
2372
2373         Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
2374         https://bugs.webkit.org/show_bug.cgi?id=66078
2375
2376         Unreviewed.  Add an assert about the type of "args"
2377         to our Executive Mocks and fix a piece of code
2378         from this patch which was hitting that assert
2379         when executing for real.
2380
2381         * Scripts/webkitpy/common/system/executive_mock.py:
2382         * Scripts/webkitpy/layout_tests/port/webkit.py:
2383
2384 2011-11-06  Eric Seidel  <eric@webkit.org>
2385
2386         Split chunk handling out of prepare_lists_and_print_output to make it more readable
2387         https://bugs.webkit.org/show_bug.cgi?id=71629
2388
2389         Reviewed by Adam Barth.
2390
2391         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2392
2393 2011-11-06  Eric Seidel  <eric@webkit.org>
2394
2395         Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
2396         https://bugs.webkit.org/show_bug.cgi?id=66078
2397
2398         Reviewed by Adam Barth.
2399
2400         The runtime feature detection was fixed to work in bug 64472.
2401         In this bug I moved the symbol-based feature detection from
2402         popen() to Executive.run_command and cleaned up the callers
2403         and unittests to make sure that we're correctly parsing the
2404         nm output correctly.  The old code happened to work even though
2405         the runtime-features path was using "str in list" and the
2406         symbol features path was using "str in str" and it just happened
2407         to do what we wanted to.  Now runtime features and symbol feature
2408         blacklists are computed separately (and with better documentation).
2409
2410         This system remains confusing, partially because these are black-lists
2411         which are amended to whatever static blacklist may exist for the
2412         port as part of a Skipped list file.
2413
2414         For example, notice how the runtime feature list only has directory
2415         blacklists for a couple features.  If all features are off,
2416         how do we skip enough tests with only 2 entries in the blacklist map?
2417         The answer is that Windows is the only port to use runtime feature
2418         detection, and the win/Skipped file turns off all the other features
2419         statically (like mathml, mhtml, wss, etc.) where as some other ports (like AppleMac)
2420         which use symbol-based feature detection turn of mathml, wcss, etc
2421         using the blacklists found in _missing_symbol_to_skipped_tests.
2422
2423         I also noticed a couple places where we still referenced xhtmlmp
2424         even though support for such has been removed from WebKit.  Removed those.
2425
2426         This should result in no functional change.
2427
2428         * Scripts/webkitpy/layout_tests/port/gtk.py:
2429          - Use self._filesystem instead of os.path
2430         * Scripts/webkitpy/layout_tests/port/webkit.py:
2431         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2432
2433 2011-11-06  Dan Bernstein  <mitz@apple.com>
2434
2435         Made show-pretty-diff work when the input path contains spaces.
2436
2437         Reviewed by Anders Carlsson.
2438
2439         * Scripts/show-pretty-diff:
2440
2441 2011-11-05  Daniel Cheng  <dcheng@chromium.org>
2442
2443         [chromium] Use the security origin instead of the URL when checking notification permissions
2444         https://bugs.webkit.org/show_bug.cgi?id=71590
2445
2446         Reviewed by Adam Barth.
2447
2448         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2449         (NotificationPresenter::checkPermission):
2450         * DumpRenderTree/chromium/NotificationPresenter.h:
2451
2452 2011-11-05  Darin Adler  <darin@apple.com>
2453
2454         Fix a small leak in Mac version of LayoutTestController
2455         https://bugs.webkit.org/show_bug.cgi?id=71615
2456
2457         Reviewed by Mark Rowe.
2458
2459         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2460         (LayoutTestController::applicationCacheDiskUsageForOrigin): Release the origin.
2461         (LayoutTestController::localStorageDiskUsageForOrigin): Ditto.
2462
2463 2011-11-04  Eric Seidel  <eric@webkit.org>
2464
2465         Upgrade to the latest Mechanize
2466         https://bugs.webkit.org/show_bug.cgi?id=71594
2467
2468         Reviewed by Adam Barth.
2469
2470         I noticed our mechanize was somewhat out of date when removing Python 2.5 support.
2471         Mechanize is no longer two separate libraries, so importing it is much simpler.
2472
2473         * Scripts/webkitpy/thirdparty/__init__.py:
2474
2475 2011-11-04  Stephen Chenney  <schenney@chromium.org>
2476
2477         Crash in ScrollAnimator.cpp
2478         https://bugs.webkit.org/show_bug.cgi?id=69865
2479
2480         The code in ScrollAnimator assumes that horizontal per-page mouse
2481         wheel events cannot happen, which is not true. This patch adds layout
2482         tests for all paging wheel event situations and fixes the broken
2483         horizontal case.
2484
2485         Reviewed by Anders Carlsson
2486
2487         * DumpRenderTree/chromium/EventSender.cpp:
2488         (EventSender::handleMouseWheel): Added the ability to specify that a
2489         mouse wheel event should be paging.
2490
2491 2011-11-04  Eric Seidel  <eric@webkit.org>
2492
2493         Remove deprecated free functions in port.factory
2494         https://bugs.webkit.org/show_bug.cgi?id=71494
2495
2496         Unreviewed.  Fix exception when running new-run-webkit-httpd.
2497
2498         * Scripts/new-run-webkit-httpd:
2499
2500 2011-11-04  Adam Roben  <aroben@apple.com>
2501
2502         Remove Leopard-specific code from build.webkit.org
2503
2504         We don't have any Leopard bots anymore.
2505
2506         Fixes <http://webkit.org/b/71583> build.webkit.org configuration contains obsolete Leopard code
2507
2508         Reviewed by Mark Rowe.
2509
2510         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed now-unused StartATSServer
2511         and StopATSServer steps.
2512         (unitTestsSupported): Removed check for mac-leopard.
2513         (TestFactory.__init__): Removed Leopard-specific steps.
2514
2515 2011-11-04  Eric Seidel  <eric@webkit.org>
2516
2517         new-run-webkit-tests autoinstalls python-irclib even though it doesn't need to
2518         https://bugs.webkit.org/show_bug.cgi?id=71549
2519
2520         Reviewed by Adam Barth.
2521
2522         Several members of Host didn't really belong there
2523         and were instead specific to WebKitPatch, so I've moved
2524         them up onto that class.
2525
2526         * Scripts/webkitpy/common/host.py:
2527         * Scripts/webkitpy/common/host_mock.py:
2528         * Scripts/webkitpy/tool/main.py:
2529         * Scripts/webkitpy/tool/mocktool.py:
2530         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2531
2532 2011-11-04  Tony Chang  <tony@chromium.org>
2533
2534         garden-o-matic: bring back party time!
2535         https://bugs.webkit.org/show_bug.cgi?id=71582
2536
2537         Reviewed by Adam Barth.
2538
2539         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Allow images from file:
2540         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/partytime.gif: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/partytime.gif.
2541         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Add length() for UpdateTracker.
2542         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Plumb through length().
2543         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Toggle partytime.gif via css class.
2544         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css: Add css styling for partytime.
2545
2546 2011-11-04  Raphael Kubo da Costa  <kubo@profusion.mobi>
2547
2548         [EFL] DRT: Fix the order of the items in the dumped history list.
2549         https://bugs.webkit.org/show_bug.cgi?id=71562
2550
2551         It did not make much sense to hold the history list in a map, as we do not need
2552         the keys. And the printed items must be sorted by target, which is more easily
2553         done with a vector.
2554
2555         Should make tests such as http/tests/navigation/error404-frames.html pass.
2556
2557         Reviewed by Antonio Gomes.
2558
2559         * DumpRenderTree/efl/DumpHistoryItem.cpp:
2560         (compareHistoryItemsByTarget):
2561         (dumpHistoryItem):
2562
2563 2011-11-04  Patrick Gansterer  <paroga@webkit.org>
2564
2565         [Qt] Remove ENABLE_SQLITE from qmake files
2566         https://bugs.webkit.org/show_bug.cgi?id=71546
2567
2568         Reviewed by Simon Hausmann.
2569
2570         * qmake/mkspecs/features/features.prf:
2571         * qmake/mkspecs/features/webcore.prf:
2572
2573 2011-11-04  Adam Barth  <abarth@webkit.org>
2574
2575         watchlist for WebIDL shouldn't trigger on Internals.idl
2576         https://bugs.webkit.org/show_bug.cgi?id=70657
2577
2578         Reviewed by David Levin.
2579
2580         Internals.idl isn't part of the Web-facing IDL in the project.
2581
2582         * Scripts/webkitpy/common/config/watchlist:
2583
2584 2011-11-04  Anders Carlsson  <andersca@apple.com>
2585
2586         Fix WKTR crash when running NPN_ConvertPoint test.
2587
2588         Call notifyDone in a timeout - otherwise we'll end up entering layout from layout.
2589
2590         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
2591         (ConvertPoint::NPP_SetWindow):
2592
2593 2011-11-04  Anders Carlsson  <andersca@apple.com>
2594
2595         NPN_ConvertPoint plug-in test should be called from NPP_SetWindow
2596         https://bugs.webkit.org/show_bug.cgi?id=71570
2597
2598         Reviewed by Simon Fraser.
2599
2600         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2601         (PluginTest::NPP_SetWindow):
2602         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2603         Remove the NPP parameter from NPP_SetWindow.
2604
2605         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp:
2606         (NPPSetWindowCalledDuringDestruction::NPP_SetWindow):
2607         Remove the NPP parameter from NPP_SetWindow.
2608
2609         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
2610         (PassDifferentNPPStruct::NPP_SetWindow):
2611         Remove the NPP parameter from NPP_SetWindow and use PluginTest::log for logging.
2612
2613         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
2614         (ConvertPoint::NPP_SetWindow):
2615         Run the test from NPP_SetWindow and call notifyDone() when done.
2616
2617         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2618         (NPP_SetWindow):
2619         Remove unnecessary parameter.
2620
2621 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
2622
2623         [Qt] Fix run-qtwebkit-tests execution on the build bot(s).
2624
2625         Rubber-stamped by Tor Arne Vestbø.
2626
2627         * BuildSlaveSupport/build.webkit.org-config/master.cfg: The path to the tests
2628         changed slightly after the refactoring.
2629
2630 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2631
2632         [Qt] Don't warn about disabling WebKit2 when qmake does recursive includes
2633
2634         Reviewed by Simon Hausmann.
2635
2636         * qmake/mkspecs/features/default_pre.prf:
2637
2638 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2639
2640         [Qt] Don't error out on wrong Qt version when qmake does recursive includes
2641
2642         Reviewed by Simmon Hausmann.
2643
2644         * qmake/mkspecs/features/default_pre.prf:
2645
2646 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2647
2648         [Qt] Disable STDIN check before cleaning build dir
2649
2650         It didn't work on the bots.
2651
2652         Reviewed by Ossy.
2653
2654         * Scripts/webkitdirs.pm:
2655
2656 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2657
2658         [Qt] Don't build all of webkit when running build-jsc
2659
2660         In case the whole webkit project was built, but we then subsequently
2661         want to build only JSC, we need to run make in the proper subdirectory.
2662
2663         This also means the incremental target needs to be added to all
2664         makefiles.
2665
2666         Reviewed by Simmon Hausmann.
2667
2668         * Scripts/webkitdirs.pm:
2669         (buildQMakeProject):
2670         * qmake/mkspecs/features/default_post.prf:
2671
2672 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
2673
2674         Fix run-javascriptcore-tests for Qt when it's executed by the bot.
2675
2676         Reviewed by Tor Arne Vestbø.
2677
2678         * Scripts/webkitdirs.pm:
2679         (jscProductDir): jsc path changed.
2680
2681 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2682
2683         [Qt] Error out early if trying to build against Qt < 4.8
2684
2685         Reviewed by Simon Hausmann.
2686
2687         * qmake/mkspecs/features/default_pre.prf:
2688
2689 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
2690
2691         Fix run-launcher for Qt and Gtk.
2692
2693         Rubber-stamped by Tor Arne Vestbø.
2694
2695         * Scripts/webkitdirs.pm:
2696         (isWK2): Re-add isWK2(), as it's used in run-launcher.
2697
2698 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2699
2700         [Qt] Ignore '-2' if passed to build-webkit. WebKit2 is now built by default.
2701
2702         Reviewed by Simon Hausmann.
2703
2704         * Scripts/build-webkit:
2705
2706 2011-11-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2707
2708         [GTK] Use web view title as window title in MiniBrowser
2709         https://bugs.webkit.org/show_bug.cgi?id=71544
2710
2711         Reviewed by Philippe Normand.
2712
2713         * MiniBrowser/gtk/BrowserWindow.c:
2714         (webViewURIChanged): Removed extra space.
2715         (webViewTitleChanged): Set window title using
2716         webkit_web_view_get_title().
2717         (browser_window_init): Set initial default window title.
2718         (browserWindowConstructed): Connect to WebView notify::title
2719         signal.
2720
2721 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2722
2723         [Qt] Refactor and clean up the qmake build system
2724
2725         The qmake build system has accumulated a bit of cruft and redundancy
2726         over time. There's also a fairly tight coupling between how to build
2727         the various targets, and _what_ to build, making it harder to add new
2728         rules or sources. This patch aims to elevate these issues somewhat.
2729
2730         This is a short-list of the changes:
2731
2732           * The rules for how to build targets are now mostly contained as
2733             prf-files in Tools/qmake/mkspecs/features. Using mkspecs also
2734             allows us to do pre- and post-processing of each project file,
2735             which helps to clean up the actual project files.
2736
2737           * Derived sources are no longer generated as a separate make-step
2738             but is part of each target's project file as a subdir. Makefile
2739             rules are used to ensure that we run make on the derived sources
2740             before running qmake on the actual target makefile. This makes
2741             it easier to keep a proper dependency between derived sources
2742             and the target.
2743
2744           * We use GNU make and the compiler to generate dependencies on
2745             UNIX-based systems running Qt 5. This allows us to lessen the
2746             need to run qmake, which should reduce compile time.
2747
2748           * WebKit2 is now build by default if building with Qt 5. It can
2749             be disabled by passing --no-webkit2 to build-webkit.
2750
2751         The result of these changes are hopefully a cleaner and easier
2752         build system to modify, and faster build times due to no longer
2753         running qmake on every single build. It's also a first step
2754         towards possibly generating the list of sources using another
2755         build system.
2756
2757         https://bugs.webkit.org/show_bug.cgi?id=71222
2758
2759         Reviewed by Simon Hausmann.
2760
2761         * DerivedSources.pro: Removed.
2762         * DumpRenderTree/qt/DumpRenderTree.pro:
2763         * DumpRenderTree/qt/ImageDiff.pro:
2764         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2765         * MiniBrowser/qt/MiniBrowser.pro:
2766         * QtTestBrowser/QtTestBrowser.pro:
2767         * QtTestBrowser/launcherwindow.cpp:
2768         (LauncherWindow::initializeView):
2769         (LauncherWindow::createChrome):
2770         (LauncherWindow::screenshot):
2771         * QtTestBrowser/launcherwindow.h:
2772         (WindowOptions::WindowOptions):
2773         * Scripts/build-webkit:
2774         (unlinkZeroFiles):
2775         * Scripts/webkitdirs.pm:
2776         (qtFeatureDefaults):
2777         (promptUser):
2778         (buildQMakeProject):
2779         * Tools.pro:
2780         * WebKitTestRunner/DerivedSources.pri: Added.
2781         * WebKitTestRunner/DerivedSources.pro: Removed.
2782         * WebKitTestRunner/InjectedBundle/DerivedSources.pri: Added.
2783         * WebKitTestRunner/InjectedBundle/InjectedBundle.pro: Added.
2784         * WebKitTestRunner/InjectedBundle/Target.pri: Added.
2785         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Removed.
2786         * WebKitTestRunner/Target.pri: Added.
2787         * WebKitTestRunner/WebKitTestRunner.pro:
2788         * WebKitTestRunner/qt/TestInvocationQt.cpp:
2789         * WebKitTestRunner/qt/WebKitTestRunner.pro: Removed.
2790         * qmake/README: Added.
2791         * qmake/mkspecs/features/default_post.prf: Added.
2792         * qmake/mkspecs/features/default_pre.prf: Added.
2793         * qmake/mkspecs/features/features.prf: Renamed from Source/WebCore/features.pri.
2794         * qmake/mkspecs/features/functions.prf: Added.
2795         * qmake/mkspecs/features/javascriptcore.prf: Renamed from Source/JavaScriptCore/JavaScriptCore.pri.
2796         * qmake/mkspecs/features/mac/default_post.prf: Added.
2797         * qmake/mkspecs/features/mac/default_pre.prf: Added.
2798         * qmake/mkspecs/features/minimal_qt.prf: Added.
2799         * qmake/mkspecs/features/qtwebkit.prf: Added.
2800         * qmake/mkspecs/features/rpath.prf: Added.
2801         * qmake/mkspecs/features/unix/default_post.prf: Added.
2802         * qmake/mkspecs/features/unix/default_pre.prf: Added.
2803         * qmake/mkspecs/features/valgrind.prf: Added.
2804         * qmake/mkspecs/features/webcore.prf: Renamed from Source/WebCore/WebCore.pri.
2805         * qmake/mkspecs/features/webkit2.prf: Copied from Source/WebKit2/WebKit2.pri.
2806         * qmake/mkspecs/features/win32/default_post.prf: Added.
2807         * qmake/qt_webkit.pri: Renamed from Source/WebKit/qt/qt_webkit_version.pri.
2808         * qmake/syncqt-4.8: Added.
2809         (showUsage):
2810         ():
2811         (copyFile):
2812         (symlinkFile):
2813
2814 2011-11-04  Eric Seidel  <eric@webkit.org>
2815
2816         Remove deprecated free functions in port.factory
2817         https://bugs.webkit.org/show_bug.cgi?id=71494
2818
2819         Unreviewed.  Fixing exception seen when running test-webkitpy.
2820
2821         Sorry, I previously had deleted the relevant rebaseline-chromium-webkit-tests
2822         unittest, since that script is nearly ready to be deleted.  But I added
2823         it back at the last second and failed to run the tests. :(
2824         This fixes the exception the bots were seeing.
2825
2826         * Scripts/webkitpy/style/checkers/test_expectations.py:
2827         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2828         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2829
2830 2011-11-02  Xiaomei Ji  <xji@chromium.org>
2831
2832         Enable ctrl-arrow move cursor by word in visual order in cr-win by command line flag.
2833         https://bugs.webkit.org/show_bug.cgi?id=71163
2834
2835         Reviewed by Ryosuke Niwa.
2836
2837         * DumpRenderTree/chromium/WebPreferences.cpp: Set visualWordMovementEabled to false in DRT.
2838         (WebPreferences::applyTo):
2839
2840 2011-11-03  Eric Seidel  <eric@webkit.org>
2841
2842         Remove deprecated free functions in port.factory
2843         https://bugs.webkit.org/show_bug.cgi?id=71494
2844
2845         Reviewed by Adam Barth.
2846
2847         I removed port.factory.get, get_all, and all_port_names -- long-since deprecated
2848         free functions in factory.py.  To remove these required fixing all callsites
2849         to use MockHost, Host, or PortFactory where appropriate.  After this change
2850         we're only left with a handfull of places where we inappropraitely use a
2851         real Executive, FileSystem or User object during unittesting.
2852
2853         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
2854          - These PortFactory overrides were from an earlier edition of my previous patch
2855            in the end, I removed MockPortFactory so all tests ended up with this same
2856            real PortFactory() with a MockHost.  This was simply redundent code.
2857         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2858          - Use MockHost to get a mocked-out PortFactory.
2859         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2860          - This code has no access to a Host object, so we just use a default PortFactory
2861            for now.  This will still incorrectly create real Executive/FileSystem objects
2862            durring unittesting, which is wrong. :(
2863         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
2864          - Use a MockHost to get a mocked PortFactory.
2865         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
2866          - Use a MockHost to get a mocked PortFactory.
2867         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
2868          - ditto.
2869         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2870          - ditto.
2871         * Scripts/webkitpy/layout_tests/port/__init__.py:
2872          - factory.get no longer exists.  Yay!
2873         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2874          - Use a MockHost to get a mocked PortFactory.
2875            To do this efficiently, I created a helper function
2876            and combined all these (mostly redundant) tests into one test
2877            with several calls to the helper function.
2878         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2879          - Pass MockUser and MockExecutive in these port testing subclasses.
2880          - I also removed a bunch of unecessary uses of mocktool. namespacing.
2881         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2882          - Awesome windows hacks should only happen on win32.  Once we started
2883            using MockExecutives these 'svn help' commands started printing in
2884            other tests, which is how I found this bug.
2885         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2886          - DryRunPort has no Host, so just use a PortFactory() directly.
2887            This will do the wrong thing if we're unittesting the DryRun port
2888            but it's no worse than the existing code.
2889         * Scripts/webkitpy/layout_tests/port/factory.py:
2890          - Remove the free functions.
2891          - Fix argument overriding to be able to override None.
2892         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2893          - Use a mocked-out PortFactory during testing.
2894         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2895          - Pass MockExecutive and MockUser to these manual Port instantiations.
2896         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2897          - No access to a Host object here, so just using PortFactory directly.
2898            This is wrong, but no more wrong than the existing code was.
2899         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2900          - Use a MockHost to get a mocked out PortFactory.
2901         * Scripts/webkitpy/layout_tests/port/test.py:
2902          - Use our fancy _set_default_overriding_none system to clean this code up and pass a MockExecutive.
2903         * Scripts/webkitpy/layout_tests/port/win.py:
2904          - Don't run cmd /c ver from WinPort.__init__ or it shows up in unittests which have logging MockExecutive
2905            now that we're actually passing MockExecutive to most Port instantiations during testing.
2906         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2907          - Pass our new "unittesting" bool to _detect_version when actually unittesting.
2908         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2909          - Host is the future.
2910         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2911          - Use a MockHost to get a mocked out PortFactory.  Once we have a mocked PortFactory
2912            we don't need to pass MockUser explicitly, it does that automatically for us.
2913         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2914          - Use a MockHost to get a mocked out PortFactory.
2915         * Scripts/webkitpy/style/checkers/test_expectations.py:
2916          - We don't have access to a Host object, so using PortFactory() directly.
2917         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2918          - Remove unused variable.
2919         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2920          - Host isn't accessible here, so using PortFactory() directly, which
2921            although unfortunate is no worse than before.
2922         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2923          - Testing is much easier when you don't need to hack global state...
2924         * Scripts/webkitpy/tool/commands/expectations.py:
2925          - Use the port_factory on the tool.
2926         * Scripts/webkitpy/tool/commands/rebaseline.py:
2927          - ditto.
2928         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2929          - This unittest was wrong.  It was trying to pass the tool object, but failing to pass
2930            the arguments in the right order.  Fixing that made it use a MockFileSystem
2931            (like it had been trying to), which then required us to actually populate
2932            that MockFileSystem with fake expectation files (instead of using the ones on the real disk).
2933         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2934          - Get the port_factory from the tool.
2935         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2936          - Ditto.
2937         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2938          - Use a MockHost to get a mocked out Port object.
2939
2940 2011-11-03  Raphael Kubo da Costa  <kubo@profusion.mobi>
2941
2942         [EFL] DRT: Allow choosing which backing store to use.
2943         https://bugs.webkit.org/show_bug.cgi?id=70532
2944
2945         Reviewed by Antonio Gomes.
2946
2947         This change makes it possible to change the backing store used by DRT
2948         from Tiled Backing Store (TBS) to Single Backing Store (SBS) by
2949         setting the environment variable DRT_USE_SINGLE_BACKING_STORE to 1.
2950
2951         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2952         (DumpRenderTreeChrome::createView):
2953         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2954         (shouldUseSingleBackingStore):
2955         (chooseAndInitializeAppropriateSmartClass):
2956         (drtViewAdd):
2957         * DumpRenderTree/efl/DumpRenderTreeView.h:
2958
2959 2011-11-02  Erik Arvidsson  <arv@chromium.org>
2960
2961         JS Test Harness: Remove more link tags
2962         https://bugs.webkit.org/show_bug.cgi?id=71339
2963
2964         Reviewed by Ojan Vafai.
2965
2966         * Scripts/make-new-script-test:
2967         (writeTestFile): Don't output <link>
2968
2969 2011-11-03  Thouraya ANDOLSI  <thouraya.andolsi@st.com>
2970
2971         Reviewed by Martin Robinson.
2972
2973         [GTK] arguments passed to build-jsc are not taken into account
2974         https://bugs.webkit.org/show_bug.cgi?id=58333
2975
2976         * Scripts/build-jsc:
2977
2978 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2979
2980         [GTK] Show url of history items in a status bar in MiniBrowser
2981         https://bugs.webkit.org/show_bug.cgi?id=71474
2982
2983         Reviewed by Martin Robinson.
2984
2985         * MiniBrowser/gtk/BrowserWindow.c:
2986         (browserWindowSetStatusText): Set status text and show/hide the
2987         status label.
2988         (resetStatusText): Reset status text when history menu is hidden.
2989         (browserWindowHistoryItemSelected): Show url of currently selected
2990         history item.
2991         (browserWindowCreateBackForwardMenu): Connect to hide signal of
2992         menu to reset the status text.
2993         (browserWindowConstructed): Use GtkOverlay if available to show
2994         status text.
2995
2996 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2997
2998         [GTK] Add back/forward menus to MiniBrowser using WebKit2 GTK+ API
2999         https://bugs.webkit.org/show_bug.cgi?id=71466
3000
3001         Reviewed by Martin Robinson.
3002
3003         * MiniBrowser/gtk/BrowserWindow.c:
3004         (browserWindowHistoryItemActivated): Go to selected back formard
3005         list item using webkit_web_view_go_to_back_forward_list_item()
3006         (browserWindowCreateBackForwardMenu): Create a GtkMenu for the
3007         given GList of WebKitBackForwardListItems.
3008         (browserWindowUpdateNavigationActions): Enable/disable back and
3009         forward buttons depending on whether it's possible to go
3010         back/forward. Create a menu for back and forward toolbar buttons.
3011         (backForwadlistChanged): Call browserWindowUpdateNavigationActions().
3012         (browserWindowConstructed): Connect to WebKitBackForwardList
3013         changed signal.
3014
3015 2011-11-03  Simon Hausmann  <simon.hausmann@nokia.com>
3016
3017         [Qt] Remove Maemo specific code paths
3018         https://bugs.webkit.org/show_bug.cgi?id=71476
3019
3020         Reviewed by Kenneth Rohde Christiansen.
3021
3022         * QtTestBrowser/launcherwindow.cpp:
3023         (LauncherWindow::~LauncherWindow):
3024         (LauncherWindow::init):
3025         (LauncherWindow::showLinkHover):
3026         (LauncherWindow::selectElements):
3027         (LauncherWindow::showFPS):
3028         (LauncherWindow::updateFPS):
3029         * QtTestBrowser/launcherwindow.h:
3030         (WindowOptions::WindowOptions):
3031         * QtTestBrowser/locationedit.cpp:
3032         * QtTestBrowser/locationedit.h:
3033
3034 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3035
3036         [GTK] Show load progress information in MiniBrowser using WebKit2 GTK+ API
3037         https://bugs.webkit.org/show_bug.cgi?id=71461
3038
3039         Reviewed by Martin Robinson.
3040
3041         * MiniBrowser/gtk/BrowserWindow.c:
3042         (resetEntryProgress): Reset the entry progress after a while when
3043         load has been completed.
3044         (webViewLoadProgressChanged): Update location entry progress.
3045         (browserWindowConstructed): Connect to WebView
3046         notify::estimated-load-progress signal.
3047
3048 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3049
3050         [GTK] Remove WebKit2 C API from MiniBrowser
3051         https://bugs.webkit.org/show_bug.cgi?id=71459
3052
3053         Reviewed by Martin Robinson.
3054
3055         Use the GTK+ API instead to add minimum functionality. The other
3056         features will be ported to GTK+ API in following patches.
3057
3058         * MiniBrowser/gtk/BrowserWindow.c:
3059         (activateUriEntryCallback): Use webkit_web_view_load_uri().
3060         (goBackCallback): Use webkit_web_view_go_back().
3061         (goForwardCallback): Use webkit_web_view_go_forward().
3062         (webViewURIChanged): Update location entry with current uri using
3063         webkit_web_view_get_uri().
3064         (browserWindowFinalize):
3065         (browserWindowGetProperty):
3066         (browserWindowSetProperty):
3067         (browser_window_init):
3068         (browserWindowConstructed): Connect to notify::uri signal of
3069         WebView to be notified when the URI changes.
3070         (browser_window_class_init):
3071         (browser_window_new): Use WebKitWebView.
3072         (browser_window_get_view): Use WebKitWebView
3073         * MiniBrowser/gtk/BrowserWindow.h:
3074         * MiniBrowser/gtk/GNUmakefile.am:
3075         * MiniBrowser/gtk/WebBundle/WebBundleMain.c: Removed.
3076         * MiniBrowser/gtk/main.c:
3077         (loadURI): Use webkit_web_view_new().
3078         (main):
3079
3080 2011-11-03  Simon Hausmann  <simon.hausmann@nokia.com>
3081
3082         [Qt] Unable to start MiniBrowser after run-webkit-tests
3083         https://bugs.webkit.org/show_bug.cgi?id=71469
3084
3085         Reviewed by Csaba Osztrogonác.
3086
3087         * Scripts/run-launcher: Pass @ARGV instead of @args, which is stripped
3088         from things like -2. Neither Gtk or Qt MiniBrowser like unknown command
3089         line arguments.
3090
3091 2011-11-03  Philippe Normand  <pnormand@igalia.com>
3092
3093         [GTK] [WK2] ttf-liberation fonts moved to a new location (in Debian)
3094         https://bugs.webkit.org/show_bug.cgi?id=71445
3095
3096         Reviewed by Martin Robinson.
3097
3098         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3099         (initializeFonts): set directoriesDescription only when needed.
3100         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3101         (WTR::inititializeFontConfigSetting): Add the new font path for Debian fonts and
3102         refactored the font files loading code to avoid copy/pastes, ease
3103         maintenance and future font directories additions.
3104
3105 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3106
3107         [GTK] Remove GtkLauncher2
3108         https://bugs.webkit.org/show_bug.cgi?id=71449
3109
3110         Reviewed by Martin Robinson.
3111
3112         GtkLauncher2 is the GtkLauncher code compiled with webkit2. This
3113         made sense when we wanted to implement the exactly same wk1 API
3114         for wk2. Now the code would require an ifdef for most the api, so
3115         it's better to remove GtkLauncher2 and port MiniBrowser to the new
3116         GTK+ API.
3117
3118         * GNUmakefile.am:
3119         * GtkLauncher/main.c:
3120         (notifyProgressCb):
3121         (closeWebViewCb):
3122         (createBrowser):
3123         (addWebSettingsGroupToContext):
3124         (main):
3125
3126 2011-11-02  Philippe Normand  <pnormand@igalia.com>
3127
3128         [GTK] [DRT] ttf-liberation fonts moved to a new location (in Debian)
3129         https://bugs.webkit.org/show_bug.cgi?id=71359
3130
3131         Reviewed by Martin Robinson.
3132
3133         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3134         (initializeFonts): Add the new font path for Debian fonts and
3135         refactored the font files loading code to avoid copy/pastes, ease
3136         maintenance and future font directories additions.
3137
3138 2011-11-02  Eric Seidel  <eric@webkit.org>
3139
3140         Move Mocks into _mock files near their implementations
3141         https://bugs.webkit.org/show_bug.cgi?id=71425
3142
3143         Reviewed by Adam Barth.
3144
3145         This entire change is splitting mocktool.py into separate _mock.py files
3146         and placing them next to their real implementations.
3147
3148         I also deleted MockPortFactory (since it was wrong) and was just hiding
3149         the fact that the "skipped-ports" command was broken (and has been for a long time).
3150         So I made MockHost use a real PortFactory (passed a MockHost) and changed
3151         the skipped-ports implementation to use modern PortFactory methods.
3152
3153         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3154         * Scripts/webkitpy/common/checkout/checkout_mock.py: Added.
3155         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3156         * Scripts/webkitpy/common/checkout/deps_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
3157         * Scripts/webkitpy/common/checkout/scm/scm_mock.py: Added.
3158         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3159         * Scripts/webkitpy/common/config/ports_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
3160         * Scripts/webkitpy/common/host.py:
3161         * Scripts/webkitpy/common/host_mock.py: Added.
3162         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py: Added.
3163         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3164         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py: Added.
3165         * Scripts/webkitpy/common/net/credentials_unittest.py:
3166         * Scripts/webkitpy/common/net/failuremap_unittest.py:
3167         * Scripts/webkitpy/common/net/irc/irc_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
3168         * Scripts/webkitpy/common/net/statusserver_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
3169         * Scripts/webkitpy/common/net/statusserver_unittest.py:
3170         * Scripts/webkitpy/common/net/web_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
3171         * Scripts/webkitpy/common/system/executive.py:
3172         * Scripts/webkitpy/common/system/executive_mock.py:
3173         * Scripts/webkitpy/common/system/platforminfo_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
3174         * Scripts/webkitpy/common/system/user_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
3175         * Scripts/webkitpy/common/system/workspace_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
3176         * Scripts/webkitpy/common/system/workspace_unittest.py:
3177         * Scripts/webkitpy/common/watchlist/watchlist_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
3178         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3179         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
3180         * Scripts/webkitpy/layout_tests/port/__init__.py:
3181         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3182         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
3183         * Scripts/webkitpy/layout_tests/port/factory.py:
3184         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3185         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3186         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
3187         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
3188         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3189         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3190         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3191         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3192         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3193         * Scripts/webkitpy/test/main.py:
3194         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
3195         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3196         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3197         * Scripts/webkitpy/tool/commands/queries_unittest.py:
3198         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3199         * Scripts/webkitpy/tool/mocktool.py:
3200         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3201
3202 2011-11-02  Dan Bernstein  <mitz@apple.com>
3203
3204         Fixed the build and removed another copy to ColorBits.ttf.
3205
3206         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3207         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3208         * WebKitTestRunner/fonts/ColorBits.ttf: Removed.
3209
3210 2011-11-02  Dan Bernstein  <mitz@apple.com>
3211
3212         REGRESSION (r98759-r98773): platform/mac/fonts/color-bitmap.html failing on Lion Intel Debug (Tests)
3213         https://bugs.webkit.org/show_bug.cgi?id=71424
3214
3215         Reviewed by Sam Weinig.
3216
3217         Removed the ColorBits font and the code to register it in the process
3218         running the tests. The font was only used by the aforementioned test,
3219         which is now being removed.
3220
3221         * DumpRenderTree/fonts/ColorBits-A.png: Removed.
3222         * DumpRenderTree/fonts/ColorBits.ttf: Removed.
3223         * DumpRenderTree/mac/DumpRenderTree.mm:
3224         (allowedFontFamilySet):
3225         (activateTestingFonts):
3226         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3227         (WTR::inititializeFontConfigSetting):
3228         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3229         (WTR::allowedFontFamilySet):
3230         (WTR::activateFonts):
3231
3232 2011-11-02  Dan Bernstein  <mitz@apple.com>
3233
3234         Fix an intermittent hang in RenderedImageFromDOMRange.
3235
3236         Reviewed by Anders Carlsson.
3237
3238         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3239         (TestWebKitAPI::Util::run): Made the call to -runMode:beforeDate: return
3240         immediately if there are no sources by passing a date in the distant past.
3241
3242 2011-11-02  Adam Roben  <aroben@apple.com>
3243
3244         Add git-add-reviewer
3245
3246         I've been using this script for a while to add reviewers to git commits in my local
3247         repository before pushing them to the Subversion repository. Basic usage is:
3248
3249         git-add-reviewer HEAD^ "Joe Schmoe"
3250         or
3251         git-add-reviewer -i trunk
3252
3253         Fixes <http://webkit.org/b/71419> Would like an easy way to add reviewer names to existing
3254         git commits
3255
3256         Reviewed by Sam Weinig.
3257
3258         * Scripts/git-add-reviewer: Added.
3259         (top level): Parse options, check that the working tree is clean, then run in either
3260         interactive or non-interactive mode as appropriate.
3261         (interactive): Write out a temp file that contains each commit with "NOBODY" next to it and
3262         open it in the user's editor. The user can replace "NOBODY" with reviewer names. When the
3263         editor exits, we check out the commit just before the earliest one we're modifying. Then
3264         for each commit, we check it out, update the reviewer, and amend the commit to contain the
3265         new reviewer. Finally, we update the branch that was originally checked out to point to the
3266         last amended commit.
3267         (nonInteractive): Check out the commit to modify, write the current commit message to the
3268         MERGE_MSG file so addReviewer will update it, add the reviewer to the ChangeLog(s), amend
3269         the commit, and rebase the original branch on top of the amended commit. (usage): Print out
3270         a usage message and exit.
3271         (requireCleanWorkTree): Do the same steps git-rebase does to ensure that the working tree
3272         and index are clean.
3273         (fail): Print out the specified error message, if any, and return false. This function is
3274         used as a return value in various error cases throughout the script.
3275         (cherryPick): Cherry-pick the specified commit and return 1 if we succeeded.
3276         (addReviewer): Add the specified reviewer to all the ChangeLogs modified in this commit, and
3277         to .git/MERGE_MSG, which will be used as the commit message for the next commit.
3278         (commit): Call git-commit and use .git/MERGE_MSG as the commit message.
3279
3280         (addReviewerToChangeLog):
3281         (addReviewerToCommitMessage):
3282         These just call through to addReviewerToFile.
3283
3284         (addReviewerToFile): Read in the file, replacing any "NOBODY" text with the reviewer name(s)
3285         and replacing "Reviewed" with "Rubber-stamped" if specified. Write the resulting text to a
3286         temp file, then move the temp file over the original file and stage it for the next commit.
3287         (head): Returns the name of the currently-checked-out branch.
3288         (isAncestor): Returns true if the first commit is an ancestor of the second.
3289         (toCommit): Converts a commitish to a commit ID using git-rev-parse.
3290         (changeLogsForCommit): Returns a list of all the ChangeLogs modified in the given commit.
3291         (resetToCommit): Checks out the given commit, throwing away any local changes.
3292         (writeCommitMessageToFile): Gets the commit message for the current commit and writes it to
3293         the specified file.
3294         (rebaseOntoHead): Rebases the specified branch onto HEAD.
3295         (checkout): Checks out the given commit.
3296         (getConfigValue): Reads the specified config variable from git-config.
3297
3298 2011-11-02  Dean Jackson  <dino@apple.com>
3299
3300         Add ENABLE_CSS_SHADERS flag
3301         https://bugs.webkit.org/show_bug.cgi?id=71394
3302
3303         Reviewed by Sam Weinig.
3304
3305         * Scripts/build-webkit:
3306
3307 2011-10-31  Eric Seidel  <eric@webkit.org>
3308
3309         BaselineOptimizer tests should use mocks instead of real Executive/FileSystem objects
3310         https://bugs.webkit.org/show_bug.cgi?id=71237
3311
3312         Reviewed by Adam Barth.
3313
3314         Calling the static version of factory.get() with proper mocking
3315         requires passsing an explict filesystem, executive, etc.
3316         So instead, we use a PortFactory instance and pass it a Host pointer.
3317         I had to add a MockHost since we'd not needed a non-host tool before now.
3318
3319         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
3320         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3321         * Scripts/webkitpy/tool/commands/rebaseline.py:
3322         * Scripts/webkitpy/tool/mocktool.py:
3323
3324 2011-11-02  Anders Carlsson  <andersca@apple.com>
3325
3326         Update for the WebKit2 API fixage.
3327
3328         * MiniBrowser/mac/BrowserWindowController.m:
3329         (-[BrowserWindowController awakeFromNib]):
3330         * WebKitTestRunner/TestController.cpp:
3331         (WTR::TestController::initialize):
3332
3333 2011-11-02  Anders Carlsson  <andersca@apple.com>
3334
3335         Fix build.
3336
3337         Add new functions to the page loader client.
3338
3339         * MiniBrowser/mac/BrowserWindowController.m:
3340         (-[BrowserWindowController awakeFromNib]):
3341         * WebKitTestRunner/TestController.cpp:
3342         (WTR::TestController::initialize):
3343
3344 2011-11-02  Dan Bernstein  <mitz@apple.com>
3345
3346         <rdar://problem/10336700> Add API to get rendered text image without having to select it
3347         https://bugs.webkit.org/show_bug.cgi?id=71407
3348
3349         Reviewed by Simon Fraser.
3350
3351         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3352         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm: Added.
3353         (-[RenderedImageFromDOMRangeFrameLoadDelegate webView:didFinishLoadForFrame:]):
3354         (TestWebKitAPI::TEST):
3355
3356 2011-11-02  Benjamin Poulain  <benjamin@webkit.org>
3357
3358         Make the main frame's base path more explicit in _drt_descriptionSuitableForTestResult
3359         https://bugs.webkit.org/show_bug.cgi?id=71351
3360
3361         Reviewed by Darin Adler.
3362
3363         Add the delimiter "/" at the end of the path instead of adding +1 when using
3364         the path.
3365
3366         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3367         (-[NSURL _drt_descriptionSuitableForTestResult]):
3368
3369 2011-11-02  Tom Sepez  <tsepez@chromium.org>
3370
3371         XSSAuditor is silent
3372         https://bugs.webkit.org/show_bug.cgi?id=70973
3373
3374         Reviewed by Adam Barth.
3375
3376         * DumpRenderTree/chromium/WebViewHost.cpp:
3377         (WebViewHost::didDetectXSS):
3378         * DumpRenderTree/chromium/WebViewHost.h:
3379         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3380         (-[FrameLoadDelegate webView:didDetectXSS:]):
3381         * MiniBrowser/mac/BrowserWindowController.m:
3382         (didDetectXSSForFrame):
3383         (-[BrowserWindowController awakeFromNib]):
3384         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3385         (WTR::InjectedBundlePage::InjectedBundlePage):
3386         (WTR::InjectedBundlePage::didDetectXSSForFrame):
3387         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3388
3389 2011-11-02  Simon Hausmann  <simon.hausmann@nokia.com>
3390
3391         [Qt] REGRESSION: 5 editing tests fail
3392         https://bugs.webkit.org/show_bug.cgi?id=71117
3393
3394         Reviewed by Andreas Kling.
3395
3396         Make sure that the view is properly focused, in order to get the
3397         didBeginEditing DRT calls.
3398
3399         This requires activating the window (the call will result in a FocusIn
3400         event to the window as well as setting QGuiApplication::focusWindow())
3401         as well as enabling the focus on the view item. The signature of
3402         setFocus has changed to take a boolean.
3403
3404         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3405         (WTR::WrapperWindow::handleStatusChanged):
3406
3407 2011-11-02  Matt Falkenhagen  <falken@chromium.org>
3408
3409         [chromium] Add per-script font preferences support in overridePreference
3410         https://bugs.webkit.org/show_bug.cgi?id=71110
3411
3412         This allows a layout test to do something like:
3413
3414         // Set standard font for Arabic to Ahem.
3415         overridePreference("WebKitStandardFontMap", [ "Arab", "Ahem" ]);
3416
3417         This should make writing a layout test for per-script fonts easier.
3418
3419         This change only affects the Chromium DumpRenderTree, but the other
3420         platforms should probably also have a similar change eventually.
3421
3422         Reviewed by Tony Chang.
3423
3424         * DumpRenderTree/chromium/LayoutTestController.cpp: add per-script
3425         font preferences to overridePreference
3426         (LayoutTestController::cppVariantToWebStringArray):
3427         (setFontMap):
3428         (LayoutTestController::overridePreference):
3429         * DumpRenderTree/chromium/LayoutTestController.h:
3430         * DumpRenderTree/chromium/WebPreferences.cpp:
3431         (setStandardFontFamilyWrapper):
3432         (setFixedFontFamilyWrapper):
3433         (setSerifFontFamilyWrapper):
3434         (setSansSerifFontFamilyWrapper):
3435         (setCursiveFontFamilyWrapper):
3436         (setFantasyFontFamilyWrapper):
3437         (applyFontMap):
3438         (WebPreferences::applyTo):
3439         * DumpRenderTree/chromium/WebPreferences.h: add per-script font
3440         preference members
3441         (WebPreferences::UScriptCodeHashTraits::emptyValue):
3442         (WebPreferences::UScriptCodeHashTraits::constructDeletedValue):
3443         (WebPreferences::UScriptCodeHashTraits::isDeletedValue):
3444
3445 2011-11-02  Elliot Poger  <epoger@google.com>
3446
3447         until use_skia=1 by default on mac, default port should be chromium-cg-mac
3448         https://bugs.webkit.org/show_bug.cgi?id=71312
3449
3450         Reviewed by Adam Barth.
3451
3452         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3453         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3454         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3455
3456 2011-11-02  Stephen Chenney  <schenney@chromium.org>
3457
3458         printing layout test failures after r98634
3459         https://bugs.webkit.org/show_bug.cgi?id=71080
3460
3461         Reviewed by Kent Tamura
3462
3463         * DumpRenderTree/chromium/WebViewHost.cpp:
3464         (WebViewHost::paintPagesWithBoundaries): Added transforms invert the CG Bitmap so the coord system
3465         matches that for Skia.
3466
3467 2011-11-01  Sam Weinig  <sam@webkit.org>
3468
3469         Can't complete ChangeLog when using resolve-Changelogs and webkit-tools-completion.sh
3470         https://bugs.webkit.org/show_bug.cgi?id=71346
3471
3472         Reviewed by Dan Bernstein.
3473
3474         * Scripts/webkit-tools-completion.sh:
3475         Add "-o default" which allows for completing files in addition to the word list.
3476
3477 2011-11-02  Simon Hausmann  <simon.hausmann@nokia.com>
3478
3479         [Qt][WK2] Add support for touch event testing to WebKitTestRunner
3480         https://bugs.webkit.org/show_bug.cgi?id=71310
3481
3482         Reviewed by Kenneth Rohde Christiansen.
3483
3484         * WebKitTestRunner/DerivedSources.pro: Build system foo to ensure the ENABLE_TOUCH_EVENTS
3485         define works in EventSendingController.idl
3486         * WebKitTestRunner/EventSenderProxy.h: Add declarations for Qt implementations of touch
3487         handlers.
3488         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Add touch functions
3489         required by tests.
3490         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: Forward touch messages to the
3491         ui process.
3492         (WTR::EventSendingController::addTouchPoint):
3493         (WTR::EventSendingController::updateTouchPoint):
3494         (WTR::EventSendingController::setTouchModifier):
3495         (WTR::EventSendingController::touchStart):
3496         (WTR::EventSendingController::touchMove):
3497         (WTR::EventSendingController::touchEnd):
3498         (WTR::EventSendingController::clearTouchPoints):
3499         (WTR::EventSendingController::releaseTouchPoint):
3500         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3501         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Include features.pri for feature
3502         defines.
3503         * WebKitTestRunner/TestController.cpp:
3504         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Forward incoming
3505         touch messages to the EventSenderProxy.
3506         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Implement touch test harness functions.
3507         (WTR::EventSenderProxy::EventSenderProxy):
3508         (WTR::EventSenderProxy::addTouchPoint):
3509         (WTR::EventSenderProxy::updateTouchPoint):
3510         (WTR::EventSenderProxy::setTouchModifier):
3511         (WTR::EventSenderProxy::touchStart):
3512         (WTR::EventSenderProxy::touchMove):
3513         (WTR::EventSenderProxy::touchEnd):
3514         (WTR::EventSenderProxy::clearTouchPoints):
3515         (WTR::EventSenderProxy::releaseTouchPoint):
3516         (WTR::EventSenderProxy::sendTouchEvent):
3517         * WebKitTestRunner/qt/WebKitTestRunner.pro: Include features.pri for feature defines.
3518
3519 2011-11-01  Sam Weinig  <sam@webkit.org>
3520
3521         resolve-ChangeLogs --help should be faster.
3522
3523         Reviewed by Adam Roben.
3524
3525         * Scripts/resolve-ChangeLogs:
3526         (usageAndExit):
3527         Add a call to usageAndExit() before doing work to find unmerged changelogs
3528         if --help or something illegal is provided on the command line.
3529
3530 2011-11-01  Benjamin Poulain  <bpoulain@apple.com>
3531
3532         [Mac] _drt_descriptionSuitableForTestResult generate an exception for absolute paths above the main frame
3533         https://bugs.webkit.org/show_bug.cgi?id=71342
3534
3535         Reviewed by Darin Adler.
3536
3537         [NSURL _drt_descriptionSuitableForTestResult] was generating a NSRangeException due to the call to
3538         [NSString substringFromIndex:] with an index out of the string range.
3539
3540         The source of this path is the test-loading-archive-subresource-null-mimetype.html which load a subresource
3541         from the root of the disk.
3542         The problem was hidden because the exception are catched when calling the delegate.
3543
3544         This patch changes _drt_descriptionSuitableForTestResult to return absolute string if the resource is not
3545         in a subdirectory of the main frame.
3546
3547         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3548         (-[NSURL _drt_descriptionSuitableForTestResult]):
3549
3550 2011-11-01  Alok Priyadarshi  <alokp@chromium.org>
3551
3552         [chromium] --enable-hardware-gpu flag is not recognized by run-webkit-tests
3553         https://bugs.webkit.org/show_bug.cgi?id=71318
3554
3555         Reviewed by James Robinson.
3556         
3557         Fixed a typo for --enable-hardware-gpu flag.
3558
3559         * Scripts/webkitpy/layout_tests/port/chromium.py:
3560
3561 2011-11-01  Elliot Poger  <epoger@google.com>
3562
3563         chromium-gpu port should default to chromium-gpu-mac, not chromium-gpu-cg-mac
3564         https://bugs.webkit.org/show_bug.cgi?id=71286
3565
3566         Reviewed by Stephen White.
3567
3568         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3569
3570 2011-11-01  Simon Hausmann  <simon.hausmann@nokia.com>
3571
3572         [Qt][WK2] Fix build of WebKitTestRunner with ELF symbol visibility
3573         https://bugs.webkit.org/show_bug.cgi?id=71299
3574
3575         Reviewed by Andreas Kling.
3576
3577         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Use the properly exported symbol for the Qt
3578         build to enable WebCoreTestSupport::injectInternalsObject.
3579         (WTR::InjectedBundlePage::didClearWindowForFrame):
3580         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Fix include path to DRTSupportQt
3581
3582 2011-11-01  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3583
3584         [Qt] Merge common desktop and touch view APIs under a base class.
3585         https://bugs.webkit.org/show_bug.cgi?id=71280
3586
3587         Reviewed by Andreas Kling.
3588
3589         Remove unneded forwarding logic for TouchWebView since those properties are
3590         now in the view just as the desktop web view.
3591
3592         * MiniBrowser/qt/qml/TouchView.qml:
3593
3594 2011-11-01  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3595
3596         check-webkit-style: Allow names starting with "_q_".
3597         https://bugs.webkit.org/show_bug.cgi?id=70625
3598
3599         Reviewed by Tor Arne Vestbø.
3600
3601         Used by the Qt port as the standard prefix for private slots.
3602
3603         * Scripts/webkitpy/style/checkers/cpp.py:
3604         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3605
3606 2011-11-01  Simon Hausmann  <simon.hausmann@nokia.com>
3607
3608         [Qt][WK2] Fix valgrind error about uninitialized variable
3609         https://bugs.webkit.org/show_bug.cgi?id=71273
3610
3611         Reviewed by Kenneth Christiansen.
3612
3613         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3614         (MiniBrowserApplication::notify): Initialize isPrimary.
3615
3616 2011-10-31  Adam Roben  <aroben@apple.com>
3617
3618         Make Leaks Viewer less strict when parsing leaks-related output from NRWT/ORWT
3619
3620         Fixes <http://webkit.org/b/71258> REGRESSION (r98639): Leaks Viewer doesn't show recent
3621         leaky builds
3622
3623         Reviewed by Anders Carlsson.
3624
3625         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
3626         (RecentBuildsLoader.prototype.start): Relax a regex to gloss over differences in ORWT's vs.
3627         NRWT's leaks-related output (i.e., "M total leaks found!" vs. "M total leaks found for a
3628         total of N bytes!").
3629
3630 2011-10-31  Raphael Kubo da Costa  <kubo@profusion.mobi>
3631
3632         [EFL] Rename ewk_view_setting_scripts_window_open_{get,set} after r93833
3633         https://bugs.webkit.org/show_bug.cgi?id=71228
3634
3635         Reviewed by Antonio Gomes.
3636
3637         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3638         (DumpRenderTreeChrome::createNewWindow):
3639         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3640
3641 2011-10-31  Eric Seidel  <eric@webkit.org>
3642
3643         webkitpy tests depend too much on the user's environment
3644         https://bugs.webkit.org/show_bug.cgi?id=71234
3645
3646         Reviewed by Dirk Pranke.
3647
3648         This change just makes a bunch of our older tests use
3649         more modern mocking to avoid trying to launch processes
3650         or read from the user's filesystem during unittesting.
3651
3652         I found many of these by adding an assert in Executive.run_command
3653         that we were not unittesting.  I can't add that assert always
3654         as there are some valid uses of Executive during unittesting.
3655         Once I fix more of these, I may find a way to add such an assert conditionally.
3656
3657         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
3658         * Scripts/webkitpy/common/net/credentials_unittest.py:
3659         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3660         * Scripts/webkitpy/layout_tests/port/base.py:
3661         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3662
3663 2011-10-31  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3664
3665         [Qt] MiniBrowser doesn't resize as the size is always overridden
3666         https://bugs.webkit.org/show_bug.cgi?id=71212
3667
3668         Reviewed by Simon Hausmann.
3669
3670         Remove call overriden the size.
3671
3672         * MiniBrowser/qt/main.cpp:
3673         (main):
3674
3675 2011-10-30  Sheriff Bot  <webkit.review.bot@gmail.com>
3676
3677         Unreviewed, rolling out r98819, r98823, r98825, and r98830.
3678         http://trac.webkit.org/changeset/98819
3679         http://trac.webkit.org/changeset/98823
3680         http://trac.webkit.org/changeset/98825
3681         http://trac.webkit.org/changeset/98830
3682         https://bugs.webkit.org/show_bug.cgi?id=71199
3683
3684         Broke Chromium Windows bot (Requested by rniwa on #webkit).
3685
3686         * Scripts/webkitpy/layout_tests/port/base.py:
3687         * Scripts/webkitpy/layout_tests/port/chromium.py:
3688         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3689         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3690         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3691         * Scripts/webkitpy/layout_tests/port/efl.py:
3692         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3693         * Scripts/webkitpy/layout_tests/port/mac.py:
3694         * Scripts/webkitpy/layout_tests/port/qt.py:
3695         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3696         * Scripts/webkitpy/layout_tests/port/webkit.py:
3697         * Scripts/webkitpy/layout_tests/port/win.py:
3698
3699 2011-10-30  Eric Seidel  <eric@webkit.org>
3700
3701         new-run-webkit-tests is locale dependent
3702         https://bugs.webkit.org/show_bug.cgi?id=68691
3703
3704         Unreviewed.
3705
3706         This is a temporary hack until someone from the cr-win port
3707         can take a look and determine which environment variable
3708         lighttpd is missing.
3709
3710         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3711
3712 2011-10-30  Eric Seidel  <eric@webkit.org>
3713
3714         new-run-webkit-tests is locale dependent
3715         https://bugs.webkit.org/show_bug.cgi?id=68691
3716
3717         Unreviewed.  I would have preferred to have this reviewed,
3718         but relevant reviewers are asleep and bots are broken.
3719
3720         This was a regression from moving to a clean environment.
3721         ChromiumWin (and possibly other ports), need the "PATH"
3722         environment copied over.  This wasn't caught in my testing
3723         because although we had unittests to cover this, they
3724         weren't being run on anything but windows.  The vast majority
3725         of this change is just fixing the unittests to use our
3726         modern MockFileSystem/MockUser/MockExecutive so they can
3727         be run on any system (and removing the platform checks from
3728         the unittests so they are run everywhere).
3729
3730         The actual fix is the single line "PATH" string added to base.py.
3731         The rest of this change is just fixing the Chromium port unittests
3732         to run on all systems (including changing the Chromium port to
3733         use FileSystem.path_to_module instead of __file__).
3734
3735         * Scripts/webkitpy/layout_tests/port/base.py:
3736         * Scripts/webkitpy/layout_tests/port/chromium.py:
3737         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3738         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3739         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3740         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3741
3742 2011-10-29  Eric Seidel  <eric@webkit.org>
3743
3744         new-run-webkit-tests is locale dependent
3745         https://bugs.webkit.org/show_bug.cgi?id=68691
3746
3747         Unreviewed.
3748
3749         Fix the Qt port and unittest the function so we don't break it again.
3750
3751         * Scripts/webkitpy/layout_tests/port/qt.py:
3752         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3753
3754 2011-10-29  Eric Seidel  <eric@webkit.org>
3755
3756         new-run-webkit-tests is locale dependent
3757         https://bugs.webkit.org/show_bug.cgi?id=68691
3758
3759         Reviewed by Adam Barth.
3760
3761         Make NRWT use a clean environment just like ORWT did.
3762         I've manually validated that NRWT now copies over
3763         the same environment variables that ORWT did.
3764         This new code is exercised by existing setup_environ_for_server tests.
3765
3766         * Scripts/webkitpy/layout_tests/port/base.py:
3767         * Scripts/webkitpy/layout_tests/port/efl.py:
3768         * Scripts/webkitpy/layout_tests/port/mac.py:
3769         * Scripts/webkitpy/layout_tests/port/qt.py:
3770         * Scripts/webkitpy/layout_tests/port/webkit.py:
3771         * Scripts/webkitpy/layout_tests/port/win.py:
3772
3773 2011-10-29  Eric Seidel  <eric@webkit.org>
3774
3775         new-run-webkit-tests: MASTER BUG: Switch all webkit.org bots over
3776         https://bugs.webkit.org/show_bug.cgi?id=34984
3777
3778         Reviewed by Adam Barth.
3779
3780         Move run-webkit-tests from using a white-list of supported NRWT ports
3781         to a blacklist of ports requiring ORWT.
3782
3783         I've also added the ability to opt-in to parallel testing on a per-port basis.
3784
3785         With these changes I'm going to officially declare this bug dead and
3786         work on remaining polish issues and individual developer complaints.
3787
3788         * Scripts/run-webkit-tests:
3789         (useNewRunWebKitTests):
3790         (platformIsReadyForParallelTesting):
3791
3792 2011-10-29  Sheriff Bot  <webkit.review.bot@gmail.com>
3793
3794         Unreviewed, rolling out r98780.
3795         http://trac.webkit.org/changeset/98780
3796         https://bugs.webkit.org/show_bug.cgi?id=71173
3797
3798         Broke Qt bots (Requested by rniwa on #webkit).
3799
3800         * Scripts/run-webkit-tests:
3801         (useNewRunWebKitTests):
3802
3803 2011-10-28  Rafael Weinstein  <rafaelw@chromium.org>
3804
3805         webkit.py gdb visualizer is broken after change to StringImpl
3806         https://bugs.webkit.org/show_bug.cgi?id=71154
3807
3808         Reviewed by Tony Chang.
3809
3810         r98624 changed StringImpl m_data to m_data32. This changes updates
3811         webkit.py to match.
3812
3813         * gdb/webkit.py:
3814
3815 2011-10-28  Joseph Pecoraro  <pecoraro@apple.com>
3816
3817         Fix typo in check-for-inappropriate-objc-class-names
3818         https://bugs.webkit.org/show_bug.cgi?id=71144
3819
3820         Reviewed by Dan Bernstein.
3821
3822         * Scripts/check-for-inappropriate-objc-class-names:
3823
3824 2011-10-28  Sadrul Habib Chowdhury  <sadrul@chromium.org>
3825
3826         Add support for sending scroll-update events from EventSender.
3827         https://bugs.webkit.org/show_bug.cgi?id=66272
3828
3829         Reviewed by Adam Barth.
3830
3831         * DumpRenderTree/chromium/EventSender.cpp:
3832         (EventSender::EventSender):
3833         (EventSender::reset):
3834         (EventSender::gestureScrollUpdate):
3835         (EventSender::gestureEvent):
3836         * DumpRenderTree/chromium/EventSender.h:
3837
3838 2011-10-28  Eric Seidel  <eric@webkit.org>
3839
3840         new-run-webkit-tests: MASTER BUG: Switch all webkit.org bots over
3841         https://bugs.webkit.org/show_bug.cgi?id=34984
3842
3843         Reviewed by Adam Barth.
3844
3845         Move run-webkit-tests from using a white-list of supported NRWT ports
3846         to a blacklist of ports requiring ORWT.
3847
3848         I've also added the ability to opt-in to parallel testing on a per-port basis.
3849
3850         With these changes I'm going to officially declare this bug dead and
3851         work on remaining polish issues and individual developer complaints.
3852
3853         * Scripts/run-webkit-tests:
3854         (useNewRunWebKitTests):
3855         (platformIsReadyForParallelTesting):
3856
3857 2011-10-28  Eric Seidel  <eric@webkit.org>
3858
3859         NRWT crashes when parsing leaks output due to UTF-8 decoding error
3860         https://bugs.webkit.org/show_bug.cgi?id=71112
3861
3862         Reviewed by Adam Barth.
3863
3864         Use read_binary_file instead of read_text_file and add a test
3865         case with some non-utf8 data to make sure we don't break this in the future.
3866
3867         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
3868         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
3869
3870 2011-10-28  David Levin  <levin@chromium.org>
3871
3872         watchlist should not CC the bug reporter
3873         https://bugs.webkit.org/show_bug.cgi?id=71079
3874
3875         Reviewed by Adam Barth.
3876
3877         Tested by test_apply_watch_list_local (webkitpy.tool.steps.applywatchlist_unittest.ApplyWatchListTest)
3878         which remains upchanged and thus verifies that the reporter doesn't get added to the cc line.
3879
3880         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Add the new email in the output.
3881         * Scripts/webkitpy/tool/mocktool.py: Change the reporter and make them one of the people to cc.
3882         * Scripts/webkitpy/tool/steps/applywatchlist.py: Remove the reporter from the cc list.
3883
3884 2011-10-28  Zoltan Horvath  <zoltan@webkit.org>
3885
3886         Add watchlist for QtWebKit2 API and for WK2's Qt specific files.
3887         https://bugs.webkit.org/show_bug.cgi?id=71116
3888
3889         Reviewed by David Levin.
3890
3891         * Scripts/webkitpy/common/config/watchlist:
3892
3893 2011-10-28  Simon Hausmann  <simon.hausmann@nokia.com>
3894
3895         [Qt] Adapt to QSG* to QQuick* API change in qtdeclarative
3896         https://bugs.webkit.org/show_bug.cgi?id=70494
3897
3898         Reviewed by Kenneth Christiansen.
3899
3900         Use QQuick* instead of QSG* as well as QStandardPaths
3901         instead of QDesktopLocation.
3902
3903         * MiniBrowser/qt/BrowserWindow.cpp:
3904         (BrowserWindow::BrowserWindow):
3905         * MiniBrowser/qt/BrowserWindow.h:
3906         * QtTestBrowser/cookiejar.cpp:
3907         (TestBrowserCookieJar::TestBrowserCookieJar):
3908         * QtTestBrowser/launcherwindow.cpp:
3909         (LauncherWindow::setDiskCache):
3910         * WebKitTestRunner/PlatformWebView.h:
3911         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3912         (WTR::WrapperWindow::WrapperWindow):
3913         (WTR::WrapperWindow::handleStatusChanged):
3914
3915 2011-10-28  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3916
3917         [Qt] Fix the Ctrl behavior for touch mocking in MiniBrowser.
3918         https://bugs.webkit.org/show_bug.cgi?id=71106
3919
3920         Reviewed by Simon Hausmann.
3921
3922         Holding Ctrl allows multiple touch points to be held on the screen using
3923         mouse buttons. It would previously only prevent TouchReleased to be sent
3924         and would require another MouseButtonRelease to be sent without holding Ctrl.
3925
3926         This patch makes sure that all held touch points are released when Ctrl
3927         is released if MouseButtonRelease was received.
3928         It also removes the touch QEvent::Type logic since it's currently handled
3929         by QtGui by observing the modified touch points.
3930
3931         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3932         (MiniBrowserApplication::notify):
3933         (MiniBrowserApplication::sendTouchEvent):
3934         * MiniBrowser/qt/MiniBrowserApplication.h:
3935
3936 2011-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3937
3938         [Qt] MiniBrowser needs a -window-size option
3939         https://bugs.webkit.org/show_bug.cgi?id=70999
3940
3941         Reviewed by Simon Hausmann.
3942
3943         Add an -window-size option useful for testing the viewport handling.
3944         Also clean up the option handling.
3945
3946         * MiniBrowser/qt/BrowserWindow.cpp:
3947         (BrowserWindow::BrowserWindow):
3948         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3949         (MiniBrowserApplication::handleUserOptions):
3950         * MiniBrowser/qt/MiniBrowserApplication.h:
3951         (WindowOptions::WindowOptions):
3952         (WindowOptions::setRequestedWindowSize):
3953         (WindowOptions::requestedWindowSize):
3954         * MiniBrowser/qt/utils.cpp:
3955         (takeOptionValue):
3956         * MiniBrowser/qt/utils.h:
3957
3958 2011-10-28  Jochen Eisinger  <jochen@chromium.org>
3959
3960         Add allowScriptFromSource callback to FrameLoaderClient
3961         https://bugs.webkit.org/show_bug.cgi?id=71013
3962
3963         Reviewed by Darin Fisher.
3964
3965         * DumpRenderTree/chromium/LayoutTestController.cpp:
3966         (LayoutTestController::LayoutTestController):
3967         (LayoutTestController::setScriptsAllowed):
3968         * DumpRenderTree/chromium/LayoutTestController.h:
3969         * DumpRenderTree/chromium/WebPermissions.cpp:
3970         (WebPermissions::allowScriptFromSource):
3971         (WebPermissions::setScriptsAllowed):
3972         (WebPermissions::reset):
3973         * DumpRenderTree/chromium/WebPermissions.h:
3974
3975 2011-10-28  Alexandru Chiculita  <achicu@adobe.com>
3976
3977         Added myself as a committer.
3978
3979         * Scripts/webkitpy/common/config/committers.py:
3980
3981 2011-10-27  Adam Barth  <abarth@webkit.org>
3982
3983         Remove WinCairo from the set of core builders.  WinCairo rarely builds
3984         and is never green.
3985
3986         Rubber-stamped by Eric Seidel.
3987
3988         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3989         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3990
3991 2011-10-27  Yuta Kitamura  <yutak@chromium.org>
3992
3993         WebSocket: Connecting to localhost:8880 takes one second on Windows
3994         https://bugs.webkit.org/show_bug.cgi?id=64788
3995
3996         Reviewed by Dirk Pranke.
3997
3998         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
3999         Bind to "localhost" instead of "127.0.0.1" to let pywebsocket listen on both
4000         IPv4 and IPv6 addresses. This should prevent the test reserved-opcodes.html
4001         from timing out on Windows, because this test tries to open a lot of
4002         connections to localhost and each attempt takes one second to fall back from
4003         IPv6 to IPv4 on Windows (I have no idea why Windows works like this, though).
4004
4005 2011-10-27  Adam Barth  <abarth@webkit.org>
4006
4007         Dis-integrate run-bindings-tests with webkitpy
4008         https://bugs.webkit.org/show_bug.cgi?id=71092
4009
4010         Reviewed by Ryosuke Niwa.
4011
4012         These tests aren't really adding any value.
4013
4014         * Scripts/webkitpy/common/config/ports.py:
4015         * Scripts/webkitpy/tool/commands/download_unittest.py:
4016         * Scripts/webkitpy/tool/mocktool.py:
4017         * Scripts/webkitpy/tool/steps/runtests.py:
4018         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
4019         * Scripts/webkitpy/tool/steps/steps_unittest.py:
4020
4021 2011-10-27  Eric Seidel  <eric@webkit.org>
4022
4023         REGRESSION (r98639): NRWT crashes when parsing leaks output
4024         https://bugs.webkit.org/show_bug.cgi?id=71087
4025
4026         Unreviewed.  Sadly we have no good way to test logging.
4027
4028         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
4029
4030 2011-10-27  David Levin  <levin@chromium.org>
4031
4032         Test expectation errors should include the file name and platform in both the log and exception info.
4033         https://bugs.webkit.org/show_bug.cgi?id=71067
4034
4035         Reviewed by Ojan Vafai.
4036
4037         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
4038         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
4039
4040 2011-10-27  Eric Seidel  <eric@webkit.org>
4041
4042         new-run-webkit-tests doesn't understand --qt or --gtk
4043         https://bugs.webkit.org/show_bug.cgi?id=63970
4044
4045         Reviewed by Ojan Vafai.
4046
4047         Add support for --qt and --gtk to NRWT.
4048         I also removed some incorrect comments in the option parsing
4049         code (options which we already implement, but said we didn't)
4050         as well as moved --platform parsing out of the "results_options"
4051         section into the top configuration section.
4052
4053         Now run-webkit-tests no longer needs NRWT-specific code for passing
4054         --platform=qt, etc.
4055
4056         * Scripts/run-webkit-tests:
4057         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4058
4059 2011-10-27  Eric Seidel  <eric@webkit.org>
4060
4061         REGRESSION (NRWT): build.webkit.org doesn't show the total number of leaks found during a test run on the Leaks bot
4062         https://bugs.webkit.org/show_bug.cgi?id=66227
4063
4064         Reviewed by Adam Roben.
4065
4066         I believe this should fix the bug.
4067
4068         * Scripts/run-webkit-tests: make NRWT default for --leaks
4069         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
4070         (LeakDetector._parse_leaks_output): removed the (unneeded) process_pid argument, and made the regexp use named groups (even though we don't ever grab them by name)
4071         (LeakDetector.count_total_bytes_and_unique_leaks): renamed from parse_leak_files
4072         (LeakDetector.count_total_leaks): new file (the guts of this change) which is used to re-parse the leaks output during the summarize leaks phase.
4073         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
4074         Changes to reflect the rename of count_total_bytes_and_unique_leaks and a new test for count_total_leaks.
4075         * Scripts/webkitpy/layout_tests/port/mac.py:
4076         Use count_total_leaks to spit out the total leak count like ORWT did, and remove the FIXME on the subject.
4077
4078 2011-10-27  Stephen Chenney  <schenney@chromium.org>
4079
4080         [Chromium] Need setPrinting
4081         https://bugs.webkit.org/show_bug.cgi?id=46152
4082
4083         Reviewed by Hajime Morita.
4084
4085         * DumpRenderTree/chromium/LayoutTestController.cpp:
4086         (LayoutTestController::LayoutTestController): Added logic for handling setPrinting.
4087         (LayoutTestController::reset): Clearing flags for setPrinting.
4088         (LayoutTestController::setPrinting): Set flags for setPrinting.
4089         * DumpRenderTree/chromium/LayoutTestController.h:
4090         (LayoutTestController::setIsPrinting): Added the setPrinting methods and flags.
4091         (LayoutTestController::isPrinting): Method to return the setPrinting status.
4092         * DumpRenderTree/chromium/TestShell.cpp:
4093         (dumpFramesAsPrintedText): A method for creating a text dump in printed layout.
4094         (TestShell::dump): Modified to dump setPrinting-specific output.
4095         * DumpRenderTree/chromium/WebViewHost.cpp:
4096         (WebViewHost::paintPagesWithBoundaries): Handling for pixel tests when setPrinting is
4097         active.
4098         * DumpRenderTree/chromium/WebViewHost.h: Prototype for paintPagesWithBoundaries.
4099
4100 2011-10-27  Sam Weinig  <sam@webkit.org>
4101
4102         Add allowsPlugIns property to WKBrowsingContextGroup
4103         https://bugs.webkit.org/show_bug.cgi?id=70987
4104
4105         Reviewed by Anders Carlsson.
4106
4107         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
4108         Add basic test for WKBrowsingContextGroup.allowsPlugIns. 
4109
4110 2011-10-27  Adam Roben  <aroben@apple.com>
4111
4112         Test WKBundlePageGetBackingScaleFactor
4113
4114         Test for <http://webkit.org/b/71025> <rdar://problem/10355037> REGRESSION (r97191): Clients
4115         can't reliably determine the scale factor of snapshots returned via
4116         WKBundlePageCreateSnapshot* API
4117
4118         Reviewed by Sam Weinig.
4119
4120         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
4121
4122         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm: Added.
4123         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Record the passed-back scale factor.
4124         (TestWebKitAPI::setInjectedBundleClient): Hook up our didReceiveMessage callback.
4125         (TestWebKitAPI::createWindow): Conjure up a window.
4126         (TestWebKitAPI::TEST): Ask the injected bundle code to call the new
4127         WKBundlePageGetBackingScaleFactor API when the WKView is in windows with various scale
4128         factors and when using a custom scale factor, and check that we get those same scale factors
4129         back.
4130
4131         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm: Added.
4132         (TestWebKitAPI::GetBackingScaleFactorTest::GetBackingScaleFactorTest): Just initialize our
4133         members.
4134         (TestWebKitAPI::GetBackingScaleFactorTest::didCreatePage): Store the page for later.
4135         (TestWebKitAPI::GetBackingScaleFactorTest::didReceiveMessage): Get the backing scale factor
4136         from the page using the new API and send it back.
4137
4138 2011-10-27  Balazs Kelemen  <kbalazs@webkit.org>
4139
4140         [Qt][WK2] MiniBrowser crashes when started with 0 arguments
4141
4142         Rubber-stamped by Simon Hausmann.
4143
4144         * MiniBrowser/qt/MiniBrowserApplication.cpp:
4145         (MiniBrowserApplication::handleUserOptions):
4146         Fix typo error.
4147
4148 2011-10-27  Takashi Toyoshima  <toyoshim@chromium.org>
4149
4150         [WebSocket] update pywebsocket to 0.7.
4151         https://bugs.webkit.org/show_bug.cgi?id=70992
4152
4153         Reviewed by Kent Tamura.
4154
4155         pywebsocket 0.7 fixed the bug on dual stack support on OS X.
4156
4157         * Scripts/webkitpy/thirdparty/__init__.py:
4158
4159 2011-10-27  Elliot Poger  <epoger@google.com>
4160
4161         make lion observe MAC lines in test_expectations.txt
4162         https://bugs.webkit.org/show_bug.cgi?id=70941
4163
4164         Reviewed by Ojan Vafai.
4165
4166         * Scripts/webkitpy/layout_tests/port/chromium.py:
4167         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
4168
4169 2011-10-27  John Knottenbelt  <jknotten@chromium.org>
4170
4171         [Chromium] Allow DRT to be built without notifications enabled.
4172         https://bugs.webkit.org/show_bug.cgi?id=70919
4173
4174         Reviewed by Tony Gentilcore.
4175
4176         * DumpRenderTree/chromium/LayoutTestController.cpp:
4177         (LayoutTestController::grantDesktopNotificationPermission):
4178         (LayoutTestController::simulateDesktopNotificationClick):
4179         * DumpRenderTree/chromium/NotificationPresenter.cpp:
4180         * DumpRenderTree/chromium/TestShell.cpp:
4181         (TestShell::TestShell):
4182         (TestShell::resetTestController):
4183
4184 2011-10-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
4185
4186         [Qt] Improve command line arguments handling for MiniBrowser.
4187         https://bugs.webkit.org/show_bug.cgi?id=70616
4188
4189         Reviewed by Kenneth Rohde Christiansen.
4190
4191         - Use two dashes for word arguments.
4192         - Return with an error when an unsupported argument is given.
4193         - Allow the URL to be placed before option arguments.
4194
4195         * MiniBrowser/qt/MiniBrowserApplication.cpp:
4196         (printHelp):
4197         (MiniBrowserApplication::handleUserOptions):
4198         * MiniBrowser/qt/utils.cpp:
4199         (takeOptionFlag):
4200         (takeOptionValue):
4201         * MiniBrowser/qt/utils.h:
4202
4203 2011-10-27  Csaba Osztrogonác  <ossy@webkit.org>
4204
4205         [Qt] NRWT doesn't work on qt-mac platform
4206         https://bugs.webkit.org/show_bug.cgi?id=64445
4207
4208         Reviewed by Adam Barth.
4209
4210         * Scripts/run-webkit-tests: Switch qt-mac platform to NRWT.
4211         (useNewRunWebKitTests):
4212         * Scripts/webkitpy/layout_tests/port/qt.py: Fix library path on Mac.
4213
4214 2011-10-26  Sam Weinig  <sam@webkit.org>
4215
4216         Add initial setting to WKBrowsingContextGroup
4217         https://bugs.webkit.org/show_bug.cgi?id=70942
4218
4219         Reviewed by Anders Carlsson.
4220
4221         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4222         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm: Added.
4223         Add basic test that setting the javaScriptEnabled setting takes. It is not
4224         possible to test its effect quite yet.
4225
4226 2011-10-26  Alejandro G. Castro  <alex@igalia.com>
4227
4228         [GTK] [WK2] Add WebKit2 distcheck support
4229         https://bugs.webkit.org/show_bug.cgi?id=70933
4230
4231         Reviewed by Martin Robinson.
4232
4233         * WebKitTestRunner/GNUmakefile.am: Add missing files to the
4234         sources and EXTRA_DIST.
4235
4236 2011-10-26  Simon Hausmann  <simon.hausmann@nokia.com>
4237
4238         [Qt][WK2] Fix failing assertion on startup of MiniBrowser -touch.
4239
4240         Reviewed by Tor Arne Vestbø.
4241
4242         We're using QScroller since r98460, which requires QWidget/QApplication. So
4243         use QApplication and QtWidgets for the time being.
4244
4245         * MiniBrowser/qt/MiniBrowser.pro:
4246         * MiniBrowser/qt/MiniBrowserApplication.cpp:
4247         (MiniBrowserApplication::MiniBrowserApplication):
4248         (MiniBrowserApplication::notify):
4249         * MiniBrowser/qt/MiniBrowserApplication.h:
4250
4251 2011-10-25  Zeno Albisser  <zeno.albisser@nokia.com>
4252
4253         [Qt][WK2] Rewrite MiniBrowser in QML
4254         https://bugs.webkit.org/show_bug.cgi?id=70315
4255
4256         Add the first QML based implementation of MiniBrowser.
4257
4258         Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,
4259                  Zeno Albisser <zeno.albisser@nokia.com>
4260
4261         Reviewed by Tor Arne Vestbø.
4262
4263         * MiniBrowser/qt/BrowserWindow.cpp:
4264         (BrowserWindow::BrowserWindow):
4265         (BrowserWindow::webView):
4266         (BrowserWindow::load):
4267         (BrowserWindow::keyPressEvent):
4268         (BrowserWindow::~BrowserWindow):
4269         * MiniBrowser/qt/BrowserWindow.h:
4270         * MiniBrowser/qt/MiniBrowser.pro:
4271         * MiniBrowser/qt/MiniBrowser.qrc:
4272         * MiniBrowser/qt/MiniBrowserApplication.cpp:
4273         (MiniBrowserApplication::MiniBrowserApplication):
4274         (MiniBrowserApplication::handleUserOptions):