[Chromium] LayoutTests: css3/selector3/xml tests are flaky / have wrong expectations...
[WebKit-https.git] / Tools / ChangeLog
1 2012-08-23  Raphael Kubo da Costa  <rakuco@webkit.org>
2
3         [watchlist] Unreviewed, subscribe to WebKit2-EFL bugs.
4
5         * Scripts/webkitpy/common/config/watchlist:
6
7 2012-08-23  Ryosuke Niwa  <rniwa@webkit.org>
8
9         Replay tests take forever to load
10         https://bugs.webkit.org/show_bug.cgi?id=94764
11
12         Reviewed by Adam Barth.
13
14         Don't load about:blank at the beginning. This appears to clog the DRT.
15
16         * Scripts/webkitpy/performance_tests/perftest.py:
17         (ReplayPerfTest.run_single):
18         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
19         (TestReplayPerfTest.test_run_single):
20         (TestReplayPerfTest.test_run_single_fails_when_output_has_error):
21
22 2012-08-23  Kenneth Russell  <kbr@google.com>
23
24         Unreviewed, rolling out r126497.
25         http://trac.webkit.org/changeset/126497
26         https://bugs.webkit.org/show_bug.cgi?id=94764
27
28         Caused webkitpy-test step to start failing.
29
30         * Scripts/webkitpy/performance_tests/perftest.py:
31         (ReplayPerfTest.run_single):
32
33 2012-08-23  Emil A Eklund  <eae@chromium.org>
34
35         Add saturation arithmetic support to FractionalLayoutUnit
36         https://bugs.webkit.org/show_bug.cgi?id=94364
37
38         Reviewed by Benjamin Poulain.
39
40         Add test for new saturatedArithmetic functions.
41
42         * TestWebKitAPI/CMakeLists.txt:
43         * TestWebKitAPI/GNUmakefile.am:
44         * TestWebKitAPI/TestWebKitAPI.gypi:
45         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
46         * TestWebKitAPI/Tests/WTF/SaturatedArithmeticOperations.cpp: Added.
47         (TestWebKitAPI):
48         (TestWebKitAPI::TEST):
49         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
50
51 2012-08-23  Ryosuke Niwa  <rniwa@webkit.org>
52
53         Replay tests take forever to load
54         https://bugs.webkit.org/show_bug.cgi?id=94764
55
56         Reviewed by Adam Barth.
57
58         Don't load about:blank at the beginning. This appears to clog the DRT.
59
60         * Scripts/webkitpy/performance_tests/perftest.py:
61         (ReplayPerfTest.run_single):
62
63 2012-08-23  Wei Jia  <wjia@chromium.org>
64
65         create different WebKit::WebMediaPlayer based on URL
66         https://bugs.webkit.org/show_bug.cgi?id=91301
67
68         Reviewed by Adam Barth.
69
70         Pass URL to createMediaPlayer. This corresponds to change in base
71         class WebKit::WebFrameClient.
72
73         * DumpRenderTree/chromium/WebViewHost.cpp:
74         (WebViewHost::createMediaPlayer): add URL as additional argument.
75         * DumpRenderTree/chromium/WebViewHost.h:
76         (WebViewHost):
77
78 2012-08-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
79
80         Unreviewed, upgrade gyuyoung to reviewer.
81         http://lists.webkit.org/pipermail/webkit-dev/2012-August/022004.html
82
83         * Scripts/webkitpy/common/config/committers.py:
84
85 2012-08-23  Carlos Garcia Campos  <cgarcia@igalia.com>
86
87         REGRESSION(r126306): it broke the plugin process
88         https://bugs.webkit.org/show_bug.cgi?id=94797
89
90         Reviewed by Xan Lopez.
91
92         * GNUmakefile.am:
93
94 2012-08-23  Ryuan Choi  <ryuan.choi@samsung.com>
95
96         [EFL] Add url bar to EWebLauncher and MiniBrowser/Efl.
97         https://bugs.webkit.org/show_bug.cgi?id=63966
98
99         Reviewed by Kenneth Rohde Christiansen.
100
101         EWebLauncher and MiniBrowser/Efl did not have functionality that users
102         navigates the site which they want.
103         This patch adds the urlbar and functionality to load url which users want.
104
105         * CMakeLists.txt:
106         Added to share urlbar theme for both EWebLauncher and MiniBrowser/Efl.
107         * EWebLauncher/CMakeLists.txt:
108         Added urlbar.c and dependency of urlbar theme.
109         In addition, changed macro name to THEME_DIR to share the code easily.
110         * EWebLauncher/ControlTheme/CMakeLists.txt: Added for urlbar theme.
111         * EWebLauncher/ControlTheme/entry.edc: Implemented urlbar theme.
112         * EWebLauncher/main.c:
113         Implemented to use the urlbar.
114         In addition, remove unnecessary border of webview to control webview and urlbar easily.
115         (_ELauncher):
116         (on_url_changed):
117         (browserCreate):
118         (closeWindow):
119         (findThemePath):
120         * EWebLauncher/url_bar.c: Implemented functionality of the urlbar.
121         (_url_bar_url_get_with_protocol):
122         (on_urlbar_key_down):
123         (on_urlbar_mouse_down):
124         (on_urlbar_focus_out):
125         (url_bar_add):
126         (url_bar_del):
127         (url_bar_url_set):
128         * EWebLauncher/url_bar.h: Added.
129         * MiniBrowser/efl/CMakeLists.txt:
130         * MiniBrowser/efl/main.c: Implemented to use the urlbar.
131         (_MiniBrowser):
132         (on_url_changed):
133         (browserCreate):
134
135 2012-08-23  Balazs Kelemen  <kbalazs@webkit.org>
136
137         [nrwt, WTR] Remove workaround for timeout handing from r126062
138         https://bugs.webkit.org/show_bug.cgi?id=94609
139
140         Reviewed by Dirk Pranke.
141
142         Don't try to reset state if a timeout occured but inform
143         the harness that the web process is no longer reliable.
144
145         * Scripts/webkitpy/layout_tests/port/driver.py:
146         (Driver.run_test): Remove the workaround. Furthermore, handle the case when
147         the pid is unknown.
148         * WebKitTestRunner/TestController.cpp:
149         (WTR::TestController::run):
150         * WebKitTestRunner/TestInvocation.cpp:
151         (WTR::TestInvocation::invoke):
152         (WTR::TestInvocation::dumpWebProcessUnresponsiveness):
153         * WebKitTestRunner/TestInvocation.h:
154         (TestInvocation):
155
156 2012-08-23  Ádám Kallai  <kadam@inf.u-szeged.hu>
157
158         Unreviewed. Adding myself to committers list.
159
160         * Scripts/webkitpy/common/config/committers.py:
161
162 2012-08-22  Alexis Menard  <alexis@webkit.org>
163
164         Unreviewed update of my email.
165
166         * Scripts/webkitpy/common/config/committers.py:
167         * Scripts/webkitpy/common/config/watchlist:
168
169 2012-08-22  Dirk Pranke  <dpranke@chromium.org>
170
171         Fix typos in r126374
172         https://bugs.webkit.org/show_bug.cgi?id=94665
173         Unreviewed, build fix.
174
175         Fix two issues that snuck in, one that caused a crash if there
176         were no baselines to optimize and one that occurred as a result
177         of failing to rename a variable when I changed the recursion to
178         a loop in the previous patch.
179
180         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
181         (BaselineOptimizer._optimize_by_pushing_results_up):
182
183 2012-08-22  Dirk Pranke  <dpranke@chromium.org>
184
185         Baseline optimizer should try to optimize per-port if global optimization fails
186         https://bugs.webkit.org/show_bug.cgi?id=94665
187
188         Reviewed by Adam Barth.
189
190         Add a fallback strategy for optimizing baselines if the default
191         one fails; this one simply attempts to shift baselines up in the
192         tree and consolidates them if a parent and child in the fallback
193         path have the same result. This strategy is somewhat flawed in
194         that we will always put something in a parent dir even if we
195         "shouldn't"; for example, if chromium-mac produces a different
196         result from chromium-win and chromium-linux, then the new
197         algorithm will move the mac result into platform/chromium,
198         leaving chromium-mac empty. This result is still correct, but
199         perhaps confusing.
200
201         I haven't done much testing of this algorithm yet, so it's not
202         clear how many cases where this does a better job than the
203         default algorithm and how many it'll do a worse job.
204
205         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
206         (BaselineOptimizer._find_optimal_result_placement):
207         (BaselineOptimizer._optimize_by_most_specific_common_directory):
208         (BaselineOptimizer):
209         (BaselineOptimizer._optimize_by_pushing_results_up):
210         (BaselineOptimizer._find_in_fallbackpath):
211         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
212         (BaselineOptimizerTest.test_platform_mac_different):
213
214 2012-08-22  Dirk Pranke  <dpranke@chromium.org>
215
216         add debug info, another test to webkit-patch optimize-baselines
217         https://bugs.webkit.org/show_bug.cgi?id=94762
218
219         Reviewed by Adam Barth.
220
221         This patch adds more debug logging for optimize-baselines so
222         that you can tell the before and after states and figure out
223         what the command is actually deciding to do.
224
225         Also, this command adds a (disabled) test for the problem in bug
226         94665. It's disabled because we don't have the fix yet (that
227         will be posted in a patch to that bug).
228
229         There should be no functional changes in this patch apart from
230         the additional logging.
231
232         Note that adding the debug logging exposed a bug in
233         filesystem_mock.relpath() (that would return None if the path
234         wasn't a subpath of the start); the real relpath computes a
235         relpath with parent dirs. Fixing this revealed a bad check in
236         the style checker's change_directory() call which was checking
237         for None.
238
239         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
240         (BaselineOptimizer._find_optimal_result_placement):
241         (BaselineOptimizer):
242         (BaselineOptimizer._optimize_by_most_specific_common_directory):
243         (BaselineOptimizer._move_baselines):
244         (BaselineOptimizer.optimize):
245         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
246         (BaselineOptimizerTest.disabled_test_platform_mac_different):
247         * Scripts/webkitpy/common/system/filesystem.py:
248         (FileSystem):
249         * Scripts/webkitpy/common/system/filesystem_mock.py:
250         (MockFileSystem):
251         (MockFileSystem.__init__):
252         (MockFileSystem.relpath):
253         * Scripts/webkitpy/common/system/filesystem_unittest.py:
254         (RealFileSystemTest.test_sep):
255         * Scripts/webkitpy/style/main.py:
256         (change_directory):
257
258 2012-08-22  Alejandro Piñeiro  <apinheiro@igalia.com>
259
260         Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not ROLE_PUSH_BUTTON
261         https://bugs.webkit.org/show_bug.cgi?id=73819
262
263         Reviewed by Chris Fleizach.
264
265         Added a new role, Toggle Button, based on whether aria-pressed is present.
266         http://www.w3.org/TR/wai-aria/states_and_properties#aria-pressed
267
268         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
269         (roleToString): added "ToggleButton" string for WebAccessibilityRoleToggleButton
270
271 2012-08-23  Victor Carbune  <victor@rosedu.org>
272
273         Add myself to the committer list
274         https://bugs.webkit.org/show_bug.cgi?id=94659
275
276         Reviewed by James Robinson.
277
278         Added my email and IRC handle.
279
280         * Scripts/webkitpy/common/config/committers.py:
281
282 2012-08-22  Scott Graham  <scottmg@chromium.org>
283
284         Don't unconditionally define NOMINMAX on Windows
285         https://bugs.webkit.org/show_bug.cgi?id=94742
286
287         Reviewed by Adrienne Walker.
288
289         Avoids a warning when building on Windows when NOMINMAX is defined
290         elsewhere or on the command line.
291
292         * TestWebKitAPI/config.h:
293
294 2012-08-22  Zan Dobersek  <zandobersek@gmail.com>
295
296         REGRESSION(r126189): Reftest mismatches are (again) run through ImageDiff with 0.1 tolerance
297         https://bugs.webkit.org/show_bug.cgi?id=94704
298
299         Reviewed by Dirk Pranke.
300
301         Use tolerance=0 when acquiring diff image of reftest output.
302
303         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
304         (SingleTestRunner._compare_output_with_reference):
305
306 2012-08-22  Tommy Widenflycht  <tommyw@google.com>
307
308         [chromium] MediaStream API: Add MockWebRTCPeerConnectionHandler
309         https://bugs.webkit.org/show_bug.cgi?id=93091
310
311         Reviewed by Adam Barth.
312
313         Add a skeleton MockWebRTCPeerConnectionHandler to DumpRenderTree,
314         to complete the infrastructure for RTCPeerConnection.
315
316         * DumpRenderTree/DumpRenderTree.gypi:
317         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
318         (MockWebKitPlatformSupport::createRTCPeerConnectionHandler):
319         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h:
320         (MockWebKitPlatformSupport):
321         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
322         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
323         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
324         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
325         (MockWebRTCPeerConnectionHandler::initialize):
326         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
327         (WebKit):
328         (MockWebRTCPeerConnectionHandler):
329         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
330
331 2012-08-21  Ryosuke Niwa  <rniwa@webkit.org>
332
333         Merge TestExpectationSerializer into TestExpectationLine
334         https://bugs.webkit.org/show_bug.cgi?id=94638
335
336         Reviewed by Dimitri Glazkov.
337
338         Moved all methods except, list_to_string which was moved to TestExpectations
339         from TestExpectationSerializer to TestExpectationLine and removed TestExpectationSerializer.
340
341         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
342         (TestExpectationEditorTests.assert_remove_roundtrip):
343         (TestExpectationEditorTests.assert_update_roundtrip):
344         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
345         (ParseError.__repr__):
346         (TestExpectationLine):
347         (TestExpectationLine.create_passing_expectation):
348         (TestExpectationLine.to_string): Moved from TestExpectationSerializer.
349         (TestExpectationLine.to_csv): Ditto.
350         (TestExpectationLine._serialize_parsed_expectations): Ditto.
351         (TestExpectationLine._serialize_parsed_modifiers): Ditto.
352         (TestExpectationLine._format_line):
353         (TestExpectations.remove_configuration_from_test):
354         (TestExpectations.remove_rebaselined_tests):
355         (TestExpectations.add_skipped_tests):
356         (TestExpectations):
357         (TestExpectations.list_to_string): Moved from TestExpectationSerializer.
358         (TestExpectations.list_to_string.serialize):
359         (TestExpectations.list_to_string.nones_out):
360         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
361         (TestExpectationSerializationTests): Renamed from TestExpectationSerializerTests.
362         (TestExpectationSerializationTests.__init__):
363         (TestExpectationSerializationTests.assert_round_trip):
364         (TestExpectationSerializationTests.assert_list_round_trip):
365         (TestExpectationSerializationTests.test_unparsed_to_string):
366         (TestExpectationSerializationTests.test_unparsed_list_to_string):
367         (TestExpectationSerializationTests.test_parsed_to_string):
368         (TestExpectationSerializationTests.test_serialize_parsed_expectations):
369         (TestExpectationSerializationTests.test_serialize_parsed_modifier_string):
370         (TestExpectationSerializationTests.test_format_line):
371         (TestExpectationSerializationTests.test_reconstitute_only_these):
372         * Scripts/webkitpy/tool/commands/expectations.py:
373         (OptimizeExpectations.execute):
374         * Scripts/webkitpy/tool/commands/queries.py:
375         (PrintExpectations.execute):
376         (PrintExpectations._format_lines):
377         * Scripts/webkitpy/tool/servers/gardeningserver.py:
378         (GardeningExpectationsUpdater.update_expectations):
379
380 2012-08-22  Alexandre Elias  <aelias@chromium.org>
381
382         Unreviewed, add aelias@chromium.org to committers
383
384         I (aelias@chromium.org) have been approved for commit access and Apple
385         has confirmed receipt of my committer agreement.
386
387         * Scripts/webkitpy/common/config/committers.py:
388
389 2012-08-22  Alexey Proskuryakov  <ap@apple.com>
390
391         [WK2] Support posting injected bundle messages to a page
392         https://bugs.webkit.org/show_bug.cgi?id=94630
393
394         Reviewed by Sam Weinig.
395
396         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
397         * TestWebKitAPI/InjectedBundleController.cpp:
398         (TestWebKitAPI::InjectedBundleController::initialize):
399         (TestWebKitAPI::InjectedBundleController::didReceiveMessageToPage):
400         * TestWebKitAPI/InjectedBundleController.h:
401         * TestWebKitAPI/InjectedBundleTest.h:
402         (TestWebKitAPI::InjectedBundleTest::didReceiveMessageToPage):
403         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
404         (WTR::InjectedBundle::didReceiveMessage):
405         (WTR::InjectedBundle::didReceiveMessageToPage):
406         (WTR::InjectedBundle::initialize):
407         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
408         Updated for new client API call.
409
410 2012-08-22  Dominic Mazzoni  <dmazzoni@google.com>
411
412         REGRESSION (r125710): accessibility/accessibility-node-reparent.html, accessibility/accessibility-node-memory-management.html failing on GTK Linux
413         https://bugs.webkit.org/show_bug.cgi?id=94200
414
415         Reviewed by Chris Fleizach.
416
417         Adds reference counting for AtkObjects referenced by
418         AccessibilityUIElementGtk. This prevents bogus results and
419         assertion failures on AccessibilityUIElements whose underlying
420         object has been deleted (as opposed to just made defunct).
421
422         This fixes two tests that were previously failing because of this bug.
423
424         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
425         (AccessibilityUIElement::AccessibilityUIElement):
426         (AccessibilityUIElement::~AccessibilityUIElement):
427
428 2012-08-22  Gustavo Noronha Silva  <gns@gnome.org>
429
430         [GTK] Split WebCore/platform into a separate library
431         https://bugs.webkit.org/show_bug.cgi?id=94435
432
433         Reviewed by Martin Robinson.
434
435         More people have been reporting problems when linking WebCore because
436         the command line limit is being exceeded. Splitting WebCore a bit more
437         is in order.
438
439         * GNUmakefile.am: link libWebCorePlatform into DRT
440
441 2012-08-22  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
442
443         Unreviewed buildfix for Qt-minimal after r126291
444
445         Disable smooth scrolling when request-animation-frame has been disabled either
446         explicitly or as part of --minimal.
447
448         * qmake/mkspecs/features/features.prf:
449
450 2012-08-22  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
451
452         [Qt] Optionally support smooth-scrolling on all platforms
453         https://bugs.webkit.org/show_bug.cgi?id=74926
454
455         Reviewed by Simon Hausmann.
456
457         Enabled SMOOTH_SCROLLING on Qt, and expose the enable scroll animator
458         setting in QtTestBrowser so it can be tested.
459
460         * QtTestBrowser/launcherwindow.cpp:
461         (LauncherWindow::createChrome):
462         (LauncherWindow::toggleScrollAnimator):
463         * QtTestBrowser/launcherwindow.h:
464         (WindowOptions::WindowOptions):
465         (WindowOptions):
466         (LauncherWindow):
467         * qmake/mkspecs/features/features.pri:
468
469 2012-08-22  Dominik Röttsches  <dominik.rottsches@intel.com>
470
471         Unreviewed, adding myself to committers.py.
472
473         * Scripts/webkitpy/common/config/committers.py:
474
475 2012-08-21  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
476
477         [GTK] contextClick and getMenuItemTitle callbacks are leaky in DRT's EventSender
478         https://bugs.webkit.org/show_bug.cgi?id=94669
479
480         Reviewed by Carlos Garcia Campos.
481
482         Fix memory leaks in DRT's EventSender code.
483
484         * DumpRenderTree/gtk/EventSender.cpp:
485         (getMenuItemTitleCallback): Use JSRetainPtr and don't leak.
486         (contextClickCallback): Use GOwnPtr to manage memory of a
487         newly-allocated list automatically.
488
489 2012-08-21  Dirk Pranke  <dpranke@chromium.org>
490
491         Add mountain lion to perf-tests, layout tests
492         https://bugs.webkit.org/show_bug.cgi?id=94553
493
494         Reviewed by Adam Barth.
495
496         This patch adds support for the 'mac-mountainlion' platform and
497         stamps out the last references to 'mac-leopard' as a supported
498         name.
499         
500         This patch does a small amount of refactoring to try and make
501         things a little clearer how we treat the "most recent version"
502         specially for baselines and skipped files, and so you only
503         should have to touch the VERSION_FALLBACK_ORDER constants on the
504         ports, but unfortunately changing this list changes a bunch of
505         the unit tests which are doing exact matches for correctness, so
506         you have to touch more than a couple files :(. There's probably
507         still more refactoring that can be done so that we don't have to
508         do all of this functional testing to feel completely correct.
509
510         * Scripts/webkitpy/common/system/platforminfo.py:
511         (PlatformInfo._determine_mac_version):
512         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
513         (TestPlatformInfo.test_os_version):
514         * Scripts/webkitpy/layout_tests/port/apple.py:
515         (ApplePort.__init__):
516         (ApplePort):
517         (ApplePort._skipped_file_search_paths):
518         (ApplePort._generate_all_test_configurations):
519         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
520         (ChromiumMacPort):
521         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
522         (FactoryTest.test_mac):
523         * Scripts/webkitpy/layout_tests/port/mac.py:
524         (MacPort):
525         (MacPort._build_driver_flags):
526         (MacPort.should_retry_crashes):
527         (MacPort.default_baseline_search_path):
528         (MacPort.operating_system):
529         (MacPort.default_child_processes):
530         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
531         (MacTest):
532         (MacTest.test_skipped_file_search_paths):
533         (test_versions):
534         (test_baseline_search_path):
535         * Scripts/webkitpy/layout_tests/port/win.py:
536         (WinPort):
537         (WinPort.default_baseline_search_path):
538
539 2012-08-21  Zan Dobersek  <zandobersek@gmail.com>
540
541         [GTK] fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html is failing
542         https://bugs.webkit.org/show_bug.cgi?id=94617
543
544         Reviewed by Martin Robinson.
545
546         Set the 'enable-file-access-from-file-uris' setting to true when
547         resetting default values. The other ports do this as well, giving
548         documents with local security origin permission to load other
549         local resources.
550
551         * DumpRenderTree/gtk/DumpRenderTree.cpp:
552         (resetDefaultsToConsistentValues):
553
554 2012-08-21  Kent Tamura  <tkent@chromium.org>
555
556         [Chromium] DRT produces wrong back-forward list
557         https://bugs.webkit.org/show_bug.cgi?id=94575
558
559         Reviewed by Adam Barth.
560
561         DRT clears its history state before running every tests. However
562         HistoryController in WebCore isn't reset. So, it is possible that
563         'isNewNavigation' flag is false even though the navigation should be
564         handled as "new" for DRT.
565
566         This change might fix a problem of
567         fast/forms/select/select-state-restore.html (Bug 90207).
568
569         * DumpRenderTree/chromium/WebViewHost.cpp:
570         (WebViewHost::updateForCommittedLoad):
571         Treat the first page load (m_pageID == -1) as new navigation except for about:blank.
572         Without this change, a navigation entry for this loading won't be recorded.
573
574 2012-08-21  Thiago Marcos P. Santos  <thiago.santos@intel.com>
575
576         [EFL] Enable CSS Text Decoration by default
577         https://bugs.webkit.org/show_bug.cgi?id=94483
578
579         Reviewed by Kenneth Rohde Christiansen.
580
581         * Scripts/webkitperl/FeatureList.pm:
582
583 2012-08-21  Benjamin Poulain  <bpoulain@apple.com>
584
585         Store CString data in the CStringBuffer to avoid the double indirection
586         https://bugs.webkit.org/show_bug.cgi?id=94562
587
588         Reviewed by Darin Adler.
589
590         Add test coverage for WTF::CString.
591
592         * TestWebKitAPI/CMakeLists.txt:
593         * TestWebKitAPI/GNUmakefile.am:
594         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
595         * TestWebKitAPI/Tests/WTF/CString.cpp:
596
597 2012-08-21  Dirk Pranke  <dpranke@chromium.org>
598
599         Text Autosizing: ::first-letter pseudo-element is incorrectly sized
600         https://bugs.webkit.org/show_bug.cgi?id=94540
601
602         Reviewed by Ojan Vafai.
603
604         Revert the changes in bugs 94517 and 94396 so that we are
605         actually looking for stderr output from ImageDiff and doing
606         image compares on ref tests on the wk2 ports again.
607
608         Also, do an actual diff_image() call if the hash checks fail on
609         reftests, and only fail the test if we get real diffs (or don't,
610         for mismatches).
611
612         Lastly, clean up the log messages to be more helpful.
613
614         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
615         (SingleTestRunner._compare_image):
616         (SingleTestRunner._compare_output_with_reference):
617         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
618         (write_test_result):
619
620 2012-08-21  Dirk Pranke  <dpranke@chromium.org>
621
622         _compare_image() swaps actual and expected images by mistake
623         https://bugs.webkit.org/show_bug.cgi?id=94567
624
625         Reviewed by Ojan Vafai.
626
627         Re-work the code so that we consistently pass (expected, actual)
628         across all of the compare/diff routines.
629
630         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
631         (SingleTestRunner._run_compare_test):
632         (SingleTestRunner._compare_output):
633         (SingleTestRunner._compare_text):
634         (SingleTestRunner._compare_audio):
635         (SingleTestRunner._compare_image):
636         (SingleTestRunner._run_reftest):
637         (SingleTestRunner._compare_output_with_reference):
638         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
639         (write_test_result):
640
641 2012-08-21  Adam Barth  <abarth@webkit.org>
642
643         Unreviewed. Move the commit-queue to building release only. Previously,
644         we built debug too, but for some reason the debug build doesn't work on
645         the bots. We can re-enable debug builds once we fix the underlying
646         problem.
647
648         * Scripts/webkitpy/tool/commands/queues.py:
649         (CommitQueue.build_style):
650         * Scripts/webkitpy/tool/commands/queues_unittest.py:
651
652 2012-08-21  Ryosuke Niwa  <rniwa@webkit.org>
653
654         TestExpectationsParser doesn't warn about test files that don't exist.
655         https://bugs.webkit.org/show_bug.cgi?id=94632
656
657         Reviewed by Dirk Pranke.
658
659         Exit early and warn when the test file doesn't exist as well when a test directory doesn't exist.
660
661         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
662         (TestExpectationParser._parse_line):
663         (TestExpectationParser._check_test_exists):
664         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
665         (test_parse_warning):
666
667 2012-08-20  Ryosuke Niwa  <rniwa@webkit.org>
668
669         Move free functions in test_expectations to TestExpectations class
670         https://bugs.webkit.org/show_bug.cgi?id=94557
671
672         Reviewed by Dirk Pranke.
673
674         Moved test_result_was_expected, test_remove_pixel_failures, and test_suffixes_for_expectations into TestExpectations
675         to allow further refactoring.
676
677         * Scripts/webkitpy/common/net/resultsjsonparser.py:
678         (JSONTestResult.did_run_as_expected):
679         (JSONTestResult._tokenize):
680         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
681         (TestExpectations):
682         (TestExpectations.result_was_expected):
683         (TestExpectations.remove_pixel_failures):
684         (TestExpectations.has_pixel_failures):
685         (TestExpectations.suffixes_for_expectations):
686         (TestExpectations.matches_an_expected_result):
687         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
688         (MockBugManager.create_bug):
689         (test_result_was_expected):
690         (test_remove_pixel_failures):
691         (test_suffixes_for_expectations):
692         * Scripts/webkitpy/tool/commands/rebaseline.py:
693         (RebaselineExpectations._tests_to_rebaseline):
694
695 2012-08-21  Simon Hausmann  <simon.hausmann@nokia.com>
696
697         Unreviewed build fix for newer Qt 5: The meaning of private_includes changed to be fully
698         self-contained. The module name is not appended automatically anymore.
699
700         * qmake/qt_webkit.pri:
701
702 2012-08-20  Xianzhu Wang  <wangxianzhu@chromium.org>
703
704         [Chromium-Android] Add stop_when_done parameter to ChromiumAndroidDriver.run_test()
705         https://bugs.webkit.org/show_bug.cgi?id=94558
706
707         Reviewed by Dirk Pranke.
708
709         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
710         (ChromiumAndroidDriver.run_test):
711
712 2012-08-20  Ryosuke Niwa  <rniwa@webkit.org>
713
714         Cleanup TestExpectationParser.parse
715         https://bugs.webkit.org/show_bug.cgi?id=94545
716
717         Reviewed by Dirk Pranke.
718
719         Refactor TestExpectations to simplify the code.
720
721         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
722         (TestExpectationParser.parse): Merged _tokenize_list.
723         (TestExpectationParser._parse_line): Removed the call to _check_modifiers_against_expectations
724         since the check is now done in _parser_modifiers.
725         (TestExpectationParser._parse_modifiers): Merged _check_modifiers_against_expectations.
726         (TestExpectationParser._tokenize_line): Renamed from _tokenize.
727         (TestExpectationParser._split_space_separated): No longer calls lower() on all modifiers.
728         This is done on a local variable in _parse_modifiers, preserving the original case.
729         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier): Check the existence
730         of 'rebaseline' against parsed modifiers.
731         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
732         (TestExpectationParserTests._tokenize):
733         (TestExpectationParserTests.test_tokenize_valid_with_comment): Preserves case.
734         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers): Ditto.
735         (TestExpectationSerializerTests._tokenize):
736         (TestExpectationSerializerTests.assert_list_round_trip): Call parse since _tokenize_list has
737         been merged into parse.
738         * Scripts/webkitpy/tool/commands/queries_unittest.py:
739         (PrintExpectationsTest.test_csv): Preserves the case.
740
741 2012-08-20  Gustavo Noronha Silva  <gns@gnome.org>
742
743         [jhbuild] EFL now runs jhbuild update for every build
744         https://bugs.webkit.org/show_bug.cgi?id=94267
745
746         Reviewed by Martin Robinson.
747
748         Try to fix WinCE build by returning the empty string instead of
749         env when no jhbuild infrastructure is found.
750
751         * Scripts/webkitdirs.pm:
752         (jhbuildWrapperPrefixIfNeeded):
753
754 2012-08-20  Benjamin Poulain  <benjamin@webkit.org>
755
756         Add a watcher for WTF changes
757
758         Unreviewed.
759
760         Add myself as a watcher for changes in WTF.
761
762         * Scripts/webkitpy/common/config/watchlist:
763
764 2012-08-20  Thiago Marcos P. Santos  <thiago.santos@intel.com>
765
766         [EFL] Move jhbuild dependencies based on SVN to tarballs
767         https://bugs.webkit.org/show_bug.cgi?id=90374
768
769         Reviewed by Kenneth Rohde Christiansen.
770
771         Moved all the dependencies based on SVN to tarballs taken from a
772         equivalent snapshot from the official git mirror. This will make
773         update-webkitefl not dependent on network connection after the first
774         run. The bots will not fail if EFL SVN server in unreachable.
775         The reason why git mirror is not used directly is to minimize the
776         total size of source code we need to download.
777
778         * efl/jhbuild.modules:
779
780 2012-08-20  Simon Fraser  <simon.fraser@apple.com>
781
782         Lots of "error, test and reference image have different properties" in pixel test output
783         https://bugs.webkit.org/show_bug.cgi?id=92578
784
785         Reviewed by Dirk Pranke.
786
787         Improve ImageDiff's error reporting when test result image and expected image
788         differ in their properties.
789
790         * DumpRenderTree/cg/ImageDiffCG.cpp:
791
792 2012-08-20  Nate Chapin  <japhet@chromium.org>
793
794         Unsafe vsprintf usage in TestNetscapePlugin
795         https://bugs.webkit.org/show_bug.cgi?id=94522
796
797         Reviewed by Adam Barth.
798
799         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
800         (pluginLogWithArguments): Using vsnprintf instead of vsprintf to ensure we don't overflow
801             the message buffer.
802         (testDocumentOpen):
803         (testWindowOpen):
804
805 2012-08-20  George Staikos  <staikos@webkit.org>
806
807         [BlackBerry] Enable XHR Response BLOB
808         https://bugs.webkit.org/show_bug.cgi?id=94525
809
810         Reviewed by Rob Buis.
811
812         Turn on the XHR response blob feature for the BlackBerry port.
813
814         * Scripts/webkitperl/FeatureList.pm: Add the feature and enable it.
815
816 2012-08-20  Dirk Pranke  <dpranke@chromium.org>
817
818         Fix change for timeout detection to not crash if we have no output :)
819         https://bugs.webkit.org/show_bug.cgi?id=94505
820
821         Unreviewed, build fix.
822
823         * Scripts/webkitpy/layout_tests/port/driver.py:
824         (Driver.run_test):
825
826 2012-08-20  Dirk Pranke  <dpranke@chromium.org>
827
828         temporarily disable ImageDiff on WK2 ports for ref tests
829         https://bugs.webkit.org/show_bug.cgi?id=94517
830
831         Reviewed by Brady Eidson.
832
833         ImageDiff appears to be unable to handle the pngs returned from
834         WebKitTestRunner, so we disable checking images by default
835         for ref tests on wk2 ports (unless pixel tests is explicitly enabled).
836
837         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
838         (SingleTestRunner._compare_output_with_reference):
839
840 2012-08-20  Dirk Pranke  <dpranke@chromium.org>
841
842         Add missing FIXME: to previous change.
843         https://bugs.webkit.org/show_bug.cgi?id=94505
844
845         Reviewed by Ojan Vafai.
846
847         * Scripts/webkitpy/layout_tests/port/driver.py:
848         (Driver.run_test):
849
850 2012-08-20  Dirk Pranke  <dpranke@chromium.org>
851
852         Intermittenly, many WebKit2 tests have results from the wrong test compared to the test just run, giving false failures.
853         https://bugs.webkit.org/show_bug.cgi?id=94505
854
855         Reviewed by Ojan Vafai.
856
857         It looks like if the webprocess times out, WTR may tell NRWT
858         that the test completed, but not properly reset its internal
859         state, and then return stale output for subsequent tests.
860
861         This patch modifies NRWT temporarily to check for
862         "Timed out waiting for final message from web process" in stdout
863         and treat that as a timeout (and thus kill WTR); this seems
864         to solve the cascade of failures, but of course there's probably
865         still a bug in WTR that needs to be fixed.
866
867         * Scripts/webkitpy/layout_tests/port/driver.py:
868         (Driver.run_test):
869
870 2012-08-20  Dirk Pranke  <dpranke@chromium.org>
871
872         NRWT reports unexpected EOF
873         https://bugs.webkit.org/show_bug.cgi?id=94387
874
875         Reviewed by Adam Barth.
876
877         Stop logging "Unexpected EOF" when we are reading the last few
878         bytes from stdout/stderr after stopping the subprocess.
879
880         * Scripts/webkitpy/layout_tests/port/server_process.py:
881         (ServerProcess._wait_for_data_and_update_buffers_using_select):
882         (ServerProcess.stop):
883
884 2012-08-20  Brady Eidson  <beidson@apple.com>
885
886         Temporarily disable the 20+ crash and 500+ failure options on WK2 bots.
887         https://bugs.webkit.org/show_bug.cgi?id=94506
888
889         Reviewed by Dirk Pranke.
890
891         When running WK2 tests, don't add the "abort early" command line options.
892
893         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
894         (ConfigureBuild.start):
895         (RunWebKitTests):
896         (RunWebKitTests.start):
897         (RunWebKit2Tests.start):
898
899 2012-08-19  Stephanie Lewis  <slewis@apple.com>
900
901         Add mountain lion to build config.
902         https://bugs.webkit.org/show_bug.cgi?id=94441
903
904         Reviewed by Adam Barth.
905
906         Add Mountain Lion to the build trigger configurations.
907
908         * Scripts/webkitpy/common/config/build.py:
909         (_should_file_trigger_build):
910         * Scripts/webkitpy/common/config/build_unittest.py:
911         (ShouldBuildTest):
912         (ShouldBuildTest.test_should_build):
913
914 2012-08-17  Kiran Muppala  <cmuppala@apple.com>
915
916         Add self to webkit contributors list
917         https://bugs.webkit.org/show_bug.cgi?id=94409
918
919         Reviewed by Dirk Pranke.
920
921         Add name, email and irc handle to webkit contributors list.
922
923         * Scripts/webkitpy/common/config/committers.py:
924
925 2012-08-17  Ryosuke Niwa  <rniwa@webkit.org>
926
927         Perfalizer should differentiate results with and without the patch
928         https://bugs.webkit.org/show_bug.cgi?id=94399
929
930         Reviewed by Dirk Pranke.
931
932         Add "with 12345" and "without 12345" descriptions in results JSON so that graphs in
933         the results page are labled accordingly.
934
935         Also use _build_without_patch when building without a patch so that we get the right error message.
936
937         * Scripts/webkitpy/tool/commands/perfalizer.py:
938         (PerfalizerTask.run):
939         (PerfalizerTask._run_perf_test):
940         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
941         (PerfalizerTaskTest._create_and_run_perfalizer.run_perf_test):
942
943 2012-08-17  Dirk Pranke  <dpranke@chromium.org>
944
945         nrwt: don't fail tests if ImageDiff fails on the wk2 ports
946         https://bugs.webkit.org/show_bug.cgi?id=94396
947
948         Reviewed by Ryosuke Niwa.
949
950         It appears that WTR is generating PNGs that ImageDiff doesn't
951         like, and so we're getting lots of "can not get ImageDiff"
952         errors (see bug 81962). The change in r124581 made this a test
953         failure, and this is causing the WK2 bots to frequently abort
954         with 500+ failures. 
955
956         This change makes ImageDiff errors not be test failures just for
957         WK2 for now until we can better triage what's going on.
958
959         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
960         (SingleTestRunner._compare_image):
961
962 2012-08-17  James Robinson  <jamesr@chromium.org>
963
964         [chromium] Add a style check for #include "cc/..." in chromium files
965         https://bugs.webkit.org/show_bug.cgi?id=94382
966
967         Reviewed by Adam Barth.
968
969         Adds a style check to make sure new chromium code follows the correct convention for including cc files.
970
971         * Scripts/webkitpy/style/checkers/cpp.py:
972         (check_include_line):
973         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
974         (OrderOfIncludesTest.test_check_cc_includes):
975
976 2012-08-17  Ojan Vafai  <ojan@chromium.org>
977
978         Delete some dead code from the flakiness dashboard
979         https://bugs.webkit.org/show_bug.cgi?id=94380
980
981         Reviewed by Dirk Pranke.
982
983         This code became dead in one of the refactors of how we handle BuilderGroups.
984         There's no bug here, it's just dead code.
985         * TestResultServer/static-dashboards/builders.js:
986         (requestBuilderList):
987         (loadBuildersList):
988
989 2012-08-17  Jochen Eisinger  <jochen@chromium.org>
990
991         [chromium] Add content shell bots to the flakiness dashboard
992         https://bugs.webkit.org/show_bug.cgi?id=94369
993
994         Reviewed by Ojan Vafai.
995
996         The bots are named $OS (Content Shell).
997
998         * TestResultServer/static-dashboards/builders.js:
999         (isChromiumWebkitTipOfTreeTestRunner):
1000         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1001
1002 2012-08-17  Shadi Khalek  <shadi@chromium.org>
1003
1004         Add AV perf layout tests to webkit flakiness dashboard
1005         https://bugs.webkit.org/show_bug.cgi?id=94255
1006
1007         Reviewed by Ojan Vafai.
1008
1009         Added missing mappings to LEGACY_BUILDER_MASTERS_TO_GROUPS.
1010         The isChromiumDepsAVTestRunner() filter does not work on current builder names. 
1011         It assumes the new names they are getting renamed to (AV Linux, AV Win7).
1012
1013         * TestResultServer/static-dashboards/builders.js:
1014         (isChromiumTipOfTreeAVTestRunner):
1015         (loadBuildersList):
1016
1017 2012-08-17  Milian Wolff  <milian.wolff@kdab.com>
1018
1019         [Qt] QtWebKit fails to build with OpenGL support on QNX
1020         https://bugs.webkit.org/show_bug.cgi?id=93278
1021
1022         Reviewed by Noam Rosenthal.
1023
1024         Change the order in which we define WTF_USE_3D_GRAPHICS and ENABLE_WEBGL.
1025         First, we now defined WTF_USE_3D_GRAPHICS=1, but only if QT_CONFIG
1026         contains opengl. Furthermore, we disable this feature on win32-* as usual,
1027         but now also disable it on QNX.
1028
1029         Then, we set ENABLE_WEBGL=1 but only if we previously set WTF_USE_3D_GRAPHICS=1.
1030
1031         * qmake/mkspecs/features/features.prf:
1032
1033 2012-08-16  Gustavo Noronha Silva  <gns@gnome.org>
1034
1035         [jhbuild] EFL now runs jhbuild update for every build
1036         https://bugs.webkit.org/show_bug.cgi?id=94267
1037
1038         Reviewed by Dirk Pranke.
1039
1040         This change makes EFL's approach to jhbuild more in line with the one
1041         used by WebKitGTK+. update-webkitefl-libs will only be called by build-
1042         webkit if --update-efl is given explicitly. The EWS bot will do that
1043         from now on.
1044
1045         * Scripts/webkitdirs.pm:
1046         (jhbuildWrapperPrefixIfNeeded): return jhbuild wrapper only if the
1047         Dependencies directory exists also for EFL
1048         (generateBuildSystemFromCMakeProject): no longer run update-webkitefl-libs
1049         (buildCMakeProjectOrExit): build update-webkitefl-libs if --update-efl is
1050         given
1051         * Scripts/webkitpy/common/config/ports.py:
1052         (EflPort.build_webkit_command): make EWS bots pass --update-efl to build-webkit
1053         * Scripts/webkitpy/common/config/ports_unittest.py:
1054         (DeprecatedPortTest.test_efl_port): add unit testing for EFL port
1055
1056 2012-08-16  Kent Tamura  <tkent@chromium.org>
1057
1058         Add forms-bugs@chromium.org as a contributor.
1059
1060         * Scripts/webkitpy/common/config/committers.py:
1061
1062 2012-08-16  Gustavo Noronha Silva  <gns@gnome.org>
1063
1064         Unreviewed warning fix, sys.argv is a python construct.
1065
1066         * Scripts/update-webkitefl-libs:
1067
1068 2012-08-16  Dirk Pranke  <dpranke@chromium.org>
1069
1070         NRWT cutting off the output from LayoutTest run under Valgrind
1071         https://bugs.webkit.org/show_bug.cgi?id=94011
1072
1073         Reviewed by Ojan Vafai.
1074
1075         Make NRWT work with valgrind again ... I needed to rework the
1076         driver infrastructure so that we could get the stderr written
1077         between a test completing and a process being stopped and
1078         associate it with the DriverOutput for the test; this meant that
1079         run_test() needed to stop the driver at the end of the test
1080         directly if/when appropriate. This also entailed reworking
1081         run_test() so that we would gather stderr and stdout
1082         consistently regardless of whether this was a normal test, or
1083         stop_when_done, or a crash or timeout.
1084
1085         Also, I had to rework the process_stop_time() (and renamed it to
1086         driver_stop_timeout) so that it would be longer if --time-out-ms
1087         was long as well (so that valgrind would get enough time to
1088         run), and I reworked driver.stop(kill_directly=True) to just
1089         driver.stop(timeout=0.0).
1090
1091         Lastly, adding the new stop_when_done parameter entailed
1092         touching a lot of test mock functions :(.
1093
1094         This change appeared to be well-covered by existing tests.
1095
1096         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1097         (Worker._run_test):
1098         (Worker._run_test_with_timeout):
1099         (Worker._run_test_in_another_thread):
1100         (Worker._run_test_in_another_thread.SingleTestThread.run):
1101         (Worker._run_test_in_this_thread):
1102         (Worker._run_single_test):
1103         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1104         (run_single_test):
1105         (SingleTestRunner.__init__):
1106         (SingleTestRunner._run_compare_test):
1107         (SingleTestRunner._run_rebaseline):
1108         (SingleTestRunner._run_reftest):
1109         * Scripts/webkitpy/layout_tests/port/base.py:
1110         (Port.driver_stop_timeout):
1111         (Port.variable.default_configuration):
1112         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1113         (ChromiumAndroidPort.driver_stop_timeout):
1114         (ChromiumAndroidDriver.stop):
1115         * Scripts/webkitpy/layout_tests/port/driver.py:
1116         (Driver.run_test):
1117         (Driver.stop):
1118         (DriverProxy.run_test):
1119         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
1120         (DriverTest.test_check_for_driver_crash.FakeServerProcess.stop):
1121         * Scripts/webkitpy/layout_tests/port/server_process.py:
1122         (ServerProcess.write):
1123         (ServerProcess._wait_for_data_and_update_buffers_using_select):
1124         (ServerProcess.stop):
1125         (ServerProcess.kill):
1126         (ServerProcess):
1127         (ServerProcess._kill):
1128         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
1129         (TrivialMockPort.__init__):
1130         (MockProc.wait):
1131         (TestServerProcess.test_basic):
1132         * Scripts/webkitpy/layout_tests/port/test.py:
1133         (TestDriver.run_test):
1134         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1135         (get_tests_run.RecordingTestDriver.run_test):
1136         * Scripts/webkitpy/performance_tests/perftest.py:
1137         (PerfTest.run_single):
1138         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1139         (TestPageLoadingPerfTest.MockDriver.run_test):
1140         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver.run_test):
1141         (TestReplayPerfTest.test_run_single.run_test):
1142         (TestReplayPerfTest.test_run_single_fails_when_output_has_error.run_test):
1143         (TestReplayPerfTest.test_prepare.run_test):
1144         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1145         (MainTest.TestDriver.run_test):
1146
1147 2012-08-16  Roger Fong  <roger_fong@apple.com>
1148
1149         Typo in old-run-webkit-tests script from https://bugs.webkit.org/show_bug.cgi?id=93904.
1150         https://bugs.webkit.org/show_bug.cgi?id=94228
1151
1152         Reviewed by Tim Horton.
1153
1154         I previously made the change but made a typo that causes the script not ignore mismatch ref tests.
1155
1156         * Scripts/old-run-webkit-tests:
1157         (isUsedInReftest):
1158
1159 2012-08-16  Peter Beverloo  <peter@chromium.org>
1160
1161         [Chromium] Pass the --strip-binary argument to the apk test generator
1162         https://bugs.webkit.org/show_bug.cgi?id=94224
1163
1164         Reviewed by Adam Barth.
1165
1166         The native test generator currently relies on the $STRIP environment
1167         variable to be available, which it shouldn't do. Instead, pass it as an
1168         argument to the script. The $STRIP variable is being deprecated.
1169
1170         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1171         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1172
1173 2012-08-16  Xiaobo Wang  <xbwang@torchmobile.com.cn>
1174
1175         [BlackBerry] Update format of JS console message to keep consistent with other ports.
1176         https://bugs.webkit.org/show_bug.cgi?id=94058
1177
1178         Reviewed by Yong Li.
1179         Reviewed internally by George Staikos.
1180
1181         1. Remove line number if it's zero.
1182         2. Print only file name for "file://" URL.
1183
1184         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1185         (BlackBerry::WebKit::DumpRenderTree::addMessageToConsole):
1186
1187 2012-08-16  Simon Hausmann  <simon.hausmann@nokia.com>
1188
1189         [Qt] Make DRT results more reliable on X11
1190
1191         Reviewed by Jocelyn Turcotte.
1192
1193         Disable desktop setting awareness, to prevent QApplication on X11 from reading palette settings from
1194         the running desktop environment.
1195
1196         * DumpRenderTree/qt/main.cpp:
1197         (main):
1198
1199 2012-08-16  Pierre Rossi  <pierre.rossi@gmail.com>
1200
1201         [Qt] Remove FontQt4, HAVE_QRAWFONT flag and the related dead code
1202         https://bugs.webkit.org/show_bug.cgi?id=93960
1203
1204         Reviewed by Simon Hausmann.
1205
1206         Following the removal of Qt 4 support from trunk in r124879.
1207
1208         * qmake/mkspecs/features/features.prf:
1209
1210 2012-08-16  Taiju Tsuiki  <tzik@chromium.org>
1211
1212         Add deleteFileSystem support to DumpRenderTree for chromium
1213         https://bugs.webkit.org/show_bug.cgi?id=94071
1214
1215         Reviewed by Kent Tamura.
1216
1217         * DumpRenderTree/chromium/WebViewHost.cpp:
1218         (WebViewHost::deleteFileSystem): Added
1219         * DumpRenderTree/chromium/WebViewHost.h:
1220         (WebViewHost):
1221
1222 2012-08-15  Ryosuke Niwa  <rniwa@webkit.org>
1223
1224         Rename LayoutTestController to TestRunner in WebKitTestRunner
1225         https://bugs.webkit.org/show_bug.cgi?id=93942
1226
1227         Reviewed by Simon Fraser.
1228
1229         Renamed the class and relevant files.
1230
1231         * WebKitTestRunner/CMakeLists.txt:
1232         * WebKitTestRunner/DerivedSources.make:
1233         * WebKitTestRunner/GNUmakefile.am:
1234         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Removed.
1235         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Copied from Tools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl.
1236         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
1237         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1238         (WTR::InjectedBundle::didReceiveMessage):
1239         (WTR::InjectedBundle::beginTesting):
1240         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1241         (WTR::InjectedBundle::testRunner):
1242         (InjectedBundle):
1243         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1244         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Removed.
1245         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Removed.
1246         * WebKitTestRunner/InjectedBundle/Target.pri:
1247         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp.
1248         * WebKitTestRunner/InjectedBundle/TestRunner.h: Copied from Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h.
1249         (TestRunner):
1250         * WebKitTestRunner/InjectedBundle/efl/LayoutTestControllerEfl.cpp: Removed.
1251         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/efl/LayoutTestControllerEfl.cpp.
1252         (WTR::waitToDumpWatchdogTimerCallback):
1253         (WTR::TestRunner::platformInitialize):
1254         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
1255         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1256         (WTR::TestRunner::pathToLocalResource):
1257         (WTR::TestRunner::platformName):
1258         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp: Removed.
1259         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp.
1260         (WTR::waitToDumpWatchdogTimerCallback):
1261         (WTR::TestRunner::platformInitialize):
1262         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
1263         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1264         (WTR::TestRunner::pathToLocalResource):
1265         (WTR::TestRunner::platformName):
1266         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm: Removed.
1267         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm.
1268         (WTR::TestRunner::platformInitialize):
1269         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
1270         (WTR::waitUntilDoneWatchdogTimerFired):
1271         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1272         (WTR::TestRunner::pathToLocalResource):
1273         (WTR::TestRunner::platformName):
1274         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: Removed.
1275         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp.
1276         (WTR::WatchdogTimerHelper::timerFired):
1277         (WTR::TestRunner::platformInitialize):
1278         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
1279         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1280         (WTR::TestRunner::pathToLocalResource):
1281         (WTR::TestRunner::platformName):
1282         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp: Removed.
1283         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp.
1284         (WTR::TestRunner::platformInitialize):
1285         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
1286         (WTR::waitToDumpWatchdogTimerFired):
1287         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1288         (WTR::TestRunner::pathToLocalResource):
1289         (WTR::TestRunner::platformName):
1290         * WebKitTestRunner/PlatformEfl.cmake:
1291         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1292         * WebKitTestRunner/win/InjectedBundle.vcproj:
1293
1294 2012-08-15  Xianzhu Wang  <wangxianzhu@chromium.org>
1295
1296         [Chromium-Android] DumpRenderTree timeouts before NRWT timeouts
1297         https://bugs.webkit.org/show_bug.cgi?id=94155
1298
1299         Reviewed by Dirk Pranke.
1300
1301         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1302         (ChromiumAndroidPort.create_driver): Force no_timeout=True
1303
1304 2012-08-15  Ryosuke Niwa  <rniwa@webkit.org>
1305
1306         Add a hyperlink to perf-o-matic from build.webkit.org/root.html
1307         https://bugs.webkit.org/show_bug.cgi?id=93749
1308
1309         Reviewed by Csaba Osztrogonác.
1310
1311         Added the hyperlink to webkit-perf.appspot.com. Also added hyperlinks to the waterfall display
1312         of performance tests.
1313
1314         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1315
1316 2012-08-15  Bruno de Oliveira Abinader  <bruno.abinader@basyskom.com>
1317
1318         [css3-text] Add CSS3 Text decoration compile flag
1319         https://bugs.webkit.org/show_bug.cgi?id=93863
1320
1321         Reviewed by Julien Chaffraix.
1322
1323         This patch handles the compile flag implementation, which will come disabled by
1324         default, thus not exposing the CSS3 text decoration features to the web, unless
1325         when explicitly enabling it with "--css3-text-decoration" build parameter.
1326
1327         * Scripts/webkitperl/FeatureList.pm:
1328         * qmake/mkspecs/features/features.pri:
1329
1330 2012-08-15  Beth Dakin  <bdakin@apple.com>
1331
1332         https://bugs.webkit.org/show_bug.cgi?id=93693
1333         [WK2] REGRESSION(125091): pixel results don't sow scrollbars 
1334         anymore
1335
1336         Reviewed by Sam Weinig.
1337
1338         Use new API WKBundlePageCreateSnapshotWithOptions().
1339         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1340         (WTR::InjectedBundlePage::dump):
1341
1342 2012-08-15  Alexey Proskuryakov  <ap@apple.com>
1343
1344         Add rfong to Bugzilla CC "contributor" list.
1345
1346         * Scripts/webkitpy/common/config/committers.py:
1347
1348 2012-08-15  Scott Graham  <scottmg@chromium.org>
1349
1350         Rename window.internals.fastMallocStatistics to mallocStatistics
1351         https://bugs.webkit.org/show_bug.cgi?id=94033
1352
1353         Reviewed by Adam Barth.
1354
1355         * GNUmakefile.am:
1356         * Scripts/webkitpy/performance_tests/perftest.py:
1357         (PerfTest):
1358         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1359         (test_run_memory_test):
1360
1361 2012-08-15  Peter Beverloo  <peter@chromium.org>
1362
1363         Fix a warning in TestWebKitAPI's MediaTime test-suite
1364         https://bugs.webkit.org/show_bug.cgi?id=94096
1365
1366         Reviewed by Adam Barth.
1367
1368         This warning is visible when building the file with certain GCC versions,
1369         including the one used by Chromium for Android. The warning is visible in
1370         the cr-android build bot output:
1371
1372         MediaTime.cpp:152: warning: this decimal constant is unsigned only in ISO C90
1373
1374         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1375         (TestWebKitAPI::TEST):
1376
1377 2012-08-15  Kevin Funk  <kevin.funk@kdab.com>
1378
1379         Fix the 'git log' call in VCSUtils.pm for Windows
1380         https://bugs.webkit.org/show_bug.cgi?id=94113
1381
1382         Reviewed by Kenneth Rohde Christiansen.
1383
1384         Failed because of invalid enquoting characters.
1385
1386         * Scripts/VCSUtils.pm:
1387
1388 2012-08-14  Gustavo Noronha Silva  <gns@gnome.org>
1389
1390         [jhbuild] move md5sum checking to update-webkit-libs-jhbuild
1391         https://bugs.webkit.org/show_bug.cgi?id=93208
1392
1393         Reviewed by Martin Robinson.
1394
1395         This change makes the md5sum check and saving be done by the script
1396         that performs the dependencies update. build-webkit no longer prefixes
1397         calls to commands with jhbuild-wrapper if jhbuild has not been
1398         bootstrapped by the developer and --update-gtk is not given.
1399
1400         * Scripts/update-webkit-libs-jhbuild:
1401         (getMD5HashForFile): moved from webkitdirs.
1402         (jhbuildConfigurationChanged): ditto.
1403         (saveJhbuildMd5): ditto.
1404         (cleanJhbuild): ditto, and changed to run jhbuild clean before removing
1405         jhbuild.
1406         * Scripts/webkitdirs.pm:
1407         (runAutogenForAutotoolsProjectIfNecessary): use jhbuildWrapperPrefixIfNeeded.
1408         (buildAutotoolsProject): ditto.
1409         (jhbuildWrapperPrefixIfNeeded): add a code branch for GTK+.
1410         (generateBuildSystemFromCMakeProject): call update-webkitefl-libs
1411         unconditionally for EFL.
1412         * jhbuild/jhbuild-wrapper:
1413         (update_webkit_libs_jhbuild): removed, jhbuild-wrapper no longer runs the
1414         update script itself
1415         (ensure_jhbuild): remove update call.
1416
1417 2012-08-15  Christophe Dumez  <christophe.dumez@intel.com>
1418
1419         [WK2] Add support for Web Intents MessagePorts
1420         https://bugs.webkit.org/show_bug.cgi?id=89072
1421
1422         Reviewed by Kenneth Rohde Christiansen.
1423
1424         Use WKBundleIntent instead of WebIntentData in
1425         WebKitTestRunner. WTR now prints the number of
1426         MessagePorts in received Web intents as
1427         expected by the following layout tests:
1428         webintents/web-intents-invoke-port.html
1429         webintents/web-intents-obj-constructor.html
1430
1431         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1432         (WTR::InjectedBundlePage::didReceiveIntentForFrame):
1433         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1434         (WTR::LayoutTestController::deliverWebIntent):
1435
1436 2012-08-14  Ryosuke Niwa  <rniwa@webkit.org>
1437
1438         Build fix after r125516. Revert the erroneous rename since we need to keep exposing
1439         layoutTestController in Chromium port as explained r124785.
1440
1441         * DumpRenderTree/chromium/TestShell.cpp:
1442         (TestShell::bindJSObjectsToWindow):
1443
1444 2012-08-14  Dan Bernstein  <mitz@apple.com>
1445
1446         fast/events/overflow-scroll-fake-mouse-move.html and fast/events/frame-scroll-fake-mouse-move.html are failing in WebKit1
1447         https://bugs.webkit.org/show_bug.cgi?id=94045
1448
1449         Reviewed by Geoff Garen.
1450
1451         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1452         (-[DumpRenderTreeWindow _hasKeyAppearance]): Added. Returns [self isKeyWindow]. This is
1453         needed now that WebView uses -_hasKeyAppearance instead of -isKeyWindow.
1454
1455 2012-08-14  Alexey Proskuryakov  <ap@apple.com>
1456
1457         [WK2] Fix some typos in MiniBrowser
1458         https://bugs.webkit.org/show_bug.cgi?id=94047
1459
1460         Reviewed by Jon Honeycutt.
1461
1462         * MiniBrowser/mac/AppDelegate.m:
1463         (didReceiveMessageFromInjectedBundle): (-[BrowserAppDelegate init]):
1464         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1465         (didReceiveMessage):
1466         (WKBundleInitialize):
1467
1468 2012-08-14  Roger Fong  <roger_fong@apple.com>
1469
1470         old-run-webkit-tests should skip all file extensions for ref tests, not just .html.
1471         https://bugs.webkit.org/show_bug.cgi?id=93904
1472
1473         Reviewed by Tim Horton.
1474
1475         old-run-webkit-tests ref test only skipped .html test.
1476         They need to skip .html, .shtml, .xml, .xhtml, .pl, .htm, .php, .svg, .mht.
1477         
1478         * Scripts/old-run-webkit-tests:
1479         (isUsedInReftest): Skip all extensions for ref tests.
1480
1481 2012-08-14  Lauro Neto  <lauro.neto@openbossa.org>
1482
1483         Convert signals/slots to Q_* macros.
1484
1485         [Qt] Use Q_SLOTS and Q_SIGNALS instead of slots and signals
1486         https://bugs.webkit.org/show_bug.cgi?id=93996
1487
1488         Reviewed by Kenneth Rohde Christiansen.
1489
1490         Change usage of keyword-conflicting 'signals' and 'slots' for
1491         Q_SIGNALS and Q_SLOTS macro.
1492
1493         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1494         (NetworkAccessManager):
1495         (WebPage):
1496         * DumpRenderTree/qt/EventSenderQt.h:
1497         (EventSender):
1498         * DumpRenderTree/qt/GCControllerQt.h:
1499         (GCController):
1500         * DumpRenderTree/qt/TestRunnerQt.h:
1501         (TestRunner):
1502         * DumpRenderTree/qt/TextInputControllerQt.h:
1503         (TextInputController):
1504         * MiniBrowser/qt/BrowserWindow.h:
1505         (BrowserWindow):
1506         * MiniBrowser/qt/MiniBrowserApplication.h:
1507         (WindowOptions):
1508         * MiniBrowser/qt/UrlLoader.h:
1509         (UrlLoader):
1510         * QtTestBrowser/cookiejar.h:
1511         (TestBrowserCookieJar):
1512         * QtTestBrowser/fpstimer.h:
1513         (FpsTimer):
1514         * QtTestBrowser/launcherwindow.h:
1515         (LauncherWindow):
1516         * QtTestBrowser/locationedit.h:
1517         (LocationEdit):
1518         * QtTestBrowser/mainwindow.h:
1519         (MainWindow):
1520         * QtTestBrowser/urlloader.h:
1521         (UrlLoader):
1522         * QtTestBrowser/webinspector.h:
1523         (WebInspector):
1524         * QtTestBrowser/webpage.h:
1525         (WebPage):
1526         * QtTestBrowser/webview.h:
1527         (WebViewGraphicsBased):
1528         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1529         (WatchdogTimerHelper):
1530         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1531         (WrapperWindow):
1532         * WebKitTestRunner/qt/main.cpp:
1533         (Launcher):
1534
1535 2012-08-14  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1536
1537         WebKitTestRunner needs layoutTestController.dumpResourceLoadCallbacks
1538         https://bugs.webkit.org/show_bug.cgi?id=42332
1539
1540         Reviewed by Kenneth Rohde Christiansen.
1541
1542         Added Resource Callbacks logging. Several aux dumping functions are added.
1543
1544         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1545         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1546         (WTR::isFileScheme):
1547         (WTR):
1548         (WTR::pathSuitableForTestResult):
1549         (WTR::urlSuitableForTestResult):
1550         (WTR::InjectedBundlePage::resetAfterTest):
1551         (WTR::dumpRequestDescriptionSuitableForTestResult):
1552         (WTR::dumpResponseDescriptionSuitableForTestResult):
1553         (WTR::dumpErrorDescriptionSuitableForTestResult):
1554         (WTR::InjectedBundlePage::didInitiateLoadForResource):
1555         (WTR::InjectedBundlePage::willSendRequestForFrame):
1556         (WTR::InjectedBundlePage::didReceiveResponseForResource):
1557         (WTR::InjectedBundlePage::didFinishLoadForResource):
1558         (WTR::InjectedBundlePage::didFailLoadForResource):
1559         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1560         (WTR::LayoutTestController::LayoutTestController):
1561         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1562         (WTR::LayoutTestController::dumpResourceLoadCallbacks):
1563         (WTR::LayoutTestController::shouldDumpResourceLoadCallbacks):
1564         (LayoutTestController):
1565
1566 2012-08-14  Alexis Menard  <alexis.menard@openbossa.org>
1567
1568         Update INdT build bot to Mountain Lion.
1569         https://bugs.webkit.org/show_bug.cgi?id=93963
1570
1571         Reviewed by Csaba Osztrogonác.
1572
1573         We updated the machine as well as the OS as the Qt port is now running
1574         on top of Qt5.
1575
1576         * BuildSlaveSupport/build.webkit.org-config/config.json:
1577
1578 2012-08-14  Peter Beverloo  <peter@chromium.org>
1579
1580         [Chromium] Remove unneeded build logic for Android
1581         https://bugs.webkit.org/show_bug.cgi?id=93962
1582
1583         Reviewed by Dimitri Glazkov.
1584
1585         The Android SDK and NDK have been checked in to the Chromium tree, which
1586         allows WebKit to leverage those as well. They will already be pulled in
1587         through a DEPS change made last week, and by not setting the ANDROID_NDK_ROOT
1588         environment variable, the envsetup.sh will set the project files up
1589         appropriately for us.
1590
1591         * Scripts/webkitdirs.pm:
1592
1593 2012-08-14  Sergio Villar Senin  <svillar@igalia.com>
1594
1595         [WK2] [GTK] Plugin tests failing in WK2 bot
1596         https://bugs.webkit.org/show_bug.cgi?id=93954
1597
1598         Reviewed by Carlos Garcia Campos.
1599
1600         Plugin tests are failing in the WK2 bot because we aren't exporting
1601         the Netscape plugin when creating the product archive.
1602
1603         * BuildSlaveSupport/built-product-archive: added TestNetscapePlugin
1604         to the list of directories to export.
1605         (archiveBuiltProduct):
1606
1607 2012-08-14  Peter Beverloo  <peter@chromium.org>
1608
1609         [Chromium] Fix apk generation for the Android platform
1610         https://bugs.webkit.org/show_bug.cgi?id=93841
1611
1612         Unreviewed build fix.
1613
1614         APK generation was broken as the configuration file assumed compilation
1615         would only occur in the Chromium tree. Pass the path to Chromium's source
1616         base directory as a property to ant.
1617
1618         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1619         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1620
1621 2012-08-14  Sergio Villar Senin  <svillar@igalia.com>
1622
1623         [GTK] REGRESSION (r122428) WebKit2APITests/TestWebKitFindController fails "next" test
1624         https://bugs.webkit.org/show_bug.cgi?id=91083
1625
1626         Reviewed by Carlos Garcia Campos.
1627
1628         Unskipped a couple of API tests that should work fine from now on.
1629
1630         * Scripts/run-gtk-tests:
1631         (TestRunner):
1632
1633 2012-08-14  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1634
1635         [NRWT] Compare results between different platforms
1636         https://bugs.webkit.org/show_bug.cgi?id=90555
1637
1638         Reviewed by Dirk Pranke.
1639
1640         * Scripts/webkitpy/layout_tests/port/base.py:
1641         (Port.baseline_search_path):
1642         (Port):
1643         (Port.compare_baseline):
1644         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1645         (parse_args):
1646
1647 2012-08-13  Ryosuke Niwa  <rniwa@webkit.org>
1648
1649         Rename LayoutTestController to TestRunner in DumpRenderTree
1650         https://bugs.webkit.org/show_bug.cgi?id=93758
1651
1652         Reviewed by Tony Chang.
1653
1654         Renamed LayoutTestController to TestRunner. For Chromium port, it's renamed to DRTTestRunner
1655         since it already has TestRunner class shared between DumpRenderTree and content_shell.
1656
1657         * DumpRenderTree/DumpRenderTree.h:
1658         * DumpRenderTree/PixelDumpSupport.cpp:
1659         * DumpRenderTree/StorageTrackerDelegate.h:
1660         * DumpRenderTree/StorageTrackerDelegate.mm:
1661         * DumpRenderTree/TestRunner.cpp:
1662         * DumpRenderTree/TestRunner.h:
1663         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1664         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1665         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1666         * DumpRenderTree/chromium/DRTTestRunner.h:
1667         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1668         * DumpRenderTree/chromium/NotificationPresenter.h:
1669         * DumpRenderTree/chromium/TestShell.cpp:
1670         * DumpRenderTree/chromium/TestShell.h:
1671         * DumpRenderTree/chromium/WebPermissions.cpp:
1672         * DumpRenderTree/chromium/WebPermissions.h:
1673         * DumpRenderTree/chromium/WebViewHost.cpp:
1674         * DumpRenderTree/chromium/WebViewHost.h:
1675         * DumpRenderTree/efl/DumpRenderTree.cpp:
1676         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1677         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1678         * DumpRenderTree/efl/EditingCallbacks.cpp:
1679         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1680         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1681         * DumpRenderTree/gtk/EditingCallbacks.cpp:
1682         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1683         * DumpRenderTree/mac/DumpRenderTree.mm:
1684         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1685         * DumpRenderTree/mac/EditingDelegate.mm:
1686         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1687         * DumpRenderTree/mac/HistoryDelegate.mm:
1688         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1689         * DumpRenderTree/mac/PolicyDelegate.h:
1690         * DumpRenderTree/mac/PolicyDelegate.mm:
1691         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1692         * DumpRenderTree/mac/TestRunnerMac.mm:
1693         * DumpRenderTree/mac/UIDelegate.mm:
1694         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1695         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1696         * DumpRenderTree/qt/TestRunnerQt.cpp:
1697         * DumpRenderTree/qt/TestRunnerQt.h:
1698         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1699         * DumpRenderTree/win/DumpRenderTree.cpp:
1700         * DumpRenderTree/win/EditingDelegate.cpp:
1701         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1702         * DumpRenderTree/win/HistoryDelegate.cpp:
1703         * DumpRenderTree/win/PolicyDelegate.h:
1704         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1705         * DumpRenderTree/win/TestRunnerWin.cpp:
1706         * DumpRenderTree/win/UIDelegate.cpp:
1707         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1708         * DumpRenderTree/wx/TestRunnerWx.cpp:
1709
1710 2012-08-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1711
1712         [GTK] String returned by g_path_get_dirname() must be freed
1713         https://bugs.webkit.org/show_bug.cgi?id=93885
1714
1715         Reviewed by Philippe Normand.
1716
1717         Fix a memory leak in GTK's DRT code.
1718
1719         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1720         (pathFromSoupURI): Free the string returned by g_path_get_dirname().
1721
1722 2012-08-14  Zan Dobersek  <zandobersek@gmail.com>
1723
1724         Unreviewed GTK build fix after r125508.
1725
1726         Do the renaming in GNUmakefile.am as well, LayoutTestController -> TestRunner.
1727
1728         * GNUmakefile.am:
1729
1730 2012-08-13  Ryosuke Niwa  <rniwa@webkit.org>
1731
1732         Rename files that declare and define LayoutTestController in DumpRenderTree
1733         https://bugs.webkit.org/show_bug.cgi?id=93899
1734
1735         Reviewed by Tony Chang.
1736
1737         Renamed files and fixed style errors.
1738
1739         * DumpRenderTree/DumpRenderTree.gypi:
1740         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1741         * DumpRenderTree/LayoutTestController.cpp: Removed.
1742         * DumpRenderTree/LayoutTestController.h: Removed.
1743         * DumpRenderTree/PixelDumpSupport.cpp:
1744         * DumpRenderTree/StorageTrackerDelegate.mm:
1745         * DumpRenderTree/TestRunner.cpp: Copied from Tools/DumpRenderTree/LayoutTestController.cpp.
1746         * DumpRenderTree/TestRunner.h: Copied from Tools/DumpRenderTree/LayoutTestController.h.
1747         (LayoutTestController):
1748         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1749         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp: Removed.
1750         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Copied from Tools/DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp.
1751         * DumpRenderTree/chromium/DRTTestRunner.cpp: Copied from Tools/DumpRenderTree/chromium/LayoutTestController.cpp.
1752         * DumpRenderTree/chromium/DRTTestRunner.h: Copied from Tools/DumpRenderTree/chromium/LayoutTestController.h.
1753         * DumpRenderTree/chromium/LayoutTestController.cpp: Removed.
1754         * DumpRenderTree/chromium/LayoutTestController.h: Removed.
1755         * DumpRenderTree/chromium/TestShell.cpp:
1756         * DumpRenderTree/chromium/TestShell.h:
1757         * DumpRenderTree/chromium/WebPermissions.cpp:
1758         * DumpRenderTree/chromium/WebViewHost.cpp:
1759         * DumpRenderTree/efl/CMakeLists.txt:
1760         * DumpRenderTree/efl/DumpRenderTree.cpp:
1761         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1762         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1763         * DumpRenderTree/efl/EditingCallbacks.cpp:
1764         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Removed.
1765         * DumpRenderTree/efl/TestRunnerEfl.cpp: Copied from Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp.
1766         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1767         * DumpRenderTree/gtk/EditingCallbacks.cpp:
1768         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Removed.
1769         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Copied from Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp.
1770         * DumpRenderTree/mac/DumpRenderTree.mm:
1771         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1772         * DumpRenderTree/mac/EditingDelegate.mm:
1773         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1774         * DumpRenderTree/mac/HistoryDelegate.mm:
1775         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Removed.
1776         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1777         * DumpRenderTree/mac/PolicyDelegate.mm:
1778         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1779         * DumpRenderTree/mac/TestRunnerMac.mm: Copied from Tools/DumpRenderTree/mac/LayoutTestControllerMac.mm.
1780         * DumpRenderTree/mac/UIDelegate.mm:
1781         * DumpRenderTree/qt/DumpRenderTree.pro:
1782         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1783         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Removed.
1784         * DumpRenderTree/qt/LayoutTestControllerQt.h: Removed.
1785         * DumpRenderTree/qt/TestRunnerQt.cpp: Copied from Tools/DumpRenderTree/qt/LayoutTestControllerQt.cpp.
1786         * DumpRenderTree/qt/TestRunnerQt.h: Copied from Tools/DumpRenderTree/qt/LayoutTestControllerQt.h.
1787         (WebCore):
1788         (LayoutTestController):
1789         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
1790         (LayoutTestController::dumpSelectionRect):
1791         (LayoutTestController::setCallCloseOnWebViews):
1792         (LayoutTestController::addDisallowedURL):
1793         (LayoutTestController::abortModal):
1794         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1795         * DumpRenderTree/win/DumpRenderTree.cpp:
1796         * DumpRenderTree/win/DumpRenderTree.vcproj:
1797         * DumpRenderTree/win/EditingDelegate.cpp:
1798         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1799         * DumpRenderTree/win/HistoryDelegate.cpp:
1800         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Removed.
1801         * DumpRenderTree/win/PolicyDelegate.cpp:
1802         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1803         * DumpRenderTree/win/TestRunnerWin.cpp: Copied from Tools/DumpRenderTree/win/LayoutTestControllerWin.cpp.
1804         (LayoutTestController::setUserStyleSheetEnabled):
1805         (resolveCygwinPath):
1806         * DumpRenderTree/win/UIDelegate.cpp:
1807         * DumpRenderTree/wscript:
1808         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1809         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Removed.
1810         * DumpRenderTree/wx/TestRunnerWx.cpp: Copied from Tools/DumpRenderTree/wx/LayoutTestControllerWx.cpp.
1811
1812 2012-08-13  Alex Christensen  <alex.christensen@flexsim.com>
1813
1814         Windows 64 bit compliance
1815         https://bugs.webkit.org/show_bug.cgi?id=93275
1816
1817         Reviewed by Brent Fulgham.
1818
1819         Fixed a few compile and link problems for Win64
1820
1821         * WinLauncher/WinLauncher.cpp:
1822         * win/DLLLauncher/DLLLauncherMain.cpp:
1823
1824 2012-08-13  MORITA Hajime  <morrita@google.com>
1825
1826         Unreviewed update for webcomponents-bugzilla address.
1827
1828         * Scripts/webkitpy/common/config/committers.py:
1829
1830 2012-08-11  Raphael Kubo da Costa  <rakuco@webkit.org>
1831
1832         [CMake] Rewrite FindLibSoup2.cmake.
1833         https://bugs.webkit.org/show_bug.cgi?id=93191
1834
1835         Reviewed by Rob Buis.
1836
1837         * DumpRenderTree/efl/CMakeLists.txt: Use LIBSOUP_FOO instead of
1838         LIBSOUP24_FOO, and do not use LIBSOUP24_LDFLAGS, as it is not
1839         needed anymore.
1840         * EWebLauncher/CMakeLists.txt: Ditto.
1841         * MiniBrowser/efl/CMakeLists.txt: Ditto.
1842         * TestWebKitAPI/PlatformEfl.cmake: Ditto.
1843         * WebKitTestRunner/CMakeLists.txt: Ditto.
1844         * WebKitTestRunner/PlatformEfl.cmake: Ditto.
1845
1846 2012-08-13  Brady Eidson  <beidson@apple.com>
1847
1848         With asynchronous plug-in initialization, WebProcess and PluginProcess can deadlock
1849         <rdar://problem/12062125> and https://bugs.webkit.org/show_bug.cgi?id=93894
1850
1851         Reviewed by Alexey Proskuryakov.
1852
1853         Add a test that calls out to NPP_Evaluate for some JS inside of NPP_New.
1854
1855         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1856         * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSWithinNPP_New.cpp: Added.
1857         (EvaluteJSWithinNPP_New):
1858         (EvaluteJSWithinNPP_New::EvaluteJSWithinNPP_New):
1859         (EvaluteJSWithinNPP_New::NPP_New):
1860
1861 2012-08-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1862
1863         Unreviewed, rolling out r125422.
1864         http://trac.webkit.org/changeset/125422
1865         https://bugs.webkit.org/show_bug.cgi?id=93902
1866
1867         Broke the Android canary build (Requested by fmalita on
1868         #webkit).
1869
1870         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1871         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1872
1873 2012-08-13  Raphael Kubo da Costa  <rakuco@webkit.org>
1874
1875         [CMake] Remove glib-related Find modules and write single new one instead.
1876         https://bugs.webkit.org/show_bug.cgi?id=93786
1877
1878         Reviewed by Rob Buis.
1879
1880         * DumpRenderTree/efl/CMakeLists.txt: Use GLIB_* instead of Glib_*.
1881         * EWebLauncher/CMakeLists.txt: Ditto.
1882         * MiniBrowser/efl/CMakeLists.txt: Ditto.
1883         * WebKitTestRunner/PlatformEfl.cmake: Ditto.
1884
1885 2012-08-13  Peter Beverloo  <peter@chromium.org>
1886
1887         [Chromium] Fix apk generation for the Android platform
1888         https://bugs.webkit.org/show_bug.cgi?id=93841
1889
1890         Reviewed by Dimitri Glazkov.
1891
1892         APK generation was broken as the configuration file assumed compilation
1893         would only occur in the Chromium tree. Pass the path to Chromium's source
1894         base directory as a property to ant.
1895
1896         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1897         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1898
1899 2012-08-13  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1900
1901         [WK2] [WTR] InjectedBundlePage::didFailLoadForResource invokes wrong callback
1902         https://bugs.webkit.org/show_bug.cgi?id=93825
1903
1904         Reviewed by Antonio Gomes.
1905
1906         Corrected from didFinishLoadForResource() invoke to didFailLoadForResource() invoke. 
1907
1908         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1909         (WTR::InjectedBundlePage::didFailLoadForResource):
1910
1911 2012-08-13  Kwang Yul Seo  <skyul@company100.net>
1912
1913         [Qt] Add gprof.prf to build WebKit with gprof enabled
1914         https://bugs.webkit.org/show_bug.cgi?id=90283
1915
1916         Reviewed by Eric Seidel.
1917
1918         * qmake/mkspecs/features/functions.prf:
1919         gprof does not support profiling a shared library.
1920         To profile WebKit, applications must link QtWebKit statically.
1921
1922         * qmake/mkspecs/features/gprof.prf: Added.
1923         Add -pg option to both QMAKE_CXXFLAGS and QMAKE_LFLAGS.
1924
1925 2012-08-13  KwangYong Choi  <ky0.choi@samsung.com>
1926
1927         [TestNetscapePlugin][X11] Additional key up event handler routine is required
1928         https://bugs.webkit.org/show_bug.cgi?id=91357
1929
1930         Reviewed by Eric Seidel.
1931
1932         Fixed key up event handler routine to pass http/tests/plugins/plugin-document-
1933         has-focus.html on X11 architecture. The test can not be done without this patch.
1934         All other ports implemented it already.
1935
1936         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1937         (handleEventX11): Modified key up event handler for X11
1938
1939 2012-08-13  Christophe Dumez  <christophe.dumez@intel.com>
1940
1941         [EFL][WK2] Replace Skipped list by TestExpectations
1942         https://bugs.webkit.org/show_bug.cgi?id=93796
1943
1944         Reviewed by Kenneth Rohde Christiansen.
1945
1946         Enable cascaded TestExpectations for EFL port so
1947         that we can use TestExpectations in WK2-EFL.
1948
1949         * Scripts/webkitpy/layout_tests/port/efl.py:
1950         (EflPort._search_paths):
1951         (EflPort):
1952         (EflPort.expectations_files):
1953
1954 2012-08-13  Peter Gal  <galpeter@inf.u-szeged.hu>
1955
1956         REGRESSION(r125153): It broke the 'Unexpected no expected results' case
1957         https://bugs.webkit.org/show_bug.cgi?id=93789
1958
1959         Reviewed by Csaba Osztrogonác.
1960
1961         Fix the regex, so the text won't be a capturing group.
1962
1963         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1964         (RunWebKitTests._parseNewRunWebKitTestsOutput):
1965
1966 2012-08-12  MORITA Hajime  <morrita@google.com>
1967
1968         Unreviewed, added a proxy address to contributors_who_are_not_committers.
1969
1970         * Scripts/webkitpy/common/config/committers.py:
1971
1972 2012-08-12  Loïc Yhuel  <loic.yhuel@softathome.com>
1973
1974         [Qt] Make it possible to build without QtTest/QtPrintSupport
1975         https://bugs.webkit.org/show_bug.cgi?id=93492
1976
1977         Reviewed by Tor Arne Vestbø.
1978
1979         * DumpRenderTree/qt/DumpRenderTree.pro: Optional printsupport
1980         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1981         (WebCore):
1982         (WebCore::DumpRenderTree::dryRunPrint): Does nothing if no printsupport
1983         * QtTestBrowser/QtTestBrowser.pro: Optional printsupport
1984         * QtTestBrowser/launcherwindow.cpp:
1985         (LauncherWindow::createChrome): No print menu if no printsupport
1986         (LauncherWindow::print): Does nothing if no printsupport
1987         * QtTestBrowser/launcherwindow.h:
1988         * Tools.pro: Disable DRT/WTR if QtTest not present
1989         * qmake/mkspecs/features/default_pre.prf: printsupport no more mandatory
1990         * qmake/mkspecs/features/features.prf: Qt module availability tests
1991
1992 2012-08-12  Csaba Osztrogonác  <ossy@webkit.org>
1993
1994         master.cfg unittest cleanup: Show DeprecationWarnings with python >= 2.7 too
1995         https://bugs.webkit.org/show_bug.cgi?id=90161
1996
1997         Reviewed by Eric Seidel.
1998
1999         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2000
2001 2012-08-12  Simon Hausmann  <simon.hausmann@nokia.com>
2002
2003         [Qt] Unreviewed trivial build fix: Newer Qt versions don't implicitly include qwindowsysteminterface.h
2004         through the QTestLib headers anymore.
2005
2006         * DumpRenderTree/qt/EventSenderQt.cpp:
2007         * WebKitTestRunner/Target.pri:
2008         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
2009
2010 2012-08-11  Sam Weinig  <sam@webkit.org>
2011
2012         Remove ability to run MiniBrowser in threaded mode, it hasn't worked for a long time
2013         https://bugs.webkit.org/show_bug.cgi?id=93774
2014
2015         Reviewed by Dan Bernstein.
2016
2017         Remove support for opening windows using the shared thread WKContextRef. WKContextGetSharedThreadContext()
2018         is going away, due to not working for a long time, and the first step is removing all the callers.
2019
2020         While here, remove the BrowserStatisticsWindow, which was not providing interesting information.
2021
2022         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2023         * MiniBrowser/mac/AppDelegate.h:
2024         * MiniBrowser/mac/AppDelegate.m:
2025         (-[BrowserAppDelegate init]):
2026         (-[BrowserAppDelegate newWindow:]):
2027         (-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):
2028         * MiniBrowser/mac/BrowserStatisticsWindow.xib: Removed.
2029         * MiniBrowser/mac/BrowserStatisticsWindowController.h: Removed.
2030         * MiniBrowser/mac/BrowserStatisticsWindowController.m: Removed.
2031         * MiniBrowser/mac/MainMenu.xib:
2032         * MiniBrowser/win/BrowserView.cpp:
2033         (BrowserView::create):
2034
2035 2012-08-11  Sam Weinig  <sam@webkit.org>
2036
2037         Enable XPC Service based WebProcess with runtime flag
2038         https://bugs.webkit.org/show_bug.cgi?id=93773
2039
2040         Reviewed by Dan Bernstein.
2041
2042         Convert --use-web-process-xpc-service passed to run-safari (and similar scripts)
2043         to setting WEBKIT_USE_XPC_SERVICE_FOR_WEB_PROCESS=YES in the environment and setting
2044         up __XPC_DYLD_FRAMEWORK_PATH and __XPC_DYLD_INSERT_LIBRARIES variables. NOTE: using
2045         the XPC service is not the default code path.
2046
2047         * Scripts/webkitdirs.pm:
2048         (shouldUseXPCServiceForWebProcess):
2049         (determineShouldUseXPCServiceForWebProcess):
2050         Add functions to extract --use-web-process-xpc-service from ARGV and set a
2051         global variable.
2052
2053         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded):
2054         Add help text for --use-web-process-xpc-service.
2055
2056         (runMacWebKitApp):
2057         Set the WEBKIT_USE_XPC_SERVICE_FOR_WEB_PROCESS environment variable and DYLD
2058         if --use-web-process-xpc-service was passed on the command line.
2059
2060         (execMacWebKitAppForDebugging):
2061         Set the WEBKIT_USE_XPC_SERVICE_FOR_WEB_PROCESS environment variable and DYLD
2062         if --use-web-process-xpc-service was passed on the command line. Also, bail
2063         if both --use-web-process-xpc-service and --target-web-process are passed on
2064         the command line, as we don't currently support using both.
2065
2066 2012-08-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2067
2068         [EFL] Bump harfbuzz dependency to v0.9.2
2069         https://bugs.webkit.org/show_bug.cgi?id=93762
2070
2071         Reviewed by Eric Seidel.
2072
2073         EFL port has used harfbuzz 0.9.0 ver. However, the 0.9.2 version was released on 10th Aug 2012.
2074         In addition, 0.9.0 ver. was disappeared. So, EFL port needs to use 0.9.2 ver. from now on.
2075
2076         * efl/jhbuild.modules:
2077
2078 2012-08-10  Ryosuke Niwa  <rniwa@webkit.org>
2079
2080         run-perf-tests should upload memory statistics to perf-o-matic
2081         https://bugs.webkit.org/show_bug.cgi?id=93690
2082
2083         Reviewed by Dirk Pranke.
2084
2085         Upload JS Heap and FastMalloc results for a test X/Y as: X/Y:JSHeap and X/Y:FastMalloc.
2086         Note "JS Heap" is converted to the CamelCase JSHeap.
2087
2088         Also did some refactoring in PerfTest.parse_output and PerfTestRunnerTest and updated
2089         some helps in PerfTest.parse_output per arv's comments.
2090
2091         * Scripts/webkitpy/performance_tests/perftest.py:
2092         (PerfTest):
2093         (PerfTest.parse_output): Include JSHeap and FastMalloc statistics in results as well as of Time.
2094         Also refactored it to avoid hard-coding indices in _result_classes and moved complied regular
2095         exressions out of the function to avoid re-compiling them every time the method runs.
2096         (PerfTest.output_statistics): Convert ':' to ': ' as well as '/'.
2097         (ChromiumStylePerfTest.parse_output): Removed an unused variable.
2098         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2099         (PerfTestsRunner._parse_args): Uploaded some helps per arv's feedback.
2100         (PerfTestsRunner._output_json_path): Extracted from _generate_and_show_results to be used in
2101         PerfTestRunnerTest.create_runner.
2102         (PerfTestsRunner._generate_and_show_results):
2103         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2104         (create_runner): Extracted runner.load_output_json from various tests.
2105         (test_run_memory_test): Added.
2106         (PerfTestRunner): Extracted _event_target_wrapper_and_inspector_results from various tests.
2107         (test_run_with_json_output):
2108         (test_run_with_description):
2109         (test_run_generates_json_by_default):
2110         (test_run_generates_and_show_results_page):
2111         (test_run_with_json_source):
2112         (test_run_with_multiple_repositories):
2113
2114 2012-08-10  Benjamin Poulain  <bpoulain@apple.com>
2115
2116         Add support for String initialization from literal to WTFString
2117         https://bugs.webkit.org/show_bug.cgi?id=93426
2118
2119         Reviewed by Anders Carlsson.
2120
2121         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2122         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2123         (TestWebKitAPI::TEST):
2124         * TestWebKitAPI/Tests/WTF/WTFString.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/StringImpl.cpp.
2125         (TestWebKitAPI):
2126         (TestWebKitAPI::TEST):
2127
2128 2012-08-10  Xianzhu Wang  <wangxianzhu@chromium.org>
2129
2130         NRWT crashes when DRT with --encode-binary crashes just before it dumps pixels
2131         https://bugs.webkit.org/show_bug.cgi?id=93728
2132
2133         Reviewed by Dirk Pranke.
2134
2135         * Scripts/webkitpy/layout_tests/port/driver.py:
2136         (ContentBlock.decode_content): Check self.content is not None before calling base64.b64decode().
2137
2138 2012-08-10  Xianzhu Wang  <wangxianzhu@chromium.org>
2139
2140         [Chromium-Android][NRWT] Executable might not be pushed correctly when there are multiple builds
2141         https://bugs.webkit.org/show_bug.cgi?id=93688
2142
2143         Reviewed by Dirk Pranke.
2144
2145         There might be other better methods, but this change is the smallest.
2146         I think the chance of equal timestamp can be ignored because we flock
2147         to avoid concurrent linkers.
2148
2149         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2150         (ChromiumAndroidDriver._push_executable): Changed '<' to '!=' to compare the timestamp.
2151
2152 2012-08-09  Xianzhu Wang  <wangxianzhu@chromium.org>
2153
2154         [Chromium-Android] Skip layout tests directories that are not applicable
2155         https://bugs.webkit.org/show_bug.cgi?id=93670
2156
2157         Reviewed by Dirk Pranke.
2158
2159         Added back ChromiumAndroidPort.skipped_layout_tests to skip some whole directories.
2160         The method is more convenient to skip whole directories than SKIP in TestExpectations
2161         because its higher priority. Will still use TestExpectations to skip individual tests.
2162
2163         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2164         (ChromiumAndroidPort.skipped_layout_tests):
2165
2166 2012-08-09  Elliott Sprehn  <esprehn@chromium.org>
2167
2168         Add myself to the Contributor list.
2169         https://bugs.webkit.org/show_bug.cgi?id=93653
2170
2171         Reviewed by Dirk Pranke.
2172
2173         Add my email to the contributor list.
2174
2175         * Scripts/webkitpy/common/config/committers.py:
2176
2177 2012-08-09  Dirk Pranke  <dpranke@chromium.org>
2178
2179         nrwt: should log progress like ninja does
2180         https://bugs.webkit.org/show_bug.cgi?id=93563
2181
2182         Reviewed by Ojan Vafai.
2183
2184         This change modifies the output of nrwt in the
2185         non--debug-rwt-logging modes.
2186
2187         In non-verbose mode, the output changes from:
2188           "Testing (50%): 96 ran as expected, 4 didn't, 100 left"
2189         to:
2190           "[100/200] foo.html (+4)"
2191         or:
2192           "[100/200] foo.html failed  unexpectedly (text diff)"
2193
2194         which indicates the earliest test currently running (optionally plus the
2195         count of other currently-executing tests if we're running tests in parallel)
2196         or the result of said test.
2197
2198         If the test produces unexpected results, that line is flushed
2199         rather than erased (so we no longer need the %d didn't running
2200         tally).
2201
2202         In --verbose mode, the output is similar, but every test gets a
2203         line (and tests are logged in order of them being started, not
2204         order of them being completed) (and in --details mode, the
2205         first line of each test matches --verbose but the other lines
2206         are unchanged).
2207         
2208         The overall result should be easier to read and is simpler to
2209         implement as well (apart from managing the number of tests that
2210         have started but not completed, which is slightly annoying).
2211
2212         This also matches the output style for test-webkitpy, more-or-less.
2213
2214         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2215         (LayoutTestRunner.run_tests):
2216         (LayoutTestRunner._update_summary_with_result):
2217         (LayoutTestRunner._handle_started_test):
2218         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
2219         (FakePrinter):
2220         (FakePrinter.print_started_test):
2221         (FakePrinter.print_finished_test):
2222         * Scripts/webkitpy/layout_tests/views/printing.py:
2223         (Printer.__init__):
2224         (Printer.print_started_test):
2225         (Printer.print_finished_test):
2226         (Printer._print_test_trace):
2227         (Printer._print_progress):
2228         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2229         (test_details):
2230
2231 2012-08-09  Alexey Proskuryakov  <ap@apple.com>
2232
2233         [WK2] Add a process model constant for multiple processes
2234         https://bugs.webkit.org/show_bug.cgi?id=93642
2235
2236         Reviewed by Anders Carlsson.
2237
2238         * MiniBrowser/mac/AppDelegate.h: Updated process model enum to match WebKit.
2239
2240 2012-08-09  Ryosuke Niwa  <rniwa@webkit.org>
2241
2242         Build fix after r125178.
2243
2244         * Scripts/webkitpy/performance_tests/perftest.py:
2245         (PerfTest.parse_output): Don't include non-time results in the JSON output.
2246         * Scripts/webkitpy/performance_tests/perftest_unittest.py: Updated the test outputs so to match
2247         actual test outputs.
2248         (MainTest.test_parse_output):
2249         (MainTest.test_parse_output_with_failing_line):
2250         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: Ditto.
2251
2252 2012-08-09  Zoltan Horvath  <zoltan@webkit.org>
2253
2254         JSHeap and FastMallocStatistics based memory measurement for performance-tests
2255         https://bugs.webkit.org/show_bug.cgi?id=90858
2256
2257         Reviewed by Ryosuke Niwa.
2258
2259         Measure the memory usage of the performancetests with the help of the windows.memory.usedJSHeapSize
2260         object and the window.internals.fastMallocStatistics() function call.
2261
2262         * Scripts/webkitpy/performance_tests/perftest.py:
2263         (PerfTest):
2264         (PerfTest.parse_output):
2265         (PerfTest.output_statistics):
2266
2267 2012-08-09  Csaba Osztrogonác  <ossy@webkit.org>
2268
2269         [Qt][Win] Build system bug revealed by r124835
2270         https://bugs.webkit.org/show_bug.cgi?id=93339
2271
2272         Reviewed by Tor Arne Vestbø.
2273
2274         Don't add "LC_ALL=c" on Windows in svnRevisionForDirectory() and in pathRelativeToSVNRepositoryRootForPath().
2275
2276         * Scripts/VCSUtils.pm:
2277         (isWindows): Copied from webkitdirs.pm.
2278         (svnRevisionForDirectory):
2279         (pathRelativeToSVNRepositoryRootForPath):
2280
2281 2012-08-08  Dirk Pranke  <dpranke@chromium.org>
2282
2283         update bot parsing of new-run-webkit-tests' output
2284         https://bugs.webkit.org/show_bug.cgi?id=93537
2285
2286         Reviewed by Ryosuke Niwa.
2287
2288         This change updates the way we parse the output from
2289         new-run-webkit-tests on the bots so that we can show a summary
2290         of the results properly after I re-land the changes that were
2291         reverted in r124994 and r124870.
2292
2293         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2294         (RunWebKitTests._parseNewRunWebKitTestsOutput):
2295
2296 2012-08-08  Shane Stephens  <shanestephens@google.com>
2297
2298         Compile flag for CSS Hierarchies
2299         https://bugs.webkit.org/show_bug.cgi?id=92433
2300
2301         Reviewed by Tony Chang.
2302
2303         * Scripts/webkitperl/FeatureList.pm:
2304         * qmake/mkspecs/features/features.pri:
2305
2306 2012-08-08  Benjamin Poulain  <bpoulain@apple.com>
2307
2308         Use char* instead of LChar* for the public interface of String construction from literals
2309         https://bugs.webkit.org/show_bug.cgi?id=93402
2310
2311         Reviewed by Michael Saboff.
2312
2313         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2314         (TestWebKitAPI::TEST):
2315
2316 2012-08-08  Dirk Pranke  <dpranke@chromium.org>
2317
2318         nrwt: rename finder.py to layout_test_finder.py
2319         https://bugs.webkit.org/show_bug.cgi?id=93557
2320
2321         Reviewed by Ryosuke Niwa.
2322
2323         One last cleanup per old review feedback from rniwa.
2324
2325         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py: Renamed from Tools/Scripts/webkitpy/layout_tests/controllers/finder.py.
2326         (LayoutTestFinder):
2327         (LayoutTestFinder.__init__):
2328         (LayoutTestFinder.find_tests):
2329         (LayoutTestFinder._strip_test_dir_prefixes):
2330         (LayoutTestFinder._strip_test_dir_prefix):
2331         (LayoutTestFinder._read_test_names_from_file):
2332         (LayoutTestFinder._strip_comments):
2333         (LayoutTestFinder.skip_tests):
2334         (LayoutTestFinder.split_into_chunks):
2335         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2336
2337 2012-08-08  Ryosuke Niwa  <rniwa@webkit.org>
2338
2339         Add Perf EWS IRC bot
2340         https://bugs.webkit.org/show_bug.cgi?id=92913
2341
2342         Reviewed by Dirk Pranke.
2343
2344         Adds the preliminary implementation of perfalizer, a IRC bot that runs performance tests
2345         based on IRC requests.
2346
2347         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2348         (MockSCM.head_svn_revision): The actual implementation returns string, so match that.
2349         (MockSCM.svn_revision): Ditto.
2350         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2351         (Bugzilla.add_attachment_to_bug): Added mimetype.
2352         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
2353         (MockBugzilla.add_attachment_to_bug): Ditto.
2354         * Scripts/webkitpy/common/system/filesystem.py:
2355         (FileSystem.copytree): Added.
2356         * Scripts/webkitpy/common/system/filesystem_mock.py:
2357         (MockFileSystem.copytree): Added.
2358         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: Rebaselined tests
2359         that had assumed revision numbers were integers.
2360         (test_run_with_json_output):
2361         (test_run_with_description):
2362         (test_run_generates_json_by_default):
2363         (test_run_generates_and_show_results_page):
2364         (test_run_with_json_source):
2365         (test_run_with_multiple_repositories):
2366         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2367         * Scripts/webkitpy/tool/commands/__init__.py:
2368         * Scripts/webkitpy/tool/commands/perfalizer.py: Added.
2369         (PerfalizerTask):
2370         (PerfalizerTask.__init__):
2371         (PerfalizerTask._copy_build_product_without_patch):
2372         (PerfalizerTask.run):
2373         (PerfalizerTask.parent_command):
2374         (PerfalizerTask.run_webkit_patch):
2375         (PerfalizerTask._json_path):
2376         (PerfalizerTask._results_page_path):
2377         (PerfalizerTask._run_perf_test):
2378         (PerfalizerTask.run_command):
2379         (PerfalizerTask.command_passed):
2380         (PerfalizerTask.command_failed):
2381         (PerfalizerTask.refetch_patch):
2382         (PerfalizerTask.expected_failures):
2383         (PerfalizerTask.build_style):
2384         (PerfTest): IRC command.
2385         (PerfTest.execute):
2386         (Perfalizer): IRC bot.
2387         (Perfalizer.begin_work_queue):
2388         (Perfalizer.work_item_log_path):
2389         (Perfalizer._is_old_failure):
2390         (Perfalizer.next_work_item):
2391         (Perfalizer.process_work_item):
2392         (Perfalizer.handle_unexpected_error):
2393         (Perfalizer.handle_script_error):
2394         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py: Added.
2395         (PerfalizerTaskTest):
2396         (PerfalizerTaskTest._create_and_run_perfalizer):
2397         (PerfalizerTaskTest._create_and_run_perfalizer.logger):
2398         (PerfalizerTaskTest._create_and_run_perfalizer.run_webkit_patch):
2399         (PerfalizerTaskTest._create_and_run_perfalizer.run_perf_test):
2400         (PerfalizerTaskTest.test_run):
2401         (PerfalizerTaskTest.test_run_with_clean_fails):
2402         (PerfalizerTaskTest.test_run_with_update_fails):
2403         (PerfalizerTaskTest.test_run_with_build_fails):
2404         (PerfalizerTaskTest.test_run_with_perf_test_fails):
2405         (PerfalizerTaskTest.test_run_without_results_page):
2406         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2407         (AbstractPatchQueueTest.test_upload_results_archive_for_patch): Rebaselined.
2408         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2409         (test_attach_to_bug): Ditto.
2410         (test_attach_to_bug_no_description_or_comment): Ditto.
2411
2412 2012-08-08  Dirk Pranke  <dpranke@chromium.org>
2413
2414         webkit-patch rebaseline-expectations needs to support multiple expectations files
2415         https://bugs.webkit.org/show_bug.cgi?id=89051
2416
2417         Reviewed by Adam Barth.
2418
2419         fixed the bug described above, added unit test in
2420         test_expectations_unittest, and updated the tool tests
2421         to not contain all of the "missing skia expectations" warnings.
2422
2423         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2424         (TestExpectations.remove_rebaselined_tests):
2425         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
2426         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2427         (RebaseliningTest.assertRemove):
2428         (RebaseliningTest.test_remove):
2429         * Scripts/webkitpy/tool/commands/rebaseline.py:
2430         (RebaselineExpectations._update_expectations_files):
2431         (RebaselineExpectations.execute):
2432         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2433         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
2434         (test_rebaseline_expectations):
2435
2436 2012-08-08  Alexey Proskuryakov  <ap@apple.com>
2437
2438         [WK2] MiniBrowser crashes on quit if any windows were previously closed
2439         https://bugs.webkit.org/show_bug.cgi?id=93529
2440
2441         Reviewed by John Sullivan.
2442
2443         * MiniBrowser/mac/AppDelegate.h:
2444         * MiniBrowser/mac/AppDelegate.m:
2445         (-[BrowserAppDelegate init]):
2446         (-[BrowserAppDelegate newWindow:]):
2447         (-[BrowserAppDelegate browserWindowWillClose:]):
2448         (-[BrowserAppDelegate applicationWillTerminate:]):
2449         (-[BrowserAppDelegate frontmostBrowserWindowController]):
2450         Track browser windows explicitly, not relying on [NSApp windows]. Closed windows
2451         are not automatically removed from the list until deallocated, so a refcounting
2452         error can result in working on a closed window.
2453
2454         * MiniBrowser/mac/BrowserWindowController.m:
2455         (-[BrowserWindowController dealloc]): Moved code from -windowWillClose: here.
2456         Releasing data members is -dealloc's job.
2457         (-[BrowserWindowController windowWillClose:]): Notify BrowserAppDelegate that
2458         the window is no longer open. Autorelease self, making sure that WKView and
2459         then WebPageProxy get released.
2460         (-[BrowserWindowController applicationTerminating]): Don't release _webView.pageRef.
2461         WKView is responsible for its lifetime.
2462         (closePage): Ditto.
2463
2464 2012-08-08  Xianzhu Wang  <wangxianzhu@chromium.org>
2465
2466         [Chromium-Android] Apply all Linux layout test expectations
2467         https://bugs.webkit.org/show_bug.cgi?id=92653
2468
2469         Reviewed by Adam Barth.
2470
2471         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2472         (ChromiumAndroidPort.skipped_layout_tests): Removed. Skip these tests in TestExpectations instead.
2473
2474 2012-08-08  Josh Hawn  <jhawn@apple.com>
2475
2476         Add MountainLion WebKit Bots.
2477         https://bugs.webkit.org/show_bug.cgi?id=93417
2478
2479         Reviewed by Stephanie Lewis.
2480
2481         Mountain Lion is now available, so we've added the appropriate Apple bots,
2482         mirroring the configuration of the Lion bots.
2483
2484         * BuildSlaveSupport/build.webkit.org-config/config.json:
2485         Added 10 "apple-mini-###" slaves.
2486         Added MountainLion Builders and Schedulers.
2487
2488 2012-08-08  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2489
2490         [WK2] Coding style violation was brought with r125031
2491         https://bugs.webkit.org/show_bug.cgi?id=93503
2492
2493         Reviewed by Alexey Proskuryakov.
2494
2495         WKURLResponseCopyMimeType is corrected to WKURLResponseCopyMIMEType.
2496
2497         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2498         (WTR::InjectedBundlePage::didReceiveResponseForResource):
2499         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2500         (WTR::LayoutTestController::dumpProgressFinishedCallback): Removed trailing whitespace that was brought with the same revision.
2501
2502 2012-08-08  Peter Beverloo  <peter@chromium.org>
2503
2504         Buildmaster changes in preparation of a Chromium Android tester
2505         https://bugs.webkit.org/show_bug.cgi?id=92251
2506
2507         Reviewed by Adam Barth.
2508
2509         Slightly update the build master's configuration in preparation of adding
2510         a Chromium Android tester.
2511
2512         The change in built-product-archive is required as the out/ directory
2513         for Android has a number of unstripped .so binaries and unaligned APKs,
2514         causing the default release.zip file to be 2.7 gigabytes. By excluding
2515         these file types, the file is only 59.7 megabytes. We can't disable
2516         them for all of Chromium, as Mac and Linux do use their .so files.
2517
2518         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2519         (ArchiveBuiltProduct): Pass the full platform name instead of just the
2520             generic type, i.e. chromium-android instead of chromium.
2521         (ExtractBuiltProduct): Dito, stay consistent for this script.
2522         (RunUnitTests): Pass --chromium-android as well as --chromium. Since we
2523             now read the full platform name, stay on the safe side with 'win'
2524             even though there (as far as I know) is no win-* platform.
2525         (RunChromiumWebKitUnitTests): Dito. The platform wasn't being passed
2526             at all, but we'll be needing different handling here.
2527         (unitTestsSupported): Next to refactoring work required, as we'll be
2528             running this test on a device, there is no reason to disable this
2529             in the master's configuration.
2530         * BuildSlaveSupport/built-product-archive:
2531         (main): Determine the generic platform.
2532         (archiveBuiltProduct): Use an identical set of ignorePatterns, but
2533             extend the list with .so, .pak and -unaligned.apk for Android.
2534
2535 2012-08-08  Adam Barth  <abarth@webkit.org>
2536
2537         Unreviewed. Stop running tests on the mac-ews while we wait for more
2538         hardware. As requested by lforschler.
2539
2540         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2541
2542 2012-08-08  Peter Beverloo  <peter@chromium.org>
2543
2544         The cr-android EWS should actually be building Chromium for Android
2545         https://bugs.webkit.org/show_bug.cgi?id=93489
2546
2547         Reviewed by Adam Barth.
2548
2549         The cr-android EWS bots should be building Chromium for Android, which
2550         requires some additional flags to Chromium's default configuration.
2551
2552         * Scripts/webkitdirs.pm:
2553         (buildChromium):
2554         * Scripts/webkitpy/common/config/ports.py:
2555         (DeprecatedPort.port):
2556         (ChromiumAndroidPort):
2557         (ChromiumAndroidPort.update_webkit_command):
2558         (ChromiumAndroidPort.build_webkit_command):
2559         * Scripts/webkitpy/common/config/ports_unittest.py:
2560         (DeprecatedPortTest.test_chromium_android_port):
2561         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2562         (ChromiumAndroidEWS):
2563         * Scripts/webkitpy/tool/steps/update_unittest.py:
2564         (UpdateTest.test_update_command_non_interactive):
2565         (UpdateTest.test_update_command_interactive):
2566
2567 2012-08-08  Alexey Proskuryakov  <ap@apple.com>
2568
2569         [WK2] MiniBrowser crashes on window.open()
2570         https://bugs.webkit.org/show_bug.cgi?id=93413
2571
2572         Reviewed by Dan Bernstein.
2573
2574         * MiniBrowser/mac/BrowserWindowController.m: (createNewPage): This is a "create"
2575         API, so it needs to return a retained result.
2576
2577         * MiniBrowser/mac/WebBundle/WebBundleMain.m: (didClearWindowObjectForFrame):
2578         When this function is called, URL appears to be poorly defined. Sometimes, it's
2579         the new URL, other times it's the old one. An "old" URL is null in a new page.
2580
2581 2012-08-08  Loïc Yhuel  <loic.yhuel@softathome.com>
2582
2583         [Qt] Compile errors with OpenGLES2
2584         https://bugs.webkit.org/show_bug.cgi?id=93206
2585
2586         Reviewed by Noam Rosenthal.
2587
2588         Fix build with OpenGLES2 on Linux desktop
2589
2590         * qmake/mkspecs/features/features.prf: Don't use GLX with OpenGLES2
2591
2592 2012-08-08  Peter Beverloo  <peter@chromium.org>
2593
2594         Introduce cr-android bots in the EWS system
2595         https://bugs.webkit.org/show_bug.cgi?id=93472
2596
2597         Reviewed by Adam Barth.
2598
2599         This adds the queue to the EWS scripts. Two builders are ready to be
2600         attached to the queue. All webkitpy tests pass with this change applied.
2601
2602         * QueueStatusServer/model/queues.py:
2603         (Queue):
2604         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2605         (ChromiumAndroidEWS):
2606         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2607         (EarlyWarningSytemTest.test_builder_ewses):
2608
2609 2012-08-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2610
2611         Unreviewed. Fix GTK+ build with GTK2 after r121475.
2612
2613         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp: Add missing
2614         include required when building with GTK2.
2615
2616 2012-08-08  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2617
2618         [WK2] [WTR] Provide Resource Response dumping.
2619         https://bugs.webkit.org/show_bug.cgi?id=93454
2620
2621         Reviewed by Kenneth Rohde Christiansen.
2622
2623         Added missing dumpResourceResponseMIMETypes() method to testRunner. Provided resource response dumping.
2624
2625         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2626         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2627         (WTR::InjectedBundlePage::didReceiveResponseForResource):
2628         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2629         (WTR::LayoutTestController::LayoutTestController):
2630         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2631         (WTR::LayoutTestController::dumpProgressFinishedCallback):
2632         (WTR::LayoutTestController::dumpResourceResponseMIMETypes):
2633         (WTR::LayoutTestController::shouldDumpResourceResponseMIMETypes):
2634         (LayoutTestController):
2635
2636 2012-08-08  Simon Hausmann  <simon.hausmann@nokia.com>
2637
2638         [Qt][Win] Fix compilation of DumpRenderTree
2639         https://bugs.webkit.org/show_bug.cgi?id=93461
2640
2641         Reviewed by Tor Arne Vestbø.
2642
2643         DRT includes stdint.h, for which we have wrappers in Source/JavaScriptCore/os-win32. Use these not only
2644         for libraries but any building template.
2645
2646         * qmake/mkspecs/features/default_post.prf:
2647
2648 2012-08-08  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2649
2650         [WK2] [WTR] Refactoring: LayoutTestController::shouldDumpProgressFinishedCallback() should be const
2651         https://bugs.webkit.org/show_bug.cgi?id=93457
2652
2653         Reviewed by Csaba Osztrogonác.
2654
2655         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2656         (WTR::LayoutTestController::shouldDumpProgressFinishedCallback): Added constness.
2657
2658 2012-08-07  Csaba Osztrogonác  <ossy@webkit.org>
2659
2660         Unreviewed typo fix after r124988.
2661
2662         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2663         (TestExpectations):
2664
2665 2012-08-07  YoungTaeck Song  <youngtaeck.song@samsung.com>
2666
2667         [WK2][EFL] Implement accelerated compositing on WK2 Efl port
2668         https://bugs.webkit.org/show_bug.cgi?id=89840
2669
2670         Reviewed by Noam Rosenthal.
2671
2672         Implement accelerated composition with TiledBackingStore on WK2 Efl port.
2673         Add OPENGL_LIBRARIES in CMakeList.txt.
2674
2675         * MiniBrowser/efl/CMakeLists.txt:
2676         * WebKitTestRunner/PlatformEfl.cmake:
2677
2678 2012-08-07  Csaba Osztrogonác  <ossy@webkit.org>
2679
2680         [NRWT] REGRESSION(r124967): New tests without expected results handled as failures
2681         https://bugs.webkit.org/show_bug.cgi?id=93434
2682
2683         Reviewed by Tony Chang.
2684
2685         Change back "missing results" to "no expected result found", because master.cfg's results parser expects it.
2686
2687         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2688         (TestExpectations):
2689
2690 2012-08-07  Csaba Osztrogonác  <ossy@webkit.org>
2691
2692         buildbot: Remove the configuration of hfreyther*
2693         https://bugs.webkit.org/show_bug.cgi?id=91849
2694
2695         Unreviewed typo fix after r123757.
2696
2697         * BuildSlaveSupport/build.webkit.org-config/config.json:
2698
2699 2012-08-07  Dirk Pranke  <dpranke@chromium.org>
2700
2701         REGRESSION: PrettyPatchTest.test_pretty_diff_encodings has been failing on Chromium Windows
2702         https://bugs.webkit.org/show_bug.cgi?id=93192
2703
2704         Unreviewed, build fix.
2705
2706         Disabling the test for now as PrettyPatch is just broken on win32.
2707
2708         * Scripts/webkitpy/common/prettypatch_unittest.py:
2709         (test_pretty_diff_encodings):
2710
2711 2012-08-07  Dirk Pranke  <dpranke@chromium.org>
2712
2713         [NRWT] Would like an output mode similar to ORWT verbose one
2714         https://bugs.webkit.org/show_bug.cgi?id=88702
2715
2716         Reviewed by Ryosuke Niwa.
2717
2718         Change the --verbose logging for new-run-webkit-tests so that
2719         it matches ORWT more; we just print one line per test. Use
2720         --debug-rwt-logging to get the full debug stream (aka old ORWT
2721         --verbose).
2722
2723         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2724         (TestExpectations):
2725         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2726         (_set_up_derived_options):
2727         (parse_args):
2728         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2729         (MainTest.test_retrying_and_flaky_tests):
2730         * Scripts/webkitpy/layout_tests/views/printing.py:
2731         (print_options):
2732         (Printer._print_result_summary_entry):
2733         (Printer._print_one_line_summary):
2734         (Printer._print_test_result):
2735         (Printer._print_baseline):
2736         (Printer._print_unexpected_results):
2737
2738 2012-08-07  Dirk Pranke  <dpranke@chromium.org>
2739
2740         nrwt: handle errors from image diff better
2741         https://bugs.webkit.org/show_bug.cgi?id=92934
2742
2743         Reviewed by Ojan Vafai.
2744
2745         Re-land the change in r124801 with a fix ... in the case where
2746         the ImageDiff is passed a tolerance and passes the fuzzy check,
2747         we were returning the wrong value (missing an empty error
2748         string) and crashing; this patch fixes that and adds a test for
2749         that case (TestImageDiffer.test_image_diff_passed).
2750
2751         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2752         (SingleTestRunner._compare_image):
2753         (SingleTestRunner._compare_output_with_reference):
2754         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2755         (write_test_result):
2756         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
2757         (TestResultWriterTest.test_reftest_diff_image.ImageDiffTestPort.diff_image):
2758         (TestResultWriterTest):
2759         * Scripts/webkitpy/layout_tests/port/base.py:
2760         (Port.diff_image):
2761         * Scripts/webkitpy/layout_tests/port/chromium.py:
2762         (ChromiumPort.diff_image):
2763         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
2764         (ChromiumPortTestCase.test_diff_image_crashed):
2765         * Scripts/webkitpy/layout_tests/port/image_diff.py:
2766         (ImageDiffer.diff_image):
2767         (ImageDiffer._read):
2768         * Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:
2769         (TestImageDiffer.test_diff_image):
2770         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2771         (MockDRTPortTest.test_diff_image_crashed):
2772         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2773         (PortTestCase.test_diff_image):
2774         (PortTestCase.test_diff_image_crashed):
2775         (PortTestCase.test_diff_image_crashed.make_proc):
2776         * Scripts/webkitpy/layout_tests/port/server_process_mock.py:
2777         (MockServerProcess.__init__):
2778         * Scripts/webkitpy/layout_tests/port/test.py:
2779         (TestPort.diff_image):
2780         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2781         (MainTest.test_tolerance.ImageDiffTestPort.diff_image):
2782
2783 2012-08-07  Dirk Pranke  <dpranke@chromium.org>
2784
2785         nrwt: --no-build isn't working
2786         https://bugs.webkit.org/show_bug.cgi?id=93415
2787
2788         Reviewed by Ryosuke Niwa.
2789
2790         Turns out our optimization to avoid calling
2791         webkit-build-directory N times for each worker broke --no-build.
2792
2793         Fixing, and adding a test.
2794
2795         Also, the gtk port wasn't using the default check_build() logic,
2796         but I don't know why not. Removing their custom hook and will
2797         verify that this is okay in the review ...
2798
2799         * Scripts/webkitpy/layout_tests/port/base.py:
2800         (Port.__init__):
2801         (Port.check_build):
2802         (Port._build_path):
2803         * Scripts/webkitpy/layout_tests/port/gtk.py:
2804         (GtkPort._path_to_image_diff):
2805         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2806         (MockDRTPortTest.test_check_build):
2807         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2808         (test_path_to_apache_config_file):
2809         (test_check_build):
2810         (test_check_build.build_driver_called):
2811
2812 2012-08-07  Ryosuke Niwa  <rniwa@webkit.org>
2813
2814         run-perf-tests should support --no-show-results
2815         https://bugs.webkit.org/show_bug.cgi?id=93409
2816
2817         Reviewed by Dirk Pranke.
2818
2819         Add the support for --no-show-results.
2820
2821         Also replace only local paths to jquery and flot instead of embedding them.
2822         The results page is still standalone in that it tries to load scripts
2823         from both webkit.org and local filesystem.
2824
2825         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2826         (PerfTestsRunner._parse_args):
2827         (PerfTestsRunner.run):
2828         (PerfTestsRunner._generate_and_show_results):
2829         (PerfTestsRunner._generate_output_files):
2830         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2831         (create_runner_and_setup_results_template):
2832         (test_run_generates_and_show_results_page):
2833         (test_run_respects_no_show_results):
2834
2835 2012-08-07  Dirk Pranke  <dpranke@chromium.org>
2836
2837         test-webkitpy hangs in a new checkout on snow leopard
2838         https://bugs.webkit.org/show_bug.cgi?id=93301
2839
2840         Reviewed by Ryosuke Niwa.
2841
2842         This change works around what appears to be a bug in Python
2843         2.6.1 (the version that ships on Mac Snow Leopard) that causes
2844         the multiprocessing module to hang after we use the
2845         autoinstaller; I'm guessing it's some sort of python sockets
2846         issue. I was unable to reproduce this with 2.6.5 or newer
2847         versions of Python.
2848
2849         * Scripts/webkitpy/common/system/autoinstall.py:
2850         (AutoInstaller.install):
2851         * Scripts/webkitpy/test/main.py:
2852         (Tester._run_tests):
2853         * Scripts/webkitpy/thirdparty/__init__.py:
2854         (AutoinstallImportHook._install_mechanize):
2855         (AutoinstallImportHook._install_pep8):
2856         (AutoinstallImportHook._install_pylint):
2857         (AutoinstallImportHook._install_buildbot):
2858         (AutoinstallImportHook._install_coverage):
2859         (AutoinstallImportHook._install_eliza):
2860         (AutoinstallImportHook._install_irc):
2861         (AutoinstallImportHook._install_webpagereplay):
2862         (AutoinstallImportHook._install):
2863         (autoinstall_everything):
2864
2865 2012-08-07  Xianzhu Wang  <wangxianzhu@chromium.org>
2866
2867         [Chromium-Android][NRWT] Fix 2 FIXMEs in chromium_android.py
2868         https://bugs.webkit.org/show_bug.cgi?id=93381
2869
2870         Reviewed by Adam Barth.
2871
2872         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2873         (ChromiumAndroidDriver.__init__):
2874         (ChromiumAndroidDriver._push_executable): Remove temporary lines as the chromium change has been landed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150371
2875         (ChromiumAndroidDriver._setup_performance): Update all scaling governor files.
2876         (ChromiumAndroidDriver._teardown_performance): Update all scaling governor files.
2877
2878 2012-08-07  W. James MacLean  <wjmaclean@chromium.org>
2879
2880         [chromium] Add support to DumpRenderTree [EventSender] for GestureTapDown events.
2881         https://bugs.webkit.org/show_bug.cgi?id=93286
2882
2883         Reviewed by James Robinson.
2884
2885         Adds support to generate GestureTapDown events from EventSender, to facilitate
2886         link highlighting layout tests.
2887  
2888         Added a GestureTapEvent to one existing test, more tests to follow when LinkHighlight CLs start to land.
2889
2890         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
2891         (EventSender::EventSender):
2892         (EventSender::gestureTapDown):
2893         (EventSender::gestureEvent):
2894         * DumpRenderTree/chromium/TestRunner/EventSender.h:
2895         (EventSender):
2896
2897 2012-08-07  Marcelo Lira  <marcelo.lira@openbossa.org>
2898
2899         [Qt] Add support for the Gamepad API
2900         https://bugs.webkit.org/show_bug.cgi?id=90637
2901
2902         Reviewed by Alexis Menard.
2903
2904         If the libudev library is present, the GAMEPAD flag is
2905         turned on by default for the Qt port.
2906
2907         * Scripts/webkitperl/FeatureList.pm:
2908         * qmake/mkspecs/features/features.prf:
2909
2910 2012-08-07  Rob Buis  <rbuis@rim.com>
2911
2912         [BlackBerry] Turn on CSS Variables
2913         https://bugs.webkit.org/show_bug.cgi?id=93376
2914
2915         Reviewed by Antonio Gomes.
2916
2917         Turn on CSS Variables for BlackBerry port.
2918
2919         * Scripts/webkitperl/FeatureList.pm:
2920
2921 2012-08-07  No'am Rosenthal  <noam.rosenthal@nokia.com>
2922
2923         [Qt] Make it possible to build without QtQuick
2924
2925         Reviewed by Simon Hausmann.
2926
2927         * Tools.pro:
2928         * qmake/mkspecs/features/features.prf:
2929
2930 2012-08-02  Simon Hausmann  <simon.hausmann@nokia.com>
2931
2932         [Qt] Remove Qt 4 specific code paths
2933         https://bugs.webkit.org/show_bug.cgi?id=88161
2934
2935         Reviewed by Kenneth Rohde Christiansen.
2936
2937         * DumpRenderTree/qt/DumpRenderTree.pro:
2938         * DumpRenderTree/qt/EventSenderQt.cpp:
2939         (EventSender::touchCancel):
2940         (EventSender::sendTouchEvent):
2941         * DumpRenderTree/qt/EventSenderQt.h:
2942         (EventSender):
2943         * DumpRenderTree/qt/ImageDiff.pro:
2944         * DumpRenderTree/qt/main.cpp:
2945         (main):
2946         * QtTestBrowser/QtTestBrowser.pro:
2947         * QtTestBrowser/cookiejar.cpp:
2948         (TestBrowserCookieJar::TestBrowserCookieJar):
2949         * QtTestBrowser/launcherwindow.cpp:
2950         (LauncherWindow::setDiskCache):
2951         * qmake/configure.pri:
2952         * qmake/mkspecs/features/default_post.prf:
2953         * qmake/mkspecs/features/default_pre.prf:
2954         * qmake/mkspecs/features/features.prf:
2955         * qmake/mkspecs/features/functions.prf:
2956         * qmake/mkspecs/features/qtwebkit.prf: Removed.
2957         * qmake/mkspecs/features/unix/default_pre.prf:
2958
2959 2012-08-07  Andras Becsi  <andras.becsi@nokia.com>
2960
2961         [Qt][WK2] MiniBrowser should only synthesize multiple touch points if Ctrl is pressed
2962         https://bugs.webkit.org/show_bug.cgi?id=93277
2963
2964         Reviewed by Jocelyn Turcotte.
2965
2966         MiniBrowser's multi-touch mocking does not check if Ctrl is pressed
2967         when registering multiple touch points based on pressed mouse buttons
2968         and sends inconsistent touch events to the WebView which triggers an
2969         assert in the pinch gesture recognizer.
2970         MiniBrowserApplication::updateTouchPoint should only register multiple
2971         touch points if the Ctrl button is pressed else it should ignore the
2972         update request.
2973
2974         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2975         (MiniBrowserApplication::updateTouchPoint):
2976
2977 2012-08-07  Csaba Osztrogonác  <ossy@webkit.org>
2978
2979         REGRESSION(r124800): It broke NRWT result parsing of build.webkit.org
2980         https://bugs.webkit.org/show_bug.cgi?id=93346
2981
2982         Rubber-stamped by Simon Hausmann.
2983
2984         Change back "unexpected" to "Unexpected", because master.cfg's results parser expects it.
2985
2986         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2987         (MainTest.test_retrying_and_flaky_tests):
2988         * Scripts/webkitpy/layout_tests/views/printing.py:
2989         (Printer._print_unexpected_results):
2990
2991 2012-08-06  Balazs Kelemen  <kbalazs@webkit.org>
2992
2993         [NRWT] runs platform specific tests that it shouldn't with --force
2994         https://bugs.webkit.org/show_bug.cgi?id=91089
2995
2996         Reviewed by Dirk Pranke.
2997
2998         Ignore other platform's directories from platform/.
2999
3000         * Scripts/webkitpy/layout_tests/port/base.py:
3001         (Port._expanded_paths):
3002         * Scripts/webkitpy/layout_tests/port/test.py:
3003         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3004         (MainTest.test_platform_tests_are_found):
3005         Updated integration test in accordance to the new behavior.
3006
3007 2012-08-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3008
3009         [EFL] Enable link prefetch
3010         https://bugs.webkit.org/show_bug.cgi?id=93281
3011
3012         Reviewed by Kentaro Hara.
3013
3014         * Scripts/webkitperl/FeatureList.pm: Enable LINK_PREFETCH feature.
3015
3016 2012-08-06  Sheriff Bot  <webkit.review.bot@gmail.com>
3017
3018         Unreviewed, rolling out r124801.
3019         http://trac.webkit.org/changeset/124801
3020         https://bugs.webkit.org/show_bug.cgi?id=93338
3021
3022         It broke NRWT (Requested by Ossy on #webkit).
3023
3024         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3025         (SingleTestRunner._compare_image):
3026         (SingleTestRunner._compare_output_with_reference):
3027         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3028         (write_test_result):
3029         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
3030         (TestResultWriterTest.test_reftest_diff_image.ImageDiffTestPort.diff_image):
3031         (TestResultWriterTest):
3032         * Scripts/webkitpy/layout_tests/port/base.py:
3033         (Port.diff_image):
3034         * Scripts/webkitpy/layout_tests/port/chromium.py:
3035         (ChromiumPort.diff_image):
3036         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
3037         (ChromiumPortTestCase.test_diff_image):
3038         * Scripts/webkitpy/layout_tests/port/image_diff.py:
3039         (ImageDiffer.diff_image):
3040         (ImageDiffer._read):
3041         * Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:
3042         (TestImageDiffer.test_diff_image):
3043         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3044         (MockDRTPortTest.test_diff_image):
3045         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3046         (PortTestCase.test_diff_image):
3047         * Scripts/webkitpy/layout_tests/port/server_process_mock.py:
3048         (MockServerProcess.__init__):
3049         * Scripts/webkitpy/layout_tests/port/test.py:
3050         (TestPort.diff_image):
3051         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3052         (MainTest.test_tolerance.ImageDiffTestPort.diff_image):
3053
3054 2012-08-06  Wei James  <james.wei@intel.com>
3055
3056         [Chromium]duplicated command line options in Android LayoutTest
3057         https://bugs.webkit.org/show_bug.cgi?id=93233
3058
3059         Reviewed by Tony Chang.
3060
3061         Duplicated options found in Android layout test command line:
3062         --encode-binary and --enable-hardware-gpu.
3063
3064         If there are multiple ChromiumAndroidPort instances,
3065         these two options will be appended for multiple times.
3066
3067         * Scripts/webkitpy/layout_tests/port/base.py:
3068         (Port.additional_drt_flag):
3069         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3070         (ChromiumAndroidPort.__init__):
3071         (ChromiumAndroidPort.additional_drt_flag):
3072         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3073         (ChromiumAndroidTwoPortsTest):
3074         (ChromiumAndroidTwoPortsTest.test_options_with_two_ports):
3075         * Scripts/webkitpy/layout_tests/port/driver.py:
3076         (Driver.cmd_line):
3077
3078 2012-08-03  Brady Eidson  <beidson@apple.com>
3079
3080         Out-of-process plug-ins should support asynchronous initialization
3081         <rdar://problem/10598594> and https://bugs.webkit.org/show_bug.cgi?id=92919
3082
3083         Reviewed by Anders Carlsson.
3084
3085         Add a plug-in with an NPP_New that takes 550ms (a reasonable trade-off between a solid test and a slow running test)
3086         for testing asynchronous plug-in initialization.
3087
3088         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3089         * DumpRenderTree/TestNetscapePlugIn/Tests/SlowNPPNew.cpp: Copied from Source/WebKit2/Shared/Plugins/PluginProcessCreationParameters.h.
3090         (SlowNPPNew):
3091         (SlowNPPNew::SlowNPPNew):
3092         (SlowNPPNew::NPP_New):
3093
3094 2012-08-06  Xianzhu Wang  <wangxianzhu@chromium.org>
3095
3096         [Chromium-Android] Virtual test suites fail
3097         https://bugs.webkit.org/show_bug.cgi?id=92515
3098
3099         Reviewed by Dirk Pranke.
3100
3101         The failure is because our bypassing of DriverProxy.
3102         Repeat the logic of virtual tests in DriverProxy in ChromiumAndroidDriver
3103         and restart DRT when the command line changes.
3104
3105         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3106         (ChromiumAndroidDriver.__init__):
3107         (ChromiumAndroidDriver.cmd_line): Added comments about why we override this and have _drt_cmd_line().
3108         (ChromiumAndroidDriver.run_test): Repeat the logic of virtual tests in DriverProxy.
3109         (ChromiumAndroidDriver.start): Restart DRT when the command line changes.
3110         (ChromiumAndroidDriver._start_once):
3111
3112 2012-08-06  Xianzhu Wang  <wangxianzhu@chromium.org>
3113
3114         Remove NRWT --shard-ref-tests
3115         https://bugs.webkit.org/show_bug.cgi?id=91539
3116
3117         This is basically a revert of "[Chromium-Android] Run ref tests together to avoid expensive driver restarts"
3118         (https://bugs.webkit.org/show_bug.cgi?id=91533, http://trac.webkit.org/changeset/122914),
3119         with some conflicts resolved (because of refactory of Manager/LayoutTestRunner/Sharder classes).
3120
3121         Reviewed by Dirk Pranke.
3122
3123         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3124         (LayoutTestRunner.run_tests):
3125         (Sharder.shard_tests):
3126         (Sharder._shard_in_two):
3127         (Sharder._shard_by_directory):
3128         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
3129         (SharderTests):
3130         (SharderTests.get_test_input):
3131         (SharderTests.get_shards):
3132         (SharderTests.test_shard_by_dir):
3133         (SharderTests.test_shard_in_two):
3134         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3135         (Manager._test_input_for_file):
3136         (Manager._test_is_slow):
3137         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3138         (ChromiumAndroidPort.__init__):
3139         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3140         (parse_args):
3141
3142 2012-08-06  Luciano Wolf  <luciano.wolf@openbossa.org>
3143
3144         [Qt] Default sizes for input-text and text-area are different when running DRT/WTR
3145         https://bugs.webkit.org/show_bug.cgi?id=91990
3146
3147         Reviewed by Kenneth Rohde Christiansen.
3148
3149         Initializing TestFonts information into WTR binary. Doing it 
3150         later leads to wrong font names usage (Dejavu Serif instead
3151         of Liberation Serif).
3152
3153         * WebKitTestRunner/Target.pri:
3154         * WebKitTestRunner/qt/main.cpp:
3155         (main):
3156
3157 2012-08-06  Jeff Timanus  <twiz@chromium.org>
3158
3159         Add twiz@{chromium|google}.org to the set of non-committer contributors.
3160         https://bugs.webkit.org/show_bug.cgi?id=93288
3161
3162         Reviewed by Adam Barth.
3163
3164         * Scripts/webkitpy/common/config/committers.py:
3165
3166 2012-08-06  Adam Barth  <abarth@webkit.org>
3167
3168         REGRESSION(124789): EWS errors out because --print option is missing
3169         https://bugs.webkit.org/show_bug.cgi?id=93299
3170
3171         Unreviewed.
3172
3173         The --print option doesn't exist anymore.  Let's try --quiet instead.
3174
3175         * Scripts/webkitpy/tool/steps/runtests.py:
3176         (RunTests.run):
3177         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3178
3179 2012-08-06  Ryosuke Niwa  <rniwa@webkit.org>
3180
3181         run-webkit-tests should have ability to add description to its JSON output
3182         https://bugs.webkit.org/show_bug.cgi?id=93296
3183
3184         Reviewed by Dirk Pranke.
3185
3186         Add --description option.
3187
3188         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3189         (PerfTestsRunner._parse_args):
3190         (PerfTestsRunner._generate_and_show_results):
3191         (PerfTestsRunner._generate_results_dict):
3192         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3193         (test_run_with_description):
3194
3195 2012-08-06  Dirk Pranke  <dpranke@chromium.org>
3196
3197         nrwt: handle errors from image diff better
3198         https://bugs.webkit.org/show_bug.cgi?id=92934
3199
3200         Reviewed by Ojan Vafai.
3201
3202         Currently if ImageDiff crashes, returns a weird exit code, or
3203         produces any stderr output, it's basically swallowed. This
3204         change ensures that we log errors to stderr, and also appends
3205         the error to the stderr for the test (so it'll show up in
3206         results.html).
3207
3208         Most importantly, it'll cause diff_image() to fail and we'll
3209         report ImageHashMismatch ... this may be kinda untrue, but I
3210         think it's better than ignoring the error.
3211
3212         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3213         (SingleTestRunner._compare_image):
3214         (SingleTestRunner._compare_output_with_reference):
3215         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3216         (write_test_result):
3217         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
3218         (TestResultWriterTest.test_reftest_diff_image.ImageDiffTestPort.diff_image):
3219         (TestResultWriterTest):
3220         * Scripts/webkitpy/layout_tests/port/base.py:
3221         (Port.diff_image):
3222         * Scripts/webkitpy/layout_tests/port/chromium.py:
3223         (ChromiumPort.diff_image):
3224         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
3225         (ChromiumPortTestCase.test_diff_image_crashed):
3226         * Scripts/webkitpy/layout_tests/port/driver.py:
3227         (Driver.run_test):
3228         * Scripts/webkitpy/layout_tests/port/image_diff.py:
3229         (ImageDiffer.diff_image):
3230         (ImageDiffer._read):
3231         * Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:
3232         (TestImageDiffer.test_diff_image):
3233         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3234         (MockDRTPortTest.test_diff_image_crashed):
3235         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3236         (PortTestCase.test_diff_image):
3237         (PortTestCase):
3238         (PortTestCase.test_diff_image_crashed):
3239         (PortTestCase.test_diff_image_crashed.make_proc):
3240         * Scripts/webkitpy/layout_tests/port/server_process_mock.py:
3241         (MockServerProcess.__init__):
3242         * Scripts/webkitpy/layout_tests/port/test.py:
3243         (TestPort.diff_image):
3244         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3245         (MainTest.test_tolerance.ImageDiffTestPort.diff_image):
3246
3247 2012-08-06  Dirk Pranke  <dpranke@chromium.org>
3248
3249         nrwt: clean up printing.py
3250         https://bugs.webkit.org/show_bug.cgi?id=93026
3251
3252         Reviewed by Dirk Pranke.
3253
3254         This patch cleans up the implementation of printing.py now
3255         that we're not using all the original complexity.
3256
3257         There should be no changes in functionality and everything
3258         should be covered by the existing tests.
3259
3260         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3261         (LayoutTestRunner.run_tests):
3262         * Scripts/webkitpy/layout_tests/views/printing.py:
3263         (Printer.__init__):
3264         (Printer.__del__):
3265         (Printer.print_config):
3266         (Printer.print_found):
3267         (Printer.print_expected):
3268         (Printer.print_workers_and_shards):
3269         (Printer):
3270         (Printer._print_expected_results_of_type):
3271         (Printer.print_results):
3272         (Printer._print_timing_statistics):
3273         (Printer._print_aggregate_test_statistics):
3274         (Printer._print_individual_test_times):
3275         (Printer._print_test_list_timing):
3276         (Printer._print_directory_timings):
3277         (Printer._print_statistics_for_test_timings):
3278         (Printer._print_result_summary):
3279         (Printer._print_result_summary_entry):
3280         (Printer._print_one_line_summary):
3281         (Printer.print_finished_test):
3282         (Printer._print_test_result):
3283         (Printer._print_test_trace):
3284         (Printer._print_baseline):
3285         (Printer._print_unexpected_test_result):
3286         (Printer._print_progress):
3287         (Printer._print_unexpected_results):
3288         (Printer._print_unexpected_results.add_result):
3289         (Printer._print_quiet):
3290         (Printer._print_default):
3291         (Printer._print_debug):
3292         (Printer._print_for_bot):
3293         (Printer.write_update):
3294         (Printer.writeln):
3295         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3296         (Testprinter.get_printer):
3297         (Testprinter.test_print_config):
3298         (Testprinter.test_print_one_line_summary):
3299         (Testprinter.test_print_unexpected_results):
3300         (test_details):
3301
3302 2012-08-06  Dirk Pranke  <dpranke@chromium.org>
3303
3304         change bots to pass --debug-rwt-logging instead of --verbose to new-run-webkit-tests
3305         https://bugs.webkit.org/show_bug.cgi?id=93043
3306
3307         Reviewed by Ryosuke Niwa.
3308
3309         in preparation for the cleanup of the logging flags in new-run-webkit-tests.
3310
3311         * Scripts/run-webkit-tests:
3312
3313 2012-08-06  Dirk Pranke  <dpranke@chromium.org>
3314
3315         nrwt: clean up logging, part 1
3316         https://bugs.webkit.org/show_bug.cgi?id=93018
3317
3318         Reviewed by Ojan Vafai.
3319
3320         remove --print, --help-printing from nrwt, add three new options:
3321         --quiet, which just logs warnings,errors, and unexpected results
3322         --debug-rwt-logging, a new name for --verbose
3323         --details, to get the old --print trace-everything behavior
3324
3325         This patch does not implement the new "one line per test"
3326         --verbose behavior specified in bug 88702, and there's a bunch
3327         of internal cleanup I can do in printing.py that I'll defer to
3328         a later patch to make things easier to review.
3329
3330         This patch deletes a lot of unit tests that are no longer
3331         necessary since there aren't so many logging combinations.
3332
3333         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3334         (run):
3335         (main):
3336         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3337         (parse_args):
3338         (passing_run):
3339         (StreamTestingMixin.assertContains):
3340         (MainTest.test_child_processes_2):
3341         (MainTest.test_child_processes_min):
3342         (MainTest.test_full_results_html):
3343         (MainTest.test_no_tests_found):
3344         (MainTest.test_no_tests_found_2):
3345         (MainTest.test_repeat_each_iterations_num_tests):
3346         (MainTest.test_additional_platform_directory):
3347         (RebaselineTest.assertBaselines):
3348         * Scripts/webkitpy/layout_tests/views/printing.py:
3349         (print_options):
3350         (Printer.__init__):
3351         (Printer.enabled):
3352         (Printer.print_unexpected_results):
3353         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3354         (TestUtilityFunctions.test_print_options):
3355         (Testprinter.get_result_summary):
3356         (Testprinter.test_configure_and_cleanup):
3357         (Testprinter.test_print_config):
3358         (Testprinter.test_print_one_line_summary):
3359         (Testprinter.test_print_unexpected_results):
3360         (test_details):
3361         (test_default):
3362         (test_quiet):
3363         (test_verbose):
3364
3365 2012-08-06  Xianzhu Wang  <wangxianzhu@chromium.org>
3366
3367         [Chromium-Android] Store test executable, data and fonts in /data/local/tmp
3368         https://bugs.webkit.org/show_bug.cgi?id=91910
3369
3370         /data/local/tmp is a directory with permission 0777 by default.
3371         Place DumpRenderTree resources here so that both the native test app and
3372         the NRWT script can access them even if adb shell isn't running as root.
3373
3374         Reviewed by Adam Barth.
3375
3376         * DumpRenderTree/chromium/TestShellAndroid.cpp:
3377         (createFIFO): Set fifo mode to 0666 to allow unrooted adb shell to access.
3378         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3379         (ChromiumAndroidPort.driver_cmd_line):
3380         (ChromiumAndroidDriver.__init__):
3381         (ChromiumAndroidDriver._setup_test):
3382         (ChromiumAndroidDriver._push_executable):
3383         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3384         (ChromiumAndroidPortTest.make_port):
3385         (ChromiumAndroidPortTest.test_expectations_files):
3386         (ChromiumAndroidDriverTest.test_drt_cmd_line):
3387
3388 2012-08-06  Abhishek Arya  <inferno@chromium.org>
3389
3390         [Chromium] Re-expose layoutTestController as various fuzzers depend on it
3391         https://bugs.webkit.org/show_bug.cgi?id=93282
3392
3393         Reviewed by Ryosuke Niwa.
3394
3395         Unfortunately, various fuzzers used in the Chromium project still depends on
3396         window.layoutTestController. Re-expose the object while they're making the transition.
3397
3398         * DumpRenderTree/chromium/TestShell.cpp:
3399         (TestShell::bindJSObjectsToWindow):
3400
3401 2012-08-06  Balazs Kelemen  <kbalazs@webkit.org>
3402
3403         WTR should be able to load external resources
3404         https://bugs.webkit.org/show_bug.cgi?id=89382
3405
3406         Reviewed by Ryosuke Niwa.
3407
3408         Allow to load an external resource as the main frame
3409         and allow all subsequent external loads for such a main
3410         frame. This behavior is necessary for being able to run
3411         performance tests (https://bugs.webkit.org/show_bug.cgi?id=84008).
3412
3413         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3414         (WTR::isLocalHost):
3415         (WTR):
3416         (WTR::isHTTPOrHTTPSScheme):
3417         (WTR::InjectedBundlePage::willSendRequestForFrame):
3418
3419 2012-08-06  Balazs Kelemen  <kbalazs@webkit.org>
3420
3421         [WK2] REGRESSION(124596) lot of web process unresponsiveness appears on Apple bots
3422         https://bugs.webkit.org/show_bug.cgi?id=93120
3423
3424         Reviewed by Csaba Osztrogonác.
3425
3426         Set the short timeout back to 15 seconds and add more time to WebKitTestRunner
3427         so it will be able to detect an unresponsive web process.
3428
3429         * Scripts/webkitpy/layout_tests/port/base.py:
3430         (Port.default_timeout_ms):
3431         * WebKitTestRunner/TestController.cpp:
3432         (WTR):
3433
3434 2012-08-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3435
3436         Unreviewed. Fix make distcheck.
3437
3438         * GNUmakefile.am: Add jhbuildutils.py to EXTRA_DIST.
3439
3440 2012-08-06  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3441
3442         [EFL] EFL's LayoutTestController needs removeAllVisitedLinks implementation
3443         https://bugs.webkit.org/show_bug.cgi?id=82724
3444
3445         Reviewed by Csaba Osztrogonác.
3446
3447         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3448         (LayoutTestController::removeAllVisitedLinks):
3449
3450 2012-08-06  Mario Sanchez Prada  <msanchez@igalia.com>
3451
3452         [WK2][GTK] Implement a new spell checker API for WebKit2GTK+
3453         https://bugs.webkit.org/show_bug.cgi?id=90268
3454
3455         Reviewed by Martin Robinson.
3456
3457         Ignore WebKitTextChecker.* private files for gtk-doc.
3458
3459         * gtk/generate-gtkdoc:
3460         (get_webkit2_options):
3461
3462 2012-08-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3463
3464         Unreviewed. Roll out r124728 because of build bot test fail.
3465
3466         * Scripts/webkitpy/common/config/watchlist:
3467
3468 2012-08-05  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3469
3470         Unreviewed. Change my email address for watch list.
3471
3472         * Scripts/webkitpy/common/config/watchlist:
3473
3474 2012-08-04  Nico Weber  <thakis@chromium.org>
3475
3476         [Chromium Mac] Tests are exiting early due to failures to load missingImage.png
3477         https://bugs.webkit.org/show_bug.cgi?id=93186
3478
3479         Reviewed by Ryosuke Niwa.
3480
3481         Add missingImage.png to DumpRenderTree.app's Resource folder.
3482         Depends on http://crrev.com/150037 rolling into webkit first.
3483
3484         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3485
3486 2012-08-03  Ryosuke Niwa  <rniwa@webkit.org>
3487
3488         Stop exposing window.layoutTestController in layout tests in favor of window.testRunner
3489         https://bugs.webkit.org/show_bug.cgi?id=93173
3490
3491         Reviewed by Adam Barth.
3492
3493         Don't expose window.layoutTestController since all layout tests use window.testRunner
3494         instead of window.layoutTestController as of r124685.
3495
3496         We can safely rename classes and files to use TestRunner once this patch is landed.
3497
3498         * DumpRenderTree/LayoutTestController.cpp:
3499         (LayoutTestController::makeWindowObject):
3500         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3501         (notifyTestCompletion):
3502         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3503         (PluginTest::waitUntilDone):
3504         (PluginTest::notifyDone):
3505         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
3506         (ConvertPoint::NPP_SetWindow):
3507         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3508         (handleEventCarbon):
3509         (handleEventCocoa):
3510         (handleEventWin):
3511         * DumpRenderTree/chromium/TestShell.cpp:
3512         (TestShell::bindJSObjectsToWindow):
3513         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3514         (WebCore::DumpRenderTree::initJSObjects):
3515         * Scripts/bencher:
3516         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3517         (WTR::LayoutTestController::makeWindowObject):
3518
3519 2012-08-04  Ilya Tikhonovsky  <loislo@chromium.org>
3520
3521         Unreviewed: Web Inspector: extend instrumenting methods set in ReportMemoryUsage clang plugin
3522         Three methods addString, addVectorPtr and addInstrumentedVectorPtr were added to the list of instrumentation methods.
3523
3524         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
3525         (clang::ReportMemoryUsageConsumer::ReportMemoryUsageConsumer):
3526
3527 2012-08-03  Yaron Friedman  <yfriedman@chromium.org>
3528
3529         [Chrome-Android] - Prepare apk tests for switch to checked in SDK.
3530         https://bugs.webkit.org/show_bug.cgi?id=92931
3531
3532         Reviewed by Adam Barth.
3533
3534         Pass Android-specific gyp variables to the native test generator,
3535         avoiding any dependencies on environment variables during build time.
3536
3537         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3538         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3539
3540 2012-08-03  Rick Byers  <rbyers@chromium.org>
3541
3542         Double tap gesture should send dblclick event
3543         https://bugs.webkit.org/show_bug.cgi?id=92412
3544
3545         Reviewed by Adam Barth.
3546
3547         Enable EventSender to set the tap count on tap gesture events.  The
3548         delta X/Y parameters were not actually being used anymore (used to be
3549         used for radius information).
3550
3551         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
3552         (EventSender::gestureEvent):
3553
3554 2012-08-03  Ryosuke Niwa  <rniwa@webkit.org>
3555
3556         run-perf-tests should generate JSON output and results page by default
3557         https://bugs.webkit.org/show_bug.cgi?id=93042
3558
3559         Reviewed by Eric Seidel.
3560
3561         Generate results JSON and page named PerfTestResults.json and PerfTestResults.html by default.
3562
3563         * Scripts/webkitpy/layout_tests/port/base.py:
3564         (Port.perf_results_directory): Added.
3565         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3566         (PerfTestsRunner): Added _DEFAULT_JSON_FILENAME.
3567         (PerfTestsRunner._parse_args): Added --no-results option in the case a user doens't want to generate
3568         results JSON or results page.
3569         (PerfTestsRunner.run):
3570         (PerfTestsRunner._generate_and_show_results): Extracted from run. Set the default json file path using
3571         port's perf_results_directory and call show_results_html_file at the end if the results page is generated.
3572         (PerfTestsRunner._generate_results_dict): Renamed from _generate_output to disambiguate it from
3573         _generate_and_show_results.
3574         (PerfTestsRunner._generate_output_files): Takes results page's path instead of a boolean indicating
3575         whether results page should be generated or not.
3576         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3577         (create_runner_and_setup_results_template):
3578         (test_run_respects_results_output): Added.
3579         (test_run_generates_json_by_default): Added.
3580         (test_run_generates_and_show_results_page): Added a check to ensure show_results_html_file is called.
3581
3582 2012-08-03  Sheriff Bot  <webkit.review.bot@gmail.com>
3583
3584         Unreviewed, rolling out r124628.
3585         http://trac.webkit.org/changeset/124628
3586         https://bugs.webkit.org/show_bug.cgi?id=93155
3587
3588         Causes random crashes of DRT on Chromium bots (Requested by
3589         dimich on #webkit).
3590
3591         * DumpRenderTree/DumpRenderTree.gypi:
3592         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
3593         (MockWebKitPlatformSupport::createMediaStreamCenter):
3594         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h:
3595         (MockWebKitPlatformSupport):
3596         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
3597         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
3598         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp: Removed.
3599         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h: Removed.
3600
3601 2012-08-03  Brady Eidson  <beidson@apple.com>
3602
3603         Small part of "Out-of-process plug-ins should support asynchronous initialization."
3604         <rdar://problem/10598594> and https://bugs.webkit.org/show_bug.cgi?id=92919
3605
3606         Reviewed by Anders Carlsson.
3607
3608         * WebKitTestRunner/TestController.cpp:
3609         (WTR::TestController::resetStateToConsistentValues): Reset all preferences related to asynchronous plugin initialization.
3610
3611 2012-08-02  Jeffrey Pfau  <jpfau@apple.com>
3612
3613         Add API for enabling blanket third-party data blocking
3614         https://bugs.webkit.org/show_bug.cgi?id=93022
3615
3616         Reviewed by Anders Carlsson.
3617
3618         Added test for default setting of new third-party storage blocking API.
3619
3620         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3621         (TestWebKitAPI::TEST):
3622
3623 2012-08-03  Arvid Nilsson  <anilsson@rim.com>
3624
3625         Unreviewed, adding self to committers.py after becoming committer.
3626
3627         * Scripts/webkitpy/common/config/committers.py:
3628
3629 2012-08-03  Ádám Kallai  <kadam@inf.u-szeged.hu>
3630
3631         Limited the number of queried cached build infos in URLs used by Garden-o-matic.
3632         https://bugs.webkit.org/show_bug.cgi?id=92992.
3633
3634         Reviewed by Adam Barth.
3635
3636         I added a limit to the cached builds that are included in the URL to avoid too long URLs in Garden-o-matic.
3637
3638         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
3639         (.):
3640         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3641
3642 2012-08-03  Tommy Widenflycht  <tommyw@google.com>
3643
3644         [chromium] MediaStream API: Add MockWebRTCPeerConnectionHandler
3645         https://bugs.webkit.org/show_bug.cgi?id=93091
3646
3647         Reviewed by Adam Barth.
3648
3649