Tools/ChangeLog

   1 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
   2
   3         Revert an erroneous change.
   4
   5         * Scripts/webkitpy/tool/commands/sheriffbot.py:
   6         (SheriffBot):
   7
   8 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
   9
  10         Some build fixes for WKR and webkitbot.
  11
  12         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
  13         (IRCBotTest.test_help):
  14         * Scripts/webkitpy/tool/commands/newcommitbot.py:
  15         (Agent):
  16         (Agent.__init__):
  17         (Agent.name):
  18         (NewCommitBot):
  19         (NewCommitBot.begin_work_queue):
  20         (NewCommitBot.next_work_item):
  21         * Scripts/webkitpy/tool/commands/sheriffbot.py:
  22         (SheriffBot):
  23
  24 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
  25
  26         Teach webkitbot and WKR how to respond to yt?
  27         https://bugs.webkit.org/show_bug.cgi?id=116775
  28
  29         Reviewed by Andreas Kling.
  30
  31         * Scripts/webkitpy/tool/bot/irc_command.py:
  32         (Hi): Fixed the usage string.
  33         (Hi.execute): Made it more generic so that it works in WKR.
  34         (YouThere): Added.
  35         (YouThere.execute): Added.
  36         * Scripts/webkitpy/tool/commands/newcommitbot.py:
  37
  38 2013-05-25  Simon Fraser  <simon.fraser@apple.com>
  39
  40         Try to fix the EFL build.
  41
  42         * DumpRenderTree/efl/TestRunnerEfl.cpp:
  43         (TestRunner::setPageVisibility):
  44
  45 2013-05-25  Simon Fraser  <simon.fraser@apple.com>
  46
  47         Unprefix Page Visibility API
  48         https://bugs.webkit.org/show_bug.cgi?id=102340
  49
  50         Reviewed by Tim Horton.
  51
  52         Rename "preview" state to "unloaded" state, and adjust the tests
  53         to test for it.
  54
  55         * DumpRenderTree/mac/TestRunnerMac.mm:
  56         (TestRunner::setPageVisibility):
  57         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp:
  58         (TestWebKitAPI::setPageVisibilityStateWithEvalContinuation):
  59         (TestWebKitAPI::didRunStep2StateChangeHiddenToPrerender):
  60         (TestWebKitAPI::didRunStep3StateChangePrerenderToUnloaded):
  61         (TestWebKitAPI::didRunStep4InStateUnloaded):
  62         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.html:
  63         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
  64         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
  65         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  66         (WTR::TestRunner::setPageVisibility):
  67
  68 2013-05-24  Brent Fulgham  <bfulgham@apple.com>
  69
  70         Unreviewed build fix. Don't use new NRWT logic needed
  71         by Windows yet. Activate (and fix test) when we cut over.
  72
  73         * Scripts/webkitpy/port/driver.py:
  74         (Driver._setup_environ_for_driver):
  75         (Driver._start):
  76
  77 2013-05-24  Brent Fulgham  <bfulgham@apple.com>
  78
  79         [Windows] Expose database storage and cache locations via preferences.
  80         https://bugs.webkit.org/show_bug.cgi?id=116729
  81
  82         Reviewed by Tim Horton.
  83
  84         Update DumpRenderTree to use CFPreferences to control where WebKit
  85         stores its local databases, URL caches, etc.
  86
  87         * DumpRenderTree/win/DumpRenderTree.cpp:
  88         (libraryPathForDumpRenderTree): Added.
  89         (dllLauncherEntryPoint): Set up DRT-specific cache locations.
  90         * Scripts/webkitpy/port/base.py:
  91         (Port._driver_tempdir): Added (to allow port-specific overload).
  92         (Port._driver_tempdir_for_environment): Ditto
  93         * Scripts/webkitpy/port/driver.py:
  94         (Driver._setup_environ_for_driver): Use new overload to set
  95         environment variable.
  96         (Driver._start): Use new overload for temp directory location.
  97         * Scripts/webkitpy/port/win.py:
  98         (WinPort._driver_tempdir_for_environment): New overload to supply
  99         Windows path to DumpRenderTree environment (while still using
 100         cygwin paths for internal operations.
 101
 102 2013-05-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
 103
 104         Remove custom code for webkitAudioContext global constructor getter
 105         https://bugs.webkit.org/show_bug.cgi?id=116530
 106
 107         Reviewed by Geoffrey Garen.
 108
 109         Update EFL's DumpRenderTree to use DumpRenderTreeSupport to toggle
 110         WebAudio feature instead of public ewk_view API since that API was
 111         removed.
 112
 113         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
 114         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
 115         * DumpRenderTree/efl/TestRunnerEfl.cpp:
 116         (TestRunner::overridePreference):
 117
 118 2013-05-24  Bem Jones-Bey  <bjonesbe@adobe.com>
 119
 120         Make team.html have each contributor's area of expertise
 121         https://bugs.webkit.org/show_bug.cgi?id=116737
 122
 123         Reviewed by Benjamin Poulain.
 124
 125         * Scripts/webkitpy/common/config/contributors.json:
 126         Add expertise to each contributor, taken from http://trac.webkit.org/wiki/WebKit%20Team
 127
 128         Changed formatting of the file because the lines are getting way to
 129         long, and I generated this, so it's easier if the formatting of the
 130         file is regular.
 131
 132 2013-05-24  Simon Pena  <simon.pena@samsung.com>
 133
 134         Update WTF::Vector pretty printers
 135         https://bugs.webkit.org/show_bug.cgi?id=116719
 136
 137         Reviewed by Anders Carlsson.
 138
 139         After r148891, WTF::Vector pretty printers were left outdated, as
 140         the WTF::Vector was made to extend a VectorBuffer, instead of keeping
 141         one as a member. This patch updates the pretty printers so they work
 142         again.
 143
 144         * gdb/webkit.py:
 145         (WTFVectorPrinter.children):
 146         (WTFVectorPrinter.to_string):
 147
 148 2013-05-24  Steve Falkenburg  <sfalken@apple.com>
 149
 150         Update prepareConsistentTestingEnvironment to use a non-deprecated API.
 151         https://bugs.webkit.org/show_bug.cgi?id=116710
 152
 153         Reviewed by Mark Rowe.
 154
 155         * DumpRenderTree/mac/DumpRenderTree.mm:
 156         (prepareConsistentTestingEnvironment): Use beginActivityWithOptions instead of beginSuspensionOfSystemBehaviors.
 157
 158 2013-05-23  Lauro Neto  <lauro.neto@openbossa.org>
 159
 160         Add missing dependencies to deps script.
 161
 162         [GTK] Missing packages in install-dependencies script.
 163         https://bugs.webkit.org/show_bug.cgi?id=116632
 164
 165         Reviewed by Martin Robinson.
 166
 167         * gtk/install-dependencies:
 168
 169 2013-05-23  Brent Fulgham  <bfulgham@apple.com>
 170
 171         [Windows] Unreviewed change for NRWT support.
 172
 173         * Scripts/webkitpy/port/win.py:
 174         (WinPort.default_child_processes): Added a default implementation
 175         that limits NRWT to a single instance.
 176
 177 2013-05-23  Brent Fulgham  <bfulgham@apple.com>
 178
 179         Remove meaningless "test_uses_apache" from Python test cases.
 180         https://bugs.webkit.org/show_bug.cgi?id=38756
 181
 182         Reviewed by Ryosuke Niwa.
 183
 184         * Scripts/webkitpy/port/port_testcase.py:
 185         (PortTestCase.test_driver_cmd_line): Remove the meaningless
 186         "test_uses_apache" test case from the Python test infrastructure.
 187         It was hard-coded to true, even though not all ports use
 188         Apache.
 189
 190 2013-05-23  Brent Fulgham  <bfulgham@webkit.org>
 191
 192         [Windows] Update new-run-webkit-tests for Windows port.
 193         https://bugs.webkit.org/show_bug.cgi?id=38756
 194
 195         Reviewed by Ryosuke Niwa.
 196
 197         * Scripts/new-run-webkit-httpd:
 198         (run): Switch from 'chromium' to 'win'
 199         * Scripts/webkitpy/port/win.py:
 200         (WinPort): Add support methods for lighttpd server.
 201         (WinPort._uses_apache):
 202         (WinPort._path_to_lighttpd):
 203         (WinPort._path_to_lighttpd_modules):
 204         (WinPort._path_to_lighttpd_php):
 205
 206 2013-05-23  Patrick Gansterer  <paroga@webkit.org>
 207
 208         Make default bug links in buildbot clickable
 209         https://bugs.webkit.org/show_bug.cgi?id=116673
 210
 211         Reviewed by Ryosuke Niwa.
 212
 213         Use changecommentlink of html.WebStatus to make the links clickable.
 214
 215         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 216
 217 2013-05-22  Ryosuke Niwa  <rniwa@webkit.org>
 218
 219         REGRESSION(r150491): WebKit2.DOMWindowExtensionNoCache fails
 220         https://bugs.webkit.org/show_bug.cgi?id=116595
 221
 222         Temporarily skip this test.
 223
 224         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
 225         (TestWebKitAPI::TEST):
 226
 227 2013-05-22  Alex Christensen  <achristensen@apple.com>
 228
 229         Unreviewed.  Added myself to contributors.json.
 230
 231         * Scripts/webkitpy/common/config/contributors.json:
 232         Added myself.
 233
 234 2013-05-22  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
 235
 236         [EFL][WK2] Add sub menus to MiniBrowser
 237         https://bugs.webkit.org/show_bug.cgi?id=114728
 238
 239         Reviewed by Christophe Dumez.
 240
 241         Elementary Ctxpopup widget API does not provide support for submenu item.
 242         To implement ewk submenus in Minibrowser, Ctxpopup has to be replaced with
 243         Elementary Menu widget.
 244
 245         * MiniBrowser/efl/main.c:
 246         (_Browser_Window):
 247         (on_window_resize):
 248         (window_free):
 249         (context_menu_item_selected_cb):
 250         (context_menu_populate):
 251         (on_context_menu_show):
 252         (on_context_menu_hide):
 253         (window_create):
 254
 255 2013-05-22  Andrzej Badowski  <a.badowski@samsung.com>
 256
 257         [EFL] Add command line option to MiniBrowser to set cookies policy.
 258         https://bugs.webkit.org/show_bug.cgi?id=115028
 259
 260         Reviewed by Christophe Dumez.
 261
 262         Add command line option to MiniBrowser EFL to set cookies policy:
 263         -p parameter with value from (always, never, no-third-party) respectively (EWK_COOKIE_ACCEPT_POLICY_ALWAYS,
 264         EWK_COOKIE_ACCEPT_POLICY_NEVER, EWK_COOKIE_ACCEPT_POLICY_NO_THIRD_PARTY).
 265
 266         * MiniBrowser/efl/main.c:
 267         (elm_main):
 268
 269 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
 270
 271         REGRESSION(r150369): WebKit2WillLoadTest tests are failing
 272         https://bugs.webkit.org/show_bug.cgi?id=116585
 273
 274         Reviewed by Alexey Proskuryakov.
 275
 276         willLoadURLRequest and willLoadDataRequest require the API version 6.
 277
 278         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
 279
 280 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
 281
 282         REGRESSION(r150393): editing/inserting/typing-at-end-of-line.html fails
 283         https://bugs.webkit.org/show_bug.cgi?id=116516
 284
 285         Reviewed by Alexey Proskuryakov.
 286
 287         Reset states in DumpRenderTree. The fix for WebKitTestRunner should be implemented in the bug 116577.
 288
 289         * DumpRenderTree/mac/DumpRenderTree.mm:
 290         (createWebViewAndOffscreenWindow): Match the ordering.
 291         (resetWebViewToConsistentStateBeforeTesting): Reset text replacement states.
 292
 293 2013-05-21  Alexey Proskuryakov  <ap@apple.com>
 294
 295         <rdar://problem/13929704> [WK2] WebKitTestRunner always crashes on exit
 296         https://bugs.webkit.org/show_bug.cgi?id=116568
 297
 298         Reviewed by Anders Carlsson.
 299
 300         * WebKitTestRunner/WebNotificationProvider.cpp:
 301         (WTR::WebNotificationProvider::~WebNotificationProvider):
 302         * WebKitTestRunner/WebNotificationProvider.h:
 303         When the provider is destroyed, it should no longer be registered with the manager.
 304
 305         * WebKitTestRunner/GeolocationProviderMock.cpp:
 306         (WTR::GeolocationProviderMock::~GeolocationProviderMock):
 307         * WebKitTestRunner/GeolocationProviderMock.h:
 308         I wasn't seeing a crash here, but this code has the same issue as notification
 309         provider, so applying the same fix.
 310
 311         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
 312         Close icon database. I started seeing ASSERT(!isOpen()) in WebCore IconDatabase
 313         destructor having fixed the above.
 314
 315 2013-05-21  Commit Queue  <commit-queue@webkit.org>
 316
 317         Unreviewed, rolling out r150386 and r150397.
 318         http://trac.webkit.org/changeset/150386
 319         http://trac.webkit.org/changeset/150397
 320         https://bugs.webkit.org/show_bug.cgi?id=116572
 321
 322         Broke a test; Alex is going to try again later. (Requested by
 323         thorton on #webkit).
 324
 325         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 326         (WTR::pathSuitableForTestResult):
 327         (WTR::dumpRequestDescriptionSuitableForTestResult):
 328         (WTR::dumpResponseDescriptionSuitableForTestResult):
 329         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
 330         (WTR::InjectedBundlePage::didInitiateLoadForResource):
 331         (WTR::InjectedBundlePage::willSendRequestForFrame):
 332         (WTR::InjectedBundlePage::didReceiveResponseForResource):
 333         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
 334         (InjectedBundlePage):
 335
 336 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
 337
 338         Fix a python unittest after r149419. We need to support Python 2.6 on Windows.
 339
 340         * Scripts/webkitpy/tool/commands/suggestnominations.py:
 341         (AbstractCommitLogCommand._recent_commit_messages):
 342
 343 2013-05-21  Martin Robinson  <mrobinson@igalia.com>
 344
 345         [GTK] [CMake] Add support for building WebKit2
 346         https://bugs.webkit.org/show_bug.cgi?id=116372
 347
 348         Reviewed by Gustavo Noronha Silva.
 349
 350         * CMakeLists.txt: Do not build WebKitTestRunner yet for WebKitGTK+.
 351         * MiniBrowser/gtk/CMakeLists.txt: Added.
 352
 353 2013-05-21  Jessie Berlin  <jberlin@apple.com>
 354
 355         Revert r149635, it was too optimistic.
 356
 357         Rubber-stamped by Andreas Kling.
 358
 359         We are not at the point where we can always use more descriptive macros instead of PLATFORM()
 360         #ifdefs in WebCore code outside of WebCore/platform.
 361
 362         * Scripts/webkitpy/style/checkers/cpp.py:
 363         (check_invalid_increment):
 364         (process_line):
 365         (CppChecker):
 366         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
 367         (CppStyleTest.test_plain_integral_bitfields):
 368
 369 2013-05-21  Jer Noble  <jer.noble@apple.com>
 370
 371         Unreviewed; fix lldb synthetic representation of WTF::Vector after r148891.
 372
 373         * lldb/lldb_webkit.py:
 374         (WTFVectorProvider.num_children):
 375         (WTFVectorProvider.get_child_index):
 376         (WTFVectorProvider.get_child_at_index):
 377         (WTFVectorProvider.update):
 378
 379 2013-05-21  Jessie Berlin  <jberlin@apple.com>
 380
 381         Expose a way to know when forms are added to a page or when form controls are added to a form
 382         in the injected bundle
 383         https://bugs.webkit.org/show_bug.cgi?id=116334
 384
 385         Reviewed by Alexey Proskuryakov.
 386
 387         Add tests for the new callbacks.
 388
 389         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 390         Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
 391
 392         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
 393         (TestWebKitAPI::nullJavaScriptCallback):
 394         A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
 395         being passed in for the callback.
 396         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
 397         After receiving the message that didAssociateFormControls callback was invoked from adding
 398         the form in the onload handler, tell the page to add a password field to the form, which
 399         should also invoke didAssociateFormControls callback.
 400         (TestWebKitAPI::setInjectedBundleClient):
 401         Register to receive messages.
 402         (TestWebKitAPI::TEST):
 403         Load associate-form-controls.html and wait until the didAssociateFormControls callback has
 404         been invoked for both adding the form and for adding a password field to the form.
 405
 406         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
 407         (TestWebKitAPI::shouldNotifyOnFormChanges):
 408         Return true so the didAssociateFormControls callback is invoked.
 409         (TestWebKitAPI::didAssociateFormControls):
 410         Tell the UI process.
 411         (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
 412         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
 413         Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
 414
 415         * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
 416         Add a form in response to the onload event. Add a button that will add the password field
 417         for manual testing.
 418
 419 2013-05-21  Krzysztof Czech  <k.czech@samsung.com>
 420
 421         [GTK][WK2] accessibility/label-for-control-hittest.html is failing
 422         https://bugs.webkit.org/show_bug.cgi?id=106341
 423
 424         Reviewed by Martin Robinson.
 425
 426         Adds support for retrieving accessibility element at exact point.
 427
 428         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
 429         (WTR::AccessibilityUIElement::elementAtPoint):
 430
 431 2013-05-21  Krzysztof Czech  <k.czech@samsung.com>
 432
 433         [ATK] [WebKit2] AccessibilityUIElement often leaks its AtkObject
 434         https://bugs.webkit.org/show_bug.cgi?id=112913
 435
 436         Reviewed by Martin Robinson.
 437
 438         AccessibilityUIElement is often created by passing new reference to AtkObject (transfer full).
 439         AccessibilityUIElement::~AccessibilityUIElement does not decrement the reference of the element,
 440         so the leak appears.
 441
 442         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
 443         (WTR):
 444         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
 445         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
 446         (WTR::AccessibilityController::rootElement):
 447         (WTR):
 448         (WTR::AccessibilityController::focusedElement):
 449         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
 450         (WTR::checkElementState):
 451         (WTR::indexRangeInTable):
 452         (WTR::alterCurrentValue):
 453         (WTR::AccessibilityUIElement::getChildren):
 454         (WTR::AccessibilityUIElement::getChildrenWithRange):
 455         (WTR::AccessibilityUIElement::childrenCount):
 456         (WTR::AccessibilityUIElement::indexOfChild):
 457         (WTR::AccessibilityUIElement::titleUIElement):
 458         (WTR::AccessibilityUIElement::parentElement):
 459         (WTR::AccessibilityUIElement::allAttributes):
 460         (WTR::AccessibilityUIElement::role):
 461         (WTR::AccessibilityUIElement::title):
 462         (WTR::AccessibilityUIElement::description):
 463         (WTR::AccessibilityUIElement::orientation):
 464         (WTR::AccessibilityUIElement::stringValue):
 465         (WTR::AccessibilityUIElement::language):
 466         (WTR::AccessibilityUIElement::x):
 467         (WTR::AccessibilityUIElement::y):
 468         (WTR::AccessibilityUIElement::width):
 469         (WTR::AccessibilityUIElement::height):
 470         (WTR::AccessibilityUIElement::intValue):
 471         (WTR::AccessibilityUIElement::minValue):
 472         (WTR::AccessibilityUIElement::maxValue):
 473         (WTR::AccessibilityUIElement::isEnabled):
 474         (WTR::AccessibilityUIElement::isFocused):
 475         (WTR::AccessibilityUIElement::isSelected):
 476         (WTR::AccessibilityUIElement::isExpanded):
 477         (WTR::AccessibilityUIElement::isChecked):
 478         (WTR::AccessibilityUIElement::rowCount):
 479         (WTR::AccessibilityUIElement::columnCount):
 480         (WTR::AccessibilityUIElement::rowIndexRange):
 481         (WTR::AccessibilityUIElement::columnIndexRange):
 482         (WTR::AccessibilityUIElement::cellForColumnAndRow):
 483         (WTR::AccessibilityUIElement::increment):
 484         (WTR::AccessibilityUIElement::decrement):
 485         (WTR::AccessibilityUIElement::press):
 486         (WTR::AccessibilityUIElement::documentEncoding):
 487         (WTR::AccessibilityUIElement::documentURI):
 488         (WTR::AccessibilityUIElement::isFocusable):
 489         (WTR::AccessibilityUIElement::isSelectable):
 490         (WTR::AccessibilityUIElement::isMultiSelectable):
 491         (WTR::AccessibilityUIElement::isVisible):
 492
 493 2013-05-20  Lucas Forschler  <lforschler@apple.com>
 494
 495     Rollout 150398.
 496
 497 2013-05-20  Zan Dobersek  <zdobersek@igalia.com>
 498
 499         [GTK] Fix concatenations of string literals that are not C++11-compliant
 500         https://bugs.webkit.org/show_bug.cgi?id=116449
 501
 502         Reviewed by Martin Robinson.
 503
 504         Fix the problematic concatenations of string literals so they are compilable under the C++11 standard. This
 505         is simply a matter of separating the string and the string literal that are being concatenated with a space.
 506
 507         * ImageDiff/gtk/ImageDiff.cpp:
 508         (printImage):
 509
 510 2013-05-20  Zan Dobersek  <zdobersek@igalia.com>
 511
 512         [GTK] Pass GTEST_HAS_RTTI=0 cppflag to TestWebKitAPI programs at compilation-time
 513         https://bugs.webkit.org/show_bug.cgi?id=116450
 514
 515         Reviewed by Martin Robinson.
 516
 517         The -fno-rtti flag is used when compiling C++ source code throughout the project. The TestWebKitAPI
 518         programs fail to compile because of this when using the C++11 standard as the GTest headers assume by
 519         default that the RTTI support is available. This can be turned off by passing GTEST_HAS_RTTI=0 to the
 520         TestWebKitAPI programs when compiling them.
 521
 522         * TestWebKitAPI/GNUmakefile.am:
 523
 524 2013-05-20  Ryosuke Niwa  <rniwa@webkit.org>
 525
 526         Remove DriverProxy._running_drivers from webkitpy.layout_tests.port
 527         https://bugs.webkit.org/show_bug.cgi?id=116492
 528
 529         Reviewed by Dirk Pranke.
 530
 531         Merge https://chromium.googlesource.com/chromium/blink/+/1af2f0be5a1746784ff114952f29f7b8fa9895f3.
 532
 533         The DriverProxy class had the concept of keeping a pool of started DRTs around (indexed by command line)
 534         so that we didn't necessarily need to restart DRT when the command line for a test changed (e.g., when
 535         starting to run tests in a virtual suite). However, the pool was per-worker (so not shared across the machine)
 536         and we didn't cap the number of processes started, so we would end up with a whole bunch of DRTs (3x-4x
 537         the number of workers started). If anything, this seemed to make the tests slightly slower and probably added
 538         to memory pressure on the machine.
 539
 540         This change removes the pool code; now we'll simply restart DRT when the command line changes. With this change,
 541         we can actually fold the restarting code into Driver itself (and get rid of DriverProxy), but I'll leave that
 542         for a subsequent patch just to make things easier to follow.
 543
 544         * Scripts/webkitpy/port/driver.py:
 545         (DriverProxy.__init__):
 546         (DriverProxy.run_test):
 547         (DriverProxy.has_crashed):
 548         (DriverProxy.stop):
 549
 550 2013-05-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 551
 552         Change EFL Linux 64-bit Release with EFL Linux 64-bit Release WK1
 553         https://bugs.webkit.org/show_bug.cgi?id=116423
 554
 555         Reviewed by Ryosuke Niwa.
 556
 557         EFL Linux 64-bit Release starts to support WK1's build and layout test from now on.
 558
 559         * BuildSlaveSupport/build.webkit.org-config/config.json:
 560
 561 2013-05-20  Seokju Kwon  <seokju.kwon@gmail.com>
 562
 563         Remove remaining link-prerender code
 564         https://bugs.webkit.org/show_bug.cgi?id=116429
 565
 566         Reviewed by Darin Adler.
 567
 568         Link prerendering code was removed in r150356.
 569
 570         * Scripts/webkitperl/FeatureList.pm:
 571         * qmake/mkspecs/features/features.pri:
 572
 573 2013-05-20  Ryosuke Niwa  <rniwa@webkit.org>
 574
 575         commit-queue should check for oops in changelog entries
 576         https://bugs.webkit.org/show_bug.cgi?id=116395
 577
 578         Reviewed by Martin Robinson.
 579
 580         Make changelog validation fail when it contains oops!.
 581
 582         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
 583         (CommitQueueTask._validate_changelog):
 584         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
 585         (CommitQueueTaskTest._run_through_task):
 586         * Scripts/webkitpy/tool/commands/queues_unittest.py:
 587         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
 588         (ValidateChangeLogs.options):
 589         (ValidateChangeLogs._check_changelog_diff):
 590         (ValidateChangeLogs._changelog_contains_oops):
 591         (ValidateChangeLogs.run):
 592         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
 593         (ValidateChangeLogsTest._assert_start_line_produces_output):
 594         (ValidateChangeLogsTest.test_check_changelog_diff):
 595         (ValidateChangeLogsTest):
 596         (ValidateChangeLogsTest.test_changelog_contains_oops):
 597
 598 2013-05-20  Jessie Berlin  <jberlin@apple.com>
 599
 600         Expose a way to know when forms are added to a page or when form controls are added to a form
 601         in the injected bundle
 602         https://bugs.webkit.org/show_bug.cgi?id=116334
 603
 604         Reviewed by Alexey Proskuryakov.
 605
 606         Add tests for the new callbacks.
 607
 608         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 609         Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
 610
 611         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
 612         (TestWebKitAPI::nullJavaScriptCallback):
 613         A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
 614         being passed in for the callback.
 615         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
 616         After receiving the message that didAssociateFormControls callback was invoked from adding
 617         the form in the onload handler, tell the page to add a password field to the form, which
 618         should also invoke didAssociateFormControls callback.
 619         (TestWebKitAPI::setInjectedBundleClient):
 620         Register to receive messages.
 621         (TestWebKitAPI::TEST):
 622         Load associate-form-controls.html and wait until the didAssociateFormControls callback has
 623         been invoked for both adding the form and for adding a password field to the form.
 624
 625         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
 626         (TestWebKitAPI::shouldNotifyOnFormChanges):
 627         Return true so the didAssociateFormControls callback is invoked.
 628         (TestWebKitAPI::didAssociateFormControls):
 629         Tell the UI process.
 630         (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
 631         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
 632         Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
 633
 634         * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
 635         Add a form in response to the onload event. Add a button that will add the password field
 636         for manual testing.
 637
 638 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
 639
 640         [EFL][JHBUILD] Make sure eet is built before evas
 641         https://bugs.webkit.org/show_bug.cgi?id=116440
 642
 643         Reviewed by Gyuyoung Kim.
 644
 645         Mark eet as a dependency of evas since evas requires eet to enable some of its
 646         functionality.
 647
 648         * efl/jhbuild.modules:
 649
 650 2013-05-20  Alex Christensen  <achristensen@apple.com>
 651
 652         WTR::pathSuitableForTestResult should behave the same as _drt_descriptionSuitableForTestResult so we can unskip tests.
 653         https://bugs.webkit.org/show_bug.cgi?id=116125
 654
 655         Reviewed by Tim Horton.
 656
 657         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 658         (WTR::pathSuitableForTestResult):
 659         Changed string operations to match _drt_descriptionSuitableForTestResult.
 660         (WTR::dumpRequestDescriptionSuitableForTestResult):
 661         (WTR::dumpResponseDescriptionSuitableForTestResult):
 662         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
 663         (WTR::InjectedBundlePage::didInitiateLoadForResource):
 664         (WTR::InjectedBundlePage::willSendRequestForFrame):
 665         (WTR::InjectedBundlePage::didReceiveResponseForResource):
 666         Pass the main frame's URL to pathSuitableForTestResult.
 667         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
 668         Added WKBundlePageRef to willPerformClientRedirectForFrame.
 669
 670 2013-05-20  Dirk Pranke  <dpranke@chromium.org>
 671
 672         fix w3c test importer unit tests after r150324
 673         https://bugs.webkit.org/show_bug.cgi?id=116459
 674
 675         Reviewed by Ryosuke Niwa.
 676
 677         This patch fixes the unit tests to not actually call out to
 678         'hg' (by using a mock executive) and also changes the real
 679         directory we crawl from Source/WebCore/css to
 680         Tools/Scripts/webkitpy/w3c to run much more quickly. We should
 681         still change this to a mock filesystem, but that's a separate change.
 682
 683         * Scripts/webkitpy/w3c/test_importer.py:
 684         (main):
 685         (TestImporter.__init__):
 686         (TestImporter.load_changeset):
 687         * Scripts/webkitpy/w3c/test_importer_unittest.py:
 688         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
 689         (TestImporterTest.test_import_dir_with_no_tests):
 690
 691 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
 692
 693         Unreviewed EFL build fix.
 694
 695         Fix linking errors due to undefined symbols on Ubuntu 13.04.
 696
 697         * DumpRenderTree/efl/CMakeLists.txt:
 698         * EWebLauncher/CMakeLists.txt:
 699         * MiniBrowser/efl/CMakeLists.txt:
 700
 701 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
 702
 703         [EFL] Reenabled INDEXED_DATABASE after r150344
 704         https://bugs.webkit.org/show_bug.cgi?id=116430
 705
 706         Reviewed by Gyuyoung Kim.
 707
 708         Reenable INDEXED_DATABASE flag for EFL port now that WebKit2
 709         build was fixed in r150344.
 710
 711         * Scripts/webkitperl/FeatureList.pm:
 712
 713 2013-05-19  Ryuan Choi  <ryuan.choi@samsung.com>
 714
 715         [EFL] init/shutdown should be paired in EWebLauncher
 716         https://bugs.webkit.org/show_bug.cgi?id=116427
 717
 718         Reviewed by Christophe Dumez.
 719
 720         Added ecore_file_shutdown() for cleanup of ecore_file.
 721         Removed edje_init and ecore_evas_init because it was in ewk_init().
 722
 723         * EWebLauncher/main.c:
 724         (main):
 725
 726 2013-05-19  Jinwoo Song  <jinwoo7.song@samsung.com>
 727
 728         [EFL] Add command line option to MiniBrowser to set user agent
 729         https://bugs.webkit.org/show_bug.cgi?id=116387
 730
 731         Reviewed by Christophe Dumez.
 732
 733         We need this option to compare the rendering differences according to different user agents.
 734
 735         * MiniBrowser/efl/main.c:
 736         (window_create):
 737         (elm_main):
 738
 739 2013-05-19  Zan Dobersek  <zdobersek@igalia.com>
 740
 741         Unreviewed, addressing test-webkitpy failures after r150317.
 742
 743         * Scripts/webkitpy/w3c/test_converter.py:
 744         (W3CTestConverter.read_webkit_prefixed_css_property_list): CssPropertyNames.in doesn't exist, but CSSPropertyNames.in does.
 745
 746 2013-05-18  Patrick Gansterer  <paroga@webkit.org>
 747
 748         [CMake] Replace *_LIBRARY_NAME with *_OUTPUT_NAME
 749         https://bugs.webkit.org/show_bug.cgi?id=114554
 750
 751         Reviewed by Gyuyoung Kim.
 752
 753         Using variables as target names is very uncommon in CMake.
 754         The usual way to specify the name of the resulting binary
 755         is to set the OUTPUT_NAME target property.
 756
 757         * DumpRenderTree/efl/CMakeLists.txt:
 758         * EWebLauncher/CMakeLists.txt:
 759         * ImageDiff/CMakeLists.txt:
 760         * MiniBrowser/efl/CMakeLists.txt:
 761         * TestWebKitAPI/CMakeLists.txt:
 762         * WebKitTestRunner/CMakeLists.txt:
 763         * WebKitTestRunner/PlatformEfl.cmake:
 764         * WinCELauncher/CMakeLists.txt:
 765
 766 2013-05-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
 767
 768         Unreviewed EFL build fix.
 769
 770         Temporarily disabled INDEXED_DATABASE at compile-time as it breaks
 771         WK2 build after r150305.
 772
 773         * Scripts/webkitperl/FeatureList.pm:
 774
 775 2013-05-18  Alberto Garcia  <agarcia@igalia.com>
 776
 777         [GTK] Parallel build fails if gtk-doc is enabled
 778         https://bugs.webkit.org/show_bug.cgi?id=116227
 779
 780         Reviewed by Martin Robinson.
 781
 782         * GNUmakefile.am:
 783         Don't use the 'all' target to generate the documentation.
 784         The prerequisites of this target must be files that need to be
 785         built _before_ the actual compilation of WebKit starts. Since the
 786         documentation depends on WebKit being built first, this means in
 787         practice that the code will be built in parallel with the
 788         generation of its dependencies, potentially making the build fail.
 789
 790 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
 791
 792         Don't run hg.
 793
 794         * Scripts/webkitpy/w3c/test_importer_unittest.py:
 795         (TestImporterTest):
 796
 797 2013-05-17  Dirk Pranke  <dpranke@chromium.org>
 798
 799         Create a script to import W3C tests
 800         https://bugs.webkit.org/show_bug.cgi?id=111513
 801
 802         Reviewed by Ryosuke Niwa.
 803
 804         This patch attempts to re-land the 'import-w3c-tests'
 805         script and accompanying modules.  The tests and code have
 806         been cleaned up so that we do not log anything to stdout/stderr
 807         while running the tests (thanks to outputcapture) and do not
 808         write into the source tree while running the tests, and much
 809         but not all of the code has been converted over to using the webkitpy
 810
 811         * Scripts/import-w3c-tests: Added.
 812         * Scripts/webkitpy/w3c/__init__.py: Added.
 813         * Scripts/webkitpy/w3c/test_converter.py: Added.
 814         (W3CTestConverter):
 815         (W3CTestConverter.__init__):
 816         (W3CTestConverter.path_from_webkit_root):
 817         (W3CTestConverter.read_webkit_prefixed_css_property_list):
 818         (W3CTestConverter.convert_for_webkit):
 819         (W3CTestConverter.convert_css):
 820         (W3CTestConverter.convert_html):
 821         (W3CTestConverter.convert_testharness_paths):
 822         (W3CTestConverter.convert_prefixed_properties):
 823         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
 824         (W3CTestConverter.replace_tag):
 825         * Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
 826         (W3CTestConverterTest):
 827         (W3CTestConverterTest.fake_dir_path):
 828         (W3CTestConverterTest.test_read_prefixed_property_list):
 829         (W3CTestConverterTest.test_convert_for_webkit_nothing_to_convert):
 830         (test_convert_for_webkit_harness_only):
 831         (test_convert_for_webkit_properties_only):
 832         (test_convert_for_webkit_harness_and_properties):
 833         (test_convert_test_harness_paths):
 834         (test_convert_prefixed_properties):
 835         (verify_conversion_happened):
 836         (verify_no_conversion_happened):
 837         (verify_test_harness_paths):
 838         (verify_prefixed_properties):
 839         (generate_test_content):
 840         * Scripts/webkitpy/w3c/test_importer.py: Added.
 841         (main):
 842         (parse_args):
 843         (validate_import_directory):
 844         (TestImporter):
 845         (TestImporter.__init__):
 846         (TestImporter.path_from_webkit_root):
 847         (TestImporter.do_import):
 848         (TestImporter.load_changeset):
 849         (TestImporter.find_importable_tests):
 850         (TestImporter.import_tests):
 851         (TestImporter.setup_destination_directory):
 852         (TestImporter.update_test_status):
 853         (TestImporter.remove_deleted_files):
 854         (TestImporter.write_import_log):
 855         * Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
 856         (TestImporterTest):
 857         (TestImporterTest.test_import_dir_with_no_tests):
 858         * Scripts/webkitpy/w3c/test_parser.py: Added.
 859         (TestParser):
 860         (TestParser.__init__):
 861         (TestParser.load_file):
 862         (TestParser.analyze_test):
 863         (TestParser.reference_links_of_type):
 864         (TestParser.is_jstest):
 865         (TestParser.support_files):
 866         * Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
 867         (TestParserTest):
 868         (TestParserTest.test_analyze_test_reftest_one_match):
 869         (test_analyze_test_reftest_multiple_matches):
 870         (test_analyze_test_reftest_match_and_mismatch):
 871         (test_analyze_test_reftest_with_ref_support_Files):
 872         (test_analyze_jstest):
 873         (test_analyze_pixel_test_all_true):
 874         (test_analyze_pixel_test_all_false):
 875         (test_analyze_non_html_file):
 876
 877 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
 878
 879         Leaks builders exit early frequently
 880         https://bugs.webkit.org/show_bug.cgi?id=116355
 881
 882         Reviewed by Stephanie Lewis.
 883
 884         Throttle the number of processes to use, and also bump up the number of crashes/timeouts
 885         we tolerate from 20 to 50.
 886
 887         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 888         (RunWebKitTests.start):
 889         * Scripts/webkitpy/port/mac.py:
 890         (MacPort.default_child_processes):
 891
 892 2013-05-17  Peter Gal  <galpeter@inf.u-szeged.hu>
 893
 894         Remove chrome-channels command from the webkit-patch
 895         https://bugs.webkit.org/show_bug.cgi?id=116303
 896
 897         Reviewed by Ryosuke Niwa.
 898
 899         * Scripts/webkitpy/common/config/urls.py: Removed omahaproxy url.
 900         * Scripts/webkitpy/common/net/omahaproxy.py: Removed.
 901         * Scripts/webkitpy/common/net/omahaproxy_unittest.py: Removed.
 902         * Scripts/webkitpy/tool/commands/__init__.py: Removed chromechannels import.
 903         * Scripts/webkitpy/tool/commands/chromechannels.py: Removed.
 904         * Scripts/webkitpy/tool/commands/chromechannels_unittest.py: Removed.
 905
 906 2013-05-17  David Kilzer  <ddkilzer@apple.com>
 907
 908         filter-build-webkit: Don't filter out the location of the missing symbol when linking fails
 909         Part 3 of 3: <http://webkit.org/b/116247>
 910
 911         Reviewed by Benjamin Poulain.
 912
 913         * Scripts/filter-build-webkit: Change while() loop to for() loop
 914         to track $previousLine, then pass $previousLine into
 915         shouldIgnoreLine().
 916         (shouldIgnoreLine): Add $previousLine argument. Do not skip a
 917         line that begins with four spaces if the previous line is a
 918         linker error message.
 919         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
 920         - Add "Ignored: " to test descriptions to document expected
 921           behavior.
 922         - Add comment blocks for various groups of tests.
 923         - Expand "Build settings" tests since we're changing the code in
 924           shouldIgnoreLine() that ignores those lines.
 925         - Add tests for undefined symbols error message.
 926         (description): Add.  Extract from global code.
 927
 928 2013-05-17  David Kilzer  <ddkilzer@apple.com>
 929
 930         Add tests for shouldIgnoreLine() in filter-build-webkit
 931         Part 2 of 3: <http://webkit.org/b/116247>
 932
 933         Reviewed by Benjamin Poulain.
 934
 935         * Scripts/filter-build-webkit:
 936         (shouldIgnoreLine): Add.  Extract code from global scope into
 937         subroutine to make it testable.
 938         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl: Add.
 939         Tests shouldIgnoreLine() using output from a real build
 940         transcript.
 941
 942 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
 943
 944         Rename "WebKit Queues" to explicitly call out for EWS and CQ on build.webkit.org
 945         https://bugs.webkit.org/show_bug.cgi?id=116341
 946
 947         Reviewed by Brady Eidson.
 948
 949         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
 950
 951 2013-05-17  Brent Fulgham  <bfulgham@apple.com>
 952
 953         [Windows] Don't use pdevenv when building with VS2010.
 954         https://bugs.webkit.org/show_bug.cgi?id=116338.
 955
 956         Reviewed by Adam Roben.
 957
 958         * Scripts/webkitdirs.pm:
 959         (setupCygwinEnv): Check if we are using VS2005, and only use
 960         the 'pdevenv' hack if we are. Otherwise, just build with
 961         our standard project since it uses VS2010+'s native
 962         parallel building features.
 963
 964 2013-05-17  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
 965
 966         Unreviewed. Disable accelerated compositing until we figure out why it does not work
 967         properly in the 64 bits release bot.
 968
 969         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 970         (resetDefaultsToConsistentValues):
 971
 972 2013-05-17  David Kilzer  <ddkilzer@apple.com>
 973
 974         Make filter-build-webkit testable using LoadAsModule
 975         Part 1 of 3: <http://webkit.org/b/116247>
 976
 977         Reviewed by Benjamin Poulain.
 978
 979         * Scripts/filter-build-webkit: Change global variables that are
 980         used in subroutines from 'my' to 'our' to make it possible to
 981         evaluate the script in a package context in LoadAsModule.pm.
 982
 983 2013-05-14  Sam Weinig  <sam@webkit.org>
 984
 985         Add variants of the loading APIs that take user data and a way for the injected bundle to find out about them
 986         https://bugs.webkit.org/show_bug.cgi?id=116132
 987
 988         Reviewed by Anders Carlsson.
 989
 990         Adds "WithUserData" versions of all the load APIs and two new WKBundlePageLoaderClient functions,
 991         willLoadURLRequest and willLoadDataRequest to let the bundle access them.
 992
 993         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 994         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Added.
 995         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp: Added.
 996         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 997
 998 2013-05-16  Seokju Kwon  <seokju.kwon@gmail.com>
 999
1000         [EFL] inspector-protocol/page/javascriptDialogEvents.html is failing
1001         https://bugs.webkit.org/show_bug.cgi?id=114781
1002
1003         Reviewed by Christophe Dumez.
1004
1005         Add run_before_unload_confirm and
1006         Print the log message with "CONFIRM NAVIGATION: " in console.
1007
1008         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1009         (onBeforeUnloadConfirm):
1010         (drtViewAdd):
1011
1012 2013-05-16  Peter Gal  <galpeter@inf.u-szeged.hu>
1013
1014         Fix Analyze ChangeLog's entry processing
1015         https://bugs.webkit.org/show_bug.cgi?id=116219
1016
1017         Reviewed by Ryosuke Niwa.
1018
1019         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
1020         (ChangeLogAnalyzer._analyze_entries): Fix the counter initialization.
1021
1022 2013-05-16  Hyungchan Kim  <hyungchan2.kim@lge.com>
1023
1024         [Qt] UrlLoader::loadNext is broken in MiniBrowser
1025         https://bugs.webkit.org/show_bug.cgi?id=116099
1026
1027         Reviewed by Jocelyn Turcotte.
1028
1029         QQuickWebView's 3 signals(loadStarted, loadSucceeded, loadFailed)
1030         are not available any more. So, UrlLoader::loadNext was broken
1031         because it failed to connect to those signals.
1032
1033         * MiniBrowser/qt/UrlLoader.cpp:
1034         (UrlLoader::UrlLoader):
1035         (UrlLoader::loadingChanged):
1036         * MiniBrowser/qt/UrlLoader.h:
1037         (UrlLoader):
1038
1039 2013-05-16  Lamarque V. Souza  <Lamarque.Souza@basyskom.com>
1040
1041         [WebSocket] Update pywebsocket to r760
1042         https://bugs.webkit.org/show_bug.cgi?id=115863
1043
1044         Reviewed by Alexey Proskuryakov.
1045
1046         Version r760 supports a newer draft of message compression.
1047         We need this update to finish the permessage compression patch in
1048         bug 98840. This patch also fixes failing unit tests after the update.
1049
1050         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py:
1051         (StreamBase._read):
1052         (StreamBase._read.of):
1053         (StreamBase._write):
1054         (StreamBase.receive_bytes):
1055         (StreamBase._read_until):
1056         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py:
1057         (parse_frame):
1058         (StreamOptions.__init__):
1059         (Stream.__init__):
1060         (Stream._receive_frame_as_frame_object):
1061         (Stream._get_message_from_frame):
1062         (Stream._process_close_message):
1063         (Stream.close_connection):
1064         (Stream.get_last_received_opcode):
1065         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py:
1066         * Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py:
1067         (Dispatcher.do_extra_handshake):
1068         (Dispatcher.transfer_data):
1069         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py:
1070         (ExtensionProcessorInterface.__init__):
1071         (ExtensionProcessorInterface.request):
1072         (ExtensionProcessorInterface):
1073         (ExtensionProcessorInterface.name):
1074         (ExtensionProcessorInterface.check_consistency_with_other_processors):
1075         (ExtensionProcessorInterface.set_active):
1076         (ExtensionProcessorInterface.is_active):
1077         (ExtensionProcessorInterface._get_extension_response_internal):
1078         (ExtensionProcessorInterface.get_extension_response):
1079         (ExtensionProcessorInterface._setup_stream_options_internal):
1080         (ExtensionProcessorInterface.setup_stream_options):
1081         (_log_outgoing_compression_ratio):
1082         (_log_incoming_compression_ratio):
1083         (_parse_window_bits):
1084         (_AverageRatioCalculator):
1085         (_AverageRatioCalculator.__init__):
1086         (_AverageRatioCalculator.add_original_bytes):
1087         (_AverageRatioCalculator.add_result_bytes):
1088         (_AverageRatioCalculator.get_average_ratio):
1089         (DeflateFrameExtensionProcessor):
1090         (DeflateFrameExtensionProcessor.__init__):
1091         (DeflateFrameExtensionProcessor._get_extension_response_internal):
1092         (DeflateFrameExtensionProcessor._setup_stream_options_internal):
1093         (DeflateFrameExtensionProcessor._outgoing_filter):
1094         (DeflateFrameExtensionProcessor._incoming_filter):
1095         (CompressionExtensionProcessorBase.for):
1096         (CompressionExtensionProcessorBase.__init__):
1097         (CompressionExtensionProcessorBase._get_extension_response_internal):
1098         (CompressionExtensionProcessorBase._setup_stream_options_internal):
1099         (PerFrameCompressExtensionProcessor):
1100         (PerMessageDeflateExtensionProcessor):
1101         (PerMessageDeflateExtensionProcessor.__init__):
1102         (PerMessageDeflateExtensionProcessor._get_extension_response_internal):
1103         (PerMessageDeflateExtensionProcessor._setup_stream_options_internal):
1104         (PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits):
1105         (PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits.adds):
1106         (PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover):
1107         (PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover.adds):
1108         (PerMessageDeflateExtensionProcessor.set_bfinal):
1109         (PerMessageDeflateExtensionProcessor.enable_outgoing_compression):
1110         (PerMessageDeflateExtensionProcessor.disable_outgoing_compression):
1111         (_PerMessageDeflateFramer):
1112         (_PerMessageDeflateFramer.__init__):
1113         (_PerMessageDeflateFramer.set_compress_outgoing_enabled):
1114         (_PerMessageDeflateFramer._process_incoming_message):
1115         (_PerMessageDeflateFramer._process_outgoing_message):
1116         (_PerMessageDeflateFramer.setup_stream_options):
1117         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter):
1118         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.__init__):
1119         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.filter):
1120         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter):
1121         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.__init__):
1122         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.decompress_next_message):
1123         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.filter):
1124         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter):
1125         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.__init__):
1126         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.set_compression_bit):
1127         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.filter):
1128         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter):
1129         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.__init__):
1130         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.filter):
1131         (PerMessageCompressExtensionProcessor):
1132         (PerMessageCompressExtensionProcessor._lookup_compression_processor):
1133         (MuxExtensionProcessor.__init__):
1134         (MuxExtensionProcessor.check_consistency_with_other_processors):
1135         (MuxExtensionProcessor):
1136         (MuxExtensionProcessor._get_extension_response_internal):
1137         (MuxExtensionProcessor._setup_stream_options_internal):
1138         (MuxExtensionProcessor.set_quota):
1139         (MuxExtensionProcessor.quota):
1140         (MuxExtensionProcessor.set_extensions):
1141         (MuxExtensionProcessor.extensions):
1142         (is_compression_extension):
1143         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py:
1144         (validate_subprotocol):
1145         (parse_host_header):
1146         (format_header):
1147         (check_request_line):
1148         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py:
1149         (Handshaker.do_handshake):
1150         (Handshaker._create_handshake_response):
1151         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py:
1152         (_validate_subprotocol):
1153         (_check_header_lines):
1154         (_build_location):
1155         (Handshaker.do_handshake):
1156         (Handshaker._set_subprotocol):
1157         (Handshaker._set_location):
1158         * Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py:
1159         (_create_dispatcher):
1160         (headerparserhandler):
1161         * Scripts/webkitpy/thirdparty/mod_pywebsocket/mux.py:
1162         (_create_add_channel_response):
1163         (_create_drop_channel):
1164         (_create_flow_control):
1165         (_create_new_channel_slot):
1166         (_create_fallback_new_channel_slot):
1167         (_MuxFramePayloadParser._read_number):
1168         (_MuxFramePayloadParser._read_size_and_contents):
1169         (_MuxFramePayloadParser._read_flow_control):
1170         (_MuxFramePayloadParser._read_new_channel_slot):
1171         (_LogicalConnection.__init__):
1172         (_LogicalConnection.write):
1173         (_LogicalConnection.on_write_data_done):
1174         (_LogicalConnection):
1175         (_LogicalConnection.on_writer_done):
1176         (_InnerMessage):
1177         (_InnerMessage.__init__):
1178         (_InnerMessageBuilder):
1179         (_InnerMessageBuilder.that):
1180         (_InnerMessageBuilder.__init__):
1181         (_InnerMessageBuilder._handle_first):
1182         (_InnerMessageBuilder._process_first_fragmented_control):
1183         (_InnerMessageBuilder._process_first_fragmented_message):
1184         (_InnerMessageBuilder._handle_fragmented_control):
1185         (_InnerMessageBuilder._reassemble_fragmented_control):
1186         (_InnerMessageBuilder._handle_fragmented_message):
1187         (_InnerMessageBuilder._reassemble_fragmented_message):
1188         (_InnerMessageBuilder.build):
1189         (_LogicalStream.__init__):
1190         (_LogicalStream._create_inner_frame):
1191         (_LogicalStream._write_inner_frame):
1192         (_LogicalStream.replenish_send_quota):
1193         (_LogicalStream.send_message):
1194         (_LogicalStream._receive_frame):
1195         (_LogicalStream._get_message_from_frame):
1196         (_LogicalStream.stop_sending):
1197         (_PhysicalConnectionWriter.__init__):
1198         (_PhysicalConnectionWriter._write_data):
1199         (_PhysicalConnectionWriter.run):
1200         (_PhysicalConnectionWriter.stop):
1201         (_Worker.run):
1202         (_MuxHandshaker.__init__):
1203         (_MuxHandshaker._create_stream):
1204         (_MuxHandshaker._create_handshake_response):
1205         (_HandshakeDeltaBase.create_headers):
1206         (_MuxHandler.start):
1207         (_MuxHandler.wait_until_done):
1208         (_MuxHandler.notify_write_data_done):
1209         (_MuxHandler._process_drop_channel):
1210         (_MuxHandler._process_logical_frame):
1211         (_MuxHandler.notify_reader_done):
1212         (_MuxHandler):
1213         (_MuxHandler.notify_writer_done):
1214         (_MuxHandler.fail_physical_connection):
1215         (_MuxHandler.fail_logical_channel):
1216         (use_mux):
1217         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py:
1218         (_StandaloneRequest.get_uri):
1219         (_StandaloneRequest.get_unparsed_uri):
1220         (_StandaloneRequest):
1221         (_StandaloneRequest.is_https):
1222         (_import_ssl):
1223         (_import_pyopenssl):
1224         (_StandaloneSSLConnection.for):
1225         (_StandaloneSSLConnection):
1226         (_StandaloneSSLConnection.__getattribute__):
1227         (_StandaloneSSLConnection.__setattr__):
1228         (_StandaloneSSLConnection.makefile):
1229         (_StandaloneSSLConnection.shutdown):
1230         (_StandaloneSSLConnection.recv):
1231         (WebSocketServer.__init__):
1232         (WebSocketServer._create_sockets):
1233         (WebSocketServer.handle_error):
1234         (WebSocketServer.get_request):
1235         (WebSocketServer.get_request.default_callback):
1236         (WebSocketRequestHandler.parse_request):
1237         (_build_option_parser):
1238         (_main):
1239         (_main.if):
1240         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py:
1241         (RepeatedXorMasker.__init__):
1242         (RepeatedXorMasker._mask_using_swig):
1243         (RepeatedXorMasker):
1244         (RepeatedXorMasker._mask_using_array):
1245         (_Deflater.compress_and_finish):
1246         (_RFC1979Deflater.filter):
1247         (DeflateSocket.send):
1248
1249 2013-05-16  Jonathan Liu  <net147@gmail.com>
1250
1251         Fix testing if program exists in PATH
1252         https://bugs.webkit.org/show_bug.cgi?id=116216
1253
1254         Reviewed by Jocelyn Turcotte.
1255
1256         functions.prf incorrectly uses win_cmd_shell to test whether to
1257         add .exe to the executable name when checking if it exists in
1258         the PATH environment variable. This works correctly when
1259         building using Windows Command Prompt but not under MSYS shell.
1260
1261         To resolve this, check the win32 platform scope instead of
1262         win_cmd_shell so that it correctly adds .exe to the executable
1263         name on Windows regardless of the shell used when testing if
1264         it exists in PATH.
1265
1266         * qmake/mkspecs/features/functions.prf:
1267
1268 2013-05-16  Ryosuke Niwa  <rniwa@webkit.org>
1269
1270         Fix the hard-coded names of EWS bots that run tests.
1271
1272         * Scripts/webkitpy/tool/commands/queues.py:
1273         (CommitQueue.did_pass_testing_ews):
1274
1275 2013-05-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1276
1277         [GTK] Build Xvfb with jhbuild
1278         https://bugs.webkit.org/show_bug.cgi?id=115907
1279
1280         Reviewed by Martin Robinson.
1281
1282         Build our own Xvfb so that we can avoid problems with the system Xvfb
1283         relying on symbols not present in our jhbuilt libraries such as pixman,
1284         and also to ensure we have the fix for a GLX module crasher.
1285
1286         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1287         (resetDefaultsToConsistentValues): enable accelerated compositing.
1288         * gtk/install-dependencies: list packages required for building Xvfb.
1289         * gtk/jhbuild.modules: add xserver as a jhbuild module.
1290         * gtk/patches/xserver-remove-bogus-dependencies.patch: Added.
1291         * gtk/patches/xserver-fix-glx-init.patch: Added. Fixes a crash while
1292         initializing the GLX module for Xvfb.
1293
1294 2013-05-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1295
1296         [jhbuild] Should remove the sources directory as well when cleaning
1297         https://bugs.webkit.org/show_bug.cgi?id=116229
1298
1299         Reviewed by Martin Robinson.
1300
1301         * Scripts/update-webkit-libs-jhbuild:
1302         (cleanJhbuild): remove the Source directory as well when cleaning.
1303
1304 2013-05-15  Dominik Röttsches  <dominik.rottsches@intel.com>
1305
1306         [EFL] Remove Intel Wk2 Buildbots from Master
1307         https://bugs.webkit.org/show_bug.cgi?id=116149
1308
1309         Removing Intel maintained EFL Wk2 bots except the handle for efl-linux-slave-2
1310         since Gyuyoung Kim from Samsung plans to take over and maintain it.
1311
1312         Reviewed by Benjamin Poulain.
1313
1314         * BuildSlaveSupport/build.webkit.org-config/config.json:
1315
1316 2013-05-15  Brent Fulgham  <bfulgham@apple.com>
1317
1318         [Windows] Update various build tools to understand VS2010 environment.
1319         https://bugs.webkit.org/show_bug.cgi?id=116169.
1320
1321         Reviewed by Anders Carlsson.
1322
1323         * Scripts/build-api-tests: Identify VS2010 environment.
1324         * Scripts/build-dumprendertree: Ditto.
1325         * Scripts/build-webkit: Ditto.
1326         * Scripts/webkitdirs.pm:
1327         (dieIfWindowsPlatformSDKNotInstalled): Update to recognize a wider
1328         range of acceptable SDK's.
1329
1330 2013-05-15  Peter Gal  <galpeter@inf.u-szeged.hu>
1331
1332         Allow http tests on Arch Linux
1333         https://bugs.webkit.org/show_bug.cgi?id=116155
1334
1335         Reviewed by Ryosuke Niwa.
1336
1337         * Scripts/webkitpy/port/base.py:
1338         (Port._is_arch_based): Added check for /etc/arch-release file.
1339         (Port._apache_config_file_name_for_platform): Call the check.
1340         * Scripts/webkitpy/port/port_testcase.py:
1341         (test_linux_distro_detection): Testcase added.
1342
1343 2013-05-15  Peter Gal  <galpeter@inf.u-szeged.hu>
1344
1345         Remove a leftover v8 file from the watchlist
1346         https://bugs.webkit.org/show_bug.cgi?id=116158
1347
1348         Reviewed by Csaba Osztrogonác.
1349
1350         * Scripts/webkitpy/common/config/watchlist: Removed a v8 entry from the watchlist.
1351
1352 2013-05-15  Alberto Garcia  <agarcia@igalia.com>
1353
1354         [GTK] Fails to build while generating gtkdoc
1355         https://bugs.webkit.org/show_bug.cgi?id=115612
1356
1357         Reviewed by Philippe Normand.
1358
1359         Fix typo in the prerequisites of docs-build.stamp.
1360
1361         * GNUmakefile.am:
1362
1363 2013-05-15  Zan Dobersek  <zdobersek@igalia.com>
1364
1365         Unreviewed, fixing the current test-webkitpy failure.
1366
1367         * Scripts/webkitpy/port/mac_unittest.py:
1368         (test_setup_environ_for_server): Adjusting the expected DYLD_INSERT_LIBRARIES environment variable value
1369         in webkitpy.port.mac_unittest.test_setup_environ_for_server after r150089.
1370
1371 2013-05-14  Jaehun Lim  <ljaehun.lim@samsung.com>
1372
1373         Fix build after r150090.
1374         https://bugs.webkit.org/show_bug.cgi?id=116129
1375
1376         Unreviewed build fix after r150090.
1377
1378         * WebKitTestRunner/TestInvocation.cpp:
1379         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1380
1381 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
1382
1383         [Windows, others] Unreviewed build fix after r150090.
1384
1385         * DumpRenderTree/TestRunner.cpp:
1386         (getSecureEventInputIsEnabledCallback): IsSecureEventInputEnabled
1387         doesn't exist on other platforms.
1388
1389 2013-05-14  Brent Fulgham  <bfulgham@webkit.org>
1390
1391         [Windows] Expunge pthreads2VC.dll from DumpRenderTree Project
1392         https://bugs.webkit.org/show_bug.cgi?id=115889
1393
1394         Reviewed by Benjamin Poulain.
1395
1396         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
1397         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1398
1399 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
1400
1401         [Windows] Identify proper run environment for scripts.
1402         https://bugs.webkit.org/show_bug.cgi?id=116114
1403
1404         Reviewed by David Kilzer.
1405
1406         Determine (based on Visual Studio version) which path to use for
1407         executables (bin versus bin32).
1408
1409         * Scripts/webkitdirs.pm:
1410         (determineVisualStudioInstallDir): Added.
1411         (determineVisualStudioVersion): Added.
1412         (determineConfigurationProductDir): Modified to choose proper bin
1413         or bin32 directory.
1414         (visualStudioVersion): Added
1415         (setupCygwinEnv): Modified to use new determineVisualStudioInstallDir
1416
1417 2013-05-14  Alexey Proskuryakov  <ap@apple.com>
1418
1419         [Mac] Add tests for secure event input
1420         https://bugs.webkit.org/show_bug.cgi?id=116121
1421
1422         Reviewed by Mark Rowe.
1423
1424         * DumpRenderTree/TestRunner.cpp:
1425         (getSecureEventInputIsEnabledCallback):
1426         (TestRunner::staticValues):
1427         Expose an accessor for current secure event input state.
1428
1429         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1430         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1431         (WTR::TestRunner::secureEventInputIsEnabled):
1432         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1433         * WebKitTestRunner/TestInvocation.cpp:
1434         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1435         Expose an accessor for current secure event input state. This has to be done in
1436         UI process, as this is where it's changed by WebKit.
1437
1438 2013-05-14  Alexey Proskuryakov  <ap@apple.com>
1439
1440         [Mac] Add a testing shim for secure event input functions
1441         https://bugs.webkit.org/show_bug.cgi?id=116122
1442
1443         Reviewed by Mark Rowe.
1444
1445         * Scripts/webkitpy/port/mac.py: (MacPort.setup_environ_for_server):
1446         Inject WebCore testing shim library to override system framework functions.
1447
1448 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
1449
1450         [Windows] Switch to embedded manifest commands for launcher executables.
1451         https://bugs.webkit.org/show_bug.cgi?id=116109
1452
1453         Reviewed by Darin Adler.
1454
1455         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Remove the
1456         now-unused WinLauncher.exe.manifest file.
1457         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
1458         * win/DLLLauncher/DLLLauncherMain.cpp: Add embedded manifest command
1459         when building with VS2010 or newer.
1460
1461 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
1462
1463         [Windows] Update ORWT to know about the Windows 8 SDK and Debug Tools.
1464         https://bugs.webkit.org/show_bug.cgi?id=116079
1465
1466         Reviewed by David Kilzer.
1467
1468         * Scripts/old-run-webkit-tests:
1469         (setUpWindowsCrashLogSaving): Locate ntsd.exe and use it.
1470
1471 2013-05-14  Zan Dobersek  <zdobersek@igalia.com>
1472
1473         [GTK] Move generated ColorData.cpp, WebKitFontFamilyNames.(cpp|h) build targets into libPlatform
1474         https://bugs.webkit.org/show_bug.cgi?id=115921
1475
1476         Reviewed by Gustavo Noronha Silva.
1477
1478         * GNUmakefile.am: Add platform_cppflags to the list of CPPFLAGS for libWebCoreInternals and DumpRenderTree.
1479         * TestWebKitAPI/GNUmakefile.am: Add platform_cppflags to the list of TestGtk CPPFLAGS.
1480
1481 2013-05-13  Alex Christensen  <achristensen@apple.com>
1482
1483         Added testRunner.setPrinting.
1484         https://bugs.webkit.org/show_bug.cgi?id=42693
1485         rdar://problem/8213845
1486
1487         Reviewed by Darin Adler.
1488
1489         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1490         Added setPrinting JavaScript function.
1491         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1492         (WTR::InjectedBundlePage::dump):
1493         Dump the external representation for printing if setPrinting has been called.
1494         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1495         (WTR::TestRunner::isPrinting): Added.
1496         (WTR::TestRunner::setPrinting): Added.
1497         Added and initialized m_isPrinting member boolean.
1498
1499 2013-05-13  Csaba Osztrogonác  <ossy@webkit.org>
1500
1501         [webkitpy] Make FileInfo.repository_name support SVN version > 1.6
1502         https://bugs.webkit.org/show_bug.cgi?id=116016
1503
1504         Reviewed by Dirk Pranke.
1505
1506         Same fix as in the upstream style checker, but without hg support.
1507         ( http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py )
1508
1509         * Scripts/webkitpy/style/checkers/cpp.py:
1510         (FileInfo.repository_name):
1511
1512 2013-05-13  Zan Dobersek  <zdobersek@igalia.com>
1513
1514         [GTK] Use WebCore layer archives for TestWebCore, WebKitPluginProcess
1515         https://bugs.webkit.org/show_bug.cgi?id=115918
1516
1517         Reviewed by Gustavo Noronha Silva.
1518
1519         Due to layer violations and circular dependencies the TestWebCores requires for the libraries containing
1520         the built code of the intertwining Platform and WebCore layers to be specified multiple times when linking.
1521         This can be avoided by packing the two layers' archives into one big archive, named after the WebCore layer
1522         due to no clear boundary between it and the Platform layer. The big archive can then be specified only once
1523         when linking, simplifying the code and suppressing all the layering violations so they do not cause build
1524         problems.
1525
1526         First the libtool libraries that the WebCore layer (as required by the TestWebCore) depends on are specified.
1527         These are then used as dependencies for the archive creation rule as well as the list from which the archive
1528         file paths are constructed and then used to dump the member files from these archives. The member files are
1529         then added to the big archive. The latter is added to the list of libraries the TestWebCore requires to
1530         successfully link.
1531
1532         * TestWebKitAPI/GNUmakefile.am:
1533
1534 2013-05-13  Anders Carlsson  <andersca@apple.com>
1535
1536         Remove UnusedParam.h
1537         https://bugs.webkit.org/show_bug.cgi?id=116029
1538
1539         Reviewed by Andreas Kling.
1540
1541         Stop including UnusedParam.h.
1542
1543         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1544         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1545
1546 2013-05-12  Commit Queue  <commit-queue@webkit.org>
1547
1548         Unreviewed, rolling out r149955.
1549         http://trac.webkit.org/changeset/149955
1550         https://bugs.webkit.org/show_bug.cgi?id=115990
1551
1552         Broke lots of tests (Requested by smfr on #webkit).
1553
1554         * Scripts/webkitpy/port/mac.py:
1555
1556 2013-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1557
1558         [GTK] Remove unnecessary GTK_CHECK_VERSION #ifdefs
1559         https://bugs.webkit.org/show_bug.cgi?id=115914
1560
1561         Reviewed by Martin Robinson.
1562
1563         * GtkLauncher/main.c:
1564         (createToolbar):
1565         * MiniBrowser/gtk/BrowserWindow.c:
1566         (_BrowserWindow):
1567         (browserWindowSetStatusText):
1568         (fullScreenMessageTimeoutCallback):
1569         (webViewEnterFullScreen):
1570         (webViewLeaveFullScreen):
1571         (browserWindowFinalize):
1572         (browserWindowConstructed):
1573         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1574         (WTR::EventSenderProxy::mouseScrollBy):
1575         (WTR::EventSenderProxy::continuousMouseScrollBy):
1576
1577 2013-05-11  Anders Carlsson  <andersca@apple.com>
1578
1579         Crash when terminating a process that has not been fully launched
1580         https://bugs.webkit.org/show_bug.cgi?id=115962
1581         <rdar://problem/13660916>
1582
1583         Reviewed by Andreas Kling.
1584
1585         Add TerminateTwice, a test that terminates a page, then reloads it and terminates it again
1586         before the process has had a chance to be fully launched.
1587
1588         * TestWebKitAPI/GNUmakefile.am:
1589         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1590         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Added.
1591         (TestWebKitAPI):
1592         (TestWebKitAPI::didFinishLoadForFrame):
1593         (TestWebKitAPI::TEST):
1594         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
1595
1596 2013-05-10  Laszlo Gombos  <l.gombos@samsung.com>
1597
1598         Remove Mac OS X Leopard (10.5) support
1599         https://bugs.webkit.org/show_bug.cgi?id=107964
1600
1601         Reviewed by Ryosuke Niwa.
1602
1603         Removed the code for 10.5 and removed if-def for 10.6.
1604
1605         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
1606         (convertMIMEType):
1607         (createXMLStringFromWebArchiveData):
1608         * DumpRenderTree/mac/TestRunnerMac.mm:
1609         (TestRunner::authenticateSession):
1610         (TestRunner::setTextDirection):
1611         * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
1612         (convertMIMEType):
1613         (createXMLStringFromWebArchiveData):
1614
1615 2013-05-10  Brent Fulgham  <bfulgham@apple.com>
1616
1617         [Windows] Allow VS2010 Build to use VS2005 Support Libraries
1618         https://bugs.webkit.org/show_bug.cgi?id=115935
1619
1620         Reviewed by Jer Noble.
1621
1622         * WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Added.
1623         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add reference
1624         to the new manifest file.
1625         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
1626
1627 2013-05-10  Jacky Jiang  <zhajiang@blackberry.com>
1628
1629         Fix some compiler warnings (miscellaneous)
1630         https://bugs.webkit.org/show_bug.cgi?id=80790
1631
1632         Reviewed by Rob Buis.
1633
1634         Fix the following warnings for BlackBerry:
1635         DumpRenderTree.cpp:357:42: warning: suggest parentheses around assignment
1636         used as truth value [-Wparentheses].
1637
1638         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1639         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
1640
1641 2013-05-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1642
1643         [WK2][CoordinatedGraphics] WKViewSetThemePath is EFL specific
1644         https://bugs.webkit.org/show_bug.cgi?id=115928
1645
1646         Reviewed by Kenneth Rohde Christiansen.
1647
1648         WKViewSetThemePath was moved to WKViewEfl.h.
1649
1650         * TestWebKitAPI/efl/PlatformWebView.cpp:
1651
1652 2013-05-10  Andreas Kling  <akling@apple.com>
1653
1654         I accidentally the Java testing.
1655
1656         * Scripts/webkitpy/port/mac.py:
1657
1658 2013-05-10  Brian Holt  <brian.holt@samsung.com>
1659
1660         [GTK] Module Cairo fails to build under jhbuild
1661         https://bugs.webkit.org/show_bug.cgi?id=115854
1662
1663         Reviewed by Martin Robinson.
1664
1665         Make cairo depend on glib in jhbuild.modules.
1666
1667         * gtk/jhbuild.modules:
1668
1669 2013-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1670
1671         [GTK] Remove unnecessary GLIB_CHECK_VERSION #ifdefs
1672         https://bugs.webkit.org/show_bug.cgi?id=115904
1673
1674         Reviewed by Martin Robinson.
1675
1676         * ImageDiff/gtk/ImageDiff.cpp:
1677         (main):
1678
1679 2013-05-10  Balazs Kelemen  <kbalazs@webkit.org>
1680
1681         Add my new address to contributors.json. (Unreviewed)
1682
1683         * Scripts/webkitpy/common/config/contributors.json:
1684
1685 2013-05-10  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1686
1687         Unreviewed. Move myself to the reviewers list.
1688
1689         * Scripts/webkitpy/common/config/contributors.json:
1690
1691 2013-05-10  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1692
1693         Unreviewed. Add my email to a few watchlists.
1694
1695         * Scripts/webkitpy/common/config/watchlist:
1696
1697 2013-05-10  Simon Pena  <simon.pena@samsung.com>
1698
1699         Unicode support missing from string representation of Contributors in committers.py
1700         https://bugs.webkit.org/show_bug.cgi?id=115859
1701
1702         Reviewed by Darin Adler.
1703
1704         Contributors, in committers.py, provided a string representation in __str__ which
1705         didn't support unicode characters, so printing a contributor would fail in that case.
1706         This patch implements __unicode__ and makes __str__ use it to represent a contributor.
1707         The unit tests are updated accordingly, so they ensure that a unicode name can be shown.
1708
1709         * Scripts/webkitpy/common/config/committers.py: Move the existing string representation
1710         to the newly implemented method __unicode__, and make __str__ display its utf-8 encoded
1711         representation.
1712         (Contributor.__str__):
1713         (Contributor):
1714         (Contributor.__unicode__):
1715         * Scripts/webkitpy/common/config/committers_unittest.py: Add a new test that checks that
1716         a contributor with unicode characters can be represented as a string.
1717         (CommittersTest):
1718         (CommittersTest.test_contributor_encoding):
1719
1720 2013-05-09  Patrick Gansterer  <paroga@webkit.org>
1721
1722         [WIN][DRT] Remove duplicated (start|stop)JavaScriptThreads()
1723         https://bugs.webkit.org/show_bug.cgi?id=92371
1724
1725         Reviewed by Brent Fulgham.
1726
1727         Use JavaScriptThreading.cpp where the same functionality is
1728         implemented too. This reduces the dependency on the pthread
1729         library. Also replace assert() with WebKit ASSERT().
1730
1731         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1732         * DumpRenderTree/win/DumpRenderTree.cpp:
1733         (dumpHistoryItem):
1734         (dumpBackForwardList):
1735         * DumpRenderTree/win/DumpRenderTree.vcproj:
1736
1737 2013-05-09  Patrick Gansterer  <paroga@webkit.org>
1738
1739         [DRT] Replace JavaScriptThreadingPthreads.cpp with JavaScriptThreading.cpp
1740         https://bugs.webkit.org/show_bug.cgi?id=92505
1741
1742         Reviewed by Brent Fulgham.
1743
1744         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1745         * DumpRenderTree/JavaScriptThreading.cpp: Copied from DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp.
1746         (javaScriptThreadsMutex):
1747         (javaScriptThreads):
1748         (runJavaScriptThread):
1749         (startJavaScriptThreads):
1750         (stopJavaScriptThreads):
1751         * DumpRenderTree/pthreads: Removed.
1752         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Removed.
1753
1754 2013-05-09  Mario Sanchez Prada  <mario.prada@samsung.com>
1755
1756         Unreviewed. Update Simon Pena email on his behalf.
1757
1758         * Scripts/webkitpy/common/config/contributors.json:
1759
1760 2013-05-09  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1761
1762         Add support for [NoInterfaceObject] Web IDL extended attribute
1763         https://bugs.webkit.org/show_bug.cgi?id=115714
1764
1765         Reviewed by Kentaro Hara.
1766
1767         Update BindingsTests.generate_supplemental_dependency() to pass an
1768         additional windowConstructorsFile argument to preprocess-idls.pl.
1769
1770         * Scripts/webkitpy/bindings/main.py:
1771         (BindingsTests.generate_supplemental_dependency):
1772         (BindingsTests.main):
1773
1774 2013-05-09  ChangSeok Oh  <changseok.oh@collabora.com>
1775
1776         [GTK][AC] Buildfix after r149694
1777         https://bugs.webkit.org/show_bug.cgi?id=115797
1778
1779         Reviewed by Gustavo Noronha Silva.
1780
1781         Add CLUTTER_LIBS for linking TestWebCore.
1782
1783         * TestWebKitAPI/GNUmakefile.am:
1784
1785 2013-05-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1786
1787         [EFL] Remove unnecessary pkgs in EFL jhbuild
1788         https://bugs.webkit.org/show_bug.cgi?id=114908
1789
1790         Reviewed by Laszlo Gombos.
1791
1792         p11-kit, libgpg-error and libgcrypt don't influence on layout test. So, we don't need to
1793         handle them using jhbuild. We can reduce build time when using --update-efl.
1794
1795         * efl/jhbuild.modules:
1796
1797 2013-05-08  Seokju Kwon  <seokju.kwon@gmail.com>
1798
1799         [EFL] Disable SHADOW DOM feature in FeatureList.pm
1800         https://bugs.webkit.org/show_bug.cgi?id=115834
1801
1802         Reviewed by Gyuyoung Kim.
1803
1804         * Scripts/webkitperl/FeatureList.pm:
1805
1806 2013-05-08  Lucas Forschler  <lforschler@apple.com>
1807
1808         Add Scheduler for Mac MtnLion 32bit Release builder.
1809
1810         Unreviewed.
1811
1812         * BuildSlaveSupport/build.webkit.org-config/config.json:
1813
1814 2013-05-08  Denis Nomiyama  <d.nomiyama@samsung.com>
1815
1816         Update JSCIdentifier pretty printer in Tools/gdb/webkit.py
1817         https://bugs.webkit.org/show_bug.cgi?id=115808
1818
1819         Reviewed by Darin Adler.
1820
1821         The pretty printer for the JSCIdentifier in Tools/gdb/webkit.py
1822         was left outdated after r127191, when the m_string member was changed
1823         from UString to String. This patch calls the right pretty printer for it.
1824
1825         * gdb/webkit.py:
1826         (JSCIdentifierPrinter.to_string): Use WTFPrettyPrinter instead of
1827         WTFImplPrettyPrinter.
1828
1829 2013-05-08  Andy Estes  <aestes@apple.com>
1830
1831         [WebKit2] REGRESSION (Custom Protocols): Reproducible crash when navigating to URL with an invalid scheme
1832         https://bugs.webkit.org/show_bug.cgi?id=115790
1833
1834         Reviewed by Alexey Proskuryakov.
1835
1836         Added two API tests:
1837
1838         1) Verify that +[WKBrowsingContextController (un)registerSchemeForCustomProtocol:] can be called with a nil NSString without crashing.
1839         2) Verify that +[WKCustomProtocol canInitWithRequest:] does not crash when passed an NSURLRequest with an invalid scheme.
1840
1841         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1842         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm: Added.
1843         (TestWebKitAPI):
1844         (TestWebKitAPI::TEST):
1845         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp: Added.
1846         (TestWebKitAPI):
1847         (TestWebKitAPI::decidePolicyForNavigationAction):
1848         (CustomProtocolInvalidSchemeTest):
1849         (TestWebKitAPI::CustomProtocolInvalidSchemeTest::CustomProtocolInvalidSchemeTest):
1850
1851 2013-05-08  Lucas Forschler  <lforschler@apple.com>
1852
1853         Teach buildbot how to compile 32-bit on Mac.
1854
1855         Reviewed by Ryosuke Niwa.
1856
1857         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1858         (CompileWebKit.start):
1859         (ExtractTestResultsAndLeaks):
1860
1861 2013-05-08  Eli Fidler  <efidler@blackberry.com>
1862
1863         [BlackBerry] Fix usage of BlackBerry::Platform::String
1864         https://bugs.webkit.org/show_bug.cgi?id=115781
1865
1866         Reviewed by Rob Buis.
1867
1868         BlackBerry PRs 304193 and 327181
1869         Internally Reviewed by Mike Lattanzio, Arvid Nilsson, Joe Mason, Jeff Rogers, and George Staikos
1870
1871         We currently have a problem where we're passing UTF-8 encoded data into
1872         the char* constructors of BlackBerry::Platform::String. This means the string
1873         thinks its data is not UTF-8.
1874
1875         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1876         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
1877         (BlackBerry::WebKit::dumpHistoryItem):
1878         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1879         (TestRunner::setUserStyleSheetLocation):
1880         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
1881         (LoadHTMLStringItem::invoke):
1882
1883 2013-05-08  Alberto Garcia  <agarcia@igalia.com>
1884
1885         Tools: add new BlackBerry include dirs.
1886         https://bugs.webkit.org/show_bug.cgi?id=115514
1887
1888         Reviewed by Rob Buis.
1889
1890         iType include dirs are missing, and HarfBuzz needs to be fixed.
1891
1892         * Scripts/webkitdirs.pm:
1893         (blackberryCMakeArguments):
1894
1895 2013-05-08  José Dapena Paz  <jdapena@igalia.com> and Zan Dobersek  <zdobersek@igalia.com>
1896
1897         [GTK] Plumb the Automake build system for the Battery Status API feature
1898         https://bugs.webkit.org/show_bug.cgi?id=115718
1899
1900         Reviewed by Martin Robinson.
1901
1902         * Scripts/webkitdirs.pm:
1903         (buildAutotoolsProject): List battery-status as a configurable feature, meaning its value will be adjusted
1904         through the --(enable|disable)-battery-status flag passed to configure.
1905
1906 2013-05-08  Ryosuke Niwa  <rniwa@webkit.org>
1907
1908         new-run-webkit-websocketserver doesn't work after Chromium removal
1909         https://bugs.webkit.org/show_bug.cgi?id=115816
1910
1911         Reviewed by Joseph Pecoraro.
1912
1913         Fix the bug by instantiating the correct port object.
1914
1915         * Scripts/new-run-webkit-websocketserver:
1916         (main):
1917
1918 2013-05-07  Lucas Forschler  <lforschler@apple.com>
1919
1920         Configure buildbot for 32bit builder.
1921         https://bugs.webkit.org/show_bug.cgi?id=115769
1922
1923         Reviewed by Ryosuke Niwa.
1924
1925         * BuildSlaveSupport/build.webkit.org-config/config.json:
1926
1927 2013-05-08  Brent Fulgham  <bfulgham@webkit.org>
1928
1929         Unreviewed. Update to show my apple.com address.
1930
1931         * Scripts/webkitpy/common/config/contributors.json: Added
1932         my apple.com e-mail address.
1933
1934 2013-05-08  David Kilzer  <ddkilzer@apple.com>
1935
1936         BUILD FIX (r149579): Use Vector::appendVector() instead of Vector::append()
1937
1938         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1939         (concatenateAttributeAndValue): Switch to appendVector().
1940
1941 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
1942
1943         [Qt][WTR] Fix the build on Mac after r149692
1944
1945         Unreviewed build fix.
1946
1947         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1948         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
1949
1950 2013-05-08  Mario Sanchez Prada  <mario.prada@samsung.com>
1951
1952         Unreviewed. Added Anton Obzhirov to the list of contributors and myself
1953         to the watchlist for Accessibility.
1954
1955         * Scripts/webkitpy/common/config/contributors.json: Added Anton Obzhirov.
1956         * Scripts/webkitpy/common/config/watchlist: Added myself.
1957
1958 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
1959
1960         [Qt] Build fails with clang
1961         https://bugs.webkit.org/show_bug.cgi?id=115741
1962
1963         Reviewed by Benjamin Poulain.
1964
1965         Since r149112 std::move is used in AtomicString for compilers that
1966         support rvalue references and this requires a standard library
1967         implementing c++11 move semantics.
1968         We only explicitely require c++11 for WebKit2, but since clang supports
1969         rvalue references the build of subtargets using AtomicString fails because
1970         of missing std::move.
1971         It is safe to add CONFIG += c++11 for the whole project when using clang
1972         since we explicitely disable c++11 for ANGLE that had probems with libc++.
1973
1974         * qmake/mkspecs/features/unix/default_pre.prf:
1975
1976 2013-05-08  Darin Adler  <darin@apple.com>
1977
1978         Fix one more place that needed to use adoptCF/NS
1979         https://bugs.webkit.org/show_bug.cgi?id=115778
1980
1981         Reviewed by Benjamin Poulain.
1982
1983         Not sure why I missed this code last time, but found a bit more code that needs
1984         to switch to the newer style adoptCF/NS.
1985
1986         * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
1987         (convertWebResourceDataToString): Use adoptCF.
1988         (convertWebResourceResponseToDictionary): Ditto.
1989         (createXMLStringFromWebArchiveData): Ditto.
1990         * WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm:
1991         (createCFURLResponseFromResponseData): Use adoptNS and adoptCF.
1992
1993 2013-05-08  Commit Queue  <commit-queue@webkit.org>
1994
1995         Unreviewed, rolling out r149271.
1996         http://trac.webkit.org/changeset/149271
1997         https://bugs.webkit.org/show_bug.cgi?id=115780
1998
1999         The mangled symbols are now enforced through LDFLAGS
2000         (Requested by zdobersek on #webkit).
2001
2002         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
2003
2004 2013-05-08  Zan Dobersek  <zdobersek@igalia.com>
2005
2006         [Flakiness Dashboard] Remove the Chromium fallback platforms listing from the legend popup
2007         https://bugs.webkit.org/show_bug.cgi?id=115636
2008
2009         Reviewed by Ryosuke Niwa.
2010
2011         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2012         (showLegend): Remove the listing of the Chromium fallback platforms from the legend popup. The code iterated
2013         through the platforms in the g_fallbacksMap dictionary to construct this part of the legend, but the dictionary,
2014         while Chromium-specific, can't be removed just yet as there's more code that uses it.
2015
2016 2013-05-06  Darin Adler  <darin@apple.com>
2017
2018         Use adoptCF and adoptNS in more places, test code and code not compiled on Mac
2019         https://bugs.webkit.org/show_bug.cgi?id=115657
2020
2021         Reviewed by Sam Weinig.
2022
2023         This is similar to my last set of changes, but covers code that I missed with
2024         global replace using the Safari Xcode workspace.
2025
2026         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
2027         (convertWebResourceDataToString):
2028         (convertWebResourceResponseToDictionary):
2029         (createXMLStringFromWebArchiveData):
2030         * DumpRenderTree/cg/ImageDiffCG.cpp:
2031         (createImageFromStdin):
2032         (createDifferenceImage):
2033         (main):
2034         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2035         (printPNG):
2036         (dumpBitmap):
2037         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2038         (BitmapContext::BitmapContext):
2039         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
2040         (-[MockWebNotificationProvider init]):
2041         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2042         (createBitmapContext):
2043         * DumpRenderTree/mac/TestRunnerMac.mm:
2044         (TestRunner::addDisallowedURL):
2045         (TestRunner::applicationCacheDiskUsageForOrigin):
2046         (TestRunner::localStorageDiskUsageForOrigin):
2047         (TestRunner::clearApplicationCacheForOrigin):
2048         (TestRunner::deleteLocalStorageForOrigin):
2049         (TestRunner::copyDecodedHostName):
2050         (TestRunner::copyEncodedHostName):
2051         (TestRunner::queueLoad):
2052         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
2053         (TestRunner::setMockGeolocationPositionUnavailableError):
2054         (TestRunner::setUserStyleSheetLocation):
2055         (TestRunner::setValueForUser):
2056         (TestRunner::overridePreference):
2057         (TestRunner::setPersistentUserStyleSheetLocation):
2058         (TestRunner::execCommand):
2059         (TestRunner::findString):
2060         (TestRunner::isCommandEnabled):
2061         (TestRunner::addOriginAccessWhitelistEntry):
2062         (TestRunner::removeOriginAccessWhitelistEntry):
2063         (TestRunner::addUserScript):
2064         (TestRunner::addUserStyleSheet):
2065         (TestRunner::evaluateInWebInspector):
2066         (TestRunner::evaluateScriptInIsolatedWorld):
2067         (TestRunner::apiTestNewWindowDataLoadBaseURL):
2068         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
2069         (TestRunner::authenticateSession):
2070         (TestRunner::grantWebNotificationPermission):
2071         (TestRunner::denyWebNotificationPermission):
2072         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
2073         (createCFURLResponseFromResponseData):
2074         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2075         (LoadItem::invoke):
2076         (LoadHTMLStringItem::invoke):
2077         (ScriptItem::invoke):
2078         * DumpRenderTree/win/DumpRenderTree.cpp:
2079         (substringFromIndex):
2080         (urlSuitableForTestResult):
2081         (lastPathComponent):
2082         (sharedCFURLCache):
2083         * DumpRenderTree/win/ImageDiffCairo.cpp:
2084         (createImageFromStdin):
2085         (main):
2086         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2087         (createBitmapContextFromWebView):
2088         * DumpRenderTree/win/TestRunnerWin.cpp:
2089         (TestRunner::setUserStyleSheetLocation):
2090         (TestRunner::setPersistentUserStyleSheetLocation):
2091         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2092         (TestWebKitAPI::TEST):
2093         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
2094         (TestWebKitAPI::TEST):
2095         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
2096         (TestWebKitAPI::TEST):
2097         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
2098         (TestWebKitAPI::TEST):
2099         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
2100         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2101         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
2102         (TestWebKitAPI::createWindow):
2103         (TestWebKitAPI::TEST):
2104         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
2105         (TestWebKitAPI::TEST):
2106         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
2107         (TestWebKitAPI::AcceptsFirstMouse::runTest):
2108         * TestWebKitAPI/Tests/mac/AttributedString.mm:
2109         (TestWebKitAPI::TEST):
2110         * TestWebKitAPI/Tests/mac/BackForwardList.mm:
2111         (TestWebKitAPI::TEST):
2112         * TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm:
2113         (TestWebKitAPI::TEST):
2114         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
2115         (TestWebKitAPI::TEST):
2116         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm:
2117         (TestWebKitAPI::TEST):
2118         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
2119         (TestWebKitAPI::TEST):
2120         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm:
2121         (TestWebKitAPI::TEST):
2122         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
2123         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
2124         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
2125         (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow):
2126         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
2127         (TestWebKitAPI::TEST):
2128         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
2129         (TestWebKitAPI::TEST):
2130         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
2131         (TestWebKitAPI::TEST):
2132         * TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.mm:
2133         (TestWebKitAPI::TEST):
2134         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
2135         (TestWebKitAPI::TEST):
2136         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2137         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
2138         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
2139         (TestWebKitAPI::TEST):
2140         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
2141         (TestWebKitAPI::TEST):
2142         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
2143         (TestWebKitAPI::TEST):
2144         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
2145         (TestWebKitAPI::TEST):
2146         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
2147         (TestWebKitAPI::TEST):
2148         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
2149         (TestWebKitAPI::TEST):
2150         * TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm:
2151         (TestWebKitAPI::TEST):
2152         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2153         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
2154         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2155         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
2156         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
2157         * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
2158         (WTR::testPathFromURL):
2159         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2160         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2161         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2162         (WTR::createCGContextFromImage):
2163         (WTR::dumpBitmap):
2164         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2165         * WebKitTestRunner/mac/EventSenderProxy.mm:
2166         (WTR::EventSenderProxy::mouseScrollBy):
2167         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2168         (WTR::PlatformWebView::windowSnapshotImage):
2169         * WebKitTestRunner/win/TestControllerWin.cpp:
2170         (WTR::TestController::initializeTestPluginDirectory):
2171         Use adoptCF and adoptNS.
2172
2173 2013-05-07  Alex Christensen  <achristensen@apple.com>
2174
2175         Fix a memory leak introduced in r149692
2176         https://bugs.webkit.org/show_bug.cgi?id=115766
2177
2178         Reviewed by Mark Rowe.
2179
2180         In r149692, the fix for <http://webkit.org/b/42324>, a call to WKBundleFrameCopyWebArchive was added without any
2181         matching call to WKRelease. An earlier attempted fix in r149697 introduced a RetainPtr but failed to adopt the object.
2182
2183         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2184         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
2185         Fix the memory leak by switching to WKRetainPtr and adopting the returned object.
2186
2187 2013-05-07  Darin Adler  <darin@apple.com>
2188
2189         [Win] Fix storage leak in Windows DumpRenderTree
2190         https://bugs.webkit.org/show_bug.cgi?id=115651
2191
2192         Reviewed by Sam Weinig.
2193
2194         * DumpRenderTree/win/DumpRenderTree.cpp:
2195         (lastPathComponent): Added a missing call to adoptCF.
2196
2197 2013-05-07  Alex Christensen  <achristensen@apple.com>
2198
2199         fixed a memory leak introduced by bug 42324 by using a RetainPtr
2200         https://bugs.webkit.org/show_bug.cgi?id=115760
2201
2202         Reviewed by Tim Horton.
2203
2204         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2205         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
2206         fixed memory leak, added UNUSED_PARAM macros
2207
2208 2013-05-07  Alex Christensen  <achristensen@apple.com>
2209
2210         WebKitTestRunner needs testRunner.dumpDOMAsWebArchive
2211         https://bugs.webkit.org/show_bug.cgi?id=42324
2212         <rdar://problem/8193633>
2213
2214         Reviewed by Tim Horton.
2215
2216         * Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2217         Added dumpDOMAsWebArchive JavaScript function to be called by test cases.
2218         * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2219         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
2220         Added dumpDOMAsWebArchive code that is called when dumping.
2221         (WTR::InjectedBundlePage::dump):
2222         Made DOMAsWebArchive case when dumping call dumpDOMAsWebArchive.
2223         * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2224         (InjectedBundlePage):
2225         Added dumpDOMAsWebArchive declaration.
2226         * Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
2227         (WTR::TestRunner::dumpDOMAsWebArchive):
2228         Added dumpDOMAsWebArchive JS callback function that sets m_whatToDump to DOMAsWebArchive.
2229         * Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2230         Added WebArchiveDumpSupport.cpp, WebArchiveDumpSupport.h, WebArchiveDumpSupportMac.mm to project.
2231         * Tools/WebKitTestRunner/cf: Added.
2232         * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.cpp: Added.
2233         Copied from Tools/DumpRenderTree/cf for createXMLStringFromWebArchiveData and other functions it uses.
2234         (convertMIMEType):
2235         (convertWebResourceDataToString):
2236         (normalizeHTTPResponseHeaderFields):
2237         (normalizeWebResourceURL):
2238         (convertWebResourceResponseToDictionary):
2239         (compareResourceURLs):
2240         (createXMLStringFromWebArchiveData):
2241         * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.h: Added.
2242         Copied from Tools/DumpRenderTree/cf for used symbol declarations.
2243         * Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm: Added.
2244         Copied from Tools/DumpRenderTree/mac for used functions.
2245         (createCFURLResponseFromResponseData):
2246         (supportedNonImageMIMETypes):
2247
2248 2013-05-07  Alex Christensen  <achristensen@apple.com>
2249
2250         Updated style of WebArchiveDumpSupport before putting it into WebKitTestRunner.
2251         https://bugs.webkit.org/show_bug.cgi?id=115745
2252
2253         Reviewed by Tim Horton.
2254
2255         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
2256         (compareResourceURLs):
2257         Updated style.
2258
2259 2013-05-06  Ryosuke Niwa  <rniwa@webkit.org>
2260
2261         Add an 'isReadOnly' member to IDL parse tree structure
2262         https://bugs.webkit.org/show_bug.cgi?id=115704
2263
2264         Reviewed by Kentaro Hara.
2265
2266         Use newly added isReadOnly attribute.
2267
2268         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2269         (_generateHeaderFile):
2270         (_generateImplementationFile):
2271         (_staticValuesGetterImplementation):
2272
2273 2013-05-07  Anders Carlsson  <andersca@apple.com>
2274
2275         Remove AlwaysInline.h from WTF
2276         https://bugs.webkit.org/show_bug.cgi?id=115727
2277
2278         Reviewed by Brent Fulgham.
2279
2280         The macro that used to be in AlwaysInline.h is now in Compiler.h so there's no reason
2281         to keep AlwaysInline.h around anymore.
2282
2283         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
2284         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
2285
2286 2013-05-07  Andras Becsi  <andras.becsi@digia.com>
2287
2288         [Qt][WTR] QQuickWindowPrivate::setRenderWithoutShowing has been removed from Qt 5
2289         https://bugs.webkit.org/show_bug.cgi?id=114808
2290
2291         Reviewed by Jocelyn Turcotte.
2292
2293         QQuickWindow::grabWindow() has been implemented for isVisible=false for Qt 5.1.
2294         (https://codereview.qt-project.org/#change,54234)
2295
2296         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2297         (WTR::WrapperWindow::handleStatusChanged):
2298
2299 2013-05-06  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2300
2301         Unreviewed. Add my email to EFL and BindingsScripts watchlists.
2302
2303         * Scripts/webkitpy/common/config/watchlist:
2304
2305 2013-05-06  Kangil Han  <kangil.han@samsung.com>
2306
2307         [EFL][WK1][PerformanceTests] Adopt --no-timeout option implementation to DumpRenderTree
2308         https://bugs.webkit.org/show_bug.cgi?id=115645
2309
2310         Reviewed by Gyuyoung Kim.
2311
2312         To run performance tests in wk1, we need --no-timeout option implementation.
2313         So adopt it from gtk+ port.
2314
2315         * DumpRenderTree/efl/DumpRenderTree.cpp:
2316         (shouldSetWaitToDumpWatchdog):
2317         (parseCommandLineOptions):
2318         * DumpRenderTree/efl/DumpRenderTreeEfl.h:
2319         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2320         (TestRunner::setWaitToDump):
2321
2322 2013-05-06  Commit Queue  <commit-queue@webkit.org>
2323
2324         Unreviewed, rolling out r149547.
2325         http://trac.webkit.org/changeset/149547
2326         https://bugs.webkit.org/show_bug.cgi?id=115682
2327
2328         Added unittests that fail on bots and spits out text into
2329         stdout (Requested by rniwa on #webkit).
2330
2331         * Scripts/import-w3c-tests: Removed.
2332         * Scripts/webkitpy/w3c/__init__.py: Removed.
2333         * Scripts/webkitpy/w3c/test_converter.py: Removed.
2334         * Scripts/webkitpy/w3c/test_converter_unittest.py: Removed.
2335         * Scripts/webkitpy/w3c/test_importer.py: Removed.
2336         * Scripts/webkitpy/w3c/test_importer_unittest.py: Removed.
2337         * Scripts/webkitpy/w3c/test_parser.py: Removed.
2338         * Scripts/webkitpy/w3c/test_parser_unittest.py: Removed.
2339
2340 2013-05-03  Gustavo Noronha Silva  <gns@gnome.org>
2341
2342         [jhbuild] bump jhbuild version to take advantage of new improvements
2343         https://bugs.webkit.org/show_bug.cgi?id=115558
2344
2345         Reviewed by Martin Robinson.
2346
2347         One of the important improvements is jhbuild no longer fetches git
2348         repositories if they are already at the expected revision, which should
2349         make the EWS bots more robust to git servers unavailability.
2350
2351         * jhbuild/jhbuild-wrapper: bump jhbuild to 496974221c3a8ac4fbbc3b0a577c71cac224130d.
2352
2353 2013-05-06  Manuel Rego Casasnovas  <rego@igalia.com>
2354
2355         [GTK] Add webkit_uri_scheme_request_finish_error
2356         https://bugs.webkit.org/show_bug.cgi?id=94316
2357
2358         Reviewed by Anders Carlsson.
2359
2360         * MiniBrowser/gtk/main.c:
2361         (miniBrowserErrorQuark): Add function to create a global quark for
2362         MiniBrowser.
2363         (aboutURISchemeRequestCallback): Update MiniBrowser to use the new
2364         function webkit_uri_scheme_request_finish_error().
2365
2366 2013-05-06  Mike Lattanzio  <mlattanzio@blackberry.com>
2367
2368         [BlackBerry] Enable and Expose Text Autosizing through BlackBerry::WebKit::WebSettings
2369         https://bugs.webkit.org/show_bug.cgi?id=113808
2370
2371         Reviewed by Rob Buis.
2372
2373         Modify FeatureList.pm and set ENABLE_TEXT_AUTOSIZING to default
2374         to true for BlackBerry.
2375
2376         * Scripts/webkitperl/FeatureList.pm:
2377
2378 2013-05-06  Jessie Berlin  <jberlin@apple.com>
2379
2380         check-webkit-style should complain about a layering violation if platform-specific guards are
2381         used in WebCore outside of the platform directory
2382         https://bugs.webkit.org/show_bug.cgi?id=115567
2383
2384         Reviewed by Benjamin Poulain.
2385
2386         * Scripts/webkitpy/style/checkers/cpp.py:
2387         (check_for_webcore_platform_layering_violation):
2388         If the file is in WebCore but not in platform and contains #if PLATFORM(SOMETHING), emit an error.
2389         (process_line):
2390         Add the check_for_webcore_platform_layering_violation.
2391         (CppChecker):
2392         List the new check.
2393
2394         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2395         (CppStyleTest.test_webcore_platform_layering_violation):
2396         Add tests.
2397
2398 2013-05-06  David Kilzer  <ddkilzer@apple.com>
2399
2400         webkit-patch: fix 'upload' command with Bugzilla 4.2.5
2401         <http://webkit.org/b/115667>
2402
2403         Reviewed by Dirk Pranke.
2404
2405         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2406         (Bugzilla._check_create_bug_response): Update regex to work with
2407         Bugzilla 3.2.3 and 4.2.5.
2408         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2409         (test__check_create_bug_response): Add new test that covers both
2410         old and new <title> variations.
2411
2412 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
2413
2414         [Flakiness Dashboard] Stop decoding SnowLeopard builder names into platforms
2415         https://bugs.webkit.org/show_bug.cgi?id=115661
2416
2417         Reviewed by Ryosuke Niwa.
2418
2419         The Apple Mac Snow Leopard builders are no long present so there's no need to try to decode such
2420         builders into the APPLE_MAC_SNOW_LEOPARD platforms. Instead, check for the Mountain Lion builders
2421         and decode their names into the APPLE_MAC_MOUNTAIN_LION platforms.
2422
2423         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2424         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2425
2426 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
2427
2428         [Flakiness Dashboard] Remove everything Chromium from the builders.json-generating script
2429         https://bugs.webkit.org/show_bug.cgi?id=114603
2430
2431         Reviewed by Ryosuke Niwa.
2432
2433         * TestResultServer/generate_builders_json.py:
2434         (insert_builder_and_test_data): Only process the 'layout-tests' steps, but force the name that's used
2435         to represent these to be 'layout-test', for backwards compatibility.
2436         (main): Remove all the build.chromium.org masters.
2437         * TestResultServer/generate_builders_json_unittest.py: Clean up the Chromium-related test cases and update other ones.
2438         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
2439         (GenerateBuildersJsonTest):
2440         (GenerateBuildersJsonTest.test_generate_json_data):
2441         * TestResultServer/static-dashboards/builders.jsonp: Updated after changes to the script, now only lists the
2442         test-running builders from the webkit.org master.
2443
2444 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
2445
2446         [Flakiness Dashboard] Update expected outcome in a couple of unit tests after r148778
2447         https://bugs.webkit.org/show_bug.cgi?id=114988
2448
2449         Reviewed by Ryosuke Niwa.
2450
2451         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Update the expected platforms list, the Chromium
2452         and Apple Mac Snow Leopard platforms were removed with the Apple Mac Mountain Lion platform being added.
2453         * TestResultServer/static-dashboards/loader_unittests.js: Update the list of the expected loaded expectations platforms,
2454         mac-snowleopard isn't loaded anymore due to the support for the platform being removed, while the mac-wk2 is loaded twice,
2455         once for the Apple Mac Lion and once for the Apple Mac Mountain Lion platform.
2456
2457 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
2458
2459         [Flakiness Dashboard] Remove the remaining traces of platform modifier unions
2460         https://bugs.webkit.org/show_bug.cgi?id=114954
2461
2462         Reviewed by Ryosuke Niwa.
2463
2464         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2465         (processExpectationsForPlatform): Remove the platform tree traversal that checked for presence of the platform
2466         modifier unions in the list of modifiers.
2467         (generatePageForExpectationsUpdate): Only filter through the modifiers that do not represent build types or bug references.
2468         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Adjust the test cases for the realModifiers unit test.
2469
2470 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
2471
2472         [Flakiness Dashboard] Simplify builder-name-based platform recognition
2473         https://bugs.webkit.org/show_bug.cgi?id=114957
2474
2475         Reviewed by Ryosuke Niwa.
2476
2477         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2478         (determineBuilderPlatform): Renamed from nonChromiumPlatform.
2479         (chromiumPlatform): Removed, unnecessary.
2480         (platformAndBuildType): With Chromium builders are gone, meaning determineBuilderPlatform can be called by default
2481         to determine the platform of the builder. No need to check for 'DBG' substring in the builder name to determine whether
2482         the builder operates with debug builds, no webkit.org builders are named this way.
2483         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2484         (platformAndBuildTypes): Remove Chromium-specific test cases, reducing the number of expected assertions this test will make.
2485
2486 2013-05-06  Andy Estes  <aestes@apple.com>
2487
2488         Added two files I neglected to commit in r149589.
2489
2490         * TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
2491         * TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.
2492
2493 2013-05-04  Andy Estes  <aestes@apple.com>
2494
2495         REGRESSION (r125592): Reproducible crash in DOMWindow::open when a delegate closes the new window in decidePolicyForNavigationAction
2496         https://bugs.webkit.org/show_bug.cgi?id=115609
2497
2498         Reviewed by Oliver Hunt.
2499
2500         Added an API test.
2501
2502         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2503         * TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
2504         (+[TestDelegate shared]):
2505         (-[TestDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2506         (-[TestDelegate webView:createWebViewWithRequest:]):
2507         (TestWebKitAPI):
2508         (TestWebKitAPI::TEST):
2509         * TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.
2510
2511 2013-05-06  Antoine Quint  <graouts@apple.com>
2512
2513         Manage the presentation of the snapshotted plug-in using JavaScript
2514         https://bugs.webkit.org/show_bug.cgi?id=115548
2515
2516         Reviewed by Dean Jackson.
2517
2518         Take into account the new plugInExtraScript method added to support
2519         the injection of a JS file from the chrome client to customize the
2520         rendering of a snapshotted plug-in's shadow tree.
2521
2522         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2523         (WTR::InjectedBundlePage::InjectedBundlePage):
2524
2525 2013-05-05  Anders Carlsson  <andersca@apple.com>
2526
2527         Remove the Vector::append overload that takes a Vector
2528         https://bugs.webkit.org/show_bug.cgi?id=115535
2529
2530         Reviewed by Andreas Kling.
2531
2532         Use Vector::appendVector instead.
2533
2534         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2535         (concatenateAttributeAndValue):
2536         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2537         (WTR::concatenateAttributeAndValue):
2538
2539 2013-05-04  Sam Weinig  <sam@webkit.org>
2540
2541         REGRESSION(r148312): Crash when calling WKPageClose(page) followed by WKPageTerminate(page)
2542         <rdar://problem/13702008>
2543         https://bugs.webkit.org/show_bug.cgi?id=115607
2544
2545         Reviewed by Benjamin Poulain.
2546
2547         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2548         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp: Added.
2549         (TestWebKitAPI::didFinishLoadForFrame):
2550         (TestWebKitAPI::TEST):
2551         Add test that calls WKPageClose, follow by WKPageTerminate. If it crashes, its not working.
2552
2553 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
2554
2555         Unreviewed.
2556
2557         * Scripts/webkitpy/common/config/contributors.json: Correcting my igalia.com email address.
2558
2559 2013-05-04  Mihnea Ovidenie  <mihnea@adobe.com>
2560
2561         Unreviewed. Adding Radu Stavila as an Adobe contributor, working on CSSRegions.
2562
2563         * Scripts/webkitpy/common/config/contributors.json:
2564
2565 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
2566
2567         [GTK] Catch select.error exceptions in parse_output_lines
2568         https://bugs.webkit.org/show_bug.cgi?id=115253
2569
2570         Reviewed by Gustavo Noronha Silva.
2571
2572         Catch any select.error exceptions when waiting for the file descriptor to become readable when parsing the
2573         output lines in common.parse_output_lines. These are currently being thrown when running the GTK unit tests on
2574         builders, but are not fatal. Because of that they are at the moment only logged (writing out the file descriptor,
2575         error code and the error message) and the loop is re-entered.
2576
2577         * gtk/common.py:
2578         (parse_output_lines):
2579
2580 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
2581
2582         [GTK] Set up the TestWebCore in TestWebKitAPI
2583         https://bugs.webkit.org/show_bug.cgi?id=115237
2584
2585         Reviewed by Gustavo Noronha Silva.
2586
2587         Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
2588         Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
2589         a workaround for the layer violations and circular dependencies between various static libraries. Linking against
2590         either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
2591         shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).
2592
2593         * TestWebKitAPI/GNUmakefile.am:
2594
2595 2013-05-03  Rebecca Hauck  <rhauck@adobe.com>
2596
2597         Create a script to import W3C tests
2598         https://bugs.webkit.org/show_bug.cgi?id=111513
2599
2600         Reviewed by Dirk Pranke.
2601
2602         Script to automate the import of W3C tests into WebKit.
2603         For the full description of how it works, see the comments
2604         at the top of test_importer.py.
2605
2606         * Scripts/import-w3c-tests: Added.
2607         * Scripts/webkitpy/w3c/__init__.py: Added.
2608         * Scripts/webkitpy/w3c/test_converter.py: Added.
2609         (TestConverter):
2610         (TestConverter.__init__):
2611         (TestConverter.load_prefixed_prop_list):
2612         (TestConverter.load_file):
2613         (TestConverter.convert_for_webkit):
2614         (TestConverter.convert_testharness_paths):
2615         (TestConverter.convert_prefixed_properties):
2616         (TestConverter.scrub_unprefixed_props):
2617         (TestConverter.replace_tag):
2618         * Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
2619         (TestConverterTest):
2620         (TestConverterTest.testLoadPrefixedPropList):
2621         (TestConverterTest.test_convertForWebkitNothingToConvert):
2622         (test_convertForWebkitHarnessOnly):
2623         (test_convertForWebkitPropsOnly):
2624         (test_convertForWebkitHarnessAndProps):
2625         (test_convertTestHarnessPaths):
2626         (test_convertPrefixedProperties):
2627         (verifyTestHarnessPaths):
2628         (verifyPrefixedProperties):
2629         (generateTestContent):
2630         * Scripts/webkitpy/w3c/test_importer.py: Added.
2631         (main):
2632         (parse_args):
2633         (validate_import_directory):
2634         (TestImporter):
2635         (TestImporter.__init__):
2636         (TestImporter.do_import):
2637         (TestImporter.get_changeset):
2638         (TestImporter.scan_source_directory):
2639         (TestImporter.import_tests):
2640         (TestImporter.setup_destination_directory):
2641         (TestImporter.get_test_status):
2642         (TestImporter.remove_deleted_files):
2643         (TestImporter.write_import_log):
2644         * Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
2645         (TestImporterTest):
2646         (TestImporterTest.test_ImportDirWithNoTests):
2647         * Scripts/webkitpy/w3c/test_parser.py: Added.
2648         (TestParser):
2649         (TestParser.__init__):
2650         (TestParser.load_file):
2651         (TestParser.analyze_test):
2652         (TestParser.get_reftests):
2653         (TestParser.is_jstest):
2654         (TestParser.get_support_files):
2655         * Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
2656         (TestParserTest):
2657         (TestParserTest.test_analyzeTestReftestOneMatch):
2658         (test_analyzeTestReftestMultipleMatches):
2659         (test_analyzeTestReftestMatchAndMismatch):
2660         (test_analyzeTestReftestWithRefSupportFiles):
2661         (test_analyzeJSTest):
2662         (test_analyzePixelTestAllTrue):
2663         (test_analyzePixelTestAllFalse):
2664         (test_analyzeNonHTMLFile):
2665
2666 2013-05-03  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2667
2668         Unreviewed. Update Viatcheslav Ostapenko's email in contributors.json.
2669
2670         * Scripts/webkitpy/common/config/contributors.json:
2671
2672 2013-05-02  Nico Weber  <thakis@chromium.org>
2673
2674         Remove a stale script file.
2675         https://bugs.webkit.org/show_bug.cgi?id=115521
2676
2677         Reviewed by Anders Carlsson.
2678
2679         This script was added in
2680         https://bugs.webkit.org/show_bug.cgi?id=17507, but it relies on the
2681         Bakefile system that was removed in
2682         https://bugs.webkit.org/show_bug.cgi?id=49983 . As a result, this
2683         script just asserts when it's run and is useless.
2684
2685         * Scripts/update-sources-list.py: Removed.
2686
2687 2013-05-01  Glenn Adams  <glenn@skynav.com>
2688
2689         [webkitpy] Need abstract base class for commands that analyze commit logs
2690         https://bugs.webkit.org/show_bug.cgi?id=115391
2691
2692         Reviewed by Benjamin Poulain.
2693
2694         Move commit log parsing functions into new abstract base class AbstractCommitLogCommand
2695         in preparation for adding two new commands that will reuse this functionality along with
2696         suggest-nominations. See https://bugs.webkit.org/show_bug.cgi?id=115387 and
2697         https://bugs.webkit.org/show_bug.cgi?id=115388.
2698
2699         No new tests as this patch does not change existing functionality or behavior.
2700
2701         * Scripts/webkitpy/tool/commands/suggestnominations.py:
2702         (AbstractCommitLogCommand): Add abstract base class for commands that analyze commit logs.
2703         (AbstractCommitLogCommand.__init__):
2704         (AbstractCommitLogCommand._init_options):
2705         (AbstractCommitLogCommand._parse_commit_message):
2706         (SuggestNominations): Move generic commit log parsing into new base class. Use new base class.
2707         (SuggestNominations.__init__):
2708         (SuggestNominations._init_options):
2709
2710 2013-05-01  Seokju Kwon  <seokju.kwon@gmail.com>
2711
2712         Web Inspector: Fix check-inspector-strings script and fix localized strings
2713         https://bugs.webkit.org/show_bug.cgi?id=115495
2714
2715         Reviewed by Joseph Pecoraro.
2716
2717         * Scripts/check-inspector-strings:
2718
2719 2013-05-01  Zan Dobersek  <zdobersek@igalia.com>
2720
2721         [TestWebKitAPI] <WebKit2/WebKit2_C.h> being included in GTK WK1-only builds
2722         https://bugs.webkit.org/show_bug.cgi?id=115470
2723
2724         Reviewed by Martin Robinson.
2725
2726         In the TestWebKitAPI's config.h header, only include the <WebKit2/WebKit2_C.h> header when
2727         not building either of the IOS, Windows or GTK-WK1 platforms.
2728
2729         Up until now the header was included for everything but the IOS and Windows platforms due to
2730         an incorrectly stated condition regarding the GTK platform.
2731
2732         * TestWebKitAPI/config.h:
2733
2734 2013-05-01  Zan Dobersek  <zdobersek@igalia.com>
2735
2736         [GTK] Split the forwarding headers stamp in the TestWebKitAPI GNUmakefile.am
2737         https://bugs.webkit.org/show_bug.cgi?id=115469
2738
2739         Reviewed by Martin Robinson.
2740
2741         Split the stamp-testwebkitapi-forwarding-headers into two stamps, one covering forwarding headers
2742         for the WebCore tests (under the Tests/WebCore directory) and the other covering forwarding headers
2743         for the WebKit2 tests and the injected bundle required by them.
2744
2745         This makes it possible for the WebCore tests to compile when the WebKit2 build is disabled, i.e. the WebCore
2746         tests shouldn't depend on the WebKit2 build (though the forwarding headers generation script is stored
2747         under the WebKit2 code).
2748
2749         The WebCore forwarding headers are generated by scanning only the files under the Tests/WebCore directory,
2750         while the WebKit2 forwarding headers generation should keep on scanning the complete root directory of the
2751         TestWebKitAPI subproject, though the target directory should be narrowed down if at all possible.
2752
2753         * TestWebKitAPI/GNUmakefile.am:
2754
2755 2013-04-30  Glenn Adams  <glenn@skynav.com>
2756
2757         Unreviewed. Add myself to watchlist entries.
2758
2759         * Scripts/webkitpy/common/config/watchlist:
2760
2761 2013-04-30  Glenn Adams  <glenn@skynav.com>
2762
2763         [webkitpy] suggest-nominations doesn't count all qualified patches
2764         https://bugs.webkit.org/show_bug.cgi?id=115285
2765
2766         Reviewed by Benjamin Poulain.
2767
2768         Fix commit analysis so that patches made by an existing committer are counted towards reviewer
2769         nomination. Improve commit log parsing.
2770
2771         * Scripts/webkitpy/tool/commands/suggestnominations.py:
2772         (CommitLogError):
2773         (CommitLogError.__init__):
2774         (CommitLogMissingReviewer):
2775         (CommitLogMissingReviewer.__init__):
2776         (SuggestNominations):
2777         (SuggestNominations.__init__):
2778         (SuggestNominations._recent_commit_messages):
2779         (SuggestNominations._author_name_from_email):
2780         (SuggestNominations._contributor_from_email):
2781         (SuggestNominations._parse_commit_message):
2782         (SuggestNominations._count_commit):
2783         (SuggestNominations._count_recent_patches):
2784         (SuggestNominations._collect_nominations):
2785         (SuggestNominations._print_nominations):
2786         (SuggestNominations.execute):
2787         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2788         (_make_options):
2789         (test_recent_commit_messages):
2790         (test_basic):
2791
2792 2013-04-30  Commit Queue  <rniwa@webkit.org>
2793
2794         Unreviewed, rolling out r149309.
2795         http://trac.webkit.org/changeset/149309
2796         https://bugs.webkit.org/show_bug.cgi?id=115430
2797
2798         The patch does not build on WK1-only builds of the GTK port
2799         (Requested by zdobersek on #webkit).
2800
2801         * TestWebKitAPI/GNUmakefile.am:
2802
2803 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2804
2805         Stop using "in" keyword in IDL files
2806         https://bugs.webkit.org/show_bug.cgi?id=115418
2807
2808         Reviewed by Kentaro Hara.
2809
2810         Remove "in" keyword from IDL files as this is no longer part of the Web
2811         IDL specification.
2812
2813         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2814         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl:
2815         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl:
2816         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2817         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2818         * WebKitTestRunner/InjectedBundle/Bindings/GCController.idl:
2819         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2820         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
2821
2822 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2823
2824         [EFL] Enable scaled cursors
2825         https://bugs.webkit.org/show_bug.cgi?id=106242
2826
2827         Reviewed by Gyuyoung Kim.
2828
2829         Enable ENABLE_MOUSE_CURSOR_SCALE for EFL port.
2830
2831         * Scripts/webkitperl/FeatureList.pm:
2832
2833 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2834
2835         Replace "Optional" extended attribute by proper Web IDL "optional" keyword
2836         https://bugs.webkit.org/show_bug.cgi?id=115380
2837
2838         Reviewed by Kentaro Hara.
2839
2840         Replace WebKit-specific [Optional] extended attribute by Web IDL "optional"
2841         keyword.
2842
2843         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2844         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2845
2846 2013-04-30  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2847
2848         Fix the USE(3D_GRAPHICS) build with the standard OpenGL on Windows
2849         https://bugs.webkit.org/show_bug.cgi?id=114684
2850
2851         Reviewed by Simon Hausmann.
2852
2853         Remove the ANGLE requirement for USE(3D_GRAPHICS).
2854         This enables WebKit2 in the build when using a "-opengl desktop" configured Qt.
2855
2856         * qmake/mkspecs/features/features.prf:
2857
2858 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
2859
2860         [GTK] Disable Shadow DOM feature
2861         https://bugs.webkit.org/show_bug.cgi?id=115374
2862
2863         Reviewed by Martin Robinson.
2864
2865         Disable the Shadow DOM feature on the GTK port, the feature is planned for removal.
2866
2867         * Scripts/webkitperl/FeatureList.pm:
2868
2869 2013-04-29  Glenn Adams  <glenn@skynav.com>
2870
2871         [webkitpy] Add missing contributor email addresses
2872         https://bugs.webkit.org/show_bug.cgi?id=115394
2873
2874         Reviewed by Ryosuke Niwa.
2875
2876         * Scripts/webkitpy/common/config/contributors.json:
2877
2878 2013-04-29  Alberto Garcia  <agarcia@igalia.com>
2879
2880         Remove all remaining Skia code
2881         https://bugs.webkit.org/show_bug.cgi?id=115263
2882
2883         Reviewed by Benjamin Poulain.
2884
2885         Remove all remaining references to Skia.
2886
2887         * Scripts/webkitdirs.pm:
2888         (blackberryCMakeArguments):
2889         * Scripts/webkitpy/common/config/contributionareas.py:
2890         * Scripts/webkitpy/common/config/watchlist:
2891
2892 2013-04-29  Seokju Kwon  <seokju.kwon@gmail.com>
2893
2894         Get rid of unused options in Tools/Scripts/webkit-build-directory
2895         https://bugs.webkit.org/show_bug.cgi?id=115383
2896
2897         Reviewed by Darin Adler.
2898
2899         * Scripts/webkit-build-directory:
2900
2901 2013-04-29  Alexey Proskuryakov  <ap@apple.com>
2902
2903         [WK2][Mac] Test with NetworkProcess enabled.
2904
2905         Fix the build for non-Mac.
2906
2907         * WebKitTestRunner/TestController.cpp:
2908         (WTR::TestController::initialize):
2909
2910 2013-04-29  Alexey Proskuryakov  <ap@apple.com>
2911
2912         [WK2][Mac] Test with NetworkProcess enabled.
2913
2914         Reviewed by Sam Weinig.
2915
2916         * WebKitTestRunner/TestController.cpp:
2917         (WTR::TestController::initialize):
2918
2919 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
2920
2921         [GTK] Set up the TestWebCore in TestWebKitAPI
2922         https://bugs.webkit.org/show_bug.cgi?id=115237
2923
2924         Reviewed by Gustavo Noronha Silva.
2925
2926         Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
2927         Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
2928         a workaround for the layer violations and circular dependencies between various static libraries. Linking against
2929         either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
2930         shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).
2931
2932         * TestWebKitAPI/GNUmakefile.am:
2933
2934 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
2935
2936         [GTK] Set up the TestJavaScriptCore in TestWebKitAPI
2937         https://bugs.webkit.org/show_bug.cgi?id=115236
2938
2939         Reviewed by Gustavo Noronha Silva.
2940
2941         Set up the TestJavaScriptCore unit test program, consisting of the unit tests
2942         under the TestWebKitAPI/Tests/JavaScriptCore directory.
2943
2944         * TestWebKitAPI/GNUmakefile.am:
2945
2946 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
2947
2948         [GTK] Export the COLLECT_NO_DEMANGLE variable on the builders
2949         https://bugs.webkit.org/show_bug.cgi?id=115323
2950
2951         Reviewed by Philippe Normand.
2952
2953         Export the COLLECT_NO_DEMANGLE environment variable on the GTK BuildBot builders.
2954         Its presence enforces linkers to output mangled symbols when reporting linking failures
2955         due to unresolved references. People trying to fix the build can then simply copy
2956         the printed mangled symbol into the symbols.filter file instead of doing a manual build
2957         or connecting to the builders to discover the mangled version of the missing symbol.
2958
2959         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
2960
2961 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
2962
2963         Remove Chromium code from Tools/BuildSlaveSupport
2964         https://bugs.webkit.org/show_bug.cgi?id=115325
2965
2966         Reviewed by Benjamin Poulain.
2967
2968         Remove the two Chromium-specific scripts and the Chromium-specific parts from the code
2969         covering archiving test results and built products.
2970
2971         * BuildSlaveSupport/built-product-archive:
2972         (archiveBuiltProduct):
2973         (extractBuiltProduct):
2974         * BuildSlaveSupport/chromium/output-android-device-status: Removed.
2975         * BuildSlaveSupport/chromium/remove-crash-logs: Removed.
2976         * BuildSlaveSupport/test-result-archive:
2977         (archiveTestResults):
2978
2979 2013-04-28  Seokju Kwon  <seokju.kwon@gmail.com>
2980
2981         Remove support for Chromium from webkitdirs.pm
2982         https://bugs.webkit.org/show_bug.cgi?id=115338
2983
2984         Reviewed by Darin Adler.
2985
2986         * Scripts/webkitdirs.pm:
2987         (determineBaseProductDir):
2988         (argumentsForConfiguration):
2989         (builtDylibPathForName):
2990         (determineIsQt):
2991         (isAppleWebKit):
2992
2993 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
2994
2995         Rename TestRunner's setAudioData to setAudioResult
2996         https://bugs.webkit.org/show_bug.cgi?id=115326
2997
2998         Reviewed by Darin Adler.
2999
3000         Rename the TestRunner's setAudioData method to setAudioResult. The new name better conveys the method's purpose
3001         than the previous one. The change is a simple rename, there's no change in the method's functionality. The
3002         affected tests are adjusted accordingly.
3003
3004         * DumpRenderTree/qt/TestRunnerQt.cpp:
3005         (TestRunnerQt::setAudioResult):
3006         * DumpRenderTree/qt/TestRunnerQt.h:
3007         (TestRunnerQt):
3008         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3009         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3010         (WTR::TestRunner::setAudioResult):
3011         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3012         (TestRunner):
3013
3014 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
3015
3016         [WKTR] Tests dumping audio data shouldn't dump pixels
3017         https://bugs.webkit.org/show_bug.cgi?id=115270
3018
3019         Reviewed by Benjamin Poulain.
3020
3021         Prevent dumping the pixel output when Web Audio tests are dumping output data
3022         as the testing output. Pixel output in these tests has no real meaning and is
3023         as such unnecessary.
3024
3025         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3026         (WTR::TestRunner::setAudioData):
3027
3028 2013-04-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3029
3030         [EFL] Unreviewed Intel bots fix after r149231.
3031
3032         * efl/jhbuild.modules: Disable the libxml Python bindings since the
3033         bots don't have Python's development files installed. libxml should
3034         detect this kind of thing better.
3035
3036 2013-04-26  Ryuan Choi  <ryuan.choi@samsung.com>
3037
3038         [EFL] Build break using jhbuild on ubuntu 13.04
3039         https://bugs.webkit.org/show_bug.cgi?id=115225
3040
3041         Reviewed by Gyuyoung Kim.
3042
3043         libxslt in Ubuntu 13.04 requires libxml 2.9.0 or higher and
3044         libxml 2.9.0 has a bug to make regression which r138422 mentioned.
3045         So this patch bumped libxml version to 2.9.1.
3046
3047         * efl/jhbuild.modules:
3048
3049 2013-04-26  Jeffrey Pfau  <jpfau@apple.com>
3050
3051         delete-stale-build-files does not clear .d files
3052         http://bugs.webkit.org/show_bug.cgi?id=115293
3053
3054         Reviewed by Ryosuke Niwa.
3055
3056         * BuildSlaveSupport/delete-stale-build-files:
3057         (main): Add .d to the file type list
3058
3059 2013-04-26  Roger Fong  <roger_fong@apple.com>
3060
3061         Make Apple Windows VS2010 build results into and get dependencies from __32 suffixed folders.
3062         Make the DebugSuffix configuration use _debug dependencies.
3063
3064         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3065         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeApple.props:
3066         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
3067         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props:
3068         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
3069         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
3070         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props:
3071         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props:
3072         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props:
3073         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
3074         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd:
3075         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props:
3076         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
3077         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
3078         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
3079         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props:
3080         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props:
3081         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props:
3082         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
3083         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props:
3084         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props:
3085         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props:
3086         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
3087         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props:
3088         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
3089         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props:
3090         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def:
3091         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
3092         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
3093         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
3094         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props:
3095         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props:
3096         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
3097         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin_debug.def: Removed.
3098         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3099         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
3100         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
3101         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props:
3102         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
3103         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props:
3104         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
3105         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
3106         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
3107         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props:
3108         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props:
3109         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3110         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
3111         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props:
3112         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props:
3113         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
3114         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props:
3115         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
3116         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
3117         * win/AssembleBuildLogs/AssembleLogs.cmd:
3118         * win/record-memory/record-memory.vcxproj:
3119         * win/record-memory/record-memoryDebug.props:
3120         * win/record-memory/record-memoryDebugWinCairo.props:
3121         * win/record-memory/record-memoryProduction.props:
3122         * win/record-memory/record-memoryRelease.props:
3123         * win/record-memory/record-memoryReleaseWinCairo.props:
3124
3125 2013-04-26  Zan Dobersek  <zdobersek@igalia.com>
3126
3127         [GTK] Clean up the TestWebKitAPI GNUmakefile.am
3128         https://bugs.webkit.org/show_bug.cgi?id=115233
3129
3130         Reviewed by Martin Robinson.
3131
3132         Specify unconditional, non-installable program targets in one declaration. Only conditionally specify
3133         WebKit2-specific targets, not the complete target setups (i.e. targets' sources, cppflags listings etc.).
3134         Add missing unit test source files to the TestWTF program, namely HashSet.cpp and MetaAllocator.cpp.
3135         Specify the TestWTF program's CXXFLAGS to be the same as the global cxxflags as the source files need to
3136         be compiled with the -fno-rtti flag that's present in the global_cxxflags variable.
3137
3138         * TestWebKitAPI/GNUmakefile.am:
3139
3140 2013-04-25  Andy Estes  <aestes@apple.com>
3141
3142         [WebKit2] Loading a resource from a custom protocol in a synchronous XHR times out
3143         https://bugs.webkit.org/show_bug.cgi?id=115223
3144
3145         Reviewed by Darin Adler.
3146
3147         Added an API test.
3148
3149         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
3150         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm: Added.
3151         (TestWebKitAPI::TEST): Tested that a synchronous XHR does not time out
3152         when it loads a request with a custom protocol.
3153         * TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Added.
3154         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: Moved the
3155         NSURLProtocol subclass to TestProtocol.{h, mm} and did some
3156         miscellaneous cleanup.
3157         * TestWebKitAPI/mac/TestProtocol.h: Copied from Source/WebKit2/WebProcess/WebProcessSupplement.h.
3158         * TestWebKitAPI/mac/TestProtocol.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm.
3159         (+[TestProtocol canInitWithRequest:]):
3160         (+[TestProtocol canonicalRequestForRequest:]):
3161         (+[TestProtocol requestIsCacheEquivalent:toRequest:]):
3162         (+[TestProtocol scheme]):
3163         (-[TestProtocol startLoading]):
3164         (-[TestProtocol stopLoading]):
3165
3166 2013-04-26  Martin Robinson  <mrobinson@igalia.com>
3167
3168         Remove the remaining Skia #ifdefs
3169         https://bugs.webkit.org/show_bug.cgi?id=114886
3170
3171         Reviewed by Benjamin Poulain.
3172
3173         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
3174         (createBitmapContextFromWebView): Remove Skia #ifdef references.
3175
3176 2013-04-26  Mary Wu  <mary.wu@torchmobile.com.cn>
3177
3178         [BlackBerry] Clean up load interface in WebPage
3179         https://bugs.webkit.org/show_bug.cgi?id=113267
3180
3181         Reviewed by Rob Buis.
3182
3183         Update DumpRenderTree with change of load() interface in WebPage.
3184         RIM Bug# 315535, internally reviewed by Joe Mason.
3185
3186         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3187         (BlackBerry::WebKit::DumpRenderTree::runTest):
3188
3189 2013-04-26  Zan Dobersek  <zdobersek@igalia.com>
3190
3191         Remove the HeapGraphSerializer unit test
3192         https://bugs.webkit.org/show_bug.cgi?id=115231
3193
3194         Reviewed by Andreas Kling.
3195
3196         Remove the HeapGraphSerializer unit test. The code it was testing was removed in r148921,
3197         specifically the Source/WebCore/inspector/HeapGraphSerializer.(cpp|h) files.
3198
3199         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed.
3200
3201 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
3202
3203         Remove support for Chromium from build/update scripts
3204         https://bugs.webkit.org/show_bug.cgi?id=115218
3205
3206         Reviewed by Darin Adler.
3207
3208         * Scripts/build-webkit:
3209         (writeCongrats):
3210         * Scripts/update-webkit:
3211
3212 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
3213
3214         Remove support for Chromium from api-test
3215         https://bugs.webkit.org/show_bug.cgi?id=115211
3216
3217         Reviewed by Dirk Pranke.
3218
3219         * Scripts/build-api-tests:
3220         * Scripts/run-api-tests:
3221         (isSupportedPlatform):
3222
3223 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
3224
3225         Get rid of Chromium in build-dumprendertree
3226         https://bugs.webkit.org/show_bug.cgi?id=115212
3227
3228         Reviewed by Dirk Pranke.
3229
3230         * Scripts/build-dumprendertree:
3231
3232 2013-04-25  Alexey Proskuryakov  <ap@apple.com>
3233
3234         Pass relatedPage when creating a page in WebKitTestRunner
3235         https://bugs.webkit.org/show_bug.cgi?id=115206
3236
3237         Reviewed by Geoffrey Garen.
3238
3239         To make sure that window.open() opens in the same process even when using multiple processes.
3240
3241         * WebKitTestRunner/PlatformWebView.h:
3242         * WebKitTestRunner/TestController.cpp:
3243         (WTR::TestController::createOtherPage):
3244         (WTR::TestController::createWebViewWithOptions):
3245         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3246         (WTR::PlatformWebView::PlatformWebView):
3247         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3248         (WTR::PlatformWebView::PlatformWebView):
3249         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3250         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useTiledDrawing:]):
3251         (WTR::PlatformWebView::PlatformWebView):
3252         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3253         (WTR::PlatformWebView::PlatformWebView):
3254         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3255         (WTR::PlatformWebView::PlatformWebView):
3256
3257 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
3258
3259         Fix autocompletion for Benjamin. The Bugzilla email address must come first.
3260
3261         * Scripts/webkitpy/common/config/contributors.json:
3262
3263 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
3264
3265         Build fix. Forgot to merge args.
3266
3267         * Scripts/webkitpy/tool/bot/irc_command.py:
3268         (Hi.execute):
3269
3270 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
3271
3272         webkitbot should recognize its own nickname in greetings.
3273         https://bugs.webkit.org/show_bug.cgi?id=115196
3274
3275         Reviewed by Andreas Kling.
3276
3277         Make webkitbot recognize other forms of its nick. Also be tolerant of spaces between the nick and !.
3278
3279         * Scripts/webkitpy/tool/bot/irc_command.py:
3280         (Hi.execute):
3281
3282 2013-04-25  Xavier Castano  <xcastanho@igalia.com>
3283
3284         [GTK] Tools/gtk/install-dependencies added ragel dependency
3285         https://bugs.webkit.org/show_bug.cgi?id=115163
3286
3287         Reviewed by Xan Lopez.
3288
3289         The install-dependencies script was missing a dependency on ragel
3290         which is expected when building HarfBuzz.
3291
3292         * gtk/install-dependencies: Added a dependency on ragel for both
3293         apt and yum.
3294
3295 2013-04-25  Eduardo Lima Mitev  <elima@igalia.com>
3296
3297         [GTK] Remove pango from optional jhbuild dependencies
3298         https://bugs.webkit.org/show_bug.cgi?id=115162
3299
3300         Reviewed by Martin Robinson.
3301
3302         Pango is not needed since revision r148293 that lowers the pango
3303         dependency to 1.30, which is available in most distributions.
3304
3305         * gtk/jhbuild-optional.modules: Removes description of pango module.
3306
3307 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
3308
3309         Remove Chromium-specific cases from FeatureList.pm
3310         https://bugs.webkit.org/show_bug.cgi?id=115169
3311
3312         Reviewed by Andreas Kling.
3313
3314         * Scripts/webkitperl/FeatureList.pm:
3315
3316 2013-04-24  Seokju Kwon  <seokju.kwon@gmail.com>
3317
3318         Remove checking chromium from run-webkit-tests
3319         https://bugs.webkit.org/show_bug.cgi?id=115139
3320
3321         Reviewed by Benjamin Poulain.
3322
3323         * Scripts/run-webkit-tests:
3324         (useNewRunWebKitTests):
3325
3326 2013-04-24  Simon Fraser  <simon.fraser@apple.com>
3327
3328         Pixel tests in SVG are all broken in WK2
3329         https://bugs.webkit.org/show_bug.cgi?id=114218
3330
3331         Reviewed by Darin Adler.
3332
3333         Window snapshots in WebKitTestRunner on Mac are window-sized
3334         (800x600), which is wrong for the W3C SVG tests that require a
3335         480x360 snapshot.
3336
3337         Fix by resizing the window, as well as the web view in
3338         PlatformWebView::resizeTo() so that window snapshots are correctly
3339         sized.
3340
3341         Also do some drive-by cleanup of the window size constants in both
3342         DRT and WTR to remove magic numbers, and make the code more similar.
3343
3344         * DumpRenderTree/TestRunner.cpp:
3345         (TestRunner::setShouldPaintBrokenImage):
3346         * DumpRenderTree/TestRunner.h:
3347         * DumpRenderTree/efl/DumpRenderTree.cpp:
3348         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3349         (webInspectorShowWindow):
3350         * DumpRenderTree/mac/DumpRenderTree.mm:
3351         (createWebViewAndOffscreenWindow):
3352         (sizeWebViewForCurrentTest):
3353         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3354         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3355         (createPagedBitmapContext):
3356         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3357         (DumpRenderTree::DumpRenderTree):
3358         (DumpRenderTree::open):
3359         * DumpRenderTree/qt/TestRunnerQt.cpp:
3360         * DumpRenderTree/qt/TestRunnerQt.h:
3361         * DumpRenderTree/win/DumpRenderTree.cpp:
3362         (sizeWebViewForCurrentTest):
3363         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
3364         * WebKitTestRunner/TestController.cpp:
3365         (WTR::TestController::resetStateToConsistentValues):
3366         * WebKitTestRunner/TestController.h:
3367         * WebKitTestRunner/TestInvocation.cpp:
3368         (WTR::sizeWebViewForCurrentTest):
3369         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3370         (WTR::PlatformWebView::PlatformWebView):
3371         (WTR::PlatformWebView::resizeTo):
3372
3373 2013-04-24  Byungwoo Lee  <bw80.lee@samsung.com>
3374
3375         [EFL] Fix build error after r148963.
3376         https://bugs.webkit.org/show_bug.cgi?id=115126
3377
3378         Reviewed by Laszlo Gombos.
3379
3380         Generate forwarding headers for 'CoordinatedGraphics' to generate WKView.h
3381
3382         * TestWebKitAPI/PlatformEfl.cmake:
3383
3384 2013-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3385
3386         [GTK] Use stamp files for generate-forwarding-headers makefile rules
3387         https://bugs.webkit.org/show_bug.cgi?id=115118
3388
3389         Reviewed by Martin Robinson.
3390
3391         Use a stamp file for the TestWebKitAPI and WebKitTestRunner
3392         forwarding generator rules and don't call it for soup since there
3393         aren't soup directories in TestWebKitAPI and WebKitTestRunner.
3394
3395         * TestWebKitAPI/GNUmakefile.am:
3396         * WebKitTestRunner/GNUmakefile.am:
3397
3398 2013-04-24  Simon Pena  <simon.pena@samsung.com>
3399
3400         [GTK] Update build dependencies
3401         https://bugs.webkit.org/show_bug.cgi?id=115111
3402
3403         Reviewed by Martin Robinson.
3404
3405         The install-dependencies script was missing a dependency on EGL,
3406         which is expected when building Cairo.
3407
3408         * gtk/install-dependencies: Added a dependency on libegl1-mesa
3409         for both apt and yum.
3410
3411 2013-04-24  Seokju Kwon  <seokju.kwon@gmail.com>
3412
3413         Remove the Chromium-specific helper from run_webkit_tests.py
3414         https://bugs.webkit.org/show_bug.cgi?id=114996
3415
3416         Reviewed by Dirk Pranke.
3417
3418         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3419         (parse_args):
3420
3421 2013-04-24  Sergio Correia  <sergio.correia@openbossa.org>
3422
3423         [EFL][WK2]: Fix WKViewClientWebProcessCallbacks WK2 API test
3424         https://bugs.webkit.org/show_bug.cgi?id=114850
3425
3426         Reviewed by Andreas Kling.
3427
3428         Revision r148312 fixed WebPageProxy cleanup and also changed the process
3429         termination semantics when requested by the user so that a client is not
3430         notified of a crash anymore, since there was no crash anyway.
3431
3432         That change broke WKViewClientWebProcessCallbacks WK2 API test, since it
3433         relied on being notified of a crash after calling WKPageTerminate(). As
3434         a result of not being notified of such non-existent crash, the test would
3435         timeout right after making the terminate call.
3436
3437         This patch adds an InjectedBundle to be used for simulating a crash, by
3438         calling abort() upon receiving a "Crash" message, and thus we are able to
3439         keep testing the crash callback.
3440
3441         This patch also re-enables the WKViewClientWebProcessCallbacks test, which
3442         had been disabled in revisions r148858 and r148855, since it was failing.
3443
3444         * TestWebKitAPI/PlatformEfl.cmake:
3445         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
3446         (TestWebKitAPI::TEST):
3447         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Added.
3448         (TestWebKitAPI):
3449         (WKViewClientWebProcessCallbacksTest):
3450         (TestWebKitAPI::WKViewClientWebProcessCallbacksTest::WKViewClientWebProcessCallbacksTest):
3451         (TestWebKitAPI::WKViewClientWebProcessCallbacksTest::didReceiveMessage):
3452
3453 2013-04-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3454
3455         [EFL][WK2] WebKitTestRunner failures due to IconDatabase assertions
3456         https://bugs.webkit.org/show_bug.cgi?id=115095
3457
3458         Reviewed by Antonio Gomes.
3459
3460         Use different subfolders under DumpRenderTree Temp folder for every
3461         functionality (icon database, cache, localstorage, ...). This makes
3462         sure there is no conflict between the functionalities.
3463
3464         In EFL's case, libsoup cache was causing problems for the icon
3465         database if sharing the same folder.
3466
3467         * WebKitTestRunner/TestController.cpp:
3468         (WTR::TestController::initialize):
3469
3470 == Rolled over to ChangeLog-2013-04-24 ==