Add a version of WebKitSystemInterface for Mavericks.
[WebKit-https.git] / Tools / ChangeLog
1 2013-10-21  Mark Rowe  <mrowe@apple.com>
2
3         Add a version of WebKitSystemInterface for Mavericks.
4
5         Reviewed by Ryosuke Niwa.
6
7         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
8         * Scripts/copy-webkitlibraries-to-product-directory:
9         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
10
11 2013-10-21  Anders Carlsson  <andersca@apple.com>
12
13         Navigation policy callback not called when performing the same fragment navigation twice
14         https://bugs.webkit.org/show_bug.cgi?id=123121
15         <rdar://problem/15230466>
16
17         Reviewed by Beth Dakin.
18
19         Add a test.
20
21         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
22         * TestWebKitAPI/Tests/mac/FragmentNavigation.html: Added.
23         * TestWebKitAPI/Tests/mac/FragmentNavigation.mm: Added.
24         (+[WebKit1FragmentNavigationTestDelegate shared]):
25         (-[WebKit1FragmentNavigationTestDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
26         (-[WebKit1FragmentNavigationTestDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
27         (-[WebKit1FragmentNavigationTestDelegate webView:didFinishLoadForFrame:]):
28         (-[WebKit1FragmentNavigationTestDelegate _runNextTestWithWebView:]):
29         (TestWebKitAPI::TEST):
30
31 2013-10-21  Dan Bernstein  <mitz@apple.com>
32
33         Style checker should allow a space after the @property keyword
34         https://bugs.webkit.org/show_bug.cgi?id=123117
35
36         Reviewed by Anders Carlsson.
37
38         * Scripts/webkitpy/style/checkers/cpp.py:
39         (check_spacing_for_function_call): Allow a space between @property and the following (
40         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
41         (CppStyleTest.test_spacing_for_fncall): Added a test case.
42
43 2013-10-21  peavo@outlook.com  <peavo@outlook.com>
44
45         [WinCairo] Build does not start.
46         https://bugs.webkit.org/show_bug.cgi?id=123059
47
48         Reviewed by Csaba Osztrogonác.
49
50         The function isAppleWinWebKit() does no longer return true for WinCairo, need to add isWinCairo() checks instead.
51
52         * Scripts/build-webkit:
53
54 2013-10-21  Zan Dobersek  <zdobersek@igalia.com>
55
56         [Jhbuild] Bump the required Jhbuild revision
57         https://bugs.webkit.org/show_bug.cgi?id=123089
58
59         Reviewed by Carlos Garcia Campos.
60
61         * jhbuild/jhbuild-wrapper: Latest versions of the gnome-common tools produce failures when configuring Jhbuild
62         due to the configure.ac script using both IT_PROG_INTLTOOL and AM_GNU_GETTEXT macros. This is already fixed
63         in the Jhbuild source so a more recent revision of it should be used.
64
65 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
66
67         Mac build fix.
68
69         * DumpRenderTree/mac/DumpRenderTree.mm: Cast the length for %lu specifier.
70
71 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
72
73         Enable webaudio/ tests on DRT/Mac
74         https://bugs.webkit.org/show_bug.cgi?id=86914
75
76         Reviewed by Darin Adler.
77
78         * DumpRenderTree/ForwardingHeaders/runtime/ArrayBufferView.h: Copied from Source/WebCore/ForwardingHeaders/runtime/ArrayBufferView.h.
79         * DumpRenderTree/ForwardingHeaders/runtime/JSArrayBufferView.h: Copied from Source/WebCore/ForwardingHeaders/runtime/JSArrayBufferView.h.
80         * DumpRenderTree/ForwardingHeaders/runtime/TypedArrayInlines.h: Copied from Source/WebCore/ForwardingHeaders/runtime/TypedArrayInlines.h.
81         There is no way to efficiently get TypedArray buffer using API, so we need some internal headers.
82
83         * DumpRenderTree/TestRunner.cpp:
84         (setAudioResultCallback): 
85         (TestRunner::staticFunctions):
86         * DumpRenderTree/TestRunner.h:
87         (TestRunner::audioResult):
88         (TestRunner::setAudioResult):
89         The function has a different name and argument type now, updated accordingly.
90         Changed buffer from std::string to std::vector<char>, because it's more idiomatic.
91
92         * DumpRenderTree/mac/DumpRenderTree.mm:
93         (dumpAudio): Updated for the new name of audioResult accessor.
94         (dump): Print the result in the format webkitpy currently expects.
95
96         * WebKitTestRunner/TestInvocation.cpp:
97         (WTR::TestInvocation::dumpAudio): fwrite the whole block at once, splitting into
98         chunks made no sense.
99
100         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
101         (WTR::TestRunner::setAudioResult): Added a FIXME about getting off WKBundle SPI.
102
103         * DumpRenderTree/CMakeLists.txt: Added JavaScriptCore/parser to include search list,
104         so that "SourceProvider.h" can be found.
105
106 2013-10-19  Ryosuke Niwa  <rniwa@webkit.org>
107
108         run-webkit-tests should submit time and modifiers to the new flakiness dashboard
109         https://bugs.webkit.org/show_bug.cgi?id=123070
110
111         Reviewed by Alexey Proskuryakov.
112
113         * Scripts/webkitpy/layout_tests/controllers/manager.py:
114         (Manager.run):
115         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
116         (summarize_results): Added include_time_and_modifiers. Report test_run_time and modifiers
117         in the test expectations when this argument is set to true.
118
119 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
120
121         Mac DumpRenderTree builds without NDEBUG even in release mode
122         https://bugs.webkit.org/show_bug.cgi?id=123066
123
124         Reviewed by Dan Bernstein.
125
126         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
127         * DumpRenderTree/mac/Configurations/Base.xcconfig:
128         Use the same pattern as WebCore and WebKitTestRunner.
129
130 2013-10-19  Zan Dobersek  <zdobersek@igalia.com>
131
132         REGRESSION(r155373): Mac WK2 EWS bots is actually Mac WK1 debug
133         https://bugs.webkit.org/show_bug.cgi?id=123064
134
135         Reviewed by Ryosuke Niwa.
136
137         Revert r155373 as it is causing incorrect port/platform deduction for the Mac EWS systems.
138
139         * Scripts/webkitpy/common/config/ports.py: Added.
140         (DeprecatedPort):
141         (DeprecatedPort.name):
142         (DeprecatedPort.flag):
143         (DeprecatedPort.script_path):
144         (DeprecatedPort.script_shell_command):
145         (DeprecatedPort.port):
146         (DeprecatedPort.makeArgs):
147         (DeprecatedPort.update_webkit_command):
148         (DeprecatedPort.check_webkit_style_command):
149         (DeprecatedPort.prepare_changelog_command):
150         (DeprecatedPort.build_webkit_command):
151         (DeprecatedPort.run_javascriptcore_tests_command):
152         (DeprecatedPort.run_webkit_unit_tests_command):
153         (DeprecatedPort.run_webkit_tests_command):
154         (DeprecatedPort.run_python_unittests_command):
155         (DeprecatedPort.run_perl_unittests_command):
156         (DeprecatedPort.run_bindings_tests_command):
157         (MacPort):
158         (MacWK2Port):
159         (MacWK2Port.run_webkit_tests_command):
160         (WinPort):
161         (WinPort.run_bindings_tests_command):
162         (GtkPort):
163         (GtkPort.build_webkit_command):
164         (GtkPort.run_webkit_tests_command):
165         (GtkWK2Port):
166         (GtkWK2Port.build_webkit_command):
167         (GtkWK2Port.run_webkit_tests_command):
168         (QtPort):
169         (QtPort.build_webkit_command):
170         (QtPort.run_webkit_tests_command):
171         (QtWK2Port):
172         (QtWK2Port.build_webkit_command):
173         (QtWK2Port.run_webkit_tests_command):
174         (EflPort):
175         (EflPort.build_webkit_command):
176         (EflWK2Port):
177         (EflWK2Port.build_webkit_command):
178         * Scripts/webkitpy/common/config/ports_mock.py: Added.
179         (MockPort):
180         (MockPort.name):
181         (MockPort.check_webkit_style_command):
182         (MockPort.update_webkit_command):
183         (MockPort.build_webkit_command):
184         (MockPort.prepare_changelog_command):
185         (MockPort.run_python_unittests_command):
186         (MockPort.run_perl_unittests_command):
187         (MockPort.run_javascriptcore_tests_command):
188         (MockPort.run_webkit_unit_tests_command):
189         (MockPort.run_webkit_tests_command):
190         (MockPort.run_bindings_tests_command):
191         * Scripts/webkitpy/common/config/ports_unittest.py: Added.
192         (DeprecatedPortTest):
193         (DeprecatedPortTest.test_mac_port):
194         (DeprecatedPortTest.test_gtk_port):
195         (DeprecatedPortTest.test_gtk_wk2_port):
196         (DeprecatedPortTest.test_efl_port):
197         (DeprecatedPortTest.test_qt_port):
198         (DeprecatedPortTest.test_qt_wk2_port):
199         * Scripts/webkitpy/port/base.py:
200         (Port._port_flag_for_scripts):
201         (Port._wk2_port_name):
202         * Scripts/webkitpy/port/base_unittest.py:
203         (PortTest.test_build_path):
204         * Scripts/webkitpy/port/efl_unittest.py:
205         (EflPortTest.test_show_results_html_file):
206         * Scripts/webkitpy/port/gtk_unittest.py:
207         (GtkPortTest.test_get_crash_log):
208         * Scripts/webkitpy/port/mac_unittest.py:
209         (test_64bit):
210         * Scripts/webkitpy/port/test.py:
211         (TestPort.virtual_test_suites):
212         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
213         (FlakyTestReporter.__init__):
214         * Scripts/webkitpy/tool/bot/irc_command.py:
215         (Rollout._update_working_copy):
216         * Scripts/webkitpy/tool/commands/download_unittest.py:
217         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
218         (AbstractEarlyWarningSystem.run_command):
219         * Scripts/webkitpy/tool/commands/queues.py:
220         (PatchProcessingQueue.begin_work_queue):
221         (CommitQueue.run_command):
222         * Scripts/webkitpy/tool/main.py:
223         (WebKitPatch.__init__):
224         (WebKitPatch.deprecated_port):
225         (WebKitPatch.handle_global_options):
226         * Scripts/webkitpy/tool/mocktool.py:
227         (MockTool.__init__):
228         (MockTool.deprecated_port):
229         * Scripts/webkitpy/tool/steps/build.py:
230         (Build.build):
231         * Scripts/webkitpy/tool/steps/checkstyle.py:
232         (CheckStyle.run):
233         * Scripts/webkitpy/tool/steps/commit.py:
234         (Commit._check_test_expectations):
235         * Scripts/webkitpy/tool/steps/preparechangelog.py:
236         (PrepareChangeLog.run):
237         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
238         (PrepareChangeLogForRevert.run):
239         * Scripts/webkitpy/tool/steps/runtests.py:
240         (RunTests.run):
241         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
242         (RunTestsTest.test_webkit_run_unit_tests):
243         * Scripts/webkitpy/tool/steps/steps_unittest.py:
244         (StepsTest.test_runtests_args):
245         * Scripts/webkitpy/tool/steps/update.py:
246         (Update._update_command):
247         * Scripts/webkitpy/tool/steps/update_unittest.py:
248         (UpdateTest.test_update_command_non_interactive):
249         (UpdateTest.test_update_command_interactive):
250
251 2013-10-19  Andreas Kling  <akling@apple.com>
252
253         RefPtr::releaseNonNull() incorrectly increments the refcount.
254         <https://webkit.org/b/123063>
255
256         Add an API test to verify that no extra refs are added when calling
257         RefPtr::releaseNonNull().
258
259         Reviewed by Anders Carlsson.
260
261 2013-10-18  Rik Cabanier <cabanier@adobe.com>
262         Add Rik Cabanier to list of committers
263         https://bugs.webkit.org/show_bug.cgi?id=123031
264
265         reviewed by Dirk Schulze.
266
267         * Tools/Scripts/webkitpy/common/config/contributors.json: Added name.
268
269 2013-10-18  Denis Nomiyama  <d.nomiyama@samsung.com>
270
271         [ATK] Fix invalid signal to set objects to an unknown state "layout-complete"
272         https://bugs.webkit.org/show_bug.cgi?id=122970
273
274         Reviewed by Mario Sanchez Prada.
275
276         Removed an invalid signal to set an object state to layout-complete
277         that does not exist. It was replaced by ATK:AtkDocument:load-complete.
278
279         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
280         (axObjectEventListener): Replaced layout-complete with load-complete.
281         (connectAccessibilityCallbacks): Connect callback to new listener for
282         ATK:AtkDocument:load-complete.
283         (disconnectAccessibilityCallbacks): Disconnect callback to new listener
284         for ATK:AtkDocument:load-complete.
285         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
286         (axObjectEventListener): Replaced layout-complete with load-complete.
287         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
288         Connect callback to new listener for ATK:AtkDocument:load-complete.
289         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
290         Disconnect callback to new listener for ATK:AtkDocument:load-complete.
291
292 2013-10-18  Carlos Garcia Campos  <cgarcia@igalia.com>
293
294         [GTK] Generate API documentation for GObject DOM bindings
295         https://bugs.webkit.org/show_bug.cgi?id=121538
296
297         Reviewed by Gustavo Noronha Silva.
298
299         The .symbols file that is now generated for checking GObject DOM
300         bindings API compatibility while building can also be used to
301         generate the files needed to produce the gtk-doc
302         documentation. The new script generate-webkitdom-doc-files can
303         generate the docs.sgml and sections.txt files from the given list
304         of .symbols files.
305
306         * gtk/GNUmakefile.am: Add rules to generate webkitdomgtk-docs.sgml
307         and webkitdomgtk-sections.txt as well as rules to install the
308         generated WebKitDOMGTK documentation.
309         * gtk/generate-gtkdoc:
310         (webkitdom_docs_html_path): New helper function that returns the
311         path where the DOM API documentation has been generated.
312         (get_webkit2_options): Include DOM API docs to the list of xref
313         dependencies.
314         (get_webkit1_options): Ditto.
315         (get_webkitdom_options): Return the gtk-doc options to generate
316         the DOM API docs.
317         (get_webkitdom_options.derived_sources_path):
318         (get_webkitdom_options.src_path):
319         * gtk/generate-webkitdom-doc-files: Added.
320         (WebKitDOMDocGenerator):
321         (WebKitDOMDocGenerator.write_header):
322         (WebKitDOMDocGenerator.write_section):
323         (WebKitDOMDocGenerator.write_footer):
324         (WebKitDOMDocGeneratorDocs):
325         (WebKitDOMDocGeneratorDocs.write_header):
326         (write_section):
327         (write_footer):
328         (WebKitDOMDocGeneratorSections):
329         (WebKitDOMDocGeneratorSections.__init__):
330         (WebKitDOMDocGeneratorSections._dom_class):
331         (WebKitDOMDocGeneratorSections._dom_class_decamelize):
332         (WebKitDOMDocGeneratorSections._symbol_list):
333         (WebKitDOMDocGeneratorSections.write_section):
334
335 2013-10-17  Alex Christensen  <achristensen@webkit.org>
336
337         Run JavaScriptCore tests again on Windows.
338         https://bugs.webkit.org/show_bug.cgi?id=122787
339
340         Reviewed by Tim Horton.
341
342         * Scripts/build-jsc:
343         (buildMyProject): Use JavaScriptCore.sln to build JavaScriptCore and WTF.
344         * Scripts/run-javascriptcore-tests: Don't run stress tests on WinCairo.
345         * Scripts/webkitdirs.pm:
346         (determineConfigurationForVisualStudio):
347         (determineConfigurationProductDir):
348         Build directory should end with bin64 and configuration should end with |x64 on Win64.
349         (isAppleWinWebKit):
350         (copyInspectorFrontendFiles):
351         (setPathForRunningWebKitApp):
352         Separated WinCairo directories and options from AppleWin.
353
354 2013-10-17  Mihnea Ovidenie  <mihnea@adobe.com>
355
356         Unreviewed. Add myself as a reviewer.
357
358         * Scripts/webkitpy/common/config/contributors.json:
359
360 2013-10-17  Andreas Kling  <akling@apple.com>
361
362         Make it possible to assign a PassRef to a RefPtr.
363         <https://webkit.org/b/122943>
364
365         Added a small API test for RefPtr=(PassRef) so we know this code
366         will compile (and work.)
367
368         Reviewed by Antti Koivisto.
369
370 2013-10-16  Filip Pizlo  <fpizlo@apple.com>
371
372         We need test coverage for just the Baseline JIT
373         https://bugs.webkit.org/show_bug.cgi?id=122929
374
375         Reviewed by Sam Weinig.
376         
377         Adds no-LLInt versions of all tests. For the Mozilla tests, also add a BaselineJIT-only
378         variant.
379
380         * Scripts/run-jsc-stress-tests:
381
382 2013-10-16  Ryosuke Niwa  <rniwa@webkit.org>
383
384         Support multiple repositories in submitting results to --results-server-host
385         https://bugs.webkit.org/show_bug.cgi?id=122935
386
387         Reviewed by Anders Carlsson.
388
389         Remoevd --got-revision and added the logic to extract revision information
390         from multiple repositories as done in run-perf-tests.
391
392         * Scripts/webkitpy/layout_tests/controllers/manager.py:
393         (Manager.upload_results):
394         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
395         (parse_args):
396
397 2013-10-16  Darin Adler  <darin@apple.com>
398
399         Add PassRef and createRefCounted so we can improve creation of RefCounted objects
400         https://bugs.webkit.org/show_bug.cgi?id=122904
401
402         Reviewed by Anders Carlsson.
403
404         * TestWebKitAPI/Tests/WTF/Ref.cpp: Added some basic tests for adoptRef and PassRef.
405
406 2013-10-16  Darin Adler  <darin@apple.com>
407
408         Need tests for RefPtr self-assignment and self-move-assignment.
409
410         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Added tests.
411
412 2013-10-16  Robert Plociennik  <r.plociennik@samsung.com>
413
414         [EFL] Minibrowser can't load child window's location
415         https://bugs.webkit.org/show_bug.cgi?id=122485
416
417         Reviewed by Gyuyoung Kim.
418
419         * MiniBrowser/efl/main.c: Now calling window_create() without the url parameter
420             followed by an explicit call to ewk_view_url_set() where appropriate.
421         (on_key_down):
422         (on_window_create):
423         (window_create):
424         (elm_main):
425
426 2013-10-15  Sergio Correia  <sergio.correia@openbossa.org>
427
428         [EFL][WK2] Make SeccompFilters build again after r156349 and r156353
429         https://bugs.webkit.org/show_bug.cgi?id=122872
430
431         Reviewed by Anders Carlsson.
432
433         * TestWebKitAPI/PlatformEfl.cmake: Mark SeccompFilters API test as
434         failing.
435
436 2013-10-15  Dean Jackson  <dino@apple.com>
437
438         Add ENABLE_WEB_ANIMATIONS flag
439         https://bugs.webkit.org/show_bug.cgi?id=122871
440
441         Reviewed by Tim Horton.
442
443         Eventually might be http://dev.w3.org/fxtf/web-animations/
444         but this is just engine-internal work at the moment.
445
446         * Scripts/webkitperl/FeatureList.pm:
447
448 2013-10-15  Darin Adler  <darin@apple.com>
449
450         Add some API tests for Vector, RefPtr, and Ref
451         https://bugs.webkit.org/show_bug.cgi?id=122840
452
453         Reviewed by Andreas Kling.
454
455         * TestWebKitAPI/CMakeLists.txt: Added new files.
456         * TestWebKitAPI/GNUmakefile.am: Ditto.
457         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
458         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
459         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
460
461         * TestWebKitAPI/Tests/WTF/Ref.cpp: Added.
462         * TestWebKitAPI/Tests/WTF/RefLogger.h: Added.
463         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Added.
464         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added move-only insert tests.
465
466 2013-10-14  Roger Fong  <roger_fong@apple.com>
467
468         Adding myself to CC list for some components.
469
470         * Scripts/webkitpy/common/config/watchlist:
471
472 2013-10-13  Darin Adler  <darin@apple.com>
473
474         Deprecate or remove deleteAllValues functions; there are only a few call sites left
475         https://bugs.webkit.org/show_bug.cgi?id=122738
476
477         Reviewed by Anders Carlsson.
478
479         * DumpRenderTree/win/DRTDataObject.cpp:
480         (DRTDataObject::~DRTDataObject):
481         * DumpRenderTree/win/UIDelegate.cpp:
482         (DRTUndoStack::~DRTUndoStack):
483         (DRTUndoStack::clear):
484         Renamed deleteAllValues to deprecatedDeleteAllValues.
485
486         * Scripts/do-webcore-rename: Updated to perform this rename, as is traditional.
487
488 2013-10-13  Alexey Proskuryakov  <ap@apple.com>
489
490         build.webkit.org/dashboard incorrectly shows interrupted builds as green
491         https://bugs.webkit.org/show_bug.cgi?id=122732
492
493         Reviewed by Tim Hatcher.
494
495         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
496         (BuildbotIteration.prototype.update): Removed a special case for status 4 (EXCEPTION).
497         I don't see it occur any time in recent history, but judging from what happens for
498         status 5 (RETRY), we can just finish this function normally.
499         Record overall text description for iteration as BuildbotIteration.text.
500
501         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
502         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): If an iteration is a failure,
503         but no tests failed, make it yellow, and use buildbot-provided description for it.
504
505 2013-10-13  Alexey Proskuryakov  <ap@apple.com>
506
507         Remove Chromium specific code from flakiness dashboard
508         https://bugs.webkit.org/show_bug.cgi?id=122714
509
510         Reviewed by Sam Weinig.
511
512         Also removed code related to GPU tests and virtual suites.
513         "Fallbacks map" was chromium only too, not sure why they needed special handling there.
514
515         * TestResultServer/model/jsonresults_unittest.py:
516         * TestResultServer/static-dashboards/builders.js:
517         * TestResultServer/static-dashboards/dashboard_base.js:
518         * TestResultServer/static-dashboards/flakiness_dashboard.html:
519         * TestResultServer/static-dashboards/flakiness_dashboard.js:
520         * TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
521         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
522         * TestResultServer/static-dashboards/history.js:
523         * TestResultServer/static-dashboards/loader.js:
524         * TestResultServer/static-dashboards/ui.js:
525         * TestResultServer/templates/uploadform.html:
526
527 2013-10-11  Timothy Hatcher  <timothy@apple.com>
528
529         Remove preference support for picking the old Web Inspector.
530         https://bugs.webkit.org/show_bug.cgi?id=122655
531
532         Reviewed by Alexey Proskuryakov.
533
534         * WebKitTestRunner/TestController.cpp:
535         (WTR::TestController::resetStateToConsistentValues):
536
537 2013-10-11  Filip Pizlo  <fpizlo@apple.com>
538
539         Fix 64-bit build on everything but Windows.
540
541         Rubber stamped by Brent Fulgham.
542
543         * Scripts/webkitdirs.pm:
544         (argumentsForConfiguration):
545
546 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
547
548         Touch a file to see how auto-update works.
549
550         Rubber-stamped by Tim Hatcher.
551
552         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
553
554 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
555
556         LeaksViewer fails to present recent results list if current build is still updating svn
557         https://bugs.webkit.org/show_bug.cgi?id=122670
558
559         Fixed an obvious mistake in the previous patch.
560
561         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
562         (RecentBuildsLoader.prototype.start):
563
564 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
565
566         LeaksViewer fails to present recent results list if current build is still updating svn
567         https://bugs.webkit.org/show_bug.cgi?id=122670
568
569         Reviewed by Adam Roben.
570
571         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
572         (RecentBuildsLoader.prototype.start): Skip builds that don't have an svn revision yet.
573
574 2013-10-11  Brent Fulgham  <bfulgham@apple.com>
575
576         Unreviewed build fix for --64-bit target.
577
578         * Scripts/webkitdirs.pm:
579         (argumentsForConfiguration): Use 'isWin64' test, since @ARGV value may have
580         been removed by this point.
581         (hasArgument): Remove unused temporary.
582
583 2013-10-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
584
585         webkit-patch failure-reason has a quite low limit for 'too many failures'
586         https://bugs.webkit.org/show_bug.cgi?id=122556
587
588         Reviewed by Darin Adler.
589
590         * Scripts/webkitpy/tool/commands/queries.py:
591         (FailureReason._explain_failures_for_builder): adjust the number of too many failures
592         to match what the layout test runners use these days.
593
594 2013-10-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
595
596         webkit-patch failure-reason should allow specifying failures one is interested in
597         https://bugs.webkit.org/show_bug.cgi?id=122554
598
599         Reviewed by Darin Adler.
600
601         * Scripts/webkitpy/tool/commands/queries.py:
602         (FailureReason):
603         (FailureReason._explain_failures_for_builder): keep track of explained failures and drop out of the
604         loop if the ones we're interested in been explained.
605         (FailureReason._done_explaining): check the failures we're interested in have been explained, if any.
606         (FailureReason.execute): initialize failures to explain and the explained set.
607
608 2013-10-10  Filip Pizlo  <fpizlo@apple.com>
609
610         Make sure that DataTypes.h is in the binary drop.
611
612         Rubber stamped by Michael Saboff.
613
614         * Scripts/export-llvm-build:
615
616 2013-10-10  Filip Pizlo  <fpizlo@apple.com>
617
618         FTL: Soft-link LLVM as a workaround for LLVM's static initializers and exit-time destructors
619         https://bugs.webkit.org/show_bug.cgi?id=122566
620
621         Reviewed by Mark Rowe.
622
623         * Scripts/configure-llvm:
624
625 2013-10-10  Mark Rowe  <mrowe@apple.com>
626
627         <rdar://problem/13341666> WebKit should always build against an SDK.
628
629         Have all projects default to building against the OS X Internal SDK for the Production
630         configuration. For the Debug and Release configurations, look for UseInternalSDK.xcconfig
631         to determine whether the OS X Internal SDK should be used. If not, use the normal OS X SDK.
632
633         Reviewed by Dan Bernstein.
634
635         * DumpRenderTree/mac/Configurations/Base.xcconfig:
636         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
637         * MiniBrowser/Configurations/Base.xcconfig:
638         * MiniBrowser/Configurations/DebugRelease.xcconfig:
639         * TestWebKitAPI/Configurations/Base.xcconfig:
640         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
641         * WebKitTestRunner/Configurations/Base.xcconfig:
642         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
643
644 2013-10-10  Gustavo Noronha Silva  <gns@gnome.org>
645
646         Unreviewed gardening, the inspector protocol timeouts are also affecting TestInspectorServer.
647
648         * Scripts/run-gtk-tests:
649         (TestRunner): skip TestInspectorServer.
650
651 2013-10-10  Andres Gomez  <agomez@igalia.com>
652
653         [GTK] Provide search functionality to MiniBrowser
654         https://bugs.webkit.org/show_bug.cgi?id=117631
655
656         Reviewed by Carlos Garcia Campos.
657
658         Adds a search bar to MiniBrowser with the minimum functionality
659         and a new button to the toolbar for showing the new search
660         bar. Typical keyboard shortcuts are also added.
661
662         * MiniBrowser/gtk/BrowserSearchBar.c: Added.
663         (doSearch):
664         (searchNext):
665         (searchPrevious):
666         (searchCloseButtonClickedCallback):
667         (searchEntryMenuIconPressedCallback):
668         (searchEntryClearIconReleasedCallback):
669         (searchEntryChangedCallback):
670         (searchEntryActivatedCallback):
671         (searchPrevButtonClickedCallback):
672         (searchNextButtonClickedCallback):
673         (searchMenuCheckButtonToggledCallback):
674         (browser_search_bar_init):
675         (browserSearchBarFinalize):
676         (browser_search_bar_class_init):
677         (browser_search_bar_new):
678         (browser_search_bar_add_accelerators):
679         (browser_search_bar_open):
680         (browser_search_bar_close):
681         * MiniBrowser/gtk/BrowserSearchBar.h: Added.
682         * MiniBrowser/gtk/BrowserWindow.c:
683         (webViewEnterFullScreen): Closes new search bar.
684         (webViewLeaveFullScreen): Opens new search bar if previously
685         visible.
686         (searchCallback): Added. Shows and hides the new search bar.
687         (browser_window_init): Added search button to the toolbar.
688         (browserWindowConstructed): Creates the new search bar.
689         * MiniBrowser/gtk/GNUmakefile.am: Added new files to compilation.
690
691 2013-10-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
692
693         webkit-patch failure-reason fails with UnicodeDecodeError when name has non-ascii characters
694         https://bugs.webkit.org/show_bug.cgi?id=122552
695
696         Reviewed by Darin Adler.
697
698         * Scripts/webkitpy/common/checkout/commitinfo.py:
699         (CommitInfo.blame_string): ensure objects are made into unicode strings, not regular ones that
700         will cause UnicodeDecodeError for non-ascii characters.
701
702 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
703
704         Would like a link to dashboard from build.webkit.org main page
705         https://bugs.webkit.org/show_bug.cgi?id=122577
706
707         Reviewed by Tim Hatcher.
708
709         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added.
710
711 2013-10-09  Brent Fulgham  <bfulgham@apple.com>
712
713         [Win] Check for MathML fonts and warn user if they are missing.
714         https://bugs.webkit.org/show_bug.cgi?id=122568
715
716         Reviewed by Tim Horton.
717
718         * Scripts/webkitdirs.pm:
719         (checkRequiredSystemConfig): Use common gperf/bison/flex tests, rather than
720         Windows-specific code I added previously.
721         (fontExists): Added
722         (checkInstalledTools): Add check for MathML fonts.
723
724 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
725
726         http://build.webkit.org/dashboard/ doesn't link to webkitpy failures
727         https://bugs.webkit.org/show_bug.cgi?id=122471
728
729         Reviewed by Tim Hatcher.
730
731         Added links to webkitpy, webkitperl and bindings-tests results.
732
733         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
734         (Buildbot.prototype.apiTestResultsURLForIteration):
735         (Buildbot.prototype.webkitpyTestResultsURLForIteration):
736         (Buildbot.prototype.webkitperlTestResultsURLForIteration):
737         (Buildbot.prototype.bindingsTestResultsURLForIteration):
738         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
739         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
740
741 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
742
743         Move some functions from WebKitBuildbot to Buildbot class.
744
745         Suggested by Tim Hatcher.
746
747         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
748         (Buildbot.prototype.javascriptTestResultsURLForIteration):
749         (Buildbot.prototype.apiTestResultsURLForIteration):
750         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
751         (WebKitBuildbot.prototype.layoutTestResultsURLForIteration):
752
753 2013-10-09  Timothy Hatcher  <timothy@apple.com>
754
755         Add API tests to the Dashbord page.
756
757         https://bugs.webkit.org/show_bug.cgi?id=122283
758
759         Reviewed by Timothy Hatcher.
760
761         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
762         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
763         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
764         (WebKitBuildbot.prototype.apiTestResultsURLForIteration):
765
766 2013-10-09  Timothy Hatcher  <timothy@apple.com>
767
768         Attempt to fix faulty Dashboard iteration updating by always rebuilding test result objects.
769
770         https://bugs.webkit.org/show_bug.cgi?id=122515
771
772         Reviewed by Alexey Proskuryakov.
773
774         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
775         (BuildbotIteration.prototype.update):
776
777 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
778
779         build.webkit.org/dashboard doesn't provide a results link when there issues at multiple steps
780         https://bugs.webkit.org/show_bug.cgi?id=122573
781
782         Reviewed by Tim Hatcher.
783
784         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
785         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Provide a URL.
786
787         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
788         (Buildbot.prototype.buildPageURLForIteration): Added.
789
790 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
791
792         http://build.webkit.org/dashboard/ links to a wrong jscore-test results page
793         https://bugs.webkit.org/show_bug.cgi?id=122569
794
795         Reviewed by Tim Hatcher.
796
797         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
798         (WebKitBuildbot.prototype.javascriptTestResultsURLForIteration): "actual.html" used
799         to be produced by the old Mozilla test harness that we don't use any more.
800
801 2013-10-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
802
803         Add GTK 64 bits release to the buildbot dashboard
804         https://bugs.webkit.org/show_bug.cgi?id=122548
805
806         Reviewed by Darin Adler.
807
808         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png: Added.
809         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
810         (WebKitBuildbot): add 64 bits release wk2 and wk1 testers.
811         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
812         (table.queue-grid tr.platform.linux-gtk img.logo): use the GTK+ logo in its dashboard line.
813
814 2013-10-09  Mario Sanchez Prada  <mario.prada@samsung.com>
815
816         [ATK] Implement new API in AtkText: atk_text_get_string_at_offset()
817         https://bugs.webkit.org/show_bug.cgi?id=120638
818
819         Reviewed by Gustavo Noronha Silva.
820
821         * gtk/jhbuild.modules: Raised ATK and AT-SPI versions to 2.10.0, so we
822         can check both the old and new APIs to retrieve text at a given offset.
823
824 2013-10-08  Alex Christensen  <achristensen@webkit.org>
825
826         Improved WinLauncher.
827         https://bugs.webkit.org/show_bug.cgi?id=122536
828
829         Reviewed by Brent Fulgham.
830
831         * WinLauncher/PrintWebUIDelegate.cpp:
832         (PrintWebUIDelegate::runJavaScriptAlertPanelWithMessage): Added.
833         (PrintWebUIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
834         * WinLauncher/PrintWebUIDelegate.h: Removed stubs.
835         * WinLauncher/WinLauncher.cpp:
836         (createCrashReport): Use the executable name instead of "WinLauncher".
837         * WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Removed.
838         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link to Wininet.lib.
839         * win/DLLLauncher/DLLLauncherMain.cpp: Remove VS2005 dependency for WinCairo.
840
841 2013-10-08  Mark Lam  <mark.lam@apple.com>
842
843         Fix ruby LoadError when running run-javascriptcore-tests.
844         https://bugs.webkit.org/show_bug.cgi?id=122519.
845
846         Reviewed by Mark Hahnenberg.
847
848         The scripts needed to explicitly require 'rubygems' for older versions of ruby
849         (versions before 1.9).
850
851         * Scripts/jsc-stress-test-helpers/profiler-test-helper:
852         * Scripts/run-jsc-stress-tests:
853
854 2013-10-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
855
856         Unreviewed, add my new email to contributors.json.
857
858         * Scripts/webkitpy/common/config/contributors.json:
859
860 2013-10-08  Brent Fulgham  <bfulgham@apple.com>
861
862         Unreviewed build correction.
863
864         * Scripts/webkitpy/port/win.py:
865         (WinPort.write_registry_value): Use string representation of error message to avoid
866         format conversion problem.
867
868 2013-10-07  Brent Fulgham  <bfulgham@apple.com>
869
870         [Win] Add checks for proper build and test environment
871         https://bugs.webkit.org/show_bug.cgi?id=122466
872
873         Reviewed by Darin Adler.
874
875         This patch makes two changes:
876         1. Update webkitdirs.pm to check for some common misconfigurations and provide helpful warnings or
877            error messages so that people know what to fix to get things working.
878         2. Modify the win.py port to handle the 32-bit and 64-bit test environments, as well as making sure
879            the various environment settings are properly configured for our test environment.
880
881         * Scripts/webkitdirs.pm:
882         (checkInstalledTools): Add checks for some common Cygwin configuration problems that have
883         caused problems in the past.
884         (setupAppleWinEnv):
885         * Scripts/webkitpy/port/win.py:
886         (WinPort):
887         (WinPort.read_registry_string): Parameterize for run architecture and registry root.
888         (WinPort.write_registry_value): Parameterize registry writing by data type (string versus
889         DWORD, etc.)
890         (WinPort.write_registry_string): Revise to call new generic registry write function.
891         (WinPort.setup_crash_log_saving): Revise for new API
892         (WinPort.restore_crash_log_saving): Ditto
893         (WinPort.prevent_error_dialogs): Add new methods to prevent Windows dialogs that block our test
894         servers from running.
895         (WinPort.allow_error_dialogs): Ditto.
896         (WinPort.setup_test_run): Call new API to turn off user input dialogs on program failure.
897         (WinPort.clean_up_test_run): Call new API to reactivatea user input dialogs after test run finished.
898
899 2013-10-08  Philippe Normand  <pnormand@igalia.com>
900
901         [GStreamer] enable v4l2 plugin
902         https://bugs.webkit.org/show_bug.cgi?id=122503
903
904         Reviewed by Martin Robinson.
905
906         * gtk/jhbuild.modules: Enable the plugin, it now builds fine since
907         we updated our GStreamer version to 1.0.8.
908
909 2013-10-08  Mario Sanchez Prada  <mario.prada@samsung.com>
910
911         [ATK] Expose state of aria-invalid as ATK_STATE_INVALID_ENTRY
912         https://bugs.webkit.org/show_bug.cgi?id=122104
913
914         Reviewed by Chris Fleizach.
915
916         Updated stringAttributeValue to double check that the exposure of
917         aria-invalid as a state is consistent with its exposure as a text
918         attribute as well, when it applies (implementations of AtkText).
919
920         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
921         (AccessibilityUIElement::stringAttributeValue): Add double check.
922         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
923         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
924
925 2013-10-07  Filip Pizlo  <fpizlo@apple.com>
926
927         run-jsc-stress-tests progress meter should update more quickly on older Rubies
928         https://bugs.webkit.org/show_bug.cgi?id=122459
929
930         Reviewed by Darin Adler.
931
932         * Scripts/run-jsc-stress-tests:
933
934 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
935
936         [buildbot] parse tests that are reported as crashed correctly for GTK+
937         https://bugs.webkit.org/show_bug.cgi?id=122476
938
939         Reviewed by Martin Robinson.
940
941         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
942         (RunGtkAPITests.commandComplete): parse the crashed tests output so that is reported
943         as a failure of the API tests.
944
945 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
946
947         Unreviewed. Skipping API test that is causing the next one to crash,
948         see https://bugs.webkit.org/show_bug.cgi?id=121970.
949
950         * Scripts/run-gtk-tests:
951         (TestRunner):
952
953 2013-10-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
954
955         [GTK] run-gtk-tests does not distinguish between failure and crashes
956         https://bugs.webkit.org/show_bug.cgi?id=122135
957
958         Reviewed by Martin Robinson.
959
960         The GTK+ API test runner does not distinguish between failures and crashes. This change
961         makes it do that, so it's easier for us to spot the more important/higher priority crash
962         case.
963
964         * Scripts/run-gtk-tests:
965         (TestRunner._run_test_command): return the exit code instead of a boolean true/false,
966         so we have more information on how the process ended.
967         (TestRunner._run_test): check the exit code to distinguish between crashes and failures.
968         (TestRunner.run_tests): report crashes.
969
970 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
971
972         [GTK] Missing packages for APT on install-dependencies
973         https://bugs.webkit.org/show_bug.cgi?id=121555
974
975         Reviewed by Martin Robinson.
976
977         * gtk/install-dependencies: add packages that are needed for
978         building WebKit itself and the jhbuild dependencies.
979
980 2013-10-07  Anders Carlsson  <andersca@apple.com>
981
982         Fix test failures.
983
984         * Scripts/webkitpy/port/base.py:
985         (Port.to.start_helper):
986         * Scripts/webkitpy/port/mock_drt.py:
987         (MockDRTPort.start_helper):
988
989 2013-10-07  Anders Carlsson  <andersca@apple.com>
990
991         Always force discrete mode when running layout tests
992         https://bugs.webkit.org/show_bug.cgi?id=122465
993
994         Reviewed by Tim Horton.
995
996         This should speed up WebGL tests and hopefully prevent race conditions that may cause window server crashes from happening.
997         
998         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
999         Link with IOKit.
1000
1001         * DumpRenderTree/mac/LayoutTestHelper.m:
1002         (installLayoutTestColorProfile):
1003         Check installColorProfile.
1004
1005         (restoreUserColorProfile):
1006         Check installColorProfile.
1007
1008         (lockDownDiscreteGraphics):
1009         New function to force discrete graphics.
1010
1011         (main):
1012         Add '--install-color-profile' option.
1013
1014         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1015         (Manager._set_up_run):
1016         Always start the helper, but pass self._options.pixel_tests to it.
1017
1018         * Scripts/webkitpy/port/mac.py:
1019         (MacPort.start_helper):
1020         Pass --install-color-profile' to the helper if pixel_tests is true.
1021
1022 2013-10-07  Timothy Hatcher  <timothy@apple.com>
1023
1024         Properly count binding test failures as failures.
1025
1026         Fix the total for multiple failures in different steps too by avoiding undefined.
1027
1028         https://bugs.webkit.org/show_bug.cgi?id=122232
1029
1030         Reviewed by Alexey Proskuryakov.
1031
1032         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1033         (BuildbotTestResults):
1034         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1035         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1036
1037 2013-10-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1038
1039         [GTK] Fails to build with jhbuild with newer system glib
1040         https://bugs.webkit.org/show_bug.cgi?id=122132
1041
1042         Reviewed by Martin Robinson.
1043
1044         Newer glib includes new symbols that some system libraries which we depend on, such as pango, have
1045         started relying on. glib is not a dependency that should change test results, and is provided in
1046         jhbuild with the intention of supporting the other bits that do, so using a newer stable release
1047         should not be an issue.
1048
1049         * gtk/jhbuild.modules:
1050
1051 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
1052
1053         run-jsc-stress-tests shouldn't print its goofy progress meter when running on the bots
1054         https://bugs.webkit.org/show_bug.cgi?id=122437
1055
1056         Reviewed by Antoine Quint.
1057
1058         * Scripts/run-jsc-stress-tests:
1059
1060 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
1061
1062         Unreviewed, fix build on old Rubies.
1063
1064         * Scripts/run-jsc-stress-tests:
1065
1066 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
1067
1068         Unified test infrastructure via the jsc shell
1069         https://bugs.webkit.org/show_bug.cgi?id=120696
1070
1071         Reviewed by Oliver Hunt.
1072         
1073         Make run-jsc-stress-tests smart enough to be able to handle different styles of test
1074         output (silent or noisy) and different styles of test failure (just bad exit code,
1075         text diff, filtering for some magical text, etc.). This allows me to get rid of the
1076         layout-test-helper. It also allows me to switch all of the old Mozilla tests to
1077         running in run-jsc-stress-tests.
1078         
1079         Also removes all of the code paths that defended against not having shellwords. Just
1080         install the shellwords gem if you want to run tests.
1081         
1082         Also removes the non-parallel test running code. No reason for it to exist anymore.
1083         
1084         This is a massive increase in test coverage. It uncovered bugs. I fixed two of them
1085         as part of this patch, and left three more as new bugzillas.
1086
1087         * Scripts/create-mozilla-js-test-list: Added.
1088         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
1089         * Scripts/jsc-stress-test-helpers/layout-test-helper: Removed.
1090         * Scripts/run-javascriptcore-tests:
1091         * Scripts/run-jsc-stress-tests:
1092
1093 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
1094
1095         run-jsc-stress-tests should be less verbose
1096         https://bugs.webkit.org/show_bug.cgi?id=122397
1097
1098         Reviewed by Sam Weinig.
1099         
1100         It now just prints something like:
1101         
1102          965/1831 ....
1103         
1104         Where the first number is the number of tests that completed, the second number is the
1105         number of tests total, and the dots are the number of tests running right now - which is
1106         useful towards the end when you're waiting for the last slow tests to finish.
1107         
1108         It will also print out the output from failing tests and it will print a line for skipped
1109         tests (to annoy you into getting them into a shape where they can be unskipped). For
1110         example, for LayoutTests, it will print just the diff, if the test fails. It's cool.
1111
1112         * Scripts/run-jsc-stress-tests:
1113
1114 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
1115
1116         Allow skipping of run-jsc-stress-tests that are configured using yaml files
1117         https://bugs.webkit.org/show_bug.cgi?id=122385
1118
1119         Reviewed by Sam Wieinig.
1120         
1121         Make tests run via YAML be able to do the parse-for-commands trick that allows
1122         us to skip tests and do other custom per-test stuff.
1123
1124         * Scripts/jsc-stress-test-helpers/layout-test-helper:
1125         * Scripts/run-jsc-stress-tests:
1126
1127 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
1128
1129         Unreviewed, fix tests on older Rubies.
1130
1131         * Scripts/run-jsc-stress-tests:
1132
1133 2013-10-05  Anders Carlsson  <andersca@apple.com>
1134
1135         Don't filter the weak symbols.
1136
1137         * Scripts/check-for-weak-vtables-and-externals:
1138
1139 2013-10-04  Filip Pizlo  <fpizlo@apple.com>
1140
1141         Have run-javascriptcore-tests run JS LayoutTests using run-jsc-stress-tests so that it runs in parallel
1142         https://bugs.webkit.org/show_bug.cgi?id=122376
1143
1144         Reviewed by Mark Hahnenberg.
1145
1146         * Scripts/jsc-stress-test-helpers/layout-test-helper: Added.
1147         * Scripts/run-javascriptcore-tests:
1148         (printThingsFound):
1149         * Scripts/run-jsc-stress-tests:
1150
1151 2013-10-04  Filip Pizlo  <fpizlo@apple.com>
1152
1153         It should be even easier to run and debug a failing JSC stress test
1154         https://bugs.webkit.org/show_bug.cgi?id=122337
1155
1156         Reviewed by Oliver Hunt.
1157         
1158         If a test fails, you can now just say:
1159
1160         sh WebKitBuild/Debug/jsc-stress-results/regress/script-tests/emscripten-cube2hash.js.ftl-eager-no-cjit
1161
1162         and get the reproduction. You don't have to set any environment variables like before.
1163         Also if you want to debug the failing test you can now just say:
1164
1165         sh WebKitBuild/Debug/jsc-stress-results/regress/script-tests/emscripten-cube2hash.js.ftl-eager-no-cjit lldb --
1166
1167         Broadly, any arguments passed to the reproduction script are prepended to the command to
1168         run the test. This is sort of quirky and won't work for some tests (for example the
1169         profiler tests run a ruby script that runs some other stuff) but it'll work for most of
1170         them and that's good enough for now.
1171
1172         * Scripts/run-jsc-stress-tests:
1173
1174 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
1175
1176         [Windows] Correct run-path when using 64-bit binaries.
1177
1178         Reviewed by David Kilzer.
1179
1180         * Scripts/webkitdirs.pm:
1181         (determineConfigurationProductDir): If running in 64-bit mode, use the 'bin64'
1182         directory. Otherwise use the existing 'bin32' directory.
1183
1184 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
1185
1186         Teach webkitdirs.pm to honor the --64-bit flag
1187         https://bugs.webkit.org/show_bug.cgi?id=122357
1188
1189         Reviewed by David Kilzer.
1190
1191         * Scripts/webkitdirs.pm:
1192         (argumentsForConfiguration): Modify to check if --64-bit is supplied
1193         by the user.
1194         (findMatchingArguments): Added.
1195         (hasArgument): Added.
1196         (checkForArgumentAndRemoveFromArrayRef): Refactor to use the new
1197         findMatchingArguments subroutine.
1198
1199 2013-10-04  Alexey Proskuryakov  <ap@apple.com>
1200
1201         Update svn-config for new Visual Studio extensions
1202         https://bugs.webkit.org/show_bug.cgi?id=122344
1203
1204         Reviewed by Brent Fulgham.
1205
1206         * svn-config: Add new Visual Studio extensions.
1207
1208 2013-10-04  Alex Christensen  <achristensen@webkit.org>
1209
1210         Made WinLauncher have better error handling, crash reporting, and modifiability.
1211         https://bugs.webkit.org/show_bug.cgi?id=122319
1212
1213         Reviewed by Brent Fulgham.
1214
1215         * WinLauncher/WinLauncher.cpp:
1216         (WinLauncherWebHost::didFailProvisionalLoadWithError):
1217         Don't display the numerous "Cancelled" messages that are obviously from the user.
1218         (createCrashReport): Added.
1219         (dllLauncherEntryPoint):
1220         Made main loop back into while loop and write a crash report if it crashes.
1221         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1222         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
1223         Added WinLauncherReplace.h.
1224         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
1225         Added linking to DbgHelp.lib.
1226         * WinLauncher/WinLauncherReplace.h:
1227         Added to make modifying WinLauncher behaviour and appearance easy.
1228         (processCrashDump): Added.
1229
1230 2013-10-04  Dirk Pranke  <dpranke@chromium.org>
1231
1232         remove dpranke from webkitpy watchlist
1233         https://bugs.webkit.org/show_bug.cgi?id=122331
1234
1235         Reviewed by Brent Fulgham.
1236
1237         * Scripts/webkitpy/common/config/watchlist:
1238
1239 2013-10-04  Tim Horton  <timothy_horton@apple.com>
1240
1241         [mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
1242         https://bugs.webkit.org/show_bug.cgi?id=122299
1243
1244         Reviewed by Beth Dakin.
1245
1246         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1247         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
1248         The last fix didn't work; instead of trying to block, turn off threaded scrolling for all three tests.
1249
1250 2013-10-04  Alexey Proskuryakov  <ap@apple.com>
1251
1252         Watchlist is broken after <http://trac.webkit.org/r156880>
1253
1254         * Scripts/webkitpy/common/config/watchlist: Remove an incorrect change.
1255
1256 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
1257
1258         Remove Qt features from build and test tools
1259         https://bugs.webkit.org/show_bug.cgi?id=122312
1260
1261         Reviewed by Anders Carlsson.
1262
1263         * Scripts/build-dumprendertree:
1264         * Scripts/build-jsc:
1265         * Scripts/build-webkit:
1266         * Scripts/build-webkittestrunner:
1267         * Scripts/old-run-webkit-tests:
1268         (openDumpTool):
1269         (buildPlatformResultHierarchy):
1270         (buildPlatformTestHierarchy):
1271         (readSkippedFiles):
1272         * Scripts/run-launcher:
1273         * Scripts/run-qtwebkit-tests: Removed.
1274         * Scripts/run-webkit-tests:
1275         (useNewRunWebKitTests):
1276         * Scripts/update-webkit:
1277         * Scripts/webkit-build-directory:
1278         * Scripts/webkitdirs.pm:
1279         (argumentsForConfiguration):
1280         (jscProductDir):
1281         (builtDylibPathForName):
1282         (isAppleWebKit):
1283         (launcherPath):
1284         (launcherName):
1285         (checkRequiredSystemConfig):
1286         (setupCygwinEnv):
1287         (copyInspectorFrontendFiles):
1288         (setPathForRunningWebKitApp):
1289         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
1290         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1291         (BaselineOptimizerTest.test_mac_future):
1292         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
1293         (BaselineOptimizerTest.test_common_directory_includes_root):
1294         (BaselineOptimizerTest.test_virtual_ports_filtered):
1295         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1296         (test_parse_reviewer_text):
1297         * Scripts/webkitpy/common/config/watchlist:
1298         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1299         (PortTest.disabled_test_chromium_mac_lion_in_test_shell_mode):
1300         * Scripts/webkitpy/port/base.py:
1301         (Port.__init__):
1302         (Port._port_flag_for_scripts):
1303         (Port._wk2_port_name):
1304         * Scripts/webkitpy/port/builders.py:
1305         * Scripts/webkitpy/port/factory.py:
1306         (platform_options):
1307         (PortFactory):
1308         (PortFactory._default_port):
1309         * Scripts/webkitpy/port/factory_unittest.py:
1310         (FactoryTest.test_gtk):
1311         * Scripts/webkitpy/port/qt.py: Removed.
1312         * Scripts/webkitpy/port/qt_unittest.py: Removed.
1313         * Scripts/webkitpy/style/checker.py:
1314         * Scripts/webkitpy/style/checker_unittest.py:
1315         (GlobalVariablesTest.test_path_rules_specifier):
1316         * Scripts/webkitpy/style/checkers/cmake.py:
1317         (CMakeChecker):
1318         * Scripts/webkitpy/style/checkers/cpp.py:
1319         (_classify_include):
1320         (check_include_line):
1321         (check_identifier_name_in_declaration):
1322         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1323         (OrderOfIncludesTest.test_classify_include):
1324         (WebKitStyleTest.test_names):
1325         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1326         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
1327         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1328         (TestRebaselineTest.test_baseline_directory):
1329         * Scripts/webkitpy/tool/main.py:
1330         (WebKitPatch):
1331
1332 2013-10-03  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1333
1334         Unreviewed. Add myself to some watchlists.
1335
1336         * Scripts/webkitpy/common/config/watchlist:
1337
1338 2013-10-03  Ryosuke Niwa  <rniwa@webkit.org>
1339
1340         Remove Qt builders from the flakiness dashboard.
1341
1342         * TestResultServer/static-dashboards/builders.jsonp:
1343         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1344         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1345         * TestResultServer/static-dashboards/loader_unittests.js:
1346
1347 2013-10-03  Tim Horton  <timothy_horton@apple.com>
1348
1349         [mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
1350         https://bugs.webkit.org/show_bug.cgi?id=122299
1351
1352         Reviewed by Beth Dakin.
1353
1354         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
1355         Disable threaded scrolling.
1356
1357         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1358         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
1359         Synchronously wait for the scrolling thread to inform the main thread of the new scroll position.
1360
1361 2013-10-03  Anders Carlsson  <andersca@apple.com>
1362
1363         Use numeric strings in the OS version dictionary
1364         https://bugs.webkit.org/show_bug.cgi?id=122300
1365
1366         Reviewed by Mark Rowe.
1367
1368         * Scripts/webkitpy/common/system/platforminfo.py:
1369         (PlatformInfo._determine_mac_version):
1370
1371 2013-10-03  Alexey Proskuryakov  <ap@apple.com>
1372
1373         Fix LeaksViewer to load leaks results from MountainLion, not Lion.
1374
1375         Rubber-stamped by Tim Horton.
1376
1377         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1378         (LeaksViewer._displayURLPrompt):
1379
1380 2013-10-03  Dan Bernstein  <mitz@apple.com>
1381
1382         REGRESSION (r156811): Objective-C JavaScriptCore API test failing on Mountain Lion bots
1383         https://bugs.webkit.org/show_bug.cgi?id=122260
1384
1385         Reviewed by Alexey Proskuryakov.
1386
1387         For the API to work, the tests need to be compiled with a newer version of the LLVM
1388         compiler. Until the bots are updated to that version, disable the tests on 10.8.
1389
1390         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
1391
1392 2013-10-02  Mario Sanchez Prada  <mario.prada@samsung.com>
1393
1394         [ATK] Expose aria-invalid as a text attribute (not object attribute)
1395         https://bugs.webkit.org/show_bug.cgi?id=122015
1396
1397         Reviewed by Chris Fleizach.
1398
1399         Adapted DRT and WKTR to check the exposure of the aria-invalid
1400         attribute as a text attribute, instead of an object attribute.
1401
1402         Also, done some refactoring of the code to try to keep things
1403         simpler and more coherent, by defining new helper functions,
1404         simplifying code, moving static variables and functions into
1405         unnammed namespaces and so on, without altering the logic other
1406         than for checking the text attribute for aria-invalid.
1407
1408         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1409         (coreAttributeToAtkAttribute): Consider 'invalid' as the name of
1410         the attribute exposed by the ATK wrapper, not 'aria-invalid'.
1411         Also, never return an empty string if not falling through any of
1412         the cases checked here, and return the original attribute instead.
1413         (atkAttributeValueToCoreAttributeValue): New helper function to
1414         match the attributes values returned by the ATK wrapper with the
1415         values expected by the layout tests. Moved the mappings for the
1416         values of AXSortDirection here as well.
1417         (getAttributeSet): New helper function to retrieve a list of
1418         attributes (an AtkAttributeSet) from an AtkObject using the right
1419         API depending on whether we want the object attributes or the text
1420         attributes (in case the object implements AtkText).
1421         (getAttributeSetValueForId): Simplified by using getAttributeSet
1422         and atkAttributeValueToCoreAttributeValue. Also, added a new
1423         parameter to indicater whether we are interested in object
1424         attributes or text attributes.
1425         (getAtkAttributeSetAsString): Ditto.
1426         (attributesOfElement): Updated to pass the new required parameter
1427         to getAtkAttributeSetAsString, indicating that we want the object
1428         attributes in this case, for backwards compatibility.
1429         (indexRangeInTable): Moved up in the file into the unnammed namespace.
1430         (alterCurrentValue): Ditto.
1431         (AccessibilityUIElement::stringAttributeValue): After moving most
1432         of the code here to the new helper functions, simplified it by
1433         just checking whether the required attribute is provided as an
1434         object attribute or, if that's not the case, as a text attribute.
1435         (AccessibilityUIElement::isAttributeSupported): Ditto.
1436         (AccessibilityUIElement::intValue): Updated to pass the new
1437         required parameter to getAttributeSetValueForId, indicating that
1438         we want the object attributes in this case.
1439         (AccessibilityUIElement::hasPopup): Ditto.
1440
1441         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1442         (WTR::coreAttributeToAtkAttribute): Same changes than for DRT.
1443         (WTR::atkAttributeValueToCoreAttributeValue): Ditto.
1444         (WTR::getAttributeSet): Ditto.
1445         (WTR::getAttributeSetValueForId): Ditto.
1446         (WTR::getAtkAttributeSetAsString): Ditto.
1447         (WTR::attributesOfElement): Ditto.
1448         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
1449         (WTR::AccessibilityUIElement::isAttributeSupported): Ditto.
1450         (WTR::AccessibilityUIElement::intValue): Ditto.
1451         (WTR::AccessibilityUIElement::hasPopup): Ditto.
1452
1453 2013-10-02  Ryosuke Niwa  <rniwa@webkit.org>
1454
1455         EWS build fix after the Qt EWS removal.
1456
1457         * QueueStatusServer/model/attachment.py:
1458         (Attachment._calculate_queue_positions):
1459
1460 2013-10-02  Anders Carlsson  <andersca@apple.com>
1461
1462         Remove Qt code from Tools/
1463         https://bugs.webkit.org/show_bug.cgi?id=122227
1464
1465         Reviewed by Andreas Kling.
1466
1467         * DumpRenderTree/WorkQueue.cpp:
1468         * DumpRenderTree/blackberry/src.pro: Removed.
1469         * DumpRenderTree/qt/DumpRenderTree.pro: Removed.
1470         * DumpRenderTree/qt/DumpRenderTree.qrc: Removed.
1471         * DumpRenderTree/qt/DumpRenderTreeMain.cpp: Removed.
1472         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Removed.
1473         * DumpRenderTree/qt/DumpRenderTreeQt.h: Removed.
1474         * DumpRenderTree/qt/EventSenderQt.cpp: Removed.
1475         * DumpRenderTree/qt/EventSenderQt.h: Removed.
1476         * DumpRenderTree/qt/GCControllerQt.cpp: Removed.
1477         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Removed.
1478         * DumpRenderTree/qt/TestRunnerQt.cpp: Removed.
1479         * DumpRenderTree/qt/TestRunnerQt.h: Removed.
1480         * DumpRenderTree/qt/TextInputControllerQt.cpp: Removed.
1481         * DumpRenderTree/qt/TextInputControllerQt.h: Removed.
1482         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Removed.
1483         * DumpRenderTree/qt/WorkQueueItemQt.h: Removed.
1484         * DumpRenderTree/qt/fonts/AHEM____.TTF: Removed.
1485         * DumpRenderTree/qt/resources/user.css: Removed.
1486         * DumpRenderTree/qt/testplugin.cpp: Removed.
1487         * DumpRenderTree/qt/testplugin.h: Removed.
1488         * ImageDiff/ImageDiff.pro: Removed.
1489         * ImageDiff/qt/ImageDiff.cpp: Removed.
1490         * MiniBrowser/qt/BrowserWindow.cpp: Removed.
1491         * MiniBrowser/qt/BrowserWindow.h: Removed.
1492         * MiniBrowser/qt/MiniBrowser.pro: Removed.
1493         * MiniBrowser/qt/MiniBrowser.qrc: Removed.
1494         * MiniBrowser/qt/MiniBrowserApplication.cpp: Removed.
1495         * MiniBrowser/qt/MiniBrowserApplication.h: Removed.
1496         * MiniBrowser/qt/UrlLoader.cpp: Removed.
1497         * MiniBrowser/qt/UrlLoader.h: Removed.
1498         * MiniBrowser/qt/icons/checkbox_checked.png: Removed.
1499         * MiniBrowser/qt/icons/checkbox_unchecked.png: Removed.
1500         * MiniBrowser/qt/icons/contents_width.png: Removed.
1501         * MiniBrowser/qt/icons/favicon.png: Removed.
1502         * MiniBrowser/qt/icons/find.png: Removed.
1503         * MiniBrowser/qt/icons/folder.png: Removed.
1504         * MiniBrowser/qt/icons/info.png: Removed.
1505         * MiniBrowser/qt/icons/next.png: Removed.
1506         * MiniBrowser/qt/icons/plus.png: Removed.
1507         * MiniBrowser/qt/icons/previous.png: Removed.
1508         * MiniBrowser/qt/icons/refresh.png: Removed.
1509         * MiniBrowser/qt/icons/stop.png: Removed.
1510         * MiniBrowser/qt/icons/titlebar.png: Removed.
1511         * MiniBrowser/qt/icons/touch.png: Removed.
1512         * MiniBrowser/qt/icons/touchpoint.png: Removed.
1513         * MiniBrowser/qt/icons/up.png: Removed.
1514         * MiniBrowser/qt/js/MultiSelect.js: Removed.
1515         * MiniBrowser/qt/main.cpp: Removed.
1516         * MiniBrowser/qt/qml/AlertDialog.qml: Removed.
1517         * MiniBrowser/qt/qml/AuthenticationDialog.qml: Removed.
1518         * MiniBrowser/qt/qml/BrowserWindow.qml: Removed.
1519         * MiniBrowser/qt/qml/CheckBox.qml: Removed.
1520         * MiniBrowser/qt/qml/ColorChooser.qml: Removed.
1521         * MiniBrowser/qt/qml/ConfirmDialog.qml: Removed.
1522         * MiniBrowser/qt/qml/Dialog.qml: Removed.
1523         * MiniBrowser/qt/qml/DialogButton.qml: Removed.
1524         * MiniBrowser/qt/qml/DialogLineInput.qml: Removed.
1525         * MiniBrowser/qt/qml/FilePicker.qml: Removed.
1526         * MiniBrowser/qt/qml/ItemSelector.qml: Removed.
1527         * MiniBrowser/qt/qml/MockTouchPoint.qml: Removed.
1528         * MiniBrowser/qt/qml/PromptDialog.qml: Removed.
1529         * MiniBrowser/qt/qml/ProxyAuthenticationDialog.qml: Removed.
1530         * MiniBrowser/qt/qml/ScrollIndicator.qml: Removed.
1531         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Removed.
1532         * MiniBrowser/qt/raw/DerivedSources.pri: Removed.
1533         * MiniBrowser/qt/raw/MiniBrowserRaw.pro: Removed.
1534         * MiniBrowser/qt/raw/Target.pri: Removed.
1535         * MiniBrowser/qt/raw/View.cpp: Removed.
1536         * MiniBrowser/qt/raw/View.h: Removed.
1537         * MiniBrowser/qt/utils.cpp: Removed.
1538         * MiniBrowser/qt/utils.h: Removed.
1539         * QtTestBrowser/QtTestBrowser.pro: Removed.
1540         * QtTestBrowser/QtTestBrowser.qrc: Removed.
1541         * QtTestBrowser/cookiejar.cpp: Removed.
1542         * QtTestBrowser/cookiejar.h: Removed.
1543         * QtTestBrowser/favicon.png: Removed.
1544         * QtTestBrowser/fpstimer.cpp: Removed.
1545         * QtTestBrowser/fpstimer.h: Removed.
1546         * QtTestBrowser/launcherwindow.cpp: Removed.
1547         * QtTestBrowser/launcherwindow.h: Removed.
1548         * QtTestBrowser/locationedit.cpp: Removed.
1549         * QtTestBrowser/locationedit.h: Removed.
1550         * QtTestBrowser/mainwindow.cpp: Removed.
1551         * QtTestBrowser/mainwindow.h: Removed.
1552         * QtTestBrowser/qttestbrowser.cpp: Removed.
1553         * QtTestBrowser/urlloader.cpp: Removed.
1554         * QtTestBrowser/urlloader.h: Removed.
1555         * QtTestBrowser/useragentlist.txt: Removed.
1556         * QtTestBrowser/utils.cpp: Removed.
1557         * QtTestBrowser/utils.h: Removed.
1558         * QtTestBrowser/webinspector.h: Removed.
1559         * QtTestBrowser/webpage.cpp: Removed.
1560         * QtTestBrowser/webpage.h: Removed.
1561         * QtTestBrowser/webview.cpp: Removed.
1562         * QtTestBrowser/webview.h: Removed.
1563         * TestWebKitAPI/DerivedSources.pri: Removed.
1564         * TestWebKitAPI/InjectedBundle.pri: Removed.
1565         * TestWebKitAPI/PlatformWebView.h:
1566         * TestWebKitAPI/TestWebKitAPI.pri: Removed.
1567         * TestWebKitAPI/TestWebKitAPI.pro: Removed.
1568         * TestWebKitAPI/Tests.pri: Removed.
1569         * TestWebKitAPI/Tests/JavaScriptCore/JavaScriptCore.pro: Removed.
1570         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
1571         * TestWebKitAPI/Tests/WTF/WTF.pro: Removed.
1572         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro: Removed.
1573         * TestWebKitAPI/qt/InjectedBundleControllerQt.cpp: Removed.
1574         * TestWebKitAPI/qt/PlatformUtilitiesQt.cpp: Removed.
1575         * TestWebKitAPI/qt/PlatformWebViewQt.cpp: Removed.
1576         * TestWebKitAPI/qt/main.cpp: Removed.
1577         * Tools.pro: Removed.
1578         * WebKitTestRunner/DerivedSources.pri: Removed.
1579         * WebKitTestRunner/EventSenderProxy.h:
1580         * WebKitTestRunner/InjectedBundle/DerivedSources.pri: Removed.
1581         * WebKitTestRunner/InjectedBundle/InjectedBundle.pro: Removed.
1582         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1583         (WTR::InjectedBundlePage::resetAfterTest):
1584         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
1585         (WTR::InjectedBundlePage::didClearWindowForFrame):
1586         * WebKitTestRunner/InjectedBundle/Target.pri: Removed.
1587         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1588         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: Removed.
1589         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp: Removed.
1590         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp: Removed.
1591         * WebKitTestRunner/PlatformWebView.h:
1592         * WebKitTestRunner/Target.pri: Removed.
1593         * WebKitTestRunner/TestController.cpp:
1594         (WTR::TestController::resetStateToConsistentValues):
1595         * WebKitTestRunner/TestController.h:
1596         * WebKitTestRunner/WebKitTestRunner.pro: Removed.
1597         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Removed.
1598         * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Removed.
1599         * WebKitTestRunner/qt/TestControllerQt.cpp: Removed.
1600         * WebKitTestRunner/qt/TestInvocationQt.cpp: Removed.
1601         * WebKitTestRunner/qt/WebKitTestRunner.qrc: Removed.
1602         * WebKitTestRunner/qt/main.cpp: Removed.
1603         * WebKitTestRunner/qt/resources/user.css: Removed.
1604         * qmake/.qmake.cache: Removed.
1605         * qmake/.qmake.conf: Removed.
1606         * qmake/README: Removed.
1607         * qmake/config.tests/README: Removed.
1608         * qmake/config.tests/fontconfig/fontconfig.cpp: Removed.
1609         * qmake/config.tests/fontconfig/fontconfig.pro: Removed.
1610         * qmake/config.tests/gccdepends/empty.cpp: Removed.
1611         * qmake/config.tests/gccdepends/gccdepends.pro: Removed.
1612         * qmake/config.tests/glx/glx.cpp: Removed.
1613         * qmake/config.tests/glx/glx.pro: Removed.
1614         * qmake/config.tests/gnuld/gnuld.pro: Removed.
1615         * qmake/config.tests/gnuld/main.cpp: Removed.
1616         * qmake/config.tests/libXcomposite/libXcomposite.cpp: Removed.
1617         * qmake/config.tests/libXcomposite/libXcomposite.pro: Removed.
1618         * qmake/config.tests/libXrender/libXrender.cpp: Removed.
1619         * qmake/config.tests/libXrender/libXrender.pro: Removed.
1620         * qmake/config.tests/libwebp/libwebp.cpp: Removed.
1621         * qmake/config.tests/libwebp/libwebp.pro: Removed.
1622         * qmake/config.tests/libxml2/libxml2.cpp: Removed.
1623         * qmake/config.tests/libxml2/libxml2.pro: Removed.
1624         * qmake/config.tests/libxslt/libxslt.cpp: Removed.
1625         * qmake/config.tests/libxslt/libxslt.pro: Removed.
1626         * qmake/config.tests/libzlib/libzlib.cpp: Removed.
1627         * qmake/config.tests/libzlib/libzlib.pro: Removed.
1628         * qmake/dump-features.pl: Removed.
1629         * qmake/mkspecs/features/configure.prf: Removed.
1630         * qmake/mkspecs/features/default_post.prf: Removed.
1631         * qmake/mkspecs/features/default_pre.prf: Removed.
1632         * qmake/mkspecs/features/features.prf: Removed.
1633         * qmake/mkspecs/features/features.pri: Removed.
1634         * qmake/mkspecs/features/force_static_libs_as_shared.prf: Removed.
1635         * qmake/mkspecs/features/functions.prf: Removed.
1636         * qmake/mkspecs/features/gprof.prf: Removed.
1637         * qmake/mkspecs/features/mac/default_post.prf: Removed.
1638         * qmake/mkspecs/features/mac/default_pre.prf: Removed.
1639         * qmake/mkspecs/features/minimal_qt.prf: Removed.
1640         * qmake/mkspecs/features/production_build.prf: Removed.
1641         * qmake/mkspecs/features/rpath.prf: Removed.
1642         * qmake/mkspecs/features/unix/default_post.prf: Removed.
1643         * qmake/mkspecs/features/unix/default_pre.prf: Removed.
1644         * qmake/mkspecs/features/unix/icc.prf: Removed.
1645         * qmake/mkspecs/features/use_all_in_one_files.prf: Removed.
1646         * qmake/mkspecs/features/valgrind.prf: Removed.
1647         * qmake/mkspecs/features/webkit_modules.prf: Removed.
1648         * qmake/mkspecs/features/win32/default_post.prf: Removed.
1649         * qmake/mkspecs/features/win32/default_pre.prf: Removed.
1650         * qmake/mkspecs/modules/angle.prf: Removed.
1651         * qmake/mkspecs/modules/javascriptcore.prf: Removed.
1652         * qmake/mkspecs/modules/webcore.prf: Removed.
1653         * qmake/mkspecs/modules/webkit1.prf: Removed.
1654         * qmake/mkspecs/modules/webkit2.prf: Removed.
1655         * qmake/mkspecs/modules/wtf.prf: Removed.
1656
1657 2013-10-02  Tim Horton  <timothy_horton@apple.com>
1658
1659         [mac] Stop using DrawingAreaImpl on PLATFORM(MAC) 
1660         https://bugs.webkit.org/show_bug.cgi?id=121859
1661         <rdar://problem/15069359>
1662
1663         Reviewed by Anders Carlsson.
1664
1665         * WebKitTestRunner/TestInvocation.cpp:
1666         (WTR::shouldUseThreadedScrolling):
1667         (WTR::updateThreadedScrollingForCurrentTest):
1668         (WTR::TestInvocation::invoke):
1669         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1670         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useThreadedScrolling:]):
1671         (WTR::PlatformWebView::PlatformWebView):
1672         (WTR::PlatformWebView::viewSupportsOptions):
1673         Rename the tiled drawing switch to threaded scrolling, since that's really
1674         all it switches now that we use tiled drawing everywhere.
1675
1676         Use an unbuffered window, as well, to avoid snapshotting issues on some platforms
1677         and to more closely match the case we're interested in testing.
1678
1679 2013-10-02  Anders Carlsson  <andersca@apple.com>
1680
1681         Move AHEM____.TTF from qt/fonts/ to fonts/.
1682
1683         Rubber-stamped by Andreas Kling.
1684
1685         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1686         * DumpRenderTree/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/qt/fonts/AHEM____.TTF.
1687
1688 2013-10-02  Ádám Kallai  <kadam@inf.u-szeged.hu>
1689
1690         Remove Qt bots and EWS from trunk.
1691         https://bugs.webkit.org/show_bug.cgi?id=122210.
1692
1693         Reviewed by Allan Sandfeld Jensen.
1694
1695         Remove Qt buil dbots.
1696
1697         * BuildSlaveSupport/build.webkit.org-config/config.json:
1698         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1699         (appendCustomBuildFlags):
1700         (RunGtkAPITests.getText2):
1701         (Factory.__init__):
1702         (TestFactory.__init__):
1703         (BuildAndTestFactory.__init__):
1704         (loadBuilderConfig):
1705         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1706
1707 2013-10-02  Ádám Kallai  <kadam@inf.u-szeged.hu>
1708
1709         Remove Qt bots and EWS from trunk.
1710         https://bugs.webkit.org/show_bug.cgi?id=122210.
1711
1712         Reviewed by Allan Sandfeld Jensen.
1713
1714         Remove Qt EWS bots.
1715
1716         * QueueStatusServer/config/queues.py:
1717         * Scripts/webkitpy/common/config/ews.json:
1718
1719 2013-10-01  Timothy Hatcher  <timothy@apple.com>
1720
1721         Fix singular labels for test failures.
1722
1723         https://bugs.webkit.org/show_bug.cgi?id=122200
1724
1725         Reviewed by Joseph Pecoraro.
1726
1727         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1728         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1729
1730 2013-10-01  Timothy Hatcher  <timothy@apple.com>
1731
1732         Don't keep appending iterations each time the queue updates.
1733
1734         https://bugs.webkit.org/show_bug.cgi?id=122198
1735
1736         Reviewed by Joseph Pecoraro.
1737
1738         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1739         (BuildbotQueue.prototype.update):
1740
1741 2013-10-01  Timothy Hatcher  <timothy@apple.com>
1742
1743         Properly sort iterations in the Dashboard by revision for out-of-order queues.
1744
1745         https://bugs.webkit.org/show_bug.cgi?id=122196
1746
1747         Reviewed by Brent Fulgham.
1748
1749         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1750         (BuildbotIteration):
1751         (BuildbotIteration.prototype.update):
1752         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1753         (BuildbotQueue.prototype.update):
1754         (BuildbotQueue.prototype.sortIterations):
1755
1756 2013-10-01  Timothy Hatcher  <timothy@apple.com>
1757
1758         Fix some exceptions seen in the Buildbot Dashboard when looking at unloaded iterations.
1759
1760         Also fix some URLs to not have extras slashes and add a page title.
1761
1762         https://bugs.webkit.org/show_bug.cgi?id=122192
1763
1764         Reviewed by Joseph Pecoraro.
1765
1766         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1767         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1768         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1769         (WebKitBuildbot.prototype.buildLogURLForIteration):
1770         (WebKitBuildbot.prototype.layoutTestResultsURLForIteration):
1771         (WebKitBuildbot.prototype.javascriptTestResultsURLForIteration):
1772         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1773
1774 2013-10-01  Alexey Proskuryakov  <ap@apple.com>
1775
1776         [Mac] Set NSApplication current event while sending events directly to views
1777         https://bugs.webkit.org/show_bug.cgi?id=122179
1778
1779         Reviewed by Darin Adler.
1780
1781         DumpRenderTree and WebKitTestRunner send events directly to WebHMTLView or WKView,
1782         which doesn't update [NSApp currentEvent]. But there are many places in WebKit that
1783         use the current event.
1784
1785         * DumpRenderTree/mac/EventSendingController.mm:
1786         (-[EventSendingController mouseDown:withModifiers:]):
1787         (-[EventSendingController mouseUp:withModifiers:]):
1788         (-[EventSendingController mouseMoveToX:Y:]):
1789         (-[EventSendingController mouseScrollByX:andY:continuously:]):
1790         (-[EventSendingController contextClick]):
1791         (-[EventSendingController keyDown:withModifiers:withLocation:]):
1792         * WebKitTestRunner/mac/EventSenderProxy.mm:
1793         (WTR::EventSenderProxy::mouseDown):
1794         (WTR::EventSenderProxy::mouseUp):
1795         (WTR::EventSenderProxy::mouseMoveTo):
1796         (WTR::EventSenderProxy::keyDown):
1797         (WTR::EventSenderProxy::mouseScrollBy):
1798         Update the current event. We were already using the SPI in WebKit.
1799
1800 2013-10-01  Joseph Pecoraro  <pecoraro@apple.com>
1801
1802         Buildbot Dashboard: Fix JSHint issue: 'perlTestResults' used out of scope.
1803         https://bugs.webkit.org/show_bug.cgi?id=122183
1804
1805         Reviewed by Timothy Hatcher.
1806
1807         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1808         (BuildbotIteration.prototype.update):
1809
1810 2013-10-01  Timothy Hatcher  <timothy@apple.com>
1811
1812         Tweaks to the Buildbot Dashboard
1813
1814         https://bugs.webkit.org/show_bug.cgi?id=122169
1815
1816         Reviewed by Alexey Proskuryakov.
1817
1818         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1819         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
1820         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1821         (BuildbotQueueView.prototype.revisionLinksForIteration):
1822         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1823         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1824         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Added.
1825         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1826         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1827         (WebKitBuildbot.prototype.buildLogURLForIteration):
1828         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1829
1830 2013-10-01  Commit Queue  <commit-queue@webkit.org>
1831
1832         Unreviewed, rolling out r156725.
1833         http://trac.webkit.org/changeset/156725
1834         https://bugs.webkit.org/show_bug.cgi?id=122176
1835
1836         broke all the mismatch tests again (Requested by thorton on
1837         #webkit).
1838
1839         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1840         (WTR::PlatformWebView::PlatformWebView):
1841
1842 2013-10-01  Alex Christensen  <achristensen@webkit.org>
1843
1844         Implemented createWebViewWithRequest in WinLauncher.
1845         https://bugs.webkit.org/show_bug.cgi?id=122069
1846
1847         Reviewed by Brent Fulgham.
1848
1849         * WinLauncher/PrintWebUIDelegate.cpp:
1850         (PrintWebUIDelegate::createWebViewWithRequest): Added.
1851         * WinLauncher/PrintWebUIDelegate.h:
1852         Removed createWebViewWithRequest stub.
1853
1854 2013-10-01  Tim Horton  <timothy_horton@apple.com>
1855
1856         [wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
1857         https://bugs.webkit.org/show_bug.cgi?id=122006
1858         <rdar://problem/15095197>
1859
1860         Reviewed by Dean Jackson.
1861
1862         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1863         (WTR::PlatformWebView::PlatformWebView):
1864         Layer-back the root view in WebKitTestRunner's window, to work around a bug
1865         where the window server snapshot API returns blank snapshots.
1866
1867         Re-landing after r156724, this should not break everything now.
1868
1869 2013-10-01  Tim Horton  <timothy_horton@apple.com>
1870
1871         [mac] 1x emulation on Retina hardware shouldn't use SPI
1872         https://bugs.webkit.org/show_bug.cgi?id=122152
1873         <rdar://problem/15119384>
1874
1875         Reviewed by Anders Carlsson.
1876
1877         * DumpRenderTree/mac/DumpRenderTree.mm:
1878         (createWebViewAndOffscreenWindow):
1879         (main):
1880         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1881         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1882         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1883         (WTR::PlatformWebView::PlatformWebView):
1884         * WebKitTestRunner/mac/main.mm:
1885         (main):
1886         Register for AppleMagnifiedMode instead of using _setWindowResolution:displayIfChanged:.
1887
1888 2013-09-30  Sam Weinig  <sam@webkit.org>
1889
1890         check-webkit-style should not warn about use of C++11 “>>”  instead of “> >"
1891         https://bugs.webkit.org/show_bug.cgi?id=116474
1892
1893         Reviewed by Ryosuke Niwa.
1894
1895         * Scripts/webkitpy/style/checkers/cpp.py:
1896         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1897
1898 2013-09-30  Sam Weinig  <sam@webkit.org>
1899
1900         Remove support for DOMFileSystem
1901         https://bugs.webkit.org/show_bug.cgi?id=122137
1902
1903         Reviewed by Anders Carlsson.
1904
1905         * Scripts/webkitperl/FeatureList.pm:
1906         * Scripts/webkitpy/style/checkers/cpp.py:
1907         (check_spacing):
1908         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1909         (CppStyleTest.test_spacing_for_binary_ops):
1910         * qmake/mkspecs/features/features.pri:
1911
1912 2013-09-30  Mark Rowe  <mrowe@apple.com>
1913
1914         More build fixage for builds with SDKs.
1915
1916         * WebKitTestRunner/Configurations/Base.xcconfig:
1917         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
1918
1919 2013-09-30  Timothy Hatcher  <timothy@apple.com>
1920
1921         Add initial version of a new Buildbot dashboard view.
1922
1923         https://bugs.webkit.org/show_bug.cgi?id=122131
1924
1925         Reviewed by Alexey Proskuryakov.
1926
1927         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Added.
1928         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Added.
1929         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png: Added.
1930         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks@2x.png: Added.
1931         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Added.
1932         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Added.
1933         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing.png: Added.
1934         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing@2x.png: Added.
1935         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7.png: Added.
1936         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7@2x.png: Added.
1937         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8.png: Added.
1938         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8@2x.png: Added.
1939         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP.png: Added.
1940         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP@2x.png: Added.
1941         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BaseObject.js: Added.
1942         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js: Added.
1943         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js: Added.
1944         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Added.
1945         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: Added.
1946         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: Added.
1947         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js: Added.
1948         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: Added.
1949         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Added.
1950         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js: Added.
1951         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js: Added.
1952         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: Added.
1953         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotBuilderQueueView.css: Added.
1954         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css: Added.
1955         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotTesterQueueView.css: Added.
1956         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Added.
1957         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css: Added.
1958         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added.
1959
1960 2013-09-30  Benjamin Poulain  <benjamin@webkit.org>
1961
1962         Remove the code guarded by STYLE_SCOPED
1963         https://bugs.webkit.org/show_bug.cgi?id=122123
1964
1965         Reviewed by Anders Carlsson.
1966
1967         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1968         (resetDefaultsToConsistentValues):
1969         * Scripts/webkitperl/FeatureList.pm:
1970         * qmake/mkspecs/features/features.pri:
1971
1972 2013-09-30  Mark Rowe  <mrowe@apple.com>
1973
1974         Fix the build when building against an SDK.
1975
1976         Xcode helpfully prepends $(SDKROOT) to the paths in FRAMEWORK_SEARCH_PATHS when generating
1977         the compiler command lines. It can't know to do this for the system framework search paths
1978         we add manually via OTHER_CFLAGS though, so we need to prefix them with $(SDKROOT) ourself.
1979
1980         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
1981         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
1982
1983 2013-09-30  Brent Fulgham  <bfulgham@apple.com>
1984
1985         [Windows] Unreviewed test fix. Prevent crash when changing URL paths during testing.
1986
1987         A shared BSTR value (_bstr_t) was being reallocated outside the smart pointer, causing
1988         it to be double-freed.
1989
1990         * WinLauncher/WinLauncher.cpp:
1991         (EditProc): Be explicit about type passed to loadURL.
1992         (loadURL): Create a shallow copy of the BSTR so we only allocate memory if needed. Use _bstr_t so
1993         that reallocating the BSTR is done with the knowledge of the smart pointer.
1994
1995 2013-09-30  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1996
1997         [Qt] Fix force_static_libs_as_shared in WebKit2
1998         https://bugs.webkit.org/show_bug.cgi?id=121961
1999
2000         Reviewed by Csaba Osztrogonác.
2001
2002         Get rid of the unused WebKit2QML library
2003
2004         * qmake/mkspecs/features/webkit_modules.prf:
2005         * qmake/mkspecs/modules/webkit2qml.prf: Removed.
2006
2007 2013-09-30  Krzysztof Wolanski  <k.wolanski@samsung.com>
2008
2009         [EFL] Fix incorrect click counting in EventSenderProxy
2010         https://bugs.webkit.org/show_bug.cgi?id=122098
2011
2012         Reviewed by Gyuyoung Kim.
2013
2014         Previously used two types of recording time, which conflicted with each other.
2015
2016         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2017         (WTR::EventSenderProxy::mouseUp):
2018
2019 2013-09-30  Zan Dobersek  <zdobersek@igalia.com>
2020
2021         [webkitpy] Make the Xvfb screen depth overridable
2022         https://bugs.webkit.org/show_bug.cgi?id=122089
2023
2024         Reviewed by Gyuyoung Kim.
2025
2026         Make the Xvfb screen depth overridable by checking if the XVFB_SCREEN_DEPTH environment variable
2027         was set. The default value that's used if the variable wasn't set is 24.
2028
2029         * Scripts/webkitpy/port/xvfbdriver.py:
2030         (XvfbDriver._xvfb_screen_depth):
2031         (XvfbDriver._start):
2032         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
2033         (XvfbDriverTest.make_driver):
2034         (XvfbDriverTest.test_start_no_pixel_tests):
2035         (XvfbDriverTest.test_start_pixel_tests):
2036         (XvfbDriverTest.test_start_arbitrary_worker_number):
2037         (XvfbDriverTest.test_next_free_display):
2038         (XvfbDriverTest.test_start_next_worker):
2039
2040 2013-09-29  Mark Rowe  <mrowe@apple.com>
2041
2042         Fix the Lion build.
2043
2044         Ensure that C++ and Objective-C++ files build with the right compiler flags.
2045
2046         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
2047         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
2048
2049 2013-09-28  Mark Rowe  <mrowe@apple.com>
2050
2051         Fix some failures with newer versions of clang.
2052
2053         Some CoreGraphics headers generate warnings under newer versions of clang. Since they're system headers the warnings would
2054         usually be suppressed, but we're adding the frameworks to the non-system framework search path so they're no longer treated
2055         as system headers. We address this by removing the system paths from FRAMEWORK_SEARCH_PATHS and using the -iframework compiler
2056         flag in OTHER_CFLAGS to add the paths to the system framework search path. We have to set OTHER_CFLAGS at the target level
2057         in order for it to coexist with the ASAN-related OTHER_CFLAGS that's set in DebugRelease.xcconfig.
2058
2059         Reviewed by Dan Bernstein.
2060
2061         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2062         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
2063         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2064         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2065         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
2066         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
2067         * WebKitTestRunner/Configurations/Base.xcconfig:
2068         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
2069         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2070         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2071         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2072
2073 2013-09-27  Commit Queue  <commit-queue@webkit.org>
2074
2075         Unreviewed, rolling out r156569.
2076         http://trac.webkit.org/changeset/156569
2077         https://bugs.webkit.org/show_bug.cgi?id=122035
2078
2079         broke a lot of mismatch tests (Requested by thorton on
2080         #webkit).
2081
2082         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2083         (WTR::PlatformWebView::PlatformWebView):
2084
2085 2013-09-27  Alexey Proskuryakov  <ap@apple.com>
2086
2087         Don't retry failures on Apple MountainLion Release WK1 tester
2088         https://bugs.webkit.org/show_bug.cgi?id=122026
2089
2090         Reviewed by Mark Rowe.
2091
2092         * BuildSlaveSupport/build.webkit.org-config/config.json: Added --no-retry-failures
2093         on this bot.
2094
2095 2013-09-27  Alexey Proskuryakov  <ap@apple.com>
2096
2097         Don't hardcode builder specific configuration in buildbot master.cfg
2098         https://bugs.webkit.org/show_bug.cgi?id=122023
2099
2100         Reviewed by Mark Rowe.
2101
2102         * BuildSlaveSupport/build.webkit.org-config/config.json: Added an additionalArguments
2103         property to Qt Mountain Lion Release, making it run pixel tests.
2104
2105         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2106         (RunWebKitTests.start): Use additionalArguments.
2107         (RunWebKit2Tests.start): Don't hardcode individual bot behavior here.
2108
2109 2013-09-27  Tim Horton  <timothy_horton@apple.com>
2110
2111         [wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
2112         https://bugs.webkit.org/show_bug.cgi?id=122006
2113         <rdar://problem/15095197>
2114
2115         Reviewed by Dean Jackson.
2116
2117         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2118         (WTR::PlatformWebView::PlatformWebView):
2119         Layer-back the root view in WebKitTestRunner's window, to work around a bug
2120         where the window server snapshot API returns blank snapshots.
2121
2122 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
2123
2124         [GTK] GTK does not expose heading level correctly. Was: accessibility/heading-level.html is failing
2125         https://bugs.webkit.org/show_bug.cgi?id=106924
2126
2127         Reviewed by Chris Fleizach.
2128
2129         Consider headings levels as values to be returned in intValue()
2130         both in DRT and WKTR, so we can share more tests with other ports.
2131
2132         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2133         (AccessibilityUIElement::intValue): Consider headings too.
2134         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2135         (WTR::AccessibilityUIElement::intValue): Ditto.
2136
2137 2013-09-26  Darin Adler  <darin@apple.com>
2138
2139         rename KURL to URL
2140         https://bugs.webkit.org/show_bug.cgi?id=16214
2141
2142         Reviewed by Andreas Kling.
2143
2144         * many files: Renamed, using script.
2145
2146 2013-09-27  Darin Adler  <darin@apple.com>
2147
2148         Fix Python scripts test failures.
2149
2150         * Scripts/webkitpy/style/checkers/cpp.py:
2151         (_FunctionState.modifiers_and_return_type): Added this back. Used only by tests
2152         now, not by the checker itself.
2153
2154 2013-09-27  Denis Nomiyama  <d.nomiyama@samsung.com>
2155
2156         [GTK][WK2] Logging of accessibility events is not disabled between tests
2157         https://bugs.webkit.org/show_bug.cgi?id=121957
2158
2159         Reviewed by Mario Sanchez Prada.
2160
2161         Fixed an issue in AccessibilityNotificationHandler where the destructor
2162         was not disconnecting accessibility event callbacks if logging was on.
2163         The decision of disconnecting events can solely rely on the existence of
2164         notification handlers because logging uses the global notification
2165         handler.
2166
2167         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2168         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks): Fixed
2169         disconnection when logging is on.
2170
2171 2013-09-27  Patrick Gansterer  <paroga@webkit.org>
2172
2173         Add general CMakeLists.txt for DRT
2174         https://bugs.webkit.org/show_bug.cgi?id=119268
2175
2176         Reviewed by Gyuyoung Kim.
2177
2178         The new file allows better sharing between ports.
2179
2180         * CMakeLists.txt:
2181         * DumpRenderTree/CMakeLists.txt: Added.
2182         * DumpRenderTree/PlatformEfl.cmake: Added.
2183         * DumpRenderTree/efl/CMakeLists.txt: Removed.
2184
2185 2013-09-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2186
2187         [Qt] Fix force_static_libs_as_shared in WebKit2
2188         https://bugs.webkit.org/show_bug.cgi?id=121961
2189
2190         Reviewed by Csaba Osztrogonác.
2191
2192         Reenable force_static_libs_as_shared when building WebKit2.
2193
2194         * qmake/mkspecs/features/default_post.prf:
2195
2196 2013-09-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2197
2198         [Qt] Mock implementations of positioning and orientation not used
2199         https://bugs.webkit.org/show_bug.cgi?id=121956
2200
2201         Reviewed by Csaba Osztrogonác.
2202
2203         Move production_build checks to sanitizeFeatures where its value is actually known.
2204
2205         * qmake/mkspecs/features/features.prf:
2206         * qmake/mkspecs/features/features.pri:
2207
2208 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
2209
2210         [ATK] Normalize checks in entry points for DRT and WKTR
2211         https://bugs.webkit.org/show_bug.cgi?id=121959
2212
2213         Reviewed by Chris Fleizach.
2214
2215         Always check if we have a proper instance of AtkObject,
2216         implementing the interfaces that we might need for each case, at
2217         the entry point of every method of AccessibilityUIElement for ATK,
2218         and do those checks in an uniform way across DRT and WKTR, to
2219         avoid confusion and issues when modifying these files in the future.
2220
2221         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2222         (AccessibilityUIElement::getChildren): Use normalized checks.
2223         (AccessibilityUIElement::getChildrenWithRange): Ditto.
2224         (AccessibilityUIElement::rowCount): Ditto.
2225         (AccessibilityUIElement::columnCount): Ditto.
2226         (AccessibilityUIElement::childrenCount): Ditto.
2227         (AccessibilityUIElement::elementAtPoint): Ditto.
2228         (AccessibilityUIElement::getChildAtIndex): Ditto.
2229         (AccessibilityUIElement::allAttributes): Ditto.
2230         (AccessibilityUIElement::titleUIElement): Ditto.
2231         (AccessibilityUIElement::parentElement): Ditto.
2232         (AccessibilityUIElement::attributesOfChildren): Ditto.
2233         (AccessibilityUIElement::role): Ditto.
2234         (AccessibilityUIElement::title): Ditto.
2235         (AccessibilityUIElement::description): Ditto.
2236         (AccessibilityUIElement::stringValue): Ditto.
2237         (AccessibilityUIElement::language): Ditto.
2238         (AccessibilityUIElement::x): Ditto.
2239         (AccessibilityUIElement::y): Ditto.
2240         (AccessibilityUIElement::width): Ditto.
2241         (AccessibilityUIElement::height): Ditto.
2242         (AccessibilityUIElement::orientation): Ditto.
2243         (AccessibilityUIElement::intValue): Ditto.
2244         (AccessibilityUIElement::minValue): Ditto.
2245         (AccessibilityUIElement::maxValue): Ditto.
2246         (indexRangeInTable): Ditto.
2247         (AccessibilityUIElement::cellForColumnAndRow): Ditto.
2248         (AccessibilityUIElement::stringAttributeValue): Ditto.
2249         (alterCurrentValue): Ditto.
2250         (AccessibilityUIElement::press): Ditto.
2251         (AccessibilityUIElement::documentEncoding): Ditto.
2252         (AccessibilityUIElement::documentURI): Ditto.
2253         (AccessibilityUIElement::hasPopup): Ditto.
2254
2255         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2256         (WTR::indexRangeInTable): Use normalized checks.
2257         (WTR::alterCurrentValue): Ditto.
2258         (WTR::AccessibilityUIElement::getChildren): Ditto.
2259         (WTR::AccessibilityUIElement::getChildrenWithRange): Ditto.
2260         (WTR::AccessibilityUIElement::childrenCount): Ditto.
2261         (WTR::AccessibilityUIElement::elementAtPoint): Ditto.
2262         (WTR::AccessibilityUIElement::indexOfChild): Ditto.
2263         (WTR::AccessibilityUIElement::childAtIndex): Ditto.
2264         (WTR::AccessibilityUIElement::titleUIElement): Ditto.
2265         (WTR::AccessibilityUIElement::parentElement): Ditto.
2266         (WTR::AccessibilityUIElement::attributesOfChildren): Ditto.
2267         (WTR::AccessibilityUIElement::allAttributes): Ditto.
2268         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
2269         (WTR::AccessibilityUIElement::role): Ditto.
2270         (WTR::AccessibilityUIElement::title): Ditto.
2271         (WTR::AccessibilityUIElement::description): Ditto.
2272         (WTR::AccessibilityUIElement::orientation): Ditto.
2273         (WTR::AccessibilityUIElement::stringValue): Ditto.
2274         (WTR::AccessibilityUIElement::language): Ditto.
2275         (WTR::AccessibilityUIElement::x): Ditto.
2276         (WTR::AccessibilityUIElement::y): Ditto.
2277         (WTR::AccessibilityUIElement::width): Ditto.
2278         (WTR::AccessibilityUIElement::height): Ditto.
2279         (WTR::AccessibilityUIElement::intValue): Ditto.
2280         (WTR::AccessibilityUIElement::minValue): Ditto.
2281         (WTR::AccessibilityUIElement::maxValue): Ditto.
2282         (WTR::AccessibilityUIElement::rowCount): Ditto.
2283         (WTR::AccessibilityUIElement::columnCount): Ditto.
2284         (WTR::AccessibilityUIElement::cellForColumnAndRow): Ditto.
2285         (WTR::AccessibilityUIElement::press): Ditto.
2286         (WTR::AccessibilityUIElement::documentEncoding): Ditto.
2287         (WTR::AccessibilityUIElement::documentURI): Ditto.
2288         (WTR::AccessibilityUIElement::hasPopup): Ditto.
2289
2290 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
2291
2292         [ATK] accessibility/aria-sort.html is failing after r156409
2293         https://bugs.webkit.org/show_bug.cgi?id=121947
2294
2295         Reviewed by Chris Fleizach.
2296
2297         Implement AccessibilityUIElement::isSupported for the ATK
2298         platforms, just by checking whether we have an associated object
2299         attribute exposed for the wrapper object matching the required
2300         attribute in the layout test (e.g "AXSortDirection" -> "sort").
2301
2302         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2303         (AccessibilityUIElement::isAttributeSupported): Implemented.
2304         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2305         (WTR::AccessibilityUIElement::isAttributeSupported): Implemented.
2306
2307 2013-09-26  Eric Carlson  <eric.carlson@apple.com>
2308
2309         [MediaStream] make MediaStream testable
2310         https://bugs.webkit.org/show_bug.cgi?id=121967
2311
2312         Reviewed by Dean Jackson.
2313
2314         * DumpRenderTree/mac/UIDelegate.mm:
2315         (-[UIDelegate webView:decidePolicyForUserMediaRequestFromOrigin:listener:]): Add a very permissive
2316             user media request policy delegate.
2317
2318 2013-09-26  Brian J. Burg  <burg@cs.washington.edu>
2319
2320         build-webkit --inspector-frontend should copy WebInspectorUI files
2321         https://bugs.webkit.org/show_bug.cgi?id=117851
2322
2323         Reviewed by Joseph Pecoraro.
2324
2325         Change the --inspector-frontend build option to additionally build/copy 
2326         WebInspectorUI by setting it as the only project that needs to be built.
2327
2328         * Scripts/build-webkit:
2329
2330 2013-09-26  Zan Dobersek  <zdobersek@igalia.com>
2331
2332         XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
2333         https://bugs.webkit.org/show_bug.cgi?id=121951
2334
2335         Reviewed by Carlos Garcia Campos.
2336
2337         Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
2338         software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
2339         500 layout tests that trigger accelerated compositing to be used.
2340
2341         * Scripts/webkitpy/port/xvfbdriver.py:
2342         (XvfbDriver._start):
2343         * Scripts/webkitpy/port/xvfbdriver_unittest.py: Update unit test baselines.
2344         (XvfbDriverTest.test_start_no_pixel_tests):
2345         (XvfbDriverTest.test_start_pixel_tests):
2346         (XvfbDriverTest.test_start_arbitrary_worker_number):
2347         (XvfbDriverTest.test_next_free_display):
2348         (XvfbDriverTest.test_start_next_worker):
2349
2350 2013-09-26  Tim Horton  <timothy_horton@apple.com>
2351
2352         Tiled drawing should not imply threaded scrolling
2353         https://bugs.webkit.org/show_bug.cgi?id=121874
2354         <rdar://problem/15071494>
2355
2356         Reviewed by Sam Weinig.
2357
2358         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2359         (WTR::PlatformWebView::PlatformWebView):
2360         The existing tiled-drawing layout tests require threaded scrolling to be enabled.
2361
2362 2013-09-26  Commit Queue  <commit-queue@webkit.org>
2363
2364         Unreviewed, rolling out r156457.
2365         http://trac.webkit.org/changeset/156457
2366         https://bugs.webkit.org/show_bug.cgi?id=121960
2367
2368         Broke webkitpy tests. (Requested by kling on #webkit).
2369
2370         * Scripts/webkitpy/port/xvfbdriver.py:
2371         (XvfbDriver._start):
2372
2373 2013-09-26  Zan Dobersek  <zdobersek@igalia.com>
2374
2375         XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
2376         https://bugs.webkit.org/show_bug.cgi?id=121951
2377
2378         Reviewed by Carlos Garcia Campos.
2379
2380         Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
2381         software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
2382         500 layout tests that trigger accelerated compositing to be used.
2383
2384         * Scripts/webkitpy/port/xvfbdriver.py:
2385         (XvfbDriver._start):
2386
2387 2013-09-25  Alex Christensen  <achristensen@webkit.org>
2388
2389         Removed check for Apple Application Support directory in WinCairo port.
2390         https://bugs.webkit.org/show_bug.cgi?id=121869
2391
2392         Reviewed by Brent Fulgham.
2393
2394         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2395         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2396         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2397         Use DLLLauncherWinCairo.props for WinCairo ports.
2398         * win/DLLLauncher/DLLLauncherMain.cpp:
2399         (wWinMain):
2400         Don't call modifyPath to check for AAS in the WinCairo port.
2401         * win/DLLLauncher/DLLLauncherWinCairo.props: Added to define WIN_CAIRO.
2402
2403 2013-09-25  Alex Christensen  <achristensen@webkit.org>
2404
2405         Enabled AssembleBuildLogs on WinCairo port.
2406         https://bugs.webkit.org/show_bug.cgi?id=121923
2407
2408         Reviewed by Brent Fulgham.
2409
2410         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
2411         Fixed reference to README, added WinCairo configurations.
2412         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters:
2413         Fixed reference to README.
2414         * win/AssembleBuildLogs/AssembleLogs.cmd:
2415         Added ANGLE projects, skipped QTMovieWin for WinCairo, use PlatformArchitecture for Win64.
2416         * win/AssembleBuildLogs/README: Fixed spelling.
2417
2418 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
2419
2420         [WIN] Fix MSVC C4146 compiler warning
2421         https://bugs.webkit.org/show_bug.cgi?id=121838
2422
2423         Reviewed by Brent Fulgham.
2424
2425         Fix some variables from unsinged to int to fix the compiler warning
2426         "unary minus operator applied to unsigned type, result still unsigned".
2427
2428         * DumpRenderTree/WorkQueueItem.h:
2429         (BackItem::BackItem):
2430         (ForwardItem::ForwardItem):
2431         * DumpRenderTree/win/DumpRenderTree.cpp:
2432         (createWebViewAndOffscreenWindow):
2433
2434 2013-09-25  Zan Dobersek  <zdobersek@igalia.com>
2435
2436         [GTK] Switch the 64-bit Release builder to testing layout tests under WK2
2437         https://bugs.webkit.org/show_bug.cgi?id=121256
2438
2439         Reviewed by Martin Robinson.
2440
2441         Switch the GTK 64-bit Release builder to testing the layout tests under WebKit2.
2442         The GTK 64-bit Release WK2 testing builder is switched to now run layout tests under WebKit1.
2443
2444         * BuildSlaveSupport/build.webkit.org-config/config.json:
2445
2446 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
2447
2448         Add style checker for CMake lists
2449         https://bugs.webkit.org/show_bug.cgi?id=121764
2450
2451         Reviewed by Ryosuke Niwa.
2452
2453         Add an additional check to make sure that list of files are sorted.
2454         Exclude lists of include directories for now, since the order
2455         can be importent for compilation of some files.
2456
2457         * Scripts/webkitpy/style/checkers/cmake.py:
2458         (CMakeChecker.check):
2459         (CMakeChecker._check_indent):
2460         (CMakeChecker):
2461         (CMakeChecker._check_list_order):
2462         (CMakeChecker._list_item_path):
2463         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
2464         (CMakeCheckerTest.test_check):
2465
2466 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
2467
2468         CMakeChecker takes unusually long time to run
2469         https://bugs.webkit.org/show_bug.cgi?id=105662
2470
2471         Reviewed by Ryosuke Niwa.
2472
2473         Move the caching mechanism for regular expression of the C++ checker into
2474         a common file and use it for the CMake and ChangeLog checkers too.
2475
2476         * Scripts/webkitpy/style/checkers/changelog.py:
2477         (ChangeLogChecker.check_entry):
2478         * Scripts/webkitpy/style/checkers/cmake.py:
2479         (CMakeChecker._process_line):
2480         (CMakeChecker._check_no_space_cmds):
2481         (CMakeChecker._check_one_space_cmds):
2482         (CMakeChecker._check_non_lowercase_cmd):
2483         * Scripts/webkitpy/style/checkers/common.py:
2484         (match):
2485         (search):
2486         (searchIgnorecase):
2487         (sub):
2488         (subn):
2489         * Scripts/webkitpy/style/checkers/cpp.py:
2490
2491 2013-09-25  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2492
2493         [Qt] Fix build with Qt 5.2 QtPosition module
2494         https://bugs.webkit.org/show_bug.cgi?id=121089
2495
2496         Reviewed by Simon Hausmann.
2497
2498         QtLocation -> QtPositioning. Make sure we set build type before doing configure checks
2499         that might depend on them.
2500
2501         * qmake/mkspecs/features/default_pre.prf:
2502         * qmake/mkspecs/features/features.prf:
2503
2504 2013-09-25  Mario Sanchez Prada  <mario.prada@samsung.com>
2505
2506         [ATK] Fix style issues in AccessibilityUIElementAtk
2507         https://bugs.webkit.org/show_bug.cgi?id=121898
2508
2509         Reviewed by Chris Fleizach.
2510
2511         Avoid the '.f' suffix for float literals and use G_VALUE_INIT
2512         instead of { 0, { { 0 } } } to initialize a GValue.
2513
2514         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2515         (AccessibilityUIElement::clickPointX): Remove suffix.
2516         (AccessibilityUIElement::clickPointY): Ditto.
2517         (AccessibilityUIElement::intValue): Use G_VALUE_INIT and remove suffix.
2518         (AccessibilityUIElement::minValue): Ditto.
2519         (AccessibilityUIElement::maxValue): Ditto.
2520         (AccessibilityUIElement::numberAttributeValue): Remove suffix.
2521         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2522         (WTR::AccessibilityUIElement::numberAttributeValue): Remove suffix.
2523         (WTR::AccessibilityUIElement::x): Ditto.
2524         (WTR::AccessibilityUIElement::y): Ditto.
2525         (WTR::AccessibilityUIElement::width): Ditto.
2526         (WTR::AccessibilityUIElement::height): Ditto.
2527         (WTR::AccessibilityUIElement::clickPointX): Ditto.
2528         (WTR::AccessibilityUIElement::clickPointY): Ditto.
2529         (WTR::AccessibilityUIElement::intValue): Ditto.
2530         (WTR::AccessibilityUIElement::minValue): Ditto.
2531         (WTR::AccessibilityUIElement::maxValue): Ditto.
2532
2533 2013-09-25  Krzysztof Czech  <k.czech@samsung.com>
2534
2535         [EFL] accessibility/loading-iframe-sends-notification.html is failing
2536         https://bugs.webkit.org/show_bug.cgi?id=112003
2537
2538         Reviewed by Mario Sanchez Prada.
2539
2540         Enabled addNotificationListener and removeNotificationListener for EFL port.
2541
2542         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2543         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2544         (WTR::AccessibilityController::removeNotificationListener):
2545
2546 2013-09-24  Filip Pizlo  <fpizlo@apple.com>
2547
2548         Crashing under JSC::DFG::SpeculativeJIT::spill visiting citicards.com
2549         https://bugs.webkit.org/show_bug.cgi?id=121844
2550
2551         Reviewed by Mark Hahnenberg.
2552
2553         * Scripts/run-javascriptcore-tests: Be more clear about what test suite failed.
2554
2555 2013-09-24  Alexey Proskuryakov  <ap@apple.com>
2556
2557         [Mac][WK2] Multiple font tests fail is there is a global setting for font antialiasing threshold
2558         https://bugs.webkit.org/show_bug.cgi?id=121854
2559
2560         Reviewed by Anders Carlsson.
2561
2562         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2563         (WTR::InjectedBundle::platformInitialize): Post a notification to update cached
2564         settings in underlying frameworks.
2565
2566 2013-09-24  Mark Rowe  <mrowe@apple.com>
2567
2568         <rdar://problem/14971518> WebKit should build against the Xcode default toolchain when targeting OS X 10.8
2569
2570         Reviewed by Dan Bernstein.
2571
2572         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2573         * MiniBrowser/Configurations/Base.xcconfig:
2574         * TestWebKitAPI/Configurations/Base.xcconfig:
2575         * WebKitLauncher/Configurations/Base.xcconfig:
2576         * WebKitTestRunner/Configurations/Base.xcconfig:
2577
2578 2013-09-24  Denis Nomiyama  <d.nomiyama@samsung.com>
2579
2580         [ATK] Missing WTR AccessibilityController::addNotificationListener implementation
2581         https://bugs.webkit.org/show_bug.cgi?id=121674
2582
2583         Reviewed by Mario Sanchez Prada.
2584
2585         Implemented the global notification listener for
2586         AccessibilityController. The signal is generated by
2587         AXObjectCache::postPlatformNotification() and received by
2588         axObjectEventListener(). axObjectEventListener will then invoke
2589         JSObjectCallAsFunction() with the respective callback function.
2590
2591         There is no additional test for this patch since its implementation will
2592         be tested by an accessibility layout test that is currently failing
2593         (accessibility/loading-iframe-sends-notification.html).
2594
2595         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Removed
2596         stub implementations of addNotificationListener and
2597         removeNotificationListener for the GTK port.
2598         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2599         (WTR::AccessibilityController::addNotificationListener): Creates the
2600         notification handler and sets the notification function callback.
2601         (WTR::AccessibilityController::removeNotificationListener): Removes the
2602         global handler.
2603
2604 2013-09-24  Anton Obzhirov  <a.obzhirov@samsung.com>
2605
2606         [GTK] fast/images/exif-orientation-composited.html is failing
2607         https://bugs.webkit.org/show_bug.cgi?id=119731
2608
2609         Reviewed by Carlos Garcia Campos.
2610
2611         Add handling respect image orientation property in DRT.
2612
2613         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2614         (TestRunner::overridePreference):
2615
2616 2013-09-24  Zan Dobersek  <zdobersek@igalia.com>
2617
2618         [GTK] Bump the GTK+ dependency in the Wayland-specific Jhbuild moduleset
2619         https://bugs.webkit.org/show_bug.cgi?id=121787
2620
2621         Reviewed by Gustavo Noronha Silva.
2622
2623         * gtk/jhbuild-wayland.modules: Bump the GTK+ dependency that's intended for use when building
2624         with the Wayland target enabled to version 3.10.0.
2625
2626 2013-09-23  Patrick Gansterer  <paroga@webkit.org>
2627
2628         use NOMINMAX instead of #define min min
2629         https://bugs.webkit.org/show_bug.cgi?id=73563
2630
2631         Reviewed by Brent Fulgham.
2632
2633         Use NOMINMAX instead of #define min/max as a cleaner
2634         way of ensuring that Windows system header files don't
2635         define min/max as macro in the first place.
2636
2637         * DumpRenderTree/DumpRenderTreePrefix.h:
2638         * DumpRenderTree/cg/ImageDiffCG.cpp:
2639         * DumpRenderTree/config.h:
2640         * DumpRenderTree/win/ImageDiffCairo.cpp:
2641         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
2642         * WebKitTestRunner/config.h:
2643
2644 2013-09-23  Benjamin Poulain  <benjamin@webkit.org>
2645
2646         Delete TestWebKitAPI domain or some keys before running TestWebKitAPI
2647         https://bugs.webkit.org/show_bug.cgi?id=121715 & <rdar://problem/14269434>
2648
2649         Reviewed by Alexey Proskuryakov.
2650
2651         Previously, initalizing a WebPreference would change the cache model
2652         to WebCacheModelDocumentBrowser. That behavior was due to a stale
2653         preference file on disk.
2654
2655         This patch fixes the tests by resetting the default, and using the proper
2656         default values after initializing WebPreference.
2657
2658         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
2659         (TestWebKitAPI::TEST): Use the proper initial value, unrelated
2660         to the previous runs.
2661
2662         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
2663         (TestWebKitAPI::TEST): This test needs b/f cache to be enabled, so change
2664         cache model to the one required.
2665
2666         * TestWebKitAPI/ios/mainIOS.mm:
2667         (main): Reset the preferences before testing.
2668         * TestWebKitAPI/mac/mainMac.mm:
2669         (main): Ditto.
2670
2671 2013-09-23  Benjamin Poulain  <benjamin@webkit.org>
2672
2673         Delete TestWebKitAPI domain or some keys before running TestWebKitAPI
2674         https://bugs.webkit.org/show_bug.cgi?id=121715 & <rdar://problem/14269434>
2675
2676         Reviewed by Alexey Proskuryakov.
2677
2678         Previously, initalizing a WebPreference would change the cache model
2679         to WebCacheModelDocumentBrowser. That behavior was due to a stale
2680         preference file on disk.
2681
2682         This patch fixes the tests by resetting the default, and using the proper
2683         default values after initializing WebPreference.
2684
2685         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
2686         (TestWebKitAPI::TEST): Use the proper initial value, unrelated
2687         to the previous runs.
2688
2689         * TestWebKitAPI/ios/mainIOS.mm:
2690         (main): Reset the preferences before testing.
2691         * TestWebKitAPI/mac/mainMac.mm:
2692         (main): Ditto.
2693
2694 2013-09-23  Anders Carlsson  <andersca@apple.com>
2695
2696         ListHashSet should work with move-only types
2697         https://bugs.webkit.org/show_bug.cgi?id=121802
2698
2699         Reviewed by Andreas Kling.
2700
2701         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
2702         (TestWebKitAPI::TEST):
2703         Add a test for move-only types.
2704
2705 2013-09-23  Alex Christensen  <alex.christensen@flexsim.com>
2706
2707         Added --64-bit option for Windows build.
2708         https://bugs.webkit.org/show_bug.cgi?id=121799
2709
2710         Reviewed by Brent Fulgham.
2711
2712         * Scripts/webkitdirs.pm:
2713         (determinePassedConfiguration): Add "|x64" for 64-bit configuration.
2714         (isWin64): Added.
2715         (determineIsWin64): Added.
2716
2717 2013-09-23  Anders Carlsson  <andersca@apple.com>
2718
2719         ListHashSet should use std::reverse_iterator for reverse iterators
2720         https://bugs.webkit.org/show_bug.cgi?id=121795
2721
2722         Reviewed by Antti Koivisto.
2723
2724         Add test for reverse iterators.
2725
2726         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
2727         (TestWebKitAPI::TEST):
2728
2729 2013-09-23  Krzysztof Czech  <k.czech@samsung.com>
2730
2731         [EFL] accessibility/aria-invalid is failing
2732         https://bugs.webkit.org/show_bug.cgi?id=111986
2733
2734         Reviewed by Mario Sanchez Prada.
2735
2736         Adds possibility to retrieve JS context.
2737         This is part of the implementation of AccessibilityUIElement::addNotificationListener
2738         from 119883 and 120421.
2739
2740         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
2741         (axObjectEventListener):
2742         (addAccessibilityNotificationHandler):
2743         (removeAccessibilityNotificationHandler):
2744         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2745         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
2746         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
2747
2748 2013-09-20  Mark Rowe  <mrowe@apple.com>
2749
2750         <https://webkit.org/b/90090> build-webkit should verify that your tools are up-to-date
2751
2752         Enforce a minimum OS version of 10.7.5 and Xcode version of 4.6.
2753
2754         Reviewed by David Kilzer.
2755
2756         * Scripts/webkitdirs.pm:
2757         (checkRequiredSystemConfig):
2758
2759 2013-09-20  Mario Sanchez Prada  <mario.prada@samsung.com>
2760
2761         [ATK] Do not expose aria-help in ATK based platforms
2762         https://bugs.webkit.org/show_bug.cgi?id=121675
2763
2764         Reviewed by Chris Fleizach.
2765
2766         Remove the implementations for AccessibilityUIElement::helpText()
2767         from DRT and WKTR for GTK and EFL, since they are based on the
2768         AccessibilityObject::helpText() method and the 'aria-help'
2769         attributes, which is wrong since they should not depend on that
2770         but in ATK specific API (see also http://webkit.org/b/121684).
2771
2772         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2773         (AccessibilityUIElement::helpText): Added a new and empty
2774         implementation, now that we are no longer using this in ATK.
2775         * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Removed file
2776         as the only function provided here was helpText().
2777         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Ditto.
2778         * DumpRenderTree/efl/CMakeLists.txt: AccessibilityUIElementEfl.cpp
2779         removed from the list of sources to compile.
2780         * GNUmakefile.am: Likewise, but for AccessibilityUIElementGtk.cpp.
2781         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2782         (WTR::AccessibilityUIElement::helpText): Replaced old implementation
2783         based in DumpRenderTreeSupportGtk with an empty one.
2784
2785 2013-09-20  Dan Bernstein  <mitz@apple.com>
2786
2787         Make extract-localizable-strings available to WebCore clients
2788         https://bugs.webkit.org/show_bug.cgi?id=121699
2789
2790         Reviewed by Darin Adler.
2791
2792         * Scripts/extract-localizable-strings: Copied to
2793         Soure/WebCore/extract-localizaebl-strings.pl, and changed this into a shell script that
2794         executes the script from its new location. This is a temporary measure until certain code
2795         that is external to WebKit is adapted to the new location.
2796         * Scripts/update-webkit-localizable-strings: Changed to call extract-localizable-strings.pl
2797         from its new location.
2798
2799 2013-09-20  Patrick Gansterer  <paroga@webkit.org>
2800
2801         Nuke remaining VS2005 tools from the tree.
2802         https://bugs.webkit.org/show_bug.cgi?id=121691
2803
2804         Reviewed by Brent Fulgham.
2805
2806         * CLWrapper/CLWrapper.cpp: Removed.
2807         * CLWrapper/CLWrapper.sln: Removed.
2808         * CLWrapper/CLWrapper.vcproj: Removed.
2809         * MIDLWrapper/MIDLWrapper.cpp: Removed.
2810         * MIDLWrapper/MIDLWrapper.sln: Removed.
2811         * MIDLWrapper/MIDLWrapper.vcproj: Removed.
2812         * Scripts/parallelcl: Removed.
2813         * vcbin/cl.exe: Removed.
2814         * vcbin/midl.exe: Removed.
2815
2816 2013-09-20  Mario Sanchez Prada  <mario.prada@samsung.com>
2817
2818         [GTK] socket_embed_hook hitting NULL-check assertion running TestWebKit2
2819         https://bugs.webkit.org/show_bug.cgi?id=121294
2820
2821         Reviewed by Martin Robinson.
2822
2823         Provide a new patch to deal with the issue in the GTK+ module from
2824         the internal jhbuild environment. This issue has been reported
2825         upstream (see https://bugzilla.gnome.org/show_bug.cgi?id=708024).
2826
2827         * gtk/jhbuild.modules: Apply the new patch to the GTK+ module.
2828         * gtk/patches/gtk-3.6-do-not-shutdown-accessibility.patch: Added.
2829
2830 2013-09-20  Denis Nomiyama  <d.nomiyama@samsung.com>
2831
2832         [ATK][WTR] accessibility/aria-invalid.html times out
2833         https://bugs.webkit.org/show_bug.cgi?id=121668
2834
2835         Reviewed by Mario Sanchez Prada.
2836
2837         Fixed WTR::AccessibilityUIElement::stringAttributeValue() to return
2838         false in case of aria-invalid event with empty value.
2839
2840         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2841         (WTR::AccessibilityUIElement::stringAttributeValue): Returns false in
2842         case of aria-invalid event with empty value.
2843
2844 2013-09-20  Denis Nomiyama  <d.nomiyama@samsung.com>
2845
2846         [ATK] Missing WTR AccessibilityUIElement::addNotificationListener implementation
2847         https://bugs.webkit.org/show_bug.cgi?id=120421
2848
2849         Reviewed by Mario Sanchez Prada.
2850
2851         Implemented the notification listener for AccessibilityUIElement for
2852         WebKitTestRunner. The signal is generated by
2853         AXObjectCache::postPlatformNotification() and received by
2854         axObjectEventListener(). axObjectEventListener() will then invoke
2855         JSObjectCallAsFunction() with the respective callback function. The
2856         notification handlers are stored in HashMap in
2857         AccessibilityNotificationHandlerAtk.cpp.
2858
2859         Moved ATK signal handling (printAccessibilityEvent and
2860         axObjectEventListener) to AccessibilityNotificationHandlerAtk.cpp.
2861
2862         * WebKitTestRunner/CMakeLists.txt: Added InjectedBundle/atk to the
2863         include path.
2864         * WebKitTestRunner/GNUmakefile.am:
2865         Added AccessibilityNotificationHandlerAtk.cpp/h.
2866         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Moved
2867         listener IDs to AccessibilityNotificationHandlerAtk.cpp.
2868         * WebKitTestRunner/InjectedBundle/AccessibilityController.h: Moved
2869         listener IDs to AccessibilityNotificationHandlerAtk.cpp.
2870         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added a
2871         notification handler for GTK+ and EFL.
2872         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2873         Moved printAccessibilityEvent and axObjectEventListener to
2874         AccessibilityNotificationHandlerAtk.cpp.
2875         (WTR::AccessibilityController::logAccessibilityEvents): Moved listener
2876         IDs to AccessibilityNotificationHandlerAtk.cpp.
2877         (WTR::AccessibilityController::resetToConsistentState): Moved listener
2878         IDs to AccessibilityNotificationHandlerAtk.cpp.
2879         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Added.
2880         (WTR::printAccessibilityEvent): Prints accessibility events. This
2881         function was moved from AccessibilityControllerAtk.cpp.
2882         (WTR::axObjectEventListener): Callback for signals. This function was
2883         moved from AccessibilityControllerAtk.cpp.
2884         (WTR::AccessibilityNotificationHandler::AccessibilityNotificationHandler):
2885         Initialize element and function callback.
2886         (WTR::AccessibilityNotificationHandler::~AccessibilityNotificationHandler):
2887         Removes handler from HashMap and disconnects callbacks if necessary.
2888         (WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Sets
2889         logging mode and connects callbacks.
2890         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
2891         Sets the notification callback and connects callback to signals.
2892         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
2893         Removes the notification callback from HashMap.
2894         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
2895         Connects axObjectEventListener to ATK signals.
2896         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
2897         Disconnects callback.
2898         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h: Added.
2899         (WTR::AccessibilityNotificationHandler::create): Creates a new instance
2900         of AccessibilityNotificationHandler.
2901         (WTR::AccessibilityNotificationHandler::setPlatformElement): Sets the
2902         element.
2903         (WTR::AccessibilityNotificationHandler::platformElement): Gets the
2904         element.
2905         (WTR::AccessibilityNotificationHandler::notificationFunctionCallback):
2906         Gets the notification callback.
2907         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2908         (WTR::AccessibilityUIElement::addNotificationListener): Creates
2909         notification handler, set the platform element and the notification
2910         callback.
2911         (WTR::AccessibilityUIElement::removeNotificationListener): Deletes the
2912         notification handler.
2913         * WebKitTestRunner/PlatformEfl.cmake:
2914         Added AccessibilityNotificationHandlerAtk.cpp.
2915
2916 2013-09-20  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2917
2918         Update features.pri
2919         https://bugs.webkit.org/show_bug.cgi?id=121670
2920
2921         Reviewed by Jocelyn Turcotte.
2922
2923         Remove feature flags that no longer exists and new ones added to FeatureList.pm
2924
2925         * qmake/mkspecs/features/features.pri:
2926
2927 2013-09-20  Krzysztof Czech  <k.czech@samsung.com>
2928
2929         [GTK][WK2] accessibility/selection-states.html is failing
2930         https://bugs.webkit.org/show_bug.cgi?id=116972
2931
2932         Reviewed by Mario Sanchez Prada.
2933
2934         isSelectable() was not exposed in Accessibility.
2935
2936         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2937
2938 2013-09-19  Dan Bernstein  <mitz@apple.com>
2939
2940         Attempted build fix after r156114.
2941
2942         * Scripts/copy-webkitlibraries-to-product-directory: Removed references to WebCoreSQLite3.
2943
2944 2013-09-19  Alexey Proskuryakov  <ap@apple.com>
2945
2946         REGRESSION (r129451): run-safari --no-saved-state is broken
2947         https://bugs.webkit.org/show_bug.cgi?id=121566
2948
2949         Undo a last minute change that doesn't actually work.
2950
2951         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp): "-1" cannot be passed
2952         via command line, <rdar://problem/15032886>.
2953
2954 2013-09-19  Dan Bernstein  <mitz@apple.com>
2955
2956         Add a style guideline regarding spacing in range-based for loops
2957         https://bugs.webkit.org/show_bug.cgi?id=121620
2958
2959         Reviewed by Anders Carlsson.
2960
2961         * Scripts/webkitpy/style/checkers/cpp.py:
2962         (check_spacing): Added checking that there are spaces around the colon in a range-based for
2963         loop.
2964         (CppChecker): Added whitespace/colon to the categories set.
2965         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2966         (WebKitStyleTest.test_spacing): Added two tests for the new check.
2967
2968 2013-09-18  Sam Weinig  <sam@webkit.org>
2969
2970         Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in Tools
2971         https://bugs.webkit.org/show_bug.cgi?id=121588
2972
2973         Reviewed by Anders Carlsson.
2974
2975         * DumpRenderTree/TestRunner.cpp:
2976         * ImageDiff/efl/ImageDiff.cpp:
2977         * TestWebKitAPI/JavaScriptTest.cpp:
2978         * TestWebKitAPI/PlatformUtilities.cpp:
2979         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2980         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2981         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2982         * WebKitTestRunner/StringFunctions.h:
2983         * WebKitTestRunner/TestInvocation.cpp:
2984         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2985         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2986
2987 2013-09-18  Bem Jones-Bey  <bjonesbe@adobe.com>
2988
2989         W3C Test Import script reformats test HTML
2990         https://bugs.webkit.org/show_bug.cgi?id=119159
2991
2992         Reviewed by Dirk Pranke.
2993
2994         Completely rewrite the test conversion process to minimize
2995         reformatting when adding prefixes, etc. This isn't 100% perfect, there
2996         are still places where it will end up changing the formatting, but it
2997         is much better than before. Most notably, the public interface to the
2998         test converter has changed: now one calls a method instead of creating
2999         an instance of the test converter class. This is because the test
3000         converter class now has state, so one really needs a new instance for
3001         each test.
3002
3003         Note that this also lays some simple groundwork for being able to use
3004         a MockHost in the tests.
3005
3006         * Scripts/webkitpy/w3c/test_converter.py:
3007         (convert_for_webkit):
3008         (_W3CTestConverter):
3009         (_W3CTestConverter.__init__):
3010         (_W3CTestConverter.output):
3011         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
3012         (_W3CTestConverter.convert_style_data):
3013         (_W3CTestConverter.convert_attributes_if_needed):
3014         (_W3CTestConverter.handle_starttag):
3015         (_W3CTestConverter.handle_endtag):
3016         (_W3CTestConverter.handle_startendtag):
3017         (_W3CTestConverter.handle_data):
3018         (_W3CTestConverter.handle_entityref):
3019         (_W3CTestConverter.handle_charref):
3020         (_W3CTestConverter.handle_comment):
3021         (_W3CTestConverter.handle_decl):
3022         (_W3CTestConverter.handle_pi):
3023         * Scripts/webkitpy/w3c/test_converter_unittest.py:
3024         (W3CTestConverterTest):
3025         (W3CTestConverterTest.fake_dir_path):
3026         (W3CTestConverterTest.test_read_prefixed_property_list):
3027         (verify_no_conversion_happened):
3028         * Scripts/webkitpy/w3c/test_importer.py:
3029         (TestImporter.import_tests):
3030
3031 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
3032
3033         Get rid of the jsc-test-list by moving all not-jsc-capable tests into js/dom
3034         https://bugs.webkit.org/show_bug.cgi?id=121578
3035
3036         Rubber stamped by Geoffrey Garen.
3037
3038         * Scripts/run-layout-jsc:
3039
3040 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
3041
3042         Unreviewed, fix for Ruby 1.8.
3043
3044         * Scripts/run-jsc-stress-tests:
3045
3046 2013-09-17  Filip Pizlo  <fpizlo@apple.com>
3047
3048         run-jsc-stress-tests should make it easier to look at error spew from tests
3049         https://bugs.webkit.org/show_bug.cgi?id=121531
3050
3051         Reviewed by Mark Hahnenberg.
3052         
3053         This makes two changes:
3054         
3055         - The out/err spew from each test is now saved to a .out file in jsc-stress-results.
3056         
3057         - The same spew also goes to the console but is prefixed by the test's name.
3058         
3059         This required some tee and awk hacks, and then some sh hacks to work around the fact
3060         that if you do "(foo | bar) || baz", and foo fails, then baz won't run - the ||
3061         operator will only see a failure of bar failed. So to pass output to tee and awk, I
3062         needed to do weird things.
3063
3064         * Scripts/run-jsc-stress-tests:
3065
3066 2013-09-18  Alexey Proskuryakov  <ap@apple.com>
3067
3068         REGRESSION (r129451): run-safari --no-saved-state is broken
3069         https://bugs.webkit.org/show_bug.cgi?id=121566
3070
3071         Reviewed by Mark Rowe.
3072
3073         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp):
3074         Check arguments, not the newly created empty array. Pass a value that silences warnings.
3075         While at it, removed a check for Snow Leopard.
3076
3077 2013-09-18  Alex Christensen  <achristensen@webkit.org>
3078
3079         Improved WinLauncher's URL handling.
3080         https://bugs.webkit.org/show_bug.cgi?id=121535
3081
3082         Reviewed by Brent Fulgham.
3083
3084         * WinLauncher/WinLauncher.cpp:
3085         (EditProc):
3086         Use INTERNET_MAX_URL_LENGTH instead of our MAX_URL_LENGTH.
3087         (loadURL):
3088         Prepend "http://" to URLs with no scheme.
3089
3090 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
3091
3092         DFG should support Int52 for local variables
3093         https://bugs.webkit.org/show_bug.cgi?id=121064
3094
3095         Reviewed by Oliver Hunt.
3096
3097         * Scripts/run-jsc-stress-tests:
3098
3099 2013-09-18  peavo@outlook.com  <peavo@outlook.com>
3100
3101         [Win] TestWebKitAPI does not compile.
3102         https://bugs.webkit.org/show_bug.cgi?id=121485
3103
3104         Reviewed by Brent Fulgham.
3105
3106         It is no longer possible to inherit from WebCore::BitmapImage, which the test relies on.
3107         Instead, load a bitmap, then destroy the decoded data, which will cause WebCore::frameAtIndex()
3108         to return null, which is the case we want to test.
3109
3110         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
3111         (TestWebKitAPI::TEST):
3112
3113 2013-09-18  Mario Sanchez Prada  <mario.prada@samsung.com>
3114
3115         [ATK] Expose aria-haspopup and aria-sort without the 'aria-' prefix
3116         https://bugs.webkit.org/show_bug.cgi?id=121495
3117
3118         Reviewed by Chris Fleizach.
3119
3120         Adapted DRT and WKTR to deal with the new names for the ATK object
3121         attributes being exposed for 'aria-haspopup' and 'aria-sort'.
3122
3123         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3124         (coreAttributeToAtkAttribute): Updated translation between ATK and DRT.
3125         (AccessibilityUIElement::stringAttributeValue): Ditto.
3126         (AccessibilityUIElement::hasPopup): Ditto.
3127         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3128         (WTR::coreAttributeToAtkAttribute): Updated translation between ATK and WKTR.
3129         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
3130         (WTR::AccessibilityUIElement::hasPopup): Ditto.
3131
3132 2013-09-18  Commit Queue  <commit-queue@webkit.org>
3133
3134         Unreviewed, rolling out r156019 and r156020.
3135         http://trac.webkit.org/changeset/156019
3136         http://trac.webkit.org/changeset/156020
3137         https://bugs.webkit.org/show_bug.cgi?id=121540
3138
3139         Broke tests (Requested by ap on #webkit).
3140
3141         * Scripts/run-jsc-stress-tests:
3142
3143 2013-09-17  Gwang Yoon Hwang  <ryumiel@company100.net>
3144
3145         Unreviewed. Add myself as a committer.
3146
3147         * Scripts/webkitpy/common/config/contributors.json:
3148
3149 2013-09-17  Jae Hyun Park  <jae.park@company100.net>
3150
3151         Unreviewed. Add myself as a committer.
3152
3153         * Scripts/webkitpy/common/config/contributors.json:
3154
3155 2013-09-17  Filip Pizlo  <fpizlo@apple.com>
3156
3157         DFG should support Int52 for local variables
3158         https://bugs.webkit.org/show_bug.cgi?id=121064
3159
3160         Reviewed by Oliver Hunt.
3161
3162         * Scripts/run-jsc-stress-tests:
3163
3164 2013-09-17  Alex Christensen  <alex.christensen@flexsim.com>
3165
3166         Added back and forward buttons to WinLauncher.
3167         https://bugs.webkit.org/show_bug.cgi?id=121212
3168
3169         Reviewed by Brent Fulgham.
3170
3171         * WinLauncher/WinLauncher.cpp:
3172         (resizeSubViews):
3173         Move new back and forward buttons to correct positions before URL bar.
3174         (dllLauncherEntryPoint): 
3175         Store the default button window procedure and replace with my button procedures.
3176         (EditProc): Updated style and renamed from MyEditProc.
3177         (BackButtonProc): Added.
3178         (ForwardButtonProc): Added.
3179
3180 2013-09-17  Michael Saboff  <msaboff@apple.com>
3181
3182         Unreviewed typo fix after r155999
3183
3184         Changed en_US.UTB-8 to en_US.UTF-8
3185
3186         * Scripts/run-javascriptcore-tests:
3187
3188 2013-09-17  Michael Saboff  <msaboff@apple.com>
3189
3190         run-jsc-stress-tests fails with ruby version 2
3191         https://bugs.webkit.org/show_bug.cgi?id=121521
3192
3193         Reviewed by Jessie Berlin.
3194
3195         Explicitly set LANG to en_US.UTB-8 before starting run-jsc-stress-tests.
3196
3197         * Scripts/run-javascriptcore-tests:
3198
3199 2013-09-17  Brent Fulgham  <bfulgham@apple.com>
3200
3201         [Windows] Unreviewed build fix after r155963.
3202
3203         * DumpRenderTree/win/TestRunnerWin.cpp:
3204         (TestRunner::evaluateScriptInIsolatedWorld): Pass nullptr rather than 0.
3205
3206 2013-09-17  Anders Carlsson  <andersca@apple.com>
3207
3208         Fix a typo.
3209
3210         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3211         (TestWebKitAPI::TEST):
3212
3213 2013-09-16  Anders Carlsson  <andersca@apple.com>
3214
3215         HashMap should work with move-only keys
3216         https://bugs.webkit.org/show_bug.cgi?id=121310
3217
3218         Reviewed by Darin Adler.
3219
3220         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3221         (TestWebKitAPI::TEST):
3222         Add test.
3223
3224 2013-09-17  YuTeh Shen  <shenyute@hotmail.com>
3225
3226         BrowserMarshal.h build fail
3227         https://bugs.webkit.org/show_bug.cgi?id=102938
3228
3229         Reviewed by Carlos Garcia Campos.
3230
3231         Fix variable name.
3232
3233         * MiniBrowser/gtk/GNUmakefile.am:
3234
3235 2013-09-16  Brent Fulgham  <bfulgham@apple.com>
3236
3237         [Windows] Clean up WinLauncher by using smart pointers
3238         https://bugs.webkit.org/show_bug.cgi?id=121467
3239
3240         Reviewed by Anders Carlsson.
3241
3242         * WinLauncher/PrintWebUIDelegate.cpp:
3243         (PrintWebUIDelegate::webViewPrintingMarginRect): Switch to smart pointers.
3244         * WinLauncher/WinLauncher.cpp:
3245         (WinLauncherWebHost::updateAddressBar): Use _bstr_t and smart pointers.
3246         (WinLauncherWebHost::didFailProvisionalLoadWithError): Ditto.
3247         (showLastVisitedSites): Smart pointer updates.
3248         (WinLauncherWebHost::didFinishLoadForFrame): Ditto.
3249         (setToDefaultPreferences): Ditto.
3250         (dllLauncherEntryPoint): Ditto.
3251         (PrintView): Ditto.
3252         (LaunchInspector): Ditto.
3253         (NavigateToHistory): Ditto.
3254         (MyEditProc): Ditto.
3255         (loadURL): Ditto.
3256
3257 2013-09-16  Brent Fulgham  <bfulgham@apple.com>
3258
3259         [Windows] Add rudimentary history to WinLauncher.
3260         https://bugs.webkit.org/show_bug.cgi?id=121463
3261
3262         Reviewed by Anders Carlsson.
3263
3264         * WinLauncher/WinLauncher.cpp:
3265         (updateMenuItemForHistoryItem): Added
3266         (showLastVisitedSites): Added
3267         (WinLauncherWebHost::didFinishLoadForFrame): Add history item once
3268         a new page has been visited.
3269         (dllLauncherEntryPoint): Deallocate history on exit.
3270         (NavigateToHistory): Added
3271         (WndProc): Add handler for history entries
3272         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu items to hold
3273         up to 10 history slots.
3274         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link against
3275         Windows utility library to allow use of _bstr_t type.
3276         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Add menu items
3277         to hold up to 10 history slots.
3278         * WinLauncher/stdafx.h: Add <comutil.h> to precompiled headers.
3279
3280 2013-09-16  Gustavo Noronha Silva  <gns@gnome.org>
3281
3282         [GTK] Make symbol export filter more strict, and disable for dev/test builds
3283         https://bugs.webkit.org/show_bug.cgi?id=120586
3284
3285         Reviewed by Martin Robinson.
3286
3287         * GNUmakefile.am: moved GtkLauncher and documentation builds to their own
3288         makefiles, so they can be included unconditionally.
3289         * GtkLauncher/GNUmakefile.am: added.
3290         * Scripts/webkitdirs.pm:
3291         (runAutogenForAutotoolsProjectIfNecessary): always pass --enable-developer-mode
3292         to configure, since we consider builds done through build-webkit to be development
3293         and test builds.
3294         * gtk/GNUmakefile.am: added.
3295         * gtk/common.py: do not use the Scripts directory as a reference to the top path;
3296         it's not necessary and it will not work now that the Scripts directory is not
3297         shipped in the tarball.
3298
3299 2013-09-16  Anders Carlsson  <andersca@apple.com>
3300
3301         WTF::Deque should work with move only types
3302         https://bugs.webkit.org/show_bug.cgi?id=121446
3303
3304         Reviewed by Andreas Kling.
3305
3306         * TestWebKitAPI/Tests/WTF/Deque.cpp:
3307         (TestWebKitAPI::TEST):
3308         Add a test.
3309
3310 2013-09-16  Wojciech Bielawski  <w.bielawski@samsung.com>
3311
3312         [WKTR] WebKitTestRunner's eventSender.contextClick() returns objects without implemented click() method.
3313         https://bugs.webkit.org/show_bug.cgi?id=98410
3314
3315         Reviewed by Darin Adler.
3316
3317         Add implementation of click() method of objects returned by eventSender.contextClick().
3318
3319         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3320         (MenuItemPrivateData):
3321         (WTR::menuItemClickCallback):
3322         (WTR::getMenuItemTitleCallback):
3323         (WTR::staticMenuItemFinalize):
3324         (WTR::getMenuItemClass):
3325         (WTR::EventSendingController::contextClick):
3326
3327 2013-09-15  Zan Dobersek  <zdobersek@igalia.com>
3328
3329         Make the GDB webkit.py script compatible with Python v3
3330         https://bugs.webkit.org/show_bug.cgi?id=121395
3331
3332         Reviewed by Ryosuke Niwa.
3333
3334         GDB fails to load the printing helpers from the webkit.py script if Python v3 is used. To avoid that,
3335         uses of xrange() in the script are replaced with range(), and the print statements are changed into
3336         the print() function invocations.
3337
3338         * gdb/webkit.py:
3339         (guess_string_length):
3340         (ustring_to_string):
3341         (lstring_to_string):
3342         (WTFCStringPrinter.to_string):
3343         (PrintPathToRootCommand.invoke):
3344
3345 2013-09-15  Zan Dobersek  <zdobersek@igalia.com>
3346
3347         [webkitpy] perf profiler attaches to WKTR after the WebProcess was launched
3348         https://bugs.webkit.org/show_bug.cgi?id=119631
3349
3350         Reviewed by Ryosuke Niwa.
3351
3352         The perf profiler is attached to the test runner after the test runner has been launched,
3353         but in the case of WebKitTestRunner, this is done after the WebProcess was spawned by the
3354         UIProcess, meaning that WebProcess operations will not be profiled.
3355
3356         To avoid that, the perf profiler is changed to provide a wrapper command for the test runner.
3357         This is done in the scope of already present support for wrapper scripts (such as valgrind)
3358         that are settable through the --wrapper option. This causes the perf profiler to correctly
3359         continue profiling the WebProcess after it was spawned.
3360
3361         When the profiler is launched, a wait process is launched with the profiler's pid as the
3362         argument. This ensures we can check that the profiler exited normally. If it did not, its
3363         output can be corrupted and can cause problems when that output is examined. The after-exit
3364         report is avoided in that case.
3365
3366         * Scripts/webkitpy/common/system/profiler.py:
3367         (Profiler.wrapper_arguments): The method returns an empty list by default.
3368         (Perf.__init__): Remove unnecessary member variables.
3369         (Perf.attach_to_pid): Launch the wait process with the profiler's pid as the argument.
3370         (Perf.wrapper_arguments): Used instead of attaching the profiler to the profiled process' pid,
3371         the method returns a list of arguments that should be used as a wrapper for the test runner.
3372         The arguments specify the 'perf record' command, with the output file and the instruction to
3373         construct the call graph given as well.
3374         (Perf._first_ten_lines_of_profile): Prettify the output by avoiding the unnecessary trailing
3375         whitespace in the profile lines.
3376         (Perf.profile_after_exit): Kill the profiler process through its pid if the wait process is still
3377         running. If it is running even after that, or if the profiler process produced a non-zero exit
3378         code, the method reports the profiling failure and returns. Otherwise it continues on reporting
3379         the top 10 lines of the profile and how to examine the profile further.
3380         * Scripts/webkitpy/port/driver.py:
3381         (Driver._command_wrapper): The method is now a member of the Driver class, returning the wrapper
3382         as specified by the --wrapper option if given, or the profiler wrapper if the profiler is present,
3383         or an empty list otherwise.
3384         (Driver.cmd_line):
3385         * Scripts/webkitpy/port/driver_unittest.py:
3386         (DriverTest.make_port): Adjusted so mock host or options objects can be specified
3387         for the testing-specific Port object.
3388         (DriverTest._assert_wrapper): Pass a MockOptions object with the wrapper value to the make_port method,
3389         as the Driver._command_wrapper now operates on the option's value directly rather than accepting it through
3390         a parameter.
3391         (DriverTest.test_profiler_as_wrapper): Provide a test case to check the correct profiler wrapper is used
3392         when profiling on the Linux platform with the perf profiler.
3393
3394 2013-09-14  Dan Bernstein  <mitz@apple.com>
3395
3396         [mac] Check For Framework Include Consistency build phase checks the wrong framework
3397         https://bugs.webkit.org/show_bug.cgi?id=121215
3398
3399         Reviewed by Mark Rowe.
3400
3401         * Scripts/check-for-webkit-framework-include-consistency: Replaced hard-coded paths to
3402         WebKit.framework’s Headers and PrivateHeaders directories with the current target’s
3403         public and private headers folder paths. Also tweaked the error messages’ format to make
3404         Xcode recognize them as errors.
3405
3406 2013-09-14  Alberto Garcia  <berto@igalia.com>
3407
3408         [GTK] Fails to compile if the build directory is in a different partition
3409         https://bugs.webkit.org/show_bug.cgi?id=121296
3410
3411         Reviewed by Martin Robinson.
3412
3413         Instead of using os.symlink() to install the gtk-doc templates,
3414         use os.link() first and fall back to os.symlink() if it fails.
3415
3416         * gtk/gtkdoc.py:
3417         (GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):
3418
3419 2013-09-14  Alberto Garcia  <berto@igalia.com>
3420
3421         [GTK] WebKitGTK+ is linking against libxslt in too many places
3422         https://bugs.webkit.org/show_bug.cgi?id=121356
3423
3424         Reviewed by Martin Robinson.
3425
3426         TestWebCore, WebKitTestRunner and MiniBrowser don't use libxslt,
3427         so we don't need to link against it.
3428
3429         * MiniBrowser/gtk/GNUmakefile.am:
3430         * TestWebKitAPI/GNUmakefile.am:
3431         * WebKitTestRunner/GNUmakefile.am:
3432
3433 2013-09-14  Ross Burton  <ross.burton@intel.com>
3434
3435         Uses gtk-doc tools even when --disable-gtk-doc passed
3436         https://bugs.webkit.org/show_bug.cgi?id=91239
3437
3438         Reviewed by Martin Robinson.
3439
3440         Don't run generate-gtkdoc on install if gtk-doc is disabled.
3441
3442         * GNUmakefile.am:
3443
3444 2013-09-14  Alberto Garcia  <berto@igalia.com>
3445
3446         [GTK] Fails to compile if the build directory is in a different partition
3447         https://bugs.webkit.org/show_bug.cgi?id=121296
3448
3449         Reviewed by Carlos Garcia Campos.
3450
3451         Use symlinks instead of hard links to support building on a
3452         different file system.
3453
3454         * gtk/gtkdoc.py:
3455         (GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):
3456
3457 2013-09-13  Darin Adler  <darin@apple.com>
3458
3459         Use a better name than m_invertibleCTM
3460         https://bugs.webkit.org/show_bug.cgi?id=121341
3461
3462         Reviewed by Andreas Kling.
3463
3464         * Scripts/do-webcore-rename: Updated to do this replace as we do.
3465
3466 2013-09-13  Anders Carlsson  <andersca@apple.com>
3467
3468         Pick the correct overload when a const reference is passed to appendSlowCase.
3469         https://bugs.webkit.org/show_bug.cgi?id=121326
3470
3471         Reviewed by Darin Adler.
3472
3473         * TestWebKitAPI/Tests/WTF/Vector.cpp:
3474         (TestWebKitAPI::TEST):
3475
3476 2013-09-13  Darin Adler  <darin@apple.com>
3477
3478         Rename confusingly named "runtimeObject" functions
3479         https://bugs.webkit.org/show_bug.cgi?id=121339
3480
3481         Reviewed by Sam Weinig.
3482
3483         * Scripts/do-webcore-rename: Updated to do this replace as usual.
3484
3485 2013-09-13  Filip Pizlo  <fpizlo@apple.com>
3486
3487         DFG AI assumes that ToThis can never return non-object if it is passed an object, and operationToThis will get the wrong value of isStrictMode() if there's inlining
3488         https://bugs.webkit.org/show_bug.cgi?id=121330
3489
3490         Reviewed by Mark Hahnenberg and Oliver Hunt.
3491
3492         We should run tests even if they don't have expected files yet.
3493         
3494         * Scripts/run-layout-jsc:
3495
3496 2013-09-13  Anders Carlsson  <andersca@apple.com>
3497
3498         Use nullptr instead of 0 in calls to HashMap::add
3499         https://bugs.webkit.org/show_bug.cgi?id=121322
3500
3501         Reviewed by Sam Weinig.
3502
3503         * DumpRenderTree/mac/TestRunnerMac.mm:
3504         (TestRunner::evaluateScriptInIsolatedWorld):
3505         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3506         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
3507
3508 2013-09-13  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3509
3510         [GTK] Move to the new web inspector
3511         https://bugs.webkit.org/show_bug.cgi?id=120647
3512
3513         Reviewed by Carlos Garcia Campos.
3514
3515         * GtkLauncher/main.c:
3516         (main): no longer set WEBKIT_INSPECTOR_PATH.
3517         * MiniBrowser/gtk/main.c:
3518         (main): ditto.
3519         * Scripts/old-run-webkit-tests:
3520         (openDumpTool): ditto.
3521         * Scripts/run-gtk-tests: ditto.
3522         * Scripts/webkitpy/port/gtk.py:
3523         (GtkPort.setup_environ_for_server): ditto.
3524
3525 2013-09-13  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3526
3527         [Qt] REGRESSION(r154444): xss-DENIED test results changed
3528         https://bugs.webkit.org/show_bug.cgi?id=120595
3529
3530         Reviewed by Jocelyn Turcotte.
3531
3532         Avoid overwriting Qt meta properties, which we identify by them being undeletable.
3533
3534         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3535         (DumpRenderTree::initJSObjects):
3536
3537 2013-09-13  Darin Adler  <darin@apple.com>
3538
3539         Give actions in Range class NON_SHOUTING_NAMES
3540         https://bugs.webkit.org/show_bug.cgi?id=121280
3541
3542         Reviewed by Andreas Kling.
3543
3544         * Scripts/do-webcore-rename: Updated to do this replace, keeping with
3545         the tradition of checking in the last one we did, along with other
3546         rename ideas for the future.
3547
3548 2013-09-12  Lucas Forschler  <lforschler@apple.com>
3549
3550         Create short build logs for errors and warnings.
3551         https://bugs.webkit.org/show_bug.cgi?id=120614
3552
3553         Reviewed by Ryosuke Niwa.
3554
3555         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3556             -include StringIO 
3557         (CompileWebKit.createSummary):
3558             -add a createSummary function which will parse out errors and warnings into a concise log file for quick viewing
3559
3560 2013-09-12  Roger Fong  <roger_fong@apple.com>
3561
3562         Update cygwin downloader to search for packages in the right location.
3563
3564         * CygwinDownloader/cygwin-downloader.py:
3565         * CygwinDownloader/cygwin-downloader.zip:
3566
3567 2013-09-12  Anders Carlsson  <andersca@apple.com>
3568
3569         Add rudimentary support for move-only types as values in HashMap
3570         https://bugs.webkit.org/show_bug.cgi?id=121226
3571
3572         Reviewed by Andreas Kling.
3573
3574         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3575         (TestWebKitAPI::TEST):
3576         Add a HashMap<unsigned, MoveOnly> test.
3577
3578 2013-09-12  Gabor Abraham  <abrhm@inf.u-szeged.hu>
3579
3580         Auto GDB backtrace generation for EFL/GTK/Qt bots.
3581         https://bugs.webkit.org/show_bug.cgi?id=119338
3582
3583         Reviewed by Csaba Osztrogonác.
3584
3585         * Scripts/webkitpy/port/efl.py:
3586         (EflPort.check_sys_deps):
3587         (EflPort):
3588         (EflPort._get_crash_log):
3589         * Scripts/webkitpy/port/efl_unittest.py:
3590         (EflPortTest.test_show_results_html_file):
3591         (EflPortTest):
3592         (EflPortTest.test_get_crash_log):
3593         * Scripts/webkitpy/port/gtk.py:
3594         (GtkPort._get_crash_log):
3595         * Scripts/webkitpy/port/gtk_unittest.py:
3596         (GtkPortTest.test_get_crash_log):
3597         * Scripts/webkitpy/port/linux_get_crash_log.py: Added.
3598         (GDBCrashLogGenerator):
3599         (GDBCrashLogGenerator.__init__):
3600         (GDBCrashLogGenerator._get_gdb_output):
3601         (GDBCrashLogGenerator.generate_crash_log):
3602         (GDBCrashLogGenerator.generate_crash_log.match_filename):
3603         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py: Added.
3604         (GDBCrashLogGeneratorTest):
3605         (GDBCrashLogGeneratorTest.test_generate_crash_log):
3606         (_mock_gdb_output):
3607         * Scripts/webkitpy/port/qt.py:
3608         (QtPort.default_child_processes):
3609         (QtPort):
3610         (QtPort._get_crash_log):
3611         * Scripts/webkitpy/port/qt_unittest.py:
3612         (QtPortTest.test_check_sys_deps):
3613         (QtPortTest):
3614         (QtPortTest.test_get_crash_log):
3615
3616 2013-09-12  Peter Gal  <galpeter@inf.u-szeged.hu>
3617
3618         Unreviewed. Moving myself to the commiters list.
3619
3620         * Scripts/webkitpy/common/config/contributors.json:
3621
3622 2013-09-12  ChangSeok Oh  <changseok.oh@collabora.com>
3623
3624         [GTK] Add jhbuild-wayland.modules
3625         https://bugs.webkit.org/show_bug.cgi?id=120455
3626