[ARM] Disable tests that run out of memory
[WebKit-https.git] / Tools / ChangeLog
1 2018-03-06  Dominik Infuehr  <dinfuehr@igalia.com>
2
3         [ARM] Disable tests that run out of memory
4         https://bugs.webkit.org/show_bug.cgi?id=182699
5
6         Reviewed by Žan Doberšek.
7
8         Add run mode to allow running modules.yaml-tests without
9         disabling LLInt for specific tests.
10
11         * Scripts/run-jsc-stress-tests:
12
13 2018-03-05  Yusuke Suzuki  <utatane.tea@gmail.com>
14
15         Fix std::make_unique / new[] using system malloc
16         https://bugs.webkit.org/show_bug.cgi?id=182975
17
18         Reviewed by JF Bastien.
19
20         * TestWebKitAPI/CMakeLists.txt:
21         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
22         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp: Copied from Source/WebKit/Platform/win/LoggingWin.cpp.
23         (TestWebKitAPI::NonTrivialDestructor::NonTrivialDestructor):
24         (TestWebKitAPI::NonTrivialDestructor::~NonTrivialDestructor):
25         (TestWebKitAPI::NonTrivialDestructor::setLog):
26         (TestWebKitAPI::TEST):
27
28 2018-03-05  Myles C. Maxfield  <mmaxfield@apple.com>
29
30         DumpRenderTree build fix
31
32         Unreviewed.
33
34         * DumpRenderTree/mac/LayoutTestHelper.m:
35
36 2018-03-05  Andy Estes  <aestes@apple.com>
37
38         [Mac] Teach WebCore::Pasteboard about file promise drags
39         https://bugs.webkit.org/show_bug.cgi?id=183314
40         <rdar://problem/38105493>
41
42         Reviewed by Darin Adler.
43
44         * DumpRenderTree/DumpRenderTreeFileDraggingSource.h:
45         * DumpRenderTree/DumpRenderTreeFileDraggingSource.m:
46         (-[DumpRenderTreeFileDraggingSource initWithPromisedFileURLs:]):
47         (-[DumpRenderTreeFileDraggingSource dealloc]):
48
49         Taught DumpRenderTreeFileDraggingSource to store the promised file URLs.
50
51         * DumpRenderTree/mac/DumpRenderTree.mm:
52         (runTest):
53
54         Called +[DumpRenderTreeDraggingInfo clearAllFilePromiseReceivers] after running a test.
55
56         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
57         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
58         (-[DumpRenderTreeFilePromiseReceiver initWithPromisedUTIs:]):
59         (-[DumpRenderTreeFilePromiseReceiver fileTypes]):
60         (-[DumpRenderTreeFilePromiseReceiver fileNames]):
61         (-[DumpRenderTreeFilePromiseReceiver dealloc]):
62         (copyFile):
63         (-[DumpRenderTreeFilePromiseReceiver receivePromisedFilesAtDestination:options:operationQueue:reader:]):
64
65         We can't instantiate real NSFilePromiseReceivers in DumpRenderTree. They rely on the
66         pasteboard server to generate unique file URLs, which is incompatible with our swizzled
67         NSPasteboard.
68
69         Instead, create a subclass of NSFilePromiseReceiver that implements its own promise resolution.
70         -receivePromisedFilesAtDestination:... asks its DumpRenderTreeFileDraggingSource for the
71         array of file URLs, then copies each to the destination directory on the specified operation
72         queue. It emulates how NSPasteboard tries to find a unique destination name by appending
73         numbers to the file name.
74
75         All receivers are collected in a global array that is cleared when each test finishes.
76         DumpRenderTreeFilePromiseReceiver will delete the files it copied in -dealloc.
77
78         (+[DumpRenderTreeDraggingInfo clearAllFilePromiseReceivers]):
79         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
80         
81         If NSFilesPromisePboardType is on the pasteboard and classArray contains
82         NSFilePromiseReceiver, construct a DumpRenderTreeFilePromiseReceiver, add it to the array of
83         all file promise receivers, then wrap it in an NSDraggingItem and call block.
84
85         * DumpRenderTree/mac/EventSendingController.mm:
86         (+[EventSendingController isSelectorExcludedFromWebScript:]):
87         (+[EventSendingController webScriptNameForSelector:]):
88         (-[EventSendingController beginDragWithFilePromises:]):
89
90         Implement eventSender.beginDragWithFilePromises() by placing file UTIs on the pasteboard
91         with type NSFilesPromisePboardType, creating a DumpRenderTreeFileDraggingSource with the
92         file URLs, and creating a new DumpRenderTreeDraggingInfo and passing it to
93         -[WebView draggingEntered:].
94
95 2018-03-05  Aakash Jain  <aakash_jain@apple.com>
96
97         [webkitpy] Bugzilla class should use NetworkTransaction for network operations
98         https://bugs.webkit.org/show_bug.cgi?id=183222
99
100         Reviewed by Alexey Proskuryakov.
101
102         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
103         (Bugzilla.open_url): Method which uses NetworkTransaction for opening url.
104         (Bugzilla.fetch_user): Used self.open_url instead of directly calling browser.open().
105         (Bugzilla.add_user_to_groups): Ditto.
106         (Bugzilla._fetch_bug_page): Ditto.
107         (Bugzilla.fetch_attachment_contents): Ditto.
108         (Bugzilla.get_bug_id_for_attachment_id): Ditto.
109         (Bugzilla.authenticate): Ditto.
110         (Bugzilla.add_attachment_to_bug): Ditto.
111         (Bugzilla.add_patch_to_bug): Ditto.
112         (Bugzilla.create_bug): Ditto.
113         (Bugzilla.clear_attachment_flags): Ditto.
114         (Bugzilla.set_flag_on_attachment): Ditto.
115         (Bugzilla.obsolete_attachment): Ditto.
116         (Bugzilla.add_cc_to_bug): Ditto.
117         (Bugzilla.post_comment_to_bug): Ditto.
118         (Bugzilla.close_bug_as_fixed): Ditto.
119         (Bugzilla.reassign_bug): Ditto.
120         (Bugzilla.reopen_bug): Ditto.
121         (Bugzilla._fetch_bug_page_by_url): Deleted, not required anymore.
122         * Scripts/webkitpy/common/net/networktransaction.py:
123         (NetworkTransaction.run): Added a FIXME.
124
125 2018-03-05  Joseph Pecoraro  <pecoraro@apple.com>
126
127         dump-class-layout mishandles duplicates base classes and miscomputes padding
128         https://bugs.webkit.org/show_bug.cgi?id=183311
129
130         Reviewed by Simon Fraser.
131
132         * Scripts/dump-class-layout:
133         (verify_type):
134         (verify_type_recursive):
135         Keep a list of seen (offset, type) that we have output and don't re-output them.
136         The Python types list the base classes as members multiple times as you iterate
137         through the members, so just ignore them if we have seem them already at a
138         specific offset.
139
140 2018-03-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
141
142         [GTK][Wayland] The GTK Wayland bot exits early because of assertions related with libsecret since r221925
143         https://bugs.webkit.org/show_bug.cgi?id=183330
144
145         Reviewed by Michael Catanzaro.
146
147         Add libsecret to the JHBuild and build it only when the system version is
148         less than 0.18.6 (unreleased as of writing this) in order to cherry pick
149         a fix for a bug that causes crashes with layout tests.
150
151         * gtk/jhbuild.modules:
152         * gtk/patches/libsecret-secret-methods-Don-t-unref-NULL-when-search-fails.patch: Added.
153
154 2018-03-05  Claudio Saavedra  <csaavedra@igalia.com>
155
156         [GTK] Implement WTR's PlatformWebView::setWindowIsKey()
157         https://bugs.webkit.org/show_bug.cgi?id=183143
158
159         Reviewed by Carlos Garcia Campos.
160
161         Implement ::setWindowIsKey() by keeping a second window to be
162         presented when the webview's window is to lose its key status.
163
164         * WebKitTestRunner/PlatformWebView.h:
165         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
166         (WTR::PlatformWebView::PlatformWebView):
167         (WTR::PlatformWebView::~PlatformWebView):
168         (WTR::PlatformWebView::setWindowIsKey):
169
170 2018-03-05  Yusuke Suzuki  <utatane.tea@gmail.com>
171
172         Unreviewed, attempt to fix Apple port build
173
174         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
175
176 2018-03-05  Yusuke Suzuki  <utatane.tea@gmail.com>
177
178         Unreviewed, attempt to fix WPE build
179
180         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
181         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
182         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:
183         (WTR::PlatformWebView::windowSnapshotImage):
184         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
185         (WTR::TestController::platformRunUntil):
186
187 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
188
189         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
190         https://bugs.webkit.org/show_bug.cgi?id=183312
191
192         Reviewed by Mark Lam.
193
194         Remove wtf/CurrentTime.h include pragma.
195
196         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
197         * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSWithinNPP_New.cpp:
198         * DumpRenderTree/TestNetscapePlugIn/Tests/InvokeDestroysPluginWithinNPP_New.cpp:
199         * DumpRenderTree/TestNetscapePlugIn/Tests/SlowNPPNew.cpp:
200         * TestWebKitAPI/Tests/WTF/Condition.cpp:
201         * TestWebKitAPI/Tests/WTF/Signals.cpp:
202         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
203         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
204         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
205         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
206         * TestWebKitAPI/jsconly/PlatformUtilitiesJSCOnly.cpp:
207         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
208
209 2018-03-04  Tim Horton  <timothy_horton@apple.com>
210
211         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
212         https://bugs.webkit.org/show_bug.cgi?id=183283
213         <rdar://problem/38062148>
214
215         Reviewed by Sam Weinig.
216
217         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
218
219 2018-03-02  Chris Dumez  <cdumez@apple.com>
220
221         Converting a load to a download does not work with async policy delegates
222         https://bugs.webkit.org/show_bug.cgi?id=183254
223         <rdar://problem/38035334>
224
225         Reviewed by Youenn Fablet.
226
227         Add layout test infrastructure for responding to the decidePolicyForNavigationResponse
228         delegate asynchronously.
229
230         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
231         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
232         (WTR::InjectedBundlePage::decidePolicyForResponse):
233         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
234         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
235         * WebKitTestRunner/InjectedBundle/TestRunner.h:
236         (WTR::TestRunner::shouldDecideResponsePolicyAfterDelay const):
237         * WebKitTestRunner/TestController.cpp:
238         (WTR::TestController::resetStateToConsistentValues):
239         (WTR::TestController::decidePolicyForNavigationResponse):
240         * WebKitTestRunner/TestController.h:
241         (WTR::TestController::setShouldDecideResponsePolicyAfterDelay):
242         * WebKitTestRunner/TestInvocation.cpp:
243         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
244
245 2018-03-01  Youenn Fablet  <youenn@apple.com>
246
247         Add API test to validate setting of service worker and cache storage directories
248         https://bugs.webkit.org/show_bug.cgi?id=182543
249
250         Reviewed by Chris Dumez.
251
252         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
253
254 2018-03-01  Ross Kirsling  <ross.kirsling@sony.com>
255
256         [Win][DRT] Implement setSpatialNavigationEnabled.
257         https://bugs.webkit.org/show_bug.cgi?id=183166
258
259         Reviewed by Per Arne Vollan.
260
261         * DumpRenderTree/TestRunner.cpp:
262         (setSpatialNavigationEnabledCallback):
263         * DumpRenderTree/win/DumpRenderTree.cpp:
264         (resetWebPreferencesToConsistentValues):
265         * DumpRenderTree/win/TestRunnerWin.cpp:
266         (TestRunner::setSpatialNavigationEnabled):
267
268 2018-03-01  Basuke Suzuki  <Basuke.Suzuki@sony.com>
269
270         [webkitpy] Use shell=False to launch apache http server.
271         https://bugs.webkit.org/show_bug.cgi?id=183191
272
273         Reviewed by Aakash Jain.
274
275         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
276         (LayoutTestApacheHttpd.__init__):
277         (LayoutTestApacheHttpd._run):
278
279 2018-03-01  Chris Dumez  <cdumez@apple.com>
280
281         Unreviewed, update WebKit.CustomHeaderFields API test after r229133.
282
283         We no longer do policy checks for 'about:blank'.
284
285         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
286         (-[CustomHeaderFieldsDelegate webView:startURLSchemeTask:]):
287         (TEST):
288
289 2018-02-28  Jonathan Bedard  <jbedard@apple.com>
290
291         [webkitpy] Remove concept of 'future' versions (Follow-up fix 2)
292         https://bugs.webkit.org/show_bug.cgi?id=183184
293         <rdar://problem/37958594>
294
295         Reviewed by Aakash Jain.
296
297         Unlisted Apple versions can't run webkitpy tests because they don't
298         have specified port names.
299
300         * Scripts/webkitpy/port/apple.py:
301         (ApplePort.determine_full_port_name): Return valid port name for unnamed
302         versions.
303         * Scripts/webkitpy/port/base.py:
304         (Port.version_name): Check both public and internal version mapping
305         when returning a version name.
306         * Scripts/webkitpy/port/mac.py:
307         (MacPort.__init__): If no os version is defined, use the current version.
308
309 2018-02-28  John Wilander  <wilander@apple.com>
310
311         Add a second tier of prevalence to facilitate telemetry on very prevalent domains
312         https://bugs.webkit.org/show_bug.cgi?id=183218
313         <rdar://problem/37992388>
314
315         Reviewed by Brent Fulgham.
316
317         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
318             Added two new testRunner functions:
319             - setStatisticsVeryPrevalentResource()
320             - isStatisticsVeryPrevalentResource()
321         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
322         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
323         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
324         * WebKitTestRunner/InjectedBundle/TestRunner.h:
325         * WebKitTestRunner/TestController.cpp:
326         (WTR::TestController::setStatisticsVeryPrevalentResource):
327         (WTR::TestController::isStatisticsVeryPrevalentResource):
328         * WebKitTestRunner/TestController.h:
329         * WebKitTestRunner/TestInvocation.cpp:
330         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
331
332 2018-02-28  Jonathan Bedard  <jbedard@apple.com>
333
334         [webkitpy] Remove concept of 'future' versions (Follow-up fix)
335         https://bugs.webkit.org/show_bug.cgi?id=183184
336         <rdar://problem/37958594>
337
338         Reviewed by David Kilzer.
339
340         The factory also relies on future in a non-obvious way.
341
342         * Scripts/webkitpy/common/system/platforminfo.py:
343         (PlatformInfo.os_version_name): Check both public and internal version mapping
344         when returning a version name.
345         * Scripts/webkitpy/common/system/platforminfo_mock.py:
346         (MockPlatformInfo.os_version_name): Ditto.
347
348 2018-02-28  Zan Dobersek  <zdobersek@igalia.com>
349
350         Unreviewed WPE fixup after r229080.
351
352         Add empty definitions for two AccessibilityUIElement methods,
353         avoiding undefined symbols in the WKTR injected bundle.
354
355         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
356         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRange):
357         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions):
358
359 2018-02-27  Jonathan Bedard  <jbedard@apple.com>
360
361         Remove concept of 'future'
362         https://bugs.webkit.org/show_bug.cgi?id=183184
363         <rdar://problem/37958594>
364
365         Reviewed by Aakash Jain.
366
367         Remove concept of 'future' from expectations and instead
368         use a system of inheritance centered around the current version
369         of an OS for Mac and iOS.
370
371         Inheritance works like so:
372
373         | ....
374         V Future
375         > High Sierra (mac)
376         ^ mac-sierra
377         | mac-elcapitan
378         | ....
379
380         This does not change expectation inheritance for any currently running
381         configurations, it generalizes the logic already used.
382
383         * Scripts/webkitpy/common/version_name_map.py:
384         (VersionNameMap.__init__): Remove all future versions.
385         (VersionNameMap.mapping_for_platform): Return empty dicts instead of
386         asserting.
387         * Scripts/webkitpy/port/apple.py:
388         (ApplePort):
389         (ApplePort._allowed_versions): Return all available versions.
390         (ApplePort._generate_all_test_configurations): Instead of picking from a set
391         of allowed versions, assume that every specified version is allowed.
392         (ApplePort._port_name_with_version): Deleted.
393         * Scripts/webkitpy/port/darwin.py: Add CURRENT_VERSION overridden by subclasses.
394         (DarwinPort):
395         * Scripts/webkitpy/port/ios.py:
396         (IOSPort):
397         (IOSPort.default_baseline_search_path): Use system of inheritance centered around
398         the current version.
399         * Scripts/webkitpy/port/mac.py:
400         (MacPort):
401         (MacPort.__init__): Use current version by default.
402         (MacPort.default_baseline_search_path): Use system of inheritance centered around
403         the current version.
404         (MacPort.configuration_specifier_macros): Use the same set of version names
405         supported in default_baseline_search_path.
406         * Scripts/webkitpy/port/mac_unittest.py:
407         (MacTest.test_versions): Remove 'future' tests.
408
409 2018-02-27  Michael Catanzaro  <mcatanzaro@igalia.com>
410
411         Unreviewed GTK test gardening
412
413         * TestWebKitAPI/glib/TestExpectations.json:
414
415 2018-02-27  Doug Russell  <doug@getitdownonpaper.com>
416
417         AX: Spell check and style attributes should be optional when fetching attributed string
418         https://bugs.webkit.org/show_bug.cgi?id=160744
419
420         Reviewed by Chris Fleizach.
421
422         The overhead of fetching a spell checked attributed string via AX API is substantial. 
423         In some cases on the order of 7/8 of the total time spent fetching the string.
424
425         This change introduces the new attribute AXAttributedStringForTextMarkerRangeWithOptions which accepts an NSDictionary as it's parameter with keys "AXTextMarkerRange" (AXTextMarkerRangeRef) and "AXSpellCheck" (NSNumber(BOOL)).
426
427         AXAttributedStringForTextMarkerRange will remain unchanged.
428
429         * DumpRenderTree/AccessibilityUIElement.cpp:
430         (attributedStringForTextMarkerRangeCallback):
431         (attributedStringForTextMarkerRangeWithOptionsCallback):
432         (AccessibilityUIElement::attributedStringForTextMarkerRange):
433         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions):
434         (AccessibilityUIElement::getJSClass):
435         * DumpRenderTree/AccessibilityUIElement.h:
436         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
437         (AccessibilityUIElement::attributedStringForTextMarkerRange):
438         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions):
439         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
440         (createJSStringRef):
441         (AccessibilityUIElement::attributedStringForTextMarkerRange):
442         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions):
443         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
444         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
445         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
446         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRange):
447         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions):
448         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
449         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRange):
450         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions):
451         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
452         (WTR::createJSStringRef):
453         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRange):
454         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions):
455
456 2018-02-27  Daniel Bates  <dabates@apple.com>
457
458         Standardize terminology for marked text
459         https://bugs.webkit.org/show_bug.cgi?id=180999
460
461         Reviewed by Zalan Bujtas.
462
463         The name MarkerSubrange is a misnomer for a data structure that associates a text subrange with a type
464         and optional document marker. In particular, a MarkerSubrange may not always correspond to a document
465         marker. For instance, selected text is represented using a MarkerSubrange that does not have a
466         corresponding document marker. Let's standardize on the phrase "marked text" as the canonical way to
467         describe these tagged text subranges.
468
469         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
470         * TestWebKitAPI/Tests/WebCore/MarkedText.cpp: Added.
471         (WebCore::operator<<):
472         (TestWebKitAPI::TEST):
473         * TestWebKitAPI/Tests/WebCore/MarkerSubrange.cpp: Removed.
474
475 2018-02-27  Aakash Jain  <aakash_jain@apple.com>
476
477         webkitpy Bugzilla transactions should retry on URLError
478         https://bugs.webkit.org/show_bug.cgi?id=183156
479
480         Reviewed by Alexey Proskuryakov.
481
482         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
483         (Bugzilla): Use NetworkTransaction.
484         (Bugzilla._fetch_bug_page_by_url):
485         (Bugzilla.bug_id_for_attachment_id):
486         (Bugzilla.get_bug_id_for_attachment_id):
487
488 2018-02-27  Wenson Hsieh  <wenson_hsieh@apple.com>
489
490         [Extra zoom mode] Implement additional SPI for adjusting viewport shrink-to-fit behavior
491         https://bugs.webkit.org/show_bug.cgi?id=183100
492         <rdar://problem/37840987>
493
494         Reviewed by Tim Horton.
495
496         Add API tests that exercise -_setMinimumAllowedLayoutWidth: and -_setForceHorizontalViewportShrinkToFit:. See
497         WebKit ChangeLog for more detail.
498
499         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
500         * TestWebKitAPI/Tests/ios/ViewportSizingTests.mm: Added.
501         (TestWebKitAPI::while):
502         (viewportTestPageMarkup):
503         (TestWebKitAPI::TEST):
504
505 2018-02-27  Yusuke Suzuki  <utatane.tea@gmail.com>
506
507         Unreviewed, skip FTL tests if FTL is disabled
508         https://bugs.webkit.org/show_bug.cgi?id=183071
509
510         * Scripts/run-jsc-stress-tests:
511
512 2018-02-26  Don Olmstead  <don.olmstead@sony.com>
513
514         Fix WebCore includes within WebKitLegacy
515         https://bugs.webkit.org/show_bug.cgi?id=183147
516
517         Reviewed by Tim Horton.
518
519         * MiniBrowser/win/ResourceLoadDelegate.cpp:
520
521 2018-02-26  Yousuke Kimoto  <yousuke.kimoto@sony.com>
522
523         [WinCairo] WebKit2_C.h should be included for TestWebKit
524         https://bugs.webkit.org/show_bug.cgi?id=182682
525
526         Reviewed by Yusuke Suzuki.
527
528         * TestWebKitAPI/config.h:
529
530 2018-02-25  Fujii Hironori  <Hironori.Fujii@sony.com>
531
532         [WK2] http/tests/navigation/new-window-redirect-history.html crashes
533         https://bugs.webkit.org/show_bug.cgi?id=127683
534
535         Reviewed by Dan Bernstein.
536
537         m_previousTestBackForwardListItem was null for the new window.
538         m_previousTestBackForwardListItem is initialized only for the main
539         window in InjectedBundlePage::prepare.
540
541         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
542         (WTR::InjectedBundlePage::dumpBackForwardList):
543         Do null-check of m_previousTestBackForwardListItem.
544
545 2018-02-25  Alexey Proskuryakov  <ap@apple.com>
546
547         Various crashes in WebKitTestRunner, especially when system is under heavy load
548         https://bugs.webkit.org/show_bug.cgi?id=183109
549
550         Reviewed by Tim Horton.
551
552         WebKitTestRunner had many places where it sent messages to WebContent with a timeout,
553         but it didn't handle the timeout when it did occur. Nearly all of those would result
554         in logic errors and failing tests, and most would even result in stack corruption,
555         as the response handler modified local variables.
556
557         There is only one timeout scenario that we actually mean to handle in WKTR. That's
558         when a test freezes after it is done (e.g. an infinite loop in beforeunload) - we don't
559         want to blame the next test for freezing, so we silently relaunch WebContent.
560         Everything else is cargo cult code that never worked.
561
562         This patch addresses the crashes, and actually makes tests pass a lot more on an
563         overloaded system.
564
565         * WebKitTestRunner/TestController.cpp:
566         (WTR::TestController::resetStateToConsistentValues): Moved m_doneResetting assignment
567         to where it's actually needed, for clarity.
568         (WTR::TestController::reattachPageToWebProcess): This function used to always hit
569         and ignore message timeout, as m_doneResetting is only updated by navigation callback
570         when the state is Resetting. This change makes it faster.
571         (WTR::TestController::platformResetStateToConsistentValues): Style fix.
572         (WTR::TestController::clearServiceWorkerRegistrations): Timing out here wasn't
573         handled in a meaningful manner, and would even corrupt the stack.
574         (WTR::TestController::clearDOMCache): Ditto.
575         (WTR::TestController::clearDOMCaches): Ditto.
576         (WTR::TestController::hasDOMCache): Ditto.
577         (WTR::TestController::domCacheSize): Ditto.
578         (WTR::TestController::isStatisticsPrevalentResource): Ditto.
579         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder): Ditto.
580         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo): Ditto.
581         (WTR::TestController::isStatisticsHasHadUserInteraction): Ditto.
582         (WTR::TestController::isStatisticsGrandfathered): Ditto.
583         (WTR::TestController::statisticsUpdateCookiePartitioning): Ditto.
584         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost): Ditto.
585         (WTR::TestController::statisticsClearInMemoryAndPersistentStore): Ditto.
586         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours): Ditto.
587         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval): Ditto.
588
589         * WebKitTestRunner/TestInvocation.cpp:
590         (WTR::TestInvocation::shortTimeout const): Made shortTimeout shorter (on a hunch).
591         (WTR::TestInvocation::invoke): Removed a timeout waiting for initial response. There
592         is never a logical reason for such a timeout, as we always have a new or responsive
593         WebContent process here.
594         (WTR::TestInvocation::dumpResults): Removed another timeout that we don't know how to
595         properly handle.
596         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Removed assignment to
597         m_errorMessage, which had no effect in this context.
598
599         * WebKitTestRunner/TestInvocation.h: Removed no longer used code.
600
601         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
602         (WTR::TestController::cocoaResetStateToConsistentValues): Use a named constant for
603         no timeout.
604         
605         * WebKitTestRunner/ios/TestControllerIOS.mm:
606         (WTR::TestController::platformConfigureViewForTest): Removed a useless timeout.
607         Not sure if timing out here would corrupt the stack or not, but there is no reason
608         to impose arbitrary limits on individual steps of a test.
609
610         * WebKitTestRunner/mac/TestControllerMac.mm:
611         (WTR::TestController::platformConfigureViewForTest): Use a named constant for
612         no timeout.
613
614 2018-02-25  Ali Juma  <ajuma@chromium.org>
615
616         Unreviewed. Change my status to committer.
617
618         * Scripts/webkitpy/common/config/contributors.json:
619
620 2018-02-25  Chris Dumez  <cdumez@apple.com>
621
622         Service workers do not work well inside Web.app
623         https://bugs.webkit.org/show_bug.cgi?id=183105
624         <rdar://problem/37864140>
625
626         Reviewed by Youenn Fablet.
627
628         Add API test coverage.
629
630         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
631
632 2018-02-25  Aakash Jain  <aakash_jain@apple.com>
633
634         [build.webkit.org] unit-tests fail if buildbot 0.8.6p1 is not installed locally
635         https://bugs.webkit.org/show_bug.cgi?id=183103
636
637         Reviewed by Alexey Proskuryakov.
638
639         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Removed extra imports.
640
641 2018-02-24  Wenson Hsieh  <wenson_hsieh@apple.com>
642
643         Unreviewed, fix the TestWebKitAPI build after r228825.
644
645         I removed a `>= iOS 11` check in r228825, but forgot that this was also neeed to guard against tvOS and watchOS
646         builds. This fixes the build by restoring the compile-time guard and also makes it explicit for these platforms.
647
648         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
649
650 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
651
652         Remove currentTime() / currentTimeMS()
653         https://bugs.webkit.org/show_bug.cgi?id=183052
654
655         Reviewed by Mark Lam.
656
657         * DumpRenderTree/TestRunner.cpp:
658         (preciseTimeCallback):
659         * DumpRenderTree/mac/TestRunnerMac.mm:
660         (TestRunner::setMockGeolocationPosition):
661         * TestWebKitAPI/Tests/WTF/Condition.cpp:
662         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
663         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
664         * WebKitTestRunner/GeolocationProviderMock.cpp:
665         (WTR::GeolocationProviderMock::setPosition):
666         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
667         (WTR::TestRunner::preciseTime):
668
669 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
670
671         Remove sleep(double) and sleepMS(double) interfaces
672         https://bugs.webkit.org/show_bug.cgi?id=183038
673
674         Reviewed by Mark Lam.
675
676         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
677         (PluginTest::indicateTestFailure):
678         * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSWithinNPP_New.cpp:
679         (EvaluteJSWithinNPP_New::NPP_New):
680         * DumpRenderTree/TestNetscapePlugIn/Tests/InvokeDestroysPluginWithinNPP_New.cpp:
681         (InvokeDestroysPluginWithinNPP_New::NPP_New):
682         * DumpRenderTree/TestNetscapePlugIn/Tests/SlowNPPNew.cpp:
683         * TestWebKitAPI/Tests/WTF/Signals.cpp:
684         (TEST):
685         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
686         (TestWebKitAPI::testThreadGroup):
687         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
688         (TestWebKitAPI::TEST):
689         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
690         (TestWebKitAPI::TEST):
691         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
692         (TestWebKitAPI::TEST):
693         * TestWebKitAPI/jsconly/PlatformUtilitiesJSCOnly.cpp:
694         (TestWebKitAPI::Util::sleep):
695
696 2018-02-21  Don Olmstead  <don.olmstead@sony.com>
697
698         [CMake][Win] Use cmakeconfig.h rather than config.h and Platform.h
699         https://bugs.webkit.org/show_bug.cgi?id=182883
700
701         Reviewed by Per Arne Vollan.
702
703         * DumpRenderTree/config.h:
704         * TestWebKitAPI/config.h:
705
706 2018-02-21  Michael Catanzaro  <mcatanzaro@igalia.com>
707
708         [GTK] Unsafe g_setenv use in MiniBrowser main
709         https://bugs.webkit.org/show_bug.cgi?id=182978
710
711         Reviewed by Carlos Garcia Campos.
712
713         setenv (and g_setenv) will randomly crash if called too late.
714
715         * MiniBrowser/gtk/main.c:
716         (main):
717
718 2018-02-21  Aakash Jain  <aakash_jain@apple.com>
719
720         webkitpy NetworkTransaction should retry on URLError
721         https://bugs.webkit.org/show_bug.cgi?id=182987
722
723         Reviewed by Alexey Proskuryakov.
724
725         * Scripts/webkitpy/common/net/networktransaction.py:
726         (NetworkTransaction.run): Retry on urllib2.URLError.
727
728 2018-02-21  Ms2ger  <Ms2ger@igalia.com>
729
730         [WTR][WPE] Correct the process names in TestController.
731         https://bugs.webkit.org/show_bug.cgi?id=178700
732
733         Reviewed by Michael Catanzaro.
734
735         Similar to r228731 for GTK.
736
737         * Scripts/webkitpy/port/wpe.py:
738         (WPEPort._get_crash_log): removed the code to convert WebProcess name.
739         * WebKitTestRunner/TestController.cpp: return the correct process names for WPE.
740         (WTR::TestController::webProcessName):
741         (WTR::TestController::networkProcessName):
742         (WTR::TestController::databaseProcessName):
743
744 2018-02-21  Ms2ger  <Ms2ger@igalia.com>
745
746         [ATK] Remove attributeSet variable from AccessibilityUIElement::attributedStringForRange().
747         https://bugs.webkit.org/show_bug.cgi?id=183000
748
749         Reviewed by Joanmarie Diggs.
750
751         It is never initialized, but is passed to atk_attribute_set_free.
752         This caused a crash in accessibility/content-editable-as-textarea.html on the debug bots.
753
754         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
755         (WTR::AccessibilityUIElement::attributedStringForRange):
756
757 2018-02-21  Myles C. Maxfield  <mmaxfield@apple.com>
758
759         [Cocoa] Make system-ui obey the user-installed-font policy
760         https://bugs.webkit.org/show_bug.cgi?id=182860
761         <rdar://problem/36158249>
762
763         Reviewed by Antti Koivisto.
764
765         Create a font, FakeHelvetica-ArmenianCharacter.ttf, which supports a particular Armenian
766         character which isn't isn't supported by any other font on the system.
767
768         * WebKitTestRunner/FakeHelvetica-ArmenianCharacter.ttf:
769         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
770
771 2018-02-20  Timothy Horton  <timothy_horton@apple.com>
772
773         Try to fix the 32-bit build after r228857
774
775         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
776         (WTR::UIScriptController::firstResponderSuppressionForWebView):
777
778 2018-02-20  Nan Wang  <n_wang@apple.com>
779
780         AX: Keyboard focus not following VoiceOver cursor into web content or within web content.
781         https://bugs.webkit.org/show_bug.cgi?id=182752
782         <rdar://problem/37518233>
783
784         Reviewed by Ryosuke Niwa.
785
786         * DumpRenderTree/mac/UIScriptControllerMac.mm:
787         (WTR::UIScriptController::firstResponderSuppressionForWebView):
788         (WTR::UIScriptController::makeWindowContentViewFirstResponder):
789         (WTR::UIScriptController::isWindowContentViewFirstResponder const):
790         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
791         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
792         (WTR::UIScriptController::firstResponderSuppressionForWebView):
793         (WTR::UIScriptController::makeWindowContentViewFirstResponder):
794         (WTR::UIScriptController::isWindowContentViewFirstResponder const):
795         * TestRunnerShared/UIScriptContext/UIScriptController.h:
796         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
797         (WTR::UIScriptController::firstResponderSuppressionForWebView):
798         (WTR::UIScriptController::makeWindowContentViewFirstResponder):
799         (WTR::UIScriptController::isWindowContentViewFirstResponder const):
800
801 2018-02-20  Fujii Hironori  <Hironori.Fujii@sony.com>
802
803         [GTK] jhbuild: Remove gtk-doc
804         https://bugs.webkit.org/show_bug.cgi?id=182956
805
806         Reviewed by Michael Catanzaro.
807
808         jhbuild doesn't need to build gtk-doc because major LTS Linux
809         distributions have gtk-doc v1.25, and
810         Tools/gtk/install-dependencies installs gtk-doc.
811
812         * gtk/jhbuild.modules: Removed gtk-doc.
813
814 2018-02-20  Tim Horton  <timothy_horton@apple.com>
815
816         Introduce HAVE(IOSURFACE_ACCELERATOR)
817         https://bugs.webkit.org/show_bug.cgi?id=182955
818         <rdar://problem/37699510>
819
820         Reviewed by Sam Weinig.
821
822         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
823         (createBitmapContextFromWebView):
824         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
825         (WTR::PlatformWebView::windowSnapshotImage):
826
827 2018-02-20  Chris Dumez  <cdumez@apple.com>
828
829         Provisional load may get committed before receiving the decidePolicyForNavigationResponse response
830         https://bugs.webkit.org/show_bug.cgi?id=182720
831         <rdar://problem/37515204>
832
833         Reviewed by Alex Christensen.
834
835         Add API test coverage.
836
837         * TestWebKitAPI/Tests/WebKitCocoa/AsyncPolicyForNavigationResponse.mm:
838         (-[TestAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
839         (TestWebKitAPI::TEST):
840
841 2018-02-20  Nan Wang  <n_wang@apple.com>
842
843         AX: AOM: Dispatch accessibleclick event
844         https://bugs.webkit.org/show_bug.cgi?id=180898
845         <rdar://problem/36086710>
846
847         Reviewed by Ryosuke Niwa.
848
849         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
850         (WTR::AccessibilityUIElement::syncPress):
851         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
852         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
853         (WTR::AccessibilityUIElement::syncPress):
854
855 2018-02-20  Wenson Hsieh  <wenson_hsieh@apple.com>
856
857         [iOS 11.3 Beta] Can't copy a URL from Safari and paste it into the Gmail app
858         https://bugs.webkit.org/show_bug.cgi?id=182952
859         <rdar://problem/37636190>
860
861         Reviewed by Tim Horton.
862
863         Adds a new iOS copy/paste test that copies an anchor element via action sheet, and checks that upon pasting,
864         both "text/plain" and "text/uri-list" are provided. Additionally tweaks an existing iOS drag and drop test to
865         check for the same behavior.
866
867         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
868         (TestWebKitAPI::TEST):
869         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
870         (TestWebKitAPI::TEST):
871
872 2018-02-20  Philippe Normand  <pnormand@igalia.com>
873
874         [GStreamer][MiniBrowser] Honor GStreamer command line parameters in MiniBrowser
875         https://bugs.webkit.org/show_bug.cgi?id=173655
876
877         Reviewed by Xabier Rodriguez-Calvar.
878
879         The FIXME in GStreamerUtilities.cpp asks to pass the command line
880         parameters to the GStreamer initialization function.
881
882         Based on initial patch by: Vanessa Chipirrás Navalón  <vchipirras@igalia.com>
883
884         * MiniBrowser/gtk/main.c:
885         (main): Add the group containing the Gstreamer options that the console displays.
886
887 2018-02-19  Fujii Hironori  <Hironori.Fujii@sony.com>
888
889         [WTR][GTK] crash log backtrace doesn't show symbol names for DatabaseProcess and NetworkProcess
890         https://bugs.webkit.org/show_bug.cgi?id=182953
891
892         Reviewed by Carlos Garcia Campos.
893
894         * Scripts/webkitpy/port/gtk.py:
895         (GtkPort._get_crash_log): Removed the code to convert WebProcess name.
896         * WebKitTestRunner/TestController.cpp:
897         (WTR::TestController::webProcessName): Return the correct program name for GTK+ port.
898         (WTR::TestController::networkProcessName): Ditto.
899         (WTR::TestController::databaseProcessName): Ditto.
900
901 2018-02-19  Ryan Haddad  <ryanhaddad@apple.com>
902
903         Unreviewed, rolling out r228696.
904
905         The API test added with this change is timing out on macOS.
906
907         Reverted changeset:
908
909         "Null pointer dereference in
910         WebPageProxy::urlSchemeHandlerForScheme()"
911         https://bugs.webkit.org/show_bug.cgi?id=182905
912         https://trac.webkit.org/changeset/228696
913
914 2018-02-16  Ryosuke Niwa  <rniwa@webkit.org>
915
916         Add an entitlement check for service worker on iOS
917         https://bugs.webkit.org/show_bug.cgi?id=182865
918         <rdar://problem/37505903>
919
920         Reviewed by Brady Eidson.
921
922         Added the service worker entitlements to WebKitTestRunner and TestWebKitAPI on iOS.
923
924         * TestWebKitAPI/Configurations/TestWebKitAPI-iOS.entitlements:
925         * WebKitTestRunner/Configurations/WebKitTestRunnerApp-iOS.entitlements:
926         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
927         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
928
929 2018-02-16  Youenn Fablet  <youenn@apple.com>
930
931         Allow specifying which plug-ins are supported
932         https://bugs.webkit.org/show_bug.cgi?id=182748
933
934         Reviewed by Chris Dumez.
935
936         Add support for a test runner API to specificy supported plug-ins.
937
938         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
939         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
940         (WTR::TestRunner::setPluginsAsUnsupported):
941         * WebKitTestRunner/InjectedBundle/TestRunner.h:
942         * WebKitTestRunner/TestController.cpp:
943         (WTR::TestController::resetStateToConsistentValues):
944         (WTR::TestController::setPluginsAsUnsupported):
945         * WebKitTestRunner/TestController.h:
946         * WebKitTestRunner/TestInvocation.cpp:
947         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
948
949 2018-02-16  Per Arne Vollan  <pvollan@apple.com>
950
951         Implement stopping of run loop in the WebContent process when using NSRunLoop.
952         https://bugs.webkit.org/show_bug.cgi?id=182499
953         <rdar://problem/37247424>
954
955         Reviewed by Brent Fulgham.
956
957         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
958         * TestWebKitAPI/Tests/WebKitCocoa/WebProcessTerminate.mm: Added.
959         (TEST):
960
961 2018-02-15  Alexey Proskuryakov  <ap@apple.com>
962
963         Speed up dSYM generation on build.webkit.org with -gline-tables-only
964         https://bugs.webkit.org/show_bug.cgi?id=182841
965         rdar://problem/34579649
966
967         Reviewed by Aakash Jain.
968
969         Build speed and binary size improvements are so substantial that I'm willing to make
970         CI builds less suitable for debugging, which is not a common scenario anyway.
971         Crash logs will still have line numbers in them.
972
973         * BuildSlaveSupport/build.webkit.org-config/steps.py: (CompileWebKit.start):
974
975 2018-02-15  Don Olmstead  <don.olmstead@sony.com>
976
977         WebCore headers should not be included relatively within dependent projects
978         https://bugs.webkit.org/show_bug.cgi?id=182805
979
980         Reviewed by Chris Dumez.
981
982         * TestWebKitAPI/win/TestWebCoreStubs.cpp:
983         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
984         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityControllerWPE.cpp:
985         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
986         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
987         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
988
989 2018-02-15  Tomas Popela  <tpopela@redhat.com>
990
991         run-jsc-stress-tests - skip a test if any of the run commands evals to skip
992         https://bugs.webkit.org/show_bug.cgi?id=182729
993
994         If multiple run commands are specified and one of them evals to skip,
995         then the test is not skipped, because the run is scheduled while
996         evaluating other commands.
997
998         Remember if the test is going to be skipped - if yes, just stop
999         evaluating the other run commands.
1000
1001         Reviewed by Saam Barati.
1002
1003         * Scripts/run-jsc-stress-tests:
1004
1005 2018-02-14  Charlie Turner  <cturner@igalia.com>
1006
1007         Get Garden-O-Matic running again.
1008         https://bugs.webkit.org/show_bug.cgi?id=179089
1009
1010         Reviewed by Carlos Alberto Lopez Perez.
1011
1012         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js:
1013         (parseCommitData): Author field is not always spelled 'author' these days.
1014         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1015         No longer have a 32-bit builder.
1016         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js:
1017         (ui.perf.View.base.init): createElement has a required parameter these days.
1018         * Scripts/webkitpy/tool/commands/gardenomatic.py:
1019         (GardenOMatic): Override use_globs so that platform lookup in config.js works.
1020
1021 2018-02-14  Don Olmstead  <don.olmstead@sony.com>
1022
1023         Remove unused ForwardingHeaders directories from Tools
1024         https://bugs.webkit.org/show_bug.cgi?id=182813
1025
1026         Reviewed by Konstantin Tokarev.
1027
1028         * DumpRenderTree/ForwardingHeaders/runtime/ArrayBufferView.h: Removed.
1029         * DumpRenderTree/ForwardingHeaders/runtime/JSArrayBufferView.h: Removed.
1030         * DumpRenderTree/ForwardingHeaders/runtime/JSExportMacros.h: Removed.
1031         * DumpRenderTree/ForwardingHeaders/runtime/TypedArrayInlines.h: Removed.
1032         * TestWebKitAPI/ForwardingHeaders/WebCore/LayoutUnit.h: Removed.
1033
1034 2018-02-14  Daniel Bates  <dabates@apple.com>
1035
1036         Disallow cross-origin subresources from asking for credentials
1037         https://bugs.webkit.org/show_bug.cgi?id=182579
1038         <rdar://problem/36162271>
1039
1040         Reviewed by Andy Estes.
1041
1042         Add test option allowCrossOriginSubresourcesToAskForCredential (defaults to false)
1043         so that tests can toggle between the old behavior and new behavior.
1044
1045         * DumpRenderTree/TestOptions.h:
1046         * DumpRenderTree/TestOptions.mm:
1047         (TestOptions::TestOptions):
1048         * DumpRenderTree/mac/DumpRenderTree.mm:
1049         (setWebPreferencesForTestOptions):
1050         * WebKitTestRunner/TestController.cpp:
1051         (WTR::TestController::resetPreferencesToConsistentValues):
1052         (WTR::updateTestOptionsFromTestHeader):
1053         * WebKitTestRunner/TestOptions.h:
1054         (WTR::TestOptions::hasSameInitializationOptions const):
1055
1056 2018-02-12  Ryosuke Niwa  <rniwa@webkit.org>
1057
1058         REGRESSION (r223440): Copying & pasting a list from Microsoft Word to TinyMCE fails
1059         https://bugs.webkit.org/show_bug.cgi?id=182564
1060
1061         Reviewed by Wenson Hsieh.
1062
1063         Updated assertions to make sure the trailing "}" of @list rules is includd in the style, the "style" element
1064         is wrapped by "head" element (not present in the pasted markup since the fragment parsing algorithm strips away),
1065         and the style content is enclosed in "<!--" and "-->".
1066
1067         Also use execCommand('insertHTML', ~) to insert the HTML obtained via dataTransfer.getData instead of innerHTML
1068         to make sure our pasting code preserves the special style element for MSO list quirks.
1069
1070         Finally, added two more test cases for pasting content from Microsoft Word's compatibility mode.
1071
1072         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
1073         (TEST):
1074         * TestWebKitAPI/Tests/WebKitCocoa/PasteWebArchive.mm:
1075         (TEST):
1076
1077 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
1078
1079         [Tools] --wincairo should imply --64-bit by default.
1080         https://bugs.webkit.org/show_bug.cgi?id=182753
1081
1082         Reviewed by Daniel Bates.
1083
1084         WinCairo does not currently support 32-bit and `--wincairo` itself should refer to a working platform.
1085         This patch ensures x64 is determined correctly for `build-webkit --no-ninja` and `run-webkit-tests`.
1086
1087         * Scripts/webkitdirs.pm:
1088         (determinePassedArchitecture):
1089         (shouldBuild32Bit):
1090         (determineShouldBuild32Bit):
1091         (determineIsWin64):
1092         * Scripts/webkitpy/common/config/ports.py:
1093         (WinCairoPort.build_webkit_command):
1094         * Scripts/webkitpy/common/config/ports_unittest.py:
1095         (DeprecatedPortTest.test_wincairo_port):
1096         * Scripts/webkitpy/port/win.py:
1097         (WinCairoPort):
1098
1099 2018-02-13  Commit Queue  <commit-queue@webkit.org>
1100
1101         Unreviewed, rolling out r228431.
1102         https://bugs.webkit.org/show_bug.cgi?id=182766
1103
1104         Regressed CMake build stability (Requested by dolmstead on
1105         #webkit).
1106
1107         Reverted changeset:
1108
1109         "[CMake] Make WebCore headers copies"
1110         https://bugs.webkit.org/show_bug.cgi?id=182512
1111         https://trac.webkit.org/changeset/228431
1112
1113 2018-02-13  Don Olmstead  <don.olmstead@sony.com>
1114
1115         [CMake] Make WebCore headers copies
1116         https://bugs.webkit.org/show_bug.cgi?id=182512
1117
1118         Reviewed by Keith Miller.
1119
1120         * DumpRenderTree/CMakeLists.txt:
1121         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1122         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
1123         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
1124         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
1125         * TestWebKitAPI/PlatformGTK.cmake:
1126         * TestWebKitAPI/PlatformWPE.cmake:
1127         * TestWebKitAPI/PlatformWin.cmake:
1128         * TestWebKitAPI/win/TestWebCoreStubs.cpp:
1129         (loadResourceIntoBuffer):
1130         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1131         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityControllerWPE.cpp:
1132         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
1133         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1134         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1135
1136 2018-02-13  Chris Dumez  <cdumez@apple.com>
1137
1138         REGRESSION (r228299): Broke reader mode in Safari
1139         https://bugs.webkit.org/show_bug.cgi?id=182697
1140         <rdar://problem/37399012>
1141
1142         Reviewed by Ryosuke Niwa.
1143
1144         Add API test coverage for responding asynchronously to the decidePolicyForNavigationResponse
1145         delegate.
1146
1147         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1148         * TestWebKitAPI/Tests/WebKitCocoa/AsyncPolicyForNavigationResponse.mm: Added.
1149         (-[TestAsyncNavigationDelegate webView:didFinishNavigation:]):
1150         (-[TestAsyncNavigationDelegate webView:didFailNavigation:withError:]):
1151         (-[TestAsyncNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1152         (-[TestAsyncNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1153         (-[TestAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1154         (TestWebKitAPI::TEST):
1155
1156 2018-02-12  John Wilander  <wilander@apple.com>
1157
1158         Resource Load Statistics: Classify resources as prevalent based on redirects to other prevalent resources
1159         https://bugs.webkit.org/show_bug.cgi?id=182664
1160         <rdar://problem/37372572>
1161
1162         Reviewed by Brent Fulgham.
1163
1164         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1165         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1166         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
1167         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
1168         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
1169         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1170         * WebKitTestRunner/TestController.cpp:
1171         (WTR::TestController::setStatisticsSubresourceUniqueRedirectFrom):
1172         (WTR::TestController::setStatisticsTopFrameUniqueRedirectTo):
1173         (WTR::TestController::setStatisticsTopFrameUniqueRedirectFrom):
1174         * WebKitTestRunner/TestController.h:
1175         * WebKitTestRunner/TestInvocation.cpp:
1176         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1177
1178 2018-02-12  Ross Kirsling  <ross.kirsling@sony.com>
1179
1180         download-latest-github-release .py should not use "browser download URL".
1181         https://bugs.webkit.org/show_bug.cgi?id=182646
1182
1183         Reviewed by Per Arne Vollan.
1184
1185         * Scripts/download-latest-github-release.py:
1186         Download request should be a proper GitHub API call and should actually include the token when applicable.
1187         (Also clean up usage of args and print while we're in here.)
1188
1189 2018-02-12  Per Arne Vollan  <pvollan@apple.com>
1190
1191         EWS should run Windows tests.
1192         https://bugs.webkit.org/show_bug.cgi?id=177967
1193
1194         Reviewed by Lucas Forschler.
1195
1196         This will help catch regressions at an early stage.
1197
1198         * Scripts/webkitpy/common/config/ews.json:
1199
1200 2018-02-08  Ryosuke Niwa  <rniwa@webkit.org>
1201
1202         REGRESSION (r223440): Copying & pasting a list from Microsoft Word to TinyMCE fails
1203         https://bugs.webkit.org/show_bug.cgi?id=182564
1204
1205         Reviewed by Wenson Hsieh.
1206
1207         Added tests for pasting HTML with list items generated by Microsoft Word as well as HTML which looks like
1208         the one generated by Microsoft Word but missing a proper "html" element at the beginning.
1209
1210         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1211         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm: Added test cases.
1212         * TestWebKitAPI/Tests/WebKitCocoa/PasteWebArchive.mm: Added test cases.
1213         (msoListMarkupWithoutProperHTMLElement): Added.
1214         * TestWebKitAPI/Tests/WebKitCocoa/mso-list.html: Added.
1215
1216 2018-02-09  Don Olmstead  <don.olmstead@sony.com>
1217
1218         [CMake] Make PAL headers copies
1219         https://bugs.webkit.org/show_bug.cgi?id=182645
1220
1221         Reviewed by Alex Christensen.
1222
1223         * TestWebKitAPI/CMakeLists.txt:
1224
1225 2018-02-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1226
1227         Pasting from Excel no longer provides text/html data
1228         https://bugs.webkit.org/show_bug.cgi?id=182636
1229         <rdar://problem/37087060>
1230
1231         Reviewed by Ryosuke Niwa.
1232
1233         Add new API tests to exercise pasting images with various other content types on macOS, and when dropping images
1234         and HTML markup on iOS. See the WebCore ChangeLog for more detail.
1235
1236         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1237         * TestWebKitAPI/Tests/WebKitCocoa/DataTransfer.html: Added.
1238
1239         Add a new API test harness that dumps various bits of information about a DataTransfer upon paste and drop.
1240         While somewhat similar to some existing harnesses, this makes a distinction between the raw HTML data on the
1241         pasteboard and the actual result of inserting said HTML into the DOM. This allows us to check that the HTML has
1242         been sanitized, while making checks for the actual content of the HTML robust against inline style changes.
1243
1244         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
1245         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm: Added.
1246
1247         Add a new test suite to exercise pasting mixed content types. In these test cases, the pasteboard contains a
1248         file, with some combination of plain text, rich text, and URLs.
1249
1250         (imagePath):
1251         (writeTypesAndDataToPasteboard):
1252
1253         Add a helper to write a var-arg list of content types and data to the general NSPasteboard.
1254
1255         (setUpWebView):
1256         (markupString):
1257         (TestWebKitAPI::TEST):
1258         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1259         (TestWebKitAPI::testIconImageData):
1260         (TestWebKitAPI::TEST):
1261         * TestWebKitAPI/cocoa/TestWKWebView.h:
1262
1263         Move a private declaration of -[WKWebView paste:] out to TestWKWebView.h, so that it can be shared across
1264         multiple tests. Currently, it only resides in PasteImage.mm, but I need it in PasteMixedContent.mm as well.
1265
1266 2018-02-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1267
1268         Add a way to check if a host is an IP address
1269         https://bugs.webkit.org/show_bug.cgi?id=182427
1270
1271         Reviewed by Alex Christensen.
1272
1273         Add unit test for URL::hostIsIPAddress().
1274
1275         * TestWebKitAPI/Tests/WebCore/URL.cpp:
1276         (TestWebKitAPI::TEST_F):
1277
1278 2018-02-09  Philippe Normand  <pnormand@igalia.com>
1279
1280         [GStreamer] Layout test fast/replaced/border-radius-clip.html crashes with GStreamer-CRITICAL **: gst_segment_to_stream_time: assertion 'segment->format == format' failed in gst_segment_to_stream_time()
1281         https://bugs.webkit.org/show_bug.cgi?id=176802
1282
1283         Reviewed by Xabier Rodriguez-Calvar.
1284
1285         * gstreamer/jhbuild.modules:
1286         * gstreamer/patches/gst-plugins-good-0001-gstgdkpixbufdec-stop-pretending-to-decode-gifs.patch: Added.
1287
1288 2018-02-09  Philippe Normand  <pnormand@igalia.com>
1289
1290         [JHBuild] Update Mesa to version 17
1291         https://bugs.webkit.org/show_bug.cgi?id=182599
1292
1293         Reviewed by Carlos Alberto Lopez Perez.
1294
1295         * gtk/jhbuild.modules: Update Mesa (and its dependencies, hopefully) to version 17.3.3.
1296
1297 2018-02-08  Chris Dumez  <cdumez@apple.com>
1298
1299         There should be a way to disable [OverrideBuiltins] behavior in a given DOMWrapperWorld
1300         https://bugs.webkit.org/show_bug.cgi?id=182524
1301         <rdar://problem/9057327>
1302
1303         Reviewed by Ryosuke Niwa.
1304
1305         Add API test coverage.
1306
1307         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1308         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp: Added.
1309         (TestWebKitAPI::runJavaScriptAlert):
1310         (TestWebKitAPI::TEST):
1311         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp: Added.
1312         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::InjectedBundleDisableOverrideBuiltinsBehaviorTest):
1313         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
1314         * TestWebKitAPI/Tests/WebKit/override-builtins-test.html: Added.
1315
1316 2018-02-08  Michael Catanzaro  <mcatanzaro@igalia.com>
1317
1318         TestController should not exercise cocoa-specific resource load statistics APIs
1319         https://bugs.webkit.org/show_bug.cgi?id=182355
1320
1321         Reviewed by Alex Christensen.
1322
1323         Remove unnecessary use of platform-specific APIs in the TestController, since there are
1324         cross-platform APIs to do the same thing.
1325
1326         Also, ensure callbacks execute before returning from TestController's functions, since
1327         otherwise the tests are guaranteed to be flaky at best, and also since there's nothing to
1328         prevent the TestController from being destroyed before the callbacks execute.
1329
1330         * WebKitTestRunner/TestController.cpp:
1331         (WTR::resourceStatisticsVoidResultCallback):
1332         (WTR::resourceStatisticsBooleanResultCallback):
1333         (WTR::TestController::isStatisticsPrevalentResource):
1334         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
1335         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
1336         (WTR::TestController::isStatisticsHasHadUserInteraction):
1337         (WTR::TestController::isStatisticsGrandfathered):
1338         (WTR::TestController::statisticsUpdateCookiePartitioning):
1339         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
1340         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
1341         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1342         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
1343         (WTR::resourceStatisticsCallback): Deleted.
1344         (WTR::TestController::statisticsClearThroughWebsiteDataRemovalCallback): Deleted.
1345         * WebKitTestRunner/TestController.h:
1346         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1347         (WTR::toNSString): Deleted.
1348         (WTR::TestController::setStatisticsLastSeen): Deleted.
1349         (WTR::TestController::setStatisticsPrevalentResource): Deleted.
1350         (WTR::TestController::isStatisticsPrevalentResource): Deleted.
1351         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder): Deleted.
1352         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo): Deleted.
1353         (WTR::TestController::setStatisticsHasHadUserInteraction): Deleted.
1354         (WTR::TestController::setStatisticsHasHadNonRecentUserInteraction): Deleted.
1355         (WTR::TestController::isStatisticsHasHadUserInteraction): Deleted.
1356         (WTR::TestController::setStatisticsGrandfathered): Deleted.
1357         (WTR::TestController::isStatisticsGrandfathered): Deleted.
1358         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin): Deleted.
1359         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin): Deleted.
1360         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo): Deleted.
1361         (WTR::TestController::setStatisticsTimeToLiveUserInteraction): Deleted.
1362         (WTR::TestController::setStatisticsTimeToLiveCookiePartitionFree): Deleted.
1363         (WTR::TestController::statisticsProcessStatisticsAndDataRecords): Deleted.
1364         (WTR::TestController::statisticsUpdateCookiePartitioning): Deleted.
1365         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost): Deleted.
1366         (WTR::TestController::statisticsSubmitTelemetry): Deleted.
1367         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned): Deleted.
1368         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval): Deleted.
1369         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured): Deleted.
1370         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval): Deleted.
1371         (WTR::TestController::setStatisticsGrandfatheringTime): Deleted.
1372         (WTR::TestController::setStatisticsMaxStatisticsEntries): Deleted.
1373         (WTR::TestController::setStatisticsPruneEntriesDownTo): Deleted.
1374         (WTR::TestController::statisticsClearInMemoryAndPersistentStore): Deleted.
1375         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours): Deleted.
1376         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval): Deleted.
1377         (WTR::TestController::statisticsResetToConsistentState): Deleted.
1378
1379 2018-02-08  Jonathan Bedard  <jbedard@apple.com>
1380
1381         webkit-patch suggest-reviewers dies with AttributeError: 'NoneType' object has no attribute 'revision'
1382         https://bugs.webkit.org/show_bug.cgi?id=182584
1383
1384         Reviewed by Daniel Bates.
1385
1386         It is possible that a specific revision has an empty ChangeLog. In this case, Checkout.commit_info_for_revision
1387         will return 'None'. Checkout.recent_commit_infos_for_files should never return a set with 'None' in it.
1388
1389         * Scripts/webkitpy/common/checkout/checkout.py:
1390         (Checkout.recent_commit_infos_for_files): Remove any empty commit information from the set.
1391         * Scripts/webkitpy/common/checkout/checkout_unittest.py: Add a file which references an empty ChangeLog.
1392
1393 2018-02-08  Matt Lewis  <jlewis3@apple.com>
1394
1395         Unreviewed, rolling out r228261.
1396
1397         This broke an internal build
1398
1399         Reverted changeset:
1400
1401         "Add a way to check if a host is an IP address"
1402         https://bugs.webkit.org/show_bug.cgi?id=182427
1403         https://trac.webkit.org/changeset/228261
1404
1405 2018-02-08  Commit Queue  <commit-queue@webkit.org>
1406
1407         Unreviewed, rolling out r228267, r228268, and r228269.
1408         https://bugs.webkit.org/show_bug.cgi?id=182601
1409
1410         jhbuild socks (Requested by philn on #webkit).
1411
1412         Reverted changesets:
1413
1414         "[JHBuild] Update Mesa to version 17"
1415         https://bugs.webkit.org/show_bug.cgi?id=182599
1416         https://trac.webkit.org/changeset/228267
1417
1418         "Unreviewed, GTK build fix attempt after r228267."
1419         https://trac.webkit.org/changeset/228268
1420
1421         "Unreviewed, final GTK build fix attempt after r228267."
1422         https://trac.webkit.org/changeset/228269
1423
1424 2018-02-08  Philippe Normand  <pnormand@igalia.com>
1425
1426         Unreviewed, final GTK build fix attempt after r228267.
1427
1428         * gtk/jhbuild.modules: sha256sum for libdrm was for the tar.gz archive. Oops.
1429
1430 2018-02-08  Philippe Normand  <pnormand@igalia.com>
1431
1432         Unreviewed, GTK build fix attempt after r228267.
1433
1434         * gtk/jhbuild.modules: Update to libdrm version 2.4.89, Mesa 17 requires at least version 2.4.75.
1435
1436 2018-02-08  Philippe Normand  <pnormand@igalia.com>
1437
1438         [JHBuild] Update Mesa to version 17
1439         https://bugs.webkit.org/show_bug.cgi?id=182599
1440
1441         Reviewed by Carlos Alberto Lopez Perez.
1442
1443         * gtk/jhbuild.modules: Update Mesa to version 17.3.3.
1444
1445 2018-02-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1446
1447         Add a way to check if a host is an IP address
1448         https://bugs.webkit.org/show_bug.cgi?id=182427
1449
1450         Reviewed by Alex Christensen.
1451
1452         Add unit test for URL::hostIsIPAddress().
1453
1454         * TestWebKitAPI/Tests/WebCore/URL.cpp:
1455         (TestWebKitAPI::TEST_F):
1456
1457 2018-02-07  Tim Horton  <timothy_horton@apple.com>
1458
1459         Evernote device management web view sometimes displays at the wrong scale
1460         https://bugs.webkit.org/show_bug.cgi?id=182590
1461         <rdar://problem/36633687>
1462
1463         Reviewed by Simon Fraser.
1464
1465         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1466         * TestWebKitAPI/Tests/ios/WKScrollViewDelegate.mm: Renamed from Tools/TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm.
1467         (-[TestDelegateForScrollView dealloc]):
1468         (TestWebKitAPI::TEST):
1469         (-[WKScrollViewDelegateWithViewForZoomingOverridden viewForZoomingInScrollView:]):
1470         Add a test that failed before the change that ensures that we don't
1471         consult the external delegate for viewForZoomingInScrollView:, and that
1472         we succesfully update the scale even if it matches that of the view
1473         the external delegate returns for viewForZoomingInScrollView:.
1474
1475 2018-02-07  Wenson Hsieh  <wenson_hsieh@apple.com>
1476
1477         REGRESSION(r226396): File paths are inserted when dropping image files
1478         https://bugs.webkit.org/show_bug.cgi?id=182557
1479         <rdar://problem/37294120>
1480
1481         Reviewed by Ryosuke Niwa.
1482
1483         Tweak some image pasting API tests to ensure that file paths are not inserted when pasting images backed by
1484         file paths on disk.
1485
1486         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
1487         (TEST):
1488
1489 2018-02-07  Ms2ger  <Ms2ger@igalia.com>
1490
1491         [GTK] Enable WebKit.GeolocationTransitionTo{High,Low}Accuracy tests
1492         https://bugs.webkit.org/show_bug.cgi?id=125068
1493
1494         Unreviewed test gardening.
1495
1496         They do not appear to have failed since we started running them again in r226944.
1497
1498         * TestWebKitAPI/glib/TestExpectations.json:
1499
1500 2018-02-07  Ms2ger  <Ms2ger@igalia.com>
1501
1502         [GTK] Enable WebKit.InjectedBundleFrameHitTest test
1503         https://bugs.webkit.org/show_bug.cgi?id=120303
1504
1505         Unreviewed test gardening.
1506
1507         It does not appear to have failed since we started running it again in r226944.
1508
1509         * TestWebKitAPI/glib/TestExpectations.json:
1510
1511 2018-02-07  Ms2ger  <Ms2ger@igalia.com>
1512
1513         [GTK] Enable WebKit.ForceRepaint test
1514         https://bugs.webkit.org/show_bug.cgi?id=105532
1515
1516         Unreviewed test gardening.
1517
1518         It does not appear to have failed since we started running it again in r226944.
1519
1520         * TestWebKitAPI/glib/TestExpectations.json:
1521
1522 2018-02-07  Philippe Normand  <pnormand@igalia.com>
1523
1524         [JHBuild] Add libva in moduleset
1525         https://bugs.webkit.org/show_bug.cgi?id=182384
1526
1527         Reviewed by Xabier Rodriguez-Calvar.
1528
1529         * gstreamer/jhbuild.modules: Add libva and disable spurious message output.
1530         * gtk/install-dependencies: Remove libva from dependencies.
1531         * wpe/install-dependencies: Ditto.
1532
1533 2018-02-07  Ms2ger  <Ms2ger@igalia.com>
1534
1535         [GTK] Enable WebKit.NewFirstVisuallyNonEmptyLayoutFrames test
1536         https://bugs.webkit.org/show_bug.cgi?id=85037
1537
1538         Unreviewed test gardening.
1539
1540         It does not appear to have failed since we started running it again in r226944.
1541
1542         * TestWebKitAPI/glib/TestExpectations.json:
1543
1544 2018-02-06  Leo Balter  <leonardo.balter@gmail.com>
1545
1546         Nit fix for ruby script called through Perl
1547         https://bugs.webkit.org/show_bug.cgi?id=182552
1548
1549         Reviewed by Yusuke Suzuki.
1550
1551         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1552         (RunTest262Tests):
1553
1554 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
1555
1556         Remove WebCore/ForwardingHeaders directory
1557         https://bugs.webkit.org/show_bug.cgi?id=182347
1558
1559         Reviewed by Keith Miller.
1560
1561         * WebKitTestRunner/TestController.cpp:
1562
1563 2018-02-06  Ross Kirsling  <ross.kirsling@sony.com>
1564
1565         webkit-patch upload should ask for confirmation before creating a new bug
1566         https://bugs.webkit.org/show_bug.cgi?id=182551
1567
1568         Reviewed by Daniel Bates.
1569
1570         It is quite easy to paste unintended text into the bug number prompt. This creates a junk bug with an uneditable
1571         first comment, which could result in embarrassment or potentially even a proprietary information leak.
1572
1573         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1574         (test_prepare):
1575         * Scripts/webkitpy/tool/steps/promptforbugortitle.py:
1576         (PromptForBugOrTitle):
1577         (PromptForBugOrTitle.options):
1578         (PromptForBugOrTitle.run):
1579
1580 2018-02-06  Youenn Fablet  <youenn@apple.com>
1581
1582         HasServiceWorkerRegistration bit should be sent when creating a new page
1583         https://bugs.webkit.org/show_bug.cgi?id=182410
1584
1585         Reviewed by Chris Dumez.
1586
1587         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1588
1589 2018-02-06  Andres Gomez  <agomez@igalia.com>
1590
1591         [GTK][WPE] Add dependencies watching lists for WKGTK+ and WPE
1592         https://bugs.webkit.org/show_bug.cgi?id=182346
1593
1594         Reviewed by Michael Catanzaro.
1595
1596         Loren, Carlos and Andres are interested on the WKGTK+ dependencies
1597         watchlist since they are running WKGTK+ EWS.
1598
1599         Similarly, Adrian and Carlos are running a WPE EWS.
1600
1601         * Scripts/webkitpy/common/config/watchlist: Added WPEDependencies
1602           and WebKitGTKDependencies watchlists with the proper people.
1603
1604 2018-02-06  Andres Gomez  <agomez@igalia.com>
1605
1606         Unreviewed, canonicalize contributors.json
1607
1608         After Thibault's addition, automatic checks complain about
1609         contributors.json with:
1610
1611         "[...] Use "validate-committer-lists --canonicalize" to reformat
1612         it. [...]"
1613
1614         * Scripts/webkitpy/common/config/contributors.json: Canonicalize.
1615
1616 2018-02-06  Andres Gomez  <agomez@igalia.com>
1617
1618         Unreviewed, add Lorenzo Tilve to contributors.json
1619
1620         We need to add Loren to the contributors list in order to CC him
1621         in Bugzilla.
1622
1623         * Scripts/webkitpy/common/config/contributors.json: Added Lorenzo
1624           Tilve.
1625
1626 2018-02-05  Yousuke Kimoto  <yousuke.kimoto@sony.com>
1627
1628         [WinCairo] Refine WebKitLegacy and WebKit build for wincairo
1629         https://bugs.webkit.org/show_bug.cgi?id=182478
1630
1631         Reviewed by Alex Christensen.
1632
1633         For TestWebKitAPI, sources related to WebKitLegacy are built
1634         at WebKit build. Those files should be reffered for WebKitLegacy build.
1635
1636         * TestWebKitAPI/PlatformWin.cmake:
1637
1638 2018-02-05  Daniel Bates  <dabates@apple.com>
1639
1640         REGRESSION (r217572): run-webkit-tests exits without emitting newline character
1641         https://bugs.webkit.org/show_bug.cgi?id=182360
1642
1643         Rubber-stamped by Aakash Jain.
1644
1645         Fixes an annoyance where run-webkit-tests always exits without printing a newline character.
1646         In the terminal this looks like:
1647
1648             $ Tools/Scripts/run-webkit-tests
1649             Expected to fail, but passed: (7)
1650             ...
1651             Stopping WebSocket server ...$
1652
1653         This bug was caused by code added in r217572 to stop all run-webkit-tests started servers (e.g. an HTTP
1654         server) from an at-exit handler. When run-webkit-tests runs successfully (i.e. without error or
1655         control-C interruption) we would stop all such servers twice: once as part of ending the test
1656         run and once from the at-exit handler. The latter never prints a trailing newline character hence
1657         the state of the terminal (as depicted above). Instead LayoutTestRunner.stop_servers() should only
1658         stop servers that it started in LayoutTestRunner.start_servers().
1659
1660         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1661         (LayoutTestRunner.__init__):
1662         (LayoutTestRunner.start_servers):
1663         (LayoutTestRunner.stop_servers):
1664         Only start servers that run-webkit-tests has not already started and only stop servers that
1665         run-webkit-tests started.
1666
1667         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1668         (LayoutTestRunnerTests.test_servers_started.is_websocket_server_running):
1669         (LayoutTestRunnerTests.test_servers_started):
1670         (LayoutTestRunnerTests.test_servers_started.is_websocket_servers_running): Deleted.
1671         Update due to rename below.
1672
1673         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
1674         (is_web_socket_server_running): Added.
1675         (PyWebSocket.is_running): Deleted.
1676
1677         * Scripts/webkitpy/port/base.py:
1678         (Port.is_http_server_running): Check if we already started the server ourself.
1679         (Port.is_websocket_server_running): Formerly named is_websocket_servers_running. Modified
1680         to check if we already started the server ourself. Take a similar approach as the other
1681         Port.is_*_running methods and only check if an existing WebSocket server is running on the
1682         non-secure server port. This is a simple heuristic and should be sufficient in practice.
1683         (Port.is_wpt_server_running): Check if we already started the server ourself.
1684         (Port.is_websocket_servers_running): Deleted; renamed to is_websocket_server_running().
1685
1686 2018-02-05  Daniel Bates  <dabates@apple.com>
1687
1688         prepare-ChangeLog gets confused about Python docstrings that contain the word "class" or "def"
1689         https://bugs.webkit.org/show_bug.cgi?id=182405
1690
1691         Reviewed by David Kilzer.
1692
1693         String literal statements, including docstrings, do not demarcate a new scope in Python.
1694         So, do not treat them like they do when building up the list of modified functions.
1695
1696         * Scripts/prepare-ChangeLog:
1697         (get_function_line_ranges_for_python):
1698         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt:
1699         The expected ending line number for the last "pass" statement inside the scope of Class5 changed
1700         from 97 to 98 because empty lines do not effect scope. This is consistent with the parsing
1701         of the second "pass" statement in the scope of class Class5. A "pass" is a null operation that
1702         is used as a syntactic placeholder when a statement is required. Ideally we would make
1703         the parsing code smarter so as to avoid emitting ranges for "pass" statements that serve
1704         not syntactic purpose.
1705         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py:
1706         (Class5):
1707         (Class6):
1708         (Class6.__init__):
1709         (Class7):
1710         (Class7.__init__):
1711         (Class8):
1712         (Class8.__init__):
1713         Add some more tests.
1714
1715 2018-02-05  Matt Lewis  <jlewis3@apple.com>
1716
1717         Unreviewed, rolling out r228086.
1718
1719         This introduced a failure with API test
1720         URLTest.HostIsIPAddress.
1721
1722         Reverted changeset:
1723
1724         "Add a way to check if a host is an IP address"
1725         https://bugs.webkit.org/show_bug.cgi?id=182427
1726         https://trac.webkit.org/changeset/228086
1727
1728 2018-02-05  John Wilander  <wilander@apple.com>
1729
1730         Storage Access API: Add testRunner.getAllStorageAccessEntries() to make testing easier and more explicit
1731         https://bugs.webkit.org/show_bug.cgi?id=181601
1732         <rdar://problem/36475837>
1733
1734         Reviewed by Alex Christensen.
1735
1736         http/tests/storageAccess/request-and-grant-access-then-detach-should-not-have-access.html
1737         was found to be flaky. With the testRunner.hasStorageAccessEntry() getter
1738         it's possible to check access even if a frame doesn't respond timely to
1739         postMessage after detach and attach.
1740
1741         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1742         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1743         (WTR::InjectedBundle::didReceiveMessageToPage):
1744         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1745         (WTR::TestRunner::setStorageAccessAPIEnabled):
1746             Just moved for source file grouping.
1747         (WTR::TestRunner::getAllStorageAccessEntries):
1748         (WTR::TestRunner::callDidReceiveAllStorageAccessEntriesCallback):
1749         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1750         * WebKitTestRunner/TestController.cpp:
1751         (WTR::TestController::getAllStorageAccessEntries):
1752             Note that this is just stubbed out, i.e. not implemented.
1753         * WebKitTestRunner/TestController.h:
1754         * WebKitTestRunner/TestInvocation.cpp:
1755         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1756         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
1757         * WebKitTestRunner/TestInvocation.h:
1758         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1759         (WTR::TestController::getAllStorageAccessEntries):
1760             This is the Cocoa-specific version of this test infrastructure.
1761
1762 2018-02-05  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1763
1764         [Win] Enable multi CPU building on MSBuild.
1765         https://bugs.webkit.org/show_bug.cgi?id=182446
1766
1767         Compiling itself already uses multi cores, but other stuff is still on single core.
1768         This patch enables that by passing an argument to MSBuild.exe.
1769
1770         Reviewed by Alex Christensen.
1771
1772         * Scripts/webkitdirs.pm:
1773         (determineNumberOfCPUs):
1774         (buildVisualStudioProject):
1775
1776 2018-02-05  Alicia Boya García  <aboya@igalia.com>
1777
1778         Fix bug in MediaTime comparison for negative values with different scale.
1779         https://bugs.webkit.org/show_bug.cgi?id=182433
1780
1781         Improved test coverage for MediaTime::compare().
1782
1783         Reviewed by Xabier Rodriguez-Calvar.
1784
1785         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1786         (TestWebKitAPI::TEST):
1787
1788 2018-02-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1789
1790         [SOUP] WebSockets must use system proxy settings
1791         https://bugs.webkit.org/show_bug.cgi?id=126384
1792
1793         Reviewed by Michael Catanzaro.
1794
1795         Check also WebSockets in /webkit2/WebKitWebContext/proxy.
1796
1797         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
1798         (ProxyTest::webSocketProxyServerCallback):
1799         (ProxyTest::ProxyTest):
1800         (ProxyTest::webSocketConnected):
1801         (ProxyTest::createWebSocketAndWaitUntilConnected):
1802         (webSocketServerCallback):
1803         (testWebContextProxySettings):
1804         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
1805         (WebKitTestServer::~WebKitTestServer):
1806         (WebKitTestServer::addWebSocketHandler):
1807         (WebKitTestServer::removeWebSocketHandler):
1808         (WebKitTestServer::getWebSocketURIForPath const):
1809         (WebKitTestServer::getURIForPath const):
1810         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h:
1811         (WebKitTestServer::baseURI const):
1812         (WebKitTestServer::baseWebSocketURI const):
1813
1814 2018-02-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1815
1816         Add a way to check if a host is an IP address
1817         https://bugs.webkit.org/show_bug.cgi?id=182427
1818
1819         Reviewed by Alex Christensen.
1820
1821         Add unit test for URL::hostIsIPAddress().
1822
1823         * TestWebKitAPI/Tests/WebCore/URL.cpp:
1824         (TestWebKitAPI::TEST_F):
1825
1826 2018-02-03  Charlie Turner  <cturner@igalia.com>
1827
1828         Add libmount to WPE dependencies
1829         https://bugs.webkit.org/show_bug.cgi?id=182345
1830
1831         Reviewed by Michael Catanzaro.
1832
1833         * wpe/install-dependencies:
1834
1835 2018-02-02  Youenn Fablet  <youenn@apple.com>
1836
1837         W3C test exporter should allow exporting newly added files
1838         https://bugs.webkit.org/show_bug.cgi?id=182369
1839
1840         Reviewed by Ryosuke Niwa.
1841
1842         * Scripts/webkitpy/common/checkout/scm/git.py:
1843         (Git.apply_mail_patch):
1844
1845 2018-02-02  David Quesada  <david_quesada@apple.com>
1846
1847         WebAppManifest scope should default to the containing directory of start_url if 'scope' is not specified
1848         https://bugs.webkit.org/show_bug.cgi?id=182363
1849         rdar://problem/37093498
1850
1851         Reviewed by Ryosuke Niwa.
1852
1853         Updated ApplicationManifestParserTests to account for the new default scope behavior.
1854
1855         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
1856         (assertManifestHasDefaultValues):
1857         (TEST_F):
1858
1859 2018-02-02  Youenn Fablet  <youenn@apple.com>
1860
1861         Clearing all service worker registrations should wait for importing service worker registration to finish
1862         https://bugs.webkit.org/show_bug.cgi?id=182407
1863
1864         Reviewed by Chris Dumez.
1865
1866         Make sure we finish clearing service worker registrations before running tests.
1867
1868         * WebKitTestRunner/TestController.cpp:
1869         (WTR::TestController::resetStateToConsistentValues):
1870         (WTR::ClearServiceWorkerRegistrationsCallbackContext::ClearServiceWorkerRegistrationsCallbackContext):
1871         (WTR::clearServiceWorkerRegistrationsCallback):
1872         (WTR::TestController::clearServiceWorkerRegistrations):
1873         * WebKitTestRunner/TestController.h:
1874
1875 2018-02-02  Youenn Fablet  <youenn@apple.com>
1876
1877         Configure serviceWorkerRegistrationDirectory on the web site data store and move it to a Caches subfolder as a default
1878         https://bugs.webkit.org/show_bug.cgi?id=182403
1879
1880         Reviewed by Alex Christensen.
1881
1882         * WebKitTestRunner/TestController.cpp:
1883         (WTR::TestController::generateContextConfiguration const):
1884         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1885         (WTR::initializeWebViewConfiguration):
1886
1887 2018-02-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1888
1889         [GTK] WebDriver: tests step always times out in the bot
1890         https://bugs.webkit.org/show_bug.cgi?id=182437
1891
1892         Reviewed by Carlos Alberto Lopez Perez.
1893
1894         The process itself is not timing out, but the buildbot step is. This is because we are leaking the Xvfb
1895         processes. We should ensure that only one driver is executed and it's stopped before the process finishes.
1896
1897         * Scripts/run-webdriver-tests: Call teardown() after run().
1898         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1899         (WebDriverSeleniumExecutor.__init__): Receive the env directly instead of the display driver.
1900         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
1901         (WebDriverTestRunner.__init__): Use the driver class directly instead of using the DriverProxy. Get the env from
1902         the display driver once and pass it to the test runners.
1903         (WebDriverTestRunner.teardown): Stop the display server.
1904         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1905         (WebDriverTestRunnerSelenium.__init__): Receive the env directly instead of the display driver.
1906         (WebDriverTestRunnerSelenium.collect_tests): Pass the env to the executor.
1907         (WebDriverTestRunnerSelenium.run): Ditto.
1908         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1909         (WebDriverTestRunnerW3C.__init__): Receive the env directly instead of the display driver.
1910         (WebDriverTestRunnerW3C.run): Pass the env to the executor.
1911         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
1912         (WebDriverW3CExecutor.__init__): Receive the env directly instead of the display driver.
1913
1914 2018-02-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1915
1916         Unreviewed, rolling out r227999.
1917
1918         It didn't fix the problem
1919
1920         Reverted changeset:
1921
1922         "Unreviewed. Try to avoid webdriver tests step timing out in
1923         the bots."
1924         https://trac.webkit.org/changeset/227999
1925
1926 2018-02-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1927
1928         Start timeout for the run-buildbot-test script is too aggressive
1929         https://bugs.webkit.org/show_bug.cgi?id=182429
1930
1931         Reviewed by Carlos Garcia Campos.
1932
1933         15 seconds is not enough waiting for the update database process
1934         to complete on a system backed with rotational HDDs. Raise it to 60.
1935
1936         * BuildSlaveSupport/build.webkit.org-config/run-buildbot-test.py:
1937         (wait_for_master_ready):
1938
1939 2018-02-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1940
1941         re-add ARM JSCOnly bots on buildbot waterfall
1942         https://bugs.webkit.org/show_bug.cgi?id=182428
1943
1944         Reviewed by Csaba Osztrogonác.
1945
1946         * BuildSlaveSupport/build.webkit.org-config/config.json:
1947         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1948
1949 2018-02-02  Csaba Osztrogonác  <ossy@webkit.org>
1950
1951         Remove ARM JSCOnly bots from buildbot waterfall
1952         https://bugs.webkit.org/show_bug.cgi?id=182398
1953
1954         Reviewed by Alexey Proskuryakov.
1955
1956         * BuildSlaveSupport/build.webkit.org-config/config.json:
1957         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1958
1959 2018-02-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1960
1961         Unreviewed. Try to avoid webdriver tests step timing out in the bots.
1962
1963         This is another speculative workaround. Carlos Lopez suggested to use os._exit() instead of sys.exit() as a
1964         workaround for a bug in python2.7 when using multiprocess module.
1965
1966         * Scripts/run-webdriver-tests:
1967
1968 2018-02-01  Youenn Fablet  <youenn@apple.com>
1969
1970         Delay service worker process creation until actually needed by SWServer
1971         https://bugs.webkit.org/show_bug.cgi?id=182301
1972
1973         Reviewed by Chris Dumez.
1974
1975         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1976         (function):
1977
1978 2018-02-01  Aakash Jain  <aakash_jain@apple.com>
1979
1980         Bubbles intermittently disappear from bot watchers dashboard
1981         https://bugs.webkit.org/show_bug.cgi?id=182085
1982
1983         Reviewed by Alexey Proskuryakov.
1984
1985         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1986         (BuildbotIteration.prototype.failureLogURL): failureLogURL doesn't depend on step in Buildbot 0.9.
1987         Return the Build Page URL for Buildbot Buildbot 0.9. Earlier code was also doing the same using a
1988         confusing if (!this._firstFailedStep.logs) statement which is always false for Buildbot 0.9.
1989
1990 2018-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1991
1992         [GTK] Problem with Washington Post images
1993         https://bugs.webkit.org/show_bug.cgi?id=181421
1994
1995         Reviewed by Carlos Alberto Lopez Perez.
1996
1997         Add test case for the new user agent quirk.
1998
1999         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2000         (TestWebKitAPI::TEST):
2001
2002 2018-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2003
2004         [GTK] MiniBrowser settings are just a list of names
2005         https://bugs.webkit.org/show_bug.cgi?id=182005
2006
2007         Reviewed by Sergio Villar Senin.
2008
2009         The default size we are using is too small to show the values column, and the window is not resizable because
2010         GObjectClass::constructed() is not called in the parent class.
2011
2012         * MiniBrowser/gtk/BrowserSettingsDialog.c:
2013         (browser_settings_dialog_init): Use 600x400 as default size.
2014         (browserSettingsDialogConstructed): Chain up to parent constructed.
2015
2016 2018-01-31  Andres Gomez  <agomez@igalia.com>
2017
2018         Unreviewed. Remove WebInspectorUI watchlist and remove myself from 2 watchlists more
2019
2020         * Scripts/webkitpy/common/config/watchlist:
2021
2022 2018-01-31  Per Arne Vollan  <pvollan@apple.com>
2023
2024         Layout Test fast/events/beforeunload-dom-manipulation-crash.html is crashing
2025         https://bugs.webkit.org/show_bug.cgi?id=181204
2026         <rdar://problem/36256274>
2027
2028         Reviewed by Ryosuke Niwa.
2029
2030         Implement 'testRunner.forceImmediateCompletion()' for WK1.
2031
2032         * DumpRenderTree/TestRunner.cpp:
2033         (forceImmediateCompletionCallback):
2034         (TestRunner::staticFunctions):
2035
2036 2018-01-31  Alex Christensen  <achristensen@webkit.org>
2037
2038         Unreviewed, rolling out r227942.
2039
2040         r227875 should not have been rolled out.
2041
2042         Reverted changeset:
2043
2044         "Unreviewed, rolling out r227875."
2045         https://bugs.webkit.org/show_bug.cgi?id=182357
2046         https://trac.webkit.org/changeset/227942
2047
2048 2018-01-31  Michael Catanzaro  <mcatanzaro@igalia.com>
2049
2050         Unreviewed, rolling out r227875.
2051         https://bugs.webkit.org/show_bug.cgi?id=182357
2052
2053         Missing cross-platform TestController implementation
2054
2055         Reverted changeset:
2056
2057         "Add callbacks to testRunner.statisticsSetShouldPartitionCookiesForHost() and testRunner.statisticsUpdateCookiePartitioning()"
2058         https://bugs.webkit.org/show_bug.cgi?id=181958
2059         https://trac.webkit.org/changeset/227875
2060
2061         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2062         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2063         (WTR::InjectedBundle::didReceiveMessageToPage):
2064         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2065         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
2066         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
2067         (WTR::TestRunner::statisticsCallDidSetPartitionOrBlockCookiesForHostCallback): Deleted.
2068         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2069         * WebKitTestRunner/TestInvocation.cpp:
2070         (WTR::TestInvocation::didSetPartitionOrBlockCookiesForHost): Deleted.
2071         * WebKitTestRunner/TestInvocation.h:
2072         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2073         (WTR::TestController::statisticsUpdateCookiePartitioning):
2074         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
2075
2076 2018-01-31  Michael Catanzaro  <mcatanzaro@igalia.com>
2077
2078         REGRESSION(r227223): http/tests/resourceLoadStatistics/clear-in-memory-and-persistent-store-one-hour.html, http/tests/resourceLoadStatistics/grandfathering.html timing out on GTK, WPE
2079         https://bugs.webkit.org/show_bug.cgi?id=182222
2080
2081         Reviewed by Alex Christensen.
2082
2083         Use the new API to notify when resource load statistics deletion is complete.
2084
2085         * WebKitTestRunner/TestController.cpp:
2086         (WTR::TestController::statisticsClearThroughWebsiteDataRemovalCallback):
2087         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
2088         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2089
2090 2018-01-31  Ryosuke Niwa  <rniwa@webkit.org>
2091
2092         Add the support for running StyleBench to run-benchmark
2093         https://bugs.webkit.org/show_bug.cgi?id=182323
2094
2095         Reviewed by Antti Koivisto.
2096
2097         Added the plan file and the patch needed to run StyleBench using run-benchmark as of r227863.
2098
2099         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/StyleBench.patch: Added.
2100         * Scripts/webkitpy/benchmark_runner/data/plans/stylebench.plan: Added.
2101
2102 2018-01-31  Wenson Hsieh  <wenson_hsieh@apple.com>
2103
2104         [iOS WK2] API test DataInteractionTests.ExternalSourceDataTransferItemGetFolderAsEntry is failing after an SDK update
2105         https://bugs.webkit.org/show_bug.cgi?id=182339
2106         <rdar://problem/36041396>
2107
2108         Reviewed by Andy Estes.
2109
2110         This API test wasn't meant to be dependent on the size of an image generated using UIImagePNGRepresentation().
2111         To make this test robust against changes to image encoding, write the raw data to the test folder instead and
2112         check against the length of the data written.
2113
2114         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2115         (testIconImageData):
2116         (runTestWithTemporaryFolder):
2117         (TestWebKitAPI::TEST):
2118
2119 2018-01-31  Dan Bernstein  <mitz@apple.com>
2120
2121         [macOS] MiniBrowser isn’t app-sandboxed
2122         https://bugs.webkit.org/show_bug.cgi?id=182147
2123
2124         Reviewed by Sam Weinig.
2125
2126         Enable App Sandbox and add a temporary exception allowing read access to all files.
2127
2128         * MiniBrowser/Configurations/Base.xcconfig: Enabled ad-hoc code signing.
2129         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Specified the entitlements file to use.
2130         * MiniBrowser/MiniBrowser.entitlements: Added. Enables App Sandbox with outbound networking
2131           and read access from /.
2132         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Added reference to new file.
2133
2134 2018-01-31  Philippe Normand  <pnormand@igalia.com>
2135
2136         [JHBuild] Add gstreamer-vaapi in moduleset
2137         https://bugs.webkit.org/show_bug.cgi?id=182283
2138
2139         Reviewed by Carlos Alberto Lopez Perez.
2140
2141         GStreamer-VAAPI is required for hardware-accelerated video
2142         playback support on Intel and AMD (using radeosi driver)
2143         platforms.
2144
2145         * gstreamer/jhbuild.modules: Add gstreamer-vaapi.
2146         * gtk/install-dependencies: Install libva.
2147         * wpe/install-dependencies: Ditto.
2148         * Scripts/webkitpy/port/gtk.py:
2149         (GtkPort.setup_environ_for_server): Disable va-api support when
2150         testing because it's incompatible with Mesa's softGL driver.
2151
2152 2018-01-31  Charlie Turner  <cturner@igalia.com>
2153
2154         [WPE] Update jhbuild dependencies
2155         https://bugs.webkit.org/show_bug.cgi?id=182286
2156
2157         This upgrades the following packages,
2158         glib 2.44.1 -> 2.54.3
2159         glib-networking 2.42.0 -> 2.54.1
2160         libsoup 2.48.0 -> 2.60.3
2161
2162         The initial reason for performing these upgrades was that when
2163         visiting https://youtube.com, WPE was getting TLS certificate
2164         errors. After upgrading glib-networking, these were fixed, but the
2165         upgrade introduced dependencies on newer versions of the other
2166         packages upgraded in this commit.
2167
2168         The upgrade to glib caused a linking error in gstreamer, the
2169         following errors were being logged during linking,
2170
2171         //usr/lib/x86_64-linux-gnu/libpangoft2-1.0.so.0: undefined reference to `hb_glib_script_from_script'
2172         //usr/lib/x86_64-linux-gnu/libpangoft2-1.0.so.0: undefined reference to `hb_glib_get_unicode_funcs'
2173         //usr/lib/x86_64-linux-gnu/libpangoft2-1.0.so.0: undefined reference to `hb_glib_script_to_script'
2174
2175         This was fixed by adding the glib package built in the jhbuild to
2176         harfbuzz.
2177
2178         Finally, the upgrade of glib caused the glib-warning-fix.patch to
2179         no longer apply, so this patch was removed.
2180
2181         Reviewed by Michael Catanzaro.
2182
2183         * wpe/jhbuild.modules: Added dependecies.
2184         * wpe/patches/glib-warning-fix.patch: Removed.
2185
2186 2018-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2187
2188         Unreviewed, rolling out r227782.
2189
2190         It didn't fix the problem
2191
2192         Reverted changeset:
2193
2194         "Unreviewed. Try to avoid webdriver tests step timing out in
2195         the bots."
2196         https://trac.webkit.org/changeset/227782
2197
2198 2018-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2199
2200         WebDriver: add domains to server config in w3c tests
2201         https://bugs.webkit.org/show_bug.cgi?id=182294
2202
2203         Reviewed by Carlos Alberto Lopez Perez.
2204
2205         Several cookie tests expect server_config to have a domains key.
2206
2207         Fixes: imported/w3c/webdriver/tests/cookies/add_cookie.py::test_add_domain_cookie
2208                imported/w3c/webdriver/tests/cookies/add_cookie.py::test_add_session_cookie_with_leading_dot_character_in_domain
2209
2210         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
2211         (WebDriverW3CExecutor.__init__):
2212
2213 2018-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2214
2215         Unreviewed. Update W3C WebDriver imported tests.
2216
2217         Show full pytest failure logs.
2218
2219         pytest truncates long lists when printing a failed assertion.
2220         This is not great for debugging and arguably it should be the
2221         default to show the full diff when comparing lists.
2222
2223         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2224         (run):
2225
2226 2018-01-30  John Wilander  <wilander@apple.com>
2227
2228         Add callbacks to testRunner.statisticsSetShouldPartitionCookiesForHost() and testRunner.statisticsUpdateCookiePartitioning()
2229         https://bugs.webkit.org/show_bug.cgi?id=181958
2230         https://bugs.webkit.org/show_bug.cgi?id=182072
2231         <rdar://problem/36801804>
2232         <rdar://problem/36845795>
2233
2234         Reviewed by Brent Fulgham.
2235
2236         Because of the asynchronous nature of XPC and cookies,
2237         we need callbacks in these TestRunner functions so that
2238         the layout tests can wait for state changes to finish
2239         before checking test conditions.
2240
2241         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2242         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2243         (WTR::InjectedBundle::didReceiveMessageToPage):
2244         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2245         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
2246         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
2247         (WTR::TestRunner::statisticsCallDidSetPartitionOrBlockCookiesForHostCallback):
2248         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2249         * WebKitTestRunner/TestInvocation.cpp:
2250         (WTR::TestInvocation::didSetPartitionOrBlockCookiesForHost):
2251         * WebKitTestRunner/TestInvocation.h:
2252         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2253         (WTR::TestController::statisticsUpdateCookiePartitioning):
2254         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
2255
2256 2018-01-30  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2257
2258         [webkitpy] Config file for apache is copied twice.
2259         https://bugs.webkit.org/show_bug.cgi?id=182131
2260
2261         Reviewed by Daniel Bates.
2262
2263         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2264         (LayoutTestApacheHttpd.__init__):
2265         (LayoutTestApacheHttpd._copy_apache_config_file):
2266         (LayoutTestApacheHttpd._get_apache_config_file_path): Deleted.
2267
2268 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
2269
2270         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
2271         https://bugs.webkit.org/show_bug.cgi?id=182312
2272
2273         Reviewed by Michael Catanzaro.
2274
2275         * DumpRenderTree/config.h:
2276         * TestWebKitAPI/config.h:
2277         * WebKitTestRunner/config.h:
2278
2279 2018-01-30  Wenson Hsieh  <wenson_hsieh@apple.com>
2280
2281         [iOS] API test UIPasteboardTests.DataTransferGetDataWhenPastingPlatformRepresentations fails after r223440
2282         https://bugs.webkit.org/show_bug.cgi?id=182307
2283         <rdar://problem/36041485>
2284
2285         Reviewed by Ryosuke Niwa.
2286
2287         Adjusts a failing API test that we forgot to rebaseline after r223440, which ensures that the result of reading
2288         "text/html" from the DataTransfer is sanitized markup. To do this, teach the test harness
2289         (dump-datatransfer-types.html) to ignore inline styles in markup if a flag is set, and then set that flag in
2290         UIPasteboardTests.DataTransferGetDataWhenPastingPlatformRepresentations.
2291
2292         * TestWebKitAPI/Tests/WebKitCocoa/dump-datatransfer-types.html:
2293         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2294         (TestWebKitAPI::TEST):
2295
2296 2018-01-30  Sergio Villar Senin  <svillar@igalia.com>
2297
2298         [WebVR][GTK][WPE] Exclude OpenVR from tarballs
2299         https://bugs.webkit.org/show_bug.cgi?id=182284
2300
2301         Reviewed by Michael Catanzaro.
2302
2303         * gtk/manifest.txt.in: Added ThirdParty/openvr to exclusions.
2304         * wpe/manifest.txt.in: Ditto.
2305
2306 2018-01-30  Yusuke Suzuki  <utatane.tea@gmail.com>
2307
2308         Unreviewed, try to fix JSCOnly build
2309         https://bugs.webkit.org/show_bug.cgi?id=177202
2310
2311         * CMakeLists.txt:
2312
2313 2018-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2314
2315         Unreviewed. Try to avoid webdriver tests step timing out in the bots.
2316
2317         The process itself doesn't seem to be timing out, but the buildbot is always reporting the step as finished
2318         after timeout. I think there's a race condition or something in buildbot, and it keeps watching the json log
2319         file even when it has already been written. This is a speculative workaround, assuming that's the problem, that
2320         creates the json file before running the tests. I'll revert this if it doesn't fix the issue in the end.
2321
2322         * Scripts/run-webdriver-tests:
2323         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
2324         (WebDriverTestRunner.dump_results_to_json_file):
2325
2326 2018-01-30  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2327
2328         [WinCairo] Fix forwarding header conflict of WebKit on WinCairo
2329         https://bugs.webkit.org/show_bug.cgi?id=177202
2330
2331         Reviewed by Alex Christensen.
2332
2333         * CMakeLists.txt:
2334
2335 2018-01-29  Alex Christensen  <achristensen@webkit.org>
2336
2337         Clean up API after bugs 178240 and 176474
2338         https://bugs.webkit.org/show_bug.cgi?id=182259
2339
2340         Reviewed by Dan Bernstein.
2341
2342         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2343         (TEST):
2344         (-[PinnedStateObserver observeValueForKeyPath:ofObject:change:context:]):
2345
2346 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
2347
2348         [WebAuthN] Add a compile-time feature flag
2349         https://bugs.webkit.org/show_bug.cgi?id=182211
2350         <rdar://problem/36936365>
2351
2352         Reviewed by Brent Fulgham.
2353
2354         * Scripts/webkitperl/FeatureList.pm:
2355         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2356
2357 2018-01-29  Brady Eidson  <beidson@apple.com>
2358
2359         Make the API test added in r227737 be Mac-only.
2360
2361         Unreviewed gardening.
2362
2363         * TestWebKitAPI/Tests/WebKitCocoa/MessagePortProviders.mm:
2364
2365 2018-01-29  Matt Lewis  <jlewis3@apple.com>
2366
2367         Unreviewed, rolling out r227731.
2368
2369         This caused and assertion failure in API tests.
2370
2371         Reverted changeset:
2372
2373         "Layout Test fast/events/beforeunload-dom-manipulation-
2374         crash.html is crashing"
2375         https://bugs.webkit.org/show_bug.cgi?id=181204
2376         https://trac.webkit.org/changeset/227731
2377
2378 2018-01-29  Youenn Fablet  <youenn@apple.com>
2379
2380         WPT test exporter should add WebKit export in its PR description
2381         https://bugs.webkit.org/show_bug.cgi?id=182246
2382
2383         Reviewed by Chris Dumez.
2384
2385         Updating PR description body to contain the words 'WebKit export'.
2386         That way, WPT PR bot will mark the PR as reviewed downstream.
2387
2388         * Scripts/webkitpy/w3c/test_exporter.py:
2389         (TestExporter.__init__):
2390         (TestExporter.make_pull_request):
2391         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
2392         (TestExporterTest.test_export):
2393
2394 2018-01-29  Ryosuke Niwa  <rniwa@webkit.org>
2395
2396         Add the support for running Speedometer 2.0 to run-benchmark
2397         https://bugs.webkit.org/show_bug.cgi?id=182231
2398
2399         Reviewed by Antti Koivisto.
2400
2401         Made it possible to run Speedometer 2.0 using run-benchmark. To do this, this patch adds the ability to
2402         aggregate results using the differently aggregated values of subtests. In particular, Speedometer 2.0
2403         requires aggregating the geometric mean out of total time spent in each suite.
2404
2405         Also added --show-iteration-values to show individual measured values in each iteration.
2406
2407         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
2408         (BenchmarkResults.format): Added show_iteration_values as an option.
2409         (BenchmarkResults._format_tests): Ditto.
2410         (BenchmarkResults._format_values): Ditto. Added the code to show the measured values for each iteration
2411         when show_iteration_values is set to True. We don't emit the unit in each value so that the list of values
2412         is easily parsable as a JSON array.
2413         (BenchmarkResults._format_values.format_scaled): Added. A helper function.
2414         (BenchmarkResults._subtest_values_by_config_iteration): Added the support for aggregating values using
2415         the aggregated values of a subtest even when they were computed using a different aggregator if the subtest
2416         had exactly one aggregator.
2417         (BenchmarkResults._lint_results):
2418         (BenchmarkResults._lint_subtest_results): Replaced parent_needing_aggregation, which is set to the parent
2419         test's name only when the parent test had an aggregator, by self-explanatory parent_test and
2420         parent_aggregator_list.
2421         (BenchmarkResults._lint_aggregator_list): Ditto. Added raise an exception when a test has an aggregator but
2422         its subtest doesn't specify the same aggregator or it has more than one aggregators, making it ambiguous.
2423         (BenchmarkResults._lint_configuration):
2424         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py:
2425         (test_format_values_with_no_unit_scaling): Added.
2426         (test_format_values_with_iteration_values): Added.
2427         (test_format_values_with_no_unit_scaling_and_iteration_values): Added.
2428         (test_aggregate_results_from_another_aggregator): Added.
2429         (test_lint_results): Added a test case.
2430         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2431         (BenchmarkRunner.__init__): Added show_iteration_values as an argument.
2432         (BenchmarkRunner._run_benchmark): Ditto.
2433         (BenchmarkRunner.show_results): Ditto.
2434         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer2.patch: Added.
2435         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer2.plan: Added.
2436         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2437         (parse_args): Added --show-iteration-values as a boolean argument.
2438         (run_benchmark_plan): Ditto.
2439         (start): Ditto.
2440         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
2441         (WebServerBenchmarkRunner.__init__): Ditto.
2442
2443 2018-01-29  Brady Eidson  <beidson@apple.com>
2444
2445         Make it possible for apps that use both WK1 and WK2 to use MessagePorts.
2446         https://bugs.webkit.org/show_bug.cgi?id=182229
2447
2448         Reviewed by Chris Dumez.
2449
2450         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2451         * TestWebKitAPI/Tests/WebKitCocoa/MessagePortProviders.mm: Added.
2452
2453 2018-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2454
2455         WebDriver: properly recover w3c tests after a webdriver server crash
2456         https://bugs.webkit.org/show_bug.cgi?id=182242
2457
2458         Reviewed by Carlos Alberto Lopez Perez.
2459
2460         When a test makes the webdriver server crash, all other subsequent tests fail because they still try to send
2461         messages to the server, gettin connection refused errors all the time. Selenium tests handle this correctly by
2462         relaunching the server after every test failure, because other failures, even when not crashing the server,
2463         might leave it in an bad state. WPT runner does the same for test files, it uses a subprocess to run the tests
2464         and when any subtest fails, a new subsprocess is used for the following test file. We could do the same.
2465
2466         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2467         (WebDriverTestRunnerW3C.run): Restart the executor if any subtest failed.
2468         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
2469         (WebDriverW3CExecutor.__init__): Save timeout and expectations and do not import pytest.
2470         (WebDriverW3CExecutor.setup): Create a subprocess to run the tests.
2471         (WebDriverW3CExecutor.teardown): Send a message to the subprocess to terminate.
2472         (WebDriverW3CExecutor._runner): Run the tests using pytest runner.
2473         (WebDriverW3CExecutor.run): Send a message to the subprocess to run the given test and return the results message.
2474
2475 2018-01-29  Per Arne Vollan  <pvollan@apple.com>
2476
2477         Layout Test fast/events/beforeunload-dom-manipulation-crash.html is crashing
2478         https://bugs.webkit.org/show_bug.cgi?id=181204
2479         <rdar://problem/36256274>
2480
2481         Reviewed by Ryosuke Niwa.
2482
2483         Implement 'testRunner.forceImmediateCompletion()' for WK1.
2484
2485         * DumpRenderTree/TestRunner.cpp:
2486         (forceImmediateCompletionCallback):
2487         (TestRunner::staticFunctions):
2488
2489 2018-01-29  Frederic Wang  <fwang@igalia.com>
2490
2491         Unreviewed, add myself to some watch lists.
2492
2493         * Scripts/webkitpy/common/config/watchlist:
2494
2495 2018-01-27  Dan Bernstein  <mitz@apple.com>
2496
2497         HaveInternalSDK includes should be "#include?"
2498         https://bugs.webkit.org/show_bug.cgi?id=179670
2499
2500         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2501
2502 2018-01-26  Chris Dumez  <cdumez@apple.com>
2503
2504         Make sure service worker code does not launch a StorageProcess unnecessarily
2505         https://bugs.webkit.org/show_bug.cgi?id=182192
2506         <rdar://problem/36927427>
2507
2508         Reviewed by Geoffrey Garen.
2509
2510         Add API test coverage.
2511
2512         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2513
2514 2018-01-26  Chris Dumez  <cdumez@apple.com>
2515
2516         Offlined content does not work for apps on home screen
2517         https://bugs.webkit.org/show_bug.cgi?id=182070
2518         <rdar://problem/36843906>
2519
2520         Reviewed by Youenn Fablet.
2521
2522         Add API test coverage to make sure an already registered service worker is able to intercept
2523         the very first load.
2524
2525         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2526         (-[SWMessageHandlerWithExpectedMessage userContentController:didReceiveScriptMessage:]):
2527
2528 2018-01-26  Chris Nardi  <cnardi@chromium.org>
2529
2530         Addressing post-review comments after r226614
2531         https://bugs.webkit.org/show_bug.cgi?id=182151
2532
2533         Reviewed by Myles C. Maxfield.
2534
2535         * TestWebKitAPI/Tests/WTF/TextBreakIterator.cpp:
2536         (TestWebKitAPI::TEST):
2537
2538 2018-01-25  Per Arne Vollan  <pvollan@apple.com>
2539
2540         Unreviewed, rolling out r224920.
2541
2542         Some Win EWS bots are not coming back up after starting reboot.
2543
2544         * EWSTools/start-queue-win.sh:
2545
2546 2018-01-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2547
2548         WebDriver: simplify the tests json report
2549         https://bugs.webkit.org/show_bug.cgi?id=182171
2550
2551         Reviewed by Carlos Alberto Lopez Perez.
2552
2553         We are duplicating the test name in every subtest name. WPT already changed the format to remove the test name
2554         form the subtest name. We should do the same for simplicity and compatibility with WPT.
2555
2556         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
2557         (WebDriverTestRunner.dump_results_to_json_file):
2558
2559 2018-01-25  Alex Christensen  <achristensen@webkit.org>
2560
2561         REGRESSION (r221899): Web Content process hangs when webpage tries to make a new window if the WKWebView doesn’t have a UI delegate
2562         https://bugs.webkit.org/show_bug.cgi?id=182152
2563
2564         Reviewed by Joseph Pecoraro.
2565
2566         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2567         (-[NoUIDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2568         (TEST):
2569
2570 2018-01-25  Youenn Fablet  <youenn@apple.com>
2571
2572         WebPluginInfoProvider should handle null host queries
2573         https://bugs.webkit.org/show_bug.cgi?id=182112
2574
2575         Reviewed by Chris Dumez.
2576
2577         * TestWebKitAPI/Tests/WebKitCocoa/PluginLoadClientPolicies.mm:
2578         (TEST):
2579
2580 2018-01-25  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2581
2582         [webkitpy] Stop modifying path information only when running on Cygwin
2583         https://bugs.webkit.org/show_bug.cgi?id=182136
2584
2585         On LayoutTestApacheHttpd, some path configuration is modified when platform
2586         is Windows. This modification is only required for AppleWin running on Cygwin.
2587         WinCairo uses native Windows environment, so the condition should be changed.
2588
2589         Reviewed by Per Arne Vollan.
2590
2591         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2592         (LayoutTestApacheHttpd.__init__):
2593         (LayoutTestApacheHttpd._get_apache_config_file_path):
2594
2595 2018-01-25  Eric Carlson  <eric.carlson@apple.com>
2596
2597         REGRESSION(r227457): Release assert in updateLayout while destructing a media element
2598         https://bugs.webkit.org/show_bug.cgi?id=182038
2599         <rdar://problem/36812083>
2600
2601         Reviewed by Jer Noble.
2602
2603         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
2604         (TestWebKitAPI::TEST): Show/hide page so controls are always updated.
2605
2606 2018-01-24  Daniel Bates  <dabates@apple.com>
2607
2608         webkit-patch upload emits irrelevant simulator warnings
2609         https://bugs.webkit.org/show_bug.cgi?id=181702
2610         <rdar://problem/36556359>
2611
2612         Reviewed by Aakash Jain.
2613
2614         Remove warning when a person explicitly passes --child-processes with a value greater than
2615         the default number of simulator instances webkitpy would have used had --child-processes
2616         been omitted. Moreover, the placement of the warning logic to support printing such a message
2617         (in the IOSSimulatorPort constructor) caused side effects that may print other warning messages.
2618
2619         By default, webkitpy will parallelize running tests using the maximum number of simulator
2620         instances that can be supported based on available system resources at the time run-webkit-tests
2621         is invoked. It seems reasonable to assume that a person that explicitly overrides this default
2622         by specifying --child-processes knows what they are doing. The effects of picking a large
2623         value be obvious, the system may become sluggish.
2624
2625         As a side benefit of this change we no longer will emit simulator warnings whenever the iOS
2626         simulator port is instantiated by non-layout test related code (e.g. check-webkit-style).
2627
2628         * Scripts/webkitpy/port/ios_simulator.py:
2629         (IOSSimulatorPort.__init__):
2630
2631 2018-01-25  Sergio Villar Senin  <svillar@igalia.com>
2632
2633         [WebVR][GTK][WPE] Remove the WebVR public API added in r227518
2634         https://bugs.webkit.org/show_bug.cgi?id=182102
2635
2636         Reviewed by Carlos Garcia Campos.
2637
2638         * MiniBrowser/gtk/main.c:
2639         (main): Removed the call to set_enable_webvr().
2640
2641 2018-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2642
2643         WebDriver: add support for slow tests
2644         https://bugs.webkit.org/show_bug.cgi?id=182095
2645
2646         Reviewed by Carlos Alberto Lopez Perez.
2647
2648         Add timeout mark to slow tests.
2649
2650         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2651         (TestExpectationsMarker.__init__): Save the timeout.
2652         (TestExpectationsMarker.pytest_collection_modifyitems): If test is slow use timeout * 5.
2653         (run): Pass timeout to TestExpectationsMarker constructor.
2654
2655 2018-01-24  Alex Christensen  <achristensen@webkit.org>
2656
2657         Gracefully recover from NetworkProcess crashes in private browsing
2658         https://bugs.webkit.org/show_bug.cgi?id=182073
2659         <rdar://problem/36572023>
2660
2661         Reviewed by Geoff Garen.
2662
2663         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2664         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcessCrashNonPersistentDataStore.mm: Added.
2665         (-[CrashDelegate webView:didFinishNavigation:]):
2666         (-[CrashDelegate webView:didFailProvisionalNavigation:withError:]):
2667         (-[CrashDelegate webView:didFailNavigation:withError:]):
2668         (TEST):
2669
2670 2018-01-24  Ali Juma  <ajuma@chromium.org>
2671
2672         REGRESSION (r227430): ASSERTION FAILED: !self.zoomToScaleCompletionHandler in TestRunnerWKWebView::zoomToScale
2673         https://bugs.webkit.org/show_bug.cgi?id=182052
2674
2675         Reviewed by Simon Fraser.
2676
2677         Don't set zoomToScaleCompletionHandler in zoomToScale:animated when calling the completion handler
2678         immediately.
2679
2680         Test: fast/visual-viewport/viewport-dimensions.html
2681
2682         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2683         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
2684
2685 2018-01-24  Alex Christensen  <achristensen@webkit.org>
2686
2687         Remove pre-Sierra-OS-specific code in Tools
2688         https://bugs.webkit.org/show_bug.cgi?id=182034
2689
2690         Reviewed by Tim Horton.
2691
2692         * DumpRenderTree/mac/DumpRenderTree.mm:
2693         (setDefaultsToConsistentValuesForTesting):
2694         * MiniBrowser/mac/BrowserWindowController.m:
2695         (-[BrowserWindowController windowDidLoad]):
2696         (-[BrowserWindowController share:]):
2697         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2698         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:
2699         (-[EventStreamPlayer playbackTimerFired:]):
2700         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2701         * TestWebKitAPI/Tests/WebCore/FontCache.cpp: Removed.
2702         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
2703         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2704         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
2705         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2706         (WTR::InjectedBundle::platformInitialize):
2707         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2708         (WTR::initializeWebViewConfiguration):
2709
2710 2018-01-24  Alexey Proskuryakov  <ap@apple.com>
2711
2712         REGRESSION (r226485): Many new wasm leaks detected by the leaks bot
2713         https://bugs.webkit.org/show_bug.cgi?id=181400
2714         <rdar://problem/36358768>
2715
2716         Reviewed by Joseph Pecoraro.
2717
2718         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove incorrect option.
2719
2720         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (_set_up_derived_options):
2721         Always disable poisoning when running with --leaks, as this should work locally,
2722         not just on bots.
2723
2724 2018-01-24  Daniel Bates  <dabates@apple.com>
2725
2726         REGRESSION (r226138): Selecting a line that ends with zero-width joiner (ZWJ) may cause text transformation
2727         https://bugs.webkit.org/show_bug.cgi?id=181993
2728         <rdar://problem/36421080>
2729
2730         Reviewed by David Hyatt.
2731
2732         Remove unit test for overlap strategy FrontmostWithLongestEffectiveRange
2733         as we no longer support this strategy.
2734
2735         * TestWebKitAPI/Tests/WebCore/MarkerSubrange.cpp:
2736
2737 2018-01-24  David Kilzer  <ddkilzer@apple.com>
2738
2739         check-webkit-style reports false-positive whitespace/braces warning about blocks with return types as arguments in Objective-C
2740         <https://webkit.org/b/182015>
2741         <rdar://problem/36449728>
2742
2743         Reviewed by Tim Horton.
2744
2745         * Scripts/webkitpy/style/checkers/cpp.py:
2746         (regex_for_lambdas_and_blocks): Update regex to include
2747         optional return type for block argument in Objective-C.
2748         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2749         (WebKitStyleTest.test_braces): Add test.
2750
2751 2018-01-24  Ms2ger  <Ms2ger@igalia.com>
2752
2753         WPE-focused test gardening.
2754         https://bugs.webkit.org/show_bug.cgi?id=182051
2755
2756         Unreviewed test gardening.
2757
2758         * TestWebKitAPI/glib/TestExpectations.json: TestWebKitFindController failure was fixed in r227418.
2759
2760 2018-01-23  Mark Lam  <mark.lam@apple.com>
2761
2762         Update Poisoned pointers to take a Poison class instead of a uintptr_t&.
2763         https://bugs.webkit.org/show_bug.cgi?id=182017
2764         <rdar://problem/36795513>
2765
2766         Reviewed by Filip Pizlo and JF Bastien.
2767
2768         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
2769         (TestWebKitAPI::TEST):
2770         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
2771         (TestWebKitAPI::TEST):
2772         (TestWebKitAPI::passWithRef):
2773         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
2774         (TestWebKitAPI::TEST):
2775         (TestWebKitAPI::f1):
2776         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
2777         (TestWebKitAPI::TEST):
2778         (TestWebKitAPI::poisonedPtrFoo):
2779         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
2780         (TestWebKitAPI::TEST):
2781         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
2782         (TestWebKitAPI::TEST):
2783
2784 2018-01-18  Sergio Villar Senin  <svillar@igalia.com>
2785
2786         [WebVR] Add OpenVR to the tree and to the build
2787         https://bugs.webkit.org/show_bug.cgi?id=177298
2788
2789         Reviewed by Žan Doberšek.
2790
2791         * Scripts/webkitpy/style/checker.py: Added openvr to the list of third party libraries
2792         with reduced style checks.
2793
2794 2018-01-24  Chris Nardi  <cnardi@chromium.org>
2795
2796         Add Chris Nardi to contributors list
2797         https://bugs.webkit.org/show_bug.cgi?id=182029
2798
2799         Reviewed by Antti Koivisto.
2800
2801         * Scripts/webkitpy/common/config/contributors.json:
2802
2803 2018-01-22  Ryosuke Niwa  <rniwa@webkit.org>
2804
2805         Mac Sierra perf bots have been failing due to CG errors
2806         https://bugs.webkit.org/show_bug.cgi?id=181955
2807
2808         Reviewed by Antti Koivisto.
2809
2810         Ignore the CoreGraphics error messages on macOS Sierra.
2811
2812         Also added tests for ignoring lines in stdout and stderr.
2813
2814         * Scripts/webkitpy/performance_tests/perftest.py:
2815         (PerfTest.run_failed): Refactored for clarity.
2816         (PerfTest):
2817         (PerfTest.filter_ignored_lines): Added.
2818         (PerfTest._lines_to_ignore): Renamed from _lines_to_ignore_in_parser_result since these regular expressions
2819         are now used to ignore lines in other kinds of tests than parser tests.
2820         (PerfTest._errors_to_ignore_in_sierra): Added.
2821         (PerfTest._filter_output): Added the code to ignore errors only on macOS Sierra.
2822         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2823         (test_parse_output_with_ignored_stdout): Added.
2824         (test_parse_output_with_ignored_stderr): Added.
2825         (test_parse_output_with_ignored_stderr.MockPortWithSierraName): Added.
2826
2827 2018-01-23  Eric Carlson  <eric.carlson@apple.com>
2828
2829         Resign NowPlaying status when no media element is eligible
2830         https://bugs.webkit.org/show_bug.cgi?id=181914
2831         <rdar://problem/35294116>
2832
2833         Reviewed by Jer Noble.
2834
2835         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
2836         (-[NowPlayingTestWebView hasActiveNowPlayingSession]):
2837         (TestWebKitAPI::TEST):
2838         * TestWebKitAPI/Tests/WebKitCocoa/large-video-test-now-playing.html:
2839
2840 2018-01-23  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2841
2842         [WinCairo] Use 64-bit toolset
2843         https://bugs.webkit.org/show_bug.cgi?id=181979
2844
2845         Reviewed by Alex Christensen.
2846
2847         Use 64-bit toolset for 64-bit build in order to improve build time. 
2848
2849         * Scripts/webkitdirs.pm:
2850         (generateBuildSystemFromCMakeProject):
2851
2852 2018-01-23  Simon Fraser  <simon.fraser@apple.com>
2853
2854         Element with position:fixed stops scrolling at the bottom of the page, but is painted in the right place on Chacos.com.
2855         https://bugs.webkit.org/show_bug.cgi?id=181741
2856         rdar://problem/36593581
2857
2858         Reviewed by Tim Horton.
2859         
2860         If zoomToScale:animated: is called with the current zoom level, call the callback
2861         rather than doing nothing.
2862
2863         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2864         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
2865
2866 2018-01-23  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2867
2868         Add ignore_errors keyword argument to Executive.run_command() for replacing the common pattern of error_handler usage
2869         https://bugs.webkit.org/show_bug.cgi?id=180820
2870
2871         Reviewed by David Kilzer.
2872
2873         * Scripts/webkitpy/common/checkout/scm/git.py:
2874         (Git.in_working_directory):
2875         (Git.clone):
2876         (Git.read_git_config):
2877         (Git.apply_reverse_diff):
2878         * Scripts/webkitpy/common/checkout/scm/scm.py:
2879         (SCM.run):
2880         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2881         * Scripts/webkitpy/common/checkout/scm/svn.py:
2882         (SVNRepository.has_authorization_for_realm):
2883         * Scripts/webkitpy/common/net/credentials_unittest.py:
2884         * Scripts/webkitpy/common/system/abstractexecutive.py:
2885         (AbstractExecutive.run_command):
2886         * Scripts/webkitpy/common/system/executive.py:
2887         (Executive.kill_process.is):
2888         (Executive.running_pids):
2889         (Executive.kill_all):
2890         (Executive.run_command):
2891         * Scripts/webkitpy/common/system/executive_mock.py:
2892         (MockExecutive.run_command):
2893         (MockExecutive2.run_command):
2894         * Scripts/webkitpy/common/system/executive_unittest.py:
2895         (ExecutiveTest.test_run_command_with_bad_command.run_bad_command):
2896         * Scripts/webkitpy/common/system/platforminfo.py:
2897         (PlatformInfo.xcode_sdk_version):
2898         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2899         (Lighttpd._check_and_kill):
2900         * Scripts/webkitpy/port/base.py:
2901         (Port._symbols_string):
2902         * Scripts/webkitpy/port/gtk.py:
2903         (GtkPort.setup_environ_for_server):
2904         * Scripts/webkitpy/port/win.py:
2905         (WinPort._runtime_feature_list):
2906         (WinPort.read_registry_value):
2907         * Scripts/webkitpy/port/win_unittest.py:
2908         (WinPortTest.test_runtime_feature_list):
2909         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
2910         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
2911
2912 2018-01-23  Commit Queue  <commit-queue@webkit.org>
2913
2914         Unreviewed, rolling out r227279 and r227373.
2915         https://bugs.webkit.org/show_bug.cgi?id=181988
2916
2917         The LayoutTest crash fix introduced an API test failure.
2918         (Requested by ryanhaddad on #webkit).
2919
2920         Reverted changesets:
2921
2922         "Resign NowPlaying status when no media element is eligible"
2923         https://bugs.webkit.org/show_bug.cgi?id=181914
2924         https://trac.webkit.org/changeset/227279
2925
2926         "Resign NowPlaying status when no media element is eligible"
2927         https://bugs.webkit.org/show_bug.cgi?id=181914
2928         https://trac.webkit.org/changeset/227373
2929
2930 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2931
2932         Unreviewed. Add test case for slow in test_expectations.py.
2933
2934         I forgot to also check slow tests in test_expectations.py unit tests.
2935
2936         * Scripts/webkitpy/common/test_expectations_unittest.py:
2937         (assert_slow):
2938         (test_build_type):
2939         (test_slow):
2940
2941 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2942
2943         Unreviewed. Mark test WTF_Lock.ManyContendedShortSections as slow.
2944
2945         * TestWebKitAPI/glib/TestExpectations.json:
2946
2947 2018-01-22  Ryosuke Niwa  <rniwa@webkit.org>
2948
2949         Blob conversion and sanitization doesn't work with Microsoft Word for Mac 2011
2950         https://bugs.webkit.org/show_bug.cgi?id=181616
2951         <rdar://problem/36484908>
2952
2953         Reviewed by Wenson Hsieh.
2954
2955         Added tests to make sure we sanitize plain HTML, not just web archives,
2956         when and only when custom pasteboard data is enabled.
2957
2958         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2959         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm: Added.
2960         (writeHTMLToPasteboard): Added.
2961         (createWebViewWithCustomPasteboardDataSetting): Added.
2962
2963 2018-01-22  Alexey Proskuryakov  <ap@apple.com>
2964
2965         REGRESSION (r226485): Many new wasm leaks detected by the leaks bot
2966         https://bugs.webkit.org/show_bug.cgi?id=181400
2967         rdar://problem/36358768
2968
2969         Reviewed by JF Bastien.
2970
2971         * BuildSlaveSupport/build.webkit.org-config/config.json: Disable poisoning on the leaks bot.
2972
2973 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2974
2975         [GTK] Test /webkit/WebKitWebsiteData/resource-load-statistics is failing since r227223
2976         https://bugs.webkit.org/show_bug.cgi?id=181929
2977
2978         Reviewed by Michael Catanzaro.
2979
2980         The test is checking that the resource load stats file is deleted after clearing website data. Since r227223,
2981         the website data completion callback is not called immediately, and a new file is created when the operation
2982         finishes. We need to check that the file was removing after calling clear.
2983
2984         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
2985         (fileChangedCallback):
2986         (testWebsiteDataResourceLoadStatistics):
2987
2988 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2989
2990         Reviewed GTK gardening. Mark /webkit/WebKitWebView/mouse-target as fail too.
2991
2992         * TestWebKitAPI/glib/TestExpectations.json:
2993
2994 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2995
2996         Unreviewed GTK+ gardening. Fix /webkit/WebKitConsoleMessage/network-error.
2997
2998         Partially revert r226782, the fix was wrong for the GLib version we currently use.
2999
3000         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
3001         (testWebKitConsoleMessageNetworkError):
3002
3003 2018-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3004
3005         Unreviewed. Remove unused verbose mode from GLib API tests runner.
3006
3007         * glib/api_test_runner.py:
3008         (add_options):
3009
3010 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3011
3012         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
3013         https://bugs.webkit.org/show_bug.cgi?id=181918
3014
3015         Reviewed by Tim Horton.
3016
3017         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
3018
3019         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3020
3021 2018-01-21  Eric Carlson  <eric.carlson@apple.com>
3022
3023         Resign NowPlaying status when no media element is eligible
3024         https://bugs.webkit.org/show_bug.cgi?id=181914
3025         <rdar://problem/35294116>
3026
3027         Reviewed by Jer Noble.
3028
3029         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
3030         (-[NowPlayingTestWebView hasActiveNowPlayingSession]):
3031         (TestWebKitAPI::TEST):
3032         * TestWebKitAPI/Tests/WebKitCocoa/large-video-test-now-playing.html:
3033
3034 2018-01-21  Aakash Jain  <aakash_jain@apple.com>
3035
3036         Fix broken unit-tests after r227192
3037         https://bugs.webkit.org/show_bug.cgi?id=181909
3038
3039         Reviewed by Carlos Garcia Campos.
3040
3041         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3042
3043 2018-01-20  Chris Dumez  <cdumez@apple.com>
3044
3045         API test URLSchemeHandler.Leaks1 is timing out on iOS simulator debug
3046         https://bugs.webkit.org/show_bug.cgi?id=174984
3047         <rdar://problem/33665676>
3048
3049         Reviewed by Alexey Proskuryakov.
3050
3051         Disable URLSchemeHandler.Leaks1 API test on iOS as it sometimes times out.
3052
3053         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-leaks.mm:
3054         (TEST):
3055
3056 2018-01-20  Brian Burg  <bburg@apple.com>
3057
3058         WebDriver: fix some nits that prevent running W3C tests on Mac
3059         https://bugs.webkit.org/show_bug.cgi?id=181864
3060
3061         Reviewed by Carlos Garcia Campos.
3062
3063         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
3064         (WebDriverW3CWebServer.__init__): _wsout needs to always be defined,
3065         as we assume that the property exists later.
3066
3067         (WebDriverW3CWebServer.stop): If the temporary file doesn't
3068         exist for some reason, the remove call will raise and exception.
3069         Gracefully handle the case where the file isn't created due to
3070         a problem/exception that happened elsewhere.
3071
3072 2018-01-19  Ling Ho  <lingcherd_ho@apple.com>
3073
3074         Move Bingdings EWS and Webkitpy EWS queues to High Sierra on buildbot dashboard.
3075         https://bugs.webkit.org/show_bug.cgi?id=181881
3076
3077         Reviewed by Alexey Proskuryakov.
3078
3079         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3080         (BubbleQueueServer):
3081         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3082         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3083         (table.queue-grid tr.platform.mac-os-x-elcapitan img.logo): Deleted.
3084
3085 2018-01-19  Youenn Fablet  <youenn@apple.com>
3086
3087         Do not go to the storage process when registering a service worker client if there is no service worker registered
3088         https://bugs.webkit.org/show_bug.cgi?id=181740
3089         <rdar://problem/36650400>
3090
3091         Reviewed by Chris Dumez.
3092
3093         Add support for internals inside API tests.
3094
3095         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3096         * TestWebKitAPI/Tests/InjectInternals_Bundle.cpp: Added.
3097         (TestWebKitAPI::InternalsInjectedBundleTest::InternalsInjectedBundleTest):
3098         (TestWebKitAPI::InternalsInjectedBundleTest::initialize):
3099         (TestWebKitAPI::InternalsInjectedBundleTest::didCreatePage):
3100         (TestWebKitAPI::InternalsInjectedBundleTest::didClearWindowForFrame):
3101         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3102         (setConfigurationInjectedBundlePath):
3103         (-[RegularPageMessageHandler userContentController:didReceiveScriptMessage:]):
3104
3105 2018-01-19  John Wilander  <wilander@apple.com>
3106
3107         Resource Load Statistics: Implement callback support for removal of WebsiteDataType::ResourceLoadStatistics
3108         https://bugs.webkit.org/show_bug.cgi?id=181822
3109         https://bugs.webkit.org/show_bug.cgi?id=175263
3110         https://bugs.webkit.org/show_bug.cgi?id=178536
3111         https://bugs.webkit.org/show_bug.cgi?id=181223
3112         https://bugs.webkit.org/show_bug.cgi?id=181482
3113         <rdar://problem/33491222>
3114         <rdar://problem/33805293>
3115         <rdar://problem/36332683>
3116         <rdar://problem/36549026>
3117
3118         Reviewed by Alex Christensen.
3119
3120         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3121         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3122         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
3123         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
3124         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3125         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3126         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
3127         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
3128
3129 2018-01-19  Jonathan Bedard  <jbedard@apple.com>
3130
3131         run-webkit-tests fails when there is a curly brace in Xcode build output
3132         https://bugs.webkit.org/show_bug.cgi?id=181254
3133         <rdar://problem/36453374>
3134
3135         Reviewed by Daniel Bates.
3136
3137         * Scripts/webkitpy/port/base.py:
3138         (Port._run_script): Encode script output before logging it.
3139
3140 2018-01-19  Chris Dumez  <cdumez@apple.com>
3141
3142         Service worker registrations restored from disk may not be reused when the JS calls register() again
3143         https://bugs.webkit.org/show_bug.cgi?id=181810
3144         <rdar://problem/36591711>
3145
3146         Reviewed by Youenn Fablet.
3147
3148         Add API test coverage.
3149
3150         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3151         (-[SWMessageHandlerForRestoreFromDiskTest initWithExpectedMessage:]):
3152         (-[SWMessageHandlerForRestoreFromDiskTest userContentController:didReceiveScriptMessage:]):
3153
3154 2018-01-19  Ryan Haddad  <ryanhaddad@apple.com>
3155
3156         Remove El Capitan queues from flakiness dashboard
3157         https://bugs.webkit.org/show_bug.cgi?id=181860
3158
3159         Reviewed by Aakash Jain.
3160
3161         * TestResultServer/static-dashboards/builders.jsonp:
3162
3163 2018-01-19  Keith Miller  <keith_miller@apple.com>
3164
3165         HaveInternalSDK includes should be "#include?"
3166         https://bugs.webkit.org/show_bug.cgi?id=179670
3167
3168         Reviewed by Dan Bernstein.
3169
3170         * MiniBrowser/Configurations/Base.xcconfig:
3171         * MobileMiniBrowser/Configurations/Base.xcconfig:
3172         * TestWebKitAPI/Configurations/Base.xcconfig:
3173         * WebKitTestRunner/Configurations/Base.xcconfig:
3174
3175 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3176
3177         WebDriver: driver environment not passed to pytest when running w3c tests
3178         https://bugs.webkit.org/show_bug.cgi?id=181852
3179
3180         Reviewed by Carlos Alberto Lopez Perez.
3181
3182         That's why color codes are not used in the bots log for selenium tests but they appear in w3c tests.
3183
3184         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
3185         (WebDriverW3CExecutor.run):
3186
3187 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3188
3189         [GTK] WebDriver: wayland display no used in wayland bot
3190         https://bugs.webkit.org/show_bug.cgi?id=181851
3191
3192         Reviewed by Carlos Alberto Lopez Perez.
3193
3194         We need to handle the additionalArguments property in the WebDriverTests step.
3195
3196         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3197         (RunWebDriverTests.start):
3198
3199 2018-01-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3200
3201         [GTK] TERM environment variable is not passed to the test driver.
3202         https://bugs.webkit.org/show_bug.cgi?id=181847
3203
3204         Rubber-stamped by by Carlos Garcia Campos.
3205
3206         * Scripts/webkitpy/port/base.py:
3207         (Port.to.setup_environ_for_server):
3208
3209 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3210
3211         WebDriver: run-webdriver-tests is crashing in the bots when creating results json file
3212         https://bugs.webkit.org/show_bug.cgi?id=181844
3213
3214         Reviewed by Carlos Alberto Lopez Perez.
3215
3216         We always try to create the directory where to store the json file, but when the filename is given directly,
3217         like in the bots, the current dir is used.
3218
3219         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
3220         (WebDriverTestRunner.dump_results_to_json_file): Do not try to create the directory if dirname() returns an
3221         empty string.
3222
3223 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3224
3225         [GTK] WebDriver tests are running outside the jhbuild env
3226         https://bugs.webkit.org/show_bug.cgi?id=181842
3227
3228         Reviewed by Žan Doberšek.
3229
3230         We need to enter jhbuild env in run-webdriver-tests.
3231
3232         * Scripts/run-webdriver-tests:
3233
3234 2018-01-18  Carlos Garcia Campos  <cgarcia@igalia.com>
3235
3236         [GTK] Run WebDriver tests in the bots
3237         https://bugs.webkit.org/show_bug.cgi?id=181787
3238
3239         Reviewed by Michael Catanzaro.
3240
3241         Add a step to run WebDriver tests in the GTK test bots. The new step is not GTK specific, but only added to the
3242         factory for the GTK port for now.
3243
3244         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3245         (TestFactory.__init__):
3246         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3247         (RunWebDriverTests):
3248         (RunWebDriverTests.start):
3249         (RunWebDriverTests.commandComplete):
3250         (RunWebDriverTests.evaluateCommand):
3251         (RunWebDriverTests.getText):
3252         (RunWebDriverTests.getText2):
3253
3254 2018-01-18  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3255
3256         [WinCairo] Pass correct url for http test to test driver.
3257         https://bugs.webkit.org/show_bug.cgi?id=181814
3258
3259         Reviewed by Alex Christensen.
3260
3261         * Scripts/webkitpy/port/driver.py:
3262         (Driver):
3263         (Driver.http_test_path_to_uri):
3264         (Driver.is_secure_path):
3265         (Driver.http_base_url):
3266         (Driver.uri_to_test):
3267
3268 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
3269
3270         Unreviewed, update the triggerable name for 'sierra-release-perf-tests'
3271
3272         * BuildSlaveSupport/build.webkit.org-config/config.json:
3273
3274 2018-01-18  Dan Bernstein  <mitz@apple.com>
3275
3276         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
3277         https://bugs.webkit.org/show_bug.cgi?id=181803
3278
3279         Reviewed by Tim Horton.
3280
3281         * DumpRenderTree/mac/Configurations/Base.xcconfig: Updated.
3282         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Ditto.
3283         * ImageDiff/cg/Configurations/Base.xcconfig: Ditto.
3284         * ImageDiff/cg/Configurations/DebugRelease.xcconfig: Ditto.
3285         * MiniBrowser/Configurations/Base.xcconfig: Ditto.
3286         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
3287         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
3288         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
3289         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals
3290           helpers.
3291         * TestWebKitAPI/Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build
3292           settings useful for defining settings that depend on the target macOS version.
3293         * WebKitTestRunner/Configurations/Base.xcconfig: Updated.
3294         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Updated.
3295
3296 2018-01-18  Ling Ho  <lingcherd_ho@apple.com>
3297
3298         Remove Opensource El Capitan queues from buildbot
3299         https://bugs.webkit.org/show_bug.cgi?id=181712
3300
3301         Reviewed by Aakash Jain.
3302
3303         * BuildSlaveSupport/build.webkit.org-config/config.json:
3304         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3305         (WebKitBuildbot):
3306         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3307
3308 2018-01-18  Chris Dumez  <cdumez@apple.com>
3309
3310         Service Workers restored from persistent storage have 'redundant' state
3311         https://bugs.webkit.org/show_bug.cgi?id=181749
3312         <rdar://problem/36556486>
3313
3314         Reviewed by Youenn Fablet.
3315
3316         Add API test coverage.
3317
3318         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3319         (-[SWMessageHandlerForFetchTest userContentController:didReceiveScriptMessage:]):
3320
3321 2018-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
3322
3323         [GTK] AX: Two layout tests crash with error 'g_strstr_len: assertion 'haystack != NULL' failed' in Accessibility::UIElement::url
3324         https://bugs.webkit.org/show_bug.cgi?id=176796
3325
3326         Reviewed by Chris Fleizach.
3327
3328         Add sanity check that we have a URL before calling g_strstr_len().
3329
3330         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3331         (WTR::AccessibilityUIElement::url):
3332
3333 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
3334
3335         Add triggers for Sierra test262 and perf queues
3336         https://bugs.webkit.org/show_bug.cgi?id=181799
3337
3338         Reviewed by Aakash Jain.
3339
3340         * BuildSlaveSupport/build.webkit.org-config/config.json:
3341
3342 2018-01-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3343
3344         [iOS] Specify -[NSURL _title] for the associated URL when copying an image element
3345         https://bugs.webkit.org/show_bug.cgi?id=181783
3346         <rdar://problem/35785445>
3347
3348         Reviewed by Ryosuke Niwa.
3349
3350         Augments an existing API test and adds a new test to make sure that the resulting NSItemProvider's NSURL when
3351         copying an image contains a relevant title.
3352
3353         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
3354         (TestWebKitAPI::TEST):
3355         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3356         * TestWebKitAPI/ios/UIKitSPI.h:
3357
3358 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3359
3360         WebDriver: ignore the driver in selenium test names when getting expectations
3361         https://bugs.webkit.org/show_bug.cgi?id=181738
3362
3363         Reviewed by Carlos Alberto Lopez Perez.
3364
3365         In selenium tests, the driver is added as a parameter to every test which results in tests names like
3366         foo[DriverName] or foo[DriverName-param2] in case of tests using more parameters. We don't want to include the
3367         driver name in the test expectations file, so we need to remove it when querying the expectations.
3368
3369         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
3370         (TestExpectationsMarker.__init__): Save the param to ignore.
3371         (TestExpectationsMarker._item_name): Return the name of the test without the para to ignore.
3372         (TestExpectationsMarker.pytest_collection_modifyitems): Use _item_name().
3373         (run): Pass param to ignore to TestExpectationsMarker().
3374         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
3375         (WebDriverSeleniumExecutor.__init__): Save the driver name.
3376         (WebDriverSeleniumExecutor.run): Pass the driver name as param to ignore.
3377
3378 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3379
3380         [GTK][WPE] Show unit tests unexpectedly passing in the bots
3381         https://bugs.webkit.org/show_bug.cgi?id=181726
3382
3383         Reviewed by Michael Catanzaro.
3384
3385         Now that we have the info, let's show it also in the bots.
3386
3387         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3388         (RunGLibAPITests.commandComplete):
3389
3390 2018-01-17  Ling Ho  <lingcherd_ho@apple.com>
3391
3392         Fix broken unittest after r227048
3393         https://bugs.webkit.org/show_bug.cgi?id=181760
3394
3395         Reviewed by Aakash Jain.
3396
3397
3398 2018-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
3399
3400         WEBKIT_FRAMEWORK should not modify file-global include directories
3401         https://bugs.webkit.org/show_bug.cgi?id=181656
3402
3403         Reviewed by Konstantin Tokarev.
3404
3405         * TestWebKitAPI/PlatformWPE.cmake:
3406         * TestWebKitAPI/glib/CMakeLists.txt:
3407
3408 2018-01-17  Alicia Boya García  <aboya@igalia.com>
3409
3410         Unreviewed, mark Alicia as committer in contributors.json
3411
3412         * Scripts/webkitpy/common/config/contributors.json:
3413
3414 2018-01-17  Youenn Fablet  <youenn@apple.com>
3415
3416         Put fetch Request.keepalive behind a runtime flag
3417         https://bugs.webkit.org/show_bug.cgi?id=181592
3418
3419         Reviewed by Chris Dumez.
3420
3421         * DumpRenderTree/mac/DumpRenderTree.mm:
3422         (enableExperimentalFeatures):
3423         * DumpRenderTree/win/DumpRenderTree.cpp:
3424         (enableExperimentalFeatures):
3425         * WebKitTestRunner/TestController.cpp:
3426         (WTR::TestController::resetPreferencesToConsistentValues):
3427
3428 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3429
3430         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
3431         https://bugs.webkit.org/show_bug.cgi?id=181637
3432         <rdar://problem/36508471>
3433
3434         Reviewed by Tim Horton.
3435
3436         Add 2 new API tests to exercise injected bundle SPI for supplying replacement URLs when pasting an image, and an
3437         attributed string containing multiple NSTextAttachments. See WebKit and WebCore ChangeLogs for more detail.
3438
3439         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
3440         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3441         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]):
3442
3443         Implement the new Objective-C bundle SPI to look up the incoming MIME type in the dictionary supplied via the
3444         "MIMETypeToReplacementURLMap" bundle initialization parameter, and return it.
3445
3446         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3447         (webViewForTestingAttachments):
3448         (-[TestWKWebView tagsInBody]):
3449         (-[TestWKWebView expectElementTagsInOrder:]):
3450         (-[TestWKWebView expectElementTag:toComeBefore:]):
3451
3452         Add a test helper to check that the given list of element tags appears in the document body. Also, reimplement
3453         the existing -expectElementTag:toComeBefore: as a special case of -expectElementTagsInOrder:.
3454
3455         (TestWebKitAPI::TEST):
3456         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3457         (WTR::InjectedBundlePage::InjectedBundlePage):
3458
3459 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3460
3461         WebDriver: add support for test expectations
3462         https://bugs.webkit.org/show_bug.cgi?id=180420
3463
3464         Reviewed by Carlos Alberto Lopez Perez.
3465
3466         Add support for parsing test expectations from a JSON file and mark tests on collection accordingly.
3467
3468         * Scripts/run-webdriver-tests: Get the retval from process_results().
3469         * Scripts/webkitpy/thirdparty/__init__.py:
3470         (AutoinstallImportHook._install_pytest): Install also py because pytest needs it.
3471         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
3472         (TestExpectationsMarker): Plugin to mark tests based on given expectations.
3473         (TestExpectationsMarker.__init__): Initialize expectations.
3474         (TestExpectationsMarker.pytest_collection_modifyitems): Mark tests if needed,
3475         (run): Create and use TestExpectationsMarker plugin.
3476         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
3477         (WebDriverSeleniumExecutor.run): Pass expectations to pytest_runner.
3478         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
3479         (WebDriverTestRunner.__init__): Create a TestExpectations and pass it to the runners.
3480         (WebDriverTestRunner.run): Do not count results here.
3481         (WebDriverTestRunner.process_results): Rename print_results() as process_results() since it now returns the
3482         amount of failures. Printing the test summary while processing results will be made optional in a follow up
3483         patch.
3484         (WebDriverTestRunner.process_results.report): Return the amount of failures.
3485         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
3486         (WebDriverTestRunnerSelenium.__init__): Initialize _expectations.
3487         (WebDriverTestRunnerSelenium.collect_tests): Do not include skipped tests.
3488         (WebDriverTestRunnerSelenium.run): Stop returning the tests count.
3489         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
3490         (WebDriverTestRunnerW3C.__init__): Initialize _expectations.
3491         (WebDriverTestRunnerW3C.collect_tests): Do not include skipped tests.
3492         (WebDriverTestRunnerW3C._scan_directory): Ditto.
3493         (WebDriverTestRunnerW3C.run): Stop returning the tests count.
3494         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
3495         (WebDriverW3CExecutor.run): Pass expectations to pytest_runner.
3496
3497 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3498
3499         Unreviewed WPE gardening. Mark some known unit test failures.
3500
3501         * TestWebKitAPI/glib/TestExpectations.json:
3502
3503 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3504
3505         [GTK][WPE] Use the same subtest names in GTK and WPE unit tests
3506         https://bugs.webkit.org/show_bug.cgi?id=181724
3507
3508         Reviewed by Philippe Normand.
3509
3510         We currently use /webkit2/foo/bar for GTK and /wpe/foo/bar for WPE. Many of the tests are common, so there's no
3511         reason to use different names. This way we can refer to the same test names for both and we can share the
3512         expectations in the TestExpectations.json file.
3513
3514         * TestWebKitAPI/glib/TestExpectations.json:
3515         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Use /webkit/foo/bar in GTK and WPE.
3516
3517 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3518
3519         Unreviewed. Increase the slow timeout of GTK and WPE unit tests.
3520
3521         We are using now a lower default timeout, so multiplying by 5 is no longer enough for some of the WTF
3522         tests. Multiply by 10 so that we get the same slow timeout as before, 50.
3523
3524         * glib/api_test_runner.py:
3525         (TestRunner._run_test_glib):
3526         (TestRunner._run_google_test):
3527
3528 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3529
3530         [GTK] Duplicated symbols in libjavascriptcoregtk and libwebkit2gtk can cause crashes in production builds
3531         https://bugs.webkit.org/show_bug.cgi?id=179914
3532
3533         Reviewed by Žan Doberšek.
3534
3535         Add two scripts to be run by dist-check step when releasing. One is to detect symbols duplicated in
3536         libjavascriptcoregtk and libwebkit2gtk that should be included to the version script. The other one is to ensure
3537         all symbols listed in the script are present in the library.
3538
3539         * Scripts/check-for-global-bss-symbols-in-webkigtk-libs: Added.
3540         (bss_symbols):
3541         * Scripts/check-for-invalid-symbols-in-version-script: Added.
3542         (script_symbols):
3543         * Scripts/make-dist:
3544         (Distcheck.build):
3545         (Distcheck):
3546         (Distcheck.check_symbols):
3547         (Distcheck.check):
3548
3549 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3550
3551         [GTK][WPE] Propagate the parameters when restarting glib api tests after a crash
3552         https://bugs.webkit.org/show_bug.cgi?id=181722
3553
3554         Reviewed by Žan Doberšek.
3555
3556         I forgot to pass the parameters to run() when restarting.
3557
3558         * glib/glib_test_runner.py:
3559         (GLibTestRunner.run):
3560
3561 2018-01-16  Fujii Hironori  <Hironori.Fujii@sony.com>
3562
3563         [CMake] Remove WebCoreDerivedSources library target
3564         https://bugs.webkit.org/show_bug.cgi?id=181664
3565
3566         Reviewed by Carlos Garcia Campos.
3567
3568         * TestWebKitAPI/PlatformWPE.cmake: Do not link WebCoreDerivedSources.
3569         * TestWebKitAPI/PlatformWin.cmake: Ditto.
3570
3571 2018-01-16  Ling Ho  <lingcherd_ho@apple.com>
3572
3573         Move Debug Test262, Release Test262 and Performance queues to Sierra
3574         https://bugs.webkit.org/show_bug.cgi?id=181692
3575
3576         Unreviewed
3577
3578 2018-01-16  Zach Li  <zachli@apple.com>
3579
3580         Add pop-up policy support in website policies.
3581         https://bugs.webkit.org/show_bug.cgi?id=181544.
3582         rdar://problem/30521400.
3583
3584         Reviewed by Alex Christensen.
3585
3586         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3587         Added pop-up-check.html.
3588
3589         * TestWebKitAPI/Tests/WebKit/pop-up-check.html: Added.
3590
3591         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3592         (-[PopUpPoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3593         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
3594         (-[PopUpPoliciesDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3595         (TEST):
3596
3597 2018-01-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3598
3599         [Attachment Support] Provide the `src` of an attachment to the UI delegate when an attachment is inserted
3600         https://bugs.webkit.org/show_bug.cgi?id=181638
3601         <rdar://problem/36508702>
3602
3603         Reviewed by Dan Bernstein.
3604
3605         Tweak an existing API test to check that the `src` of an attachment element inserted via script matches the
3606         `source` provided to the UI delegate via -[WKUIDelegate _webView:didInsertAttachment:withSource:].
3607
3608         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3609         (-[AttachmentUpdateObserver init]):
3610         (-[AttachmentUpdateObserver sourceForIdentifier:]):
3611         (-[AttachmentUpdateObserver _webView:didInsertAttachment:withSource:]):
3612         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::expectSourceForIdentifier):
3613         (TestWebKitAPI::TEST):
3614         (-[AttachmentUpdateObserver _webView:didInsertAttachment:]): Deleted.
3615
3616 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
3617
3618         Unreviewed. Fix GTK unit tests execution in the bots after r226967.
3619
3620         I forgot to pass the environment to the GLibTestRunner and Xvfb was not used in the bots.
3621
3622         * glib/api_test_runner.py:
3623         (TestRunner._run_test_glib): Pass env to GLibTestRunner.
3624         * glib/glib_test_runner.py:
3625         (GLibTestRunner.run): Use given env.
3626
3627 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
3628
3629         [GTK][WPE] Stop passing --verbose to run-api-tests from the bots
3630         https://bugs.webkit.org/show_bug.cgi?id=181676
3631
3632         Reviewed by Carlos Alberto Lopez Perez.
3633
3634         The option was removed in r226967.
3635
3636         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3637         (RunGtkAPITests):
3638         (RunWPEAPITests):
3639
3640 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
3641
3642         Unreviewed. Temporarily bring back --verbose option of api_test_runner.py.
3643
3644         The bots are still pa