ef002f4b4894fdd9871244c8da02b895bca68dc4
[WebKit-https.git] / Tools / ChangeLog
1 2015-04-09  Joseph Pecoraro  <pecoraro@apple.com>
2
3         Flakiness Dashboard not loading insecure content if loaded with https URL
4         https://bugs.webkit.org/show_bug.cgi?id=143570
5
6         Reviewed by Alexey Proskuryakov.
7
8         * TestResultServer/app.yaml:
9         * TestResultServer/static-dashboards/loader.js:
10         Switch to https scheme.
11
12 2015-04-09  Csaba Osztrogonác  <ossy@webkit.org>
13
14         [EFL][GTK] WebKit2's generate-forwarding-headers.pl runs too many times
15         https://bugs.webkit.org/show_bug.cgi?id=142907
16
17         Reviewed by Carlos Garcia Campos.
18
19         * TestWebKitAPI/PlatformEfl.cmake:
20         * TestWebKitAPI/PlatformGTK.cmake:
21         * WebKitTestRunner/PlatformEfl.cmake:
22         * WebKitTestRunner/PlatformGTK.cmake:
23
24 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
25
26         [Mac] Unreviewed test fix after r182584
27         https://bugs.webkit.org/show_bug.cgi?id=143452
28
29         Put both of these tests back to their original state now that the underlying
30         problem is fixed.
31
32         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
33         (TestWebKitAPI::TEST):
34         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
35         (TestWebKitAPI::TEST):
36
37 2015-04-08  Filip Pizlo  <fpizlo@apple.com>
38
39         run-jsc-benchmarks geomean of preferred means shouldn't print the VMs header twice
40         https://bugs.webkit.org/show_bug.cgi?id=143553
41
42         Reviewed by Ryosuke Niwa.
43         
44         Remove the spurious printVMs left over from an earlier change.
45
46         * Scripts/run-jsc-benchmarks:
47
48 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
49
50         [Mac] Unreviewed test fix after r182581
51
52         The behavior of control-left-click is controlled by a system preference.
53         Our test bots have this turned off.
54
55         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
56         (TestWebKitAPI::TEST):
57         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
58         (TestWebKitAPI::TEST):
59
60 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
61
62         [Mac] WebKit is not honoring OS preferences for secondary click behaviors
63         https://bugs.webkit.org/show_bug.cgi?id=143452
64         <rdar://problem/20437483>
65
66         Reviewed by Tim Horton.
67
68         Add a new API test to confirm that Cocoa mouse button press events are properly
69         tagged with the desired menu behavior (i.e., 'None', 'Context', or 'Action'.)
70
71         The WK2 test dispatches mouse down events to a PlatformWebView, and checks with
72         some registered event handlers that the expected button press and context menu
73         events are received.
74
75         The WK1 unit test creates an NSEvent with the desired button press state, and then
76         uses WebCore::PlatformEventFactory::createPlatformMouseEvent to create a WebCore event.
77         We check the resulting PlatformMouseEvent for proper state.
78
79         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test files.
80         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp: Added.
81         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
82         * TestWebKitAPI/Tests/WebKit2/mouse-button-listener.html: Added.
83         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm: Added.
84         (TestWebKitAPI::canCallMenuTypeForEvent): Helper function.
85         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
86         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
87         (TestWebKitAPI::PlatformWebView::simulateButtonClick): Added method to support firing
88         mouse down events.
89         * TestWebKitAPI/mac/PlatformWebViewMac.h:
90
91 2015-04-08  Michael Catanzaro  <mcatanzaro@igalia.com>
92
93         [GTK] Add pango to jhbuild-optional.modules
94         https://bugs.webkit.org/show_bug.cgi?id=143537
95
96         Reviewed by Martin Robinson.
97
98         * gtk/jhbuild-optional.modules: Add pango.
99
100 2015-04-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
101
102         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 22.
103         https://bugs.webkit.org/show_bug.cgi?id=143530
104
105         Reviewed by Žan Doberšek.
106
107         Assume that the default value for display (:0) is reserved and start checking on :1
108         Adjust webkitpy test and include two new test cases for this bug (display number not specified)
109         and for X server named Xorg.bin (previous bug 1376599)
110
111         * Scripts/webkitpy/port/xvfbdriver.py:
112         (XvfbDriver._next_free_display)
113         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
114         (XvfbDriverTest.test_start_no_pixel_tests):
115         (XvfbDriverTest.test_start_pixel_tests):
116         (XvfbDriverTest.test_start_arbitrary_worker_number):
117         (XvfbDriverTest.test_next_free_display):
118         (XvfbDriverTest.test_start_next_worker):
119 2015-04-08  Alex Christensen  <achristensen@webkit.org>
120
121         Block popups from content extensions.
122         https://bugs.webkit.org/show_bug.cgi?id=143497
123
124         Reviewed by Brady Eidson.
125
126         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
127         (TestWebKitAPI::TEST_F):
128         Added popup test.
129
130 2015-04-08  Alex Christensen  <achristensen@webkit.org> and Patrick Gansterer  <paroga@webkit.org>
131
132         Add CMake build system for WinCairo port.
133         https://bugs.webkit.org/show_bug.cgi?id=115944
134
135         Reviewed by Chris Dumez.
136
137         * CMakeLists.txt:
138         * WinLauncher/CMakeLists.txt: Added.
139
140 2015-04-08  Carlos Garcia Campos  <cgarcia@igalia.com>
141
142         [GTK] Crash in DOMObjectCache when a wrapped object owned by the cache is unreffed by the user
143         https://bugs.webkit.org/show_bug.cgi?id=143521
144
145         Reviewed by Martin Robinson.
146
147         Add a way to detect unexpected web process crashes to WebViewTest,
148         and a test case to testDOMCache to trigger the crash.
149
150         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
151         (WebKitDOMNodeTest::testDOMCache):
152         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
153         (testWebKitWebViewProcessCrashed):
154         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
155         (WebViewTest::WebViewTest):
156         (WebViewTest::webProcessCrashed):
157         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
158
159 2015-04-07  Alexey Proskuryakov  <ap@apple.com>
160
161         PageVisibilityStateWithWindowChanges should only be enabled on Yosemite
162         rdar://problem/20461342
163
164         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
165
166 2015-04-07  Commit Queue  <commit-queue@webkit.org>
167
168         Unreviewed, rolling out r182511.
169         https://bugs.webkit.org/show_bug.cgi?id=143507
170
171         caused debug test failures (Requested by alexchristensen on
172         #webkit).
173
174         Reverted changeset:
175
176         "Block popups from content extensions."
177         https://bugs.webkit.org/show_bug.cgi?id=143497
178         http://trac.webkit.org/changeset/182511
179
180 2015-04-07  Alex Christensen  <achristensen@webkit.org>
181
182         Block popups from content extensions.
183         https://bugs.webkit.org/show_bug.cgi?id=143497
184
185         Reviewed by Brady Eidson.
186
187         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
188         (TestWebKitAPI::TEST_F):
189         Added popup test.
190
191 2015-04-07  Benjamin Poulain  <benjamin@webkit.org>
192
193         Get the features.json files ready for open contributions
194         https://bugs.webkit.org/show_bug.cgi?id=143436
195
196         Reviewed by Darin Adler.
197
198         * Scripts/webkitpy/style/checkers/jsonchecker.py:
199         (JSONFeaturesChecker.check):
200         Extend the syntax checking a bit, but leave everything non-mandatory
201         very loose until we figure what fields are important.
202
203 2015-04-07  Tim Horton  <timothy_horton@apple.com>
204
205         Expose and test fixedLayoutSize via modern WebKit SPI
206         https://bugs.webkit.org/show_bug.cgi?id=143500
207
208         Reviewed by Simon Fraser.
209
210         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
211         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Added.
212         (-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]):
213         (TEST):
214         Add a test that verifies that fixedLayoutSize works at all, that
215         it persists through a navigation, and that turning it back off reverts to
216         laying out at the size of the view.
217
218 2015-04-07  Michael Catanzaro  <mcatanzaro@igalia.com>
219
220         Unreviewed. Add myself as a committer.
221
222         * Scripts/webkitpy/common/config/contributors.json:
223
224 2015-04-07  Brent Fulgham  <bfulgham@apple.com>
225
226         [Win] Bots complain about missing /etc/catalog
227         https://bugs.webkit.org/show_bug.cgi?id=143484
228
229         Reviewed by Chris Dumez.
230
231         The libxml2 build on Mac, iOS, and Windows does not provide the set
232         of default catalog files. We do not actually need these for our
233         purposes, but we get warnings and some bot flakiness because they
234         are not present.
235
236         We can avoid both problems the same way the Mac and iOS ports do,
237         by setting the XML_CATALOG_FILES environment variable to 'empty string',
238         which avoid the warnings and bot problems.
239
240         * Scripts/webkitpy/port/win.py:
241         (WinPort.setup_environ_for_server): Added.
242
243 2015-04-06  Sam Weinig  <sam@webkit.org>
244
245         Use content extensions in MiniBrowser.
246         https://bugs.webkit.org/show_bug.cgi?id=143446
247
248         Reviewed by Alex Christensen.
249
250         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
251         * MiniBrowser/mac/AppDelegate.h:
252         * MiniBrowser/mac/AppDelegate.m:
253         (-[BrowserAppDelegate init]):
254         (-[BrowserAppDelegate showExtensionsManager:]):
255         (-[BrowserAppDelegate userContentContoller]):
256         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
257         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
258         (-[ExtensionManagerWindowController init]):
259         (-[ExtensionManagerWindowController windowDidLoad]):
260         (-[ExtensionManagerWindowController add:]):
261         (-[ExtensionManagerWindowController remove:]):
262         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
263         * MiniBrowser/mac/MainMenu.xib:
264
265 2015-04-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
266
267         web-platform-tests server should retrieve the modules file relatively to its docroot path
268         https://bugs.webkit.org/show_bug.cgi?id=142742
269
270         Reviewed by Darin Adler.
271
272         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
273         (WebPlatformTestServer._install_modules): Compute the modules description file path according wpt server doc root path.
274
275 2015-04-06  Commit Queue  <commit-queue@webkit.org>
276
277         Unreviewed, rolling out r182445.
278         https://bugs.webkit.org/show_bug.cgi?id=143459
279
280         broke 32 bit build (Requested by alexchristensen on #webkit).
281
282         Reverted changeset:
283
284         "Use content extensions in MiniBrowser."
285         https://bugs.webkit.org/show_bug.cgi?id=143446
286         http://trac.webkit.org/changeset/182445
287
288 2015-04-06  Sam Weinig  <sam@webkit.org>
289
290         Use content extensions in MiniBrowser.
291         https://bugs.webkit.org/show_bug.cgi?id=143446
292
293         Reviewed by Alex Christensen.
294
295         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
296         * MiniBrowser/mac/AppDelegate.h:
297         * MiniBrowser/mac/AppDelegate.m:
298         (-[BrowserAppDelegate init]):
299         (-[BrowserAppDelegate showExtensionsManager:]):
300         (-[BrowserAppDelegate userContentContoller]):
301         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
302         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
303         (-[ExtensionManagerWindowController init]):
304         (-[ExtensionManagerWindowController windowDidLoad]):
305         (-[ExtensionManagerWindowController add:]):
306         (-[ExtensionManagerWindowController remove:]):
307         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
308         * MiniBrowser/mac/MainMenu.xib:
309
310 2015-04-06  Michael Catanzaro  <mcatanzaro@gnome.org>
311
312         [GTK] install-dependencies should prefer dnf to yum
313         https://bugs.webkit.org/show_bug.cgi?id=143441
314
315         Reviewed by Martin Robinson.
316
317         Test for the existance of dnf before yum, and only try to use yum if dnf does not exist.
318
319         * gtk/install-dependencies:
320
321 2015-04-06  Andy Estes  <aestes@apple.com>
322
323         [iOS] 'make clean' fails in Tools/WebKitTestRunner
324         https://bugs.webkit.org/show_bug.cgi?id=143455
325
326         Reviewed by Dan Bernstein.
327
328         This Makefile adds '-target WebKitTestRunnerApp' to OTHER_OPTIONS during iOS builds, but the top-level
329         Makefile.shared adds '-alltargets' for clean builds, and xcodebuild does not allow both -target and -alltargets.
330
331         * WebKitTestRunner/Makefile: Don't add '-target WebKitTestRunerApp' to OTHER_OPTIONS on clean builds.
332
333 2015-04-06  Alexey Proskuryakov  <ap@apple.com>
334
335         WebKit1.SetAndUpdateCacheModelPreferencesChangeMix fails on some machines
336         https://bugs.webkit.org/show_bug.cgi?id=143450
337
338         Reviewed by Anders Carlsson.
339
340         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: (TestWebKitAPI::TEST):
341         Make sure that the view is actually closed, regardless of anything else that happens beneath.
342         Also, removed unnecessary get() calls.
343
344 2015-04-03  Alexey Proskuryakov  <ap@apple.com>
345
346         Reduce the dependency on Flash in regression tests
347         https://bugs.webkit.org/show_bug.cgi?id=143391
348
349         Reviewed by Anders Carlsson.
350
351         * WebKitTestRunner/TestController.cpp: (WTR::TestController::decidePolicyForPluginLoad):
352         Only allow QuickTime and the test plug-in.
353
354 2015-04-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
355
356         W3C test importer should generate the modules installed dynamically to run wpt tests
357         https://bugs.webkit.org/show_bug.cgi?id=142738
358
359         Reviewed by Ryosuke Niwa.
360
361         The test importer can now generate the submodules description file based on information extracted from the corresponding git repository.
362         The implementation is done within TestDownloader and it is activated for the WPT repository.
363         LayoutTests/imported/w3c/resources/WPTModules is renamed as LayoutTests/imported/w3c/resources/web-platform-tests-modules.json for that reason.
364
365         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
366         (WebPlatformTestServer._install_modules): Updated to cope with path as array.
367         * Scripts/webkitpy/w3c/test_downloader.py:
368         (TestDownloader._git_submodules_status): Added so that it can be overriden for unit tests.
369         (TestDownloader):
370         (TestDownloader._git_submodules_description): Computes submodule description.
371         (TestDownloader.generate_git_submodules_description): Write submodule description in a file.
372         * Scripts/webkitpy/w3c/test_importer.py:
373         (TestImporter.do_import): Added the possibility to post process the tests.
374         (TestImporter):
375         (TestImporter.generate_git_submodules_description_for_all_repositories): Enable generating module description file.
376         (TestImporter.should_convert_test_harness_links): Updated according new options format.
377         * Scripts/webkitpy/w3c/test_importer_unittest.py:
378         (TestImporterTest.import_downloaded_tests): Making use of TestDownloaderMock. 
379         (TestImporterTest.import_downloaded_tests.TestDownloaderMock): Added to override submodule status gathering.
380         (TestImporterTest.import_downloaded_tests.TestDownloaderMock.__init__):
381         (TestImporterTest.import_downloaded_tests.TestDownloaderMock._git_submodules_status):
382         (TestImporterTest.test_submodules_generation): Added to check that modules description files works.
383
384 2015-04-05  Antti Koivisto  <antti@apple.com>
385
386         Bloom filter should support longer hashes
387         https://bugs.webkit.org/show_bug.cgi?id=143419
388
389         Reviewed by Dan Bernstein.
390
391         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp:
392         (TestWebKitAPI::generateRandomDigests):
393         (TestWebKitAPI::TEST):
394
395 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
396
397         run-jsc-stress-tests --remote should add libllvmForJSC.so to the bundle on Linux
398         https://bugs.webkit.org/show_bug.cgi?id=143372
399
400         Reviewed by Darin Adler.
401
402         * Scripts/run-jsc-stress-tests:
403
404 2015-04-03  Antti Koivisto  <antti@apple.com>
405
406         Add non-counting bloom filter class
407         https://bugs.webkit.org/show_bug.cgi?id=143366
408
409         Reviewed by Sam Weinig.
410
411         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
412         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp: Added.
413         (TestWebKitAPI::generateRandomHashes):
414         (TestWebKitAPI::TEST):
415
416 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
417
418         FTL JIT tests should fail if LLVM library isn't available
419         https://bugs.webkit.org/show_bug.cgi?id=143374
420
421         Reviewed by Mark Lam.
422
423         * Scripts/run-jsc-stress-tests:
424
425 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
426
427         [EFL] Speedup jhbuild with disable running autogen.sh
428         https://bugs.webkit.org/show_bug.cgi?id=143369
429
430         Reviewed by Gyuyoung Kim.
431
432         * efl/jhbuild.modules:
433
434 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
435
436         filter-webkit-build should filter out "created by an unsupported XCDependencyGraph build" lines
437         https://bugs.webkit.org/show_bug.cgi?id=143282
438
439         Reviewed by Daniel Bates.
440
441         * Scripts/filter-build-webkit: (shouldIgnoreLine): Do it.
442
443 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
444
445         When LayoutTestHelper fails to start, we continue to run the tests, ending up with mysterious failures
446         https://bugs.webkit.org/show_bug.cgi?id=143240
447         rdar://problem/19990425
448
449         Reviewed by Tim Horton.
450
451         * DumpRenderTree/mac/LayoutTestHelper.m:
452         (colorProfileURLForDisplay):
453         (saveDisplayColorProfiles):
454         Gracefully handle it when the current profile cannot be retrieved, fixing at
455         least one case when LayoutTestHelper couldn't start.
456
457         * Scripts/webkitpy/layout_tests/controllers/manager.py:
458         (Manager._set_up_run):
459         (Manager._force_pixel_tests_if_needed):
460         * Scripts/webkitpy/port/base.py: (Port.to.start_helper):
461         * Scripts/webkitpy/port/mac.py: (MacPort.start_helper):
462         Return and check an error from start_helper().
463
464 2015-04-01  Brent Fulgham  <bfulgham@apple.com>
465
466         [Win] Run test-webkitpy as part of EWS (just like we do on other platforms)
467         https://bugs.webkit.org/show_bug.cgi?id=143321
468
469         Reviewed by Alexey Proskuryakov.
470
471         * EWSTools/start-queue-win.sh: Add commands to run 'test-webkitpy' during processing loop.
472
473 2015-04-01  Enrica Casucci  <enrica@apple.com>
474
475         Injected bundle messages should be at the page level.
476         https://bugs.webkit.org/show_bug.cgi?id=143283
477
478         Reviewed by Alexey Proskuryakov.
479
480         Updating WebKitTestRunner to use the new page level messaging.
481         The author of this patch is Tim Horton, I just finished it.
482
483         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
484         (WTR::EventSendingController::mouseDown):
485         (WTR::EventSendingController::mouseUp):
486         (WTR::EventSendingController::mouseMoveTo):
487         (WTR::EventSendingController::leapForward):
488         (WTR::EventSendingController::scheduleAsynchronousClick):
489         (WTR::EventSendingController::keyDown):
490         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
491         (WTR::EventSendingController::mouseScrollBy):
492         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
493         (WTR::EventSendingController::continuousMouseScrollBy):
494         (WTR::EventSendingController::addTouchPoint):
495         (WTR::EventSendingController::updateTouchPoint):
496         (WTR::EventSendingController::setTouchModifier):
497         (WTR::EventSendingController::setTouchPointRadius):
498         (WTR::EventSendingController::touchStart):
499         (WTR::EventSendingController::touchMove):
500         (WTR::EventSendingController::touchEnd):
501         (WTR::EventSendingController::touchCancel):
502         (WTR::EventSendingController::clearTouchPoints):
503         (WTR::EventSendingController::releaseTouchPoint):
504         (WTR::EventSendingController::cancelTouchPoint):
505         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
506         (WTR::InjectedBundle::didReceiveMessage):
507         (WTR::InjectedBundle::didReceiveMessageToPage):
508         (WTR::InjectedBundle::done):
509         (WTR::InjectedBundle::outputText):
510         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
511         (WTR::InjectedBundle::postAddChromeInputField):
512         (WTR::InjectedBundle::postRemoveChromeInputField):
513         (WTR::InjectedBundle::postFocusWebView):
514         (WTR::InjectedBundle::postSetBackingScaleFactor):
515         (WTR::InjectedBundle::postSetWindowIsKey):
516         (WTR::InjectedBundle::postSimulateWebNotificationClick):
517         (WTR::InjectedBundle::postSetAddsVisitedLinks):
518         (WTR::InjectedBundle::setGeolocationPermission):
519         (WTR::InjectedBundle::setMockGeolocationPosition):
520         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
521         (WTR::InjectedBundle::setUserMediaPermission):
522         (WTR::InjectedBundle::setCustomPolicyDelegate):
523         (WTR::InjectedBundle::setHidden):
524         (WTR::InjectedBundle::setCacheModel):
525         (WTR::InjectedBundle::shouldProcessWorkQueue):
526         (WTR::InjectedBundle::processWorkQueue):
527         (WTR::InjectedBundle::queueBackNavigation):
528         (WTR::InjectedBundle::queueForwardNavigation):
529         (WTR::InjectedBundle::queueLoad):
530         (WTR::InjectedBundle::queueLoadHTMLString):
531         (WTR::InjectedBundle::queueReload):
532         (WTR::InjectedBundle::queueLoadingScript):
533         (WTR::InjectedBundle::queueNonLoadingScript):
534         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
535         (WTR::TestRunner::setHandlesAuthenticationChallenges):
536         (WTR::TestRunner::setAuthenticationUsername):
537         (WTR::TestRunner::setAuthenticationPassword):
538         (WTR::TestRunner::secureEventInputIsEnabled):
539         (WTR::TestRunner::setBlockAllPlugins):
540         * WebKitTestRunner/TestController.cpp:
541         (WTR::TestController::createWebViewWithOptions):
542         (WTR::TestController::resetStateToConsistentValues):
543         (WTR::TestController::didReceivePageMessageFromInjectedBundle):
544         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle):
545         * WebKitTestRunner/TestController.h:
546         * WebKitTestRunner/TestInvocation.cpp:
547         (WTR::TestInvocation::invoke):
548         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
549
550 2015-04-01  Commit Queue  <commit-queue@webkit.org>
551
552         Unreviewed, rolling out r182174 and r182177.
553         https://bugs.webkit.org/show_bug.cgi?id=143314
554
555         Try to correct EWS failures (Requested by bfulgham on
556         #webkit).
557
558         Reverted changesets:
559
560         "Python SCM should be able to retrieve untracked files"
561         https://bugs.webkit.org/show_bug.cgi?id=143135
562         http://trac.webkit.org/changeset/182174
563
564         "[buildbot] clean-build script should remove untracked files
565         and revert local changes too"
566         https://bugs.webkit.org/show_bug.cgi?id=142400
567         http://trac.webkit.org/changeset/182177
568
569 2015-04-01  Alex Christensen  <achristensen@webkit.org>
570
571         [Content Extensions] Properly handle regexes that match everything.
572         https://bugs.webkit.org/show_bug.cgi?id=143281
573
574         Reviewed by Benjamin Poulain.
575
576         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
577         (TestWebKitAPI::testRequest):
578         (TestWebKitAPI::makeBackend):
579         (TestWebKitAPI::TEST_F):
580         Removed duplicate code and added test.
581
582 2015-03-31  Benjamin Poulain  <bpoulain@apple.com>
583
584         Content Extensions: split the state machines to minimize prefix states
585         https://bugs.webkit.org/show_bug.cgi?id=143253
586
587         Reviewed by Alex Christensen.
588
589         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
590         (TestWebKitAPI::TEST_F):
591         (TestWebKitAPI::testPatternStatus):
592
593 2015-03-31  Yusuke Suzuki  <utatane.tea@gmail.com>
594
595         Clean up Identifier factories to clarify the meaning of StringImpl*
596         https://bugs.webkit.org/show_bug.cgi?id=143146
597
598         Reviewed by Filip Pizlo.
599
600         Simple API tests for StringImpl are added.
601
602         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
603         (TestWebKitAPI::TEST):
604
605 2015-03-31  Csaba Osztrogonác  <ossy@webkit.org>
606
607         [EFL] Add AArch64 builder and tester bot to build.webkit.org
608         https://bugs.webkit.org/show_bug.cgi?id=143092
609
610         Reviewed by Gyuyoung Kim.
611
612         * BuildSlaveSupport/build.webkit.org-config/config.json:
613         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
614         (Factory.__init__):
615         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
616
617 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
618
619         [buildbot] clean-build script should remove untracked files and revert local changes too
620         https://bugs.webkit.org/show_bug.cgi?id=142400
621
622         Reviewed by Ryosuke Niwa.
623
624         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
625         A helper routine SCM.discard_untracked_files is added for that purpose.
626
627         * BuildSlaveSupport/clean-build:
628         (main): Making call to Scripts/clean-webkit
629         * Scripts/clean-webkit: Added.
630         (main): Revert changes and delete untracked files.
631         * Scripts/webkitpy/common/checkout/scm/scm.py:
632         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
633         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
634         (SCMTest._shared_test_discard_untracked_files):
635         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
636
637 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
638
639         Python SCM should be able to retrieve untracked files
640         https://bugs.webkit.org/show_bug.cgi?id=143135
641
642         Reviewed by Ryosuke Niwa.
643
644         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
645         Ignored files may be included or not in this list according boolean passed to the function.
646
647         * Scripts/webkitpy/common/checkout/scm/git.py:
648         (Git.untracked_files):
649         * Scripts/webkitpy/common/checkout/scm/scm.py:
650         (SCM.untracked_files):
651         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
652         (SCMTest._shared_test_untracked_files):
653         (test_untracked_files):
654         (GitSVNTest.test_untracked_files):
655         * Scripts/webkitpy/common/checkout/scm/svn.py:
656         (SVN.untracked_files):
657
658 2015-03-30  Alex Christensen  <achristensen@webkit.org>
659
660         [Content Extensions] Correctly handle regular expressions matching everything
661         https://bugs.webkit.org/show_bug.cgi?id=143235
662
663         Reviewed by Benjamin Poulain.
664
665         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
666         (TestWebKitAPI::checkCompilerError):
667         (TestWebKitAPI::TEST_F):
668         Test ContentExtensionErrors.
669
670 2015-03-30  Alexey Proskuryakov  <ap@apple.com>
671
672         DumpRenderTree should set NSWindowDisplayWithRunLoopObserver
673         https://bugs.webkit.org/show_bug.cgi?id=143241
674         rdar://problem/20351297
675
676         Reviewed by Mark Lam.
677
678         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
679
680 2015-03-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
681
682         [CMake][EFL] Remove redundant library link and include path
683         https://bugs.webkit.org/show_bug.cgi?id=143221
684
685         Reviewed by Csaba Osztrogonác.
686
687         * ImageDiff/PlatformEfl.cmake: Remove unnecessary library link and include path.
688
689 2015-03-30  Sam Weinig  <sam@webkit.org>
690
691         [Content Extensions] Flesh out the UserContentExtensionStore
692         https://bugs.webkit.org/show_bug.cgi?id=143123
693
694         Reviewed by Benjamin Poulain.
695
696         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
697         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: Added.
698         Add tests for _WKUserContentExtensionStore.
699
700 2015-03-30  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
701
702         Update install-dependencies Fedora packages after r181624
703         https://bugs.webkit.org/show_bug.cgi?id=143215
704
705         Add json-glib, libv4l, openssl and pulseaudio development packages to
706         the Fedora list providing we need them to build WebKit dependencies
707         for this distribution.
708
709         Reviewed by Philippe Normand.
710
711         * gtk/install-dependencies:
712
713 2015-03-30  Commit Queue  <commit-queue@webkit.org>
714
715         Unreviewed, rolling out r182119.
716         https://bugs.webkit.org/show_bug.cgi?id=143196
717
718         problem with syntax (Requested by youenn on #webkit).
719
720         Reverted changeset:
721
722         "[buildbot] clean-build script should remove untracked files
723         and revert local changes too"
724         https://bugs.webkit.org/show_bug.cgi?id=142400
725         http://trac.webkit.org/changeset/182119
726
727 2015-03-30  Benjamin Poulain  <benjamin@webkit.org>
728
729         Start the features.json files
730         https://bugs.webkit.org/show_bug.cgi?id=143207
731
732         Reviewed by Darin Adler.
733
734         I kept the style checking light. We'll have to figure
735         what is the best format for each field.
736
737         * Scripts/webkitpy/style/checker.py:
738         (CheckerDispatcher._create_checker):
739         * Scripts/webkitpy/style/checkers/jsonchecker.py:
740         (JSONContributorsChecker.check):
741         (JSONFeaturesChecker):
742         (JSONFeaturesChecker.check):
743
744 2015-03-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
745
746         [buildbot] clean-build script should remove untracked files and revert local changes too
747         https://bugs.webkit.org/show_bug.cgi?id=142400
748
749         Reviewed by Ryosuke Niwa.
750
751         This patch cleans the WebKit folder by deleting SCM untracked files and reverting changes for tracked files.
752
753         * BuildSlaveSupport/clean-build:
754         (main): Adding call to Tools/Scripts/clean-webkit.
755         * Scripts/clean-webkit: Added.
756         (main): Removes untracked and changed files.
757         * Scripts/webkitpy/common/checkout/scm/git.py:
758         (Git.untracked_files): Retrieves GIT untracked files.
759         * Scripts/webkitpy/common/checkout/scm/scm.py:
760         (SCM.untracked_files): Retrieves SVN untracked files.
761         (SCM):
762         (SCM.discard_untracked_files): Deletes untracked files/folders.
763         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
764         (SCMTest._shared_test_untracked_files): Unit testing for untracked files.
765         (test_untracked_files):
766         (GitSVNTest.test_untracked_files):
767         * Scripts/webkitpy/common/checkout/scm/svn.py:
768         (SVN.untracked_files):
769
770 2015-03-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
771
772         [CMake] Remove unnecessary INCLUDE_IF_EXISTS macro 
773         https://bugs.webkit.org/show_bug.cgi?id=143138
774
775         Reviewed by Csaba Osztrogonác.
776
777         INCLUDE_IF_EXISTS isn't used except for 2 places. However those uses can
778         be replaced with WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS.
779
780         * ImageDiff/CMakeLists.txt:
781         Use WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS() instead of INCLUDE_IF_EXISTS.
782         * WebKitTestRunner/CMakeLists.txt: ditto.
783
784 2015-03-27  Myles C. Maxfield  <mmaxfield@apple.com>
785
786         Support building WTF on Windows without Cygwin
787         https://bugs.webkit.org/show_bug.cgi?id=143084
788
789         Reviewed by Brent Fulgham.
790
791         Windows without Cygwin doesn't have curl, unzip, or grep. Luckily, Perl does all of these things.
792         This patch also migrates to using File::Spec->catfile() for directory separators.
793
794         * Scripts/update-webkit-dependency:
795         (wanted):
796         * Scripts/update-webkit-support-libs:
797         (wanted):
798         (downloadExpectedVersionNumber):
799         (zipFileVersion):
800         (toUnixPath): Deleted.
801         * Scripts/webkitdirs.pm:
802         (determineSourceDir):
803         (windowsSourceSourceDir):
804         (windowsLibrariesDir):
805         (windowsOutputDir):
806         (checkInstalledTools):
807         (buildVisualStudioProject):
808
809 2015-03-27  Alex Christensen  <achristensen@webkit.org>
810
811         Fix WinCairo bot.
812         https://bugs.webkit.org/show_bug.cgi?id=143086
813
814         Reviewed by Brent Fulgham.
815
816         * Scripts/webkitdirs.pm:
817         (buildVisualStudioProject):
818         (runSvnUpdateAndResolveChangeLogs):
819         Use ActivePerl-friendly perl.
820
821 2015-03-27  Csaba Osztrogonác  <ossy@webkit.org>
822
823         URTBF after r182059 to fix the EFL build.
824
825         * TestWebKitAPI/CMakeLists.txt:
826
827 2015-03-26  Alexey Proskuryakov  <ap@apple.com>
828
829         Layout test results URL loads in WK1 but not WK2 minibrowser
830         https://bugs.webkit.org/show_bug.cgi?id=143117
831
832         Reviewed by Tim Horton.
833
834         * MiniBrowser/mac/WK2BrowserWindowController.m:
835         (-[WK2BrowserWindowController fetch:]): Fix this, international domain names, and
836         everything.
837         (-[WK2BrowserWindowController updateTextFieldFromURL:]): Ditto.
838
839 2015-03-26  Jer Noble  <jer.noble@apple.com>
840
841         Add --allowed-host support to run-webkit-tests
842         https://bugs.webkit.org/show_bug.cgi?id=142938
843
844         Reviewed by Brent Fulgham.
845
846         Accept --allowed-host arguments from run-webkit-tests and pass them through to
847         DumpRenderTree and WebKitTestRunner.
848
849         Drive-by fix: Depending on the value of the --layout-test-dir parameter, layout test results
850         are placed in the wrong location. The argument is compared with each tests's path, and if a
851         relative path or a path with '..' was used, results are placed alongside the test. Take the
852         absolute path of the --layout-test-dir argument, collapsing path components like '..'.
853
854         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
855         (parse_args):
856         * Scripts/webkitpy/port/base.py:
857         (Port.__init__):
858         (Port.allowed_hosts):
859         * Scripts/webkitpy/port/driver.py:
860         (Driver.cmd_line):
861
862 2015-03-26  Jer Noble  <jer.noble@apple.com>
863
864         [Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connect to non-localhost servers
865         https://bugs.webkit.org/show_bug.cgi?id=142931
866
867         Reviewed by Brent Fulgham.
868
869         Currently, both DRT and WKTR will refuse to allow network connections to non-localhost servers
870         over HTTP/HTTPS. For certain testing scenarios, however, it would be useful if both DRT and
871         WKTR could be allowed to make HTTP/HTTPS connections to certain, specific servers defined at
872         runtime.
873
874         To allow this, add an optional argument to DRT and WKTR, --allowed-host, which will add the specified
875         hostname to a whitelist; requests to these hosts will allowed to proceed normally.
876
877         Drive-by fix: in InjectedBundlePage::willSendRequestForFrame, we get the top loading frame from the
878         injected bundle. But after the main resource load completes, the bundle nulls out it's pointer to the
879         top loading frame, which causes a subsequent crash when further resources are requested. Instead, get
880         the top loading frame from the page, as we do elsewhere in this class.
881
882         * DumpRenderTree/TestRunner.h:
883         (TestRunner::allowedHosts):
884         (TestRunner::setAllowedHosts):
885         * DumpRenderTree/mac/DumpRenderTree.mm:
886         (initializeGlobalsFromCommandLineOptions):
887         (runTest):
888         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
889         (isAllowedHost):
890         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
891         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
892         (WTR::InjectedBundle::didReceiveMessage):
893         (WTR::InjectedBundle::isAllowedHost):
894         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
895         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
896         (WTR::isAllowedHost):
897         (WTR::InjectedBundlePage::willSendRequestForFrame):
898         * WebKitTestRunner/InjectedBundle/TestRunner.h:
899         * WebKitTestRunner/Options.cpp:
900         (WTR::handleOptionAllowedHost):
901         (WTR::OptionsHandler::OptionsHandler):
902         * WebKitTestRunner/Options.h:
903         * WebKitTestRunner/TestController.cpp:
904         (WTR::TestController::initialize):
905         (WTR::TestController::resetStateToConsistentValues):
906         * WebKitTestRunner/TestController.h:
907
908 2015-03-26  Brady Eidson  <beidson@apple.com>
909
910         Apply ContentExtension actions after redirects.
911         <rdar://problem/20062613> and https://bugs.webkit.org/show_bug.cgi?id=143055
912
913         Reviewed by Alex Christensen.
914
915         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
916         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Dump the fact that the load error is kWKErrorCodeCannotShowURL
917           which is specifically interesting to a new test.
918
919 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
920
921         [EFL] Disable building libseccomp on AArch64
922         https://bugs.webkit.org/show_bug.cgi?id=143094
923
924         Reviewed by Gyuyoung Kim.
925
926         * efl/jhbuildrc:
927
928 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
929
930         [jhbuild] git should use only 1 thread for cloning jhbuild
931         https://bugs.webkit.org/show_bug.cgi?id=143095
932
933         Reviewed by Gyuyoung Kim.
934
935         * jhbuild/jhbuild-wrapper:
936         (clone_jhbuild):
937
938 2015-03-25  Joseph Pecoraro  <pecoraro@apple.com>
939
940         Update prepare-ChangeLog to work with ES6 Class syntax
941         https://bugs.webkit.org/show_bug.cgi?id=143069
942
943         Reviewed by Timothy Hatcher.
944
945         * Scripts/prepare-ChangeLog:
946         (get_function_line_ranges_for_javascript):
947         Better handle ES6 Class syntax.
948
949         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
950         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
951         (BaseClass):
952         (DerivedClass):
953         (DerivedClass.staticMethod):
954         (DerivedClass.prototype.method.nestedFunctionInsideMethod):
955         (DerivedClass.prototype.method):
956         (DerivedClass.prototype.get getter):
957         (namespace.MyClass):
958         (namespace.MyClass.staticMethod):
959         (namespace.MyClass.prototype.method.nestedFunctionInsideMethod):
960         (namespace.MyClass.prototype.method):
961         (namespace.MyClass.prototype.get getter):
962         Proof!
963
964 2015-03-25  Filip Pizlo  <fpizlo@apple.com>
965
966         Use JITCompilationCanFail in more places, and make the fail path of JITCompilationMustSucceed a crash instead of attempting GC
967         https://bugs.webkit.org/show_bug.cgi?id=142993
968
969         Reviewed by Mark Lam.
970         
971         Bunch of support for testing executable allocation failure.
972
973         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz: Added.
974         (fail):
975         * Scripts/run-javascriptcore-tests:
976         (runJSCStressTests):
977         * Scripts/run-jsc-stress-tests:
978
979 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
980
981         Fix Windows build from r181977.
982
983         Unreviewed.
984
985         * Scripts/update-webkit-dependency:
986
987 2015-03-25  Sam Weinig  <sam@webkit.org>
988
989         Address additional review feedback from https://bugs.webkit.org/show_bug.cgi?id=143059.
990
991         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
992         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
993
994 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
995
996         Migrate update-webkit for Windows to not require Cygwin
997         https://bugs.webkit.org/show_bug.cgi?id=143040
998
999         Reviewed by Brent Fulgham.
1000
1001         * Scripts/update-webkit-dependency:
1002         (wanted):
1003         (toUnixPath): Deleted.
1004         * Scripts/webkitdirs.pm:
1005         (fontExists):
1006         (checkInstalledTools):
1007         (setupAppleWinEnv):
1008
1009 2015-03-25  Sam Weinig  <sam@webkit.org>
1010
1011         [Content Extensions] Convert content extension compiling to return error codes and write its output using a client
1012         https://bugs.webkit.org/show_bug.cgi?id=143059
1013
1014         Reviewed by Alex Christensen.
1015
1016         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1017         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1018         Update for new interface of compileRuleList().
1019
1020 2015-03-25  Alex Christensen  <achristensen@webkit.org>
1021
1022         [Content Extensions] Add multi-DFA compiling and interpreting.
1023         https://bugs.webkit.org/show_bug.cgi?id=143010
1024
1025         Reviewed by Benjamin Poulain.
1026
1027         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1028         (TestWebKitAPI::testRequest):
1029         (TestWebKitAPI::TEST_F):
1030         Add some tests for ignore-previous-rules and large rulesets.
1031
1032 2015-03-25  Alexey Proskuryakov  <ap@apple.com>
1033
1034         Mavericks WK1 still runs JSC tests
1035         https://bugs.webkit.org/show_bug.cgi?id=143035
1036
1037         Reviewed by Csaba Osztrogonác.
1038
1039         * BuildSlaveSupport/build.webkit.org-config/config.json: Bring Mavericks WK1 in line
1040         with other bots.
1041
1042         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated the tests
1043         accordingly.
1044
1045 2015-03-25  Commit Queue  <commit-queue@webkit.org>
1046
1047         Unreviewed, rolling out r181932.
1048         https://bugs.webkit.org/show_bug.cgi?id=143041
1049
1050         The test fails most of the time on bots (Requested by ap on
1051         #webkit).
1052
1053         Reverted changeset:
1054
1055         "[Content Extensions] Add multi-DFA compiling and
1056         interpreting."
1057         https://bugs.webkit.org/show_bug.cgi?id=143010
1058         http://trac.webkit.org/changeset/181932
1059
1060 2015-03-24  Alex Christensen  <achristensen@webkit.org>
1061
1062         [Content Extensions] Add multi-DFA compiling and interpreting.
1063         https://bugs.webkit.org/show_bug.cgi?id=143010
1064
1065         Reviewed by Benjamin Poulain.
1066
1067         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1068         (TestWebKitAPI::testRequest):
1069         (TestWebKitAPI::TEST_F):
1070         Add some tests for ignore-previous-rules and large rulesets.
1071
1072 2015-03-24  Benjamin Poulain  <bpoulain@apple.com>
1073
1074         Make URL filter patterns matching consistent and add a simple canonicalization step
1075         https://bugs.webkit.org/show_bug.cgi?id=142998
1076
1077         Reviewed by Alex Christensen.
1078
1079         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1080
1081 2015-03-24  Csaba Osztrogonác  <ossy@webkit.org>
1082
1083         [EFL] Add OpenWebRTC in jhbuild
1084         https://bugs.webkit.org/show_bug.cgi?id=142778
1085
1086         Reviewed by Gyuyoung Kim.
1087
1088         Original patch by Philippe Normand <pnormand@igalia.com>
1089
1090         * efl/install-dependencies: Dependencies for OpenWebRTC.
1091         * efl/jhbuild.modules: build OpenWebRTC, libusrsctp, libnice and
1092         the openwebrtc gst plugins.
1093
1094 2015-03-23  Brent Fulgham  <bfulgham@apple.com>
1095
1096         Regression(r181257): WTF_WorkQueue.Simple is flaky
1097         https://bugs.webkit.org/show_bug.cgi?id=142560
1098
1099         Remove the check that the refCount has returned to one after the
1100         individual tasks have completed. It's too nondeterministic when
1101         the reference count will be reduced.
1102
1103         Reviewed by Alexey Proskuryakov
1104
1105         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1106         (TestWebKitAPI::TEST): Remove test that refCount is back to 1.
1107
1108 2015-03-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1109
1110         [CMake][EFL] Put failure API test excutables into failure directory
1111         https://bugs.webkit.org/show_bug.cgi?id=142965
1112
1113         Reviewed by Csaba Osztrogonác.
1114
1115         Move failing WK2 API test executables to *bin/TestWebKitAPI/WebKit2/failure* directory.
1116
1117         * TestWebKitAPI/CMakeLists.txt: Fix a typo. Change *testBaseName* with *testName*.
1118         * TestWebKitAPI/PlatformEfl.cmake: Additionally remove unnecessary SHARED_CORE and comment for SeccompFilters test.
1119
1120 2015-03-22  Benjamin Poulain  <benjamin@webkit.org>
1121
1122         CSS Selectors: fix attribute case-insensitive matching of Contain and List
1123         https://bugs.webkit.org/show_bug.cgi?id=142932
1124
1125         Reviewed by Darin Adler.
1126
1127         Add tests for the new features and fix some existing tests using the 
1128         stringFromUTF8() utility recently added by Dhi.
1129
1130         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1131         (TestWebKitAPI::stringFromUTF8):
1132         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1133
1134 2015-03-22  Michael Catanzaro  <mcatanzaro@igalia.com>
1135
1136         [GTK] install-dependencies should install orc
1137         https://bugs.webkit.org/show_bug.cgi?id=142955
1138
1139         Reviewed by Martin Robinson.
1140
1141         Install orc, needed by openwebrtc
1142
1143         * gtk/install-dependencies:
1144
1145 2015-03-22  Benjamin Poulain  <bpoulain@apple.com>
1146
1147         Detect when url filter pattern with groups match the empty string
1148         https://bugs.webkit.org/show_bug.cgi?id=142930
1149
1150         Reviewed by Sam Weinig.
1151
1152         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1153
1154 2015-03-22  Anders Carlsson  <andersca@apple.com>
1155
1156         _WKWebsiteDataStore should clear WebSQL databases
1157         https://bugs.webkit.org/show_bug.cgi?id=142947
1158
1159         Reviewed by Sam Weinig.
1160
1161         Add a variable that keeps track of the types of data we want to operate on, for easier debugging.
1162
1163         * MiniBrowser/mac/WK2BrowserWindowController.m:
1164         (-[WK2BrowserWindowController fetchWebsiteData:]):
1165         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
1166         (-[WK2BrowserWindowController clearWebsiteData:]):
1167
1168 2015-03-20  Mark Hahnenberg  <mhahnenb@gmail.com>
1169
1170         GCTimer should know keep track of nested GC phases
1171         https://bugs.webkit.org/show_bug.cgi?id=142675
1172
1173         Reviewed by Darin Adler.
1174
1175         Adds a tool to aid in parsing the GC phase timing output into a
1176         tree-like structure based on the parent-child relationships
1177         of nested GC phases.
1178
1179         * Scripts/parse-gc-phase-timings: Added.
1180         (Timing):
1181         (Timing.__init__):
1182         (Timing.__unicode__):
1183         (Timing.__str__):
1184         (Timing.__repr__):
1185         (parse_input):
1186         (print_timing_node):
1187         (print_timing_tree):
1188         (link_parents):
1189         (main):
1190
1191 2015-03-20  Brent Fulgham  <bfulgham@apple.com>
1192
1193         [Win] Temporarily turn of EWS Windows tests while I debug the test failure.
1194
1195         * Scripts/webkitpy/common/config/ews.json:
1196
1197 2015-03-20  Philippe Normand  <pnormand@igalia.com>
1198
1199         [GTK][jhbuild] Fix flakey failures due to unstable googlecode repository
1200         https://bugs.webkit.org/show_bug.cgi?id=142867
1201
1202         Rubber-stamped by Csaba Osztrogon.
1203
1204         * gtk/jhbuild.modules: Use Ossy's libusrsctp Github fork. Also use
1205         a fixed revision for the openwebrtc-gst-plugins.
1206
1207 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
1208
1209         Unreviewed build fix. Don't try to report stats for all benchmarks.
1210         Just report the geometric mean of preferred means.
1211
1212         * Scripts/run-jsc-benchmarks:
1213
1214 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
1215
1216         run-jsc-benchmarks should only report preferred mean
1217         https://bugs.webkit.org/show_bug.cgi?id=142874
1218
1219         Reviewed by Geoffrey Garen.
1220
1221         Just collect statistics for the preferred mean.
1222
1223         * Scripts/run-jsc-benchmarks:
1224
1225 2015-03-19  Alex Christensen  <achristensen@webkit.org>
1226
1227         [Content Extensions] Test regular expression parse failures.
1228         https://bugs.webkit.org/show_bug.cgi?id=142872
1229
1230         Reviewed by Benjamin Poulain.
1231
1232         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1233         (TestWebKitAPI::testPatternStatus):
1234         (TestWebKitAPI::TEST_F):
1235         Added tests for each parsing status.
1236
1237 2015-03-19  Alex Christensen  <achristensen@webkit.org>
1238
1239         Fix API tests after r181754.
1240
1241         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1242         (TestWebKitAPI::testRequest):
1243
1244 2015-03-19  Brady Eidson  <beidson@apple.com>
1245
1246         Part of content extensions should apply css selectors
1247         https://bugs.webkit.org/show_bug.cgi?id=142604
1248
1249         Reviewed by Alex Christensen.
1250
1251         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1252         (WebCore::ContentExtensions::operator<<):
1253
1254 2015-03-19  Brent Fulgham  <bfulgham@apple.com>
1255
1256         [Win] Activate tests on EWS
1257         https://bugs.webkit.org/show_bug.cgi?id=142850
1258
1259         Reviewed by Alexey Proskuryakov.
1260
1261         * Scripts/webkitpy/common/config/ews.json: Add me as
1262         the EWS bot watcher, and activate tests.
1263
1264 2015-03-19  Csaba Osztrogonác  <ossy@webkit.org>
1265
1266         [GTK] Fix inspector userinterface related incremental build issue
1267         https://bugs.webkit.org/show_bug.cgi?id=142849
1268
1269         Reviewed by Carlos Garcia Campos.
1270
1271         * Scripts/webkitdirs.pm:
1272         (shouldRemoveCMakeCache):
1273
1274 2015-03-18  Alex Christensen  <achristensen@webkit.org>
1275
1276         [ContentExtensions] Prepare for compiling stylesheets of selectors to be used on every page.
1277         https://bugs.webkit.org/show_bug.cgi?id=142799
1278
1279         Reviewed by Brady Eidson.
1280
1281         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1282         (TestWebKitAPI::testPattern):
1283         (TestWebKitAPI::TEST_F):
1284         Start testing regex failures.
1285
1286 2015-03-18  Dhi Aurrahman  <diorahman@rockybars.com>
1287
1288         Fix StringView typos after r181525 and r181558
1289         https://bugs.webkit.org/show_bug.cgi?id=142772
1290
1291         Reviewed by Darin Adler.
1292
1293         Add some tests in [1] to cover the StringView::startsWith, 
1294         StringView::startsWithIgnoringASCIICase, StringView::endsWith and 
1295         StringView::endsWithIgnoringASCIICase implementations.
1296
1297         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1298         (TestWebKitAPI::TEST):
1299
1300 2015-03-18  Dana Burkart  <dburkart@apple.com>
1301
1302         Remove extraneous import to fix the build.
1303
1304         Unreviewed.
1305
1306         * Scripts/webkitpy/port/driver.py:
1307
1308 2015-03-18  Dana Burkart  <dburkart@apple.com>
1309
1310         ASAN_OPTIONS=allocator_may_return_null=1 needs to be set 
1311         https://bugs.webkit.org/show_bug.cgi?id=142547
1312
1313         Reviewed by Alexey Proskuryakov.
1314
1315         * Scripts/webkitpy/port/driver.py:
1316         (Driver._setup_environ_for_driver):
1317
1318 2015-03-18  Alexey Proskuryakov  <ap@apple.com>
1319
1320         Tweak how AppleSystemFontOSSubversion default is added
1321         https://bugs.webkit.org/show_bug.cgi?id=142835
1322
1323         Reviewed by Dan Bernstein.
1324
1325         * DumpRenderTree/mac/DumpRenderTree.mm:
1326         (setDefaultsToConsistentValuesForTesting):
1327
1328 2015-03-18  Dan Bernstein  <mitz@apple.com>
1329
1330         prepare-ChangeLog doesn't understand C string literals split across multiple lines with \
1331         https://bugs.webkit.org/show_bug.cgi?id=142815
1332
1333         Reviewed by Darin Adler.
1334
1335         * Scripts/prepare-ChangeLog:
1336         (get_function_line_ranges_for_cpp): If the line ends with a backslash instead of a matching
1337         quotation mark, use new variable $quotation_mark to remember what we are looking for, and
1338         keep consuming the quoted text until the matching quotation mark is reached. Emit the
1339         warning only if a line ends without a backslash before the matching quotation mark was found.
1340
1341 2015-03-18  Joseph Pecoraro  <pecoraro@apple.com>
1342
1343         Remove unused "preprocessor" parameter to sub-CodeGenerators
1344         https://bugs.webkit.org/show_bug.cgi?id=142793
1345
1346         Reviewed by Darin Adler.
1347
1348         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1349         (new):
1350
1351 2015-03-18  Csaba Osztrogonác  <ossy@webkit.org>
1352
1353         [EFL] Bump gstreamer version to 1.4.4
1354         https://bugs.webkit.org/show_bug.cgi?id=142782
1355
1356         Reviewed by Philippe Normand.
1357
1358         * efl/jhbuild.modules:
1359         * efl/patches/gst-libav.patch:
1360         * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
1361         * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
1362
1363 2015-03-17  Tim Horton  <timothy_horton@apple.com>
1364
1365         Fix the iOS build.
1366
1367         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
1368         (WTR::InjectedBundle::platformInitialize):
1369
1370 2015-03-17  Dean Jackson  <dino@apple.com>
1371
1372         check-webkit-style should allow "bool a : 1"
1373         https://bugs.webkit.org/show_bug.cgi?id=142794
1374
1375         Reviewed by Brent Fulgham.
1376
1377         We should allow member bitfields of the form:
1378
1379         bool m_var : 1;
1380
1381         It seems that Visual Studio 8 was the last compiler that
1382         wasn't happy about not using unsigned here. We already have
1383         about 500 cases (in WebCore) where people were ignoring this rule.
1384
1385         * Scripts/webkitpy/style/checkers/cpp.py:
1386         (check_language): Allow "bool".
1387         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add tests.
1388         (CppStyleTest.test_enum_bitfields):
1389         (CppStyleTest.test_plain_integral_bitfields):
1390
1391 2015-03-17  Benjamin Poulain  <bpoulain@apple.com>
1392
1393         Compile character ranges targeting the same state as range check in the bytecode
1394         https://bugs.webkit.org/show_bug.cgi?id=142759
1395
1396         Reviewed by Alex Christensen.
1397
1398         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1399         (TestWebKitAPI::TEST_F):
1400
1401 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1402
1403         W3C test parser and converter should use test importer host
1404         https://bugs.webkit.org/show_bug.cgi?id=142729
1405
1406         Reviewed by Bem Jones-Bey.
1407
1408         When instantiated by TestImporter, TestParser and TestConverter are now using the same host.
1409         This enables adding more TestImporter unit testing.
1410         This patch also ensures that the git object instantiated by TestDownloader is using the
1411         same Executive and FileSystem object as TestDownloader, again to enable TestImporter/TestDownloader unit testing.
1412
1413         * Scripts/webkitpy/common/system/filesystem_mock.py:
1414         (MockFileSystem.copytree): Fixes implementation as it creates a runtime error.
1415         * Scripts/webkitpy/w3c/test_downloader.py:
1416         (TestDownloader.git): Set the executive of the git object to the one of TestDownloader. Refactoring in a new git function for future reuse.
1417         (TestDownloader.checkout_test_repository): Making use of the new git function.
1418         * Scripts/webkitpy/w3c/test_importer.py:
1419         (TestImporter.find_importable_tests): Adding host as parameter to the parser.
1420         (TestImporter.import_tests): Adding host as parameter to the converter.
1421         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1422         (TestImporterTest.create_test_download_importer): Creating a test downloader mock, to be reused by other tests.
1423         (TestImporterTest):
1424         (TestImporterTest.test_harnesslinks_conversion): Adding test to check that test harness links are converted for CSS tests but not WPT tests. 
1425         * Scripts/webkitpy/w3c/test_parser.py:
1426         (TestParser.__init__): Adding host as parameter constructor.
1427
1428 2015-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1429
1430         [GTK] WebKitDOM objects leaking
1431         https://bugs.webkit.org/show_bug.cgi?id=118788
1432
1433         Reviewed by Darin Adler and Sergio Villar Senin.
1434
1435         Update DOMObjectCache unit test to check that DOM objects are also
1436         released when new contents are loaded in the web view, and the old
1437         document is detached from the frame.
1438
1439         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
1440         (testWebKitDOMObjectCache):
1441         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1442         (runTest):
1443
1444 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1445
1446         W3C test importer default import folder should be LayoutTests/imported/w3c
1447         https://bugs.webkit.org/show_bug.cgi?id=142728
1448
1449         Reviewed by Bem Jones-Bey.
1450
1451         * Scripts/webkitpy/w3c/test_importer.py:
1452         (parse_args): Updating the default destination option value to 'imported/w3c'.
1453
1454 2015-03-17  Philippe Normand  <pnormand@igalia.com>
1455
1456         [GTK] basic OpenWebRTC build support
1457         https://bugs.webkit.org/show_bug.cgi?id=142393
1458
1459         Reviewed by Carlos Garcia Campos.
1460
1461         * gtk/jhbuild.modules: Add OpenWebRTC and its dependencies. This
1462         is not the upstream OpenWebRTC repository. This temporary fork
1463         contains a few patches needed by WebKit for audio/video rendering.
1464
1465 2015-03-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1466
1467         [CMake][EFL] Build test tools only for developer mode
1468         https://bugs.webkit.org/show_bug.cgi?id=142761
1469
1470         Reviewed by Csaba Osztrogonác.
1471
1472         Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on production mode.
1473
1474         * CMakeLists.txt:
1475
1476 2015-03-17  Joseph Pecoraro  <pecoraro@apple.com>
1477
1478         Remove never used "useLayerOnTop" bindings generator argument
1479         https://bugs.webkit.org/show_bug.cgi?id=142773
1480
1481         Reviewed by Darin Adler.
1482
1483         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1484         (new):
1485
1486 2015-03-16  Ryosuke Niwa  <rniwa@webkit.org>
1487
1488         Enable ES6 classes by default
1489         https://bugs.webkit.org/show_bug.cgi?id=142774
1490
1491         Reviewed by Gavin Barraclough.
1492
1493         * Scripts/webkitperl/FeatureList.pm:
1494
1495 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
1496
1497         Fix webkitpy tests after r181585.
1498
1499         Looks like "me" cannot be anyone's email, it's a special case.
1500
1501         * Scripts/webkitpy/common/config/contributors.json:
1502
1503 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
1504
1505         Add tolerance to WebAudio tests
1506         https://bugs.webkit.org/show_bug.cgi?id=142676
1507
1508         Reviewed by Tim Horton.
1509
1510         * Scripts/webkitpy/common/wavediff.py: Added. Based on Jer Noble's work.
1511
1512         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1513         (TestResultWriter.create_audio_diff_and_write_result):
1514         * Scripts/webkitpy/layout_tests/models/test_failures.py:
1515         (FailureAudio.write_failure):
1516         * Scripts/webkitpy/port/base.py:
1517         (Port.do_audio_results_differ):
1518         Diff audio failures.
1519
1520         * Scripts/webkitpy/port/test.py: Added a test for the tolerance, fixed existing
1521         tests to use real parseable WAV data, and got rid of base64, which there didn't
1522         seem to have been any reason for.
1523
1524 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
1525
1526         [Mac] fast/forms/text-control-intrinsic-widths.html fails when MS Office is installed
1527         https://bugs.webkit.org/show_bug.cgi?id=142720
1528
1529         Reviewed by Myles C. Maxfield.
1530
1531         Activate system copies of Microsoft fonts for the current process, thus overriding
1532         any other ones that could be preferred by the system otherwise.
1533
1534         * DumpRenderTree/mac/DumpRenderTree.mm:
1535         (activateSystemCoreWebFonts):
1536         (adjustFonts):
1537         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1538         (WTR::activateSystemCoreWebFonts):
1539         (WTR::activateFonts):
1540
1541 2015-03-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1542
1543         Created Streams API watchlist
1544         https://bugs.webkit.org/show_bug.cgi?id=142684
1545
1546         Reviewed by Benjamin Poulain.
1547
1548         * Scripts/webkitpy/common/config/watchlist: Created StreamsAPI
1549         watchlist and added Benjamin, Youenn and me to it.
1550
1551 2015-03-15  Benjamin Poulain  <benjamin@webkit.org>
1552
1553         CSS: fix the case-insensitive matching of the attribute selectors Begin, End and Hyphen
1554         https://bugs.webkit.org/show_bug.cgi?id=142715
1555
1556         Reviewed by Brent Fulgham.
1557
1558         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1559         (TestWebKitAPI::TEST):
1560
1561 2015-03-15  Benjamin Poulain  <bpoulain@apple.com>
1562
1563         Change the exact attribute matching to be ASCII case-insensitive
1564         https://bugs.webkit.org/show_bug.cgi?id=142609
1565
1566         Reviewed by Darin Adler.
1567
1568         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1569         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1570
1571 2015-03-13  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1572
1573         WebKit test infrastructure should automate the process of cloning W3C test suite and importing tests from it
1574         https://bugs.webkit.org/show_bug.cgi?id=134764
1575
1576         Reviewed by Ryosuke Niwa.
1577
1578         TestDownloader is introduced to download W3C tests from the official
1579         W3C tests repositories (https://github.com/w3c/web-platform-tests.git
1580         and https://github.com/w3c/csswg-test.git).
1581         TestDownloader clones the repositories and checkouts revisions of the tests
1582         defined in LayoutTests/imported/w3c/resources/TestRepositories.
1583
1584         Similarly to https://codereview.chromium.org/148173016,
1585         TestDownloader copies part of the files based on the rules
1586         defined in LayoutTests/imported/w3c/resources/ImportExpectations.
1587
1588         TestDownloader is used by TestImporter when no source directory is provided.
1589
1590         * Scripts/webkitpy/w3c/test_downloader.py: Added.
1591         (TestDownloader):
1592         (TestDownloader.default_options):
1593         (TestDownloader.load_test_repositories):
1594         (TestDownloader.__init__):
1595         (TestDownloader.checkout_test_repository):
1596         (TestDownloader._init_paths_from_expectations):
1597         (TestDownloader._add_test_suite_paths):
1598         (TestDownloader._empty_directory):
1599         (TestDownloader.copy_tests):
1600         (TestDownloader.download_tests):
1601         * Scripts/webkitpy/w3c/test_importer.py:
1602         (main):
1603         (parse_args):
1604         (TestImporter.__init__):
1605         (TestImporter.do_import):
1606         (TestImporter.test_downloader):
1607         (TestImporter.find_importable_tests.should_keep_subdir):
1608         (TestImporter.should_convert_test_harness_links):
1609         (TestImporter.import_tests):
1610         (TestImporter.write_import_log):
1611
1612 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
1613
1614         [Mavericks] Test snapshots are 1600x1200 on Retina devices
1615         https://bugs.webkit.org/show_bug.cgi?id=142630
1616
1617         Reviewed by Tim Horton.
1618
1619         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
1620         Removed an ifdef that disabled the fix on Mavericks.
1621
1622 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
1623
1624         Remove isWK2 cruft from webkitdirs.pm after r170426
1625         https://bugs.webkit.org/show_bug.cgi?id=142618
1626
1627         Reviewed by Daniel Bates.
1628
1629         * Scripts/webkitdirs.pm:
1630         (isWK2): Deleted.
1631
1632 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
1633
1634         testRunner.setAlwaysAcceptCookies does not work with NetworkProcess
1635         https://bugs.webkit.org/show_bug.cgi?id=138687
1636
1637         Reviewed by Carlos Garcia Campos.
1638
1639         Always change cookie policy from UI process, as changing it from WebProcess doesn't
1640         affect other processes.
1641
1642         The implementation is imperfect, because the change happens asynchronously, but I
1643         don't expect it to be a problem in practice.
1644
1645         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1646         (WTR::InjectedBundle::beginTesting):
1647         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1648         (WTR::TestRunner::setAlwaysAcceptCookies):
1649         * WebKitTestRunner/TestInvocation.cpp:
1650         (WTR::TestInvocation::invoke):
1651         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1652
1653 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
1654
1655         [EFL] Enable building EFL 1.13 with NEON support
1656         https://bugs.webkit.org/show_bug.cgi?id=142619
1657
1658         Reviewed by Gyuyoung Kim.
1659
1660         * efl/jhbuild.modules:
1661
1662 2015-03-11  Alex Christensen  <achristensen@webkit.org>
1663
1664         [Content Extensions] Add resource type and load type triggers.
1665         https://bugs.webkit.org/show_bug.cgi?id=142422
1666
1667         Reviewed by Benjamin Poulain.
1668
1669         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1670         (TestWebKitAPI::testRequest):
1671         (TestWebKitAPI::mainDocumentRequest):
1672         (TestWebKitAPI::TEST_F):
1673         (TestWebKitAPI::testURL): Deleted.
1674
1675 2015-03-10  Sam Weinig  <sam@webkit.org>
1676
1677         Allow adding a button in input elements for auto fill related functionality
1678         <rdar://problem/19782066>
1679         https://bugs.webkit.org/show_bug.cgi?id=142564
1680
1681         Reviewed by Anders Carlsson.
1682
1683         * WebKitTestRunner/TestController.cpp:
1684         (WTR::TestController::createOtherPage):
1685         (WTR::TestController::createWebViewWithOptions):
1686         Update for new callback.
1687
1688 2015-03-11  Benjamin Poulain  <bpoulain@apple.com>
1689
1690         Add basic support for BOL and EOL assertions to the URL Filter parser
1691         https://bugs.webkit.org/show_bug.cgi?id=142568
1692
1693         Reviewed by Alex Christensen.
1694
1695         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1696         (TestWebKitAPI::TEST_F):
1697
1698 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1699
1700         [GTK] Add support for handling TLS errors to MiniBrowser
1701         https://bugs.webkit.org/show_bug.cgi?id=142576
1702
1703         Reviewed by Sergio Villar Senin.
1704
1705         It's useful for testing TLS errors handling itself, but also to
1706         allow ignoring TLS errors when testing.
1707
1708         * MiniBrowser/gtk/BrowserWindow.c:
1709         (webViewLoadFailedWithTLSerrors):
1710         (browserWindowConstructed):
1711
1712 2015-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
1713
1714         Use out-of-band messaging for RenderBox::firstLineBaseline() and RenderBox::inlineBlockBaseline()
1715         https://bugs.webkit.org/show_bug.cgi?id=142569
1716
1717         Reviewed by David Hyatt.
1718
1719         Test Optional::valueOrCompute().
1720
1721         * TestWebKitAPI/Tests/WTF/Optional.cpp:
1722         (TestWebKitAPI::TEST):
1723
1724 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1725
1726         [GTK] Add an option to enable MiniBrowser for non developer builds and always install it
1727         https://bugs.webkit.org/show_bug.cgi?id=126688
1728
1729         Reviewed by Gustavo Noronha Silva.
1730
1731         * CMakeLists.txt: Build testing tools only for developer builds,
1732         but MiniBrowser when ENABLE_MINIBROWSER option is ON.
1733         * MiniBrowser/gtk/CMakeLists.txt: Only add
1734         -DWEBKIT_INJECTED_BUNDLE_PATH to the build for developer builds,
1735         and add a rule to install the MiniBrowser.
1736         * MiniBrowser/gtk/main.c:
1737         (main): Only set WEBKIT_INJECTED_BUNDLE_PATH env var for developer
1738         builds.
1739
1740 2015-03-11  Brent Fulgham  <bfulgham@apple.com>
1741
1742         Add some DateMath tests to TestWebKitAPI
1743         https://bugs.webkit.org/show_bug.cgi?id=142565
1744
1745         Reviewed by Alexey Proskuryakov.
1746
1747         * TestWebKitAPI/CMakeLists.txt: Add new DateMath.cpp file.
1748         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
1749         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
1750         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto."
1751         * TestWebKitAPI/Tests/WTF/DateMath.cpp: Added.
1752
1753 2015-03-10  Brent Fulgham  <bfulgham@apple.com>
1754
1755         Regression(r181257): WTF_WorkQueue.Simple is flaky
1756         https://bugs.webkit.org/show_bug.cgi?id=142560
1757
1758         Unreviewed attempt to improve test stability.
1759
1760         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Check the reference count for
1761         the WorkQueue a little later to redue flakiness.
1762
1763 2015-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
1764
1765         Migrate from SystemUIFontSelect to AppleSystemFontOSSubversion
1766         https://bugs.webkit.org/show_bug.cgi?id=142555
1767
1768         Reviewed by Simon Fraser.
1769
1770         * DumpRenderTree/mac/DumpRenderTree.mm:
1771         (setDefaultsToConsistentValuesForTesting):
1772         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1773         (WTR::InjectedBundle::platformInitialize):
1774
1775 2015-03-10  Alex Christensen  <achristensen@webkit.org>
1776
1777         Use unsigned for HashSet size.
1778         https://bugs.webkit.org/show_bug.cgi?id=142518
1779
1780         Reviewed by Benjamin Poulain.
1781
1782         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1783         (TestWebKitAPI::TEST):
1784         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1785         (TestWebKitAPI::testInitialCapacity):
1786         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
1787         (TestWebKitAPI::TEST):
1788
1789 2015-03-10  Daniel Bates  <dabates@apple.com>
1790
1791         [iOS] Add WebKitSystemInterface for iOS 8.2
1792         https://bugs.webkit.org/show_bug.cgi?id=142505
1793
1794         Rubber-stamped by Anders Carlsson.
1795
1796         Make copy-webkitlibraries-to-product-directory install libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a.
1797         I inadvertently forgot to add libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a to script
1798         copy-webkitlibraries-to-product-directory in r181286.
1799
1800         * Scripts/copy-webkitlibraries-to-product-directory:
1801
1802 2015-03-10  Benjamin Poulain  <bpoulain@apple.com>
1803
1804         Extend URL filter's Term definition to support groups/subpatterns
1805         https://bugs.webkit.org/show_bug.cgi?id=142519
1806
1807         Reviewed by Alex Christensen.
1808
1809         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1810         (TestWebKitAPI::testURL):
1811
1812 2015-03-06  Jer Noble  <jer.noble@apple.com>
1813
1814         Add an option to run-webkit-tests to override the LayoutTests/ directory
1815         https://bugs.webkit.org/show_bug.cgi?id=142418
1816
1817         Reviewed by David Kilzer.
1818
1819         Add an arugment to run-webkit-tests which, when set, overrides the port's default LayoutTests
1820         directory. The base port will parse the options during initialization and store the override
1821         location if present. layout_tests_dir() will return this overridden location if set.
1822
1823         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1824         (parse_args):
1825         * Scripts/webkitpy/port/base.py:
1826         (Port.__init__):
1827         (Port.layout_tests_dir):
1828
1829 2015-03-09  Martin Robinson  <mrobinson@igalia.com>
1830
1831         [CMake] Enable WorkQueue tests for CMake ports
1832         https://bugs.webkit.org/show_bug.cgi?id=142473
1833
1834         Reviewed by Darin Adler.
1835
1836         * TestWebKitAPI/CMakeLists.txt: Add the WorkQueue tests source file to
1837         the list of source files.
1838         * Tools/TestWebKitAPI/PlatformEfl.cmake: Add the DispatchQueueEfl directory
1839         to the list of include directories for EFL.
1840
1841 2015-03-09  David Kilzer  <ddkilzer@apple.com>
1842
1843         Attempt to fix timeouts on iOS Simulator layout tests
1844
1845         * Scripts/webkitpy/port/ios.py:
1846         (IOSSimulatorPort.setup_test_run): Most layout test runs on iOS
1847         Simulator end after the first 50 tests time out.  Some analysis
1848         this past weekend shows that the 'Booted' status in the output
1849         of `xcrun simctl list` is not sufficient (and watching the test
1850         run shows that SpringBoard hasn't fully started to the point
1851         where it's displaying icons on the home screen).  The workaround
1852         until we have a better fix is to add an arbitrary timeout to let
1853         SpringBoard finish launching.  In practice, 15 seconds is
1854         probably enough, but 30 seconds should nearly always work.
1855
1856 2015-03-09  Per Arne Vollan  <peavo@outlook.com>
1857
1858         Unreviewed. Add myself as a committer.
1859
1860         * Scripts/webkitpy/common/config/contributors.json:
1861
1862 2015-03-09  David Kilzer  <ddkilzer@apple.com>
1863
1864         Attempt to fix WTF_WorkQueue.TwoQueues timeout test failure
1865
1866         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1867         (TestWebKitAPI::TEST): Change delay from 50ns to 50ms, and add
1868         an expectation that will fail if we hit the race condition.
1869         This test is inherently racy and will deadlock if the first job
1870         for queue2 takes the mutex lock before the second job for
1871         queue1.
1872
1873 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
1874
1875         [Win] WTF::WorkQueue does not balance ref/deref properly
1876         https://bugs.webkit.org/show_bug.cgi?id=142471
1877
1878         Reviewed by Antti Koivisto.
1879
1880         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1881         (TestWebKitAPI::TEST): Check that the refcount is correct.
1882
1883 2015-03-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1884
1885         Do not show passing test result on output of EFL layout test
1886         https://bugs.webkit.org/show_bug.cgi?id=142380
1887
1888         Reviewed by Darin Adler.
1889
1890         To show passing tests has caused inconvenience when we detect problem tests
1891         in output of layout test. So this patch applies '--debug-rwt-logging' except for EFL port
1892         in order not to show passing tests in the output of EFL layout test.
1893
1894         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1895         (RunWebKitTests.start):
1896
1897 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
1898
1899         Unreviewed build fix.
1900
1901         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1902         (TestWebKitAPI::TEST): Remove two unused variables.
1903
1904 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
1905
1906         Add some WorkQueue tests to TestWebKitAPI
1907         https://bugs.webkit.org/show_bug.cgi?id=142447
1908
1909         Reviewed by Sam Weinig.
1910
1911         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1912         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1913         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1914         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Added.
1915         (TestWebKitAPI::simpleTest):
1916         (TestWebKitAPI::longTest):
1917         (TestWebKitAPI::thirdTest):
1918         (TestWebKitAPI::finishedTests):
1919         (TestWebKitAPI::TEST):
1920         (TestWebKitAPI::longTest2):
1921
1922 2015-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1923
1924         Remove willDestroyFrame in WKBundlePageLoaderClient
1925         https://bugs.webkit.org/show_bug.cgi?id=142389
1926
1927         Reviewed by Anders Carlsson.
1928
1929         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1930         (WTR::InjectedBundlePage::InjectedBundlePage):
1931
1932 2015-03-07  Brent Fulgham  <bfulgham@apple.com>
1933
1934         [Win] Increase TestWebKitAPI Test Coverage[Win] Increase TestWebKitAPI Test Coverage
1935         https://bugs.webkit.org/show_bug.cgi?id=142433
1936
1937         Reviewed by Darin Adler.
1938
1939         Include more TestWebKitAPI tests when building for Windows. Also
1940         fix a build error in MetaAllocator.cpp caused by one of the
1941         Microsoft headers #defining 'small'.
1942
1943         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1944         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1945         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1946
1947 2015-03-06  Sam Weinig  <sam@webkit.org>
1948
1949         [Content Extensions] Move compiling of content extensions to the UIProcess
1950         https://bugs.webkit.org/show_bug.cgi?id=142402
1951
1952         Reviewed by Benjamin Poulain.
1953
1954         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1955         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: Copied from Tools/TestWebKitAPI/Tests/WebCore/ContentFilter.cpp.
1956         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
1957         (TestWebKitAPI::InMemoryCompiledContentExtension::~InMemoryCompiledContentExtension):
1958         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
1959         (TestWebKitAPI::TEST_F):
1960         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Removed.
1961         Update test for new name (ContentFilter -> ContentExtensions) and API (CompiledContentExtension
1962         is now abstract).
1963
1964 2015-03-06  Brent Fulgham  <bfulgham@apple.com>
1965
1966         [Win] Correct Windows build.
1967
1968         Rubberstamped by Michael Saboff
1969
1970         * win/AssembleBuildLogs/AssembleLogs.cmd: Correct cut/paste error
1971         in the GOTO labels.
1972
1973 2015-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1974
1975         [GTK] Test /webkit2/WebKitWebView/sync-request-on-max-conns might fail after finished
1976         https://bugs.webkit.org/show_bug.cgi?id=142385
1977
1978         Reviewed by Sergio Villar Senin.
1979
1980         Use stack allocated GMainLoopSources to make sure they are
1981         cancelled automatically if the test finishes before they have
1982         been processed.
1983
1984         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1985         (testWebViewSyncRequestOnMaxConns):
1986
1987 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
1988
1989         Remove Mountain Lion libraries since ML isn't supported
1990         https://bugs.webkit.org/show_bug.cgi?id=142332
1991
1992         Reviewed by Darin Adler.
1993
1994         * Scripts/copy-webkitlibraries-to-product-directory:
1995
1996 2015-03-06  Carlos Alberto Lopez Perez <clopez@igalia.com> and Youenn Fablet  <youenn.fablet@crf.canon.fr>
1997
1998         Layout tests imported/w3c/web-platform-tests certificates should not be tracked on WebKit VCS
1999         https://bugs.webkit.org/show_bug.cgi?id=142083
2000
2001         Reviewed by Simon Fraser.
2002
2003         Modifying on the fly wpt config.json to set the directory where to generate/read certificates as a subfolder of the layout test results folder.
2004
2005         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2006         (WebPlatformTestServer._copy_webkit_test_files):
2007
2008 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
2009
2010         setup-git-clone fails due to the failure to download python-irclib-0.4.8
2011         https://bugs.webkit.org/show_bug.cgi?id=141946
2012
2013         Reviewed by Ryosuke Niwa.
2014
2015         Check in ircbot.py and irclib.py to avoid network problems in the future.
2016
2017         * Scripts/webkitpy/common/net/irc/ircbot.py:
2018         * Scripts/webkitpy/thirdparty/__init__.py:
2019         (AutoinstallImportHook.find_module):
2020         (AutoinstallImportHook._install_irc): Deleted.
2021         * Scripts/webkitpy/thirdparty/__init___unittest.py:
2022         (ThirdpartyTest.test_imports):
2023         * Scripts/webkitpy/thirdparty/irc/__init__.py: Added.
2024         * Scripts/webkitpy/thirdparty/irc/ircbot.py: Added.
2025         * Scripts/webkitpy/thirdparty/irc/irclib.py: Added.
2026
2027 2015-03-06  David Kilzer  <ddkilzer@apple.com>
2028
2029         Dashboard: Perf bot status is missing for Apple {Mavericks,Yosemite} Release builds
2030
2031         See also fix to config.json in r181097.
2032
2033         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2034         (WebKitBuildbot): Add missing "WK2" to the names of the perf
2035         bots.
2036
2037 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
2038
2039         run-jsc-stress-tests should determine the architecture from ELF binaries
2040         https://bugs.webkit.org/show_bug.cgi?id=142335
2041
2042         Reviewed by Darin Adler.
2043
2044         * Scripts/run-jsc-stress-tests:
2045
2046 2015-03-05  David Kilzer  <ddkilzer@apple.com>
2047
2048         [iOS] TestExpectations for ios-simulator-wk2 should fall back to 'wk2' after 'ios-simulator'
2049         <http://webkit.org/b/142226>
2050
2051         Reviewed by Darin Adler.
2052
2053         * Scripts/webkitpy/port/ios.py:
2054         (IOSSimulatorPort.default_baseline_search_path): Switch the
2055         TestExpectations order of ios-simulator-wk2 from this:
2056           ios-simulator-wk2, wk2, ios-simulator
2057         To this:
2058           ios-simulator-wk2, ios-simualtor, wk2
2059
2060 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
2061
2062         [Win] Provide tiered logging from MSBuild -- Errors on top, Warnings after
2063         https://bugs.webkit.org/show_bug.cgi?id=142370
2064
2065         Reviewed by Dean Jackson.
2066
2067         * Scripts/webkitdirs.pm:
2068         (buildVisualStudioProject): Tell MSBuild to output log files to two separate
2069         logs, one for warnings, the other for errors.
2070         * win/AssembleBuildLogs/AssembleLogs.cmd: Combine the error and warning logs
2071         into the standard BuildOutput.htm document.
2072
2073 2015-03-05  David Kilzer  <ddkilzer@apple.com>
2074
2075         Dashboard has trouble parsing iOS test output
2076         <http://webkit.org/b/142364>
2077
2078         Reviewed by Alex Christensen.
2079
2080         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2081         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
2082         Add fallback path to build a regex using 'matchString' so that
2083         it matches anywhere in the line.  In practice, 'matchString' is
2084         a prefix for the label following the number.
2085
2086 2015-03-05  Alex Christensen  <achristensen@webkit.org>
2087
2088         Fix linker warnings in TestWebKitAPI.
2089         https://bugs.webkit.org/show_bug.cgi?id=141912
2090
2091         Reviewed by David Kilzer.
2092
2093         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2094         Do not export TearDownTestCase or SetUpTestCase symbols.
2095
2096 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
2097
2098         [Win] Unreviewed EWS fix.
2099
2100         * Scripts/webkitdirs.pm:
2101         (buildVisualStudioProject): Dial logging back to 'ErrorsOnly' to see if that makes
2102         the EWS output more usable.
2103
2104 2015-03-05  Chris Dumez  <cdumez@apple.com>
2105
2106         Regression(r173761): ASSERTION FAILED: !is8Bit() in StringImpl::characters16()
2107         https://bugs.webkit.org/show_bug.cgi?id=142350
2108
2109         Reviewed by Michael Saboff and Benjamin Poulain.
2110
2111         Add API test for WTFString::hasInfixStartingAt() to make sure it doesn't
2112         crash if the string is 8-bit but the pattern is 16-bit (and vice-versa).
2113
2114         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2115         (TestWebKitAPI::TEST):
2116
2117 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
2118
2119         [Win] Ensure build target directory exists when launching MSBuild
2120         https://bugs.webkit.org/show_bug.cgi?id=142360
2121
2122         Reviewed by Dean Jackson.
2123
2124         Create the build output directory (if it doesn't exist) before
2125         launching MSBuild so that it can immediately begin writing logs.
2126
2127         * Scripts/webkitdirs.pm:
2128         (buildVisualStudioProject):
2129
2130 2015-03-05  Chris Dumez  <cdumez@apple.com>
2131
2132         run-webkit-tests and run-perf-tests should use WebKitTestRunner by default
2133         https://bugs.webkit.org/show_bug.cgi?id=142325
2134
2135         Reviewed by Csaba Osztrogonác.
2136
2137         run-webkit-tests and run-perf-tests now use WebKitTestRunner by default.
2138         As a result, "--webkit-test-runner / -2" parameters are replaced by
2139         "--dump-render-tree / -1" so developers can run DumpRenderTree rather
2140         than WebKitTestRunner.
2141
2142         * BuildSlaveSupport/build.webkit.org-config/config.json:
2143         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2144         (RunWebKit1Tests):
2145         (RunWebKit1Tests.start):
2146         (RunWebKit1LeakTests):
2147         (RunWebKit1LeakTests.start):
2148         (RunAndUploadPerfTestsWebKit1):
2149         (RunAndUploadPerfTestsWebKit1.start):
2150         (TestFactory):
2151         (TestWebKit1LeaksFactory):
2152         (TestWebKit1LeaksFactory.__init__):
2153         (TestWebKit1Factory):
2154         (TestWebKit1AllButJSCFactory):
2155         (TestAllButJSCFactory):
2156         (BuildAndPerfTestWebKit1Factory):
2157         (BuildAndPerfTestWebKit1Factory.__init__):
2158         (BuildAndPerfTestFactory):
2159         (BuildAndPerfTestFactory.__init__):
2160         (DownloadAndPerfTestWebKit1Factory):
2161         (DownloadAndPerfTestWebKit1Factory.__init__):
2162         (DownloadAndPerfTestFactory):
2163         (DownloadAndPerfTestFactory.__init__):
2164         (RunWebKitLeakTests): Deleted.
2165         (RunWebKitLeakTests.start): Deleted.
2166         (RunWebKit2Tests): Deleted.
2167         (RunWebKit2Tests.start): Deleted.
2168         (RunAndUploadPerfTestsWebKit2): Deleted.
2169         (RunAndUploadPerfTestsWebKit2.start): Deleted.
2170         (TestLeaksFactory): Deleted.
2171         (TestLeaksFactory.__init__): Deleted.
2172         (TestWebKit2Factory): Deleted.
2173         (TestWebKit2AndJSCFactory): Deleted.
2174         (BuildAndPerfTestWebKit2Factory): Deleted.
2175         (BuildAndPerfTestWebKit2Factory.__init__): Deleted.
2176         (DownloadAndPerfTestWebKit2Factory): Deleted.
2177         (DownloadAndPerfTestWebKit2Factory.__init__): Deleted.
2178         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2179         (parse_args):
2180         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2181         (PerfTestsRunner._parse_args):
2182         * Scripts/webkitpy/port/port_testcase.py:
2183         (PortTestCase.test_build_driver):
2184
2185 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
2186
2187         [Win] Switch to MSBuild so we get more useful stdout logging in buildbot
2188         https://bugs.webkit.org/show_bug.cgi?id=140845
2189
2190         Reviewed by David Kilzer.
2191
2192         Update 'webkitdirs.pm' to locate the MSBuild used with Visual Studio 2013
2193         and generate suitable build commands to drive a full build from our
2194         existing solution files.
2195
2196         * Scripts/webkitdirs.pm:
2197         (msBuildInstallDir): Added.
2198         (determineConfigurationForVisualStudio): Revise to use MSBuild command
2199         line arguments to drive the build.
2200         (setupCygwinEnv): Warn user if MSBuild cannot be located.
2201         (buildVisualStudioProject): Revise to use MSBuild command line arguments
2202         to specify build architecture.
2203         * win/AssembleBuildLogs/AssembleLogs.cmd: MSBuild doesn't produce individual
2204         output logs, so don't attempt to consolidate them. Also: Drive-by fix: Don't
2205         bother looking for CoreUI or SafariTheme build logs.
2206
2207 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
2208
2209         [buildbot] mastercfg_unittest.py should be runnable easily
2210         https://bugs.webkit.org/show_bug.cgi?id=142219
2211
2212         Reviewed by Chris Dumez.
2213
2214         Buildbot 0.8.6p1 runs on build.webkit org with Twisted 12.1.0, which is
2215         the last Twisted version works together with this buildbot version.
2216
2217         * Scripts/webkitpy/common/system/autoinstall.py:
2218         (AutoInstaller): Added prepend_to_search_path argument to be able
2219         to prefer autoinstalled package to system package.
2220         (AutoInstaller.__init__):
2221         (AutoInstaller._set_up_target_dir):
2222         (AutoInstaller._extract_tar): Renamed from _extract_targz, now it works with tar.bz2 too.
2223         (AutoInstaller._prepare_package):
2224         (AutoInstaller._extract_targz): Renamed to _extract_tar.
2225         * Scripts/webkitpy/thirdparty/__init__.py:
2226         (AutoinstallImportHook._install_buildbot): Autoinstall Twisted 12.1.0.
2227
2228 2015-03-05  Lukasz Bialek  <l.bialek@samsung.com>
2229
2230         [EFL][WK2] Crash when "Download Linked File" from MiniBrowser context menu is clicked
2231         https://bugs.webkit.org/show_bug.cgi?id=131162
2232
2233         Reviewed by Gyuyoung Kim.
2234
2235         * MiniBrowser/efl/main.c:
2236         (on_download_request):
2237         (on_download_finished):
2238         (on_download_failed):
2239         (window_create):
2240         Adapt download callbacks to new callback mechanism
2241
2242 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2243
2244         Unreviewed. Fix /webkit2/WebKitWebResource/mime-type after r180927.
2245
2246         In r180927 we updated the libsoup version used by the jhbuild. In
2247         this new version the sniffer uses image/x-icon instead of
2248         image/vnd.microsoft.icon for blank.ico resource.
2249
2250         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2251         (testWebResourceMimeType):
2252
2253 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2254
2255         [SOUP] Check TLS errors as soon as they are set in the SoupMessage
2256         https://bugs.webkit.org/show_bug.cgi?id=142244
2257
2258         Reviewed by Sergio Villar Senin.
2259
2260         Check that the SSL server doesn't process any request in case of
2261         TLS errors when the policy is set to FAIL.
2262
2263         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2264         (testTLSErrorsPolicy):
2265         (testTLSErrorsRedirect):
2266         (testTLSErrorsHTTPAuth):
2267         (testLoadFailedWithTLSErrors):
2268         (testSubresourceLoadFailedWithTLSErrors):
2269         (httpsServerCallback):
2270
2271 2015-03-05  Pawel Forysiuk  <p.forysiuk@samsung.com>
2272
2273         [EFL] REGRESSION (r178685): ASSERTION FAILED: !parameters.mediaKeyStorageDirectory.isEmpty()
2274         https://bugs.webkit.org/show_bug.cgi?id=141154
2275
2276         Reviewed by Jer Noble.
2277
2278         Unlike GTK, EFL port enables ENABLE_ENCRYPTED_MEDIA_V2 build option by default.
2279
2280         For the sake of completeness WebKitTestRunner should specify temporary
2281         folder for MediaKeysStorageDirecory as well as IndexedDB, LocalStorage, etc.
2282
2283         Default non legacy paths are set up in ProcessPoolConfiguration constructor.
2284         They use WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
2285         to get data storage paths. Only Mac port has an actual implementation of it.
2286         However, WebKitTestRunner overrides them in favour of unique temporary dir
2287         which is taken from libraryPathForTesting().
2288
2289         Since WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
2290         is not implemented for EFL and GTK ports it returns an empty string.
2291         All default data folders besides MediaKeys are overridden in TestRunner
2292         code with unique temporary folders derived from DUMPRENDERTREE_TEMP
2293         env variable.
2294
2295         GTK port does not enable encrypted keys by default so
2296         WebMediaKeyStorageManager::initialize() code path is never triggered.
2297
2298         * WebKitTestRunner/TestController.cpp:
2299         (WTR::TestController::initialize): Set MediaKeysStorageDirectory for all
2300         WebKit ports.
2301
2302 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
2303
2304         [buildbot] Add regression test to check which builder runs which tests
2305         https://bugs.webkit.org/show_bug.cgi?id=142166
2306
2307         Reviewed by Alexey Proskuryakov.
2308
2309         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2310         (BuildStepsConstructorTest.createTest):
2311         (BuildStepsTest):
2312         (BuildStepsTest.generateTests):
2313         (BuildStepsTest.createTest):
2314         (BuildStepsTest.createTest.doTest):
2315         (BuildStepsTest.test_unnecessary_expected_results):
2316
2317 2015-03-04  Commit Queue  <commit-queue@webkit.org>
2318
2319         Unreviewed, rolling out r181054.
2320         https://bugs.webkit.org/show_bug.cgi?id=142320
2321
2322         Broke the api tests (Requested by sundiamonde on #webkit).
2323
2324         Reverted changeset:
2325
2326         "Fix linker warnings in TestWebKitAPI."
2327         https://bugs.webkit.org/show_bug.cgi?id=141912
2328         http://trac.webkit.org/changeset/181054
2329
2330 2015-03-04  Alex Christensen  <achristensen@webkit.org>
2331
2332         Fix linker warnings in TestWebKitAPI.
2333         https://bugs.webkit.org/show_bug.cgi?id=141912
2334
2335         Reviewed by David Kilzer.
2336
2337         * TestWebKitAPI/Configurations/Base.xcconfig:
2338         Use GCC_SYMBOLS_PRIVATE_EXTERN like we do in WebCore.
2339
2340 2015-03-04  Alexey Proskuryakov  <ap@apple.com>
2341
2342         [Mac] Set SystemUIFontSelect in DRT and WKTR
2343         https://bugs.webkit.org/show_bug.cgi?id=142303
2344
2345         Reviewed by Myles C. Maxfield.
2346
2347         * DumpRenderTree/mac/DumpRenderTree.mm:
2348         (setDefaultsToConsistentValuesForTesting):
2349         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2350         (WTR::InjectedBundle::platformInitialize):
2351
2352 2015-03-04  Chris Dumez  <cdumez@apple.com>
2353
2354         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
2355         https://bugs.webkit.org/show_bug.cgi?id=142314
2356         <rdar://problem/20046835>
2357
2358         Reviewed by Ryosuke Niwa.
2359
2360         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
2361         to get WK2 code coverage.
2362
2363         * BuildSlaveSupport/build.webkit.org-config/config.json:
2364
2365 2015-03-04  Alex Christensen  <achristensen@webkit.org>
2366
2367         Move content extensions test to properly named directory.
2368         https://bugs.webkit.org/show_bug.cgi?id=142299
2369
2370         Reviewed by Tim Horton.
2371
2372         * WebKitTestRunner/mac/TestControllerMac.mm:
2373         (WTR::TestController::platformConfigureViewForTest):
2374
2375 2015-03-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2376
2377         W3C test importer should use filesystem instead of os.walk
2378         https://bugs.webkit.org/show_bug.cgi?id=142085
2379
2380         Reviewed by Bem Jones-Bey.
2381
2382         Added FileSystem.dirs_under to remove the use of os.walk in test importer.
2383         Added MockFileSystem.dirs_under and MockFileSystem.getsize to enable unit testing of test importer.
2384         Added unit test for FileSystem.dirs_under and MockFileSystem.dirs_under.
2385
2386         Made use of FileSystem.dirs_under within TestImporter.find_importable_tests.
2387         Added a unit test to check that test importer is now black-box testable using a Mock system.
2388
2389         * Scripts/webkitpy/common/system/filesystem.py:
2390         (FileSystem.dirs_under): Returns a list of filtered sub-directories.
2391         (FileSystem.dirs_under.filter_all):
2392         * Scripts/webkitpy/common/system/filesystem_mock.py:
2393         (MockFileSystem.dirs_under):
2394         (MockFileSystem.dirs_under.filter_all):
2395         (MockFileSystem.getsize):
2396         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
2397         (MockFileSystemTest.test_dirs_under):
2398         (MockFileSystemTest.test_dirs_under.filter_dir):
2399         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2400         (RealFileSystemTest.test_sep):
2401         (RealFileSystemTest):
2402         (RealFileSystemTest.test_dirs_under):
2403         (RealFileSystemTest.test_dirs_under.filter_this_dir):
2404         * Scripts/webkitpy/w3c/test_importer.py:
2405         (TestImporter.do_import):
2406         (TestImporter.find_importable_tests.should_keep_subdir):
2407         (TestImporter.find_importable_tests):
2408         (TestImporter.should_keep_subdir): Deleted.
2409         (TestImporter.should_skip_file): Deleted.
2410         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2411         (TestImporterTest.test_import_dir_with_empty_init_py): Added test to ensure empty __init__.py are no longer empty once imported.
2412
2413 2015-03-04  Timothy Horton  <timothy_horton@apple.com>
2414
2415         [WebEditingTester] Add support for the find and replace bar
2416         https://bugs.webkit.org/show_bug.cgi?id=142247
2417
2418         Reviewed by Enrica Casucci.
2419
2420         While it's not hooked up yet in WKWebView, adding support for the
2421         find bar to WebEditingTester will help us implement that functionality.
2422
2423         * WebEditingTester/AppDelegate.h:
2424         * WebEditingTester/AppDelegate.m:
2425         (-[WebEditingAppDelegate performTextFinderAction:]):
2426         * WebEditingTester/MainMenu.xib:
2427         Receive performTextFinderAction: and forward it to the frontmost WebDocumentController.
2428
2429         * WebEditingTester/WK2WebDocumentController.m:
2430         (-[WK2WebDocumentController awakeFromNib]):
2431         (-[WK2WebDocumentController performTextFinderAction:]):
2432         (-[WK2WebDocumentController findBarView]):
2433         (-[WK2WebDocumentController setFindBarView:]):
2434         (-[WK2WebDocumentController isFindBarVisible]):
2435         (-[WK2WebDocumentController setFindBarVisible:]):
2436         (-[WK2WebDocumentController findBarViewDidChangeHeight]):
2437         (-[WK2WebDocumentController layout]):
2438         Implement performTextFinderAction: for WebKit2, and have a NSTextFinder
2439         pointing at the WKWebView (currently nothing will work, but the bar will
2440         show up). Install and uninstall the bar as needed.
2441
2442         * WebEditingTester/WebDocument.xib:
2443         Don't use a full-size content view. There's no need, and it makes find
2444         bar layout harder.
2445
2446         * WebEditingTester/WebDocumentController.h:
2447         * WebEditingTester/WebDocumentController.m:
2448         (-[WebDocumentController performTextFinderAction:]):
2449
2450 2015-03-03  Sam Weinig  <sam@webkit.org>
2451
2452         [Content Extensions] Split parsing and compiling of content extensions into their own files
2453         https://bugs.webkit.org/show_bug.cgi?id=142259
2454
2455         Reviewed by Anders Carlsson.
2456
2457         Add basic unit test for the content filter compiler.
2458
2459         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2460         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Added.
2461         (WebCore::ContentExtensions::operator<<):
2462         (TestWebKitAPI::ContentFilterTest::SetUp):
2463         (TestWebKitAPI::TEST_F):
2464
2465 2015-03-04  Matthew Mirman  <mmirman@apple.com>
2466
2467         Cleaned up BuildAndTestFactory to not be a near duplicate of TestFactory
2468         https://bugs.webkit.org/show_bug.cgi?id=142230
2469
2470         Reviewed by Csaba Osztrogonác.
2471
2472         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2473         (TestFactory):
2474         (TestFactory.getProduct): Added
2475         (TestFactory.__init__): moved downloader to getProduct
2476         (BuildAndTestFactory):        
2477         (BuildAndTestFactory.getProduct): Added
2478         (BuildAndTestFactory.__init__): made to call TestFactory.__init__ and append steps to the end.
2479         (BuildAndTestWebKit2Factory): Deleted.  Wasn't used anywhere.
2480
2481 2015-03-04  Debarshi Ray  <debarshir@gnome.org>
2482
2483         [GTK] WebView should hold a reference on WebContext because non-default contexts are a reality
2484         https://bugs.webkit.org/show_bug.cgi?id=142225
2485
2486         Reviewed by Carlos Garcia Campos.
2487
2488         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2489         (testWebViewWebContextLifetime):
2490         (beforeAll):
2491
2492 2015-03-03  David Kilzer  <ddkilzer@apple.com>
2493
2494         [iOS] Crash logs can't be found on ios-simulator because WebKitTestRunner returns the wrong process name
2495         <http://webkit.org/b/142243>
2496
2497         Reviewed by Alexey Proskuryakov.
2498
2499         * WebKitTestRunner/TestController.cpp:
2500         (WTR::TestController::webProcessName):
2501         (WTR::TestController::networkProcessName):
2502         - Return the same process name on iOS and Mac because they both
2503           use the same process name for local engineering builds.
2504
2505 2015-03-03  David Kilzer  <ddkilzer@apple.com>
2506
2507         check-webkit-style: Add exception for FrameworkSoftLink.h header order
2508         <http://webkit.org/b/141872>
2509
2510         Reviewed by Alex Christensen.
2511
2512         * Scripts/webkitpy/style/checkers/cpp.py: Remove unneeded
2513         semi-colons in various places and fix whitespace.
2514         (_IncludeState): Add _SOFT_LINK_HEADER and _SOFT_LINK_SECTION
2515         constants.
2516         (_IncludeState.__init__): Add self._visited_soft_link_section
2517         boolean state variable.
2518         (_IncludeState.visited_soft_link_section): Getter for
2519         self._visited_soft_link_section.
2520         (_IncludeState.check_next_include_order): Update state machine
2521         for soft-link headers.  Add check that soft-link headers always
2522         appear last.
2523         (_classify_include): Add check for soft-link header type.
2524         (check_include_line): Return early if there is a soft-link
2525         header error.
2526
2527         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2528         (OrderOfIncludesTest.test_public_primary_header): Add tests for
2529         including soft-link headers.
2530         (OrderOfIncludesTest.test_classify_include): Add test for
2531         _SOFT_LINK_HEADER type.
2532
2533 2015-03-03  Alexey Proskuryakov  <ap@apple.com>
2534
2535         build.webkit.org/dashboard: Don't repeatedly handle each test type
2536         https://bugs.webkit.org/show_bug.cgi?id=142211
2537
2538         Reviewed by Tim Horton and Matt Hanson.
2539
2540         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2541         (Buildbot.prototype.javascriptTestResultsURLForIteration): Deleted.
2542         (Buildbot.prototype.apiTestResultsURLForIteration): Deleted.
2543         (Buildbot.prototype.platformAPITestResultsURLForIteration): Deleted.
2544         (Buildbot.prototype.webkitpyTestResultsURLForIteration): Deleted.
2545         (Buildbot.prototype.webkitperlTestResultsURLForIteration): Deleted.
2546         (Buildbot.prototype.bindingsTestResultsURLForIteration): Deleted.
2547         Removed functions that build a link to test step results. The buildbot provides
2548         these links in JSON.
2549
2550         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2551         (BuildbotIteration): Put failing tests into an array, instead of named variables.
2552         (BuildbotIteration.ProductiveSteps): Removed step names that are not used on build.webkit.org.
2553         We can easily add them to the map as needed.
2554         (BuildbotIteration.TestSteps): Added a list of test steps to be displayed by test queues.
2555         (BuildbotIteration.prototype._parseData): Moved code for parsing step results away
2556         to BuildbotTestResults class. We used to parse here, build an intermediate data structure,
2557         and then build a BuildbotTestResults object, which was strange.
2558         (BuildbotIteration.prototype.loadLayoutTestResults): Ditto.
2559
2560         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2561         Corrected an unrelated assertion that was buggy, and kept firing.
2562
2563         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2564         (BuildbotTestResults):
2565         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
2566         (BuildbotTestResults.prototype._parseResults):
2567         (BuildbotTestResults.prototype.addFullLayoutTestResults):
2568         Moved the code for parsing JSON results for a single step here.
2569
2570         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2571         (BuildbotTesterQueueView.prototype._testStepFailureDescription):
2572         (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount):
2573         (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
2574         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Deleted.
2575         (BuildbotTesterQueueView.prototype.update): Deleted.
2576         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Deleted.
2577         Updated for the new data structures. One behavior change is that we now display individual
2578         counts when multiple test kinds fail, e.g. "1 javascript test failure, 83+ layout
2579         test failures, 3 platform api test failures".
2580
2581 2015-03-03  Matthew Mirman  <mmirman@apple.com>
2582
2583         JSC tests should not be repeated twice for each branch builder, and should if possible have their own queue.
2584         https://bugs.webkit.org/show_bug.cgi?id=142094
2585
2586         Reviewed by Csaba Osztrogonác.
2587
2588         * BuildSlaveSupport/build.webkit.org-config/config.json: Added bots 155 and 157
2589         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2590         (TestFactory):
2591         (TestFactory.__init__): Made running of JSC tests conditional.
2592         (TestAllButJSCFactory):
2593         (TestJSCFactory): Added.
2594         (TestJSCFactory.__init__):
2595         (TestWebKit2AndJSCFactory): Added factory to not run JSC tests on WebKit2.
2596
2597 2015-03-03  David Kilzer  <ddkilzer@apple.com>
2598
2599         `build-webkit --help` is wrong about how to build for the iOS simulator
2600         <http://webkit.org/b/142223>
2601
2602         Reviewed by Csaba Osztrogonác.
2603
2604         * Scripts/build-webkit: Fix help.
2605
2606 2015-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2607
2608         Unreviewed. Bump libsoup version to 2.49.91.1 to fix 32 bit build.
2609
2610         * gtk/jhbuild.modules:
2611
2612 2015-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2613
2614         [SOUP] Synchronous XMLHttpRequests can time out when we reach the max connections limit
2615         https://bugs.webkit.org/show_bug.cgi?id=141508
2616
2617         Reviewed by Sergio Villar Senin.
2618
2619         Add a unit test to check that synchronous XHRs load even if the
2620         maximum connection limits are reached.
2621
2622         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2623         (testWebViewSyncRequestOnMaxConns):
2624         (serverCallback):
2625         (beforeAll):
2626         * gtk/jhbuild.modules: Bump libsoup version to 2.49.91.
2627
2628 2015-03-02  Alexey Proskuryakov  <ap@apple.com>
2629
2630         Update the name of ASan build step.
2631
2632         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2633
2634 2015-03-02  Jer Noble  <jer.noble@apple.com>
2635
2636         [WK1][WK2][Mac] Fullscreen animation is incorrect when page is scaled.
2637         https://bugs.webkit.org/show_bug.cgi?id=142121
2638
2639         Reviewed by Simon Fraser.
2640
2641         Add a test which changes the WebView's page scale, then enters fullscreen mode, and verifies
2642         that the initial and final screen rects for the web content are as expected.
2643
2644         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2645         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.html: Added.
2646         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm: Added.
2647         (-[FullscreenStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
2648         (runJavaScriptAlert):
2649         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
2650         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
2651         (TestWebKitAPI::FullscreenZoomInitialFrame::setPageScale):
2652         (TestWebKitAPI::FullscreenZoomInitialFrame::sendMouseDownEvent):
2653         (TestWebKitAPI::FullscreenZoomInitialFrame::runTest):
2654         (TestWebKitAPI::TEST_F):
2655
2656 2015-03-01  David Kilzer  <ddkilzer@apple.com>
2657
2658         LayoutTestRealy: Prepend __XPC_ to the key, not the value!
2659
2660         Follow-up fix for:
2661
2662         LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
2663         <http://webkit.org/b/142145>
2664
2665         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2666         (-[LTRelayController _environmentVariables]): Fix think-o.
2667
2668 2015-03-01  David Kilzer  <ddkilzer@apple.com>
2669
2670         LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
2671         <http://webkit.org/b/142145>
2672
2673         Reviewed by Simon Fraser.
2674
2675         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2676         (-[LTRelayController _environmentVariables]): Add.
2677         (-[LTRelayController launchApp]): Use -_environmentVariables.
2678
2679 2015-02-28  David Kilzer  <ddkilzer@apple.com>
2680
2681         [iOS] Stop running webkit-build-directory on every layout test
2682
2683         This was originally fixed by David Farler for Bug 135409 in
2684         r172602.
2685
2686         * Scripts/webkitpy/port/ios.py:
2687         (IOSSimulatorPort.relay_path): Mark as @memoized so it doesn't
2688         run webkit-build-directory every time it's called.
2689
2690 2015-02-28  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2691
2692         W3C importer should use filesystem instead of shutil/host
2693         https://bugs.webkit.org/show_bug.cgi?id=142012
2694
2695         Reviewed by Bem Jones-Bey.
2696
2697         Removed direct use of python shutil and os, except for os.walk which will require its own fix.
2698
2699         * Scripts/webkitpy/w3c/test_importer.py:
2700         (main):
2701         (TestImporter.do_import):
2702         (TestImporter.find_importable_tests):
2703         (TestImporter.import_tests):
2704         (TestImporter.remove_deleted_files):
2705         (TestImporter.write_import_log):
2706
2707 2015-02-28  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2708
2709         W3C test importer should use filesystem to read and write files
2710         https://bugs.webkit.org/show_bug.cgi?id=142084
2711
2712         Reviewed by Bem Jones-Bey.
2713
2714         Use of FileSystem.write_binary_file, read_text_file and write_text_file in lieu of open().
2715
2716         * Scripts/webkitpy/w3c/test_importer.py:
2717         (TestImporter.import_tests):
2718         (TestImporter.remove_deleted_files):
2719         (TestImporter.write_import_log):
2720
2721 2015-02-27  Sam Weinig  <sam@webkit.org>
2722
2723         Add WebKit2 SPI to create a DOM File object
2724         https://bugs.webkit.org/show_bug.cgi?id=142109
2725
2726         Reviewed by Tim Horton.
2727
2728         Add a test for WKBundleFileHandleRef.
2729
2730         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2731         * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle.cpp: Added.
2732         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2733         (TestWebKitAPI::didFinishLoadForFrame):
2734         (TestWebKitAPI::TEST):
2735         * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle_Bundle.cpp: Added.
2736         (TestWebKitAPI::WKBundleFileHandleTest::WKBundleFileHandleTest):
2737         * TestWebKitAPI/Tests/WebKit2/bundle-file.html: Added.
2738
2739 2015-02-27  Michael Saboff  <msaboff@apple.com>
2740
2741         Add ability for run-jsc-benchmarks to set library path from test binary when run on a build bot
2742         https://bugs.webkit.org/show_bug.cgi?id=142112
2743
2744         Reviewed by Filip Pizlo.
2745
2746         Added check for VMs in the form of <someDir>/{DumpRenderTree,webkitTestRunner,jsc} and use
2747         <someDir> as the library path.
2748
2749         * Scripts/run-jsc-benchmarks:
2750
2751 2015-02-27  Alex Christensen  <achristensen@webkit.org>
2752
2753         [WinCairo] Unreviewed build fix.
2754
2755         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
2756         Use TestWebKitAPIPrefix.h like in TestWebKitAPICommon.props.
2757
2758 2015-02-27  Anders Carlsson  <andersca@apple.com>
2759
2760         Add infrastructure for handling website data in the network process
2761         https://bugs.webkit.org/show_bug.cgi?id=142092
2762
2763         Reviewed by Andreas Kling.
2764
2765         Add a menu item that will fetch all website data, delete the returned data records, and
2766         fetch all website data again so we can confirm that it's all empty.
2767
2768         * MiniBrowser/mac/WK2BrowserWindowController.m:
2769         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
2770
2771 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
2772
2773         [Win] Remove remaining SafariTheme cruft
2774         https://bugs.webkit.org/show_bug.cgi?id=142075
2775
2776         Reviewed by Anders Carlsson.
2777
2778         Remove reference to SafariTheme-switching preference.
2779
2780         * DumpRenderTree/win/DumpRenderTree.cpp:
2781         (resetWebPreferencesToConsistentValues):
2782         (prepareConsistentTestingEnvironment):
2783
2784 2015-02-26  Doug Russell  <d_russell@apple.com>
2785
2786         AX: Expose caret browsing preference to accessibility API
2787         https://bugs.webkit.org/show_bug.cgi?id=141862
2788
2789         Reviewed by Chris Fleizach.
2790
2791         Exposing the caret browsing setting on WebCore::Frame via the accessibility API would allow assistive tech apps to enable it contextually (for example, when the assistive tech app is running).
2792         Enabling caret browsing when assistive tech apps are running greatly improves the reliability of keyboard navigation on the web. Most especially in cases where selection would be disrupted by focus events.
2793
2794         * DumpRenderTree/AccessibilityUIElement.cpp:
2795         (setBoolAttributeValueCallback):
2796         (selectedTextMarkerRangeCallback):
2797         (resetSelectedTextMarkerRangeCallback):
2798         (AccessibilityUIElement::setBoolAttributeValue):
2799         (AccessibilityUIElement::selectedTextMarkerRange):
2800         (AccessibilityUIElement::resetSelectedTextMarkerRange):
2801         (AccessibilityUIElement::getJSClass):
2802         * DumpRenderTree/AccessibilityUIElement.h:
2803         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2804         (AccessibilityUIElement::setBoolAttributeValue):
2805         (AccessibilityUIElement::selectedTextMarkerRange):
2806         (AccessibilityUIElement::resetSelectedTextMarkerRange):
2807         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2808         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
2809         (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
2810         (WTR::AccessibilityUIElement::setBoolAttributeValue):
2811         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2812         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2813         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2814         (WTR::AccessibilityUIElement::setBoolAttributeValue):
2815         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
2816         (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
2817
2818 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
2819
2820         [Win] Remove WebKitExportGenerator project (and related)
2821         https://bugs.webkit.org/show_bug.cgi?id=142035
2822
2823         Reviewed by Dean Jackson.
2824
2825         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't look for a
2826         build log from WebKitExportGenerator.
2827
2828 2015-02-26  Csaba Osztrogonác  <ossy@webkit.org>
2829
2830         [EFL] Bump EFL version to 1.13.0
2831         https://bugs.webkit.org/show_bug.cgi?id=141708
2832
2833         Reviewed by Gyuyoung Kim.
2834
2835         * efl/jhbuild.modules:
2836
2837 2015-02-26  Sam Weinig  <sam@webkit.org>
2838
2839         Check in missing WebEditingTester.xcconfig file.
2840
2841         * WebEditingTester/Configurations/WebEditingTester.xcconfig: Added.
2842
2843 2015-02-26  Csaba Osztrogonác  <ossy@webkit.org>
2844
2845         [webkitpy] Remove skipped file related crufts
2846         https://bugs.webkit.org/show_bug.cgi?id=142046
2847
2848         Reviewed by Ryosuke Niwa.
2849
2850         * Scripts/webkitpy/port/base.py:
2851         (Port.skipped_layout_tests):
2852         (Port._tests_from_skipped_file_contents): Deleted.
2853         (Port): Deleted.
2854         (Port._expectations_from_skipped_files): Deleted.
2855         * Scripts/webkitpy/port/mac_unittest.py:
2856         (MacTest.test_default_timeout_ms):
2857         (MacTest): Deleted.
2858         (test_tests_from_skipped_file_contents): Deleted.
2859
2860 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
2861
2862         [Win] Unreviewed WinCairo build fix after r180653.
2863
2864         TestWebKitAPI should know about proper WEBCORE_EXPORT definitions.
2865
2866         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2867         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
2868         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
2869         * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Added.
2870         * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Added.
2871
2872 2015-02-25  Brent Fulgham  <bfulgham@apple.com>
2873
2874         [Win] Use WEBCORE_EXPORT instead of Definition file
2875         https://bugs.webkit.org/show_bug.cgi?id=141734
2876
2877         Reviewed by Alex Christensen.
2878
2879         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2880         Use a precompiled header so we can define our export macros properly.
2881         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
2882         Visual studio automatic update stuff.
2883         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
2884         Set up Precompiled Header use for project..
2885         * DumpRenderTree/win/DumpRenderTreePrefix.cpp: Added.
2886         * DumpRenderTree/DumpRenderTreePrefix.h: Update with proper export
2887         declarations for building DumpRenderTree as a client of
2888         WebCore/WebKit.
2889
2890 2015-02-25  Mark Lam  <mark.lam@apple.com>
2891
2892         ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack.
2893         <https://webkit.org/b/141672>
2894
2895         Reviewed by Alexey Proskuryakov.
2896
2897         ASan does not like the fact that we memcpy the stack for GC scans.  So,
2898         we're working around this by using our own memcpy (asanUnsafeMemcpy)
2899         implementation that we can tell ASan to ignore.
2900
2901         Also removed the previous added directive to ignore *tryCopyOtherThreadStack*
2902         which isn't effective for working around this issue. 
2903
2904         * asan/webkit-asan-ignore.txt:
2905
2906 2015-02-25  Benjamin Poulain  <bpoulain@apple.com>
2907
2908         CodeBlock crashes when dumping op_push_name_scope
2909         https://bugs.webkit.org/show_bug.cgi?id=141953
2910
2911         Reviewed by Filip Pizlo.
2912
2913         * Scripts/run-jsc-stress-tests:
2914
2915 2015-02-25  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2916
2917         W3C test importer should use argparse instead of optparse
2918         https://bugs.webkit.org/show_bug.cgi?id=142013
2919
2920         Reviewed by Bem Jones-Bey.
2921
2922         * Scripts/webkitpy/w3c/test_importer.py:
2923         (main): Updating according argparse.
2924         (parse_args): Moving from optparse to argparse.
2925
2926 2015-02-25  Brady Eidson  <beidson@apple.com>
2927
2928         Get rid of TestInvocation::pathOrURL
2929         https://bugs.webkit.org/show_bug.cgi?id=142021
2930
2931         Reviewed by Tim Horton.
2932
2933         The pathOrURL string is a relative path used as an argument to WebKitTestRunner,
2934         but most code that uses it expected an absolute path.
2935
2936         This gets rid of the member and replaces all uses with a more descriptive "urlContains" method.
2937
2938         * WebKitTestRunner/TestController.cpp:
2939         (WTR::TestController::updateWebViewSizeForTest):
2940         (WTR::TestController::updateWindowScaleForTest):
2941         (WTR::shouldUseFixedLayout):
2942         (WTR::TestController::updateLayoutTypeForTest):
2943
2944         * WebKitTestRunner/TestInvocation.cpp:
2945         (WTR::TestInvocation::TestInvocation):
2946         (WTR::TestInvocation::urlContains):
2947         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
2948         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
2949         (WTR::TestInvocation::invoke):
2950         (WTR::shouldLogFrameLoadDelegates): Deleted.
2951         (WTR::shouldLogHistoryClientCallbacks): Deleted.
2952         * WebKitTestRunner/TestInvocation.h:
2953         (WTR::TestInvocation::pathOrURL): Deleted.
2954
2955         * WebKitTestRunner/ios/TestControllerIOS.mm:
2956         (WTR::shouldMakeViewportFlexible):
2957         (WTR::TestController::platformConfigureViewForTest):
2958
2959         * WebKitTestRunner/mac/TestControllerMac.mm:
2960         (WTR::shouldUseThreadedScrolling):
2961         (WTR::TestController::platformConfigureViewForTest):
2962
2963 2015-02-25  Brady Eidson  <beidson@apple.com>
2964
2965         Layout test support for user content filters
2966         https://bugs.webkit.org/show_bug.cgi?id=142018
2967
2968         Reviewed by Tim Horton.
2969
2970         * WebKitTestRunner/TestController.cpp:
2971         (WTR::TestController::resetStateToConsistentValues): Clear all user content filters between tests.
2972
2973         * WebKitTestRunner/mac/TestControllerMac.mm:
2974         (WTR::TestController::platformConfigureViewForTest): For all tests with usercontentfilter/ in their path try to load a matching .json
2975           file before loading the test itself.
2976
2977 2015-02-24  Sam Weinig  <sam@webkit.org>
2978
2979         Convert WebEditingTester to use xcconfig files
2980         https://bugs.webkit.org/show_bug.cgi?id=141879
2981
2982         Reviewed by Darin Adler.
2983
2984         Add xcconfig files to WebEditingTester based on the ones used by MiniBrowser.
2985
2986         * WebEditingTester/Configurations: Added.
2987         * WebEditingTester/Configurations/Base.xcconfig: Added.
2988         * WebEditingTester/Configurations/DebugRelease.xcconfig: Added.
2989         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
2990
2991 2015-02-24  Andy Estes  <aestes@apple.com>
2992
2993         Teach MiniBrowser how to disable per-window web processes
2994         https://bugs.webkit.org/show_bug.cgi?id=141988
2995
2996         Reviewed by Darin Adler.
2997
2998         * MiniBrowser/mac/AppDelegate.m:
2999         (defaultConfiguration): Created a _WKProcessPoolConfiguration with maximumProcessCount == 1 if per-window web processes are disabled.
3000         * MiniBrowser/mac/SettingsController.h:
3001         * MiniBrowser/mac/SettingsController.m:
3002         (-[SettingsController _populateMenu]): Added a new Settings menu item.
3003         (-[SettingsController validateMenuItem:]): Validated the new Settings menu item.
3004         (-[SettingsController togglePerWindowWebProcessesDisabled:]): Displayed an alert informing the user that MiniBrowser must be restarted for the setting to take effect.
3005         (-[SettingsController perWindowWebProcessesDisabled]): Returned the value from user defaults.
3006
3007 2015-02-24  Alexey Proskuryakov  <ap@apple.com>
3008
3009         Bot watcher's dashboard sometimes hits an assertion: data.num_missing === this.layoutTestResults.testsWithMissingResults.length
3010         https://bugs.webkit.org/show_bug.cgi?id=141889
3011
3012         Reviewed by Darin Adler.
3013
3014         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3015
3016 2015-02-24  Yusuke Suzuki  <utatane.tea@gmail.com>
3017
3018         REGRESSION(r179429): Can't type comments in Facebook
3019         https://bugs.webkit.org/show_bug.cgi?id=141859
3020
3021         Reviewed by Brent Fulgham.
3022
3023         Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
3024
3025         * DumpRenderTree/mac/DumpRenderTree.mm:
3026         (resetWebPreferencesToConsistentValues):
3027         * DumpRenderTree/win/DumpRenderTree.cpp:
3028         (resetWebPreferencesToConsistentValues):
3029         * WebKitTestRunner/TestController.cpp:
3030         (WTR::TestController::resetPreferencesToConsistentValues):
3031
3032 2015-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3033
3034         Crash loading local file with WebPageProxy::loadAlternateHTMLString
3035         https://bugs.webkit.org/show_bug.cgi?id=141867
3036
3037         Reviewed by Anders Carlsson.
3038
3039         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
3040         (TestWebKitAPI::loadAlternateHTMLString): Split most of this test into a function so it can
3041         be shared with the new test.
3042         (TestWebKitAPI::TEST): Add a cross-platform test for this crash.
3043         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Add a GTK+ test for this crash.
3044         (testLoadAlternateHTMLForLocalPage):
3045         (beforeAll):
3046
3047 2015-02-24  David Kilzer  <ddkilzer@apple.com>
3048
3049         [iOS] Implement WTR::activateFonts() to fix missing fonts in WebKit2 test runs
3050         <http://webkit.org/b/141900>
3051
3052         Reviewed by Myles C. Maxfield.
3053
3054         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
3055         (OTHER_LDFLAGS_BASE): Link to CoreText.framework.
3056         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm: Rename from Tools/WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm.
3057         - Rename to share code with iOS.
3058         - Add USE(APPKIT) around AppKit-specific headers and code.
3059         - Fix a check-webkit-style warning.
3060         * WebKitTestRunner/InjectedBundle/ios/ActivateFontsIOS.mm: Remove.
3061         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3062         - Rename mac/ActivateFonts.mm to cocoa/ActivateFontsCocoa.mm.
3063         - Remove ios/ActivateFontsIOS.mm.
3064         - Fix InjectedBundle/cocoa group to represent the directory on
3065           disk.  Includes a change to InjectedBundlePageCocoa.mm.
3066
3067 2015-02-23  Commit Queue  <commit-queue@webkit.org>
3068
3069         Unreviewed, rolling out r180547 and r180550.
3070         https://bugs.webkit.org/show_bug.cgi?id=141957
3071
3072         Broke 10 Windows tests. (Requested by bfulgham_ on #webkit).
3073
3074         Reverted changesets:
3075
3076         "REGRESSION(r179429): Can't type comments in Facebook"
3077         https://bugs.webkit.org/show_bug.cgi?id=141859
3078         http://trac.webkit.org/changeset/180547
3079
3080         "Constructor returning null should construct an object instead
3081         of null"
3082         https://bugs.webkit.org/show_bug.cgi?id=141640
3083         http://trac.webkit.org/changeset/180550
3084
3085 2015-02-23  Yusuke Suzuki  <utatane.tea@gmail.com>
3086
3087         REGRESSION(r179429): Can't type comments in Facebook
3088         https://bugs.webkit.org/show_bug.cgi?id=141859
3089
3090         Reviewed by Geoffrey Garen.
3091
3092         Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
3093
3094         * DumpRenderTree/mac/DumpRenderTree.mm:
3095         (resetWebPreferencesToConsistentValues):
3096         * WebKitTestRunner/TestController.cpp:
3097         (WTR::TestController::resetPreferencesToConsistentValues):
3098
3099 2015-02-23  KwangHyuk Kim  <hyuki.kim@samsung.com>
3100
3101         [EFL] fix eo errors
3102         https://bugs.webkit.org/show_bug.cgi?id=141909
3103
3104         Reviewed by Gyuyoung Kim.
3105
3106         Fix eo errors that occur whenever minibrowser is launched.
3107         - elm_obj_entry_text_style_user_push can only be applied for elm_entry
3108         - elm_obj_win_resize_object_add's first parameter should be elm_win
3109
3110         * MiniBrowser/efl/main.c:
3111         (window_create):
3112
3113 2015-02-23  Ryosuke Niwa  <rniwa@webkit.org>
3114
3115         Unreviewed build fix after r180535. Removed the test case that wasn't compiling.
3116
3117         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3118         (TestWebKitAPI::TEST):
3119
3120 2015-02-23  Brent Fulgham  <bfulgham@apple.com>
3121
3122         WTF::WeakPtr should rename 'forgot' to 'clear' and support nullptr assignment
3123         https://bugs.webkit.org/show_bug.cgi?id=141935
3124
3125         Reviewed by Myles C. Maxfield.
3126
3127         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3128         (TestWebKitAPI::TEST): Updated for 'clear' method rename, and added a few
3129         tests for assigning from nullptr.
3130
3131 2015-02-23  Brent Fulgham  <bfulgham@apple.com>
3132
3133         WTF::WeakPtr should have a 'forget' method.
3134         https://bugs.webkit.org/show_bug.cgi?id=141923
3135
3136         Reviewed by Myles C. Maxfield.
3137
3138         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3139         (TestWebKitAPI::TEST): Added 'Forget' tests case.
3140
3141 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
3142
3143         build.webkit.org/dashboard CrashOnly queues should not show two green bubbles
3144         https://bugs.webkit.org/show_bug.cgi?id=141920
3145
3146         Reviewed by Tim Horton.
3147
3148         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3149         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3150         Do the same thing as we do for regular green bubbles.
3151
3152 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
3153
3154         Bot watcher's dashboard doesn't show a popover for commit history when all commits were to another branch
3155         https://bugs.webkit.org/show_bug.cgi?id=141925
3156
3157         Reviewed by Tim Horton.
3158
3159         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3160         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
3161
3162 2015-02-23  Anders Carlsson  <andersca@apple.com>
3163
3164         Add API for fetching website data records to _WKWebsiteDataStore
3165         https://bugs.webkit.org/show_bug.cgi?id=141926
3166
3167         Reviewed by Beth Dakin.
3168
3169         * MiniBrowser/mac/MainMenu.xib:
3170         * MiniBrowser/mac/WK2BrowserWindowController.m:
3171         (-[WK2BrowserWindowController fetchWebsiteData:]):
3172         Add menu item to fetch and dump website data.
3173
3174 2015-02-23  David Kilzer  <ddkilzer@apple.com>
3175
3176         [iOS] run-webkit-tests --leaks is broken because IOSSimulatorPort has no is_snowleopard attribute
3177         <http://webkit.org/b/141884>
3178
3179         Reviewed by Alexey Proskuryakov.
3180
3181         * Scripts/webkitpy/port/leakdetector.py:
3182         (LeakDetector._callstacks_to_exclude_from_leaks): Remove
3183         snowleopard, lion and older leaks.  Add known leak for
3184         mavericks, but check Port.operating_system before calling
3185         Port.is_mavericks.
3186         * Scripts/webkitpy/port/mac.py:
3187         (MacPort.is_snowleopard): Delete.
3188         (MacPort.is_lion): Delete.
3189         (MacPort.is_mavericks): Add.
3190
3191 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
3192
3193         build.webkit.org/dashboard should filter out commits to other branches
3194         https://bugs.webkit.org/show_bug.cgi?id=140362
3195
3196         Reviewed by Tim Horton.
3197
3198         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3199         (BuildbotQueue):
3200         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3201         (BuildbotQueueView.prototype._presentPopoverForPendingCommits):
3202         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
3203         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration):
3204         (BuildbotQueueView.prototype.revisionContentForIteration):
3205         (BuildbotQueueView.prototype._appendPendingRevisionCount): Deleted.
3206         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Deleted.
3207         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Deleted.
3208         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3209         (Trac.prototype.get oldestRecordedRevisionNumber):
3210         (Trac.prototype.commitsOnBranch):
3211         (Trac.prototype._xmlTimelineURL):
3212         (Trac.prototype._convertCommitInfoElementToObject):
3213         (Trac.prototype._update):
3214         (Trac.prototype.startPeriodicUpdates):
3215         (Trac.prototype.loadMoreHistoricalData):
3216         (Trac.prototype.update): Deleted.
3217
3218 2015-02-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3219
3220         Tests don't work on some bots: Failed to stop wptwk
3221         https://bugs.webkit.org/show_bug.cgi?id=141235
3222
3223         Reviewed by Ryosuke Niwa.
3224
3225         Logging of server subprocesses in launcher script.
3226         Killing of server subprocesses when stopping/before starting.
3227         Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore.
3228
3229         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
3230         (main): Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore. Added logging in a file of server subprocesses to clean them in case of abnormal shutdown. 
3231         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3232         (WebPlatformTestServer.__init__):
3233         (WebPlatformTestServer._stop_running_subservers): Kill server subprocesses based on file created by wpt launcher.
3234         (WebPlatformTestServer):
3235         (WebPlatformTestServer.stop): Overriden to ensure killing subprocesses in case of orphaned process.
3236         (WebPlatformTestServer._stop_running_server): Killing of wpt launcher process after regular shutdown. 
3237         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
3238         (TestWebPlatformTestServer.test_server_closes_previously_spawned_instance): Reworked the test to call start/stop with an existing pid file.
3239         (TestWebPlatformTestServer.test_import_web_platform_test_modules): No change.
3240         (TestWebPlatformTestServer):
3241         (TestWebPlatformTestServer.test_corrupted_subserver_files): Checked that server subprocess cleaning does not throw in case of bad server pid file.
3242
3243 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3244
3245         [WebEditingTester] Allow dropping HTML files on the app
3246         https://bugs.webkit.org/show_bug.cgi?id=141834
3247
3248         Reviewed by Simon Fraser.
3249
3250         * WebEditingTester/AppDelegate.m:
3251         (-[WebEditingAppDelegate openDocument:]):
3252         (-[WebEditingAppDelegate application:openFile:]):
3253         Implement application:openFile:, factoring file loading code out of openDocument.
3254
3255         * WebEditingTester/Info.plist:
3256         Register as an editor for HTML files.
3257
3258         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3259         Enrica is not an organization.
3260
3261 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3262
3263         [WebEditingTester] Expand "WK" to "WebKit" in a few places
3264         https://bugs.webkit.org/show_bug.cgi?id=141833
3265
3266         Reviewed by Anders Carlsson.
3267
3268         * WebEditingTester/AppDelegate.h:
3269         * WebEditingTester/AppDelegate.m:
3270         (-[WebEditingAppDelegate newEditor:]):
3271         (-[WebEditingAppDelegate toggleUseWebKit2ByDefault:]):
3272         (-[WebEditingAppDelegate validateMenuItem:]):
3273         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
3274         (-[WebEditingAppDelegate applicationDidFinishLaunching:]): Deleted.
3275         (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
3276         (-[WebEditingAppDelegate showOperations:]): Deleted.
3277         * WebEditingTester/MainMenu.xib:
3278         The WK abbreviation is unnaturally grating in menu items for some reason.
3279
3280 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3281
3282         [WebEditingTester] Add a custom protocol for loading canned content
3283         https://bugs.webkit.org/show_bug.cgi?id=141830
3284
3285         Reviewed by Enrica Casucci.
3286
3287         Add a canned:// protocol handler, which can be used to emulate behaviors
3288         in WebKit client apps (like Mail) that use custom protocol handlers,
3289         which can have important effects on editing (mostly, the URLs are only
3290         valid inside of the client application, but not when copied/dragged out).
3291
3292         For now, we only support two canned files:
3293
3294             canned://dice is a PNG of dice (stolen from LayoutTests/)
3295             canned://text is the string "canned text" served as text/html
3296
3297         In the future we could support things like very large (generated) files,
3298         progressive loading, etc. to further simulate conditions in other apps.
3299
3300         * WebEditingTester/AppDelegate.m:
3301         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
3302         Register the protocol with CFNetwork, and the scheme with WebKit2.
3303
3304         * WebEditingTester/Canned Content/dice.png: Added.
3305         * WebEditingTester/CannedContent.h: Added.
3306         * WebEditingTester/CannedContent.m: Added.
3307         (-[CannedContent initWithRequest:cachedResponse:client:]):
3308         (+[CannedContent canonicalRequestForRequest:]):
3309         (+[CannedContent canInitWithRequest:]):
3310         We only want to handle canned:// URLs.
3311
3312         (-[CannedContent startLoading]):
3313         For now, immediately load the two files we know about.
3314         Otherwise, immediately fail the load.
3315
3316         (-[CannedContent stopLoading]):
3317         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3318
3319 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3320
3321         [WebEditingTester] Implement an open panel
3322         https://bugs.webkit.org/show_bug.cgi?id=141829
3323
3324         Reviewed by Simon Fraser.
3325
3326         * WebEditingTester/AppDelegate.m:
3327         (-[WebEditingAppDelegate _useWebKit1ForOpeningDocument:]):
3328         (-[WebEditingAppDelegate _useWebKit2ForOpeningDocument:]):
3329         (-[WebEditingAppDelegate openDocument:]):
3330         Add an open panel (with radio buttons to pick which WebKit to open with).
3331         Loads the file as an HTML string.
3332
3333 2015-02-20  Simon Fraser  <simon.fraser@apple.com>
3334
3335         [WebEditingTester] @properties, dot syntax, and remember the window position
3336         https://bugs.webkit.org/show_bug.cgi?id=141843
3337
3338         Reviewed by Tim Horton.
3339         
3340         Modernize a bit with more dot syntax, use @property for the web views,
3341         and give the main window an Autosave name so it remembers the widow position.
3342
3343         * WebEditingTester/WK1WebDocumentController.m:
3344         (-[WK1WebDocumentController awakeFromNib]):
3345         (-[WK1WebDocumentController loadHTMLString:]):
3346         * WebEditingTester/WK2WebDocumentController.m:
3347         (-[WK2WebDocumentController awakeFromNib]):
3348         * WebEditingTester/WebDocument.xib:
3349
3350 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3351
3352         [WebEditingTester] Hook up key equivalents for new window action
3353         https://bugs.webkit.org/show_bug.cgi?id=141828
3354
3355         Reviewed by Enrica Casucci.
3356
3357         * WebEditingTester/AppDelegate.h:
3358         * WebEditingTester/AppDelegate.m:
3359         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
3360         (-[WebEditingAppDelegate newEditor:]):
3361         (-[WebEditingAppDelegate _defaultWebDocumentControllerClass]):
3362         (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
3363         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
3364         (defaultConfiguration): Deleted.
3365         (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
3366         Move WKWebViewConfiguration setup into WK2WebDocumentController.
3367         Remove unused application termination code.
3368         Update new-window menu item key equivalents when launching and when
3369         changing the use-WebKit2-by-default setting.
3370         Make WebDocumentController subclasses all initialized the same way,
3371         and use that to factor out alloc/init.
3372         Rename loadContent to loadHTMLString for future use.
3373
3374         * WebEditingTester/MainMenu.xib:
3375         Add default key equivalents.
3376         Cmd-N will always make the default kind of window (controlled by the pref).
3377         Cmd-Opt-N will always make the other kind.
3378         The menu items are configured as alternates so they only show up if you
3379         press alt (just like in MiniBrowser).
3380
3381         * WebEditingTester/WK1WebDocumentController.m:
3382         (-[WK1WebDocumentController loadHTMLString:]):
3383         (-[WK1WebDocumentController loadContent]): Deleted.
3384         * WebEditingTester/WK2WebDocumentController.h:
3385         * WebEditingTester/WK2WebDocumentController.m:
3386         (defaultConfiguration):
3387         (-[WK2WebDocumentController awakeFromNib]):
3388         (-[WK2WebDocumentController loadHTMLString:]):
3389         (-[WK2WebDocumentController initWithConfiguration:]): Deleted.
3390         (-[WK2WebDocumentController dealloc]): Deleted.
3391         * WebEditingTester/WebDocumentController.h:
3392         * WebEditingTester/WebDocumentController.m:
3393         (-[WebDocumentController init]):
3394         (-[WebDocumentController initWithWindow:]):
3395         (+[WebDocumentController defaultEditingSource]):
3396         (-[WebDocumentController loadHTMLString:]):
3397         (-[WebDocumentController windowDidLoad]): Deleted.
3398         (-[WebDocumentController defaultEditingSource]): Deleted.
3399         (-[WebDocumentController applicationTerminating]): Deleted.
3400         (-[WebDocumentController loadContent]): Deleted.
3401
3402 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3403
3404         [WebEditingTester] ARC-ify WebEditingTester
3405         https://bugs.webkit.org/show_bug.cgi?id=141827
3406
3407         Reviewed by Sam Weinig.
3408
3409         * WebEditingTester/AppDelegate.m:
3410         (-[WebEditingAppDelegate showOperations:]):
3411         * WebEditingTester/EditingOperations.m:
3412         (editingOperations):
3413         * WebEditingTester/WK1WebDocumentController.m:
3414         (-[WK1WebDocumentController dealloc]): Deleted.
3415         * WebEditingTester/WK2WebDocumentController.m:
3416         (-[WK2WebDocumentController dealloc]): Deleted.
3417         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3418         Turn on ARC and remove a few retain/release/autorelease calls.
3419         We don't need to implement dealloc in either document controller
3420         because WebView and WKWebView's UIDelegate property does not hold a
3421         strong reference.
3422
3423 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3424
3425         [WebEditingTester] Factor out list of editing operations
3426         https://bugs.webkit.org/show_bug.cgi?id=141826
3427
3428         Reviewed by Sam Weinig.
3429
3430         * WebEditingTester/AppDelegate.m:
3431         (-[WebEditingAppDelegate showOperations:]):
3432         * WebEditingTester/EditingOperations.h: Added.
3433         * WebEditingTester/EditingOperations.m: Added.
3434         (editingOperations):
3435         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3436         Move EditingOperations array to its own file, and make it an NSArray
3437         instead of a C array. Adjust accordingly in showOperations:.
3438
3439 2015-02-20  Michael Saboff  <msaboff@apple.com>
3440
3441         DFG JIT needs to check for stack overflow at the start of Program and Eval execution
3442         https://bugs.webkit.org/show_bug.cgi?id=141676
3443
3444         Reviewed by Filip Pizlo.
3445
3446         Set the newly added --maximumEvalCacheableSourceLength option for eager test runs.  This is needed
3447         to allow the eval out of stack tests to tier up.  Without this option, we don't cache the likely
3448         large string expression that we want to eval.
3449
3450         * Scripts/run-jsc-stress-tests:
3451
3452 2015-02-19  Daniel Bates  <dabates@apple.com>
3453
3454         REGRESSION (r180239): run-webkit-test fails to boot simulator device that was booted by previous test run
3455         https://bugs.webkit.org/show_bug.cgi?id=141815
3456         <rdar://problem/19893933>
3457
3458         Reviewed by Simon Fraser.
3459
3460         Fixes an issue where run-webkit-tests would fail to boot the WebKit Tester simulator device if it
3461         was booted by iOS Simulator in a previous run of run-webkit-test.
3462
3463         * Scripts/webkitpy/port/ios.py:
3464         (IOSSimulatorPort.check_sys_deps): Added logic moved from IOSSimulatorPort.setup_test_run().
3465         (IOSSimulatorPort.setup_test_run): Moved logic to quit the iOS Simulator app and wait for the
3466         testing device to be in the shutdown state from here to IOSSimulatorPort.check_sys_deps().
3467
3468 2015-02-19  David Kilzer  <ddkilzer@apple.com>
3469
3470         check-webkit-style: do not warn about missing primary header for *SoftLink.cpp files
3471         <http://webkit.org/b/141799>
3472
3473         Reviewed by Alex Christensen.
3474
3475         * Scripts/webkitpy/style/checkers/cpp.py:
3476         (_IncludeState.check_next_include_order): Don't emit a warning
3477         if the primary header exists and the source file name ends with
3478         "SoftLink.cpp".  Add 'filename' argument to method.
3479         (check_include_line): Pass in 'filename'.
3480
3481         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3482         (OrderOfIncludesTest.test_check_next_include_order__no_config):
3483         (OrderOfIncludesTest.test_check_next_include_order__no_self):
3484         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config):
3485         (OrderOfIncludesTest.test_check_next_include_order__other_then_config):
3486         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely):
3487         - Add test filename arguments for calls to
3488           check_next_include_order().
3489         (OrderOfIncludesTest.test_primary_header): Add test for a file
3490         name ending in "SoftLink.cpp".
3491
3492 2015-02-18  Enrica Casucci  <enrica@apple.com>
3493
3494         Add new tool to test editable Webviews.
3495         https://bugs.webkit.org/show_bug.cgi?id=141772
3496
3497         Reviewed by Tim Horton.
3498
3499         Adding WebEditingTester, a Cocoa application to
3500         test WK1 and Wk2 views in editable mode.
3501
3502         * WebEditingTester: Added.
3503         * WebEditingTester/AppDelegate.h: Added.
3504         * WebEditingTester/AppDelegate.m: Added.
3505         (-[WebEditingAppDelegate init]):
3506         (defaultConfiguration):
3507         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
3508         (-[WebEditingAppDelegate applicationWillTerminate:]):
3509         (-[WebEditingAppDelegate newEditor:]):
3510         (-[WebEditingAppDelegate showOperations:]):
3511         (-[WebEditingAppDelegate useWebKit2ByDefault]):
3512         (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
3513         (-[WebEditingAppDelegate validateMenuItem:]):
3514         * WebEditingTester/Info.plist: Added.
3515         * WebEditingTester/MainMenu.xib: Added.
3516         * WebEditingTester/WK1WebDocumentController.h: Added.
3517         * WebEditingTester/WK1WebDocumentController.m: Added.
3518         (-[WK1WebDocumentController awakeFromNib]):
3519         (-[WK1WebDocumentController loadContent]):
3520         (-[WK1WebDocumentController dealloc]):
3521         (-[WK1WebDocumentController pasteAsMarkup:]):
3522         * WebEditingTester/WK2WebDocumentController.h: Added.
3523         * WebEditingTester/WK2WebDocumentController.m: Added.
3524         (-[WK2WebDocumentController initWithConfiguration:]):
3525         (-[WK2WebDocumentController pasteAsMarkup:]):
3526         (-[WK2WebDocumentController awakeFromNib]):
3527         (-[WK2WebDocumentController dealloc]):
3528         (-[WK2WebDocumentController loadContent]):
3529         * WebEditingTester/WebDocument.xib: Added.
3530         * WebEditingTester/WebDocumentController.h: Added.
3531         * WebEditingTester/WebDocumentController.m: Added.
3532         (-[WebDocumentController initWithWindow:]):
3533         (-[WebDocumentController windowDidLoad]):
3534         (-[WebDocumentController defaultEditingSource]):
3535         (-[WebDocumentController applicationTerminating]):
3536         (-[WebDocumentController loadContent]):
3537         * WebEditingTester/WebEditingTester.xcodeproj: Added.
3538         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj: Added.
3539         * WebEditingTester/main.m: Added.
3540         (main):
3541
3542 2015-02-18  Csaba Osztrogonác  <ossy@webkit.org>
3543
3544         Run JSC tests on ARM EFL bots
3545         https://bugs.webkit.org/show_bug.cgi?id=141165
3546
3547         Reviewed by Alexey Proskuryakov.
3548
3549         * BuildSlaveSupport/build.webkit.org-config/config.json:
3550         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3551         (RunJavaScriptCoreTests.countFailures):
3552         (RunRemoteJavaScriptCoreTests):
3553         (RunRemoteJavaScriptCoreTests.start):
3554         (BuildAndRemoteJSCTestsFactory):
3555         (BuildAndRemoteJSCTestsFactory.__init__):
3556
3557 2015-02-18  Alexey Proskuryakov  <ap@apple.com>
3558
3559         Streamline unexported function build fixes
3560         https://bugs.webkit.org/show_bug.cgi?id=141761
3561
3562         Reviewed by Alex Christensen.
3563
3564         * Scripts/check-for-weak-vtables-and-externals: (readXcode5SymbolsToIgnore): Deleted.
3565         We don't need to ignore symbols that are not exported due to the .unexp file.
3566
3567 2015-02-18  Timothy Horton  <timothy_horton@apple.com>
3568
3569         Remove more references to WebCore.exp.in
3570         https://bugs.webkit.org/show_bug.cgi?id=141747
3571
3572         Reviewed by Alexey Proskuryakov.
3573
3574         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3575         (ShouldBuildTest):
3576
3577 2015-02-17  Myles C. Maxfield  <mmaxfield@apple.com>
3578
3579         Windows test results should not fall back to mac-mountainlion after r180176
3580         https://bugs.webkit.org/show_bug.cgi?id=141719
3581
3582         Reviewed by Brent Fulgham.
3583
3584         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3585         (_should_file_trigger_build):
3586         * Scripts/webkitpy/port/win.py:
3587         (WinPort.default_baseline_search_path):
3588         * Scripts/webkitpy/port/win_unittest.py:
3589         (WinPortTest.test_baseline_search_path):
3590
3591 2015-02-17  Daniel Bates  <dabates@apple.com>
3592
3593         [iOS] run-webkit-tests should check that simctl can boot and shutdown simulator device before running tests
3594         https://bugs.webkit.org/show_bug.cgi?id=141718
3595
3596         Reviewed by Alex Christensen.
3597
3598         We should only run layout tests if simctl can successfully boot and shutdown the testing device.
3599
3600         * Scripts/webkitpy/port/ios.py:
3601         (IOSSimulatorPort.check_sys_deps): Modified to call Simulator.check_simulator_device_and_erase_if_needed().
3602         Log a error and return False if we are unable to boot the simulator device so that the caller can take
3603         appropriate action, say exit(3) before running any layout tests.
3604         * Scripts/webkitpy/xcode/simulator.py:
3605         (Simulator._boot_and_shutdown_simulator_device): Added. Boot and then shut down the simulator device
3606         with the specified UDID.
3607         (Simulator.check_simulator_device_and_erase_if_needed): Added. Checks that simulator device
3608         with the specified UDID can successfully boot and shut down. We make at most two attempts to
3609         boot and shut down the device, erasing the device between tries so as to restore the device
3610         to a known good state.
3611
3612 2015-02-17  Daniel Bates  <dabates@apple.com>
3613
3614         run_webkit_tests.py should not know about iOS Simulator details
3615         https://bugs.webkit.org/show_bug.cgi?id=141711
3616
3617         Reviewed by Alex Christensen.
3618
3619         Run_webkit_tests.py should only parse the iOS-specific command
3620         line options --runtime and --device-type. Let the port-specific
3621         logic in ios.py validate the parsed options and instantiate
3622         internal data structures.
3623
3624         Currently run_webkit_tests.py parses the iOS-specific command
3625         line options --runtime and --device-type, validates them, and
3626         instantiates internal data structures from the parsed strings.
3627         Instead the validation logic and instantiation of internal
3628         data structures should be handled by the iOS port object.
3629
3630         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3631         (_set_up_derived_options): Remove logic to validate --runtime and --device-type
3632         and instantiate internal data structures for them.
3633         * Scripts/webkitpy/port/driver.py:
3634         (IOSSimulatorDriver.cmd_line): Modified to reference IOSSimulatorPort.simulator_runtime
3635         and IOSSimulatorPort.simulator_device_type for the iOS Simulator runtime and device type,
3636         respectively.
3637         * Scripts/webkitpy/port/ios.py: Sort the list of imports.
3638         (IOSSimulatorPort.simulator_runtime): Added. Instantiates a Runtime
3639         object from --runtime, if specified. Otherwise, instantiates a Runtime
3640         object for the latest installed iphonesimulator SDK version.
3641         (IOSSimulatorPort.simulator_device_type): Added. Instantiates a DeviceType
3642         object from --device-type, if specified. Otherwise, instantiates
3643         a DeviceType object for a iPhone 5 or iPhone 5s when on a 32-bit and 64-bit
3644         machine, respectively.
3645         (IOSSimulatorPort.check_sys_deps): Added. Validate if the chosen iOS simulator
3646         runtime is available to use.
3647         (IOSSimulatorPort.testing_device): Modified to make use of properties simulator_device_type
3648         and simulator_runtime for the iOS Simulator device type and runtime, respectively.
3649         * Scripts/webkitpy/xcode/simulator.py:
3650         (Runtime.from_version_string): Added. Turns around and calls Runtime.from_identifier()
3651         with a runtime identifier for the specified iOS version.
3652
3653 2015-02-17  Dana Burkart  <dburkart@apple.com>
3654
3655         ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack
3656         https://bugs.webkit.org/show_bug.cgi?id=141672
3657
3658         Reviewed by David Kilzer.
3659
3660         * asan/webkit-asan-ignore.txt:
3661
3662 2015-02-17  Alex Christensen  <achristensen@webkit.org>
3663
3664         Remove WebCore.exp.in and clean up.
3665         https://bugs.webkit.org/show_bug.cgi?id=141491
3666
3667         Reviewed by Andreas Kling.
3668
3669         * Scripts/sort-export-file: Removed.
3670         * Scripts/webkitpy/style/checker.py:
3671         (_all_categories):
3672         (FileType):
3673         (CheckerDispatcher._file_type):
3674         (CheckerDispatcher._create_checker):
3675         Don't check if the export files are sorted.
3676         * Scripts/webkitpy/style/checkers/exportfile.py: Removed.
3677         * Scripts/webkitpy/style/checkers/exportfile_unittest.py: Removed.
3678
3679 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3680
3681         Unreviewed. Fix GTK+ make distcheck.
3682
3683         Do not exclude bmalloc directory from the tarball.
3684
3685         * gtk/manifest.txt.in:
3686
3687 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3688
3689         Unreviewed. Fix /webkit2/WebKitDOMNode/dom-cache after r180214.
3690
3691         I forgot to add the return of a bool function.
3692
3693         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
3694         (WebKitDOMNodeTest::testDOMCache):
3695
3696 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3697
3698         [GTK] GObject DOM bindings object are cached forever
3699         https://bugs.webkit.org/show_bug.cgi?id=141558
3700
3701         Reviewed by Sergio Villar Senin.
3702
3703         Add checks for all DOM objects to ensure they are not leaked. Also
3704         add a dedicated test for the DOM Object Cache.
3705
3706         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
3707         (WebKitDOMNodeFilterTest::testTreeWalker):
3708         (WebKitDOMNodeFilterTest::testNodeIterator):
3709         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
3710         (WebKitDOMNodeTest::testHierarchyNavigation):
3711         (WebKitDOMNodeTest::testInsertion):
3712         (WebKitDOMNodeTest::testTagNames):
3713         (WebKitDOMNodeTest::testDOMCache):
3714         (registerTests):
3715         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
3716         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
3717         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
3718         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
3719         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
3720         (testWebKitDOMObjectCache):
3721         (beforeAll):
3722         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
3723         (documentLoadedCallback):
3724
3725 2015-02-16  Carlos Garcia Campos  <cgarcia@igalia.com>
3726
3727         [GTK] WebKitFrame objects are never released
3728         https://bugs.webkit.org/show_bug.cgi?id=141641
3729
3730         Reviewed by Martin Robinson.
3731
3732         Add a way to check GObjects leaks for WebProcess tests and check
3733         WebKitFrame objects are not leaked.
3734
3735         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
3736         (WebKitFrameTest::testMainFrame):
3737         (WebKitFrameTest::testURI):
3738         (WebKitFrameTest::testJavaScriptContext):
3739         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
3740         (WebProcessTest::assertObjectIsDeletedWhenTestFinishes):
3741         (runTest):
3742         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
3743
3744 2015-02-16  Tim Horton  <timothy_horton@apple.com>
3745
3746         Fix the MiniBrowser build with newer clang
3747
3748         * MiniBrowser/mac/SettingsController.m:
3749         (-[SettingsController _toggleBooleanDefault:]):
3750         * MiniBrowser/mac/WK1BrowserWindowController.m:
3751         (-[WK1BrowserWindowController windowWillClose:]):
3752         * MiniBrowser/mac/WK2BrowserWindowController.m:
3753         (-[WK2BrowserWindowController windowWillClose:]):
3754         NSApp is id and clang gets confused about which -delegate we're talking about.
3755
3756 2015-02-16  Antti Koivisto  <antti@apple.com>
3757
3758         Develop/Disable Caches does not properly disable disk cache
3759         https://bugs.webkit.org/show_bug.cgi?id=141636
3760
3761         Reviewed by Anders Carlsson.
3762
3763         Make testRunner.setCacheModel() use the WKContext interface so the model gets passed to
3764         the network process too.
3765
3766         This makes setCacheModel asynchronous but there don't seem to be any tests that expect otherwise.
3767
3768         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3769         (WTR::InjectedBundle::beginTesting):
3770         (WTR::InjectedBundle::setCacheModel):
3771         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3772         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3773
3774             Forward to TestController.
3775
3776         (WTR::TestRunner::setCacheModel):
3777         * WebKitTestRunner/TestInvocation.cpp:
3778         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3779
3780 2015-02-16  Andrzej Badowski  <a.badowski@samsung.com>
3781
3782         Unreviewed. Add myself as a committer.
3783
3784         * Scripts/webkitpy/common/config/contributors.json:
3785
3786 2015-02-15  David Kilzer  <ddkilzer@apple.com>
3787
3788         REGRESSION (r180082): WebCore Debug builds fail on Mavericks due to weak export symbols
3789         <http://webkit.org/b/141607>
3790
3791         * Scripts/check-for-weak-vtables-and-externals: Ignore weak
3792         externals in Source/WebCore/Configurations/WebCore.unexp when
3793         building with Xcode 5.x.
3794         (readXcode5SymbolsToIgnore): Add.
3795
3796 2015-02-15  KwangHyuk Kim  <hyuki.kim@samsung.com>
3797
3798         [EFL] fix Evas GL engine error.
3799         https://bugs.webkit.org/show_bug.cgi?id=141621
3800
3801         Reviewed by Gyuyoung Kim.
3802
3803         As new elm engine api was added from efl 1.10, replace elm_config_preferred_engine_set with elm_config_accel_preference_set.
3804
3805         * MiniBrowser/efl/main.c:
3806         (elm_main):
3807
3808 2015-02-14  Csaba Osztrogonác  <ossy@webkit.org>
3809
3810         [buildbot] Enable run-api-tests on release Mac bots
3811         https://bugs.webkit.org/show_bug.cgi?id=141518
3812
3813         Reviewed by Darin Adler.
3814
3815         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3816         (RunUnitTests):
3817         (BuildFactory.__init__):
3818         (TestFactory.__init__):
3819         (BuildAndTestFactory.__init__):
3820         (RunUnitTests.start): Deleted.
3821         (unitTestsSupported): Deleted.
3822
3823 2015-02-13  Anders Carlsson  <andersca@apple.com>
3824
3825         Add a move constructor and move assignment operator to Deque
3826         https://bugs.webkit.org/show_bug.cgi?id=141571
3827
3828         Reviewed by Andreas Kling.
3829
3830         * TestWebKitAPI/Tests/WTF/Deque.cpp:
3831         (TestWebKitAPI::TEST):
3832
3833 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
3834
3835         run-jsc-stress-tests --remote should skip profiler tests
3836         https://bugs.webkit.org/show_bug.cgi?id=141470
3837
3838         Reviewed by Filip Pizlo.
3839
3840         * Scripts/run-jsc-stress-tests:
3841
3842 2015-02-13  Anders Carlsson  <andersca@apple.com>
3843
3844         Add an initializer list constructor to Deque
3845         https://bugs.webkit.org/show_bug.cgi?id=141565
3846
3847         Reviewed by Andreas Kling.
3848
3849         * TestWebKitAPI/Tests/WTF/Deque.cpp:
3850         (TestWebKitAPI::TEST):
3851
3852 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
3853
3854         [buildbot] Remove buildJSCTool cruft from master.cfg
3855         https://bugs.webkit.org/show_bug.cgi?id=141513
3856
3857         Reviewed by Alexey Proskuryakov.
3858
3859         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3860         (RunJavaScriptCoreTests):
3861         (RunJavaScriptCoreTests.start):
3862         (RunWebKitTests):
3863         (RunWebKitTests.start):
3864         (TestFactory.__init__):
3865         (TestLeaksFactory.__init__):
3866         (RunJavaScriptCoreTests.__init__): Deleted.
3867         (RunWebKitTests.__init__): Deleted.
3868
3869 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
3870
3871         Unreviewed, remove empty directories.
3872
3873         * DumpRenderTree/gtk: Removed.
3874         * DumpRenderTree/gtk/fonts: Removed.
3875         * DumpRenderTree/unix: Removed.
3876         * DumpRenderTree/unix/TestNetscapePlugin: Removed.
3877         * GtkLauncher: Removed.
3878         * TestWebKitAPI/Tests/WebKitGtk: Removed.
3879         * TestWebKitAPI/Tests/WebKitGtk/resources: Removed.
3880         * WebKitTestRunner/WebKitTestRunnerAppTests: Removed.
3881         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj: Removed.
3882
3883 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
3884
3885         Remove Windows cruft from Tools/Scripts/build-webkittestrunner
3886         https://bugs.webkit.org/show_bug.cgi?id=141519
3887
3888         Reviewed by Alexey Proskuryakov.
3889
3890         * Scripts/build-webkittestrunner:
3891
3892 2015-02-12  Alex Christensen  <achristensen@webkit.org>
3893
3894         Removed empty directory.
3895
3896         * WinCELauncher: Removed.
3897
3898 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
3899
3900         run-jsc-stress-tests --remote should be able add the necessary libraries to the bundle on Linux
3901         https://bugs.webkit.org/show_bug.cgi?id=141202
3902
3903         Reviewed by Darin Adler.
3904
3905         * Scripts/run-jsc-stress-tests:
3906
3907 2015-02-12  Brent Fulgham  <bfulgham@apple.com>
3908
3909         [Win] Test bot infrastructure should not try to find/use old Safari DLLs
3910         https://bugs.webkit.org/show_bug.cgi?id=141517
3911
3912         Reviewed by Anders Carlsson.
3913
3914         We do not need to locate or use the DLL's that came with Safari, so stop
3915         failing when we cannot find them. Also remove some old Qt cruft from this
3916         script.
3917
3918         * BuildSlaveSupport/built-product-archive:
3919         (archiveBuiltProduct): 
3920         (extractBuiltProduct):
3921
3922 2015-02-11  Brent Fulgham  <bfulgham@apple.com>
3923
3924         [Win] [64-bit] Work around MSVC2013 Runtime Bug
3925         https://bugs.webkit.org/show_bug.cgi?id=141498
3926         <rdar://problem/19803642>
3927
3928         Reviewed by Anders Carlsson.
3929
3930         Disable FMA3 instruction use in the MSVC math library to
3931         work around a VS2013 runtime crash. We can remove this
3932         workaround when we switch to VS2015.
3933
3934         * DumpRenderTree/cg/ImageDiffCG.cpp: Call _set_FMA3_enable(0) to
3935         disable FMA3 support.
3936         * DumpRenderTree/win/DumpRenderTree.cpp: Ditto.
3937         * DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
3938         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
3939         * Scripts/webkitperl/httpd.pm: Ditto.
3940         * TestWebKitAPI/win/main.cpp: Ditto.
3941         * WinLauncher/Common.cpp: Ditto.
3942         * win/DLLLauncher/DLLLauncherMain.cpp: Ditto.
3943
3944 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
3945
3946         run-jsc-stress-tests should accept remote host config from JSON file
3947         https://bugs.webkit.org/show_bug.cgi?id=141509
3948
3949         Reviewed by Michael Saboff.
3950
3951         * Scripts/run-javascriptcore-tests:
3952         (runJSCStressTests):
3953         * Scripts/run-jsc-stress-tests:
3954
3955 2015-02-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3956
3957         [GTK] Add API to allow overriding the default color chooser implementation
3958         https://bugs.webkit.org/show_bug.cgi?id=98935
3959
3960         Reviewed by Gustavo Noronha Silva.
3961
3962         Add a color chooser implementation for MiniBrowser using
3963         GtkPopover when the GTK+ version is recent enough.
3964         And a test case to check the new color chooser API.
3965
3966         * MiniBrowser/gtk/BrowserWindow.c:
3967         (colorChooserRGBAChanged):
3968         (popoverColorClosed):
3969         (colorChooserRequestFinished):
3970         (runColorChooserCallback):
3971         (browserWindowConstructed):
3972         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
3973         (testWebViewColorChooserRequest):
3974         (beforeAll):
3975
3976 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
3977
3978         Make run-jsc-stress-tests --remote work with make-based runner
3979         https://bugs.webkit.org/show_bug.cgi?id=141079
3980
3981         Reviewed by Darin Adler.
3982
3983         * Scripts/run-javascriptcore-tests:
3984         (runJSCStressTests): Pass through the --shell-runner and --make-runner arguments.
3985         * Scripts/run-jsc-stress-tests: Made the make-based runner the default runner,
3986         except for remote testing on Darwin. Unified runShellTestRunner and runMakeTestRunner
3987         to avoid code duplication.
3988
3989 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
3990
3991         run-jsc-stress tests should detect the number of processors on the remote machine too
3992         https://bugs.webkit.org/show_bug.cgi?id=141196
3993
3994         Reviewed by Darin Adler.
3995
3996         * Scripts/run-javascriptcore-tests:
3997         (runJSCStressTests): Pass through the --child-processes argument.
3998         * Scripts/run-jsc-stress-tests: Added determineNumberOfProcessors function
3999         to detect the number of local and remote processors with the same algorithm.
4000         Additionally introduced $numChildProcesses to emphasize it isn't necessarily
4001         same as $numProcessors.
4002
4003 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
4004
4005         run-jsc-stress-tests should pass JSC_timeout to remote hosts
4006         https://bugs.webkit.org/show_bug.cgi?id=141164
4007
4008         Reviewed by Darin Adler.
4009
4010         Additonally removed IMPORTANT_ENVS, since JSC_timeout was the only one.
4011
4012         * Scripts/run-jsc-stress-tests:
4013
4014 2015-02-11  Carlos Garcia Campos  <cgarcia@igalia.com>
4015
4016         [GTK] Add default color chooser implementation using GtkColorChooserDialog
4017         https://bugs.webkit.org/show_bug.cgi?id=141392
4018
4019         Reviewed by Gustavo Noronha Silva.
4020
4021         Enable INPUT_TYPE_COLOR by default for GTK+ port.
4022
4023         * Scripts/webkitperl/FeatureList.pm:
4024
4025 2015-02-09  Csaba Osztrogonác  <ossy@webkit.org>
4026
4027         run-jsc-stress-tests shell test runner should run tests in fixed order
4028         https://bugs.webkit.org/show_bug.cgi?id=141383
4029
4030         Reviewed by Darin Adler.
4031
4032         * Scripts/jsc-stress-test-helpers/shell-runner.sh:
4033
4034 2015-02-08  Chris Fleizach  <cfleizach@apple.com>
4035
4036         AX: VoiceOver appears unresponsive when JavaScript alerts are triggered via focus or blur events
4037         https://bugs.webkit.org/show_bug.cgi?id=140485
4038
4039         Reviewed by Anders Carlsson.
4040
4041         Implement takeFocus() as a way to set focus through accessibility wrappers.
4042
4043         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4044         (AccessibilityUIElement::takeFocus):
4045         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4046         (WTR::AccessibilityUIElement::takeFocus):
4047
4048 2015-02-08  Darin Adler  <darin@apple.com>
4049
4050         Remove the SVG instance tree
4051         https://bugs.webkit.org/show_bug.cgi?id=140602
4052
4053         Reviewed by Dean Jackson.
4054
4055         * Scripts/check-for-global-initializers: Removed special case for
4056         SVGElementInstance.o.
4057
4058 2015-02-07  David Kilzer  <ddkilzer@apple.com>
4059
4060         [iOS] run-webkit-tests fails due to simulator devices from previous SDK installs being marked as unavailable
4061         <http://webkit.org/b/141365>
4062
4063         Reviewed by Daniel Bates.
4064
4065         * Scripts/webkitpy/xcode/simulator.py:
4066         (Simulator): Add unavailable_version_re precompiled regex.
4067         (Simulator._parse_devices): Check for unavailable versions and
4068         ignore them if found when parsing the output of
4069         `xcrun simctl list`.
4070         * Scripts/webkitpy/xcode/simulator_unittest.py:
4071         (test_unavailable_devices): Add test with output from
4072         `xcrun simctl list` with unavailable runtimes that fails before
4073         the fix.
4074
4075 2015-02-07  Chris Dumez  <cdumez@apple.com>
4076
4077         Add Vector::removeFirstMatching() / removeAllMatching() methods taking lambda functions
4078         https://bugs.webkit.org/show_bug.cgi?id=141321
4079
4080         Reviewed by Darin Adler.
4081
4082         Use new Vector::removeFirstMatching() / removeAllMatching() methods.
4083
4084 2015-02-07  David Kilzer  <ddkilzer@apple.com>
4085
4086         [iOS] Make Simulator class testable
4087         <http://webkit.org/b/141358>
4088
4089         Rubber-stamped by Darin Adler.
4090
4091         * Scripts/webkitpy/common/system/platforminfo.py:
4092         (PlatformInfo.xcode_simctl_list): Move `xcrun simctl list`
4093         command to here from Simulator.refresh() in xcode/simulator.py
4094         so that the output of the command can be mocked.
4095
4096         * Scripts/webkitpy/common/system/platforminfo_mock.py:
4097         (MockPlatformInfo.__init__): Set self.expected_xcode_simctl_list
4098         to None.
4099         (MockPlatformInfo.xcode_simctl_list): Add method that returns
4100         self.expected_xcode_simctl_list expectation.
4101
4102         * Scripts/webkitpy/xcode/simulator.py: Add missing copyright
4103         and license header.
4104         (Simulator.__init__): Add optional 'host' parameter to make it
4105         possible to pass in a mock object for testing.  Set self._host
4106         to 'host' parameter or create Host() object.
4107         (Simulator.refresh): Call new PlatformInfo.xcode_simctl_list()
4108         method.
4109
4110         * Scripts/webkitpy/xcode/simulator_unittest.py: Add unit test
4111         for current code.
4112         (SimulatorTest):
4113         (SimulatorTest.setUp):
4114         (SimulatorTest._set_expected_xcrun_simctl_list):
4115         (SimulatorTest.test_simulator_device_types):
4116         (test_invalid_device_types_header):
4117         (test_invalid_runtimes_header):
4118         (test_invalid_devices_header):
4119
4120 2015-02-07  Csaba Osztrogonác  <ossy@webkit.org>
4121
4122         run-jsc-stress-tests --remote should use the default ssh port
4123         https://bugs.webkit.org/show_bug.cgi?id=141287
4124
4125         Reviewed by Darin Adler.
4126
4127         * Scripts/run-jsc-stress-tests: Extended URI module to be able to handle ssh scheme with the default 22 port number.
4128
4129 2015-02-06  Dana Burkart  <dburkart@apple.com>
4130
4131         dashboard: BuildbotTesterQueueView crashesOnly logic is wrong
4132         https://bugs.webkit.org/show_bug.cgi?id=141349
4133
4134         Reviewed by Alexey Proskuryakov.
4135
4136         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
4137         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
4138         (BuildbotTesterQueueView.prototype.update):
4139
4140 2015-02-06  Alexey Proskuryakov  <ap@apple.com>
4141
4142         Report network process crashes during layout tests
4143         https://bugs.webkit.org/show_bug.cgi?id=139646
4144
4145         Reviewed by Anders Carlsson.
4146
4147         * WebKitTestRunner/TestController.cpp:
4148         (WTR::TestController::initialize):
4149         (WTR::TestController::networkProcessName):
4150         (WTR::TestController::networkProcessDidCrash):
4151         * WebKitTestRunner/TestController.h:
4152
4153 2015-02-06  Csaba Osztrogonác  <ossy@webkit.org>
4154
4155         run-jsc-stress-tests --remote should create remote directory before copying the bundle
4156         https://bugs.webkit.org/show_bug.cgi?id=141329
4157
4158         Reviewed by Michael Saboff.
4159
4160         * Scripts/run-jsc-stress-tests:
4161
4162 2015-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
4163
4164         [GTK] Remove WebKitWebView::close-notification signal
4165         https://bugs.webkit.org/show_bug.cgi?id=141330
4166
4167         Reviewed by Gustavo Noronha Silva.
4168
4169         Update notifications unit tests according to the API changes, and
4170         add a test case to check that onclose event is fired when a
4171         notification is closed by the user.
4172
4173         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
4174         (testWebViewNotification):
4175
4176 2015-02-05  Alexey Proskuryakov  <ap@apple.com>
4177
4178         Dashboard doesn't consider building ASan a productive step
4179         https://bugs.webkit.org/show_bug.cgi?id=141312
4180
4181         Reviewed by Simon Fraser.
4182
4183         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
4184
4185 2015-02-05  Daniel Bates  <dabates@apple.com>
4186
4187         [iOS] webkitpy.xcode.simulator.Runtime.from_identifier() returns wrong result for non-existent runtime
4188         https://bugs.webkit.org/show_bug.cgi?id=141306
4189
4190         Reviewed by Alexey Proskuryakov.
4191
4192         The function webkitpy.xcode.simulator.Runtime.from_identifier always returns a Runtime object
4193         corresponding to the last-most runtime parsed from the output of `simctl list` for any non-
4194         existent runtime.
4195
4196         * Scripts/webkitpy/xcode/simulator.py:
4197         (Runtime.from_identifier):
4198
4199 2015-02-05  Daniel Bates  <dabates@apple.com>
4200
4201         LayoutTestRelay does not install DumpRenderTree.app/WebKitTestRunnerApp.app
4202         https://bugs.webkit.org/show_bug.cgi?id=139746
4203         <rdar://problem/19283658>
4204
4205         Reviewed by Alexey Proskuryakov.
4206
4207         Fixes an issues where LayoutTestRelay may fail to install DumpRenderTree.app/WebKitTestRunnerApp.app
4208         if the simulator device is not in state Booted.
4209
4210         Currently run-webkit-test --ios-sim executes LayoutTestRelay immediately after
4211         launching/relaunching the iOS Simulator app and a simulator app can only be installed
4212         on a device that is in the Booted state. LayoutTestRelay may run before the
4213         device is booted and hence fail to install DumpRenderTree.app/WebKitTestRunnerApp.app.
4214         We should defer executing LayoutTestRelay until the simulator device booted by
4215         iOS Simulator is in the Booted state.
4216
4217         * Scripts/webkitpy/port/ios.py: Import webkitpy.xcode.simulator.Simulator to avoid prefixing
4218         Simulator methods with the module name, simulator.
4219         (IOSSimulatorPort.setup_test_run): Wait for the simulator device to be in the Booted state
4220         after launching iOS Simulator. Also, wait until the simulator device is in the Shutdown state
4221         before launching iOS Simulator to boot it.
4222         (IOSSimulatorPort.testing_device): Fix up caller since we now import webkitpy.xcode.simulator.Simulator.
4223         (IOSSimulatorPort.simulator_path): Deleted; moved this function to class Simulator and renamed to device_directory().
4224         * Scripts/webkitpy/xcode/simulator.py:
4225         (Device.__init__): Remove parameter state and an instance variable of the same name, which represented
4226         the state of the device when we created this object as part of parsing the output of `simctl list`. Callers
4227         interested in the state of the device are more likely interested in the current state of the device as
4228         opposed to the state of the device when the Device object was created.
4229         (Device.state): Added; turn around and call Simulator.device_state() for the current state of the device.
4230         (Device.path): Extracted implementation into Simulator.device_directory() so that it can be called
4231         from both this function and Simulator.device_state().
4232         (Device.create): Use Simulator.wait_until_device_is_in_state() to simplify the implementation of this function.
4233         (Simulator.DeviceState): Added; class of constants.
4234         (Simulator.wait_until_device_is_in_state): Added; this function does not return until the specified
4235         device is in the specified state.
4236         (Simulator.device_state): Added; parses the state of the device from the appropriate CoreSimulator device.plist file.
4237         (Simulator.device_directory): Added.
4238         (Simulator._parse_devices): Do not pass argument state to Device constructor as it no longer accepts it.
4239
4240 2015-02-05  Alexey Proskuryakov  <ap@apple.com>
4241
4242         Disable retries on Mac debug testers
4243         https://bugs.webkit.org/show_bug.cgi?id=141296
4244
4245         Reviewed by Simon Fraser.
4246
4247         * BuildSlaveSupport/build.webkit.org-config/config.json:
4248
4249 2015-02-05  Dan Bernstein  <mitz@apple.com>
4250
4251         Need a way to force $xcodeSDK in webkitdirs.pm
4252         https://bugs.webkit.org/show_bug.cgi?id=141291
4253
4254         Reviewed by Anders Carlsson.
4255
4256         * Scripts/webkitdirs.pm:
4257         (setXcodeSDK): Added.
4258
4259 2015-02-05  Youenn Fablet  <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar <calvaris@igalia.com>
4260
4261         [Streams API] Implement a barebone ReadableStream interface
4262         https://bugs.webkit.org/show_bug.cgi?id=141045
4263
4264         Reviewed by Benjamin Poulain.
4265
4266         * Scripts/webkitperl/FeatureList.pm: Added streams-api compilation switch.
4267
4268 2015-02-04  Joseph Pecoraro  <pecoraro@apple.com>
4269
4270         filter-build-webkit: reduce more unfiltered output
4271         https://bugs.webkit.org/show_bug.cgi?id=141282
4272
4273         Reviewed by Daniel Bates.
4274
4275         * Scripts/filter-build-webkit:
4276         Report CompileDTraceScript and Preprocess lines as successful.
4277
4278 2015-02-04  Dana Burkart  <dburkart@apple.com>
4279
4280         Botwatcher's Dashboard is cramped
4281         https://bugs.webkit.org/show_bug.cgi?id=140273
4282
4283         Reviewed by Alexey Proskuryakov.
4284
4285         Add a heading key which will allow for arbitrary headings in builder queues.
4286
4287         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
4288         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
4289         (BuildbotBuilderQueueView.prototype.update):
4290         (BuildbotBuilderQueueView.prototype.update.appendBuildArchitecture): Deleted.
4291         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
4292         (BuildbotIteration.prototype._parseData):
4293         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
4294         (BuildbotLeaksQueueView.prototype.update):
4295         (BuildbotLeaksQueueView.prototype.update.appendBuild): Deleted.
4296         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
4297         (BuildbotPerformanceQueueView.prototype.update):
4298         (BuildbotPerformanceQueueView.prototype.update.appendBuild): Deleted.
4299         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
4300         (BuildbotQueue):
4301         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
4302         (BuildbotQueueView.prototype._unauthorizedAccess):
4303         (BuildbotQueueView.prototype._appendBuild):
4304         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
4305         (BuildbotTestResults):
4306         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
4307         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
4308         (BuildbotTesterQueueView.prototype.update):
4309         (BuildbotTesterQueueView.prototype.update.appendBuild): Deleted.
4310
4311 2015-02-04  Simon Fraser  <simon.fraser@apple.com>
4312
4313         WKTR should not use -mainScreen to pick a color profile
4314         https://bugs.webkit.org/show_bug.cgi?id=141265
4315
4316         Reviewed by Tim Horton.
4317         
4318         -[NSScreen mainScreen] depends on the active window, so use the first screen
4319         (which is the one we put the window on anyway).
4320         
4321         Do some cleanup in DRT that makes the code look similar.
4322
4323         * DumpRenderTree/mac/DumpRenderTree.mm:
4324         (createWebViewAndOffscreenWindow):
4325         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4326         (WTR::PlatformWebView::PlatformWebView):
4327
4328 2015-02-04  Simon Fraser  <simon.fraser@apple.com>
4329
4330         LayoutTestHelper should set the color profile of all displays
4331         https://bugs.webkit.org/show_bug.cgi?id=141260
4332
4333         Reviewed by Tim Horton.
4334         
4335         WebKitTestRunner can (erroneously) grab the colorspace of the "main" screen.
4336         which is the screen with the active window. Make things more robust by changing
4337         the colorspace of all displays, not just the main screen, when running layout tests.
4338
4339         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Enable ARC
4340         * DumpRenderTree/mac/LayoutTestHelper.m: 
4341         (originalColorProfileURLs):
4342         (colorProfileURLForDisplay):
4343         (displayUUIDStrings):
4344   &