1 2012-02-07 Gyuyoung Kim <gyuyoung.kim@samsung.com>
3 [CMAKE] Use *bin* and *lib* directories for executable and libraries.
4 https://bugs.webkit.org/show_bug.cgi?id=77928
6 Reviewed by Daniel Bates.
8 CMake has used *Programs* directory for executable. In addition, shared libraries are being
9 built in source directory. It is better to set common places in order to maintain executable
10 and libraries. *bin* is for executable and *lib* is for library.
12 * DumpRenderTree/efl/CMakeLists.txt:
13 * EWebLauncher/CMakeLists.txt:
14 * Scripts/run-launcher:
15 * Scripts/webkitdirs.pm:
17 * Scripts/webkitpy/layout_tests/port/efl.py:
18 (EflPort._path_to_driver):
19 (EflPort._path_to_image_diff):
21 2012-02-07 Adam Klein <adamk@chromium.org>
23 Add JSC support for delivering mutations when the outermost script context exits
24 https://bugs.webkit.org/show_bug.cgi?id=70289
26 Reviewed by Eric Seidel.
28 * DumpRenderTree/mac/EventSendingController.mm: Add support for
29 eventSender.scheduleAsynchronousKeyDown.
30 (+[EventSendingController isSelectorExcludedFromWebScript:]):
31 (+[EventSendingController webScriptNameForSelector:]):
32 (-[EventSendingController keyDownWrapper:withModifiers:withLocation:]):
33 (-[EventSendingController scheduleAsynchronousKeyDown:withModifiers:withLocation:]):
34 * Scripts/build-webkit: Properly alphabetize --mutation-observers in the --help output.
36 2012-02-07 Chris Rogers <crogers@google.com>
38 Add Chris Rogers to reviewers section
39 https://bugs.webkit.org/show_bug.cgi?id=78016
41 Reviewed by Adam Barth.
43 * Scripts/webkitpy/common/config/committers.py:
45 2012-02-07 Nikolas Zimmermann <nzimmermann@rim.com>
47 layoutTestController.display() is flaky for SVG tests
48 https://bugs.webkit.org/show_bug.cgi?id=78021
50 Reviewed by Dan Bernstein.
52 Fix race condition in repaint rect tracking. When running a test using the repaint.js
53 harness right after a test starting with "svg/W3C-SVG-1.1" the repaint test will fail,
54 the gray overlay isn't contained in the pixel dump anymore. This is because of a specific
55 hack that forces 480x360 instead of 800x600 pixel test dumps for any test starting with
56 svg/W3C-SVG-1.1. The resizing of the web view was done when dumping the render tree, after
57 the repaint test already run, thus invalidating the previously tracked repaint rects.
59 * DumpRenderTree/mac/DumpRenderTree.mm:
63 2012-02-07 Hans Wennborg <hans@chromium.org>
65 Chromium: remove WebSpeechInputResult::set
66 https://bugs.webkit.org/show_bug.cgi?id=77977
68 Reviewed by Darin Fisher.
70 It was renamed to assign() in r106475.
72 * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
75 2012-02-07 Allan Sandfeld Jensen <allan.jensen@nokia.com>
77 [Qt] Give emulated touch-point a radius
78 https://bugs.webkit.org/show_bug.cgi?id=77985
80 Increase the radius of touch-point and show the actual size of the touch point in the touch-point mockup.
82 Reviewed by Kenneth Rohde Christiansen.
84 * MiniBrowser/qt/BrowserWindow.cpp:
85 (BrowserWindow::updateVisualMockTouchPoints):
86 * MiniBrowser/qt/MiniBrowserApplication.cpp:
87 (MiniBrowserApplication::notify):
88 * MiniBrowser/qt/qml/MockTouchPoint.qml:
90 2012-02-07 Mario Sanchez Prada <msanchez@igalia.com>
92 [GTK] Include gdk-pixbuf in the jhbuild modules
93 https://bugs.webkit.org/show_bug.cgi?id=77980
95 Reviewed by Gustavo Noronha Silva.
97 * gtk/jhbuild.modules: Add gdk-pixbuf to the jhbuild moduleset.
99 2012-02-07 Simon Hausmann <simon.hausmann@nokia.com>
101 [Qt] Prevent early test termination with newer Qt 5
102 https://bugs.webkit.org/show_bug.cgi?id=77945
104 Reviewed by Csaba Osztrogonác.
106 QTBUG-24120 tracks a regression in Qt that would make layout tests
107 terminate early. This patch works around it in a Qt 4 + 5 safe manner
108 by disabling the quitOnLastWindowClosed feature, which we don't want/need
111 * DumpRenderTree/qt/main.cpp:
112 (main): Don't quit on last window closed.
114 2012-02-06 Martin Robinson <mrobinson@igalia.com>
116 Fix some miscellaneous 'make dist' error for WebKitGTK+.
118 * MiniBrowser/gtk/GNUmakefile.am: The MiniBrowser generated
119 files should not be distributed.
121 2012-02-02 Hajime Morrita <morrita@chromium.org>
123 [PerformanceTests] Each Dromaeo test needs its landing html.
124 https://bugs.webkit.org/show_bug.cgi?id=77504
126 Reviewed by Ryosuke Niwa.
128 Added an ignorable pattern which happens in some Dromaeo tests.
130 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
133 2012-02-06 Kalev Lember <kalevlember@gmail.com>
135 [GTK] Add missing pango include dir to fix build
136 https://bugs.webkit.org/show_bug.cgi?id=77832
138 Reviewed by Martin Robinson.
140 * GNUmakefile.am: Added $(PANGO_CFLAGS) to libWebCoreInternals_la_CPPFLAGS.
142 2012-02-06 Martin Robinson <mrobinson@igalia.com>
144 [GTK] Fix remaining errors in GTK+ WebKit2 API
145 https://bugs.webkit.org/show_bug.cgi?id=77890
147 Reviewed by Gustavo Noronha Silva.
149 Verify that WebKit2 GTK+ test files are not skipped during style checks.
150 Skip soup_server_new when checking for NULL versus 0 usage.
152 * Scripts/webkitpy/style/checker_unittest.py:
153 (CheckerDispatcherSkipTest.test_should_skip_with_warning):
154 * Scripts/webkitpy/style/checkers/cpp.py:
157 2012-02-06 Eric Seidel <eric@webkit.org>
159 webkit-patch apply-from-bug should be able to apply non-reviewed patches
160 https://bugs.webkit.org/show_bug.cgi?id=77883
162 Reviewed by Adam Barth.
164 This is very helpful if you use bugzilla as a replacement for git-stash.
165 Makes it simpler to re-apply the patch w/o having to look up the patch id.
167 * Scripts/webkitpy/tool/commands/download.py:
168 (ProcessBugsMixin._fetch_list_of_patches_to_process):
169 * Scripts/webkitpy/tool/commands/download_unittest.py:
170 (DownloadCommandsTest.test_apply_from_bug):
172 2012-02-06 Philippe Normand <pnormand@igalia.com>
174 [webkitpy] cpp style-checker complains about readability/naming in GStreamer elements source files
175 https://bugs.webkit.org/show_bug.cgi?id=77866
177 Reviewed by Martin Robinson.
179 * Scripts/webkitpy/style/checker.py: Ignore readability/naming
180 errors in some gstreamer source code files defining new GStreamer elements.
181 * Scripts/webkitpy/style/checker_unittest.py:
182 (GlobalVariablesTest.test_path_rules_specifier):
184 2012-02-06 Carlos Garcia Campos <cgarcia@igalia.com>
186 [GTK] Make sure html_dir exists before calling gtkdoc-rebase
187 https://bugs.webkit.org/show_bug.cgi?id=77869
189 Reviewed by Philippe Normand.
192 (GTKDoc.rebase_installed_docs): Check html_dir exists.
194 2012-02-03 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
196 [Qt] Don't version QtWebKit.experimental.
197 https://bugs.webkit.org/show_bug.cgi?id=77739
199 Reviewed by Tor Arne Vestbø.
201 * MiniBrowser/qt/qml/BrowserWindow.qml:
203 2012-02-06 Carlos Garcia Campos <cgarcia@igalia.com>
205 [GTK] Fix several gtkdoc-fixxref warnings
206 https://bugs.webkit.org/show_bug.cgi?id=77613
208 Reviewed by Martin Robinson.
210 * gtk/generate-gtkdoc:
211 (get_webkit1_options): Add webkitspellcheckerenchant.* to the list
212 of ignored files, since it's private.
214 (GTKDoc._ignored_files_basenames): Helper function that returns a
215 string with the list of ignored files basenames separated by a
216 spaces, as expected by several gtkdoc commands.
217 (GTKDoc._run_gtkdoc_scan): Use _ignored_files_basenames for
218 --ignore-headers option.
219 (GTKDoc._run_gtkdoc_mkdb): Use _ignored_files_basenames for
220 --ignore-files option.
222 2012-02-06 Carlos Garcia Campos <cgarcia@igalia.com>
224 [GTK] Fix xrefs after installing API documentation
225 https://bugs.webkit.org/show_bug.cgi?id=77551
227 Reviewed by Martin Robinson.
229 * GNUmakefile.am: Call generate-gtkdoc --rebase after installing
232 (prefix_of_pkg_config_file): Get the prefix variable of the given
234 (gtk_version_of_pkg_config_file): Get the gtk version required by
235 the given pkg-config file.
236 * gtk/generate-gtkdoc: Add --rebase command line option to rebase
237 installed documentation.
238 (get_gtkdoc_module_paths): Get paths where API doc is installed
239 for the dependencies of the given pkg-config file.
240 (get_common_xref_deps): Get API doc directories of dependencies
241 common to WebKit1 and WebKit2.
242 (get_webkit2_options): Add cross_reference_deps option.
243 (get_webkit1_options): Ditto
244 (rebase_installed_docs): Helper function to create a generator for
245 the given pkg-config file and options and call rebase_installed_docs.
247 (GTKDoc.__init__): Initialize cross_reference_deps.
248 (GTKDoc._run_gtkdoc_fixxref): Add API doc directories of
250 (GTKDoc.rebase_installed_docs): Call gtkdoc-rebase to fix xref
251 links of installed documentation.
252 (PkgConfigGTKDoc.__init__): Get the prefix from the pkg-config
255 2012-02-06 Sergio Villar Senin <svillar@igalia.com>
257 Incorrect statistics shown when running run-webkit-tests with --repeat-each or --iterations
258 https://bugs.webkit.org/show_bug.cgi?id=77672
260 Reviewed by Dirk Pranke.
262 Test repetitions must be taken into account when working out
263 the statistics shown by run-webkit-tests.
265 * Scripts/webkitpy/layout_tests/controllers/manager.py:
266 (Manager.prepare_lists_and_print_output):
267 (Manager._print_result_summary):
268 * Scripts/webkitpy/layout_tests/models/result_summary.py:
269 (ResultSummary.__init__):
271 * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
272 (MainTest.test_repeat_each_iterations_num_tests):
274 2012-02-05 Dan Bernstein <mitz@apple.com>
276 <rdar://problem/10809525> WebKit2’s WebFrameLoaderClient::shouldUseCredentialStorage() always returns true
277 https://bugs.webkit.org/show_bug.cgi?id=77823
279 Reviewed by Anders Carlsson.
281 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
282 (WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.
284 2012-02-04 Dan Bernstein <mitz@apple.com>
286 <rdar://problem/10660698> Clients cannot prevent caching of individual responses
287 https://bugs.webkit.org/show_bug.cgi?id=77822
289 Reviewed by Sam Weinig.
291 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
292 (WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.
294 2012-02-04 Sam Weinig <sam@webkit.org>
296 Add ability to send WKURLRequests in WebKit2 API user messages
297 https://bugs.webkit.org/show_bug.cgi?id=77819
299 Reviewed by Anders Carlsson.
301 Add testing for round-tripping WKTypes from the UIProcess,
302 to the WebProcess, and back.
304 - This commit adds a test fixture and tests for WKURLRequestRef, WKURLRef, and WKStringRef.
305 More can easily be added.
307 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
308 * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Added.
310 (WebKit2UserMessageRoundTripTest):
311 (TestWebKitAPI::WebKit2UserMessageRoundTripTest::WebKit2UserMessageRoundTripTest):
312 (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didReceiveMessageFromInjectedBundle):
313 (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didFinishLoadForFrame):
314 (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setInjectedBundleClient):
315 (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
316 (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp):
317 (TestWebKitAPI::WebKit2UserMessageRoundTripTest::roundTrip):
318 (TestWebKitAPI::TEST_F):
319 * TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp: Added.
322 (TestWebKitAPI::UserMessageTest::UserMessageTest):
323 (TestWebKitAPI::UserMessageTest::didReceiveMessage):
324 * TestWebKitAPI/mac/PlatformWebViewMac.mm:
325 (TestWebKitAPI::PlatformWebView::resizeTo):
327 * TestWebKitAPI/win/TestWebKitAPI.vcproj:
328 * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
330 2012-02-04 Dan Bernstein <mitz@apple.com>
332 <rdar://problem/10772406> WKPreferences instances cannot be copied
333 https://bugs.webkit.org/show_bug.cgi?id=77816
335 Reviewed by Sam Weinig.
337 * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
338 (TestWebKitAPI::TEST):
340 2012-02-04 Adam Barth <abarth@webkit.org>
342 garden-o-matic's All Failure tab should let you examine and rebaseline expected failures
343 https://bugs.webkit.org/show_bug.cgi?id=77802
345 Reviewed by Eric Seidel.
347 This patch refactors our directory grouping code into base.js where it
348 can be shared between failures.js and notifications.js. It then adds
349 an Examine action to each group of failures that triggers the "results"
352 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
353 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
354 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
355 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
356 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
357 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
359 2012-02-04 Ojan Vafai <ojan@chromium.org>
361 check-webkit-style is throwing an exception
362 https://bugs.webkit.org/show_bug.cgi?id=77744
364 Reviewed by David Levin.
366 If the test_list is None, then we don't need to check for unsupported
367 feature tests to skip.
369 * Scripts/webkitpy/layout_tests/port/webkit.py:
370 (WebKitPort._has_test_in_directories):
371 * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
372 (test_skipped_tests_for_unsupported_features_empty_test_list):
374 2012-02-03 Adam Barth <abarth@webkit.org>
376 List of all failures in garden-o-matic should actually list all the failures
377 https://bugs.webkit.org/show_bug.cgi?id=77796
379 Reviewed by Eric Seidel.
381 This patch wires a bit more data into the new "All Failures" tab. I've
382 also iterated on how we enable this experimental feature. The tab is
383 still just a dumb list, but we'll make it smarter.
385 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
386 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
387 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
388 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
390 2012-02-03 Ryosuke Niwa <rniwa@webkit.org>
392 Windows build fix after r106692.
394 * Scripts/webkitpy/layout_tests/port/base_unittest.py:
395 (PortTest.test_reference_files):
397 2012-02-03 Beth Dakin <bdakin@apple.com>
399 https://bugs.webkit.org/show_bug.cgi?id=77782
400 WebPageProxy::didNewFirstVisuallyNonEmptyLayout should is called more than
401 once on some pages with frames
403 <rdar://problem/10798474>
405 Reviewed by Sam Weinig.
408 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
409 * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp: Added.
411 (TestWebKitAPI::didForceRepaint):
412 (TestWebKitAPI::didFinishLoadForFrame):
413 (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
414 (TestWebKitAPI::setPageLoaderClient):
415 (TestWebKitAPI::TEST):
416 * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp: Added.
418 (NewFirstVisuallyNonEmptyLayoutFramesTest):
419 (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::NewFirstVisuallyNonEmptyLayoutFramesTest):
420 (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage):
421 * TestWebKitAPI/Tests/WebKit2/lots-of-iframes.html: Added.
423 2012-02-03 Dirk Pranke <dpranke@chromium.org>
425 webkitpy: change exit() calls to sys.exit(), fix a leak in outputcapture
426 https://bugs.webkit.org/show_bug.cgi?id=77781
428 Reviewed by Eric Seidel.
430 This change fixes a couple of issues discovered while debugging
431 test-webkitpy; both calling exit() instead of sys.exit() --
432 which is discouraged in program code instead of the interpreter
433 -- and a particular usage of outputcapture were stdin to get whacked
434 and preventing debugging.
436 This change introduces a couple of common _exit() methods that
437 will standardize how webkit-patch exit's, in case we need to do
438 something different in the future.
440 * Scripts/webkitpy/common/system/deprecated_logging.py:
442 * Scripts/webkitpy/common/system/outputcapture.py:
443 (OutputCapture.assert_outputs):
444 * Scripts/webkitpy/tool/bot/queueengine.py:
445 (QueueEngine.exit_after_handled_error):
446 * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
447 (AbstractSequencedCommand.execute):
448 * Scripts/webkitpy/tool/commands/queues.py:
449 (StyleQueue.handle_script_error):
450 * Scripts/webkitpy/tool/commands/upload.py:
451 (MarkBugFixed.execute):
452 * Scripts/webkitpy/tool/multicommandtool.py:
454 * Scripts/webkitpy/tool/steps/abstractstep.py:
455 (AbstractStep._exit):
456 * Scripts/webkitpy/tool/steps/checkstyle.py:
458 * Scripts/webkitpy/tool/steps/commit.py:
459 (Commit._check_test_expectations):
460 * Scripts/webkitpy/tool/steps/confirmdiff.py:
463 2012-02-03 Ryosuke Niwa <rniwa@webkit.org>
467 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
468 (PerfTestsRunner._generate_json):
470 2012-02-03 Adam Barth <abarth@webkit.org>
472 Add a blank "Expected Failures" tab to garden-o-matic
473 https://bugs.webkit.org/show_bug.cgi?id=77793
475 Reviewed by Eric Seidel.
477 This tab will help us explore and manage our expected failures. The
478 tab is hidden by default via a new "experimental features" flag.
480 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
481 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
482 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
483 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
484 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
486 (#onebar.partytime #unexpected):
488 2012-02-03 Lucas Forschler <lforschler@apple.com>
490 update-webkit-support-libraries is broken with the change from http to https on developer.apple.com
491 https://bugs.webkit.org/show_bug.cgi?id=77785
495 Pass the -k and --sslv3 keys to make curl work with https on https://developer.apple.com
497 * Scripts/update-webkit-support-libs:
498 (downloadExpectedVersionNumber):
500 2012-02-03 Lucas Forschler <lforschler@apple.com>
502 Add a Mac Lion Performance bot.
503 https://bugs.webkit.org/show_bug.cgi?id=77765
505 Reviewed by Adam Roben.
507 This will update the master configuration in the following ways:
508 Add a new performance slave (apple-xseve-11)
509 Add a new Factory to download a build and run perf tests.
511 * BuildSlaveSupport/build.webkit.org-config/config.json:
512 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
513 (DownloadAndPerfTestFactory):
514 (DownloadAndPerfTestFactory.__init__):
516 2012-02-03 Dirk Pranke <dpranke@chromium.org>
518 Extra TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk in repository
519 https://bugs.webkit.org/show_bug.cgi?id=77752
521 Reviewed by James Robinson.
523 Delete unneeded file accidentally checked in in r106481.
525 * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk: Removed.
527 2012-02-03 Ryosuke Niwa <rniwa@webkit.org>
529 Ref Tests should support plain SVG files
530 https://bugs.webkit.org/show_bug.cgi?id=77685
532 Reviewed by Tony Chang.
534 Don't assume reference files always use .html as the extension.
535 Instead, use the list of supported extension to look for -expected.* and -mismatch.*
537 Also fix various bugs in MockFileSystem and TestPort.
539 * Scripts/webkitpy/common/system/filesystem_mock.py:
540 (MockFileSystem.isdir):
541 * Scripts/webkitpy/layout_tests/port/base.py:
542 (Port.reference_files):
543 * Scripts/webkitpy/layout_tests/port/base_unittest.py:
544 (PortTest.test_is_test_file):
545 (PortTest.test_reference_files):
546 * Scripts/webkitpy/layout_tests/port/test.py:
547 (TestInstance.__init__):
549 2012-02-03 Ryosuke Niwa <rniwa@webkit.org>
551 perf-o-matic should store chromium svn revision
552 https://bugs.webkit.org/show_bug.cgi?id=77725
554 Reviewed by Dirk Pranke.
556 Report both WebKit and Chromium revisions to the graph server. Renamed test_repository_paths to
557 repository_paths since it's nothing to do with tests. Also refactored scm so that head_svn_revision
558 is implemented in terms of newly added svn_revision.
560 * Scripts/webkitpy/common/checkout/scm/git.py:
562 * Scripts/webkitpy/common/checkout/scm/scm.py:
563 (SCM.head_svn_revision):
566 * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
567 (MockSCM.svn_revision):
568 * Scripts/webkitpy/common/checkout/scm/svn.py:
570 * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
571 (JSONLayoutResultsGenerator.__init__):
572 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
573 (JSONResultsGeneratorBase._insert_generic_metadata):
574 * Scripts/webkitpy/layout_tests/port/base.py:
575 (Port.repository_paths):
576 * Scripts/webkitpy/layout_tests/port/chromium.py:
577 (ChromiumPort.repository_paths):
578 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
579 (PerfTestsRunner._generate_json):
580 * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
581 (test_run_test_set_with_json_output):
582 (test_run_test_set_with_json_source):
583 (test_run_test_set_with_multiple_repositories):
585 2012-02-03 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
587 [Qt] Split QQuickWebViewPrivate in two classes, for desktop and touch behavior.
588 https://bugs.webkit.org/show_bug.cgi?id=77632
590 Reviewed by Kenneth Rohde Christiansen.
592 * MiniBrowser/qt/BrowserWindow.cpp:
593 (BrowserWindow::BrowserWindow):
594 * MiniBrowser/qt/MiniBrowserApplication.cpp:
595 (MiniBrowserApplication::sendTouchEvent):
596 (MiniBrowserApplication::handleUserOptions):
597 * MiniBrowser/qt/MiniBrowserApplication.h:
599 (WindowOptions::WindowOptions):
600 * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
601 (WTR::PlatformWebView::PlatformWebView):
602 * WebKitTestRunner/qt/main.cpp:
604 * qmake/mkspecs/features/default_post.prf:
606 2012-02-03 Simon Hausmann <simon.hausmann@nokia.com>
608 [Qt] Replace GNU linker script for exports with export macros in WTF/JSC
609 https://bugs.webkit.org/show_bug.cgi?id=77723
611 Reviewed by Tor Arne Vestbø.
613 * Tools.pro: Compile WTR again on all platforms with WK2.
615 2012-02-03 Sriram Neelakandan <sriram.neelakandan@gmail.com>
617 Ensure that inspector disabled build works
618 https://bugs.webkit.org/show_bug.cgi?id=77604
620 Reviewed by Tor Arne Vestbø.
622 * qmake/mkspecs/features/features.prf:
624 2012-02-02 Jochen Eisinger <jochen@chromium.org>
626 [chromium] add support for --makeargs to the ninja-based build
627 https://bugs.webkit.org/show_bug.cgi?id=77688
629 Reviewed by Adam Barth.
631 * Scripts/webkitdirs.pm:
632 (buildChromiumNinja):
634 2012-02-02 Eric Seidel <eric@webkit.org>
636 Run tests in serial on SnowLeopard to avoid CFURLCache crashes
637 https://bugs.webkit.org/show_bug.cgi?id=75145
639 Reviewed by Dirk Pranke.
641 * Scripts/webkitpy/layout_tests/port/mac.py:
642 (MacPort.default_child_processes):
643 * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
644 (test_operating_system):
645 (test_default_child_processes):
647 2012-02-02 Dirk Pranke <dpranke@chromium.org>
649 nrwt shouldn't blow up when there are errors in test_expectations.txt
650 https://bugs.webkit.org/show_bug.cgi?id=73603
652 Reviewed by Ojan Vafai.
654 This change removes the distinction between 'errors' and 'warnings'
655 in the test expectations parser. Now, any problem is a
656 'warning', and if we are linting the file, warnings become fatal (errors).
658 This will allow a normal run-webkit-tests run to proceed even if
661 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
662 (ParseError.__init__):
663 (ParseError.__str__):
664 (ParseError.__repr__):
665 (TestExpectationSerializer.to_string):
666 (TestExpectationParser._parse_modifiers):
667 (TestExpectationParser._parse_expectations):
668 (TestExpectationParser._check_modifiers_against_expectations):
669 (TestExpectationParser._tokenize):
670 (TestExpectationLine.__init__):
671 (TestExpectationLine.is_invalid):
672 (TestExpectationsModel.add_expectation_line):
673 (TestExpectationsModel._already_seen_better_match):
674 (TestExpectations.__init__):
675 (TestExpectations._report_warnings):
676 (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
677 * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
678 (assert_bad_expectations):
679 (test_parse_warning):
680 (test_overrides__duplicate):
681 (ExpectationSyntaxTests.test_missing_expectation):
682 (ExpectationSyntaxTests.test_missing_colon):
683 (ExpectationSyntaxTests.test_too_many_colons):
684 (ExpectationSyntaxTests.test_too_many_equals_signs):
685 (ExpectationSyntaxTests.test_unrecognized_expectation):
686 (SemanticTests.test_bug_format):
687 (SemanticTests.test_bad_bugid):
688 (SemanticTests.test_slow_and_timeout):
690 (test_more_modifiers):
691 (test_order_in_file):
692 (test_macro_overrides):
693 (RebaseliningTest.assertRemove):
694 (TestExpectationParserTests.test_tokenize_blank):
695 (TestExpectationParserTests.test_tokenize_missing_colon):
696 (TestExpectationParserTests.test_tokenize_extra_colon):
697 (TestExpectationParserTests.test_tokenize_empty_comment):
698 (TestExpectationParserTests.test_tokenize_comment):
699 (TestExpectationParserTests.test_tokenize_missing_equal):
700 (TestExpectationParserTests.test_tokenize_extra_equal):
701 (TestExpectationParserTests.test_tokenize_valid):
702 (TestExpectationParserTests.test_tokenize_valid_with_comment):
703 (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
704 (TestExpectationSerializerTests.test_unparsed_to_string):
705 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
707 * Scripts/webkitpy/style/checkers/test_expectations.py:
708 (TestExpectationsChecker.check_test_expectations):
710 2012-02-02 Sheriff Bot <webkit.review.bot@gmail.com>
712 Unreviewed, rolling out r106543.
713 http://trac.webkit.org/changeset/106543
714 https://bugs.webkit.org/show_bug.cgi?id=77671
716 Made tests less stable (Requested by rniwa on #webkit).
718 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
720 (PerfTestsRunner.__init__):
721 (PerfTestsRunner._run_tests_set):
722 (PerfTestsRunner._run_single_test):
723 * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
724 (MainTest.TestDriver.run_test):
727 2012-02-02 Beth Dakin <bdakin@apple.com>
729 https://bugs.webkit.org/show_bug.cgi?id=77664
730 Add API tests for didNewFirstVisuallyNonEmptyLayout
732 Reviewed by Darin Adler.
735 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
736 * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp: Added.
738 (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
739 (TestWebKitAPI::setPageLoaderClient):
740 (TestWebKitAPI::TEST):
741 * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp: Added.
743 (TestWebKitAPI::didForceRepaint):
744 (TestWebKitAPI::didFinishLoadForFrame):
745 (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
746 (TestWebKitAPI::setPageLoaderClient):
747 (TestWebKitAPI::TEST):
748 * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp: Added.
750 (NewFirstVisuallyNonEmptyLayoutFailsTest):
751 (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::NewFirstVisuallyNonEmptyLayoutFailsTest):
752 (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage):
753 * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp: Added.
755 (NewFirstVisuallyNonEmptyLayoutTest):
756 (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::NewFirstVisuallyNonEmptyLayoutTest):
757 (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::didCreatePage):
759 2012-02-02 Michael Saboff <msaboff@apple.com>
761 Add Michael Saboff to reviewers list.
763 Rubber-stamped by Gavin Barraclough.
765 * Scripts/webkitpy/common/config/committers.py:
767 2012-02-02 Kristóf Kosztyó <kkristof@inf.u-szeged.hu>
769 Add myself as a committer
773 * Scripts/webkitpy/common/config/committers.py:
775 2012-02-02 Ryosuke Niwa <rniwa@webkit.org>
777 [PerformanceTests] tests have dependencies
778 https://bugs.webkit.org/show_bug.cgi?id=77506
780 Reviewed by Hajime Morita.
782 Load an initialization page before each test after starting a DRT so that
783 warming up DRT won't affect the performance test results.
785 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
787 (PerfTestsRunner.__init__):
788 (PerfTestsRunner._run_tests_set):
789 (PerfTestsRunner._run_single_test):
790 * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
791 (MainTest.TestDriver.run_test):
792 (test_initial_page_loaded):
793 (test_initial_page_loaded.run_test):
795 2012-02-02 Ryosuke Niwa <rniwa@webkit.org>
797 Re-land r106442 per Adam's suggestion. We'll do both restarting DRT and loading a fake test first.
799 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
800 (PerfTestsRunner._run_tests_set):
801 (PerfTestsRunner._run_single_test):
802 * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
804 (test_run_passing_test):
805 (test_run_silent_test):
806 (test_run_failed_test):
807 (test_run_tonguey_test):
808 (test_run_timeout_test):
809 (test_run_crash_test):
810 (test_run_test_set_kills_drt_per_run):
811 (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
812 (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__):
813 (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):
815 2012-02-01 Jacob Goldstein <jacobg@adobe.com>
817 Webkit generate-coverage-data script needs update to use new test script
818 https://bugs.webkit.org/show_bug.cgi?id=77597
820 Reviewed by Dirk Schulze.
822 * Scripts/generate-coverage-data:
824 2012-02-01 Adam Barth <abarth@webkit.org>
826 Update the tests to show that the mac-ews processes patches from
829 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
830 (EarlyWarningSytemTest.test_committer_only_ewses):
831 (EarlyWarningSytemTest.test_builder_ewses):
833 2012-02-01 Adam Barth <abarth@webkit.org>
835 Mac-ews logs are huge
836 https://bugs.webkit.org/show_bug.cgi?id=77045
838 Reviewed by Eric Seidel.
840 In order to get the cr-linux-ews bot to run tests on EC2, we created
841 the chromium-xvfb port, which contained a number of tweaks to the
842 Chromium port's behavior. This patch refactors those tweaks so they
843 can be shared with the mac-ews, mostly by moving them into the
844 non-interactive mode of RunTests.
846 * Scripts/webkitpy/common/config/ports.py:
848 (WebKitPort.layout_tests_results_path):
849 (ChromiumPort.run_javascriptcore_tests_command):
851 (ChromiumXVFBPort.run_webkit_tests_command):
852 * Scripts/webkitpy/common/config/ports_mock.py:
854 (MockPort.layout_tests_results_path):
855 * Scripts/webkitpy/common/config/ports_unittest.py:
856 (WebKitPortTest.test_chromium_xvfb_port):
857 * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
858 (LayoutTestResultsReaderTest.test_missing_layout_test_results):
859 * Scripts/webkitpy/tool/commands/queues_unittest.py:
860 (CommitQueueTest.test_commit_queue):
862 (test_manual_reject_during_processing):
863 * Scripts/webkitpy/tool/steps/runtests.py:
865 * Scripts/webkitpy/tool/steps/runtests_unittest.py:
866 (RunTestsTest.test_no_unit_tests):
867 * Scripts/webkitpy/tool/steps/steps_unittest.py:
868 (StepsTest.test_runtests_args):
870 2012-02-01 Ryosuke Niwa <rniwa@webkit.org>
872 Roll out r106442. It made some tests more stable but others less stable.
874 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
875 (PerfTestsRunner._run_tests_set):
876 (PerfTestsRunner._run_single_test):
877 * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
879 (test_run_passing_test):
880 (test_run_silent_test):
881 (test_run_failed_test):
882 (test_run_tonguey_test):
883 (test_run_timeout_test):
884 (test_run_crash_test):
887 2012-02-01 Lucas Forschler <lforschler@apple.com>
889 Enable EWS for non-contributers.
890 https://bugs.webkit.org/show_bug.cgi?id=77576
892 Reviewed by Adam Barth.
894 * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
897 2012-02-01 Beth Dakin <bdakin@apple.com>
899 https://bugs.webkit.org/show_bug.cgi?id=77383
900 Add a different didFirstVisuallNonEmptyLayout heuristic to experiment with
902 <rdar://problem/10709560>
904 Reviewed by Sam Weinig.
906 WebKit2's WebLoaderClient has a temporary new function that must be accounted
908 * MiniBrowser/mac/BrowserWindowController.m:
909 (-[BrowserWindowController awakeFromNib]):
910 * WebKitTestRunner/TestController.cpp:
911 (WTR::TestController::initialize):
913 2012-02-01 Dirk Pranke <dpranke@chromium.org>
915 TestWebKitAPI isn't being built on chromium bots any more
916 https://bugs.webkit.org/show_bug.cgi?id=77563
918 Reviewed by Dimitri Glazkov.
920 I accidentally dropped it in the refactoring in r105449.
922 * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Added.
924 2012-02-01 Hans Wennborg <hans@chromium.org>
926 Rename WebSpeechInputResult::set() to assign()
927 https://bugs.webkit.org/show_bug.cgi?id=77540
929 Reviewed by Darin Fisher.
931 * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
932 (MockWebSpeechInputController::addMockRecognitionResult):
933 (MockWebSpeechInputController::speechTaskFired):
935 2012-02-01 Carlos Garcia Campos <cgarcia@igalia.com>
937 [GTK] WebKit1 API documentation is not generated when building with gtk-2.0
938 https://bugs.webkit.org/show_bug.cgi?id=77542
940 Reviewed by Martin Robinson.
942 * gtk/generate-gtkdoc: Check first whether there's
943 webkitgtk-3.0.pc and if it doesn't exist use webkitgtk-1.0.pc
945 (get_webkit2_options): Return just the options since the
946 pkg_config_path doesn't depend on options
947 (get_webkit1_options): Ditto.
948 (generate_doc): Helper function to create a generator and generate
949 documentation for the given pkg-config file with the given options.
951 (GTKDoc.__init__): Don't use ** for args parameter, since it's
952 used as a dict and never expanded.
953 (PkgConfigGTKDoc.__init__): Ditto.
955 2012-02-01 Carlos Garcia Campos <cgarcia@igalia.com>
957 [GTK] API documentation is not installed even when building with --enable-gtk-doc
958 https://bugs.webkit.org/show_bug.cgi?id=77094
960 Reviewed by Martin Robinson.
962 * GNUmakefile.am: Add install-data-local and uninstall-local rules
963 to install/uninstall WebKit1 and WebKit2 API documentation.
965 2012-02-01 Sheriff Bot <webkit.review.bot@gmail.com>
967 Unreviewed, rolling out r106460.
968 http://trac.webkit.org/changeset/106460
969 https://bugs.webkit.org/show_bug.cgi?id=77552
971 It break unit tests if WEBKIT_TESTFONTS isn't defined.
972 (Requested by Ossy on #webkit).
974 * Scripts/webkitpy/layout_tests/port/qt.py:
976 2012-02-01 Nándor Huszka <huszka.nandor@stud.u-szeged.hu>
978 [Qt] Automatic clean build feature always do clean build with --no-webkit2
979 https://bugs.webkit.org/show_bug.cgi?id=74519
981 Reviewed by Tor Arne Vestbø.
983 Set the PLUGIN_ARCHITECTURE_UNSUPPORTED define always.
985 * qmake/mkspecs/features/features.prf:
987 2012-02-01 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
989 [Qt][WK2] run-webkit-tests --qt crashes if WEBKIT_TESTFONTS is not set
990 https://bugs.webkit.org/show_bug.cgi?id=77466
992 Reviewed by Kenneth Rohde Christiansen.
994 Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS
995 is set or if we should raise an error.
997 * Scripts/webkitpy/layout_tests/port/qt.py:
998 (QtPort.setup_environ_for_server):
1000 2012-02-01 Philippe Normand <pnormand@igalia.com> and Sergio Villar Senin <svillar@igalia.com>
1002 Reviewed by Martin Robinson.
1004 [GTK] Improve FrameLoader signals. Resource loading
1005 https://bugs.webkit.org/show_bug.cgi?id=49543
1007 Support for the new loader signals in DRT.
1009 * DumpRenderTree/gtk/DumpRenderTree.cpp:
1011 (willSendRequestCallback):
1012 (urlSuitableForTestResult):
1013 (descriptionSuitableForTestResult):
1014 (didReceiveResponse):
1016 (didFailLoadingWithError):
1019 2012-02-01 Ryosuke Niwa <rniwa@webkit.org>
1021 run-perf-tests should restart DRT for each test
1022 https://bugs.webkit.org/show_bug.cgi?id=77506
1024 Reviewed by Adam Barth.
1026 Always restart DRT when running performance tests in order to minimize the dependency between tests.
1028 * Scripts/webkitpy/layout_tests/port/chromium.py:
1029 (ChromiumDriver.stop):
1030 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1031 (PerfTestsRunner._run_tests_set):
1032 (PerfTestsRunner._run_single_test):
1033 * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1035 (test_run_passing_test):
1036 (test_run_silent_test):
1037 (test_run_failed_test):
1038 (test_run_tonguey_test):
1039 (test_run_timeout_test):
1040 (test_run_crash_test):
1041 (test_run_test_set_kills_drt_per_run):
1042 (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
1043 (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__):
1044 (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):
1046 2012-01-31 Hans Wennborg <hans@chromium.org>
1048 Speech Input: Report speech element rect relative to window rather than frame
1049 https://bugs.webkit.org/show_bug.cgi?id=76443
1051 Reviewed by Darin Fisher.
1053 Update LayoutTestController to allow for retrieving the speech
1054 element's position used in a request.
1056 In Chromium this is handled by the MockWebSpeechInputController;
1057 adding stubs for the other implementations.
1059 * DumpRenderTree/LayoutTestController.cpp:
1060 (setMockSpeechInputDumpRectCallback):
1061 (LayoutTestController::staticFunctions):
1062 * DumpRenderTree/LayoutTestController.h:
1063 (LayoutTestController):
1064 * DumpRenderTree/chromium/LayoutTestController.cpp:
1065 (LayoutTestController::LayoutTestController):
1066 (LayoutTestController::setMockSpeechInputDumpRect):
1067 * DumpRenderTree/chromium/LayoutTestController.h:
1068 (LayoutTestController):
1069 * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
1070 (MockWebSpeechInputController::setDumpRect):
1071 (MockWebSpeechInputController::clearResults):
1072 (MockWebSpeechInputController::startRecognition):
1073 (MockWebSpeechInputController::MockWebSpeechInputController):
1075 (MockWebSpeechInputController::speechTaskFired):
1076 * DumpRenderTree/chromium/MockWebSpeechInputController.h:
1077 (MockWebSpeechInputController):
1078 * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1079 (LayoutTestController::setMockSpeechInputDumpRect):
1080 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1081 (LayoutTestController::setMockSpeechInputDumpRect):
1082 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1083 (LayoutTestController::setMockSpeechInputDumpRect):
1084 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1085 (LayoutTestController::setMockSpeechInputDumpRect):
1086 * DumpRenderTree/qt/LayoutTestControllerQt.h:
1087 (LayoutTestController):
1088 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1089 (LayoutTestController::setMockSpeechInputDumpRect):
1090 * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1091 (LayoutTestController::setMockSpeechInputDumpRect):
1093 2012-01-31 Ryuan Choi <ryuan.choi@samsung.com>
1095 [EFL] Add basic DRT/Efl implementation to support viewport test.
1096 https://bugs.webkit.org/show_bug.cgi?id=77320
1098 Reviewed by Andreas Kling.
1100 * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1101 (LayoutTestController::dumpConfigurationForViewport): call dumpConfigurationForViewport().
1103 2012-01-31 Alexey Proskuryakov <ap@apple.com>
1105 REGRESSION (WebKit2): event.keyCode is always zero when typing in Russian
1106 https://bugs.webkit.org/show_bug.cgi?id=77473
1107 <rdar://problem/10751357>
1109 Reviewed by Darin Adler.
1111 * DumpRenderTree/mac/EventSendingController.mm:
1112 (-[EventSendingController keyDown:withModifiers:withLocation:]):
1113 * WebKitTestRunner/mac/EventSenderProxy.mm:
1114 (WTR::EventSenderProxy::keyDown):
1115 Added a new special keyDown value to test this.
1117 2012-01-31 Dirk Pranke <dpranke@chromium.org>
1119 nrwt: fix the mock port to work with DriverProxy, reftests
1120 https://bugs.webkit.org/show_bug.cgi?id=77170
1122 Reviewed by Eric Seidel.
1124 The DryrunPort used for benchmarking and testing NRWT has been
1125 broken since we added the DriverProxy code. It isn't really
1126 needed any more, so I've removed it.
1128 The MockDRT port was also broken by DriverProxy, and moreover,
1129 never worked w/ reftests. Since we don't exercise this module in
1130 the unit tests, the code had also bitrotted some. I have cleaned
1131 it up and made it use DriverInput and DriverOutput for
1134 * Scripts/webkitpy/layout_tests/port/dryrun.py:
1135 (DryRunPort.__init__):
1137 (DryRunPort.real_name):
1138 (DryRunPort.create_driver):
1139 (DryRunPort.driver_cmd_line):
1140 (DryRunPort._driver_class):
1142 (DryrunDriver.run_test):
1143 * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1144 (MockDRTPort.create_driver):
1145 (MockChromiumDRT.run_one_test):
1147 2012-01-31 Ojan Vafai <ojan@chromium.org>
1149 run-webkit-tests calls out to webkit-build-directory twice
1150 https://bugs.webkit.org/show_bug.cgi?id=77248
1152 Reviewed by Dirk Pranke.
1154 * Scripts/webkit-build-directory:
1155 If called with no arguments, print out both the top-level directory and the
1156 configuration directory
1158 * Scripts/webkitpy/layout_tests/port/config.py:
1159 (Config.build_directory):
1160 When called with no arguments, get and cache both the top-level and configuration directories.
1162 * Scripts/webkitpy/layout_tests/port/config_standalone.py:
1164 * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1165 (ConfigTest.assert_configuration):
1166 (ConfigTest.test_build_directory.mock_webkit_build_directory):
1167 (ConfigTest.test_build_directory):
1168 (ConfigTest.test_default_configuration__notfound):
1169 * Scripts/webkitpy/layout_tests/port/webkit.py:
1170 (WebKitPort._build_path):
1171 Cache the build directory in the options object so that other users
1172 of the options object don't need to call out to webkit-build-directory.
1173 Also, properly support the existing --build-directory argument.
1175 2012-01-31 Ryosuke Niwa <rniwa@webkit.org>
1177 Bump up the timeout for performance tests since DOM/DOMTable.html
1178 and Parser/html5-full-render.html are timing out on the bot.
1180 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1181 (PerfTestsRunner._parse_args):
1183 2012-01-31 Ehsan Akhgari <ehsan.akhgari@gmail.com>
1185 Fix the update_webgl_conformance_tests.py script in order to enable it
1186 to detect the SCM being used correctly.
1187 https://bugs.webkit.org/show_bug.cgi?id=77462
1189 Reviewed by Kenneth Russell.
1191 * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
1194 2012-01-31 Eric Seidel <eric@webkit.org>
1196 webkit-patch apply-from-bug should work regardless of your CWD
1197 https://bugs.webkit.org/show_bug.cgi?id=77482
1199 Reviewed by Adam Barth.
1201 webkit-patch only ever works with patches made from the root
1202 directory. We should pass the CWD to svn-apply in the case
1203 where we're running not from the webkit root. I believe
1204 this used to work in the past and regressed.
1206 * Scripts/webkitpy/common/checkout/checkout.py:
1207 (Checkout.apply_patch):
1208 * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1209 (CheckoutTest.test_apply_patch):
1211 2012-01-31 Sheriff Bot <webkit.review.bot@gmail.com>
1213 Unreviewed, rolling out r106302.
1214 http://trac.webkit.org/changeset/106302
1215 https://bugs.webkit.org/show_bug.cgi?id=77472
1217 Broke building DRT before running the tests (Requested by ojan
1220 * Scripts/webkit-build-directory:
1221 * Scripts/webkitpy/layout_tests/port/config.py:
1222 (Config.build_directory):
1223 * Scripts/webkitpy/layout_tests/port/config_standalone.py:
1225 * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1226 (ConfigTest.assert_configuration):
1227 (ConfigTest.test_build_directory.mock_webkit_build_directory):
1228 (ConfigTest.test_build_directory):
1229 (ConfigTest.test_default_configuration__notfound):
1230 * Scripts/webkitpy/layout_tests/port/webkit.py:
1231 (WebKitPort._build_path):
1233 2012-01-31 Antoine Labour <piman@chromium.org>
1235 Merge WebGraphicsContext3D creation and initialization, and move it to
1237 https://bugs.webkit.org/show_bug.cgi?id=76593
1239 Reviewed by Darin Fisher.
1241 * DumpRenderTree/chromium/TestWebPlugin.cpp:
1242 (TestWebPlugin::TestWebPlugin):
1243 (TestWebPlugin::initialize):
1244 * DumpRenderTree/chromium/TestWebPlugin.h:
1245 * DumpRenderTree/chromium/WebViewHost.cpp:
1246 (WebViewHost::createGraphicsContext3D):
1247 (WebViewHost::createPlugin):
1248 * DumpRenderTree/chromium/WebViewHost.h:
1250 2012-01-31 Gabor Rapcsanyi <rgabor@webkit.org>
1252 [GTK] build-webkit warning.
1253 https://bugs.webkit.org/show_bug.cgi?id=77411
1255 Reviewed by Philippe Normand.
1257 * Scripts/webkitdirs.pm:
1258 (isCrossCompilation):
1260 2012-01-31 Dan Bernstein <mitz@apple.com>
1262 When generating derived sources, use the same compiler that is used to compile WebKitTestRunner.
1264 Reviewed by Anders Carlsson.
1266 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1268 2012-01-31 Csaba Osztrogonác <ossy@webkit.org>
1270 If the QTDIR environment variable is set, the build system fails to compile WinCairo
1271 https://bugs.webkit.org/show_bug.cgi?id=77112
1273 Reviewed by Daniel Bates.
1275 * Scripts/webkitdirs.pm:
1278 2012-01-31 Adam Roben <aroben@apple.com>
1280 Only call -typingAttributes on WebViews, not WebHTMLViews
1282 Looks like this case was just missed in r105908.
1284 Fixes <http://webkit.org/b/77432> REGRESSION (r105908): WebKit1.InspectorBarTest is crashing
1286 Reviewed by Antti Koivisto.
1288 * TestWebKitAPI/Tests/mac/InspectorBar.mm:
1289 (TestWebKitAPI::TEST): Call -typingAttributes on the WebView, just like we do 2 lines
1292 2012-01-31 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
1294 [Qt] MiniBrowser: Show touch mocking indicators only when Ctrl is held down.
1295 https://bugs.webkit.org/show_bug.cgi?id=77221
1297 Reviewed by Kenneth Rohde Christiansen.
1299 This makes sure that the indicator isn't in the way when doing clicks or dealing with the rest of the UI.
1301 * MiniBrowser/qt/MiniBrowserApplication.cpp:
1302 (MiniBrowserApplication::sendTouchEvent):
1304 2012-01-26 Hans Wennborg <hans@chromium.org>
1306 Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation
1307 https://bugs.webkit.org/show_bug.cgi?id=77083
1309 Reviewed by Darin Fisher.
1311 Add MockWebSpeechInputController which provides a mock implementation
1312 of the WebSpeechInputController interface, and use that in
1315 * DumpRenderTree/DumpRenderTree.gypi:
1316 * DumpRenderTree/chromium/LayoutTestController.cpp:
1317 (LayoutTestController::addMockSpeechInputResult):
1318 * DumpRenderTree/chromium/LayoutTestController.h:
1320 * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Added.
1321 (MockWebSpeechInputController::create):
1322 (MockWebSpeechInputController::addMockRecognitionResult):
1323 (MockWebSpeechInputController::clearResults):
1324 (MockWebSpeechInputController::startRecognition):
1325 (MockWebSpeechInputController::cancelRecognition):
1326 (MockWebSpeechInputController::stopRecording):
1327 (MockWebSpeechInputController::MockWebSpeechInputController):
1328 (MockWebSpeechInputController::speechTaskFired):
1329 (MockWebSpeechInputController::SpeechTask::SpeechTask):
1330 (MockWebSpeechInputController::SpeechTask::stop):
1331 (MockWebSpeechInputController::SpeechTask::runIfValid):
1332 * DumpRenderTree/chromium/MockWebSpeechInputController.h: Added.
1334 (MockWebSpeechInputController):
1335 (MockWebSpeechInputController::taskList):
1337 * DumpRenderTree/chromium/TestShell.cpp:
1338 * DumpRenderTree/chromium/WebViewHost.cpp:
1339 (WebViewHost::speechInputController):
1340 * DumpRenderTree/chromium/WebViewHost.h:
1342 (WebViewHost::speechInputControllerMock):
1346 2012-01-31 Hajime Morrita <morrita@chromium.org>
1348 [PerformanceTests] Add landing html for Dromaeo dom-query test
1349 https://bugs.webkit.org/show_bug.cgi?id=77329
1351 Reviewed by Ryosuke Niwa.
1353 Added some more ignorable output patterns to allow warnings
1354 from a third party test suite.
1356 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1358 (PerfTestsRunner._should_ignore_line_in_parser_test_result):
1360 2012-01-30 Kevin Ollivier <kevino@theolliviers.com>
1362 [wx] Unreviewed. Update download URLs to new domain.
1364 * waf/build/build_utils.py:
1367 2012-01-30 Kevin Ollivier <kevino@theolliviers.com>
1369 [wx] Unreviewed. Build fix, add JavaScriptCore/tools
1370 to the list of build directories.
1372 * waf/build/settings.py:
1374 2012-01-30 Kentaro Hara <haraken@chromium.org>
1376 REGRESSION(r105797): prepare-ChangeLog for a .cpp file can
1377 output an empty method name (i.e. "()")
1378 https://bugs.webkit.org/show_bug.cgi?id=77336
1380 Reviewed by Darin Adler.
1382 r105797 tried to detect a change outside methods, but it causes a bug that
1383 prepare-ChangeLog can output an empty method name, like this:
1390 This is because the cpp parser in prepare-ChangeLog cannot distinguish
1391 '{' as the beginning of a method with '{' as the beginning of an array definition
1394 int a[] = { 1, 2, 3 }; // This '{' is the beginning of an array definition.
1396 void func() { // This '{' is the beginning of a method.
1400 This patch fixes prepare-ChangeLog so that it skips an array definition at the top level.
1402 * Scripts/prepare-ChangeLog:
1403 (get_function_line_ranges_for_cpp): Modified as described above.
1404 (generateFunctionLists): As a hack, modified so that prepare-ChangeLog does not output
1405 an empty method name. Ideally this should not happen but may happen, since the
1406 parsers are not perfect.
1407 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases.
1411 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
1413 2012-01-30 Ojan Vafai <ojan@chromium.org>
1415 run-webkit-tests calls out to webkit-build-directory twice
1416 https://bugs.webkit.org/show_bug.cgi?id=77248
1418 Reviewed by Dirk Pranke.
1420 This reduces to calls to webkit-build-directory to one call and
1421 saves 500ms for run-webkit-tests over a single file.
1423 * Scripts/webkit-build-directory:
1424 If called with no arguments, print out both the top-level directory and the
1425 configuration directory.
1427 * Scripts/webkit-build-directory:
1428 * Scripts/webkitpy/layout_tests/port/config.py:
1429 (Config.build_directory):
1430 When called with no arguments, get and cache both the top-level and configuration directories.
1432 * Scripts/webkitpy/layout_tests/port/config_standalone.py:
1434 * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1435 (ConfigTest.assert_configuration):
1436 (ConfigTest.test_build_directory.mock_webkit_build_directory):
1437 (ConfigTest.test_build_directory):
1438 (ConfigTest.test_default_configuration__notfound):
1439 * Scripts/webkitpy/layout_tests/port/webkit.py:
1440 (WebKitPort._build_path):
1441 Cache the root directory in the options object so that other users
1442 of the options object don't need to call out to webkit-build-directory.
1444 2012-01-30 Ojan Vafai <ojan@chromium.org>
1446 Parsing test_expecations.txt + Skipped lists takes too long
1447 https://bugs.webkit.org/show_bug.cgi?id=77059
1449 Reviewed by Dirk Pranke.
1451 This saves ~100ms on the Apple Mac port.
1452 -memoize a bunch of path methods.
1453 -Avoid doing multiple disk accesses per line.
1454 -Parse the skipped list directly instead of turning it into a test_expecations.txt
1455 formatting string and parsing that.
1457 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1458 (TestExpectationParser):
1459 (TestExpectationParser.expectation_for_skipped_test):
1460 (TestExpectationParser._parse_line):
1461 (TestExpectationParser._collect_matching_tests):
1462 (TestExpectations.__init__):
1463 (TestExpectations._add_skipped_tests):
1464 * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1465 (test_add_skipped_tests):
1466 (test_add_skipped_tests_duplicate):
1467 * Scripts/webkitpy/layout_tests/port/base.py:
1470 (Port.normalize_test_name):
1471 (Port.layout_tests_dir):
1472 (Port.abspath_for_test):
1473 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1475 2012-01-30 Alexis Menard <alexis.menard@openbossa.org>
1477 Unreviewed. Add myself to CSS, GStreamer, Qt related watchlists.
1479 * Scripts/webkitpy/common/config/watchlist:
1481 2012-01-30 Gavin Barraclough <barraclough@apple.com>
1483 Unreviewed build fix following bug#76855
1485 * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1487 (TestWebKitAPI::TEST_F):
1489 2012-01-26 No'am Rosenthal <noam.rosenthal@nokia.com> and Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
1491 [Qt] WKTR: Use a software rendering pipiline when running tests.
1492 https://bugs.webkit.org/show_bug.cgi?id=76708
1494 Reviewed by Kenneth Rohde Christiansen.
1496 * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1497 (WTR::WrapperWindow::WrapperWindow):
1498 (WTR::PlatformWebView::PlatformWebView): Use software rendering of layers since the wrapping QQuickView isn't shown.
1500 2012-01-30 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
1502 [Qt] Store build config immediately instead of waiting for a successfull build
1504 Otherwise we will not pick up changes to the config if the build is aborted,
1505 for example due to build errors or if the user pressed Ctrl+Z. We now write
1506 the new config before starting a build, but still defer to write the SVN
1507 revision once the build completes successfully.
1511 * Scripts/webkitdirs.pm:
1512 (buildQMakeProjects):
1514 2012-01-30 Alexander Færøy <ahf@0x90.dk>
1516 [Qt] Add "New Window" button to the Qt MiniBrowser
1517 https://bugs.webkit.org/show_bug.cgi?id=77281
1519 Reviewed by Tor Arne Vestbø.
1521 * MiniBrowser/qt/BrowserWindow.cpp:
1522 (BrowserWindow::BrowserWindow):
1523 * MiniBrowser/qt/MiniBrowser.qrc:
1524 * MiniBrowser/qt/icons/plus.png: Added.
1525 * MiniBrowser/qt/qml/BrowserWindow.qml:
1527 2012-01-30 Csaba Osztrogonác <ossy@webkit.org>
1529 Unreviewed rolling out r106222.
1531 * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1532 (SingleTestRunner.__init__):
1533 * Scripts/webkitpy/layout_tests/controllers/worker.py:
1534 (Worker.handle_test_list):
1535 * Scripts/webkitpy/layout_tests/models/test_input.py:
1536 (TestInput.__init__):
1537 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1538 (_set_up_derived_options):
1540 * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1541 (MainTest.test_repeat_each):
1542 * WebKitTestRunner/TestInvocation.cpp:
1543 (WTR::TestInvocation::setIsPixelTest):
1545 2012-01-30 Hans Wennborg <hans@chromium.org>
1547 Unreviewed, rolling out r106219.
1548 http://trac.webkit.org/changeset/106219
1549 https://bugs.webkit.org/show_bug.cgi?id=77083
1551 This broke Chromium's test_shell.
1553 * DumpRenderTree/DumpRenderTree.gypi:
1554 * DumpRenderTree/chromium/LayoutTestController.cpp:
1555 (LayoutTestController::addMockSpeechInputResult):
1556 * DumpRenderTree/chromium/LayoutTestController.h:
1558 (LayoutTestController):
1560 * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Removed.
1561 * DumpRenderTree/chromium/MockWebSpeechInputController.h: Removed.
1562 * DumpRenderTree/chromium/TestShell.cpp:
1563 * DumpRenderTree/chromium/WebViewHost.cpp:
1564 (WebViewHost::speechInputController):
1565 * DumpRenderTree/chromium/WebViewHost.h:
1567 (WebViewHost::speechInputControllerMock):
1571 2012-01-26 Hans Wennborg <hans@chromium.org>
1573 Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation
1574 https://bugs.webkit.org/show_bug.cgi?id=77083
1576 Reviewed by Darin Fisher.
1578 Add MockWebSpeechInputController which provides a mock implementation
1579 of the WebSpeechInputController interface, and use that in
1582 * DumpRenderTree/DumpRenderTree.gypi:
1583 * DumpRenderTree/chromium/LayoutTestController.cpp:
1584 (LayoutTestController::addMockSpeechInputResult):
1585 * DumpRenderTree/chromium/LayoutTestController.h:
1587 * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Added.
1588 (MockWebSpeechInputController::create):
1589 (MockWebSpeechInputController::addMockRecognitionResult):
1590 (MockWebSpeechInputController::clearResults):
1591 (MockWebSpeechInputController::startRecognition):
1592 (MockWebSpeechInputController::cancelRecognition):
1593 (MockWebSpeechInputController::stopRecording):
1594 (MockWebSpeechInputController::MockWebSpeechInputController):
1595 (MockWebSpeechInputController::speechTaskFired):
1596 (MockWebSpeechInputController::SpeechTask::SpeechTask):
1597 (MockWebSpeechInputController::SpeechTask::stop):
1598 (MockWebSpeechInputController::SpeechTask::runIfValid):
1599 * DumpRenderTree/chromium/MockWebSpeechInputController.h: Added.
1601 (MockWebSpeechInputController):
1602 (MockWebSpeechInputController::taskList):
1604 * DumpRenderTree/chromium/TestShell.cpp:
1605 * DumpRenderTree/chromium/WebViewHost.cpp:
1606 (WebViewHost::speechInputController):
1607 * DumpRenderTree/chromium/WebViewHost.h:
1609 (WebViewHost::speechInputControllerMock):
1613 2012-01-29 Sheriff Bot <webkit.review.bot@gmail.com>
1615 Unreviewed, rolling out r106109.
1616 http://trac.webkit.org/changeset/106109
1617 https://bugs.webkit.org/show_bug.cgi?id=77302
1619 It made tests crash (Requested by Ossy_weekend on #webkit).
1621 * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1622 (WTR::WrapperWindow::WrapperWindow):
1623 (WTR::PlatformWebView::PlatformWebView):
1625 2012-01-28 Nico Weber <thakis@chromium.org>
1627 [chromium] Add support for building standalone webkit/chromium checkouts with ninja.
1628 https://bugs.webkit.org/show_bug.cgi?id=77243
1630 Reviewed by Adam Barth.
1632 * Scripts/update-webkit:
1633 * Scripts/webkitdirs.pm:
1635 (determineIsChromiumNinja):
1636 (buildChromiumNinja):
1639 2012-01-27 Kentaro Hara <haraken@chromium.org>
1641 The cpp parser of prepare-ChangeLog treats if(...) {} as a method
1642 https://bugs.webkit.org/show_bug.cgi?id=77241
1644 Reviewed by Ryosuke Niwa.
1646 The cpp parser of prepare-ChangeLog is wrong, and an inner {} block
1647 in a method in some namespace or class is treated as a method.
1648 This patch fixes the bug.
1653 if (1) { // This should not be treated as a method.
1658 * Scripts/prepare-ChangeLog:
1659 (get_function_line_ranges_for_cpp):
1660 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
1661 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
1665 2012-01-27 Enrica Casucci <enrica@apple.com>
1667 Followup to http://trac.webkit.org/changeset/106171.
1668 Dan Bernstein pointed out correctly that I should
1669 have used copy instead of initWithString.
1671 Reviewed by Dan Bernstein.
1673 * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1674 (-[LocalPasteboard initWithName:]):
1676 2012-01-27 Enrica Casucci <enrica@apple.com>
1678 DRT pasteboard object should return the correct pasteboard name.
1679 https://bugs.webkit.org/show_bug.cgi?id=77260
1681 Currently the name property always returns nil.
1682 Adding a memeber variable to store the pasteboard name and return its
1683 value from the name method instead of returning nil always.
1685 Reviewed by Dan Bernstein.
1687 * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1688 (+[DumpRenderTreePasteboard _pasteboardWithName:]):
1689 (-[LocalPasteboard initWithName:]):
1690 (-[LocalPasteboard name]):
1692 2012-01-27 Martin Robinson <mrobinson@igalia.com>
1694 [GTK] [WK2] Implement the policy client
1695 https://bugs.webkit.org/show_bug.cgi?id=76343
1697 Reviewed by Gustavo Noronha Silva.
1699 * gtk/generate-gtkdoc:
1700 (get_webkit2_options): Update the list of skipped source files to include all clients.
1702 2012-01-27 Ada Chan <adachan@apple.com>
1704 Add test for WKBundleFrameGetParentFrame().
1705 https://bugs.webkit.org/show_bug.cgi?id=77161
1707 Reviewed by Anders Carlsson.
1709 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add ParentFrame.cpp and ParentFrame_Bundle.cpp.
1710 * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp: Added.
1712 (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Get the check result from the injected bundle.
1713 (TestWebKitAPI::setInjectedBundleClient):
1714 (TestWebKitAPI::TEST): Load simple-iframe.html and then wait for the injected bundle to post result.
1715 Make sure the check is successful.
1716 * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp: Added.
1719 (TestWebKitAPI::ParentFrameTest::ParentFrameTest):
1720 (TestWebKitAPI::didFinishLoadForFrame): If the frame is a subframe, store it off for checking later.
1721 If the frame is the main frame, check whether it's indeed the subframe's parent frame and post the result
1722 to the test controller.
1723 (TestWebKitAPI::ParentFrameTest::didCreatePage): Set the page loader client on this page.
1725 2012-01-27 Zan Dobersek <zandobersek@gmail.com>
1727 [Gtk] DumpRenderTree lacks --no-timeout command line option
1728 https://bugs.webkit.org/show_bug.cgi?id=77196
1730 Reviewed by Martin Robinson.
1732 Add the --no-timeout command line option and reorganize
1733 watchdog code to make running DumpRenderTree without
1736 * DumpRenderTree/gtk/DumpRenderTree.cpp:
1737 (setWaitToDumpWatchdog):
1738 (shouldSetWaitToDumpWatchdog):
1739 (initializeGlobalsFromCommandLineOptions):
1740 * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1741 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1742 (waitToDumpWatchdogFired):
1743 (LayoutTestController::setWaitToDump):
1745 2012-01-27 Andras Becsi <andras.becsi@nokia.com>
1747 [Qt][WK2] Enable the automatic touch->mouse mocking on the new Qt5 hashes
1748 https://bugs.webkit.org/show_bug.cgi?id=77122
1750 Reviewed by Kenneth Rohde Christiansen.
1752 * MiniBrowser/qt/MiniBrowserApplication.cpp:
1753 (MiniBrowserApplication::MiniBrowserApplication):
1755 2012-01-27 Zeno Albisser <zeno@webkit.org>
1757 [Qt][Mac] Build fails after adding ICU support (r105997).
1758 https://bugs.webkit.org/show_bug.cgi?id=77118
1760 Define WTF_USE_ICU_UNICODE if we are on mac.
1762 Reviewed by Tor Arne Vestbø.
1764 * qmake/mkspecs/features/features.prf:
1766 2012-01-27 Roland Takacs <takacs.roland@stud.u-szeged.hu>
1768 Update committers.py with new contributors.
1769 https://bugs.webkit.org/show_bug.cgi?id=77207
1771 I added six new contributors into committers.py:
1778 - Szilard Ledan-Muntean
1780 * Scripts/webkitpy/common/config/committers.py:
1782 2012-01-27 Vsevolod Vlasov <vsevik@chromium.org>
1784 Add Vsevolod Vlasov to reviewers list.
1786 Reviewed by Pavel Feldman.
1788 * Scripts/webkitpy/common/config/committers.py:
1790 2012-01-26 No'am Rosenthal <noam.rosenthal@nokia.com> and Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
1792 [Qt] WKTR: Use a software rendering pipiline when running tests.
1793 https://bugs.webkit.org/show_bug.cgi?id=76708
1795 Reviewed by Kenneth Rohde Christiansen.
1797 * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1798 (WTR::WrapperWindow::WrapperWindow):
1799 (WTR::PlatformWebView::PlatformWebView): Use software rendering of layers since the wrapping QQuickView isn't shown.
1801 2012-01-26 Kevin Ollivier <kevino@theolliviers.com>
1803 [wx] Unreviewed. Build fix, add WebCore/testing/js
1804 to the list of source directories we build.
1806 * waf/build/settings.py:
1808 2012-01-26 Filip Pizlo <fpizlo@apple.com>
1810 Tools/Scripts/commit-log-editor is broken due to $_ getting clobbered
1811 https://bugs.webkit.org/show_bug.cgi?id=77177
1813 Reviewed by Jon Honeycutt.
1815 * Scripts/commit-log-editor:
1817 2012-01-26 Ojan Vafai <ojan@chromium.org>
1819 Decrease sleep time when killing server_process on Mac.
1820 https://bugs.webkit.org/show_bug.cgi?id=77169
1822 Reviewed by Eric Seidel.
1824 This shaves another ~70ms off single test runtime.
1826 * Scripts/webkitpy/layout_tests/port/server_process.py:
1827 (ServerProcess.stop):
1829 2012-01-26 Ojan Vafai <ojan@chromium.org>
1831 Remove builder name so http://trac.webkit.org/changeset/106035 actually works.
1832 https://bugs.webkit.org/show_bug.cgi?id=77164
1834 Reviewed by Dirk Pranke.
1836 http://trac.webkit.org/changeset/106035 depends on builder_name being
1837 falsey by default. There's other code that requires it to be iterable
1838 by default. So, make it be the empty string.
1840 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1843 2012-01-26 Ryosuke Niwa <rniwa@webkit.org>
1845 run-perf-test should include relative file paths in test names
1846 https://bugs.webkit.org/show_bug.cgi?id=77144
1848 Reviewed by Adam Birth.
1850 Include all directory names in the test name separated by "/".
1851 e.g. Bindings/event-target-wrapper.html translates to Bindings/event-target-wrapper
1853 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1855 (PerfTestsRunner._process_parser_test_result):
1856 * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1857 (test_run_test_set_with_json_output):
1858 (test_run_test_set_with_json_source):
1860 2012-01-26 Dirk Pranke <dpranke@chromium.org>
1862 webkitpy: re-land cleanup of test scaffolding
1863 https://bugs.webkit.org/show_bug.cgi?id=77153
1865 Reviewed by Eric Seidel.
1867 This is an attempt to reland the change in bug 76973 /
1868 r105935. My earlier attempt to manipulate PYTHONPATH
1869 seems to only work some of the time, for reasons that
1870 elude me. Directly adding Tools/Scripts to sys.path from
1871 inside the test script appears to work (more?) reliably.
1873 Also, it seemed like the files didn't actually get deleted
1874 the last time; I don't know why.
1876 * Scripts/test-webkitpy:
1877 * Scripts/webkitpy/common/system/executive_unittest.py:
1880 (ExecutiveTest.test_run_command_args_type):
1881 (ExecutiveTest.test_run_command_with_unicode):
1882 (ExecutiveTest.test_running_pids):
1884 * Scripts/webkitpy/common/system/fileutils.py: Removed.
1885 * Scripts/webkitpy/test/cat.py: Removed.
1886 * Scripts/webkitpy/test/cat_unittest.py: Removed.
1887 * Scripts/webkitpy/test/echo.py: Removed.
1888 * Scripts/webkitpy/test/echo_unittest.py: Removed.
1890 2012-01-26 Ojan Vafai <ojan@chromium.org>
1892 run-webkit-tests calls "nm" when it doesn't need to
1893 https://bugs.webkit.org/show_bug.cgi?id=77143
1895 Reviewed by Dirk Pranke.
1897 If we are not running any test that can be skipped by checking
1898 the DRT feature list or looking at the list of symbols, avoid calling
1899 out to DRT or calling "nm".
1901 This saves ~700ms on my Mac Pro. In cases where you still have to call out
1902 to "nm" it's only a couple ms slower.
1904 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1905 (TestExpectations.__init__):
1906 * Scripts/webkitpy/layout_tests/port/base.py:
1907 (Port.skipped_tests):
1908 * Scripts/webkitpy/layout_tests/port/webkit.py:
1909 (WebKitPort._should_check_for_missing_features):
1911 (WebKitPort._should_check_for_missing_symbols):
1912 (WebKitPort._skipped_tests_for_unsupported_features):
1913 (WebKitPort.skipped_layout_tests):
1914 (WebKitPort.skipped_tests):
1915 * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1916 (WebKitPortTest.test_skipped_directories_for_symbols):
1917 (test_skipped_directories_for_features):
1918 (test_skipped_directories_for_features_no_matching_tests_in_test_list):
1919 (test_skipped_layout_tests):
1921 2012-01-26 Benjamin Poulain <bpoulain@apple.com>
1923 Support a suffix on ChangeLog filenames based on a configuration file
1924 https://bugs.webkit.org/show_bug.cgi?id=76956
1926 Reviewed by Kentaro Hara.
1928 Modify the tools used to generate, edit and resolve ChangeLogs to support
1929 the addition of a suffix to the ChangeLog filename.
1931 This patch makes it easier to support alternate ChangeLog files in branches.
1933 * Scripts/VCSUtils.pm:
1935 (changeLogFileName):
1936 * Scripts/commit-log-editor:
1937 * Scripts/prepare-ChangeLog:
1938 (getLatestChangeLogs):
1939 (generateNewChangeLogs):
1941 * Scripts/resolve-ChangeLogs:
1944 2012-01-26 Sheriff Bot <webkit.review.bot@gmail.com>
1946 Unreviewed, rolling out r106038.
1947 http://trac.webkit.org/changeset/106038
1948 https://bugs.webkit.org/show_bug.cgi?id=77142
1950 Caused a bunch of skipped tests to not be skipped. (Requested
1951 by ojan on #webkit).
1953 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1954 (TestExpectationParser):
1955 (TestExpectationParser.parse):
1956 (TestExpectationParser._parse_line):
1957 (TestExpectationParser._collect_matching_tests):
1958 (TestExpectations.__init__):
1959 (TestExpectations._add_skipped_tests):
1960 * Scripts/webkitpy/layout_tests/port/base.py:
1962 (Port.normalize_test_name):
1963 (Port.update_baseline):
1964 (Port.layout_tests_dir):
1965 (Port.relative_perf_test_filename):
1966 (Port.abspath_for_test):
1968 2012-01-25 Ojan Vafai <ojan@chromium.org>
1970 Parsing test_expecations.txt + Skipped lists takes too long
1971 https://bugs.webkit.org/show_bug.cgi?id=77059
1973 Reviewed by Dirk Pranke.
1975 This saves ~100ms on the Apple Mac port.
1976 -memoize a bunch of path methods.
1977 -Avoid doing multiple disk accesses per line.
1978 -Parse the skipped list directly instead of turning it into a test_expecations.txt
1979 formatting string and parsing that.
1981 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1982 (TestExpectationParser):
1983 (TestExpectationParser.parse_skipped_tests):
1984 (TestExpectationParser._parse_line):
1985 (TestExpectationParser._collect_matching_tests):
1986 (TestExpectations.__init__):
1987 (TestExpectations._add_skipped_tests):
1988 * Scripts/webkitpy/layout_tests/port/base.py:
1991 (Port.normalize_test_name):
1992 (Port.layout_tests_dir):
1993 (Port.abspath_for_test):
1995 2012-01-25 Ojan Vafai <ojan@chromium.org>
1997 Only store the SVN revision in the summarized results if we're on a builder
1998 https://bugs.webkit.org/show_bug.cgi?id=76976
2000 Reviewed by Dirk Pranke.
2002 This shaves another ~130ms off the single test run-webkit-tests runtime.
2004 * Scripts/webkitpy/layout_tests/controllers/manager.py:
2005 (summarize_results):
2006 * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2007 (ResultSummaryTest.get_result):
2008 (ResultSummaryTest):
2009 (ResultSummaryTest.get_result_summary):
2010 (ResultSummaryTest.get_unexpected_results):
2011 (ResultSummaryTest.test_no_svn_revision):
2012 (ResultSummaryTest.test_svn_revision):
2013 * Scripts/webkitpy/layout_tests/port/base.py:
2014 (Port.use_trac_links_in_results_html):
2016 2012-01-26 Luciano Wolf <luciano.wolf@openbossa.org>
2018 [Qt][WK2] fast/loader tests failed after r94178
2019 https://bugs.webkit.org/show_bug.cgi?id=67388
2021 Reviewed by Simon Hausmann.
2023 Applying the same fix used for Qt-WebKit1 from bug #67254 -
2024 [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
2025 https://bugs.webkit.org/show_bug.cgi?id=67254
2026 Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
2027 derived from the running location of DumpRenderTree binary.
2029 * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
2030 (WTR::LayoutTestController::pathToLocalResource):
2032 2012-01-26 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
2034 Implement overridePreference for boolean preferences in WebKitTestRunner
2035 https://bugs.webkit.org/show_bug.cgi?id=77033
2037 Reviewed by Alexey Proskuryakov.
2039 For now overridePreference supports boolean values.
2041 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2042 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2043 (WTR::LayoutTestController::setXSSAuditorEnabled):
2044 (WTR::LayoutTestController::overridePreference):
2045 * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2046 * WebKitTestRunner/TestController.cpp:
2047 (WTR::TestController::resetStateToConsistentValues): Reset the overrides
2048 explicitly and properly disable the use of PageCache when resetting the
2049 state. Tests that use PageCache can now enable it via overridePreference.
2051 2012-01-26 Alexander Færøy <alexander.faeroy@nokia.com>
2053 [Qt] Support opening multiple URL's from the command line in the Qt MiniBrowser
2054 https://bugs.webkit.org/show_bug.cgi?id=77100
2056 Reviewed by Simon Hausmann.
2058 This patch makes the MiniBrowser read multiple URL's from the command
2059 line such that there will be one browser window opened for each URL.
2061 * MiniBrowser/qt/MiniBrowserApplication.cpp:
2062 (MiniBrowserApplication::handleUserOptions):
2064 2012-01-26 Alexander Færøy <alexander.faeroy@nokia.com>
2066 [Qt] The Qt MiniBrowser crashes when given multiple URL's
2067 https://bugs.webkit.org/show_bug.cgi?id=77009
2069 Reviewed by Simon Hausmann.
2071 This patch fixes a crash in BrowserWindow::newWindow() where a
2072 BrowserWindow-object is constructed with a 0 pointer as the
2073 WindowOptions parameter which leads to a crash.
2075 * MiniBrowser/qt/BrowserWindow.cpp:
2076 (BrowserWindow::BrowserWindow):
2077 (BrowserWindow::newWindow):
2078 * MiniBrowser/qt/BrowserWindow.h:
2080 2012-01-26 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
2082 [Qt] Use ICU if available
2083 https://bugs.webkit.org/show_bug.cgi?id=76821
2085 Reviewed by Simon Hausmann.
2087 Adding unicode defines for a Qt 5 based build.
2089 * qmake/mkspecs/features/features.prf:
2091 2012-01-26 Nándor Huszka <huszka.nandor@stud.u-szeged.hu>
2093 [WK2] WebKitTestRunner needs layoutTestController.setGeolocationPermission
2094 https://bugs.webkit.org/show_bug.cgi?id=42545
2096 Reviewed by Zoltan Herczeg.
2098 Implement the setGeolocationPermission method.
2100 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2101 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2102 (WTR::LayoutTestController::setGeolocationPermission):
2104 * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2105 (LayoutTestController):
2107 2012-01-26 Balazs Kelemen <kbalazs@webkit.org>
2109 [NRWT] Support --ignore-metrics
2110 https://bugs.webkit.org/show_bug.cgi?id=76278
2112 Reviewed by Tony Chang.
2114 Port the feature from ORWT.
2116 * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2117 (SingleTestRunner._run_compare_test):
2118 * Scripts/webkitpy/layout_tests/port/driver.py:
2120 (DriverOutput.strip_metrics):
2121 * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
2123 (DriverOutputTest.test_strip_metrics):
2124 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2125 (_set_up_derived_options):
2128 2012-01-26 Sheriff Bot <webkit.review.bot@gmail.com>
2130 Unreviewed, rolling out r105935 and r105954.
2131 http://trac.webkit.org/changeset/105935
2132 http://trac.webkit.org/changeset/105954
2133 https://bugs.webkit.org/show_bug.cgi?id=77080
2135 test-webkitpy is still broken (Requested by abarth on
2138 * Scripts/test-webkitpy:
2139 * Scripts/webkitpy/common/system/executive_unittest.py:
2140 (never_ending_command):
2141 (ExecutiveTest.test_run_command_args_type):
2142 (ExecutiveTest.test_run_command_with_unicode):
2143 (ExecutiveTest.test_running_pids):
2144 * Scripts/webkitpy/common/system/fileutils.py:
2145 (make_stdout_binary):
2146 * Scripts/webkitpy/test/cat.py:
2147 (command_arguments):
2149 * Scripts/webkitpy/test/cat_unittest.py:
2151 (CatTest.assert_cat):
2152 (CatTest.test_basic):
2153 (CatTest.test_no_newline):
2154 (CatTest.test_unicode):
2155 (CatTest.test_as_command):
2156 * Scripts/webkitpy/test/echo.py:
2157 (command_arguments):
2159 * Scripts/webkitpy/test/echo_unittest.py:
2161 (EchoTest.test_basic):
2162 (EchoTest.test_no_newline):
2163 (EchoTest.test_unicode):
2164 (EchoTest.test_argument_order):
2165 (EchoTest.test_empty_arguments):
2166 (EchoTest.test_no_arguments):
2167 (EchoTest.test_as_command):
2169 2012-01-26 Gabor Rapcsanyi <rgabor@webkit.org>
2171 [GTK] Detect cross-compilation in webkitdirs.pm to not generate gtkdoc
2172 https://bugs.webkit.org/show_bug.cgi?id=76138
2174 Reviewed by Martin Robinson.
2176 * Scripts/webkitdirs.pm:
2177 (isCrossCompilation):
2178 (buildAutotoolsProject):
2180 2012-01-25 Adam Barth <abarth@webkit.org>
2182 Kentaro is a reviewer now. Yay!
2184 * Scripts/webkitpy/common/config/committers.py:
2186 2012-01-25 Dirk Pranke <dpranke@chromium.org>
2188 nrwt: running w/ no arguments fails
2189 https://bugs.webkit.org/show_bug.cgi?id=77064
2191 Unreviewed, build fix.
2193 This change fixes a regression introduced in r105944
2194 where running without --platform <foo> or one of the other
2195 platform switches would cause a null deref :(.
2197 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2200 2012-01-25 Eric Seidel <eric@webkit.org>
2202 Automatically CC someone from Apple on any changes to Obj-C public API
2203 https://bugs.webkit.org/show_bug.cgi?id=77053
2205 Reviewed by Timothy Hatcher.
2207 This has long been de-facto practice, seems now that we have
2208 fancy watchlist support, we should just make the tools
2209 do this automatically.
2211 * Scripts/webkitpy/common/config/watchlist:
2213 2012-01-25 Antoine Labour <piman@chromium.org>
2215 Updating status in committers.py.
2219 * Scripts/webkitpy/common/config/committers.py:
2221 2012-01-25 Dirk Pranke <dpranke@chromium.org>
2223 test-webkitpy: executive_unittest fails if PYTHONPATH isn't set
2224 https://bugs.webkit.org/show_bug.cgi?id=77058
2226 Reviewed by Eric Seidel.
2228 r105935 broke executive_unittest by changing which script we
2229 were running and not ensuring that the PYTHONPATH was set up
2232 This change also fixes a regression introduced recently where
2233 test-webkitpy wasn't figuring out the path to Tools/Scripts
2234 right, either (so running ./test-webkitpy would fail).
2236 * Scripts/test-webkitpy:
2237 * Scripts/webkitpy/common/system/executive_unittest.py:
2239 (ExecutiveTest.setUp):
2241 (ExecutiveTest.tearDown):
2243 2012-01-25 Adam Barth <abarth@webkit.org>
2245 Disable tests on the mac-ews while we sort out hte stability issues.
2247 * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2250 2012-01-23 Dirk Pranke <dpranke@chromium.org>
2252 investigate use of 'mac' and 'win' as fully-specified port names for the apple ports
2253 https://bugs.webkit.org/show_bug.cgi?id=76475
2255 Reviewed by Eric Seidel.
2257 This patch cleans up the internal usage of port names for the
2258 Apple mac and Apple win ports so that 'mac' and 'win are never
2259 considered "fully specified" port names: they are still legal
2260 input to the PortFactory.get() routine, but only if run on the given
2261 platform (i.e. trying to PortFactory.get('mac') on windows or
2262 linux will return an error, since we don't know which version of
2263 the port is desired.
2265 This also cleans up handling of the webkit2 variants, so that
2266 the full port names consistently follow the
2267 <operating_system>-<version>[-<wk2>] convention.
2269 Lastly this patch adds some assertions and removes some
2270 try/catch logic to catch more programming and usage errors;
2271 previously mac-tiger might've been allowed -- and it would've
2272 translated into using just the baselines in platform/mac -- but
2275 * Scripts/webkitpy/layout_tests/port/apple.py:
2276 (ApplePort.determine_full_port_name):
2277 (ApplePort.__init__):
2279 (ApplePort._port_name_with_version):
2280 * Scripts/webkitpy/layout_tests/port/builders.py:
2281 * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2282 (FactoryTest.test_mac):
2283 (FactoryTest.test_win):
2284 * Scripts/webkitpy/layout_tests/port/mac.py:
2285 (MacPort.baseline_search_path):
2286 * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2287 (MacTest.test_versions):
2288 * Scripts/webkitpy/layout_tests/port/win.py:
2289 (WinPort.baseline_search_path):
2290 * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2291 (WinTest.test_versions):
2293 2012-01-25 Dirk Pranke <dpranke@chromium.org>
2295 webkitpy: print nicer errors while linting expectations files, remove redundant tests
2296 https://bugs.webkit.org/show_bug.cgi?id=76955
2298 Reviewed by Adam Barth.
2300 This change cleans up the errors that are printed so that the
2301 are more "quickfix" compatible (path:lineno).
2303 Also, there were a bunch of redundant tests between
2304 layout_tests.models.test_expectations_unittest and
2305 style.checkers.test_expectations_unittest. The latter should
2306 just expect the former to do most of the testing.
2308 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2309 (TestExpectationParser._parse_modifiers):
2310 (TestExpectations._report_errors):
2311 (TestExpectations._add_skipped_tests):
2312 * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2313 (test_parse_error_nonfatal):
2314 (SemanticTests.test_bad_bugid):
2315 * Scripts/webkitpy/style/checkers/test_expectations.py:
2316 (TestExpectationsChecker.__init__):
2317 * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2318 (TestExpectationsTestCase.assert_lines_lint):
2319 (TestExpectationsTestCase.test_valid_expectations):
2320 (TestExpectationsTestCase.test_invalid_expectations):
2321 (TestExpectationsTestCase.test_tab):
2323 2012-01-25 Eric Seidel <eric@webkit.org>
2325 webkit-patch apply-* should always continue after failures
2326 https://bugs.webkit.org/show_bug.cgi?id=77057
2328 Reviewed by Adam Barth.
2330 As far as I can tell there is only one potential drawback to always
2331 forcing: that if you're somehow in the wrong directory it will create new
2332 directories for new files. Since webkit-patch always cd's to the root
2333 it seems that's not a drawback. The drawback of not using --force for
2334 svn-apply, is that it will stop after the first failure, which is rarely
2335 (if ever) the desired behavior. This just removes the force option
2336 (which was strangely hidden behind --non-interactive). This should
2337 make for a better user experiance.
2339 * Scripts/webkitpy/common/checkout/checkout.py:
2340 (Checkout.apply_patch):
2341 * Scripts/webkitpy/common/checkout/checkout_mock.py:
2342 (MockCheckout.apply_patch):
2343 * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2344 (CheckoutTest.test_chromium_deps):
2346 (CheckoutTest.test_apply_patch):
2347 * Scripts/webkitpy/tool/commands/download_unittest.py:
2348 (DownloadCommandsTest._default_options):
2349 * Scripts/webkitpy/tool/steps/applypatch.py:
2350 (ApplyPatch.options):
2352 * Scripts/webkitpy/tool/steps/options.py:
2355 2012-01-25 Dirk Pranke <dpranke@chromium.org>
2357 nrwt: should be able to run --platform test interactively
2358 https://bugs.webkit.org/show_bug.cgi?id=76959
2360 Reviewed by Adam Barth.
2362 As part of refactoring the Port interfaces, in r103254 I made
2363 passing a Host object to the Port mandatory; previously TestPort
2364 objects would create their own (mock) hosts. However,
2365 new-run-webkit-tests always passed a real Host, not a MockHost,
2366 and so you couldn't run new-run-webkit-tests --platform test
2367 interactively to debug test failures.
2369 This change fixes that by creating a MockHost instead of a real
2370 host if you say --platform test*.
2372 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2375 2012-01-25 Dirk Pranke <dpranke@chromium.org>
2377 run-webkit-tests --lint-test-files should lint all the ports by default
2378 https://bugs.webkit.org/show_bug.cgi?id=76749
2380 Reviewed by Ojan Vafai.
2382 Currently run-webkit-tests --lint-test-files will only lint the
2383 test_expectations for the single port determined by the command
2384 line options. This is not obvious and can produce unintended results
2385 if you want to lint the chromium port (probably the normal case
2386 for using --lint-test-files) but don't specify a port name or
2389 I think we should probably lint *all* of the ports if no port
2390 name is supplied. This change implements that, and also moves
2391 the linting logic out of the Manager class, since this really
2392 has nothing to do with Managers. It has little to do with
2393 run-webkit-tests, but splitting it into a different script would
2394 introduce compatibility issues. It might make sense to do that
2395 anyway, in a separate patch and combining that with cleaning up
2396 the style checker to share more code.
2398 * Scripts/webkitpy/layout_tests/controllers/manager.py:
2399 (Manager._strip_test_dir_prefix):
2400 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2403 * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2404 (LintTest.test_all_configurations): added.
2405 (LintTest.test_lint_test_files): added.
2406 (LintTest.test_lint_test_files__errors): added.
2407 (MainTest.test_lint_test_files): removed.
2408 (MainTest.test_lint_test_files__errors): removed.
2410 2012-01-25 Dirk Pranke <dpranke@chromium.org>
2412 webkitpy: clean up a bunch of test scaffolding
2413 https://bugs.webkit.org/show_bug.cgi?id=76973
2415 Reviewed by Eric Seidel.
2417 There were several helper modules in the webkitpy.test package
2418 that appear to only be used by executive_unittest.py. I am
2419 rolling them all into that file to make that clearer.
2421 * Scripts/webkitpy/common/system/executive_unittest.py:
2422 (ExecutiveTest.test_run_command_args_type):
2423 (ExecutiveTest.test_run_command_with_unicode):
2424 (ExecutiveTest.test_running_pids):
2427 * Scripts/webkitpy/common/system/fileutils.py: Removed.
2428 * Scripts/webkitpy/test/cat.py: Removed.
2429 * Scripts/webkitpy/test/cat_unittest.py: Removed.
2430 * Scripts/webkitpy/test/echo.py: Removed.
2431 * Scripts/webkitpy/test/echo_unittest.py: Removed.
2433 2012-01-25 Dirk Pranke <dpranke@chromium.org>
2435 webkitpy: clean up a bunch of test scaffolding
2436 https://bugs.webkit.org/show_bug.cgi?id=76973
2438 Reviewed by Eric Seidel.
2440 There were several helper modules in the webkitpy.test package
2441 that appear to only be used by executive_unittest.py. I am
2442 rolling them all into that file to make that clearer.
2444 * Scripts/webkitpy/common/system/executive_unittest.py:
2445 (ExecutiveTest.test_run_command_args_type):
2446 (ExecutiveTest.test_run_command_with_unicode):
2447 (ExecutiveTest.test_running_pids):
2450 * Scripts/webkitpy/common/system/fileutils.py: Removed.
2451 * Scripts/webkitpy/test/cat.py: Removed.
2452 * Scripts/webkitpy/test/cat_unittest.py: Removed.
2453 * Scripts/webkitpy/test/echo.py: Removed.
2454 * Scripts/webkitpy/test/echo_unittest.py: Removed.
2456 2012-01-25 Eric Seidel <eric@webkit.org>
2458 Remove Python 2.5 support from WebKit
2459 https://bugs.webkit.org/show_bug.cgi?id=71593
2461 Reviewed by Adam Barth.
2463 Just removing support from this one core file.
2464 I'll commit the rest of the (large) change once we've
2465 gone 24 hours and seen that no bots have exploded.
2466 We can roll out this one change if we break bots
2467 and then roll in the rest once those bots are fixed.
2469 * Scripts/webkitpy/common/system/executive.py:
2470 (Executive.cpu_count):
2472 2012-01-25 Hajime Morita <morrita@google.com>
2474 ENABLE_SHADOW_DOM should be available via build-webkit --shadow-dom
2475 https://bugs.webkit.org/show_bug.cgi?id=76863
2477 Reviewed by Dimitri Glazkov.
2479 Added a feature flag.
2481 * Scripts/build-webkit:
2482 * qmake/mkspecs/features/features.prf:
2484 2012-01-25 Martin Robinson <mrobinson@igalia.com>
2486 [WK2] Navigation events not triggered by a mouse event claim to be triggered by the left mouse button during policy decisions
2487 https://bugs.webkit.org/show_bug.cgi?id=76344
2489 Reviewed by Sam Weinig.
2491 Add a test verifying that the mouse button during policy decisions for
2492 events not triggered by mouse events is NoButton.
2494 * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2495 (TestWebKitAPI::decidePolicyForNavigationAction): Added test.
2496 (TestWebKitAPI::decidePolicyForNewWindowAction): Added test.
2498 2012-01-25 Ryosuke Niwa <rniwa@webkit.org>
2500 run-perf-tests should timeout sooner
2501 https://bugs.webkit.org/show_bug.cgi?id=77026
2503 Reviewed by Adam Barth.
2505 Bump off the timeout from 10 minutes to 4 minutes.
2507 Also use float instead of str in test result values to compress the size of json files bots upload.
2509 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2510 (PerfTestsRunner._parse_args):
2511 (PerfTestsRunner._process_chromium_style_test_result):
2512 (PerfTestsRunner._process_parser_test_result):
2513 * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2514 (test_run_test_set_for_parser_tests):
2515 (test_run_test_set_with_json_output):
2516 (test_run_test_set_with_json_source):
2518 2012-01-25 Enrica Casucci <enrica@apple.com>
2520 WebView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
2521 https://bugs.webkit.org/show_bug.cgi?id=76951
2522 <rdar://problem/9325158>
2524 Reviewed by Alexey Proskuryakov.
2526 * TestWebKitAPI/Tests/mac/InspectorBar.mm: Modified to reflect the changes to WebView
2528 (TestWebKitAPI::TEST):
2530 2012-01-23 MORITA Hajime <morrita@google.com>
2532 [Refactoring][Internals] Should have InternalSettings
2533 https://bugs.webkit.org/show_bug.cgi?id=76424
2535 Reviewed by Kent Tamura.
2537 * GNUmakefile.am: Added so new files.
2539 2012-01-25 Takashi Toyoshima <toyoshim@chromium.org>
2541 webkitpy: new-run-webkit-websocket is broken
2542 https://bugs.webkit.org/show_bug.cgi?id=76999
2544 Reviewed by Dirk Pranke.
2546 r105674 broke new-run-webkit-websocket, since options.chromium
2547 doesn't exist any more. new-run-webkit-httpd was also broken
2548 and already fixed at r105835.
2549 * Scripts/new-run-webkit-websocketserver:
2552 2012-01-25 Nándor Huszka <huszka.nandor@stud.u-szeged.hu>
2554 [WK2] WebKitTestRunner needs layoutTestController.setPopupBlockingEnabled
2555 https://bugs.webkit.org/show_bug.cgi?id=63458
2557 Reviewed by Adam Roben.
2559 Implement the setPopupBlockingEnabled method.
2561 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2562 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2563 (WTR::LayoutTestController::setPopupBlockingEnabled):
2564 * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2566 2012-01-24 Balazs Kelemen <kbalazs@webkit.org>
2568 [Qt] Cleanup testfonts handling
2569 https://bugs.webkit.org/show_bug.cgi?id=76068
2571 Reviewed by Simon Hausmann.
2573 Factor test font initialization into it's own file so test
2574 font users can share the implementation by adding the file
2576 Use fonts.conf from the test font directory to not require the
2577 current directory to be the WebKit root.
2578 Fix the -use-test-fonts option of QtTestBrowser by initializing
2579 the fonts earlier, before it is too late (namely before calling
2580 show on the main window).
2582 * DumpRenderTree/qt/DumpRenderTree.pro:
2583 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2584 (WebCore::DumpRenderTree::open):
2585 * DumpRenderTree/qt/DumpRenderTreeQt.h:
2586 * DumpRenderTree/qt/QtInitializeTestFonts.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
2587 (WebKit::initializeTestFonts):
2588 * DumpRenderTree/qt/QtInitializeTestFonts.h: Added.
2589 * DumpRenderTree/qt/fonts.conf: Removed. No need for this since
2590 we will use the one from the test fonts directory.
2591 * DumpRenderTree/qt/main.cpp:
2592 (main): Fix the ifdefs to make it clear that the code to
2593 set up the Dpi has not been ported to Qt5 yet.
2594 * QtTestBrowser/QtTestBrowser.pro:
2595 * QtTestBrowser/launcherwindow.h:
2596 (WindowOptions::WindowOptions):
2597 * QtTestBrowser/main.cpp:
2599 (LauncherApplication::handleUserOptions):
2600 * WebKitTestRunner/InjectedBundle/Target.pri:
2601 * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2602 (WTR::activateFonts): Remove the code to set up the Dpi
2603 because it does not work with Qt5.
2605 2012-01-25 Simon Hausmann <simon.hausmann@nokia.com>
2607 [Qt] build-webkit --qt requires a git-svn or SVN checkout.
2609 Reviewed by Tor Arne Vestø.
2611 Don't require it by making svnRevisionForDirectory return "unknown"
2612 instead of bailing out with an error.
2614 * Scripts/VCSUtils.pm:
2615 (svnRevisionForDirectory):
2617 2012-01-25 Adam Barth <abarth@webkit.org>
2619 Temporarily disable running the unit tests on the Chromium EWS. These
2620 tests don't work properly (see
2621 https://bugs.webkit.org/show_bug.cgi?id=76979) and are currently
2624 * Scripts/webkitpy/common/config/ports.py:
2627 2012-01-25 Adam Barth <abarth@webkit.org>
2629 Update results.html version of PixelZoomer
2630 https://bugs.webkit.org/show_bug.cgi?id=76965
2632 Reviewed by Ojan Vafai.
2634 Improve readability as suggested by Ojan.
2636 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:
2638 2012-01-25 Carlos Garcia Campos <cgarcia@igalia.com>
2640 [GTK] Page clients don't need to be GObjects anymore in WebKit2 GTK+ API
2641 https://bugs.webkit.org/show_bug.cgi?id=76899
2643 Reviewed by Martin Robinson.
2645 * gtk/generate-gtkdoc:
2646 (get_webkit2_options): WebKitWebLoaderClient has been renamed to
2649 2012-01-24 Ryosuke Niwa <rniwa@webkit.org>
2651 Build fix. Trigger Chromium Mac Release (Perf) on new commits.
2653 * BuildSlaveSupport/build.webkit.org-config/config.json:
2655 2012-01-23 Ryosuke Niwa <rniwa@webkit.org>
2657 WebKit needs public performance tests running on public bots
2658 https://bugs.webkit.org/show_bug.cgi?id=10266
2660 Reviewed by Adam Barth.
2662 Completes the initial implementation of WebKit Perf bots. Add a build step for run-perf-test
2663 and make google-mac-4 run it, and upload the results to webkit-perf.webkit.org.
2665 * BuildSlaveSupport/build.webkit.org-config/config.json:
2666 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2667 (RunAndUploadPerfTests):
2668 (RunAndUploadPerfTests.start):
2669 (UploadPerfTestResults):
2670 (BuildAndPerfTestFactory):
2671 (BuildAndPerfTestFactory.__init__):
2673 2012-01-24 Ojan Vafai <ojan@chromium.org>
2675 Initializing the browser property of the Bugzilla class takes too long
2676 https://bugs.webkit.org/show_bug.cgi?id=76960
2678 Reviewed by Adam Barth.
2680 Lazily initialize it. This saves ~150ms on a no-op run-webkit-tests call
2683 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2684 (Bugzilla.__init__):
2685 (Bugzilla._get_browser):
2687 (Bugzilla._set_browser):
2689 2012-01-24 Mark Rowe <mrowe@apple.com>
2691 Death to JavaScriptGlue.
2693 Rubber-stamped by Geoffrey Garen.
2695 * BuildSlaveSupport/build-launcher-app:
2696 (copyNightlyLauncher):
2697 * Scripts/build-webkit:
2698 * Scripts/do-file-rename:
2699 * Scripts/do-webcore-rename:
2700 * Scripts/webkitpy/common/config/build.py:
2701 (_should_file_trigger_build):
2702 * Scripts/webkitpy/common/config/build_unittest.py: Update the test to use another Mac-specific
2703 path in conjunction with a cross-platform path.
2706 2012-01-24 Kentaro Hara <haraken@chromium.org>
2708 webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl should test stdout and stderr
2709 https://bugs.webkit.org/show_bug.cgi?id=75836
2711 Reviewed by David Kilzer.
2713 Previously parser_unittests.pl can just test the returned value of
2714 get_function_line_ranges() in prepare-ChangeLog. This patch fixes
2715 parser_unittests.pl so that it also tests the stdout and stderr of
2716 get_function_line_ranges().
2718 This patch adds css_unittests_warning.css, which contains test cases
2719 for warning messages of the CSS parser of prepare-ChangeLog.
2721 * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2722 (captureOutput): Captures the stdout and stderr of a given method.
2723 (convertAbsolutepathToWebKitPath): Converts absolute paths in a given
2724 string to relative paths.
2726 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt: Added.
2727 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css: Added.
2736 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
2737 Just updated the test results, i.e. added stdout and stderr results.
2738 No essential changes in the test results.
2739 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Ditto.
2740 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests-expected.txt: Ditto.
2741 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Ditto.
2742 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt: Ditto.
2743 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt: Ditto.
2745 2012-01-24 Dirk Pranke <dpranke@chromium.org>
2747 webkitpy: new-run-webkit-httpd is broken
2748 https://bugs.webkit.org/show_bug.cgi?id=76963
2750 Reviewed by Adam Barth.
2752 r105674 broke new-run-webkit-httpd, since options.chromium
2753 doesn't exist any more. We didn't catch this because we don't
2754 run the integration tests by default anywhere :(.
2756 * Scripts/new-run-webkit-httpd:
2760 2012-01-24 Adam Barth <abarth@webkit.org>
2762 garden-o-matic pixel zoomer should let you look at every pixel of the image
2763 https://bugs.webkit.org/show_bug.cgi?id=76962
2765 Reviewed by Ojan Vafai.
2767 Previously, you couldn't get up to the right and bottom pixels.
2769 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:
2771 2012-01-24 Enrica Casucci <enrica@apple.com>
2773 WebHTMLView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
2774 https://bugs.webkit.org/show_bug.cgi?id=76951
2775 <rdar://problem/9325158>
2777 Added test to verify that WebHTMLView supports the typingAttributes method and that it
2780 Reviewed by Alexey Proskuryakov.
2782 * TestWebKitAPI/Tests/mac/InspectorBar.mm:
2783 (TestWebKitAPI::TEST):
2785 2012-01-24 James Robinson <jamesr@chromium.org>
2787 Put a space between the trac link and ellipsis in sheriffbot rollout message so it linkifies better in some IRC clients
2788 https://bugs.webkit.org/show_bug.cgi?id=76884
2790 Reviewed by Adam Barth.
2792 * Scripts/webkitpy/tool/bot/irc_command.py:
2794 * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2795 (SheriffIRCBotTest.test_rollout):
2796 (SheriffIRCBotTest.test_revert):
2797 (SheriffIRCBotTest.test_multi_rollout):
2798 (SheriffIRCBotTest.test_rollout_with_r_in_svn_revision):
2799 (SheriffIRCBotTest.test_multi_rollout_with_r_in_svn_revision):
2800 (SheriffIRCBotTest.test_rollout_invalidate_reason):
2801 (test_multi_rollout_invalidate_reason):
2803 2012-01-24 Kentaro Hara <haraken@chromium.org>
2805 The cpp parser of prepare-ChangeLog cannot detect a change in classes and namespaces
2806 https://bugs.webkit.org/show_bug.cgi?id=75531
2808 Reviewed by David Kilzer.
2810 Previously, the cpp parser of prepare-ChangeLog could not detect a change
2811 outside methods. Consider the following cpp file.
2814 int a; // this change does not appear on ChangeLog.
2816 int b; // this change does not appear on ChangeLog.
2819 int c; // this change appears on ChangeLog.
2821 int d; // this change does not appear on ChangeLog.
2823 int e; // this change does not appear on ChangeLog.
2826 The previous prepare-ChangeLog outputs just methods in which a change is found:
2829 This patch fixes prepare-ChangeLog so that it outputs namespaces, classes
2830 and methods in which a change is found:
2835 * Scripts/prepare-ChangeLog:
2836 (get_function_line_ranges_for_cpp): Modified as described above.
2838 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases.
2849 (NameSpace5::NameSpace6::Class107::func34):
2850 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
2852 2012-01-24 Kentaro Hara <haraken@chromium.org>
2854 prepare-ChangeLog outputs warnings for top-level { ... } blocks
2855 https://bugs.webkit.org/show_bug.cgi?id=75943
2857 Reviewed by David Kilzer.
2859 Currently, prepare-ChangeLog outputs warnings for top-level { ... } blocks,
2860 because it does not distinguish '}' at the end of a subroutine
2861 with '}' at the end of a if or for statement.
2870 nested functions found at top-level at foo.pl:2
2871 nested functions found at top-level at foo.pl:4
2873 This patch fixes the bug.
2875 * Scripts/prepare-ChangeLog:
2876 (get_function_line_ranges_for_perl):
2877 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
2878 Added test cases. No change in the test results.
2880 2012-01-24 Dirk Pranke <dpranke@chromium.org>
2882 r105674 broke check-webkit-style for chromium's test_expectations.
2884 Unreviewed, build fix.
2886 We now need to pass in a platform name of 'chromium' if we want
2887 the chromium port; options.chromium is no longer recognized. I
2888 will follow this patch up with a separate patch that has a test,
2889 but this at least fixes the build.
2891 * Scripts/webkitpy/style/checkers/test_expectations.py:
2892 (TestExpectationsChecker._determine_port_from_exepectations_path):
2894 2012-01-20 Ojan Vafai <ojan@chromium.org>
2896 check-webkit-style of the chromium test_expectations.txt file takes too long
2897 https://bugs.webkit.org/show_bug.cgi?id=76745
2899 Reviewed by Dimitri Glazkov.
2901 When in lint mode, have TestExpectations test all configurations instead
2902 of looping over each configuration. This also has the benefit of making
2903 the error output considerably more concise.
2905 Also, got rid of the double-printing of errors when linting through check-webkit-style.
2907 * Scripts/webkitpy/layout_tests/controllers/manager.py:
2909 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2910 (TestExpectations._report_errors):
2911 (TestExpectations._add_expectations):
2912 * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2913 (test_parse_error_nonfatal):
2914 (test_error_on_different_platform):
2915 * Scripts/webkitpy/style/checkers/test_expectations.py:
2916 (TestExpectationsChecker.check_test_expectations):
2917 (TestExpectationsChecker.check):
2918 * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2919 (TestExpectationsTestCase.test_determine_port_from_exepectations_path):
2920 (TestExpectationsTestCase.assert_lines_lint):
2922 2012-01-24 Ryosuke Niwa <rniwa@webkit.org>
2924 Another build fix attempt after r105543.
2926 * Scripts/webkitpy/common/net/file_uploader.py:
2927 (FileUploader.upload_as_multipart_form_data):
2929 2012-01-24 Ryosuke Niwa <rniwa@webkit.org>
2931 Build fix attempt after r105543.
2933 * Scripts/webkitpy/common/net/file_uploader.py:
2934 (FileUploader.upload_as_multipart_form_data):
2936 2012-01-24 Vincent Scheib <scheib@chromium.org>
2938 [Chromium] Add Pointer Lock test hooks and mock implementation to DumpRenderTree
2939 https://bugs.webkit.org/show_bug.cgi?id=76411
2941 Reviewed by Adam Barth.
2943 Breaking up https://bugs.webkit.org/show_bug.cgi?id=75762
2944 into a series of patches, this change adds a trivial
2945 pointer lock implementation to the Chromium port's DumpRenderTree
2946 and exposes LayoutTestController hooks to force failure conditions.
2948 * DumpRenderTree/chromium/LayoutTestController.cpp:
2949 (LayoutTestController::LayoutTestController):
2950 (LayoutTestController::didLosePointerLock):
2951 (LayoutTestController::setPointerLockWillFailAsynchronously):
2952 (LayoutTestController::setPointerLockWillFailSynchronously):
2953 * DumpRenderTree/chromium/LayoutTestController.h:
2954 * DumpRenderTree/chromium/WebViewHost.cpp:
2955 (WebViewHost::requestPointerLock):
2956 (WebViewHost::requestPointerUnlock):
2957 (WebViewHost::isPointerLocked):
2958 (WebViewHost::didCompletePointerLock):
2959 (WebViewHost::didNotCompletePointerLock):
2960 (WebViewHost::didLosePointerLock):
2961 (WebViewHost::reset):
2962 * DumpRenderTree/chromium/WebViewHost.h:
2963 (WebViewHost::setPointerLockWillFailAsynchronously):
2964 (WebViewHost::setPointerLockWillFailSynchronously):
2966 2012-01-24 Mario Sanchez Prada <msanchez@igalia.com>
2968 Unreviewed, skip WK2 API test timing out on some GTK bots.
2970 WebKit2APITests/TestDownloads is consistently timing out on the
2971 32bit release and 64bit debug bots.
2973 * Scripts/run-gtk-tests:
2974 (TestRunner): Skip WebKit2APITests/TestDownloads.
2976 2012-01-24 Andras Becsi <andras.becsi@nokia.com>
2978 [Qt] Fix the build with the newes Qt5 hashes
2979 https://bugs.webkit.org/show_bug.cgi?id=76657
2981 Reviewed by Simon Hausmann.
2983 * MiniBrowser/qt/MiniBrowserApplication.cpp:
2984 (MiniBrowserApplication::MiniBrowserApplication): Disable the automatic touch->mouse event synthesis
2985 for now to prevent an infinite loop where Qt always creates mouse events out of our touch mock events.
2987 2012-01-24 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
2989 [Qt] Distinguish between Cygwin and cmd.exe in the way we set env variables
2991 We can't use win32-msvc* to decide whether or not to use (set FOO=bar), as
2992 building with MinGW inside cmd.exe will require the same construct. Instead
2993 we assume that when the first character in PWD is a '/' we're running under
2994 Cygwin, and use the normal unix way of setting environment variables.
2996 Reviewed by Simon Hausmann.
2998 * qmake/mkspecs/features/default_pre.prf:
3000 2012-01-24 Simon Hausmann <simon.hausmann@nokia.com>
3002 Some qmake build files must include Qt5's "quick" module.
3003 https://bugs.webkit.org/show_bug.cgi?id=76671
3005 Unreviewed build fix.
3007 * MiniBrowser/qt/MiniBrowser.pro:
3008 * WebKitTestRunner/Target.pri:
3010 2012-01-24 Andras Becsi <andras.becsi@nokia.com>
3012 [Qt] Fix the event timestamps for touch mocking
3014 Reviewed by Simon Hausmann.
3016 * MiniBrowser/qt/MiniBrowserApplication.cpp:
3017 (MiniBrowserApplication::sendTouchEvent): We should not set QEvent::None as the
3018 timestamp argument in the QWindowSystemInterface::handleTouchEvent call.
3020 2012-01-24 Carlos Garcia Campos <cgarcia@igalia.com>
3022 [GTK] Implement DownloadClient in WebKit2 GTK+ API
3023 https://bugs.webkit.org/show_bug.cgi?id=72952
3025 Reviewed by Martin Robinson.
3027 * gtk/generate-gtkdoc:
3028 (get_webkit2_options): Ignore WebKitDownloadClient.
3030 2012-01-23 Zan Dobersek <zandobersek@gmail.com>
3032 [GTK] editing/deleting/5408255.html results are incorrect
3033 https://bugs.webkit.org/show_bug.cgi?id=53644
3035 Reviewed by Martin Robinson.
3037 WEBKIT_TOP_LEVEL environment variable is now set directly in either
3038 WebKitTestRunner or DumpRenderTree through usage of a compilation-time
3039 macro. This way both tools can be run outside the test harness without
3040 the need to manually set the environment variable.
3042 * DumpRenderTree/gtk/DumpRenderTree.cpp:
3045 * Scripts/webkitpy/layout_tests/port/gtk.py:
3046 (GtkPort.setup_environ_for_server):
3047 * WebKitTestRunner/GNUmakefile.am:
3048 * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
3049 (WTR::InjectedBundle::platformInitialize):
3051 2012-01-23 Dmitry Lomov <dslomov@google.com>
3053 [Chromium] Implement layoutTestController.workerThreadCount in DRT
3054 https://bugs.webkit.org/show_bug.cgi?id=74653.
3056 Reviewed by Darin Fisher.
3058 * DumpRenderTree/chromium/LayoutTestController.cpp:
3059 (LayoutTestController::LayoutTestController):
3060 (LayoutTestController::workerThreadCount):
3061 * DumpRenderTree/chromium/LayoutTestController.h:
3063 2012-01-23 Dirk Pranke <dpranke@chromium.org>
3065 nrwt: make --chromium work like --qt
3066 https://bugs.webkit.org/show_bug.cgi?id=76875
3068 Reviewed by Adam Barth.
3070 --chromium used to have to be handled differently from --qt
3071 due to the way the PortFactory was implemented; there's not
3072 really a good reason for that any more so this patch makes
3073 things slightly more consistent and eliminates the
3074 options.chromium flag (--chromium is now truly a synonym for
3075 --platform chromium).
3077 * Scripts/webkitpy/layout_tests/port/factory.py:
3078 (PortFactory._default_port):
3080 * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3081 (FactoryTest.setUp):
3082 (FactoryTest.test_chromium_mac):
3083 (FactoryTest.test_chromium_linux):
3084 (FactoryTest.test_chromium_win):
3085 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3088 2012-01-23 Dirk Pranke <dpranke@chromium.org>
3090 run-webkit-tests needs to propagate --chromium
3091 https://bugs.webkit.org/show_bug.cgi?id=76870
3093 Reviewed by Eric Seidel.
3095 run-webkit-tests removes '--chromium' argument from @ARGV when
3096 determining which port to run, which means that that doesn't
3097 propagate to new-run-webkit-tests. That's bad (and is handled
3098 for the other ports by re-adding the flag, but apparently we're
3099 just now noticing for Chromium).
3101 * Scripts/run-webkit-tests:
3103 2012-01-23 Brian Weinstein <bweinstein@apple.com>
3105 More build fixing after r105646.
3107 * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3108 (TestWebKitAPI::TestNode::key):
3110 2012-01-23 Gavin Barraclough <barraclough@apple.com>
3112 Unreviewed build fix - r105646 broke this.
3114 * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3115 (TestWebKitAPI::TestNode::TestNode):
3116 (TestWebKitAPI::TestNode::key):
3117 (TestWebKitAPI::RedBlackTreeTest::assertEqual):
3118 (TestWebKitAPI::RedBlackTreeTest::assertSameValuesForKey):
3119 (TestWebKitAPI::RedBlackTreeTest::testDriver):
3121 2012-01-23 Sheriff Bot <webkit.review.bot@gmail.com>
3123 Unreviewed, rolling out r105658.
3124 http://trac.webkit.org/changeset/105658
3125 https://bugs.webkit.org/show_bug.cgi?id=76883
3127 We want this eventually, but not right at this moment
3128 (Requested by abarth on #webkit).
3130 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3132 2012-01-23 Adam Barth <abarth@webkit.org>
3134 garden-o-matic should support Chromium Mac Lion
3135 https://bugs.webkit.org/show_bug.cgi?id=76880
3137 Reviewed by Eric Seidel.
3139 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3141 2012-01-23 Emil A Eklund <eae@chromium.org>
3143 check-webkit-style whitespace/operators triggers on overloaded division operator
3144 https://bugs.webkit.org/show_bug.cgi?id=76650
3146 Reviewed by Darin Adler.
3148 * Scripts/webkitpy/style/checkers/cpp.py:
3150 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3151 (CppStyleTest.test_operator_methods):
3153 2012-01-23 Ryosuke Niwa <rniwa@webkit.org>
3155 run-perf-tests should report server-side errors
3156 https://bugs.webkit.org/show_bug.cgi?id=76802
3158 Reviewed by Tony Chang.
3160 Report errors whenever server's response doesn't match "OK".
3162 * Scripts/webkitpy/common/net/file_uploader.py:
3163 (FileUploader.upload_single_text_file):
3164 (FileUploader.upload_as_multipart_form_data):
3165 (FileUploader._upload_data.callback):
3167 (FileUploader._upload_data):
3168 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3169 (PerfTestsRunner._upload_json):
3170 * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3172 (test_upload_json.MockFileUploader.upload_single_text_file):
3174 2012-01-22 Ryosuke Niwa <rniwa@webkit.org>
3176 run-perf-tests ignore Skipped list on chromium
3177 https://bugs.webkit.org/show_bug.cgi?id=76764
3179 Reviewed by Dirk Pranke.
3181 Move skipped_perf_tests from WebKit port to Base port so that Chromium port
3182 can also find skipped list. Chromium port only uses test_expectations.txt for
3183 layout tests but performacne tests don't use test_expectations.txt so Chromium port
3184 also needs to use Skipped list.
3186 * Scripts/webkitpy/layout_tests/port/base.py:
3187 (Port._tests_from_skipped_file_contents):
3189 (Port._expectations_from_skipped_files):
3190 (Port.skipped_perf_tests):
3191 * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3192 (PortTest.test_skipped_perf_tests):
3193 (PortTest.test_skipped_perf_tests.add_text_file):
3194 * Scripts/webkitpy/layout_tests/port/webkit.py:
3195 (WebKitPort._skipped_tests_for_unsupported_features):
3196 (WebKitPort._skipped_file_search_paths):
3197 (WebKitPort.skipped_layout_tests):
3199 2012-01-23 Andy Estes <aestes@apple.com>
3201 Fix the build after r105635.
3203 * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
3204 (TestWebKitAPI::TEST):
3206 2012-01-23 Xianzhu Wang <wangxianzhu@chromium.org>
3208 Basic enhancements to StringBuilder
3209 https://bugs.webkit.org/show_bug.cgi?id=67081
3211 Reviewed by Darin Adler.
3213 * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
3214 (TestWebKitAPI::TEST):
3216 2012-01-23 Mario Sanchez Prada <msanchez@igalia.com>
3218 [GTK] run-gtk-tests randomly fails while running the xprop comand
3219 https://bugs.webkit.org/show_bug.cgi?id=76817
3221 Reviewed by Gustavo Noronha Silva.
3223 No need to use xprop to remove the AT_SPI_BUS property since
3224 run-gtk-tests will always run new instances of Xvfb.
3226 * Scripts/run-gtk-tests:
3227 (TestRunner): Unskip TestWebKitAccessibility.
3228 (TestRunner.run): Uncomment lines for launching the accessibility
3229 bus and registry daemon, and remove lines for running xprop.
3231 2012-01-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
3233 [Qt] Don't warn about override and final being C++11 extensions
3235 Clang will emit a warning when these extensions are used without passing
3236 --std=c++11, but we use feature checking to decide if we have the right
3237 extensions, so we can safely ignore these warnings. The XCode and Windows
3238 project files have the same workaround.
3240 The reason for adding the flag to QMAKE_OBJECTIVE_CFLAGS as well is that
3241 we only have one extra compiler for Objective-C, which is also used for
3242 Objective-C++ sources, so we have to pass the flag, even if it doesn't
3243 make sense for Objective-C.
3245 Reviewed by Simon Hausmann.
3247 * qmake/mkspecs/features/unix/default_post.prf:
3249 2012-01-20 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
3251 [Qt] Change how build-webkit decides when to do full incremental builds
3253 Instead of relying on update-webkit (which isn't run on the bots) to
3254 decide when to do a full incremental build (make qmake), we let the
3255 build-webkit script itself check the current SVN revision against the
3256 previous build (by storing it in .webkit.config).
3258 If the two differ we assume a full incremental build is needed, since
3259 the new revisions might have introduced problematic things like new
3260 Q_OBJECT macros. If not, we assume the developer is doing changes
3261 locally, and revert to doing a plain 'make'.
3263 In addition, when the build fails in the latter case, we inform the
3264 developer of possible pitfalls and how to manually run 'make qmake'.
3268 * Scripts/update-webkit:
3269 * Scripts/webkitdirs.pm:
3270 (buildQMakeProjects):
3272 2012-01-23 Mario Sanchez Prada <msanchez@igalia.com>
3274 [GTK] run-gtk-tests randomly fails while running the xprop comand
3275 https://bugs.webkit.org/show_bug.cgi?id=76817
3277 Reviewed by Philippe Normand.
3279 Temporarily comment the lines related to launching the ATSPI bus
3280 and registry daemon, which are making the bots to fail randomly.
3282 * Scripts/run-gtk-tests:
3283 (TestRunner): Skip TestWebKitAccessibility, as it won't run
3284 properly if the ATSPI infrastructure is not properly initialized.
3285 (TestRunner.run): Comment lines related to initialization of ATSPI.
3287 2012-01-22 Ryosuke Niwa <rniwa@webkit.org>
3289 Windows python test build fix.
3291 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3292 (PerfTestsRunner.__init__):
3294 2012-01-22 Sergio Villar Senin <svillar@igalia.com>
3296 [GTK] DumpRenderTree converts "file:///" to a path differently
3297 https://bugs.webkit.org/show_bug.cgi?id=76631
3299 Reviewed by Martin Robinson.
3301 DumpRenderTree should print "/" as the last path component if the
3302 path is a lone slash instead of empty output.
3304 * DumpRenderTree/gtk/DumpRenderTree.cpp:
3305 (webViewConsoleMessage):
3307 2012-01-20 David Levin <levin@chromium.org>
3309 The leaky DC check should use adoptPtr as a signal instead of OwnPtr to get less false positives.
3310 https://bugs.webkit.org/show_bug.cgi?id=76752
3312 Reviewed by Eric Seidel.
3314 * Scripts/webkitpy/style/checkers/cpp.py:
3315 (check_for_leaky_patterns):
3316 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3317 (LeakyPatternTest.test_create_dc):
3318 (LeakyPatternTest.test_create_compatible_dc):
3320 2012-01-20 Shawn Singh <shawnsingh@chromium.org>
3322 Changed my status in commiters.py
3326 * Scripts/webkitpy/common/config/committers.py:
3328 2012-01-20 Ojan Vafai <ojan@chromium.org>
3330 run-webkit-tests --lint-test-files crawls the whole LayoutTests subtree
3331 https://bugs.webkit.org/show_bug.cgi?id=76748
3333 Reviewed by Ryosuke Niwa.
3335 It crawls the whole subtree and then doesn't use the data. Cutting this out
3336 saves 4 seconds warm and 17 seconds cold on my Mac Pro.
3338 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3341 2012-01-20 Adam Barth <abarth@webkit.org>
3343 Another tiny tweak to the garden-o-matic CSS. This makes things line
3344 up slightly nicer when there aren't any failures.
3346 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
3349 2012-01-19 Ryosuke Niwa <rniwa@webkit.org>
3351 run-perf-tests should support --test-results-server option
3352 https://bugs.webkit.org/show_bug.cgi?id=76680
3354 Reviewed by Adam Barth.
3356 Add --test-results-server, --builder-name, and --build-number options to run-perf-tests
3357 to be used by perf bots. Also refactor file_uploader as needed.
3359 * Scripts/webkitpy/common/net/file_uploader.py:
3360 (FileUploader.__init__):
3361 (FileUploader.upload_single_file):
3362 (FileUploader.upload_as_multipart_form_data):
3364 (FileUploader._upload_data):
3365 (FileUploader._upload_data.callback):
3366 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3367 (JSONResultsGeneratorBase.upload_json_files):
3368 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3370 (PerfTestsRunner._parse_args):
3371 (PerfTestsRunner.run):
3372 (PerfTestsRunner._generate_json):
3373 (PerfTestsRunner._upload_json):
3374 (PerfTestsRunner._run_tests_set):
3375 * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3377 (test_run_with_upload_json):
3378 (test_run_with_upload_json.mock_upload_json):
3380 (test_upload_json.MockFileUploader):
3381 (test_upload_json.MockFileUploader.__init__):
3382 (test_upload_json.MockFileUploader.upload_single_file):
3385 2012-01-20 Adam Barth <abarth@webkit.org>
3387 The party time image overlaps real content! This patch makes the
3388 image centered vertically.
3390 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
3391 (#onebar.partytime #summary):
3393 2012-01-19 Ojan Vafai <ojan@chromium.org>
3395 Refactor TestExpectationsParser in preparation for caching the results
3396 https://bugs.webkit.org/show_bug.cgi?id=76669
3398 Reviewed by Dimitri Glazkov.
3400 Make everything private expect for the parse method.
3401 Eventually, we'll need the expectations lines to not be modified
3402 outside of TestExpectationsParser so we can cache the results.
3403 This makes check-webkit-style of the chromium test_expectations.txt file
3404 go from ~17 seconds to ~12 seconds on my Mac Pro.
3406 This patch is just a refactor in preparation, so no new tests.
3408 * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
3409 (TestExpectationEditorTests.make_parsed_expectation_lines):
3410 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3411 (TestExpectationParser.parse):
3412 (TestExpectationParser):
3413 (TestExpectationParser._parse_line):
3414 (TestExpectationParser._tokenize):
3415 (TestExpectationParser._tokenize_list):
3416 (TestExpectationsModel._clear_expectations_for_test):
3417 (TestExpectations.__init__):
3418 (TestExpectations._add_expectations):
3419 (TestExpectations._add_skipped_tests):
3420 * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3421 (TestExpectationParserTests.test_tokenize_blank):
3422 (TestExpectationParserTests.test_tokenize_missing_colon):
3423 (TestExpectationParserTests.test_tokenize_extra_colon):
3424 (TestExpectationParserTests.test_tokenize_empty_comment):
3425 (TestExpectationParserTests.test_tokenize_comment):
3426 (TestExpectationParserTests.test_tokenize_missing_equal):
3427 (TestExpectationParserTests.test_tokenize_extra_equal):
3428 (TestExpectationParserTests.test_tokenize_valid):
3429 (TestExpectationParserTests.test_tokenize_valid_with_comment):
3430 (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
3431 (TestExpectationParserTests.test_parse_empty_string):
3432 (TestExpectationSerializerTests.assert_round_trip):
3433 (TestExpectationSerializerTests.assert_list_round_trip):
3434 * Scripts/webkitpy/tool/commands/expectations.py:
3435 (OptimizeExpectations.execute):
3436 * Scripts/webkitpy/tool/servers/gardeningserver.py:
3437 (GardeningExpectationsUpdater.update_expectations):
3439 2012-01-20 Adam Barth <abarth@webkit.org>
3441 Follow-up to previous patch: don't produce NaN when the revision number
3444 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
3445 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
3447 2012-01-20 Adam Barth <abarth@webkit.org>
3449 Garden-o-matic should tell me which revisions have been checked by all the bots
3450 https://bugs.webkit.org/show_bug.cgi?id=76722
3452 Reviewed by Dimitri Glazkov.
3454 This information helps me know when it's safe for me to roll a
3457 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
3458 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
3459 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
3461 2012-01-20 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
3463 build-webkit: Don't spit out congratulations message on Ctrl+C
3465 Reviewed by Andreas Kling.
3467 * Scripts/build-webkit:
3469 2012-01-20 Philippe Normand <pnormand@igalia.com>
3471 [GTK] Allow extra jhbuild modulesets
3472 https://bugs.webkit.org/show_bug.cgi?id=76691
3474 Reviewed by Gustavo Noronha Silva.
3476 * gtk/jhbuildrc: Extra modulesets and modules can be added in
3477 JHBuild using the WEBKIT_EXTRA_MODULESETS and WEBKIT_EXTRA_MODULES
3478 env variables respectively. Use comma-separated values. Example:
3479 WEBKIT_EXTRA_MODULES=file:///path/to/module.set,file:///other/path.
3481 2012-01-20 Mario Sanchez Prada <msanchez@igalia.com>
3483 [GTK] Expose accessibility hierarchy in WebKit2 to ATK/AT-SPI based ATs
3484 https://bugs.webkit.org/show_bug.cgi?id=72589
3486 Reviewed by Martin Robinson.
3488 Ensure the accessibility infrastructure is available when running
3489 the unit tests, otherwise WK2's accessibility tests won't work.
3491 * Scripts/run-gtk-tests:
3493 (TestRunner._lookup_atspi2_binary): New. Looks for the directory
3494 where at-spi2's stuff is located (like at-spi-bus-launcher and
3496 (TestRunner.run): Initialize the accessibility infrastructure.
3498 * gtk/generate-gtkdoc:
3499 (get_webkit2_options): Add 'WebKitWebViewBaseAccessible.*'.
3501 * gtk/jhbuild.modules: Added at-spi2-core and at-spi2-atk.
3503 2012-01-20 Hayato Ito <hayato@chromium.org>
3505 Add ShadowRoot.idl which is enabled by newly introduced SHADOW_DOM flag.
3506 https://bugs.webkit.org/show_bug.cgi?id=76353
3508 Reviewed by Hajime Morita.
3510 Add ShadowRoot.idl, which is enabled only on chromium port since this is
3511 under development feature.
3512 ShadowRoot.idl contains minimum API so that we can test it.
3513 Other APIs should be added on other changes so that we can isolate issues.
3515 * DumpRenderTree/chromium/TestShell.cpp:
3516 (TestShell::TestShell):
3518 2012-01-20 Mario Sanchez Prada <msanchez@igalia.com>
3520 [GTK] GTK's DRT not to log events for already defunct objects
3521 https://bugs.webkit.org/show_bug.cgi?id=76620
3523 Reviewed by Martin Robinson.
3525 Do not log 'state-change:defunct' events.
3527 * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
3528 (printAccessibilityEvent): Early return if a
3529 'state-change:defunct' signal is passed.
3530 (axObjectEventListener): Pass the signal name and value in
3531 separate parameters to printAccessibilityEvent.
3533 2012-01-19 Gustavo Noronha Silva <gns@gnome.org>
3535 Unreviewed build fix. Wrong variable being used as the cwd for git
3536 remote update command.
3538 * gtk/run-with-jhbuild:
3541 2012-01-19 Gustavo Noronha Silva <gns@gnome.org>
3543 [GTK] ensure the jhbuild used by webkit is as up-to-date as needed
3544 https://bugs.webkit.org/show_bug.cgi?id=76585
3546 Reviewed by Martin Robinson.
3548 This allows us to specify a minimum version of jhbuild required,
3549 while also providing stability against changes done to the master
3550 branch, by letting us choose what is the exact version that will
3553 * gtk/run-with-jhbuild: refactored for more hackability and easier
3555 (jhbuild_installed): checks whether jhbuild is installed
3556 (jhbuild_cloned): checks whether jhbuild has been cloned
3557 (jhbuild_at_expected_revision): checks whether jhbuild is at the
3559 (update_jhbuild): brings jhbuild to the expected revision
3560 (clone_jhbuild): clones jhbuild
3561 (install_jhbuild): build and installs jhbuild
3562 (update_webkitgtk_libs): runs update-webkitgtk-libs
3563 (ensure_jhbuild): high-level logic to decide whether and which of
3564 the steps above are executed
3566 2012-01-19 Alexey Proskuryakov <ap@apple.com>
3568 [WK2] DumpRenderTree converts "file:///" to a path differently
3569 https://bugs.webkit.org/show_bug.cgi?id=76653
3571 Reviewed by John Sullivan.
3573 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::lastFileURLPathComponent):
3574 Do print a slash if there are no path components.
3576 2012-01-19 Eric Seidel <eric@webkit.org>
3578 webkit-patch cannot rollout patches without changelog/bug number
3579 https://bugs.webkit.org/show_bug.cgi?id=75962
3581 Reviewed by Adam Barth.
3583 * Scripts/webkitpy/tool/commands/download.py:
3584 (AbstractRolloutPrepCommand._prepare_state):
3585 * Scripts/webkitpy/tool/commands/download_unittest.py:
3586 (AbstractRolloutPrepCommandTest.test_prepare_state):
3588 2012-01-19 Alexey Proskuryakov <ap@apple.com>
3590 [WK2] fast/url/degenerate-file-base.html fails
3591 https://bugs.webkit.org/show_bug.cgi?id=76619
3593 Reviewed by Adam Roben.
3595 A URL generated form local path for loading had an extra slash, making document.URL
3596 incorrect in all WebKit2 tests (file://localhost//path/to/test.html).
3598 * WebKitTestRunner/TestInvocation.cpp: (WTR::createWKURL):
3600 2012-01-18 Ojan Vafai <ojan@chromium.org>
3602 check-webkit-style of the chromium test_expectations.txt file doesn't test all chromium ports
3603 https://bugs.webkit.org/show_bug.cgi?id=76510
3605 Reviewed by Adam Barth.
3607 Unlike other style rules, if you get the syntax of the test_expectations.txt
3608 file wrong, the layout tests won't run. Also, this check is simple and only
3609 slows down committing if you actually modify one of the test_expectations.txt files.
3611 * Scripts/webkitpy/style/checkers/test_expectations.py:
3612 (TestExpectationsChecker.check_test_expectations):
3613 (TestExpectationsChecker.check):
3614 * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3615 (TestExpectationsTestCase.test_check_covers_all_configurations):
3616 (TestExpectationsTestCase.test_check_covers_all_configurations.mock_check_test_expectations):
3617 (TestExpectationsTestCase):
3618 (assert_lines_lint):
3620 2012-01-19 Ryosuke Niwa <rniwa@webkit.org>
3622 Build fix. Revert an unintentional change to WebKitDriver in r105443.
3624 * Scripts/webkitpy/layout_tests/port/driver.py:
3625 (DriverProxy.__init__):
3627 2012-01-19 Dirk Pranke <dpranke@chromium.org>
3629 remove the duplicated build rules from WebKit.gyp, Tools.gyp
3630 https://bugs.webkit.org/show_bug.cgi?id=73384
3632 Reviewed by Tony Chang.
3634 This patch removes the no-longer-necessary conditional logic for
3635 build_webkit_exes_from_webkit_gyp; we now always build the exes
3636 from their own dedicated gyp files.
3638 * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3640 2012-01-19 Alexey Proskuryakov <ap@apple.com>
3642 make-new-script-test should work with HTTP tests
3643 https://bugs.webkit.org/show_bug.cgi?id=76603
3645 Reviewed by Adam Roben.
3647 * Scripts/make-new-script-test:
3648 (makePathToSharedSources): Renamed from makeTestRelativePathToSharedSources(), since it
3649 now also creates absolute paths for HTTP.
3651 2012-01-19 Ryosuke Niwa <rniwa@webkit.org>
3653 Some perf tests time out when ran by run-perf-tests
3654 https://bugs.webkit.org/show_bug.cgi?id=76612
3656 Reviewed by Dirk Pranke and Eric Seidel.
3658 Always pass --no-timeout to DumpRenderTree from run-perf-tests.
3659 Otherwise some tests such as Parser/xml-parser.html will timeout.
3661 --no-timeout option is currently supported by Chromium and Mac ports.
3663 * Scripts/webkitpy/layout_tests/port/base.py:
3664 (Port.to.create_driver):
3665 * Scripts/webkitpy/layout_tests/port/chromium.py:
3666 (ChromiumDriver.__init__):
3667 (ChromiumDriver._wrapper_options):
3668 * Scripts/webkitpy/layout_tests/port/driver.py:
3670 (DriverProxy.__init__):
3671 * Scripts/webkitpy/layout_tests/port/webkit.py:
3672 (WebKitDriver.__init__):
3673 (WebKitDriver.cmd_line):
3674 * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: