Tools/ChangeLog

   1 2015-10-20  Aakash Jain  <aakash_jain@apple.com>
   2
   3         run-webkit-tests does not copy all crash logs for layout test failures on iOS
   4         https://bugs.webkit.org/show_bug.cgi?id=150056
   5         <rdar://problem/9280656>
   6
   7         Reviewed by Alexey Proskuryakov.
   8
   9         * Scripts/webkitpy/common/system/crashlogs.py:
  10         (CrashLogs.find_all_logs): Generic method to find all crash logs.
  11         (CrashLogs._find_all_logs_darwin): Darwin based method to find all crash logs.
  12         It iterates through log directory and returns all the logs based on timestamp.
  13         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
  14         (CrashLogsTest.create_crash_logs_darwin): Creates sample crash logs and verify them.
  15         (CrashLogsTest.test_find_all_log_darwin): Testcase for above find_all_logs method
  16         (CrashLogsTest.test_find_log_darwin): Restructured to share code with other methods.
  17         * Scripts/webkitpy/layout_tests/controllers/manager.py:
  18         (Manager.run): Modified start_time to start counting before simulator launch
  19         so that we can capture crashes during simualator launch.
  20         (Manager._look_for_new_crash_logs): Browse through list of crashes and append
  21         any test which is not already marked as CRASH to the run_results.
  22         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  23         (TestExpectationsModel.get_expectations_string): return PASS in case there
  24         are no expectations defined for this test.
  25         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
  26         (summarize_results): Add other_crashes in a separte category in full_results.json.
  27         * Scripts/webkitpy/port/ios.py:
  28         (IOSSimulatorPort._merge_crash_logs): Merge unique crash logs from two dictionaries.
  29         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Get the crash logs
  30         from the log directory.
  31         (IOSSimulatorPort.look_for_new_crash_logs): Uses above method to get crash
  32         logs from log directory and merge them with the list of already crashed tests.
  33
  34 2015-10-20  Dana Burkart  <dburkart@apple.com>
  35
  36         Fix the build
  37
  38         Unreviewed.
  39
  40         My previous patch was missing a necessary space character.
  41
  42         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
  43
  44 2015-10-20  Dana Burkart  <dburkart@apple.com>
  45
  46         svn-apply fails to apply binary diffs in some cases
  47         https://bugs.webkit.org/show_bug.cgi?id=64647
  48
  49         Reviewed by Daniel Bates.
  50
  51         * Scripts/VCSUtils.pm:
  52         (decodeGitBinaryPatchDeltaSize): Modified.
  53         We need to handle the case where the binary diff is the last in the patch; so we match on "-- \n" or "\Z".
  54         * Tools/Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl: Added.
  55
  56 2015-10-20  Alexey Proskuryakov  <ap@apple.com>
  57
  58         Mac Debug EWS never finishes when there are failures
  59         https://bugs.webkit.org/show_bug.cgi?id=150334
  60
  61         Reviewed by Daniel Bates.
  62
  63         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  64         * Scripts/webkitpy/tool/commands/queues.py:
  65
  66 2015-10-20  Philippe Normand  <pnormand@igalia.com>
  67
  68         [GTK] Enable OpenWebRTC test video/audio sources in tests
  69
  70         This is needed because we can't expect the buildbots to have
  71         webcam/mic devices plugged in.
  72
  73         Rubber-stamped by Carlos Garcia Campos.
  74
  75         * Scripts/run-gtk-tests:
  76         (TestRunner._setup_testing_environment):
  77         * Scripts/webkitpy/port/gtk.py:
  78         (GtkPort.setup_environ_for_server):
  79
  80 2015-10-20  Yoav Weiss  <yoav@yoav.ws>
  81
  82         Rename the PICTURE_SIZES flag to CURRENTSRC
  83         https://bugs.webkit.org/show_bug.cgi?id=150275
  84
  85         Reviewed by Dean Jackson.
  86
  87         * Scripts/webkitperl/FeatureList.pm:
  88
  89 2015-10-19  Hunseop Jeong  <hs85.jeong@samsung.com>
  90
  91         Unreviewed, add myself to the committers list.
  92
  93         * Scripts/webkitpy/common/config/contributors.json:
  94
  95 2015-10-19  Alexey Proskuryakov  <ap@apple.com>
  96
  97         Add new EWS queues to bot watcher's dashboard
  98         https://bugs.webkit.org/show_bug.cgi?id=150297
  99
 100         Reviewed by Darin Adler.
 101
 102         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
 103         (BubbleQueueServer):
 104
 105 2015-10-19  ChangSeok Oh  <changseok.oh@collabora.com>
 106
 107         REGRESSION(r190262): User media unit test failures after r190262
 108         https://bugs.webkit.org/show_bug.cgi?id=149580
 109
 110         Reviewed by Carlos Garcia Campos.
 111
 112         The test failures on usermedia-permission-requests and WebKit2.UserMediaBasic have gone.
 113         So we do not need to skip them anymore.
 114
 115         * Scripts/run-gtk-tests:
 116         (TestRunner): Deleted.
 117
 118 2015-10-19  Csaba Osztrogonác  <ossy@webkit.org>
 119
 120         Add historical addresses to contributors.json
 121         https://bugs.webkit.org/show_bug.cgi?id=150227
 122
 123         Reviewed by Darin Adler.
 124
 125         * Scripts/webkitpy/common/config/contributors.json:
 126
 127 2015-10-18  Sungmann Cho  <sungmann.cho@navercorp.com>
 128
 129         [Win] Change the DLL name in MiniBrowserLib.vcxproj to match webkit.org/b/150124.
 130         https://bugs.webkit.org/show_bug.cgi?id=150307
 131
 132         Reviewed by Brent Fulgham.
 133
 134         The DLL build rules have been changed to generate "{Name}Lib.DLL",
 135         but these changes have not yet been applied to the Visual Studio builds.
 136
 137         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj:
 138
 139 2015-10-16  Andreas Kling  <akling@apple.com>
 140
 141         [EFL, AppleWin] WTF.ConcatenateCharacterArrayAndEmptyString API test failed
 142         <https://webkit.org/b/150153>
 143
 144         Unreviewed.
 145
 146         Just use simple arrays of LChar and UChar for this test instead of creating String
 147         objects and then getting the characters8()/characters16() from them, since that
 148         doesn't guarantee null-termination (the bug.)
 149
 150         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
 151         (TestWebKitAPI::TEST):
 152         (TestWebKitAPI::build): Deleted.
 153
 154 2015-10-16  Tim Horton  <timothy_horton@apple.com>
 155
 156         WebKit2.AutoLayoutIntegration API test is failing on some of the bots
 157         https://bugs.webkit.org/show_bug.cgi?id=150255
 158
 159         Reviewed by Simon Fraser.
 160
 161         * Scripts/run-api-tests:
 162         (runTest):
 163         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
 164         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:]):
 165         (-[AutoLayoutWKWebView layoutAtMinimumWidth:andExpectContentSizeChange:]):
 166         (-[AutoLayoutWKWebView load:expectingContentSize:]): Deleted.
 167         (-[AutoLayoutWKWebView expectContentSizeChange:]): Deleted.
 168         Don't set the layout size until after the load finishes and we're waiting
 169         for the reply, so that there is no race between the new size coming in
 170         and us waiting for it.
 171
 172 2015-10-16  Anders Carlsson  <andersca@apple.com>
 173
 174         WebEditingDelegate should be a formal protocol
 175         https://bugs.webkit.org/show_bug.cgi?id=150254
 176         <rdar://problem/23149847>
 177
 178         Reviewed by Dan Bernstein.
 179
 180         * DumpRenderTree/mac/EditingDelegate.h:
 181         Conform to the WebEditingDelegate protocol.
 182
 183 2015-10-16  Tim Horton  <timothy_horton@apple.com>
 184
 185         Hook up autolayout intrinsic sizing for WKWebView
 186         https://bugs.webkit.org/show_bug.cgi?id=150219
 187         <rdar://problem/20016905>
 188
 189         Reviewed by Simon Fraser.
 190
 191         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 192         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm: Added.
 193         (-[AutoLayoutNavigationDelegate webView:didFinishNavigation:]):
 194         (-[AutoLayoutWKWebView load:expectingContentSize:]):
 195         (-[AutoLayoutWKWebView expectContentSizeChange:]):
 196         (-[AutoLayoutWKWebView invalidateIntrinsicContentSize]):
 197         (TEST):
 198         Add a variety of tests, including one which catches the bug that
 199         the WebCore part of this patch fixes.
 200
 201 2015-10-15  Csaba Osztrogonác  <ossy@webkit.org>
 202
 203         Update the help message of --system-malloc
 204         https://bugs.webkit.org/show_bug.cgi?id=150169
 205
 206         Reviewed by Geoffrey Garen.
 207
 208         * Scripts/webkitperl/FeatureList.pm:
 209
 210 2015-10-15  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 211
 212         Update ImportExpectations according currently imported wpt tests
 213         https://bugs.webkit.org/show_bug.cgi?id=150158
 214
 215         Reviewed by Chris Dumez.
 216
 217         * Scripts/webkitpy/w3c/test_downloader.py:
 218         (TestDownloader.copy_tests): ensuring that directories marked as [ Skip ] are not copied.
 219
 220 2015-10-15  Eunmi Lee  <eunmi15.lee@samsung.com>
 221
 222         Unreviewed, Update my email address.
 223
 224         * Scripts/webkitpy/common/config/contributors.json:
 225
 226 2015-10-15  Carlos Garcia Campos  <cgarcia@igalia.com>
 227
 228         [GTK] Test WebKit2.RestoreSessionStateContainingFormData fails
 229         https://bugs.webkit.org/show_bug.cgi?id=84960
 230
 231         Reviewed by Žan Doberšek.
 232
 233         * Scripts/run-gtk-tests:
 234         (TestRunner): Unskip tests using SessionState.
 235         * TestWebKitAPI/PlatformGTK.cmake: Add
 236         WKPageCopySessionStateWithFiltering test.
 237
 238 2015-10-14  Carlos Garcia Campos  <cgarcia@igalia.com>
 239
 240         [GTK] Missing return value on TestWebExtensions.cpp:193
 241         https://bugs.webkit.org/show_bug.cgi?id=149755
 242
 243         Unreviewed. Add missing return value.
 244
 245         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
 246         (permissionRequestCallback):
 247
 248 2015-10-14  Andy Estes  <aestes@apple.com>
 249
 250         [iOS] build-dumprendertree does not build ImageDiff
 251         https://bugs.webkit.org/show_bug.cgi?id=150152
 252
 253         Reviewed by Tim Horton.
 254
 255         run-webkit-tests attempts to build the tools it requires by calling build-dumprendertree and build-webkittestrunner.
 256         On iOS, build-dumprendertree builds the DumpRenderTree.app target, which does not contain the ImageDiff target
 257         as a dependent. If you haven't built ImageDiff by other means (say, because you built the 'All Source' scheme in
 258         WebKit.xcworkspace), tests that rely on image diffing won't work properly.
 259
 260         There's actually no reason to build the DumpRenderTree.app target on iOS; the default aggregate target works
 261         fine on that platform, and results in ImageDiff being built.
 262
 263         * Scripts/build-dumprendertree:
 264
 265 2015-10-14  Brent Fulgham  <bfulgham@apple.com>
 266
 267         [Win] Enforce launcher/library naming scheme
 268         https://bugs.webkit.org/show_bug.cgi?id=150124
 269
 270         Reviewed by Alex Christensen.
 271
 272         * DumpRenderTree/PlatformWin.cmake: Use 'Lib' suffix for DLLs.
 273         * MiniBrowser/win/CMakeLists.txt: Ditto.
 274         * TestWebKitAPI/PlatformWin.cmake: Ditto.
 275         * win/DLLLauncher/DLLLauncherMain.cpp:
 276         (wWinMain): Look for a DLL named {name}Lib.dll, rather than the
 277         original {name}.dll.
 278
 279 2015-10-14  Andreas Kling  <akling@apple.com>
 280
 281         REGRESSION(r190882): Concatenating a character array and an empty string is broken.
 282         <https://webkit.org/b/150135>
 283
 284         Reviewed by Geoffrey Garen.
 285
 286         Add a new WTF API test that covers this issue.
 287
 288         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
 289         (TestWebKitAPI::build):
 290         (TestWebKitAPI::TEST):
 291
 292 2015-10-14  Alex Christensen  <achristensen@webkit.org>
 293
 294         Add SPI for reloading without content blockers
 295         https://bugs.webkit.org/show_bug.cgi?id=150058
 296         rdar://problem/22742222
 297
 298         Reviewed by Sam Weinig.
 299
 300         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
 301         (WTR::TestController::cocoaResetStateToConsistentValues):
 302         * WebKitTestRunner/mac/TestControllerMac.mm:
 303         (WTR::TestController::platformConfigureViewForTest):
 304
 305 2015-10-14  Mark Lam  <mark.lam@apple.com>
 306
 307         Rename some JSC option names to be more uniform.
 308         https://bugs.webkit.org/show_bug.cgi?id=150127
 309
 310         Reviewed by Geoffrey Garen.
 311
 312         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
 313         * Scripts/run-jsc-stress-tests:
 314
 315 2015-10-14  Anders Carlsson  <andersca@apple.com>
 316
 317         Change the bundle app cache APIs to take a page
 318         https://bugs.webkit.org/show_bug.cgi?id=150123
 319
 320         Reviewed by Sam Weinig.
 321
 322         Update APIs.
 323
 324         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 325         (WTR::InjectedBundle::beginTesting):
 326         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 327         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
 328         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
 329         (WTR::TestRunner::clearAllApplicationCaches):
 330         (WTR::TestRunner::clearApplicationCacheForOrigin):
 331         (WTR::TestRunner::setAppCacheMaximumSize):
 332         (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
 333         (WTR::TestRunner::originsWithApplicationCache):
 334
 335 2015-10-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 336
 337         Update web-platform-tests tools to the latest revision
 338         https://bugs.webkit.org/show_bug.cgi?id=149645
 339
 340         Reviewed by Darin Adler.
 341
 342         Disabling git submodules information conversion to json install file for web-platform-tests.
 343         Disabling related python unit tests.
 344         The tools submodules contain submodules and the conversion tool does not support that yet.
 345
 346         Updating wpt launcher script to aling it with web-platform-test main script.
 347
 348         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
 349         (main):
 350         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
 351         (TestWebPlatformTestServer.test_corrupted_subserver_files): Deleted.
 352         * Scripts/webkitpy/w3c/test_importer_unittest.py:
 353         (TestImporterTest.test_submodules_generation):
 354
 355 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
 356
 357         More debug queue build fixing.
 358
 359         Preserve the build style in one more place. Changed mock build_style from "both"
 360         to "release", as we don't support testing both debug and release.
 361
 362         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
 363         (MockCommitQueue.archive_last_test_results):
 364         (MockCommitQueue):
 365         (MockCommitQueue.build_style):
 366         (MockCommitQueue.did_pass_testing_ews):
 367         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
 368         (PatchAnalysisTask._test):
 369         (PatchAnalysisTask._build_and_test_without_patch):
 370         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
 371         (EarlyWarningSystemTest._default_expected_logs):
 372         * Scripts/webkitpy/tool/commands/queues_unittest.py:
 373
 374 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
 375
 376         More debug queue build fixing.
 377
 378         Add build_style argument to derived classes as well.
 379
 380         * Scripts/webkitpy/common/config/ports.py:
 381         (MacPort):
 382         (MacPort.run_webkit_tests_command):
 383         (WinPort.run_bindings_tests_command):
 384         (WinPort):
 385         (WinPort.run_webkit_tests_command):
 386         (GtkWK2Port.build_webkit_command):
 387         (GtkWK2Port):
 388         (GtkWK2Port.run_webkit_tests_command):
 389
 390 2015-10-13  Myles C. Maxfield  <mmaxfield@apple.com>
 391
 392         [iOS] Build fix
 393
 394         Unreviewed.
 395
 396         Mach-O section names are limited to 16 characters.
 397
 398         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
 399         * DumpRenderTree/mac/DumpRenderTree.mm:
 400         (activateFontsIOS):
 401
 402 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
 403
 404         Build fix for mac-debug EWS queue.
 405
 406         Unreviewed.
 407
 408         Pass --debug to run-webkit-tests.
 409
 410         While at it, removed unsupported run_webkit_unit_tests_command. All the test steps
 411         will need to be substantially modified to work in EWS, so the dummy implementation
 412         was not helpful.
 413
 414         * Scripts/webkitpy/common/config/ports.py:
 415         (DeprecatedPort.run_javascriptcore_tests_command):
 416         (DeprecatedPort):
 417         (DeprecatedPort.run_webkit_tests_command):
 418         (DeprecatedPort.run_python_unittests_command):
 419         (DeprecatedPort.run_webkit_unit_tests_command): Deleted.
 420         * Scripts/webkitpy/common/config/ports_mock.py:
 421         (MockPort.run_javascriptcore_tests_command):
 422         (MockPort):
 423         (MockPort.run_webkit_tests_command):
 424         (MockPort.run_bindings_tests_command):
 425         (MockPort.run_webkit_unit_tests_command): Deleted.
 426         * Scripts/webkitpy/tool/commands/download_unittest.py:
 427         * Scripts/webkitpy/tool/steps/runtests.py:
 428         (RunTests.run):
 429         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
 430         (RunTestsTest.test_webkit_run_unit_tests):
 431         * Scripts/webkitpy/tool/steps/steps_unittest.py:
 432         (StepsTest.test_runtests_args):
 433
 434 2015-10-13  Brent Fulgham  <bfulgham@apple.com>
 435
 436         [Win] Generate Crash Traces
 437         https://bugs.webkit.org/show_bug.cgi?id=150103
 438
 439         Reviewed by Daniel Bates.
 440
 441         We were using an exception filter to try to emit "#CRASHED" to stderr
 442         when a test program crashed. However, the modern Python implementation
 443         seems capable of recognizing crashes on its own. Furthermore, registering
 444         the exception handler was preventing the JIT debugger (NTSD) from
 445         automatically attaching to the crashing program, so we were not getting
 446         crash traces.
 447
 448         * DumpRenderTree/win/DumpRenderTree.cpp:
 449         (main): Don't register an exception filter.
 450         (exceptionFilter): Deleted.
 451         * Scripts/webkitpy/common/system/crashlogs.py:
 452         (CrashLogs): Add another regular expression to handle a second crash trace
 453         syntax I encountered during testing.
 454         (CrashLogs._find_newest_log_win): If the old regular expression doesn't match,
 455         try the new one. The PID found by the new expression is in hexadecimal, so
 456         convert it to an integer before returning it.
 457         * Scripts/webkitpy/port/driver.py:
 458         (Driver._check_for_driver_crash_or_unresponsiveness): Windows was not recognizing
 459         the "#CRASHED" state because it was appending '\r\n', rather than just '\r'. Instead,
 460         check for "#CRASHED" after stripping off the EOL characters.
 461         * Scripts/webkitpy/port/win.py:
 462         (WinPort.setup_crash_log_saving): Put back the '-e %ld' flag in the debugger
 463         invocation. This is apparently used to signal an event when the debugger is finished.
 464
 465 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
 466
 467         Mac Debug and 32-bit queues should be separate
 468         https://bugs.webkit.org/show_bug.cgi?id=150092
 469
 470         Reviewed by Lucas Forschler.
 471
 472         * QueueStatusServer/config/queues.py:
 473         * QueueStatusServer/model/queues.py:
 474         (Queue._capitalize_after_dash):
 475         (Queue._caplitalize_after_dash): Deleted.
 476         * Scripts/webkitpy/common/config/ews.json:
 477
 478 2015-10-13  Sergio Villar Senin  <svillar@igalia.com>
 479
 480         [GTK] Fix build for ENABLE_TOUCH_EVENTS=OFF
 481         https://bugs.webkit.org/show_bug.cgi?id=150085
 482
 483         Reviewed by Carlos Garcia Campos.
 484
 485         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
 486
 487 2015-10-13  Sebastian Dröge  <sebastian@centricular.com>
 488
 489         Unreviewed, add myself to the committers list.
 490
 491         * Scripts/webkitpy/common/config/contributors.json:
 492
 493 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
 494
 495         Update bot watcher's dashboard to reflect that EWS is on iOS 9 now
 496         https://bugs.webkit.org/show_bug.cgi?id=149983
 497
 498         Reviewed by Dan Bates.
 499
 500         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
 501         (BubbleQueueServer):
 502         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
 503
 504 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
 505
 506         Fix webkitpy tests after r190922.
 507
 508         * Scripts/webkitpy/common/config/ews.json:
 509         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
 510         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
 511
 512 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
 513
 514         Add a Mac debug EWS queue
 515         https://bugs.webkit.org/show_bug.cgi?id=150069
 516
 517         Reviewed by Geoffrey Garen.
 518
 519         * QueueStatusServer/config/queues.py:
 520         * Scripts/webkitpy/common/config/ews.json:
 521         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
 522         (AbstractEarlyWarningSystem):
 523         (AbstractEarlyWarningSystem.archive_last_test_results):
 524         (AbstractEarlyWarningSystem.build_style):
 525         (AbstractEarlyWarningSystem.refetch_patch):
 526         (AbstractEarlyWarningSystem.load_ews_classes):
 527
 528 2015-10-12  Mario Sanchez Prada  <mario@endlessm.com>
 529
 530         [GTK] Update jhbuild's version of harfbuzz
 531         https://bugs.webkit.org/show_bug.cgi?id=149749
 532
 533         Reviewed by Martin Robinson.
 534
 535         Update harfbuzz to 0.9.35, following the lead of Debian Stable.
 536
 537         * gtk/jhbuild.modules: Updated details for harfbuzz.
 538
 539 2015-10-12  Mario Sanchez Prada  <mario@endlessm.com>
 540
 541         [GTK] Media tests crashing with gst-plugins-bad 1.4.4 and cpp 5.2
 542         https://bugs.webkit.org/show_bug.cgi?id=150026
 543
 544         Reviewed by Philippe Normand.
 545
 546         Backport upstream patch from gst-plugins-bad so that the right version
 547         of FAAD2 can be found with newer versions of cpp, so that gst-plugins-bad
 548         gets compiled properly, avoiding crashes on runtime while running tests.
 549
 550         * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Added.
 551         * gtk/jhbuild.modules: Referenced the newly added patch for gst-plugins-bad.
 552
 553 2015-10-11  Myles C. Maxfield  <mmaxfield@apple.com>
 554
 555         Test font-variant-* and font-feature-settings with mocked preinstalled fonts
 556         https://bugs.webkit.org/show_bug.cgi?id=149777
 557
 558         Reviewed by Simon Fraser.
 559
 560         Include FontWithFeatures in DumpRenderTree and WebKitTestRunner. Add it
 561         to the list of tests to preinstall at startup time.
 562
 563         Also, update the generation of the 'name' table in the FontWithFeatures font.
 564
 565         * DumpRenderTree/mac/DumpRenderTree.mm:
 566         (allowedFontFamilySet):
 567         (activateTestingFonts):
 568         (activateFontsIOS):
 569         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
 570         (Generator::generate):
 571         (Generator::appendCFFTable):
 572         (Generator::appendNameSubtable):
 573         (Generator::appendNAMETable):
 574         * FontWithFeatures/FontWithFeatures/main.cpp:
 575         (main):
 576         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
 577         (WTR::allowedFontFamilySet):
 578         (WTR::activateFonts):
 579         * WebKitTestRunner/mac/TestControllerMac.mm:
 580         (WTR::allowedFontFamilySet):
 581
 582 2015-10-11  Jinyoung Hur  <hur.ims@navercorp.com>
 583
 584         Unreviewed. Add Jinyoung Hur as a committer.
 585
 586         * Scripts/webkitpy/common/config/contributors.json:
 587
 588 2015-10-10  Dan Bernstein  <mitz@apple.com>
 589
 590         [iOS] Remove unnecessary iOS version checks
 591         https://bugs.webkit.org/show_bug.cgi?id=150002
 592
 593         Reviewed by Alexey Proskuryakov.
 594
 595         * WebKitTestRunner/ios/HIDEventGenerator.mm:
 596         (-[HIDEventGenerator _createIOHIDEventType:]):
 597         (-[HIDEventGenerator _sendHIDEvent:]):
 598         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
 599         * WebKitTestRunner/ios/UIKitSPI.h:
 600
 601 2015-10-09  Myles C. Maxfield  <mmaxfield@apple.com>
 602
 603         Unreviewed, rolling out r190689
 604         https://bugs.webkit.org/show_bug.cgi?id=149992
 605
 606         Fixed in other repository.
 607
 608         Reverted changesets:
 609
 610         "Unreviewed, rolling out r190572, r190593, r190594, and r190639."
 611         https://bugs.webkit.org/show_bug.cgi?id=149897
 612
 613 2015-10-09  Brian Burg  <bburg@apple.com>
 614
 615         Teach webkitperl how to figure out IOS versions from the SDK
 616         https://bugs.webkit.org/show_bug.cgi?id=149963
 617
 618         Reviewed by Daniel Bates.
 619
 620         It should be easier to check the major and minor version of IOS SDKs.
 621
 622         * Scripts/copy-webkitlibraries-to-product-directory: use iosVersion().
 623         * Scripts/webkitdirs.pm:
 624         (splitVersionString): Added.
 625         (determineOSXVersion): Use splitVersionString.
 626         (determineIOSVersion): Added. Look at the SDK version and make a tuple.
 627         (iosVersion): Added.
 628
 629 2015-10-09  Simon Fraser  <simon.fraser@apple.com>
 630
 631         [iOS WK2] Fix some leaks in TestRunnerWKWebView and UIScriptContext
 632         https://bugs.webkit.org/show_bug.cgi?id=149960
 633
 634         Reviewed by Tim Horton.
 635
 636         Use adoptWK(), and null out some members (file is not using ARC).
 637
 638         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
 639         (UIScriptContext::uiScriptComplete):
 640         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
 641         (-[TestRunnerWKWebView dealloc]):
 642
 643 2015-10-09  Csaba Osztrogonác  <ossy@webkit.org>
 644
 645         Remove ENABLE_SUID_SANDBOX_LINUX cruft
 646         https://bugs.webkit.org/show_bug.cgi?id=149954
 647
 648         Reviewed by Darin Adler.
 649
 650         * Scripts/webkitperl/FeatureList.pm:
 651
 652 2015-10-09  Daniel Bates  <dabates@apple.com>
 653
 654         Make iOS builders generate debug information in a separate dSYM file
 655         https://bugs.webkit.org/show_bug.cgi?id=149696
 656
 657         Reviewed by Darin Adler.
 658
 659         Similar to the Mac builders, the iOS builders should write debug information
 660         into a separate dSYM file instead of including such information in the binary
 661         itself (default Xcode behavior)
 662
 663         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 664         (CompileWebKit.start):
 665
 666 2015-10-09  Csaba Osztrogonác  <ossy@webkit.org>
 667
 668         Fix webkitpy tests after r190779
 669         https://bugs.webkit.org/show_bug.cgi?id=149949
 670
 671         Reviewed by Ryosuke Niwa.
 672
 673         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
 674         (BenchmarkResults.format):
 675         (BenchmarkResults._format_values):
 676
 677 2015-10-08  Dewei Zhu  <dewei_zhu@apple.com>
 678
 679         Extend run-benchmark script to support human-readable results conversion.
 680         https://bugs.webkit.org/show_bug.cgi?id=149944
 681
 682         Reviewed by Ryosuke Niwa.
 683
 684         Add '--read-results-json' and '--no-adjust-unit' options.
 685         '--read-results-json' option converts result file to human readable format.
 686         '--no-adjust-unit' option skips scientific notation convertion.
 687         '--platform' defaults to 'osx' and '--browser' defaults to 'safari'.
 688
 689         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
 690         (BenchmarkResults.format):
 691         (BenchmarkResults._format_tests):
 692         (BenchmarkResults._format_values):
 693         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
 694         (BenchmarkRunner.__init__):
 695         (BenchmarkRunner._run_benchmark):
 696         (BenchmarkRunner._dump):
 697         (BenchmarkRunner.show_results):
 698         (BenchmarkRunner._show_results): Deleted.
 699         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
 700         (parse_args):
 701         (start):
 702
 703 2015-10-08  Daniel Bates  <dabates@apple.com>
 704
 705         Add iOS 9 device builder to WebKit Bot Watcher's Dashboard
 706         https://bugs.webkit.org/show_bug.cgi?id=149945
 707
 708         Reviewed by Dan Bernstein.
 709
 710         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9.png: Added.
 711         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9@2x.png: Added.
 712         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
 713         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
 714         (WebKitBuildbot):
 715         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
 716         (table.queue-grid tr.platform.ios-9 img.logo):
 717
 718 2015-10-08  Daniel Bates  <dabates@apple.com>
 719
 720         Teach build-webkit to install LLVM binaries for iOS when building for device with the public iOS SDK
 721         https://bugs.webkit.org/show_bug.cgi?id=149943
 722
 723         Reviewed by Dan Bernstein.
 724
 725         Following the addition of the LLVM binaries for iOS in changeset r190759 (bug #149913) we should
 726         teach build-webkit to install them when building for iOS device using the public iOS SDK.
 727
 728         * Scripts/build-webkit:
 729
 730 2015-10-08  Daniel Bates  <dabates@apple.com>
 731
 732         Add LLVM binaries for iOS 9 device
 733         https://bugs.webkit.org/show_bug.cgi?id=149913
 734
 735         Reviewed by Filip Pizlo.
 736
 737         Implement support for building LLVM for ARM64-based iOS devices.
 738
 739         * Scripts/build-jsc: Enable the FTL when building for Mac or iOS device.
 740         * Scripts/copy-webkitlibraries-to-product-directory: Move logic to clean
 741         an existing build earlier in the file such that remove previously built
 742         libraries before building/copying new ones (if applicable).
 743         (fileContains): Moved function outside of if-block.
 744         (isContentOfFileEqualToString): Renamed; formerly named fileContentsEquals().
 745         (buildLLVM): Added. Extracted machinery to build LLVM into this function and
 746         added logic to build LLVM for ARM64-based iOS devices.
 747         (symlinkLLVMLibrariesIfNeeded): Added. Extracted machinery to symlink the built
 748         LLVM into the WebKitBuild directory.
 749
 750 2015-10-08  Alexey Proskuryakov  <ap@apple.com>
 751
 752         Crash-only queues on bot watcher's dashboard should not have non-crashing tests in popovers
 753         https://bugs.webkit.org/show_bug.cgi?id=149848
 754
 755         Reviewed by Darin Adler.
 756
 757         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
 758
 759 2015-10-07  Brent Fulgham  <bfulgham@apple.com>
 760
 761         [Win] Support 64-bit Build and Testing
 762         https://bugs.webkit.org/show_bug.cgi?id=149904
 763
 764         Reviewed by Daniel Bates.
 765
 766         Extend our existing scripts to support 64-bit build and test operations on
 767         Windows.
 768
 769         * Scripts/build-dumprendertree: We don't need to build DRT on its own;
 770         Windows always builds the whole stack.
 771         * Scripts/webkit-build-directory: Add an option to return the location of
 772         the executable files produced by a specific configuration. This change is
 773         actually useful for Gtk and EFL, too.
 774         * Scripts/webkitdirs.pm:
 775         (executableProductDir): Added. This function appends the proper binary
 776         path to the productDir. This is useful for Windows, Gtk, and EFL ports.
 777         (jscProductDir): Use the new 'executableProductDir' method.
 778         (setPathForRunningWebKitApp): Ditto.
 779         (runSafari): Ditto.
 780         (runMiniBrowser): Ditto.
 781         * Scripts/webkitpy/port/factory.py:
 782         (configuration_options): Add a 64-bit option, used on Windows to specify
 783         which binary target should be used for testing.
 784         * Scripts/webkitpy/port/win.py:
 785         (WinPort._port_flag_for_scripts): Added. Supply the 64-bit flag to child
 786         processes when needed.
 787         (WinPort._build_path): Add the correct binary target path to _build_path.
 788         (WinPort._ntsd_location): Check 32-bit paths when running 32-bit tests,
 789         64-bit paths for 64-bit tests.
 790         (WinPort.setup_crash_log_saving): Remove '-e %ld' argument, since the
 791         NTSD debugger does not understand this argument.
 792
 793 2015-10-07  Myles C. Maxfield  <mmaxfield@apple.com>
 794
 795         Test font-variant-* and font-feature-settings with TrueType fonts
 796         https://bugs.webkit.org/show_bug.cgi?id=149776
 797
 798         Reviewed by Simon Fraser.
 799
 800         This test extends our existing FontWithFeatures project to be able to generate a
 801         TrueType font. This font is conceptually similar as the existing OpenType font,
 802         except the feature -> character mapping is different.
 803
 804         The font itself only supports the following characters:
 805         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
 806         However, the shape of these letters are either an X or a check mark.
 807         The letter "A" always is a check mark.
 808         The letter "B" always is an X.
 809         Each font feature has an letter associated with it. When the font feature is enabled,
 810         that letter is shown as a check mark. For example, when
 811         "kLowerCaseType / kLowerCaseSmallCapsSelector" is enabled, "S" is shown as a check
 812         mark.
 813
 814         Here are the mappings of font features to letters:
 815         kLigaturesType / kCommonLigaturesOnSelector: C
 816         kLigaturesType / kContextualLigaturesOnSelector: D
 817         kLigaturesType / kRareLigaturesOnSelector: G
 818         kLigaturesType / kHistoricalLigaturesOnSelector: I
 819         kContextualAlternatesType / kContextualAlternatesOnSelector: L
 820         kVerticalPositionType / kInferiorsSelector: O
 821         kVerticalPositionType / kSuperiorsSelector: P
 822         kLowerCaseType / kLowerCaseSmallCapsSelector: S
 823         kUpperCaseType / kUpperCaseSmallCapsSelector: V
 824         kLowerCaseType / kLowerCasePetiteCapsSelector: T
 825         kUpperCaseType / kUpperCasePetiteCapsSelector: W
 826         kLetterCaseType / 14: Y
 827         kStyleOptionsType / kTitlingCapsSelector: a
 828         kNumberCaseType / kUpperCaseNumbersSelector: c
 829         kNumberCaseType / kLowerCaseNumbersSelector: d
 830         kNumberSpacingType / kProportionalNumbersSelector: f
 831         kNumberSpacingType / kMonospacedNumbersSelector: g
 832         kFractionsType / kDiagonalFractionsSelector: i
 833         kFractionsType / kVerticalFractionsSelector: j
 834         kVerticalPositionType / kOrdinalsSelector: Q
 835         kTypographicExtrasType / kSlashedZeroOnSelector: k
 836         kLigaturesType / kHistoricalLigaturesOnSelector: K
 837         kCharacterShapeType / kJIS1978CharactersSelector: m
 838         kCharacterShapeType / kJIS1983CharactersSelector: n
 839         kCharacterShapeType / kJIS1990CharactersSelector: o
 840         kCharacterShapeType / kJIS2004CharactersSelector: p
 841         kCharacterShapeType / kSimplifiedCharactersSelector: q
 842         kCharacterShapeType / kTraditionalCharactersSelector: r
 843         kTextSpacingType / kMonospacedTextSelector: t
 844         kTextSpacingType / kProportionalTextSelector: u
 845         kRubyKanaType / kRubyKanaOnSelector: v
 846
 847         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
 848         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
 849         (CFFBuilder::moveTo):
 850         (CFFBuilder::lineTo):
 851         (GLYFBuilder::GLYFBuilder):
 852         (GLYFBuilder::takeResult):
 853         (GLYFBuilder::moveTo):
 854         (GLYFBuilder::lineTo):
 855         (GLYFBuilder::closePath):
 856         (GLYFBuilder::writePoint):
 857         (GLYFBuilder::append16):
 858         (generateBoxCharString):
 859         (generateCheckCharString):
 860         (generateXCharString):
 861         (itemForGlyph):
 862         (Generator::generate):
 863         (Generator::insertSelector):
 864         (Generator::insertFeature):
 865         (Generator::generateFeatureDescription):
 866         (Generator::appendCFFTable):
 867         (Generator::appendGLYFTable):
 868         (Generator::appendLOCATable):
 869         (Generator::appendFEATTable):
 870         (Generator::appendMetamorphosisChain):
 871         (Generator::appendMORXTable):
 872         (Generator::appendHEADTable):
 873         (Generator::appendHMTXTable):
 874         (Generator::appendNameSubtable):
 875         (Generator::append2ByteASCIIString):
 876         (Generator::appendNAMETable):
 877         (generateFont):
 878         (CFFBuilder::curveToCubic): Deleted.
 879         (charStringForGlyph): Deleted.
 880         * FontWithFeatures/FontWithFeatures/FontCreator.h:
 881         * FontWithFeatures/FontWithFeatures/main.cpp:
 882         (constructFontWithTrueTypeFeature):
 883         (constructFontWithOpenTypeFeature):
 884         (drawText):
 885         (main):
 886         (drawTextWithFeature): Deleted.
 887
 888 2015-10-07  Commit Queue  <commit-queue@webkit.org>
 889
 890         Unreviewed, rolling out r190572, r190593, r190594, and
 891         r190639.
 892         https://bugs.webkit.org/show_bug.cgi?id=149897
 893
 894         Breaks Mavericks build (Requested by litherum on #webkit).
 895
 896         Reverted changesets:
 897
 898         "Allow WKRetainPtrs to be used as keys in hashing data
 899         structures"
 900         https://bugs.webkit.org/show_bug.cgi?id=149762
 901         http://trac.webkit.org/changeset/190572
 902
 903         "REGRESSION(189668?): http/tests/notifications/events.html
 904         flakily asserts or times out"
 905         https://bugs.webkit.org/show_bug.cgi?id=149218
 906         http://trac.webkit.org/changeset/190593
 907
 908         "Prospective Mavericks build fix."
 909         http://trac.webkit.org/changeset/190594
 910
 911         "Post-review cleanup after r190572."
 912         http://trac.webkit.org/changeset/190639
 913
 914 2015-10-06  Michael Catanzaro  <mcatanzaro@igalia.com>
 915
 916         [GTK] Add autocleanups
 917         https://bugs.webkit.org/show_bug.cgi?id=149588
 918
 919         Reviewed by Darin Adler.
 920
 921         * TestWebKitAPI/Tests/WebKit2Gtk/AutocleanupsTest.cpp: Added.
 922         (AutocleanupsTest::create):
 923         (AutocleanupsTest::testWebProcessAutocleanups):
 924         (registerTests):
 925         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
 926         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp: Added.
 927         (testUIProcessAutocleanups):
 928         (testWebProcessAutocleanups):
 929         (beforeAll):
 930         (afterAll):
 931
 932 2015-10-06  Brian Burg  <bburg@apple.com>
 933
 934         Unreviewed, try to fix the iOS 8 build after r190368.
 935
 936         On older versions, IOHIDEventCreateForceEvent is not available.
 937
 938         * WebKitTestRunner/ios/HIDEventGenerator.mm:
 939         (-[HIDEventGenerator _createIOHIDEventType:]): Add another guard for force events.
 940
 941 2015-10-06  Keith Miller  <keith_miller@apple.com>
 942
 943         Add gmalloc option to run-javascriptcore-tests.
 944         https://bugs.webkit.org/show_bug.cgi?id=149858
 945
 946         Reviewed by Geoffrey Garen.
 947
 948         run-javascriptcore-tests takes a new option --gmalloc with an optional string argument, the path to the gmalloc dylib.
 949         If no argument is provided then /usr/lib/libgmalloc.dylib is used by default.
 950
 951         * Scripts/run-javascriptcore-tests:
 952
 953 2015-10-06  Myles C. Maxfield  <mmaxfield@apple.com>
 954
 955         Post-review cleanup after r190572.
 956
 957         Unreviewed.
 958
 959         * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp:
 960
 961 2015-10-06  Brent Fulgham  <bfulgham@apple.com>
 962
 963         [Win] Unreviewed build correction.
 964
 965         * TestWebKitAPI/PlatformWin.cmake: We don't need to link to all of these libraries. Most
 966         are soft-linked at runtime.
 967
 968 2015-10-06  Keith Miller  <keith_miller@apple.com>
 969
 970         Fix run-javascriptcore-tests/run-jsc-stress-tests to work with rootless, add a --quick option and deprecate the Mozilla driver.
 971         https://bugs.webkit.org/show_bug.cgi?id=149815
 972
 973         Reviewed by Filip Pizlo.
 974
 975         Rootless has an issue where it will strip any environment variables that start with DYLD starting a perl/ruby/python script.
 976         Now, run-jsc-stress-tests takes an new argument, --env-vars, that will set the specified environment variables before
 977         running tests. Additionally, I added a quick option that only runs default and the NoCJITValidate versions of each test.
 978         Finally, I removed the calls to the mozilla jsDriver.pl since the run-jsc-stress-tests runner runs the same test suite
 979         so should just use one test runner.
 980
 981         * Scripts/run-javascriptcore-tests:
 982         (runJSCStressTests):
 983         (runMozillaTests): Deleted.
 984         (defaultJsDriverArgsForMozillaTests): Deleted.
 985         * Scripts/run-jsc-stress-tests:
 986
 987 2015-10-06  Mark Salisbury  <mark.salisbury@hp.com>
 988
 989         [GTK] Make update-webkitgtk-libs work behind firewall
 990
 991         update-webkitgtk-libs can work behind a firewall with changes to
 992         a few packages.  Where outbound git and active FTP connections
 993         fail, using http protocol succeeds.  Most packages are
 994         already accessed using http.
 995
 996         https://bugs.webkit.org/show_bug.cgi?id=148941
 997
 998         Reviewed by Martin Robinson.
 999
1000         Tools
1001         * gtk/jhbuild.modules:
1002             Replace git URLs with http.  Remove no longer used ftp repositories.
1003             Update argument for libxml2's autogen.sh script (--without-python
1004             is ignored; --with-python=no is correct).
1005         * jhbuild/jhbuild-wrapper:
1006             Instead of connecting to git://git.gnome.org/jhbuild, connect to
1007             http://git.gnome.org/browse/jhbuild.
1008
1009 2015-10-06  Daniel Bates  <dbates@webkit.org>
1010
1011         Enable XSLT when building WebKit for iOS using the public iOS SDK
1012         https://bugs.webkit.org/show_bug.cgi?id=149827
1013
1014         Reviewed by Alexey Proskuryakov.
1015
1016         Teach script configure-xcode-for-ios-development to copy the OS X XSLT headers to the iPhoneOS
1017         and iPhoneSimulator SDKs so as to support building WebKit for iOS with XSLT. A person must
1018         run this script before building WebKit for iOS or the build will fail because one or more XSLT
1019         headers cannot be found.
1020
1021         * Scripts/configure-xcode-for-ios-development:
1022         (copyMissingXSLTHeadersToSDKIfNeeded): Added.
1023
1024 2015-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
1025
1026         REGRESSION(189668?): http/tests/notifications/events.html flakily asserts or times out
1027         https://bugs.webkit.org/show_bug.cgi?id=149218
1028
1029         Reviewed by Alexey Proskuryakov.
1030
1031         Because of r189668, WebKitTestRunner now tears down and recreates its WKNotificationManagerRef
1032         when the TestOptions change. Previously, WebNotificationProvider only could handle a single
1033         WKNotificationManagerRef. Because the ower of the WKNotificationManagerRef is reference counted,
1034         and AppKit internally retains some objects which end up retaining the WKNotificationManagerRef,
1035         the old WKNotificationManager may not be destroyed before the new one is created. Therefore,
1036         WebNotificationProvider must be updated to appropriately handle multiple
1037         WKNotificationManagerRefs in flight at the same time.
1038
1039         * WebKitTestRunner/WebNotificationProvider.cpp:
1040         (WTR::WebNotificationProvider::~WebNotificationProvider):
1041         (WTR::WebNotificationProvider::showWebNotification):
1042         (WTR::WebNotificationProvider::closeWebNotification):
1043         (WTR::WebNotificationProvider::addNotificationManager):
1044         (WTR::WebNotificationProvider::removeNotificationManager):
1045         (WTR::WebNotificationProvider::simulateWebNotificationClick):
1046         (WTR::WebNotificationProvider::reset):
1047         * WebKitTestRunner/WebNotificationProvider.h:
1048
1049 2015-10-05  Daniel Bates  <dabates@apple.com>
1050
1051         Disable Bitcode when building for iOS device
1052         https://bugs.webkit.org/show_bug.cgi?id=149818
1053
1054         Reviewed by Alexey Proskuryakov.
1055
1056         Xcode 7 generates bitcode for iOS device apps by default. Do not generate bitcode
1057         when building for iOS device.
1058
1059         * Scripts/webkitdirs.pm:
1060         (XcodeOptions):
1061
1062 2015-10-05  Daniel Bates  <dabates@apple.com>
1063
1064         [iOS] Make it possible to build WebKit using iphoneos SDK without a developer certificate installed
1065         https://bugs.webkit.org/show_bug.cgi?id=140828
1066         <rdar://problem/19520599>
1067
1068         Reviewed by Alexey Proskuryakov.
1069
1070         Support building WebKit for iOS device without an iOS Developer certificate installed. Otherwise,
1071         we will pass CODE_SIGN_IDENTITY="iPhone Developer: " to Xcode to find a iOS Developer certificate
1072         to use. To use a specific installed iOS Developer certificate, explicitly pass CODE_SIGN_IDENTITY
1073         to build-webkit.
1074
1075         * Scripts/webkitdirs.pm:
1076         (XcodeOptions): Cleaned up code. When building for iOS device, pass to Xcode CODE_SIGN_IDENTITY="iPhone Developer: "
1077         to code sign using the installed iOS development certificate (if it exists - we assume there is only one such certificate).
1078         Otherwise, pass CODE_SIGN_IDENTITY="" and CODE_SIGNING_REQUIRED=NO to Xcode to disable code signing.
1079         (hasIOSDevelopmentCertificate): Added.
1080
1081 2015-10-05  Daniel Bates  <dabates@apple.com>
1082
1083         DumpRenderTree built with public iOS SDK crashes under -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
1084         https://bugs.webkit.org/show_bug.cgi?id=149766
1085
1086         Reviewed by Alexey Proskuryakov.
1087
1088         Create network storage testing session on iOS.
1089
1090         Currently we do not create a network storage testing session on iOS. A network storage testing session always
1091         has an associated cookie store. When WebKit is built without USE(CFNETWORK), NetworkStorageSession::defaultStorageSession().cookieStorage()
1092         returns nullptr because the caller is expected to interact with NSHTTPCookieStorage instead of querying
1093         NetworkStorageSession for the cookie store. When WebKit is built with USE(CFNETWORK) accessing
1094         NetworkStorageSession::defaultStorageSession().cookieStorage() returns a valid cookie store (creating one if
1095         it does not exist). Instead we should make use of NetworkStorageSession::switchToNewTestingSession() to
1096         create a network storage testing session when building DumpRenderTree for iOS so as to ensure a consistent
1097         testing environment regardless of whether we built with USE(CFNETWORK). This will also make the behavior of
1098         DumpRenderTree on iOS more consistent with the behavior of DumpRenderTree on Mac.
1099
1100         As a side effect of this change DumpRenderTree no longer crashes in -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
1101         when WebKit is built without USE(CFNETWORK) because NetworkStorageSession::defaultStorageSession().cookieStorage()
1102         returns a non-null pointer to a cookie store.
1103
1104         * DumpRenderTree/mac/DumpRenderTree.mm:
1105         (prepareConsistentTestingEnvironment):
1106
1107 2015-10-05  Simon Fraser  <simon.fraser@apple.com>
1108
1109         Fix the iOS 8 build again, where -[UIApplication _enqueueHIDEvent:] is not
1110         available.
1111
1112         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1113         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
1114
1115 2015-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
1116
1117         Allow WKRetainPtrs to be used as keys in hashing data structures
1118         https://bugs.webkit.org/show_bug.cgi?id=149762
1119
1120         Reviewed by Anders Carlsson.
1121
1122         * TestWebKitAPI/PlatformGTK.cmake:
1123         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1124         * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp: Added.
1125         (TestWebKitAPI::TEST):
1126
1127 2015-10-05  Simon Fraser  <simon.fraser@apple.com>
1128
1129         Fix the iOS 8 build, where -[UIApplication _enqueueHIDEvent:] is not
1130         available, and tidy up the #ifdefs in the UIKitSPI header.
1131
1132         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1133         (-[HIDEventGenerator _sendHIDEvent:]):
1134         * WebKitTestRunner/ios/UIKitSPI.h:
1135
1136 2015-10-04  Zan Dobersek  <zdobersek@igalia.com>
1137
1138         [GTK] Remove duplicate entries in WebKitTestRunner_SOURCES
1139         https://bugs.webkit.org/show_bug.cgi?id=149792
1140
1141         Reviewed by Martin Robinson.
1142
1143         * WebKitTestRunner/PlatformGTK.cmake: Don't list build targets
1144         for WebKitTestRunner multiple times.
1145
1146 2015-10-04  Daniel Bates  <dabates@apple.com>
1147
1148         Fix the Apple Internal iOS build after <http://trac.webkit.org/changeset/190515>
1149         (https://bugs.webkit.org/show_bug.cgi?id=149753)
1150
1151         For now, support calling build-layouttestrelay without --ios-simulator so long
1152         as we are building on a Mac.
1153
1154         * Scripts/build-layouttestrelay:
1155
1156 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
1157
1158         Support Trac 1.0.x XML timeline link format
1159         https://bugs.webkit.org/show_bug.cgi?id=149786
1160
1161         Reviewed by Lucas Forschler.
1162
1163         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1164         (Trac.prototype._convertCommitInfoElementToObject):
1165
1166 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
1167
1168         Fix some errors on bot watcher's dashboard
1169         https://bugs.webkit.org/show_bug.cgi?id=149789
1170
1171         Reviewed by Lucas Forschler.
1172
1173         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1174         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): We may not get to layout
1175         tests step, in which case layoutTestResults.tooManyFailures would raise an exception.
1176
1177 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
1178
1179         Bot watcher's dashboard builders should turn yellow when svn fails
1180         https://bugs.webkit.org/show_bug.cgi?id=149791
1181
1182         Reviewed by Lucas Forschler.
1183
1184         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1185         (BuildbotBuilderQueueView.prototype.appendBuilderQueueStatus):
1186         (BuildbotBuilderQueueView.prototype.update):
1187
1188 2015-10-02  Daniel Bates  <dabates@apple.com>
1189
1190         Add iOS 9 Simulator builders and testers to WebKit Bot Watcher's Dashboard
1191         https://bugs.webkit.org/show_bug.cgi?id=149769
1192
1193         Reviewed by Alexey Proskuryakov.
1194
1195         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png: Added.
1196         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png: Added.
1197         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1198         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1199         (WebKitBuildbot):
1200         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1201         (table.queue-grid tr.platform.ios-simulator-9 img.logo):
1202
1203 2015-10-02  Ryosuke Niwa  <rniwa@webkit.org>
1204
1205         REGRESSION(r190370): Speedometer spits out an extra console message
1206         https://bugs.webkit.org/show_bug.cgi?id=149720
1207
1208         Unreviewed. Temporarily ignore the console error message.
1209
1210         * Scripts/webkitpy/performance_tests/perftest.py:
1211         (PerfTest._filter_output):
1212
1213 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
1214
1215         Provide "--no-ninja" option to avoid using Ninja
1216         https://bugs.webkit.org/show_bug.cgi?id=149757
1217
1218         Reviewed by Alex Christensen.
1219
1220         Add a new command line argument understood by webkitdirs.pm so
1221         that we can conditionally avoid using Ninja. This is an
1222         'opt-out' argument, so no existing Ninja users should be affected.
1223
1224         * Scripts/webkitdirs.pm:
1225         (canUseNinja): Check for option and block ninja if present.
1226
1227 2015-10-02  Aakash Jain  <aakash_jain@apple.com>
1228
1229         Flakiness dashboard should support OS X El Capitan
1230         https://bugs.webkit.org/show_bug.cgi?id=149648
1231
1232         Reviewed by Alexey Proskuryakov.
1233
1234         * TestResultServer/static-dashboards/flakiness_dashboard.js: Fix the broken dashboard for ElCapitan.
1235
1236 2015-10-02  Daniel Bates  <dabates@apple.com>
1237
1238         Fix run-webkit-tests --ios-simulator after <http://trac.webkit.org/changeset/190515>
1239         (https://bugs.webkit.org/show_bug.cgi?id=149753)
1240
1241         For now, pass --ios-simulator.
1242
1243         * Scripts/webkitpy/port/ios.py:
1244         (IOSSimulatorPort._build_relay):
1245
1246 2015-10-02  Simon Fraser  <simon.fraser@apple.com>
1247
1248         Remove a "nullable" that breaks the iOS 8 build.
1249
1250         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1251         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]):
1252
1253 2015-10-02  Daniel Bates  <dabates@apple.com>
1254
1255         LayoutTestRelay is not built and archived when building for iOS Simulator
1256         https://bugs.webkit.org/show_bug.cgi?id=149753
1257
1258         Reviewed by Alexey Proskuryakov and Andy Estes.
1259
1260         Towards running layout tests on the iOS Simulator test bots, we need to teach scripts build-webkit
1261         and built-product-archive to build the Mac tool LayoutTestRelay and include this tool in the built
1262         product archive when building for iOS Simulator, respectively.
1263
1264         * BuildSlaveSupport/built-product-archive:
1265         (main): Pass the full platform name (options.platform) to archiveBuiltProduct() so that it can
1266         differentiate between iOS device and iOS Simulator platforms.
1267         (webkitBuildDirectoryForConfigurationAndPlatform): Extracted logic to run the script webkit-build-directory
1268         from determineWebKitBuildDirectories() into this function so that it can be used by both
1269         determineWebKitBuildDirectories() and archiveBuiltProduct().
1270         (determineWebKitBuildDirectories): Moved logic to execute the script webkit-build-directory from here to
1271         webkitBuildDirectoryForConfigurationAndPlatform().
1272         (createZip): Added parameter embedParentDirectoryNameOnDarwin (defaults to False) to specify whether
1273         we should call ditto(1) with --keepParent to embed the parent directory name in the zip archive. This
1274         argument is only applicable when building on Darwin. We only pass embedParentDirectoryNameOnDarwin=True
1275         when making an archive for a Mac or iOS device build. For iOS Simulator builds we archive two directories
1276         and we do not want to keep the parent directory because it is a placeholder directory used as a workaround
1277         for the limitation that ditto(1) can only accept a single directory to archive on its command line.
1278         (archiveBuiltProduct): Modified to take the full platform name as an argument. Added logic for iOS.
1279         For iOS device builds we use the same logic as for a Mac build and archive the configuration-specific
1280         build directory. For iOS Simulator builds we archive the configuration-specific iOS build directory,
1281         LayoutTestRelay and LayoutTestRelay.dSYM (if it exists) from the configuration-specific Mac build.
1282         * Scripts/build-layouttestrelay:
1283             - Remove unnecessary include of Perl module POSIX.
1284             - Only build LayoutTestRelay when building for iOS Simulator (i.e. --ios-simulator is passed).
1285         * Scripts/build-webkit:
1286             - Invoke script build-layouttestrelay when building for iOS Simulator.
1287
1288 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
1289
1290         [Win] Unreviewed test fix.
1291
1292         You cannot run 'run-webkit-tests' from the command line because it does not know
1293         to append the binary subdirectory (bin32/bin64). We don't see this on our builders
1294         because they explicitly set use the 'root' argument to provide the full path to
1295         the test binaries.
1296
1297         * Scripts/webkitpy/port/win.py:
1298         (WinPort._build_path): Added.
1299
1300 2015-10-02  Alex Christensen  <achristensen@webkit.org>
1301
1302         Reloading without content blockers doesn't apply to resource loads after the main frame finishes
1303         https://bugs.webkit.org/show_bug.cgi?id=149430
1304         rdar://problem/22742222
1305
1306         Reviewed by Geoffrey Garen.
1307
1308         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1309         (WTR::TestController::cocoaResetStateToConsistentValues):
1310         * WebKitTestRunner/mac/TestControllerMac.mm:
1311         (WTR::TestController::platformConfigureViewForTest):
1312         Test what happens when you disable content blockers from the SPI.
1313
1314 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
1315
1316         [Win] Unreviewed build fix for run-api-tests
1317
1318         * Scripts/run-api-tests:
1319         (testToolPaths): Windows run needs to specify the binary path.
1320
1321 2015-10-01  Daniel Bates  <dabates@apple.com>
1322
1323         Another attempt to fix the Windows builders after <https://trac.webkit.org/changeset/190387>
1324         (https://bugs.webkit.org/show_bug.cgi?id=149695)
1325
1326         Following r190424 we can now rely on webkit-build-directory to return the path to
1327         the correct configuration-specific build directory on Windows.
1328
1329         * BuildSlaveSupport/built-product-archive:
1330         (archiveBuiltProduct):
1331
1332 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
1333
1334         [Win] Unreviewed build fix.
1335
1336         * Scripts/webkitdirs.pm:
1337         (setupAppleWinEnv): Use 64-bit build tools if available
1338
1339 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
1340
1341         [Win] Fix TestWebKitAPI build under CMake.
1342
1343         Reviewed by Alex Christensen.
1344
1345         * TestWebKitAPI/PlatformWin.cmake: Add missing link command
1346         for Psapi.lib.
1347
1348 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
1349
1350         [Win] Fix behavior of webkit-build-directory script
1351         https://bugs.webkit.org/show_bug.cgi?id=149718
1352
1353         Reviewed by Alex Christensen.
1354
1355         * Scripts/webkitdirs.pm:
1356         (determineConfigurationProductDir): Do not include the binary
1357         sub-directory in the configuration product directory output.
1358         (jscProductDir): Append correct binary path for Windows build.
1359         (setPathForRunningWebKitApp): Include properly binary subdirectories.
1360         (runSafari): Update for revised productDir behavior.
1361         (runMiniBrowser): Ditto.
1362
1363 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
1364
1365         Stop building LayoutTestRelay for now. It's a Mac project, but build-webkit tries to
1366         use iOS SDK, like with all the others.
1367
1368         * Scripts/build-webkit:
1369
1370 2015-10-01  Daniel Bates  <dabates@apple.com>
1371
1372         Attempt to fix the iOS 9 Simulator testers
1373
1374         Add dependency DumpRenderTree.app to target All of project DumpRenderTree so that we
1375         build DumpRenderTree.app, if applicable. Also, teach build-webkit to build project
1376         LayoutTestRelay when building for iOS Simulator.
1377
1378         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1379         * Scripts/build-webkit:
1380
1381 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1382
1383         [GTK] Websites with invalid auth header keep loading forever
1384         https://bugs.webkit.org/show_bug.cgi?id=149710
1385
1386         Reviewed by Martin Robinson.
1387
1388         Add test case to check that we can authenticate sites with an
1389         empty realm.
1390
1391         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
1392         (testWebViewAuthenticationEmptyRealm):
1393         (serverCallback):
1394         (beforeAll):
1395
1396 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
1397
1398         [Mac] Make run-api-tests work with System Integrity Protection
1399         https://bugs.webkit.org/show_bug.cgi?id=149711
1400         rdar://problem/22928202
1401
1402         Reviewed by Dan Bernstein.
1403
1404         * Scripts/run-api-tests:
1405         (runTest):
1406         (archCommandLineArgumentsForRestrictedEnvironmentVariables):
1407
1408 2015-10-01  Daniel Bates  <dabates@apple.com>
1409
1410         Attempt to fix the Windows build after <https://trac.webkit.org/changeset/190387>
1411         (https://bugs.webkit.org/show_bug.cgi?id=149695)
1412
1413         For some reason built-product-archive hardcodes the assumption that we build for 32-bit Windows.
1414         For now, use the path to the top-level WebKit build directory instead of using the configuration-
1415         specific build directory.
1416
1417         * BuildSlaveSupport/built-product-archive:
1418         (archiveBuiltProduct):
1419
1420 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
1421
1422         [EFL] Fix the openwebrtc and gst-plugins-openwebrtc build with clang
1423         https://bugs.webkit.org/show_bug.cgi?id=145837
1424
1425         Reviewed by Philippe Normand.
1426
1427         * efl/jhbuild.modules:
1428         * efl/patches/openwebrtc-clang-warning-fix.patch: Added.
1429         * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Added.
1430
1431 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1432
1433         Unreviewed. Fix the iOS build after r190407.
1434
1435         * WebKitTestRunner/ios/IOKitSPI.h:
1436
1437 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1438
1439         Implement keyboard event sending for iOS in WebKitTestRunner
1440         https://bugs.webkit.org/show_bug.cgi?id=149676
1441
1442         Reviewed by Simon Fraser.
1443
1444         Adds support for generating and sending key events in WebKitTestRunner. This is accomplished in a similar
1445         way as touch events, using IOHIDEvent machinery. Also adds callbacks to the UIScriptController JS API that
1446         allows us to run code when the keyboard is shown or hidden.
1447
1448         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Adds the typeCharacter JS interface.
1449         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1450         (WTR::UIScriptController::setDidShowKeyboardCallback):
1451         (WTR::UIScriptController::didShowKeyboardCallback):
1452         (WTR::UIScriptController::setDidHideKeyboardCallback):
1453         (WTR::UIScriptController::didHideKeyboardCallback):
1454         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
1455         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
1456         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
1457         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1458         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1459         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1460         (-[TestRunnerWKWebView initWithFrame:configuration:]): Registers the TestRunnerWKWebView to listen to
1461                 the notifications that the keyboard has been raised or lowered.
1462         (-[TestRunnerWKWebView _keyboardDidShow:]):
1463         (-[TestRunnerWKWebView _keyboardDidHide:]):
1464         * WebKitTestRunner/ios/HIDEventGenerator.h:
1465         * WebKitTestRunner/ios/HIDEventGenerator.m:
1466         (-[HIDEventGenerator _sendIOHIDKeyboardEvent:usage:isKeyDown:]): Helper to send a HID keyboard event.
1467         (shouldWrapWithShiftKeyEventForCharacter): Helper used to generate key events.
1468         (hidUsageCodeForCharacter): Ditto.
1469         (-[HIDEventGenerator keyDown:completionBlock:]): Synthesizes and sends HIDKeyboardEvents, triggering
1470                 a keyDown event in WebKit.
1471         * WebKitTestRunner/ios/IOKitSPI.h:
1472         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1473
1474 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1475
1476         Unreviewed, rolling out r190399.
1477
1478         Tests are still failing even after r190362
1479
1480         Reverted changeset:
1481
1482         "Unreviewed. Unskip GTK+ user media unit tests after r190362."
1483         http://trac.webkit.org/changeset/190399
1484
1485 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
1486
1487         [jhbuild] switch to new upstream usrsctp library
1488         https://bugs.webkit.org/show_bug.cgi?id=149494
1489
1490         Reviewed by Philippe Normand.
1491
1492         * efl/jhbuild.modules:
1493         * gtk/jhbuild.modules:
1494
1495 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1496
1497         Unreviewed. Unskip GTK+ user media unit tests after r190362.
1498
1499         They should pass now.
1500
1501         * Scripts/run-gtk-tests:
1502         (TestRunner):
1503
1504 2015-09-30  Daniel Bates  <dabates@apple.com>
1505
1506         Another attempt to fix the build after <https://trac.webkit.org/changeset/190387>
1507         (https://bugs.webkit.org/show_bug.cgi?id=149695)
1508
1509         * BuildSlaveSupport/built-product-archive:
1510         (determineWebKitBuildDirectories): Substitute _configurationBuildDirectory for _buildDirectory.
1511         (extractBuiltProduct): Substitute _topLevelBuildDirectory for _buildDirectory.
1512
1513 2015-09-30  Daniel Bates  <dabates@apple.com>
1514
1515         Attempt to fix the build after <https://trac.webkit.org/changeset/190387>
1516         (https://bugs.webkit.org/show_bug.cgi?id=149695)
1517
1518         Actually, we need to pass --configuration to script webkit-build-directory to have
1519         it return the path to the configuration-specific build directory.
1520
1521         * BuildSlaveSupport/built-product-archive:
1522         (determineWebKitBuildDirectories):
1523
1524 2015-09-30  Daniel Bates  <dabates@apple.com>
1525
1526         built-product-archive archives incorrect build directory for iOS port
1527         https://bugs.webkit.org/show_bug.cgi?id=149695
1528
1529         Reviewed by Darin Adler.
1530
1531         Fixes an issue where the script built-product-archive archives a non-existent
1532         build directory for the iOS port. Without loss of generality, the script assumes
1533         the path to the Release configuration build for iOS is in directory WebKitBuild/Release.
1534         But the built products for this configuration are in directory WebKitBuild/Release-iphonesimulator.
1535
1536         Currently the script built-product-archive calls `webkit-build-directory --top-level ...`
1537         to determine the top-level build directory and computes the configuration-specific
1538         build directory to be the concatenation of the the top-level build directory and
1539         the configuration (e.g. Release). This is incorrect. Instead we should call
1540         webkit-build-directory omitting the flag --top-level to compute the path to the
1541         configuration-specific build directory.
1542
1543         * BuildSlaveSupport/built-product-archive: Fix up the style such that we use single quoted literals.
1544         (main): Renamed global variable _buildDirectory to _topLevelBuildDirectory to better describe
1545         its purpose and added global variable _configurationBuildDirectory to store the path
1546         to the configuration-specific build directory. Ensure that we have a non-empty string
1547         for both the top-level and configuration-specific build directories.
1548         (determineWebKitBuildDirectories): Formerly named determineWebKitBuildDirectory.
1549         Compute the configuration-specific build directory and store it in the global variable
1550         _configurationBuildDirectory.
1551         (archiveBuiltProduct): Modified to use _configurationBuildDirectory.
1552         (extractBuiltProduct): Modified to use _configurationBuildDirectory and _topLevelBuildDirectory
1553         as needed.
1554         (determineWebKitBuildDirectory): Deleted.
1555
1556 2015-09-30  Hunseop Jeong  <hs85.jeong@samsung.com>
1557
1558         [EFL] css3/device-adapt/* tests failed after r190335.
1559         https://bugs.webkit.org/show_bug.cgi?id=149655
1560
1561         Reviewed by Simon Fraser.
1562
1563         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
1564         overwritten by updatePlatformSpecificViewOptionsForTest after r190335.
1565
1566         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1567         (WTR::shouldUseFixedLayout):
1568
1569 2015-09-30  Dewei Zhu  <dewei_zhu@apple.com>
1570
1571         Extend JetStream timeout for slow devices.
1572
1573         Reviewed by Chris Dumez.
1574
1575         Extend JetStream timeout to 20 minutes.
1576
1577         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
1578
1579 2015-09-30  Daniel Bates  <dabates@apple.com>
1580
1581         Rename iOS builders/testers to include version
1582         https://bugs.webkit.org/show_bug.cgi?id=149685
1583
1584         Reviewed by Simon Fraser.
1585
1586         Substitute "Apple iOS 9" for "Apple iOS" in the names of iOS builders/testers so as
1587         make it clear to a reader the version of iOS these builders/testers are using.
1588
1589         * BuildSlaveSupport/build.webkit.org-config/config.json:
1590         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1591
1592 2015-09-30  Daniel Bates  <dabates@apple.com>
1593
1594         Add iOS criterion for triggering a build
1595         https://bugs.webkit.org/show_bug.cgi?id=149679
1596
1597         Rubber-stamped by Alexey Proskuryakov.
1598
1599         First pass at defining criterion for triggering an iOS build.
1600
1601         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1602         (_should_file_trigger_build):
1603         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1604         (ShouldBuildTest):
1605         (ShouldBuildTest.test_should_build):
1606
1607 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
1608
1609         [iOS] Allow tests to generate user gestures for UI testing
1610         https://bugs.webkit.org/show_bug.cgi?id=149653
1611
1612         Reviewed by Tim Horton.
1613
1614         Expose functionality in UIScriptController to allow for testing single- and double-tap,
1615         and to listen for completion of scrolling and zooming in the WKWebView.
1616
1617         Tap generation is done using synthetic IOHIDEvents, via a new HIDEventGenerator class
1618         which hides the complexity of creating these events. Event dispatch is asynchronous.
1619         We detect when the last event has been handled by dispatching a vendor-specific event,
1620         which is detected via -_handleHIDEvent: in our UIApplication subclass.
1621
1622         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Link with IOKit.
1623         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Two new properties
1624         for 'will begin zooming' and 'did end zooming' callbacks, and functions to dispatch
1625         single and double taps.
1626         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
1627         (UIScriptContext::registerCallback): Used to store the callbacks for zooming.
1628         Unlike the "task" callbacks, these are persistent, but we store them in the same hash map.
1629         (UIScriptContext::unregisterCallback):
1630         (UIScriptContext::callbackWithID):
1631         (UIScriptContext::fireCallback):
1632         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
1633         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1634         (WTR::UIScriptController::setWillBeginZoomingCallback): Cross-platform code.
1635         (WTR::UIScriptController::willBeginZoomingCallback): Ditto.
1636         (WTR::UIScriptController::setDidEndZoomingCallback):
1637         (WTR::UIScriptController::didEndZoomingCallback):
1638         (WTR::UIScriptController::singleTapAtPoint): Non-iOS stub.
1639         (WTR::UIScriptController::doubleTapAtPoint): Ditto.
1640         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
1641         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
1642         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1643         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1644         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Properties for the zooming callbacks.
1645         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1646         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]): Dispatch the zooming callback.
1647         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]): Ditto.
1648         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]): Ditto.
1649         (-[TestRunnerWKWebView onDidEndZooming:]): Deleted.
1650         * WebKitTestRunner/ios/HIDEventGenerator.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
1651         * WebKitTestRunner/ios/HIDEventGenerator.m: Added.
1652         (simpleDragCurve):
1653         (calculateNextLocation):
1654         (delayBetweenMove):
1655         (+[HIDEventGenerator sharedHIDEventGenerator]):
1656         (+[HIDEventGenerator nextEventCallbackID]):
1657         (-[HIDEventGenerator init]):
1658         (-[HIDEventGenerator _createIOHIDEventType:]):
1659         (-[HIDEventGenerator _sendHIDEvent:]):
1660         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
1661         (-[HIDEventGenerator _updateTouchPoints:count:]):
1662         (-[HIDEventGenerator touchDownAtPoints:touchCount:]):
1663         (-[HIDEventGenerator touchDown:touchCount:]):
1664         (-[HIDEventGenerator touchDown:]):
1665         (-[HIDEventGenerator liftUpAtPoints:touchCount:]):
1666         (-[HIDEventGenerator liftUp:touchCount:]):
1667         (-[HIDEventGenerator liftUp:]):
1668         (-[HIDEventGenerator moveToPoints:touchCount:duration:]):
1669         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
1670         (-[HIDEventGenerator tap:completionBlock:]):
1671         (-[HIDEventGenerator doubleTap:completionBlock:]):
1672         (-[HIDEventGenerator twoFingerTap:completionBlock:]):
1673         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
1674         (-[HIDEventGenerator pinchCloseWithStartPoint:endPoint:duration:completionBlock:]):
1675         (-[HIDEventGenerator pinchOpenWithStartPoint:endPoint:duration:completionBlock:]):
1676         (-[HIDEventGenerator markerEventReceived:]):
1677         * WebKitTestRunner/ios/IOKitSPI.h: Added.
1678         * WebKitTestRunner/ios/UIKitSPI.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
1679         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1680         (WTR::globalToContentCoordinates):
1681         (WTR::UIScriptController::singleTapAtPoint):
1682         (WTR::UIScriptController::doubleTapAtPoint):
1683         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
1684         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
1685         * WebKitTestRunner/ios/mainIOS.mm:
1686         (-[WebKitTestRunnerApp _handleHIDEvent:]):
1687
1688 2015-09-30  Dana Burkart  <dburkart@apple.com>
1689
1690         git-add-reviewer should trim trailing spaces/newlines
1691         https://bugs.webkit.org/show_bug.cgi?id=149513
1692
1693         Reviewed by Darin Adler.
1694
1695         * Scripts/git-add-reviewer:
1696         (nonInteractive):
1697
1698 2015-09-30  Eric Carlson  <eric.carlson@apple.com>
1699
1700         REGRESSION(r190262): User media unit test failures after r190262
1701         https://bugs.webkit.org/show_bug.cgi?id=149580
1702
1703         Reviewed by Darin Adler.
1704
1705         * WebKitTestRunner/TestController.cpp:
1706         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Fix parameter
1707           order to WKUserMediaPermissionRequestAllow.
1708
1709 2015-09-30  Daniel Bates  <dabates@apple.com>
1710
1711         Add iOS builders and testers
1712         https://bugs.webkit.org/show_bug.cgi?id=149549
1713
1714         Reviewed by Alexey Proskuryakov.
1715
1716         Adds definitions for 64-bit iOS Simulator release builders and testers and a iOS device
1717         builder that builds universal release binaries for armv7, armv7s and arm64 architectures.
1718
1719         * BuildSlaveSupport/build.webkit.org-config/config.json: Add definitions for builders and testers.
1720         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Update unit tests.
1721
1722 2015-09-30  Timothy Hatcher  <timothy@apple.com>
1723
1724         Give WebKitLauncher the get-task-allow entitlement to allow it to work on El Capitan
1725         https://bugs.webkit.org/show_bug.cgi?id=149674
1726
1727         Reviewed by Lucas Forschler.
1728
1729         * WebKitLauncher/WebKitLauncher.entitlements: Added.
1730         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1731
1732 2015-09-30  Jason Marcell  <jmarcell@apple.com>
1733
1734         BuildbotQueueView.prototype._appendPendingRevisionCount should skip repositories that don't
1735         have an associated trac instance.
1736         https://bugs.webkit.org/show_bug.cgi?id=149673
1737
1738         Reviewed by Alexey Proskuryakov.
1739
1740         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1741         (BuildbotQueueView.prototype._appendPendingRevisionCount): Skip repositories that don't
1742         have an associated trac instance.
1743
1744 2015-09-30  Daniel Bates  <dabates@apple.com>
1745
1746         Prioritize testing latest build request on iOS test bots
1747         https://bugs.webkit.org/show_bug.cgi?id=149669
1748
1749         Reviewed by Darin Adler.
1750
1751         We should prioritize testing of the latest build request on the iOS test bots
1752         as we do for Mac and Windows test bots.
1753
1754         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1755         (loadBuilderConfig):
1756
1757 2015-09-30  Daniel Bates  <dabates@apple.com>
1758
1759         Add buildbot category for iOS builders and testers
1760         https://bugs.webkit.org/show_bug.cgi?id=149667
1761
1762         Reviewed by Darin Adler.
1763
1764         Group iOS builders and testers under category iOS and add dashboard and console hyperlinks
1765         for iOS to the build.webkit.org home page.
1766
1767         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1768         (loadBuilderConfig):
1769         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1770
1771 2015-09-30  Daniel Bates  <dabates@apple.com>
1772
1773         Actually fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
1774         (https://bugs.webkit.org/show_bug.cgi?id=149539)
1775
1776         I inadvertently didn't remove the ONLY_ACTIVE_ARCH=NO flag when building on a Mac
1777         in <http://trac.webkit.org/changeset/190351>.
1778
1779         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1780         (CompileWebKit.start):
1781
1782 2015-09-30  Daniel Bates  <dabates@apple.com>
1783
1784         Attempt to fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
1785         (https://bugs.webkit.org/show_bug.cgi?id=149539)
1786
1787         {32, 64}-bit Mac builders should not try to build project {Plugin.64, Plugin.32},
1788         respectively; only pass ONLY_ACTIVE_ARCH=NO when building for iOS.
1789
1790         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1791         (CompileWebKit.start):
1792
1793 2015-09-30  Lucas Forschler  <lforschler@apple.com>
1794
1795         bot210 was configured for a queue instead of bot126.
1796
1797         Unreviewed config.json fix.
1798
1799         * BuildSlaveSupport/build.webkit.org-config/config.json:
1800
1801 2015-09-30  Lucas Forschler  <lforschler@apple.com>
1802
1803         Bring El Capitan buildbot infrastructure online.
1804         https://bugs.webkit.org/show_bug.cgi?id=149605
1805
1806         Reviewed by Darin Adler.
1807
1808         * BuildSlaveSupport/build.webkit.org-config/config.json:
1809
1810 2015-09-30  Tomas Popela  <tpopela@redhat.com>
1811
1812         [GTK] Deprecation warnings in DOMNodeTest
1813         https://bugs.webkit.org/show_bug.cgi?id=149663
1814
1815         After the webkit_dom_document_get_elements_by_tag_name deprecation we
1816         need to update the tests to use webkit_dom_document_query_selector_all
1817         to avoid compilation warnings.
1818
1819         Also add a new test for webkit_dom_document_get_elements_by_tag_name_as_html_collection
1820         (the suggested replacement for the deprecated function).
1821
1822         Reviewed by Carlos Garcia Campos.
1823
1824         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
1825         (WebKitDOMNodeTest::testTagNamesNodeList):
1826         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
1827         (registerTests):
1828         (WebKitDOMNodeTest::testTagNames): Deleted.
1829         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
1830         (prepareDOMForTagNamesTests):
1831         (testWebKitDOMNodeTagNamesNodeList):
1832         (testWebKitDOMNodeTagNamesHTMLCollection):
1833         (beforeAll):
1834         (testWebKitDOMNodeTagNames): Deleted.
1835
1836 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
1837
1838         WebKitTestRunner fails to apply "useFlexibleViewport" when it's specified in a file comment
1839         https://bugs.webkit.org/show_bug.cgi?id=149650
1840
1841         Reviewed by Tim Horton.
1842
1843         TestInvocation::invoke() consulted shouldMakeViewportFlexible(), but that only
1844         looks at the file path, and not the custom options that come from file comments.
1845
1846         Fix by computing TestOptions before making the TestInvocation, and setting them
1847         as const TestInvocation data. This meant changing various call sites to take
1848         the std::string pathOrURL, rather than the TestInvocation itself.
1849
1850         Also initialize TestInvocation with a WKURLRef, rather than a std::string.
1851
1852         * WebKitTestRunner/CMakeLists.txt:
1853         * WebKitTestRunner/TestController.cpp:
1854         (WTR::TestController::ensureViewSupportsOptionsForTest):
1855         (WTR::testPath):
1856         (WTR::createTestURL):
1857         (WTR::updateTestOptionsFromTestHeader):
1858         (WTR::TestController::testOptionsForTest):
1859         (WTR::TestController::updateWebViewSizeForTest):
1860         (WTR::TestController::updateWindowScaleForTest):
1861         (WTR::TestController::runTest):
1862         * WebKitTestRunner/TestController.h:
1863         * WebKitTestRunner/TestInvocation.cpp:
1864         (WTR::TestInvocation::TestInvocation):
1865         (WTR::TestInvocation::invoke):
1866         (WTR::createWKURL): Deleted.
1867         (WTR::TestInvocation::shouldMakeViewportFlexible): Deleted.
1868         (WTR::TestInvocation::shouldUseFixedLayout): Deleted.
1869         * WebKitTestRunner/TestInvocation.h:
1870         (WTR::TestInvocation::options):
1871         * WebKitTestRunner/TestOptions.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
1872         (WTR::pathContains):
1873         (WTR::shouldMakeViewportFlexible):
1874         (WTR::shouldUseFixedLayout):
1875         (WTR::isSVGTestPath):
1876         (WTR::isHiDPITestPath):
1877         (WTR::TestOptions::TestOptions):
1878         * WebKitTestRunner/TestOptions.h:
1879         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1880         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1881         (WTR::pathContains):
1882         (WTR::shouldUseFixedLayout):
1883         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1884         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1885         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1886         * WebKitTestRunner/ios/TestControllerIOS.mm:
1887         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1888         * WebKitTestRunner/mac/TestControllerMac.mm:
1889         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1890
1891 2015-09-29  Aakash Jain  <aakash_jain@apple.com>
1892
1893         Flakiness dashboard should support OS X El Capitan
1894         https://bugs.webkit.org/show_bug.cgi?id=149648
1895
1896         Reviewed by Alexey Proskuryakov.
1897
1898         * QueueStatusServer/app.yaml: We do not need to maintain SVN revision here because of
1899         difference between new appscale and old Google App Engine implementation.
1900         * TestResultServer/app.yaml: Same.
1901         * TestResultServer/static-dashboards/builders.jsonp: Added OSX El Capitan support.
1902
1903 2015-09-29  Daniel Bates  <dabates@apple.com>
1904
1905         configure-xcode-for-ios-development does not work with Xcode 7
1906         https://bugs.webkit.org/show_bug.cgi?id=149640
1907
1908         Reviewed by Alexey Proskuryakov.
1909
1910         When Xcode 7 is installed, running configure-xcode-for-ios-development dies with an error
1911         because it cannot find the Xcode specification files for iOS simulator and device. These
1912         files have moved to a new location in Xcode 7 distribution. Moreover we must add the
1913         relevant definitions to the Xcode 7 specification files directly as opposed to creating
1914         new specification files with the added definitions (as we did in older versions of Xcode)
1915         in order for Xcode 7 to honor these definitions.
1916
1917         * Scripts/configure-xcode-for-ios-development: Sorted forward declarations.
1918         (updateXcodeSpecificationFilesForSDKIfNeeded): Added.
1919         (updateXcode7SpecificationFile): Added.
1920         (createLegacyXcodeSpecificationFilesForSDKIfNeeded): Formerly named createXcodeSpecificationFilesForSDKIfNeeded.
1921         (writeXcodeSpecification): Moved congratulations line to caller so as to write out the
1922         appropriate success message.
1923         (mergeXcodeSpecificationWithSpecificationAndId): Formerly named createXcodeSpecificationFromSpecificationAndId.
1924         (createXcodeSpecificationFilesForSDKIfNeeded): Deleted.
1925         (createXcodeSpecificationFromSpecificationAndId): Deleted.
1926
1927 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
1928
1929         [Win] Allow 'prepare-ChangeLog' to be used without Cygwin
1930         https://bugs.webkit.org/show_bug.cgi?id=149639
1931
1932         Reviewed by Alex Christensen.
1933
1934         * Scripts/VCSUtils.pm:
1935         (exitStatus): Use 'isWindows()' method.
1936         (isSVNVersion16OrNewer): 'eval' is not needed here, and just causes
1937         an error. This method could probably just go away.
1938         (normalizePath): Leave Windows (or Unix) paths as platform paths, rather than
1939         always changing to Unix style.
1940         (unixPath): Added. Needed so Windows can always show a Unix path in the
1941         ChangeLog file.
1942         (changeLogName): Work around the fact that 'getpwuid' is not available on
1943         a pure Windows build of Perl.
1944         * Scripts/prepare-ChangeLog:
1945         (generateFunctionLists): Normalize path received from 'svn' in case it's a Unix
1946         path on Windows.
1947         (svnUpdateCommand): Added helper function. Needed because Windows Perl does not
1948         support using arrays for 'open' arguments.
1949         (resolveChangeLogsPath): Ditto.
1950         (resolveConflictedChangeLogs): Use new helper functions.
1951         (generateNewChangeLogs): Force Windows to use Unix paths in ChangeLog output.
1952         (diffCommand): Use double-quotes for paths, since Windows doesn't understand single
1953         quotes. Unix systems are happy either way.
1954         (statusCommand): Ditto.
1955         * Scripts/webkitdirs.pm:
1956         (launcherName): Drive-by fix. WinLauncher was renamed to MiniBrowser some time ago.
1957
1958 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
1959
1960         [Win] Unreviewed 64-bit build fix after switch to CMake.
1961
1962         * Scripts/webkitdirs.pm:
1963         (determineIsWin64FromArchitecture): Added.
1964
1965 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1966
1967         printing does not use minimum page zoom factor
1968         https://bugs.webkit.org/show_bug.cgi?id=108507
1969
1970         Reviewed by Darin Adler.
1971
1972         WebKitTestRunner always takes the snapshots from the UI process
1973         (expect for IOS), so in the case of printing, the layout in the
1974         web view is not the expected one. When printing, we need to take
1975         the snapshot in the web process and ensure it's rendered with a
1976         PrintContext.
1977
1978         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1979         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
1980         kWKSnapshotOptionsPrinting option to
1981         WKBundlePageCreateSnapshotWithOptions() when printing.
1982
1983 2015-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1984
1985         [WTR] Pixel tests generate the snapshots twice in Web and UI processes
1986         https://bugs.webkit.org/show_bug.cgi?id=149595
1987
1988         Reviewed by Tim Horton.
1989
1990         All ports except IOS implement
1991         PlatformWebView::windowSnapshotImage() to generate the snapshot
1992         for the pixel tests in the UI process. But we are still generating
1993         a snapshot for pixel tests in the Web process too, that is passed
1994         to the UI process but ignored.
1995         Whether a pixel result is needed or not, is only known by the web
1996         process depending on whether the test called dumpAsText with
1997         dumpPixels == true or not. Since the pixels are now dump in the UI
1998         process, we need to pass that information to the UI process when
1999         the test is done. For that we set a PixelResultIsPending bool
2000         parameter to the Done message, and we only add the PixelResult
2001         when UI process doesn't need to generate the pixels dump.
2002
2003         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2004         (WTR::InjectedBundle::didReceiveMessageToPage): Set
2005         m_pixelResultIsPending to false on reset.
2006         (WTR::InjectedBundle::done): Add PixelResultIsPending parameter to the
2007         Done message, and set the PixelResult if m_pixelResultIsPending is false.
2008         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2009         (WTR::InjectedBundle::setPixelResult): Set m_pixelResultIsPending to false.
2010         (WTR::InjectedBundle::setNeedsPixelResult): Set m_pixelResultIsPending.
2011         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2012         (WTR::InjectedBundlePage::dump): Only create a snapshot for IOS
2013         port.
2014         * WebKitTestRunner/TestInvocation.cpp:
2015         (WTR::TestInvocation::dumpResults): Use either the pixel result
2016         from the web process or generate a pixel result from the web view
2017         if need it.
2018         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2019         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
2020         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
2021         is created by the caller now, but the CG implementation needs to
2022         know if it's a Web or UI process snapshot.
2023         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2024         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2025         cairo surface for the given image.
2026         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2027         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2028         CGContext for the given image.
2029
2030 2015-09-28  Dean Johnson  <dean_johnson@apple.com>
2031
2032         Fix JS errors on dashboard metrics page
2033         https://bugs.webkit.org/show_bug.cgi?id=149608
2034
2035         Reviewed by Alexey Proskuryakov.
2036
2037         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Updated to use Settings.
2038         (initPlatformsByFamily):
2039         (updateHiddenPlatforms):
2040         (parsePlatformFamily): Deleted.
2041         (updateToggleButtons): Deleted.
2042         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2043         (updateHiddenPlatforms): Added to remove errors.
2044         (initPlatformsByFamily): Added to remove errors.
2045         (unhiddenQueues): Updated to use Settings.
2046         (documentReady): Added logic to add toggle buttons to the settings menu.
2047         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
2048         (Settings.prototype.parsePlatformFamily): Moved duplicate logic from Main.js and
2049         MetricsMain.js to Settings.
2050         (Settings.prototype.updateToggleButtons): Moved duplicate logic from Main.js and
2051         MetricsMain.js to Settings.
2052         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
2053         (QueueView.prototype._updateHiddenState): Updated to use Settings.
2054
2055 2015-09-28  Aakash Jain  <aakash_jain@apple.com>
2056
2057         Appscale query fails because of missing index
2058         https://bugs.webkit.org/show_bug.cgi?id=149609
2059
2060         Reviewed by Darin Adler.
2061
2062         * QueueStatusServer/index.yaml: Added the required index.
2063
2064 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
2065
2066         [Win] Fix the 64-bit build after switch to cmake.
2067
2068         Reviewed by Alex Christensen.
2069
2070         * Scripts/webkitdirs.pm:
2071         (generateBuildSystemFromCMakeProject): Use correct arguments for cmake to
2072         run a 64-bit build.
2073
2074 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
2075
2076         [Win] Allow Windows to run test-webkitpy without Cygwin
2077         https://bugs.webkit.org/show_bug.cgi?id=149602
2078
2079         Reviewed by Alex Christensen.
2080
2081         These changes mostly shift from hard-coded paths using UNIX-style
2082         separators to Python's "os.path.join" syntax that uses the correct
2083         path separator for each platform.
2084
2085         * Scripts/webkitpy/common/system/path.py:
2086         (cygpath): Don't pass paths through Cygpath on native Windows.
2087         * Scripts/webkitpy/port/win.py:
2088         (WinPort._path_to_apache): Use os.path.join.
2089         (WinPort._ntsd_location): Support 64-bit environment (ProgramW6432 doesn't exist
2090         in 64-bit environments).
2091         * Scripts/webkitpy/style/checker.py: Use os.path.join.
2092         * Scripts/webkitpy/style/checker_unittest.py:
2093         (GlobalVariablesTest.test_path_rules_specifier.assertNoCheck): Use os.path.join.
2094         (GlobalVariablesTest.test_path_rules_specifier): Ditto.
2095         (GlobalVariablesTest): Ditto.
2096         (GlobalVariablesTest.test_max_reports_per_category): Ditto.
2097         (CheckerDispatcherSkipTest.test_should_skip_with_warning): Ditto.
2098         (CheckerDispatcherDispatchTest.test_js_paths): Ditto.
2099         (CheckerDispatcherDispatchTest.test_json_paths): Ditto.
2100         (CheckerDispatcherDispatchTest.test_python_paths): Ditto.
2101         (CheckerDispatcherDispatchTest.test_text_paths): Ditto.
2102         (CheckerDispatcherDispatchTest.test_xml_paths): Ditto.
2103         (StyleProcessor_CodeCoverageTest._create_carriage_checker_class): Ditto.
2104         (StyleProcessor_CodeCoverageTest): Ditto.
2105         (StyleProcessor_CodeCoverageTest.test_should_process__skip_without_warning): Ditto.
2106         (StyleProcessor_CodeCoverageTest.test_should_process__skip_with_warning): Ditto.
2107         (StyleProcessor_CodeCoverageTest.test_should_process__true_result): Ditto.
2108         * Scripts/webkitpy/w3c/test_parser_unittest.py: Uses os.path.join rather than
2109         manual string concatenation of paths.
2110
2111 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
2112
2113         Add bugzilla addresses of committers to contributors.json
2114         https://bugs.webkit.org/show_bug.cgi?id=149520
2115
2116         Reviewed by Darin Adler.
2117
2118         * Scripts/webkitpy/common/config/contributors.json:
2119
2120 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
2121
2122         validate-committer-lists -b shouldn't need edituser privileges
2123         https://bugs.webkit.org/show_bug.cgi?id=149519
2124
2125         Reviewed by Darin Adler.
2126
2127         * Scripts/validate-committer-lists:
2128         (CommitterListBugzillaChecker._has_invalid_bugzilla_email):
2129         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2130         (BugzillaQueries.is_invalid_bugzilla_email):
2131         (BugzillaQueries): Deleted.
2132         (BugzillaQueries.fetch_logins_matching_substring): Deleted.
2133
2134 2015-09-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2135
2136         Unreviewed. Gardening: skip media stream tests failing after r190262.
2137
2138         * Scripts/run-gtk-tests:
2139         (TestRunner):
2140
2141 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
2142
2143         [Mac] USE_INTERNAL_SDK is used undefined in tools projects
2144         https://bugs.webkit.org/show_bug.cgi?id=149571
2145
2146         Reviewed by Dan Bernstein.
2147
2148         Use the same pattern as in Source directory configurations (so, also get rid of AspenFamily.xcconfig).
2149
2150         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2151         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2152         * LayoutTestRelay/Configurations/Base.xcconfig:
2153         * MiniBrowser/Configurations/Base.xcconfig:
2154         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2155         * TestWebKitAPI/Configurations/Base.xcconfig:
2156         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2157         * WebEditingTester/Configurations/Base.xcconfig:
2158         * WebEditingTester/Configurations/DebugRelease.xcconfig:
2159         * WebKitTestRunner/Configurations/Base.xcconfig:
2160         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2161         * WebKitTestRunner/iOS.xcconfig: Removed.
2162
2163 2015-09-25  Eric Carlson  <eric.carlson@apple.com>
2164
2165         Clean up user media request internal API
2166         https://bugs.webkit.org/show_bug.cgi?id=149527
2167
2168         Reviewed by Tim Horton.
2169
2170         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
2171         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): Update for API changes.
2172
2173         * WebKitTestRunner/TestController.cpp:
2174         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Ditto.
2175
2176 2015-09-25  Simon Fraser  <simon.fraser@apple.com>
2177
2178         [iOS WK2] Add viewport tests and fix runUIScript() timing issues
2179         https://bugs.webkit.org/show_bug.cgi?id=149577
2180
2181         Reviewed by Tim Horton.
2182
2183         When calling testRunner.runUIScript() from a page load event, the script could run
2184         in the UI process before the current remote layer tree transaction had been handled
2185         there. This meant that runUIScript() could query state which was about to change.
2186
2187         Fix by delaying the execution of the UI script until a layer tree transaction has
2188         been handled by the UI process, leveraging the existing DrawingAreaProxy::dispatchAfterEnsuringDrawing().
2189
2190         * WebKitTestRunner/TestInvocation.cpp:
2191         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2192         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
2193         * WebKitTestRunner/TestInvocation.h:
2194
2195 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
2196
2197         [Mac] Media tests start to time out after a few days of bot uptime
2198         https://bugs.webkit.org/show_bug.cgi?id=149468
2199
2200         Reviewed by Darin Adler.
2201
2202         Delete cache directory in addition to the temporary one. Don't delete /private/tmp/MediaCache,
2203         as it's not longer used by tests. Set TMPDIR and DIRHELPER_USER_DIR_SUFFIX to make
2204         all temporary and cache files go to a custom location.
2205
2206         * Scripts/webkitpy/port/base.py:
2207         * Scripts/webkitpy/port/driver.py:
2208         * Scripts/webkitpy/port/mac.py:
2209         * Scripts/webkitpy/port/win.py:
2210         (WinPort._driver_tempdir_for_environment): Deleted unused function.
2211
2212 2015-09-25  Dan Bernstein  <mitz@apple.com>
2213
2214         Removed MiniBrowser.entitlements.
2215
2216         Rubber-stamped by Anders Carlsson.
2217
2218         The entitlements weren’t used anyway.
2219
2220         * MiniBrowser/MiniBrowser.entitlements: Removed.
2221         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2222
2223 2015-09-24  Daniel Bates  <dabates@apple.com>
2224
2225         Add WebKitSystemInterface for iOS 9.0
2226         https://bugs.webkit.org/show_bug.cgi?id=149550
2227
2228         Rubber-stamped by Alexey Proskuryakov.
2229
2230         * Scripts/copy-webkitlibraries-to-product-directory:
2231
2232 2015-09-24  Daniel Bates  <dabates@apple.com>
2233
2234         Support building for arbitrary architectures
2235         https://bugs.webkit.org/show_bug.cgi?id=149539
2236
2237         Reviewed by Alexey Proskuryakov.
2238
2239         Teach buildbot to pass the architectures associated with the builder to build-webkit
2240         when building on OS X and iOS. As a side effect of this change we now support building
2241         universal binaries when multiples architectures are specified.
2242
2243         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2244         (CompileWebKit.start):
2245
2246 2015-09-24  Daniel Bates  <dabates@apple.com>
2247
2248         Fix the build after <http://trac.webkit.org/changeset/190212>
2249         (http://trac.webkit.org/changeset/190212)
2250
2251         I inadvertently did not remove the fullPlatform argument from one of the callers of archiveBuiltProduct().
2252
2253         * BuildSlaveSupport/built-product-archive:
2254         (main):
2255
2256 2015-09-24  Daniel Bates  <dabates@apple.com>
2257
2258         Support running unit tests on iOS Simulator test bot
2259         https://bugs.webkit.org/show_bug.cgi?id=149536
2260
2261         Reviewed by Alexey Proskuryakov.
2262
2263         Implements support for running unit tests on a iOS test bot. At the time of writing,
2264         the script run-api-tests supports running unit tests on Mac, Windows and iOS Simulator.
2265
2266         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2267         (RunUnitTests.start): Append appropriate command line flag when invoking script run-api-tests.
2268         (TestFactory.__init__): Add step RunUnitTests when the test bot is for the iOS Simulator platform.
2269
2270 2015-09-24  Daniel Bates  <dabates@apple.com>
2271
2272         Add support infrastructure for OpenSource iOS builders and testers
2273         https://bugs.webkit.org/show_bug.cgi?id=149534
2274
2275         Reviewed by Darin Adler.
2276
2277         Towards setting up OpenSource iOS build bots, teach buildbot and its support
2278         scripts about iOS.
2279
2280         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2281         (appendCustomBuildFlags): Require the caller to pass parameter fullPlatform and append
2282         --ios-simulator or --device for a builder/tester whose full platform name begins with
2283         "ios-simulator" or "ios", respectively.
2284         (RunJavaScriptCoreTests.start): Pass the full platform name to appendCustomBuildFlags().
2285         * BuildSlaveSupport/built-product-archive:
2286         (main): Pass the full platform name to determineWebKitBuildDirectory().
2287         (determineWebKitBuildDirectory): Call script webkit-build-directory with the appropriate
2288         command line flag when building for iOS.
2289         (archiveBuiltProduct): Use the same logic for iOS as we do for Mac. Also, remove unused
2290         parameter fullPlatform. This parameter was originally added in r125066 to support the
2291         Chromium Android port, which has since been removed from the OpenSource WebKit Project.
2292         (extractBuiltProduct): Use the same logic for iOS as we do for Mac.
2293         * BuildSlaveSupport/clean-build:
2294         (main): Call script webkit-build-directory with the appropriate command line flag when
2295         building for iOS.
2296         * BuildSlaveSupport/delete-stale-build-files:
2297         (main): Use the same logic for iOS as we do for Mac.
2298         (webkitBuildDirectory): Call script webkit-build-directory with the appropriate command line
2299         flag when building for iOS.
2300         * BuildSlaveSupport/test-result-archive:
2301         (archiveTestResults): Use the same logic for iOS as we do for Mac.
2302
2303 2015-09-24  Daniel Bates  <dabates@apple.com>
2304
2305         Remove Chromium-specific changes to script built-product-archive
2306         https://bugs.webkit.org/show_bug.cgi?id=149530
2307
2308         Rubber-stamped by Csaba Osztrogonác.
2309
2310         Reverts changes made in r113074 and r113067 to support Chromium testers. The
2311         Chromium code has long since been removed from the OpenSource WebKit Project.
2312
2313         * BuildSlaveSupport/built-product-archive:
2314         (createZipManually):
2315         (createZip):
2316         (archiveBuiltProduct):
2317
2318 2015-09-24  Dan Bernstein  <mitz@apple.com>
2319
2320         Build fix.
2321
2322         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2323
2324 2015-09-24  Mark Lam  <mark.lam@apple.com>
2325
2326         Unreviewed. Make Lucas Forschler a WebKit reviewer.
2327
2328         * Scripts/webkitpy/common/config/contributors.json:
2329
2330 2015-09-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2331
2332         Unreviewed. Fix GObject DOM API breaks after r190120.
2333
2334         Bring back code removed in r169931 to handle documentation of
2335         deleted classes.
2336
2337         * gtk/webkitdom.py:
2338         (WebKitDOMDocGenerator):
2339         (WebKitDOMDocGenerator.write_deleted_classes):
2340         (WebKitDOMDocGenerator.generate):
2341         (write_deleted_classes):
2342         (WebKitDOMDocGeneratorSections._deleted_class):
2343         (WebKitDOMDocGeneratorSections._deleted_class.in):
2344         (WebKitDOMDocGeneratorSections.write_deleted_classes):
2345         (WebKitDOMDocGeneratorSections.write_deleted_classes.with):
2346
2347 2015-09-23  Myles C. Maxfield  <mmaxfield@apple.com>
2348
2349         [Cocoa] [Font Features] Implement font-variant-*
2350         https://bugs.webkit.org/show_bug.cgi?id=148413
2351
2352         Reviewed by Darin Adler.
2353
2354         Update test font to use "lnum" feature.
2355
2356         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
2357         (Generator::appendGSUBTable):
2358
2359 2015-09-22  Andy Estes  <aestes@apple.com>
2360
2361         ContentFiltering.AllowDownloadAfterAddData is very flaky
2362         https://bugs.webkit.org/show_bug.cgi?id=148885
2363         <rdar://problem/22729563>
2364
2365         Reviewed by Alexey Proskuryakov.
2366
2367         The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:,
2368         but there is no guarantee of this. For tests that should allow a download, spin the runloop until
2369         -_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures.
2370
2371         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2372         (downloadTest):
2373
2374 2015-09-22  Alexey Proskuryakov  <ap@apple.com>
2375
2376         Mavericks: Media tests start to time out after a few days of bot uptime
2377         https://bugs.webkit.org/show_bug.cgi?id=149468
2378
2379         Reviewed by Chris Dumez.
2380
2381         * Scripts/webkitpy/port/base.py:
2382         * Scripts/webkitpy/port/driver.py:
2383         * Scripts/webkitpy/port/mac.py:
2384
2385 2015-09-22  Nan Wang  <n_wang@apple.com>
2386
2387         Unreviewed, add myself to the committers list.
2388
2389         * Scripts/webkitpy/common/config/contributors.json:
2390
2391 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
2392
2393         Remove 'nullable' to fix older iOS builds.
2394
2395         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2396         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
2397
2398 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
2399
2400         [Win] Show tiled drawing debug overlay on Windows
2401         https://bugs.webkit.org/show_bug.cgi?id=149426
2402
2403         Reviewed by Dean Jackson.
2404
2405         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Add new menu option.
2406         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Ditto.
2407         * MiniBrowser/win/Common.cpp:
2408         (::ToggleMenuItem): Recognize new menu item and toggle the 'showTiledScrollingIndicator'
2409         flag if needed.
2410         * MiniBrowser/win/MiniBrowser.h: Update to use new IWebPreferencesPrivate3 class.
2411
2412 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
2413
2414         [Win] Use command-line argument to launch in regular or High DPI mode.
2415         https://bugs.webkit.org/show_bug.cgi?id=149417
2416
2417         Reviewed by Dean Jackson.
2418
2419         * MiniBrowser/win/Common.cpp:
2420         (parseCommandLine): Ignore the '--highDPI' argument. It's used at the
2421         very start of execution, before the MiniBrowser.dll is loaded.
2422         * win/DLLLauncher/DLLLauncherMain.cpp:
2423         (shouldUseHighDPI): Check for '--highDPI', and use this mode if
2424         present. On WinCairo, always use High DPI.
2425
2426 2015-09-21  Ryosuke Niwa  <rniwa@webkit.org>
2427
2428         32-bit Mac build fix attempt after r190065.
2429
2430         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2431
2432 2015-09-21  Alexey Proskuryakov  <ap@apple.com>
2433
2434         [OS X] Update for Xcode 7.0 on Yosemite
2435         https://bugs.webkit.org/show_bug.cgi?id=149389
2436
2437         Reviewed by Dan Bernstein.
2438
2439         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
2440         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
2441         Removed unneeded declarations - conforming to a protocol is sufficient.
2442
2443         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2444         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
2445         Changed the definitions to be compiled whenever the SDK requires it (so we will have
2446         dead code compiled in when building for 10.10 with 10.11 SDK, somewhat unfortunately).
2447
2448 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
2449
2450         Add the ability for tests to run script in the UI process in WebKitTestRunner
2451         https://bugs.webkit.org/show_bug.cgi?id=149356
2452
2453         Reviewed by Tim Horton.
2454
2455         This change adds testRunner.runUIScript(script, callback), which allows a test
2456         to execute script in a JSContext which runs in the UI process. That context
2457         has bindings exposed through the UIScriptController interface; currently one test
2458         function, and some iOS-specific functions are included. UIScriptController can be
2459         async with a callback, and runUIScript() itself is asynchronous. When the UI
2460         script is complete, it calls uiController.uiScriptComplete(result), where 'result'
2461         is a string passed back to the web process, and given to the runUIScript()
2462         callback function.
2463
2464         Thanks to Gyuyoung Kim for help with the Gtk/Efl build.
2465
2466         * WebKitTestRunner/DerivedSources.make: Build UIScriptController.idl.
2467         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add runUIScript().
2468         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2469         (WTR::InjectedBundle::didReceiveMessageToPage): When the UI-side script is
2470         complete, call back into TestRunner.
2471         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2472         (WTR::nextUIScriptCallbackID):
2473         (WTR::TestRunner::runUIScript): Post a message to the injected bundle to run the UI script.
2474         (WTR::TestRunner::runUIScriptCallback): When the UI script is done, execute its callback function.
2475         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2476         * WebKitTestRunner/PlatformWebView.h:
2477         * WebKitTestRunner/TestController.cpp:
2478         (WTR::updateTestOptionsFromTestHeader):
2479         (WTR::TestController::testOptionsForTest): Support "useFlexibleViewport" as a test argument.
2480         (WTR::shouldUseFixedLayout): Deleted. Moved to a TestInvocation function.
2481         * WebKitTestRunner/TestInvocation.cpp:
2482         (WTR::TestInvocation::shouldUseFixedLayout):
2483         (WTR::TestInvocation::shouldUseThreadedScrolling):
2484         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2485         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2486         (WTR::TestInvocation::runUISideScript): Run the UI-side script!
2487         (WTR::TestInvocation::uiScriptDidComplete): Send a message back to the injected bundle.
2488         * WebKitTestRunner/TestInvocation.h:
2489         * WebKitTestRunner/TestOptions.h:
2490         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2491         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2492         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
2493         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Added.
2494         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
2495         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
2496         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
2497         (-[TestRunnerWKWebView onDidEndZooming:]): Allow a test to hook into the end of zooming.
2498         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2499         (WTR::PlatformWebView::PlatformWebView): Make a TestRunnerWKWebView on iOS.
2500         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Added.
2501         (WTR::UIScriptController::doAsyncTask):
2502         (WTR::UIScriptController::zoomToScale):
2503         (WTR::UIScriptController::zoomScale):
2504         (WTR::UIScriptController::minimumZoomScale):
2505         (WTR::UIScriptController::maximumZoomScale):
2506         (WTR::UIScriptController::contentVisibleRect):
2507         * WebKitTestRunner/mac/EventSenderProxy.mm:
2508         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2509         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Deleted.
2510         * WebKitTestRunner/mac/TestControllerMac.mm:
2511         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2512         (WTR::shouldUseThreadedScrolling): Deleted. Moved to TestInvocation.
2513         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
2514         * WebKitTestRunner/uiscriptcontext/UIScriptContext.cpp: Added. Owns the JS context in the UI process.
2515         (UIScriptContext::UIScriptContext):
2516         (UIScriptContext::~UIScriptContext):
2517         (UIScriptContext::runUIScript): Entrypoint to running the UI script. If the script didn't do anything
2518         asynchronous, call the callback.
2519         (UIScriptContext::nextTaskCallbackID):
2520         (UIScriptContext::prepareForAsyncTask): Do setup for one async task (i.e. a UIScriptController function
2521         that has a callback). Has to store the callbackID of the script, so code called from the completion
2522         callback knows which UI script invoked it.
2523         (UIScriptContext::asyncTaskComplete): Called when one task is finished.
2524         (UIScriptContext::uiScriptComplete):
2525         (UIScriptContext::objectFromRect): Make a JS object from a rect.
2526         * WebKitTestRunner/uiscriptcontext/UIScriptContext.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
2527         (WTR::UIScriptContext::hasOutstandingAsyncTasks):
2528         * WebKitTestRunner/uiscriptcontext/UIScriptController.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
2529         (WTR::UIScriptController::UIScriptController):
2530         (WTR::UIScriptController::makeWindowObject):
2531         (WTR::UIScriptController::wrapperClass):
2532         (WTR::UIScriptController::doAsyncTask):
2533         (WTR::UIScriptController::zoomToScale):
2534         (WTR::UIScriptController::zoomScale):
2535         (WTR::UIScriptController::minimumZoomScale):
2536         (WTR::UIScriptController::maximumZoomScale):
2537         (WTR::UIScriptController::contentVisibleRect):
2538         (WTR::UIScriptController::uiScriptComplete):
2539         * WebKitTestRunner/uiscriptcontext/UIScriptController.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
2540         (WTR::UIScriptController::create):
2541         * WebKitTestRunner/uiscriptcontext/bindings/UIScriptController.idl: Copied from Tools/WebKitTestRunner/TestOptions.h.
2542
2543 2015-09-21  Tim Horton  <timothy_horton@apple.com>
2544
2545         Turn on threaded scrolling by default in the tests
2546         https://bugs.webkit.org/show_bug.cgi?id=149377
2547
2548         Reviewed by Simon Fraser.
2549
2550         * WebKitTestRunner/mac/TestControllerMac.mm:
2551         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2552         (WTR::shouldUseThreadedScrolling): Deleted.
2553         Turn on threaded scrolling by default.
2554
2555 2015-09-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2556
2557         [GTK] run-gtk-tests doesn't provide feedback about crashing google tests
2558         https://bugs.webkit.org/show_bug.cgi?id=149252
2559
2560         Reviewed by Darin Adler.
2561
2562         In case of glib tests the test runner notifies about tests
2563         crashing, but for google tests we don't get any feedback, which
2564         means that in case of a test crashing we get a list of **PASS**
2565         messages and at the summary we are notified that the test suite
2566         has failed, but it's impossible to know which test cases have failed.
2567
2568         * Scripts/run-gtk-tests:
2569         (TestRunner._run_google_test): Add a **CRASH** message if test
2570         case crashed.
2571
2572 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
2573
2574         WebKitTestRunner can leak user content script results between tests
2575         https://bugs.webkit.org/show_bug.cgi?id=149391
2576
2577         Reviewed by Sam Weinig.
2578
2579         Move WKBundlePageRemoveAllUserContent call so that it's executed before loading
2580         about:blank, and thus about:blank doesn't have unintended side effects.
2581
2582         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2583         (WTR::InjectedBundle::beginTesting):
2584         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2585         (WTR::InjectedBundlePage::resetAfterTest):
2586
2587 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
2588
2589         [Mac, iOS] AccessibilityController doesn't uninstall global notification handler
2590         https://bugs.webkit.org/show_bug.cgi?id=149384
2591
2592         Reviewed by Chris Fleizach.
2593
2594         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2595         (AccessibilityController::addNotificationListener): Fixed a leak, and cleaned up the code.
2596         (AccessibilityController::platformResetToConsistentState): Actually remove the handler,
2597         regardless of whether someone else holds a reference (we also call -stopListening in
2598         -dealloc).
2599
2600         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2601         (AccessibilityController::platformResetToConsistentState):
2602         (AccessibilityController::addNotificationListener):
2603         Ditto.
2604
2605 2015-09-20  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2606
2607         Remove XHR_TIMEOUT compilation guard
2608         https://bugs.webkit.org/show_bug.cgi?id=149260
2609
2610         Reviewed by Benjamin Poulain.
2611
2612         * Scripts/webkitperl/FeatureList.pm:
2613
2614 2015-09-19  Dan Bernstein  <mitz@apple.com>
2615
2616         Attempted build fix.
2617
2618         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2619
2620 2015-09-18  Commit Queue  <commit-queue@webkit.org>
2621
2622         Unreviewed, rolling out r189908.
2623         https://bugs.webkit.org/show_bug.cgi?id=149368
2624
2625         Broke run-webkit-tests --pixel (Requested by ap on #webkit).
2626
2627         Reverted changeset:
2628
2629         "printing does not use minimum page zoom factor"
2630         https://bugs.webkit.org/show_bug.cgi?id=108507
2631         http://trac.webkit.org/changeset/189908
2632
2633 2015-09-18  Andy Estes  <aestes@apple.com>
2634
2635         [iOS] did{Start,Finish}LoadForQuickLookDocumentInMainFrame is never called on WKNavigationDelegate
2636         https://bugs.webkit.org/show_bug.cgi?id=149360
2637
2638         Reviewed by Tim Horton.
2639
2640         Added an API test.
2641
2642         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2643         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Added.
2644         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2645         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2646         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]):
2647         (TEST):
2648         * TestWebKitAPI/ios/pages.pages: Added.
2649
2650 2015-09-18  Nan Wang  <n_wang@apple.com>
2651
2652         AX: Implement ARIA 1.1 @aria-current on iOS
2653         https://bugs.webkit.org/show_bug.cgi?id=149297
2654
2655         Reviewed by Chris Fleizach.
2656
2657         Added support to test aria-current on iOS.
2658
2659         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2660         (AccessibilityUIElement::stringAttributeValue):
2661         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2662         (WTR::AccessibilityUIElement::stringAttributeValue):
2663
2664 2015-09-18  Alexey Proskuryakov  <ap@apple.com>
2665
2666         iOS WebKitTestRunner frequently crashes in WKContextGetIconDatabase
2667         https://bugs.webkit.org/show_bug.cgi?id=149352
2668
2669         Reviewed by Simon Fraser.
2670
2671         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
2672         m_context can be null. This may indicate a bug in webkitpy too, but
2673         WebKitTestRunner should handle this situation nicely, there is nothing intrinsically
2674         wrong with opening and immediately closing it.
2675
2676 2015-09-18  Daniel Bates  <dabates@apple.com>
2677
2678         isGitSVNDirectory() returns true when Git is not installed
2679         https://bugs.webkit.org/show_bug.cgi?id=149351
2680
2681         Reviewed by Alexey Proskuryakov.
2682
2683         Fixes an issue where VCSUtils::isGitSVNDirectory() returns true for any arbitrary directory if
2684         Git is not installed on the machine.
2685
2686         * Scripts/VCSUtils.pm:
2687         (isGitSVNDirectory): Ensure that `git config --get svn-remote.svn.fetch 2>& 1` exits with
2688         status code 0 (success).
2689
2690 2015-09-18  Alex Christensen  <achristensen@webkit.org>
2691
2692         Prevent build-webkit from building four times on Windows
2693         https://bugs.webkit.org/show_bug.cgi?id=149336
2694
2695         Reviewed by Brent Fulgham.
2696
2697         * Scripts/build-webkit:
2698         Move the Windows code out of the for loop iterating over each subdirectory to be build.
2699         They're built all at once.
2700         * Scripts/webkitdirs.pm:
2701         (buildVisualStudioProject):
2702         (cmakeGeneratedBuildfile):
2703         Don't generate the Visual Studio solution if it already exists.
2704         It will run CMake again if necessary.
2705
2706 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
2707
2708         [iOS WK2] WTR fails to set the key window in the UIKit sense
2709         https://bugs.webkit.org/show_bug.cgi?id=149325
2710
2711         Reviewed by Tim Horton.
2712
2713         -[WebKitTestRunnerWindow isKeyWindow] just returned _platformWebView->windowIsKey().
2714         This causes UIKit to bypass code that actually sets the key window, resulting in
2715         [UIAppliation sharedApplication].keyWindow always being nil.
2716
2717         Fix by PlatformWebView::setWindowIsKey() actually call -makeKeyWindow, and having
2718         -[WebKitTestRunnerWindow isKeyWindow] call super.
2719
2720         * WebKitTestRunner/PlatformWebView.h:
2721         (WTR::PlatformWebView::setWindowIsKey): Deleted.
2722         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2723         (WTR::PlatformWebView::setWindowIsKey):
2724         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2725         (WTR::PlatformWebView::setWindowIsKey):
2726         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2727         (-[WebKitTestRunnerWindow isKeyWindow]):
2728         (WTR::PlatformWebView::PlatformWebView):
2729         (WTR::PlatformWebView::~PlatformWebView):
2730         (WTR::PlatformWebView::setWindowIsKey):
2731         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2732         (WTR::PlatformWebView::setWindowIsKey):
2733
2734 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
2735
2736         [iOS WK2] When loading viewport tests, use the normal web page viewport configuration
2737         https://bugs.webkit.org/show_bug.cgi?id=149321
2738
2739         Reviewed by Tim Horton.
2740
2741         InjectedBundlePage::platformDidStartProvisionalLoadForFrame() unconditionally
2742         enabled the "testing" viewport configuration, which disables page scaling.
2743
2744         If we're running viewport tests, we want the normal web page configuration.
2745         Do that by passing a flag in the dictionary sent to InjectedBundle::beginTesting(),
2746         based on whether the test is in a "viewport" directory.
2747
2748         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2749         (WTR::InjectedBundle::beginTesting):
2750         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2751         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Deleted.
2752         * WebKitTestRunner/TestInvocation.cpp:
2753         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
2754         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
2755         (WTR::TestInvocation::shouldMakeViewportFlexible):
2756         (WTR::TestInvocation::invoke):
2757         * WebKitTestRunner/TestInvocation.h:
2758         * WebKitTestRunner/ios/TestControllerIOS.mm:
2759         (WTR::TestController::platformConfigureViewForTest):
2760         (WTR::shouldMakeViewportFlexible): Deleted.
2761
2762 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
2763
2764         Give iOS WebKitTestRunner a launch storyboard
2765         https://bugs.webkit.org/show_bug.cgi?id=149314
2766
2767         Reviewed by Dan Bates.
2768
2769         Add a launch storyboard to iOS WebKitTestRunner so that Springboard recognizes
2770         that it's been built for specific device configurations, and puts the window
2771         at the top of the screen. This simplifies coordinate conversions in a future patch.
2772
2773         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2774         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
2775         * WebKitTestRunner/ios/Launch.storyboard: Added.
2776
2777 2015-09-17  Myles C. Maxfield  <mmaxfield@apple.com>
2778
2779         Update licence in r189890
2780         https://bugs.webkit.org/show_bug.cgi?id=149306
2781
2782         Reviewed by Dean Jackson.
2783
2784         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
2785         * FontWithFeatures/FontWithFeatures/FontCreator.h:
2786         * FontWithFeatures/FontWithFeatures/main.cpp:
2787
2788 2015-09-17  Mark Lam  <mark.lam@apple.com>
2789
2790         Add the ability to skip JIT stress tests in run-javascriptcore-tests.
2791         https://bugs.webkit.org/show_bug.cgi?id=149285
2792
2793         Reviewed by Saam Barati.
2794
2795         Just need to add an option to pass --no-jit to run-jsc-stress-test.
2796
2797         * Scripts/run-javascriptcore-tests:
2798         (runJSCStressTests):
2799
2800 2015-09-17  Alex Christensen  <achristensen@webkit.org>
2801
2802         Switch AppleWin build to use CMake
2803         https://bugs.webkit.org/show_bug.cgi?id=149163
2804
2805         Reviewed by Brent Fulgham.
2806
2807         * Scripts/build-webkit:
2808         * Scripts/run-api-tests:
2809         (runTest):
2810         (listAllTests):
2811         (prepareEnvironmentForRunningTestTool):
2812         (testToolPaths):
2813         (testToolPath): Deleted.
2814         Run the API tests as separate executables on Windows.
2815         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
2816         * Scripts/webkitdirs.pm:
2817         (checkRequiredSystemConfig):
2818         (jhbuildWrapperPrefixIfNeeded):
2819         (generateBuildSystemFromCMakeProject):
2820         Fix configuration quirks.
2821
2822 2015-09-17  Dean Johnson  <dean_johnson@apple.com>
2823
2824         Added toggle options for hiding and showing certain platform families on the dashboard.
2825         https://bugs.webkit.org/show_bug.cgi?id=148403
2826
2827         Reviewed by David Kilzer.
2828
2829         This patch removes "hiddenPlatforms" from use in the code and local storage. We also removed
2830         individual hide/show buttons for platforms because we've added toggle options to hide/show entire
2831         families. Examples of these are "mac", "ios", and "linux". "Show All Platforms" was also removed
2832         in lieu of an "all" button in the toggle menu.
2833
2834         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2835         (parsePlatformFamily): Helper function to parse out a platform family.
2836         (initPlatformsByFamily): Initializes platformsByFamily, which organizes platforms on the
2837         page by platformsByFamily[<family>] = <list of platforms belonging to that family>.
2838         (updateToggleButtons): Updates the status of the toggle buttons.
2839         (updateHiddenPlatforms): Changed to work with the new implementation of hiding/showing platforms.
2840         (documentReady): Added creation of toggle buttons.
2841         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2842         (unhiddenQueues): Updated to search by platform family instead of the individual platform name.
2843         (documentReady): Changed hiddenPlatforms => hiddenPlatformFamilies.
2844         (updateHiddenPlatforms): Deleted. After removing the individual hide button code,
2845         this did the exact same thing as the updateHiddenPlatforms in Scripts/Main.js so it was removed.
2846         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
2847         (QueueView): Updated to use hiddenPlatformFamilies.
2848         (QueueView.prototype._updateHiddenState): Updated to use hiddenPlatformFamilies.
2849         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
2850         (Settings.prototype.toggleHiddenPlatformFamily): Renamed function and some variables.
2851         (Settings.prototype.clearHiddenPlatformFamilies): Now uses hiddenPlatformFamilies for events.
2852         (Settings.prototype.toggleHiddenPlatform): Deleted.
2853         (Settings.prototype.clearHiddenPlatforms): Deleted.
2854         (Settings.prototype.toggleShowPlatformFamily): Deleted.
2855         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2856         (div.cellButton, div.accessibilityButton, div.platformFamilyToggleButton):
2857         (div.cellButton.unhide, div.accessibilityButton.unhide, div.platformFamilyToggleButton.unhide):
2858         (.settings-visible div.settingsWrapper.hide, .settings-visible div.settingsWrapper):
2859         (table.queue-grid tr.headers th):
2860         (div.settingsWrapper.hide):
2861         (div.settingsWrapper):
2862         (div.familyToggleWrapper):
2863         (div.platformFamilyToggleButton):
2864         (div.platformFamilyShowToggleButton:not(:last-child)):
2865         (div.familyShown):
2866         (div.accessibilityButton):
2867         (div.cellButton, div.accessibilityButton): Added platformFamilyToggleButton class.
2868         (div.cellButton.unhide, div.accessibilityButton.unhide): Added platformFamilyToggleButton class.
2869         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide): Added
2870         platformFamilyToggleButton and settingsWrapper class.
2871         (.accessibilityButton): Deleted.
2872
2873 2015-09-17  Tim Horton  <timothy_horton@apple.com>
2874
2875         Add a test ensuring that scrolling in the middle of a page can't start a swipe gesture
2876         https://bugs.webkit.org/show_bug.cgi?id=148904
2877
2878         Reviewed by Myles Maxfield.
2879
2880         * WebKitTestRunner/TestController.cpp:
2881         (WTR::parseBooleanTestHeaderValue):
2882         (WTR::updateViewOptionsFromTestHeader):
2883         Check for the key "useThreadedScrolling".
2884         Add some code to check for "true" and "false" for boolean options.
2885
2886         (WTR::TestController::viewOptionsForTest):
2887         Apply the test's overrides last, even after the platform's.
2888
2889 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2890
2891         printing does not use minimum page zoom factor
2892         https://bugs.webkit.org/show_bug.cgi?id=108507
2893
2894         Reviewed by Darin Adler.
2895
2896         WebKitTestRunner always takes the snapshots from the UI process
2897         (expect for IOS), so in the case of printing, the layout in the
2898         web view is not the expected one. When printing, we need to take
2899         the snapshot in the web process and ensure it's rendered with a
2900         PrintContext.
2901
2902         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2903         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
2904         kWKSnapshotOptionsPrinting option to
2905         WKBundlePageCreateSnapshotWithOptions() when printing. When not
2906         printing, don't even create the snapshot, since it will be ignored
2907         by the UI process that always creates its own from the WebView (expect for IOS platform)
2908         * WebKitTestRunner/TestInvocation.cpp:
2909         (WTR::TestInvocation::dumpResults): Use always the snapshot image
2910         received from the web process if any when comparing pixel
2911         results. Now we only receive a snapshot from the web process in
2912         case of printing, or when platform is IOS. Otherwhise, generate
2913         the snapshot from the WebView as usual.
2914         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
2915         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
2916         is created by the caller now, but the CG implementation needs to
2917         know if it's a Web or UI process snapshot.
2918         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2919         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2920         cairo surface for the given image.
2921         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2922         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2923         CGContext for the given image.
2924
2925 2015-09-16  Myles C. Maxfield  <mmaxfield@apple.com>
2926
2927         Create a font which can be used for testing font features
2928         https://bugs.webkit.org/show_bug.cgi?id=149237
2929
2930         Reviewed by Simon Fraser.
2931
2932         This patch adds a new project in the Tools/ directory which generates a font which can
2933         be used for testing font features. This is a standalone project consisting of two files:
2934         1. A file which actually generates the byte vector representing the font. This file has
2935         a single public function: std::vector<uint8_t> generateFont(). This file is not platform
2936         specific, and only relies on the C++ STL.
2937         2. A file with a main() which calls generateFont() and writes out the font, as well as
2938         uses the font to render some demonstration text into a .png file. This file is platform
2939         specific.
2940
2941         The font itself only supports the following characters:
2942         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
2943         However, the shape of these letters are either an X or a check mark.
2944
2945         The letter "A" always is a check mark.
2946         The letter "B" always is an X.
2947         Without any font features turned on, the rest of the letters are shown as X.
2948
2949         Each font feature has an letter associated with it. When the font feature is enabled,
2950         that letter is shown as a check mark. For example, when "smcp" is enabled, "J" is shown
2951         as a check mark.
2952
2953         Here are the mappings of font features to letters:
2954         liga: C
2955         clig: D
2956         dlig: E
2957         hlig: F
2958         calt: G
2959         subs: H
2960         sups: I
2961         smcp: J
2962         c2sc: K
2963         pcap: L
2964         c2pc: M
2965         unic: N
2966         titl: O
2967         onum: P
2968         pnum: Q
2969         tnum: R
2970         frac: S
2971         afrc: T
2972         ordn: U
2973         zero: V
2974         hist: W
2975         jp78: X
2976         jp83: Y
2977         jp90: Z
2978         jp04: a
2979         smpl: b
2980         trad: c
2981         fwid: d
2982         pwid: e
2983         ruby: f
2984
2985         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj: Added.
2986         * FontWithFeatures/FontWithFeatures/FontCreator.cpp: Added.
2987         (integralLog2):
2988         (roundDownToPowerOfTwo):
2989         (isFourByteAligned):
2990         (clampTo):
2991         (append32):
2992         (writeCFFEncodedNumber):
2993         (CFFBuilder::CFFBuilder):
2994         (CFFBuilder::takeResult):
2995         (CFFBuilder::moveTo):
2996         (CFFBuilder::lineTo):
2997         (CFFBuilder::curveToCubic):
2998         (CFFBuilder::closePath):
2999         (CFFBuilder::writePoint):
3000         (generateBoxCharString):
3001         (generateCheckCharString):
3002         (generateXCharString):
3003         (charStringForGlyph):
3004         (Generator::generate):
3005         (Generator::Placeholder::Placeholder):
3006         (Generator::Placeholder::populate):
3007         (Generator::Placeholder::~Placeholder):
3008         (Generator::placeholder):
3009         (Generator::append16):
3010         (Generator::append32):
3011         (Generator::append32BitCode):
3012         (Generator::overwrite16):
3013         (Generator::overwrite32):
3014         (Generator::appendCFFTable):
3015         (Generator::appendSubstitutionSubtable):
3016         (Generator::appendScriptSubtable):
3017         (Generator::appendGSUBTable):
3018         (Generator::appendOS2Table):
3019         (Generator::appendFormat12CMAPTable):
3020         (Generator::appendFormat4CMAPTable):
3021         (Generator::appendCMAPTable):
3022         (Generator::appendHEADTable):
3023         (Generator::appendHHEATable):
3024         (Generator::appendHMTXTable):
3025         (Generator::appendMAXPTable):
3026         (Generator::appendNAMETable):
3027         (Generator::appendPOSTTable):
3028         (Generator::calculateChecksum):
3029         (Generator::appendTable):
3030         (generateFont):
3031         * FontWithFeatures/FontWithFeatures/FontCreator.h: Added.
3032         * FontWithFeatures/FontWithFeatures/main.cpp: Added.
3033         (drawTextWithFeature):
3034         (main):
3035
3036 2015-09-16  Commit Queue  <commit-queue@webkit.org>
3037
3038         Unreviewed, rolling out r189875 and r189878.
3039         https://bugs.webkit.org/show_bug.cgi?id=149235
3040
3041         cygwin cmake build not ready yet (Requested by alexchristensen
3042         on #webkit).
3043
3044         Reverted changesets:
3045
3046         "Switch AppleWin build to use CMake"
3047         https://bugs.webkit.org/show_bug.cgi?id=149163
3048         http://trac.webkit.org/changeset/189875
3049
3050         "Cygwin build fix after r189875"
3051         http://trac.webkit.org/changeset/189878
3052
3053 2015-09-16  Alex Christensen  <achristensen@webkit.org>
3054
3055         Cygwin build fix after r189875
3056
3057         * Scripts/build-webkit:
3058         * Scripts/webkitdirs.pm:
3059         (jhbuildWrapperPrefixIfNeeded):
3060         (generateBuildSystemFromCMakeProject):
3061         Make things work with cygwin and cmake.
3062
3063 2015-09-16  Alex Christensen  <achristensen@webkit.org>
3064
3065         Switch AppleWin build to use CMake
3066         https://bugs.webkit.org/show_bug.cgi?id=149163
3067
3068         Reviewed by Brent Fulgham.
3069
3070         * Scripts/build-webkit:
3071         Build with CMake.
3072         * Scripts/run-api-tests:
3073         (runTest):
3074         (listAllTests):
3075         (prepareEnvironmentForRunningTestTool):
3076         (testToolPaths):
3077         (testToolPath): Deleted.
3078         Run the API tests as separate executables on Windows.
3079         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
3080
3081 2015-09-16  Alexey Proskuryakov  <ap@apple.com>
3082
3083         Add newer build.webkit.org pages to robots.txt
3084         https://bugs.webkit.org/show_bug.cgi?id=149219
3085
3086         Reviewed by Darin Adler.
3087
3088         Indexing bot watcher's dashboard can't be good.
3089
3090         * BuildSlaveSupport/build.webkit.org-config/public_html/robots.txt:
3091
3092 2015-09-16  Alex Christensen  <achristensen@webkit.org>
3093
3094         Rollout r189851 and 189853 because they didn’t actually fix the permissions issue
3095
3096         * BuildSlaveSupport/built-product-archive:
3097         (unzipArchive):
3098
3099 2015-09-16  Csaba Osztrogonác  <ossy@webkit.org>
3100
3101         [EFL] Fix the help message of separated web process option of MiniBrowser
3102         https://bugs.webkit.org/show_bug.cgi?id=149212
3103
3104         Reviewed by Gyuyoung Kim.
3105
3106         * MiniBrowser/efl/main.c:
3107
3108 2015-09-16  Alex Christensen  <achristensen@webkit.org>
3109
3110         Fix python syntax after r189851.
3111
3112         * BuildSlaveSupport/built-product-archive:
3113         (unzipArchive):
3114         For loops need a colon.
3115
3116 2015-09-15  Alex Christensen  <achristensen@webkit.org>
3117
3118         Fix Windows test bots after changing to non-cygwin build
3119         https://bugs.webkit.org/show_bug.cgi?id=149196
3120
3121         Reviewed by Daniel Bates.
3122
3123         * BuildSlaveSupport/built-product-archive:
3124         (unzipArchive):
3125         Using different versions of python makes what I think is https://bugs.python.org/issue15795
3126         prevent us from executing files from the archive on the test bots.
3127
3128 2015-09-15  Ryosuke Niwa  <rniwa@webkit.org>
3129
3130         Add ShadowRoot interface and Element.prototype.attachShadow
3131         https://bugs.webkit.org/show_bug.cgi?id=149187
3132
3133         Reviewed by Antti Koivisto.
3134
3135         * Scripts/webkitperl/FeatureList.pm:
3136
3137 2015-09-15  Aakash Jain  <aakash_jain@apple.com>
3138
3139         Appscale queue status json output lacks bots
3140         https://bugs.webkit.org/show_bug.cgi?id=149194
3141         <rdar://problem/22171089>
3142
3143         Reviewed by Alexey Proskuryakov.
3144
3145         * QueueStatusServer/handlers/queuestatusjson.py:
3146         (QueueStatusJSON._bots): Order the results by date so as to get latest events, this was default in AppEngine.
3147         * QueueStatusServer/index.yaml: Index according to appscale requirements.
3148
3149 2015-09-15  Brent Fulgham  <bfulgham@apple.com>
3150
3151         [Win] Provide a means for viewing the layer tree
3152         https://bugs.webkit.org/show_bug.cgi?id=149165
3153
3154         Reviewed by Simon Fraser.
3155
3156         Update MiniBrowser with a new Debug menu option that will
3157         dump the current layer tree to the debug console.
3158
3159         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc:
3160         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h:
3161         * MiniBrowser/win/Common.cpp:
3162         (WndProc): Add handler for 'Print Layer Tree' menu option.
3163         * MiniBrowser/win/MiniBrowser.cpp:
3164         (MiniBrowser::printLayerTree): Added Handler.
3165         * MiniBrowser/win/MiniBrowser.h:
3166
3167 2015-09-14  Myles C. Maxfield  <mmaxfield@apple.com>
3168
3169         WebKitTestRunner declarative language setting is broken for iOS
3170         https://bugs.webkit.org/show_bug.cgi?id=149119
3171
3172         Unreviewed.
3173
3174         In all of the patches on webkit.org/b/189669, my patch to get this working on iOS was
3175         lost in the final version which got committed. This simply implements the existing
3176         OS X behavior on iOS.
3177
3178         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
3179         (WTR::InjectedBundle::platformInitialize):
3180
3181 2015-09-14  Dewei Zhu  <dewei_zhu@apple.com>
3182
3183         Unreviewed, add myself to committers list.
3184
3185         * Scripts/webkitpy/common/config/contributors.json:
3186
3187 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
3188
3189         [Cocoa] Allow testing with the system language
3190         https://bugs.webkit.org/show_bug.cgi?id=148671
3191
3192         Reviewed by Anders Carlsson and Alexey Proskuryakov.
3193
3194         React to tests marked with language=lang1,lang2,etc in their header.
3195         Once this information is parsed, pass it to
3196         WKContextConfigurationSetOverrideLanguages().
3197
3198         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3199         (WTR::InjectedBundle::platformInitialize): Don't clobber the language
3200         list.
3201         * WebKitTestRunner/TestController.cpp:
3202         (WTR::TestController::createWebViewWithOptions): Call
3203         WKContextConfigurationSetOverrideLanguages().
3204         (WTR::updateTestOptionsFromTestHeader): Inspect the language option.
3205         * WebKitTestRunner/TestOptions.h:
3206         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3207         (WTR::PlatformWebView::viewSupportsOptions): Cause a differing language
3208         option to restart the web process.
3209         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3210         (WTR::PlatformWebView::viewSupportsOptions): Ditto.
3211
3212 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
3213
3214         [WKTR] Allow changing the WKContextConfiguration between successive tests
3215         https://bugs.webkit.org/show_bug.cgi?id=148833
3216
3217         Reviewed by Tim Horton.
3218
3219         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
3220         However, there are certain tests which require specifying options in this object. This patch makes
3221         our existing code for recreating the test runner web view also recreate the WKContext.
3222
3223         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
3224         class.
3225
3226         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
3227         * WebKitTestRunner/PlatformWebView.h:
3228         (WTR::PlatformWebView::options):
3229         * WebKitTestRunner/TestController.cpp:
3230         (WTR::TestController::initialize):
3231         (WTR::TestController::generateContextConfiguration):
3232         (WTR::TestController::generatePageConfiguration):
3233         (WTR::TestController::createWebViewWithOptions):
3234         (WTR::TestController::ensureViewSupportsOptionsForTest):
3235         (WTR::updateContextConfigurationOptionsFromTestHeader):
3236         (WTR::TestController::contextConfigurationOptionsForTest):
3237         (WTR::TestController::platformCreateWebView):
3238         (WTR::TestController::platformCreateOtherPage):
3239         (WTR::updateViewOptionsFromTestHeader): Deleted.
3240         (WTR::TestController::viewOptionsForTest): Deleted.
3241         * WebKitTestRunner/TestController.h:
3242         (WTR::TestController::injectedBundlePath):
3243         (WTR::TestController::testPluginDirectory):
3244         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3245         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3246         (WTR::TestController::platformCreateWebView):
3247         (WTR::TestController::platformCreateOtherPage):
3248         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3249         (WTR::PlatformWebView::PlatformWebView):
3250         (WTR::PlatformWebView::viewSupportsOptions):
3251         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3252         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
3253         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
3254         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3255         (WTR::PlatformWebView::PlatformWebView):
3256         (WTR::PlatformWebView::viewSupportsOptions):
3257         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3258         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
3259         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
3260         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3261         (WTR::PlatformWebView::PlatformWebView):
3262         (WTR::PlatformWebView::viewSupportsOptions):
3263         * WebKitTestRunner/ios/TestControllerIOS.mm:
3264         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
3265         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
3266         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3267         (WTR::PlatformWebView::PlatformWebView):
3268         (WTR::PlatformWebView::viewSupportsOptions):
3269         * WebKitTestRunner/mac/TestControllerMac.mm:
3270         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
3271         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
3272
3273 2015-09-11  Michael Saboff  <msaboff@apple.com>
3274
3275         LayoutTestHelper crashes if a color profile isn't set for a 3rd party monitor
3276         https://bugs.webkit.org/show_bug.cgi?id=149083
3277
3278         Reviewed by Alexey Proskuryakov.
3279
3280         Check to make sure that we have a valid factoryProfile CFDictionaryRef before using it.
3281
3282         * DumpRenderTree/mac/LayoutTestHelper.m:
3283         (colorProfileURLForDisplay):
3284
3285 2015-09-11  Saam barati  <sbarati@apple.com>
3286
3287         There should be a defaultSpotCheck-like mode that doesn't run the MaximalFlushInsertionPhase in run-jsc-stress-tests
3288         https://bugs.webkit.org/show_bug.cgi?id=149058
3289
3290         Reviewed by Geoffrey Garen.
3291
3292         * Scripts/run-jsc-stress-tests:
3293
3294 2015-09-10  Commit Queue  <commit-queue@webkit.org>
3295
3296         Unreviewed, rolling out r189595.
3297         https://bugs.webkit.org/show_bug.cgi?id=149052
3298
3299         The tests still fail (Requested by ap on #webkit).
3300
3301         Reverted changeset:
3302
3303         "Spurious output on Windows tests: AQMEIOManager::FindIOUnit:
3304         error -1"
3305         https://bugs.webkit.org/show_bug.cgi?id=142929
3306         http://trac.webkit.org/changeset/189595
3307
3308 2015-09-10  Alexey Proskuryakov  <ap@apple.com>
3309
3310         Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
3311         https://bugs.webkit.org/show_bug.cgi?id=142929
3312
3313         Reviewed by Brent Fulgham.
3314
3315         Silence the logging. We'll track fixing the root cause in Radar.
3316
3317         * Scripts/webkitpy/port/mac.py:
3318         (MacPort.stderr_patterns_to_strip): Added a FIXME.
3319
3320         * Scripts/webkitpy/port/win.py:
3321         (WinPort.logging_patterns_to_strip): Added.
3322
3323 2015-09-09  Andy Estes  <aestes@apple.com>
3324
3325         [iOS] Teach run-webkit-tests how to parse simulator runtimes when version numbers contain a revision
3326         https://bugs.webkit.org/show_bug.cgi?id=149022
3327
3328         Reviewed by Daniel Bates.
3329
3330         Simulator runtime versions can contain a revision number (e.g. 8.4.1), but the regex for matching runtimes
3331         did not account for this.
3332
3333         * Scripts/webkitpy/xcode/simulator.py:
3334         (Simulator): Optionally matched a revision at the end of a runtime version number.
3335         * Scripts/webkitpy/xcode/simulator_unittest.py: Added a test.
3336
3337 2015-09-09  Andy Estes  <aestes@apple.com>
3338
3339         [iOS] Teach run-webkit-tests how to parse `simctl list` when a tvOS SDK is installed
3340         https://bugs.webkit.org/show_bug.cgi?id=149029
3341         <rdar://problem/22432624>
3342
3343         Reviewed by Daniel Bates.
3344
3345         * Scripts/webkitpy/xcode/simulator.py:
3346         (Simulator): Taught to parse tvOS runtimes.
3347         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
3348
3349 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
3350
3351         Fix bit rot on bot watcher's dashboard page
3352         https://bugs.webkit.org/show_bug.cgi?id=149012
3353
3354         Reviewed by Tim Horton.
3355
3356         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3357         The code path used by the metrics page was trying to add properties to an undefined.
3358
3359         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
3360         Silence an expection that would occur when the step has no logs. This should never
3361         happen, but it did (perhaps buildbot was misconfigured for a while).
3362
3363 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
3364
3365         Update LayoutTestRelay xcconfig file.
3366
3367         Rubber-stamped by Dan Bernstein.
3368
3369         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
3370
3371 2015-09-09  Saam barati  <sbarati@apple.com>
3372
3373         DFG should have a debugging option that runs a phase that flushes all locals
3374         https://bugs.webkit.org/show_bug.cgi?id=148916
3375
3376         Reviewed by Filip Pizlo.
3377
3378         * Scripts/run-jsc-stress-tests:
3379
3380 2015-09-09  Commit Queue  <commit-queue@webkit.org>
3381
3382         Unreviewed, rolling out r189530 and r189534.
3383         https://bugs.webkit.org/show_bug.cgi?id=148996
3384
3385         Caused assertion failures on Yosemite (Requested by litherum
3386         on #webkit).
3387
3388         Reverted changesets:
3389
3390         "[WKTR] Allow changing the WKContextConfiguration between
3391         successive tests"
3392         https://bugs.webkit.org/show_bug.cgi?id=148833
3393         http://trac.webkit.org/changeset/189530
3394
3395         "[Cocoa] Fix the tests after r189530"
3396         http://trac.webkit.org/changeset/189534
3397
3398 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
3399
3400         [Cocoa] Fix the tests after r189530
3401
3402         Unreviewed.
3403
3404         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3405         (WTR::initializeWebViewConfiguration):
3406
3407 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
3408
3409         [WKTR] Allow changing the WKContextConfiguration between successive tests
3410         https://bugs.webkit.org/show_bug.cgi?id=148833
3411
3412         Reviewed by Tim Horton.
3413
3414         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
3415         However, there are certain tests which require specifying options in this object. This patch makes
3416         our existing code for recreating the test runner web view also recreate the WKContext.
3417
3418         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
3419         class.
3420
3421         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
3422         * WebKitTestRunner/PlatformWebView.h:
3423         (WTR::PlatformWebView::options):
3424         * WebKitTestRunner/TestController.cpp:
3425         (WTR::TestController::initialize):
3426         (WTR::TestController::generateContextConfiguration):
3427         (WTR::TestController::generatePageConfiguration):
3428         (WTR::TestController::createWebViewWithOptions):
3429         (WTR::TestController::ensureViewSupportsOptionsForTest):
3430         (WTR::updateContextConfigurationOptionsFromTestHeader):
3431         (WTR::TestController::contextConfigurationOptionsForTest):
3432         (WTR::TestController::platformCreateWebView):
3433         (WTR::TestController::platformCreateOtherPage):
3434         (WTR::updateViewOptionsFromTestHeader): Deleted.
3435         (WTR::TestController::viewOptionsForTest): Deleted.
3436         * WebKitTestRunner/TestController.h:
3437         (WTR::TestController::injectedBundlePath):
3438         (WTR::TestController::testPluginDirectory):
3439         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3440         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3441         (WTR::TestController::platformCreateWebView):
3442         (WTR::TestController::platformCreateOtherPage):
3443         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3444         (WTR::PlatformWebView::PlatformWebView):
3445         (WTR::PlatformWebView::viewSupportsOptions):
3446         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3447         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
3448         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
3449         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3450         (WTR::PlatformWebView::PlatformWebView):
3451         (WTR::PlatformWebView::viewSupportsOptions):
3452         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3453         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
3454         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
3455         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3456         (WTR::PlatformWebView::PlatformWebView):
3457         (WTR::PlatformWebView::viewSupportsOptions):
3458         * WebKitTestRunner/ios/TestControllerIOS.mm:
3459         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
3460         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
3461         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3462         (WTR::PlatformWebView::PlatformWebView):
3463         (WTR::PlatformWebView::viewSupportsOptions):
3464         * WebKitTestRunner/mac/TestControllerMac.mm:
3465         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
3466         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
3467
3468 2015-09-08  Daniel Bates  <dabates@apple.com>
3469
3470         [Mac] Expose Enable/Disable Accelerated Drawing in MiniBrowser
3471         https://bugs.webkit.org/show_bug.cgi?id=148980
3472
3473         Reviewed by Alexey Proskuryakov.
3474
3475         Add setting to enable/disable accelerated drawing so as to support testing
3476         this feature in MiniBrowser on Mac.
3477
3478         * MiniBrowser/mac/SettingsController.h:
3479         * MiniBrowser/mac/SettingsController.m:
3480         (-[SettingsController _populateMenu]): Add menu item.
3481         (-[SettingsController validateMenuItem:]): Update setting when menu item is toggled.
3482         (-[SettingsController toggleAcceleratedDrawingEnabled:]): Added.
3483         (-[SettingsController acceleratedDrawingEnabled]): Added.
3484         * MiniBrowser/mac/WK1BrowserWindowController.m:
3485         (-[WK1BrowserWindowController didChangeSettings]): Apply setting in WebKit1.
3486         * MiniBrowser/mac/WK2BrowserWindowController.m:
3487         (-[WK2BrowserWindowController didChangeSettings]): Apply setting in WebKit2.
3488
3489 2015-09-08  Jason Marcell  <jmarcell@apple.com>
3490
3491         Unreviewed. Added myself as a commiter in contributors.json.
3492
3493         * Scripts/webkitpy/common/config/contributors.json:
3494
3495 2015-09-08  Keith Miller  <keith_miller@apple.com>
3496
3497         Unreviewed, added myself to the list of contributors.
3498
3499         * Scripts/webkitpy/common/config/contributors.json:
3500
3501 2015-09-08  Daniel Bates  <dabates@apple.com>
3502
3503         Dashboard: Remove use of z-index for ring overlay; use DOM ordering
3504         https://bugs.webkit.org/show_bug.cgi?id=148921
3505
3506         Reviewed by Alexey Proskuryakov.
3507
3508         The ring image is positioned above the platform icon in markup and we specify the CSS
3509         property z-index for the ring image so that it is painted on top of the platform icon
3510         instead of below it (by DOM ordering). Instead we can take advantage of the transparency
3511         of the ring image, switch the order of these DOM elements and remove the use of the CSS
3512         property z-index to achieve a similar effect.
3513
3514         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3515         (documentReady): Create the platform icon image element before the ring image such that
3516         the ring image is painted on top of the platform icon.
3517         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3518         (table.queue-grid td.logo img.ring): Removed property z-index.
3519
3520 2015-09-08  Daniel Bates  <dabates@apple.com>
3521
3522         Dashboard: Remove duplicate gear icon data URLs
3523         https://bugs.webkit.org/show_bug.cgi?id=148920
3524
3525         Reviewed by Alexey Proskuryakov.
3526
3527         Currently we duplicate the SVG data URL for the gear icon up to its fill color in the CSS property
3528         background-image associated with each of the three gear icon states: collapsed (.settings), hover
3529         (.settings:hover), and expanded (.settings-visible .settings). Instead we should use the gear icon
3530         as a mask and make use of the CSS background-color to define the fill color for each of these three
3531         states.
3532
3533         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3534         (.settings): Use gear icon as mask and define CSS background-color for collapsed state.
3535         (.settings:hover): Override CSS background-color for hover state.
3536         (.settings-visible .settings): Override CSS background-color for expanded state.
3537
3538 2015-09-07  Andy Estes  <aestes@apple.com>
3539
3540         [Mac] DebugRelease builds should link against libWebKitSystemInterfaceElCapitan.a on 10.11
3541         https://bugs.webkit.org/show_bug.cgi?id=148946
3542         <rdar://problem/22603981>
3543
3544         Reviewed by Dan Bernstein.
3545
3546         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3547         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3548
3549 2015-09-07  Hunseop Jeong  <hs85.jeong@samsung.com>
3550
3551         [EFL] Many of the css3/device-adapt/* tests failed after r188548.
3552         https://bugs.webkit.org/show_bug.cgi?id=148927
3553
3554         Reviewed by Csaba Osztrogonác.
3555
3556         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
3557         overwritten by updatePlatformSpecificViewOptionsForTest after r188548.
3558
3559         * WebKitTestRunner/TestController.cpp:
3560         (WTR::shouldUseFixedLayout): Removed the unnecessary indentations.
3561         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3562         (WTR::shouldUseFixedLayout): Return true if the test is related with 'device-adapt'.
3563
3564 2015-09-07  Andy Estes  <aestes@apple.com>
3565
3566         Fix the Production build after r189455.
3567
3568         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Somehow I added the All target using the
3569         In-App Purchase template instead of the Aggregate template. Whoops.
3570
3571 2015-09-06  Andy Estes  <aestes@apple.com>
3572
3573         WebKit.xcworkspace should be be able to build iOS platforms
3574         https://bugs.webkit.org/show_bug.cgi?id=148881
3575
3576         Reviewed by Daniel Bates.
3577
3578         Since we don't want to create platform-specific schemes, all projects in the workspace's schemes need to build
3579         for all supported platforms.
3580
3581         * MiniBrowser/Configurations/Base.xcconfig: Included iphoneos and iphonesimulator in SUPPORTED_PLATFORMS.
3582         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Excluded all source files on iOS, and linked Cocoa and WebKit on Mac.
3583         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Ditto.
3584         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Stopped linking frameworks in Link Binaries With Libraries.
3585
3586 2015-09-06  Andy Estes  <aestes@apple.com>
3587
3588         WebKitTestRunner should build for iOS using the default target
3589         https://bugs.webkit.org/show_bug.cgi?id=148918
3590
3591         Reviewed by Daniel Bates.
3592
3593         When WebKitTestRunner was ported to iOS, a separate target (WebKitTestRunnerApp) was created for building the
3594         iOS variant. This is annoying because (1) all tools that invoke xcodebuild need to be taught to