ebf2614f80e98bbf52bbaae9f2cb9750a5b21780
[WebKit-https.git] / Tools / ChangeLog
1 2013-10-22  Commit Queue  <commit-queue@webkit.org>
2
3         Unreviewed, rolling out r157774.
4         http://trac.webkit.org/changeset/157774
5         https://bugs.webkit.org/show_bug.cgi?id=123167
6
7         causes python test to fail (Requested by smfr on #webkit).
8
9         * Scripts/webkitpy/layout_tests/controllers/manager.py:
10         (Manager.run):
11         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
12         (TestExpectations.__init__):
13         (TestExpectations._add_expectations):
14         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
15         (parse_args):
16         (_set_up_derived_options):
17
18 2013-10-22  Lucas Forschler  <lforschler@apple.com>
19
20         Prepare WebKit Buildbot master for Mavericks.
21         This adds the following bot configurations:
22             Mavericks Release/Debug builders
23             Mavericks Release/Debug WK1 Testers
24             Mavericks Release/Debug WK2 Testers
25
26         Unreviewed.
27         
28         * BuildSlaveSupport/build.webkit.org-config/config.json:
29
30 2013-10-21  Tamas Gergely  <gertom@inf.u-szeged.hu>
31
32         Run tests as if they are expected to pass when --force is given.
33         https://bugs.webkit.org/show_bug.cgi?id=112890
34
35         Reviewed by Ryosuke Niwa.
36
37         The --force switch of new-run-webkit-tests is now forces all tests to
38         be run with 'PASS' as expected result.
39
40         * Scripts/webkitpy/layout_tests/controllers/manager.py:
41         (Manager.run):
42         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
43         (TestExpectations.__init__):
44         (TestExpectations._add_expectations):
45         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
46         (parse_args):
47         (_set_up_derived_options):
48
49 2013-10-21  Mark Rowe  <mrowe@apple.com>
50
51         Add a version of WebKitSystemInterface for Mavericks.
52
53         Reviewed by Ryosuke Niwa.
54
55         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
56         * Scripts/copy-webkitlibraries-to-product-directory:
57         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
58
59 2013-10-21  Anders Carlsson  <andersca@apple.com>
60
61         Navigation policy callback not called when performing the same fragment navigation twice
62         https://bugs.webkit.org/show_bug.cgi?id=123121
63         <rdar://problem/15230466>
64
65         Reviewed by Beth Dakin.
66
67         Add a test.
68
69         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
70         * TestWebKitAPI/Tests/mac/FragmentNavigation.html: Added.
71         * TestWebKitAPI/Tests/mac/FragmentNavigation.mm: Added.
72         (+[WebKit1FragmentNavigationTestDelegate shared]):
73         (-[WebKit1FragmentNavigationTestDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
74         (-[WebKit1FragmentNavigationTestDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
75         (-[WebKit1FragmentNavigationTestDelegate webView:didFinishLoadForFrame:]):
76         (-[WebKit1FragmentNavigationTestDelegate _runNextTestWithWebView:]):
77         (TestWebKitAPI::TEST):
78
79 2013-10-21  Dan Bernstein  <mitz@apple.com>
80
81         Style checker should allow a space after the @property keyword
82         https://bugs.webkit.org/show_bug.cgi?id=123117
83
84         Reviewed by Anders Carlsson.
85
86         * Scripts/webkitpy/style/checkers/cpp.py:
87         (check_spacing_for_function_call): Allow a space between @property and the following (
88         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
89         (CppStyleTest.test_spacing_for_fncall): Added a test case.
90
91 2013-10-21  peavo@outlook.com  <peavo@outlook.com>
92
93         [WinCairo] Build does not start.
94         https://bugs.webkit.org/show_bug.cgi?id=123059
95
96         Reviewed by Csaba Osztrogonác.
97
98         The function isAppleWinWebKit() does no longer return true for WinCairo, need to add isWinCairo() checks instead.
99
100         * Scripts/build-webkit:
101
102 2013-10-21  Zan Dobersek  <zdobersek@igalia.com>
103
104         [Jhbuild] Bump the required Jhbuild revision
105         https://bugs.webkit.org/show_bug.cgi?id=123089
106
107         Reviewed by Carlos Garcia Campos.
108
109         * jhbuild/jhbuild-wrapper: Latest versions of the gnome-common tools produce failures when configuring Jhbuild
110         due to the configure.ac script using both IT_PROG_INTLTOOL and AM_GNU_GETTEXT macros. This is already fixed
111         in the Jhbuild source so a more recent revision of it should be used.
112
113 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
114
115         Mac build fix.
116
117         * DumpRenderTree/mac/DumpRenderTree.mm: Cast the length for %lu specifier.
118
119 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
120
121         Enable webaudio/ tests on DRT/Mac
122         https://bugs.webkit.org/show_bug.cgi?id=86914
123
124         Reviewed by Darin Adler.
125
126         * DumpRenderTree/ForwardingHeaders/runtime/ArrayBufferView.h: Copied from Source/WebCore/ForwardingHeaders/runtime/ArrayBufferView.h.
127         * DumpRenderTree/ForwardingHeaders/runtime/JSArrayBufferView.h: Copied from Source/WebCore/ForwardingHeaders/runtime/JSArrayBufferView.h.
128         * DumpRenderTree/ForwardingHeaders/runtime/TypedArrayInlines.h: Copied from Source/WebCore/ForwardingHeaders/runtime/TypedArrayInlines.h.
129         There is no way to efficiently get TypedArray buffer using API, so we need some internal headers.
130
131         * DumpRenderTree/TestRunner.cpp:
132         (setAudioResultCallback): 
133         (TestRunner::staticFunctions):
134         * DumpRenderTree/TestRunner.h:
135         (TestRunner::audioResult):
136         (TestRunner::setAudioResult):
137         The function has a different name and argument type now, updated accordingly.
138         Changed buffer from std::string to std::vector<char>, because it's more idiomatic.
139
140         * DumpRenderTree/mac/DumpRenderTree.mm:
141         (dumpAudio): Updated for the new name of audioResult accessor.
142         (dump): Print the result in the format webkitpy currently expects.
143
144         * WebKitTestRunner/TestInvocation.cpp:
145         (WTR::TestInvocation::dumpAudio): fwrite the whole block at once, splitting into
146         chunks made no sense.
147
148         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
149         (WTR::TestRunner::setAudioResult): Added a FIXME about getting off WKBundle SPI.
150
151         * DumpRenderTree/CMakeLists.txt: Added JavaScriptCore/parser to include search list,
152         so that "SourceProvider.h" can be found.
153
154 2013-10-19  Ryosuke Niwa  <rniwa@webkit.org>
155
156         run-webkit-tests should submit time and modifiers to the new flakiness dashboard
157         https://bugs.webkit.org/show_bug.cgi?id=123070
158
159         Reviewed by Alexey Proskuryakov.
160
161         * Scripts/webkitpy/layout_tests/controllers/manager.py:
162         (Manager.run):
163         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
164         (summarize_results): Added include_time_and_modifiers. Report test_run_time and modifiers
165         in the test expectations when this argument is set to true.
166
167 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
168
169         Mac DumpRenderTree builds without NDEBUG even in release mode
170         https://bugs.webkit.org/show_bug.cgi?id=123066
171
172         Reviewed by Dan Bernstein.
173
174         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
175         * DumpRenderTree/mac/Configurations/Base.xcconfig:
176         Use the same pattern as WebCore and WebKitTestRunner.
177
178 2013-10-19  Zan Dobersek  <zdobersek@igalia.com>
179
180         REGRESSION(r155373): Mac WK2 EWS bots is actually Mac WK1 debug
181         https://bugs.webkit.org/show_bug.cgi?id=123064
182
183         Reviewed by Ryosuke Niwa.
184
185         Revert r155373 as it is causing incorrect port/platform deduction for the Mac EWS systems.
186
187         * Scripts/webkitpy/common/config/ports.py: Added.
188         (DeprecatedPort):
189         (DeprecatedPort.name):
190         (DeprecatedPort.flag):
191         (DeprecatedPort.script_path):
192         (DeprecatedPort.script_shell_command):
193         (DeprecatedPort.port):
194         (DeprecatedPort.makeArgs):
195         (DeprecatedPort.update_webkit_command):
196         (DeprecatedPort.check_webkit_style_command):
197         (DeprecatedPort.prepare_changelog_command):
198         (DeprecatedPort.build_webkit_command):
199         (DeprecatedPort.run_javascriptcore_tests_command):
200         (DeprecatedPort.run_webkit_unit_tests_command):
201         (DeprecatedPort.run_webkit_tests_command):
202         (DeprecatedPort.run_python_unittests_command):
203         (DeprecatedPort.run_perl_unittests_command):
204         (DeprecatedPort.run_bindings_tests_command):
205         (MacPort):
206         (MacWK2Port):
207         (MacWK2Port.run_webkit_tests_command):
208         (WinPort):
209         (WinPort.run_bindings_tests_command):
210         (GtkPort):
211         (GtkPort.build_webkit_command):
212         (GtkPort.run_webkit_tests_command):
213         (GtkWK2Port):
214         (GtkWK2Port.build_webkit_command):
215         (GtkWK2Port.run_webkit_tests_command):
216         (QtPort):
217         (QtPort.build_webkit_command):
218         (QtPort.run_webkit_tests_command):
219         (QtWK2Port):
220         (QtWK2Port.build_webkit_command):
221         (QtWK2Port.run_webkit_tests_command):
222         (EflPort):
223         (EflPort.build_webkit_command):
224         (EflWK2Port):
225         (EflWK2Port.build_webkit_command):
226         * Scripts/webkitpy/common/config/ports_mock.py: Added.
227         (MockPort):
228         (MockPort.name):
229         (MockPort.check_webkit_style_command):
230         (MockPort.update_webkit_command):
231         (MockPort.build_webkit_command):
232         (MockPort.prepare_changelog_command):
233         (MockPort.run_python_unittests_command):
234         (MockPort.run_perl_unittests_command):
235         (MockPort.run_javascriptcore_tests_command):
236         (MockPort.run_webkit_unit_tests_command):
237         (MockPort.run_webkit_tests_command):
238         (MockPort.run_bindings_tests_command):
239         * Scripts/webkitpy/common/config/ports_unittest.py: Added.
240         (DeprecatedPortTest):
241         (DeprecatedPortTest.test_mac_port):
242         (DeprecatedPortTest.test_gtk_port):
243         (DeprecatedPortTest.test_gtk_wk2_port):
244         (DeprecatedPortTest.test_efl_port):
245         (DeprecatedPortTest.test_qt_port):
246         (DeprecatedPortTest.test_qt_wk2_port):
247         * Scripts/webkitpy/port/base.py:
248         (Port._port_flag_for_scripts):
249         (Port._wk2_port_name):
250         * Scripts/webkitpy/port/base_unittest.py:
251         (PortTest.test_build_path):
252         * Scripts/webkitpy/port/efl_unittest.py:
253         (EflPortTest.test_show_results_html_file):
254         * Scripts/webkitpy/port/gtk_unittest.py:
255         (GtkPortTest.test_get_crash_log):
256         * Scripts/webkitpy/port/mac_unittest.py:
257         (test_64bit):
258         * Scripts/webkitpy/port/test.py:
259         (TestPort.virtual_test_suites):
260         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
261         (FlakyTestReporter.__init__):
262         * Scripts/webkitpy/tool/bot/irc_command.py:
263         (Rollout._update_working_copy):
264         * Scripts/webkitpy/tool/commands/download_unittest.py:
265         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
266         (AbstractEarlyWarningSystem.run_command):
267         * Scripts/webkitpy/tool/commands/queues.py:
268         (PatchProcessingQueue.begin_work_queue):
269         (CommitQueue.run_command):
270         * Scripts/webkitpy/tool/main.py:
271         (WebKitPatch.__init__):
272         (WebKitPatch.deprecated_port):
273         (WebKitPatch.handle_global_options):
274         * Scripts/webkitpy/tool/mocktool.py:
275         (MockTool.__init__):
276         (MockTool.deprecated_port):
277         * Scripts/webkitpy/tool/steps/build.py:
278         (Build.build):
279         * Scripts/webkitpy/tool/steps/checkstyle.py:
280         (CheckStyle.run):
281         * Scripts/webkitpy/tool/steps/commit.py:
282         (Commit._check_test_expectations):
283         * Scripts/webkitpy/tool/steps/preparechangelog.py:
284         (PrepareChangeLog.run):
285         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
286         (PrepareChangeLogForRevert.run):
287         * Scripts/webkitpy/tool/steps/runtests.py:
288         (RunTests.run):
289         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
290         (RunTestsTest.test_webkit_run_unit_tests):
291         * Scripts/webkitpy/tool/steps/steps_unittest.py:
292         (StepsTest.test_runtests_args):
293         * Scripts/webkitpy/tool/steps/update.py:
294         (Update._update_command):
295         * Scripts/webkitpy/tool/steps/update_unittest.py:
296         (UpdateTest.test_update_command_non_interactive):
297         (UpdateTest.test_update_command_interactive):
298
299 2013-10-19  Andreas Kling  <akling@apple.com>
300
301         RefPtr::releaseNonNull() incorrectly increments the refcount.
302         <https://webkit.org/b/123063>
303
304         Add an API test to verify that no extra refs are added when calling
305         RefPtr::releaseNonNull().
306
307         Reviewed by Anders Carlsson.
308
309 2013-10-18  Rik Cabanier <cabanier@adobe.com>
310         Add Rik Cabanier to list of committers
311         https://bugs.webkit.org/show_bug.cgi?id=123031
312
313         reviewed by Dirk Schulze.
314
315         * Tools/Scripts/webkitpy/common/config/contributors.json: Added name.
316
317 2013-10-18  Denis Nomiyama  <d.nomiyama@samsung.com>
318
319         [ATK] Fix invalid signal to set objects to an unknown state "layout-complete"
320         https://bugs.webkit.org/show_bug.cgi?id=122970
321
322         Reviewed by Mario Sanchez Prada.
323
324         Removed an invalid signal to set an object state to layout-complete
325         that does not exist. It was replaced by ATK:AtkDocument:load-complete.
326
327         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
328         (axObjectEventListener): Replaced layout-complete with load-complete.
329         (connectAccessibilityCallbacks): Connect callback to new listener for
330         ATK:AtkDocument:load-complete.
331         (disconnectAccessibilityCallbacks): Disconnect callback to new listener
332         for ATK:AtkDocument:load-complete.
333         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
334         (axObjectEventListener): Replaced layout-complete with load-complete.
335         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
336         Connect callback to new listener for ATK:AtkDocument:load-complete.
337         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
338         Disconnect callback to new listener for ATK:AtkDocument:load-complete.
339
340 2013-10-18  Carlos Garcia Campos  <cgarcia@igalia.com>
341
342         [GTK] Generate API documentation for GObject DOM bindings
343         https://bugs.webkit.org/show_bug.cgi?id=121538
344
345         Reviewed by Gustavo Noronha Silva.
346
347         The .symbols file that is now generated for checking GObject DOM
348         bindings API compatibility while building can also be used to
349         generate the files needed to produce the gtk-doc
350         documentation. The new script generate-webkitdom-doc-files can
351         generate the docs.sgml and sections.txt files from the given list
352         of .symbols files.
353
354         * gtk/GNUmakefile.am: Add rules to generate webkitdomgtk-docs.sgml
355         and webkitdomgtk-sections.txt as well as rules to install the
356         generated WebKitDOMGTK documentation.
357         * gtk/generate-gtkdoc:
358         (webkitdom_docs_html_path): New helper function that returns the
359         path where the DOM API documentation has been generated.
360         (get_webkit2_options): Include DOM API docs to the list of xref
361         dependencies.
362         (get_webkit1_options): Ditto.
363         (get_webkitdom_options): Return the gtk-doc options to generate
364         the DOM API docs.
365         (get_webkitdom_options.derived_sources_path):
366         (get_webkitdom_options.src_path):
367         * gtk/generate-webkitdom-doc-files: Added.
368         (WebKitDOMDocGenerator):
369         (WebKitDOMDocGenerator.write_header):
370         (WebKitDOMDocGenerator.write_section):
371         (WebKitDOMDocGenerator.write_footer):
372         (WebKitDOMDocGeneratorDocs):
373         (WebKitDOMDocGeneratorDocs.write_header):
374         (write_section):
375         (write_footer):
376         (WebKitDOMDocGeneratorSections):
377         (WebKitDOMDocGeneratorSections.__init__):
378         (WebKitDOMDocGeneratorSections._dom_class):
379         (WebKitDOMDocGeneratorSections._dom_class_decamelize):
380         (WebKitDOMDocGeneratorSections._symbol_list):
381         (WebKitDOMDocGeneratorSections.write_section):
382
383 2013-10-17  Alex Christensen  <achristensen@webkit.org>
384
385         Run JavaScriptCore tests again on Windows.
386         https://bugs.webkit.org/show_bug.cgi?id=122787
387
388         Reviewed by Tim Horton.
389
390         * Scripts/build-jsc:
391         (buildMyProject): Use JavaScriptCore.sln to build JavaScriptCore and WTF.
392         * Scripts/run-javascriptcore-tests: Don't run stress tests on WinCairo.
393         * Scripts/webkitdirs.pm:
394         (determineConfigurationForVisualStudio):
395         (determineConfigurationProductDir):
396         Build directory should end with bin64 and configuration should end with |x64 on Win64.
397         (isAppleWinWebKit):
398         (copyInspectorFrontendFiles):
399         (setPathForRunningWebKitApp):
400         Separated WinCairo directories and options from AppleWin.
401
402 2013-10-17  Mihnea Ovidenie  <mihnea@adobe.com>
403
404         Unreviewed. Add myself as a reviewer.
405
406         * Scripts/webkitpy/common/config/contributors.json:
407
408 2013-10-17  Andreas Kling  <akling@apple.com>
409
410         Make it possible to assign a PassRef to a RefPtr.
411         <https://webkit.org/b/122943>
412
413         Added a small API test for RefPtr=(PassRef) so we know this code
414         will compile (and work.)
415
416         Reviewed by Antti Koivisto.
417
418 2013-10-16  Filip Pizlo  <fpizlo@apple.com>
419
420         We need test coverage for just the Baseline JIT
421         https://bugs.webkit.org/show_bug.cgi?id=122929
422
423         Reviewed by Sam Weinig.
424         
425         Adds no-LLInt versions of all tests. For the Mozilla tests, also add a BaselineJIT-only
426         variant.
427
428         * Scripts/run-jsc-stress-tests:
429
430 2013-10-16  Ryosuke Niwa  <rniwa@webkit.org>
431
432         Support multiple repositories in submitting results to --results-server-host
433         https://bugs.webkit.org/show_bug.cgi?id=122935
434
435         Reviewed by Anders Carlsson.
436
437         Remoevd --got-revision and added the logic to extract revision information
438         from multiple repositories as done in run-perf-tests.
439
440         * Scripts/webkitpy/layout_tests/controllers/manager.py:
441         (Manager.upload_results):
442         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
443         (parse_args):
444
445 2013-10-16  Darin Adler  <darin@apple.com>
446
447         Add PassRef and createRefCounted so we can improve creation of RefCounted objects
448         https://bugs.webkit.org/show_bug.cgi?id=122904
449
450         Reviewed by Anders Carlsson.
451
452         * TestWebKitAPI/Tests/WTF/Ref.cpp: Added some basic tests for adoptRef and PassRef.
453
454 2013-10-16  Darin Adler  <darin@apple.com>
455
456         Need tests for RefPtr self-assignment and self-move-assignment.
457
458         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Added tests.
459
460 2013-10-16  Robert Plociennik  <r.plociennik@samsung.com>
461
462         [EFL] Minibrowser can't load child window's location
463         https://bugs.webkit.org/show_bug.cgi?id=122485
464
465         Reviewed by Gyuyoung Kim.
466
467         * MiniBrowser/efl/main.c: Now calling window_create() without the url parameter
468             followed by an explicit call to ewk_view_url_set() where appropriate.
469         (on_key_down):
470         (on_window_create):
471         (window_create):
472         (elm_main):
473
474 2013-10-15  Sergio Correia  <sergio.correia@openbossa.org>
475
476         [EFL][WK2] Make SeccompFilters build again after r156349 and r156353
477         https://bugs.webkit.org/show_bug.cgi?id=122872
478
479         Reviewed by Anders Carlsson.
480
481         * TestWebKitAPI/PlatformEfl.cmake: Mark SeccompFilters API test as
482         failing.
483
484 2013-10-15  Dean Jackson  <dino@apple.com>
485
486         Add ENABLE_WEB_ANIMATIONS flag
487         https://bugs.webkit.org/show_bug.cgi?id=122871
488
489         Reviewed by Tim Horton.
490
491         Eventually might be http://dev.w3.org/fxtf/web-animations/
492         but this is just engine-internal work at the moment.
493
494         * Scripts/webkitperl/FeatureList.pm:
495
496 2013-10-15  Darin Adler  <darin@apple.com>
497
498         Add some API tests for Vector, RefPtr, and Ref
499         https://bugs.webkit.org/show_bug.cgi?id=122840
500
501         Reviewed by Andreas Kling.
502
503         * TestWebKitAPI/CMakeLists.txt: Added new files.
504         * TestWebKitAPI/GNUmakefile.am: Ditto.
505         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
506         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
507         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
508
509         * TestWebKitAPI/Tests/WTF/Ref.cpp: Added.
510         * TestWebKitAPI/Tests/WTF/RefLogger.h: Added.
511         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Added.
512         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added move-only insert tests.
513
514 2013-10-14  Roger Fong  <roger_fong@apple.com>
515
516         Adding myself to CC list for some components.
517
518         * Scripts/webkitpy/common/config/watchlist:
519
520 2013-10-13  Darin Adler  <darin@apple.com>
521
522         Deprecate or remove deleteAllValues functions; there are only a few call sites left
523         https://bugs.webkit.org/show_bug.cgi?id=122738
524
525         Reviewed by Anders Carlsson.
526
527         * DumpRenderTree/win/DRTDataObject.cpp:
528         (DRTDataObject::~DRTDataObject):
529         * DumpRenderTree/win/UIDelegate.cpp:
530         (DRTUndoStack::~DRTUndoStack):
531         (DRTUndoStack::clear):
532         Renamed deleteAllValues to deprecatedDeleteAllValues.
533
534         * Scripts/do-webcore-rename: Updated to perform this rename, as is traditional.
535
536 2013-10-13  Alexey Proskuryakov  <ap@apple.com>
537
538         build.webkit.org/dashboard incorrectly shows interrupted builds as green
539         https://bugs.webkit.org/show_bug.cgi?id=122732
540
541         Reviewed by Tim Hatcher.
542
543         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
544         (BuildbotIteration.prototype.update): Removed a special case for status 4 (EXCEPTION).
545         I don't see it occur any time in recent history, but judging from what happens for
546         status 5 (RETRY), we can just finish this function normally.
547         Record overall text description for iteration as BuildbotIteration.text.
548
549         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
550         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): If an iteration is a failure,
551         but no tests failed, make it yellow, and use buildbot-provided description for it.
552
553 2013-10-13  Alexey Proskuryakov  <ap@apple.com>
554
555         Remove Chromium specific code from flakiness dashboard
556         https://bugs.webkit.org/show_bug.cgi?id=122714
557
558         Reviewed by Sam Weinig.
559
560         Also removed code related to GPU tests and virtual suites.
561         "Fallbacks map" was chromium only too, not sure why they needed special handling there.
562
563         * TestResultServer/model/jsonresults_unittest.py:
564         * TestResultServer/static-dashboards/builders.js:
565         * TestResultServer/static-dashboards/dashboard_base.js:
566         * TestResultServer/static-dashboards/flakiness_dashboard.html:
567         * TestResultServer/static-dashboards/flakiness_dashboard.js:
568         * TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
569         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
570         * TestResultServer/static-dashboards/history.js:
571         * TestResultServer/static-dashboards/loader.js:
572         * TestResultServer/static-dashboards/ui.js:
573         * TestResultServer/templates/uploadform.html:
574
575 2013-10-11  Timothy Hatcher  <timothy@apple.com>
576
577         Remove preference support for picking the old Web Inspector.
578         https://bugs.webkit.org/show_bug.cgi?id=122655
579
580         Reviewed by Alexey Proskuryakov.
581
582         * WebKitTestRunner/TestController.cpp:
583         (WTR::TestController::resetStateToConsistentValues):
584
585 2013-10-11  Filip Pizlo  <fpizlo@apple.com>
586
587         Fix 64-bit build on everything but Windows.
588
589         Rubber stamped by Brent Fulgham.
590
591         * Scripts/webkitdirs.pm:
592         (argumentsForConfiguration):
593
594 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
595
596         Touch a file to see how auto-update works.
597
598         Rubber-stamped by Tim Hatcher.
599
600         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
601
602 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
603
604         LeaksViewer fails to present recent results list if current build is still updating svn
605         https://bugs.webkit.org/show_bug.cgi?id=122670
606
607         Fixed an obvious mistake in the previous patch.
608
609         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
610         (RecentBuildsLoader.prototype.start):
611
612 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
613
614         LeaksViewer fails to present recent results list if current build is still updating svn
615         https://bugs.webkit.org/show_bug.cgi?id=122670
616
617         Reviewed by Adam Roben.
618
619         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
620         (RecentBuildsLoader.prototype.start): Skip builds that don't have an svn revision yet.
621
622 2013-10-11  Brent Fulgham  <bfulgham@apple.com>
623
624         Unreviewed build fix for --64-bit target.
625
626         * Scripts/webkitdirs.pm:
627         (argumentsForConfiguration): Use 'isWin64' test, since @ARGV value may have
628         been removed by this point.
629         (hasArgument): Remove unused temporary.
630
631 2013-10-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
632
633         webkit-patch failure-reason has a quite low limit for 'too many failures'
634         https://bugs.webkit.org/show_bug.cgi?id=122556
635
636         Reviewed by Darin Adler.
637
638         * Scripts/webkitpy/tool/commands/queries.py:
639         (FailureReason._explain_failures_for_builder): adjust the number of too many failures
640         to match what the layout test runners use these days.
641
642 2013-10-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
643
644         webkit-patch failure-reason should allow specifying failures one is interested in
645         https://bugs.webkit.org/show_bug.cgi?id=122554
646
647         Reviewed by Darin Adler.
648
649         * Scripts/webkitpy/tool/commands/queries.py:
650         (FailureReason):
651         (FailureReason._explain_failures_for_builder): keep track of explained failures and drop out of the
652         loop if the ones we're interested in been explained.
653         (FailureReason._done_explaining): check the failures we're interested in have been explained, if any.
654         (FailureReason.execute): initialize failures to explain and the explained set.
655
656 2013-10-10  Filip Pizlo  <fpizlo@apple.com>
657
658         Make sure that DataTypes.h is in the binary drop.
659
660         Rubber stamped by Michael Saboff.
661
662         * Scripts/export-llvm-build:
663
664 2013-10-10  Filip Pizlo  <fpizlo@apple.com>
665
666         FTL: Soft-link LLVM as a workaround for LLVM's static initializers and exit-time destructors
667         https://bugs.webkit.org/show_bug.cgi?id=122566
668
669         Reviewed by Mark Rowe.
670
671         * Scripts/configure-llvm:
672
673 2013-10-10  Mark Rowe  <mrowe@apple.com>
674
675         <rdar://problem/13341666> WebKit should always build against an SDK.
676
677         Have all projects default to building against the OS X Internal SDK for the Production
678         configuration. For the Debug and Release configurations, look for UseInternalSDK.xcconfig
679         to determine whether the OS X Internal SDK should be used. If not, use the normal OS X SDK.
680
681         Reviewed by Dan Bernstein.
682
683         * DumpRenderTree/mac/Configurations/Base.xcconfig:
684         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
685         * MiniBrowser/Configurations/Base.xcconfig:
686         * MiniBrowser/Configurations/DebugRelease.xcconfig:
687         * TestWebKitAPI/Configurations/Base.xcconfig:
688         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
689         * WebKitTestRunner/Configurations/Base.xcconfig:
690         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
691
692 2013-10-10  Gustavo Noronha Silva  <gns@gnome.org>
693
694         Unreviewed gardening, the inspector protocol timeouts are also affecting TestInspectorServer.
695
696         * Scripts/run-gtk-tests:
697         (TestRunner): skip TestInspectorServer.
698
699 2013-10-10  Andres Gomez  <agomez@igalia.com>
700
701         [GTK] Provide search functionality to MiniBrowser
702         https://bugs.webkit.org/show_bug.cgi?id=117631
703
704         Reviewed by Carlos Garcia Campos.
705
706         Adds a search bar to MiniBrowser with the minimum functionality
707         and a new button to the toolbar for showing the new search
708         bar. Typical keyboard shortcuts are also added.
709
710         * MiniBrowser/gtk/BrowserSearchBar.c: Added.
711         (doSearch):
712         (searchNext):
713         (searchPrevious):
714         (searchCloseButtonClickedCallback):
715         (searchEntryMenuIconPressedCallback):
716         (searchEntryClearIconReleasedCallback):
717         (searchEntryChangedCallback):
718         (searchEntryActivatedCallback):
719         (searchPrevButtonClickedCallback):
720         (searchNextButtonClickedCallback):
721         (searchMenuCheckButtonToggledCallback):
722         (browser_search_bar_init):
723         (browserSearchBarFinalize):
724         (browser_search_bar_class_init):
725         (browser_search_bar_new):
726         (browser_search_bar_add_accelerators):
727         (browser_search_bar_open):
728         (browser_search_bar_close):
729         * MiniBrowser/gtk/BrowserSearchBar.h: Added.
730         * MiniBrowser/gtk/BrowserWindow.c:
731         (webViewEnterFullScreen): Closes new search bar.
732         (webViewLeaveFullScreen): Opens new search bar if previously
733         visible.
734         (searchCallback): Added. Shows and hides the new search bar.
735         (browser_window_init): Added search button to the toolbar.
736         (browserWindowConstructed): Creates the new search bar.
737         * MiniBrowser/gtk/GNUmakefile.am: Added new files to compilation.
738
739 2013-10-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
740
741         webkit-patch failure-reason fails with UnicodeDecodeError when name has non-ascii characters
742         https://bugs.webkit.org/show_bug.cgi?id=122552
743
744         Reviewed by Darin Adler.
745
746         * Scripts/webkitpy/common/checkout/commitinfo.py:
747         (CommitInfo.blame_string): ensure objects are made into unicode strings, not regular ones that
748         will cause UnicodeDecodeError for non-ascii characters.
749
750 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
751
752         Would like a link to dashboard from build.webkit.org main page
753         https://bugs.webkit.org/show_bug.cgi?id=122577
754
755         Reviewed by Tim Hatcher.
756
757         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added.
758
759 2013-10-09  Brent Fulgham  <bfulgham@apple.com>
760
761         [Win] Check for MathML fonts and warn user if they are missing.
762         https://bugs.webkit.org/show_bug.cgi?id=122568
763
764         Reviewed by Tim Horton.
765
766         * Scripts/webkitdirs.pm:
767         (checkRequiredSystemConfig): Use common gperf/bison/flex tests, rather than
768         Windows-specific code I added previously.
769         (fontExists): Added
770         (checkInstalledTools): Add check for MathML fonts.
771
772 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
773
774         http://build.webkit.org/dashboard/ doesn't link to webkitpy failures
775         https://bugs.webkit.org/show_bug.cgi?id=122471
776
777         Reviewed by Tim Hatcher.
778
779         Added links to webkitpy, webkitperl and bindings-tests results.
780
781         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
782         (Buildbot.prototype.apiTestResultsURLForIteration):
783         (Buildbot.prototype.webkitpyTestResultsURLForIteration):
784         (Buildbot.prototype.webkitperlTestResultsURLForIteration):
785         (Buildbot.prototype.bindingsTestResultsURLForIteration):
786         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
787         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
788
789 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
790
791         Move some functions from WebKitBuildbot to Buildbot class.
792
793         Suggested by Tim Hatcher.
794
795         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
796         (Buildbot.prototype.javascriptTestResultsURLForIteration):
797         (Buildbot.prototype.apiTestResultsURLForIteration):
798         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
799         (WebKitBuildbot.prototype.layoutTestResultsURLForIteration):
800
801 2013-10-09  Timothy Hatcher  <timothy@apple.com>
802
803         Add API tests to the Dashbord page.
804
805         https://bugs.webkit.org/show_bug.cgi?id=122283
806
807         Reviewed by Timothy Hatcher.
808
809         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
810         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
811         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
812         (WebKitBuildbot.prototype.apiTestResultsURLForIteration):
813
814 2013-10-09  Timothy Hatcher  <timothy@apple.com>
815
816         Attempt to fix faulty Dashboard iteration updating by always rebuilding test result objects.
817
818         https://bugs.webkit.org/show_bug.cgi?id=122515
819
820         Reviewed by Alexey Proskuryakov.
821
822         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
823         (BuildbotIteration.prototype.update):
824
825 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
826
827         build.webkit.org/dashboard doesn't provide a results link when there issues at multiple steps
828         https://bugs.webkit.org/show_bug.cgi?id=122573
829
830         Reviewed by Tim Hatcher.
831
832         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
833         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Provide a URL.
834
835         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
836         (Buildbot.prototype.buildPageURLForIteration): Added.
837
838 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
839
840         http://build.webkit.org/dashboard/ links to a wrong jscore-test results page
841         https://bugs.webkit.org/show_bug.cgi?id=122569
842
843         Reviewed by Tim Hatcher.
844
845         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
846         (WebKitBuildbot.prototype.javascriptTestResultsURLForIteration): "actual.html" used
847         to be produced by the old Mozilla test harness that we don't use any more.
848
849 2013-10-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
850
851         Add GTK 64 bits release to the buildbot dashboard
852         https://bugs.webkit.org/show_bug.cgi?id=122548
853
854         Reviewed by Darin Adler.
855
856         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png: Added.
857         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
858         (WebKitBuildbot): add 64 bits release wk2 and wk1 testers.
859         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
860         (table.queue-grid tr.platform.linux-gtk img.logo): use the GTK+ logo in its dashboard line.
861
862 2013-10-09  Mario Sanchez Prada  <mario.prada@samsung.com>
863
864         [ATK] Implement new API in AtkText: atk_text_get_string_at_offset()
865         https://bugs.webkit.org/show_bug.cgi?id=120638
866
867         Reviewed by Gustavo Noronha Silva.
868
869         * gtk/jhbuild.modules: Raised ATK and AT-SPI versions to 2.10.0, so we
870         can check both the old and new APIs to retrieve text at a given offset.
871
872 2013-10-08  Alex Christensen  <achristensen@webkit.org>
873
874         Improved WinLauncher.
875         https://bugs.webkit.org/show_bug.cgi?id=122536
876
877         Reviewed by Brent Fulgham.
878
879         * WinLauncher/PrintWebUIDelegate.cpp:
880         (PrintWebUIDelegate::runJavaScriptAlertPanelWithMessage): Added.
881         (PrintWebUIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
882         * WinLauncher/PrintWebUIDelegate.h: Removed stubs.
883         * WinLauncher/WinLauncher.cpp:
884         (createCrashReport): Use the executable name instead of "WinLauncher".
885         * WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Removed.
886         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link to Wininet.lib.
887         * win/DLLLauncher/DLLLauncherMain.cpp: Remove VS2005 dependency for WinCairo.
888
889 2013-10-08  Mark Lam  <mark.lam@apple.com>
890
891         Fix ruby LoadError when running run-javascriptcore-tests.
892         https://bugs.webkit.org/show_bug.cgi?id=122519.
893
894         Reviewed by Mark Hahnenberg.
895
896         The scripts needed to explicitly require 'rubygems' for older versions of ruby
897         (versions before 1.9).
898
899         * Scripts/jsc-stress-test-helpers/profiler-test-helper:
900         * Scripts/run-jsc-stress-tests:
901
902 2013-10-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
903
904         Unreviewed, add my new email to contributors.json.
905
906         * Scripts/webkitpy/common/config/contributors.json:
907
908 2013-10-08  Brent Fulgham  <bfulgham@apple.com>
909
910         Unreviewed build correction.
911
912         * Scripts/webkitpy/port/win.py:
913         (WinPort.write_registry_value): Use string representation of error message to avoid
914         format conversion problem.
915
916 2013-10-07  Brent Fulgham  <bfulgham@apple.com>
917
918         [Win] Add checks for proper build and test environment
919         https://bugs.webkit.org/show_bug.cgi?id=122466
920
921         Reviewed by Darin Adler.
922
923         This patch makes two changes:
924         1. Update webkitdirs.pm to check for some common misconfigurations and provide helpful warnings or
925            error messages so that people know what to fix to get things working.
926         2. Modify the win.py port to handle the 32-bit and 64-bit test environments, as well as making sure
927            the various environment settings are properly configured for our test environment.
928
929         * Scripts/webkitdirs.pm:
930         (checkInstalledTools): Add checks for some common Cygwin configuration problems that have
931         caused problems in the past.
932         (setupAppleWinEnv):
933         * Scripts/webkitpy/port/win.py:
934         (WinPort):
935         (WinPort.read_registry_string): Parameterize for run architecture and registry root.
936         (WinPort.write_registry_value): Parameterize registry writing by data type (string versus
937         DWORD, etc.)
938         (WinPort.write_registry_string): Revise to call new generic registry write function.
939         (WinPort.setup_crash_log_saving): Revise for new API
940         (WinPort.restore_crash_log_saving): Ditto
941         (WinPort.prevent_error_dialogs): Add new methods to prevent Windows dialogs that block our test
942         servers from running.
943         (WinPort.allow_error_dialogs): Ditto.
944         (WinPort.setup_test_run): Call new API to turn off user input dialogs on program failure.
945         (WinPort.clean_up_test_run): Call new API to reactivatea user input dialogs after test run finished.
946
947 2013-10-08  Philippe Normand  <pnormand@igalia.com>
948
949         [GStreamer] enable v4l2 plugin
950         https://bugs.webkit.org/show_bug.cgi?id=122503
951
952         Reviewed by Martin Robinson.
953
954         * gtk/jhbuild.modules: Enable the plugin, it now builds fine since
955         we updated our GStreamer version to 1.0.8.
956
957 2013-10-08  Mario Sanchez Prada  <mario.prada@samsung.com>
958
959         [ATK] Expose state of aria-invalid as ATK_STATE_INVALID_ENTRY
960         https://bugs.webkit.org/show_bug.cgi?id=122104
961
962         Reviewed by Chris Fleizach.
963
964         Updated stringAttributeValue to double check that the exposure of
965         aria-invalid as a state is consistent with its exposure as a text
966         attribute as well, when it applies (implementations of AtkText).
967
968         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
969         (AccessibilityUIElement::stringAttributeValue): Add double check.
970         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
971         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
972
973 2013-10-07  Filip Pizlo  <fpizlo@apple.com>
974
975         run-jsc-stress-tests progress meter should update more quickly on older Rubies
976         https://bugs.webkit.org/show_bug.cgi?id=122459
977
978         Reviewed by Darin Adler.
979
980         * Scripts/run-jsc-stress-tests:
981
982 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
983
984         [buildbot] parse tests that are reported as crashed correctly for GTK+
985         https://bugs.webkit.org/show_bug.cgi?id=122476
986
987         Reviewed by Martin Robinson.
988
989         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
990         (RunGtkAPITests.commandComplete): parse the crashed tests output so that is reported
991         as a failure of the API tests.
992
993 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
994
995         Unreviewed. Skipping API test that is causing the next one to crash,
996         see https://bugs.webkit.org/show_bug.cgi?id=121970.
997
998         * Scripts/run-gtk-tests:
999         (TestRunner):
1000
1001 2013-10-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1002
1003         [GTK] run-gtk-tests does not distinguish between failure and crashes
1004         https://bugs.webkit.org/show_bug.cgi?id=122135
1005
1006         Reviewed by Martin Robinson.
1007
1008         The GTK+ API test runner does not distinguish between failures and crashes. This change
1009         makes it do that, so it's easier for us to spot the more important/higher priority crash
1010         case.
1011
1012         * Scripts/run-gtk-tests:
1013         (TestRunner._run_test_command): return the exit code instead of a boolean true/false,
1014         so we have more information on how the process ended.
1015         (TestRunner._run_test): check the exit code to distinguish between crashes and failures.
1016         (TestRunner.run_tests): report crashes.
1017
1018 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
1019
1020         [GTK] Missing packages for APT on install-dependencies
1021         https://bugs.webkit.org/show_bug.cgi?id=121555
1022
1023         Reviewed by Martin Robinson.
1024
1025         * gtk/install-dependencies: add packages that are needed for
1026         building WebKit itself and the jhbuild dependencies.
1027
1028 2013-10-07  Anders Carlsson  <andersca@apple.com>
1029
1030         Fix test failures.
1031
1032         * Scripts/webkitpy/port/base.py:
1033         (Port.to.start_helper):
1034         * Scripts/webkitpy/port/mock_drt.py:
1035         (MockDRTPort.start_helper):
1036
1037 2013-10-07  Anders Carlsson  <andersca@apple.com>
1038
1039         Always force discrete mode when running layout tests
1040         https://bugs.webkit.org/show_bug.cgi?id=122465
1041
1042         Reviewed by Tim Horton.
1043
1044         This should speed up WebGL tests and hopefully prevent race conditions that may cause window server crashes from happening.
1045         
1046         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1047         Link with IOKit.
1048
1049         * DumpRenderTree/mac/LayoutTestHelper.m:
1050         (installLayoutTestColorProfile):
1051         Check installColorProfile.
1052
1053         (restoreUserColorProfile):
1054         Check installColorProfile.
1055
1056         (lockDownDiscreteGraphics):
1057         New function to force discrete graphics.
1058
1059         (main):
1060         Add '--install-color-profile' option.
1061
1062         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1063         (Manager._set_up_run):
1064         Always start the helper, but pass self._options.pixel_tests to it.
1065
1066         * Scripts/webkitpy/port/mac.py:
1067         (MacPort.start_helper):
1068         Pass --install-color-profile' to the helper if pixel_tests is true.
1069
1070 2013-10-07  Timothy Hatcher  <timothy@apple.com>
1071
1072         Properly count binding test failures as failures.
1073
1074         Fix the total for multiple failures in different steps too by avoiding undefined.
1075
1076         https://bugs.webkit.org/show_bug.cgi?id=122232
1077
1078         Reviewed by Alexey Proskuryakov.
1079
1080         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1081         (BuildbotTestResults):
1082         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1083         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1084
1085 2013-10-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1086
1087         [GTK] Fails to build with jhbuild with newer system glib
1088         https://bugs.webkit.org/show_bug.cgi?id=122132
1089
1090         Reviewed by Martin Robinson.
1091
1092         Newer glib includes new symbols that some system libraries which we depend on, such as pango, have
1093         started relying on. glib is not a dependency that should change test results, and is provided in
1094         jhbuild with the intention of supporting the other bits that do, so using a newer stable release
1095         should not be an issue.
1096
1097         * gtk/jhbuild.modules:
1098
1099 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
1100
1101         run-jsc-stress-tests shouldn't print its goofy progress meter when running on the bots
1102         https://bugs.webkit.org/show_bug.cgi?id=122437
1103
1104         Reviewed by Antoine Quint.
1105
1106         * Scripts/run-jsc-stress-tests:
1107
1108 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
1109
1110         Unreviewed, fix build on old Rubies.
1111
1112         * Scripts/run-jsc-stress-tests:
1113
1114 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
1115
1116         Unified test infrastructure via the jsc shell
1117         https://bugs.webkit.org/show_bug.cgi?id=120696
1118
1119         Reviewed by Oliver Hunt.
1120         
1121         Make run-jsc-stress-tests smart enough to be able to handle different styles of test
1122         output (silent or noisy) and different styles of test failure (just bad exit code,
1123         text diff, filtering for some magical text, etc.). This allows me to get rid of the
1124         layout-test-helper. It also allows me to switch all of the old Mozilla tests to
1125         running in run-jsc-stress-tests.
1126         
1127         Also removes all of the code paths that defended against not having shellwords. Just
1128         install the shellwords gem if you want to run tests.
1129         
1130         Also removes the non-parallel test running code. No reason for it to exist anymore.
1131         
1132         This is a massive increase in test coverage. It uncovered bugs. I fixed two of them
1133         as part of this patch, and left three more as new bugzillas.
1134
1135         * Scripts/create-mozilla-js-test-list: Added.
1136         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
1137         * Scripts/jsc-stress-test-helpers/layout-test-helper: Removed.
1138         * Scripts/run-javascriptcore-tests:
1139         * Scripts/run-jsc-stress-tests:
1140
1141 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
1142
1143         run-jsc-stress-tests should be less verbose
1144         https://bugs.webkit.org/show_bug.cgi?id=122397
1145
1146         Reviewed by Sam Weinig.
1147         
1148         It now just prints something like:
1149         
1150          965/1831 ....
1151         
1152         Where the first number is the number of tests that completed, the second number is the
1153         number of tests total, and the dots are the number of tests running right now - which is
1154         useful towards the end when you're waiting for the last slow tests to finish.
1155         
1156         It will also print out the output from failing tests and it will print a line for skipped
1157         tests (to annoy you into getting them into a shape where they can be unskipped). For
1158         example, for LayoutTests, it will print just the diff, if the test fails. It's cool.
1159
1160         * Scripts/run-jsc-stress-tests:
1161
1162 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
1163
1164         Allow skipping of run-jsc-stress-tests that are configured using yaml files
1165         https://bugs.webkit.org/show_bug.cgi?id=122385
1166
1167         Reviewed by Sam Wieinig.
1168         
1169         Make tests run via YAML be able to do the parse-for-commands trick that allows
1170         us to skip tests and do other custom per-test stuff.
1171
1172         * Scripts/jsc-stress-test-helpers/layout-test-helper:
1173         * Scripts/run-jsc-stress-tests:
1174
1175 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
1176
1177         Unreviewed, fix tests on older Rubies.
1178
1179         * Scripts/run-jsc-stress-tests:
1180
1181 2013-10-05  Anders Carlsson  <andersca@apple.com>
1182
1183         Don't filter the weak symbols.
1184
1185         * Scripts/check-for-weak-vtables-and-externals:
1186
1187 2013-10-04  Filip Pizlo  <fpizlo@apple.com>
1188
1189         Have run-javascriptcore-tests run JS LayoutTests using run-jsc-stress-tests so that it runs in parallel
1190         https://bugs.webkit.org/show_bug.cgi?id=122376
1191
1192         Reviewed by Mark Hahnenberg.
1193
1194         * Scripts/jsc-stress-test-helpers/layout-test-helper: Added.
1195         * Scripts/run-javascriptcore-tests:
1196         (printThingsFound):
1197         * Scripts/run-jsc-stress-tests:
1198
1199 2013-10-04  Filip Pizlo  <fpizlo@apple.com>
1200
1201         It should be even easier to run and debug a failing JSC stress test
1202         https://bugs.webkit.org/show_bug.cgi?id=122337
1203
1204         Reviewed by Oliver Hunt.
1205         
1206         If a test fails, you can now just say:
1207
1208         sh WebKitBuild/Debug/jsc-stress-results/regress/script-tests/emscripten-cube2hash.js.ftl-eager-no-cjit
1209
1210         and get the reproduction. You don't have to set any environment variables like before.
1211         Also if you want to debug the failing test you can now just say:
1212
1213         sh WebKitBuild/Debug/jsc-stress-results/regress/script-tests/emscripten-cube2hash.js.ftl-eager-no-cjit lldb --
1214
1215         Broadly, any arguments passed to the reproduction script are prepended to the command to
1216         run the test. This is sort of quirky and won't work for some tests (for example the
1217         profiler tests run a ruby script that runs some other stuff) but it'll work for most of
1218         them and that's good enough for now.
1219
1220         * Scripts/run-jsc-stress-tests:
1221
1222 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
1223
1224         [Windows] Correct run-path when using 64-bit binaries.
1225
1226         Reviewed by David Kilzer.
1227
1228         * Scripts/webkitdirs.pm:
1229         (determineConfigurationProductDir): If running in 64-bit mode, use the 'bin64'
1230         directory. Otherwise use the existing 'bin32' directory.
1231
1232 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
1233
1234         Teach webkitdirs.pm to honor the --64-bit flag
1235         https://bugs.webkit.org/show_bug.cgi?id=122357
1236
1237         Reviewed by David Kilzer.
1238
1239         * Scripts/webkitdirs.pm:
1240         (argumentsForConfiguration): Modify to check if --64-bit is supplied
1241         by the user.
1242         (findMatchingArguments): Added.
1243         (hasArgument): Added.
1244         (checkForArgumentAndRemoveFromArrayRef): Refactor to use the new
1245         findMatchingArguments subroutine.
1246
1247 2013-10-04  Alexey Proskuryakov  <ap@apple.com>
1248
1249         Update svn-config for new Visual Studio extensions
1250         https://bugs.webkit.org/show_bug.cgi?id=122344
1251
1252         Reviewed by Brent Fulgham.
1253
1254         * svn-config: Add new Visual Studio extensions.
1255
1256 2013-10-04  Alex Christensen  <achristensen@webkit.org>
1257
1258         Made WinLauncher have better error handling, crash reporting, and modifiability.
1259         https://bugs.webkit.org/show_bug.cgi?id=122319
1260
1261         Reviewed by Brent Fulgham.
1262
1263         * WinLauncher/WinLauncher.cpp:
1264         (WinLauncherWebHost::didFailProvisionalLoadWithError):
1265         Don't display the numerous "Cancelled" messages that are obviously from the user.
1266         (createCrashReport): Added.
1267         (dllLauncherEntryPoint):
1268         Made main loop back into while loop and write a crash report if it crashes.
1269         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1270         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
1271         Added WinLauncherReplace.h.
1272         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
1273         Added linking to DbgHelp.lib.
1274         * WinLauncher/WinLauncherReplace.h:
1275         Added to make modifying WinLauncher behaviour and appearance easy.
1276         (processCrashDump): Added.
1277
1278 2013-10-04  Dirk Pranke  <dpranke@chromium.org>
1279
1280         remove dpranke from webkitpy watchlist
1281         https://bugs.webkit.org/show_bug.cgi?id=122331
1282
1283         Reviewed by Brent Fulgham.
1284
1285         * Scripts/webkitpy/common/config/watchlist:
1286
1287 2013-10-04  Tim Horton  <timothy_horton@apple.com>
1288
1289         [mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
1290         https://bugs.webkit.org/show_bug.cgi?id=122299
1291
1292         Reviewed by Beth Dakin.
1293
1294         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1295         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
1296         The last fix didn't work; instead of trying to block, turn off threaded scrolling for all three tests.
1297
1298 2013-10-04  Alexey Proskuryakov  <ap@apple.com>
1299
1300         Watchlist is broken after <http://trac.webkit.org/r156880>
1301
1302         * Scripts/webkitpy/common/config/watchlist: Remove an incorrect change.
1303
1304 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
1305
1306         Remove Qt features from build and test tools
1307         https://bugs.webkit.org/show_bug.cgi?id=122312
1308
1309         Reviewed by Anders Carlsson.
1310
1311         * Scripts/build-dumprendertree:
1312         * Scripts/build-jsc:
1313         * Scripts/build-webkit:
1314         * Scripts/build-webkittestrunner:
1315         * Scripts/old-run-webkit-tests:
1316         (openDumpTool):
1317         (buildPlatformResultHierarchy):
1318         (buildPlatformTestHierarchy):
1319         (readSkippedFiles):
1320         * Scripts/run-launcher:
1321         * Scripts/run-qtwebkit-tests: Removed.
1322         * Scripts/run-webkit-tests:
1323         (useNewRunWebKitTests):
1324         * Scripts/update-webkit:
1325         * Scripts/webkit-build-directory:
1326         * Scripts/webkitdirs.pm:
1327         (argumentsForConfiguration):
1328         (jscProductDir):
1329         (builtDylibPathForName):
1330         (isAppleWebKit):
1331         (launcherPath):
1332         (launcherName):
1333         (checkRequiredSystemConfig):
1334         (setupCygwinEnv):
1335         (copyInspectorFrontendFiles):
1336         (setPathForRunningWebKitApp):
1337         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
1338         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1339         (BaselineOptimizerTest.test_mac_future):
1340         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
1341         (BaselineOptimizerTest.test_common_directory_includes_root):
1342         (BaselineOptimizerTest.test_virtual_ports_filtered):
1343         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1344         (test_parse_reviewer_text):
1345         * Scripts/webkitpy/common/config/watchlist:
1346         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1347         (PortTest.disabled_test_chromium_mac_lion_in_test_shell_mode):
1348         * Scripts/webkitpy/port/base.py:
1349         (Port.__init__):
1350         (Port._port_flag_for_scripts):
1351         (Port._wk2_port_name):
1352         * Scripts/webkitpy/port/builders.py:
1353         * Scripts/webkitpy/port/factory.py:
1354         (platform_options):
1355         (PortFactory):
1356         (PortFactory._default_port):
1357         * Scripts/webkitpy/port/factory_unittest.py:
1358         (FactoryTest.test_gtk):
1359         * Scripts/webkitpy/port/qt.py: Removed.
1360         * Scripts/webkitpy/port/qt_unittest.py: Removed.
1361         * Scripts/webkitpy/style/checker.py:
1362         * Scripts/webkitpy/style/checker_unittest.py:
1363         (GlobalVariablesTest.test_path_rules_specifier):
1364         * Scripts/webkitpy/style/checkers/cmake.py:
1365         (CMakeChecker):
1366         * Scripts/webkitpy/style/checkers/cpp.py:
1367         (_classify_include):
1368         (check_include_line):
1369         (check_identifier_name_in_declaration):
1370         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1371         (OrderOfIncludesTest.test_classify_include):
1372         (WebKitStyleTest.test_names):
1373         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1374         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
1375         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1376         (TestRebaselineTest.test_baseline_directory):
1377         * Scripts/webkitpy/tool/main.py:
1378         (WebKitPatch):
1379
1380 2013-10-03  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1381
1382         Unreviewed. Add myself to some watchlists.
1383
1384         * Scripts/webkitpy/common/config/watchlist:
1385
1386 2013-10-03  Ryosuke Niwa  <rniwa@webkit.org>
1387
1388         Remove Qt builders from the flakiness dashboard.
1389
1390         * TestResultServer/static-dashboards/builders.jsonp:
1391         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1392         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1393         * TestResultServer/static-dashboards/loader_unittests.js:
1394
1395 2013-10-03  Tim Horton  <timothy_horton@apple.com>
1396
1397         [mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
1398         https://bugs.webkit.org/show_bug.cgi?id=122299
1399
1400         Reviewed by Beth Dakin.
1401
1402         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
1403         Disable threaded scrolling.
1404
1405         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1406         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
1407         Synchronously wait for the scrolling thread to inform the main thread of the new scroll position.
1408
1409 2013-10-03  Anders Carlsson  <andersca@apple.com>
1410
1411         Use numeric strings in the OS version dictionary
1412         https://bugs.webkit.org/show_bug.cgi?id=122300
1413
1414         Reviewed by Mark Rowe.
1415
1416         * Scripts/webkitpy/common/system/platforminfo.py:
1417         (PlatformInfo._determine_mac_version):
1418
1419 2013-10-03  Alexey Proskuryakov  <ap@apple.com>
1420
1421         Fix LeaksViewer to load leaks results from MountainLion, not Lion.
1422
1423         Rubber-stamped by Tim Horton.
1424
1425         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1426         (LeaksViewer._displayURLPrompt):
1427
1428 2013-10-03  Dan Bernstein  <mitz@apple.com>
1429
1430         REGRESSION (r156811): Objective-C JavaScriptCore API test failing on Mountain Lion bots
1431         https://bugs.webkit.org/show_bug.cgi?id=122260
1432
1433         Reviewed by Alexey Proskuryakov.
1434
1435         For the API to work, the tests need to be compiled with a newer version of the LLVM
1436         compiler. Until the bots are updated to that version, disable the tests on 10.8.
1437
1438         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
1439
1440 2013-10-02  Mario Sanchez Prada  <mario.prada@samsung.com>
1441
1442         [ATK] Expose aria-invalid as a text attribute (not object attribute)
1443         https://bugs.webkit.org/show_bug.cgi?id=122015
1444
1445         Reviewed by Chris Fleizach.
1446
1447         Adapted DRT and WKTR to check the exposure of the aria-invalid
1448         attribute as a text attribute, instead of an object attribute.
1449
1450         Also, done some refactoring of the code to try to keep things
1451         simpler and more coherent, by defining new helper functions,
1452         simplifying code, moving static variables and functions into
1453         unnammed namespaces and so on, without altering the logic other
1454         than for checking the text attribute for aria-invalid.
1455
1456         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1457         (coreAttributeToAtkAttribute): Consider 'invalid' as the name of
1458         the attribute exposed by the ATK wrapper, not 'aria-invalid'.
1459         Also, never return an empty string if not falling through any of
1460         the cases checked here, and return the original attribute instead.
1461         (atkAttributeValueToCoreAttributeValue): New helper function to
1462         match the attributes values returned by the ATK wrapper with the
1463         values expected by the layout tests. Moved the mappings for the
1464         values of AXSortDirection here as well.
1465         (getAttributeSet): New helper function to retrieve a list of
1466         attributes (an AtkAttributeSet) from an AtkObject using the right
1467         API depending on whether we want the object attributes or the text
1468         attributes (in case the object implements AtkText).
1469         (getAttributeSetValueForId): Simplified by using getAttributeSet
1470         and atkAttributeValueToCoreAttributeValue. Also, added a new
1471         parameter to indicater whether we are interested in object
1472         attributes or text attributes.
1473         (getAtkAttributeSetAsString): Ditto.
1474         (attributesOfElement): Updated to pass the new required parameter
1475         to getAtkAttributeSetAsString, indicating that we want the object
1476         attributes in this case, for backwards compatibility.
1477         (indexRangeInTable): Moved up in the file into the unnammed namespace.
1478         (alterCurrentValue): Ditto.
1479         (AccessibilityUIElement::stringAttributeValue): After moving most
1480         of the code here to the new helper functions, simplified it by
1481         just checking whether the required attribute is provided as an
1482         object attribute or, if that's not the case, as a text attribute.
1483         (AccessibilityUIElement::isAttributeSupported): Ditto.
1484         (AccessibilityUIElement::intValue): Updated to pass the new
1485         required parameter to getAttributeSetValueForId, indicating that
1486         we want the object attributes in this case.
1487         (AccessibilityUIElement::hasPopup): Ditto.
1488
1489         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1490         (WTR::coreAttributeToAtkAttribute): Same changes than for DRT.
1491         (WTR::atkAttributeValueToCoreAttributeValue): Ditto.
1492         (WTR::getAttributeSet): Ditto.
1493         (WTR::getAttributeSetValueForId): Ditto.
1494         (WTR::getAtkAttributeSetAsString): Ditto.
1495         (WTR::attributesOfElement): Ditto.
1496         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
1497         (WTR::AccessibilityUIElement::isAttributeSupported): Ditto.
1498         (WTR::AccessibilityUIElement::intValue): Ditto.
1499         (WTR::AccessibilityUIElement::hasPopup): Ditto.
1500
1501 2013-10-02  Ryosuke Niwa  <rniwa@webkit.org>
1502
1503         EWS build fix after the Qt EWS removal.
1504
1505         * QueueStatusServer/model/attachment.py:
1506         (Attachment._calculate_queue_positions):
1507
1508 2013-10-02  Anders Carlsson  <andersca@apple.com>
1509
1510         Remove Qt code from Tools/
1511         https://bugs.webkit.org/show_bug.cgi?id=122227
1512
1513         Reviewed by Andreas Kling.
1514
1515         * DumpRenderTree/WorkQueue.cpp:
1516         * DumpRenderTree/blackberry/src.pro: Removed.
1517         * DumpRenderTree/qt/DumpRenderTree.pro: Removed.
1518         * DumpRenderTree/qt/DumpRenderTree.qrc: Removed.
1519         * DumpRenderTree/qt/DumpRenderTreeMain.cpp: Removed.
1520         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Removed.
1521         * DumpRenderTree/qt/DumpRenderTreeQt.h: Removed.
1522         * DumpRenderTree/qt/EventSenderQt.cpp: Removed.
1523         * DumpRenderTree/qt/EventSenderQt.h: Removed.
1524         * DumpRenderTree/qt/GCControllerQt.cpp: Removed.
1525         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Removed.
1526         * DumpRenderTree/qt/TestRunnerQt.cpp: Removed.
1527         * DumpRenderTree/qt/TestRunnerQt.h: Removed.
1528         * DumpRenderTree/qt/TextInputControllerQt.cpp: Removed.
1529         * DumpRenderTree/qt/TextInputControllerQt.h: Removed.
1530         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Removed.
1531         * DumpRenderTree/qt/WorkQueueItemQt.h: Removed.
1532         * DumpRenderTree/qt/fonts/AHEM____.TTF: Removed.
1533         * DumpRenderTree/qt/resources/user.css: Removed.
1534         * DumpRenderTree/qt/testplugin.cpp: Removed.
1535         * DumpRenderTree/qt/testplugin.h: Removed.
1536         * ImageDiff/ImageDiff.pro: Removed.
1537         * ImageDiff/qt/ImageDiff.cpp: Removed.
1538         * MiniBrowser/qt/BrowserWindow.cpp: Removed.
1539         * MiniBrowser/qt/BrowserWindow.h: Removed.
1540         * MiniBrowser/qt/MiniBrowser.pro: Removed.
1541         * MiniBrowser/qt/MiniBrowser.qrc: Removed.
1542         * MiniBrowser/qt/MiniBrowserApplication.cpp: Removed.
1543         * MiniBrowser/qt/MiniBrowserApplication.h: Removed.
1544         * MiniBrowser/qt/UrlLoader.cpp: Removed.
1545         * MiniBrowser/qt/UrlLoader.h: Removed.
1546         * MiniBrowser/qt/icons/checkbox_checked.png: Removed.
1547         * MiniBrowser/qt/icons/checkbox_unchecked.png: Removed.
1548         * MiniBrowser/qt/icons/contents_width.png: Removed.
1549         * MiniBrowser/qt/icons/favicon.png: Removed.
1550         * MiniBrowser/qt/icons/find.png: Removed.
1551         * MiniBrowser/qt/icons/folder.png: Removed.
1552         * MiniBrowser/qt/icons/info.png: Removed.
1553         * MiniBrowser/qt/icons/next.png: Removed.
1554         * MiniBrowser/qt/icons/plus.png: Removed.
1555         * MiniBrowser/qt/icons/previous.png: Removed.
1556         * MiniBrowser/qt/icons/refresh.png: Removed.
1557         * MiniBrowser/qt/icons/stop.png: Removed.
1558         * MiniBrowser/qt/icons/titlebar.png: Removed.
1559         * MiniBrowser/qt/icons/touch.png: Removed.
1560         * MiniBrowser/qt/icons/touchpoint.png: Removed.
1561         * MiniBrowser/qt/icons/up.png: Removed.
1562         * MiniBrowser/qt/js/MultiSelect.js: Removed.
1563         * MiniBrowser/qt/main.cpp: Removed.
1564         * MiniBrowser/qt/qml/AlertDialog.qml: Removed.
1565         * MiniBrowser/qt/qml/AuthenticationDialog.qml: Removed.
1566         * MiniBrowser/qt/qml/BrowserWindow.qml: Removed.
1567         * MiniBrowser/qt/qml/CheckBox.qml: Removed.
1568         * MiniBrowser/qt/qml/ColorChooser.qml: Removed.
1569         * MiniBrowser/qt/qml/ConfirmDialog.qml: Removed.
1570         * MiniBrowser/qt/qml/Dialog.qml: Removed.
1571         * MiniBrowser/qt/qml/DialogButton.qml: Removed.
1572         * MiniBrowser/qt/qml/DialogLineInput.qml: Removed.
1573         * MiniBrowser/qt/qml/FilePicker.qml: Removed.
1574         * MiniBrowser/qt/qml/ItemSelector.qml: Removed.
1575         * MiniBrowser/qt/qml/MockTouchPoint.qml: Removed.
1576         * MiniBrowser/qt/qml/PromptDialog.qml: Removed.
1577         * MiniBrowser/qt/qml/ProxyAuthenticationDialog.qml: Removed.
1578         * MiniBrowser/qt/qml/ScrollIndicator.qml: Removed.
1579         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Removed.
1580         * MiniBrowser/qt/raw/DerivedSources.pri: Removed.
1581         * MiniBrowser/qt/raw/MiniBrowserRaw.pro: Removed.
1582         * MiniBrowser/qt/raw/Target.pri: Removed.
1583         * MiniBrowser/qt/raw/View.cpp: Removed.
1584         * MiniBrowser/qt/raw/View.h: Removed.
1585         * MiniBrowser/qt/utils.cpp: Removed.
1586         * MiniBrowser/qt/utils.h: Removed.
1587         * QtTestBrowser/QtTestBrowser.pro: Removed.
1588         * QtTestBrowser/QtTestBrowser.qrc: Removed.
1589         * QtTestBrowser/cookiejar.cpp: Removed.
1590         * QtTestBrowser/cookiejar.h: Removed.
1591         * QtTestBrowser/favicon.png: Removed.
1592         * QtTestBrowser/fpstimer.cpp: Removed.
1593         * QtTestBrowser/fpstimer.h: Removed.
1594         * QtTestBrowser/launcherwindow.cpp: Removed.
1595         * QtTestBrowser/launcherwindow.h: Removed.
1596         * QtTestBrowser/locationedit.cpp: Removed.
1597         * QtTestBrowser/locationedit.h: Removed.
1598         * QtTestBrowser/mainwindow.cpp: Removed.
1599         * QtTestBrowser/mainwindow.h: Removed.
1600         * QtTestBrowser/qttestbrowser.cpp: Removed.
1601         * QtTestBrowser/urlloader.cpp: Removed.
1602         * QtTestBrowser/urlloader.h: Removed.
1603         * QtTestBrowser/useragentlist.txt: Removed.
1604         * QtTestBrowser/utils.cpp: Removed.
1605         * QtTestBrowser/utils.h: Removed.
1606         * QtTestBrowser/webinspector.h: Removed.
1607         * QtTestBrowser/webpage.cpp: Removed.
1608         * QtTestBrowser/webpage.h: Removed.
1609         * QtTestBrowser/webview.cpp: Removed.
1610         * QtTestBrowser/webview.h: Removed.
1611         * TestWebKitAPI/DerivedSources.pri: Removed.
1612         * TestWebKitAPI/InjectedBundle.pri: Removed.
1613         * TestWebKitAPI/PlatformWebView.h:
1614         * TestWebKitAPI/TestWebKitAPI.pri: Removed.
1615         * TestWebKitAPI/TestWebKitAPI.pro: Removed.
1616         * TestWebKitAPI/Tests.pri: Removed.
1617         * TestWebKitAPI/Tests/JavaScriptCore/JavaScriptCore.pro: Removed.
1618         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
1619         * TestWebKitAPI/Tests/WTF/WTF.pro: Removed.
1620         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro: Removed.
1621         * TestWebKitAPI/qt/InjectedBundleControllerQt.cpp: Removed.
1622         * TestWebKitAPI/qt/PlatformUtilitiesQt.cpp: Removed.
1623         * TestWebKitAPI/qt/PlatformWebViewQt.cpp: Removed.
1624         * TestWebKitAPI/qt/main.cpp: Removed.
1625         * Tools.pro: Removed.
1626         * WebKitTestRunner/DerivedSources.pri: Removed.
1627         * WebKitTestRunner/EventSenderProxy.h:
1628         * WebKitTestRunner/InjectedBundle/DerivedSources.pri: Removed.
1629         * WebKitTestRunner/InjectedBundle/InjectedBundle.pro: Removed.
1630         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1631         (WTR::InjectedBundlePage::resetAfterTest):
1632         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
1633         (WTR::InjectedBundlePage::didClearWindowForFrame):
1634         * WebKitTestRunner/InjectedBundle/Target.pri: Removed.
1635         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1636         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: Removed.
1637         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp: Removed.
1638         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp: Removed.
1639         * WebKitTestRunner/PlatformWebView.h:
1640         * WebKitTestRunner/Target.pri: Removed.
1641         * WebKitTestRunner/TestController.cpp:
1642         (WTR::TestController::resetStateToConsistentValues):
1643         * WebKitTestRunner/TestController.h:
1644         * WebKitTestRunner/WebKitTestRunner.pro: Removed.
1645         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Removed.
1646         * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Removed.
1647         * WebKitTestRunner/qt/TestControllerQt.cpp: Removed.
1648         * WebKitTestRunner/qt/TestInvocationQt.cpp: Removed.
1649         * WebKitTestRunner/qt/WebKitTestRunner.qrc: Removed.
1650         * WebKitTestRunner/qt/main.cpp: Removed.
1651         * WebKitTestRunner/qt/resources/user.css: Removed.
1652         * qmake/.qmake.cache: Removed.
1653         * qmake/.qmake.conf: Removed.
1654         * qmake/README: Removed.
1655         * qmake/config.tests/README: Removed.
1656         * qmake/config.tests/fontconfig/fontconfig.cpp: Removed.
1657         * qmake/config.tests/fontconfig/fontconfig.pro: Removed.
1658         * qmake/config.tests/gccdepends/empty.cpp: Removed.
1659         * qmake/config.tests/gccdepends/gccdepends.pro: Removed.
1660         * qmake/config.tests/glx/glx.cpp: Removed.
1661         * qmake/config.tests/glx/glx.pro: Removed.
1662         * qmake/config.tests/gnuld/gnuld.pro: Removed.
1663         * qmake/config.tests/gnuld/main.cpp: Removed.
1664         * qmake/config.tests/libXcomposite/libXcomposite.cpp: Removed.
1665         * qmake/config.tests/libXcomposite/libXcomposite.pro: Removed.
1666         * qmake/config.tests/libXrender/libXrender.cpp: Removed.
1667         * qmake/config.tests/libXrender/libXrender.pro: Removed.
1668         * qmake/config.tests/libwebp/libwebp.cpp: Removed.
1669         * qmake/config.tests/libwebp/libwebp.pro: Removed.
1670         * qmake/config.tests/libxml2/libxml2.cpp: Removed.
1671         * qmake/config.tests/libxml2/libxml2.pro: Removed.
1672         * qmake/config.tests/libxslt/libxslt.cpp: Removed.
1673         * qmake/config.tests/libxslt/libxslt.pro: Removed.
1674         * qmake/config.tests/libzlib/libzlib.cpp: Removed.
1675         * qmake/config.tests/libzlib/libzlib.pro: Removed.
1676         * qmake/dump-features.pl: Removed.
1677         * qmake/mkspecs/features/configure.prf: Removed.
1678         * qmake/mkspecs/features/default_post.prf: Removed.
1679         * qmake/mkspecs/features/default_pre.prf: Removed.
1680         * qmake/mkspecs/features/features.prf: Removed.
1681         * qmake/mkspecs/features/features.pri: Removed.
1682         * qmake/mkspecs/features/force_static_libs_as_shared.prf: Removed.
1683         * qmake/mkspecs/features/functions.prf: Removed.
1684         * qmake/mkspecs/features/gprof.prf: Removed.
1685         * qmake/mkspecs/features/mac/default_post.prf: Removed.
1686         * qmake/mkspecs/features/mac/default_pre.prf: Removed.
1687         * qmake/mkspecs/features/minimal_qt.prf: Removed.
1688         * qmake/mkspecs/features/production_build.prf: Removed.
1689         * qmake/mkspecs/features/rpath.prf: Removed.
1690         * qmake/mkspecs/features/unix/default_post.prf: Removed.
1691         * qmake/mkspecs/features/unix/default_pre.prf: Removed.
1692         * qmake/mkspecs/features/unix/icc.prf: Removed.
1693         * qmake/mkspecs/features/use_all_in_one_files.prf: Removed.
1694         * qmake/mkspecs/features/valgrind.prf: Removed.
1695         * qmake/mkspecs/features/webkit_modules.prf: Removed.
1696         * qmake/mkspecs/features/win32/default_post.prf: Removed.
1697         * qmake/mkspecs/features/win32/default_pre.prf: Removed.
1698         * qmake/mkspecs/modules/angle.prf: Removed.
1699         * qmake/mkspecs/modules/javascriptcore.prf: Removed.
1700         * qmake/mkspecs/modules/webcore.prf: Removed.
1701         * qmake/mkspecs/modules/webkit1.prf: Removed.
1702         * qmake/mkspecs/modules/webkit2.prf: Removed.
1703         * qmake/mkspecs/modules/wtf.prf: Removed.
1704
1705 2013-10-02  Tim Horton  <timothy_horton@apple.com>
1706
1707         [mac] Stop using DrawingAreaImpl on PLATFORM(MAC) 
1708         https://bugs.webkit.org/show_bug.cgi?id=121859
1709         <rdar://problem/15069359>
1710
1711         Reviewed by Anders Carlsson.
1712
1713         * WebKitTestRunner/TestInvocation.cpp:
1714         (WTR::shouldUseThreadedScrolling):
1715         (WTR::updateThreadedScrollingForCurrentTest):
1716         (WTR::TestInvocation::invoke):
1717         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1718         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useThreadedScrolling:]):
1719         (WTR::PlatformWebView::PlatformWebView):
1720         (WTR::PlatformWebView::viewSupportsOptions):
1721         Rename the tiled drawing switch to threaded scrolling, since that's really
1722         all it switches now that we use tiled drawing everywhere.
1723
1724         Use an unbuffered window, as well, to avoid snapshotting issues on some platforms
1725         and to more closely match the case we're interested in testing.
1726
1727 2013-10-02  Anders Carlsson  <andersca@apple.com>
1728
1729         Move AHEM____.TTF from qt/fonts/ to fonts/.
1730
1731         Rubber-stamped by Andreas Kling.
1732
1733         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1734         * DumpRenderTree/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/qt/fonts/AHEM____.TTF.
1735
1736 2013-10-02  Ádám Kallai  <kadam@inf.u-szeged.hu>
1737
1738         Remove Qt bots and EWS from trunk.
1739         https://bugs.webkit.org/show_bug.cgi?id=122210.
1740
1741         Reviewed by Allan Sandfeld Jensen.
1742
1743         Remove Qt buil dbots.
1744
1745         * BuildSlaveSupport/build.webkit.org-config/config.json:
1746         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1747         (appendCustomBuildFlags):
1748         (RunGtkAPITests.getText2):
1749         (Factory.__init__):
1750         (TestFactory.__init__):
1751         (BuildAndTestFactory.__init__):
1752         (loadBuilderConfig):
1753         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1754
1755 2013-10-02  Ádám Kallai  <kadam@inf.u-szeged.hu>
1756
1757         Remove Qt bots and EWS from trunk.
1758         https://bugs.webkit.org/show_bug.cgi?id=122210.
1759
1760         Reviewed by Allan Sandfeld Jensen.
1761
1762         Remove Qt EWS bots.
1763
1764         * QueueStatusServer/config/queues.py:
1765         * Scripts/webkitpy/common/config/ews.json:
1766
1767 2013-10-01  Timothy Hatcher  <timothy@apple.com>
1768
1769         Fix singular labels for test failures.
1770
1771         https://bugs.webkit.org/show_bug.cgi?id=122200
1772
1773         Reviewed by Joseph Pecoraro.
1774
1775         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1776         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1777
1778 2013-10-01  Timothy Hatcher  <timothy@apple.com>
1779
1780         Don't keep appending iterations each time the queue updates.
1781
1782         https://bugs.webkit.org/show_bug.cgi?id=122198
1783
1784         Reviewed by Joseph Pecoraro.
1785
1786         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1787         (BuildbotQueue.prototype.update):
1788
1789 2013-10-01  Timothy Hatcher  <timothy@apple.com>
1790
1791         Properly sort iterations in the Dashboard by revision for out-of-order queues.
1792
1793         https://bugs.webkit.org/show_bug.cgi?id=122196
1794
1795         Reviewed by Brent Fulgham.
1796
1797         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1798         (BuildbotIteration):
1799         (BuildbotIteration.prototype.update):
1800         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1801         (BuildbotQueue.prototype.update):
1802         (BuildbotQueue.prototype.sortIterations):
1803
1804 2013-10-01  Timothy Hatcher  <timothy@apple.com>
1805
1806         Fix some exceptions seen in the Buildbot Dashboard when looking at unloaded iterations.
1807
1808         Also fix some URLs to not have extras slashes and add a page title.
1809
1810         https://bugs.webkit.org/show_bug.cgi?id=122192
1811
1812         Reviewed by Joseph Pecoraro.
1813
1814         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1815         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1816         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1817         (WebKitBuildbot.prototype.buildLogURLForIteration):
1818         (WebKitBuildbot.prototype.layoutTestResultsURLForIteration):
1819         (WebKitBuildbot.prototype.javascriptTestResultsURLForIteration):
1820         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1821
1822 2013-10-01  Alexey Proskuryakov  <ap@apple.com>
1823
1824         [Mac] Set NSApplication current event while sending events directly to views
1825         https://bugs.webkit.org/show_bug.cgi?id=122179
1826
1827         Reviewed by Darin Adler.
1828
1829         DumpRenderTree and WebKitTestRunner send events directly to WebHMTLView or WKView,
1830         which doesn't update [NSApp currentEvent]. But there are many places in WebKit that
1831         use the current event.
1832
1833         * DumpRenderTree/mac/EventSendingController.mm:
1834         (-[EventSendingController mouseDown:withModifiers:]):
1835         (-[EventSendingController mouseUp:withModifiers:]):
1836         (-[EventSendingController mouseMoveToX:Y:]):
1837         (-[EventSendingController mouseScrollByX:andY:continuously:]):
1838         (-[EventSendingController contextClick]):
1839         (-[EventSendingController keyDown:withModifiers:withLocation:]):
1840         * WebKitTestRunner/mac/EventSenderProxy.mm:
1841         (WTR::EventSenderProxy::mouseDown):
1842         (WTR::EventSenderProxy::mouseUp):
1843         (WTR::EventSenderProxy::mouseMoveTo):
1844         (WTR::EventSenderProxy::keyDown):
1845         (WTR::EventSenderProxy::mouseScrollBy):
1846         Update the current event. We were already using the SPI in WebKit.
1847
1848 2013-10-01  Joseph Pecoraro  <pecoraro@apple.com>
1849
1850         Buildbot Dashboard: Fix JSHint issue: 'perlTestResults' used out of scope.
1851         https://bugs.webkit.org/show_bug.cgi?id=122183
1852
1853         Reviewed by Timothy Hatcher.
1854
1855         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1856         (BuildbotIteration.prototype.update):
1857
1858 2013-10-01  Timothy Hatcher  <timothy@apple.com>
1859
1860         Tweaks to the Buildbot Dashboard
1861
1862         https://bugs.webkit.org/show_bug.cgi?id=122169
1863
1864         Reviewed by Alexey Proskuryakov.
1865
1866         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1867         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
1868         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1869         (BuildbotQueueView.prototype.revisionLinksForIteration):
1870         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1871         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1872         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Added.
1873         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1874         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1875         (WebKitBuildbot.prototype.buildLogURLForIteration):
1876         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1877
1878 2013-10-01  Commit Queue  <commit-queue@webkit.org>
1879
1880         Unreviewed, rolling out r156725.
1881         http://trac.webkit.org/changeset/156725
1882         https://bugs.webkit.org/show_bug.cgi?id=122176
1883
1884         broke all the mismatch tests again (Requested by thorton on
1885         #webkit).
1886
1887         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1888         (WTR::PlatformWebView::PlatformWebView):
1889
1890 2013-10-01  Alex Christensen  <achristensen@webkit.org>
1891
1892         Implemented createWebViewWithRequest in WinLauncher.
1893         https://bugs.webkit.org/show_bug.cgi?id=122069
1894
1895         Reviewed by Brent Fulgham.
1896
1897         * WinLauncher/PrintWebUIDelegate.cpp:
1898         (PrintWebUIDelegate::createWebViewWithRequest): Added.
1899         * WinLauncher/PrintWebUIDelegate.h:
1900         Removed createWebViewWithRequest stub.
1901
1902 2013-10-01  Tim Horton  <timothy_horton@apple.com>
1903
1904         [wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
1905         https://bugs.webkit.org/show_bug.cgi?id=122006
1906         <rdar://problem/15095197>
1907
1908         Reviewed by Dean Jackson.
1909
1910         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1911         (WTR::PlatformWebView::PlatformWebView):
1912         Layer-back the root view in WebKitTestRunner's window, to work around a bug
1913         where the window server snapshot API returns blank snapshots.
1914
1915         Re-landing after r156724, this should not break everything now.
1916
1917 2013-10-01  Tim Horton  <timothy_horton@apple.com>
1918
1919         [mac] 1x emulation on Retina hardware shouldn't use SPI
1920         https://bugs.webkit.org/show_bug.cgi?id=122152
1921         <rdar://problem/15119384>
1922
1923         Reviewed by Anders Carlsson.
1924
1925         * DumpRenderTree/mac/DumpRenderTree.mm:
1926         (createWebViewAndOffscreenWindow):
1927         (main):
1928         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1929         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1930         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1931         (WTR::PlatformWebView::PlatformWebView):
1932         * WebKitTestRunner/mac/main.mm:
1933         (main):
1934         Register for AppleMagnifiedMode instead of using _setWindowResolution:displayIfChanged:.
1935
1936 2013-09-30  Sam Weinig  <sam@webkit.org>
1937
1938         check-webkit-style should not warn about use of C++11 “>>”  instead of “> >"
1939         https://bugs.webkit.org/show_bug.cgi?id=116474
1940
1941         Reviewed by Ryosuke Niwa.
1942
1943         * Scripts/webkitpy/style/checkers/cpp.py:
1944         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1945
1946 2013-09-30  Sam Weinig  <sam@webkit.org>
1947
1948         Remove support for DOMFileSystem
1949         https://bugs.webkit.org/show_bug.cgi?id=122137
1950
1951         Reviewed by Anders Carlsson.
1952
1953         * Scripts/webkitperl/FeatureList.pm:
1954         * Scripts/webkitpy/style/checkers/cpp.py:
1955         (check_spacing):
1956         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1957         (CppStyleTest.test_spacing_for_binary_ops):
1958         * qmake/mkspecs/features/features.pri:
1959
1960 2013-09-30  Mark Rowe  <mrowe@apple.com>
1961
1962         More build fixage for builds with SDKs.
1963
1964         * WebKitTestRunner/Configurations/Base.xcconfig:
1965         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
1966
1967 2013-09-30  Timothy Hatcher  <timothy@apple.com>
1968
1969         Add initial version of a new Buildbot dashboard view.
1970
1971         https://bugs.webkit.org/show_bug.cgi?id=122131
1972
1973         Reviewed by Alexey Proskuryakov.
1974
1975         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Added.
1976         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Added.
1977         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png: Added.
1978         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks@2x.png: Added.
1979         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Added.
1980         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Added.
1981         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing.png: Added.
1982         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing@2x.png: Added.
1983         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7.png: Added.
1984         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7@2x.png: Added.
1985         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8.png: Added.
1986         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8@2x.png: Added.
1987         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP.png: Added.
1988         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP@2x.png: Added.
1989         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BaseObject.js: Added.
1990         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js: Added.
1991         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js: Added.
1992         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Added.
1993         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: Added.
1994         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: Added.
1995         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js: Added.
1996         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: Added.
1997         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Added.
1998         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js: Added.
1999         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js: Added.
2000         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: Added.
2001         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotBuilderQueueView.css: Added.
2002         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css: Added.
2003         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotTesterQueueView.css: Added.
2004         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Added.
2005         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css: Added.
2006         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added.
2007
2008 2013-09-30  Benjamin Poulain  <benjamin@webkit.org>
2009
2010         Remove the code guarded by STYLE_SCOPED
2011         https://bugs.webkit.org/show_bug.cgi?id=122123
2012
2013         Reviewed by Anders Carlsson.
2014
2015         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2016         (resetDefaultsToConsistentValues):
2017         * Scripts/webkitperl/FeatureList.pm:
2018         * qmake/mkspecs/features/features.pri:
2019
2020 2013-09-30  Mark Rowe  <mrowe@apple.com>
2021
2022         Fix the build when building against an SDK.
2023
2024         Xcode helpfully prepends $(SDKROOT) to the paths in FRAMEWORK_SEARCH_PATHS when generating
2025         the compiler command lines. It can't know to do this for the system framework search paths
2026         we add manually via OTHER_CFLAGS though, so we need to prefix them with $(SDKROOT) ourself.
2027
2028         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
2029         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
2030
2031 2013-09-30  Brent Fulgham  <bfulgham@apple.com>
2032
2033         [Windows] Unreviewed test fix. Prevent crash when changing URL paths during testing.
2034
2035         A shared BSTR value (_bstr_t) was being reallocated outside the smart pointer, causing
2036         it to be double-freed.
2037
2038         * WinLauncher/WinLauncher.cpp:
2039         (EditProc): Be explicit about type passed to loadURL.
2040         (loadURL): Create a shallow copy of the BSTR so we only allocate memory if needed. Use _bstr_t so
2041         that reallocating the BSTR is done with the knowledge of the smart pointer.
2042
2043 2013-09-30  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2044
2045         [Qt] Fix force_static_libs_as_shared in WebKit2
2046         https://bugs.webkit.org/show_bug.cgi?id=121961
2047
2048         Reviewed by Csaba Osztrogonác.
2049
2050         Get rid of the unused WebKit2QML library
2051
2052         * qmake/mkspecs/features/webkit_modules.prf:
2053         * qmake/mkspecs/modules/webkit2qml.prf: Removed.
2054
2055 2013-09-30  Krzysztof Wolanski  <k.wolanski@samsung.com>
2056
2057         [EFL] Fix incorrect click counting in EventSenderProxy
2058         https://bugs.webkit.org/show_bug.cgi?id=122098
2059
2060         Reviewed by Gyuyoung Kim.
2061
2062         Previously used two types of recording time, which conflicted with each other.
2063
2064         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2065         (WTR::EventSenderProxy::mouseUp):
2066
2067 2013-09-30  Zan Dobersek  <zdobersek@igalia.com>
2068
2069         [webkitpy] Make the Xvfb screen depth overridable
2070         https://bugs.webkit.org/show_bug.cgi?id=122089
2071
2072         Reviewed by Gyuyoung Kim.
2073
2074         Make the Xvfb screen depth overridable by checking if the XVFB_SCREEN_DEPTH environment variable
2075         was set. The default value that's used if the variable wasn't set is 24.
2076
2077         * Scripts/webkitpy/port/xvfbdriver.py:
2078         (XvfbDriver._xvfb_screen_depth):
2079         (XvfbDriver._start):
2080         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
2081         (XvfbDriverTest.make_driver):
2082         (XvfbDriverTest.test_start_no_pixel_tests):
2083         (XvfbDriverTest.test_start_pixel_tests):
2084         (XvfbDriverTest.test_start_arbitrary_worker_number):
2085         (XvfbDriverTest.test_next_free_display):
2086         (XvfbDriverTest.test_start_next_worker):
2087
2088 2013-09-29  Mark Rowe  <mrowe@apple.com>
2089
2090         Fix the Lion build.
2091
2092         Ensure that C++ and Objective-C++ files build with the right compiler flags.
2093
2094         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
2095         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
2096
2097 2013-09-28  Mark Rowe  <mrowe@apple.com>
2098
2099         Fix some failures with newer versions of clang.
2100
2101         Some CoreGraphics headers generate warnings under newer versions of clang. Since they're system headers the warnings would
2102         usually be suppressed, but we're adding the frameworks to the non-system framework search path so they're no longer treated
2103         as system headers. We address this by removing the system paths from FRAMEWORK_SEARCH_PATHS and using the -iframework compiler
2104         flag in OTHER_CFLAGS to add the paths to the system framework search path. We have to set OTHER_CFLAGS at the target level
2105         in order for it to coexist with the ASAN-related OTHER_CFLAGS that's set in DebugRelease.xcconfig.
2106
2107         Reviewed by Dan Bernstein.
2108
2109         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2110         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
2111         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2112         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2113         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
2114         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
2115         * WebKitTestRunner/Configurations/Base.xcconfig:
2116         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
2117         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2118         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2119         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2120
2121 2013-09-27  Commit Queue  <commit-queue@webkit.org>
2122
2123         Unreviewed, rolling out r156569.
2124         http://trac.webkit.org/changeset/156569
2125         https://bugs.webkit.org/show_bug.cgi?id=122035
2126
2127         broke a lot of mismatch tests (Requested by thorton on
2128         #webkit).
2129
2130         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2131         (WTR::PlatformWebView::PlatformWebView):
2132
2133 2013-09-27  Alexey Proskuryakov  <ap@apple.com>
2134
2135         Don't retry failures on Apple MountainLion Release WK1 tester
2136         https://bugs.webkit.org/show_bug.cgi?id=122026
2137
2138         Reviewed by Mark Rowe.
2139
2140         * BuildSlaveSupport/build.webkit.org-config/config.json: Added --no-retry-failures
2141         on this bot.
2142
2143 2013-09-27  Alexey Proskuryakov  <ap@apple.com>
2144
2145         Don't hardcode builder specific configuration in buildbot master.cfg
2146         https://bugs.webkit.org/show_bug.cgi?id=122023
2147
2148         Reviewed by Mark Rowe.
2149
2150         * BuildSlaveSupport/build.webkit.org-config/config.json: Added an additionalArguments
2151         property to Qt Mountain Lion Release, making it run pixel tests.
2152
2153         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2154         (RunWebKitTests.start): Use additionalArguments.
2155         (RunWebKit2Tests.start): Don't hardcode individual bot behavior here.
2156
2157 2013-09-27  Tim Horton  <timothy_horton@apple.com>
2158
2159         [wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
2160         https://bugs.webkit.org/show_bug.cgi?id=122006
2161         <rdar://problem/15095197>
2162
2163         Reviewed by Dean Jackson.
2164
2165         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2166         (WTR::PlatformWebView::PlatformWebView):
2167         Layer-back the root view in WebKitTestRunner's window, to work around a bug
2168         where the window server snapshot API returns blank snapshots.
2169
2170 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
2171
2172         [GTK] GTK does not expose heading level correctly. Was: accessibility/heading-level.html is failing
2173         https://bugs.webkit.org/show_bug.cgi?id=106924
2174
2175         Reviewed by Chris Fleizach.
2176
2177         Consider headings levels as values to be returned in intValue()
2178         both in DRT and WKTR, so we can share more tests with other ports.
2179
2180         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2181         (AccessibilityUIElement::intValue): Consider headings too.
2182         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2183         (WTR::AccessibilityUIElement::intValue): Ditto.
2184
2185 2013-09-26  Darin Adler  <darin@apple.com>
2186
2187         rename KURL to URL
2188         https://bugs.webkit.org/show_bug.cgi?id=16214
2189
2190         Reviewed by Andreas Kling.
2191
2192         * many files: Renamed, using script.
2193
2194 2013-09-27  Darin Adler  <darin@apple.com>
2195
2196         Fix Python scripts test failures.
2197
2198         * Scripts/webkitpy/style/checkers/cpp.py:
2199         (_FunctionState.modifiers_and_return_type): Added this back. Used only by tests
2200         now, not by the checker itself.
2201
2202 2013-09-27  Denis Nomiyama  <d.nomiyama@samsung.com>
2203
2204         [GTK][WK2] Logging of accessibility events is not disabled between tests
2205         https://bugs.webkit.org/show_bug.cgi?id=121957
2206
2207         Reviewed by Mario Sanchez Prada.
2208
2209         Fixed an issue in AccessibilityNotificationHandler where the destructor
2210         was not disconnecting accessibility event callbacks if logging was on.
2211         The decision of disconnecting events can solely rely on the existence of
2212         notification handlers because logging uses the global notification
2213         handler.
2214
2215         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2216         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks): Fixed
2217         disconnection when logging is on.
2218
2219 2013-09-27  Patrick Gansterer  <paroga@webkit.org>
2220
2221         Add general CMakeLists.txt for DRT
2222         https://bugs.webkit.org/show_bug.cgi?id=119268
2223
2224         Reviewed by Gyuyoung Kim.
2225
2226         The new file allows better sharing between ports.
2227
2228         * CMakeLists.txt:
2229         * DumpRenderTree/CMakeLists.txt: Added.
2230         * DumpRenderTree/PlatformEfl.cmake: Added.
2231         * DumpRenderTree/efl/CMakeLists.txt: Removed.
2232
2233 2013-09-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2234
2235         [Qt] Fix force_static_libs_as_shared in WebKit2
2236         https://bugs.webkit.org/show_bug.cgi?id=121961
2237
2238         Reviewed by Csaba Osztrogonác.
2239
2240         Reenable force_static_libs_as_shared when building WebKit2.
2241
2242         * qmake/mkspecs/features/default_post.prf:
2243
2244 2013-09-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2245
2246         [Qt] Mock implementations of positioning and orientation not used
2247         https://bugs.webkit.org/show_bug.cgi?id=121956
2248
2249         Reviewed by Csaba Osztrogonác.
2250
2251         Move production_build checks to sanitizeFeatures where its value is actually known.
2252
2253         * qmake/mkspecs/features/features.prf:
2254         * qmake/mkspecs/features/features.pri:
2255
2256 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
2257
2258         [ATK] Normalize checks in entry points for DRT and WKTR
2259         https://bugs.webkit.org/show_bug.cgi?id=121959
2260
2261         Reviewed by Chris Fleizach.
2262
2263         Always check if we have a proper instance of AtkObject,
2264         implementing the interfaces that we might need for each case, at
2265         the entry point of every method of AccessibilityUIElement for ATK,
2266         and do those checks in an uniform way across DRT and WKTR, to
2267         avoid confusion and issues when modifying these files in the future.
2268
2269         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2270         (AccessibilityUIElement::getChildren): Use normalized checks.
2271         (AccessibilityUIElement::getChildrenWithRange): Ditto.
2272         (AccessibilityUIElement::rowCount): Ditto.
2273         (AccessibilityUIElement::columnCount): Ditto.
2274         (AccessibilityUIElement::childrenCount): Ditto.
2275         (AccessibilityUIElement::elementAtPoint): Ditto.
2276         (AccessibilityUIElement::getChildAtIndex): Ditto.
2277         (AccessibilityUIElement::allAttributes): Ditto.
2278         (AccessibilityUIElement::titleUIElement): Ditto.
2279         (AccessibilityUIElement::parentElement): Ditto.
2280         (AccessibilityUIElement::attributesOfChildren): Ditto.
2281         (AccessibilityUIElement::role): Ditto.
2282         (AccessibilityUIElement::title): Ditto.
2283         (AccessibilityUIElement::description): Ditto.
2284         (AccessibilityUIElement::stringValue): Ditto.
2285         (AccessibilityUIElement::language): Ditto.
2286         (AccessibilityUIElement::x): Ditto.
2287         (AccessibilityUIElement::y): Ditto.
2288         (AccessibilityUIElement::width): Ditto.
2289         (AccessibilityUIElement::height): Ditto.
2290         (AccessibilityUIElement::orientation): Ditto.
2291         (AccessibilityUIElement::intValue): Ditto.
2292         (AccessibilityUIElement::minValue): Ditto.
2293         (AccessibilityUIElement::maxValue): Ditto.
2294         (indexRangeInTable): Ditto.
2295         (AccessibilityUIElement::cellForColumnAndRow): Ditto.
2296         (AccessibilityUIElement::stringAttributeValue): Ditto.
2297         (alterCurrentValue): Ditto.
2298         (AccessibilityUIElement::press): Ditto.
2299         (AccessibilityUIElement::documentEncoding): Ditto.
2300         (AccessibilityUIElement::documentURI): Ditto.
2301         (AccessibilityUIElement::hasPopup): Ditto.
2302
2303         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2304         (WTR::indexRangeInTable): Use normalized checks.
2305         (WTR::alterCurrentValue): Ditto.
2306         (WTR::AccessibilityUIElement::getChildren): Ditto.
2307         (WTR::AccessibilityUIElement::getChildrenWithRange): Ditto.
2308         (WTR::AccessibilityUIElement::childrenCount): Ditto.
2309         (WTR::AccessibilityUIElement::elementAtPoint): Ditto.
2310         (WTR::AccessibilityUIElement::indexOfChild): Ditto.
2311         (WTR::AccessibilityUIElement::childAtIndex): Ditto.
2312         (WTR::AccessibilityUIElement::titleUIElement): Ditto.
2313         (WTR::AccessibilityUIElement::parentElement): Ditto.
2314         (WTR::AccessibilityUIElement::attributesOfChildren): Ditto.
2315         (WTR::AccessibilityUIElement::allAttributes): Ditto.
2316         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
2317         (WTR::AccessibilityUIElement::role): Ditto.
2318         (WTR::AccessibilityUIElement::title): Ditto.
2319         (WTR::AccessibilityUIElement::description): Ditto.
2320         (WTR::AccessibilityUIElement::orientation): Ditto.
2321         (WTR::AccessibilityUIElement::stringValue): Ditto.
2322         (WTR::AccessibilityUIElement::language): Ditto.
2323         (WTR::AccessibilityUIElement::x): Ditto.
2324         (WTR::AccessibilityUIElement::y): Ditto.
2325         (WTR::AccessibilityUIElement::width): Ditto.
2326         (WTR::AccessibilityUIElement::height): Ditto.
2327         (WTR::AccessibilityUIElement::intValue): Ditto.
2328         (WTR::AccessibilityUIElement::minValue): Ditto.
2329         (WTR::AccessibilityUIElement::maxValue): Ditto.
2330         (WTR::AccessibilityUIElement::rowCount): Ditto.
2331         (WTR::AccessibilityUIElement::columnCount): Ditto.
2332         (WTR::AccessibilityUIElement::cellForColumnAndRow): Ditto.
2333         (WTR::AccessibilityUIElement::press): Ditto.
2334         (WTR::AccessibilityUIElement::documentEncoding): Ditto.
2335         (WTR::AccessibilityUIElement::documentURI): Ditto.
2336         (WTR::AccessibilityUIElement::hasPopup): Ditto.
2337
2338 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
2339
2340         [ATK] accessibility/aria-sort.html is failing after r156409
2341         https://bugs.webkit.org/show_bug.cgi?id=121947
2342
2343         Reviewed by Chris Fleizach.
2344
2345         Implement AccessibilityUIElement::isSupported for the ATK
2346         platforms, just by checking whether we have an associated object
2347         attribute exposed for the wrapper object matching the required
2348         attribute in the layout test (e.g "AXSortDirection" -> "sort").
2349
2350         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2351         (AccessibilityUIElement::isAttributeSupported): Implemented.
2352         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2353         (WTR::AccessibilityUIElement::isAttributeSupported): Implemented.
2354
2355 2013-09-26  Eric Carlson  <eric.carlson@apple.com>
2356
2357         [MediaStream] make MediaStream testable
2358         https://bugs.webkit.org/show_bug.cgi?id=121967
2359
2360         Reviewed by Dean Jackson.
2361
2362         * DumpRenderTree/mac/UIDelegate.mm:
2363         (-[UIDelegate webView:decidePolicyForUserMediaRequestFromOrigin:listener:]): Add a very permissive
2364             user media request policy delegate.
2365
2366 2013-09-26  Brian J. Burg  <burg@cs.washington.edu>
2367
2368         build-webkit --inspector-frontend should copy WebInspectorUI files
2369         https://bugs.webkit.org/show_bug.cgi?id=117851
2370
2371         Reviewed by Joseph Pecoraro.
2372
2373         Change the --inspector-frontend build option to additionally build/copy 
2374         WebInspectorUI by setting it as the only project that needs to be built.
2375
2376         * Scripts/build-webkit:
2377
2378 2013-09-26  Zan Dobersek  <zdobersek@igalia.com>
2379
2380         XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
2381         https://bugs.webkit.org/show_bug.cgi?id=121951
2382
2383         Reviewed by Carlos Garcia Campos.
2384
2385         Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
2386         software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
2387         500 layout tests that trigger accelerated compositing to be used.
2388
2389         * Scripts/webkitpy/port/xvfbdriver.py:
2390         (XvfbDriver._start):
2391         * Scripts/webkitpy/port/xvfbdriver_unittest.py: Update unit test baselines.
2392         (XvfbDriverTest.test_start_no_pixel_tests):
2393         (XvfbDriverTest.test_start_pixel_tests):
2394         (XvfbDriverTest.test_start_arbitrary_worker_number):
2395         (XvfbDriverTest.test_next_free_display):
2396         (XvfbDriverTest.test_start_next_worker):
2397
2398 2013-09-26  Tim Horton  <timothy_horton@apple.com>
2399
2400         Tiled drawing should not imply threaded scrolling
2401         https://bugs.webkit.org/show_bug.cgi?id=121874
2402         <rdar://problem/15071494>
2403
2404         Reviewed by Sam Weinig.
2405
2406         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2407         (WTR::PlatformWebView::PlatformWebView):
2408         The existing tiled-drawing layout tests require threaded scrolling to be enabled.
2409
2410 2013-09-26  Commit Queue  <commit-queue@webkit.org>
2411
2412         Unreviewed, rolling out r156457.
2413         http://trac.webkit.org/changeset/156457
2414         https://bugs.webkit.org/show_bug.cgi?id=121960
2415
2416         Broke webkitpy tests. (Requested by kling on #webkit).
2417
2418         * Scripts/webkitpy/port/xvfbdriver.py:
2419         (XvfbDriver._start):
2420
2421 2013-09-26  Zan Dobersek  <zdobersek@igalia.com>
2422
2423         XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
2424         https://bugs.webkit.org/show_bug.cgi?id=121951
2425
2426         Reviewed by Carlos Garcia Campos.
2427
2428         Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
2429         software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
2430         500 layout tests that trigger accelerated compositing to be used.
2431
2432         * Scripts/webkitpy/port/xvfbdriver.py:
2433         (XvfbDriver._start):
2434
2435 2013-09-25  Alex Christensen  <achristensen@webkit.org>
2436
2437         Removed check for Apple Application Support directory in WinCairo port.
2438         https://bugs.webkit.org/show_bug.cgi?id=121869
2439
2440         Reviewed by Brent Fulgham.
2441
2442         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2443         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2444         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2445         Use DLLLauncherWinCairo.props for WinCairo ports.
2446         * win/DLLLauncher/DLLLauncherMain.cpp:
2447         (wWinMain):
2448         Don't call modifyPath to check for AAS in the WinCairo port.
2449         * win/DLLLauncher/DLLLauncherWinCairo.props: Added to define WIN_CAIRO.
2450
2451 2013-09-25  Alex Christensen  <achristensen@webkit.org>
2452
2453         Enabled AssembleBuildLogs on WinCairo port.
2454         https://bugs.webkit.org/show_bug.cgi?id=121923
2455
2456         Reviewed by Brent Fulgham.
2457
2458         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
2459         Fixed reference to README, added WinCairo configurations.
2460         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters:
2461         Fixed reference to README.
2462         * win/AssembleBuildLogs/AssembleLogs.cmd:
2463         Added ANGLE projects, skipped QTMovieWin for WinCairo, use PlatformArchitecture for Win64.
2464         * win/AssembleBuildLogs/README: Fixed spelling.
2465
2466 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
2467
2468         [WIN] Fix MSVC C4146 compiler warning
2469         https://bugs.webkit.org/show_bug.cgi?id=121838
2470
2471         Reviewed by Brent Fulgham.
2472
2473         Fix some variables from unsinged to int to fix the compiler warning
2474         "unary minus operator applied to unsigned type, result still unsigned".
2475
2476         * DumpRenderTree/WorkQueueItem.h:
2477         (BackItem::BackItem):
2478         (ForwardItem::ForwardItem):
2479         * DumpRenderTree/win/DumpRenderTree.cpp:
2480         (createWebViewAndOffscreenWindow):
2481
2482 2013-09-25  Zan Dobersek  <zdobersek@igalia.com>
2483
2484         [GTK] Switch the 64-bit Release builder to testing layout tests under WK2
2485         https://bugs.webkit.org/show_bug.cgi?id=121256
2486
2487         Reviewed by Martin Robinson.
2488
2489         Switch the GTK 64-bit Release builder to testing the layout tests under WebKit2.
2490         The GTK 64-bit Release WK2 testing builder is switched to now run layout tests under WebKit1.
2491
2492         * BuildSlaveSupport/build.webkit.org-config/config.json:
2493
2494 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
2495
2496         Add style checker for CMake lists
2497         https://bugs.webkit.org/show_bug.cgi?id=121764
2498
2499         Reviewed by Ryosuke Niwa.
2500
2501         Add an additional check to make sure that list of files are sorted.
2502         Exclude lists of include directories for now, since the order
2503         can be importent for compilation of some files.
2504
2505         * Scripts/webkitpy/style/checkers/cmake.py:
2506         (CMakeChecker.check):
2507         (CMakeChecker._check_indent):
2508         (CMakeChecker):
2509         (CMakeChecker._check_list_order):
2510         (CMakeChecker._list_item_path):
2511         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
2512         (CMakeCheckerTest.test_check):
2513
2514 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
2515
2516         CMakeChecker takes unusually long time to run
2517         https://bugs.webkit.org/show_bug.cgi?id=105662
2518
2519         Reviewed by Ryosuke Niwa.
2520
2521         Move the caching mechanism for regular expression of the C++ checker into
2522         a common file and use it for the CMake and ChangeLog checkers too.
2523
2524         * Scripts/webkitpy/style/checkers/changelog.py:
2525         (ChangeLogChecker.check_entry):
2526         * Scripts/webkitpy/style/checkers/cmake.py:
2527         (CMakeChecker._process_line):
2528         (CMakeChecker._check_no_space_cmds):
2529         (CMakeChecker._check_one_space_cmds):
2530         (CMakeChecker._check_non_lowercase_cmd):
2531         * Scripts/webkitpy/style/checkers/common.py:
2532         (match):
2533         (search):
2534         (searchIgnorecase):
2535         (sub):
2536         (subn):
2537         * Scripts/webkitpy/style/checkers/cpp.py:
2538
2539 2013-09-25  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2540
2541         [Qt] Fix build with Qt 5.2 QtPosition module
2542         https://bugs.webkit.org/show_bug.cgi?id=121089
2543
2544         Reviewed by Simon Hausmann.
2545
2546         QtLocation -> QtPositioning. Make sure we set build type before doing configure checks
2547         that might depend on them.
2548
2549         * qmake/mkspecs/features/default_pre.prf:
2550         * qmake/mkspecs/features/features.prf:
2551
2552 2013-09-25  Mario Sanchez Prada  <mario.prada@samsung.com>
2553
2554         [ATK] Fix style issues in AccessibilityUIElementAtk
2555         https://bugs.webkit.org/show_bug.cgi?id=121898
2556
2557         Reviewed by Chris Fleizach.
2558
2559         Avoid the '.f' suffix for float literals and use G_VALUE_INIT
2560         instead of { 0, { { 0 } } } to initialize a GValue.
2561
2562         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2563         (AccessibilityUIElement::clickPointX): Remove suffix.
2564         (AccessibilityUIElement::clickPointY): Ditto.
2565         (AccessibilityUIElement::intValue): Use G_VALUE_INIT and remove suffix.
2566         (AccessibilityUIElement::minValue): Ditto.
2567         (AccessibilityUIElement::maxValue): Ditto.
2568         (AccessibilityUIElement::numberAttributeValue): Remove suffix.
2569         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2570         (WTR::AccessibilityUIElement::numberAttributeValue): Remove suffix.
2571         (WTR::AccessibilityUIElement::x): Ditto.
2572         (WTR::AccessibilityUIElement::y): Ditto.
2573         (WTR::AccessibilityUIElement::width): Ditto.
2574         (WTR::AccessibilityUIElement::height): Ditto.
2575         (WTR::AccessibilityUIElement::clickPointX): Ditto.
2576         (WTR::AccessibilityUIElement::clickPointY): Ditto.
2577         (WTR::AccessibilityUIElement::intValue): Ditto.
2578         (WTR::AccessibilityUIElement::minValue): Ditto.
2579         (WTR::AccessibilityUIElement::maxValue): Ditto.
2580
2581 2013-09-25  Krzysztof Czech  <k.czech@samsung.com>
2582
2583         [EFL] accessibility/loading-iframe-sends-notification.html is failing
2584         https://bugs.webkit.org/show_bug.cgi?id=112003
2585
2586         Reviewed by Mario Sanchez Prada.
2587
2588         Enabled addNotificationListener and removeNotificationListener for EFL port.
2589
2590         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2591         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2592         (WTR::AccessibilityController::removeNotificationListener):
2593
2594 2013-09-24  Filip Pizlo  <fpizlo@apple.com>
2595
2596         Crashing under JSC::DFG::SpeculativeJIT::spill visiting citicards.com
2597         https://bugs.webkit.org/show_bug.cgi?id=121844
2598
2599         Reviewed by Mark Hahnenberg.
2600
2601         * Scripts/run-javascriptcore-tests: Be more clear about what test suite failed.
2602
2603 2013-09-24  Alexey Proskuryakov  <ap@apple.com>
2604
2605         [Mac][WK2] Multiple font tests fail is there is a global setting for font antialiasing threshold
2606         https://bugs.webkit.org/show_bug.cgi?id=121854
2607
2608         Reviewed by Anders Carlsson.
2609
2610         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2611         (WTR::InjectedBundle::platformInitialize): Post a notification to update cached
2612         settings in underlying frameworks.
2613
2614 2013-09-24  Mark Rowe  <mrowe@apple.com>
2615
2616         <rdar://problem/14971518> WebKit should build against the Xcode default toolchain when targeting OS X 10.8
2617
2618         Reviewed by Dan Bernstein.
2619
2620         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2621         * MiniBrowser/Configurations/Base.xcconfig:
2622         * TestWebKitAPI/Configurations/Base.xcconfig:
2623         * WebKitLauncher/Configurations/Base.xcconfig:
2624         * WebKitTestRunner/Configurations/Base.xcconfig:
2625
2626 2013-09-24  Denis Nomiyama  <d.nomiyama@samsung.com>
2627
2628         [ATK] Missing WTR AccessibilityController::addNotificationListener implementation
2629         https://bugs.webkit.org/show_bug.cgi?id=121674
2630
2631         Reviewed by Mario Sanchez Prada.
2632
2633         Implemented the global notification listener for
2634         AccessibilityController. The signal is generated by
2635         AXObjectCache::postPlatformNotification() and received by
2636         axObjectEventListener(). axObjectEventListener will then invoke
2637         JSObjectCallAsFunction() with the respective callback function.
2638
2639         There is no additional test for this patch since its implementation will
2640         be tested by an accessibility layout test that is currently failing
2641         (accessibility/loading-iframe-sends-notification.html).
2642
2643         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Removed
2644         stub implementations of addNotificationListener and
2645         removeNotificationListener for the GTK port.
2646         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2647         (WTR::AccessibilityController::addNotificationListener): Creates the
2648         notification handler and sets the notification function callback.
2649         (WTR::AccessibilityController::removeNotificationListener): Removes the
2650         global handler.
2651
2652 2013-09-24  Anton Obzhirov  <a.obzhirov@samsung.com>
2653
2654         [GTK] fast/images/exif-orientation-composited.html is failing
2655         https://bugs.webkit.org/show_bug.cgi?id=119731
2656
2657         Reviewed by Carlos Garcia Campos.
2658
2659         Add handling respect image orientation property in DRT.
2660
2661         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2662         (TestRunner::overridePreference):
2663
2664 2013-09-24  Zan Dobersek  <zdobersek@igalia.com>
2665
2666         [GTK] Bump the GTK+ dependency in the Wayland-specific Jhbuild moduleset
2667         https://bugs.webkit.org/show_bug.cgi?id=121787
2668
2669         Reviewed by Gustavo Noronha Silva.
2670
2671         * gtk/jhbuild-wayland.modules: Bump the GTK+ dependency that's intended for use when building
2672         with the Wayland target enabled to version 3.10.0.
2673
2674 2013-09-23  Patrick Gansterer  <paroga@webkit.org>
2675
2676         use NOMINMAX instead of #define min min
2677         https://bugs.webkit.org/show_bug.cgi?id=73563
2678
2679         Reviewed by Brent Fulgham.
2680
2681         Use NOMINMAX instead of #define min/max as a cleaner
2682         way of ensuring that Windows system header files don't
2683         define min/max as macro in the first place.
2684
2685         * DumpRenderTree/DumpRenderTreePrefix.h:
2686         * DumpRenderTree/cg/ImageDiffCG.cpp:
2687         * DumpRenderTree/config.h:
2688         * DumpRenderTree/win/ImageDiffCairo.cpp:
2689         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
2690         * WebKitTestRunner/config.h:
2691
2692 2013-09-23  Benjamin Poulain  <benjamin@webkit.org>
2693
2694         Delete TestWebKitAPI domain or some keys before running TestWebKitAPI
2695         https://bugs.webkit.org/show_bug.cgi?id=121715 & <rdar://problem/14269434>
2696
2697         Reviewed by Alexey Proskuryakov.
2698
2699         Previously, initalizing a WebPreference would change the cache model
2700         to WebCacheModelDocumentBrowser. That behavior was due to a stale
2701         preference file on disk.
2702
2703         This patch fixes the tests by resetting the default, and using the proper
2704         default values after initializing WebPreference.
2705
2706         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
2707         (TestWebKitAPI::TEST): Use the proper initial value, unrelated
2708         to the previous runs.
2709
2710         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
2711         (TestWebKitAPI::TEST): This test needs b/f cache to be enabled, so change
2712         cache model to the one required.
2713
2714         * TestWebKitAPI/ios/mainIOS.mm:
2715         (main): Reset the preferences before testing.
2716         * TestWebKitAPI/mac/mainMac.mm:
2717         (main): Ditto.
2718
2719 2013-09-23  Benjamin Poulain  <benjamin@webkit.org>
2720
2721         Delete TestWebKitAPI domain or some keys before running TestWebKitAPI
2722         https://bugs.webkit.org/show_bug.cgi?id=121715 & <rdar://problem/14269434>
2723
2724         Reviewed by Alexey Proskuryakov.
2725
2726         Previously, initalizing a WebPreference would change the cache model
2727         to WebCacheModelDocumentBrowser. That behavior was due to a stale
2728         preference file on disk.
2729
2730         This patch fixes the tests by resetting the default, and using the proper
2731         default values after initializing WebPreference.
2732
2733         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
2734         (TestWebKitAPI::TEST): Use the proper initial value, unrelated
2735         to the previous runs.
2736
2737         * TestWebKitAPI/ios/mainIOS.mm:
2738         (main): Reset the preferences before testing.
2739         * TestWebKitAPI/mac/mainMac.mm:
2740         (main): Ditto.
2741
2742 2013-09-23  Anders Carlsson  <andersca@apple.com>
2743
2744         ListHashSet should work with move-only types
2745         https://bugs.webkit.org/show_bug.cgi?id=121802
2746
2747         Reviewed by Andreas Kling.
2748
2749         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
2750         (TestWebKitAPI::TEST):
2751         Add a test for move-only types.
2752
2753 2013-09-23  Alex Christensen  <alex.christensen@flexsim.com>
2754
2755         Added --64-bit option for Windows build.
2756         https://bugs.webkit.org/show_bug.cgi?id=121799
2757
2758         Reviewed by Brent Fulgham.
2759
2760         * Scripts/webkitdirs.pm:
2761         (determinePassedConfiguration): Add "|x64" for 64-bit configuration.
2762         (isWin64): Added.
2763         (determineIsWin64): Added.
2764
2765 2013-09-23  Anders Carlsson  <andersca@apple.com>
2766
2767         ListHashSet should use std::reverse_iterator for reverse iterators
2768         https://bugs.webkit.org/show_bug.cgi?id=121795
2769
2770         Reviewed by Antti Koivisto.
2771
2772         Add test for reverse iterators.
2773
2774         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
2775         (TestWebKitAPI::TEST):
2776
2777 2013-09-23  Krzysztof Czech  <k.czech@samsung.com>
2778
2779         [EFL] accessibility/aria-invalid is failing
2780         https://bugs.webkit.org/show_bug.cgi?id=111986
2781
2782         Reviewed by Mario Sanchez Prada.
2783
2784         Adds possibility to retrieve JS context.
2785         This is part of the implementation of AccessibilityUIElement::addNotificationListener
2786         from 119883 and 120421.
2787
2788         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
2789         (axObjectEventListener):
2790         (addAccessibilityNotificationHandler):
2791         (removeAccessibilityNotificationHandler):
2792         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2793         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
2794         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
2795
2796 2013-09-20  Mark Rowe  <mrowe@apple.com>
2797
2798         <https://webkit.org/b/90090> build-webkit should verify that your tools are up-to-date
2799
2800         Enforce a minimum OS version of 10.7.5 and Xcode version of 4.6.
2801
2802         Reviewed by David Kilzer.
2803
2804         * Scripts/webkitdirs.pm:
2805         (checkRequiredSystemConfig):
2806
2807 2013-09-20  Mario Sanchez Prada  <mario.prada@samsung.com>
2808
2809         [ATK] Do not expose aria-help in ATK based platforms
2810         https://bugs.webkit.org/show_bug.cgi?id=121675
2811
2812         Reviewed by Chris Fleizach.
2813
2814         Remove the implementations for AccessibilityUIElement::helpText()
2815         from DRT and WKTR for GTK and EFL, since they are based on the
2816         AccessibilityObject::helpText() method and the 'aria-help'
2817         attributes, which is wrong since they should not depend on that
2818         but in ATK specific API (see also http://webkit.org/b/121684).
2819
2820         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2821         (AccessibilityUIElement::helpText): Added a new and empty
2822         implementation, now that we are no longer using this in ATK.
2823         * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Removed file
2824         as the only function provided here was helpText().
2825         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Ditto.
2826         * DumpRenderTree/efl/CMakeLists.txt: AccessibilityUIElementEfl.cpp
2827         removed from the list of sources to compile.
2828         * GNUmakefile.am: Likewise, but for AccessibilityUIElementGtk.cpp.
2829         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2830         (WTR::AccessibilityUIElement::helpText): Replaced old implementation
2831         based in DumpRenderTreeSupportGtk with an empty one.
2832
2833 2013-09-20  Dan Bernstein  <mitz@apple.com>
2834
2835         Make extract-localizable-strings available to WebCore clients
2836         https://bugs.webkit.org/show_bug.cgi?id=121699
2837
2838         Reviewed by Darin Adler.
2839
2840         * Scripts/extract-localizable-strings: Copied to
2841         Soure/WebCore/extract-localizaebl-strings.pl, and changed this into a shell script that
2842         executes the script from its new location. This is a temporary measure until certain code
2843         that is external to WebKit is adapted to the new location.
2844         * Scripts/update-webkit-localizable-strings: Changed to call extract-localizable-strings.pl
2845         from its new location.
2846
2847 2013-09-20  Patrick Gansterer  <paroga@webkit.org>
2848
2849         Nuke remaining VS2005 tools from the tree.
2850         https://bugs.webkit.org/show_bug.cgi?id=121691
2851
2852         Reviewed by Brent Fulgham.
2853
2854         * CLWrapper/CLWrapper.cpp: Removed.
2855         * CLWrapper/CLWrapper.sln: Removed.
2856         * CLWrapper/CLWrapper.vcproj: Removed.
2857         * MIDLWrapper/MIDLWrapper.cpp: Removed.
2858         * MIDLWrapper/MIDLWrapper.sln: Removed.
2859         * MIDLWrapper/MIDLWrapper.vcproj: Removed.
2860         * Scripts/parallelcl: Removed.
2861         * vcbin/cl.exe: Removed.
2862         * vcbin/midl.exe: Removed.
2863
2864 2013-09-20  Mario Sanchez Prada  <mario.prada@samsung.com>
2865
2866         [GTK] socket_embed_hook hitting NULL-check assertion running TestWebKit2
2867         https://bugs.webkit.org/show_bug.cgi?id=121294
2868
2869         Reviewed by Martin Robinson.
2870
2871         Provide a new patch to deal with the issue in the GTK+ module from
2872         the internal jhbuild environment. This issue has been reported
2873         upstream (see https://bugzilla.gnome.org/show_bug.cgi?id=708024).
2874
2875         * gtk/jhbuild.modules: Apply the new patch to the GTK+ module.
2876         * gtk/patches/gtk-3.6-do-not-shutdown-accessibility.patch: Added.
2877
2878 2013-09-20  Denis Nomiyama  <d.nomiyama@samsung.com>
2879
2880         [ATK][WTR] accessibility/aria-invalid.html times out
2881         https://bugs.webkit.org/show_bug.cgi?id=121668
2882
2883         Reviewed by Mario Sanchez Prada.
2884
2885         Fixed WTR::AccessibilityUIElement::stringAttributeValue() to return
2886         false in case of aria-invalid event with empty value.
2887
2888         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2889         (WTR::AccessibilityUIElement::stringAttributeValue): Returns false in
2890         case of aria-invalid event with empty value.
2891
2892 2013-09-20  Denis Nomiyama  <d.nomiyama@samsung.com>
2893
2894         [ATK] Missing WTR AccessibilityUIElement::addNotificationListener implementation
2895         https://bugs.webkit.org/show_bug.cgi?id=120421
2896
2897         Reviewed by Mario Sanchez Prada.
2898
2899         Implemented the notification listener for AccessibilityUIElement for
2900         WebKitTestRunner. The signal is generated by
2901         AXObjectCache::postPlatformNotification() and received by
2902         axObjectEventListener(). axObjectEventListener() will then invoke
2903         JSObjectCallAsFunction() with the respective callback function. The
2904         notification handlers are stored in HashMap in
2905         AccessibilityNotificationHandlerAtk.cpp.
2906
2907         Moved ATK signal handling (printAccessibilityEvent and
2908         axObjectEventListener) to AccessibilityNotificationHandlerAtk.cpp.
2909
2910         * WebKitTestRunner/CMakeLists.txt: Added InjectedBundle/atk to the
2911         include path.
2912         * WebKitTestRunner/GNUmakefile.am:
2913         Added AccessibilityNotificationHandlerAtk.cpp/h.
2914         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Moved
2915         listener IDs to AccessibilityNotificationHandlerAtk.cpp.
2916         * WebKitTestRunner/InjectedBundle/AccessibilityController.h: Moved
2917         listener IDs to AccessibilityNotificationHandlerAtk.cpp.
2918         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added a
2919         notification handler for GTK+ and EFL.
2920         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2921         Moved printAccessibilityEvent and axObjectEventListener to
2922         AccessibilityNotificationHandlerAtk.cpp.
2923         (WTR::AccessibilityController::logAccessibilityEvents): Moved listener
2924         IDs to AccessibilityNotificationHandlerAtk.cpp.
2925         (WTR::AccessibilityController::resetToConsistentState): Moved listener
2926         IDs to AccessibilityNotificationHandlerAtk.cpp.
2927         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Added.
2928         (WTR::printAccessibilityEvent): Prints accessibility events. This
2929         function was moved from AccessibilityControllerAtk.cpp.
2930         (WTR::axObjectEventListener): Callback for signals. This function was
2931         moved from AccessibilityControllerAtk.cpp.
2932         (WTR::AccessibilityNotificationHandler::AccessibilityNotificationHandler):
2933         Initialize element and function callback.
2934         (WTR::AccessibilityNotificationHandler::~AccessibilityNotificationHandler):
2935         Removes handler from HashMap and disconnects callbacks if necessary.
2936         (WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Sets
2937         logging mode and connects callbacks.
2938         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
2939         Sets the notification callback and connects callback to signals.
2940         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
2941         Removes the notification callback from HashMap.
2942         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
2943         Connects axObjectEventListener to ATK signals.
2944         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
2945         Disconnects callback.
2946         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h: Added.
2947         (WTR::AccessibilityNotificationHandler::create): Creates a new instance
2948         of AccessibilityNotificationHandler.
2949         (WTR::AccessibilityNotificationHandler::setPlatformElement): Sets the
2950         element.
2951         (WTR::AccessibilityNotificationHandler::platformElement): Gets the
2952         element.
2953         (WTR::AccessibilityNotificationHandler::notificationFunctionCallback):
2954         Gets the notification callback.
2955         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2956         (WTR::AccessibilityUIElement::addNotificationListener): Creates
2957         notification handler, set the platform element and the notification
2958         callback.
2959         (WTR::AccessibilityUIElement::removeNotificationListener): Deletes the
2960         notification handler.
2961         * WebKitTestRunner/PlatformEfl.cmake:
2962         Added AccessibilityNotificationHandlerAtk.cpp.
2963
2964 2013-09-20  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2965
2966         Update features.pri
2967         https://bugs.webkit.org/show_bug.cgi?id=121670
2968
2969         Reviewed by Jocelyn Turcotte.
2970
2971         Remove feature flags that no longer exists and new ones added to FeatureList.pm
2972
2973         * qmake/mkspecs/features/features.pri:
2974
2975 2013-09-20  Krzysztof Czech  <k.czech@samsung.com>
2976
2977         [GTK][WK2] accessibility/selection-states.html is failing
2978         https://bugs.webkit.org/show_bug.cgi?id=116972
2979
2980         Reviewed by Mario Sanchez Prada.
2981
2982         isSelectable() was not exposed in Accessibility.
2983
2984         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2985
2986 2013-09-19  Dan Bernstein  <mitz@apple.com>
2987
2988         Attempted build fix after r156114.
2989
2990         * Scripts/copy-webkitlibraries-to-product-directory: Removed references to WebCoreSQLite3.
2991
2992 2013-09-19  Alexey Proskuryakov  <ap@apple.com>
2993
2994         REGRESSION (r129451): run-safari --no-saved-state is broken
2995         https://bugs.webkit.org/show_bug.cgi?id=121566
2996
2997         Undo a last minute change that doesn't actually work.
2998
2999         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp): "-1" cannot be passed
3000         via command line, <rdar://problem/15032886>.
3001
3002 2013-09-19  Dan Bernstein  <mitz@apple.com>
3003
3004         Add a style guideline regarding spacing in range-based for loops
3005         https://bugs.webkit.org/show_bug.cgi?id=121620
3006
3007         Reviewed by Anders Carlsson.
3008
3009         * Scripts/webkitpy/style/checkers/cpp.py:
3010         (check_spacing): Added checking that there are spaces around the colon in a range-based for
3011         loop.
3012         (CppChecker): Added whitespace/colon to the categories set.
3013         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3014         (WebKitStyleTest.test_spacing): Added two tests for the new check.
3015
3016 2013-09-18  Sam Weinig  <sam@webkit.org>
3017
3018         Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in Tools
3019         https://bugs.webkit.org/show_bug.cgi?id=121588
3020
3021         Reviewed by Anders Carlsson.
3022
3023         * DumpRenderTree/TestRunner.cpp:
3024         * ImageDiff/efl/ImageDiff.cpp:
3025         * TestWebKitAPI/JavaScriptTest.cpp:
3026         * TestWebKitAPI/PlatformUtilities.cpp:
3027         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3028         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3029         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3030         * WebKitTestRunner/StringFunctions.h:
3031         * WebKitTestRunner/TestInvocation.cpp:
3032         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
3033         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3034
3035 2013-09-18  Bem Jones-Bey  <bjonesbe@adobe.com>
3036
3037         W3C Test Import script reformats test HTML
3038         https://bugs.webkit.org/show_bug.cgi?id=119159
3039
3040         Reviewed by Dirk Pranke.
3041
3042         Completely rewrite the test conversion process to minimize
3043         reformatting when adding prefixes, etc. This isn't 100% perfect, there
3044         are still places where it will end up changing the formatting, but it
3045         is much better than before. Most notably, the public interface to the
3046         test converter has changed: now one calls a method instead of creating
3047         an instance of the test converter class. This is because the test
3048         converter class now has state, so one really needs a new instance for
3049         each test.
3050
3051         Note that this also lays some simple groundwork for being able to use
3052         a MockHost in the tests.
3053
3054         * Scripts/webkitpy/w3c/test_converter.py:
3055         (convert_for_webkit):
3056         (_W3CTestConverter):
3057         (_W3CTestConverter.__init__):
3058         (_W3CTestConverter.output):
3059         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
3060         (_W3CTestConverter.convert_style_data):
3061         (_W3CTestConverter.convert_attributes_if_needed):
3062         (_W3CTestConverter.handle_starttag):
3063         (_W3CTestConverter.handle_endtag):
3064         (_W3CTestConverter.handle_startendtag):
3065         (_W3CTestConverter.handle_data):
3066         (_W3CTestConverter.handle_entityref):
3067         (_W3CTestConverter.handle_charref):
3068         (_W3CTestConverter.handle_comment):
3069         (_W3CTestConverter.handle_decl):
3070         (_W3CTestConverter.handle_pi):
3071         * Scripts/webkitpy/w3c/test_converter_unittest.py:
3072         (W3CTestConverterTest):
3073         (W3CTestConverterTest.fake_dir_path):
3074         (W3CTestConverterTest.test_read_prefixed_property_list):
3075         (verify_no_conversion_happened):
3076         * Scripts/webkitpy/w3c/test_importer.py:
3077         (TestImporter.import_tests):
3078
3079 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
3080
3081         Get rid of the jsc-test-list by moving all not-jsc-capable tests into js/dom
3082         https://bugs.webkit.org/show_bug.cgi?id=121578
3083
3084         Rubber stamped by Geoffrey Garen.
3085
3086         * Scripts/run-layout-jsc:
3087
3088 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
3089
3090         Unreviewed, fix for Ruby 1.8.
3091
3092         * Scripts/run-jsc-stress-tests:
3093
3094 2013-09-17  Filip Pizlo  <fpizlo@apple.com>
3095
3096         run-jsc-stress-tests should make it easier to look at error spew from tests
3097         https://bugs.webkit.org/show_bug.cgi?id=121531
3098
3099         Reviewed by Mark Hahnenberg.
3100         
3101         This makes two changes:
3102         
3103         - The out/err spew from each test is now saved to a .out file in jsc-stress-results.
3104         
3105         - The same spew also goes to the console but is prefixed by the test's name.
3106         
3107         This required some tee and awk hacks, and then some sh hacks to work around the fact
3108         that if you do "(foo | bar) || baz", and foo fails, then baz won't run - the ||
3109         operator will only see a failure of bar failed. So to pass output to tee and awk, I
3110         needed to do weird things.
3111
3112         * Scripts/run-jsc-stress-tests:
3113
3114 2013-09-18  Alexey Proskuryakov  <ap@apple.com>
3115
3116         REGRESSION (r129451): run-safari --no-saved-state is broken
3117         https://bugs.webkit.org/show_bug.cgi?id=121566
3118
3119         Reviewed by Mark Rowe.
3120
3121         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp):
3122         Check arguments, not the newly created empty array. Pass a value that silences warnings.
3123         While at it, removed a check for Snow Leopard.
3124
3125 2013-09-18  Alex Christensen  <achristensen@webkit.org>
3126
3127         Improved WinLauncher's URL handling.
3128         https://bugs.webkit.org/show_bug.cgi?id=121535
3129
3130         Reviewed by Brent Fulgham.
3131
3132         * WinLauncher/WinLauncher.cpp:
3133         (EditProc):
3134         Use INTERNET_MAX_URL_LENGTH instead of our MAX_URL_LENGTH.
3135         (loadURL):
3136         Prepend "http://" to URLs with no scheme.
3137
3138 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
3139
3140         DFG should support Int52 for local variables
3141         https://bugs.webkit.org/show_bug.cgi?id=121064
3142
3143         Reviewed by Oliver Hunt.
3144
3145         * Scripts/run-jsc-stress-tests:
3146
3147 2013-09-18  peavo@outlook.com  <peavo@outlook.com>
3148
3149         [Win] TestWebKitAPI does not compile.
3150         https://bugs.webkit.org/show_bug.cgi?id=121485
3151
3152         Reviewed by Brent Fulgham.
3153
3154         It is no longer possible to inherit from WebCore::BitmapImage, which the test relies on.
3155         Instead, load a bitmap, then destroy the decoded data, which will cause WebCore::frameAtIndex()
3156         to return null, which is the case we want to test.
3157
3158         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
3159         (TestWebKitAPI::TEST):
3160
3161 2013-09-18  Mario Sanchez Prada  <mario.prada@samsung.com>
3162
3163         [ATK] Expose aria-haspopup and aria-sort without the 'aria-' prefix
3164         https://bugs.webkit.org/show_bug.cgi?id=121495
3165
3166         Reviewed by Chris Fleizach.
3167
3168         Adapted DRT and WKTR to deal with the new names for the ATK object
3169         attributes being exposed for 'aria-haspopup' and 'aria-sort'.
3170
3171         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3172         (coreAttributeToAtkAttribute): Updated translation between ATK and DRT.
3173         (AccessibilityUIElement::stringAttributeValue): Ditto.
3174         (AccessibilityUIElement::hasPopup): Ditto.
3175         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3176         (WTR::coreAttributeToAtkAttribute): Updated translation between ATK and WKTR.
3177         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
3178         (WTR::AccessibilityUIElement::hasPopup): Ditto.
3179
3180 2013-09-18  Commit Queue  <commit-queue@webkit.org>
3181
3182         Unreviewed, rolling out r156019 and r156020.
3183         http://trac.webkit.org/changeset/156019
3184         http://trac.webkit.org/changeset/156020
3185         https://bugs.webkit.org/show_bug.cgi?id=121540
3186
3187         Broke tests (Requested by ap on #webkit).
3188
3189         * Scripts/run-jsc-stress-tests:
3190
3191 2013-09-17  Gwang Yoon Hwang  <ryumiel@company100.net>
3192
3193         Unreviewed. Add myself as a committer.
3194
3195         * Scripts/webkitpy/common/config/contributors.json:
3196
3197 2013-09-17  Jae Hyun Park  <jae.park@company100.net>
3198
3199         Unreviewed. Add myself as a committer.
3200
3201         * Scripts/webkitpy/common/config/contributors.json:
3202
3203 2013-09-17  Filip Pizlo  <fpizlo@apple.com>
3204
3205         DFG should support Int52 for local variables
3206         https://bugs.webkit.org/show_bug.cgi?id=121064
3207
3208         Reviewed by Oliver Hunt.
3209
3210         * Scripts/run-jsc-stress-tests:
3211
3212 2013-09-17  Alex Christensen  <alex.christensen@flexsim.com>
3213
3214         Added back and forward buttons to WinLauncher.
3215         https://bugs.webkit.org/show_bug.cgi?id=121212
3216
3217         Reviewed by Brent Fulgham.
3218
3219         * WinLauncher/WinLauncher.cpp:
3220         (resizeSubViews):
3221         Move new back and forward buttons to correct positions before URL bar.
3222         (dllLauncherEntryPoint): 
3223         Store the default button window procedure and replace with my button procedures.
3224         (EditProc): Updated style and renamed from MyEditProc.
3225         (BackButtonProc): Added.
3226         (ForwardButtonProc): Added.
3227
3228 2013-09-17  Michael Saboff  <msaboff@apple.com>
3229
3230         Unreviewed typo fix after r155999
3231
3232         Changed en_US.UTB-8 to en_US.UTF-8
3233
3234         * Scripts/run-javascriptcore-tests:
3235
3236 2013-09-17  Michael Saboff  <msaboff@apple.com>
3237
3238         run-jsc-stress-tests fails with ruby version 2
3239         https://bugs.webkit.org/show_bug.cgi?id=121521
3240
3241         Reviewed by Jessie Berlin.
3242
3243         Explicitly set LANG to en_US.UTB-8 before starting run-jsc-stress-tests.
3244
3245         * Scripts/run-javascriptcore-tests:
3246
3247 2013-09-17  Brent Fulgham  <bfulgham@apple.com>
3248
3249         [Windows] Unreviewed build fix after r155963.
3250
3251         * DumpRenderTree/win/TestRunnerWin.cpp:
3252         (TestRunner::evaluateScriptInIsolatedWorld): Pass nullptr rather than 0.
3253
3254 2013-09-17  Anders Carlsson  <andersca@apple.com>
3255
3256         Fix a typo.
3257
3258         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3259         (TestWebKitAPI::TEST):
3260
3261 2013-09-16  Anders Carlsson  <andersca@apple.com>
3262
3263         HashMap should work with move-only keys
3264         https://bugs.webkit.org/show_bug.cgi?id=121310
3265
3266         Reviewed by Darin Adler.
3267
3268         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3269         (TestWebKitAPI::TEST):
3270         Add test.
3271
3272 2013-09-17  YuTeh Shen  <shenyute@hotmail.com>
3273
3274         BrowserMarshal.h build fail
3275         https://bugs.webkit.org/show_bug.cgi?id=102938
3276
3277         Reviewed by Carlos Garcia Campos.
3278
3279         Fix variable name.
3280
3281         * MiniBrowser/gtk/GNUmakefile.am:
3282
3283 2013-09-16  Brent Fulgham  <bfulgham@apple.com>
3284
3285         [Windows] Clean up WinLauncher by using smart pointers
3286         https://bugs.webkit.org/show_bug.cgi?id=121467
3287
3288         Reviewed by Anders Carlsson.
3289
3290         * WinLauncher/PrintWebUIDelegate.cpp:
3291         (PrintWebUIDelegate::webViewPrintingMarginRect): Switch to smart pointers.
3292         * WinLauncher/WinLauncher.cpp:
3293         (WinLauncherWebHost::updateAddressBar): Use _bstr_t and smart pointers.
3294         (WinLauncherWebHost::didFailProvisionalLoadWithError): Ditto.
3295         (showLastVisitedSites): Smart pointer updates.
3296         (WinLauncherWebHost::didFinishLoadForFrame): Ditto.
3297         (setToDefaultPreferences): Ditto.
3298         (dllLauncherEntryPoint): Ditto.
3299         (PrintView): Ditto.
3300         (LaunchInspector): Ditto.
3301         (NavigateToHistory): Ditto.
3302         (MyEditProc): Ditto.
3303         (loadURL): Ditto.
3304
3305 2013-09-16  Brent Fulgham  <bfulgham@apple.com>
3306
3307         [Windows] Add rudimentary history to WinLauncher.
3308         https://bugs.webkit.org/show_bug.cgi?id=121463
3309
3310         Reviewed by Anders Carlsson.
3311
3312         * WinLauncher/WinLauncher.cpp:
3313         (updateMenuItemForHistoryItem): Added
3314         (showLastVisitedSites): Added
3315         (WinLauncherWebHost::didFinishLoadForFrame): Add history item once
3316         a new page has been visited.
3317         (dllLauncherEntryPoint): Deallocate history on exit.
3318         (NavigateToHistory): Added
3319         (WndProc): Add handler for history entries
3320         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu items to hold
3321         up to 10 history slots.
3322         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link against
3323         Windows utility library to allow use of _bstr_t type.
3324         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Add menu items
3325         to hold up to 10 history slots.
3326         * WinLauncher/stdafx.h: Add <comutil.h> to precompiled headers.
3327
3328 2013-09-16  Gustavo Noronha Silva  <gns@gnome.org>
3329
3330         [GTK] Make symbol export filter more strict, and disable for dev/test builds
3331         https://bugs.webkit.org/show_bug.cgi?id=120586
3332
3333         Reviewed by Martin Robinson.
3334
3335         * GNUmakefile.am: moved GtkLauncher and documentation builds to their own
3336         makefiles, so they can be included unconditionally.
3337         * GtkLauncher/GNUmakefile.am: added.
3338         * Scripts/webkitdirs.pm:
3339         (runAutogenForAutotoolsProjectIfNecessary): always pass --enable-developer-mode
3340         to configure, since we consider builds done through build-webkit to be development
3341         and test builds.
3342         * gtk/GNUmakefile.am: added.
3343         * gtk/common.py: do not use the Scripts directory as a reference to the top path;
3344         it's not necessary and it will not work now that the Scripts directory is not
3345         shipped in the tarball.
3346
3347 2013-09-16  Anders Carlsson  <andersca@apple.com>
3348
3349         WTF::Deque should work with move only types
3350         https://bugs.webkit.org/show_bug.cgi?id=121446
3351
3352         Reviewed by Andreas Kling.
3353
3354         * TestWebKitAPI/Tests/WTF/Deque.cpp:
3355         (TestWebKitAPI::TEST):
3356         Add a test.
3357
3358 2013-09-16  Wojciech Bielawski  <w.bielawski@samsung.com>
3359
3360         [WKTR] WebKitTestRunner's eventSender.contextClick() returns objects without implemented click() method.
3361         https://bugs.webkit.org/show_bug.cgi?id=98410
3362
3363         Reviewed by Darin Adler.
3364
3365         Add implementation of click() method of objects returned by eventSender.contextClick().
3366
3367         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3368         (MenuItemPrivateData):
3369         (WTR::menuItemClickCallback):
3370         (WTR::getMenuItemTitleCallback):
3371         (WTR::staticMenuItemFinalize):
3372         (WTR::getMenuItemClass):
3373         (WTR::EventSendingController::contextClick):
3374
3375 2013-09-15  Zan Dobersek  <zdobersek@igalia.com>
3376
3377         Make the GDB webkit.py script compatible with Python v3
3378         https://bugs.webkit.org/show_bug.cgi?id=121395
3379
3380         Reviewed by Ryosuke Niwa.
3381
3382         GDB fails to load the printing helpers from the webkit.py script if Python v3 is used. To avoid that,
3383         uses of xrange() in the script are replaced with range(), and the print statements are changed into
3384         the print() function invocations.
3385
3386         * gdb/webkit.py:
3387         (guess_string_length):
3388         (ustring_to_string):
3389         (lstring_to_string):
3390         (WTFCStringPrinter.to_string):
3391         (PrintPathToRootCommand.invoke):
3392
3393 2013-09-15  Zan Dobersek  <zdobersek@igalia.com>
3394
3395         [webkitpy] perf profiler attaches to WKTR after the WebProcess was launched
3396         https://bugs.webkit.org/show_bug.cgi?id=119631
3397
3398         Reviewed by Ryosuke Niwa.
3399
3400         The perf profiler is attached to the test runner after the test runner has been launched,
3401         but in the case of WebKitTestRunner, this is done after the WebProcess was spawned by the
3402         UIProcess, meaning that WebProcess operations will not be profiled.
3403
3404         To avoid that, the perf profiler is changed to provide a wrapper command for the test runner.
3405         This is done in the scope of already present support for wrapper scripts (such as valgrind)
3406         that are settable through the --wrapper option. This causes the perf profiler to correctly
3407         continue profiling the WebProcess after it was spawned.
3408
3409         When the profiler is launched, a wait process is launched with the profiler's pid as the
3410         argument. This ensures we can check that the profiler exited normally. If it did not, its
3411         output can be corrupted and can cause problems when that output is examined. The after-exit
3412         report is avoided in that case.
3413
3414         * Scripts/webkitpy/common/system/profiler.py:
3415         (Profiler.wrapper_arguments): The method returns an empty list by default.
3416         (Perf.__init__): Remove unnecessary member variables.
3417         (Perf.attach_to_pid): Launch the wait process with the profiler's pid as the argument.
3418         (Perf.wrapper_arguments): Used instead of attaching the profiler to the profiled process' pid,
3419         the method returns a list of arguments that should be used as a wrapper for the test runner.
3420         The arguments specify the 'perf record' command, with the output file and the instruction to
3421         construct the call graph given as well.
3422         (Perf._first_ten_lines_of_profile): Prettify the output by avoiding the unnecessary trailing
3423         whitespace in the profile lines.
3424         (Perf.profile_after_exit): Kill the profiler process through its pid if the wait process is still
3425         running. If it is running even after that, or if the profiler process produced a non-zero exit
3426         code, the method reports the profiling failure and returns. Otherwise it continues on reporting
3427         the top 10 lines of the profile and how to examine the profile further.
3428         * Scripts/webkitpy/port/driver.py:
3429         (Driver._command_wrapper): The method is now a member of the Driver class, returning the wrapper
3430         as specified by the --wrapper option if given, or the profiler wrapper if the profiler is present,
3431         or an empty list otherwise.
3432         (Driver.cmd_line):
3433         * Scripts/webkitpy/port/driver_unittest.py:
3434         (DriverTest.make_port): Adjusted so mock host or options objects can be specified
3435         for the testing-specific Port object.
3436         (DriverTest._assert_wrapper): Pass a MockOptions object with the wrapper value to the make_port method,
3437         as the Driver._command_wrapper now operates on the option's value directly rather than accepting it through
3438         a parameter.
3439         (DriverTest.test_profiler_as_wrapper): Provide a test case to check the correct profiler wrapper is used
3440         when profiling on the Linux platform with the perf profiler.
3441
3442 2013-09-14  Dan Bernstein  <mitz@apple.com>
3443
3444         [mac] Check For Framework Include Consistency build phase checks the wrong framework
3445         https://bugs.webkit.org/show_bug.cgi?id=121215
3446
3447         Reviewed by Mark Rowe.
3448
3449         * Scripts/check-for-webkit-framework-include-consistency: Replaced hard-coded paths to
3450         WebKit.framework’s Headers and PrivateHeaders directories with the current target’s
3451         public and private headers folder paths. Also tweaked the error messages’ format to make
3452         Xcode recognize them as errors.
3453
3454 2013-09-14  Alberto Garcia  <berto@igalia.com>
3455
3456         [GTK] Fails to compile if the build directory is in a different partition
3457         https://bugs.webkit.org/show_bug.cgi?id=121296
3458
3459         Reviewed by Martin Robinson.
3460
3461         Instead of using os.symlink() to install the gtk-doc templates,
3462         use os.link() first and fall back to os.symlink() if it fails.
3463
3464         * gtk/gtkdoc.py:
3465         (GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):
3466
3467 2013-09-14  Alberto Garcia  <berto@igalia.com>
3468
3469         [GTK] WebKitGTK+ is linking against libxslt in too many places
3470         https://bugs.webkit.org/show_bug.cgi?id=121356
3471
3472         Reviewed by Martin Robinson.
3473
3474         TestWebCore, WebKitTestRunner and MiniBrowser don't use libxslt,
3475         so we don't need to link against it.
3476
3477         * MiniBrowser/gtk/GNUmakefile.am:
3478         * TestWebKitAPI/GNUmakefile.am:
3479         * WebKitTestRunner/GNUmakefile.am:
3480
3481 2013-09-14  Ross Burton  <ross.burton@intel.com>
3482
3483         Uses gtk-doc tools even when --disable-gtk-doc passed
3484         https://bugs.webkit.org/show_bug.cgi?id=91239
3485
3486         Reviewed by Martin Robinson.
3487
3488         Don't run generate-gtkdoc on install if gtk-doc is disabled.
3489
3490         * GNUmakefile.am:
3491
3492 2013-09-14  Alberto Garcia  <berto@igalia.com>
3493
3494         [GTK] Fails to compile if the build directory is in a different partition
3495         https://bugs.webkit.org/show_bug.cgi?id=121296
3496
3497         Reviewed by Carlos Garcia Campos.
3498
3499         Use symlinks instead of hard links to support building on a
3500         different file system.
3501
3502         * gtk/gtkdoc.py:
3503         (GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):
3504
3505 2013-09-13  Darin Adler  <darin@apple.com>
3506
3507         Use a better name than m_invertibleCTM
3508         https://bugs.webkit.org/show_bug.cgi?id=121341
3509
3510         Reviewed by Andreas Kling.
3511
3512         * Scripts/do-webcore-rename: Updated to do this replace as we do.
3513
3514 2013-09-13  Anders Carlsson  <andersca@apple.com>
3515
3516         Pick the correct overload when a const reference is passed to appendSlowCase.
3517         https://bugs.webkit.org/show_bug.cgi?id=121326
3518
3519         Reviewed by Darin Adler.
3520
3521         * TestWebKitAPI/Tests/WTF/Vector.cpp:
3522         (TestWebKitAPI::TEST):
3523
3524 2013-09-13  Darin Adler  <darin@apple.com>
3525
3526         Rename confusingly named "runtimeObject" functions
3527         https://bugs.webkit.org/show_bug.cgi?id=121339
3528
3529         Reviewed by Sam Weinig.
3530
3531         * Scripts/do-webcore-rename: Updated to do this replace as usual.
3532
3533 2013-09-13  Filip Pizlo  <fpizlo@apple.com>
3534
3535         DFG AI assumes that ToThis can never return non-object if it is passed an object, and operationToThis will get the wrong value of isStrictMode() if there's inlining
3536         https://bugs.webkit.org/show_bug.cgi?id=121330
3537
3538         Reviewed by Mark Hahnenberg and Oliver Hunt.
3539
3540         We should run tests even if they don't have expected files yet.
3541         
3542         * Scripts/run-layout-jsc:
3543
3544 2013-09-13  Anders Carlsson  <andersca@apple.com>
3545
3546         Use nullptr instead of 0 in calls to HashMap::add
3547         https://bugs.webkit.org/show_bug.cgi?id=121322
3548
3549         Reviewed by Sam Weinig.
3550
3551         * DumpRenderTree/mac/TestRunnerMac.mm:
3552         (TestRunner::evaluateScriptInIsolatedWorld):
3553         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3554         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
3555
3556 2013-09-13  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3557
3558         [GTK] Move to the new web inspector
3559         https://bugs.webkit.org/show_bug.cgi?id=120647
3560
3561         Reviewed by Carlos Garcia Campos.
3562
3563         * GtkLauncher/main.c:
3564         (main): no longer set WEBKIT_INSPECTOR_PATH.
3565         * MiniBrowser/gtk/main.c:
3566         (main): ditto.
3567         * Scripts/old-run-webkit-tests:
3568         (openDumpTool): ditto.
3569         * Scripts/run-gtk-tests: ditto.
3570         * Scripts/webkitpy/port/gtk.py:
3571         (GtkPort.setup_environ_for_server): ditto.
3572
3573 2013-09-13  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3574
3575         [Qt] REGRESSION(r154444): xss-DENIED test results changed
3576         https://bugs.webkit.org/show_bug.cgi?id=120595
3577
3578         Reviewed by Jocelyn Turcotte.
3579
3580         Avoid overwriting Qt meta properties, which we identify by them being undeletable.
3581
3582         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3583         (DumpRenderTree::initJSObjects):
3584
3585 2013-09-13  Darin Adler  <darin@apple.com>
3586
3587         Give actions in Range class NON_SHOUTING_NAMES
3588         https://bugs.webkit.org/show_bug.cgi?id=121280
3589
3590         Reviewed by Andreas Kling.
3591
3592         * Scripts/do-webcore-rename: Updated to do this replace, keeping with
3593         the tradition of checking in the last one we did, along with other
3594         rename ideas for the future.
3595
3596 2013-09-12  Lucas Forschler  <lforschler@apple.com>
3597
3598         Create short build logs for errors and warnings.
3599         https://bugs.webkit.org/show_bug.cgi?id=120614
3600
3601         Reviewed by Ryosuke Niwa.
3602
3603         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3604             -include StringIO 
3605         (CompileWebKit.createSummary):
3606             -add a createSummary function which will parse out errors and warnings into a concise log file for quick viewing
3607
3608 2013-09-12  Roger Fong  <roger_fong@apple.com>
3609
3610         Update cygwin downloader to search for packages in the right location.
3611
3612         * CygwinDownloader/cygwin-downloader.py:
3613         * CygwinDownloader/cygwin-downloader.zip:
3614
3615 2013-09-12  Anders Carlsson  <andersca@apple.com>
3616
3617         Add rudimentary support for move-only types as values in HashMap
3618         https://bugs.webkit.org/show_bug.cgi?id=121226
3619
3620         Reviewed by Andreas Kling.
3621
3622         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3623         (TestWebKitAPI::TEST):
3624         Add a HashMap<unsigned, MoveOnly> test.
3625
3626 2013-09-12  Gabor Abraham  <abrhm@inf.u-szeged.hu>
3627
3628         Auto GDB backtrace generation for EFL/GTK/Qt bots.
3629         https://bugs.webkit.org/show_bug.cgi?id=119338
3630
3631         Reviewed by Csaba Osztrogonác.
3632
3633         * Scripts/webkitpy/port/efl.py:
3634         (EflPort.check_sys_deps):
3635         (EflPort):
3636         (EflPort._get_crash_log):
3637         * Scripts/webkitpy/port/efl_unittest.py:
3638         (EflPortTest.test_show_results_html_file):
3639         (EflPortTest):
3640         (EflPortTest.test_get_crash_log):
3641         * Scripts/webkitpy/port/gtk.py:
3642         (GtkPort._get_crash_log):
3643         * Scripts/webkitpy/port/gtk_unittest.py:
3644         (GtkPortTest.test_get_crash_log):
3645         * Scripts/webkitpy/port/linux_get_crash_log.py: Added.
3646         (GDBCrashLogGenerator):
3647         (GDBCrashLogGenerator.__init__):
3648         (GDBCrashLogGenerator._get_gdb_output):
3649         (GDBCrashLogGenerator.generate_crash_log):
3650         (GDBCrashLogGenerator.generate_crash_log.match_filename):
3651         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py: Added.
3652         (GDBCrashLogGeneratorTest):
3653         (GDBCrashLogGeneratorTest.test_generate_crash_log):
3654         (_mock_gdb_output):
3655         * Scripts/webkitpy/port/qt.py:
3656         (QtPort.default_child_processes):
3657         (QtPort):
3658         (QtPort._get_crash_log):
3659         * Scripts/webkitpy/port/qt_unittest.py:
3660         (QtPortTest.test_check_sys_deps):
3661         (QtPortTest):
3662         (QtPortTest.test_get_crash_log):
3663
3664 2013-09-12  Peter Gal  <galpeter@inf.u-szeged.hu>
3665
3666         Unreviewed. Moving myself to the commiters list.
3667
3668         * Scripts/webkitpy/common/config/contributors.json:
3669
3670 2013-09-12  ChangSeok Oh  <changseok.oh@collabora.com>
3671
3672         [GTK] Add jhbuild-wayland.modules
3673         https://bugs.webkit.org/show_bug.cgi?id=120455
3674
3675         Reviewed by Gustavo Noronha Silva.
3676
3677         Current versions of gtk+, gdk-pixbuf and glib don't fit the requirement for wayland support.
3678         With this patch, you can build extra gtk+, gdk-pixbuf and glib through jhbuild with exporting
3679         WEBKIT_EXTRA_MODULESETS.
3680
3681         * gtk/jhbuild-wayland.modules: Added.
3682
3683 2013-09-12  Mario Sanchez Prada  <mario.prada@samsung.com>
3684
3685         [GTK][WK2] a11y tests unconditionally launching a11y daemons
3686         https://bugs.webkit.org/show_bug.cgi?id=120299
3687
3688         Reviewed by Carlos Garcia Campos.
3689
3690         Use the right variable name to store a reference to the at-spi2
3691         bus launcher process, so we can be sure we are terminating it when
3692         calling _tear_down_testing_environment().
3693
3694         * Scripts/run-gtk-tests:
3695         (TestRunner._start_accessibility_daemons): Use _spi_bus_launcher
3696         instead of _ally_bus_launcher.
3697
3698 2013-09-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3699
3700         [GTK] run-gtk-tests option --skipped=ignore doesn't work when the entire suite is skipped
3701         https://bugs.webkit.org/show_bug.cgi?id=121218
3702
3703         Reviewed by Philippe Normand.
3704
3705         Skipping the entire suite was added to skip tests when they can't
3706         be run because of the environment, for example to skip the a11y
3707         tests when the at-spi daemons fail to start. This is no longer
3708         true for all the cases, so we can disable the tests that are
3709         impossible to run instead of skipping them.
3710
3711         * Scripts/run-gtk-tests:
3712         (TestRunner.__init__): Initialize the skipped tests list.
3713         (TestRunner._setup_testing_environment): Add
3714         TestWebKitAccessibility path to the list of disabled tests when
3715         at-spi daemon fail to start.
3716         (TestRunner._should_run_test_program): Check first if the test
3717         program is disabled and then whether it's skipped honoring the
3718         skipped command line option.
3719
3720 2013-09-12  Samuel White  <samuel_white@apple.com>
3721
3722         <meter> element text value exposed as AXTitle; should be exposing AXValueDescription
3723         https://bugs.webkit.org/show_bug.cgi?id=117651
3724
3725         Reviewed by Mario Sanchez Prada.
3726
3727         Prepended 'AXValueDescription: ' to valueDescription output and updated impacted tests.
3728
3729         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3730         (AccessibilityUIElement::valueDescription):
3731         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3732         (WTR::AccessibilityUIElement::valueDescription):
3733
3734 2013-09-12  Denis Nomiyama  <d.nomiyama@samsung.com>
3735
3736         REGRESSION(r154781): accessibility/notification-listeners.html is failing
3737         https://bugs.webkit.org/show_bug.cgi?id=120669
3738
3739         Reviewed by Chris Fleizach.
3740
3741         Fixed 4 problems that were causing notification-listeners.html to fail.
3742
3743         Notifications for AXFocusedUIElementChanged and AXValueChanged had to be
3744         implemented in axObjectEventListener().
3745
3746         A notification for AXFocusedUIElementChanged was incorrectly sent when
3747         the element lost focus.
3748
3749         Global notification was not dispatched if an element notification was
3750         present in the HashMap.
3751
3752         connectAccessibilityCallbacks() was connecting signals to callbacks
3753         multiple times because it was not checking if
3754         disconnectAccessibilityCallbacks() had an early return if there were
3755         active handlers.
3756
3757         * DumpRenderTree/atk/AccessibilityCallbacks.h: Modified
3758         disconnectAccessibilityCallbacks() to inform if the callbacks were
3759         successfully disconnected.
3760         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
3761         (axObjectEventListener): Implemented notifications for
3762         AXFocusedUIElementChanged and AXValueChanged. Fixed the global
3763         notification, which was not dispatched if an element notification
3764         existed. Fixed the notification for AXFocusedUIElementChanged that was
3765         incorrectly sent when the element lost focus. In addition, fixed a typo
3766         where TRUE should be true.
3767         (connectAccessibilityCallbacks): Added early return if
3768         disconnectAccessibilityCallbacks() did not disconnect the callbacks.
3769         (disconnectAccessibilityCallbacks): Added a return value to inform if
3770         callbacks were successfully disconnected.
3771
3772 2013-09-11  Anders Carlsson  <andersca@apple.com>
3773
3774         Try to fix GCC builds.
3775
3776         * TestWebKitAPI/Tests/WTF/MoveOnly.h:
3777
3778 2013-09-11  Anders Carlsson  <andersca@apple.com>
3779
3780         Try to fix the build.
3781
3782         Move MoveOnly.h to Tests/WTF and fix the broken Xcode project that caused me to add the header
3783         file in the Tests/ directory in the first place.
3784
3785         * TestWebKitAPI/CMakeLists.txt:
3786         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
3787         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
3788         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3789         * TestWebKitAPI/Tests/WTF/MoveOnly.h: Renamed from Tools/TestWebKitAPI/Tests/MoveOnly.h.
3790
3791 2013-09-11  Brent Fulgham  <bfulgham@apple.com>
3792
3793         [Windows] Build fix for MoveOnly
3794
3795         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props: Add
3796         Tests to include search path.
3797         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
3798         Ditto.
3799
3800 2013-09-11  Anders Carlsson  <andersca@apple.com>
3801
3802         Add HashSet::take
3803         https://bugs.webkit.org/show_bug.cgi?id=121192
3804
3805         Reviewed by Darin Adler.
3806
3807         Add a test for HashSet::take.
3808
3809         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3810         (TestWebKitAPI::TEST):
3811
3812 2013-09-11  Anders Carlsson  <andersca@apple.com>
3813
3814         HashSet should work with move only types
3815         https://bugs.webkit.org/show_bug.cgi?id=121188
3816
3817         Reviewed by Geoffrey Garen.
3818
3819         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3820         * TestWebKitAPI/Tests/MoveOnly.h: Added.
3821         Move the MoveOnly class from Vector out into its own header.
3822
3823         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3824         (TestWebKitAPI::TEST):
3825         Add aHashSet<MoveOnly> test.
3826
3827         * TestWebKitAPI/Tests/WTF/Vector.cpp:
3828         Include MoveOnly.h.
3829
3830 2013-09-11  Brent Fulgham  <bfulgham@apple.com>
3831
3832         [Windows] Avoid converting from IntSize->SIZE->IntSize
3833         https://bugs.webkit.org/show_bug.cgi?id=121180
3834
3835         Reviewed by Anders Carlsson.
3836
3837         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
3838         (TestWebKitAPI::TEST): Use IntSize instead of SIZE struct.
3839
3840 2013-09-11  Dan Bernstein  <mitz@apple.com>
3841
3842         REGRESSION (r155561): extract-localizable-strings can miss strings
3843         https://bugs.webkit.org/show_bug.cgi?id=121184
3844
3845         Reviewed by Darin Adler.
3846
3847         * Scripts/extract-localizable-strings: Don’t discard lines if we are waiting for a closing
3848         parenthesis or bracket.
3849
3850 2013-09-11  Dan Bernstein  <mitz@apple.com>
3851
3852         update-webkit-localizable-strings is at least 5.8x slower than it should be
3853         https://bugs.webkit.org/show_bug.cgi?id=121178
3854
3855         Reviewed by Darin Adler.
3856
3857         * Scripts/extract-localizable-strings: Quickly skip over lines that contain neither " nor /*.
3858         Note that this does not change functionality, because the script already does not understand
3859         the line continuation sequence (backslash followed by a newline).
3860
3861 2013-09-11  Anders Carlsson  <andersca@apple.com>
3862
3863         Vector::append doesn't work if element type has overloaded operator&
3864         https://bugs.webkit.org/show_bug.cgi?id=121175
3865
3866         Reviewed by Brent Fulgham.
3867
3868         Add a test case.
3869
3870         * TestWebKitAPI/Tests/WTF/Vector.cpp:
3871         (TestWebKitAPI::TEST):
3872
3873 2013-09-11  Anders Carlsson  <andersca@apple.com>
3874
3875         Implement Vector::append for move-only types
3876         https://bugs.webkit.org/show_bug.cgi?id=120805
3877
3878         Reviewed by Sam Weinig.
3879
3880         Add a test for Vector<MoveOnly>::append.
3881
3882         * TestWebKitAPI/Tests/WTF/Vector.cpp:
3883         (TestWebKitAPI::TEST):
3884
3885 2013-09-11  Csaba Osztrogonác  <ossy@webkit.org>
3886
3887         Unreviewed. Fix the indentation after r105848. Typo fix after r155523.
3888
3889         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3890         (RunAndUploadPerfTests):
3891         (RunAndUploadPerfTests.start):
3892         (RunAndUploadPerfTests.getText2):
3893
3894 2013-09-11  Anders Carlsson  <andersca@apple.com>
3895
3896         The style checker shouldn't complain about returning or passing OwnPtr
3897         https://bugs.webkit.org/show_bug.cgi?id=121163
3898
3899         Reviewed by Antti Koivisto.
3900
3901         * Scripts/webkitpy/style/checkers/cpp.py:
3902         (check_function_definition_and_pass_ptr):
3903         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3904         (PassPtrTest.test_pass_ref_ptr_return_value):
3905         (PassPtrTest.test_own_ptr_parameter_value):
3906
3907 2013-09-11  Mario Sanchez Prada  <mario.prada@samsung.com>
3908
3909         [GTK] Remove Gail dependency from build system for GTK3
3910         https://bugs.webkit.org/show_bug.cgi?id=119673
3911
3912         Reviewed by Gustavo Noronha Silva.
3913
3914         * EWSTools/ubuntu-ews-packages: Removed libgail-dev package.
3915         * Scripts/webkitpy/port/gtk.py:
3916         (GtkPort.setup_environ_for_server): Do not load the 'gail' module anymore.
3917         * TestWebKitAPI/GNUmakefile.am: Removed GAIL_LIBS.
3918
3919 2013-09-11  Gabor Abraham  <abrhm@inf.u-szeged.hu>
3920
3921         Performance tester bots should report the number of failing tests
3922         https://bugs.webkit.org/show_bug.cgi?id=120462
3923
3924         Reviewed by Csaba Osztrogonác.
3925
3926         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3927         (RunAndUploadPerfTests.start.getText):
3928         (RunAndUploadPerfTests.start):
3929         (RunAndUploadPerfTests):
3930         (RunAndUploadPerfTests.start.getText2):
3931
3932 2013-09-11  Krzysztof Czech  <k.czech@samsung.com>
3933
3934         [ATK] Adds mapping MenuItemRadioRole to ATK
3935         https://bugs.webkit.org/show_bug.cgi?id=121149
3936
3937         Reviewed by Mario Sanchez Prada.
3938
3939         Adds mapping MenuItemRadioRole to ATK.
3940
3941         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3942         (roleToString):
3943         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3944         (WTR::roleToString):
3945
3946 2013-09-10  Csaba Osztrogonác  <ossy@webkit.org>
3947
3948         Unreviewed fix after the unreviewed r155498 to unbreak the failure
3949         counter of run-javascriptcore-tests build step on build.webkit.org.
3950
3951         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3952         (RunJavaScriptCoreTests.commandComplete):
3953         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3954
3955 2013-09-10  Filip Pizlo  <fpizlo@apple.com>
3956
3957         Unreviewed, be a bit more clear about what we mean by 'js' tests. I think this
3958         got a bit overlooked from the fast/js->js refactoring.
3959
3960         * Scripts/run-javascriptcore-tests:
3961
3962 2013-09-10  Daniel Bates  <dabates@apple.com>
3963
3964         [iOS] Upstream text autosizing
3965         https://bugs.webkit.org/show_bug.cgi?id=121111
3966
3967         Reviewed by Andy Estes and Sam Weinig.
3968
3969         Implement infrastructure to test the iOS text autosizing code.
3970
3971         * DumpRenderTree/TestRunner.cpp:
3972         (setTextAutosizingEnabledCallback): Added.
3973         (TestRunner::staticFunctions):
3974         * DumpRenderTree/TestRunner.h:
3975         * DumpRenderTree/mac/DumpRenderTree.mm:
3976         (resetDefaultsToConsistentValues):
3977         * DumpRenderTree/mac/TestRunnerMac.mm:
3978         (TestRunner::setTextAutosizingEnabled): Added.
3979
3980 2013-09-10  Mark Hahnenberg  <mhahnenberg@apple.com>
3981
3982         run-jsc-stress-tests should have a mode for always running the copy phase
3983         https://bugs.webkit.org/show_bug.cgi?id=121128
3984
3985         Reviewed by Geoffrey Garen.
3986
3987         This will increase test coverage of the copying phase, which might not always get 
3988         triggered normally with our default parameters for required Heap/CopiedBlock utilization.
3989
3990         * Scripts/run-jsc-stress-tests:
3991
3992 2013-09-10  Sergio Correia  <sergio.correia@openbossa.org>
3993
3994         [EFL][JHBUILD] Use a tarball for libseccomp, instead of git
3995         https://bugs.webkit.org/show_bug.cgi?id=121114
3996
3997         Reviewed by Christophe Dumez.
3998
3999         Use a tarball for libseccomp instead of git to avoid network issues on
4000         the buildbots while checking out the git repo. Using tarballs has the
4001         advantage of them being cached if the checksum matches, in which case
4002         there will be no need to download them again.
4003
4004         * efl/jhbuild.modules:
4005
4006 2013-09-10  Mark Lam  <mark.lam@apple.com>
4007
4008         Replace remaining "fast js" names in scripts.
4009         https://bugs.webkit.org/show_bug.cgi?id=120899.
4010
4011         Rubber stamped by Filip Pizlo.
4012
4013         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
4014         (test_layout_failure_new_output):
4015         (test_layout_crash_new_output):
4016         (test_mozilla_and_layout_failure_new_output):
4017         * Scripts/run-fast-jsc: Removed.
4018         * Scripts/run-javascriptcore-tests:
4019         * Scripts/run-layout-jsc: Copied from Tools/Scripts/run-fast-jsc.
4020
4021 2013-09-10  Zan Dobersek  <zdobersek@igalia.com>
4022
4023         Enable JSC stress tests for the rest of non-Windows platforms
4024         https://bugs.webkit.org/show_bug.cgi?id=121021
4025
4026         Reviewed by Filip Pizlo.
4027
4028         The JSC stress tests can already be enabled on Linux-based ports.
4029
4030         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4031         (RunJavaScriptCoreTests.commandComplete): Reformulate the regular expressions used to find the number of regressed
4032         JSC tests of various test suites. The expressions now look for the suite-specific report compartment over the
4033         complete output, with the number of failing or crashing tests properly extracted.
4034         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add a couple of unit tests and expand the tested
4035         output in other unit tests testing the parsing of the output in the new format.
4036         (test_jsc_stress_failure_new_output):
4037         (test_fast_js_crashes_and_jsc_stress_failures_new_output):
4038         * Scripts/run-javascriptcore-tests: Enable the JSC stress tests on all but the Apple Win port.
4039         * Scripts/run-jsc-stress-tests: `sysctl -n hw.availcpu` doesn't work on Linux-based ports but the numProcesses
4040         variable is still gracefully assigned a zero value. In that case, try running `nproc --all` to gather the number
4041         of available CPUs so the stress tests can be run in parallel.
4042
4043 2013-09-10  Chris Fleizach  <cfleizach@apple.com>
4044
4045         AX: Expose DOM ID and ClassList to AX APIs for automation and AT element hashes
4046         https://bugs.webkit.org/show_bug.cgi?id=120552
4047
4048         Unreviewed build fix.
4049
4050         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
4051         (AccessibilityUIElement::classList):
4052
4053 2013-09-10  Chris Fleizach  <cfleizach@apple.com>
4054
4055         AX: Expose DOM ID and ClassList to AX APIs for automation and AT element hashes
4056         https://bugs.webkit.org/show_bug.cgi?id=120552
4057
4058         Reviewed by Darin Adler.
4059
4060         * DumpRenderTree/AccessibilityUIElement.cpp:
4061         (getClassListCallback):
4062         (AccessibilityUIElement::getJSClass):
4063         * DumpRenderTree/AccessibilityUIElement.h:
4064         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
4065         (AccessibilityUIElement::classList):
4066         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
4067         (AccessibilityUIElement::classList):
4068         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4069         (AccessibilityUIElement::classList):
4070         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
4071         (AccessibilityUIElement::classList):
4072         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
4073         (WTR::AccessibilityUIElement::classList):
4074         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
4075         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
4076         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4077         (WTR::AccessibilityUIElement::classList):
4078         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4079         (WTR::AccessibilityUIElement::classList):
4080
4081 2013-09-10  Denis Nomiyama  <d.nomiyama@samsung.com>
4082
4083         [GTK] accessibility/loading-iframe-sends-notification.html is failing
4084         https://bugs.webkit.org/show_bug.cgi?id=98370
4085
4086         Reviewed by Chris Fleizach.
4087
4088         Added AXLayoutComplete for the GTK platform.
4089
4090         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
4091         (axObjectEventListener): Added notification AXLayoutComplete for
4092         layout-complete signal.
4093
4094 2013-09-09  Brent Fulgham  <bfulgham@apple.com>
4095
4096         [Windows] Change from using OwnPtr<GDI Stuff> to new GDIObject.
4097         https://bugs.webkit.org/show_bug.cgi?id=120778
4098
4099         Reviewed by Anders Carlsson.
4100
4101         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
4102         (createBitmapContextFromWebView): Use GDIObject.
4103         * Scripts/webkitpy/style/checkers/cpp.py:
4104         (check_for_leaky_patterns): Update for GDIObject instead of adoptPtr and OwnPtr.
4105         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4106         (LeakyPatternTest.test_create_dc): Update for GDIObject instead of adoptPtr/OwnPtr.
4107         (LeakyPatternTest.test_create_compatible_dc): Ditto.
4108
4109 2013-09-10  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
4110
4111         Unreviewed. Add myself as a committer.
4112
4113         * Scripts/webkitpy/common/config/contributors.json:
4114
4115 2013-09-10  Mark Lam  <mark.lam@apple.com>
4116
4117         Move LayoutTests/fast/js to LayoutTests/js.
4118         https://bugs.webkit.org/show_bug.cgi?id=120899.
4119
4120         Rubber stamped by Filip Pizlo.
4121
4122         Changed scripts to reflect the path change.
4123
4124         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4125         (RunJavaScriptCoreTests.commandComplete):
4126         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
4127         (test_fast_js_failure_new_output):
4128         (test_fast_js_crash_new_output):
4129         (test_mozilla_and_fast_js_failure_new_output):
4130         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
4131         (BlackBerry::WebKit::DumpRenderTree::runTests):
4132         * Scripts/make-script-test-wrappers:
4133         (findTemplateFiles):
4134         * Scripts/run-fast-jsc:
4135         * Scripts/run-javascriptcore-tests:
4136         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
4137         (TestExpectations):
4138
4139 2013-09-10  Denis Nomiyama  <d.nomiyama@samsung.com>
4140
4141         [GTK] Missing DRT AccessibilityController::addNotificationListener implementation
4142         https://bugs.webkit.org/show_bug.cgi?id=70606
4143
4144         Reviewed by Mario Sanchez Prada.
4145
4146         Implemented the global notification listener for
4147         AccessibilityController. The signal is generated by
4148         AXObjectCache::postPlatformNotification() and received by
4149         axObjectEventListener(). axObjectEventListener will then invoke
4150         JSObjectCallAsFunction() with the respective callback function.
4151
4152         There is no additional test for this patch since its implementation will
4153         be tested by a11y layout tests that are currently skipped (e.g. bug
4154         98370).
4155
4156         * DumpRenderTree/AccessibilityController.h: Added a global notification
4157         handler for GTK+.
4158         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
4159         (AccessibilityController::AccessibilityController): Initializes the
4160         global handler with 0.
4161         (AccessibilityController::addNotificationListener): Creates the
4162         notification handler and sets the notification function callback.
4163         (AccessibilityController::removeNotificationListener): Removes the
4164         global handler.
4165
4166 2013-09-10  Krzysztof Czech  <k.czech@samsung.com>
4167
4168         [ATK] Incorrect type for holding float value
4169         https://bugs.webkit.org/show_bug.cgi?id=121091
4170
4171         Reviewed by Mario Sanchez Prada.
4172
4173         Variable is not set properly, because of it's type.
4174
4175         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4176         (WTR::alterCurrentValue):
4177
4178 2013-09-10  Allan Sandfeld Jensen  <allan.jensen@digia.com>
4179
4180         [Qt] make use of qtHaveModule() 
4181         https://bugs.webkit.org/show_bug.cgi?id=121090
4182
4183         Reviewed by Jocelyn Turcotte.
4184         Patch by Oswald Buddenhagen <oswald.buddenhagen@digia.com>
4185
4186         Use qtHaveModule instead of our own haveQtModule.
4187
4188         * QtTestBrowser/QtTestBrowser.pro:
4189         * qmake/mkspecs/features/configure.prf:
4190         * qmake/mkspecs/features/features.prf:
4191         * qmake/mkspecs/features/functions.prf:
4192
4193 2013-09-10  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
4194
4195         Unreviewed. Add myself as a committer.
4196
4197         * Scripts/webkitpy/common/config/contributors.json:
4198
4199 2013-09-10  Radu Stavila  <stavila@adobe.com>
4200
4201         Unreviewed. Added myself as a committer.
4202
4203         * Scripts/webkitpy/common/config/contributors.json:
4204
4205 2013-09-10  Mario Sanchez Prada  <mario.prada@samsung.com>
4206
4207         [GTK] Test /webkit/atk/getTextInParagraphAndBodyModerate fails
4208         https://bugs.webkit.org/show_bug.cgi?id=105538
4209
4210         Reviewed by Chris Fleizach.
4211
4212         Unskip passing test getTextInParagraphAndBodyModerate.
4213
4214         * Scripts/run-gtk-tests:
4215         (TestRunner): Unskip pasing test.
4216
4217 2013-09-09  Mark Lam  <mark.lam@apple.com>
4218
4219         Remove more references to the deleted js-test-style.css.
4220         https://bugs.webkit.org/show_bug.cgi?id=120899.
4221
4222         Reviewed by Ryosuke Niwa.
4223
4224         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
4225         (translate_includes):
4226
4227 2013-09-09  Mark Lam  <mark.lam@apple.com>
4228
4229         Re-landing r155392 (Point Tools scripts to LayoutTests/resources).
4230         https://bugs.webkit.org/show_bug.cgi?id=120899.
4231
4232         Not reviewed.
4233
4234         The webkitpy test failure that resulted in the rollout is due to
4235         update_webgl_conformance_tests_unittest.py referencing js-test-style.css
4236         which is to be deleted. Deleting that line fixes the issue.
4237
4238         * Scripts/make-new-script-test:
4239         (makePathToSharedSources):
4240         * Scripts/run-fast-jsc:
4241         * Scripts/webkitperl/httpd.pm:
4242         (getDefaultConfigForTestDirectory):
4243         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
4244         (LayoutTestApacheHttpd.__init__):
4245         * Scripts/webkitpy/layout_tests/servers/http_server.py:
4246         (Lighttpd.__init__):
4247         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
4248         (BaseTest.integration_test_port_and_root):
4249         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
4250         (TestHttpServer.test_start_cmd):
4251         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
4252         (translate_includes):
4253         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
4254         (TestTranslation.test_include_rewriting):
4255
4256 2013-09-09  Mark Lam  <mark.lam@apple.com>
4257
4258         Rolling out r155392 (Point Tools scripts to LayoutTests/resources): breaks tests.
4259         https://bugs.webkit.org/show_bug.cgi?id=120899.
4260
4261         Not reviewed.
4262
4263         * Scripts/make-new-script-test:
4264         (makePathToSharedSources):
4265         * Scripts/run-fast-jsc:
4266         * Scripts/webkitperl/httpd.pm:
4267         (getDefaultConfigForTestDirectory):
4268         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
4269         (LayoutTestApacheHttpd.__init__):
4270         * Scripts/webkitpy/layout_tests/servers/http_server.py:
4271         (Lighttpd.__init__):
4272         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
4273         (BaseTest.integration_test_port_and_root):
4274         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
4275         (TestHttpServer.test_start_cmd):
4276         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
4277         (translate_includes):
4278         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
4279         (TestTranslation.test_include_rewriting):
4280
4281 2013-09-09  Mark Lam  <mark.lam@apple.com>
4282
4283         Point Tools scripts to LayoutTests/resources.
4284         https://bugs.webkit.org/show_bug.cgi?id=120899.
4285
4286         Reviewed by Ryosuke Niwa.
4287
4288         * Scripts/make-new-script-test:
4289         (makePathToSharedSources):
4290         * Scripts/run-fast-jsc:
4291         * Scripts/webkitperl/httpd.pm:
4292         (getDefaultConfigForTestDirectory):
4293         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
4294         (LayoutTestApacheHttpd.__init__):
4295         * Scripts/webkitpy/layout_tests/servers/http_server.py:
4296         (Lighttpd.__init__):
4297     &nb