eb84d4399038b9f3b5bc63d398ae5c7dfd09cf72
[WebKit-https.git] / Tools / ChangeLog
1 2012-01-24  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Build fix attempt after r105543.
4
5         * Scripts/webkitpy/common/net/file_uploader.py:
6         (FileUploader.upload_as_multipart_form_data):
7
8 2012-01-24  Mario Sanchez Prada  <msanchez@igalia.com>
9
10         Unreviewed, skip WK2 API test timing out on some GTK bots.
11
12         WebKit2APITests/TestDownloads is consistently timing out on the
13         32bit release and 64bit debug bots.
14
15         * Scripts/run-gtk-tests:
16         (TestRunner): Skip WebKit2APITests/TestDownloads.
17
18 2012-01-24  Andras Becsi  <andras.becsi@nokia.com>
19
20         [Qt] Fix the build with the newes Qt5 hashes
21         https://bugs.webkit.org/show_bug.cgi?id=76657
22
23         Reviewed by Simon Hausmann.
24
25         * MiniBrowser/qt/MiniBrowserApplication.cpp:
26         (MiniBrowserApplication::MiniBrowserApplication): Disable the automatic touch->mouse event synthesis
27         for now to prevent an infinite loop where Qt always creates mouse events out of our touch mock events.
28
29 2012-01-24  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
30
31         [Qt] Distinguish between Cygwin and cmd.exe in the way we set env variables
32
33         We can't use win32-msvc* to decide whether or not to use (set FOO=bar), as
34         building with MinGW inside cmd.exe will require the same construct. Instead
35         we assume that when the first character in PWD is a '/' we're running under
36         Cygwin, and use the normal unix way of setting environment variables.
37
38         Reviewed by Simon Hausmann.
39
40         * qmake/mkspecs/features/default_pre.prf:
41
42 2012-01-24  Simon Hausmann  <simon.hausmann@nokia.com>
43
44         Some qmake build files must include Qt5's "quick" module.
45         https://bugs.webkit.org/show_bug.cgi?id=76671
46
47         Unreviewed build fix.
48
49         * MiniBrowser/qt/MiniBrowser.pro:
50         * WebKitTestRunner/Target.pri:
51
52 2012-01-24  Andras Becsi  <andras.becsi@nokia.com>
53
54         [Qt] Fix the event timestamps for touch mocking
55
56         Reviewed by Simon Hausmann.
57
58         * MiniBrowser/qt/MiniBrowserApplication.cpp:
59         (MiniBrowserApplication::sendTouchEvent): We should not set QEvent::None as the
60         timestamp argument in the QWindowSystemInterface::handleTouchEvent call.
61
62 2012-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
63
64         [GTK] Implement DownloadClient in WebKit2 GTK+ API
65         https://bugs.webkit.org/show_bug.cgi?id=72952
66
67         Reviewed by Martin Robinson.
68
69         * gtk/generate-gtkdoc:
70         (get_webkit2_options): Ignore WebKitDownloadClient.
71
72 2012-01-23  Zan Dobersek  <zandobersek@gmail.com>
73
74         [GTK] editing/deleting/5408255.html results are incorrect
75         https://bugs.webkit.org/show_bug.cgi?id=53644
76
77         Reviewed by Martin Robinson.
78
79         WEBKIT_TOP_LEVEL environment variable is now set directly in either
80         WebKitTestRunner or DumpRenderTree through usage of a compilation-time
81         macro. This way both tools can be run outside the test harness without
82         the need to manually set the environment variable.
83
84         * DumpRenderTree/gtk/DumpRenderTree.cpp:
85         (getTopLevelPath):
86         * GNUmakefile.am:
87         * Scripts/webkitpy/layout_tests/port/gtk.py:
88         (GtkPort.setup_environ_for_server):
89         * WebKitTestRunner/GNUmakefile.am:
90         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
91         (WTR::InjectedBundle::platformInitialize):
92
93 2012-01-23  Dmitry Lomov  <dslomov@google.com>
94
95         [Chromium] Implement layoutTestController.workerThreadCount in DRT
96         https://bugs.webkit.org/show_bug.cgi?id=74653.
97
98         Reviewed by Darin Fisher.
99
100         * DumpRenderTree/chromium/LayoutTestController.cpp:
101         (LayoutTestController::LayoutTestController):
102         (LayoutTestController::workerThreadCount):
103         * DumpRenderTree/chromium/LayoutTestController.h:
104
105 2012-01-23  Dirk Pranke  <dpranke@chromium.org>
106
107         nrwt: make --chromium work like --qt
108         https://bugs.webkit.org/show_bug.cgi?id=76875
109
110         Reviewed by Adam Barth.
111
112         --chromium used to have to be handled differently from --qt
113         due to the way the PortFactory was implemented; there's not
114         really a good reason for that any more so this patch makes
115         things slightly more consistent and eliminates the
116         options.chromium flag (--chromium is now truly a synonym for
117         --platform chromium).
118
119         * Scripts/webkitpy/layout_tests/port/factory.py:
120         (PortFactory._default_port):
121         (PortFactory.get):
122         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
123         (FactoryTest.setUp):
124         (FactoryTest.test_chromium_mac):
125         (FactoryTest.test_chromium_linux):
126         (FactoryTest.test_chromium_win):
127         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
128         (parse_args):
129
130 2012-01-23  Dirk Pranke  <dpranke@chromium.org>
131
132         run-webkit-tests needs to propagate --chromium
133         https://bugs.webkit.org/show_bug.cgi?id=76870
134
135         Reviewed by Eric Seidel.
136
137         run-webkit-tests removes '--chromium' argument from @ARGV when
138         determining which port to run, which means that that doesn't
139         propagate to new-run-webkit-tests. That's bad (and is handled
140         for the other ports by re-adding the flag, but apparently we're
141         just now noticing for Chromium).
142
143         * Scripts/run-webkit-tests:
144
145 2012-01-23  Brian Weinstein  <bweinstein@apple.com>
146
147         More build fixing after r105646.
148
149         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
150         (TestWebKitAPI::TestNode::key):
151
152 2012-01-23  Gavin Barraclough  <barraclough@apple.com>
153
154         Unreviewed build fix - r105646 broke this.
155
156         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
157         (TestWebKitAPI::TestNode::TestNode):
158         (TestWebKitAPI::TestNode::key):
159         (TestWebKitAPI::RedBlackTreeTest::assertEqual):
160         (TestWebKitAPI::RedBlackTreeTest::assertSameValuesForKey):
161         (TestWebKitAPI::RedBlackTreeTest::testDriver):
162
163 2012-01-23  Sheriff Bot  <webkit.review.bot@gmail.com>
164
165         Unreviewed, rolling out r105658.
166         http://trac.webkit.org/changeset/105658
167         https://bugs.webkit.org/show_bug.cgi?id=76883
168
169         We want this eventually, but not right at this moment
170         (Requested by abarth on #webkit).
171
172         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
173
174 2012-01-23  Adam Barth  <abarth@webkit.org>
175
176         garden-o-matic should support Chromium Mac Lion
177         https://bugs.webkit.org/show_bug.cgi?id=76880
178
179         Reviewed by Eric Seidel.
180
181         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
182
183 2012-01-23  Emil A Eklund  <eae@chromium.org>
184
185         check-webkit-style whitespace/operators triggers on overloaded division operator
186         https://bugs.webkit.org/show_bug.cgi?id=76650
187
188         Reviewed by Darin Adler.
189
190         * Scripts/webkitpy/style/checkers/cpp.py:
191         (check_spacing):
192         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
193         (CppStyleTest.test_operator_methods):
194
195 2012-01-23  Ryosuke Niwa  <rniwa@webkit.org>
196
197         run-perf-tests should report server-side errors
198         https://bugs.webkit.org/show_bug.cgi?id=76802
199
200         Reviewed by Tony Chang.
201
202         Report errors whenever server's response doesn't match "OK".
203
204         * Scripts/webkitpy/common/net/file_uploader.py:
205         (FileUploader.upload_single_text_file):
206         (FileUploader.upload_as_multipart_form_data):
207         (FileUploader._upload_data.callback):
208         (FileUploader):
209         (FileUploader._upload_data):
210         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
211         (PerfTestsRunner._upload_json):
212         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
213         (test_upload_json):
214         (test_upload_json.MockFileUploader.upload_single_text_file):
215
216 2012-01-22  Ryosuke Niwa  <rniwa@webkit.org>
217
218         run-perf-tests ignore Skipped list on chromium
219         https://bugs.webkit.org/show_bug.cgi?id=76764
220
221         Reviewed by Dirk Pranke.
222
223         Move skipped_perf_tests from WebKit port to Base port so that Chromium port
224         can also find skipped list. Chromium port only uses test_expectations.txt for
225         layout tests but performacne tests don't use test_expectations.txt so Chromium port
226         also needs to use Skipped list.
227
228         * Scripts/webkitpy/layout_tests/port/base.py:
229         (Port._tests_from_skipped_file_contents):
230         (Port):
231         (Port._expectations_from_skipped_files):
232         (Port.skipped_perf_tests):
233         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
234         (PortTest.test_skipped_perf_tests):
235         (PortTest.test_skipped_perf_tests.add_text_file):
236         * Scripts/webkitpy/layout_tests/port/webkit.py:
237         (WebKitPort._skipped_tests_for_unsupported_features):
238         (WebKitPort._skipped_file_search_paths):
239         (WebKitPort.skipped_layout_tests):
240
241 2012-01-23  Andy Estes  <aestes@apple.com>
242
243         Fix the build after r105635.
244
245         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
246         (TestWebKitAPI::TEST):
247
248 2012-01-23  Xianzhu Wang  <wangxianzhu@chromium.org>
249
250         Basic enhancements to StringBuilder
251         https://bugs.webkit.org/show_bug.cgi?id=67081
252
253         Reviewed by Darin Adler.
254
255         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
256         (TestWebKitAPI::TEST):
257
258 2012-01-23  Mario Sanchez Prada  <msanchez@igalia.com>
259
260         [GTK] run-gtk-tests randomly fails while running the xprop comand
261         https://bugs.webkit.org/show_bug.cgi?id=76817
262
263         Reviewed by Gustavo Noronha Silva.
264
265         No need to use xprop to remove the AT_SPI_BUS property since
266         run-gtk-tests will always run new instances of Xvfb.
267
268         * Scripts/run-gtk-tests:
269         (TestRunner): Unskip TestWebKitAccessibility.
270         (TestRunner.run): Uncomment lines for launching the accessibility
271         bus and registry daemon, and remove lines for running xprop.
272
273 2012-01-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
274
275         [Qt] Don't warn about override and final being C++11 extensions
276
277         Clang will emit a warning when these extensions are used without passing
278         --std=c++11, but we use feature checking to decide if we have the right
279         extensions, so we can safely ignore these warnings. The XCode and Windows
280         project files have the same workaround.
281
282         The reason for adding the flag to QMAKE_OBJECTIVE_CFLAGS as well is that
283         we only have one extra compiler for Objective-C, which is also used for
284         Objective-C++ sources, so we have to pass the flag, even if it doesn't
285         make sense for Objective-C.
286
287         Reviewed by Simon Hausmann.
288
289         * qmake/mkspecs/features/unix/default_post.prf:
290
291 2012-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
292
293         [Qt] Change how build-webkit decides when to do full incremental builds
294
295         Instead of relying on update-webkit (which isn't run on the bots) to
296         decide when to do a full incremental build (make qmake), we let the
297         build-webkit script itself check the current SVN revision against the
298         previous build (by storing it in .webkit.config).
299
300         If the two differ we assume a full incremental build is needed, since
301         the new revisions might have introduced problematic things like new
302         Q_OBJECT macros. If not, we assume the developer is doing changes
303         locally, and revert to doing a plain 'make'.
304
305         In addition, when the build fails in the latter case, we inform the
306         developer of possible pitfalls and how to manually run 'make qmake'.
307
308         Reviewed by Ossy.
309
310         * Scripts/update-webkit:
311         * Scripts/webkitdirs.pm:
312         (buildQMakeProjects):
313
314 2012-01-23  Mario Sanchez Prada  <msanchez@igalia.com>
315
316         [GTK] run-gtk-tests randomly fails while running the xprop comand
317         https://bugs.webkit.org/show_bug.cgi?id=76817
318
319         Reviewed by Philippe Normand.
320
321         Temporarily comment the lines related to launching the ATSPI bus
322         and registry daemon, which are making the bots to fail randomly.
323
324         * Scripts/run-gtk-tests:
325         (TestRunner): Skip TestWebKitAccessibility, as it won't run
326         properly if the ATSPI infrastructure is not properly initialized.
327         (TestRunner.run): Comment lines related to initialization of ATSPI.
328
329 2012-01-22  Ryosuke Niwa  <rniwa@webkit.org>
330
331         Windows python test build fix.
332
333         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
334         (PerfTestsRunner.__init__):
335
336 2012-01-22  Sergio Villar Senin  <svillar@igalia.com>
337
338         [GTK] DumpRenderTree converts "file:///" to a path differently
339         https://bugs.webkit.org/show_bug.cgi?id=76631
340
341         Reviewed by Martin Robinson.
342
343         DumpRenderTree should print "/" as the last path component if the
344         path is a lone slash instead of empty output.
345
346         * DumpRenderTree/gtk/DumpRenderTree.cpp:
347         (webViewConsoleMessage):
348
349 2012-01-20  David Levin  <levin@chromium.org>
350
351         The leaky DC check should use adoptPtr as a signal instead of OwnPtr to get less false positives.
352         https://bugs.webkit.org/show_bug.cgi?id=76752
353
354         Reviewed by Eric Seidel.
355
356         * Scripts/webkitpy/style/checkers/cpp.py:
357         (check_for_leaky_patterns):
358         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
359         (LeakyPatternTest.test_create_dc):
360         (LeakyPatternTest.test_create_compatible_dc):
361
362 2012-01-20  Shawn Singh  <shawnsingh@chromium.org>
363
364         Changed my status in commiters.py
365
366         Unreviewed.
367
368         * Scripts/webkitpy/common/config/committers.py:
369
370 2012-01-20  Ojan Vafai  <ojan@chromium.org>
371
372         run-webkit-tests --lint-test-files crawls the whole LayoutTests subtree
373         https://bugs.webkit.org/show_bug.cgi?id=76748
374
375         Reviewed by Ryosuke Niwa.
376
377         It crawls the whole subtree and then doesn't use the data. Cutting this out
378         saves 4 seconds warm and 17 seconds cold on my Mac Pro.
379
380         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
381         (run):
382
383 2012-01-20  Adam Barth  <abarth@webkit.org>
384
385         Another tiny tweak to the garden-o-matic CSS.  This makes things line
386         up slightly nicer when there aren't any failures.
387
388         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
389         (#summary):
390
391 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
392
393         run-perf-tests should support --test-results-server option
394         https://bugs.webkit.org/show_bug.cgi?id=76680
395
396         Reviewed by Adam Barth.
397
398         Add --test-results-server, --builder-name, and --build-number options to run-perf-tests
399         to be used by perf bots. Also refactor file_uploader as needed.
400
401         * Scripts/webkitpy/common/net/file_uploader.py:
402         (FileUploader.__init__):
403         (FileUploader.upload_single_file):
404         (FileUploader.upload_as_multipart_form_data):
405         (FileUploader):
406         (FileUploader._upload_data):
407         (FileUploader._upload_data.callback):
408         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
409         (JSONResultsGeneratorBase.upload_json_files):
410         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
411         (PerfTestsRunner):
412         (PerfTestsRunner._parse_args):
413         (PerfTestsRunner.run):
414         (PerfTestsRunner._generate_json):
415         (PerfTestsRunner._upload_json):
416         (PerfTestsRunner._run_tests_set):
417         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
418         (create_runner):
419         (test_run_with_upload_json):
420         (test_run_with_upload_json.mock_upload_json):
421         (test_upload_json):
422         (test_upload_json.MockFileUploader):
423         (test_upload_json.MockFileUploader.__init__):
424         (test_upload_json.MockFileUploader.upload_single_file):
425         (test_parse_args):
426
427 2012-01-20  Adam Barth  <abarth@webkit.org>
428
429         The party time image overlaps real content!  This patch makes the
430         image centered vertically.
431
432         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
433         (#onebar.partytime #summary):
434
435 2012-01-19  Ojan Vafai  <ojan@chromium.org>
436
437         Refactor TestExpectationsParser in preparation for caching the results
438         https://bugs.webkit.org/show_bug.cgi?id=76669
439
440         Reviewed by Dimitri Glazkov.
441
442         Make everything private expect for the parse method. 
443         Eventually, we'll need the expectations lines to not be modified
444         outside of TestExpectationsParser so we can cache the results.
445         This makes check-webkit-style of the chromium test_expectations.txt file
446         go from ~17 seconds to ~12 seconds on my Mac Pro.
447
448         This patch is just a refactor in preparation, so no new tests.
449
450         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
451         (TestExpectationEditorTests.make_parsed_expectation_lines):
452         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
453         (TestExpectationParser.parse):
454         (TestExpectationParser):
455         (TestExpectationParser._parse_line):
456         (TestExpectationParser._tokenize):
457         (TestExpectationParser._tokenize_list):
458         (TestExpectationsModel._clear_expectations_for_test):
459         (TestExpectations.__init__):
460         (TestExpectations._add_expectations):
461         (TestExpectations._add_skipped_tests):
462         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
463         (TestExpectationParserTests.test_tokenize_blank):
464         (TestExpectationParserTests.test_tokenize_missing_colon):
465         (TestExpectationParserTests.test_tokenize_extra_colon):
466         (TestExpectationParserTests.test_tokenize_empty_comment):
467         (TestExpectationParserTests.test_tokenize_comment):
468         (TestExpectationParserTests.test_tokenize_missing_equal):
469         (TestExpectationParserTests.test_tokenize_extra_equal):
470         (TestExpectationParserTests.test_tokenize_valid):
471         (TestExpectationParserTests.test_tokenize_valid_with_comment):
472         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
473         (TestExpectationParserTests.test_parse_empty_string):
474         (TestExpectationSerializerTests.assert_round_trip):
475         (TestExpectationSerializerTests.assert_list_round_trip):
476         * Scripts/webkitpy/tool/commands/expectations.py:
477         (OptimizeExpectations.execute):
478         * Scripts/webkitpy/tool/servers/gardeningserver.py:
479         (GardeningExpectationsUpdater.update_expectations):
480
481 2012-01-20  Adam Barth  <abarth@webkit.org>
482
483         Follow-up to previous patch: don't produce NaN when the revision number
484         is missing.
485
486         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
487         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
488
489 2012-01-20  Adam Barth  <abarth@webkit.org>
490
491         Garden-o-matic should tell me which revisions have been checked by all the bots
492         https://bugs.webkit.org/show_bug.cgi?id=76722
493
494         Reviewed by Dimitri Glazkov.
495
496         This information helps me know when it's safe for me to roll a
497         candidate revision.
498
499         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
500         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
501         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
502
503 2012-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
504
505         build-webkit: Don't spit out congratulations message on Ctrl+C
506
507         Reviewed by Andreas Kling.
508
509         * Scripts/build-webkit:
510
511 2012-01-20  Philippe Normand  <pnormand@igalia.com>
512
513         [GTK] Allow extra jhbuild modulesets
514         https://bugs.webkit.org/show_bug.cgi?id=76691
515
516         Reviewed by Gustavo Noronha Silva.
517
518         * gtk/jhbuildrc: Extra modulesets and modules can be added in
519         JHBuild using the WEBKIT_EXTRA_MODULESETS and WEBKIT_EXTRA_MODULES
520         env variables respectively. Use comma-separated values. Example:
521         WEBKIT_EXTRA_MODULES=file:///path/to/module.set,file:///other/path.
522
523 2012-01-20  Mario Sanchez Prada  <msanchez@igalia.com>
524
525         [GTK] Expose accessibility hierarchy in WebKit2 to ATK/AT-SPI based ATs
526         https://bugs.webkit.org/show_bug.cgi?id=72589
527
528         Reviewed by Martin Robinson.
529
530         Ensure the accessibility infrastructure is available when running
531         the unit tests, otherwise WK2's accessibility tests won't work.
532
533         * Scripts/run-gtk-tests:
534         (TestRunner):
535         (TestRunner._lookup_atspi2_binary): New. Looks for the directory
536         where at-spi2's stuff is located (like at-spi-bus-launcher and
537         at-spi2-registryd).
538         (TestRunner.run): Initialize the accessibility infrastructure.
539
540         * gtk/generate-gtkdoc:
541         (get_webkit2_options): Add 'WebKitWebViewBaseAccessible.*'.
542
543         * gtk/jhbuild.modules: Added at-spi2-core and at-spi2-atk.
544
545 2012-01-20  Hayato Ito  <hayato@chromium.org>
546
547         Add ShadowRoot.idl which is enabled by newly introduced SHADOW_DOM flag.
548         https://bugs.webkit.org/show_bug.cgi?id=76353
549
550         Reviewed by Hajime Morita.
551
552         Add ShadowRoot.idl, which is enabled only on chromium port since this is
553         under development feature.
554         ShadowRoot.idl contains minimum API so that we can test it.
555         Other APIs should be added on other changes so that we can isolate issues.
556
557         * DumpRenderTree/chromium/TestShell.cpp:
558         (TestShell::TestShell):
559
560 2012-01-20  Mario Sanchez Prada  <msanchez@igalia.com>
561
562         [GTK] GTK's DRT not to log events for already defunct objects
563         https://bugs.webkit.org/show_bug.cgi?id=76620
564
565         Reviewed by Martin Robinson.
566
567         Do not log 'state-change:defunct' events.
568
569         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
570         (printAccessibilityEvent): Early return if a
571         'state-change:defunct' signal is passed.
572         (axObjectEventListener): Pass the signal name and value in
573         separate parameters to printAccessibilityEvent.
574
575 2012-01-19  Gustavo Noronha Silva  <gns@gnome.org>
576
577         Unreviewed build fix. Wrong variable being used as the cwd for git
578         remote update command.
579
580         * gtk/run-with-jhbuild:
581         (update_jhbuild):
582
583 2012-01-19  Gustavo Noronha Silva  <gns@gnome.org>
584
585         [GTK] ensure the jhbuild used by webkit is as up-to-date as needed
586         https://bugs.webkit.org/show_bug.cgi?id=76585
587
588         Reviewed by Martin Robinson.
589
590         This allows us to specify a minimum version of jhbuild required,
591         while also providing stability against changes done to the master
592         branch, by letting us choose what is the exact version that will
593         be used.
594
595         * gtk/run-with-jhbuild: refactored for more hackability and easier
596         reading
597         (jhbuild_installed): checks whether jhbuild is installed
598         (jhbuild_cloned): checks whether jhbuild has been cloned
599         (jhbuild_at_expected_revision): checks whether jhbuild is at the
600         expected revision
601         (update_jhbuild): brings jhbuild to the expected revision
602         (clone_jhbuild): clones jhbuild
603         (install_jhbuild): build and installs jhbuild
604         (update_webkitgtk_libs): runs update-webkitgtk-libs
605         (ensure_jhbuild): high-level logic to decide whether and which of
606         the steps above are executed
607
608 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
609
610         [WK2] DumpRenderTree converts "file:///" to a path differently
611         https://bugs.webkit.org/show_bug.cgi?id=76653
612
613         Reviewed by John Sullivan.
614
615         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::lastFileURLPathComponent):
616         Do print a slash if there are no path components.
617
618 2012-01-19  Eric Seidel  <eric@webkit.org>
619
620         webkit-patch cannot rollout patches without changelog/bug number
621         https://bugs.webkit.org/show_bug.cgi?id=75962
622
623         Reviewed by Adam Barth.
624
625         * Scripts/webkitpy/tool/commands/download.py:
626         (AbstractRolloutPrepCommand._prepare_state):
627         * Scripts/webkitpy/tool/commands/download_unittest.py:
628         (AbstractRolloutPrepCommandTest.test_prepare_state):
629
630 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
631
632         [WK2] fast/url/degenerate-file-base.html fails
633         https://bugs.webkit.org/show_bug.cgi?id=76619
634
635         Reviewed by Adam Roben.
636
637         A URL generated form local path for loading had an extra slash, making document.URL
638         incorrect in all WebKit2 tests (file://localhost//path/to/test.html).
639
640         * WebKitTestRunner/TestInvocation.cpp: (WTR::createWKURL):
641
642 2012-01-18  Ojan Vafai  <ojan@chromium.org>
643
644         check-webkit-style of the chromium test_expectations.txt file doesn't test all chromium ports
645         https://bugs.webkit.org/show_bug.cgi?id=76510
646
647         Reviewed by Adam Barth.
648
649         Unlike other style rules, if you get the syntax of the test_expectations.txt
650         file wrong, the layout tests won't run. Also, this check is simple and only
651         slows down committing if you actually modify one of the test_expectations.txt files.
652
653         * Scripts/webkitpy/style/checkers/test_expectations.py:
654         (TestExpectationsChecker.check_test_expectations):
655         (TestExpectationsChecker.check):
656         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
657         (TestExpectationsTestCase.test_check_covers_all_configurations):
658         (TestExpectationsTestCase.test_check_covers_all_configurations.mock_check_test_expectations):
659         (TestExpectationsTestCase):
660         (assert_lines_lint):
661
662 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
663
664         Build fix. Revert an unintentional change to WebKitDriver in r105443.
665
666         * Scripts/webkitpy/layout_tests/port/driver.py:
667         (DriverProxy.__init__):
668
669 2012-01-19  Dirk Pranke  <dpranke@chromium.org>
670
671         remove the duplicated build rules from WebKit.gyp, Tools.gyp
672         https://bugs.webkit.org/show_bug.cgi?id=73384
673
674         Reviewed by Tony Chang.
675
676         This patch removes the no-longer-necessary conditional logic for
677         build_webkit_exes_from_webkit_gyp; we now always build the exes
678         from their own dedicated gyp files.
679
680         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
681
682 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
683
684         make-new-script-test should work with HTTP tests
685         https://bugs.webkit.org/show_bug.cgi?id=76603
686
687         Reviewed by Adam Roben.
688
689         * Scripts/make-new-script-test:
690         (makePathToSharedSources): Renamed from makeTestRelativePathToSharedSources(), since it
691         now also creates absolute paths for HTTP.
692
693 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
694
695         Some perf tests time out when ran by run-perf-tests
696         https://bugs.webkit.org/show_bug.cgi?id=76612
697
698         Reviewed by Dirk Pranke and Eric Seidel.
699
700         Always pass --no-timeout to DumpRenderTree from run-perf-tests.
701         Otherwise some tests such as Parser/xml-parser.html will timeout.
702
703         --no-timeout option is currently supported by Chromium and Mac ports.
704
705         * Scripts/webkitpy/layout_tests/port/base.py:
706         (Port.to.create_driver):
707         * Scripts/webkitpy/layout_tests/port/chromium.py:
708         (ChromiumDriver.__init__):
709         (ChromiumDriver._wrapper_options):
710         * Scripts/webkitpy/layout_tests/port/driver.py:
711         (Driver.__init__):
712         (DriverProxy.__init__):
713         * Scripts/webkitpy/layout_tests/port/webkit.py:
714         (WebKitDriver.__init__):
715         (WebKitDriver.cmd_line):
716         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
717         (WebKitDriverTest.test_read_binary_block):
718         (WebKitDriverTest):
719         (WebKitDriverTest.test_no_timeout):
720         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
721         (get_tests_run.RecordingTestDriver.__init__):
722         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
723         (PerfTestsRunner._parse_args):
724         (PerfTestsRunner._run_tests_set):
725         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
726         (create_runner):
727
728 2012-01-19  Ben Wells  <benwells@chromium.org>
729
730         Add support for window.print to chromium DRT
731         https://bugs.webkit.org/show_bug.cgi?id=76479
732
733         When used in a test window.print goes into print mode and then
734         straight out again. This will allow the afterprint event to be
735         tested by having the afterprint event happen before the dump
736         happens.
737
738         Reviewed by Mihai Parparita.
739
740         * DumpRenderTree/chromium/WebViewHost.cpp:
741         (WebViewHost::printPage):
742         * DumpRenderTree/chromium/WebViewHost.h:
743
744 2012-01-18  Enrica Casucci  <enrica@apple.com>
745
746         editingAttributedStringFromRange in WebHTMLConverter does not handle NSUnderlineStyleAttributeName.
747         https://bugs.webkit.org/show_bug.cgi?id=76588
748         <rdar://problem/9325183>
749
750         Added test.
751         
752         Reviewed by Dan Bernstein.
753
754         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
755         (TestWebKitAPI::TEST):
756
757 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
758
759         [Qt] Do full incremental builds until bots use update-webkit
760
761         Rubber-stamped by Simon Hausmann.
762
763         * Scripts/webkitdirs.pm:
764         (buildQMakeProjects):
765
766 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
767
768         Fix the Qt build
769
770         Unreviewed build fix.
771
772         * Scripts/webkitdirs.pm:
773         (buildQMakeProjects):
774
775 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
776
777         [Qt] Make build-webkit always do safe incremental builds after update-webkit
778
779         When building against Qt5 with GCC we would just run 'make' in the build dir,
780         and rely on the dependency files output by GCC (-MD) to handle dependency
781         tracking, but that fails for special-cases like adding a Q_OBJECT macro
782         to a header.
783
784         To guarantee that an incrmental build will work, we have to run 'make qmake',
785         which we now do on every build-webkit that's followed by a successful run
786         of update-webkit. The reasoning is that update-webkit can result in such
787         potential corner-cases being applied, and since we can't know for sure
788         unless we inspect the diff and account for all the corner cases we assume
789         the worst and always run 'make qmake'.
790
791         After a succesful run of build-webkit we proceed to do just 'make' for any
792         subsequent runs, since we assume that the developer knows what kind of
793         changes he/she is doing, and when a 'make qmake' is needed.
794
795         Reviewed by Simon Hausmann.
796
797         * Scripts/update-webkit:
798         * Scripts/webkitdirs.pm:
799         (determineCurrentSVNRevision):
800         (currentSVNRevision):
801         (buildQMakeProjects):
802         * qmake/mkspecs/features/default_post.prf:
803
804 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
805
806         run-perf-tests should support Skipped list
807         https://bugs.webkit.org/show_bug.cgi?id=76594
808
809         Reviewed by Adam Barth.
810
811         Add a support for Skipped list in run-perf-tests; also skip files in resources directories.
812
813         * Scripts/webkitpy/layout_tests/port/base.py:
814         (Port.perf_tests_dir):
815         (Port.skipped_perf_tests):
816         (Port.skips_perf_test):
817         (Port.relative_perf_test_filename):
818         * Scripts/webkitpy/layout_tests/port/test.py:
819         (TestPort.perf_tests_dir):
820         * Scripts/webkitpy/layout_tests/port/webkit.py:
821         (WebKitPort._expectations_from_skipped_files):
822         (WebKitPort):
823         (WebKitPort.skipped_layout_tests):
824         (WebKitPort.skipped_perf_tests):
825         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
826         (PerfTestsRunner._collect_tests):
827         (PerfTestsRunner.run):
828         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
829         (test_run_test_set_with_json_output):
830         (test_run_test_set_with_json_source):
831         (test_collect_tests_with_skipped_list):
832         (test_collect_tests_with_skipped_list.add_file):
833
834 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
835
836         Fix path to chromium_src_dir introduced in previous change.
837
838         Unreviewed, build fix.
839
840         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
841
842 2012-01-18  Alexey Proskuryakov  <ap@apple.com>
843
844         Need infrastructure to test Content-Disposition filename encoding support
845         https://bugs.webkit.org/show_bug.cgi?id=76572
846         <rdar://problem/6421825>
847
848         Reviewed by Sam Weinig.
849
850         Made policy delegate log suggested file name when resource has Content-Disposition: attachment.
851
852         WebKitTestRunner does not have a policy delegate yet, bug 42546.
853
854         * DumpRenderTree/mac/PolicyDelegate.mm:
855         (dispositionTypeFromContentDispositionHeader):
856         (-[PolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
857
858 2012-01-18  Ojan Vafai  <ojan@chromium.org>
859
860         Fix tests from http://trac.webkit.org/changeset/105332.
861
862         The code assumed that if you passed an options object with a configuration
863         attribute that it would have a valid value. A bunch of the testing mocks
864         do things like having a configuration value of None.
865
866         * Scripts/webkitpy/layout_tests/port/base.py:
867         (Port.__init__):
868
869 2012-01-18  Ojan Vafai  <ojan@chromium.org>
870
871         Shave 0.5 seconds off check-webkit-style runtime for test_expectations.txt
872         https://bugs.webkit.org/show_bug.cgi?id=76576
873
874         Reviewed by Adam Barth.
875
876         Avoid calling default_configuration in base.py. We don't need it for
877         checking test_expectations.txt style. It takes ~0.5 seconds to run on my
878         Mac Pro. It's the call to "perl Tools/Scripts/webkit-build-directory --top-level"
879         from common.executive.
880
881         At some point someone should probably look into why that call is so slow
882         since it's on the critical path for run-webkit-tests and build-webkit startup.
883
884         * Scripts/webkitpy/layout_tests/port/base.py:
885         (Port.__init__):
886         * Scripts/webkitpy/style/checkers/test_expectations.py:
887         (TestExpectationsChecker._determine_port_from_exepectations_path):
888
889 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
890
891         [chromium] move Tools.gyp, switch build-webkit --chromium to All.gyp
892         https://bugs.webkit.org/show_bug.cgi?id=76505
893
894         Reviewed by Tony Chang.
895
896         Update chromium build script to use All.gyp instead of WebKit.gyp
897
898         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Renamed from Source/WebKit/chromium/Tools.gyp.
899         * Scripts/webkitdirs.pm:
900
901 2012-01-18  Sam Weinig  <sam@webkit.org>
902
903         Don’t hardcode the path to ‘make‘.
904
905         Reviewed by Dan Bernstein.
906
907         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
908
909 2012-01-18  Joshua Bell  <jsbell@chromium.org>
910
911         Adding myself to committers.py
912         https://bugs.webkit.org/show_bug.cgi?id=76569
913
914         Unreviewed.
915
916         * Scripts/webkitpy/common/config/committers.py:
917
918 2012-01-18  Adam Barth  <abarth@webkit.org>
919
920         Up the cap on test failures tolerated by the EWS so the mac-ews can run to completion
921         https://bugs.webkit.org/show_bug.cgi?id=76567
922
923         Reviewed by Eric Seidel.
924
925         Current the AppleMac port has slightly more failures than we allow on
926         the EWS, causing the mac-ews to spin.  This patch ups the limit a bit,
927         which should hopefully let the mac-ews run to completion.  Once
928         AppleMac has fewer failures, we can lower the cap again.
929
930         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
931         (LayoutTestResultsReaderTest.test_layout_test_results):
932         * Scripts/webkitpy/tool/steps/runtests.py:
933         (RunTests):
934         * Scripts/webkitpy/tool/steps/steps_unittest.py:
935
936 2012-01-18  Eric Carlson  <eric.carlson@apple.com>
937
938         Provide access to user's list of preferred languages
939         https://bugs.webkit.org/show_bug.cgi?id=76138
940
941         Reviewed by Alexey Proskuryakov.
942
943         * GNUmakefile.am: Add JSInternalsCustom.cpp.
944
945 2012-01-18  Adam Barth  <abarth@webkit.org>
946
947         Add Chromium Linux GPU 32 to the list of allowed Chromium Linux
948         configurations.
949
950         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
951         (ChromiumLinuxPort.__init__):
952
953 2012-01-18  Dominic Mazzoni  <dmazzoni@google.com>
954
955         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
956         https://bugs.webkit.org/show_bug.cgi?id=73460
957
958         Reviewed by Chris Fleizach.
959
960         * DumpRenderTree/AccessibilityUIElement.h:
961         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
962         (AccessibilityUIElement::AccessibilityUIElement):
963         (AccessibilityUIElement::scrollToMakeVisibleCallback):
964         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
965         (AccessibilityUIElement::scrollToGlobalPointCallback):
966         * DumpRenderTree/chromium/AccessibilityUIElement.h:
967         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
968         (AccessibilityUIElement::scrollToMakeVisible):
969         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
970         (AccessibilityUIElement::scrollToGlobalPoint):
971         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
972         (AccessibilityUIElement::scrollToMakeVisible):
973         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
974         (AccessibilityUIElement::scrollToGlobalPoint):
975         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
976         (AccessibilityUIElement::scrollToMakeVisible):
977         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
978         (AccessibilityUIElement::scrollToGlobalPoint):
979
980 2012-01-17  Enrica Casucci  <enrica@apple.com>
981
982         Missing NSForegroundColorAttributeName should be treated as black instead of transparent.
983         https://bugs.webkit.org/show_bug.cgi?id=76490
984         <rdar://problem/9460733>
985
986         Added TestWebKitAPI test.
987         
988         Reviewed by Dan Bernstein.
989
990         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new test file.
991         * TestWebKitAPI/Tests/mac/InspectorBar.mm: Added test that calls
992         changeAttributes to the WebView.
993         
994 2012-01-18  Balazs Kelemen  <kbalazs@webkit.org>
995
996         [Qt] Consolidate layout test crash logging
997         https://bugs.webkit.org/show_bug.cgi?id=75088
998
999         Reviewed by Simon Hausmann.
1000
1001         Move backtrace generating logic into WTFReportBacktrace
1002         and add a way to deinstall signal handlers if we know
1003         that we have already printed the backtrace.
1004
1005         * DumpRenderTree/qt/main.cpp:
1006         (crashHandler):
1007         (setupSignalHandlers):
1008         (WTFCrashHook):
1009         (main):
1010         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
1011         (WTR::crashHandler):
1012         (WTR::setupSignalHandlers):
1013         (WTR::crashHook):
1014         (WTR::InjectedBundle::platformInitialize):
1015
1016 2012-01-18  Ilya Tikhonovsky  <loislo@chromium.org>
1017
1018         Unreviewed build fix after r105256.
1019
1020         There was a cyclic dependency between self._port and self._host assigments.
1021
1022         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1023         (PerfTestsRunner.__init__):
1024
1025 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1026
1027         Add new watchlist rule for the Qt build system
1028
1029         Reviewed by Simon Hausmann.
1030
1031         * Scripts/webkitpy/common/config/watchlist:
1032
1033 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1034
1035         [Qt] Move OTHER_FILES from WebKit.pro to Tools.pro
1036
1037         Reviewed by Simon Hausmann.
1038
1039         * Tools.pro:
1040
1041 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1042
1043         [Qt] Allow building only a subset of the WebKit sub-projects
1044
1045         Fixes build-jsc, broken in r104825.
1046
1047         We no longer need the intermediate buildQMakeQtProject(), as we're the
1048         only port using qmake, and buildQMakeProject is now highly Qt specific.
1049
1050         <http://webkit.org/b/76179>
1051
1052         Reviewed by Simon Hausmann.
1053
1054         * Scripts/build-jsc:
1055         * Scripts/build-webkit:
1056         * Scripts/webkitdirs.pm:
1057         (buildQMakeProjects):
1058
1059 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
1060
1061         run-perf-tests should generate a json file that summaries the result
1062         https://bugs.webkit.org/show_bug.cgi?id=76504
1063
1064         Reviewed by Adam Barth.
1065
1066         Add an ability to generate a json file to run-perf-test in the preparation for perf bots.
1067         New option --outout-json-path specifies the json file's path, and --source-json-path specifies
1068         another json file to be merged into the generated json file.
1069
1070         Also fixed a bug that --build wasn't set by default.
1071
1072         * Scripts/webkitpy/layout_tests/port/test.py:
1073         (TestPort.webkit_base):
1074         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1075         (PerfTestsRunner.__init__):
1076         (PerfTestsRunner):
1077         (PerfTestsRunner._parse_args):
1078         (PerfTestsRunner.run):
1079         (PerfTestsRunner._generate_json_if_specified):
1080         (PerfTestsRunner._process_chromium_style_test_result):
1081         (PerfTestsRunner._process_parser_test_result):
1082         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1083         (MainTest):
1084         (create_runner):
1085         (test_run_test_set):
1086         (test_run_test_set_for_parser_tests):
1087         (test_run_test_set_with_summary_json):
1088         (test_collect_tests):
1089         (test_parse_args):
1090
1091 2012-01-17  Sheriff Bot  <webkit.review.bot@gmail.com>
1092
1093         Unreviewed, rolling out r105244.
1094         http://trac.webkit.org/changeset/105244
1095         https://bugs.webkit.org/show_bug.cgi?id=76518
1096
1097         broke Chromium Mac (Requested by rolandsteiner on #webkit).
1098
1099         * DumpRenderTree/AccessibilityUIElement.h:
1100         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1101         (AccessibilityUIElement::AccessibilityUIElement):
1102         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1103         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1104         (AccessibilityUIElement::removeSelection):
1105         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1106         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1107         (AccessibilityUIElement::removeSelection):
1108
1109 2012-01-17  Dominic Mazzoni  <dmazzoni@google.com>
1110
1111         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
1112         https://bugs.webkit.org/show_bug.cgi?id=73460
1113
1114         Reviewed by Chris Fleizach.
1115
1116         * DumpRenderTree/AccessibilityUIElement.h:
1117         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1118         (AccessibilityUIElement::AccessibilityUIElement):
1119         (AccessibilityUIElement::scrollToMakeVisibleCallback):
1120         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
1121         (AccessibilityUIElement::scrollToGlobalPointCallback):
1122         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1123         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1124         (AccessibilityUIElement::scrollToMakeVisible):
1125         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1126         (AccessibilityUIElement::scrollToGlobalPoint):
1127         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1128         (AccessibilityUIElement::scrollToMakeVisible):
1129         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1130         (AccessibilityUIElement::scrollToGlobalPoint):
1131         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1132         (AccessibilityUIElement::scrollToMakeVisible):
1133         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1134         (AccessibilityUIElement::scrollToGlobalPoint):
1135
1136 2012-01-17  Adam Barth  <abarth@webkit.org>
1137
1138         Enable tests on the mac-ews
1139         https://bugs.webkit.org/show_bug.cgi?id=76502
1140
1141         Reviewed by Simon Fraser.
1142
1143         Apple now has five machines running the mac-ews.  Lucas Forschler has
1144         asked that we try enabling tests to see if we have enough bandwidth.
1145
1146         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1147         (MacEWS):
1148
1149 2012-01-17  Sanjoy Das  <sanjoy@playingwithpointers.com>
1150
1151         Add a check-webkit-style exception for GDBInterface.cpp
1152         https://bugs.webkit.org/show_bug.cgi?id=76187
1153
1154         Add an exception for Source/JavaScriptCore/jit/GDBInterface.cpp so
1155         that it does not fail the style check.
1156
1157         Reviewed by Martin Robinson.
1158
1159         * Scripts/webkitpy/style/checker.py: Tell the style checker to not run
1160         readability/naming tests on
1161         Source/JavaScriptCore/jit/GDBInterface.cpp.
1162         * Scripts/webkitpy/style/checker_unittest.py:
1163         (GlobalVariablesTest.test_path_rules_specifier): Add a test for
1164         the above exception.
1165
1166 2012-01-17  Hajime Morrita  <morrita@chromium.org>
1167
1168         https://bugs.webkit.org/show_bug.cgi?id=76245
1169         [Mac][DRT] should allow query string for the file URL.
1170
1171         Reviewed by Tony Chang.
1172
1173         Taught DRT about file:// as a url instead of a file path.
1174         We are now able to use a path file:///foo/bar.html?baz as a url
1175         with which DRT opens "/foo/bar.html" with "baz" as a query string.
1176
1177         * DumpRenderTree/mac/DumpRenderTree.mm:
1178         (runTest):
1179
1180 2012-01-17  Ojan Vafai  <ojan@chromium.org>
1181
1182         Check style on test_expectations.txt files before commit
1183         https://bugs.webkit.org/show_bug.cgi?id=76484
1184
1185         Reviewed by Adam Barth.
1186
1187         Unlike other style rules, if you get the syntax of the test_expectations.txt
1188         file wrong, the layout tests won't run. Also, this check is simple and only
1189         slows down committing if you actually modify one of the test_expectations.txt files.
1190
1191         * Scripts/webkitpy/tool/steps/commit.py:
1192         (Commit._check_test_expectations):
1193         (Commit.run):
1194         * Scripts/webkitpy/tool/steps/commit_unittest.py: Added.
1195         (CommitTest):
1196         (CommitTest.test_check_test_expectations):
1197
1198 2012-01-17  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
1199
1200         [Qt] Debug build fails with debug qt5
1201         https://bugs.webkit.org/show_bug.cgi?id=76463
1202
1203         Reviewed by Simon Hausmann.
1204
1205         Add QNetworkCookie include in order to satisfy sizeof in QTypeInfo in debug builds.
1206
1207         * QtTestBrowser/cookiejar.h:
1208
1209 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
1210
1211         webkitpy: fix json import on linux
1212         https://bugs.webkit.org/show_bug.cgi?id=76481
1213
1214         Reviewed by Adam Barth.
1215
1216         For some reason, the version of simplejson autoinstalled on my linux
1217         box seems to be broken. We should really only be using
1218         simplejson if json isn't available anyway, so this change looks
1219         for json first.
1220
1221         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1222         (JSONGeneratorTest.test_test_timings_trie):
1223
1224 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
1225
1226         Fix failures in test-webkitpy caused by r105177.
1227
1228         Unreviewed, build fix.
1229
1230         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1231         (ChromiumLinuxPort._determine_driver_path_statically):
1232         (ChromiumLinuxPort._static_build_path):
1233
1234 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
1235
1236         webkitpy: make PortFactory.get() be fully data-driven
1237         https://bugs.webkit.org/show_bug.cgi?id=76360
1238
1239         Reviewed by Eric Seidel.
1240
1241         Refactor PortFactory.get() to be fully data-driven.
1242
1243         * Scripts/webkitpy/layout_tests/port/factory.py:
1244         (PortFactory):
1245         (PortFactory._default_port):
1246         (PortFactory.get):
1247         (PortFactory.get.in):
1248         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1249         (FactoryTest.assert_port):
1250
1251 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
1252
1253         webkitpy: add determine_full_port_name(), clean up port.__init__()
1254         https://bugs.webkit.org/show_bug.cgi?id=76357
1255
1256         Reviewed by Adam Barth.
1257
1258         Each Port class is now required to implement a 'port_name' field
1259         that will match the start of all ports constructed by this class and
1260         a 'determine_full_port_name' field that will make the port
1261         fully-qualified.
1262
1263         * Scripts/webkitpy/layout_tests/port/apple.py:
1264         (ApplePort.__init__):
1265         * Scripts/webkitpy/layout_tests/port/base.py:
1266         (Port):
1267         (Port.determine_port_name):
1268         (Port.__init__):
1269         * Scripts/webkitpy/layout_tests/port/chromium.py:
1270         (ChromiumPort.for):
1271         (ChromiumPort.__init__):
1272         (ChromiumPort):
1273         (ChromiumPort._chromium_base_dir):
1274         (ChromiumPort.path_from_chromium_base):
1275         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1276         (ChromiumGpuLinuxPort):
1277         (ChromiumGpuLinuxPort.__init__):
1278         (ChromiumGpuMacPort):
1279         (ChromiumGpuMacPort.__init__):
1280         (ChromiumGpuWinPort):
1281         (ChromiumGpuWinPort.__init__):
1282         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1283         (ChromiumLinuxPort):
1284         (ChromiumLinuxPort.determine_port_name):
1285         (ChromiumLinuxPort.__init__):
1286         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1287         (ChromiumMacPort):
1288         (ChromiumMacPort.determine_port_name):
1289         (ChromiumMacPort.__init__):
1290         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1291         (ChromiumWinPort):
1292         (ChromiumWinPort.determine_port_name):
1293         (ChromiumWinPort.__init__):
1294         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1295         (DryRunPort):
1296         (DryRunPort.determine_port_name):
1297         (DryRunPort.__init__):
1298         * Scripts/webkitpy/layout_tests/port/efl.py:
1299         (EflPort):
1300         * Scripts/webkitpy/layout_tests/port/factory.py:
1301         (PortFactory):
1302         (PortFactory._default_port):
1303         (PortFactory.get):
1304         (PortFactory.get.in):
1305         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1306         (FactoryTest.assert_port):
1307         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1308         (GoogleChromeLinux32Port):
1309         (GoogleChromeLinux32Port.determine_port_name):
1310         (GoogleChromeLinux64Port):
1311         (GoogleChromeLinux64Port.determine_port_name):
1312         (GoogleChromeMacPort):
1313         (GoogleChromeMacPort.determine_port_name):
1314         (GoogleChromeWinPort):
1315         (GoogleChromeWinPort.determine_port_name):
1316         * Scripts/webkitpy/layout_tests/port/gtk.py:
1317         (GtkPort):
1318         * Scripts/webkitpy/layout_tests/port/mac.py:
1319         (MacPort):
1320         (MacPort.determine_port_name):
1321         (MacPort.__init__):
1322         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1323         (test_versions):
1324         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1325         (MockDRTPort):
1326         (MockDRTPort.determine_port_name):
1327         (MockDRTPort.__init__):
1328         (MockDRT):
1329         (MockDRT.determine_port_name):
1330         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1331         (PortTestCase.make_port):
1332         * Scripts/webkitpy/layout_tests/port/qt.py:
1333         (QtPort):
1334         (QtPort.determine_port_name):
1335         (QtPort.__init__):
1336         * Scripts/webkitpy/layout_tests/port/test.py:
1337         (TestPort):
1338         (TestPort.determine_port_name):
1339         (TestPort.__init__):
1340         * Scripts/webkitpy/layout_tests/port/webkit.py:
1341         (WebKitPort.__init__):
1342         * Scripts/webkitpy/layout_tests/port/win.py:
1343         (WinPort):
1344         (WinPort.determine_port_name):
1345         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1346         (get_test_baselines.AllPlatformsPort.__init__):
1347         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
1348         (get_test_config.TestMacPort):
1349         (get_test_config):
1350
1351 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
1352
1353         webkitpy: clean up port code in preparation for static port names
1354         https://bugs.webkit.org/show_bug.cgi?id=76356
1355
1356         Reviewed by Adam Barth.
1357
1358         To fix bug 76215 and be able to determine appropriate port names
1359         in webkitpy without actually constructing Port objects, we need
1360         to shuffle some logic in the chromium ports to be able to figure
1361         out whether we built DRT in 32 or 64-bit mode.
1362
1363         * Scripts/webkitpy/layout_tests/port/chromium.py:
1364         (ChromiumPort):
1365         (ChromiumPort._chromium_base_dir):
1366         (ChromiumPort.__init__):
1367         (ChromiumPort.path_from_chromium_base):
1368         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1369         (ChromiumLinuxPort):
1370         (ChromiumLinuxPort._determine_driver_path_statically):
1371         (ChromiumLinuxPort._static_build_path):
1372         (ChromiumLinuxPort._determine_architecture):
1373         (ChromiumLinuxPort.__init__):
1374         (ChromiumLinuxPort._build_path):
1375
1376 2012-01-17  Hao Zheng  <zhenghao@chromium.org>
1377
1378         Do not remove pixel failures for ref tests.
1379         https://bugs.webkit.org/show_bug.cgi?id=76243
1380
1381         Reviewed by Tony Chang.
1382
1383         'NRWT --no-pixel-tests' complains when reftests are expected to
1384         be image mismatch.
1385
1386         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1387         (Manager._update_summary_with_result):
1388         * Scripts/webkitpy/layout_tests/models/test_failures.py:
1389         (is_reftest_failure):
1390         (determine_result_type):
1391
1392 2012-01-17  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
1393
1394         REGRESSION(r81225): ORWT should ignore reftests
1395         https://bugs.webkit.org/show_bug.cgi?id=67936
1396
1397         Reviewed by Csaba Osztrogonác.
1398
1399         * Scripts/old-run-webkit-tests:
1400         (isUsedInReftest): $filename should be the first parameter
1401         (findTestsToRun): run test if it isn't reftest
1402
1403 2012-01-17  Gustavo Noronha Silva  <gns@gnome.org>
1404
1405         Unreviewed. Fix python unit test I broke with r105142
1406
1407         * Scripts/webkitpy/common/config/ports_unittest.py:
1408         (WebKitPortTest.test_gtk_port):
1409
1410 2012-01-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1411
1412         [Qt] Don't set the 'primary' flag when mocking touch-points in MiniBrowser
1413
1414         Qt 5 no longer has that flag.
1415
1416         Reviewed by Simon Hausmann.
1417
1418         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1419         (MiniBrowserApplication::notify):
1420
1421 2012-01-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1422
1423         GTK+ EWS needs to run update-webkitgtk-libs after applying a patch
1424         https://bugs.webkit.org/show_bug.cgi?id=75857
1425
1426         Reviewed by Adam Barth.
1427
1428         * Scripts/webkitdirs.pm:
1429         (buildAutotoolsProject): move cleaning the build to happen early,
1430         and handle --update-gtk right after that
1431         * Scripts/webkitpy/common/config/ports.py:
1432         (GtkPort.build_webkit_command): pass --update-gtk as an option to
1433         build-webkit, so that it is used in the EWS
1434
1435 2012-01-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1436
1437         [Qt] Don't add _debug postfix to targets when building debug only
1438
1439         Reviewed by Simon Hausmann.
1440
1441         * qmake/mkspecs/features/default_post.prf:
1442         * qmake/mkspecs/features/functions.prf:
1443
1444 2012-01-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1445
1446         [Qt] Add more files to project-files for easier navigation in Qt Creator
1447
1448         Reviewed by Simon Hausmann.
1449
1450         * Tools.pro:
1451         * qmake/config.tests/README: Added.
1452
1453 2012-01-17  Philippe Normand  <pnormand@igalia.com>
1454
1455         [GTK] fast/dom/constructed-objects-prototypes.html fails
1456         https://bugs.webkit.org/show_bug.cgi?id=75432
1457
1458         Reviewed by Martin Robinson.
1459
1460         * Scripts/build-webkit: Enable video-track in GTK.
1461
1462 2012-01-16  Takashi Toyoshima  <toyoshim@chromium.org>
1463
1464         Add toyoshim as a committer.
1465         https://bugs.webkit.org/show_bug.cgi?id=76390
1466
1467         Reviewed by Hajime Morita.
1468
1469         * Scripts/webkitpy/common/config/committers.py:
1470
1471 2012-01-16  Brent Fulgham  <bfulgham@webkit.org>
1472
1473         [WinCairo] Build fix after r104155. Several debug targets were not
1474         properly including the '*Common' property sheets.
1475
1476         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops:
1477         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops:
1478         * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops:
1479         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops:
1480         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops:
1481
1482 2012-01-16  Csaba Osztrogonác  <ossy@webkit.org>
1483
1484         REGRESSION(r105072): It broke committers_unittest.py
1485         https://bugs.webkit.org/show_bug.cgi?id=76396
1486
1487         Reviewed by Adam Barth.
1488
1489         * Scripts/webkitpy/common/config/committers_unittest.py:
1490         (CommittersTest._assert_fuzz_match): It should handle more names.
1491         (CommittersTest.test_contributors_by_fuzzy_match_with_legacy_names): Fix the testcase.
1492
1493 2012-01-16  Mario Sanchez Prada  <msanchez@igalia.com>
1494
1495         [GTK] Include gtk+3 in the jhbuild modules
1496         https://bugs.webkit.org/show_bug.cgi?id=76284
1497
1498         Reviewed by Philippe Normand.
1499
1500         * gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
1501
1502 2012-01-16  Dan Winship  <danw@gnome.org>
1503
1504         Add myself as a committer
1505
1506         Unreviewed
1507
1508         * Scripts/webkitpy/common/config/committers.py:
1509
1510 2012-01-16  Raphael Kubo da Costa  <kubo@profusion.mobi>
1511
1512         Unreviewed; fix the build when --as-needed and --no-copy-dt-needed-entries are passed to the linker.
1513
1514         Some recent versions of a few Linux distributions have started passing
1515         --as-needed and --no-copy-dt-needed-entries by default to the linker,
1516         which broke the build when SHARED_CORE was turned on, as libwtf_efl.so
1517         needed a few symbols from libjavascriptcore_efl.so.
1518
1519         * DumpRenderTree/efl/CMakeLists.txt: Explicitly pass WTF_LIBRARY_NAME
1520         before JavaScriptCore_LIBRARY_NAME in DumpRenderTree_LIBRARIES so the
1521         libraries are searched in the right order by the linker.
1522
1523 2012-01-16  Philippe Normand  <pnormand@igalia.com>
1524
1525         [GTK] set audio resources path in NRTW
1526         https://bugs.webkit.org/show_bug.cgi?id=76380
1527
1528         Reviewed by Martin Robinson.
1529
1530         * Scripts/webkitpy/layout_tests/port/gtk.py:
1531         (GtkPort.setup_environ_for_server): Set $AUDIO_RESOURCES_PATH so
1532         the uninstalled audio resources are used during webaudio tests.
1533
1534 2012-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1535
1536         [GTK] ldflags and cflags should take precedence over the existing flags in gtkdoc.py
1537         https://bugs.webkit.org/show_bug.cgi?id=76369
1538
1539         Reviewed by Xan Lopez.
1540
1541         If there's an installed version of webkit and there are new
1542         symbols in the build tree, gtkdoc-scanobj fails due to undefined
1543         references, because the env ldflags are given before the local
1544         ones.
1545
1546         * gtk/gtkdoc.py:
1547         (GTKDoc._run_gtkdoc_scangobj):
1548
1549 2012-01-15  Pablo Flouret  <pablof@motorola.com>
1550
1551         Fix compilation errors on build-webkit --debug --no-video on mac.
1552         https://bugs.webkit.org/show_bug.cgi?id=75867
1553
1554         Reviewed by Philippe Normand.
1555
1556         Add --[no-]video-track to build-webkit, since video track feature
1557         depends on video.
1558
1559         * Scripts/build-webkit:
1560
1561 2012-01-14  James Robinson  <jamesr@chromium.org>
1562
1563         [chromium] Failing webkit_unit_tests does not make the cr-linux EWS bubble red
1564         https://bugs.webkit.org/show_bug.cgi?id=76313
1565
1566         Reviewed by Adam Barth.
1567
1568         The exit code of this script should be the exit code of webkit_unit_tests. Tested manually.
1569
1570         * Scripts/run-chromium-webkit-unit-tests:
1571
1572 2012-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1573
1574         Unreviewed, rolling out r105017.
1575         http://trac.webkit.org/changeset/105017
1576         https://bugs.webkit.org/show_bug.cgi?id=76333
1577
1578         broke the build (Requested by philn-tp on #webkit).
1579
1580         * gtk/jhbuild.modules:
1581
1582 2012-01-14  Mario Sanchez Prada  <msanchez@igalia.com>
1583
1584         [GTK] Include gtk+3 in the jhbuild modules
1585         https://bugs.webkit.org/show_bug.cgi?id=76284
1586
1587         Reviewed by Philippe Normand.
1588
1589         * gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
1590
1591 2012-01-13  Adam Barth  <abarth@webkit.org>
1592
1593         Remove --dry-run support from webkit-patch
1594         https://bugs.webkit.org/show_bug.cgi?id=76300
1595
1596         Reviewed by Dirk Pranke.
1597
1598         This is the rest of the patch from Bug 76300.  I landed it separtely
1599         because main.py had some stray conflict markers that I needed to clean
1600         up first.
1601
1602         * Scripts/webkitpy/test/main.py:
1603         (Tester.parse_args):
1604         (Tester._run_tests):
1605
1606 2012-01-13  Adam Barth  <abarth@webkit.org>
1607
1608         test-webkitpy does not run
1609         https://bugs.webkit.org/show_bug.cgi?id=76318
1610
1611         Unreviewed.
1612
1613         Looks like some conflict markers got left in the file.
1614
1615         * Scripts/webkitpy/test/main.py:
1616         (Tester.run):
1617
1618 2012-01-13  Adam Barth  <abarth@webkit.org>
1619
1620         Remove --dry-run support from webkit-patch
1621         https://bugs.webkit.org/show_bug.cgi?id=76300
1622
1623         Reviewed by Dirk Pranke.
1624
1625         We don't use this functionality for anything, and it doesn't really
1626         work.  Someone in #webkit tried using it and and got sad/confused.  We
1627         should just remove it.
1628
1629         * Scripts/webkitpy/common/checkout/scm/git.py:
1630         (Git.push_local_commits_to_server):
1631         * Scripts/webkitpy/common/checkout/scm/scm.py:
1632         (SCM.__init__):
1633         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1634         (_shared_test_commit_with_message):
1635         (GitSVNTest.test_commit_text_parsing):
1636         * Scripts/webkitpy/common/checkout/scm/svn.py:
1637         (SVN.commit_with_message):
1638         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1639         (Bugzilla.__init__):
1640         (Bugzilla.quips):
1641         (Bugzilla.authenticate):
1642         (Bugzilla.add_attachment_to_bug):
1643         (Bugzilla.add_patch_to_bug):
1644         (Bugzilla.create_bug):
1645         (Bugzilla.clear_attachment_flags):
1646         (Bugzilla.set_flag_on_attachment):
1647         (Bugzilla.obsolete_attachment):
1648         (Bugzilla.add_cc_to_bug):
1649         (Bugzilla.post_comment_to_bug):
1650         (Bugzilla.close_bug_as_fixed):
1651         (Bugzilla.reassign_bug):
1652         (reopen_bug):
1653         * Scripts/webkitpy/test/main.py:
1654         (Tester.parse_args):
1655         (Tester.run_tests):
1656
1657 2012-01-13  David Levin  <levin@chromium.org>
1658
1659         check-webkit-style: should encourage the use of Own* classes for Windows DC.
1660         https://bugs.webkit.org/show_bug.cgi?id=76227
1661
1662         Reviewed by Dirk Pranke.
1663
1664         * Scripts/webkitpy/style/checkers/cpp.py:
1665         (check_for_leaky_patterns): The new check.
1666         (process_line): Added a call to the new check.
1667         (CppChecker): Added the new error type.
1668         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1669         (CppStyleTestBase):
1670         (CppStyleTestBase.perform_leaky_pattern_check):
1671         The check for only leaky pattern errors.
1672         (LeakyPatternTest): Test cases.
1673
1674 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
1675
1676         test-webkitpy: clean up handling of test directories, QueueStatusServer
1677         https://bugs.webkit.org/show_bug.cgi?id=76238
1678
1679         Reviewed by Adam Barth.
1680
1681         This patch cleans up a bunch of hacks related to how we find all
1682         of the python unit tests and set up the sys.path variable in
1683         test-webkitpy.
1684
1685         This patch changes how test-webkitpy works slightly in that we
1686         will now look for test files under Tools/Scripts and Source/WebKit2/Scripts
1687         rather than just Tools/Scripts/webkitpy and Source/WebKit2/Scripts/webkit.
1688         This greatly simplifies the mapping of paths to module names and
1689         appears to have no significant performance impact or other drawbacks.
1690
1691         There are other ways that we could remove all of the hacks and
1692         still have a more flexible mapping of paths to module names, but
1693         the ones I've thought of so far add a decent amount of complexity to
1694         the implementation and don't seem to buy us much.
1695         
1696         * QueueStatusServer/__init__.py:
1697         * Scripts/test-webkitpy:
1698         * Scripts/webkitpy/test/main.py:
1699         (Tester._modules_from_paths):
1700         (Tester._is_module):
1701
1702 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
1703
1704         test-webkitpy: should support classes and individual test names as well as modules
1705         https://bugs.webkit.org/show_bug.cgi?id=76233
1706
1707         Reviewed by Adam Barth.
1708
1709         The default unittest.main() supports a list of individual
1710         TestCase classes or individual tests as well as modules. This
1711         change adds support for the same to test-webkitpy, so now you
1712         can say
1713
1714           % test-wekbitpy webkitpy.test.cat_unittest.CatTest
1715
1716         and
1717
1718           % test-wekbitpy webkitpy.test.cat_unittest.CatTest.test_basic
1719
1720         in addition to
1721
1722           % test-wekbitpy webkitpy.test.cat_unittest
1723
1724         * Scripts/test-webkitpy:
1725         * Scripts/webkitpy/test/cat_unittest.py:
1726         * Scripts/webkitpy/test/main.py:
1727         (Tester.parse_args):
1728         (Tester.run):
1729         (Tester):
1730         (Tester._find_modules):
1731         (Tester._exclude):
1732         (Tester._run_tests):
1733         (Tester._is_module):
1734         (Tester._log_exception):
1735
1736 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
1737
1738         test-webkitpy: add basic code coverage support
1739         https://bugs.webkit.org/show_bug.cgi?id=76201
1740
1741         Reviewed by Adam Barth.
1742
1743         This test adds basic code coverage support to test-webkitpy; if
1744         you pass the -c flag, we will generate a new coverage file. We
1745         can start simply with this and add more features as necessary.
1746
1747         This patch requires coverage to be already installed on the
1748         machine. I am not auto-installing this for now.
1749
1750         * Scripts/webkitpy/test/main.py:
1751         (Tester.parse_args):
1752         (Tester.run_tests):
1753
1754 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
1755
1756         StatusBubbleTest.test_build_bubble is failing
1757         https://bugs.webkit.org/show_bug.cgi?id=76222
1758
1759         Reviewed by Adam Barth.
1760
1761         * QueueStatusServer/handlers/statusbubble_unittest.py:
1762         (StatusBubbleTest.test_build_bubble):
1763
1764 2012-01-13  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1765
1766         nrwt should use multiple http shards
1767         https://bugs.webkit.org/show_bug.cgi?id=75958
1768
1769         Add --max-locked-shards option to the nrwt for manual set
1770         the maximum number of the locked shards
1771
1772         Reviewed by Dirk Pranke.
1773
1774         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1775         (Manager._max_locked_shards):
1776         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1777         (ShardingTests.get_shards):
1778         (ShardingTests.test_multiple_locked_shards):
1779         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1780         (parse_args):
1781
1782 2012-01-13  Raphael Kubo da Costa  <kubo@profusion.mobi>
1783
1784         prepare-ChangeLog: Look for a text editor in a few more variables.
1785         https://bugs.webkit.org/show_bug.cgi?id=76289
1786
1787         Reviewed by Ryosuke Niwa.
1788
1789         A text editor was looked for only in the CHANGE_LOG_EDITOR and
1790         CHANGE_LOG_EDIT_APPLICATION environment variables before falling back
1791         to the OS X-specific open(1) command.
1792
1793         As there does not seem to be a common way of looking for a text editor
1794         among the scripts in Tools/Scripts right now, just look at $VISUAL and
1795         $EDITOR (set much more often than the other variables in Unix systems)
1796         before falling back to open(1).
1797
1798         * Scripts/prepare-ChangeLog:
1799         (openChangeLogs):
1800
1801 2012-01-13  Gabor Rapcsanyi  <rgabor@webkit.org>
1802
1803         [GTK] gtkdoc.py ignoring LDFLAGS and CFLAGS environment variables
1804         https://bugs.webkit.org/show_bug.cgi?id=76269
1805
1806         Reviewed by Martin Robinson.
1807
1808         * gtk/gtkdoc.py:
1809         (GTKDoc._run_gtkdoc_scangobj):
1810
1811 2012-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1812
1813         [Qt][WK2]REGRESSION(r104881):It broke hundreds of tests
1814         https://bugs.webkit.org/show_bug.cgi?id=76247
1815
1816         Reviewed by Kenneth Rohde Christiansen.
1817
1818         * WebKitTestRunner/TestController.cpp:
1819         (WTR::TestController::resetStateToConsistentValues): Disable mock scrollbars on Qt by default. (workaround)
1820
1821 2012-01-13  Hajime Morrita  <morrita@chromium.org>
1822
1823         [Mac][DRT] Should support --no-timeout
1824         https://bugs.webkit.org/show_bug.cgi?id=76242
1825
1826         Reviewed by Darin Adler.
1827
1828         * DumpRenderTree/mac/DumpRenderTree.mm:
1829         (initializeGlobalsFromCommandLineOptions): Added "--no-timeout" to the options list.
1830         (setWaitToDumpWatchdog): Added to encapsulate the waitToDumpWatchdog global variable.
1831         (shouldSetWaitToDumpWatchdog): Added to check the useTimeoutWatchdog flag set by the option.
1832         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1833         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1834         (LayoutTestController::setWaitToDump): Now calls shouldSetWaitToDumpWatchdog() to check the flag.
1835
1836 2012-01-12  Simon Fraser  <simon.fraser@apple.com>
1837
1838         Mitigate scrollbar differences when running pixel tests
1839         https://bugs.webkit.org/show_bug.cgi?id=67217
1840
1841         Reviewed by Dan Bernstein.
1842         
1843         Enable mock scrollbars by default for tests.
1844
1845         * DumpRenderTree/mac/DumpRenderTree.mm:
1846         (resetDefaultsToConsistentValues):
1847         * WebKitTestRunner/TestController.cpp:
1848         (WTR::TestController::resetStateToConsistentValues):
1849
1850 2012-01-12  Ryosuke Niwa  <rniwa@webkit.org>
1851
1852         Need a script to run tests in PerformanceTests
1853         https://bugs.webkit.org/show_bug.cgi?id=76132
1854
1855         Reviewed by Adam Barth.
1856
1857         Add run-perf-tests to run performance tests using parser/resources/runner.js.
1858         Unfortunately, there isn't an easy way of telling which test uses which format
1859         so hard-code directory that uses Chromium perf-bot style (only inspector perf. tests for now).
1860
1861         All test outputs are re-formatted to match Chromium perf-bot style.
1862
1863         * Scripts/run-inspector-perf-tests.py:
1864         * Scripts/run-perf-tests: Added.
1865         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1866         (PerfTestsRunner):
1867         (PerfTestsRunner.__init__):
1868         (PerfTestsRunner._collect_tests):
1869         (PerfTestsRunner.run):
1870         (PerfTestsRunner._print_status):
1871         (PerfTestsRunner._run_tests_set):
1872         (PerfTestsRunner._process_chromium_style_test_result):
1873         (PerfTestsRunner._should_ignore_line_in_parser_test_result):
1874         (PerfTestsRunner._process_parser_test_result):
1875         (PerfTestsRunner._run_single_test):
1876         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1877         (MainTest.TestDriver.run_test):
1878         (create_runner):
1879         (run_test):
1880         (test_run_test_set):
1881         (test_run_test_set_for_parser_tests):
1882         (test_collect_tests):
1883
1884 2012-01-12  Dirk Pranke  <dpranke@chromium.org>
1885
1886         webkitpy: clean up port unit tests in preparation for making port_name mandatory
1887         https://bugs.webkit.org/show_bug.cgi?id=76123
1888
1889         Reviewed by Adam Barth.
1890
1891         This change updates the unit tests to be more consistent in how
1892         ports are created, in preparation for making port_name a
1893         mandatory parameter to the constructor and removing any version
1894         interpretation from it.
1895
1896         There should be no functional changes in this patch, but some
1897         tests that are no longer relevant have been removed or reworked.
1898
1899         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1900         (PortTest.test_get_option__default):
1901         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1902         (ChromiumLinuxPortTest):
1903         (ChromiumLinuxPortTest.assert_architecture):
1904         (ChromiumLinuxPortTest.test_determine_architecture_fails):
1905         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1906         (ChromiumMacPortTest):
1907         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1908         (ChromiumPortTest):
1909         (ChromiumPortTest.test_all_test_configurations):
1910         (ChromiumPortTest.TestMacPort.__init__):
1911         (ChromiumPortTest.TestLinuxPort.__init__):
1912         (ChromiumPortTest.TestWinPort.__init__):
1913         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1914         (ChromiumWinTest):
1915         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
1916         (EflPortTest):
1917         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1918         (GtkPortTest):
1919         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1920         (MacTest):
1921         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1922         (MockDRTPortTest):
1923         (MockDRTPortTest.make_port):
1924         * Scripts/webkitpy/layout_tests/port/qt.py:
1925         (QtPort._port_flag_for_scripts):
1926         (QtPort.__init__):
1927         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1928         (QtPortTest):
1929         (QtPortTest._assert_search_path):
1930         (QtPortTest.test_baseline_search_path):
1931         (QtPortTest.test_operating_system):
1932         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1933         (WebKitPortTest):
1934         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1935         (WinPortTest):
1936         (WinPortTest._assert_search_path):
1937         (WinPortTest.test_baseline_search_path):
1938         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
1939         (get_test_config.TestMacPort.__init__):
1940
1941 2012-01-12  Dirk Pranke  <dpranke@chromium.org>
1942
1943         test-webkitpy: clean up logging and provide a real --help message
1944         https://bugs.webkit.org/show_bug.cgi?id=76142
1945
1946         Reviewed by Adam Barth.
1947
1948         This test is mostly more refactoring - it calls objects in
1949         unittest directly instead of routing through unittest.main() --
1950         in order to gain more control over the logging and to provide a
1951         correct --help message. This will also give us a better
1952         foundation for adding more feautures down the road.
1953
1954         This patch adds different levels of logging controlled by the
1955         '-s', '-q', and '-v' options (see --help for details), and
1956         removes the --verbose-logging option.
1957
1958         * Scripts/test-webkitpy:
1959         * Scripts/webkitpy/test/main.py:
1960         (Tester):
1961         (Tester.clean_packages):
1962         (Tester.__init__):
1963         (Tester.parse_args):
1964         (Tester.configure):
1965         (Tester._configure_logging):
1966         (Tester.find_modules):
1967         (Tester._exclude):
1968         (Tester._modules_from_paths):
1969         (Tester.run_tests):
1970
1971 2012-01-12  Simon Hausmann  <simon.hausmann@nokia.com>
1972
1973         Make the new WTF module build on Qt
1974         https://bugs.webkit.org/show_bug.cgi?id=76163
1975
1976         Reviewed by Tor Arne Vestbø.
1977
1978         * qmake/mkspecs/modules/wtf.prf: Pull in WTF from the new location.
1979
1980 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
1981
1982         Unreviewed, mac DumpRenderTree fix.
1983
1984         * DumpRenderTree/mac/UIDelegate.mm:
1985         (-[UIDelegate webView:addMessageToConsole:withSource:]):
1986
1987 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
1988
1989         WebKitTestRunner should not print console message line number when it is equal to zero.
1990         https://bugs.webkit.org/show_bug.cgi?id=76167
1991
1992         Reviewed by Csaba Osztrogonác.
1993
1994         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1995         (WTR::InjectedBundlePage::willAddMessageToConsole):
1996
1997 2012-01-11  Vsevolod Vlasov  <vsevik@chromium.org>
1998
1999         Make default console messages line numbers consistent.
2000         https://bugs.webkit.org/show_bug.cgi?id=74075
2001
2002         Reviewed by Pavel Feldman.
2003
2004         Unset line numbers are not printed to console now.
2005         Added Source/WebCore/inspector to efl DumpRenderTree include path.
2006
2007         * DumpRenderTree/chromium/WebViewHost.cpp:
2008         (WebViewHost::didAddMessageToConsole):
2009         * DumpRenderTree/efl/CMakeLists.txt:
2010         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2011         (onConsoleMessage):
2012         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2013         (webViewConsoleMessage):
2014         * DumpRenderTree/mac/UIDelegate.mm:
2015         (-[UIDelegate webView:addMessageToConsole:withSource:]):
2016         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2017         (WebCore::WebPage::javaScriptConsoleMessage):
2018         * DumpRenderTree/win/UIDelegate.cpp:
2019         (UIDelegate::webViewAddMessageToConsole):
2020         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
2021         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
2022
2023 2012-01-10  Dirk Pranke  <dpranke@chromium.org>
2024
2025         test-webkitpy: push more logic into webkitpy.test.main, clean up code
2026         https://bugs.webkit.org/show_bug.cgi?id=76021
2027
2028         Reviewed by Eric Seidel.
2029
2030         I plan to add more functionality to test-webkitpy, but it is
2031         difficult to hack on now; this patch is the first of two that
2032         brings test-webkitpy more inline with current coding style by
2033         pushing more logic into the webkitpy.test.main.Tester class (so
2034         that it will be testable itself).
2035         
2036         There should be no functional changes in this patch.
2037
2038         * Scripts/test-webkitpy:
2039         (_path_from_webkit_root):
2040         * Scripts/webkitpy/test/main.py:
2041         (Tester):
2042         (Tester.init):
2043         (Tester.configure_logging):
2044         (Tester.configure_logging.filter):
2045         (Tester.clean_packages):
2046         (Tester.run_tests):
2047
2048 2012-01-11  Wei Jia  <wjia@chromium.org>
2049
2050         implement layout tests for <video> with media stream
2051         https://bugs.webkit.org/show_bug.cgi?id=74882
2052
2053         Reviewed by Kent Tamura.
2054
2055         * DumpRenderTree/DumpRenderTree.gypi:
2056         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp: Added.
2057         (WebKit::WebUserMediaClientMock::create):
2058         (WebKit::WebUserMediaClientMock::IsMockStream):
2059         (WebKit::WebUserMediaClientMock::requestUserMedia):
2060         (WebKit::WebUserMediaClientMock::cancelUserMediaRequest):
2061         * DumpRenderTree/chromium/WebUserMediaClientMock.h: Added.
2062         (WebKit::WebUserMediaClientMock::~WebUserMediaClientMock):
2063         (WebKit::WebUserMediaClientMock::WebUserMediaClientMock):
2064         * DumpRenderTree/chromium/WebViewHost.cpp:
2065         (WebViewHost::userMediaClient):
2066         (WebViewHost::userMediaClientMock):
2067         (WebViewHost::createMediaPlayer):
2068         (WebViewHost::mediaStreamUtil):
2069         (WebViewHost::testMediaStreamClient):
2070         * DumpRenderTree/chromium/WebViewHost.h:
2071
2072 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
2073
2074         Unreviewed, build fix.
2075
2076         Fix chromium-win's version remapping to work correctly on Win 7 SP1.
2077
2078         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2079         (ChromiumWinPort.__init__):
2080
2081 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
2082
2083         Sheriffbot build fix. Don't emit empty lines on IRC.
2084
2085         * Scripts/webkitpy/tool/bot/irc_command.py:
2086         (LastGreenRevision.execute):
2087
2088 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
2089
2090         last-green-revision should report the revision that succeeded on all bots
2091         https://bugs.webkit.org/show_bug.cgi?id=76109
2092
2093         Reviewed by Adam Barth.
2094
2095         Add an algorithm to find the last known good revision among the specified bots. For a revision to be
2096         considered green by this algorithm, all matching builders must have a successful run at the revision
2097         or two consecutive successful runs before and after the revision.
2098
2099         Also fixed a bug in irc_command that the result wasn't posted on IRC properly and a bug in queries.py
2100         that resulted in an exception when the user didn't pass BUILDER_NAME argument.
2101
2102         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2103         (BuildBot._revisions_for_builder):
2104         (BuildBot):
2105         (BuildBot._find_green_revision):
2106         (BuildBot.last_green_revision):
2107         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
2108         (MockBuildBot.last_green_revision):
2109         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2110         (test_revisions_for_builder):
2111         (test_find_green_revision):
2112         (test_last_green_revision):
2113         * Scripts/webkitpy/tool/bot/irc_command.py:
2114         (LastGreenRevision.execute):
2115         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2116         (SheriffIRCBotTest.test_lgr):
2117         * Scripts/webkitpy/tool/commands/queries.py:
2118         (LastGreenRevision):
2119
2120 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
2121
2122         Unreviewed, fix build bustage on win32 introduced by r104725.
2123
2124         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2125         (MockDRTPortTest.make_port):
2126         (MockChromiumDRTTest.test_pixeltest__fails):
2127
2128 2012-01-11  Jochen Eisinger  <jochen@chromium.org>
2129
2130         [Chromium] mimic the (old) behavior of the mac port for (re)setting the color profile
2131         https://bugs.webkit.org/show_bug.cgi?id=75618
2132
2133         Eventually, we should get away from setting the display's color profile, as the mac port is doing now.
2134
2135         Reviewed by Tony Chang.
2136
2137         * DumpRenderTree/chromium/LayoutTestHelper.mm:
2138         (installLayoutTestColorProfile):
2139         (restoreUserColorProfile):
2140         (main):
2141
2142 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
2143
2144         test-webkitpy: fix -v and eliminate some spurious warnings
2145         https://bugs.webkit.org/show_bug.cgi?id=76099
2146
2147         Reviewed by Adam Barth.
2148
2149         when we added support for --xml output, we broke the -v flag.
2150
2151         Also, fix the code to swallow a harmless warning from
2152         VCSUtils.pm and fix a deprecated warning in jsonchecker.py.
2153
2154         test-webkitpy is now silent again except for the one known
2155         logging issue.
2156
2157         * Scripts/webkitpy/common/checkout/checkout.py:
2158         (Checkout.commit_message_for_this_commit):
2159         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2160         (test_commit_message_for_this_commit):
2161         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2162         (JSONChecker.check):
2163         (JSONChecker.line_number_from_json_exception):
2164         * Scripts/webkitpy/test/main.py:
2165         (Tester.run_tests):
2166
2167 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
2168
2169         webkitpy: webkitpy.layout_tests.port tests should only use MockSystemHost, not MockHost
2170         https://bugs.webkit.org/show_bug.cgi?id=76084
2171
2172         Reviewed by Adam Barth.
2173
2174         This will help make it easier to catch layering violations. This
2175         change just refactors test code; there are no changes to
2176         production code.
2177
2178         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2179         (PortTest.make_port):
2180         (PortTest.test_find_no_paths_specified):
2181         (PortTest.test_find_one_test):
2182         (PortTest.test_find_glob):
2183         (PortTest.test_find_with_skipped_directories):
2184         (PortTest.test_find_with_skipped_directories_2):
2185         (PortTest.test_parse_reftest_list):
2186         (PortTest.test_httpd_returns_error_code):
2187         (PortTest.test_virtual_methods):
2188         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2189         (ChromiumGpuTest.assert_port_works):
2190         (ChromiumGpuTest._assert_baseline_path):
2191         (ChromiumGpuTest.test_graphics_type):
2192         (ChromiumGpuTest.test_default_tests_paths.test_paths):
2193         (ChromiumGpuTest.test_test_files):
2194         (ChromiumGpuTest.test_test_files.test_paths):
2195         (ChromiumGpuTest):
2196         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2197         (ChromiumLinuxPortTest.assert_architecture):
2198         (ChromiumLinuxPortTest.test_check_illegal_port_names):
2199         (ChromiumLinuxPortTest.test_determine_architecture_fails):
2200         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
2201         (DriverTest.make_port):
2202         (DriverTest):
2203         (DriverTest.assertVirtual):
2204         (DriverTest._assert_wrapper):
2205         (DriverTest.test_virtual_driver_methods):
2206         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2207         (MockDRTPortTest.make_port):
2208         (MockDRTPortTest.test_port_name_in_constructor):
2209         (MockDRTTest.assertTest):
2210         (MockDRTTest.test_main):
2211         (MockChromiumDRTTest.test_pixeltest__fails):
2212         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2213         (QtPortTest._assert_search_path):
2214         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2215         (TestWebKitPort.__init__):
2216         (WebKitPortUnitTests.test_default_options):
2217         (test_runtime_feature_list):
2218         (test_test_expectations):
2219
2220 2012-01-11  Ojan Vafai  <ojan@chromium.org>
2221
2222         Style skipped tests in the flakiness dashboard
2223         https://bugs.webkit.org/show_bug.cgi?id=76091
2224
2225         Reviewed by Tony Chang.
2226
2227         * TestResultServer/static-dashboards/dashboard_base.js:
2228         Removed "FLAKY" from this list since we don't ever mark individual runs
2229         as flaky. Also deleted an outdated line.
2230         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2231
2232 2012-01-11  Ojan Vafai  <ojan@chromium.org>
2233
2234         Remove gtest normalization code from the test results server
2235         https://bugs.webkit.org/show_bug.cgi?id=76089
2236
2237         Reviewed by Tony Chang.
2238
2239         The normalization now happens on the gtest side.
2240
2241         * TestResultServer/model/jsonresults.py:
2242         (JsonResults.merge):
2243         * TestResultServer/model/jsonresults_unittest.py:
2244         (JsonResultsTest.test_gtest):
2245
2246 2012-01-11  Ojan Vafai  <ojan@chromium.org>
2247
2248         Be more aggressive about deleting unnecessary results from the test-results-server json files
2249         https://bugs.webkit.org/show_bug.cgi?id=76086
2250
2251         Reviewed by Tony Chang.
2252
2253         Remove any tests that only contain skip/pass/nodata values whose runtime
2254         is less than 5 seconds.
2255
2256         * TestResultServer/model/jsonresults.py:
2257         (JsonResults._normalize_results_json):
2258         * TestResultServer/model/jsonresults_unittest.py:
2259         (JsonResultsTest.test_merge_remove_test):
2260         (JsonResultsTest.test_merge_keep_test_with_all_pass_but_slow_time):
2261
2262 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
2263
2264         last-green-revision should give us per-bot information
2265         https://bugs.webkit.org/show_bug.cgi?id=76011
2266
2267         Reviewed by Adam Barth.
2268
2269         Rewrote last-green-revision command. Instead of finding a revision for which all bots succeeded,
2270         we report the latest green run on each bot from the last 100 runs.
2271
2272         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2273         (BuildBot._fetch_builder_page):
2274         (BuildBot):
2275         (BuildBot._green_revision_for_builder):
2276         (BuildBot.last_green_revision):
2277         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2278         (test_green_revision_for_builder):
2279         (test_last_green_revision):
2280         * Scripts/webkitpy/tool/bot/irc_command.py:
2281         (LastGreenRevision.execute):
2282         * Scripts/webkitpy/tool/commands/queries.py:
2283         (LastGreenRevision.execute):
2284
2285 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
2286
2287         webkitpy: clean up version detection in webkitpy.layout_tests.port
2288         https://bugs.webkit.org/show_bug.cgi?id=76016
2289
2290         Reviewed by Adam Barth.
2291
2292         This change updates the code in webkitpy.layout_tests.port to
2293         use the new os_name and os_version fields on host.platform. This
2294         gets layout_tests.port out of the version parsing business. Most
2295         of the diffs are just cleaning up test code to accomodate the
2296         changes.
2297
2298         * Scripts/webkitpy/common/system/executive_mock.py:
2299         (MockExecutive):
2300         (MockExecutive.ignore_error):
2301         (MockExecutive2):
2302         (MockExecutive2.ignore_error):
2303         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2304         (MockPlatformInfo.is_mac):
2305         (MockPlatformInfo.is_linux):
2306         (MockPlatformInfo.is_win):
2307         * Scripts/webkitpy/common/system/systemhost_mock.py:
2308         (MockSystemHost.__init__):
2309         * Scripts/webkitpy/layout_tests/port/apple.py:
2310         (ApplePort.__init__):
2311         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2312         (ChromiumMacPort.__init__):
2313         (ChromiumMacPort.check_wdiff):
2314         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2315         (ChromiumMacPortTest):
2316         (ChromiumMacPortTest.assert_name):
2317         (ChromiumMacPortTest.test_versions):
2318         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2319         (ChromiumPortTest.test_all_test_configurations):
2320         (ChromiumPortTest.TestMacPort.__init__):
2321         (ChromiumPortTest.TestLinuxPort.__init__):
2322         (ChromiumPortTest.TestWinPort.__init__):
2323         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2324         (ChromiumWinPort.__init__):
2325         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2326         (ChromiumWinTest):
2327         (ChromiumWinTest.assert_name):
2328         (ChromiumWinTest.test_versions):
2329         (ChromiumWinTest.test_baseline_path):
2330         (ChromiumWinTest.test_build_path):
2331         * Scripts/webkitpy/layout_tests/port/factory.py:
2332         (PortFactory._port_name_from_arguments_and_options):
2333         (PortFactory.get):
2334         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2335         (FactoryTest):
2336         (FactoryTest.setUp):
2337         (FactoryTest.assert_port):
2338         (FactoryTest.test_mac):
2339         (FactoryTest.test_win):
2340         (FactoryTest.test_google_chrome):
2341         (FactoryTest.test_gtk):
2342         (FactoryTest.test_qt):
2343         (FactoryTest.test_chromium_gpu):
2344         (FactoryTest.test_chromium_gpu_linux):
2345         (FactoryTest.test_chromium_gpu_mac):
2346         (FactoryTest.test_chromium_gpu_win):
2347         (FactoryTest.test_chromium_mac):
2348         (FactoryTest.test_chromium_linux):
2349         (FactoryTest.test_chromium_win):
2350         (FactoryTest.test_unknown_specified):
2351         (FactoryTest.test_unknown_default):
2352         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2353         (TestGoogleChromePort):
2354         (TestGoogleChromePort._verify_baseline_path):
2355         (TestGoogleChromePort._verify_expectations_overrides):
2356         (TestGoogleChromePort.test_get_google_chrome_port):
2357         * Scripts/webkitpy/layout_tests/port/mac.py:
2358         (MacPort):
2359         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2360         (MacTest):
2361         (assert_name):
2362         (test_tests_for_other_platforms):
2363         (test_version):
2364         (test_versions):
2365         (test_is_version_methods):
2366         (test_setup_environ_for_server):
2367         (_assert_search_path):
2368         (test_show_results_html_file):
2369         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2370         (PortTestCase):
2371         (PortTestCase.make_port):
2372         * Scripts/webkitpy/layout_tests/port/win.py:
2373         (WinPort):
2374         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2375         (WinPortTest):
2376         (WinPortTest.test_show_results_html_file):
2377         (WinPortTest._assert_search_path):
2378         (WinPortTest._assert_version):
2379
2380 2012-01-11  Hugo Parente Lima  <hugo.lima@openbossa.org>
2381
2382         [Qt][WK2] Remove workaround introduced into bug 75470
2383         https://bugs.webkit.org/show_bug.cgi?id=75889
2384
2385         Reviewed by Tor Arne Vestbø.
2386
2387         * MiniBrowser/qt/qml/BrowserWindow.qml:
2388
2389 2012-01-10  Dmitry Lomov  <dslomov@google.com>
2390
2391         [Chromium] Remove obsolete references to WebWorker class.
2392         https://bugs.webkit.org/show_bug.cgi?id=76020
2393
2394         Reviewed by David Levin.
2395
2396         * DumpRenderTree/chromium/TestWebWorker.h: Removed.
2397         * DumpRenderTree/chromium/WebViewHost.cpp:
2398         * DumpRenderTree/chromium/WebViewHost.h:
2399
2400 2012-01-11  Csaba Osztrogonác  <ossy@webkit.org>
2401
2402         [Qt] Some css3 filter tests are failing after r104698
2403         https://bugs.webkit.org/show_bug.cgi?id=76055
2404
2405         Reviewed by Simon Hausmann.
2406
2407         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2408         (LayoutTestController::overridePreference): Add WebKitAcceleratedCompositingEnabled preference.
2409
2410 2012-01-11  Tony Chang  <tony@chromium.org>
2411
2412         Don't remove 0 byte files when running build-webkit --chromium
2413         https://bugs.webkit.org/show_bug.cgi?id=75997
2414
2415         Reviewed by Csaba Osztrogonác.
2416
2417         If QTDIR is set, isQt() is true even when running build-webkit --chromium.
2418
2419         * Scripts/webkitdirs.pm:
2420         (determineIsQt):
2421
2422 2012-01-10  David Kilzer  <ddkilzer@apple.com>
2423
2424         Add TestWebKitAPI tests for KURL
2425         <http://webkit.org/b/75774>
2426
2427         Reviewed by Adam Barth.
2428
2429         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add a
2430         WebCore folder and KURL.cpp source file to the project.
2431         * TestWebKitAPI/Tests/WebCore/KURL.cpp: Added.
2432         (TestWebKitAPI::WebCore::SetUp): Initialize the main thread
2433         during setup since this test doesn't go through WebKit or
2434         WebKit2.
2435         (TestWebKitAPI::TEST_F): Add two basic tests.
2436
2437 2012-01-10  David Kilzer  <ddkilzer@apple.com>
2438
2439         Extract common code for comparing WTF::String objects into WTFStringUtilities.h
2440
2441         Reviewed by Adam Barth.
2442
2443         Needed for: <http://webkit.org/b/75774> Add TestWebKitAPI tests for KURL
2444
2445         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
2446         WTFStringUtilities.h to the project.
2447         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Update to use
2448         WTFStringUtilities.h.
2449         * TestWebKitAPI/WTFStringUtilities.h: Added.
2450         (WTF::operator<<):
2451
2452 2012-01-10  Vincent Scheib  <scheib@chromium.org>
2453
2454         Clarify run-webkit-tests options reset-results and new-baseline
2455         https://bugs.webkit.org/show_bug.cgi?id=75993
2456
2457         Reviewed by Dirk Pranke.
2458
2459         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2460         (parse_args):
2461
2462 2012-01-10  Simon Fraser  <simon.fraser@apple.com>
2463
2464         Disabled mock scrollbars should draw differently
2465         https://bugs.webkit.org/show_bug.cgi?id=75995
2466
2467         Reviewed by James Robinson.
2468
2469         When the scrollbar is disabled, paint the entire track of
2470         mock scrollbars with a lighter gray, and hide the thumb.
2471
2472         * DumpRenderTree/mac/DumpRenderTree.mm:
2473         (-[DRTMockScroller drawKnob]):
2474         (-[DRTMockScroller drawRect:]):
2475
2476 2012-01-10  James Robinson  <jamesr@chromium.org>
2477
2478         [chromium] Run webkit_unit_tests as part of webkit-patch build-and-test
2479         https://bugs.webkit.org/show_bug.cgi?id=75988
2480
2481         Reviewed by Adam Barth.
2482
2483         * Scripts/webkitpy/common/config/ports.py:
2484         (WebKitPort.run_webkit_unit_tests_command):
2485         (WebKitPort):
2486         (ChromiumPort.run_webkit_unit_tests_command):
2487         (ChromiumPort):
2488         * Scripts/webkitpy/common/config/ports_mock.py:
2489         (MockPort.run_webkit_unit_tests_command):
2490         * Scripts/webkitpy/tool/commands/download_unittest.py:
2491         (DownloadCommandsTest.test_build_and_test):
2492         (test_land):
2493         (test_land_red_builders):
2494         * Scripts/webkitpy/tool/steps/runtests.py:
2495         (RunTests.run):
2496         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2497
2498 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
2499
2500         webkitpy: add os_name, os_version to platforminfo
2501         https://bugs.webkit.org/show_bug.cgi?id=75931
2502
2503         Reviewed by Eric Siedel.
2504
2505         As a first step in cleaning up the version parsing logic in
2506         webkitpy.layout_tests.port, this adds common routines for
2507         getting the os_name and os_version fields to the PlatformInfo
2508         class. Nothing uses them yet but I've added FIXME's to some of
2509         the code that needs to be deleted in the port files.
2510
2511         * Scripts/webkitpy/common/system/platforminfo.py:
2512         (PlatformInfo.__init__):
2513         (PlatformInfo):
2514         (PlatformInfo._determine_os_name):
2515         (PlatformInfo._determine_mac_version):
2516         (PlatformInfo._determine_linux_version):
2517         (PlatformInfo._determine_win_version):
2518         (PlatformInfo.display_name):
2519         (PlatformInfo.total_bytes_memory):
2520         (PlatformInfo._compute_bytes_from_vm_stat_output):
2521         (PlatformInfo.free_bytes_memory):
2522         * Scripts/webkitpy/common/system/platforminfo_unittest.py: Added.
2523         (TestPlatformInfo):
2524         (TestPlatformInfo.make_info):
2525         (TestPlatformInfo.make_info.mock_run_command):
2526         (TestPlatformInfo.setUp):
2527         (TestPlatformInfo.tearDown):
2528         (TestPlatformInfo.test_basic):
2529         (TestPlatformInfo.integration_test_basic):
2530         (TestPlatformInfo.test_display_name_mac):
2531         (TestPlatformInfo.test_display_name_win32):
2532         (TestPlatformInfo.test_memory_mac):
2533         (TestPlatformInfo.test_memory_win32):
2534         (TestPlatformInfo.test_determine_os_name):
2535         (TestPlatformInfo.test_determine_mac_version):
2536         (TestPlatformInfo.test_determine_linux_version):
2537         (TestPlatformInfo.test_determine_win_version_from_tuple):
2538         (TestPlatformInfo.test_determine_win_version_from_cmd):
2539         * Scripts/webkitpy/layout_tests/port/apple.py:
2540         (ApplePort.__init__):
2541         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2542         (ChromiumMacPort.__init__):
2543         * Scripts/webkitpy/layout_tests/port/mac.py:
2544         (MacPort):
2545         * Scripts/webkitpy/layout_tests/port/win.py:
2546         (WinPort):
2547
2548 2012-01-10  Adam Roben  <aroben@apple.com>
2549
2550         Make it possible to type data: URLs into MiniBrowser on Windows
2551
2552         Fixes <http://webkit.org/b/75084> Crash when trying to navigate to a data: URL in
2553         MiniBrowser on Windows
2554
2555         Reviewed by Darin Adler.
2556
2557         * MiniBrowser/win/BrowserWindow.cpp:
2558         (BrowserWindow::handleMessage): Instead of checking for an "http://" prefix when deciding
2559         whether to prepend "http://", just look for whether the typed URL contains a colon. If it
2560         does, we assume it already has a scheme and don't modify it.
2561
2562 2012-01-10  Adam Roben  <aroben@apple.com>
2563
2564         Make MiniBrowser automatically escape invalid URL characters typed in its URL field
2565
2566         Fixes <http://webkit.org/b/75086> Crash when typing a data: URL containing double-quotes in
2567         MiniBrowser on Windows
2568
2569         Reviewed by Darin Adler.
2570
2571         * MiniBrowser/win/BrowserView.cpp:
2572         (BrowserView::goToURL): Pass the typed string through
2573         CFURLCreateStringByAddingPercentEscapes before trying to create a URL from it.
2574
2575 2012-01-10  Ben Wells  <benwells@chromium.org>
2576
2577         Adding myself (benwells) to committers.py
2578         https://bugs.webkit.org/show_bug.cgi?id=75971
2579
2580         Reviewed by Ojan Vafai.
2581
2582         * Scripts/webkitpy/common/config/committers.py:
2583
2584 2012-01-10  Mario Sanchez Prada  <msanchez@igalia.com>
2585
2586         AX: support helpText() in DumpRenderTree
2587         https://bugs.webkit.org/show_bug.cgi?id=40193
2588
2589         Reviewed by Chris Fleizach.
2590
2591         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2592         (AccessibilityUIElement::helpText): Implemented.
2593
2594 2012-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2595
2596         Unreviewed, rolling out r104572.
2597         http://trac.webkit.org/changeset/104572
2598         https://bugs.webkit.org/show_bug.cgi?id=75967
2599
2600         It broke zillion tests (Requested by Ossy on #webkit).
2601
2602         * DumpRenderTree/qt/EventSenderQt.cpp:
2603         (EventSender::EventSender):
2604         (EventSender::sendOrQueueEvent):
2605         (EventSender::replaySavedEvents):
2606         (EventSender::eventFilter):
2607         * DumpRenderTree/qt/EventSenderQt.h:
2608
2609 2012-01-10  Hugo Parente Lima  <hugo.lima@openbossa.org>
2610
2611         [Qt] fast/events/dont-loose-last-event test fails on WK1
2612         https://bugs.webkit.org/show_bug.cgi?id=73894
2613
2614         Reviewed by Simon Hausmann.
2615
2616         Empty the entire event queue when requested besides using
2617         sendEvent instead of postEvent to make sure all events were
2618         delivered.
2619         This commit also removes not working DRT code to handle drag and drop,
2620         for more refs see: https://bugs.webkit.org/show_bug.cgi?id=31332
2621
2622         * DumpRenderTree/qt/EventSenderQt.cpp:
2623         (EventSender::EventSender):
2624         (EventSender::sendOrQueueEvent):
2625         (EventSender::replaySavedEvents):
2626         * DumpRenderTree/qt/EventSenderQt.h:
2627
2628 2012-01-10  No'am Rosenthal  <noam.rosenthal@nokia.com>
2629
2630         [Qt] Enable CSS_FILTERS in Qt build
2631         https://bugs.webkit.org/show_bug.cgi?id=75777
2632
2633         Add the CSS_FILTERS feature flag to Qt.
2634
2635         Reviewed by Kenneth Rohde Christiansen.
2636
2637         * qmake/mkspecs/features/features.prf:
2638
2639 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
2640
2641         [Qt] Unreviewed -Werror build fix.
2642
2643         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2644         (MiniBrowserApplication::MiniBrowserApplication): Re-order initialization to match
2645         declaration.
2646
2647 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
2648
2649         [Qt] Remove dependency to uitools
2650         https://bugs.webkit.org/show_bug.cgi?id=75952
2651
2652         Reviewed by Tor Arne Vestbø.
2653
2654         QUiLoader is used for creating QLabel/QProgressBar widgets for
2655         a layout test, to verify some widget embedding feature. Unfortunately
2656         in Qt 5, QUiLoader is part of qttools, which depends on webkit, which
2657         depends on qttools. Since we don't really _need_ QUiLoader for our tests,
2658         let's break the circular dependency.
2659
2660         * DumpRenderTree/qt/DumpRenderTree.pro:
2661         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2662         (WebCore::WebPage::createPlugin):
2663         * QtTestBrowser/QtTestBrowser.pro:
2664         * QtTestBrowser/launcherwindow.h:
2665         * QtTestBrowser/webpage.cpp:
2666         (WebPage::createPlugin):
2667         * qmake/mkspecs/features/minimal_qt.prf:
2668         * qmake/mkspecs/features/uitools.prf: Removed.
2669
2670 2012-01-10  Alexander Færøy  <alexander.faeroy@nokia.com>
2671
2672         [Qt] Don't expose m_windowOptions as part of the public interface in MiniBrowserApplication
2673         https://bugs.webkit.org/show_bug.cgi?id=75894
2674
2675         Reviewed by Tor Arne Vestbø.
2676
2677         * MiniBrowser/qt/MiniBrowserApplication.h:
2678         (MiniBrowserApplication::windowOptions):
2679         * MiniBrowser/qt/main.cpp:
2680         (main):
2681
2682 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
2683
2684         [Qt] DRT crashes with Qt 5
2685         https://bugs.webkit.org/show_bug.cgi?id=75951
2686
2687         Reviewed by Ossy.
2688
2689         * DumpRenderTree/qt/fonts.conf: Add missing last-resort font fallback for Qt 5 where
2690         Qt relies on font-config to define the default font family.
2691
2692 2012-01-10  Csaba Osztrogonác  <ossy@webkit.org>
2693
2694         [Qt] REGRESSION(r100130): Clean build feature is broken.
2695         https://bugs.webkit.org/show_bug.cgi?id=75863
2696
2697         Reviewed by Tor Arne Vestbø.
2698
2699         * Scripts/webkitdirs.pm:
2700         (buildQMakeProject):
2701
2702 2012-01-10  Zeno Albisser  <zeno@webkit.org>
2703
2704         [Qt][WK2] Fix keyboard shortcuts in MiniBrowser.
2705         https://bugs.webkit.org/show_bug.cgi?id=75885
2706
2707         In QML events are propagated through parents. But since the
2708         WebView may consume key events, a shortcut might never reach
2709         the top QtQuickItem.
2710         Therefore an application wide event handling function in C++
2711         needs to take care of shortcuts for MiniBrowser.
2712
2713         Reviewed by Kenneth Rohde Christiansen.
2714
2715         * MiniBrowser/qt/BrowserWindow.cpp:
2716         (BrowserWindow::reload):
2717         (BrowserWindow::focusAddressBar):
2718         * MiniBrowser/qt/BrowserWindow.h:
2719         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2720         (MiniBrowserApplication::notify):
2721         * MiniBrowser/qt/qml/BrowserWindow.qml:
2722
2723 2012-01-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2724
2725         Add --efl alias for --platform=efl to run-webkit-test
2726         https://bugs.webkit.org/show_bug.cgi?id=75937
2727
2728         Reviewed by Andreas Kling.
2729         
2730         * Scripts/run-webkit-tests: Add --efl alias.
2731         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --efl alias.
2732         (parse_args):
2733
2734 2012-01-09  Dan Bernstein  <mitz@apple.com>
2735
2736         -[DOMRange renderedImageForcingBlackText:] fails with non-user-selectable text
2737         https://bugs.webkit.org/show_bug.cgi?id=75920
2738
2739         Reviewed by Darin Adler.
2740
2741         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
2742         (TestWebKitAPI::TEST): Added a test for a range in a
2743         -webkit-user-select: none; block.
2744
2745 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
2746
2747         webkitpy.layout_tests.port.mock_drt_unittest.MockChromiumDRTTest has been failing on cr-win
2748         https://bugs.webkit.org/show_bug.cgi?id=75884
2749
2750         Reviewed by Ryosuke Niwa.
2751
2752         Fix regression introduced (revealed?) in r104340. Chromium file         
2753         url syntax is different on win32 and the test results weren't           
2754         expecting that.                                                         
2755
2756         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2757         (TestExpectations._report_errors):
2758         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2759         (test_parse_error_nonfatal):
2760         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2761         (MockDRTTest.input_line):
2762         (MockChromiumDRTTest.test_pixeltest__fails):
2763         * Scripts/webkitpy/layout_tests/port/test.py:
2764         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2765         (TestRebaseliner.make_rebaseliner):
2766         (TestRebaseliner.test_one_platform):
2767         (TestRebaseliner.test_all_platforms):
2768         (TestRebaseliner.test_png_file_with_comment):
2769         (TestRebaseliner.test_png_file_with_comment_remove_old_checksum):
2770         (TestRebaseliner.test_png_file_with_comment_as_duplicate):
2771         (TestRealMain.test_all_platforms):
2772
2773 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
2774
2775         Fix regression in test-webkitpy introduced by removing the webkitpy/python24 directory.
2776
2777         Unreviewed, build fix.
2778
2779         test-webkitpy had a built-in self-test routine to verify that
2780         deleting the .pyc files worked correctly. When I removed the
2781         python24 directory in r104482, I broke the self-test.
2782
2783         I have deleted the self-test for now. Since I am reworking
2784         test-webkitpy I will make sure the new version is adequately
2785         tested.
2786
2787         * Scripts/test-webkitpy:
2788         (configure_logging):
2789         (_clean_pyc_files):
2790         (_clean_packages):
2791         (init):
2792
2793 2012-01-09  Justin Novosad  <junov@chromium.org>
2794
2795         [Chromium] remove all references to the legacy accelerated 2d Canvas
2796         implementation
2797         https://bugs.webkit.org/show_bug.cgi?id=75108
2798
2799         Purging an old settings flag that is no longer referenced
2800
2801         Reviewed by Darin Fisher.
2802
2803         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2804         (main):
2805         * DumpRenderTree/chromium/TestShell.cpp:
2806         (TestShell::TestShell):
2807         (TestShell::resetWebSettings):
2808         * DumpRenderTree/chromium/TestShell.h:
2809         (TestShell::setAccelerated2dCanvasEnabled):
2810         * DumpRenderTree/chromium/WebPreferences.cpp:
2811         (WebPreferences::reset):
2812         (WebPreferences::applyTo):
2813         * DumpRenderTree/chromium/WebPreferences.h:
2814
2815 2012-01-09  Adam Roben  <aroben@apple.com>
2816
2817         Convert Cygwin paths to Windows paths before passing them to DRT
2818
2819         Fixes <http://webkit.org/b/64468> <rdar://problem/10663409> WIN: DumpRenderTree hangs under
2820         NRWT
2821
2822         I couldn't find a way to test this because I couldn't figure out how to override the
2823         cygpath function as it is used by WebKitDriver.
2824
2825         Reviewed by Dirk Pranke.
2826
2827         * Scripts/webkitpy/layout_tests/port/webkit.py:
2828         (WebKitDriver._command_from_driver_input): On Cygwin, convert the test's path to a
2829         Windows-style path before passing it to DRT.
2830
2831 2012-01-06  Dirk Pranke  <dpranke@chromium.org>
2832
2833         webkitpy: revamp version checking
2834         https://bugs.webkit.org/show_bug.cgi?id=75765
2835
2836         Reviewed by Adam Barth.
2837
2838         The version-checking code in webkitpy/python24/versioning seems really
2839         awkward and overdesigned, especially since we don't support python 2.4
2840         any more.
2841
2842         In addition, I am tired of getting warnings about Python 2.6 being "a
2843         newer release than what is supported" :).
2844
2845         I'm taking a page from the depot_tools python code and just creating a
2846         new webkitpy.common.version_check module that will print a message on
2847         stderr and call sys.exit() if we're running an unsupported version.
2848
2849         * Scripts/check-webkit-style:
2850         * Scripts/new-run-webkit-httpd:
2851         * Scripts/new-run-webkit-tests:
2852         * Scripts/rebaseline-chromium-webkit-tests:
2853         * Scripts/test-webkitpy:
2854         (configure_logging):
2855         (init):
2856         * Scripts/webkit-patch:
2857         (main):
2858         * Scripts/webkitpy/common/system/executive.py:
2859         (Executive._child_process_encoding):
2860         (Executive._should_encode_child_process_arguments):
2861         * Scripts/webkitpy/common/version_check.py: Copied from Tools/Scripts/rebaseline-chromium-webkit-tests.
2862         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2863         * Scripts/webkitpy/python24/__init__.py: Removed.
2864         * Scripts/webkitpy/python24/versioning.py: Removed.
2865         * Scripts/webkitpy/python24/versioning_unittest.py: Removed.
2866
2867 2012-01-09  Adam Barth  <abarth@webkit.org>
2868
2869         Remove Chromium Mac CG from the flakiness dashboard
2870         https://bugs.webkit.org/show_bug.cgi?id=75873
2871
2872         Reviewed by Ojan Vafai.
2873
2874         This configuration no longer exists.
2875
2876         * TestResultServer/static-dashboards/builders.js:
2877         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2878         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2879         (testOverrideJustBuildType):
2880         (testPlatformAndBuildType):
2881
2882 2012-01-06  Adam Roben  <aroben@apple.com>
2883
2884         Print an error message when NRWT can't run Apache
2885
2886         Fixes <http://webkit.org/b/75712> NRWT mysteriously exits when Apache returns an error code
2887
2888         Reviewed by Dirk Pranke.
2889
2890         * Scripts/webkitpy/layout_tests/port/base.py:
2891         (Port.check_httpd): Print an error message when Apache returns an error code instead of
2892         failing silently.
2893
2894         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2895         (PortTest.test_check_httpd_success): Test that we don't print anything when we successfully
2896         run Apache.
2897         (PortTest.test_httpd_returns_error_code): Test that we print an error message when Apache
2898         fails.
2899
2900 2012-01-09  Gabor Rapcsanyi  <rgabor@webkit.org>
2901
2902         [Gtk][ARM] Cross compiler buildbot is failing after r103040
2903         https://bugs.webkit.org/show_bug.cgi?id=75846
2904
2905         Reviewed by Philippe Normand.
2906
2907         * Scripts/webkitdirs.pm:
2908         (runAutogenForAutotoolsProjectIfNecessary):
2909
2910 2012-01-09  Alexander Færøy  <ahf@0x90.dk>
2911
2912         [Qt] Add support for dynamically enabling and disabling touch mocking in the Qt MiniBrowser
2913         https://bugs.webkit.org/show_bug.cgi?id=75807
2914
2915         This patch adds a new icon to navigationbar of the Qt MiniBrowser
2916         which allows you to dynamically toggle whether touch mocking is
2917         enabled or disabled.
2918
2919         Reviewed by Tor Arne Vestbø.
2920
2921         * MiniBrowser/qt/MiniBrowser.qrc:
2922         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2923         (MiniBrowserApplication::notify):
2924         * MiniBrowser/qt/MiniBrowserApplication.h:
2925         (WindowOptions::WindowOptions):
2926         (WindowOptions::touchMockingEnabled):
2927         (WindowOptions::setTouchMockingEnabled):
2928         * MiniBrowser/qt/icons/touch.png: Added.
2929         * MiniBrowser/qt/qml/BrowserWindow.qml:
2930
2931 2012-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2932
2933         Unreviewed. Fix make distcheck issues.
2934
2935         * MiniBrowser/gtk/GNUmakefile.am:
2936
2937 2012-01-08  Sheriff Bot  <webkit.review.bot@gmail.com>
2938
2939         Unreviewed, rolling out r104421.
2940         http://trac.webkit.org/changeset/104421
2941         https://bugs.webkit.org/show_bug.cgi?id=75816
2942
2943         Need to rebaseline some tests on Linux (Requested by noamr on
2944         #webkit).
2945
2946         * qmake/mkspecs/features/features.prf:
2947
2948 2012-01-08  Adam Barth  <abarth@webkit.org>
2949
2950         Remove support for Chromium Mac CG from garden-o-matic
2951         https://bugs.webkit.org/show_bug.cgi?id=75814
2952
2953         Reviewed by Eric Seidel.
2954
2955         This configuration no longer exists.  This patch is mostly a matter of
2956         updating config.js and removing the examples from the unit tests.
2957
2958         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2959         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2960         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2961         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
2962         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2963
2964 2012-01-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
2965
2966         [Qt] Enable CSS_FILTERS in Qt build
2967         https://bugs.webkit.org/show_bug.cgi?id=75777
2968
2969         Add the CSS_FILTERS feature flag to Qt.
2970
2971         Reviewed by Kenneth Rohde Christiansen.
2972
2973         * qmake/mkspecs/features/features.prf:
2974
2975 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
2976
2977         Categorize bots by ports instead of core/non-core separation
2978         https://bugs.webkit.org/show_bug.cgi?id=75766
2979
2980         Reviewed by Eric Seidel.
2981
2982         Rename categorizes so as to preserve the original ordering of bots per Eric's suggestion
2983         (Chromium still comes before GTK and Qt).
2984
2985         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2986         (loadBuilderConfig):
2987         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2988
2989 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
2990
2991         Remove the concept of core builders from webkitpy
2992         https://bugs.webkit.org/show_bug.cgi?id=75809
2993
2994         Reviewed by Ryosuke Niwa.
2995
2996         Treat all bots equally since core/non-core sepration has been removed from build.webkit.org,
2997         and remove the relevant code.
2998
2999         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3000         (BuildBot.__init__):
3001         (BuildBot._matches_regexps):
3002         (BuildBot._builder_statuses_with_names_matching_regexps):
3003         (BuildBot.builder_statuses):
3004         (BuildBot.failure_map):
3005         (BuildBot._latest_builds_from_builders):
3006         (BuildBot.last_green_revision):
3007         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
3008         (MockBuildBot.builder_statuses):
3009         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3010         (test_status_parsing):
3011         (test_last_green_revision):
3012         (test_last_green_revision.mock_builds_from_builders):
3013
3014 2012-01-08  Adam Barth  <abarth@webkit.org>
3015
3016         Remove Chromium Mac CG concept from webkitpy
3017         https://bugs.webkit.org/show_bug.cgi?id=75810
3018
3019         Reviewed by Ryosuke Niwa.
3020
3021         This configuration no longer exists.  We can remove all the supporting
3022         code from webkitpy.
3023
3024         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3025         (BaselineOptimizerTest.test_move_baselines):
3026         (BaselineOptimizerTest.test_chromium_covers_mac_win_linux):
3027         (BaselineOptimizerTest.test_chromium_mac_redundant_with_apple_mac):
3028         (BaselineOptimizerTest.test_common_directory_includes_root):
3029         (BaselineOptimizerTest.test_complex_shadowing):
3030         * Scripts/webkitpy/common/config/build.py:
3031         (_should_file_trigger_build):
3032         * Scripts/webkitpy/common/config/build_unittest.py:
3033         (ShouldBuildTest):
3034         * Scripts/webkitpy/layout_tests/port/builders.py:
3035         * Scripts/webkitpy/layout_tests/port/chromium.py:
3036         (ChromiumPort):
3037         (ChromiumPort._generate_all_test_configurations):
3038         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3039         (_default_tests_paths):
3040         (ChromiumGpuLinuxPort.tests):
3041         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3042         (ChromiumGpuTest.integration_test_chromium_gpu_mac):
3043         (ChromiumGpuTest.assert_port_works):
3044         (ChromiumGpuTest.test_baseline_paths):
3045         (ChromiumGpuTest.test_graphics_type):
3046         (ChromiumGpuTest.test_default_tests_paths):
3047         (ChromiumGpuTest.test_test_files):
3048         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3049         (ChromiumMacPort):
3050         (ChromiumMacPort.__init__):
3051         (ChromiumMacPort.baseline_search_path):
3052         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3053         (ChromiumMacPortTest.test_graphics_type):
3054         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3055         (ChromiumPortTest.test_all_test_configurations):
3056         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3057         * Scripts/webkitpy/layout_tests/port/factory.py:
3058         (PortFactory._port_name_from_arguments_and_options):
3059         (PortFactory.get):
3060         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3061         (FactoryTest.test_chromium_gpu_mac):
3062         (FactoryTest.test_chromium_mac):
3063         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3064         (GetGoogleChromePortTest._verify_expectations_overrides):
3065         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3066         (MockChromiumDRTTest.test_chromium_parse_options):
3067         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3068         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
3069         (test_url_fetcher):
3070         (test_zip_factory):
3071         (test_archive):
3072         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3073         (TestRebaseline.test_rebaseline_expectations):
3074
3075 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
3076
3077         Categorize bots by ports instead of core/non-core separation
3078         https://bugs.webkit.org/show_bug.cgi?id=75766
3079
3080         Reviewed by Adam Barth.
3081
3082         Get rid of the concept of core/non-core builders, and categorize build bots by ports instead.
3083
3084         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3085         (loadBuilderConfig):
3086         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3087
3088 2012-01-08  Sheriff Bot  <webkit.review.bot@gmail.com>
3089
3090         Unreviewed, rolling out r104403.
3091         http://trac.webkit.org/changeset/104403
3092         https://bugs.webkit.org/show_bug.cgi?id=75803
3093
3094         It broke all tests on Qt5 (Requested by Ossy_weekend on
3095         #webkit).
3096
3097         * qmake/mkspecs/features/features.prf:
3098
3099 2012-01-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
3100
3101         [Qt] Enable CSS_FILTERS in Qt build
3102         https://bugs.webkit.org/show_bug.cgi?id=75777
3103
3104         Add the CSS_FILTERS feature flag to Qt.
3105
3106         Reviewed by Kenneth Rohde Christiansen.
3107
3108         * qmake/mkspecs/features/features.prf:
3109
3110 2012-01-04  Kentaro Hara  <haraken@chromium.org>
3111
3112         Rewrite the CSS parser of prepare-ChangeLog with unittests.
3113         https://bugs.webkit.org/show_bug.cgi?id=75202
3114
3115         Reviewed by David Kilzer.
3116
3117         The current CSS parser can just parse simple CSSes like
3118
3119             foo bar baz {
3120                 property1: value;
3121                 property2: value;
3122             }
3123
3124         , and cannot parse comments nor a CSS in which a selector and {
3125         appears in different lines. This patch rewrites the CSS parser
3126         (i.e. get_selector_line_ranges_for_css()) so that it can parse more CSSes
3127         shown in css_unittests.css.
3128
3129         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css
3130
3131         * Scripts/prepare-ChangeLog:
3132         (get_selector_line_ranges_for_css):
3133         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
3134         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Added.
3135         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css: Added.
3136         (element1):
3137         (element2):
3138         (element3):
3139         (element4.p):
3140         (element5.p.q.r.s):
3141         (element6#p):
3142         (element7 element8):
3143         (element9.p element10.q):
3144         (element11#p element12#q):
3145         (element13, element14):
3146         (.p):
3147         (#p):
3148         (.p element15 #q element16.r element17#s):
3149         (element18:target):
3150         (element19):
3151         (element20):
3152         (element21):
3153         (element22):
3154
3155 2012-01-04  Kentaro Hara  <haraken@chromium.org>
3156
3157         The Perl parser of prepare-ChangeLog can parse here-documents
3158         https://bugs.webkit.org/show_bug.cgi?id=73208
3159
3160         Reviewed by David Kilzer.
3161
3162         Currently prepare-ChangeLog cannot recognize here-documents in Perl,
3163         which results in wrong subroutine names in ChangeLogs.
3164         With this patch, prepare-ChangeLog can judge whether the line of "}"
3165         is the end of a subroutine or a line inside a here-document.
3166
3167         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
3168
3169         * Scripts/prepare-ChangeLog:
3170         (get_function_line_ranges_for_perl):
3171         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
3172         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
3173         Added test cases for here-documents.
3174         (func7):
3175         (func8):
3176         (func9):
3177         (func10):
3178         (func11):
3179         (func12):
3180         (func13):
3181         (func14):
3182         (func15):
3183         (func16):
3184
3185 2012-01-08  Kentaro Hara  <haraken@chromium.org>
3186
3187         Add unittests for the JavaScript parser of prepare-ChangeLog
3188         https://bugs.webkit.org/show_bug.cgi?id=75201
3189
3190         Reviewed by David Kilzer.
3191
3192         javascript_unittests.js is a unittest for get_function_line_ranges_for_javascript()
3193         of prepare-ChangeLog.
3194
3195         * Scripts/prepare-ChangeLog:
3196         (get_function_line_ranges_for_javascript): Before this patch, a string found was just
3197         omitted from parsing. Thus,
3198
3199             str = "foo"
3200             function func() {
3201             }
3202
3203         was recognized as equivalent to
3204
3205             str = function func() {
3206             }
3207
3208         This patch replaces a string with a dummy identifier 'string_appeared_here'
3209         to tell the parser that a string appeared there.
3210
3211         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
3212         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Added.
3213         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js: Added.
3214         (func1):
3215         (func2):
3216         (func3):
3217         (func4):
3218         (func5):
3219         (func6):
3220         (func7):
3221         (func8):
3222         (func9):
3223         (func10):
3224         (func11):
3225         (func12):
3226         (funcOverloaded):
3227         (Func1.prototype.get x1):
3228         (Func1.prototype.get x2):
3229         (Func1.prototype.set x1):
3230         (Func1.prototype.set x3):
3231         (Func2.prototype.func13):
3232         (Func2.prototype.func14):
3233         (Func2.prototype.func15):
3234         (func16.func17):
3235         (func16.func18):
3236         (func16.func19):
3237         (func16):
3238
3239 2012-01-08  David Levin  <levin@chromium.org>
3240
3241         [chromium] Add layout test support for autosize code in FrameView.
3242         https://bugs.webkit.org/show_bug.cgi?id=73631
3243
3244         Reviewed by Dmitry Titov.
3245
3246         * DumpRenderTree/chromium/LayoutTestController.cpp:
3247         (LayoutTestController::LayoutTestController): Expose the new autoresize method.
3248         (LayoutTestController::reset): Set the autoresize mode back to false.
3249         (LayoutTestController::enableAutoResizeMode): A way to turn on autoresizing from javascript code in DumpRenderTree.
3250         * DumpRenderTree/chromium/LayoutTestController.h:
3251         * DumpRenderTree/chromium/WebViewHost.cpp:
3252         (WebViewHost::didAutoResize): Handle the autoresize callback so that the outer bounds change appropriately.
3253         * DumpRenderTree/chromium/WebViewHost.h:
3254
3255 2012-01-07  Zan Dobersek  <zandobersek@gmail.com>
3256
3257         [WK2][GTK] Each test takes roughly half a second to load
3258         https://bugs.webkit.org/show_bug.cgi?id=70699
3259
3260         Reviewed by Martin Robinson.
3261
3262         Set the XDG_CACHE_HOME environment variable when testing with
3263         WebKitTestRunner. This way the testing is started with a non-existing
3264         application cache. If the cache exists and is not empty, the emptying
3265         and vacuuming that is performed before every test can consume a lot of
3266         time.
3267
3268         This is just a temporary workaround until it becomes possible to set
3269         a desired directory to be used as the application cache location through
3270         WebKitWebContext.
3271
3272         * Scripts/webkitpy/layout_tests/port/gtk.py:
3273         (GtkPort.setup_environ_for_server):
3274
3275 2012-01-07  Zan Dobersek  <zandobersek@gmail.com>
3276
3277         [GTK] Enable requestAnimationFrame in build-webkit
3278         https://bugs.webkit.org/show_bug.cgi?id=75773
3279
3280         Reviewed by Martin Robinson.
3281
3282         Enable requestAnimationFrame for the Gtk port.
3283
3284         * Scripts/build-webkit:
3285
3286 2012-01-06  Jarred Nicholls  <jarred@sencha.com>
3287
3288         Unreviewed build-webkit fix for Chromium to properly use make if gyp generates Makefiles.
3289
3290         * Scripts/webkitdirs.pm:
3291         (buildChromium):
3292         Missing parentheses.
3293
3294 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
3295
3296         Fix DRT build on case-sensitive file systems.
3297
3298         Fix case of include of WebDynamicScrollBarsView.h
3299         
3300         * DumpRenderTree/mac/DumpRenderTree.mm:
3301
3302 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
3303
3304         Pixel results from DumpRenderTree and WebKitTestRunner don't match because of colorspace issues
3305         https://bugs.webkit.org/show_bug.cgi?id=75662
3306
3307         Reviewed by Dan Bernstein.
3308         
3309         The pixel results generated by DumpRenderTree and WebKitTestRunner differed because
3310         of color profile issues. Fix by keeping everything in device RGB and ensuring that the
3311         test window uses the main display's color space, so that the pixel values in the bitmap
3312         that gets checksummed are identical to the CSS colors.
3313         
3314         Removed the code that switches the display profile in DRT, since that is no longer required.
3315
3316         * DumpRenderTree/PixelDumpSupport.h: Remove unused function declarations.
3317         * DumpRenderTree/mac/DumpRenderTree.mm:
3318         (crashHandler): Remove code that switches display profiles.
3319         (prepareConsistentTestingEnvironment): Ditto.
3320         (dumpRenderTree): Ditto.
3321         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Ditto.
3322         (createBitmapContext): Use DeviceRGB for the bitmap colorspace.
3323         (createBitmapContextFromWebView): Add comment about the colorspace handling.
3324         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3325         (WTR::createCGContextFromImage): Use a RetainPtr, add comment.
3326         (WTR::computeMD5HashStringForContext): Simplify the #ifdefs around the braces.
3327         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3328         (WTR::PlatformWebView::PlatformWebView): Set the window's colorspace to that of the main display.
3329         (WTR::PlatformWebView::windowSnapshotImage): Add comment about colorspaces.
3330
3331 2012-01-06  David Kilzer  <ddkilzer@apple.com>
3332
3333         run-api-tests: specify individual suites and tests on the command-line
3334
3335         Reviewed by Adam Roben.
3336
3337         Fixes: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
3338
3339         The run-api-tests script will now accept a list of arguments on
3340         the command-line that are used as prefix filters.  To run all
3341         tests in a suite that starts with "WTF" (WTF and WTF_Vector)
3342         use:
3343
3344             $ run-api-tests WTF
3345
3346         To run only the tests in the "WTF" suite, not the "WTF_Vector"
3347         suite, use:
3348
3349             $ run-api-tests WTF.
3350
3351         * Scripts/run-api-tests: Filter tests if any prefix arguments
3352         are passed on the command-line.
3353
3354 2012-01-06  David Kilzer  <ddkilzer@apple.com>
3355
3356         run-api-tests: change internal representation of tests to array of "SuiteName.TestName" strings
3357
3358         Reviewed by Adam Roben.
3359
3360         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
3361
3362         * Scripts/run-api-tests:
3363         (dumpTestsBySuite): Update to accept array of tests instead of
3364         hash data structure.
3365         (runTestsBySuite): Ditto.
3366         (listAllTests): Rename from populateTests().  Update to return
3367         an array of tests instad of the hash data structure.
3368
3369 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
3370
3371         webkitpy: clean up test/uri conversion routines
3372         https://bugs.webkit.org/show_bug.cgi?id=75648
3373
3374         Reviewed by Eric Seidel.
3375
3376         This change moves test_to_uri and uri_to_test from the Port
3377         class to the Driver class (the routines were only being
3378         called by the drivers), and removes a bunch of stale and/or
3379         busted logic.
3380
3381         * Scripts/webkitpy/layout_tests/port/base.py:
3382         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3383         * Scripts/webkitpy/layout_tests/port/chromium.py:
3384         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3385         * Scripts/webkitpy/layout_tests/port/driver.py:
3386         (is_http_test):
3387         (test_to_uri):
3388         (uri_to_test):
3389         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3390         (run_one_test):
3391         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3392         (MockDRTTest.input_line):
3393         (input_line):
3394         (expected_output):
3395         * Scripts/webkitpy/layout_tests/port/test.py:
3396         * Scripts/webkitpy/layout_tests/port/webkit.py:
3397         (_command_from_driver_input):
3398
3399 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
3400
3401         Mitigate scrollbar differences when running pixel tests
3402         https://bugs.webkit.org/show_bug.cgi?id=67217
3403
3404         Reviewed by Dan Bernstein.
3405         
3406         Add an NSScroller subclass that draws mock scrollbars identically
3407         to the WebCore mock scrollbar theme, and register it with the
3408         WebDynamicScrollbarsView.
3409
3410         * DumpRenderTree/mac/DumpRenderTree.mm:
3411         (-[DRTMockScroller rectForPart:]):
3412         (-[DRTMockScroller drawKnob]):
3413         (-[DRTMockScroller drawRect:]):
3414         (registerMockScrollbars):
3415         (prepareConsistentTestingEnvironment):
3416
3417 2012-01-05  Jon Lee  <jonlee@apple.com>
3418
3419         Update DRT on Mac to draw resize handles on text areas.
3420
3421         Reviewed by John Sullivan.
3422
3423         Enable resize handles on text areas so that we don't have to create two different sets of pixel test results,
3424         between WK1 and WK2. This will require rebaselining existing textarea pixel tests.
3425
3426         * DumpRenderTree/mac/DumpRenderTree.mm:
3427         (resetDefaultsToConsistentValues):
3428
3429 2012-01-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3430
3431         [Qt] Move listing of include paths and libs to pri files in sources
3432
3433         Includepaths are sometimes modified by non-Qt contributors so keeping
3434         them in files inside Sources makes it more likely that they are updated
3435         along with project files for the other ports.
3436
3437         Using pri files instead of prf files for this also has the benefit that
3438         the include() from the main target file can be parsed and followed by
3439         Qt Creator -- something that does not work with load().
3440
3441         Dependency from a target to a library through the WEBKIT variable are
3442         handled through forwarding-files in Tools/qmake/mkspecs/modules, which
3443         set the source root of the module and include the right pri file.
3444
3445         Ideally we'd use the variant of include() that takes an optional
3446         namespace to read the variables into, or the fromfile() function,
3447         but both of these add an overhead of about 40% on the total qmake
3448         runtime, due to making a deep copy of all the variables in the
3449         project or re-reading all the prf files from scratch.
3450
3451         Reviewed by Simon Hausmann.
3452         Reviewed by Ossy.
3453
3454         * qmake/mkspecs/features/default_post.prf:
3455         * qmake/mkspecs/modules/javascriptcore.prf: Added.
3456         * qmake/mkspecs/modules/webcore.prf: Added.
3457         * qmake/mkspecs/modules/webkit2.prf: Added.
3458         * qmake/mkspecs/modules/wtf.prf: Added.
3459
3460 2012-01-06  JungJik Lee  <jungjik.lee@samsung.com>
3461
3462         [EFL] Add pre-render handling code in EWebLauncher.
3463         https://bugs.webkit.org/show_bug.cgi?id=73430
3464
3465         Reviewed by Zoltan Herczeg.
3466
3467         Add pre-render handling code by pressing Insert key.
3468
3469         * EWebLauncher/main.c:
3470         (on_key_down):
3471
3472 2012-01-06  Csaba Osztrogonác  <ossy@webkit.org>
3473
3474         NRWT should use test_expectation.txt on wk2 platforms
3475         https://bugs.webkit.org/show_bug.cgi?id=75417
3476
3477         Reviewed by Dirk Pranke.
3478
3479         * Scripts/webkitpy/layout_tests/port/webkit.py:
3480         (path_to_test_expectations_file):
3481         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3482         (test_path_to_test_expectations_file):
3483
3484 2012-01-05  Jochen Eisinger  <jochen@chromium.org>
3485
3486         Don't hardcode expected file URIs in as they depend on the platform
3487         https://bugs.webkit.org/show_bug.cgi?id=75666
3488
3489         Reviewed by Dirk Pranke.
3490
3491         * Scripts/webkitpy/layout_tests/port/win.py:
3492         (WinPort.show_results_html_file):
3493         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3494         (MainTest.test_unexpected_failures):
3495         (MainTest.test_results_directory_default):
3496         (MainTest.test_results_directory_relative):
3497
3498 2012-01-05  Anders Carlsson  <andersca@apple.com>
3499
3500         Crash when trying to invalidate the NPRuntimeObjectMap for a plug-in in a subframe
3501         https://bugs.webkit.org/show_bug.cgi?id=75667
3502         <rdar://problem/10389454>
3503
3504         Reviewed by Kevin Decker.
3505
3506         Add an evaluate method to the plug-in test scriptable object that can be used to evaluate a given JS string.
3507
3508         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3509         (PluginTest::executeScript):
3510         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3511         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp:
3512         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasMethod):
3513         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::invoke):
3514         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasProperty):
3515
3516 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
3517
3518         webkitpy: clean up port factory methods
3519         https://bugs.webkit.org/show_bug.cgi?id=75590
3520
3521         Reviewed by Eric Seidel.
3522
3523         This change consolidates much of the "factory method" logic
3524         of determining which port objects to create for a given set
3525         of configurations by merging the separate factory methods in
3526         chromium_gpu and google_chrome into PortFactory so that at least
3527         all of the logic is in one place.
3528
3529         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3530         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3531         * Scripts/webkitpy/layout_tests/port/factory.py:
3532         (_port_name_from_arguments_and_options):
3533         (get):
3534         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3535         (test_google_chrome):
3536         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3537         (GoogleChromeLinux32Port):
3538         (GoogleChromeLinux32Port.baseline_search_path):
3539         (test_expectations_overrides):
3540         (architecture):
3541         (GoogleChromeLinux64Port):
3542         (GoogleChromeLinux64Port.baseline_search_path):
3543         (GoogleChromeMacPort):
3544         (GoogleChromeMacPort.baseline_search_path):
3545         (GoogleChromeWinPort):
3546         (GoogleChromeWinPort.baseline_search_path):
3547         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3548         (_verify_baseline_path):
3549
3550 2012-01-05  Jochen Eisinger  <jochen@chromium.org>
3551
3552         Replace webkitpy.common.system.filesystem.file_path_as_url with webkitpy.common.system.path.abspath_to_uri
3553         https://bugs.webkit.org/show_bug.cgi?id=75617
3554
3555         Reviewed by Dirk Pranke.
3556
3557         * Scripts/webkitpy/common/system/filesystem.py:
3558         (FileSystem.exists):
3559         * Scripts/webkitpy/common/system/filesystem_mock.py:
3560         (MockFileSystem.exists):
3561         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3562         (GenericFileSystemTests.teardown_generic_test_dir):
3563         * Scripts/webkitpy/layout_tests/port/base.py:
3564         (Port.to.show_results_html_file):
3565         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3566         (MainTest.test_results_directory_absolute):
3567
3568 2012-01-05  Adam Roben  <aroben@apple.com>
3569
3570         Remove some unnecessary code from old-run-webkit-tests
3571
3572         Thanks to r104187/r104188, we no longer need to set PATH before launching DumpRenderTree or
3573         WebKitTestRunner.
3574
3575         Fixes <http://webkit.org/b/75640> ORWT unnecessarily sets PATH before launching DRT/WTR on
3576         Windows
3577
3578         Reviewed by Eric Seidel.
3579
3580         * Scripts/old-run-webkit-tests:
3581         (top level):
3582         (openDumpTool):
3583         Removed calls to setPathForRunningWebKitApp.
3584
3585 2012-01-05  Adam Roben  <aroben@apple.com>
3586
3587         Teach NRWT to use run-safari to open results.html on Apple's Windows port
3588
3589         NRWT was trying to use User.open_url, which doesn't work on Cygwin. But run-safari is
3590         better, since we always want to open results.html using the user's build of WebKit, not
3591         whatever their default browser is.
3592
3593         Fixes <http://webkit.org/b/75629> <rdar://problem/10648621> NRWT fails to open results.html
3594         for Apple's Windows port
3595
3596         Reviewed by Eric Seidel.
3597
3598         * Scripts/webkitpy/layout_tests/port/win.py:
3599         (WinPort.show_results_html_file): Changed to use run_safari, like MacPort does. Also removed
3600         an obsolete comment.
3601
3602         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3603         (WinPortTest.test_show_results_html_file): Updated expected results.
3604
3605 2012-01-05  Adam Roben  <aroben@apple.com>
3606
3607         Prepend Safari.exe's path to the command-line passed to CreateProcess
3608
3609         Safari expects the first argument in the command-line to be the path to Safari.exe itself.
3610         This is how things get set up when Safari is launched normally (e.g., by Explorer). Safari
3611         thus ignores the first argument when looking for command-line arguments. WebKitLauncherWin
3612         was not including the path to Safari.exe in the command-line, so Safari was ignoring the
3613         first argument that WebKitLauncherWin was trying to pass to it.
3614
3615         Fixes <http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by Safari
3616
3617         Reviewed by Steve Falkenburg.
3618
3619         * WebKitLauncherWin/WebKitLauncherWin.cpp:
3620         (_tWinMain): Construct a command-line for CreateProcess that first contains a double-quoted
3621         path to Safari.exe, then contains any arguments that were passed to WebKitLauncherWin.
3622
3623 2012-01-05  Adam Roben  <aroben@apple.com>
3624
3625         Stop using explicit memory management in WebKitLauncherWin
3626
3627         We now use stack-allocated STL objects instead.
3628
3629         Prep work for <http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by
3630         Safari
3631
3632         Reviewed by Steve Falkenburg.
3633
3634         * WebKitLauncherWin/WebKitLauncherWin.cpp:
3635         (getStringValue):
3636         (applePathFromRegistry):
3637         (safariInstallDir):
3638         (safariBrowserExe):
3639         (_tWinMain):
3640         Changed to use stack-allocated STL objects instead of malloc/free.
3641
3642 2012-01-05  Adam Roben  <aroben@apple.com>
3643
3644         Turn WebKitTestRunner into a stub .exe launcher and a .dll that contains all the real code
3645
3646         This allows us to add the Safari and Apple Application Support directories to PATH before
3647         trying to load WebKit so that SafariTheme.dll, CoreGraphics.dll and friends can be found.
3648
3649         Fixes <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
3650         Windows port of DumpRenderTree/WebKitTestRunner
3651
3652         Reviewed by Steve Falkenburg.
3653
3654         * WebKitTestRunner/WebKitTestRunner.sln: Added WebKitTestRunnerLauncher and
3655         ImageDiffLauncher, which I forgot to add to this .sln when that project was created.
3656
3657         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
3658         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3659         Changed to build WebKitTestRunner.dll instead of WebKitTestRunner.exe.
3660
3661         * WebKitTestRunner/win/WebKitTestRunnerLauncher.vcproj: Copied from
3662         Tools/WebKitTestRunner/win/WebKitTestRunner.vcproj but changed to build
3663         the stub launcher.
3664
3665         * WebKitTestRunner/win/WebKitTestRunnerLauncherCommon.vsprops: Added.
3666         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebug.vsprops: Added.
3667         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugAll.vsprops: Added.
3668         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops: Added.
3669         * WebKitTestRunner/win/WebKitTestRunnerLauncherProduction.vsprops: Added.
3670         * WebKitTestRunner/win/WebKitTestRunnerLauncherRelease.vsprops: Added.
3671         * WebKitTestRunner/win/WebKitTestRunnerLauncherReleaseCairoCFLite.vsprops: Added.
3672
3673         * WebKitTestRunner/win/main.cpp:
3674         (dllLauncherEntryPoint): Renamed from main. This is what the stub launcher calls.
3675
3676 2012-01-05  Adam Roben  <aroben@apple.com>
3677
3678         Turn DumpRenderTree into a stub .exe launcher and a .dll that contains all the real code
3679
3680         This allows us to add the Safari and Apple Application Support directories to PATH before
3681         trying to load WebKit so that SafariTheme.dll, CoreGraphics.dll and friends can be found.
3682
3683         Part of <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
3684         Windows port of DumpRenderTree/WebKitTestRunner
3685
3686         Reviewed by Steve Falkenburg.
3687
3688         * DumpRenderTree/DumpRenderTree.sln: Added DumpRenderTreeLauncher and ImageDiffLauncher,
3689         which I forgot to add to this .sln when that project was created.
3690
3691         * DumpRenderTree/win/DumpRenderTree.cpp:
3692         (dllLauncherEntryPoint): Renamed from main. This is what the stub launcher calls.
3693
3694         * DumpRenderTree/win/DumpRenderTree.vcproj:
3695         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
3696         Changed to build DumpRenderTree.dll instead of DumpRenderTree.exe.
3697
3698         * DumpRenderTree/win/DumpRenderTreeLauncher.vcproj: Added.
3699         * DumpRenderTree/win/DumpRenderTreeLauncherCommon.vsprops: Added.
3700         * DumpRenderTree/win/DumpRenderTreeLauncherDebug.vsprops: Added.
3701         * DumpRenderTree/win/DumpRenderTreeLauncherDebugAll.vsprops: Added.
3702         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops: Added.
3703         * DumpRenderTree/win/DumpRenderTreeLauncherProduction.vsprops: Added.
3704         * DumpRenderTree/win/DumpRenderTreeLauncherRelease.vsprops: Added.
3705         * DumpRenderTree/win/DumpRenderTreeLauncherReleaseCairoCFLite.vsprops: Added.
3706
3707         * win/DLLLauncher/DLLLauncherMain.cpp:
3708         (modifyPath): Moved code to modify PATH here from main/wWinMain. Changed to also prepend
3709         Safari's directory to PATH so that SafariTheme.dll can be found.
3710
3711         (main):
3712         (wWinMain):
3713         Changed to use the new modifyPath function.
3714
3715 2012-01-05  Alexander Færøy  <alexander.faeroy@nokia.com>
3716
3717         [Qt] Never enable FontConfig on Mac OS X
3718         https://bugs.webkit.org/show_bug.cgi?id=75616
3719
3720         Reviewed by Tor Arne Vestbø.
3721
3722         * qmake/mkspecs/features/features.prf:
3723
3724 2012-01-05  Alpha Lam  <hclam@chromium.org>
3725
3726         Unreviewed, rolling out r104159.
3727         http://trac.webkit.org/changeset/104159
3728         https://bugs.webkit.org/show_bug.cgi?id=75590
3729
3730         Chromium port GPU tests cannot be executed.
3731
3732         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3733         (get):
3734         (_default_tests_paths):
3735         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3736         (ChromiumGpuTest.assert_port_works):
3737         * Scripts/webkitpy/layout_tests/port/factory.py:
3738         (PortFactory._port_name_from_arguments_and_options):
3739         (PortFactory):
3740         (PortFactory._get_kwargs):
3741         (PortFactory.get):
3742         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3743         (FactoryTest.test_google_chrome.names):
3744         (FactoryTest.test_google_chrome):
3745         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3746         (GetGoogleChromePort):
3747         (GetGoogleChromePort.GoogleChromeLinux32Port):
3748         (GetGoogleChromePort.GoogleChromeLinux32Port.baseline_search_path):
3749         (GetGoogleChromePort.GoogleChromeLinux32Port.test_expectations_overrides):
3750         (GetGoogleChromePort.GoogleChromeLinux32Port.architecture):
3751         (GetGoogleChromePort.GoogleChromeLinux64Port):
3752         (GetGoogleChromePort.GoogleChromeLinux64Port.baseline_search_path):
3753         (GetGoogleChromePort.GoogleChromeLinux64Port.test_expectations_overrides):
3754         (GetGoogleChromePort.GoogleChromeLinux64Port.architecture):
3755         (GetGoogleChromePort.GoogleChromeMacPort):
3756         (GetGoogleChromePort.GoogleChromeMacPort.baseline_search_path):
3757         (GetGoogleChromePort.GoogleChromeMacPort.test_expectations_overrides):
3758         (GetGoogleChromePort.GoogleChromeWinPort):
3759         (GetGoogleChromePort.GoogleChromeWinPort.baseline_search_path):
3760         (GetGoogleChromePort.GoogleChromeWinPort.test_expectations_overrides):
3761         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3762         (GetGoogleChromePortTest._verify_baseline_path):
3763         (GetGoogleChromePortTest._verify_expectations_overrides):
3764
3765 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
3766
3767         webkitpy: clean up port factory methods
3768         https://bugs.webkit.org/show_bug.cgi?id=75590
3769
3770         Reviewed by Eric Seidel.
3771
3772         This change consolidates much of the "factory method" logic
3773         of determining which port objects to create for a given set
3774         of configurations by merging the separate factory methods in
3775         chromium_gpu and google_chrome into PortFactory so that at least
3776         all of the logic is in one place.
3777
3778         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3779         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3780         * Scripts/webkitpy/layout_tests/port/factory.py:
3781         (_port_name_from_arguments_and_options):
3782         (get):
3783         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3784         (test_google_chrome):
3785         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3786         (GoogleChromeLinux32Port):
3787         (GoogleChromeLinux32Port.baseline_search_path):
3788         (test_expectations_overrides):
3789         (architecture):
3790         (GoogleChromeLinux64Port):
3791         (GoogleChromeLinux64Port.baseline_search_path):
3792         (GoogleChromeMacPort):
3793         (GoogleChromeMacPort.baseline_search_path):
3794         (GoogleChromeWinPort):
3795         (GoogleChromeWinPort.baseline_search_path):
3796         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3797         (_verify_baseline_path):
3798
3799 2012-01-04  Adam Roben  <aroben@apple.com>
3800
3801         Turn ImageDiff into a stub .exe launcher and a .dll that contains all the real code
3802
3803         This allows us to add the Apple Application Support directory to PATH before trying to load
3804         WebKit so that CoreGraphics.dll and friends can be found.
3805
3806         Fixes <http://webkit.org/b/75572> ImageDiff.exe can't be run without first munging PATH
3807
3808         Reviewed by Anders Carlsson.
3809
3810         * DumpRenderTree/win/ImageDiff.vcproj:
3811         * DumpRenderTree/win/ImageDiffCommon.vsprops:
3812         Changed to build ImageDiff.dll instead of ImageDiff.exe.
3813
3814         * DumpRenderTree/win/ImageDiffLauncher.vcproj: Copied from
3815         Tools/DumpRenderTree/win/ImageDiff.vcproj but changed to build the stub launcher.
3816
3817         * DumpRenderTree/win/ImageDiffLauncherCommon.vsprops: Added.
3818         * DumpRenderTree/win/ImageDiffLauncherDebug.vsprops: Added.
3819         * DumpRenderTree/win/ImageDiffLauncherDebugAll.vsprops: Added.
3820         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops: Added.
3821         * DumpRenderTree/win/ImageDiffLauncherProduction.vsprops: Added.
3822         * DumpRenderTree/win/ImageDiffLauncherRelease.vsprops: Added.
3823         * DumpRenderTree/win/ImageDiffLauncherReleaseCairoCFLite.vsprops: Added.
3824
3825         * DumpRenderTree/win/ImageDiffWin.cpp: Added.
3826         (dllLauncherEntryPoint): This function is called by the stub launcher and just calls through
3827         to main.
3828
3829         * win/DLLLauncher/DLLLauncherMain.cpp:
3830         (main):
3831         (wWinMain):
3832         Added support for launching console programs. When USE_CONSOLE_ENTRY_POINT is defined, the
3833         stub launcher acts as a console program and calls a console version of
3834         dllLauncherEntryPoint.
3835
3836 2012-01-04  Adam Roben  <aroben@apple.com>
3837
3838         Turn MiniBrowser into a stub .exe launcher and a .dll that contains all the real code
3839
3840         This allows us to add the Apple Application Support directory to PATH before trying to load
3841         WebKit so that CoreGraphics.dll and friends can be found.
3842
3843         Fixes <http://webkit.org/b/68576> <rdar://problem/10163853> MiniBrowser fails to launch when
3844         double-clicked
3845
3846         Reviewed by Anders Carlsson.
3847
3848         * MiniBrowser/MiniBrowser.vcproj:
3849         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
3850         Changed to build MiniBrowser.dll instead of MiniBrowser.exe.
3851
3852         * MiniBrowser/Configurations/MiniBrowserLauncherCommon.vsprops: Added.
3853         * MiniBrowser/Configurations/MiniBrowserLauncherDebug.vsprops: Added.
3854         * MiniBrowser/Configurations/MiniBrowserLauncherDebugAll.vsprops: Added.
3855         * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops: Added.
3856         * MiniBrowser/Configurations/MiniBrowserLauncherProduction.vsprops: Added.
3857         * MiniBrowser/Configurations/MiniBrowserLauncherRelease.vsprops: Added.
3858         * MiniBrowser/Configurations/MiniBrowserLauncherReleaseCairoCFLite.vsprops: Added.
3859
3860         * MiniBrowser/MiniBrowserLauncher.vcproj: Copied from Tools/MiniBrowser/MiniBrowser.vcproj
3861         but changed to build the stub launcher.
3862
3863         * MiniBrowser/win/main.cpp: Moved the /manifestdependency code to DLLLauncherMain.cpp, since
3864         it needs to be compiled into the .exe instead of the .dll.
3865         (DllMain): Added. We use this to store the DLL's HINSTANCE.
3866         (dllLauncherEntryPoint): Renamed from _tWinMain. This is what gets called by the
3867         DLLLauncherMain code.
3868
3869         * win/DLLLauncher/DLLLauncherMain.cpp: Moved the /manifestdependency code from MiniBrowser
3870         to here.
3871
3872 2012-01-04  Adam Roben  <aroben@apple.com>
3873
3874         Make WinLauncher's window frame respond to clicks/drags again
3875
3876         Fixes <http://webkit.org/b/75562> REGRESSION (r84990): Can't drag WinLauncher by its title
3877         bar when Aero is disabled
3878
3879         Reviewed by Brent Fulgham.
3880
3881         * WinLauncher/WinLauncher.cpp:
3882         (WndProc): Always call up to our parent wndproc when we don't handle WM_NCHITTEST ourselves.
3883         Also removed an unnecessary "break" keyword.
3884
3885 2012-01-04  Adam Roben  <aroben@apple.com>
3886
3887         Turn WinLauncher into a stub .exe launcher and a .dll that contains all the real code
3888
3889         This allows us to add the Apple Application Support directory to PATH before trying to load
3890         WebKit so that CoreGraphics.dll and friends can be found. Eventually all our WebKit apps
3891         should use this mechanism.
3892
3893         Fixes <http://webkit.org/b/68578> <rdar://problem/10163861> WinLauncher fails to launch when
3894         double-clicked
3895
3896         Reviewed by Anders Carlsson.
3897
3898         * WinLauncher/WinLauncher.cpp: Removed InitInstance.
3899         (DllMain): Added. Stores the DLL HINSTANCE in the global hInst variable. This used to be
3900         done by the now-removed InitInstance function.
3901         (dllLauncherEntryPoint): Renamed from _tWinMain. This is the function that our stub launcher
3902         calls. Merged code from InitInstance into this function, and change to use the global hInst
3903         variable, which corresponds to WinLauncher.dll, rather than the HINSTANCE passed into this
3904         function, which corresponds to WinLauncher.exe.
3905
3906         * WinLauncher/WinLauncher.vcproj:
3907         * WinLauncher/WinLauncherCommon.vsprops:
3908         Changed to build WinLauncher.dll instead of WinLauncher.exe.
3909
3910         * WinLauncher/WinLauncherLauncher.rc: Added.
3911         * WinLauncher/WinLauncherLauncherResource.h: Added.
3912         This just references the WinLauncher.ico file to set the application icon (though it looks
3913         like that's a default icon).
3914
3915         * WinLauncher/WinLauncherLauncher.vcproj: Copied from Tools/WinLauncher/WinLauncher.vcproj
3916         but changed to build WinLauncher.exe using the new DLLLauncherMain.cpp file.
3917
3918         * WinLauncher/WinLauncherLauncherCommon.vsprops: Added.
3919         * WinLauncher/WinLauncherLauncherDebug.vsprops: Added.
3920         * WinLauncher/WinLauncherLauncherDebugAll.vsprops: Added.
3921         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops: Added.
3922         * WinLauncher/WinLauncherLauncherProduction.vsprops: Added.
3923         * WinLauncher/WinLauncherLauncherRelease.vsprops: Added.
3924         * WinLauncher/WinLauncherLauncherReleaseCairoCFLite.vsprops: Added.
3925
3926         * win/DLLLauncher/DLLLauncherMain.cpp: Added.
3927         (enableTerminationOnHeapCorruption): Uses HeapSetInformation to tell Windows to kill the
3928         program if it detects heap corruption.
3929         (getStringValue): Helper function to read a string value from the registry.
3930         (applePathFromRegistry): Helper function to read the InstallDir for a given Apple
3931         application from the registry.
3932         (appleApplicationSupportDirectory): Helper function to return the path to the Apple
3933         Application Support directory.
3934         (copyEnvironmentVariable): Helper function to copy an environment variable's value.
3935         (prependPath): Helper function to prepend a directory to the PATH.
3936         (fatalError): Helper function to display an error to the user.
3937         (wWinMain): Add Apple Application Support to the PATH, then load our DLL and call its
3938         dllLauncherEntryPoint function.
3939
3940 2012-01-05  Kentaro Hara  <haraken@chromium.org>
3941
3942         prepare-ChangeLog cannot parse python code that nests classes and defs
3943         https://bugs.webkit.org/show_bug.cgi?id=75524
3944
3945         Reviewed by Ryosuke Niwa.
3946
3947         This patch fixes the python parser of prepare-ChangeLog so that it can parse
3948         python code that nests classes and defs, like this:
3949
3950         class C:
3951             pass
3952             def f():
3953                 pass
3954             pass
3955
3956         Also, this patch fixes the python parser so that it inserts a dummy line
3957         at the end of the file to pop out all popped scopes.
3958
3959         * Scripts/prepare-ChangeLog:
3960         (get_function_line_ranges_for_python):
3961
3962         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py:
3963         Added test cases that nest classes and defs.
3964         (func7):
3965         (func7.func8):
3966         (func7.func8.func9):
3967         (Class2):
3968         (Class2.Class3):
3969         (Class2.Class3.Class4):
3970         (Class5):
3971         (Class5.func10):
3972         (Class5.func11):
3973         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt:
3974
3975 2012-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3976
3977         [GTK] Rename webkit_web_view_load_alternate_html as webkit_web_view_replace_content in WebKit2 GTK+
3978         https://bugs.webkit.org/show_bug.cgi?id=75433
3979
3980         Reviewed by Martin Robinson.
3981
3982         * MiniBrowser/gtk/BrowserWindow.c:
3983         (webViewLoadFailed): Reset the progress bar when load fails.
3984         (browserWindowConstructed): Connect to load-failed signal.
3985
3986 2012-01-04  Dan Bernstein  <mitz@apple.com>
3987
3988         Add a --target-web-process option to the debug-* scripts. When specified, the scripts will
3989         start WebProcess under gdb and WebProcess will then run the client executable.
3990
3991         This is the Tools part of fixing <http://webkit.org/b/75444> Debugging WebProcess requires running a UI process first and waiting to attach
3992
3993         Reviewed by Anders Carlsson.
3994
3995         * Scripts/webkitdirs.pm:
3996         (shouldTargetWebProcess): Added.
3997         (determineShouldTargetWebProcess): Added. Checks for --target-web-process.
3998         (execMacWebKitAppForDebugging): Changed to target gdb at WebProcess and pass the path to the
3999         app using the -client-executable option if targeting the web process.
4000
4001 2012-01-04  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
4002
4003         Adding myself to committers list.
4004
4005         Unreviewed.
4006
4007         * Scripts/webkitpy/common/config/committers.py:
4008
4009 2012-01-04  David Kilzer  <ddkilzer@apple.com>
4010
4011         Revert fix for Bug 75064: TestWebKitAPI: initialize the main thread before running tests
4012
4013         This reverts commit r103546.
4014
4015         * TestWebKitAPI/TestsController.cpp:
4016         (TestWebKitAPI::TestsController::TestsController):
4017
4018 2012-01-04  James Robinson  <jamesr@chromium.org>
4019
4020         [chromium] Move WebMimeRegistry and dependencies to Source/Platform
4021         https://bugs.webkit.org/show_bug.cgi?id=74583
4022
4023         Reviewed by Darin Fisher.
4024
4025         Teaches the WEBKIT_EXPORT check about the chromium WebKit platform API header location.
4026
4027         * Scripts/webkitpy/style/checkers/cpp.py:
4028         (check_function_definition):
4029
4030 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4031
4032         [Qt] Fix link order of static libraries and unbreak QtWin32
4033
4034         We were keeping the correct static link order between the intermediate
4035         WebKit libraries, but not the internal dependencies for each of those
4036         libraries. The load() will in some instances mess with LIBS, so we need
4037         to ensure that the dependent libraries are added after the library we
4038         are linking against.
4039
4040         Reviewed by Simon Hausmann.
4041
4042         * qmake/mkspecs/features/default_post.prf:
4043
4044 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4045
4046         [Qt] Introduce new qmake variable 'WEBKIT' for signaling dependencies
4047
4048         The custom qmake variable 'WEBKIT' is used for signaling that a
4049         target depends in some way on other subproject of the WebKit
4050         project. For now this is limited to the set of intermediate
4051         libraries: wtf, javascriptcore, webcore, and webkit2.
4052
4053         This replaces the previous convension of using load(foo) for
4054         just include paths, and CONFIG += foo to also link against foo.
4055
4056         Adding a dependency results in additional include paths being
4057         available, and potentially linking to the library. This is
4058         decided by the build system based on conditions such as what
4059         kind of target is being built and the general build config.
4060
4061         An advantage to his approach is that it simplifies the individual
4062         foo.prf files, for example by allowing us to use INCLUDEPATH +=
4063         and LIBS += as normal instead of prepending.
4064
4065         Reviewed by Simon Hausmann.
4066
4067         * DumpRenderTree/qt/DumpRenderTree.pro:
4068         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
4069         * QtTestBrowser/QtTestBrowser.pro:
4070         * WebKitTestRunner/InjectedBundle/Target.pri:
4071         * WebKitTestRunner/Target.pri:
4072         * qmake/README:
4073         * qmake/mkspecs/features/default_post.prf:
4074         * qmake/mkspecs/features/functions.prf:
4075         * qmake/mkspecs/features/javascriptcore.prf:
4076         * qmake/mkspecs/features/qtwebkit.prf:
4077         * qmake/mkspecs/features/webcore.prf:
4078         * qmake/mkspecs/features/webkit2.prf:
4079         * qmake/mkspecs/features/wtf.prf:
4080
4081 2012-01-04  Alexander Færøy  <ahf@0x90.dk>
4082
4083         [Qt] Add UI for JavaScript Prompt dialog in the Qt MiniBrowser
4084         https://bugs.webkit.org/show_bug.cgi?id=75488
4085
4086         Reviewed by Tor Arne Vestbø.
4087
4088         * MiniBrowser/qt/MiniBrowser.qrc:
4089         * MiniBrowser/qt/qml/BrowserWindow.qml:
4090         * MiniBrowser/qt/qml/Dialog.qml:
4091         * MiniBrowser/qt/qml/DialogLineInput.qml: Copied from Tools/MiniBrowser/qt/qml/Dialog.qml.
4092         * MiniBrowser/qt/qml/PromptDialog.qml: Copied from Tools/MiniBrowser/qt/qml/Dialog.qml.
4093
4094 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4095
4096         [Qt] Use rpath for WTR's InjectedBundle to pick up the right QtWebKit
4097
4098         It wasn't really a problem at runtime since the right QtWebKit was
4099         already loaded as a dependency of the web process, but the ldd output
4100         would still be busted.
4101
4102         Reviewed by Simon Hausmann.
4103
4104         * WebKitTestRunner/InjectedBundle/Target.pri:
4105
4106 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4107
4108         [Qt] Move use of $$qtLibraryTarget() to a single place
4109
4110         Reviewed by Kenneth Rohde Christiansen.
4111
4112         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
4113         * WebKitTestRunner/InjectedBundle/Target.pri:
4114         * qmake/mkspecs/features/default_post.prf:
4115         * qmake/mkspecs/features/webcore.prf:
4116
4117 2012-01-04  Mary Wu  <mary.wu@torchmobile.com.cn>
4118
4119         Enable DOWNLOAD_ATTRIBUTE in BlackBerry porting
4120         https://bugs.webkit.org/show_bug.cgi?id=75238
4121
4122         Reviewed by Antonio Gomes.
4123
4124         Add ENABLE_DOWNLOAD_ATTRIBUTE webkit feature into the build script so that 
4125         it could initiate download directly if it has the download attribute in the link 
4126         and doesn't need to open new blank page for the target="_blank". Enabling this 
4127         feature in the BlackBerry porting also prepares for later blob feature implementation.
4128
4129         * Scripts/build-webkit: Modified to handle ENABLE_DOWNLOAD_ATTRIBUTE. Make it default on
4130         for the BlackBerry porting.
4131
4132 2012-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
4133
4134         [GTK] Fix a runtime warning when hovering hyperlink auditing setting in MiniBroweser settings dialog
4135         https://bugs.webkit.org/show_bug.cgi?id=75475
4136
4137         Reviewed by Martin Robinson.
4138
4139         The problem is that the property blurb contains <a ping> and tree
4140         view uses gtk_tooltip_set_markup() internally, so we need to
4141         escape the text.
4142
4143         * MiniBrowser/gtk/BrowserSettingsDialog.c:
4144         (browserSettingsDialogConstructed): Escape property blurb before
4145         storing it in the GtkTreeModel.
4146
4147 2012-01-03  Jochen Eisinger  <jochen@chromium.org>
4148
4149         When showing results.html pass a correct URL to webbrowser.open
4150         https://bugs.webkit.org/show_bug.cgi?id=75438
4151
4152         Reviewed by Adam Barth.
4153
4154         * Scripts/webkitpy/common/system/filesystem.py:
4155         (file_path_as_url):
4156         * Scripts/webkitpy/common/system/filesystem_mock.py:
4157         (file_path_as_url):
4158         * Scripts/webkitpy/common/system/filesystem_unittest.py:
4159         (test_file_path_as_url):
4160         * Scripts/webkitpy/layout_tests/port/base.py:
4161         (show_results_html_file):
4162         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
4163         (test_show_results_html_file):
4164         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4165         (test_results_directory_relative):
4166
4167 2012-01-03  Ojan Vafai  <ojan@chromium.org>
4168
4169         shrink the header on the flakiness dashboard
4170         https://bugs.webkit.org/show_bug.cgi?id=65153
4171
4172         Reviewed by Adam Roben.
4173
4174         Move some of the "show" links to be to the right of the header
4175         instead of below the header when they content they're showing
4176         is hidden. That way we don't waste vertical space on them.
4177
4178         No new tests. This code is covered by existing tests.
4179
4180         * TestResultServer/static-dashboards/flakiness_dashboard.html:
4181
4182 2012-01-03  Ryosuke Niwa  <rniwa@webkit.org>
4183
4184         Add a tool to analyze change logs
4185         https://bugs.webkit.org/show_bug.cgi?id=72243
4186
4187         Reviewed by Eric Seidel.
4188
4189         Add the initial implementation of analyze-changelog command. This version supports parsing multiple changelogs
4190         in a single directory and summarizes the result in json files. It also copies summary.html to the output directory
4191         for visualizing json files.
4192
4193         Usage: webkit-patch analyze-changelog [--changelog-count N] <CHANGELOG_DIR> <OUTPUT_DIR>
4194         where CHANGELOG_DIR is the directory to look for changelogs, OUTPUT_DIR is the directory into which the tool
4195         generates json files, and N is the number of changelogs to parse.
4196
4197         * Scripts/webkitpy/common/config/contributionareas.py: Added names().
4198         * Scripts/webkitpy/common/system/filesystem_mock.py: Added readline and iterator support to ReadableTextFileObject.
4199         * Scripts/webkitpy/tool/commands/__init__.py:
4200         * Scripts/webkitpy/tool/commands/analyzechangelog.py: Added.
4201         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py: Added.
4202         * Scripts/webkitpy/tool/commands/data/summary.html: Added.
4203         * Scripts/webkitpy/tool/steps/options.py:
4204
4205 2012-01-03  Ryosuke Niwa  <rniwa@webkit.org>
4206
4207         Add a tool to analyze change logs
4208         https://bugs.webkit.org/show_bug.cgi?id=72243
4209
4210         Reviewed by Eric Seidel.
4211
4212         Add the initial implementation of analyze-changelog command. This version supports parsing multiple changelogs
4213         in a single directory and summarizes the result in json files. It also copies summary.html to the output directory
4214         for visualizing json files.
4215
4216         Usage: webkit-patch analyze-changelog [--changelog-count N] <CHANGELOG_DIR> <OUTPUT_DIR>
4217         where CHANGELOG_DIR is the directory to look for changelogs, OUTPUT_DIR is the directory into which the tool
4218         generates json files, and N is the number of changelogs to parse.
4219
4220         * Scripts/webkitpy/common/config/contributionareas.py: Added names().
4221         * Scripts/webkitpy/common/system/filesystem_mock.py: Added readline and iterator support to ReadableTextFileObject.
4222         * Scripts/webkitpy/tool/commands/__init__.py:
4223         * Scripts/webkitpy/tool/commands/analyzechangelog.py: Added.
4224         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py: Added.
4225         * Scripts/webkitpy/tool/commands/data/summary.html: Added.
4226         * Scripts/webkitpy/tool/steps/options.py:
4227
4228 2012-01-03  Adam Roben  <aroben@apple.com>
4229
4230         Make Port subclasses override the operating_system method rather than setting an attribute
4231
4232         Without this patch, any use of Port.operating_system() within a port's __init__ method would
4233         return the default value ("mac"). This was confusing the version-checking logic inside
4234         ApplePort.__init__ on Windows.
4235
4236         Fixes <http://webkit.org/b/75479> <rdar://problem/10637385> REGRESSION (r102161): NRWT
4237         crashes on launch on Windows 7 SP1
4238
4239         Reviewed by Eric Seidel.
4240
4241         * Scripts/webkitpy/layout_tests/port/apple.py:
4242         (ApplePort.__init__): Replaced uses of self._operating_system with self.operating_system().
4243
4244         * Scripts/webkitpy/layout_tests/port/base.py:
4245         (Port.__init__): Removed code that set the self._operating_system attribute. Subclasses
4246         should now override the operating_system method instead.
4247         (Port.operating_system): Changed to always return "mac". Subclasses should override to
4248         return something else.
4249
4250         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
4251         (ChromiumLinuxPort.__init__):
4252         (ChromiumLinuxPort.operating_system):
4253         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
4254         (ChromiumMacPort.__init__):
4255         (ChromiumMacPort.operating_system):
4256         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
4257         (ChromiumWinPort.__init__):
4258         (ChromiumWinPort.operating_system):
4259         * Scripts/webkitpy/layout_tests/port/mac.py:
4260         (MacPort.__init__):
4261         (MacPort.operating_system):
4262         * Scripts/webkitpy/layout_tests/port/win.py:
4263         (WinPort.__init__):
4264         (WinPort.operating_system):
4265         Changed to override the operating_system method rather than setting the _operating_system
4266         attribute, since setting the attribute isn't sufficient for code inside __init__ methods.
4267
4268         * Scripts/webkitpy/layout_tests/port/qt.py:
4269         (QtPort.__init__):
4270         (QtPort._path_to_webcore_library):
4271         Changed to use self.operating_system() instead of self._operating_system, for consistency
4272         with other Port-related code.
4273
4274         (QtPort.operating_system): Added this override of Port.operating_system that returns the
4275         value we determined in our __init__ method.
4276
4277         * Scripts/webkitpy/layout_tests/port/test.py:
4278         (TestPort.operating_system): Added this override of Port.operating_system that returns the
4279         value we determined in our __init__ method.
4280
4281         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
4282         (PortTest.test_operating_system):
4283         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
4284         (ChromiumLinuxPortTest.test_operating_system):
4285         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
4286         (ChromiumMacPortTest.test_operating_system):
4287         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
4288         (ChromiumWinPortTest.test_operating_system):
4289         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
4290         (MacPortTest.test_operating_system):
4291         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
4292         (QtPortTest.test_operating_system):
4293         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
4294         (WinPortTest.test_operating_system):
4295         Test that all ports return the expected operating system string.
4296
4297 2012-01-03  Mario Sanchez Prada  <msanchez@igalia.com>
4298
4299         [GTK] run-gtk-test should ignore files with names without a "test" or "Test" prefix
4300         https://bugs.webkit.org/show_bug.cgi?id=75474
4301
4302         Reviewed by Philippe Normand.
4303
4304         * Scripts/run-gtk-tests: Ignore files whose name does not start
4305         with a "test" (for WK1's API tests) or a "Test" prefix (for WK2).
4306
4307 2012-01-03  Alexander Færøy  <alexander.faeroy@nokia.com>
4308
4309         [Qt] Add UI for JavaScript Confirmation dialog in the Qt MiniBrowser
4310         https://bugs.webkit.org/show_bug.cgi?id=75472
4311
4312         Reviewed by Tor Arne Vestbø.
4313
4314         * MiniBrowser/qt/MiniBrowser.pro:
4315         * MiniBrowser/qt/MiniBrowser.qrc:
4316         * MiniBrowser/qt/qml/BrowserWindow.qml:
4317         * MiniBrowser/qt/qml/ConfirmDialog.qml: Added.
4318
4319 2012-01-03  Alexander Færøy  <alexander.faeroy@nokia.com>
4320
4321         [Qt] Add UI for JavaScript Alert dialog in the Qt MiniBrowser
4322         https://bugs.webkit.org/show_bug.cgi?id=75471
4323
4324         Reviewed by Tor Arne Vestbø.
4325
4326         Add simple UI for JavaScript Alert dialogs. This patch also adds a
4327         simple DialogButton QML type and a Dialog QML type which will be
4328         reusable for other JavaScript dialogs.
4329
4330         * MiniBrowser/qt/MiniBrowser.qrc:
4331         * MiniBrowser/qt/qml/AlertDialog.qml: Added.
4332         * MiniBrowser/qt/qml/BrowserWindow.qml:
4333         * MiniBrowser/qt/qml/Dialog.qml: Added.