Fix wrong value variable in ENABLE_NAVIGATOR_HWCONCURRENCY
[WebKit-https.git] / Tools / ChangeLog
1 2015-04-13  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2
3         Fix wrong value variable in ENABLE_NAVIGATOR_HWCONCURRENCY
4         https://bugs.webkit.org/show_bug.cgi?id=143667
5
6         Reviewed by Csaba Osztrogonác.
7
8         ENABLE_NAVIGATOR_HWCONCURRENCY has used $registerProtocolHandlerSupport value variable
9         since r169017. Added $hardwareConcurrencySupport for it.
10
11         Additionally networkInfoSupport is removed because this feature was removed due to spec out.
12
13         * Scripts/webkitperl/FeatureList.pm:
14
15 2015-04-13  Csaba Osztrogonác  <ossy@webkit.org>
16
17         [cmake] Add ENABLE(ATTACHMENT_ELEMENT) to the build system
18         https://bugs.webkit.org/show_bug.cgi?id=143664
19
20         Reviewed by Gyuyoung Kim.
21
22         * Scripts/webkitperl/FeatureList.pm:
23
24 2015-04-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
25
26         [EFL] Enable Media Source
27         https://bugs.webkit.org/show_bug.cgi?id=143635
28
29         Reviewed by Csaba Osztrogonác.
30
31         * Scripts/webkitperl/FeatureList.pm: Enable media source on efl port.
32
33 2015-04-12  Alexey Proskuryakov  <ap@apple.com>
34
35         build.webkit.org/dashboard: Crash-only queues should show failure when failure limit is exceeded
36         https://bugs.webkit.org/show_bug.cgi?id=143646
37
38         Reviewed by David Kilzer.
39
40         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
41         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
42
43 2015-04-11  Alexey Proskuryakov  <ap@apple.com>
44
45         Use en_US spell checker for tests on Mac instead of Multilingual
46         https://bugs.webkit.org/show_bug.cgi?id=143641
47
48         Reviewed by Dan Bernstein.
49
50         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
51         While at it, override NSUserDictionaryReplacementItems, so that user replacements
52         cannot affect tests.
53
54         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
55         Made this more like WebKit1 version.
56
57 2015-04-10  Tim Horton  <timothy_horton@apple.com>
58
59         Replace setFixedLayoutSizeEnabled: with an enum of layout modes
60         https://bugs.webkit.org/show_bug.cgi?id=143576
61
62         Reviewed by Simon Fraser.
63
64         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm:
65         (TEST):
66         Adopt.
67
68 2015-04-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
69
70         Update my email address and expertise.
71         https://bugs.webkit.org/show_bug.cgi?id=143586
72
73         Unreviewed, just update my info.
74
75         * Scripts/webkitpy/common/config/contributors.json:
76
77 2015-04-09  Joseph Pecoraro  <pecoraro@apple.com>
78
79         Flakiness Dashboard not loading insecure content if loaded with https URL
80         https://bugs.webkit.org/show_bug.cgi?id=143570
81
82         Reviewed by Alexey Proskuryakov.
83
84         * TestResultServer/app.yaml:
85         * TestResultServer/static-dashboards/loader.js:
86         Switch to https scheme.
87
88 2015-04-09  Csaba Osztrogonác  <ossy@webkit.org>
89
90         [EFL][GTK] WebKit2's generate-forwarding-headers.pl runs too many times
91         https://bugs.webkit.org/show_bug.cgi?id=142907
92
93         Reviewed by Carlos Garcia Campos.
94
95         * TestWebKitAPI/PlatformEfl.cmake:
96         * TestWebKitAPI/PlatformGTK.cmake:
97         * WebKitTestRunner/PlatformEfl.cmake:
98         * WebKitTestRunner/PlatformGTK.cmake:
99
100 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
101
102         [Mac] Unreviewed test fix after r182584
103         https://bugs.webkit.org/show_bug.cgi?id=143452
104
105         Put both of these tests back to their original state now that the underlying
106         problem is fixed.
107
108         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
109         (TestWebKitAPI::TEST):
110         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
111         (TestWebKitAPI::TEST):
112
113 2015-04-08  Filip Pizlo  <fpizlo@apple.com>
114
115         run-jsc-benchmarks geomean of preferred means shouldn't print the VMs header twice
116         https://bugs.webkit.org/show_bug.cgi?id=143553
117
118         Reviewed by Ryosuke Niwa.
119         
120         Remove the spurious printVMs left over from an earlier change.
121
122         * Scripts/run-jsc-benchmarks:
123
124 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
125
126         [Mac] Unreviewed test fix after r182581
127
128         The behavior of control-left-click is controlled by a system preference.
129         Our test bots have this turned off.
130
131         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
132         (TestWebKitAPI::TEST):
133         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
134         (TestWebKitAPI::TEST):
135
136 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
137
138         [Mac] WebKit is not honoring OS preferences for secondary click behaviors
139         https://bugs.webkit.org/show_bug.cgi?id=143452
140         <rdar://problem/20437483>
141
142         Reviewed by Tim Horton.
143
144         Add a new API test to confirm that Cocoa mouse button press events are properly
145         tagged with the desired menu behavior (i.e., 'None', 'Context', or 'Action'.)
146
147         The WK2 test dispatches mouse down events to a PlatformWebView, and checks with
148         some registered event handlers that the expected button press and context menu
149         events are received.
150
151         The WK1 unit test creates an NSEvent with the desired button press state, and then
152         uses WebCore::PlatformEventFactory::createPlatformMouseEvent to create a WebCore event.
153         We check the resulting PlatformMouseEvent for proper state.
154
155         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test files.
156         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp: Added.
157         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
158         * TestWebKitAPI/Tests/WebKit2/mouse-button-listener.html: Added.
159         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm: Added.
160         (TestWebKitAPI::canCallMenuTypeForEvent): Helper function.
161         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
162         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
163         (TestWebKitAPI::PlatformWebView::simulateButtonClick): Added method to support firing
164         mouse down events.
165         * TestWebKitAPI/mac/PlatformWebViewMac.h:
166
167 2015-04-08  Michael Catanzaro  <mcatanzaro@igalia.com>
168
169         [GTK] Add pango to jhbuild-optional.modules
170         https://bugs.webkit.org/show_bug.cgi?id=143537
171
172         Reviewed by Martin Robinson.
173
174         * gtk/jhbuild-optional.modules: Add pango.
175
176 2015-04-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
177
178         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 22.
179         https://bugs.webkit.org/show_bug.cgi?id=143530
180
181         Reviewed by Žan Doberšek.
182
183         Assume that the default value for display (:0) is reserved and start checking on :1
184         Adjust webkitpy test and include two new test cases for this bug (display number not specified)
185         and for X server named Xorg.bin (previous bug 1376599)
186
187         * Scripts/webkitpy/port/xvfbdriver.py:
188         (XvfbDriver._next_free_display)
189         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
190         (XvfbDriverTest.test_start_no_pixel_tests):
191         (XvfbDriverTest.test_start_pixel_tests):
192         (XvfbDriverTest.test_start_arbitrary_worker_number):
193         (XvfbDriverTest.test_next_free_display):
194         (XvfbDriverTest.test_start_next_worker):
195 2015-04-08  Alex Christensen  <achristensen@webkit.org>
196
197         Block popups from content extensions.
198         https://bugs.webkit.org/show_bug.cgi?id=143497
199
200         Reviewed by Brady Eidson.
201
202         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
203         (TestWebKitAPI::TEST_F):
204         Added popup test.
205
206 2015-04-08  Alex Christensen  <achristensen@webkit.org> and Patrick Gansterer  <paroga@webkit.org>
207
208         Add CMake build system for WinCairo port.
209         https://bugs.webkit.org/show_bug.cgi?id=115944
210
211         Reviewed by Chris Dumez.
212
213         * CMakeLists.txt:
214         * WinLauncher/CMakeLists.txt: Added.
215
216 2015-04-08  Carlos Garcia Campos  <cgarcia@igalia.com>
217
218         [GTK] Crash in DOMObjectCache when a wrapped object owned by the cache is unreffed by the user
219         https://bugs.webkit.org/show_bug.cgi?id=143521
220
221         Reviewed by Martin Robinson.
222
223         Add a way to detect unexpected web process crashes to WebViewTest,
224         and a test case to testDOMCache to trigger the crash.
225
226         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
227         (WebKitDOMNodeTest::testDOMCache):
228         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
229         (testWebKitWebViewProcessCrashed):
230         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
231         (WebViewTest::WebViewTest):
232         (WebViewTest::webProcessCrashed):
233         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
234
235 2015-04-07  Alexey Proskuryakov  <ap@apple.com>
236
237         PageVisibilityStateWithWindowChanges should only be enabled on Yosemite
238         rdar://problem/20461342
239
240         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
241
242 2015-04-07  Commit Queue  <commit-queue@webkit.org>
243
244         Unreviewed, rolling out r182511.
245         https://bugs.webkit.org/show_bug.cgi?id=143507
246
247         caused debug test failures (Requested by alexchristensen on
248         #webkit).
249
250         Reverted changeset:
251
252         "Block popups from content extensions."
253         https://bugs.webkit.org/show_bug.cgi?id=143497
254         http://trac.webkit.org/changeset/182511
255
256 2015-04-07  Alex Christensen  <achristensen@webkit.org>
257
258         Block popups from content extensions.
259         https://bugs.webkit.org/show_bug.cgi?id=143497
260
261         Reviewed by Brady Eidson.
262
263         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
264         (TestWebKitAPI::TEST_F):
265         Added popup test.
266
267 2015-04-07  Benjamin Poulain  <benjamin@webkit.org>
268
269         Get the features.json files ready for open contributions
270         https://bugs.webkit.org/show_bug.cgi?id=143436
271
272         Reviewed by Darin Adler.
273
274         * Scripts/webkitpy/style/checkers/jsonchecker.py:
275         (JSONFeaturesChecker.check):
276         Extend the syntax checking a bit, but leave everything non-mandatory
277         very loose until we figure what fields are important.
278
279 2015-04-07  Tim Horton  <timothy_horton@apple.com>
280
281         Expose and test fixedLayoutSize via modern WebKit SPI
282         https://bugs.webkit.org/show_bug.cgi?id=143500
283
284         Reviewed by Simon Fraser.
285
286         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
287         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Added.
288         (-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]):
289         (TEST):
290         Add a test that verifies that fixedLayoutSize works at all, that
291         it persists through a navigation, and that turning it back off reverts to
292         laying out at the size of the view.
293
294 2015-04-07  Michael Catanzaro  <mcatanzaro@igalia.com>
295
296         Unreviewed. Add myself as a committer.
297
298         * Scripts/webkitpy/common/config/contributors.json:
299
300 2015-04-07  Brent Fulgham  <bfulgham@apple.com>
301
302         [Win] Bots complain about missing /etc/catalog
303         https://bugs.webkit.org/show_bug.cgi?id=143484
304
305         Reviewed by Chris Dumez.
306
307         The libxml2 build on Mac, iOS, and Windows does not provide the set
308         of default catalog files. We do not actually need these for our
309         purposes, but we get warnings and some bot flakiness because they
310         are not present.
311
312         We can avoid both problems the same way the Mac and iOS ports do,
313         by setting the XML_CATALOG_FILES environment variable to 'empty string',
314         which avoid the warnings and bot problems.
315
316         * Scripts/webkitpy/port/win.py:
317         (WinPort.setup_environ_for_server): Added.
318
319 2015-04-06  Sam Weinig  <sam@webkit.org>
320
321         Use content extensions in MiniBrowser.
322         https://bugs.webkit.org/show_bug.cgi?id=143446
323
324         Reviewed by Alex Christensen.
325
326         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
327         * MiniBrowser/mac/AppDelegate.h:
328         * MiniBrowser/mac/AppDelegate.m:
329         (-[BrowserAppDelegate init]):
330         (-[BrowserAppDelegate showExtensionsManager:]):
331         (-[BrowserAppDelegate userContentContoller]):
332         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
333         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
334         (-[ExtensionManagerWindowController init]):
335         (-[ExtensionManagerWindowController windowDidLoad]):
336         (-[ExtensionManagerWindowController add:]):
337         (-[ExtensionManagerWindowController remove:]):
338         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
339         * MiniBrowser/mac/MainMenu.xib:
340
341 2015-04-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
342
343         web-platform-tests server should retrieve the modules file relatively to its docroot path
344         https://bugs.webkit.org/show_bug.cgi?id=142742
345
346         Reviewed by Darin Adler.
347
348         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
349         (WebPlatformTestServer._install_modules): Compute the modules description file path according wpt server doc root path.
350
351 2015-04-06  Commit Queue  <commit-queue@webkit.org>
352
353         Unreviewed, rolling out r182445.
354         https://bugs.webkit.org/show_bug.cgi?id=143459
355
356         broke 32 bit build (Requested by alexchristensen on #webkit).
357
358         Reverted changeset:
359
360         "Use content extensions in MiniBrowser."
361         https://bugs.webkit.org/show_bug.cgi?id=143446
362         http://trac.webkit.org/changeset/182445
363
364 2015-04-06  Sam Weinig  <sam@webkit.org>
365
366         Use content extensions in MiniBrowser.
367         https://bugs.webkit.org/show_bug.cgi?id=143446
368
369         Reviewed by Alex Christensen.
370
371         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
372         * MiniBrowser/mac/AppDelegate.h:
373         * MiniBrowser/mac/AppDelegate.m:
374         (-[BrowserAppDelegate init]):
375         (-[BrowserAppDelegate showExtensionsManager:]):
376         (-[BrowserAppDelegate userContentContoller]):
377         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
378         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
379         (-[ExtensionManagerWindowController init]):
380         (-[ExtensionManagerWindowController windowDidLoad]):
381         (-[ExtensionManagerWindowController add:]):
382         (-[ExtensionManagerWindowController remove:]):
383         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
384         * MiniBrowser/mac/MainMenu.xib:
385
386 2015-04-06  Michael Catanzaro  <mcatanzaro@gnome.org>
387
388         [GTK] install-dependencies should prefer dnf to yum
389         https://bugs.webkit.org/show_bug.cgi?id=143441
390
391         Reviewed by Martin Robinson.
392
393         Test for the existance of dnf before yum, and only try to use yum if dnf does not exist.
394
395         * gtk/install-dependencies:
396
397 2015-04-06  Andy Estes  <aestes@apple.com>
398
399         [iOS] 'make clean' fails in Tools/WebKitTestRunner
400         https://bugs.webkit.org/show_bug.cgi?id=143455
401
402         Reviewed by Dan Bernstein.
403
404         This Makefile adds '-target WebKitTestRunnerApp' to OTHER_OPTIONS during iOS builds, but the top-level
405         Makefile.shared adds '-alltargets' for clean builds, and xcodebuild does not allow both -target and -alltargets.
406
407         * WebKitTestRunner/Makefile: Don't add '-target WebKitTestRunerApp' to OTHER_OPTIONS on clean builds.
408
409 2015-04-06  Alexey Proskuryakov  <ap@apple.com>
410
411         WebKit1.SetAndUpdateCacheModelPreferencesChangeMix fails on some machines
412         https://bugs.webkit.org/show_bug.cgi?id=143450
413
414         Reviewed by Anders Carlsson.
415
416         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: (TestWebKitAPI::TEST):
417         Make sure that the view is actually closed, regardless of anything else that happens beneath.
418         Also, removed unnecessary get() calls.
419
420 2015-04-03  Alexey Proskuryakov  <ap@apple.com>
421
422         Reduce the dependency on Flash in regression tests
423         https://bugs.webkit.org/show_bug.cgi?id=143391
424
425         Reviewed by Anders Carlsson.
426
427         * WebKitTestRunner/TestController.cpp: (WTR::TestController::decidePolicyForPluginLoad):
428         Only allow QuickTime and the test plug-in.
429
430 2015-04-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
431
432         W3C test importer should generate the modules installed dynamically to run wpt tests
433         https://bugs.webkit.org/show_bug.cgi?id=142738
434
435         Reviewed by Ryosuke Niwa.
436
437         The test importer can now generate the submodules description file based on information extracted from the corresponding git repository.
438         The implementation is done within TestDownloader and it is activated for the WPT repository.
439         LayoutTests/imported/w3c/resources/WPTModules is renamed as LayoutTests/imported/w3c/resources/web-platform-tests-modules.json for that reason.
440
441         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
442         (WebPlatformTestServer._install_modules): Updated to cope with path as array.
443         * Scripts/webkitpy/w3c/test_downloader.py:
444         (TestDownloader._git_submodules_status): Added so that it can be overriden for unit tests.
445         (TestDownloader):
446         (TestDownloader._git_submodules_description): Computes submodule description.
447         (TestDownloader.generate_git_submodules_description): Write submodule description in a file.
448         * Scripts/webkitpy/w3c/test_importer.py:
449         (TestImporter.do_import): Added the possibility to post process the tests.
450         (TestImporter):
451         (TestImporter.generate_git_submodules_description_for_all_repositories): Enable generating module description file.
452         (TestImporter.should_convert_test_harness_links): Updated according new options format.
453         * Scripts/webkitpy/w3c/test_importer_unittest.py:
454         (TestImporterTest.import_downloaded_tests): Making use of TestDownloaderMock. 
455         (TestImporterTest.import_downloaded_tests.TestDownloaderMock): Added to override submodule status gathering.
456         (TestImporterTest.import_downloaded_tests.TestDownloaderMock.__init__):
457         (TestImporterTest.import_downloaded_tests.TestDownloaderMock._git_submodules_status):
458         (TestImporterTest.test_submodules_generation): Added to check that modules description files works.
459
460 2015-04-05  Antti Koivisto  <antti@apple.com>
461
462         Bloom filter should support longer hashes
463         https://bugs.webkit.org/show_bug.cgi?id=143419
464
465         Reviewed by Dan Bernstein.
466
467         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp:
468         (TestWebKitAPI::generateRandomDigests):
469         (TestWebKitAPI::TEST):
470
471 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
472
473         run-jsc-stress-tests --remote should add libllvmForJSC.so to the bundle on Linux
474         https://bugs.webkit.org/show_bug.cgi?id=143372
475
476         Reviewed by Darin Adler.
477
478         * Scripts/run-jsc-stress-tests:
479
480 2015-04-03  Antti Koivisto  <antti@apple.com>
481
482         Add non-counting bloom filter class
483         https://bugs.webkit.org/show_bug.cgi?id=143366
484
485         Reviewed by Sam Weinig.
486
487         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
488         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp: Added.
489         (TestWebKitAPI::generateRandomHashes):
490         (TestWebKitAPI::TEST):
491
492 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
493
494         FTL JIT tests should fail if LLVM library isn't available
495         https://bugs.webkit.org/show_bug.cgi?id=143374
496
497         Reviewed by Mark Lam.
498
499         * Scripts/run-jsc-stress-tests:
500
501 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
502
503         [EFL] Speedup jhbuild with disable running autogen.sh
504         https://bugs.webkit.org/show_bug.cgi?id=143369
505
506         Reviewed by Gyuyoung Kim.
507
508         * efl/jhbuild.modules:
509
510 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
511
512         filter-webkit-build should filter out "created by an unsupported XCDependencyGraph build" lines
513         https://bugs.webkit.org/show_bug.cgi?id=143282
514
515         Reviewed by Daniel Bates.
516
517         * Scripts/filter-build-webkit: (shouldIgnoreLine): Do it.
518
519 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
520
521         When LayoutTestHelper fails to start, we continue to run the tests, ending up with mysterious failures
522         https://bugs.webkit.org/show_bug.cgi?id=143240
523         rdar://problem/19990425
524
525         Reviewed by Tim Horton.
526
527         * DumpRenderTree/mac/LayoutTestHelper.m:
528         (colorProfileURLForDisplay):
529         (saveDisplayColorProfiles):
530         Gracefully handle it when the current profile cannot be retrieved, fixing at
531         least one case when LayoutTestHelper couldn't start.
532
533         * Scripts/webkitpy/layout_tests/controllers/manager.py:
534         (Manager._set_up_run):
535         (Manager._force_pixel_tests_if_needed):
536         * Scripts/webkitpy/port/base.py: (Port.to.start_helper):
537         * Scripts/webkitpy/port/mac.py: (MacPort.start_helper):
538         Return and check an error from start_helper().
539
540 2015-04-01  Brent Fulgham  <bfulgham@apple.com>
541
542         [Win] Run test-webkitpy as part of EWS (just like we do on other platforms)
543         https://bugs.webkit.org/show_bug.cgi?id=143321
544
545         Reviewed by Alexey Proskuryakov.
546
547         * EWSTools/start-queue-win.sh: Add commands to run 'test-webkitpy' during processing loop.
548
549 2015-04-01  Enrica Casucci  <enrica@apple.com>
550
551         Injected bundle messages should be at the page level.
552         https://bugs.webkit.org/show_bug.cgi?id=143283
553
554         Reviewed by Alexey Proskuryakov.
555
556         Updating WebKitTestRunner to use the new page level messaging.
557         The author of this patch is Tim Horton, I just finished it.
558
559         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
560         (WTR::EventSendingController::mouseDown):
561         (WTR::EventSendingController::mouseUp):
562         (WTR::EventSendingController::mouseMoveTo):
563         (WTR::EventSendingController::leapForward):
564         (WTR::EventSendingController::scheduleAsynchronousClick):
565         (WTR::EventSendingController::keyDown):
566         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
567         (WTR::EventSendingController::mouseScrollBy):
568         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
569         (WTR::EventSendingController::continuousMouseScrollBy):
570         (WTR::EventSendingController::addTouchPoint):
571         (WTR::EventSendingController::updateTouchPoint):
572         (WTR::EventSendingController::setTouchModifier):
573         (WTR::EventSendingController::setTouchPointRadius):
574         (WTR::EventSendingController::touchStart):
575         (WTR::EventSendingController::touchMove):
576         (WTR::EventSendingController::touchEnd):
577         (WTR::EventSendingController::touchCancel):
578         (WTR::EventSendingController::clearTouchPoints):
579         (WTR::EventSendingController::releaseTouchPoint):
580         (WTR::EventSendingController::cancelTouchPoint):
581         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
582         (WTR::InjectedBundle::didReceiveMessage):
583         (WTR::InjectedBundle::didReceiveMessageToPage):
584         (WTR::InjectedBundle::done):
585         (WTR::InjectedBundle::outputText):
586         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
587         (WTR::InjectedBundle::postAddChromeInputField):
588         (WTR::InjectedBundle::postRemoveChromeInputField):
589         (WTR::InjectedBundle::postFocusWebView):
590         (WTR::InjectedBundle::postSetBackingScaleFactor):
591         (WTR::InjectedBundle::postSetWindowIsKey):
592         (WTR::InjectedBundle::postSimulateWebNotificationClick):
593         (WTR::InjectedBundle::postSetAddsVisitedLinks):
594         (WTR::InjectedBundle::setGeolocationPermission):
595         (WTR::InjectedBundle::setMockGeolocationPosition):
596         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
597         (WTR::InjectedBundle::setUserMediaPermission):
598         (WTR::InjectedBundle::setCustomPolicyDelegate):
599         (WTR::InjectedBundle::setHidden):
600         (WTR::InjectedBundle::setCacheModel):
601         (WTR::InjectedBundle::shouldProcessWorkQueue):
602         (WTR::InjectedBundle::processWorkQueue):
603         (WTR::InjectedBundle::queueBackNavigation):
604         (WTR::InjectedBundle::queueForwardNavigation):
605         (WTR::InjectedBundle::queueLoad):
606         (WTR::InjectedBundle::queueLoadHTMLString):
607         (WTR::InjectedBundle::queueReload):
608         (WTR::InjectedBundle::queueLoadingScript):
609         (WTR::InjectedBundle::queueNonLoadingScript):
610         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
611         (WTR::TestRunner::setHandlesAuthenticationChallenges):
612         (WTR::TestRunner::setAuthenticationUsername):
613         (WTR::TestRunner::setAuthenticationPassword):
614         (WTR::TestRunner::secureEventInputIsEnabled):
615         (WTR::TestRunner::setBlockAllPlugins):
616         * WebKitTestRunner/TestController.cpp:
617         (WTR::TestController::createWebViewWithOptions):
618         (WTR::TestController::resetStateToConsistentValues):
619         (WTR::TestController::didReceivePageMessageFromInjectedBundle):
620         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle):
621         * WebKitTestRunner/TestController.h:
622         * WebKitTestRunner/TestInvocation.cpp:
623         (WTR::TestInvocation::invoke):
624         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
625
626 2015-04-01  Commit Queue  <commit-queue@webkit.org>
627
628         Unreviewed, rolling out r182174 and r182177.
629         https://bugs.webkit.org/show_bug.cgi?id=143314
630
631         Try to correct EWS failures (Requested by bfulgham on
632         #webkit).
633
634         Reverted changesets:
635
636         "Python SCM should be able to retrieve untracked files"
637         https://bugs.webkit.org/show_bug.cgi?id=143135
638         http://trac.webkit.org/changeset/182174
639
640         "[buildbot] clean-build script should remove untracked files
641         and revert local changes too"
642         https://bugs.webkit.org/show_bug.cgi?id=142400
643         http://trac.webkit.org/changeset/182177
644
645 2015-04-01  Alex Christensen  <achristensen@webkit.org>
646
647         [Content Extensions] Properly handle regexes that match everything.
648         https://bugs.webkit.org/show_bug.cgi?id=143281
649
650         Reviewed by Benjamin Poulain.
651
652         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
653         (TestWebKitAPI::testRequest):
654         (TestWebKitAPI::makeBackend):
655         (TestWebKitAPI::TEST_F):
656         Removed duplicate code and added test.
657
658 2015-03-31  Benjamin Poulain  <bpoulain@apple.com>
659
660         Content Extensions: split the state machines to minimize prefix states
661         https://bugs.webkit.org/show_bug.cgi?id=143253
662
663         Reviewed by Alex Christensen.
664
665         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
666         (TestWebKitAPI::TEST_F):
667         (TestWebKitAPI::testPatternStatus):
668
669 2015-03-31  Yusuke Suzuki  <utatane.tea@gmail.com>
670
671         Clean up Identifier factories to clarify the meaning of StringImpl*
672         https://bugs.webkit.org/show_bug.cgi?id=143146
673
674         Reviewed by Filip Pizlo.
675
676         Simple API tests for StringImpl are added.
677
678         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
679         (TestWebKitAPI::TEST):
680
681 2015-03-31  Csaba Osztrogonác  <ossy@webkit.org>
682
683         [EFL] Add AArch64 builder and tester bot to build.webkit.org
684         https://bugs.webkit.org/show_bug.cgi?id=143092
685
686         Reviewed by Gyuyoung Kim.
687
688         * BuildSlaveSupport/build.webkit.org-config/config.json:
689         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
690         (Factory.__init__):
691         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
692
693 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
694
695         [buildbot] clean-build script should remove untracked files and revert local changes too
696         https://bugs.webkit.org/show_bug.cgi?id=142400
697
698         Reviewed by Ryosuke Niwa.
699
700         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
701         A helper routine SCM.discard_untracked_files is added for that purpose.
702
703         * BuildSlaveSupport/clean-build:
704         (main): Making call to Scripts/clean-webkit
705         * Scripts/clean-webkit: Added.
706         (main): Revert changes and delete untracked files.
707         * Scripts/webkitpy/common/checkout/scm/scm.py:
708         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
709         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
710         (SCMTest._shared_test_discard_untracked_files):
711         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
712
713 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
714
715         Python SCM should be able to retrieve untracked files
716         https://bugs.webkit.org/show_bug.cgi?id=143135
717
718         Reviewed by Ryosuke Niwa.
719
720         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
721         Ignored files may be included or not in this list according boolean passed to the function.
722
723         * Scripts/webkitpy/common/checkout/scm/git.py:
724         (Git.untracked_files):
725         * Scripts/webkitpy/common/checkout/scm/scm.py:
726         (SCM.untracked_files):
727         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
728         (SCMTest._shared_test_untracked_files):
729         (test_untracked_files):
730         (GitSVNTest.test_untracked_files):
731         * Scripts/webkitpy/common/checkout/scm/svn.py:
732         (SVN.untracked_files):
733
734 2015-03-30  Alex Christensen  <achristensen@webkit.org>
735
736         [Content Extensions] Correctly handle regular expressions matching everything
737         https://bugs.webkit.org/show_bug.cgi?id=143235
738
739         Reviewed by Benjamin Poulain.
740
741         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
742         (TestWebKitAPI::checkCompilerError):
743         (TestWebKitAPI::TEST_F):
744         Test ContentExtensionErrors.
745
746 2015-03-30  Alexey Proskuryakov  <ap@apple.com>
747
748         DumpRenderTree should set NSWindowDisplayWithRunLoopObserver
749         https://bugs.webkit.org/show_bug.cgi?id=143241
750         rdar://problem/20351297
751
752         Reviewed by Mark Lam.
753
754         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
755
756 2015-03-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
757
758         [CMake][EFL] Remove redundant library link and include path
759         https://bugs.webkit.org/show_bug.cgi?id=143221
760
761         Reviewed by Csaba Osztrogonác.
762
763         * ImageDiff/PlatformEfl.cmake: Remove unnecessary library link and include path.
764
765 2015-03-30  Sam Weinig  <sam@webkit.org>
766
767         [Content Extensions] Flesh out the UserContentExtensionStore
768         https://bugs.webkit.org/show_bug.cgi?id=143123
769
770         Reviewed by Benjamin Poulain.
771
772         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
773         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: Added.
774         Add tests for _WKUserContentExtensionStore.
775
776 2015-03-30  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
777
778         Update install-dependencies Fedora packages after r181624
779         https://bugs.webkit.org/show_bug.cgi?id=143215
780
781         Add json-glib, libv4l, openssl and pulseaudio development packages to
782         the Fedora list providing we need them to build WebKit dependencies
783         for this distribution.
784
785         Reviewed by Philippe Normand.
786
787         * gtk/install-dependencies:
788
789 2015-03-30  Commit Queue  <commit-queue@webkit.org>
790
791         Unreviewed, rolling out r182119.
792         https://bugs.webkit.org/show_bug.cgi?id=143196
793
794         problem with syntax (Requested by youenn on #webkit).
795
796         Reverted changeset:
797
798         "[buildbot] clean-build script should remove untracked files
799         and revert local changes too"
800         https://bugs.webkit.org/show_bug.cgi?id=142400
801         http://trac.webkit.org/changeset/182119
802
803 2015-03-30  Benjamin Poulain  <benjamin@webkit.org>
804
805         Start the features.json files
806         https://bugs.webkit.org/show_bug.cgi?id=143207
807
808         Reviewed by Darin Adler.
809
810         I kept the style checking light. We'll have to figure
811         what is the best format for each field.
812
813         * Scripts/webkitpy/style/checker.py:
814         (CheckerDispatcher._create_checker):
815         * Scripts/webkitpy/style/checkers/jsonchecker.py:
816         (JSONContributorsChecker.check):
817         (JSONFeaturesChecker):
818         (JSONFeaturesChecker.check):
819
820 2015-03-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
821
822         [buildbot] clean-build script should remove untracked files and revert local changes too
823         https://bugs.webkit.org/show_bug.cgi?id=142400
824
825         Reviewed by Ryosuke Niwa.
826
827         This patch cleans the WebKit folder by deleting SCM untracked files and reverting changes for tracked files.
828
829         * BuildSlaveSupport/clean-build:
830         (main): Adding call to Tools/Scripts/clean-webkit.
831         * Scripts/clean-webkit: Added.
832         (main): Removes untracked and changed files.
833         * Scripts/webkitpy/common/checkout/scm/git.py:
834         (Git.untracked_files): Retrieves GIT untracked files.
835         * Scripts/webkitpy/common/checkout/scm/scm.py:
836         (SCM.untracked_files): Retrieves SVN untracked files.
837         (SCM):
838         (SCM.discard_untracked_files): Deletes untracked files/folders.
839         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
840         (SCMTest._shared_test_untracked_files): Unit testing for untracked files.
841         (test_untracked_files):
842         (GitSVNTest.test_untracked_files):
843         * Scripts/webkitpy/common/checkout/scm/svn.py:
844         (SVN.untracked_files):
845
846 2015-03-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
847
848         [CMake] Remove unnecessary INCLUDE_IF_EXISTS macro 
849         https://bugs.webkit.org/show_bug.cgi?id=143138
850
851         Reviewed by Csaba Osztrogonác.
852
853         INCLUDE_IF_EXISTS isn't used except for 2 places. However those uses can
854         be replaced with WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS.
855
856         * ImageDiff/CMakeLists.txt:
857         Use WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS() instead of INCLUDE_IF_EXISTS.
858         * WebKitTestRunner/CMakeLists.txt: ditto.
859
860 2015-03-27  Myles C. Maxfield  <mmaxfield@apple.com>
861
862         Support building WTF on Windows without Cygwin
863         https://bugs.webkit.org/show_bug.cgi?id=143084
864
865         Reviewed by Brent Fulgham.
866
867         Windows without Cygwin doesn't have curl, unzip, or grep. Luckily, Perl does all of these things.
868         This patch also migrates to using File::Spec->catfile() for directory separators.
869
870         * Scripts/update-webkit-dependency:
871         (wanted):
872         * Scripts/update-webkit-support-libs:
873         (wanted):
874         (downloadExpectedVersionNumber):
875         (zipFileVersion):
876         (toUnixPath): Deleted.
877         * Scripts/webkitdirs.pm:
878         (determineSourceDir):
879         (windowsSourceSourceDir):
880         (windowsLibrariesDir):
881         (windowsOutputDir):
882         (checkInstalledTools):
883         (buildVisualStudioProject):
884
885 2015-03-27  Alex Christensen  <achristensen@webkit.org>
886
887         Fix WinCairo bot.
888         https://bugs.webkit.org/show_bug.cgi?id=143086
889
890         Reviewed by Brent Fulgham.
891
892         * Scripts/webkitdirs.pm:
893         (buildVisualStudioProject):
894         (runSvnUpdateAndResolveChangeLogs):
895         Use ActivePerl-friendly perl.
896
897 2015-03-27  Csaba Osztrogonác  <ossy@webkit.org>
898
899         URTBF after r182059 to fix the EFL build.
900
901         * TestWebKitAPI/CMakeLists.txt:
902
903 2015-03-26  Alexey Proskuryakov  <ap@apple.com>
904
905         Layout test results URL loads in WK1 but not WK2 minibrowser
906         https://bugs.webkit.org/show_bug.cgi?id=143117
907
908         Reviewed by Tim Horton.
909
910         * MiniBrowser/mac/WK2BrowserWindowController.m:
911         (-[WK2BrowserWindowController fetch:]): Fix this, international domain names, and
912         everything.
913         (-[WK2BrowserWindowController updateTextFieldFromURL:]): Ditto.
914
915 2015-03-26  Jer Noble  <jer.noble@apple.com>
916
917         Add --allowed-host support to run-webkit-tests
918         https://bugs.webkit.org/show_bug.cgi?id=142938
919
920         Reviewed by Brent Fulgham.
921
922         Accept --allowed-host arguments from run-webkit-tests and pass them through to
923         DumpRenderTree and WebKitTestRunner.
924
925         Drive-by fix: Depending on the value of the --layout-test-dir parameter, layout test results
926         are placed in the wrong location. The argument is compared with each tests's path, and if a
927         relative path or a path with '..' was used, results are placed alongside the test. Take the
928         absolute path of the --layout-test-dir argument, collapsing path components like '..'.
929
930         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
931         (parse_args):
932         * Scripts/webkitpy/port/base.py:
933         (Port.__init__):
934         (Port.allowed_hosts):
935         * Scripts/webkitpy/port/driver.py:
936         (Driver.cmd_line):
937
938 2015-03-26  Jer Noble  <jer.noble@apple.com>
939
940         [Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connect to non-localhost servers
941         https://bugs.webkit.org/show_bug.cgi?id=142931
942
943         Reviewed by Brent Fulgham.
944
945         Currently, both DRT and WKTR will refuse to allow network connections to non-localhost servers
946         over HTTP/HTTPS. For certain testing scenarios, however, it would be useful if both DRT and
947         WKTR could be allowed to make HTTP/HTTPS connections to certain, specific servers defined at
948         runtime.
949
950         To allow this, add an optional argument to DRT and WKTR, --allowed-host, which will add the specified
951         hostname to a whitelist; requests to these hosts will allowed to proceed normally.
952
953         Drive-by fix: in InjectedBundlePage::willSendRequestForFrame, we get the top loading frame from the
954         injected bundle. But after the main resource load completes, the bundle nulls out it's pointer to the
955         top loading frame, which causes a subsequent crash when further resources are requested. Instead, get
956         the top loading frame from the page, as we do elsewhere in this class.
957
958         * DumpRenderTree/TestRunner.h:
959         (TestRunner::allowedHosts):
960         (TestRunner::setAllowedHosts):
961         * DumpRenderTree/mac/DumpRenderTree.mm:
962         (initializeGlobalsFromCommandLineOptions):
963         (runTest):
964         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
965         (isAllowedHost):
966         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
967         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
968         (WTR::InjectedBundle::didReceiveMessage):
969         (WTR::InjectedBundle::isAllowedHost):
970         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
971         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
972         (WTR::isAllowedHost):
973         (WTR::InjectedBundlePage::willSendRequestForFrame):
974         * WebKitTestRunner/InjectedBundle/TestRunner.h:
975         * WebKitTestRunner/Options.cpp:
976         (WTR::handleOptionAllowedHost):
977         (WTR::OptionsHandler::OptionsHandler):
978         * WebKitTestRunner/Options.h:
979         * WebKitTestRunner/TestController.cpp:
980         (WTR::TestController::initialize):
981         (WTR::TestController::resetStateToConsistentValues):
982         * WebKitTestRunner/TestController.h:
983
984 2015-03-26  Brady Eidson  <beidson@apple.com>
985
986         Apply ContentExtension actions after redirects.
987         <rdar://problem/20062613> and https://bugs.webkit.org/show_bug.cgi?id=143055
988
989         Reviewed by Alex Christensen.
990
991         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
992         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Dump the fact that the load error is kWKErrorCodeCannotShowURL
993           which is specifically interesting to a new test.
994
995 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
996
997         [EFL] Disable building libseccomp on AArch64
998         https://bugs.webkit.org/show_bug.cgi?id=143094
999
1000         Reviewed by Gyuyoung Kim.
1001
1002         * efl/jhbuildrc:
1003
1004 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
1005
1006         [jhbuild] git should use only 1 thread for cloning jhbuild
1007         https://bugs.webkit.org/show_bug.cgi?id=143095
1008
1009         Reviewed by Gyuyoung Kim.
1010
1011         * jhbuild/jhbuild-wrapper:
1012         (clone_jhbuild):
1013
1014 2015-03-25  Joseph Pecoraro  <pecoraro@apple.com>
1015
1016         Update prepare-ChangeLog to work with ES6 Class syntax
1017         https://bugs.webkit.org/show_bug.cgi?id=143069
1018
1019         Reviewed by Timothy Hatcher.
1020
1021         * Scripts/prepare-ChangeLog:
1022         (get_function_line_ranges_for_javascript):
1023         Better handle ES6 Class syntax.
1024
1025         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
1026         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
1027         (BaseClass):
1028         (DerivedClass):
1029         (DerivedClass.staticMethod):
1030         (DerivedClass.prototype.method.nestedFunctionInsideMethod):
1031         (DerivedClass.prototype.method):
1032         (DerivedClass.prototype.get getter):
1033         (namespace.MyClass):
1034         (namespace.MyClass.staticMethod):
1035         (namespace.MyClass.prototype.method.nestedFunctionInsideMethod):
1036         (namespace.MyClass.prototype.method):
1037         (namespace.MyClass.prototype.get getter):
1038         Proof!
1039
1040 2015-03-25  Filip Pizlo  <fpizlo@apple.com>
1041
1042         Use JITCompilationCanFail in more places, and make the fail path of JITCompilationMustSucceed a crash instead of attempting GC
1043         https://bugs.webkit.org/show_bug.cgi?id=142993
1044
1045         Reviewed by Mark Lam.
1046         
1047         Bunch of support for testing executable allocation failure.
1048
1049         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz: Added.
1050         (fail):
1051         * Scripts/run-javascriptcore-tests:
1052         (runJSCStressTests):
1053         * Scripts/run-jsc-stress-tests:
1054
1055 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
1056
1057         Fix Windows build from r181977.
1058
1059         Unreviewed.
1060
1061         * Scripts/update-webkit-dependency:
1062
1063 2015-03-25  Sam Weinig  <sam@webkit.org>
1064
1065         Address additional review feedback from https://bugs.webkit.org/show_bug.cgi?id=143059.
1066
1067         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1068         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1069
1070 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
1071
1072         Migrate update-webkit for Windows to not require Cygwin
1073         https://bugs.webkit.org/show_bug.cgi?id=143040
1074
1075         Reviewed by Brent Fulgham.
1076
1077         * Scripts/update-webkit-dependency:
1078         (wanted):
1079         (toUnixPath): Deleted.
1080         * Scripts/webkitdirs.pm:
1081         (fontExists):
1082         (checkInstalledTools):
1083         (setupAppleWinEnv):
1084
1085 2015-03-25  Sam Weinig  <sam@webkit.org>
1086
1087         [Content Extensions] Convert content extension compiling to return error codes and write its output using a client
1088         https://bugs.webkit.org/show_bug.cgi?id=143059
1089
1090         Reviewed by Alex Christensen.
1091
1092         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1093         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1094         Update for new interface of compileRuleList().
1095
1096 2015-03-25  Alex Christensen  <achristensen@webkit.org>
1097
1098         [Content Extensions] Add multi-DFA compiling and interpreting.
1099         https://bugs.webkit.org/show_bug.cgi?id=143010
1100
1101         Reviewed by Benjamin Poulain.
1102
1103         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1104         (TestWebKitAPI::testRequest):
1105         (TestWebKitAPI::TEST_F):
1106         Add some tests for ignore-previous-rules and large rulesets.
1107
1108 2015-03-25  Alexey Proskuryakov  <ap@apple.com>
1109
1110         Mavericks WK1 still runs JSC tests
1111         https://bugs.webkit.org/show_bug.cgi?id=143035
1112
1113         Reviewed by Csaba Osztrogonác.
1114
1115         * BuildSlaveSupport/build.webkit.org-config/config.json: Bring Mavericks WK1 in line
1116         with other bots.
1117
1118         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated the tests
1119         accordingly.
1120
1121 2015-03-25  Commit Queue  <commit-queue@webkit.org>
1122
1123         Unreviewed, rolling out r181932.
1124         https://bugs.webkit.org/show_bug.cgi?id=143041
1125
1126         The test fails most of the time on bots (Requested by ap on
1127         #webkit).
1128
1129         Reverted changeset:
1130
1131         "[Content Extensions] Add multi-DFA compiling and
1132         interpreting."
1133         https://bugs.webkit.org/show_bug.cgi?id=143010
1134         http://trac.webkit.org/changeset/181932
1135
1136 2015-03-24  Alex Christensen  <achristensen@webkit.org>
1137
1138         [Content Extensions] Add multi-DFA compiling and interpreting.
1139         https://bugs.webkit.org/show_bug.cgi?id=143010
1140
1141         Reviewed by Benjamin Poulain.
1142
1143         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1144         (TestWebKitAPI::testRequest):
1145         (TestWebKitAPI::TEST_F):
1146         Add some tests for ignore-previous-rules and large rulesets.
1147
1148 2015-03-24  Benjamin Poulain  <bpoulain@apple.com>
1149
1150         Make URL filter patterns matching consistent and add a simple canonicalization step
1151         https://bugs.webkit.org/show_bug.cgi?id=142998
1152
1153         Reviewed by Alex Christensen.
1154
1155         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1156
1157 2015-03-24  Csaba Osztrogonác  <ossy@webkit.org>
1158
1159         [EFL] Add OpenWebRTC in jhbuild
1160         https://bugs.webkit.org/show_bug.cgi?id=142778
1161
1162         Reviewed by Gyuyoung Kim.
1163
1164         Original patch by Philippe Normand <pnormand@igalia.com>
1165
1166         * efl/install-dependencies: Dependencies for OpenWebRTC.
1167         * efl/jhbuild.modules: build OpenWebRTC, libusrsctp, libnice and
1168         the openwebrtc gst plugins.
1169
1170 2015-03-23  Brent Fulgham  <bfulgham@apple.com>
1171
1172         Regression(r181257): WTF_WorkQueue.Simple is flaky
1173         https://bugs.webkit.org/show_bug.cgi?id=142560
1174
1175         Remove the check that the refCount has returned to one after the
1176         individual tasks have completed. It's too nondeterministic when
1177         the reference count will be reduced.
1178
1179         Reviewed by Alexey Proskuryakov
1180
1181         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1182         (TestWebKitAPI::TEST): Remove test that refCount is back to 1.
1183
1184 2015-03-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1185
1186         [CMake][EFL] Put failure API test excutables into failure directory
1187         https://bugs.webkit.org/show_bug.cgi?id=142965
1188
1189         Reviewed by Csaba Osztrogonác.
1190
1191         Move failing WK2 API test executables to *bin/TestWebKitAPI/WebKit2/failure* directory.
1192
1193         * TestWebKitAPI/CMakeLists.txt: Fix a typo. Change *testBaseName* with *testName*.
1194         * TestWebKitAPI/PlatformEfl.cmake: Additionally remove unnecessary SHARED_CORE and comment for SeccompFilters test.
1195
1196 2015-03-22  Benjamin Poulain  <benjamin@webkit.org>
1197
1198         CSS Selectors: fix attribute case-insensitive matching of Contain and List
1199         https://bugs.webkit.org/show_bug.cgi?id=142932
1200
1201         Reviewed by Darin Adler.
1202
1203         Add tests for the new features and fix some existing tests using the 
1204         stringFromUTF8() utility recently added by Dhi.
1205
1206         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1207         (TestWebKitAPI::stringFromUTF8):
1208         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1209
1210 2015-03-22  Michael Catanzaro  <mcatanzaro@igalia.com>
1211
1212         [GTK] install-dependencies should install orc
1213         https://bugs.webkit.org/show_bug.cgi?id=142955
1214
1215         Reviewed by Martin Robinson.
1216
1217         Install orc, needed by openwebrtc
1218
1219         * gtk/install-dependencies:
1220
1221 2015-03-22  Benjamin Poulain  <bpoulain@apple.com>
1222
1223         Detect when url filter pattern with groups match the empty string
1224         https://bugs.webkit.org/show_bug.cgi?id=142930
1225
1226         Reviewed by Sam Weinig.
1227
1228         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1229
1230 2015-03-22  Anders Carlsson  <andersca@apple.com>
1231
1232         _WKWebsiteDataStore should clear WebSQL databases
1233         https://bugs.webkit.org/show_bug.cgi?id=142947
1234
1235         Reviewed by Sam Weinig.
1236
1237         Add a variable that keeps track of the types of data we want to operate on, for easier debugging.
1238
1239         * MiniBrowser/mac/WK2BrowserWindowController.m:
1240         (-[WK2BrowserWindowController fetchWebsiteData:]):
1241         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
1242         (-[WK2BrowserWindowController clearWebsiteData:]):
1243
1244 2015-03-20  Mark Hahnenberg  <mhahnenb@gmail.com>
1245
1246         GCTimer should know keep track of nested GC phases
1247         https://bugs.webkit.org/show_bug.cgi?id=142675
1248
1249         Reviewed by Darin Adler.
1250
1251         Adds a tool to aid in parsing the GC phase timing output into a
1252         tree-like structure based on the parent-child relationships
1253         of nested GC phases.
1254
1255         * Scripts/parse-gc-phase-timings: Added.
1256         (Timing):
1257         (Timing.__init__):
1258         (Timing.__unicode__):
1259         (Timing.__str__):
1260         (Timing.__repr__):
1261         (parse_input):
1262         (print_timing_node):
1263         (print_timing_tree):
1264         (link_parents):
1265         (main):
1266
1267 2015-03-20  Brent Fulgham  <bfulgham@apple.com>
1268
1269         [Win] Temporarily turn of EWS Windows tests while I debug the test failure.
1270
1271         * Scripts/webkitpy/common/config/ews.json:
1272
1273 2015-03-20  Philippe Normand  <pnormand@igalia.com>
1274
1275         [GTK][jhbuild] Fix flakey failures due to unstable googlecode repository
1276         https://bugs.webkit.org/show_bug.cgi?id=142867
1277
1278         Rubber-stamped by Csaba Osztrogon.
1279
1280         * gtk/jhbuild.modules: Use Ossy's libusrsctp Github fork. Also use
1281         a fixed revision for the openwebrtc-gst-plugins.
1282
1283 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
1284
1285         Unreviewed build fix. Don't try to report stats for all benchmarks.
1286         Just report the geometric mean of preferred means.
1287
1288         * Scripts/run-jsc-benchmarks:
1289
1290 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
1291
1292         run-jsc-benchmarks should only report preferred mean
1293         https://bugs.webkit.org/show_bug.cgi?id=142874
1294
1295         Reviewed by Geoffrey Garen.
1296
1297         Just collect statistics for the preferred mean.
1298
1299         * Scripts/run-jsc-benchmarks:
1300
1301 2015-03-19  Alex Christensen  <achristensen@webkit.org>
1302
1303         [Content Extensions] Test regular expression parse failures.
1304         https://bugs.webkit.org/show_bug.cgi?id=142872
1305
1306         Reviewed by Benjamin Poulain.
1307
1308         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1309         (TestWebKitAPI::testPatternStatus):
1310         (TestWebKitAPI::TEST_F):
1311         Added tests for each parsing status.
1312
1313 2015-03-19  Alex Christensen  <achristensen@webkit.org>
1314
1315         Fix API tests after r181754.
1316
1317         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1318         (TestWebKitAPI::testRequest):
1319
1320 2015-03-19  Brady Eidson  <beidson@apple.com>
1321
1322         Part of content extensions should apply css selectors
1323         https://bugs.webkit.org/show_bug.cgi?id=142604
1324
1325         Reviewed by Alex Christensen.
1326
1327         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1328         (WebCore::ContentExtensions::operator<<):
1329
1330 2015-03-19  Brent Fulgham  <bfulgham@apple.com>
1331
1332         [Win] Activate tests on EWS
1333         https://bugs.webkit.org/show_bug.cgi?id=142850
1334
1335         Reviewed by Alexey Proskuryakov.
1336
1337         * Scripts/webkitpy/common/config/ews.json: Add me as
1338         the EWS bot watcher, and activate tests.
1339
1340 2015-03-19  Csaba Osztrogonác  <ossy@webkit.org>
1341
1342         [GTK] Fix inspector userinterface related incremental build issue
1343         https://bugs.webkit.org/show_bug.cgi?id=142849
1344
1345         Reviewed by Carlos Garcia Campos.
1346
1347         * Scripts/webkitdirs.pm:
1348         (shouldRemoveCMakeCache):
1349
1350 2015-03-18  Alex Christensen  <achristensen@webkit.org>
1351
1352         [ContentExtensions] Prepare for compiling stylesheets of selectors to be used on every page.
1353         https://bugs.webkit.org/show_bug.cgi?id=142799
1354
1355         Reviewed by Brady Eidson.
1356
1357         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1358         (TestWebKitAPI::testPattern):
1359         (TestWebKitAPI::TEST_F):
1360         Start testing regex failures.
1361
1362 2015-03-18  Dhi Aurrahman  <diorahman@rockybars.com>
1363
1364         Fix StringView typos after r181525 and r181558
1365         https://bugs.webkit.org/show_bug.cgi?id=142772
1366
1367         Reviewed by Darin Adler.
1368
1369         Add some tests in [1] to cover the StringView::startsWith, 
1370         StringView::startsWithIgnoringASCIICase, StringView::endsWith and 
1371         StringView::endsWithIgnoringASCIICase implementations.
1372
1373         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1374         (TestWebKitAPI::TEST):
1375
1376 2015-03-18  Dana Burkart  <dburkart@apple.com>
1377
1378         Remove extraneous import to fix the build.
1379
1380         Unreviewed.
1381
1382         * Scripts/webkitpy/port/driver.py:
1383
1384 2015-03-18  Dana Burkart  <dburkart@apple.com>
1385
1386         ASAN_OPTIONS=allocator_may_return_null=1 needs to be set 
1387         https://bugs.webkit.org/show_bug.cgi?id=142547
1388
1389         Reviewed by Alexey Proskuryakov.
1390
1391         * Scripts/webkitpy/port/driver.py:
1392         (Driver._setup_environ_for_driver):
1393
1394 2015-03-18  Alexey Proskuryakov  <ap@apple.com>
1395
1396         Tweak how AppleSystemFontOSSubversion default is added
1397         https://bugs.webkit.org/show_bug.cgi?id=142835
1398
1399         Reviewed by Dan Bernstein.
1400
1401         * DumpRenderTree/mac/DumpRenderTree.mm:
1402         (setDefaultsToConsistentValuesForTesting):
1403
1404 2015-03-18  Dan Bernstein  <mitz@apple.com>
1405
1406         prepare-ChangeLog doesn't understand C string literals split across multiple lines with \
1407         https://bugs.webkit.org/show_bug.cgi?id=142815
1408
1409         Reviewed by Darin Adler.
1410
1411         * Scripts/prepare-ChangeLog:
1412         (get_function_line_ranges_for_cpp): If the line ends with a backslash instead of a matching
1413         quotation mark, use new variable $quotation_mark to remember what we are looking for, and
1414         keep consuming the quoted text until the matching quotation mark is reached. Emit the
1415         warning only if a line ends without a backslash before the matching quotation mark was found.
1416
1417 2015-03-18  Joseph Pecoraro  <pecoraro@apple.com>
1418
1419         Remove unused "preprocessor" parameter to sub-CodeGenerators
1420         https://bugs.webkit.org/show_bug.cgi?id=142793
1421
1422         Reviewed by Darin Adler.
1423
1424         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1425         (new):
1426
1427 2015-03-18  Csaba Osztrogonác  <ossy@webkit.org>
1428
1429         [EFL] Bump gstreamer version to 1.4.4
1430         https://bugs.webkit.org/show_bug.cgi?id=142782
1431
1432         Reviewed by Philippe Normand.
1433
1434         * efl/jhbuild.modules:
1435         * efl/patches/gst-libav.patch:
1436         * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
1437         * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
1438
1439 2015-03-17  Tim Horton  <timothy_horton@apple.com>
1440
1441         Fix the iOS build.
1442
1443         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
1444         (WTR::InjectedBundle::platformInitialize):
1445
1446 2015-03-17  Dean Jackson  <dino@apple.com>
1447
1448         check-webkit-style should allow "bool a : 1"
1449         https://bugs.webkit.org/show_bug.cgi?id=142794
1450
1451         Reviewed by Brent Fulgham.
1452
1453         We should allow member bitfields of the form:
1454
1455         bool m_var : 1;
1456
1457         It seems that Visual Studio 8 was the last compiler that
1458         wasn't happy about not using unsigned here. We already have
1459         about 500 cases (in WebCore) where people were ignoring this rule.
1460
1461         * Scripts/webkitpy/style/checkers/cpp.py:
1462         (check_language): Allow "bool".
1463         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add tests.
1464         (CppStyleTest.test_enum_bitfields):
1465         (CppStyleTest.test_plain_integral_bitfields):
1466
1467 2015-03-17  Benjamin Poulain  <bpoulain@apple.com>
1468
1469         Compile character ranges targeting the same state as range check in the bytecode
1470         https://bugs.webkit.org/show_bug.cgi?id=142759
1471
1472         Reviewed by Alex Christensen.
1473
1474         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1475         (TestWebKitAPI::TEST_F):
1476
1477 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1478
1479         W3C test parser and converter should use test importer host
1480         https://bugs.webkit.org/show_bug.cgi?id=142729
1481
1482         Reviewed by Bem Jones-Bey.
1483
1484         When instantiated by TestImporter, TestParser and TestConverter are now using the same host.
1485         This enables adding more TestImporter unit testing.
1486         This patch also ensures that the git object instantiated by TestDownloader is using the
1487         same Executive and FileSystem object as TestDownloader, again to enable TestImporter/TestDownloader unit testing.
1488
1489         * Scripts/webkitpy/common/system/filesystem_mock.py:
1490         (MockFileSystem.copytree): Fixes implementation as it creates a runtime error.
1491         * Scripts/webkitpy/w3c/test_downloader.py:
1492         (TestDownloader.git): Set the executive of the git object to the one of TestDownloader. Refactoring in a new git function for future reuse.
1493         (TestDownloader.checkout_test_repository): Making use of the new git function.
1494         * Scripts/webkitpy/w3c/test_importer.py:
1495         (TestImporter.find_importable_tests): Adding host as parameter to the parser.
1496         (TestImporter.import_tests): Adding host as parameter to the converter.
1497         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1498         (TestImporterTest.create_test_download_importer): Creating a test downloader mock, to be reused by other tests.
1499         (TestImporterTest):
1500         (TestImporterTest.test_harnesslinks_conversion): Adding test to check that test harness links are converted for CSS tests but not WPT tests. 
1501         * Scripts/webkitpy/w3c/test_parser.py:
1502         (TestParser.__init__): Adding host as parameter constructor.
1503
1504 2015-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1505
1506         [GTK] WebKitDOM objects leaking
1507         https://bugs.webkit.org/show_bug.cgi?id=118788
1508
1509         Reviewed by Darin Adler and Sergio Villar Senin.
1510
1511         Update DOMObjectCache unit test to check that DOM objects are also
1512         released when new contents are loaded in the web view, and the old
1513         document is detached from the frame.
1514
1515         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
1516         (testWebKitDOMObjectCache):
1517         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1518         (runTest):
1519
1520 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1521
1522         W3C test importer default import folder should be LayoutTests/imported/w3c
1523         https://bugs.webkit.org/show_bug.cgi?id=142728
1524
1525         Reviewed by Bem Jones-Bey.
1526
1527         * Scripts/webkitpy/w3c/test_importer.py:
1528         (parse_args): Updating the default destination option value to 'imported/w3c'.
1529
1530 2015-03-17  Philippe Normand  <pnormand@igalia.com>
1531
1532         [GTK] basic OpenWebRTC build support
1533         https://bugs.webkit.org/show_bug.cgi?id=142393
1534
1535         Reviewed by Carlos Garcia Campos.
1536
1537         * gtk/jhbuild.modules: Add OpenWebRTC and its dependencies. This
1538         is not the upstream OpenWebRTC repository. This temporary fork
1539         contains a few patches needed by WebKit for audio/video rendering.
1540
1541 2015-03-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1542
1543         [CMake][EFL] Build test tools only for developer mode
1544         https://bugs.webkit.org/show_bug.cgi?id=142761
1545
1546         Reviewed by Csaba Osztrogonác.
1547
1548         Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on production mode.
1549
1550         * CMakeLists.txt:
1551
1552 2015-03-17  Joseph Pecoraro  <pecoraro@apple.com>
1553
1554         Remove never used "useLayerOnTop" bindings generator argument
1555         https://bugs.webkit.org/show_bug.cgi?id=142773
1556
1557         Reviewed by Darin Adler.
1558
1559         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1560         (new):
1561
1562 2015-03-16  Ryosuke Niwa  <rniwa@webkit.org>
1563
1564         Enable ES6 classes by default
1565         https://bugs.webkit.org/show_bug.cgi?id=142774
1566
1567         Reviewed by Gavin Barraclough.
1568
1569         * Scripts/webkitperl/FeatureList.pm:
1570
1571 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
1572
1573         Fix webkitpy tests after r181585.
1574
1575         Looks like "me" cannot be anyone's email, it's a special case.
1576
1577         * Scripts/webkitpy/common/config/contributors.json:
1578
1579 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
1580
1581         Add tolerance to WebAudio tests
1582         https://bugs.webkit.org/show_bug.cgi?id=142676
1583
1584         Reviewed by Tim Horton.
1585
1586         * Scripts/webkitpy/common/wavediff.py: Added. Based on Jer Noble's work.
1587
1588         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1589         (TestResultWriter.create_audio_diff_and_write_result):
1590         * Scripts/webkitpy/layout_tests/models/test_failures.py:
1591         (FailureAudio.write_failure):
1592         * Scripts/webkitpy/port/base.py:
1593         (Port.do_audio_results_differ):
1594         Diff audio failures.
1595
1596         * Scripts/webkitpy/port/test.py: Added a test for the tolerance, fixed existing
1597         tests to use real parseable WAV data, and got rid of base64, which there didn't
1598         seem to have been any reason for.
1599
1600 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
1601
1602         [Mac] fast/forms/text-control-intrinsic-widths.html fails when MS Office is installed
1603         https://bugs.webkit.org/show_bug.cgi?id=142720
1604
1605         Reviewed by Myles C. Maxfield.
1606
1607         Activate system copies of Microsoft fonts for the current process, thus overriding
1608         any other ones that could be preferred by the system otherwise.
1609
1610         * DumpRenderTree/mac/DumpRenderTree.mm:
1611         (activateSystemCoreWebFonts):
1612         (adjustFonts):
1613         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1614         (WTR::activateSystemCoreWebFonts):
1615         (WTR::activateFonts):
1616
1617 2015-03-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1618
1619         Created Streams API watchlist
1620         https://bugs.webkit.org/show_bug.cgi?id=142684
1621
1622         Reviewed by Benjamin Poulain.
1623
1624         * Scripts/webkitpy/common/config/watchlist: Created StreamsAPI
1625         watchlist and added Benjamin, Youenn and me to it.
1626
1627 2015-03-15  Benjamin Poulain  <benjamin@webkit.org>
1628
1629         CSS: fix the case-insensitive matching of the attribute selectors Begin, End and Hyphen
1630         https://bugs.webkit.org/show_bug.cgi?id=142715
1631
1632         Reviewed by Brent Fulgham.
1633
1634         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1635         (TestWebKitAPI::TEST):
1636
1637 2015-03-15  Benjamin Poulain  <bpoulain@apple.com>
1638
1639         Change the exact attribute matching to be ASCII case-insensitive
1640         https://bugs.webkit.org/show_bug.cgi?id=142609
1641
1642         Reviewed by Darin Adler.
1643
1644         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1645         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1646
1647 2015-03-13  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1648
1649         WebKit test infrastructure should automate the process of cloning W3C test suite and importing tests from it
1650         https://bugs.webkit.org/show_bug.cgi?id=134764
1651
1652         Reviewed by Ryosuke Niwa.
1653
1654         TestDownloader is introduced to download W3C tests from the official
1655         W3C tests repositories (https://github.com/w3c/web-platform-tests.git
1656         and https://github.com/w3c/csswg-test.git).
1657         TestDownloader clones the repositories and checkouts revisions of the tests
1658         defined in LayoutTests/imported/w3c/resources/TestRepositories.
1659
1660         Similarly to https://codereview.chromium.org/148173016,
1661         TestDownloader copies part of the files based on the rules
1662         defined in LayoutTests/imported/w3c/resources/ImportExpectations.
1663
1664         TestDownloader is used by TestImporter when no source directory is provided.
1665
1666         * Scripts/webkitpy/w3c/test_downloader.py: Added.
1667         (TestDownloader):
1668         (TestDownloader.default_options):
1669         (TestDownloader.load_test_repositories):
1670         (TestDownloader.__init__):
1671         (TestDownloader.checkout_test_repository):
1672         (TestDownloader._init_paths_from_expectations):
1673         (TestDownloader._add_test_suite_paths):
1674         (TestDownloader._empty_directory):
1675         (TestDownloader.copy_tests):
1676         (TestDownloader.download_tests):
1677         * Scripts/webkitpy/w3c/test_importer.py:
1678         (main):
1679         (parse_args):
1680         (TestImporter.__init__):
1681         (TestImporter.do_import):
1682         (TestImporter.test_downloader):
1683         (TestImporter.find_importable_tests.should_keep_subdir):
1684         (TestImporter.should_convert_test_harness_links):
1685         (TestImporter.import_tests):
1686         (TestImporter.write_import_log):
1687
1688 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
1689
1690         [Mavericks] Test snapshots are 1600x1200 on Retina devices
1691         https://bugs.webkit.org/show_bug.cgi?id=142630
1692
1693         Reviewed by Tim Horton.
1694
1695         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
1696         Removed an ifdef that disabled the fix on Mavericks.
1697
1698 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
1699
1700         Remove isWK2 cruft from webkitdirs.pm after r170426
1701         https://bugs.webkit.org/show_bug.cgi?id=142618
1702
1703         Reviewed by Daniel Bates.
1704
1705         * Scripts/webkitdirs.pm:
1706         (isWK2): Deleted.
1707
1708 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
1709
1710         testRunner.setAlwaysAcceptCookies does not work with NetworkProcess
1711         https://bugs.webkit.org/show_bug.cgi?id=138687
1712
1713         Reviewed by Carlos Garcia Campos.
1714
1715         Always change cookie policy from UI process, as changing it from WebProcess doesn't
1716         affect other processes.
1717
1718         The implementation is imperfect, because the change happens asynchronously, but I
1719         don't expect it to be a problem in practice.
1720
1721         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1722         (WTR::InjectedBundle::beginTesting):
1723         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1724         (WTR::TestRunner::setAlwaysAcceptCookies):
1725         * WebKitTestRunner/TestInvocation.cpp:
1726         (WTR::TestInvocation::invoke):
1727         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1728
1729 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
1730
1731         [EFL] Enable building EFL 1.13 with NEON support
1732         https://bugs.webkit.org/show_bug.cgi?id=142619
1733
1734         Reviewed by Gyuyoung Kim.
1735
1736         * efl/jhbuild.modules:
1737
1738 2015-03-11  Alex Christensen  <achristensen@webkit.org>
1739
1740         [Content Extensions] Add resource type and load type triggers.
1741         https://bugs.webkit.org/show_bug.cgi?id=142422
1742
1743         Reviewed by Benjamin Poulain.
1744
1745         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1746         (TestWebKitAPI::testRequest):
1747         (TestWebKitAPI::mainDocumentRequest):
1748         (TestWebKitAPI::TEST_F):
1749         (TestWebKitAPI::testURL): Deleted.
1750
1751 2015-03-10  Sam Weinig  <sam@webkit.org>
1752
1753         Allow adding a button in input elements for auto fill related functionality
1754         <rdar://problem/19782066>
1755         https://bugs.webkit.org/show_bug.cgi?id=142564
1756
1757         Reviewed by Anders Carlsson.
1758
1759         * WebKitTestRunner/TestController.cpp:
1760         (WTR::TestController::createOtherPage):
1761         (WTR::TestController::createWebViewWithOptions):
1762         Update for new callback.
1763
1764 2015-03-11  Benjamin Poulain  <bpoulain@apple.com>
1765
1766         Add basic support for BOL and EOL assertions to the URL Filter parser
1767         https://bugs.webkit.org/show_bug.cgi?id=142568
1768
1769         Reviewed by Alex Christensen.
1770
1771         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1772         (TestWebKitAPI::TEST_F):
1773
1774 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1775
1776         [GTK] Add support for handling TLS errors to MiniBrowser
1777         https://bugs.webkit.org/show_bug.cgi?id=142576
1778
1779         Reviewed by Sergio Villar Senin.
1780
1781         It's useful for testing TLS errors handling itself, but also to
1782         allow ignoring TLS errors when testing.
1783
1784         * MiniBrowser/gtk/BrowserWindow.c:
1785         (webViewLoadFailedWithTLSerrors):
1786         (browserWindowConstructed):
1787
1788 2015-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
1789
1790         Use out-of-band messaging for RenderBox::firstLineBaseline() and RenderBox::inlineBlockBaseline()
1791         https://bugs.webkit.org/show_bug.cgi?id=142569
1792
1793         Reviewed by David Hyatt.
1794
1795         Test Optional::valueOrCompute().
1796
1797         * TestWebKitAPI/Tests/WTF/Optional.cpp:
1798         (TestWebKitAPI::TEST):
1799
1800 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1801
1802         [GTK] Add an option to enable MiniBrowser for non developer builds and always install it
1803         https://bugs.webkit.org/show_bug.cgi?id=126688
1804
1805         Reviewed by Gustavo Noronha Silva.
1806
1807         * CMakeLists.txt: Build testing tools only for developer builds,
1808         but MiniBrowser when ENABLE_MINIBROWSER option is ON.
1809         * MiniBrowser/gtk/CMakeLists.txt: Only add
1810         -DWEBKIT_INJECTED_BUNDLE_PATH to the build for developer builds,
1811         and add a rule to install the MiniBrowser.
1812         * MiniBrowser/gtk/main.c:
1813         (main): Only set WEBKIT_INJECTED_BUNDLE_PATH env var for developer
1814         builds.
1815
1816 2015-03-11  Brent Fulgham  <bfulgham@apple.com>
1817
1818         Add some DateMath tests to TestWebKitAPI
1819         https://bugs.webkit.org/show_bug.cgi?id=142565
1820
1821         Reviewed by Alexey Proskuryakov.
1822
1823         * TestWebKitAPI/CMakeLists.txt: Add new DateMath.cpp file.
1824         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
1825         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
1826         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto."
1827         * TestWebKitAPI/Tests/WTF/DateMath.cpp: Added.
1828
1829 2015-03-10  Brent Fulgham  <bfulgham@apple.com>
1830
1831         Regression(r181257): WTF_WorkQueue.Simple is flaky
1832         https://bugs.webkit.org/show_bug.cgi?id=142560
1833
1834         Unreviewed attempt to improve test stability.
1835
1836         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Check the reference count for
1837         the WorkQueue a little later to redue flakiness.
1838
1839 2015-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
1840
1841         Migrate from SystemUIFontSelect to AppleSystemFontOSSubversion
1842         https://bugs.webkit.org/show_bug.cgi?id=142555
1843
1844         Reviewed by Simon Fraser.
1845
1846         * DumpRenderTree/mac/DumpRenderTree.mm:
1847         (setDefaultsToConsistentValuesForTesting):
1848         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1849         (WTR::InjectedBundle::platformInitialize):
1850
1851 2015-03-10  Alex Christensen  <achristensen@webkit.org>
1852
1853         Use unsigned for HashSet size.
1854         https://bugs.webkit.org/show_bug.cgi?id=142518
1855
1856         Reviewed by Benjamin Poulain.
1857
1858         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1859         (TestWebKitAPI::TEST):
1860         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1861         (TestWebKitAPI::testInitialCapacity):
1862         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
1863         (TestWebKitAPI::TEST):
1864
1865 2015-03-10  Daniel Bates  <dabates@apple.com>
1866
1867         [iOS] Add WebKitSystemInterface for iOS 8.2
1868         https://bugs.webkit.org/show_bug.cgi?id=142505
1869
1870         Rubber-stamped by Anders Carlsson.
1871
1872         Make copy-webkitlibraries-to-product-directory install libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a.
1873         I inadvertently forgot to add libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a to script
1874         copy-webkitlibraries-to-product-directory in r181286.
1875
1876         * Scripts/copy-webkitlibraries-to-product-directory:
1877
1878 2015-03-10  Benjamin Poulain  <bpoulain@apple.com>
1879
1880         Extend URL filter's Term definition to support groups/subpatterns
1881         https://bugs.webkit.org/show_bug.cgi?id=142519
1882
1883         Reviewed by Alex Christensen.
1884
1885         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1886         (TestWebKitAPI::testURL):
1887
1888 2015-03-06  Jer Noble  <jer.noble@apple.com>
1889
1890         Add an option to run-webkit-tests to override the LayoutTests/ directory
1891         https://bugs.webkit.org/show_bug.cgi?id=142418
1892
1893         Reviewed by David Kilzer.
1894
1895         Add an arugment to run-webkit-tests which, when set, overrides the port's default LayoutTests
1896         directory. The base port will parse the options during initialization and store the override
1897         location if present. layout_tests_dir() will return this overridden location if set.
1898
1899         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1900         (parse_args):
1901         * Scripts/webkitpy/port/base.py:
1902         (Port.__init__):
1903         (Port.layout_tests_dir):
1904
1905 2015-03-09  Martin Robinson  <mrobinson@igalia.com>
1906
1907         [CMake] Enable WorkQueue tests for CMake ports
1908         https://bugs.webkit.org/show_bug.cgi?id=142473
1909
1910         Reviewed by Darin Adler.
1911
1912         * TestWebKitAPI/CMakeLists.txt: Add the WorkQueue tests source file to
1913         the list of source files.
1914         * Tools/TestWebKitAPI/PlatformEfl.cmake: Add the DispatchQueueEfl directory
1915         to the list of include directories for EFL.
1916
1917 2015-03-09  David Kilzer  <ddkilzer@apple.com>
1918
1919         Attempt to fix timeouts on iOS Simulator layout tests
1920
1921         * Scripts/webkitpy/port/ios.py:
1922         (IOSSimulatorPort.setup_test_run): Most layout test runs on iOS
1923         Simulator end after the first 50 tests time out.  Some analysis
1924         this past weekend shows that the 'Booted' status in the output
1925         of `xcrun simctl list` is not sufficient (and watching the test
1926         run shows that SpringBoard hasn't fully started to the point
1927         where it's displaying icons on the home screen).  The workaround
1928         until we have a better fix is to add an arbitrary timeout to let
1929         SpringBoard finish launching.  In practice, 15 seconds is
1930         probably enough, but 30 seconds should nearly always work.
1931
1932 2015-03-09  Per Arne Vollan  <peavo@outlook.com>
1933
1934         Unreviewed. Add myself as a committer.
1935
1936         * Scripts/webkitpy/common/config/contributors.json:
1937
1938 2015-03-09  David Kilzer  <ddkilzer@apple.com>
1939
1940         Attempt to fix WTF_WorkQueue.TwoQueues timeout test failure
1941
1942         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1943         (TestWebKitAPI::TEST): Change delay from 50ns to 50ms, and add
1944         an expectation that will fail if we hit the race condition.
1945         This test is inherently racy and will deadlock if the first job
1946         for queue2 takes the mutex lock before the second job for
1947         queue1.
1948
1949 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
1950
1951         [Win] WTF::WorkQueue does not balance ref/deref properly
1952         https://bugs.webkit.org/show_bug.cgi?id=142471
1953
1954         Reviewed by Antti Koivisto.
1955
1956         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1957         (TestWebKitAPI::TEST): Check that the refcount is correct.
1958
1959 2015-03-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1960
1961         Do not show passing test result on output of EFL layout test
1962         https://bugs.webkit.org/show_bug.cgi?id=142380
1963
1964         Reviewed by Darin Adler.
1965
1966         To show passing tests has caused inconvenience when we detect problem tests
1967         in output of layout test. So this patch applies '--debug-rwt-logging' except for EFL port
1968         in order not to show passing tests in the output of EFL layout test.
1969
1970         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1971         (RunWebKitTests.start):
1972
1973 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
1974
1975         Unreviewed build fix.
1976
1977         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1978         (TestWebKitAPI::TEST): Remove two unused variables.
1979
1980 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
1981
1982         Add some WorkQueue tests to TestWebKitAPI
1983         https://bugs.webkit.org/show_bug.cgi?id=142447
1984
1985         Reviewed by Sam Weinig.
1986
1987         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1988         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1989         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1990         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Added.
1991         (TestWebKitAPI::simpleTest):
1992         (TestWebKitAPI::longTest):
1993         (TestWebKitAPI::thirdTest):
1994         (TestWebKitAPI::finishedTests):
1995         (TestWebKitAPI::TEST):
1996         (TestWebKitAPI::longTest2):
1997
1998 2015-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1999
2000         Remove willDestroyFrame in WKBundlePageLoaderClient
2001         https://bugs.webkit.org/show_bug.cgi?id=142389
2002
2003         Reviewed by Anders Carlsson.
2004
2005         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2006         (WTR::InjectedBundlePage::InjectedBundlePage):
2007
2008 2015-03-07  Brent Fulgham  <bfulgham@apple.com>
2009
2010         [Win] Increase TestWebKitAPI Test Coverage[Win] Increase TestWebKitAPI Test Coverage
2011         https://bugs.webkit.org/show_bug.cgi?id=142433
2012
2013         Reviewed by Darin Adler.
2014
2015         Include more TestWebKitAPI tests when building for Windows. Also
2016         fix a build error in MetaAllocator.cpp caused by one of the
2017         Microsoft headers #defining 'small'.
2018
2019         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2020         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
2021         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2022
2023 2015-03-06  Sam Weinig  <sam@webkit.org>
2024
2025         [Content Extensions] Move compiling of content extensions to the UIProcess
2026         https://bugs.webkit.org/show_bug.cgi?id=142402
2027
2028         Reviewed by Benjamin Poulain.
2029
2030         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2031         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: Copied from Tools/TestWebKitAPI/Tests/WebCore/ContentFilter.cpp.
2032         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
2033         (TestWebKitAPI::InMemoryCompiledContentExtension::~InMemoryCompiledContentExtension):
2034         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
2035         (TestWebKitAPI::TEST_F):
2036         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Removed.
2037         Update test for new name (ContentFilter -> ContentExtensions) and API (CompiledContentExtension
2038         is now abstract).
2039
2040 2015-03-06  Brent Fulgham  <bfulgham@apple.com>
2041
2042         [Win] Correct Windows build.
2043
2044         Rubberstamped by Michael Saboff
2045
2046         * win/AssembleBuildLogs/AssembleLogs.cmd: Correct cut/paste error
2047         in the GOTO labels.
2048
2049 2015-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2050
2051         [GTK] Test /webkit2/WebKitWebView/sync-request-on-max-conns might fail after finished
2052         https://bugs.webkit.org/show_bug.cgi?id=142385
2053
2054         Reviewed by Sergio Villar Senin.
2055
2056         Use stack allocated GMainLoopSources to make sure they are
2057         cancelled automatically if the test finishes before they have
2058         been processed.
2059
2060         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2061         (testWebViewSyncRequestOnMaxConns):
2062
2063 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
2064
2065         Remove Mountain Lion libraries since ML isn't supported
2066         https://bugs.webkit.org/show_bug.cgi?id=142332
2067
2068         Reviewed by Darin Adler.
2069
2070         * Scripts/copy-webkitlibraries-to-product-directory:
2071
2072 2015-03-06  Carlos Alberto Lopez Perez <clopez@igalia.com> and Youenn Fablet  <youenn.fablet@crf.canon.fr>
2073
2074         Layout tests imported/w3c/web-platform-tests certificates should not be tracked on WebKit VCS
2075         https://bugs.webkit.org/show_bug.cgi?id=142083
2076
2077         Reviewed by Simon Fraser.
2078
2079         Modifying on the fly wpt config.json to set the directory where to generate/read certificates as a subfolder of the layout test results folder.
2080
2081         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2082         (WebPlatformTestServer._copy_webkit_test_files):
2083
2084 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
2085
2086         setup-git-clone fails due to the failure to download python-irclib-0.4.8
2087         https://bugs.webkit.org/show_bug.cgi?id=141946
2088
2089         Reviewed by Ryosuke Niwa.
2090
2091         Check in ircbot.py and irclib.py to avoid network problems in the future.
2092
2093         * Scripts/webkitpy/common/net/irc/ircbot.py:
2094         * Scripts/webkitpy/thirdparty/__init__.py:
2095         (AutoinstallImportHook.find_module):
2096         (AutoinstallImportHook._install_irc): Deleted.
2097         * Scripts/webkitpy/thirdparty/__init___unittest.py:
2098         (ThirdpartyTest.test_imports):
2099         * Scripts/webkitpy/thirdparty/irc/__init__.py: Added.
2100         * Scripts/webkitpy/thirdparty/irc/ircbot.py: Added.
2101         * Scripts/webkitpy/thirdparty/irc/irclib.py: Added.
2102
2103 2015-03-06  David Kilzer  <ddkilzer@apple.com>
2104
2105         Dashboard: Perf bot status is missing for Apple {Mavericks,Yosemite} Release builds
2106
2107         See also fix to config.json in r181097.
2108
2109         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2110         (WebKitBuildbot): Add missing "WK2" to the names of the perf
2111         bots.
2112
2113 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
2114
2115         run-jsc-stress-tests should determine the architecture from ELF binaries
2116         https://bugs.webkit.org/show_bug.cgi?id=142335
2117
2118         Reviewed by Darin Adler.
2119
2120         * Scripts/run-jsc-stress-tests:
2121
2122 2015-03-05  David Kilzer  <ddkilzer@apple.com>
2123
2124         [iOS] TestExpectations for ios-simulator-wk2 should fall back to 'wk2' after 'ios-simulator'
2125         <http://webkit.org/b/142226>
2126
2127         Reviewed by Darin Adler.
2128
2129         * Scripts/webkitpy/port/ios.py:
2130         (IOSSimulatorPort.default_baseline_search_path): Switch the
2131         TestExpectations order of ios-simulator-wk2 from this:
2132           ios-simulator-wk2, wk2, ios-simulator
2133         To this:
2134           ios-simulator-wk2, ios-simualtor, wk2
2135
2136 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
2137
2138         [Win] Provide tiered logging from MSBuild -- Errors on top, Warnings after
2139         https://bugs.webkit.org/show_bug.cgi?id=142370
2140
2141         Reviewed by Dean Jackson.
2142
2143         * Scripts/webkitdirs.pm:
2144         (buildVisualStudioProject): Tell MSBuild to output log files to two separate
2145         logs, one for warnings, the other for errors.
2146         * win/AssembleBuildLogs/AssembleLogs.cmd: Combine the error and warning logs
2147         into the standard BuildOutput.htm document.
2148
2149 2015-03-05  David Kilzer  <ddkilzer@apple.com>
2150
2151         Dashboard has trouble parsing iOS test output
2152         <http://webkit.org/b/142364>
2153
2154         Reviewed by Alex Christensen.
2155
2156         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2157         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
2158         Add fallback path to build a regex using 'matchString' so that
2159         it matches anywhere in the line.  In practice, 'matchString' is
2160         a prefix for the label following the number.
2161
2162 2015-03-05  Alex Christensen  <achristensen@webkit.org>
2163
2164         Fix linker warnings in TestWebKitAPI.
2165         https://bugs.webkit.org/show_bug.cgi?id=141912
2166
2167         Reviewed by David Kilzer.
2168
2169         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2170         Do not export TearDownTestCase or SetUpTestCase symbols.
2171
2172 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
2173
2174         [Win] Unreviewed EWS fix.
2175
2176         * Scripts/webkitdirs.pm:
2177         (buildVisualStudioProject): Dial logging back to 'ErrorsOnly' to see if that makes
2178         the EWS output more usable.
2179
2180 2015-03-05  Chris Dumez  <cdumez@apple.com>
2181
2182         Regression(r173761): ASSERTION FAILED: !is8Bit() in StringImpl::characters16()
2183         https://bugs.webkit.org/show_bug.cgi?id=142350
2184
2185         Reviewed by Michael Saboff and Benjamin Poulain.
2186
2187         Add API test for WTFString::hasInfixStartingAt() to make sure it doesn't
2188         crash if the string is 8-bit but the pattern is 16-bit (and vice-versa).
2189
2190         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2191         (TestWebKitAPI::TEST):
2192
2193 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
2194
2195         [Win] Ensure build target directory exists when launching MSBuild
2196         https://bugs.webkit.org/show_bug.cgi?id=142360
2197
2198         Reviewed by Dean Jackson.
2199
2200         Create the build output directory (if it doesn't exist) before
2201         launching MSBuild so that it can immediately begin writing logs.
2202
2203         * Scripts/webkitdirs.pm:
2204         (buildVisualStudioProject):
2205
2206 2015-03-05  Chris Dumez  <cdumez@apple.com>
2207
2208         run-webkit-tests and run-perf-tests should use WebKitTestRunner by default
2209         https://bugs.webkit.org/show_bug.cgi?id=142325
2210
2211         Reviewed by Csaba Osztrogonác.
2212
2213         run-webkit-tests and run-perf-tests now use WebKitTestRunner by default.
2214         As a result, "--webkit-test-runner / -2" parameters are replaced by
2215         "--dump-render-tree / -1" so developers can run DumpRenderTree rather
2216         than WebKitTestRunner.
2217
2218         * BuildSlaveSupport/build.webkit.org-config/config.json:
2219         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2220         (RunWebKit1Tests):
2221         (RunWebKit1Tests.start):
2222         (RunWebKit1LeakTests):
2223         (RunWebKit1LeakTests.start):
2224         (RunAndUploadPerfTestsWebKit1):
2225         (RunAndUploadPerfTestsWebKit1.start):
2226         (TestFactory):
2227         (TestWebKit1LeaksFactory):
2228         (TestWebKit1LeaksFactory.__init__):
2229         (TestWebKit1Factory):
2230         (TestWebKit1AllButJSCFactory):
2231         (TestAllButJSCFactory):
2232         (BuildAndPerfTestWebKit1Factory):
2233         (BuildAndPerfTestWebKit1Factory.__init__):
2234         (BuildAndPerfTestFactory):
2235         (BuildAndPerfTestFactory.__init__):
2236         (DownloadAndPerfTestWebKit1Factory):
2237         (DownloadAndPerfTestWebKit1Factory.__init__):
2238         (DownloadAndPerfTestFactory):
2239         (DownloadAndPerfTestFactory.__init__):
2240         (RunWebKitLeakTests): Deleted.
2241         (RunWebKitLeakTests.start): Deleted.
2242         (RunWebKit2Tests): Deleted.
2243         (RunWebKit2Tests.start): Deleted.
2244         (RunAndUploadPerfTestsWebKit2): Deleted.
2245         (RunAndUploadPerfTestsWebKit2.start): Deleted.
2246         (TestLeaksFactory): Deleted.
2247         (TestLeaksFactory.__init__): Deleted.
2248         (TestWebKit2Factory): Deleted.
2249         (TestWebKit2AndJSCFactory): Deleted.
2250         (BuildAndPerfTestWebKit2Factory): Deleted.
2251         (BuildAndPerfTestWebKit2Factory.__init__): Deleted.
2252         (DownloadAndPerfTestWebKit2Factory): Deleted.
2253         (DownloadAndPerfTestWebKit2Factory.__init__): Deleted.
2254         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2255         (parse_args):
2256         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2257         (PerfTestsRunner._parse_args):
2258         * Scripts/webkitpy/port/port_testcase.py:
2259         (PortTestCase.test_build_driver):
2260
2261 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
2262
2263         [Win] Switch to MSBuild so we get more useful stdout logging in buildbot
2264         https://bugs.webkit.org/show_bug.cgi?id=140845
2265
2266         Reviewed by David Kilzer.
2267
2268         Update 'webkitdirs.pm' to locate the MSBuild used with Visual Studio 2013
2269         and generate suitable build commands to drive a full build from our
2270         existing solution files.
2271
2272         * Scripts/webkitdirs.pm:
2273         (msBuildInstallDir): Added.
2274         (determineConfigurationForVisualStudio): Revise to use MSBuild command
2275         line arguments to drive the build.
2276         (setupCygwinEnv): Warn user if MSBuild cannot be located.
2277         (buildVisualStudioProject): Revise to use MSBuild command line arguments
2278         to specify build architecture.
2279         * win/AssembleBuildLogs/AssembleLogs.cmd: MSBuild doesn't produce individual
2280         output logs, so don't attempt to consolidate them. Also: Drive-by fix: Don't
2281         bother looking for CoreUI or SafariTheme build logs.
2282
2283 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
2284
2285         [buildbot] mastercfg_unittest.py should be runnable easily
2286         https://bugs.webkit.org/show_bug.cgi?id=142219
2287
2288         Reviewed by Chris Dumez.
2289
2290         Buildbot 0.8.6p1 runs on build.webkit org with Twisted 12.1.0, which is
2291         the last Twisted version works together with this buildbot version.
2292
2293         * Scripts/webkitpy/common/system/autoinstall.py:
2294         (AutoInstaller): Added prepend_to_search_path argument to be able
2295         to prefer autoinstalled package to system package.
2296         (AutoInstaller.__init__):
2297         (AutoInstaller._set_up_target_dir):
2298         (AutoInstaller._extract_tar): Renamed from _extract_targz, now it works with tar.bz2 too.
2299         (AutoInstaller._prepare_package):
2300         (AutoInstaller._extract_targz): Renamed to _extract_tar.
2301         * Scripts/webkitpy/thirdparty/__init__.py:
2302         (AutoinstallImportHook._install_buildbot): Autoinstall Twisted 12.1.0.
2303
2304 2015-03-05  Lukasz Bialek  <l.bialek@samsung.com>
2305
2306         [EFL][WK2] Crash when "Download Linked File" from MiniBrowser context menu is clicked
2307         https://bugs.webkit.org/show_bug.cgi?id=131162
2308
2309         Reviewed by Gyuyoung Kim.
2310
2311         * MiniBrowser/efl/main.c:
2312         (on_download_request):
2313         (on_download_finished):
2314         (on_download_failed):
2315         (window_create):
2316         Adapt download callbacks to new callback mechanism
2317
2318 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2319
2320         Unreviewed. Fix /webkit2/WebKitWebResource/mime-type after r180927.
2321
2322         In r180927 we updated the libsoup version used by the jhbuild. In
2323         this new version the sniffer uses image/x-icon instead of
2324         image/vnd.microsoft.icon for blank.ico resource.
2325
2326         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2327         (testWebResourceMimeType):
2328
2329 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2330
2331         [SOUP] Check TLS errors as soon as they are set in the SoupMessage
2332         https://bugs.webkit.org/show_bug.cgi?id=142244
2333
2334         Reviewed by Sergio Villar Senin.
2335
2336         Check that the SSL server doesn't process any request in case of
2337         TLS errors when the policy is set to FAIL.
2338
2339         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2340         (testTLSErrorsPolicy):
2341         (testTLSErrorsRedirect):
2342         (testTLSErrorsHTTPAuth):
2343         (testLoadFailedWithTLSErrors):
2344         (testSubresourceLoadFailedWithTLSErrors):
2345         (httpsServerCallback):
2346
2347 2015-03-05  Pawel Forysiuk  <p.forysiuk@samsung.com>
2348
2349         [EFL] REGRESSION (r178685): ASSERTION FAILED: !parameters.mediaKeyStorageDirectory.isEmpty()
2350         https://bugs.webkit.org/show_bug.cgi?id=141154
2351
2352         Reviewed by Jer Noble.
2353
2354         Unlike GTK, EFL port enables ENABLE_ENCRYPTED_MEDIA_V2 build option by default.
2355
2356         For the sake of completeness WebKitTestRunner should specify temporary
2357         folder for MediaKeysStorageDirecory as well as IndexedDB, LocalStorage, etc.
2358
2359         Default non legacy paths are set up in ProcessPoolConfiguration constructor.
2360         They use WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
2361         to get data storage paths. Only Mac port has an actual implementation of it.
2362         However, WebKitTestRunner overrides them in favour of unique temporary dir
2363         which is taken from libraryPathForTesting().
2364
2365         Since WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
2366         is not implemented for EFL and GTK ports it returns an empty string.
2367         All default data folders besides MediaKeys are overridden in TestRunner
2368         code with unique temporary folders derived from DUMPRENDERTREE_TEMP
2369         env variable.
2370
2371         GTK port does not enable encrypted keys by default so
2372         WebMediaKeyStorageManager::initialize() code path is never triggered.
2373
2374         * WebKitTestRunner/TestController.cpp:
2375         (WTR::TestController::initialize): Set MediaKeysStorageDirectory for all
2376         WebKit ports.
2377
2378 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
2379
2380         [buildbot] Add regression test to check which builder runs which tests
2381         https://bugs.webkit.org/show_bug.cgi?id=142166
2382
2383         Reviewed by Alexey Proskuryakov.
2384
2385         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2386         (BuildStepsConstructorTest.createTest):
2387         (BuildStepsTest):
2388         (BuildStepsTest.generateTests):
2389         (BuildStepsTest.createTest):
2390         (BuildStepsTest.createTest.doTest):
2391         (BuildStepsTest.test_unnecessary_expected_results):
2392
2393 2015-03-04  Commit Queue  <commit-queue@webkit.org>
2394
2395         Unreviewed, rolling out r181054.
2396         https://bugs.webkit.org/show_bug.cgi?id=142320
2397
2398         Broke the api tests (Requested by sundiamonde on #webkit).
2399
2400         Reverted changeset:
2401
2402         "Fix linker warnings in TestWebKitAPI."
2403         https://bugs.webkit.org/show_bug.cgi?id=141912
2404         http://trac.webkit.org/changeset/181054
2405
2406 2015-03-04  Alex Christensen  <achristensen@webkit.org>
2407
2408         Fix linker warnings in TestWebKitAPI.
2409         https://bugs.webkit.org/show_bug.cgi?id=141912
2410
2411         Reviewed by David Kilzer.
2412
2413         * TestWebKitAPI/Configurations/Base.xcconfig:
2414         Use GCC_SYMBOLS_PRIVATE_EXTERN like we do in WebCore.
2415
2416 2015-03-04  Alexey Proskuryakov  <ap@apple.com>
2417
2418         [Mac] Set SystemUIFontSelect in DRT and WKTR
2419         https://bugs.webkit.org/show_bug.cgi?id=142303
2420
2421         Reviewed by Myles C. Maxfield.
2422
2423         * DumpRenderTree/mac/DumpRenderTree.mm:
2424         (setDefaultsToConsistentValuesForTesting):
2425         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2426         (WTR::InjectedBundle::platformInitialize):
2427
2428 2015-03-04  Chris Dumez  <cdumez@apple.com>
2429
2430         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
2431         https://bugs.webkit.org/show_bug.cgi?id=142314
2432         <rdar://problem/20046835>
2433
2434         Reviewed by Ryosuke Niwa.
2435
2436         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
2437         to get WK2 code coverage.
2438
2439         * BuildSlaveSupport/build.webkit.org-config/config.json:
2440
2441 2015-03-04  Alex Christensen  <achristensen@webkit.org>
2442
2443         Move content extensions test to properly named directory.
2444         https://bugs.webkit.org/show_bug.cgi?id=142299
2445
2446         Reviewed by Tim Horton.
2447
2448         * WebKitTestRunner/mac/TestControllerMac.mm:
2449         (WTR::TestController::platformConfigureViewForTest):
2450
2451 2015-03-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2452
2453         W3C test importer should use filesystem instead of os.walk
2454         https://bugs.webkit.org/show_bug.cgi?id=142085
2455
2456         Reviewed by Bem Jones-Bey.
2457
2458         Added FileSystem.dirs_under to remove the use of os.walk in test importer.
2459         Added MockFileSystem.dirs_under and MockFileSystem.getsize to enable unit testing of test importer.
2460         Added unit test for FileSystem.dirs_under and MockFileSystem.dirs_under.
2461
2462         Made use of FileSystem.dirs_under within TestImporter.find_importable_tests.
2463         Added a unit test to check that test importer is now black-box testable using a Mock system.
2464
2465         * Scripts/webkitpy/common/system/filesystem.py:
2466         (FileSystem.dirs_under): Returns a list of filtered sub-directories.
2467         (FileSystem.dirs_under.filter_all):
2468         * Scripts/webkitpy/common/system/filesystem_mock.py:
2469         (MockFileSystem.dirs_under):
2470         (MockFileSystem.dirs_under.filter_all):
2471         (MockFileSystem.getsize):
2472         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
2473         (MockFileSystemTest.test_dirs_under):
2474         (MockFileSystemTest.test_dirs_under.filter_dir):
2475         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2476         (RealFileSystemTest.test_sep):
2477         (RealFileSystemTest):
2478         (RealFileSystemTest.test_dirs_under):
2479         (RealFileSystemTest.test_dirs_under.filter_this_dir):
2480         * Scripts/webkitpy/w3c/test_importer.py:
2481         (TestImporter.do_import):
2482         (TestImporter.find_importable_tests.should_keep_subdir):
2483         (TestImporter.find_importable_tests):
2484         (TestImporter.should_keep_subdir): Deleted.
2485         (TestImporter.should_skip_file): Deleted.
2486         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2487         (TestImporterTest.test_import_dir_with_empty_init_py): Added test to ensure empty __init__.py are no longer empty once imported.
2488
2489 2015-03-04  Timothy Horton  <timothy_horton@apple.com>
2490
2491         [WebEditingTester] Add support for the find and replace bar
2492         https://bugs.webkit.org/show_bug.cgi?id=142247
2493
2494         Reviewed by Enrica Casucci.
2495
2496         While it's not hooked up yet in WKWebView, adding support for the
2497         find bar to WebEditingTester will help us implement that functionality.
2498
2499         * WebEditingTester/AppDelegate.h:
2500         * WebEditingTester/AppDelegate.m:
2501         (-[WebEditingAppDelegate performTextFinderAction:]):
2502         * WebEditingTester/MainMenu.xib:
2503         Receive performTextFinderAction: and forward it to the frontmost WebDocumentController.
2504
2505         * WebEditingTester/WK2WebDocumentController.m:
2506         (-[WK2WebDocumentController awakeFromNib]):
2507         (-[WK2WebDocumentController performTextFinderAction:]):
2508         (-[WK2WebDocumentController findBarView]):
2509         (-[WK2WebDocumentController setFindBarView:]):
2510         (-[WK2WebDocumentController isFindBarVisible]):
2511         (-[WK2WebDocumentController setFindBarVisible:]):
2512         (-[WK2WebDocumentController findBarViewDidChangeHeight]):
2513         (-[WK2WebDocumentController layout]):
2514         Implement performTextFinderAction: for WebKit2, and have a NSTextFinder
2515         pointing at the WKWebView (currently nothing will work, but the bar will
2516         show up). Install and uninstall the bar as needed.
2517
2518         * WebEditingTester/WebDocument.xib:
2519         Don't use a full-size content view. There's no need, and it makes find
2520         bar layout harder.
2521
2522         * WebEditingTester/WebDocumentController.h:
2523         * WebEditingTester/WebDocumentController.m:
2524         (-[WebDocumentController performTextFinderAction:]):
2525
2526 2015-03-03  Sam Weinig  <sam@webkit.org>
2527
2528         [Content Extensions] Split parsing and compiling of content extensions into their own files
2529         https://bugs.webkit.org/show_bug.cgi?id=142259
2530
2531         Reviewed by Anders Carlsson.
2532
2533         Add basic unit test for the content filter compiler.
2534
2535         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2536         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Added.
2537         (WebCore::ContentExtensions::operator<<):
2538         (TestWebKitAPI::ContentFilterTest::SetUp):
2539         (TestWebKitAPI::TEST_F):
2540
2541 2015-03-04  Matthew Mirman  <mmirman@apple.com>
2542
2543         Cleaned up BuildAndTestFactory to not be a near duplicate of TestFactory
2544         https://bugs.webkit.org/show_bug.cgi?id=142230
2545
2546         Reviewed by Csaba Osztrogonác.
2547
2548         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2549         (TestFactory):
2550         (TestFactory.getProduct): Added
2551         (TestFactory.__init__): moved downloader to getProduct
2552         (BuildAndTestFactory):        
2553         (BuildAndTestFactory.getProduct): Added
2554         (BuildAndTestFactory.__init__): made to call TestFactory.__init__ and append steps to the end.
2555         (BuildAndTestWebKit2Factory): Deleted.  Wasn't used anywhere.
2556
2557 2015-03-04  Debarshi Ray  <debarshir@gnome.org>
2558
2559         [GTK] WebView should hold a reference on WebContext because non-default contexts are a reality
2560         https://bugs.webkit.org/show_bug.cgi?id=142225
2561
2562         Reviewed by Carlos Garcia Campos.
2563
2564         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2565         (testWebViewWebContextLifetime):
2566         (beforeAll):
2567
2568 2015-03-03  David Kilzer  <ddkilzer@apple.com>
2569
2570         [iOS] Crash logs can't be found on ios-simulator because WebKitTestRunner returns the wrong process name
2571         <http://webkit.org/b/142243>
2572
2573         Reviewed by Alexey Proskuryakov.
2574
2575         * WebKitTestRunner/TestController.cpp:
2576         (WTR::TestController::webProcessName):
2577         (WTR::TestController::networkProcessName):
2578         - Return the same process name on iOS and Mac because they both
2579           use the same process name for local engineering builds.
2580
2581 2015-03-03  David Kilzer  <ddkilzer@apple.com>
2582
2583         check-webkit-style: Add exception for FrameworkSoftLink.h header order
2584         <http://webkit.org/b/141872>
2585
2586         Reviewed by Alex Christensen.
2587
2588         * Scripts/webkitpy/style/checkers/cpp.py: Remove unneeded
2589         semi-colons in various places and fix whitespace.
2590         (_IncludeState): Add _SOFT_LINK_HEADER and _SOFT_LINK_SECTION
2591         constants.
2592         (_IncludeState.__init__): Add self._visited_soft_link_section
2593         boolean state variable.
2594         (_IncludeState.visited_soft_link_section): Getter for
2595         self._visited_soft_link_section.
2596         (_IncludeState.check_next_include_order): Update state machine
2597         for soft-link headers.  Add check that soft-link headers always
2598         appear last.
2599         (_classify_include): Add check for soft-link header type.
2600         (check_include_line): Return early if there is a soft-link
2601         header error.
2602
2603         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2604         (OrderOfIncludesTest.test_public_primary_header): Add tests for
2605         including soft-link headers.
2606         (OrderOfIncludesTest.test_classify_include): Add test for
2607         _SOFT_LINK_HEADER type.
2608
2609 2015-03-03  Alexey Proskuryakov  <ap@apple.com>
2610
2611         build.webkit.org/dashboard: Don't repeatedly handle each test type
2612         https://bugs.webkit.org/show_bug.cgi?id=142211
2613
2614         Reviewed by Tim Horton and Matt Hanson.
2615
2616         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2617         (Buildbot.prototype.javascriptTestResultsURLForIteration): Deleted.
2618         (Buildbot.prototype.apiTestResultsURLForIteration): Deleted.
2619         (Buildbot.prototype.platformAPITestResultsURLForIteration): Deleted.
2620         (Buildbot.prototype.webkitpyTestResultsURLForIteration): Deleted.
2621         (Buildbot.prototype.webkitperlTestResultsURLForIteration): Deleted.
2622         (Buildbot.prototype.bindingsTestResultsURLForIteration): Deleted.
2623         Removed functions that build a link to test step results. The buildbot provides
2624         these links in JSON.
2625
2626         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2627         (BuildbotIteration): Put failing tests into an array, instead of named variables.
2628         (BuildbotIteration.ProductiveSteps): Removed step names that are not used on build.webkit.org.
2629         We can easily add them to the map as needed.
2630         (BuildbotIteration.TestSteps): Added a list of test steps to be displayed by test queues.
2631         (BuildbotIteration.prototype._parseData): Moved code for parsing step results away
2632         to BuildbotTestResults class. We used to parse here, build an intermediate data structure,
2633         and then build a BuildbotTestResults object, which was strange.
2634         (BuildbotIteration.prototype.loadLayoutTestResults): Ditto.
2635
2636         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2637         Corrected an unrelated assertion that was buggy, and kept firing.
2638
2639         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2640         (BuildbotTestResults):
2641         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
2642         (BuildbotTestResults.prototype._parseResults):
2643         (BuildbotTestResults.prototype.addFullLayoutTestResults):
2644         Moved the code for parsing JSON results for a single step here.
2645
2646         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2647         (BuildbotTesterQueueView.prototype._testStepFailureDescription):
2648         (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount):
2649         (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
2650         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Deleted.
2651         (BuildbotTesterQueueView.prototype.update): Deleted.
2652         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Deleted.
2653         Updated for the new data structures. One behavior change is that we now display individual
2654         counts when multiple test kinds fail, e.g. "1 javascript test failure, 83+ layout
2655         test failures, 3 platform api test failures".
2656
2657 2015-03-03  Matthew Mirman  <mmirman@apple.com>
2658
2659         JSC tests should not be repeated twice for each branch builder, and should if possible have their own queue.
2660         https://bugs.webkit.org/show_bug.cgi?id=142094
2661
2662         Reviewed by Csaba Osztrogonác.
2663
2664         * BuildSlaveSupport/build.webkit.org-config/config.json: Added bots 155 and 157
2665         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2666         (TestFactory):
2667         (TestFactory.__init__): Made running of JSC tests conditional.
2668         (TestAllButJSCFactory):
2669         (TestJSCFactory): Added.
2670         (TestJSCFactory.__init__):
2671         (TestWebKit2AndJSCFactory): Added factory to not run JSC tests on WebKit2.
2672
2673 2015-03-03  David Kilzer  <ddkilzer@apple.com>
2674
2675         `build-webkit --help` is wrong about how to build for the iOS simulator
2676         <http://webkit.org/b/142223>
2677
2678         Reviewed by Csaba Osztrogonác.
2679
2680         * Scripts/build-webkit: Fix help.
2681
2682 2015-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2683
2684         Unreviewed. Bump libsoup version to 2.49.91.1 to fix 32 bit build.
2685
2686         * gtk/jhbuild.modules:
2687
2688 2015-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2689
2690         [SOUP] Synchronous XMLHttpRequests can time out when we reach the max connections limit
2691         https://bugs.webkit.org/show_bug.cgi?id=141508
2692
2693         Reviewed by Sergio Villar Senin.
2694
2695         Add a unit test to check that synchronous XHRs load even if the
2696         maximum connection limits are reached.
2697
2698         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2699         (testWebViewSyncRequestOnMaxConns):
2700         (serverCallback):
2701         (beforeAll):
2702         * gtk/jhbuild.modules: Bump libsoup version to 2.49.91.
2703
2704 2015-03-02  Alexey Proskuryakov  <ap@apple.com>
2705
2706         Update the name of ASan build step.
2707
2708         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2709
2710 2015-03-02  Jer Noble  <jer.noble@apple.com>
2711
2712         [WK1][WK2][Mac] Fullscreen animation is incorrect when page is scaled.
2713         https://bugs.webkit.org/show_bug.cgi?id=142121
2714
2715         Reviewed by Simon Fraser.
2716
2717         Add a test which changes the WebView's page scale, then enters fullscreen mode, and verifies
2718         that the initial and final screen rects for the web content are as expected.
2719
2720         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2721         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.html: Added.
2722         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm: Added.
2723         (-[FullscreenStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
2724         (runJavaScriptAlert):
2725         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
2726         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
2727         (TestWebKitAPI::FullscreenZoomInitialFrame::setPageScale):
2728         (TestWebKitAPI::FullscreenZoomInitialFrame::sendMouseDownEvent):
2729         (TestWebKitAPI::FullscreenZoomInitialFrame::runTest):
2730         (TestWebKitAPI::TEST_F):
2731
2732 2015-03-01  David Kilzer  <ddkilzer@apple.com>
2733
2734         LayoutTestRealy: Prepend __XPC_ to the key, not the value!
2735
2736         Follow-up fix for:
2737
2738         LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
2739         <http://webkit.org/b/142145>
2740
2741         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2742         (-[LTRelayController _environmentVariables]): Fix think-o.
2743
2744 2015-03-01  David Kilzer  <ddkilzer@apple.com>
2745
2746         LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
2747         <http://webkit.org/b/142145>
2748
2749         Reviewed by Simon Fraser.
2750
2751         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2752         (-[LTRelayController _environmentVariables]): Add.
2753         (-[LTRelayController launchApp]): Use -_environmentVariables.
2754
2755 2015-02-28  David Kilzer  <ddkilzer@apple.com>
2756
2757         [iOS] Stop running webkit-build-directory on every layout test
2758
2759         This was originally fixed by David Farler for Bug 135409 in
2760         r172602.
2761
2762         * Scripts/webkitpy/port/ios.py:
2763         (IOSSimulatorPort.relay_path): Mark as @memoized so it doesn't
2764         run webkit-build-directory every time it's called.
2765
2766 2015-02-28  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2767
2768         W3C importer should use filesystem instead of shutil/host
2769         https://bugs.webkit.org/show_bug.cgi?id=142012
2770
2771         Reviewed by Bem Jones-Bey.
2772
2773         Removed direct use of python shutil and os, except for os.walk which will require its own fix.
2774
2775         * Scripts/webkitpy/w3c/test_importer.py:
2776         (main):
2777         (TestImporter.do_import):
2778         (TestImporter.find_importable_tests):
2779         (TestImporter.import_tests):
2780         (TestImporter.remove_deleted_files):
2781         (TestImporter.write_import_log):
2782
2783 2015-02-28  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2784
2785         W3C test importer should use filesystem to read and write files
2786         https://bugs.webkit.org/show_bug.cgi?id=142084
2787
2788         Reviewed by Bem Jones-Bey.
2789
2790         Use of FileSystem.write_binary_file, read_text_file and write_text_file in lieu of open().
2791
2792         * Scripts/webkitpy/w3c/test_importer.py:
2793         (TestImporter.import_tests):
2794         (TestImporter.remove_deleted_files):
2795         (TestImporter.write_import_log):
2796
2797 2015-02-27  Sam Weinig  <sam@webkit.org>
2798
2799         Add WebKit2 SPI to create a DOM File object
2800         https://bugs.webkit.org/show_bug.cgi?id=142109
2801
2802         Reviewed by Tim Horton.
2803
2804         Add a test for WKBundleFileHandleRef.
2805
2806         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2807         * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle.cpp: Added.
2808         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2809         (TestWebKitAPI::didFinishLoadForFrame):
2810         (TestWebKitAPI::TEST):
2811         * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle_Bundle.cpp: Added.
2812         (TestWebKitAPI::WKBundleFileHandleTest::WKBundleFileHandleTest):
2813         * TestWebKitAPI/Tests/WebKit2/bundle-file.html: Added.
2814
2815 2015-02-27  Michael Saboff  <msaboff@apple.com>
2816
2817         Add ability for run-jsc-benchmarks to set library path from test binary when run on a build bot
2818         https://bugs.webkit.org/show_bug.cgi?id=142112
2819
2820         Reviewed by Filip Pizlo.
2821
2822         Added check for VMs in the form of <someDir>/{DumpRenderTree,webkitTestRunner,jsc} and use
2823         <someDir> as the library path.
2824
2825         * Scripts/run-jsc-benchmarks:
2826
2827 2015-02-27  Alex Christensen  <achristensen@webkit.org>
2828
2829         [WinCairo] Unreviewed build fix.
2830
2831         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
2832         Use TestWebKitAPIPrefix.h like in TestWebKitAPICommon.props.
2833
2834 2015-02-27  Anders Carlsson  <andersca@apple.com>
2835
2836         Add infrastructure for handling website data in the network process
2837         https://bugs.webkit.org/show_bug.cgi?id=142092
2838
2839         Reviewed by Andreas Kling.
2840
2841         Add a menu item that will fetch all website data, delete the returned data records, and
2842         fetch all website data again so we can confirm that it's all empty.
2843
2844         * MiniBrowser/mac/WK2BrowserWindowController.m:
2845         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
2846
2847 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
2848
2849         [Win] Remove remaining SafariTheme cruft
2850         https://bugs.webkit.org/show_bug.cgi?id=142075
2851
2852         Reviewed by Anders Carlsson.
2853
2854         Remove reference to SafariTheme-switching preference.
2855
2856         * DumpRenderTree/win/DumpRenderTree.cpp:
2857         (resetWebPreferencesToConsistentValues):
2858         (prepareConsistentTestingEnvironment):
2859
2860 2015-02-26  Doug Russell  <d_russell@apple.com>
2861
2862         AX: Expose caret browsing preference to accessibility API
2863         https://bugs.webkit.org/show_bug.cgi?id=141862
2864
2865         Reviewed by Chris Fleizach.
2866
2867         Exposing the caret browsing setting on WebCore::Frame via the accessibility API would allow assistive tech apps to enable it contextually (for example, when the assistive tech app is running).
2868         Enabling caret browsing when assistive tech apps are running greatly improves the reliability of keyboard navigation on the web. Most especially in cases where selection would be disrupted by focus events.
2869
2870         * DumpRenderTree/AccessibilityUIElement.cpp:
2871         (setBoolAttributeValueCallback):
2872         (selectedTextMarkerRangeCallback):
2873         (resetSelectedTextMarkerRangeCallback):
2874         (AccessibilityUIElement::setBoolAttributeValue):
2875         (AccessibilityUIElement::selectedTextMarkerRange):
2876         (AccessibilityUIElement::resetSelectedTextMarkerRange):
2877         (AccessibilityUIElement::getJSClass):
2878         * DumpRenderTree/AccessibilityUIElement.h:
2879         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2880         (AccessibilityUIElement::setBoolAttributeValue):
2881         (AccessibilityUIElement::selectedTextMarkerRange):
2882         (AccessibilityUIElement::resetSelectedTextMarkerRange):
2883         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2884         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
2885         (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
2886         (WTR::AccessibilityUIElement::setBoolAttributeValue):
2887         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2888         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2889         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2890         (WTR::AccessibilityUIElement::setBoolAttributeValue):
2891         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
2892         (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
2893
2894 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
2895
2896         [Win] Remove WebKitExportGenerator project (and related)
2897         https://bugs.webkit.org/show_bug.cgi?id=142035
2898
2899         Reviewed by Dean Jackson.
2900
2901         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't look for a
2902         build log from WebKitExportGenerator.
2903
2904 2015-02-26  Csaba Osztrogonác  <ossy@webkit.org>
2905
2906         [EFL] Bump EFL version to 1.13.0
2907         https://bugs.webkit.org/show_bug.cgi?id=141708
2908
2909         Reviewed by Gyuyoung Kim.
2910
2911         * efl/jhbuild.modules:
2912
2913 2015-02-26  Sam Weinig  <sam@webkit.org>
2914
2915         Check in missing WebEditingTester.xcconfig file.
2916
2917         * WebEditingTester/Configurations/WebEditingTester.xcconfig: Added.
2918
2919 2015-02-26  Csaba Osztrogonác  <ossy@webkit.org>
2920
2921         [webkitpy] Remove skipped file related crufts
2922         https://bugs.webkit.org/show_bug.cgi?id=142046
2923
2924         Reviewed by Ryosuke Niwa.
2925
2926         * Scripts/webkitpy/port/base.py:
2927         (Port.skipped_layout_tests):
2928         (Port._tests_from_skipped_file_contents): Deleted.
2929         (Port): Deleted.
2930         (Port._expectations_from_skipped_files): Deleted.
2931         * Scripts/webkitpy/port/mac_unittest.py:
2932         (MacTest.test_default_timeout_ms):
2933         (MacTest): Deleted.
2934         (test_tests_from_skipped_file_contents): Deleted.
2935
2936 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
2937
2938         [Win] Unreviewed WinCairo build fix after r180653.
2939
2940         TestWebKitAPI should know about proper WEBCORE_EXPORT definitions.
2941
2942         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2943         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
2944         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
2945         * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Added.
2946         * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Added.
2947
2948 2015-02-25  Brent Fulgham  <bfulgham@apple.com>
2949
2950         [Win] Use WEBCORE_EXPORT instead of Definition file
2951         https://bugs.webkit.org/show_bug.cgi?id=141734
2952
2953         Reviewed by Alex Christensen.
2954
2955         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2956         Use a precompiled header so we can define our export macros properly.
2957         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
2958         Visual studio automatic update stuff.
2959         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
2960         Set up Precompiled Header use for project..
2961         * DumpRenderTree/win/DumpRenderTreePrefix.cpp: Added.
2962         * DumpRenderTree/DumpRenderTreePrefix.h: Update with proper export
2963         declarations for building DumpRenderTree as a client of
2964         WebCore/WebKit.
2965
2966 2015-02-25  Mark Lam  <mark.lam@apple.com>
2967
2968         ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack.
2969         <https://webkit.org/b/141672>
2970
2971         Reviewed by Alexey Proskuryakov.
2972
2973         ASan does not like the fact that we memcpy the stack for GC scans.  So,
2974         we're working around this by using our own memcpy (asanUnsafeMemcpy)
2975         implementation that we can tell ASan to ignore.
2976
2977         Also removed the previous added directive to ignore *tryCopyOtherThreadStack*
2978         which isn't effective for working around this issue. 
2979
2980         * asan/webkit-asan-ignore.txt:
2981
2982 2015-02-25  Benjamin Poulain  <bpoulain@apple.com>
2983
2984         CodeBlock crashes when dumping op_push_name_scope
2985         https://bugs.webkit.org/show_bug.cgi?id=141953
2986
2987         Reviewed by Filip Pizlo.
2988
2989         * Scripts/run-jsc-stress-tests:
2990
2991 2015-02-25  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2992
2993         W3C test importer should use argparse instead of optparse
2994         https://bugs.webkit.org/show_bug.cgi?id=142013
2995
2996         Reviewed by Bem Jones-Bey.
2997
2998         * Scripts/webkitpy/w3c/test_importer.py:
2999         (main): Updating according argparse.
3000         (parse_args): Moving from optparse to argparse.
3001
3002 2015-02-25  Brady Eidson  <beidson@apple.com>
3003
3004         Get rid of TestInvocation::pathOrURL
3005         https://bugs.webkit.org/show_bug.cgi?id=142021
3006
3007         Reviewed by Tim Horton.
3008
3009         The pathOrURL string is a relative path used as an argument to WebKitTestRunner,
3010         but most code that uses it expected an absolute path.
3011
3012         This gets rid of the member and replaces all uses with a more descriptive "urlContains" method.
3013
3014         * WebKitTestRunner/TestController.cpp:
3015         (WTR::TestController::updateWebViewSizeForTest):
3016         (WTR::TestController::updateWindowScaleForTest):
3017         (WTR::shouldUseFixedLayout):
3018         (WTR::TestController::updateLayoutTypeForTest):
3019
3020         * WebKitTestRunner/TestInvocation.cpp:
3021         (WTR::TestInvocation::TestInvocation):
3022         (WTR::TestInvocation::urlContains):
3023         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
3024         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
3025         (WTR::TestInvocation::invoke):
3026         (WTR::shouldLogFrameLoadDelegates): Deleted.
3027         (WTR::shouldLogHistoryClientCallbacks): Deleted.
3028         * WebKitTestRunner/TestInvocation.h:
3029         (WTR::TestInvocation::pathOrURL): Deleted.
3030
3031         * WebKitTestRunner/ios/TestControllerIOS.mm:
3032         (WTR::shouldMakeViewportFlexible):
3033         (WTR::TestController::platformConfigureViewForTest):
3034
3035         * WebKitTestRunner/mac/TestControllerMac.mm:
3036         (WTR::shouldUseThreadedScrolling):
3037         (WTR::TestController::platformConfigureViewForTest):
3038
3039 2015-02-25  Brady Eidson  <beidson@apple.com>
3040
3041         Layout test support for user content filters
3042         https://bugs.webkit.org/show_bug.cgi?id=142018
3043
3044         Reviewed by Tim Horton.
3045
3046         * WebKitTestRunner/TestController.cpp:
3047         (WTR::TestController::resetStateToConsistentValues): Clear all user content filters between tests.
3048
3049         * WebKitTestRunner/mac/TestControllerMac.mm:
3050         (WTR::TestController::platformConfigureViewForTest): For all tests with usercontentfilter/ in their path try to load a matching .json
3051           file before loading the test itself.
3052
3053 2015-02-24  Sam Weinig  <sam@webkit.org>
3054
3055         Convert WebEditingTester to use xcconfig files
3056         https://bugs.webkit.org/show_bug.cgi?id=141879
3057
3058         Reviewed by Darin Adler.
3059
3060         Add xcconfig files to WebEditingTester based on the ones used by MiniBrowser.
3061
3062         * WebEditingTester/Configurations: Added.
3063         * WebEditingTester/Configurations/Base.xcconfig: Added.
3064         * WebEditingTester/Configurations/DebugRelease.xcconfig: Added.
3065         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3066
3067 2015-02-24  Andy Estes  <aestes@apple.com>
3068
3069         Teach MiniBrowser how to disable per-window web processes
3070         https://bugs.webkit.org/show_bug.cgi?id=141988
3071
3072         Reviewed by Darin Adler.
3073
3074         * MiniBrowser/mac/AppDelegate.m:
3075         (defaultConfiguration): Created a _WKProcessPoolConfiguration with maximumProcessCount == 1 if per-window web processes are disabled.
3076         * MiniBrowser/mac/SettingsController.h:
3077         * MiniBrowser/mac/SettingsController.m:
3078         (-[SettingsController _populateMenu]): Added a new Settings menu item.
3079         (-[SettingsController validateMenuItem:]): Validated the new Settings menu item.
3080         (-[SettingsController togglePerWindowWebProcessesDisabled:]): Displayed an alert informing the user that MiniBrowser must be restarted for the setting to take effect.
3081         (-[SettingsController perWindowWebProcessesDisabled]): Returned the value from user defaults.
3082
3083 2015-02-24  Alexey Proskuryakov  <ap@apple.com>
3084
3085         Bot watcher's dashboard sometimes hits an assertion: data.num_missing === this.layoutTestResults.testsWithMissingResults.length
3086         https://bugs.webkit.org/show_bug.cgi?id=141889
3087
3088         Reviewed by Darin Adler.
3089
3090         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3091
3092 2015-02-24  Yusuke Suzuki  <utatane.tea@gmail.com>
3093
3094         REGRESSION(r179429): Can't type comments in Facebook
3095         https://bugs.webkit.org/show_bug.cgi?id=141859
3096
3097         Reviewed by Brent Fulgham.
3098
3099         Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
3100
3101         * DumpRenderTree/mac/DumpRenderTree.mm:
3102         (resetWebPreferencesToConsistentValues):
3103         * DumpRenderTree/win/DumpRenderTree.cpp:
3104         (resetWebPreferencesToConsistentValues):
3105         * WebKitTestRunner/TestController.cpp:
3106         (WTR::TestController::resetPreferencesToConsistentValues):
3107
3108 2015-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3109
3110         Crash loading local file with WebPageProxy::loadAlternateHTMLString
3111         https://bugs.webkit.org/show_bug.cgi?id=141867
3112
3113         Reviewed by Anders Carlsson.
3114
3115         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
3116         (TestWebKitAPI::loadAlternateHTMLString): Split most of this test into a function so it can
3117         be shared with the new test.
3118         (TestWebKitAPI::TEST): Add a cross-platform test for this crash.
3119         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Add a GTK+ test for this crash.
3120         (testLoadAlternateHTMLForLocalPage):
3121         (beforeAll):
3122
3123 2015-02-24  David Kilzer  <ddkilzer@apple.com>
3124
3125         [iOS] Implement WTR::activateFonts() to fix missing fonts in WebKit2 test runs
3126         <http://webkit.org/b/141900>
3127
3128         Reviewed by Myles C. Maxfield.
3129
3130         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
3131         (OTHER_LDFLAGS_BASE): Link to CoreText.framework.
3132         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm: Rename from Tools/WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm.
3133         - Rename to share code with iOS.
3134         - Add USE(APPKIT) around AppKit-specific headers and code.
3135         - Fix a check-webkit-style warning.
3136         * WebKitTestRunner/InjectedBundle/ios/ActivateFontsIOS.mm: Remove.
3137         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3138         - Rename mac/ActivateFonts.mm to cocoa/ActivateFontsCocoa.mm.
3139         - Remove ios/ActivateFontsIOS.mm.
3140         - Fix InjectedBundle/cocoa group to represent the directory on
3141           disk.  Includes a change to InjectedBundlePageCocoa.mm.
3142
3143 2015-02-23  Commit Queue  <commit-queue@webkit.org>
3144
3145         Unreviewed, rolling out r180547 and r180550.
3146         https://bugs.webkit.org/show_bug.cgi?id=141957
3147
3148         Broke 10 Windows tests. (Requested by bfulgham_ on #webkit).
3149
3150         Reverted changesets:
3151
3152         "REGRESSION(r179429): Can't type comments in Facebook"
3153         https://bugs.webkit.org/show_bug.cgi?id=141859
3154         http://trac.webkit.org/changeset/180547
3155
3156         "Constructor returning null should construct an object instead
3157         of null"
3158         https://bugs.webkit.org/show_bug.cgi?id=141640
3159         http://trac.webkit.org/changeset/180550
3160
3161 2015-02-23  Yusuke Suzuki  <utatane.tea@gmail.com>
3162
3163         REGRESSION(r179429): Can't type comments in Facebook
3164         https://bugs.webkit.org/show_bug.cgi?id=141859
3165
3166         Reviewed by Geoffrey Garen.
3167
3168         Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
3169
3170         * DumpRenderTree/mac/DumpRenderTree.mm:
3171         (resetWebPreferencesToConsistentValues):
3172         * WebKitTestRunner/TestController.cpp:
3173         (WTR::TestController::resetPreferencesToConsistentValues):
3174
3175 2015-02-23  KwangHyuk Kim  <hyuki.kim@samsung.com>
3176
3177         [EFL] fix eo errors
3178         https://bugs.webkit.org/show_bug.cgi?id=141909
3179
3180         Reviewed by Gyuyoung Kim.
3181
3182         Fix eo errors that occur whenever minibrowser is launched.
3183         - elm_obj_entry_text_style_user_push can only be applied for elm_entry
3184         - elm_obj_win_resize_object_add's first parameter should be elm_win
3185
3186         * MiniBrowser/efl/main.c:
3187         (window_create):
3188
3189 2015-02-23  Ryosuke Niwa  <rniwa@webkit.org>
3190
3191         Unreviewed build fix after r180535. Removed the test case that wasn't compiling.
3192
3193         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3194         (TestWebKitAPI::TEST):
3195
3196 2015-02-23  Brent Fulgham  <bfulgham@apple.com>
3197
3198         WTF::WeakPtr should rename 'forgot' to 'clear' and support nullptr assignment
3199         https://bugs.webkit.org/show_bug.cgi?id=141935
3200
3201         Reviewed by Myles C. Maxfield.
3202
3203         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3204         (TestWebKitAPI::TEST): Updated for 'clear' method rename, and added a few
3205         tests for assigning from nullptr.
3206
3207 2015-02-23  Brent Fulgham  <bfulgham@apple.com>
3208
3209         WTF::WeakPtr should have a 'forget' method.
3210         https://bugs.webkit.org/show_bug.cgi?id=141923
3211
3212         Reviewed by Myles C. Maxfield.
3213
3214         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3215         (TestWebKitAPI::TEST): Added 'Forget' tests case.
3216
3217 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
3218
3219         build.webkit.org/dashboard CrashOnly queues should not show two green bubbles
3220         https://bugs.webkit.org/show_bug.cgi?id=141920
3221
3222         Reviewed by Tim Horton.
3223
3224         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3225         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3226         Do the same thing as we do for regular green bubbles.
3227
3228 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
3229
3230         Bot watcher's dashboard doesn't show a popover for commit history when all commits were to another branch
3231         https://bugs.webkit.org/show_bug.cgi?id=141925
3232
3233         Reviewed by Tim Horton.
3234
3235         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3236         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
3237
3238 2015-02-23  Anders Carlsson  <andersca@apple.com>
3239
3240         Add API for fetching website data records to _WKWebsiteDataStore
3241         https://bugs.webkit.org/show_bug.cgi?id=141926
3242
3243         Reviewed by Beth Dakin.
3244
3245         * MiniBrowser/mac/MainMenu.xib:
3246         * MiniBrowser/mac/WK2BrowserWindowController.m:
3247         (-[WK2BrowserWindowController fetchWebsiteData:]):
3248         Add menu item to fetch and dump website data.
3249
3250 2015-02-23  David Kilzer  <ddkilzer@apple.com>
3251
3252         [iOS] run-webkit-tests --leaks is broken because IOSSimulatorPort has no is_snowleopard attribute
3253         <http://webkit.org/b/141884>
3254
3255         Reviewed by Alexey Proskuryakov.
3256
3257         * Scripts/webkitpy/port/leakdetector.py:
3258         (LeakDetector._callstacks_to_exclude_from_leaks): Remove
3259         snowleopard, lion and older leaks.  Add known leak for
3260         mavericks, but check Port.operating_system before calling
3261         Port.is_mavericks.
3262         * Scripts/webkitpy/port/mac.py:
3263         (MacPort.is_snowleopard): Delete.
3264         (MacPort.is_lion): Delete.
3265         (MacPort.is_mavericks): Add.
3266
3267 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
3268
3269         build.webkit.org/dashboard should filter out commits to other branches
3270         https://bugs.webkit.org/show_bug.cgi?id=140362
3271
3272         Reviewed by Tim Horton.
3273
3274         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3275         (BuildbotQueue):
3276         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3277         (BuildbotQueueView.prototype._presentPopoverForPendingCommits):
3278         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
3279         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration):
3280         (BuildbotQueueView.prototype.revisionContentForIteration):
3281         (BuildbotQueueView.prototype._appendPendingRevisionCount): Deleted.
3282         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Deleted.
3283         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Deleted.
3284         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3285         (Trac.prototype.get oldestRecordedRevisionNumber):
3286         (Trac.prototype.commitsOnBranch):
3287         (Trac.prototype._xmlTimelineURL):
3288         (Trac.prototype._convertCommitInfoElementToObject):
3289         (Trac.prototype._update):
3290         (Trac.prototype.startPeriodicUpdates):
3291         (Trac.prototype.loadMoreHistoricalData):
3292         (Trac.prototype.update): Deleted.
3293
3294 2015-02-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3295
3296         Tests don't work on some bots: Failed to stop wptwk
3297         https://bugs.webkit.org/show_bug.cgi?id=141235
3298
3299         Reviewed by Ryosuke Niwa.
3300
3301         Logging of server subprocesses in launcher script.
3302         Killing of server subprocesses when stopping/before starting.
3303         Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore.
3304
3305         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
3306         (main): Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore. Added logging in a file of server subprocesses to clean them in case of abnormal shutdown. 
3307         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3308         (WebPlatformTestServer.__init__):
3309         (WebPlatformTestServer._stop_running_subservers): Kill server subprocesses based on file created by wpt launcher.
3310         (WebPlatformTestServer):
3311         (WebPlatformTestServer.stop): Overriden to ensure killing subprocesses in case of orphaned process.
3312         (WebPlatformTestServer._stop_running_server): Killing of wpt launcher process after regular shutdown. 
3313         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
3314         (TestWebPlatformTestServer.test_server_closes_previously_spawned_instance): Reworked the test to call start/stop with an existing pid file.
3315         (TestWebPlatformTestServer.test_import_web_platform_test_modules): No change.
3316         (TestWebPlatformTestServer):
3317         (TestWebPlatformTestServer.test_corrupted_subserver_files): Checked that server subprocess cleaning does not throw in case of bad server pid file.
3318
3319 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3320
3321         [WebEditingTester] Allow dropping HTML files on the app
3322         https://bugs.webkit.org/show_bug.cgi?id=141834
3323
3324         Reviewed by Simon Fraser.
3325
3326         * WebEditingTester/AppDelegate.m:
3327         (-[WebEditingAppDelegate openDocument:]):
3328         (-[WebEditingAppDelegate application:openFile:]):
3329         Implement application:openFile:, factoring file loading code out of openDocument.
3330
3331         * WebEditingTester/Info.plist:
3332         Register as an editor for HTML files.
3333
3334         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3335         Enrica is not an organization.
3336
3337 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3338
3339         [WebEditingTester] Expand "WK" to "WebKit" in a few places
3340         https://bugs.webkit.org/show_bug.cgi?id=141833
3341
3342         Reviewed by Anders Carlsson.
3343
3344         * WebEditingTester/AppDelegate.h:
3345         * WebEditingTester/AppDelegate.m:
3346         (-[WebEditingAppDelegate newEditor:]):
3347         (-[WebEditingAppDelegate toggleUseWebKit2ByDefault:]):
3348         (-[WebEditingAppDelegate validateMenuItem:]):
3349         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
3350         (-[WebEditingAppDelegate applicationDidFinishLaunching:]): Deleted.
3351         (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
3352         (-[WebEditingAppDelegate showOperations:]): Deleted.
3353         * WebEditingTester/MainMenu.xib:
3354         The WK abbreviation is unnaturally grating in menu items for some reason.
3355
3356 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3357
3358         [WebEditingTester] Add a custom protocol for loading canned content
3359         https://bugs.webkit.org/show_bug.cgi?id=141830
3360
3361         Reviewed by Enrica Casucci.
3362
3363         Add a canned:// protocol handler, which can be used to emulate behaviors
3364         in WebKit client apps (like Mail) that use custom protocol handlers,
3365         which can have important effects on editing (mostly, the URLs are only
3366         valid inside of the client application, but not when copied/dragged out).
3367
3368         For now, we only support two canned files:
3369
3370             canned://dice is a PNG of dice (stolen from LayoutTests/)
3371             canned://text is the string "canned text" served as text/html
3372
3373         In the future we could support things like very large (generated) files,
3374         progressive loading, etc. to further simulate conditions in other apps.
3375
3376         * WebEditingTester/AppDelegate.m:
3377         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
3378         Register the protocol with CFNetwork, and the scheme with WebKit2.
3379
3380         * WebEditingTester/Canned Content/dice.png: Added.
3381         * WebEditingTester/CannedContent.h: Added.
3382         * WebEditingTester/CannedContent.m: Added.
3383         (-[CannedContent initWithRequest:cachedResponse:client:]):
3384         (+[CannedContent canonicalRequestForRequest:]):
3385         (+[CannedContent canInitWithRequest:]):
3386         We only want to handle canned:// URLs.
3387
3388         (-[CannedContent startLoading]):
3389         For now, immediately load the two files we know about.
3390         Otherwise, immediately fail the load.
3391
3392         (-[CannedContent stopLoading]):
3393         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3394
3395 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3396
3397         [WebEditingTester] Implement an open panel
3398         https://bugs.webkit.org/show_bug.cgi?id=141829
3399
3400         Reviewed by Simon Fraser.
3401
3402         * WebEditingTester/AppDelegate.m:
3403         (-[WebEditingAppDelegate _useWebKit1ForOpeningDocument:]):
3404         (-[WebEditingAppDelegate _useWebKit2ForOpeningDocument:]):
3405         (-[WebEditingAppDelegate openDocument:]):
3406         Add an open panel (with radio buttons to pick which WebKit to open with).
3407         Loads the file as an HTML string.
3408
3409 2015-02-20  Simon Fraser  <simon.fraser@apple.com>
3410
3411         [WebEditingTester] @properties, dot syntax, and remember the window position
3412         https://bugs.webkit.org/show_bug.cgi?id=141843
3413
3414         Reviewed by Tim Horton.
3415         
3416         Modernize a bit with more dot syntax, use @property for the web views,
3417         and give the main window an Autosave name so it remembers the widow position.
3418
3419         * WebEditingTester/WK1WebDocumentController.m:
3420         (-[WK1WebDocumentController awakeFromNib]):
3421         (-[WK1WebDocumentController loadHTMLString:]):
3422         * WebEditingTester/WK2WebDocumentController.m:
3423         (-[WK2WebDocumentController awakeFromNib]):
3424         * WebEditingTester/WebDocument.xib:
3425
3426 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3427
3428         [WebEditingTester] Hook up key equivalents for new window action
3429         https://bugs.webkit.org/show_bug.cgi?id=141828
3430
3431         Reviewed by Enrica Casucci.
3432
3433         * WebEditingTester/AppDelegate.h:
3434         * WebEditingTester/AppDelegate.m:
3435         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
3436         (-[WebEditingAppDelegate newEditor:]):
3437         (-[WebEditingAppDelegate _defaultWebDocumentControllerClass]):
3438         (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
3439         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
3440         (defaultConfiguration): Deleted.
3441         (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
3442         Move WKWebViewConfiguration setup into WK2WebDocumentController.
3443         Remove unused application termination code.
3444         Update new-window menu item key equivalents when launching and when
3445         changing the use-WebKit2-by-default setting.
3446         Make WebDocumentController subclasses all initialized the same way,
3447         and use that to factor out alloc/init.
3448         Rename loadContent to loadHTMLString for future use.
3449
3450         * WebEditingTester/MainMenu.xib:
3451         Add default key equivalents.
3452         Cmd-N will always make the default kind of window (controlled by the pref).
3453         Cmd-Opt-N will always make the other kind.
3454         The menu items are configured as alternates so they only show up if you
3455         press alt (just like in MiniBrowser).
3456
3457         * WebEditingTester/WK1WebDocumentController.m:
3458         (-[WK1WebDocumentController loadHTMLString:]):
3459         (-[WK1WebDocumentController loadContent]): Deleted.
3460         * WebEditingTester/WK2WebDocumentController.h:
3461         * WebEditingTester/WK2WebDocumentController.m:
3462         (defaultConfiguration):
3463         (-[WK2WebDocumentController awakeFromNib]):
3464         (-[WK2WebDocumentController loadHTMLString:]):
3465         (-[WK2WebDocumentController initWithConfiguration:]): Deleted.
3466         (-[WK2WebDocumentController dealloc]): Deleted.
3467         * WebEditingTester/WebDocumentController.h:
3468         * WebEditingTester/WebDocumentController.m:
3469         (-[WebDocumentController init]):
3470         (-[WebDocumentController initWithWindow:]):
3471         (+[WebDocumentController defaultEditingSource]):
3472         (-[WebDocumentController loadHTMLString:]):
3473         (-[WebDocumentController windowDidLoad]): Deleted.
3474         (-[WebDocumentController defaultEditingSource]): Deleted.
3475         (-[WebDocumentController applicationTerminating]): Deleted.
3476         (-[WebDocumentController loadContent]): Deleted.
3477
3478 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3479
3480         [WebEditingTester] ARC-ify WebEditingTester
3481         https://bugs.webkit.org/show_bug.cgi?id=141827
3482
3483         Reviewed by Sam Weinig.
3484
3485         * WebEditingTester/AppDelegate.m:
3486         (-[WebEditingAppDelegate showOperations:]):
3487         * WebEditingTester/EditingOperations.m:
3488         (editingOperations):
3489         * WebEditingTester/WK1WebDocumentController.m:
3490         (-[WK1WebDocumentController dealloc]): Deleted.
3491         * WebEditingTester/WK2WebDocumentController.m:
3492         (-[WK2WebDocumentController dealloc]): Deleted.
3493         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3494         Turn on ARC and remove a few retain/release/autorelease calls.
3495         We don't need to implement dealloc in either document controller
3496         because WebView and WKWebView's UIDelegate property does not hold a
3497         strong reference.
3498
3499 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
3500
3501         [WebEditingTester] Factor out list of editing operations
3502         https://bugs.webkit.org/show_bug.cgi?id=141826
3503
3504         Reviewed by Sam Weinig.
3505
3506         * WebEditingTester/AppDelegate.m:
3507         (-[WebEditingAppDelegate showOperations:]):
3508         * WebEditingTester/EditingOperations.h: Added.
3509         * WebEditingTester/EditingOperations.m: Added.
3510         (editingOperations):
3511         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
3512         Move EditingOperations array to its own file, and make it an NSArray
3513         instead of a C array. Adjust accordingly in showOperations:.
3514
3515 2015-02-20  Michael Saboff  <msaboff@apple.com>
3516
3517         DFG JIT needs to check for stack overflow at the start of Program and Eval execution
3518         https://bugs.webkit.org/show_bug.cgi?id=141676
3519
3520         Reviewed by Filip Pizlo.
3521
3522         Set the newly added --maximumEvalCacheableSourceLength option for eager test runs.  This is needed
3523         to allow the eval out of stack tests to tier up.  Without this option, we don't cache the likely
3524         large string expression that we want to eval.
3525
3526         * Scripts/run-jsc-stress-tests:
3527
3528 2015-02-19  Daniel Bates  <dabates@apple.com>
3529
3530         REGRESSION (r180239): run-webkit-test fails to boot simulator device that was booted by previous test run
3531         https://bugs.webkit.org/show_bug.cgi?id=141815
3532         <rdar://problem/19893933>
3533
3534         Reviewed by Simon Fraser.
3535
3536         Fixes an issue where run-webkit-tests would fail to boot the WebKit Tester simulator device if it
3537         was booted by iOS Simulator in a previous run of run-webkit-test.
3538
3539         * Scripts/webkitpy/port/ios.py:
3540         (IOSSimulatorPort.check_sys_deps): Added logic moved from IOSSimulatorPort.setup_test_run().
3541         (IOSSimulatorPort.setup_test_run): Moved logic to quit the iOS Simulator app and wait for the
3542         testing device to be in the shutdown state from here to IOSSimulatorPort.check_sys_deps().
3543
3544 2015-02-19  David Kilzer  <ddkilzer@apple.com>
3545
3546         check-webkit-style: do not warn about missing primary header for *SoftLink.cpp files
3547         <http://webkit.org/b/141799>
3548
3549         Reviewed by Alex Christensen.
3550
3551         * Scripts/webkitpy/style/checkers/cpp.py:
3552         (_IncludeState.check_next_include_order): Don't emit a warning
3553         if the primary header exists and the source file name ends with
3554         "SoftLink.cpp".  Add 'filename' argument to method.
3555         (check_include_line): Pass in 'filename'.
3556
3557         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3558         (OrderOfIncludesTest.test_check_next_include_order__no_config):
3559         (OrderOfIncludesTest.test_check_next_include_order__no_self):
3560         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config):
3561         (OrderOfIncludesTest.test_check_next_include_order__other_then_config):
3562         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely):
3563         - Add test filename arguments for calls to
3564           check_next_include_order().
3565         (OrderOfIncludesTest.test_primary_header): Add test for a file
3566         name ending in "SoftLink.cpp".
3567
3568 2015-02-18  Enrica Casucci  <enrica@apple.com>
3569
3570         Add new tool to test editable Webviews.
3571         https://bugs.webkit.org/show_bug.cgi?id=141772
3572
3573         Reviewed by Tim Horton.
3574
3575         Adding WebEditingTester, a Cocoa application to
3576         test WK1 and Wk2 views in editable mode.
3577
3578         * WebEditingTester: Added.
3579         * WebEditingTester/AppDelegate.h: Added.
3580         * WebEditingTester/AppDelegate.m: Added.
3581         (-[WebEditingAppDelegate init]):
3582         (defaultConfiguration):
3583         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
3584         (-[WebEditingAppDelegate applicationWillTerminate:]):
3585         (-[WebEditingAppDelegate newEditor:]):
3586         (-[WebEditingAppDelegate showOperations:]):
3587         (-[WebEditingAppDelegate useWebKit2ByDefault]):
3588         (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
3589         (-[WebEditingAppDelegate validateMenuItem:]):
3590         * WebEditingTester/Info.plist: Added.
3591         * WebEditingTester/MainMenu.xib: Added.
3592         * WebEditingTester/WK1WebDocumentController.h: Added.
3593         * WebEditingTester/WK1WebDocumentController.m: Added.
3594         (-[WK1WebDocumentController awakeFromNib]):
3595         (-[WK1WebDocumentController loadContent]):
3596         (-[WK1WebDocumentController dealloc]):
3597         (-[WK1WebDocumentController pasteAsMarkup:]):
3598         * WebEditingTester/WK2WebDocumentController.h: Added.
3599         * WebEditingTester/WK2WebDocumentController.m: Added.
3600         (-[WK2WebDocumentController initWithConfiguration:]):
3601         (-[WK2WebDocumentController pasteAsMarkup:]):
3602         (-[WK2WebDocumentController awakeFromNib]):
3603         (-[WK2WebDocumentController dealloc]):
3604         (-[WK2WebDocumentController loadContent]):
3605         * WebEditingTester/WebDocument.xib: Added.
3606         * WebEditingTester/WebDocumentController.h: Added.
3607         * WebEditingTester/WebDocumentController.m: Added.
3608         (-[WebDocumentController initWithWindow:]):
3609         (-[WebDocumentController windowDidLoad]):
3610         (-[WebDocumentController defaultEditingSource]):
3611         (-[WebDocumentController applicationTerminating]):
3612         (-[WebDocumentController loadContent]):
3613         * WebEditingTester/WebEditingTester.xcodeproj: Added.
3614         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj: Added.
3615         * WebEditingTester/main.m: Added.
3616         (main):
3617
3618 2015-02-18  Csaba Osztrogonác  <ossy@webkit.org>
3619
3620         Run JSC tests on ARM EFL bots
3621         https://bugs.webkit.org/show_bug.cgi?id=141165
3622
3623         Reviewed by Alexey Proskuryakov.
3624
3625         * BuildSlaveSupport/build.webkit.org-config/config.json:
3626         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3627         (RunJavaScriptCoreTests.countFailures):
3628         (RunRemoteJavaScriptCoreTests):
3629         (RunRemoteJavaScriptCoreTests.start):
3630         (BuildAndRemoteJSCTestsFactory):
3631         (BuildAndRemoteJSCTestsFactory.__init__):
3632
3633 2015-02-18  Alexey Proskuryakov  <ap@apple.com>
3634
3635         Streamline unexported function build fixes
3636         https://bugs.webkit.org/show_bug.cgi?id=141761
3637
3638         Reviewed by Alex Christensen.
3639
3640         * Scripts/check-for-weak-vtables-and-externals: (readXcode5SymbolsToIgnore): Deleted.
3641         We don't need to ignore symbols that are not exported due to the .unexp file.
3642
3643 2015-02-18  Timothy Horton  <timothy_horton@apple.com>
3644
3645         Remove more references to WebCore.exp.in
3646         https://bugs.webkit.org/show_bug.cgi?id=141747
3647
3648         Reviewed by Alexey Proskuryakov.
3649
3650         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3651         (ShouldBuildTest):
3652
3653 2015-02-17  Myles C. Maxfield  <mmaxfield@apple.com>
3654
3655         Windows test results should not fall back to mac-mountainlion after r180176
3656         https://bugs.webkit.org/show_bug.cgi?id=141719
3657
3658         Reviewed by Brent Fulgham.
3659
3660         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3661         (_should_file_trigger_build):
3662         * Scripts/webkitpy/port/win.py:
3663         (WinPort.default_baseline_search_path):
3664         * Scripts/webkitpy/port/win_unittest.py:
3665         (WinPortTest.test_baseline_search_path):
3666
3667 2015-02-17  Daniel Bates  <dabates@apple.com>
3668
3669         [iOS] run-webkit-tests should check that simctl can boot and shutdown simulator device before running tests
3670         https://bugs.webkit.org/show_bug.cgi?id=141718
3671
3672         Reviewed by Alex Christensen.
3673
3674         We should only run layout tests if simctl can successfully boot and shutdown the testing device.
3675
3676         * Scripts/webkitpy/port/ios.py:
3677         (IOSSimulatorPort.check_sys_deps): Modified to call Simulator.check_simulator_device_and_erase_if_needed().