eaf1e1a98fcffd81bcf3bba07e7303782e761210
[WebKit-https.git] / Tools / ChangeLog
1 2017-02-01  Daniel Bates  <dabates@apple.com>
2
3         REGRESSION (r210820): svn-create-patch does not emit property change only diff
4         https://bugs.webkit.org/show_bug.cgi?id=167169
5
6         Reviewed by David Kilzer.
7
8         More directly handle the SVN 1.9 or newer syntax change for a diff of a copied or moved file
9         - a SVN diff header and an empty body. In particular, remove a duplicate leading SVN diff
10         header from the output of "svn diff" on a file that was copied or moved.
11
12         Following r210820 svn-create-patch emits to standard output a diff only if it has at least one
13         chunk range line (e.g. @@ -0,0 +1,7 @@) as a means to workaround a syntax change in the diff
14         output of a copied or moved file in SVN version 1.9 or newer. In SVN 1.9 or newer "svn diff"
15         of a copied or moved file always emits to standard output a leading SVN diff header (an "Index:"
16         line followed by a separator line) with an empty body; => no chunk range lines. However a diff
17         of a file with only a property change also does not contain any chunk range lines. Therefore
18         svn-create-patch no longer emitted to standard output such a diff. Instead of indirectly detecting
19         a SVN diff header with an empty body by counting the number of chunk range lines in the diff
20         we should directly test for the presence of a leading SVN diff header with an empty body and
21         remove such lines from the diff.
22
23         * Scripts/VCSUtils.pm:
24         (fixSVNPatchForAdditionWithHistory): Added.
25         * Scripts/svn-create-patch:
26         (generateDiff): Pass the output from "svn diff" to fixSVNPatchForAdditionWithHistory() when
27         we have a non empty patch for an added file with history (i.e. a copied or moved file).
28         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Added.
29
30 2017-02-01  Eric Carlson  <eric.carlson@apple.com>
31
32         [Mac] Update CARingBuffer class
33         https://bugs.webkit.org/show_bug.cgi?id=167656
34
35         Reviewed by Jer Noble.
36
37         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
38         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp: Added.
39         (TestWebKitAPI::CARingBufferTest::SetUp):
40         (TestWebKitAPI::CARingBufferTest::setup):
41         (TestWebKitAPI::CARingBufferTest::setListDataBuffer):
42         (TestWebKitAPI::CARingBufferTest::description):
43         (TestWebKitAPI::CARingBufferTest::bufferList):
44         (TestWebKitAPI::CARingBufferTest::ringBuffer):
45         (TestWebKitAPI::CARingBufferTest::capacity):
46         (TestWebKitAPI::CARingBufferTest::audioBufferListSizeForStream):
47         (TestWebKitAPI::CARingBufferTest::configureBufferListForStream):
48         (TestWebKitAPI::TEST_F):
49         (TestWebKitAPI::MixingTest::run):
50
51 2017-02-01  Alexey Proskuryakov  <ap@apple.com>
52
53         [Mac] TestWebKitAPI includes system frameworks incorrectly
54         https://bugs.webkit.org/show_bug.cgi?id=167703
55         rdar://problem/30301498
56
57         Reviewed by Ryosuke Niwa.
58
59         FRAMEWORK_SEARCH_PATH results in frameworks being treated as user ones, not system.
60         Make TestWebKitAPI use -iframework instead, like the rest of WebKit does.
61
62         Also, reduced the number of subframework search paths, looks like we only need one now.
63
64         * TestWebKitAPI/Configurations/Base.xcconfig:
65
66 2017-02-01  Brent Fulgham  <bfulgham@apple.com>
67
68         Correct "filesHaveSameVolume" predicate
69         https://bugs.webkit.org/show_bug.cgi?id=167696
70         <rdar://problem/30298722>
71
72         Reviewed by David Kilzer.
73
74         Add new tests that confirm that the 'filesHaveSamePath' predicate properly handles
75         percent-escaped path inputs.
76
77         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
78         (TestWebKitAPI::FileSystemTest::spaceContainingFilePath):
79         (TestWebKitAPI::FileSystemTest::bangContainingFilePath):
80         (TestWebKitAPI::FileSystemTest::quoteContainingFilePath):
81         (TestWebKitAPI::TEST_F):
82
83 2017-02-01  Tomas Popela  <tpopela@redhat.com>
84
85         Unreviewed. Fix coding style in MiniBrowser
86
87         * MiniBrowser/gtk/BrowserWindow.c:
88         (editingCommandCallback):
89         (insertImageCommandCallback):
90         (insertLinkCommandCallback):
91
92 2017-02-01  Tomas Popela  <tpopela@redhat.com>
93
94         [GTK] Add an API to add a custom tab into the print dialog
95         https://bugs.webkit.org/show_bug.cgi?id=151998
96
97         Reviewed by Carlos Garcia Campos.
98
99         Add a new WebKitPrintOperation/custom-widget test in TestPrinting
100         that is testing a newly added API.
101
102         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
103         (testPrintCustomWidget):
104         (beforeAll):
105
106 2017-02-01  Enrique Ocaña González  <eocanha@igalia.com>
107
108         [GStreamer][MSE] qtdemux: Update the tfdt patch to the version finally accepted upstream
109         https://bugs.webkit.org/show_bug.cgi?id=166529
110
111         Reviewed by Xabier Rodriguez-Calvar.
112
113         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch:
114         New patch version accepted in GStreamer upstream.
115
116 2017-02-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
117
118         [GTK] Install either libxfont1-dev or libxfont-dev as dependency
119         https://bugs.webkit.org/show_bug.cgi?id=167498
120
121         Reviewed by Carlos Garcia Campos.
122
123         Depending on the distro version you can need either libxfont1-dev
124         or libfont-dev to build with jhbuild.
125
126         * gtk/install-dependencies:
127
128 2017-01-31  Ryan Haddad  <ryanhaddad@apple.com>
129
130         Disable API test WebKit2.WKWebProcessPlugInRangeHandle
131         https://bugs.webkit.org/show_bug.cgi?id=167594
132
133         Unreviewed test gardening.
134
135         Disabling this test while we investigate the cause of a timeout on ios-simulator.
136
137         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
138         (TEST):
139
140 2017-01-31  Filip Pizlo  <fpizlo@apple.com>
141
142         Move slow-running microbenchmarks out of JSTests/microbenchmarks
143         https://bugs.webkit.org/show_bug.cgi?id=167676
144
145         Reviewed by Saam Barati.
146
147         * Scripts/run-javascriptcore-tests:
148         (runJSCStressTests): Add slowMicrobenchmarks.yaml.
149
150 2017-01-31  Megan Gardner  <megan_gardner@apple.com>
151
152         Make Dump Render Tree not crash
153         https://bugs.webkit.org/show_bug.cgi?id=167667
154
155         DumpRenderTree is crashing when running WK2 tests that it's not supposed to be running. 
156         DumpRenderTree uses RunLoop::main.dispatch(), but that crashes because it's not set up on iOS.
157         So we're making use of RunWebThread, which is the correct thing to do on iOS, and it doesn't crash.
158         This does not fix any tests, it just fixes the crash.
159         
160         Reviewed by Simon Fraser.
161
162         * DumpRenderTree/TestRunner.cpp:
163         (TestRunner::callUIScriptCallback):
164
165 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
166
167         Workaround for simctl install failing to report install failure
168         https://bugs.webkit.org/show_bug.cgi?id=167654
169
170         Reviewed by Daniel Bates.
171
172         simctl install will sometimes report success even though install has failed.
173         To workaround this bug, we attempt an app launch after install to ensure
174         install has succeeded.
175
176         * Scripts/webkitpy/xcode/simulator.py:
177         (Device.install_app): Attempt app launch after install, retry install if launch fails.
178         (Device.launch_app): Correct comment.
179
180 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
181
182         Unreviewed webkitpy fix after r211405.
183
184         * Scripts/webkitpy/xcode/simulator.py:
185         (Device.launch_app): Remove @staticmethod on _log_debug_error.
186
187 2017-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
188
189         Unreviewed. Do not include libwebrtc and qunit in GTK+ tarballs.
190
191         * gtk/manifest.txt.in:
192
193 2017-01-31  Chris Fleizach  <cfleizach@apple.com>
194
195         AX: enable search predication for iOS
196         https://bugs.webkit.org/show_bug.cgi?id=167558
197         <rdar://problem/30251367>
198
199         Reviewed by Joanmarie Diggs.
200
201         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
202         (AccessibilityUIElement::uiElementForSearchPredicate):
203         * DumpRenderTree/mac/AccessibilityCommonMac.h:
204         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
205         (searchPredicateParameterizedAttributeForSearchCriteria):
206         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
207         (searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
208         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
209         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
210         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
211         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
212         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
213         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
214         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
215         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
216         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
217
218 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
219
220         Workaround for simctl launch bug
221         https://bugs.webkit.org/show_bug.cgi?id=167613
222
223         Reviewed by Daniel Bates.
224
225         simctl launch will sometimes fail because of a race condition when many
226         simulators are being run simultaneously. These failures will always have
227         an exit code of 1. This change attempts to launch an app multiple times
228         before reporting a failure to workaround this bug.
229
230         * Scripts/webkitpy/xcode/simulator.py:
231         (Device.launch_app): Execute multiple launch attempts, better logging of failures.
232
233 2017-01-30  Alexey Proskuryakov  <ap@apple.com>
234
235         Commit queue fails to look at real name aliases for the reviewer
236         https://bugs.webkit.org/show_bug.cgi?id=167422
237
238         Reviewed by Joseph Pecoraro.
239
240         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
241         (test_has_valid_reviewer): Added tests.
242
243         * Scripts/webkitpy/common/config/committers.py:
244         (CommitterList._name_to_contributor_map):
245         Made _name_to_contributor_map include alias names.
246
247         * Scripts/webkitpy/common/config/committers_unittest.py:
248         (CommittersTest.test_contributors_by_fuzzy_match):
249         Removed subtests that are now obsolete, as these matches are strict. It is not
250         obvious if distance based fuzzy matching for names is useful at all, but we can
251         look into that some other time.
252
253 2017-01-30  Aakash Jain  <aakash_jain@apple.com>
254
255         QueueStatusServer should have an explicit timeout for _fetch_url
256         https://bugs.webkit.org/show_bug.cgi?id=167467
257
258         Reviewed by Alexey Proskuryakov.
259
260         * Scripts/webkitpy/common/net/statusserver.py:
261         (StatusServer._fetch_url): Add an explicit timeout of 300s.
262
263 2017-01-30  Kocsen Chung  <kocsen_chung@apple.com>
264
265         Add support for Trac instances that host multiple projects.
266         https://bugs.webkit.org/show_bug.cgi?id=167524
267
268         Reviewed by Alexey Proskuryakov.
269
270         When multiple projects are hosted on a single Trac instance, the current
271         behavior will retrieve changesets from all tracked projects.
272         This patch teaches Trac.js to get project-specific changesets from Trac.
273         We do this by replacing the parameter `changeset=on` to `repo-projectname=on`
274         when querying the Trac timeline.
275
276         To tell Trac to be aware of multi-project instances we leverage the 
277         `options` parameter when creating a new instance: 
278
279             new Trac("https://mytrac.com/", { projectIdentifier: "tracProjectName" });
280
281         If this option is not provided, the original behaviour will prevail.
282         Additionally, add corresponding tests.
283
284         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
285         (Trac): Reason about new optional parameter 'projectIdentifier'.
286         (Trac.prototype.revisionURL): Given a projectIdentifier, append it to the end of the URL.
287         (Trac.prototype._xmlTimelineURL): Given a projectIdentifier,
288         replace default parameter `changeset=on` with `repo-projectname=on`.
289         (Trac.prototype._convertCommitInfoElementToObject): Fix missing ';'.
290         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
291         (MockTrac): Add support for instantiating Trac with a projectIdentifier.
292         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
293         (setup): Provide a multiple-project MockTrac instance to all test cases for testing.
294         Add the following tests:
295             test("revisionURL")
296             test("revisionURL with Trac Identifier")
297             test("_xmlTimelineURL")
298             test("_xmlTimelineURL with Trac Identifier")
299         (this.view._latestProductiveIteration): Fix missing ';'.
300
301 2017-01-30  Myles C. Maxfield  <mmaxfield@apple.com>
302
303         Correct spacing regression on inter-element complex path shaping on some fonts
304         https://bugs.webkit.org/show_bug.cgi?id=166013
305
306         Reviewed by Simon Fraser.
307
308         Unskip existing tests and make some new tests:
309         - Testing complex text with no origins
310         - Testing initial expansions
311         - Testing the sign of vertical advances
312
313         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
314         (TestWebKitAPI::TEST_F):
315
316 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
317
318         [GTK][EFL] Avoid using a thin directory to create the built product on the archive-built-product step.
319         https://bugs.webkit.org/show_bug.cgi?id=167596
320
321         Reviewed by Daniel Bates.
322
323         We avoid needing a thin directory by invoking the zip program with
324         the list of directories from the build directory to be zipped,
325         and by using the zip feature to exclude files matching a pattern.
326
327         * BuildSlaveSupport/built-product-archive:
328         (copyBuildFiles):
329         (createZipFromList):
330         (archiveBuiltProduct):
331
332 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
333
334         Use simctl instead of LayoutTestRelay
335         https://bugs.webkit.org/show_bug.cgi?id=165927
336
337         Reviewed by Daniel Bates.
338
339         Part 1
340
341         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
342         simulators through simctl (iOS 10 and later), use this functionality instead.
343
344         * Scripts/webkitpy/port/base.py:
345         (Port.__init__): Added _test_runner_process_constructor.
346         * Scripts/webkitpy/port/darwin.py:
347         (DarwinPort.app_identifier_from_bundle): Added function to extract bundle ID from plist.
348         * Scripts/webkitpy/port/driver.py:
349         (Driver._start): Pass worker_number to server_process so we can look up the correct simulator device to use.
350         (IOSSimulatorDriver): Deleted.
351         * Scripts/webkitpy/port/driver_unittest.py:
352         (DriverTest.test_stop_cleans_up_properly): Set _test_runner_process_constructor for testing.
353         (DriverTest.test_two_starts_cleans_up_properly): Ditto.
354         (DriverTest.test_start_actually_starts): Ditto.
355         * Scripts/webkitpy/port/ios.py:
356         (IOSSimulatorPort): Remove relay_name.
357         (IOSSimulatorPort.__init__): Set _test_runner_process_constructor to SimulatorProcess for IOSSimulatorPort.
358         (IOSSimulatorPort._create_simulators): Formatting change.
359         (IOSSimulatorPort.relay_path): Deleted.
360         (IOSSimulatorPort._check_relay): Deleted.
361         (IOSSimulatorPort._check_port_build): Deleted. Use base class implementation
362         (IOSSimulatorPort._build_relay): Deleted.
363         (IOSSimulatorPort._build_driver): Deleted. Use base class implementation
364         (IOSSimulatorPort._driver_class): Deleted. Use base class implementation
365         * Scripts/webkitpy/port/ios_unittest.py:
366         (iosTest.test_32bit): Update test.
367         (iosTest.test_64bit): Update test.
368         * Scripts/webkitpy/port/server_process.py:
369         (ServerProcess.__init__): Added argument worker_number. This class does not make use of it. We will make use of this argument in SimulatorProcess to lookup the associated simulator device.
370         (ServerProcess._set_file_nonblocking): Added to share common code.
371         * Scripts/webkitpy/port/server_process_mock.py:
372         (MockServerProcess.__init__): Added argument worker_number.
373         * Scripts/webkitpy/port/simulator_process.py: Added.
374         (SimulatorProcess): Added.
375         (SimulatorProcess.Popen): Added.
376         (SimulatorProcess.Popen.__init__): Added. Initialize Popen structure with stdin, stdout, stderr and pid.
377         (SimulatorProcess.Popen.poll): Added. Check if the process is running.
378         (SimulatorProcess.Popen.wait): Added. Wait for process to close.
379         (SimulatorProcess.__init__): Added. Install app to device specified through port and worker_number.
380         (SimulatorProcess._reset): Added. Unlink fifos.
381         (SimulatorProcess._start): Added. Launch app on simulator, link fifos.
382         (SimulatorProcess._kill): Added. Shutdown app on simulator.
383         * Scripts/webkitpy/xcode/simulator.py:
384         (Device.__init__): Accept host to run install/launch/terminate.
385         (Device.install_app): Install app to target Device.
386         (Device.launch_app): Launch app on target Device.
387         (Device.terminate_app): Shutdown app on target Device.
388         (Simulator._parse_devices): Pass host to Device.
389
390 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
391
392         [GTK] pixman fails to compile on Raspberry Pi (GCC crash)
393         https://bugs.webkit.org/show_bug.cgi?id=167411
394
395         Reviewed by Michael Catanzaro.
396
397         Disable the ARM iwMMXt fast path for pixman, because it triggers
398         a GCC bug on the RPi with Raspbian/PIXEL causing a build failure.
399
400         * gtk/jhbuild.modules:
401
402 2017-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
403
404         [GTK] Add API to handle the accelerated compositing policy
405         https://bugs.webkit.org/show_bug.cgi?id=167509
406
407         Reviewed by Michael Catanzaro.
408
409         Handle new setting in MiniBrowser. The settings dialog doesn't support enum settings so it needs to be handled
410         as a special case. Also add test cases to the get/set API.
411
412         * MiniBrowser/gtk/BrowserSettingsDialog.c:
413         (hardwareAccelerationPolicyToString):
414         (stringToHardwareAccelerationPolicy):
415         (cellRendererChanged):
416         (browserSettingsDialogConstructed):
417         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
418         (testWebKitSettings):
419
420 2017-01-29  Andy Estes  <aestes@apple.com>
421
422         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
423         https://bugs.webkit.org/show_bug.cgi?id=167563
424         <rdar://problem/30253207>
425
426         Reviewed by Andreas Kling.
427
428         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
429         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
430         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
431         (runTest):
432         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
433         (TEST):
434
435 2017-01-29  Dan Bernstein  <mitz@apple.com>
436
437         [iOS] Expose WebCore::DataDetection::detectContentInRange WKWebProcessPlugInRangeHandle
438         https://bugs.webkit.org/show_bug.cgi?id=167565
439
440         Reviewed by Sam Weinig.
441
442         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
443         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Added.
444         (-[BundleRangeHandleRemoteObject textFromBodyRange:]):
445         (-[BundleRangeHandleRemoteObject bodyInnerHTMLAfterDetectingData:]):
446         (TEST):
447         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Added.
448         (-[BundleRangeHandlePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
449         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
450         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Added.
451
452 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
453
454         Add Link Preload as an off-by-default experimental feature menu item.
455         https://bugs.webkit.org/show_bug.cgi?id=167201
456
457         Reviewed by Ryosuke Niwa.
458
459         * DumpRenderTree/mac/DumpRenderTree.mm:
460         (resetWebPreferencesToConsistentValues):
461         * DumpRenderTree/win/DumpRenderTree.cpp:
462         (resetWebPreferencesToConsistentValues):
463
464 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
465
466         Add User Timing Experimental Feature
467         https://bugs.webkit.org/show_bug.cgi?id=167542
468         <rdar://problem/22746307>
469
470         Reviewed by Ryosuke Niwa.
471
472         * DumpRenderTree/mac/DumpRenderTree.mm:
473         (enableExperimentalFeatures):
474         (resetWebPreferencesToConsistentValues):
475         * DumpRenderTree/win/DumpRenderTree.cpp:
476         (enableExperimentalFeatures):
477
478 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
479
480         Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
481         https://bugs.webkit.org/show_bug.cgi?id=167519
482
483         Reviewed by Ryosuke Niwa.
484
485         * QueueStatusServer/templates/statusbubble.html:
486         To measure the bubbleContainer's width, it must not be wrapping based
487         on its parent container. So when measuring the width temporarily set
488         the parent to a very large width so as to not artificially wrap us.
489         Restore the parent's width after measuring.
490
491 2017-01-27  Andy Estes  <aestes@apple.com>
492
493         [iOS] Add a test for _WKNSFileManagerExtras
494         https://bugs.webkit.org/show_bug.cgi?id=167478
495
496         Reviewed by Andreas Kling.
497
498         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
499         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Added.
500         (expectAttributes):
501         (TEST):
502
503 2017-01-27  Keith Miller  <keith_miller@apple.com>
504
505         run-benchmarks should make sure it passes the test url to the right application
506         https://bugs.webkit.org/show_bug.cgi?id=167533
507
508         Reviewed by Joseph Pecoraro.
509
510         This fixes an issue when trying to run-benchmark script with the
511         system default browser set to STP. Previously, it would run
512         the test in STP rather than the provided build. Now, it should run
513         in the provided build.
514
515         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
516         (OSXSafariDriver.launch_url):
517
518 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
519
520         [Cocoa] Prepare ComplexTextController for unit testing
521         https://bugs.webkit.org/show_bug.cgi?id=167493
522
523         Reviewed by Simon Fraser.
524
525         Addressing post-review comments from Simon Fraser.
526
527         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
528         (TestWebKitAPI::TEST_F):
529
530 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
531
532         [Cocoa] Prepare ComplexTextController for unit testing
533         https://bugs.webkit.org/show_bug.cgi?id=167493
534
535         Reviewed by Dean Jackson.
536
537         Create four unit tests.
538
539         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
540         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Added.
541         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
542         (TestWebKitAPI::TEST_F):
543
544 2017-01-26  Chris Dumez  <cdumez@apple.com>
545
546         Crash when navigating back to a page in PacheCache when one of its frames has been removed
547         https://bugs.webkit.org/show_bug.cgi?id=167421
548         <rdar://problem/30188490>
549
550         Reviewed by Darin Adler.
551
552         Add a new setting allowing layout tests to enable PageCache in a window
553         that has an opener, for convenience.
554
555         * DumpRenderTree/mac/DumpRenderTree.mm:
556         (resetWebPreferencesToConsistentValues):
557         * DumpRenderTree/win/DumpRenderTree.cpp:
558         (resetWebPreferencesToConsistentValues):
559         * WebKitTestRunner/TestController.cpp:
560         (WTR::TestController::resetPreferencesToConsistentValues):
561
562 2017-01-26  Keith Miller  <keith_miller@apple.com>
563
564         classInfo should take a VM so it is not materialized from the object on each call
565         https://bugs.webkit.org/show_bug.cgi?id=167424
566
567         Rubber Stamped by Michael Saboff.
568
569         Previously, classInfo() would get the VM from the target's
570         MarkedBlock.  Most callers already have a VM on hand, so it is
571         wasteful to compute the VM from the marked block every time. This
572         patch refactors some of the most common callers of classInfo(),
573         jsDynamicCast and inherits to take a VM as well.
574
575         * DumpRenderTree/TestRunner.cpp:
576         (setAudioResultCallback):
577
578 2017-01-26  Jer Noble  <jer.noble@apple.com>
579
580         Autoplay muted videos stop playback of any streaming app in the background
581         https://bugs.webkit.org/show_bug.cgi?id=163993
582         <rdar://problem/29020431>
583
584         Reviewed by Eric Carlson.
585
586         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
587         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
588         (TestWebKitAPI::TEST):
589         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Added.
590
591 2017-01-26  Ryan Haddad  <ryanhaddad@apple.com>
592
593         Disable API test WebKit2.WebsitePoliciesPlayAfterPreventedAutoplay.
594         https://bugs.webkit.org/show_bug.cgi?id=167466
595
596         Unreviewed test gardening.
597
598         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
599         (TEST):
600
601 2017-01-26  Matt Rajca  <mrajca@apple.com>
602
603         Notify clients when the user plays media otherwise prevented from autoplaying
604         https://bugs.webkit.org/show_bug.cgi?id=167390
605
606         Reviewed by Alex Christensen.
607
608         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
609         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
610         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
611         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
612         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
613         (TEST):
614         * TestWebKitAPI/cocoa/TestWKWebView.h:
615         * TestWebKitAPI/cocoa/TestWKWebView.mm:
616         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
617         (-[TestWKWebView waitForLoad]):
618         (-[TestWKWebView mouseUpAtPoint:]):
619         * WebKitTestRunner/TestController.cpp:
620         (WTR::TestController::createOtherPage):
621         (WTR::TestController::createWebViewWithOptions):
622
623 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
624
625         Crash when setting custom scale factor.
626         https://bugs.webkit.org/show_bug.cgi?id=167369
627
628         Reviewed by Sam Weinig.
629
630         Added API test.
631
632         * TestWebKitAPI/PlatformWin.cmake:
633         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Added.
634         (TestWebKitAPI::WebKitCreateInstance):
635         (TestWebKitAPI::ScaleWebView::SetUp):
636         (TestWebKitAPI::ScaleWebView::TearDown):
637         (TestWebKitAPI::TEST_F):
638
639 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
640
641         run-benchmark nests MotionMark results by the suite name twice
642         https://bugs.webkit.org/show_bug.cgi?id=164948
643
644         Reviewed by Said Abou-Hallawa.
645
646         Use a single level MotionMark now that this is the name of the benchmark,
647         and we no longer have tests that aren't part of the MotionMark suite.
648
649         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch:
650
651 2017-01-25  Ryan Haddad  <ryanhaddad@apple.com>
652
653         Unreviewed, rolling out r211193.
654
655         This change broke internal builds.
656
657         Reverted changeset:
658
659         "Notify clients when the user plays media otherwise prevented
660         from autoplaying"
661         https://bugs.webkit.org/show_bug.cgi?id=167390
662         http://trac.webkit.org/changeset/211193
663
664 2017-01-25  Matt Rajca  <mrajca@apple.com>
665
666         Notify clients when the user plays media otherwise prevented from autoplaying
667         https://bugs.webkit.org/show_bug.cgi?id=167390
668
669         Reviewed by Alex Christensen.
670
671         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
672         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
673         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
674         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
675         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
676         (TEST):
677         * TestWebKitAPI/cocoa/TestWKWebView.h:
678         * TestWebKitAPI/cocoa/TestWKWebView.mm:
679         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
680         (-[TestWKWebView waitForLoad]):
681         (-[TestWKWebView mouseUpAtPoint:]):
682         * WebKitTestRunner/TestController.cpp:
683         (WTR::TestController::createOtherPage):
684         (WTR::TestController::createWebViewWithOptions):
685
686 2017-01-25  Matt Rajca  <mrajca@apple.com>
687
688         [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out
689         https://bugs.webkit.org/show_bug.cgi?id=167385
690
691         Reviewed by Alex Christensen.
692
693         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Avoid arbitrary timeouts in favor of promises.
694         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html:
695         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
696         (TEST): Allow inline (rather than full screen) media playback on iOS.
697
698 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
699
700         [GTK] Icon Database should be in private browsing mode for ephemeral web views
701         https://bugs.webkit.org/show_bug.cgi?id=167414
702
703         Reviewed by Michael Catanzaro.
704
705         Add a test case to check ephemeral web views don't write favicons to the database.
706
707         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
708         (ephemeralViewLoadChanged):
709         (testPrivateBrowsing):
710         (testFaviconDatabase):
711
712 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
713
714         [GTK] Add a private browsing mode to MiniBrowser
715         https://bugs.webkit.org/show_bug.cgi?id=167413
716
717         Reviewed by Michael Catanzaro.
718
719         Add -p/--private command line option to create a private instance. Also add CTRL+SHIFT+P shortcut to create
720         private windows, even on non-private instances.
721
722         * MiniBrowser/gtk/BrowserWindow.c:
723         (webViewTitleChanged): Add [Private] to title window for private windows.
724         (webViewCreate): Pass web context to browser_window_new.
725         (openPrivateWindow): Create a new ephemeral web view and add it to a new window.
726         (browserWindowFinalize): Disconnect web context signal handlers.
727         (browser_window_init): Add shortcut for opening private window.
728         (browser_window_new): It now receives the context and connect to download-started here.
729         (browser_window_get_web_context): Return the context.
730         * MiniBrowser/gtk/BrowserWindow.h:
731         * MiniBrowser/gtk/main.c:
732         (createBrowserTab): Create the web view for the window web context.
733         (aboutDataScriptMessageReceivedCallback): Do not use the default web context, but the window one.
734         (aboutDataHandleRequest): Ditto.
735         (aboutURISchemeRequestCallback): Ditto.
736         (main): Create ephemeral web context if private command line option is used.
737
738 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
739
740         collectMatchingElementsInFlatTree should not find elements inside an user agent shadow tree
741         https://bugs.webkit.org/show_bug.cgi?id=167409
742
743         Reviewed by Antti Koivisto.
744
745         Added a test case for collectMatchingElementsInFlatTree not finding elements inside an user agent shadow tree
746         as well as tests for the newly added matchingElementInFlatTree.
747
748         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
749         (TestWebKitAPI::runJavaScriptAlert):
750         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
751         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
752         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html:
753
754 2017-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
755
756         [GTK] Add API to create ephemeral web views and deprecate the private browsing setting
757         https://bugs.webkit.org/show_bug.cgi?id=167370
758
759         Reviewed by Michael Catanzaro.
760
761         Add several test cases of ephemeral web views.
762
763         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
764         (testWebViewAuthenticationStorage):
765         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
766         (ephemeralViewloadChanged):
767         (testCookieManagerEphemeral):
768         (beforeAll):
769         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
770         (testWebKitSettings):
771         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
772         (testWebContextEphemeral):
773         (ephemeralViewloadChanged):
774         (testWebContextProxySettings):
775         (beforeAll):
776         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
777         (ephemeralViewloadChanged):
778         (testWebViewEphemeral):
779         (beforeAll):
780         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
781         (ephemeralViewloadChanged):
782         (testWebsiteDataEphemeral):
783         (beforeAll):
784
785 2017-01-24  Alex Christensen  <achristensen@webkit.org>
786
787         REGRESSION (r208902): URLWithUserTypedString returns nil with file URLs
788         https://bugs.webkit.org/show_bug.cgi?id=167402
789
790         Reviewed by Ryosuke Niwa.
791
792         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
793         (TestWebKitAPI::TEST):
794
795 2017-01-24  Zalan Bujtas  <zalan@apple.com>
796
797         Add simple line layout toggle to MiniBrowser
798         https://bugs.webkit.org/show_bug.cgi?id=167405
799
800         Reviewed by Andreas Kling.
801
802         * MiniBrowser/mac/SettingsController.h:
803         * MiniBrowser/mac/SettingsController.m:
804         (-[SettingsController _populateMenu]):
805         (-[SettingsController validateMenuItem:]):
806         (-[SettingsController toggleSimpleLineLayoutEnabled:]):
807         (-[SettingsController simpleLineLayoutEnabled]):
808         * MiniBrowser/mac/WK1BrowserWindowController.m:
809         (-[WK1BrowserWindowController didChangeSettings]):
810         * MiniBrowser/mac/WK2BrowserWindowController.m:
811         (-[WK2BrowserWindowController didChangeSettings]):
812
813 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
814
815         WKR does not include my nick when commit-queue lands my patch
816         https://bugs.webkit.org/show_bug.cgi?id=167388
817
818         Reviewed by Ryosuke Niwa.
819
820         * Scripts/webkitpy/tool/commands/newcommitbot.py:
821         (NewCommitBot._summarize_commit_log):
822         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
823         Perform nickname insertion before grabbing "Patch by" details.
824         This way we can include the nickname with the full name.
825
826 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
827
828         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
829         https://bugs.webkit.org/show_bug.cgi?id=167394
830
831         Reviewed by Ryosuke Niwa.
832
833         * Scripts/webkitperl/FeatureList.pm:
834         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
835
836 2017-01-24  Youenn Fablet  <youenn@apple.com>
837
838         [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
839         https://bugs.webkit.org/show_bug.cgi?id=167353
840
841         Reviewed by Alex Christensen.
842
843         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
844         (CMakeGenerator.initialize_targets):
845
846 2017-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
847
848         WKR should not confuse Miguel Gomez with Andres Gomez
849         https://bugs.webkit.org/show_bug.cgi?id=167389
850
851         Reviewed by Lucas Forschler.
852
853         Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
854         "mAndres Gomez". Fix this.
855
856         * Scripts/webkitpy/tool/commands/newcommitbot.py:
857         (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
858         space on each side of the email address, so expect both spaces to be there before
859         considering the email for replacement.
860         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
861
862 2017-01-24  Matt Rajca  <mrajca@apple.com>
863
864         Pass down website autoplay policies to media elements
865         https://bugs.webkit.org/show_bug.cgi?id=167355
866
867         Reviewed by Alex Christensen.
868
869         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
870         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html to match our naming conventions.
871         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Added.
872         * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Added.
873         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
874         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
875         (TEST):
876
877 2017-01-24  Nan Wang  <n_wang@apple.com>
878
879         AX: Speak Selection does not work in an iframe
880         https://bugs.webkit.org/show_bug.cgi?id=166794
881         <rdar://problem/29913013>
882
883         Reviewed by Chris Fleizach.
884
885         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
886         (WTR::UIScriptController::retrieveSpeakSelectionContent):
887         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
888         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
889         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
890         (WTR::UIScriptController::retrieveSpeakSelectionContent):
891         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
892         * TestRunnerShared/UIScriptContext/UIScriptController.h:
893         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
894         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
895         (-[TestRunnerWKWebView dealloc]):
896         (-[TestRunnerWKWebView _accessibilityDidGetSpeakSelectionContent:]):
897         (-[TestRunnerWKWebView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:]):
898         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
899         (WTR::UIScriptController::retrieveSpeakSelectionContent):
900         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
901
902 2017-01-24  Daniel Bates  <dabates@apple.com>
903
904         StringView.split() should use an iterator design pattern instead of allocating a Vector
905         https://bugs.webkit.org/show_bug.cgi?id=163225
906
907         Reviewed by Darin Adler.
908
909         Add unit tests for StringView.split().
910
911         * TestWebKitAPI/Tests/WTF/StringView.cpp:
912         (TestWebKitAPI::stringViewFromLiteral): Moved to the top of the file so that it can be
913         used in the StringView.split() unit tests.
914         (TestWebKitAPI::stringViewFromUTF8): Ditto.
915         (TestWebKitAPI::vectorFromSplitResult): Convenience function to convert a StringView::SplitResult
916         object to a Vector of String objects.
917         (TestWebKitAPI::TEST): Added the following tests:
918             - WTF.StringViewSplitEmptyAndNullStrings
919             - WTF.StringViewSplitBasic
920             - WTF.StringViewSplitWithConsecutiveSeparators
921
922 2017-01-23  Anders Carlsson  <andersca@apple.com>
923
924         The Score Esports crashes on launch
925         https://bugs.webkit.org/show_bug.cgi?id=167338
926         rdar://problem/29948645
927
928         Reviewed by Dan Bernstein.
929
930         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
931         (TestWebKitAPI::TEST):
932         Add a test.
933
934 2017-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
935
936         [GTK] Add API to WebKitWebsiteDataManager to handle website data
937         https://bugs.webkit.org/show_bug.cgi?id=146589
938
939         Reviewed by Michael Catanzaro.
940
941         Add about:data handler to MiniBrowser to manually test the website data API. Also add unit tests to test all the
942         new API, moving the WebKitWebsiteDataManager configuration API to the new file too.
943
944         * MiniBrowser/gtk/BrowserWindow.c:
945         (webViewDecidePolicy):
946         (newTabCallback):
947         * MiniBrowser/gtk/main.c:
948         (createBrowserTab):
949         (aboutDataRequestFree):
950         (aboutDataRequestNew):
951         (aboutDataRequestForView):
952         (websiteDataRemovedCallback):
953         (websiteDataClearedCallback):
954         (aboutDataScriptMessageReceivedCallback):
955         (domainListFree):
956         (aboutDataFillTable):
957         (gotWebsiteDataCallback):
958         (aboutDataHandleRequest):
959         (aboutURISchemeRequestCallback):
960         (main):
961         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
962         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
963         (serverCallback):
964         (beforeAll):
965         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: Added.
966         (serverCallback):
967         (WebsiteDataTest::WebsiteDataTest):
968         (WebsiteDataTest::~WebsiteDataTest):
969         (WebsiteDataTest::fetch):
970         (WebsiteDataTest::remove):
971         (WebsiteDataTest::clear):
972         (testWebsiteDataConfiguration):
973         (testWebsiteDataCache):
974         (testWebsiteDataStorage):
975         (testWebsiteDataDatabases):
976         (testWebsiteDataAppcache):
977         (beforeAll):
978         (afterAll):
979
980 2017-01-23  Commit Queue  <commit-queue@webkit.org>
981
982         Unreviewed, rolling out r211062.
983         https://bugs.webkit.org/show_bug.cgi?id=167354
984
985         broke API tests (Requested by alexchristensen on #webkit).
986
987         Reverted changeset:
988
989         "Pass down website autoplay policies to media elements"
990         https://bugs.webkit.org/show_bug.cgi?id=167132
991         http://trac.webkit.org/changeset/211062
992
993 2017-01-23  Alex Christensen  <achristensen@webkit.org>
994
995         URLParser should fail to parse percent-encoded invalid UTF-8 sequences
996         https://bugs.webkit.org/show_bug.cgi?id=167330
997
998         Reviewed by Tim Horton.
999
1000         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1001         (TestWebKitAPI::TEST_F):
1002
1003 2017-01-23  Alex Christensen  <achristensen@webkit.org>
1004
1005         Make URLs with non-special schemes and a query or fragment but no slash after the host more compatible
1006         https://bugs.webkit.org/show_bug.cgi?id=167317
1007
1008         Reviewed by Sam Weinig.
1009
1010         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1011         (TestWebKitAPI::TEST_F):
1012
1013 2017-01-23  Jonathan Bedard  <jbedard@apple.com>
1014
1015         svn-create-patch should emit properties when files are moved or copied
1016         https://bugs.webkit.org/show_bug.cgi?id=167264
1017
1018         Reviewed by Daniel Bates.
1019
1020         * Scripts/svn-create-patch:
1021         (manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties.
1022
1023 2017-01-23  Youenn Fablet  <youenn@apple.com>
1024
1025         [WebRTC] Filter libwebrtc link flags
1026         https://bugs.webkit.org/show_bug.cgi?id=167287
1027
1028         Reviewed by Alex Christensen.
1029
1030         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1031         (CMakeGenerator._compute_link_flags):
1032         (CMakeGenerator._compute_link_flags.keep_flag):
1033         (CMakeGenerator._generate_compile_target_options):
1034
1035 2017-01-23  Youenn Fablet  <youennf@gmail.com>
1036
1037         [WebRTC] Make VP8 optional in libwebrtc
1038         https://bugs.webkit.org/show_bug.cgi?id=167257
1039
1040         Reviewed by Darin Adler.
1041
1042         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1043         (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.
1044
1045 2017-01-23  Jer Noble  <jer.noble@apple.com>
1046
1047         Video details does not apear and missing scrubber in Control Center
1048         https://bugs.webkit.org/show_bug.cgi?id=167233
1049
1050         Reviewed by Alex Christensen.
1051
1052         Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to
1053         NowPlayingControlTests for iOS.
1054
1055         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1056         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
1057         (-[NowPlayingTestWebView setWindowVisible:]):
1058         (TestWebKitAPI::TEST):
1059         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
1060         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1061         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
1062         * TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h.
1063         * TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm.
1064         (SOFT_LINK_CLASS):
1065         (-[TestMessageHandler addMessage:withHandler:]):
1066         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
1067         (__simulated_forceClickAssociatedEventsMask):
1068         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
1069         (-[TestWKWebViewHostWindow isKeyWindow]):
1070         (-[TestWKWebViewHostWindow makeKeyWindow]):
1071         (-[TestWKWebViewHostWindow resignKeyWindow]):
1072         (-[TestWKWebView initWithFrame:]):
1073         (-[TestWKWebView initWithFrame:configuration:]):
1074         (-[TestWKWebView _setUpTestWindow:]):
1075         (-[TestWKWebView performAfterReceivingMessage:action:]):
1076         (-[TestWKWebView loadTestPageNamed:]):
1077         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
1078         (-[TestWKWebView stringByEvaluatingJavaScript:]):
1079         (-[TestWKWebView waitForMessage:]):
1080         (-[TestWKWebView performAfterLoading:]):
1081         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
1082         (-[TestWKWebView typeCharacter:]):
1083
1084 2017-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1085
1086         Unreviewed. Bring back gtk-doc error messages after r209981.
1087
1088         Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
1089         impossible to know what's wrong.
1090
1091         * gtk/gtkdoc.py:
1092         (GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.
1093
1094 2017-01-20  Youenn Fablet  <youennf@gmail.com>
1095
1096         [WebRTC] Update build system to make G711 optional in libwebrtc
1097         https://bugs.webkit.org/show_bug.cgi?id=167256
1098
1099         Reviewed by Alex Christensen.
1100
1101         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1102         (CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.
1103
1104 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1105
1106         Cleanup RuntimeEnabledFeatures
1107         https://bugs.webkit.org/show_bug.cgi?id=167228
1108
1109         Reviewed by Simon Fraser.
1110
1111         * DumpRenderTree/mac/DumpRenderTree.mm:
1112         (enableExperimentalFeatures):
1113         (resetWebPreferencesToConsistentValues):
1114         (setWebPreferencesForTestOptions):
1115         (resetWebViewToConsistentStateBeforeTesting):
1116         * DumpRenderTree/win/DumpRenderTree.cpp:
1117         (enableExperimentalFeatures):
1118         (resetWebPreferencesToConsistentValues):
1119         More closely match WebKitTestRunner initialization of preferences
1120         for experimental features.
1121
1122 2017-01-20  Alex Christensen  <achristensen@webkit.org>
1123
1124         Build Fix for Windows DumpRenderTree after r210976
1125         https://bugs.webkit.org/show_bug.cgi?id=167115
1126
1127         * DumpRenderTree/win/DumpRenderTree.cpp:
1128         (resetWebPreferencesToConsistentValues):
1129
1130 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1131
1132         Remove outdated ENABLE(CSP_NEXT) build flag
1133         https://bugs.webkit.org/show_bug.cgi?id=167252
1134
1135         Reviewed by Brent Fulgham.
1136
1137         * Scripts/webkitperl/FeatureList.pm:
1138         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1139
1140 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1141
1142         Build Fix for Windows DumpRenderTree after r210976
1143
1144         * DumpRenderTree/win/DumpRenderTree.cpp:
1145         (resetWebPreferencesToConsistentValues):
1146
1147 2017-01-20  Antoine Quint  <graouts@apple.com>
1148
1149         Web Animations should be off by default and enabled as an experimental feature
1150         https://bugs.webkit.org/show_bug.cgi?id=167115
1151         <rdar://problem/30048963>
1152
1153         Reviewed by Joseph Pecoraro.
1154
1155         Turn Web Animations on in DRT.
1156
1157         * DumpRenderTree/mac/DumpRenderTree.mm:
1158         (resetWebPreferencesToConsistentValues):
1159         * DumpRenderTree/win/DumpRenderTree.cpp:
1160         (resetWebPreferencesToConsistentValues):
1161
1162 2017-01-20  Youenn Fablet  <youenn@apple.com>
1163
1164         [WebRTC] Add libwebrtc build infrastructure
1165         https://bugs.webkit.org/show_bug.cgi?id=167207
1166
1167         Reviewed by Alex Christensen.
1168
1169         Adding a script doing the libwebrtc project json to CMake file conversion.
1170
1171         * Scripts/generate-libwebrtc-cmake: Added.
1172         * Scripts/webkitpy/libwebrtc/__init__.py: Added.
1173         * Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.
1174
1175 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1176
1177         Mini Browser: Show tooltip for Experimental Features
1178         https://bugs.webkit.org/show_bug.cgi?id=167225
1179
1180         Reviewed by Alex Christensen.
1181
1182         * MiniBrowser/mac/SettingsController.m:
1183         (-[SettingsController _populateMenu]):
1184         Include the full details string as a tooltip.
1185
1186 2017-01-20  Per Arne Vollan  <pvollan@apple.com>
1187
1188         [Win] Test output results should not be written twice.
1189         https://bugs.webkit.org/show_bug.cgi?id=167197
1190
1191         Reviewed by Brent Fulgham.
1192
1193         Prevent test output from being written twice by returning early from
1194         the dump() function, if it already has been called.
1195         This patch also adds a missing newline to a test output line. 
1196         
1197         * DumpRenderTree/win/DumpRenderTree.cpp:
1198         (dump):
1199
1200 2017-01-20  Antoine Quint  <graouts@apple.com>
1201
1202         [Modern Media Controls] Turn modern media controls on by default
1203         https://bugs.webkit.org/show_bug.cgi?id=165668
1204
1205         Reviewed by Dean Jackson.
1206
1207         Enabled modern media controls by default in test runners.
1208
1209         * DumpRenderTree/TestOptions.h:
1210         * WebKitTestRunner/TestOptions.h:
1211
1212 2017-01-19  Chris Dumez  <cdumez@apple.com>
1213
1214         iterable<> should be enabled on WK1
1215         https://bugs.webkit.org/show_bug.cgi?id=167221
1216         <rdar://problem/30108531>
1217
1218         Reviewed by Youenn Fablet.
1219
1220         * DumpRenderTree/mac/DumpRenderTree.mm:
1221         (resetWebPreferencesToConsistentValues):
1222         * DumpRenderTree/win/DumpRenderTree.cpp:
1223         (resetWebPreferencesToConsistentValues):
1224         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1225         (WTR::InjectedBundle::beginTesting):
1226         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1227         (WTR::TestRunner::setDOMIteratorEnabled): Deleted.
1228         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1229
1230 2017-01-19  Aakash Jain  <aakash_jain@apple.com>
1231
1232         Ensure status server logs go to log file
1233         https://bugs.webkit.org/show_bug.cgi?id=167210
1234
1235         Reviewed by Alexey Proskuryakov.
1236
1237         * Scripts/webkitpy/common/net/statusserver.py:
1238         (StatusServer.next_work_item): Change log level from debug to info in
1239         order to facilitate deubgging issues.
1240         (StatusServer.update_work_items): Same.
1241
1242 2017-01-19  Megan Gardner  <megan_gardner@apple.com>
1243
1244         Additional selection tests and interpolation fix
1245         https://bugs.webkit.org/show_bug.cgi?id=167171
1246
1247         Reviewed by Simon Fraser.
1248
1249         We weren't adding the final event when interpolating event streams.
1250
1251         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1252         (-[HIDEventGenerator interpolatedEvents:]):
1253
1254 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
1255
1256         [Cocoa] Variation fonts are erroneously disabled on iOS
1257         https://bugs.webkit.org/show_bug.cgi?id=167172
1258
1259         Reviewed by Simon Fraser.
1260
1261         OpenSource builders don't seem to understand sdk=embedded*.
1262
1263         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1264
1265 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1266
1267         Unreviewed. Fix GTK+ unit tests failing since r210531.
1268
1269         Avoid using paths to files that don't actually exist.
1270
1271         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
1272         (testWebKitConsoleMessageNetworkError):
1273         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1274         (testContextMenuDefaultMenu):
1275         * TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
1276         * TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
1277         * TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
1278
1279 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1280
1281         [GTK] Provide API to set proxy settings
1282         https://bugs.webkit.org/show_bug.cgi?id=128674
1283
1284         Reviewed by Michael Catanzaro.
1285
1286         Add tests for new proxy settings API.
1287
1288         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1289         (serverCallback):
1290         (ProxyTest::ProxyTest):
1291         (ProxyTest::~ProxyTest):
1292         (ProxyTest::loadURIAndGetMainResourceData):
1293         (ProxyTest::proxyServerPortAsString):
1294         (testWebContextProxySettings):
1295         (beforeAll):
1296
1297 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
1298
1299         Add back my old email address so old commits will still match it.
1300
1301         * Scripts/webkitpy/common/config/contributors.json:
1302
1303 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
1304
1305         Remove my old email address from contributors.json and watchlist.
1306
1307         * Scripts/validate-committer-lists:
1308         (CommitterListFromGit): Change the mapping to the correct email.
1309         * Scripts/webkitpy/common/config/contributors.json:
1310         * Scripts/webkitpy/common/config/watchlist:
1311
1312 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1313
1314         Unreviewed, rolling out r210848.
1315
1316         This change introduced media-related LayoutTest failures and
1317         crashes on macOS.
1318
1319         Reverted changeset:
1320
1321         "[Modern Media Controls] Turn modern media controls on by
1322         default"
1323         https://bugs.webkit.org/show_bug.cgi?id=165668
1324         http://trac.webkit.org/changeset/210848
1325
1326 2017-01-18  Andreas Kling  <akling@apple.com>
1327
1328         Document::securityOrigin() should return a reference.
1329         <https://webkit.org/b/167124>
1330
1331         Reviewed by Sam Weinig.
1332
1333         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1334         (TestWebKitAPI::TEST_F):
1335
1336 2017-01-18  Per Arne Vollan  <pvollan@apple.com>
1337
1338         [Win] Clipboard tests are flaky.
1339         https://bugs.webkit.org/show_bug.cgi?id=167088
1340
1341         Reviewed by Brent Fulgham.
1342
1343         Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. 
1344         We can fix this by assigning each DRT a separate window station (each window station has its own clipboard).
1345
1346         * DumpRenderTree/win/DumpRenderTree.cpp:
1347         (main):
1348
1349 2017-01-18  Antoine Quint  <graouts@apple.com>
1350
1351         [Modern Media Controls] Turn modern media controls on by default
1352         https://bugs.webkit.org/show_bug.cgi?id=165668
1353
1354         Reviewed by Dean Jackson.
1355
1356         Enabled modern media controls by default in test runners. 
1357
1358         * DumpRenderTree/TestOptions.h:
1359         * WebKitTestRunner/TestOptions.h:
1360
1361 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
1362
1363         Unreviewed, rolling out r210834
1364         https://bugs.webkit.org/show_bug.cgi?id=165668
1365
1366         It introduced dozens of test timeouts.
1367
1368         Reverted changeset:
1369         "[Modern Media Controls] Turn modern media controls on by default"
1370         https://bugs.webkit.org/show_bug.cgi?id=165668
1371         http://trac.webkit.org/changeset/210834
1372
1373 2017-01-17  Antoine Quint  <graouts@apple.com>
1374
1375         [Modern Media Controls] Turn modern media controls on by default
1376         https://bugs.webkit.org/show_bug.cgi?id=165668
1377
1378         Reviewed by Dean Jackson.
1379
1380         Enabled modern media controls by default in test runners. 
1381
1382         * DumpRenderTree/TestOptions.h:
1383         * WebKitTestRunner/TestOptions.h:
1384
1385 2017-01-17  Chris Dumez  <cdumez@apple.com>
1386
1387         Document title changed twice when setting document.title
1388         https://bugs.webkit.org/show_bug.cgi?id=167065
1389
1390         Reviewed by Darin Adler.
1391
1392         Add WebKit2GTK API test that was written by Michael Catanzaro.
1393
1394         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1395         (testWebViewTitleChange):
1396         (beforeAll):
1397
1398 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
1399
1400         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
1401         https://bugs.webkit.org/show_bug.cgi?id=116551
1402         <rdar://problem/13949830>
1403
1404         Reviewed by Alex Christensen.
1405
1406         * Scripts/webkitperl/FeatureList.pm:
1407         Remove stale RESOURCE_TIMING references which are now a runtime enabled feature
1408         that is part of the existing WEB_TIMING feature.
1409
1410         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1411
1412 2017-01-17  Jonathan Bedard  <jbedard@apple.com>
1413
1414         'webkit-patch post' no longer works with moved/copied files
1415         https://bugs.webkit.org/show_bug.cgi?id=166914
1416         <rdar://problem/29979707>
1417
1418         Reviewed by Daniel Bates.
1419
1420         SVN 1.9 has a bug where when a file has been moved or copied, the svn diff of the new
1421         file outputs only the "Index:" line with an empty body.  This workaround
1422         ignores such output from svn diff.  A issue has been filed with SVN, a link to the
1423         public email list tracking this bug is below.
1424         http://mail-archives.apache.org/mod_mbox/subversion-users/201701.mbox/%3cCF9BDE0A-7454-4405-8259-1120C6B76A03@apple.com%3e
1425         
1426
1427         * Scripts/svn-create-patch:
1428         (generateDiff): Ignore an "Index:" line with an empty body.
1429
1430 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
1431
1432         Remove the REQUEST_ANIMATION_FRAME flag
1433         https://bugs.webkit.org/show_bug.cgi?id=156980
1434         <rdar://problem/25906849>
1435
1436         Reviewed by Simon Fraser.
1437
1438         * Scripts/webkitperl/FeatureList.pm:
1439         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1440
1441 2017-01-15  Sam Weinig  <sam@webkit.org>
1442
1443         Add the ability to use numbers in makeString()
1444         https://bugs.webkit.org/show_bug.cgi?id=167087
1445
1446         Reviewed by Darin Adler.
1447
1448         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1449         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Added.
1450         Add tests for StringConcatenate, focusing on new numeric additions.
1451
1452 2017-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
1453
1454         Unreviewed, remove stale comment.
1455
1456         This test was fixed by r163173.
1457
1458         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1459
1460 2017-01-14  Yusuke Suzuki  <utatane.tea@gmail.com>
1461
1462         Annotate large string tests with largeHeap
1463         https://bugs.webkit.org/show_bug.cgi?id=167054
1464
1465         Reviewed by Filip Pizlo.
1466
1467         * Scripts/run-javascriptcore-tests:
1468         * Scripts/run-jsc-stress-tests:
1469
1470 2017-01-14  Joseph Pecoraro  <pecoraro@apple.com>
1471
1472         Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES
1473         https://bugs.webkit.org/show_bug.cgi?id=167043
1474
1475         Reviewed by Darin Adler.
1476
1477         * Scripts/webkitperl/FeatureList.pm:
1478
1479 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
1480
1481         Remove ENABLE(DETAILS_ELEMENT) guards
1482         https://bugs.webkit.org/show_bug.cgi?id=167042
1483
1484         Reviewed by Alex Christensen.
1485
1486         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1487
1488 2017-01-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
1489
1490         26 MotionMark performance tests failing
1491         https://bugs.webkit.org/show_bug.cgi?id=166854
1492
1493         Reviewed by Ryosuke Niwa.
1494
1495         Unrelated change. This is the last place that we need to rename Animometer
1496         to MotionMark.
1497
1498         * Scripts/webkitpy/common/config/watchlist:
1499
1500 2017-01-13  Yusuke Suzuki  <utatane.tea@gmail.com>
1501
1502         run-jsc-benchmarks' echo should have -e option
1503         https://bugs.webkit.org/show_bug.cgi?id=167009
1504
1505         Reviewed by Sam Weinig.
1506
1507         echo requires `-e` option to use escape sequence.
1508         Without it, in some environment (in my Fedora 25), the escape sequence is not
1509         recognized and just dumped as `\c` etc.
1510
1511         * Scripts/run-jsc-benchmarks:
1512
1513 2017-01-12  Chris Dumez  <cdumez@apple.com>
1514
1515         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
1516         https://bugs.webkit.org/show_bug.cgi?id=166995
1517
1518         Reviewed by Jer Noble.
1519
1520         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
1521         as some people are having trouble building without it.
1522
1523         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1524
1525 2017-01-12  Sam Weinig  <sam@webkit.org>
1526
1527         Add the ability to filter the set of bindings tests you want to run
1528         https://bugs.webkit.org/show_bug.cgi?id=166977
1529
1530         Reviewed by Tim Horton.
1531
1532         Allows doing things like:
1533             run-bindings-tests TestObj* TestCEReactions*
1534         
1535         to run only those tests that match the patterns.
1536
1537         * Scripts/run-bindings-tests:
1538         (main):
1539         Switch to using optparse and pass the remaining args as the filters.
1540
1541         * Scripts/webkitpy/bindings/main.py:
1542         (BindingsTests.__init__):
1543         Store the pattens.
1544
1545         (BindingsTests.test_matches_patterns):
1546         Add helper predicate to determine if a test should be run. When no
1547         patterns are present, all tests should run.
1548
1549         (BindingsTests.run_tests):
1550         Filter tests using the passed in patterns.
1551
1552 2017-01-12  Per Arne Vollan  <pvollan@apple.com>
1553
1554         Followup fix after r210503.
1555         https://bugs.webkit.org/show_bug.cgi?id=166887
1556
1557         Reviewed by Alex Christensen.
1558
1559         After <http://trac.webkit.org/changeset/210503>, test results are written to a
1560         duplicated file handle on Windows. This patch fixes the remaining call sites.
1561
1562         * DumpRenderTree/PixelDumpSupport.cpp:
1563         * DumpRenderTree/TestRunner.cpp:
1564         (TestRunner::waitToDumpWatchdogTimerFired):
1565         * DumpRenderTree/TestRunner.h:
1566         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1567         * DumpRenderTree/win/DumpRenderTree.cpp:
1568         * DumpRenderTree/win/DumpRenderTreeWin.h:
1569         * DumpRenderTree/win/TestRunnerWin.cpp:
1570         (TestRunner::setSpellCheckerLoggingEnabled):
1571
1572 2017-01-11  Megan Gardner  <megan_gardner@apple.com>
1573
1574         Add committer status for Megan
1575         https://bugs.webkit.org/show_bug.cgi?id=166954
1576
1577         Reviewed by Tim Horton.
1578
1579         Add committer status for Megan Gardner
1580
1581         * Scripts/webkitpy/common/config/contributors.json:
1582
1583 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
1584
1585         Unreviewed test fix after r210599.
1586
1587         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
1588         (TestWebKitAPI::TEST): Remove debugging code that was causing a timeout.
1589
1590 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
1591
1592         Unreviewed build fix after r210599.
1593
1594         Add missing files.
1595
1596         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
1597         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
1598
1599 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
1600
1601         File scheme should not allow access of a resource on a different volume.
1602         https://bugs.webkit.org/show_bug.cgi?id=158552
1603         <rdar://problem/15307582>
1604
1605         Reviewed by Alex Christensen.
1606
1607         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
1608         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
1609         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
1610
1611 2017-01-11  Ryan Haddad  <ryanhaddad@apple.com>
1612
1613         Unreviewed, rolling out r210571.
1614
1615         This change broke the 32-bit macOS build and caused LayoutTest
1616         failures.
1617
1618         Reverted changeset:
1619
1620         "File scheme should not allow access of a resource on a
1621         different volume."
1622         https://bugs.webkit.org/show_bug.cgi?id=158552
1623         http://trac.webkit.org/changeset/210571
1624
1625 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1626
1627         [GTK] install-dependencies script misses gdb
1628         https://bugs.webkit.org/show_bug.cgi?id=166917
1629
1630         Reviewed by Michael Catanzaro.
1631
1632         gdb is needed for generating the crash logs.
1633
1634         * gtk/install-dependencies:
1635
1636 2017-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1637
1638         [GTK] No way for applications to set notification permissions without waiting for permission request
1639         https://bugs.webkit.org/show_bug.cgi?id=163366
1640
1641         Reviewed by Carlos Garcia Campos.
1642
1643         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1644         (testWebViewNotification):
1645         (setInitialNotificationPermissionsAllowedCallback):
1646         (setInitialNotificationPermissionsDisallowedCallback):
1647         (testWebViewNotificationInitialPermissionAllowed):
1648         (testWebViewNotificationInitialPermissionDisallowed):
1649         (beforeAll):
1650         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1651         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1652         (WebViewTest::WebViewTest):
1653         (WebViewTest::initializeWebView):
1654         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
1655
1656 2017-01-10  Tim Horton  <timothy_horton@apple.com>
1657
1658         MobileMiniBrowser tests don't work by default
1659         https://bugs.webkit.org/show_bug.cgi?id=166910
1660
1661         Reviewed by Alex Christensen.
1662
1663         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme: Added.
1664         Add a shared scheme; the Makefile depends on the MobileMiniBrowserUITests scheme existing, at the very least.
1665
1666 2017-01-10  Brent Fulgham  <bfulgham@apple.com>
1667
1668         File scheme should not allow access of a resource on a different volume.
1669         https://bugs.webkit.org/show_bug.cgi?id=158552
1670         <rdar://problem/15307582>
1671
1672         Reviewed by Alex Christensen.
1673
1674         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
1675         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
1676         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
1677
1678 2017-01-10  Mark Lam  <mark.lam@apple.com>
1679
1680         Reverting run-jsc-stress-tests' $buildType to use string values.
1681         https://bugs.webkit.org/show_bug.cgi?id=166912
1682
1683         Rubber stamped by Filip Pizlo.
1684
1685         This is so that we can test for it in the tests e.g.
1686         //@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end
1687
1688         * Scripts/run-jsc-stress-tests:
1689
1690 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
1691
1692         Temporarily add back the file removed in r210463 to unbreak internal bots.
1693
1694         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
1695
1696 2017-01-10  Jonathan Bedard  <jbedard@apple.com>
1697
1698         svn-apply failed to apply a patch (deleting file with svn property)
1699         https://bugs.webkit.org/show_bug.cgi?id=165953
1700
1701         Reviewed by Daniel Bates.
1702
1703         * Scripts/VCSUtils.pm:
1704         (parseSvnPropertyValue): The beginning of a diff will cause an early exit in the case of no empty newlines.
1705         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Add tests without break between diffs for properties.
1706
1707 2017-01-10  Ryan Haddad  <ryanhaddad@apple.com>
1708
1709         Update flakiness dashboard configuration.
1710         https://bugs.webkit.org/show_bug.cgi?id=166869
1711
1712         Reviewed by Alexey Proskuryakov.
1713
1714         * TestResultServer/static-dashboards/builders.jsonp:
1715         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1716
1717 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1718
1719         [GTK] Stop honoring the environment variable USE_NATIVE_XDISPLAY
1720         https://bugs.webkit.org/show_bug.cgi?id=165232
1721
1722         Unreviewed follow-up patch after r210539 and r210523.
1723
1724         Instead of using that environment variable, the argument
1725         --display-server=xorg should be passed now.
1726
1727         The GTK+ performance bot was the only bot using this, and is
1728         already passing --display-server=xorg after r210539.
1729
1730         * Scripts/webkitpy/port/gtk.py:
1731         (GtkPort._driver_class):
1732
1733 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1734
1735         [GTK] Add a new release test bot for Wayland and pass --display-server=xorg to the GTK Perf bot.
1736         https://bugs.webkit.org/show_bug.cgi?id=166872
1737
1738         Reviewed by Michael Catanzaro.
1739
1740         Add the new wayland release test bot as a test-only bot. It will download the built product from the release build-only bot.
1741         Define the required "--display-server=driver" in the bot additionalArguments config entry.
1742         Implement support for honoring additionalArguments on the RunGtkAPITests and RunAndUploadPerfTests steps.
1743         The step RunWebKitTests already has support for it.
1744
1745         * BuildSlaveSupport/build.webkit.org-config/config.json:
1746         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1747         (RunGtkAPITests.start):
1748         (RunAndUploadPerfTests.start):
1749         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1750
1751 2017-01-09  Ryan Haddad  <ryanhaddad@apple.com>
1752
1753         Unreviewed, rolling out r210531.
1754
1755         This change broke the 32-bit macOS build and caused LayoutTest
1756         failures.
1757
1758         Reverted changeset:
1759
1760         "File scheme should not allow access of a resource on a
1761         different volume."
1762         https://bugs.webkit.org/show_bug.cgi?id=158552
1763         http://trac.webkit.org/changeset/210531
1764
1765 2017-01-09  Brent Fulgham  <bfulgham@apple.com>
1766
1767         File scheme should not allow access of a resource on a different volume.
1768         https://bugs.webkit.org/show_bug.cgi?id=158552
1769         <rdar://problem/15307582>
1770
1771         Reviewed by Alex Christensen.
1772
1773         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
1774         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
1775         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
1776
1777 2017-01-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1778
1779         [GTK][Wayland] Allow running the layout tests under a native Wayland environment.
1780         https://bugs.webkit.org/show_bug.cgi?id=165232
1781
1782         Reviewed by Michael Catanzaro.
1783
1784         Add a new WaylandDriver to run the tests in the user current wayland session.
1785
1786         Also merge all the configuration options for selecting the display server inside one
1787         switch --display-server=xvfb/xorg/wayland/weston (defaulting to xvfb).
1788
1789         This switch is supported on the scripts: run-gtk-tests, run-perf-tests and run-webkit-tests.
1790
1791         * Scripts/run-gtk-tests: Add missing logging.basicConfig() initialization for the error logger.
1792         (TestRunner._create_driver):
1793         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1794         (parse_args):
1795         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1796         (PerfTestsRunner._parse_args):
1797         * Scripts/webkitpy/port/gtk.py:
1798         (GtkPort.__init__):
1799         (GtkPort._driver_class):
1800         (GtkPort._search_paths):
1801         * Scripts/webkitpy/port/waylanddriver.py: Added.
1802         (WaylandDriver):
1803         (WaylandDriver.check_driver):
1804         (WaylandDriver._setup_environ_for_test):
1805         (WaylandDriver._start):
1806
1807 2017-01-09  Andy Estes  <aestes@apple.com>
1808
1809         [QuickLook] Add a layout test for webkit.org/b/135651
1810         https://bugs.webkit.org/show_bug.cgi?id=166855
1811
1812         Reviewed by Andreas Kling.
1813
1814         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1815         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): Added output for
1816         errors with code WebKitErrorCannotShowURL.
1817         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1818         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Made the error output
1819         not specific to WebKit2 error codes.
1820
1821 2017-01-09  Antoine Quint  <graouts@apple.com>
1822
1823         Support webkit-test-runner key-value pairs in http tests in DumpRenderTree
1824         https://bugs.webkit.org/show_bug.cgi?id=166837
1825
1826         Reviewed by Alex Christensen.
1827
1828         We now correctly handle the --absolutePath argument in DumpRenderTree and use
1829         the provided value when trying to determine the path to the test file. Failing
1830         that, we use the computed URL or the raw path provided to cover all cases.
1831         
1832         This was tested in the context of https://bugs.webkit.org/show_bug.cgi?id=165668
1833         by applying this patch and seeing the number test failures dramatically reduced
1834         with WK1 due to the option to turn modern media controls off for older media controls
1835         tests.
1836
1837         * DumpRenderTree/DumpRenderTree.h:
1838         * DumpRenderTree/DumpRenderTreeCommon.cpp:
1839         (parseInputLine):
1840         * DumpRenderTree/TestOptions.h:
1841         * DumpRenderTree/TestOptions.mm:
1842         (TestOptions::TestOptions):
1843         * DumpRenderTree/mac/DumpRenderTree.mm:
1844         (runTest):
1845
1846 2017-01-09  Milan Crha  <mcrha@redhat.com>
1847
1848         prepare-ChangeLog: Correct help string for --style option
1849         https://bugs.webkit.org/show_bug.cgi?id=166725
1850
1851         Reviewed by Alexey Proskuryakov.
1852
1853         * Scripts/prepare-ChangeLog:
1854         (main):
1855
1856 2017-01-09  Lucas Forschler  <lforschler@apple.com>
1857
1858         https://bugs.webkit.org/show_bug.cgi?id=166839
1859         Add php7 support for macOS.
1860         Mirror the debian logic to look for a php7 module on disk, and return the appropriate apache config file.
1861
1862         Reviewed by Alexey Proskuryakov.
1863
1864         * Scripts/webkitpy/port/base.py:
1865         (Port._is_darwin_php_version_7):
1866         (Port._debian_php_version):
1867         (Port):
1868         (Port._darwin_php_version):
1869         (Port._apache_config_file_name_for_platform):
1870
1871 2017-01-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1872
1873         [GTK] Should support key and code properties on keyboard events
1874         https://bugs.webkit.org/show_bug.cgi?id=166759
1875
1876         Reviewed by Carlos Garcia Campos.
1877
1878         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1879         (WTR::getGDKKeySymForKeyRef): add missing modifier keys which were being reported as 'l' and 'r' only
1880         on tests.
1881
1882 2017-01-06  Per Arne Vollan  <pvollan@apple.com>
1883
1884         [Win] Some tests are flaky because certain DLLs are writing to stdout.
1885         https://bugs.webkit.org/show_bug.cgi?id=166760
1886
1887         Reviewed by Darin Adler.
1888
1889         Some tests are flaky because certain DLLs are writing to stdout, giving incorrect test results.
1890         We can work around that by duplicating and redirecting stdout.
1891
1892         * DumpRenderTree/PixelDumpSupport.cpp:
1893         (dumpWebViewAsPixelsAndCompareWithExpected):
1894         (printPNG):
1895         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1896         (logEventProc):
1897         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1898         (DRTDesktopNotificationPresenter::showDesktopNotification):
1899         (DRTDesktopNotificationPresenter::cancelDesktopNotification):
1900         (DRTDesktopNotificationPresenter::requestNotificationPermission):
1901         * DumpRenderTree/win/DumpRenderTree.cpp:
1902         (dumpFrameScrollPosition):
1903         (dumpHistoryItem):
1904         (dumpBackForwardList):
1905         (dump):
1906         (runTest):
1907         (main):
1908         * DumpRenderTree/win/DumpRenderTreeWin.h:
1909         * DumpRenderTree/win/EditingDelegate.cpp:
1910         (EditingDelegate::shouldBeginEditingInDOMRange):
1911         (EditingDelegate::shouldEndEditingInDOMRange):
1912         (EditingDelegate::shouldInsertNode):
1913         (EditingDelegate::shouldInsertText):
1914         (EditingDelegate::shouldDeleteDOMRange):
1915         (EditingDelegate::shouldChangeSelectedDOMRange):
1916         (EditingDelegate::shouldApplyStyle):
1917         (EditingDelegate::shouldChangeTypingStyle):
1918         (EditingDelegate::doPlatformCommand):
1919         (EditingDelegate::webViewDidBeginEditing):
1920         (EditingDelegate::webViewDidChange):
1921         (EditingDelegate::webViewDidEndEditing):
1922         (EditingDelegate::webViewDidChangeTypingStyle):
1923         (EditingDelegate::webViewDidChangeSelection):
1924         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1925         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
1926         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame):
1927         (FrameLoadDelegate::didChangeLocationWithinPageForFrame):
1928         (FrameLoadDelegate::didFailProvisionalLoadWithError):
1929         (FrameLoadDelegate::didCommitLoadForFrame):
1930         (FrameLoadDelegate::didReceiveTitle):
1931         (FrameLoadDelegate::didFinishLoadForFrame):
1932         (FrameLoadDelegate::didFailLoadWithError):
1933         (FrameLoadDelegate::willPerformClientRedirectToURL):
1934         (FrameLoadDelegate::didCancelClientRedirectForFrame):
1935         (FrameLoadDelegate::windowScriptObjectAvailable):
1936         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
1937         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
1938         (FrameLoadDelegate::didDisplayInsecureContent):
1939         (FrameLoadDelegate::didRunInsecureContent):
1940         (FrameLoadDelegate::webViewProgressFinishedNotification):
1941         * DumpRenderTree/win/HistoryDelegate.cpp:
1942         (HistoryDelegate::didNavigateWithNavigationData):
1943         (HistoryDelegate::didPerformClientRedirectFromURL):
1944         (HistoryDelegate::didPerformServerRedirectFromURL):
1945         (HistoryDelegate::updateHistoryTitle):
1946         (HistoryDelegate::populateVisitedLinksForWebView):
1947         * DumpRenderTree/win/PolicyDelegate.cpp:
1948         (PolicyDelegate::decidePolicyForNavigationAction):
1949         (PolicyDelegate::unableToImplementPolicyWithError):
1950         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1951         (ResourceLoadDelegate::willSendRequest):
1952         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
1953         (ResourceLoadDelegate::didReceiveResponse):
1954         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
1955         (ResourceLoadDelegate::didFailLoadingWithError):
1956         * DumpRenderTree/win/TestRunnerWin.cpp:
1957         (TestRunner::addDisallowedURL):
1958         (TestRunner::originsWithApplicationCache):
1959         (TestRunner::setStorageDatabaseIdleInterval):
1960         (TestRunner::closeIdleLocalStorageDatabases):
1961         (TestRunner::copyDecodedHostName):
1962         (TestRunner::copyEncodedHostName):
1963         (TestRunner::numberOfPendingGeolocationPermissionRequests):
1964         (TestRunner::isGeolocationProviderActive):
1965         (TestRunner::pathToLocalResource):
1966         (TestRunner::setMockDeviceOrientation):
1967         (TestRunner::setMockGeolocationPosition):
1968         (TestRunner::setMockGeolocationPositionUnavailableError):
1969         (TestRunner::setSpatialNavigationEnabled):
1970         (TestRunner::setAutomaticLinkDetectionEnabled):
1971         (TestRunner::isCommandEnabled):
1972         (TestRunner::authenticateSession):
1973         (TestRunner::addChromeInputField):
1974         (TestRunner::removeChromeInputField):
1975         (TestRunner::focusWebView):
1976         (TestRunner::grantWebNotificationPermission):
1977         (TestRunner::denyWebNotificationPermission):
1978         (TestRunner::removeAllWebNotificationPermissions):
1979         (TestRunner::simulateWebNotificationClick):
1980         (TestRunner::imageCountInGeneralPasteboard):
1981         * DumpRenderTree/win/UIDelegate.cpp:
1982         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1983         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1984         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1985         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
1986         (UIDelegate::webViewAddMessageToConsole):
1987         (UIDelegate::exceededDatabaseQuota):
1988         (UIDelegate::setStatusText):
1989         (UIDelegate::didPressMissingPluginButton):
1990
1991 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1992
1993         Add a setting to create editable MiniBrowser windows by default
1994         https://bugs.webkit.org/show_bug.cgi?id=166806
1995
1996         Reviewed by Beth Dakin.
1997
1998         * MiniBrowser/mac/AppDelegate.m:
1999         (-[BrowserAppDelegate createBrowserWindowController:]):
2000         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
2001         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
2002         * MiniBrowser/mac/SettingsController.h:
2003         * MiniBrowser/mac/SettingsController.m:
2004         (-[SettingsController _populateMenu]):
2005         (-[SettingsController validateMenuItem:]):
2006         (-[SettingsController toggleCreateEditorByDefault:]):
2007         (-[SettingsController createEditorByDefault]):
2008         Add a setting and update the key equivalents accordingly.
2009         Also make sure to make the right kind of window on launch.
2010
2011 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2012
2013         Fix the 32-bit build.
2014
2015         * MiniBrowser/mac/BrowserWindowController.h:
2016         * MiniBrowser/mac/BrowserWindowController.m:
2017
2018 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2019
2020         Fix the 32-bit build.
2021
2022         * MiniBrowser/mac/BrowserWindowController.m:
2023
2024 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2025
2026         Make it possible to drop HTML files on the MiniBrowser icon
2027         https://bugs.webkit.org/show_bug.cgi?id=166802
2028
2029         Reviewed by Simon Fraser.
2030
2031         * MiniBrowser/mac/AppDelegate.m:
2032         (-[BrowserAppDelegate application:openFile:]):
2033         * MiniBrowser/mac/Info.plist:
2034         If you're using an editable window, the usual trick of dropping on the
2035         window doesn't work anymore (it makes an <attachment> instead).
2036
2037 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2038
2039         MiniBrowser window gets smaller each time it is instantiated
2040         https://bugs.webkit.org/show_bug.cgi?id=166807
2041
2042         Reviewed by Andy Estes.
2043
2044         * MiniBrowser/mac/BrowserWindowController.m:
2045         (-[BrowserWindowController windowDidLoad]):
2046         * MiniBrowser/mac/BrowserWindow.xib:
2047         Turn on full-window content view support with IB, instead of waiting
2048         until after the views have been loaded. This seems to resolve the
2049         longstanding ever-shrinking-window problem.
2050
2051 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2052
2053         Add indent/outdent items to MiniBrowser's new format menu
2054         https://bugs.webkit.org/show_bug.cgi?id=166805
2055
2056         Reviewed by Dan Bernstein.
2057
2058         * MiniBrowser/mac/MainMenu.xib:
2059
2060 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2061
2062         Add a stock Format menu to MiniBrowser
2063         https://bugs.webkit.org/show_bug.cgi?id=166804
2064
2065         Reviewed by Andy Estes.
2066
2067         * MiniBrowser/mac/MainMenu.xib:
2068         Many of the features automatically work with editable web views.
2069         However, this seems to expose a bug where none of the font-related features
2070         (Cmd-B, for example) work until the first time the font panel is shown,
2071         per process, which will need to be investigated separately.
2072
2073 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2074
2075         Remove unused applicationWillTerminate methods from MiniBrowser
2076         https://bugs.webkit.org/show_bug.cgi?id=166803
2077
2078         Reviewed by Andy Estes.
2079
2080         * MiniBrowser/mac/AppDelegate.m:
2081         (-[BrowserAppDelegate applicationWillTerminate:]): Deleted.
2082         * MiniBrowser/mac/BrowserWindowController.h:
2083         * MiniBrowser/mac/BrowserWindowController.m:
2084         (-[BrowserWindowController applicationTerminating]): Deleted.
2085         * MiniBrowser/mac/WK1BrowserWindowController.m:
2086         (-[WK1BrowserWindowController applicationTerminating]): Deleted.
2087         * MiniBrowser/mac/WK2BrowserWindowController.m:
2088         (-[WK2BrowserWindowController applicationTerminating]): Deleted.
2089
2090 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2091
2092         Add the ability to create empty contentEditable windows in MiniBrowser
2093         https://bugs.webkit.org/show_bug.cgi?id=166801
2094
2095         Reviewed by Wenson Hsieh.
2096
2097         * MiniBrowser/mac/AppDelegate.h:
2098         * MiniBrowser/mac/AppDelegate.m:
2099         (-[BrowserAppDelegate createBrowserWindowController:]):
2100         (-[BrowserAppDelegate newWindow:]):
2101         (-[BrowserAppDelegate newEditorWindow:]):
2102         (-[BrowserAppDelegate openDocument:]):
2103         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
2104         * MiniBrowser/mac/BrowserWindowController.h:
2105         * MiniBrowser/mac/BrowserWindowController.m:
2106         (-[BrowserWindowController loadHTMLString:]):
2107         (-[BrowserWindowController toggleEditable:]):
2108         * MiniBrowser/mac/MainMenu.xib:
2109         * MiniBrowser/mac/WK1BrowserWindowController.m:
2110         (-[WK1BrowserWindowController awakeFromNib]):
2111         (-[WK1BrowserWindowController loadHTMLString:]):
2112         (-[WK1BrowserWindowController validateMenuItem:]):
2113         (-[WK1BrowserWindowController setEditable:]):
2114         (-[WK1BrowserWindowController updateTitle:]):
2115         * MiniBrowser/mac/WK2BrowserWindowController.m:
2116         (-[WK2BrowserWindowController awakeFromNib]):
2117         (-[WK2BrowserWindowController validateMenuItem:]):
2118         (-[WK2BrowserWindowController setEditable:]):
2119         (-[WK2BrowserWindowController updateTitle:]):
2120         (-[WK2BrowserWindowController loadHTMLString:]):
2121         Merge more functionality from WebEditingTester.
2122         Add two menu items for creating empty editable WebKit1/2 windows.
2123         Add a menu item to the Edit menu to toggle editability on any window.
2124
2125 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2126
2127         Implement find-in-page in MiniBrowser
2128         https://bugs.webkit.org/show_bug.cgi?id=166799
2129
2130         Reviewed by Andy Estes.
2131
2132         * MiniBrowser/mac/BrowserWindow.xib:
2133         * MiniBrowser/mac/BrowserWindowController.h:
2134         * MiniBrowser/mac/BrowserWindowController.m:
2135         (-[BrowserWindowController find:]): Deleted.
2136         * MiniBrowser/mac/MainMenu.xib:
2137         * MiniBrowser/mac/WK1BrowserWindowController.m:
2138         (-[WK1BrowserWindowController toggleShrinkToFit:]):
2139         (-[WK1BrowserWindowController find:]): Deleted.
2140         * MiniBrowser/mac/WK2BrowserWindowController.m:
2141         (-[WK2BrowserWindowController awakeFromNib]):
2142         (-[WK2BrowserWindowController dealloc]):
2143         (-[WK2BrowserWindowController validateMenuItem:]):
2144         (-[WK2BrowserWindowController performTextFinderAction:]):
2145         (-[WK2BrowserWindowController findBarView]):
2146         (-[WK2BrowserWindowController setFindBarView:]):
2147         (-[WK2BrowserWindowController isFindBarVisible]):
2148         (-[WK2BrowserWindowController setFindBarVisible:]):
2149         (-[WK2BrowserWindowController contentView]):
2150         (-[WK2BrowserWindowController findBarViewDidChangeHeight]):
2151         (-[WK2BrowserWindowController performFindPanelAction:]): Deleted.
2152         (-[WK2BrowserWindowController find:]): Deleted.
2153         Implement find-in-page using WKWebView's conformance to the NSTextFinderClient
2154         protocol. At first glance, it's pretty broken, but vaguely works.
2155
2156 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2157
2158         Share the implementation of MiniBrowser view hiding functionality
2159         https://bugs.webkit.org/show_bug.cgi?id=166800
2160
2161         Reviewed by Andy Estes.
2162
2163         * MiniBrowser/mac/BrowserWindowController.m:
2164         (-[BrowserWindowController showHideWebView:]):
2165         (-[BrowserWindowController removeReinsertWebView:]):
2166         * MiniBrowser/mac/WK1BrowserWindowController.m:
2167         (-[WK1BrowserWindowController showHideWebView:]): Deleted.
2168         (-[WK1BrowserWindowController removeReinsertWebView:]): Deleted.
2169         * MiniBrowser/mac/WK2BrowserWindowController.m:
2170         (-[WK2BrowserWindowController showHideWebView:]): Deleted.
2171         (-[WK2BrowserWindowController removeReinsertWebView:]): Deleted.
2172         Move the implementation of these two things to the shared superclass,
2173         since they don't depend on WebKit-specific things.
2174         Also, there was no reason to retain the (WK)WebView while it was unparented,
2175         as the BrowserWindowController maintains a reference the entire time.
2176
2177 2017-01-06  Andy Estes  <aestes@apple.com>
2178
2179         [Cocoa] Consolidate duplicate copies of WebArchiveDumpSupport in DRT and WKTR into WebCoreTestSupport
2180         https://bugs.webkit.org/show_bug.cgi?id=166789
2181
2182         Reviewed by Alex Christensen.
2183
2184         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2185         * DumpRenderTree/PlatformMac.cmake:
2186         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: Removed.
2187         * DumpRenderTree/cf/WebArchiveDumpSupport.h: Removed.
2188         * DumpRenderTree/mac/DumpRenderTree.mm:
2189         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
2190         createXMLStringFromWebArchiveData().
2191         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: Removed.
2192         * WebKitTestRunner/Configurations/Base.xcconfig:
2193         Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to HEADER_SEARCH_PATHS.
2194         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2195         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
2196         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
2197         createXMLStringFromWebArchiveData().
2198         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Removed.
2199         * WebKitTestRunner/PlatformMac.cmake:
2200         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2201         * WebKitTestRunner/cf/WebArchiveDumpSupport.h: Removed.
2202
2203 2017-01-06  Tim Horton  <timothy_horton@apple.com>
2204
2205         Minor cleanups to IndentOutdentCommand and related code
2206         https://bugs.webkit.org/show_bug.cgi?id=166791
2207
2208         Reviewed by Simon Fraser.
2209
2210         * WebEditingTester/EditingOperations.m:
2211         (editingOperations):
2212         Add the outdent operation to WebEditingTester.
2213
2214 2017-01-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
2215
2216         Create a plan and a patch files for MotionMark and delete the Animometer's ones
2217         https://bugs.webkit.org/show_bug.cgi?id=166785
2218
2219         Reviewed by Ryosuke Niwa.
2220
2221         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
2222         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan.
2223
2224 2017-01-06  Antoine Quint  <graouts@apple.com>
2225
2226         Support webkit-test-runner key-value pairs in http tests
2227         https://bugs.webkit.org/show_bug.cgi?id=149812
2228
2229         Reviewed by Alex Christensen.
2230
2231         We pass the absolute path for a test through to WKTR so that we can parse
2232         tests that are running as URLs for webkit-test-runner options.
2233
2234         * DumpRenderTree/DumpRenderTreeCommon.cpp:
2235         (parseInputLine):
2236
2237         Explicitly skip the --absolute-path option in DRT or else we'd crash.
2238
2239         * Scripts/webkitpy/port/driver.py:
2240         (Driver._command_from_driver_input):
2241
2242         Pass the absolute path to the file through the CLI.
2243
2244         * WebKitTestRunner/TestController.cpp:
2245         (WTR::updateTestOptionsFromTestHeader):
2246         (WTR::TestController::testOptionsForTest):
2247         (WTR::parseInputLine):
2248         (WTR::TestController::runTest):
2249         * WebKitTestRunner/TestController.h:
2250
2251 2017-01-06  Tim Horton  <timothy_horton@apple.com>
2252
2253         Warning about unconnectable outlets when opening a MiniBrowser window
2254         https://bugs.webkit.org/show_bug.cgi?id=166756
2255
2256         Reviewed by Dan Bernstein.
2257
2258         * MiniBrowser/mac/BrowserWindow.xib:
2259         When launching MiniBrowser, it says:
2260         Failed to connect (Share) outlet from (WK1BrowserWindowController) to
2261             (MBToolbarItem): missing setter or instance variable
2262         Failed to connect (shareButton) outlet from (WK1BrowserWindowController) to
2263             (NSButtonCell): missing setter or instance variable.
2264
2265         It looks like someone added the connection from the share button
2266         to the BrowserWindowController three times; only one of the connections
2267         is valid. Remove the other two.
2268
2269 2017-01-05  Keith Rollin  <krollin@apple.com>
2270
2271         Add WebCore::URL::protocolHostAndPort
2272         https://bugs.webkit.org/show_bug.cgi?id=166426
2273
2274         Reviewed by Alex Christensen.
2275
2276         Add test for protocolHostAndPort.
2277
2278         * TestWebKitAPI/Tests/WebCore/URL.cpp:
2279         (TestWebKitAPI::TEST_F):
2280
2281 2017-01-05  Per Arne Vollan  <pvollan@apple.com>
2282
2283         [Win] Archive test result is failing.
2284         https://bugs.webkit.org/show_bug.cgi?id=166720
2285
2286         Reviewed by Alex Christensen.
2287
2288         Deleting the layout test result folder is sometimes failing
2289         on Windows. This is not a critical error.
2290
2291         * BuildSlaveSupport/test-result-archive:
2292         (archiveTestResults):
2293
2294 2017-01-04  Tomas Popela  <tpopela@redhat.com>
2295
2296         [GTK] Minibrowser: Add printing support
2297         https://bugs.webkit.org/show_bug.cgi?id=165298
2298
2299         Open a print dialog when the Ctrl + P shortcut is pressed. If there is
2300         an error during the print, it's printed on the console.
2301
2302         Reviewed by Michael Catanzaro.
2303
2304         * MiniBrowser/gtk/BrowserWindow.c:
2305         (webKitPrintOperationFailedCallback):
2306         (printPage):
2307         (browser_window_init):
2308
2309 2017-01-04  Manuel Rego Casasnovas  <rego@igalia.com>
2310
2311         [css-grid] Fix crash clamping grid lines
2312         https://bugs.webkit.org/show_bug.cgi?id=166637
2313
2314         Reviewed by Darin Adler.
2315
2316         Creates new unit test to verify that the maximum tracks limit
2317         is used in GridPosition too.
2318
2319         * TestWebKitAPI/PlatformEfl.cmake:
2320         * TestWebKitAPI/PlatformGTK.cmake:
2321         * TestWebKitAPI/PlatformWin.cmake:
2322         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2323         * TestWebKitAPI/Tests/WebCore/GridPosition.cpp: Added.
2324         (TestWebKitAPI::TEST):
2325
2326 2017-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2327
2328         Move editing history scripts to WebCore PrivateHeaders
2329         https://bugs.webkit.org/show_bug.cgi?id=166709
2330         <rdar://problem/29876612>
2331
2332         Reviewed by Dan Bernstein.
2333
2334         Update references to editing script files in WebCore that were moved.
2335
2336         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
2337
2338 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
2339
2340         Unreviewed, build fix after r210313 part 2
2341         https://bugs.webkit.org/show_bug.cgi?id=166676
2342
2343         Add 'U' suffix.
2344
2345         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2346         (TestWebKitAPI::TEST):
2347         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2348         (TestWebKitAPI::TEST):
2349
2350 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
2351
2352         Limit thread name appropriately
2353         https://bugs.webkit.org/show_bug.cgi?id=166676
2354
2355         Reviewed by Sam Weinig.
2356
2357         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2358         (TestWebKitAPI::TEST):
2359         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2360         (TestWebKitAPI::TEST):
2361
2362 2017-01-04  Andy Estes  <aestes@apple.com>
2363
2364         [Cocoa] Teach SharedBuffer to return an NSArray of data segments to avoid flattening
2365         https://bugs.webkit.org/show_bug.cgi?id=166696
2366
2367         Reviewed by Tim Horton.
2368
2369         * TestWebKitAPI/PlatformGTK.cmake:
2370         * TestWebKitAPI/PlatformWin.cmake:
2371         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2372         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Moved class SharedBufferTest to SharedBufferTest.{cpp,h}.
2373         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp: Moved class SharedBufferTest from SharedBuffer.cpp.
2374         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.h: Ditto.
2375         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm: Added.
2376         (TestWebKitAPI::expectDataArraysEqual): Added a helper to assert that two NSArrays of NSData are equal.
2377         (TestWebKitAPI::TEST_F): Added a test for createNSDataArray.
2378
2379 2017-01-03  Brian Burg  <bburg@apple.com>
2380
2381         Web Inspector: teach the protocol generator about platform-specific types, events, and commands
2382         https://bugs.webkit.org/show_bug.cgi?id=166003
2383         <rdar://problem/28718990>
2384
2385         Reviewed by Joseph Pecoraro.
2386
2387         Teach run-inspector-generator-tests to generate test output using the platform name
2388         derived from the directory that the test is in. For example, tests in the /generic/
2389         subdirectory will pass `--platform generic` to generate-inspector-protocol-bindings.py.
2390
2391         * Scripts/webkitpy/inspector/main.py:
2392         (InspectorGeneratorTests.generate_from_json):
2393         (InspectorGeneratorTests.run_tests):
2394         (InspectorGeneratorTests.main):
2395
2396 2017-01-04  Csaba Osztrogonác  <ossy@webkit.org>
2397
2398         Unreviewed cmake buildfix after r210266.
2399
2400         * DumpRenderTree/PlatformMac.cmake:
2401
2402 2017-01-04  Tim Horton  <timothy_horton@apple.com>
2403
2404         Provide a setting for clients to always prefer low-power WebGL
2405         https://bugs.webkit.org/show_bug.cgi?id=166675
2406         <rdar://problem/29834093>
2407
2408         Reviewed by Dan Bernstein.
2409
2410         * MiniBrowser/mac/Info.plist:
2411         Have MiniBrowser claim to be a modern app that supports
2412         automatic graphics switching. WebKit needs to support automatic
2413         graphics switching, so our test app might as well. Without this
2414         Info.plist parameter, this change has no effect, and bringing up
2415         a WebGL context still brings up the discrete GPU (also true of the
2416         existing web-exposed preferLowPowerToHighPerformance API).
2417
2418 2017-01-03  Yusuke Suzuki  <utatane.tea@gmail.com>
2419
2420         WorkQueueGeneric's platformInvalidate() can deadlock when called on the RunLoop's thread
2421         https://bugs.webkit.org/show_bug.cgi?id=166645
2422
2423         Reviewed by Carlos Garcia Campos.
2424
2425         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2426         (TestWebKitAPI::TEST):
2427
2428 2017-01-03  Andy Estes  <aestes@apple.com>
2429
2430         Place all the Cocoa WebCore API tests in the same directory
2431         https://bugs.webkit.org/show_bug.cgi?id=166673
2432
2433         Reviewed by Michael Catanzaro.
2434
2435         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2436         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm.
2437         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/Cocoa/URLExtras.mm.
2438         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm.
2439
2440 2017-01-03  Tim Horton  <timothy_horton@apple.com>
2441
2442         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
2443         https://bugs.webkit.org/show_bug.cgi?id=166450
2444         <rdar://problem/29447824>
2445
2446         Reviewed by Darin Adler.
2447
2448         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2449         * DumpRenderTree/TestRunner.cpp:
2450         (TestRunner::staticFunctions):
2451         * DumpRenderTree/mac/TestRunnerMac.mm:
2452         (setSpellCheckerLoggingEnabledCallback):
2453         * DumpRenderTree/win/TestRunnerWin.cpp:
2454         (setSpellCheckerLoggingEnabledCallback):
2455         * DumpRenderTree/mac/DumpRenderTree.mm:
2456         (resetWebViewToConsistentStateBeforeTesting):
2457         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.h: Added.
2458         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.mm: Added.
2459         (stringForCorrectionResponse):
2460         (drt_NSSpellChecker_recordResponseToCorrection):
2461         (swizzleNSSpellCheckerMethodsIfNeeded):
2462         (setSpellCheckerLoggingEnabled):
2463         Add a new testRunner method, setSpellCheckerLoggingEnabled, which, when
2464         set to true, logs to stdout (which ends up in the test result) whenever
2465         NSSpellChecker recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
2466         is called, and then calls the original method. It is reset to false between tests.
2467
2468 2017-01-03  Sam Weinig  <sam@webkit.org>
2469
2470         Make WTF::Expected support Ref template parameters
2471         https://bugs.webkit.org/show_bug.cgi?id=166662
2472
2473         Reviewed by Alex Christensen.
2474
2475         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2476         (TestWebKitAPI::TEST):
2477         Add tests for using Ref with Expected.
2478
2479 2017-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2480
2481         [GTK] Expose WebKitSecurityOrigin API
2482         https://bugs.webkit.org/show_bug.cgi?id=166632
2483
2484         Reviewed by Carlos Garcia Campos.
2485
2486         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2487         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp: Added.
2488         (testSecurityOriginBasicConstructor):
2489         (testSecurityOriginURIConstructor):
2490         (testSecurityOriginDefaultPort):
2491         (testSecurityOriginFileURI):
2492         (testSecurityOriginDataURI):
2493         (beforeAll):
2494         (afterAll):
2495
2496 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2497
2498         [GTK] HTTP auth layout tests are flaky
2499         https://bugs.webkit.org/show_bug.cgi?id=158919
2500
2501         Reviewed by Michael Catanzaro.
2502
2503         * gtk/jhbuild.modules: Update libsoup to version 2.57.1.
2504         * gtk/jhbuildrc: Stop passing --enable-introspection unconditionally to all modules. We don't really need
2505         introspection for the dependencies in the internal build, and it makes newer libsoup build fail because of
2506         missing valac in the bots.
2507
2508 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2509
2510         REGRESSION(r173753): [GTK] Source/WebKit is distributed in tarballs
2511         https://bugs.webkit.org/show_bug.cgi?id=165797
2512
2513         Reviewed by Michael Catanzaro.
2514
2515         Move directory ruleset after all exclude rules of Source rulset.
2516
2517         * gtk/manifest.txt.in:
2518
2519 2017-01-02  Yusuke Suzuki  <utatane.tea@gmail.com>
2520
2521         Leverage Substring to create new AtomicStringImpl for StaticStringImpl and SymbolImpl
2522         https://bugs.webkit.org/show_bug.cgi?id=166636
2523
2524         Reviewed by Darin Adler.
2525
2526         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2527         (TestWebKitAPI::TEST):
2528
2529 2017-01-02  Manuel Rego Casasnovas  <rego@igalia.com>
2530
2531         [GTK] WebCore/CSSParser unit test is not being built
2532         https://bugs.webkit.org/show_bug.cgi?id=166492
2533
2534         Reviewed by Michael Catanzaro.
2535
2536         This test was introduced in r175930, but we were not building
2537         it on GTK+ port since r176015.
2538         This patch marks the test to be built again on GTK+.
2539         JFTR, the test is passing right now.
2540
2541         * TestWebKitAPI/PlatformGTK.cmake: Add CSSParser.cpp test file and use
2542         ADD_WHOLE_ARCHIVE_TO_LIBRARIES to avoid linking errors.
2543
2544 2017-01-02  Chris Fleizach  <cfleizach@apple.com>
2545
2546         AX: Expose block quote level to iOS API
2547         https://bugs.webkit.org/show_bug.cgi?id=166629
2548         <rdar://problem/29834793>
2549
2550         Reviewed by Darin Adler.
2551
2552         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2553         (AccessibilityUIElement::numberAttributeValue):
2554         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2555         (WTR::AccessibilityUIElement::numberAttributeValue):
2556
2557 2016-12-31  Michael Catanzaro  <mcatanzaro@igalia.com>
2558
2559         SecurityOrigin::create triplet constructor does not canonicalize port
2560         https://bugs.webkit.org/show_bug.cgi?id=166624
2561
2562         Reviewed by Daniel Bates.
2563
2564         * TestWebKitAPI/PlatformGTK.cmake:
2565         * TestWebKitAPI/PlatformWin.cmake:
2566         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2567         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Added.
2568         (TestWebKitAPI::SecurityOriginTest::SetUp):
2569         (TestWebKitAPI::TEST_F):
2570
2571 2016-12-30  Michael Catanzaro  <mcatanzaro@igalia.com>
2572
2573         [GTK] Improve user agent construction
2574         https://bugs.webkit.org/show_bug.cgi?id=142074
2575
2576         Reviewed by Carlos Garcia Campos.
2577
2578         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2579         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
2580         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
2581         (TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk):
2582         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
2583         (TestWebKitAPI::TEST):
2584
2585 2016-12-27  Michael Catanzaro  <mcatanzaro@igalia.com>
2586
2587         [GTK] Improve user agent construction
2588         https://bugs.webkit.org/show_bug.cgi?id=142074
2589
2590         Reviewed by Carlos Garcia Campos.
2591
2592         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2593         (TestWebKitAPI::TEST):
2594
2595 2016-12-23  Simon Fraser  <simon.fraser@apple.com>
2596
2597         REGRESSION (r209299): Selection is broken when you zoom in webpage using trackpad
2598         https://bugs.webkit.org/show_bug.cgi?id=166472
2599         rdar://problem/29675551
2600
2601         Reviewed by Tim Horton.
2602
2603         These changes are necessary to allow the mouse to leave the WTR window while
2604         drag-scrolling, to test autoscroll. Previously, we were never calling -mouseDragged
2605         (which DRT does); we'd always go through mouseMoved, which hits an early return
2606         in WebViewImpl::mouseMoved() when the point is outside the view.
2607
2608         * WebKitTestRunner/mac/EventSenderProxy.mm:
2609         (WTR::EventSenderProxy::mouseMoveTo):
2610
2611 2016-12-23  Andy Estes  <aestes@apple.com>
2612
2613         [iOS] Fix some crashing webarchive tests
2614         https://bugs.webkit.org/show_bug.cgi?id=166470
2615
2616         Reviewed by Andreas Kling.
2617
2618         Tests that use TestRunner.dumpDOMAsWebArchive() crashed on iOS due to a stub implementation
2619         of WebArchiveDumpSupport in WebKitTestRunner. The Mac implementation works fine on iOS too,
2620         so this change uses that on both platforms.
2621
2622         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Removed
2623         WebArchiveDumpSupportMac.mm from EXCLUDED_SOURCE_FILE_NAMES.
2624         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Renamed from
2625         Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm.
2626         * WebKitTestRunner/PlatformMac.cmake:
2627         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2628         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Removed.
2629
2630 2016-12-22  Saam Barati  <sbarati@apple.com>
2631
2632         WebAssembly: Silence the output of the spec-tests
2633         https://bugs.webkit.org/show_bug.cgi?id=166417
2634
2635         Reviewed by Mark Lam.
2636
2637         * Scripts/run-jsc-stress-tests:
2638
2639 2016-12-22  Zhuo Li  <zachli@apple.com>
2640
2641         [Cocoa] SPI for setloadsImagesAutomatically.
2642         https://bugs.webkit.org/show_bug.cgi?id=166401.
2643
2644         Reviewed by Darin Adler.
2645
2646         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
2647         (TEST): Test the _setLoadsImagesAutomatically SPI. By default,
2648         _loadsImagesAutomatically returns YES.
2649
2650 2016-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2651
2652         fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html is flaky/order dependent
2653         https://bugs.webkit.org/show_bug.cgi?id=161328
2654         <rdar://problem/28475977>
2655
2656         Reviewed by Darin Adler.
2657
2658         Running a test that scales the viewport and listens to a didEndZooming callback (such as
2659         viewport-shrink-to-fit-allows-double-tap.html) immediately after a test that may begin to trigger viewport
2660         scaling as the test completes (such as viewport-device-width-at-initial-scale-fast-clicks.html) may result in
2661         the didEndZooming callback of the latter test being fired early due to the previous test triggering a zoom
2662         animation. Ideally, -[WKScrollView _stopScrollingAndZoomingAnimations], which is called when committing the page
2663         load, should prevent this from happening, but from reading documentation and code inspection, this is not
2664         intended to fire any associated delegate methods or notifications of the UIScrollView, instead deferring them
2665         for later. Instead, what we need in this case is to clear out any started but not yet completed animations after
2666         we finish running a test and before we load the next test.
2667
2668         One way to do this is to remove all animations from the WKScrollView's layer, and the layers of its children,
2669         recursively. Doing so causes scrollViewDidEndZooming:withView:atScale: to fire at the end of the runloop if the
2670         previous test started zooming and then finished before zooming completed. Since this happens before the next
2671         test has a chance to run UI-side scripts, we won't end up firing this callback prematurely during the next test.
2672
2673         * WebKitTestRunner/ios/TestControllerIOS.mm:
2674         (WTR::TestController::platformResetStateToConsistentValues):
2675
2676 2016-12-22  Jer Noble  <jer.noble@apple.com>
2677
2678         Muted media element playback should not interrupt other audio playback
2679         https://bugs.webkit.org/show_bug.cgi?id=166347
2680
2681         Reviewed by Eric Carlson.
2682
2683         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2684         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
2685         (TestWebKitAPI::TEST):
2686         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio.html: Added.
2687
2688 2016-12-22  Alejandro G. Castro  <alex@igalia.com>
2689
2690         [WebRTC] Add support for runtime PeeConnection setting, required after r209757
2691         https://bugs.webkit.org/show_bug.cgi?id=166346
2692
2693         Reviewed by Carlos Garcia Campos.
2694
2695         Enable WebRTC by default to simplify testing.
2696
2697         * MiniBrowser/gtk/main.c:
2698         (main):
2699
2700 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
2701
2702         REGRESSION: API test failure: WKWebView.LocalStorageClear
2703         https://bugs.webkit.org/show_bug.cgi?id=166032
2704         <rdar://problem/29758423>
2705
2706         Reviewed by Simon Fraser.
2707
2708         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
2709         to ensure that the view is destroyed before the callback fires.
2710
2711         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2712         (TEST):
2713
2714 2016-12-21  Saam Barati  <sbarati@apple.com>
2715
2716         WebAssembly: Import spec tests
2717         https://bugs.webkit.org/show_bug.cgi?id=166395
2718
2719         Rubber stamped by Keith Miller.
2720
2721         * Scripts/run-jsc-stress-tests:
2722
2723 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
2724
2725         REGRESSION: API test failure: _WKDownload.OriginatingWebView
2726         https://bugs.webkit.org/show_bug.cgi?id=166033
2727         <rdar://problem/29758428>
2728
2729         Reviewed by Simon Fraser.
2730
2731         Add an @autoreleasepool around the code that allocates the WKWebView, 
2732         so that it can be destroyed by removing the last reference in _downloadDidStart.
2733
2734         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2735         (TEST):
2736
2737 2016-12-21  Daniel Bates  <dabates@apple.com>
2738
2739         WebKitTestRunner: Add comment to TestRunner::setCanOpenWindows()
2740         https://bugs.webkit.org/show_bug.cgi?id=166356
2741
2742         Add comment in TestRunner::setCanOpenWindows() to elaborate further on its purpose
2743         as a means to allow a test to explicit allow an embedding client to open a new windows
2744         such that the default behavior is for the embedding client to forbid such an action.
2745         The test plugins/get-url-with-blank-target.html assumes this default behavior though
2746         it is currently skipped on WebKit2 because questions were raised in the patch for
2747         <https://bugs.webkit.org/show_bug.cgi?id=43389> about its correctness and usefulness.
2748         We will need to implement TestRunner::setCanOpenWindows() should we decide to unskip
2749         this test.
2750
2751         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2752         (WTR::TestRunner::setCanOpenWindows):
2753
2754 2016-12-20  Simon Fraser  <simon.fraser@apple.com>
2755
2756         REGRESSION: API test failure: WKWebView.EvaluateJavaScriptBlockCrash
2757         https://bugs.webkit.org/show_bug.cgi?id=166031
2758
2759         Reviewed by Tim Horton.
2760         
2761         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
2762         to ensure that the view is destroyed before the callback fires.
2763
2764         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
2765
2766 2016-12-20  Megan Gardner  <megan_gardner@apple.com>
2767
2768         Throw Exception when test doesn't clean up HID Events properly
2769         https://bugs.webkit.org/show_bug.cgi?id=166271
2770
2771         Reviewed by Simon Fraser.
2772
2773         Add in a check when UIScriptController is deleted to make sure that the HID event
2774         callback dictionary is empty. If it is not, and a HID event is hit, this will cause
2775         the program to crash without any good information. Crashes are race-y, and will still
2776         happen with malformed test, but the information will be much more helpful. 
2777
2778         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2779         (WTR::UIScriptController::checkForClean):
2780         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
2781         (UIScriptContext::~UIScriptContext):
2782         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2783         (WTR::UIScriptController::checkForClean):
2784         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2785         * WebKitTestRunner/ios/HIDEventGenerator.h:
2786         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2787         (-[HIDEventGenerator checkHIDCallbacksClear]):
2788         * WebKitTestRunner/ios/TestControllerIOS.mm:
2789         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2790         (WTR::UIScriptController::checkForClean):
2791
2792 2016-12-20  Andy Estes  <aestes@apple.com>
2793
2794         [Cocoa] REGRESSION (r209558): Calling decisionHandler multiple times in webView:decidePolicyForNavigationAction:decisionHandler: leads to a crash
2795         https://bugs.webkit.org/show_bug.cgi?id=165992
2796
2797         Reviewed by Brady Eidson.
2798
2799         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2800         * TestWebKitAPI/Tests/WebKit2Cocoa/DuplicateCompletionHandlerCalls.mm: Added.
2801         (expectException):
2802         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2803         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2804         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2805         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2806         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
2807         (-[DuplicateCompletionHandlerCallsDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
2808         (-[DuplicateCompletionHandlerCallsDelegate _webView:willSubmitFormValues:userObject:submissionHandler:]):
2809         (TEST):
2810         * TestWebKitAPI/Tests/WebKit2Cocoa/duplicate-completion-handler-calls.html: Added.
2811
2812 2016-12-20  Dean Jackson  <dino@apple.com>
2813
2814         Remove INDIE_UI
2815         https://bugs.webkit.org/show_bug.cgi?id=165881
2816         <rdar://problem/29672532>
2817
2818         Reviewed by Simon Fraser.
2819
2820         The Indie UI work has been discontinued.
2821
2822         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2823
2824 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
2825
2826         [ES6] Enable ES6 Modules
2827         https://bugs.webkit.org/show_bug.cgi?id=165849
2828
2829         Reviewed by Geoffrey Garen.
2830
2831         * DumpRenderTree/mac/DumpRenderTree.mm:
2832         (resetWebPreferencesToConsistentValues):
2833         * DumpRenderTree/win/DumpRenderTree.cpp:
2834         (resetWebPreferencesToConsistentValues):
2835         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2836         (WTR::InjectedBundle::beginTesting):
2837         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2838         (WTR::TestRunner::setES6ModulesEnabled): Deleted.
2839         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2840
2841 2016-12-19  Ryan Haddad  <ryanhaddad@apple.com>
2842
2843         Repurpose bots and clean up dashboard.
2844         https://bugs.webkit.org/show_bug.cgi?id=166045
2845
2846         Reviewed by Lucas Forschler.
2847
2848         * BuildSlaveSupport/build.webkit.org-config/config.json:
2849         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2850         (BubbleQueueServer):
2851         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2852         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2853         (WebKitBuildbot):
2854         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2855         (table.queue-grid tr.platform.mac-os-x-yosemite img.logo): Deleted.
2856
2857 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2858
2859         [CMake] TestWebKitAPIBase links to itself
2860         https://bugs.webkit.org/show_bug.cgi?id=165985
2861
2862         Reviewed by Alex Christensen.
2863
2864         Fix CMake warning about a target linking to itself, which makes no sense.
2865
2866         * TestWebKitAPI/CMakeLists.txt:
2867
2868 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2869
2870         [GTK] GtkDoc build should be quieter
2871         https://bugs.webkit.org/show_bug.cgi?id=165994
2872
2873         Reviewed by Carlos Garcia Campos.
2874
2875         Make it not print by default.
2876
2877         * gtk/generate-gtkdoc:
2878         (get_generator_for_config):
2879         (generate_doc):
2880         * gtk/gtkdoc.py:
2881         (GTKDoc._run_command):
2882         (GTKDoc._copy_doc_files_to_output_dir):
2883
2884 2016-12-18  Simon Fraser  <simon.fraser@apple.com>
2885
2886         Expose a way for MiniBrowser to simulate header and footer banners
2887         https://bugs.webkit.org/show_bug.cgi?id=166005
2888
2889         Reviewed by Wenson Hsieh.
2890         
2891         Add a MiniBrowser menu item and setting to toggle adding space for header and footer
2892         banners. This only works in WebKit2.
2893         
2894         We need to reset these on each navigation, since newly created FrameViews
2895         don't re-fetch the header and footer height stored on Page.
2896         
2897         Also fix the signature of webView:didFinishNavigation: to follow API changes,
2898         as well as fixing webViewWebContentProcessDidTerminate:
2899
2900         * MiniBrowser/mac/SettingsController.h:
2901         * MiniBrowser/mac/SettingsController.m:
2902         (-[SettingsController _populateMenu]):
2903         (-[SettingsController validateMenuItem:]):
2904         (-[SettingsController toggleReserveSpaceForBanners:]):
2905         (-[SettingsController isSpaceReservedForBanners]):
2906         * MiniBrowser/mac/WK2BrowserWindowController.m:
2907         (-[WK2BrowserWindowController didChangeSettings]):
2908         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
2909         (-[WK2BrowserWindowController webViewWebContentProcessDidTerminate:]):
2910         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]): Deleted.
2911         (-[WK2BrowserWindowController _webViewWebProcessDidCrash:]): Deleted.
2912
2913 2016-12-17  Simon Fraser  <simon.fraser@apple.com>
2914
2915         Fix iOS test results after r209967.
2916         
2917         Subtracting out the status bar height was erroneously happening for all tests,
2918         not just for flexible viewport tests.
2919         
2920         Fix by plumbing WebViewSizingMode through resizeTo() and setWindowFrame().
2921
2922         * WebKitTestRunner/PlatformWebView.h:
2923         * WebKitTestRunner/TestController.cpp:
2924         (WTR::TestController::resetStateToConsistentValues):
2925         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2926         (WTR::PlatformWebView::resizeTo):
2927         (WTR::PlatformWebView::setWindowFrame):
2928         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2929         (WTR::PlatformWebView::resizeTo):
2930         (WTR::PlatformWebView::setWindowFrame):
2931         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2932         (WTR::PlatformWebView::resizeTo):
2933         (WTR::PlatformWebView::setWindowFrame):
2934         * WebKitTestRunner/ios/TestControllerIOS.mm:
2935         (WTR::TestController::platformConfigureViewForTest):
2936         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2937         (WTR::PlatformWebView::resizeTo):
2938         (WTR::PlatformWebView::setWindowFrame):
2939
2940 2016-12-17  Joonghun Park  <jh718.park@samsung.com>
2941
2942         [EFL] bump EFL version to 1.18.4
2943         https://bugs.webkit.org/show_bug.cgi?id=166004
2944
2945         Reviewed by Gyuyoung Kim.
2946
2947         * efl/jhbuild.modules: Use efl-1.18.4 instead of 1.18.1.
2948
2949 2016-12-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2950
2951         Visual viewports: bottom fixed elements disappear behind the keyboard
2952         https://bugs.webkit.org/show_bug.cgi?id=165983
2953         <rdar://problem/29409852>
2954
2955         Reviewed by Simon Fraser.
2956
2957         Add support for UIScriptController.inputViewBounds, which UI-side scripts may use to fetch the bounding rect of
2958         the keyboard when it is up.
2959
2960         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2961         (WTR::UIScriptController::inputViewBounds):
2962         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2963         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2964         (WTR::UIScriptController::inputViewBounds):
2965         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2966         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2967         (WTR::viewRectForWindowRect):
2968
2969         Previously, we accounted for the status bar height by translating the entire web view down by the height of the
2970         status bar. However, we did not shrink the height of the web view itself, which means that for tests which
2971         involve scrolling past the end of the document, the bottom strip of the web view is out of bounds of the window.
2972
2973         (WTR::PlatformWebView::PlatformWebView):
2974         (WTR::PlatformWebView::setWindowFrame):
2975         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2976         (WTR::UIScriptController::inputViewBounds):
2977
2978 2016-12-16  Ryosuke Niwa  <rniwa@webkit.org>
2979
2980         Deleting a character converted from pinyin after an image causes a Safari crash
2981         https://bugs.webkit.org/show_bug.cgi?id=165839
2982         <rdar://problem/27951933>
2983
2984         Reviewed by Wenson Hsieh.
2985
2986         Add a WebKit API test to call attributedSubstringForProposedRange on a WKWebView
2987         while the proposed range contains an image. This should not cause a WebProcess to crash
2988         or send an invalid message to the UIProcess.
2989
2990         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2991         * TestWebKitAPI/Tests/WebKit2/chinese-character-with-image.html: Added.
2992         * TestWebKitAPI/Tests/WebKit2/mac/AttributedSubstringForProposedRangeWithImage.mm: Added.
2993         (TestWebKitAPI::didFinishLoadForFrame):
2994         (TestWebKitAPI::processDidCrash):
2995         (TestWebKitAPI::invalidMessageFunction):
2996         (TestWebKitAPI::WebKit2.AttributedSubstringForProposedRangeWithImage):
2997
2998 2016-12-16  Wenson Hsieh  <wenson_hsieh@apple.com>
2999
3000         Visual viewports: carets and selection UI are incorrectly positioned when editing fixed elements
3001         https://bugs.webkit.org/show_bug.cgi?id=165767
3002         <rdar://problem/29602382>
3003
3004         Reviewed by Simon Fraser.
3005
3006         Introduces two new UIScriptController methods: doAfterWebPageIsInStableState and textSelectionCaretRect. See
3007         WebKit2 ChangeLog for more details.
3008
3009         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3010         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3011         (WTR::UIScriptController::textSelectionCaretRect):
3012         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3013         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3014         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3015         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3016         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3017         (WTR::UIScriptController::textSelectionCaretRect):
3018         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3019         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3020         (-[TestRunnerWKWebView _setStableStateOverride:]):
3021
3022         Force the WKWebView to update its visible content rects when changing the stable state override.
3023
3024         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3025         (WTR::toNSDictionary):
3026         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3027         (WTR::UIScriptController::selectionRangeViewRects):
3028         (WTR::UIScriptController::textSelectionCaretRect):
3029         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3030         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3031
3032 2016-12-15  Brent Fulgham  <bfulgham@apple.com>
3033
3034         Arguments called in wrong order
3035         https://bugs.webkit.org/show_bug.cgi?id=165923
3036
3037         Reviewed by Simon Fraser.
3038
3039         The 'audioDeviceUIDs' array is being passed to the argument that expects video devices,
3040         and the 'videoDeviceUIDs' array is being passed to the audo device argument. Fix this.
3041
3042         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
3043         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): The
3044         order of arguments to WKUserMediaPermissionRequestAllow are flipped.
3045
3046 2016-12-16  Hunseop Jeong  <hs85.jeong@samsung.com>
3047
3048         [EFL] Disable non-srcdir builds for failing libraries
3049         https://bugs.webkit.org/show_bug.cgi?id=165896
3050
3051         Reviewed by Gyuyoung Kim.
3052
3053         * efl/jhbuild.modules: Set non srcdir builds to no
3054
3055 2016-12-15  Daniel Bates  <dabates@apple.com>
3056
3057         check-style should not complain about code in icu directories
3058         https://bugs.webkit.org/show_bug.cgi?id=53929
3059
3060         Reviewed by Darin Adler.
3061
3062         Skip style checking of imported ICU headers to avoid a deluge of style issues
3063         as they do not conform to the WebKit Code Style guideline. We want to preserve
3064         the formatting of these headers so as to make it straightforward to merge
3065         changes to them, if necessary.
3066
3067         * Scripts/webkitpy/style/checker.py:
3068
3069 2016-12-15  Alexey Proskuryakov  <ap@apple.com>
3070
3071         Move JSC testers from Yosemite to Sierra
3072         https://bugs.webkit.org/show_bug.cgi?id=165925
3073
3074         Reviewed by Lucas Forschler.
3075
3076         * BuildSlaveSupport/build.webkit.org-config/config.json:
3077         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3078         (WebKitBuildbot):
3079
3080 2016-12-15  Megan Gardner  <megan_gardner@apple.com>
3081
3082         Add coordinate space to event streams and streamline tests
3083         https://bugs.webkit.org/show_bug.cgi?id=165119
3084
3085         Reviewed by Simon Fraser.
3086
3087         Update event streams to allow for both content and global coordinate space.
3088         Update example script to more accurately show all the available options.
3089
3090         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3091         * WebKitTestRunner/ios/HIDEventGenerator.h:
3092         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3093         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3094         (WTR::convertCoordinates):
3095         (WTR::UIScriptController::sendEventStream):
3096
3097 2016-12-15  Claudio Saavedra  <csaavedra@igalia.com>
3098
3099         [GTK] Ensure gst* docs are not built with update-webkitgtk-libs
3100         https://bugs.webkit.org/show_bug.cgi?id=165855
3101
3102         Reviewed by Philippe Normand.
3103
3104         GStreamer's autogen.sh enables gtk-doc always so we end up building
3105         docs even if we disable them. Use the configure script instead, since
3106         we build from packages and these include it already.
3107
3108         * gtk/jhbuild.modules: Use shipped configure instead of autogen.sh for
3109         upstream gstreamer packages.
3110
3111 2016-12-15  Alex Christensen  <achristensen@webkit.org>
3112
3113         REGRESSION (r208902) Null pointer dereference in wkIsPublicSuffix
3114         https://bugs.webkit.org/show_bug.cgi?id=165885
3115         <rdar://problem/29476917>
3116
3117         Reviewed by Darin Adler.
3118
3119         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3120         (TestWebKitAPI::utf16String): Deleted.
3121         * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
3122         (TestWebKitAPI::TEST_F):
3123         * TestWebKitAPI/WTFStringUtilities.h:
3124         (utf16String):
3125         Moved from URLParser to share with other tests.
3126
3127 2016-12-14  Ryosuke Niwa  <rniwa@webkit.org>
3128
3129         iOS: An element with tabindex is not focusable unless there is no mouse event handler
3130         https://bugs.webkit.org/show_bug.cgi?id=165843
3131
3132         Reviewed by Antti Koivisto.
3133
3134         Add testRunner.isWebKit2 which is always true in WebKitTestRunner.
3135         Without this, it's really hard to reliably differentiate DumpRenderTree and WebKitTestRunner,
3136         and DumpRenderTree's runUIScript would hit an assertion :(
3137
3138         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3139         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3140         (WTR::TestRunner::isWebKit2):
3141
3142 2016-12-14  Brady Eidson  <beidson@apple.com>
3143
3144         IndexedDB 2.0: Massively speedup IDBIndex.get().
3145         https://bugs.webkit.org/show_bug.cgi?id=165802
3146
3147         Reviewed by Alex Christensen.
3148
3149         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3150         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.html: Added.
3151         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm: Added.
3152         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.blob: Added.
3153         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.sqlite3: Added.
3154
3155 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3156
3157         [GTK][EFL] Update the JHBuild version.
3158         https://bugs.webkit.org/show_bug.cgi?id=165838
3159
3160         Reviewed by Michael Catanzaro.
3161
3162         * jhbuild/jhbuild-wrapper: This new version fixes a bug with the
3163         usage of the JHBUILD_MIRROR feature with git repositories.
3164
3165 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3166
3167         [GTK] Yasm is needed for building the JHBuild after r208940
3168         https://bugs.webkit.org/show_bug.cgi?id=165837
3169
3170         Reviewed by Alejandro G. Castro.
3171
3172         * gtk/install-dependencies: Yasm is needed for building libvpx.
3173
3174 2016-12-14  Youenn Fablet  <youenn@apple.com>
3175
3176         Test infrastructure should allow to filter out text output before doing a comparison with the baseline
3177         https://bugs.webkit.org/show_bug.cgi?id=161310
3178
3179         Reviewed by Ryosuke Niwa.
3180
3181         Adding --dump-jsconsolelog-in-stderr test option for DRT and WTR.
3182         When set, WTR and DRT output JS console log in the stderr and not the test output.
3183         This allows removing potentially flaky information while still being able to read it for investigation.
3184
3185         Updated webkitpy infrastructure to use this test option in case of DumpJSConsoleLogInStdErr modifier.
3186
3187         Changes are covered by updating a fetch test to output console log and set its option to --dump-jsconsolelog-in-stderr in TestExpectations.
3188         This test should have this option when fetch API will start logging resource loader errors.
3189
3190         * DumpRenderTree/DumpRenderTree.h:
3191         (TestCommand::TestCommand): Deleted.
3192         * DumpRenderTree/DumpRenderTreeCommon.cpp:
3193         (parseInputLine):
3194         * DumpRenderTree/TestRunner.h:
3195         (TestRunner::setDumpJSConsoleLogInStdErr):
3196         (TestRunner::dumpJSConsoleLogInStdErr):
3197         * DumpRenderTree/mac/DumpRenderTree.mm:
3198         (runTest):
3199         * DumpRenderTree/mac/UIDelegate.mm:
3200         (-[UIDelegate webView:addMessageToConsole:withSource:]):
3201         * DumpRenderTree/win/DumpRenderTree.cpp:
3202         (runTest):
3203         * DumpRenderTree/win/UIDelegate.cpp:
3204         (UIDelegate::webViewAddMessageToConsole):
3205         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3206         (TestExpectationParser._tokenize_line):
3207         * Scripts/webkitpy/port/driver.py:
3208         (Driver._command_from_driver_input):
3209         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3210         (WTR::InjectedBundle::didReceiveMessageToPage):
3211         (WTR::InjectedBundle::dumpToStdErr):
3212         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3213         (WTR::InjectedBundle::dumpJSConsoleLogInStdErr):
3214         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3215         (WTR::InjectedBundlePage::willAddMessageToConsole):
3216         * WebKitTestRunner/TestController.cpp:
3217         (WTR::parseInputLine):
3218         (WTR::TestController::runTest):
3219         (WTR::TestCommand::TestCommand): Deleted.
3220         * WebKitTestRunner/TestInvocation.cpp:
3221         (WTR::TestInvocation::invoke):
3222         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3223         * WebKitTestRunner/TestInvocation.h:
3224         (WTR::TestInvocation::setDumpJSConsoleLogInStdErr):
3225
3226
3227 2016-12-14  Enrique Ocaña González  <eocanha@igalia.com>
3228
3229         REGRESSION(r207879-207891): [GStreamer] Introduced many layout test failures and crashes, bots exiting early
3230         https://bugs.webkit.org/show_bug.cgi?id=164022
3231
3232         Reviewed by Xabier Rodriguez-Calvar.
3233
3234         * Scripts/webkitperl/FeatureList.pm:
3235           Re-enable MEDIA_SOURCE for the GTK+ port.
3236
3237 2016-12-13  Alex Christensen  <achristensen@webkit.org>
3238
3239         Fix CMake build.
3240
3241         * DumpRenderTree/PlatformMac.cmake:
3242         Define NS_RETURNS_RETAINED as nothing for now.
3243
3244 2016-12-13  Jer Noble  <jer.noble@apple.com>
3245
3246         Fullscreen in WebKit2 does not restore topContentInset upon exiting; leaves top of page not visible
3247         https://bugs.webkit.org/show_bug.cgi?id=165697
3248
3249         Reviewed by Tim Horton.
3250
3251         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
3252         (TestWebKitAPI::TEST):
3253
3254 2016-12-13  Andy Estes  <aestes@apple.com>
3255
3256         [Cocoa] Implement -shouldInsertText: on WKWebProcessPlugInEditingDelegate
3257         https://bugs.webkit.org/show_bug.cgi?id=165785
3258         <rdar://problem/26929398>
3259
3260         Reviewed by Darin Adler.
3261
3262         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
3263         (-[BundleEditingDelegateRemoteObject shouldInsertText:replacingRange:givenAction:]): Added
3264         expectations for the text, range, and action.
3265         (TEST): Set the "EditingDelegateShouldInsertText" bundle parameter to NO so that the plug-in
3266         will return NO in -_webProcessPlugInBrowserContextController:willInsertText:. Added a
3267         plain-text string to the pasteboard, executed a paste action, and verified that the selected
3268         text in the web view did not change.
3269         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm:
3270         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]): Set
3271         _editingDelegateShouldInsertText according to the "EditingDelegateShouldInsertText" bundle
3272         parameter.
3273         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:shouldInsertText:replacingRange:givenAction:]):
3274         Added. Called -shouldInsertText:replacingRange:givenAction: on the remote object proxy
3275         and returned the value of _editingDelegateShouldInsertText.
3276         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Declared
3277         -shouldInsertText:replacingRange:givenAction:.
3278
3279 2016-12-13  Chris Dumez  <cdumez@apple.com>
3280
3281         Unreviewed, rolling out r209544.
3282
3283         Looks like r209489 did not cause the performance regression
3284         after all
3285
3286         Reverted changeset:
3287
3288         "Unreviewed, rolling out r209489."
3289         https://bugs.webkit.org/show_bug.cgi?id=165550
3290         http://trac.webkit.org/changeset/209544
3291
3292 2016-12-12  Sam Weinig  <sam@webkit.org>
3293
3294         [WebIDL] Remove use of Dictionary in ApplePaySession
3295         https://bugs.webkit.org/show_bug.cgi?id=165787
3296
3297         Reviewed by Anders Carlsson.
3298
3299         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3300         (WTR::initializeWebViewConfiguration):
3301         (WTR::TestController::platformCreateWebView):
3302         Enable ApplePay for the tests (where supported).
3303
3304 2016-12-13  Eric Carlson  <eric.carlson@apple.com>
3305
3306         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
3307         https://bugs.webkit.org/show_bug.cgi?id=165251
3308
3309         Reviewed by Youenn Fablet.
3310
3311         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp:
3312         (TestWebKitAPI::TEST): Enable MediaStream, create web view from the page group upon which
3313         the preferences have been set.
3314
3315 2016-12-08  Antti Koivisto  <antti@apple.com>
3316
3317         Enable network cache speculative revalidation in MiniBrowser
3318         https://bugs.webkit.org/show_bug.cgi?id=165616
3319
3320         Reviewed by Darin Adler.
3321
3322         Match Safari. Also add a menu item to disable it.
3323
3324         * MiniBrowser/mac/AppDelegate.m:
3325         (defaultConfiguration):
3326         * MiniBrowser/mac/SettingsController.h:
3327         * MiniBrowser/mac/SettingsController.m:
3328         (-[SettingsController _populateMenu]):
3329         (-[SettingsController validateMenuItem:]):
3330         (-[SettingsController networkCacheSpeculativeRevalidationDisabled]):
3331         (-[SettingsController toggleNetworkCacheSpeculativeRevalidationDisabled:]):
3332
3333 2016-12-12  Alexey Proskuryakov  <ap@apple.com>
3334
3335         ChangeLogs become readonly after resolving a conflict
3336         https://bugs.webkit.org/show_bug.cgi?id=165440
3337         rdar://problem/29491002
3338
3339         Reviewed by Darin Adler.
3340
3341         * Scripts/resolve-ChangeLogs: (resolveChangeLog): Set correct permissions when
3342         moving the file.
3343
3344 2016-12-12  Filip Pizlo  <fpizlo@apple.com>
3345
3346         Re-enable collectContinuously since it doesn't crash anymore
3347
3348         Rubber stamped by Michael Saboff.
3349
3350         * Scripts/run-jsc-stress-tests:
3351
3352 2016-12-11  Konstantin Tokarev  <annulen@yandex.ru>
3353
3354         Unreviewed attempt to fix EFL and Mac/cmake builds after r209665.
3355         https://bugs.webkit.org/show_bug.cgi?id=165686
3356
3357         * DumpRenderTree/CMakeLists.txt: WebKit2 should precede other target
3358         so that right config.h comes first in include path.
3359
3360 2016-12-11  Dave Hyatt  <hyatt@apple.com>
3361
3362         [CSS Parser] Make sure content extensions initialize AtomicString
3363         https://bugs.webkit.org/show_bug.cgi?id=165737
3364
3365         Reviewed by Darin Adler.
3366
3367         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3368         (TestWebKitAPI::makeBackend):
3369
3370 2016-12-08  Dave Hyatt  <hyatt@apple.com>
3371
3372         [CSS Parser] Remove the old CSS Parser
3373         https://bugs.webkit.org/show_bug.cgi?id=165645
3374
3375         Reviewed by Daniel Bates.
3376
3377         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
3378         (TestWebKitAPI::TEST):
3379
3380 2016-12-10  Konstantin Tokarev  <annulen@yandex.ru>
3381
3382         [cmake] Include WTF, JSC, and WebCore headers automatically to targers using them
3383         https://bugs.webkit.org/show_bug.cgi?id=165686
3384
3385         Reviewed by Michael Catanzaro.
3386
3387         This change reduces duplication of include path lists between modules,
3388         and reduces future need for fixes like r209605 (broken build because of
3389         WebCore header suddenly becoming used in WebKit2).
3390
3391         * DumpRenderTree/CMakeLists.txt:
3392         * DumpRenderTree/PlatformMac.cmake:
3393         * ImageDiff/CMakeLists.txt:
3394         * MiniBrowser/gtk/CMakeLists.txt:
3395         * MiniBrowser/mac/CMakeLists.txt:
3396         * MiniBrowser/win/CMakeLists.txt:
3397         * TestWebKitAPI/CMakeLists.txt:
3398         * TestWebKitAPI/PlatformEfl.cmake:
3399         * TestWebKitAPI/PlatformJSCOnly.cmake:
3400         * TestWebKitAPI/PlatformMac.cmake:
3401         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3402         * WebKitTestRunner/CMakeLists.txt:
3403         * WebKitTestRunner/PlatformGTK.cmake:
3404         * WebKitTestRunner/PlatformMac.cmake:
3405
3406 2016-12-09  Csaba Osztrogonác  <ossy@webkit.org>
3407
3408         Unreviewed buildfix after r209630.
3409
3410         * Scripts/build-jsc: Remove building the non-existing testWASM.
3411
3412 2016-12-09  Eric Carlson  <eric.carlson@apple.com>
3413
3414         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
3415         https://bugs.webkit.org/show_bug.cgi?id=165251
3416
3417         Reviewed by Dean Jackson.
3418
3419         Based on a patch by Dr Alex Gouaillard <agouaillard@gmail.com>
3420
3421         * DumpRenderTree/mac/DumpRenderTree.mm:
3422         (resetWebPreferencesToConsistentValues): Enable MediaStream and PeerConnection.
3423
3424         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3425         (WTR::InjectedBundle::beginTesting): Ditto.
3426
3427         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3428         (WTR::TestRunner::setMediaStreamEnabled): New.
3429         (WTR::TestRunner::setPeerConnectionEnabled): New.
3430         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3431
3432 2016-12-09  Brady Eidson  <beidson@apple.com> 
3433  
3434         Re-landing:
3435         Add _WKIconLoadingDelegate SPI. 
3436         https://bugs.webkit.org/show_bug.cgi?id=164894 
3437  
3438         Reviewed by Alex Christensen. 
3439         
3440         Add MiniBrowser support for this new SPI, configurable with a setting. 
3441  
3442         * MiniBrowser/mac/SettingsController.h: 
3443         * MiniBrowser/mac/SettingsController.m: 
3444         (-[SettingsController _populateMenu]): 
3445         (-[SettingsController validateMenuItem:]): 
3446         (-[SettingsController loadsAllSiteIcons]): 
3447         (-[SettingsController toggleLoadsAllSiteIcons:]): 
3448         * MiniBrowser/mac/WK2BrowserWindowController.m: 
3449         (-[WK2BrowserWindowController awakeFromNib]): 
3450         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): 
3451
3452 2016-12-09  Ryan Haddad  <ryanhaddad@apple.com>
3453
3454         Fix the 32-bit build.
3455
3456         Unreviewed build fix.
3457
3458         * MiniBrowser/mac/SettingsController.h:
3459
3460 2016-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3461
3462         Fedora also needs a PHP7 config file alternative
3463         https://bugs.webkit.org/show_bug.cgi?id=165606
3464
3465         Reviewed by Michael Catanzaro.
3466
3467         * Scripts/webkitpy/port/base.py:
3468         (Port._is_fedora_php_version_7): check for the php7 library.
3469         (Port._fedora_php_version): get the appropriate filename for Fedora.
3470         (Port._apache_config_file_name_for_platform):
3471
3472 2016-12-09  Ryan Haddad  <ryanhaddad@apple.com>
3473
3474         Complete the revert of r208865.
3475         https://bugs.webkit.org/show_bug.cgi?id=164894
3476
3477         Unreviewed build fix.
3478
3479         * MiniBrowser/mac/SettingsController.h:
3480         * MiniBrowser/mac/SettingsController.m:
3481         (-[SettingsController _populateMenu]):
3482         (-[SettingsController validateMenuItem:]):
3483         (-[SettingsController loadsAllSiteIcons]): Deleted.
3484         (-[SettingsController toggleLoadsAllSiteIcons:]): Deleted.
3485         * MiniBrowser/mac/WK2BrowserWindowController.m:
3486         (-[WK2BrowserWindowController awakeFromNib]):
3487         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): Deleted.
3488
3489 2016-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3490
3491         [GTK] Force GDK backend to x11 when running with XvfbDriver
3492         https://bugs.webkit.org/show_bug.cgi?id=165612
3493
3494         Reviewed by Michael Catanzaro.
3495
3496         When the developer is running a Wayland session, GDK may get confused
3497         and try to use its Wayland backend (which is higher priority) instead.
3498         This ensures it will use the appropriate backend when running under
3499         Xvfb.
3500
3501         * Scripts/webkitpy/port/gtk.py:
3502         (GtkPort.setup_environ_for_server): when running with XvfbDriver,
3503         force GDK_BACKEND to x11.
3504
3505 2016-12-08  Keith Miller  <keith_miller@apple.com>
3506
3507         Add 64-bit signed LEB decode method
3508         https://bugs.webkit.org/show_bug.cgi?id=165630
3509
3510         Reviewed by Ryosuke Niwa.
3511
3512         Add tests for LEB int64 and uint64 decode since I guess
3513         I forgot to add tests before.
3514
3515         * TestWebKitAPI/Tests/WTF/LEBDecoder.cpp:
3516         (TestWebKitAPI::testUInt32LEBDecode):
3517         (TestWebKitAPI::TEST):
3518         (TestWebKitAPI::testUInt64LEBDecode):
3519         (TestWebKitAPI::testInt32LEBDecode):
3520         (TestWebKitAPI::testInt64LEBDecode):
3521         (TestWebKitAPI::testUnsignedLEBDecode): Deleted.
3522
3523 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
3524
3525         Make it easy to enable --force-collectContinuously
3526         https://bugs.webkit.org/show_bug.cgi?id=165638
3527
3528         Reviewed by Keith Miller.
3529
3530         * Scripts/run-javascriptcore-tests:
3531         (runJSCStressTests):
3532
3533 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
3534
3535         Disable the collectContinuously mode until I investigate failures.
3536
3537         Rubber stamped by Keith Miller.
3538         
3539         I'm seeing collectContinuously crashes on some platforms. Disabling that testing mode
3540         while I investigate.
3541
3542         * Scripts/run-jsc-stress-tests:
3543
3544 2016-12-08  Alex Christensen  <achristensen@webkit.org>
3545
3546         REGRESSION (URL parser): Relative URLs aren’t resolved correctly when the base URL is an applewebdata: URL
3547         https://bugs.webkit.org/show_bug.cgi?id=165621
3548
3549         Reviewed by Dan Bernstein.
3550
3551         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3552         (TestWebKitAPI::TEST_F):
3553
3554 2016-12-06  Filip Pizlo  <fpizlo@apple.com>
3555
3556         Concurrent GC should be stable enough to land enabled
3557         https://bugs.webkit.org/show_bug.cgi?id=164990
3558
3559         Reviewed by Geoffrey Garen.
3560         
3561         Add a new mode that runs GC continuously. Also made eager modes run GC continuously.
3562         
3563         It's clear that this works just fine in release, but I'm still trying to figure out if it's
3564         safe for debug. It might be too slow for debug.
3565
3566         * Scripts/run-jsc-stress-tests:
3567
3568 2016-12-08  Alex Christensen  <achristensen@webkit.org>
3569
3570         Add SPI for sending WebsiteSettings to WebProcess during navigation
3571         https://bugs.webkit.org/show_bug.cgi?id=165517
3572         <rdar://29341068>
3573
3574         Reviewed by Anders Carlsson.
3575
3576         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3577         * TestWebKitAPI/Tests/WebKit2/contentBlockerCheck.html: Added.
3578         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm: Added.
3579         (-[WebsitePoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3580         (-[WebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
3581         (-[WebsitePoliciesDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3582         (TEST):
3583
3584 2016-12-08  Chris Dumez  <cdumez@apple.com>
3585
3586         Unreviewed, rolling out r209489.
3587
3588         Likely caused large regressions on JetStream, Sunspider and
3589         Speedometer
3590
3591         Reverted changeset:
3592
3593         "Add system trace points for JavaScript VM entry/exit"
3594         https://bugs.webkit.org/show_bug.cgi?id=165550
3595         http://trac.webkit.org/changeset/209489
3596
3597 2016-12-08  Keith Miller  <keith_miller@apple.com>
3598
3599         Move LEB tests to API tests
3600         https://bugs.webkit.org/show_bug.cgi?id=165586
3601
3602         Reviewed by Saam Barati.
3603
3604         Move the tests from testWasm.cpp and make them functions
3605         rather than macros.
3606
3607         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3608         * TestWebKitAPI/Tests/WTF/LEBDecoder.cpp: Added.
3609         (TestWebKitAPI::testUnsignedLEBDecode):
3610         (TestWebKitAPI::TEST):
3611         (TestWebKitAPI::testInt32LEBDecode):
3612
3613 2016-12-08  Chris Dumez  <cdumez@apple.com>
3614
3615         Support running the layout tests offline
3616         https://bugs.webkit.org/show_bug.cgi?id=165534
3617
3618         Reviewed by Ryosuke Niwa.
3619
3620         * Scripts/webkitpy/common/system/autoinstall.py:
3621         (AutoInstaller._download_to_stream):
3622         getcode() returns None for file URLs so handle this.
3623
3624         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3625         (WebPlatformTestServer._install_modules):
3626         Deal with local path in the json file and resolve them into file URLs
3627         before using AutoInstall.
3628
3629 2016-12-08  Alex Christensen  <achristensen@webkit.org>
3630
3631         Fix CMake build.
3632
3633         * DumpRenderTree/PlatformMac.cmake:
3634         Remove CheckedMalloc.cpp after r209516.
3635
3636 2016-12-07  Mark Lam  <mark.lam@apple.com>
3637
3638         DumpRenderTree should stop using CheckedMalloc.
3639         https://bugs.webkit.org/show_bug.cgi?id=165563
3640         <rdar://problem/28945820>
3641
3642         Reviewed by Geoffrey Garen.
3643
3644         1. WebKitTestRunner does not have equivalent behavior to that which is implemented
3645            in CheckedMalloc.
3646         2. bmalloc does not honor the settings of CheckedMalloc.
3647
3648         The only time CheckedMalloc comes into play is when DRT uses gmalloc or system
3649         malloc.  As a result, DRT exhibits different behavior from the normal way we run
3650         our tests.  We should obsolete CheckedMalloc and make DRT behave consistently
3651         with WKTR.
3652
3653         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3654         * DumpRenderTree/mac/CheckedMalloc.cpp: Removed.
3655         * DumpRenderTree/mac/CheckedMalloc.h: Removed.
3656         * DumpRenderTree/mac/DumpRenderTree.mm:
3657         (prepareConsistentTestingEnvironment):
3658
3659 2016-12-07  Dean Jackson  <dino@apple.com>
3660
3661         Remove runtime toggle for pointer-lock
3662         https://bugs.webkit.org/show_bug.cgi?id=165577
3663         <rdar://problems/29566996>
3664
3665         Reviewed by Jon Lee.
3666
3667         Remove any runtime calls to check if pointer-lock is enabled. It's
3668         either compiled in or out.
3669
3670         * DumpRenderTree/mac/DumpRenderTree.mm:
3671         (resetWebPreferencesToConsistentValues):
3672         * WebKitTestRunner/TestController.cpp:
3673         (WTR::TestController::resetPreferencesToConsistentValues):
3674
3675 2016-12-07  Eric Carlson  <eric.carlson@apple.com>
3676
3677         [MediaStream][Mac] Revoke sandbox extensions when capture ends
3678         https://bugs.webkit.org/show_bug.cgi?id=165476
3679
3680         Reviewed by Brady Eidson.
3681         
3682         Add a test which loads a page that calls navigator.mediaDevices.enumerateDevices, kills the
3683         page, and loads the same page again to ensure that the WK2 UserMediaPermissionRequestManagerProxy
3684         is reset and recreated when a web page exits and is reloaded.
3685
3686         * TestWebKitAPI/PlatformGTK.cmake:
3687         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3688         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp: Added.
3689         (TestWebKitAPI::checkUserMediaPermissionCallback):
3690         (TestWebKitAPI::TEST):
3691         * TestWebKitAPI/Tests/WebKit2/enumerateMediaDevices.html: Added.
3692
3693 2016-12-07  Jeremy Jones  <jeremyj@apple.com>
3694
3695         One esc to exit fullscreen and pointer lock
3696         https://bugs.webkit.org/show_bug.cgi?id=165416
3697         rdar://problem/29430711
3698
3699         Reviewed by Jer Noble.
3700
3701         Implement WKPageUIClientV8 for pointer lock support.
3702         Add "escape" key support in EventSenderProxy.
3703
3704         * WebKitTestRunner/TestController.cpp:
3705         (WTR::requestPointerLock):
3706         (WTR::TestController::createOtherPage):
3707         (WTR::TestController::createWebViewWithOptions):
3708         * WebKitTestRunner/mac/EventSenderProxy.mm:
3709         (WTR::EventSenderProxy::keyDown):
3710
3711 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
3712
3713         Add system trace points for JavaScript VM entry/exit
3714         https://bugs.webkit.org/show_bug.cgi?id=165550
3715
3716         Reviewed by Tim Horton.
3717
3718         Add trace points for entry/exit into/out of the JS VM.
3719
3720         * Tracing/SystemTracePoints.plist:
3721
3722 2016-12-07  ChangSeok Oh  <changseok@webkit.org>
3723
3724         [GTK] Cannot build GTK+ with CUPS 2.* versions
3725         https://bugs.webkit.org/show_bug.cgi?id=163591
3726
3727         Reviewed by Michael Catanzaro.
3728
3729         GTK+ build has failed on the system which CUPS 2.x is installed in. GTK+ 3.16.4
3730         does not assume to use the recent CUPS thus it fails to detect the CUPS in configuration.
3731         GTK+ upstream fixed this issue but it is not easy to apply the original patch to our
3732         old gtk+ since it requires not only bumping up glib accordingly and its consequence
3733         causes many printing test failures. So, I propose to fix the configuration issue by
3734         applying the change to the configure file directly. By doing this, we don't need to
3735         upgrade glib and worry about any test failures as a consequence of the upgraded glib.
3736
3737         * gtk/jhbuild.modules:
3738         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Added.
3739
3740 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
3741
3742         Fix use of enum in a WK2 C SPI header.
3743         rdar://problem/28725583
3744
3745         Followup to correctly prefix the enum values.
3746
3747         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3748         (WTR::InjectedBundlePage::prepare):
3749
3750 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
3751
3752         Fix use of enum in a WK2 C SPI header.
3753         rdar://problem/28725583
3754
3755         Reviewed by Dan Bernstein.
3756
3757         Use correct enum style for a C SPI header and fix the callers.
3758
3759         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3760         (WTR::InjectedBundlePage::prepare):
3761
3762 2016-12-07  Wenson Hsieh  <wenson_hsieh@apple.com>
3763
3764         Add a new project for recording and playing back editing commands in editable web content
3765         https://bugs.webkit.org/show_bug.cgi?id=165114
3766         <rdar://problem/29408135>
3767
3768         Reviewed by Beth Dakin.
3769
3770         Adds a new Xcode project containing work towards rewinding and playing back editing commands. This work is
3771         wrapped in an Xcode project to take advantage of the XCTest framework. To manually test recording, open the
3772         capture test harness, edit the contenteditable body, and then hit cmd-S. This downloads a .json file which may
3773         then be dragged into the playback test harness.
3774
3775         Also adds 3 new unit tests in EditingHistoryTests/RewindAndPlaybackTests.m. These tests carry out the following
3776         steps:
3777
3778         1. Load the capture harness and perform test-specific editing on the web view.
3779         2. Let originalState be a dump of the DOM at this point in time.
3780         3. Extract the JSON-serialized editing history data and load the playback harness with this data.
3781         4. Rewind all editing to the beginning.
3782         5. Playback all editing to the end.
3783         6. Dump the state of the DOM. This should be identical to originalState.
3784
3785         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj: Added.
3786         * EditingHistory/EditingHistory/Info.plist: Added.
3787         * EditingHistory/EditingHistory/Resources/CaptureHarness.html: Added.
3788         * EditingHistory/EditingHistory/Resources/DOMTestingUtil.js: Added.
3789         * EditingHistory/EditingHistory/Resources/PlaybackHarness.html: Added.
3790         * EditingHistory/EditingHistory/TestRunner.h: Added.
3791         * EditingHistory/EditingHistory/TestRunner.m: Added.
3792         (injectedMessageEventHandlerScript):
3793         (-[TestRunner init]):
3794         (-[TestRunner deleteBackwards:]):
3795         (-[TestRunner typeString:]):
3796         (-[TestRunner bodyElementSubtree]):
3797         (-[TestRunner bodyTextContent]):
3798         (-[TestRunner editingHistoryJSON]):
3799         (-[TestRunner loadPlaybackTestHarnessWithJSON:]):
3800         (-[TestRunner numberOfUpdates]):
3801         (-[TestRunner jumpToUpdateIndex:]):
3802         (-[TestRunner expectEvents:afterPerforming:]):
3803         (-[TestRunner loadCaptureTestHarness]):
3804         (-[TestRunner setTextObfuscationEnabled:]):
3805         (-[TestRunner isDoneWaitingForPendingEvents]):
3806         (-[TestRunner userContentController:didReceiveScriptMessage:]):
3807
3808         The TestRunner provides utilities that a unit test should use to drive the test forward (e.g. loading harnesses)
3809         or inspect the state of the loaded page (e.g. extracting JSON editing history data from the capture harness).
3810
3811         * EditingHistory/EditingHistory/TestUtil.h: Added.
3812         * EditingHistory/EditingHistory/TestUtil.m: Added.
3813         (waitUntilWithTimeout):
3814         (waitUntil):
3815
3816         Provides utilities for running tests. For now, this is just spinning the runloop on a given condition.
3817
3818         * EditingHistory/EditingHistory/WKWebViewAdditions.h: Added.
3819         * EditingHistory/EditingHistory/WKWebViewAdditions.m: Added.
3820         (-[WKWebView loadPageFromBundleNamed:]):
3821         (-[WKWebView typeCharacter:]):
3822         (-[WKWebView keyPressWithCharacters:keyCode:]):
3823         (-[WKWebView stringByEvaluatingJavaScriptFromString:]):
3824
3825         Provides utilities for simulating interaction in a web view.
3826
3827         * EditingHistory/EditingHistory/main.m: Added.
3828         (main):
3829         * EditingHistory/EditingHistoryTests/Info.plist: Added.
3830         * EditingHistory/EditingHistoryTests/RewindAndPlaybackTests.m: Added.
3831         (-[RewindAndPlaybackTests setUp]):
3832         (-[RewindAndPlaybackTests tearDown]):
3833         (-[RewindAndPlaybackTests testTypingSingleLineOfText]):
3834         (-[RewindAndPlaybackTests testTypingMultipleLinesOfText]):
3835         (-[RewindAndPlaybackTests testTypingAndDeletingText]):
3836         (-[RewindAndPlaybackTests rewindAndPlaybackEditingInPlaybackTestHarness]):
3837         (-[RewindAndPlaybackTests originalBodySubtree:isEqualToFinalSubtree:]):
3838
3839 2016-12-07  Philippe Normand  <pnormand@igalia.com>
3840
3841         [GTK][jhbuild] missing dependency on libvpx in gst-plugins-good
3842         https://bugs.webkit.org/show_bug.cgi?id=165525
3843
3844         Reviewed by Carlos Garcia Campos.
3845
3846         * gtk/jhbuild.modules: gst-plugins-good should depend on the
3847         libvpx package built within jhbuild.
3848
3849 2016-12-07  Philippe Normand  <pnormand@igalia.com>
3850
3851         [GTK][jhbuild] gst-plugins-bad fails to build with OpenSSL 1.1.0
3852         https://bugs.webkit.org/show_bug.cgi?id=165520
3853
3854         Reviewed by Carlos Garcia Campos.
3855
3856         * gtk/jhbuild.modules: Added missing dependency on openh264 in
3857         gst-plugins-bad, along with 2 upstream patches fixing the build
3858         against OpenSSL 1.1.0.
3859         * gtk/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Added.
3860         * gtk/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Added.
3861
3862 2016-12-06  Alexey Proskuryakov  <ap@apple.com>
3863
3864         Correct SDKROOT values in xcconfig files
3865         https://bugs.webkit.org/show_bug.cgi?id=165487
3866         rdar://problem/29539209
3867
3868         Reviewed by Dan Bernstein.
3869
3870         Fix suggested by Dan Bernstein.
3871
3872         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
3873         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3874         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3875         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3876         * WebEditingTester/Configurations/DebugRelease.xcconfig:
3877         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3878
3879 2016-12-06  Daniel Bates  <dabates@apple.com>
3880
3881         WebKitTestRunner: Plugins are disabled in new windows
3882         https://bugs.webkit.org/show_bug.cgi?id=165410
3883
3884         Reviewed by Alex Christensen.
3885
3886         Currently WebKitTestRunner only enables plugins in the main window. So, a test that opens
3887         a new window and loads a plugin will fail. We should enable plugins in all windows by
3888         default. Moreover toggling testRunner.setPluginsEnabled() should effect all windows.
3889
3890         Making these changes is a step towards running plugins/open-and-close-window-with-plugin.html
3891         in WebKitTestRunner (we still need to fix <https://bugs.webkit.org/show_bug.cgi?id=46714>) and
3892         will make the behavior of WebKitTestRunner more closely match the behavior DumpRenderTree.
3893
3894         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3895         (WTR::InjectedBundle::beginTesting): Call TestRunner::setPluginsEnabled() instead of
3896         WKBundleSetPluginsEnabled().
3897         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3898         (WTR::TestRunner::setPluginsEnabled): Take a similar approach as TestRunner::setXSSAuditorEnabled()
3899         and make use of WKBundleOverrideBoolPreferenceForTestRunner().
3900
3901 2016-12-05  Dean Jackson  <dino@apple.com>
3902
3903         pointer lock needs to be feature detectable
3904         https://bugs.webkit.org/show_bug.cgi?id=165426
3905         <rdar://problem/29486715>
3906
3907         Reviewed by Antoine Quint.
3908
3909         Expose the comment line to turn on/off pointer lock.
3910
3911         * DumpRenderTree/TestOptions.h:
3912         * DumpRenderTree/TestOptions.mm:
3913         (TestOptions::TestOptions):
3914         * DumpRenderTree/mac/DumpRenderTree.mm:
3915         (resetWebPreferencesToConsistentValues):
3916         * WebKitTestRunner/TestController.cpp:
3917         (WTR::TestController::resetPreferencesToConsistentValues):
3918         (WTR::updateTestOptionsFromTestHeader):
3919         * WebKitTestRunner/TestOptions.h:
3920         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3921         (WTR::PlatformWebView::viewSupportsOptions):
3922         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3923         (WTR::PlatformWebView::viewSupportsOptions):
3924
3925 2016-12-05  Jonathan Bedard  <jbedard@apple.com>
3926
3927         Make it possible to use an existing simulator instance for one-off testing
3928         https://bugs.webkit.org/show_bug.cgi?id=164568
3929         <rdar://problem/29189133>
3930
3931         Reviewed by Daniel Bates.
3932
3933         With this patch, if a simulator is currently running on the machine and
3934         '--dedicated-simulators' is not passed into the application, only one simulator
3935         instance will be used, and this instance will be the existing instance.
3936         If no simulator is running or '--dedicated-simulators' is passed to the script,
3937         previous behavior will be used.
3938
3939         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3940         (parse_args):
3941         * Scripts/webkitpy/port/ios.py:
3942         (IOSSimulatorPort.__init__): Logic for enabling usage of currently running simulator.
3943         (IOSSimulatorPort._create_simulators): Only create simulators when needed, don't reset already running simulators.
3944         (IOSSimulatorPort.setup_test_run): Don't open already running simulators.
3945         (IOSSimulatorPort._quit_ios_simulator): Only quit simulators if we manage them.
3946         (IOSSimulatorPort.clean_up_test_run): Only clean up simulators if we manage them. 
3947         (IOSSimulatorPort._using_dedicated_simulators): True if simulators need to be managed, false if using an existing instance.
3948         (IOSSimulatorPort.device_id_for_worker_number): Access currently running simulator if not managing devices.
3949         * Scripts/webkitpy/xcode/simulator.py:
3950         (Simulator.refresh): Check if xcode_simctl_list returned None instead of a generator.
3951         (Simulator.current_device): Get currently running device.
3952
3953 2016-12-05  Dan Bernstein  <mitz@apple.com>
3954
3955         Disable a crashing test on iOS.
3956
3957         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
3958
3959 2016-12-04  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3960
3961         Fix a build break on EFL since r209303.
3962
3963         Unreviewed build fix.
3964
3965         * Scripts/webkitperl/FeatureList.pm: Disable SS Device Adaptation temporarily.
3966
3967 2016-12-03  Yusuke Suzuki  <utatane.tea@gmail.com>
3968
3969         Refactor SymbolImpl layout
3970         https://bugs.webkit.org/show_bug.cgi?id=165247
3971
3972         Reviewed by Darin Adler.
3973
3974         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3975         (TestWebKitAPI::TEST):
3976
3977 2016-12-03  Dan Bernstein  <mitz@apple.com>
3978
3979         Fixed the build after r209307.
3980
3981         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
3982         (TEST):
3983
3984 2016-12-03  Dan Bernstein  <mitz@apple.com>
3985
3986         [Cocoa] Expose InjectedBundlePageEditorClient via the Objective-C bundle SPI
3987         https://bugs.webkit.org/show_bug.cgi?id=165276
3988         <rdar://problem/29467040>
3989
3990         Reviewed by Darin Adler.
3991
3992         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3993         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm: Added.
3994         (-[BundleEditingDelegateRemoteObject willWriteToPasteboard:]):
3995         (-[BundleEditingDelegateRemoteObject didWriteToPasteboard]):
3996         (TEST):
3997         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm: Added.
3998         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3999         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:willWriteRangeToPasteboard:]):
4000         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:pasteboardDataForRange:]):
4001         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextControllerDidWriteToPasteboard:]):
4002         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Added.
4003
4004 2016-12-02  Andy Estes  <aestes@apple.com>
4005
4006         [Cocoa] Adopt the PRODUCT_BUNDLE_IDENTIFIER build setting
4007         https://bugs.webkit.org/show_bug.cgi?id=164492
4008
4009         Reviewed by Dan Bernstein.
4010
4011         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Changed CFBundleIdentifier's value from
4012         com.apple.testnetscapeplugin to ${PRODUCT_BUNDLE_IDENTIFIER}.
4013         * DumpRenderTree/ios/Info.plist: Changed CFBundleIdentifier's value from
4014         org.webkit.DumpRenderTree to ${PRODUCT_BUNDLE_IDENTIFIER}.
4015         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Set
4016         PRODUCT_BUNDLE_IDENTIFIER to org.webkit.DumpRenderTree.
4017         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Set
4018         PRODUCT_BUNDLE_IDENTIFIER to com.apple.testnetscapeplugin.
4019         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
4020         org.webkit.$(PRODUCT_NAME:rfc1034identifier).
4021         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
4022         com.apple.$(PRODUCT_NAME:rfc1034identifier).
4023         * MiniBrowser/mac/Bundle/Info.plist: Changed CFBundleIdentifier's value from
4024         com.apple.${PRODUCT_NAME:rfc1034identifier} to ${PRODUCT_BUNDLE_IDENTIFIER}.
4025         * MiniBrowser/mac/Info.plist: Changed CFBundleIdentifier's value from
4026         org.webkit.${PRODUCT_NAME} to ${PRODUCT_BUNDLE_IDENTIFIER}.
4027         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig: Set INFOPLIST_FILE to
4028         InjectedBundle-Info.plist and set PRODUCT_BUNDLE_IDENTIFIER to
4029         com.apple.$(PRODUCT_NAME:rfc1034identifier).
4030         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
4031         com.apple.$(PRODUCT_NAME:rfc1034identifier).
4032         * TestWebKitAPI/InjectedBundle-Info.plist: Changed CFBundleIdentifier's value from
4033         com.yourcompany.${PRODUCT_NAME:rfc1034identifier} to ${PRODUCT_BUNDLE_IDENTIFIER}.
4034         * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added a CFBundleIdentifier key with the
4035         value ${PRODUCT_BUNDLE_IDENTIFIER}.
4036         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Set INFOPLIST_FILE to
4037         InjectedBundle-Info.plist and set PRODUCT_BUNDLE_IDENTIFIER to
4038         com.apple.WebKitTestRunner.InjectedBundle.
4039         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Set
4040         PRODUCT_BUNDLE_IDENTIFIER to org.webkit.$(PRODUCT_NAME:rfc1034identifier).
4041         * WebKitTestRunner/InjectedBundle-Info.plist: Changed CFBundleIdentifier's value from
4042         com.apple.WebKitTestRunner.InjectedBundle to ${PRODUCT_BUNDLE_IDENTIFIER}.
4043         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist: Changed
4044         CFBundleIdentifier's value from org.webkit.${PRODUCT_NAME:rfc1034identifier} to
4045         ${PRODUCT_BUNDLE_IDENTIFIER}.
4046
4047 2016-12-02  Brady Eidson  <beidson@apple.com>
4048
4049         Make IndexedDB.WebProcessKillIDBCleanup even more reliable.
4050         https://bugs.webkit.org/show_bug.cgi?id=165330
4051
4052         Reviewed by Alex Christensen.
4053
4054         The test currently nulls out a RetainPtr<WKWebView> to try to destroy the view and kill the process.
4055
4056         Problem is that doesn't reliably destroy the view.
4057         We should explicitly kill the process instead.
4058
4059         Also, by relocating when we kill the process, we can better test behavior of the IndexedDB mechanism.
4060         e.g. We explicitly confirm that a second WebProcess can simultaneously attach to the same unique database as the first.
4061
4062         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
4063         (TEST):
4064
4065 2016-12-02  Commit Queue  <commit-queue@webkit.org>
4066
4067         Unreviewed, rolling out r209136.
4068         https://bugs.webkit.org/show_bug.cgi?id=165337
4069
4070         broke 36 webkitpy tests (Requested by mcatanzaro on #webkit).
4071
4072         Reverted changeset:
4073
4074         "Make it possible to use an existing simulator instance for
4075         one-off testing"
4076         https://bugs.webkit.org/show_bug.cgi?id=164568
4077         http://trac.webkit.org/changeset/209136
4078
4079 2016-12-02  Chris Dumez  <cdumez@apple.com>
4080
4081         [Mac][WK1] Implement new HTML interactive form validation user interface
4082         https://bugs.webkit.org/show_bug.cgi?id=164483
4083
4084         Reviewed by Simon Fraser.
4085
4086         Add support for UIScriptController's contentsOfUserInterfaceItem("validationBubble")
4087         on Mac DRT as this is needed by the HTML form validation layout tests.
4088
4089         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4090         (WTR::UIScriptController::contentsOfUserInterfaceItem):
4091
4092 2016-12-02  Brady Eidson  <beidson@apple.com>
4093
4094         IndexedDB.IndexedDBMultiProcess and IndexedDB.WebProcessKillIDBCleanup sometimes timeout.
4095         https://bugs.webkit.org/show_bug.cgi?id=160780 and https://bugs.webkit.org/show_bug.cgi?id=161001
4096
4097         Reviewed by Alexey Proskuryakov.
4098
4099         These tests had "run-loop races."
4100         
4101         The test spins the runloop waiting for one message.
4102         Two messages might come in from the WebProcess in short succession, and both be delivered to the
4103         UIProcess in the same spin of the runloop.
4104
4105         Therefore by the time the test stops spinning the runloop, notified that a message was received,
4106         the first message has been overwritten by the second.
4107
4108         These tests are fixed by queueing the incoming messages instead of just storing one.
4109
4110         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
4111         (-[IndexedDBMPMessageHandler userContentController:didReceiveScriptMessage:]):
4112         (getNextMessage):
4113         (TEST):
4114
4115         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
4116         (-[IndexedDBWebProcessKillMessageHandler userContentController:didReceiveScriptMessage:]):
4117         (getNextMessage):
4118         (TEST):
4119
4120 2016-12-01  Jiewen Tan  <jiewen_tan@apple.com>
4121
4122         Add a runtime flag for SubtleCrypto
4123         https://bugs.webkit.org/show_bug.cgi?id=164982
4124
4125         Reviewed by Brent Fulgham.
4126
4127         * DumpRenderTree/mac/DumpRenderTree.mm:
4128         (resetWebPreferencesToConsistentValues):
4129         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4130         (WTR::InjectedBundle::beginTesting):
4131         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4132         (WTR::TestRunner::setSubtleCryptoEnabled):
4133         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4134
4135 2016-12-01  Alexey Proskuryakov  <ap@apple.com>
4136
4137         Remove webkitpy dependency on Eliza
4138         https://bugs.webkit.org/show_bug.cgi?id=164979
4139
4140         Reviewed by Daniel Bates.
4141
4142         This module is not on pypi, so installing it is a challenge. The jokes feel pretty old too!
4143
4144         * Scripts/webkitpy/thirdparty/__init__.py:
4145         * Scripts/webkitpy/thirdparty/__init___unittest.py: Changed mock import hook to
4146         test buildbot instead of eliza.
4147         * Scripts/webkitpy/tool/bot/ircbot.py:
4148         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
4149
4150 2016-12-01  Beth Dakin  <bdakin@apple.com>
4151
4152         Force clicking tests fail on some machines
4153         https://bugs.webkit.org/show_bug.cgi?id=165263
4154
4155         Reviewed by Tim Horton.
4156
4157         Initialize com.apple.trackpad.forceClick to 1 so that we don’t have to depend on 
4158         the user account having this feature enabled. 
4159         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
4160         (WTR::InjectedBundle::platformInitialize):
4161         * WebKitTestRunner/mac/main.mm:
4162         (setDefaultsToConsistentValuesForTesting):
4163
4164 2016-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
4165
4166         Introduce StringImpl::StaticStringImpl with constexpr constructor
4167         https://bugs.webkit.org/show_bug.cgi?id=165093
4168
4169         Reviewed by Darin Adler.
4170
4171         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
4172         (TestWebKitAPI::TEST):
4173
4174 2016-11-30  Antoine Quint  <graouts@apple.com>
4175
4176         [Modern Media Controls] Add an HTML comment flag to turn the feature on
4177         https://bugs.webkit.org/show_bug.cgi?id=165226
4178
4179         Reviewed by Dean Jackson.
4180
4181         Add a new flag to turn Modern Media Controls on in the test runners.
4182
4183         * DumpRenderTree/TestOptions.h:
4184         * DumpRenderTree/TestOptions.mm:
4185         (TestOptions::TestOptions):
4186         * DumpRenderTree/mac/DumpRenderTree.mm:
4187         (resetWebPreferencesToConsistentValues):
4188         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4189         (WTR::InjectedBundle::beginTesting):
4190         * WebKitTestRunner/TestController.cpp:
4191         (WTR::TestController::resetPreferencesToConsistentValues):
4192         (WTR::updateTestOptionsFromTestHeader):
4193         * WebKitTestRunner/TestOptions.h:
4194         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4195         (WTR::PlatformWebView::viewSupportsOptions):
4196         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4197         (WTR::PlatformWebView::viewSupportsOptions):
4198
4199 2016-11-30  Said Abou-Hallawa  <sabouhallawa@apple.com>
4200
4201         Add separate settings and preferences to enable/disable async decoding for large images and animated images
4202         https://bugs.webkit.org/show_bug.cgi?id=165177
4203
4204         Reviewed by Simon Fraser.
4205         
4206         Pref and a menu item to toggle async image decoding settings for WebKits 1 and 2.
4207
4208         * MiniBrowser/mac/SettingsController.h:
4209         * MiniBrowser/mac/SettingsController.m:
4210         (-[SettingsController _populateMenu]):
4211         (-[SettingsController validateMenuItem:]):
4212         (-[SettingsController toggleLargeImageAsyncDecodingEnabled:]):
4213         (-[SettingsController largeImageAsyncDecodingEnabled]):
4214         (-[SettingsController toggleAnimatedImageAsyncDecodingEnabled:]):
4215         (-[SettingsController animatedImageAsyncDecodingEnabled]):
4216         (-[SettingsController toggleAsyncImageDecodingEnabled:]): Deleted.
4217         (-[SettingsController asyncImageDecodingEnabled]): Deleted.
4218         * MiniBrowser/mac/WK1BrowserWindowController.m:
4219         (-[WK1BrowserWindowController didChangeSettings]):
4220         * MiniBrowser/mac/WK2BrowserWindowController.m:
4221         (-[WK2BrowserWindowController didChangeSettings]):
4222
4223 2016-11-30  Jonathan Bedard  <jbedard@apple.com>
4224
4225         Make it possible to use an existing simulator instance for one-off testing
4226         https://bugs.webkit.org/show_bug.cgi?id=164568
4227         <rdar://problem/29189133>
4228
4229         Reviewed by Daniel Bates.
4230
4231         With this patch, if a simulator is currently running on the machine and
4232         '--dedicated-simulators' is not passed into the application, only one simulator
4233         instance will be used, and this instance will be the existing instance.
4234         If no simulator is running or '--dedicated-simulators' is passed to the script,
4235         previous behavior will be used.
4236
4237         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4238         (parse_args):
4239         * Scripts/webkitpy/port/ios.py:
4240         (IOSSimulatorPort.__init__): Logic for enabling usage of currently running simulator.
4241         (IOSSimulatorPort._create_simulators): Only create simulators when needed, don't reset already running simulators.
4242         (IOSSimulatorPort.setup_test_run): Don't open already running simulators.
4243         (IOSSimulatorPort._quit_ios_simulator): Only quit simulators if we manage them.
4244         (IOSSimulatorPort.clean_up_test_run): Only clean up simulators if we manage them. 
4245         (IOSSimulatorPort._using_dedicated_simulators): True if simulators need to be managed, false if using an existing instance.
4246         (IOSSimulatorPort.device_id_for_worker_number): Access currently running simulator if not managing devices.
4247         * Scripts/webkitpy/xcode/simulator.py:
4248         (Simulator.current_device): Get currently running device.
4249
4250 2016-11-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4251
4252         [Linux] run-benchmark should be able to execute the benchmarks with more browsers.
4253         https://bugs.webkit.org/show_bug.cgi?id=164792
4254
4255         Reviewed by Michael Catanzaro.
4256
4257         This removes the GTKBrowserDriver (and the platform 'gtk') from the run-benchmark script,
4258         and adds a new LinuxBrowserDriver with a platform 'linux'.
4259
4260         It add also drivers for Chrome (Chromium), Firefox, Epiphany and MiniBrowser-GTK (previously MiniBrowser).
4261
4262         The detection of the platform is now done automatically, so it is not longer needed to pass a "--platform" parameter.
4263
4264         The tracking of the browser process is now more robust, we track the pid of the browser process and we only try to
4265         kill the ones that were executed by this script, instead of doing a 'killall $browser' (like before).
4266         We also check for browser process childs and we kill them if they are still alive after the main browser process has been killed.
4267         This depends on psutil, so this will only be done if psutil is installed.
4268
4269         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4270         (RunBenchmarkTests.start): The platform is now autodetected and the MiniBrowser driver is renamed to MiniBrowser-GTK.
4271         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
4272         (BenchmarkRunner._run_benchmark): Fix a bug that caused close_browsers to be called twice. Its already called inside BenchmarkRunner._run_one_test.
4273         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py: Added.
4274         (LinuxBrowserDriver): Implement base class that has all the needed functionality for driving the browsers.
4275         (LinuxBrowserDriver.__init__):
4276         (LinuxBrowserDriver.prepare_env):
4277         (LinuxBrowserDriver.restore_env):
4278         (LinuxBrowserDriver.close_browsers): Made the dependency on psutil optional (because it was listed as such on the README file <Tools/Scripts/webkitpy/benchmark_runner/README.md>)
4279         (LinuxBrowserDriver.launch_url):
4280         (LinuxBrowserDriver._get_first_executable_path_from_list):
4281         (LinuxBrowserDriver._screen_size):
4282         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py: Copied from Tools/Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py.
4283         (LinuxChromeDriver):
4284         (LinuxChromeDriver.launch_url):
4285         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py: Renamed from Tools/Scripts/webkitpy/benchmark_runner/browser_driver/gtk_browser_driver.py.
4286         (EpiphanyBrowserDriver):
4287         (EpiphanyBrowserDriver.launch_url):
4288         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py: Copied from Tools/Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py.
4289         (LinuxFirefoxDriver):
4290         (LinuxFirefoxDriver.launch_url):
4291         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py: Renamed from Tools/Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py.
4292         (GTKMiniBrowserDriver):
4293         (GTKMiniBrowserDriver.launch_url):
4294         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
4295         (SimpleHTTPServerDriver):
4296         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
4297         (getplatform):
4298         (getdefaultbrowser):
4299         (parse_args):
4300         * Scripts/webkitpy/benchmark_runner/utils.py:
4301         (load_subclasses): The loading of subclasses was still (even after r196979) sensitive to the order in which the modules are loaded.
4302         We have to ensure that the files containing subclasses of the base_class_file are loaded after the base_class_file,
4303         we can do that by matching against the base_class_file pattern when the list is created.