Revert another erroneous change.
[WebKit-https.git] / Tools / ChangeLog
1 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Revert another erroneous change.
4
5         * Scripts/webkitpy/tool/commands/newcommitbot.py:
6         (NewCommitBot.next_work_item):
7
8 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
9
10         Revert an erroneous change.
11
12         * Scripts/webkitpy/tool/commands/sheriffbot.py:
13         (SheriffBot):
14
15 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
16
17         Some build fixes for WKR and webkitbot.
18
19         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
20         (IRCBotTest.test_help):
21         * Scripts/webkitpy/tool/commands/newcommitbot.py:
22         (Agent):
23         (Agent.__init__):
24         (Agent.name):
25         (NewCommitBot):
26         (NewCommitBot.begin_work_queue):
27         (NewCommitBot.next_work_item):
28         * Scripts/webkitpy/tool/commands/sheriffbot.py:
29         (SheriffBot):
30
31 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
32
33         Teach webkitbot and WKR how to respond to yt?
34         https://bugs.webkit.org/show_bug.cgi?id=116775
35
36         Reviewed by Andreas Kling.
37
38         * Scripts/webkitpy/tool/bot/irc_command.py:
39         (Hi): Fixed the usage string.
40         (Hi.execute): Made it more generic so that it works in WKR.
41         (YouThere): Added.
42         (YouThere.execute): Added.
43         * Scripts/webkitpy/tool/commands/newcommitbot.py:
44
45 2013-05-25  Simon Fraser  <simon.fraser@apple.com>
46
47         Try to fix the EFL build.
48         
49         * DumpRenderTree/efl/TestRunnerEfl.cpp:
50         (TestRunner::setPageVisibility):
51
52 2013-05-25  Simon Fraser  <simon.fraser@apple.com>
53
54         Unprefix Page Visibility API
55         https://bugs.webkit.org/show_bug.cgi?id=102340
56
57         Reviewed by Tim Horton.
58         
59         Rename "preview" state to "unloaded" state, and adjust the tests
60         to test for it.
61
62         * DumpRenderTree/mac/TestRunnerMac.mm:
63         (TestRunner::setPageVisibility):
64         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp:
65         (TestWebKitAPI::setPageVisibilityStateWithEvalContinuation):
66         (TestWebKitAPI::didRunStep2StateChangeHiddenToPrerender):
67         (TestWebKitAPI::didRunStep3StateChangePrerenderToUnloaded):
68         (TestWebKitAPI::didRunStep4InStateUnloaded):
69         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.html:
70         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
71         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
72         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
73         (WTR::TestRunner::setPageVisibility):
74
75 2013-05-24  Brent Fulgham  <bfulgham@apple.com>
76
77         Unreviewed build fix. Don't use new NRWT logic needed
78         by Windows yet. Activate (and fix test) when we cut over.
79
80         * Scripts/webkitpy/port/driver.py:
81         (Driver._setup_environ_for_driver):
82         (Driver._start):
83
84 2013-05-24  Brent Fulgham  <bfulgham@apple.com>
85
86         [Windows] Expose database storage and cache locations via preferences.
87         https://bugs.webkit.org/show_bug.cgi?id=116729
88
89         Reviewed by Tim Horton.
90
91         Update DumpRenderTree to use CFPreferences to control where WebKit
92         stores its local databases, URL caches, etc.
93
94         * DumpRenderTree/win/DumpRenderTree.cpp:
95         (libraryPathForDumpRenderTree): Added.
96         (dllLauncherEntryPoint): Set up DRT-specific cache locations.
97         * Scripts/webkitpy/port/base.py:
98         (Port._driver_tempdir): Added (to allow port-specific overload).
99         (Port._driver_tempdir_for_environment): Ditto
100         * Scripts/webkitpy/port/driver.py:
101         (Driver._setup_environ_for_driver): Use new overload to set
102         environment variable.
103         (Driver._start): Use new overload for temp directory location.
104         * Scripts/webkitpy/port/win.py:
105         (WinPort._driver_tempdir_for_environment): New overload to supply
106         Windows path to DumpRenderTree environment (while still using
107         cygwin paths for internal operations.
108
109 2013-05-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
110
111         Remove custom code for webkitAudioContext global constructor getter
112         https://bugs.webkit.org/show_bug.cgi?id=116530
113
114         Reviewed by Geoffrey Garen.
115
116         Update EFL's DumpRenderTree to use DumpRenderTreeSupport to toggle
117         WebAudio feature instead of public ewk_view API since that API was
118         removed.
119
120         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
121         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
122         * DumpRenderTree/efl/TestRunnerEfl.cpp:
123         (TestRunner::overridePreference):
124
125 2013-05-24  Bem Jones-Bey  <bjonesbe@adobe.com>
126
127         Make team.html have each contributor's area of expertise
128         https://bugs.webkit.org/show_bug.cgi?id=116737
129
130         Reviewed by Benjamin Poulain.
131
132         * Scripts/webkitpy/common/config/contributors.json:
133         Add expertise to each contributor, taken from http://trac.webkit.org/wiki/WebKit%20Team
134         
135         Changed formatting of the file because the lines are getting way to
136         long, and I generated this, so it's easier if the formatting of the
137         file is regular.
138
139 2013-05-24  Simon Pena  <simon.pena@samsung.com>
140
141         Update WTF::Vector pretty printers
142         https://bugs.webkit.org/show_bug.cgi?id=116719
143
144         Reviewed by Anders Carlsson.
145
146         After r148891, WTF::Vector pretty printers were left outdated, as
147         the WTF::Vector was made to extend a VectorBuffer, instead of keeping
148         one as a member. This patch updates the pretty printers so they work
149         again. 
150
151         * gdb/webkit.py:
152         (WTFVectorPrinter.children):
153         (WTFVectorPrinter.to_string):
154
155 2013-05-24  Steve Falkenburg  <sfalken@apple.com>
156
157         Update prepareConsistentTestingEnvironment to use a non-deprecated API.
158         https://bugs.webkit.org/show_bug.cgi?id=116710
159
160         Reviewed by Mark Rowe.
161
162         * DumpRenderTree/mac/DumpRenderTree.mm:
163         (prepareConsistentTestingEnvironment): Use beginActivityWithOptions instead of beginSuspensionOfSystemBehaviors.
164
165 2013-05-23  Lauro Neto  <lauro.neto@openbossa.org>
166
167         Add missing dependencies to deps script.
168
169         [GTK] Missing packages in install-dependencies script.
170         https://bugs.webkit.org/show_bug.cgi?id=116632
171
172         Reviewed by Martin Robinson.
173
174         * gtk/install-dependencies:
175
176 2013-05-23  Brent Fulgham  <bfulgham@apple.com>
177
178         [Windows] Unreviewed change for NRWT support.
179
180         * Scripts/webkitpy/port/win.py:
181         (WinPort.default_child_processes): Added a default implementation
182         that limits NRWT to a single instance.
183
184 2013-05-23  Brent Fulgham  <bfulgham@apple.com>
185
186         Remove meaningless "test_uses_apache" from Python test cases.
187         https://bugs.webkit.org/show_bug.cgi?id=38756
188
189         Reviewed by Ryosuke Niwa.
190
191         * Scripts/webkitpy/port/port_testcase.py:
192         (PortTestCase.test_driver_cmd_line): Remove the meaningless
193         "test_uses_apache" test case from the Python test infrastructure.
194         It was hard-coded to true, even though not all ports use
195         Apache.
196
197 2013-05-23  Brent Fulgham  <bfulgham@webkit.org>
198
199         [Windows] Update new-run-webkit-tests for Windows port.
200         https://bugs.webkit.org/show_bug.cgi?id=38756
201
202         Reviewed by Ryosuke Niwa.
203
204         * Scripts/new-run-webkit-httpd:
205         (run): Switch from 'chromium' to 'win'
206         * Scripts/webkitpy/port/win.py:
207         (WinPort): Add support methods for lighttpd server.
208         (WinPort._uses_apache):
209         (WinPort._path_to_lighttpd):
210         (WinPort._path_to_lighttpd_modules):
211         (WinPort._path_to_lighttpd_php):
212
213 2013-05-23  Patrick Gansterer  <paroga@webkit.org>
214
215         Make default bug links in buildbot clickable
216         https://bugs.webkit.org/show_bug.cgi?id=116673
217
218         Reviewed by Ryosuke Niwa.
219
220         Use changecommentlink of html.WebStatus to make the links clickable.
221
222         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
223
224 2013-05-22  Ryosuke Niwa  <rniwa@webkit.org>
225
226         REGRESSION(r150491): WebKit2.DOMWindowExtensionNoCache fails
227         https://bugs.webkit.org/show_bug.cgi?id=116595
228
229         Temporarily skip this test.
230
231         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
232         (TestWebKitAPI::TEST):
233
234 2013-05-22  Alex Christensen  <achristensen@apple.com>
235
236         Unreviewed.  Added myself to contributors.json.
237
238         * Scripts/webkitpy/common/config/contributors.json:
239         Added myself.
240
241 2013-05-22  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
242
243         [EFL][WK2] Add sub menus to MiniBrowser
244         https://bugs.webkit.org/show_bug.cgi?id=114728
245
246         Reviewed by Christophe Dumez.
247
248         Elementary Ctxpopup widget API does not provide support for submenu item.
249         To implement ewk submenus in Minibrowser, Ctxpopup has to be replaced with
250         Elementary Menu widget.
251
252         * MiniBrowser/efl/main.c:
253         (_Browser_Window):
254         (on_window_resize):
255         (window_free):
256         (context_menu_item_selected_cb):
257         (context_menu_populate):
258         (on_context_menu_show):
259         (on_context_menu_hide):
260         (window_create):
261
262 2013-05-22  Andrzej Badowski  <a.badowski@samsung.com>
263
264         [EFL] Add command line option to MiniBrowser to set cookies policy.
265         https://bugs.webkit.org/show_bug.cgi?id=115028
266
267         Reviewed by Christophe Dumez.
268
269         Add command line option to MiniBrowser EFL to set cookies policy:
270         -p parameter with value from (always, never, no-third-party) respectively (EWK_COOKIE_ACCEPT_POLICY_ALWAYS,
271         EWK_COOKIE_ACCEPT_POLICY_NEVER, EWK_COOKIE_ACCEPT_POLICY_NO_THIRD_PARTY).
272
273         * MiniBrowser/efl/main.c:
274         (elm_main):
275
276 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
277
278         REGRESSION(r150369): WebKit2WillLoadTest tests are failing
279         https://bugs.webkit.org/show_bug.cgi?id=116585
280
281         Reviewed by Alexey Proskuryakov.
282
283         willLoadURLRequest and willLoadDataRequest require the API version 6.
284
285         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
286
287 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
288
289         REGRESSION(r150393): editing/inserting/typing-at-end-of-line.html fails
290         https://bugs.webkit.org/show_bug.cgi?id=116516
291
292         Reviewed by Alexey Proskuryakov.
293
294         Reset states in DumpRenderTree. The fix for WebKitTestRunner should be implemented in the bug 116577.
295
296         * DumpRenderTree/mac/DumpRenderTree.mm:
297         (createWebViewAndOffscreenWindow): Match the ordering.
298         (resetWebViewToConsistentStateBeforeTesting): Reset text replacement states.
299
300 2013-05-21  Alexey Proskuryakov  <ap@apple.com>
301
302         <rdar://problem/13929704> [WK2] WebKitTestRunner always crashes on exit
303         https://bugs.webkit.org/show_bug.cgi?id=116568
304
305         Reviewed by Anders Carlsson.
306
307         * WebKitTestRunner/WebNotificationProvider.cpp:
308         (WTR::WebNotificationProvider::~WebNotificationProvider):
309         * WebKitTestRunner/WebNotificationProvider.h:
310         When the provider is destroyed, it should no longer be registered with the manager.
311
312         * WebKitTestRunner/GeolocationProviderMock.cpp:
313         (WTR::GeolocationProviderMock::~GeolocationProviderMock):
314         * WebKitTestRunner/GeolocationProviderMock.h:
315         I wasn't seeing a crash here, but this code has the same issue as notification
316         provider, so applying the same fix.
317
318         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
319         Close icon database. I started seeing ASSERT(!isOpen()) in WebCore IconDatabase
320         destructor having fixed the above.
321
322 2013-05-21  Commit Queue  <commit-queue@webkit.org>
323
324         Unreviewed, rolling out r150386 and r150397.
325         http://trac.webkit.org/changeset/150386
326         http://trac.webkit.org/changeset/150397
327         https://bugs.webkit.org/show_bug.cgi?id=116572
328
329         Broke a test; Alex is going to try again later. (Requested by
330         thorton on #webkit).
331
332         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
333         (WTR::pathSuitableForTestResult):
334         (WTR::dumpRequestDescriptionSuitableForTestResult):
335         (WTR::dumpResponseDescriptionSuitableForTestResult):
336         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
337         (WTR::InjectedBundlePage::didInitiateLoadForResource):
338         (WTR::InjectedBundlePage::willSendRequestForFrame):
339         (WTR::InjectedBundlePage::didReceiveResponseForResource):
340         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
341         (InjectedBundlePage):
342
343 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
344
345         Fix a python unittest after r149419. We need to support Python 2.6 on Windows.
346
347         * Scripts/webkitpy/tool/commands/suggestnominations.py:
348         (AbstractCommitLogCommand._recent_commit_messages):
349
350 2013-05-21  Martin Robinson  <mrobinson@igalia.com>
351
352         [GTK] [CMake] Add support for building WebKit2
353         https://bugs.webkit.org/show_bug.cgi?id=116372
354
355         Reviewed by Gustavo Noronha Silva.
356
357         * CMakeLists.txt: Do not build WebKitTestRunner yet for WebKitGTK+.
358         * MiniBrowser/gtk/CMakeLists.txt: Added.
359
360 2013-05-21  Jessie Berlin  <jberlin@apple.com>
361
362         Revert r149635, it was too optimistic.
363
364         Rubber-stamped by Andreas Kling.
365
366         We are not at the point where we can always use more descriptive macros instead of PLATFORM()
367         #ifdefs in WebCore code outside of WebCore/platform.
368
369         * Scripts/webkitpy/style/checkers/cpp.py:
370         (check_invalid_increment):
371         (process_line):
372         (CppChecker):
373         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
374         (CppStyleTest.test_plain_integral_bitfields):
375
376 2013-05-21  Jer Noble  <jer.noble@apple.com>
377
378         Unreviewed; fix lldb synthetic representation of WTF::Vector after r148891.
379
380         * lldb/lldb_webkit.py:
381         (WTFVectorProvider.num_children):
382         (WTFVectorProvider.get_child_index):
383         (WTFVectorProvider.get_child_at_index):
384         (WTFVectorProvider.update):
385
386 2013-05-21  Jessie Berlin  <jberlin@apple.com>
387
388         Expose a way to know when forms are added to a page or when form controls are added to a form
389         in the injected bundle
390         https://bugs.webkit.org/show_bug.cgi?id=116334
391
392         Reviewed by Alexey Proskuryakov.
393
394         Add tests for the new callbacks.
395
396         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
397         Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
398
399         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
400         (TestWebKitAPI::nullJavaScriptCallback):
401         A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
402         being passed in for the callback.
403         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
404         After receiving the message that didAssociateFormControls callback was invoked from adding
405         the form in the onload handler, tell the page to add a password field to the form, which
406         should also invoke didAssociateFormControls callback.
407         (TestWebKitAPI::setInjectedBundleClient):
408         Register to receive messages.
409         (TestWebKitAPI::TEST):
410         Load associate-form-controls.html and wait until the didAssociateFormControls callback has
411         been invoked for both adding the form and for adding a password field to the form.
412
413         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
414         (TestWebKitAPI::shouldNotifyOnFormChanges):
415         Return true so the didAssociateFormControls callback is invoked.
416         (TestWebKitAPI::didAssociateFormControls):
417         Tell the UI process.
418         (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
419         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
420         Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
421
422         * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
423         Add a form in response to the onload event. Add a button that will add the password field
424         for manual testing.
425
426 2013-05-21  Krzysztof Czech  <k.czech@samsung.com>
427
428         [GTK][WK2] accessibility/label-for-control-hittest.html is failing
429         https://bugs.webkit.org/show_bug.cgi?id=106341
430
431         Reviewed by Martin Robinson.
432
433         Adds support for retrieving accessibility element at exact point.
434
435         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
436         (WTR::AccessibilityUIElement::elementAtPoint):
437
438 2013-05-21  Krzysztof Czech  <k.czech@samsung.com>
439
440         [ATK] [WebKit2] AccessibilityUIElement often leaks its AtkObject
441         https://bugs.webkit.org/show_bug.cgi?id=112913
442
443         Reviewed by Martin Robinson.
444
445         AccessibilityUIElement is often created by passing new reference to AtkObject (transfer full).
446         AccessibilityUIElement::~AccessibilityUIElement does not decrement the reference of the element,
447         so the leak appears.
448
449         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
450         (WTR):
451         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
452         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
453         (WTR::AccessibilityController::rootElement):
454         (WTR):
455         (WTR::AccessibilityController::focusedElement):
456         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
457         (WTR::checkElementState):
458         (WTR::indexRangeInTable):
459         (WTR::alterCurrentValue):
460         (WTR::AccessibilityUIElement::getChildren):
461         (WTR::AccessibilityUIElement::getChildrenWithRange):
462         (WTR::AccessibilityUIElement::childrenCount):
463         (WTR::AccessibilityUIElement::indexOfChild):
464         (WTR::AccessibilityUIElement::titleUIElement):
465         (WTR::AccessibilityUIElement::parentElement):
466         (WTR::AccessibilityUIElement::allAttributes):
467         (WTR::AccessibilityUIElement::role):
468         (WTR::AccessibilityUIElement::title):
469         (WTR::AccessibilityUIElement::description):
470         (WTR::AccessibilityUIElement::orientation):
471         (WTR::AccessibilityUIElement::stringValue):
472         (WTR::AccessibilityUIElement::language):
473         (WTR::AccessibilityUIElement::x):
474         (WTR::AccessibilityUIElement::y):
475         (WTR::AccessibilityUIElement::width):
476         (WTR::AccessibilityUIElement::height):
477         (WTR::AccessibilityUIElement::intValue):
478         (WTR::AccessibilityUIElement::minValue):
479         (WTR::AccessibilityUIElement::maxValue):
480         (WTR::AccessibilityUIElement::isEnabled):
481         (WTR::AccessibilityUIElement::isFocused):
482         (WTR::AccessibilityUIElement::isSelected):
483         (WTR::AccessibilityUIElement::isExpanded):
484         (WTR::AccessibilityUIElement::isChecked):
485         (WTR::AccessibilityUIElement::rowCount):
486         (WTR::AccessibilityUIElement::columnCount):
487         (WTR::AccessibilityUIElement::rowIndexRange):
488         (WTR::AccessibilityUIElement::columnIndexRange):
489         (WTR::AccessibilityUIElement::cellForColumnAndRow):
490         (WTR::AccessibilityUIElement::increment):
491         (WTR::AccessibilityUIElement::decrement):
492         (WTR::AccessibilityUIElement::press):
493         (WTR::AccessibilityUIElement::documentEncoding):
494         (WTR::AccessibilityUIElement::documentURI):
495         (WTR::AccessibilityUIElement::isFocusable):
496         (WTR::AccessibilityUIElement::isSelectable):
497         (WTR::AccessibilityUIElement::isMultiSelectable):
498         (WTR::AccessibilityUIElement::isVisible):
499
500 2013-05-20  Lucas Forschler  <lforschler@apple.com>
501
502     Rollout 150398.
503     
504 2013-05-20  Zan Dobersek  <zdobersek@igalia.com>
505
506         [GTK] Fix concatenations of string literals that are not C++11-compliant
507         https://bugs.webkit.org/show_bug.cgi?id=116449
508
509         Reviewed by Martin Robinson.
510
511         Fix the problematic concatenations of string literals so they are compilable under the C++11 standard. This
512         is simply a matter of separating the string and the string literal that are being concatenated with a space.
513
514         * ImageDiff/gtk/ImageDiff.cpp:
515         (printImage):
516
517 2013-05-20  Zan Dobersek  <zdobersek@igalia.com>
518
519         [GTK] Pass GTEST_HAS_RTTI=0 cppflag to TestWebKitAPI programs at compilation-time
520         https://bugs.webkit.org/show_bug.cgi?id=116450
521
522         Reviewed by Martin Robinson.
523
524         The -fno-rtti flag is used when compiling C++ source code throughout the project. The TestWebKitAPI
525         programs fail to compile because of this when using the C++11 standard as the GTest headers assume by
526         default that the RTTI support is available. This can be turned off by passing GTEST_HAS_RTTI=0 to the
527         TestWebKitAPI programs when compiling them.
528
529         * TestWebKitAPI/GNUmakefile.am:
530
531 2013-05-20  Ryosuke Niwa  <rniwa@webkit.org>
532
533         Remove DriverProxy._running_drivers from webkitpy.layout_tests.port
534         https://bugs.webkit.org/show_bug.cgi?id=116492
535
536         Reviewed by Dirk Pranke.
537
538         Merge https://chromium.googlesource.com/chromium/blink/+/1af2f0be5a1746784ff114952f29f7b8fa9895f3.
539
540         The DriverProxy class had the concept of keeping a pool of started DRTs around (indexed by command line)
541         so that we didn't necessarily need to restart DRT when the command line for a test changed (e.g., when
542         starting to run tests in a virtual suite). However, the pool was per-worker (so not shared across the machine)
543         and we didn't cap the number of processes started, so we would end up with a whole bunch of DRTs (3x-4x
544         the number of workers started). If anything, this seemed to make the tests slightly slower and probably added
545         to memory pressure on the machine.
546
547         This change removes the pool code; now we'll simply restart DRT when the command line changes. With this change,
548         we can actually fold the restarting code into Driver itself (and get rid of DriverProxy), but I'll leave that
549         for a subsequent patch just to make things easier to follow.
550
551         * Scripts/webkitpy/port/driver.py:
552         (DriverProxy.__init__):
553         (DriverProxy.run_test):
554         (DriverProxy.has_crashed):
555         (DriverProxy.stop):
556
557 2013-05-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
558
559         Change EFL Linux 64-bit Release with EFL Linux 64-bit Release WK1
560         https://bugs.webkit.org/show_bug.cgi?id=116423
561
562         Reviewed by Ryosuke Niwa.
563
564         EFL Linux 64-bit Release starts to support WK1's build and layout test from now on.
565
566         * BuildSlaveSupport/build.webkit.org-config/config.json:
567
568 2013-05-20  Seokju Kwon  <seokju.kwon@gmail.com>
569
570         Remove remaining link-prerender code
571         https://bugs.webkit.org/show_bug.cgi?id=116429
572
573         Reviewed by Darin Adler.
574
575         Link prerendering code was removed in r150356.
576
577         * Scripts/webkitperl/FeatureList.pm:
578         * qmake/mkspecs/features/features.pri:
579
580 2013-05-20  Ryosuke Niwa  <rniwa@webkit.org>
581
582         commit-queue should check for oops in changelog entries
583         https://bugs.webkit.org/show_bug.cgi?id=116395
584
585         Reviewed by Martin Robinson.
586
587         Make changelog validation fail when it contains oops!.
588
589         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
590         (CommitQueueTask._validate_changelog):
591         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
592         (CommitQueueTaskTest._run_through_task):
593         * Scripts/webkitpy/tool/commands/queues_unittest.py:
594         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
595         (ValidateChangeLogs.options):
596         (ValidateChangeLogs._check_changelog_diff):
597         (ValidateChangeLogs._changelog_contains_oops):
598         (ValidateChangeLogs.run):
599         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
600         (ValidateChangeLogsTest._assert_start_line_produces_output):
601         (ValidateChangeLogsTest.test_check_changelog_diff):
602         (ValidateChangeLogsTest):
603         (ValidateChangeLogsTest.test_changelog_contains_oops):
604
605 2013-05-20  Jessie Berlin  <jberlin@apple.com>
606
607         Expose a way to know when forms are added to a page or when form controls are added to a form
608         in the injected bundle
609         https://bugs.webkit.org/show_bug.cgi?id=116334
610
611         Reviewed by Alexey Proskuryakov.
612
613         Add tests for the new callbacks.
614
615         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
616         Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
617
618         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
619         (TestWebKitAPI::nullJavaScriptCallback):
620         A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
621         being passed in for the callback.
622         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
623         After receiving the message that didAssociateFormControls callback was invoked from adding
624         the form in the onload handler, tell the page to add a password field to the form, which
625         should also invoke didAssociateFormControls callback.
626         (TestWebKitAPI::setInjectedBundleClient):
627         Register to receive messages.
628         (TestWebKitAPI::TEST):
629         Load associate-form-controls.html and wait until the didAssociateFormControls callback has
630         been invoked for both adding the form and for adding a password field to the form.
631
632         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
633         (TestWebKitAPI::shouldNotifyOnFormChanges):
634         Return true so the didAssociateFormControls callback is invoked.
635         (TestWebKitAPI::didAssociateFormControls):
636         Tell the UI process.
637         (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
638         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
639         Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
640
641         * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
642         Add a form in response to the onload event. Add a button that will add the password field
643         for manual testing.
644
645 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
646
647         [EFL][JHBUILD] Make sure eet is built before evas
648         https://bugs.webkit.org/show_bug.cgi?id=116440
649
650         Reviewed by Gyuyoung Kim.
651
652         Mark eet as a dependency of evas since evas requires eet to enable some of its
653         functionality.
654
655         * efl/jhbuild.modules:
656
657 2013-05-20  Alex Christensen  <achristensen@apple.com>
658
659         WTR::pathSuitableForTestResult should behave the same as _drt_descriptionSuitableForTestResult so we can unskip tests.
660         https://bugs.webkit.org/show_bug.cgi?id=116125
661
662         Reviewed by Tim Horton.
663
664         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
665         (WTR::pathSuitableForTestResult):
666         Changed string operations to match _drt_descriptionSuitableForTestResult.
667         (WTR::dumpRequestDescriptionSuitableForTestResult):
668         (WTR::dumpResponseDescriptionSuitableForTestResult):
669         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
670         (WTR::InjectedBundlePage::didInitiateLoadForResource):
671         (WTR::InjectedBundlePage::willSendRequestForFrame):
672         (WTR::InjectedBundlePage::didReceiveResponseForResource):
673         Pass the main frame's URL to pathSuitableForTestResult.
674         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
675         Added WKBundlePageRef to willPerformClientRedirectForFrame.
676
677 2013-05-20  Dirk Pranke  <dpranke@chromium.org>
678
679         fix w3c test importer unit tests after r150324
680         https://bugs.webkit.org/show_bug.cgi?id=116459
681
682         Reviewed by Ryosuke Niwa.
683
684         This patch fixes the unit tests to not actually call out to
685         'hg' (by using a mock executive) and also changes the real
686         directory we crawl from Source/WebCore/css to
687         Tools/Scripts/webkitpy/w3c to run much more quickly. We should
688         still change this to a mock filesystem, but that's a separate change.
689
690         * Scripts/webkitpy/w3c/test_importer.py:
691         (main):
692         (TestImporter.__init__):
693         (TestImporter.load_changeset):
694         * Scripts/webkitpy/w3c/test_importer_unittest.py:
695         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
696         (TestImporterTest.test_import_dir_with_no_tests):
697
698 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
699
700         Unreviewed EFL build fix.
701
702         Fix linking errors due to undefined symbols on Ubuntu 13.04.
703
704         * DumpRenderTree/efl/CMakeLists.txt:
705         * EWebLauncher/CMakeLists.txt:
706         * MiniBrowser/efl/CMakeLists.txt:
707
708 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
709
710         [EFL] Reenabled INDEXED_DATABASE after r150344
711         https://bugs.webkit.org/show_bug.cgi?id=116430
712
713         Reviewed by Gyuyoung Kim.
714
715         Reenable INDEXED_DATABASE flag for EFL port now that WebKit2
716         build was fixed in r150344.
717
718         * Scripts/webkitperl/FeatureList.pm:
719
720 2013-05-19  Ryuan Choi  <ryuan.choi@samsung.com>
721
722         [EFL] init/shutdown should be paired in EWebLauncher
723         https://bugs.webkit.org/show_bug.cgi?id=116427
724
725         Reviewed by Christophe Dumez.
726
727         Added ecore_file_shutdown() for cleanup of ecore_file.
728         Removed edje_init and ecore_evas_init because it was in ewk_init().
729
730         * EWebLauncher/main.c:
731         (main):
732
733 2013-05-19  Jinwoo Song  <jinwoo7.song@samsung.com>
734
735         [EFL] Add command line option to MiniBrowser to set user agent
736         https://bugs.webkit.org/show_bug.cgi?id=116387
737
738         Reviewed by Christophe Dumez.
739
740         We need this option to compare the rendering differences according to different user agents.
741
742         * MiniBrowser/efl/main.c:
743         (window_create):
744         (elm_main):
745
746 2013-05-19  Zan Dobersek  <zdobersek@igalia.com>
747
748         Unreviewed, addressing test-webkitpy failures after r150317.
749
750         * Scripts/webkitpy/w3c/test_converter.py:
751         (W3CTestConverter.read_webkit_prefixed_css_property_list): CssPropertyNames.in doesn't exist, but CSSPropertyNames.in does.
752
753 2013-05-18  Patrick Gansterer  <paroga@webkit.org>
754
755         [CMake] Replace *_LIBRARY_NAME with *_OUTPUT_NAME
756         https://bugs.webkit.org/show_bug.cgi?id=114554
757
758         Reviewed by Gyuyoung Kim.
759
760         Using variables as target names is very uncommon in CMake.
761         The usual way to specify the name of the resulting binary
762         is to set the OUTPUT_NAME target property.
763
764         * DumpRenderTree/efl/CMakeLists.txt:
765         * EWebLauncher/CMakeLists.txt:
766         * ImageDiff/CMakeLists.txt:
767         * MiniBrowser/efl/CMakeLists.txt:
768         * TestWebKitAPI/CMakeLists.txt:
769         * WebKitTestRunner/CMakeLists.txt:
770         * WebKitTestRunner/PlatformEfl.cmake:
771         * WinCELauncher/CMakeLists.txt:
772
773 2013-05-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
774
775         Unreviewed EFL build fix.
776
777         Temporarily disabled INDEXED_DATABASE at compile-time as it breaks
778         WK2 build after r150305.
779
780         * Scripts/webkitperl/FeatureList.pm:
781
782 2013-05-18  Alberto Garcia  <agarcia@igalia.com>
783
784         [GTK] Parallel build fails if gtk-doc is enabled
785         https://bugs.webkit.org/show_bug.cgi?id=116227
786
787         Reviewed by Martin Robinson.
788
789         * GNUmakefile.am:
790         Don't use the 'all' target to generate the documentation.
791         The prerequisites of this target must be files that need to be
792         built _before_ the actual compilation of WebKit starts. Since the
793         documentation depends on WebKit being built first, this means in
794         practice that the code will be built in parallel with the
795         generation of its dependencies, potentially making the build fail.
796
797 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
798
799         Don't run hg.
800
801         * Scripts/webkitpy/w3c/test_importer_unittest.py:
802         (TestImporterTest):
803
804 2013-05-17  Dirk Pranke  <dpranke@chromium.org>
805
806         Create a script to import W3C tests
807         https://bugs.webkit.org/show_bug.cgi?id=111513
808
809         Reviewed by Ryosuke Niwa.
810
811         This patch attempts to re-land the 'import-w3c-tests'
812         script and accompanying modules.  The tests and code have
813         been cleaned up so that we do not log anything to stdout/stderr
814         while running the tests (thanks to outputcapture) and do not
815         write into the source tree while running the tests, and much
816         but not all of the code has been converted over to using the webkitpy
817
818         * Scripts/import-w3c-tests: Added.
819         * Scripts/webkitpy/w3c/__init__.py: Added.
820         * Scripts/webkitpy/w3c/test_converter.py: Added.
821         (W3CTestConverter):
822         (W3CTestConverter.__init__):
823         (W3CTestConverter.path_from_webkit_root):
824         (W3CTestConverter.read_webkit_prefixed_css_property_list):
825         (W3CTestConverter.convert_for_webkit):
826         (W3CTestConverter.convert_css):
827         (W3CTestConverter.convert_html):
828         (W3CTestConverter.convert_testharness_paths):
829         (W3CTestConverter.convert_prefixed_properties):
830         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
831         (W3CTestConverter.replace_tag):
832         * Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
833         (W3CTestConverterTest):
834         (W3CTestConverterTest.fake_dir_path):
835         (W3CTestConverterTest.test_read_prefixed_property_list):
836         (W3CTestConverterTest.test_convert_for_webkit_nothing_to_convert):
837         (test_convert_for_webkit_harness_only):
838         (test_convert_for_webkit_properties_only):
839         (test_convert_for_webkit_harness_and_properties):
840         (test_convert_test_harness_paths):
841         (test_convert_prefixed_properties):
842         (verify_conversion_happened):
843         (verify_no_conversion_happened):
844         (verify_test_harness_paths):
845         (verify_prefixed_properties):
846         (generate_test_content):
847         * Scripts/webkitpy/w3c/test_importer.py: Added.
848         (main):
849         (parse_args):
850         (validate_import_directory):
851         (TestImporter):
852         (TestImporter.__init__):
853         (TestImporter.path_from_webkit_root):
854         (TestImporter.do_import):
855         (TestImporter.load_changeset):
856         (TestImporter.find_importable_tests):
857         (TestImporter.import_tests):
858         (TestImporter.setup_destination_directory):
859         (TestImporter.update_test_status):
860         (TestImporter.remove_deleted_files):
861         (TestImporter.write_import_log):
862         * Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
863         (TestImporterTest):
864         (TestImporterTest.test_import_dir_with_no_tests):
865         * Scripts/webkitpy/w3c/test_parser.py: Added.
866         (TestParser):
867         (TestParser.__init__):
868         (TestParser.load_file):
869         (TestParser.analyze_test):
870         (TestParser.reference_links_of_type):
871         (TestParser.is_jstest):
872         (TestParser.support_files):
873         * Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
874         (TestParserTest):
875         (TestParserTest.test_analyze_test_reftest_one_match):
876         (test_analyze_test_reftest_multiple_matches):
877         (test_analyze_test_reftest_match_and_mismatch):
878         (test_analyze_test_reftest_with_ref_support_Files):
879         (test_analyze_jstest):
880         (test_analyze_pixel_test_all_true):
881         (test_analyze_pixel_test_all_false):
882         (test_analyze_non_html_file):
883
884 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
885
886         Leaks builders exit early frequently
887         https://bugs.webkit.org/show_bug.cgi?id=116355
888
889         Reviewed by Stephanie Lewis.
890
891         Throttle the number of processes to use, and also bump up the number of crashes/timeouts
892         we tolerate from 20 to 50.
893
894         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
895         (RunWebKitTests.start):
896         * Scripts/webkitpy/port/mac.py:
897         (MacPort.default_child_processes):
898
899 2013-05-17  Peter Gal  <galpeter@inf.u-szeged.hu>
900
901         Remove chrome-channels command from the webkit-patch
902         https://bugs.webkit.org/show_bug.cgi?id=116303
903
904         Reviewed by Ryosuke Niwa.
905
906         * Scripts/webkitpy/common/config/urls.py: Removed omahaproxy url.
907         * Scripts/webkitpy/common/net/omahaproxy.py: Removed.
908         * Scripts/webkitpy/common/net/omahaproxy_unittest.py: Removed.
909         * Scripts/webkitpy/tool/commands/__init__.py: Removed chromechannels import.
910         * Scripts/webkitpy/tool/commands/chromechannels.py: Removed.
911         * Scripts/webkitpy/tool/commands/chromechannels_unittest.py: Removed.
912
913 2013-05-17  David Kilzer  <ddkilzer@apple.com>
914
915         filter-build-webkit: Don't filter out the location of the missing symbol when linking fails
916         Part 3 of 3: <http://webkit.org/b/116247>
917
918         Reviewed by Benjamin Poulain.
919
920         * Scripts/filter-build-webkit: Change while() loop to for() loop
921         to track $previousLine, then pass $previousLine into
922         shouldIgnoreLine().
923         (shouldIgnoreLine): Add $previousLine argument. Do not skip a
924         line that begins with four spaces if the previous line is a
925         linker error message.
926         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
927         - Add "Ignored: " to test descriptions to document expected
928           behavior.
929         - Add comment blocks for various groups of tests.
930         - Expand "Build settings" tests since we're changing the code in
931           shouldIgnoreLine() that ignores those lines.
932         - Add tests for undefined symbols error message.
933         (description): Add.  Extract from global code.
934
935 2013-05-17  David Kilzer  <ddkilzer@apple.com>
936
937         Add tests for shouldIgnoreLine() in filter-build-webkit
938         Part 2 of 3: <http://webkit.org/b/116247>
939
940         Reviewed by Benjamin Poulain.
941
942         * Scripts/filter-build-webkit:
943         (shouldIgnoreLine): Add.  Extract code from global scope into
944         subroutine to make it testable.
945         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl: Add.
946         Tests shouldIgnoreLine() using output from a real build
947         transcript.
948
949 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
950
951         Rename "WebKit Queues" to explicitly call out for EWS and CQ on build.webkit.org
952         https://bugs.webkit.org/show_bug.cgi?id=116341
953
954         Reviewed by Brady Eidson.
955
956         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
957
958 2013-05-17  Brent Fulgham  <bfulgham@apple.com>
959
960         [Windows] Don't use pdevenv when building with VS2010.
961         https://bugs.webkit.org/show_bug.cgi?id=116338.
962
963         Reviewed by Adam Roben.
964
965         * Scripts/webkitdirs.pm:
966         (setupCygwinEnv): Check if we are using VS2005, and only use
967         the 'pdevenv' hack if we are. Otherwise, just build with
968         our standard project since it uses VS2010+'s native
969         parallel building features.
970
971 2013-05-17  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
972
973         Unreviewed. Disable accelerated compositing until we figure out why it does not work
974         properly in the 64 bits release bot.
975
976         * DumpRenderTree/gtk/DumpRenderTree.cpp:
977         (resetDefaultsToConsistentValues):
978
979 2013-05-17  David Kilzer  <ddkilzer@apple.com>
980
981         Make filter-build-webkit testable using LoadAsModule
982         Part 1 of 3: <http://webkit.org/b/116247>
983
984         Reviewed by Benjamin Poulain.
985
986         * Scripts/filter-build-webkit: Change global variables that are
987         used in subroutines from 'my' to 'our' to make it possible to
988         evaluate the script in a package context in LoadAsModule.pm.
989
990 2013-05-14  Sam Weinig  <sam@webkit.org>
991
992         Add variants of the loading APIs that take user data and a way for the injected bundle to find out about them
993         https://bugs.webkit.org/show_bug.cgi?id=116132
994
995         Reviewed by Anders Carlsson.
996
997         Adds "WithUserData" versions of all the load APIs and two new WKBundlePageLoaderClient functions,
998         willLoadURLRequest and willLoadDataRequest to let the bundle access them.
999
1000         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1001         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Added.
1002         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp: Added.
1003         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1004
1005 2013-05-16  Seokju Kwon  <seokju.kwon@gmail.com>
1006
1007         [EFL] inspector-protocol/page/javascriptDialogEvents.html is failing
1008         https://bugs.webkit.org/show_bug.cgi?id=114781
1009
1010         Reviewed by Christophe Dumez.
1011
1012         Add run_before_unload_confirm and
1013         Print the log message with "CONFIRM NAVIGATION: " in console.
1014
1015         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1016         (onBeforeUnloadConfirm):
1017         (drtViewAdd):
1018
1019 2013-05-16  Peter Gal  <galpeter@inf.u-szeged.hu>
1020
1021         Fix Analyze ChangeLog's entry processing
1022         https://bugs.webkit.org/show_bug.cgi?id=116219
1023
1024         Reviewed by Ryosuke Niwa.
1025
1026         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
1027         (ChangeLogAnalyzer._analyze_entries): Fix the counter initialization.
1028
1029 2013-05-16  Hyungchan Kim  <hyungchan2.kim@lge.com>
1030
1031         [Qt] UrlLoader::loadNext is broken in MiniBrowser
1032         https://bugs.webkit.org/show_bug.cgi?id=116099
1033
1034         Reviewed by Jocelyn Turcotte.
1035
1036         QQuickWebView's 3 signals(loadStarted, loadSucceeded, loadFailed)
1037         are not available any more. So, UrlLoader::loadNext was broken
1038         because it failed to connect to those signals.
1039
1040         * MiniBrowser/qt/UrlLoader.cpp:
1041         (UrlLoader::UrlLoader):
1042         (UrlLoader::loadingChanged):
1043         * MiniBrowser/qt/UrlLoader.h:
1044         (UrlLoader):
1045
1046 2013-05-16  Lamarque V. Souza  <Lamarque.Souza@basyskom.com>
1047
1048         [WebSocket] Update pywebsocket to r760
1049         https://bugs.webkit.org/show_bug.cgi?id=115863
1050
1051         Reviewed by Alexey Proskuryakov.
1052
1053         Version r760 supports a newer draft of message compression.
1054         We need this update to finish the permessage compression patch in
1055         bug 98840. This patch also fixes failing unit tests after the update.
1056
1057         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py:
1058         (StreamBase._read):
1059         (StreamBase._read.of):
1060         (StreamBase._write):
1061         (StreamBase.receive_bytes):
1062         (StreamBase._read_until):
1063         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py:
1064         (parse_frame):
1065         (StreamOptions.__init__):
1066         (Stream.__init__):
1067         (Stream._receive_frame_as_frame_object):
1068         (Stream._get_message_from_frame):
1069         (Stream._process_close_message):
1070         (Stream.close_connection):
1071         (Stream.get_last_received_opcode):
1072         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py:
1073         * Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py:
1074         (Dispatcher.do_extra_handshake):
1075         (Dispatcher.transfer_data):
1076         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py:
1077         (ExtensionProcessorInterface.__init__):
1078         (ExtensionProcessorInterface.request):
1079         (ExtensionProcessorInterface):
1080         (ExtensionProcessorInterface.name):
1081         (ExtensionProcessorInterface.check_consistency_with_other_processors):
1082         (ExtensionProcessorInterface.set_active):
1083         (ExtensionProcessorInterface.is_active):
1084         (ExtensionProcessorInterface._get_extension_response_internal):
1085         (ExtensionProcessorInterface.get_extension_response):
1086         (ExtensionProcessorInterface._setup_stream_options_internal):
1087         (ExtensionProcessorInterface.setup_stream_options):
1088         (_log_outgoing_compression_ratio):
1089         (_log_incoming_compression_ratio):
1090         (_parse_window_bits):
1091         (_AverageRatioCalculator):
1092         (_AverageRatioCalculator.__init__):
1093         (_AverageRatioCalculator.add_original_bytes):
1094         (_AverageRatioCalculator.add_result_bytes):
1095         (_AverageRatioCalculator.get_average_ratio):
1096         (DeflateFrameExtensionProcessor):
1097         (DeflateFrameExtensionProcessor.__init__):
1098         (DeflateFrameExtensionProcessor._get_extension_response_internal):
1099         (DeflateFrameExtensionProcessor._setup_stream_options_internal):
1100         (DeflateFrameExtensionProcessor._outgoing_filter):
1101         (DeflateFrameExtensionProcessor._incoming_filter):
1102         (CompressionExtensionProcessorBase.for):
1103         (CompressionExtensionProcessorBase.__init__):
1104         (CompressionExtensionProcessorBase._get_extension_response_internal):
1105         (CompressionExtensionProcessorBase._setup_stream_options_internal):
1106         (PerFrameCompressExtensionProcessor):
1107         (PerMessageDeflateExtensionProcessor):
1108         (PerMessageDeflateExtensionProcessor.__init__):
1109         (PerMessageDeflateExtensionProcessor._get_extension_response_internal):
1110         (PerMessageDeflateExtensionProcessor._setup_stream_options_internal):
1111         (PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits):
1112         (PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits.adds):
1113         (PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover):
1114         (PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover.adds):
1115         (PerMessageDeflateExtensionProcessor.set_bfinal):
1116         (PerMessageDeflateExtensionProcessor.enable_outgoing_compression):
1117         (PerMessageDeflateExtensionProcessor.disable_outgoing_compression):
1118         (_PerMessageDeflateFramer):
1119         (_PerMessageDeflateFramer.__init__):
1120         (_PerMessageDeflateFramer.set_compress_outgoing_enabled):
1121         (_PerMessageDeflateFramer._process_incoming_message):
1122         (_PerMessageDeflateFramer._process_outgoing_message):
1123         (_PerMessageDeflateFramer.setup_stream_options):
1124         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter):
1125         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.__init__):
1126         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.filter):
1127         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter):
1128         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.__init__):
1129         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.decompress_next_message):
1130         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.filter):
1131         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter):
1132         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.__init__):
1133         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.set_compression_bit):
1134         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.filter):
1135         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter):
1136         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.__init__):
1137         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.filter):
1138         (PerMessageCompressExtensionProcessor):
1139         (PerMessageCompressExtensionProcessor._lookup_compression_processor):
1140         (MuxExtensionProcessor.__init__):
1141         (MuxExtensionProcessor.check_consistency_with_other_processors):
1142         (MuxExtensionProcessor):
1143         (MuxExtensionProcessor._get_extension_response_internal):
1144         (MuxExtensionProcessor._setup_stream_options_internal):
1145         (MuxExtensionProcessor.set_quota):
1146         (MuxExtensionProcessor.quota):
1147         (MuxExtensionProcessor.set_extensions):
1148         (MuxExtensionProcessor.extensions):
1149         (is_compression_extension):
1150         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py:
1151         (validate_subprotocol):
1152         (parse_host_header):
1153         (format_header):
1154         (check_request_line):
1155         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py:
1156         (Handshaker.do_handshake):
1157         (Handshaker._create_handshake_response):
1158         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py:
1159         (_validate_subprotocol):
1160         (_check_header_lines):
1161         (_build_location):
1162         (Handshaker.do_handshake):
1163         (Handshaker._set_subprotocol):
1164         (Handshaker._set_location):
1165         * Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py:
1166         (_create_dispatcher):
1167         (headerparserhandler):
1168         * Scripts/webkitpy/thirdparty/mod_pywebsocket/mux.py:
1169         (_create_add_channel_response):
1170         (_create_drop_channel):
1171         (_create_flow_control):
1172         (_create_new_channel_slot):
1173         (_create_fallback_new_channel_slot):
1174         (_MuxFramePayloadParser._read_number):
1175         (_MuxFramePayloadParser._read_size_and_contents):
1176         (_MuxFramePayloadParser._read_flow_control):
1177         (_MuxFramePayloadParser._read_new_channel_slot):
1178         (_LogicalConnection.__init__):
1179         (_LogicalConnection.write):
1180         (_LogicalConnection.on_write_data_done):
1181         (_LogicalConnection):
1182         (_LogicalConnection.on_writer_done):
1183         (_InnerMessage):
1184         (_InnerMessage.__init__):
1185         (_InnerMessageBuilder):
1186         (_InnerMessageBuilder.that):
1187         (_InnerMessageBuilder.__init__):
1188         (_InnerMessageBuilder._handle_first):
1189         (_InnerMessageBuilder._process_first_fragmented_control):
1190         (_InnerMessageBuilder._process_first_fragmented_message):
1191         (_InnerMessageBuilder._handle_fragmented_control):
1192         (_InnerMessageBuilder._reassemble_fragmented_control):
1193         (_InnerMessageBuilder._handle_fragmented_message):
1194         (_InnerMessageBuilder._reassemble_fragmented_message):
1195         (_InnerMessageBuilder.build):
1196         (_LogicalStream.__init__):
1197         (_LogicalStream._create_inner_frame):
1198         (_LogicalStream._write_inner_frame):
1199         (_LogicalStream.replenish_send_quota):
1200         (_LogicalStream.send_message):
1201         (_LogicalStream._receive_frame):
1202         (_LogicalStream._get_message_from_frame):
1203         (_LogicalStream.stop_sending):
1204         (_PhysicalConnectionWriter.__init__):
1205         (_PhysicalConnectionWriter._write_data):
1206         (_PhysicalConnectionWriter.run):
1207         (_PhysicalConnectionWriter.stop):
1208         (_Worker.run):
1209         (_MuxHandshaker.__init__):
1210         (_MuxHandshaker._create_stream):
1211         (_MuxHandshaker._create_handshake_response):
1212         (_HandshakeDeltaBase.create_headers):
1213         (_MuxHandler.start):
1214         (_MuxHandler.wait_until_done):
1215         (_MuxHandler.notify_write_data_done):
1216         (_MuxHandler._process_drop_channel):
1217         (_MuxHandler._process_logical_frame):
1218         (_MuxHandler.notify_reader_done):
1219         (_MuxHandler):
1220         (_MuxHandler.notify_writer_done):
1221         (_MuxHandler.fail_physical_connection):
1222         (_MuxHandler.fail_logical_channel):
1223         (use_mux):
1224         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py:
1225         (_StandaloneRequest.get_uri):
1226         (_StandaloneRequest.get_unparsed_uri):
1227         (_StandaloneRequest):
1228         (_StandaloneRequest.is_https):
1229         (_import_ssl):
1230         (_import_pyopenssl):
1231         (_StandaloneSSLConnection.for):
1232         (_StandaloneSSLConnection):
1233         (_StandaloneSSLConnection.__getattribute__):
1234         (_StandaloneSSLConnection.__setattr__):
1235         (_StandaloneSSLConnection.makefile):
1236         (_StandaloneSSLConnection.shutdown):
1237         (_StandaloneSSLConnection.recv):
1238         (WebSocketServer.__init__):
1239         (WebSocketServer._create_sockets):
1240         (WebSocketServer.handle_error):
1241         (WebSocketServer.get_request):
1242         (WebSocketServer.get_request.default_callback):
1243         (WebSocketRequestHandler.parse_request):
1244         (_build_option_parser):
1245         (_main):
1246         (_main.if):
1247         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py:
1248         (RepeatedXorMasker.__init__):
1249         (RepeatedXorMasker._mask_using_swig):
1250         (RepeatedXorMasker):
1251         (RepeatedXorMasker._mask_using_array):
1252         (_Deflater.compress_and_finish):
1253         (_RFC1979Deflater.filter):
1254         (DeflateSocket.send):
1255
1256 2013-05-16  Jonathan Liu  <net147@gmail.com>
1257
1258         Fix testing if program exists in PATH
1259         https://bugs.webkit.org/show_bug.cgi?id=116216
1260
1261         Reviewed by Jocelyn Turcotte.
1262
1263         functions.prf incorrectly uses win_cmd_shell to test whether to
1264         add .exe to the executable name when checking if it exists in
1265         the PATH environment variable. This works correctly when
1266         building using Windows Command Prompt but not under MSYS shell.
1267
1268         To resolve this, check the win32 platform scope instead of
1269         win_cmd_shell so that it correctly adds .exe to the executable
1270         name on Windows regardless of the shell used when testing if
1271         it exists in PATH.
1272
1273         * qmake/mkspecs/features/functions.prf:
1274
1275 2013-05-16  Ryosuke Niwa  <rniwa@webkit.org>
1276
1277         Fix the hard-coded names of EWS bots that run tests.
1278
1279         * Scripts/webkitpy/tool/commands/queues.py:
1280         (CommitQueue.did_pass_testing_ews):
1281
1282 2013-05-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1283
1284         [GTK] Build Xvfb with jhbuild
1285         https://bugs.webkit.org/show_bug.cgi?id=115907
1286
1287         Reviewed by Martin Robinson.
1288
1289         Build our own Xvfb so that we can avoid problems with the system Xvfb
1290         relying on symbols not present in our jhbuilt libraries such as pixman,
1291         and also to ensure we have the fix for a GLX module crasher.
1292
1293         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1294         (resetDefaultsToConsistentValues): enable accelerated compositing.
1295         * gtk/install-dependencies: list packages required for building Xvfb.
1296         * gtk/jhbuild.modules: add xserver as a jhbuild module.
1297         * gtk/patches/xserver-remove-bogus-dependencies.patch: Added.
1298         * gtk/patches/xserver-fix-glx-init.patch: Added. Fixes a crash while
1299         initializing the GLX module for Xvfb.
1300
1301 2013-05-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1302
1303         [jhbuild] Should remove the sources directory as well when cleaning
1304         https://bugs.webkit.org/show_bug.cgi?id=116229
1305
1306         Reviewed by Martin Robinson.
1307
1308         * Scripts/update-webkit-libs-jhbuild:
1309         (cleanJhbuild): remove the Source directory as well when cleaning.
1310
1311 2013-05-15  Dominik Röttsches  <dominik.rottsches@intel.com>
1312
1313         [EFL] Remove Intel Wk2 Buildbots from Master
1314         https://bugs.webkit.org/show_bug.cgi?id=116149
1315
1316         Removing Intel maintained EFL Wk2 bots except the handle for efl-linux-slave-2
1317         since Gyuyoung Kim from Samsung plans to take over and maintain it.
1318
1319         Reviewed by Benjamin Poulain.
1320
1321         * BuildSlaveSupport/build.webkit.org-config/config.json:
1322
1323 2013-05-15  Brent Fulgham  <bfulgham@apple.com>
1324
1325         [Windows] Update various build tools to understand VS2010 environment.
1326         https://bugs.webkit.org/show_bug.cgi?id=116169.
1327
1328         Reviewed by Anders Carlsson.
1329
1330         * Scripts/build-api-tests: Identify VS2010 environment.
1331         * Scripts/build-dumprendertree: Ditto.
1332         * Scripts/build-webkit: Ditto.
1333         * Scripts/webkitdirs.pm:
1334         (dieIfWindowsPlatformSDKNotInstalled): Update to recognize a wider
1335         range of acceptable SDK's.
1336
1337 2013-05-15  Peter Gal  <galpeter@inf.u-szeged.hu>
1338
1339         Allow http tests on Arch Linux
1340         https://bugs.webkit.org/show_bug.cgi?id=116155
1341
1342         Reviewed by Ryosuke Niwa.
1343
1344         * Scripts/webkitpy/port/base.py:
1345         (Port._is_arch_based): Added check for /etc/arch-release file.
1346         (Port._apache_config_file_name_for_platform): Call the check.
1347         * Scripts/webkitpy/port/port_testcase.py:
1348         (test_linux_distro_detection): Testcase added.
1349
1350 2013-05-15  Peter Gal  <galpeter@inf.u-szeged.hu>
1351
1352         Remove a leftover v8 file from the watchlist
1353         https://bugs.webkit.org/show_bug.cgi?id=116158
1354
1355         Reviewed by Csaba Osztrogonác.
1356
1357         * Scripts/webkitpy/common/config/watchlist: Removed a v8 entry from the watchlist.
1358
1359 2013-05-15  Alberto Garcia  <agarcia@igalia.com>
1360
1361         [GTK] Fails to build while generating gtkdoc
1362         https://bugs.webkit.org/show_bug.cgi?id=115612
1363
1364         Reviewed by Philippe Normand.
1365
1366         Fix typo in the prerequisites of docs-build.stamp.
1367
1368         * GNUmakefile.am:
1369
1370 2013-05-15  Zan Dobersek  <zdobersek@igalia.com>
1371
1372         Unreviewed, fixing the current test-webkitpy failure.
1373
1374         * Scripts/webkitpy/port/mac_unittest.py:
1375         (test_setup_environ_for_server): Adjusting the expected DYLD_INSERT_LIBRARIES environment variable value
1376         in webkitpy.port.mac_unittest.test_setup_environ_for_server after r150089.
1377
1378 2013-05-14  Jaehun Lim  <ljaehun.lim@samsung.com>
1379
1380         Fix build after r150090.
1381         https://bugs.webkit.org/show_bug.cgi?id=116129
1382
1383         Unreviewed build fix after r150090.
1384
1385         * WebKitTestRunner/TestInvocation.cpp:
1386         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1387
1388 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
1389
1390         [Windows, others] Unreviewed build fix after r150090.
1391
1392         * DumpRenderTree/TestRunner.cpp:
1393         (getSecureEventInputIsEnabledCallback): IsSecureEventInputEnabled
1394         doesn't exist on other platforms.
1395
1396 2013-05-14  Brent Fulgham  <bfulgham@webkit.org>
1397
1398         [Windows] Expunge pthreads2VC.dll from DumpRenderTree Project
1399         https://bugs.webkit.org/show_bug.cgi?id=115889
1400
1401         Reviewed by Benjamin Poulain.
1402
1403         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
1404         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1405
1406 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
1407
1408         [Windows] Identify proper run environment for scripts.
1409         https://bugs.webkit.org/show_bug.cgi?id=116114
1410
1411         Reviewed by David Kilzer.
1412
1413         Determine (based on Visual Studio version) which path to use for
1414         executables (bin versus bin32).
1415
1416         * Scripts/webkitdirs.pm:
1417         (determineVisualStudioInstallDir): Added.
1418         (determineVisualStudioVersion): Added.
1419         (determineConfigurationProductDir): Modified to choose proper bin
1420         or bin32 directory.
1421         (visualStudioVersion): Added
1422         (setupCygwinEnv): Modified to use new determineVisualStudioInstallDir
1423
1424 2013-05-14  Alexey Proskuryakov  <ap@apple.com>
1425
1426         [Mac] Add tests for secure event input
1427         https://bugs.webkit.org/show_bug.cgi?id=116121
1428
1429         Reviewed by Mark Rowe.
1430
1431         * DumpRenderTree/TestRunner.cpp:
1432         (getSecureEventInputIsEnabledCallback):
1433         (TestRunner::staticValues):
1434         Expose an accessor for current secure event input state.
1435
1436         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1437         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1438         (WTR::TestRunner::secureEventInputIsEnabled):
1439         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1440         * WebKitTestRunner/TestInvocation.cpp:
1441         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1442         Expose an accessor for current secure event input state. This has to be done in
1443         UI process, as this is where it's changed by WebKit.
1444
1445 2013-05-14  Alexey Proskuryakov  <ap@apple.com>
1446
1447         [Mac] Add a testing shim for secure event input functions
1448         https://bugs.webkit.org/show_bug.cgi?id=116122
1449
1450         Reviewed by Mark Rowe.
1451
1452         * Scripts/webkitpy/port/mac.py: (MacPort.setup_environ_for_server):
1453         Inject WebCore testing shim library to override system framework functions.
1454
1455 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
1456
1457         [Windows] Switch to embedded manifest commands for launcher executables.
1458         https://bugs.webkit.org/show_bug.cgi?id=116109
1459
1460         Reviewed by Darin Adler.
1461
1462         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Remove the
1463         now-unused WinLauncher.exe.manifest file.
1464         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
1465         * win/DLLLauncher/DLLLauncherMain.cpp: Add embedded manifest command
1466         when building with VS2010 or newer.
1467
1468 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
1469
1470         [Windows] Update ORWT to know about the Windows 8 SDK and Debug Tools.
1471         https://bugs.webkit.org/show_bug.cgi?id=116079
1472
1473         Reviewed by David Kilzer.
1474
1475         * Scripts/old-run-webkit-tests:
1476         (setUpWindowsCrashLogSaving): Locate ntsd.exe and use it.
1477
1478 2013-05-14  Zan Dobersek  <zdobersek@igalia.com>
1479
1480         [GTK] Move generated ColorData.cpp, WebKitFontFamilyNames.(cpp|h) build targets into libPlatform
1481         https://bugs.webkit.org/show_bug.cgi?id=115921
1482
1483         Reviewed by Gustavo Noronha Silva.
1484
1485         * GNUmakefile.am: Add platform_cppflags to the list of CPPFLAGS for libWebCoreInternals and DumpRenderTree.
1486         * TestWebKitAPI/GNUmakefile.am: Add platform_cppflags to the list of TestGtk CPPFLAGS.
1487
1488 2013-05-13  Alex Christensen  <achristensen@apple.com>
1489
1490         Added testRunner.setPrinting.
1491         https://bugs.webkit.org/show_bug.cgi?id=42693
1492         rdar://problem/8213845
1493
1494         Reviewed by Darin Adler.
1495
1496         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1497         Added setPrinting JavaScript function.
1498         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1499         (WTR::InjectedBundlePage::dump):
1500         Dump the external representation for printing if setPrinting has been called.
1501         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1502         (WTR::TestRunner::isPrinting): Added.
1503         (WTR::TestRunner::setPrinting): Added.
1504         Added and initialized m_isPrinting member boolean.
1505
1506 2013-05-13  Csaba Osztrogonác  <ossy@webkit.org>
1507
1508         [webkitpy] Make FileInfo.repository_name support SVN version > 1.6
1509         https://bugs.webkit.org/show_bug.cgi?id=116016
1510
1511         Reviewed by Dirk Pranke.
1512
1513         Same fix as in the upstream style checker, but without hg support.
1514         ( http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py )
1515
1516         * Scripts/webkitpy/style/checkers/cpp.py:
1517         (FileInfo.repository_name):
1518
1519 2013-05-13  Zan Dobersek  <zdobersek@igalia.com>
1520
1521         [GTK] Use WebCore layer archives for TestWebCore, WebKitPluginProcess
1522         https://bugs.webkit.org/show_bug.cgi?id=115918
1523
1524         Reviewed by Gustavo Noronha Silva.
1525
1526         Due to layer violations and circular dependencies the TestWebCores requires for the libraries containing
1527         the built code of the intertwining Platform and WebCore layers to be specified multiple times when linking.
1528         This can be avoided by packing the two layers' archives into one big archive, named after the WebCore layer
1529         due to no clear boundary between it and the Platform layer. The big archive can then be specified only once
1530         when linking, simplifying the code and suppressing all the layering violations so they do not cause build
1531         problems.
1532
1533         First the libtool libraries that the WebCore layer (as required by the TestWebCore) depends on are specified.
1534         These are then used as dependencies for the archive creation rule as well as the list from which the archive
1535         file paths are constructed and then used to dump the member files from these archives. The member files are
1536         then added to the big archive. The latter is added to the list of libraries the TestWebCore requires to
1537         successfully link.
1538
1539         * TestWebKitAPI/GNUmakefile.am:
1540
1541 2013-05-13  Anders Carlsson  <andersca@apple.com>
1542
1543         Remove UnusedParam.h
1544         https://bugs.webkit.org/show_bug.cgi?id=116029
1545
1546         Reviewed by Andreas Kling.
1547
1548         Stop including UnusedParam.h.
1549
1550         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1551         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1552
1553 2013-05-12  Commit Queue  <commit-queue@webkit.org>
1554
1555         Unreviewed, rolling out r149955.
1556         http://trac.webkit.org/changeset/149955
1557         https://bugs.webkit.org/show_bug.cgi?id=115990
1558
1559         Broke lots of tests (Requested by smfr on #webkit).
1560
1561         * Scripts/webkitpy/port/mac.py:
1562
1563 2013-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1564
1565         [GTK] Remove unnecessary GTK_CHECK_VERSION #ifdefs
1566         https://bugs.webkit.org/show_bug.cgi?id=115914
1567
1568         Reviewed by Martin Robinson.
1569
1570         * GtkLauncher/main.c:
1571         (createToolbar):
1572         * MiniBrowser/gtk/BrowserWindow.c:
1573         (_BrowserWindow):
1574         (browserWindowSetStatusText):
1575         (fullScreenMessageTimeoutCallback):
1576         (webViewEnterFullScreen):
1577         (webViewLeaveFullScreen):
1578         (browserWindowFinalize):
1579         (browserWindowConstructed):
1580         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1581         (WTR::EventSenderProxy::mouseScrollBy):
1582         (WTR::EventSenderProxy::continuousMouseScrollBy):
1583
1584 2013-05-11  Anders Carlsson  <andersca@apple.com>
1585
1586         Crash when terminating a process that has not been fully launched
1587         https://bugs.webkit.org/show_bug.cgi?id=115962
1588         <rdar://problem/13660916>
1589
1590         Reviewed by Andreas Kling.
1591
1592         Add TerminateTwice, a test that terminates a page, then reloads it and terminates it again
1593         before the process has had a chance to be fully launched.
1594
1595         * TestWebKitAPI/GNUmakefile.am:
1596         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1597         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Added.
1598         (TestWebKitAPI):
1599         (TestWebKitAPI::didFinishLoadForFrame):
1600         (TestWebKitAPI::TEST):
1601         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
1602
1603 2013-05-10  Laszlo Gombos  <l.gombos@samsung.com>
1604
1605         Remove Mac OS X Leopard (10.5) support
1606         https://bugs.webkit.org/show_bug.cgi?id=107964
1607
1608         Reviewed by Ryosuke Niwa.
1609
1610         Removed the code for 10.5 and removed if-def for 10.6.
1611
1612         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
1613         (convertMIMEType):
1614         (createXMLStringFromWebArchiveData):
1615         * DumpRenderTree/mac/TestRunnerMac.mm:
1616         (TestRunner::authenticateSession):
1617         (TestRunner::setTextDirection):
1618         * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
1619         (convertMIMEType):
1620         (createXMLStringFromWebArchiveData):
1621
1622 2013-05-10  Brent Fulgham  <bfulgham@apple.com>
1623
1624         [Windows] Allow VS2010 Build to use VS2005 Support Libraries
1625         https://bugs.webkit.org/show_bug.cgi?id=115935
1626
1627         Reviewed by Jer Noble.
1628
1629         * WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Added.
1630         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add reference
1631         to the new manifest file.
1632         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
1633
1634 2013-05-10  Jacky Jiang  <zhajiang@blackberry.com>
1635
1636         Fix some compiler warnings (miscellaneous)
1637         https://bugs.webkit.org/show_bug.cgi?id=80790
1638
1639         Reviewed by Rob Buis.
1640
1641         Fix the following warnings for BlackBerry:
1642         DumpRenderTree.cpp:357:42: warning: suggest parentheses around assignment
1643         used as truth value [-Wparentheses].
1644
1645         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1646         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
1647
1648 2013-05-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1649
1650         [WK2][CoordinatedGraphics] WKViewSetThemePath is EFL specific
1651         https://bugs.webkit.org/show_bug.cgi?id=115928
1652
1653         Reviewed by Kenneth Rohde Christiansen.
1654
1655         WKViewSetThemePath was moved to WKViewEfl.h.
1656
1657         * TestWebKitAPI/efl/PlatformWebView.cpp:
1658
1659 2013-05-10  Andreas Kling  <akling@apple.com>
1660
1661         I accidentally the Java testing.
1662
1663         * Scripts/webkitpy/port/mac.py:
1664
1665 2013-05-10  Brian Holt  <brian.holt@samsung.com>
1666
1667         [GTK] Module Cairo fails to build under jhbuild
1668         https://bugs.webkit.org/show_bug.cgi?id=115854
1669
1670         Reviewed by Martin Robinson.
1671
1672         Make cairo depend on glib in jhbuild.modules.
1673
1674         * gtk/jhbuild.modules:
1675
1676 2013-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1677
1678         [GTK] Remove unnecessary GLIB_CHECK_VERSION #ifdefs
1679         https://bugs.webkit.org/show_bug.cgi?id=115904
1680
1681         Reviewed by Martin Robinson.
1682
1683         * ImageDiff/gtk/ImageDiff.cpp:
1684         (main):
1685
1686 2013-05-10  Balazs Kelemen  <kbalazs@webkit.org>
1687
1688         Add my new address to contributors.json. (Unreviewed)
1689
1690         * Scripts/webkitpy/common/config/contributors.json:
1691
1692 2013-05-10  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1693
1694         Unreviewed. Move myself to the reviewers list.
1695
1696         * Scripts/webkitpy/common/config/contributors.json:
1697
1698 2013-05-10  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1699
1700         Unreviewed. Add my email to a few watchlists.
1701
1702         * Scripts/webkitpy/common/config/watchlist:
1703
1704 2013-05-10  Simon Pena  <simon.pena@samsung.com>
1705
1706         Unicode support missing from string representation of Contributors in committers.py
1707         https://bugs.webkit.org/show_bug.cgi?id=115859
1708
1709         Reviewed by Darin Adler.
1710
1711         Contributors, in committers.py, provided a string representation in __str__ which
1712         didn't support unicode characters, so printing a contributor would fail in that case.
1713         This patch implements __unicode__ and makes __str__ use it to represent a contributor.
1714         The unit tests are updated accordingly, so they ensure that a unicode name can be shown.
1715
1716         * Scripts/webkitpy/common/config/committers.py: Move the existing string representation
1717         to the newly implemented method __unicode__, and make __str__ display its utf-8 encoded
1718         representation.
1719         (Contributor.__str__):
1720         (Contributor):
1721         (Contributor.__unicode__):
1722         * Scripts/webkitpy/common/config/committers_unittest.py: Add a new test that checks that
1723         a contributor with unicode characters can be represented as a string.
1724         (CommittersTest):
1725         (CommittersTest.test_contributor_encoding):
1726
1727 2013-05-09  Patrick Gansterer  <paroga@webkit.org>
1728
1729         [WIN][DRT] Remove duplicated (start|stop)JavaScriptThreads()
1730         https://bugs.webkit.org/show_bug.cgi?id=92371
1731
1732         Reviewed by Brent Fulgham.
1733
1734         Use JavaScriptThreading.cpp where the same functionality is
1735         implemented too. This reduces the dependency on the pthread
1736         library. Also replace assert() with WebKit ASSERT().
1737
1738         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1739         * DumpRenderTree/win/DumpRenderTree.cpp:
1740         (dumpHistoryItem):
1741         (dumpBackForwardList):
1742         * DumpRenderTree/win/DumpRenderTree.vcproj:
1743
1744 2013-05-09  Patrick Gansterer  <paroga@webkit.org>
1745
1746         [DRT] Replace JavaScriptThreadingPthreads.cpp with JavaScriptThreading.cpp
1747         https://bugs.webkit.org/show_bug.cgi?id=92505
1748
1749         Reviewed by Brent Fulgham.
1750
1751         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1752         * DumpRenderTree/JavaScriptThreading.cpp: Copied from DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp.
1753         (javaScriptThreadsMutex):
1754         (javaScriptThreads):
1755         (runJavaScriptThread):
1756         (startJavaScriptThreads):
1757         (stopJavaScriptThreads):
1758         * DumpRenderTree/pthreads: Removed.
1759         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Removed.
1760
1761 2013-05-09  Mario Sanchez Prada  <mario.prada@samsung.com>
1762
1763         Unreviewed. Update Simon Pena email on his behalf.
1764
1765         * Scripts/webkitpy/common/config/contributors.json:
1766
1767 2013-05-09  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1768
1769         Add support for [NoInterfaceObject] Web IDL extended attribute
1770         https://bugs.webkit.org/show_bug.cgi?id=115714
1771
1772         Reviewed by Kentaro Hara.
1773
1774         Update BindingsTests.generate_supplemental_dependency() to pass an
1775         additional windowConstructorsFile argument to preprocess-idls.pl.
1776
1777         * Scripts/webkitpy/bindings/main.py:
1778         (BindingsTests.generate_supplemental_dependency):
1779         (BindingsTests.main):
1780
1781 2013-05-09  ChangSeok Oh  <changseok.oh@collabora.com>
1782
1783         [GTK][AC] Buildfix after r149694
1784         https://bugs.webkit.org/show_bug.cgi?id=115797
1785
1786         Reviewed by Gustavo Noronha Silva.
1787
1788         Add CLUTTER_LIBS for linking TestWebCore.
1789
1790         * TestWebKitAPI/GNUmakefile.am:
1791
1792 2013-05-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1793
1794         [EFL] Remove unnecessary pkgs in EFL jhbuild
1795         https://bugs.webkit.org/show_bug.cgi?id=114908
1796
1797         Reviewed by Laszlo Gombos.
1798
1799         p11-kit, libgpg-error and libgcrypt don't influence on layout test. So, we don't need to
1800         handle them using jhbuild. We can reduce build time when using --update-efl.
1801
1802         * efl/jhbuild.modules:
1803
1804 2013-05-08  Seokju Kwon  <seokju.kwon@gmail.com>
1805
1806         [EFL] Disable SHADOW DOM feature in FeatureList.pm
1807         https://bugs.webkit.org/show_bug.cgi?id=115834
1808
1809         Reviewed by Gyuyoung Kim.
1810
1811         * Scripts/webkitperl/FeatureList.pm:
1812
1813 2013-05-08  Lucas Forschler  <lforschler@apple.com>
1814
1815         Add Scheduler for Mac MtnLion 32bit Release builder.
1816         
1817         Unreviewed.
1818         
1819         * BuildSlaveSupport/build.webkit.org-config/config.json:
1820
1821 2013-05-08  Denis Nomiyama  <d.nomiyama@samsung.com>
1822
1823         Update JSCIdentifier pretty printer in Tools/gdb/webkit.py
1824         https://bugs.webkit.org/show_bug.cgi?id=115808
1825
1826         Reviewed by Darin Adler.
1827
1828         The pretty printer for the JSCIdentifier in Tools/gdb/webkit.py
1829         was left outdated after r127191, when the m_string member was changed
1830         from UString to String. This patch calls the right pretty printer for it.
1831
1832         * gdb/webkit.py:
1833         (JSCIdentifierPrinter.to_string): Use WTFPrettyPrinter instead of
1834         WTFImplPrettyPrinter.
1835
1836 2013-05-08  Andy Estes  <aestes@apple.com>
1837
1838         [WebKit2] REGRESSION (Custom Protocols): Reproducible crash when navigating to URL with an invalid scheme
1839         https://bugs.webkit.org/show_bug.cgi?id=115790
1840
1841         Reviewed by Alexey Proskuryakov.
1842
1843         Added two API tests:
1844
1845         1) Verify that +[WKBrowsingContextController (un)registerSchemeForCustomProtocol:] can be called with a nil NSString without crashing.
1846         2) Verify that +[WKCustomProtocol canInitWithRequest:] does not crash when passed an NSURLRequest with an invalid scheme.
1847
1848         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1849         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm: Added.
1850         (TestWebKitAPI):
1851         (TestWebKitAPI::TEST):
1852         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp: Added.
1853         (TestWebKitAPI):
1854         (TestWebKitAPI::decidePolicyForNavigationAction):
1855         (CustomProtocolInvalidSchemeTest):
1856         (TestWebKitAPI::CustomProtocolInvalidSchemeTest::CustomProtocolInvalidSchemeTest):
1857
1858 2013-05-08  Lucas Forschler  <lforschler@apple.com>
1859
1860         Teach buildbot how to compile 32-bit on Mac.
1861
1862         Reviewed by Ryosuke Niwa.
1863
1864         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1865         (CompileWebKit.start):
1866         (ExtractTestResultsAndLeaks):
1867
1868 2013-05-08  Eli Fidler  <efidler@blackberry.com>
1869
1870         [BlackBerry] Fix usage of BlackBerry::Platform::String
1871         https://bugs.webkit.org/show_bug.cgi?id=115781
1872
1873         Reviewed by Rob Buis.
1874
1875         BlackBerry PRs 304193 and 327181
1876         Internally Reviewed by Mike Lattanzio, Arvid Nilsson, Joe Mason, Jeff Rogers, and George Staikos
1877
1878         We currently have a problem where we're passing UTF-8 encoded data into
1879         the char* constructors of BlackBerry::Platform::String. This means the string
1880         thinks its data is not UTF-8.
1881
1882         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1883         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
1884         (BlackBerry::WebKit::dumpHistoryItem):
1885         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1886         (TestRunner::setUserStyleSheetLocation):
1887         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
1888         (LoadHTMLStringItem::invoke):
1889
1890 2013-05-08  Alberto Garcia  <agarcia@igalia.com>
1891
1892         Tools: add new BlackBerry include dirs.
1893         https://bugs.webkit.org/show_bug.cgi?id=115514
1894
1895         Reviewed by Rob Buis.
1896
1897         iType include dirs are missing, and HarfBuzz needs to be fixed.
1898
1899         * Scripts/webkitdirs.pm:
1900         (blackberryCMakeArguments):
1901
1902 2013-05-08  José Dapena Paz  <jdapena@igalia.com> and Zan Dobersek  <zdobersek@igalia.com>
1903
1904         [GTK] Plumb the Automake build system for the Battery Status API feature
1905         https://bugs.webkit.org/show_bug.cgi?id=115718
1906
1907         Reviewed by Martin Robinson.
1908
1909         * Scripts/webkitdirs.pm:
1910         (buildAutotoolsProject): List battery-status as a configurable feature, meaning its value will be adjusted
1911         through the --(enable|disable)-battery-status flag passed to configure.
1912
1913 2013-05-08  Ryosuke Niwa  <rniwa@webkit.org>
1914
1915         new-run-webkit-websocketserver doesn't work after Chromium removal
1916         https://bugs.webkit.org/show_bug.cgi?id=115816
1917
1918         Reviewed by Joseph Pecoraro.
1919
1920         Fix the bug by instantiating the correct port object.
1921
1922         * Scripts/new-run-webkit-websocketserver:
1923         (main):
1924
1925 2013-05-07  Lucas Forschler  <lforschler@apple.com>
1926
1927         Configure buildbot for 32bit builder.
1928         https://bugs.webkit.org/show_bug.cgi?id=115769
1929         
1930         Reviewed by Ryosuke Niwa.
1931
1932         * BuildSlaveSupport/build.webkit.org-config/config.json:
1933
1934 2013-05-08  Brent Fulgham  <bfulgham@webkit.org>
1935
1936         Unreviewed. Update to show my apple.com address.
1937
1938         * Scripts/webkitpy/common/config/contributors.json: Added
1939         my apple.com e-mail address.
1940
1941 2013-05-08  David Kilzer  <ddkilzer@apple.com>
1942
1943         BUILD FIX (r149579): Use Vector::appendVector() instead of Vector::append()
1944
1945         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1946         (concatenateAttributeAndValue): Switch to appendVector().
1947
1948 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
1949
1950         [Qt][WTR] Fix the build on Mac after r149692
1951
1952         Unreviewed build fix.
1953
1954         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1955         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
1956
1957 2013-05-08  Mario Sanchez Prada  <mario.prada@samsung.com>
1958
1959         Unreviewed. Added Anton Obzhirov to the list of contributors and myself
1960         to the watchlist for Accessibility.
1961
1962         * Scripts/webkitpy/common/config/contributors.json: Added Anton Obzhirov.
1963         * Scripts/webkitpy/common/config/watchlist: Added myself.
1964
1965 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
1966
1967         [Qt] Build fails with clang
1968         https://bugs.webkit.org/show_bug.cgi?id=115741
1969
1970         Reviewed by Benjamin Poulain.
1971
1972         Since r149112 std::move is used in AtomicString for compilers that
1973         support rvalue references and this requires a standard library
1974         implementing c++11 move semantics.
1975         We only explicitely require c++11 for WebKit2, but since clang supports
1976         rvalue references the build of subtargets using AtomicString fails because
1977         of missing std::move.
1978         It is safe to add CONFIG += c++11 for the whole project when using clang
1979         since we explicitely disable c++11 for ANGLE that had probems with libc++.
1980
1981         * qmake/mkspecs/features/unix/default_pre.prf:
1982
1983 2013-05-08  Darin Adler  <darin@apple.com>
1984
1985         Fix one more place that needed to use adoptCF/NS
1986         https://bugs.webkit.org/show_bug.cgi?id=115778
1987
1988         Reviewed by Benjamin Poulain.
1989
1990         Not sure why I missed this code last time, but found a bit more code that needs
1991         to switch to the newer style adoptCF/NS.
1992
1993         * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
1994         (convertWebResourceDataToString): Use adoptCF.
1995         (convertWebResourceResponseToDictionary): Ditto.
1996         (createXMLStringFromWebArchiveData): Ditto.
1997         * WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm:
1998         (createCFURLResponseFromResponseData): Use adoptNS and adoptCF.
1999
2000 2013-05-08  Commit Queue  <commit-queue@webkit.org>
2001
2002         Unreviewed, rolling out r149271.
2003         http://trac.webkit.org/changeset/149271
2004         https://bugs.webkit.org/show_bug.cgi?id=115780
2005
2006         The mangled symbols are now enforced through LDFLAGS
2007         (Requested by zdobersek on #webkit).
2008
2009         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
2010
2011 2013-05-08  Zan Dobersek  <zdobersek@igalia.com>
2012
2013         [Flakiness Dashboard] Remove the Chromium fallback platforms listing from the legend popup
2014         https://bugs.webkit.org/show_bug.cgi?id=115636
2015
2016         Reviewed by Ryosuke Niwa.
2017
2018         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2019         (showLegend): Remove the listing of the Chromium fallback platforms from the legend popup. The code iterated
2020         through the platforms in the g_fallbacksMap dictionary to construct this part of the legend, but the dictionary,
2021         while Chromium-specific, can't be removed just yet as there's more code that uses it.
2022
2023 2013-05-06  Darin Adler  <darin@apple.com>
2024
2025         Use adoptCF and adoptNS in more places, test code and code not compiled on Mac
2026         https://bugs.webkit.org/show_bug.cgi?id=115657
2027
2028         Reviewed by Sam Weinig.
2029
2030         This is similar to my last set of changes, but covers code that I missed with
2031         global replace using the Safari Xcode workspace.
2032
2033         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
2034         (convertWebResourceDataToString):
2035         (convertWebResourceResponseToDictionary):
2036         (createXMLStringFromWebArchiveData):
2037         * DumpRenderTree/cg/ImageDiffCG.cpp:
2038         (createImageFromStdin):
2039         (createDifferenceImage):
2040         (main):
2041         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2042         (printPNG):
2043         (dumpBitmap):
2044         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2045         (BitmapContext::BitmapContext):
2046         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
2047         (-[MockWebNotificationProvider init]):
2048         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2049         (createBitmapContext):
2050         * DumpRenderTree/mac/TestRunnerMac.mm:
2051         (TestRunner::addDisallowedURL):
2052         (TestRunner::applicationCacheDiskUsageForOrigin):
2053         (TestRunner::localStorageDiskUsageForOrigin):
2054         (TestRunner::clearApplicationCacheForOrigin):
2055         (TestRunner::deleteLocalStorageForOrigin):
2056         (TestRunner::copyDecodedHostName):
2057         (TestRunner::copyEncodedHostName):
2058         (TestRunner::queueLoad):
2059         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
2060         (TestRunner::setMockGeolocationPositionUnavailableError):
2061         (TestRunner::setUserStyleSheetLocation):
2062         (TestRunner::setValueForUser):
2063         (TestRunner::overridePreference):
2064         (TestRunner::setPersistentUserStyleSheetLocation):
2065         (TestRunner::execCommand):
2066         (TestRunner::findString):
2067         (TestRunner::isCommandEnabled):
2068         (TestRunner::addOriginAccessWhitelistEntry):
2069         (TestRunner::removeOriginAccessWhitelistEntry):
2070         (TestRunner::addUserScript):
2071         (TestRunner::addUserStyleSheet):
2072         (TestRunner::evaluateInWebInspector):
2073         (TestRunner::evaluateScriptInIsolatedWorld):
2074         (TestRunner::apiTestNewWindowDataLoadBaseURL):
2075         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
2076         (TestRunner::authenticateSession):
2077         (TestRunner::grantWebNotificationPermission):
2078         (TestRunner::denyWebNotificationPermission):
2079         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
2080         (createCFURLResponseFromResponseData):
2081         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2082         (LoadItem::invoke):
2083         (LoadHTMLStringItem::invoke):
2084         (ScriptItem::invoke):
2085         * DumpRenderTree/win/DumpRenderTree.cpp:
2086         (substringFromIndex):
2087         (urlSuitableForTestResult):
2088         (lastPathComponent):
2089         (sharedCFURLCache):
2090         * DumpRenderTree/win/ImageDiffCairo.cpp:
2091         (createImageFromStdin):
2092         (main):
2093         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2094         (createBitmapContextFromWebView):
2095         * DumpRenderTree/win/TestRunnerWin.cpp:
2096         (TestRunner::setUserStyleSheetLocation):
2097         (TestRunner::setPersistentUserStyleSheetLocation):
2098         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2099         (TestWebKitAPI::TEST):
2100         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
2101         (TestWebKitAPI::TEST):
2102         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
2103         (TestWebKitAPI::TEST):
2104         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
2105         (TestWebKitAPI::TEST):
2106         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
2107         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2108         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
2109         (TestWebKitAPI::createWindow):
2110         (TestWebKitAPI::TEST):
2111         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
2112         (TestWebKitAPI::TEST):
2113         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
2114         (TestWebKitAPI::AcceptsFirstMouse::runTest):
2115         * TestWebKitAPI/Tests/mac/AttributedString.mm:
2116         (TestWebKitAPI::TEST):
2117         * TestWebKitAPI/Tests/mac/BackForwardList.mm:
2118         (TestWebKitAPI::TEST):
2119         * TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm:
2120         (TestWebKitAPI::TEST):
2121         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
2122         (TestWebKitAPI::TEST):
2123         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm:
2124         (TestWebKitAPI::TEST):
2125         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
2126         (TestWebKitAPI::TEST):
2127         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm:
2128         (TestWebKitAPI::TEST):
2129         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
2130         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
2131         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
2132         (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow):
2133         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
2134         (TestWebKitAPI::TEST):
2135         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
2136         (TestWebKitAPI::TEST):
2137         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
2138         (TestWebKitAPI::TEST):
2139         * TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.mm:
2140         (TestWebKitAPI::TEST):
2141         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
2142         (TestWebKitAPI::TEST):
2143         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2144         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
2145         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
2146         (TestWebKitAPI::TEST):
2147         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
2148         (TestWebKitAPI::TEST):
2149         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
2150         (TestWebKitAPI::TEST):
2151         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
2152         (TestWebKitAPI::TEST):
2153         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
2154         (TestWebKitAPI::TEST):
2155         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
2156         (TestWebKitAPI::TEST):
2157         * TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm:
2158         (TestWebKitAPI::TEST):
2159         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2160         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
2161         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2162         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
2163         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
2164         * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
2165         (WTR::testPathFromURL):
2166         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2167         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2168         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2169         (WTR::createCGContextFromImage):
2170         (WTR::dumpBitmap):
2171         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2172         * WebKitTestRunner/mac/EventSenderProxy.mm:
2173         (WTR::EventSenderProxy::mouseScrollBy):
2174         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2175         (WTR::PlatformWebView::windowSnapshotImage):
2176         * WebKitTestRunner/win/TestControllerWin.cpp:
2177         (WTR::TestController::initializeTestPluginDirectory):
2178         Use adoptCF and adoptNS.
2179
2180 2013-05-07  Alex Christensen  <achristensen@apple.com>
2181
2182         Fix a memory leak introduced in r149692
2183         https://bugs.webkit.org/show_bug.cgi?id=115766
2184
2185         Reviewed by Mark Rowe.
2186
2187         In r149692, the fix for <http://webkit.org/b/42324>, a call to WKBundleFrameCopyWebArchive was added without any 
2188         matching call to WKRelease. An earlier attempted fix in r149697 introduced a RetainPtr but failed to adopt the object.
2189
2190         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2191         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
2192         Fix the memory leak by switching to WKRetainPtr and adopting the returned object.
2193
2194 2013-05-07  Darin Adler  <darin@apple.com>
2195
2196         [Win] Fix storage leak in Windows DumpRenderTree
2197         https://bugs.webkit.org/show_bug.cgi?id=115651
2198
2199         Reviewed by Sam Weinig.
2200
2201         * DumpRenderTree/win/DumpRenderTree.cpp:
2202         (lastPathComponent): Added a missing call to adoptCF.
2203
2204 2013-05-07  Alex Christensen  <achristensen@apple.com>
2205
2206         fixed a memory leak introduced by bug 42324 by using a RetainPtr
2207         https://bugs.webkit.org/show_bug.cgi?id=115760
2208
2209         Reviewed by Tim Horton.
2210
2211         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2212         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
2213         fixed memory leak, added UNUSED_PARAM macros
2214
2215 2013-05-07  Alex Christensen  <achristensen@apple.com>
2216
2217         WebKitTestRunner needs testRunner.dumpDOMAsWebArchive
2218         https://bugs.webkit.org/show_bug.cgi?id=42324
2219         <rdar://problem/8193633>
2220
2221         Reviewed by Tim Horton.
2222
2223         * Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2224         Added dumpDOMAsWebArchive JavaScript function to be called by test cases.
2225         * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2226         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
2227         Added dumpDOMAsWebArchive code that is called when dumping.        
2228         (WTR::InjectedBundlePage::dump):
2229         Made DOMAsWebArchive case when dumping call dumpDOMAsWebArchive.
2230         * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2231         (InjectedBundlePage):
2232         Added dumpDOMAsWebArchive declaration.
2233         * Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
2234         (WTR::TestRunner::dumpDOMAsWebArchive):
2235         Added dumpDOMAsWebArchive JS callback function that sets m_whatToDump to DOMAsWebArchive.
2236         * Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2237         Added WebArchiveDumpSupport.cpp, WebArchiveDumpSupport.h, WebArchiveDumpSupportMac.mm to project.
2238         * Tools/WebKitTestRunner/cf: Added.
2239         * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.cpp: Added.
2240         Copied from Tools/DumpRenderTree/cf for createXMLStringFromWebArchiveData and other functions it uses.
2241         (convertMIMEType):
2242         (convertWebResourceDataToString):
2243         (normalizeHTTPResponseHeaderFields):
2244         (normalizeWebResourceURL):
2245         (convertWebResourceResponseToDictionary):
2246         (compareResourceURLs):
2247         (createXMLStringFromWebArchiveData):
2248         * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.h: Added.
2249         Copied from Tools/DumpRenderTree/cf for used symbol declarations.
2250         * Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm: Added.
2251         Copied from Tools/DumpRenderTree/mac for used functions.
2252         (createCFURLResponseFromResponseData):
2253         (supportedNonImageMIMETypes):
2254
2255 2013-05-07  Alex Christensen  <achristensen@apple.com>
2256
2257         Updated style of WebArchiveDumpSupport before putting it into WebKitTestRunner.
2258         https://bugs.webkit.org/show_bug.cgi?id=115745
2259
2260         Reviewed by Tim Horton.
2261
2262         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
2263         (compareResourceURLs):
2264         Updated style.
2265
2266 2013-05-06  Ryosuke Niwa  <rniwa@webkit.org>
2267
2268         Add an 'isReadOnly' member to IDL parse tree structure
2269         https://bugs.webkit.org/show_bug.cgi?id=115704
2270
2271         Reviewed by Kentaro Hara.
2272
2273         Use newly added isReadOnly attribute.
2274
2275         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2276         (_generateHeaderFile):
2277         (_generateImplementationFile):
2278         (_staticValuesGetterImplementation):
2279
2280 2013-05-07  Anders Carlsson  <andersca@apple.com>
2281
2282         Remove AlwaysInline.h from WTF
2283         https://bugs.webkit.org/show_bug.cgi?id=115727
2284
2285         Reviewed by Brent Fulgham.
2286
2287         The macro that used to be in AlwaysInline.h is now in Compiler.h so there's no reason
2288         to keep AlwaysInline.h around anymore.
2289
2290         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
2291         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
2292
2293 2013-05-07  Andras Becsi  <andras.becsi@digia.com>
2294
2295         [Qt][WTR] QQuickWindowPrivate::setRenderWithoutShowing has been removed from Qt 5
2296         https://bugs.webkit.org/show_bug.cgi?id=114808
2297
2298         Reviewed by Jocelyn Turcotte.
2299
2300         QQuickWindow::grabWindow() has been implemented for isVisible=false for Qt 5.1.
2301         (https://codereview.qt-project.org/#change,54234)
2302
2303         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2304         (WTR::WrapperWindow::handleStatusChanged):
2305
2306 2013-05-06  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2307
2308         Unreviewed. Add my email to EFL and BindingsScripts watchlists.
2309
2310         * Scripts/webkitpy/common/config/watchlist:
2311
2312 2013-05-06  Kangil Han  <kangil.han@samsung.com>
2313
2314         [EFL][WK1][PerformanceTests] Adopt --no-timeout option implementation to DumpRenderTree
2315         https://bugs.webkit.org/show_bug.cgi?id=115645
2316
2317         Reviewed by Gyuyoung Kim.
2318
2319         To run performance tests in wk1, we need --no-timeout option implementation.
2320         So adopt it from gtk+ port.
2321
2322         * DumpRenderTree/efl/DumpRenderTree.cpp:
2323         (shouldSetWaitToDumpWatchdog):
2324         (parseCommandLineOptions):
2325         * DumpRenderTree/efl/DumpRenderTreeEfl.h:
2326         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2327         (TestRunner::setWaitToDump):
2328
2329 2013-05-06  Commit Queue  <commit-queue@webkit.org>
2330
2331         Unreviewed, rolling out r149547.
2332         http://trac.webkit.org/changeset/149547
2333         https://bugs.webkit.org/show_bug.cgi?id=115682
2334
2335         Added unittests that fail on bots and spits out text into
2336         stdout (Requested by rniwa on #webkit).
2337
2338         * Scripts/import-w3c-tests: Removed.
2339         * Scripts/webkitpy/w3c/__init__.py: Removed.
2340         * Scripts/webkitpy/w3c/test_converter.py: Removed.
2341         * Scripts/webkitpy/w3c/test_converter_unittest.py: Removed.
2342         * Scripts/webkitpy/w3c/test_importer.py: Removed.
2343         * Scripts/webkitpy/w3c/test_importer_unittest.py: Removed.
2344         * Scripts/webkitpy/w3c/test_parser.py: Removed.
2345         * Scripts/webkitpy/w3c/test_parser_unittest.py: Removed.
2346
2347 2013-05-03  Gustavo Noronha Silva  <gns@gnome.org>
2348
2349         [jhbuild] bump jhbuild version to take advantage of new improvements
2350         https://bugs.webkit.org/show_bug.cgi?id=115558
2351
2352         Reviewed by Martin Robinson.
2353
2354         One of the important improvements is jhbuild no longer fetches git
2355         repositories if they are already at the expected revision, which should
2356         make the EWS bots more robust to git servers unavailability.
2357
2358         * jhbuild/jhbuild-wrapper: bump jhbuild to 496974221c3a8ac4fbbc3b0a577c71cac224130d.
2359
2360 2013-05-06  Manuel Rego Casasnovas  <rego@igalia.com>
2361
2362         [GTK] Add webkit_uri_scheme_request_finish_error
2363         https://bugs.webkit.org/show_bug.cgi?id=94316
2364
2365         Reviewed by Anders Carlsson.
2366
2367         * MiniBrowser/gtk/main.c:
2368         (miniBrowserErrorQuark): Add function to create a global quark for
2369         MiniBrowser.
2370         (aboutURISchemeRequestCallback): Update MiniBrowser to use the new
2371         function webkit_uri_scheme_request_finish_error().
2372
2373 2013-05-06  Mike Lattanzio  <mlattanzio@blackberry.com>
2374
2375         [BlackBerry] Enable and Expose Text Autosizing through BlackBerry::WebKit::WebSettings
2376         https://bugs.webkit.org/show_bug.cgi?id=113808
2377
2378         Reviewed by Rob Buis.
2379
2380         Modify FeatureList.pm and set ENABLE_TEXT_AUTOSIZING to default
2381         to true for BlackBerry.
2382
2383         * Scripts/webkitperl/FeatureList.pm:
2384
2385 2013-05-06  Jessie Berlin  <jberlin@apple.com>
2386
2387         check-webkit-style should complain about a layering violation if platform-specific guards are
2388         used in WebCore outside of the platform directory
2389         https://bugs.webkit.org/show_bug.cgi?id=115567
2390
2391         Reviewed by Benjamin Poulain.
2392
2393         * Scripts/webkitpy/style/checkers/cpp.py:
2394         (check_for_webcore_platform_layering_violation):
2395         If the file is in WebCore but not in platform and contains #if PLATFORM(SOMETHING), emit an error.
2396         (process_line):
2397         Add the check_for_webcore_platform_layering_violation.
2398         (CppChecker):
2399         List the new check.
2400
2401         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2402         (CppStyleTest.test_webcore_platform_layering_violation):
2403         Add tests.
2404
2405 2013-05-06  David Kilzer  <ddkilzer@apple.com>
2406
2407         webkit-patch: fix 'upload' command with Bugzilla 4.2.5
2408         <http://webkit.org/b/115667>
2409
2410         Reviewed by Dirk Pranke.
2411
2412         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2413         (Bugzilla._check_create_bug_response): Update regex to work with
2414         Bugzilla 3.2.3 and 4.2.5.
2415         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2416         (test__check_create_bug_response): Add new test that covers both
2417         old and new <title> variations.
2418
2419 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
2420
2421         [Flakiness Dashboard] Stop decoding SnowLeopard builder names into platforms
2422         https://bugs.webkit.org/show_bug.cgi?id=115661
2423
2424         Reviewed by Ryosuke Niwa.
2425
2426         The Apple Mac Snow Leopard builders are no long present so there's no need to try to decode such
2427         builders into the APPLE_MAC_SNOW_LEOPARD platforms. Instead, check for the Mountain Lion builders
2428         and decode their names into the APPLE_MAC_MOUNTAIN_LION platforms.
2429
2430         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2431         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2432
2433 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
2434
2435         [Flakiness Dashboard] Remove everything Chromium from the builders.json-generating script
2436         https://bugs.webkit.org/show_bug.cgi?id=114603
2437
2438         Reviewed by Ryosuke Niwa.
2439
2440         * TestResultServer/generate_builders_json.py:
2441         (insert_builder_and_test_data): Only process the 'layout-tests' steps, but force the name that's used
2442         to represent these to be 'layout-test', for backwards compatibility.
2443         (main): Remove all the build.chromium.org masters.
2444         * TestResultServer/generate_builders_json_unittest.py: Clean up the Chromium-related test cases and update other ones.
2445         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
2446         (GenerateBuildersJsonTest):
2447         (GenerateBuildersJsonTest.test_generate_json_data):
2448         * TestResultServer/static-dashboards/builders.jsonp: Updated after changes to the script, now only lists the
2449         test-running builders from the webkit.org master.
2450
2451 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
2452
2453         [Flakiness Dashboard] Update expected outcome in a couple of unit tests after r148778
2454         https://bugs.webkit.org/show_bug.cgi?id=114988
2455
2456         Reviewed by Ryosuke Niwa.
2457
2458         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Update the expected platforms list, the Chromium
2459         and Apple Mac Snow Leopard platforms were removed with the Apple Mac Mountain Lion platform being added.
2460         * TestResultServer/static-dashboards/loader_unittests.js: Update the list of the expected loaded expectations platforms,
2461         mac-snowleopard isn't loaded anymore due to the support for the platform being removed, while the mac-wk2 is loaded twice,
2462         once for the Apple Mac Lion and once for the Apple Mac Mountain Lion platform.
2463
2464 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
2465
2466         [Flakiness Dashboard] Remove the remaining traces of platform modifier unions
2467         https://bugs.webkit.org/show_bug.cgi?id=114954
2468
2469         Reviewed by Ryosuke Niwa.
2470
2471         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2472         (processExpectationsForPlatform): Remove the platform tree traversal that checked for presence of the platform
2473         modifier unions in the list of modifiers.
2474         (generatePageForExpectationsUpdate): Only filter through the modifiers that do not represent build types or bug references.
2475         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Adjust the test cases for the realModifiers unit test.
2476
2477 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
2478
2479         [Flakiness Dashboard] Simplify builder-name-based platform recognition
2480         https://bugs.webkit.org/show_bug.cgi?id=114957
2481
2482         Reviewed by Ryosuke Niwa.
2483
2484         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2485         (determineBuilderPlatform): Renamed from nonChromiumPlatform.
2486         (chromiumPlatform): Removed, unnecessary.
2487         (platformAndBuildType): With Chromium builders are gone, meaning determineBuilderPlatform can be called by default
2488         to determine the platform of the builder. No need to check for 'DBG' substring in the builder name to determine whether
2489         the builder operates with debug builds, no webkit.org builders are named this way.
2490         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2491         (platformAndBuildTypes): Remove Chromium-specific test cases, reducing the number of expected assertions this test will make.
2492
2493 2013-05-06  Andy Estes  <aestes@apple.com>
2494
2495         Added two files I neglected to commit in r149589.
2496
2497         * TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
2498         * TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.
2499
2500 2013-05-04  Andy Estes  <aestes@apple.com>
2501
2502         REGRESSION (r125592): Reproducible crash in DOMWindow::open when a delegate closes the new window in decidePolicyForNavigationAction
2503         https://bugs.webkit.org/show_bug.cgi?id=115609
2504
2505         Reviewed by Oliver Hunt.
2506
2507         Added an API test.
2508
2509         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2510         * TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
2511         (+[TestDelegate shared]):
2512         (-[TestDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2513         (-[TestDelegate webView:createWebViewWithRequest:]):
2514         (TestWebKitAPI):
2515         (TestWebKitAPI::TEST):
2516         * TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.
2517
2518 2013-05-06  Antoine Quint  <graouts@apple.com>
2519
2520         Manage the presentation of the snapshotted plug-in using JavaScript
2521         https://bugs.webkit.org/show_bug.cgi?id=115548
2522
2523         Reviewed by Dean Jackson.
2524
2525         Take into account the new plugInExtraScript method added to support
2526         the injection of a JS file from the chrome client to customize the
2527         rendering of a snapshotted plug-in's shadow tree.
2528
2529         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2530         (WTR::InjectedBundlePage::InjectedBundlePage):
2531
2532 2013-05-05  Anders Carlsson  <andersca@apple.com>
2533
2534         Remove the Vector::append overload that takes a Vector
2535         https://bugs.webkit.org/show_bug.cgi?id=115535
2536
2537         Reviewed by Andreas Kling.
2538
2539         Use Vector::appendVector instead.
2540
2541         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2542         (concatenateAttributeAndValue):
2543         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2544         (WTR::concatenateAttributeAndValue):
2545
2546 2013-05-04  Sam Weinig  <sam@webkit.org>
2547
2548         REGRESSION(r148312): Crash when calling WKPageClose(page) followed by WKPageTerminate(page)
2549         <rdar://problem/13702008>
2550         https://bugs.webkit.org/show_bug.cgi?id=115607
2551
2552         Reviewed by Benjamin Poulain.
2553
2554         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2555         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp: Added.
2556         (TestWebKitAPI::didFinishLoadForFrame):
2557         (TestWebKitAPI::TEST):
2558         Add test that calls WKPageClose, follow by WKPageTerminate. If it crashes, its not working.
2559
2560 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
2561
2562         Unreviewed.
2563
2564         * Scripts/webkitpy/common/config/contributors.json: Correcting my igalia.com email address.
2565
2566 2013-05-04  Mihnea Ovidenie  <mihnea@adobe.com>
2567
2568         Unreviewed. Adding Radu Stavila as an Adobe contributor, working on CSSRegions.
2569
2570         * Scripts/webkitpy/common/config/contributors.json:
2571
2572 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
2573
2574         [GTK] Catch select.error exceptions in parse_output_lines
2575         https://bugs.webkit.org/show_bug.cgi?id=115253
2576
2577         Reviewed by Gustavo Noronha Silva.
2578
2579         Catch any select.error exceptions when waiting for the file descriptor to become readable when parsing the
2580         output lines in common.parse_output_lines. These are currently being thrown when running the GTK unit tests on
2581         builders, but are not fatal. Because of that they are at the moment only logged (writing out the file descriptor,
2582         error code and the error message) and the loop is re-entered.
2583
2584         * gtk/common.py:
2585         (parse_output_lines):
2586
2587 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
2588
2589         [GTK] Set up the TestWebCore in TestWebKitAPI
2590         https://bugs.webkit.org/show_bug.cgi?id=115237
2591
2592         Reviewed by Gustavo Noronha Silva.
2593
2594         Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
2595         Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
2596         a workaround for the layer violations and circular dependencies between various static libraries. Linking against
2597         either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
2598         shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).
2599
2600         * TestWebKitAPI/GNUmakefile.am:
2601
2602 2013-05-03  Rebecca Hauck  <rhauck@adobe.com>
2603
2604         Create a script to import W3C tests
2605         https://bugs.webkit.org/show_bug.cgi?id=111513
2606
2607         Reviewed by Dirk Pranke.
2608
2609         Script to automate the import of W3C tests into WebKit. 
2610         For the full description of how it works, see the comments
2611         at the top of test_importer.py.
2612
2613         * Scripts/import-w3c-tests: Added.
2614         * Scripts/webkitpy/w3c/__init__.py: Added.
2615         * Scripts/webkitpy/w3c/test_converter.py: Added.
2616         (TestConverter):
2617         (TestConverter.__init__):
2618         (TestConverter.load_prefixed_prop_list):
2619         (TestConverter.load_file):
2620         (TestConverter.convert_for_webkit):
2621         (TestConverter.convert_testharness_paths):
2622         (TestConverter.convert_prefixed_properties):
2623         (TestConverter.scrub_unprefixed_props):
2624         (TestConverter.replace_tag):
2625         * Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
2626         (TestConverterTest):
2627         (TestConverterTest.testLoadPrefixedPropList):
2628         (TestConverterTest.test_convertForWebkitNothingToConvert):
2629         (test_convertForWebkitHarnessOnly):
2630         (test_convertForWebkitPropsOnly):
2631         (test_convertForWebkitHarnessAndProps):
2632         (test_convertTestHarnessPaths):
2633         (test_convertPrefixedProperties):
2634         (verifyTestHarnessPaths):
2635         (verifyPrefixedProperties):
2636         (generateTestContent):
2637         * Scripts/webkitpy/w3c/test_importer.py: Added.
2638         (main):
2639         (parse_args):
2640         (validate_import_directory):
2641         (TestImporter):
2642         (TestImporter.__init__):
2643         (TestImporter.do_import):
2644         (TestImporter.get_changeset):
2645         (TestImporter.scan_source_directory):
2646         (TestImporter.import_tests):
2647         (TestImporter.setup_destination_directory):
2648         (TestImporter.get_test_status):
2649         (TestImporter.remove_deleted_files):
2650         (TestImporter.write_import_log):
2651         * Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
2652         (TestImporterTest):
2653         (TestImporterTest.test_ImportDirWithNoTests):
2654         * Scripts/webkitpy/w3c/test_parser.py: Added.
2655         (TestParser):
2656         (TestParser.__init__):
2657         (TestParser.load_file):
2658         (TestParser.analyze_test):
2659         (TestParser.get_reftests):
2660         (TestParser.is_jstest):
2661         (TestParser.get_support_files):
2662         * Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
2663         (TestParserTest):
2664         (TestParserTest.test_analyzeTestReftestOneMatch):
2665         (test_analyzeTestReftestMultipleMatches):
2666         (test_analyzeTestReftestMatchAndMismatch):
2667         (test_analyzeTestReftestWithRefSupportFiles):
2668         (test_analyzeJSTest):
2669         (test_analyzePixelTestAllTrue):
2670         (test_analyzePixelTestAllFalse):
2671         (test_analyzeNonHTMLFile):
2672
2673 2013-05-03  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2674
2675         Unreviewed. Update Viatcheslav Ostapenko's email in contributors.json.
2676
2677         * Scripts/webkitpy/common/config/contributors.json:
2678
2679 2013-05-02  Nico Weber  <thakis@chromium.org>
2680
2681         Remove a stale script file.
2682         https://bugs.webkit.org/show_bug.cgi?id=115521
2683
2684         Reviewed by Anders Carlsson.
2685
2686         This script was added in
2687         https://bugs.webkit.org/show_bug.cgi?id=17507, but it relies on the
2688         Bakefile system that was removed in
2689         https://bugs.webkit.org/show_bug.cgi?id=49983 . As a result, this
2690         script just asserts when it's run and is useless.
2691
2692         * Scripts/update-sources-list.py: Removed.
2693
2694 2013-05-01  Glenn Adams  <glenn@skynav.com>
2695
2696         [webkitpy] Need abstract base class for commands that analyze commit logs
2697         https://bugs.webkit.org/show_bug.cgi?id=115391
2698
2699         Reviewed by Benjamin Poulain.
2700
2701         Move commit log parsing functions into new abstract base class AbstractCommitLogCommand
2702         in preparation for adding two new commands that will reuse this functionality along with
2703         suggest-nominations. See https://bugs.webkit.org/show_bug.cgi?id=115387 and
2704         https://bugs.webkit.org/show_bug.cgi?id=115388.
2705
2706         No new tests as this patch does not change existing functionality or behavior.
2707
2708         * Scripts/webkitpy/tool/commands/suggestnominations.py:
2709         (AbstractCommitLogCommand): Add abstract base class for commands that analyze commit logs.
2710         (AbstractCommitLogCommand.__init__):
2711         (AbstractCommitLogCommand._init_options):
2712         (AbstractCommitLogCommand._parse_commit_message):
2713         (SuggestNominations): Move generic commit log parsing into new base class. Use new base class.
2714         (SuggestNominations.__init__): 
2715         (SuggestNominations._init_options):
2716
2717 2013-05-01  Seokju Kwon  <seokju.kwon@gmail.com>
2718
2719         Web Inspector: Fix check-inspector-strings script and fix localized strings
2720         https://bugs.webkit.org/show_bug.cgi?id=115495
2721
2722         Reviewed by Joseph Pecoraro.
2723
2724         * Scripts/check-inspector-strings:
2725
2726 2013-05-01  Zan Dobersek  <zdobersek@igalia.com>
2727
2728         [TestWebKitAPI] <WebKit2/WebKit2_C.h> being included in GTK WK1-only builds
2729         https://bugs.webkit.org/show_bug.cgi?id=115470
2730
2731         Reviewed by Martin Robinson.
2732
2733         In the TestWebKitAPI's config.h header, only include the <WebKit2/WebKit2_C.h> header when
2734         not building either of the IOS, Windows or GTK-WK1 platforms.
2735
2736         Up until now the header was included for everything but the IOS and Windows platforms due to
2737         an incorrectly stated condition regarding the GTK platform.
2738
2739         * TestWebKitAPI/config.h:
2740
2741 2013-05-01  Zan Dobersek  <zdobersek@igalia.com>
2742
2743         [GTK] Split the forwarding headers stamp in the TestWebKitAPI GNUmakefile.am
2744         https://bugs.webkit.org/show_bug.cgi?id=115469
2745
2746         Reviewed by Martin Robinson.
2747
2748         Split the stamp-testwebkitapi-forwarding-headers into two stamps, one covering forwarding headers
2749         for the WebCore tests (under the Tests/WebCore directory) and the other covering forwarding headers
2750         for the WebKit2 tests and the injected bundle required by them.
2751
2752         This makes it possible for the WebCore tests to compile when the WebKit2 build is disabled, i.e. the WebCore
2753         tests shouldn't depend on the WebKit2 build (though the forwarding headers generation script is stored
2754         under the WebKit2 code).
2755
2756         The WebCore forwarding headers are generated by scanning only the files under the Tests/WebCore directory,
2757         while the WebKit2 forwarding headers generation should keep on scanning the complete root directory of the
2758         TestWebKitAPI subproject, though the target directory should be narrowed down if at all possible.
2759
2760         * TestWebKitAPI/GNUmakefile.am:
2761
2762 2013-04-30  Glenn Adams  <glenn@skynav.com>
2763
2764         Unreviewed. Add myself to watchlist entries.
2765
2766         * Scripts/webkitpy/common/config/watchlist:
2767
2768 2013-04-30  Glenn Adams  <glenn@skynav.com>
2769
2770         [webkitpy] suggest-nominations doesn't count all qualified patches
2771         https://bugs.webkit.org/show_bug.cgi?id=115285
2772
2773         Reviewed by Benjamin Poulain.
2774
2775         Fix commit analysis so that patches made by an existing committer are counted towards reviewer
2776         nomination. Improve commit log parsing.
2777
2778         * Scripts/webkitpy/tool/commands/suggestnominations.py:
2779         (CommitLogError):
2780         (CommitLogError.__init__):
2781         (CommitLogMissingReviewer):
2782         (CommitLogMissingReviewer.__init__):
2783         (SuggestNominations):
2784         (SuggestNominations.__init__):
2785         (SuggestNominations._recent_commit_messages):
2786         (SuggestNominations._author_name_from_email):
2787         (SuggestNominations._contributor_from_email):
2788         (SuggestNominations._parse_commit_message):
2789         (SuggestNominations._count_commit):
2790         (SuggestNominations._count_recent_patches):
2791         (SuggestNominations._collect_nominations):
2792         (SuggestNominations._print_nominations):
2793         (SuggestNominations.execute):
2794         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2795         (_make_options):
2796         (test_recent_commit_messages):
2797         (test_basic):
2798
2799 2013-04-30  Commit Queue  <rniwa@webkit.org>
2800
2801         Unreviewed, rolling out r149309.
2802         http://trac.webkit.org/changeset/149309
2803         https://bugs.webkit.org/show_bug.cgi?id=115430
2804
2805         The patch does not build on WK1-only builds of the GTK port
2806         (Requested by zdobersek on #webkit).
2807
2808         * TestWebKitAPI/GNUmakefile.am:
2809
2810 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2811
2812         Stop using "in" keyword in IDL files
2813         https://bugs.webkit.org/show_bug.cgi?id=115418
2814
2815         Reviewed by Kentaro Hara.
2816
2817         Remove "in" keyword from IDL files as this is no longer part of the Web
2818         IDL specification.
2819
2820         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2821         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl:
2822         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl:
2823         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2824         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2825         * WebKitTestRunner/InjectedBundle/Bindings/GCController.idl:
2826         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2827         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
2828
2829 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2830
2831         [EFL] Enable scaled cursors
2832         https://bugs.webkit.org/show_bug.cgi?id=106242
2833
2834         Reviewed by Gyuyoung Kim.
2835
2836         Enable ENABLE_MOUSE_CURSOR_SCALE for EFL port.
2837
2838         * Scripts/webkitperl/FeatureList.pm:
2839
2840 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2841
2842         Replace "Optional" extended attribute by proper Web IDL "optional" keyword
2843         https://bugs.webkit.org/show_bug.cgi?id=115380
2844
2845         Reviewed by Kentaro Hara.
2846
2847         Replace WebKit-specific [Optional] extended attribute by Web IDL "optional"
2848         keyword.
2849
2850         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2851         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2852
2853 2013-04-30  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2854
2855         Fix the USE(3D_GRAPHICS) build with the standard OpenGL on Windows
2856         https://bugs.webkit.org/show_bug.cgi?id=114684
2857
2858         Reviewed by Simon Hausmann.
2859
2860         Remove the ANGLE requirement for USE(3D_GRAPHICS).
2861         This enables WebKit2 in the build when using a "-opengl desktop" configured Qt.
2862
2863         * qmake/mkspecs/features/features.prf:
2864
2865 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
2866
2867         [GTK] Disable Shadow DOM feature
2868         https://bugs.webkit.org/show_bug.cgi?id=115374
2869
2870         Reviewed by Martin Robinson.
2871
2872         Disable the Shadow DOM feature on the GTK port, the feature is planned for removal.
2873
2874         * Scripts/webkitperl/FeatureList.pm:
2875
2876 2013-04-29  Glenn Adams  <glenn@skynav.com>
2877
2878         [webkitpy] Add missing contributor email addresses
2879         https://bugs.webkit.org/show_bug.cgi?id=115394
2880
2881         Reviewed by Ryosuke Niwa.
2882
2883         * Scripts/webkitpy/common/config/contributors.json:
2884
2885 2013-04-29  Alberto Garcia  <agarcia@igalia.com>
2886
2887         Remove all remaining Skia code
2888         https://bugs.webkit.org/show_bug.cgi?id=115263
2889
2890         Reviewed by Benjamin Poulain.
2891
2892         Remove all remaining references to Skia.
2893
2894         * Scripts/webkitdirs.pm:
2895         (blackberryCMakeArguments):
2896         * Scripts/webkitpy/common/config/contributionareas.py:
2897         * Scripts/webkitpy/common/config/watchlist:
2898
2899 2013-04-29  Seokju Kwon  <seokju.kwon@gmail.com>
2900
2901         Get rid of unused options in Tools/Scripts/webkit-build-directory
2902         https://bugs.webkit.org/show_bug.cgi?id=115383
2903
2904         Reviewed by Darin Adler.
2905
2906         * Scripts/webkit-build-directory:
2907
2908 2013-04-29  Alexey Proskuryakov  <ap@apple.com>
2909
2910         [WK2][Mac] Test with NetworkProcess enabled.
2911
2912         Fix the build for non-Mac.
2913
2914         * WebKitTestRunner/TestController.cpp:
2915         (WTR::TestController::initialize):
2916
2917 2013-04-29  Alexey Proskuryakov  <ap@apple.com>
2918
2919         [WK2][Mac] Test with NetworkProcess enabled.
2920
2921         Reviewed by Sam Weinig.
2922
2923         * WebKitTestRunner/TestController.cpp:
2924         (WTR::TestController::initialize):
2925
2926 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
2927
2928         [GTK] Set up the TestWebCore in TestWebKitAPI
2929         https://bugs.webkit.org/show_bug.cgi?id=115237
2930
2931         Reviewed by Gustavo Noronha Silva.
2932
2933         Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
2934         Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
2935         a workaround for the layer violations and circular dependencies between various static libraries. Linking against
2936         either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
2937         shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).
2938
2939         * TestWebKitAPI/GNUmakefile.am:
2940
2941 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
2942
2943         [GTK] Set up the TestJavaScriptCore in TestWebKitAPI
2944         https://bugs.webkit.org/show_bug.cgi?id=115236
2945
2946         Reviewed by Gustavo Noronha Silva.
2947
2948         Set up the TestJavaScriptCore unit test program, consisting of the unit tests
2949         under the TestWebKitAPI/Tests/JavaScriptCore directory.
2950
2951         * TestWebKitAPI/GNUmakefile.am:
2952
2953 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
2954
2955         [GTK] Export the COLLECT_NO_DEMANGLE variable on the builders
2956         https://bugs.webkit.org/show_bug.cgi?id=115323
2957
2958         Reviewed by Philippe Normand.
2959
2960         Export the COLLECT_NO_DEMANGLE environment variable on the GTK BuildBot builders.
2961         Its presence enforces linkers to output mangled symbols when reporting linking failures
2962         due to unresolved references. People trying to fix the build can then simply copy
2963         the printed mangled symbol into the symbols.filter file instead of doing a manual build
2964         or connecting to the builders to discover the mangled version of the missing symbol.
2965
2966         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
2967
2968 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
2969
2970         Remove Chromium code from Tools/BuildSlaveSupport
2971         https://bugs.webkit.org/show_bug.cgi?id=115325
2972
2973         Reviewed by Benjamin Poulain.
2974
2975         Remove the two Chromium-specific scripts and the Chromium-specific parts from the code
2976         covering archiving test results and built products.
2977
2978         * BuildSlaveSupport/built-product-archive:
2979         (archiveBuiltProduct):
2980         (extractBuiltProduct):
2981         * BuildSlaveSupport/chromium/output-android-device-status: Removed.
2982         * BuildSlaveSupport/chromium/remove-crash-logs: Removed.
2983         * BuildSlaveSupport/test-result-archive:
2984         (archiveTestResults):
2985
2986 2013-04-28  Seokju Kwon  <seokju.kwon@gmail.com>
2987
2988         Remove support for Chromium from webkitdirs.pm
2989         https://bugs.webkit.org/show_bug.cgi?id=115338
2990
2991         Reviewed by Darin Adler.
2992
2993         * Scripts/webkitdirs.pm:
2994         (determineBaseProductDir):
2995         (argumentsForConfiguration):
2996         (builtDylibPathForName):
2997         (determineIsQt):
2998         (isAppleWebKit):
2999
3000 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
3001
3002         Rename TestRunner's setAudioData to setAudioResult
3003         https://bugs.webkit.org/show_bug.cgi?id=115326
3004
3005         Reviewed by Darin Adler.
3006
3007         Rename the TestRunner's setAudioData method to setAudioResult. The new name better conveys the method's purpose
3008         than the previous one. The change is a simple rename, there's no change in the method's functionality. The
3009         affected tests are adjusted accordingly.
3010
3011         * DumpRenderTree/qt/TestRunnerQt.cpp:
3012         (TestRunnerQt::setAudioResult):
3013         * DumpRenderTree/qt/TestRunnerQt.h:
3014         (TestRunnerQt):
3015         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3016         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3017         (WTR::TestRunner::setAudioResult):
3018         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3019         (TestRunner):
3020
3021 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
3022
3023         [WKTR] Tests dumping audio data shouldn't dump pixels
3024         https://bugs.webkit.org/show_bug.cgi?id=115270
3025
3026         Reviewed by Benjamin Poulain.
3027
3028         Prevent dumping the pixel output when Web Audio tests are dumping output data
3029         as the testing output. Pixel output in these tests has no real meaning and is
3030         as such unnecessary.
3031
3032         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3033         (WTR::TestRunner::setAudioData):
3034
3035 2013-04-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3036
3037         [EFL] Unreviewed Intel bots fix after r149231.
3038
3039         * efl/jhbuild.modules: Disable the libxml Python bindings since the
3040         bots don't have Python's development files installed. libxml should
3041         detect this kind of thing better.
3042
3043 2013-04-26  Ryuan Choi  <ryuan.choi@samsung.com>
3044
3045         [EFL] Build break using jhbuild on ubuntu 13.04
3046         https://bugs.webkit.org/show_bug.cgi?id=115225
3047
3048         Reviewed by Gyuyoung Kim.
3049
3050         libxslt in Ubuntu 13.04 requires libxml 2.9.0 or higher and
3051         libxml 2.9.0 has a bug to make regression which r138422 mentioned.
3052         So this patch bumped libxml version to 2.9.1.
3053
3054         * efl/jhbuild.modules:
3055
3056 2013-04-26  Jeffrey Pfau  <jpfau@apple.com>
3057
3058         delete-stale-build-files does not clear .d files
3059         http://bugs.webkit.org/show_bug.cgi?id=115293
3060
3061         Reviewed by Ryosuke Niwa.
3062
3063         * BuildSlaveSupport/delete-stale-build-files:
3064         (main): Add .d to the file type list
3065
3066 2013-04-26  Roger Fong  <roger_fong@apple.com>
3067
3068         Make Apple Windows VS2010 build results into and get dependencies from __32 suffixed folders.
3069         Make the DebugSuffix configuration use _debug dependencies.
3070
3071         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3072         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeApple.props:
3073         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
3074         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props:
3075         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
3076         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
3077         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props:
3078         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props:
3079         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props:
3080         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
3081         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd:
3082         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props:
3083         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
3084         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
3085         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
3086         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props:
3087         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props:
3088         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props:
3089         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
3090         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props:
3091         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props:
3092         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props:
3093         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
3094         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props:
3095         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
3096         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props:
3097         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def:
3098         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
3099         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
3100         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
3101         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props:
3102         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props:
3103         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
3104         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin_debug.def: Removed.
3105         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3106         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
3107         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
3108         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props:
3109         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
3110         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props:
3111         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
3112         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
3113         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
3114         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props:
3115         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props:
3116         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3117         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
3118         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props:
3119         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props:
3120         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
3121         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props:
3122         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
3123         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
3124         * win/AssembleBuildLogs/AssembleLogs.cmd:
3125         * win/record-memory/record-memory.vcxproj:
3126         * win/record-memory/record-memoryDebug.props:
3127         * win/record-memory/record-memoryDebugWinCairo.props:
3128         * win/record-memory/record-memoryProduction.props:
3129         * win/record-memory/record-memoryRelease.props:
3130         * win/record-memory/record-memoryReleaseWinCairo.props:
3131
3132 2013-04-26  Zan Dobersek  <zdobersek@igalia.com>
3133
3134         [GTK] Clean up the TestWebKitAPI GNUmakefile.am
3135         https://bugs.webkit.org/show_bug.cgi?id=115233
3136
3137         Reviewed by Martin Robinson.
3138
3139         Specify unconditional, non-installable program targets in one declaration. Only conditionally specify
3140         WebKit2-specific targets, not the complete target setups (i.e. targets' sources, cppflags listings etc.).
3141         Add missing unit test source files to the TestWTF program, namely HashSet.cpp and MetaAllocator.cpp.
3142         Specify the TestWTF program's CXXFLAGS to be the same as the global cxxflags as the source files need to
3143         be compiled with the -fno-rtti flag that's present in the global_cxxflags variable.
3144
3145         * TestWebKitAPI/GNUmakefile.am:
3146
3147 2013-04-25  Andy Estes  <aestes@apple.com>
3148
3149         [WebKit2] Loading a resource from a custom protocol in a synchronous XHR times out
3150         https://bugs.webkit.org/show_bug.cgi?id=115223
3151
3152         Reviewed by Darin Adler.
3153
3154         Added an API test.
3155
3156         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
3157         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm: Added.
3158         (TestWebKitAPI::TEST): Tested that a synchronous XHR does not time out
3159         when it loads a request with a custom protocol.
3160         * TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Added.
3161         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: Moved the
3162         NSURLProtocol subclass to TestProtocol.{h, mm} and did some
3163         miscellaneous cleanup.
3164         * TestWebKitAPI/mac/TestProtocol.h: Copied from Source/WebKit2/WebProcess/WebProcessSupplement.h.
3165         * TestWebKitAPI/mac/TestProtocol.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm.
3166         (+[TestProtocol canInitWithRequest:]):
3167         (+[TestProtocol canonicalRequestForRequest:]):
3168         (+[TestProtocol requestIsCacheEquivalent:toRequest:]):
3169         (+[TestProtocol scheme]):
3170         (-[TestProtocol startLoading]):
3171         (-[TestProtocol stopLoading]):
3172
3173 2013-04-26  Martin Robinson  <mrobinson@igalia.com>
3174
3175         Remove the remaining Skia #ifdefs
3176         https://bugs.webkit.org/show_bug.cgi?id=114886
3177
3178         Reviewed by Benjamin Poulain.
3179
3180         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
3181         (createBitmapContextFromWebView): Remove Skia #ifdef references.
3182
3183 2013-04-26  Mary Wu  <mary.wu@torchmobile.com.cn>
3184
3185         [BlackBerry] Clean up load interface in WebPage
3186         https://bugs.webkit.org/show_bug.cgi?id=113267
3187
3188         Reviewed by Rob Buis.
3189
3190         Update DumpRenderTree with change of load() interface in WebPage.
3191         RIM Bug# 315535, internally reviewed by Joe Mason.
3192
3193         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3194         (BlackBerry::WebKit::DumpRenderTree::runTest):
3195
3196 2013-04-26  Zan Dobersek  <zdobersek@igalia.com>
3197
3198         Remove the HeapGraphSerializer unit test
3199         https://bugs.webkit.org/show_bug.cgi?id=115231
3200
3201         Reviewed by Andreas Kling.
3202
3203         Remove the HeapGraphSerializer unit test. The code it was testing was removed in r148921,
3204         specifically the Source/WebCore/inspector/HeapGraphSerializer.(cpp|h) files.
3205
3206         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed.
3207
3208 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
3209
3210         Remove support for Chromium from build/update scripts
3211         https://bugs.webkit.org/show_bug.cgi?id=115218
3212
3213         Reviewed by Darin Adler.
3214
3215         * Scripts/build-webkit:
3216         (writeCongrats):
3217         * Scripts/update-webkit:
3218
3219 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
3220
3221         Remove support for Chromium from api-test
3222         https://bugs.webkit.org/show_bug.cgi?id=115211
3223
3224         Reviewed by Dirk Pranke.
3225
3226         * Scripts/build-api-tests:
3227         * Scripts/run-api-tests:
3228         (isSupportedPlatform):
3229
3230 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
3231
3232         Get rid of Chromium in build-dumprendertree
3233         https://bugs.webkit.org/show_bug.cgi?id=115212
3234
3235         Reviewed by Dirk Pranke.
3236
3237         * Scripts/build-dumprendertree:
3238
3239 2013-04-25  Alexey Proskuryakov  <ap@apple.com>
3240
3241         Pass relatedPage when creating a page in WebKitTestRunner
3242         https://bugs.webkit.org/show_bug.cgi?id=115206
3243
3244         Reviewed by Geoffrey Garen.
3245
3246         To make sure that window.open() opens in the same process even when using multiple processes.
3247
3248         * WebKitTestRunner/PlatformWebView.h:
3249         * WebKitTestRunner/TestController.cpp:
3250         (WTR::TestController::createOtherPage):
3251         (WTR::TestController::createWebViewWithOptions):
3252         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3253         (WTR::PlatformWebView::PlatformWebView):
3254         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3255         (WTR::PlatformWebView::PlatformWebView):
3256         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3257         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useTiledDrawing:]):
3258         (WTR::PlatformWebView::PlatformWebView):
3259         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3260         (WTR::PlatformWebView::PlatformWebView):
3261         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3262         (WTR::PlatformWebView::PlatformWebView):
3263
3264 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
3265
3266         Fix autocompletion for Benjamin. The Bugzilla email address must come first.
3267
3268         * Scripts/webkitpy/common/config/contributors.json:
3269
3270 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
3271
3272         Build fix. Forgot to merge args.
3273
3274         * Scripts/webkitpy/tool/bot/irc_command.py:
3275         (Hi.execute):
3276
3277 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
3278
3279         webkitbot should recognize its own nickname in greetings.
3280         https://bugs.webkit.org/show_bug.cgi?id=115196
3281
3282         Reviewed by Andreas Kling.
3283
3284         Make webkitbot recognize other forms of its nick. Also be tolerant of spaces between the nick and !.
3285
3286         * Scripts/webkitpy/tool/bot/irc_command.py:
3287         (Hi.execute):
3288
3289 2013-04-25  Xavier Castano  <xcastanho@igalia.com>
3290
3291         [GTK] Tools/gtk/install-dependencies added ragel dependency
3292         https://bugs.webkit.org/show_bug.cgi?id=115163
3293
3294         Reviewed by Xan Lopez.
3295
3296         The install-dependencies script was missing a dependency on ragel
3297         which is expected when building HarfBuzz.
3298
3299         * gtk/install-dependencies: Added a dependency on ragel for both
3300         apt and yum.
3301
3302 2013-04-25  Eduardo Lima Mitev  <elima@igalia.com>
3303
3304         [GTK] Remove pango from optional jhbuild dependencies
3305         https://bugs.webkit.org/show_bug.cgi?id=115162
3306
3307         Reviewed by Martin Robinson.
3308
3309         Pango is not needed since revision r148293 that lowers the pango
3310         dependency to 1.30, which is available in most distributions.
3311
3312         * gtk/jhbuild-optional.modules: Removes description of pango module.
3313
3314 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
3315
3316         Remove Chromium-specific cases from FeatureList.pm
3317         https://bugs.webkit.org/show_bug.cgi?id=115169
3318
3319         Reviewed by Andreas Kling.
3320
3321         * Scripts/webkitperl/FeatureList.pm:
3322
3323 2013-04-24  Seokju Kwon  <seokju.kwon@gmail.com>
3324
3325         Remove checking chromium from run-webkit-tests
3326         https://bugs.webkit.org/show_bug.cgi?id=115139
3327
3328         Reviewed by Benjamin Poulain.
3329
3330         * Scripts/run-webkit-tests:
3331         (useNewRunWebKitTests):
3332
3333 2013-04-24  Simon Fraser  <simon.fraser@apple.com>
3334
3335         Pixel tests in SVG are all broken in WK2
3336         https://bugs.webkit.org/show_bug.cgi?id=114218
3337
3338         Reviewed by Darin Adler.
3339         
3340         Window snapshots in WebKitTestRunner on Mac are window-sized
3341         (800x600), which is wrong for the W3C SVG tests that require a
3342         480x360 snapshot.
3343         
3344         Fix by resizing the window, as well as the web view in
3345         PlatformWebView::resizeTo() so that window snapshots are correctly
3346         sized.
3347         
3348         Also do some drive-by cleanup of the window size constants in both
3349         DRT and WTR to remove magic numbers, and make the code more similar.
3350         
3351         * DumpRenderTree/TestRunner.cpp:
3352         (TestRunner::setShouldPaintBrokenImage):
3353         * DumpRenderTree/TestRunner.h:
3354         * DumpRenderTree/efl/DumpRenderTree.cpp:
3355         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3356         (webInspectorShowWindow):
3357         * DumpRenderTree/mac/DumpRenderTree.mm:
3358         (createWebViewAndOffscreenWindow):
3359         (sizeWebViewForCurrentTest):
3360         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3361         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3362         (createPagedBitmapContext):
3363         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3364         (DumpRenderTree::DumpRenderTree):
3365         (DumpRenderTree::open):
3366         * DumpRenderTree/qt/TestRunnerQt.cpp:
3367         * DumpRenderTree/qt/TestRunnerQt.h:
3368         * DumpRenderTree/win/DumpRenderTree.cpp:
3369         (sizeWebViewForCurrentTest):
3370         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
3371         * WebKitTestRunner/TestController.cpp:
3372         (WTR::TestController::resetStateToConsistentValues):
3373         * WebKitTestRunner/TestController.h:
3374         * WebKitTestRunner/TestInvocation.cpp:
3375         (WTR::sizeWebViewForCurrentTest):
3376         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3377         (WTR::PlatformWebView::PlatformWebView):
3378         (WTR::PlatformWebView::resizeTo):
3379
3380 2013-04-24  Byungwoo Lee  <bw80.lee@samsung.com>
3381
3382         [EFL] Fix build error after r148963.
3383         https://bugs.webkit.org/show_bug.cgi?id=115126
3384
3385         Reviewed by Laszlo Gombos.
3386
3387         Generate forwarding headers for 'CoordinatedGraphics' to generate WKView.h
3388
3389         * TestWebKitAPI/PlatformEfl.cmake:
3390
3391 2013-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3392
3393         [GTK] Use stamp files for generate-forwarding-headers makefile rules
3394         https://bugs.webkit.org/show_bug.cgi?id=115118
3395
3396         Reviewed by Martin Robinson.
3397
3398         Use a stamp file for the TestWebKitAPI and WebKitTestRunner
3399         forwarding generator rules and don't call it for soup since there
3400         aren't soup directories in TestWebKitAPI and WebKitTestRunner.
3401
3402         * TestWebKitAPI/GNUmakefile.am:
3403         * WebKitTestRunner/GNUmakefile.am:
3404
3405 2013-04-24  Simon Pena  <simon.pena@samsung.com>
3406
3407         [GTK] Update build dependencies
3408         https://bugs.webkit.org/show_bug.cgi?id=115111
3409
3410         Reviewed by Martin Robinson.
3411
3412         The install-dependencies script was missing a dependency on EGL,
3413         which is expected when building Cairo.
3414
3415         * gtk/install-dependencies: Added a dependency on libegl1-mesa
3416         for both apt and yum.
3417
3418 2013-04-24  Seokju Kwon  <seokju.kwon@gmail.com>
3419
3420         Remove the Chromium-specific helper from run_webkit_tests.py
3421         https://bugs.webkit.org/show_bug.cgi?id=114996
3422
3423         Reviewed by Dirk Pranke.
3424
3425         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3426         (parse_args):
3427
3428 2013-04-24  Sergio Correia  <sergio.correia@openbossa.org>
3429
3430         [EFL][WK2]: Fix WKViewClientWebProcessCallbacks WK2 API test
3431         https://bugs.webkit.org/show_bug.cgi?id=114850
3432
3433         Reviewed by Andreas Kling.
3434
3435         Revision r148312 fixed WebPageProxy cleanup and also changed the process
3436         termination semantics when requested by the user so that a client is not
3437         notified of a crash anymore, since there was no crash anyway.
3438
3439         That change broke WKViewClientWebProcessCallbacks WK2 API test, since it
3440         relied on being notified of a crash after calling WKPageTerminate(). As
3441         a result of not being notified of such non-existent crash, the test would
3442         timeout right after making the terminate call.
3443
3444         This patch adds an InjectedBundle to be used for simulating a crash, by
3445         calling abort() upon receiving a "Crash" message, and thus we are able to
3446         keep testing the crash callback.
3447
3448         This patch also re-enables the WKViewClientWebProcessCallbacks test, which
3449         had been disabled in revisions r148858 and r148855, since it was failing.
3450
3451         * TestWebKitAPI/PlatformEfl.cmake:
3452         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
3453         (TestWebKitAPI::TEST):
3454         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Added.
3455         (TestWebKitAPI):
3456         (WKViewClientWebProcessCallbacksTest):
3457         (TestWebKitAPI::WKViewClientWebProcessCallbacksTest::WKViewClientWebProcessCallbacksTest):
3458         (TestWebKitAPI::WKViewClientWebProcessCallbacksTest::didReceiveMessage):
3459
3460 2013-04-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3461
3462         [EFL][WK2] WebKitTestRunner failures due to IconDatabase assertions
3463         https://bugs.webkit.org/show_bug.cgi?id=115095
3464
3465         Reviewed by Antonio Gomes.
3466
3467         Use different subfolders under DumpRenderTree Temp folder for every
3468         functionality (icon database, cache, localstorage, ...). This makes
3469         sure there is no conflict between the functionalities.
3470
3471         In EFL's case, libsoup cache was causing problems for the icon
3472         database if sharing the same folder.
3473
3474         * WebKitTestRunner/TestController.cpp:
3475         (WTR::TestController::initialize):
3476
3477 == Rolled over to ChangeLog-2013-04-24 ==