[WPE] Add libepoxy to the Jhbuild moduleset
[WebKit-https.git] / Tools / ChangeLog
1 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
2
3         [WPE] Add libepoxy to the Jhbuild moduleset
4         https://bugs.webkit.org/show_bug.cgi?id=174711
5
6         Reviewed by Carlos Alberto Lopez Perez.
7
8         * wpe/jhbuild.modules: Add libepoxy 1.4.3 to WPE's Jhbuild moduleset.
9
10 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
11
12         [WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
13         https://bugs.webkit.org/show_bug.cgi?id=174780
14
15         Reviewed by Carlos Garcia Campos.
16
17         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
18         Manually define the EGL_CAST macro to the C++ version that uses static_cast<>
19         in case the eglplatform.h header doesn't provide that macro. This replicates
20         the work in WebCore's EpoxyEGL.h header, but we can't include that header here.
21
22 2017-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
23
24         [iOS WK2] Remove _WKDraggableElementInfo and fold PositionInformationTests into WKRequestActivatedElementInfo
25         https://bugs.webkit.org/show_bug.cgi?id=174758
26
27         Reviewed by Dan Bernstein.
28
29         Migrate position-information-related unit tests from the PositionInformationTests suite to
30         WKRequestActivatedElementInfo as 2 new unit tests. See WebKit2 ChangeLog for more details.
31
32         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
33         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
34         (TestWebKitAPI::checkElementTypeAndBoundingRect):
35         (TestWebKitAPI::TEST):
36         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm: Removed.
37         * TestWebKitAPI/cocoa/TestWKWebView.h:
38         * TestWebKitAPI/cocoa/TestWKWebView.mm:
39         (-[TestWKWebView activatedElementAtPosition:]):
40
41 2017-07-22  Chris Dumez  <cdumez@apple.com>
42
43         REGRESSION(r204565): WKObject is broken
44         https://bugs.webkit.org/show_bug.cgi?id=174736
45         <rdar://problem/33246169>
46
47         Reviewed by Dan Bernstein.
48
49         Add API test that used to crash.
50
51         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
52         (TestWebKitAPI::TEST):
53
54 2017-07-22  Yusuke Suzuki  <utatane.tea@gmail.com>
55
56         [WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult
57         https://bugs.webkit.org/show_bug.cgi?id=174705
58
59         Reviewed by Mark Lam.
60
61         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
62         (TestWebKitAPI::testThreadGroup):
63         (TestWebKitAPI::TEST):
64
65 2017-07-21  Jonathan Bedard  <jbedard@apple.com>
66
67         Fail gracefully when xcrun fails in IOSSimulatorPort constructor
68         https://bugs.webkit.org/show_bug.cgi?id=174724
69
70         Reviewed by Aakash Jain.
71
72         * Scripts/webkitpy/port/ios_simulator.py:
73         (IOSSimulatorPort.__init__): Ignore any errors when attempting to find a running
74         simulator. Errors here should be treated the same as no simulators found.
75
76 2017-07-21  Yousuke Kimoto  <Yousuke.Kimoto@sony.com>
77
78         [CMake] Add an option to stop build after generating project files
79         https://bugs.webkit.org/show_bug.cgi?id=174664
80
81         Reviewed by Konstantin Tokarev.
82
83         Add "--generate-project-only" to stop build after generating project files.
84
85         * Scripts/build-webkit: Add '--generate-project-only' option and a checker to stop build.
86         * Scripts/webkitdirs.pm: Add a function to check '--generate-project-only' option and the same checker as the above
87         (buildCMakeProjectOrExit): Add a cheker to stop build stop build after generating project files.
88         (determineIsGenerateProjectOnly): Check if '--generate-project-only' option is specified
89         (isGenerateProjectOnly): ditto
90
91 2017-07-21  Yusuke Suzuki  <utatane.tea@gmail.com>
92
93         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
94         https://bugs.webkit.org/show_bug.cgi?id=174501
95
96         Reviewed by Darin Adler.
97
98         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
99         (TestWebKitAPI::TEST):
100
101 2017-07-20  David Quesada  <david_quesada@apple.com>
102
103         Add SPI to notify WKNavigationDelegate about client redirects
104         https://bugs.webkit.org/show_bug.cgi?id=174680
105         rdar://problem/33184886
106
107         Reviewed by Brady Eidson.
108
109         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
110         (-[DidPerformClientRedirectNavigationDelegate _webView:didPerformClientRedirectForNavigation:]):
111         (TEST):
112         Add API test for -[id<WKNavigationDelegatePrivate> _webView:didPerformClientRedirectForNavigation:].
113
114 2017-07-20  Brady Eidson  <beidson@apple.com>
115
116         Test WebKit2CustomProtocolsTest.ProcessPoolDestroyedDuringLoading added in r219664 fails on El Capitan.
117         https://bugs.webkit.org/show_bug.cgi?id=174685
118
119         Reviewed by Andy Estes.
120
121         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
122         (TestWebKitAPI::TEST): Use a scoped AutodrainedPool instead of a RetainPtr<NSAutoreleasePool>.
123
124 2017-07-20  Brady Eidson  <beidson@apple.com>
125
126         Deprecate WebIconDatabase in WebKitLegacy/mac.
127         https://bugs.webkit.org/show_bug.cgi?id=174607
128
129         Reviewed by Alex Christensen.
130
131         * DumpRenderTree/mac/TestRunnerMac.mm:
132
133 2017-07-20  Jonathan Bedard  <jbedard@apple.com>
134
135         lint-test-expectations should be run during style checking
136         https://bugs.webkit.org/show_bug.cgi?id=173559
137         <rdar://problem/32854941>
138
139         Reviewed by Aakash Jain.
140
141         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
142         (TestExpectationsModel._already_seen_better_match): Append returns 'None' when successful,
143         prevents identifying errors on specific lines in a file.
144         * Scripts/webkitpy/style/main_unittest.py:
145         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Test for the
146         case where a linter error is in the file modified, but the line modified is not related to
147         the linter error.
148
149 2017-07-20  Brady Eidson  <beidson@apple.com>
150
151         Remove WebIconDatabase from WebKitLegacy/win.
152         https://bugs.webkit.org/show_bug.cgi?id=174608
153
154         Reviewed by Alex Christensen.
155
156         * DumpRenderTree/win/DumpRenderTree.cpp:
157         (main):
158         * DumpRenderTree/win/TestRunnerWin.cpp:
159         (TestRunner::setIconDatabaseEnabled):
160
161 2017-07-20  Zan Dobersek  <zdobersek@igalia.com>
162
163         [WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
164         https://bugs.webkit.org/show_bug.cgi?id=174671
165
166         Reviewed by Carlos Garcia Campos.
167
168         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
169         (HeadlessViewBackend::HeadlessViewBackend): Use the RunLoopDispatcher
170         priority for this source in order to have it dispatched on the same
171         priority as the other WebKit-controlled GSource objects.
172
173 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
174
175         lint-test-expectations should be run during style checking
176         https://bugs.webkit.org/show_bug.cgi?id=173559
177         <rdar://problem/32854941>
178
179         Reviewed by Daniel Bates.
180
181         Follow up fix addressing style and a few minor bugs.
182
183         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
184         (TestExpectationParser.__init__): Use lambda x: x instead of str
185         (TestExpectationsModel.__init__): Make lambda x: x the default argument.
186         (TestExpectationsModel._already_seen_better_match): Use a temporary variable to
187         reduce the calls of _shorten_filename, fix minor bug in appending the current
188         expectation's line number instead of the previous ones, clarify treatment of None
189         in file-to-line-number mapping.
190         (TestExpectations._report_warnings): Collapse call.
191         * Scripts/webkitpy/style/checkers/test_expectations.py:
192         (TestExpectationsChecker.lint_test_expectations):
193         * Scripts/webkitpy/style/filereader.py: Re-write comment.
194         (TextFileReader.process_file): Add comment explaining treatment of None in
195         file-to-line-number mapping.
196         (TextFileReader.delete_file): Collapse call.
197
198 2017-07-19  Chris Dumez  <cdumez@apple.com>
199
200         Unreviewed attempt to fix API test failure after r219663.
201
202         The test was hard-coding an exception string and the string has changed slightly
203         in r219663.
204
205         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
206         (TEST):
207
208 2017-07-19  Megan Gardner  <megan_gardner@apple.com>
209
210         Don't write file URLs to iOS Pasteboard
211         https://bugs.webkit.org/show_bug.cgi?id=174647
212         <rdar://problem/33199730>
213
214         Reviewed by Wenson Hsieh.
215
216         Updating tests to reflect the lack of file URLs for images.
217
218         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
219         (checkTypeIdentifierAndIsNotOtherTypeIdentifier):
220         (checkEstimatedSize):
221         (TestWebKitAPI::TEST):
222
223 2017-07-19  Brady Eidson  <beidson@apple.com>
224
225         iBooks sometimes crashes when closing a book.
226         <rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658
227
228         Reviewed by Oliver Hunt.
229
230         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
231         (-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
232         (-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
233         (-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
234         (TestWebKitAPI::TEST):
235
236         Add a "spin the runloop X number of times" utility:
237         * TestWebKitAPI/Utilities.h:
238         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
239         (TestWebKitAPI::Util::spinRunLoop):
240
241 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
242
243         lint-test-expectations should be run during style checking
244         https://bugs.webkit.org/show_bug.cgi?id=173559
245         <rdar://problem/32854941>
246
247         Reviewed by David Kilzer.
248
249         Running the test expectation linter requires reading both files and lines not in the
250         patch because, for example, deletion of a test can cause a lint failure even though
251         no test expectations where modified. This means that the linter will occasionally warn
252         about lines which were not changed in a given patch but whose error is related to a
253         change made in that patch.
254
255         * Scripts/webkitpy/common/system/filesystem_mock.py:
256         (MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.
257         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
258         (TestExpectationWarning): Added class to pass warnings as an object instead of a string.
259         (TestExpectationWarning.__init__): Construct warning with file name, line number, line
260         content, description of the error and the name of the associated test.
261         (TestExpectationWarning.__str__): Convert to string so that existing printing code works.
262         (TestExpectationParser.__init__): Pass shorten_filename function to
263         TestExpectationsParser to add a deleted file to the related_files dictionary.
264         (TestExpectationParser._check_test_exists): If the test does not exist, add the
265         missing path to the related_files dictionary.
266         (TestExpectationLine.__init__): Add related_files dictionary, which tracks
267         files and line numbers related to this test expectation line. This will allow
268         tracking linter errors in the style checker occurring across multiple files.
269         (TestExpectationsModel._already_seen_better_match): Add redundant expectation
270         lines to related_files dictionary.
271         (TestExpectations.__init__): Pass self._shorten_filename to TestExpectationParser.
272         (TestExpectations._report_warnings): Construct warning object instead of string
273         when adding to warnings list.
274         * Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to
275         clean-up log.
276         * Scripts/webkitpy/style/checker.py:
277         (ProcessorBase.do_association_check): Add required function for processor classes.
278         (StyleProcessor):
279         (StyleProcessor.do_association_check): Run the TestExpectations linter when
280         checking for errors between associated files.
281         * Scripts/webkitpy/style/checkers/test_expectations.py:
282         (TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
283         (TestExpectationsChecker):
284         (TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
285         of modified files, the current working directory and the host, determine if the linter
286         warning is associated with the changes.
287         (TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
288         style checker.
289         * Scripts/webkitpy/style/filereader.py:
290         (TextFileReader):
291         (TextFileReader.__init__): Track modified files in dictionary instead of a counter.
292         (TextFileReader.file_count): Use dictionary to determine the number of modified files.
293         (TextFileReader.process_file): Track both the number of files changed and which lines
294         in those files were changed.
295         (TextFileReader.do_association_check): Run the processor's association check on all
296         modified or deleted files processed by TextFileReader.
297         (TextFileReader.delete_file): Track deleted files in _files dictionary.
298         (TextFileReader.count_delete_only_file): Deleted.
299         * Scripts/webkitpy/style/filereader_unittest.py:
300         (TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
301         (TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.
302         * Scripts/webkitpy/style/main.py:
303         (CheckWebKitStyle.main): When running the style checker on a specific list of files,
304         explicitly run the association check on the file reader.
305         * Scripts/webkitpy/style/main_unittest.py:
306         (ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
307         embedded in the style checker.
308         (ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
309         (ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
310         construct the TextFileReader object with a StyleProcessor used to run style checks on
311         specific files.
312         (ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
313         testing the test expectation linter inside the style checker. This host must contain a
314         mock file system with the basic structure of test expectations.
315         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
316         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
317         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
318         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
319         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):
320         * Scripts/webkitpy/style/patchreader.py:
321         (PatchReader.check): Specify which file was deleted, run the association check.
322         * Scripts/webkitpy/style/patchreader_unittest.py:
323         (PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
324         (PatchReaderTest.MockTextFileReader.do_association_check): Added.
325         (PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.
326
327 2017-07-19  Yusuke Suzuki  <utatane.tea@gmail.com>
328
329         [WTF] Implement WTF::ThreadGroup
330         https://bugs.webkit.org/show_bug.cgi?id=174081
331
332         Reviewed by Mark Lam.
333
334         Add WTF::ThreadGroup tests.
335
336         * TestWebKitAPI/CMakeLists.txt:
337         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
338         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
339         (TestWebKitAPI::testThreadGroup):
340         (TestWebKitAPI::TEST):
341
342 2017-07-18  Andy Estes  <aestes@apple.com>
343
344         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
345         https://bugs.webkit.org/show_bug.cgi?id=174631
346
347         Reviewed by Tim Horton.
348
349         * DumpRenderTree/mac/Configurations/Base.xcconfig:
350         * MiniBrowser/Configurations/Base.xcconfig:
351         * MobileMiniBrowser/Configurations/Base.xcconfig:
352         * TestWebKitAPI/Configurations/Base.xcconfig:
353         * WebKitTestRunner/Configurations/Base.xcconfig:
354
355 2017-07-18  Andy Estes  <aestes@apple.com>
356
357         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
358         https://bugs.webkit.org/show_bug.cgi?id=174631
359
360         Reviewed by Sam Weinig.
361
362         * DumpRenderTree/mac/Configurations/Base.xcconfig:
363         * MiniBrowser/Configurations/Base.xcconfig:
364         * MobileMiniBrowser/Configurations/Base.xcconfig:
365         * TestWebKitAPI/Configurations/Base.xcconfig:
366         * WebKitTestRunner/Configurations/Base.xcconfig:
367
368 2017-07-18  Daniel Bates  <dabates@apple.com>
369
370         lldb: Add type summary for StringView
371         https://bugs.webkit.org/show_bug.cgi?id=174637
372
373         Reviewed by Sam Weinig.
374
375         For debugging convenience, adds a pretty-print type summary for StringView. Evaluating a
376         StringView object will print output that has the form:
377
378             (WTF::StringView) $4 = { length = 2, contents = 'li' } {
379               m_characters = 0x000000011b57abb5 "eeeeeefjh0n"
380               m_length = 2
381               m_is8Bit = true
382               m_underlyingString = 0x0000614000000a90
383             }
384
385         * lldb/lldb_webkit.py:
386         (__lldb_init_module): Use WTFStringView_SummaryProvider to format StringView types.
387         (WTFStringView_SummaryProvider):
388         (WTFStringViewProvider):
389         (WTFStringViewProvider.__init__):
390         (WTFStringViewProvider.is_8bit): Access field StringView.m_is8Bit.
391         (WTFStringViewProvider.get_length): Access field StringView.m_length.
392         (WTFStringViewProvider.get_characters): Access field StringView.m_characters.
393         (WTFStringViewProvider.to_string): Returns the string represented by the StringView.
394
395 2017-07-18  Andy Estes  <aestes@apple.com>
396
397         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
398         https://bugs.webkit.org/show_bug.cgi?id=174631
399
400         Reviewed by Dan Bernstein.
401
402         * DumpRenderTree/mac/Configurations/Base.xcconfig:
403         * MiniBrowser/Configurations/Base.xcconfig:
404         * MobileMiniBrowser/Configurations/Base.xcconfig:
405         * TestWebKitAPI/Configurations/Base.xcconfig:
406         * WebKitTestRunner/Configurations/Base.xcconfig:
407
408 2017-07-18  Devin Rousso  <drousso@apple.com>
409
410         Web Inspector: Add memoryCost to Inspector Protocol objects
411         https://bugs.webkit.org/show_bug.cgi?id=174478
412
413         Reviewed by Joseph Pecoraro.
414
415         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
416         * TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp: Added.
417         (TestWebKitAPI::TEST(InspectorValue, MemoryCostNull)):
418         (TestWebKitAPI::TEST(InspectorValue, MemoryCostBoolean)):
419         (TestWebKitAPI::TEST(InspectorValue, MemoryCostDouble)):
420         (TestWebKitAPI::TEST(InspectorValue, MemoryCostInteger)):
421         (TestWebKitAPI::TEST(InspectorValue, MemoryCostString)):
422         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringEmpty)):
423         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringNull)):
424         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringGrowing)):
425         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringUnicode)):
426         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObject)):
427         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectEmpty)):
428         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectGrowing)):
429         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArray)):
430         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayEmpty)):
431         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayGrowing)):
432
433 2017-07-18  Andy Estes  <aestes@apple.com>
434
435         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
436         https://bugs.webkit.org/show_bug.cgi?id=174631
437
438         Reviewed by Darin Adler.
439
440         * DumpRenderTree/mac/Configurations/Base.xcconfig:
441         * MiniBrowser/Configurations/Base.xcconfig:
442         * MobileMiniBrowser/Configurations/Base.xcconfig:
443         * TestWebKitAPI/Configurations/Base.xcconfig:
444         * WebKitTestRunner/Configurations/Base.xcconfig:
445
446 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
447
448         Unreviewed, fix the iOS build.
449
450         I missed a spot when renaming -synchronouslyLoadHTML: to -synchronouslyLoadHTMLString:.
451
452         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
453         (TestWebKitAPI::TEST):
454
455 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
456
457         [iOS DnD] Web process uses too much memory when beginning a drag on a very large image
458         https://bugs.webkit.org/show_bug.cgi?id=174585
459         <rdar://problem/33302541>
460
461         Reviewed by Tim Horton.
462
463         Adds a new test verifying that we don't try to allocate any image buffer equal to the true size of the image
464         being dragged when initiating a drag.
465
466         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
467         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Added.
468         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
469         (TestWebKitAPI::TEST):
470         * TestWebKitAPI/cocoa/TestWKWebView.h:
471
472         Add a new -synchronouslyLoadHTMLString: helper that works like -synchronouslyLoadTestPage:, but takes markup.
473
474         * TestWebKitAPI/cocoa/TestWKWebView.mm:
475         (-[TestWKWebView synchronouslyLoadHTMLString:]):
476
477 2017-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
478
479         [CMake] Macros in WebKitMacros.cmake should be prefixed with WEBKIT_ namespace
480         https://bugs.webkit.org/show_bug.cgi?id=174547
481
482         Reviewed by Alex Christensen.
483
484         * DumpRenderTree/PlatformWin.cmake:
485         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
486
487 2017-07-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
488
489         Update style checker to deal with "final"
490         https://bugs.webkit.org/show_bug.cgi?id=174528
491
492         Reviewed by Alex Christensen.
493         
494         check-webkit-style shouldn't complain about an open brace to start a
495         line after a function definition with "final" or "const final".
496
497         * Scripts/webkitpy/style/checkers/cpp.py:
498         (check_braces):
499         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
500         (CppStyleTest.test_brace_at_begin_of_line):
501
502 2017-07-17  Alex Christensen  <achristensen@webkit.org>
503
504         Modernize content extension code
505         https://bugs.webkit.org/show_bug.cgi?id=174588
506
507         Reviewed by Sam Weinig.
508
509         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
510         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
511         (TestWebKitAPI::testRequest):
512         (TestWebKitAPI::makeBackend):
513         (TestWebKitAPI::TEST_F):
514
515 2017-07-17  Brady Eidson  <beidson@apple.com>
516
517         WKHTTPCookieStore observing only works on the default cookie store.
518         <rdar://problem/33330724> and https://bugs.webkit.org/show_bug.cgi?id=174580
519
520         Reviewed by Sam Weinig.
521
522         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
523         (runTestWithWebsiteDataStore): Refactor the cookie observing test out so it can be
524           called for the default store, a non-persistent store, and a custom store.
525         (TEST):
526
527 2017-07-16  Sam Weinig  <sam@webkit.org>
528
529         [Scripts] Fix missing variable warnings from svn-create-patch when there are untracked files
530         https://bugs.webkit.org/show_bug.cgi?id=174575
531
532         Reviewed by Brady Eidson.
533
534         * Scripts/svn-create-patch:
535         (findModificationType):
536         Add support for more status codes. C -> conflicted, ? -> untracked, ! -> missing. Give a
537         default value of "unknown".
538
539         (generateFileList):
540         Handle all the new modification types. Abort on conflicted, missing, and unknown. Log
541         for untracked, which matches our old behavior.
542
543 2017-07-17  Charlie Turner  <cturner@igalia.com>
544
545         Add some missing build dependencies on Fedora
546         https://bugs.webkit.org/show_bug.cgi?id=174578
547
548         Unreviewed dependency update.
549
550         * gtk/install-dependencies:
551
552 2017-07-16  Brady Eidson  <beidson@apple.com>
553
554         Crash when a WKHTTPCookieStore outlives its owning WKWebsiteDataStore.
555         <rdar://problem/33341730> and https://bugs.webkit.org/show_bug.cgi?id=174574
556
557         Reviewed by Tim Horton.
558
559         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
560         (-[CookieNavigationDelegate webView:didFinishNavigation:]):
561         (TEST):
562
563 2017-07-16  Bernhard M. Wiedemann  <bwiedemann@suse.de>
564
565         [GTK] Sort inspector GResource manifest to ensure reproducible builds
566         https://bugs.webkit.org/show_bug.cgi?id=174540
567
568         Reviewed by Michael Catanzaro.
569
570         * gtk/generate-inspector-gresource-manifest.py:
571         (get_filenames): sort list of input files
572
573 2017-07-15  Brady Eidson  <beidson@apple.com>
574
575         Make sure all CFHTTPCookieStorageRefs we create are scheduled.
576         <rdar://problem/33221110> and https://bugs.webkit.org/show_bug.cgi?id=174513
577
578         Reviewed by Tim Horton.
579
580         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
581         (TEST): Make this test more reliable by clearing everything beforehand.
582
583 2017-07-15  David Kilzer  <ddkilzer@apple.com>
584
585         Make it possible to extend check-webkit-style with Apple-internal checkers
586         <https://webkit.org/b/174464>
587         <rdar://problem/25564402>
588
589         Reviewed by Darin Adler.
590
591         * Scripts/webkitpy/style/checker.py: Import apple_additions.
592         (_all_categories): Add categories from apple_additions() if it
593         exists.
594         (CheckerDispatcher._create_checker): Create python checker
595         from apple_additions() if it exists.
596
597 2017-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
598
599         [iOS WK2] Presenting an action sheet on an image map prevents selection UI from updating
600         https://bugs.webkit.org/show_bug.cgi?id=174539
601         <rdar://problem/33307395>
602
603         Reviewed by Darin Adler.
604
605         Adds a new unit test suite to cover action sheet popover presentation.
606
607         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
608         * TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Added.
609         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm: Added.
610         (-[ActionSheetObserver waitForActionSheetAfterBlock:]):
611
612         Runs the given block and waits until the UI process has indicated that it will present an action sheet.
613
614         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
615         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
616
617         Helper class to alter the behavior of [[UIDevice currentDevice] userInterfaceIdiom] for testing.
618
619         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
620         (TestWebKitAPI::TEST):
621
622 2017-07-15  Sam Weinig  <sam@webkit.org>
623
624         [Scripts] Make svn-create-patch work better when called in sub directories
625         https://bugs.webkit.org/show_bug.cgi?id=174551
626
627         Reviewed by Darin Adler.
628
629         - Fixes manufacturePatchForAdditionWithHistory to use the correct path
630           by ensuring that the prefix is applied as is done in generateDiff.
631         - Silence output of explanatory lines from svn stat (" > move to ...")
632           that show up in STDERR when running svn-create-patch.
633         - Add verbose logging that I found useful while debugging this issue.
634
635         * Scripts/svn-create-patch:
636         (findBaseUrl):
637         (findMimeType):
638         (findSourceFileAndRevision):
639         (generateDiff):
640         (generateFileList):
641         (manufacturePatchForAdditionWithHistory):
642
643 2017-07-15  Jonathan Bedard  <jbedard@apple.com>
644
645         Unreviewed build fix after r219537.
646
647         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
648
649 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
650
651         Add iOS 11 SPI
652         https://bugs.webkit.org/show_bug.cgi?id=174430
653         <rdar://problem/33269288>
654
655         Reviewed by Tim Horton.
656
657         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Define drag-and-drop API required for testing.
658         * TestWebKitAPI/ios/DataInteractionSimulator.h: Ditto.
659         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Ditto.
660
661 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
662
663         Failing to install on iPad simulators
664         https://bugs.webkit.org/show_bug.cgi?id=174532
665         <rdar://problem/33328347>
666
667         Reviewed by Stephanie Lewis.
668
669         * Scripts/webkitpy/xcode/simulated_device.py:
670         (SimulatedDevice.install_app): Place install command in retry try-except block.
671
672 2017-07-14  Jeff Miller  <jeffm@apple.com>
673
674         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
675         https://bugs.webkit.org/show_bug.cgi?id=174524
676
677         Reviewed by Sam Weinig.
678
679         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
680         (TEST):
681         Renamed TestParameter to TestParameter1.
682         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
683
684         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
685         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
686         Observe changes for two bundle parameters.
687
688         (-[BundleParametersPlugIn dealloc]):
689         Remove observers for two bundle parameters.
690
691 2017-07-14  Commit Queue  <commit-queue@webkit.org>
692
693         Unreviewed, rolling out r219510.
694         https://bugs.webkit.org/show_bug.cgi?id=174525
695
696         Need to revert length() == 0 check for null string (Requested
697         by yusukesuzuki on #webkit).
698
699         Reverted changeset:
700
701         "[WTF] Newly added AtomicStringImpl should use BufferInternal
702         static string if StringImpl is static"
703         https://bugs.webkit.org/show_bug.cgi?id=174501
704         http://trac.webkit.org/changeset/219510
705
706 2017-07-14  Jer Noble  <jer.noble@apple.com>
707
708         [MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
709         https://bugs.webkit.org/show_bug.cgi?id=174514
710
711         Reviewed by Sam Weinig.
712
713         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
714         (TestWebKitAPI::TEST_F):
715
716 2017-07-14  Yusuke Suzuki  <utatane.tea@gmail.com>
717
718         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
719         https://bugs.webkit.org/show_bug.cgi?id=174501
720
721         Reviewed by Darin Adler.
722
723         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
724         (TestWebKitAPI::TEST):
725
726 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
727
728         Bring mac expectations in-line with other platforms
729         https://bugs.webkit.org/show_bug.cgi?id=174472
730         <rdar://problem/33297388>
731
732         Reviewed by David Kilzer.
733
734         The override order for Mac test expectations does not conform to the pattern used by iOS,
735         GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
736
737             platform/mac-wk2
738             platform/wk2
739             platform/mac-elcapitan
740             platform/mac-sierra
741             generic
742
743         After this change, El Capitan's baseline search path looks like this:
744
745             platform/mac-sierra-wk2
746             platform/mac-sierra
747             platform/mac-wk2
748             platform/wk2
749             generic
750
751         * Scripts/webkitpy/port/mac.py:
752         (MacPort.__init__): If a specific version is specified in the port name, use that
753         as the os version.
754         (MacPort.default_baseline_search_path): Expectation search paths should work the
755         same way they do on other ports. Port + version overrides port, port overrides generic
756         and wk1/wk2 should override expectations for the two combined.
757         * Scripts/webkitpy/port/mac_unittest.py:
758         (MacTest.test_tests_for_other_platforms): Deleted.
759         (MacTest._assert_search_path): Deleted.
760         (MacTest.test_baseline_search_path): Deleted.
761         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
762         (TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
763         (test_rebaseline_test_and_print_scm_changes): Ditto.
764         (test_rebaseline_and_copy_test): Ditto.
765         (test_rebaseline_and_copy_test_no_existing_result): Ditto.
766         (test_rebaseline_and_copy_test_with_lion_result): Ditto.
767         (test_rebaseline_and_copy_no_overwrite_test): Ditto.
768
769 2017-07-13  Michael Catanzaro  <mcatanzaro@igalia.com>
770
771         Fix style checker unit test
772
773         Unreviewed WebKit2 => WebKit fixup.
774
775         * Scripts/webkitpy/style/checker_unittest.py:
776         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
777
778 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
779
780         Use the old WebKit/WebKit2 targets for CMake builds. (v2)
781
782         Unreviewed build fix.
783
784         r219492 missed one hunk from its partial revert of r219489.
785         This patch reverts that hunk.
786
787         * TestWebKitAPI/CMakeLists.txt:
788
789 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
790
791         Use the old WebKit/WebKit2 targets for CMake builds.
792
793         Unreviewed build fix.
794
795         We can update the target names to match the Framework names in a future patch.
796         This is a partial revert of r219489.
797
798         * TestWebKitAPI/CMakeLists.txt:
799         WebKitLegacy => WebKit
800         WebKit => WebKit2
801
802 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
803
804         Fix TestWebKit API.
805         https://bugs.webkit.org/show_bug.cgi?id=174164
806         rdar://problem/33137595
807
808         Reviewed by Dan Bernstein.
809
810         * TestWebKitAPI/CMakeLists.txt:
811         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
812         * TestWebKitAPI/PlatformGTK.cmake:
813
814 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
815
816         Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
817         https://bugs.webkit.org/show_bug.cgi?id=174164
818         rdar://problem/33137595
819
820         Reviewed by Dan Bernstein.
821
822         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
823         (ShouldBuildTest):
824         * DumpRenderTree/mac/Configurations/Base.xcconfig:
825         * Scripts/build-webkit:
826         * Scripts/do-file-rename:
827         * Scripts/do-webcore-rename:
828         * Scripts/update-webkit-localizable-strings:
829         * Scripts/webkitpy/common/config/watchlist:
830         * Scripts/webkitpy/style/checker.py:
831         * Scripts/webkitpy/style/checkers/featuredefines.py:
832         * gtk/make-dist.py:
833         (ensure_version_if_possible):
834         * gtk/manifest.txt.in:
835
836 2017-07-05  Matthew Hanson  <matthew_hanson@apple.com>
837
838         Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
839         https://bugs.webkit.org/show_bug.cgi?id=174162
840         rdar://problem/33137594
841
842         Reviewed by Dan Bernstein.
843
844         Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource tooling.
845
846         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
847         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
848         * EWSTools/configure-clang-linux.sh:
849         * Scripts/build-webkit:
850         * Scripts/do-file-rename:
851         * Scripts/do-webcore-rename:
852         * Scripts/update-webkit-localizable-strings:
853         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
854         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
855         * Scripts/webkitpy/style/checkers/featuredefines.py:
856         * gtk/manifest.txt.in:
857
858 2017-07-13  Jonathan Bedard  <jbedard@apple.com>
859
860         Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
861         https://bugs.webkit.org/show_bug.cgi?id=174438
862         <rdar://problem/33277112>
863
864         Reviewed by Aakash Jain.
865
866         Given a patch, this will convert the changes from the path to the new directory structure.
867
868         * Scripts/rebase-patch-after-webkit-move: Added.
869         (append_source): Append 'Source' to the provided path.
870         (is_editable_line): Return true if a line the script expects to modify.
871         (needs_rebase): Return if a line needs to be rebased based on it's content.
872         (rebase_line): Rebase the provided line.
873         (rebase): Rebase a patch given the lines of that patch and a file to output the rebased patch to.
874         (parse_arguments): Parse the command line arguments and return the patches to be rebased, if they
875         were provided.
876
877 2017-07-12  Nan Wang  <n_wang@apple.com>
878
879         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
880         https://bugs.webkit.org/show_bug.cgi?id=174393
881         <rdar://problem/33248006>
882
883         Reviewed by Chris Fleizach.
884
885         * DumpRenderTree/AccessibilityUIElement.cpp:
886         (textMarkerRangeMatchesTextNearMarkersCallback):
887         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
888         (AccessibilityUIElement::getJSClass):
889         * DumpRenderTree/AccessibilityUIElement.h:
890         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
891         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
892         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
893         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
894         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
895         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
896         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
897         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
898
899 2017-07-12  Matt Lewis  <jlewis3@apple.com>
900
901         Unreviewed, rolling out r219409.
902
903         The revision caused the Windows builds to fail.
904
905         Reverted changeset:
906
907         "AX: [iOS] Implement a way to retrieve a text marker range
908         with desired text that is closest to a position"
909         https://bugs.webkit.org/show_bug.cgi?id=174393
910         http://trac.webkit.org/changeset/219409
911
912 2017-07-12  Nan Wang  <n_wang@apple.com>
913
914         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
915         https://bugs.webkit.org/show_bug.cgi?id=174393
916         <rdar://problem/33248006>
917
918         Reviewed by Chris Fleizach.
919
920         * DumpRenderTree/AccessibilityUIElement.cpp:
921         (textMarkerRangeMatchesTextNearMarkersCallback):
922         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
923         (AccessibilityUIElement::getJSClass):
924         * DumpRenderTree/AccessibilityUIElement.h:
925         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
926         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
927         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
928         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
929         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
930         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
931         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
932         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
933
934 2017-07-12  Emilio Cobos Álvarez  <ecobos@igalia.com>
935
936         Make prepare-ChangeLog -g <commit> generate a more standard ChangeLog entry.
937         https://bugs.webkit.org/show_bug.cgi?id=174197
938
939         Reviewed by Darin Adler.
940
941         This bit me the first time I tried to submit a patch to WebKit, and still I have
942         to manually edit the ChangeLog every time I use the script.
943
944         This generates a more convenient and standard ChangeLog entry.
945
946         * Scripts/prepare-ChangeLog:
947         (generateNewChangeLogs):
948
949 2017-07-12  Matt Lewis  <jlewis3@apple.com>
950
951         Unreviewed, rolling out r219401.
952
953         This revision rolled out the previous patch, but after talking
954         with reviewer, a rebaseline is what was needed.Rolling back in
955         before rebaseline.
956
957         Reverted changeset:
958
959         "Unreviewed, rolling out r219379."
960         https://bugs.webkit.org/show_bug.cgi?id=174400
961         http://trac.webkit.org/changeset/219401
962
963 2017-07-12  Matt Lewis  <jlewis3@apple.com>
964
965         Unreviewed, rolling out r219379.
966
967         This revision caused a consistent failure in the test
968         fast/dom/Window/property-access-on-cached-window-after-frame-
969         removed.html.
970
971         Reverted changeset:
972
973         "Remove NAVIGATOR_HWCONCURRENCY"
974         https://bugs.webkit.org/show_bug.cgi?id=174400
975         http://trac.webkit.org/changeset/219379
976
977 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
978
979         [WPE] Use libepoxy
980         https://bugs.webkit.org/show_bug.cgi?id=172104
981
982         Reviewed by Michael Catanzaro.
983
984         * WebKitTestRunner/wpe/HeadlessViewBackend.h:
985         Include the <epoxy/egl.h> header, dropping the EGL and GLES2 inclusions.
986
987 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
988
989         [GTK][WPE] Align Jhbuild patches for GStreamer packages
990         https://bugs.webkit.org/show_bug.cgi?id=174363
991
992         Reviewed by Michael Catanzaro.
993
994         Align the patches we apply over Jhbuild-managed GStreamer dependency packages
995         between the GTK+ and WPE port. There's no reason for the two ports to apply
996         different patches over same versions of GStreamer releases.
997
998         This aligns the two ports on this specific issue. Next we'll look into
999         creating a single GStreamer-specific Jhbuild moduleset that will allow us
1000         to keep these patches in a single place, avoiding duplicate files.
1001
1002         * gtk/jhbuild.modules:
1003         * gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
1004         * gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch.
1005         * gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
1006         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Removed.
1007
1008 2017-07-11  Dean Jackson  <dino@apple.com>
1009
1010         Remove NAVIGATOR_HWCONCURRENCY
1011         https://bugs.webkit.org/show_bug.cgi?id=174400
1012
1013         Reviewed by Sam Weinig.
1014
1015         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1016
1017 2017-07-11  Ansh Shukla  <ansh_shukla@apple.com>
1018
1019         WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration properties
1020         https://bugs.webkit.org/show_bug.cgi?id=174239
1021
1022         Reviewed by Brady Eidson.
1023
1024         Create windows with specific features set and make sure those are properly reflected in the
1025         WKWindowFeatures object.
1026
1027         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
1028         (resetToConsistentState):
1029         (-[CheckWindowFeaturesUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1030         (TEST):
1031
1032 2017-07-11  Jonathan Bedard  <jbedard@apple.com>
1033
1034         Do not duplicate files when deleting directories with svn 1.9
1035         https://bugs.webkit.org/show_bug.cgi?id=174339
1036         <rdar://problem/33226781>
1037
1038         Reviewed by David Kilzer.
1039
1040         * Scripts/svn-create-patch:
1041         (diffOptionsForFile): No longer pass -N option, since this does not work in SVN 1.9.4.
1042         (generateFileList): Determine which files are deleted because they are part of a
1043         directory being deleted.
1044
1045 2017-07-11  Dean Jackson  <dino@apple.com>
1046
1047         Rolling out r219372.
1048
1049         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1050
1051 2017-07-11  Dean Jackson  <dino@apple.com>
1052
1053         Remove NAVIGATOR_HWCONCURRENCY
1054         https://bugs.webkit.org/show_bug.cgi?id=174400
1055
1056         Reviewed by Sam Weinig.
1057
1058         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1059
1060 2017-07-11  Lucas Forschler  <lforschler@apple.com>
1061
1062         Teach build workers to fetch archives from S3.
1063         https://bugs.webkit.org/show_bug.cgi?id=174384
1064
1065         Reviewed by Aakash Jain.
1066
1067         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1068         (DownloadBuiltProduct):
1069
1070 2017-07-11  Lucas Forschler  <lforschler@apple.com>
1071
1072         Configure buildbot to transfer all archives to S3.
1073         Previously this was Mac only, but it's time to expand!
1074         https://bugs.webkit.org/show_bug.cgi?id=174378
1075         
1076         Reviewed by Aakash Jain.
1077
1078         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1079         (BuildFactory.__init__):
1080
1081 2017-07-11  Zan Dobersek  <zdobersek@igalia.com>
1082
1083         [WPE] Bump GStreamer packages in jhbuild.modules to 1.10.5
1084         https://bugs.webkit.org/show_bug.cgi?id=174350
1085
1086         Reviewed by Xabier Rodriguez-Calvar.
1087
1088         Bump the various GStreamer dependencies listed in WPE's Jhbuild modules file
1089         to the 1.10.5 version. One gstreamer patch is added. The two gst-plugins-bad
1090         patches are removed. The patches for gst-plugins-good are updated, removing
1091         the stale ones and adding the additional changes to qtdemux, souphttpsrc and
1092         rtpbin elements that will help with the EMEv3 development.
1093
1094         * wpe/jhbuild.modules:
1095         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
1096         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
1097         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added.
1098         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
1099         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Added.
1100         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
1101         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
1102         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
1103         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
1104
1105 2017-07-10  John Wilander  <wilander@apple.com>
1106
1107         Resource Load Statistics: Prune statistics in orders of importance
1108         https://bugs.webkit.org/show_bug.cgi?id=174215
1109         <rdar://problem/33164403>
1110
1111         Reviewed by Chris Dumez.
1112
1113         Nest infrastructure. Adds these functions:
1114         1. testRunner.setStatisticsLastSeen()
1115         2. setStatisticsMaxStatisticsEntries()
1116         3. setStatisticsPruneEntriesDownTo()
1117
1118         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1119         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1120         (WTR::TestRunner::setStatisticsLastSeen):
1121         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
1122         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
1123         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1124         * WebKitTestRunner/TestController.cpp:
1125         (WTR::TestController::setStatisticsLastSeen):
1126         (WTR::TestController::setMaxStatisticsEntries):
1127         (WTR::TestController::setPruneEntriesDownTo):
1128         * WebKitTestRunner/TestController.h:
1129         * WebKitTestRunner/TestInvocation.cpp:
1130         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1131         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1132         (WTR::TestController::setStatisticsLastSeen):
1133         (WTR::TestController::setStatisticsMaxStatisticsEntries):
1134         (WTR::TestController::setStatisticsPruneEntriesDownTo):
1135
1136 2017-07-03  Brian Burg  <bburg@apple.com>
1137
1138         Web Replay: remove some unused code
1139         https://bugs.webkit.org/show_bug.cgi?id=173903
1140
1141         Rubber-stamped by Joseph Pecoraro.
1142
1143         * Scripts/run-input-generator-tests: Removed.
1144         * Scripts/webkitpy/replay/__init__.py: Removed.
1145         * Scripts/webkitpy/replay/main.py: Removed.
1146
1147 2017-07-10  Zan Dobersek  <zdobersek@igalia.com>
1148
1149         [WPE] Fix layout test baseline and TestExpectations hierarchy
1150         https://bugs.webkit.org/show_bug.cgi?id=174092
1151
1152         Reviewed by Michael Catanzaro.
1153
1154         Like for the GTK+ port, override the default_baseline_search_path() and
1155         _port_specific_expectations_files() methods in the webkitpy.port.WPEPort class.
1156         Both methods operate on a short list of search paths that defaults to 'wpe' and
1157         'wk2', along with any other user-specified platform directory.
1158
1159         The test_expectations_file_position() method is overridden for testing purposes,
1160         and relevant unit tests are added.
1161
1162         * Scripts/webkitpy/port/wpe.py:
1163         (WPEPort._search_paths):
1164         (WPEPort):
1165         (WPEPort.default_baseline_search_path):
1166         (WPEPort._port_specific_expectations_files):
1167         (WPEPort.test_expectations_file_position):
1168         * Scripts/webkitpy/port/wpe_unittest.py:
1169         (WPEPortTest.test_default_baseline_search_path):
1170         (WPEPortTest):
1171         (WPEPortTest.test_port_specific_expectations_files):
1172
1173 2017-07-10  Chris Dumez  <cdumez@apple.com>
1174
1175         Further WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore clean up
1176         https://bugs.webkit.org/show_bug.cgi?id=174301
1177
1178         Reviewed by Brent Fulgham.
1179
1180         Rename some of the testRunner API for clarity and to better match what it calls
1181         internally.
1182
1183         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1184         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1185         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
1186         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
1187         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1188         * WebKitTestRunner/TestController.cpp:
1189         (WTR::TestController::statisticsUpdateCookiePartitioning):
1190         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
1191         * WebKitTestRunner/TestController.h:
1192         * WebKitTestRunner/TestInvocation.cpp:
1193         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1194         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1195         (WTR::TestController::statisticsUpdateCookiePartitioning):
1196         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
1197
1198 2017-07-10  Charlie Turner  <cturner@igalia.com>
1199
1200         [GStreamer] Live twitch.tv videos do not play
1201         https://bugs.webkit.org/show_bug.cgi?id=174222
1202
1203         Reviewed by Michael Catanzaro.
1204
1205         Upgrade GStreamer to 1.10.5. It contains a change to typefind that
1206         fixes videos not playing on twitch.tv.
1207
1208         * gtk/jhbuild.modules:
1209
1210 2017-07-09  Zan Dobersek  <zdobersek@igalia.com>
1211
1212         Add WebGL2 configuration option to build-webkit
1213         https://bugs.webkit.org/show_bug.cgi?id=174251
1214
1215         Reviewed by Michael Catanzaro.
1216
1217         * Scripts/webkitperl/FeatureList.pm: Add the 'webgl2' option, making it possible
1218         to enable the ENABLE_WEBGL2 flag through the build-webkit script. The feature
1219         is marked as enabled for the Apple Cocoa ports.
1220
1221 2017-07-08  Chris Dumez  <cdumez@apple.com>
1222
1223         Simplify WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore
1224         https://bugs.webkit.org/show_bug.cgi?id=174290
1225
1226         Reviewed by Brent Fulgham.
1227
1228         Rename testRunner API to match the new internal API names.
1229
1230         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1231         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1232         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
1233         (WTR::TestRunner::statisticsSubmitTelemetry):
1234         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1235         * WebKitTestRunner/TestController.cpp:
1236         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1237         (WTR::TestController::statisticsSubmitTelemetry):
1238         * WebKitTestRunner/TestController.h:
1239         * WebKitTestRunner/TestInvocation.cpp:
1240         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1241         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1242         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1243         (WTR::TestController::statisticsSubmitTelemetry):
1244
1245 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1246
1247         Drop NOSNIFF compile flag
1248         https://bugs.webkit.org/show_bug.cgi?id=174289
1249
1250         Reviewed by Michael Catanzaro.
1251
1252         * Scripts/webkitperl/FeatureList.pm:
1253         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1254
1255 2017-07-07  Wenson Hsieh  <wenson_hsieh@apple.com>
1256
1257         [iOS DnD] For cross-app drags, 'drop' event handlers are never invoked if dataTransfer.dropEffect is not set while dragging
1258         https://bugs.webkit.org/show_bug.cgi?id=174219
1259         <rdar://problem/32083177>
1260
1261         Reviewed by Ryosuke Niwa.
1262
1263         Add plumbing and support to mock the value of -allowsMoveOperation on the simulated UIDragDropSession objects.
1264         Setting the DataInteractionSimulator's shouldAllowMoveOperation property to NO simulates a drag operation coming
1265         in from another app out-of-process, for which move operations won't cause a drop to be performed in the first
1266         place.
1267
1268         Also tweaks 2 existing unit tests regarding file uploads via JavaScript to simulate items coming in from a
1269         different application, and adds a new test to check that if a drop area specifically requests a MOVE operation,
1270         no action is taken when dropping.
1271
1272         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html:
1273         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1274         (TestWebKitAPI::TEST):
1275         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1276         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1277         (-[MockDragDropSession initWithItems:location:window:allowMove:]):
1278         (-[MockDragDropSession allowsMoveOperation]):
1279         (-[MockDataOperationSession initWithProviders:location:window:allowMove:]):
1280         (-[MockDataInteractionSession initWithWindow:allowMove:]):
1281         (-[DataInteractionSimulator initWithWebView:]):
1282         (-[DataInteractionSimulator runFrom:to:]):
1283         (-[DataInteractionSimulator _advanceProgress]):
1284         (-[MockDragDropSession initWithItems:location:window:]): Deleted.
1285         (-[MockDataOperationSession initWithProviders:location:window:]): Deleted.
1286         (-[MockDataInteractionSession initWithWindow:]): Deleted.
1287
1288 2017-07-07  Commit Queue  <commit-queue@webkit.org>
1289
1290         Unreviewed, rolling out r219238, r219239, and r219241.
1291         https://bugs.webkit.org/show_bug.cgi?id=174265
1292
1293         "fast/workers/dedicated-worker-lifecycle.html is flaky"
1294         (Requested by yusukesuzuki on #webkit).
1295
1296         Reverted changesets:
1297
1298         "[WTF] Implement WTF::ThreadGroup"
1299         https://bugs.webkit.org/show_bug.cgi?id=174081
1300         http://trac.webkit.org/changeset/219238
1301
1302         "Unreviewed, build fix after r219238"
1303         https://bugs.webkit.org/show_bug.cgi?id=174081
1304         http://trac.webkit.org/changeset/219239
1305
1306         "Unreviewed, CLoop build fix after r219238"
1307         https://bugs.webkit.org/show_bug.cgi?id=174081
1308         http://trac.webkit.org/changeset/219241
1309
1310 2017-07-07  Yusuke Suzuki  <utatane.tea@gmail.com>
1311
1312         [GTK][WPE] Enable X-Content-Type-Options: nosniff
1313         https://bugs.webkit.org/show_bug.cgi?id=174250
1314
1315         Reviewed by Carlos Alberto Lopez Perez.
1316
1317         * Scripts/webkitperl/FeatureList.pm:
1318
1319 2017-07-07  Charlie Turner  <cturner@igalia.com>
1320         [GStreamer] vid.me videos do not play
1321         https://bugs.webkit.org/show_bug.cgi?id=172240
1322
1323         Reviewed by Xabier Rodriguez-Calvar.
1324
1325         Build httpsoupsrc again for use in adaptive streaming pipelines, and
1326         have the existing libsoup build against GNOME to avoid header drift
1327         against GStreamer's linked Soup library.
1328
1329         * gtk/jhbuild.modules:
1330
1331 2017-07-06  Lucas Forschler  <lforschler@apple.com>
1332
1333         Write a support script to enable buildbot to upload to S3
1334         https://bugs.webkit.org/show_bug.cgi?id=174196
1335         
1336         Reviewed by Stephanie Lewis.
1337
1338         * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Added.
1339         (uploadToS3):
1340         (archiveExists):
1341
1342 2017-07-06  Lucas Forschler  <lforschler@apple.com>
1343
1344         Enabling uploading archives to S3.
1345         https://bugs.webkit.org/show_bug.cgi?id=174198
1346         
1347         Reviewed by Stephanie Lewis.
1348
1349         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1350         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
1351         (UploadMinifiedBuiltProduct): Upload minified archive to build master
1352         (TransferToS3): Transfer full and minified archives to S3
1353
1354 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1355
1356         [WTF] Implement WTF::ThreadGroup
1357         https://bugs.webkit.org/show_bug.cgi?id=174081
1358
1359         Reviewed by Mark Lam.
1360
1361         Add WTF::ThreadGroup tests.
1362
1363         * TestWebKitAPI/CMakeLists.txt:
1364         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1365         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
1366         (TestWebKitAPI::TEST):
1367
1368 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
1369
1370         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
1371         https://bugs.webkit.org/show_bug.cgi?id=174150
1372
1373         Reviewed by Mark Lam.
1374
1375         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1376         (TestWebKitAPI::TEST):
1377         * TestWebKitAPI/TestsController.cpp:
1378         (TestWebKitAPI::TestsController::TestsController):
1379
1380 2017-07-06  Lucas Forschler  <lforschler@apple.com>
1381
1382         Enabling uploading archives to S3.
1383         https://bugs.webkit.org/show_bug.cgi?id=174198
1384         
1385         Reviewed by Lucas Forschler.
1386
1387         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1388         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
1389         (UploadMinifiedBuiltProduct): Upload minified archive to build master
1390         (TransferToS3): Transfer full and minified archives to S3
1391
1392 2017-07-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1393
1394         [GTK][WPE] kill-old-process should kill more webkit related process
1395         https://bugs.webkit.org/show_bug.cgi?id=174220
1396
1397         Reviewed by Michael Catanzaro.
1398
1399         Generate list of possible webkit-related process names and add
1400         them to the list of process to kill.
1401         Also update the possible system related process for GTK+/WPE.
1402
1403         * BuildSlaveSupport/kill-old-processes:
1404         (listAllWebKitPrograms):
1405         (main):
1406
1407 2017-07-06  Chris Dumez  <cdumez@apple.com>
1408
1409         FileMonitor should not be ref counted
1410         https://bugs.webkit.org/show_bug.cgi?id=174166
1411
1412         Reviewed by Brent Fulgham.
1413
1414         Update the API tests to reflect the API change.
1415
1416         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1417         (TestWebKitAPI::TEST_F):
1418
1419 2017-07-06  Commit Queue  <commit-queue@webkit.org>
1420
1421         Unreviewed, rolling out r219194.
1422         https://bugs.webkit.org/show_bug.cgi?id=174207
1423
1424         it broke some layout tests (Requested by clopez on #webkit).
1425
1426         Reverted changeset:
1427
1428         "[GStreamer] vid.me videos do not play"
1429         https://bugs.webkit.org/show_bug.cgi?id=172240
1430         http://trac.webkit.org/changeset/219194
1431
1432 2017-07-06  Matt Lewis  <jlewis3@apple.com>
1433
1434         Unreviewed, rolling out r219178.
1435
1436         This caused a consistent failure with the API test
1437         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
1438
1439         Reverted changeset:
1440
1441         "[WTF] Clean up StringStatics.cpp by using
1442         LazyNeverDestroyed<> for Atoms"
1443         https://bugs.webkit.org/show_bug.cgi?id=174150
1444         http://trac.webkit.org/changeset/219178
1445
1446 2017-07-06  Alicia Boya García  <aboya@igalia.com>
1447
1448         Add CWD to Perl library path (no longer the default since 5.26.0)
1449         https://bugs.webkit.org/show_bug.cgi?id=174200
1450
1451         Reviewed by Michael Catanzaro.
1452
1453         * Scripts/webkitpy/tool/commands/setupgitclone.py:
1454         (SetupGitClone._get_username_and_email):
1455
1456 2017-07-06  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1457
1458         Unreviewed, update my email address.
1459
1460         * Scripts/webkitpy/common/config/contributors.json:
1461
1462 2017-07-06  Charlie Turner  <cturner@igalia.com>
1463         [GStreamer] vid.me videos do not play
1464         https://bugs.webkit.org/show_bug.cgi?id=172240
1465
1466         Reviewed by Xabier Rodriguez-Calvar.
1467
1468         Build httpsoupsrc again for use in adaptive streaming pipelines, and
1469         have the existing libsoup build against GNOME to avoid header drift
1470         against GStreamer's linked Soup library.
1471
1472         * gtk/jhbuild.modules:
1473
1474 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
1475
1476         [WTF] Move SoftLinking.h into WTF
1477         https://bugs.webkit.org/show_bug.cgi?id=174000
1478
1479         Reviewed by Alex Christensen.
1480
1481         * DumpRenderTree/mac/TestRunnerMac.mm:
1482         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1483         (test_primary_header):
1484         (ErrorCollector.__init__): Deleted.
1485         (ErrorCollector.__call__): Deleted.
1486         (ErrorCollector.results): Deleted.
1487         (ErrorCollector.result_list): Deleted.
1488         (ErrorCollector.verify_all_categories_are_seen): Deleted.
1489         (MockIo.open): Deleted.
1490         (CppFunctionsTest.test_convert_to_lower_with_underscores): Deleted.
1491         (CppFunctionsTest.test_create_acronym): Deleted.
1492         (CppFunctionsTest.test_is_c_or_objective_c): Deleted.
1493         (CppFunctionsTest.test_parameter): Deleted.
1494         (CppFunctionsTest.test_single_line_view): Deleted.
1495         (CppFunctionsTest.test_create_skeleton_parameters): Deleted.
1496         (CppFunctionsTest.test_find_parameter_name_index): Deleted.
1497         (CppFunctionsTest.test_parameter_list): Deleted.
1498         (CppFunctionsTest.test_check_parameter_against_text): Deleted.
1499         (CppStyleTestBase.process_file_data): Deleted.
1500         (CppStyleTestBase.perform_lint): Deleted.
1501         (CppStyleTestBase.perform_single_line_lint): Deleted.
1502         (CppStyleTestBase.perform_multi_line_lint): Deleted.
1503         (CppStyleTestBase.perform_language_rules_check): Deleted.
1504         (CppStyleTestBase.perform_function_lengths_check): Deleted.
1505         (CppStyleTestBase.perform_pass_ptr_check): Deleted.
1506         (CppStyleTestBase.perform_leaky_pattern_check): Deleted.
1507         (CppStyleTestBase.perform_include_what_you_use): Deleted.
1508         (CppStyleTestBase.perform_header_guard_check): Deleted.
1509         (CppStyleTestBase.assert_lint): Deleted.
1510         (CppStyleTestBase.assert_lint_one_of_many_errors_re): Deleted.
1511         (CppStyleTestBase.assert_multi_line_lint): Deleted.
1512         (CppStyleTestBase.assert_multi_line_lint_re): Deleted.
1513         (CppStyleTestBase.assert_language_rules_check): Deleted.
1514         (CppStyleTestBase.assert_include_what_you_use): Deleted.
1515         (CppStyleTestBase.assert_header_guard): Deleted.
1516         (CppStyleTestBase.assert_blank_lines_check): Deleted.
1517         (CppStyleTestBase.assert_positions_equal): Deleted.
1518         (FunctionDetectionTest.test_basic_function_detection): Deleted.
1519         (FunctionDetectionTest.test_function_declaration_detection): Deleted.
1520         (FunctionDetectionTest.test_pure_function_detection): Deleted.
1521         (FunctionDetectionTest.test_override_and_final_function_detection): Deleted.
1522         (FunctionDetectionTest.test_ignore_macros): Deleted.
1523         (FunctionDetectionTest.test_non_functions): Deleted.
1524         (FunctionDetectionTest.test_non_functions.Stuff): Deleted.
1525         (FunctionDetectionTest.test_parameter_list): Deleted.
1526         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack): Deleted.
1527         (CppStyleTest.test_asm_lines_ignored): Deleted.
1528         (CppStyleTest.test_get_line_width): Deleted.
1529         (CppStyleTest.test_find_next_multi_line_comment_start): Deleted.
1530         (CppStyleTest.test_find_next_multi_line_comment_end): Deleted.
1531         (CppStyleTest.test_remove_multi_line_comments_from_range): Deleted.
1532         (CppStyleTest.test_position): Deleted.
1533         (CppStyleTest.test_rfind_in_lines): Deleted.
1534         (CppStyleTest.test_close_expression): Deleted.
1535         (CppStyleTest.test_spaces_at_end_of_line): Deleted.
1536         (CppStyleTest.test_cstyle_cast): Deleted.
1537         (CppStyleTest.test_runtime_casting): Deleted.
1538         (CppStyleTest.test_runtime_selfinit): Deleted.
1539         (CppStyleTest.test_runtime_rtti): Deleted.
1540         (CppStyleTest.test_static_cast_readability): Deleted.
1541         (CppStyleTest.test_check_for_unnamed_params): Deleted.
1542         (CppStyleTest.void): Deleted.
1543         (CppStyleTest.test_deprecated_cast): Deleted.
1544         (CppStyleTest.test_mock_method): Deleted.
1545         (CppStyleTest.test_sizeof_type): Deleted.
1546         (CppStyleTest.cases): Deleted.
1547         (CppStyleTest.for): Deleted.
1548         (CppStyleTest.test_typedef_for_pointer_to_function): Deleted.
1549         (CppStyleTest.test_typedef_for_pointer_to_function.void): Deleted.
1550         (CppStyleTest.test_include_what_you_use_no_implementation_files): Deleted.
1551         (CppStyleTest.test_include_what_you_use): Deleted.
1552         (CppStyleTest.test_files_belong_to_same_module): Deleted.
1553         (CppStyleTest.test_cleanse_line): Deleted.
1554         (CppStyleTest.test_multi_line_comments): Deleted.
1555         (CppStyleTest.test_multi_line_comments.Foo): Deleted.
1556         (CppStyleTest.test_multiline_strings): Deleted.
1557         (CppStyleTest.test_platformh_comments): Deleted.
1558         (CppStyleTest.test_explicit_single_argument_constructors): Deleted.
1559         (CppStyleTest.test_explicit_single_argument_constructors.Foo): Deleted.
1560         (CppStyleTest.test_explicit_single_argument_constructors.Qualifier): Deleted.
1561         (CppStyleTest.test_explicit_single_argument_constructors.definition): Deleted.
1562         (CppStyleTest.test_slash_star_comment_on_single_line): Deleted.
1563         (CppStyleTest.test_suspicious_usage_of_if): Deleted.
1564         (CppStyleTest.test_suspicious_usage_of_memset): Deleted.
1565         (CppStyleTest.test_check_posix_threading): Deleted.
1566         (CppStyleTest.test_insecure_string_operations): Deleted.
1567         (CppStyleTest.test_format_strings): Deleted.
1568         (CppStyleTest.test_insecure_temp_file): Deleted.
1569         (CppStyleTest.test_variable_length_array_detection): Deleted.
1570         (CppStyleTest.test_braces): Deleted.
1571         (CppStyleTest.test_check_check): Deleted.
1572         (CppStyleTest.test_brace_at_begin_of_line): Deleted.
1573         (CppStyleTest.test_mismatching_spaces_in_parens): Deleted.
1574         (CppStyleTest.test_spacing_for_fncall): Deleted.
1575         (CppStyleTest.test_spacing_for_fncall.foo): Deleted.
1576         (CppStyleTest.test_spacing_before_braces): Deleted.
1577         (CppStyleTest.test_spacing_between_braces): Deleted.
1578         (CppStyleTest.test_spacing_before_brackets): Deleted.
1579         (CppStyleTest.test_cpp_lambda_functions): Deleted.
1580         (CppStyleTest.test_objective_c_block): Deleted.
1581         (CppStyleTest.test_objective_c_block_as_argument): Deleted.
1582         (CppStyleTest.test_spacing_around_else): Deleted.
1583         (CppStyleTest.test_spacing_for_binary_ops): Deleted.
1584         (CppStyleTest.test_spacing_for_binary_ops.hash_map): Deleted.
1585         (CppStyleTest.test_operator_methods): Deleted.
1586         (CppStyleTest.test_spacing_in_objective_c_properties): Deleted.
1587         (CppStyleTest.test_spacing_before_last_semicolon): Deleted.
1588         (CppStyleTest.test_static_or_global_stlstrings): Deleted.
1589         (CppStyleTest.test_no_spaces_in_function_calls): Deleted.
1590         (CppStyleTest.test_one_spaces_between_code_and_comments): Deleted.
1591         (CppStyleTest.test_one_spaces_after_punctuation_in_comments): Deleted.
1592         (CppStyleTest.test_space_after_comment_marker): Deleted.
1593         (CppStyleTest.test_newline_at_eof): Deleted.
1594         (CppStyleTest.test_newline_at_eof.do_test): Deleted.
1595         (CppStyleTest.test_extra_newlines_at_eof): Deleted.
1596         (CppStyleTest.test_extra_newlines_at_eof.do_test): Deleted.
1597         (CppStyleTest.test_invalid_utf8): Deleted.
1598         (CppStyleTest.test_invalid_utf8.do_test): Deleted.
1599         (CppStyleTest.test_is_blank_line): Deleted.
1600         (CppStyleTest.test_blank_lines_check): Deleted.
1601         (CppStyleTest.test_allow_blank_line_before_closing_namespace): Deleted.
1602         (CppStyleTest.test_allow_blank_line_before_if_else_chain): Deleted.
1603         (CppStyleTest.test_else_on_same_line_as_closing_braces): Deleted.
1604         (CppStyleTest.test_else_clause_not_on_same_line_as_else): Deleted.
1605         (CppStyleTest.test_comma): Deleted.
1606         (CppStyleTest.test_declaration): Deleted.
1607         (CppStyleTest.test_pointer_reference_marker_location): Deleted.
1608         (CppStyleTest.test_indent): Deleted.
1609         (CppStyleTest.test_indent.Foo): Deleted.
1610         (CppStyleTest.test_not_alabel): Deleted.
1611         (CppStyleTest.test_tab): Deleted.
1612         (CppStyleTest.test_unnamed_namespaces_in_headers): Deleted.
1613         (CppStyleTest.test_build_class): Deleted.
1614         (CppStyleTest.test_build_class.definitions): Deleted.
1615         (CppStyleTest.test_build_class.Foo): Deleted.
1616         (CppStyleTest.test_build_class.DERIVE_FROM_GOO): Deleted.
1617         (CppStyleTest.test_build_end_comment): Deleted.
1618         (CppStyleTest.test_build_forward_decl): Deleted.
1619         (CppStyleTest.test_build_forward_decl.Foo): Deleted.
1620         (CppStyleTest.test_build_header_guard): Deleted.
1621         (CppStyleTest.test_build_header_guard.Foo_h): Deleted.
1622         (CppStyleTest.test_build_header_guard.Foo_h.for): Deleted.
1623         (CppStyleTest.test_build_printf_format): Deleted.
1624         (CppStyleTest.test_runtime_printf_format): Deleted.
1625         (CppStyleTest.assert_lintLogCodeOnError): Deleted.
1626         (CppStyleTest.test_build_storage_class): Deleted.
1627         (CppStyleTest.test_build_storage_class.unsignedLongLong): Deleted.
1628         (CppStyleTest.test_build_storage_class.declaration): Deleted.
1629         (CppStyleTest.test_build_storage_class.after): Deleted.
1630         (CppStyleTest.test_build_storage_class.is): Deleted.
1631         (CppStyleTest.test_legal_copyright): Deleted.
1632         (CppStyleTest.test_invalid_increment): Deleted.
1633         (CppStyleTest.test_enum_bitfields): Deleted.
1634         (CppStyleTest.test_plain_integral_bitfields): Deleted.
1635         (CleansedLinesTest.test_init_empty): Deleted.
1636         (CleansedLinesTest.test_collapse_strings): Deleted.
1637         (OrderOfIncludesTest.tearDown): Deleted.
1638         (OrderOfIncludesTest.test_check_next_include_order__no_config): Deleted.
1639         (OrderOfIncludesTest.test_check_next_include_order__no_self): Deleted.
1640         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config): Deleted.
1641         (OrderOfIncludesTest.test_check_next_include_order__other_then_config): Deleted.
1642         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely): Deleted.
1643         (OrderOfIncludesTest.test_check_alphabetical_include_order): Deleted.
1644         (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines): Deleted.
1645         (OrderOfIncludesTest.test_check_line_break_after_own_header): Deleted.
1646         (OrderOfIncludesTest.test_check_line_break_before_own_header): Deleted.
1647         (OrderOfIncludesTest.test_check_preprocessor_in_include_section): Deleted.
1648         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.BAZ): Deleted.
1649         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.FOOBAR): Deleted.
1650         (OrderOfIncludesTest.test_primary_header): Deleted.
1651         (OrderOfIncludesTest.test_public_primary_header): Deleted.
1652         (OrderOfIncludesTest.test_check_wtf_includes): Deleted.
1653         (OrderOfIncludesTest.test_classify_include): Deleted.
1654         (OrderOfIncludesTest.test_try_drop_common_suffixes): Deleted.
1655         (CheckForFunctionLengthsTest.tearDown): Deleted.
1656         (CheckForFunctionLengthsTest.set_min_confidence): Deleted.
1657         (CheckForFunctionLengthsTest.assert_function_lengths_check): Deleted.
1658         (CheckForFunctionLengthsTest.trigger_lines): Deleted.
1659         (CheckForFunctionLengthsTest.trigger_test_lines): Deleted.
1660         (CheckForFunctionLengthsTest.assert_function_length_check_definition): Deleted.
1661         (CheckForFunctionLengthsTest.assert_function_length_check_definition_ok): Deleted.
1662         (CheckForFunctionLengthsTest.assert_function_length_check_at_error_level): Deleted.
1663         (CheckForFunctionLengthsTest.assert_function_length_check_below_error_level): Deleted.
1664         (CheckForFunctionLengthsTest.assert_function_length_check_above_error_level): Deleted.
1665         (CheckForFunctionLengthsTest.function_body): Deleted.
1666         (CheckForFunctionLengthsTest.function_body_with_blank_lines): Deleted.
1667         (CheckForFunctionLengthsTest.function_body_with_no_lints): Deleted.
1668         (CheckForFunctionLengthsTest.test_function_length_check_declaration): Deleted.
1669         (CheckForFunctionLengthsTest.test_function_length_check_declaration_with_block_following): Deleted.
1670         (CheckForFunctionLengthsTest.test_function_length_check_class_definition): Deleted.
1671         (CheckForFunctionLengthsTest.test_function_length_check_class_definition.Test): Deleted.
1672         (CheckForFunctionLengthsTest.test_function_length_check_trivial): Deleted.
1673         (CheckForFunctionLengthsTest.test_function_length_check_empty): Deleted.
1674         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity0): Deleted.
1675         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity0): Deleted.
1676         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity0): Deleted.
1677         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1v0): Deleted.
1678         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1v0): Deleted.
1679         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1): Deleted.
1680         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1): Deleted.
1681         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity1): Deleted.
1682         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_indented): Deleted.
1683         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_blanks): Deleted.
1684         (CheckForFunctionLengthsTest.test_function_length_check_complex_definition_severity1): Deleted.
1685         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_test): Deleted.
1686         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_split_line_test): Deleted.
1687         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Deleted.
1688         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_embedded_no_lints): Deleted.
1689         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_no_lint): Deleted.
1690         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity2): Deleted.
1691         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity2): Deleted.
1692         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity2): Deleted.
1693         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity3): Deleted.
1694         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity3): Deleted.
1695         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity3): Deleted.
1696         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity4): Deleted.
1697         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity4): Deleted.
1698         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity4): Deleted.
1699         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity5): Deleted.
1700         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity5): Deleted.
1701         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity5): Deleted.
1702         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines): Deleted.
1703         (CheckForFunctionLengthsTest.test_function_length_not_determinable): Deleted.
1704         (NoNonVirtualDestructorsTest.test_no_error): Deleted.
1705         (NoNonVirtualDestructorsTest.test_no_error.Foo): Deleted.
1706         (NoNonVirtualDestructorsTest.test_no_error.MyClass): Deleted.
1707         (NoNonVirtualDestructorsTest.test_no_error.Qualified): Deleted.
1708         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed): Deleted.
1709         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed.Foo): Deleted.
1710         (NoNonVirtualDestructorsTest.test_enum_casing): Deleted.
1711         (NoNonVirtualDestructorsTest.test_enum_casing.Foo): Deleted.
1712         (NoNonVirtualDestructorsTest.test_enum_casing.Enum123): Deleted.
1713         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon): Deleted.
1714         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass): Deleted.
1715         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum): Deleted.
1716         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed): Deleted.
1717         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed.Foo): Deleted.
1718         (NoNonVirtualDestructorsTest.test_no_warn_when_derived): Deleted.
1719         (NoNonVirtualDestructorsTest.test_no_warn_when_derived.Foo): Deleted.
1720         (NoNonVirtualDestructorsTest.test_internal_braces): Deleted.
1721         (NoNonVirtualDestructorsTest.test_internal_braces.Foo): Deleted.
1722         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor): Deleted.
1723         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo): Deleted.
1724         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo.Goo): Deleted.
1725         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Goo): Deleted.
1726         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor): Deleted.
1727         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo): Deleted.
1728         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo.Goo): Deleted.
1729         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor): Deleted.
1730         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor.Qualified): Deleted.
1731         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error): Deleted.
1732         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error.Foo): Deleted.
1733         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error): Deleted.
1734         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error.Foo): Deleted.
1735         (LeakyPatternTest.assert_leaky_pattern_check): Deleted.
1736         (LeakyPatternTest.test_get_dc): Deleted.
1737         (LeakyPatternTest.test_get_dc.HWndDC): Deleted.
1738         (LeakyPatternTest.test_own_get_dc): Deleted.
1739         (LeakyPatternTest.test_create_dc): Deleted.
1740         (LeakyPatternTest.test_create_compatible_dc): Deleted.
1741         (WebKitStyleTest.test_indentation): Deleted.
1742         (WebKitStyleTest.test_indentation.Foo): Deleted.
1743         (WebKitStyleTest.test_indentation.Document): Deleted.
1744         (WebKitStyleTest.test_spacing): Deleted.
1745         (WebKitStyleTest.test_line_breaking): Deleted.
1746         (WebKitStyleTest.test_braces): Deleted.
1747         (WebKitStyleTest.test_braces.MyClass): Deleted.
1748         (WebKitStyleTest.test_braces.NS_ENUM): Deleted.
1749         (WebKitStyleTest.test_braces.CPP11EnumClass): Deleted.
1750         (WebKitStyleTest.test_braces.SOMETHING): Deleted.
1751         (WebKitStyleTest.test_null_false_zero): Deleted.
1752         (WebKitStyleTest.test_directive_indentation): Deleted.
1753         (WebKitStyleTest.test_using_std): Deleted.
1754         (WebKitStyleTest.test_using_namespace): Deleted.
1755         (WebKitStyleTest.test_max_macro): Deleted.
1756         (WebKitStyleTest.test_min_macro): Deleted.
1757         (WebKitStyleTest.test_wtf_move): Deleted.
1758         (WebKitStyleTest.test_ctype_fucntion): Deleted.
1759         (WebKitStyleTest.test_names): Deleted.
1760         (WebKitStyleTest.test_names.HTMLDocument): Deleted.
1761         (WebKitStyleTest.test_names.WebWindowFadeAnimation): Deleted.
1762         (WebKitStyleTest.test_names.declarations): Deleted.
1763         (WebKitStyleTest.test_names.struct): Deleted.
1764         (WebKitStyleTest.test_names.VectorType): Deleted.
1765         (WebKitStyleTest.test_parameter_names): Deleted.
1766         (WebKitStyleTest.test_comments): Deleted.
1767         (WebKitStyleTest.test_webkit_export_check): Deleted.
1768         (WebKitStyleTest.test_member_initialization_list): Deleted.
1769         (WebKitStyleTest.test_member_initialization_list.MyClass): Deleted.
1770         (WebKitStyleTest.test_other): Deleted.
1771         (CppCheckerTest.mock_handle_style_error): Deleted.
1772         (CppCheckerTest._checker): Deleted.
1773         (CppCheckerTest.test_init): Deleted.
1774         (CppCheckerTest.test_eq): Deleted.
1775         (CppCheckerTest.test_eq.mock_handle_style_error2): Deleted.
1776         (CppCheckerTest.test_ne): Deleted.
1777         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
1778         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1779         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1780         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1781         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1782         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1783
1784 2017-07-05  Saam Barati  <sbarati@apple.com>
1785
1786         NewArray in FTLLowerDFGToB3 does not handle speculating on doubles when having a bad time
1787         https://bugs.webkit.org/show_bug.cgi?id=174188
1788         <rdar://problem/30581423>
1789
1790         Reviewed by Mark Lam.
1791
1792         * Scripts/run-jsc-stress-tests:
1793
1794 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1795
1796         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
1797         https://bugs.webkit.org/show_bug.cgi?id=174150
1798
1799         Reviewed by Mark Lam.
1800
1801         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1802         (TestWebKitAPI::TEST):
1803
1804 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
1805
1806         Remove copy of ICU headers from WebKit
1807         https://bugs.webkit.org/show_bug.cgi?id=116407
1808
1809         Reviewed by Alex Christensen.
1810
1811         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1812         * TestWebKitAPI/Configurations/Base.xcconfig:
1813         * WebKitTestRunner/Configurations/Base.xcconfig:
1814
1815 2017-07-05  Chris Dumez  <cdumez@apple.com>
1816
1817         Regression(r218821): Bad cast to WebKit::DiagnosticLoggingClient in WKWebView's _setDiagnosticLoggingDelegate
1818         https://bugs.webkit.org/show_bug.cgi?id=174163
1819         <rdar://problem/33067518>
1820
1821         Reviewed by Alex Christensen.
1822
1823         Add API test coverage.
1824
1825         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1826         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDiagnosticLogging.mm: Added.
1827         (TEST):
1828
1829 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1830
1831         When dragging a selection, clearing the selection in dragstart should not crash the web process
1832         https://bugs.webkit.org/show_bug.cgi?id=174142
1833         <rdar://problem/33067501>
1834
1835         Reviewed by Tim Horton.
1836
1837         Adds a unit test checking that the web process does not crash when the selection is cleared while a selection
1838         drag is starting up.
1839
1840         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1841         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-clear-selection.html: Added.
1842         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1843         (TestWebKitAPI::TEST):
1844
1845 2017-07-05  Daniel Bates  <dabates@apple.com>
1846
1847         Do not pass API::FrameInfo for source frame or clear out page of target frame on
1848         API navigation
1849         https://bugs.webkit.org/show_bug.cgi?id=174170
1850         <rdar://problem/33140328>
1851
1852         Reviewed by Brady Eidson.
1853
1854         Update tests as needed for the behavior change.
1855
1856         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
1857         (TEST):
1858
1859 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
1860
1861         Add WebKitPrivateFrameworkStubs for iOS 11
1862         https://bugs.webkit.org/show_bug.cgi?id=173988
1863
1864         Reviewed by David Kilzer.
1865
1866         * DumpRenderTree/mac/Configurations/Base.xcconfig: iphoneos and iphonesimulator
1867         should use the same directory for private framework stubs.
1868         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
1869
1870 2017-07-05  Eric Carlson  <eric.carlson@apple.com>
1871
1872         [MediaStream] Protect request and web view during gUM client callback
1873         https://bugs.webkit.org/show_bug.cgi?id=174096
1874         <rdar://problem/32833102>
1875
1876         Reviewed by Youenn Fablet.
1877
1878         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1879         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
1880
1881 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1882
1883         Unreviewed, guard iOS 11-dependent UIPasteboardTests to be iOS 11+ only
1884
1885         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1886
1887 2017-07-05  Matt Lewis  <jlewis3@apple.com>
1888
1889         Unreviewed, rolling out r219128.
1890
1891         Spoke with engineer who originally submitted, Patch for APi
1892         test to follow.
1893
1894         Reverted changeset:
1895
1896         "Unreviewed, rolling out r219070."
1897         https://bugs.webkit.org/show_bug.cgi?id=174082
1898         http://trac.webkit.org/changeset/219128
1899
1900 2017-07-05  Matt Lewis  <jlewis3@apple.com>
1901
1902         Unreviewed, rolling out r219070.
1903
1904         This revision caused consistent failures of the API test
1905         UIPasteboardTests.DoNotPastePlainTextAsURL on iOS.
1906
1907         Reverted changeset:
1908
1909         "Pasting single words copied to UIPasteboard inserts URLs in
1910         editable areas"
1911         https://bugs.webkit.org/show_bug.cgi?id=174082
1912         http://trac.webkit.org/changeset/219070
1913
1914 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
1915
1916         Remove unused EFL logo from bot watcher dashboard
1917         https://bugs.webkit.org/show_bug.cgi?id=174136
1918
1919         Reviewed by Alexey Proskuryakov.
1920
1921         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Removed.
1922         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Removed.
1923
1924 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
1925
1926         [GTK] Add more GTK bots to dashboard
1927         https://bugs.webkit.org/show_bug.cgi?id=174129
1928
1929         Reviewed by Carlos Alberto Lopez Perez.
1930
1931         We have a bunch of GTK bots that I never look at because they're not on the dashboard. Add
1932         them.
1933
1934         This also changes the sort order to put WPE above GTK so that it's not buried under all the
1935         less-essential GTK bots.
1936
1937         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1938         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1939         (WebKitBuildbot):
1940
1941 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
1942
1943         [WPE] Add WPE to bot watcher dashboard
1944         https://bugs.webkit.org/show_bug.cgi?id=174119
1945
1946         Reviewed by Alexey Proskuryakov.
1947
1948         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/CREDIT: Added.
1949         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png: Added.
1950         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png: Added.
1951         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1952         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1953         (WebKitBuildbot):
1954         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1955         (table.queue-grid tr.platform.linux-wpe img.logo):
1956
1957 2017-07-03  Lucas Forschler  <lforschler@apple.com>
1958
1959         https://bugs.webkit.org/show_bug.cgi?id=174105
1960         
1961         Reviewed by Stephanie Lewis.
1962
1963         * BuildSlaveSupport/built-product-archive:
1964         (main): Add a -minify parser option
1965         (createZip): Pass along the optional Minify argument if requested
1966         (minifySource): This will trim down archives, logic limited to Mac platform.
1967
1968 2017-07-03  Matt Rajca  <mrajca@apple.com>
1969
1970         Add/remove appropriate media element behavior restrictions when updateWebsitePolicies is called
1971         https://bugs.webkit.org/show_bug.cgi?id=174103
1972
1973         Reviewed by Alex Christensen.
1974
1975         Added an API test.
1976
1977         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Expose a pause method.
1978         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1979         (TEST): Added test.
1980         * TestWebKitAPI/cocoa/TestWKWebView.h:
1981         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1982         (-[TestWKWebView stringByEvaluatingJavaScript:]): Don't simulate a user gesture when invoking the script.
1983
1984 2017-07-03  Matt Lewis  <jlewis3@apple.com>
1985
1986         Unreviewed, rolling out r219103.
1987
1988         Caused multiple build failures.
1989
1990         Reverted changeset:
1991
1992         "Remove copy of ICU headers from WebKit"
1993         https://bugs.webkit.org/show_bug.cgi?id=116407
1994         http://trac.webkit.org/changeset/219103
1995
1996 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
1997
1998         Remove copy of ICU headers from WebKit
1999         https://bugs.webkit.org/show_bug.cgi?id=116407
2000
2001         Reviewed by Alex Christensen.
2002
2003         Use WTF's copy of ICU headers.
2004
2005         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2006         * TestWebKitAPI/Configurations/Base.xcconfig:
2007         * WebKitTestRunner/Configurations/Base.xcconfig:
2008
2009 2017-07-03  Brady Eidson  <beidson@apple.com>
2010
2011         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
2012         https://bugs.webkit.org/show_bug.cgi?id=174073
2013
2014         Reviewed by Andy Estes.
2015
2016         * DumpRenderTree/mac/TestRunnerMac.mm:
2017         (TestRunner::setIconDatabaseEnabled): Call new SPI for this setting instead of WebIconDatabase stuff.
2018
2019         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:
2020         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
2021
2022 2017-07-03  Matt Lewis  <jlewis3@apple.com>
2023
2024         Unreviewed, rolling out r219083.
2025
2026         The revision caused an API failure on all testing platforms.
2027
2028         Reverted changeset:
2029
2030         "[MediaStream] Protect request and web view during gUM client
2031         callback"
2032         https://bugs.webkit.org/show_bug.cgi?id=174096
2033         http://trac.webkit.org/changeset/219083
2034
2035 2017-07-03  Jonathan Bedard  <jbedard@apple.com>
2036
2037         webkitpy: Properly number duplicated crashlogs
2038         https://bugs.webkit.org/show_bug.cgi?id=172002
2039
2040         Reviewed by Aakash Jain.
2041
2042         * Scripts/webkitpy/common/system/crashlogs.py:
2043         (CrashLogs._find_all_logs_darwin): Number multiple crash logs for a single process with
2044         an increasing integer.
2045         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2046         (CrashLogsTest.create_crash_logs_darwin): Create duplicated crashlog for testing.
2047         (CrashLogsTest.test_find_all_log_darwin): Now 7 Darwin logs instead of 5.
2048         (CrashLogsTest.test_duplicate_log_darwin): Test that duplicated logs are correctly numbered.
2049
2050 2017-07-03  Ryosuke Niwa  <rniwa@webkit.org>
2051
2052         WebContent processes crash when the network process crashes with pending connection requests
2053         https://bugs.webkit.org/show_bug.cgi?id=174065
2054         <rdar://problem/30359835>
2055
2056         Reviewed by Tim Horton.
2057
2058         Add a API to ensure UI process tries to relaunch a new network process when the network process
2059         crashes with pending network connection requests.
2060
2061         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2062         * TestWebKitAPI/Tests/WebKit2/NetworkProcessCrashWithPendingConnection.mm: Added.
2063         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2064         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2065         (-[TestNavigationDelegate webViewWebContentProcessDidTerminate:]): Added.
2066
2067 2017-07-03  Eric Carlson  <eric.carlson@apple.com>
2068
2069         [MediaStream] Protect request and web view during gUM client callback
2070         https://bugs.webkit.org/show_bug.cgi?id=174096
2071         <rdar://problem/32833102>
2072
2073         Reviewed by Youenn Fablet.
2074
2075         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2076         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
2077
2078 2017-07-03  Andy Estes  <aestes@apple.com>
2079
2080         [Xcode] Add an experimental setting to build with ccache
2081         https://bugs.webkit.org/show_bug.cgi?id=173875
2082
2083         Reviewed by Tim Horton.
2084
2085         On systems that already have ccache(1) installed, this patch adds experimental support for
2086         it to Xcode builds. It can be enabled with the WK_USE_CCACHE build setting.
2087
2088         When ccache is enabled, CC is overridden to invoke Tools/ccache/ccache-clang. This script
2089         finds the "-isysroot" argument to determine the active SDK, uses xcrun(1) and the SDK to
2090         find the toolchain from which to run clang, and then invokes ccache with the required
2091         arguments.
2092
2093         ccache is invoked with CCACHE_SLOPPINESS="pch_defines,time_macros", which is required for
2094         precompiled headers to work properly [1].
2095
2096         LDPLUSPLUS is overridden to invoke Tools/ccache/ccache-clang++. It behaves the same as
2097         ccache-clang, except it tells ccache to execute clang++ instead of clang. This is important
2098         during linking.
2099         
2100         [1] https://ccache.samba.org/manual.html#_precompiled_headers
2101
2102         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
2103         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
2104         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
2105         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
2106         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Ditto.
2107         * ccache/README.md: Added.
2108         * ccache/ccache-clang: Added.
2109         * ccache/ccache-clang++: Added.
2110         * ccache/ccache.xcconfig: Added. Overrides CC and LDPLUSPLUS when WK_USE_CACHE=YES.
2111
2112 2017-07-03  Alex Christensen  <achristensen@webkit.org>
2113
2114         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
2115         https://bugs.webkit.org/show_bug.cgi?id=174051
2116
2117         Reviewed by Tim Horton.
2118
2119         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2120         (TestWebKitAPI::TEST_F):
2121
2122 2017-07-03  Matt Lewis  <jlewis3@apple.com>
2123
2124         Unreviewed, rolling out r219024.
2125
2126         This patch cause 3 didferent test to fail.
2127
2128         Reverted changeset:
2129
2130         "REGRESSION(r215096) Queries of URLs with non-special schemes
2131         should not percent-encode single quotes"
2132         https://bugs.webkit.org/show_bug.cgi?id=174051
2133         http://trac.webkit.org/changeset/219024
2134
2135 2017-07-03  Chris Dumez  <cdumez@apple.com>
2136
2137         Drop ResourceLoadStatisticsStore's statisticsLock
2138         https://bugs.webkit.org/show_bug.cgi?id=174080
2139
2140         Reviewed by Brent Fulgham.
2141
2142         Port WebKitTestRunner to new Asynchronous Cocoa SPI.
2143
2144         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2145         (WTR::TestController::isStatisticsPrevalentResource):
2146         (WTR::TestController::isStatisticsHasHadUserInteraction):
2147         (WTR::TestController::isStatisticsGrandfathered):
2148
2149 2017-07-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2150
2151         Pasting single words copied to UIPasteboard inserts URLs in editable areas
2152         https://bugs.webkit.org/show_bug.cgi?id=174082
2153         <rdar://problem/33046992>
2154
2155         Reviewed by Tim Horton.
2156
2157         Adds 3 new unit tests to UIPasteboardTests to test cases of pasting plain text and URLs.
2158
2159         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2160         (TestWebKitAPI::setUpWebViewForPasteboardTests):
2161         (TestWebKitAPI::TEST):
2162
2163 2017-07-02  Brady Eidson  <beidson@apple.com>
2164
2165         Add API test for all parts of WebKit1 API related to favicons.
2166         https://bugs.webkit.org/show_bug.cgi?id=174069
2167
2168         Reviewed by Andy Estes.
2169
2170         These two API tests cover all WebKit1 API related to icons.
2171         
2172         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2173         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm: Added.
2174         (mainResourceData):
2175         (defaultFaviconData):
2176         (customFaviconData):
2177         (imageFromData):
2178         (+[IconLoadingProtocol canInitWithRequest:]):
2179         (+[IconLoadingProtocol canonicalRequestForRequest:]):
2180         (-[IconLoadingProtocol startLoading]):
2181         (-[IconLoadingProtocol stopLoading]):
2182         (-[IconLoadingFrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2183         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
2184         (TestWebKitAPI::TEST):
2185
2186 2017-07-01  Dan Bernstein  <mitz@apple.com>
2187
2188         [iOS] Remove code only needed when building for iOS 9.x
2189         https://bugs.webkit.org/show_bug.cgi?id=174068
2190
2191         Reviewed by Tim Horton.
2192
2193         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2194         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2195         (WTR::initializeWebViewConfiguration):
2196         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2197         (-[HIDEventGenerator _createIOHIDEventType:]):
2198
2199 2017-07-01  Brady Eidson  <beidson@apple.com>
2200
2201         When setting a custom cookie storage location on a WKWebsiteDataStore, cookies aren't actually removed.
2202         <rdar://problem/32410662> and https://bugs.webkit.org/show_bug.cgi?id=174035
2203
2204         Reviewed by Alex Christensen.
2205
2206         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2207
2208 2017-07-01  Dan Bernstein  <mitz@apple.com>
2209
2210         [macOS] Remove code only needed when building for OS X Yosemite
2211         https://bugs.webkit.org/show_bug.cgi?id=174067
2212
2213         Reviewed by Tim Horton.
2214
2215         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2216         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2217         * DumpRenderTree/mac/DumpRenderTree.mm:
2218         (setDefaultsToConsistentValuesForTesting):
2219         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2220         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
2221         * MiniBrowser/Configurations/Base.xcconfig:
2222         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2223         * TestWebKitAPI/Configurations/Base.xcconfig:
2224         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2225         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2226         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2227         (TestWebKitAPI::TEST_F):
2228         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
2229         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
2230         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2231         (TestWebKitAPI::TEST_F):
2232         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
2233         (TestWebKitAPI::TEST):
2234         * WebKitTestRunner/Configurations/Base.xcconfig:
2235         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2236         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2237         (WTR::InjectedBundle::platformInitialize):
2238         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
2239         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
2240
2241 2017-07-01  Chris Dumez  <cdumez@apple.com>
2242
2243         Replace ResourceLoadStatisticsStore C API with Cocoa SPI
2244         https://bugs.webkit.org/show_bug.cgi?id=174060
2245
2246         Reviewed by Brent Fulgham.
2247
2248         Port WebKitTestRunner over to the new Cocoa SPI.
2249
2250         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2251         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2252         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2253         Drop calls to the WKResourceLoadStatisticsStore C API here. Those were
2254         no-ops since this code runs in the WebContent process, not the
2255         UIProcess.
2256
2257         * WebKitTestRunner/TestController.cpp:
2258         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2259
2260 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
2261
2262         Unreviewed mac build fix.
2263
2264         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
2265         (TestWebKitAPI::TEST):
2266
2267 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
2268
2269         Add API to get WKActivatedElementInfo
2270         https://bugs.webkit.org/show_bug.cgi?id=174001
2271         <rdar://problem/29165518>
2272         
2273         Tests for now SPI to get activatedElementInfo.
2274
2275         Reviewed by Tim Horton.
2276
2277         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2278         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm: Added.
2279         (TestWebKitAPI::TEST):
2280
2281 2017-06-30  Chris Dumez  <cdumez@apple.com>
2282
2283         Move store logic from WebResourceLoadStatisticsManager to WebResourceLoadStatisticsStore
2284         https://bugs.webkit.org/show_bug.cgi?id=174038
2285
2286         Reviewed by Brent Fulgham.
2287
2288         Fix typo in API name.
2289
2290         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2291         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2292         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2293         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2294         * WebKitTestRunner/TestController.cpp:
2295         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2296         * WebKitTestRunner/TestController.h:
2297         * WebKitTestRunner/TestInvocation.cpp:
2298         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2299
2300 2017-06-30  Alex Christensen  <achristensen@webkit.org>
2301
2302         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
2303         https://bugs.webkit.org/show_bug.cgi?id=174051
2304         <rdar://problem/33002846>
2305
2306         Reviewed by Tim Horton.
2307
2308         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2309         (TestWebKitAPI::TEST_F):
2310
2311 2017-06-30  Daniel Bates  <dabates@apple.com>
2312
2313         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
2314         https://bugs.webkit.org/show_bug.cgi?id=165160
2315         <rdar://problem/29451999>
2316
2317         Reviewed by Brady Eidson.
2318
2319         Add tests to ensure that -[WKFrameInfo webView] is computed correctly for the source and target frame
2320         for navigations and window creation.
2321
2322         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2323         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm: Added. Derived from file ShouldOpenExternalURLsInNewWindowActions.mm.
2324         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
2325         (-[DecidePolicyForNavigationActionController webView:didFinishNavigation:]):
2326         (-[DecidePolicyForNavigationActionController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2327         (TEST):
2328
2329 2017-06-29  Jer Noble  <jer.noble@apple.com>
2330
2331         Make Legacy EME API controlled by RuntimeEnabled setting.
2332         https://bugs.webkit.org/show_bug.cgi?id=173994
2333
2334         Reviewed by Sam Weinig.
2335
2336         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2337
2338 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
2339
2340         Follow-up fix for r218996
2341
2342         Unreviewed infrastructure fix.
2343
2344         Repeated calls to 'ios_version' make the log noisy, memoize the function.
2345
2346         * Scripts/webkitpy/port/ios_simulator.py:
2347         (IOSSimulatorPort): Memoize ios_version().
2348
2349 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
2350
2351         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
2352         https://bugs.webkit.org/show_bug.cgi?id=174017
2353         <rdar://problem/32959782>
2354
2355         Reviewed by Simon Fraser.
2356
2357         Add a new test verifying that the drag caret is visually contained within the bounds of an iframe. Before these
2358         changes, the caret would appear outside of the iframe.
2359
2360         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2361         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-in-iframe.html: Added.
2362         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2363         (checkDragCaretRectIsContainedInRect):
2364         (TestWebKitAPI::TEST):
2365         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2366         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2367         (-[DataInteractionSimulator _resetSimulatedState]):
2368         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
2369         (-[DataInteractionSimulator _advanceProgress]):
2370         (-[DataInteractionSimulator lastKnownDragCaretRect]):
2371
2372 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
2373
2374         Add support for different versions of iOS when loading test expectations
2375         https://bugs.webkit.org/show_bug.cgi?id=173774
2376         <rdar://problem/32951132>
2377
2378         Rubber-stamped by Aakash Jain.
2379
2380         When running layout tests, we should support multiple version of iOS the same way we do Mac.
2381
2382         * Scripts/webkitpy/port/ios.py:
2383         (IOSPort.default_baseline_search_path): Add ios-<major version> test expectation.
2384         (IOSPort.test_expectations_file_position): Added new file expectations, increment expected file position.
2385         (IOSPort.ios_version): iOS ports must define a function to retrieve the iOS version.
2386         * Scripts/webkitpy/port/ios_device.py:
2387         (IOSDevicePort.ios_version): Ask connected devices for implementation.
2388         * Scripts/webkitpy/port/ios_device_unittest.py:
2389         (IOSDeviceTest.test_additional_platform_directory): Skip test until bug 173775 is finished.
2390         (IOSDeviceTest.test_baseline_searchpath): Ditto.
2391         (IOSDeviceTest.test_expectations_ordering): Ditto.
2392         * Scripts/webkitpy/port/ios_simulator.py:
2393         (IOSSimulatorPort.ios_version): If a runtime is specified, ask the runtime for the iOS version. Otherwise,
2394         ask the platform.
2395
2396 2017-06-30  Jacobo Aragunde Pérez  <jaragunde@igalia.com>
2397
2398         Fontconfig build breaks with glibc 2.15+
2399         https://bugs.webkit.org/show_bug.cgi?id=174019
2400
2401         Reviewed by Carlos Alberto Lopez Perez.
2402
2403         Apply patch by Khem Raj adapted to fontconfig 2.11.1.
2404
2405         * wpe/jhbuild.modules:
2406         * wpe/patches/fontconfig-avoid-conflicts-with-integer-width-macros-from-TS-18.patch: Added.
2407
2408 2017-06-29  Wenson Hsieh  <wenson_hsieh@apple.com>
2409
2410         [iOS DnD] Web content process crashes when the selection is moved far offscreen in dragstart
2411         https://bugs.webkit.org/show_bug.cgi?id=174010
2412         <rdar://problem/32597802>
2413
2414         Reviewed by Tim Horton.
2415
2416         Adds a new API test to ensure that we don't crash trying to dereference a null RefPtr when the TextIndicator
2417         snapshot fails for any reason.
2418
2419         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2420         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-change-selection-offscreen.html: Added.
2421         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2422         (TestWebKitAPI::TEST):
2423
2424 2017-06-29  Chris Fleizach  <cfleizach@apple.com>
2425
2426         AX: Cannot call setValue() on contenteditable or ARIA text controls
2427         https://bugs.webkit.org/show_bug.cgi?id=173520
2428
2429         Reviewed by Ryosuke Niwa.
2430
2431         Add setValue() method to WKTR (already existed in DRT).
2432
2433         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2434         (WTR::AccessibilityUIElement::setValue):
2435         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2436         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2437         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2438         (WTR::AccessibilityUIElement::setValue):
2439
2440 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
2441
2442         getBoundingClientRect returns wrong value for combination of page zoom and scroll
2443         https://bugs.webkit.org/show_bug.cgi?id=173841
2444         rdar://problem/32983841
2445
2446         Reviewed by Dean Jackson.
2447
2448         Make "Zoom In" and "Zoom Out" work correctly in the WebKit1 window. Previously they
2449         always did text zooming.
2450
2451         * MiniBrowser/mac/WK1BrowserWindowController.m:
2452         (-[WK1BrowserWindowController zoomIn:]):
2453         (-[WK1BrowserWindowController zoomOut:]):
2454         (-[WK1BrowserWindowController canResetZoom]):
2455         (-[WK1BrowserWindowController resetZoom:]):
2456
2457 2017-06-29  John Wilander  <wilander@apple.com>
2458
2459         Fix for intermittent Layout Test fail http/tests/loading/resourceLoadStatistics/telemetry-generation.html
2460         https://bugs.webkit.org/show_bug.cgi?id=173940
2461         <rdar://problem/33018125>
2462
2463         Reviewed by Brent Fulgham.
2464
2465         This change allows the TestController to turn off
2466         regular resource load statistics telemetry submission
2467         and to manually control when telemetry is calculated
2468         and submitted.
2469
2470         * WebKitTestRunner/TestController.cpp:
2471         (WTR::TestController::initialize):
2472             Turns off automatic resource load statistics telemetry submission.
2473
2474 2017-06-29  Commit Queue  <commit-queue@webkit.org>
2475
2476         Unreviewed, rolling out r218512.
2477         https://bugs.webkit.org/show_bug.cgi?id=173981
2478
2479         "It changes the behavior of the JS API's JSEvaluateScript
2480         which breaks TurboTax" (Requested by saamyjoon on #webkit).
2481
2482         Reverted changeset:
2483
2484         "test262: Completion values for control flow do not match the
2485         spec"
2486         https://bugs.webkit.org/show_bug.cgi?id=171265
2487         http://trac.webkit.org/changeset/218512
2488
2489 2017-06-29  Jonathan Bedard  <jbedard@apple.com>
2490
2491         Add WebKitSystemInterface for iOS 11
2492         https://bugs.webkit.org/show_bug.cgi?id=173936
2493
2494         Reviewed by Lucas Forschler.
2495
2496         * Scripts/copy-webkitlibraries-to-product-directory: Copy iOS 11 WebKitSystemInterface libraries. 
2497
2498 2017-06-28  Keith Miller  <keith_miller@apple.com>
2499
2500         VMTraps has some races
2501         https://bugs.webkit.org/show_bug.cgi?id=173941
2502
2503         Reviewed by Michael Saboff.
2504
2505         Add new testing mode for testing the Watchdog with our stress
2506         tests.
2507
2508         * Scripts/run-jsc-stress-tests:
2509
2510 2017-06-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2511
2512         [GTK][WPE] Implement API::IconLoadingClient and rework WebKitFaviconDatabase to use IconDatabase directly
2513         https://bugs.webkit.org/show_bug.cgi?id=173877
2514
2515         Reviewed by Brady Eidson.
2516
2517         Update favicons unit test to ensure we wait until the database is updated in testGetFavicon() before starting
2518         the next tests.
2519
2520         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
2521         (testGetFavicon):
2522
2523 2017-06-28  Tim Horton  <timothy_horton@apple.com>
2524
2525         MobileSafari was constantly using 10-15% CPU viewing a PDF
2526         https://bugs.webkit.org/show_bug.cgi?id=173944
2527         <rdar://problem/33039910>
2528
2529         Reviewed by Simon Fraser.
2530
2531         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2532         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewStablePresentationUpdateCallback.mm:
2533         Add a test that we ever call the stable presentation update callback
2534         when we have a WKPDFView up, instead of infinitely looping.
2535
2536 2017-06-28  Alex Christensen  <achristensen@webkit.org>
2537
2538         Prevent displaying URLs with small capital letters
2539         https://bugs.webkit.org/show_bug.cgi?id=173949
2540         <rdar://problem/32952058>
2541
2542         Reviewed by Brent Fulgham.
2543
2544         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
2545         (TestWebKitAPI::TEST):
2546
2547 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
2548
2549         Unreviewed test fix.
2550
2551         Disable the file monitor tests on iOS because the 'system' API is unavailable on that platform.
2552
2553         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: 
2554
2555 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
2556
2557         Teach ResourceLoadStatistics to recognize changes in the file system
2558         https://bugs.webkit.org/show_bug.cgi?id=173800
2559         <rdar://problem/32937842>
2560
2561         Reviewed by Chris Dumez.
2562
2563         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2564         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: Added.
2565         (TestWebKitAPI::FileMonitorTest::tempFilePath):
2566         (TestWebKitAPI::handleFileModification):
2567         (TestWebKitAPI::handleFileDeletion):
2568         (TestWebKitAPI::resetTestState):
2569         (TestWebKitAPI::TEST_F):
2570
2571 2017-06-28  Brady Eidson  <beidson@apple.com>
2572
2573         DocumentLoader should always notify the client if there are pending icon loads when the load is stopped.
2574         https://bugs.webkit.org/show_bug.cgi?id=173874
2575
2576         Reviewed by Alex Christensen.
2577
2578         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
2579
2580 2017-06-28  Don Olmstead  <don.olmstead@sony.com>
2581
2582         Unreviewed, adding Don Olmstead to contributors.json
2583
2584         * Scripts/webkitpy/common/config/contributors.json:
2585
2586 2017-06-28  Alex Christensen  <achristensen@webkit.org>
2587
2588         WebsitePolicies given with navigation policy for redirects should apply to the provisional document
2589         https://bugs.webkit.org/show_bug.cgi?id=173886
2590         <rdar://problem/32543191>
2591
2592         Reviewed by Andy Estes.
2593
2594         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2595         (ParsedRange::ParsedRange):
2596         (-[TestSchemeHandler initWithVideoData:]):
2597         (-[TestSchemeHandler webView:startURLSchemeTask:]):
2598         (-[TestSchemeHandler webView:stopURLSchemeTask:]):
2599         (TEST):
2600
2601 2017-06-27  JF Bastien  <jfbastien@apple.com>
2602
2603         WebAssembly: running out of executable memory should throw OoM
2604         https://bugs.webkit.org/show_bug.cgi?id=171537
2605         <rdar://problem/32963338>
2606
2607         Reviewed by Saam Barati.
2608
2609         * Scripts/run-jsc-stress-tests: add a configuration which runs the
2610         tests under limited executable memory and avoids non-WebAssembly
2611         code generation so that we more reliably run out of executable
2612         memory in WebAssembly.
2613
2614 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2615
2616         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
2617         https://bugs.webkit.org/show_bug.cgi?id=173854
2618         <rdar://problem/32236827>
2619
2620         Reviewed by Ryosuke Niwa and Tim Horton.
2621
2622         Adds a new test to check that an image can be dragged out of a contenteditable and dropped.
2623
2624         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2625         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-target.html: Added.
2626         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2627         (TestWebKitAPI::TEST):
2628
2629 2017-06-27  Don Olmstead  <don.olmstead@sony.com>
2630
2631         [PAL] Add symbol export macros for PAL
2632         https://bugs.webkit.org/show_bug.cgi?id=171519
2633
2634         Reviewed by Konstantin Tokarev.
2635
2636         * DumpRenderTree/config.h:
2637         * TestWebKitAPI/CMakeLists.txt:
2638         * TestWebKitAPI/config.h:
2639         * WebKitTestRunner/config.h:
2640
2641 2017-06-27  John Wilander  <wilander@apple.com>
2642
2643         Resource Load Statistics: Add telemetry
2644         https://bugs.webkit.org/show_bug.cgi?id=173499
2645         <rdar://problem/32826094>
2646
2647         Reviewed by Brent Fulgham.
2648
2649         Adds three new testRunner functions:
2650         - installStatisticsDidRunTelemetryCallback()
2651         - statisticsFireTelemetryHandler()
2652         - setStatisticsNotifyPagesWhenTelemetryWasCaptured()
2653
2654         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2655         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2656         (WTR::InjectedBundle::didReceiveMessageToPage):
2657         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2658         (WTR::TestRunner::installStatisticsDidRunTelemetryCallback):
2659         (WTR::TestRunner::statisticsDidRunTelemetryCallback):
2660         (WTR::TestRunner::statisticsFireTelemetryHandler):
2661         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2662         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2663         * WebKitTestRunner/TestController.cpp:
2664         (WTR::TestController::resetStateToConsistentValues):
2665         (WTR::TestController::statisticsFireTelemetryHandler):
2666         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2667         * WebKitTestRunner/TestController.h:
2668         * WebKitTestRunner/TestInvocation.cpp:
2669         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2670
2671 2017-06-27  Ting-Wei Lan  <lantw44@gmail.com>
2672
2673         Add missing includes to fix compilation error on FreeBSD
2674         https://bugs.webkit.org/show_bug.cgi?id=172919
2675
2676         Reviewed by Mark Lam.
2677
2678         * ImageDiff/cairo/PlatformImageCairo.cpp:
2679
2680 2017-06-26  Jonathan Bedard  <jbedard@apple.com>
2681
2682         Unreviewed, rolling out r218783.
2683
2684         Causing accessibility/mac/setting-attributes-is-
2685         asynchronous.html to crash consistently on mac-wk2 Debug
2686
2687         Reverted changeset:
2688
2689         "AX: Cannot call setValue() on contenteditable or ARIA text
2690         controls"
2691         https://bugs.webkit.org/show_bug.cgi?id=173520
2692         http://trac.webkit.org/changeset/218783
2693
2694 2017-06-26  Yusuke Suzuki  <utatane.tea@gmail.com>
2695
2696         [WTF] Drop Thread::create(obsolete things) API since we can use lambda
2697         https://bugs.webkit.org/show_bug.cgi?id=173825
2698
2699         Reviewed by Saam Barati.
2700
2701         * DumpRenderTree/JavaScriptThreading.cpp:
2702         (runJavaScriptThread):
2703         (startJavaScriptThreads):
2704         * DumpRenderTree/mac/DumpRenderTree.mm:
2705         (runThread):
2706         (runPthread):
2707         (testThreadIdentifierMap):
2708
2709 2017-06-26  David Kilzer  <ddkilzer@apple.com>
2710
2711         [TestWebKitAPI] Fix false-positive bad release warnings found by clang static analyzer
2712         <https://webkit.org/b/173837>
2713
2714         Reviewed by Geoffrey Garen.
2715
2716         The clang static analyzer can't reason about objects that are
2717         assigned to a delegate as +1 retained, and then released
2718         later in a different method when the delegate is cleared.
2719
2720         Instead, use a common idiom where the object setting the
2721         delegate retains it as an instance variable on initialization.
2722         Then the same object clears the delegate and releases its
2723         instance variable during teardown.
2724
2725         Also add EXPECT_TRUE() tests to make sure the delegate objects
2726         match before teardown.
2727
2728         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2729         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
2730         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
2731         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2732         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
2733         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::teardownView):
2734
2735 2017-06-26  David Kilzer  <ddkilzer@apple.com>
2736
2737         [TestWebKitAPI] REGRESSION (r218750): Fix leak of NSURLResponse in WKURLSchemeHandler-1.mm
2738         <https://webkit.org/b/173836>
2739
2740         Reviewed by Brady Eidson.
2741
2742         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2743         (-[RedirectSchemeHandler webView:startURLSchemeTask:]): Use
2744         adoptNS() to fix the leak.  Also use auto/adoptNS() for other
2745         objects in this test.
2746
2747 2017-06-26  Joanmarie Diggs  <jdiggs@igalia.com>
2748
2749         [ATK] Add support for aria-details and aria-errormessage
2750         https://bugs.webkit.org/show_bug.cgi?id=172588
2751
2752         Reviewed by Chris Fleizach.
2753
2754         Add additional methods to test ARIA properties which are exposed via
2755         AtkRelation. Also bump minimum versions of at-spi2-core and at-spi2-atk
2756         to versions which support the details and error-message relation types.
2757
2758         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2759         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
2760         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
2761         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
2762         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
2763         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2764         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2765         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
2766         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
2767         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
2768         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
2769         * gtk/jhbuild.modules:
2770
2771 2017-06-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2772
2773         Unreviewed. Add libfii to GTK+ install dependencies script.
2774
2775         * gtk/install-dependencies:
2776
2777 2017-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
2778
2779         Unreviewed, rolling out r215190.
2780
2781         Broke product select element on GNOME Bugzilla
2782
2783         Reverted changeset:
2784
2785         "[GTK] Misplaced right click menu on web page due to
2786         deprecated gtk_menu_popup()"
2787         https://bugs.webkit.org/show_bug.cgi?id=170553
2788         http://trac.webkit.org/changeset/215190
2789
2790 2017-06-24  Joseph Pecoraro  <pecoraro@apple.com>
2791
2792         Remove Reflect.enumerate
2793         https://bugs.webkit.org/show_bug.cgi?id=173806
2794
2795         Reviewed by Yusuke Suzuki.
2796
2797         * Scripts/run-jsc-stress-tests:
2798
2799 2017-06-24  Chris Fleizach  <cfleizach@apple.com>
2800
2801         AX: Cannot call setValue() on contenteditable or ARIA text controls
2802         https://bugs.webkit.org/show_bug.cgi?id=173520
2803
2804         Reviewed by Ryosuke Niwa.
2805
2806         Add setValue() method to WKTR (already existed in DRT).
2807
2808         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2809         (WTR::AccessibilityUIElement::setValue):
2810         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2811         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2812         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2813         (WTR::AccessibilityUIElement::setValue):
2814
2815 2017-06-23  Keith Miller  <keith_miller@apple.com>
2816
2817         Switch VMTraps to use halt instructions rather than breakpoint instructions
2818         https://bugs.webkit.org/show_bug.cgi?id=173677
2819
2820         Reviewed by JF Bastien.
2821
2822         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
2823         (TEST):
2824
2825 2017-06-23  Youenn Fablet  <youenn@apple.com>
2826
2827         Set getUserMedia permission to true by default on WTR
2828         https://bugs.webkit.org/show_bug.cgi?id=173610
2829
2830         Reviewed by Alex Christensen.
2831
2832         Adding a way to reset the getUserMedia permission to pending.
2833
2834         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2835         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2836         (WTR::InjectedBundle::setUserMediaPermissionAsUnset):
2837         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2838         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2839         (WTR::TestRunner::setUserMediaPermissionAsUnset):
2840         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2841         * WebKitTestRunner/TestController.cpp:
2842         (WTR::TestController::resetStateToConsistentValues):
2843         (WTR::TestController::setUserMediaPermissionAsUnset):
2844         * WebKitTestRunner/TestController.h:
2845         * WebKitTestRunner/TestInvocation.cpp:
2846         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2847
2848 2017-06-23  Alex Christensen  <achristensen@webkit.org>
2849
2850         Add SPI to WKURLSchemeTask for redirection
2851         https://bugs.webkit.org/show_bug.cgi?id=173730
2852
2853         Reviewed by Brady Eidson.
2854
2855         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2856         (-[SchemeHandler webView:startURLSchemeTask:]):
2857         (-[SchemeHandler webView:stopURLSchemeTask:]):
2858         (TEST):
2859         (-[RedirectSchemeHandler webView:startURLSchemeTask:]):
2860         (-[RedirectSchemeHandler webView:stopURLSchemeTask:]):
2861         (-[RedirectSchemeHandler webView:didReceiveServerRedirectForProvisionalNavigation:]):
2862         (-[RedirectSchemeHandler webView:decidePolicyForNavigationResponse:decisionHandler:]):
2863         (-[RedirectSchemeHandler userContentController:didReceiveScriptMessage:]):
2864
2865 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2866
2867         [WPE] Use JSC API to send script messages from web extension in tests
2868         https://bugs.webkit.org/show_bug.cgi?id=173757
2869
2870         Reviewed by Žan Doberšek.
2871
2872         The GTK+ uses DOM bindings to send the messages. We can just build the message string and use JSEvaluateScript
2873         to run postMessage().
2874
2875         Fixes: /wpe/WebKitSecurityManager/file-xhr
2876                /wpe/WebKitConsoleMessage/console-api
2877                /wpe/WebKitConsoleMessage/js-exception
2878                /wpe/WebKitConsoleMessage/network-error
2879                /wpe/WebKitConsoleMessage/security-error
2880
2881         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
2882         (testWebKitConsoleMessageSecurityError): Remove ifdefs.
2883         (beforeAll): Ditto.
2884         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
2885         (testWebContextSecurityFileXHR): Ditto.
2886         (beforeAll): Ditto.
2887         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2888         (consoleMessageSentCallback): Use JSEvaluateScript in WPE. We need to escape the '"' in the message string.
2889         (pageCreatedCallback): Remove ifdefs.
2890
2891 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2892
2893         Unreviewed. Fix WPE /wpe/WebKitWebView/javascript-dialogs and /wpe/WebKitWebView/window-properties
2894
2895         Skip onbeforeunload dialog tests for now in WPE since we don't have a implemention for
2896         simulateUserInteraction(). And do not expect changes in "geometry" property of WebKitWindowProperties that
2897         doesn't exist yet in WPE.
2898
2899         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2900         (testWebViewJavaScriptDialogs):
2901         (testWebViewWindowProperties):
2902
2903 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2904
2905         [GTK] Upgrade pixman and cairo in jhbuild
2906         https://bugs.webkit.org/show_bug.cgi?id=173710
2907
2908         Reviewed by Carlos Alberto Lopez Perez.
2909
2910         * gtk/jhbuild.modules:
2911
2912 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2913
2914         REGRESSION(r218686): [GTK] Several unit tests are failing after r218686 in the bots
2915         https://bugs.webkit.org/show_bug.cgi?id=173711
2916
2917         Reviewed by Carlos Alberto Lopez Perez.
2918
2919         I can't reproduce it locally, but it's complaining about a g_setenv() and I only added one in r218686 to recover
2920         the XDG_RUNTIME_DIR, because it's required by Wayland to work. So, I guess that env var is not set in the bots.
2921
2922         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2923         (WebKitTestBus::run): Ensure value is not nullptr before calling g_setenv().
2924
2925 2017-06-22  David Kilzer  <ddkilzer@apple.com>
2926
2927         REGRESSION (r218419): 7 leaks in PluginLoadClientPolicies.mm
2928         <https://webkit.org/b/173721>
2929
2930         Reviewed by Joseph Pecoraro.
2931
2932         Use RetainPtr<> to create NSMutableDictionary and NSNumber
2933         objects to fix leaks and to avoid the autoreleasepool.
2934
2935         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm:
2936         (TEST):
2937
2938 2017-06-22  Matt Lewis  <jlewis3@apple.com>
2939
2940         Unreviewed, rolling out r218633.
2941
2942         The test is failing frequently on Sierra Debug and Windows
2943
2944         Reverted changeset:
2945
2946         "AX: Cannot call setValue() on contenteditable or ARIA text
2947         controls"
2948         https://bugs.webkit.org/show_bug.cgi?id=173520
2949         http://trac.webkit.org/changeset/218633
2950
2951 2017-06-22  David Kilzer  <ddkilzer@apple.com>
2952
2953         [TestWebKitAPI] Fix misuse of -[NSData dataWithBytesNoCopy:length:] with global variables
2954         <https://webkit.org/b/173690>
2955
2956         Reviewed by Chris Dumez.
2957
2958         Per documentation, -[NSData dataWithBytesNoCopy:length:] takes
2959         ownership of malloc()-ed memory, then frees it when it's
2960         released.  These tests were passing global variables into the
2961         method, which is not malloc()-ed memory, which violates the API
2962         contract.
2963
2964         The fix is to switch to use
2965         -[NSData dataWithBytesNoCopy:length:freeWhenDone:] and to pass
2966         NO for the last argument.
2967
2968         Caught by the clang static analyzer.
2969
2970         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
2971         (TEST):
2972         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2973         (TEST):
2974
2975 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2976
2977         [GTK] Upgrade Harfbuzz to version 1.4.2
2978         https://bugs.webkit.org/show_bug.cgi?id=173592
2979
2980         Reviewed by Carlos Alberto Lopez Perez.
2981
2982         * gtk/jhbuild.modules:
2983
2984 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2985
2986         [WPE] Update WPEBackend-mesa
2987         https://bugs.webkit.org/show_bug.cgi?id=173705
2988
2989         Reviewed by Carlos Alberto Lopez Perez.
2990
2991         A crash has been fixed, needed for unit tests to work.
2992
2993         * wpe/jhbuild.modules:
2994
2995 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2996
2997         Remove unused coordinated graphics C API
2998         https://bugs.webkit.org/show_bug.cgi?id=173706
2999
3000         Reviewed by Žan Doberšek.
3001
3002         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp: Removed.
3003         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp: Removed.
3004         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Removed.
3005         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: Removed.
3006         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Removed.
3007         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Removed.
3008
3009 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3010
3011         [WPE] Build glib API tests
3012         https://bugs.webkit.org/show_bug.cgi?id=173702
3013
3014         Reviewed by Žan Doberšek.
3015
3016         Many of the tests pass without problems, others need to be investigated, and some others are known issues. The
3017         main difference between the GTK+ and WPE WebKitWebView is that in GTK+ it's a GtkWidget, so initially
3018         unowned. The tests assume that webkit_web_view_new methods return a floating reference. This patch adds
3019         Test::adoptView() method that returns a GRefPtr<WebKitWebView> with a different implementation in GTK+ and
3020         WPE. In the case of GTK+, it sinks the floating reference, while in WPE it simply adopts the reference. Another
3021         difference is that in GTK+ the web view is initially hidden and needs to be added to a window to make it
3022         visible. Also, some tests need the web view to be realized to work, and others need that the view is added to a
3023         toplevel window, instead of a popup window. All those things are not needed at all in WPE. I've added several
3024         #ifdefs with FIXME comments for the things that we know don't work in WPE yet, for example, because we haven't
3025         implemented the methods to send events to the web view. Those will be removed eventually when we fix the issues
3026         and implement the missing features.
3027
3028         * CMakeLists.txt:
3029         * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp:
3030         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
3031         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3032         (testAutomationSessionRequestSession):
3033         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
3034         (testWebKitWebViewSessionState):
3035         (testWebKitWebViewSessionStateWithFormData):
3036         (testWebKitWebViewNavigationAfterSessionRestore):
3037         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
3038         (beforeAll):
3039         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3040         (testCookieManagerEphemeral):
3041         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
3042         (testBlobDownload):
3043         (beforeAll):
3044         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
3045         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3046         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
3047         (testProcessPerWebView):
3048         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
3049         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3050         (testWebViewCreateNavigationData):
3051         (testWebViewJavaScriptDialogs):
3052         (testWebViewWindowProperties):
3053         (testWebViewMouseTarget):
3054         (testWebViewGeolocationPermissionRequests):
3055         (testWebViewUserMediaPermissionRequests):
3056         (testWebViewAudioOnlyUserMediaPermissionRequests):
3057         (testWebViewFileChooserRequest):
3058         (beforeAll):
3059         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
3060         (beforeAll):
3061         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
3062         (testPrivateBrowsing):
3063         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
3064         (testFindControllerHide):
3065         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
3066         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3067         (testWebKitSettings):
3068         (beforeAll):
3069         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3070         (testWebViewNewWithUserContentManager):
3071         (beforeAll):
3072         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
3073         (testWebContextEphemeral):
3074         (testWebContextProxySettings):
3075         (beforeAll):
3076         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3077         (testWebViewWebContext):
3078         (testWebViewWebContextLifetime):
3079         (testWebViewEphemeral):
3080         (testWebViewSettings):
3081         (testWebViewCanShowMIMEType):
3082         (testWebViewPageVisibility):
3083         (testWebViewIsPlayingAudio):
3084         (beforeAll):
3085         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
3086         (testWebsiteDataEphemeral):
3087         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3088         (documentLoadedCallback):
3089         (pageCreatedCallback):
3090         (methodCallCallback):
3091         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h:
3092         * TestWebKitAPI/glib/CMakeLists.txt:
3093         * TestWebKitAPI/glib/PlatformGTK.cmake:
3094         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
3095         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
3096         (main):
3097         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3098         (Test::adoptView):
3099         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3100         (WebKitTestBus::run):
3101         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
3102         (WebViewTest::~WebViewTest):
3103         (WebViewTest::initializeWebView):
3104         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
3105         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp: Added.
3106         (WebViewTest::platformDestroy):
3107         (WebViewTest::platformInitializeWebView):
3108         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
3109         (WebViewTest::resizeView):
3110         (WebViewTest::hideView):
3111         (parentWindowMapped):
3112         (WebViewTest::showInWindow):
3113         (WebViewTest::showInWindowAndWaitUntilMapped):
3114         (WebViewTest::mouseMoveTo):
3115         (WebViewTest::clickMouseButton):
3116         (WebViewTest::emitPopupMenuSignal):
3117         (WebViewTest::keyStroke):
3118         (WebViewTest::doMouseButtonEvent):
3119         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp: Copied from Tools/TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h.
3120         (WebViewTest::platformDestroy):
3121         (WebViewTest::platformInitializeWebView):
3122         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
3123         (WebViewTest::resizeView):
3124         (WebViewTest::hideView):
3125         (WebViewTest::mouseMoveTo):
3126         (WebViewTest::clickMouseButton):
3127         (WebViewTest::keyStroke):
3128
3129 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3130
3131         [GTK] Move WebKit2 GLib API tests to glib directories
3132         https://bugs.webkit.org/show_bug.cgi?id=173642
3133
3134         Reviewed by Žan Doberšek.
3135
3136         * CMakeLists.txt:
3137         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Removed.
3138         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Removed.
3139         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp.
3140         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp.
3141         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp.
3142         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp.
3143         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp.
3144         (testWebKitConsoleMessageNetworkError):
3145         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp.
3146         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp.
3147         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp.
3148         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp.
3149         (testLoadFromGResource):
3150         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp.
3151         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp.
3152         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp.
3153         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp.
3154         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp.
3155         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp.
3156         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp.
3157         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp.
3158         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp.
3159         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp.
3160         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp.
3161         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp.
3162         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp.
3163         (testWebViewRunJavaScript):
3164         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp.
3165         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp.
3166         (registerGResource):
3167         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp.
3168         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h.
3169         * TestWebKitAPI/Tests/WebKitGLib/resources/blank.ico: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico.
3170         * TestWebKitAPI/Tests/WebKitGLib/resources/boring.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html.
3171         * TestWebKitAPI/Tests/WebKitGLib/resources/link-title.js: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js.
3172         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg.
3173         * TestWebKitAPI/Tests/WebKitGLib/resources/simple.json: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json.
3174         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem.
3175         * TestWebKitAPI/Tests/WebKitGLib/resources/test-key.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem.
3176         * TestWebKitAPI/Tests/WebKitGLib/resources/test.pdf: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf.
3177         * TestWebKitAPI/Tests/WebKitGLib/resources/track.ogg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/track.ogg.
3178         * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml: Added.
3179         * TestWebKitAPI/glib/CMakeLists.txt: Added.
3180         * TestWebKitAPI/glib/PlatformGTK.cmake: Added.
3181         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp.
3182         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h.
3183         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp.
3184         (registerGResource):
3185         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h.
3186         (Test::getResourcesDir):
3187         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp.
3188         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h.
3189         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp.
3190         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h.
3191         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp.
3192         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h.
3193
3194 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3195
3196         [WPE] Add initial web extensions API
3197         https://bugs.webkit.org/show_bug.cgi?id=173640
3198
3199         Reviewed by Žan Doberšek.
3200
3201         Add style checker exceptions for WPE web extensions API files.
3202
3203         * Scripts/webkitpy/style/checker.py:
3204
3205 2017-06-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3206
3207         [iOS DnD] [WK2] Cancelling a drag interaction using the ObjC SPI causes subsequent dragging to fail
3208         https://bugs.webkit.org/show_bug.cgi?id=173659
3209         <rdar://problem/32879788>
3210
3211         Reviewed by Tim Horton.
3212
3213         Adds a new test to verify that a lift cancelled within the UI process does not cause subsequent dragging to fail.
3214
3215         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html:
3216
3217         Augment this test page to log dragend and dragstart events on the drag source as well.
3218
3219         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3220         (checkStringArraysAreEqual):
3221         (TestWebKitAPI::TEST):
3222
3223 2017-06-21  Antoine Quint  <graouts@apple.com>
3224
3225         Ensure DRT always logs rAF suspension debugging code
3226         https://bugs.webkit.org/show_bug.cgi?id=173681
3227
3228         Reviewed by Tim "Mr. T" Horton.
3229
3230         * DumpRenderTree/mac/DumpRenderTree.mm:
3231         (resetWebPreferencesToConsistentValues):
3232
3233 2017-06-21  Chris Dumez  <cdumez@apple.com>
3234
3235         Allow constructing a WTF:Function from a function pointer
3236         https://bugs.webkit.org/show_bug.cgi?id=173660
3237
3238         Reviewed by Alex Christensen.
3239
3240         Add API test coverage.
3241
3242         * TestWebKitAPI/Tests/WTF/Function.cpp:
3243         (TestWebKitAPI::returnThree):
3244         (TestWebKitAPI::returnFour):
3245         (TestWebKitAPI::returnPassedValue):
3246         (TestWebKitAPI::TEST):
3247
3248 2017-06-21  Antoine Quint  <graouts@apple.com>
3249
3250         Add logging to identify when the Page suspends scripted animations
3251         https://bugs.webkit.org/show_bug.cgi?id=173626
3252
3253         Reviewed by Tim Horton.
3254
3255         Turn the new logging on for WK1/DRT since the issue we're trying to pinpoint only occurs on WK1 bots.
3256
3257         * DumpRenderTree/mac/DumpRenderTree.mm:
3258         (resetWebPreferencesToConsistentValues):
3259
3260 2017-06-21  Chris Fleizach  <cfleizach@apple.com>
3261
3262         AX: Cannot call setValue() on contenteditable or ARIA text controls
3263         https://bugs.webkit.org/show_bug.cgi?id=173520
3264
3265         Reviewed by Ryosuke Niwa.
3266
3267         Add setValue() method to WKTR (already existed in DRT).
3268
3269         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3270         (WTR::AccessibilityUIElement::setValue):
3271         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3272         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3273         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3274         (WTR::AccessibilityUIElement::setValue):
3275
3276 2017-06-21  Zan Dobersek  <zdobersek@igalia.com>
3277
3278         List libtasn1 packages in GTK+ and WPE install-dependencies scripts
3279         as one of the dependencies required to build the product.
3280
3281         Rubber-stamped by Carlos Garcia Campos.
3282
3283         * gtk/install-dependencies:
3284         * wpe/install-dependencies:
3285
3286 2017-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
3287
3288         Disable font variations on macOS Sierra and iOS 10
3289         https://bugs.webkit.org/show_bug.cgi?id=173618
3290         <rdar://problem/32879164>
3291
3292         Reviewed by Jon Lee.
3293
3294         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3295
3296 2017-06-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3297
3298         [iOS DnD] [WK2] Remove custom logic for disambiguating long press action sheet gestures and drag lift
3299         https://bugs.webkit.org/show_bug.cgi?id=173578
3300         <rdar://problem/32825028>
3301
3302         Reviewed by Tim Horton.
3303
3304         Slight tweak to ensure that DataInteractionTests.CustomActionSheetPopover still passes and verifies that showing
3305         a custom popover does not cause dragging to fail when the popover is presented.
3306
3307         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3308         (-[DataInteractionSimulator _advanceProgress]):
3309
3310 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3311
3312         [WPE] Add initial implementation of glib API
3313         https://bugs.webkit.org/show_bug.cgi?id=173546
3314
3315         Reviewed by Žan Doberšek.
3316
3317         Disable geolocation because WPE doesn't implement any provider and update the style checker exceptions to
3318         include WPE glib API files.
3319
3320         * Scripts/webkitperl/FeatureList.pm:
3321         * Scripts/webkitpy/style/checker.py:
3322         * Scripts/webkitpy/style/checkers/cpp.py:
3323         (check_identifier_name_in_declaration):
3324
3325 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3326
3327         [GTK] Upgrade to ICU to version 57.1
3328         https://bugs.webkit.org/show_bug.cgi?id=173538
3329
3330         Reviewed by Žan Doberšek.
3331
3332         * gtk/jhbuild.modules:
3333
3334 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3335
3336         [GTK] Remove unneeded modules from the jhbuild
3337         https://bugs.webkit.org/show_bug.cgi?id=170540
3338
3339         Reviewed by Michael Catanzaro.
3340
3341         We are building libxslt and libffi that we don't really need to build from sources.
3342
3343         * gtk/jhbuild.modules:
3344
3345 2017-06-19  Frederic Wang  <fwang@igalia.com>
3346
3347         [Mac] Add an experimental feature setting for async frame scrolling
3348         https://bugs.webkit.org/show_bug.cgi?id=173359
3349
3350         Reviewed by Simon Fraser.
3351
3352         * DumpRenderTree/mac/DumpRenderTree.mm:
3353         (enableExperimentalFeatures): Do not enable async frame scrolling for now.
3354         (resetWebPreferencesToConsistentValues): Disable async frame scrolling by default.
3355         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3356         (WTR::InjectedBundle::beginTesting): Initalize to async frame scrolling to false.
3357
3358 2017-06-19  Guillaume Emont  <guijemont@igalia.com>
3359
3360         Unreviewed, adding myself to contributors.json
3361
3362         * Scripts/webkitpy/common/config/contributors.json:
3363
3364 2017-06-19  Joseph Pecoraro  <pecoraro@apple.com>
3365
3366         test262: Completion values for control flow do not match the spec
3367         https://bugs.webkit.org/show_bug.cgi?id=171265
3368
3369         Reviewed by Saam Barati.
3370
3371         * Scripts/run-jsc-stress-tests:
3372         Include a :failDueToOutdatedOrBadTest to mark failures with justification.
3373
3374 2017-06-19  Zalan Bujtas  <zalan@apple.com>
3375
3376         Opening certain mails brings up a mail that grows indefinitely.
3377         https://bugs.webkit.org/show_bug.cgi?id=173562
3378         <rdar://problem/32766579>
3379
3380         Reviewed by Tim Horton.
3381
3382         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
3383         (TEST):
3384
3385 2017-06-19  Wenson Hsieh  <wenson_hsieh@apple.com>
3386
3387         [iOS DnD] Support .zip archives for file uploads via drag and drop
3388         https://bugs.webkit.org/show_bug.cgi?id=173511
3389         <rdar://problem/32521025>
3390
3391         Reviewed by Tim Horton.
3392
3393         Adds tests for dropping .zip archives into a JavaScript-based file upload area, as well as into a file input.
3394         Also verifies that URLs are not handled as file drops. See WebCore ChangeLog for more details.
3395
3396         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3397         * TestWebKitAPI/Tests/WebKit2Cocoa/compressed-files.zip: Added.
3398         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3399         (testZIPArchive):
3400         (TestWebKitAPI::TEST):
3401
3402 2017-06-18  Darin Adler  <darin@apple.com>
3403
3404         Fix Ref to deref before assignment, add tests for this to RefPtr, Ref, Function
3405         https://bugs.webkit.org/show_bug.cgi?id=173526
3406
3407         Reviewed by Sam Weinig.
3408
3409         * TestWebKitAPI/CMakeLists.txt: Added Function.cpp.
3410         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
3411
3412         * TestWebKitAPI/Tests/WTF/Function.cpp: Added. Contains basic tests and some
3413         tests for assignment before destruction ones.
3414
3415         * TestWebKitAPI/Tests/WTF/MoveOnly.h: Added a () operator so this can be used
3416         as a function, so it can be used in WTF::Function tests.
3417
3418         * TestWebKitAPI/Tests/WTF/Ref.cpp: Use EXPECT macros insead of ASSERT.
3419         Added tests for swap and for assignment before deref.
3420
3421         * TestWebKitAPI/Tests/WTF/RefLogger.cpp: Stopped using inlining; no good reason
3422         to inline everything. Also removed the unnecessary clearing of the log every time
3423         the DerivedRefLogger constructor is called.
3424         * TestWebKitAPI/Tests/WTF/RefLogger.h: Ditto.
3425
3426         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Use EXPECT macros instead of ASSERT.
3427         Added tests for assignment before deref and similar for releaseNonNull.
3428
3429 2017-06-19  Sam Weinig  <sam@webkit.org>
3430
3431         [WebIDL] Properly model buffer source / typed arrays as their own IDL types
3432         https://bugs.webkit.org/show_bug.cgi?id=173513
3433
3434         Reviewed by Alex Christensen.
3435
3436         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
3437         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3438         Replace IsNonPointerType subroutine with IsPrimitiveType so we can remove IsNonPointerType.
3439
3440 2017-06-19  Per Arne Vollan  <pvollan@apple.com>
3441
3442         [Win] fast/dom/assign-to-window-status.html is flaky.
3443         https://bugs.webkit.org/show_bug.cgi?id=173512
3444
3445         Reviewed by Alex Christensen.
3446
3447         We should not dump status callbacks when test is done.
3448
3449         * DumpRenderTree/win/UIDelegate.cpp:
3450         (UIDelegate::setStatusText):
3451
3452 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3453
3454         [WPE][JHBuild] Update WPEBackend-mesa
3455         https://bugs.webkit.org/show_bug.cgi?id=173433
3456
3457         Unreviewed.
3458
3459         Update WPEBackend-mesa back (like it was done originally in r218344)
3460         after fixing the issue with the DISPLAY environment variables that
3461         caused the crashes.
3462
3463         * wpe/jhbuild.modules:
3464
3465 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3466
3467         Rename unit test file after r218482
3468         https://bugs.webkit.org/show_bug.cgi?id=173483
3469
3470         Unreviewed.
3471
3472         * Scripts/webkitpy/port/waylanddriver_unittest.py: Renamed from Tools/Scripts/webkitpy/port/wayland_unittest.py.
3473
3474 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3475
3476         Unreviewed. Fix wrong style checker condition added in r218487.
3477
3478         * Scripts/webkitpy/style/checkers/cpp.py:
3479         (check_identifier_name_in_declaration):
3480
3481 2017-06-19  Adrian Perez de Castro  <aperez@igalia.com>
3482
3483         Missing <functional> includes make builds fail with GCC 7.x
3484         https://bugs.webkit.org/show_bug.cgi?id=173544
3485
3486         Unreviewed gardening.
3487
3488         Fix compilation with GCC 7.
3489
3490         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3491         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
3492
3493 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3494
3495         [GTK] Move GTK+ API files that could be shared to glib dirs
3496         https://bugs.webkit.org/show_bug.cgi?id=173545
3497
3498         Reviewed by Žan Doberšek.
3499
3500         Update paths of GTK+ API in watchlist and style checker.
3501
3502         * Scripts/webkitpy/common/config/watchlist:
3503         * Scripts/webkitpy/style/checker.py:
3504         * Scripts/webkitpy/style/checkers/cpp.py:
3505         (check_identifier_name_in_declaration):
3506
3507 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3508
3509         Port setup_environ_for_server should not set environment variables related with the driver.
3510         https://bugs.webkit.org/show_bug.cgi?id=173483
3511
3512         Reviewed by Carlos Garcia Campos.
3513
3514         The port setup_environ_for_server() should not set environment variables
3515         that depend on the type of driver (like DISPLAY or GDK_BACKEND).
3516         This varibles should be only set on the driver setup_environ_for_test().
3517
3518         This causes that (for example) the variable DISPLAY or XAUTHORITY leaks
3519         into the test environment even when running the tests with a driver
3520         that is not the Xorg or Xvfb one.
3521
3522         * Scripts/webkitpy/port/base.py: Stop setting XAUTHORITY and DISPLAY here.
3523         (Port.to.setup_environ_for_server):
3524         * Scripts/webkitpy/port/driver.py: Remove unneded WEBKIT_OUTPUTDIR that is already set on base.py
3525         (Driver._setup_environ_for_driver):
3526         * Scripts/webkitpy/port/driver_unittest.py:
3527         (DriverTest.test_setup_environ_for_test):
3528         (DriverTest):
3529         (DriverTest.test_setup_environ_base_vars):
3530         * Scripts/webkitpy/port/gtk.py: Stop setting GDK_BACKEND here and do that on the driver (Xvfb).
3531         (GtkPort.setup_environ_for_server):
3532         * Scripts/webkitpy/port/wayland_unittest.py: Added.
3533         (WaylandDriverTest):
3534         (WaylandDriverTest.make_driver):
3535         (WaylandDriverTest.make_environment):
3536         (WaylandDriverTest.test_checkdriver):
3537         (WaylandDriverTest.test_environment_needed_variables):
3538         (WaylandDriverTest.test_environment_forbidden_variables):
3539         (WaylandDriverTest.test_environment_optional_variables):
3540         * Scripts/webkitpy/port/waylanddriver.py: Allow the driver to run also with WAYLAND_SOCKET.
3541         (WaylandDriver.check_driver):
3542         (WaylandDriver._setup_environ_for_test):
3543         * Scripts/webkitpy/port/xorgdriver.py:
3544         (XorgDriver.check_driver):
3545         (XorgDriver._setup_environ_for_test):
3546         * Scripts/webkitpy/port/xorgdriver_unittest.py: Added.
3547         (XorgDriverTest):
3548         (XorgDriverTest.make_driver):
3549         (XorgDriverTest.make_environment):
3550         (XorgDriverTest.test_checkdriver):
3551         (XorgDriverTest.test_environment_needed_variables):
3552         (XorgDriverTest.test_environment_forbidden_variables):
3553         (XorgDriverTest.test_environment_optional_variables):
3554         * Scripts/webkitpy/port/xvfbdriver.py:
3555         (XvfbDriver._setup_environ_for_test):
3556         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
3557         (XvfbDriverTest.assertDriverStartSuccessful):
3558
3559
3560 2017-05-14 Frederic Wang  <fwang@igalia.com>
3561
3562         Add heuristic to avoid flattening "fullscreen" iframes
3563         https://bugs.webkit.org/show_bug.cgi?id=171914
3564
3565         Reviewed by Simon Fraser.
3566
3567         * DumpRenderTree/mac/DumpRenderTree.mm:
3568         (resetWebPreferencesToConsistentValues): Use WebKitFrameFlatteningDisabled.
3569
3570 2017-06-18  Chris Dumez  <cdumez@apple.com>
3571
3572         Crash when re-entering MediaDevicesEnumerationRequest::cancel()
3573         https://bugs.webkit.org/show_bug.cgi?id=173522
3574         <rdar://problem/31185739>
3575
3576         Reviewed by Darin Adler.
3577
3578         Add API test for re-entering Function's assignment operators.
3579
3580         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3581         * TestWebKitAPI/Tests/WTF/Function.cpp: Added.
3582         (TestWebKitAPI::TestObject::TestObject):
3583         (TestWebKitAPI::TestObject::~TestObject):
3584         (TestWebKitAPI::TestObject::operator()):
3585         (TestWebKitAPI::TEST):
3586
3587 2017-06-16  Dan Bernstein  <mitz@apple.com>
3588
3589         [Cocoa] Some declarations have missing or incorrect availability attributes
3590         https://bugs.webkit.org/show_bug.cgi?id=173508
3591
3592         Reviewed by Tim Horton.
3593
3594         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
3595         (TestWebKitAPI::TEST): Updated for renames.
3596
3597 2017-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3598
3599         [iOS DnD] Upstream iOS drag and drop implementation into OpenSource WebKit
3600         https://bugs.webkit.org/show_bug.cgi?id=173366
3601         <rdar://problem/32767014>
3602
3603         Reviewed by Tim Horton.
3604
3605         Move test pages and pieces of DataInteractionSimulator hidden behind WebKitAdditions into TestWebKitAPI. No
3606         change in behavior.
3607
3608         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3609         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3610         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
3611         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Added.
3612         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-textarea.html: Added.
3613         * TestWebKitAPI/Tests/WebKit2Cocoa/div-and-large-image.html: Added.
3614         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html: Added.
3615         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
3616 &nbs