e53aaecb55d1ee514876499cdbb7b0e8786982f7
[WebKit-https.git] / Tools / ChangeLog
1 2012-02-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2
3         Unreviewed. Fix make distcheck.
4
5         * GNUmakefile.am: Fix typo.
6
7 2012-02-27  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
8
9         [Qt] Use USE() macro instead of ENABLE() for using the Qt image decoder
10
11         Reviewed by Kenneth Rohde Christiansen..
12
13         * qmake/mkspecs/features/features.prf:
14
15 2012-02-27  Hao Zheng  <zhenghao@chromium.org>
16
17         Add a ChromiumGpuAndroid port.
18         https://bugs.webkit.org/show_bug.cgi?id=79628
19
20         Reviewed by Adam Barth.
21
22         Android does have a gpu port, so revert r107697.
23
24         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
25         (ChromiumAndroidPort.__init__):
26         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
27         (ChromiumGpuAndroidPort):
28         (ChromiumGpuAndroidPort.__init__):
29         (ChromiumGpuAndroidPort.baseline_search_path):
30         (ChromiumGpuAndroidPort.default_child_processes):
31         (ChromiumGpuAndroidPort.tests):
32         * Scripts/webkitpy/layout_tests/port/factory.py:
33         (PortFactory):
34
35 2012-02-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
36
37         Change Build bot with BuildAndTest bot for EFL port.
38         https://bugs.webkit.org/show_bug.cgi?id=77518
39
40         Reviewed by Ryosuke Niwa.
41
42         EFL build bot starts to support layout test.
43
44         * BuildSlaveSupport/build.webkit.org-config/config.json:
45         * BuildSlaveSupport/built-product-archive:
46         (archiveBuiltProduct):
47         (extractBuiltProduct):
48         * BuildSlaveSupport/test-result-archive:
49         (archiveTestResults):
50         * Scripts/webkitdirs.pm: Enable SHARED_CORE option when ENABLE_DRT is enable in EFL port.
51         (generateBuildSystemFromCMakeProject):
52
53 2012-02-24  Darin Fisher  <darin@chromium.org>
54
55         Add watchlist for ChromiumPlatformApi matching Source/Platform/chromium/public/
56
57         Reviewed by James Robinson.
58
59         * Scripts/webkitpy/common/config/watchlist:
60
61 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
62
63         webkitpy: changelog_unittest test_fuzzy_reviewer_match is slow
64         https://bugs.webkit.org/show_bug.cgi?id=79258
65
66         Reviewed by Ryosuke Niwa.
67
68         Split the fuzzy matching into separate functions so that they
69         can be sharded and run in parallel.
70
71         Also, fix a bug in the svn_blame_regexp that was causing us
72         to require ChangeLog lines to have at least one space after the
73         author, making the code require trailing whitespace in the
74         changelog in some places (this was making my life harder because
75         I have my text editor set to strip trailing whitespace in python
76         files, and that was causing test_parse_log_entries_from_changelog() to fail
77         when the whitespace on line 275 was removed).
78
79         * Scripts/webkitpy/common/checkout/changelog.py:
80         (ChangeLog):
81         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
82         (test_fuzzy_reviewer_match__none):
83         (test_fuzzy_reviewer_match_adam_barth):
84         (test_fuzzy_reviewer_match_darin_adler_et_al):
85         (test_fuzzy_reviewer_match_dimitri_glazkov):
86         (test_fuzzy_reviewer_match_george_staikos):
87         (test_fuzzy_reviewer_match_mark_rowe):
88
89 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
90
91         webkitpy: committers_unittest fuzzy matching is really slow
92         https://bugs.webkit.org/show_bug.cgi?id=79179
93
94         Reviewed by Ryosuke Niwa.
95
96         Break the fuzzy matching tests into individual routines for
97         each contributor so that the intent is a little clearer, so
98         that it's easier to test individual names (and identify
99         duplicate tests), and so that we can eventually run
100         them in parallel.
101
102         Also, mark most of them as 'integration' tests so that they
103         can be skipped if we want to go fast (we leave a few as
104         regular tests for functional coverage).
105
106         * Scripts/webkitpy/common/config/committers_unittest.py:
107         (CommittersTest):
108         (CommittersTest.test_contributors_by_fuzzy_match):
109         (CommittersTest.integration_test_contributors__none):
110         (CommittersTest.integration_test_contributors__none_2):
111         (CommittersTest.integration_test_contributors__none_3):
112         (CommittersTest.integration_test_contributors_ada_chan):
113         (CommittersTest.integration_test_contributors_adele_peterson):
114         (CommittersTest.integration_test_contributors_alexey_proskuryakov):
115         (CommittersTest.integration_test_contributors_alice_liu):
116         (CommittersTest.integration_test_contributors_alp_toker):
117         (CommittersTest.integration_test_contributors_anders_carlsson):
118         (CommittersTest.integration_test_contributors_antti_koivisto):
119         (CommittersTest.integration_test_contributors_beth_dakin):
120         (CommittersTest.integration_test_contributors_brady_eidson):
121         (CommittersTest.integration_test_contributors_cameron_zwarich):
122         (CommittersTest.integration_test_contributors_chris_blumenberg):
123         (CommittersTest.integration_test_contributors_dan_bernstein):
124         (CommittersTest.integration_test_contributors_dan_bernstein_2):
125         (CommittersTest.integration_test_contributors_darin_adler):
126         (CommittersTest.integration_test_contributors_david_harrison):
127         (CommittersTest.integration_test_contributors_david_harrison_2):
128         (CommittersTest.integration_test_contributors_david_hyatt):
129         (CommittersTest.integration_test_contributors_david_kilzer):
130         (CommittersTest.integration_test_contributors_don_melton):
131         (CommittersTest.integration_test_contributors_eric_seidel):
132         (CommittersTest.integration_test_contributors_geoffrey_garen):
133         (CommittersTest.integration_test_contributors_greg_bolsinga):
134         (CommittersTest.integration_test_contributors_holger_freyther):
135         (CommittersTest.integration_test_contributors_jon_sullivan):
136         (CommittersTest.integration_test_contributors_jon_honeycutt):
137         (CommittersTest.integration_test_contributors_joseph_pecoraro):
138         (CommittersTest.integration_test_contributors_ken_kocienda):
139         (CommittersTest.integration_test_contributors_kenneth_russell):
140         (CommittersTest.integration_test_contributors_kevin_decker):
141         (CommittersTest.integration_test_contributors_kevin_mccullough):
142         (CommittersTest.integration_test_contributors_lars_knoll):
143         (CommittersTest.integration_test_contributors_lars_weintraub):
144         (CommittersTest.integration_test_contributors_maciej_stachowiak):
145         (CommittersTest.integration_test_contributors_mark_rowe):
146         (CommittersTest.integration_test_contributors_nikolas_zimmermann):
147         (CommittersTest.integration_test_contributors_oliver_hunt):
148         (CommittersTest.integration_test_contributors_rniwa):
149         (CommittersTest.disabled_integration_test_contributors_simon_fraser):
150         (CommittersTest.integration_test_contributors_steve_falkenburg):
151         (CommittersTest.integration_test_contributors_sam_weinig):
152         (CommittersTest.integration_test_contributors_tim_omernick):
153         (CommittersTest.integration_test_contributors_timothy_hatcher):
154         (CommittersTest.integration_test_contributors_tor_arne_vestbo):
155         (CommittersTest.integration_test_contributors_vicki_murley):
156         (CommittersTest.integration_test_contributors_zack_rusin):
157
158 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
159
160         webkitpy: should autoinstall coverage
161         https://bugs.webkit.org/show_bug.cgi?id=79535
162
163         Reviewed by Eric Seidel.
164
165         We should automatically print the coverage report after the run, too.
166
167         * Scripts/webkitpy/test/main.py:
168         (Tester._run_tests):
169         * Scripts/webkitpy/thirdparty/__init__.py:
170         (AutoinstallImportHook.find_module):
171         (AutoinstallImportHook._install_coverage):
172
173 2012-02-24  Pablo Flouret  <pablof@motorola.com>
174
175         Fix copypasta in build-webkit's --vibration option description
176         https://bugs.webkit.org/show_bug.cgi?id=79528
177
178         Reviewed by Andreas Kling.
179
180         * Scripts/build-webkit:
181
182 2012-02-24  Antonio Gomes  <agomes@rim.com>
183
184         Adding myself to ScrollingCoordinator watchlist
185         https://bugs.webkit.org/show_bug.cgi?id=79525
186
187         Reviewed by Rob Buis.
188
189         * Scripts/webkitpy/common/config/watchlist:
190
191 2012-02-24  Darin Fisher  <darin@chromium.org>
192
193         Update watchlist for ChromiumPublicApi to include Platform/chromium/public/
194
195         Reviewed by Adam Barth.
196
197         * Scripts/webkitpy/common/config/watchlist:
198
199 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
200
201         webkitpy: config_unittest is sensitive to other tests that might've already run
202         https://bugs.webkit.org/show_bug.cgi?id=79382
203
204         Reviewed by Adam Barth.
205
206         If another test runs prior to config_unittest and pokes the
207         cached configuration, the first test in config_unittest might
208         fail; the tearDown() will then allow subsequent tests to pass.
209         Clearing the configuration prior to each test makes things
210         slightly slower but safer.
211
212         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
213         (ConfigTest.setUp):
214
215 2012-02-24  David Kilzer  <ddkilzer@apple.com>
216
217         Use xcrun to find compiler paths for Generate Derived Sources build phase script
218         <http://webkit.org/b/79512>
219
220         Reviewed by Dan Bernstein.
221
222         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
223         (Generate Derived Sources): Use xcrun to find the path to the
224         compiler since that works on both iOS and OS X.
225
226 2012-02-24  James Robinson  <jamesr@chromium.org>
227
228         Create a watchlist for ScrollingCoordinator changes
229         https://bugs.webkit.org/show_bug.cgi?id=79511
230
231         Reviewed by Anders Carlsson.
232
233         * Scripts/webkitpy/common/config/watchlist:
234
235 2012-02-24  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
236
237         [EFL][DRT] Implement setValueForUser and setAutofilled.
238         https://bugs.webkit.org/show_bug.cgi?id=79237
239
240         Reviewed by Andreas Kling.
241
242         Adds missing implementation setValueForUser and setAutofilled to EFL's LayoutTestController.
243         Those implementations are related with input fields and allow to pass following tests:
244         fast/forms/onchange-setvalueforuser.html
245         fast/forms/input-autofilled.html
246         fast/forms/reset-autofilled.html
247
248         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
249         (LayoutTestController::setValueForUser):
250         (LayoutTestController::setAutofilled):
251
252 2012-02-24  Zoltan Horvath  <zoltan@webkit.org>
253
254         [Qt] Allow to use WebCore imagedecoders
255         https://bugs.webkit.org/show_bug.cgi?id=32410
256
257         Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.
258
259         Reviewed by Simon Hausmann.
260
261         * qmake/mkspecs/features/features.prf:
262
263 2012-02-24  Balazs Kelemen  <kbalazs@webkit.org>
264
265         [Qt] Add Qt5 way to force 96 DPI for tests
266         https://bugs.webkit.org/show_bug.cgi?id=79364
267
268         Reviewed by Simon Hausmann.
269
270         * DumpRenderTree/qt/main.cpp:
271         (main):
272         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
273         (WTR::activateFonts):
274
275 2012-02-24  Carlos Garcia Campos  <cgarcia@igalia.com>
276
277         [GTK] MiniBrowser should reload the view then the reload button is clicked
278         https://bugs.webkit.org/show_bug.cgi?id=79472
279
280         Reviewed by Philippe Normand.
281
282         * MiniBrowser/gtk/BrowserWindow.c:
283         (reloadCallback): Call webkit_web_view_reload().
284         (browser_window_init): Connect reload item clicked even to
285         reloadCallback instead of activateUriEntryCallback.
286
287 2012-02-24  Kentaro Hara  <haraken@chromium.org>
288
289         Add performance tests for DOM attribute getters and setters
290         https://bugs.webkit.org/show_bug.cgi?id=79208
291
292         Reviewed by Ryosuke Niwa.
293
294         We want to allow perf tests to output info messages
295         that do not affect the test results. To accomplish this,
296         this patch modifies perftestsrunner.py so that it ignores
297         a line that starts from "Info:".
298
299         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
300         (PerfTestsRunner):
301
302 2012-02-24  Andrew Lo  <anlo@rim.com>
303
304         [BlackBerry] Enable requestAnimationFrame
305         https://bugs.webkit.org/show_bug.cgi?id=79408
306
307         Enable requestAnimationFrame for BlackBerry.
308
309         Reviewed by Rob Buis.
310
311         * Scripts/build-webkit:
312
313 2012-02-24  Adam Barth  <abarth@webkit.org>
314
315         style-queue tries to apply the patch twice
316         https://bugs.webkit.org/show_bug.cgi?id=79459
317
318         Reviewed by Eric Seidel.
319
320         Previously, we applied the patch using both apply-patch and
321         check-style.  This patch introduces a check-style-local to mirror the
322         apply-watchlist-local, which operates on the current working diff.
323
324         This patch also cleans up some other bugs I found by running the queue
325         locally for a while.  The queue still prints out a slightly
326         less-than-ideal message on the bugs when it find an error, but it's ok
327         for now.  We'll need to iterate a bit.
328
329         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
330         (StyleQueueTask.validate):
331         (StyleQueueTask._check_style):
332         * Scripts/webkitpy/tool/commands/download.py:
333         (CheckStyleLocal):
334         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
335         (EarlyWarningSytemTest._default_expected_stderr):
336         (EarlyWarningSytemTest._test_testing_ews):
337         * Scripts/webkitpy/tool/commands/queues.py:
338         (AbstractReviewQueue.handle_script_error):
339         (StyleQueue.review_patch):
340         * Scripts/webkitpy/tool/commands/queues_unittest.py:
341         * Scripts/webkitpy/tool/commands/queuestest.py:
342         (QueuesTest.assert_queue_outputs):
343
344 2012-02-23  Adam Barth  <abarth@webkit.org>
345
346         should_proceed_with_work_item is unused and can be removed
347         https://bugs.webkit.org/show_bug.cgi?id=79416
348
349         Reviewed by Eric Seidel.
350
351         We used to use this function to check whether the tree is red.  Now, we
352         don't use external measures of whether to proceed with work items.
353         Instead, we analyze them with the idea in mind that the tree might be
354         red.
355
356         * Scripts/webkitpy/tool/bot/queueengine.py:
357         (QueueEngineDelegate.next_work_item):
358         (QueueEngine.run):
359         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
360         (LoggingDelegate):
361         (LoggingDelegate.next_work_item):
362         (RaisingDelegate.process_work_item):
363         (QueueEngineTest.test_terminating_error):
364         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
365         (AbstractEarlyWarningSystem.__init__):
366         * Scripts/webkitpy/tool/commands/queues.py:
367         (AbstractQueue.next_work_item):
368         (FeederQueue.next_work_item):
369         (CommitQueue.next_work_item):
370         (AbstractReviewQueue.next_work_item):
371         (StyleQueue.__init__):
372         * Scripts/webkitpy/tool/commands/queues_unittest.py:
373         (FeederQueueTest.test_feeder_queue):
374         (CommitQueueTest.test_commit_queue):
375         (test_commit_queue_failure):
376         (test_commit_queue_failure_with_failing_tests):
377         (test_rollout):
378         (test_rollout_lands):
379         (StyleQueueTest.test_style_queue_with_style_exception):
380         (test_style_queue_with_watch_list_exception):
381         * Scripts/webkitpy/tool/commands/queuestest.py:
382         (QueuesTest.assert_queue_outputs):
383         * Scripts/webkitpy/tool/commands/sheriffbot.py:
384         (SheriffBot.next_work_item):
385
386 2012-02-23  Adrienne Walker  <enne@google.com>
387
388         Unreviewed, add Stephen Chenney to committers.py as a contributor.
389
390         * Scripts/webkitpy/common/config/committers.py:
391
392 2012-02-23  Adam Barth  <abarth@webkit.org>
393
394         style-queue logs bogus messages to the QueueStatusServer
395         https://bugs.webkit.org/show_bug.cgi?id=79424
396
397         Reviewed by Eric Seidel.
398
399         Copy/paste error.
400
401         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
402         (StyleQueueTask._check_style):
403         (StyleQueueTask._apply_watch_list):
404         * Scripts/webkitpy/tool/commands/queues_unittest.py:
405
406 2012-02-23  Eric Seidel  <eric@webkit.org>
407
408         Use self._filesystem in more places in the SCM classes
409         https://bugs.webkit.org/show_bug.cgi?id=79415
410
411         Reviewed by Adam Barth.
412
413         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
414         (SCMDetectorTest.test_detect_scm_system):
415         * Scripts/webkitpy/common/checkout/scm/git.py:
416         (Git.find_checkout_root):
417         (Git.to_object_name):
418         * Scripts/webkitpy/common/checkout/scm/scm.py:
419         (SCM.__init__):
420         (SCM.in_working_directory):
421         * Scripts/webkitpy/common/checkout/scm/svn.py:
422         (SVN.find_uuid):
423         (SVN.find_checkout_root):
424
425 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
426
427         Unreviewed, rolling out r108685.
428         http://trac.webkit.org/changeset/108685
429         https://bugs.webkit.org/show_bug.cgi?id=79414
430
431         Broke Chromium builds (Requested by enne on #webkit).
432
433         * qmake/mkspecs/features/features.prf:
434
435 2012-02-23  Adam Barth  <abarth@webkit.org>
436
437         style-queue shouldn't spam bugs if it fails to update its working copy
438         https://bugs.webkit.org/show_bug.cgi?id=79412
439
440         Reviewed by Eric Seidel.
441
442         This patch moves style-queue over to the new PatchAnalysisTask
443         infrastructure, which is smarter about retrying patches when update
444         fails.
445
446         * Scripts/webkitpy/common/system/executive_mock.py:
447         (MockExecutive.run_and_throw_if_fail):
448         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
449         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
450         (UnableToApplyPatch):
451         (UnableToApplyPatch.__init__):
452         (PatchAnalysisTask.__init__):
453         * Scripts/webkitpy/tool/bot/stylequeuetask.py: Added.
454         (StyleQueueTaskDelegate):
455         (StyleQueueTaskDelegate.parent_command):
456         (StyleQueueTask):
457         (StyleQueueTask.validate):
458         (StyleQueueTask._check_style):
459         (StyleQueueTask._apply_watch_list):
460         (StyleQueueTask.run):
461         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
462         * Scripts/webkitpy/tool/commands/queues.py:
463         (StyleQueue):
464         (StyleQueue.should_proceed_with_work_item):
465         (StyleQueue.review_patch):
466         (StyleQueue.run_command):
467         (StyleQueue.command_passed):
468         (StyleQueue.command_failed):
469         (StyleQueue.expected_failures):
470         (StyleQueue.refetch_patch):
471         * Scripts/webkitpy/tool/commands/queues_unittest.py:
472         (StyleQueueTest.test_style_queue_with_style_exception):
473         (test_style_queue_with_watch_list_exception):
474
475 2012-02-23  Zoltan Horvath  <zoltan@webkit.org>
476
477         [Qt] Allow to use WebCore imagedecoders
478         https://bugs.webkit.org/show_bug.cgi?id=32410
479
480         Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.
481
482         Reviewed by Simon Hausmann.
483
484         * qmake/mkspecs/features/features.prf:
485
486 2012-02-23  Eric Seidel  <eric@webkit.org>
487
488         Remove old broken find_checkout_root tests now that find_checkout_root is gone
489         https://bugs.webkit.org/show_bug.cgi?id=79405
490
491         Reviewed by Adam Barth.
492
493         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py: Added.
494         (SCMDetectorTest):
495         (SCMDetectorTest.test_find_checkout_root):
496         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
497         (SVNTestRepository.tear_down):
498
499 2012-02-23  Michael Brüning  <michael.bruning@nokia.com>
500
501         [Qt][WK2] Implement proxy authentication dialog.
502         https://bugs.webkit.org/show_bug.cgi?id=79350
503
504         Reviewed by Simon Hausmann.
505
506         * MiniBrowser/qt/MiniBrowser.qrc:
507         * MiniBrowser/qt/qml/BrowserWindow.qml:
508         * MiniBrowser/qt/qml/ProxyAuthenticationDialog.qml: Added.
509
510 2012-02-23  Kevin Ollivier  <kevino@theolliviers.com>
511
512         [wx] Build fix, add recently added source dirs.
513
514         * waf/build/settings.py:
515
516 2012-02-23  Simon Hausmann  <simon.hausmann@nokia.com>
517
518         [Qt] Add support for touch cancellation
519         https://bugs.webkit.org/show_bug.cgi?id=79348
520
521         Reviewed by Kenneth Rohde Christiansen.
522
523         Added straight-forward touch cancellation event sending to Qt WK1 DRT
524         and WK2 WTR.
525
526         * DumpRenderTree/qt/EventSenderQt.cpp:
527         (EventSender::touchCancel):
528         (EventSender::cancelTouchPoint):
529         * DumpRenderTree/qt/EventSenderQt.h:
530         (EventSender):
531         * WebKitTestRunner/EventSenderProxy.h:
532         (EventSenderProxy):
533         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
534         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
535         (WTR::EventSendingController::touchCancel):
536         (WTR):
537         (WTR::EventSendingController::cancelTouchPoint):
538         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
539         (EventSendingController):
540         * WebKitTestRunner/TestController.cpp:
541         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
542         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
543         (WTR::EventSenderProxy::touchCancel):
544         (WTR):
545         (WTR::EventSenderProxy::cancelTouchPoint):
546
547 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
548
549         Unreviewed, rolling out r108626.
550         http://trac.webkit.org/changeset/108626
551         https://bugs.webkit.org/show_bug.cgi?id=79370
552
553         broke qt-wk2 bot, somehow the workaround does not work on the
554         bot (Requested by Ossy on #webkit).
555
556         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
557         (WTR::WrapperWindow::handleStatusChanged):
558         (WTR::PlatformWebView::resizeTo):
559
560 2012-02-23  ChangSeok Oh  <shivamidow@gmail.com>
561
562         [GTK] DRT doesn't support scheduleAsynchronousKeyDown.
563         https://bugs.webkit.org/show_bug.cgi?id=78481
564
565         Reviewed by Gustavo Noronha Silva.
566
567         Extracted shareable code from keyDownCallback and then added createKeyPressEvent
568         to create gdk press key event.
569         Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly
570         and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown.
571
572         * DumpRenderTree/gtk/EventSender.cpp:
573         (scheduleAsynchronousClickCallback):
574         (createKeyPressEvent):
575         (sendKeyDown):
576         (keyDownCallback):
577         (sendAsynchronousKeyDown):
578         (scheduleAsynchronousKeyDownCallback):
579
580 2012-02-23  Balazs Kelemen  <kbalazs@webkit.org>
581
582         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
583         https://bugs.webkit.org/show_bug.cgi?id=76546
584
585         Reviewed by Simon Hausmann.
586
587         Co-authored with Simon Hausmann.
588
589         Revert the workaround introduced in r107868 and reintroduce
590         the qml binding so we can test the code path that we are more
591         interested in. The reason that it did not work before is that
592         we don't have an active platform window which we now workaround
593         by propagating the resize through QWindowSystemInterface.
594
595         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
596         (WTR::WrapperWindow::handleStatusChanged):
597         (WTR::PlatformWebView::resizeTo):
598
599 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
600
601         Unreviewed, rolling out r108577.
602         http://trac.webkit.org/changeset/108577
603         https://bugs.webkit.org/show_bug.cgi?id=79359
604
605         It doesn't work as expected (Requested by Ossy on #webkit).
606
607         * DumpRenderTree/qt/EventSenderQt.cpp:
608         (EventSender::postEvent):
609         * DumpRenderTree/qt/EventSenderQt.h:
610         (EventSender):
611
612 2012-02-23  Philippe Normand  <pnormand@igalia.com>
613
614         [GTK] FullScreen signals
615         https://bugs.webkit.org/show_bug.cgi?id=76181
616
617         Reviewed by Martin Robinson.
618
619         Use the two new entering/leaving fullscreen signals to hide/show
620         the tool bar, the status bar and ask the user's permission before
621         entering fullscreen.
622
623         * GtkLauncher/main.c:
624         (webViewFullscreenMessageWindowClose):
625         (webViewWindowStateEvent):
626         (hide_widget):
627         (show_widget):
628         (webViewEnteringFullScreen):
629         (webViewLeavingFullScreen):
630         (createBrowser):
631         (createWindow):
632
633 2012-02-22  Dongwoo Im  <dw.im@samsung.com>
634
635         [EFL] Fix to launch the EWebLauncher using the script, run-launcher.
636         https://bugs.webkit.org/show_bug.cgi?id=79076
637
638         Reviewed by Andreas Kling.
639
640         * Scripts/webkitdirs.pm: Fix the path of libewebkit.so.
641         (builtDylibPathForName):
642
643 2012-02-22  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
644
645         [Qt] Add eventSender.gestureTap
646         https://bugs.webkit.org/show_bug.cgi?id=66173
647
648         Reviewed by Kenneth Rohde Christiansen.
649
650         * DumpRenderTree/qt/EventSenderQt.cpp:
651         (EventSender::gestureTap):
652         * DumpRenderTree/qt/EventSenderQt.h:
653
654 2012-02-22  Brady Eidson  <beidson@apple.com>
655
656         <rdar://problem/10406044> and https://bugs.webkit.org/show_bug.cgi?id=79279
657         Synchronous ShouldGoToBackForwardListItem causes lots of WebProcess hangs
658
659         Reviewed by Anders Carlsson.
660
661         Update our tools to the new form of the PageLoadClient.
662
663         * MiniBrowser/mac/BrowserWindowController.m:
664         (-[BrowserWindowController awakeFromNib]): 
665
666         * WebKitTestRunner/TestController.cpp:
667         (WTR::TestController::initialize):
668
669 2012-02-22  Daniel Bates  <dbates@webkit.org>
670
671         new-run-webkit-tests shouldn't restore Safari state on Lion when showing results
672         https://bugs.webkit.org/show_bug.cgi?id=79277
673
674         Reviewed by Adam Barth.
675
676         Pass command line argument no-saved-state to run-safari to disable Safari
677         state restoration for the session on OS 10.7.
678
679         * Scripts/webkitpy/layout_tests/port/mac.py:
680         (MacPort.show_results_html_file):
681         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
682         (test_show_results_html_file):
683
684 2012-02-22  Kalev Lember  <kalevlember@gmail.com>
685
686         Explicitly include unistd.h in TestNetscapePlugIn for GCC 4.7
687         https://bugs.webkit.org/show_bug.cgi?id=77759
688
689         Reviewed by Tony Chang.
690
691         Fixes build with gcc 4.7.
692
693         r100432 added the include only for ANDROID; this changes the ifdef to
694         also cover other unix platforms. On Fedora 17 the gcc 4.7 compiler no
695         longer implicitly includes unistd.h from standard headers and other
696         unix platforms are likely to get gcc 4.7 as well in the future.
697
698         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
699
700 2012-02-22  Philippe Normand  <pnormand@igalia.com>
701
702         Unreviewed, rolling out r108522.
703         http://trac.webkit.org/changeset/108522
704         https://bugs.webkit.org/show_bug.cgi?id=76181
705
706         Broke 4 fullscreen tests on GTK.
707
708         * GtkLauncher/main.c:
709         (createBrowser):
710         (createWindow):
711
712 2012-02-20  Philippe Normand  <pnormand@igalia.com>
713
714         [GTK] FullScreen signals
715         https://bugs.webkit.org/show_bug.cgi?id=76181
716
717         Reviewed by Martin Robinson.
718
719         Use the two new entering/leaving fullscreen signals to hide/show
720         the tool bar, the status bar and ask the user's permission before
721         entering fullscreen.
722
723         * GtkLauncher/main.c:
724         (webViewFullscreenMessageWindowClose):
725         (webViewWindowStateEvent):
726         (hide_widget):
727         (show_widget):
728         (webViewEnteringFullScreen):
729         (webViewLeavingFullScreen):
730         (createBrowser):
731         (createWindow):
732
733 2012-02-22  Rob Flack  <flackr@chromium.org>
734
735         Update Linux ChromiumOS builders in flakiness dashboard.
736         https://bugs.webkit.org/show_bug.cgi?id=79238
737
738         Reviewed by Ojan Vafai.
739
740         * TestResultServer/static-dashboards/builders.js:
741
742 2012-02-22  Dirk Pranke  <dpranke@chromium.org>
743
744         webkitpy: test_function_length_check_definition_huge_lines is slow
745         https://bugs.webkit.org/show_bug.cgi?id=79185
746
747         Reviewed by Adam Barth.
748
749         This test takes ~3 seconds to run, apparently because we're
750         running a test on a 10,000 line function :). Dropping the
751         function length to 640 still exercises the code path and
752         provides a 10x speedup.
753
754         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
755         (CppStyleTest):
756         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines):
757
758 2012-02-22  Dirk Pranke  <dpranke@chromium.org>
759
760         webkitpy: speed up FileLockTest.test_lock_lifecycle
761         https://bugs.webkit.org/show_bug.cgi?id=79189
762
763         Reviewed by Adam Barth.
764
765         The unit test had a second lock trying to acquire a
766         lock already held, and a hard-coded timeout of one second.
767         I have changed the timeouts to a tenth of a second (which
768         is probably still fine) and changed the hard-spin on
769         the lock to a slow-spin every hundredth of a second.
770
771         * Scripts/webkitpy/common/system/file_lock.py:
772         (FileLock.acquire_lock):
773         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
774         (FileLockTest.setUp):
775         (FileLockTest.test_stuck_lock):
776
777 2012-02-22  Gabor Rapcsanyi  <rgabor@webkit.org>
778
779         build-webkit should use environment variable at number of CPU
780         detection on all platform
781         https://bugs.webkit.org/show_bug.cgi?id=79227
782
783         Reviewed by Martin Robinson.
784
785         * Scripts/webkitdirs.pm:
786         (determineNumberOfCPUs):
787
788 2012-02-22  Mihnea Ovidenie  <mihnea@adobe.com>
789
790         [Qt] REGRESSION(r108108): It made 3 fast/repaint tests fail
791         https://bugs.webkit.org/show_bug.cgi?id=78960
792
793         Reviewed by Csaba Osztrogonác.
794
795         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
796         (LayoutTestController::overridePreference):
797
798 2012-02-22  Hao Zheng  <zhenghao@chromium.org>
799
800         [chromium] Build WebKit with MEDIA_STREAM disabled.
801         https://bugs.webkit.org/show_bug.cgi?id=79214
802
803         Reviewed by Kent Tamura.
804
805         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
806         * DumpRenderTree/chromium/WebUserMediaClientMock.h:
807         * DumpRenderTree/chromium/WebViewHost.cpp:
808         (WebViewHost::createMediaPlayer):
809         * DumpRenderTree/chromium/WebViewHost.h:
810         (WebViewHost):
811
812 2012-02-22  Zeno Albisser  <zeno@webkit.org>
813
814         [Qt][WK2][Mac] WebKitTestRunner does not build with clang.
815         https://bugs.webkit.org/show_bug.cgi?id=79124
816
817         WebKitTestRunnerPrefix.h should also be included
818         when building with clang.
819
820         Reviewed by Kenneth Rohde Christiansen.
821
822         * WebKitTestRunner/Target.pri:
823
824 2012-02-20  Roland Steiner  <rolandsteiner@chromium.org>
825
826         <style scoped>: Add runtime-flag
827         https://bugs.webkit.org/show_bug.cgi?id=79074
828
829         Enable the runtime-flag for DRT. 
830
831         Reviewed by Dimitri Glazkov.
832
833         * DumpRenderTree/chromium/TestShell.cpp:
834         (TestShell::TestShell):
835
836 2012-02-22  Carlos Garcia Campos  <cgarcia@igalia.com>
837
838         Unreviewed, rolling out r107351.
839         http://trac.webkit.org/changeset/107351
840         https://bugs.webkit.org/show_bug.cgi?id=53600
841
842         Several issues introduced in WebKitGTK+ API
843
844         * DumpRenderTree/gtk/DumpRenderTree.cpp:
845         (createWebView):
846         * GtkLauncher/main.c:
847         (createWebViewCb):
848         (createBrowser):
849         (createWindow):
850         (main):
851
852 2012-02-21  Filip Pizlo  <fpizlo@apple.com>
853
854         JSC should be a triple-tier VM
855         https://bugs.webkit.org/show_bug.cgi?id=75812
856         <rdar://problem/10079694>
857
858         Reviewed by Gavin Barraclough.
859
860         Changed EFL's build system to include a new directory in JavaScriptCore.
861
862         * DumpRenderTree/efl/CMakeLists.txt:
863
864 2012-02-21  Daniel Cheng  <dcheng@chromium.org>
865
866         [chromium] Fix image drag out on Chromium
867         https://bugs.webkit.org/show_bug.cgi?id=79158
868
869         Reviewed by Tony Chang.
870
871         * DumpRenderTree/chromium/EventSender.cpp:
872         (EventSender::dumpFilenameBeingDragged):
873         (EventSender::beginDragWithFiles):
874         * DumpRenderTree/chromium/WebViewHost.cpp:
875         (addDRTFakeFileToDataObject):
876
877 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
878
879         webkitpy: speed up hot filesystem_mock functions
880         https://bugs.webkit.org/show_bug.cgi?id=79159
881
882         Reviewed by Adam Barth.
883
884         Profiling run_webkit_tests_integrationtest.py revealed that
885         isdir(), normpath(), and join() are called a lot and were very
886         slow.This patch speeds them up substantially, shaving 20 seconds
887         off of the execution time.
888
889         * Scripts/webkitpy/common/system/filesystem_mock.py:
890         (MockFileSystem.isdir):
891         (MockFileSystem._slow_but_correct_join):
892         (MockFileSystem.join):
893         (MockFileSystem.listdir):
894         (MockFileSystem._slow_but_correct_normpath):
895         (MockFileSystem.normpath):
896         (MockFileSystem.write_binary_file):
897         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
898         (MockFileSystemTest.quick_check):
899         (MockFileSystemTest):
900         (MockFileSystemTest.test_join):
901         (MockFileSystemTest.test_normpath):
902         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
903         (get_test_config): Call write_binary_file() instead of updating
904           filesystem.files directly, so that we create directories as
905           needed.
906
907 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
908
909         nrwt: make the delay between starting workers configurable per-port
910         https://bugs.webkit.org/show_bug.cgi?id=79148
911
912         Reviewed by Eric Seidel.
913
914         Because of bug 79147, we have to sleep a bit in between starting
915         DRTs; however, doing so across the board slows down the Test
916         port. Making this configurable shaves 10 seconds off of
917         run_webkit_tests_integrationtest.py
918         
919         * Scripts/webkitpy/layout_tests/controllers/manager.py:
920         (Manager._run_tests):
921         * Scripts/webkitpy/layout_tests/port/base.py:
922         (Port.worker_startup_delay_secs):
923         * Scripts/webkitpy/layout_tests/port/test.py:
924         (TestPort.worker_startup_delay_secs):
925
926 2012-02-21  Jon Lee  <jonlee@apple.com>
927
928         Bring notifications support to WK1 mac
929         https://bugs.webkit.org/show_bug.cgi?id=78783
930         <rdar://problem/10610578>
931
932         Reviewed by Anders Carlsson.
933
934         * DumpRenderTree/mac/UIDelegate.mm: Refactor WebGeolocationPolicyListener to WebAllowDenyPolicyListener.
935         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
936         (-[UIDelegate timerFired]):
937
938 2012-02-21  Kentaro Hara  <haraken@chromium.org>
939
940         Enable the IDL attribute checker in run-bindings-tests
941         https://bugs.webkit.org/show_bug.cgi?id=79091
942
943         Reviewed by Adam Barth.
944
945         We have enabled the IDL attribute checker in Chromium in r108322.
946         This patch enables the IDL attribute checker in run-bindings-tests.
947
948         No tests. I manually checked that [Custommm], [CallWith=],
949         [CallWith=ScriptExecutionContext|Foo] in TestObj.idl cause
950         run-bindings-tests failures.
951
952         * Scripts/webkitpy/bindings/main.py:
953         (BindingsTests.generate_supplemental_dependency):
954
955 2012-02-21  Rafael Weinstein  <rafaelw@chromium.org>
956
957         Add rafaelw as a committer.
958
959         Unreviewed.
960
961         * Scripts/webkitpy/common/config/committers.py:
962
963 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
964
965         webkitpy: update names after deleting message_broker
966         https://bugs.webkit.org/show_bug.cgi?id=79000
967
968         Reviewed by Eric Seidel.
969
970         Part 3 of 3 in deleting message_broker.py; this change just
971         adjusts the names for the newly merged symbols so that they are
972         private as appropriate.
973
974         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
975         (get):
976         (_Broker):
977         (_BrokerConnection):
978         (_BrokerConnection.__init__):
979         (AbstractWorker.__init__):
980         (_ManagerConnection):
981         (_ManagerConnection.__init__):
982         (_WorkerConnection):
983         (_WorkerConnection.__init__):
984
985 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
986
987         webkitpy: merge message_broker.py into manager_worker_broker.py
988         https://bugs.webkit.org/show_bug.cgi?id=78999
989
990         Reviewed by Tony Chang.
991
992         This is pretty much a straight cut-and-paste of one file into
993         another (broken up so that docstrings and imports are in the
994         right place).
995
996         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
997         (BrokerClient):
998         (BrokerClient.is_done):
999         (BrokerClient.name):
1000         (Broker):
1001         (Broker.__init__):
1002         (Broker.add_topic):
1003         (Broker._get_queue_for_topic):
1004         (Broker.post_message):
1005         (Broker.run_message_loop):
1006         (Broker.run_all_pending):
1007         (Broker._run_loop):
1008         (Broker._dispatch_message):
1009         (_Message):
1010         (_Message.loads):
1011         (_Message.__init__):
1012         (_Message.dumps):
1013         (_Message.__repr__):
1014         (BrokerConnection):
1015         (BrokerConnection.__init__):
1016         (BrokerConnection.run_message_loop):
1017         (BrokerConnection.post_message):
1018         (BrokerConnection.raise_exception):
1019         * Scripts/webkitpy/layout_tests/controllers/message_broker.py: Removed.
1020
1021 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
1022
1023         webkitpy: prepare to delete message_broker.py
1024         https://bugs.webkit.org/show_bug.cgi?id=78997
1025
1026         Reviewed by Eric Seidel.
1027
1028         This is part 1 of 3 changes to fix bug 78187. This change
1029         prepares the code for merging message_broker.py into
1030         manager_worker_broker.py; the tests in message_broker_unittest
1031         are merged into manager_worker_broker_unittest, the symbols
1032         needed by the tests are exported from manager_worker_broker.py,
1033         and manager_worker_broker itself is updated to refer to the
1034         symbols directly (without the module prefix).
1035
1036         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1037         (get):
1038         (AbstractWorker):
1039         (AbstractWorker.__init__):
1040         (_ManagerConnection):
1041         (_ManagerConnection.__init__):
1042         (_WorkerConnection):
1043         (_WorkerConnection.__init__):
1044         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1045         (InterfaceTest.test_brokerclient_is_abstract):
1046         (InterfaceTest.test_brokerclient_is_abstract.methods):
1047         (MessageTest):
1048         (MessageTest.test__no_body):
1049         (MessageTest.test__body):
1050         * Scripts/webkitpy/layout_tests/controllers/message_broker_unittest.py: Removed.
1051
1052 2012-02-21  Sam Weinig  <sam@webkit.org>
1053
1054         Attempt to fix the Snow Leopard build.
1055
1056         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1057         * MiniBrowser/Configurations/Base.xcconfig:
1058         * TestWebKitAPI/Configurations/Base.xcconfig:
1059         * WebKitTestRunner/Configurations/Base.xcconfig:
1060
1061 2012-02-21  Sam Weinig  <sam@webkit.org>
1062
1063         Use libc++ when building with Clang on Mac
1064         https://bugs.webkit.org/show_bug.cgi?id=78981
1065
1066         Reviewed by Dan Bernstein.
1067
1068         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1069         * MiniBrowser/Configurations/Base.xcconfig:
1070         * TestWebKitAPI/Configurations/Base.xcconfig:
1071         * WebKitTestRunner/Configurations/Base.xcconfig:
1072
1073 2012-02-21  Adam Roben  <aroben@apple.com>
1074
1075         Roll out r108309, r108323, and r108326
1076
1077         They broke the 32-bit Lion build.
1078
1079         Original bugs is <http://webkit.org/b/75812> <rdar://problem/10079694>.
1080
1081         * DumpRenderTree/efl/CMakeLists.txt:
1082
1083 2012-02-21  Andras Becsi  <andras.becsi@nokia.com>
1084
1085         [Qt][WK2] Get rid of the dependency to QtWidgets
1086         https://bugs.webkit.org/show_bug.cgi?id=76276
1087
1088         Reviewed by Simon Hausmann.
1089
1090         * MiniBrowser/qt/MiniBrowser.pro:
1091         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1092         (MiniBrowserApplication::MiniBrowserApplication):
1093         (MiniBrowserApplication::notify):
1094         (MiniBrowserApplication::sendTouchEvent):
1095         * MiniBrowser/qt/MiniBrowserApplication.h:
1096         (MiniBrowserApplication):
1097         * QtTestBrowser/locationedit.h:
1098         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1099         (WTR::activateFonts):
1100         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1101
1102 2012-02-20  Adam Barth  <abarth@webkit.org>
1103
1104         mastercfg_unittest.py fails without simplejson
1105         https://bugs.webkit.org/show_bug.cgi?id=79070
1106
1107         Reviewed by Csaba Osztrogonác.
1108
1109         Now that we require Python 2.6 (and higher) we can import json rather
1110         than simplejson.  We still need to use the simplejson name because
1111         that's what the master.cfg script expects.
1112
1113         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1114         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules):
1115
1116 2012-02-20  Filip Pizlo  <fpizlo@apple.com>
1117
1118         JSC should be a triple-tier VM
1119         https://bugs.webkit.org/show_bug.cgi?id=75812
1120         <rdar://problem/10079694>
1121
1122         Reviewed by Gavin Barraclough.
1123
1124         Changed EFL's build system to include a new directory in JavaScriptCore.
1125
1126         * DumpRenderTree/efl/CMakeLists.txt:
1127
1128 2012-02-20  Kenichi Ishibashi  <bashi@chromium.org>
1129
1130         Update pywebsocket to 0.7.2
1131         https://bugs.webkit.org/show_bug.cgi?id=79066
1132
1133         This version includes vendor-prefixed deflate-frame extension support.
1134
1135         Reviewed by Kent Tamura.
1136
1137         * Scripts/webkitpy/thirdparty/__init__.py:
1138         (AutoinstallImportHook._install_pywebsocket):
1139
1140 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
1141
1142         [UNIX] Plugin information fields are not interpreted as UTF-8
1143         https://bugs.webkit.org/show_bug.cgi?id=78635
1144
1145         Reviewed by Gustavo Noronha Silva.
1146
1147         Interpret plugin metadata as UTF8 aways. This matches the behavior
1148         of Chromium and the Totem plugin.
1149
1150         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1151         (NPP_GetValue): Include a UTF-8 character in the description string for testing purposes.
1152
1153 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
1154
1155         [GTK] [Qt] Move the unix forwarding headers for TestNetscapePlugin to the TestNetscapePlugin directory
1156         https://bugs.webkit.org/show_bug.cgi?id=78935
1157
1158         Reviewed by Gustavo Noronha Silva.
1159
1160         Move the TestNetscapePlugin headers to a more appropriate directory and update
1161         the build files to match.
1162
1163         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h.
1164         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h.
1165         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h.
1166         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update build.
1167         * GNUmakefile.am: Ditto.
1168
1169 2012-02-20  Kihong Kwon  <kihong.kwon@samsung.com>
1170
1171         Add a new API for the Vibration API(W3C).
1172         https://bugs.webkit.org/show_bug.cgi?id=72010
1173
1174         Reviewed by Hajime Morita.
1175
1176         * Scripts/build-webkit: Enable ENABLE_VIBRATION feature.
1177
1178 2012-02-20  János Badics  <dicska@gmail.com>
1179
1180         [Qt] run-qtwebkit-tests doesn't consider timeouts as failures
1181         https://bugs.webkit.org/show_bug.cgi?id=71816
1182
1183         RunQtAPITests will notify if a timeout occurs during testing.
1184         Added unittest to the master.cfg
1185
1186         Reviewed by Csaba Osztrogonác.
1187
1188         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1189         (RunQtAPITests.evaluateCommand):
1190         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1191         (RunQtAPITestsTest):
1192         (RunQtAPITestsTest.assertResults):
1193         (RunQtAPITestsTest.test_timeout):
1194         (test_success):
1195         (test_failure):
1196         (test_timeout_and_failure):
1197
1198 2012-02-20  Andy Wingo  <wingo@igalia.com>
1199
1200         Add wingo as a committer.
1201
1202         Unreviewed.
1203
1204         * Scripts/webkitpy/common/config/committers.py: Add myself to the
1205         committers list.
1206
1207 2012-02-20  Jochen Eisinger  <jochen@chromium.org>
1208
1209         [chromium] check that we're not running multiple modal dialogs at the same time
1210         https://bugs.webkit.org/show_bug.cgi?id=78486
1211
1212         Reviewed by Kent Tamura.
1213
1214         * DumpRenderTree/chromium/TestShell.cpp:
1215         (TestShell::TestShell):
1216         * DumpRenderTree/chromium/TestShell.h:
1217         (TestShell::setIsDisplayingModalDialog):
1218         (TestShell::isDisplayingModalDialog):
1219         (TestShell):
1220         * DumpRenderTree/chromium/WebViewHost.cpp:
1221         (WebViewHost::runModal):
1222
1223 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
1224
1225         Fix WebKit2GTK+ for 'make distcheck'.
1226
1227         Instead of conditionally including WebKit2 GNUmakefiles, always
1228         include them and conditionally activate the final targets.
1229
1230         * MiniBrowser/gtk/GNUmakefile.am:
1231         * WebKitTestRunner/GNUmakefile.am:
1232
1233 2012-02-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1234
1235         Enable video option for EFL port in build-webkit.
1236         https://bugs.webkit.org/show_bug.cgi?id=79006
1237
1238         Reviewed by Daniel Bates.
1239
1240         * Scripts/build-webkit:
1241
1242 2012-02-19  JungJik Lee  <jungjik.lee@samsung.com>
1243
1244         [EFL] Use modifier keys to execute pre-rendering.
1245         https://bugs.webkit.org/show_bug.cgi?id=77933
1246
1247         Reviewed by Chang Shu.
1248
1249         Use modifier key to execute pre-rendering instead of using reserved function keys.
1250
1251         * EWebLauncher/main.c:
1252         (on_key_down):
1253
1254 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
1255
1256         Fix one more dangling reference to worker_connection.name, delete unused code.
1257
1258         Unreviewed, build fix.
1259
1260         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1261         (Manager.update):
1262         (_WorkerState.__init__):
1263
1264 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
1265
1266         Add a change that should've been in r108005.
1267
1268         Unreviewed, build fix.
1269
1270         In the refactoring/cleanup in r108005 I should've changed the
1271         implementation of WorkerConnection to make it match BrokerClient
1272         (and everything else) so that objects had a name() method
1273         instead of a name property.
1274
1275         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1276         (Manager._run_tests):
1277         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1278         (_WorkerConnection.__init__):
1279         (_WorkerConnection.name):
1280         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1281         (_TestWorker.__init__):
1282         (_TestsMixin.name):
1283         (_TestsMixin.test_name):
1284         (_TestsMixin.test_cancel):
1285         (_TestsMixin.test_unknown_message):
1286
1287 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
1288
1289         webkitpy: remove webkitpy.common.array_stream
1290         https://bugs.webkit.org/show_bug.cgi?id=78952
1291
1292         Reviewed by Eric Seidel.
1293
1294         Turns out array_stream didn't really do anything that StringIO
1295         didn't do (at least as of Python 2.6). This change removes it
1296         and updates all of the callers. Where possible, I changed the
1297         test assertions in order to capture the intent more clearly,
1298         e.g., instead of calling self.assertTrue('foo' in stream.get()),
1299         we have self.assertContainsLine(stream, 'foo'), and instead of
1300         self.assertTrue(stream.empty()), we have self.assertEmpty(stream) -
1301         the latter isn't that much more readable, but StringIO doesn't
1302         export an empty() method.
1303
1304         * Scripts/webkitpy/common/array_stream.py: Removed.
1305         * Scripts/webkitpy/common/array_stream_unittest.py: Removed.
1306         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1307         (passing_run):
1308         (run_and_capture):
1309         (StreamTestingMixin):
1310         (StreamTestingMixin.assertContains):
1311         (StreamTestingMixin.assertContainsLine):
1312         (StreamTestingMixin.assertEmpty):
1313         (StreamTestingMixin.assertNotEmpty):
1314         (LintTest):
1315         (LintTest.test_lint_test_files):
1316         (LintTest.test_lint_test_files__errors):
1317         (MainTest):
1318         (MainTest.test_child_process_1):
1319         (MainTest.test_child_processes_2):
1320         (MainTest.test_child_processes_min):
1321         (MainTest.test_help_printing):
1322         (MainTest.test_hung_thread):
1323         (MainTest.test_no_tests_found):
1324         (MainTest.test_no_tests_found_2):
1325         (MainTest.test_repeat_each_iterations_num_tests):
1326         (MainTest.test_test_list):
1327         (MainTest.test_unexpected_failures):
1328         (MainTest.test_worker_model__inline_with_child_processes):
1329         (MainTest.test_additional_platform_directory):
1330         (RebaselineTest):
1331         (RebaselineTest.assertBaselines):
1332         (RebaselineTest.test_reset_results):
1333         (RebaselineTest.test_missing_results):
1334         (RebaselineTest.test_new_baseline):
1335         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
1336         (MeteredStream.update):
1337         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
1338         (TestMeteredStream.test_regular):
1339         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1340         (TestUtilityFunctions.assertEmpty):
1341         (TestUtilityFunctions):
1342         (TestUtilityFunctions.assertNotEmpty):
1343         (TestUtilityFunctions.assertWritten):
1344         (TestUtilityFunctions.test_configure_logging):
1345         (Testprinter.assertEmpty):
1346         (Testprinter):
1347         (Testprinter.assertNotEmpty):
1348         (Testprinter.assertWritten):
1349         (Testprinter.reset):
1350         (Testprinter.get_printer):
1351         (Testprinter.test_help_printer):
1352         (Testprinter.do_switch_tests.do_helper):
1353         (Testprinter.test_print_one_line_summary):
1354         (Testprinter.test_print_test_result):
1355         (Testprinter.test_print_progress):
1356         (Testprinter.test_write_nothing):
1357         (Testprinter.test_write_misc):
1358         (Testprinter.test_write_everything):
1359         (Testprinter.test_write_verbose):
1360         (Testprinter.test_print_unexpected_results):
1361         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1362         (MainTest.assertWritten):
1363         (create_runner):
1364         (test_run_test_set):
1365         (test_run_test_set_kills_drt_per_run):
1366         (test_run_test_set_for_parser_tests):
1367         (test_run_test_set_with_json_output):
1368         (test_run_test_set_with_json_source):
1369         (test_run_test_set_with_multiple_repositories):
1370         (test_upload_json):
1371
1372 2012-02-18  Kevin Ollivier  <kevino@theolliviers.com>
1373
1374         [wx] Add the WebCore/page/scrolling directory to the build dirs.
1375
1376         * waf/build/settings.py:
1377
1378 2012-02-18  Kevin Ollivier  <kevino@theolliviers.com>
1379
1380         [wx] Unreviewed build fix. Don't error out or hang if we have
1381         downloaded dependencies but server update check fails.
1382
1383         * waf/build/build_utils.py:
1384         (download_if_newer):
1385
1386 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
1387
1388         The new run-webkit-tests needs to dump out pixel hash failures even if the pixel test passes.
1389         https://bugs.webkit.org/show_bug.cgi?id=69444
1390
1391         Reviewed by Tony Chang.
1392
1393         Currently if a test's image checksum doesn't match the checksum
1394         in the baseline, but the images themselves match according to
1395         ImageDiff, new-run-webkit-tests ignores the problem. This is
1396         probably bad, but it's not yet clear what the right thing to do
1397         is. This patch will log a warning to stderr, at least (but the
1398         test will still pass).
1399
1400         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1401         (SingleTestRunner._compare_image):
1402         (SingleTestRunner._run_reftest):
1403         * Scripts/webkitpy/layout_tests/port/test.py:
1404         (unit_test_list):
1405         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1406
1407 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
1408
1409         NRWT does not report failure for a skipped test
1410         https://bugs.webkit.org/show_bug.cgi?id=78750
1411
1412         Reviewed by Eric Seidel.
1413
1414         If a test is listed in a Skipped file and you run it anyway
1415         with --force, and the test fails, currently NRWT will print
1416         "test ran as expected"; this is confusing, because you probably
1417         expect the test to fail and yet this might lead you to think the
1418         test passed. This patch changes the expected behavior to "PASS",
1419         so tests that fail will be reported.
1420
1421         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1422         (result_was_expected):
1423         (TestExpectationParser):
1424         (TestExpectationParser.expectation_for_skipped_test):
1425         (TestExpectations):
1426         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1427         (test_add_skipped_tests):
1428         * Scripts/webkitpy/layout_tests/port/test.py:
1429         (unit_test_list): Add some tests that are expected to be in a Skipped file.
1430         (TestPort.skipped_tests): This adds actual integration test coverage of Skipped files.
1431
1432 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
1433
1434         webkitpy: fix test code after bug 78181
1435         https://bugs.webkit.org/show_bug.cgi?id=78870
1436
1437         Reviewed by Adam Barth.
1438
1439         I forgot to update the test code as per Tony's suggestion in
1440         bug 78181 (r108005). This change does that, and in doing so
1441         it revealed a subtle bug in _InlineWorkerConnection.run() that
1442         I am fixing as part of this (_alive would not be cleared if an
1443         exception was thrown).
1444
1445         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1446         (_InlineWorkerConnection.run):
1447         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1448         (_TestWorker.__init__):
1449         (_TestWorker.handle_stop):
1450         (_TestWorker.handle_test):
1451         (_TestWorker.run):
1452         (_TestsMixin.handle_exception):
1453         (_TestsMixin.test_unknown_message):
1454
1455 2012-02-17  Adam Roben  <aroben@apple.com>
1456
1457         Mac build fix after r108119
1458
1459         * DumpRenderTree/mac/DumpRenderTree.mm:
1460         (runThread):
1461         (runPthread):
1462         (testThreadIdentifierMap):
1463         Updated to match current WTF threading APIs.
1464
1465 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
1466
1467         revert r107147 - breaks webkit-patch on Mac SL
1468         https://bugs.webkit.org/show_bug.cgi?id=78866
1469
1470         Reviewed by Adam Barth.
1471
1472         It appears that zipfile.ExtractAll is broken on Python 2.6.1,
1473         which is the version that ships on Mac SL. Reverting this
1474         change until we no longer have to worry about that version.
1475
1476         * Scripts/webkitpy/common/system/autoinstall.py:
1477         (AutoInstaller):
1478         (AutoInstaller._extract_all): Added a comment about SL.
1479         (AutoInstaller._unzip):
1480
1481 2012-02-17  Mihnea Ovidenie  <mihnea@adobe.com>
1482
1483         CSS regions enabled by default
1484         https://bugs.webkit.org/show_bug.cgi?id=78525
1485
1486         Reviewed by David Hyatt.
1487
1488         Add a runtime preference to enable/disable regions functionality at runtime(WebKitCSSRegionsEnabled).
1489         CSSRegions are still enabled by default.
1490         In DRT, use layoutTestController.overridePreference("WebKitCSSRegionsEnabled", "0") to disable the css regions functionality.
1491
1492         * DumpRenderTree/chromium/LayoutTestController.cpp:
1493         (LayoutTestController::overridePreference):
1494         * DumpRenderTree/chromium/WebPreferences.cpp:
1495         (WebPreferences::reset):
1496         (WebPreferences::applyTo):
1497         * DumpRenderTree/chromium/WebPreferences.h:
1498         (WebPreferences):
1499         * DumpRenderTree/mac/DumpRenderTree.mm:
1500         (resetDefaultsToConsistentValues):
1501
1502 2012-02-17  Maciej Stachowiak  <mjs@apple.com>
1503
1504         Some API tests erroneously use = instead of == (causing build failures)
1505         https://bugs.webkit.org/show_bug.cgi?id=78915
1506
1507         Reviewed by Sam Weinig.
1508
1509         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1510         (TestWebKitAPI::decidePolicyForNavigationAction): Replace an = with an ==
1511         (TestWebKitAPI::decidePolicyForNewWindowAction): ditto
1512
1513 2012-02-17  Peter Beverloo  <peter@chromium.org>
1514
1515         [Chromium] Include TestShellLinux.cpp in the build for Android
1516         https://bugs.webkit.org/show_bug.cgi?id=78865
1517
1518         Reviewed by Eric Seidel.
1519
1520         Android will be re-using the TestShellLinux.cpp file. I already
1521         added this r104033, but it seems to have gotten lost in the
1522         recent refactorings.
1523
1524         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1525
1526 2012-02-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1527
1528         Unreviewed, disable video build on EFL until it can be
1529         supported by EFL build bot.
1530
1531         * Scripts/build-webkit:
1532
1533 2012-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1534
1535         [GTK] Implement zoom in/out in MiniBrowser
1536         https://bugs.webkit.org/show_bug.cgi?id=75253
1537
1538         Reviewed by Gustavo Noronha Silva.
1539
1540         * MiniBrowser/gtk/BrowserWindow.c:
1541         (browserWindowCanZoomIn):
1542         (browserWindowCanZoomOut):
1543         (browserWindowUpdateZoomActions):
1544         (webViewZoomLevelChanged):
1545         (zoomInCallback):
1546         (zoomOutCallback):
1547         (browser_window_init):
1548         (browserWindowConstructed):
1549
1550 2012-02-17  Nikolas Zimmermann  <nzimmermann@rim.com>
1551
1552         layoutTestController.display() is flaky for SVG tests
1553         https://bugs.webkit.org/show_bug.cgi?id=78021
1554
1555         Reviewed by Adam Roben.
1556
1557         Apply the same fix to DRT/Win, as previously applied to DRT/Mac.
1558         Size the web view before running the test, not when dumping.
1559         All platforms handle this correctly now.
1560
1561         * DumpRenderTree/win/DumpRenderTree.cpp:
1562         (dump):
1563         (sizeWebViewForCurrentTest):
1564         (runTest):
1565
1566 2012-02-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1567
1568         [GTK] Make install is broken when building without --enable-gtk-doc
1569         https://bugs.webkit.org/show_bug.cgi?id=78828
1570
1571         Reviewed by Martin Robinson.
1572
1573         * gtk/generate-gtkdoc:
1574         (rebase_installed_docs): Check documentation has been generated
1575         before trying to rebase it.
1576
1577 2012-02-16  Dirk Pranke  <dpranke@chromium.org>
1578
1579         nrwt: simplify worker interface
1580         https://bugs.webkit.org/show_bug.cgi?id=78181
1581
1582         Reviewed by Tony Chang.
1583
1584         This change moves code in name(), is_done(), run(), and cancel()
1585         from Worker to AbstractWorker, since the logic is pretty much
1586         boilerplate code that any implementation would want to use.
1587
1588         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1589         (get.should):
1590         (AbstractWorker.__init__):
1591         (AbstractWorker):
1592         (AbstractWorker.name):
1593         (AbstractWorker.stop_handling_messages):
1594         (AbstractWorker.run):
1595         (AbstractWorker.is_done):
1596         (AbstractWorker.cancel):
1597         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1598         (Worker.__init__):
1599         (Worker.run):
1600         (Worker.handle_stop):
1601
1602 2012-02-16  Michael Saboff  <msaboff@apple.com>
1603
1604         ENH: Add ability to run subset of JavaScript layout tests with JSC
1605         https://bugs.webkit.org/show_bug.cgi?id=78764
1606
1607         Reviewed by Gavin Barraclough.
1608
1609         New simple test drive shell script that runs a defined
1610         list of javascript tests using jsc and the standalone-{pre,post}.js
1611         wrappers.
1612
1613         * Scripts/run-fast-jsc: Added.
1614
1615 2012-02-16  Csaba Osztrogonác  <ossy@webkit.org>
1616
1617         Add new Qt performance tester bot to build.webkit.org
1618         https://bugs.webkit.org/show_bug.cgi?id=78795
1619
1620         Reviewed by Adam Roben.
1621
1622         * BuildSlaveSupport/build.webkit.org-config/config.json:
1623
1624 2012-02-16  Patrick Gansterer  <paroga@webkit.org>
1625
1626         Disable inspector on WinCE.
1627
1628         Avoid compiling InspectorBackendDispatcher.cpp, which causes an internal compiler error.
1629
1630         * Scripts/build-webkit:
1631
1632 2012-02-16  Patrick Gansterer  <paroga@webkit.org>
1633
1634         WinCE build fix after r107656.
1635
1636         Disable FTPDIR on WinCE, since it does not compile there.
1637
1638         * Scripts/build-webkit:
1639
1640 2012-02-15  Leo Yang  <leo.yang@torchmobile.com.cn>
1641
1642         Build fix after r107863.
1643
1644         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
1645
1646 2012-02-15  Tony Chang  <tony@chromium.org>
1647
1648         [chromium] add linux dbg back to garden-o-matic
1649         https://bugs.webkit.org/show_bug.cgi?id=78752
1650
1651         Reviewed by Adam Barth.
1652
1653         This reflects the current linux debug bot name (there's only one bot).
1654         I'm also remove the mac clang builder since it doesn't exist (mac
1655         always uses clang now).
1656
1657         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1658         * Scripts/webkitpy/layout_tests/port/builders.py:
1659
1660 2012-02-15  Sam Weinig  <sam@webkit.org>
1661
1662         Add style check for ctype functions that are generally frowned upon in WebKit
1663         https://bugs.webkit.org/show_bug.cgi?id=78748
1664
1665         Reviewed by Anders Carlsson.
1666
1667         Not every platform has DisallowCType.h to check for uses of the ctype.h
1668         functions, so add a style check for them as well.
1669
1670         * Scripts/webkitpy/style/checkers/cpp.py:
1671         (check_ctype_functions):
1672         (check_style):
1673         (CppChecker):
1674         Add check.
1675
1676         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1677         (WebKitStyleTest.test_ctype_fucntion):
1678         Add checker.
1679
1680 2012-02-15  Szilard Ledan  <Ledan-Muntean.Szilard@stud.u-szeged.hu>
1681
1682         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
1683         https://bugs.webkit.org/show_bug.cgi?id=76546
1684
1685         Reviewed by Simon Hausmann.
1686
1687         Resize the web view programatically because the declarative property binding
1688         does not work. Seems like our qml environment is not initialized fully but it
1689         needs more investigation.
1690
1691         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1692         (WTR::WrapperWindow::handleStatusChanged):
1693         (WTR::PlatformWebView::resizeTo):
1694
1695 2012-02-15  Dirk Pranke  <dpranke@chromium.org>
1696
1697         webkitpy: add a worker_args concept to start_worker()
1698         https://bugs.webkit.org/show_bug.cgi?id=78572
1699
1700         Reviewed by Tony Chang.
1701
1702         This change replaces the three NRWT-specific arguments passed
1703         through the broker to the worker with a generic WorkerArguments
1704         wrapper class and a separate set_inline_arguments() call that can
1705         be used to pass additional data to the worker when it is running
1706         in the same process as the manager (this is needed for testing).
1707         With the addition of set_inline_arguments() we also no longer
1708         need to pass an optional argument to the worker.run() call.
1709
1710         Note that this method is *only* implemented on inline workers,
1711         so calling this on a regular (child process) worker will result
1712         in a runtime error.
1713
1714         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1715         (Manager._run_tests):
1716         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1717         (AbstractWorker.__init__):
1718         (AbstractWorker.run):
1719         (_ManagerConnection.start_worker):
1720         (_InlineManager.start_worker):
1721         (_InlineManager.set_inline_arguments):
1722         (_InlineManager.run_message_loop):
1723         (_MultiProcessManager.start_worker): Reworked signature.
1724         (_WorkerConnection.__init__):
1725         (_InlineWorkerConnection.__init__):
1726         (_InlineWorkerConnection.set_inline_arguments): New method.
1727         (_InlineWorkerConnection):
1728         (_InlineWorkerConnection.run):
1729         (_Process.run):
1730         (_MultiProcessWorkerConnection.__init__):
1731         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1732         (_TestWorker.__init__):
1733         (_TestWorker.set_inline_arguments):
1734         (_TestWorker.handle_test):
1735         (_TestWorker.run):
1736         (_TestsMixin.test_cancel):
1737         (_TestsMixin.test_done):
1738         (_TestsMixin.test_unknown_message):
1739         (InlineBrokerTests): New class for more testing.
1740         (InlineBrokerTests.setUp):
1741         (InlineBrokerTests.test_inline_arguments): New test.
1742         (InterfaceTest.test_managerconnection_is_abstract):
1743         (InterfaceTest.test_workerconnection_is_abstract):
1744         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1745         (WorkerArguments):
1746         (WorkerArguments.__init__):
1747         (Worker.__init__):
1748         (Worker.set_inline_arguments):
1749         (Worker):
1750         (Worker.run):
1751         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
1752         (WorkerTest.test_default_platform_in_worker):
1753
1754 2012-02-15  Adam Klein  <adamk@chromium.org>
1755
1756         Unreviewed, rolling out r107704.
1757         http://trac.webkit.org/changeset/107704
1758         https://bugs.webkit.org/show_bug.cgi?id=78486
1759
1760         Caused layout test crashes in debug builds.
1761
1762         Specific crashing tests:
1763
1764         fast/events/show-modal-dialog-onblur-onfocus.html
1765         fast/harness/show-modal-dialog.html
1766         inspector/console/console-long-eval-crash.html
1767
1768         * DumpRenderTree/chromium/TestShell.cpp:
1769         (TestShell::TestShell):
1770         * DumpRenderTree/chromium/TestShell.h:
1771         (TestShell):
1772         * DumpRenderTree/chromium/WebViewHost.cpp:
1773         (WebViewHost::runModal):
1774
1775 2012-02-15  Michael Brüning  <michael.bruning@nokia.com>
1776
1777         [Qt] Add UI for HTTP authentication in the Qt MiniBrowser
1778         https://bugs.webkit.org/show_bug.cgi?id=76347
1779
1780         Reviewed by Kenneth Rohde Christiansen.
1781
1782         * MiniBrowser/qt/MiniBrowser.qrc:
1783         * MiniBrowser/qt/qml/AuthenticationDialog.qml: Added. 
1784         * MiniBrowser/qt/qml/BrowserWindow.qml:
1785         * MiniBrowser/qt/qml/DialogLineInput.qml:
1786
1787 2012-02-15  Simon Hausmann  <simon.hausmann@nokia.com>
1788
1789         [Qt] Fix WebGL in QtTestBrowser
1790
1791         Reviewed by Tor Arne Vestbø.
1792
1793         * QtTestBrowser/QtTestBrowser.pro: Set the OpenGL define so that when passing
1794         the options for enabling GL we also pass them on properly.
1795
1796 2012-02-14  Sam Weinig  <sam@webkit.org>
1797
1798         Add #include of unistd.h on the mac for getcwd. 
1799
1800         Reviewed by Anders Carlsson.
1801
1802         This is necessary when building with libc++.
1803
1804         * WebKitTestRunner/TestInvocation.cpp:
1805
1806 2012-02-14  Sam Weinig  <sam@webkit.org>
1807
1808         In DRT, don't #define min or max on non-Windows platforms, it just isn't needed
1809         https://bugs.webkit.org/show_bug.cgi?id=78663
1810
1811         Reviewed by Anders Carlsson.
1812
1813         * DumpRenderTree/DumpRenderTreePrefix.h:
1814         * DumpRenderTree/cg/ImageDiffCG.cpp:
1815
1816 2012-02-14  Adam Barth  <abarth@webkit.org>
1817
1818         Implement an adb-based driver for the ChromiumAndroidPort
1819         https://bugs.webkit.org/show_bug.cgi?id=78627
1820
1821         Reviewed by Eric Seidel.
1822
1823         This driver mostly just wires up the ChromiumDriver through adb.  In
1824         some cases, it translates protocol elements, such as URIs, so that the
1825         rest of webkitpy is insulated from the "remoteness" of the target device.
1826
1827         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1828         (ChromiumAndroidPort.start_helper):
1829         (ChromiumAndroidPort._driver_class):
1830         (ChromiumAndroidPort._update_version):
1831         (ChromiumAndroidPort._get_stderr):
1832         (ChromiumAndroidPort):
1833         (ChromiumAndroidPort._get_last_stacktrace):
1834         (ChromiumAndroidPort._teardown_performance):
1835         (ChromiumAndroidDriver):
1836         (ChromiumAndroidDriver.__init__):
1837         (ChromiumAndroidDriver._start):
1838         (ChromiumAndroidDriver.run_test):
1839         (ChromiumAndroidDriver.stop):
1840         (ChromiumAndroidDriver._test_shell_command):
1841         (ChromiumAndroidDriver._write_command_and_read_line):
1842         (ChromiumAndroidDriver._output_image):
1843         (ChromiumAndroidDriver._has_crash_hint):
1844
1845 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
1846
1847         webkitpy: the real_name() method in the Port class is no longer needed
1848         https://bugs.webkit.org/show_bug.cgi?id=78651
1849
1850         Reviewed by Eric Seidel.
1851
1852         The change in bug 78565 / r107718 made it no longer necessary
1853         (we can use options.platform instead).
1854
1855         * Scripts/webkitpy/layout_tests/port/base.py:
1856         (Port.name):
1857         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1858         (MockDRTPort.__init__):
1859
1860 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
1861
1862         webkitpy: clean up options, port handling in manager_worker_broker
1863         https://bugs.webkit.org/show_bug.cgi?id=78568
1864
1865         Reviewed by Tony Chang.
1866
1867         manager_worker_broker no longer needs options or port objects
1868         directly, so we make them only be passed in start_worker().
1869
1870         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1871         (Manager._run_tests):
1872         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1873         (get):
1874         (_ManagerConnection.__init__):
1875         (_ManagerConnection.start_worker):
1876         (_InlineManager.__init__):
1877         (_InlineManager.start_worker):
1878         (_InlineManager.run_message_loop):
1879         (_MultiProcessManager.__init__):
1880         (_MultiProcessManager):
1881         (_MultiProcessManager.start_worker):
1882         (_InlineWorkerConnection.__init__):
1883         (_InlineWorkerConnection.run):
1884         (_Process.__init__):
1885         (_MultiProcessWorkerConnection.__init__):
1886         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1887         (make_broker):
1888         (_TestWorker.run):
1889         (_TestsMixin.test_cancel):
1890         (_TestsMixin.test_done):
1891         (_TestsMixin.test_unknown_message):
1892         (MultiProcessBrokerTests.setUp):
1893         (InterfaceTest.test_managerconnection_is_abstract):
1894         * Scripts/webkitpy/layout_tests/controllers/message_broker.py:
1895         (Broker.__init__):
1896
1897 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
1898
1899         nrwt: add a unit test for regression introduced in bug 78565
1900         https://bugs.webkit.org/show_bug.cgi?id=78646
1901
1902         Reviewed by Tony Chang.
1903
1904         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py: Added.
1905         (FakeConnection):
1906         (FakeConnection.run_message_loop):
1907         (FakeConnection.post_message):
1908         (WorkerTest):
1909         (WorkerTest.test_default_platform_in_worker):
1910
1911 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
1912
1913         NRWT is broken for the default port
1914         https://bugs.webkit.org/show_bug.cgi?id=78640
1915     
1916         Reviewed by Tony Chang.
1917
1918         The change in r107718 (bug 78565) broke NRWT if you didn't
1919         specify any sort of --platform flag or equivalent. I didn't
1920         catch this because it's a full integration test (which we don't
1921         have an automated test for) and I missed this command line
1922         variant when testing interactively.
1923
1924         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1925         (Worker.run):
1926
1927 2012-02-14  Ramya Chandrasekaran  <cramya@google.com>
1928
1929         Last character display for passwords in Android.
1930         https://bugs.webkit.org/show_bug.cgi?id=78532
1931
1932         Reviewed by Adam Barth.
1933
1934         * DumpRenderTree/chromium/WebPreferences.cpp:
1935         (WebPreferences::applyTo):
1936
1937 2012-02-14  Adam Barth  <abarth@webkit.org>
1938
1939         Finish implementing start_helper for ChromiumAndroidPort
1940         https://bugs.webkit.org/show_bug.cgi?id=78582
1941
1942         Reviewed by Eric Seidel.
1943
1944         This patch contains the remaining odds and ends for the start_helper function.
1945
1946         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1947         (ChromiumAndroidPort.start_helper):
1948         (ChromiumAndroidPort._synchronize_datetime):
1949         (ChromiumAndroidPort):
1950         (ChromiumAndroidPort._check_version):
1951         (ChromiumAndroidPort._run_adb_command):
1952         (ChromiumAndroidPort._copy_device_file):
1953
1954 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
1955
1956         webkitpy: create ports in Workers, not in manager_worker_broker
1957         https://bugs.webkit.org/show_bug.cgi?id=78565
1958
1959         Reviewed by Tony Chang.
1960
1961         We will now create the Port object (if necessary) in the Worker
1962         directly, so that the manager_worker_broker module doesn't need
1963         all of this layout_test-specific logic. Part of the fixes for
1964         bug 78171.
1965
1966         These changes are all well-tested by the existing tests in
1967         run_webkit_tests_integrationtest.py.
1968
1969         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1970         (_Process.run):
1971         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1972         (Worker.__init__):
1973         (Worker.safe_init):
1974         (Worker.run):
1975         (Worker.cleanup):
1976         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1977         (parse_args):
1978         (main): Fix a minor bug where running the 'mock-test' port didn't work right.
1979
1980 2012-02-14  Jochen Eisinger  <jochen@chromium.org>
1981
1982         [chromium] check that we're not running multiple modal dialogs at the same time
1983         https://bugs.webkit.org/show_bug.cgi?id=78486
1984
1985         Reviewed by Kent Tamura.
1986
1987         * DumpRenderTree/chromium/TestShell.cpp:
1988         (TestShell::TestShell):
1989         * DumpRenderTree/chromium/TestShell.h:
1990         (TestShell::setIsDisplayingModalDialog):
1991         (TestShell::isDisplayingModalDialog):
1992         (TestShell):
1993         * DumpRenderTree/chromium/WebViewHost.cpp:
1994         (WebViewHost::runModal):
1995
1996 2012-02-14  Adam Barth  <abarth@webkit.org>
1997
1998         Enable the GPU codepath in the chromium-android port
1999         https://bugs.webkit.org/show_bug.cgi?id=78580
2000
2001         Reviewed by James Robinson.
2002
2003         Suprise!  There is no ChromiumGpuAndroidPort!  Instead, Chromium
2004         Android always uses the GPU codepath, so we set the GPU flags on the
2005         main chromium-android port instead.
2006
2007         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2008         (ChromiumAndroidPort.__init__):
2009
2010 2012-02-14  Adam Barth  <abarth@webkit.org>
2011
2012         NRWT should expose --adb-args flag for Android
2013         https://bugs.webkit.org/show_bug.cgi?id=78579
2014
2015         Reviewed by Eric Seidel.
2016
2017         This flag is already wired up to the ChromiumAndroidPort.
2018
2019         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2020         (parse_args):
2021
2022 2012-02-14  Alexey Proskuryakov  <ap@apple.com>
2023
2024         [Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets
2025         https://bugs.webkit.org/show_bug.cgi?id=78541
2026         <rdar://problem/10036695>
2027
2028         Reviewed by Kent Tamura.
2029
2030         * DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
2031         * DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
2032         After each test, reset to using new protocol.
2033
2034 2012-02-11  Nikolas Zimmermann  <nzimmermann@rim.com>
2035
2036         Convert svg/animations to use SMIL methods for driving the timeline
2037         https://bugs.webkit.org/show_bug.cgi?id=78422
2038
2039         Reviewed by Dirk Schulze.
2040
2041         Remove no longer needed SVG specific animation sampling functionality from DRT.
2042         Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.
2043
2044         * DumpRenderTree/LayoutTestController.cpp:
2045         (LayoutTestController::staticFunctions):
2046         * DumpRenderTree/LayoutTestController.h:
2047         (LayoutTestController):
2048         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2049         * DumpRenderTree/chromium/LayoutTestController.cpp:
2050         (LayoutTestController::LayoutTestController):
2051         * DumpRenderTree/chromium/LayoutTestController.h:
2052         (LayoutTestController):
2053         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2054         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2055         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2056         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2057         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2058         (LayoutTestController):
2059         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2060         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2061
2062 2012-02-13  Rob Flack  <flackr@chromium.org>
2063
2064         Add Linux ChromiumOS test results to flakiness dashboard.
2065         https://bugs.webkit.org/show_bug.cgi?id=78495
2066
2067         Reviewed by Ojan Vafai.
2068
2069         * TestResultServer/static-dashboards/builders.js:
2070         * TestResultServer/static-dashboards/dashboard_base.js:
2071
2072 2012-02-13  ChangSeok Oh  <shivamidow@gmail.com>
2073
2074         [GTK] Mutation Observers build is broken
2075         https://bugs.webkit.org/show_bug.cgi?id=78433
2076
2077         Reviewed by Martin Robinson.
2078
2079         Enabled mutation observers as a default feature for GTK port, too.
2080
2081         * Scripts/build-webkit:
2082
2083 2012-02-13  Loïc Yhuel  <loic.yhuel_ext@softathome.com>
2084
2085         Allow to configure ENABLE_FTPDIR in build-webkit
2086         https://bugs.webkit.org/show_bug.cgi?id=65098
2087
2088         Reviewed by Eric Seidel.
2089
2090         Allow to disable ENABLE_FTPDIR by command line.
2091         Remove ENABLE_FTPDIR from --minimal build
2092
2093         * Scripts/build-webkit: Add entries for ENABLE_FTPDIR (enabled by default)
2094         * qmake/mkspecs/features/features.prf: ENABLE_FTPDIR must be set to match Platform.h,
2095         as, for Qt platform, build-webkit does not add on command line what it thinks to be default values
2096
2097 2012-02-13  Shinya Kawanaka  <shinyak@chromium.org>
2098
2099         Add shinyak as committer.
2100
2101         Unreviewed.
2102
2103         * Scripts/webkitpy/common/config/committers.py:
2104
2105 2012-02-13  Adam Barth  <abarth@webkit.org>
2106
2107         Implement start/stop_helper for ChromiumAndroidPort
2108         https://bugs.webkit.org/show_bug.cgi?id=78558
2109
2110         Reviewed by Dirk Pranke.
2111
2112         These functions (and their dependencies) set up the Android device for
2113         testing.
2114
2115         This patch also includes a few tweaks on the previous patch recommended
2116         by dpranke.
2117
2118         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2119         (ChromiumAndroidPort.__init__):
2120         (ChromiumAndroidPort.start_helper):
2121         (ChromiumAndroidPort.stop_helper):
2122         (ChromiumAndroidPort._shut_down_http_server):
2123         (ChromiumAndroidPort):
2124         (ChromiumAndroidPort._push_executable):
2125         (ChromiumAndroidPort._push_fonts):
2126         (ChromiumAndroidPort._restore_system_font):
2127         (ChromiumAndroidPort._push_test_resources):
2128         (ChromiumAndroidPort._push_to_device):
2129         (ChromiumAndroidPort._pull_from_device):
2130         (ChromiumAndroidPort._kill_device_process):
2131         (ChromiumAndroidPort._setup_performance):
2132         (ChromiumAndroidPort._teardown_performance):
2133         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2134         (ChromiumAndroidPortTest):
2135         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2136         (PortTestCase):
2137         (PortTestCase.make_port):
2138         (PortTestCase.test_default_worker_model):
2139
2140 2012-02-13  Adam Barth  <abarth@webkit.org>
2141
2142         Implement enough of ChromiumAndroidPort to make ChromiumAndroidPortTest pass
2143         https://bugs.webkit.org/show_bug.cgi?id=78550
2144
2145         Reviewed by Eric Seidel.
2146
2147         Much of this code just forwards to the "host" port, which seems like a
2148         reasonable thing to do.
2149
2150         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2151         (ChromiumAndroidPort.__init__):
2152         (ChromiumAndroidPort.stop_helper):
2153         (ChromiumAndroidPort):
2154         (ChromiumAndroidPort._build_path):
2155         (ChromiumAndroidPort._path_to_apache):
2156         (ChromiumAndroidPort._path_to_apache_config_file):
2157         (ChromiumAndroidPort._path_to_driver):
2158         (ChromiumAndroidPort._path_to_helper):
2159         (ChromiumAndroidPort._path_to_image_diff):
2160         (ChromiumAndroidPort._path_to_lighttpd):
2161         (ChromiumAndroidPort._path_to_lighttpd_modules):
2162         (ChromiumAndroidPort._path_to_lighttpd_php):
2163         (ChromiumAndroidPort._path_to_wdiff):
2164         (ChromiumAndroidPort._shut_down_http_server):
2165         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2166         (ChromiumAndroidPortTest):
2167         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2168         (PortTestCase):
2169         (PortTestCase.make_port):
2170         (PortTestCase.test_default_worker_model):
2171
2172 2012-02-13  Adam Barth  <abarth@webkit.org>
2173
2174         chromium_android.py should implement "virtual" methods from ChromiumPort
2175         https://bugs.webkit.org/show_bug.cgi?id=78545
2176
2177         Reviewed by Dirk Pranke.
2178
2179         This patch adds basic implementations that specialize a bunch of
2180         functions from ChromiumPort.
2181
2182         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2183         (ChromiumAndroidPort):
2184         (ChromiumAndroidPort.__init__):
2185         (ChromiumAndroidPort.default_child_processes):
2186         (ChromiumAndroidPort.baseline_search_path):
2187         (ChromiumAndroidPort.check_build):
2188         (ChromiumAndroidPort.check_sys_deps):
2189         (ChromiumAndroidPort.default_worker_model):
2190         (ChromiumAndroidPort.test_expectations):
2191         (ChromiumAndroidPort.start_http_server):
2192         (ChromiumAndroidPort.stop_http_server):
2193         (ChromiumAndroidPort.start_helper):
2194         (ChromiumAndroidPort.stop_helper):
2195
2196 2012-02-13  Adam Barth  <abarth@webkit.org>
2197
2198         Add a skeleton ChromiumAndroid port to webkitpy
2199         https://bugs.webkit.org/show_bug.cgi?id=78543
2200
2201         Reviewed by Eric Seidel.
2202
2203         This patch just adds an empty ChromiumAndroid port object to webkitpy
2204         and wires it up to the factory objects.  An actual implementation will
2205         follow.
2206
2207         * Scripts/webkitpy/layout_tests/port/chromium.py:
2208         (ChromiumPort):
2209         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Added.
2210         (ChromiumAndroidPort):
2211         (ChromiumAndroidPort.__init__):
2212         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2213         (ChromiumPortTest.test_all_test_configurations):
2214         * Scripts/webkitpy/layout_tests/port/factory.py:
2215         (PortFactory):
2216
2217 2012-02-13  Adam Barth  <abarth@webkit.org>
2218
2219         NRWT's HTTP servers should support additional directories for resources
2220         https://bugs.webkit.org/show_bug.cgi?id=78528
2221
2222         Reviewed by Eric Seidel.
2223
2224         This functionality will be used by the Chromium-Android port.
2225
2226         * Scripts/webkitpy/layout_tests/port/base.py:
2227         (Port.to.start_http_server):
2228         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2229         (LayoutTestApacheHttpd.__init__):
2230         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2231         (Lighttpd.__init__):
2232         (Lighttpd._prepare_config):
2233
2234 2012-02-13  Ami Fischman  <fischman@chromium.org>
2235
2236         Add fischman as committer.
2237
2238         Unreviewed
2239
2240         * Scripts/webkitpy/common/config/committers.py:
2241
2242 2012-02-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
2243
2244         [EFL] Drop support for the Curl network backend.
2245         https://bugs.webkit.org/show_bug.cgi?id=77874
2246
2247         Reviewed by Eric Seidel.
2248
2249         Nobody seems to be maintaining the Curl backend in WebCore, the
2250         EFL port developers all seem to be using the Soup backend and the
2251         port itself has many features which are only implemented for the
2252         latter.
2253
2254         * DumpRenderTree/efl/CMakeLists.txt: Always link to glib/libsoup
2255         and always add the required include directories.
2256         * EWebLauncher/CMakeLists.txt: Add the required glib/libsoup
2257         include directories and link to them.
2258
2259 2012-02-13  Kenichi Ishibashi  <bashi@chromium.org>
2260
2261         [WebSocket] Update pywebsocket to 0.7.1
2262         https://bugs.webkit.org/show_bug.cgi?id=78484
2263
2264         pywebsocket-0.7.1 follow the current draft of WebSocket deflate-frame extension.
2265
2266         Reviewed by Kent Tamura.
2267
2268         * Scripts/webkitpy/thirdparty/__init__.py:
2269         (AutoinstallImportHook._install_pywebsocket):
2270
2271 2012-02-12  Kangil Han  <kangil.han@samsung.com>
2272
2273         [EFL][DRT] Implement zoomPage{In,Out} and textZoom{In,Out} events.
2274         https://bugs.webkit.org/show_bug.cgi?id=78091
2275
2276         Reviewed by Hajime Morita.
2277
2278         Implemented zoomPageIn, zoomPageOut, textZoomIn and textZoomOut events on EFL DRT.
2279         This patch will activate around 1,900 test cases from skipped list in EFL port.
2280
2281         * DumpRenderTree/efl/EventSender.cpp:
2282         (textZoom):
2283         (pageZoom):
2284         (textZoomInCallback):
2285         (textZoomOutCallback):
2286         (zoomPageInCallback):
2287         (zoomPageOutCallback):
2288
2289 2012-02-12  Ashod Nakashian  <ashodnakashian@yahoo.com>
2290
2291         KeywordLookupGenerator.py script fails in some cases
2292         https://bugs.webkit.org/show_bug.cgi?id=77886
2293
2294         Reviewed by Benjamin Poulain.
2295
2296         * Scripts/webkitpy/style/checker.py: New rule for Keywords.table to not have CR.
2297         * Scripts/webkitpy/style/checker_unittest.py: New UT for Keywords.table rule.
2298         (GlobalVariablesTest.test_path_rules_specifier):
2299
2300 2012-02-12  Joe Thomas  <joethomas@motorola.com>
2301
2302         Add toText and isTextNode helpers in Text class.
2303         https://bugs.webkit.org/show_bug.cgi?id=78140
2304
2305         Unit test case for the new style checker introduced.
2306
2307         Reviewed by Adam Barth.
2308
2309         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2310         (CppStyleTest):
2311         (CppStyleTest.test_static_cast_readability): Added a unit test case.
2312
2313 2012-02-12  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2314
2315         Enable features supported by EFL port in build-webkit.
2316         https://bugs.webkit.org/show_bug.cgi?id=78348
2317
2318         Reviewed by Ryosuke Niwa.
2319
2320         Sync build-webkit with OptionEfl.cmake, as some features enabled in
2321         OptionEfl.cmake are not enabled in build-webkit.
2322
2323         * Scripts/build-webkit:
2324
2325 2012-02-12  Joe Thomas  <joethomas@motorola.com>
2326
2327         Add toText and isTextNode helpers in Text class.
2328         https://bugs.webkit.org/show_bug.cgi?id=78140
2329
2330         Added a style checker to use toText rather than static_cast<Text*>.
2331
2332         Reviewed by Adam Barth.
2333
2334         * Scripts/webkitpy/style/checkers/cpp.py:
2335         (check_language): Style checker for static_cast<Text*>.
2336
2337 2012-02-12  Philippe Normand  <pnormand@igalia.com>
2338
2339         Unreviewed, disable Mutation observers build on GTK until it can
2340         actually build.
2341
2342         * Scripts/build-webkit:
2343
2344 2012-02-11  Benjamin Poulain  <benjamin@webkit.org>
2345
2346         Add back WTFURL to WebKit
2347         https://bugs.webkit.org/show_bug.cgi?id=77291
2348
2349         Reviewed by Adam Barth.
2350
2351         Add a flag to build-webkit to easily build WebKit with WTFURL.
2352
2353         * Scripts/build-webkit:
2354
2355 2012-02-10  Adam Klein  <adamk@chromium.org>
2356
2357         Enable MUTATION_OBSERVERS by default on all platforms
2358         https://bugs.webkit.org/show_bug.cgi?id=78196
2359
2360         Reviewed by Ojan Vafai.
2361
2362         * Scripts/build-webkit:
2363
2364 2012-02-10  Adam Barth  <abarth@webkit.org>
2365
2366         Move garden-o-matic's All Failures out of experimental
2367         https://bugs.webkit.org/show_bug.cgi?id=78395
2368
2369         Reviewed by Dimitri Glazkov.
2370
2371         Several folks have tried this feature and found it useful.
2372
2373         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2374
2375 2012-02-10  Tim Horton  <timothy_horton@apple.com>
2376
2377         NRWT should categorize options in --help
2378         https://bugs.webkit.org/show_bug.cgi?id=76221
2379
2380         Reviewed by Eric Seidel.
2381         
2382         Use optparse's OptionGroup mechanism to logically group NRWT's options,
2383         providing a better experience when scanning all the options.
2384
2385         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2386         (parse_args):
2387
2388 2012-02-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2389
2390         [Qt][WK2] Refactor on Qt5 Layout tests' structure
2391         https://bugs.webkit.org/show_bug.cgi?id=77450
2392
2393         Reviewed by Csaba Osztrogonác.
2394
2395         Fix the scripts and related unittest due to the rename of qt-wk2 and qt-wk1
2396         to qt-5.0-wk2 and qt-5.0-wk1.
2397
2398         * Scripts/old-run-webkit-tests:
2399         (buildPlatformResultHierarchy):
2400         (readSkippedFiles):
2401         * Scripts/webkitpy/layout_tests/port/qt.py:
2402         (QtPort._wk2_port_name):
2403         (QtPort._skipped_file_search_paths):
2404         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2405         (QtPortTest.test_baseline_search_path):
2406         * Scripts/webkitpy/layout_tests/port/webkit.py:
2407         (WebKitPort._wk2_port_name):
2408
2409 2012-02-09  Philippe Normand  <pnormand@igalia.com>
2410
2411         [GTK] EWS command-line option to run the tests
2412         https://bugs.webkit.org/show_bug.cgi?id=78211
2413
2414         Reviewed by Adam Barth.
2415
2416         New --run-tests option (defaults to False) for the EWS commands.
2417
2418         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2419         (AbstractEarlyWarningSystem):
2420         (AbstractEarlyWarningSystem.__init__):
2421         (AbstractEarlyWarningSystem.review_patch):
2422         (ChromiumLinuxEWS):
2423         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2424         (EarlyWarningSytemTest._test_builder_ews):
2425
2426 2012-02-09  Eric Seidel  <eric@webkit.org>
2427
2428         Rename compare_text and compare_audio to make it clear that they're !=
2429         https://bugs.webkit.org/show_bug.cgi?id=78301
2430
2431         Reviewed by Adam Barth.
2432
2433         I also removed the maybe_create_directory function which was redundant.
2434
2435         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2436         (Manager.set_up_run):
2437         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2438         (TestResultWriter._make_output_directory):
2439         * Scripts/webkitpy/layout_tests/port/base.py:
2440         (Port.do_text_results_differ):
2441         (Port.do_audio_results_differ):
2442         (Port.diff_text):
2443         (Port.driver_name):
2444         (Port.skips_perf_test):
2445         * Scripts/webkitpy/layout_tests/port/win.py:
2446         (WinPort.do_text_results_differ):
2447         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2448         (WinPortTest.test_do_text_results_differ):
2449         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2450         (LayoutTestApacheHttpd.__init__):
2451         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2452         (HttpServerBase.__init__):
2453         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2454         (Rebaseliner._diff_baselines):
2455
2456 2012-02-09  Zan Dobersek  <zandobersek@gmail.com>
2457
2458         [GTK] Add DRT support for modal dialogs
2459         https://bugs.webkit.org/show_bug.cgi?id=53600
2460
2461         Reviewed by Martin Robinson.
2462
2463         Implement the modal dialogs handling in DumpRenderTree and GtkLauncher.
2464         Most significantly, when creating a new web view in GtkLauncher, the window
2465         of the web view opener is passed around. In DumpRenderTree, the window of
2466         the main web view is always considered as the opener. This is required so
2467         the modal dialog's toplevel can be made transient for the opener's toplevel.
2468
2469         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2470         (webViewRunModalDialog):
2471         (createWebView):
2472         * GtkLauncher/main.c:
2473         (createWebViewCb):
2474         (runModalDialogCb):
2475         (createBrowser):
2476         (createWindow):
2477         (main):
2478
2479 2012-02-09  Zan Dobersek  <zandobersek@gmail.com>
2480
2481         [Gtk] security/set-form-autocomplete-attribute.html fails
2482         https://bugs.webkit.org/show_bug.cgi?id=78261
2483
2484         Reviewed by Martin Robinson.
2485
2486         Use the new helper in DumpRenderTreeSupportGtk to properly
2487         test whether an element performs autocompletion.
2488
2489         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2490         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
2491
2492 2012-02-09  James Robinson  <jamesr@chromium.org>
2493
2494         [chromium] Enable mock scrollbars for compositing layout tests
2495         https://bugs.webkit.org/show_bug.cgi?id=78299
2496
2497         Reviewed by Dirk Pranke.
2498
2499         This enables mock scrollbars by default for compositing tests. These pixel tests are intended to test the
2500         compositor behavior, not native theming, and having real scrollbars causes us to have to maintain significantly
2501         more pngs than we should and expose weird alpha bugs in our theming that doesn't impact real users.
2502
2503         * DumpRenderTree/chromium/TestShell.cpp:
2504         (TestShell::runFileTest):
2505         * DumpRenderTree/chromium/WebPreferences.cpp:
2506         (WebPreferences::reset):
2507         (WebPreferences::applyTo):
2508         * DumpRenderTree/chromium/WebPreferences.h:
2509         (WebPreferences):
2510
2511 2012-02-09  Eric Seidel  <eric@webkit.org>
2512
2513         Remove more uses of "os" from our webkitpy code
2514         https://bugs.webkit.org/show_bug.cgi?id=78292
2515
2516         Reviewed by Adam Barth.
2517
2518         * Scripts/webkitpy/common/checkout/checkout_mock.py:
2519         (MockCheckout.__init__):
2520         (MockCheckout.is_path_to_changelog):
2521         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2522         * Scripts/webkitpy/common/system/filesystem_mock.py:
2523         (MockFileSystem._split):
2524         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
2525         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2526         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2527         * Scripts/webkitpy/layout_tests/port/webkit.py:
2528         * Scripts/webkitpy/tool/bot/queueengine.py:
2529         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
2530         * Scripts/webkitpy/tool/commands/download.py:
2531         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2532         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2533         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2534         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2535         * Scripts/webkitpy/tool/commands/upload.py:
2536         (CreateBug.prompt_for_bug_title_and_comment):
2537         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
2538         * Scripts/webkitpy/tool/steps/attachtobug.py:
2539         (AttachToBug.run):
2540         * Scripts/webkitpy/tool/steps/checkstyle.py:
2541         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2542         * Scripts/webkitpy/tool/steps/commit_unittest.py:
2543         * Scripts/webkitpy/tool/steps/editchangelog.py:
2544         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2545         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
2546         (PrepareChangeLogTest.test_ensure_bug_url):
2547         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
2548         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2549         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
2550         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2551
2552 2012-02-09  Eric Seidel  <eric@webkit.org>
2553
2554         Remove the cr-mac-ews (it's long been dead)
2555         https://bugs.webkit.org/show_bug.cgi?id=78267
2556
2557         Reviewed by Adam Barth.
2558
2559         * QueueStatusServer/model/queues.py:
2560         (Queue):
2561         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2562         (ChromiumWindowsEWS):
2563         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2564         (EarlyWarningSytemTest._test_builder_ews):
2565         (EarlyWarningSytemTest._test_testing_ews):
2566
2567 2012-02-09  Dirk Pranke  <dpranke@chromium.org>
2568
2569         some tests in webkitpy are being run three times
2570         https://bugs.webkit.org/show_bug.cgi?id=78283
2571
2572         Reviewed by Ryosuke Niwa.
2573
2574         It turns out that if you import a class derived from
2575         unittest.TestCase as a base name (e.g., from ... import ChangeLogTest),
2576         the unittest framework treats it as if the class was defined in
2577         the file (as well in the original file). This led us to running
2578         the tests in ChangeLogTest three times.
2579
2580         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
2581         (PrepareChangeLogTest):
2582         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
2583         (_assert_message_for_revert_output):
2584
2585 2012-02-09  Adam Barth  <abarth@webkit.org>
2586
2587         Remove extraneous line in previous patch.  I forgot to remove this
2588         before landing.
2589
2590         * Scripts/webkitpy/layout_tests/port/driver.py:
2591         (DriverProxy.start):
2592
2593 2012-02-09  Adam Barth  <abarth@webkit.org>
2594
2595         run-perf-tests should have an option to pause before running tests so we can attach Instruments
2596         https://bugs.webkit.org/show_bug.cgi?id=78271
2597
2598         Reviewed by Ryosuke Niwa.
2599
2600         This lets me attach instruments to profile the performance of the test.
2601
2602         * Scripts/webkitpy/layout_tests/port/chromium.py:
2603         (ChromiumDriver.start):
2604         * Scripts/webkitpy/layout_tests/port/driver.py:
2605         (Driver.start):
2606         (DriverProxy.start):
2607         * Scripts/webkitpy/layout_tests/port/server_process.py:
2608         (ServerProcess.start):
2609         * Scripts/webkitpy/layout_tests/port/test.py:
2610         (TestDriver.start):
2611         * Scripts/webkitpy/layout_tests/port/webkit.py:
2612         (WebKitDriver.start):
2613         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2614         (get_tests_run.RecordingTestDriver.start):
2615         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2616         (PerfTestsRunner._parse_args):
2617         (PerfTestsRunner._run_tests_set):
2618         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2619         (start):
2620         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
2621         (test_run_test_set_kills_drt_per_run):
2622         (test_run_test_set_kills_drt_per_run.TestDriverWithStartCount):
2623         (test_run_test_set_kills_drt_per_run.TestDriverWithStartCount.start):
2624
2625 2012-02-09  Adam Barth  <abarth@webkit.org>
2626
2627         run-perf-tests --chromium should run the chromium port
2628         https://bugs.webkit.org/show_bug.cgi?id=78266
2629
2630         Reviewed by Ryosuke Niwa.
2631
2632         This patch makes run-perf-tests work more like run-webkit-tests.
2633
2634         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2635         (PerfTestsRunner._parse_args):
2636
2637 2012-02-09  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2638
2639         [Qt][WK2] run-webkit-tests --qt  crashes if WEBKIT_TESTFONTS is not set
2640         https://bugs.webkit.org/show_bug.cgi?id=77466
2641
2642         Reviewed by Dirk Pranke.
2643
2644         Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS
2645         is set or if we should raise an error. A unit test was added.
2646
2647         * Scripts/webkitpy/layout_tests/port/qt.py:
2648         (QtPort.operating_system):
2649         (QtPort):
2650         (QtPort.check_sys_deps):
2651         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2652         (QtPortTest.test_operating_system):
2653         (QtPortTest):
2654         (QtPortTest.test_check_sys_deps):
2655
2656 2012-02-09  Eric Seidel  <eric@webkit.org>
2657
2658         Rename ports.WebKitPort to DeprecatedPort and make it stop being all class methods
2659         https://bugs.webkit.org/show_bug.cgi?id=78263
2660
2661         Reviewed by Adam Barth.
2662
2663         * Scripts/webkitpy/common/config/ports.py:
2664         (DeprecatedPort):
2665         (DeprecatedPort.name):
2666         (DeprecatedPort.flag):
2667         (DeprecatedPort.script_path):
2668         (DeprecatedPort.script_shell_command):
2669         (DeprecatedPort.port):
2670         (DeprecatedPort.makeArgs):
2671         (DeprecatedPort.update_webkit_command):
2672         (DeprecatedPort.check_webkit_style_command):
2673         (DeprecatedPort.prepare_changelog_command):
2674         (DeprecatedPort.build_webkit_command):
2675         (DeprecatedPort.run_javascriptcore_tests_command):
2676         (DeprecatedPort.run_webkit_unit_tests_command):
2677         (DeprecatedPort.run_webkit_tests_command):
2678         (DeprecatedPort.run_python_unittests_command):
2679         (DeprecatedPort.run_perl_unittests_command):
2680         (DeprecatedPort.layout_tests_results_path):
2681         (MacPort):
2682         (WinPort):
2683         (GtkPort):
2684         (GtkPort.build_webkit_command):
2685         (GtkPort.run_webkit_tests_command):
2686         (QtPort):
2687         (QtPort.build_webkit_command):
2688         (EflPort):
2689         (EflPort.build_webkit_command):
2690         (ChromiumPort):
2691         (ChromiumPort.update_webkit_command):
2692         (ChromiumPort.build_webkit_command):
2693         (ChromiumPort.run_webkit_tests_command):
2694         (ChromiumPort.run_javascriptcore_tests_command):
2695         (ChromiumXVFBPort):
2696         (ChromiumXVFBPort.run_webkit_tests_command):
2697         * Scripts/webkitpy/common/config/ports_unittest.py:
2698         (DeprecatedPortTest):
2699         (DeprecatedPortTest.test_mac_port):
2700         (DeprecatedPortTest.test_gtk_port):
2701         (DeprecatedPortTest.test_qt_port):
2702         (DeprecatedPortTest.test_chromium_port):
2703         (DeprecatedPortTest.test_chromium_xvfb_port):
2704         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2705         (AbstractEarlyWarningSystem.__init__):
2706         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2707         * Scripts/webkitpy/tool/main.py:
2708         (WebKitPatch):
2709         (WebKitPatch.handle_global_options):
2710         * Scripts/webkitpy/tool/steps/abstractstep.py:
2711         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2712         (StepsTest.test_runtests_args):
2713
2714 2012-02-09  Jochen Eisinger  <jochen@chromium.org>
2715
2716         [chromium] always initialize makeArgs in buildChromiumNinja
2717         https://bugs.webkit.org/show_bug.cgi?id=78231
2718
2719         Reviewed by Tony Gentilcore.
2720
2721         * Scripts/webkitdirs.pm:
2722         (buildChromiumNinja):
2723
2724 2012-02-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2725
2726         [GTK] Show url of current hovered link in MiniBrowser
2727         https://bugs.webkit.org/show_bug.cgi?id=78098
2728
2729         Reviewed by Martin Robinson.
2730
2731         * MiniBrowser/gtk/BrowserWindow.c:
2732         (webViewMouseTargetChanged): Check whether hit test result is a
2733         link and use the url to update the status bar text.
2734         (browserWindowConstructed): Connect to
2735         WebKitWebView::mouse-target-changed signal.
2736
2737 2012-02-09  Rob Buis  <rbuis@rim.com>
2738
2739         [BlackBerry] Upstream DumpRenderTreeBlackBerry
2740         https://bugs.webkit.org/show_bug.cgi?id=78042
2741
2742         Reviewed by Antonio Gomes.
2743
2744         Upstream final part of our DRT implementation.
2745
2746         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp: Added.
2747         * DumpRenderTree/blackberry/PNGImageEncoder.cpp: Added.
2748         * DumpRenderTree/blackberry/PNGImageEncoder.h: Added.
2749         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp: Added.
2750         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h: Added.
2751
2752 2012-02-09  Ryosuke Niwa  <rniwa@webkit.org>
2753
2754         kill-old-processes should kill gcc and clang
2755         https://bugs.webkit.org/show_bug.cgi?id=78189
2756
2757         Reviewed by Eric Seidel.
2758
2759         Added a bunch of processes names of gcc and clang to the list.
2760
2761         * BuildSlaveSupport/kill-old-processes:
2762
2763 2012-02-07  MORITA Hajime  <morrita@google.com>
2764
2765         Replacement text should be available from the marker.
2766         https://bugs.webkit.org/show_bug.cgi?id=77934
2767
2768         Made the mock requestCheckingOfText() implementation to return
2769         a replacement text for each misspelled word if available.
2770
2771         Reviewed by Kent Tamura.
2772
2773         * DumpRenderTree/chromium/WebViewHost.cpp:
2774         (WebViewHost::finishLastTextCheck):
2775
2776 2012-02-08  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2777
2778         [Qt][DRT] DumpRenderTreeQt should support --no-timeout and --timeout options
2779         https://bugs.webkit.org/show_bug.cgi?id=78146
2780
2781         Reviewed by Ryosuke Niwa.
2782
2783         Our DumpRenderTree should support --no-timeout and --timeout options in order
2784         to be able to use run-perf-tests and have a Performance Bot.
2785         This patch adds setTimeout and setShouldTimeout functions to our LayoutTestController
2786         and the necessary code to handle such command line arguments to our DumpRenderTree.
2787
2788         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2789         (WebCore::DumpRenderTree::setTimeout):
2790         (WebCore):
2791         (WebCore::DumpRenderTree::setShouldTimeout):
2792         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2793         (DumpRenderTree):
2794         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2795         (LayoutTestController::LayoutTestController):
2796         (LayoutTestController::waitUntilDone):
2797         (LayoutTestController::notifyDone):
2798         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2799         (LayoutTestController::setTimeout):
2800         (LayoutTestController::setShouldTimeout):
2801         (LayoutTestController):
2802         * DumpRenderTree/qt/main.cpp:
2803         (isOption):
2804         (printUsage):
2805         (main):
2806
2807 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
2808
2809         Rubber-stamped by Martin Robinson.
2810
2811         * gtk/common.py:
2812         (get_build_path): Move test for current directory being a valid
2813         directory up so it takes precedence over WebKitBuild/Release and
2814         WebKitBuild/Debug when they exist as well.
2815
2816 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
2817
2818         [GTK] doc rebasing does not respect DESTDIR
2819         https://bugs.webkit.org/show_bug.cgi?id=78177
2820
2821         Reviewed by Martin Robinson.
2822
2823         * GNUmakefile.am: Pass DESTDIR on to generate-gtkdoc, when
2824         calling it for rebasing.
2825         * gtk/generate-gtkdoc:
2826         (get_common_options): Handle the new --virtual-root option.
2827         * gtk/gtkdoc.py:
2828         (GTKDoc.rebase_installed_docs): If a virtual-root has been given, pass
2829         it on to gtkdoc-rebase as dest-dir, and prefix the htmldir with it.
2830
2831 2012-02-08  Adam Barth  <abarth@webkit.org>
2832
2833         Remove Python 2.5 support from WebKit
2834         https://bugs.webkit.org/show_bug.cgi?id=71593
2835
2836         Reviewed by Eric Seidel.
2837
2838         This is the last vestige of our Python 2.5 support.
2839
2840         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2841         (AbstractQueueTest.test_log_from_script_error_for_upload):
2842
2843 2012-02-08  Adam Barth  <abarth@webkit.org>
2844
2845         version_check.py should inform users that we don't support Python 2.5 anymore
2846         https://bugs.webkit.org/show_bug.cgi?id=78179
2847
2848         Reviewed by Eric Seidel.
2849
2850         We don't support Python 2.5 anymore.
2851
2852         * Scripts/webkitpy/common/version_check.py:
2853
2854 2012-02-08  Adam Barth  <abarth@webkit.org>
2855
2856         test_configuration.py shouldn't re-implement itertools
2857         https://bugs.webkit.org/show_bug.cgi?id=78178
2858
2859         Reviewed by Eric Seidel.
2860
2861         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
2862         (TestConfigurationConverter.to_specifiers_list):
2863         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
2864         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
2865         (TestConfigurationConverter):
2866
2867 2012-02-08  Adam Barth  <abarth@webkit.org>
2868
2869         webkitpy should reply upon the multiprocessing package existing
2870         https://bugs.webkit.org/show_bug.cgi?id=78176
2871
2872         Reviewed by Eric Seidel.
2873
2874         Now that we don't support Python 2.5, this import can't fail.
2875
2876         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2877         (get):
2878         (_Process):
2879         (_Process.__init__):
2880         (_Process.run):
2881         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
2882         (FunctionTests.test_get__processes):
2883         (MultiProcessBrokerTests.setUp):
2884         * Scripts/webkitpy/layout_tests/port/base.py:
2885         (Port.__init__):
2886         (Port.default_worker_model):
2887         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2888         (ChromiumMacPort.check_build):
2889         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2890         (PortTestCase.test_default_worker_model):
2891         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2892
2893 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
2894
2895         Unreviewed typo fix that makes docs build again for the gtk2-based
2896         library.
2897
2898         * gtk/generate-gtkdoc:
2899
2900 2012-02-08  Adam Barth  <abarth@webkit.org>
2901
2902         Don't re-implement ZipFile.extractall
2903         https://bugs.webkit.org/show_bug.cgi?id=78173
2904
2905         Reviewed by Eric Seidel.
2906
2907         We can use ZipFile.extractall now that we don't support Python 2.5.
2908
2909         * Scripts/webkitpy/common/system/autoinstall.py:
2910         (AutoInstaller._extract_targz):
2911         (AutoInstaller._unzip):
2912
2913 2012-02-08  Adam Barth  <abarth@webkit.org>
2914
2915         Remove the ospath compat shim from webkitpy
2916         https://bugs.webkit.org/show_bug.cgi?id=78170
2917
2918         Reviewed by Eric Seidel.
2919
2920         We no longer need this compat shim now that we don't support Python 2.5.
2921
2922         * Scripts/webkitpy/common/checkout/scm/git.py:
2923         * Scripts/webkitpy/common/checkout/scm/svn.py:
2924         * Scripts/webkitpy/common/system/filesystem.py:
2925         (FileSystem.relpath):
2926         * Scripts/webkitpy/common/system/filesystem_mock.py:
2927         (MockFileSystem.relpath):
2928         * Scripts/webkitpy/common/system/ospath.py: Removed.
2929         * Scripts/webkitpy/common/system/ospath_unittest.py: Removed.
2930
2931 2012-02-08  Ryosuke Niwa  <rniwa@webkit.org>
2932
2933         Build fix attempt after r107053.
2934
2935         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2936         (test_collect_tests):
2937
2938 2012-02-08  Adam Barth  <abarth@webkit.org>
2939
2940         Remove simplejson because it's no longer used by webkitpy
2941         https://bugs.webkit.org/show_bug.cgi?id=78164
2942
2943         Reviewed by Eric Seidel.
2944
2945         All the importers of this code were removed in a previous patch.
2946
2947         * Scripts/webkitpy/thirdparty/simplejson: Removed.
2948         * Scripts/webkitpy/thirdparty/simplejson/LICENSE.txt: Removed.
2949         * Scripts/webkitpy/thirdparty/simplejson/README.txt: Removed.
2950         * Scripts/webkitpy/thirdparty/simplejson/__init__.py: Removed.
2951         * Scripts/webkitpy/thirdparty/simplejson/_speedups.c: Removed.
2952         * Scripts/webkitpy/thirdparty/simplejson/decoder.py: Removed.
2953         * Scripts/webkitpy/thirdparty/simplejson/encoder.py: Removed.
2954         * Scripts/webkitpy/thirdparty/simplejson/jsonfilter.py: Removed.
2955         * Scripts/webkitpy/thirdparty/simplejson/ordered_dict.py: Removed.
2956         * Scripts/webkitpy/thirdparty/simplejson/scanner.py: Removed.
2957         * Scripts/webkitpy/thirdparty/simplejson/tool.py: Removed.
2958
2959 2012-02-08  Adam Barth  <abarth@webkit.org>
2960
2961         webkitpy still imports simplejson
2962         https://bugs.webkit.org/show_bug.cgi?id=78161
2963
2964         Reviewed by Eric Seidel.
2965
2966         We no longer support Python 2.5, so we can rely upon Python's built-in
2967         JSON package.
2968
2969         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2970         * Scripts/webkitpy/common/net/resultsjsonparser.py:
2971         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py:
2972         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2973         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2974         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2975         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2976         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2977         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2978         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2979         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
2980
2981 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
2982
2983         [GTK] Fails to build docs with non-standard build directories
2984         https://bugs.webkit.org/show_bug.cgi?id=78118
2985
2986         * gtk/common.py:
2987         (get_build_path): add comment to document changes done in r107098,
2988         as requested by the reviewer and forgotten by me.
2989
2990 2012-02-08  Adam Barth  <abarth@webkit.org>
2991
2992         Stop importing with_statement from the mysterious future
2993         https://bugs.webkit.org/show_bug.cgi?id=78156
2994
2995         Reviewed by Eric Seidel.
2996
2997         The future is now!  (Well, at least 2008, when Python 2.6 was released,
2998         is no longer the __future__.)
2999
3000         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3001         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3002         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3003         * Scripts/webkitpy/common/net/credentials_unittest.py:
3004         * Scripts/webkitpy/common/net/file_uploader.py:
3005         * Scripts/webkitpy/common/newstringio_unittest.py:
3006         * Scripts/webkitpy/common/system/autoinstall.py:
3007         * Scripts/webkitpy/common/system/crashlogs.py:
3008         * Scripts/webkitpy/common/system/fileset.py:
3009         * Scripts/webkitpy/common/system/filesystem.py:
3010         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3011         * Scripts/webkitpy/common/system/path.py:
3012         * Scripts/webkitpy/common/thread/threadedmessagequeue.py:
3013         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3014         * Scripts/webkitpy/layout_tests/port/base.py:
3015         (of):
3016         * Scripts/webkitpy/layout_tests/port/gtk.py:
3017         * Scripts/webkitpy/layout_tests/port/test.py:
3018         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3019         * Scripts/webkitpy/style/filereader_unittest.py:
3020         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3021         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
3022         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
3023         * Scripts/webkitpy/tool/commands/queues.py:
3024         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
3025         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
3026
3027 2012-02-08  Rob Buis  <rbuis@rim.com>
3028
3029         [BlackBerry] Upstream DumpRenderTreeBlackBerry
3030         https://bugs.webkit.org/show_bug.cgi?id=78042
3031
3032         Reviewed by Antonio Gomes.
3033
3034         Upstream more parts of our DRT implementation.
3035
3036         * DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp: Added.
3037         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp: Added.
3038         * DumpRenderTree/blackberry/EventSender.cpp: Added.
3039         * DumpRenderTree/blackberry/EventSender.h: Added.
3040         * DumpRenderTree/blackberry/GCControllerBlackBerry.cpp: Added.
3041         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp: Added.
3042
3043 2012-02-08  Dirk Pranke  <dpranke@chromium.org>
3044
3045         check-webkit-style failing with "Path does not exist."
3046         https://bugs.webkit.org/show_bug.cgi?id=77873
3047
3048         Reviewed by Ojan Vafai.
3049
3050         This change fixes the way the style checker determines which
3051         Port class to use for a given test_expectations.txt path; the
3052         previous version used a heuristic that didn't really work in the
3053         first place.
3054
3055         * Scripts/webkitpy/style/checkers/test_expectations.py:
3056         (TestExpectationsChecker._determine_port_from_expectations_path):
3057         (TestExpectationsChecker.__init__):
3058         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3059         (TestExpectationsTestCase._expect_port_for_expectations_path):
3060         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
3061
3062 2012-02-08  Fehér Zsolt  <feherzs@inf.u-szeged.hu>
3063
3064         nrwt: make --skip-pixel-test-if-no-baseline option
3065         https://bugs.webkit.org/show_bug.cgi?id=70484
3066
3067         Reviewed by Dirk Pranke.
3068
3069         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3070         (SingleTestRunner.__init__):
3071         (SingleTestRunner._should_fetch_expected_checksum):
3072         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3073         (Worker.handle_test_list):
3074         * Scripts/webkitpy/layout_tests/models/test_input.py:
3075         (TestInput.__init__):
3076         * Scripts/webkitpy/layout_tests/port/webkit.py:
3077         (WebKitDriver.cmd_line):
3078         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3079         (_set_up_derived_options):
3080         (parse_args):
3081         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3082         (MainTest.test_skip_pixel_test_if_no_baseline_option):
3083         * WebKitTestRunner/TestController.cpp:
3084         (WTR::TestController::TestController):
3085         (WTR::TestController::initialize):
3086         (WTR::TestController::runTest):
3087         * WebKitTestRunner/TestController.h:
3088         (TestController):
3089         * WebKitTestRunner/TestInvocation.cpp:
3090         (WTR::TestInvocation::TestInvocation):
3091         (WTR::TestInvocation::setIsPixelTest):
3092         * WebKitTestRunner/TestInvocation.h:
3093         (WTR::TestInvocation::setSkipPixelTestOption):
3094         (TestInvocation):
3095
3096 2012-02-08  Rob Buis  <rbuis@rim.com>
3097
3098         [BlackBerry] Upstream DumpRenderTreeBlackBerry
3099         https://bugs.webkit.org/show_bug.cgi?id=78042
3100
3101         Reviewed by Antonio Gomes.
3102
3103         Add implementation for our DumpRenderTree solution.
3104
3105         * DumpRenderTree/blackberry/DumpRenderTree.cpp: Added.
3106         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h: Added.
3107
3108 2012-02-08  Antti Koivisto  <antti@apple.com>
3109
3110         REGRESSION (r106681): Null check missing in [WebFrame(WebInternal) _typingStyle]
3111         https://bugs.webkit.org/show_bug.cgi?id=78080
3112
3113         Reviewed by Andreas Kling, Darin Adler and Dan Bernstein.
3114         
3115         Add API test.
3116
3117         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3118         * TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: Added.
3119         (TestWebKitAPI):
3120         (TestWebKitAPI::TEST):
3121
3122 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
3123
3124         [GTK] Fails to build docs with non-standard build directories
3125         https://bugs.webkit.org/show_bug.cgi?id=78118
3126
3127         Reviewed by Martin Robinson.
3128
3129         * gtk/common.py:
3130         (get_build_path): also try the current directory as a valid build
3131         dir, which makes non-standard build directories such as build-2.0
3132         and build-3.0 work
3133
3134 2012-02-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3135
3136         [GTK] Open links in a new window when clicking with the middle button in MiniBrowser
3137         https://bugs.webkit.org/show_bug.cgi?id=78099
3138
3139         Reviewed by Martin Robinson.
3140
3141         * MiniBrowser/gtk/BrowserWindow.c:
3142         (webViewDecidePolicy): Check whether it's a link clicked with the
3143         middle mouse button and load the request in a new window.
3144         (browserWindowConstructed): Connect to
3145         WebKitWebView::decide-policy signal.
3146
3147 2012-02-08  Ryosuke Niwa  <rniwa@webkit.org>
3148
3149         Revert a part of the change in r106687 as a build fix.
3150
3151         Since Chromium port doesn't checkout the entire WebKit trunk,
3152         we can't run "svn info" on webkit_base.
3153
3154         * Scripts/webkitpy/layout_tests/port/base.py:
3155         (Port.repository_paths):
3156
3157 2012-02-07  Ryosuke Niwa  <rniwa@webkit.org>
3158
3159         run-perf-tests doesn't recognize paths that start with PerformanceTests
3160         https://bugs.webkit.org/show_bug.cgi?id=78012
3161
3162         Reviewed by Adam Barth.
3163
3164         Use resolve paths using filesystem.relpath before passing it to find_files.find.
3165
3166         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3167         (PerfTestsRunner):
3168         (PerfTestsRunner._collect_tests):
3169         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3170         (test_collect_tests):
3171         (test_collect_tests.add_file):
3172
3173 2012-02-07  Justin Novosad  <junov@chromium.org>
3174
3175         [Chromium] add option for 2d canvas defered rendering to DumpRenderTree
3176         https://bugs.webkit.org/show_bug.cgi?id=78039
3177
3178         Reviewed by Stephen White.
3179
3180         Adding the --enable-deferred-2d-canvas switch to DumpRenderTree
3181
3182         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3183         (main):
3184         * DumpRenderTree/chromium/TestShell.cpp:
3185         (TestShell::TestShell):
3186         (TestShell::resetWebSettings):
3187         (TestShell::runFileTest):
3188         * DumpRenderTree/chromium/TestShell.h:
3189         (TestShell::setDeferred2dCanvasEnabled):
3190         (TestShell):
3191         * DumpRenderTree/chromium/WebPreferences.cpp:
3192         (WebPreferences::reset):
3193         (WebPreferences::applyTo):
3194         * DumpRenderTree/chromium/WebPreferences.h:
3195         (WebPreferences):
3196
3197 2012-02-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3198
3199         [CMAKE] Use *bin* and *lib* directories for executable and libraries.
3200         https://bugs.webkit.org/show_bug.cgi?id=77928
3201
3202         Reviewed by Daniel Bates.
3203
3204         CMake has used *Programs* directory for executable. In addition, shared libraries are being
3205         built in source directory. It is better to set common places in order to maintain executable
3206         and libraries. *bin* is for executable and *lib* is for library.
3207
3208         * DumpRenderTree/efl/CMakeLists.txt:
3209         * EWebLauncher/CMakeLists.txt:
3210         * Scripts/run-launcher:
3211         * Scripts/webkitdirs.pm:
3212         (jscProductDir):
3213         * Scripts/webkitpy/layout_tests/port/efl.py:
3214         (EflPort._path_to_driver):
3215         (EflPort._path_to_image_diff):
3216
3217 2012-02-07  Adam Klein  <adamk@chromium.org>
3218
3219         Add JSC support for delivering mutations when the outermost script context exits
3220         https://bugs.webkit.org/show_bug.cgi?id=70289
3221
3222         Reviewed by Eric Seidel.
3223
3224         * DumpRenderTree/mac/EventSendingController.mm: Add support for
3225         eventSender.scheduleAsynchronousKeyDown.
3226         (+[EventSendingController isSelectorExcludedFromWebScript:]):
3227         (+[EventSendingController webScriptNameForSelector:]):
3228         (-[EventSendingController keyDownWrapper:withModifiers:withLocation:]):
3229         (-[EventSendingController scheduleAsynchronousKeyDown:withModifiers:withLocation:]):
3230         * Scripts/build-webkit: Properly alphabetize --mutation-observers in the --help output.
3231
3232 2012-02-07  Chris Rogers  <crogers@google.com>
3233
3234         Add Chris Rogers to reviewers section
3235         https://bugs.webkit.org/show_bug.cgi?id=78016
3236
3237         Reviewed by Adam Barth.
3238
3239         * Scripts/webkitpy/common/config/committers.py:
3240
3241 2012-02-07  Nikolas Zimmermann  <nzimmermann@rim.com>
3242
3243         layoutTestController.display() is flaky for SVG tests
3244         https://bugs.webkit.org/show_bug.cgi?id=78021
3245
3246         Reviewed by Dan Bernstein.
3247
3248         Fix race condition in repaint rect tracking. When running a test using the repaint.js
3249         harness right after a test starting with "svg/W3C-SVG-1.1" the repaint test will fail,
3250         the gray overlay isn't contained in the pixel dump anymore. This is because of a specific
3251         hack that forces 480x360 instead of 800x600 pixel test dumps for any test starting with
3252         svg/W3C-SVG-1.1. The resizing of the web view was done when dumping the render tree, after
3253         the repaint test already run, thus invalidating the previously tracked repaint rects.
3254
3255         * DumpRenderTree/mac/DumpRenderTree.mm:
3256         (dump):
3257         (runTest):
3258
3259 2012-02-07  Hans Wennborg  <hans@chromium.org>
3260
3261         Chromium: remove WebSpeechInputResult::set
3262         https://bugs.webkit.org/show_bug.cgi?id=77977
3263
3264         Reviewed by Darin Fisher.
3265
3266         It was renamed to assign() in r106475.
3267
3268         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
3269         (makeRectResult):
3270
3271 2012-02-07  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
3272
3273         [Qt] Give emulated touch-point a radius
3274         https://bugs.webkit.org/show_bug.cgi?id=77985
3275         
3276         Increase the radius of touch-point and show the actual size of the touch point in the touch-point mockup.
3277
3278         Reviewed by Kenneth Rohde Christiansen.
3279
3280         * MiniBrowser/qt/BrowserWindow.cpp:
3281         (BrowserWindow::updateVisualMockTouchPoints):
3282         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3283         (MiniBrowserApplication::notify):
3284         * MiniBrowser/qt/qml/MockTouchPoint.qml:
3285
3286 2012-02-07  Mario Sanchez Prada  <msanchez@igalia.com>
3287
3288         [GTK] Include gdk-pixbuf in the jhbuild modules
3289         https://bugs.webkit.org/show_bug.cgi?id=77980
3290
3291         Reviewed by Gustavo Noronha Silva.
3292
3293         * gtk/jhbuild.modules: Add gdk-pixbuf to the jhbuild moduleset.
3294
3295 2012-02-07  Simon Hausmann  <simon.hausmann@nokia.com>
3296
3297         [Qt] Prevent early test termination with newer Qt 5
3298         https://bugs.webkit.org/show_bug.cgi?id=77945
3299
3300         Reviewed by Csaba Osztrogonác.
3301
3302         QTBUG-24120 tracks a regression in Qt that would make layout tests
3303         terminate early. This patch works around it in a Qt 4 + 5 safe manner
3304         by disabling the quitOnLastWindowClosed feature, which we don't want/need
3305         for DRT anyway.
3306
3307         * DumpRenderTree/qt/main.cpp:
3308         (main): Don't quit on last window closed.
3309
3310 2012-02-06  Martin Robinson  <mrobinson@igalia.com>
3311
3312         Fix some miscellaneous 'make dist' error for WebKitGTK+.
3313
3314         * MiniBrowser/gtk/GNUmakefile.am: The MiniBrowser generated
3315         files should not be distributed.
3316
3317 2012-02-02  Hajime Morrita  <morrita@chromium.org>
3318
3319         [PerformanceTests] Each Dromaeo test needs its landing html.
3320         https://bugs.webkit.org/show_bug.cgi?id=77504
3321
3322         Reviewed by Ryosuke Niwa.
3323
3324         Added an ignorable pattern which happens in some Dromaeo tests.
3325
3326         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3327         (PerfTestsRunner):
3328
3329 2012-02-06  Kalev Lember  <kalevlember@gmail.com>
3330
3331         [GTK] Add missing pango include dir to fix build
3332         https://bugs.webkit.org/show_bug.cgi?id=77832
3333
3334         Reviewed by Martin Robinson.
3335
3336         * GNUmakefile.am: Added $(PANGO_CFLAGS) to libWebCoreInternals_la_CPPFLAGS.
3337
3338 2012-02-06  Martin Robinson  <mrobinson@igalia.com>
3339
3340         [GTK] Fix remaining errors in GTK+ WebKit2 API
3341         https://bugs.webkit.org/show_bug.cgi?id=77890
3342
3343         Reviewed by Gustavo Noronha Silva.
3344
3345         Verify that WebKit2 GTK+ test files are not skipped during style checks.
3346         Skip soup_server_new when checking for NULL versus 0 usage.
3347
3348         * Scripts/webkitpy/style/checker_unittest.py:
3349         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
3350         * Scripts/webkitpy/style/checkers/cpp.py:
3351         (check_for_null):
3352
3353 2012-02-06  Eric Seidel  <eric@webkit.org>
3354
3355         webkit-patch apply-from-bug should be able to apply non-reviewed patches
3356         https://bugs.webkit.org/show_bug.cgi?id=77883
3357
3358         Reviewed by Adam Barth.
3359
3360         This is very helpful if you use bugzilla as a replacement for git-stash.
3361         Makes it simpler to re-apply the patch w/o having to look up the patch id.
3362
3363         * Scripts/webkitpy/tool/commands/download.py:
3364         (ProcessBugsMixin._fetch_list_of_patches_to_process):
3365         * Scripts/webkitpy/tool/commands/download_unittest.py:
3366         (DownloadCommandsTest.test_apply_from_bug):
3367
3368 2012-02-06  Philippe Normand  <pnormand@igalia.com>
3369
3370         [webkitpy] cpp style-checker complains about readability/naming in GStreamer elements source files
3371         https://bugs.webkit.org/show_bug.cgi?id=77866
3372
3373         Reviewed by Martin Robinson.
3374
3375         * Scripts/webkitpy/style/checker.py: Ignore readability/naming
3376         errors in some gstreamer source code files defining new GStreamer elements.
3377         * Scripts/webkitpy/style/checker_unittest.py:
3378         (GlobalVariablesTest.test_path_rules_specifier):
3379
3380 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3381
3382         [GTK] Make sure html_dir exists before calling gtkdoc-rebase
3383         https://bugs.webkit.org/show_bug.cgi?id=77869
3384
3385         Reviewed by Philippe Normand.
3386
3387         * gtk/gtkdoc.py:
3388         (GTKDoc.rebase_installed_docs): Check html_dir exists.
3389
3390 2012-02-03  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3391
3392         [Qt] Don't version QtWebKit.experimental.
3393         https://bugs.webkit.org/show_bug.cgi?id=77739
3394
3395         Reviewed by Tor Arne Vestbø.
3396
3397         * MiniBrowser/qt/qml/BrowserWindow.qml:
3398
3399 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3400
3401         [GTK] Fix several gtkdoc-fixxref warnings
3402         https://bugs.webkit.org/show_bug.cgi?id=77613
3403
3404         Reviewed by Martin Robinson.
3405
3406         * gtk/generate-gtkdoc:
3407         (get_webkit1_options): Add webkitspellcheckerenchant.* to the list
3408         of ignored files, since it's private.
3409         * gtk/gtkdoc.py:
3410         (GTKDoc._ignored_files_basenames): Helper function that returns a
3411         string with the list of ignored files basenames separated by a
3412         spaces, as expected by several gtkdoc commands.
3413         (GTKDoc._run_gtkdoc_scan): Use _ignored_files_basenames for
3414         --ignore-headers option.
3415         (GTKDoc._run_gtkdoc_mkdb): Use _ignored_files_basenames for
3416         --ignore-files option.
3417
3418 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3419
3420         [GTK] Fix xrefs after installing API documentation
3421         https://bugs.webkit.org/show_bug.cgi?id=77551
3422
3423         Reviewed by Martin Robinson.
3424
3425         * GNUmakefile.am: Call generate-gtkdoc --rebase after installing
3426         api docs.
3427         * gtk/common.py:
3428         (prefix_of_pkg_config_file): Get the prefix variable of the given
3429         pkg-config file.
3430         (gtk_version_of_pkg_config_file): Get the gtk version required by
3431         the given pkg-config file.
3432         * gtk/generate-gtkdoc: Add --rebase command line option to rebase
3433         installed documentation.
3434         (get_gtkdoc_module_paths): Get paths where API doc is installed
3435         for the dependencies of the given pkg-config file.
3436         (get_common_xref_deps): Get API doc directories of dependencies
3437         common to WebKit1 and WebKit2.
3438         (get_webkit2_options): Add cross_reference_deps option.
3439         (get_webkit1_options): Ditto
3440         (rebase_installed_docs): Helper function to create a generator for
3441         the given pkg-config file and options and call rebase_installed_docs.
3442         * gtk/gtkdoc.py:
3443         (GTKDoc.__init__): Initialize cross_reference_deps.
3444         (GTKDoc._run_gtkdoc_fixxref): Add API doc directories of
3445         dependencies.
3446         (GTKDoc.rebase_installed_docs): Call gtkdoc-rebase to fix xref
3447         links of installed documentation.
3448         (PkgConfigGTKDoc.__init__): Get the prefix from the pkg-config
3449         file.
3450
3451 2012-02-06  Sergio Villar Senin  <svillar@igalia.com>
3452
3453         Incorrect statistics shown when running run-webkit-tests with --repeat-each or --iterations
3454         https://bugs.webkit.org/show_bug.cgi?id=77672
3455
3456         Reviewed by Dirk Pranke.
3457
3458         Test repetitions must be taken into account when working out
3459         the statistics shown by run-webkit-tests.
3460
3461         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3462         (Manager.prepare_lists_and_print_output):
3463         (Manager._print_result_summary):
3464         * Scripts/webkitpy/layout_tests/models/result_summary.py:
3465         (ResultSummary.__init__):
3466         (ResultSummary.add):
3467         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3468         (MainTest.test_repeat_each_iterations_num_tests):
3469
3470 2012-02-05  Dan Bernstein  <mitz@apple.com>
3471
3472         <rdar://problem/10809525> WebKit2’s WebFrameLoaderClient::shouldUseCredentialStorage() always returns true
3473         https://bugs.webkit.org/show_bug.cgi?id=77823
3474
3475         Reviewed by Anders Carlsson.
3476
3477         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3478         (WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.
3479
3480 2012-02-04  Dan Bernstein  <mitz@apple.com>
3481
3482         <rdar://problem/10660698> Clients cannot prevent caching of individual responses
3483         https://bugs.webkit.org/show_bug.cgi?id=77822
3484
3485         Reviewed by Sam Weinig.
3486
3487         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3488         (WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.
3489
3490 2012-02-04  Sam Weinig  <sam@webkit.org>
3491
3492         Add ability to send WKURLRequests in WebKit2 API user messages
3493         https://bugs.webkit.org/show_bug.cgi?id=77819
3494
3495         Reviewed by Anders Carlsson.
3496
3497         Add testing for round-tripping WKTypes from the UIProcess,
3498         to the WebProcess, and back.
3499
3500         - This commit adds a test fixture and tests for WKURLRequestRef, WKURLRef, and WKStringRef.
3501           More can easily be added.
3502
3503         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3504         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Added.
3505         (TestWebKitAPI):
3506         (WebKit2UserMessageRoundTripTest):
3507         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::WebKit2UserMessageRoundTripTest):
3508         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didReceiveMessageFromInjectedBundle):
3509         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didFinishLoadForFrame):
3510         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setInjectedBundleClient):
3511         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
3512         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp):
3513         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::roundTrip):
3514         (TestWebKitAPI::TEST_F):
3515         * TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp: Added.
3516         (TestWebKitAPI):
3517         (UserMessageTest):
3518         (TestWebKitAPI::UserMessageTest::UserMessageTest):
3519         (TestWebKitAPI::UserMessageTest::didReceiveMessage):
3520         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3521         (TestWebKitAPI::PlatformWebView::resizeTo):
3522         (TestWebKitAPI):
3523         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3524         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
3525
3526 2012-02-04  Dan Bernstein  <mitz@apple.com>
3527
3528         <rdar://problem/10772406> WKPreferences instances cannot be copied
3529         https://bugs.webkit.org/show_bug.cgi?id=77816
3530
3531         Reviewed by Sam Weinig.
3532
3533         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3534         (TestWebKitAPI::TEST):
3535
3536 2012-02-04  Adam Barth  <abarth@webkit.org>
3537
3538         garden-o-matic's All Failure tab should let you examine and rebaseline expected failures
3539         https://bugs.webkit.org/show_bug.cgi?id=77802
3540
3541         Reviewed by Eric Seidel.
3542
3543         This patch refactors our directory grouping code into base.js where it
3544         can be shared between failures.js and notifications.js.  It then adds
3545         an Examine action to each group of failures that triggers the "results"
3546         view.
3547
3548         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3549         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3550         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
3551         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3552         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3553         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
3554
3555 2012-02-04  Ojan Vafai  <ojan@chromium.org>
3556
3557         check-webkit-style is throwing an exception
3558         https://bugs.webkit.org/show_bug.cgi?id=77744
3559
3560         Reviewed by David Levin.
3561
3562         If the test_list is None, then we don't need to check for unsupported
3563         feature tests to skip.
3564
3565         * Scripts/webkitpy/layout_tests/port/webkit.py:
3566         (WebKitPort._has_test_in_directories):
3567         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3568         (test_skipped_tests_for_unsupported_features_empty_test_list):
3569
3570 2012-02-03  Adam Barth  <abarth@webkit.org>
3571
3572         List of all failures in garden-o-matic should actually list all the failures
3573         https://bugs.webkit.org/show_bug.cgi?id=77796
3574
3575         Reviewed by Eric Seidel.
3576
3577         This patch wires a bit more data into the new "All Failures" tab.  I've
3578         also iterated on how we enable this experimental feature.  The tab is
3579         still just a dumb list, but we'll make it smarter.
3580
3581         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3582         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
3583         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3584         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
3585
3586 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
3587
3588         Windows build fix after r106692.
3589
3590         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3591         (PortTest.test_reference_files):
3592
3593 2012-02-03  Beth Dakin  <bdakin@apple.com>
3594
3595         https://bugs.webkit.org/show_bug.cgi?id=77782
3596         WebPageProxy::didNewFirstVisuallyNonEmptyLayout should is called more than 
3597         once on some pages with frames
3598         -and corresponding-
3599         <rdar://problem/10798474>
3600
3601         Reviewed by Sam Weinig.
3602
3603         One new test.
3604         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3605         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp: Added.
3606         (TestWebKitAPI):
3607         (TestWebKitAPI::didForceRepaint):
3608         (TestWebKitAPI::didFinishLoadForFrame):
3609         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
3610         (TestWebKitAPI::setPageLoaderClient):
3611         (TestWebKitAPI::TEST):
3612         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp: Added.
3613         (TestWebKitAPI):
3614         (NewFirstVisuallyNonEmptyLayoutFramesTest):
3615         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::NewFirstVisuallyNonEmptyLayoutFramesTest):
3616         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage):
3617         * TestWebKitAPI/Tests/WebKit2/lots-of-iframes.html: Added.
3618
3619 2012-02-03  Dirk Pranke  <dpranke@chromium.org>
3620
3621         webkitpy: change exit() calls to sys.exit(), fix a leak in outputcapture
3622         https://bugs.webkit.org/show_bug.cgi?id=77781
3623
3624         Reviewed by Eric Seidel.
3625
3626         This change fixes a couple of issues discovered while debugging
3627         test-webkitpy; both calling exit() instead of sys.exit() --
3628         which is discouraged in program code instead of the interpreter
3629         -- and a particular usage of outputcapture were stdin to get whacked
3630         and preventing debugging.
3631        
3632         This change introduces a couple of common _exit() methods that
3633         will standardize how webkit-patch exit's, in case we need to do
3634         something different in the future.
3635
3636         * Scripts/webkitpy/common/system/deprecated_logging.py:
3637         (error):
3638         * Scripts/webkitpy/common/system/outputcapture.py:
3639         (OutputCapture.assert_outputs):
3640         * Scripts/webkitpy/tool/bot/queueengine.py:
3641         (QueueEngine.exit_after_handled_error):
3642         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
3643         (AbstractSequencedCommand.execute):
3644         * Scripts/webkitpy/tool/commands/queues.py:
3645         (StyleQueue.handle_script_error):
3646         * Scripts/webkitpy/tool/commands/upload.py:
3647         (MarkBugFixed.execute):
3648         * Scripts/webkitpy/tool/multicommandtool.py:
3649         (Command._exit):
3650         * Scripts/webkitpy/tool/steps/abstractstep.py:
3651         (AbstractStep._exit):
3652         * Scripts/webkitpy/tool/steps/checkstyle.py:
3653         (CheckStyle.run):
3654         * Scripts/webkitpy/tool/steps/commit.py:
3655         (Commit._check_test_expectations):
3656         * Scripts/webkitpy/tool/steps/confirmdiff.py:
3657         (ConfirmDiff.run):
3658
3659 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
3660
3661         Perf bot build fix.
3662
3663         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3664         (PerfTestsRunner._generate_json):
3665
3666 2012-02-03  Adam Barth  <abarth@webkit.org>
3667
3668         Add a blank "Expected Failures" tab to garden-o-matic
3669         https://bugs.webkit.org/show_bug.cgi?id=77793
3670
3671         Reviewed by Eric Seidel.
3672
3673         This tab will help us explore and manage our expected failures.  The
3674         tab is hidden by default via a new "experimental features" flag.
3675
3676         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3677         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
3678         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3679         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
3680         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
3681         (#unexpected):
3682         (#onebar.partytime #unexpected):
3683
3684 2012-02-03  Lucas Forschler  <lforschler@apple.com>
3685
3686         update-webkit-support-libraries is broken with the change from http to https on developer.apple.com
3687         https://bugs.webkit.org/show_bug.cgi?id=77785
3688
3689         Fix the build bots.
3690         
3691         Pass the -k and --sslv3 keys to make curl work with https on https://developer.apple.com
3692
3693         * Scripts/update-webkit-support-libs:
3694         (downloadExpectedVersionNumber):
3695
3696 2012-02-03  Lucas Forschler  <lforschler@apple.com>
3697
3698         Add a Mac Lion Performance bot.
3699         https://bugs.webkit.org/show_bug.cgi?id=77765
3700
3701         Reviewed by Adam Roben.
3702
3703         This will update the master configuration in the following ways:
3704             Add a new performance slave (apple-xseve-11)
3705             Add a new Factory to download a build and run perf tests.
3706             
3707         * BuildSlaveSupport/build.webkit.org-config/config.json:
3708         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3709         (DownloadAndPerfTestFactory):
3710         (DownloadAndPerfTestFactory.__init__):
3711
3712 2012-02-03  Dirk Pranke  <dpranke@chromium.org>
3713
3714         Extra TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk in repository
3715         https://bugs.webkit.org/show_bug.cgi?id=77752
3716
3717         Reviewed by James Robinson.
3718
3719         Delete unneeded file accidentally checked in in r106481.
3720
3721         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk: Removed.
3722
3723 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
3724
3725         Ref Tests should support plain SVG files
3726         https://bugs.webkit.org/show_bug.cgi?id=77685
3727
3728         Reviewed by Tony Chang.
3729
3730         Don't assume reference files always use .html as the extension.
3731         Instead, use the list of supported extension to look for -expected.* and -mismatch.*
3732
3733         Also fix various bugs in MockFileSystem and TestPort.
3734
3735         * Scripts/webkitpy/common/system/filesystem_mock.py:
3736         (MockFileSystem.isdir):
3737         * Scripts/webkitpy/layout_tests/port/base.py:
3738         (Port.reference_files):
3739         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3740         (PortTest.test_is_test_file):
3741         (PortTest.test_reference_files):
3742         * Scripts/webkitpy/layout_tests/port/test.py:
3743         (TestInstance.__init__):
3744
3745 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
3746
3747         perf-o-matic should store chromium svn revision
3748         https://bugs.webkit.org/show_bug.cgi?id=77725
3749
3750         Reviewed by Dirk Pranke.
3751
3752         Report both WebKit and Chromium revisions to the graph server. Renamed test_repository_paths to
3753         repository_paths since it's nothing to do with tests. Also refactored scm so that head_svn_revision
3754         is implemented in terms of newly added svn_revision.
3755
3756         * Scripts/webkitpy/common/checkout/scm/git.py:
3757         (Git.svn_revision):
3758         * Scripts/webkitpy/common/checkout/scm/scm.py:
3759         (SCM.head_svn_revision):
3760         (SCM):
3761         (SCM.svn_revision):
3762         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3763         (MockSCM.svn_revision):
3764         * Scripts/webkitpy/common/checkout/scm/svn.py:
3765         (SVN.svn_revision):
3766         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3767         (JSONLayoutResultsGenerator.__init__):
3768         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3769         (JSONResultsGeneratorBase._insert_generic_metadata):
3770         * Scripts/webkitpy/layout_tests/port/base.py:
3771         (Port.repository_paths):
3772         * Scripts/webkitpy/layout_tests/port/chromium.py:
3773         (ChromiumPort.repository_paths):
3774         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3775         (PerfTestsRunner._generate_json):
3776         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3777         (test_run_test_set_with_json_output):
3778         (test_run_test_set_with_json_source):
3779         (test_run_test_set_with_multiple_repositories):
3780
3781 2012-02-03  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3782
3783         [Qt] Split QQuickWebViewPrivate in two classes, for desktop and touch behavior.
3784         https://bugs.webkit.org/show_bug.cgi?id=77632
3785
3786         Reviewed by Kenneth Rohde Christiansen.
3787
3788         * MiniBrowser/qt/BrowserWindow.cpp:
3789         (BrowserWindow::BrowserWindow):
3790         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3791         (MiniBrowserApplication::sendTouchEvent):
3792         (MiniBrowserApplication::handleUserOptions):
3793         * MiniBrowser/qt/MiniBrowserApplication.h:
3794         (WindowOptions):
3795         (WindowOptions::WindowOptions):
3796         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3797         (WTR::PlatformWebView::PlatformWebView):
3798         * WebKitTestRunner/qt/main.cpp:
3799         (main):
3800         * qmake/mkspecs/features/default_post.prf:
3801
3802 2012-02-03  Simon Hausmann  <simon.hausmann@nokia.com>
3803
3804         [Qt] Replace GNU linker script for exports with export macros in WTF/JSC
3805         https://bugs.webkit.org/show_bug.cgi?id=77723
3806
3807         Reviewed by Tor Arne Vestbø.
3808
3809         * Tools.pro: Compile WTR again on all platforms with WK2.
3810
3811 2012-02-03  Sriram Neelakandan  <sriram.neelakandan@gmail.com>
3812
3813         Ensure that inspector disabled build works
3814         https://bugs.webkit.org/show_bug.cgi?id=77604
3815
3816         Reviewed by Tor Arne Vestbø.
3817
3818         * qmake/mkspecs/features/features.prf:
3819
3820 2012-02-02  Jochen Eisinger  <jochen@chromium.org>
3821
3822         [chromium] add support for --makeargs to the ninja-based build
3823         https://bugs.webkit.org/show_bug.cgi?id=77688
3824
3825         Reviewed by Adam Barth.
3826
3827         * Scripts/webkitdirs.pm:
3828         (buildChromiumNinja):
3829
3830 2012-02-02  Eric Seidel  <eric@webkit.org>
3831
3832         Run tests in serial on SnowLeopard to avoid CFURLCache crashes
3833         https://bugs.webkit.org/show_bug.cgi?id=75145
3834
3835         Reviewed by Dirk Pranke.
3836
3837         * Scripts/webkitpy/layout_tests/port/mac.py:
3838         (MacPort.default_child_processes):
3839         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3840         (test_operating_system):
3841         (test_default_child_processes):
3842
3843 2012-02-02  Dirk Pranke  <dpranke@chromium.org>
3844
3845        nrwt shouldn't blow up when there are errors in test_expectations.txt
3846        https://bugs.webkit.org/show_bug.cgi?id=73603
3847
3848        Reviewed by Ojan Vafai.
3849
3850        This change removes the distinction between 'errors' and 'warnings'
3851        in the test expectations parser. Now, any problem is a
3852        'warning', and if we are linting the file, warnings become fatal (errors).
3853
3854         This will allow a normal run-webkit-tests run to proceed even if
3855         there are bad lines.
3856
3857         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3858         (ParseError.__init__):
3859         (ParseError.__str__):
3860         (ParseError.__repr__):
3861         (TestExpectationSerializer.to_string):
3862         (TestExpectationParser._parse_modifiers):
3863         (TestExpectationParser._parse_expectations):
3864         (TestExpectationParser._check_modifiers_against_expectations):
3865         (TestExpectationParser._tokenize):
3866         (TestExpectationLine.__init__):
3867         (TestExpectationLine.is_invalid):
3868         (TestExpectationsModel.add_expectation_line):
3869         (TestExpectationsModel._already_seen_better_match):
3870         (TestExpectations.__init__):
3871         (TestExpectations._report_warnings):
3872         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
3873         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3874         (assert_bad_expectations):
3875         (test_parse_warning):
3876         (test_overrides__duplicate):
3877         (ExpectationSyntaxTests.test_missing_expectation):
3878         (ExpectationSyntaxTests.test_missing_colon):
3879         (ExpectationSyntaxTests.test_too_many_colons):
3880         (ExpectationSyntaxTests.test_too_many_equals_signs):
3881         (ExpectationSyntaxTests.test_unrecognized_expectation):
3882         (SemanticTests.test_bug_format):
3883         (SemanticTests.test_bad_bugid):
3884         (SemanticTests.test_slow_and_timeout):
3885         (test_ambiguous):
3886         (test_more_modifiers):
3887         (test_order_in_file):
3888         (test_macro_overrides):
3889         (RebaseliningTest.assertRemove):
3890         (TestExpectationParserTests.test_tokenize_blank):
3891         (TestExpectationParserTests.test_tokenize_missing_colon):
3892         (TestExpectationParserTests.test_tokenize_extra_colon):
3893         (TestExpectationParserTests.test_tokenize_empty_comment):
3894         (TestExpectationParserTests.test_tokenize_comment):
3895         (TestExpectationParserTests.test_tokenize_missing_equal):
3896         (TestExpectationParserTests.test_tokenize_extra_equal):
3897         (TestExpectationParserTests.test_tokenize_valid):
3898         (TestExpectationParserTests.test_tokenize_valid_with_comment):
3899         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
3900         (TestExpectationSerializerTests.test_unparsed_to_string):
3901         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3902         (lint):
3903         * Scripts/webkitpy/style/checkers/test_expectations.py:
3904         (TestExpectationsChecker.check_test_expectations):
3905
3906 2012-02-02  Sheriff Bot  <webkit.review.bot@gmail.com>
3907
3908         Unreviewed, rolling out r106543.
3909         http://trac.webkit.org/changeset/106543
3910         https://bugs.webkit.org/show_bug.cgi?id=77671
3911
3912         Made tests less stable (Requested by rniwa on #webkit).
3913
3914         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3915         (PerfTestsRunner):
3916         (PerfTestsRunner.__init__):
3917         (PerfTestsRunner._run_tests_set):
3918         (PerfTestsRunner._run_single_test):
3919         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3920         (MainTest.TestDriver.run_test):
3921         (run_test):
3922
3923 2012-02-02  Beth Dakin  <bdakin@apple.com>
3924
3925         https://bugs.webkit.org/show_bug.cgi?id=77664
3926         Add API tests for didNewFirstVisuallyNonEmptyLayout
3927
3928         Reviewed by Darin Adler.
3929
3930         Two new tests.
3931         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3932         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp: Added.
3933         (TestWebKitAPI):
3934         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
3935         (TestWebKitAPI::setPageLoaderClient):
3936         (TestWebKitAPI::TEST):
3937         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp: Added.
3938         (TestWebKitAPI):
3939         (TestWebKitAPI::didForceRepaint):
3940         (TestWebKitAPI::didFinishLoadForFrame):
3941         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
3942         (TestWebKitAPI::setPageLoaderClient):
3943         (TestWebKitAPI::TEST):
3944         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp: Added.
3945         (TestWebKitAPI):
3946         (NewFirstVisuallyNonEmptyLayoutFailsTest):
3947         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::NewFirstVisuallyNonEmptyLayoutFailsTest):
3948         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage):
3949         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp: Added.
3950         (TestWebKitAPI):
3951         (NewFirstVisuallyNonEmptyLayoutTest):
3952         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::NewFirstVisuallyNonEmptyLayoutTest):
3953         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::didCreatePage):
3954
3955 2012-02-02  Michael Saboff  <msaboff@apple.com>
3956
3957         Add Michael Saboff to reviewers list.
3958
3959         Rubber-stamped by Gavin Barraclough.
3960
3961         * Scripts/webkitpy/common/config/committers.py:
3962
3963 2012-02-02  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3964
3965         Add myself as a committer
3966
3967         Unreviewed
3968
3969         * Scripts/webkitpy/common/config/committers.py:
3970
3971 2012-02-02  Ryosuke Niwa  <rniwa@webkit.org>
3972
3973         [PerformanceTests] tests have dependencies
3974         https://bugs.webkit.org/show_bug.cgi?id=77506
3975
3976         Reviewed by Hajime Morita.
3977
3978         Load an initialization page before each test after starting a DRT so that
3979         warming up DRT won't affect the performance test results.
3980
3981         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3982         (PerfTestsRunner):
3983         (PerfTestsRunner.__init__):
3984         (PerfTestsRunner._run_tests_set):
3985         (PerfTestsRunner._run_single_test):
3986         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3987         (MainTest.TestDriver.run_test):
3988         (test_initial_page_loaded):
3989         (test_initial_page_loaded.run_test):
3990
3991 2012-02-02  Ryosuke Niwa  <rniwa@webkit.org>
3992
3993         Re-land r106442 per Adam's suggestion. We'll do both restarting DRT and loading a fake test first.
3994
3995         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3996         (PerfTestsRunner._run_tests_set):
3997         (PerfTestsRunner._run_single_test):
3998         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3999         (create_runner):
4000         (test_run_passing_test):
4001         (test_run_silent_test):
4002         (test_run_failed_test):
4003         (test_run_tonguey_test):
4004         (test_run_timeout_test):
4005         (test_run_crash_test):
4006         (test_run_test_set_kills_drt_per_run):
4007         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
4008         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__):
4009         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):
4010
4011 2012-02-01  Jacob Goldstein  <jacobg@adobe.com>
4012
4013         Webkit generate-coverage-data script needs update to use new test script
4014         https://bugs.webkit.org/show_bug.cgi?id=77597
4015
4016         Reviewed by Dirk Schulze.
4017
4018         * Scripts/generate-coverage-data:
4019
4020 2012-02-01  Adam Barth  <abarth@webkit.org>
4021
4022         Update the tests to show that the mac-ews processes patches from
4023         non-committers.
4024
4025         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4026         (EarlyWarningSytemTest.test_committer_only_ewses):
4027         (EarlyWarningSytemTest.test_builder_ewses):
4028
4029 2012-02-01  Adam Barth  <abarth@webkit.org>
4030
4031         Mac-ews logs are huge
4032         https://bugs.webkit.org/show_bug.cgi?id=77045
4033
4034         Reviewed by Eric Seidel.
4035
4036         In order to get the cr-linux-ews bot to run tests on EC2, we created
4037         the chromium-xvfb port, which contained a number of tweaks to the
4038         Chromium port's behavior.  This patch refactors those tweaks so they
4039         can be shared with the mac-ews, mostly by moving them into the
4040         non-interactive mode of RunTests.
4041
4042         * Scripts/webkitpy/common/config/ports.py:
4043         (WebKitPort):
4044         (WebKitPort.layout_tests_results_path):
4045         (ChromiumPort.run_javascriptcore_tests_command):
4046         (ChromiumXVFBPort):
4047         (ChromiumXVFBPort.run_webkit_tests_command):
4048         * Scripts/webkitpy/common/config/ports_mock.py:
4049         (MockPort):
4050         (MockPort.layout_tests_results_path):
4051         * Scripts/webkitpy/common/config/ports_unittest.py:
4052         (WebKitPortTest.test_chromium_xvfb_port):
4053         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
4054         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
4055         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4056         (CommitQueueTest.test_commit_queue):
4057         (test_rollout):
4058         (test_manual_reject_during_processing):
4059         * Scripts/webkitpy/tool/steps/runtests.py:
4060         (RunTests.run):
4061         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
4062         (RunTestsTest.test_no_unit_tests):
4063         * Scripts/webkitpy/tool/steps/steps_unittest.py:
4064         (StepsTest.test_runtests_args):
4065
4066 2012-02-01  Ryosuke Niwa  <rniwa@webkit.org>
4067
4068         Roll out r106442. It made some tests more stable but others less stable.
4069
4070         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4071         (PerfTestsRunner._run_tests_set):
4072         (PerfTestsRunner._run_single_test):
4073         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
4074         (create_runner):
4075         (test_run_passing_test):
4076         (test_run_silent_test):
4077         (test_run_failed_test):
4078         (test_run_tonguey_test):
4079         (test_run_timeout_test):
4080         (test_run_crash_test):
4081         (test_run_test_set):
4082
4083 2012-02-01  Lucas Forschler  <lforschler@apple.com>
4084
4085         Enable EWS for non-contributers.
4086         https://bugs.webkit.org/show_bug.cgi?id=77576
4087         
4088         Reviewed by Adam Barth.
4089
4090         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4091         (MacEWS):
4092
4093 2012-02-01  Beth Dakin  <bdakin@apple.com>
4094
4095         https://bugs.webkit.org/show_bug.cgi?id=77383
4096         Add a different didFirstVisuallNonEmptyLayout heuristic to experiment with
4097         -and corresponding-
4098         <rdar://problem/10709560>
4099
4100         Reviewed by Sam Weinig.
4101
4102         WebKit2's WebLoaderClient has a temporary new function that must be accounted 
4103         for.
4104         * MiniBrowser/mac/BrowserWindowController.m:
4105         (-[BrowserWindowController awakeFromNib]):
4106         * WebKitTestRunner/TestController.cpp:
4107         (WTR::TestController::initialize):
4108
4109 2012-02-01  Dirk Pranke  <dpranke@chromium.org>
4110
4111         TestWebKitAPI isn't being built on chromium bots any more
4112         https://bugs.webkit.org/show_bug.cgi?id=77563
4113
4114         Reviewed by Dimitri Glazkov.
4115
4116         I accidentally dropped it in the refactoring in r105449.
4117
4118         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Added.
4119
4120 2012-02-01  Hans Wennborg  <hans@chromium.org>
4121
4122         Rename WebSpeechInputResult::set() to assign()
4123         https://bugs.webkit.org/show_bug.cgi?id=77540
4124
4125         Reviewed by Darin Fisher.
4126
4127         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
4128         (MockWebSpeechInputController::addMockRecognitionResult):
4129         (MockWebSpeechInputController::speechTaskFired):
4130
4131 2012-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
4132
4133         [GTK] WebKit1 API documentation is not generated when building with gtk-2.0
4134         https://bugs.webkit.org/show_bug.cgi?id=77542
4135
4136         Reviewed by Martin Robinson.
4137
4138         * gtk/generate-gtkdoc: Check first whether there's
4139         webkitgtk-3.0.pc and if it doesn't exist use webkitgtk-1.0.pc
4140         instead.
4141         (get_webkit2_options): Return just the options since the
4142         pkg_config_path doesn't depend on options
4143         (get_webkit1_options): Ditto.
4144         (generate_doc): Helper function to create a generator and generate
4145         documentation for the given pkg-config file with the given options.
4146         * gtk/gtkdoc.py:
4147         (GTKDoc.__init__): Don't use ** for args parameter, since it's
4148         used as a dict and never expanded.
4149         (PkgConfigGTKDoc.__init__): Ditto.
4150
4151 2012-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
4152
4153         [GTK] API documentation is not installed even when building with --enable-gtk-doc
4154         https://bugs.webkit.org/show_bug.cgi?id=77094
4155
4156         Reviewed by Martin Robinson.
4157
4158         * GNUmakefile.am: Add install-data-local and uninstall-local rules
4159         to install/uninstall WebKit1 and WebKit2 API documentation.
4160
4161 2012-02-01  Sheriff Bot  <webkit.review.bot@gmail.com>
4162
4163         Unreviewed, rolling out r106460.
4164         http://trac.webkit.org/changeset/106460
4165         https://bugs.webkit.org/show_bug.cgi?id=77552
4166
4167         It break unit tests if WEBKIT_TESTFONTS isn't defined.
4168         (Requested by Ossy on #webkit).
4169
4170         * Scripts/webkitpy/layout_tests/port/qt.py:
4171
4172 2012-02-01  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
4173
4174         [Qt] Automatic clean build feature always do clean build with --no-webkit2
4175         https://bugs.webkit.org/show_bug.cgi?id=74519
4176
4177         Reviewed by Tor Arne Vestbø.
4178
4179         Set the PLUGIN_ARCHITECTURE_UNSUPPORTED define always.
4180
4181         * qmake/mkspecs/features/features.prf:
4182
4183 2012-02-01  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
4184
4185         [Qt][WK2] run-webkit-tests --qt  crashes if WEBKIT_TESTFONTS is not set
4186         https://bugs.webkit.org/show_bug.cgi?id=77466
4187
4188         Reviewed by Kenneth Rohde Christiansen.
4189
4190         Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS
4191         is set or if we should raise an error.
4192
4193         * Scripts/webkitpy/layout_tests/port/qt.py:
4194         (QtPort.setup_environ_for_server):
4195
4196 2012-02-01  Philippe Normand  <pnormand@igalia.com> and Sergio Villar Senin  <svillar@igalia.com>
4197
4198         Reviewed by Martin Robinson.
4199
4200         [GTK] Improve FrameLoader signals. Resource loading
4201         https://bugs.webkit.org/show_bug.cgi?id=49543
4202
4203         Support for the new loader signals in DRT.
4204
4205         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4206         (urlPath):
4207         (willSendRequestCallback):
4208         (urlSuitableForTestResult):
4209         (descriptionSuitableForTestResult):
4210         (didReceiveResponse):
4211         (didFinishLoading):
4212         (didFailLoadingWithError):
4213         (createWebView):
4214
4215 2012-02-01  Ryosuke Niwa  <rniwa@webkit.org>
4216
4217         run-perf-tests should restart DRT for each test
4218         https://bugs.webkit.org/show_bug.cgi?id=77506
4219
4220         Reviewed by Adam Barth.
4221
4222         Always restart DRT when running performance tests in order to minimize the dependency between tests.
4223
4224         * Scripts/webkitpy/layout_tests/port/chromium.py:
4225         (ChromiumDriver.stop):
4226         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4227         (PerfTestsRunner._run_tests_set):
4228         (PerfTestsRunner._run_single_test):
4229         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
4230         (create_runner):
4231         (test_run_passing_test):
4232         (test_run_silent_test):
4233         (test_run_failed_test):
4234         (test_run_tonguey_test):
4235         (test_run_timeout_test):
4236         (test_run_crash_test):
4237         (test_run_test_set_kills_drt_per_run):
4238         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
4239         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__):
4240         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):
4241
4242 2012-01-31  Hans Wennborg  <hans@chromium.org>
4243
4244         Speech Input: Report speech element rect relative to window rather than frame
4245         https://bugs.webkit.org/show_bug.cgi?id=76443
4246
4247         Reviewed by Darin Fisher.
4248
4249         Update LayoutTestController to allow for retrieving the speech
4250         element's position used in a request.
4251
4252         In Chromium this is handled by the MockWebSpeechInputController;
4253         adding stubs for the other implementations.
4254
4255         * DumpRenderTree/LayoutTestController.cpp:
4256         (setMockSpeechInputDumpRectCallback):
4257         (LayoutTestController::staticFunctions):
4258         * DumpRenderTree/LayoutTestController.h:
4259         (LayoutTestController):
4260         * DumpRenderTree/chromium/LayoutTestController.cpp:
4261         (LayoutTestController::LayoutTestController):
4262         (LayoutTestController::setMockSpeechInputDumpRect):
4263         * DumpRenderTree/chromium/LayoutTestController.h:
4264         (LayoutTestController):
4265         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
4266         (MockWebSpeechInputController::setDumpRect):
4267         (MockWebSpeechInputController::clearResults):
4268         (MockWebSpeechInputController::startRecognition):
4269         (MockWebSpeechInputController::MockWebSpeechInputController):
4270         (makeRectResult):
4271         (MockWebSpeechInputController::speechTaskFired):
4272         * DumpRenderTree/chromium/MockWebSpeechInputController.h:
4273         (MockWebSpeechInputController):
4274         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
4275         (LayoutTestController::setMockSpeechInputDumpRect):
4276         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4277         (LayoutTestController::setMockSpeechInputDumpRect):
4278         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4279         (LayoutTestController::setMockSpeechInputDumpRect):
4280         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4281         (LayoutTestController::setMockSpeechInputDumpRect):
4282         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4283         (LayoutTestController):
4284         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4285         (LayoutTestController::setMockSpeechInputDumpRect):
4286         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4287         (LayoutTestController::setMockSpeechInputDumpRect):
4288
4289 2012-01-31  Ryuan Choi  <ryuan.choi@samsung.com>
4290
4291         [EFL] Add basic DRT/Efl implementation to support viewport test.
4292         https://bugs.webkit.org/show_bug.cgi?id=77320
4293
4294         Reviewed by Andreas Kling.
4295
4296         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
4297         (LayoutTestController::dumpConfigurationForViewport): call dumpConfigurationForViewport().
4298
4299 2012-01-31  Alexey Proskuryakov  <ap@apple.com>
4300
4301         REGRESSION (WebKit2): event.keyCode is always zero when typing in Russian
4302         https://bugs.webkit.org/show_bug.cgi?id=77473
4303         <rdar://problem/10751357>
4304
4305         Reviewed by Darin Adler.
4306
4307         * DumpRenderTree/mac/EventSendingController.mm:
4308         (-[EventSendingController keyDown:withModifiers:withLocation:]):
4309         * WebKitTestRunner/mac/EventSenderProxy.mm:
4310         (WTR::EventSenderProxy::keyDown):
4311         Added a new special keyDown value to test this.
4312
4313 2012-01-31  Dirk Pranke  <dpranke@chromium.org>
4314
4315         nrwt: fix the mock port to work with DriverProxy, reftests
4316         https://bugs.webkit.org/show_bug.cgi?id=77170
4317
4318         Reviewed by Eric Seidel.
4319
4320         The DryrunPort used for benchmarking and testing NRWT has been
4321         broken since we added the DriverProxy code. It isn't really
4322         needed any more, so I've removed it.
4323
4324         The MockDRT port was also broken by DriverProxy, and moreover,
4325         never worked w/ reftests. Since we don't exercise this module in
4326         the unit tests, the code had also bitrotted some. I have cleaned
4327         it up and made it use DriverInput and DriverOutput for
4328         consistency.
4329
4330         * Scripts/webkitpy/layout_tests/port/dryrun.py:
4331         (DryRunPort.__init__):
4332         (DryRunPort):
4333         (DryRunPort.real_name):
4334         (DryRunPort.create_driver):
4335         (DryRunPort.driver_cmd_line):
4336         (DryRunPort._driver_class):
4337         (DryrunDriver):
4338         (DryrunDriver.run_test):
4339         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
4340         (MockDRTPort.create_driver):
4341         (MockChromiumDRT.run_one_test):
4342
4343 2012-01-31  Ojan Vafai  <ojan@chromium.org>
4344
4345         run-webkit-tests calls out to webkit-build-directory twice
4346         https://bugs.webkit.org/show_bug.cgi?id=77248
4347
4348         Reviewed by Dirk Pranke.
4349
4350         * Scripts/webkit-build-directory:
4351         If called with no arguments, print out both the top-level directory and the 
4352         configuration directory
4353
4354         * Scripts/webkitpy/layout_tests/port/config.py:
4355         (Config.build_directory):
4356         When called with no arguments, get and cache both the top-level and configuration directories.
4357
4358         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
4359         (main):
4360         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
4361         (ConfigTest.assert_configuration):
4362         (ConfigTest.test_build_directory.mock_webkit_build_directory):
4363         (ConfigTest.test_build_directory):
4364         (ConfigTest.test_default_configuration__notfound):
4365         * Scripts/webkitpy/layout_tests/port/webkit.py:
4366         (WebKitPort._build_path):
4367         Cache the build directory in the options object so that other users
4368         of the options object don't need to call out to webkit-build-directory.
4369         Also, properly support the existing --build-directory argument.
4370
4371 2012-01-31  Ryosuke Niwa  <rniwa@webkit.org>
4372
4373         Bump up the timeout for performance tests since DOM/DOMTable.html
4374         and Parser/html5-full-render.html are timing out on the bot.
4375
4376         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4377         (PerfTestsRunner._parse_args):
4378
4379 2012-01-31  Ehsan Akhgari  <ehsan.akhgari@gmail.com>
4380
4381         Fix the update_webgl_conformance_tests.py script in order to enable it
4382         to detect the SCM being used correctly.
4383         https://bugs.webkit.org/show_bug.cgi?id=77462
4384
4385         Reviewed by Kenneth Russell.
4386
4387         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
4388         (default_out_dir):
4389
4390 2012-01-31  Eric Seidel  <eric@webkit.org>
4391
4392         webkit-patch apply-from-bug should work regardless of your CWD
4393         https://bugs.webkit.org/show_bug.cgi?id=77482
4394
4395         Reviewed by Adam Barth.
4396
4397         webkit-patch only ever works with patches made from the root
4398         directory.  We should pass the CWD to svn-apply in the case