e2e034ee4b7febab9632df700996cec384a8a5e3
[WebKit-https.git] / Tools / ChangeLog
1 2012-02-03  Lucas Forschler  <lforschler@apple.com>
2
3         Add a Mac Lion Performance bot.
4         https://bugs.webkit.org/show_bug.cgi?id=77765
5
6         Reviewed by Adam Roben.
7
8         This will update the master configuration in the following ways:
9             Add a new performance slave (apple-xseve-11)
10             Add a new Factory to download a build and run perf tests.
11             
12         * BuildSlaveSupport/build.webkit.org-config/config.json:
13         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
14         (DownloadAndPerfTestFactory):
15         (DownloadAndPerfTestFactory.__init__):
16
17 2012-02-03  Dirk Pranke  <dpranke@chromium.org>
18
19         Extra TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk in repository
20         https://bugs.webkit.org/show_bug.cgi?id=77752
21
22         Reviewed by James Robinson.
23
24         Delete unneeded file accidentally checked in in r106481.
25
26         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk: Removed.
27
28 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
29
30         Ref Tests should support plain SVG files
31         https://bugs.webkit.org/show_bug.cgi?id=77685
32
33         Reviewed by Tony Chang.
34
35         Don't assume reference files always use .html as the extension.
36         Instead, use the list of supported extension to look for -expected.* and -mismatch.*
37
38         Also fix various bugs in MockFileSystem and TestPort.
39
40         * Scripts/webkitpy/common/system/filesystem_mock.py:
41         (MockFileSystem.isdir):
42         * Scripts/webkitpy/layout_tests/port/base.py:
43         (Port.reference_files):
44         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
45         (PortTest.test_is_test_file):
46         (PortTest.test_reference_files):
47         * Scripts/webkitpy/layout_tests/port/test.py:
48         (TestInstance.__init__):
49
50 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
51
52         perf-o-matic should store chromium svn revision
53         https://bugs.webkit.org/show_bug.cgi?id=77725
54
55         Reviewed by Dirk Pranke.
56
57         Report both WebKit and Chromium revisions to the graph server. Renamed test_repository_paths to
58         repository_paths since it's nothing to do with tests. Also refactored scm so that head_svn_revision
59         is implemented in terms of newly added svn_revision.
60
61         * Scripts/webkitpy/common/checkout/scm/git.py:
62         (Git.svn_revision):
63         * Scripts/webkitpy/common/checkout/scm/scm.py:
64         (SCM.head_svn_revision):
65         (SCM):
66         (SCM.svn_revision):
67         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
68         (MockSCM.svn_revision):
69         * Scripts/webkitpy/common/checkout/scm/svn.py:
70         (SVN.svn_revision):
71         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
72         (JSONLayoutResultsGenerator.__init__):
73         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
74         (JSONResultsGeneratorBase._insert_generic_metadata):
75         * Scripts/webkitpy/layout_tests/port/base.py:
76         (Port.repository_paths):
77         * Scripts/webkitpy/layout_tests/port/chromium.py:
78         (ChromiumPort.repository_paths):
79         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
80         (PerfTestsRunner._generate_json):
81         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
82         (test_run_test_set_with_json_output):
83         (test_run_test_set_with_json_source):
84         (test_run_test_set_with_multiple_repositories):
85
86 2012-02-03  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
87
88         [Qt] Split QQuickWebViewPrivate in two classes, for desktop and touch behavior.
89         https://bugs.webkit.org/show_bug.cgi?id=77632
90
91         Reviewed by Kenneth Rohde Christiansen.
92
93         * MiniBrowser/qt/BrowserWindow.cpp:
94         (BrowserWindow::BrowserWindow):
95         * MiniBrowser/qt/MiniBrowserApplication.cpp:
96         (MiniBrowserApplication::sendTouchEvent):
97         (MiniBrowserApplication::handleUserOptions):
98         * MiniBrowser/qt/MiniBrowserApplication.h:
99         (WindowOptions):
100         (WindowOptions::WindowOptions):
101         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
102         (WTR::PlatformWebView::PlatformWebView):
103         * WebKitTestRunner/qt/main.cpp:
104         (main):
105         * qmake/mkspecs/features/default_post.prf:
106
107 2012-02-03  Simon Hausmann  <simon.hausmann@nokia.com>
108
109         [Qt] Replace GNU linker script for exports with export macros in WTF/JSC
110         https://bugs.webkit.org/show_bug.cgi?id=77723
111
112         Reviewed by Tor Arne Vestbø.
113
114         * Tools.pro: Compile WTR again on all platforms with WK2.
115
116 2012-02-03  Sriram Neelakandan  <sriram.neelakandan@gmail.com>
117
118         Ensure that inspector disabled build works
119         https://bugs.webkit.org/show_bug.cgi?id=77604
120
121         Reviewed by Tor Arne Vestbø.
122
123         * qmake/mkspecs/features/features.prf:
124
125 2012-02-02  Jochen Eisinger  <jochen@chromium.org>
126
127         [chromium] add support for --makeargs to the ninja-based build
128         https://bugs.webkit.org/show_bug.cgi?id=77688
129
130         Reviewed by Adam Barth.
131
132         * Scripts/webkitdirs.pm:
133         (buildChromiumNinja):
134
135 2012-02-02  Eric Seidel  <eric@webkit.org>
136
137         Run tests in serial on SnowLeopard to avoid CFURLCache crashes
138         https://bugs.webkit.org/show_bug.cgi?id=75145
139
140         Reviewed by Dirk Pranke.
141
142         * Scripts/webkitpy/layout_tests/port/mac.py:
143         (MacPort.default_child_processes):
144         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
145         (test_operating_system):
146         (test_default_child_processes):
147
148 2012-02-02  Dirk Pranke  <dpranke@chromium.org>
149
150        nrwt shouldn't blow up when there are errors in test_expectations.txt
151        https://bugs.webkit.org/show_bug.cgi?id=73603
152
153        Reviewed by Ojan Vafai.
154
155        This change removes the distinction between 'errors' and 'warnings'
156        in the test expectations parser. Now, any problem is a
157        'warning', and if we are linting the file, warnings become fatal (errors).
158
159         This will allow a normal run-webkit-tests run to proceed even if
160         there are bad lines.
161
162         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
163         (ParseError.__init__):
164         (ParseError.__str__):
165         (ParseError.__repr__):
166         (TestExpectationSerializer.to_string):
167         (TestExpectationParser._parse_modifiers):
168         (TestExpectationParser._parse_expectations):
169         (TestExpectationParser._check_modifiers_against_expectations):
170         (TestExpectationParser._tokenize):
171         (TestExpectationLine.__init__):
172         (TestExpectationLine.is_invalid):
173         (TestExpectationsModel.add_expectation_line):
174         (TestExpectationsModel._already_seen_better_match):
175         (TestExpectations.__init__):
176         (TestExpectations._report_warnings):
177         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
178         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
179         (assert_bad_expectations):
180         (test_parse_warning):
181         (test_overrides__duplicate):
182         (ExpectationSyntaxTests.test_missing_expectation):
183         (ExpectationSyntaxTests.test_missing_colon):
184         (ExpectationSyntaxTests.test_too_many_colons):
185         (ExpectationSyntaxTests.test_too_many_equals_signs):
186         (ExpectationSyntaxTests.test_unrecognized_expectation):
187         (SemanticTests.test_bug_format):
188         (SemanticTests.test_bad_bugid):
189         (SemanticTests.test_slow_and_timeout):
190         (test_ambiguous):
191         (test_more_modifiers):
192         (test_order_in_file):
193         (test_macro_overrides):
194         (RebaseliningTest.assertRemove):
195         (TestExpectationParserTests.test_tokenize_blank):
196         (TestExpectationParserTests.test_tokenize_missing_colon):
197         (TestExpectationParserTests.test_tokenize_extra_colon):
198         (TestExpectationParserTests.test_tokenize_empty_comment):
199         (TestExpectationParserTests.test_tokenize_comment):
200         (TestExpectationParserTests.test_tokenize_missing_equal):
201         (TestExpectationParserTests.test_tokenize_extra_equal):
202         (TestExpectationParserTests.test_tokenize_valid):
203         (TestExpectationParserTests.test_tokenize_valid_with_comment):
204         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
205         (TestExpectationSerializerTests.test_unparsed_to_string):
206         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
207         (lint):
208         * Scripts/webkitpy/style/checkers/test_expectations.py:
209         (TestExpectationsChecker.check_test_expectations):
210
211 2012-02-02  Sheriff Bot  <webkit.review.bot@gmail.com>
212
213         Unreviewed, rolling out r106543.
214         http://trac.webkit.org/changeset/106543
215         https://bugs.webkit.org/show_bug.cgi?id=77671
216
217         Made tests less stable (Requested by rniwa on #webkit).
218
219         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
220         (PerfTestsRunner):
221         (PerfTestsRunner.__init__):
222         (PerfTestsRunner._run_tests_set):
223         (PerfTestsRunner._run_single_test):
224         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
225         (MainTest.TestDriver.run_test):
226         (run_test):
227
228 2012-02-02  Beth Dakin  <bdakin@apple.com>
229
230         https://bugs.webkit.org/show_bug.cgi?id=77664
231         Add API tests for didNewFirstVisuallyNonEmptyLayout
232
233         Reviewed by Darin Adler.
234
235         Two new tests.
236         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
237         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp: Added.
238         (TestWebKitAPI):
239         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
240         (TestWebKitAPI::setPageLoaderClient):
241         (TestWebKitAPI::TEST):
242         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp: Added.
243         (TestWebKitAPI):
244         (TestWebKitAPI::didForceRepaint):
245         (TestWebKitAPI::didFinishLoadForFrame):
246         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
247         (TestWebKitAPI::setPageLoaderClient):
248         (TestWebKitAPI::TEST):
249         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp: Added.
250         (TestWebKitAPI):
251         (NewFirstVisuallyNonEmptyLayoutFailsTest):
252         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::NewFirstVisuallyNonEmptyLayoutFailsTest):
253         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage):
254         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp: Added.
255         (TestWebKitAPI):
256         (NewFirstVisuallyNonEmptyLayoutTest):
257         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::NewFirstVisuallyNonEmptyLayoutTest):
258         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::didCreatePage):
259
260 2012-02-02  Michael Saboff  <msaboff@apple.com>
261
262         Add Michael Saboff to reviewers list.
263
264         Rubber-stamped by Gavin Barraclough.
265
266         * Scripts/webkitpy/common/config/committers.py:
267
268 2012-02-02  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
269
270         Add myself as a committer
271
272         Unreviewed
273
274         * Scripts/webkitpy/common/config/committers.py:
275
276 2012-02-02  Ryosuke Niwa  <rniwa@webkit.org>
277
278         [PerformanceTests] tests have dependencies
279         https://bugs.webkit.org/show_bug.cgi?id=77506
280
281         Reviewed by Hajime Morita.
282
283         Load an initialization page before each test after starting a DRT so that
284         warming up DRT won't affect the performance test results.
285
286         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
287         (PerfTestsRunner):
288         (PerfTestsRunner.__init__):
289         (PerfTestsRunner._run_tests_set):
290         (PerfTestsRunner._run_single_test):
291         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
292         (MainTest.TestDriver.run_test):
293         (test_initial_page_loaded):
294         (test_initial_page_loaded.run_test):
295
296 2012-02-02  Ryosuke Niwa  <rniwa@webkit.org>
297
298         Re-land r106442 per Adam's suggestion. We'll do both restarting DRT and loading a fake test first.
299
300         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
301         (PerfTestsRunner._run_tests_set):
302         (PerfTestsRunner._run_single_test):
303         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
304         (create_runner):
305         (test_run_passing_test):
306         (test_run_silent_test):
307         (test_run_failed_test):
308         (test_run_tonguey_test):
309         (test_run_timeout_test):
310         (test_run_crash_test):
311         (test_run_test_set_kills_drt_per_run):
312         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
313         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__):
314         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):
315
316 2012-02-01  Jacob Goldstein  <jacobg@adobe.com>
317
318         Webkit generate-coverage-data script needs update to use new test script
319         https://bugs.webkit.org/show_bug.cgi?id=77597
320
321         Reviewed by Dirk Schulze.
322
323         * Scripts/generate-coverage-data:
324
325 2012-02-01  Adam Barth  <abarth@webkit.org>
326
327         Update the tests to show that the mac-ews processes patches from
328         non-committers.
329
330         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
331         (EarlyWarningSytemTest.test_committer_only_ewses):
332         (EarlyWarningSytemTest.test_builder_ewses):
333
334 2012-02-01  Adam Barth  <abarth@webkit.org>
335
336         Mac-ews logs are huge
337         https://bugs.webkit.org/show_bug.cgi?id=77045
338
339         Reviewed by Eric Seidel.
340
341         In order to get the cr-linux-ews bot to run tests on EC2, we created
342         the chromium-xvfb port, which contained a number of tweaks to the
343         Chromium port's behavior.  This patch refactors those tweaks so they
344         can be shared with the mac-ews, mostly by moving them into the
345         non-interactive mode of RunTests.
346
347         * Scripts/webkitpy/common/config/ports.py:
348         (WebKitPort):
349         (WebKitPort.layout_tests_results_path):
350         (ChromiumPort.run_javascriptcore_tests_command):
351         (ChromiumXVFBPort):
352         (ChromiumXVFBPort.run_webkit_tests_command):
353         * Scripts/webkitpy/common/config/ports_mock.py:
354         (MockPort):
355         (MockPort.layout_tests_results_path):
356         * Scripts/webkitpy/common/config/ports_unittest.py:
357         (WebKitPortTest.test_chromium_xvfb_port):
358         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
359         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
360         * Scripts/webkitpy/tool/commands/queues_unittest.py:
361         (CommitQueueTest.test_commit_queue):
362         (test_rollout):
363         (test_manual_reject_during_processing):
364         * Scripts/webkitpy/tool/steps/runtests.py:
365         (RunTests.run):
366         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
367         (RunTestsTest.test_no_unit_tests):
368         * Scripts/webkitpy/tool/steps/steps_unittest.py:
369         (StepsTest.test_runtests_args):
370
371 2012-02-01  Ryosuke Niwa  <rniwa@webkit.org>
372
373         Roll out r106442. It made some tests more stable but others less stable.
374
375         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
376         (PerfTestsRunner._run_tests_set):
377         (PerfTestsRunner._run_single_test):
378         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
379         (create_runner):
380         (test_run_passing_test):
381         (test_run_silent_test):
382         (test_run_failed_test):
383         (test_run_tonguey_test):
384         (test_run_timeout_test):
385         (test_run_crash_test):
386         (test_run_test_set):
387
388 2012-02-01  Lucas Forschler  <lforschler@apple.com>
389
390         Enable EWS for non-contributers.
391         https://bugs.webkit.org/show_bug.cgi?id=77576
392         
393         Reviewed by Adam Barth.
394
395         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
396         (MacEWS):
397
398 2012-02-01  Beth Dakin  <bdakin@apple.com>
399
400         https://bugs.webkit.org/show_bug.cgi?id=77383
401         Add a different didFirstVisuallNonEmptyLayout heuristic to experiment with
402         -and corresponding-
403         <rdar://problem/10709560>
404
405         Reviewed by Sam Weinig.
406
407         WebKit2's WebLoaderClient has a temporary new function that must be accounted 
408         for.
409         * MiniBrowser/mac/BrowserWindowController.m:
410         (-[BrowserWindowController awakeFromNib]):
411         * WebKitTestRunner/TestController.cpp:
412         (WTR::TestController::initialize):
413
414 2012-02-01  Dirk Pranke  <dpranke@chromium.org>
415
416         TestWebKitAPI isn't being built on chromium bots any more
417         https://bugs.webkit.org/show_bug.cgi?id=77563
418
419         Reviewed by Dimitri Glazkov.
420
421         I accidentally dropped it in the refactoring in r105449.
422
423         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Added.
424
425 2012-02-01  Hans Wennborg  <hans@chromium.org>
426
427         Rename WebSpeechInputResult::set() to assign()
428         https://bugs.webkit.org/show_bug.cgi?id=77540
429
430         Reviewed by Darin Fisher.
431
432         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
433         (MockWebSpeechInputController::addMockRecognitionResult):
434         (MockWebSpeechInputController::speechTaskFired):
435
436 2012-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
437
438         [GTK] WebKit1 API documentation is not generated when building with gtk-2.0
439         https://bugs.webkit.org/show_bug.cgi?id=77542
440
441         Reviewed by Martin Robinson.
442
443         * gtk/generate-gtkdoc: Check first whether there's
444         webkitgtk-3.0.pc and if it doesn't exist use webkitgtk-1.0.pc
445         instead.
446         (get_webkit2_options): Return just the options since the
447         pkg_config_path doesn't depend on options
448         (get_webkit1_options): Ditto.
449         (generate_doc): Helper function to create a generator and generate
450         documentation for the given pkg-config file with the given options.
451         * gtk/gtkdoc.py:
452         (GTKDoc.__init__): Don't use ** for args parameter, since it's
453         used as a dict and never expanded.
454         (PkgConfigGTKDoc.__init__): Ditto.
455
456 2012-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
457
458         [GTK] API documentation is not installed even when building with --enable-gtk-doc
459         https://bugs.webkit.org/show_bug.cgi?id=77094
460
461         Reviewed by Martin Robinson.
462
463         * GNUmakefile.am: Add install-data-local and uninstall-local rules
464         to install/uninstall WebKit1 and WebKit2 API documentation.
465
466 2012-02-01  Sheriff Bot  <webkit.review.bot@gmail.com>
467
468         Unreviewed, rolling out r106460.
469         http://trac.webkit.org/changeset/106460
470         https://bugs.webkit.org/show_bug.cgi?id=77552
471
472         It break unit tests if WEBKIT_TESTFONTS isn't defined.
473         (Requested by Ossy on #webkit).
474
475         * Scripts/webkitpy/layout_tests/port/qt.py:
476
477 2012-02-01  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
478
479         [Qt] Automatic clean build feature always do clean build with --no-webkit2
480         https://bugs.webkit.org/show_bug.cgi?id=74519
481
482         Reviewed by Tor Arne Vestbø.
483
484         Set the PLUGIN_ARCHITECTURE_UNSUPPORTED define always.
485
486         * qmake/mkspecs/features/features.prf:
487
488 2012-02-01  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
489
490         [Qt][WK2] run-webkit-tests --qt  crashes if WEBKIT_TESTFONTS is not set
491         https://bugs.webkit.org/show_bug.cgi?id=77466
492
493         Reviewed by Kenneth Rohde Christiansen.
494
495         Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS
496         is set or if we should raise an error.
497
498         * Scripts/webkitpy/layout_tests/port/qt.py:
499         (QtPort.setup_environ_for_server):
500
501 2012-02-01  Philippe Normand  <pnormand@igalia.com> and Sergio Villar Senin  <svillar@igalia.com>
502
503         Reviewed by Martin Robinson.
504
505         [GTK] Improve FrameLoader signals. Resource loading
506         https://bugs.webkit.org/show_bug.cgi?id=49543
507
508         Support for the new loader signals in DRT.
509
510         * DumpRenderTree/gtk/DumpRenderTree.cpp:
511         (urlPath):
512         (willSendRequestCallback):
513         (urlSuitableForTestResult):
514         (descriptionSuitableForTestResult):
515         (didReceiveResponse):
516         (didFinishLoading):
517         (didFailLoadingWithError):
518         (createWebView):
519
520 2012-02-01  Ryosuke Niwa  <rniwa@webkit.org>
521
522         run-perf-tests should restart DRT for each test
523         https://bugs.webkit.org/show_bug.cgi?id=77506
524
525         Reviewed by Adam Barth.
526
527         Always restart DRT when running performance tests in order to minimize the dependency between tests.
528
529         * Scripts/webkitpy/layout_tests/port/chromium.py:
530         (ChromiumDriver.stop):
531         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
532         (PerfTestsRunner._run_tests_set):
533         (PerfTestsRunner._run_single_test):
534         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
535         (create_runner):
536         (test_run_passing_test):
537         (test_run_silent_test):
538         (test_run_failed_test):
539         (test_run_tonguey_test):
540         (test_run_timeout_test):
541         (test_run_crash_test):
542         (test_run_test_set_kills_drt_per_run):
543         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
544         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__):
545         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):
546
547 2012-01-31  Hans Wennborg  <hans@chromium.org>
548
549         Speech Input: Report speech element rect relative to window rather than frame
550         https://bugs.webkit.org/show_bug.cgi?id=76443
551
552         Reviewed by Darin Fisher.
553
554         Update LayoutTestController to allow for retrieving the speech
555         element's position used in a request.
556
557         In Chromium this is handled by the MockWebSpeechInputController;
558         adding stubs for the other implementations.
559
560         * DumpRenderTree/LayoutTestController.cpp:
561         (setMockSpeechInputDumpRectCallback):
562         (LayoutTestController::staticFunctions):
563         * DumpRenderTree/LayoutTestController.h:
564         (LayoutTestController):
565         * DumpRenderTree/chromium/LayoutTestController.cpp:
566         (LayoutTestController::LayoutTestController):
567         (LayoutTestController::setMockSpeechInputDumpRect):
568         * DumpRenderTree/chromium/LayoutTestController.h:
569         (LayoutTestController):
570         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
571         (MockWebSpeechInputController::setDumpRect):
572         (MockWebSpeechInputController::clearResults):
573         (MockWebSpeechInputController::startRecognition):
574         (MockWebSpeechInputController::MockWebSpeechInputController):
575         (makeRectResult):
576         (MockWebSpeechInputController::speechTaskFired):
577         * DumpRenderTree/chromium/MockWebSpeechInputController.h:
578         (MockWebSpeechInputController):
579         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
580         (LayoutTestController::setMockSpeechInputDumpRect):
581         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
582         (LayoutTestController::setMockSpeechInputDumpRect):
583         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
584         (LayoutTestController::setMockSpeechInputDumpRect):
585         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
586         (LayoutTestController::setMockSpeechInputDumpRect):
587         * DumpRenderTree/qt/LayoutTestControllerQt.h:
588         (LayoutTestController):
589         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
590         (LayoutTestController::setMockSpeechInputDumpRect):
591         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
592         (LayoutTestController::setMockSpeechInputDumpRect):
593
594 2012-01-31  Ryuan Choi  <ryuan.choi@samsung.com>
595
596         [EFL] Add basic DRT/Efl implementation to support viewport test.
597         https://bugs.webkit.org/show_bug.cgi?id=77320
598
599         Reviewed by Andreas Kling.
600
601         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
602         (LayoutTestController::dumpConfigurationForViewport): call dumpConfigurationForViewport().
603
604 2012-01-31  Alexey Proskuryakov  <ap@apple.com>
605
606         REGRESSION (WebKit2): event.keyCode is always zero when typing in Russian
607         https://bugs.webkit.org/show_bug.cgi?id=77473
608         <rdar://problem/10751357>
609
610         Reviewed by Darin Adler.
611
612         * DumpRenderTree/mac/EventSendingController.mm:
613         (-[EventSendingController keyDown:withModifiers:withLocation:]):
614         * WebKitTestRunner/mac/EventSenderProxy.mm:
615         (WTR::EventSenderProxy::keyDown):
616         Added a new special keyDown value to test this.
617
618 2012-01-31  Dirk Pranke  <dpranke@chromium.org>
619
620         nrwt: fix the mock port to work with DriverProxy, reftests
621         https://bugs.webkit.org/show_bug.cgi?id=77170
622
623         Reviewed by Eric Seidel.
624
625         The DryrunPort used for benchmarking and testing NRWT has been
626         broken since we added the DriverProxy code. It isn't really
627         needed any more, so I've removed it.
628
629         The MockDRT port was also broken by DriverProxy, and moreover,
630         never worked w/ reftests. Since we don't exercise this module in
631         the unit tests, the code had also bitrotted some. I have cleaned
632         it up and made it use DriverInput and DriverOutput for
633         consistency.
634
635         * Scripts/webkitpy/layout_tests/port/dryrun.py:
636         (DryRunPort.__init__):
637         (DryRunPort):
638         (DryRunPort.real_name):
639         (DryRunPort.create_driver):
640         (DryRunPort.driver_cmd_line):
641         (DryRunPort._driver_class):
642         (DryrunDriver):
643         (DryrunDriver.run_test):
644         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
645         (MockDRTPort.create_driver):
646         (MockChromiumDRT.run_one_test):
647
648 2012-01-31  Ojan Vafai  <ojan@chromium.org>
649
650         run-webkit-tests calls out to webkit-build-directory twice
651         https://bugs.webkit.org/show_bug.cgi?id=77248
652
653         Reviewed by Dirk Pranke.
654
655         * Scripts/webkit-build-directory:
656         If called with no arguments, print out both the top-level directory and the 
657         configuration directory
658
659         * Scripts/webkitpy/layout_tests/port/config.py:
660         (Config.build_directory):
661         When called with no arguments, get and cache both the top-level and configuration directories.
662
663         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
664         (main):
665         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
666         (ConfigTest.assert_configuration):
667         (ConfigTest.test_build_directory.mock_webkit_build_directory):
668         (ConfigTest.test_build_directory):
669         (ConfigTest.test_default_configuration__notfound):
670         * Scripts/webkitpy/layout_tests/port/webkit.py:
671         (WebKitPort._build_path):
672         Cache the build directory in the options object so that other users
673         of the options object don't need to call out to webkit-build-directory.
674         Also, properly support the existing --build-directory argument.
675
676 2012-01-31  Ryosuke Niwa  <rniwa@webkit.org>
677
678         Bump up the timeout for performance tests since DOM/DOMTable.html
679         and Parser/html5-full-render.html are timing out on the bot.
680
681         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
682         (PerfTestsRunner._parse_args):
683
684 2012-01-31  Ehsan Akhgari  <ehsan.akhgari@gmail.com>
685
686         Fix the update_webgl_conformance_tests.py script in order to enable it
687         to detect the SCM being used correctly.
688         https://bugs.webkit.org/show_bug.cgi?id=77462
689
690         Reviewed by Kenneth Russell.
691
692         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
693         (default_out_dir):
694
695 2012-01-31  Eric Seidel  <eric@webkit.org>
696
697         webkit-patch apply-from-bug should work regardless of your CWD
698         https://bugs.webkit.org/show_bug.cgi?id=77482
699
700         Reviewed by Adam Barth.
701
702         webkit-patch only ever works with patches made from the root
703         directory.  We should pass the CWD to svn-apply in the case
704         where we're running not from the webkit root.  I believe
705         this used to work in the past and regressed.
706
707         * Scripts/webkitpy/common/checkout/checkout.py:
708         (Checkout.apply_patch):
709         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
710         (CheckoutTest.test_apply_patch):
711
712 2012-01-31  Sheriff Bot  <webkit.review.bot@gmail.com>
713
714         Unreviewed, rolling out r106302.
715         http://trac.webkit.org/changeset/106302
716         https://bugs.webkit.org/show_bug.cgi?id=77472
717
718         Broke building DRT before running the tests (Requested by ojan
719         on #webkit).
720
721         * Scripts/webkit-build-directory:
722         * Scripts/webkitpy/layout_tests/port/config.py:
723         (Config.build_directory):
724         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
725         (main):
726         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
727         (ConfigTest.assert_configuration):
728         (ConfigTest.test_build_directory.mock_webkit_build_directory):
729         (ConfigTest.test_build_directory):
730         (ConfigTest.test_default_configuration__notfound):
731         * Scripts/webkitpy/layout_tests/port/webkit.py:
732         (WebKitPort._build_path):
733
734 2012-01-31  Antoine Labour  <piman@chromium.org>
735
736         Merge WebGraphicsContext3D creation and initialization, and move it to
737         WebViewClient.
738         https://bugs.webkit.org/show_bug.cgi?id=76593
739
740         Reviewed by Darin Fisher.
741
742         * DumpRenderTree/chromium/TestWebPlugin.cpp:
743         (TestWebPlugin::TestWebPlugin):
744         (TestWebPlugin::initialize):
745         * DumpRenderTree/chromium/TestWebPlugin.h:
746         * DumpRenderTree/chromium/WebViewHost.cpp:
747         (WebViewHost::createGraphicsContext3D):
748         (WebViewHost::createPlugin):
749         * DumpRenderTree/chromium/WebViewHost.h:
750
751 2012-01-31  Gabor Rapcsanyi  <rgabor@webkit.org>
752
753         [GTK] build-webkit warning.
754         https://bugs.webkit.org/show_bug.cgi?id=77411
755
756         Reviewed by Philippe Normand.
757
758         * Scripts/webkitdirs.pm:
759         (isCrossCompilation):
760
761 2012-01-31  Dan Bernstein  <mitz@apple.com>
762
763         When generating derived sources, use the same compiler that is used to compile WebKitTestRunner.
764
765         Reviewed by Anders Carlsson.
766
767         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
768
769 2012-01-31  Csaba Osztrogonác  <ossy@webkit.org>
770
771         If the QTDIR environment variable is set, the build system fails to compile WinCairo
772         https://bugs.webkit.org/show_bug.cgi?id=77112
773
774         Reviewed by Daniel Bates.
775
776         * Scripts/webkitdirs.pm:
777         (determineIsQt):
778
779 2012-01-31  Adam Roben  <aroben@apple.com>
780
781         Only call -typingAttributes on WebViews, not WebHTMLViews
782
783         Looks like this case was just missed in r105908.
784
785         Fixes <http://webkit.org/b/77432> REGRESSION (r105908): WebKit1.InspectorBarTest is crashing
786
787         Reviewed by Antti Koivisto.
788
789         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
790         (TestWebKitAPI::TEST): Call -typingAttributes on the WebView, just like we do 2 lines
791         earlier.
792
793 2012-01-31  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
794
795         [Qt] MiniBrowser: Show touch mocking indicators only when Ctrl is held down.
796         https://bugs.webkit.org/show_bug.cgi?id=77221
797
798         Reviewed by Kenneth Rohde Christiansen.
799
800         This makes sure that the indicator isn't in the way when doing clicks or dealing with the rest of the UI.
801
802         * MiniBrowser/qt/MiniBrowserApplication.cpp:
803         (MiniBrowserApplication::sendTouchEvent):
804
805 2012-01-26  Hans Wennborg  <hans@chromium.org>
806
807         Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation
808         https://bugs.webkit.org/show_bug.cgi?id=77083
809
810         Reviewed by Darin Fisher.
811
812         Add MockWebSpeechInputController which provides a mock implementation
813         of the WebSpeechInputController interface, and use that in
814         DumpRenderTree.
815
816         * DumpRenderTree/DumpRenderTree.gypi:
817         * DumpRenderTree/chromium/LayoutTestController.cpp:
818         (LayoutTestController::addMockSpeechInputResult):
819         * DumpRenderTree/chromium/LayoutTestController.h:
820         ():
821         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Added.
822         (MockWebSpeechInputController::create):
823         (MockWebSpeechInputController::addMockRecognitionResult):
824         (MockWebSpeechInputController::clearResults):
825         (MockWebSpeechInputController::startRecognition):
826         (MockWebSpeechInputController::cancelRecognition):
827         (MockWebSpeechInputController::stopRecording):
828         (MockWebSpeechInputController::MockWebSpeechInputController):
829         (MockWebSpeechInputController::speechTaskFired):
830         (MockWebSpeechInputController::SpeechTask::SpeechTask):
831         (MockWebSpeechInputController::SpeechTask::stop):
832         (MockWebSpeechInputController::SpeechTask::runIfValid):
833         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Added.
834         (WebKit):
835         (MockWebSpeechInputController):
836         (MockWebSpeechInputController::taskList):
837         (SpeechTask):
838         * DumpRenderTree/chromium/TestShell.cpp:
839         * DumpRenderTree/chromium/WebViewHost.cpp:
840         (WebViewHost::speechInputController):
841         * DumpRenderTree/chromium/WebViewHost.h:
842         (WebKit):
843         (WebViewHost::speechInputControllerMock):
844         (WebViewHost):
845         ():
846
847 2012-01-31  Hajime Morrita  <morrita@chromium.org>
848
849         [PerformanceTests] Add landing html for Dromaeo dom-query test
850         https://bugs.webkit.org/show_bug.cgi?id=77329
851
852         Reviewed by Ryosuke Niwa.
853
854         Added some more ignorable output patterns to allow warnings
855         from a third party test suite.
856
857         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
858         (PerfTestsRunner):
859         (PerfTestsRunner._should_ignore_line_in_parser_test_result):
860
861 2012-01-30  Kevin Ollivier  <kevino@theolliviers.com>
862
863         [wx] Unreviewed. Update download URLs to new domain.
864         
865         * waf/build/build_utils.py:
866         (update_wx_deps):
867
868 2012-01-30  Kevin Ollivier  <kevino@theolliviers.com>
869
870         [wx] Unreviewed. Build fix, add JavaScriptCore/tools
871         to the list of build directories.
872         
873         * waf/build/settings.py:
874
875 2012-01-30  Kentaro Hara  <haraken@chromium.org>
876
877         REGRESSION(r105797): prepare-ChangeLog for a .cpp file can
878         output an empty method name (i.e. "()")
879         https://bugs.webkit.org/show_bug.cgi?id=77336
880
881         Reviewed by Darin Adler.
882
883         r105797 tried to detect a change outside methods, but it causes a bug that
884         prepare-ChangeLog can output an empty method name, like this:
885
886             * foo/bar/baz.cpp:
887             (method1):
888             ():
889             (method2):
890
891         This is because the cpp parser in prepare-ChangeLog cannot distinguish
892         '{' as the beginning of a method with '{' as the beginning of an array definition
893         at the top level.
894
895             int a[] = { 1, 2, 3 };  // This '{' is the beginning of an array definition.
896
897             void func() { // This '{' is the beginning of a method.
898                 ...;
899             }
900
901         This patch fixes prepare-ChangeLog so that it skips an array definition at the top level.
902
903         * Scripts/prepare-ChangeLog:
904         (get_function_line_ranges_for_cpp): Modified as described above.
905         (generateFunctionLists): As a hack, modified so that prepare-ChangeLog does not output
906         an empty method name. Ideally this should not happen but may happen, since the
907         parsers are not perfect.
908         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases.
909         (NameSpace7):
910         (NameSpace8):
911         (Class109):
912         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
913
914 2012-01-30  Ojan Vafai  <ojan@chromium.org>
915
916         run-webkit-tests calls out to webkit-build-directory twice
917         https://bugs.webkit.org/show_bug.cgi?id=77248
918
919         Reviewed by Dirk Pranke.
920
921         This reduces to calls to webkit-build-directory to one call and
922         saves 500ms for run-webkit-tests over a single file.
923
924         * Scripts/webkit-build-directory:
925         If called with no arguments, print out both the top-level directory and the 
926         configuration directory.
927
928         * Scripts/webkit-build-directory:
929         * Scripts/webkitpy/layout_tests/port/config.py:
930         (Config.build_directory):
931         When called with no arguments, get and cache both the top-level and configuration directories.
932
933         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
934         (main):
935         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
936         (ConfigTest.assert_configuration):
937         (ConfigTest.test_build_directory.mock_webkit_build_directory):
938         (ConfigTest.test_build_directory):
939         (ConfigTest.test_default_configuration__notfound):
940         * Scripts/webkitpy/layout_tests/port/webkit.py:
941         (WebKitPort._build_path):
942         Cache the root directory in the options object so that other users
943         of the options object don't need to call out to webkit-build-directory.
944
945 2012-01-30  Ojan Vafai  <ojan@chromium.org>
946
947         Parsing test_expecations.txt + Skipped lists takes too long
948         https://bugs.webkit.org/show_bug.cgi?id=77059
949
950         Reviewed by Dirk Pranke.
951
952         This saves ~100ms on the Apple Mac port.
953         -memoize a bunch of path methods.
954         -Avoid doing multiple disk accesses per line.
955         -Parse the skipped list directly instead of turning it into a test_expecations.txt
956         formatting string and parsing that.
957
958         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
959         (TestExpectationParser):
960         (TestExpectationParser.expectation_for_skipped_test):
961         (TestExpectationParser._parse_line):
962         (TestExpectationParser._collect_matching_tests):
963         (TestExpectations.__init__):
964         (TestExpectations._add_skipped_tests):
965         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
966         (test_add_skipped_tests):
967         (test_add_skipped_tests_duplicate):
968         * Scripts/webkitpy/layout_tests/port/base.py:
969         (Port):
970         (Port.test_isfile):
971         (Port.normalize_test_name):
972         (Port.layout_tests_dir):
973         (Port.abspath_for_test):
974         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
975
976 2012-01-30  Alexis Menard  <alexis.menard@openbossa.org>
977
978         Unreviewed. Add myself to CSS, GStreamer, Qt related watchlists.
979         
980         * Scripts/webkitpy/common/config/watchlist:
981
982 2012-01-30  Gavin Barraclough  <barraclough@apple.com>
983
984         Unreviewed build fix following bug#76855
985
986         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
987         ():
988         (TestWebKitAPI::TEST_F):
989
990 2012-01-26  No'am Rosenthal  <noam.rosenthal@nokia.com> and Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
991
992         [Qt] WKTR: Use a software rendering pipiline when running tests.
993         https://bugs.webkit.org/show_bug.cgi?id=76708
994
995         Reviewed by Kenneth Rohde Christiansen.
996
997         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
998         (WTR::WrapperWindow::WrapperWindow):
999         (WTR::PlatformWebView::PlatformWebView): Use software rendering of layers since the wrapping QQuickView isn't shown.
1000
1001 2012-01-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1002
1003         [Qt] Store build config immediately instead of waiting for a successfull build
1004
1005         Otherwise we will not pick up changes to the config if the build is aborted,
1006         for example due to build errors or if the user pressed Ctrl+Z. We now write
1007         the new config before starting a build, but still defer to write the SVN
1008         revision once the build completes successfully.
1009
1010         Reviewed by Ossy.
1011
1012         * Scripts/webkitdirs.pm:
1013         (buildQMakeProjects):
1014
1015 2012-01-30  Alexander Færøy  <ahf@0x90.dk>
1016
1017         [Qt] Add "New Window" button to the Qt MiniBrowser
1018         https://bugs.webkit.org/show_bug.cgi?id=77281
1019
1020         Reviewed by Tor Arne Vestbø.
1021
1022         * MiniBrowser/qt/BrowserWindow.cpp:
1023         (BrowserWindow::BrowserWindow):
1024         * MiniBrowser/qt/MiniBrowser.qrc:
1025         * MiniBrowser/qt/icons/plus.png: Added.
1026         * MiniBrowser/qt/qml/BrowserWindow.qml:
1027
1028 2012-01-30  Csaba Osztrogonác  <ossy@webkit.org>
1029
1030         Unreviewed rolling out r106222.
1031
1032         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1033         (SingleTestRunner.__init__):
1034         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1035         (Worker.handle_test_list):
1036         * Scripts/webkitpy/layout_tests/models/test_input.py:
1037         (TestInput.__init__):
1038         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1039         (_set_up_derived_options):
1040         (parse_args):
1041         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1042         (MainTest.test_repeat_each):
1043         * WebKitTestRunner/TestInvocation.cpp:
1044         (WTR::TestInvocation::setIsPixelTest):
1045
1046 2012-01-30  Hans Wennborg  <hans@chromium.org>
1047
1048         Unreviewed, rolling out r106219.
1049         http://trac.webkit.org/changeset/106219
1050         https://bugs.webkit.org/show_bug.cgi?id=77083
1051
1052         This broke Chromium's test_shell.
1053
1054         * DumpRenderTree/DumpRenderTree.gypi:
1055         * DumpRenderTree/chromium/LayoutTestController.cpp:
1056         (LayoutTestController::addMockSpeechInputResult):
1057         * DumpRenderTree/chromium/LayoutTestController.h:
1058         (WebKit):
1059         (LayoutTestController):
1060         ():
1061         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Removed.
1062         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Removed.
1063         * DumpRenderTree/chromium/TestShell.cpp:
1064         * DumpRenderTree/chromium/WebViewHost.cpp:
1065         (WebViewHost::speechInputController):
1066         * DumpRenderTree/chromium/WebViewHost.h:
1067         (WebKit):
1068         (WebViewHost::speechInputControllerMock):
1069         (WebViewHost):
1070         ():
1071
1072 2012-01-26  Hans Wennborg  <hans@chromium.org>
1073
1074         Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation
1075         https://bugs.webkit.org/show_bug.cgi?id=77083
1076
1077         Reviewed by Darin Fisher.
1078
1079         Add MockWebSpeechInputController which provides a mock implementation
1080         of the WebSpeechInputController interface, and use that in
1081         DumpRenderTree.
1082
1083         * DumpRenderTree/DumpRenderTree.gypi:
1084         * DumpRenderTree/chromium/LayoutTestController.cpp:
1085         (LayoutTestController::addMockSpeechInputResult):
1086         * DumpRenderTree/chromium/LayoutTestController.h:
1087         ():
1088         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Added.
1089         (MockWebSpeechInputController::create):
1090         (MockWebSpeechInputController::addMockRecognitionResult):
1091         (MockWebSpeechInputController::clearResults):
1092         (MockWebSpeechInputController::startRecognition):
1093         (MockWebSpeechInputController::cancelRecognition):
1094         (MockWebSpeechInputController::stopRecording):
1095         (MockWebSpeechInputController::MockWebSpeechInputController):
1096         (MockWebSpeechInputController::speechTaskFired):
1097         (MockWebSpeechInputController::SpeechTask::SpeechTask):
1098         (MockWebSpeechInputController::SpeechTask::stop):
1099         (MockWebSpeechInputController::SpeechTask::runIfValid):
1100         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Added.
1101         (WebKit):
1102         (MockWebSpeechInputController):
1103         (MockWebSpeechInputController::taskList):
1104         (SpeechTask):
1105         * DumpRenderTree/chromium/TestShell.cpp:
1106         * DumpRenderTree/chromium/WebViewHost.cpp:
1107         (WebViewHost::speechInputController):
1108         * DumpRenderTree/chromium/WebViewHost.h:
1109         (WebKit):
1110         (WebViewHost::speechInputControllerMock):
1111         (WebViewHost):
1112         ():
1113
1114 2012-01-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1115
1116         Unreviewed, rolling out r106109.
1117         http://trac.webkit.org/changeset/106109
1118         https://bugs.webkit.org/show_bug.cgi?id=77302
1119
1120         It made tests crash (Requested by Ossy_weekend on #webkit).
1121
1122         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1123         (WTR::WrapperWindow::WrapperWindow):
1124         (WTR::PlatformWebView::PlatformWebView):
1125
1126 2012-01-28  Nico Weber  <thakis@chromium.org>
1127
1128         [chromium] Add support for building standalone webkit/chromium checkouts with ninja.
1129         https://bugs.webkit.org/show_bug.cgi?id=77243
1130
1131         Reviewed by Adam Barth.
1132
1133         * Scripts/update-webkit:
1134         * Scripts/webkitdirs.pm:
1135         (isChromiumNinja):
1136         (determineIsChromiumNinja):
1137         (buildChromiumNinja):
1138         (buildChromium):
1139
1140 2012-01-27  Kentaro Hara  <haraken@chromium.org>
1141
1142         The cpp parser of prepare-ChangeLog treats if(...) {} as a method
1143         https://bugs.webkit.org/show_bug.cgi?id=77241
1144
1145         Reviewed by Ryosuke Niwa.
1146
1147         The cpp parser of prepare-ChangeLog is wrong, and an inner {} block
1148         in a method in some namespace or class is treated as a method.
1149         This patch fixes the bug.
1150
1151             class C {
1152                 void func()
1153                 {
1154                     if (1) {    // This should not be treated as a method.
1155                     }
1156                 }
1157             };
1158
1159         * Scripts/prepare-ChangeLog:
1160         (get_function_line_ranges_for_cpp):
1161         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
1162         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
1163         (Class108):
1164         (Class108::func35):
1165
1166 2012-01-27  Enrica Casucci  <enrica@apple.com>
1167
1168         Followup to http://trac.webkit.org/changeset/106171.
1169         Dan Bernstein pointed out correctly that I should
1170         have used copy instead of initWithString.
1171
1172         Reviewed by Dan Bernstein.
1173
1174         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1175         (-[LocalPasteboard initWithName:]):
1176
1177 2012-01-27  Enrica Casucci  <enrica@apple.com>
1178
1179         DRT pasteboard object should return the correct pasteboard name.
1180         https://bugs.webkit.org/show_bug.cgi?id=77260
1181         
1182         Currently the name property always returns nil.
1183         Adding a memeber variable to store the pasteboard name and return its
1184         value from the name method instead of returning nil always.
1185
1186         Reviewed by Dan Bernstein.
1187
1188         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1189         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
1190         (-[LocalPasteboard initWithName:]):
1191         (-[LocalPasteboard name]):
1192
1193 2012-01-27  Martin Robinson  <mrobinson@igalia.com>
1194
1195         [GTK] [WK2] Implement the policy client
1196         https://bugs.webkit.org/show_bug.cgi?id=76343
1197
1198         Reviewed by Gustavo Noronha Silva.
1199
1200         * gtk/generate-gtkdoc:
1201         (get_webkit2_options): Update the list of skipped source files to include all clients.
1202
1203 2012-01-27  Ada Chan  <adachan@apple.com>
1204
1205         Add test for WKBundleFrameGetParentFrame().
1206         https://bugs.webkit.org/show_bug.cgi?id=77161
1207
1208         Reviewed by Anders Carlsson.
1209
1210         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add ParentFrame.cpp and ParentFrame_Bundle.cpp.
1211         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp: Added.
1212         (TestWebKitAPI):
1213         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Get the check result from the injected bundle.
1214         (TestWebKitAPI::setInjectedBundleClient):
1215         (TestWebKitAPI::TEST): Load simple-iframe.html and then wait for the injected bundle to post result.
1216         Make sure the check is successful.
1217         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp: Added.
1218         (TestWebKitAPI):
1219         (ParentFrameTest):
1220         (TestWebKitAPI::ParentFrameTest::ParentFrameTest):
1221         (TestWebKitAPI::didFinishLoadForFrame): If the frame is a subframe, store it off for checking later.
1222         If the frame is the main frame, check whether it's indeed the subframe's parent frame and post the result
1223         to the test controller.
1224         (TestWebKitAPI::ParentFrameTest::didCreatePage): Set the page loader client on this page.
1225
1226 2012-01-27  Zan Dobersek  <zandobersek@gmail.com>
1227
1228         [Gtk] DumpRenderTree lacks --no-timeout command line option
1229         https://bugs.webkit.org/show_bug.cgi?id=77196
1230
1231         Reviewed by Martin Robinson.
1232
1233         Add the --no-timeout command line option and reorganize
1234         watchdog code to make running DumpRenderTree without
1235         timeout possible.
1236
1237         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1238         (setWaitToDumpWatchdog):
1239         (shouldSetWaitToDumpWatchdog):
1240         (initializeGlobalsFromCommandLineOptions):
1241         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1242         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1243         (waitToDumpWatchdogFired):
1244         (LayoutTestController::setWaitToDump):
1245
1246 2012-01-27  Andras Becsi  <andras.becsi@nokia.com>
1247
1248         [Qt][WK2] Enable the automatic touch->mouse mocking on the new Qt5 hashes
1249         https://bugs.webkit.org/show_bug.cgi?id=77122
1250
1251         Reviewed by Kenneth Rohde Christiansen.
1252
1253         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1254         (MiniBrowserApplication::MiniBrowserApplication):
1255
1256 2012-01-27  Zeno Albisser  <zeno@webkit.org>
1257
1258         [Qt][Mac] Build fails after adding ICU support (r105997).
1259         https://bugs.webkit.org/show_bug.cgi?id=77118
1260
1261         Define WTF_USE_ICU_UNICODE if we are on mac.
1262
1263         Reviewed by Tor Arne Vestbø.
1264
1265         * qmake/mkspecs/features/features.prf:
1266
1267 2012-01-27  Roland Takacs  <takacs.roland@stud.u-szeged.hu>
1268
1269         Update committers.py with new contributors.
1270         https://bugs.webkit.org/show_bug.cgi?id=77207
1271
1272         I added six new contributors into committers.py:
1273
1274         - Adam Kallai
1275         - Balazs Ankes
1276         - Janos Badics
1277         - Nandor Huszka
1278         - Roland Takacs
1279         - Szilard Ledan-Muntean
1280
1281         * Scripts/webkitpy/common/config/committers.py:
1282
1283 2012-01-27  Vsevolod Vlasov  <vsevik@chromium.org>
1284
1285         Add Vsevolod Vlasov to reviewers list.
1286
1287         Reviewed by Pavel Feldman.
1288
1289         * Scripts/webkitpy/common/config/committers.py:
1290
1291 2012-01-26  No'am Rosenthal  <noam.rosenthal@nokia.com> and Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1292
1293         [Qt] WKTR: Use a software rendering pipiline when running tests.
1294         https://bugs.webkit.org/show_bug.cgi?id=76708
1295
1296         Reviewed by Kenneth Rohde Christiansen.
1297
1298         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1299         (WTR::WrapperWindow::WrapperWindow):
1300         (WTR::PlatformWebView::PlatformWebView): Use software rendering of layers since the wrapping QQuickView isn't shown.
1301
1302 2012-01-26  Kevin Ollivier  <kevino@theolliviers.com>
1303
1304         [wx] Unreviewed. Build fix, add WebCore/testing/js
1305         to the list of source directories we build.
1306
1307         * waf/build/settings.py:
1308
1309 2012-01-26  Filip Pizlo  <fpizlo@apple.com>
1310
1311         Tools/Scripts/commit-log-editor is broken due to $_ getting clobbered
1312         https://bugs.webkit.org/show_bug.cgi?id=77177
1313
1314         Reviewed by Jon Honeycutt.
1315
1316         * Scripts/commit-log-editor:
1317
1318 2012-01-26  Ojan Vafai  <ojan@chromium.org>
1319
1320         Decrease sleep time when killing server_process on Mac.
1321         https://bugs.webkit.org/show_bug.cgi?id=77169
1322
1323         Reviewed by Eric Seidel.
1324
1325         This shaves another ~70ms off single test runtime.
1326
1327         * Scripts/webkitpy/layout_tests/port/server_process.py:
1328         (ServerProcess.stop):
1329
1330 2012-01-26  Ojan Vafai  <ojan@chromium.org>
1331
1332         Remove builder name so http://trac.webkit.org/changeset/106035 actually works.
1333         https://bugs.webkit.org/show_bug.cgi?id=77164
1334
1335         Reviewed by Dirk Pranke.
1336
1337         http://trac.webkit.org/changeset/106035 depends on builder_name being
1338         falsey by default. There's other code that requires it to be iterable
1339         by default. So, make it be the empty string.
1340
1341         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1342         (parse_args):
1343
1344 2012-01-26  Ryosuke Niwa  <rniwa@webkit.org>
1345
1346         run-perf-test should include relative file paths in test names
1347         https://bugs.webkit.org/show_bug.cgi?id=77144
1348
1349         Reviewed by Adam Birth.
1350
1351         Include all directory names in the test name separated by "/".
1352         e.g. Bindings/event-target-wrapper.html translates to Bindings/event-target-wrapper
1353
1354         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1355         (PerfTestsRunner):
1356         (PerfTestsRunner._process_parser_test_result):
1357         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1358         (test_run_test_set_with_json_output):
1359         (test_run_test_set_with_json_source):
1360
1361 2012-01-26  Dirk Pranke  <dpranke@chromium.org>
1362
1363         webkitpy: re-land cleanup of test scaffolding
1364         https://bugs.webkit.org/show_bug.cgi?id=77153
1365
1366         Reviewed by Eric Seidel.
1367
1368         This is an attempt to reland the change in bug 76973 / 
1369         r105935. My earlier attempt to manipulate PYTHONPATH
1370         seems to only work some of the time, for reasons that
1371         elude me. Directly adding Tools/Scripts to sys.path from
1372         inside the test script appears to work (more?) reliably.
1373
1374         Also, it seemed like the files didn't actually get deleted
1375         the last time; I don't know why.
1376
1377         * Scripts/test-webkitpy:
1378         * Scripts/webkitpy/common/system/executive_unittest.py:
1379         (command_line):
1380         (ExecutiveTest):
1381         (ExecutiveTest.test_run_command_args_type):
1382         (ExecutiveTest.test_run_command_with_unicode):
1383         (ExecutiveTest.test_running_pids):
1384         (main):
1385         * Scripts/webkitpy/common/system/fileutils.py: Removed.
1386         * Scripts/webkitpy/test/cat.py: Removed.
1387         * Scripts/webkitpy/test/cat_unittest.py: Removed.
1388         * Scripts/webkitpy/test/echo.py: Removed.
1389         * Scripts/webkitpy/test/echo_unittest.py: Removed.
1390
1391 2012-01-26  Ojan Vafai  <ojan@chromium.org>
1392
1393         run-webkit-tests calls "nm" when it doesn't need to
1394         https://bugs.webkit.org/show_bug.cgi?id=77143
1395
1396         Reviewed by Dirk Pranke.
1397
1398         If we are not running any test that can be skipped by checking
1399         the DRT feature list or looking at the list of symbols, avoid calling
1400         out to DRT or calling "nm".
1401
1402         This saves ~700ms on my Mac Pro. In cases where you still have to call out
1403         to "nm" it's only a couple ms slower.
1404
1405         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1406         (TestExpectations.__init__):
1407         * Scripts/webkitpy/layout_tests/port/base.py:
1408         (Port.skipped_tests):
1409         * Scripts/webkitpy/layout_tests/port/webkit.py:
1410         (WebKitPort._should_check_for_missing_features):
1411         (WebKitPort):
1412         (WebKitPort._should_check_for_missing_symbols):
1413         (WebKitPort._skipped_tests_for_unsupported_features):
1414         (WebKitPort.skipped_layout_tests):
1415         (WebKitPort.skipped_tests):
1416         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1417         (WebKitPortTest.test_skipped_directories_for_symbols):
1418         (test_skipped_directories_for_features):
1419         (test_skipped_directories_for_features_no_matching_tests_in_test_list):
1420         (test_skipped_layout_tests):
1421
1422 2012-01-26  Benjamin Poulain  <bpoulain@apple.com>
1423
1424         Support a suffix on ChangeLog filenames based on a configuration file
1425         https://bugs.webkit.org/show_bug.cgi?id=76956
1426
1427         Reviewed by Kentaro Hara.
1428
1429         Modify the tools used to generate, edit and resolve ChangeLogs to support
1430         the addition of a suffix to the ChangeLog filename.
1431
1432         This patch makes it easier to support alternate ChangeLog files in branches.
1433
1434         * Scripts/VCSUtils.pm:
1435         (changeLogSuffix):
1436         (changeLogFileName):
1437         * Scripts/commit-log-editor:
1438         * Scripts/prepare-ChangeLog:
1439         (getLatestChangeLogs):
1440         (generateNewChangeLogs):
1441         (generateFileList):
1442         * Scripts/resolve-ChangeLogs:
1443         (findChangeLog):
1444
1445 2012-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1446
1447         Unreviewed, rolling out r106038.
1448         http://trac.webkit.org/changeset/106038
1449         https://bugs.webkit.org/show_bug.cgi?id=77142
1450
1451         Caused a bunch of skipped tests to not be skipped. (Requested
1452         by ojan on #webkit).
1453
1454         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1455         (TestExpectationParser):
1456         (TestExpectationParser.parse):
1457         (TestExpectationParser._parse_line):
1458         (TestExpectationParser._collect_matching_tests):
1459         (TestExpectations.__init__):
1460         (TestExpectations._add_skipped_tests):
1461         * Scripts/webkitpy/layout_tests/port/base.py:
1462         (Port.test_dirs):
1463         (Port.normalize_test_name):
1464         (Port.update_baseline):
1465         (Port.layout_tests_dir):
1466         (Port.relative_perf_test_filename):
1467         (Port.abspath_for_test):
1468
1469 2012-01-25  Ojan Vafai  <ojan@chromium.org>
1470
1471         Parsing test_expecations.txt + Skipped lists takes too long
1472         https://bugs.webkit.org/show_bug.cgi?id=77059
1473
1474         Reviewed by Dirk Pranke.
1475
1476         This saves ~100ms on the Apple Mac port.
1477         -memoize a bunch of path methods.
1478         -Avoid doing multiple disk accesses per line.
1479         -Parse the skipped list directly instead of turning it into a test_expecations.txt
1480         formatting string and parsing that.
1481
1482         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1483         (TestExpectationParser):
1484         (TestExpectationParser.parse_skipped_tests):
1485         (TestExpectationParser._parse_line):
1486         (TestExpectationParser._collect_matching_tests):
1487         (TestExpectations.__init__):
1488         (TestExpectations._add_skipped_tests):
1489         * Scripts/webkitpy/layout_tests/port/base.py:
1490         (Port):
1491         (Port.test_isfile):
1492         (Port.normalize_test_name):
1493         (Port.layout_tests_dir):
1494         (Port.abspath_for_test):
1495
1496 2012-01-25  Ojan Vafai  <ojan@chromium.org>
1497
1498         Only store the SVN revision in the summarized results if we're on a builder
1499         https://bugs.webkit.org/show_bug.cgi?id=76976
1500
1501         Reviewed by Dirk Pranke.
1502
1503         This shaves another ~130ms off the single test run-webkit-tests runtime.
1504
1505         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1506         (summarize_results):
1507         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1508         (ResultSummaryTest.get_result):
1509         (ResultSummaryTest):
1510         (ResultSummaryTest.get_result_summary):
1511         (ResultSummaryTest.get_unexpected_results):
1512         (ResultSummaryTest.test_no_svn_revision):
1513         (ResultSummaryTest.test_svn_revision):
1514         * Scripts/webkitpy/layout_tests/port/base.py:
1515         (Port.use_trac_links_in_results_html):
1516
1517 2012-01-26  Luciano Wolf  <luciano.wolf@openbossa.org>
1518
1519         [Qt][WK2] fast/loader tests failed after r94178
1520         https://bugs.webkit.org/show_bug.cgi?id=67388
1521
1522         Reviewed by Simon Hausmann.
1523
1524         Applying the same fix used for Qt-WebKit1 from bug #67254 -
1525         [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
1526         https://bugs.webkit.org/show_bug.cgi?id=67254
1527         Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
1528         derived from the running location of DumpRenderTree binary.
1529
1530         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1531         (WTR::LayoutTestController::pathToLocalResource):
1532
1533 2012-01-26  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1534
1535         Implement overridePreference for boolean preferences in WebKitTestRunner
1536         https://bugs.webkit.org/show_bug.cgi?id=77033
1537
1538         Reviewed by Alexey Proskuryakov.
1539
1540         For now overridePreference supports boolean values.
1541
1542         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1543         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1544         (WTR::LayoutTestController::setXSSAuditorEnabled):
1545         (WTR::LayoutTestController::overridePreference):
1546         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1547         * WebKitTestRunner/TestController.cpp:
1548         (WTR::TestController::resetStateToConsistentValues): Reset the overrides
1549         explicitly and properly disable the use of PageCache when resetting the
1550         state. Tests that use PageCache can now enable it via overridePreference.
1551
1552 2012-01-26  Alexander Færøy  <alexander.faeroy@nokia.com>
1553
1554         [Qt] Support opening multiple URL's from the command line in the Qt MiniBrowser
1555         https://bugs.webkit.org/show_bug.cgi?id=77100
1556
1557         Reviewed by Simon Hausmann.
1558
1559         This patch makes the MiniBrowser read multiple URL's from the command
1560         line such that there will be one browser window opened for each URL.
1561
1562         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1563         (MiniBrowserApplication::handleUserOptions):
1564
1565 2012-01-26  Alexander Færøy  <alexander.faeroy@nokia.com>
1566
1567         [Qt] The Qt MiniBrowser crashes when given multiple URL's
1568         https://bugs.webkit.org/show_bug.cgi?id=77009
1569
1570         Reviewed by Simon Hausmann.
1571
1572         This patch fixes a crash in BrowserWindow::newWindow() where a
1573         BrowserWindow-object is constructed with a 0 pointer as the
1574         WindowOptions parameter which leads to a crash.
1575
1576         * MiniBrowser/qt/BrowserWindow.cpp:
1577         (BrowserWindow::BrowserWindow):
1578         (BrowserWindow::newWindow):
1579         * MiniBrowser/qt/BrowserWindow.h:
1580
1581 2012-01-26  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1582
1583         [Qt] Use ICU if available
1584         https://bugs.webkit.org/show_bug.cgi?id=76821
1585
1586         Reviewed by Simon Hausmann.
1587
1588         Adding unicode defines for a Qt 5 based build.
1589
1590         * qmake/mkspecs/features/features.prf:
1591
1592 2012-01-26  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
1593
1594         [WK2] WebKitTestRunner needs layoutTestController.setGeolocationPermission
1595         https://bugs.webkit.org/show_bug.cgi?id=42545
1596
1597         Reviewed by Zoltan Herczeg.
1598
1599         Implement the setGeolocationPermission method.
1600
1601         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1602         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1603         (WTR::LayoutTestController::setGeolocationPermission):
1604         (WTR):
1605         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1606         (LayoutTestController):
1607
1608 2012-01-26  Balazs Kelemen  <kbalazs@webkit.org>
1609
1610         [NRWT] Support --ignore-metrics
1611         https://bugs.webkit.org/show_bug.cgi?id=76278
1612
1613         Reviewed by Tony Chang.
1614
1615         Port the feature from ORWT.
1616
1617         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1618         (SingleTestRunner._run_compare_test):
1619         * Scripts/webkitpy/layout_tests/port/driver.py:
1620         (DriverOutput):
1621         (DriverOutput.strip_metrics):
1622         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
1623         (DriverOutputTest):
1624         (DriverOutputTest.test_strip_metrics):
1625         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1626         (_set_up_derived_options):
1627         (parse_args):
1628
1629 2012-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1630
1631         Unreviewed, rolling out r105935 and r105954.
1632         http://trac.webkit.org/changeset/105935
1633         http://trac.webkit.org/changeset/105954
1634         https://bugs.webkit.org/show_bug.cgi?id=77080
1635
1636         test-webkitpy is still broken (Requested by abarth on
1637         #webkit).
1638
1639         * Scripts/test-webkitpy:
1640         * Scripts/webkitpy/common/system/executive_unittest.py:
1641         (never_ending_command):
1642         (ExecutiveTest.test_run_command_args_type):
1643         (ExecutiveTest.test_run_command_with_unicode):
1644         (ExecutiveTest.test_running_pids):
1645         * Scripts/webkitpy/common/system/fileutils.py:
1646         (make_stdout_binary):
1647         * Scripts/webkitpy/test/cat.py:
1648         (command_arguments):
1649         (main):
1650         * Scripts/webkitpy/test/cat_unittest.py:
1651         (CatTest):
1652         (CatTest.assert_cat):
1653         (CatTest.test_basic):
1654         (CatTest.test_no_newline):
1655         (CatTest.test_unicode):
1656         (CatTest.test_as_command):
1657         * Scripts/webkitpy/test/echo.py:
1658         (command_arguments):
1659         (main):
1660         * Scripts/webkitpy/test/echo_unittest.py:
1661         (EchoTest):
1662         (EchoTest.test_basic):
1663         (EchoTest.test_no_newline):
1664         (EchoTest.test_unicode):
1665         (EchoTest.test_argument_order):
1666         (EchoTest.test_empty_arguments):
1667         (EchoTest.test_no_arguments):
1668         (EchoTest.test_as_command):
1669
1670 2012-01-26  Gabor Rapcsanyi  <rgabor@webkit.org>
1671
1672         [GTK] Detect cross-compilation in webkitdirs.pm to not generate gtkdoc
1673         https://bugs.webkit.org/show_bug.cgi?id=76138
1674
1675         Reviewed by Martin Robinson.
1676
1677         * Scripts/webkitdirs.pm:
1678         (isCrossCompilation):
1679         (buildAutotoolsProject):
1680
1681 2012-01-25  Adam Barth  <abarth@webkit.org>
1682
1683         Kentaro is a reviewer now.  Yay!
1684
1685         * Scripts/webkitpy/common/config/committers.py:
1686
1687 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1688
1689         nrwt: running w/ no arguments fails
1690         https://bugs.webkit.org/show_bug.cgi?id=77064
1691
1692         Unreviewed, build fix.
1693
1694         This change fixes a regression introduced in r105944
1695         where running without --platform <foo> or one of the other
1696         platform switches would cause a null deref :(.
1697
1698         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1699         (main):
1700
1701 2012-01-25  Eric Seidel  <eric@webkit.org>
1702
1703         Automatically CC someone from Apple on any changes to Obj-C public API
1704         https://bugs.webkit.org/show_bug.cgi?id=77053
1705
1706         Reviewed by Timothy Hatcher.
1707
1708         This has long been de-facto practice, seems now that we have
1709         fancy watchlist support, we should just make the tools
1710         do this automatically.
1711
1712         * Scripts/webkitpy/common/config/watchlist:
1713
1714 2012-01-25  Antoine Labour  <piman@chromium.org>
1715
1716         Updating status in committers.py.
1717
1718         Unreviewed.
1719
1720         * Scripts/webkitpy/common/config/committers.py:
1721
1722 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1723
1724         test-webkitpy: executive_unittest fails if PYTHONPATH isn't set
1725         https://bugs.webkit.org/show_bug.cgi?id=77058
1726
1727         Reviewed by Eric Seidel.
1728
1729         r105935 broke executive_unittest by changing which script we
1730         were running and not ensuring that the PYTHONPATH was set up
1731         properly.
1732
1733         This change also fixes a regression introduced recently where
1734         test-webkitpy wasn't figuring out the path to Tools/Scripts
1735         right, either (so running ./test-webkitpy would fail).
1736
1737         * Scripts/test-webkitpy:
1738         * Scripts/webkitpy/common/system/executive_unittest.py:
1739         (script_dir):
1740         (ExecutiveTest.setUp):
1741         (ExecutiveTest):
1742         (ExecutiveTest.tearDown):
1743
1744 2012-01-25  Adam Barth  <abarth@webkit.org>
1745
1746         Disable tests on the mac-ews while we sort out hte stability issues.
1747
1748         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1749         (MacEWS):
1750
1751 2012-01-23  Dirk Pranke  <dpranke@chromium.org>
1752
1753         investigate use of 'mac' and 'win' as fully-specified port names for the apple ports
1754         https://bugs.webkit.org/show_bug.cgi?id=76475
1755
1756         Reviewed by Eric Seidel.
1757
1758         This patch cleans up the internal usage of port names for the
1759         Apple mac and Apple win ports so that 'mac' and 'win are never
1760         considered "fully specified" port names: they are still legal
1761         input to the PortFactory.get() routine, but only if run on the given
1762         platform (i.e. trying to PortFactory.get('mac') on windows or
1763         linux will return an error, since we don't know which version of
1764         the port is desired.
1765
1766         This also cleans up handling of the webkit2 variants, so that
1767         the full port names consistently follow the
1768         <operating_system>-<version>[-<wk2>] convention.
1769
1770         Lastly this patch adds some assertions and removes some
1771         try/catch logic to catch more programming and usage errors;
1772         previously mac-tiger might've been allowed -- and it would've
1773         translated into using just the baselines in platform/mac -- but
1774         now it should fail.
1775
1776         * Scripts/webkitpy/layout_tests/port/apple.py:
1777         (ApplePort.determine_full_port_name):
1778         (ApplePort.__init__):
1779         (ApplePort):
1780         (ApplePort._port_name_with_version):
1781         * Scripts/webkitpy/layout_tests/port/builders.py:
1782         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1783         (FactoryTest.test_mac):
1784         (FactoryTest.test_win):
1785         * Scripts/webkitpy/layout_tests/port/mac.py:
1786         (MacPort.baseline_search_path):
1787         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1788         (MacTest.test_versions):
1789         * Scripts/webkitpy/layout_tests/port/win.py:
1790         (WinPort.baseline_search_path):
1791         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1792         (WinTest.test_versions):
1793
1794 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1795
1796         webkitpy: print nicer errors while linting expectations files, remove redundant tests
1797         https://bugs.webkit.org/show_bug.cgi?id=76955
1798
1799         Reviewed by Adam Barth.
1800
1801         This change cleans up the errors that are printed so that the
1802         are more "quickfix" compatible (path:lineno).
1803
1804         Also, there were a bunch of redundant tests between
1805         layout_tests.models.test_expectations_unittest and
1806         style.checkers.test_expectations_unittest. The latter should
1807         just expect the former to do most of the testing.
1808
1809         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1810         (TestExpectationParser._parse_modifiers):
1811         (TestExpectations._report_errors):
1812         (TestExpectations._add_skipped_tests):
1813         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1814         (test_parse_error_nonfatal):
1815         (SemanticTests.test_bad_bugid):
1816         * Scripts/webkitpy/style/checkers/test_expectations.py:
1817         (TestExpectationsChecker.__init__):
1818         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1819         (TestExpectationsTestCase.assert_lines_lint):
1820         (TestExpectationsTestCase.test_valid_expectations):
1821         (TestExpectationsTestCase.test_invalid_expectations):
1822         (TestExpectationsTestCase.test_tab):
1823
1824 2012-01-25  Eric Seidel  <eric@webkit.org>
1825
1826         webkit-patch apply-* should always continue after failures
1827         https://bugs.webkit.org/show_bug.cgi?id=77057
1828
1829         Reviewed by Adam Barth.
1830
1831         As far as I can tell there is only one potential drawback to always
1832         forcing: that if you're somehow in the wrong directory it will create new
1833         directories for new files.  Since webkit-patch always cd's to the root
1834         it seems that's not a drawback.  The drawback of not using --force for
1835         svn-apply, is that it will stop after the first failure, which is rarely
1836         (if ever) the desired behavior.  This just removes the force option
1837         (which was strangely hidden behind --non-interactive).  This should
1838         make for a better user experiance.
1839
1840         * Scripts/webkitpy/common/checkout/checkout.py:
1841         (Checkout.apply_patch):
1842         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1843         (MockCheckout.apply_patch):
1844         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1845         (CheckoutTest.test_chromium_deps):
1846         (CheckoutTest):
1847         (CheckoutTest.test_apply_patch):
1848         * Scripts/webkitpy/tool/commands/download_unittest.py:
1849         (DownloadCommandsTest._default_options):
1850         * Scripts/webkitpy/tool/steps/applypatch.py:
1851         (ApplyPatch.options):
1852         (ApplyPatch.run):
1853         * Scripts/webkitpy/tool/steps/options.py:
1854         (Options):
1855
1856 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1857
1858         nrwt: should be able to run --platform test interactively
1859         https://bugs.webkit.org/show_bug.cgi?id=76959
1860
1861         Reviewed by Adam Barth.
1862
1863         As part of refactoring the Port interfaces, in r103254 I made
1864         passing a Host object to the Port mandatory; previously TestPort
1865         objects would create their own (mock) hosts. However,
1866         new-run-webkit-tests always passed a real Host, not a MockHost,
1867         and so you couldn't run new-run-webkit-tests --platform test
1868         interactively to debug test failures.
1869
1870         This change fixes that by creating a MockHost instead of a real
1871         host if you say --platform test*.
1872
1873         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1874         (main):
1875
1876 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1877
1878         run-webkit-tests --lint-test-files should lint all the ports by default
1879         https://bugs.webkit.org/show_bug.cgi?id=76749
1880
1881         Reviewed by Ojan Vafai.
1882
1883         Currently run-webkit-tests --lint-test-files will only lint the
1884         test_expectations for the single port determined by the command
1885         line options. This is not obvious and can produce unintended results
1886         if you want to lint the chromium port (probably the normal case
1887         for using --lint-test-files) but don't specify a port name or
1888         --chromium.
1889
1890         I think we should probably lint *all* of the ports if no port
1891         name is supplied. This change implements that, and also moves
1892         the linting logic out of the Manager class, since this really
1893         has nothing to do with Managers. It has little to do with
1894         run-webkit-tests, but splitting it into a different script would
1895         introduce compatibility issues. It might make sense to do that
1896         anyway, in a separate patch and combining that with cleaning up
1897         the style checker to share more code.
1898
1899         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1900         (Manager._strip_test_dir_prefix):
1901         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1902         (lint):
1903         (run):
1904         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1905         (LintTest.test_all_configurations): added.
1906         (LintTest.test_lint_test_files): added.
1907         (LintTest.test_lint_test_files__errors): added.
1908         (MainTest.test_lint_test_files): removed.
1909         (MainTest.test_lint_test_files__errors): removed.
1910
1911 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1912
1913         webkitpy: clean up a bunch of test scaffolding
1914         https://bugs.webkit.org/show_bug.cgi?id=76973
1915
1916         Reviewed by Eric Seidel.
1917
1918         There were several helper modules in the webkitpy.test package
1919         that appear to only be used by executive_unittest.py. I am
1920         rolling them all into that file to make that clearer.
1921
1922         * Scripts/webkitpy/common/system/executive_unittest.py:
1923         (ExecutiveTest.test_run_command_args_type):
1924         (ExecutiveTest.test_run_command_with_unicode):
1925         (ExecutiveTest.test_running_pids):
1926         (command_line):
1927         (main):
1928         * Scripts/webkitpy/common/system/fileutils.py: Removed.
1929         * Scripts/webkitpy/test/cat.py: Removed.
1930         * Scripts/webkitpy/test/cat_unittest.py: Removed.
1931         * Scripts/webkitpy/test/echo.py: Removed.
1932         * Scripts/webkitpy/test/echo_unittest.py: Removed.
1933
1934 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1935
1936         webkitpy: clean up a bunch of test scaffolding
1937         https://bugs.webkit.org/show_bug.cgi?id=76973
1938
1939         Reviewed by Eric Seidel.
1940
1941         There were several helper modules in the webkitpy.test package
1942         that appear to only be used by executive_unittest.py. I am
1943         rolling them all into that file to make that clearer.
1944
1945         * Scripts/webkitpy/common/system/executive_unittest.py:
1946         (ExecutiveTest.test_run_command_args_type):
1947         (ExecutiveTest.test_run_command_with_unicode):
1948         (ExecutiveTest.test_running_pids):
1949         (command_line):
1950         (main):
1951         * Scripts/webkitpy/common/system/fileutils.py: Removed.
1952         * Scripts/webkitpy/test/cat.py: Removed.
1953         * Scripts/webkitpy/test/cat_unittest.py: Removed.
1954         * Scripts/webkitpy/test/echo.py: Removed.
1955         * Scripts/webkitpy/test/echo_unittest.py: Removed.
1956
1957 2012-01-25  Eric Seidel  <eric@webkit.org>
1958
1959         Remove Python 2.5 support from WebKit
1960         https://bugs.webkit.org/show_bug.cgi?id=71593
1961
1962         Reviewed by Adam Barth.
1963
1964         Just removing support from this one core file.
1965         I'll commit the rest of the (large) change once we've
1966         gone 24 hours and seen that no bots have exploded.
1967         We can roll out this one change if we break bots
1968         and then roll in the rest once those bots are fixed.
1969
1970         * Scripts/webkitpy/common/system/executive.py:
1971         (Executive.cpu_count):
1972
1973 2012-01-25  Hajime Morita  <morrita@google.com>
1974
1975         ENABLE_SHADOW_DOM should be available via build-webkit --shadow-dom
1976         https://bugs.webkit.org/show_bug.cgi?id=76863
1977
1978         Reviewed by Dimitri Glazkov.
1979
1980         Added a feature flag.
1981
1982         * Scripts/build-webkit:
1983         * qmake/mkspecs/features/features.prf:
1984
1985 2012-01-25  Martin Robinson  <mrobinson@igalia.com>
1986
1987         [WK2] Navigation events not triggered by a mouse event claim to be triggered by the left mouse button during policy decisions
1988         https://bugs.webkit.org/show_bug.cgi?id=76344
1989
1990         Reviewed by Sam Weinig.
1991
1992         Add a test verifying that the mouse button during policy decisions for
1993         events not triggered by mouse events is NoButton.
1994
1995         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1996         (TestWebKitAPI::decidePolicyForNavigationAction): Added test.
1997         (TestWebKitAPI::decidePolicyForNewWindowAction): Added test.
1998
1999 2012-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2000
2001         run-perf-tests should timeout sooner
2002         https://bugs.webkit.org/show_bug.cgi?id=77026
2003
2004         Reviewed by Adam Barth.
2005
2006         Bump off the timeout from 10 minutes to 4 minutes.
2007
2008         Also use float instead of str in test result values to compress the size of json files bots upload.
2009
2010         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2011         (PerfTestsRunner._parse_args):
2012         (PerfTestsRunner._process_chromium_style_test_result):
2013         (PerfTestsRunner._process_parser_test_result):
2014         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2015         (test_run_test_set_for_parser_tests):
2016         (test_run_test_set_with_json_output):
2017         (test_run_test_set_with_json_source):
2018
2019 2012-01-25  Enrica Casucci  <enrica@apple.com>
2020
2021         WebView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
2022         https://bugs.webkit.org/show_bug.cgi?id=76951
2023         <rdar://problem/9325158>
2024
2025         Reviewed by Alexey Proskuryakov.
2026
2027         * TestWebKitAPI/Tests/mac/InspectorBar.mm: Modified to reflect the changes to WebView
2028         and WebHTMLView.
2029         (TestWebKitAPI::TEST):
2030
2031 2012-01-23  MORITA Hajime  <morrita@google.com>
2032
2033         [Refactoring][Internals] Should have InternalSettings
2034         https://bugs.webkit.org/show_bug.cgi?id=76424
2035
2036         Reviewed by Kent Tamura.
2037
2038         * GNUmakefile.am: Added so new files.
2039
2040 2012-01-25  Takashi Toyoshima  <toyoshim@chromium.org>
2041
2042         webkitpy: new-run-webkit-websocket is broken
2043         https://bugs.webkit.org/show_bug.cgi?id=76999
2044
2045         Reviewed by Dirk Pranke.
2046
2047         r105674 broke new-run-webkit-websocket, since options.chromium
2048         doesn't exist any more. new-run-webkit-httpd was also broken
2049         and already fixed at r105835.
2050         * Scripts/new-run-webkit-websocketserver:
2051         (main):
2052
2053 2012-01-25  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
2054
2055         [WK2] WebKitTestRunner needs layoutTestController.setPopupBlockingEnabled
2056         https://bugs.webkit.org/show_bug.cgi?id=63458
2057
2058         Reviewed by Adam Roben.
2059
2060         Implement the setPopupBlockingEnabled method.
2061
2062         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2063         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2064         (WTR::LayoutTestController::setPopupBlockingEnabled):
2065         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2066
2067 2012-01-24  Balazs Kelemen  <kbalazs@webkit.org>
2068
2069         [Qt] Cleanup testfonts handling
2070         https://bugs.webkit.org/show_bug.cgi?id=76068
2071
2072         Reviewed by Simon Hausmann.
2073
2074         Factor test font initialization into it's own file  so test
2075         font users can share the implementation by adding the file
2076         to their build.
2077         Use fonts.conf from the test font directory to not require the
2078         current directory to be the WebKit root.
2079         Fix the -use-test-fonts option of QtTestBrowser by initializing
2080         the fonts earlier, before it is too late (namely before calling
2081         show on the main window).
2082
2083         * DumpRenderTree/qt/DumpRenderTree.pro:
2084         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2085         (WebCore::DumpRenderTree::open):
2086         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2087         * DumpRenderTree/qt/QtInitializeTestFonts.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
2088         (WebKit::initializeTestFonts):
2089         * DumpRenderTree/qt/QtInitializeTestFonts.h: Added.
2090         * DumpRenderTree/qt/fonts.conf: Removed. No need for this since
2091         we will use the one from the test fonts directory.
2092         * DumpRenderTree/qt/main.cpp:
2093         (main): Fix the ifdefs to make it clear that the code to
2094         set up the Dpi has not been ported to Qt5 yet.
2095         * QtTestBrowser/QtTestBrowser.pro:
2096         * QtTestBrowser/launcherwindow.h:
2097         (WindowOptions::WindowOptions):
2098         * QtTestBrowser/main.cpp:
2099         (launcherMain):
2100         (LauncherApplication::handleUserOptions):
2101         * WebKitTestRunner/InjectedBundle/Target.pri:
2102         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2103         (WTR::activateFonts): Remove the code to set up the Dpi
2104         because it does not work with Qt5.
2105
2106 2012-01-25  Simon Hausmann  <simon.hausmann@nokia.com>
2107
2108         [Qt] build-webkit --qt requires a git-svn or SVN checkout.
2109
2110         Reviewed by Tor Arne Vestø.
2111
2112         Don't require it by making svnRevisionForDirectory return "unknown"
2113         instead of bailing out with an error.
2114
2115         * Scripts/VCSUtils.pm:
2116         (svnRevisionForDirectory):
2117
2118 2012-01-25  Adam Barth  <abarth@webkit.org>
2119
2120         Temporarily disable running the unit tests on the Chromium EWS.  These
2121         tests don't work properly (see
2122         https://bugs.webkit.org/show_bug.cgi?id=76979) and are currently
2123         blocking the EWS.
2124
2125         * Scripts/webkitpy/common/config/ports.py:
2126         (ChromiumPort):
2127
2128 2012-01-25  Adam Barth  <abarth@webkit.org>
2129
2130         Update results.html version of PixelZoomer
2131         https://bugs.webkit.org/show_bug.cgi?id=76965
2132
2133         Reviewed by Ojan Vafai.
2134
2135         Improve readability as suggested by Ojan.
2136
2137         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:
2138
2139 2012-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2140
2141         [GTK] Page clients don't need to be GObjects anymore in WebKit2 GTK+ API
2142         https://bugs.webkit.org/show_bug.cgi?id=76899
2143
2144         Reviewed by Martin Robinson.
2145
2146         * gtk/generate-gtkdoc:
2147         (get_webkit2_options): WebKitWebLoaderClient has been renamed to
2148         WebKitLoaderClient.
2149
2150 2012-01-24  Ryosuke Niwa  <rniwa@webkit.org>
2151
2152         Build fix. Trigger Chromium Mac Release (Perf) on new commits.
2153
2154         * BuildSlaveSupport/build.webkit.org-config/config.json:
2155
2156 2012-01-23  Ryosuke Niwa  <rniwa@webkit.org>
2157
2158         WebKit needs public performance tests running on public bots
2159         https://bugs.webkit.org/show_bug.cgi?id=10266
2160
2161         Reviewed by Adam Barth.
2162
2163         Completes the initial implementation of WebKit Perf bots. Add a build step for run-perf-test
2164         and make google-mac-4 run it, and upload the results to webkit-perf.webkit.org.
2165
2166         * BuildSlaveSupport/build.webkit.org-config/config.json:
2167         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2168         (RunAndUploadPerfTests):
2169         (RunAndUploadPerfTests.start):
2170         (UploadPerfTestResults):
2171         (BuildAndPerfTestFactory):
2172         (BuildAndPerfTestFactory.__init__):
2173
2174 2012-01-24  Ojan Vafai  <ojan@chromium.org>
2175
2176         Initializing the browser property of the Bugzilla class takes too long
2177         https://bugs.webkit.org/show_bug.cgi?id=76960
2178
2179         Reviewed by Adam Barth.
2180
2181         Lazily initialize it. This saves ~150ms on a no-op run-webkit-tests call
2182         on my Mac Pro.
2183
2184         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2185         (Bugzilla.__init__):
2186         (Bugzilla._get_browser):
2187         (Bugzilla):
2188         (Bugzilla._set_browser):
2189
2190 2012-01-24  Mark Rowe  <mrowe@apple.com>
2191
2192         Death to JavaScriptGlue.
2193
2194         Rubber-stamped by Geoffrey Garen.
2195
2196         * BuildSlaveSupport/build-launcher-app:
2197         (copyNightlyLauncher):
2198         * Scripts/build-webkit:
2199         * Scripts/do-file-rename:
2200         * Scripts/do-webcore-rename:
2201         * Scripts/webkitpy/common/config/build.py:
2202         (_should_file_trigger_build):
2203         * Scripts/webkitpy/common/config/build_unittest.py: Update the test to use another Mac-specific
2204         path in conjunction with a cross-platform path.
2205         (ShouldBuildTest):
2206
2207 2012-01-24  Kentaro Hara  <haraken@chromium.org>
2208
2209         webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl should test stdout and stderr
2210         https://bugs.webkit.org/show_bug.cgi?id=75836
2211
2212         Reviewed by David Kilzer.
2213
2214         Previously parser_unittests.pl can just test the returned value of
2215         get_function_line_ranges() in prepare-ChangeLog. This patch fixes
2216         parser_unittests.pl so that it also tests the stdout and stderr of
2217         get_function_line_ranges().
2218
2219         This patch adds css_unittests_warning.css, which contains test cases
2220         for warning messages of the CSS parser of prepare-ChangeLog.
2221
2222         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2223         (captureOutput): Captures the stdout and stderr of a given method.
2224         (convertAbsolutepathToWebKitPath): Converts absolute paths in a given
2225         string to relative paths.
2226
2227         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt: Added.
2228         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css: Added.
2229         (element1):
2230         (element2):
2231         (element3):
2232         (element4):
2233         ():
2234         (element5):
2235         (element6):
2236
2237         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
2238         Just updated the test results, i.e. added stdout and stderr results.
2239         No essential changes in the test results.
2240         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Ditto.
2241         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests-expected.txt: Ditto.
2242         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Ditto.
2243         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt: Ditto.
2244         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt: Ditto.
2245
2246 2012-01-24  Dirk Pranke  <dpranke@chromium.org>
2247
2248         webkitpy: new-run-webkit-httpd is broken
2249         https://bugs.webkit.org/show_bug.cgi?id=76963
2250
2251         Reviewed by Adam Barth.
2252
2253         r105674 broke new-run-webkit-httpd, since options.chromium
2254         doesn't exist any more. We didn't catch this because we don't
2255         run the integration tests by default anywhere :(.
2256
2257         * Scripts/new-run-webkit-httpd:
2258         (run):
2259         (main):
2260
2261 2012-01-24  Adam Barth  <abarth@webkit.org>
2262
2263         garden-o-matic pixel zoomer should let you look at every pixel of the image
2264         https://bugs.webkit.org/show_bug.cgi?id=76962
2265
2266         Reviewed by Ojan Vafai.
2267
2268         Previously, you couldn't get up to the right and bottom pixels.
2269
2270         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:
2271
2272 2012-01-24  Enrica Casucci  <enrica@apple.com>
2273
2274         WebHTMLView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
2275         https://bugs.webkit.org/show_bug.cgi?id=76951
2276         <rdar://problem/9325158>
2277
2278         Added test to verify that WebHTMLView supports the typingAttributes method and that it
2279         works as expected.
2280         
2281         Reviewed by Alexey Proskuryakov.
2282
2283         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
2284         (TestWebKitAPI::TEST):
2285
2286 2012-01-24  James Robinson  <jamesr@chromium.org>
2287
2288         Put a space between the trac link and ellipsis in sheriffbot rollout message so it linkifies better in some IRC clients
2289         https://bugs.webkit.org/show_bug.cgi?id=76884
2290
2291         Reviewed by Adam Barth.
2292
2293         * Scripts/webkitpy/tool/bot/irc_command.py:
2294         (Rollout.execute):
2295         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2296         (SheriffIRCBotTest.test_rollout):
2297         (SheriffIRCBotTest.test_revert):
2298         (SheriffIRCBotTest.test_multi_rollout):
2299         (SheriffIRCBotTest.test_rollout_with_r_in_svn_revision):
2300         (SheriffIRCBotTest.test_multi_rollout_with_r_in_svn_revision):
2301         (SheriffIRCBotTest.test_rollout_invalidate_reason):
2302         (test_multi_rollout_invalidate_reason):
2303
2304 2012-01-24  Kentaro Hara  <haraken@chromium.org>
2305
2306         The cpp parser of prepare-ChangeLog cannot detect a change in classes and namespaces
2307         https://bugs.webkit.org/show_bug.cgi?id=75531
2308
2309         Reviewed by David Kilzer.
2310
2311         Previously, the cpp parser of prepare-ChangeLog could not detect a change
2312         outside methods. Consider the following cpp file.
2313
2314             namespace N {
2315             int a;     // this change does not appear on ChangeLog.
2316             class C {
2317                 int b;     // this change does not appear on ChangeLog.
2318                 void f()
2319                 {
2320                     int c;     // this change appears on ChangeLog.
2321                 }
2322                 int d;     // this change does not appear on ChangeLog.
2323             };
2324             int e;     // this change does not appear on ChangeLog.
2325             };
2326
2327         The previous prepare-ChangeLog outputs just methods in which a change is found:
2328             (N::C::f):
2329
2330         This patch fixes prepare-ChangeLog so that it outputs namespaces, classes
2331         and methods in which a change is found:
2332             (N):
2333             (N::C):
2334             (N::C::f):
2335
2336         * Scripts/prepare-ChangeLog:
2337         (get_function_line_ranges_for_cpp): Modified as described above.
2338
2339         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases.
2340         (Class104):
2341         (Class105):
2342         (Class106):
2343         (Class106::func32):
2344         (Class106::func33):
2345         (NameSpace3):
2346         (NameSpace4):
2347         (NameSpace5):
2348         (NameSpace6):
2349         (Class107):
2350         (NameSpace5::NameSpace6::Class107::func34):
2351         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
2352
2353 2012-01-24  Kentaro Hara  <haraken@chromium.org>
2354
2355         prepare-ChangeLog outputs warnings for top-level { ... } blocks
2356         https://bugs.webkit.org/show_bug.cgi?id=75943
2357
2358         Reviewed by David Kilzer.
2359
2360         Currently, prepare-ChangeLog outputs warnings for top-level { ... } blocks,
2361         because it does not distinguish '}' at the end of a subroutine
2362         with '}' at the end of a if or for statement.
2363
2364         foo.pl:
2365             if (1) {
2366             }
2367             for (@v) {
2368             }
2369
2370         output:
2371             nested functions found at top-level at foo.pl:2
2372             nested functions found at top-level at foo.pl:4
2373
2374         This patch fixes the bug.
2375
2376         * Scripts/prepare-ChangeLog:
2377         (get_function_line_ranges_for_perl):
2378         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
2379         Added test cases. No change in the test results.
2380
2381 2012-01-24  Dirk Pranke  <dpranke@chromium.org>
2382
2383         r105674 broke check-webkit-style for chromium's test_expectations.
2384
2385         Unreviewed, build fix.
2386         
2387         We now need to pass in a platform name of 'chromium' if we want
2388         the chromium port; options.chromium is no longer recognized. I
2389         will follow this patch up with a separate patch that has a test,
2390         but this at least fixes the build.
2391
2392         * Scripts/webkitpy/style/checkers/test_expectations.py:
2393         (TestExpectationsChecker._determine_port_from_exepectations_path):
2394
2395 2012-01-20  Ojan Vafai  <ojan@chromium.org>
2396
2397         check-webkit-style of the chromium test_expectations.txt file takes too long
2398         https://bugs.webkit.org/show_bug.cgi?id=76745
2399
2400         Reviewed by Dimitri Glazkov.
2401
2402         When in lint mode, have TestExpectations test all configurations instead
2403         of looping over each configuration. This also has the benefit of making
2404         the error output considerably more concise.
2405
2406         Also, got rid of the double-printing of errors when linting through check-webkit-style.
2407
2408         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2409         (Manager.lint):
2410         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2411         (TestExpectations._report_errors):
2412         (TestExpectations._add_expectations):
2413         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2414         (test_parse_error_nonfatal):
2415         (test_error_on_different_platform):
2416         * Scripts/webkitpy/style/checkers/test_expectations.py:
2417         (TestExpectationsChecker.check_test_expectations):
2418         (TestExpectationsChecker.check):
2419         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2420         (TestExpectationsTestCase.test_determine_port_from_exepectations_path):
2421         (TestExpectationsTestCase.assert_lines_lint):
2422
2423 2012-01-24  Ryosuke Niwa  <rniwa@webkit.org>
2424
2425         Another build fix attempt after r105543.
2426
2427         * Scripts/webkitpy/common/net/file_uploader.py:
2428         (FileUploader.upload_as_multipart_form_data):
2429
2430 2012-01-24  Ryosuke Niwa  <rniwa@webkit.org>
2431
2432         Build fix attempt after r105543.
2433
2434         * Scripts/webkitpy/common/net/file_uploader.py:
2435         (FileUploader.upload_as_multipart_form_data):
2436
2437 2012-01-24  Vincent Scheib  <scheib@chromium.org>
2438
2439         [Chromium] Add Pointer Lock test hooks and mock implementation to DumpRenderTree
2440         https://bugs.webkit.org/show_bug.cgi?id=76411
2441
2442         Reviewed by Adam Barth.
2443
2444         Breaking up https://bugs.webkit.org/show_bug.cgi?id=75762
2445         into a series of patches, this change adds a trivial
2446         pointer lock implementation to the Chromium port's DumpRenderTree
2447         and exposes LayoutTestController hooks to force failure conditions.
2448
2449         * DumpRenderTree/chromium/LayoutTestController.cpp:
2450         (LayoutTestController::LayoutTestController):
2451         (LayoutTestController::didLosePointerLock):
2452         (LayoutTestController::setPointerLockWillFailAsynchronously):
2453         (LayoutTestController::setPointerLockWillFailSynchronously):
2454         * DumpRenderTree/chromium/LayoutTestController.h:
2455         * DumpRenderTree/chromium/WebViewHost.cpp:
2456         (WebViewHost::requestPointerLock):
2457         (WebViewHost::requestPointerUnlock):
2458         (WebViewHost::isPointerLocked):
2459         (WebViewHost::didCompletePointerLock):
2460         (WebViewHost::didNotCompletePointerLock):
2461         (WebViewHost::didLosePointerLock):
2462         (WebViewHost::reset):
2463         * DumpRenderTree/chromium/WebViewHost.h:
2464         (WebViewHost::setPointerLockWillFailAsynchronously):
2465         (WebViewHost::setPointerLockWillFailSynchronously):
2466
2467 2012-01-24  Mario Sanchez Prada  <msanchez@igalia.com>
2468
2469         Unreviewed, skip WK2 API test timing out on some GTK bots.
2470
2471         WebKit2APITests/TestDownloads is consistently timing out on the
2472         32bit release and 64bit debug bots.
2473
2474         * Scripts/run-gtk-tests:
2475         (TestRunner): Skip WebKit2APITests/TestDownloads.
2476
2477 2012-01-24  Andras Becsi  <andras.becsi@nokia.com>
2478
2479         [Qt] Fix the build with the newes Qt5 hashes
2480         https://bugs.webkit.org/show_bug.cgi?id=76657
2481
2482         Reviewed by Simon Hausmann.
2483
2484         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2485         (MiniBrowserApplication::MiniBrowserApplication): Disable the automatic touch->mouse event synthesis
2486         for now to prevent an infinite loop where Qt always creates mouse events out of our touch mock events.
2487
2488 2012-01-24  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2489
2490         [Qt] Distinguish between Cygwin and cmd.exe in the way we set env variables
2491
2492         We can't use win32-msvc* to decide whether or not to use (set FOO=bar), as
2493         building with MinGW inside cmd.exe will require the same construct. Instead
2494         we assume that when the first character in PWD is a '/' we're running under
2495         Cygwin, and use the normal unix way of setting environment variables.
2496
2497         Reviewed by Simon Hausmann.
2498
2499         * qmake/mkspecs/features/default_pre.prf:
2500
2501 2012-01-24  Simon Hausmann  <simon.hausmann@nokia.com>
2502
2503         Some qmake build files must include Qt5's "quick" module.
2504         https://bugs.webkit.org/show_bug.cgi?id=76671
2505
2506         Unreviewed build fix.
2507
2508         * MiniBrowser/qt/MiniBrowser.pro:
2509         * WebKitTestRunner/Target.pri:
2510
2511 2012-01-24  Andras Becsi  <andras.becsi@nokia.com>
2512
2513         [Qt] Fix the event timestamps for touch mocking
2514
2515         Reviewed by Simon Hausmann.
2516
2517         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2518         (MiniBrowserApplication::sendTouchEvent): We should not set QEvent::None as the
2519         timestamp argument in the QWindowSystemInterface::handleTouchEvent call.
2520
2521 2012-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2522
2523         [GTK] Implement DownloadClient in WebKit2 GTK+ API
2524         https://bugs.webkit.org/show_bug.cgi?id=72952
2525
2526         Reviewed by Martin Robinson.
2527
2528         * gtk/generate-gtkdoc:
2529         (get_webkit2_options): Ignore WebKitDownloadClient.
2530
2531 2012-01-23  Zan Dobersek  <zandobersek@gmail.com>
2532
2533         [GTK] editing/deleting/5408255.html results are incorrect
2534         https://bugs.webkit.org/show_bug.cgi?id=53644
2535
2536         Reviewed by Martin Robinson.
2537
2538         WEBKIT_TOP_LEVEL environment variable is now set directly in either
2539         WebKitTestRunner or DumpRenderTree through usage of a compilation-time
2540         macro. This way both tools can be run outside the test harness without
2541         the need to manually set the environment variable.
2542
2543         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2544         (getTopLevelPath):
2545         * GNUmakefile.am:
2546         * Scripts/webkitpy/layout_tests/port/gtk.py:
2547         (GtkPort.setup_environ_for_server):
2548         * WebKitTestRunner/GNUmakefile.am:
2549         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
2550         (WTR::InjectedBundle::platformInitialize):
2551
2552 2012-01-23  Dmitry Lomov  <dslomov@google.com>
2553
2554         [Chromium] Implement layoutTestController.workerThreadCount in DRT
2555         https://bugs.webkit.org/show_bug.cgi?id=74653.
2556
2557         Reviewed by Darin Fisher.
2558
2559         * DumpRenderTree/chromium/LayoutTestController.cpp:
2560         (LayoutTestController::LayoutTestController):
2561         (LayoutTestController::workerThreadCount):
2562         * DumpRenderTree/chromium/LayoutTestController.h:
2563
2564 2012-01-23  Dirk Pranke  <dpranke@chromium.org>
2565
2566         nrwt: make --chromium work like --qt
2567         https://bugs.webkit.org/show_bug.cgi?id=76875
2568
2569         Reviewed by Adam Barth.
2570
2571         --chromium used to have to be handled differently from --qt
2572         due to the way the PortFactory was implemented; there's not
2573         really a good reason for that any more so this patch makes
2574         things slightly more consistent and eliminates the
2575         options.chromium flag (--chromium is now truly a synonym for
2576         --platform chromium).
2577
2578         * Scripts/webkitpy/layout_tests/port/factory.py:
2579         (PortFactory._default_port):
2580         (PortFactory.get):
2581         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2582         (FactoryTest.setUp):
2583         (FactoryTest.test_chromium_mac):
2584         (FactoryTest.test_chromium_linux):
2585         (FactoryTest.test_chromium_win):
2586         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2587         (parse_args):
2588
2589 2012-01-23  Dirk Pranke  <dpranke@chromium.org>
2590
2591         run-webkit-tests needs to propagate --chromium
2592         https://bugs.webkit.org/show_bug.cgi?id=76870
2593
2594         Reviewed by Eric Seidel.
2595
2596         run-webkit-tests removes '--chromium' argument from @ARGV when
2597         determining which port to run, which means that that doesn't
2598         propagate to new-run-webkit-tests. That's bad (and is handled
2599         for the other ports by re-adding the flag, but apparently we're
2600         just now noticing for Chromium).
2601
2602         * Scripts/run-webkit-tests:
2603
2604 2012-01-23  Brian Weinstein  <bweinstein@apple.com>
2605
2606         More build fixing after r105646.
2607
2608         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2609         (TestWebKitAPI::TestNode::key):
2610
2611 2012-01-23  Gavin Barraclough  <barraclough@apple.com>
2612
2613         Unreviewed build fix - r105646 broke this.
2614
2615         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2616         (TestWebKitAPI::TestNode::TestNode):
2617         (TestWebKitAPI::TestNode::key):
2618         (TestWebKitAPI::RedBlackTreeTest::assertEqual):
2619         (TestWebKitAPI::RedBlackTreeTest::assertSameValuesForKey):
2620         (TestWebKitAPI::RedBlackTreeTest::testDriver):
2621
2622 2012-01-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2623
2624         Unreviewed, rolling out r105658.
2625         http://trac.webkit.org/changeset/105658
2626         https://bugs.webkit.org/show_bug.cgi?id=76883
2627
2628         We want this eventually, but not right at this moment
2629         (Requested by abarth on #webkit).
2630
2631         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2632
2633 2012-01-23  Adam Barth  <abarth@webkit.org>
2634
2635         garden-o-matic should support Chromium Mac Lion
2636         https://bugs.webkit.org/show_bug.cgi?id=76880
2637
2638         Reviewed by Eric Seidel.
2639
2640         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2641
2642 2012-01-23  Emil A Eklund  <eae@chromium.org>
2643
2644         check-webkit-style whitespace/operators triggers on overloaded division operator
2645         https://bugs.webkit.org/show_bug.cgi?id=76650
2646
2647         Reviewed by Darin Adler.
2648
2649         * Scripts/webkitpy/style/checkers/cpp.py:
2650         (check_spacing):
2651         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2652         (CppStyleTest.test_operator_methods):
2653
2654 2012-01-23  Ryosuke Niwa  <rniwa@webkit.org>
2655
2656         run-perf-tests should report server-side errors
2657         https://bugs.webkit.org/show_bug.cgi?id=76802
2658
2659         Reviewed by Tony Chang.
2660
2661         Report errors whenever server's response doesn't match "OK".
2662
2663         * Scripts/webkitpy/common/net/file_uploader.py:
2664         (FileUploader.upload_single_text_file):
2665         (FileUploader.upload_as_multipart_form_data):
2666         (FileUploader._upload_data.callback):
2667         (FileUploader):
2668         (FileUploader._upload_data):
2669         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2670         (PerfTestsRunner._upload_json):
2671         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2672         (test_upload_json):
2673         (test_upload_json.MockFileUploader.upload_single_text_file):
2674
2675 2012-01-22  Ryosuke Niwa  <rniwa@webkit.org>
2676
2677         run-perf-tests ignore Skipped list on chromium
2678         https://bugs.webkit.org/show_bug.cgi?id=76764
2679
2680         Reviewed by Dirk Pranke.
2681
2682         Move skipped_perf_tests from WebKit port to Base port so that Chromium port
2683         can also find skipped list. Chromium port only uses test_expectations.txt for
2684         layout tests but performacne tests don't use test_expectations.txt so Chromium port
2685         also needs to use Skipped list.
2686
2687         * Scripts/webkitpy/layout_tests/port/base.py:
2688         (Port._tests_from_skipped_file_contents):
2689         (Port):
2690         (Port._expectations_from_skipped_files):
2691         (Port.skipped_perf_tests):
2692         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2693         (PortTest.test_skipped_perf_tests):
2694         (PortTest.test_skipped_perf_tests.add_text_file):
2695         * Scripts/webkitpy/layout_tests/port/webkit.py:
2696         (WebKitPort._skipped_tests_for_unsupported_features):
2697         (WebKitPort._skipped_file_search_paths):
2698         (WebKitPort.skipped_layout_tests):
2699
2700 2012-01-23  Andy Estes  <aestes@apple.com>
2701
2702         Fix the build after r105635.
2703
2704         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2705         (TestWebKitAPI::TEST):
2706
2707 2012-01-23  Xianzhu Wang  <wangxianzhu@chromium.org>
2708
2709         Basic enhancements to StringBuilder
2710         https://bugs.webkit.org/show_bug.cgi?id=67081
2711
2712         Reviewed by Darin Adler.
2713
2714         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2715         (TestWebKitAPI::TEST):
2716
2717 2012-01-23  Mario Sanchez Prada  <msanchez@igalia.com>
2718
2719         [GTK] run-gtk-tests randomly fails while running the xprop comand
2720         https://bugs.webkit.org/show_bug.cgi?id=76817
2721
2722         Reviewed by Gustavo Noronha Silva.
2723
2724         No need to use xprop to remove the AT_SPI_BUS property since
2725         run-gtk-tests will always run new instances of Xvfb.
2726
2727         * Scripts/run-gtk-tests:
2728         (TestRunner): Unskip TestWebKitAccessibility.
2729         (TestRunner.run): Uncomment lines for launching the accessibility
2730         bus and registry daemon, and remove lines for running xprop.
2731
2732 2012-01-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2733
2734         [Qt] Don't warn about override and final being C++11 extensions
2735
2736         Clang will emit a warning when these extensions are used without passing
2737         --std=c++11, but we use feature checking to decide if we have the right
2738         extensions, so we can safely ignore these warnings. The XCode and Windows
2739         project files have the same workaround.
2740
2741         The reason for adding the flag to QMAKE_OBJECTIVE_CFLAGS as well is that
2742         we only have one extra compiler for Objective-C, which is also used for
2743         Objective-C++ sources, so we have to pass the flag, even if it doesn't
2744         make sense for Objective-C.
2745
2746         Reviewed by Simon Hausmann.
2747
2748         * qmake/mkspecs/features/unix/default_post.prf:
2749
2750 2012-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2751
2752         [Qt] Change how build-webkit decides when to do full incremental builds
2753
2754         Instead of relying on update-webkit (which isn't run on the bots) to
2755         decide when to do a full incremental build (make qmake), we let the
2756         build-webkit script itself check the current SVN revision against the
2757         previous build (by storing it in .webkit.config).
2758
2759         If the two differ we assume a full incremental build is needed, since
2760         the new revisions might have introduced problematic things like new
2761         Q_OBJECT macros. If not, we assume the developer is doing changes
2762         locally, and revert to doing a plain 'make'.
2763
2764         In addition, when the build fails in the latter case, we inform the
2765         developer of possible pitfalls and how to manually run 'make qmake'.
2766
2767         Reviewed by Ossy.
2768
2769         * Scripts/update-webkit:
2770         * Scripts/webkitdirs.pm:
2771         (buildQMakeProjects):
2772
2773 2012-01-23  Mario Sanchez Prada  <msanchez@igalia.com>
2774
2775         [GTK] run-gtk-tests randomly fails while running the xprop comand
2776         https://bugs.webkit.org/show_bug.cgi?id=76817
2777
2778         Reviewed by Philippe Normand.
2779
2780         Temporarily comment the lines related to launching the ATSPI bus
2781         and registry daemon, which are making the bots to fail randomly.
2782
2783         * Scripts/run-gtk-tests:
2784         (TestRunner): Skip TestWebKitAccessibility, as it won't run
2785         properly if the ATSPI infrastructure is not properly initialized.
2786         (TestRunner.run): Comment lines related to initialization of ATSPI.
2787
2788 2012-01-22  Ryosuke Niwa  <rniwa@webkit.org>
2789
2790         Windows python test build fix.
2791
2792         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2793         (PerfTestsRunner.__init__):
2794
2795 2012-01-22  Sergio Villar Senin  <svillar@igalia.com>
2796
2797         [GTK] DumpRenderTree converts "file:///" to a path differently
2798         https://bugs.webkit.org/show_bug.cgi?id=76631
2799
2800         Reviewed by Martin Robinson.
2801
2802         DumpRenderTree should print "/" as the last path component if the
2803         path is a lone slash instead of empty output.
2804
2805         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2806         (webViewConsoleMessage):
2807
2808 2012-01-20  David Levin  <levin@chromium.org>
2809
2810         The leaky DC check should use adoptPtr as a signal instead of OwnPtr to get less false positives.
2811         https://bugs.webkit.org/show_bug.cgi?id=76752
2812
2813         Reviewed by Eric Seidel.
2814
2815         * Scripts/webkitpy/style/checkers/cpp.py:
2816         (check_for_leaky_patterns):
2817         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2818         (LeakyPatternTest.test_create_dc):
2819         (LeakyPatternTest.test_create_compatible_dc):
2820
2821 2012-01-20  Shawn Singh  <shawnsingh@chromium.org>
2822
2823         Changed my status in commiters.py
2824
2825         Unreviewed.
2826
2827         * Scripts/webkitpy/common/config/committers.py:
2828
2829 2012-01-20  Ojan Vafai  <ojan@chromium.org>
2830
2831         run-webkit-tests --lint-test-files crawls the whole LayoutTests subtree
2832         https://bugs.webkit.org/show_bug.cgi?id=76748
2833
2834         Reviewed by Ryosuke Niwa.
2835
2836         It crawls the whole subtree and then doesn't use the data. Cutting this out
2837         saves 4 seconds warm and 17 seconds cold on my Mac Pro.
2838
2839         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2840         (run):
2841
2842 2012-01-20  Adam Barth  <abarth@webkit.org>
2843
2844         Another tiny tweak to the garden-o-matic CSS.  This makes things line
2845         up slightly nicer when there aren't any failures.
2846
2847         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
2848         (#summary):
2849
2850 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
2851
2852         run-perf-tests should support --test-results-server option
2853         https://bugs.webkit.org/show_bug.cgi?id=76680
2854
2855         Reviewed by Adam Barth.
2856
2857         Add --test-results-server, --builder-name, and --build-number options to run-perf-tests
2858         to be used by perf bots. Also refactor file_uploader as needed.
2859
2860         * Scripts/webkitpy/common/net/file_uploader.py:
2861         (FileUploader.__init__):
2862         (FileUploader.upload_single_file):
2863         (FileUploader.upload_as_multipart_form_data):
2864         (FileUploader):
2865         (FileUploader._upload_data):
2866         (FileUploader._upload_data.callback):
2867         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2868         (JSONResultsGeneratorBase.upload_json_files):
2869         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2870         (PerfTestsRunner):
2871         (PerfTestsRunner._parse_args):
2872         (PerfTestsRunner.run):
2873         (PerfTestsRunner._generate_json):
2874         (PerfTestsRunner._upload_json):
2875         (PerfTestsRunner._run_tests_set):
2876         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2877         (create_runner):
2878         (test_run_with_upload_json):
2879         (test_run_with_upload_json.mock_upload_json):
2880         (test_upload_json):
2881         (test_upload_json.MockFileUploader):
2882         (test_upload_json.MockFileUploader.__init__):
2883         (test_upload_json.MockFileUploader.upload_single_file):
2884         (test_parse_args):
2885
2886 2012-01-20  Adam Barth  <abarth@webkit.org>
2887
2888         The party time image overlaps real content!  This patch makes the
2889         image centered vertically.
2890
2891         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
2892         (#onebar.partytime #summary):
2893
2894 2012-01-19  Ojan Vafai  <ojan@chromium.org>
2895
2896         Refactor TestExpectationsParser in preparation for caching the results
2897         https://bugs.webkit.org/show_bug.cgi?id=76669
2898
2899         Reviewed by Dimitri Glazkov.
2900
2901         Make everything private expect for the parse method. 
2902         Eventually, we'll need the expectations lines to not be modified
2903         outside of TestExpectationsParser so we can cache the results.
2904         This makes check-webkit-style of the chromium test_expectations.txt file
2905         go from ~17 seconds to ~12 seconds on my Mac Pro.
2906
2907         This patch is just a refactor in preparation, so no new tests.
2908
2909         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
2910         (TestExpectationEditorTests.make_parsed_expectation_lines):
2911         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2912         (TestExpectationParser.parse):
2913         (TestExpectationParser):
2914         (TestExpectationParser._parse_line):
2915         (TestExpectationParser._tokenize):
2916         (TestExpectationParser._tokenize_list):
2917         (TestExpectationsModel._clear_expectations_for_test):
2918         (TestExpectations.__init__):
2919         (TestExpectations._add_expectations):
2920         (TestExpectations._add_skipped_tests):
2921         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2922         (TestExpectationParserTests.test_tokenize_blank):
2923         (TestExpectationParserTests.test_tokenize_missing_colon):
2924         (TestExpectationParserTests.test_tokenize_extra_colon):
2925         (TestExpectationParserTests.test_tokenize_empty_comment):
2926         (TestExpectationParserTests.test_tokenize_comment):
2927         (TestExpectationParserTests.test_tokenize_missing_equal):
2928         (TestExpectationParserTests.test_tokenize_extra_equal):
2929         (TestExpectationParserTests.test_tokenize_valid):
2930         (TestExpectationParserTests.test_tokenize_valid_with_comment):
2931         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
2932         (TestExpectationParserTests.test_parse_empty_string):
2933         (TestExpectationSerializerTests.assert_round_trip):
2934         (TestExpectationSerializerTests.assert_list_round_trip):
2935         * Scripts/webkitpy/tool/commands/expectations.py:
2936         (OptimizeExpectations.execute):
2937         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2938         (GardeningExpectationsUpdater.update_expectations):
2939
2940 2012-01-20  Adam Barth  <abarth@webkit.org>
2941
2942         Follow-up to previous patch: don't produce NaN when the revision number
2943         is missing.
2944
2945         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
2946         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
2947
2948 2012-01-20  Adam Barth  <abarth@webkit.org>
2949
2950         Garden-o-matic should tell me which revisions have been checked by all the bots
2951         https://bugs.webkit.org/show_bug.cgi?id=76722
2952
2953         Reviewed by Dimitri Glazkov.
2954
2955         This information helps me know when it's safe for me to roll a
2956         candidate revision.
2957
2958         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2959         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
2960         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
2961
2962 2012-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2963
2964         build-webkit: Don't spit out congratulations message on Ctrl+C
2965
2966         Reviewed by Andreas Kling.
2967
2968         * Scripts/build-webkit:
2969
2970 2012-01-20  Philippe Normand  <pnormand@igalia.com>
2971
2972         [GTK] Allow extra jhbuild modulesets
2973         https://bugs.webkit.org/show_bug.cgi?id=76691
2974
2975         Reviewed by Gustavo Noronha Silva.
2976
2977         * gtk/jhbuildrc: Extra modulesets and modules can be added in
2978         JHBuild using the WEBKIT_EXTRA_MODULESETS and WEBKIT_EXTRA_MODULES
2979         env variables respectively. Use comma-separated values. Example:
2980         WEBKIT_EXTRA_MODULES=file:///path/to/module.set,file:///other/path.
2981
2982 2012-01-20  Mario Sanchez Prada  <msanchez@igalia.com>
2983
2984         [GTK] Expose accessibility hierarchy in WebKit2 to ATK/AT-SPI based ATs
2985         https://bugs.webkit.org/show_bug.cgi?id=72589
2986
2987         Reviewed by Martin Robinson.
2988
2989         Ensure the accessibility infrastructure is available when running
2990         the unit tests, otherwise WK2's accessibility tests won't work.
2991
2992         * Scripts/run-gtk-tests:
2993         (TestRunner):
2994         (TestRunner._lookup_atspi2_binary): New. Looks for the directory
2995         where at-spi2's stuff is located (like at-spi-bus-launcher and
2996         at-spi2-registryd).
2997         (TestRunner.run): Initialize the accessibility infrastructure.
2998
2999         * gtk/generate-gtkdoc:
3000         (get_webkit2_options): Add 'WebKitWebViewBaseAccessible.*'.
3001
3002         * gtk/jhbuild.modules: Added at-spi2-core and at-spi2-atk.
3003
3004 2012-01-20  Hayato Ito  <hayato@chromium.org>
3005
3006         Add ShadowRoot.idl which is enabled by newly introduced SHADOW_DOM flag.
3007         https://bugs.webkit.org/show_bug.cgi?id=76353
3008
3009         Reviewed by Hajime Morita.
3010
3011         Add ShadowRoot.idl, which is enabled only on chromium port since this is
3012         under development feature.
3013         ShadowRoot.idl contains minimum API so that we can test it.
3014         Other APIs should be added on other changes so that we can isolate issues.
3015
3016         * DumpRenderTree/chromium/TestShell.cpp:
3017         (TestShell::TestShell):
3018
3019 2012-01-20  Mario Sanchez Prada  <msanchez@igalia.com>
3020
3021         [GTK] GTK's DRT not to log events for already defunct objects
3022         https://bugs.webkit.org/show_bug.cgi?id=76620
3023
3024         Reviewed by Martin Robinson.
3025
3026         Do not log 'state-change:defunct' events.
3027
3028         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
3029         (printAccessibilityEvent): Early return if a
3030         'state-change:defunct' signal is passed.
3031         (axObjectEventListener): Pass the signal name and value in
3032         separate parameters to printAccessibilityEvent.
3033
3034 2012-01-19  Gustavo Noronha Silva  <gns@gnome.org>
3035
3036         Unreviewed build fix. Wrong variable being used as the cwd for git
3037         remote update command.
3038
3039         * gtk/run-with-jhbuild:
3040         (update_jhbuild):
3041
3042 2012-01-19  Gustavo Noronha Silva  <gns@gnome.org>
3043
3044         [GTK] ensure the jhbuild used by webkit is as up-to-date as needed
3045         https://bugs.webkit.org/show_bug.cgi?id=76585
3046
3047         Reviewed by Martin Robinson.
3048
3049         This allows us to specify a minimum version of jhbuild required,
3050         while also providing stability against changes done to the master
3051         branch, by letting us choose what is the exact version that will
3052         be used.
3053
3054         * gtk/run-with-jhbuild: refactored for more hackability and easier
3055         reading
3056         (jhbuild_installed): checks whether jhbuild is installed
3057         (jhbuild_cloned): checks whether jhbuild has been cloned
3058         (jhbuild_at_expected_revision): checks whether jhbuild is at the
3059         expected revision
3060         (update_jhbuild): brings jhbuild to the expected revision
3061         (clone_jhbuild): clones jhbuild
3062         (install_jhbuild): build and installs jhbuild
3063         (update_webkitgtk_libs): runs update-webkitgtk-libs
3064         (ensure_jhbuild): high-level logic to decide whether and which of
3065         the steps above are executed
3066
3067 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
3068
3069         [WK2] DumpRenderTree converts "file:///" to a path differently
3070         https://bugs.webkit.org/show_bug.cgi?id=76653
3071
3072         Reviewed by John Sullivan.
3073
3074         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::lastFileURLPathComponent):
3075         Do print a slash if there are no path components.
3076
3077 2012-01-19  Eric Seidel  <eric@webkit.org>
3078
3079         webkit-patch cannot rollout patches without changelog/bug number
3080         https://bugs.webkit.org/show_bug.cgi?id=75962
3081
3082         Reviewed by Adam Barth.
3083
3084         * Scripts/webkitpy/tool/commands/download.py:
3085         (AbstractRolloutPrepCommand._prepare_state):
3086         * Scripts/webkitpy/tool/commands/download_unittest.py:
3087         (AbstractRolloutPrepCommandTest.test_prepare_state):
3088
3089 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
3090
3091         [WK2] fast/url/degenerate-file-base.html fails
3092         https://bugs.webkit.org/show_bug.cgi?id=76619
3093
3094         Reviewed by Adam Roben.
3095
3096         A URL generated form local path for loading had an extra slash, making document.URL
3097         incorrect in all WebKit2 tests (file://localhost//path/to/test.html).
3098
3099         * WebKitTestRunner/TestInvocation.cpp: (WTR::createWKURL):
3100
3101 2012-01-18  Ojan Vafai  <ojan@chromium.org>
3102
3103         check-webkit-style of the chromium test_expectations.txt file doesn't test all chromium ports
3104         https://bugs.webkit.org/show_bug.cgi?id=76510
3105
3106         Reviewed by Adam Barth.
3107
3108         Unlike other style rules, if you get the syntax of the test_expectations.txt
3109         file wrong, the layout tests won't run. Also, this check is simple and only
3110         slows down committing if you actually modify one of the test_expectations.txt files.
3111
3112         * Scripts/webkitpy/style/checkers/test_expectations.py:
3113         (TestExpectationsChecker.check_test_expectations):
3114         (TestExpectationsChecker.check):
3115         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3116         (TestExpectationsTestCase.test_check_covers_all_configurations):
3117         (TestExpectationsTestCase.test_check_covers_all_configurations.mock_check_test_expectations):
3118         (TestExpectationsTestCase):
3119         (assert_lines_lint):
3120
3121 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
3122
3123         Build fix. Revert an unintentional change to WebKitDriver in r105443.
3124
3125         * Scripts/webkitpy/layout_tests/port/driver.py:
3126         (DriverProxy.__init__):
3127
3128 2012-01-19  Dirk Pranke  <dpranke@chromium.org>
3129
3130         remove the duplicated build rules from WebKit.gyp, Tools.gyp
3131         https://bugs.webkit.org/show_bug.cgi?id=73384
3132
3133         Reviewed by Tony Chang.
3134
3135         This patch removes the no-longer-necessary conditional logic for
3136         build_webkit_exes_from_webkit_gyp; we now always build the exes
3137         from their own dedicated gyp files.
3138
3139         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3140
3141 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
3142
3143         make-new-script-test should work with HTTP tests
3144         https://bugs.webkit.org/show_bug.cgi?id=76603
3145
3146         Reviewed by Adam Roben.
3147
3148         * Scripts/make-new-script-test:
3149         (makePathToSharedSources): Renamed from makeTestRelativePathToSharedSources(), since it
3150         now also creates absolute paths for HTTP.
3151
3152 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
3153
3154         Some perf tests time out when ran by run-perf-tests
3155         https://bugs.webkit.org/show_bug.cgi?id=76612
3156
3157         Reviewed by Dirk Pranke and Eric Seidel.
3158
3159         Always pass --no-timeout to DumpRenderTree from run-perf-tests.
3160         Otherwise some tests such as Parser/xml-parser.html will timeout.
3161
3162         --no-timeout option is currently supported by Chromium and Mac ports.
3163
3164         * Scripts/webkitpy/layout_tests/port/base.py:
3165         (Port.to.create_driver):
3166         * Scripts/webkitpy/layout_tests/port/chromium.py:
3167         (ChromiumDriver.__init__):
3168         (ChromiumDriver._wrapper_options):
3169         * Scripts/webkitpy/layout_tests/port/driver.py:
3170         (Driver.__init__):
3171         (DriverProxy.__init__):
3172         * Scripts/webkitpy/layout_tests/port/webkit.py:
3173         (WebKitDriver.__init__):
3174         (WebKitDriver.cmd_line):
3175         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3176         (WebKitDriverTest.test_read_binary_block):
3177         (WebKitDriverTest):
3178         (WebKitDriverTest.test_no_timeout):
3179         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3180         (get_tests_run.RecordingTestDriver.__init__):
3181         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3182         (PerfTestsRunner._parse_args):
3183         (PerfTestsRunner._run_tests_set):
3184         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3185         (create_runner):
3186
3187 2012-01-19  Ben Wells  <benwells@chromium.org>
3188
3189         Add support for window.print to chromium DRT
3190         https://bugs.webkit.org/show_bug.cgi?id=76479
3191
3192         When used in a test window.print goes into print mode and then
3193         straight out again. This will allow the afterprint event to be
3194         tested by having the afterprint event happen before the dump
3195         happens.
3196
3197         Reviewed by Mihai Parparita.
3198
3199         * DumpRenderTree/chromium/WebViewHost.cpp:
3200         (WebViewHost::printPage):
3201         * DumpRenderTree/chromium/WebViewHost.h:
3202
3203 2012-01-18  Enrica Casucci  <enrica@apple.com>
3204
3205         editingAttributedStringFromRange in WebHTMLConverter does not handle NSUnderlineStyleAttributeName.
3206         https://bugs.webkit.org/show_bug.cgi?id=76588
3207         <rdar://problem/9325183>
3208
3209         Added test.
3210         
3211         Reviewed by Dan Bernstein.
3212
3213         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
3214         (TestWebKitAPI::TEST):
3215
3216 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3217
3218         [Qt] Do full incremental builds until bots use update-webkit
3219
3220         Rubber-stamped by Simon Hausmann.
3221
3222         * Scripts/webkitdirs.pm:
3223         (buildQMakeProjects):
3224
3225 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3226
3227         Fix the Qt build
3228
3229         Unreviewed build fix.
3230
3231         * Scripts/webkitdirs.pm:
3232         (buildQMakeProjects):
3233
3234 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3235
3236         [Qt] Make build-webkit always do safe incremental builds after update-webkit
3237
3238         When building against Qt5 with GCC we would just run 'make' in the build dir,
3239         and rely on the dependency files output by GCC (-MD) to handle dependency
3240         tracking, but that fails for special-cases like adding a Q_OBJECT macro
3241         to a header.
3242
3243         To guarantee that an incrmental build will work, we have to run 'make qmake',
3244         which we now do on every build-webkit that's followed by a successful run
3245         of update-webkit. The reasoning is that update-webkit can result in such
3246         potential corner-cases being applied, and since we can't know for sure
3247         unless we inspect the diff and account for all the corner cases we assume
3248         the worst and always run 'make qmake'.
3249
3250         After a succesful run of build-webkit we proceed to do just 'make' for any
3251         subsequent runs, since we assume that the developer knows what kind of
3252         changes he/she is doing, and when a 'make qmake' is needed.
3253
3254         Reviewed by Simon Hausmann.
3255
3256         * Scripts/update-webkit:
3257         * Scripts/webkitdirs.pm:
3258         (determineCurrentSVNRevision):
3259         (currentSVNRevision):
3260         (buildQMakeProjects):
3261         * qmake/mkspecs/features/default_post.prf:
3262
3263 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
3264
3265         run-perf-tests should support Skipped list
3266         https://bugs.webkit.org/show_bug.cgi?id=76594
3267
3268         Reviewed by Adam Barth.
3269
3270         Add a support for Skipped list in run-perf-tests; also skip files in resources directories.
3271
3272         * Scripts/webkitpy/layout_tests/port/base.py:
3273         (Port.perf_tests_dir):
3274         (Port.skipped_perf_tests):
3275         (Port.skips_perf_test):
3276         (Port.relative_perf_test_filename):
3277         * Scripts/webkitpy/layout_tests/port/test.py:
3278         (TestPort.perf_tests_dir):
3279         * Scripts/webkitpy/layout_tests/port/webkit.py:
3280         (WebKitPort._expectations_from_skipped_files):
3281         (WebKitPort):
3282         (WebKitPort.skipped_layout_tests):
3283         (WebKitPort.skipped_perf_tests):
3284         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3285         (PerfTestsRunner._collect_tests):
3286         (PerfTestsRunner.run):
3287         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3288         (test_run_test_set_with_json_output):
3289         (test_run_test_set_with_json_source):
3290         (test_collect_tests_with_skipped_list):
3291         (test_collect_tests_with_skipped_list.add_file):
3292
3293 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
3294
3295         Fix path to chromium_src_dir introduced in previous change.
3296
3297         Unreviewed, build fix.
3298
3299         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3300
3301 2012-01-18  Alexey Proskuryakov  <ap@apple.com>
3302
3303         Need infrastructure to test Content-Disposition filename encoding support
3304         https://bugs.webkit.org/show_bug.cgi?id=76572
3305         <rdar://problem/6421825>
3306
3307         Reviewed by Sam Weinig.
3308
3309         Made policy delegate log suggested file name when resource has Content-Disposition: attachment.
3310
3311         WebKitTestRunner does not have a policy delegate yet, bug 42546.
3312
3313         * DumpRenderTree/mac/PolicyDelegate.mm:
3314         (dispositionTypeFromContentDispositionHeader):
3315         (-[PolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
3316
3317 2012-01-18  Ojan Vafai  <ojan@chromium.org>
3318
3319         Fix tests from http://trac.webkit.org/changeset/105332.
3320
3321         The code assumed that if you passed an options object with a configuration
3322         attribute that it would have a valid value. A bunch of the testing mocks
3323         do things like having a configuration value of None.
3324
3325         * Scripts/webkitpy/layout_tests/port/base.py:
3326         (Port.__init__):
3327
3328 2012-01-18  Ojan Vafai  <ojan@chromium.org>
3329
3330         Shave 0.5 seconds off check-webkit-style runtime for test_expectations.txt
3331         https://bugs.webkit.org/show_bug.cgi?id=76576
3332
3333         Reviewed by Adam Barth.
3334
3335         Avoid calling default_configuration in base.py. We don't need it for
3336         checking test_expectations.txt style. It takes ~0.5 seconds to run on my
3337         Mac Pro. It's the call to "perl Tools/Scripts/webkit-build-directory --top-level"
3338         from common.executive.
3339
3340         At some point someone should probably look into why that call is so slow
3341         since it's on the critical path for run-webkit-tests and build-webkit startup.
3342
3343         * Scripts/webkitpy/layout_tests/port/base.py:
3344         (Port.__init__):
3345         * Scripts/webkitpy/style/checkers/test_expectations.py:
3346         (TestExpectationsChecker._determine_port_from_exepectations_path):
3347
3348 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
3349
3350         [chromium] move Tools.gyp, switch build-webkit --chromium to All.gyp
3351         https://bugs.webkit.org/show_bug.cgi?id=76505
3352
3353         Reviewed by Tony Chang.
3354
3355         Update chromium build script to use All.gyp instead of WebKit.gyp
3356
3357         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Renamed from Source/WebKit/chromium/Tools.gyp.
3358         * Scripts/webkitdirs.pm:
3359
3360 2012-01-18  Sam Weinig  <sam@webkit.org>
3361
3362         Don’t hardcode the path to ‘make‘.
3363
3364         Reviewed by Dan Bernstein.
3365
3366         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3367
3368 2012-01-18  Joshua Bell  <jsbell@chromium.org>
3369
3370         Adding myself to committers.py
3371         https://bugs.webkit.org/show_bug.cgi?id=76569
3372
3373         Unreviewed.
3374
3375         * Scripts/webkitpy/common/config/committers.py:
3376
3377 2012-01-18  Adam Barth  <abarth@webkit.org>
3378
3379         Up the cap on test failures tolerated by the EWS so the mac-ews can run to completion
3380         https://bugs.webkit.org/show_bug.cgi?id=76567
3381
3382         Reviewed by Eric Seidel.
3383
3384         Current the AppleMac port has slightly more failures than we allow on
3385         the EWS, causing the mac-ews to spin.  This patch ups the limit a bit,
3386         which should hopefully let the mac-ews run to completion.  Once
3387         AppleMac has fewer failures, we can lower the cap again.
3388
3389         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3390         (LayoutTestResultsReaderTest.test_layout_test_results):
3391         * Scripts/webkitpy/tool/steps/runtests.py:
3392         (RunTests):
3393         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3394
3395 2012-01-18  Eric Carlson  <eric.carlson@apple.com>
3396
3397         Provide access to user's list of preferred languages
3398         https://bugs.webkit.org/show_bug.cgi?id=76138
3399
3400         Reviewed by Alexey Proskuryakov.
3401
3402         * GNUmakefile.am: Add JSInternalsCustom.cpp.
3403
3404 2012-01-18  Adam Barth  <abarth@webkit.org>
3405
3406         Add Chromium Linux GPU 32 to the list of allowed Chromium Linux
3407         configurations.
3408
3409         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3410         (ChromiumLinuxPort.__init__):
3411
3412 2012-01-18  Dominic Mazzoni  <dmazzoni@google.com>
3413
3414         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
3415         https://bugs.webkit.org/show_bug.cgi?id=73460
3416
3417         Reviewed by Chris Fleizach.
3418
3419         * DumpRenderTree/AccessibilityUIElement.h:
3420         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3421         (AccessibilityUIElement::AccessibilityUIElement):
3422         (AccessibilityUIElement::scrollToMakeVisibleCallback):
3423         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
3424         (AccessibilityUIElement::scrollToGlobalPointCallback):
3425         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3426         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3427         (AccessibilityUIElement::scrollToMakeVisible):
3428         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3429         (AccessibilityUIElement::scrollToGlobalPoint):
3430         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3431         (AccessibilityUIElement::scrollToMakeVisible):
3432         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3433         (AccessibilityUIElement::scrollToGlobalPoint):
3434         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3435         (AccessibilityUIElement::scrollToMakeVisible):
3436         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3437         (AccessibilityUIElement::scrollToGlobalPoint):
3438
3439 2012-01-17  Enrica Casucci  <enrica@apple.com>
3440
3441         Missing NSForegroundColorAttributeName should be treated as black instead of transparent.
3442         https://bugs.webkit.org/show_bug.cgi?id=76490
3443         <rdar://problem/9460733>
3444
3445         Added TestWebKitAPI test.
3446         
3447         Reviewed by Dan Bernstein.
3448
3449         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new test file.
3450         * TestWebKitAPI/Tests/mac/InspectorBar.mm: Added test that calls
3451         changeAttributes to the WebView.
3452         
3453 2012-01-18  Balazs Kelemen  <kbalazs@webkit.org>
3454
3455         [Qt] Consolidate layout test crash logging
3456         https://bugs.webkit.org/show_bug.cgi?id=75088
3457
3458         Reviewed by Simon Hausmann.
3459
3460         Move backtrace generating logic into WTFReportBacktrace
3461         and add a way to deinstall signal handlers if we know
3462         that we have already printed the backtrace.
3463
3464         * DumpRenderTree/qt/main.cpp:
3465         (crashHandler):
3466         (setupSignalHandlers):
3467         (WTFCrashHook):
3468         (main):
3469         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
3470         (WTR::crashHandler):
3471         (WTR::setupSignalHandlers):
3472         (WTR::crashHook):
3473         (WTR::InjectedBundle::platformInitialize):
3474
3475 2012-01-18  Ilya Tikhonovsky  <loislo@chromium.org>
3476
3477         Unreviewed build fix after r105256.
3478
3479         There was a cyclic dependency between self._port and self._host assigments.
3480
3481         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3482         (PerfTestsRunner.__init__):
3483
3484 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3485
3486         Add new watchlist rule for the Qt build system
3487
3488         Reviewed by Simon Hausmann.
3489
3490         * Scripts/webkitpy/common/config/watchlist:
3491
3492 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3493
3494         [Qt] Move OTHER_FILES from WebKit.pro to Tools.pro
3495
3496         Reviewed by Simon Hausmann.
3497
3498         * Tools.pro:
3499
3500 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3501
3502         [Qt] Allow building only a subset of the WebKit sub-projects
3503
3504         Fixes build-jsc, broken in r104825.
3505
3506         We no longer need the intermediate buildQMakeQtProject(), as we're the
3507         only port using qmake, and buildQMakeProject is now highly Qt specific.
3508
3509         <http://webkit.org/b/76179>
3510
3511         Reviewed by Simon Hausmann.
3512
3513         * Scripts/build-jsc:
3514         * Scripts/build-webkit:
3515         * Scripts/webkitdirs.pm:
3516         (buildQMakeProjects):
3517
3518 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
3519
3520         run-perf-tests should generate a json file that summaries the result
3521         https://bugs.webkit.org/show_bug.cgi?id=76504
3522
3523         Reviewed by Adam Barth.
3524
3525         Add an ability to generate a json file to run-perf-test in the preparation for perf bots.
3526         New option --outout-json-path specifies the json file's path, and --source-json-path specifies
3527         another json file to be merged into the generated json file.
3528
3529         Also fixed a bug that --build wasn't set by default.
3530
3531         * Scripts/webkitpy/layout_tests/port/test.py:
3532         (TestPort.webkit_base):
3533         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3534         (PerfTestsRunner.__init__):
3535         (PerfTestsRunner):
3536         (PerfTestsRunner._parse_args):
3537         (PerfTestsRunner.run):
3538         (PerfTestsRunner._generate_json_if_specified):
3539         (PerfTestsRunner._process_chromium_style_test_result):
3540         (PerfTestsRunner._process_parser_test_result):
3541         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3542         (MainTest):
3543         (create_runner):
3544         (test_run_test_set):
3545         (test_run_test_set_for_parser_tests):
3546         (test_run_test_set_with_summary_json):
3547         (test_collect_tests):
3548         (test_parse_args):
3549
3550 2012-01-17  Sheriff Bot  <webkit.review.bot@gmail.com>
3551
3552         Unreviewed, rolling out r105244.
3553         http://trac.webkit.org/changeset/105244
3554         https://bugs.webkit.org/show_bug.cgi?id=76518
3555
3556         broke Chromium Mac (Requested by rolandsteiner on #webkit).
3557
3558         * DumpRenderTree/AccessibilityUIElement.h:
3559         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3560         (AccessibilityUIElement::AccessibilityUIElement):
3561         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3562         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3563         (AccessibilityUIElement::removeSelection):
3564         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3565         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3566         (AccessibilityUIElement::removeSelection):
3567
3568 2012-01-17  Dominic Mazzoni  <dmazzoni@google.com>
3569
3570         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
3571         https://bugs.webkit.org/show_bug.cgi?id=73460
3572
3573         Reviewed by Chris Fleizach.
3574
3575         * DumpRenderTree/AccessibilityUIElement.h:
3576         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3577         (AccessibilityUIElement::AccessibilityUIElement):
3578         (AccessibilityUIElement::scrollToMakeVisibleCallback):
3579         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
3580         (AccessibilityUIElement::scrollToGlobalPointCallback):
3581         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3582         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3583         (AccessibilityUIElement::scrollToMakeVisible):
3584         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3585         (AccessibilityUIElement::scrollToGlobalPoint):
3586         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3587         (AccessibilityUIElement::scrollToMakeVisible):
3588         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3589         (AccessibilityUIElement::scrollToGlobalPoint):
3590         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3591         (AccessibilityUIElement::scrollToMakeVisible):
3592         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3593         (AccessibilityUIElement::scrollToGlobalPoint):
3594
3595 2012-01-17  Adam Barth  <abarth@webkit.org>
3596
3597         Enable tests on the mac-ews
3598         https://bugs.webkit.org/show_bug.cgi?id=76502
3599
3600         Reviewed by Simon Fraser.
3601
3602         Apple now has five machines running the mac-ews.  Lucas Forschler has
3603         asked that we try enabling tests to see if we have enough bandwidth.
3604
3605         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3606         (MacEWS):
3607
3608 2012-01-17  Sanjoy Das  <sanjoy@playingwithpointers.com>
3609
3610         Add a check-webkit-style exception for GDBInterface.cpp
3611         https://bugs.webkit.org/show_bug.cgi?id=76187
3612
3613         Add an exception for Source/JavaScriptCore/jit/GDBInterface.cpp so
3614         that it does not fail the style check.
3615
3616         Reviewed by Martin Robinson.
3617
3618         * Scripts/webkitpy/style/checker.py: Tell the style checker to not run
3619         readability/naming tests on
3620         Source/JavaScriptCore/jit/GDBInterface.cpp.
3621         * Scripts/webkitpy/style/checker_unittest.py:
3622         (GlobalVariablesTest.test_path_rules_specifier): Add a test for
3623         the above exception.
3624
3625 2012-01-17  Hajime Morrita  <morrita@chromium.org>
3626
3627         https://bugs.webkit.org/show_bug.cgi?id=76245
3628         [Mac][DRT] should allow query string for the file URL.
3629
3630         Reviewed by Tony Chang.
3631
3632         Taught DRT about file:// as a url instead of a file path.
3633         We are now able to use a path file:///foo/bar.html?baz as a url
3634         with which DRT opens "/foo/bar.html" with "baz" as a query string.
3635
3636         * DumpRenderTree/mac/DumpRenderTree.mm:
3637         (runTest):
3638
3639 2012-01-17  Ojan Vafai  <ojan@chromium.org>
3640
3641         Check style on test_expectations.txt files before commit
3642         https://bugs.webkit.org/show_bug.cgi?id=76484
3643
3644         Reviewed by Adam Barth.
3645
3646         Unlike other style rules, if you get the syntax of the test_expectations.txt
3647         file wrong, the layout tests won't run. Also, this check is simple and only
3648         slows down committing if you actually modify one of the test_expectations.txt files.
3649
3650         * Scripts/webkitpy/tool/steps/commit.py:
3651         (Commit._check_test_expectations):
3652         (Commit.run):
3653         * Scripts/webkitpy/tool/steps/commit_unittest.py: Added.
3654         (CommitTest):
3655         (CommitTest.test_check_test_expectations):
3656
3657 2012-01-17  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
3658
3659         [Qt] Debug build fails with debug qt5
3660         https://bugs.webkit.org/show_bug.cgi?id=76463
3661
3662         Reviewed by Simon Hausmann.
3663
3664         Add QNetworkCookie include in order to satisfy sizeof in QTypeInfo in debug builds.
3665
3666         * QtTestBrowser/cookiejar.h:
3667
3668 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
3669
3670         webkitpy: fix json import on linux
3671         https://bugs.webkit.org/show_bug.cgi?id=76481
3672
3673         Reviewed by Adam Barth.
3674
3675         For some reason, the version of simplejson autoinstalled on my linux
3676         box seems to be broken. We should really only be using
3677         simplejson if json isn't available anyway, so this change looks
3678         for json first.
3679
3680         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3681         (JSONGeneratorTest.test_test_timings_trie):
3682
3683 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
3684
3685         Fix failures in test-webkitpy caused by r105177.
3686
3687         Unreviewed, build fix.
3688
3689         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3690         (ChromiumLinuxPort._determine_driver_path_statically):
3691         (ChromiumLinuxPort._static_build_path):
3692
3693 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
3694
3695         webkitpy: make PortFactory.get() be fully data-driven
3696         https://bugs.webkit.org/show_bug.cgi?id=76360
3697
3698         Reviewed by Eric Seidel.
3699
3700         Refactor PortFactory.get() to be fully data-driven.
3701
3702         * Scripts/webkitpy/layout_tests/port/factory.py:
3703         (PortFactory):
3704         (PortFactory._default_port):
3705         (PortFactory.get):
3706         (PortFactory.get.in):
3707         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3708         (FactoryTest.assert_port):
3709
3710 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
3711
3712         webkitpy: add determine_full_port_name(), clean up port.__init__()
3713         https://bugs.webkit.org/show_bug.cgi?id=76357
3714
3715         Reviewed by Adam Barth.
3716
3717         Each Port class is now required to implement a 'port_name' field
3718         that will match the start of all ports constructed by this class and
3719         a 'determine_full_port_name' field that will make the port
3720         fully-qualified.
3721
3722         * Scripts/webkitpy/layout_tests/port/apple.py:
3723         (ApplePort.__init__):
3724         * Scripts/webkitpy/layout_tests/port/base.py:
3725         (Port):
3726         (Port.determine_port_name):
3727         (Port.__init__):
3728         * Scripts/webkitpy/layout_tests/port/chromium.py:
3729         (ChromiumPort.for):
3730         (ChromiumPort.__init__):
3731         (ChromiumPort):
3732         (ChromiumPort._chromium_base_dir):
3733         (ChromiumPort.path_from_chromium_base):
3734         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3735         (ChromiumGpuLinuxPort):
3736         (ChromiumGpuLinuxPort.__init__):
3737         (ChromiumGpuMacPort):
3738         (ChromiumGpuMacPort.__init__):
3739         (ChromiumGpuWinPort):
3740         (ChromiumGpuWinPort.__init__):
3741         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3742         (ChromiumLinuxPort):
3743         (ChromiumLinuxPort.determine_port_name):
3744         (ChromiumLinuxPort.__init__):
3745         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3746         (ChromiumMacPort):
3747         (ChromiumMacPort.determine_port_name):
3748         (ChromiumMacPort.__init__):
3749         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3750         (ChromiumWinPort):
3751         (ChromiumWinPort.determine_port_name):
3752         (ChromiumWinPort.__init__):
3753         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3754         (DryRunPort):
3755         (DryRunPort.determine_port_name):
3756         (DryRunPort.__init__):
3757         * Scripts/webkitpy/layout_tests/port/efl.py:
3758         (EflPort):
3759         * Scripts/webkitpy/layout_tests/port/factory.py:
3760         (PortFactory):
3761         (PortFactory._default_port):
3762         (PortFactory.get):
3763         (PortFactory.get.in):
3764         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3765         (FactoryTest.assert_port):
3766         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3767         (GoogleChromeLinux32Port):
3768         (GoogleChromeLinux32Port.determine_port_name):
3769         (GoogleChromeLinux64Port):
3770         (GoogleChromeLinux64Port.determine_port_name):
3771         (GoogleChromeMacPort):
3772         (GoogleChromeMacPort.determine_port_name):
3773         (GoogleChromeWinPort):
3774         (GoogleChromeWinPort.determine_port_name):
3775         * Scripts/webkitpy/layout_tests/port/gtk.py:
3776         (GtkPort):
3777         * Scripts/webkitpy/layout_tests/port/mac.py:
3778         (MacPort):
3779         (MacPort.determine_port_name):
3780         (MacPort.__init__):
3781         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3782         (test_versions):
3783         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3784         (MockDRTPort):
3785         (MockDRTPort.determine_port_name):
3786         (MockDRTPort.__init__):
3787         (MockDRT):
3788         (MockDRT.determine_port_name):
3789         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3790         (PortTestCase.make_port):
3791         * Scripts/webkitpy/layout_tests/port/qt.py:
3792         (QtPort):
3793         (QtPort.determine_port_name):
3794         (QtPort.__init__):
3795         * Scripts/webkitpy/layout_tests/port/test.py:
3796         (TestPort):
3797         (TestPort.determine_port_name):
3798         (TestPort.__init__):
3799         * Scripts/webkitpy/layout_tests/port/webkit.py:
3800         (WebKitPort.__init__):
3801         * Scripts/webkitpy/layout_tests/port/win.py:
3802         (WinPort):
3803         (WinPort.determine_port_name):
3804         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3805         (get_test_baselines.AllPlatformsPort.__init__):
3806         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
3807         (get_test_config.TestMacPort):
3808         (get_test_config):
3809
3810 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
3811
3812         webkitpy: clean up port code in preparation for static port names
3813         https://bugs.webkit.org/show_bug.cgi?id=76356
3814
3815         Reviewed by Adam Barth.
3816
3817         To fix bug 76215 and be able to determine appropriate port names
3818         in webkitpy without actually constructing Port objects, we need
3819         to shuffle some logic in the chromium ports to be able to figure
3820         out whether we built DRT in 32 or 64-bit mode.
3821
3822         * Scripts/webkitpy/layout_tests/port/chromium.py:
3823         (ChromiumPort):
3824         (ChromiumPort._chromium_base_dir):
3825         (ChromiumPort.__init__):
3826         (ChromiumPort.path_from_chromium_base):
3827         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3828         (ChromiumLinuxPort):
3829         (ChromiumLinuxPort._determine_driver_path_statically):
3830         (ChromiumLinuxPort._static_build_path):
3831         (ChromiumLinuxPort._determine_architecture):
3832         (ChromiumLinuxPort.__init__):
3833         (ChromiumLinuxPort._build_path):
3834
3835 2012-01-17  Hao Zheng  <zhenghao@chromium.org>
3836
3837         Do not remove pixel failures for ref tests.
3838         https://bugs.webkit.org/show_bug.cgi?id=76243
3839
3840         Reviewed by Tony Chang.
3841
3842         'NRWT --no-pixel-tests' complains when reftests are expected to
3843         be image mismatch.
3844
3845         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3846         (Manager._update_summary_with_result):
3847         * Scripts/webkitpy/layout_tests/models/test_failures.py:
3848         (is_reftest_failure):
3849         (determine_result_type):
3850
3851 2012-01-17  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
3852
3853         REGRESSION(r81225): ORWT should ignore reftests
3854         https://bugs.webkit.org/show_bug.cgi?id=67936
3855
3856         Reviewed by Csaba Osztrogonác.
3857
3858         * Scripts/old-run-webkit-tests:
3859         (isUsedInReftest): $filename should be the first parameter
3860         (findTestsToRun): run test if it isn't reftest
3861
3862 2012-01-17  Gustavo Noronha Silva  <gns@gnome.org>
3863
3864         Unreviewed. Fix python unit test I broke with r105142
3865
3866         * Scripts/webkitpy/common/config/ports_unittest.py:
3867         (WebKitPortTest.test_gtk_port):
3868
3869 2012-01-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3870
3871         [Qt] Don't set the 'primary' flag when mocking touch-points in MiniBrowser
3872
3873         Qt 5 no longer has that flag.
3874
3875         Reviewed by Simon Hausmann.
3876
3877         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3878         (MiniBrowserApplication::notify):
3879
3880 2012-01-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3881
3882         GTK+ EWS needs to run update-webkitgtk-libs after applying a patch
3883         https://bugs.webkit.org/show_bug.cgi?id=75857
3884
3885         Reviewed by Adam Barth.
3886
3887         * Scripts/webkitdirs.pm:
3888         (buildAutotoolsProject): move cleaning the build to happen early,
3889         and handle --update-gtk right after that
3890         * Scripts/webkitpy/common/config/ports.py:
3891         (GtkPort.build_webkit_command): pass --update-gtk as an option to
3892         build-webkit, so that it is used in the EWS
3893
3894 2012-01-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3895
3896         [Qt] Don't add _debug postfix to targets when building debug only
3897
3898         Reviewed by Simon Hausmann.
3899
3900         * qmake/mkspecs/features/default_post.prf:
3901         * qmake/mkspecs/features/functions.prf:
3902
3903 2012-01-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3904
3905         [Qt] Add more files to project-files for easier navigation in Qt Creator
3906
3907         Reviewed by Simon Hausmann.
3908
3909         * Tools.pro:
3910         * qmake/config.tests/README: Added.
3911
3912 2012-01-17  Philippe Normand  <pnormand@igalia.com>
3913
3914         [GTK] fast/dom/constructed-objects-prototypes.html fails
3915         https://bugs.webkit.org/show_bug.cgi?id=75432
3916
3917         Reviewed by Martin Robinson.
3918
3919         * Scripts/build-webkit: Enable video-track in GTK.
3920
3921 2012-01-16  Takashi Toyoshima  <toyoshim@chromium.org>
3922
3923         Add toyoshim as a committer.
3924         https://bugs.webkit.org/show_bug.cgi?id=76390
3925
3926         Reviewed by Hajime Morita.
3927
3928         * Scripts/webkitpy/common/config/committers.py:
3929
3930 2012-01-16  Brent Fulgham  <bfulgham@webkit.org>
3931
3932         [WinCairo] Build fix after r104155. Several debug targets were not
3933         properly including the '*Common' property sheets.
3934
3935         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops:
3936         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops:
3937         * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops:
3938         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops:
3939         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops:
3940
3941 2012-01-16  Csaba Osztrogonác  <ossy@webkit.org>
3942
3943         REGRESSION(r105072): It broke committers_unittest.py
3944         https://bugs.webkit.org/show_bug.cgi?id=76396
3945
3946         Reviewed by Adam Barth.
3947
3948         * Scripts/webkitpy/common/config/committers_unittest.py:
3949         (CommittersTest._assert_fuzz_match): It should handle more names.
3950         (CommittersTest.test_contributors_by_fuzzy_match_with_legacy_names): Fix the testcase.
3951
3952 2012-01-16  Mario Sanchez Prada  <msanchez@igalia.com>
3953
3954         [GTK] Include gtk+3 in the jhbuild modules
3955         https://bugs.webkit.org/show_bug.cgi?id=76284
3956
3957         Reviewed by Philippe Normand.
3958
3959         * gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
3960
3961 2012-01-16  Dan Winship  <danw@gnome.org>
3962
3963         Add myself as a committer
3964
3965         Unreviewed
3966
3967         * Scripts/webkitpy/common/config/committers.py:
3968
3969 2012-01-16  Raphael Kubo da Costa  <kubo@profusion.mobi>
3970
3971         Unreviewed; fix the build when --as-needed and --no-copy-dt-needed-entries are passed to the linker.
3972
3973         Some recent versions of a few Linux distributions have started passing
3974         --as-needed and --no-copy-dt-needed-entries by default to the linker,
3975         which broke the build when SHARED_CORE was turned on, as libwtf_efl.so
3976         needed a few symbols from libjavascriptcore_efl.so.
3977
3978         * DumpRenderTree/efl/CMakeLists.txt: Explicitly pass WTF_LIBRARY_NAME
3979         before JavaScriptCore_LIBRARY_NAME in DumpRenderTree_LIBRARIES so the
3980         libraries are searched in the right order by the linker.
3981
3982 2012-01-16  Philippe Normand  <pnormand@igalia.com>
3983
3984         [GTK] set audio resources path in NRTW
3985         https://bugs.webkit.org/show_bug.cgi?id=76380
3986
3987         Reviewed by Martin Robinson.
3988
3989         * Scripts/webkitpy/layout_tests/port/gtk.py:
3990         (GtkPort.setup_environ_for_server): Set $AUDIO_RESOURCES_PATH so
3991         the uninstalled audio resources are used during webaudio tests.
3992
3993 2012-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
3994
3995         [GTK] ldflags and cflags should take precedence over the existing flags in gtkdoc.py
3996         https://bugs.webkit.org/show_bug.cgi?id=76369
3997
3998         Reviewed by Xan Lopez.
3999
4000         If there's an installed version of webkit and there are new
4001         symbols in the build tree, gtkdoc-scanobj fails due to undefined
4002         references, because the env ldflags are given before the local
4003         ones.
4004
4005         * gtk/gtkdoc.py:
4006         (GTKDoc._run_gtkdoc_scangobj):
4007
4008 2012-01-15  Pablo Flouret  <pablof@motorola.com>
4009
4010         Fix compilation errors on build-webkit --debug --no-video on mac.
4011         https://bugs.webkit.org/show_bug.cgi?id=75867
4012
4013         Reviewed by Philippe Normand.
4014
4015         Add --[no-]video-track to build-webkit, since video track feature
4016         depends on video.
4017
4018         * Scripts/build-webkit:
4019
4020 2012-01-14  James Robinson  <jamesr@chromium.org>
4021
4022         [chromium] Failing webkit_unit_tests does not make the cr-linux EWS bubble red
4023         https://bugs.webkit.org/show_bug.cgi?id=76313
4024
4025         Reviewed by Adam Barth.
4026
4027         The exit code of this script should be the exit code of webkit_unit_tests. Tested manually.
4028
4029         * Scripts/run-chromium-webkit-unit-tests:
4030
4031 2012-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
4032
4033         Unreviewed, rolling out r105017.
4034         http://trac.webkit.org/changeset/105017
4035         https://bugs.webkit.org/show_bug.cgi?id=76333
4036
4037         broke the build (Requested by philn-tp on #webkit).
4038
4039         * gtk/jhbuild.modules:
4040
4041 2012-01-14  Mario Sanchez Prada  <msanchez@igalia.com>
4042
4043         [GTK] Include gtk+3 in the jhbuild modules
4044         https://bugs.webkit.org/show_bug.cgi?id=76284
4045
4046         Reviewed by Philippe Normand.
4047
4048         * gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
4049
4050 2012-01-13  Adam Barth  <abarth@webkit.org>
4051
4052         Remove --dry-run support from webkit-patch
4053         https://bugs.webkit.org/show_bug.cgi?id=76300
4054
4055         Reviewed by Dirk Pranke.
4056
4057         This is the rest of the patch from Bug 76300.  I landed it separtely
4058         because main.py had some stray conflict markers that I needed to clean
4059         up first.
4060
4061         * Scripts/webkitpy/test/main.py:
4062         (Tester.parse_args):
4063         (Tester._run_tests):
4064
4065 2012-01-13  Adam Barth  <abarth@webkit.org>
4066
4067         test-webkitpy does not run
4068         https://bugs.webkit.org/show_bug.cgi?id=76318
4069
4070         Unreviewed.
4071
4072         Looks like some conflict markers got left in the file.
4073
4074         * Scripts/webkitpy/test/main.py:
4075         (Tester.run):
4076
4077 2012-01-13  Adam Barth  <abarth@webkit.org>
4078
4079         Remove --dry-run support from webkit-patch
4080         https://bugs.webkit.org/show_bug.cgi?id=76300
4081
4082         Reviewed by Dirk Pranke.
4083
4084         We don't use this functionality for anything, and it doesn't really
4085         work.  Someone in #webkit tried using it and and got sad/confused.  We
4086         should just remove it.
4087
4088         * Scripts/webkitpy/common/checkout/scm/git.py:
4089         (Git.push_local_commits_to_server):
4090         * Scripts/webkitpy/common/checkout/scm/scm.py:
4091         (SCM.__init__):
4092         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
4093         (_shared_test_commit_with_message):
4094         (GitSVNTest.test_commit_text_parsing):
4095         * Scripts/webkitpy/common/checkout/scm/svn.py:
4096         (SVN.commit_with_message):
4097         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4098         (Bugzilla.__init__):
4099         (Bugzilla.quips):
4100         (Bugzilla.authenticate):
4101         (Bugzilla.add_attachment_to_bug):
4102         (Bugzilla.add_patch_to_bug):
4103         (Bugzilla.create_bug):
4104         (Bugzilla.clear_attachment_flags):
4105         (Bugzilla.set_flag_on_attachment):
4106         (Bugzilla.obsolete_attachment):
4107         (Bugzilla.add_cc_to_bug):
4108         (Bugzilla.post_comment_to_bug):
4109         (Bugzilla.close_bug_as_fixed):
4110         (Bugzilla.reassign_bug):
4111         (reopen_bug):
4112         * Scripts/webkitpy/test/main.py:
4113         (Tester.parse_args):
4114         (Tester.run_tests):
4115
4116 2012-01-13  David Levin  <levin@chromium.org>
4117
4118         check-webkit-style: should encourage the use of Own* classes for Windows DC.
4119         https://bugs.webkit.org/show_bug.cgi?id=76227
4120
4121         Reviewed by Dirk Pranke.
4122
4123         * Scripts/webkitpy/style/checkers/cpp.py:
4124         (check_for_leaky_patterns): The new check.
4125         (process_line): Added a call to the new check.
4126         (CppChecker): Added the new error type.
4127         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4128         (CppStyleTestBase):
4129         (CppStyleTestBase.perform_leaky_pattern_check):
4130         The check for only leaky pattern errors.
4131         (LeakyPatternTest): Test cases.
4132
4133 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
4134
4135         test-webkitpy: clean up handling of test directories, QueueStatusServer
4136         https://bugs.webkit.org/show_bug.cgi?id=76238
4137
4138         Reviewed by Adam Barth.
4139
4140         This patch cleans up a bunch of hacks related to how we find all
4141         of the python unit tests and set up the sys.path variable in
4142         test-webkitpy.
4143
4144         This patch changes how test-webkitpy works slightly in that we
4145         will now look for test files under Tools/Scripts and Source/WebKit2/Scripts
4146         rather than just Tools/Scripts/webkitpy and Source/WebKit2/Scripts/webkit.
4147         This greatly simplifies the mapping of paths to module names and
4148         appears to have no significant performance impact or other drawbacks.
4149
4150         There are other ways that we could remove all of the hacks and
4151         still have a more flexible mapping of paths to module names, but
4152         the ones I've thought of so far add a decent amount of complexity to
4153         the implementation and don't seem to buy us much.
4154         
4155         * QueueStatusServer/__init__.py:
4156         * Scripts/test-webkitpy:
4157         * Scripts/webkitpy/test/main.py:
4158         (Tester._modules_from_paths):
4159         (Tester._is_module):
4160
4161 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
4162
4163         test-webkitpy: should support classes and individual test names as well as modules
4164         https://bugs.webkit.org/show_bug.cgi?id=76233
4165
4166         Reviewed by Adam Barth.
4167
4168         The default unittest.main() supports a list of individual
4169         TestCase classes or individual tests as well as modules. This
4170         change adds support for the same to test-webkitpy, so now you
4171         can say
4172
4173           % test-wekbitpy webkitpy.test.cat_unittest.CatTest
4174
4175         and
4176
4177           % test-wekbitpy webkitpy.test.cat_unittest.CatTest.test_basic
4178
4179         in addition to
4180
4181           % test-wekbitpy webkitpy.test.cat_unittest
4182
4183         * Scripts/test-webkitpy:
4184         * Scripts/webkitpy/test/cat_unittest.py:
4185         * Scripts/webkitpy/test/main.py:
4186         (Tester.parse_args):
4187         (Tester.run):
4188         (Tester):
4189         (Tester._find_modules):
4190         (Tester._exclude):
4191         (Tester._run_tests):
4192         (Tester._is_module):
4193         (Tester._log_exception):
4194
4195 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
4196
4197         test-webkitpy: add basic code coverage support
4198         https://bugs.webkit.org/show_bug.cgi?id=76201
4199
4200         Reviewed by Adam Barth.
4201
4202         This test adds basic code coverage support to test-webkitpy; if
4203         you pass the -c flag, we will generate a new coverage file. We
4204         can start simply with this and add more features as necessary.
4205
4206         This patch requires coverage to be already installed on the
4207         machine. I am not auto-installing this for now.
4208
4209         * Scripts/webkitpy/test/main.py:
4210         (Tester.parse_args):
4211         (Tester.run_tests):
4212
4213 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
4214
4215         StatusBubbleTest.test_build_bubble is failing
4216         https://bugs.webkit.org/show_bug.cgi?id=76222
4217
4218         Reviewed by Adam Barth.
4219
4220         * QueueStatusServer/handlers/statusbubble_unittest.py:
4221         (StatusBubbleTest.test_build_bubble):
4222
4223 2012-01-13  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
4224
4225         nrwt should use multiple http shards
4226         https://bugs.webkit.org/show_bug.cgi?id=75958
4227
4228         Add --max-locked-shards option to the nrwt for manual set
4229         the maximum number of the locked shards
4230
4231         Reviewed by Dirk Pranke.
4232
4233         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4234         (Manager._max_locked_shards):
4235         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
4236         (ShardingTests.get_shards):
4237         (ShardingTests.test_multiple_locked_shards):
4238         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4239         (parse_args):
4240
4241 2012-01-13  Raphael Kubo da Costa  <kubo@profusion.mobi>
4242
4243         prepare-ChangeLog: Look for a text editor in a few more variables.
4244         https://bugs.webkit.org/show_bug.cgi?id=76289
4245
4246         Reviewed by Ryosuke Niwa.
4247
4248         A text editor was looked for only in the CHANGE_LOG_EDITOR and
4249         CHANGE_LOG_EDIT_APPLICATION environment variables before falling back
4250         to the OS X-specific open(1) command.
4251
4252         As there does not seem to be a common way of looking for a text editor
4253         among the scripts in Tools/Scripts right now, just look at $VISUAL and
4254         $EDITOR (set much more often than the other variables in Unix systems)
4255         before falling back to open(1).
4256
4257         * Scripts/prepare-ChangeLog:
4258         (openChangeLogs):
4259
4260 2012-01-13  Gabor Rapcsanyi  <rgabor@webkit.org>
4261
4262         [GTK] gtkdoc.py ignoring LDFLAGS and CFLAGS environment variables
4263         https://bugs.webkit.org/show_bug.cgi?id=76269
4264
4265         Reviewed by Martin Robinson.
4266
4267         * gtk/gtkdoc.py:
4268         (GTKDoc._run_gtkdoc_scangobj):
4269
4270 2012-01-13  Csaba Osztrogonác  <ossy@webkit.org>
4271
4272         [Qt][WK2]REGRESSION(r104881):It broke hundreds of tests
4273         https://bugs.webkit.org/show_bug.cgi?id=76247
4274
4275         Reviewed by Kenneth Rohde Christiansen.
4276
4277         * WebKitTestRunner/TestController.cpp:
4278         (WTR::TestController::resetStateToConsistentValues): Disable mock scrollbars on Qt by default. (workaround)
4279
4280 2012-01-13  Hajime Morrita  <morrita@chromium.org>
4281
4282         [Mac][DRT] Should support --no-timeout
4283         https://bugs.webkit.org/show_bug.cgi?id=76242
4284
4285         Reviewed by Darin Adler.
4286
4287         * DumpRenderTree/mac/DumpRenderTree.mm:
4288         (initializeGlobalsFromCommandLineOptions): Added "--no-timeout" to the options list.
4289         (setWaitToDumpWatchdog): Added to encapsulate the waitToDumpWatchdog global variable.
4290         (shouldSetWaitToDumpWatchdog): Added to check the useTimeoutWatchdog flag set by the option.
4291         * DumpRenderTree/mac/DumpRenderTreeMac.h:
4292         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4293         (LayoutTestController::setWaitToDump): Now calls shouldSetWaitToDumpWatchdog() to check the flag.
4294
4295 2012-01-12  Simon Fraser  <simon.fraser@apple.com>
4296
4297         Mitigate scrollbar differences when running pixel tests
4298         https://bugs.webkit.org/show_bug.cgi?id=67217
4299
4300         Reviewed by Dan Bernstein.
4301         
4302         Enable mock scrollbars by default for tests.
4303
4304         * DumpRenderTree/mac/DumpRenderTree.mm:
4305         (resetDefaultsToConsistentValues):
4306         * WebKitTestRunner/TestController.cpp:
4307         (WTR::TestController::resetStateToConsistentValues):
4308
4309 2012-01-12  Ryosuke Niwa  <rniwa@webkit.org>
4310
4311         Need a script to run tests in PerformanceTests
4312         https://bugs.webkit.org/show_bug.cgi?id=76132
4313
4314         Reviewed by Adam Barth.
4315
4316         Add run-perf-tests to run performance tests using parser/resources/runner.js.
4317         Unfortunately, there isn't an easy way of telling which test uses which format
4318         so hard-code directory that uses Chromium perf-bot style (only inspector perf. tests for now).
4319
4320         All test outputs are re-formatted to match Chromium perf-bot style.
4321
4322         * Scripts/run-inspector-perf-tests.py:
4323         * Scripts/run-perf-tests: Added.
4324         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4325         (PerfTestsRunner):
4326         (PerfTestsRunner.__init__):
4327         (PerfTestsRunner._collect_tests):
4328         (PerfTestsRunner.run):
4329         (PerfTestsRunner._print_status):
4330         (PerfTestsRunner._run_tests_set):
4331         (PerfTestsRunner._process_chromium_style_test_result):
4332         (PerfTestsRunner._should_ignore_line_in_parser_test_result):
4333         (PerfTestsRunner._process_parser_test_result):
4334         (PerfTestsRunner._run_single_test):
4335         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
4336         (MainTest.TestDriver.run_test):
4337         (create_runner):
4338         (run_test):
4339         (test_run_test_set):
4340         (test_run_test_set_for_parser_tests):
4341         (test_collect_tests):
4342
4343 2012-01-12  Dirk Pranke  <dpranke@chromium.org>
4344
4345         webkitpy: clean up port unit tests in preparation for making port_name mandatory
4346         https://bugs.webkit.org/show_bug.cgi?id=76123
4347
4348         Reviewed by Adam Barth.
4349
4350         This change updates the unit tests to be more consistent in how
4351         ports are created, in preparation for making port_name a
4352         mandatory parameter to the constructor and removing any version
4353         interpretation from it.
4354
4355         There should be no functional changes in this patch, but some
4356         tests that are no longer relevant have been removed or reworked.
4357
4358         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
4359         (PortTest.test_get_option__default):
4360         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
4361         (ChromiumLinuxPortTest):
4362         (ChromiumLinuxPortTest.assert_architecture):
4363         (ChromiumLinuxPortTest.test_determine_architecture_fails):
4364         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
4365         (ChromiumMacPortTest):
4366         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
4367         (ChromiumPortTest):
4368         (ChromiumPortTest.test_all_test_configurations):
4369         (ChromiumPortTest.TestMacPort.__init__):
4370         (ChromiumPortTest.TestLinuxPort.__ini