Add navigator.registerProtocolHandler behind a flag.
[WebKit-https.git] / Tools / ChangeLog
1 2011-02-03  James Kozianski  <koz@chromium.org>
2
3         Reviewed by Dimitri Glazkov.
4
5         Add navigator.registerProtocolHandler behind a flag.
6         https://bugs.webkit.org/show_bug.cgi?id=52609
7
8         * Scripts/build-webkit:
9
10 2011-02-03  Hayato Ito  <hayato@chromium.org>
11
12         Reviewed by Eric Seidel.
13
14         [NRWT] Remove TestArgs class, which is wrongly used.
15
16         https://bugs.webkit.org/show_bug.cgi?id=53063
17
18         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
19         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
20         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
21         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
22         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
23         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
24
25 2011-02-03  Andrew Wason  <rectalogic@rectalogic.com>
26
27         Reviewed by Kenneth Russell.
28
29         Change ENABLE_3D_CANVAS to ENABLE_WEBGL
30         https://bugs.webkit.org/show_bug.cgi?id=53714
31
32         * Scripts/build-webkit: change --3d-canvas build option
33           to set ENABLE_WEBGL
34
35 2011-02-03  Hayato Ito  <hayato@chromium.org>
36
37         Reviewed by Tony Chang.
38
39         [NRWT] Introduces Input/Output class used by base.Driver into port/base.py and
40         move _run_single_test() and _process_output() functions from
41         dump_render_tree_thread.py to a single_test_runner.py as an individual module.
42
43         This is clean up and acts as a preparation for elimination of test_types/*
44         classes. These classes will move to the single_test_runner module introduced
45         in this patch.
46
47         https://bugs.webkit.org/show_bug.cgi?id=53004
48
49         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
50         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Added.
51         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
52         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Removed.
53         * Scripts/webkitpy/layout_tests/port/base.py:
54         * Scripts/webkitpy/layout_tests/port/chromium.py:
55         * Scripts/webkitpy/layout_tests/port/dryrun.py:
56         * Scripts/webkitpy/layout_tests/port/test.py:
57         * Scripts/webkitpy/layout_tests/port/webkit.py:
58         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
59         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
60         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
61
62 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
63
64         Unreviewed, build fix.
65
66         Delete a line that was accidentally missed in r77586; without it
67         there is still a race between the two threads.
68
69         https://bugs.webkit.org/show_bug.cgi?id=51572
70
71         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
72
73 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
74
75         Reviewed by Tony Chang.
76
77         nrwt: handle "broken pipe" notifications from DRT more cleanly.
78
79         https://bugs.webkit.org/show_bug.cgi?id=52927
80
81         * Scripts/webkitpy/layout_tests/port/server_process.py:
82         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
83
84 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
85
86         Reviewed by Kenneth Russell.
87
88         Update, resubmit change to bug 51572. I think the race that was
89         fixed in r76703 caused the hang that caused us to roll this
90         patch out before, so I'd like to try again.
91
92         https://bugs.webkit.org/show_bug.cgi?id=51572
93
94         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
95         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
96
97 2011-02-03  Daniel Cheng  <dcheng@chromium.org>
98
99         Unreviewed.
100
101         Adding myself to committers.py.
102
103         * Scripts/webkitpy/common/config/committers.py:
104
105 2011-02-03  Adam Roben  <aroben@apple.com>
106
107         Include the crashing function in the link to a crash log
108
109         Fixes <http://webkit.org/b/53739> Crash log links in results.html should include the
110         function that crashed
111
112         Reviewed by David Kilzer.
113
114         * Scripts/old-run-webkit-tests:
115         (crashLocation): Added. Returns the location of the crash.
116         (linksForErrorTest): Include the crash location in the link text for the crash log, if one
117         could be determined.
118
119 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
120
121         Unreviewed, build fix.
122
123         Actually make the changes suggested by Mihai in his review
124         of bug 53720 :(
125
126         https://bugs.webkit.org/show_bug.cgi?id=53720
127
128         * Scripts/webkitpy/layout_tests/port/test_files.py:
129         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
130
131 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
132
133         Reviewed by Mihai Parparita.
134
135         new-run-webkit-tests: Fix bug introduced in r77434 that was
136         causing us to run the canvas GPU tests on the Mac GPU port. This
137         bug revealed that we were not setting the port.name() field
138         properly in many cases, so I've cleaned up all of that code, and
139         removed a few comments about "version-specific" GPU ports that
140         don't exist and just confused things.
141
142         Testing also revealed that port.abspath_for_test() wasn't
143         normalizing paths on Windows properly, so I fixed that as well.
144
145         https://bugs.webkit.org/show_bug.cgi?id=53719
146
147         * Scripts/webkitpy/layout_tests/port/base.py:
148         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
149         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
150
151 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
152
153         Reviewed by Mihai Parparita.
154
155         new-run-webkit-tests: fix normalization of paths on windows when gathering files
156
157         r77434 introduced a bug that was causing the test expectations
158         for the GPU ports to not be treated properly. It turns out that
159         when we gathered the list of test files on Windows, we would
160         return paths of the form "c:\LayoutTests/fast/canvas", and the
161         mixture of backslashes and forward slashes was confusing things.
162
163         This patch normalizes all of the filenames returned from
164         test_files.find(), and adds better tests for this (fixing a
165         couple of other bugs found in the meantime).
166
167         https://bugs.webkit.org/show_bug.cgi?id=53720
168
169         * Scripts/webkitpy/layout_tests/port/test.py:
170         * Scripts/webkitpy/layout_tests/port/test_files.py:
171         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
172
173 2011-02-03  Adam Roben  <aroben@apple.com>
174
175         Add links to Windows crash logs in results.html
176
177         Fixes <http://webkit.org/b/53718> run-webkit-tests should link to Windows crash logs in
178         results.html
179
180         Reviewed by David Kilzer.
181
182         * Scripts/old-run-webkit-tests:
183         (top level): Added $crashLogTag and $windowsCrashLogFilePrefix (which came from
184         createDebuggerCommandFile).
185         (testCrashedOrTimedOut): If the test crashed, capture any saved crash log after the dump
186         tool has exited.
187         (captureSavedCrashLog): Added. Finds the crash log for the test that just crashed and moves
188         it into the test results directory tree. Only implemented for Cygwin currently.
189         (findNewestFileMatchingGlob): Added. Does what it says.
190         (htmlForResultsSection): Only link to files that exist.
191         (linksForErrorTest): Add a link to the crash log.
192         (deleteExpectedAndActualResults): Delete any old crash log for this test.
193         (createDebuggerCommandFile): Use the new $windowsCrashLogFilePrefix constant instead of
194         hardcoding it here.
195
196 2011-02-03  Adam Roben  <aroben@apple.com>
197
198         Tell the debugger the path to the WebKit source tree when saving a crash log
199
200         This allows the debugger to include the crashing line of code in the log.
201
202         Fixes <http://webkit.org/b/53678> Crash logs from buildslaves don't show the crashing line
203         of code
204
205         Reviewed by Sam Weinig.
206
207         * Scripts/old-run-webkit-tests:
208         (createDebuggerCommandFile): Added. Saves commands that we'd like the debugger to run to a
209         file and returns the path to that file. The commands we pass came from
210         setUpWindowsCrashLogSaving, but I've added a .srcpath command to tell the debugger where the
211         WebKit source code lives.
212         (setUpWindowsCrashLogSaving): Instead of specifying the commands directly on the command
213         line using -c, save them to a file and specify the path to that file using -cf. This works
214         around what is presumably a bug in Windows's command line parsing, where having multiple
215         quoted paths in the debugger commands causes the post-mortem debugger not to be invoked at
216         all. Also pulled the options we pass to the debugger out into a list that is then join()ed
217         together to make them easier to modify in the future.
218
219 2011-02-02  Sam Weinig  <sam@webkit.org>
220
221         Reviewed by Anders Carlsson.
222
223         Add notification of the end of a rubber band.
224         <rdar://problem/8940648>
225
226         * MiniBrowser/mac/BrowserWindowController.m:
227         (-[BrowserWindowController awakeFromNib]):
228         * WebKitTestRunner/TestController.cpp:
229         (WTR::TestController::createOtherPage):
230         (WTR::TestController::initialize):
231         Stub out the new WKUIClient function.
232
233 2011-02-03  Gabor Rapcsanyi  <rgabor@webkit.org>
234
235         Unreviewed.
236
237         Adding myself to committers.py.
238
239         * Scripts/webkitpy/common/config/committers.py:
240
241 2011-02-03  Balazs Kelemen  <kbalazs@webkit.org>
242
243         Reviewed by Csaba Osztrogonác.
244
245         [Qt][WK2] MiniBrowser's window size should be 800x600
246         https://bugs.webkit.org/show_bug.cgi?id=53670
247
248         Make layout test failure debugging easier.
249         * MiniBrowser/qt/BrowserWindow.cpp:
250         (BrowserWindow::BrowserWindow):
251
252 2011-02-02  Andy Estes  <aestes@apple.com>
253
254         Reviewed by Mark Rowe.
255
256         'update-webkit' should handle OpenSource and Internal using different
257         VCSs.
258
259         * Scripts/update-webkit: Re-check the VCS type when updating Apple's
260         Internal directory.
261
262 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
263
264         Reviewed by Mihai Parparita.
265
266         new-run-webkit-tests: hardcode the directories to scan for tests
267         for GPU bots instead of SKIPping them. See bug 53562 for some
268         context, but we will now hard-code the list of directories to
269         use by default instead of skipping over directories in the
270         expectations file. We do this so that we will be able to merge
271         the expectations files without getting conflicting SKIP
272         directives. Note that this change will reduce the # of tests
273         being run on the Mac GPU bots, because we're accidentally
274         including some today.
275
276         https://bugs.webkit.org/show_bug.cgi?id=53631
277
278         * Scripts/webkitpy/layout_tests/port/base.py:
279         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
280         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
281
282 2011-02-02  Sam Weinig  <sam@webkit.org>
283
284         Reviewed by Beth Dakin.
285
286         Add ChromeClient function to paint custom overhang areas.
287         https://bugs.webkit.org/show_bug.cgi?id=53639
288
289         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
290         (WTR::InjectedBundlePage::InjectedBundlePage):
291         Stub out new callback.
292
293 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
294
295         Reviewed by Tony Chang.
296
297         new-run-webkit-tests: support chromium code paths in mock_drt
298
299         https://bugs.webkit.org/show_bug.cgi?id=53471
300
301         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
302         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
303
304 2011-02-02  Adam Klein  <adamk@chromium.org>
305
306         Reviewed by Tony Chang.
307
308         Update new-run-webkit-tests --chromium to put output under Source/...
309         https://bugs.webkit.org/show_bug.cgi?id=53612
310
311         * BuildSlaveSupport/test-result-archive:
312         * Scripts/webkitpy/layout_tests/port/chromium.py:
313
314 2011-01-28  Tony Chang  <tony@chromium.org>
315
316         Reviewed by Eric Seidel.
317
318         [chromium] remove --use-test-shell from NRWT
319         https://bugs.webkit.org/show_bug.cgi?id=53346
320
321         I've already started removing some of the bindings like eventSender so
322         this already doesn't work isn't useful.  Also updated some comments to
323         refer to DRT instead of test_shell.
324
325         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
326         * Scripts/webkitpy/layout_tests/port/chromium.py:
327         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
328         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
329         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
330         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
331         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
332         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
333
334 2011-02-02  Steve Lacey  <sjl@chromium.org>
335
336         Reviewed by Eric Carlson.
337
338         Implement basic media statistics on media elements.
339         https://bugs.webkit.org/show_bug.cgi?id=53322
340
341         * Scripts/build-webkit:
342
343 2011-02-02  Kevin Ollivier  <kevino@theolliviers.com>
344
345         [wx] Build fixes for wxWebKit.
346
347         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
348         (LayoutTestController::setSerializeHTTPLoads):
349         * wx/browser/wscript:
350         * wx/build/build_utils.py:
351         * wx/build/settings.py:
352
353 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
354
355         Reviewed by Mihai Parparita.
356
357         new-run-webkit-tests: stop skipping so many tests
358
359         r77163 introduced a regression where we weren't resetting test
360         expectations properly and were skipping too many tests as a
361         result. This patch fixes that and adds a test for it.
362
363         https://bugs.webkit.org/show_bug.cgi?id=53551
364
365         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
366         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
367
368 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
369
370         Reviewed by Tony Chang.
371
372         new-run-webkit-tests: add first stub of test_runner2. This
373         will add support for the 'inline', 'threads', and 'processes'
374         flags to --worker-model, but for now the implementatios just
375         fall back on the old ones.
376
377         https://bugs.webkit.org/show_bug.cgi?id=53157
378
379         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
380         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
381
382 2011-02-01  Mihai Parparita  <mihaip@chromium.org>
383
384         Reviewed by James Robinson.
385
386         [Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
387         https://bugs.webkit.org/show_bug.cgi?id=53522
388
389         * Scripts/run-chromium-webkit-unit-tests:
390
391 2011-02-01  Adam Barth  <abarth@webkit.org>
392
393         Reviewed by Mihai Parparita.
394
395         Using Control-C to cancel webkit-patch or other python tools causes
396         unpleasant traceback console spew
397         https://bugs.webkit.org/show_bug.cgi?id=53462
398
399         Catch the exception and don't print the stack trace.
400
401         * Scripts/webkit-patch:
402
403 2011-02-01  Scott Cameron  <sccameron@rim.com>
404
405         Reviewed by Daniel Bates.
406
407         Use Windows format for MinGW HTTPD path.
408         https://bugs.webkit.org/show_bug.cgi?id=53503
409
410         * Scripts/webkitperl/httpd.pm:
411           - Use single-quotes around MySys value for $httpdPath in getHTTPDPath()
412             so that we don't have to escape the space characters in the path. Also,
413             changed path to Windows-style path and removed FIXME comment.
414
415 2011-02-01  Balazs Kelemen  <kbalazs@webkit.org>
416
417         Reviewed by Andreas Kling.
418
419         [Qt][WK2] Add a way to use shared process model in MiniBrowser
420         https://bugs.webkit.org/show_bug.cgi?id=53090
421
422         * MiniBrowser/qt/BrowserView.cpp:
423         (BrowserView::BrowserView): Removed the m_context member.
424         From now the context is guaranteed to be non-null and we
425         don't need to store that in the object.
426         * MiniBrowser/qt/BrowserView.h:
427         * MiniBrowser/qt/BrowserWindow.cpp:
428         Added static bool to determine that new windows need to be
429         created with their own context or not. Use the same context
430         and web process by default to be inilne with the other ports.
431         (BrowserWindow::BrowserWindow):
432         (BrowserWindow::newWindow):
433         * MiniBrowser/qt/BrowserWindow.h:
434         * MiniBrowser/qt/main.cpp:
435         (main): Added command line switch to be able to use the
436         non-shared process model. Simplify the handling of the command line
437         switches a little bit.
438
439 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
440
441         Reviewed by Andreas Kling.
442
443         [Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
444         https://bugs.webkit.org/show_bug.cgi?id=53491
445
446         * MiniBrowser/qt/BrowserWindow.cpp:
447         (BrowserWindow::BrowserWindow):
448         (BrowserWindow::toggleFullScreenMode):
449         * MiniBrowser/qt/BrowserWindow.h:
450
451 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
452
453         Reviewed by Andreas Kling.
454
455         [Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
456         https://bugs.webkit.org/show_bug.cgi?id=53489
457
458         Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
459         to Settings menu.
460
461         * MiniBrowser/qt/BrowserWindow.cpp:
462         (BrowserWindow::BrowserWindow):
463         (BrowserWindow::toggleFrameFlattening):
464         (BrowserWindow::toggleDisableJavaScript):
465         (BrowserWindow::toggleAutoLoadImages):
466         * MiniBrowser/qt/BrowserWindow.h:
467
468 2011-01-31  Mihai Parparita  <mihaip@chromium.org>
469
470         Reviewed by Tony Chang.
471
472         [Chromium] Switch chromium-mac to use ChromiumDriver
473         https://bugs.webkit.org/show_bug.cgi?id=53461
474         
475         For the sake of consistency with the other Chromium platforms (and so
476         that chromium-mac picks up special flags like --enable-hardware-gpu),
477         switch chromium-mac from the WebKitDriver to ChromiumDriver.
478
479         * Scripts/webkitpy/layout_tests/port/chromium.py:
480
481 2011-01-31  Dirk Pranke  <dpranke@chromium.org>
482
483         Reviewed by Mihai Parparita.
484
485         The current modifier parsing code in test_expectations is
486         fragile and hard-coded, so it's not easy to understand the logic
487         or easily add new types of modifiers (like GPU vs. CPU testing
488         for graphics tests, or 32-bit vs. 64-bit differences).
489
490         This is the first of two patches that will add in more generic
491         support and then eliminate the GPU-specific test expectations
492         files for Chromium.
493
494         This patch adds two standalone objects for handling modifiers. The
495         rules for interpreting modifiers, precedence, and conflicts are
496         given in the docstring to the ModifierMatcher class, which
497         returns ModifierMatchResult objects.
498         
499         This patch also adds routines to the Port interface and a
500         default set of values in the base object, in order to obtain the
501         values needed on a given test run. These values are then passed
502         to the expectation parser. This also allows us to clean up the
503         logic used to lint all of the different configurations in a
504         single test_expectations.txt file.
505
506         The next patch will merge in the separate GPU expectations file.
507
508         https://bugs.webkit.org/show_bug.cgi?id=51222
509
510         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
511         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
512         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
513         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
514         * Scripts/webkitpy/layout_tests/port/base.py:
515         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
516         * Scripts/webkitpy/layout_tests/port/chromium.py:
517         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
518         * Scripts/webkitpy/layout_tests/port/test.py:
519         * Scripts/webkitpy/layout_tests/port/webkit.py:
520         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
521         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
522         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
523         * Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
524         * Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
525
526 2011-01-31  Scott Cameron  <sccameron@rim.com>
527
528         Reviewed by Daniel Bates.
529
530         update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
531         https://bugs.webkit.org/show_bug.cgi?id=50036
532
533         This will add an Apache2.2 configuration file and modifies scripts to allow
534         running an httpd server in an MSYS environment.
535
536         The default Apache2.2 installation path has been preserved and PHP5 modules disabled
537         in order to allow for simple installation/execution.  Simply install the latest
538         Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
539         be able to execute run-webkit-httpd.
540         
541
542         * Scripts/run-webkit-httpd:
543         * Scripts/webkitperl/httpd.pm:
544
545 2011-01-31  Tony Chang  <tony@chromium.org>
546
547         Reviewed by Eric Seidel.
548
549         mac DRT should report RTL scroll offset relative to top right corner
550         https://bugs.webkit.org/show_bug.cgi?id=53324
551
552         * DumpRenderTree/mac/DumpRenderTree.mm:
553         (dumpFrameScrollPosition):
554
555 2011-01-31  Zoltan Horvath  <zoltan@webkit.org>
556
557         Reviewed by Andreas Kling.
558
559         [Qt] Add Take Screen Shot action to MiniBrowser
560         https://bugs.webkit.org/show_bug.cgi?id=53422
561
562         Add Take Screen Shot action to MiniBrowser's view menu.
563
564         * MiniBrowser/qt/BrowserWindow.cpp:
565         (BrowserWindow::BrowserWindow):
566         (BrowserWindow::screenshot):
567         * MiniBrowser/qt/BrowserWindow.h:
568
569 2011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
570
571         Reviewed by Xan Lopez.
572
573         [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
574         https://bugs.webkit.org/show_bug.cgi?id=53379
575
576         Remove left over #ifdef's. I thought all of the conditional code
577         had been freed from the condition, but I forgot to check DRT.
578
579         * DumpRenderTree/gtk/DumpRenderTree.cpp:
580         (resetDefaultsToConsistentValues):
581         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
582         (LayoutTestController::setAlwaysAcceptCookies):
583
584 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
585
586         Unreviewed, build fix.
587
588         Fix regression introduced in r77093 - path.rsplit() doesn't
589         take keyword arguments.
590
591         https://bugs.webkit.org/show_bug.cgi?id=53326
592
593         * Scripts/webkitpy/common/system/filesystem_mock.py:
594
595 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
596
597         Reviewed by Mihai Parparita.
598
599         Add more unit tests for rebaseline-chromium-webkit-tests. This
600         change involves restructuring a bunch of r-c-w-t code to make it
601         more testable as well. We also add wrapper classes for handling
602         testing zip files and fetching URLs.
603
604         https://bugs.webkit.org/show_bug.cgi?id=53040
605
606         * Scripts/webkitpy/common/system/urlfetcher.py:
607         * Scripts/webkitpy/common/system/urlfetcher_mock.py:
608         * Scripts/webkitpy/common/system/zipfileset_mock.py:
609         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
610         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
611         * Scripts/webkitpy/tool/mocktool.py:
612
613 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
614
615         Reviewed by Eric Seidel.
616
617         Clean up of the filesystem-related modules used in webkitpy.
618         I've added relpath() to the filesystem interface, modified
619         ospath.relpath() so that it could work with the filesystem
620         interface, and modified the fileset* routines to use the
621         filesystem interface consistently.
622
623         This patch also adds a close() routine to the fileset routines
624         to indicate that the caller is done with the fileset. This
625         allows zipfileset to clean up after itself when it creates
626         tempfiles to store downloads.
627
628         https://bugs.webkit.org/show_bug.cgi?id=53326
629
630         * Scripts/webkitpy/common/system/directoryfileset.py:
631         * Scripts/webkitpy/common/system/fileset.py:
632         * Scripts/webkitpy/common/system/filesystem.py:
633         * Scripts/webkitpy/common/system/filesystem_mock.py:
634         * Scripts/webkitpy/common/system/filesystem_unittest.py:
635         * Scripts/webkitpy/common/system/ospath.py:
636         * Scripts/webkitpy/common/system/zipfileset.py:
637         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
638
639 2011-01-30  Balazs Kelemen  <kbalazs@webkit.org>
640
641         Reviewed by Csaba Osztrogonác.
642
643         [Qt][WK2]REGRESSION (r76991): Fix build errors
644         https://bugs.webkit.org/show_bug.cgi?id=53400
645
646         Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
647         and remove WebKit2Prefix.h from the build.
648         * MiniBrowser/qt/MiniBrowser.pro:
649
650 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
651
652         Unreviewed.
653
654         [Qt][WK2] Buildfix.
655
656         * MiniBrowser/qt/MiniBrowser.pro:
657
658 2011-01-28  Simon Fraser  <simon.fraser@apple.com>
659
660         Reviewed by Adam Roben.
661         
662         define NOMINMAX when building ImageDiff, as we do elsewhere.
663
664         Add various clampToInt() methods to MathExtras.h
665         https://bugs.webkit.org/show_bug.cgi?id=52910
666
667         * DumpRenderTree/win/ImageDiffCommon.vsprops:
668
669 2011-01-28  Maciej Stachowiak  <mjs@apple.com>
670
671         Reviewed by Darin Adler.
672
673         WebKitTestRunner needs layoutTestController.setPOSIXLocale
674         https://bugs.webkit.org/show_bug.cgi?id=42682
675
676         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
677         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
678         (WTR::InjectedBundle::resetLocalSettings):
679         (WTR::InjectedBundle::didReceiveMessage):
680         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
681         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
682         (WTR::LayoutTestController::setPOSIXLocale):
683         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
684
685 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
686  
687          Reviewed by Mihai Parparita.
688  
689          test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths
690  
691          This patch re-enables this test and changes it to
692          handle all of the mac platform versions, not just the one
693          it is running on.
694  
695          https://bugs.webkit.org/show_bug.cgi?id=53356
696  
697          * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
698  
699 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
700
701         Unreviewed, build fix.
702
703         Take two. The fix in 77023 didn't work, because we were
704         still calling path.abspath_to_uri, which calls _cygpath under
705         the covers, and it appears the cygpath on the bots does
706         something different than it does on my machine. This patch
707         removes the calls to path.abspath_to_uri, so it should be safe.
708         If it doesn't work, I'll roll it out along with r76982 and 77023.
709
710         https://bugs.webkit.org/show_bug.cgi?id=53126
711
712         * Scripts/webkitpy/layout_tests/port/test.py:
713
714 2011-01-28  David Kilzer  <ddkilzer@apple.com>
715
716         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 
717         <http://webkit.org/b/53353>
718
719         Reviewed by Mark Rowe.
720
721         * Scripts/webkitdirs.pm:
722         (checkRequiredSystemConfig): Check the Xcode marketing version
723         in addition to the DevCoreTools build version before complaining
724         about an old version of Xcode.  Also make the Mac OS X version
725         check use Perl's built-in version string comparitor.
726
727 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
728
729         Unreviewed, build fix.
730
731         Work around breakage on Win 7 Release bot caused by r76982
732         and the fact that windows ports use "file:////" instead of
733         "file:///". Ideally the test code should be isolated from
734         this, but it isn't yet. Will fix properly in a bit.
735
736         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
737
738 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
739
740         Reviewed by Tony Chang.
741
742         new-run-webkit-tests: change worker model values to
743         "old-inline", "old-threads" in preparation for test_runner2 /
744         multiprocessing changes.
745
746         https://bugs.webkit.org/show_bug.cgi?id=53156
747
748         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
749         * Scripts/webkitpy/layout_tests/port/base.py:
750         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
751         * Scripts/webkitpy/layout_tests/port/mac.py:
752         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
753
754 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
755
756         Reviewed by Tony Chang.
757
758         committers.py - add an IRC nickname for dpranke
759         https://bugs.webkit.org/show_bug.cgi?id=53335
760
761         * Scripts/webkitpy/common/config/committers.py:
762
763 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
764
765         Reviewed by Tony Chang.
766
767         new-run-webkit-tests: add a "mock DRT" port implementation
768         and a separate class that emulates what we expect the
769         DumpRenderTree behavior to be.
770
771         This will eventually replace port/dryrun.py and allow us to get
772         better test coverage of the new-run-webkit-tests code as well as
773         a reference for what new-run-webkit-tests expects from DRT.
774
775         This is the first attempt at this, and it is pretty bare-boned. It
776         really only has been tested on the 'mac' port (and a little on
777         the 'chromium-mac' port.
778
779         https://bugs.webkit.org/show_bug.cgi?id=53126
780
781         * Scripts/webkitpy/common/system/filesystem_mock.py:
782         * Scripts/webkitpy/layout_tests/port/dryrun.py:
783         * Scripts/webkitpy/layout_tests/port/factory.py:
784         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
785         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
786         * Scripts/webkitpy/layout_tests/port/test.py:
787
788 2011-01-28  Pratik Solanki  <psolanki@apple.com>
789
790         Unreviewed. Removing .swp file checked in by mistake.
791
792         * Scripts/.webkitdirs.pm.swp: Removed.
793
794 2011-01-28  Pratik Solanki  <psolanki@apple.com>
795
796         Reviewed by David Kilzer.
797
798         Space not necessary for undefined feature
799         https://bugs.webkit.org/show_bug.cgi?id=53317
800
801         * Scripts/build-webkit:
802
803 2011-01-28  Chang Shu  <chang.shu@nokia.com>
804
805         Reviewed by Andreas Kling.
806
807         Reset NetworkAccessManager to clean up credentials from previous tests.
808         This change causes no performance overhead either.
809         https://bugs.webkit.org/show_bug.cgi?id=36688
810
811         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
812         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
813         (WebCore::DumpRenderTree::open):
814         * DumpRenderTree/qt/DumpRenderTreeQt.h:
815
816 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
817
818         Reviewed by Andreas Kling.
819
820         [Qt] Add Zoom Text Only action to MiniBrowser
821         https://bugs.webkit.org/show_bug.cgi?id=53297
822
823         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
824
825         * MiniBrowser/qt/BrowserWindow.cpp:
826         (BrowserWindow::BrowserWindow):
827         (BrowserWindow::zoomIn):
828         (BrowserWindow::zoomOut):
829         (BrowserWindow::resetZoom):
830         (BrowserWindow::toggleZoomTextOnly):
831         (BrowserWindow::applyZoom):
832         * MiniBrowser/qt/BrowserWindow.h:
833
834 2011-01-28  Adam Barth  <abarth@webkit.org>
835
836         Reviewed by Eric Seidel.
837
838         Add webkit-patch roll-chromium-deps
839         https://bugs.webkit.org/show_bug.cgi?id=53288
840
841         This command updates the Source/WebKit/chromium/DEPS file with the
842         last-known good revision of Chromium (or a revision specified on the
843         command line).  I'd eventually like to turn this into a SheriffBot
844         command, but this is the first step.
845
846         This patch somewhat sprawled because I needed to move a bunch of code
847         out of ChangeLog that should never have been there in the first place.
848         Also, I had to fix a bug in MockUser in order to test the new command.
849
850         * Scripts/webkitpy/common/checkout/api.py:
851         * Scripts/webkitpy/common/checkout/changelog.py:
852         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
853         * Scripts/webkitpy/common/checkout/deps.py: Added.
854         * Scripts/webkitpy/common/config/urls.py:
855         * Scripts/webkitpy/tool/commands/__init__.py:
856         * Scripts/webkitpy/tool/commands/download_unittest.py:
857         * Scripts/webkitpy/tool/commands/roll.py: Added.
858         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
859         * Scripts/webkitpy/tool/commands/upload_unittest.py:
860         * Scripts/webkitpy/tool/mocktool.py:
861         * Scripts/webkitpy/tool/steps/__init__.py:
862         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
863         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
864         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
865         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
866         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
867         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
868
869 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
870
871         Reviewed by Laszlo Gombos.
872
873         Get rid of prefix header dependency for WebKit2 build system
874         https://bugs.webkit.org/show_bug.cgi?id=50174
875
876         Change the style checker so that it enforces config.h include for
877         WebKit2.
878
879         * Scripts/webkitpy/style/checker.py:
880
881 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
882
883         Reviewed by Darin Adler.
884
885         execCommand("Paste") doesn't work in WebKitTestRunner
886         https://bugs.webkit.org/show_bug.cgi?id=52785
887
888         Enable both of the settings needed to allow paste.
889         
890         * WebKitTestRunner/TestController.cpp:
891         (WTR::TestController::resetStateToConsistentValues):
892
893 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
894
895         Reviewed by Andreas Kling.
896
897         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
898         https://bugs.webkit.org/show_bug.cgi?id=48440
899
900         Preserve user input when toggling use of QGraphicsView
901
902         * QtTestBrowser/launcherwindow.cpp:
903         (LauncherWindow::initializeView):
904         (LauncherWindow::loadFinished):
905         * QtTestBrowser/launcherwindow.h:
906         * QtTestBrowser/mainwindow.cpp:
907         (MainWindow::addressUrl):
908         * QtTestBrowser/mainwindow.h:
909
910 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
911
912         Reviewed by Mihai Parparita.
913
914         new-run-webkit-tests: turn off pixel tests correctly by default
915         for webkit-based ports. r70013 (bug 47510) used
916         port.set_option_default() to attempt to set default values, but
917         that didn't work correctly. I have removed set_option_default
918         for now since it was only being used in two places and in three
919         useless unit tests. There is a separate bug open to fix the
920         option parsing (48095), so this workaround is fine for now.
921
922         https://bugs.webkit.org/show_bug.cgi?id=53217
923
924         * Scripts/webkitpy/layout_tests/port/webkit.py:
925         * Scripts/webkitpy/layout_tests/port/base.py:
926         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
927
928 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
929
930         Rubber-stamped by Ariya Hidayat.
931
932         Trivial crash fix in WTR.
933
934         * WebKitTestRunner/TestController.cpp:
935         (WTR::TestController::initialize): Increase the size
936         of the vector by one to be able to store the null character.
937
938 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
939
940         Reviewed by Csaba Osztrogonác.
941
942         [Qt][WK2] WTR should be initialized in the same way as DRT
943         https://bugs.webkit.org/show_bug.cgi?id=53240
944
945         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
946         (WTR::activateFonts): Added missing initialization steps.
947
948 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
949
950         Unreviewed. 
951
952         Adding myself to committers.py.
953
954         * Scripts/webkitpy/common/config/committers.py:
955
956 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
957
958         Reviewed by Csaba Osztrogonác.
959
960         [Qt] [Symbian] Move project files into Source
961         https://bugs.webkit.org/show_bug.cgi?id=52891
962
963         Fix the Symbian build after the project files
964         are moved to Source directory. On Symbian qmake
965         needs to run in the same directory where the main
966         pro files (WebKit.pro, Tools.pro) are located.
967
968         * Scripts/webkitdirs.pm: Change to the directory where the pro file
969         is located before running qmake for Symbian. Qmake on Symbian
970         does not properly honor the "-o" option, work it around by setting
971         the name of the Makefile to bld.inf.
972
973 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
974
975         Reviewed by Andreas Kling.
976
977         [Qt] Add simple zooming features to MiniBrowser
978         https://bugs.webkit.org/show_bug.cgi?id=53231
979
980         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
981
982         * MiniBrowser/qt/BrowserWindow.cpp:
983         (BrowserWindow::BrowserWindow):
984         (BrowserWindow::zoomIn):
985         (BrowserWindow::zoomOut):
986         (BrowserWindow::resetZoom):
987         (BrowserWindow::updateUserAgentList):
988         (BrowserWindow::applyZoom):
989         * MiniBrowser/qt/BrowserWindow.h:
990
991 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
992
993         Reviewed by Dan Bernstein.
994
995         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
996         https://bugs.webkit.org/show_bug.cgi?id=42319
997         
998         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
999
1000         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1001         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1002         (WTR::LayoutTestController::showWebInspector):
1003         (WTR::LayoutTestController::closeWebInspector):
1004         (WTR::LayoutTestController::evaluateInWebInspector):
1005         (WTR::LayoutTestController::setTimelineProfilingEnabled):
1006         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1007         * WebKitTestRunner/TestInvocation.cpp:
1008         (WTR::shouldOpenWebInspector):
1009         (WTR::TestInvocation::invoke):
1010         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1011
1012 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
1013
1014         Reviewed by Xan Lopez.
1015
1016         [GTK] Pixel dumps do not include scrollbars in output images
1017         https://bugs.webkit.org/show_bug.cgi?id=53216
1018
1019         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
1020         that have scrollbars.
1021
1022         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1023         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
1024         instead of the web view itself.
1025
1026 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1027
1028         Reviewed by Mihai Parparita.
1029
1030         Fix regression introduced in r76322 ... new-run-webkit-tests
1031         was attempting to save the image diff output as a UTF-8-encoded
1032         file.
1033
1034         https://bugs.webkit.org/show_bug.cgi?id=53210
1035
1036         * Scripts/webkitpy/layout_tests/port/webkit.py:
1037
1038 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1039
1040         Unreviewed, rolling out r76709.
1041         http://trac.webkit.org/changeset/76709
1042         https://bugs.webkit.org/show_bug.cgi?id=53194
1043
1044         "broke python tests on non-snowleopard platforms" (Requested
1045         by dpranke on #webkit).
1046
1047         * Scripts/webkitpy/layout_tests/port/factory.py:
1048         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
1049         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
1050
1051 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1052
1053         Reviewed by Tony Chang.
1054
1055         new-run-webkit-tests: add a "mock DRT" port implementation
1056         and a separate class that emulates what we expect the
1057         DumpRenderTree behavior to be.
1058
1059         This will eventually replace port/dryrun.py and allow us to get
1060         better test coverage of the new-run-webkit-tests code as well as
1061         a reference for what new-run-webkit-tests expects from DRT.
1062
1063         This is the first attempt at this, and it is pretty bare-boned. It
1064         really only has been tested on the 'mac' port (and a little on
1065         the 'chromium-mac' port.
1066
1067         https://bugs.webkit.org/show_bug.cgi?id=53126
1068
1069         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1070         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1071         * Scripts/webkitpy/layout_tests/port/factory.py:
1072
1073 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
1074
1075         Reviewed by Tony Chang.
1076
1077         Add '--no-timeout' option to Chromium DRT to ease debugging.
1078         https://bugs.webkit.org/show_bug.cgi?id=52873
1079
1080         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1081         (main):
1082
1083 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1084
1085         Reviewed by Andreas Kling.
1086
1087         [Qt] Fix qt_minimal build
1088         https://bugs.webkit.org/show_bug.cgi?id=53172
1089
1090         * QtTestBrowser/locationedit.h:
1091
1092 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
1093
1094         Reviewed by Antonio Gomes.
1095
1096         QtTestBrowser should have a UI Setting to disable plugins
1097         https://bugs.webkit.org/show_bug.cgi?id=52408
1098         
1099         Added a new action item named "Disable Plugins"
1100         under the "Settings" menu. 
1101
1102         * QtTestBrowser/launcherwindow.cpp:
1103         (LauncherWindow::createChrome):
1104         (LauncherWindow::togglePlugins):
1105         * QtTestBrowser/launcherwindow.h:
1106
1107 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1108
1109         Reviewed by Adam Barth.
1110
1111         Move main CMakeLists.txt into Source directory
1112         https://bugs.webkit.org/show_bug.cgi?id=52888
1113
1114         * Scripts/webkitdirs.pm:
1115
1116 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1117
1118         Reviewed by Eric Seidel.
1119
1120         Improve label text in submit-to-ews
1121         https://bugs.webkit.org/show_bug.cgi?id=53130
1122
1123         * QueueStatusServer/templates/submittoews.html:
1124
1125 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
1126
1127         Reviewed by Antonio Gomes.
1128
1129         QtTestBrowser should have a UI Settings to prevent loading images
1130         https://bugs.webkit.org/show_bug.cgi?id=52409
1131         
1132         Added a new action item named "DisableAutoLoadImages"
1133         under the "Settings" menu 
1134
1135         * QtTestBrowser/launcherwindow.cpp:
1136         (LauncherWindow::createChrome):
1137         (LauncherWindow::toggleAutoLoadImages):
1138         * QtTestBrowser/launcherwindow.h:
1139
1140 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
1141
1142         Reviewed by Tony Chang.
1143
1144         Minor bug fixes and cleanup for filesystem wrappers, port/* test
1145         classes, test_expectations.py. This change adds "test-win" and
1146         "test-mac" variants to the test port so that we can better test
1147         rebaselining, and adds a MockUser() object for reuse in testing.
1148
1149         https://bugs.webkit.org/show_bug.cgi?id=53036
1150
1151         * Scripts/webkitpy/common/system/filesystem.py:
1152         * Scripts/webkitpy/common/system/filesystem_mock.py:
1153         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1154         * Scripts/webkitpy/layout_tests/port/factory.py:
1155         * Scripts/webkitpy/layout_tests/port/base.py:
1156         * Scripts/webkitpy/layout_tests/port/test.py:
1157         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1158         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1159         * Scripts/webkitpy/tool/mocktool.py:
1160
1161 2011-01-25  Tony Chang  <tony@chromium.org>
1162
1163         Reviewed by Dimitri Glazkov.
1164
1165         [chromium] remove unused layoutTestController callback
1166         https://bugs.webkit.org/show_bug.cgi?id=53103
1167
1168         This method is used by a test_shell_test, but not needed by DRT.
1169
1170         * DumpRenderTree/chromium/LayoutTestController.cpp:
1171         (LayoutTestController::LayoutTestController):
1172         * DumpRenderTree/chromium/LayoutTestController.h:
1173
1174 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1175
1176         Reviewed by Andreas Kling.
1177
1178         [GTK] Remove 64 bits release bot from the buildbot master
1179         https://bugs.webkit.org/show_bug.cgi?id=52899
1180
1181         Removes the 64 bits release slave from the buildbot configuration,
1182         so that we can use it as an EWS.
1183
1184         * BuildSlaveSupport/build.webkit.org-config/config.json:
1185
1186 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1187
1188         Reviewed by Dan Bernstein.
1189
1190         Implement database quota callback to fix storage tests on WebKit2 bot
1191         https://bugs.webkit.org/show_bug.cgi?id=53064
1192
1193         * WebKitTestRunner/TestController.cpp:
1194         (WTR::exceededDatabaseQuota):
1195         (WTR::TestController::createOtherPage):
1196         (WTR::TestController::initialize):
1197
1198 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1199
1200         Reviewed by Anders Carlsson.
1201
1202         Use designated temp directory for the database for WebKit2
1203         https://bugs.webkit.org/show_bug.cgi?id=53052
1204         
1205         Adopt the new WK2 API for this.
1206
1207         * WebKitTestRunner/TestController.cpp:
1208         (WTR::TestController::libraryPathForTesting):
1209         (WTR::TestController::initialize):
1210         * WebKitTestRunner/TestController.h:
1211         * WebKitTestRunner/mac/TestControllerMac.mm:
1212         (WTR::TestController::platformLibraryPathForTesting):
1213         * WebKitTestRunner/qt/TestControllerQt.cpp:
1214         (WTR::TestController::platformLibraryPathForTesting):
1215         * WebKitTestRunner/win/TestControllerWin.cpp:
1216         (WTR::TestController::platformLibraryPathForTesting):
1217
1218 2011-01-24  Lucas Forschler  <lforschler@apple.com>
1219
1220         Reviewed by Stephanie Lewis.
1221
1222         Add a new Leopard test bot.
1223
1224         * BuildSlaveSupport/build.webkit.org-config/config.json:
1225
1226 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1227
1228         Reviewed by Adam Barth.
1229
1230         Add EFL Builder to core waterfall
1231         https://bugs.webkit.org/show_bug.cgi?id=52704
1232
1233         Add EFL Builder to the core waterfall again.
1234
1235         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1236         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1237
1238 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
1239
1240         Reviewed by Tony Chang.
1241
1242         new-run-webkit-tests fails to start HTTP server if there are proxy settings
1243         https://bugs.webkit.org/show_bug.cgi?id=52872
1244
1245         Force disabling proxy to resolve the problem.
1246
1247         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1248         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1249
1250 2011-01-24  Andreas Kling  <kling@webkit.org>
1251
1252         Reviewed by Darin Adler.
1253
1254         check-webkit-style: Update exemptions following Source/ move.
1255         https://bugs.webkit.org/show_bug.cgi?id=53017
1256
1257         * Scripts/webkitpy/style/checker.py:
1258         * Scripts/webkitpy/style/checker_unittest.py:
1259
1260 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1261
1262         Rubber-stamped by Csaba Osztrogonác.
1263
1264         [Qt] Move project files into Source
1265         https://bugs.webkit.org/show_bug.cgi?id=52891
1266
1267         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
1268
1269 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
1270
1271         Reviewed by Yury Semikhatsky.
1272
1273         Web Inspector: Find duplicate strings in localizedStrings.js
1274
1275         https://bugs.webkit.org/show_bug.cgi?id=53005
1276
1277         * Scripts/check-inspector-strings:
1278
1279 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
1280
1281         Reviewed by Andreas Kling.
1282
1283         [Qt] Regroup MiniBrowser's menubar and add open file action
1284         https://bugs.webkit.org/show_bug.cgi?id=53000
1285
1286         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
1287
1288         * MiniBrowser/qt/BrowserWindow.cpp:
1289         (BrowserWindow::BrowserWindow):
1290         (BrowserWindow::openFile):
1291         (BrowserWindow::~BrowserWindow):
1292         * MiniBrowser/qt/BrowserWindow.h:
1293
1294 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
1295
1296         Unreviewed fix after r76496
1297
1298         [Qt] Move project files into Source
1299         https://bugs.webkit.org/show_bug.cgi?id=52891
1300
1301         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
1302         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
1303         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
1304
1305 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1306
1307         Reviewed by Csaba Osztrogonác.
1308
1309         [Qt] Move project files into Source
1310         https://bugs.webkit.org/show_bug.cgi?id=52891
1311
1312         * DerivedSources.pro: Renamed from DerivedSources.pro.
1313         * DumpRenderTree/qt/DumpRenderTree.pro:
1314         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1315         * MiniBrowser/DerivedSources.pro:
1316         * MiniBrowser/qt/MiniBrowser.pro:
1317         * QtTestBrowser/QtTestBrowser.pro:
1318         * Scripts/webkitdirs.pm:
1319         * Tools.pro: Added.
1320         * WebKitTestRunner/DerivedSources.pro:
1321         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1322         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1323
1324 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
1325
1326         Reviewed by Dan Bernstein.
1327
1328         Beefed up --threaded mode to catch even more kinds of errors.
1329         https://bugs.webkit.org/show_bug.cgi?id=52971
1330
1331         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
1332         context group to force JSC to mark multiple threads. (This used to be
1333         the default, but it changed in SnowLeopard.)
1334         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
1335         to give threading mistakes more chances to show themselves.
1336         (startJavaScriptThreads):
1337         (stopJavaScriptThreads):
1338
1339 2011-01-22  Robert Hogan  <robert@webkit.org>
1340
1341         Reviewed by Andreas Kling.
1342
1343         [Qt] Support layoutTestController.addURLToRedirect()
1344         https://bugs.webkit.org/show_bug.cgi?id=52956
1345
1346         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1347         (LayoutTestController::addURLToRedirect):
1348         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1349
1350 2011-01-22  Robert Hogan  <robert@webkit.org>
1351
1352         Reviewed by Kenneth Rohde Christiansen.
1353
1354         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
1355         https://bugs.webkit.org/show_bug.cgi?id=49802
1356
1357         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1358         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1359         (WebCore::DumpRenderTree::open):
1360
1361 2011-01-21  Adam Barth  <abarth@webkit.org>
1362
1363         Reviewed by Maciej Stachowiak.
1364
1365         Disable mac_unittest.py that fails on some of the Mac bots
1366         https://bugs.webkit.org/show_bug.cgi?id=52947
1367
1368         As noted in the comment, this test does not appear to be correct
1369         because the function this test is testing returns different results
1370         depending on which flavor of Mac the test is run on.  This patch
1371         disable the test.  Hopefully we can re-enable the test once we've
1372         probably insulated the test from its environment.
1373
1374         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1375
1376 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1377
1378         Reviewed by Mihai Parparita.
1379
1380         Fix bug introduced in r76322 that caused NRWT to not actually
1381         read the Skipped files properly.
1382
1383         https://bugs.webkit.org/show_bug.cgi?id=52771
1384
1385         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1386         * Scripts/webkitpy/layout_tests/port/webkit.py:
1387         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1388
1389 2011-01-21  Sam Weinig  <sam@webkit.org>
1390
1391         Reviewed by Geoffrey Sean Garen and Mark Rowe.
1392
1393         WebKitTestRunner needs the HOME environment variable to be set.
1394         <rdar://problem/8896573>
1395
1396         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
1397         it exists.
1398
1399 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1400
1401         Reviewed by Eric Seidel.
1402
1403         Suppress a few remaining integration tests so that none of the
1404         layout_test unit tests ever read from the filesystem or launch
1405         subprocesses that aren't part of the unit tests.
1406
1407         Also fix a minor bug in the printing unit tests that was
1408         incorrectly relying on sys.argv.
1409
1410         https://bugs.webkit.org/show_bug.cgi?id=52863
1411
1412         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1413         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1414         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1415
1416 2011-01-21  Darin Adler  <darin@apple.com>
1417
1418        Fix Mac build.
1419
1420         * MiniBrowser/mac/BrowserWindowController.m:
1421         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
1422
1423 2011-01-20  Darin Adler  <darin@apple.com>
1424
1425         Reviewed by Dan Bernstein.
1426
1427         WebKit2: Implement showModalDialog
1428         https://bugs.webkit.org/show_bug.cgi?id=52855
1429
1430         This fixes WebKitTestRunner to compile, but more work is probably
1431         needed to get it to pass the tests.
1432
1433         * WebKitTestRunner/TestController.cpp:
1434         (WTR::TestController::runModal): Added. Calls through to the
1435         platform-specific version of runModal.
1436         (WTR::TestController::createOtherPage): Changed to be a private
1437         static member function so it can refer to runModal, which is
1438         a private static member function.
1439         (WTR::TestController::initialize): Pass 0 for the runModal
1440         function since we don't need to run the main window modal.
1441         I suspect this is wrong and will need to change.
1442         * WebKitTestRunner/TestController.h: Added declarations for
1443         the functions added above.
1444         * WebKitTestRunner/mac/TestControllerMac.mm:
1445         (WTR::TestController::runModal): Added. Untested implementation.
1446         * WebKitTestRunner/qt/TestControllerQt.cpp:
1447         (WTR::TestController::runModal): Added.
1448         * WebKitTestRunner/win/TestControllerWin.cpp:
1449         (WTR::TestController::runModal): Added.
1450
1451 2011-01-21  Eric Seidel  <eric@webkit.org>
1452
1453         Reviewed by Adam Barth.
1454
1455         Split Host object off from WebKitPatch for easier re-use
1456         https://bugs.webkit.org/show_bug.cgi?id=52284
1457
1458         new-run-webkit-tests and other tools are eventually going to want one of these.
1459         Basically you need to inherit from this class if you want to pretend to be a
1460         self.tool object for Steps/Commands.
1461
1462         * Scripts/webkitpy/common/host.py: Added.
1463         * Scripts/webkitpy/tool/main.py:
1464
1465 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1466
1467         Reviewed by Adam Barth.
1468
1469         Disable the tests that start and stop the http server and web
1470         server, so that we don't have to worry about port collisions on
1471         the bots.
1472
1473         https://bugs.webkit.org/show_bug.cgi?id=52861
1474
1475         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1476
1477 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1478
1479         Reviewed by Eric Seidel.
1480
1481         nrwt: rewrite google_chrome_unittest to use mock filesystem.
1482         
1483         https://bugs.webkit.org/show_bug.cgi?id=52772
1484         
1485         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1486
1487 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1488
1489         Reviewed by Eric Siedel.
1490
1491         nrwt: clean up almost all remaining port references, remove
1492         unnecessary import clauses. The only remaining references are
1493         in places where a mock filesystem makes no sense or can't be
1494         used, and in one routine in port/google_chrome_unittest that
1495         I'll rewrite in a separate patch.
1496
1497         https://bugs.webkit.org/show_bug.cgi?id=52771
1498
1499         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1500         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1501         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1502         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1503         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1504         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1505         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1506         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1507         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1508         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1509         * Scripts/webkitpy/layout_tests/port/gtk.py:
1510         * Scripts/webkitpy/layout_tests/port/mac.py:
1511         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1512         * Scripts/webkitpy/layout_tests/port/qt.py:
1513         * Scripts/webkitpy/layout_tests/port/webkit.py:
1514         * Scripts/webkitpy/layout_tests/port/win.py:
1515         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1516
1517 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1518
1519         Reviewed by Mihai Parparita.
1520
1521         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
1522
1523         https://bugs.webkit.org/show_bug.cgi?id=52762
1524
1525         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1526         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1527
1528 2011-01-20  Tony Chang  <tony@chromium.org>
1529
1530         Reviewed by Ojan Vafai.
1531
1532         [chromium] fix the paths used for the rebaseline tool
1533         https://bugs.webkit.org/show_bug.cgi?id=52857
1534
1535         Some of the bots were renamed so the path to grab the results zip
1536         file has changed.
1537
1538         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1539
1540 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1541
1542         Reviewed by Tony Chang.
1543
1544         Fix bug introduced in r72688 / bug 52768 that broke the
1545         generation of the output filename links in the results.html
1546         output. Apparently none of the unit tests actually checked to
1547         make sure the generated links were correct :(
1548
1549         https://bugs.webkit.org/show_bug.cgi?id=52854
1550
1551         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1552         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1553
1554 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
1555
1556         Reviewed by Darin Adler.
1557
1558         https://bugs.webkit.org/show_bug.cgi?id=52849
1559         Make window.print work with WebKit2
1560
1561         * MiniBrowser/mac/BrowserWindowController.m:
1562         (-[BrowserWindowController awakeFromNib]):
1563         * WebKitTestRunner/TestController.cpp:
1564         (WTR::createOtherPage):
1565         (WTR::TestController::initialize):
1566         Added zeroes to WKPageUIClient structures to avoid build failures.
1567
1568 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1569
1570         Reviewed by Eric Seidel.
1571
1572         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
1573
1574         https://bugs.webkit.org/show_bug.cgi?id=52756
1575
1576         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1577         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1578         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1579         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1580         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1581         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1582
1583 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
1584
1585         Reviewed by Antonio Gomes.
1586
1587         QtTestBrowser should have a seperate menu for Settings
1588         https://bugs.webkit.org/show_bug.cgi?id=52817
1589         
1590         Added a new menu item named "Settings"
1591         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
1592
1593         * QtTestBrowser/launcherwindow.cpp:
1594         (LauncherWindow::createChrome):
1595
1596 2011-01-20  Sam Weinig  <sam@webkit.org>
1597
1598         Reviewed by John Sullivan.
1599
1600         Update update-webkit-localizable-strings with new path to WebKit.
1601
1602         * Scripts/update-webkit-localizable-strings:
1603
1604 2011-01-20  James Robinson  <jamesr@chromium.org>
1605
1606         Reviewed by Darin Fisher.
1607
1608         Implement mozilla's requestAnimationFrame API
1609         https://bugs.webkit.org/show_bug.cgi?id=51218
1610
1611         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1612
1613         * DumpRenderTree/chromium/WebViewHost.cpp:
1614         (invokeScheduleComposite):
1615         (WebViewHost::scheduleAnimation):
1616         (WebViewHost::paintInvalidatedRegion):
1617         * DumpRenderTree/chromium/WebViewHost.h:
1618
1619 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
1620
1621         Reviewed by Adam Roben.
1622
1623         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
1624         https://bugs.webkit.org/show_bug.cgi?id=42327
1625
1626         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
1627         for methods that take their normal arguments but also a JSContextRef.
1628         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
1629         for evaluateScriptInIsolatedWorld.
1630         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1631         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
1632         this call is for an isolated world.
1633         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1634         (WTR::worldMap): Helper to create a world map.
1635         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
1636         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
1637         added LayoutTestController API.
1638         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1639
1640 2011-01-19  Adam Roben  <aroben@apple.com>
1641
1642         Convert paths in environment variables back to msys-style inside commit-log-editor
1643
1644         When this script gets run from inside git commit, msys-style paths in the environment will
1645         have been turned into Windows-style paths with forward slashes. This screws up functions
1646         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
1647         the paths back to msys-style before doing anything else.
1648
1649         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
1650         using msysgit's Perl and multiple ChangeLogs have been edited
1651
1652         Reviewed by David Kilzer.
1653
1654         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
1655         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
1656         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
1657
1658 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1659
1660         [Win] Unreviewed build fix after r76248.
1661
1662         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
1663
1664 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1665
1666         Reviewed by Csaba Osztrogonác.
1667
1668         Refactoring of the custom allocation framework
1669         https://bugs.webkit.org/show_bug.cgi?id=49897
1670
1671         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
1672         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
1673         equivalent macro implementation at the necessary places.
1674 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
1675
1676         Unreviewed. 
1677
1678         Adding myself to committers.py.
1679
1680         * Scripts/webkitpy/common/config/committers.py:
1681
1682 2011-01-20  Adam Barth  <abarth@webkit.org>
1683
1684         Reviewed by Tony Chang.
1685
1686         Chromium builders don't delete unversioned directories when DEPS change
1687         https://bugs.webkit.org/show_bug.cgi?id=52745
1688
1689         If we pass this option to gclient sync, gclient will delete directories
1690         that are no longer part of DEPS instead of leaving them around to
1691         confuse us later.  Apparently, the downstream buildbots use this option
1692         already.
1693
1694         * Scripts/update-webkit-chromium:
1695
1696 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1697
1698         Unreviewed, build fix - I pulled this patch in to fix an issue
1699         revealed by r76195 running on some new bots). Also fix a couple
1700         of other issues revealed in testing.
1701
1702         nrwt: remove fs refs from layout_package/json*
1703
1704         https://bugs.webkit.org/show_bug.cgi?id=52754
1705
1706         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1707         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1708         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1709         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1710         * Scripts/webkitpy/layout_tests/port/base.py:
1711
1712 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1713
1714         Unreviewed, build fix.
1715
1716         Fix a couple of minor bugs discovered while bringing up new bots
1717         for testing.
1718
1719         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1720         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1721
1722 2011-01-19  James Robinson  <jamesr@chromium.org>
1723
1724         Unreviewed, rolling out r76194.
1725         http://trac.webkit.org/changeset/76194
1726         https://bugs.webkit.org/show_bug.cgi?id=51218
1727
1728         Caused mysterious compile failure on the chromium win
1729         build.webkit.org bots
1730
1731         * DumpRenderTree/chromium/WebViewHost.cpp:
1732         (WebViewHost::paintInvalidatedRegion):
1733         * DumpRenderTree/chromium/WebViewHost.h:
1734
1735 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1736
1737         Reviewed by Mihai Parparita.
1738
1739         remove fs refs from test_runner, dump_render_tree_thread
1740
1741         https://bugs.webkit.org/show_bug.cgi?id=52753
1742
1743         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1744         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1745         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
1746         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1747
1748 2011-01-19  James Robinson  <jamesr@chromium.org>
1749
1750         Reviewed by Darin Fisher.
1751
1752         Implement mozilla's requestAnimationFrame API
1753         https://bugs.webkit.org/show_bug.cgi?id=51218
1754
1755         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1756
1757         * DumpRenderTree/chromium/WebViewHost.cpp:
1758         (invokeScheduleComposite):
1759         (WebViewHost::scheduleAnimation):
1760         (WebViewHost::paintInvalidatedRegion):
1761         * DumpRenderTree/chromium/WebViewHost.h:
1762
1763 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1764
1765         Unreviewed, build fix.
1766
1767         Fix a few incorrect "self._filesystem" references introduced in
1768         r76184.
1769
1770         * Scripts/webkitpy/layout_tests/port/chromium.py:
1771         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1772
1773 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1774
1775         Reviewed by Mihai Parparita.
1776
1777         add a .sep property, abspath(), isabs(), mtime(), and
1778         open_text_file_for_writing() to filesystem modules. Some of
1779         these properties are not needed in this patch but will be needed
1780         in subsequent patches (I'm doing this to avoid having to track
1781         multiple versions of a single file).
1782
1783         Also, change most of the port/* modules to use the filesystem
1784         objects instead of referencing the filesystem directly.
1785
1786         https://bugs.webkit.org/show_bug.cgi?id=52748
1787
1788         * Scripts/webkitpy/common/system/filesystem.py:
1789         * Scripts/webkitpy/common/system/filesystem_mock.py:
1790         * Scripts/webkitpy/layout_tests/port/__init__.py:
1791         * Scripts/webkitpy/layout_tests/port/base.py:
1792         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1793         * Scripts/webkitpy/layout_tests/port/chromium.py:
1794         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1795         * Scripts/webkitpy/layout_tests/port/config.py:
1796         * Scripts/webkitpy/layout_tests/port/test.py:
1797         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1798
1799 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
1800
1801         Reviewed by Anders Carlsson.
1802
1803         If resetting between tests times out, treat it as a WebProcess crash
1804         https://bugs.webkit.org/show_bug.cgi?id=52757
1805
1806         * WebKitTestRunner/TestController.cpp:
1807         (WTR::TestController::runTest):
1808
1809 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
1810
1811         Reviewed by Darin Adler.
1812
1813         https://bugs.webkit.org/show_bug.cgi?id=52739
1814         Make it possible for a WebKit2 client to print headers and footers
1815
1816         Added dummy implementations for new printing UIClient calls.
1817
1818         * MiniBrowser/mac/BrowserWindowController.m:
1819         (-[BrowserWindowController awakeFromNib]):
1820         * WebKitTestRunner/TestController.cpp:
1821         (WTR::createOtherPage):
1822         (WTR::TestController::initialize):
1823
1824 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1825
1826         Reviewed by Ojan Vafai.
1827
1828         Change webkitpy/layout_tests/port/test.py to use the
1829         in-memory filesystem for cleaner unit testing. This
1830         change allows us to kill a lot of code that was
1831         specific to the test port, at the cost of being a
1832         little less clear about how things would work if
1833         you didn't have a filesystem.
1834
1835         https://bugs.webkit.org/show_bug.cgi?id=52605
1836
1837         * Scripts/webkitpy/layout_tests/port/test.py:
1838
1839 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1840
1841         Unreviewed, build fix.
1842
1843         Fix test failure caused by committing attachment 79368 instead
1844         of attachment 79461 on bug 52604.
1845
1846         * Scripts/webkitpy/common/system/filesystem_mock.py:
1847
1848 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1849
1850         Reviewed by Mihai Parparita.
1851
1852         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
1853         unit testing. os.walk() is too much of a hassle to implement on
1854         top of the in-memory mock filesystem and adding the necessary
1855         interface to files_under() gives clients a cleaner API anyway
1856         (for this particular usage model).
1857
1858         https://bugs.webkit.org/show_bug.cgi?id=52691
1859
1860         * Scripts/webkitpy/common/system/filesystem.py:
1861         * Scripts/webkitpy/common/system/filesystem_mock.py:
1862         * Scripts/webkitpy/layout_tests/port/test_files.py:
1863         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1864
1865 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1866
1867         Reviewed by Tony Chang.
1868
1869         Change more modules in the layout-tests code to use the
1870         filesystem wrapper for cleaner unit testing.
1871
1872         This patch also adds the glob() wrapper to the filesystem
1873         abstraction.
1874         
1875         https://bugs.webkit.org/show_bug.cgi?id=52604
1876
1877         * Scripts/webkitpy/layout_tests/port/test_files.py:
1878         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1879         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1880         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1881         * Scripts/webkitpy/common/system/filesystem.py:
1882         * Scripts/webkitpy/common/system/filesystem_mock.py:
1883
1884 2011-01-19  Levi Weintraub  <leviw@chromium.org>
1885
1886         Unreviewed.
1887
1888         Updating my email addresses and irc nick.
1889
1890         * Scripts/webkitpy/common/config/committers.py:
1891
1892 2011-01-19  Tony Chang  <tony@chromium.org>
1893
1894         Reviewed by Mihai Parparita.
1895
1896         [chromium] [linux] if check-sys-deps fails, output the failure reason
1897         https://bugs.webkit.org/show_bug.cgi?id=52671
1898
1899         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
1900             error handler functions.
1901         * Scripts/webkitpy/layout_tests/port/chromium.py:
1902             output the error text from --check-sys-deps
1903         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1904
1905 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
1906
1907         Reviewed by Andreas Kling.
1908
1909         [Qt] QtTestBrowser crashes when closing if Facebook is opened
1910         https://bugs.webkit.org/show_bug.cgi?id=52554
1911         
1912         QtNetworkAccessManager is created in a thread and set as
1913         member variable in QWebPage. When the thread is destroyed
1914         the object is still used. So fix will set the object to
1915         NULL once the thread is destroyed.
1916
1917         * QtTestBrowser/launcherwindow.cpp:
1918         (LauncherWindow::~LauncherWindow):
1919
1920 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1921
1922         Rubber stamped by Csaba Osztrogonac
1923
1924         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
1925
1926 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1927
1928         Reviewed by Tony Chang.
1929
1930         new-run-webkit-tests: add a --build-directory command line argument
1931
1932         Official Google Chrome builds use a non-standard build directory
1933         location. This patch adds a --build-directory argument that
1934         allows that location to be specified on the command line. Only
1935         Chromium-based builds will use this flag for now, but anyone can
1936         in the future.
1937
1938         There are no unit tests for this since it's difficult to test
1939         until mock filesystems are fully supported in the code. This was
1940         tested by hand for now.
1941
1942         https://bugs.webkit.org/show_bug.cgi?id=52694
1943
1944         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1945         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1946         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1947         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1948
1949 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1950
1951         Not reviewed. Bot fix.
1952
1953         Remove an inadvertently committed debugging print.
1954
1955         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1956         (LayoutTestController::notifyDone):
1957
1958 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1959
1960         Reviewed by Sam Weinig.
1961
1962         WebKitTestRunner should track loading more like DumpRenderTree
1963         https://bugs.webkit.org/show_bug.cgi?id=52692
1964
1965         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
1966         This makes some tests that call notifyDone multiple times pass.
1967         
1968         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1969         (WTR::InjectedBundle::InjectedBundle):
1970         (WTR::InjectedBundle::done):
1971         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1972         (WTR::InjectedBundle::topLoadingFrame):
1973         (WTR::InjectedBundle::setTopLoadingFrame):
1974         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1975         (WTR::InjectedBundlePage::InjectedBundlePage):
1976         (WTR::InjectedBundlePage::stopLoading):
1977         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1978         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
1979         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1980         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1981         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1982         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1983         (WTR::LayoutTestController::notifyDone):
1984         * WebKitTestRunner/TestController.cpp:
1985         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1986
1987 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
1988
1989         Reviewed by Kent Tamura.
1990
1991         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
1992         https://bugs.webkit.org/show_bug.cgi?id=52678
1993         
1994         Update path now that WebKit is inside Source.
1995
1996         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1997
1998 2011-01-18  Robert Hogan  <robert@webkit.org>
1999
2000         Reviewed by Simon Hausmann.
2001
2002         [Qt] http/tests/incremental/slow-utf8-text.pl fails
2003         https://bugs.webkit.org/show_bug.cgi?id=44282
2004
2005         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2006         (WebCore::DumpRenderTree::dump):
2007
2008 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2009
2010         Reviewed by Mihai Parparita.
2011
2012         Fix a small race condition that could cause the unit tests for
2013         new-run-webkit-tests to fail in a multithreaded environment.
2014         There was a small window in the code where one thread would
2015         check to see if a thread had raised an exception, do something,
2016         and then check to see if the thread was alive. If the other
2017         thread raised an exception and exited in between these two
2018         steps, the exception would be lost. Flipping the order of the
2019         two checks fixes the race, since we will now always check for an
2020         exception on the thread before exiting.
2021
2022         https://bugs.webkit.org/show_bug.cgi?id=51579
2023
2024         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2025
2026 2011-01-18  Eric Seidel  <eric@webkit.org>
2027
2028         Reviewed by Adam Barth.
2029
2030         commit-queue dies when test archiving fails
2031         https://bugs.webkit.org/show_bug.cgi?id=52617
2032
2033         I looked at the machine and it had 10 archives already
2034         thus find_unused_name was returning None.  I've upped
2035         the limit to 100 (per bug) and tested the case where
2036         find_unused_name returns None (making archive return None).
2037
2038         * Scripts/webkitpy/common/system/workspace.py:
2039         * Scripts/webkitpy/common/system/workspace_unittest.py:
2040         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2041         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2042         * Scripts/webkitpy/tool/commands/queues.py:
2043
2044 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2045
2046         Reviewed by Ojan Vafai.
2047
2048         Update rebaseline-chromium-webkit-tests unit tests to use a mock
2049         filesystem. Also fix a couple of "with" statements missed by
2050         r76050.
2051
2052         https://bugs.webkit.org/show_bug.cgi?id=52487
2053
2054         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2055
2056 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
2057
2058         Reviewed by Martin Robinson.
2059
2060         [Gtk] Build fixes for gtk3 build
2061         https://bugs.webkit.org/show_bug.cgi?id=52648
2062
2063         * DumpRenderTree/gtk/EventSender.cpp:
2064         (beginDragWithFilesCallback):
2065
2066 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2067
2068         Reviewed by Mihai Parparita.
2069
2070         Update rebaseline-chromium-webkit-tests to use filesystem objects
2071         instead of direct references to os.path, shutil, tempfile, etc.
2072
2073         This patch doesn't change anything, but will allow subsequent
2074         patches to change the unit tests to no longer use the real
2075         filesystem.
2076
2077         This patch adds a bunch more methods to the filesystem object as
2078         well.
2079
2080         https://bugs.webkit.org/show_bug.cgi?id=52482
2081
2082         * Scripts/webkitpy/common/system/filesystem.py:
2083         * Scripts/webkitpy/common/system/filesystem_mock.py:
2084         * Scripts/webkitpy/tool/commands/queues.py:
2085         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2086         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2087
2088 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2089
2090         Reviewed by Mihai Parparita.
2091
2092         new-run-webkit-tests shouldn't crash when you try to run a
2093         directory containing only skipped files.
2094
2095         https://bugs.webkit.org/show_bug.cgi?id=52478
2096         
2097         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2098         * Scripts/webkitpy/layout_tests/port/test.py:
2099         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2100
2101 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
2102
2103         Reviewed by Gustavo Noronha Silva.
2104
2105         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
2106         https://bugs.webkit.org/show_bug.cgi?id=40833
2107
2108         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
2109         GTK+ event sender.
2110         (dragWithFilesDragDataGetCallback): Added.
2111         (dragWithFilesDragEndCallback): Added.
2112         (beginDragWithFilesCallback): Added.
2113
2114 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2115
2116         Reviewed by Adam Barth.
2117
2118         ews: Add additional watcher to efl ews
2119         https://bugs.webkit.org/show_bug.cgi?id=52613
2120
2121         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
2122
2123         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2124
2125 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
2126
2127         Reviewed by Alexey Proskuryakov.
2128
2129         Fix some headers with missing or misspelled #ifndef guards
2130         https://bugs.webkit.org/show_bug.cgi?id=52545
2131
2132         * DumpRenderTree/chromium/TestEventPrinter.h:
2133         * DumpRenderTree/chromium/WebPreferences.h:
2134
2135 2011-01-17  Jessie Berlin  <jberlin@apple.com>
2136
2137         Reviewed by Anders Carlsson.
2138
2139         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
2140         navigating back to an unreachable URL
2141         https://bugs.webkit.org/show_bug.cgi?id=52388
2142
2143         Add a third parameter (unreachableURL) to queueLoadHTMLString.
2144
2145         * DumpRenderTree/LayoutTestController.cpp:
2146         (queueLoadHTMLStringCallback):
2147         (LayoutTestController::queueLoadHTMLString):
2148         (LayoutTestController::queueLoadAlternateHTMLString):
2149         * DumpRenderTree/LayoutTestController.h:
2150
2151         * DumpRenderTree/WorkQueueItem.h:
2152         (LoadHTMLStringItem::LoadHTMLStringItem):
2153
2154         * DumpRenderTree/chromium/LayoutTestController.cpp:
2155         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
2156         (WorkItemLoadHTMLString::run):
2157         (LayoutTestController::queueLoadHTMLString):
2158
2159         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2160         (LoadHTMLStringItem::invoke):
2161         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2162         (LoadHTMLStringItem::invoke):
2163         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2164         (LoadHTMLStringItem::invoke):
2165
2166 2011-01-17  Dan Bernstein  <mitz@apple.com>
2167
2168         Rubber-stamped by Mark Rowe.
2169
2170         Update xcodeproj svn:ignore to include xcuserdata.
2171
2172         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
2173         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
2174         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
2175         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
2176         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
2177
2178 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2179
2180         Unreviewed fix after r75908.
2181
2182         Move WebKit into Source
2183         https://bugs.webkit.org/show_bug.cgi?id=52530
2184
2185         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
2186
2187 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2188
2189         Unreviewed.
2190
2191         Remove accidentally committed debug printing after r75908.
2192
2193         * Scripts/webkitdirs.pm:
2194
2195 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2196
2197         Unreviewed.
2198
2199         Add myself to committers list
2200         https://bugs.webkit.org/show_bug.cgi?id=52566
2201
2202         * Scripts/webkitpy/common/config/committers.py:
2203
2204 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2205
2206         Reviewed by Jeremy Orlow.
2207
2208         GeolocationController should call stopUpdating on destruction
2209         https://bugs.webkit.org/show_bug.cgi?id=52216
2210
2211         fast/dom/Geolocation/window-close-crash.html requires that a
2212         Geolocation watch be started in a secondary window. Consequently,
2213         we need to allow geolocation permission and provide a mock
2214         geolocation position for the secondary window's
2215         GeolocationClientMock.
2216
2217         * DumpRenderTree/chromium/LayoutTestController.cpp:
2218         (LayoutTestController::setGeolocationPermission):
2219         (LayoutTestController::setMockGeolocationPosition):
2220         (LayoutTestController::setMockGeolocationError):
2221         * DumpRenderTree/chromium/TestShell.h:
2222         (TestShell::windowList):
2223
2224 2011-01-16  Adam Barth  <abarth@webkit.org>
2225
2226         Update more include paths to reflect WebKit move.
2227
2228         * DumpRenderTree/chromium/EventSender.cpp:
2229         (EventSender::keyDown):
2230         (EventSender::needsShiftModifier):
2231         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2232         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2233
2234 2011-01-16  Kent Tamura  <tkent@chromium.org>
2235
2236         Unreviewed, Chromium build fix.
2237
2238         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
2239
2240 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
2241
2242         Build fix for GTK+ after source directory movement.
2243
2244         * GNUmakefile.am: Correct include paths.
2245
2246 2011-01-16  Adam Barth  <abarth@webkit.org>
2247
2248         Teach svn-apply about WebKit move.
2249
2250         * Scripts/VCSUtils.pm:
2251
2252 2011-01-16  Adam Barth  <abarth@webkit.org>
2253
2254         Rubber-stamped by Eric Seidel.
2255
2256         Move WebKit into Source
2257         https://bugs.webkit.org/show_bug.cgi?id=52530
2258
2259         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
2260         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2261         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2262         * DumpRenderTree/qt/GCControllerQt.cpp:
2263         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2264         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2265         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2266         * DumpRenderTree/wscript:
2267         * QtTestBrowser/launcherwindow.h:
2268         * Scripts/build-webkit:
2269         * Scripts/webkitdirs.pm:
2270
2271 2011-01-15  Adam Barth  <abarth@webkit.org>
2272
2273         Teach svn-apply about WebKit2 move.
2274
2275         * Scripts/VCSUtils.pm:
2276
2277 2011-01-15  Adam Barth  <abarth@webkit.org>
2278
2279         Rubber-stamped by Eric Seidel.
2280
2281         Move WebKit2 into Source
2282         https://bugs.webkit.org/show_bug.cgi?id=52438
2283
2284         * MiniBrowser/qt/MiniBrowser.pro:
2285         * Scripts/build-webkit:
2286         * Scripts/do-file-rename:
2287         * Scripts/do-webcore-rename:
2288         * Scripts/test-webkitpy:
2289         * Scripts/webkitdirs.pm:
2290         * Scripts/webkitpy/style/checker.py:
2291         * WebKitTestRunner/DerivedSources.pro:
2292         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2293         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2294
2295 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
2296
2297         Reviewed by David Levin.
2298
2299         [chromium] remove obsolete createView method
2300         https://bugs.webkit.org/show_bug.cgi?id=52437
2301
2302         * DumpRenderTree/chromium/WebViewHost.cpp:
2303         (WebViewHost::createView):
2304         * DumpRenderTree/chromium/WebViewHost.h:
2305
2306 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
2307
2308         Reviewed by Geoff Garen.
2309
2310         ShouldLoadResourceForFrame should use strings, not URLs.
2311         https://bugs.webkit.org/show_bug.cgi?id=52476
2312
2313         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2314         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
2315         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2316
2317 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
2318
2319         Reviewed by David Levin.
2320
2321         Add Tony Gentilcore as a reviewer
2322         https://bugs.webkit.org/show_bug.cgi?id=52480
2323
2324         * Scripts/webkitpy/common/config/committers.py:
2325
2326 2011-01-14  David Levin  <levin@chromium.org>
2327
2328         Reviewed by Eric Seidel.
2329
2330         check-webkit-style: _FunctionState should keep track of where the function name starts.
2331         https://bugs.webkit.org/show_bug.cgi?id=52454
2332
2333         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
2334         _FunctionState and logic for setting it correctly.
2335         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
2336
2337 2011-01-14  Vincent Scheib  <scheib@chromium.org>
2338
2339         Reviewed by David Levin.
2340
2341         Add support to DumpRenderTree to use the GPU rather than software renderer
2342         https://bugs.webkit.org/show_bug.cgi?id=52333
2343
2344         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2345         (main):
2346         * Scripts/webkitpy/layout_tests/port/chromium.py:
2347         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2348
2349 2011-01-14  Tony Chang  <tony@chromium.org>
2350
2351         Reviewed by Kent Tamura.
2352
2353         [chromium] update fonts.conf to fix 6 linux tests in drt
2354         https://bugs.webkit.org/show_bug.cgi?id=52411
2355
2356         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
2357             chromium's src/webkit/tools/test_shell/resources/fonts.conf
2358
2359 2011-01-14  Eric Seidel  <eric@webkit.org>
2360
2361         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
2362
2363         Reviewed by Adam Barth.
2364
2365         Fix when running Tools/Scripts/check-webkit-style without arguments.
2366         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
2367
2368         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
2369         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2370
2371 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
2372
2373         Reviewed by David Levin.
2374
2375         Store the tempdir object in a variable so it doesn't get deleted too early.
2376         https://bugs.webkit.org/show_bug.cgi?id=51875
2377
2378         * Scripts/update-webkit-auxiliary-libs:
2379         * Scripts/update-webkit-support-libs:
2380
2381 2011-01-14  Eric Seidel  <eric@webkit.org>
2382
2383         Unreviewed.  Make it work in python 2.5.
2384
2385         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2386         https://bugs.webkit.org/show_bug.cgi?id=49158
2387
2388         * Scripts/webkitpy/common/checkout/api_unittest.py:
2389
2390 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2391
2392         Unreviewed, rolling out r75774.
2393         http://trac.webkit.org/changeset/75774
2394         https://bugs.webkit.org/show_bug.cgi?id=52431
2395
2396         gtk builds were broken (Requested by loislo2 on #webkit).
2397
2398         * Scripts/webkitpy/common/checkout/scm.py:
2399
2400 2011-01-14  David Levin  <levin@chromium.org>
2401
2402         Reviewed by Shinichiro Hamaji.
2403
2404         check-webkit-style: _FunctionState should detect pure functions.
2405         https://bugs.webkit.org/show_bug.cgi?id=52428
2406
2407         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
2408         is a pure virtual function.
2409         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
2410         virtual functions are correctly detected.
2411
2412 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
2413
2414         Reviewed by Yury Semikhatsky.
2415
2416         Just small fix for problem with check-webkit-style.
2417         It just didn't work for this patch.
2418         Old code can't concatenate a list of strings with None.
2419
2420         * Scripts/webkitpy/common/checkout/scm.py:
2421
2422 2011-01-13  David Levin  <levin@chromium.org>
2423
2424         Reviewed by Shinichiro Hamaji.
2425
2426         check-webkit-style: _FunctionState should use Position to know where items are.
2427         https://bugs.webkit.org/show_bug.cgi?id=52424
2428
2429         * Scripts/webkitpy/style/checkers/cpp.py:
2430         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
2431         (detect_functions): Changed to pass Position's to _FunctionState.begin and
2432         did some minor clean-up.
2433         (*): Other changes are simply about converting to use the Position's in_FunctionState
2434         instead of line numbers.
2435         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
2436         to verify the positions stored in _FunctionState.
2437
2438 2011-01-13  Eric Seidel  <eric@webkit.org>
2439
2440         Reviewed by David Levin.
2441
2442         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2443         https://bugs.webkit.org/show_bug.cgi?id=49158
2444
2445         This is not the most elegant, but it is a very safe fix to this bug.
2446         One advantage of catching ScriptError like this instead of adding a
2447         new added_or_modified_files or fixing all changed_files callers
2448         to use a more specific change_files variant, is that we catch
2449         all kinds of ScriptErrors which might cause our (non-essential)
2450         suggest-reviewers code to fail out.  This should make passing
2451         --suggest-reviewers to webkit-patch upload much more robust
2452         and may even make it possible for us to make it default.
2453
2454         The root of the problem here is that SCM.changed_files includes
2455         deleted ChangeLog paths (from moves, etc) which then when we ask
2456         SVN/Git for the contents of the file at that revision, the command
2457         errors out and Executive.run_command raises a ScriptError.
2458
2459         In the future we might fix this differently by making all current
2460         callers of chagned_files use a more specific method for requesting
2461         what types of changes they're interested in (adds, modifies, deletes, etc.)
2462
2463         * Scripts/webkitpy/common/checkout/api.py:
2464         * Scripts/webkitpy/common/checkout/api_unittest.py:
2465
2466 2011-01-13  Dan Bernstein  <mitz@apple.com>
2467
2468         Reviewed by Alexey Proskuryakov.
2469
2470         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
2471         https://bugs.webkit.org/show_bug.cgi?id=52419
2472
2473         Allow to further control the behavior of the willSendRequest delegate callback by making it
2474         set a different URL in the new request.
2475
2476         * DumpRenderTree/LayoutTestController.cpp:
2477         (addURLToRedirectCallback): Added.
2478         (LayoutTestController::staticFunctions): Added addURLToRedirect.
2479         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
2480         (LayoutTestController::redirectionDestinationForURL): Added this getter.
2481         * DumpRenderTree/LayoutTestController.h:
2482         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2483         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
2484         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
2485         change the URL in the new request to the redirect destination.
2486
2487 2011-01-13  Eric Seidel  <eric@webkit.org>
2488
2489         Reviewed by Mihai Parparita.
2490
2491         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
2492         https://bugs.webkit.org/show_bug.cgi?id=52416
2493
2494         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
2495         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
2496
2497         I also added FIXMEs about the changed_files returning deleted files problem
2498         which is causing the other most common exception for suggest-reviewers
2499         (and is probably breaking sheriff-bots blame detection).
2500
2501         * Scripts/webkitpy/common/checkout/api.py:
2502         * Scripts/webkitpy/common/checkout/api_unittest.py:
2503         * Scripts/webkitpy/common/checkout/scm.py:
2504
2505 2011-01-13  Eric Seidel  <eric@webkit.org>
2506
2507         Reviewed by Adam Barth.
2508
2509         results archives from commit-queue are too large to upload
2510         https://bugs.webkit.org/show_bug.cgi?id=52405
2511
2512         * Scripts/webkitpy/common/system/filesystem.py:
2513         * Scripts/webkitpy/common/system/filesystem_mock.py:
2514         * Scripts/webkitpy/tool/commands/queues.py:
2515
2516 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
2517
2518         Reviewed by Martin Robinson.
2519
2520         [gtk] Zero-sized font does not yet work
2521         https://bugs.webkit.org/show_bug.cgi?id=49793
2522
2523         Set minimum-font-size to 0 for the DRT.
2524
2525         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2526         (resetDefaultsToConsistentValues):
2527
2528 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2529
2530         Reviewed by Darin Adler.
2531
2532         Make old-run-webkit-tests more robust on buildbots
2533         https://bugs.webkit.org/show_bug.cgi?id=52364
2534
2535         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
2536
2537 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2538
2539         Reviewed by Darin Adler.
2540
2541         Make old-run-webkit-tests more robust on buildbots
2542         https://bugs.webkit.org/show_bug.cgi?id=52364
2543
2544         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
2545
2546 2011-01-13  Tony Chang  <tony@chromium.org>
2547
2548         Reviewed by Kent Tamura.
2549
2550         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
2551         https://bugs.webkit.org/show_bug.cgi?id=52332
2552
2553         Forked Info.plist is not longer needed.
2554
2555         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
2556
2557 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
2558
2559         Reviewed by Timothy Hatcher.
2560
2561         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
2562         to be passed directly to WebInspector.UIString
2563
2564         https://bugs.webkit.org/show_bug.cgi?id=52365
2565
2566         * Scripts/check-inspector-strings:
2567
2568 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2569
2570         Unreviewed, rolling out r74881.
2571         http://trac.webkit.org/changeset/74881
2572         https://bugs.webkit.org/show_bug.cgi?id=52357
2573
2574         The EFL builder has been red for days (Requested by abarth on
2575         #webkit).
2576
2577         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2578         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2579
2580 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2581
2582         Reviewed by David Levin.
2583
2584         Add beforeunload support to WebKitTestRunner
2585         https://bugs.webkit.org/show_bug.cgi?id=52353
2586         
2587         This makes a number of currently failing tests pass.
2588
2589         * WebKitTestRunner/TestController.cpp:
2590         (WTR::runBeforeUnloadConfirmPanel):
2591         (WTR::createOtherPage):
2592         (WTR::TestController::initialize):
2593
2594 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2595
2596         Reviewed by Sam Weinig.
2597
2598         Detect, identify and recover from WebProcess crashes in run-webkit-tests
2599         https://bugs.webkit.org/show_bug.cgi?id=52330
2600
2601         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
2602         a web process crash.
2603         * WebKitTestRunner/TestController.cpp:
2604         (WTR::TestController::initialize): Set up a processDidCrash
2605         callback.
2606         (WTR::TestController::processDidCrash): Report that the Web process
2607         crashed.
2608         * WebKitTestRunner/TestController.h:
2609
2610 2011-01-12  David Levin  <levin@chromium.org>
2611
2612         Reviewed by Shinichiro Hamaji.
2613
2614         check-webkit-style -- close_expression function doesn't work correctly.
2615         https://bugs.webkit.org/show_bug.cgi?id=52272
2616
2617         * Scripts/webkitpy/style/checkers/cpp.py:
2618         (Position.__str__): Added a way to convert it to a string which is useful in tests.
2619         (Position.__cmp__): Added a way to compare Position which is useful in tests and
2620         generally useful (for upcoming code changes).
2621         (close_expression): Changed to use Position for input and output.
2622         Also, fixed many bugs such as only working correctly for parenthesis,
2623         not working correctly if given an offset in a line and not finding
2624         the real closing element if there were multiple closing elements in
2625         the same line.
2626         (detect_functions): Adjusted due to the change in arguments for
2627         close_expression.
2628         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2629         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
2630         two positions are the same.
2631         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
2632         (CppStyleTest.test_close_expression): Added tests to catch the issues
2633         that were fixed.
2634
2635 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2636
2637         Unreviewed, rolling out r75576.
2638         http://trac.webkit.org/changeset/75576
2639         https://bugs.webkit.org/show_bug.cgi?id=52304
2640
2641         broke rebaseline-chromium-webkit-test (Requested by thakis on
2642         #webkit).
2643
2644         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2645         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2646         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2647         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2648         * Scripts/webkitpy/layout_tests/port/base.py:
2649         * Scripts/webkitpy/layout_tests/port/chromium.py:
2650         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2651         * Scripts/webkitpy/layout_tests/port/test.py:
2652         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2653         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2654         * Scripts/webkitpy/style/checkers/test_expectations.py:
2655         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2656
2657 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2658
2659         Reviewed by Darin Adler.
2660
2661         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
2662         https://bugs.webkit.org/show_bug.cgi?id=52307
2663
2664         * Scripts/old-run-webkit-tests:
2665
2666 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
2667
2668         Reviewed by Martin Robinson.
2669
2670         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
2671         https://bugs.webkit.org/show_bug.cgi?id=50867
2672
2673         Fixed library extention for Mac in webkitdirs.pm and type conflict in
2674         TestNetscapePlugin.cpp 
2675
2676         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
2677         * Scripts/webkitdirs.pm:
2678
2679 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
2680
2681         Reviewed by Pavel Feldman.
2682
2683         Add check-inspector-strings script.
2684
2685         https://bugs.webkit.org/show_bug.cgi?id=52295
2686
2687         * Scripts/check-inspector-strings: Added.
2688
2689 2011-01-12  Adam Roben  <aroben@apple.com>
2690
2691         Advertise the .testnetscape file extension on Windows
2692
2693         Fixes <http://webkit.org/b/52298>
2694         plugins/no-mime-with-valid-extension.html fails on Windows
2695
2696         Reviewed by Dan Bernstein.
2697
2698         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
2699         FileExtents field to map the .testnetscape file extension to the
2700         application/x-webkit-test-netscape MIME type, just as we do on Mac.
2701
2702 2011-01-12  Adam Barth  <abarth@webkit.org>
2703
2704         Reviewed by Eric Seidel.
2705
2706         Make webkit-patch support subdirectories for SVN checkouts
2707         https://bugs.webkit.org/show_bug.cgi?id=52261
2708
2709         os.relpath does not exist on Python 2.5, so we need to call our version
2710         of the API.
2711
2712         * Scripts/webkitpy/common/checkout/scm.py:
2713
2714 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2715
2716         Reviewed by Eric Seidel.
2717
2718         Close additional pages opened during a test once the test completes.
2719         https://bugs.webkit.org/show_bug.cgi?id=52276
2720
2721         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2722         (WTR::InjectedBundle::done):
2723
2724 2011-01-11  David Levin  <levin@chromium.org>
2725
2726         Reviewed by Eric Seidel.
2727
2728         Errors should be separated from the command line in bot messages.
2729         https://bugs.webkit.org/show_bug.cgi?id=52275
2730
2731         * Scripts/webkitpy/common/system/executive.py:
2732         (ScriptError.message_with_output): Added a newline to separate the command
2733         line from the errors.
2734         * Scripts/webkitpy/common/system/executive_unittest.py:
2735         (ScriptErrorTest.test_message_with_output): Added tests for the various code
2736         paths in message_with_output.
2737
2738 2011-01-11  Eric Seidel  <eric@webkit.org>
2739
2740         Unreviewed.
2741
2742         commit-queue should know how to upload archived results (for test flakes or general failures)
2743         https://bugs.webkit.org/show_bug.cgi?id=52048
2744
2745         The zips are mostly empty due to forgetting -r.
2746         Expected diffs were not being pulled from the archive due
2747         to the archive having longer paths than I realized.
2748
2749         * Scripts/webkitpy/common/system/workspace.py:
2750         * Scripts/webkitpy/common/system/workspace_unittest.py:
2751         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2752         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2753
2754 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
2755
2756         Reviewed by Ojan Vafai.
2757
2758         The current modifier parsing code in test_expectations is
2759         fragile and hard-coded, so it's not easy to understand the logic
2760         or easily add new types of modifiers (like GPU vs. CPU testing
2761         for graphics tests, or 32-bit vs. 64-bit differences).
2762
2763         This is the first of two patches that will add in more generic
2764         support and then eliminate the GPU-specific test expectations
2765         files for Chromium.
2766
2767         This patch adds two standalone objects for handling modifiers. The
2768         rules for interpreting modifiers, precedence, and conflicts are
2769         given in the docstring to the ModifierMatcher class, which
2770         returns ModifierMatchResult objects.
2771         
2772         This patch also adds routines to the Port interface and a
2773         default set of values in the base object, in order to obtain the
2774         values needed on a given test run. These values are then passed
2775         to the expectation parser. This also allows us to clean up the
2776         logic used to lint all of the different configurations in a
2777         single test_expectations.txt file.
2778
2779         The next patch will merge in the separate GPU expectations file.
2780
2781         https://bugs.webkit.org/show_bug.cgi?id=51222
2782
2783         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2784         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2785         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2786         * Scripts/webkitpy/layout_tests/port/base.py:
2787         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2788         * Scripts/webkitpy/layout_tests/port/chromium.py:
2789         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2790         * Scripts/webkitpy/layout_tests/port/test.py:
2791         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2792         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2793
2794 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2795
2796         Reviewed by Adam Barth.
2797
2798         Make webkit-patch support subdirectories for SVN checkouts
2799         https://bugs.webkit.org/show_bug.cgi?id=52261
2800
2801         * Scripts/webkitpy/common/checkout/scm.py:
2802         * Scripts/webkitpy/style_references.py:
2803         * Scripts/webkitpy/tool/main.py:
2804         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2805
2806 2011-01-11  Eric Seidel  <eric@webkit.org>
2807
2808         Unreviewed.
2809
2810         commit-queue should know how to upload archived results (for test flakes or general failures)
2811         https://bugs.webkit.org/show_bug.cgi?id=52048
2812
2813         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
2814         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
2815
2816         * Scripts/webkitpy/common/system/workspace.py:
2817         * Scripts/webkitpy/common/system/workspace_unittest.py:
2818         * Scripts/webkitpy/tool/commands/queues.py:
2819
2820 2011-01-11  Sam Weinig  <sam@webkit.org>
2821
2822         Roll r75474 back in.
2823
2824 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2825
2826         Reviewed by Kenneth Rohde Christiansen.
2827
2828         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
2829         https://bugs.webkit.org/show_bug.cgi?id=51204
2830
2831         * QtTestBrowser/webpage.h:
2832         (QtNAMThread::QtNAMThread):
2833         (QtNAMThread::networkAccessManager):
2834         (QtNAMThread::run):
2835
2836 2011-01-11  Peter Varga  <pvarga@webkit.org>
2837
2838         Unreviewed.
2839
2840         Add myself to committers' list.
2841
2842         * Scripts/webkitpy/common/config/committers.py:
2843
2844 2011-01-11  Eric Seidel  <eric@webkit.org>
2845
2846         Reviewed by Adam Barth.
2847
2848         commit-queue should know how to upload archived results (for test flakes or general failures)
2849         https://bugs.webkit.org/show_bug.cgi?id=52048
2850
2851         Now the queue will always upload results.  Either the entire zip, or just
2852         the diffs.txt in the case of text failures.
2853
2854         This should make understanding flakes much easier, and paves the way
2855         for having the EWS run layout tests (and upload failures).
2856
2857         In order to upload .zip files I had to teach bugzilla.py to autodetect
2858         mime types from the filename.  Since mimetypes.py doesn't include a mapping
2859         for .patch files, I have it add one before calling guess_type.
2860
2861         We may find that always uploading the whole zip instead of just the -diffs.txt
2862         file is preferable, but for now I'm keeping the old behavior because it makes
2863         quickly understanding text failures easy.
2864
2865         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2866         * Scripts/webkitpy/common/system/workspace.py: Added.
2867         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
2868         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2869         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2870         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2871         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2872         * Scripts/webkitpy/tool/commands/queues.py:
2873         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2874
2875 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2876
2877         Unreviewed, rolling out r75464.
2878         http://trac.webkit.org/changeset/75464
2879         https://bugs.webkit.org/show_bug.cgi?id=52193
2880
2881         Followup rollout for 75474 (Requested by Ossy on #webkit).
2882
2883         * MiniBrowser/mac/BrowserWindowController.m:
2884         (-[BrowserWindowController awakeFromNib]):
2885         * MiniBrowser/win/BrowserView.cpp:
2886         (BrowserView::create):
2887         * WebKitTestRunner/TestController.cpp:
2888         (WTR::createOtherPage):
2889         (WTR::TestController::initialize):
2890
2891 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2892
2893         Reviewed by Csaba Osztrogonác.
2894
2895         [Qt] Baseline qt_minimal configuration
2896         https://bugs.webkit.org/show_bug.cgi?id=51313
2897
2898         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2899         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
2900         QT_NO_UNDOSTACK guard.
2901
2902         * QtTestBrowser/launcherwindow.cpp:
2903         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
2904         guards.
2905         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
2906         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
2907         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
2908         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
2909
2910         * QtTestBrowser/launcherwindow.h:
2911         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
2912         * QtTestBrowser/locationedit.h: Ditto.
2913
2914         * QtTestBrowser/mainwindow.cpp:
2915         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
2916         QT_NO_UNDOSTACK guards.
2917         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
2918         (MainWindow::changeLocation): Ditto.
2919         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
2920         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
2921
2922         * QtTestBrowser/webpage.cpp:
2923         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
2924         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
2925
2926         * QtTestBrowser/webview.cpp:
2927         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
2928         (WebViewGraphicsBased::animatedYFlip): Ditto.
2929
2930 2011-01-10  Sam Weinig  <sam@webkit.org>
2931
2932         Fix build.
2933
2934         * MiniBrowser/mac/BrowserWindowController.m:
2935         (-[BrowserWindowController awakeFromNib]):
2936         * MiniBrowser/win/BrowserView.cpp:
2937         (BrowserView::create):
2938         * WebKitTestRunner/TestController.cpp:
2939         (WTR::createOtherPage):
2940         (WTR::TestController::initialize):
2941
2942 2011-01-10  Eric Seidel  <eric@webkit.org>
2943
2944         Reviewed by Ojan Vafai.
2945
2946         style-queue messages are way too long for big patches
2947         https://bugs.webkit.org/show_bug.cgi?id=52161
2948
2949         We definitely could build much fancier list-to-string-with-limit functions
2950         but this should be sufficient for our needs at the moment.
2951
2952         * Scripts/webkitpy/common/system/executive.py:
2953         * Scripts/webkitpy/common/system/executive_unittest.py:
2954
2955 2011-01-10  Tony Chang  <tony@chromium.org>
2956
2957         Unreviewed, rolling out r75398.
2958         http://trac.webkit.org/changeset/75398
2959         https://bugs.webkit.org/show_bug.cgi?id=52008
2960
2961         Some layout tests are crashing on Chromium Win.
2962
2963         * DumpRenderTree/chromium/WebViewHost.cpp:
2964         (WebViewHost::updatePaintRect):
2965         * DumpRenderTree/chromium/WebViewHost.h:
2966
2967 2011-01-10  Adam Roben  <aroben@apple.com>
2968
2969         Roll out r75392
2970
2971         It isn't needed now that r75289 has been rolled out.
2972
2973         * Scripts/run-javascriptcore-tests:
2974
2975 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
2976
2977         Reviewed by Anders Carlsson.
2978
2979         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
2980         https://bugs.webkit.org/show_bug.cgi?id=52160
2981
2982         * WebKitTestRunner/mac/TestControllerMac.mm:
2983         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
2984         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
2985         anyway.
2986
2987 2011-01-10  Tony Chang  <tony@chromium.org>
2988
2989         Reviewed by Mihai Parparita.
2990
2991         [chromium] fix for animated gif layout tests
2992         https://bugs.webkit.org/show_bug.cgi?id=52008
2993
2994         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
2995             to trigger gif animations.
2996         (WebViewHostPaintTask::WebViewHostPaintTask):
2997         (WebViewHostPaintTask::runIfValid):
2998         (WebViewHost::updatePaintRect):
2999         * DumpRenderTree/chromium/WebViewHost.h:
3000         (WebViewHost::taskList):
3001
3002 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
3003
3004         Reviewed by Xan Lopez.
3005
3006         [GTK] Fix gtk2 compilation for master
3007         https://bugs.webkit.org/show_bug.cgi?id=51885
3008
3009         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3010         (createBitmapContextFromWebView): Replaced the old
3011         gdk_drawable_get_size with gdk_pixmap_get_size.
3012
3013 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
3014
3015         Reviewed by Laszlo Gombos.
3016
3017         [WINCE] Reenable NPAPI after r75203
3018         https://bugs.webkit.org/show_bug.cgi?id=52109
3019
3020         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
3021         it with !isEfl(), because EFL port does not support NPAPI (yet).
3022
3023         * Scripts/build-webkit:
3024
3025 2011-01-10  Adam Roben  <aroben@apple.com>
3026
3027         Skip some asserting JS tests
3028
3029         See <http://webkit.org/b/52156>.
3030
3031         * Scripts/run-javascriptcore-tests:
3032
3033 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
3034
3035         Reviewed by Xan Lopez.
3036
3037         [GTK] build-webkit disable Blob support via arguments passed to automake
3038         https://bugs.webkit.org/show_bug.cgi?id=52097
3039
3040         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
3041         build-webkit.
3042
3043 2011-01-10  Adam Roben  <aroben@apple.com>
3044
3045         Use the same name and description for TestNetscapePlugin on Windows and
3046         Mac
3047
3048         Fixes <http://webkit.org/b/52151>
3049         fast/frames/iframe-reparenting-plugins.html fails on Windows
3050
3051         Reviewed by Steve Falkenburg.
3052
3053         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
3054         the name and description from Mac's Info.plist.
3055
3056 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
3057
3058         Reviewed by Laszlo Gombos.
3059
3060         [Qt][WK2] Guard gcc-specific syntax
3061
3062         Non-gcc based compliers choke on the "-include"
3063         syntax for preinclude, place guard around it.
3064
3065         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3066         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3067
3068 2011-01-10  Andreas Kling  <kling@webkit.org>
3069
3070         Reviewed by Simon Hausmann.
3071
3072         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
3073         https://bugs.webkit.org/show_bug.cgi?id=52111
3074
3075         When getting a createNewPage() callback from QWKPage, create the
3076         new page with the same QWKContext as the page that is passed to
3077         the callback.
3078
3079         * MiniBrowser/qt/BrowserView.h:
3080         * MiniBrowser/qt/BrowserWindow.cpp:
3081         (newPageFunction):
3082         (BrowserWindow::BrowserWindow):
3083         * MiniBrowser/qt/BrowserWindow.h:
3084
3085 2011-01-10  Andreas Kling  <kling@webkit.org>
3086
3087         Reviewed by Kenneth Rohde Christiansen.
3088
3089         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
3090
3091         BrowserView set its own useless createNewPage() callback on QWKPage.
3092         This was immediately overridden by BrowserWindow anyway, so remove
3093         the BrowserView one.
3094
3095         * MiniBrowser/qt/BrowserView.cpp:
3096         (BrowserView::BrowserView):
3097
3098 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
3099
3100         Reviewed by Jeremy Orlow.
3101
3102         [Chromium] Remove non-client-based Geolocation code
3103         https://bugs.webkit.org/show_bug.cgi?id=50921
3104
3105         * DumpRenderTree/chromium/LayoutTestController.cpp:
3106         (LayoutTestController::setGeolocationPermission):
3107         (LayoutTestController::setMockGeolocationPosition):
3108         (LayoutTestController::setMockGeolocationError):
3109         * DumpRenderTree/chromium/WebViewHost.cpp:
3110         (WebViewHost::geolocationClientMock):
3111         (WebViewHost::reset):
3112         * DumpRenderTree/chromium/WebViewHost.h:
3113
3114 2011-01-10  Eric Seidel  <eric@webkit.org>
3115
3116         Reviewed by Adam Barth.
3117
3118         Commit bot tried to land r? cq+ patch
3119         https://bugs.webkit.org/show_bug.cgi?id=36638
3120
3121         It should now be possible to post a patch with r? and cq+ and the
3122         commit-queue will correctly wait for the r+ before attempting to land the patch.
3123         (This was a feature requested by several users.)
3124
3125         One caveat: We don't actually reject r-, cq+ patches from the queue
3126         (we just ignore them), but I think that's OK for now.
3127
3128         I also noticed that setting r- once a commit-queue node had grabbed
3129         a patch would not properly cancel the landing.  That's fixed and
3130         tested in this patch.
3131
3132         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3133         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3134         * Scripts/webkitpy/tool/bot/feeders.py:
3135         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3136
3137 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
3138
3139         Reviewed by Kenneth Rohde Christiansen.
3140
3141         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
3142         https://bugs.webkit.org/show_bug.cgi?id=51934
3143
3144         When accessing the network from the destructor of QWebPage, the network access manager
3145         was already deleted because the object WebPage was already destructed.
3146
3147         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
3148         The object is now destructed in the destructor of QObject.
3149
3150         * QtTestBrowser/webpage.cpp:
3151         (WebPage::WebPage):
3152         (WebPage::setQnamThreaded):
3153         * QtTestBrowser/webpage.h:
3154         (QtNAMThread::QtNAMThread):
3155
3156 2011-01-08  Eric Seidel  <eric@webkit.org>
3157
3158         Reviewed by Ojan Vafai.
3159
3160         test_failures.py should not mention TestShell (long live DumpRenderTree!)
3161         https://bugs.webkit.org/show_bug.cgi?id=52067
3162
3163         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
3164         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
3165
3166         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3167
3168 2011-01-08  Eric Seidel  <eric@webkit.org>
3169
3170         Reviewed by Mihai Parparita.
3171
3172         commit-queue hangs when the ChangeLog diff is bad
3173         https://bugs.webkit.org/show_bug.cgi?id=52072
3174
3175         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
3176         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3177
3178 2011-01-08  Adam Barth  <abarth@webkit.org>
3179
3180         Teach svn-apply how to re-write WebCore to Source/WebCore.
3181
3182         * Scripts/VCSUtils.pm:
3183
3184 2011-01-07  Adam Barth  <abarth@webkit.org>
3185
3186         Rubber-stamped by Eric Seidel.
3187
3188         Move WebCore to Source
3189         https://bugs.webkit.org/show_bug.cgi?id=52050
3190
3191         Update the tools to understand WebCore's new location.
3192
3193         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3194         * DumpRenderTree/wscript:
3195         * GNUmakefile.am:
3196         * Scripts/build-webkit:
3197         * Scripts/do-file-rename:
3198         * Scripts/do-webcore-rename:
3199         * Scripts/generate-qt-inspector-resource:
3200         * Scripts/prepare-ChangeLog:
3201         * Scripts/run-bindings-tests:
3202         * Scripts/update-iexploder-cssproperties:
3203         * Scripts/update-sources-list.py:
3204         * Scripts/update-webkit-localizable-strings:
3205         * Scripts/webkitdirs.pm:
3206         * Scripts/webkitpy/common/config/build.py:
3207         * Scripts/webkitpy/common/config/build_unittest.py:
3208         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3209         * Scripts/webkitpy/style/checker.py:
3210         * Scripts/webkitpy/style/checker_unittest.py:
3211         * WebKitTestRunner/DerivedSources.pro:
3212         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3213         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
3214         * wx/browser/wscript:
3215         * wx/build/settings.py:
3216
3217 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
3218
3219         Reviewed by Sam Weinig.
3220
3221         Make WebKitTestRunner rest between loads more robust to avoid test crashes
3222         https://bugs.webkit.org/show_bug.cgi?id=52086
3223
3224         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3225         (WTR::InjectedBundle::didReceiveMessage):
3226         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3227         (WTR::LayoutTestController::notifyDone):
3228         * WebKitTestRunner/TestController.cpp:
3229         (WTR::TestController::resetStateToConsistentValues):
3230         (WTR::TestController::run):
3231
3232 2011-01-07  James Robinson  <jamesr@chromium.org>
3233
3234         Revert "Implement mozilla's animationTime property"
3235         https://bugs.webkit.org/show_bug.cgi?id=51952
3236
3237         This approach isn't quite right.
3238
3239         * DumpRenderTree/chromium/WebViewHost.cpp:
3240         (WebViewHost::paintInvalidatedRegion):
3241
3242 2011-01-07  Adam Roben  <aroben@apple.com>
3243
3244         Build master fix
3245
3246         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3247         (RunWebKitTests.start): Don't try to concatenate a list and a string.
3248
3249 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
3250
3251         Reviewed by Csaba Osztrogonác.
3252
3253         run-qtwebkit-tests should be able to kill a testsuite.
3254
3255         Add new option in the script that can setup a timeout for a test.
3256         If the test execution takes more then specified time then the test
3257         would be terminated.
3258
3259         [Qt] run-qtwebkit-tests needs timeout
3260         https://bugs.webkit.org/show_bug.cgi?id=51894
3261
3262         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3263         * Scripts/run-qtwebkit-tests:
3264
3265 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
3266
3267         Unreviewed fix after r75233.
3268
3269         Based on idea from Eric Seidel.
3270
3271         Add remote zip file handling to webkitpy.
3272         https://bugs.webkit.org/show_bug.cgi?id=50901
3273
3274         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
3275
3276 2011-01-07  Shane Stephens  <shanestephens@google.com>
3277
3278         Reviewed by Eric Seidel.
3279
3280         svn-apply: should support git binary delta diffs
3281         https://bugs.webkit.org/show_bug.cgi?id=38864
3282
3283         * Scripts/VCSUtils.pm:
3284         * Scripts/svn-apply:
3285
3286 2011-01-06  Julie Parent  <jparent@chromium.org>
3287
3288         Reviewed by Eric Seidel.
3289
3290         Test Result Server not removing old results.
3291         https://bugs.webkit.org/show_bug.cgi?id=52012
3292
3293         * TestResultServer/model/jsonresults.py:
3294         Fix off-by-one: Truncate if >= num_runs, not just >.
3295         * TestResultServer/model/jsonresults_unittest.py:
3296         Add unit test to test that merging in a new result with the same value
3297         as the last result causes previous result to fall off.
3298
3299 2011-01-06  James Kozianski  <koz@chromium.org>
3300
3301         Reviewed by Mihai Parparita.
3302
3303         Add classes to provide a consistent interface to a set of files.
3304         https://bugs.webkit.org/show_bug.cgi?id=50901
3305
3306         These classes allow us to write code that is agnostic to whether a
3307         particular set of files resides in a local directory or in a zip file
3308         on a remote machine.
3309
3310         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
3311         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
3312         * Scripts/webkitpy/common/system/fileset.py: Added.
3313         * Scripts/webkitpy/common/system/filesystem.py:
3314         * Scripts/webkitpy/common/system/filesystem_mock.py:
3315         * Scripts/webkitpy/common/system/zipfileset.py: Added.
3316         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
3317
3318 2011-01-06  Eric Seidel  <eric@webkit.org>
3319
3320         Reviewed by Adam Barth.
3321
3322         NetworkTransaction should log the url it is retrying
3323         https://bugs.webkit.org/show_bug.cgi?id=52043
3324
3325         * Scripts/webkitpy/common/net/networktransaction.py:
3326         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3327
3328 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3329
3330         Windows build fix.
3331         Import os before using it.
3332
3333         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3334
3335 2011-01-06  Eric Seidel  <eric@webkit.org>
3336
3337         Reviewed by Adam Barth.
3338
3339         StyleQueue fails to report errors when patches have many files
3340         https://bugs.webkit.org/show_bug.cgi?id=52042
3341
3342         This is one of at least two errors preventing style error reporting at the moment.
3343         When we moved to passing the list of files to check explicitly,
3344         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
3345         We could change the type of the QueueStatus.message type, or we could
3346         just teach statusserver.py how to clamp values (and warn when it does).
3347         I chose the latter path.
3348
3349         * Scripts/webkitpy/common/net/statusserver.py:
3350
3351 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3352
3353         Reviewed by Stephanie Lewis.
3354         
3355         Fix syntax error in script.
3356
3357         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3358         https://bugs.webkit.org/show_bug.cgi?id=51996
3359
3360         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3361
3362 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3363
3364         Unreviewed, fixing WinCE build after r75196.
3365
3366         WinCE port does not (yet) support NPAPI.
3367
3368         * Scripts/build-webkit:
3369
3370 2011-01-06  Xan Lopez  <xlopez@igalia.com>
3371
3372         Reviewed by Darin Adler.
3373
3374         File::Spec->rel2abs in sunspider-compare-results mangles parameters
3375         https://bugs.webkit.org/show_bug.cgi?id=52015
3376
3377         * Scripts/sunspider-compare-results: call rel2abs on our arguments
3378         after the platform has been detected, otherwise the script will
3379         mangle things like '--gtk' into '/a/path/--gtk', breaking the
3380         detection.
3381
3382 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3383
3384         Reviewed by Eric Seidel.
3385
3386         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
3387         https://bugs.webkit.org/show_bug.cgi?id=51346
3388
3389         * Scripts/build-webkit:
3390
3391 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3392
3393         Reviewed by Adam Roben.
3394
3395         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3396         https://bugs.webkit.org/show_bug.cgi?id=51996
3397         
3398         After the configuration directory change, we were archiving the incorrect directory for
3399         build product, so we were running tests on the wrong binaries.
3400         
3401         This change archives the correct directory, and also unarchives it into a configuration-
3402         specific directory.
3403
3404         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
3405         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
3406
3407 2011-01-06  Eric Seidel  <eric@webkit.org>
3408
3409         Reviewed by Mihai Parparita.
3410
3411         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
3412         https://bugs.webkit.org/show_bug.cgi?id=52002
3413
3414         See an example of this here:
3415         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
3416
3417         It's due to the fact that we pass around TestFailure() instance
3418         objects and yet expect them to all compare to be the same.
3419
3420         This is bad.  We should either have shared instances of these values
3421         or we should just pass around the class names.  There are already hacks
3422         in place to make TestFailure objects pass equality tests, I just added
3423         a __hash__ implementation so they can be used in sets as expected.
3424
3425         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3426         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3427
3428 2011-01-06  Evan Martin  <evan@chromium.org>
3429
3430         Reviewed by Tony Chang.
3431
3432         [gdb] handle inaccessible memory and UChar*
3433         https://bugs.webkit.org/show_bug.cgi?id=52003
3434
3435         To pretty-print a UChar*, we just grope around in the memory
3436         looking for a terminating NUL.  We need to handle the exception
3437         that can occur when we poke into an invalid location.
3438
3439         Additionally, the logic for choosing which pretty-printer would
3440         early return before hitting the point where we'd use the UChar*
3441         printer.  (Did this ever work?  How did it regress?)
3442
3443         * gdb/webkit.py:
3444
3445 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
3446
3447         Reviewed by Ada Chan.
3448
3449         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
3450         https://bugs.webkit.org/show_bug.cgi?id=51969
3451         
3452         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
3453
3454         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3455         (WTR::InjectedBundlePage::InjectedBundlePage):
3456         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
3457         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3458
3459 2011-01-06  James Robinson  <jamesr@chromium.org>
3460
3461         Reviewed by Simon Fraser.
3462
3463         Implement mozilla's animationTime property
3464         https://bugs.webkit.org/show_bug.cgi?id=51952
3465
3466         Chromium DRT support for webkitAnimationTime.
3467
3468         * DumpRenderTree/chromium/WebViewHost.cpp:
3469         (WebViewHost::paintInvalidatedRegion):
3470
3471 2011-01-06  Julie Parent  <jparent@chromium.org>
3472
3473         Reviewed by Tony Chang.
3474
3475         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
3476         https://bugs.webkit.org/show_bug.cgi?id=51217
3477
3478         * TestResultServer/model/jsonresults.py:
3479         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
3480         Adds missing documentation.
3481         * TestResultServer/model/jsonresults_unittest.py:
3482         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
3483         Update test_merge to take a number of builds to truncate at.
3484
3485 2011-01-06  Adam Barth  <abarth@webkit.org>
3486
3487         Reviewed by Eric Seidel.
3488
3489         The EWS should log outside of the working directory
3490         https://bugs.webkit.org/show_bug.cgi?id=51986
3491
3492         This patch prepare us for using git clean -x -d -f in the EWS wrapper
3493         script, which will actually clean the working copy back to a pristine
3494         state instead of leaving untracked directories and ignored files.
3495
3496         * Scripts/webkitpy/tool/commands/queues.py:
3497         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3498
3499 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3500
3501         Windows build fix.
3502         Back out attempted change to built-product-archive.
3503
3504         * BuildSlaveSupport/built-product-archive:
3505
3506 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3507
3508         Windows build fix.
3509         Include configuration name when unpacking a build archive.
3510
3511         Needed, since we split Windows build results into configuration-specific directories
3512         under WebKitOutputDir.
3513
3514         * BuildSlaveSupport/built-product-archive:
3515
3516 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3517
3518         Reviewed by Darin Adler.
3519
3520         Debug and Release builds on Windows clobber each other
3521         https://bugs.webkit.org/show_bug.cgi?id=49185
3522
3523         Changes the structure of WebKitBuild build products directory so we
3524         completely separate each build configuration into independent directories.
3525         
3526         Although we previously had per-configuration directories for obj, this change adds
3527         per-configuration directories for bin, lib, obj, and include. Each configuration's
3528         build products are stored within a directory inside of WebKitBuild.
3529         
3530         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
3531         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
3532
3533         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
3534         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
3535         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
3536         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
3537         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
3538         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
3539         * DumpRenderTree/win/ImageDiffCommon.vsprops:
3540         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
3541         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
3542         * FindSafari/FindSafari.vcproj:
3543         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
3544         * MiniBrowser/MiniBrowserPostBuild.cmd:
3545         * MiniBrowser/MiniBrowserPreBuild.cmd:
3546         * Scripts/webkitdirs.pm:
3547         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3548         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
3549         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
3550         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
3551         * TestWebKitAPI/win/copy-resources.cmd:
3552         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3553         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
3554         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
3555         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
3556         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
3557         * WebKitTestRunner/win/InjectedBundle.vcproj:
3558         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
3559         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
3560         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
3561         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
3562         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
3563         * WinLauncher/WinLauncherCommon.vsprops:
3564         * WinLauncher/WinLauncherPostBuild.cmd:
3565         * WinLauncher/WinLauncherPreBuild.cmd:
3566
3567 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
3568
3569         Reviewed by Ariya Hidayat.
3570
3571         [Qt] TestNetscapePlugin doesn't link on OS X
3572         https://bugs.webkit.org/show_bug.cgi?id=51948
3573
3574         Only add a dependency on libX11 on X11 systems
3575
3576         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3577
3578 2011-01-05  Jeff Miller  <jeffm@apple.com>
3579
3580         Reviewed by Adam Roben.
3581
3582         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
3583         https://bugs.webkit.org/show_bug.cgi?id=51970
3584
3585         * Scripts/webkitpy/style/checker.py:
3586         Add -readability/naming for WebKit2 C API directories.
3587
3588 2011-01-05  Eric Seidel  <eric@webkit.org>
3589
3590         Unreviewed, just fixing one more log error from my previous python patch.
3591
3592         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3593         https://bugs.webkit.org/show_bug.cgi?id=51802
3594
3595         webkit-patch failure-reason was logging about parsing errors
3596         due to my misunderstanding of how BeautifulSoup.findAll worked.
3597
3598         Fixed, and added a unit test.
3599
3600         * Scripts/webkitpy/common/net/layouttestresults.py:
3601         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3602
3603 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
3604
3605         Reviewed by Kenneth Rohde Christiansen.
3606
3607         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
3608         https://bugs.webkit.org/show_bug.cgi?id=51951
3609
3610         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
3611         to create new window from WebKit.
3612
3613         * MiniBrowser/qt/BrowserWindow.cpp:
3614         (newPageFunction):
3615         (BrowserWindow::BrowserWindow):
3616         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
3617         (BrowserWindow::newWindow):
3618         (BrowserWindow::updateUserAgentList):
3619         (BrowserWindow::showUserAgentDialog):
3620         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
3621         define the type of the backing store used for new windows.
3622         * MiniBrowser/qt/main.cpp:
3623         (main):
3624
3625 2011-01-05  Eric Seidel  <eric@webkit.org>
3626
3627         Reviewed by Ojan Vafai.
3628
3629         commit-queue should report failure type when reporting flaky tests
3630         https://bugs.webkit.org/show_bug.cgi?id=51900
3631
3632         This patch was a ridiculous amount of plumbing.  In the end I like
3633         the NRWT-style TestResult class even less.  But now we're passing
3634         a list of TestResult objects from the queue to the FlakyTestReporter.
3635         Thus the FlakyTestReporter can more easily report what type of failure
3636         occurred.
3637
3638         In the process, I found that I was not alone in finding TestResult
3639         cumbersome to use.  A bunch of code was trying to create a TestResult
3640         object with default values.  However since the constructor didn't make
3641         this easy, some places were getting it wrong (including the TestResult unit test)!
3642         I've fixed the TestResult constructor to have default values for non-essential
3643         arguments.
3644
3645         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3646         * Scripts/webkitpy/common/net/layouttestresults.py:
3647         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3648         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3649         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3650         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3651         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3652         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
3653         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3654         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3655         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3656         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3657         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3658         * Scripts/webkitpy/tool/commands/queues.py:
3659         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3660
3661 2011-01-05  Eric Seidel  <eric@webkit.org>
3662
3663         Unreviewed.
3664
3665         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3666         https://bugs.webkit.org/show_bug.cgi?id=51802
3667
3668         Add another unit test to cover a previously missing import.
3669
3670         * Scripts/webkitpy/common/net/layouttestresults.py:
3671         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3672
3673 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
3674
3675         Reviewed by David Levin.
3676
3677         Add mihaip@chromium.org as a reviewer
3678         https://bugs.webkit.org/show_bug.cgi?id=51966
3679         
3680         Add myself as a reviewer.
3681
3682         * Scripts/webkitpy/common/config/committers.py:
3683
3684 2011-01-05  James Simonsen  <simonjam@chromium.org>
3685
3686         Unreviewed. Adding myself to the list of committers.
3687
3688         * Scripts/webkitpy/common/config/committers.py:
3689
3690 2011-01-05  Eric Seidel  <eric@webkit.org>
3691
3692         Unreviewed.
3693
3694         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3695         https://bugs.webkit.org/show_bug.cgi?id=51802
3696
3697         Fix two exceptions seen on the bots after my original commit.
3698
3699         * Scripts/webkitpy/common/net/layouttestresults.py:
3700         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3701
3702 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
3703
3704         Reviewed by Andreas Kling.
3705