-asan-blacklist option also renamed to generic -fsanitize-blacklist
[WebKit-https.git] / Tools / ChangeLog
1 2014-10-02  David Farler  <dfarler@apple.com>
2
3         -asan-blacklist option also renamed to generic -fsanitize-blacklist
4         https://bugs.webkit.org/show_bug.cgi?id=137377
5
6         Reviewed by Daniel Bates.
7
8         * asan/asan.xcconfig:
9         -asan-blacklist -> -fsanitize-blacklist
10
11         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
12
13 2014-10-03  Roger Fong  <roger_fong@apple.com>
14
15         [Windows] Include batch size argument to layout tests on Windows.
16
17         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
18         (RunWebKitTests.start): 
19         This is a speculative fix for the the inconsistent crashes we are seeing on Windows.
20         These crashes seem to happen on random tests though generally in a spread out fashion.
21         It seems possible that the DRT instance is being clobbered somehow after running too many
22         tests in a row so we will try to mitigate this by just forcing DRT to restart periodically.
23
24 2014-10-03  Roger Fong  <roger_fong@apple.com>
25
26         [Windows] Settle for 2 chid processes running NRWT on Windows.
27
28         * Scripts/webkitpy/port/win.py:
29         (WinPort.default_child_processes): 3 child processes reintroduces the sporadic crashing, will settle for 2.
30
31 2014-10-03  Akos Kiss  <akiss@inf.u-szeged.hu>
32
33         [GTK] Bump up and patch dependencies to allow building for aarch64
34         https://bugs.webkit.org/show_bug.cgi?id=137147
35
36         Reviewed by Martin Robinson.
37
38         The currently used versions of pixman, libffi, librsvg, glib,
39         glib-networking, fontconfig, libxml2, gst-plugins-base fail to configure
40         and/or build for aarch64, so they are bumped up and patched where
41         necessary. Wherever possible, the same versions and patches were used as
42         for the EFL port bump-up
43         (https://bugs.webkit.org/show_bug.cgi?id=135885).
44
45         After the bump-up, a hitherto hidden bug in gst-plugins-good caused a
46         regression by crashing http/tests/media/video-redirect.html . A patch
47         already in upstream fixes that bug.
48
49         This change does not touch xserver, which also needs bumping up, but 
50         will be dealt with later.
51
52         * gtk/jhbuild.modules:
53         Specified versions and patches necessary to correctly build for aarch64.
54         * gtk/patches/gst-events-arent-gstobjects.patch:
55         Added. Patches gst-plugins-good to fix a bug in .mov file demuxing.
56         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch:
57         Added. Patches gst-plugins-base to configure correctly for aarch64.
58         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch:
59         Added. Bumps up config.guess and config.sub in librsvg to recognize
60         aarch64.
61         * gtk/patches/libxml2-2.9.0-dtd.patch:
62         Removed. Not necessary for libxml2 v2.9.1 anymore.
63
64 2014-09-28  Sam Weinig  <sam@webkit.org>
65
66         Remove RefPtrHashMap
67         https://bugs.webkit.org/show_bug.cgi?id=137200
68
69         Reviewed by Darin Adler.
70
71         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
72         (TestWebKitAPI::TEST):
73         Add tests for using a HashMap with RefPtr keys, focusing on ensuring that
74         a minimum of refcount churn occurs.
75
76 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
77
78         Remove workarounds for versions of Python before 2.7
79         https://bugs.webkit.org/show_bug.cgi?id=137338
80
81         Reviewed by Csaba Osztrogonác.
82
83         * Scripts/webkitpy/common/system/autoinstall.py:
84         (AutoInstaller._extract_targz):
85         (AutoInstaller._unzip):
86         (AutoInstaller): Deleted.
87         (AutoInstaller._extract_all): Deleted.
88         * Scripts/webkitpy/common/webkitunittest.py:
89         (TestCase.setUp): Deleted.
90         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
91         (TestConfigurationConverter.collapse_macros):
92         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
93         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
94         (TestConfigurationConverter):
95         (TestConfigurationConverter.combinations): Deleted.
96         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
97         * Scripts/webkitpy/port/base.py:
98
99 2014-10-03  Commit Queue  <commit-queue@webkit.org>
100
101         Unreviewed, rolling out r174264.
102         https://bugs.webkit.org/show_bug.cgi?id=137392
103
104         It broke run-webkit-tests (Requested by ebalazsfalvi on
105         #webkit).
106
107         Reverted changeset:
108
109         "Remove workarounds for versions of Python before 2.7"
110         https://bugs.webkit.org/show_bug.cgi?id=137338
111         http://trac.webkit.org/changeset/174264
112
113 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
114
115         Remove workarounds for versions of Python before 2.7
116         https://bugs.webkit.org/show_bug.cgi?id=137338
117
118         Reviewed by Csaba Osztrogonác.
119
120         * Scripts/webkitpy/common/system/autoinstall.py:
121         (AutoInstaller._extract_targz):
122         (AutoInstaller._unzip):
123         (AutoInstaller): Deleted.
124         (AutoInstaller._extract_all): Deleted.
125         * Scripts/webkitpy/common/webkitunittest.py:
126         (TestCase.setUp): Deleted.
127         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
128         (TestConfigurationConverter.collapse_macros):
129         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
130         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
131         (TestConfigurationConverter):
132         (TestConfigurationConverter.combinations): Deleted.
133         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
134         * Scripts/webkitpy/port/base.py:
135         * Scripts/webkitpy/port/driver.py:
136         (ContentBlock.__init__):
137         * Scripts/webkitpy/port/server_process.py:
138         (ServerProcess._reset):
139
140 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
141
142         Remove autoinstaller workaround for python 2.6
143         https://bugs.webkit.org/show_bug.cgi?id=137343
144
145         Reviewed by Daniel Bates.
146
147         Reverting <http://trac.webkit.org/changeset/124928>, neither Python
148         2.6, nor Snow Leopard is supported anymore, so the workaround is not
149         needed anymore.
150
151         * Scripts/webkitpy/common/system/autoinstall.py:
152         (AutoInstaller.install):
153         * Scripts/webkitpy/test/main.py:
154         (Tester._run_tests):
155         * Scripts/webkitpy/thirdparty/__init__.py:
156         (AutoinstallImportHook._install_mechanize):
157         (AutoinstallImportHook._install_pep8):
158         (AutoinstallImportHook._install_pylint):
159         (AutoinstallImportHook._install_buildbot):
160         (AutoinstallImportHook._install_coverage):
161         (AutoinstallImportHook._install_eliza):
162         (AutoinstallImportHook._install_irc):
163         (AutoinstallImportHook._install):
164         (autoinstall_everything):
165
166 2014-10-02  Daniel Bates  <dabates@apple.com>
167
168         Use version number 101000 instead of 10100 for OS X Yosemite
169         https://bugs.webkit.org/show_bug.cgi?id=137372
170
171         Reviewed by Mark Rowe.
172
173         The version number for OS X Yosemite is 101000.
174
175         * DumpRenderTree/mac/TextInputController.m:
176
177 2014-10-02  Alexey Proskuryakov  <ap@apple.com>
178
179         update-work-items should never delete items
180         https://bugs.webkit.org/show_bug.cgi?id=137366
181
182         Reviewed by Ryosuke Niwa.
183
184         As we don't just replace the whole list any more, indicate which items are high
185         priority, and which are not. Hight priority ones will be prepended to the queue,
186         others will be appended.
187
188         This creates a bit of unfairness in that high priority item queue becomes a LIFO.
189         But hopefully we will never have many rollouts competing like that.
190
191         * QueueStatusServer/app.yaml: Update version.
192
193         * QueueStatusServer/handlers/updateworkitems.py: Never remove items. Pass high
194         priority and regular items separately. Removed some error handling that used to
195         end up in returning status 500 - an uncaught exception does that automatically.
196
197         * QueueStatusServer/main.py: Removed unnecessary regexps from URL matching code.
198
199         * QueueStatusServer/model/workitems.py: Added a way to add high priority items.
200
201         * QueueStatusServer/templates/updateworkitems.html: Added a field for high
202         priority items.
203
204         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
205         (BugzillaQueries._parse_attachment_ids_request_query): Removed an annoying log
206         line that complicated testing.
207
208         * Scripts/webkitpy/common/net/statusserver.py: Pass high priority items separately.
209
210         * Scripts/webkitpy/tool/bot/feeders.py: For commit queue, split high and regular
211         priority items into separate lists.
212
213         * Scripts/webkitpy/common/net/statusserver_mock.py:
214         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
215         * Scripts/webkitpy/tool/commands/queues_unittest.py:
216         Updated tests.
217
218 2014-10-02  Brendan Long  <b.long@cablelabs.com>
219
220         Annoying build warnings in WTFString API tests
221         https://bugs.webkit.org/show_bug.cgi?id=137360
222
223         Reviewed by Darin Adler.
224
225         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
226         (TestWebKitAPI::TEST): Change EXPECT_EQ(false, ok) to EXPECT_FALSE(ok) and EXPECT_EQ(true, ok) to EXPECT_TRUE(ok).
227
228 2014-10-02  Roger Fong  <roger_fong@apple.com>
229
230         [Windows] The number of processes did not affect the crash inconsistency, increase number of child processes again.
231
232         * Scripts/webkitpy/port/win.py:
233         (WinPort.default_child_processes): Ambitiously try 3 processes the testers are too slow now.
234
235 2014-10-02  David Farler  <dfarler@apple.com>
236
237         Move ASan arguments from LLVM (-mllvm) to the frontend
238         https://bugs.webkit.org/show_bug.cgi?id=137365
239
240         Reviewed by David Kilzer.
241
242         * asan/asan.xcconfig:
243         Remove the -mllvm prefix to the asan-blacklist argument, moving it
244         to the clang frontend.
245
246         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
247
248 2014-10-02  Commit Queue  <commit-queue@webkit.org>
249
250         Unreviewed, rolling out r174120.
251         https://bugs.webkit.org/show_bug.cgi?id=137350
252
253         While number of failures is reasonable with 2 processes, test
254         results seem to be inconsistent between runs (Requested by
255         rfong on #webkit).
256
257         Reverted changeset:
258
259         "[Windows] Back to 2 child processes for NRWT on Windows."
260         http://trac.webkit.org/changeset/174120
261
262 2014-10-02  Jeff Miller  <jeffm@apple.com>
263
264         DumpRenderTree and WebKitTestRunner should use WebKitystemInterfaceYosemite when building on Yosemite
265         https://bugs.webkit.org/show_bug.cgi?id=137347
266
267         Reviewed by Dan Bernstein.
268
269         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
270         Use WebKitSystemInterfaceYosemite on OS X 10.10.
271
272         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
273         Ditto.
274
275 2014-10-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
276
277         [GTK] [JHBuild] Switch sourceware.org mirror to http.
278
279         Unreviewed.
280
281         The ftp access is recently failing to work as expected, and the
282         bots fail to download the file.
283         The same mirror is available via http and seems to work better.
284
285         * gtk/jhbuild.modules:
286
287 2014-10-01  Commit Queue  <commit-queue@webkit.org>
288
289         Unreviewed, rolling out r174185.
290         https://bugs.webkit.org/show_bug.cgi?id=137334
291
292         Patch that adds logging causes webkitpy failures (Requested by
293         rfong on #webkit).
294
295         Reverted changeset:
296
297         "commitqueuetasks_unittest references a non-existent member
298         variable"
299         https://bugs.webkit.org/show_bug.cgi?id=137303
300         http://trac.webkit.org/changeset/174185
301
302 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
303
304         EWS and Commit Queue should know better than to spew 500 failed
305         results in the case of extremely red patches.
306         https://bugs.webkit.org/show_bug.cgi?id=137324
307
308         Reviewed by Alexey Proskuryakov.
309
310         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
311         Adds a check for did_exceed_test_failure_limit.
312         (AbstractEarlyWarningSystem._failing_tests_message):
313         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
314         Alters the task mock to respond properly to
315         results_from_patch_test_run(patch)
316         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
317         * Scripts/webkitpy/tool/commands/queues.py:
318         Adds a check for did_exceed_test_failure_limit.
319         (CommitQueue._failing_tests_message):
320
321 2014-10-01  Daniel Bates  <dabates@apple.com>
322
323         Unreviewed, rolling out r174192.
324
325         Revert the unit test fix in r174192 since we reverted r174187
326         in r174194 due to correctness issues. See
327         <http://webkit.org/b/137329> for more details.
328
329         Reverted changeset:
330
331         "Test fix after r174187"
332         http://trac.webkit.org/changeset/174192
333
334 2014-10-01  Mark Rowe  <mrowe@apple.com>
335
336         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
337
338         Reviewed by Dan Bernstein.
339
340         * Scripts/copy-webkitlibraries-to-product-directory: Copy libWebKitSystemInterfaceYosemite.a
341         into the build directory. Use LLVMIncludesYosemite.tar.bz2 and LLVMLibrariesYosemite.tar.bz2
342         for the LLVM components when on Yosemite.
343
344 2014-10-01  Commit Queue  <commit-queue@webkit.org>
345
346         Unreviewed, rolling out r174187.
347         https://bugs.webkit.org/show_bug.cgi?id=137329
348
349         webkitpy failures, and thorton says the patch is wrong
350         (Requested by dethbakin on #webkit).
351
352         Reverted changeset:
353
354         "[Windows] Increase layout test timeout for Windows following
355         r174162."
356         http://trac.webkit.org/changeset/174187
357
358 2014-10-01  Brent Fulgham  <bfulgham@apple.com>
359
360         Test fix after r174187
361
362         * Scripts/webkitpy/port/win_unittest.py:
363         (WinPortTest.test_default_timeout_ms): Expect the new 50000 ms timeout for Windows tests.
364
365 2014-10-01  Roger Fong  <roger_fong@apple.com>
366
367         [Windows] Increase layout test timeout for Windows following r174162.
368
369         * Scripts/webkitpy/port/win.py:
370         (WinPort.default_timeout_ms):
371
372 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
373
374         commitqueuetasks_unittest references a non-existent member variable
375         when mock-reporting flaky tests.
376         https://bugs.webkit.org/show_bug.cgi?id=137303
377
378         Reviewed by Daniel Bates.
379
380         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
381         (MockCommitQueue.report_flaky_tests):
382         Makes the appropriate name change.
383         (test_simple_flaky_test_failure):
384         Adds a unit test to make sure that the code is excercised.
385
386 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
387
388         EWS is inconclusively spinning forever on a patch that breaks 500+
389         tests
390         https://bugs.webkit.org/show_bug.cgi?id=137223
391
392         Reviewed by Tim Horton.
393
394         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
395         Checks to see whether the tests have exceeded the failure limit, and
396         only spins off another test if they have not exceeded the limit.
397         (PatchAnalysisTask._test_patch):
398
399 2014-10-01  Brian J. Burg  <burg@cs.washington.edu>
400
401         Unreviewed, add Katie Madonna as a contributor.
402
403         * Scripts/webkitpy/common/config/contributors.json:
404
405 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
406
407         commitqueuetasks_unittest does not construct FailingTestCommitQueue
408         objects properly in its test cases.
409         https://bugs.webkit.org/show_bug.cgi?id=137281
410
411         Reviewed by Daniel Bates.
412
413         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
414         (FailingTestCommitQueue.test_results):
415         Adds an assert to make FailingTestCommitQueue harder to mis-use.
416         (test_double_flaky_test_failure):
417         Nests the intended test failure strings into one-length lists.
418         (test_red_test_failure):
419         Nests the intended test failure strings into one-length lists.
420
421 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
422
423         REGRESSION (r172172): Multiple regression tests fail when primary system language is Russian
424         https://bugs.webkit.org/show_bug.cgi?id=136987
425
426         Reviewed by Daniel Bates.
427
428         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
429         Specify the default encoding for all WebKit developers to get consistent results.
430
431 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
432
433         EWS is too eager to say that a patch does not apply to trunk of repository
434         https://bugs.webkit.org/show_bug.cgi?id=137290
435
436         Reviewed by Ryosuke Niwa.
437
438         * QueueStatusServer/app.yaml: Updated app version.
439
440         * QueueStatusServer/handlers/statusbubble.py:
441         (StatusBubble._build_bubble):
442         (StatusBubble._build_bubbles_for_attachment):
443         Rewrote to make more sense.
444
445 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
446
447         Remove thirdparty/unittest2 from webkitpy
448         https://bugs.webkit.org/show_bug.cgi?id=137251
449
450         Reviewed by Brent Fulgham.
451
452         Additionally ordered imports in related webkitpy files and
453         removed unnecessary shebangs from unittest files.
454
455         * BuildSlaveSupport/build.webkit.org-config/htdigestparser_unittest.py:
456         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
457         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
458         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
459         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
460         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
461         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
462         * Scripts/webkitpy/common/config/committers_unittest.py:
463         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
464         * Scripts/webkitpy/common/config/contributionareas_unittest.py:
465         * Scripts/webkitpy/common/config/ports_unittest.py:
466         * Scripts/webkitpy/common/config/urls_unittest.py:
467         * Scripts/webkitpy/common/editdistance_unittest.py:
468         * Scripts/webkitpy/common/find_files_unittest.py:
469         * Scripts/webkitpy/common/lru_cache_unittest.py:
470         * Scripts/webkitpy/common/memoized_unittest.py:
471         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
472         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
473         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
474         * Scripts/webkitpy/common/net/credentials_unittest.py:
475         * Scripts/webkitpy/common/net/failuremap_unittest.py:
476         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
477         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
478         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
479         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
480         * Scripts/webkitpy/common/net/statusserver_unittest.py:
481         * Scripts/webkitpy/common/net/unittestresults_unittest.py:
482         * Scripts/webkitpy/common/newstringio_unittest.py:
483         * Scripts/webkitpy/common/prettypatch_unittest.py:
484         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py:
485         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
486         * Scripts/webkitpy/common/system/environment_unittest.py:
487         * Scripts/webkitpy/common/system/executive.py: Ordered imports.
488         * Scripts/webkitpy/common/system/executive_mock.py: Ordered imports.
489         * Scripts/webkitpy/common/system/executive_unittest.py:
490         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
491         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
492         * Scripts/webkitpy/common/system/filesystem_unittest.py:
493         * Scripts/webkitpy/common/system/logtesting.py:
494         * Scripts/webkitpy/common/system/logutils_unittest.py:
495         * Scripts/webkitpy/common/system/outputcapture.py:
496         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
497         * Scripts/webkitpy/common/system/outputtee_unittest.py:
498         * Scripts/webkitpy/common/system/path_unittest.py:
499         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
500         * Scripts/webkitpy/common/system/profiler_unittest.py:
501         * Scripts/webkitpy/common/system/stack_utils_unittest.py:
502         * Scripts/webkitpy/common/system/user_unittest.py:
503         * Scripts/webkitpy/common/system/workspace_unittest.py:
504         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
505         * Scripts/webkitpy/common/thread/messagepump_unittest.py:
506         * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
507         * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py:
508         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py:
509         * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py:
510         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
511         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py:
512         * Scripts/webkitpy/common/webkitunittest.py:
513         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
514         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
515         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
516         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
517         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
518         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
519         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
520         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
521         * Scripts/webkitpy/layout_tests/models/test_results_unittest.py:
522         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
523         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
524         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
525         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py:
526         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
527         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
528         * Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:
529         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
530         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
531         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
532         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
533         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
534         * Scripts/webkitpy/port/base_unittest.py:
535         * Scripts/webkitpy/port/builders_unittest.py:
536         * Scripts/webkitpy/port/config_unittest.py:
537         * Scripts/webkitpy/port/driver_unittest.py:
538         * Scripts/webkitpy/port/efl_unittest.py:
539         * Scripts/webkitpy/port/factory_unittest.py:
540         * Scripts/webkitpy/port/gtk_unittest.py:
541         * Scripts/webkitpy/port/http_lock_unittest.py:
542         * Scripts/webkitpy/port/image_diff_unittest.py:
543         * Scripts/webkitpy/port/leakdetector_unittest.py:
544         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py:
545         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
546         * Scripts/webkitpy/port/mock_drt_unittest.py:
547         * Scripts/webkitpy/port/port_testcase.py:
548         * Scripts/webkitpy/port/server_process_unittest.py:
549         * Scripts/webkitpy/port/westondriver_unittest.py:
550         * Scripts/webkitpy/port/win_unittest.py:
551         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
552         * Scripts/webkitpy/style/checker_unittest.py:
553         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
554         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
555         * Scripts/webkitpy/style/checkers/common_unittest.py:
556         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
557         * Scripts/webkitpy/style/checkers/exportfile_unittest.py:
558         * Scripts/webkitpy/style/checkers/js_unittest.py:
559         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
560         * Scripts/webkitpy/style/checkers/messagesin_unittest.py:
561         * Scripts/webkitpy/style/checkers/png_unittest.py:
562         * Scripts/webkitpy/style/checkers/python_unittest.py:
563         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
564         * Scripts/webkitpy/style/checkers/text_unittest.py:
565         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
566         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
567         * Scripts/webkitpy/style/checkers/xml_unittest.py:
568         * Scripts/webkitpy/style/error_handlers_unittest.py:
569         * Scripts/webkitpy/style/filereader_unittest.py:
570         * Scripts/webkitpy/style/filter_unittest.py:
571         * Scripts/webkitpy/style/main_unittest.py:
572         * Scripts/webkitpy/style/optparser_unittest.py:
573         * Scripts/webkitpy/style/patchreader_unittest.py:
574         * Scripts/webkitpy/test/finder_unittest.py:
575         * Scripts/webkitpy/test/main.py: Ordered imports.
576         * Scripts/webkitpy/test/main_unittest.py:
577         * Scripts/webkitpy/test/printer.py: Ordered imports.
578         (Printer.configure):
579         * Scripts/webkitpy/test/runner_unittest.py:
580         * Scripts/webkitpy/test/skip_unittest.py:
581         * Scripts/webkitpy/thirdparty/__init__.py:
582         (AutoinstallImportHook._install_irc):
583         (AutoinstallImportHook._install_unittest2): Deleted.
584         * Scripts/webkitpy/thirdparty/__init___unittest.py:
585         * Scripts/webkitpy/thirdparty/ordered_dict.py: Removed.
586         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
587         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
588         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
589         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
590         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
591         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
592         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
593         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
594         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
595         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
596         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
597         * Scripts/webkitpy/tool/commands/download_unittest.py:
598         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
599         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
600         * Scripts/webkitpy/tool/commands/queries_unittest.py:
601         * Scripts/webkitpy/tool/commands/queuestest.py:
602         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
603         * Scripts/webkitpy/tool/grammar_unittest.py:
604         * Scripts/webkitpy/tool/mocktool_unittest.py:
605         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
606         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
607         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
608         * Scripts/webkitpy/tool/servers/reflectionhandler_unittest.py:
609         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py:
610         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
611         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
612         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
613         * Scripts/webkitpy/tool/steps/commit_unittest.py:
614         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py:
615         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
616         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
617         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
618         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
619         * Scripts/webkitpy/tool/steps/steps_unittest.py:
620         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
621         * Scripts/webkitpy/tool/steps/update_unittest.py:
622         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
623         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
624         * Scripts/webkitpy/w3c/test_converter_unittest.py:
625         * Scripts/webkitpy/w3c/test_importer_unittest.py:
626         * Scripts/webkitpy/w3c/test_parser_unittest.py:
627
628 2014-09-30  Jake Nielsen  <jacob_nielsen@apple.com>
629
630         LayoutTestResults and ExpectedFailures should know about the
631         interrupted flag from the json results file
632         https://bugs.webkit.org/show_bug.cgi?id=137229
633
634         Reviewed by Daniel Bates.
635
636         Changes LayoutTestResults to use the interrupted flag instead of
637         counting failures.
638
639         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
640         (BuilderTest._install_fetch_build._mock_fetch_build):
641         (BuilderTest.test_latest_layout_test_results):
642         * Scripts/webkitpy/common/net/layouttestresults.py:
643         Removes notion of failure_limit_count, and adds
644         did_exceed_test_failure_limit.
645
646         (LayoutTestResults.results_from_string):
647         (LayoutTestResults.__init__):
648         (LayoutTestResults.did_exceed_test_failure_limit):
649         (LayoutTestResults): Deleted.
650         (LayoutTestResults.set_failure_limit_count): Deleted.
651         (LayoutTestResults.failure_limit_count): Deleted.
652         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
653         Removes unit test for failure_limit_count logic.
654
655         (LayoutTestResultsTest.test_set_failure_limit_count): Deleted.
656         * Scripts/webkitpy/common/net/resultsjsonparser.py:
657         Instead of providing a class method that returns a list of
658         TestResults objects, resultsjsonparser now provides a class
659         ParsedJSONResults that serves as an interface between the results.json
660         file and the rest of webkitpy.
661
662         (ParsedJSONResults):
663         (ParsedJSONResults.__init__):
664         (ParsedJSONResults.did_exceed_test_failure_limit):
665         (ParsedJSONResults.test_results):
666         (ResultsJSONParser): Deleted.
667         (ResultsJSONParser.parse_results_json): Deleted.
668         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
669         Updates the unit test so that it can test the new ResultsJSONParser
670         class.
671
672         (ParsedJSONResultsTest):
673         (test_basic):
674         (ResultsJSONParserTest): Deleted.
675         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
676         Updates the unit test to instantiate ResultsJSONParser objects rather
677         than simple lists of TestResult objects.
678
679         (MockCommitQueue.test_results):
680         (FailingTestCommitQueue.test_results):
681         (test_flaky_test_failure):
682         (test_failed_archive):
683         * Scripts/webkitpy/tool/bot/expectedfailures.py:
684         Updates ExpectedFailures to use the did_exceed_test_failure_limit
685         method rather than counting the number of failed tests.
686
687         (ExpectedFailures._should_trust):
688         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
689         Updates MockResults to more closely resemble the updated
690         LayoutTestResults class.
691
692         (MockResults.__init__):
693         (MockResults.did_exceed_test_failure_limit):
694         (ExpectedFailuresTest.test_can_trust_results):
695         (ExpectedFailuresTest.test_unexpected_failures_observed):
696         (ExpectedFailuresTest.test_unexpected_failures_observed_when_tree_is_hosed):
697         (MockResults.failure_limit_count): Deleted.
698         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
699         Removes a FIXME regarding the use of the
700         NON_INTERACTIVE_FAILURE_LIMIT_COUNT value.
701
702         (LayoutTestResultsReader.results):
703         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
704         Updates test to not check the now-nonexistant failure_count_limit
705         method.
706
707         (test_missing_unit_test_results_path):
708         (test_layout_test_results):
709         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
710         Accounts for name change: ResultsJSONParserTest ->
711         ParsedJSONParserTest.
712
713         (RebaselineTestTest.test_gather_baselines):
714
715 2014-09-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
716
717         [EFL] Rename TEST_THEME_DIR macro
718         https://bugs.webkit.org/show_bug.cgi?id=137244
719
720         Reviewed by Csaba Osztrogonác.
721
722         TEST_THEME_DIR is to get a path for default theme though, it has used TEST_ prefix.
723         DEFAULT_THEME_DIR is better than it.
724
725         * MiniBrowser/efl/main.c:
726         (window_create):
727         * TestWebKitAPI/efl/PlatformWebView.cpp:
728         (TestWebKitAPI::PlatformWebView::PlatformWebView):
729         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
730         (WTR::PlatformWebView::PlatformWebView):
731
732 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
733
734         Windows EWS went purple when it failed to build
735         https://bugs.webkit.org/show_bug.cgi?id=137267
736
737         Reviewed by Ryosuke Niwa.
738
739         * QueueStatusServer/app.yaml: Update the version.
740
741         * QueueStatusServer/model/attachment.py: (Attachment._calculate_queue_positions):
742         Make it work for style and win-ews queues.
743
744 2014-09-29  Filip Pizlo  <fpizlo@apple.com>
745
746         It should be fun and easy to run every possible JavaScript benchmark from the command line
747         https://bugs.webkit.org/show_bug.cgi?id=137245
748
749         Reviewed by Oliver Hunt.
750         
751         We previously had Tools/Scripts/bencher.  Then we stopped adding things to it because we
752         weren't sure about the licensing of things like Kraken and Octane.  Various people ended up
753         having their own private scripts for doing benchmark runs, and didn't share them in the open
754         source community, because of fears about the shady licensing of the benchmarks suites that
755         they were running. The dominant version of this was "run-jsc-benchmarks", which has a lot of
756         excellent power - it can run benchmarks through either jsc, DumpRenferTree, or
757         WebKitTestRunner; it can run tests on any number of remote machines; and it has inside
758         knowledge about how to run *a lot* of test suites. Many of those test suites are not public,
759         but some of them are. The non-public tests are exclusively those that were not made by any
760         WebKit contributor, but which JSC/WebKit devs found useful for testing.
761
762         This fixes this weirdness by releasing run-jsc-benchmarks. The paths to the test suites
763         whose licenses are incompatible with WebKit's (to the extent that they cannot be safely
764         checked into WebKit svn at all) can be run by passing the path to them via a configuration
765         file. The default configuration file is ~/.run-jsc-benchmarks. The most important benchmark
766         suites are Octane version 2 and Kraken version 1.1. We should probably check Octane 2 into
767         WebKit eventually because it seems that the license is fine. Kraken, on the other hand, will
768         probably never be checked in because there is no license text anywhere in that benchmark.
769         A valid ~/.run-jsc-benchmarks file will just be something like:
770         
771             {
772                 "OctanePath": "/path/to/Octane2",
773                 "KrakenPath": "/path/to/Kraken-1.1/tests/kraken-1.1"
774             }
775         
776         If your ~/.run-jsc-benchmarks file omits the directory for any particular test suite, then
777         run-jsc-benchmarks will just gracefully avoid running that test suite.
778         
779         Finally, a word about policy: it is understood that different organizations that do
780         development on JSC may find themselves having internal benchmarks that they cannot share
781         because of weird licensing. It happens - usually because the organization doing JSC
782         development found some test in the wild that is owned by someone else and therefore cannot
783         be shared. So, we should consider it acceptable to write patches against run-jsc-benchmarks
784         that add support for some new kind of benchmark suite even if the suite is not made public
785         as part of the same patch - so long as the patch isn't too invasive. An example of
786         non-invasiveness is the DSPJS suite, which is implemented using some new classes (like
787         DSPJSAmmoJSRegularBenchmark) and some calls to otherwise reusable functions (like
788         emitSelfContainedBenchRunCode). It is obviously super helpful if a benchmark suite can be
789         completely open-sourced and committed to the WebKit repo - but the reality is that this
790         can't always be done safely.
791
792         * Scripts/bencher: Removed.
793         * Scripts/run-jsc-benchmarks: Added.
794
795 2014-09-30  Roger Fong  <roger_fong@apple.com>
796
797         [Windows] Add some logging to webkitpy to debug timeout issues with running NRWT using multiple child processes.
798
799         * Scripts/webkitpy/port/drdiver.py:
800         (Driver.stop):
801         * Scripts/webkitpy/port/server_process.py:
802         (ServerProcess.stop):
803
804 2014-09-30  Roger Fong  <roger_fong@apple.com>
805
806         [Windows] Back to 2 child processes for NRWT on Windows.
807
808         * Scripts/webkitpy/port/win.py:
809         (WinPort.default_child_processes):
810         Changing the number of processes to 1 did not have an effect on the layout test results. 
811         It does introduce an issue with one of the workers hanging indefinitely and causing the 
812         layout tests to timeout as a whole occasionally, but we should just fix that.
813
814 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
815
816         Remove an accidentally committed line..
817
818         * QueueStatusServer/handlers/statusbubble.py:
819         (StatusBubble._build_bubble):
820
821 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
822
823         build.webkit.org/dashboard: Switch EWS view to using actual retry count
824         https://bugs.webkit.org/show_bug.cgi?id=137240
825
826         Reviewed by Ryosuke Niwa.
827
828         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
829         (EWSQueue.prototype.loadDetailedStatus):
830         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
831         (EWSQueueView.prototype._popoverContentForEWSQueue):
832         Use the new retry_count data member from JSON.
833
834         * QueueStatusServer/app.yaml: Updating the version.
835
836         * QueueStatusServer/handlers/queuestatusjson.py: (QueueStatusJSON._rows_for_work_items):
837         Instead of message_count, produce retry_count.
838
839 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
840
841         EWS doesn't need to show all the bubbles when a patch fails to apply
842         https://bugs.webkit.org/show_bug.cgi?id=137256
843
844         Reviewed by Ryosuke Niwa.
845
846         * QueueStatusServer/app.yaml: Updated app version.
847
848         * QueueStatusServer/handlers/statusbubble.py:
849         (StatusBubble._build_bubble):
850         (StatusBubble._build_bubbles_for_attachment):
851         (StatusBubble.get):
852         * QueueStatusServer/templates/statusbubble.html:
853         When some queues fail to apply, and no queues had meaningful output (meaning that
854         they will almost certainly fail to apply later), we can show a single bubble
855         telling the user just that.
856
857 2014-09-30  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
858
859         [EFL] Bump EFL version to 1.11.2
860         https://bugs.webkit.org/show_bug.cgi?id=137118
861
862         Reviewed by Gyuyoung Kim.
863
864         Disable NEON for EFL build because the build system doesn't pass the necessary -mfpu=neon flag to the compiler.
865         Tools/efl/patches/ecore.patch: Removed, because this fix is already in EFL.
866
867         * efl/jhbuild.modules:
868         * efl/patches/ecore.patch: Removed.
869
870 2014-09-30  Carlos Garcia Campos  <cgarcia@igalia.com>
871
872         REGRESSION(r173929): [GTK] TestInspector fails after r173929
873         https://bugs.webkit.org/show_bug.cgi?id=137247
874
875         Reviewed by Philippe Normand.
876
877         Wait until can-attach property changes before trying to attach the
878         inspector after resizing the view.
879
880         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp:
881         (testInspectorDefault):
882
883 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
884
885         Require Python 2.7 version
886         https://bugs.webkit.org/show_bug.cgi?id=137112
887
888         Reviewed by Csaba Osztrogonác.
889
890         * Scripts/ensure-valid-python:
891         (checkPythonVersion):
892         * Scripts/webkitpy/common/version_check.py:
893
894 2014-09-30  Martin Hock  <mhock@apple.com>
895
896         Skip a JSC test after r174036.
897         https://bugs.webkit.org/show_bug.cgi?id=137236
898
899         Reviewed by Csaba Osztrogonác.
900
901         * Scripts/run-javascriptcore-tests:
902
903 2014-09-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
904
905         [GTK] [EFL] Install TestNetscapePlugin apart from the other libs.
906         https://bugs.webkit.org/show_bug.cgi?id=137212
907
908         This moves TestNetscapePlugin to a new folder (lib/plugins).
909         We should not use the same directory for TestNetscapePlugin and
910         the other libraries, because we end up scanning all the .so in the
911         lib dir for every test.
912
913         Reviewed by Carlos Garcia Campos.
914
915         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set LIBRARY_OUTPUT_DIRECTORY to lib/plugins.
916         * Scripts/webkitpy/port/efl.py:
917         (EflPort.setup_environ_for_server): Update plugin path.
918         * Scripts/webkitpy/port/gtk.py:
919         (GtkPort.setup_environ_for_server): Update plugin path.
920         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Update plugin path.
921
922 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
923
924         A small change to EWS bubble text. Explain why there are messages for ineligible patches.
925
926         Rubber-stamped by Tim Horton.
927
928         * QueueStatusServer/app.yaml:
929         * QueueStatusServer/handlers/statusbubble.py:
930         (StatusBubble._build_bubble):
931
932 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
933
934         Typo fix, suggested by Tim Horton.
935
936         * QueueStatusServer/handlers/statusbubble.py:
937         (StatusBubble._build_message_for_provisional_failure):
938
939 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
940
941         Improve Bugzilla status bubbles
942         https://bugs.webkit.org/show_bug.cgi?id=137232
943
944         Reviewed by Ryosuke Niwa.
945
946         * QueueStatusServer/app.yaml: Will update again with an actual version when landing.
947
948         * QueueStatusServer/handlers/statusbubble.py: Eliminated yellow color, added
949         blue and orange. Significantly extended tooltips. Made bubbles show up even for queues
950         that are stuck, as it was only confusing that they disappeared after 99.
951
952         * QueueStatusServer/model/attachment.py: Removed functionality that was only used
953         by old bubbles. We need a lot more information to determine color, so the implementation
954         can not be here.
955
956         * QueueStatusServer/templates/statusbubble.html: Updated colors in CSS, made bubbles
957         always have a link for consistency. Added code to convert timestamps in tooltips
958         to local time zone.
959
960 2014-09-29  Commit Queue  <commit-queue@webkit.org>
961
962         Unreviewed, rolling out r174045.
963         https://bugs.webkit.org/show_bug.cgi?id=137231
964
965         Introduced a crash during page loading tests on Mac (Requested
966         by rniwa on #webkit).
967
968         Reverted changeset:
969
970         "Replace OSObjectPtr with RetainPtr/adoptOS"
971         https://bugs.webkit.org/show_bug.cgi?id=137158
972         http://trac.webkit.org/changeset/174045
973
974 2014-09-29  Tim Horton  <timothy_horton@apple.com>
975
976         Add Jake as a contributor.
977
978         * Scripts/webkitpy/common/config/contributors.json:
979
980 2014-09-29  Roger Fong  <roger_fong@apple.com>
981
982         [Windows] Skip a javascriptcore test following r174036.
983
984         * Scripts/run-javascriptcore-tests:
985
986 2014-09-29  Roger Fong  <roger_fong@apple.com>
987
988         [Windows] Reduce number of processes used by NRWT on Windows to 1.
989
990         * Scripts/webkitpy/port/win.py:
991         (WinPort.default_child_processes):
992         Reduce number of processes to 1 so we can get a good baseline for what failures
993         we should be expecting to see from the Windows bots.
994
995 2014-09-29  Darin Adler  <darin@apple.com>
996
997         Tweak and tighten SVG font converter
998         https://bugs.webkit.org/show_bug.cgi?id=136956
999
1000         Reviewed by Myles Maxfield.
1001
1002         I was investigating behavior of String::toInt, String::toDouble, and
1003         String::toFloat for various failure cases, and decided to start some
1004         unit tests for those functions here.
1005
1006         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1007         (TestWebKitAPI::TEST): Addded a first small bit of StringToInt and
1008         StringToDouble testing.
1009
1010 2014-09-29  Philippe Normand  <pnormand@igalia.com>
1011
1012         [GTK][CMake] TestWebCore target build sometimes fail
1013         https://bugs.webkit.org/show_bug.cgi?id=137207
1014
1015         Reviewed by Csaba Osztrogon.
1016
1017         * TestWebKitAPI/PlatformGTK.cmake: Make sure the forwarding
1018         headers are generated before the TestWebCore target is built.
1019
1020 2014-09-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1021
1022         [GTK] Remove IntPointGtk.cpp and IntRectGtk.cpp
1023         https://bugs.webkit.org/show_bug.cgi?id=137209
1024
1025         Reviewed by Philippe Normand.
1026
1027         * TestWebKitAPI/PlatformGTK.cmake: Remove unneeded IntRectGtk.cpp
1028         from the WebCore test sources.
1029
1030 2014-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
1031
1032         Allow webkit-patch upload to respect the --directory argument with git checkouts
1033         https://bugs.webkit.org/show_bug.cgi?id=137166
1034
1035         Reviewed by Darin Adler.
1036
1037         We simply hadn't plumbed it through.
1038
1039         * Scripts/webkitpy/common/checkout/scm/detection.py:
1040         (SCMDetector.detect_scm_system):
1041         * Scripts/webkitpy/common/checkout/scm/git.py:
1042         (Git.__init__):
1043         (Git.changed_files):
1044
1045 2014-09-26  Sam Weinig  <sam@webkit.org>
1046
1047         Replace OSObjectPtr with RetainPtr/adoptOS
1048         https://bugs.webkit.org/show_bug.cgi?id=137158
1049
1050         Reviewed by Dan Bernstein.
1051
1052         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1053         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: Removed.
1054         * TestWebKitAPI/Tests/WTF/darwin/RetainPtrOSObject.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp.
1055         Rename and change test to use RetainPtr. Remove now unneeded part testing WTF::retainOSObject/WTF::releaseOSObject.
1056
1057 2014-09-26  Filip Pizlo  <fpizlo@apple.com>
1058
1059         Disable function.arguments
1060         https://bugs.webkit.org/show_bug.cgi?id=137167
1061
1062         Rubber stamped by Geoffrey Garen
1063         
1064         Enable the feature by default during tests.
1065
1066         * Scripts/run-jsc-stress-tests:
1067
1068 2014-09-26  Beth Dakin  <bdakin@apple.com>
1069
1070         Many platform/mac-wk2/tiled-drawing/ tests fail when run on a retina device
1071         https://bugs.webkit.org/show_bug.cgi?id=137089
1072
1073         Reviewed by Tim Horton.
1074
1075         This is a little sneaky since updateWindowScaleForTest() should ensure that these 
1076         tests run at 1x, but that code does not seem to execute at the right time for 
1077         these tests, so if we just ensure we start out at 1x, that appears to fix these 
1078         tests and does not break the HiDPI tests either.
1079         * WebKitTestRunner/TestController.cpp:
1080         (WTR::TestController::createWebViewWithOptions):
1081
1082 2014-09-26  Roger Fong  <roger_fong@apple.com>
1083
1084         [Windows] Decrease default number of child processes used by Windows.
1085
1086         * Scripts/webkitpy/port/win.py:
1087         (WinPort.default_child_processes):
1088         Having too many seems to cause many tests to crash or timeout. 
1089         We may even need to make it have only 1 child process if we’re still seeing problems after this.
1090
1091 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
1092
1093         Mac EWS bots do not keep logs as promised
1094         https://bugs.webkit.org/show_bug.cgi?id=137151
1095
1096         Reviewed by Ryosuke Niwa.
1097
1098         * EWSTools/start-queue-mac.sh: Actually keep the logs for 14 days.
1099
1100 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
1101
1102         Get rid of webkit-queues dashboard
1103         https://bugs.webkit.org/show_bug.cgi?id=137141
1104
1105         Reviewed by Ryosuke Niwa.
1106
1107         * QueueStatusServer/app.yaml: Updated version.
1108
1109         * QueueStatusServer/templates/dashboard.html: Removed.
1110         * QueueStatusServer/handlers/dashboard.py: Removed.
1111         * QueueStatusServer/main.py:
1112         Kill it!
1113
1114         * QueueStatusServer/stylesheets/common.css: Copied from Tools/QueueStatusServer/stylesheets/dashboard.css.
1115         (.status-cell): Deleted.
1116         (.status-cell:hover): Deleted.
1117         (.status-cell.pass): Deleted.
1118         (.status-cell.fail): Deleted.
1119         (.status-cell.pending): Deleted.
1120         (.status-cell.error): Deleted.
1121         * QueueStatusServer/stylesheets/dashboard.css: Removed.
1122         * QueueStatusServer/templates/activebots.html:
1123         * QueueStatusServer/templates/patch.html:
1124         * QueueStatusServer/templates/queuestatus.html:
1125         * QueueStatusServer/templates/recentstatus.html:
1126         Renamed dashboard.css to common.css, and removed dashboard-only rules.
1127
1128 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
1129
1130         Get rid of Retry status in webkit-queues
1131         https://bugs.webkit.org/show_bug.cgi?id=137135
1132
1133         Reviewed by Ryosuke Niwa.
1134
1135         * QueueStatusServer/config/messages.py: Removed Retry.
1136
1137         * QueueStatusServer/handlers/releasepatch.py: This is now straightforward, as it
1138         no longer needs to check the latest status. It just always both unlocks the patch
1139         and removes it from WorkItems.
1140
1141         * QueueStatusServer/handlers/submittoews.py: (SubmitToEWS._should_add_to_ews_queue):
1142         I don't understand why we even needed to check for retries here, but now that there
1143         are no retries, that code can go to /dev/null.
1144
1145         * QueueStatusServer/loggers/recordpatchevent.py:
1146         (RecordPatchEvent.started):
1147         (RecordPatchEvent.retrying): Deleted.
1148         Fixed retry counting, it should work for all queues now.
1149
1150         * QueueStatusServer/model/queuestatus.py:
1151         (QueueStatus.is_retry_request): Deleted. These are no more.
1152
1153         * Scripts/webkitpy/common/net/statusserver_mock.py:
1154         (MockStatusServer.release_lock):
1155         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1156         Did whatever it took to keep passing the tests. The particular test doesn't seem
1157         quite right, but whatever.
1158
1159         * Scripts/webkitpy/tool/commands/queues.py:
1160         (CommitQueue.process_work_item): Instead of posting a retry status, just unlock
1161         and let others pick up. Also, added explicit returns for clarity.
1162         (AbstractPatchQueue._did_retry): Deleted.
1163
1164 2014-09-26  Csaba Osztrogonác  <ossy@webkit.org>
1165
1166         [EFL] Fix the gst-libav build on ARM Thumb2
1167         https://bugs.webkit.org/show_bug.cgi?id=137022
1168
1169         Reviewed by Zoltan Herczeg.
1170
1171         * efl/jhbuild.modules:
1172         * efl/patches/gst-libav.patch: Added.
1173
1174 2014-09-26  Akos Kiss  <akiss@inf.u-szeged.hu>
1175
1176         [EFL] Bump up dependencies not to conflict with the GTK port.
1177         https://bugs.webkit.org/show_bug.cgi?id=137143
1178
1179         Reviewed by Gyuyoung Kim.
1180
1181         Tools/efl/install-dependencies and Tools/gtk/install-dependencies keep
1182         installing and removing different versions of libgnutls-dev, thus
1183         hindering the development for both ports on the same machine. GTK is
1184         using the newer version of the package, now bumping up EFL to use the 
1185         same.
1186
1187         * efl/install-dependencies:
1188
1189 2014-09-25  Rohit Kumar  <kumar.rohit@samsung.com>
1190
1191         [EFL][WK2] Minibrowser : Fix the 'Escape' button issue to exit fullscreen
1192         https://bugs.webkit.org/show_bug.cgi?id=136854
1193
1194         Reviewed by Gyuyoung Kim.
1195
1196         'Escape' key should exit fullscreen first and then should be used to stop page load.
1197
1198         * MiniBrowser/efl/main.c:
1199         (on_key_down):
1200
1201 2014-09-25  Dean Jackson  <dino@apple.com>
1202
1203         Add Said to the contributors list so his name completes in bugzilla.
1204
1205         * Scripts/webkitpy/common/config/contributors.json:
1206
1207 2014-09-25  Alexey Proskuryakov  <ap@apple.com>
1208
1209         EWS only repeats its cycle every two hours
1210         https://bugs.webkit.org/show_bug.cgi?id=137129
1211
1212         Reviewed by Ryosuke Niwa.
1213
1214         * QueueStatusServer/app.yaml: Updated version.
1215
1216         * QueueStatusServer/config/queues.py: Moved timeout from activeworkitems.py to configuration.
1217
1218         * QueueStatusServer/handlers/releaselock.py: Added. Releases the lock without removing
1219         the patch from work items.
1220
1221         * QueueStatusServer/index.yaml: No real change, just let AppEngine have its way with entry order.
1222
1223         * QueueStatusServer/main.py: Added release-lock.
1224
1225         * QueueStatusServer/model/activeworkitems.py:
1226         (ActiveWorkItems.deactivate_expired): Use timeout from configuration.
1227
1228         * QueueStatusServer/model/workitems.py: Added move_to_end. When we unlock a patch,
1229         we don't want it to be immediately picked up again, it's better to give other patches
1230         a chance.
1231
1232         * QueueStatusServer/templates/releaselock.html: Added. Not sure why all commands have
1233         these interactive versions, but OK.
1234
1235         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: (AbstractEarlyWarningSystem.review_patch):
1236         Unlock the patch when a non-final failure occurs (e.g. can't build even without the patch,
1237         or svn is down).
1238
1239         * Scripts/webkitpy/tool/commands/queues.py:
1240         (AbstractReviewQueue.process_work_item): Do not try/catch ScriptError around review_patch.
1241         Style queue never raises these, and EWS already calls _did_fail, before re-throwing,
1242         meaning that these handlers could never do the right thing. We'd either get a duplicate
1243         _did_fail, or try to unlock an already unlocked patch.
1244         (StyleQueue.review_patch): Unlock the patch on transient failure (such as svn failure),
1245         making it eligible for retry immediately.
1246
1247         * Scripts/webkitpy/common/net/statusserver.py:
1248         (StatusServer._post_release_lock):
1249         (StatusServer.release_lock):
1250         Added a call to release-lock.
1251
1252 2014-09-25  Roger Fong  <roger_fong@apple.com>
1253
1254         [Windows] Followup to r173972. Don’t set child process to none before reading from stdout.
1255
1256         * Scripts/webkitpy/common/system/path.py:
1257         (_CygPath.convert):
1258
1259 2014-09-25  Roger Fong  <roger_fong@apple.com>
1260
1261         [Windows] Close stdin to force a flush to stdout if no test path is read during layout tests.
1262
1263         * Scripts/webkitpy/common/system/path.py:
1264         (_CygPath.convert):
1265
1266 2014-09-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1267
1268         [Gtk] build.sh needs a -- before make options when the build command is cmake --build
1269         https://bugs.webkit.org/show_bug.cgi?id=136377
1270
1271         Reviewed by Philippe Normand.
1272
1273         * Scripts/webkitdirs.pm:
1274         (buildCMakeGeneratedProject): Only use the build.sh script if it exists.
1275
1276 2014-09-25  Akos Kiss  <akiss@inf.u-szeged.hu>
1277
1278         [EFL] Split the list of dependencies to make sure that at least the universally available packages get installed
1279         https://bugs.webkit.org/show_bug.cgi?id=137117
1280
1281         Tools/efl/install-dependencies relies on apt-get to install packages.
1282         Unfortunately, if a package does not exist (e.g., for a given
1283         architecture) then apt-get install is not able to ignore the missing
1284         package and install the rest but fails to run entirely (and there
1285         seems to be no intent to change this behaviour).
1286
1287         On ARM64, the luajit package is missing and currently it needs manual
1288         editing of install-dependencies to get the script install as much as it
1289         can.
1290
1291         This patch separates the installation of the universally available
1292         packages from those which might not be available for all architectures.
1293
1294         Reviewed by Gyuyoung Kim.
1295
1296         * efl/install-dependencies:
1297
1298 2014-09-25  Csaba Osztrogonác  <ossy@webkit.org>
1299
1300         Remove WinCE port from trunk
1301         https://bugs.webkit.org/show_bug.cgi?id=136951
1302
1303         Reviewed by Alex Christensen.
1304
1305         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1306         (_should_file_trigger_build):
1307         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1308         (ShouldBuildTest):
1309         * CMakeLists.txt:
1310         * DumpRenderTree/win/DRTDataObject.cpp:
1311         (DRTDataObject::CopyMedium):
1312         * Scripts/build-webkit:
1313         * Scripts/webkit-build-directory:
1314         * Scripts/webkitdirs.pm:
1315         (argumentsForConfiguration):
1316         (builtDylibPathForName):
1317         (isAppleWinWebKit):
1318         (launcherPath):
1319         (launcherName):
1320         (shouldRemoveCMakeCache):
1321         (cmakeBasedPortArguments):
1322         (cmakeBasedPortName):
1323         (isCMakeBuild):
1324         (isWinCE): Deleted.
1325         (determineIsWinCE): Deleted.
1326         * Scripts/webkitperl/FeatureList.pm:
1327         * Scripts/webkitpy/port/port_testcase.py:
1328         (test_apache_config_file_name_for_platform):
1329         * TestWebKitAPI/config.h:
1330         * WinCELauncher/CMakeLists.txt: Removed.
1331         * WinCELauncher/main.cpp: Removed.
1332         * gtk/manifest.txt:
1333
1334 2014-09-23  David Farler  <dfarler@apple.com>
1335
1336         [iOS] run-webkit-tests should support minor versions under devices and create a testing device under the right runtime
1337         https://bugs.webkit.org/show_bug.cgi?id=136895
1338
1339         Reviewed by David Kilzer.
1340
1341         Create Device, DeviceType, and Runtime data classes.
1342         Create Simulator class represent simctl output.
1343
1344         Wherever possible, use structured data classes anywhere a raw
1345         identifier or UDID string was used for a cleaner implementation
1346         and to encapsulate the inherent fragility of scraping simctl output.
1347
1348         Create a suitably named testing device if one doesn't exist.
1349
1350         Finally, accurately handle having multiple simulator runtimes (SDKs)
1351         installed in the active Xcode.app bundle.
1352
1353         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1354         (_set_up_derived_options):
1355         * Scripts/webkitpy/port/driver.py:
1356         (IOSSimulatorDriver.cmd_line):
1357         Construct DeviceType and Runtime objects from identifiers passed at the
1358         command line, still providing sensible defaults for 32- and 64-bit testing.
1359         * Scripts/webkitpy/port/ios.py:
1360         (IOSSimulatorPort.__init__):
1361         (IOSSimulatorPort.setup_test_run):
1362         (IOSSimulatorPort):
1363         (IOSSimulatorPort.testing_device):
1364         Cache the testing device once it is created or found.
1365         (IOSSimulatorPort.reset_preferences):
1366         Get the device path from the Device object instead of consructing it
1367         in the port class.
1368         (IOSSimulatorPort.simulator_udid): Deleted.
1369         Get the UDID from the testing_device :: Device object itself.
1370         * Scripts/webkitpy/xcode/simulator.py:
1371         Created Device, DeviceType, Runtime, and Simulator classes.
1372         (get_runtimes): Deleted.
1373         (get_devices): Deleted.
1374         (get_device_types): Deleted.
1375         (get_latest_runtime): Deleted.
1376
1377 2014-09-24  Roger Fong  <roger_fong@apple.com>
1378
1379         [Windows] Tentative fix for Windows test bots.
1380
1381         * Scripts/webkitpy/common/system/path.py:
1382         (_CygPath.convert):
1383
1384 2014-09-24  Alexey Proskuryakov  <ap@apple.com>
1385
1386         Change more build.webkit.org links to https
1387         https://bugs.webkit.org/show_bug.cgi?id=137049
1388
1389         Reviewed by Csaba Osztrogonác.
1390
1391         Fix appspot, svn.webkit.org and Trac links.
1392
1393         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1394         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
1395         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1396         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
1397         (ViewController.prototype._domForBuildName):
1398         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1399         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1400         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1401         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1402         (.):
1403         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
1404         (EWS):
1405         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
1406         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:
1407         (TestHistory):
1408         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1409
1410 2014-09-24  Langó László  <llango.u-szeged@partner.samsung.com>
1411
1412         Update the list of u-szeged contributors.
1413
1414         Rubber-stamped by Csaba Osztrogonác <ossy@webkit.org>.
1415
1416         * Scripts/webkitpy/common/config/contributors.json:
1417
1418 2014-09-23  Roger Fong  <roger_fong@apple.com>
1419
1420         [Windows] More debugging for the Windows bots.
1421
1422         * Scripts/webkitpy/common/system/path.py:
1423         (_CygPath):
1424
1425 2014-09-23  Roger Fong  <roger_fong@apple.com>
1426
1427         Unreviewed. Fix for r173899, those tabs should be spaces.
1428
1429         * Scripts/webkitpy/port/driver.py:
1430         (Driver._command_from_driver_input):
1431         (Driver): Deleted.
1432
1433 2014-09-23  Roger Fong  <roger_fong@apple.com>
1434
1435         [Windows] Add some logging to debug a problem with the Windows bots that causes layout tests to exit early.
1436
1437         * Scripts/webkitpy/port/driver.py:
1438         (Driver):
1439
1440 2014-09-23  Jer Noble  <jer.noble@apple.com>
1441
1442         [Tools] git-commit uses wrong ChangeLog when run from a subdirectory
1443         https://bugs.webkit.org/show_bug.cgi?id=137031
1444
1445         Reviewed by Joseph Pecoraro.
1446
1447         commit-log-editor is run from the top of the Git checkout, even when git-commit is invoked
1448         from a subdirectory, making the parsed locations of ChangeLog files incorrect. Git provides
1449         a mapping prefix in the GIT_PREFIX environment variable, so apply this prefix to the parsed
1450         ChangeLog locations before passing them to createCommitMessage().
1451
1452         * Scripts/commit-log-editor:
1453
1454 2014-09-23  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1455
1456         W3C test importer should detect manual and reference tests according their filenames
1457         https://bugs.webkit.org/show_bug.cgi?id=133852
1458
1459         Reviewed by Bem Jones-Bey.
1460
1461         * Scripts/webkitpy/w3c/test_parser.py:
1462         (TestParser.analyze_test): Adding checks based on WPT filename rules.
1463         (TestParser.is_wpt_manualtest): Detecting whether the test is a manual test based on its filename.
1464         (TestParser):
1465         (TestParser.potential_ref_filename): Getting the potential reference filename of a test from its filename.
1466         (TestParser.is_wpt_reftest): Detecting whether the test is a ref test based on its filename.
1467         * Scripts/webkitpy/w3c/test_parser_unittest.py:
1468         (test_analyze_manual_wpt_test): Adding a test for a "-manual.html" file with testharness.js link in it. 
1469
1470 2014-09-23  Bem Jones-Bey  <bjonesbe@adobe.com>
1471
1472         Unreviewed, add Rebecca Hauck as a contributor.
1473
1474         * Scripts/webkitpy/common/config/contributors.json:
1475
1476 2014-09-23  David Kilzer  <ddkilzer@apple.com>
1477
1478         Switch build.webkit.org URLs to https
1479
1480         Reviewed by Lucas Forschler and Alexey Proskuryakov.
1481
1482         * TestResultServer/app.yaml: Update version to this commit
1483         revision.
1484
1485         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1486         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1487         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1488         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js:
1489         (WebKitBuildbot):
1490         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
1491         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1492         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
1493         (.):
1494         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1495         (WebKitBuildbot):
1496         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1497         * Scripts/webkitpy/common/config/urls.py:
1498         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1499         (test_builder_with_name):
1500         * Scripts/webkitpy/tool/commands/queries.py:
1501         (TreeStatus):
1502         * TestResultServer/generate_builders_json.py:
1503         (main):
1504         * TestResultServer/generate_builders_json_unittest.py:
1505         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
1506         (GenerateBuildersJsonTest):
1507         (GenerateBuildersJsonTest.test_generate_json_data):
1508         * TestResultServer/static-dashboards/builders.jsonp:
1509         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1510         (loadExpectationsLayoutTests):
1511         * TestResultServer/static-dashboards/timeline_explorer.js:
1512
1513 2014-09-23  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1514
1515         W3C test importer should copy .htaccess files
1516         https://bugs.webkit.org/show_bug.cgi?id=136850
1517
1518         Reviewed by Bem Jones-Bey.
1519
1520         * Scripts/webkitpy/w3c/test_importer.py:
1521         (TestImporter.should_skip_file): Helper function to check whether to skip file or not. Added ".htaccess" file specific check.
1522         (TestImporter):
1523         (TestImporter.find_importable_tests): Making use of new helper function.
1524
1525 2014-09-23  Alexey Proskuryakov  <ap@apple.com>
1526
1527         Trying to revive bot watcher's dashboard after HSTS.
1528
1529         Unreviewed.
1530
1531         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1532         (WebKitBuildbot): It looks like XMLHttpRequest may not like HSTS redirects, let's try to avoid these.
1533
1534 2014-09-23  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1535
1536         Make Tools/BuildSlaveSupport/wait-for-SVN-server.py handle server donwtime
1537         https://bugs.webkit.org/show_bug.cgi?id=137026
1538
1539         Reviewed by Csaba Osztrogonác.
1540
1541         * BuildSlaveSupport/wait-for-SVN-server.py:
1542         (getLatestSVNRevision):
1543         (waitForSVNRevision):
1544
1545 2014-09-23  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1546
1547         Remove unlinkZeroFiles from build-webkit
1548         https://bugs.webkit.org/show_bug.cgi?id=137018
1549
1550         Reviewed by Csaba Osztrogonác.
1551
1552         * Scripts/build-webkit:
1553         (unlinkZeroFiles): Deleted.
1554
1555 2014-09-23  Rohit Kumar  <kumar.rohit@samsung.com>
1556
1557         [GTK] Minibrowser : Add keyboard support for stop page load
1558         https://bugs.webkit.org/show_bug.cgi?id=136857
1559
1560         Reviewed by Philippe Normand.
1561
1562         Keyboard support to stop page load in GTK Minibrowser using F6 and Escape keys.
1563
1564         * MiniBrowser/gtk/BrowserWindow.c:
1565         (stopPageLoad): Callback to stop page load.
1566         (browser_window_init):
1567
1568 2014-09-22  Rohit Kumar  <kumar.rohit@samsung.com>
1569
1570         [EFL][WK2] Minibrowser : Add keyboard support for page reload while ignoring cache
1571         https://bugs.webkit.org/show_bug.cgi?id=136813
1572
1573         Reviewed by Gyuyoung Kim.
1574
1575         Ctrl+r is used for page reload along with F5. Ctrl+Shift+r and Ctrl+F5 is used for page reload while ignoring cache.
1576
1577         * MiniBrowser/efl/main.c:
1578         (on_key_down):
1579
1580 2014-09-22  Daniel Bates  <dabates@apple.com>
1581
1582         [Cocoa] Add UI delegate callback when window.close() is called
1583         https://bugs.webkit.org/show_bug.cgi?id=137008
1584         <rdar://problem/17801001>
1585
1586         Reviewed by Anders Carlsson.
1587
1588         Add a test to ensure that -[WKUIDelegatePrivate _webViewClose:] is called on window.close()
1589         for window opened via JavaScript (i.e. window.open()).
1590
1591         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1592         * TestWebKitAPI/Tests/WebKit2/open-and-close-window.html: Added.
1593         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm: Added.
1594
1595 2014-09-22  Youenn Fablet  <youennf@gmail.com>
1596
1597         W3C importer should import html files within resources folders
1598         https://bugs.webkit.org/show_bug.cgi?id=127548
1599
1600         Reviewed by Ryosuke Niwa.
1601         
1602         Import HTML files in any folder named "resources" even if file is not detected as a HTML test file 
1603
1604         * Scripts/webkitpy/w3c/test_importer.py:
1605         (TestImporter.find_importable_tests):
1606
1607 2014-09-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1608
1609         [GTK] Test /webkit2/WebKitWebView/can-show-mime-type fails if evince browser plugin is installed
1610         https://bugs.webkit.org/show_bug.cgi?id=136998
1611
1612         Reviewed by Philippe Normand.
1613
1614         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1615         (testWebViewCanShowMIMEType): Remove the check of PDF as
1616         unsupported MIME type.
1617
1618 2014-09-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1619
1620         Unreviewed. Fix WebKitGTKTranslations rule in watchlist.
1621
1622         In r145081 GTK+ translations were moved from Source/WebKit/gtk/po/
1623         to Source/WebCore/platform/gtk/po/ but the rule was not updated.
1624
1625         * Scripts/webkitpy/common/config/watchlist: Use
1626         Source/WebCore/platform/gtk/po/ as directory to watch for
1627         WebKitGTKTranslations rule and add berto and myself to the list of
1628         watchers.
1629
1630 2014-09-22  Ryuan Choi  <ryuan.choi@gmail.com>
1631
1632         Fix syntaxError in watchlist since r173594
1633         https://bugs.webkit.org/show_bug.cgi?id=136996
1634
1635         Reviewed by Philippe Normand.
1636
1637         * Scripts/webkitpy/common/config/watchlist: Removed unnecessary comma.
1638
1639 2014-09-20  Sam Weinig  <sam@webkit.org>
1640
1641         Make possible HashSet<std::unique_ptr<>>
1642         https://bugs.webkit.org/show_bug.cgi?id=136166
1643
1644         Reviewed by Darin Adler.
1645
1646         * TestWebKitAPI/Tests/WTF/CopyMoveCounter.h: Removed.
1647         * TestWebKitAPI/Counters.cpp: Added.
1648         * TestWebKitAPI/Counters.h: Copied from Tools/TestWebKitAPI/Tests/WTF/CopyMoveCounter.h.
1649         Move the CopyMoveCounter helper from CopyMoveCounter.h to Counters.h, and add a ConstructorDestructorCounter
1650         helper to the mix as well. Add Counters.cpp to allow for the global variables to be used in more than one
1651         translation unit.
1652     
1653         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1654         Add new files.
1655
1656         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1657         Add tests for using std::unique_ptr and OwnPtr as the key's of a HashMap.
1658
1659         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1660         Add tests for using std::unique_ptr and OwnPtr as the values of a HashSet.
1661
1662 2014-09-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1663
1664         run-webkit-tests should count tests submitted as absolute paths once
1665         https://bugs.webkit.org/show_bug.cgi?id=136848
1666
1667         Reviewed by Darin Adler.
1668
1669         * Scripts/webkitpy/port/base.py:
1670         (Port._expanded_paths): In case of absolute path, do not search for platform specific tests.
1671
1672 2014-09-19  Joseph Pecoraro  <pecoraro@apple.com>
1673
1674         JSStringRef leak on the leaks bot allocation under selectTextWithCriteriaCallback
1675         https://bugs.webkit.org/show_bug.cgi?id=136974
1676
1677         Reviewed by Chris Fleizach.
1678
1679         * DumpRenderTree/AccessibilityUIElement.cpp:
1680         (selectTextWithCriteriaCallback):
1681         Be sure to release the string if it was allocated.
1682
1683 2014-09-19  Alexey Proskuryakov  <ap@apple.com>
1684
1685         build.webkit.org/dashboard: Pending builds don't show up when there is a commit with no comments
1686         https://bugs.webkit.org/show_bug.cgi?id=136966
1687
1688         Reviewed by Daniel Bates.
1689
1690         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1691         (Trac.prototype._convertCommitInfoElementToObject): Tolerate these horrible commits.
1692
1693 2014-09-19  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1694
1695         [CoordinatedGraphics][EFL] window.scrollTo(x, y) doesn't work when fixed layout is enabled
1696         https://bugs.webkit.org/show_bug.cgi?id=136917
1697
1698         Reviewed by Darin Adler.
1699
1700         Added WKViewScrollTo.cpp and scrollTo.html to test this issue.
1701
1702         * TestWebKitAPI/PlatformEfl.cmake:
1703         * TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Added.
1704         (TestWebKitAPI::didFinishLoadForFrame):
1705         (TestWebKitAPI::TEST):
1706         * TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Added.
1707
1708 2014-09-19  Daniel Bates  <dabates@apple.com>
1709
1710         Always assume internal SDK when building configuration Production
1711         https://bugs.webkit.org/show_bug.cgi?id=136925
1712         <rdar://problem/18362399>
1713
1714         Reviewed by Dan Bernstein.
1715
1716         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1717         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1718         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1719         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1720
1721 2014-09-19  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1722
1723         WTR and DRT didReceiveAuthenticationChallengeInFrame should print messages consistently
1724         https://bugs.webkit.org/show_bug.cgi?id=136847
1725
1726         Added protection space host and port logging to WTR didReceiveAuthenticationChallengeInFrame.
1727
1728         Reviewed by Alexey Proskuryakov.
1729
1730         * WebKitTestRunner/TestController.cpp:
1731         (WTR::TestController::didReceiveAuthenticationChallengeInFrame):
1732
1733 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1734
1735         [GTK] Missing inspector files in the tarball
1736         https://bugs.webkit.org/show_bug.cgi?id=136952
1737
1738         Reviewed by Gustavo Noronha Silva.
1739
1740         * gtk/manifest.txt: Add
1741         Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
1742         to the tarball.
1743
1744 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1745
1746         Webkitgtk 2.5.3: tarball contains APPLE LICENSE file - stating not distributable
1747         https://bugs.webkit.org/show_bug.cgi?id=136632
1748
1749         Reviewed by Gustavo Noronha Silva.
1750
1751         * gtk/generate-inspector-gresource-manifest.py: Use an alias for
1752         the gtk icons.
1753         * gtk/manifest.txt: Only include the free icons in the tarball.
1754
1755 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1756
1757         [GTK] generate-inspector-gresource-manifest.py should receive the list of files from the makefile
1758         https://bugs.webkit.org/show_bug.cgi?id=136943
1759
1760         Reviewed by Philippe Normand.
1761
1762         Update the script to receive the list of files from the command
1763         line instead of scanning the given directories.
1764
1765         * gtk/generate-inspector-gresource-manifest.py:
1766         (get_filenames): Convert filenames to use relative paths.
1767         (find_all_files_in_directory): Deleted.
1768         (find_all_files_in_directory.select_file): Deleted.
1769
1770 2014-09-18  Tanay C  <tanay.c@samsung.com>
1771
1772         [EFL][WK2] Minibrowser : Support Zoom on Control key + scroll
1773         https://bugs.webkit.org/show_bug.cgi?id=136739
1774
1775         Reviewed by Gyuyoung Kim.
1776
1777         * MiniBrowser/efl/main.c: Add support for zoom on control key + mouse scroll
1778         (on_mouse_wheel): Modified.
1779
1780 2014-09-18  Carlos Garcia Campos  <cgarcia@igalia.com>
1781
1782         [GTK] Dot not allow to create delete-on-destroy GMainLoopSources
1783         https://bugs.webkit.org/show_bug.cgi?id=136923
1784
1785         Reviewed by Gustavo Noronha Silva.
1786
1787         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
1788         (TestWebKitAPI::TEST): Use the new API that doesn't allow to use
1789         the source.
1790
1791 2014-09-18  Csaba Osztrogonác  <ossy@webkit.org>
1792
1793         Fix countFailures of RunLLINTCLoopTests and Run32bitJSCTests (II)
1794         https://bugs.webkit.org/show_bug.cgi?id=136856
1795
1796         Reviewed by Darin Adler.
1797
1798         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1799         (RunLLINTCLoopTests.countFailures):
1800         (Run32bitJSCTests.countFailures):
1801         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1802         (RunLLINTCLoopTestsTest.test_failures):
1803         (RunLLINTCLoopTestsTest.test_failure):
1804         (RunLLINTCLoopTestsTest.test_no_failure):
1805         (Run32bitJSCTestsTest.test_failures):
1806         (Run32bitJSCTestsTest.test_failure):
1807         (Run32bitJSCTestsTest.test_no_failure):
1808
1809 2014-09-18  Zan Dobersek  <zdobersek@igalia.com>
1810
1811         GMainLoopSource is exposed to race conditions
1812         https://bugs.webkit.org/show_bug.cgi?id=135800
1813
1814         Reviewed by Carlos Garcia Campos.
1815
1816         Add unit tests for GMainLoopSource.
1817
1818         The tests check correct behavior of GMainLoopSource in various conditions --
1819         from the most simple rescheduling to rescheduling during dispatch, cancelling
1820         or destroying the GMainLoopSource during dispatch, proper destroy callback
1821         dispatching etc.
1822
1823         Scheduling both void (one-time) and bool (repeatable) callbacks is tested.
1824         State of the GMainLoopSource object (either ready, sheduled or active) is
1825         thoroughly tested throughout the lifetime of that object.
1826
1827         Still missing are tests for socket callbacks, which are a bit trickier because
1828         they rely on a GSocket object. The delete-on-destroy GMainLoopSource objects
1829         are also not tested thoroughly, simply because it is at the moment impossible
1830         to test that the objects are actually destroyed when the corresponding source
1831         is finally deleted.
1832
1833         * TestWebKitAPI/PlatformGTK.cmake:
1834         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp: Added.
1835         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
1836         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
1837         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
1838         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish):
1839         (TestWebKitAPI::GMainLoopSourceTest::finish):
1840         (TestWebKitAPI::GMainLoopSourceTest::source):
1841         (TestWebKitAPI::TEST):
1842
1843 2014-09-17  Ryuan Choi  <ryuan.choi@gmail.com>
1844
1845         Unreviewed, Update my email in contributors.json
1846
1847         * Scripts/webkitpy/common/config/contributors.json:
1848
1849 2014-09-17  Daniel Bates  <dabates@apple.com>
1850
1851         Unreviewed, rolling out r173695.
1852
1853         Broke building third-party Legacy WebKit apps; will
1854         investigate offline
1855
1856         Reverted changeset:
1857
1858         "[iOS] Make WebCore build with public iOS SDK"
1859         https://bugs.webkit.org/show_bug.cgi?id=136487
1860         http://trac.webkit.org/changeset/173695
1861
1862 2014-09-17  Daniel Bates  <dabates@apple.com>
1863
1864         [iOS] Make WebCore build with public iOS SDK
1865         https://bugs.webkit.org/show_bug.cgi?id=136487
1866
1867         Reviewed by David Kilzer.
1868
1869         Substitute <WebCore/MachVMSPI.h> for <mach/mach_vm.h>.
1870
1871         * DumpRenderTree/mac/CheckedMalloc.cpp:
1872
1873 2014-09-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1874
1875         [GTK] WebKitWebView::load-failed-with-tls-errors should receive the failing URI instead of a host
1876         https://bugs.webkit.org/show_bug.cgi?id=136889
1877
1878         Reviewed by Gustavo Noronha Silva.
1879
1880         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1881         (testLoadFailedWithTLSErrors): Check that LoadFailedWithTLSErrors
1882         event was added to the events vector.
1883         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1884         (loadFailedCallback): Do not assume the web view URI is the
1885         failing URI when the load fails before the committed state.
1886         (loadFailedWithTLSErrorsCallback): Handle the case of load failure
1887         because of TLS errors can call LoadTrackingTest::loadFailedWithTLSErrors.
1888         (LoadTrackingTest::LoadTrackingTest): Connect to WebKitWebView::load-failed-with-tls-errors.
1889         (LoadTrackingTest::loadFailedWithTLSErrors): Add
1890         LoadFailedWithTLSErrors event to the events vector.
1891         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
1892
1893 2014-09-17  Renato Nagy  <rnagy@inf.u-szeged.hu>
1894
1895         [EFL][GTK] Remove WebKit1 related codes
1896         https://bugs.webkit.org/show_bug.cgi?id=136853
1897
1898         Reviewed by Csaba Osztrogonác.
1899
1900         Gtk and EFL WebKit1 ports no longer exist. Webkit1 related codes were deleted
1901         from scripts.
1902
1903         * BuildSlaveSupport/build.webkit.org-config/config.json:
1904         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1905         (Compile32bitJSC):
1906         (BuildAndTestWebKit2Factory):
1907         (CompileWebKit1Only): Deleted.
1908         (CompileWebKit2Only): Deleted.
1909         (BuildAndTestWebKit1OnlyFactory): Deleted.
1910         (BuildAndTestWebKit2OnlyFactory): Deleted.
1911         * Scripts/build-webkit:
1912         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
1913         * Scripts/webkitpy/common/config/ports.py:
1914         (GtkWK2Port.build_webkit_command):
1915         (EflWK2Port.build_webkit_command):
1916         * Scripts/webkitpy/common/config/ports_unittest.py:
1917         (DeprecatedPortTest.test_gtk_wk2_port):
1918         * Scripts/webkitpy/port/efl.py:
1919         (EflPort.build_webkit_command):
1920         * Scripts/webkitpy/port/gtk.py:
1921         (GtkPort._built_libraries_path):
1922         (GtkPort._search_paths):
1923         (GtkPort.test_expectations_file_position):
1924         (GtkPort.build_webkit_command):
1925         (GtkPort.run_webkit_tests_command):
1926         (GtkPort.warn_if_bug_missing_in_test_expectations): Deleted.
1927
1928 2014-09-16  Daniel Bates  <dabates@apple.com>
1929
1930         [iOS] Add iOS SDK name and version suffix to WebKitSystemInterface debug/release product name
1931         https://bugs.webkit.org/show_bug.cgi?id=136862
1932
1933         Reviewed by David Kilzer.
1934
1935         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1936         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1937         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Remove hardcoded iOS 8.0
1938         IPHONEOS_DEPLOYMENT_TARGET to ensure we link against the latest version of WebKitSystemInterface.
1939
1940 2014-09-12  Ryosuke Niwa  <rniwa@webkit.org>
1941
1942         Mac queue slaves should reboot every so often
1943         https://bugs.webkit.org/show_bug.cgi?id=136791
1944
1945         Reviewed by Alexey Proskuryakov.
1946
1947         Reboot Mac queue slaves every night between 1 A.M. and 6 A.M.
1948
1949         * EWSTools/start-queue-mac.sh:
1950
1951 2014-09-16  Csaba Osztrogonác  <ossy@webkit.org>
1952
1953         Unreviewed gardening, skip one more tests on Windows.
1954
1955         * Scripts/run-javascriptcore-tests:
1956
1957 2014-09-16  Csaba Osztrogonác  <ossy@webkit.org>
1958
1959         JSC test gardening
1960         https://bugs.webkit.org/show_bug.cgi?id=136823
1961
1962         Reviewed by Geoffrey Garen.
1963
1964         * Scripts/run-javascriptcore-tests: Skip tests on only the affected platforms.
1965
1966 2014-09-16  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1967
1968         Remove shouldAbortEarly cruft from master.cfg
1969         https://bugs.webkit.org/show_bug.cgi?id=136779
1970
1971         Reviewed by Csaba Osztrogonác.
1972
1973         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1974         (ConfigureBuild.start):
1975         (RunWebKitTests.start):
1976         (RunWebKit2Tests.start): Deleted.
1977
1978 2014-09-15  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1979
1980         Remove ORWT related crufts from webkitdirs.pm
1981         https://bugs.webkit.org/show_bug.cgi?id=136821
1982
1983         Reviewed by Alexey Proskuryakov.
1984
1985         * Scripts/webkitdirs.pm:
1986         (isPerianInstalled): Deleted.
1987         (determineIPhoneSimulatorVersion): Deleted.
1988         (iPhoneSimulatorVersion): Deleted.
1989         (isSnowLeopard): Deleted.
1990         (isLion): Deleted.
1991         (quitIOSSimulator): Deleted.
1992
1993 2014-09-15  Roger Fong  <roger_fong@apple.com>
1994
1995         Unreviewed. Skip yet another ecma/Date test that fails only on Windows.
1996         https://bugs.webkit.org/show_bug.cgi?id=25160
1997
1998         * Scripts/run-javascriptcore-tests:
1999
2000 2014-09-15  Lucas Forschler  <lforschler@apple.com>
2001
2002         Add another Apple build slave to the Mountain Lion Debug WK1 queue
2003         
2004         Rubber stamped by Matt Hanson.
2005         
2006         * BuildSlaveSupport/build.webkit.org-config/config.json:
2007
2008 2014-09-15  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
2009
2010         [EFL] Ecore and Eina are initialized twice in TestWebKitAPI
2011         https://bugs.webkit.org/show_bug.cgi?id=136822
2012
2013         Reviewed by Gyuyoung Kim.
2014
2015         In TestWebKitAPI/efl/main.cpp, ecore and eina modules are unnecessarily
2016         initialized as we already does it in PlatformWebView::PlatformWebView
2017         calling ewk_init(). The reason for that was to ensure testing for example,
2018         WTF where creating the view is not mandatory.
2019
2020         Call ewk_init() and ewk_shutdown() in TestWebKitAPI/efl/main.cpp
2021         in order to properly initalize and release EWebKit.
2022
2023         * TestWebKitAPI/PlatformEfl.cmake:
2024         * TestWebKitAPI/efl/PlatformWebView.cpp:
2025         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2026         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2027         * TestWebKitAPI/efl/main.cpp:
2028         (main):
2029
2030 2014-09-15  peavo@outlook.com  <peavo@outlook.com>
2031
2032         [WinCairo] Make it easier to enable/disable GStreamer.
2033         https://bugs.webkit.org/show_bug.cgi?id=135766
2034
2035         Reviewed by Brent Fulgham.
2036
2037         Make it possible to enable/disable GStreamer by editing the new user macro ENABLE_GSTREAMER_WINCAIRO.
2038
2039         * WinLauncher/WinMain.cpp: Compile fix when GStreamer is enabled.
2040
2041 2014-09-12  Brian J. Burg  <burg@cs.washington.edu>
2042
2043         Web Inspector: remind about rebaselining generator test results
2044         https://bugs.webkit.org/show_bug.cgi?id=136759
2045
2046         Reviewed by Joseph Pecoraro.
2047
2048         For now, we can implement this as a watchlist message. Add watchlist
2049         groups and messages for the inspector and web replay generators.
2050
2051         * Scripts/webkitpy/common/config/watchlist:
2052
2053 2014-09-12  Alexey Proskuryakov  <ap@apple.com>
2054
2055         build.webkit.org/dashboard: Overlapping text when status is long
2056         https://bugs.webkit.org/show_bug.cgi?id=136794
2057
2058         Reviewed by Timothy Hatcher.
2059
2060         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2061         (.status-line): Replaces height with min-height.
2062
2063 2014-09-12  Timothy Hatcher  <timothy@apple.com>
2064
2065         Make Brian Burg a WebKit reviewer.
2066
2067         * Scripts/webkitpy/common/config/contributors.json: Move Brian Burg's entry.
2068
2069 2014-09-12  Alexey Proskuryakov  <ap@apple.com>
2070
2071         Multiple EWS or commit bots can pick up processing of the same patch
2072         https://bugs.webkit.org/show_bug.cgi?id=136793
2073
2074         Reviewed by Ryosuke Niwa.
2075
2076         Change timeout from one hour to two hours. This will let bots finish, and in the
2077         unlikely event of a bot being frozen, will only delay patch processing restart by
2078         one hour.
2079
2080         * QueueStatusServer/app.yaml:
2081         * QueueStatusServer/model/activeworkitems.py: (ActiveWorkItems.deactivate_expired):
2082
2083 2014-09-11  Andy Estes  <aestes@apple.com>
2084
2085         [WebKit2] WKImageCreateCGImage crashes when passed a null WKImage
2086         https://bugs.webkit.org/show_bug.cgi?id=136768
2087
2088         Reviewed by Tim Horton.
2089
2090         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2091         * TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp: Added.
2092         (TestWebKitAPI::TEST):
2093
2094 2014-09-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2095
2096         REGRESSION(r173423): CertificateInfo is never sent to the UI process when using shared secondary process model
2097         https://bugs.webkit.org/show_bug.cgi?id=136669
2098
2099         Reviewed by Antti Koivisto.
2100
2101         * Scripts/run-gtk-tests:
2102         (TestRunner): Unskip SSL test.
2103
2104 2014-09-12  Eric Carlson  <eric.carlson@apple.com>
2105
2106         Strip extraneous AVFoundation and CoreMedia logging
2107         https://bugs.webkit.org/show_bug.cgi?id=136747
2108
2109         Reviewed by Jer Noble.
2110
2111         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2112         (SingleTestRunner._run_compare_test): Allow the port to specify patterns to strip from stderr.
2113
2114         * Scripts/webkitpy/port/base.py:
2115         (Port.stderr_patterns_to_strip): Base class, empty list
2116
2117         * Scripts/webkitpy/port/driver.py:
2118         (DriverOutput.strip_stderror_patterns): Strip the specified patterns from stderr.
2119
2120         * Scripts/webkitpy/port/ios.py:
2121         (IOSSimulatorPort.stderr_patterns_to_strip): iOS patterns - there are none.
2122
2123         * Scripts/webkitpy/port/mac.py:
2124         (MacPort.stderr_patterns_to_strip): CoreMedia and AVFoundation logging we can ignore.
2125
2126
2127 2014-09-11  Michael Saboff  <msaboff@apple.com>
2128
2129         lldb_webkit.py:btjs doesn't work with release builds
2130         https://bugs.webkit.org/show_bug.cgi?id=136760
2131
2132         Reviewed by Jer Noble.
2133
2134         If we can't get a result calling JSC::ExecState::describeFrame(), try calling the
2135         mangled name _ZN3JSC9ExecState13describeFrameEv.  Also cleaned up the handling if
2136         we can't get a valid result from trying either call.  In that case, we fallback to
2137         just showing the PC.  Also added check for both entry points.  If neither is found,
2138         we issue a warning and output the stack trace without JavaScript annotations.
2139
2140         * lldb/lldb_webkit.py:
2141         (btjs):
2142
2143 2014-09-11  Rebecca Hauck  <rhauck@adobe.com>
2144
2145         webkitpy test failures from import-w3c-tests
2146         https://bugs.webkit.org/show_bug.cgi?id=136752
2147
2148         Reviewed by Bem Jones-Bey.
2149
2150         This patch fixes a bug in import-w3c-tests where we were appending
2151         the wrong set of files to the copy_list. This also updates the tests
2152         to clear the failures introduced in the patch for bug 135929.
2153
2154         * Scripts/webkitpy/w3c/test_converter_unittest.py:
2155         (W3CTestConverterTest.test_read_prefixed_property_list):
2156         * Scripts/webkitpy/w3c/test_parser.py:
2157         (TestParser.analyze_test):
2158         (TestParser.support_files):
2159         * Scripts/webkitpy/w3c/test_parser_unittest.py:
2160
2161 2014-09-10  Brent Fulgham  <bfulgham@apple.com>
2162
2163         Blink merge: Speculative fix for windows run-webkit-tests hangs
2164         https://bugs.webkit.org/show_bug.cgi?id=136727
2165
2166         Reviewed by Csaba Osztrogonác.
2167
2168         Merged from Blink (patch by Dirk Pranke):
2169         <https://chromium.googlesource.com/chromium/blink/+/0cdd98d44a20c3951562ccf8b08b1fefba8dac67%5E%21/#F0>
2170
2171         * Scripts/webkitpy/common/system/executive.py:
2172         (Executive.kill_process):
2173
2174 2014-09-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2175
2176         Added myself as a committer.
2177
2178         Unreviewed.
2179
2180         * Scripts/webkitpy/common/config/contributors.json:
2181
2182 2014-09-11  László Langó  <llango.u-szeged@partner.samsung.com>
2183
2184         [JavaScriptCore] Fix FTL on platform EFL.
2185         https://bugs.webkit.org/show_bug.cgi?id=133571
2186
2187         Reviewed by Filip Pizlo.
2188
2189         * efl/install-dependencies: Revert r169181.
2190         * efl/jhbuild.modules: Clone and build a custom branch.
2191         This branch contains some fix for FTL of platform EFL.
2192         The branch is a fork of llvm r206311.
2193
2194 2014-09-10  Tanay C  <tanay.c@samsung.com>
2195
2196         [EFL][WK2] Minibrowser : Shift+Scroll navigate to back or forward url's
2197         https://bugs.webkit.org/show_bug.cgi?id=136698
2198
2199         Reviewed by Gyuyoung Kim.
2200
2201         * MiniBrowser/efl/main.c: Add functionality to support shift + mouse scroll navigation
2202         (on_mouse_wheel): Added.
2203         (window_free):
2204         (window_create):
2205
2206 2014-09-10  Rohit Kumar  <kumar.rohit@samsung.com>
2207
2208         [EFL][WK2] Minibrowser : Add tooltip for toolbar buttons in Minibrowser
2209         https://bugs.webkit.org/show_bug.cgi?id=136284
2210
2211         Reviewed by Gyuyoung Kim.
2212
2213         * MiniBrowser/efl/main.c:
2214         (window_create):
2215
2216 2014-09-10  Rebecca Hauck  <rhauck@adobe.com>
2217
2218         import-w3c-tests doesn't handle relative paths to support files in ref files correctly
2219         https://bugs.webkit.org/show_bug.cgi?id=135929
2220
2221         Reviewed by Bem Jones-Bey.
2222
2223         The recent refactor of the W3C test repo falsified a bunch of assmumptions that
2224         were made when this script was originally written with respect to relative paths
2225         in ref files. This patch updates import-w3c-tests to update paths in ref files if
2226         they move relative to the test file.
2227
2228
2229         * Scripts/webkitpy/w3c/test_converter.py:
2230         (convert_for_webkit):
2231         (_W3CTestConverter.__init__):
2232         (_W3CTestConverter.convert_reference_relpaths):
2233         (_W3CTestConverter.convert_style_data):
2234         (_W3CTestConverter.convert_attributes_if_needed):
2235         * Scripts/webkitpy/w3c/test_importer.py:
2236         (TestImporter.find_importable_tests):
2237         (TestImporter.import_tests):
2238         * Scripts/webkitpy/w3c/test_parser.py:
2239         (TestParser.load_file):
2240         (TestParser.analyze_test):
2241         (TestParser.support_files):
2242
2243 2014-09-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2244
2245         [GTK] allow overwriting destination of download
2246         https://bugs.webkit.org/show_bug.cgi?id=136372
2247
2248         Reviewed by Carlos Garcia Campos.
2249
2250         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2251         (downloadLocalFileSuccessfully): Split from testDownloadLocalFile
2252         (testDownloadLocalFile): Split off downloadLocalFileSuccessfully
2253         (createFileAtDestination): Added
2254         (testDownloadOverwriteDestinationAllowed): Added
2255         (testDownloadOverwriteDestinationDisallowed): Added
2256         (testDownloadLocalFileError): Use new DownloadErrorTest::ExpectedError
2257         (testDownloadRemoteFileError): Use new DownloadErrorTest::ExpectedError
2258         (beforeAll): New tests
2259
2260 2014-08-05  David Farler  <dfarler@apple.com>
2261
2262         iOS Simulator: run-webkit-tests chokes on unterminated UTF-8 when writing a test result
2263         https://bugs.webkit.org/show_bug.cgi?id=135551
2264
2265         Reviewed by Daniel Bates.
2266
2267         Prevent printing invalid Unicode strings going to stderr.
2268         Also, make filesystem.py more tolerant about receiving
2269         Unicode (encoded as UTF-8) when writing to files, in the
2270         rare case that an NSError description will make it to
2271         stderr, such as -[LTRelayController createUniqueApp].
2272
2273         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2274         (-[LTRelayController launchSimulator]): Removed.
2275         (-[LTRelayController createUniqueApp]):
2276         Don't explicitly try to uninstall the app. It is automatically handled
2277         when installing an app with the same bundle identifier.
2278         (-[LTRelayController start]):
2279         (-[LTRelayController bootDevice]): Removed.
2280         The device already boots as a part of starting the simulator. Attempting
2281         to boot a second time may cause spurious stderr output.
2282         * Scripts/webkitpy/port/driver.py:
2283         (IOSSimulatorDriver._setup_environ_for_driver):
2284         Explicitly set DEVELOPER_DIR once so xcode-select isn't called.
2285         Open the iOS Simulator once instead of the LayoutTestRelay trying
2286         to do it.
2287         * Scripts/webkitpy/port/ios.py:
2288         (IOSSimulatorPort._get_crash_log):
2289         Make sure stderr is at least an empty string.
2290         (IOSSimulatorPort):
2291         (IOSSimulatorPort.developer_dir):
2292         New property for setting up DEVELOPER_DIR in the driver environment.
2293
2294 2014-09-09  Dan Bernstein  <mitz@apple.com>
2295
2296         Clean up the MiniBrowser Xcode project
2297         https://bugs.webkit.org/show_bug.cgi?id=136684
2298
2299         Reviewed by Tim Horton.
2300
2301         * MiniBrowser/Configurations/Base.xcconfig: Enabled warnings recommended by Xcode 6.
2302         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed explicit linking against
2303         WebKit2.framework. Upgraded project file version.
2304
2305 2014-09-09  Daniel Bates  <dbates@webkit.org>
2306
2307         svn-{apply, unapply} fails to apply/unapply SVN 1.7 patch that adds new file with property change
2308         https://bugs.webkit.org/show_bug.cgi?id=136379
2309
2310         Reviewed by David Kilzer.
2311
2312         Fixes an issue where svn-{apply, unapply} fail to apply or unapply, respectively,
2313         a patch generated using Subversion 1.7.4 (r1295709) that both adds a new file F
2314         and sets a property on F (say, the executable bit).
2315
2316         * Scripts/svn-apply:
2317         (patch): Only add file if the diff has text chunks.
2318         * Scripts/svn-unapply:
2319         (patch): Only delete added file if the diff has text chunks.
2320
2321 2014-09-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2322
2323         [GTK] Unreviewed GTK gardening.
2324
2325         * Scripts/run-gtk-tests:
2326         (TestRunner): Skip TestSSL:webkit2/WebKitWebView/ssl (fails since r173423).
2327
2328 2014-09-09  Christophe Dumez  <cdumez@apple.com>
2329
2330         Update my email in contributors.json
2331         https://bugs.webkit.org/show_bug.cgi?id=136671
2332
2333         Reviewed by Andreas Kling.
2334
2335         * Scripts/webkitpy/common/config/contributors.json:
2336
2337 2014-09-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2338
2339         [EFL] Enable fixed layout by default
2340         https://bugs.webkit.org/show_bug.cgi?id=136607
2341
2342         Reviewed by Csaba Osztrogonác.
2343
2344         Fixed layout is being used by Tizen platform by default. However, the feature
2345         has still many defects now. So, we need to enable it by default, then should fix
2346         those bugs. 
2347
2348         * MiniBrowser/efl/main.c:
2349
2350 2014-09-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2351
2352         Remove FILTERS flag
2353         https://bugs.webkit.org/show_bug.cgi?id=136571
2354
2355         Reviewed by Darin Adler.
2356
2357         * Scripts/webkitperl/FeatureList.pm:
2358
2359 2014-09-08  Alexey Proskuryakov  <ap@apple.com>
2360
2361         Dashboard metrics should ignore commits that didn't trigger builds
2362         https://bugs.webkit.org/show_bug.cgi?id=136618
2363
2364         Reviewed by Darin Adler.
2365
2366         Commits that didn't trigger builds are ones like ChangeLog updates, patches for
2367         other platforms etc. It does not make sense to count wait time for these, as it
2368         can be arbitrarily long.
2369
2370         The new algorithm is much slower asymptotically, but it's OK, computers are fast.
2371
2372         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2373         (BuildbotIteration.prototype._parseData): Record changes that triggered the iteration.
2374
2375         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2376         We used to walk the timeline to see which revisions are fully tested, but that's not
2377         correct. A revision that's only tested by a subset of queues finishes independently
2378         of another that's tested by another subset. Now, we just search for the answer for
2379         each revision individually.
2380
2381         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js:
2382         (MetricsView.prototype._update.appendQueueResults): Added worst revision number, which
2383         the analyzer now reports. Removed best time, which is more confusing than meaningful.
2384
2385 2014-09-08  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2386
2387         Remove EWebLauncher from webkitdirs.pm
2388         https://bugs.webkit.org/show_bug.cgi?id=136622
2389
2390         Reviewed by Gyuyoung Kim.
2391
2392         * Scripts/webkitdirs.pm:
2393         (launcherName):
2394
2395 2014-09-06  Sam Weinig  <sam@webkit.org>
2396
2397         XPCPtr should be converted into an all purpose smart pointer for os_objects
2398         https://bugs.webkit.org/show_bug.cgi?id=136602
2399
2400         Reviewed by Darin Adler.
2401
2402         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2403         * TestWebKitAPI/Tests/WTF/darwin: Added.
2404         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: Added.
2405         Add basic unit tests for OSObjectPtr.
2406
2407 2014-09-06  Saam Barati  <saambarati1@gmail.com>
2408
2409         Unreviewed. Add myself as a committer.
2410
2411         * Scripts/webkitpy/common/config/contributors.json:
2412
2413 2014-09-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2414
2415         Unreviewed, EFL build fix when SHARED_CORE is on.
2416
2417         * TestWebKitAPI/PlatformEfl.cmake:
2418
2419 2014-09-05  Lucas Forschler  <lforschler@apple.com>
2420
2421         <https://webkit.org/b/136586> Add bots to Apple build/test queues
2422         
2423         Reviewed by Daniel Bates.
2424
2425         * BuildSlaveSupport/build.webkit.org-config/config.json:
2426
2427 2014-09-05  Alexey Proskuryakov  <ap@apple.com>
2428
2429         Buildbot metrics page gives wrong results after a new bot gets added
2430         https://bugs.webkit.org/show_bug.cgi?id=136516
2431
2432         Reviewed by Tim Horton.
2433
2434         Part 2: Fix elapsed times.
2435
2436         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2437         (Analyzer.prototype._countTimes): Made lastTestedRevisionByQueue contain undefined values
2438         until the first build in a queue. This happens to work as needed with _fullyTestedRevisionNumber().
2439
2440 2014-09-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2441
2442         [SOUP] Implement ResourceResponse::platformSuggestedFilename() when USE(SOUP) is enabled.
2443         https://bugs.webkit.org/show_bug.cgi?id=136562
2444
2445         Reviewed by Martin Robinson.
2446
2447         * Scripts/run-gtk-tests:
2448         (TestRunner): Remove failure expectations for tests that now pass.
2449
2450 2014-09-04  Alexey Proskuryakov  <ap@apple.com>
2451
2452         Dashboard metrics page wastes a lot of time sorting iterations
2453         https://bugs.webkit.org/show_bug.cgi?id=136559
2454
2455         Reviewed by Tim Horton.
2456
2457         Also fixes comments here and there, and adds a missing "var".
2458
2459         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2460         (BuildbotIteration.prototype._parseData):
2461         (BuildbotIteration.prototype._updateWithData):
2462         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2463         (BuildbotQueue.prototype.loadAll):
2464         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2465         (Analyzer.prototype._countTimes):
2466
2467 2014-09-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2468
2469         [GTK] Unreviewed GTK gardening.
2470
2471         * Scripts/run-gtk-tests:
2472         (TestRunner): Skip tests failing since r173272.
2473
2474 2014-09-04  Simon Fraser  <simon.fraser@apple.com>
2475
2476         Add some logging to help diagnose assertions in dumpWebViewAsPixelsAndCompareWithExpected() on bots
2477         https://bugs.webkit.org/show_bug.cgi?id=136561
2478
2479         Reviewed by Tim Horton.
2480         
2481         Log for calloc() and CGBitmapContextCreate() failures.
2482
2483         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2484         (createBitmapContext):
2485         (createBitmapContextFromWebView):
2486
2487 2014-09-04  Andy Estes  <aestes@apple.com>
2488
2489         Fix the Mac Production build after r173283.
2490
2491         * WebKitTestRunner/config.h: Reverted to defining WEBCORE_EXPORT for now.
2492
2493 2014-09-04  Brent Fulgham  <bfulgham@apple.com>
2494
2495         [Win] webkitpy test suite frequently fails to complete
2496         https://bugs.webkit.org/show_bug.cgi?id=136546
2497
2498         Reviewed by Daniel Bates.
2499
2500         Properly convert the ASCII crash log produced by ntsd into
2501         a unicode string as early as possible so that we handle it
2502         properly when generating our logs and other test support output.
2503
2504         We were mixing ASCII/unicode strings under Windows, which was
2505         causing test system failures when we processed some crash logs.
2506
2507         Also do a better job of handling garbage pid entries in the
2508         Cygwin lock files.
2509
2510         * Scripts/webkitpy/common/system/crashlogs.py:
2511         (CrashLogs._find_newest_log_win): The ntsd '.logopen' command
2512         creates an ASCII file. Decode it as ASCII, not 'utf-8', and
2513         handle the strings as unicode from that point on.
2514         * Scripts/webkitpy/port/http_lock.py:
2515         (HttpLock._current_lock_pid): Add logging and handle case of
2516         the current_pid failing to cleanly convert to 'int'.
2517         * Scripts/webkitpy/port/win.py:
2518         (WinPort): Add 64-bit architecture as a known target for the
2519         Windows build.
2520
2521 2014-09-04  Andy Estes  <aestes@apple.com>
2522
2523         Address additional review feedback after landing r173283.
2524
2525         Reviewed by Daniel Bates.
2526
2527         * DumpRenderTree/config.h: Removed redundant includes.
2528         * TestWebKitAPI/config.h: Ditto.
2529         * WebKitTestRunner/config.h: Ditto.
2530
2531 2014-09-03  Andy Estes  <aestes@apple.com>
2532
2533         [Cocoa] Some WebKitLegacy headers migrated from WebCore incorrectly contain WEBCORE_EXPORT
2534         https://bugs.webkit.org/show_bug.cgi?id=136521
2535
2536         Reviewed by Anders Carlsson.
2537
2538         * DumpRenderTree/config.h: Included <WebCore/PlatformExportMacros.h> instead of defining WEBCORE_EXPORT.
2539         * TestWebKitAPI/config.h: Ditto.
2540         * WebKitTestRunner/config.h: Ditto.
2541
2542 2014-09-04  Alexey Proskuryakov  <ap@apple.com>
2543
2544         REGRESSION: Dashboard metrics page aggregation counts performance bots
2545         https://bugs.webkit.org/show_bug.cgi?id=136539
2546
2547         Reviewed by Tim Horton.
2548
2549         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2550
2551 2014-09-04  Brent Fulgham  <bfulgham@apple.com>
2552
2553         [Win] Perl test fix.
2554
2555         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Correct test to check for
2556         VersionStamp.exe tool, not just the driver script.
2557
2558 2014-09-04  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2559
2560         Remove CSS_FILTERS flag
2561         https://bugs.webkit.org/show_bug.cgi?id=136529
2562
2563         Reviewed by Dirk Schulze.
2564
2565         * Scripts/webkitperl/FeatureList.pm:
2566
2567 2014-09-04  Commit Queue  <commit-queue@webkit.org>
2568
2569         Unreviewed, rolling out r173201.
2570         https://bugs.webkit.org/show_bug.cgi?id=136538
2571
2572         Improves the situation but also introduces additional crashes.
2573         (Requested by zdobersek on #webkit).
2574
2575         Reverted changeset:
2576
2577         "GMainLoopSource is exposed to race conditions"
2578         https://bugs.webkit.org/show_bug.cgi?id=135800
2579         http://trac.webkit.org/changeset/173201
2580
2581 2014-09-03  Alexey Proskuryakov  <ap@apple.com>
2582
2583         Buildbot metrics page gives wrong results after a new bot gets added
2584         https://bugs.webkit.org/show_bug.cgi?id=136516
2585
2586         Part 1: Fix red/green counters. Dashboard is considered green at a given time
2587         if all the bots that ever had results before this time are green.
2588
2589         This doesn't (and cannot) address situations where the bot gets removed and then
2590         re-added. It also gives wrong results after a bot gets removed, because it doesn't
2591         know that it was ever displayed on the dashboard.
2592
2593         Reviewed by Darin Adler.
2594
2595         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2596         (Analyzer.prototype._dashboardIsAllGreen):
2597         (Analyzer.prototype._updateStretchOfRedCounters):
2598         (Analyzer.prototype._countPercentageOfGreen):
2599         (Analyzer.prototype._allQueuesAreSuccessful): Deleted.
2600
2601 2014-09-03  Brent Fulgham  <bfulgham@apple.com>
2602
2603         [Win] Unreviewed test fix.
2604
2605         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Don't fail
2606         test if user doesn't have the VersionStamp.exe program.
2607
2608 2014-09-03  Dana Burkart  <dburkart@apple.com>
2609
2610         Unreviewed. Add myself as a committer.
2611
2612         * Scripts/webkitpy/common/config/contributors.json:
2613
2614 2014-09-03  Alexey Proskuryakov  <ap@apple.com>
2615
2616         build.webkit.org/dashboard performance popover is unstyled
2617         https://bugs.webkit.org/show_bug.cgi?id=136499
2618
2619         Reviewed by Tim Horton.
2620
2621         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2622         (.performance-popover):
2623         (.performance-popover .dashboard-link):
2624
2625 2014-09-03  Saam Barati  <saambarati1@gmail.com>
2626
2627         Create tests for type profiling
2628         https://bugs.webkit.org/show_bug.cgi?id=136161
2629
2630         Reviewed by Geoffrey Garen.
2631
2632         Have run-javascriptcore-tests run the newly created
2633         tests for the type profiler.
2634
2635         * Scripts/run-javascriptcore-tests:
2636         * Scripts/run-jsc-stress-tests:
2637
2638 2014-09-03  Brent Fulgham  <bfulgham@apple.com>
2639
2640         [Win] Revise test environment for Windows build.
2641         https://bugs.webkit.org/show_bug.cgi?id=136486
2642
2643         Reviewed by David Kilzer.
2644
2645         The various calls to get the Safari path really only have
2646         meaning on the Mac. Other ports get access to the build
2647         and test environment separately, so remove the various
2648         checks in the Safari-specific code to simplify things.
2649
2650         Remove some 64-bit hacks used on Windows now that the
2651         various tools know how to find the 64-bit runtime environment.
2652
2653         * Scripts/run-javascriptcore-tests: 
2654         * Scripts/webkitdirs.pm:
2655         (safariPathFromSafariBundle): Revise to expect Mac.
2656         (installedSafariPath): Ditto.
2657         (safariPath): Ditto.
2658         (appleApplicationSupportPath): Get rid of 64-bit Windows hack.
2659         (setPathForRunningWebKitApp): Get rid of unused SafariPath
2660         argument for Windows runs.
2661
2662 2014-09-03  Dana Burkart  <dburkart@apple.com>
2663
2664         Dashboard should show performance bots.
2665         https://bugs.webkit.org/show_bug.cgi?id=136386
2666
2667         Reviewed by Alexey Proskuryakov.
2668
2669         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2670         (BuildbotIteration.prototype._parseData.collectPerfTestResults):
2671         (BuildbotIteration.prototype._parseData):
2672         Support possible performance failures.
2673
2674         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
2675         New QueueView to manage the way we present performance data.
2676
2677         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2678         (BuildbotQueue):
2679         Support new 'performance' and 'performanceTestName' keys.
2680
2681
2682         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2683         Add performance column to the main page.
2684
2685         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2686         (WebKitBuildbot):
2687         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2688         (body):
2689         Make sure everything fits on 13 inch screens.
2690
2691         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
2692
2693 2014-09-03  Zan Dobersek  <zdobersek@igalia.com>
2694
2695         GMainLoopSource is exposed to race conditions
2696         https://bugs.webkit.org/show_bug.cgi?id=135800
2697
2698         Reviewed by Carlos Garcia Campos.
2699
2700         Add a unit test for GMainLoopSource that tests different
2701         types of rescheduling tasks on already-active sources.
2702
2703         * TestWebKitAPI/PlatformGTK.cmake:
2704         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp: Added.
2705         (GMainLoopSourceTest::GMainLoopSourceTest):
2706         (GMainLoopSourceTest::~GMainLoopSourceTest):
2707         (GMainLoopSourceTest::runLoop):
2708         (GMainLoopSourceTest::finish):
2709         (GMainLoopSourceTest::source):
2710         (testGMainLoopSourceBasicRescheduling):
2711         (testGMainLoopSourceReentrantRescheduling):
2712         (testGMainLoopSourceDifferentThreadRescheduling):
2713         (beforeAll):
2714         (afterAll):
2715         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
2716         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
2717         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
2718         (TestWebKitAPI::GMainLoopSourceTest::finish):
2719         (TestWebKitAPI::GMainLoopSourceTest::source):
2720         (TestWebKitAPI::TEST):
2721
2722 2014-09-02  Simon Fraser  <simon.fraser@apple.com>
2723
2724         Make sure WK1 prefs are initialized in MiniBrowser
2725         https://bugs.webkit.org/show_bug.cgi?id=136465
2726
2727         Reviewed by Tim Horton.
2728         
2729         Call -didChangeSettings from -awakeFromNib for WK1 windows just as we do
2730         for WK2 windows, to make sure that WebPreferences are updated (to get
2731         layer borders to work consistently).
2732
2733         * MiniBrowser/mac/WK1BrowserWindowController.m:
2734         (-[WK1BrowserWindowController awakeFromNib]):
2735
2736 2014-09-02  Renato Nagy  <rnagy@inf.u-szeged.hu>
2737
2738         check-webkit-style should complain about C++ comments in Platform.h
2739         https://bugs.webkit.org/show_bug.cgi?id=133802
2740
2741         Reviewed by Csaba Osztrogonác.
2742
2743         * Scripts/webkitpy/style/checkers/cpp.py:
2744         (check_platformh_comments):
2745         (_process_lines):
2746         (CppChecker):
2747         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2748         (CppStyleTest.test_platformh_comment):
2749
2750 2014-09-02  Brendan Long  <self@brendanlong.com>
2751
2752         [Gtk] Make install-dependencies work on Arch Linux
2753         https://bugs.webkit.org/show_bug.cgi?id=136374
2754
2755         Reviewed by Philippe Normand.
2756
2757         * gtk/install-dependencies: Add dependencies for pacman (Arch Linux).
2758
2759 2014-09-01  Brian J. Burg  <burg@cs.washington.edu>
2760
2761         Provide column numbers to DTrace willExecute/didExecute probes
2762         https://bugs.webkit.org/show_bug.cgi?id=136434
2763
2764         Reviewed by Antti Koivisto.
2765
2766         Create a directory for DTrace scripts. Add an example script that
2767         shows how to use static probes provided by JavaScriptCore's profiler.
2768
2769         * Scripts/dtrace/jsc-trace-profiler-events.d: Added.
2770
2771 2014-09-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2772
2773         [GTK] [JHBuild] Cyclic dependency between cairo and librsvg.
2774         https://bugs.webkit.org/show_bug.cgi?id=136431
2775
2776         Reviewed by Martin Robinson.
2777
2778         * gtk/jhbuild.modules: Disable cairo SVG testsuite.
2779         Add missing dependencies for librsvg (glib and cairo).
2780
2781 2014-09-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2782
2783         [GTK] install-dependencies don't installs dbus-launch that is needed for the API tests.
2784         https://bugs.webkit.org/show_bug.cgi?id=136425
2785
2786         Reviewed by Martin Robinson.
2787
2788         * gtk/install-dependencies: Add dbus-x11 to the list of packages needed for running the tests.
2789
2790 2014-09-01  Ryuan Choi  <ryuan.choi@samsung.com>
2791
2792         Update my list of email addresses in contributors.json
2793         https://bugs.webkit.org/show_bug.cgi?id=136424
2794
2795         Reviewed by Gyuyoung Kim.
2796
2797         * Scripts/webkitpy/common/config/contributors.json:
2798
2799 2014-08-30  Filip Pizlo  <fpizlo@apple.com>
2800
2801         [RJST] eager-no-cjit should really mean eager
2802         https://bugs.webkit.org/show_bug.cgi?id=136407
2803
2804         Reviewed by Mark Hahnenberg.
2805         
2806         At some point we made NO_CJIT_OPTIONS force threshold settings to something reasonable
2807         and well-known. But the way we appended options was such that NO_CJIT_OPTIONS came in
2808         after EAGER_OPTIONS. The whole point of "eager" was to use eager tier-up thresholds. This
2809         all meant that NO_CJIT_OPTIONS was overriding the eagerness of EAGER_OPTIONS, for the one
2810         threshold setting that NO_CJIT_OPTIONS was currently setting
2811         (thresholdForJITAfterWarmUp). The solution is to make sure that we always append
2812         NO_CJIT_OPTIONS before we append EAGER_OPTIONS.
2813         
2814         Luckily, no tests regressed during the time that we lost eager-no-cjit coverage.
2815
2816         * Scripts/run-jsc-stress-tests:
2817
2818 2014-08-29  Daniel Bates  <dabates@apple.com>
2819
2820         [iOS] Configure Xcode to build a command line tool for the iOS Simulator
2821         https://bugs.webkit.org/show_bug.cgi?id=136388
2822
2823         Reviewed by David Kilzer.
2824
2825         Add a script, called configure-xcode-for-ios-development, to configure Xcode to
2826         support building a command line tool for the iOS Simulator. You must run this
2827         script as root.
2828
2829         The script uses the xcspec files in the OS X SDK to create xcspec files in the
2830         iOS Simulator SDK with the product- and package- type definitions to build a
2831         command line tool, if applicable.
2832
2833         * Scripts/configure-xcode-for-ios-development: Added.
2834
2835 2014-08-29  Tim Horton  <timothy_horton@apple.com>
2836
2837         Remove Windows WebKit2 code from TestWebKitAPI
2838         https://bugs.webkit.org/show_bug.cgi?id=136385
2839
2840         Reviewed by Alexey Proskuryakov.
2841
2842         * TestWebKitAPI/PlatformUtilities.h:
2843         * TestWebKitAPI/PlatformWebView.h:
2844         (TestWebKitAPI::PlatformWebView::setParentWindowMessageObserver): Deleted.
2845         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
2846         (TestWebKitAPI::TEST): Deleted.
2847         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2848         (TestWebKitAPI::TEST):
2849         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2850         (TestWebKitAPI::TEST):
2851         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp: Removed.
2852         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Removed.
2853         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Removed.
2854         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp: Removed.
2855         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp: Removed.
2856         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp: Removed.
2857         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp: Removed.
2858
2859 2014-08-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2860
2861         [JSC] Some JSC tests are dependent on the machine time zone.
2862         https://bugs.webkit.org/show_bug.cgi?id=136363
2863
2864         Reviewed by Filip Pizlo.
2865
2866         * Scripts/run-javascriptcore-tests: Export TZ environment variable to US/Pacific.
2867         Unskip the tests that were skipped on r99580.
2868
2869 2014-08-29  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2870
2871         [EFL] Remove non Coordinated Graphics code path from cmake build system after r142169
2872         https://bugs.webkit.org/show_bug.cgi?id=135560
2873
2874         Reviewed by Gyuyoung Kim.
2875
2876         * Scripts/webkitperl/FeatureList.pm: Removed TILED_BACKING_STORE guard.
2877
2878 2014-08-28  Daniel Bates  <dabates@apple.com>
2879
2880         [Win] update-webkit should update auxiliary libs by default
2881
2882         Reviewed by Dan Bernstein.
2883
2884         The change set <http://trac.webkit.org/changeset/172795> inadvertently prevented update-webkit
2885         from updating the Windows auxiliary libs by default. We should make update-webkit update the
2886         Windows auxiliary libs by default. This will make its behavior match its usage text.
2887
2888         * Scripts/update-webkit:
2889
2890 2014-08-28  Brian J. Burg  <burg@cs.washington.edu>
2891
2892         build-webkit --inspector-frontend tries to copy files from old inspector path
2893         https://bugs.webkit.org/show_bug.cgi?id=136346
2894
2895         Reviewed by Timothy Hatcher.
2896
2897         Remove the old code path for copying inspector resources. It doesn't work.
2898         Complain if this option is passed to CMake-based builds.
2899
2900         * Scripts/build-webkit:
2901         * Scripts/webkitdirs.pm:
2902         (copyInspectorFrontendFiles): Deleted.
2903
2904 2014-08-28  Alexey Proskuryakov  <ap@apple.com>
2905
2906         Dashboard metrics page could show longest stretch of red
2907         https://bugs.webkit.org/show_bug.cgi?id=136334
2908
2909         Reviewed by Sam Weinig.
2910
2911         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2912         (Analyzer.prototype._updateStretchOfRedCounters):
2913         (Analyzer.prototype._countPercentageOfGreen):
2914         When counting percentage of green, also keep track of how long the page was red.
2915
2916         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js:
2917         (MetricsView.prototype._update.addDivider):
2918         (MetricsView.prototype._update.appendQueueResults):
2919         Show it in aggregate queues (can't think of a reason to have it in individual ones).
2920
2921         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Metrics.css:
2922         Changed to use an explicit divider element between green time and performance groups,
2923         as there are too many combinations to easily express in CSS.
2924
2925 2014-08-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2926
2927         [GTK] Add webkit_uri_response_get_http_headers to WebKit2 GTK+ API
2928         https://bugs.webkit.org/show_bug.cgi?id=136248
2929
2930         Reviewed by Gustavo Noronha Silva.
2931
2932         Add new test case for webkit_uri_response_get_http_headers().
2933
2934         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
2935         (testURIResponseHTTPHeaders):
2936         (serverCallback):
2937         (beforeAll):
2938
2939 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
2940
2941         EWS status link at build.webkit.org/dashboard is incorrect until EWS pop-up is opened
2942         https://bugs.webkit.org/show_bug.cgi?id=131668
2943
2944         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
2945         (EWSQueue.prototype.loadDetailedStatus): Fixed a typo in assertion.
2946
2947 2014-08-27  Zalan Bujtas  <zalan@apple.com>
2948
2949         Subpixel layout: Cleanup snapSizeToPixel/snapSizeToDevicePixel.
2950         https://bugs.webkit.org/show_bug.cgi?id=136264
2951
2952         Reviewed by Simon Fraser.
2953         
2954         1. Align snapSizeToPixel()/snapSizeToDevicePixel() function names with the rest of snapping
2955         functions. ->snappedIntSize()/snapSizeToDevicePixel().
2956         2. Operate on LayoutSize/LayoutPoint instead of LayoutUnit/LayoutUnit to reflect functionality.
2957
2958         Covered by existing tests.
2959
2960         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
2961         (TestWebKitAPI::TEST): Deleted.
2962
2963 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
2964
2965         EWS status link at build.webkit.org/dashboard is incorrect until EWS pop-up is opened
2966         https://bugs.webkit.org/show_bug.cgi?id=131668
2967
2968         Reviewed by Daniel Bates.
2969
2970         We used to fetch the URL from EWS detailed status JSON, but there isn't much reason
2971         to not just hardcode.
2972
2973         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
2974         (EWS.prototype.queueStatusURL): Added.
2975
2976         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
2977         (EWSQueue.prototype.get statusPageURL): Use the above function.
2978         (EWSQueue.prototype.loadDetailedStatus): Changed assignment to an assertion.
2979
2980         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
2981         (EWSQueueView.prototype.update): While at it, made a popover show up even if there
2982         are no patches in the queue. The popover has other useful information, such as charts
2983         link and bot status.
2984
2985 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
2986
2987         https://bugs.webkit.org/show_bug.cgi?id=136317
2988         Dashboard metrics page sometimes shows 0 for best time
2989
2990         Reviewed by Tim Horton.
2991
2992         This also affects regular dashboard display in a good way - iterations that failed
2993         due to infrastructure misbehavior will more reliably show up as yellow and not red.
2994
2995         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2996         (BuildbotIteration): Added a list of steps that we actually care about. It will need to be
2997         updated if we rename steps.
2998         (BuildbotIteration.prototype.get productive): Now that computation is more involved,
2999         do it once.
3000         (BuildbotIteration.prototype._parseData): Tweak computation of "productive" - builds
3001         that failed e.g. at downloading built archive step are not productive.
3002
3003 2014-08-27  Brent Fulgham  <bfulgham@apple.com>
3004
3005         [Win] Unreviewed gardening.
3006
3007         * win/AssembleBuildLogs/AssembleLogs.cmd: Add some missing build logs to the set
3008         of logs assembled into the final build output.
3009
3010 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
3011
3012         build.webkit.org/dashboard: Add a metrics page with overall bot performance results
3013         https://bugs.webkit.org/show_bug.cgi?id=136196
3014
3015         Reviewed by Timothy Hatcher.
3016
3017         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External: Added.
3018         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/daterangepicker.css: Added.
3019         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery-1.11.1.min.js: Added.
3020         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery.daterangepicker.js: Added.
3021         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/moment.min.js: Added.
3022         A date range picker control with dependencies.
3023         There are a few modifications from upstream at <https://github.com/longbill/jquery-date-range-picker>:
3024         - Fixed a bug where selected dates were not at midnight the first time a range was chosen
3025         (it didn't happen again upon re-opening the picker).
3026         - Made made style tweaks to match Dashboard UI.
3027
3028         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
3029         Don't create objects that are not needed by the given app, and thus are not loaded at all.
3030
3031         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js: Added.
3032         Math to count all the things. Only supports open source tree and trunk at the moment,
3033         but written with internal tree and branches in mind.
3034
3035         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js: Added.
3036         Like dashboard Main.js, draws the UI and creates all necessary objects.
3037
3038         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js: Added.
3039         A view for table cells.
3040
3041         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
3042         (Settings.prototype.toggleSettingsDisplay): Added an event for entering settings.
3043         Metrics page has individual platforms initially scrolled away form the view, so 
3044         it needs to scroll down to reveal what's being configured.
3045
3046         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
3047         Added Array.prototype.average and Array.prototype.median.
3048
3049         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3050         Made gear icon fixed instead of absolute, so that it's visible on metrics page when
3051         in settings mode.
3052
3053         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Metrics.css:
3054         Additional style rules.
3055
3056         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:
3057         The metrics page.
3058
3059 2014-08-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3060
3061         Remove networkinfo watch category in watchlist
3062         https://bugs.webkit.org/show_bug.cgi?id=136279
3063
3064         Reviewed by Alexey Proskuryakov.
3065
3066         Network info was removed. So, it is not needed anymore.
3067
3068         * Scripts/webkitpy/common/config/watchlist:
3069
3070 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
3071
3072         build.webkit.org/dashboard: Poor performance when there are broken builds at initial load time
3073         https://bugs.webkit.org/show_bug.cgi?id=136281
3074
3075         Reviewed by Tim Horton.
3076
3077         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3078         Track and expose whether the itertion is being loaded. Made update() a no-op if
3079         the iteration is already being loaded.
3080
3081         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3082         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Instead of
3083         loading everything at once, ask the queue to load a little more. We can always repeat
3084         if we still don't have enough data.
3085
3086         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3087         (BuildbotQueue.prototype.loadMoreHistoricalIterations): Added a function that loads
3088         10 more iterations intelligently.
3089
3090 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
3091
3092         build.webkit.org/dashboard raises an exception when Trac RSS fails to load
3093         https://bugs.webkit.org/show_bug.cgi?id=136283
3094
3095         Reviewed by Tim Horton.
3096
3097         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3098         Don't.
3099
3100 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
3101
3102         build.webkit.org/dashboard raises an exception after a hidden platform is removed
3103         https://bugs.webkit.org/show_bug.cgi?id=136282
3104
3105         Reviewed by Tim Horton.
3106
3107         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3108         (updateHiddenPlatforms): Check that the platform is still valid.
3109
3110 2014-08-26  Matt Lilek  <mrl@apple.com>
3111
3112         Add WebKit SPI to control the navigator.standalone property
3113         https://bugs.webkit.org/show_bug.cgi?id=136189
3114
3115         Reviewed by Andy Estes.
3116
3117         Add API test for WKPreferences
3118
3119         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3120         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
3121         (TEST):
3122
3123 2014-08-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3124
3125         Remove ENABLE_DRT environment variable to enable SHARED_CORE
3126         https://bugs.webkit.org/show_bug.cgi?id=136205
3127
3128         Reviewed by Andrei Bucur.
3129
3130         EFL port doesn't need to enable SHARED_CORE since r172894. Thus, we don't need to
3131         use ENABLE_DRT enviroment variable, which enables SHARED_CORE.
3132
3133         * Scripts/webkitdirs.pm:
3134         (generateBuildSystemFromCMakeProject):
3135
3136 2014-08-26  Brent Fulgham  <bfulgham@apple.com>
3137
3138         [Win] Version stamp should include package-level version
3139         https://bugs.webkit.org/show_bug.cgi?id=136266
3140         <rdar://problem/18134138>
3141
3142         Reviewed by David Kilzer.
3143
3144         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Add
3145         tests for the full 3+ digit version.
3146         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
3147         Confirm that the final output DLL uses the 3+ digit version.
3148
3149 2014-08-26  Brent Fulgham  <bfulgham@apple.com>
3150
3151         [Win] WebKit IDL incorrectly passes HWND as OLE_HANDLE
3152         https://bugs.webkit.org/show_bug.cgi?id=136258
3153         <rdar://problem/18134138>
3154
3155         Reviewed by Tim Horton.
3156
3157         Avoid 32/64-bit truncation by preventing 64-bit HWND (and other)
3158         values from passing through the 32-bit OLE_HANDLE data type.
3159
3160         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3161         (AccessibilityController::rootElement):
3162         * DumpRenderTree/win/DumpRenderTree.cpp:
3163         (resetWebViewToConsistentStateBeforeTesting):
3164         (runTest):
3165         (createWebViewAndOffscreenWindow):
3166         * DumpRenderTree/win/FrameLoadDelegate.h:
3167         (FrameLoadDelegate::didReceiveIcon):
3168         * DumpRenderTree/win/TestRunnerWin.cpp:
3169         (TestRunner::setWindowIsKey):
3170         * DumpRenderTree/win/UIDelegate.cpp:
3171         (UIDelegate::trackCustomPopupMenu):
3172         (UIDelegate::drawHeaderInRect):
3173         (UIDelegate::drawFooterInRect):
3174         (UIDelegate::webViewClose):
3175         (UIDelegate::webViewFocus):
3176         (UIDelegate::webViewSetCursor):
3177         (UIDelegate::drawBackground):
3178         * DumpRenderTree/win/UIDelegate.h:
3179         (UIDelegate::webViewFirstResponder):
3180         (UIDelegate::makeFirstResponder):
3181         (UIDelegate::contextMenuItemsForElement):
3182         (UIDelegate::addCustomMenuDrawingData):
3183         (UIDelegate::cleanUpCustomMenuDrawingData):
3184         (UIDelegate::webViewLostFocus):
3185         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
3186         (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
3187         * WinLauncher/PrintWebUIDelegate.cpp:
3188         (PrintWebUIDelegate::drawHeaderInRect):
3189         (PrintWebUIDelegate::drawFooterInRect):
3190         * WinLauncher/PrintWebUIDelegate.h:
3191         (PrintWebUIDelegate::webViewFirstResponder):
3192         (PrintWebUIDelegate::makeFirstResponder):
3193         (PrintWebUIDelegate::contextMenuItemsForElement):
3194         (PrintWebUIDelegate::trackCustomPopupMenu):
3195         (PrintWebUIDelegate::addCustomMenuDrawingData):
3196         (PrintWebUIDelegate::cleanUpCustomMenuDrawingData):
3197         * WinLauncher/WinLauncher.cpp:
3198         (WinLauncher::prepareViews):
3199         * WinLauncher/WinLauncherWebHost.h:
3200         (WinLauncherWebHost::didReceiveIcon):
3201
3202 2014-08-26  Daniel Bates  <dabates@apple.com>
3203
3204         Only define WEBCORE_EXPORT when building DumpRenderTree for Windows and iOS
3205
3206         Rubber-stamped by Tim Horton.
3207
3208         The Windows and iOS ports are the only ports that make use of WebCore headers
3209         in DumpRenderTree.
3210
3211         * DumpRenderTree/config.h:
3212
3213 2014-08-26  Dan Bernstein  <mitz@apple.com>
3214
3215         runSvnUpdateAndResolveChangeLogs() doesn’t work when invoked from a script outside Tools/Scripts
3216         https://bugs.webkit.org/show_bug.cgi?id=136254
3217
3218         Reviewed by Tim Horton.
3219
3220         * Scripts/webkitdirs.pm:
3221         (runSvnUpdateAndResolveChangeLogs): Locate resolve-ChangeLogs relative to the source tree,
3222         not the invoking script.
3223
3224 2014-08-26  Krzysztof Czech  <k.czech@samsung.com>
3225
3226         [EFL] Utilize espeak as a synthesizer back-end for WebSpeech
3227         https://bugs.webkit.org/show_bug.cgi?id=136127
3228
3229         Reviewed by Gyuyoung Kim.
3230
3231         Add espeak dependency.
3232
3233         * efl/install-dependencies:
3234
3235 2014-08-25  Alexey Proskuryakov  <ap@apple.com>
3236
3237         Remove a little more accidentally landed code from r172891.
3238
3239         iteration.branch also wasn't meant to be landed.
3240
3241         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3242         (BuildbotIteration.prototype._parseData):
3243
3244 2014-08-25  Alexey Proskuryakov  <ap@apple.com>
3245
3246         REGRESSION (r172891): Internal dashboard is broken.
3247
3248         Removing some accidentally landed code - I needed "changes" for another patch, but
3249         not here, and then I decided to not use it anyway.
3250
3251         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3252         (BuildbotIteration.prototype._parseData):
3253
3254 2014-08-25  Daniel Bates  <dabates@apple.com>
3255
3256         Fix the iOS DumpRenderTree build after <http://trac.webkit.org/changeset/172814/>
3257         (https://bugs.webkit.org/show_bug.cgi?id=136108)
3258
3259         Use a similar approach as in TestWebKitAPI/config.h and define a stub for the macro define WEBCORE_EXPORT
3260         so that we can compile DumpRenderTree for iOS.
3261
3262         * DumpRenderTree/config.h:
3263
3264 2014-08-25  Alexey Proskuryakov  <ap@apple.com>
3265
3266         Make build.webkit.org/dashboard work with changeset_show_files=location
3267         https://bugs.webkit.org/show_bug.cgi?id=136237
3268
3269         Reviewed by Tim Horton.
3270
3271         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3272         (Trac.prototype._convertCommitInfoElementToObject): Remove location information
3273         from description before getting title, and also actually parse the location into
3274         result object when available.
3275
3276         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
3277         (String.prototype.startsWith): Added.
3278
3279 2014-08-25  Tanay C  <tanay.c@samsung.com>
3280
3281         [EFL][WK2] Minibrowser : Enhance application to be able to support history list navigation
3282         https://bugs.webkit.org/show_bug.cgi?id=135795
3283
3284         Reviewed by Gyuyoung Kim.
3285
3286         * MiniBrowser/efl/main.c: Adding functionality for long press history list navigation
3287         (history_list_hide): Hiding and dereferencing the history list and items
3288         (on_key_down):
3289         (on_mouse_down):
3290         (on_back_button_clicked): Early return for longpress 
3291         (on_forward_button_clicked): Early return for longpress 
3292         (list_item_label_get): Populate item labels
3293         (on_list_item_select): Navigates on selection from history list
3294         (navigation_button_longpress_process): Populates the history list and displays it
3295         (on_forward_button_longpress):
3296         (on_back_button_longpress):
3297         (window_create): Add the widget for history list
3298
3299 2014-08-25  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3300
3301         [GTK] JHBuild module gst-plugins-base fails to build on x86 with GCC 4.9
3302         https://bugs.webkit.org/show_bug.cgi?id=136152
3303
3304         Reviewed by Philippe Normand.
3305
3306         * gtk/jhbuild.modules: Apply gst-plugins-base-fix-build-gcc-4.9-x86.patch.
3307         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Added.
3308         Cherry pick upstream patches daa194 and 4e3d101.
3309
3310 2014-08-24  Zan Dobersek  <zdobersek@igalia.com>
3311
3312         GenericHashTraits::peek() is producing copies of passed-in temporary values
3313         https://bugs.webkit.org/show_bug.cgi?id=131461
3314
3315         Reviewed by Darin Adler.
3316
3317         Add a test case that checks the number of copies and moves of the mapped objects
3318         when calling HashMap::get(). Exactly one copy of the mapped value should be
3319         performed when there exists a value that is mapped to the specified key, and
3320         exactly one move and no copies of the empty value should be performed when there
3321         isn't any mapped value for the specified key.
3322
3323         * TestWebKitAPI/Tests/WTF/CopyMoveCounter.h: Added.
3324         (CopyMoveCounter::TestingScope::TestingScope):
3325         (CopyMoveCounter::CopyMoveCounter):
3326         (CopyMoveCounter::operator=):
3327         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3328         (TestWebKitAPI::TEST):
3329
3330 2014-08-24  Ryuan Choi  <ryuan.choi@samsung.com>
3331
3332         [EFL] Introduce DEVELOPER_MODE
3333         https://bugs.webkit.org/show_bug.cgi?id=135884
3334
3335         Reviewed by Gyuyoung Kim.
3336
3337         * Scripts/webkitdirs.pm: Turn on DEVELOPER_MODE for the EFL port.
3338         (generateBuildSystemFromCMakeProject):
3339
3340 2014-08-24  Alexey Proskuryakov  <ap@apple.com>
3341
3342         build.webkit.org/dashboard unnecessarily loads results of hidden queues
3343         https://bugs.webkit.org/show_bug.cgi?id=136195
3344
3345         Reviewed by Tim Horton.
3346
3347         This patch also makes it possible to avoid any automatic loading, as needed for metrics view.
3348
3349         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3350         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
3351         Don't start an update just because a queue object was created. Periodic updates
3352         are triggered by views, so it only makes sense to do the same for the initial update.
3353
3354         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3355         Now that Trac object doesn't auto-load, start loading here.
3356
3357         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
3358         (QueueView): Calling _updateHiddenState right away was wrong, because it accesses
3359         a data member added by subclasses later. With this.platform being undefined, it
3360         always looked like this queue was not hidden.
3361         (QueueView.prototype._updateHiddenState): Start an immediate update, too.
3362
3363         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3364         (Trac): Don't load anything here, the client may choose to load a custom date range.
3365         (Trac.prototype.startPeriodicUpdates): Added a function to start automatic loading.
3366
3367 2014-08-23  Alexey Proskuryakov  <ap@apple.com>
3368
3369         build.webkit.org/dashboard: Further improve Trac loading
3370         https://bugs.webkit.org/show_bug.cgi?id=136174
3371
3372         Reviewed by Timothy Hatcher.
3373
3374         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3375         (Trac.prototype._xmlTimelineURL): Passing -1 as "max" resulted in an off by one
3376         error, the oldest commit within the range wasn't returned. The correct argument for
3377         "no limit" is 0.
3378         (Trac.prototype.load): Added a function to load a specific time range.
3379         (Trac.prototype._loaded): Updated to support loading revisions that are arbitrarily
3380         positioned with regards to ones that were already known.
3381
3382 2014-08-23  Alexey Proskuryakov  <ap@apple.com>
3383
3384         build.webkit.org/dashboard: Make it possible to pull historic data from Buildbot
3385         https://bugs.webkit.org/show_bug.cgi?id=136182
3386
3387         Reviewed by Timothy Hatcher.
3388
3389         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3390         Make it possible to create a complete BuildbotIteration object with JSON, not only by
3391         loading data from the network.
3392
3393         An iteration has three states:
3394         1. Just created, it only knows the revision, and whether it's already finished.
3395         BuildbotIteration constructor used to create these.
3396         2. A complete JSON report loaded from buildbot. The new constructor form creates these.
3397         3. Data about tests is fetched.
3398
3399         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3400         Make it possible to pull all data from a buildbot queue. This needs to be better
3401         optimized eventually, as it's somewhat slow.
3402
3403 2014-08-22  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
3404
3405         Remove LevelDB.
3406         https://bugs.webkit.org/show_bug.cgi?id=136170
3407
3408         Reviewed by Gyuyoung Kim.
3409
3410         * Scripts/webkitpy/common/config/watchlist:
3411         * Scripts/webkitpy/style/checker.py:
3412
3413 2014-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3414
3415         [GTK] install-dependencies don't installs Xvfb that is needed for the tests.
3416         https://bugs.webkit.org/show_bug.cgi?id=136153
3417
3418         Reviewed by Martin Robinson.
3419
3420         * gtk/install-dependencies: Add Xvfb package to the list of dependencies necessary for running tests.
3421
3422 2014-08-21  Alex Christensen  <achristensen@webkit.org>
3423
3424         [Win] Another unreviewed build fix.
3425
3426         * DumpRenderTree/config.h:
3427         Defined WEBCORE_EXPORT on Windows.
3428
3429 2014-08-21  Rohit Kumar  <kumar.rohit@samsung.com>
3430
3431         [EFL][WK2] Minibrowser : Add stop button to abort page load
3432         https://bugs.webkit.org/show_bug.cgi?id=136122
3433
3434         Reviewed by Gyuyoung Kim.
3435
3436         * MiniBrowser/efl/main.c:
3437         (on_key_down):
3438         (on_stop_button_clicked): Callback for stop button press.
3439         (window_create):
3440
3441 2014-08-21  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3442
3443         [GTK] Load the llvmpipe (Mesa) libraries when running the tests with Xvfb.
3444         https://bugs.webkit.org/show_bug.cgi?id=134070
3445
3446         Reviewed by Martin Robinson.
3447
3448         * Scripts/webkitpy/port/base.py:
3449         (Port.__init__): Set default _jhbuild_wrapper variable.
3450         (Port._should_use_jhbuild): Implement generic check.
3451         * Scripts/webkitpy/port/efl.py: Rename to jhbuild_wrapper variable
3452         to make it consistent with the other ports.
3453         * Scripts/webkitpy/port/gtk.py:
3454         (GtkPort.__init__): Use the new _should_use_jhbuild() method.
3455         (GtkPort.setup_environ_for_server): Get the path for llvmpipe_libgl_path by
3456         querying the jhbuild with printenv. Also check that the path contains
3457         the libraries we expect. Preload this path only for XvfbDriver.
3458         * Scripts/webkitpy/port/xvfbdriver.py:
3459         (XvfbDriver.check_driver): Check for the jhbuild wrapper and use it.
3460         (XvfbDriver._start): The environment for llvmpipe_libgl_path is now
3461         configured at setup_environ_for_server()
3462         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
3463         (XvfbDriverTest.make_driver): Get the port default environment.
3464         (XvfbDriverTest.test_start_no_pixel_tests): The expected log now
3465         should include the environment that is passed when running Xvfb.
3466         (XvfbDriverTest.test_start_pixel_tests): Ditto.
3467         (XvfbDriverTest.test_start_arbitrary_worker_number): Ditto.
3468         (XvfbDriverTest.test_start_next_worker): Ditto.
3469         * gtk/jhbuild.modules: Rename checkoutdir to generic "Mesa" to
3470         prevent future problems when the version is raised. Add also a
3471         comment with a warning.
3472         * gtk/jhbuildrc: The path LLVMPIPE_LIBGL_PATH should be the one
3473         that has the llvm optimized Gallium libGL libraries.
3474
3475 2014-08-21  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
3476
3477         Fix countFailures of RunLLINTCLoopTests and Run32bitJSCTests.
3478         https://bugs.webkit.org/show_bug.cgi?id=136125
3479
3480         Reviewed by Csaba Osztrogonác.
3481
3482         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3483         (RunLLINTCLoopTests.countFailures):
3484         (Run32bitJSCTests.countFailures):
3485         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3486         (RunLLINTCLoopTestsTest):
3487         (RunLLINTCLoopTestsTest.assertResults):
3488         (RunLLINTCLoopTestsTest.test_failures):
3489         (RunLLINTCLoopTestsTest.test_failure):
3490         (RunLLINTCLoopTestsTest.test_no_failure):
3491         (Run32bitJSCTestsTest):
3492         (Run32bitJSCTestsTest.assertResults):
3493         (Run32bitJSCTestsTest.test_failures):
3494         (Run32bitJSCTestsTest.test_failure):
3495         (Run32bitJSCTestsTest.test_no_failure):
3496
3497 2014-08-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3498
3499         Unreviewed, EFL build fix since r172814.
3500
3501         * WebKitTestRunner/config.h: Define WEBCORE_EXPORT.
3502
3503 2014-08-20  Alex Christensen  <achristensen@webkit.org>
3504
3505         Introducing WEBCORE_EXPORT macro.
3506         https://bugs.webkit.org/show_bug.cgi?id=136108
3507
3508         Reviewed by Antti Koivisto.
3509
3510         * TestWebKitAPI/config.h:
3511         Added stub definition of WEBCORE_EXPORT defined to nothing to be able to compile with WebCore headers.
3512
3513 2014-08-20  Rebecca Hauck  <rhauck@adobe.com>
3514
3515         import-w3c-tests doesn't import .svg support files
3516         https://bugs.webkit.org/show_bug.cgi?id=135928
3517
3518         Reviewed by Bem Jones-Bey.
3519
3520         This patch fixes the W3C import script to not treat all
3521         files with an xml mimetype as convertible tests, which
3522         was causing SVG support files to not be imported.
3523
3524         * Scripts/webkitpy/w3c/test_importer.py:
3525         (TestImporter.find_importable_tests):
3526
3527 2014-08-19  Dan Bernstein  <mitz@apple.com>
3528
3529         update-webkit should not check for the presence of Apple’s Internal directory
3530         Last part of https://bugs.webkit.org/show_bug.cgi?id=135815
3531
3532         Reviewed by Tim Horton.
3533
3534         * Scripts/update-webkit:
3535
3536 2014-08-19  Zalan Bujtas  <zalan@apple.com>
3537
3538         Remove ENABLE(SUBPIXEL_LAYOUT).
3539         https://bugs.webkit.org/show_bug.cgi?id=136077
3540
3541         Reviewed by Simon Fraser.
3542
3543         Remove compile time flag SUBPIXEL_LAYOUT. All ports have it enabled for a while now.
3544
3545         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
3546
3547 2014-08-19  Akos Kiss  <akiss@inf.u-szeged.hu>
3548
3549         Let the caller define JSC_timeout for run-javascriptcore-tests
3550         https://bugs.webkit.org/show_bug.cgi?id=136068
3551
3552         Reviewed by Csaba Osztrogonác.
3553
3554         Keep the 60 second timeout for jsc tests as the default setting but
3555         don't override the value of JSC_timeout if already set.
3556
3557         * Scripts/run-javascriptcore-tests:
3558
3559 2014-08-19  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
3560
3561         Remove obsolete run-javascriptcore-tests result parsing from master.cfg
3562         https://bugs.webkit.org/show_bug.cgi?id=136039
3563
3564         Reviewed by Csaba Osztrogonác.
3565
3566         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3567         (RunJavaScriptCoreTests.commandComplete):
3568         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3569         (RunJavaScriptCoreTestsTest.test_no_failure_new_output):
3570         (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
3571         (RunJavaScriptCoreTestsTest):
3572         (RunJavaScriptCoreTestsTest.test_jsc_stress_failure_new_output):
3573         (RunJavaScriptCoreTestsTest.test_mozilla_failure_new_output): Deleted.
3574         (test_layout_failure_new_output): Deleted.
3575         (test_layout_crash_new_output): Deleted.
3576         (test_mozilla_and_layout_failure_new_output): Deleted.
3577         (test_jsc_stress_failure_new_output): Deleted.
3578         (test_js_crashes_and_jsc_stress_failures_new_output): Deleted.
3579
3580 2014-08-19  Alexey Proskuryakov  <ap@apple.com>
3581
3582         build.webkit.org/dashboard should not request 50 revisions from trac each time
3583         https://bugs.webkit.org/show_bug.cgi?id=127130
3584
3585         build.webkit.org/dashboard sometimes fetches a Trac revision in an intermediate state, and never updates later
3586         https://bugs.webkit.org/show_bug.cgi?id=127131
3587
3588         Reviewed by Timothy Hatcher.
3589
3590         Turns out that requesting 50 builds is much slower than requesting by date - even
3591         if the request ends up returning more than 50 results. There is no way to only
3592         request updates, but this change brings request time from 6-8 seconds down to
3593         less than a second.
3594
3595         This patch generalizes date handling for later use in metrics code. As part of the
3596         rewrite, I made newly fetched data update author e-mail in previously fetched
3597         revisions, as it changes after commit queue first lands.
3598
3599         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3600         Updated for event rename. I changed the trac event to not contain the list of new
3601         commits, as we now sometimes update old commits, and that couldn't be expressed
3602         in event data. We never used the list anywhere in the first place.
3603
3604         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3605         (Trac.prototype._xmlTimelineURL): Made this function take arbitrary dates. When called
3606         without arguments, return commits for today and yesterday.
3607         (Trac.prototype._loaded):
3608         (Trac.prototype.update): Moved the function for processing loaded results out of
3609         here for clarity, and also because I'm going to have a separate loading code path
3610         for metrics.
3611
3612 2014-08-18  Dan Bernstein  <mitz@apple.com>
3613
3614         Added an update-webkit option to override the ../Internal check.
3615         Part of https://bugs.webkit.org/show_bug.cgi?id=135815
3616
3617         Reviewed by Tim Horton.
3618
3619         * Scripts/update-webkit:
3620         Added an explicit --internal option to control updating ../Internal, defaulting to whether
3621         ../Internal exists.
3622         (runSvnUpdate): Moved to webkitdirs.pm.
3623         (runGitUpdate): Ditto.
3624         * Scripts/webkitdirs.pm:
3625         (runSvnUpdateAndResolveChangeLogs): Moved runSvnUpdate from update-webkit and renamed to this.
3626         (runGitUpdate): Moved from update-webkit.
3627
3628 2014-08-18  Pratik Solanki  <psolanki@apple.com>
3629
3630         Make update-webkit more lenient for pure git svn repositories
3631         https://bugs.webkit.org/show_bug.cgi?id=135805
3632
3633         Reviewed by Oliver Hunt.
3634
3635         Make the call to git fetch be non fatal. If you have a pure git svn repository, then the
3636         call to git&nbs