2011-06-27 Adam Barth <abarth@webkit.org>
[WebKit-https.git] / Tools / ChangeLog
1 2011-06-27  Adam Barth  <abarth@webkit.org>
2
3         Reviewed by Eric Seidel.
4
5         Move deduplicate_tests.py into webkitpy.to_be_moved
6         https://bugs.webkit.org/show_bug.cgi?id=63426
7
8         deduplicate_tests.py doesn't haven anything to do with layout tests.
9         It's really a separate script.  This patch moves it to the (new)
10         to_be_moved package so that it doesn't distract us when working on NRWT.
11
12         * Scripts/deduplicate-tests:
13         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Removed.
14         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: Removed.
15         * Scripts/webkitpy/test/main.py:
16         * Scripts/webkitpy/to_be_moved: Added.
17         * Scripts/webkitpy/to_be_moved/__init__.py: Added.
18         * Scripts/webkitpy/to_be_moved/deduplicate_tests.py: Copied from Tools/Scripts/webkitpy/layout_tests/deduplicate_tests.py.
19         * Scripts/webkitpy/to_be_moved/deduplicate_tests_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py.
20
21 2011-06-26  Adam Barth  <abarth@webkit.org>
22
23         Rubber-stamped by Eric Seidel.
24
25         Remove empty directory.
26
27         * Scripts/webkitpy/layout_tests/test_types: Removed.
28
29 2011-06-25  Naoki Takano  <honten@chromium.org>
30
31         Reviewed by Eric Seidel.
32
33         Change my entry from contributors to committers.
34         https://bugs.webkit.org/show_bug.cgi?id=63043
35
36         * Scripts/webkitpy/common/config/committers.py: Change my e-mail from takano.naoki@gmail.com to honten@chromium.org. And move the entry to commiters from contributors.
37
38 2011-06-25  Adam Barth  <abarth@webkit.org>
39
40         Reviewed by Eric Seidel.
41
42         [Chromium] Update WebKit for WEBKIT_FRAME_TO_DOCUMENT_API_MOVE
43         https://bugs.webkit.org/show_bug.cgi?id=63394
44
45         * DumpRenderTree/chromium/LayoutTestController.cpp:
46         (LayoutTestController::queueLoad):
47
48 2011-06-25  Brent Fulgham  <bfulgham@webkit.org>
49
50         Unreviewed build correction after r89426.
51
52         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops:
53           Link with Cairo DLL for new functionality.
54         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Include compatibility
55           code for snprintf.
56
57 2011-06-25  Dimitri Glazkov  <dglazkov@chromium.org>
58
59         Reviewed by Adam Barth.
60
61         run-bindings-tests does not work on Chromium Windows.
62         https://bugs.webkit.org/show_bug.cgi?id=63382
63
64         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed run-bindings-tests as a build step for cr-win.
65
66 2011-06-25  Dan Bernstein  <mitz@apple.com>
67
68         Try to fix the Qt and Chromium builds.
69
70         * DumpRenderTree/chromium/LayoutTestController.cpp:
71         (LayoutTestController::setEncodedAudioData):
72         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
73
74 2011-06-24  Dan Bernstein  <mitz@apple.com>
75
76         Reviewed by Anders Carlsson.
77
78         Add an option to enable legacy rounding hacks
79         https://bugs.webkit.org/show_bug.cgi?id=63363
80
81         Added layoutTestController.allowRoundingHacks() and implemented it
82         on OS X.
83
84         * DumpRenderTree/LayoutTestController.cpp:
85         (allowRoundingHacksCallback):
86         (LayoutTestController::staticFunctions):
87         * DumpRenderTree/LayoutTestController.h:
88         * DumpRenderTree/chromium/LayoutTestController.cpp:
89         (LayoutTestController::allowRoundingHacks):
90         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
91         (LayoutTestController::allowRoundingHacks):
92         * DumpRenderTree/mac/DumpRenderTree.mm:
93         (resetWebViewToConsistentStateBeforeTesting):
94         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
95         (LayoutTestController::allowRoundingHacks):
96         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
97         (LayoutTestController::allowRoundingHacks):
98         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
99         (LayoutTestController::allowRoundingHacks):
100         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
101         (LayoutTestController::allowRoundingHacks):
102
103 2011-06-24  Adam Roben  <aroben@apple.com>
104
105         Include the directory containing the failing tests in titles of bugs filed from TestFailures
106         when all the tests won't fit
107
108         Fixes <http://webkit.org/b/63350> Short bug titles from TestFailures page give no indication
109         which tests are failing
110
111         Reviewed by David Kilzer.
112
113         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
114         (longestCommonPathPrefix): Added. Given a set of paths, returns the longest common prefix
115         that ends in a path separator.
116
117         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
118         (ViewController.prototype._domForNewAndExistingBugs): When we can't fit all the test names
119         in the title, first try to include the longest common prefix of the test names, then, if
120         that's still too long or there's no common prefix, fall back to not including any
121         information about which tests are failing.
122
123 2011-06-24  Adam Roben  <aroben@apple.com>
124
125         Include links to Trac in bugs filed from TestFailures
126
127         Fixes <http://webkit.org/b/63348> Bugs filed from TestFailures page should include links to
128         Trac for suspect revisions
129
130         Reviewed by David Kilzer.
131
132         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
133         (Trac.prototype.changesetURL): New function, returns the URL for a particular revision in
134         Trac.
135
136         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
137         (ViewController.prototype._domForNewAndExistingBugs): If there's only one suspect revision,
138         include a link to Trac for it in the first sentence of the description. Otherwise include a
139         link to the suspect range after the list of failing tests.
140
141 2011-06-24  Nat Duca  <nduca@chromium.org>
142
143         Unreviewed, rolling out r89694.
144         http://trac.webkit.org/changeset/89694
145         https://bugs.webkit.org/show_bug.cgi?id=58408
146
147         Test shell still not ready for animate changes.
148
149         * DumpRenderTree/chromium/WebViewHost.cpp:
150         (WebViewHost::paintInvalidatedRegion):
151
152 2011-06-24  Adam Roben  <aroben@apple.com>
153
154         Fix typos introduced in r89696
155
156         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
157         (Builder.prototype.getNumberOfFailingTests): Pass the result data's constituent parts to the
158         callback, since that's what it expects.
159
160 2011-06-24  Adam Roben  <aroben@apple.com>
161
162         Make TestFailures correctly remember whether old-run-webkit-tests exited early
163
164         Fixes <http://webkit.org/b/63342> TestFailures page incorrectly claims test run ran to
165         completion after reload
166
167         Reviewed by David Kilzer.
168
169         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
170         (Builder.prototype.getNumberOfFailingTests): Instead of just storing the number of failures
171         in the PeristentCache, store an object that contains both the number of failures and whether
172         old-run-webkit-tests exited early.
173
174 2011-06-24  Adam Roben  <aroben@apple.com>
175
176         Add links to regression ranges in Trac to the TestFailures page
177
178         Fixes <http://webkit.org/b/61060> <rdar://problem/9452153> TestFailures page should provide
179         links to regression ranges in Trac
180
181         Reviewed by David Kilzer.
182
183         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Added.
184         (Trac): This new class represents a particular instance of Trac for a single project.
185         (Trac.prototype.logURL): Returns the URL that can be used to see the log of the given
186         repository path between the two specified revisions
187         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
188         (ViewController): Added new trac argument.
189         (ViewController.prototype._displayBuilder): Moved code to create the DOM for the
190         passed/failed builds from here...
191         (ViewController.prototype._domForRegressionRange): ...to here. Now also includes a link to
192         Trac if there are multiple suspect revisions.
193
194         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
195         Trac.js and pass a Trac instance for trac.webkit.org to the ViewController.
196
197 2011-05-17  Nat Duca  <nduca@chromium.org>
198
199         Reviewed by James Robinson.
200
201         [chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
202         https://bugs.webkit.org/show_bug.cgi?id=58408
203
204         * DumpRenderTree/chromium/WebViewHost.cpp:
205         (WebViewHost::paintInvalidatedRegion):
206
207 2011-06-24  Dominic Cooney   <dominicc@chromium.org>
208
209         Reviewed by Dimitri Glazkov.
210
211         Convert shadow DOM-related tests to use window.internals
212         https://bugs.webkit.org/show_bug.cgi?id=61671
213
214         Remove ensureShadowRoot, shadowRoot, shadowPseudoId and
215         removeShadowRoot from layoutTestController; these have been
216         replaced by equivalents in window.internals instead.
217
218         * DumpRenderTree/LayoutTestController.cpp:
219         (LayoutTestController::staticFunctions):
220         * DumpRenderTree/LayoutTestController.h:
221         * DumpRenderTree/chromium/LayoutTestController.cpp:
222         (LayoutTestController::LayoutTestController):
223         * DumpRenderTree/chromium/LayoutTestController.h:
224         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
225         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
226         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
227         * DumpRenderTree/qt/LayoutTestControllerQt.h:
228         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
229         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
230         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
231         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
232         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
233
234 2011-06-24  Csaba Osztrogonác  <ossy@webkit.org>
235
236         Reviewed by Dirk Schulze.
237
238         Make run-bindings-tests remove its temporary directories.
239         https://bugs.webkit.org/show_bug.cgi?id=63320
240
241         * Scripts/run-bindings-tests:
242
243 2011-06-23  MORITA Hajime  <morrita@google.com>
244
245         Reviewed by Kent Tamura.
246
247         [Chromium] Invalid write inside WebKit::FrameLoaderClientImpl::dispatchDidClearWindowObjectInWorld
248         https://bugs.webkit.org/show_bug.cgi?id=63216
249
250         Deleted m_webViewHost which looks leaked.
251         
252         * DumpRenderTree/chromium/TestShell.h:
253         * DumpRenderTree/chromium/TestShell.cpp:
254         (TestShell::~TestShell):
255
256 2011-06-24  Carlos Garcia Campos  <cgarcia@igalia.com>
257
258         Unreviewed. Fix WebKit2 GTK build.
259
260         * WebKitTestRunner/GNUmakefile.am:
261
262 2011-06-23  Ryuan Choi  <ryuan.choi@samsung.com>
263
264         Unreviewed, add myself as committer.
265
266         * Scripts/webkitpy/common/config/committers.py:
267
268 2011-06-23  Nat Duca  <nduca@chromium.org>
269
270         Unreviewed, add myself as committer.
271
272         * Scripts/webkitpy/common/config/committers.py:
273
274 2011-06-23  Dirk Pranke  <dpranke@chromium.org>
275
276         Reviewed by Tony Chang.
277
278         nrwt: move http locking code into manager
279         https://bugs.webkit.org/show_bug.cgi?id=63103
280
281         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
282         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
283
284 2011-06-23  Alok Priyadarshi  <alokp@chromium.org>
285
286         Reviewed by James Robinson.
287
288         [chromium] Add support for running layout tests with accelerated rendering
289         https://bugs.webkit.org/show_bug.cgi?id=63274
290
291         * Scripts/webkitpy/layout_tests/port/chromium.py:
292         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
293
294 2011-06-23  Adam Roben  <aroben@apple.com>
295
296         Avoid fetching JSON data when possible on TestFailures page to determine if
297         old-run-webkit-tests exited early
298
299         As of r89610, results.html includes information about whether old-run-webkit-tests exited
300         early, so we don't need to look at JSON data to get this information for builds newer than
301         that.
302
303         Fixes <http://webkit.org/b/63281> TestFailures page fetches build JSON for every build,
304         which is slow and limits history to the last build master restart
305
306         Reviewed by David Kilzer.
307
308         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
309         (Builder.prototype._getFailingTests): Moved code dealing with results.html into a new
310         function. If we're dealing with a build that has early-exit information in results.html,
311         don't bother fetching JSON data and go straight to parsing results.html. Otherwise first use
312         the JSON data to determine if old-run-webkit-tests exited early, and then parse results.html
313         (as before).
314
315 2011-06-23  Eric Seidel  <eric@webkit.org>
316
317         Reviewed by Adam Barth.
318
319         sheriffbot can no longer restart
320         https://bugs.webkit.org/show_bug.cgi?id=63221
321
322         Fixed and unit tested.
323
324         * Scripts/webkitpy/tool/bot/queueengine.py:
325         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
326         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
327
328 2011-06-23  Martin Robinson  <mrobinson@igalia.com>
329
330         Reviewed by Xan Lopez.
331
332         [GTK] [WebKit2] WebKitTestRunner does not properly load TestNetscapePlugin
333         https://bugs.webkit.org/show_bug.cgi?id=63287
334
335         Send the path to the TestNetscapePlugin to the WKTR via an environment variable
336         so that the plugin loads properly.
337
338         * Scripts/old-run-webkit-tests: Pass the appropriate environment variable to WKTR.
339         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
340         (WTR::getEnvironmentVariableAsUTF8String): Added this helper which abstracts away some
341         of the work for getting an environment variable and converting it to UTF-8.
342         (WTR::TestController::initializeInjectedBundlePath): Use the helper.
343         (WTR::TestController::initializeTestPluginDirectory): Get the path from an environment variable now.
344
345 2011-06-23  Adam Roben  <aroben@apple.com>
346
347         Record whether old-run-webkit-tests aborted early in results.html
348
349         Fixes <http://webkit.org/b/63280> results.html gives no indication of whether
350         old-run-webkit-tests stopped running tests early
351
352         Reviewed by David Kilzer.
353
354         * Scripts/old-run-webkit-tests:
355         (top level): Switched to heredoc syntax for printing the start of results.html for clarity.
356         Added a <style> element with some styles for the new message. If we stopped running early,
357         put the reason why at the top of results.html.
358         (stopRunningTestsEarlyIfNeeded): Store the message we print in the new
359         $stoppedRunningEarlyMessage global.
360
361 2011-06-23  Adam Roben  <aroben@apple.com>
362
363         Cache some of the TestFailures page's data in localStorage
364
365         This makes reloading TestFailures much faster. Right now we only store the number of failing
366         tests and the list of failing tests for each build. We may choose to store more later, but
367         it's easy to run up against quota limits.
368
369         Fixes <http://webkit.org/b/61520> TestFailures page should take advantage of LocalStorage
370         APIs (or similar) to improve loading performance
371
372         Reviewed by David Kilzer.
373
374         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
375         (Builder.prototype.getNumberOfFailingTests): Changed to use the new PersistentCache object.
376         (Builder.prototype.startFetchingBuildHistory): Changed to pass whether or not we're still
377         fetching data to the callback.
378         (Builder.prototype._getFailingTests): Changed to use the new PersistentCache object. We now
379         store the tests in the cache just before calling the callback. (The previous code in this
380         function relied on being able to modify the tests object after storing it in the cache and
381         having the cached version be updated. This worked while it was a non-serialized cache, but
382         PersistentCache uses serialization.)
383
384         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js: Added.
385         (PersistentCache): This object wraps localStorage. It uses JSON to serialize/deserialize
386         values, and stores the date that each value was initially stored along with it. This is
387         later used for pruning the cache.
388         (PersistentCache.contains): Checks whether the key exists in localStorage.
389         (PersistentCache.get): Fetch the string we stored in localStorage and extract the original
390         value out of it.
391         (PersistentCache.set): Serialize the value, add the date to it, and store it in
392         localStorage. If this fails due to quota limits, empty the whole cache and try again.
393         (PersistentCache.prune): Delete any cached data that is deemed old enough.
394         (PersistentCache._addDateToJSONString): Prepend the current date to the string.
395         (PersistentCache._emptyCache): Delete everything from localStorage.
396         (PersistentCache._parseDateAndJSONFromString): Split apart the date and the JSON string and
397         return them.
398
399         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
400         (ViewController.prototype._displayBuilder): Updated for change to callback signature. When
401         we finish fetching data, prune the PersistentCache. While I was here I also fixed a bug
402         where we'd never show the new bug link for tests for which we couldn't determine a passing
403         revision.
404
405         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
406         PersistentCache.js.
407
408 2011-06-23  Adam Roben  <aroben@apple.com>
409
410         Make finding existing bugs and filing new bugs work on TestFailures even when lots of tests are failing
411
412         One bug this fixes is <http://webkit.org/b/61660> New bug links on TestFailures page often
413         contain titles that are so long they are rejected by Bugzilla
414
415         Reviewed by David Kilzer.
416
417         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
418         (Bugzilla.prototype.quickSearch): Use fetchResource to POST the search query rather than
419         using a query string on the URL. If the search query is very long, using a query string can
420         cause the request to be rejected due to the URL being too long. POSTing avoids this issue.
421         (Bugzilla.maximumBugTitleLength): Added this constant based on Bugzilla's implementation.
422
423         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
424         (.new-bug-form): Hide the form that we secretly use to file a new bug.
425
426         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
427         (fetchResource): Added. Code came from getResource. If we're using a GET request, add the
428         query parameters to the URL. Otherwise, send them as the body of the request along with the
429         appropriate headers.
430         (getResource): Now just calls through to fetchResource.
431         (urlEncodedQueryParameters): Added. Moved some code here...
432         (addQueryParametersToURL): ...from here.
433
434         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
435         (ViewController.prototype._domForNewAndExistingBugs): Shorten the title to just mention the
436         number of failing tests if mentioning all the tests would make the title too long. Improved
437         the description for large numbers of failures by listing the tests one-per-line instead of
438         just having them be comma-separated, which was hard to read. Use a form to file the new bug
439         instead of a link so that we can POST the form data. (Using a URL with a query string can
440         result in the URL being too long.) The new bug link now just submits the form.
441
442 2011-06-23  Adam Roben  <aroben@apple.com>
443
444         Show closed bugs on the TestFailures page in addition to open ones
445
446         Fixes <http://webkit.org/b/63194> TestFailures page should show closed bugs, too
447
448         Reviewed by David Kilzer.
449
450         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
451         (Bugzilla.prototype.quickSearch): Added code to extract the bug's status and store it in the
452         returned data.
453         (Bugzilla.isOpenStatus): New function, returns true if the passed-in status indicates that
454         the associated bug is still open.
455
456         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
457         (addQueryParametersToURL): Add a missing semicolon.
458         (Node.prototype.appendChildren): New function, like appendChild but takes an array-like
459         object and appends each of the values stored within.
460
461         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
462         (ViewController.prototype._domForNewAndExistingBugs): Prepend 'ALL' to the query so closed
463         bugs will be included in the results. Split the returned bugs into two sets: those which are
464         open, and those which are closed. Put the open bugs at the top level of the list, and the
465         closed bugs in a second level.
466
467 2011-06-23  Adam Roben  <aroben@apple.com>
468
469         Don't count new tests as failures on the TestFailures page
470
471         Fixes <http://webkit.org/b/63254> TestFailures page calls new tests "failures", even though
472         they aren't
473
474         Reviewed by Anders Carlsson.
475
476         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
477         (Builder.prototype.getNumberOfFailingTests): Don't add the number of new tests to the number
478         of failures.
479
480 2011-06-23  Dirk Pranke  <dpranke@chromium.org>
481
482         Reviewed by Eric Seidel.
483
484         nrwt: make TestInput objects printable
485         https://bugs.webkit.org/show_bug.cgi?id=63225
486
487         This makes debugging slighlty easier.
488
489         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
490
491 2011-06-22  Daniel Bates  <dbates@webkit.org>
492
493         Reviewed by Adam Barth.
494
495         test-webkitpy --all errors out because scm_unittest.py can't find module checkout
496         https://bugs.webkit.org/show_bug.cgi?id=62943
497
498         Remove "from .checkout import Checkout" from scm_unittest.py since it's included
499         by Scripts/webkitpy/common/checkout/__init__.py.
500
501         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
502
503 2011-06-22  Dominic Cooney  <dominicc@chromium.org>
504
505         Reviewed by Mark Rowe.
506
507         Add window.internals to WebKit2's WebKitTestRunner.
508         https://bugs.webkit.org/show_bug.cgi?id=61073
509
510         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pxbproj:
511         * WebKitTestRunner/Configurations/Base.xcconfig:
512         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
513         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
514         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
515         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
516         (WTR::InjectedBundlePage::didClearWindowForFrame):
517         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
518         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
519
520 2011-06-22  Eric Seidel  <eric@webkit.org>
521
522         Reviewed by Adam Barth.
523
524         Make sheriff-bot rollout messages a little nicer
525         https://bugs.webkit.org/show_bug.cgi?id=63107
526
527         itertools.chain.from_iterable is new in 2.6,
528         use itertools.chain(*list) for 2.5 compat.
529
530         * Scripts/webkitpy/tool/bot/irc_command.py:
531
532 2011-06-22  Eric Seidel  <eric@webkit.org>
533
534         Reviewed by Adam Barth.
535
536         Make sheriff-bot robust against exceptions from commands
537         https://bugs.webkit.org/show_bug.cgi?id=63211
538
539         sheriff-bot was acting strange this afternoon.
540         We don't know if this will fix the cause, but
541         at least it adds some unit tests and catches
542         one possible cause.
543
544         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
545         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
546
547 2011-06-22  Mark Rowe  <mrowe@apple.com>
548
549         Reviewed by David Levin.
550
551         <http://webkit.org/b/63212> TestWebKitAPI Xcode project has bogus settings since r86287
552
553         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Fix the reference to libgtest.a to
554         be relative to the built products directory rather than using a hard-coded path. Remove the
555         explicit settings of FRAMEWORK_SEARCH_PATHS, HEADER_SEARCH_PATHS and LIBRARY_SEARCH_PATHS
556         as they're all unnecessary. If they were necessary they should be set in the .xcconfig file
557         rather than in the .xcodeproj directly.
558
559 2011-06-22  Dirk Pranke  <dpranke@chromium.org>
560
561         Reviewed by Ojan Vafai.
562
563         new-run-webkit-tests: remove obsolete port.shut_down_http_server method
564         https://bugs.webkit.org/show_bug.cgi?id=59993
565
566         * Scripts/webkitpy/layout_tests/port/base.py:
567         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
568         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
569         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
570         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
571         * Scripts/webkitpy/layout_tests/port/gtk.py:
572         * Scripts/webkitpy/layout_tests/port/mac.py:
573         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
574         * Scripts/webkitpy/layout_tests/port/qt.py:
575         * Scripts/webkitpy/layout_tests/port/win.py:
576
577 2011-06-22  Luke Macpherson   <macpherson@chromium.org>
578
579         Reviewed by Andreas Kling.
580
581         Move macpherson from contributor list to committer list.
582         https://bugs.webkit.org/show_bug.cgi?id=63179
583
584         * Scripts/webkitpy/common/config/committers.py:
585         Move macpherson from contributor list to committer list.
586
587 2011-06-22  David Levin  <levin@chromium.org>
588
589         Reviewed by Adam Barth.
590
591         check-webkit-style should detect returning (Own|Ref)Ptr instead of the Pass*Ptr version.
592         https://bugs.webkit.org/show_bug.cgi?id=63204
593
594         * Scripts/webkitpy/style/checkers/cpp.py: Added a check for the return value and combined
595           with similar code for the parameter checking.
596         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Removed pass_ptr checks from
597           those done for single lines since they don't make sense in that case (variable decls look like function decls).
598           Removed some redundant comments (one of which was slightly wrong).
599           Added checks for the new functionality and minor other test changes.
600
601 2011-06-22  Nate Chapin  <japhet@chromium.org>
602
603         Reviewed by Adam Barth.
604
605         Add libsoup to libWebCoreInternals build.
606         https://bugs.webkit.org/show_bug.cgi?id=62066
607
608         * GNUmakefile.am:
609
610 2011-06-22  Dirk Pranke  <dpranke@chromium.org>
611
612         Reviewed by Tony Chang.
613
614         nrwt: handle missing httpd cleanly
615         https://bugs.webkit.org/show_bug.cgi?id=62027
616
617         We had reverted the change in r89414, so this adds it back in
618         (modifying check_sys_deps() in port/base.py to check for an
619         installed web server).
620
621         This change then fixes the change in r89414 to stub out the
622         check_sys_deps() in the test port so that the unit tests run correctly.
623
624         * Scripts/webkitpy/layout_tests/port/base.py:
625         * Scripts/webkitpy/layout_tests/port/test.py:
626
627 2011-06-22  David Levin  <levin@chromium.org>
628
629         Reviewed by Adam Barth.
630
631         check-webkit-style should check for invalid uses of RefPtr/OwnPtr as parameters.
632         https://bugs.webkit.org/show_bug.cgi?id=63188
633
634         * Scripts/webkitpy/style/checkers/cpp.py: Added the check.
635         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
636
637 2011-06-22  Tony Chang  <tony@chromium.org>
638
639         Reviewed by Ojan Vafai.
640
641         Add a buildbot for testing ENABLE(CSS3_FLEXBOX)
642         https://bugs.webkit.org/show_bug.cgi?id=62891
643
644         * BuildSlaveSupport/build.webkit.org-config/config.json:
645
646 2011-06-22  Dirk Pranke  <dpranke@chromium.org>
647
648         Reviewed by Ojan Vafai.
649
650         nrwt: don't look for http lock when running the test port
651         https://bugs.webkit.org/show_bug.cgi?id=63158
652
653         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
654         * Scripts/webkitpy/layout_tests/port/test.py:
655
656 2011-06-22  Balazs Kelemen  <kbalazs@webkit.org>
657
658         Reviewed by Andreas Kling.
659
660         [Qt][WK2] Set up plugin tests
661         https://bugs.webkit.org/show_bug.cgi?id=63066
662
663         * WebKitTestRunner/qt/TestControllerQt.cpp:
664         (WTR::TestController::initializeTestPluginDirectory):
665         Use the QTWEBKIT_PLUGIN_PATH environment variable as the path
666         of the test plugin like DRT does.
667
668 2011-06-22  Eric Seidel  <eric@webkit.org>
669
670         Reviewed by Ojan Vafai.
671
672         Make sheriff-bot rollout messages a little nicer
673         https://bugs.webkit.org/show_bug.cgi?id=63107
674
675         It annoyed me this afternoon that I had to convert sheriff-bots "r12345" revisions
676         into urls myself.  So I have now fixed its "preparing" message to include a url.
677
678         I also figured that I should make the messages mention all of the responsible parties
679         so that rollouts are never surprises.  If you're in the channel and were involved
680         in a patch, you will see if someone is using sheriff-bot to rollout a patch.
681
682         As part of doing this I also changed (and tested) _parse_args to fail-fast
683         when given invalid args.
684
685         * Scripts/webkitpy/tool/bot/irc_command.py:
686         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
687         * Scripts/webkitpy/tool/bot/sheriff.py:
688         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
689
690 2011-06-22  Dirk Pranke  <dpranke@chromium.org>
691
692         Reviewed by Tony Chang.
693
694         run-webkit-websocketserver fails to stop websocket server
695         https://bugs.webkit.org/show_bug.cgi?id=63123
696
697         There's a ten-character change in new-run-webkit-websocketserver
698         that fixes the actual bug, and then we update the code in
699         new-run-webkit-httpd to do the actual stop call, and add more tests
700         (refactoring the existing test code so that it is shared).
701
702         * Scripts/new-run-webkit-httpd:
703         * Scripts/new-run-webkit-websocketserver:
704         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py:
705
706 2011-06-22  Adam Roben  <aroben@apple.com>
707
708         Add links to existing bugs related to failing tests on TestFailures page
709
710         I changed the layout of the page a little to make it easier to read with all the new
711         information. Passing/failing revisions have been moved down below the list of tests to be
712         closer to the existing bugs and the new bug link. And each set of tests and its relevant
713         information is in a light gray box.
714
715         Fixes <http://webkit.org/b/61665> TestFailures page should link to existing bugs when
716         possible
717
718         Reviewed by Darin Adler.
719
720         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js: Added.
721         (Bugzilla): This new class represents a single Bugzilla instance.
722         (Bugzilla.prototype.quickSearch): Searches Bugzilla using its Quick Search functionality,
723         passing the resulting bug titles and URLs to the callback when complete. If called multiple
724         times with the same query before the query returns, caches the callbacks so that only one
725         query is sent over the wire. When the query completes, all pending callbacks are called.
726
727         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
728         (#failure-history): Reduce the margin/padding on the top-level list a bit.
729         (#failure-history > li): Put each set of tests in a gray box, and indent most information
730         inside the box.
731         (.test-list): Unindent the list of failing tests so it is visually at the top level.
732         (.new-and-existing-bugs): Reduce the space at the bottom of this area so that the bottom of
733         each box isn't a big empty space.
734         (.existing-bugs-list): Use a smaller text size for existing bugs, since their titles can be
735         quite long.
736
737         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
738         (addQueryParametersToURL): New function extracted from
739         ViewController.prototype._domForNewAndExistingBugs.
740
741         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
742         (ViewController): Take and store an optional Bugzilla instance.
743         (ViewController.prototype._displayBuilder): Give the top-level list an id for styling
744         purposes and move the list of failing tests above all other information. Only show bug
745         information once we've determined the most-recent passing revision for a set of tests. It's
746         not that useful to file a new bug before this information has been determined, and searching
747         for existing bugs before we've figured out which tests started failing at the same time
748         would end up giving you information about a bunch of unrelated tests.
749         (ViewController.prototype._domForNewAndExistingBugs): Renamed from _domForNewBugLink. Now
750         returns a DocumentFragment instead of an HTMLParagraphElement. If we don't have a Bugzilla
751         instance, just returns an empty DocumentFragment. Starts a search for bugs related to the
752         failing tests, and adds links to the bugs when the search completes.
753
754         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pass a
755         Bugzilla instance for bugs.webkit.org to the ViewController.
756
757 2011-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
758
759         Reviewed by Martin Robinson.
760
761         [GTK] Apply current view settings to newly created views in GtkLauncher
762         https://bugs.webkit.org/show_bug.cgi?id=63142
763
764         * GtkLauncher/main.c:
765         (createWebViewCb):
766
767 2011-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
768
769         Reviewed by Martin Robinson.
770
771         [GTK] Use GOption to parse main arguments in GtkLauncher
772         https://bugs.webkit.org/show_bug.cgi?id=63060
773
774         Instead of getting the settings from the view, create a new
775         settings object not associated with any view so that we can parse
776         the command line arguments before creating the view. It will also
777         allows to use the same settings for more than one view if we
778         eventually support passing more than one uri from the command
779         line.
780
781         * GtkLauncher/main.c:
782         (parseOptionEntryCallback): Make this function static. Also use
783         g_ascii_strtoll/g_ascii_strtod to parse int/float values instead
784         of atoi/atof to provide better error messages. And always fill the
785         error struct when the function fails.
786         (getOptionEntriesFromWebKitWebSettings): Use an array of
787         GOptionEntry structs instead of a GArray, since that is what
788         g_option_group_add_entries() expects and the array size doesn't
789         change.
790         (addWebSettingsGroupToContext): Helper function to add the
791         websettings group to the option context.
792         (main): Create the option context to parse command line arguments.
793
794 2011-06-22  Martin Robinson  <mrobinson@igalia.com>
795
796         Reviewed by Adam Roben.
797
798         [GTK] Implement pixel dump support for WebKitTestRunner
799         https://bugs.webkit.org/show_bug.cgi?id=58242
800
801         * DumpRenderTree/gtk/GNUmakefile.ImageDiff.am: Added.
802         * GNUmakefile.am: Separate out the ImageDiff bits of the GNUmakefile.
803         * Scripts/old-run-webkit-tests: Update to add support for the GTK+ port.
804         * WebKitTestRunner/GNUmakefile.am: Added Cairo specific files to the build.
805         * WebKitTestRunner/TestInvocation.cpp: Moved this code to the platform-independent
806         file so that we can share it across platforms.
807         (WTR::TestInvocation::compareActualHashToExpectedAndDumpResults):
808         * WebKitTestRunner/TestInvocation.h: Updated method list.
809         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added Cairo implementation.
810         * WebKitTestRunner/cg/TestInvocationCG.cpp:
811         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Updated to use new helper.
812
813 2011-06-22  Sheriff Bot  <webkit.review.bot@gmail.com>
814
815         Unreviewed, rolling out r89414.
816         http://trac.webkit.org/changeset/89414
817         https://bugs.webkit.org/show_bug.cgi?id=63130
818
819         It broke webkitpy tests (Requested by Ossy on #webkit).
820
821         * Scripts/webkitpy/layout_tests/port/base.py:
822
823 2011-06-22  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
824
825         Reviewed by Dirk Pranke.
826
827         [NRWT] Print error message when there is no httpd present on the system
828         https://bugs.webkit.org/show_bug.cgi?id=62027
829
830         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
831
832 2011-06-21  Dirk Pranke  <dpranke@chromium.org>
833
834         Unreviewed, build fix.
835         Fix crashes in new-run-webkit-tests resulting from the
836         change to the http_server logic in r89400. Python 2.5
837         on Mac 10.5 has some weird error paths.
838
839         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
840         * Scripts/webkitpy/common/system/executive.py:
841
842 2011-06-21  MORITA Hajime  <morrita@google.com>
843
844         Unreviewed, rolling out r89401 and r89403.
845         http://trac.webkit.org/changeset/89401
846         http://trac.webkit.org/changeset/89403
847         https://bugs.webkit.org/show_bug.cgi?id=62970
848
849         Breaks mac build and mistakenly enables the spellcheck API
850
851         * Scripts/build-webkit:
852         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
853
854 2011-06-21  Kent Tamura  <tkent@chromium.org>
855
856         [Mac] Sort Xcode project files.
857
858         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
859
860 2011-06-20  MORITA Hajime  <morrita@google.com>
861
862         Reviewed by Kent Tamura.
863
864         Spellcheck API should be build-able.
865         https://bugs.webkit.org/show_bug.cgi?id=62970
866
867         * Scripts/build-webkit:
868
869 2011-06-21  Dirk Pranke  <dpranke@chromium.org>
870
871         Reviewed by Tony Chang.
872
873         nrwt: attempt #3 at fixing server startup/shutdown
874         https://bugs.webkit.org/show_bug.cgi?id=62829
875
876         Attempt yet again to make starting and stopping servers
877         reliable. It turns out that apache has races between when the
878         ctl process exists and when it writes/removes the pid file.
879         This change accounts for the races.
880
881         * Scripts/new-run-webkit-httpd:
882         * Scripts/webkitpy/common/system/executive.py:
883         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
884         * Scripts/webkitpy/layout_tests/port/base.py:
885         * Scripts/webkitpy/layout_tests/port/http_server.py:
886         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
887         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
888         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
889         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
890
891 2011-06-21  Dmitry Lomov  <dslomov@google.com>
892
893         Reviewed by Adam Roben.
894
895         https://bugs.webkit.org/show_bug.cgi?id=63080
896         Unit-tests step on test-only bot is broken.
897         Removing the step until run-api-tests is fixed.
898
899         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
900
901 2011-06-20  Dmitry Lomov  <dslomov@google.com>
902
903         Reviewed by David Levin.
904
905         https://bugs.webkit.org/show_bug.cgi?id=63017
906         "Unit tests" step on bots should provide more information in case of failure.
907
908         * BuildSlaveSupport/build.webkit.org-config/master.cfg: added --verbose flag to UnitTests step.
909
910 2011-06-20  Dirk Pranke  <dpranke@chromium.org>
911
912         Reviewed by Ojan Vafai.
913
914         new-run-webkit-tests: order shards by name, not number of tests
915         https://bugs.webkit.org/show_bug.cgi?id=62753
916
917         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
918
919 2011-06-20  Dirk Pranke  <dpranke@chromium.org>
920
921         Reviewed by Ojan Vafai.
922
923         we should only log the test names to the tests_run.txt files during layout_tests
924         https://bugs.webkit.org/show_bug.cgi?id=62751
925
926         * Scripts/old-run-webkit-tests:
927         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
928
929 2011-06-20  Eric Seidel  <eric@webkit.org>
930
931         Reviewed by Adam Barth.
932
933         commit-queue/ews-bots should run run-bindings-tests for every patch
934         https://bugs.webkit.org/show_bug.cgi?id=63010
935
936         * Scripts/webkitpy/common/config/ports.py:
937         * Scripts/webkitpy/tool/commands/download_unittest.py:
938         * Scripts/webkitpy/tool/steps/runtests.py:
939         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
940         * Scripts/webkitpy/tool/steps/steps_unittest.py:
941
942 2011-06-20  Chang Shu  <cshu@webkit.org>
943
944         Reviewed by Adam Barth.
945
946         fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code tests fail when showModalDialog isn't supported
947         https://bugs.webkit.org/show_bug.cgi?id=53676
948
949         * WebKitTestRunner/TestController.cpp:
950         (WTR::TestController::initialize):
951
952 2011-06-20  Eric Seidel  <eric@webkit.org>
953
954         Reviewed by Adam Barth.
955
956         buildbots should run run-bindings-tests
957         https://bugs.webkit.org/show_bug.cgi?id=63001
958
959         run-bindings-tests takes 2.4 seconds on my machine, so
960         I expect this will not be noticeable on the bots.
961
962         I also removed tiger-specific checks since Tiger is no
963         longer a supported platform for webkit.
964
965         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
966
967 2011-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
968
969         Unreviewed. Fix WebKit2 GTK build after r89249.
970
971         * GtkLauncher/main.c:
972         (main):
973
974 2011-06-20  Pavel Feldman  <pfeldman@chromium.org>
975
976         Reviewed by Yury Semikhatsky.
977
978         Web Inspector: remove LayoutTestController::setTimelineProfilingEnabled.
979         https://bugs.webkit.org/show_bug.cgi?id=62994
980
981         * DumpRenderTree/LayoutTestController.cpp:
982         (closeWebInspectorCallback):
983         (LayoutTestController::staticFunctions):
984         * DumpRenderTree/LayoutTestController.h:
985         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
986         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
987         * DumpRenderTree/chromium/LayoutTestController.cpp:
988         (LayoutTestController::LayoutTestController):
989         * DumpRenderTree/chromium/LayoutTestController.h:
990         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
991         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
992         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
993         * DumpRenderTree/qt/LayoutTestControllerQt.h:
994         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
995         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
996         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
997         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
998         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
999
1000 2011-06-20  Lukasz Slachciak  <l.slachciak@samsung.com>
1001
1002         Reviewed by Martin Robinson.
1003
1004         [GTK] General mechanism for adjusting WebKitWebSettings in GtkLauncher.
1005         https://bugs.webkit.org/show_bug.cgi?id=55308
1006
1007         * GtkLauncher/main.c: Added general mechanism for adjusting WebKitWebSettings.
1008         (parseOptionEntryCallback): Callback for parsing option entry.
1009         (getOptionEntriesFromWebKitWebSettings): Basing on the WebKitWebSettings properties prepare
1010         list of option entries.
1011         (transformStringToBoolean): Transform function for boolean convertion used by parseOptionEntryCallback.
1012         (transformStringToInt): Transform function for int convertion used by parseOptionEntryCallback.
1013         (transformStringToFloat): Transform function for float convertion used by parseOptionEntryCallback.
1014         (parseAdditionalOptions): Help function parsing additional commandline options.
1015         (main): Added call to parseAdditionalOptions.
1016
1017 2011-06-20  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
1018
1019         Reviewed by Andreas Kling.
1020
1021         [Qt] [WK2] Compile error in ActivateFontsQt.cpp on Mac
1022         https://bugs.webkit.org/show_bug.cgi?id=62869
1023
1024         Add QFont include to fix "incomlete type QFont" error.
1025
1026         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1027
1028 2011-06-19  Adam Bergkvist  <adam.bergkvist@ericsson.com>
1029
1030         Reviewed by Martin Robinson.
1031
1032         [GTK] Enable Media Stream feature and make it default on
1033         https://bugs.webkit.org/show_bug.cgi?id=60394
1034
1035         * Scripts/build-webkit:
1036
1037 2011-06-19  Sheriff Bot  <webkit.review.bot@gmail.com>
1038
1039         Unreviewed, rolling out r89198.
1040         http://trac.webkit.org/changeset/89198
1041         https://bugs.webkit.org/show_bug.cgi?id=62953
1042
1043         Chromium breakage on "Linux Tests" (Requested by senorblanco
1044         on #webkit).
1045
1046         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1047         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1048         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1049
1050 2011-06-18  Daniel Bates  <dbates@webkit.org>
1051
1052         Reviewed by Eric Seidel.
1053
1054         Git.push_local_commits_to_server() should use passed username and
1055         password when we don't have cached credentials
1056         https://bugs.webkit.org/show_bug.cgi?id=62941
1057
1058         Fixes a issue where Git.push_local_commits_to_server() would always look
1059         for cached credentials regardless of whether a username and password
1060         were passed as arguments. Instead, if given both a username and password
1061         then we shouldn't look for cached credentials (since we were explicitly given
1062         credentials).
1063
1064         * Scripts/webkitpy/common/checkout/scm/git.py:
1065         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Added unit tests.
1066
1067 2011-06-18  Daniel Bates  <dbates@rim.com>
1068
1069         Rubber-stamped by Eric Seidel.
1070
1071         Remove run-javascriptcore-tests --skip-build option; Instead add --build/no-build options
1072         https://bugs.webkit.org/show_bug.cgi?id=62767
1073
1074         Part 3 of 3
1075
1076         Remove the command-line option --skip-build now that the master BuildBot has been restarted
1077         following <http://trac.webkit.org/changeset/89138>.
1078
1079         Instead, specify --no-build to get analogous functionality.
1080
1081         * Scripts/run-javascriptcore-tests:
1082
1083 2011-06-18  Dirk Pranke  <dpranke@chromium.org>
1084
1085         Reviewed by Tony Chang.
1086
1087         new-run-webkit-tests: fix test sorting
1088         https://bugs.webkit.org/show_bug.cgi?id=58691
1089
1090         This changes the sorting to use a "natural" sort order such that
1091         foo2.html sorts before foo13.html, and sorts the tests so
1092         that all the tests in a directory are run before any test in a
1093         subdirectory.
1094
1095         This change also adds a split() method to the filesystem since
1096         that is needed to cluster files into a directory otherwise.
1097
1098         * Scripts/webkitpy/common/system/filesystem.py:
1099         * Scripts/webkitpy/common/system/filesystem_mock.py:
1100         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1101         * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
1102
1103 2011-06-18  Evan Martin  <evan@chromium.org>
1104
1105         Reviewed by Darin Adler.
1106
1107         Compiler warning in double->int conversion in TestNetscapePlugIn
1108         https://bugs.webkit.org/show_bug.cgi?id=51554
1109
1110         This code is providing a JS API for removing a property by numeric ID.
1111         We get it from JS as a double, and must convert it to an int before using it.
1112
1113         Test: LayoutTests/plugins/npruntime/remove-property.html
1114
1115         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
1116         (NPRuntimeRemoveProperty::TestObject::invoke):
1117
1118 2011-06-18  Patrick Gansterer  <paroga@webkit.org>
1119
1120         Reviewed by Eric Seidel.
1121
1122         Don't exit webkit-patch when running on Win32 python
1123         https://bugs.webkit.org/show_bug.cgi?id=55811
1124
1125         Most of the basic actions work in the meantime,
1126         so let people play with in on Win32 now.
1127
1128         * Scripts/webkit-patch:
1129
1130 2011-06-18  Alice Boxhall  <aboxhall@chromium.org>
1131
1132         Reviewed by Ojan Vafai.
1133
1134         Convert json_results_generator.py to output version 4 JSON.
1135         https://bugs.webkit.org/show_bug.cgi?id=60869
1136
1137         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1138         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1139         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1140
1141 2011-06-18  Berend-Jan Wever  <skylined@chromium.org>
1142
1143         Reviewed by Eric Seidel.
1144
1145         Some names with spaces are incorrectly reported as not containing spaces
1146         while running prepare-ChangeLog
1147         https://bugs.webkit.org/show_bug.cgi?id=55572
1148
1149         * Scripts/VCSUtils.pm: Updated CHANGE_LOG_NAME check for spaces to allow
1150           non-alphanumeric characters in names.
1151
1152 2011-06-18  Michael Saboff  <msaboff@apple.com>
1153
1154         Reviewed by Eric Seidel.
1155
1156         Enhancement: New Script to Format malloc_history output as tree
1157         https://bugs.webkit.org/show_bug.cgi?id=56378
1158
1159         New script to process malloc_history output to tree format.
1160
1161         * Scripts/malloc-tree: Added.
1162
1163 2011-06-17  Dmitry Lomov  <dslomov@google.com>
1164
1165         Reviewed by Daniel Bates.
1166
1167         https://bugs.webkit.org/show_bug.cgi?id=62918 
1168         Pass configuration to UnitTests step in master.cfg
1169
1170         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1171
1172 2011-06-17  Leandro Pereira  <leandro@profusion.mobi>
1173
1174         Reviewed by Eric Seidel.
1175
1176         [EFL] Add Evas-based ImageDiff implementation.
1177         https://bugs.webkit.org/show_bug.cgi?id=61942
1178
1179         Build system changes will be performed as soon as the complete
1180         DumpRenderTree implementation is upstreamed.
1181
1182         * DumpRenderTree/efl/ImageDiff.cpp: Added.
1183         (pixelFromImageData):
1184         (differenceImageFromDifferenceBuffer):
1185         (computeDistanceBetweenPixelComponents):
1186         (calculatePixelDifference):
1187         (calculateDifference):
1188         (getTemporaryFile):
1189         (printImage):
1190         (printImageDifferences):
1191         (resizeEcoreEvasIfNeeded):
1192         (readImageFromStdin):
1193         (parseCommandLineOptions):
1194         (shutdownEfl):
1195         (abortWithErrorMessage):
1196         (initEfl):
1197         (main):
1198
1199 2011-06-17  Tony Chang  <tony@chromium.org>
1200
1201         Reviewed by Dirk Pranke.
1202
1203         [chromium] force rebaseline-chromium-webkit-tests to use the chromium port
1204         https://bugs.webkit.org/show_bug.cgi?id=62907
1205
1206         This fixes a bug where the ImageDiff on the user's machine doesn't
1207         match the logic used on the Chromium buildbots.  This has the downside
1208         of requiring that the Chromium ImageDiff is built, but it turns out
1209         that even with --tolerance 0, the CG ImageDiff will allow small pixel
1210         differences through.
1211
1212         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1213
1214 2011-06-17  Brent Fulgham  <bfulgham@webkit.org>
1215
1216         [WinCairo] Unreviewed build correction.
1217
1218         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops:
1219         Update WinCairo property sheet to link against the Cairo DLL,
1220         now that we are using a more recent Cairo build. 
1221
1222 2011-06-17  Brent Fulgham  <bfulgham@webkit.org>
1223
1224         Reviewed by Brian Weinstein.
1225
1226         Create a simple example of using the COM-based C++ listeners.
1227         A new onclick event is attached (via C++) to the WebKit logo
1228         in the default test pattern displayed on startup.  Clicking on
1229         the logo causes a message box to be displayed.
1230         https://bugs.webkit.org/show_bug.cgi?id=61885
1231
1232         * WinLauncher/DOMDefaultImpl.h: Added.  Stub implementation of
1233           the WebScriptObject and DOMEventListener.
1234         * WinLauncher/WinLauncher.cpp:
1235         (SimpleEventListener::SimpleEventListener): Example implementation
1236           of a simple DOM event listener.
1237         (SimpleEventListener::handleEvent): 
1238         (WinLauncherWebHost::didFinishLoadForFrame): Added implementation
1239          to bind a C++ method to the 'onclick' event for the WebKit logo.
1240         (_tWinMain):
1241         * WinLauncher/WinLauncher.h:
1242         * WinLauncher/WinLauncher.vcproj: Add new DOMDefaultImpl.h file.
1243
1244 2011-06-17  Chang Shu  <cshu@webkit.org>
1245
1246         Reviewed by Andreas Kling.
1247
1248         [Qt] [WK2] Support undo/redo in MiniBrowser
1249         https://bugs.webkit.org/show_bug.cgi?id=62809
1250
1251         * MiniBrowser/qt/BrowserWindow.cpp:
1252         (BrowserWindow::BrowserWindow):
1253
1254 2011-06-17  Daniel Bates  <dbates@rim.com>
1255
1256         Rubber-stamped by Eric Seidel.
1257
1258         Remove run-javascriptcore-tests --skip-build option; Instead add --build/no-build options
1259         https://bugs.webkit.org/show_bug.cgi?id=62767
1260
1261         Part 2 of 3
1262
1263         Update the BuildBot master.cfg to use the new --no-build run-javascriptcore-tests
1264         command line option instead of --skip-build.
1265
1266         We'll remove --skip-build from run-javascriptcore-test in a follow up patch once the
1267         master buildbot picks up the change.
1268
1269         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1270
1271 2011-06-17  Daniel Bates  <dbates@rim.com>
1272
1273         Rubber-stamped by Eric Seidel.
1274
1275         Remove run-javascriptcore-tests --skip-build option; Instead add --build/no-build options
1276         https://bugs.webkit.org/show_bug.cgi?id=62767
1277
1278         Part 1 of 3
1279
1280         Towards renaming the option --skip-build to --no-build. Add --build/--no-build options to
1281         run-javascriptcore-tests. Also, add a remark about these options to the usage message
1282         printed by run-javascriptcore-tests.
1283
1284         We'll remove --skip-build in a follow up patch once the master buildbot picks up the changes.
1285
1286         * Scripts/run-javascriptcore-tests: Additionally, remove unnecessary initialization
1287           of $showHelp.
1288
1289 2011-06-17  Joone Hur  <joone.hur@collabora.co.uk>
1290
1291         Reviewed by Martin Robinson.
1292
1293         [GTK] Replace GdkRectangle by cairo_rectangle_int_t
1294         https://bugs.webkit.org/show_bug.cgi?id=60687
1295
1296         Replace GdkRectangle by cairo_rectangle_int_t.
1297
1298         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Replace GdkRectangle by cairo_rectangle_int_t.
1299         (createBitmapContextFromWebView):
1300         * DumpRenderTree/gtk/TextInputController.cpp: Ditto.
1301         (firstRectForCharacterRangeCallback):
1302
1303 2011-06-16  Dmitry Lomov  <dslomov@google.com>
1304
1305         Reviewed by David Levin.
1306
1307         https://bugs.webkit.org/show_bug.cgi?id=62603
1308         Run run-api-tests on bots in debug mode.
1309         Release mode is disabled due to https://bugs.webkit.org/show_bug.cgi?id=61812.
1310
1311         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1312
1313 2011-06-16  Leandro Pereira  <leandro@profusion.mobi>
1314
1315         Reviewed by Eric Seidel.
1316
1317         [EFL] DumpRenderTree: Add GCController, PixelDumpSupport and
1318         WorkQueueItem.
1319         They will be plugged into the build system once the EFL's DRT is
1320         fully upstreamed.
1321         https://bugs.webkit.org/show_bug.cgi?id=61958
1322
1323         * DumpRenderTree/efl: Added.
1324         * DumpRenderTree/efl/GCControllerEfl.cpp: Added.
1325         (GCController::collect):
1326         (GCController::collectOnAlternateThread):
1327         (GCController::getJSObjectCount):
1328         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp: Added.
1329         (createBitmapContextFromWebView):
1330         * DumpRenderTree/efl/WorkQueueItemEfl.cpp: Added.
1331         (LoadItem::invoke):
1332         (LoadHTMLStringItem::invoke):
1333         (ReloadItem::invoke):
1334         (ScriptItem::invoke):
1335         (BackForwardItem::invoke):
1336         * DumpRenderTree/efl/WorkQueueItemEfl.h: Added.
1337         (WorkQueueItem::~WorkQueueItem):
1338         (LoadItem::LoadItem):
1339         (LoadHTMLStringItem::LoadHTMLStringItem):
1340         (ScriptItem::ScriptItem):
1341         (LoadingScriptItem::LoadingScriptItem):
1342         (LoadingScriptItem::invoke):
1343         (NonLoadingScriptItem::NonLoadingScriptItem):
1344         (NonLoadingScriptItem::invoke):
1345         (BackForwardItem::BackForwardItem):
1346         (BackItem::BackItem):
1347         (ForwardItem::ForwardItem):
1348
1349 2011-06-16  Kevin Ollivier  <kevino@theolliviers.com>
1350
1351         [wx] Unreviewed build fix, make sure the waf build checks the webKitBranchBuild
1352         preference like the perl scripts do.
1353
1354         * waf/build/build_utils.py:
1355         * waf/build/settings.py:
1356
1357 2011-06-16  Tommy Widenflycht  <tommyw@google.com>
1358
1359         Reviewed by Tony Gentilcore.
1360
1361         MediaStream API: Runtime enabled features
1362         https://bugs.webkit.org/show_bug.cgi?id=62798
1363
1364         Add the WebRuntimeFeatures API for Media Streams and enable the feature by default in DumpRenderTree.
1365
1366         * DumpRenderTree/chromium/TestShell.cpp:
1367         (TestShell::TestShell):
1368
1369 2011-06-16  Torsten Kurbad  <gentoo@tk-webart.de>
1370
1371         Reviewed by Eric Seidel.
1372
1373         Add support for sys.platform == 'linux3' by relaxing
1374         conditional statements and/or extending lookup dicts.
1375         This way, Linux kernels >=3.0-rc1 get supported in the
1376         build process.
1377         https://bugs.webkit.org/show_bug.cgi?id=62730
1378
1379         * Scripts/webkitpy/common/system/executive.py:
1380         * Scripts/webkitpy/common/system/file_lock.py:
1381         * Scripts/webkitpy/common/system/path_unittest.py:
1382         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1383         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1384         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1385         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1386         * Scripts/webkitpy/layout_tests/port/factory.py:
1387         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1388         * Scripts/webkitpy/layout_tests/port/qt.py:
1389         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1390
1391 2011-06-16  Sheriff Bot  <webkit.review.bot@gmail.com>
1392
1393         Unreviewed, rolling out r88796.
1394         http://trac.webkit.org/changeset/88796
1395         https://bugs.webkit.org/show_bug.cgi?id=62790
1396
1397         It made fast/dom/nodesFromRect-basic.html time out on Qt,
1398         64-bit, debug mode (Requested by Ossy on #webkit).
1399
1400         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1401         (LayoutTestController::nodesFromRect):
1402         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1403         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
1404         (PlainTextController::plainText):
1405         * DumpRenderTree/qt/PlainTextControllerQt.h:
1406
1407 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
1408
1409         Unreviewed, build fix.
1410
1411         Revert the patches in r88995 and r88999; the http servers don't
1412         seem to be shutting down reliably.
1413
1414         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1415         * Scripts/webkitpy/layout_tests/port/base.py:
1416         * Scripts/webkitpy/layout_tests/port/http_server.py:
1417         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1418         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
1419         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1420         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1421
1422 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
1423
1424         Unreviewed, build fix.
1425
1426         Add some debugging messages to triage problems introduced in
1427         r88995.
1428
1429         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1430
1431 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
1432
1433         Reviewed by Tony Chang.
1434
1435         nrwt: should clean up stale server processes from a previous run
1436         https://bugs.webkit.org/show_bug.cgi?id=62615
1437
1438         This change fixes cases where NRWT might start a server and then
1439         exit, leaving the server still running. Now NRWT should detect
1440         this case and clean up on the next run, without shutting down
1441         any processes it didn't start.
1442
1443         This change also fixes a bug in executive.kill_process on UNIX
1444         where zombies weren't being handled properly.
1445
1446         * Scripts/webkitpy/common/system/executive.py:
1447         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1448         * Scripts/webkitpy/layout_tests/port/base.py:
1449         * Scripts/webkitpy/layout_tests/port/http_server.py:
1450         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1451         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1452         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1453
1454 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
1455
1456         Reviewed by Tony Chang.
1457
1458         nrwt: fix http, websocket server startup, shutdown
1459         https://bugs.webkit.org/show_bug.cgi?id=62180
1460
1461         This change refactors all of the server-related code to
1462         have consistent semantics. It pushes the start()/stop()
1463         logic into the base class and adds four much smaller routines
1464         for specialization:
1465         _prepare_config() - for optionally writing config files etc.
1466             to disk prior to starting the server
1467         _remove_stale_log_files()
1468         _spawn_process() - the actual launch of the subprocess
1469         _cleanup_after_stop() - and custom cleanup code
1470
1471         Prior to this change the three server implementations were
1472         fairly inconsistent, leading to lots of weirdness on the bots
1473         with servers being left around, etc.
1474
1475         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1476         * Scripts/webkitpy/layout_tests/port/http_server.py:
1477         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1478         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1479
1480 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
1481
1482         Reviewed by Tony Chang.
1483
1484         webkitpy: clean up code prior to functional changes for server startup/shutdown
1485         https://bugs.webkit.org/show_bug.cgi?id=62256
1486
1487         This patch does a bunch of minor cleanup of the code, but there
1488         should be no functional changes except that all of the modules
1489         will now use the same exception type. Other changes include
1490         removing unused code paths and functions, pushing 'name' and
1491         'pid_file' into the base class of the server objects, and using
1492         the Filesystem object instead of the codecs, tempfile, and
1493         shutils modules.
1494
1495         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1496         * Scripts/webkitpy/layout_tests/port/http_server.py:
1497         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1498         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1499
1500 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
1501
1502         Reviewed by Tony Chang.
1503
1504         webkitpy: add integration tests for new-run-webkit-httpd, stop calling shut_down_http_server
1505         https://bugs.webkit.org/show_bug.cgi?id=62251
1506
1507         shut_down_http_server() was a total hack that was only used by
1508         new-run-webkit-httpd, so I've moved the code there and switched
1509         to using executive.kill_process() for the common case. The
1510         method itself will be removed in the patch on bug 59993.
1511
1512         * Scripts/new-run-webkit-httpd:
1513         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1514         * Scripts/webkitpy/layout_tests/port/http_server.py:
1515         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
1516         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1517
1518 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
1519
1520         Unreviewed, build fix.
1521
1522         Fix test-webkitpy failure introduced in r88986.
1523
1524         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1525
1526 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
1527
1528         Reviewed by Eric Seidel.
1529
1530         NRWT: doesn't support webarchives, has stale skipping logic.
1531         https://bugs.webkit.org/show_bug.cgi?id=58293
1532
1533         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1534         * Scripts/webkitpy/layout_tests/port/base.py:
1535         * Scripts/webkitpy/layout_tests/port/webkit.py:
1536
1537 2011-06-15  Jeremy Orlow  <jorlow@webkit.org>
1538
1539         Change my email to @webkit.org
1540
1541         * Scripts/webkitpy/common/config/committers.py:
1542
1543 2011-06-15  Nikolas Zimmermann  <nzimmermann@rim.com>
1544
1545         Reviewed by David Hyatt.
1546
1547         CSS 2.1: Support replaced elements with relative intrinsic sizes
1548         https://bugs.webkit.org/show_bug.cgi?id=15849
1549
1550         CSS 2.1 failure: html4/replaced-intrinsic-ratio-001
1551         https://bugs.webkit.org/show_bug.cgi?id=53099
1552
1553         Recognize *.htm tests in the old & new DRT implementation, needed for the vanilla css2.1 html4 tests.
1554
1555         * Scripts/old-run-webkit-tests:
1556         * Scripts/webkitpy/layout_tests/port/test_files.py:
1557
1558 2011-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1559
1560         Reviewed by Martin Robinson.
1561
1562         [GTK] Add a statusbar to MiniBrowser
1563         https://bugs.webkit.org/show_bug.cgi?id=62634
1564
1565         It shows the url of the current hovered link.
1566
1567         * MiniBrowser/gtk/BrowserWindow.c:
1568         (browserWindowConstructed): Create the GtkSatusbar.
1569         (mouseDidMoveOverElement): Update statusbar text.
1570         (browserWindowUIClientInit): Add implementation for
1571         mouseDidMoveOverElement().
1572         * MiniBrowser/gtk/GNUmakefile.am: Add new files to compilation.
1573         * MiniBrowser/gtk/WebBundle/WebBundleMain.c: Added.
1574         (mouseDidMoveOverElement): Pass the url of the current hovered
1575         link to the UI process.
1576         (didCreatePage): Set the UI client adding an implementation for
1577         mouseDidMoveOverElement().
1578         (WKBundleInitialize):
1579         * MiniBrowser/gtk/main.c:
1580         (createWKContextWithInjectedBundle): Create a global context with
1581         the injected bundle.
1582         (loadURI): Use the global context.
1583         (main):
1584
1585 2011-06-14  Lucas Forschler  <lforschler@apple.com>
1586
1587         Reviewed by Stephanie Lewis.
1588
1589         https://bugs.webkit.org/show_bug.cgi?id=62495
1590         Bug 62495 - combine windows and mac kill-old-processes script
1591         Add a platform agnostic script.  Remove the recently added mac flavor.
1592         Note: Leaving the windows one alone, since it is currently used by the WebKit bots.
1593         
1594         * BuildSlaveSupport/kill-old-processes: Added.
1595         * BuildSlaveSupport/mac: Removed.
1596         * BuildSlaveSupport/mac/kill-old-processes: Removed.
1597
1598 2011-06-14  Dirk Pranke  <dpranke@chromium.org>
1599
1600         Reviewed by Tony Chang.
1601
1602         nrwt: handle worker exceptions cleanly
1603         https://bugs.webkit.org/show_bug.cgi?id=62614
1604
1605         This change modifiers new-run-webkit-tests to handle exceptions
1606         raised by worker threads better, by:
1607         - capturing the worker's stack and logging it in the manager
1608         - propagating the worker's exception in the caller correctly
1609         - attempting to cancel the workers and clean up even when
1610           we get an unexpected exception
1611
1612         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1613         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1614         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1615         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1616
1617 2011-06-14  Qi Zhang  <qi.2.zhang@nokia.com>
1618
1619         Reviewed by Laszlo Gombos.
1620
1621         [Qt] fast/dom/HTMLScriptElement/nested-execution.html failed
1622         https://bugs.webkit.org/show_bug.cgi?id=62227
1623
1624         QtWebkit does not yet support different CacheModels. This change will 
1625         expose setCacheModel() with a stub implementation, which is enough to pass the LayoutTest.
1626
1627         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1628         (LayoutTestController::setCacheModel):
1629         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1630
1631 2011-06-14  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1632
1633         Reviewed by Andreas Kling.
1634
1635         [Qt] tst_QWebFrame::overloadedSlots() fails
1636         https://bugs.webkit.org/show_bug.cgi?id=37319
1637
1638         Since we don't implictly convert 'document' object to QWebElement
1639         in metacalls anymore, change the controller to expect QVariantMap instead.
1640
1641         The method plainText() was updated to use QVariantMap as well to let the bridge
1642         do the conversion directly for us.
1643
1644         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1645         (LayoutTestController::nodesFromRect):
1646         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1647         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
1648         (PlainTextController::plainText):
1649         * DumpRenderTree/qt/PlainTextControllerQt.h:
1650
1651 2011-06-14  Andras Becsi  <abecsi@webkit.org>
1652
1653         Reviewed by Csaba Osztrogonác.
1654
1655         Remove dead code in DumpRenderTree/TestNetscapePlugIn/main.cpp
1656         https://bugs.webkit.org/show_bug.cgi?id=62630
1657
1658         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1659         (NPP_New): remove dead variable 'forceCarbon'
1660
1661 2011-06-13  Hayato Ito  <hayato@chromium.org>
1662
1663         Reviewed by Ojan Vafai.
1664
1665         [NRWT] Fix a WebKitDriver so that it returns an actual hash value if DRT returns that.
1666         https://bugs.webkit.org/show_bug.cgi?id=59188
1667
1668         A current WebKitDriver doesn't try to return an actual hash value if DRT does not return an image.
1669         WebKitDriver should always return an actual hash value if DRT returns that.
1670
1671         No tests since I'll add sample reftests to make sure mismatch reftests work later,
1672         which should be in a separate patch.
1673
1674         * Scripts/webkitpy/layout_tests/port/webkit.py:
1675
1676 2011-06-13  Kent Tamura  <tkent@chromium.org>
1677
1678         [Chromium-win] Fix two wrong assertions exposed by r88757.
1679
1680         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
1681         (WebThemeEngineDRTWin::paintTrackbar):
1682
1683 2011-06-13  Alexey Proskuryakov  <ap@apple.com>
1684
1685         Added an updated e-mail address for Matt Lilek, to make Bugzilla autocomplete
1686         and commit queue happy.
1687
1688         * Scripts/webkitpy/common/config/committers.py:
1689
1690 2011-06-13  Chris Rogers  <crogers@google.com>
1691
1692         Unreviewed build fix.
1693
1694         Build fix to chromium DRT until we can rebaseline some tests
1695         https://bugs.webkit.org/show_bug.cgi?id=62608
1696
1697         * DumpRenderTree/chromium/TestShell.cpp:
1698         (TestShell::TestShell):
1699
1700 2011-06-13  Chris Rogers  <crogers@google.com>
1701
1702         Reviewed by Dirk Pranke.
1703
1704         Add Web Audio support to chromium DRT
1705         https://bugs.webkit.org/show_bug.cgi?id=62306
1706
1707         * DumpRenderTree/chromium/LayoutTestController.cpp:
1708         (LayoutTestController::LayoutTestController):
1709         (LayoutTestController::reset):
1710         (LayoutTestController::setEncodedAudioData):
1711         * DumpRenderTree/chromium/LayoutTestController.h:
1712         (LayoutTestController::encodedAudioData):
1713         (LayoutTestController::shouldDumpAsAudio):
1714         (LayoutTestController::setShouldDumpAsAudio):
1715         * DumpRenderTree/chromium/TestEventPrinter.cpp:
1716         (DRTPrinter::handleAudioHeader):
1717         (TestShellPrinter::handleAudioHeader):
1718         * DumpRenderTree/chromium/TestEventPrinter.h:
1719         * DumpRenderTree/chromium/TestShell.cpp:
1720         (TestShell::TestShell):
1721         (TestShell::dump):
1722
1723 2011-06-13  Jaehun Lim  <ljaehun.lim@samsung.com>
1724
1725         Reviewed by Eric Seidel.
1726
1727         [EFL] Add load error handler to EWebLauncher
1728         https://bugs.webkit.org/show_bug.cgi?id=62347
1729
1730         Add a handler function of "load,error" to EWebLauncher.
1731         EWebLauncher now displays a simple error page on load errors.
1732
1733         * EWebLauncher/main.c:
1734         (on_load_error):
1735         (browserCreate):
1736
1737 2011-06-13  Martin Robinson  <mrobinson@igalia.com>
1738
1739         Reviewed by Eric Seidel.
1740
1741         [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
1742         https://bugs.webkit.org/show_bug.cgi?id=62385
1743
1744         Remove duplicate TestNetscapePlugIn implementation. Having two copies
1745         of this code makes keeping it in sync much more difficult. The files are
1746         almost identical and this change ports the X11 changes to main.cpp.
1747
1748         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1749         (NPP_New): Do not set the plugin as windowless always. Doing this breaks
1750         some results on Qt and this seems to be unnecessary for the moment.
1751         (keyEventToChar): Added this helper which converts a X11 keycode into a char.
1752         (handleEventX11): Use the handler to properly convert the keycode. Do not print
1753         adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
1754         it should not be in the results.
1755         (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed and make it clearer why the
1756         XP_UNIX block is first by guarding against using a null instance.
1757         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list add
1758         the XP_UNIX define for Linux.
1759         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
1760         * GNUmakefile.am: Update source list.
1761
1762 2011-06-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1763
1764         Unreviewed, rolling out r88671.
1765         http://trac.webkit.org/changeset/88671
1766         https://bugs.webkit.org/show_bug.cgi?id=62591
1767
1768         "didn't work" (Requested by dpranke on #webkit).
1769
1770         * Scripts/new-run-webkit-httpd:
1771         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1772         * Scripts/webkitpy/layout_tests/port/http_server.py:
1773         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1774         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
1775         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1776         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1777
1778 2011-06-13  Nate Chapin  <japhet@chromium.org>
1779
1780         Reviewed by Darin Fisher.
1781
1782         New test method on TestNetscapePlugin for https://bugs.webkit.org/show_bug.cgi?id=61482.
1783
1784         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1785
1786 2011-06-13  Dirk Pranke  <dpranke@chromium.org>
1787
1788         Reviewed by Tony Chang.
1789
1790         webkitpy: add integration tests for new-run-webkit-httpd, stop calling shut_down_http_server
1791         https://bugs.webkit.org/show_bug.cgi?id=62251
1792
1793         shut_down_http_server() was a total hack that was only used by
1794         new-run-webkit-httpd, so I've moved the code there and switched
1795         to using executive.kill_process() for the common case. The
1796         method itself will be removed in the patch on bug 59993.
1797
1798         * Scripts/new-run-webkit-httpd:
1799         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1800         * Scripts/webkitpy/layout_tests/port/http_server.py:
1801         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
1802         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1803
1804 2011-06-13  Tony Chang  <tony@chromium.org>
1805
1806         Reviewed by Dimitri Glazkov.
1807
1808         rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
1809         https://bugs.webkit.org/show_bug.cgi?id=62578
1810
1811         * Scripts/build-webkit:
1812
1813 2011-06-13  Tony Chang  <tony@chromium.org>
1814
1815         Reviewed by Adam Barth.
1816
1817         rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
1818         https://bugs.webkit.org/show_bug.cgi?id=62545
1819
1820         * Scripts/build-webkit:
1821
1822 2011-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
1823
1824         Reviewed by Martin Robinson.
1825
1826         [GTK] Export an API similar to WebKit1
1827         https://bugs.webkit.org/show_bug.cgi?id=57820
1828
1829         Build GtkLauncher2 for WebKit2. It's actually the same GtkLauncher
1830         code, but linking to libwebkit2gtk.
1831
1832         * GNUmakefile.am:
1833         * GtkLauncher/main.c:
1834         (createBrowser):
1835         (main):
1836
1837 2011-06-12  MORITA Hajime  <morrita@google.com>
1838
1839         Unreviewed, rolling out r88625.
1840         http://trac.webkit.org/changeset/88625
1841         https://bugs.webkit.org/show_bug.cgi?id=61073
1842
1843         Breaks SL Webkit2 Tests
1844
1845         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
1846         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1847         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
1848         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1849         (WTR::InjectedBundlePage::didClearWindowForFrame):
1850         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1851
1852 2011-06-12  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1853
1854         Reviewed by Antonio Gomes.
1855
1856         [Qt] LayoutTestController needs setTextDirection implementation
1857         https://bugs.webkit.org/show_bug.cgi?id=62442
1858
1859         Implements LayoutController.setTextDirection.
1860
1861         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1862         (LayoutTestController::setTextDirection):
1863         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1864
1865 2011-06-12  Dominic Cooney  <dominicc@chromium.org>
1866
1867         Reviewed by Hajime Morita.
1868
1869         Add window.internals to WebKit2's WebKitTestRunner.
1870         https://bugs.webkit.org/show_bug.cgi?id=61073
1871
1872         Test: fast/harness/internals-object.html
1873
1874         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
1875         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1876         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
1877         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1878         (WTR::InjectedBundlePage::didClearWindowForFrame): initialize window.internals
1879         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1880
1881 2011-06-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1882
1883         Unreviewed, rolling out r88616.
1884         http://trac.webkit.org/changeset/88616
1885         https://bugs.webkit.org/show_bug.cgi?id=62517
1886
1887         It broke editing/text-iterator/findString.html (Requested by
1888         tonikitoo on #webkit).
1889
1890         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1891         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1892
1893 2011-06-12  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1894
1895         Reviewed by Antonio Gomes.
1896
1897         [Qt] LayoutTestController needs setTextDirection implementation
1898         https://bugs.webkit.org/show_bug.cgi?id=62442
1899
1900         Implements LayoutController.setTextDirection.
1901
1902         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1903         (LayoutTestController::setTextDirection):
1904         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1905
1906 2011-06-10  Ryosuke Niwa  <rniwa@webkit.org>
1907
1908         Reviewed by Ojan Vafai.
1909
1910         new-run-webkit-tests: 'images' links on results.html don't work
1911         https://bugs.webkit.org/show_bug.cgi?id=62194
1912
1913         Use relative path when generating images-diffs.html
1914
1915         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1916         Added _output_testname.
1917
1918 2011-06-10  Lucas Forschler  <lforschler@apple.com>
1919
1920         Reviewed by Stephanie Lewis.
1921
1922         Script to kill old processes on Mac.
1923         This matches the windows version.
1924         https://bugs.webkit.org/show_bug.cgi?id=62479  
1925         
1926         * BuildSlaveSupport/mac: Added.
1927         * BuildSlaveSupport/mac/kill-old-processes: Added.
1928
1929 2011-06-10  Adam Barth  <abarth@webkit.org>
1930
1931         Reviewed by James Robinson.
1932
1933         When sheriffbot reports failures on IRC instead of saying "(and more..)" it should say the number of tests that are failing
1934         https://bugs.webkit.org/show_bug.cgi?id=62489
1935
1936         * Scripts/webkitpy/tool/bot/sheriff.py:
1937         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1938
1939 2011-06-10  Tony Chang  <tony@chromium.org>
1940
1941         Reviewed by Ojan Vafai.
1942
1943         add a compile guard ENABLE(FLEXBOX)
1944         https://bugs.webkit.org/show_bug.cgi?id=62049
1945
1946         * Scripts/build-webkit:
1947
1948 2011-06-10  Mark Rowe  <mrowe@apple.com>
1949
1950         Reviewed by Dimitri Glazkov.
1951
1952         <rdar://problem/9562114> Fix DumpRenderTree build for production configuration.
1953
1954         Ensure that DumpRenderTree can find libWebCoreTestSupport.dylib and the associated
1955         header file.
1956
1957         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1958         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1959
1960 2011-06-09  Csaba Osztrogonác  <ossy@webkit.org>
1961
1962         Unreviewed rolling out r88471, because it broke plugin tests on Qt.
1963
1964         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1965         (handleEventX11):
1966         (NPP_GetValue):
1967         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1968         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Added.
1969         (webkit_test_plugin_new_instance):
1970         (webkit_test_plugin_destroy_instance):
1971         (webkit_test_plugin_set_window):
1972         (executeScript):
1973         (webkit_test_plugin_new_stream):
1974         (webkit_test_plugin_destroy_stream):
1975         (webkit_test_plugin_stream_as_file):
1976         (webkit_test_plugin_write_ready):
1977         (webkit_test_plugin_write):
1978         (webkit_test_plugin_print):
1979         (keyEventToChar):
1980         (webkit_test_plugin_handle_event):
1981         (webkit_test_plugin_url_notify):
1982         (webkit_test_plugin_get_value):
1983         (webkit_test_plugin_set_value):
1984         (NP_GetMIMEDescription):
1985         (NP_Initialize):
1986         (NP_Shutdown):
1987         (NP_GetValue):
1988         * GNUmakefile.am:
1989
1990 2011-06-09  Martin Robinson  <mrobinson@igalia.com>
1991
1992         Reviewed by Eric Seidel.
1993
1994         [GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)
1995         https://bugs.webkit.org/show_bug.cgi?id=55603
1996
1997         Add callbacks to support hasMarkedText and markedRange and also clean up existing 
1998         TextInputController support.
1999
2000         * DumpRenderTree/gtk/TextInputController.cpp:
2001         (setMarkedTextCallback): Accept parameters in terms of start and length, instead
2002         of start and end. This matches the other ports. Do not use GLib style early returns.
2003         (hasMarkedTextCallback): Added.
2004         (markedRangeCallback): Added.
2005         (insertTextCallback): Cleanup as described above.
2006         (unmarkTextCallback): Cleanup as described above.
2007         (firstRectForCharacterRangeCallback): Cleanup as described above.
2008         (selectedRangeCallback): Cleanup as described above.
2009
2010 2011-06-09  Dirk Pranke  <dpranke@chromium.org>
2011
2012         Reviewed by Tony Chang.
2013
2014         nrwt: support webaudio in chromium driver
2015         https://bugs.webkit.org/show_bug.cgi?id=62226
2016
2017         * Scripts/webkitpy/layout_tests/port/chromium.py:
2018
2019 2011-06-09  Dan Bernstein  <mitz@apple.com>
2020
2021         Reviewed by Anders Carlsson.
2022
2023         Added a test for Vector::reverse()
2024         https://bugs.webkit.org/show_bug.cgi?id=62393
2025
2026         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2027         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp: Added.
2028         (TestWebKitAPI::TEST):
2029         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2030
2031 2011-06-09  Martin Robinson  <mrobinson@igalia.com>
2032
2033         Reviewed by Andreas Kling.
2034
2035         [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
2036         https://bugs.webkit.org/show_bug.cgi?id=62385
2037
2038         Remove duplicate TestNetscapePlugIn implementation. Having two copies
2039         of this code makes keeping it in sync much more difficult. The files are
2040         almost identical and this change ports the X11 changes to main.cpp.
2041
2042         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2043         (keyEventToChar): Added this helper which converts a X11 keycode into a char.
2044         (handleEventX11): Use the handler to properly convert the keycode. Do not print
2045         adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
2046         it should not be in the results.
2047         (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed.
2048         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list.
2049         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
2050         * GNUmakefile.am: Update source list.
2051
2052 2011-06-09  Noel Gordon  <noel.gordon@gmail.com>
2053
2054         Reviewed by Tony Chang.
2055
2056         Test plugin should support event logging on the windows port.
2057         https://bugs.webkit.org/show_bug.cgi?id=61721
2058
2059         The WebKit win port interprets a 0 return from plugin NPP_HandleEvent()
2060         calls to mean the plugin handled the event.
2061
2062         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2063         (handleEventWin): Return 0 for each event on windows.
2064
2065 2011-06-09  Chang Shu  <cshu@webkit.org>
2066
2067         Reviewed by Andreas Kling.
2068
2069         [Qt] [WK2] Many editing tests failed on missing shouldBeginEditingInDOMRange:range printout
2070         https://bugs.webkit.org/show_bug.cgi?id=62381
2071
2072         Activate QGraphicsScene and setFocus on QGraphicsItem to make sure the view has the focus.
2073         QWKPagePrivate::isViewFocused() will check it later.
2074
2075         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2076         (WTR::PlatformWebView::PlatformWebView):
2077
2078 2011-06-09  Robert Hogan  <robert@webkit.org>
2079
2080         Reviewed by Andreas Kling.
2081
2082         Teach Qt about window.internals
2083         https://bugs.webkit.org/show_bug.cgi?id=61074
2084
2085         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2086         (WebCore::DumpRenderTree::initJSObjects):
2087
2088 2011-06-09  Eric Seidel  <eric@webkit.org>
2089
2090         Reviewed by Adam Barth.
2091
2092         Disable running layout tests on Mac EWS bots (and fix cr-linux bots to run them again)
2093         https://bugs.webkit.org/show_bug.cgi?id=62362
2094
2095         The mac bots are failing inspector tests.  We don't know why yet.
2096         So for now, turning run-webkit-tests off for the mac-ews.
2097
2098         Also noticed that due to the wrong variable name the cr-linux
2099         bots weren't running tests!
2100
2101         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2102
2103 2011-06-09  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>
2104
2105         Reviewed by Csaba Osztrogonac.
2106
2107         [Qt][WK2] Canvas tests make css2.1 ones failing
2108         https://bugs.webkit.org/show_bug.cgi?id=53427
2109
2110         Adding a workaround for this issue by mimicing the behaviour of DumpRenderTree.
2111         Since the Qt port should eventually go to QRawFont, this issue will be resolved
2112         in the future. Both clearMemoryCaches() and removeAllApplicationFonts() are
2113         needed for the workaround.
2114
2115         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
2116         (WTR::LayoutTestController::platformInitialize):
2117
2118 2011-06-09  Mario Sanchez Prada  <msanchez@igalia.com>
2119
2120         Reviewed by Chris Fleizach.
2121
2122         [GTK] Provide a way in DRT to check the platform name
2123         https://bugs.webkit.org/show_bug.cgi?id=56855
2124
2125         Patch for adding 'platformName' static property to DRT's
2126         LayoutController and provide platform specific implementations.
2127
2128         In principle, this feature will be only of interest for writing
2129         accessibility tests, so that's why it's only implemented in the
2130         Mac, Gtk and Win platforms.
2131
2132         * DumpRenderTree/LayoutTestController.h: New method platformName().
2133         * DumpRenderTree/LayoutTestController.cpp:
2134         (getPlatformNameCallback): New callback for 'platformName'.
2135         (LayoutTestController::staticValues): New static property.
2136
2137         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2138         (LayoutTestController::platformName): Implemented.
2139
2140         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2141         (LayoutTestController::platformName): Implemented.
2142
2143         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2144         (LayoutTestController::platformName): Implemented.
2145
2146 2011-06-08  Mike Lawther  <mikelawther@chromium.org>
2147
2148         Reviewed by James Robinson.
2149
2150         Add mikelawther to committers.py
2151         https://bugs.webkit.org/show_bug.cgi?id=62354
2152
2153         * Scripts/webkitpy/common/config/committers.py:
2154
2155 2011-06-08  Kent Tamura  <tkent@chromium.org>
2156
2157         [Chromium] Fix a typo.
2158
2159         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
2160         (WebThemeControlDRTWin::draw):
2161
2162 2011-06-08  Kent Tamura  <tkent@chromium.org>
2163
2164         Reviewed by Hajime Morita.
2165
2166         [Chromium] Support vertical sliders in Windows DRT
2167         https://bugs.webkit.org/show_bug.cgi?id=62352
2168
2169         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
2170         (WebThemeControlDRTWin::draw):
2171           Paint VerticalSliderThumbType and VerticalSliderTrackType.
2172         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
2173           Add VerticalSliderTrackType and VerticalSliderThumbType.
2174         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
2175         (WebThemeEngineDRTWin::paintTrackbar):
2176           Convert Windows identifiers to the internal identifiers for vertical sliders.
2177
2178 2011-06-08  Ojan Vafai  <ojan@chromium.org>
2179
2180         Reviewed by Tony Chang.
2181
2182         add a short-flag for --experimental-fully-parallel
2183         https://bugs.webkit.org/show_bug.cgi?id=62321
2184
2185         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2186
2187 2011-06-08  Ryosuke Niwa  <rniwa@webkit.org>
2188
2189         Reviewed by Tony Chang.
2190
2191         new-run-webkit-tests: don't turn the tree red when there are new passes
2192         https://bugs.webkit.org/show_bug.cgi?id=62311
2193
2194         Look for "new passes" instead of "passed unexpectedly" in evaluateCommand
2195         to match commandComplete.
2196
2197         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2198
2199 2011-06-08  Tom Hudson  <tomhudson@google.com>
2200
2201         Reviewed by Mihai Parparita.
2202
2203         Allow sorting in RebaselineServer based on 'metric' field in unexpected_results.json
2204         https://bugs.webkit.org/show_bug.cgi?id=60964
2205
2206         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2207         Add 'Sort tests by metric' link.
2208         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2209         (disableSorting): Activate 'Sort tests by metric' link.
2210         (enableSorting): Deactivate 'Sort tests by metric' link.
2211         (selectDirectory): Call enableSorting()/disableSorting() depending
2212         on currently selected failure type, and sort tests if requested.
2213         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2214         New .disabled-control class for deactivated links.
2215
2216 2011-06-08  Tom Sepez  <tsepez@chromium.org>
2217
2218         Reviewed by Adam Barth.
2219
2220         Add web permissions callbacks for mixed content blocking.
2221         https://bugs.webkit.org/show_bug.cgi?id=61946
2222
2223         * DumpRenderTree/chromium/LayoutTestController.cpp:
2224         (LayoutTestController::setAllowDisplayOfInsecureContent):
2225         (LayoutTestController::setAllowRunningOfInsecureContent):
2226         (LayoutTestController::overridePreference):
2227         * DumpRenderTree/chromium/WebPermissions.cpp:
2228         (WebPermissions::allowDisplayingInsecureContent):
2229         (WebPermissions::allowRunningInsecureContent):
2230         (WebPermissions::setDisplayingInsecureContentAllowed):
2231         (WebPermissions::setRunningInsecureContentAllowed):
2232         (WebPermissions::reset):
2233         * DumpRenderTree/chromium/WebPermissions.h:
2234
2235 2011-06-08  Dirk Pranke  <dpranke@chromium.org>
2236
2237         Reviewed by Tony Chang.
2238
2239         webkitpy: fix typo causing us to skip the port unit tests in chromium_linux
2240         https://bugs.webkit.org/show_bug.cgi?id=62259
2241
2242         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2243
2244 2011-06-08  Ryosuke Niwa  <rniwa@webkit.org>
2245
2246         Reviewed by Tony Chang.
2247
2248         new-run-webkit-tests: master.cfg errors when nrwt successfully runs test
2249         https://bugs.webkit.org/show_bug.cgi?id=62303
2250
2251         Access self.incorrectLayoutLines instead of incorrectLayoutLines in evaluateCommand.
2252
2253         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2254
2255 2011-06-08  Greg Simon  <gregsimon@chromium.org>
2256
2257         Reviewed by Dimitri Glazkov.
2258
2259         Control Indexeddb backends from LayoutTestController
2260         https://bugs.webkit.org/show_bug.cgi?id=61000
2261
2262         * DumpRenderTree/chromium/LayoutTestController.cpp:
2263         (LayoutTestController::LayoutTestController):
2264         (LayoutTestController::setOverrideIndexedDBBackingStore):
2265         (LayoutTestController::clearAllDatabases):
2266         * DumpRenderTree/chromium/LayoutTestController.h:
2267
2268 2011-06-08  Andreas Kling  <kling@webkit.org>
2269
2270         Add Pierre Rossi to contributors list for EZ-CC.
2271
2272         * Scripts/webkitpy/common/config/committers.py:
2273
2274 2011-06-08  Ilya Sherman  <isherman@chromium.org>
2275
2276         Reviewed by Andreas Kling.
2277
2278         Add Ilya Sherman to list of committers
2279         https://bugs.webkit.org/show_bug.cgi?id=62270
2280
2281         * Scripts/webkitpy/common/config/committers.py:
2282
2283 2011-06-07  Ryosuke Niwa  <rniwa@webkit.org>
2284
2285         Reviewed by Tony Chang.
2286
2287         new-run-webkit-tests: Bot master should print useful information on waterfall/console for nrwt
2288         https://bugs.webkit.org/show_bug.cgi?id=62178
2289
2290         Added commandComplete and evaluateCommand for NewRunWebKitTests class
2291         to parse new-run-webkit-tests' results.
2292
2293         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2294
2295 2011-06-07  Dirk Pranke  <dpranke@chromium.org>
2296
2297         Reviewed by Eric Seidel.
2298
2299         webkitpy: add a popen() call to executive
2300         https://bugs.webkit.org/show_bug.cgi?id=62179
2301
2302         This change adds a popen() wrapper call to the Executive object.
2303         This will allow other webkitpy scripts that currently call
2304         subprocess directly to use Executive, instead.
2305
2306         No additional tests are necessary (the existing tests cover the code).
2307
2308         * Scripts/webkitpy/common/system/executive.py:
2309
2310 2011-06-07  Sam Weinig  <sam@webkit.org>
2311
2312         Reviewed by Anders Carlsson.
2313
2314         Remove repeated IPC traffic from SetRenderTreeSize message
2315         https://bugs.webkit.org/show_bug.cgi?id=62244
2316
2317         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2318         (WTR::InjectedBundlePage::InjectedBundlePage):
2319         Add stub for didLayoutForFrame.
2320
2321 2011-06-07  Dirk Pranke  <dpranke@chromium.org>
2322
2323         Reviewed by Tony Chang.
2324
2325         rebaseline-chromium-webkit-tests: fix baselining order for linux, linux_x86_64
2326         https://bugs.webkit.org/show_bug.cgi?id=62241
2327
2328         * Scripts/webkitpy/layout_tests/port/chromium.py:
2329
2330 2011-06-07  Adam Barth  <abarth@webkit.org>
2331
2332         Rubber-stamped by Eric Seidel.
2333
2334         Enable tests on the mac-ews
2335
2336         When we bring the mac-ews back up, we're going to try running tests!
2337
2338         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2339
2340 2011-06-07  Dmitry Lomov  <dslomov@google.com>
2341
2342         Reviewed by David Levin.
2343
2344         https://bugs.webkit.org/show_bug.cgi?id=62215
2345         Allow comparisons with 0 in LIKELY and UNLIKELY macros.
2346
2347         * Scripts/webkitpy/style/checkers/cpp.py:
2348         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2349
2350 2011-06-07  Nico Weber  <thakis@chromium.org>
2351
2352         Reviewed by Dimitri Glazkov.
2353
2354         [chromium] -Wdelete-non-virtual-dtor pass for DumpRenderTree
2355         https://bugs.webkit.org/show_bug.cgi?id=62210
2356
2357         The change to TestEventPrinter fixes a latent bug, because
2358         objects are deleted through the TestEventPrinter type, but none
2359         of the subclasses have destructors or non-POD members.
2360
2361         The changes to NotificationPresenter and WebViewHost do _not_ to fix a
2362         real bug, they just make clang's -Wdelete-non-virtual-dtor happy. As
2363         discussed at http://codereview.chromium.org/7094005/, we prefer making
2364         leaf class destructors virtual over making the leaf classes final.
2365
2366         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2367         (NotificationPresenter::~NotificationPresenter):
2368         * DumpRenderTree/chromium/NotificationPresenter.h:
2369         * DumpRenderTree/chromium/TestEventPrinter.cpp:
2370         (TestEventPrinter::~TestEventPrinter):
2371         * DumpRenderTree/chromium/TestEventPrinter.h:
2372         * DumpRenderTree/chromium/WebViewHost.h:
2373
2374 2011-06-06  Ryosuke Niwa  <rniwa@webkit.org>
2375
2376         Reviewed by Dirk Pranke.
2377
2378         [chromium] Chromium bots on build.webkit.org don't upload results.html
2379         https://bugs.webkit.org/show_bug.cgi?id=61961
2380
2381         Don't fix the path on chromium port erroneously.
2382
2383         * BuildSlaveSupport/test-result-archive:
2384
2385 2011-06-06  Martin Robinson  <mrobinson@igalia.com>
2386
2387         Fix the GTK+ build by ensuring that the autogenerated sources
2388         necessary for libWebCoreInternals are recorded in a predeclared
2389         variable before assigning to BUILT_SOURCES.
2390
2391         * GNUmakefile.am: Predeclare libwebcoreinternals_built_sources.
2392
2393 2011-06-06  Yong Li  <yoli@rim.com>
2394
2395         Reviewed by Eric Seidel.
2396
2397         https://bugs.webkit.org/show_bug.cgi?id=62097
2398         Fix the problem that integral bitfield check incorrectly barked at ?: expressions.
2399
2400         * Scripts/webkitpy/style/checkers/cpp.py:
2401         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2402
2403 2011-06-06  Xan Lopez  <xlopez@igalia.com>
2404
2405         Reviewed by Martin Robinson.
2406
2407         [GTK] Enable feature/symbol detection in NWRT/GTK
2408         https://bugs.webkit.org/show_bug.cgi?id=62136
2409
2410         Disable feature detection through DRT, since we don't support it,
2411         and set the libwebcore patch correctly so that symbol detection
2412         through 'nm' works.
2413
2414         * Scripts/webkitpy/layout_tests/port/gtk.py:
2415
2416 2011-06-06  Shishir Agrawal  <shishir@chromium.org>
2417
2418         Reviewed by Tony Gentilcore.
2419
2420         Add a "prerender" state for page visibility.
2421         https://bugs.webkit.org/show_bug.cgi?id=62062
2422
2423         * DumpRenderTree/chromium/LayoutTestController.cpp:
2424         (LayoutTestController::setPageVisibility):
2425
2426 2011-06-06  Csaba Osztrogonác  <ossy@webkit.org>
2427
2428         [Qt] Implement download feature for QtTestBrowser
2429         https://bugs.webkit.org/show_bug.cgi?id=61865
2430
2431         Buildfix for --minimal and CONFIG+=qt_minimal build after r88161.
2432
2433         * QtTestBrowser/launcherwindow.cpp:
2434         (LauncherWindow::LauncherWindow):
2435         * QtTestBrowser/launcherwindow.h:
2436
2437 2011-06-06  Barát Tibor  <Barat.Tibor@stud.u-szeged.hu>
2438
2439         Reviewed by Csaba Osztrogonác.
2440
2441         [Qt] Implement download feature for QtTestBrowser
2442         https://bugs.webkit.org/show_bug.cgi?id=61865
2443
2444         * QtTestBrowser/launcherwindow.cpp:
2445         (LauncherWindow::LauncherWindow):
2446         (LauncherWindow::downloadRequest):
2447         (LauncherWindow::fileDownloadFinished):
2448         * QtTestBrowser/launcherwindow.h:
2449
2450 2011-06-04  Dominic Cooney  <dominicc@chromium.org>
2451
2452         Reviewed by Dimitri Glazkov.
2453
2454         Make DumpRenderTree initialize window.internals.
2455         https://bugs.webkit.org/show_bug.cgi?id=61076
2456
2457         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: link WebCoreTestSupport.
2458         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2459         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
2460
2461 2011-06-06  Alexandru Chiculita  <achicu@adobe.com>
2462
2463         Reviewed by Kent Tamura.
2464
2465         Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
2466         https://bugs.webkit.org/show_bug.cgi?id=61628
2467
2468         * Scripts/build-webkit:
2469
2470 2011-06-06  Mihnea Ovidenie  <mihnea@adobe.com>
2471
2472         Reviewed by Kent Tamura.
2473
2474         Add ENABLE(CSS_REGIONS) guard for CSS Regions support
2475         https://bugs.webkit.org/show_bug.cgi?id=61631
2476
2477         * Scripts/build-webkit:
2478
2479 2011-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2480
2481         Unreviewed. Fix the GTK+ build.
2482
2483         * GNUmakefile.am: Use javascriptcore_cflags when building libWebCoreInternals.
2484
2485 2011-06-05  Alexey Proskuryakov  <ap@apple.com>
2486
2487         Add an e-mail address for Cameron McCormack that matches Bugzilla (so that auto-completion
2488         works properly).
2489
2490         * Scripts/webkitpy/common/config/committers.py:
2491
2492 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
2493
2494         [wx] Unreviewed build fix. Update git branch build dir handling to match what other
2495         WebKit scripts expect, so other scripts work properly with wx.
2496
2497         * waf/build/build_utils.py:
2498         * waf/build/settings.py:
2499
2500 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
2501
2502         [wx] Unreviewed build fix. Restore the PPC build and allow users to specify architectures
2503         to build on Mac.
2504
2505         * waf/build/settings.py:
2506         * wx/install-unix-extras:
2507
2508 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
2509
2510         [wx] Unreviewed build fixes for recent trunk changes.
2511
2512         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2513         (LayoutTestController::setTextDirection):
2514         * waf/build/settings.py:
2515
2516 2011-06-04  Martin Robinson  <mrobinson@igalia.com>
2517
2518         Fix the GTK+ build.
2519
2520         * GNUmakefile.am: Add some missing newline escape.
2521
2522 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
2523
2524         Try to fix the GTK+ bulid.
2525
2526         * GNUmakefile.am: Add JSDOMWrapper.cpp to the libWebCoreInternals
2527         source list.
2528
2529 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
2530
2531         Reviewed by Adam Barth.
2532
2533         nrwt: should skip chromium test expectation overrides on upstream bots
2534         https://bugs.webkit.org/show_bug.cgi?id=61888
2535
2536         * Scripts/webkitpy/layout_tests/port/chromium.py:
2537         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2538
2539 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
2540
2541         Reviewed by Ojan Vafai.
2542
2543         new-run-webkit-tests: minor logging, code cleanup
2544         https://bugs.webkit.org/show_bug.cgi?id=62055
2545
2546         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2547         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2548
2549 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
2550
2551         Try to fix the build failure on the GTK+ 32-bit Release bot.
2552
2553         * GNUmakefile.am: Add JSInternal.{cpp,h} to the BUILT_SOURCES list.
2554
2555 2011-05-31  Martin Robinson  <mrobinson@igalia.com>
2556
2557         Reviewed by Ryosuke Niwa.
2558
2559         [GTK] Support smart replace for the pasteboard
2560         https://bugs.webkit.org/show_bug.cgi?id=61734
2561
2562         Call into the DumpRenderTreeSupportGtk hooks to toggle smart replace.
2563         This is required to produce consistent test results.
2564
2565         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2566         (resetDefaultsToConsistentValues): Set the smart replace setting to on by default.
2567         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2568         (LayoutTestController::setSmartInsertDeleteEnabled): Added an implementation of this
2569         methods which calls into DumpRenderTreeSupportGtk.
2570
2571 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
2572
2573         Reviewed by Dimitri Glazkov.
2574
2575         Teach Gtk build about window.internals
2576         https://bugs.webkit.org/show_bug.cgi?id=61071
2577
2578         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2579         (webViewWindowObjectCleared): Inject the new internals object when the
2580         window object clears.
2581         * GNUmakefile.am: Add new source files and includes necessary for window.internals.
2582         Also do a little bit of cleanup.
2583
2584 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
2585
2586         Reviewed by Tony Chang.
2587
2588         Worker may not be stopped after LT.
2589         https://bugs.webkit.org/show_bug.cgi?id=61847
2590
2591         Re-submit a variant of the first fix for this bug. It's possible
2592         that actually calling cleanup() in the worker threads was taking
2593         too long and we triggered the assertions in the manager thread.
2594
2595         I've bumped up the timeout in the manager and added better
2596         diagnostics. I also cleaned up the cleanup() code a bit because
2597         there was some unnecessary if-checks.
2598
2599         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2600         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2601
2602 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
2603
2604         Reviewed by Tony Chang.
2605
2606         nrwt: fix duplicate logging regression
2607         https://bugs.webkit.org/show_bug.cgi?id=61981
2608
2609         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2610
2611 2011-06-03  Robert Kroeger  <rjkroege@chromium.org>
2612
2613         Reviewed by Adam Barth.
2614
2615         Modified addTouchPoint to correctly re-use touchPoint id values starting
2616         from the lowest not-un-use touchPoint id as is done by the embedder
2617         APIs. (Fixes BUGCR36415)
2618
2619         https://bugs.webkit.org/show_bug.cgi?id=62016
2620
2621         * DumpRenderTree/chromium/EventSender.cpp:
2622         (EventSender::addTouchPoint):
2623
2624 2011-06-03  Cary Clark  <caryclark@google.com>
2625
2626         Reviewed by Eric Seidel.
2627
2628         Draw DRT scroll bar thumb with CG when WebKit renders with Skia
2629         https://bugs.webkit.org/show_bug.cgi?id=61534
2630
2631         Skia on Mac uses Skia to render WebKit, and CG
2632         to render UI elements. The CG elements need a
2633         transcribed graphics context that preserves the
2634         canvas matrix, and the canvas clip.
2635
2636         The SkiaBitLocker utility class sets up a CGContext
2637         from the SkCanvas, locks the bitmap's bits, and
2638         releases the lock when the class goes out of scope.
2639
2640         The SkiaBitLocker implementation is described by
2641         this patch:
2642         http://codereview.chromium.org/7031006/
2643
2644         When WebKit uses Skia for rendering, the WebCanvas
2645         is an SkCanvas. Create an equivalent CGContext to
2646         draw the scrollbar thumb.
2647
2648         As the Chrome Mac port does not yet use Skia, this
2649         patch has no effect and requires no tests.
2650
2651         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2652         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2653
2654 2011-06-03  Andras Becsi  <abecsi@webkit.org>
2655
2656         Unreviewed build fix.
2657
2658         Fix typo.
2659
2660         * Scripts/old-run-webkit-tests:
2661
2662 2011-06-03  Andras Becsi  <abecsi@webkit.org>
2663
2664         Reviewed by Csaba Osztrogonác.
2665
2666         Print error message when there is no httpd present on the system
2667         https://bugs.webkit.org/show_bug.cgi?id=61939
2668
2669         * Scripts/old-run-webkit-tests: Propose to run with --no-httpd.
2670         * Scripts/webkitperl/httpd.pm:
2671
2672 2011-06-03  Mikhail Naganov  <mnaganov@chromium.org>
2673
2674         Reviewed by Yury Semikhatsky.
2675
2676         Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug.
2677         https://bugs.webkit.org/show_bug.cgi?id=61533
2678
2679         Skip cpu-profiler-profiling in debug, implement a fast headless alternative.
2680
2681         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2682         (DRTDevToolsAgent::setJavaScriptProfilingEnabled):
2683         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2684         * DumpRenderTree/chromium/LayoutTestController.cpp:
2685         (LayoutTestController::LayoutTestController):
2686         (LayoutTestController::setJavaScriptProfilingEnabled):
2687         * DumpRenderTree/chromium/LayoutTestController.h:
2688         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2689         (LayoutTestController::setJavaScriptProfilingEnabled):
2690         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2691         (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
2692         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2693
2694 2011-06-02  Dirk Pranke  <dpranke@chromium.org>
2695
2696         Reviewed by Tony Chang.
2697
2698         NRWT needs a way to log to a file without including backspaces without needing --verbose
2699         https://bugs.webkit.org/show_bug.cgi?id=60328
2700
2701         This change modifies NRWT so that if it can tell if it is
2702         writing to a terminal, it will overwrite any messages printed
2703         in the 'one-line-progress' and 'updates' print options, and if
2704         not (or if --verbose was specified) the messages will be printed
2705         without backspaces.
2706
2707         If the overwriting updates are disabled, one-line-progress will
2708         only print every 10 seconds instead of on every update. This
2709         ensures that we still get updates once in a while while the
2710         tests are running, even if we're not in --verbose mode. Note
2711         that one-line-progress will now still be printed in --verbose,
2712         since it's useful as long as you're not flooded with the
2713         updates.
2714
2715         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2716         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2717         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2718
2719 2011-06-02  Martin Robinson  <mrobinson@igalia.com>
2720
2721         Reviewed by Gustavo Noronha Silva.
2722
2723         [GTK] autogen.sh is run twice for each buld on the bots
2724         https://bugs.webkit.org/show_bug.cgi?id=61951
2725
2726         * Scripts/webkitdirs.pm: Only check the previous autotools arguments
2727         for the WebKit project. This prevents build-jsc runs from forcing subsequent
2728         build-webkit runs to re-rerun autogen.sh.
2729
2730 2011-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2731
2732         Unreviewed, rolling out r87946.
2733         http://trac.webkit.org/changeset/87946
2734         https://bugs.webkit.org/show_bug.cgi?id=61965
2735
2736         Cause NRWT to break (Requested by abarth|gardener on #webkit).
2737
2738         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2739
2740 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
2741
2742         Reviewed by Darin Adler.
2743
2744         Add build logistics and plumbing for window.internals object.
2745         https://bugs.webkit.org/show_bug.cgi?id=60313
2746
2747         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
2748         * DumpRenderTree/chromium/TestShell.cpp:
2749         (TestShell::bindJSObjectsToWindow): Added injection code.
2750         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2751         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
2752
2753 2011-06-02  Hao Zheng  <zhenghao@chromium.org>
2754
2755         Reviewed by Dirk Pranke.
2756
2757         Call cleanup() explicitly at the end of worker.run().
2758         https://bugs.webkit.org/show_bug.cgi?id=61847
2759
2760         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2761
2762 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
2763
2764         Unreviewed, rolling out r87926.
2765         http://trac.webkit.org/changeset/87926
2766         https://bugs.webkit.org/show_bug.cgi?id=60313
2767
2768         Fails to find WebCoreTestSupport.dylib on bots.
2769
2770         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2771         * DumpRenderTree/chromium/TestShell.cpp:
2772         (TestShell::bindJSObjectsToWindow):
2773         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2774         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
2775
2776 2011-05-21  Dimitri Glazkov  <dglazkov@chromium.org>
2777
2778         Reviewed by Darin Adler.
2779
2780         Add build logistics and plumbing for window.internals object.
2781         https://bugs.webkit.org/show_bug.cgi?id=60313
2782
2783         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
2784         * DumpRenderTree/chromium/TestShell.cpp:
2785         (TestShell::bindJSObjectsToWindow): Added injection code.
2786         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2787         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
2788
2789 2011-06-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2790
2791         Reviewed by Eric Seidel.
2792
2793         Adjust efl coding style to more efl directories
2794         https://bugs.webkit.org/show_bug.cgi?id=61903
2795
2796         * Scripts/webkitpy/style/checker.py: Adjust efl coding style to efl directories.
2797
2798 2011-06-01  Dirk Pranke  <dpranke@chromium.org>
2799
2800         Reviewed by Tony Chang.
2801
2802         old-run-webkit-tests: add support for audio files
2803         https://bugs.webkit.org/show_bug.cgi?id=57992
2804
2805         * Scripts/old-run-webkit-tests:
2806
2807 2011-06-01  Jochen Eisinger  <jochen@chromium.org>
2808
2809         Reviewed by Adam Barth.
2810
2811         Implement layoutTestController.setImagesAllowed for controlling the respective behavior of the WebPermissionClient
2812         https://bugs.webkit.org/show_bug.cgi?id=34314
2813
2814         * DumpRenderTree/DumpRenderTree.gypi:
2815         * DumpRenderTree/chromium/LayoutTestController.cpp:
2816         (LayoutTestController::LayoutTestController):
2817         (LayoutTestController::setImagesAllowed):
2818         (LayoutTestController::setStorageAllowed):
2819         * DumpRenderTree/chromium/LayoutTestController.h:
2820         * DumpRenderTree/chromium/WebPermissions.cpp: Copied from Tools/DumpRenderTree/chromium/WebPermissions.h.
2821         (WebPermissions::WebPermissions):
2822         (WebPermissions::~WebPermissions):
2823         (WebPermissions::allowImages):
2824         (WebPermissions::allowStorage):
2825         (WebPermissions::setImagesAllowed):
2826         (WebPermissions::setStorageAllowed):
2827         (WebPermissions::reset):
2828         * DumpRenderTree/chromium/WebPermissions.h:
2829
2830 2011-06-01  Noel Gordon  <noel.gordon@gmail.com>
2831
2832         Reviewed by Tony Chang.
2833
2834         Test plugin should support event logging on the windows port.
2835         https://bugs.webkit.org/show_bug.cgi?id=61721
2836
2837         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2838         (handleEventWin): Well, handle them.
2839
2840 2011-06-01  Daniel Cheng  <dcheng@chromium.org>
2841
2842         Reviewed by Tony Chang.
2843
2844         [chromium] Use correct file name for dragging out images.
2845         https://bugs.webkit.org/show_bug.cgi?id=24887
2846
2847         * DumpRenderTree/chromium/EventSender.cpp:
2848         (EventSender::EventSender):
2849         (EventSender::dumpFilenameBeingDragged):
2850         * DumpRenderTree/chromium/EventSender.h:
2851
2852 2011-06-01  Dirk Pranke  <dpranke@chromium.org>
2853
2854         Reviewed by Tony Chang.
2855
2856         nrwt: make webaudio work w/o content-length header
2857         https://bugs.webkit.org/show_bug.cgi?id=61819
2858
2859         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2860         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2861         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2862         * Scripts/webkitpy/layout_tests/port/webkit.py:
2863
2864 2011-06-01  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
2865
2866         Reviewed by Andreas Kling.
2867
2868         [Qt][WK2] Add QGLWidget viewport support to MiniBrowser
2869         https://bugs.webkit.org/show_bug.cgi?id=61802
2870
2871         Add command line parameter and menu item to MiniBrowser application 
2872         enabling use of QGLWidget for browser viewport.
2873
2874         * MiniBrowser/qt/BrowserWindow.cpp:
2875         (BrowserWindow::BrowserWindow):
2876         (BrowserWindow::toggleGLViewport):
2877         * MiniBrowser/qt/BrowserWindow.h:
2878         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2879         (MiniBrowserApplication::handleUserOptions):
2880         * MiniBrowser/qt/MiniBrowserApplication.h:
2881         (WindowOptions::WindowOptions):
2882
2883 2011-06-01  Martin Robinson  <mrobinson@igalia.com>
2884
2885         Reviewed by Xan Lopez.
2886
2887         Print out autogen arguments when they differ from the last set, to help
2888         with debugging build issues.
2889
2890         * Scripts/webkitdirs.pm: Print out previous and current build arguments
2891         when they differ.
2892
2893 2011-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2894
2895         Reviewed by Martin Robinson.
2896
2897         [GTK] run-launcher should run MiniBrowser in WebKit2
2898         https://bugs.webkit.org/show_bug.cgi?id=61858
2899
2900         * Scripts/run-launcher: Check whether -2 command line option has
2901         been passed and run MiniBrowser instead of GtkLauncher.
2902
2903 2011-05-31  Hao Zheng  <zhenghao@chromium.org>
2904
2905         Reviewed by Dirk Pranke.
2906
2907         Fix exception in verbose printing mode.
2908         https://bugs.webkit.org/show_bug.cgi?id=61723
2909
2910         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2911
2912 2011-05-31  Yong Li  <yoli@rim.com>
2913
2914         Reviewed by Eric Seidel.
2915
2916         https://bugs.webkit.org/show_bug.cgi?id=54807
2917         We have been assuming plain bitfields (like "int a : 31") are always signed integers.
2918         However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
2919         bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
2920         http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
2921         Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
2922         always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
2923         rule we should have in order to make our code independent from compilers and compiler flags.
2924
2925         * Scripts/webkitpy/style/checkers/cpp.py:
2926
2927 2011-05-31  Hironori Bono  <hbono@chromium.org>
2928
2929         Reviewed by Eric Seidel.
2930
2931         Add a JavaScript function layoutTestController.setTextDirection().
2932         https://bugs.webkit.org/show_bug.cgi?id=50952
2933
2934         This change adds a new JavaScript function setTextDirection() to the
2935         LayoutTestController class of Safari and Chrome to write layout tests
2936         that changes the text direction of an editable element.
2937
2938         * DumpRenderTree/LayoutTestController.cpp:
2939         (setTextDirectionCallback):
2940         (LayoutTestController::staticFunctions):
2941         * DumpRenderTree/LayoutTestController.h:
2942         * DumpRenderTree/chromium/LayoutTestController.cpp:
2943         (LayoutTestController::LayoutTestController):
2944         (LayoutTestController::setTextDirection):
2945         * DumpRenderTree/chromium/LayoutTestController.h:
2946         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2947         (LayoutTestController::setTextDirection):
2948         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2949         (LayoutTestController::setTextDirection):
2950         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2951         (LayoutTestController::setTextDirection):
2952
2953 2011-05-31  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2954
2955         Reviewed by Simon Hausmann.
2956
2957         [Qt] User-agent list of Qt test browsers is very outdated
2958         https://bugs.webkit.org/show_bug.cgi?id=61531
2959
2960         The user can edit the user-agent manually, so there's no need to have
2961         a super complete and up to date list, but it's nice to have it
2962         minimally updated.
2963
2964         * MiniBrowser/qt/useragentlist.txt:
2965         * QtTestBrowser/useragentlist.txt:
2966
2967 2011-03-30  Martin Robinson  <mrobinson@igalia.com>
2968
2969         Reviewed by Adam Roben.
2970
2971         [GTK] [WebKit2] Implement a basic WebKitTestRunner
2972         https://bugs.webkit.org/show_bug.cgi?id=57068
2973
2974         Add an implementation of WebKitTestRunner for GTK+.
2975
2976         * Scripts/build-webkittestrunner: Added knowledge of GTK+ TestRunner.
2977         * Scripts/old-run-webkit-tests: Ditto.
2978         * Scripts/run-launcher: Ditto.
2979         * Scripts/webkitdirs.pm: Ditto.
2980         * WebKitTestRunner/GNUmakefile.am: Added.
2981         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2982         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp: Added.
2983         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
2984         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
2985         * WebKitTestRunner/PlatformWebView.h:
2986         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Added.
2987         * WebKitTestRunner/gtk/TestControllerGtk.cpp: Added.
2988         * WebKitTestRunner/gtk/TestInvocationGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
2989         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2990         * WebKitTestRunner/gtk/main.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
2991         (main): Added.
2992
2993 2011-05-31  Dirk Pranke  <dpranke@chromium.org>
2994
2995         Reviewed by Tony Chang.
2996
2997         new-run-webkit-tests: doesn't wait for children if it gets a ctrl-c
2998         https://bugs.webkit.org/show_bug.cgi?id=60241
2999
3000         * Scripts/new-run-webkit-tests:
3001
3002 2011-05-31  Eric Seidel  <eric@webkit.org>
3003
3004         Reviewed by David Kilzer.
3005
3006         webkitpy should create zips with zip -9
3007         https://bugs.webkit.org/show_bug.cgi?id=61789
3008
3009         Dave Kilzer suggested we add this to make zips uploaded to bugzilla smaller.
3010
3011         * Scripts/webkitpy/common/system/workspace.py:
3012         * Scripts/webkitpy/common/system/workspace_unittest.py:
3013
3014 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
3015
3016         Reviewed by Csaba Osztrogonác.
3017
3018         [Qt] Implement find feature for QtTestBrowser
3019         https://bugs.webkit.org/show_bug.cgi?id=61425
3020
3021         Buildfix for --minimal and CONFIG+=qt_minimal build.
3022
3023         * QtTestBrowser/launcherwindow.cpp:
3024         (LauncherWindow::LauncherWindow):
3025         (LauncherWindow::createChrome):
3026         * QtTestBrowser/launcherwindow.h:
3027
3028 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
3029
3030         Reviewed by Csaba Osztrogonác.
3031
3032         [Qt] Implement find feature for QtTestBrowser
3033         https://bugs.webkit.org/show_bug.cgi?id=61425
3034
3035         * QtTestBrowser/launcherwindow.cpp:
3036         (LauncherWindow::LauncherWindow):
3037         (LauncherWindow::createChrome):
3038         (LauncherWindow::showFindBar):
3039         (LauncherWindow::find):
3040         * QtTestBrowser/launcherwindow.h:
3041
3042 2011-05-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3043
3044         Reviewed by Martin Robinson.
3045
3046         [GTK] Implement JavaScript dialogs in MiniBrowser
3047         https://bugs.webkit.org/show_bug.cgi?id=61725
3048
3049         * MiniBrowser/gtk/BrowserWindow.c:
3050         (WKStringGetCString): Helper function to get a UTF-8 c string from
3051         a WKStringRef.
3052         (WKURLGetCString): Helper function to get a UTF-8 c string from a
3053         WKURLRef.
3054         (browserWindowUpdateURL): Update to use WKURLGetCString.
3055         (didReceiveTitleForFrame): Update to use WKStringGetCString.
3056         (createMessageDialog): Create a GtkMessageDialog.
3057         (runJavaScriptAlert):
3058         (runJavaScriptConfirm):
3059         (runJavaScriptPrompt):
3060         (browserWindowUIClientInit):
3061
3062 2011-05-29  Yuta Kitamura  <yutak@chromium.org>
3063
3064         Reviewed by Kent Tamura.
3065
3066         WebSocket closing handshake
3067         https://bugs.webkit.org/show_bug.cgi?id=35721
3068
3069         * Scripts/webkitpy/thirdparty/__init__.py:
3070         Pull in pywebsocket 0.6b1. We need to update pywebsocket
3071         to get the right behavior of closing handshake.
3072
3073 2011-05-29  Daniel Bates  <dbates@rim.com>
3074
3075         Reviewed by David Kilzer.
3076
3077         REGRESSION (r86515): svn-apply ignores diffs that omit line count in chunk range
3078         https://bugs.webkit.org/show_bug.cgi?id=61162
3079
3080         Fixes an issue where svn-apply may ignore a diff that contains a chunk range line
3081         that omits a line count. In particular, the chunk range regular expression does
3082         not match a chunk range line that omits a line count. GNU diff(1) will omit the
3083         line count in the chunk range if the line count is exactly 1. For example, appending
3084         a new line to the end of an existing file F that contains exactly one line of text will
3085         be represented in a diff with a chunk range line that omits the line count for F.
3086
3087         * Scripts/VCSUtils.pm:
3088           (parseChunkRange): Added.
3089         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl: Added.
3090         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
3091           - Added unit test "Git: Append new line to the end of an existing file".
3092
3093 2011-05-28  Adam Barth  <abarth@webkit.org>
3094
3095         Reviewed by Eric Seidel.
3096
3097         EWS builds patches that fail to build twice, which seems useless and slows down the bots
3098         https://bugs.webkit.org/show_bug.cgi?id=55585
3099
3100         This patch switches all the early warning system bots over to the new
3101         PatchAnalysisTask-based infrastructure.  This patch makes these bots
3102         more efficient (in the case where patches fail to build) and paves the
3103         way for running tests on these bots!
3104
3105         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3106         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
3107         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3108         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3109         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3110         * Scripts/webkitpy/tool/commands/queues.py:
3111
3112 2011-05-28  Kenichi Ishibashi  <bashi@chromium.org>
3113
3114         Reviewed by Kent Tamura.
3115
3116         Add bashi as a committer.
3117
3118         https://bugs.webkit.org/show_bug.cgi?id=61685
3119
3120         * Scripts/webkitpy/common/config/committers.py:
3121
3122 2011-05-27  Adam Barth  <abarth@webkit.org>
3123
3124         Reviewed by Eric Seidel.
3125
3126         When checking whether the tree is red, the EWS posts a link to the wrong log
3127         https://bugs.webkit.org/show_bug.cgi?id=61072
3128
3129         We need to cache the original script error because that contains the
3130         failure log we want to upload.  If we don't cache that script error,
3131         self._script_error will get overwritten when we sanity check the clean
3132         tree (and it also has test failures).
3133
3134         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3135             - This testing approach is slightly goofy.  We'd like to use
3136               assertRaisesRegexp, but that's not available until Python 2.7.
3137         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3138
3139 2011-05-27  Jochen Eisinger  <jochen@chromium.org>
3140
3141         Reviewed by Adam Barth.
3142
3143         Add layoutTestController.setStorageAllowed() to control whether access
3144         to the localStorage API is enabled via the WebPermissionClient
3145         https://bugs.webkit.org/show_bug.cgi?id=61581
3146
3147         * DumpRenderTree/chromium/LayoutTestController.cpp:
3148         (LayoutTestController::LayoutTestController):
3149         (LayoutTestController::setStorageAllowed):
3150         * DumpRenderTree/chromium/LayoutTestController.h:
3151         * DumpRenderTree/chromium/TestShell.cpp:
3152         (TestShell::TestShell):
3153         (TestShell::createNewWindow):
3154         * DumpRenderTree/chromium/TestShell.h:
3155         * DumpRenderTree/chromium/WebPermissions.h: Added.
3156         (WebPermissions::WebPermissions):
3157         (WebPermissions::allowStorage):
3158         (WebPermissions::setStorageAllowed):
3159         (WebPermissions::reset):
3160
3161 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
3162
3163         Reviewed by Eric Seidel.
3164
3165         NRWT: clean up metered_stream code in preparation for 'nooverwriting' patch
3166         https://bugs.webkit.org/show_bug.cgi?id=60326
3167
3168         This patch removes a lot of the complexity from the
3169         metered_stream implementation that was unnecessary since there
3170         was only one caller and the logic could be coordinated better.
3171
3172         There should be no functional changes in this patch, just code
3173         getting deleted and cleaned up.
3174
3175         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
3176         * Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py:
3177         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3178         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3179
3180 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
3181
3182         Reviewed by Eric Seidel.
3183
3184         NRWT: minor cleanup in printing module
3185         https://bugs.webkit.org/show_bug.cgi?id=60329
3186
3187         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3188
3189 2011-05-27  Steve Lacey  <sjl@chromium.org>
3190
3191         Reviewed by David Levin.
3192
3193         Add sjl@chromium.org as a committer.
3194
3195         https://bugs.webkit.org/show_bug.cgi?id=61672
3196
3197         * Scripts/webkitpy/common/config/committers.py:
3198
3199 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
3200
3201         Reviewed by Adam Barth.
3202
3203         NRWT: remove --print detailed-progress
3204         https://bugs.webkit.org/show_bug.cgi?id=60324
3205
3206         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
3207         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3208         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3209         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3210
3211 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
3212
3213         Reviewed by Ojan Vafai.
3214
3215         NRWT: debug messages from the workers are being logged twice
3216         https://bugs.webkit.org/show_bug.cgi?id=60428
3217
3218         It looks like when the workers are run in separate processes
3219         we end up getting two copies of every log message they print.
3220         This has to do with the multiprocessing module on UNIX cloning
3221         the log configuration in a way I wasn't expecting, and so two
3222         log handlers end up getting registered.
3223
3224         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
3225         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3226         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3227         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3228
3229 2011-05-27  Adam Roben  <aroben@apple.com>
3230
3231         Always decode tester names from location.hash
3232
3233         When navigating directly to a tester-specific URL (e.g.,
3234         <http://build.webkit.org/TestFailures/#/Windows%207%20Release%20(Tests)>), you could end up
3235         with a URL-encoded tester name in the page, and then the encoded name could make its way
3236         into Bugzilla bugs. Bad!
3237
3238         Reviewed by David Kilzer.
3239
3240         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
3241         (ViewController.prototype.parseHash): Pass the tester name we got from location.hash through
3242         decodeURIComponent before trying to use it.
3243
3244 2011-05-27  Adam Roben  <aroben@apple.com>
3245
3246         Remove testing code that snuck into r87528
3247
3248         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
3249         (ViewController.prototype._domForNewBugLink): Remove a line I was using for some testing.
3250
3251 2011-05-27  Adam Roben  <aroben@apple.com>
3252
3253         Add links to TestFailures to easily file bugs about failing tests
3254
3255         Fixes <http://webkit.org/b/61636> <rdar://problem/9514886> TestFailures page should have
3256         links to file bugs for failing tests
3257
3258         Reviewed by David Kilzer.
3259
3260         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
3261         (Builder.prototype.resultsPageURL): New helper function to return the URL to results.html
3262         for a particular build.
3263         (Builder.prototype._getFailingTests): Use resultsPageURL.
3264
3265         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
3266         (ViewController.prototype._displayBuilder): Add links to file bugs about each set of
3267         failures.
3268         (ViewController.prototype._domForBuildName): Use resultsPageURL.
3269         (ViewController.prototype._domForNewBugLink): Added. Creates an element that represents the
3270         new bug link. The bug has a title, description, and URL already filled in for you!
3271
3272 2011-05-27  Sheriff Bot  <webkit.review.bot@gmail.com>
3273
3274         Unreviewed, rolling out r87464.
3275         http://trac.webkit.org/changeset/87464
3276         https://bugs.webkit.org/show_bug.cgi?id=61643
3277
3278         client-close/server-close tests are flaky on Chromium Mac and
3279         Windows (Requested by aklein on #webkit).
3280
3281         * Scripts/webkitpy/thirdparty/__init__.py:
3282
3283 2011-05-27  Alexey Proskuryakov  <ap@apple.com>
3284
3285         Added Douglas Davidson to contributors list for easier CC'ing.
3286
3287         * Scripts/webkitpy/common/config/committers.py:
3288
3289 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
3290
3291         Reviewed by Adam Barth.
3292
3293         Fix worldID and destinationDomain argument names
3294         https://bugs.webkit.org/show_bug.cgi?id=61571
3295
3296         As part of working on r87423, I noticed a couple of inconsistencies in
3297         argument names:
3298         - We would use worldId in .h files but worldID in .cpp files.
3299           Standardize on the latter
3300         - SecurityOrigin::addOriginAccessWhitelistEntry would take a
3301           destinationDomains argument, even though the actual parameter was for
3302           a single domain (renamed to be singular).
3303
3304         * DumpRenderTree/LayoutTestController.h:
3305         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3306         (LayoutTestController::evaluateScriptInIsolatedWorld):
3307
3308 2011-05-26  Yuta Kitamura  <yutak@chromium.org>
3309
3310         Reviewed by Kent Tamura.
3311
3312         WebSocket closing handshake
3313         https://bugs.webkit.org/show_bug.cgi?id=35721
3314
3315         * Scripts/webkitpy/thirdparty/__init__.py:
3316         Pull in pywebsocket 0.6b1. We need to update pywebsocket
3317         to get the right behavior of closing handshake.
3318
3319 2011-05-26  Qi Zhang  <qi.2.zhang@nokia.com>
3320
3321         Reviewed by Andreas Kling.
3322
3323         WebKitTestRunner needs layoutTestController.setAuthorAndUserStylesEnabled
3324         https://bugs.webkit.org/show_bug.cgi?id=42676
3325
3326         Implemented layoutTestController.setAuthorAndUserStylesEnabled for WebKitTestRunner.
3327
3328         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3329         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3330         (WTR::InjectedBundle::beginTesting):
3331         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3332         (WTR::LayoutTestController::setAuthorAndUserStylesEnabled):
3333         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3334
3335 2011-05-26  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
3336
3337         Reviewed by Andreas Kling.
3338
3339         [Qt] QtTestBrowser "Switch User Agent" dialog is broken
3340         https://bugs.webkit.org/show_bug.cgi?id=61527
3341
3342         The setMaximumHeight() call is unecessary and breaks the dialog at
3343         least on my setup.
3344
3345         * QtTestBrowser/launcherwindow.cpp:
3346         (LauncherWindow::showUserAgentDialog):
3347
3348 2011-05-02  Robert Hogan  <robert@webkit.org>
3349
3350         Reviewed by Adam Roben.
3351
3352         [Qt] Allow popup windows from plugins when initiated by a user gesture
3353
3354         https://bugs.webkit.org/show_bug.cgi?id=41292
3355
3356         Support parameters introduced in plugin-initiate-popup-window.html
3357
3358         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3359         (webkit_test_plugin_new_instance):
3360         (webkit_test_plugin_handle_event):
3361
3362 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
3363
3364         Reviewed by Adam Barth.
3365
3366         Support cross-origin XMLHttpRequest in isolated worlds
3367         https://bugs.webkit.org/show_bug.cgi?id=59843
3368
3369         Expose setIsolatedWorldSecurityOrigin in LayoutTestController.
3370
3371         * DumpRenderTree/chromium/LayoutTestController.cpp:
3372         (LayoutTestController::LayoutTestController):
3373         (LayoutTestController::setIsolatedWorldSecurityOrigin):
3374         * DumpRenderTree/chromium/LayoutTestController.h:
3375
3376 2011-05-25  Brian Weinstein  <bweinstein@apple.com>
3377
3378         Reviewed by Adam Roben.
3379
3380         WebKit2: Status bar, toolbar, and menu bar checks should be in the injected bundle
3381         https://bugs.webkit.org/show_bug.cgi?id=61474
3382         <rdar://problem/9468337>
3383
3384         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3385         (WTR::InjectedBundlePage::InjectedBundlePage): Add empty entries in the WKBundlePageUIClient.
3386
3387 2011-05-26  Andreas Kling  <kling@webkit.org>
3388
3389         Unreviewed, correct address to webkit-committers mailing list.
3390
3391         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3392
3393 2011-05-25  Adam Roben  <aroben@apple.com>
3394
3395         Don't assume that builds finish in the order they were started
3396
3397         Fixes <http://webkit.org/b/61464> TestFailures page shows failures from a not-most-recent
3398         build when one slave is taking a long time to finish a build
3399
3400         Reviewed by Antti Koivisto.
3401
3402         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
3403         (Builder.prototype.getMostRecentCompletedBuildNumber): Don't assume that all builds that are
3404         newer than the oldest in-progress build are also themselves in progress. Just check whether
3405         each build is actually in progress (as signified by its presence in the currentBuilds set).
3406
3407 2011-05-25  Adam Roben  <aroben@apple.com>
3408
3409         Correctly detect cases where only a single test failed/crashed/timed out
3410
3411         Fixes <http://webkit.org/b/61463> TestFailures page doesn't show testers with only a single
3412         failing test
3413
3414         Reviewed by Darin Adler.
3415
3416         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
3417         (Builder.prototype.getNumberOfFailingTests): Don't require "test cases" to be plural. It
3418         will be singular when only a single test fails/crashes/times out.
3419
3420         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
3421         (ViewController.prototype._displayTesters): Only pluralize "test" when more than one test
3422         failed/crashed/timed out.
3423
3424 2011-05-26  Tom Hudson  <tomhudson@google.com>
3425
3426         Reviewed by Tony Chang.
3427
3428         Add flags to Chromium ImageDiff to write image comparison metrics on
3429         stdout.
3430         https://bugs.webkit.org/show_bug.cgi?id=60569
3431
3432         * DumpRenderTree/chromium/ImageDiff.cpp:
3433         (Image::createFromStdin): Fix spelling.
3434         (maxOf3): New function to do 3-way maximum.
3435         (getRedComponent): Extract red component from ABGR packed encoding.
3436         (getGreenComponent): Extract green component from ABGR packed encoding.
3437         (getBlueComponent): Extract blue component from ABGR packed encoding.
3438         (weightedPercentageDifferent): Determine % of pixels different in two
3439         images multiplied by intensity difference of each pixel.
3440         (printHelp): Document new arguments.
3441         (compareImages): Parameterize.
3442         (untestedCompareImages): Parameterize.
3443         (diffImages): Parameterize; write results on stdout if requested.
3444         (main): Parse new arguments.
3445
3446 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
3447
3448         Reviewed by Simon Hausmann.
3449
3450         WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
3451         https://bugs.webkit.org/show_bug.cgi?id=42697
3452
3453         Implemented layoutTestController.setPrivateBrowsingEnabled for WebKitTestRunner.
3454
3455         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3456         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3457         (WTR::InjectedBundle::beginTesting):
3458         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3459         (WTR::LayoutTestController::setPrivateBrowsingEnabled):
3460         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3461
3462 2011-05-25  Jon Honeycutt  <jhoneycutt@apple.com>
3463
3464         REGRESSION (WebKit2): Crash in Flash on USA Today photo gallery
3465         https://bugs.webkit.org/show_bug.cgi?id=61428
3466         <rdar://problem/9457006>
3467
3468         Reviewed by Adam Roben.
3469
3470         The crash occurs when Flash posts a message to a window that it
3471         creates, and in processing the message, it calls NPN_Evaluate to
3472         evaluate JavaScript that removes the plug-in from the page. Flash then
3473         crashes when we return to Flash code.
3474
3475         This test emulates that behavior.
3476
3477         * DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp: Added.
3478         (CallJSThatDestroysPlugin::CallJSThatDestroysPlugin):
3479         Initialize member vars.
3480         (CallJSThatDestroysPlugin::~CallJSThatDestroysPlugin):
3481         Remove our custom property from the message window, and destroy it.
3482         (CallJSThatDestroysPlugin::NPP_Destroy):
3483         Set m_isDestroyed, log that the plug-in was destroyed, and notify the
3484         layout test controller that we're done.
3485         (wndProc):
3486         Get the PluginTest object, and call its runTest() function.
3487         (CallJSThatDestroysPlugin::NPP_New):
3488         Setup the test: register a class for the message-only window, create
3489         it, and post a message to it to run the test.
3490         (CallJSThatDestroysPlugin::runTest):
3491         Execute JS that removes the plug-in from the page, and if we're not
3492         destroyed, log a success message.
3493
3494         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3495         Add new test to project.
3496
3497 2011-05-25  Tony Chang  <tony@chromium.org>
3498
3499         Reviewed by Adam Barth.
3500
3501         webkitpy's NetworkTransaction shouldn't use mechanize
3502         https://bugs.webkit.org/show_bug.cgi?id=61450
3503
3504         mechanize.HTTPError is just an alias for urllib2.HTTPError, so
3505         use urllib2 directly.  Re-add NetworkTransaction to
3506         test_results_uploader.py (reverting r87124).
3507
3508         * Scripts/webkitpy/common/net/networktransaction.py:
3509         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
3510
3511 2011-05-25  Kevin Ollivier  <kevino@theolliviers.com>
3512
3513         [Chromium] Unreviewed build fix. Do not define WTF/JS_EXPORT_PRIVATE to JS_EXPORTDATA
3514         until the port begins using those export macros.
3515
3516         * DumpRenderTree/chromium/config.h:
3517
3518 2011-05-25  Sheriff Bot  <webkit.review.bot@gmail.com>
3519
3520         Unreviewed, rolling out r87257.
3521         http://trac.webkit.org/changeset/87257
3522         https://bugs.webkit.org/show_bug.cgi?id=61457
3523
3524         This broke layout tests, see bug 61431. (Requested by
3525         hwennborg on #webkit).
3526
3527         * DumpRenderTree/chromium/LayoutTestController.cpp:
3528         (LayoutTestController::LayoutTestController):
3529         (LayoutTestController::clearAllDatabases):
3530         * DumpRenderTree/chromium/LayoutTestController.h:
3531
3532 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
3533
3534         Reviewed by Andreas Kling.
3535
3536         [Qt] fast/css/disabled-author-styles.html failed
3537         https://bugs.webkit.org/show_bug.cgi?id=61438
3538
3539         Implemented API setAuthorAndUserStylesEnabled in LayoutTestControllerQt.
3540
3541         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3542         (WebCore::WebPage::resetSettings):
3543         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3544         (LayoutTestController::setAuthorAndUserStylesEnabled):
3545         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3546
3547 2011-05-25  Adam Roben  <aroben@apple.com>
3548
3549         Identify, rather than skip, builds where run-webkit-tests exited early due to too many failures
3550
3551         Fixes <http://webkit.org/b/61441> TestFailures page should show when run-webkit-tests
3552         started exiting early due to too many crashes, timeouts, or failures
3553
3554         Reviewed by David Kilzer.
3555
3556         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
3557         (Builder.prototype.getNumberOfFailingTests): Rather than returning -1 ("unknown") when
3558         run-webkit-tests exits early due to too many failures, pass that information in another
3559         argument to the callback.
3560         (Builder.prototype.startFetchingBuildHistory): Updated the documentation comment to reflect
3561         the new structure of the object passed to the callback.
3562         (Builder.prototype._getFailingTests): Updated to expect a tooManyFailures boolean from
3563         getNumberOfFailingTests and to pass that along to our own callbacks.
3564         (Builder.prototype._incorporateBuildHistory): Updated to expect a tooManyFailures boolean
3565         from _getFailingTests and to store that value in the history object.
3566
3567         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
3568         (.info): Added.
3569
3570         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
3571         (ViewController.prototype._displayBuilder): Updated for change in structure to the history
3572         object and to add a note when run-webkit-tests exited early due to too many failures.
3573         (ViewController.prototype._displayTesters): Renamed testersAndFailureCounts to
3574         latestBuildInfos since each entry now contains more than just the tester and failure count.
3575         Now displays a message for testers where the latest build exited early due to too many
3576         failures. Updated to expect a tooManyFailures boolean from getNumberOfFailingTests and to
3577         store that value in latestBuildInfos.
3578
3579 2011-05-24  Keishi Hattori  <keishi@webkit.org>
3580
3581         Reviewed by Kent Tamura.
3582
3583         Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
3584         https://bugs.webkit.org/show_bug.cgi?id=61273
3585
3586         * Scripts/build-webkit: Added INPUT_COLOR feature flag.
3587
3588 2011-05-24  Greg Simon  <gregsimon@chromium.org>
3589
3590         Reviewed by Dimitri Glazkov.
3591
3592         Control Indexeddb backends from LayoutTestController
3593         https://bugs.webkit.org/show_bug.cgi?id=61000
3594
3595         * DumpRenderTree/chromium/LayoutTestController.cpp:
3596         (LayoutTestController::LayoutTestController):
3597         (LayoutTestController::setOverrideIndexedDBBackingStore):
3598         (LayoutTestController::clearAllDatabases):
3599         * DumpRenderTree/chromium/LayoutTestController.h:
3600
3601 2011-05-24  Robert Hogan  <robert@webkit.org>
3602
3603         Reviewed by Ryosuke Niwa.
3604
3605         [Qt] Fix fast/events/selectstart-by-single-click-with-shift.html
3606         https://bugs.webkit.org/show_bug.cgi?id=61393
3607
3608         * DumpRenderTree/qt/EventSenderQt.h:
3609         * DumpRenderTree/qt/EventSenderQt.cpp:
3610         (getModifiers): static function for interpreting modifiers
3611         (EventSender::mouseDown): Respect keyboard modifiers
3612         (EventSender::keyDown): use new static function
3613         (EventSender::sendOrQueueEvent): whitespace fix
3614
3615 2011-05-24  Jay Civelli  <jcivelli@chromium.org>
3616
3617         Reviewed by Adam Barth.
3618
3619         Adding MHTML reading support.
3620         https://bugs.webkit.org/show_bug.cgi?id=7168
3621
3622         * Scripts/build-webkit:
3623         * Scripts/old-run-webkit-tests:
3624         * Scripts/webkitperl/features.pm:
3625         * Scripts/webkitpy/layout_tests/port/test_files.py:
3626         * Scripts/webkitpy/layout_tests/port/webkit.py:
3627
3628 2011-05-24  Stephen White  <senorblanco@chromium.org>
3629
3630         Reviewed by Kenneth Russell.
3631
3632         Remove most style checks on Source/ThirdParty/glu, since it doesn't
3633         follow WebKit style.
3634         https://bugs.webkit.org/show_bug.cgi?id=61365
3635
3636         * Scripts/webkitpy/style/checker.py:
3637
3638 2011-05-24  Adam Roben  <aroben@apple.com>
3639
3640         Don't allow forcing builds through the build.webkit.org web interface
3641
3642         Someone has been forcing bogus builds.
3643
3644         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3645
3646 2011-05-24  Qi Zhang  <qi.2.zhang@nokia.com>
3647
3648         Reviewed by Adam Roben.
3649
3650         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
3651         https://bugs.webkit.org/show_bug.cgi?id=42669
3652
3653         Fixes the regression issue caused by patch 94265. The patch didn't intialize the setting before the 
3654         layouttest starting, it will make the test cases after editing/execCommand/clipboard-access.html failed.
3655         Because that case changed the setting.
3656
3657         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3658         (WTR::InjectedBundle::beginTesting):
3659
3660 2011-05-24  Csaba Osztrogonác  <ossy@webkit.org>
3661
3662         Reviewed by Kenneth Rohde Christiansen.
3663
3664         [ORWT]Make --skipped=only option work with parameters with LayoutTests/ prefix
3665         https://bugs.webkit.org/show_bug.cgi?id=61052
3666
3667         * Scripts/old-run-webkit-tests:
3668