[Attachment Support] Provide the `src` of an attachment to the UI delegate when an...
[WebKit-https.git] / Tools / ChangeLog
1 2018-01-16  Wenson Hsieh  <wenson_hsieh@apple.com>
2
3         [Attachment Support] Provide the `src` of an attachment to the UI delegate when an attachment is inserted
4         https://bugs.webkit.org/show_bug.cgi?id=181638
5         <rdar://problem/36508702>
6
7         Reviewed by Dan Bernstein.
8
9         Tweak an existing API test to check that the `src` of an attachment element inserted via script matches the
10         `source` provided to the UI delegate via -[WKUIDelegate _webView:didInsertAttachment:withSource:].
11
12         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
13         (-[AttachmentUpdateObserver init]):
14         (-[AttachmentUpdateObserver sourceForIdentifier:]):
15         (-[AttachmentUpdateObserver _webView:didInsertAttachment:withSource:]):
16         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::expectSourceForIdentifier):
17         (TestWebKitAPI::TEST):
18         (-[AttachmentUpdateObserver _webView:didInsertAttachment:]): Deleted.
19
20 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
21
22         Unreviewed. Fix GTK unit tests execution in the bots after r226967.
23
24         I forgot to pass the environment to the GLibTestRunner and Xvfb was not used in the bots.
25
26         * glib/api_test_runner.py:
27         (TestRunner._run_test_glib): Pass env to GLibTestRunner.
28         * glib/glib_test_runner.py:
29         (GLibTestRunner.run): Use given env.
30
31 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
32
33         [GTK][WPE] Stop passing --verbose to run-api-tests from the bots
34         https://bugs.webkit.org/show_bug.cgi?id=181676
35
36         Reviewed by Carlos Alberto Lopez Perez.
37
38         The option was removed in r226967.
39
40         * BuildSlaveSupport/build.webkit.org-config/steps.py:
41         (RunGtkAPITests):
42         (RunWPEAPITests):
43
44 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
45
46         Unreviewed. Temporarily bring back --verbose option of api_test_runner.py.
47
48         The bots are still passing that option and the step is failing because it was removed in r226967.
49
50         * glib/api_test_runner.py:
51         (add_options):
52
53 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
54
55         [GTK][WPE] Improve the way glib tests are run
56         https://bugs.webkit.org/show_bug.cgi?id=181674
57
58         Reviewed by Žan Doberšek.
59
60         Stop using gtester external program and use our own tester from python directly. This way we no longer need to
61         parse the tests output to get the results which is causing problems in WPE bot. We can now differentiate between
62         tests failing due to an expected assert in the test and unexpected crashes.
63         This also fixes a bug in previous code where we failed to properly detect tests timing out, because gtester was
64         not showing the subtest name in stdout in case of timeouts.
65         I've lowered the default timeout from 10 to 5, since we are now properly handling the timeout for every test
66         case. I've also removed the verbose option, since it was only used by gtester and we now always show the result
67         of every test case.
68
69         * glib/api_test_runner.py:
70         (TestRunner._run_test_glib): Use GLibTestRunner.
71         (TestRunner._run_google_test): Wrote tests timing out to stdout too.
72         (add_options):
73         * glib/glib_test_runner.py: Added.
74         (TestTimeout):
75         (Message):
76         (Message.__init__):
77         (Message.create):
78         (Message.create.read_unsigned):
79         (Message.create.read_double):
80         (Message.create.read_string):
81         (GLibTestRunner):
82         (GLibTestRunner.__init__):
83         (GLibTestRunner._process_data):
84         (GLibTestRunner._process_message):
85         (GLibTestRunner._read_from_pipe):
86         (GLibTestRunner._read_from_stderr):
87         (GLibTestRunner._start_timeout):
88         (GLibTestRunner._start_timeout._alarm_handler):
89         (GLibTestRunner._stop_timeout):
90         (GLibTestRunner._subtest_start):
91         (GLibTestRunner._subtest_message):
92         (GLibTestRunner._subtest_stderr):
93         (GLibTestRunner._subtest_end):
94         (GLibTestRunner.run):
95
96 2018-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
97
98         Unreviewed, add Thibault to contributors.json
99
100         It's a bit weird to add someone here before their first contribution, but this affects
101         Bugzilla autocomplete, and that is serious business.
102
103         * Scripts/webkitpy/common/config/contributors.json:
104
105 2018-01-15  JF Bastien  <jfbastien@apple.com>
106
107         Remove makePoisonedUnique
108         https://bugs.webkit.org/show_bug.cgi?id=181630
109         <rdar://problem/36498623>
110
111         Reviewed by Mark Lam.
112
113         Update tests.
114
115         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
116         (TestWebKitAPI::TEST):
117         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
118         (TestWebKitAPI::TEST):
119
120 2018-01-15  Adrian Perez de Castro  <aperez@igalia.com>
121
122         [GTK][JHBuild] Tools/gtk/install-dependencies: Package libxfont does not exist anymore in Arch Linux
123         https://bugs.webkit.org/show_bug.cgi?id=181476
124
125         Reviewed by Michael Catanzaro.
126
127         Update to xorg-server 1.19.6 which depends on libxfont2, and change
128         the lists of packages to install libxfont2-devel (or equivalent).
129
130         * gtk/install-dependencies:
131         * gtk/jhbuild.modules:
132
133 2018-01-15  Carlos Garcia Campos  <cgarcia@igalia.com>
134
135         [GTK][WPE] Add support for unit test expectations
136         https://bugs.webkit.org/show_bug.cgi?id=181589
137
138         Reviewed by Michael Catanzaro.
139
140         We currently have a way to skip tests by annotating them in the api test runner script. The main problem of this
141         approach is that we skip tests when they fail in the bots and we never notice if they stop failing, keeping the
142         tests skipped forever. This is indeed the case of several WebKit2 C API tests. Annotating skipped tests in the
143         script itself is not a good idea either.
144
145         This patch adds a generic TestExpectations class for simple tests based on tests with subtests, like our unit
146         tests, but also WebDriver tests. It parses a json file with the tests and subtests expectations and provides
147         convenient methods to query them.
148
149         * Scripts/run-gtk-tests:
150         (GtkTestRunner): Remove all Skipped and Slow tests marked here.
151         * Scripts/run-wpe-tests:
152         (WPETestRunner): Ditto.
153         * Scripts/webkitpy/common/test_expectations.py: Added.
154         (TestExpectations):
155         (TestExpectations.__init__):
156         (TestExpectations._port_name_for_expected):
157         (TestExpectations._expected_value):
158         (TestExpectations.skipped_tests):
159         (TestExpectations.skipped_subtests):
160         (TestExpectations._expectation_value):
161         (TestExpectations.is_slow):
162         (TestExpectations.get_expectation):
163         * Scripts/webkitpy/common/test_expectations_unittest.py: Added.
164         (MockTestExpectations):
165         (MockTestExpectations.__init__):
166         (MockTestExpectations.is_skip):
167         (ExpectationsTest):
168         (assert_exp):
169         (assert_not_exp):
170         (assert_bad_exp):
171         (assert_skip):
172         (test_basic):
173         (test_skip):
174         (test_flaky):
175         (test_build_type):
176         * TestWebKitAPI/glib/TestExpectations.json: Added.
177         * glib/api_test_runner.py:
178         (TestRunner): Remove SkippedTest implementation.
179         (TestRunner.__init__): Create a TestExpectations.
180         (TestRunner._test_cases_to_skip): Use TestExpectations to check skipped tests.
181         (TestRunner._should_run_test_program): Ditto.
182         (TestRunner._run_test_glib): Use TestExpectations to check if test suite is slow.
183         (TestRunner._run_test_glib.parse_line.set_test_result): Register also tests passing.
184         (TestRunner._run_google_test): Use TestExpectations to check if test cases is slow and register tests passing.
185         (TestRunner.run_tests): Check if actual result is the expected one and register also unexpected passes.
186         (TestRunner.run_tests.report): Helper to write report to stdout.
187
188 2018-01-13  Mark Lam  <mark.lam@apple.com>
189
190         Replace all use of ConstExprPoisoned with Poisoned.
191         https://bugs.webkit.org/show_bug.cgi?id=181542
192         <rdar://problem/36442138>
193
194         Reviewed by JF Bastien.
195
196         1. Converted tests to using new uintptr_t& poison type.
197         2. Added tests for Poisoned comparison operators.
198
199         * TestWebKitAPI/CMakeLists.txt:
200         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
201         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp: Removed.
202         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
203         (TestWebKitAPI::TEST):
204         (TestWebKitAPI::initializeTestPoison): Deleted.
205         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
206         (TestWebKitAPI::TEST):
207         (TestWebKitAPI::passWithRef):
208         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
209         (TestWebKitAPI::TEST):
210         (TestWebKitAPI::f1):
211         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
212         (TestWebKitAPI::TEST):
213         (TestWebKitAPI::poisonedPtrFoo):
214         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
215         (TestWebKitAPI::TEST):
216         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
217         (TestWebKitAPI::TEST):
218
219 2018-01-13  David Kilzer  <ddkilzer@apple.com>
220
221         check-webkit-style: false positive for [whitespace/braces] with os_log format string
222         <https://webkit.org/b/181606>
223
224         Reviewed by Darin Adler.
225
226         * Scripts/webkitpy/style/checkers/cpp.py:
227         (check_spacing): Modify regular expression to ignore
228         os_log format strings like '%{public}'.
229         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
230         (CppStyleTest.test_spacing_before_braces): Add os_log
231         format string test.
232
233 2018-01-12  Wenson Hsieh  <wenson_hsieh@apple.com>
234
235         [macOS] API tests ChangeAttachmentDataUpdatesWithInPlaceDisplay and InPlaceVideoAttachmentInsertionWithinList are failing
236         https://bugs.webkit.org/show_bug.cgi?id=181626
237
238         Reviewed by Joseph Pecoraro.
239
240         Make the web view for WKAttachmentTests slightly bigger to avoid size clamping behavior introduced in r226915.
241         Additionally, write a new API test covering the change in r226915.
242
243         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
244         (webViewForTestingAttachments):
245         (TestWebKitAPI::TEST):
246
247 2018-01-12  Alex Christensen  <achristensen@webkit.org>
248
249         History state should be updated during client redirects with asynchronous policy decisions
250         https://bugs.webkit.org/show_bug.cgi?id=181358
251         <rdar://problem/35547689>
252
253         Reviewed by Andy Estes.
254
255         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
256         (-[AsyncPolicyDecisionDelegate webView:didFinishNavigation:]):
257         (-[AsyncPolicyDecisionDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
258         (TEST):
259
260 2018-01-12  Jonathan Bedard  <jbedard@apple.com>
261
262         webkitpy: Refactor simulator code (Part 4)
263         https://bugs.webkit.org/show_bug.cgi?id=180555
264         <rdar://problem/36131381>
265
266         Reviewed by Aakash Jain.
267
268         Move new_simulated_device.py to simulated_device.py.
269
270         * Scripts/webkitpy/port/ios_simulator.py: Update import statement.
271         * Scripts/webkitpy/xcode/new_simulated_device.py: Removed.
272         * Scripts/webkitpy/xcode/new_simulated_device_unittest.py: Removed.
273         * Scripts/webkitpy/xcode/simulated_device.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device.py.
274         * Scripts/webkitpy/xcode/simulated_device_unittest.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device_unittest.py.
275
276 2018-01-12  Alex Christensen  <achristensen@webkit.org>
277
278         REGRESSION (r226818): API test WebKitLegacy.LoadInvalidURLRequest is failing
279         https://bugs.webkit.org/show_bug.cgi?id=181595
280
281         This test was testing behavior of an invalid URL that WebCore parses but NSURL does not.
282         It was using example.com<> but after r226479 < and > are considered invalid by WebCore.
283         I change the < and > to $ to make this test pass and continue to test what it used to.
284
285         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html:
286         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
287         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
288
289 2018-01-11  Keith Miller  <keith_miller@apple.com>
290
291         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
292         https://bugs.webkit.org/show_bug.cgi?id=181573
293
294         Reviewed by Simon Fraser.
295
296         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
297
298 2018-01-11  Jiewen Tan  <jiewen_tan@apple.com>
299
300         [WebAuthN] Import a CBOR coder from Chromium
301         https://bugs.webkit.org/show_bug.cgi?id=181522
302         <rdar://problem/36055729>
303
304         Reviewed by Brent Fulgham.
305
306         This patch also imports all unit tests into our API tests to ensure all
307         workarounds and modification against the original codebase doesn't change
308         any original functionalities.
309
310         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
311         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp: Added.
312         (TestWebKitAPI::TEST):
313         * TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp: Added.
314         (TestWebKitAPI::TEST):
315         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp: Added.
316         (TestWebKitAPI::eq):
317         Workarounds applied.
318         (TestWebKitAPI::TEST):
319
320 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
321
322         webkitpy: Use partially disambiguated type in SimulatedDeviceManager._disambiguate_device_type
323         https://bugs.webkit.org/show_bug.cgi?id=181538
324         <rdar://problem/36440580>
325
326         Reviewed by Aakash Jain.
327
328         When disambiguating a device type, it is possible that the provided device type is sufficiently
329         ambiguous that the comparisons against complete device types without a disambiguated hardware_family
330         will result in a failure to disambiguate the type.
331
332         * Scripts/webkitpy/xcode/new_simulated_device.py:
333         (SimulatedDeviceManager._disambiguate_device_type):
334
335 2018-01-11  Brent Fulgham  <bfulgham@apple.com>
336
337         REGRESSION(r219530): ResourceLoadStatisticsPersistentStorage should be read-only in ephemeral sessions
338         https://bugs.webkit.org/show_bug.cgi?id=181136
339         <rdar://problem/36116604>
340
341         Reviewed by Chris Dumez.
342
343         Add a new API test to confirm that ResourceLoadStatistics can be turned on safely for ephemeral
344         browsing sessions.
345
346         * Scripts/run-gtk-tests:
347         (GtkTestRunner): Unskip test now that it passes.
348         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
349         (TEST): Add new WebsiteDataStoreEphemeral test.
350
351 2018-01-11  Ryan Haddad  <ryanhaddad@apple.com>
352
353         Unreviewed, rolling out r226816.
354
355         This change broke LayoutTests on the bots.
356
357         Reverted changeset:
358
359         "run-webkit-tests fails when there is a curly brace in Xcode
360         build output"
361         https://bugs.webkit.org/show_bug.cgi?id=181254
362         https://trac.webkit.org/changeset/226816
363
364 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
365
366         webkitpy: Fix flakey webserver tests
367         https://bugs.webkit.org/show_bug.cgi?id=181555
368         <rdar://problem/36448273>
369
370         Reviewed by Aakash Jain.
371
372         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
373         (LayoutTestRunnerTests.test_servers_started): Add and bind custom checks to
374         determine if a specific server is running.
375
376 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
377
378         Commit queue failed to land a bug, 'NoneType' object has no attribute 'strip'
379         https://bugs.webkit.org/show_bug.cgi?id=181561
380         <rdar://problem/36452652>
381
382         Reviewed by Aakash Jain.
383
384         BeautifulSoup.find may return None, this case should be gracefully handled.
385
386         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
387         (BugzillaQueries._parse_result_count):
388         (BugzillaQueries._fetch_bugs_from_advanced_query): Added logging.
389
390 2018-01-11  Alexey Proskuryakov  <ap@apple.com>
391
392         run-webkit-tests fails when there is a curly brace in Xcode build output
393         https://bugs.webkit.org/show_bug.cgi?id=181254
394
395         Reviewed by Daniel Bates.
396
397         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
398         (MeteredStream.write):
399
400 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
401
402         webkitpy: Reimplement simulator code (Part 3)
403         https://bugs.webkit.org/show_bug.cgi?id=180555
404         <rdar://problem/36131381>
405
406         Reviewed by Aakash Jain.
407
408         Remove old simulator code.
409
410         * Scripts/webkitpy/xcode/__init__.py: Remove import statement.
411         * Scripts/webkitpy/xcode/simulated_device.py: Removed.
412         * Scripts/webkitpy/xcode/simulator.py: Removed.
413         * Scripts/webkitpy/xcode/simulator_unittest.py: Removed.
414
415 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
416
417         [Attachment Support] Support moving attachment elements in editable areas using drag and drop
418         https://bugs.webkit.org/show_bug.cgi?id=181337
419         <rdar://problem/36324813>
420
421         Reviewed by Tim Horton.
422
423         Add 3 new API tests for attachment element dragging.
424
425         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
426         (-[TestWKWebView expectElementTag:toComeBefore:]):
427         (-[NSItemProvider expectType:withData:]):
428         (TestWebKitAPI::TEST):
429
430 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
431
432         REGRESSION(r225856): Incorrectly managing 'future' baseline_search_paths. 
433         https://bugs.webkit.org/show_bug.cgi?id=179621
434         <rdar://problem/35589585>
435
436         Unreviewed infrastructure fix.
437
438         * Scripts/webkitpy/port/mac.py:
439         (MacPort.default_baseline_search_path): Include 'future' in the version_fallback
440         list if we are the VERSION_MAX, which usually corresponds with future.
441
442 2018-01-11  Filip Pizlo  <fpizlo@apple.com>
443
444         CodeBlocks should be in IsoSubspaces
445         https://bugs.webkit.org/show_bug.cgi?id=180884
446
447         Reviewed by Saam Barati.
448         
449         Remove some less important benchmarks from the default run. Doing run-jsc-benchmarks
450         shouldn't take a long time due to benchmarks we don't optimize for.
451         
452         * Scripts/run-jsc-benchmarks:
453
454 2018-01-11  Ms2ger  <Ms2ger@igalia.com>
455
456         Test gardening for GTK.
457         https://bugs.webkit.org/show_bug.cgi?id=181477
458
459         Unreviewed test gardening.
460
461         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Correct the file name.
462         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Adjust the expected console message.
463
464 2018-01-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
465
466         Add the new JSCOnly bot to the scheduler.
467         https://bugs.webkit.org/show_bug.cgi?id=181487
468
469         Unreviewed follow-up patch after r226729
470
471         On r226729 I missed to add the new JSCOnly bot the default scheduler.
472         This is needed to make the bot automatically pick each commit for testing.
473
474         * BuildSlaveSupport/build.webkit.org-config/config.json:
475
476 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
477
478         [Attachment Support] Support dragging attachment elements out as files on iOS
479         https://bugs.webkit.org/show_bug.cgi?id=181199
480         <rdar://problem/36299316>
481
482         Reviewed by Tim Horton, Andy Estes and Joseph Pecoraro.
483
484         Add support in the drag and drop simulator for testing blob-backed attachment element dragging, and also add new
485         attachment API tests.
486
487         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
488         (-[NSItemProvider expectType:withData:]):
489         (TestWebKitAPI::TEST):
490
491         Add two new WKAttachmentTests to exercise dragging data- and file-backed blobs via attachment elements. These
492         tests first insert attachments via drop or WKWebView SPI, and then drag these attachments out and use the
493         -expectType:withData: helper to inspect the item providers created from the drag source.
494
495         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
496         (TestWebKitAPI::TEST):
497         * TestWebKitAPI/ios/DataInteractionSimulator.h:
498         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
499         (-[MockDragSession localContext]):
500         (-[MockDragSession setLocalContext:]):
501         (-[DataInteractionSimulator _resetSimulatedState]):
502         (-[DataInteractionSimulator simulateAllTouchesCanceled:]):
503         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
504         (-[DataInteractionSimulator _advanceProgress]):
505         (-[DataInteractionSimulator endDataTransfer]):
506
507         Make some tweaks to the iOS drag and drop simulator. In particular, this patch (1) adds a new hook to tell
508         WebKit that data transfers have been completed, (2) fixes incorrect drop proposal handling when returning
509         UIDropOperationForbidden by replacing _shouldPerformOperation with a UIDropProposal, and (3) teach the
510         MockDragSession to hold on to a localContext.
511
512 2018-01-11  Ali Juma  <ajuma@chromium.org>
513
514         Unreviewed. Add Ali Juma as contributor
515
516         * Scripts/webkitpy/common/config/contributors.json:
517
518 2018-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
519
520         Unreviewed. Update Selenium WebDriver imported tests.
521
522         New version of selenium uses command line options to pass driver and browser binaries to pytest instead of
523         environment variables.
524
525         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
526         (collect): Reorder the arguments to make pytest happy.
527         (run): Ditto.
528         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
529         (WebDriverSeleniumExecutor.__init__): Add driver binary, browser binary and browser args as arguments.
530
531 2018-01-11  Ling Ho  <lingcherd_ho@apple.com>
532
533         Move Commit Queue and EWS Queues to Sierra on Bot Watcher's Dasboard
534         https://bugs.webkit.org/show_bug.cgi?id=181492
535         <rdar://problem/36359679>
536
537         Reviewed by Alexey Proskuryakov. 
538
539 2018-01-10  Adrian Perez de Castro  <aperez@igalia.com>
540
541         [GTK] Tools/gtk/install-dependencies: Packages geoclue, ruby-highline, xorg-utils do not exist in Arch Linux
542         https://bugs.webkit.org/show_bug.cgi?id=181475
543
544         Reviewed by Michael Catanzaro.
545
546         * gtk/install-dependencies: Update package list for Arch Linux, extend
547         message shown at end of installation with additional tips.
548
549 2018-01-10  Wenson Hsieh  <wenson_hsieh@apple.com>
550
551         REGRESSION(r222507): Composition highlight doesn't render when using IME
552         https://bugs.webkit.org/show_bug.cgi?id=181485
553         <rdar://problem/35896516>
554
555         Reviewed by Ryosuke Niwa.
556
557         Add a `suppressUnderline` argument to TextInputController.setMarkedText. This suppresses the custom underlines
558         rendered when testing IME on iOS in WebKit2. In this new test, suppressing underline rendering is needed to
559         allow rendering composition backgrounds (see InlineTextBox::paint).
560
561         * DumpRenderTree/ios/TextInputControllerIOS.m:
562         (+[TextInputController isSelectorExcludedFromWebScript:]):
563         (+[TextInputController webScriptNameForSelector:]):
564         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
565         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
566         * DumpRenderTree/mac/TextInputControllerMac.m:
567         (+[TextInputController isSelectorExcludedFromWebScript:]):
568         (+[TextInputController webScriptNameForSelector:]):
569         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
570         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
571         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
572         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
573         (WTR::TextInputController::setMarkedText):
574         * WebKitTestRunner/InjectedBundle/TextInputController.h:
575
576 2018-01-10  JF Bastien  <jfbastien@apple.com>
577
578         Poison small JSObject derivatives which only contain pointers
579         https://bugs.webkit.org/show_bug.cgi?id=181483
580         <rdar://problem/36407127>
581
582         Reviewed by Mark Lam.
583
584         Test the new move-assign and move-copy from unique_ptr, as well as
585         nullptr_t ctors.
586
587         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
588         (TestWebKitAPI::TEST):
589         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
590         (TestWebKitAPI::TEST):
591         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
592         (TestWebKitAPI::TEST):
593
594 2018-01-10  Chris Dumez  <cdumez@apple.com>
595
596         Multiple http/wpt/beacon/contentextensions/ test are flaky.
597         https://bugs.webkit.org/show_bug.cgi?id=179256
598         <rdar://problem/35401978>
599
600         Reviewed by Alex Christensen.
601
602         Update WebKitTestRunner to set a temporary path for content extensions so that its WKTR
603         instance gets its own folder to avoid conflicts and flakiness.
604
605         * WebKitTestRunner/mac/TestControllerMac.mm:
606         (WTR::TestController::platformConfigureViewForTest):
607
608 2018-01-10  Tim Horton  <timothy_horton@apple.com>
609
610         REGRESSION (r213590): Swipe from edge to go to previous page is significantly slower than tapping back button on Twitter
611         https://bugs.webkit.org/show_bug.cgi?id=181269
612         <rdar://problem/35110344>
613
614         Reviewed by Simon Fraser.
615
616         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
617         (WTR::UIScriptController::beginBackSwipe):
618         (WTR::UIScriptController::completeBackSwipe):
619         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
620         (WTR::UIScriptController::beginBackSwipe):
621         (WTR::UIScriptController::completeBackSwipe):
622         (WTR::UIScriptController::overridePreference):
623         (WTR::UIScriptController::replaceTextAtRange):
624         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
625         (WTR::PlatformWebView::setNavigationGesturesEnabled):
626         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
627         (WTR::UIScriptController::beginBackSwipe):
628         (WTR::UIScriptController::completeBackSwipe):
629         Implement beginBackSwipe and completeBackSwipe on iOS (they already
630         exist on Mac) in terms of the new WKWebView testing SPI.
631
632 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
633
634         REGRESSION (r226715): ignore WARNING output in linter tests
635         https://bugs.webkit.org/show_bug.cgi?id=181486
636         <rdar://problem/36408847>
637
638         Reviewed by Aakash Jain.
639
640         Linter unit tests should not be interested in logs at the the INFO or WARNING levels.
641
642         * Scripts/webkitpy/common/system/outputcapture.py:
643         (OutputCapture.__init__): Pass logging level to be captured.
644         * Scripts/webkitpy/style/main_unittest.py:
645         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors): Capture logging at the ERROR level.
646         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Ditto.
647         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit): Ditto.
648         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Ditto.
649         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Ditto.
650         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Ditto.
651         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file): Ditto.
652         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit): Ditto.
653
654 2018-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
655
656         Add a JSCOnly MIPS buildbot
657         https://bugs.webkit.org/show_bug.cgi?id=181487
658
659         Reviewed by Michael Catanzaro.
660
661         Add the new bot configs definitions for the master and update the unit tests.
662
663         * BuildSlaveSupport/build.webkit.org-config/config.json:
664         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
665
666 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
667
668         REGRESSION (r226715): don't re-check number of simulators in child processes
669         https://bugs.webkit.org/show_bug.cgi?id=181484
670         <rdar://problem/36407151>
671
672         Reviewed by Aakash Jain.
673
674         * Scripts/webkitpy/port/ios_simulator.py:
675         (IOSSimulatorPort.__init__): Skip the number of simulators check if simulators
676         are already initialized.
677
678 2018-01-10  Commit Queue  <commit-queue@webkit.org>
679
680         Unreviewed, rolling out r226667 and r226673.
681         https://bugs.webkit.org/show_bug.cgi?id=181488
682
683         This caused a flaky crash. (Requested by mlewis13 on #webkit).
684
685         Reverted changesets:
686
687         "CodeBlocks should be in IsoSubspaces"
688         https://bugs.webkit.org/show_bug.cgi?id=180884
689         https://trac.webkit.org/changeset/226667
690
691         "REGRESSION (r226667): CodeBlocks should be in IsoSubspaces"
692         https://bugs.webkit.org/show_bug.cgi?id=180884
693         https://trac.webkit.org/changeset/226673
694
695 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
696
697         Follow-up fix to r226715
698         https://bugs.webkit.org/show_bug.cgi?id=180555
699         <rdar://problem/36131381>
700
701         Unreviewed infrastructure fix.
702
703         * Scripts/webkitpy/xcode/new_simulated_device.py:
704         (SimulatedDeviceManager._create_or_find_device_for_request): Use _delete instead
705         of delete.
706
707 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
708
709         webkitpy: Refactor simulator code (Part 2)
710         https://bugs.webkit.org/show_bug.cgi?id=180555
711         <rdar://problem/36131381>
712
713         Reviewed by Aakash Jain.
714
715         The patch leverages the SimulatedDeviceManager when running layout tests.
716         This patch is primarily code removal, since much of the IOSSimulatorPort
717         was dedicated to managing simulators. The removed code is either now owned by the
718         SimulatedDeviceManager (and committed in Part 1) or supported a technique to
719         boot multiple simulators which was made obsolete in Xcode 9.
720
721         * Scripts/webkitpy/layout_tests/controllers/manager.py:
722         (Manager._custom_device_for_test.in): Device names now have spaces in them,
723         strip those spaces.
724         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
725         (parse_args): Remove '--runtime' flag, this is achieved with the --version flag.
726         * Scripts/webkitpy/port/ios.py:
727         (IOSPort.__init__): The _current_device idiom is no longer required since the
728         SimulatedDeviceManager keeps track of any previously booted devices.
729         (IOSPort.target_host): Even when only a single device is used, it will be accessed
730         through the array of managed devices.
731         (IOSPort.using_multiple_devices): Deleted.
732         * Scripts/webkitpy/port/ios_device.py:
733         (IOSDevicePort.using_multiple_devices): Deleted.
734         * Scripts/webkitpy/port/ios_simulator.py:
735         (IOSSimulatorPort): Remove constants required to manage simulators, change device
736         class strings so they can be parsed by the DeviceType class.
737         (IOSSimulatorPort.__init__): Determine the number of processes to use by checking
738         the number of simulators currently booted, the number of child processes specified
739         and the maximum number of simulators supported by this system.
740         (IOSSimulatorPort._device_for_worker_number_map):Return the array of initialized
741         devices owned by the SimulatedDeviceManager.
742         (IOSSimulatorPort.ios_version): Remove support for the --runtime option.
743         (IOSSimulatorPort.default_child_processes): Use the SimulatedDeviceManager to check
744         the maximum number of supported simulators on this system.
745         (IOSSimulatorPort._create_devices): Construct a list of device requests with a
746         request for each child process and send this list to the SimulatedDeviceManager to
747         initialize the devices.
748         (IOSSimulatorPort.clean_up_test_run):
749         (IOSSimulatorPort.check_sys_deps): Check that there are simulators running the
750         specified version of iOS.
751         (IOSSimulatorPort.reset_preferences):
752         (IOSSimulatorPort.simulator_runtime): Deleted.
753         (IOSSimulatorPort.simulator_device_type): Deleted.
754         (IOSSimulatorPort._teardown_managed_simulators): Deleted.
755         (IOSSimulatorPort.use_multiple_simulator_apps): Deleted.
756         (IOSSimulatorPort._create_simulators): Deleted.
757         (IOSSimulatorPort._quit_ios_simulator): Deleted.
758         (IOSSimulatorPort._using_dedicated_simulators): Deleted.
759         (IOSSimulatorPort.using_multiple_devices): Deleted.
760         (IOSSimulatorPort._create_device): Deleted.
761         (IOSSimulatorPort.get_simulator_path): Deleted.
762         (IOSSimulatorPort._createSimulatorApps): Deleted.
763         (IOSSimulatorPort._createSimulatorApp): Deleted.
764         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
765         (TestRebaseline.test_rebaseline): Filter out commands run when determining the
766         maximum number of simulators run on this system.
767         (TestRebaselineExpectations.test_rebaseline_expectations): Ditto.
768         * Scripts/webkitpy/xcode/new_simulated_device.py:
769         (SimulatedDeviceManager._does_fulfill_request): Fixed log statement.
770
771 2018-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
772
773         WebDriver: run-webdriver-tests doesn't handle test names with a '/' correctly
774         https://bugs.webkit.org/show_bug.cgi?id=181474
775
776         Reviewed by Carlos Alberto Lopez Perez.
777
778         We use os.path.basename() to get the subtest name. If the test name contains a slash we get part of the subtest
779         name as the name.
780
781         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
782         (WebDriverTestRunnerW3C._subtest_name): Helper function to get the subtest name.
783         (WebDriverTestRunnerW3C.run): Use _subtest_name() instead of os.path.basename().
784
785 2018-01-09  Andy Estes  <aestes@apple.com>
786
787         [Xcode] Use the Apple Internal SDK if available when building ImageDiff
788         https://bugs.webkit.org/show_bug.cgi?id=181459
789
790         Reviewed by Dan Bernstein.
791
792         * ImageDiff/cg/Configurations/Base.xcconfig:
793
794 2018-01-09  Myles C. Maxfield  <mmaxfield@apple.com>
795
796         font-display:fallback can cause a visual flash (which is supposed to be impossible)
797         https://bugs.webkit.org/show_bug.cgi?id=181374
798
799         Reviewed by Simon Fraser.
800
801         The test requires Palatino.
802
803         * DumpRenderTree/mac/DumpRenderTree.mm:
804         (allowedFontFamilySet):
805         * WebKitTestRunner/mac/TestControllerMac.mm:
806         (WTR::allowedFontFamilySet):
807
808 2018-01-09  Saam Barati  <sbarati@apple.com>
809
810         Give some slack in display-profiler-outputs computation of the terminal window's number of columns
811         https://bugs.webkit.org/show_bug.cgi?id=181449
812
813         Reviewed by JF Bastien.
814
815         This allows me to Cmd+f in my terminal to search for things without
816         having the results become misaligned.
817
818         * Scripts/display-profiler-output:
819
820 2018-01-09  Basuke Suzuki  <Basuke.Suzuki@sony.com>
821
822         [webkitpy] PlatformInfo should have default argument for casual use
823         https://bugs.webkit.org/show_bug.cgi?id=180827
824
825         Reviewed by David Kilzer.
826
827         PlatformInfo should be the only way to check platform specific thing instead
828         of sys.platform or other various checks. If there is something you want to check,
829         it should be placed in PlatformInfo.
830
831         Currently to instantiate PlatformInfo, it requires arguments, which is usually
832         sys, platform and Executive(). They are straight forward and should be handled
833         by default arguments. Then we can instantiate PlatformInfo more casual.
834
835         * Scripts/webkitpy/common/system/platforminfo.py:
836         (PlatformInfo): Use relative module path import
837         (PlatformInfo.__init__):
838         (PlatformInfo.executive): Lazy instantiation of Executive()
839         (PlatformInfo.total_bytes_memory): Accessing via above property
840         (PlatformInfo.xcode_sdk_version): Ditto
841         (PlatformInfo.xcode_simctl_list): Ditto
842         (PlatformInfo.xcode_version): Ditto
843         (PlatformInfo._win_version_str): Ditto
844         * Scripts/webkitpy/common/system/systemhost.py:
845         (SystemHost.__init__):
846         * Scripts/webkitpy/common/system/user.py:
847         (User.__init__):
848
849 2018-01-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
850
851         [Win] Remove workaround for Bug 176442 after stopping MSVC 2015 support
852         https://bugs.webkit.org/show_bug.cgi?id=176443
853
854         Reviewed by Darin Adler.
855
856         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
857         (TEST):
858
859 2018-01-09  Frederic Wang  <fwang@igalia.com.fr>
860
861         check-webkit-style: Verify syntax for WK_API_AVAILABLE
862         https://bugs.webkit.org/show_bug.cgi?id=181394
863
864         Reviewed by Darin Adler.
865
866         A common syntax error for WK_API_AVAILABLE is to write ios(WK_MAC_TBA)
867         as the second parameter instead of ios(WK_IOS_TBA). This generally
868         builds for iOS on EWS but not when using the public SDK. See r224057,
869         r223207 and r226211 for example. This patch adds a basic style check
870         for that macro to prevent this kind of mistake.
871
872         * Scripts/webkitpy/style/checkers/cpp.py:
873         (check_min_versions_of_wk_api_available): New function to verify the parameters of WX_API_AVAILABLE.
874         (check_style): Run new style check.
875         (CppChecker): Add build type for the new style check.
876         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
877         (WebKitStyleTest.test_min_versions_of_wk_api_available): Add tests for the new style check.
878
879 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
880
881         [Attachment Support] Expose HTMLAttachmentElement.uniqueIdentifier to bindings
882         https://bugs.webkit.org/show_bug.cgi?id=181420
883         <rdar://problem/36365827>
884
885         Reviewed by Alex Christensen.
886
887         Adjusts some existing API tests to verify that attachment elements' uniqueIdentifiers match the uniqueIdentifier
888         of corresponding _WKAttachments.
889
890         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
891         (TestWebKitAPI::TEST):
892
893 2018-01-08  Alex Christensen  <achristensen@webkit.org>
894
895         Add WKNavigationDelegate SPI exposing WebProcess crash reason
896         https://bugs.webkit.org/show_bug.cgi?id=181410
897         <rdar://problem/36167199>
898
899         Reviewed by Wenson Hsieh.
900
901         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
902         (-[CrashReasonDelegate _webView:webContentProcessDidTerminateWithReason:]):
903         (TEST):
904
905 2018-01-08  Alex Christensen  <achristensen@webkit.org>
906
907         Add SPI for WKOpenPanelParameters._acceptedMIMETypes and _acceptedFileExtensions
908         https://bugs.webkit.org/show_bug.cgi?id=181408
909         <rdar://problem/35884960>
910
911         Reviewed by Tim Horton.
912
913         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
914         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
915
916 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
917
918         [Attachment Support] Expose file name and content type of WKAttachment
919         https://bugs.webkit.org/show_bug.cgi?id=181390
920         <rdar://problem/36336837>
921
922         Reviewed by Tim Horton.
923
924         Adjusts some existing tests in WKAttachmentTests to exercise -requestInfo:.
925
926         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
927         (-[_WKAttachment synchronouslyRequestInfo:]):
928         (-[_WKAttachment synchronouslyRequestData:]):
929
930         Reimplement this in terms of -synchronouslyRequestInfo:.
931
932         (-[_WKAttachment expectRequestedDataToBe:]):
933         (TestWebKitAPI::TEST):
934
935 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
936
937         Copying, pasting, and then deleting an attachment element breaks attachment data requests
938         https://bugs.webkit.org/show_bug.cgi?id=181365
939         <rdar://problem/36340647>
940
941         Reviewed by Tim Horton.
942
943         Adds two new attachment API tests to verify that copying and pasting an existing attachment inserts an
944         attachment element that may be edited independently of the original attachment. See WebCore/ChangeLog for more
945         detail.
946
947         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
948         (TestWebKitAPI::TEST):
949
950 2018-01-08  Youenn Fablet  <youenn@apple.com>
951
952         navigator.onLine does not work inside service workers
953         https://bugs.webkit.org/show_bug.cgi?id=181079
954         <rdar://problem/36178606>
955
956         Reviewed by Darin Adler.
957
958         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
959         (WTR::InjectedBundle::initialize): Setting service worker creation callback to inject ServiceWorkerInternals object.
960
961 2018-01-07  Saam Barati  <sbarati@apple.com>
962
963         Add total exits and total compilations sorting mode to the "full" command in display-profiler-output
964         https://bugs.webkit.org/show_bug.cgi?id=181372
965
966         Reviewed by Filip Pizlo.
967
968         Adding these sorting modes makes it easier to analyze functions
969         that recompile a lot and exit a lot.
970
971         * Scripts/display-profiler-output:
972
973 2018-01-06  Julien Brianceau  <julien.brianceau@gmail.com>
974
975         Unreviewed, remove my Cisco email from contributors.json
976
977         * Scripts/webkitpy/common/config/contributors.json:
978
979 2018-01-05  JF Bastien  <jfbastien@apple.com>
980
981         WebAssembly: poison JS object's secrets
982         https://bugs.webkit.org/show_bug.cgi?id=181339
983         <rdar://problem/36325001>
984
985         Reviewed by Mark Lam.
986
987         Update tests for swap(Poisoned<k, T>, T*)
988
989         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp:
990         (TestWebKitAPI::TEST):
991         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
992         (TestWebKitAPI::TEST):
993         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
994         (TestWebKitAPI::TEST):
995
996 2018-01-05  Wenson Hsieh  <wenson_hsieh@apple.com>
997
998         REGRESSION(r226396) DataInteractionTests: ContentEditableToContentEditable and ContentEditableToTextarea are failing
999         https://bugs.webkit.org/show_bug.cgi?id=181359
1000
1001         Reviewed by Tim Horton.
1002
1003         Ensure that these tests still pass using older SDKs.
1004
1005         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1006         (TestWebKitAPI::TEST):
1007
1008 2018-01-05  Alex Christensen  <achristensen@webkit.org>
1009
1010         Rebase API test after r226469
1011         https://bugs.webkit.org/show_bug.cgi?id=181308
1012
1013         * TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
1014         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
1015         A URL with < or > in it is now recognized as invalid by WebKit.  This is intentional, and matches our behavior before enabling the new URLParser.
1016
1017 2018-01-05  Alex Christensen  <achristensen@webkit.org>
1018
1019         Restrict navigation-time WKWebsiteDataStore swapping to main frame navigations
1020         https://bugs.webkit.org/show_bug.cgi?id=181217
1021
1022         Reviewed by Tim Horton.
1023
1024         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1025         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1026         (TEST):
1027
1028 2018-01-05  Alex Christensen  <achristensen@webkit.org>
1029
1030         Add WKBundleFrameCreateFrameHandle
1031         https://bugs.webkit.org/show_bug.cgi?id=181232
1032         <rdar://problem/35926696>
1033
1034         Reviewed by Tim Horton.
1035
1036         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1037         * TestWebKitAPI/Tests/WebKitCocoa/FrameHandleSerialization.mm: Added.
1038         (mouseDidMoveOverElement):
1039         (-[FrameHandleSerialization webProcessPlugIn:didCreateBrowserContextController:]):
1040         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1041         (-[MouseMoveOverElementDelegate _webView:mouseDidMoveOverElement:withFlags:userInfo:]):
1042         (TEST):
1043
1044 2018-01-05  Chris Fleizach  <cfleizach@apple.com>
1045
1046         iOS: Build fix after r226432.
1047         
1048         Unreviewed. Stop duplicating speakAs symbols for iOS.
1049
1050         * DumpRenderTree/AccessibilityUIElement.cpp:
1051         (AccessibilityUIElement::speakAs):
1052
1053 2018-01-05  Javier Fernandez  <jfernandez@igalia.com>
1054
1055         Unreviewed, added myself as WebKit reviewer
1056
1057         * Scripts/webkitpy/common/config/contributors.json:
1058
1059 2018-01-05  Claudio Saavedra  <csaavedra@igalia.com>
1060
1061         WPE: Build fix after r226432.
1062
1063         Unreviewed. Rename ::speak() to ::speakAs().
1064         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
1065         (WTR::AccessibilityUIElement::speakAs):
1066         (WTR::AccessibilityUIElement::speak): Deleted.
1067
1068 2018-01-04  Chris Fleizach  <cfleizach@apple.com>
1069
1070         AX: Implement updated CSS3 Speech for 'speak' and 'speak-as' properties
1071         https://bugs.webkit.org/show_bug.cgi?id=180361
1072
1073         Reviewed by Zalan Bujtas.
1074
1075         * DumpRenderTree/AccessibilityUIElement.cpp:
1076         (speakAsCallback):
1077         (AccessibilityUIElement::speakAs):
1078         (AccessibilityUIElement::getJSClass):
1079         (speakCallback): Deleted.
1080         (AccessibilityUIElement::speak): Deleted.
1081         * DumpRenderTree/AccessibilityUIElement.h:
1082         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1083         (AccessibilityUIElement::speakAs):
1084         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1085         (AccessibilityUIElement::speakAs):
1086         (AccessibilityUIElement::speak): Deleted.
1087         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1088         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1089         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1090         (WTR::AccessibilityUIElement::speakAs):
1091         (WTR::AccessibilityUIElement::speak): Deleted.
1092         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1093         (WTR::AccessibilityUIElement::speakAs):
1094         (WTR::AccessibilityUIElement::speak): Deleted.
1095
1096 2018-01-04  Jonathan Bedard  <jbedard@apple.com>
1097
1098         REGRESSION (r226395): test-webkitperl test expectations incorrect
1099         https://bugs.webkit.org/show_bug.cgi?id=181307
1100         <rdar://problem/36306558>
1101
1102         Rubber-stamped by Aakash Jain.
1103
1104         r226395 added two lines towards the beginning of
1105         Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl, the line
1106         numbers in the test expectations need to update.
1107
1108         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
1109
1110 2018-01-04  Tim Horton  <timothy_horton@apple.com>
1111
1112         WKWebView loses minimum layout size overrides that happen while the process is terminated
1113         https://bugs.webkit.org/show_bug.cgi?id=181306
1114         <rdar://problem/34398288>
1115
1116         Reviewed by Dan Bernstein.
1117
1118         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
1119         (TEST):
1120         Add a test that calling _overrideLayoutParametersWithMinimumLayoutSize
1121         while the process is terminated results in the page getting the correct
1122         minimum layout size.
1123
1124 2018-01-04  Eric Carlson  <eric.carlson@apple.com>
1125
1126         [MediaStream] Add Mock screen capture source
1127         https://bugs.webkit.org/show_bug.cgi?id=181291
1128         <rdar://problem/36298164>
1129
1130         Reviewed by Dean Jackson.
1131
1132         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test.
1133         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
1134         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
1135
1136 2018-01-04  Lucas Forschler  <lforschler@apple.com>
1137
1138         <rdar://problem/36300930> Change proxy server setting on master config to reach s3 servers
1139
1140         Reviewed by Ling Ho.
1141
1142         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1143
1144 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1145
1146         [Attachment Support] Create attachment elements when dropping files on iOS
1147         https://bugs.webkit.org/show_bug.cgi?id=181192
1148         <rdar://problem/36280945>
1149
1150         Reviewed by Tim Horton.
1151
1152         Adds 3 new API tests to exercise different use cases of dropping content as attachment elements when the runtime
1153         switch is enabled. See below for more details.
1154
1155         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1156         (-[NSItemProvider registerData:type:]):
1157         (platformCopyPNG):
1158         (TestWebKitAPI::TEST):
1159         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1160
1161         Fix some currently failing iOS drag and drop tests. In this case, there's no reason RTFD should appear in the
1162         source item provider when dragging rich text *without* attachments, so this should have been a check for just
1163         kUTTypeRTF instead.
1164
1165         (TestWebKitAPI::TEST):
1166
1167         Tests a few cases of inserting attachment elements via drop:
1168         1.  We should distinguish between drops containing rich/plain text files from just dropping rich/plain text.
1169             Instead of inserting the contents as inline web content, this should generate attachment elements.
1170         2.  Test the fallback mechanism for inserting attachment elements. If the preferred presentation style is not
1171             explicitly set, but there's nothing WebKit would otherwise do with the dropped content, then we should fall
1172             back to inserting the content as an attachment.
1173         3.  Test that if multiple attachments and inline item providers are present, WebKit will respect the order in
1174             which they were inserted by the source (as opposed to, for instance, putting all of the attachments in front
1175             or at the end).
1176
1177         * TestWebKitAPI/cocoa/TestWKWebView.h:
1178         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1179         (-[TestWKWebView objectByEvaluatingJavaScript:]):
1180
1181         Add a helper method to return an object that represents the result of evaluating some given script, and rewrite
1182         -stringByEvaluatingJavaScript to just turn around and call this.
1183
1184         (-[TestWKWebView stringByEvaluatingJavaScript:]):
1185
1186 2018-01-03  Ting-Wei Lan  <lantw44@gmail.com>
1187
1188         Replace hard-coded paths in shebangs with #!/usr/bin/env
1189         https://bugs.webkit.org/show_bug.cgi?id=181040
1190
1191         Reviewed by Alex Christensen.
1192
1193         * BuildSlaveSupport/build-launcher-app:
1194         * BuildSlaveSupport/build-launcher-dmg:
1195         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1196         * BuildSlaveSupport/built-product-archive:
1197         * BuildSlaveSupport/clean-build:
1198         * BuildSlaveSupport/delete-stale-build-files:
1199         * BuildSlaveSupport/download-built-product:
1200         * BuildSlaveSupport/gtk/buildbot/log/run:
1201         * BuildSlaveSupport/gtk/buildbot/run:
1202         * BuildSlaveSupport/gtk/pulseaudio/run:
1203         * BuildSlaveSupport/kill-old-processes:
1204         * BuildSlaveSupport/test-result-archive:
1205         * BuildSlaveSupport/win/kill-old-processes:
1206         * Scripts/SpacingHeuristics.pm:
1207         * Scripts/add-include:
1208         * Scripts/build-api-tests:
1209         * Scripts/build-dumprendertree:
1210         * Scripts/build-imagediff:
1211         * Scripts/build-jsc:
1212         * Scripts/build-webkit:
1213         * Scripts/build-webkittestrunner:
1214         * Scripts/check-Xcode-source-file-types:
1215         * Scripts/check-dom-results:
1216         * Scripts/check-for-exit-time-destructors:
1217         * Scripts/check-for-global-initializers:
1218         * Scripts/check-for-inappropriate-objc-class-names:
1219         * Scripts/check-for-weak-vtables-and-externals:
1220         * Scripts/clean-header-guards:
1221         * Scripts/compare-timing-files:
1222         * Scripts/configure-xcode-for-ios-development:
1223         * Scripts/copy-webkitlibraries-to-product-directory:
1224         * Scripts/create-exports:
1225         * Scripts/debug-minibrowser:
1226         * Scripts/debug-safari:
1227         * Scripts/debug-test-runner:
1228         * Scripts/do-file-rename:
1229         * Scripts/do-webcore-rename:
1230         * Scripts/dump-webkit-tests-run:
1231         * Scripts/ensure-valid-python:
1232         * Scripts/execAppWithEnv:
1233         * Scripts/extract-localizable-js-strings:
1234         * Scripts/filter-build-webkit:
1235         * Scripts/find-extra-includes:
1236         * Scripts/fix-blink-patch:
1237         * Scripts/generate-coverage-data:
1238         * Scripts/git-add-reviewer:
1239         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
1240         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
1241         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz:
1242         * Scripts/make-new-script-test:
1243         * Scripts/make-script-test-wrappers:
1244         * Scripts/package-root:
1245         * Scripts/parse-malloc-history:
1246         * Scripts/report-include-statistics:
1247         * Scripts/resolve-ChangeLogs:
1248         * Scripts/run-api-tests:
1249         * Scripts/run-bindings-tests:
1250         * Scripts/run-content-extension-tester:
1251         * Scripts/run-iexploder-tests:
1252         * Scripts/run-javascriptcore-tests:
1253         * Scripts/run-jsc:
1254         * Scripts/run-leaks:
1255         * Scripts/run-mangleme-tests:
1256         * Scripts/run-minibrowser:
1257         * Scripts/run-pageloadtest:
1258         * Scripts/run-regexp-tests:
1259         * Scripts/run-safari:
1260         * Scripts/run-sunspider:
1261         * Scripts/run-test-runner:
1262         * Scripts/run-webkit-app:
1263         * Scripts/run-webkit-httpd:
1264         * Scripts/run-webkit-websocketserver:
1265         * Scripts/set-webkit-configuration:
1266         * Scripts/show-pretty-diff:
1267         * Scripts/sort-Xcode-project-file:
1268         * Scripts/split-file-by-class:
1269         * Scripts/sunspider-compare-results:
1270         * Scripts/svn-apply:
1271         * Scripts/svn-unapply:
1272         * Scripts/test-webkit-scripts:
1273         * Scripts/test-webkitperl:
1274         * Scripts/update-iexploder-cssproperties:
1275         * Scripts/update-javascriptcore-test-results:
1276         * Scripts/update-webkit:
1277         * Scripts/update-webkit-auxiliary-libs:
1278         * Scripts/update-webkit-dependency:
1279         * Scripts/update-webkit-libs-jhbuild:
1280         * Scripts/update-webkit-localizable-strings:
1281         * Scripts/update-webkit-support-libs:
1282         * Scripts/update-webkitgtk-libs:
1283         * Scripts/update-webkitwpe-libs:
1284         * Scripts/webkit-build-directory:
1285         * Scripts/webkitperl/LoadAsModule.pm:
1286         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
1287         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
1288         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl:
1289         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl:
1290         * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl:
1291         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
1292         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
1293         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
1294         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
1295         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
1296         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl:
1297         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
1298         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl:
1299         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
1300         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
1301         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
1302         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
1303         * Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl:
1304         * Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl:
1305         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl:
1306         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl:
1307         * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl:
1308         * Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl:
1309         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl:
1310         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
1311         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
1312         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl:
1313         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl:
1314         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
1315         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
1316         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
1317         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
1318         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl:
1319         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl:
1320         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl:
1321         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
1322         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
1323         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
1324         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl:
1325         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
1326         * ccache/ccache-clang:
1327         * ccache/ccache-clang++:
1328         * ccache/ccache-wrapper:
1329         * gtk/install-dependencies:
1330         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi:
1331         * iExploder/iexploder-1.3.2/htdocs/webserver.rb:
1332         * iExploder/iexploder-1.3.2/tools/lasthit.rb:
1333         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb:
1334         * iExploder/iexploder-1.3.2/tools/showtest.rb:
1335         * iExploder/iexploder-1.7.2/src/browser_harness.rb:
1336         * iExploder/iexploder-1.7.2/src/iexploder.cgi:
1337         * iExploder/iexploder-1.7.2/src/webserver.rb:
1338         * iExploder/iexploder-1.7.2/tools/lasthit.rb:
1339         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb:
1340         * wpe/install-dependencies:
1341
1342 2018-01-03  Simon Fraser  <simon.fraser@apple.com>
1343
1344         filter-build-webkit filters out useful compiler error lines
1345         https://bugs.webkit.org/show_bug.cgi?id=179864
1346
1347         Reviewed by Tim Horton.
1348
1349         Don't filter out lines that contain information about build errors by always showing lines
1350         after a line that contains "note:" or "error:".
1351
1352         * Scripts/filter-build-webkit:
1353         (shouldShowSubsequentLine):
1354         (shouldIgnoreLine):
1355
1356 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1357
1358         REGRESSION(r226366): [GTK] Broke TestBackForwardList and TestWebKitWebView
1359         https://bugs.webkit.org/show_bug.cgi?id=173915
1360
1361         Unreviewed follow-up. Fix /webkit2/WebKitWebView/session-state-with-form-data and
1362         /webkit2/WebKitWebView/submit-form. The form ID may be NULL, but we can't put NULL into a
1363         GVariant unless we use maybe types, and maybe types are incompatible with D-Bus. So use an
1364         empty string in this case.
1365
1366         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1367         (emitFormSubmissionEvent):
1368
1369 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1370
1371         [GTK] Add web process API to detect when form is submitted via JavaScript
1372         https://bugs.webkit.org/show_bug.cgi?id=173915
1373
1374         Reviewed by Carlos Garcia Campos.
1375
1376         Test it.
1377
1378         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1379         (FormSubmissionTest::FormSubmissionTest):
1380         (FormSubmissionTest::~FormSubmissionTest):
1381         (FormSubmissionTest::testFormSubmissionResult):
1382         (FormSubmissionTest::willSendDOMEventCallback):
1383         (FormSubmissionTest::willCompleteCallback):
1384         (FormSubmissionTest::runJavaScriptAndWaitUntilFormSubmitted):
1385         (testWebExtensionFormSubmissionSteps):
1386         (beforeAll):
1387         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1388         (DelayedSignal::DelayedSignal):
1389         (emitFormSubmissionEvent):
1390         (handleFormSubmissionCallback):
1391         (willSubmitFormCallback):
1392         (pageCreatedCallback):
1393
1394 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1395
1396         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/databases
1397         https://bugs.webkit.org/show_bug.cgi?id=181251
1398
1399         * Scripts/run-gtk-tests:
1400         (GtkTestRunner):
1401
1402 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1403
1404         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/ephemeral
1405         https://bugs.webkit.org/show_bug.cgi?id=181136
1406
1407         * Scripts/run-gtk-tests:
1408         (GtkTestRunner):
1409
1410 2018-01-02  Brent Fulgham  <bfulgham@apple.com>
1411
1412         [macOS, iOS] Adopt new secure coding APIs in WebKit
1413         https://bugs.webkit.org/show_bug.cgi?id=181085
1414         <rdar://problem/34837397>
1415
1416         Reviewed by Tim Horton.
1417
1418         Update API tests to use secure coding wherever possible. Currently, NSView/UIView-based classes are not
1419         capable of supporting NSSecureCoding, so pass through the current coding routines.
1420
1421         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Updated for NSSecureCoding.
1422         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
1423         (encodeAndDecode): Check if class supports the NSSecureCoding protocol and use non-secure coding
1424         routines if necessary.
1425         (TEST): Updated for NSSecureCoding.
1426         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm:
1427         (TestWebKitAPI::TEST): Updated for NSSecureCoding.
1428
1429 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
1430
1431         Remove std::chrono completely
1432         https://bugs.webkit.org/show_bug.cgi?id=181186
1433
1434         Reviewed by Alex Christensen.
1435
1436         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1437         (WTR::TestController::platformRunUntil):
1438
1439 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1440
1441         REGRESSION(r223253): Broke ResourceLoadStatistics layout tests for non-Cocoa ports
1442         https://bugs.webkit.org/show_bug.cgi?id=181231
1443
1444         Reviewed by Alex Christensen.
1445
1446         Implement TestController APIs needed by ResourceLoadStatistics tests.
1447
1448         * WebKitTestRunner/TestController.cpp:
1449         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
1450         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
1451
1452 2018-01-02  Tim Horton  <timothy_horton@apple.com>
1453
1454         Disable WKAttachmentTests if UIPasteboard.itemProviders is not available
1455         https://bugs.webkit.org/show_bug.cgi?id=181219
1456
1457         Reviewed by Wenson Hsieh.
1458
1459         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1460
1461 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1462
1463         Add a WebAuthentication runtime feature flag
1464         https://bugs.webkit.org/show_bug.cgi?id=181220
1465         <rdar://problem/36055305>
1466
1467         Reviewed by Brent Fulgham.
1468
1469         Renames the CredentialManagement runtime feature flag into WebAuthentication.
1470
1471         * DumpRenderTree/TestOptions.h:
1472         * DumpRenderTree/TestOptions.mm:
1473         (TestOptions::TestOptions):
1474         * DumpRenderTree/mac/DumpRenderTree.mm:
1475         (enableExperimentalFeatures):
1476         (setWebPreferencesForTestOptions):
1477         * WebKitTestRunner/TestController.cpp:
1478         (WTR::TestController::resetPreferencesToConsistentValues):
1479         (WTR::updateTestOptionsFromTestHeader):
1480         * WebKitTestRunner/TestOptions.h:
1481         (WTR::TestOptions::hasSameInitializationOptions const):
1482
1483 2018-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1484
1485         [Attachment Support] Don't Blob-convert images and attachments with https:, http: or data: urls
1486         https://bugs.webkit.org/show_bug.cgi?id=181143
1487         <rdar://problem/36200381>
1488
1489         Reviewed by Tim Horton.
1490
1491         Add a new API test to ensure that a copied image with a data URL does not get pasted as an attachment when
1492         attachment elements are enabled.
1493
1494         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1495         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1496         (TestWebKitAPI::TEST):
1497
1498 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1499
1500         Update Credential Management API for WebAuthentication
1501         https://bugs.webkit.org/show_bug.cgi?id=181082
1502         <rdar://problem/36055239>
1503
1504         Reviewed by Brent Fulgham.
1505
1506         Enable Credential Management API for testing.
1507
1508         * DumpRenderTree/TestOptions.h:
1509         * WebKitTestRunner/TestOptions.h:
1510
1511 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1512
1513         [GTK] Test /webkit2/WebKitWebExtension/form-controls-associated-signal is flaky
1514         https://bugs.webkit.org/show_bug.cgi?id=168194
1515
1516         Reviewed by Carlos Garcia Campos.
1517
1518         Fix an assertion and unskip the test. The order that form controls are associated is not
1519         guaranteed.
1520
1521         * Scripts/run-gtk-tests:
1522         (GtkTestRunner):
1523         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1524         (didAssociateFormControlsCallback):
1525
1526 2018-01-02  Alex Christensen  <achristensen@webkit.org>
1527
1528         Use new WebsiteDataStore passed in through decidePolicyForNavigation SPI
1529         https://bugs.webkit.org/show_bug.cgi?id=180897
1530         <rdar://problem/35535328>
1531
1532         Reviewed by Brent Fulgham.
1533
1534         Test two forms of storage to be sure we are using a different WebsiteDataStore: cookies and sessionStorage.
1535
1536         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1537         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1538         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:]):
1539         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1540         (websiteDataStoreTestWebView):
1541         (TEST):
1542
1543 == Rolled over to ChangeLog-2018-01-01 ==