Teach buildbot how to compile 32-bit on Mac.
[WebKit-https.git] / Tools / ChangeLog
1 2013-05-08  Lucas Forschler  <lforschler@apple.com>
2
3         Teach buildbot how to compile 32-bit on Mac.
4
5         Reviewed by Ryosuke Niwa.
6
7         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
8         (CompileWebKit.start):
9         (ExtractTestResultsAndLeaks):
10
11 2013-05-08  Eli Fidler  <efidler@blackberry.com>
12
13         [BlackBerry] Fix usage of BlackBerry::Platform::String
14         https://bugs.webkit.org/show_bug.cgi?id=115781
15
16         Reviewed by Rob Buis.
17
18         BlackBerry PRs 304193 and 327181
19         Internally Reviewed by Mike Lattanzio, Arvid Nilsson, Joe Mason, Jeff Rogers, and George Staikos
20
21         We currently have a problem where we're passing UTF-8 encoded data into
22         the char* constructors of BlackBerry::Platform::String. This means the string
23         thinks its data is not UTF-8.
24
25         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
26         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
27         (BlackBerry::WebKit::dumpHistoryItem):
28         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
29         (TestRunner::setUserStyleSheetLocation):
30         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
31         (LoadHTMLStringItem::invoke):
32
33 2013-05-08  Alberto Garcia  <agarcia@igalia.com>
34
35         Tools: add new BlackBerry include dirs.
36         https://bugs.webkit.org/show_bug.cgi?id=115514
37
38         Reviewed by Rob Buis.
39
40         iType include dirs are missing, and HarfBuzz needs to be fixed.
41
42         * Scripts/webkitdirs.pm:
43         (blackberryCMakeArguments):
44
45 2013-05-08  José Dapena Paz  <jdapena@igalia.com> and Zan Dobersek  <zdobersek@igalia.com>
46
47         [GTK] Plumb the Automake build system for the Battery Status API feature
48         https://bugs.webkit.org/show_bug.cgi?id=115718
49
50         Reviewed by Martin Robinson.
51
52         * Scripts/webkitdirs.pm:
53         (buildAutotoolsProject): List battery-status as a configurable feature, meaning its value will be adjusted
54         through the --(enable|disable)-battery-status flag passed to configure.
55
56 2013-05-08  Ryosuke Niwa  <rniwa@webkit.org>
57
58         new-run-webkit-websocketserver doesn't work after Chromium removal
59         https://bugs.webkit.org/show_bug.cgi?id=115816
60
61         Reviewed by Joseph Pecoraro.
62
63         Fix the bug by instantiating the correct port object.
64
65         * Scripts/new-run-webkit-websocketserver:
66         (main):
67
68 2013-05-07  Lucas Forschler  <lforschler@apple.com>
69
70         Configure buildbot for 32bit builder.
71         https://bugs.webkit.org/show_bug.cgi?id=115769
72         
73         Reviewed by Ryosuke Niwa.
74
75         * BuildSlaveSupport/build.webkit.org-config/config.json:
76
77 2013-05-08  Brent Fulgham  <bfulgham@webkit.org>
78
79         Unreviewed. Update to show my apple.com address.
80
81         * Scripts/webkitpy/common/config/contributors.json: Added
82         my apple.com e-mail address.
83
84 2013-05-08  David Kilzer  <ddkilzer@apple.com>
85
86         BUILD FIX (r149579): Use Vector::appendVector() instead of Vector::append()
87
88         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
89         (concatenateAttributeAndValue): Switch to appendVector().
90
91 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
92
93         [Qt][WTR] Fix the build on Mac after r149692
94
95         Unreviewed build fix.
96
97         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
98         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
99
100 2013-05-08  Mario Sanchez Prada  <mario.prada@samsung.com>
101
102         Unreviewed. Added Anton Obzhirov to the list of contributors and myself
103         to the watchlist for Accessibility.
104
105         * Scripts/webkitpy/common/config/contributors.json: Added Anton Obzhirov.
106         * Scripts/webkitpy/common/config/watchlist: Added myself.
107
108 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
109
110         [Qt] Build fails with clang
111         https://bugs.webkit.org/show_bug.cgi?id=115741
112
113         Reviewed by Benjamin Poulain.
114
115         Since r149112 std::move is used in AtomicString for compilers that
116         support rvalue references and this requires a standard library
117         implementing c++11 move semantics.
118         We only explicitely require c++11 for WebKit2, but since clang supports
119         rvalue references the build of subtargets using AtomicString fails because
120         of missing std::move.
121         It is safe to add CONFIG += c++11 for the whole project when using clang
122         since we explicitely disable c++11 for ANGLE that had probems with libc++.
123
124         * qmake/mkspecs/features/unix/default_pre.prf:
125
126 2013-05-08  Darin Adler  <darin@apple.com>
127
128         Fix one more place that needed to use adoptCF/NS
129         https://bugs.webkit.org/show_bug.cgi?id=115778
130
131         Reviewed by Benjamin Poulain.
132
133         Not sure why I missed this code last time, but found a bit more code that needs
134         to switch to the newer style adoptCF/NS.
135
136         * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
137         (convertWebResourceDataToString): Use adoptCF.
138         (convertWebResourceResponseToDictionary): Ditto.
139         (createXMLStringFromWebArchiveData): Ditto.
140         * WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm:
141         (createCFURLResponseFromResponseData): Use adoptNS and adoptCF.
142
143 2013-05-08  Commit Queue  <commit-queue@webkit.org>
144
145         Unreviewed, rolling out r149271.
146         http://trac.webkit.org/changeset/149271
147         https://bugs.webkit.org/show_bug.cgi?id=115780
148
149         The mangled symbols are now enforced through LDFLAGS
150         (Requested by zdobersek on #webkit).
151
152         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
153
154 2013-05-08  Zan Dobersek  <zdobersek@igalia.com>
155
156         [Flakiness Dashboard] Remove the Chromium fallback platforms listing from the legend popup
157         https://bugs.webkit.org/show_bug.cgi?id=115636
158
159         Reviewed by Ryosuke Niwa.
160
161         * TestResultServer/static-dashboards/flakiness_dashboard.js:
162         (showLegend): Remove the listing of the Chromium fallback platforms from the legend popup. The code iterated
163         through the platforms in the g_fallbacksMap dictionary to construct this part of the legend, but the dictionary,
164         while Chromium-specific, can't be removed just yet as there's more code that uses it.
165
166 2013-05-06  Darin Adler  <darin@apple.com>
167
168         Use adoptCF and adoptNS in more places, test code and code not compiled on Mac
169         https://bugs.webkit.org/show_bug.cgi?id=115657
170
171         Reviewed by Sam Weinig.
172
173         This is similar to my last set of changes, but covers code that I missed with
174         global replace using the Safari Xcode workspace.
175
176         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
177         (convertWebResourceDataToString):
178         (convertWebResourceResponseToDictionary):
179         (createXMLStringFromWebArchiveData):
180         * DumpRenderTree/cg/ImageDiffCG.cpp:
181         (createImageFromStdin):
182         (createDifferenceImage):
183         (main):
184         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
185         (printPNG):
186         (dumpBitmap):
187         * DumpRenderTree/cg/PixelDumpSupportCG.h:
188         (BitmapContext::BitmapContext):
189         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
190         (-[MockWebNotificationProvider init]):
191         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
192         (createBitmapContext):
193         * DumpRenderTree/mac/TestRunnerMac.mm:
194         (TestRunner::addDisallowedURL):
195         (TestRunner::applicationCacheDiskUsageForOrigin):
196         (TestRunner::localStorageDiskUsageForOrigin):
197         (TestRunner::clearApplicationCacheForOrigin):
198         (TestRunner::deleteLocalStorageForOrigin):
199         (TestRunner::copyDecodedHostName):
200         (TestRunner::copyEncodedHostName):
201         (TestRunner::queueLoad):
202         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
203         (TestRunner::setMockGeolocationPositionUnavailableError):
204         (TestRunner::setUserStyleSheetLocation):
205         (TestRunner::setValueForUser):
206         (TestRunner::overridePreference):
207         (TestRunner::setPersistentUserStyleSheetLocation):
208         (TestRunner::execCommand):
209         (TestRunner::findString):
210         (TestRunner::isCommandEnabled):
211         (TestRunner::addOriginAccessWhitelistEntry):
212         (TestRunner::removeOriginAccessWhitelistEntry):
213         (TestRunner::addUserScript):
214         (TestRunner::addUserStyleSheet):
215         (TestRunner::evaluateInWebInspector):
216         (TestRunner::evaluateScriptInIsolatedWorld):
217         (TestRunner::apiTestNewWindowDataLoadBaseURL):
218         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
219         (TestRunner::authenticateSession):
220         (TestRunner::grantWebNotificationPermission):
221         (TestRunner::denyWebNotificationPermission):
222         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
223         (createCFURLResponseFromResponseData):
224         * DumpRenderTree/mac/WorkQueueItemMac.mm:
225         (LoadItem::invoke):
226         (LoadHTMLStringItem::invoke):
227         (ScriptItem::invoke):
228         * DumpRenderTree/win/DumpRenderTree.cpp:
229         (substringFromIndex):
230         (urlSuitableForTestResult):
231         (lastPathComponent):
232         (sharedCFURLCache):
233         * DumpRenderTree/win/ImageDiffCairo.cpp:
234         (createImageFromStdin):
235         (main):
236         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
237         (createBitmapContextFromWebView):
238         * DumpRenderTree/win/TestRunnerWin.cpp:
239         (TestRunner::setUserStyleSheetLocation):
240         (TestRunner::setPersistentUserStyleSheetLocation):
241         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
242         (TestWebKitAPI::TEST):
243         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
244         (TestWebKitAPI::TEST):
245         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
246         (TestWebKitAPI::TEST):
247         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
248         (TestWebKitAPI::TEST):
249         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
250         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
251         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
252         (TestWebKitAPI::createWindow):
253         (TestWebKitAPI::TEST):
254         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
255         (TestWebKitAPI::TEST):
256         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
257         (TestWebKitAPI::AcceptsFirstMouse::runTest):
258         * TestWebKitAPI/Tests/mac/AttributedString.mm:
259         (TestWebKitAPI::TEST):
260         * TestWebKitAPI/Tests/mac/BackForwardList.mm:
261         (TestWebKitAPI::TEST):
262         * TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm:
263         (TestWebKitAPI::TEST):
264         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
265         (TestWebKitAPI::TEST):
266         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm:
267         (TestWebKitAPI::TEST):
268         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
269         (TestWebKitAPI::TEST):
270         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm:
271         (TestWebKitAPI::TEST):
272         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
273         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
274         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
275         (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow):
276         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
277         (TestWebKitAPI::TEST):
278         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
279         (TestWebKitAPI::TEST):
280         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
281         (TestWebKitAPI::TEST):
282         * TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.mm:
283         (TestWebKitAPI::TEST):
284         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
285         (TestWebKitAPI::TEST):
286         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
287         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
288         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
289         (TestWebKitAPI::TEST):
290         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
291         (TestWebKitAPI::TEST):
292         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
293         (TestWebKitAPI::TEST):
294         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
295         (TestWebKitAPI::TEST):
296         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
297         (TestWebKitAPI::TEST):
298         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
299         (TestWebKitAPI::TEST):
300         * TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm:
301         (TestWebKitAPI::TEST):
302         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
303         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
304         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
305         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
306         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
307         * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
308         (WTR::testPathFromURL):
309         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
310         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
311         * WebKitTestRunner/cg/TestInvocationCG.cpp:
312         (WTR::createCGContextFromImage):
313         (WTR::dumpBitmap):
314         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
315         * WebKitTestRunner/mac/EventSenderProxy.mm:
316         (WTR::EventSenderProxy::mouseScrollBy):
317         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
318         (WTR::PlatformWebView::windowSnapshotImage):
319         * WebKitTestRunner/win/TestControllerWin.cpp:
320         (WTR::TestController::initializeTestPluginDirectory):
321         Use adoptCF and adoptNS.
322
323 2013-05-07  Alex Christensen  <achristensen@apple.com>
324
325         Fix a memory leak introduced in r149692
326         https://bugs.webkit.org/show_bug.cgi?id=115766
327
328         Reviewed by Mark Rowe.
329
330         In r149692, the fix for <http://webkit.org/b/42324>, a call to WKBundleFrameCopyWebArchive was added without any 
331         matching call to WKRelease. An earlier attempted fix in r149697 introduced a RetainPtr but failed to adopt the object.
332
333         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
334         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
335         Fix the memory leak by switching to WKRetainPtr and adopting the returned object.
336
337 2013-05-07  Darin Adler  <darin@apple.com>
338
339         [Win] Fix storage leak in Windows DumpRenderTree
340         https://bugs.webkit.org/show_bug.cgi?id=115651
341
342         Reviewed by Sam Weinig.
343
344         * DumpRenderTree/win/DumpRenderTree.cpp:
345         (lastPathComponent): Added a missing call to adoptCF.
346
347 2013-05-07  Alex Christensen  <achristensen@apple.com>
348
349         fixed a memory leak introduced by bug 42324 by using a RetainPtr
350         https://bugs.webkit.org/show_bug.cgi?id=115760
351
352         Reviewed by Tim Horton.
353
354         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
355         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
356         fixed memory leak, added UNUSED_PARAM macros
357
358 2013-05-07  Alex Christensen  <achristensen@apple.com>
359
360         WebKitTestRunner needs testRunner.dumpDOMAsWebArchive
361         https://bugs.webkit.org/show_bug.cgi?id=42324
362         <rdar://problem/8193633>
363
364         Reviewed by Tim Horton.
365
366         * Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
367         Added dumpDOMAsWebArchive JavaScript function to be called by test cases.
368         * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
369         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
370         Added dumpDOMAsWebArchive code that is called when dumping.        
371         (WTR::InjectedBundlePage::dump):
372         Made DOMAsWebArchive case when dumping call dumpDOMAsWebArchive.
373         * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
374         (InjectedBundlePage):
375         Added dumpDOMAsWebArchive declaration.
376         * Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
377         (WTR::TestRunner::dumpDOMAsWebArchive):
378         Added dumpDOMAsWebArchive JS callback function that sets m_whatToDump to DOMAsWebArchive.
379         * Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
380         Added WebArchiveDumpSupport.cpp, WebArchiveDumpSupport.h, WebArchiveDumpSupportMac.mm to project.
381         * Tools/WebKitTestRunner/cf: Added.
382         * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.cpp: Added.
383         Copied from Tools/DumpRenderTree/cf for createXMLStringFromWebArchiveData and other functions it uses.
384         (convertMIMEType):
385         (convertWebResourceDataToString):
386         (normalizeHTTPResponseHeaderFields):
387         (normalizeWebResourceURL):
388         (convertWebResourceResponseToDictionary):
389         (compareResourceURLs):
390         (createXMLStringFromWebArchiveData):
391         * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.h: Added.
392         Copied from Tools/DumpRenderTree/cf for used symbol declarations.
393         * Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm: Added.
394         Copied from Tools/DumpRenderTree/mac for used functions.
395         (createCFURLResponseFromResponseData):
396         (supportedNonImageMIMETypes):
397
398 2013-05-07  Alex Christensen  <achristensen@apple.com>
399
400         Updated style of WebArchiveDumpSupport before putting it into WebKitTestRunner.
401         https://bugs.webkit.org/show_bug.cgi?id=115745
402
403         Reviewed by Tim Horton.
404
405         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
406         (compareResourceURLs):
407         Updated style.
408
409 2013-05-06  Ryosuke Niwa  <rniwa@webkit.org>
410
411         Add an 'isReadOnly' member to IDL parse tree structure
412         https://bugs.webkit.org/show_bug.cgi?id=115704
413
414         Reviewed by Kentaro Hara.
415
416         Use newly added isReadOnly attribute.
417
418         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
419         (_generateHeaderFile):
420         (_generateImplementationFile):
421         (_staticValuesGetterImplementation):
422
423 2013-05-07  Anders Carlsson  <andersca@apple.com>
424
425         Remove AlwaysInline.h from WTF
426         https://bugs.webkit.org/show_bug.cgi?id=115727
427
428         Reviewed by Brent Fulgham.
429
430         The macro that used to be in AlwaysInline.h is now in Compiler.h so there's no reason
431         to keep AlwaysInline.h around anymore.
432
433         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
434         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
435
436 2013-05-07  Andras Becsi  <andras.becsi@digia.com>
437
438         [Qt][WTR] QQuickWindowPrivate::setRenderWithoutShowing has been removed from Qt 5
439         https://bugs.webkit.org/show_bug.cgi?id=114808
440
441         Reviewed by Jocelyn Turcotte.
442
443         QQuickWindow::grabWindow() has been implemented for isVisible=false for Qt 5.1.
444         (https://codereview.qt-project.org/#change,54234)
445
446         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
447         (WTR::WrapperWindow::handleStatusChanged):
448
449 2013-05-06  Christophe Dumez  <ch.dumez@sisa.samsung.com>
450
451         Unreviewed. Add my email to EFL and BindingsScripts watchlists.
452
453         * Scripts/webkitpy/common/config/watchlist:
454
455 2013-05-06  Kangil Han  <kangil.han@samsung.com>
456
457         [EFL][WK1][PerformanceTests] Adopt --no-timeout option implementation to DumpRenderTree
458         https://bugs.webkit.org/show_bug.cgi?id=115645
459
460         Reviewed by Gyuyoung Kim.
461
462         To run performance tests in wk1, we need --no-timeout option implementation.
463         So adopt it from gtk+ port.
464
465         * DumpRenderTree/efl/DumpRenderTree.cpp:
466         (shouldSetWaitToDumpWatchdog):
467         (parseCommandLineOptions):
468         * DumpRenderTree/efl/DumpRenderTreeEfl.h:
469         * DumpRenderTree/efl/TestRunnerEfl.cpp:
470         (TestRunner::setWaitToDump):
471
472 2013-05-06  Commit Queue  <commit-queue@webkit.org>
473
474         Unreviewed, rolling out r149547.
475         http://trac.webkit.org/changeset/149547
476         https://bugs.webkit.org/show_bug.cgi?id=115682
477
478         Added unittests that fail on bots and spits out text into
479         stdout (Requested by rniwa on #webkit).
480
481         * Scripts/import-w3c-tests: Removed.
482         * Scripts/webkitpy/w3c/__init__.py: Removed.
483         * Scripts/webkitpy/w3c/test_converter.py: Removed.
484         * Scripts/webkitpy/w3c/test_converter_unittest.py: Removed.
485         * Scripts/webkitpy/w3c/test_importer.py: Removed.
486         * Scripts/webkitpy/w3c/test_importer_unittest.py: Removed.
487         * Scripts/webkitpy/w3c/test_parser.py: Removed.
488         * Scripts/webkitpy/w3c/test_parser_unittest.py: Removed.
489
490 2013-05-03  Gustavo Noronha Silva  <gns@gnome.org>
491
492         [jhbuild] bump jhbuild version to take advantage of new improvements
493         https://bugs.webkit.org/show_bug.cgi?id=115558
494
495         Reviewed by Martin Robinson.
496
497         One of the important improvements is jhbuild no longer fetches git
498         repositories if they are already at the expected revision, which should
499         make the EWS bots more robust to git servers unavailability.
500
501         * jhbuild/jhbuild-wrapper: bump jhbuild to 496974221c3a8ac4fbbc3b0a577c71cac224130d.
502
503 2013-05-06  Manuel Rego Casasnovas  <rego@igalia.com>
504
505         [GTK] Add webkit_uri_scheme_request_finish_error
506         https://bugs.webkit.org/show_bug.cgi?id=94316
507
508         Reviewed by Anders Carlsson.
509
510         * MiniBrowser/gtk/main.c:
511         (miniBrowserErrorQuark): Add function to create a global quark for
512         MiniBrowser.
513         (aboutURISchemeRequestCallback): Update MiniBrowser to use the new
514         function webkit_uri_scheme_request_finish_error().
515
516 2013-05-06  Mike Lattanzio  <mlattanzio@blackberry.com>
517
518         [BlackBerry] Enable and Expose Text Autosizing through BlackBerry::WebKit::WebSettings
519         https://bugs.webkit.org/show_bug.cgi?id=113808
520
521         Reviewed by Rob Buis.
522
523         Modify FeatureList.pm and set ENABLE_TEXT_AUTOSIZING to default
524         to true for BlackBerry.
525
526         * Scripts/webkitperl/FeatureList.pm:
527
528 2013-05-06  Jessie Berlin  <jberlin@apple.com>
529
530         check-webkit-style should complain about a layering violation if platform-specific guards are
531         used in WebCore outside of the platform directory
532         https://bugs.webkit.org/show_bug.cgi?id=115567
533
534         Reviewed by Benjamin Poulain.
535
536         * Scripts/webkitpy/style/checkers/cpp.py:
537         (check_for_webcore_platform_layering_violation):
538         If the file is in WebCore but not in platform and contains #if PLATFORM(SOMETHING), emit an error.
539         (process_line):
540         Add the check_for_webcore_platform_layering_violation.
541         (CppChecker):
542         List the new check.
543
544         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
545         (CppStyleTest.test_webcore_platform_layering_violation):
546         Add tests.
547
548 2013-05-06  David Kilzer  <ddkilzer@apple.com>
549
550         webkit-patch: fix 'upload' command with Bugzilla 4.2.5
551         <http://webkit.org/b/115667>
552
553         Reviewed by Dirk Pranke.
554
555         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
556         (Bugzilla._check_create_bug_response): Update regex to work with
557         Bugzilla 3.2.3 and 4.2.5.
558         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
559         (test__check_create_bug_response): Add new test that covers both
560         old and new <title> variations.
561
562 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
563
564         [Flakiness Dashboard] Stop decoding SnowLeopard builder names into platforms
565         https://bugs.webkit.org/show_bug.cgi?id=115661
566
567         Reviewed by Ryosuke Niwa.
568
569         The Apple Mac Snow Leopard builders are no long present so there's no need to try to decode such
570         builders into the APPLE_MAC_SNOW_LEOPARD platforms. Instead, check for the Mountain Lion builders
571         and decode their names into the APPLE_MAC_MOUNTAIN_LION platforms.
572
573         * TestResultServer/static-dashboards/flakiness_dashboard.js:
574         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
575
576 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
577
578         [Flakiness Dashboard] Remove everything Chromium from the builders.json-generating script
579         https://bugs.webkit.org/show_bug.cgi?id=114603
580
581         Reviewed by Ryosuke Niwa.
582
583         * TestResultServer/generate_builders_json.py:
584         (insert_builder_and_test_data): Only process the 'layout-tests' steps, but force the name that's used
585         to represent these to be 'layout-test', for backwards compatibility.
586         (main): Remove all the build.chromium.org masters.
587         * TestResultServer/generate_builders_json_unittest.py: Clean up the Chromium-related test cases and update other ones.
588         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
589         (GenerateBuildersJsonTest):
590         (GenerateBuildersJsonTest.test_generate_json_data):
591         * TestResultServer/static-dashboards/builders.jsonp: Updated after changes to the script, now only lists the
592         test-running builders from the webkit.org master.
593
594 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
595
596         [Flakiness Dashboard] Update expected outcome in a couple of unit tests after r148778
597         https://bugs.webkit.org/show_bug.cgi?id=114988
598
599         Reviewed by Ryosuke Niwa.
600
601         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Update the expected platforms list, the Chromium
602         and Apple Mac Snow Leopard platforms were removed with the Apple Mac Mountain Lion platform being added.
603         * TestResultServer/static-dashboards/loader_unittests.js: Update the list of the expected loaded expectations platforms,
604         mac-snowleopard isn't loaded anymore due to the support for the platform being removed, while the mac-wk2 is loaded twice,
605         once for the Apple Mac Lion and once for the Apple Mac Mountain Lion platform.
606
607 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
608
609         [Flakiness Dashboard] Remove the remaining traces of platform modifier unions
610         https://bugs.webkit.org/show_bug.cgi?id=114954
611
612         Reviewed by Ryosuke Niwa.
613
614         * TestResultServer/static-dashboards/flakiness_dashboard.js:
615         (processExpectationsForPlatform): Remove the platform tree traversal that checked for presence of the platform
616         modifier unions in the list of modifiers.
617         (generatePageForExpectationsUpdate): Only filter through the modifiers that do not represent build types or bug references.
618         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Adjust the test cases for the realModifiers unit test.
619
620 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
621
622         [Flakiness Dashboard] Simplify builder-name-based platform recognition
623         https://bugs.webkit.org/show_bug.cgi?id=114957
624
625         Reviewed by Ryosuke Niwa.
626
627         * TestResultServer/static-dashboards/flakiness_dashboard.js:
628         (determineBuilderPlatform): Renamed from nonChromiumPlatform.
629         (chromiumPlatform): Removed, unnecessary.
630         (platformAndBuildType): With Chromium builders are gone, meaning determineBuilderPlatform can be called by default
631         to determine the platform of the builder. No need to check for 'DBG' substring in the builder name to determine whether
632         the builder operates with debug builds, no webkit.org builders are named this way.
633         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
634         (platformAndBuildTypes): Remove Chromium-specific test cases, reducing the number of expected assertions this test will make.
635
636 2013-05-06  Andy Estes  <aestes@apple.com>
637
638         Added two files I neglected to commit in r149589.
639
640         * TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
641         * TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.
642
643 2013-05-04  Andy Estes  <aestes@apple.com>
644
645         REGRESSION (r125592): Reproducible crash in DOMWindow::open when a delegate closes the new window in decidePolicyForNavigationAction
646         https://bugs.webkit.org/show_bug.cgi?id=115609
647
648         Reviewed by Oliver Hunt.
649
650         Added an API test.
651
652         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
653         * TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
654         (+[TestDelegate shared]):
655         (-[TestDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
656         (-[TestDelegate webView:createWebViewWithRequest:]):
657         (TestWebKitAPI):
658         (TestWebKitAPI::TEST):
659         * TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.
660
661 2013-05-06  Antoine Quint  <graouts@apple.com>
662
663         Manage the presentation of the snapshotted plug-in using JavaScript
664         https://bugs.webkit.org/show_bug.cgi?id=115548
665
666         Reviewed by Dean Jackson.
667
668         Take into account the new plugInExtraScript method added to support
669         the injection of a JS file from the chrome client to customize the
670         rendering of a snapshotted plug-in's shadow tree.
671
672         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
673         (WTR::InjectedBundlePage::InjectedBundlePage):
674
675 2013-05-05  Anders Carlsson  <andersca@apple.com>
676
677         Remove the Vector::append overload that takes a Vector
678         https://bugs.webkit.org/show_bug.cgi?id=115535
679
680         Reviewed by Andreas Kling.
681
682         Use Vector::appendVector instead.
683
684         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
685         (concatenateAttributeAndValue):
686         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
687         (WTR::concatenateAttributeAndValue):
688
689 2013-05-04  Sam Weinig  <sam@webkit.org>
690
691         REGRESSION(r148312): Crash when calling WKPageClose(page) followed by WKPageTerminate(page)
692         <rdar://problem/13702008>
693         https://bugs.webkit.org/show_bug.cgi?id=115607
694
695         Reviewed by Benjamin Poulain.
696
697         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
698         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp: Added.
699         (TestWebKitAPI::didFinishLoadForFrame):
700         (TestWebKitAPI::TEST):
701         Add test that calls WKPageClose, follow by WKPageTerminate. If it crashes, its not working.
702
703 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
704
705         Unreviewed.
706
707         * Scripts/webkitpy/common/config/contributors.json: Correcting my igalia.com email address.
708
709 2013-05-04  Mihnea Ovidenie  <mihnea@adobe.com>
710
711         Unreviewed. Adding Radu Stavila as an Adobe contributor, working on CSSRegions.
712
713         * Scripts/webkitpy/common/config/contributors.json:
714
715 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
716
717         [GTK] Catch select.error exceptions in parse_output_lines
718         https://bugs.webkit.org/show_bug.cgi?id=115253
719
720         Reviewed by Gustavo Noronha Silva.
721
722         Catch any select.error exceptions when waiting for the file descriptor to become readable when parsing the
723         output lines in common.parse_output_lines. These are currently being thrown when running the GTK unit tests on
724         builders, but are not fatal. Because of that they are at the moment only logged (writing out the file descriptor,
725         error code and the error message) and the loop is re-entered.
726
727         * gtk/common.py:
728         (parse_output_lines):
729
730 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
731
732         [GTK] Set up the TestWebCore in TestWebKitAPI
733         https://bugs.webkit.org/show_bug.cgi?id=115237
734
735         Reviewed by Gustavo Noronha Silva.
736
737         Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
738         Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
739         a workaround for the layer violations and circular dependencies between various static libraries. Linking against
740         either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
741         shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).
742
743         * TestWebKitAPI/GNUmakefile.am:
744
745 2013-05-03  Rebecca Hauck  <rhauck@adobe.com>
746
747         Create a script to import W3C tests
748         https://bugs.webkit.org/show_bug.cgi?id=111513
749
750         Reviewed by Dirk Pranke.
751
752         Script to automate the import of W3C tests into WebKit. 
753         For the full description of how it works, see the comments
754         at the top of test_importer.py.
755
756         * Scripts/import-w3c-tests: Added.
757         * Scripts/webkitpy/w3c/__init__.py: Added.
758         * Scripts/webkitpy/w3c/test_converter.py: Added.
759         (TestConverter):
760         (TestConverter.__init__):
761         (TestConverter.load_prefixed_prop_list):
762         (TestConverter.load_file):
763         (TestConverter.convert_for_webkit):
764         (TestConverter.convert_testharness_paths):
765         (TestConverter.convert_prefixed_properties):
766         (TestConverter.scrub_unprefixed_props):
767         (TestConverter.replace_tag):
768         * Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
769         (TestConverterTest):
770         (TestConverterTest.testLoadPrefixedPropList):
771         (TestConverterTest.test_convertForWebkitNothingToConvert):
772         (test_convertForWebkitHarnessOnly):
773         (test_convertForWebkitPropsOnly):
774         (test_convertForWebkitHarnessAndProps):
775         (test_convertTestHarnessPaths):
776         (test_convertPrefixedProperties):
777         (verifyTestHarnessPaths):
778         (verifyPrefixedProperties):
779         (generateTestContent):
780         * Scripts/webkitpy/w3c/test_importer.py: Added.
781         (main):
782         (parse_args):
783         (validate_import_directory):
784         (TestImporter):
785         (TestImporter.__init__):
786         (TestImporter.do_import):
787         (TestImporter.get_changeset):
788         (TestImporter.scan_source_directory):
789         (TestImporter.import_tests):
790         (TestImporter.setup_destination_directory):
791         (TestImporter.get_test_status):
792         (TestImporter.remove_deleted_files):
793         (TestImporter.write_import_log):
794         * Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
795         (TestImporterTest):
796         (TestImporterTest.test_ImportDirWithNoTests):
797         * Scripts/webkitpy/w3c/test_parser.py: Added.
798         (TestParser):
799         (TestParser.__init__):
800         (TestParser.load_file):
801         (TestParser.analyze_test):
802         (TestParser.get_reftests):
803         (TestParser.is_jstest):
804         (TestParser.get_support_files):
805         * Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
806         (TestParserTest):
807         (TestParserTest.test_analyzeTestReftestOneMatch):
808         (test_analyzeTestReftestMultipleMatches):
809         (test_analyzeTestReftestMatchAndMismatch):
810         (test_analyzeTestReftestWithRefSupportFiles):
811         (test_analyzeJSTest):
812         (test_analyzePixelTestAllTrue):
813         (test_analyzePixelTestAllFalse):
814         (test_analyzeNonHTMLFile):
815
816 2013-05-03  Christophe Dumez  <ch.dumez@sisa.samsung.com>
817
818         Unreviewed. Update Viatcheslav Ostapenko's email in contributors.json.
819
820         * Scripts/webkitpy/common/config/contributors.json:
821
822 2013-05-02  Nico Weber  <thakis@chromium.org>
823
824         Remove a stale script file.
825         https://bugs.webkit.org/show_bug.cgi?id=115521
826
827         Reviewed by Anders Carlsson.
828
829         This script was added in
830         https://bugs.webkit.org/show_bug.cgi?id=17507, but it relies on the
831         Bakefile system that was removed in
832         https://bugs.webkit.org/show_bug.cgi?id=49983 . As a result, this
833         script just asserts when it's run and is useless.
834
835         * Scripts/update-sources-list.py: Removed.
836
837 2013-05-01  Glenn Adams  <glenn@skynav.com>
838
839         [webkitpy] Need abstract base class for commands that analyze commit logs
840         https://bugs.webkit.org/show_bug.cgi?id=115391
841
842         Reviewed by Benjamin Poulain.
843
844         Move commit log parsing functions into new abstract base class AbstractCommitLogCommand
845         in preparation for adding two new commands that will reuse this functionality along with
846         suggest-nominations. See https://bugs.webkit.org/show_bug.cgi?id=115387 and
847         https://bugs.webkit.org/show_bug.cgi?id=115388.
848
849         No new tests as this patch does not change existing functionality or behavior.
850
851         * Scripts/webkitpy/tool/commands/suggestnominations.py:
852         (AbstractCommitLogCommand): Add abstract base class for commands that analyze commit logs.
853         (AbstractCommitLogCommand.__init__):
854         (AbstractCommitLogCommand._init_options):
855         (AbstractCommitLogCommand._parse_commit_message):
856         (SuggestNominations): Move generic commit log parsing into new base class. Use new base class.
857         (SuggestNominations.__init__): 
858         (SuggestNominations._init_options):
859
860 2013-05-01  Seokju Kwon  <seokju.kwon@gmail.com>
861
862         Web Inspector: Fix check-inspector-strings script and fix localized strings
863         https://bugs.webkit.org/show_bug.cgi?id=115495
864
865         Reviewed by Joseph Pecoraro.
866
867         * Scripts/check-inspector-strings:
868
869 2013-05-01  Zan Dobersek  <zdobersek@igalia.com>
870
871         [TestWebKitAPI] <WebKit2/WebKit2_C.h> being included in GTK WK1-only builds
872         https://bugs.webkit.org/show_bug.cgi?id=115470
873
874         Reviewed by Martin Robinson.
875
876         In the TestWebKitAPI's config.h header, only include the <WebKit2/WebKit2_C.h> header when
877         not building either of the IOS, Windows or GTK-WK1 platforms.
878
879         Up until now the header was included for everything but the IOS and Windows platforms due to
880         an incorrectly stated condition regarding the GTK platform.
881
882         * TestWebKitAPI/config.h:
883
884 2013-05-01  Zan Dobersek  <zdobersek@igalia.com>
885
886         [GTK] Split the forwarding headers stamp in the TestWebKitAPI GNUmakefile.am
887         https://bugs.webkit.org/show_bug.cgi?id=115469
888
889         Reviewed by Martin Robinson.
890
891         Split the stamp-testwebkitapi-forwarding-headers into two stamps, one covering forwarding headers
892         for the WebCore tests (under the Tests/WebCore directory) and the other covering forwarding headers
893         for the WebKit2 tests and the injected bundle required by them.
894
895         This makes it possible for the WebCore tests to compile when the WebKit2 build is disabled, i.e. the WebCore
896         tests shouldn't depend on the WebKit2 build (though the forwarding headers generation script is stored
897         under the WebKit2 code).
898
899         The WebCore forwarding headers are generated by scanning only the files under the Tests/WebCore directory,
900         while the WebKit2 forwarding headers generation should keep on scanning the complete root directory of the
901         TestWebKitAPI subproject, though the target directory should be narrowed down if at all possible.
902
903         * TestWebKitAPI/GNUmakefile.am:
904
905 2013-04-30  Glenn Adams  <glenn@skynav.com>
906
907         Unreviewed. Add myself to watchlist entries.
908
909         * Scripts/webkitpy/common/config/watchlist:
910
911 2013-04-30  Glenn Adams  <glenn@skynav.com>
912
913         [webkitpy] suggest-nominations doesn't count all qualified patches
914         https://bugs.webkit.org/show_bug.cgi?id=115285
915
916         Reviewed by Benjamin Poulain.
917
918         Fix commit analysis so that patches made by an existing committer are counted towards reviewer
919         nomination. Improve commit log parsing.
920
921         * Scripts/webkitpy/tool/commands/suggestnominations.py:
922         (CommitLogError):
923         (CommitLogError.__init__):
924         (CommitLogMissingReviewer):
925         (CommitLogMissingReviewer.__init__):
926         (SuggestNominations):
927         (SuggestNominations.__init__):
928         (SuggestNominations._recent_commit_messages):
929         (SuggestNominations._author_name_from_email):
930         (SuggestNominations._contributor_from_email):
931         (SuggestNominations._parse_commit_message):
932         (SuggestNominations._count_commit):
933         (SuggestNominations._count_recent_patches):
934         (SuggestNominations._collect_nominations):
935         (SuggestNominations._print_nominations):
936         (SuggestNominations.execute):
937         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
938         (_make_options):
939         (test_recent_commit_messages):
940         (test_basic):
941
942 2013-04-30  Commit Queue  <rniwa@webkit.org>
943
944         Unreviewed, rolling out r149309.
945         http://trac.webkit.org/changeset/149309
946         https://bugs.webkit.org/show_bug.cgi?id=115430
947
948         The patch does not build on WK1-only builds of the GTK port
949         (Requested by zdobersek on #webkit).
950
951         * TestWebKitAPI/GNUmakefile.am:
952
953 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
954
955         Stop using "in" keyword in IDL files
956         https://bugs.webkit.org/show_bug.cgi?id=115418
957
958         Reviewed by Kentaro Hara.
959
960         Remove "in" keyword from IDL files as this is no longer part of the Web
961         IDL specification.
962
963         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
964         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl:
965         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl:
966         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
967         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
968         * WebKitTestRunner/InjectedBundle/Bindings/GCController.idl:
969         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
970         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
971
972 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
973
974         [EFL] Enable scaled cursors
975         https://bugs.webkit.org/show_bug.cgi?id=106242
976
977         Reviewed by Gyuyoung Kim.
978
979         Enable ENABLE_MOUSE_CURSOR_SCALE for EFL port.
980
981         * Scripts/webkitperl/FeatureList.pm:
982
983 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
984
985         Replace "Optional" extended attribute by proper Web IDL "optional" keyword
986         https://bugs.webkit.org/show_bug.cgi?id=115380
987
988         Reviewed by Kentaro Hara.
989
990         Replace WebKit-specific [Optional] extended attribute by Web IDL "optional"
991         keyword.
992
993         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
994         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
995
996 2013-04-30  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
997
998         Fix the USE(3D_GRAPHICS) build with the standard OpenGL on Windows
999         https://bugs.webkit.org/show_bug.cgi?id=114684
1000
1001         Reviewed by Simon Hausmann.
1002
1003         Remove the ANGLE requirement for USE(3D_GRAPHICS).
1004         This enables WebKit2 in the build when using a "-opengl desktop" configured Qt.
1005
1006         * qmake/mkspecs/features/features.prf:
1007
1008 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
1009
1010         [GTK] Disable Shadow DOM feature
1011         https://bugs.webkit.org/show_bug.cgi?id=115374
1012
1013         Reviewed by Martin Robinson.
1014
1015         Disable the Shadow DOM feature on the GTK port, the feature is planned for removal.
1016
1017         * Scripts/webkitperl/FeatureList.pm:
1018
1019 2013-04-29  Glenn Adams  <glenn@skynav.com>
1020
1021         [webkitpy] Add missing contributor email addresses
1022         https://bugs.webkit.org/show_bug.cgi?id=115394
1023
1024         Reviewed by Ryosuke Niwa.
1025
1026         * Scripts/webkitpy/common/config/contributors.json:
1027
1028 2013-04-29  Alberto Garcia  <agarcia@igalia.com>
1029
1030         Remove all remaining Skia code
1031         https://bugs.webkit.org/show_bug.cgi?id=115263
1032
1033         Reviewed by Benjamin Poulain.
1034
1035         Remove all remaining references to Skia.
1036
1037         * Scripts/webkitdirs.pm:
1038         (blackberryCMakeArguments):
1039         * Scripts/webkitpy/common/config/contributionareas.py:
1040         * Scripts/webkitpy/common/config/watchlist:
1041
1042 2013-04-29  Seokju Kwon  <seokju.kwon@gmail.com>
1043
1044         Get rid of unused options in Tools/Scripts/webkit-build-directory
1045         https://bugs.webkit.org/show_bug.cgi?id=115383
1046
1047         Reviewed by Darin Adler.
1048
1049         * Scripts/webkit-build-directory:
1050
1051 2013-04-29  Alexey Proskuryakov  <ap@apple.com>
1052
1053         [WK2][Mac] Test with NetworkProcess enabled.
1054
1055         Fix the build for non-Mac.
1056
1057         * WebKitTestRunner/TestController.cpp:
1058         (WTR::TestController::initialize):
1059
1060 2013-04-29  Alexey Proskuryakov  <ap@apple.com>
1061
1062         [WK2][Mac] Test with NetworkProcess enabled.
1063
1064         Reviewed by Sam Weinig.
1065
1066         * WebKitTestRunner/TestController.cpp:
1067         (WTR::TestController::initialize):
1068
1069 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
1070
1071         [GTK] Set up the TestWebCore in TestWebKitAPI
1072         https://bugs.webkit.org/show_bug.cgi?id=115237
1073
1074         Reviewed by Gustavo Noronha Silva.
1075
1076         Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
1077         Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
1078         a workaround for the layer violations and circular dependencies between various static libraries. Linking against
1079         either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
1080         shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).
1081
1082         * TestWebKitAPI/GNUmakefile.am:
1083
1084 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
1085
1086         [GTK] Set up the TestJavaScriptCore in TestWebKitAPI
1087         https://bugs.webkit.org/show_bug.cgi?id=115236
1088
1089         Reviewed by Gustavo Noronha Silva.
1090
1091         Set up the TestJavaScriptCore unit test program, consisting of the unit tests
1092         under the TestWebKitAPI/Tests/JavaScriptCore directory.
1093
1094         * TestWebKitAPI/GNUmakefile.am:
1095
1096 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
1097
1098         [GTK] Export the COLLECT_NO_DEMANGLE variable on the builders
1099         https://bugs.webkit.org/show_bug.cgi?id=115323
1100
1101         Reviewed by Philippe Normand.
1102
1103         Export the COLLECT_NO_DEMANGLE environment variable on the GTK BuildBot builders.
1104         Its presence enforces linkers to output mangled symbols when reporting linking failures
1105         due to unresolved references. People trying to fix the build can then simply copy
1106         the printed mangled symbol into the symbols.filter file instead of doing a manual build
1107         or connecting to the builders to discover the mangled version of the missing symbol.
1108
1109         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
1110
1111 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
1112
1113         Remove Chromium code from Tools/BuildSlaveSupport
1114         https://bugs.webkit.org/show_bug.cgi?id=115325
1115
1116         Reviewed by Benjamin Poulain.
1117
1118         Remove the two Chromium-specific scripts and the Chromium-specific parts from the code
1119         covering archiving test results and built products.
1120
1121         * BuildSlaveSupport/built-product-archive:
1122         (archiveBuiltProduct):
1123         (extractBuiltProduct):
1124         * BuildSlaveSupport/chromium/output-android-device-status: Removed.
1125         * BuildSlaveSupport/chromium/remove-crash-logs: Removed.
1126         * BuildSlaveSupport/test-result-archive:
1127         (archiveTestResults):
1128
1129 2013-04-28  Seokju Kwon  <seokju.kwon@gmail.com>
1130
1131         Remove support for Chromium from webkitdirs.pm
1132         https://bugs.webkit.org/show_bug.cgi?id=115338
1133
1134         Reviewed by Darin Adler.
1135
1136         * Scripts/webkitdirs.pm:
1137         (determineBaseProductDir):
1138         (argumentsForConfiguration):
1139         (builtDylibPathForName):
1140         (determineIsQt):
1141         (isAppleWebKit):
1142
1143 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
1144
1145         Rename TestRunner's setAudioData to setAudioResult
1146         https://bugs.webkit.org/show_bug.cgi?id=115326
1147
1148         Reviewed by Darin Adler.
1149
1150         Rename the TestRunner's setAudioData method to setAudioResult. The new name better conveys the method's purpose
1151         than the previous one. The change is a simple rename, there's no change in the method's functionality. The
1152         affected tests are adjusted accordingly.
1153
1154         * DumpRenderTree/qt/TestRunnerQt.cpp:
1155         (TestRunnerQt::setAudioResult):
1156         * DumpRenderTree/qt/TestRunnerQt.h:
1157         (TestRunnerQt):
1158         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1159         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1160         (WTR::TestRunner::setAudioResult):
1161         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1162         (TestRunner):
1163
1164 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
1165
1166         [WKTR] Tests dumping audio data shouldn't dump pixels
1167         https://bugs.webkit.org/show_bug.cgi?id=115270
1168
1169         Reviewed by Benjamin Poulain.
1170
1171         Prevent dumping the pixel output when Web Audio tests are dumping output data
1172         as the testing output. Pixel output in these tests has no real meaning and is
1173         as such unnecessary.
1174
1175         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1176         (WTR::TestRunner::setAudioData):
1177
1178 2013-04-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1179
1180         [EFL] Unreviewed Intel bots fix after r149231.
1181
1182         * efl/jhbuild.modules: Disable the libxml Python bindings since the
1183         bots don't have Python's development files installed. libxml should
1184         detect this kind of thing better.
1185
1186 2013-04-26  Ryuan Choi  <ryuan.choi@samsung.com>
1187
1188         [EFL] Build break using jhbuild on ubuntu 13.04
1189         https://bugs.webkit.org/show_bug.cgi?id=115225
1190
1191         Reviewed by Gyuyoung Kim.
1192
1193         libxslt in Ubuntu 13.04 requires libxml 2.9.0 or higher and
1194         libxml 2.9.0 has a bug to make regression which r138422 mentioned.
1195         So this patch bumped libxml version to 2.9.1.
1196
1197         * efl/jhbuild.modules:
1198
1199 2013-04-26  Jeffrey Pfau  <jpfau@apple.com>
1200
1201         delete-stale-build-files does not clear .d files
1202         http://bugs.webkit.org/show_bug.cgi?id=115293
1203
1204         Reviewed by Ryosuke Niwa.
1205
1206         * BuildSlaveSupport/delete-stale-build-files:
1207         (main): Add .d to the file type list
1208
1209 2013-04-26  Roger Fong  <roger_fong@apple.com>
1210
1211         Make Apple Windows VS2010 build results into and get dependencies from __32 suffixed folders.
1212         Make the DebugSuffix configuration use _debug dependencies.
1213
1214         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1215         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeApple.props:
1216         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
1217         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props:
1218         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
1219         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
1220         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props:
1221         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props:
1222         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props:
1223         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
1224         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd:
1225         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props:
1226         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
1227         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
1228         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
1229         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props:
1230         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props:
1231         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props:
1232         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1233         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props:
1234         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props:
1235         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props:
1236         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
1237         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props:
1238         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
1239         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props:
1240         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def:
1241         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1242         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
1243         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
1244         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props:
1245         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props:
1246         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
1247         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin_debug.def: Removed.
1248         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1249         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
1250         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
1251         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props:
1252         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
1253         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props:
1254         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
1255         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
1256         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
1257         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props:
1258         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props:
1259         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1260         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
1261         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props:
1262         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props:
1263         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
1264         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props:
1265         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
1266         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
1267         * win/AssembleBuildLogs/AssembleLogs.cmd:
1268         * win/record-memory/record-memory.vcxproj:
1269         * win/record-memory/record-memoryDebug.props:
1270         * win/record-memory/record-memoryDebugWinCairo.props:
1271         * win/record-memory/record-memoryProduction.props:
1272         * win/record-memory/record-memoryRelease.props:
1273         * win/record-memory/record-memoryReleaseWinCairo.props:
1274
1275 2013-04-26  Zan Dobersek  <zdobersek@igalia.com>
1276
1277         [GTK] Clean up the TestWebKitAPI GNUmakefile.am
1278         https://bugs.webkit.org/show_bug.cgi?id=115233
1279
1280         Reviewed by Martin Robinson.
1281
1282         Specify unconditional, non-installable program targets in one declaration. Only conditionally specify
1283         WebKit2-specific targets, not the complete target setups (i.e. targets' sources, cppflags listings etc.).
1284         Add missing unit test source files to the TestWTF program, namely HashSet.cpp and MetaAllocator.cpp.
1285         Specify the TestWTF program's CXXFLAGS to be the same as the global cxxflags as the source files need to
1286         be compiled with the -fno-rtti flag that's present in the global_cxxflags variable.
1287
1288         * TestWebKitAPI/GNUmakefile.am:
1289
1290 2013-04-25  Andy Estes  <aestes@apple.com>
1291
1292         [WebKit2] Loading a resource from a custom protocol in a synchronous XHR times out
1293         https://bugs.webkit.org/show_bug.cgi?id=115223
1294
1295         Reviewed by Darin Adler.
1296
1297         Added an API test.
1298
1299         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
1300         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm: Added.
1301         (TestWebKitAPI::TEST): Tested that a synchronous XHR does not time out
1302         when it loads a request with a custom protocol.
1303         * TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Added.
1304         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: Moved the
1305         NSURLProtocol subclass to TestProtocol.{h, mm} and did some
1306         miscellaneous cleanup.
1307         * TestWebKitAPI/mac/TestProtocol.h: Copied from Source/WebKit2/WebProcess/WebProcessSupplement.h.
1308         * TestWebKitAPI/mac/TestProtocol.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm.
1309         (+[TestProtocol canInitWithRequest:]):
1310         (+[TestProtocol canonicalRequestForRequest:]):
1311         (+[TestProtocol requestIsCacheEquivalent:toRequest:]):
1312         (+[TestProtocol scheme]):
1313         (-[TestProtocol startLoading]):
1314         (-[TestProtocol stopLoading]):
1315
1316 2013-04-26  Martin Robinson  <mrobinson@igalia.com>
1317
1318         Remove the remaining Skia #ifdefs
1319         https://bugs.webkit.org/show_bug.cgi?id=114886
1320
1321         Reviewed by Benjamin Poulain.
1322
1323         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
1324         (createBitmapContextFromWebView): Remove Skia #ifdef references.
1325
1326 2013-04-26  Mary Wu  <mary.wu@torchmobile.com.cn>
1327
1328         [BlackBerry] Clean up load interface in WebPage
1329         https://bugs.webkit.org/show_bug.cgi?id=113267
1330
1331         Reviewed by Rob Buis.
1332
1333         Update DumpRenderTree with change of load() interface in WebPage.
1334         RIM Bug# 315535, internally reviewed by Joe Mason.
1335
1336         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1337         (BlackBerry::WebKit::DumpRenderTree::runTest):
1338
1339 2013-04-26  Zan Dobersek  <zdobersek@igalia.com>
1340
1341         Remove the HeapGraphSerializer unit test
1342         https://bugs.webkit.org/show_bug.cgi?id=115231
1343
1344         Reviewed by Andreas Kling.
1345
1346         Remove the HeapGraphSerializer unit test. The code it was testing was removed in r148921,
1347         specifically the Source/WebCore/inspector/HeapGraphSerializer.(cpp|h) files.
1348
1349         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed.
1350
1351 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
1352
1353         Remove support for Chromium from build/update scripts
1354         https://bugs.webkit.org/show_bug.cgi?id=115218
1355
1356         Reviewed by Darin Adler.
1357
1358         * Scripts/build-webkit:
1359         (writeCongrats):
1360         * Scripts/update-webkit:
1361
1362 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
1363
1364         Remove support for Chromium from api-test
1365         https://bugs.webkit.org/show_bug.cgi?id=115211
1366
1367         Reviewed by Dirk Pranke.
1368
1369         * Scripts/build-api-tests:
1370         * Scripts/run-api-tests:
1371         (isSupportedPlatform):
1372
1373 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
1374
1375         Get rid of Chromium in build-dumprendertree
1376         https://bugs.webkit.org/show_bug.cgi?id=115212
1377
1378         Reviewed by Dirk Pranke.
1379
1380         * Scripts/build-dumprendertree:
1381
1382 2013-04-25  Alexey Proskuryakov  <ap@apple.com>
1383
1384         Pass relatedPage when creating a page in WebKitTestRunner
1385         https://bugs.webkit.org/show_bug.cgi?id=115206
1386
1387         Reviewed by Geoffrey Garen.
1388
1389         To make sure that window.open() opens in the same process even when using multiple processes.
1390
1391         * WebKitTestRunner/PlatformWebView.h:
1392         * WebKitTestRunner/TestController.cpp:
1393         (WTR::TestController::createOtherPage):
1394         (WTR::TestController::createWebViewWithOptions):
1395         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1396         (WTR::PlatformWebView::PlatformWebView):
1397         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1398         (WTR::PlatformWebView::PlatformWebView):
1399         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1400         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useTiledDrawing:]):
1401         (WTR::PlatformWebView::PlatformWebView):
1402         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1403         (WTR::PlatformWebView::PlatformWebView):
1404         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1405         (WTR::PlatformWebView::PlatformWebView):
1406
1407 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
1408
1409         Fix autocompletion for Benjamin. The Bugzilla email address must come first.
1410
1411         * Scripts/webkitpy/common/config/contributors.json:
1412
1413 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
1414
1415         Build fix. Forgot to merge args.
1416
1417         * Scripts/webkitpy/tool/bot/irc_command.py:
1418         (Hi.execute):
1419
1420 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
1421
1422         webkitbot should recognize its own nickname in greetings.
1423         https://bugs.webkit.org/show_bug.cgi?id=115196
1424
1425         Reviewed by Andreas Kling.
1426
1427         Make webkitbot recognize other forms of its nick. Also be tolerant of spaces between the nick and !.
1428
1429         * Scripts/webkitpy/tool/bot/irc_command.py:
1430         (Hi.execute):
1431
1432 2013-04-25  Xavier Castano  <xcastanho@igalia.com>
1433
1434         [GTK] Tools/gtk/install-dependencies added ragel dependency
1435         https://bugs.webkit.org/show_bug.cgi?id=115163
1436
1437         Reviewed by Xan Lopez.
1438
1439         The install-dependencies script was missing a dependency on ragel
1440         which is expected when building HarfBuzz.
1441
1442         * gtk/install-dependencies: Added a dependency on ragel for both
1443         apt and yum.
1444
1445 2013-04-25  Eduardo Lima Mitev  <elima@igalia.com>
1446
1447         [GTK] Remove pango from optional jhbuild dependencies
1448         https://bugs.webkit.org/show_bug.cgi?id=115162
1449
1450         Reviewed by Martin Robinson.
1451
1452         Pango is not needed since revision r148293 that lowers the pango
1453         dependency to 1.30, which is available in most distributions.
1454
1455         * gtk/jhbuild-optional.modules: Removes description of pango module.
1456
1457 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
1458
1459         Remove Chromium-specific cases from FeatureList.pm
1460         https://bugs.webkit.org/show_bug.cgi?id=115169
1461
1462         Reviewed by Andreas Kling.
1463
1464         * Scripts/webkitperl/FeatureList.pm:
1465
1466 2013-04-24  Seokju Kwon  <seokju.kwon@gmail.com>
1467
1468         Remove checking chromium from run-webkit-tests
1469         https://bugs.webkit.org/show_bug.cgi?id=115139
1470
1471         Reviewed by Benjamin Poulain.
1472
1473         * Scripts/run-webkit-tests:
1474         (useNewRunWebKitTests):
1475
1476 2013-04-24  Simon Fraser  <simon.fraser@apple.com>
1477
1478         Pixel tests in SVG are all broken in WK2
1479         https://bugs.webkit.org/show_bug.cgi?id=114218
1480
1481         Reviewed by Darin Adler.
1482         
1483         Window snapshots in WebKitTestRunner on Mac are window-sized
1484         (800x600), which is wrong for the W3C SVG tests that require a
1485         480x360 snapshot.
1486         
1487         Fix by resizing the window, as well as the web view in
1488         PlatformWebView::resizeTo() so that window snapshots are correctly
1489         sized.
1490         
1491         Also do some drive-by cleanup of the window size constants in both
1492         DRT and WTR to remove magic numbers, and make the code more similar.
1493         
1494         * DumpRenderTree/TestRunner.cpp:
1495         (TestRunner::setShouldPaintBrokenImage):
1496         * DumpRenderTree/TestRunner.h:
1497         * DumpRenderTree/efl/DumpRenderTree.cpp:
1498         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1499         (webInspectorShowWindow):
1500         * DumpRenderTree/mac/DumpRenderTree.mm:
1501         (createWebViewAndOffscreenWindow):
1502         (sizeWebViewForCurrentTest):
1503         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1504         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1505         (createPagedBitmapContext):
1506         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1507         (DumpRenderTree::DumpRenderTree):
1508         (DumpRenderTree::open):
1509         * DumpRenderTree/qt/TestRunnerQt.cpp:
1510         * DumpRenderTree/qt/TestRunnerQt.h:
1511         * DumpRenderTree/win/DumpRenderTree.cpp:
1512         (sizeWebViewForCurrentTest):
1513         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1514         * WebKitTestRunner/TestController.cpp:
1515         (WTR::TestController::resetStateToConsistentValues):
1516         * WebKitTestRunner/TestController.h:
1517         * WebKitTestRunner/TestInvocation.cpp:
1518         (WTR::sizeWebViewForCurrentTest):
1519         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1520         (WTR::PlatformWebView::PlatformWebView):
1521         (WTR::PlatformWebView::resizeTo):
1522
1523 2013-04-24  Byungwoo Lee  <bw80.lee@samsung.com>
1524
1525         [EFL] Fix build error after r148963.
1526         https://bugs.webkit.org/show_bug.cgi?id=115126
1527
1528         Reviewed by Laszlo Gombos.
1529
1530         Generate forwarding headers for 'CoordinatedGraphics' to generate WKView.h
1531
1532         * TestWebKitAPI/PlatformEfl.cmake:
1533
1534 2013-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1535
1536         [GTK] Use stamp files for generate-forwarding-headers makefile rules
1537         https://bugs.webkit.org/show_bug.cgi?id=115118
1538
1539         Reviewed by Martin Robinson.
1540
1541         Use a stamp file for the TestWebKitAPI and WebKitTestRunner
1542         forwarding generator rules and don't call it for soup since there
1543         aren't soup directories in TestWebKitAPI and WebKitTestRunner.
1544
1545         * TestWebKitAPI/GNUmakefile.am:
1546         * WebKitTestRunner/GNUmakefile.am:
1547
1548 2013-04-24  Simon Pena  <simon.pena@samsung.com>
1549
1550         [GTK] Update build dependencies
1551         https://bugs.webkit.org/show_bug.cgi?id=115111
1552
1553         Reviewed by Martin Robinson.
1554
1555         The install-dependencies script was missing a dependency on EGL,
1556         which is expected when building Cairo.
1557
1558         * gtk/install-dependencies: Added a dependency on libegl1-mesa
1559         for both apt and yum.
1560
1561 2013-04-24  Seokju Kwon  <seokju.kwon@gmail.com>
1562
1563         Remove the Chromium-specific helper from run_webkit_tests.py
1564         https://bugs.webkit.org/show_bug.cgi?id=114996
1565
1566         Reviewed by Dirk Pranke.
1567
1568         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1569         (parse_args):
1570
1571 2013-04-24  Sergio Correia  <sergio.correia@openbossa.org>
1572
1573         [EFL][WK2]: Fix WKViewClientWebProcessCallbacks WK2 API test
1574         https://bugs.webkit.org/show_bug.cgi?id=114850
1575
1576         Reviewed by Andreas Kling.
1577
1578         Revision r148312 fixed WebPageProxy cleanup and also changed the process
1579         termination semantics when requested by the user so that a client is not
1580         notified of a crash anymore, since there was no crash anyway.
1581
1582         That change broke WKViewClientWebProcessCallbacks WK2 API test, since it
1583         relied on being notified of a crash after calling WKPageTerminate(). As
1584         a result of not being notified of such non-existent crash, the test would
1585         timeout right after making the terminate call.
1586
1587         This patch adds an InjectedBundle to be used for simulating a crash, by
1588         calling abort() upon receiving a "Crash" message, and thus we are able to
1589         keep testing the crash callback.
1590
1591         This patch also re-enables the WKViewClientWebProcessCallbacks test, which
1592         had been disabled in revisions r148858 and r148855, since it was failing.
1593
1594         * TestWebKitAPI/PlatformEfl.cmake:
1595         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1596         (TestWebKitAPI::TEST):
1597         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Added.
1598         (TestWebKitAPI):
1599         (WKViewClientWebProcessCallbacksTest):
1600         (TestWebKitAPI::WKViewClientWebProcessCallbacksTest::WKViewClientWebProcessCallbacksTest):
1601         (TestWebKitAPI::WKViewClientWebProcessCallbacksTest::didReceiveMessage):
1602
1603 2013-04-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1604
1605         [EFL][WK2] WebKitTestRunner failures due to IconDatabase assertions
1606         https://bugs.webkit.org/show_bug.cgi?id=115095
1607
1608         Reviewed by Antonio Gomes.
1609
1610         Use different subfolders under DumpRenderTree Temp folder for every
1611         functionality (icon database, cache, localstorage, ...). This makes
1612         sure there is no conflict between the functionalities.
1613
1614         In EFL's case, libsoup cache was causing problems for the icon
1615         database if sharing the same folder.
1616
1617         * WebKitTestRunner/TestController.cpp:
1618         (WTR::TestController::initialize):
1619
1620 == Rolled over to ChangeLog-2013-04-24 ==