[GTK][CMake] Unable to do make install
[WebKit-https.git] / Tools / ChangeLog
1 2014-05-05  Martin Robinson  <mrobinson@igalia.com>
2
3         [GTK][CMake] Unable to do make install
4         https://bugs.webkit.org/show_bug.cgi?id=130188
5
6         Reviewed by Carlos Garcia Campos.
7
8         * Scripts/webkitdirs.pm:
9         (buildCMakeGeneratedProject): Always build gtkdoc-no-html for WebKitGTK+. This
10         will give an early signal that a change has broken the documentation.
11
12 2014-05-05  Pratik Solanki  <psolanki@apple.com>
13
14         Update framework locations in package-root
15         https://bugs.webkit.org/show_bug.cgi?id=132571
16
17         Reviewed by Simon Fraser.
18
19         * Scripts/package-root:
20
21 2014-05-05  Ryuan Choi  <ryuan.choi@samsung.com>
22
23         [EFL][WK2] Refactor favicon database APIs
24         https://bugs.webkit.org/show_bug.cgi?id=132519
25
26         Reviewed by Gyuyoung Kim.
27
28         * MiniBrowser/efl/main.c: Use ewk_favicon_database_icon_get instead of ewk_view_favicon_get.
29         (update_view_favicon):
30         (on_icon_changed_cb):
31         (window_free):
32         (on_url_changed):
33         (window_create):
34         (on_view_favicon_changed): Deleted.
35
36 2014-05-02  Mark Rowe  <mrowe@apple.com>
37
38         <https://webkit.org/b/132505> Make it possible to tell copy-webkitlibraries-to-product-directory which OS X version to copy for
39
40         Reviewed by Dan Bernstein.
41
42         * Scripts/copy-webkitlibraries-to-product-directory: Add an --osx-version argument and use the passed value
43         when determining which LLVM archive to extract.
44
45 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
46
47         Add Jeremy as a committer.
48         https://bugs.webkit.org/show_bug.cgi?id=132492
49
50         Reviewed by Jer Noble.
51
52         Add myself as a committer.
53
54         * Scripts/webkitpy/common/config/contributors.json:
55
56 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
57
58         Add Jeremy as a committer.
59         https://bugs.webkit.org/show_bug.cgi?id=132492
60
61         Reviewed by Jer Noble.
62
63         Add Jeremy Jones to the committers file.
64
65         * Scripts/webkitpy/common/config/contributors.json:
66
67 2014-05-02  Brian J. Burg  <burg@cs.washington.edu>
68
69         Hard to figure out how to run a single test with run-api-tests
70         https://bugs.webkit.org/show_bug.cgi?id=116332
71
72         Reviewed by Alexey Proskuryakov.
73
74         * Scripts/run-api-tests: add two examples to the help message.
75
76 2014-05-02  Simon Fraser  <simon.fraser@apple.com>
77
78         Fix several memory leaks found by code inspection
79         https://bugs.webkit.org/show_bug.cgi?id=132472
80
81         Reviewed by Geoffrey Garen.
82         
83         Fix memory leaks.
84
85         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
86         (TestWebKitAPI::TEST):
87         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
88         (WTR::InjectedBundlePage::willSendRequestForFrame):
89         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
90         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
91
92 2014-05-02  Filip Pizlo  <fpizlo@apple.com>
93
94         DFGAbstractInterpreter should not claim Int52 arithmetic creates Int52s
95         https://bugs.webkit.org/show_bug.cgi?id=132446
96
97         Reviewed by Mark Hahnenberg.
98         
99         Test the FTL by default now that it's enabled by default.
100
101         * Scripts/run-javascriptcore-tests:
102
103 2014-05-01  Ryuan Choi  <ryuan.choi@samsung.com>
104
105         [EFL][WK1] Drop ewk_view_setting_tiled_backingstore APIs
106         https://bugs.webkit.org/show_bug.cgi?id=132240
107
108         Reviewed by Anders Carlsson.
109
110         Removed ewk_view_setting_tiled_backingstore related code.
111
112         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
113         (DumpRenderTreeChrome::createView):
114         (shouldUseTiledBackingStore): Deleted.
115         * EWebLauncher/main.c:
116         (windowCreate):
117         (parseUserArguments):
118
119 2014-05-01  Anders Carlsson  <andersca@apple.com>
120
121         window.testRunner.keepWebHistory() should update the UI process state
122         https://bugs.webkit.org/show_bug.cgi?id=132440
123
124         Reviewed by Dan Bernstein.
125
126         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
127         (WTR::InjectedBundle::postSetAddsVisitedLinks):
128         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
129         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
130         (WTR::TestRunner::keepWebHistory):
131         * WebKitTestRunner/TestInvocation.cpp:
132         (WTR::TestInvocation::invoke):
133         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
134
135 2014-05-01  David Kilzer  <ddkilzer@apple.com>
136
137         Really remove ENABLE_PLUGIN_PROXY_FOR_VIDEO
138         <http://webkit.org/b/132432>
139
140         Reviewed by Tim Horton.
141
142         * Scripts/webkitperl/FeatureList.pm: Remove support for
143         --plugin-proxy-for-video switch.
144
145 2014-04-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
146
147         Kernel sysctl interface hw.activecpu don't exists on Linux.
148         https://bugs.webkit.org/show_bug.cgi?id=132286
149
150         Reviewed by Filip Pizlo.
151
152         * Scripts/run-jsc-stress-tests: Redirect stderr to null when
153         calling sysctl over hw.activecpu
154
155 2014-04-30  Anders Carlsson  <andersca@apple.com>
156
157         Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework
158         https://bugs.webkit.org/show_bug.cgi?id=132399
159         <rdar://problem/15920046>
160
161         Reviewed by Dan Bernstein.
162
163         * Scripts/check-for-webkit-framework-include-consistency:
164         Allos WAK headers in WebKitLegacy as well as WebKit.
165
166         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
167         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
168         Update header imports.
169
170 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
171
172         [iOS WK2] Add test URL to crash reports for the UI process, clean up project
173         https://bugs.webkit.org/show_bug.cgi?id=131954
174
175         Reviewed by Darin Adler.
176         
177         WebKitTestRunner was adding application-specific information to crash reports
178         to log the test path, but only in the web process. Fix it to also do this
179         for the UI process, for both iOS and OS X.
180         
181         Moved InjectedBundlePageMac.mm to InjectedBundlePageCocoa.mm and compile it for
182         both iOS and OS X.
183         
184         Factored crash reprorter-related code into CrashReporterInfo, and call it from
185         a new TestController::platformWillRunTest() function on Mac and iOS.
186         
187         Also remove Xcode-added unit test junk from the project.
188
189         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
190         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
191         * WebKitTestRunner/TestController.cpp:
192         (WTR::TestController::runTest):
193         * WebKitTestRunner/TestController.h:
194         * WebKitTestRunner/TestInvocation.cpp:
195         (WTR::TestInvocation::url):
196         * WebKitTestRunner/TestInvocation.h:
197         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
198         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Removed.
199         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Removed.
200         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Removed.
201         * WebKitTestRunner/cocoa/CrashReporterInfo.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
202         * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Renamed from Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm.
203         (WTR::testPathFromURL):
204         (WTR::setCrashReportApplicationSpecificInformationToURL):
205         * WebKitTestRunner/efl/TestControllerEfl.cpp:
206         (WTR::TestController::platformWillRunTest):
207         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
208         (WTR::TestController::platformWillRunTest):
209         * WebKitTestRunner/ios/TestControllerIOS.mm:
210         (WTR::TestController::platformWillRunTest):
211         (WTR::TestController::setHidden):
212         * WebKitTestRunner/mac/TestControllerMac.mm:
213         (WTR::TestController::platformWillRunTest):
214
215 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
216
217         Fix DRT assertion about mock scrollbars, which doesn't apply to iOS.
218
219         Reviewed by Tim Horton.
220
221         * DumpRenderTree/mac/DumpRenderTree.mm:
222         (resetWebPreferencesToConsistentValues):
223         (prepareConsistentTestingEnvironment):
224
225 2014-04-30  Anders Carlsson  <andersca@apple.com>
226
227         check-for-inappropriate-macros-in-external-headers should get the product name, not the project name
228         https://bugs.webkit.org/show_bug.cgi?id=132397
229
230         Reviewed by Dan Bernstein.
231
232         * Scripts/check-for-inappropriate-macros-in-external-headers:
233
234 2014-04-29  Martin Robinson  <mrobinson@igalia.com>
235
236         [GTK] Make it easier to run CMake for downstreams
237         https://bugs.webkit.org/show_bug.cgi?id=132370
238
239         Reviewed by Carlos Garcia Campos.
240
241         * Scripts/webkitdirs.pm:
242         (generateBuildSystemFromCMakeProject): Pass -DDEVELOPER_MODE when building
243         the GTK+ port.
244
245 2014-04-29  Stephanie Lewis  <slewis@apple.com>
246
247         <rdar://problem/16765765> Use JSON::PP in perl scripts instead of JSON.
248         
249         Rubber stamped by Jessie Berlin.
250
251         JSON.pm was removed from our tools setup.
252
253         * Scripts/generate-coverage-data:
254
255 2014-04-29  Filip Pizlo  <fpizlo@apple.com>
256
257         Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)
258         https://bugs.webkit.org/show_bug.cgi?id=112840
259
260         Rubber stamped by Geoffrey Garen.
261
262         * Scripts/build-jsc: Enable it on Mac.
263         * Scripts/build-webkit: Enable it on Mac.
264         * Scripts/export-llvm-build: Make it slightly easier to export the build if you've done a "make install".
265
266 2014-04-28  Sam Weinig  <sam@webkit.org>
267
268         REGRESSION (r167751): svn-create-patch is very slow
269         https://bugs.webkit.org/show_bug.cgi?id=132300
270
271         Reviewed by Alexey Proskuryakov.
272
273         * Scripts/svn-create-patch:
274         Change default behavior of svn-create-patch to no longer run the style checker. It can still be run
275         by calling `svn-create-patch --style`.
276
277 2014-04-29  Enrique Ocaña González  <eocanha@igalia.com>
278
279         Generate Eclipse project + ninja build for GTK+ if Eclipse in available in the PATH
280         https://bugs.webkit.org/show_bug.cgi?id=132190
281
282         Reviewed by Gustavo Noronha Silva.
283
284         * Scripts/webkitdirs.pm:
285         (canUseEclipse): Test if Eclipse is in the path. This is the same method used to test
286             if ninja is in the path.
287         (generateBuildSystemFromCMakeProject): Use the eclipse generator if possible, fallback
288             to the previous ninja generator if not.
289
290 2014-04-29  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
291
292         check-webkit-style should understand --git-index
293         https://bugs.webkit.org/show_bug.cgi?id=125364
294
295         Reviewed by Csaba Osztrogonác.
296
297         * Scripts/webkitpy/common/checkout/scm/git.py:
298         (Git.create_patch): The command now supports the --cached option.
299         * Scripts/webkitpy/style/main.py:
300         (CheckWebKitStyle.main): Passing the --git-index option.
301         * Scripts/webkitpy/style/optparser.py:
302         (CommandOptionValues.__init__): The git-index option is switched off by default.
303         (CommandOptionValues.__eq__): Equality check for the new option.
304         (ArgumentParser._create_option_parser):Adding the --git-index option
305         (ArgumentParser.parse):
306         * Scripts/webkitpy/style/optparser_unittest.py: New tests for the --git-index option
307         (CommandOptionValuesTest.test_init): 
308         (CommandOptionValuesTest.test_eq):
309
310 2014-04-28  Michael Saboff  <msaboff@apple.com>
311
312         Crash in platform/mac/accessibility/table-visible-rows.html
313         https://bugs.webkit.org/show_bug.cgi?id=132146
314
315         Reviewed by Filip Pizlo.
316
317         Instead of creating a local JSValueRef array on the stack and passing that to
318         JSObjectMakeArray(), changed to create an empty JSArray and then populate the
319         values using the JSObjectSetPropertyAtIndex() API.
320
321         * DumpRenderTree/AccessibilityUIElement.cpp:
322         (elementsForRangeCallback):
323         (convertElementsToObjectArray):
324         * DumpRenderTree/mac/TestRunnerMac.mm:
325         (originsArrayToJS):
326         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
327         (WTR::EventSendingController::contextClick):
328         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
329         (WTR::stringArrayToJS):
330         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
331         (WTR::convertElementsToObjectArray):
332
333 2014-04-28  Filip Pizlo  <fpizlo@apple.com>
334
335         Make sure that the coverage of our tests doesn't change much if we change the thresholds now and in the future, but making
336         "no-cjit" runs force the old-school threshold.
337
338         Rubber stamped by Mark Hahnenberg.
339
340         * Scripts/run-jsc-stress-tests:
341
342 2014-04-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
343
344         [GTK] install-dependencies should also install ruby-json and ruby-highline
345         https://bugs.webkit.org/show_bug.cgi?id=132292
346
347         Reviewed by Philippe Normand.
348
349         * gtk/install-dependencies: Install ruby json and highline packages.
350
351 2014-04-27  Joonghun Park  <jh718.park@samsung.com>
352
353         [EFL] Remove indexedDB's dependency on leveldb and disable indexedDB
354         https://bugs.webkit.org/show_bug.cgi?id=132176
355
356         Reviewed by Gyuyoung Kim.
357
358         EFL port will use sqlite to support indexedDB. So, this patch removes levelDB dependency
359         and turn off indexedDB feature until the sqlite implementation is introduced.
360
361         * Scripts/webkitperl/FeatureList.pm:
362
363 2014-04-25  James Craig  <jcraig@apple.com>
364
365         Set prepare-Changelog flag so that it no longer runs check-webkit-style by default
366         https://bugs.webkit.org/show_bug.cgi?id=132209
367
368         Reviewed by Daniel Bates.
369
370         Set default to --no-style to avoid additional spew from false positives in check-webkit-style.
371         Run check-webkit-style before generating changelogs to avoid additional spurious errors.
372
373         * Scripts/prepare-ChangeLog:
374         (main): 
375
376 2014-04-25  Michael Saboff  <msaboff@apple.com>
377
378         Crash in platform/mac/accessibility/table-visible-rows.html
379         https://bugs.webkit.org/show_bug.cgi?id=132146
380
381         Reviewed by Mark Lam.
382
383         Changed to use a local JSValueRef array temporary instead of a
384         std::make_unique<JSValueRef[]> when making an array of JSValues so that the temporary
385         JSValues are visited during garbage collection when the stack is scanned.  Otherwise,
386         the temporary values could be collected.
387
388         * DumpRenderTree/AccessibilityUIElement.cpp:
389         (convertElementsToObjectArray):
390         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
391         (WTR::EventSendingController::contextClick):
392         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
393         (WTR::convertElementsToObjectArray):
394
395 2014-04-24  Eduardo Lima Mitev  <elima@igalia.com>
396
397         Unreviewed GTK gardening
398
399         * Scripts/run-gtk-tests: Skips one flaky accesibility test in WK2API suite
400         (TestRunner):
401
402 2014-04-24  László Langó  <llango.u-szeged@partner.samsung.com>
403
404         prepare-ChangeLog reports as deleted methods that has not been removed.
405         https://bugs.webkit.org/show_bug.cgi?id=131733
406
407         Reviewed by Ryosuke Niwa.
408
409         * Scripts/prepare-ChangeLog:
410         (originalFile): Set merge base to origin/master by default.
411
412 2014-04-23  James Craig  <jcraig@apple.com>
413
414         prepare-Changelog and svn-create-patch should optionally run check-webkit-style.
415         https://bugs.webkit.org/show_bug.cgi?id=131115
416
417         Reviewed by Daniel Bates.
418
419         Added [--[no-]style] param to run check-webkit-style as part of prepare-Changelog and svn-create-patch.
420
421         * Scripts/commit-log-editor: Added --no-style.
422         * Scripts/prepare-ChangeLog: Primary patch.
423         (main): Primary patch.
424         (createPatchCommand): Added --no-style.
425         * Scripts/svn-create-patch: Primary patch.
426         * Scripts/webkit-tools-completion.sh: Added --style and --no-style.
427         * Scripts/webkitpy/common/checkout/scm/svn.py: Added --no-style.
428         (SVN.create_patch): Added --no-style.
429
430 2014-04-23  Anders Carlsson  <andersca@apple.com>
431
432         Try to fix iOS build.
433
434         * DumpRenderTree/mac/DumpRenderTree.mm:
435
436 2014-04-23  Alexey Proskuryakov  <ap@apple.com>
437
438         Eliminate internals.setMockScrollbarsEnabled()
439         https://bugs.webkit.org/show_bug.cgi?id=132085
440
441         Reviewed by Tim Horton.
442
443         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues):
444         No need to reset the preference, there is no way it can change.
445
446 2014-04-23  James Craig  <jcraig@apple.com>
447
448         Unreviewed. Moving myself from Contributors to Committers list.
449
450         * Scripts/webkitpy/common/config/contributors.json:
451
452 2014-04-23  Tim Horton  <timothy_horton@apple.com>
453
454         Mock scrollbars don't always work in DumpRenderTree
455         https://bugs.webkit.org/show_bug.cgi?id=132082
456
457         Reviewed by Alexey Proskuryakov.
458
459         * DumpRenderTree/mac/DumpRenderTree.mm:
460         (prepareConsistentTestingEnvironment):
461         Set the mock scrollbar setting before creating the WebView, as this setting
462         cannot be dynamically changed, so any scrollbars that are created during
463         WebView initialization and are not replaced before snapshotting will end
464         up being platform scrollbars instead of mock ones.
465         WebKitTestRunner already sets this preference before creating WKViews,
466         so we're just matching its behavior.
467
468 2014-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
469
470         [GTK] ShadowRoot API was removed in r164131
471         https://bugs.webkit.org/show_bug.cgi?id=132059
472
473         Reviewed by Gustavo Noronha Silva.
474
475         Add WebKitDOMShadowRoot to the list of deleted classes to generate
476         the API docs.
477
478         * gtk/webkitdom.py:
479         (WebKitDOMDocGenerator):
480
481 2014-04-23  Lorenzo Tilve  <ltilve@igalia.com>
482
483         [GTK] run-webkit-tests script is failing to invoke run-launcher
484         https://bugs.webkit.org/show_bug.cgi?id=132051
485
486         Reviewed by Philippe Normand.
487
488         After the WK1 support was dropped, if run-webkit-tests is executed
489         without --no-show-results parameter, the launcher is being called
490         using a -2 parameter that is it causing the run-launcher to break.
491
492         * Scripts/webkitpy/port/gtk.py:
493         (GtkPort.show_results_html_file):
494
495 2014-04-22  Tim Horton  <timothy_horton@apple.com>
496
497         DumpRenderTree generates black snapshots on some platforms
498         https://bugs.webkit.org/show_bug.cgi?id=132029
499         <rdar://problem/16679363>
500
501         Reviewed by Simon Fraser.
502
503         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
504         (createBitmapContextFromWebView):
505         DRT checks with the WebView to determine whether it can use the window's
506         backing store directly or (because of compositing) needs to take a WindowServer
507         snapshot. However, on some platforms and in some situations, the window can
508         be layer backed without the WebView necessarily currently being composited.
509         We should check with the window in addition to the WebView before going
510         ahead and using its backing store.
511
512 2014-04-22  Tim Horton  <timothy_horton@apple.com>
513
514         DumpRenderTree generates white snapshots on some platforms
515         https://bugs.webkit.org/show_bug.cgi?id=132026
516         <rdar://problem/16679363>
517
518         Reviewed by Simon Fraser.
519
520         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
521         Link DRT against QuartzCore.
522
523         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
524         (createBitmapContextFromWebView):
525         Force CoreAnimation to synchronously update layers in a more explicit
526         way that doesn't depend on AppKit behavior. This is very similar to what
527         WebKitTestRunner does (indirectly) during its force repaint.
528
529 2014-04-22  Brent Fulgham  <bfulgham@apple.com>
530
531         [Win] Support Python 2.7 in Cygwin
532         https://bugs.webkit.org/show_bug.cgi?id=132023
533
534         Reviewed by Michael Saboff.
535
536         * Scripts/webkitdirs.pm:
537         (checkInstalledTools): Remove check for Python 2.7, since
538         it now works properly.
539
540 2014-04-22  Filip Pizlo  <fpizlo@apple.com>
541
542         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
543         https://bugs.webkit.org/show_bug.cgi?id=130867
544         <rdar://problem/16432456> 
545
546         Reviewed by Mark Hahnenberg.
547
548         * Scripts/build-webkit:
549         * Scripts/copy-webkitlibraries-to-product-directory:
550
551 2014-04-22  Gustavo Noronha Silva  <gns@gnome.org>
552
553         [GTK] Fails to build documentation when output is redirected
554         https://bugs.webkit.org/show_bug.cgi?id=131178
555
556         Reviewed by Martin Robinson.
557
558         * gtk/generate-gtkdoc: set the output for stdout and stderr to UTF-8
559         explicitly to avoid encoding issues when they are redirected.
560
561 2014-04-22  ChangSeok Oh  <changseok.oh@collabora.com>
562
563         [GTK] YCM choose a newer compile_commands.json in between Release or Debug
564         https://bugs.webkit.org/show_bug.cgi?id=131911
565
566         Reviewed by Martin Robinson.
567
568         common.get_build_path returns release path even though Debug configuration
569         is newer than Release. So YouCompleteMe is used to refer old build setup inadvertently.
570
571         * gtk/ycm_extra_conf.py:
572         (get_build_path): Compare modified time of Release and Debug. And return a recent modified path.
573         (FlagsForFile):
574
575 2014-04-21  Brent Fulgham  <bfulgham@apple.com>
576
577         Unreviewed build fix.
578
579         * DumpRenderTree/mac/EventSendingController.mm:
580         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
581         Correct a typo that prevented tests from working properly.
582
583 2014-04-21  Martin Robinson  <mrobinson@igalia.com>
584
585         [GTK] Should have the ability to output composited contents during layout testing
586         https://bugs.webkit.org/show_bug.cgi?id=131864
587
588         Reviewed by Philippe Normand.
589
590         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
591         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Add a path that paints the widget contents
592         to an image surface. We run the main loop a bit to match the implementation from WebKit1 and EFL.
593         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
594         (WTR::PlatformWebView::windowSnapshotImage): Use the new UI-process path on GTK+.
595
596 2014-04-21  Sam Weinig  <sam@webkit.org>
597
598         Attempt to fix the tests.
599
600         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
601         (-[DidFailProvisionalNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
602         Add policy handler to override the new default of denying loads that NSURLConnection cannot handle.
603
604 2014-04-21  Filip Pizlo  <fpizlo@apple.com>
605
606         Unreviewed test gardening, make no-eager runs run everything except eager (as opposed to
607         being the same as a "quick run", which is meant for genuinely slow tests).
608
609         * Scripts/run-jsc-stress-tests:
610
611 2014-04-21  Darin Adler  <darin@apple.com>
612
613         Add HashSet::takeAny
614         https://bugs.webkit.org/show_bug.cgi?id=131928
615
616         Reviewed by Benjamin Poulain.
617
618         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Added a test for takeAny.
619
620 2014-04-20  Dan Bernstein  <mitz@apple.com>
621
622         Fixed a test timing out after r167572.
623
624         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
625         (-[NavigationDelegate webView:didFinishNavigation:]): Renamed from
626         -webView:didFinishLoadingNavigation:.
627
628 2014-04-20  Commit Queue  <commit-queue@webkit.org>
629
630         Unreviewed, rolling out r167510.
631         https://bugs.webkit.org/show_bug.cgi?id=131915
632
633         broke GTK Debug bot (Requested by philn on #webkit).
634
635         Reverted changeset:
636
637         "[GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force
638         it when running layout tests"
639         https://bugs.webkit.org/show_bug.cgi?id=131472
640         http://trac.webkit.org/changeset/167510
641
642 2014-04-18  Martin Robinson  <mrobinson@igalia.com>
643
644         [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
645         https://bugs.webkit.org/show_bug.cgi?id=131472
646
647         Reviewed by Philippe Normand.
648
649         * Scripts/webkitpy/port/gtk.py:
650         (GtkPort.setup_environ_for_server): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
651         when running WebKitTestRunner with run-webkit-tests.
652         * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
653         installed.
654         * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
655         how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
656         calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
657         deal.
658
659 2014-04-18  Alexey Proskuryakov  <ap@apple.com>
660
661         DownloadDecideDestinationCrash API test uses an incorrect value for path
662         https://bugs.webkit.org/show_bug.cgi?id=131845
663         <rdar://problem/15925560>
664
665         Reviewed by Enrica Casucci.
666
667         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
668         (TestWebKitAPI::decideDestinationWithSuggestedFilename):
669
670 2014-04-17  Alexey Proskuryakov  <ap@apple.com>
671
672         [Mac] AttributedStringTest API tests fail with async text input
673         https://bugs.webkit.org/show_bug.cgi?id=131833
674
675         Reviewed by Enrica Casucci.
676
677         Don't run sync NSTextInputClient tests where we don't implement these calls.
678
679         * TestWebKitAPI/Tests/mac/AttributedString.mm:
680         (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
681         (TestWebKitAPI::AttributedStringTest_CustomFont::runSyncTest):
682         (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
683         (TestWebKitAPI::AttributedStringTest_Strikethrough::runSyncTest):
684         (TestWebKitAPI::AttributedStringTest_CustomFont::runTest): Deleted.
685         (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest): Deleted.
686
687 2014-04-18  Philippe Normand  <pnormand@igalia.com>
688
689         Remove NETWORK_INFO support
690         https://bugs.webkit.org/show_bug.cgi?id=131841
691
692         Reviewed by Gyuyoung Kim.
693
694         * Scripts/webkitperl/FeatureList.pm:
695
696 2014-04-17  ChangSeok Oh  <changseok.oh@collabora.com>
697
698         [GTK] YouCompleteMe doesn't work for cmake build system.
699         https://bugs.webkit.org/show_bug.cgi?id=131591
700
701         Reviewed by Martin Robinson.
702
703         Add cmake build system support for YouCompleteMe. It should work regardless of
704         using make or ninja. In addition, autotools related code is removed since it's
705         not used anymore in WebKit.
706
707         * Scripts/webkitdirs.pm:
708         (generateBuildSystemFromCMakeProject):
709         * gtk/ycm_extra_conf.py:
710         (transform_relative_paths_to_absolute_paths):
711         (FlagsForFile):
712
713 2014-04-17  Anders Carlsson  <andersca@apple.com>
714
715         Fix build.
716
717         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
718         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
719         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
720
721 2014-04-17  Anders Carlsson  <andersca@apple.com>
722
723         Remove unused API enums
724         https://bugs.webkit.org/show_bug.cgi?id=131836
725
726         Reviewed by Tim Horton.
727
728         * MiniBrowser/mac/WK2BrowserWindowController.m:
729         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
730
731 2014-04-16  Brent Fulgham  <bfulgham@apple.com>
732
733         [Win] A few final cleanups to the DataObject classes.
734         https://bugs.webkit.org/show_bug.cgi?id=131784
735
736         Reviewed by Anders Carlsson.
737
738         * DumpRenderTree/win/DRTDataObject.cpp:
739         (DRTDataObject::clearData): Use 'last()' method.
740         * DumpRenderTree/win/UIDelegate.cpp:
741         (DRTUndoStack::pop): Use 'takeLast()' method.
742
743 2014-04-17  Andres Gomez  <agomez@igalia.com>
744
745         [Win] cygwin to keep installing curl 7.33.0-1 and subversion 1.7.14-1
746         https://bugs.webkit.org/show_bug.cgi?id=131365
747
748         Reviewed by Brent Fulgham.
749
750         The cygwin installer is now downloading the wanted versions for
751         the local installation given to the setup wizard.
752
753         * CygwinDownloader/cygwin-downloader.py:
754         * CygwinDownloader/cygwin-downloader.zip:
755
756 2014-04-17  Adrian Perez de Castro  <aperez@igalia.com>
757
758         [GTK] Make run-webkit-tests always use WKTR
759         https://bugs.webkit.org/show_bug.cgi?id=131737
760
761         Reviewed by Darin Adler.
762
763         Now that the GTK+ port only has support for WebKit2, instruct
764         run-webkit-tests to always use WKTR. This avoids needing to pass
765         flag "-2" every time.
766
767         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 
768         (_set_up_derived_options): Always set webkit_test_runner when
769         the platform is GTK+.
770
771 2014-04-17  Brendan Long  <b.long@cablelabs.com>
772
773         [Gtk] Install ninja-build in Tools/gtk/install-dependencies
774         https://bugs.webkit.org/show_bug.cgi?id=131760
775
776         Reviewed by Philippe Normand.
777
778         * gtk/install-dependencies: Install ninja-build when it's available.
779
780 2014-04-16  peavo@outlook.com  <peavo@outlook.com>
781
782         [Win] run-javascriptcore-tests fails to run.
783         https://bugs.webkit.org/show_bug.cgi?id=131761
784
785         Reviewed by Brent Fulgham.
786
787         * Scripts/build-jsc: For now, don't try to build bmalloc on Windows.
788
789 2014-04-16  Andres Gomez  <agomez@igalia.com>
790
791         [Win] Pass default parameters to cygwin setup wizard
792         https://bugs.webkit.org/show_bug.cgi?id=131361
793
794         Reviewed by Brent Fulgham.
795
796         Added some parameters to the cygwin setup wizard so the user
797         doesn't really have to do any interaction.
798
799         * CygwinDownloader/cygwin-downloader.py:
800         * CygwinDownloader/cygwin-downloader.zip:
801
802 2014-04-15  Brent Fulgham  <bfulgham@apple.com>
803
804         [Win] Eliminate use of deleteAllValues in Windows Files
805         https://bugs.webkit.org/show_bug.cgi?id=131631
806
807         Reviewed by Darin Adler.
808
809         Switch to std::unique_ptr for memory lifetime. Get rid of
810         deleteAllValues now that it is no longer needed. Use ranged
811         for loops where possible.
812
813         * DumpRenderTree/win/DRTDataObject.cpp:
814         (WCEnumFormatEtc::WCEnumFormatEtc):
815         (DRTDataObject::~DRTDataObject):
816         (DRTDataObject::GetData):
817         (DRTDataObject::QueryGetData):
818         (DRTDataObject::SetData):
819         (DRTDataObject::clearData):
820         * DumpRenderTree/win/DRTDataObject.h:
821         * DumpRenderTree/win/UIDelegate.cpp:
822         (DRTUndoObject::DRTUndoObject):
823         (DRTUndoObject::~DRTUndoObject):
824         (DRTUndoStack::~DRTUndoStack):
825         (DRTUndoStack::clear):
826         (DRTUndoStack::pop):
827         (DRTUndoManager::DRTUndoManager):
828         (DRTUndoManager::redo):
829         (DRTUndoManager::undo):
830         (UIDelegate::UIDelegate):
831         (UIDelegate::resetUndoManager):
832         * DumpRenderTree/win/UIDelegate.h:
833
834 2014-04-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
835
836         [GTK] Unreviewed GTK gardening.
837
838         Update list of skipped unit tests:
839
840           Skip test: WebKit2Gtk/TestWebKitWebView:/webkit2/WebKitWebView/page-visibility
841
842           Unskip tests: WebKit2/TestWebKit2:WebKit2.ResizeReversePaginatedWebView
843           and WebKit2/TestWebKit2:WebKit2.ScrollPinningBehaviors
844
845         * Scripts/run-gtk-tests:
846         (TestRunner):
847
848 2014-04-16  Tim Horton  <timothy_horton@apple.com>
849
850         check-webkit-style doesn't check code style in .mm or .m files
851         https://bugs.webkit.org/show_bug.cgi?id=131708
852
853         Reviewed by Darin Adler.
854
855         * Scripts/webkitpy/style/checker.py:
856         * Scripts/webkitpy/style/checker_unittest.py:
857         (CheckerDispatcherDispatchTest.test_cpp_paths):
858         (CheckerDispatcherDispatchTest.test_text_paths):
859         Check .mm and .m files as C++.
860
861         * Scripts/webkitpy/style/checkers/cpp.py:
862         (check_spacing):
863         Add an override for our ordinary "missing spaces around =" for @synthesize,
864         which should look like "@synthesize propertyName=_varName;"
865
866         Add an override for "missing space before {" for blocks' "^{".
867
868         Don't follow the "extra space before [" rule for Objective-C, because
869         it breaks this rule in a multitude of ways because of method calls.
870
871         (check_braces):
872         Don't complain about { not being on the end of the previous line if
873         the previous line starts with "- (" or "+ (", which would indicate a
874         Objective-C method definition.
875
876 2014-04-16  Darin Adler  <darin@apple.com>
877
878         Make Vector::takeLast work with move-only types (and optimize for types where move is faster)
879         https://bugs.webkit.org/show_bug.cgi?id=131735
880
881         Reviewed by Alexey Proskuryakov.
882
883         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added a test for Vector::takeLast with move only types.
884         Fixed invocations of EXPECT macros so the expected value is on the left, and the test result
885         is on the right. This can be confusing since our JavaScript test framework does it the opposite
886         way, but gtest works better this way.
887
888 2014-04-15  Hyowon Kim  <hw1008.kim@samsung.com>
889
890         [EFL] Fix problems with the pixel dump.
891         https://bugs.webkit.org/show_bug.cgi?id=131265
892
893         Reviewed by Gyuyoung Kim.
894
895         Painting and compositing paths of WebKit-EFL were totally modified from r166768.
896         However pixel dump codes still call deprecated functions like ewk_view_paint(),
897         which causes that nothing is drawn.
898
899         This patch adds new member functions to AcceleratedCompositingContext to support pixel dump.
900         One of new functions is AcceleratedCompositingContext::extractImageData(),
901         which replaces deprecated function calls. Besides the extractImageData() is invoked by
902         ewk_view_screenshot_contents_get() in order to take the visible content displayed on the EFL webview.
903
904         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
905         (createBitmapContextFromWebView): Add to call DumpRenderTreeSupportEfl::forcePaint().
906
907 2014-04-15  Filip Pizlo  <fpizlo@apple.com>
908
909         Update LLVM export scrpt to handle the build directory being different from the
910         source directory.
911
912         Rubber stamped by Geoffrey Garen.
913
914         * Scripts/export-llvm-build:
915
916 2014-04-15  Ryosuke Niwa  <rniwa@webkit.org>
917
918         Update the hyperlink to waterfall views of perf bots on build.webkit.org
919         https://bugs.webkit.org/show_bug.cgi?id=131695
920
921         Reviewed by Antti Koivisto.
922
923         Updated.
924
925         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
926
927 2014-04-15  Carlos Garcia Campos  <cgarcia@igalia.com>
928
929         [GTK] Reduce the binary size by compressing the text based web inspector resources
930         https://bugs.webkit.org/show_bug.cgi?id=121545
931
932         Reviewed by Gustavo Noronha Silva.
933
934         Compress text based files when compiling inspector resources. It
935         reduces the binary size in 3MB.
936
937         * gtk/generate-inspector-gresource-manifest.py:
938         (find_all_files_in_directory):
939         (is_compressible):
940
941 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
942
943         Remove Gtk WebKit1 tester.
944
945         Gtk WebKit1 port no longer exists, and dashboard was trying to load its tester
946         results over and over as fast as it could.
947
948         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
949         (WebKitBuildbot):
950
951 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
952
953         Wrong link for webkitpy tests results in dashboard popover
954         https://bugs.webkit.org/show_bug.cgi?id=131664
955
956         Reviewed by Timothy Hatcher.
957
958         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
959         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
960         Use a correct link.
961
962 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
963
964         Update webkitpy regression test result that started to fail after http://trac.webkit.org/r167243
965
966         I'm not sure whether the changes are desirable, but am not suspicious enough to roll out.
967
968         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
969         (CommitMessageForThisCommitTest):
970
971 2014-04-14  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
972
973         Fix commit-log-editor bug revealed by r165447
974         https://bugs.webkit.org/show_bug.cgi?id=130676
975
976         Reviewed by Csaba Osztrogonác.
977
978         * Scripts/commit-log-editor:
979         (createCommitMessage): Omitting empty Source/JavaScriptCore:... blocks.
980         Add \n before the first block too, because the longest common prefix now ends with only one newline.
981         (removeLongestCommonPrefixEndingInNewline): The longest common prefix ends with only one newline,
982         now the last block of the common prefix isn't duplicated below. Changing the function name accordingly.
983
984 2014-04-13  Darin Adler  <darin@apple.com>
985
986         userVisibleString should not try to "encode" host names
987         https://bugs.webkit.org/show_bug.cgi?id=131587
988         rdar://problem/14686849
989
990         Reviewed by Alexey Proskuryakov.
991
992         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added URLExtras.mm.
993
994         * TestWebKitAPI/Tests/mac/URLExtras.mm: Added. A few tests for WebCoreNSURLExtras.
995         Coverage is tiny at this point; we could add a lot more cases!
996
997 2014-04-13  Jaehun Lim  <ljaehun.lim@samsung.com>
998
999         Use #include instead of #import
1000         https://bugs.webkit.org/show_bug.cgi?id=131604
1001
1002         Reviewed by Darin Adler.
1003
1004         Fix "warning: #import is a deprecated GCC extension [-Wdeprecated]".
1005
1006         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1007
1008 2014-04-12  Filip Pizlo  <fpizlo@apple.com>
1009
1010         Make slow-stress tests run faster by running fewer VM variants.
1011
1012         Rubber stamped by Geoffrey Garen.
1013
1014         * Scripts/run-javascriptcore-tests:
1015         * Scripts/run-jsc-stress-tests:
1016
1017 2014-04-10  Zan Dobersek  <zdobersek@igalia.com>
1018
1019         [CMake] Add missing WTF unit tests
1020         https://bugs.webkit.org/show_bug.cgi?id=131459
1021
1022         Reviewed by Martin Robinson.
1023
1024         * TestWebKitAPI/CMakeLists.txt: Add a few missing source files
1025         that should be compiled into the TestWTF binary.
1026
1027 2014-04-10  Brendan Long  <b.long@cablelabs.com>
1028
1029         [Gtk] run-launcher doesn't work by default
1030         https://bugs.webkit.org/show_bug.cgi?id=131494
1031
1032         Reviewed by Philippe Normand.
1033
1034         * Scripts/run-launcher: Always use MiniBrowser for WebKitGTK.
1035         * Scripts/webkitdirs.pm:
1036         (launcherName): Same.
1037         * Scripts/webkitpy/style/checker.py: Remove reference to GtkLauncher.
1038         * gtk/common.py:
1039         (get_build_path.is_valid_build_directory): Same.
1040         * gtk/manifest.txt: Same.
1041
1042 2014-04-09  Commit Queue  <commit-queue@webkit.org>
1043
1044         Unreviewed, rolling out r167046.
1045         https://bugs.webkit.org/show_bug.cgi?id=131479
1046
1047         Caused 300+ failures on Mavericks WK1 tester (Requested by ap
1048         on #webkit).
1049
1050         Reverted changeset:
1051
1052         "Remove "System Font" from whitelisted DRT fonts and char
1053         width calculations"
1054         https://bugs.webkit.org/show_bug.cgi?id=131411
1055         http://trac.webkit.org/changeset/167046
1056
1057 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
1058
1059         Remove "System Font" from whitelisted DRT fonts and char width calculations
1060         https://bugs.webkit.org/show_bug.cgi?id=131411
1061
1062         Reviewed by Tim Horton.
1063
1064         Covered by existing tests.
1065
1066         * DumpRenderTree/mac/DumpRenderTree.mm:
1067         (allowedFontFamilySet):
1068
1069 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
1070
1071         systemHiddenFontFamilySet in DRT is unnecessary
1072         https://bugs.webkit.org/show_bug.cgi?id=131414
1073
1074         Reviewed by Tim Horton.
1075
1076         It doesn't seem to affect test results on my machine.
1077
1078         * DumpRenderTree/mac/DumpRenderTree.mm:
1079         (drt_NSFontManager_availableFonts):
1080         (systemHiddenFontFamilySet): Deleted.
1081
1082 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
1083
1084         [Win] Unreviewed test fix: Don't double-release BSTR.
1085
1086         * DumpRenderTree/win/DumpRenderTree.cpp:
1087         (dump): Remove unneeded call to SysFreeString now that we are
1088         using _bstr_t for this variable.
1089
1090 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
1091
1092         [Win] Various DumpRenderTree Fixes.
1093         https://bugs.webkit.org/show_bug.cgi?id=131446.
1094
1095         Reviewed by Tim Horton.
1096
1097         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1098         (AccessibilityUIElement::title): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1099         (AccessibilityUIElement::description): Ditto.
1100         (AccessibilityUIElement::helpText): Ditto.
1101         (AccessibilityUIElement::intValue): Ditto.
1102         (AccessibilityUIElement::isPressActionSupported): Ditto.
1103         (AccessibilityUIElement::accessibilityValue): Ditto.
1104         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1105         (DRTDesktopNotificationPresenter::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1106         (DRTDesktopNotificationPresenter::AddRef): Ditto.
1107         (DRTDesktopNotificationPresenter::Release): Ditto.
1108         (DRTDesktopNotificationPresenter::showDesktopNotification): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1109         (DRTDesktopNotificationPresenter::cancelDesktopNotification): Ditto.
1110         (DRTDesktopNotificationPresenter::notificationDestroyed): Ditto.
1111         (DRTDesktopNotificationPresenter::checkNotificationPermission): Ditto.
1112         (DRTDesktopNotificationPresenter::requestNotificationPermission): Ditto.
1113         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
1114         * DumpRenderTree/win/DumpRenderTree.cpp:
1115         (dumpFrameScrollPosition): Ditto.
1116         (dumpFramesAsText): Ditto.
1117         (compareHistoryItems): Ditto.
1118         (dumpHistoryItem): Ditto.
1119         (dump): Ditto.
1120         (resetDefaultsToConsistentValues): Ditto.
1121         (resetWebViewToConsistentStateBeforeTesting): Ditto.
1122         (runTest): Ditto.
1123         (createWebViewAndOffscreenWindow): Ditto.
1124         * DumpRenderTree/win/EditingDelegate.cpp:
1125         (EditingDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1126         (EditingDelegate::AddRef): Ditto.
1127         (EditingDelegate::Release): Ditto.
1128         (dumpPath): Switch to _bstr_t. Use JSStringCreateWithBSTR
1129         (EditingDelegate::shouldBeginEditingInDOMRange): Get rid of uneeded STDMETHODCALLTYPE declaration.
1130         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
1131         (EditingDelegate::shouldInsertNode): Ditto.
1132         (EditingDelegate::shouldInsertText): Ditto.
1133         (EditingDelegate::shouldDeleteDOMRange): Ditto.
1134         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
1135         (EditingDelegate::shouldApplyStyle): Ditto.
1136         (EditingDelegate::shouldChangeTypingStyle): Ditto.
1137         (EditingDelegate::doPlatformCommand): Ditto.
1138         (EditingDelegate::webViewDidBeginEditing): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1139         (EditingDelegate::webViewDidChange): Ditto.
1140         (EditingDelegate::webViewDidEndEditing): Ditto.
1141         (EditingDelegate::webViewDidChangeTypingStyle): Ditto.
1142         (EditingDelegate::webViewDidChangeSelection): Ditto.
1143         (EditingDelegate::checkSpellingOfString): Ditto.
1144         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1145         (descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1146         (FrameLoadDelegate::FrameLoadDelegate): Ditto.
1147         (FrameLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1148         (FrameLoadDelegate::AddRef): Ditto.
1149         (FrameLoadDelegate::Release): Ditto.
1150         (FrameLoadDelegate::didStartProvisionalLoadForFrame): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1151         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
1152         (FrameLoadDelegate::didFailProvisionalLoadWithError): Ditto.
1153         (FrameLoadDelegate::didCommitLoadForFrame): Ditto.
1154         (FrameLoadDelegate::didReceiveTitle): Ditto.
1155         (FrameLoadDelegate::didChangeIcons): Ditto.
1156         (delegatesWithDelayedWork): Ditto.
1157         (FrameLoadDelegate::didFinishLoadForFrame): Ditto.
1158         (FrameLoadDelegate::didFailLoadWithError): Ditto.
1159         (FrameLoadDelegate::willPerformClientRedirectToURL): Ditto.
1160         (FrameLoadDelegate::didCancelClientRedirectForFrame): Ditto.
1161         (FrameLoadDelegate::willCloseFrame): Ditto.
1162         (FrameLoadDelegate::didFinishDocumentLoadForFrame): Ditto.
1163         (FrameLoadDelegate::didHandleOnloadEventsForFrame): Ditto.
1164         (FrameLoadDelegate::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
1165         (FrameLoadDelegate::didDisplayInsecureContent): Ditto.
1166         (FrameLoadDelegate::didRunInsecureContent): Ditto.
1167         * DumpRenderTree/win/FrameLoadDelegate.h:
1168         * DumpRenderTree/win/HistoryDelegate.cpp:
1169         (HistoryDelegate::didNavigateWithNavigationData): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1170         (HistoryDelegate::updateHistoryTitle): Ditto.
1171         (HistoryDelegate::populateVisitedLinksForWebView): Ditto.
1172         * DumpRenderTree/win/PolicyDelegate.cpp:
1173         (dumpPath):
1174         (PolicyDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1175         (PolicyDelegate::AddRef): Ditto.
1176         (PolicyDelegate::Release): Ditto.
1177         (PolicyDelegate::decidePolicyForNavigationAction): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1178         (PolicyDelegate::unableToImplementPolicyWithError): Ditto.
1179         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1180         (ResourceLoadDelegate::descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1181         (ResourceLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1182         (ResourceLoadDelegate::AddRef): Ditto.
1183         (ResourceLoadDelegate::Release): Ditto.
1184         (ResourceLoadDelegate::identifierForInitialRequest): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1185         (ResourceLoadDelegate::removeIdentifierForRequest): Ditto.
1186         (ResourceLoadDelegate::willSendRequest): Ditto.
1187         (ResourceLoadDelegate::didReceiveAuthenticationChallenge): Ditto.
1188         (ResourceLoadDelegate::didReceiveResponse): Ditto.
1189         (ResourceLoadDelegate::didFinishLoadingFromDataSource): Ditto.
1190         (ResourceLoadDelegate::didFailLoadingWithError): Ditto.
1191         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
1192         (TestRunner::queueLoad): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1193         (TestRunner::setUserStyleSheetLocation): Ditto.
1194         (TestRunner::execCommand): Ditto.
1195         (TestRunner::overridePreference): Ditto.
1196         (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
1197         * DumpRenderTree/win/TextInputControllerWin.cpp: Ditto.
1198         (TextInputController::setMarkedText): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1199         (TextInputController::insertText): Ditto.
1200         * DumpRenderTree/win/UIDelegate.cpp:
1201         (UIDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1202         (UIDelegate::AddRef): Ditto.
1203         (UIDelegate::Release): Ditto.
1204         (UIDelegate::hasCustomMenuImplementation): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1205         (UIDelegate::trackCustomPopupMenu): Ditto.
1206         (UIDelegate::registerUndoWithTarget): Ditto.
1207         (UIDelegate::removeAllActionsWithTarget): Ditto.
1208         (UIDelegate::setActionTitle): Ditto.
1209         (UIDelegate::undo): Ditto.
1210         (UIDelegate::redo): Ditto.
1211         (UIDelegate::canUndo): Ditto.
1212         (UIDelegate::canRedo): Ditto.
1213         (UIDelegate::printFrame): Ditto.
1214         (UIDelegate::ftpDirectoryTemplatePath): Ditto.
1215         (UIDelegate::webViewHeaderHeight): Ditto.
1216         (UIDelegate::webViewFooterHeight): Ditto.
1217         (UIDelegate::drawHeaderInRect): Ditto.
1218         (UIDelegate::drawFooterInRect): Ditto.
1219         (UIDelegate::webViewPrintingMarginRect): Ditto.
1220         (UIDelegate::canRunModal): Ditto.
1221         (UIDelegate::createModalDialog): Ditto.
1222         (UIDelegate::runModal): Ditto.
1223         (UIDelegate::isMenuBarVisible): Ditto.
1224         (UIDelegate::setMenuBarVisible): Ditto.
1225         (UIDelegate::runDatabaseSizeLimitPrompt): Ditto.
1226         (UIDelegate::paintCustomScrollbar): Ditto.
1227         (UIDelegate::paintCustomScrollCorner): Ditto.
1228         (UIDelegate::setFrame): Ditto.
1229         (UIDelegate::webViewFrame): Ditto.
1230         (UIDelegate::runJavaScriptAlertPanelWithMessage): Ditto.
1231         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
1232         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
1233         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
1234         (UIDelegate::webViewAddMessageToConsole): Ditto.
1235         (UIDelegate::doDragDrop): Ditto.
1236         (UIDelegate::webViewGetDlgCode): Ditto.
1237         (UIDelegate::createWebViewWithRequest): Ditto.
1238         (UIDelegate::webViewClose): Ditto.
1239         (UIDelegate::webViewFocus): Ditto.
1240         (UIDelegate::webViewUnfocus): Ditto.
1241         (UIDelegate::webViewPainted): Ditto.
1242         (UIDelegate::exceededDatabaseQuota): Ditto.
1243         (UIDelegate::embeddedViewWithArguments): Ditto.
1244         (UIDelegate::webViewClosing): Ditto.
1245         (UIDelegate::webViewSetCursor): Ditto.
1246         (UIDelegate::webViewDidInvalidate): Ditto.
1247         (UIDelegate::setStatusText): Ditto.
1248         (UIDelegate::desktopNotificationsDelegate): Ditto.
1249         (UIDelegate::drawBackground): Ditto.
1250         (UIDelegate::decidePolicyForGeolocationRequest): Ditto.
1251         (UIDelegate::didPressMissingPluginButton): Ditto.
1252         * DumpRenderTree/win/WorkQueueItemWin.cpp: Ditto.
1253         (LoadItem::invoke):  Switch to _bstr_t. Use JSStringCreateWithBSTR.
1254         (LoadHTMLStringItem::invoke): Ditto.
1255         (ScriptItem::invoke): Ditto.
1256
1257 2014-04-09  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
1258
1259         Stylechecker: False positive on inline asm code.
1260         https://bugs.webkit.org/show_bug.cgi?id=130570
1261
1262         Reviewed by Csaba Osztrogonác.
1263
1264         Disable stylechecking in asm blocks.
1265
1266         * Scripts/webkitpy/style/checkers/cpp.py:
1267         (process_line):
1268         (_InlineASMState):
1269         (_InlineASMState.__init__):
1270         (_InlineASMState.process_line):
1271         (_InlineASMState.isInside):
1272         (_process_lines):
1273         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1274         (WebKitStyleTest.test_member_initialization_list):
1275
1276 2014-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1277
1278         [GTK] Move WebKit1 unit tests resources used by WebKit2 unit tests to WebKit2 resources dir
1279         https://bugs.webkit.org/show_bug.cgi?id=131029
1280
1281         Reviewed by Philippe Normand.
1282
1283         Add blank.ico and test.pdf to resources dir of WebKit2Gtk unit
1284         tests and remove the getWebKit1TestResoucesDir() method.
1285
1286         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1287         (testDownloadLocalFile): Use Test::getResourcesDir().
1288         (testDownloadLocalFileError): Ditto.
1289         (serverCallback): Ditto.
1290         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1291         (serverCallback): Ditto.
1292         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1293         (httpServerCallback): Ditto.
1294         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1295         (serverCallback): Ditto.
1296         * TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico: Added.
1297         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf: Added.
1298         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1299         (Test::getWebKit1TestResoucesDir): Deleted.
1300
1301 2014-04-09  Alexey Proskuryakov  <ap@apple.com>
1302
1303         [WK2] HTTP authentication regression tests fail
1304         https://bugs.webkit.org/show_bug.cgi?id=81627
1305         <rdar://problem/11079296>
1306
1307         Reviewed by Anders Carlsson.
1308
1309         * WebKitTestRunner/TestController.h:
1310         * WebKitTestRunner/TestController.cpp:
1311         (WTR::TestController::createWebViewWithOptions): Added canAuthenticateAgainstProtectionSpaceInFrame
1312         to pageLoaderClient structure.
1313         (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true
1314         for password based authentication (we do get server trust challenges on some tests,
1315         which WKTR can't handle).
1316         When this client call is not implemented or returns false, didReceiveAuthenticationChallengeInFrame
1317         calls won't be made, at least on CFNetwork based platforms.
1318         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Changed the output
1319         to omit <unknown>. The resource is always unknown with WK2, and it doesn't really
1320         make sense to associate auth requests with individual resources - there can be
1321         multiple resources loading at once from the same protection space, so WebKit1 API
1322         that had a resource identifier was inherently racy.
1323
1324 2014-04-09  Ryuan Choi  <ryuan.choi@samsung.com>
1325
1326         [EFL] Change font path for DumpRenderTree and WebKitTestRunner
1327         https://bugs.webkit.org/show_bug.cgi?id=131427
1328
1329         Reviewed by Gyuyoung Kim.
1330
1331         Since r166973, font path was changed.
1332
1333         * DumpRenderTree/PlatformEfl.cmake:
1334         * WebKitTestRunner/PlatformEfl.cmake:
1335
1336 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
1337
1338         Fix the build-jsc build
1339         https://bugs.webkit.org/show_bug.cgi?id=131410
1340
1341         Reviewed by Michael Saboff.
1342
1343         * Scripts/build-jsc: Make sure to build bmalloc before WTF, since
1344         WTF depends on it.
1345
1346 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
1347
1348         [GTK] Remove WebKit1 unit tests
1349         https://bugs.webkit.org/show_bug.cgi?id=131359
1350
1351         Reviewed by Anders Carlsson.
1352
1353         Remove all WebKit1 GTK+ unit tests, in preparation for removing the WebKit1 port
1354         entirely. We also remove the list of skipped WebKi1 tests from run-gtk-tests, as
1355         they were inadvertently left in http://trac.webkit.org/changeset/166504.
1356
1357         * CMakeLists.txt: No longer load the WebKit1 unit test CMakeLists.txt file.
1358         * Scripts/run-gtk-tests: Remove skipped WebKit1 unit tests.
1359         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Removed.
1360         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Removed.
1361         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Removed.
1362         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Removed.
1363         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Removed.
1364         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Removed.
1365         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Removed.
1366         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Removed.
1367         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Removed.
1368         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Removed.
1369         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Removed.
1370         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Removed.
1371         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Removed.
1372         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Removed.
1373         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Removed.
1374         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Removed.
1375         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Removed.
1376         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Removed.
1377         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Removed.
1378         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Removed.
1379         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Removed.
1380         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Removed.
1381         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Removed.
1382         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Removed.
1383         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Removed.
1384         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Removed.
1385         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Removed.
1386         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Removed.
1387         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Removed.
1388         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Removed.
1389         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Removed.
1390         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Removed.
1391         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Removed.
1392         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Removed.
1393         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Removed.
1394         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Removed.
1395
1396 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
1397
1398         Unreviewed gardening (Take 2): Prevent users from attempting
1399         to build with known invalid cURL. 
1400
1401         * Scripts/webkitdirs.pm:
1402         (checkInstalledTools): Check for 7.34.0 (the broken version), not
1403         7.33.0 (the known good version).
1404
1405 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
1406
1407         [GTK] Remove DumpRenderTree and GtkLauncher
1408         https://bugs.webkit.org/show_bug.cgi?id=131373
1409
1410         Reviewed by Andreas Kling.
1411
1412         Remove the GTK+ port of DumpRenderTree and GtkLauncher. These tools are
1413         no longer necessary now that WebKit1 GTK+ will be removed.
1414
1415         * CMakeLists.txt:
1416         * DumpRenderTree/PlatformGTK.cmake: Removed.
1417         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Removed.
1418         * DumpRenderTree/gtk/DumpRenderTree.cpp: Removed.
1419         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Removed.
1420         * DumpRenderTree/gtk/EditingCallbacks.cpp: Removed.
1421         * DumpRenderTree/gtk/EditingCallbacks.h: Removed.
1422         * DumpRenderTree/gtk/EventSender.cpp: Removed.
1423         * DumpRenderTree/gtk/EventSender.h: Removed.
1424         * DumpRenderTree/gtk/GCControllerGtk.cpp: Removed.
1425         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Removed.
1426         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Removed.
1427         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Removed.
1428         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Removed.
1429         * DumpRenderTree/gtk/TextInputController.cpp: Removed.
1430         * DumpRenderTree/gtk/TextInputController.h: Removed.
1431         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Removed.
1432         * GtkLauncher/CMakeLists.txt: Removed.
1433         * GtkLauncher/LauncherInspectorWindow.c: Removed.
1434         * GtkLauncher/LauncherInspectorWindow.h: Removed.
1435         * GtkLauncher/main.c: Removed.
1436         * GtkLauncher/simple.svg: Removed.
1437         * GtkLauncher/text.html: Removed.
1438         * WebKitTestRunner/PlatformGTK.cmake:
1439         * WebKitTestRunner/gtk/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/gtk/fonts/AHEM____.TTF.
1440         * WebKitTestRunner/gtk/fonts/FontWithNoValidEncoding.fon: Renamed from Tools/DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon.
1441         * WebKitTestRunner/gtk/fonts/fonts.conf: Renamed from Tools/DumpRenderTree/gtk/fonts/fonts.conf.
1442
1443 2014-04-08  Mark Rowe  <mrowe@apple.com>
1444
1445         XPC services launched by Safari have wrong DYLD_FRAMEWORK_PATH set when launched via run-safari / debug-safari
1446         <https://webkit.org/b/131388> / <rdar://problem/16291687>
1447
1448         Reviewed by Alexey Proskuryakov.
1449
1450         * Scripts/webkitdirs.pm:
1451         (runMacWebKitApp): Set __XPC_DYLD_FRAMEWORK_PATH to the absolute path to the built products directory.
1452         (execMacWebKitAppForDebugging): Ditto.
1453
1454 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
1455
1456         Build bmalloc on iOS too
1457         https://bugs.webkit.org/show_bug.cgi?id=131381
1458
1459         Reviewed by Andreas Kling.
1460
1461         * Scripts/build-webkit:
1462
1463 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
1464
1465         Unreviewed gardening: Prevent users from attempting
1466         to build with known invalid cURL.
1467
1468         * Scripts/webkitdirs.pm:
1469         (checkInstalledTools): Block build attempts with bad
1470         Cygwin tool set.
1471
1472 2014-04-07  Geoffrey Garen  <ggaren@apple.com>
1473
1474         Build bmalloc on Mac
1475         https://bugs.webkit.org/show_bug.cgi?id=131333
1476
1477         Reviewed by Mark Rowe.
1478
1479         * Scripts/build-webkit: Add the bmalloc target if we're on Mac.
1480         (Note: Just testing Mac is not good enough because in this
1481         script 'Mac' means 'Mac or iOS'.)
1482
1483 2014-03-30  Filip Pizlo  <fpizlo@apple.com>
1484
1485         Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running
1486         https://bugs.webkit.org/show_bug.cgi?id=130951
1487
1488         Reviewed by Geoffrey Garen.
1489
1490         * Scripts/run-javascriptcore-tests:
1491
1492 2014-04-06  Darin Adler  <darin@apple.com>
1493
1494         Rework CSS calc logic, fixing some reference count mistakes in Length
1495         https://bugs.webkit.org/show_bug.cgi?id=131280
1496
1497         Reviewed by Andreas Kling.
1498
1499         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added CalculationValue.cpp.
1500         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp: Added.
1501
1502 2014-04-04  Brian J. Burg  <burg@cs.washington.edu>
1503
1504         Enable WEB_REPLAY for PLATFORM(MAC)
1505         https://bugs.webkit.org/show_bug.cgi?id=130700
1506
1507         Reviewed by Timothy Hatcher.
1508
1509         * Scripts/webkitperl/FeatureList.pm: Set the default for WEB_REPLAY for OS X engineering builds.
1510
1511 2014-04-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1512
1513         [CMake] Include X11's include dirs in TestNetscapePlugin
1514         https://bugs.webkit.org/show_bug.cgi?id=131270
1515
1516         Reviewed by Martin Robinson.
1517
1518         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Include X11_INCLUDE_DIR since
1519         TestNetscapePlugin includes WebCore code that includes X headers.
1520
1521 2014-04-05  David Kilzer  <ddkilzer@apple.com>
1522
1523         REGRESSION (r166529): Fix build after renaming TileCache to LegacyTileCache
1524         <http://webkit.org/b/130986>
1525
1526         * Scripts/check-for-inappropriate-objc-class-names: Add 'Legacy'
1527         prefix to TileCache class names in exception list.
1528
1529 2014-04-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1530
1531         [GTK] kill-old-processes should kill dbus-daemon processes
1532         https://bugs.webkit.org/show_bug.cgi?id=127352
1533
1534         Reviewed by Martin Robinson.
1535
1536         * BuildSlaveSupport/kill-old-processes:
1537         (main):
1538
1539 2014-04-04  Andres Gomez  <agomez@igalia.com>
1540
1541         [Win] Update obsolete packages in cygwin
1542         https://bugs.webkit.org/show_bug.cgi?id=126264
1543
1544         Reviewed by Brent Fulgham.
1545
1546         Removed "apache" and "minires" as the first has been replaced by
1547         "lighttpd" and the second is now integrated into
1548         "cygwin". Replaced the transitional and now obsolete "gcc" package
1549         with "gcc-g++" and ensure that "python" stays at version "2.6.8"
1550         since the newer version available is "2.7.3" which breaks the
1551         build due to some funniness with environment variable handling.
1552
1553         * CygwinDownloader/cygwin-downloader.py:
1554         * CygwinDownloader/cygwin-downloader.zip:
1555
1556 2014-04-03  Joseph Pecoraro  <pecoraro@apple.com>
1557
1558         check-webkit-style: Improve warnings on Objective-C @property syntax
1559         https://bugs.webkit.org/show_bug.cgi?id=131200
1560
1561         Reviewed by Dan Bernstein.
1562
1563         * Scripts/webkitpy/style/checkers/cpp.py:
1564         (check_spacing):
1565         (CppChecker):
1566         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1567         (CppStyleTest.test_spacing_in_objective_c_properties):
1568
1569 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
1570
1571         Unreviewed. Moving my name to commiter section
1572
1573         * Scripts/webkitpy/common/config/contributors.json:
1574
1575 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
1576
1577         Unreviewed. Add myself as a committer.
1578
1579         * Scripts/webkitpy/common/config/contributors.json:
1580
1581 2014-04-03  Andrzej Badowski  <a.badowski@samsung.com>
1582
1583         [EFL][WK2] Replacing zoom functionality of MiniBrowser from scale_set to page_zoom_set.
1584         https://bugs.webkit.org/show_bug.cgi?id=130391
1585
1586         Reviewed by Gyuyoung Kim.
1587
1588         Change the implementation of the zoom functionality from ewk_view_scale_set
1589         to ewk_view_page_zoom_set.
1590
1591         * MiniBrowser/efl/main.c:
1592
1593 2014-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1594
1595         [webkitpy] perf profiler does not understand --call-graph argument
1596         https://bugs.webkit.org/show_bug.cgi?id=131132
1597
1598         Reviewed by Ryosuke Niwa.
1599
1600         New versions of perf profiler have changed the argument from --call-graph to -g.
1601
1602         * Scripts/webkitpy/common/system/profiler.py:
1603         (Perf.wrapper_arguments): Use -g instead of --call-graph.
1604         * Scripts/webkitpy/port/driver_unittest.py:
1605         (DriverTest.test_profiler_as_wrapper): Update test accordingly.
1606
1607 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1608
1609         Add EFL WK2 performance bot to build.webkit.org
1610         https://bugs.webkit.org/show_bug.cgi?id=131034
1611
1612         Fix after r166707, use "Perf" instead of "perf" for consistency.
1613
1614         Reviewed by Csaba Osztrogonác.
1615
1616         * BuildSlaveSupport/build.webkit.org-config/config.json:
1617
1618 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1619
1620         Add EFL WK2 performance bot to build.webkit.org
1621         https://bugs.webkit.org/show_bug.cgi?id=131034
1622
1623         Reviewed by Csaba Osztrogonác.
1624
1625         * BuildSlaveSupport/build.webkit.org-config/config.json:
1626
1627 2014-04-02  Ryuan Choi  <ryuan.choi@samsung.com>
1628
1629         [EFL][WK1] Use Evas_Touch_Point_State instead of Ewk_Touch_Point_Type
1630         https://bugs.webkit.org/show_bug.cgi?id=131151
1631
1632         Reviewed by Gyuyoung Kim.
1633
1634         * DumpRenderTree/efl/EventSender.cpp: Replace Ewk_Touch_Point_Type to Evas_Touch_Point_State.
1635         (TouchEventInfo::TouchEventInfo):
1636         (sendTouchEvent):
1637         (addTouchPointCallback):
1638         (updateTouchPointCallback):
1639         (cancelTouchPointCallback):
1640         (releaseTouchPointCallback):
1641
1642 2014-04-02  David Kilzer  <ddkilzer@apple.com>
1643
1644         filter-build-webkit: Ignore xcodebuild warnings when compiling with newer builds of clang
1645         <http://webkit.org/b/131045>
1646
1647         Reviewed by Daniel Bates.
1648
1649         * Scripts/filter-build-webkit:
1650         (shouldIgnoreLine): Ignore DVTAssertions related to new builds
1651         of clang, plus debug data for all DVTAssertions.
1652
1653 2014-04-01  Dean Jackson  <dino@apple.com>
1654
1655         Load Media Controls js/css from bundle
1656         https://bugs.webkit.org/show_bug.cgi?id=131086
1657
1658         Reviewed by Eric Carlson.
1659
1660         We're now putting CSS files into the bundle, so remove the test for them.
1661
1662         * Scripts/check-for-inappropriate-files-in-framework:
1663
1664 2014-04-02  Martin Hock  <mhock@apple.com>
1665
1666         Unify private browsing with sessions.
1667         https://bugs.webkit.org/show_bug.cgi?id=130099
1668
1669         Reviewed by Alexey Proskuryakov.
1670
1671         Add an API test for ephemeral sessions similar to PrivateBrowsingPushStateNoHistoryCallback.
1672         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1673         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
1674         (TestWebKitAPI::didNavigateWithNavigationData):
1675         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1676         (TestWebKitAPI::TEST):
1677
1678         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Also test to make sure private browsing can be disabled.
1679         (TestWebKitAPI::didNavigateWithoutNavigationData):
1680         (TestWebKitAPI::didNavigateWithNavigationData):
1681         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1682         (TestWebKitAPI::TEST):
1683
1684 2014-04-02  Martin Robinson  <mrobinson@igalia.com>
1685
1686         REGRESSION(r165704): [GTK] Inspector resources not correctly generated
1687         https://bugs.webkit.org/show_bug.cgi?id=130343
1688
1689         Reviewed by Gustavo Noronha Silva.
1690
1691         * gtk/generate-inspector-gresource-manifest.py: Instead of hard-coding the file list, accept a list
1692         of directories on the command line and look for all appropriate files in those directories for the
1693         GResource archive. Also make archive paths relative to those directories.
1694         (find_all_files_in_directory): This helper looks for all the appropriate files in a given directory.
1695         (find_all_files_in_directory.select_file): Whether or not to add the file to the archive.
1696
1697 2014-04-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1698
1699         [webkitpy] Avoid multiple "Preparing rollout for bug" log messages
1700         https://bugs.webkit.org/show_bug.cgi?id=131106
1701
1702         Reviewed by Csaba Osztrogonác.
1703
1704         * Scripts/webkitpy/tool/commands/download.py:
1705         (AbstractRolloutPrepCommand._prepare_state):
1706         * Scripts/webkitpy/tool/commands/download_unittest.py:
1707         (test_prepare_rollout):
1708         (test_create_rollout):
1709         (test_create_rollout_resolved):
1710         (test_rollout):
1711
1712 2014-04-02  Krzysztof Wolanski  <k.wolanski@samsung.com>
1713
1714         [EFL] Add option to use separate web process for new window in MiniBrowser
1715         https://bugs.webkit.org/show_bug.cgi?id=130190
1716
1717         Reviewed by Gyuyoung Kim.
1718
1719         New created window (CTRL + n) will be open in separated web process.
1720         This option is enabled by adding a flag (S/separate-process) with launching
1721         MiniBrowser.
1722
1723         * MiniBrowser/efl/main.c:
1724         (elm_main):
1725
1726 2014-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1727
1728         [GTK] Move NEWS file to a new location
1729         https://bugs.webkit.org/show_bug.cgi?id=130901
1730
1731         Reviewed by Brent Fulgham.
1732
1733         * gtk/manifest.txt: Update the NEWS file path.
1734
1735 2014-04-01  Anders Carlsson  <andersca@apple.com>
1736
1737         Fix build.
1738
1739         * MiniBrowser/mac/WK2BrowserWindowController.m:
1740         (-[WK2BrowserWindowController awakeFromNib]):
1741         (-[WK2BrowserWindowController dealloc]):
1742         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
1743
1744 2014-04-01  Brent Fulgham  <bfulgham@apple.com>
1745
1746         Unreviewed test gardening.
1747
1748         * Scripts/webkitpy/port/base_unittest.py:
1749         (PortTest.test_build_path): Handle the Debug case so we don't get webkitpy-test failures on our test bots.
1750
1751 2014-04-01  Zoltan Horvath  <zoltan@webkit.org>
1752
1753         [CSS Exclusions] Remove exclusions parsing support
1754         https://bugs.webkit.org/show_bug.cgi?id=131046
1755
1756         Reviewed by David Hyatt.
1757
1758         * Scripts/webkitperl/FeatureList.pm:
1759
1760 2014-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
1761
1762         [GTK] Remove last reference to GTK+ WK1 EWS
1763         https://bugs.webkit.org/show_bug.cgi?id=131058
1764
1765         Reviewed by Martin Robinson.
1766
1767         In r166427 WK1 GTK+ bots and EWS where removed, but this file was missing.
1768
1769         * QueueStatusServer/config/queues.py: Remove reference to GTK+ WK1 EWS.
1770
1771 2014-04-01  Lucas Forschler  <lforschler@apple.com>
1772
1773         Add a 32bit JSC builder/tester.
1774         https://bugs.webkit.org/show_bug.cgi?id=131054
1775         
1776         Reviewed by Michael Saboff.
1777
1778         * BuildSlaveSupport/build.webkit.org-config/config.json:
1779         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1780         (Compile32bitJSC):
1781         (Run32bitJSCTests):
1782         (Run32bitJSCTests.countFailures):
1783         (BuildAndTest32bitJSCFactory):
1784         (BuildAndTest32bitJSCFactory.__init__):
1785
1786 2014-04-01  Martin Robinson  <mrobinson@igalia.com>
1787
1788         [GTK] No longer build WebKit1 gtkdoc
1789         https://bugs.webkit.org/show_bug.cgi?id=130970
1790
1791         Reviewed by Anders Carlsson.
1792
1793         * gtk/common.py:
1794         (gtk_version_of_pkg_config_file): Deleted.
1795         * gtk/generate-gtkdoc:
1796         (get_gtkdoc_module_paths): We no longer need to worry about GTK+ 2, since it
1797         was only applicable for WebKit1.
1798         (get_generator_for_config): No longer look for the WebKit1 configuration file.
1799
1800 2014-04-01  Mario Sanchez Prada  <mario.prada@samsung.com>
1801
1802         [GTK] Running minibrowser with url crashes in debug build
1803         https://bugs.webkit.org/show_bug.cgi?id=130492
1804
1805         Reviewed by Martin Robinson.
1806
1807         Update "uri-scheme" test not to use invalid URIs in it, so we
1808         don't get a mistmatch when comparing the original URI stored in
1809         the test class with the one returned by the WebKitWebView.
1810
1811         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1812         (testWebContextURIScheme): Update the test.
1813
1814 2014-04-01  Mihai Tica  <mitica@adobe.com>
1815
1816         Unreviewed: Add myself as a commiter to the contributors list.
1817
1818         * Scripts/webkitpy/common/config/contributors.json:
1819
1820 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
1821
1822         [EFL][WK2] Extract the control of page background out of color_set
1823         https://bugs.webkit.org/show_bug.cgi?id=127539
1824
1825         Reviewed by Gyuyoung Kim.
1826
1827         Added an option(C) to change background color.
1828
1829         * MiniBrowser/efl/main.c:
1830         (window_create):
1831         (elm_main):
1832
1833 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
1834
1835         Unreviewed build fix on the EFL port with latest EFL libraries since r166149
1836
1837         * ImageDiff/PlatformEfl.cmake: Added ECORE_IMF_INCLUDE_DIRS to include dirs
1838
1839 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
1840
1841         Unreviewed test correction after r166530.
1842
1843         * DumpRenderTree/mac/DumpRenderTree.mm:
1844         (setDefaultsToConsistentValuesForTesting): No need to change preference for all tests. We set the proper
1845         fine-grained setting for swipe tests. This prevents existing tests from breaking.
1846
1847 2014-03-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1848
1849         Remove the trigger for webkit1 tests on the gtk-linux-64-release bot
1850         https://bugs.webkit.org/show_bug.cgi?id=130987
1851
1852         r166427 removed the WebKit1 GTK+ bots, so we don't longer need to
1853         trigger the webkit1 bot tests on the gtk-linux-64-release bot.
1854
1855         Reviewed by Martin Robinson.
1856
1857         * BuildSlaveSupport/build.webkit.org-config/config.json:
1858
1859 2014-03-31  Dean Jackson  <dino@apple.com>
1860
1861         Remove WEB_ANIMATIONS
1862         https://bugs.webkit.org/show_bug.cgi?id=130989
1863
1864         Reviewed by Simon Fraser.
1865
1866         Remove this feature flag until we plan to implement.
1867
1868         * Scripts/webkitperl/FeatureList.pm:
1869
1870 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
1871
1872         Reduced Latched Scroll Test Flakiness
1873         https://bugs.webkit.org/show_bug.cgi?id=130983
1874
1875         Reviewed by Darin Adler.
1876
1877         * DumpRenderTree/mac/DumpRenderTree.mm:
1878         (setDefaultsToConsistentValuesForTesting): Test user should have 'high resolution' scrolling.
1879         * DumpRenderTree/mac/EventSendingController.mm:
1880         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Generate mouse wheel events
1881         with high resolution flags turned on.
1882         * WebKitTestRunner/mac/EventSenderProxy.mm:
1883         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
1884
1885 2014-03-31  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1886
1887         run-webkit-tests should have a --no-timeout option
1888         https://bugs.webkit.org/show_bug.cgi?id=128286
1889
1890         Reviewed by Joseph Pecoraro.
1891
1892         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1893         (Worker._run_test): Renaming _run_test_with_timeout()
1894         (Worker._run_test_with_or_without_timeout): Renaming _run_test_with_timeout(), because tests can now run without timeout.
1895         (Worker._run_test_in_another_thread): Passing the --no-timeout option to the driver
1896         (Worker._run_test_in_this_thread):
1897         (Worker._run_test_with_timeout): Deleted.
1898         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1899         (parse_args): Added the --no-timeout option
1900
1901 2014-03-31  Samuel White  <samuel_white@apple.com>
1902
1903         AX: Need ability to get line range for text marker.
1904         https://bugs.webkit.org/show_bug.cgi?id=130906
1905
1906         Reviewed by Chris Fleizach.
1907
1908         Added a new function in DRT and TestRunner to test that AXLineTextMarkerRangeForTextMarker works as expected.
1909
1910         * DumpRenderTree/AccessibilityUIElement.cpp:
1911         (lineTextMarkerRangeForTextMarkerCallback):
1912         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1913         (AccessibilityUIElement::getJSClass):
1914         * DumpRenderTree/AccessibilityUIElement.h:
1915         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1916         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1917         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1918         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1919         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1920         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1921         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1922         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1923         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1924         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1925         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1926         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1927
1928 2014-03-31  Filip Pizlo  <fpizlo@apple.com>
1929
1930         More validation for FTL inline caches
1931         https://bugs.webkit.org/show_bug.cgi?id=130948
1932
1933         Reviewed by Geoffrey Garen.
1934
1935         * Scripts/run-jsc-stress-tests:
1936
1937 2014-03-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1938
1939         [GTK] Do not run WebKit1 unit tests by default
1940         https://bugs.webkit.org/show_bug.cgi?id=130968
1941
1942         Reviewed by Martin Robinson.
1943
1944         * Scripts/run-gtk-tests:
1945         (TestRunner):
1946
1947 2014-03-31  Martin Robinson  <mrobinson@igalia.com>
1948
1949         [GTK] Remove scripts code only applicable to autotools
1950         https://bugs.webkit.org/show_bug.cgi?id=130841
1951
1952         Reviewed by Anders Carlsson.
1953
1954         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1955         (_should_file_trigger_build): Update file list to reflect GTK+ CMake port.
1956         * Scripts/webkitpy/common/config/watchlist: Remove the GTK+ build watchlist.
1957         * Scripts/webkitpy/style/checker.py: The GNUmakefile doesn't exist any longer.
1958         * gtk/find-make-dist-errors: Removed.
1959         * gtk/generate-feature-defines-files: Removed.
1960         * gtk/manifest.txt: No longer need to consider autotools files.
1961
1962 2014-03-30  Andy Estes  <aestes@apple.com>
1963
1964         Fix two failing layout tests on Mountain Lion after r166466.
1965
1966         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1967         (-[DownloadDelegate _downloadDidStart:]):
1968
1969 2014-03-30  Andy Estes  <aestes@apple.com>
1970
1971         [Cocoa] Add an originatingWebView property to _WKDownload
1972         https://bugs.webkit.org/show_bug.cgi?id=130945
1973
1974         Reviewed by Anders Carlsson.
1975
1976         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1977         (-[DownloadDelegate _downloadDidStart:]):
1978         (-[OriginatingWebViewDownloadDelegate initWithWebView:]):
1979         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
1980         (TEST):
1981
1982 2014-03-28  Filip Pizlo  <fpizlo@apple.com>
1983
1984         Land the stackmap register liveness glue with the uses of the liveness disabled
1985         https://bugs.webkit.org/show_bug.cgi?id=130924
1986
1987         Reviewed by Oliver Hunt.
1988
1989         * Scripts/run-jsc-stress-tests:
1990
1991 2014-03-29  Alexey Proskuryakov  <ap@apple.com>
1992
1993         Update WebKit1.StringTruncator for Mountain Lion.
1994
1995         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Looks like one subtest was failing
1996         due to different font metrics on 10.8.
1997
1998 2014-03-28  Darin Adler  <darin@apple.com>
1999
2000         Fix recently-introduced off-by-one error in centerTruncateToBuffer
2001         https://bugs.webkit.org/show_bug.cgi?id=130889
2002
2003         Reviewed by Alexey Proskuryakov.
2004
2005         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringTruncator.mm.
2006         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Added. One test for each of the
2007         WebStringTruncator methods; should be good for a start. These are dependent on the
2008         metrics of Helvetica 12, but I am hoping that will be consistent across OS X machines.
2009
2010 2014-03-28  Martin Hock  <mhock@apple.com>
2011
2012         Unreviewed. Add myself as a committer.
2013
2014         * Scripts/webkitpy/common/config/contributors.json:
2015
2016 2014-03-28  Martin Robinson  <mrobinson@igalia.com>
2017
2018         Remove WebKit1 GTK+ bots
2019         https://bugs.webkit.org/show_bug.cgi?id=130904
2020
2021         Reviewed by Anders Carlsson.
2022
2023         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove references to GTK+ WebKit1 test bot and ensure
2024         all bots are testing WebKit2 only.
2025         * Scripts/webkitpy/common/config/ews.json: Remove references to GTK+ WK1 EWS.
2026         * Scripts/webkitpy/common/config/ports.py: Remove references to GTK+ WK1 bots.
2027         * Scripts/webkitpy/common/config/ports_unittest.py: Ditto.
2028         * Scripts/webkitpy/port/builders.py: Ditto.
2029         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
2030         * TestResultServer/static-dashboards/builders.jsonp: Ditto.
2031
2032 2014-03-28  Timothy Hatcher  <timothy@apple.com>
2033
2034         Remove Brian Burg's apple.com email address.
2035
2036         * Scripts/webkitpy/common/config/contributors.json:
2037
2038 2014-03-28  David Kilzer  <ddkilzer@apple.com>
2039
2040         bisect-builds should print Trac 'changeset' URL if only one build is detected
2041         <http://webkit.org/b/130903>
2042
2043         Reviewed by Dan Bernstein.
2044
2045         * Scripts/bisect-builds:
2046         (printTracLink): Print a direct link to the Trac 'changeset'
2047         URL if there is only one revision in the range.
2048
2049 2014-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2050
2051         [EFL] Bump glib version from 2.36 to 2.38 
2052         https://bugs.webkit.org/show_bug.cgi?id=130886
2053
2054         Reviewed by Csaba Osztrogonác.
2055
2056         There is a build break on EFL port when using glib 2.36 ver. To fix it,
2057         we need to bump glib version up to 2.38 as gtk port.
2058
2059         * efl/jhbuild.modules:
2060
2061 2014-03-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2062
2063         <https://webkit.org/b/42704> WebKitTestRunner needs to print history delegate information
2064
2065         Provide an implementation of WKContextHistoryClient that logs when called for tests in
2066         the globalhistory directory.
2067
2068         Reviewed by Sam Weinig.
2069
2070         * WebKitTestRunner/TestController.cpp:
2071         (WTR::TestController::TestController):
2072         (WTR::TestController::initialize): Set the history client.
2073         (WTR::TestController::resetStateToConsistentValues): Disable logging of history client callbacks.
2074         (WTR::TestController::didNavigateWithNavigationData): Log information about the navigation. Some portions
2075         of the output are hard-coded to match WebKit1's results for now since they're fixed in our existing tests
2076         and we don't yet have API to access the data in question.
2077         (WTR::TestController::didPerformClientRedirect):
2078         (WTR::TestController::didPerformServerRedirect):
2079         (WTR::TestController::didUpdateHistoryTitle):
2080         * WebKitTestRunner/TestController.h:
2081         (WTR::TestController::setShouldLogHistoryClientCallbacks):
2082         * WebKitTestRunner/TestInvocation.cpp:
2083         (WTR::shouldLogHistoryClientCallbacks): Log history client callbacks for tests in a globalhistory directory.
2084         (WTR::TestInvocation::invoke):
2085
2086 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
2087
2088         Revert http://trac.webkit.org/changeset/166386 because it broke builds.
2089
2090         * Scripts/build-webkit:
2091         * Scripts/copy-webkitlibraries-to-product-directory:
2092
2093 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
2094
2095         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
2096         https://bugs.webkit.org/show_bug.cgi?id=130867
2097         <rdar://problem/16432456> 
2098
2099         Reviewed by Mark Hahnenberg.
2100
2101         * Scripts/build-webkit:
2102         * Scripts/copy-webkitlibraries-to-product-directory:
2103
2104 2014-03-26  Andy Estes  <aestes@apple.com>
2105
2106         [Cocoa] Expose DownloadClient::didFail() and DownloadClient::didCancel()
2107         https://bugs.webkit.org/show_bug.cgi?id=130805
2108
2109         Reviewed by Dan Bernstein.
2110
2111         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2112         (-[DownloadDelegate _download:didReceiveResponse:]):
2113         (-[DownloadDelegate _downloadDidFinish:]):
2114         (runTest):
2115         (TEST):
2116         (-[FailingDownloadDelegate _downloadDidFinish:]):
2117         (-[FailingDownloadDelegate _download:didFailWithError:]):
2118         (-[FailingDownloadDelegate _downloadDidCancel:]):
2119         (-[CancelledDownloadDelegate _downloadDidStart:]):
2120         (-[CancelledDownloadDelegate _downloadDidFinish:]):
2121         (-[CancelledDownloadDelegate _download:didFailWithError:]):
2122         (-[CancelledDownloadDelegate _downloadDidCancel:]):
2123         (-[DownloadDelegate initWithSourceURL:]): Deleted.
2124         (-[DownloadDelegate sourceURL]): Deleted.
2125         (runTestWithNavigationDelegate): Deleted.
2126
2127 2014-03-26  Anders Carlsson  <andersca@apple.com>
2128
2129         Change MiniBrowser to hold on to window controllers instead of windows
2130         https://bugs.webkit.org/show_bug.cgi?id=130797
2131
2132         Reviewed by Oliver Hunt.
2133
2134         * MiniBrowser/mac/AppDelegate.h:
2135         * MiniBrowser/mac/AppDelegate.m:
2136         (-[BrowserAppDelegate init]):
2137         (-[BrowserAppDelegate newWindow:]):
2138         (-[BrowserAppDelegate browserWindowWillClose:]):
2139         (-[BrowserAppDelegate applicationWillTerminate:]):
2140         (-[BrowserAppDelegate frontmostBrowserWindowController]):
2141
2142 2014-03-26  Commit Queue  <commit-queue@webkit.org>
2143
2144         Unreviewed, rolling out r166264.
2145         https://bugs.webkit.org/show_bug.cgi?id=130785
2146
2147         Broke some window.opener tests for WK2 Mavericks (Requested by
2148         brrian__ on #webkit).
2149
2150         Reverted changeset:
2151
2152         "Web Replay: resource unique identifiers should be unique-per-
2153         frame, not globally"
2154         https://bugs.webkit.org/show_bug.cgi?id=130632
2155         http://trac.webkit.org/changeset/166264
2156
2157 2014-03-26  Zoltan Horvath  <zoltan@webkit.org>
2158
2159         [CSS Shapes] Remove shape-inside support
2160         https://bugs.webkit.org/show_bug.cgi?id=130698
2161
2162         Reviewed by David Hyatt.
2163
2164         * Scripts/webkitperl/FeatureList.pm:
2165
2166 2014-02-27  Gurpreet Kaur  <k.gurpreet@samsung.com>
2167
2168         Unreviewed. Add myself as a committer.
2169
2170         * Scripts/webkitpy/common/config/contributors.json:
2171
2172 2014-03-26  Tomas Popela  <tpopela@redhat.com>
2173
2174         run-launcher is Perl script so use elsif and not elif
2175         https://bugs.webkit.org/show_bug.cgi?id=130771
2176
2177         Reviewed by Carlos Garcia Campos.
2178
2179         * Scripts/run-launcher:
2180
2181 2014-03-26  Krzysztof Czech  <k.czech@samsung.com>
2182
2183         [ATK] Utilize new AtkValue interface coming in ATK 2.11.92
2184         https://bugs.webkit.org/show_bug.cgi?id=130575
2185
2186         Reviewed by Mario Sanchez Prada.
2187
2188         Change ATK version to 2.11.92. Adjust current implementation.
2189
2190         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2191         (AccessibilityUIElement::intValue):
2192         (AccessibilityUIElement::minValue):
2193         (AccessibilityUIElement::maxValue):
2194         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2195         (WTR::AccessibilityUIElement::intValue):
2196         (WTR::AccessibilityUIElement::minValue):
2197         (WTR::AccessibilityUIElement::maxValue):
2198         * efl/jhbuild.modules:
2199         * gtk/jhbuild.modules:
2200
2201 2014-03-12  Philippe Normand  <pnormand@igalia.com>
2202
2203         [GTK] The gnumake package is no longer needed in jhbuild
2204         https://bugs.webkit.org/show_bug.cgi?id=130121
2205
2206         Reviewed by Martin Robinson.
2207
2208         For GTK build-webkit now relies on cmake and ninja/gnumake. Even
2209         for a debug build cmake/system-gnumake worked just fine for me.
2210
2211         * gtk/jhbuild.modules: Removed gnumake.
2212         * gtk/patches/make-3.82-arg-list-length.patch: Removed.
2213         * gtk/patches/make-3.82-parallel-build.patch: Removed.
2214
2215 2014-03-25  Andy Estes  <aestes@apple.com>
2216
2217         Fix a failing API test on Mountain Lion and remove temporary debug logging.
2218
2219         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2220         (-[DownloadDelegate _download:didReceiveData:]):
2221         (-[DownloadDelegate _downloadDidFinish:]):
2222
2223 2014-03-25  Brian Burg  <bburg@apple.com>
2224
2225         Web Replay: resource unique identifiers should be unique-per-frame, not globally
2226         https://bugs.webkit.org/show_bug.cgi?id=130623
2227
2228         Reviewed by Timothy Hatcher.
2229
2230         The resource loader callback dumping routines assumed that resource identifiers
2231         were globally unique. Its map of resource identifiers to URLs must also track the
2232         frame associated with the resource.
2233
2234         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2235         (WTR::dumpResourceURL): Additionally take a WKBundleFrameRef argument, and use the
2236         opaque pointer as part of the key for assignedUrlsCache. The frame pointer is
2237         stable as long as the frame is valid.
2238         (WTR::InjectedBundlePage::didInitiateLoadForResource):
2239         (WTR::InjectedBundlePage::willSendRequestForFrame):
2240         (WTR::InjectedBundlePage::didReceiveResponseForResource):
2241         (WTR::InjectedBundlePage::didFinishLoadForResource):
2242         (WTR::InjectedBundlePage::didFailLoadForResource):
2243
2244 2014-03-25  Andy Estes  <aestes@apple.com>
2245
2246         Fix one API test expectation failure on Mountain Lion, and add additional logging to help diagnose another.
2247
2248         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2249         (-[DownloadDelegate _download:didReceiveResponse:]):
2250         (-[DownloadDelegate _download:didReceiveData:]):
2251
2252 2014-03-25  Andy Estes  <aestes@apple.com>
2253
2254         Add some debug logging to an API test that's failing on Mountain Lion.
2255
2256         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2257         (-[DownloadDelegate _download:didReceiveResponse:]):
2258         (-[DownloadDelegate _downloadDidFinish:]):
2259
2260 2014-03-25  Anders Carlsson  <andersca@apple.com>
2261
2262         Add goBack: and goForward: IBActions and move stopLoading: to a new WKIBActions category on WKWebView
2263         https://bugs.webkit.org/show_bug.cgi?id=130732
2264
2265         Reviewed by Tim Horton.
2266
2267         * MiniBrowser/mac/WK2BrowserWindowController.m:
2268         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
2269
2270 2014-03-25  Martin Robinson  <mrobinson@igalia.com>
2271
2272         [GTK] Remove the autotools build
2273         https://bugs.webkit.org/show_bug.cgi?id=130717
2274
2275         Reviewed by Anders Carlsson.
2276
2277         * DumpRenderTree/config.h: Remove references to the autotools configure file.
2278         * GNUmakefile.am: Removed.
2279         * GtkLauncher/GNUmakefile.am: Removed.
2280         * GtkLauncher/main.c: Remove references to the autotools configure file.
2281         * MiniBrowser/gtk/BrowserDownloadsBar.c: Ditto.
2282         * MiniBrowser/gtk/BrowserSearchBar.c: Ditto.
2283         * MiniBrowser/gtk/BrowserWindow.c: Ditto.
2284         * MiniBrowser/gtk/GNUmakefile.am: Removed.
2285         * MiniBrowser/gtk/main.c: Remove references to the autotools configure file.
2286         * Scripts/build-webkit: No longer handle autotools.
2287         * Scripts/run-gtk-tests: Ditto.
2288         (TestRunner._setup_testing_environment):
2289         * Scripts/run-launcher: Ditto.
2290         * Scripts/webkitdirs.pm: Ditto.
2291         * Scripts/webkitpy/common/config/contributionareas.py: Remove autotools as a contribution area.
2292         * Scripts/webkitpy/common/config/contributors.json: Ditto.
2293         * Scripts/webkitpy/port/gtk.py: No longer handle autotools.
2294         * Scripts/webkitpy/style/checker.py:
2295         * TestWebKitAPI/GNUmakefile.am: Removed.
2296         * TestWebKitAPI/config.h: Remove references to the autotools configure file.
2297         * WebKitTestRunner/GNUmakefile.am: Removed.
2298         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Ditto.
2299         * gtk/GNUmakefile.am: Removed.
2300         * gtk/common.py: Remove checks for the autotools build.
2301         * gtk/symbols.filter: Renamed from Source/autotools/symbols.filter.
2302
2303 2014-03-25  László Langó  <llango.u-szeged@partner.samsung.com>
2304
2305         prepare-ChangeLog throws false positive warnings for modified files.
2306         https://bugs.webkit.org/show_bug.cgi?id=130687
2307
2308         Reviewed by Darin Adler.
2309
2310         * Scripts/prepare-ChangeLog:
2311         (originalFile): Ignore git commit paremeter.
2312         We don't need this to get the unmodified file.
2313         (extractLineRangeBeforeChange):
2314         Simplify the if statement. Follow-up after r166189.
2315
2316 2014-03-25  Gabor Rapcsanyi  <rgabor@webkit.org>
2317
2318         [EFL] Add ARM64 build support
2319         https://bugs.webkit.org/show_bug.cgi?id=130506
2320
2321         Rubber stamped by Gyuyoung Kim.
2322
2323         * Scripts/webkitdirs.pm:
2324         (isARM): Detect aarch64 as ARM.
2325
2326 2014-03-25  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2327
2328         [webkitpy] Improve _parse_bug_description to recognize more descriptions
2329         https://bugs.webkit.org/show_bug.cgi?id=130137
2330
2331         Reviewed by Csaba Osztrogonác.
2332
2333         * Scripts/webkitpy/common/checkout/changelog.py:
2334         (ChangeLogEntry._parse_bug_description):
2335         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2336         (test_parse_log_entries_from_changelog):
2337         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2338         (CheckoutTest.test_commit_info_for_revision):
2339
2340 2014-03-24  Andy Estes  <aestes@apple.com>
2341
2342         Fix the iOS build of TestWebKitAPI.
2343
2344         * TestWebKitAPI/Configurations/Base.xcconfig:
2345         * TestWebKitAPI/PlatformUtilities.h:
2346
2347 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
2348
2349         Fix prepare-ChangeLog after r166156.
2350         https://bugs.webkit.org/show_bug.cgi?id=130674
2351
2352         Reviewed by Darin Adler.
2353
2354         * Scripts/prepare-ChangeLog:
2355         (generateFunctionLists):
2356         (extractLineRangeBeforeChange):
2357
2358 2014-03-24  Andy Estes  <aestes@apple.com>
2359
2360         [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
2361         https://bugs.webkit.org/show_bug.cgi?id=129322
2362
2363         Reviewed by Anders Carlsson.
2364
2365         Add an API test suite for _WKDownload.
2366
2367         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2368         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Added.
2369         (-[DownloadDelegate initWithSourceURL:]):
2370         (-[DownloadDelegate sourceURL]):
2371         (-[DownloadDelegate _downloadDidStart:]):
2372         (-[DownloadDelegate _download:didReceiveResponse:]):
2373         (-[DownloadDelegate _download:didReceiveData:]):
2374         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
2375         (-[DownloadDelegate _downloadDidFinish:]):
2376         (TEST):
2377         (runTestWithNavigationDelegate):
2378         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2379         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2380
2381 2014-03-24  Joseph Pecoraro  <pecoraro@apple.com>
2382
2383         filter-build-webkit: reduce unfiltered output
2384         https://bugs.webkit.org/show_bug.cgi?id=130485
2385
2386         Reviewed by Brent Fulgham.
2387
2388         * Scripts/filter-build-webkit:
2389         (shouldIgnoreLine):
2390
2391 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
2392
2393         prepare-ChangeLog should list functions that have been removed too.
2394         https://bugs.webkit.org/show_bug.cgi?id=130508
2395
2396         Reviewed by Darin Adler.
2397
2398         The prepare-ChangeLog does not list the deleted functions in the Changelog.
2399         We have to read the functions and the line ranges of them from the source
2400         before the change, then search for overlaps between them and the changed
2401         line ranges from diff.
2402
2403         * Scripts/prepare-ChangeLog:
2404         (originalFile): Get original source command.
2405         (generateFunctionLists): Collect deleted functions too.
2406         (generateFunctionListsByRanges): Duplicated code is moved to a separate subroutine.
2407         (extractLineRangeBeforeChange): Extract line ranges from the original source to get
2408         deleted functions ranges too.
2409         (extractLineRange): Renamed to extractLineRangeAfterChange.
2410
2411 2014-03-23  Hyowon Kim  <hw1008.kim@samsung.com>
2412
2413         Move all EFL typedefs into EflTypedefs.h.
2414         https://bugs.webkit.org/show_bug.cgi?id=130511
2415
2416         Reviewed by Gyuyoung Kim.
2417
2418         * TestWebKitAPI/PlatformWebView.h: Remove EFL typedefs.
2419         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
2420         * WebKitTestRunner/PlatformWebView.h: Ditto.
2421
2422 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
2423
2424         Don't flush compositing layers within FrameView::willPaintContents()
2425         https://bugs.webkit.org/show_bug.cgi?id=130627
2426         <rdar://problem/16368869>
2427
2428         Reviewed by Sam Weinig.
2429         
2430         Fix DRT to correctly render tests with layers now that FrameView::paintContents
2431         does not flush.
2432         
2433         Move the -[WebView displayIfNeeded] from -[FrameLoadDelegate webView:didFinishLoadForFrame:]
2434         into an explicit function called before dumping. 
2435         
2436         Then explicitly call _flushCompositingChanges to ensure that GraphicsLayer changes
2437         are flushed to CA. They will be pushed to the window by snapshotting.
2438
2439         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2440         Fix weird path to IOKit.framework.
2441         * DumpRenderTree/mac/DumpRenderTree.mm:
2442         (updateDisplay):
2443         (dump):
2444         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2445         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): Fix parameter name.
2446         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Remove display call.
2447
2448 2014-03-21  David Kilzer  <ddkilzer@apple.com>
2449
2450         fix-blink-patch: tool to fix up renamed directory paths in Blink
2451         <http://webkit.org/b/130609>
2452
2453         Reviewed by Ryosuke Niwa.
2454
2455         Usage: cat blink.patch | fix-blink-patch | svn-apply
2456
2457         * Scripts/fix-blink-patch: Added.
2458
2459 2014-03-21  Darin Adler  <darin@apple.com>
2460
2461         Remove use of deprecatedCharacters in WebKit API tests
2462         https://bugs.webkit.org/show_bug.cgi?id=130602
2463
2464         Reviewed by Antti Koivisto.
2465
2466         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2467         (TestWebKitAPI::expectBuilderContent): Use characters8/16 instead of deprecatedCharacters.
2468         (TestWebKitAPI::expectEmpty): Use characters8.
2469         (TestWebKitAPI::TEST): Use characters8 instead of deprecatedCharacters in most cases.
2470
2471         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2472         Removed the test that is entirely about 16-bit conversion since that's basically a test of
2473         the deprecatedCharacters function itself, which we are about to delete.
2474
2475 2014-03-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2476
2477         [webkitpy] Fix has_valid_reviewer()
2478         https://bugs.webkit.org/show_bug.cgi?id=130589
2479
2480         Reviewed by Csaba Osztrogonác.
2481
2482         * Scripts/webkitpy/common/checkout/changelog.py:
2483         (ChangeLogEntry.has_valid_reviewer):
2484         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2485         (test_has_valid_reviewer):
2486         * Scripts/webkitpy/common/config/committers.py:
2487         (CommitterList._reviewer_only):
2488         (CommitterList.committer_by_name):
2489         (CommitterList.reviewer_by_email):
2490         (CommitterList):
2491         (CommitterList.reviewer_by_name):
2492
2493 2014-03-21  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
2494
2495         Add cache support for jhbuild
2496         https://bugs.webkit.org/show_bug.cgi?id=130588
2497
2498         Reviewed by Csaba Osztrogonác.
2499
2500         * jhbuild/jhbuildrc_common.py:
2501         (init): Jhbuild can now save the dependencies locally, if the JHBUILD_MIRROR environment variable is set.
2502
2503 2014-03-21  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2504
2505         [CMake] Add support for MAX_CPU_LOAD translated to -l in ninja and make
2506         https://bugs.webkit.org/show_bug.cgi?id=130504
2507
2508         Reviewed by Martin Robinson.
2509
2510         * Scripts/build-webkit: Add the maxCPULoad() to the makeArgs in
2511         CMake if not specified.
2512         * Scripts/webkitdirs.pm:
2513         (determineMaxCPULoad): Read MAX_CPU_LOAD as maxCPULoad.
2514         (maxCPULoad): determineMaxCPULoad and return maxCPULoad.
2515
2516 2014-03-21  Andreas Kling  <akling@apple.com>
2517
2518         RetainPtr API test should use CFArray instead of CFString for testing.
2519         <rdar://problem/16384899>
2520
2521         Unreviewed bot fix.
2522
2523         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
2524         (TestWebKitAPI::TEST):
2525         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
2526         (TestWebKitAPI::TEST):
2527
2528 2014-03-20  Hyowon Kim  <hw1008.kim@samsung.com>
2529
2530         Move to using std::unique_ptr for EFL objects.
2531         https://bugs.webkit.org/show_bug.cgi?id=129853
2532
2533         Reviewed by Gyuyoung Kim.
2534
2535         EflUniquePtr is a template alias of std::unique_ptr
2536         with a custom deleter for each Efl Objects, which is motivated by GUniquePtr.
2537         This patch replaces uses of OwnPtr and PassOwnPtr for Efl objects with EflUniquePtr.
2538
2539         * DumpRenderTree/efl/DumpRenderTree.cpp:
2540         (main):
2541         * ImageDiff/efl/ImageDiff.cpp:
2542         (initEfl):
2543         (main):
2544
2545 2014-03-20  Ryuan Choi  <ryuan.choi@samsung.com>
2546
2547         Unreviewed buildfix after r165983 for non Cocoa platforms
2548
2549         Renamed WKPreferencesPrivate.h to WKPreferencesRefPrivate.h
2550
2551         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
2552         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2553         * WebKitTestRunner/TestController.cpp:
2554
2555 2014-03-20  Zan Dobersek  <zdobersek@igalia.com>
2556
2557         [GTK][CMake] Add support for building with Clang
2558         https://bugs.webkit.org/show_bug.cgi?id=130260
2559
2560         Reviewed by Martin Robinson.
2561
2562         * TestWebKitAPI/CMakeLists.txt: When building with Clang TestWebKitAPI should be
2563         built with GTEST_HAS_TR1_TUPLE defined to 0 to avoid build failures occuring in the
2564         included GTest framework headers.
2565         * gtk/generate-gtkdoc:
2566         (prepare_environment_for_gtkdoc_generation): Don't modify the CFLAGS env anymore
2567         in case of using Clang since that is now set by the CMake rule.
2568
2569 2014-03-19  Simon Fraser  <simon.fraser@apple.com>
2570
2571         Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser
2572         https://bugs.webkit.org/show_bug.cgi?id=130476
2573
2574         Reviewed by Anders Carlsson.
2575         
2576         Hook up page/text zoom in MiniBrowser, make reload work, remove some logging.
2577
2578         * MiniBrowser/mac/WK1BrowserWindowController.m:
2579         (-[WK1BrowserWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2580         Remove log.
2581         * MiniBrowser/mac/WK2BrowserWindowController.m:
2582         (-[WK2BrowserWindowController awakeFromNib]):
2583         (-[WK2BrowserWindowController validateMenuItem:]):
2584         (-[WK2BrowserWindowController reload:]):
2585         Hook up reload.
2586         (-[WK2BrowserWindowController toggleZoomMode:]):
2587         (-[WK2BrowserWindowController resetZoom:]):
2588         (-[WK2BrowserWindowController canResetZoom]):
2589         (-[WK2BrowserWindowController currentZoomFactor]):
2590         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
2591         (-[WK2BrowserWindowController canZoomIn]):
2592         (-[WK2BrowserWindowController canZoomOut]):
2593
2594 2014-03-19  Alexey Proskuryakov  <ap@apple.com>
2595
2596         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
2597         https://bugs.webkit.org/show_bug.cgi?id=130463
2598
2599         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Disable the test.
2600
2601 2014-03-18  Samuel White  <samuel_white@apple.com>
2602
2603         AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
2604         https://bugs.webkit.org/show_bug.cgi?id=130250
2605
2606         Reviewed by Chris Fleizach.
2607
2608         Added ability to toggle enhanced accessibility on and off to support tests that require it.
2609
2610         * DumpRenderTree/AccessibilityController.cpp:
2611         (enableEnhancedAccessibilityCallback):
2612         (getEnhancedAccessibilityEnabledCallback):
2613         (AccessibilityController::getJSClass):
2614         * DumpRenderTree/AccessibilityController.h:
2615         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
2616         (AccessibilityController::enableEnhancedAccessibility):
2617         (AccessibilityController::enhancedAccessibilityEnabled):
2618         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2619         (AccessibilityController::enableEnhancedAccessibility):
2620         (AccessibilityController::enhancedAccessibilityEnabled):
2621         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2622         (AccessibilityController::enableEnhancedAccessibility):
2623         (AccessibilityController::enhancedAccessibilityEnabled):
2624         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2625         (AccessibilityController::enableEnhancedAccessibility):
2626         (AccessibilityController::enhancedAccessibilityEnabled):
2627         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2628         (WTR::AccessibilityController::enableEnhancedAccessibility):
2629         (WTR::AccessibilityController::enhancedAccessibilityEnabled):
2630         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2631         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2632
2633 2014-03-18  Filip Pizlo  <fpizlo@apple.com>
2634
2635         Unreviewed, add some contributors, and fix Nadav's entry (he's not really a reviewer
2636         yet).
2637
2638         * Scripts/webkitpy/common/config/contributors.json:
2639
2640 2014-03-18  Joseph Pecoraro  <pecoraro@apple.com>
2641
2642         Web Inspector: Remove stale ReportMemoryUsagePlugin
2643         https://bugs.webkit.org/show_bug.cgi?id=130405
2644
2645         Reviewed by Andreas Kling.
2646
2647         This clang plugin looks like it was used for the old Inspector memory
2648         instrumentation that was removed. So the tool can be removed.
2649
2650         * clang/ReportMemoryUsagePlugin/CMakeLists.txt: Removed.
2651         * clang/ReportMemoryUsagePlugin/Makefile: Removed.
2652         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Removed.
2653         * clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Removed.
2654
2655 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2656
2657         webkit-patch land shouldn't add a reviewer for unreviewed build fixes
2658         https://bugs.webkit.org/show_bug.cgi?id=130220
2659
2660         Reviewed by Csaba Osztrogonác.
2661
2662         * Scripts/webkitpy/common/checkout/changelog.py:
2663         (ChangeLog.set_reviewer):
2664         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2665         (test_set_reviewer):
2666
2667 2014-03-17  Filip Pizlo  <fpizlo@apple.com>
2668
2669         More FTL enabling.
2670
2671         Rubber stamped by Dan Bernstein.
2672
2673         * Tools/Scripts/build-webkit:
2674
2675 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2676
2677         Renable pagination mode in WK2 MiniBrowser
2678         https://bugs.webkit.org/show_bug.cgi?id=130374
2679
2680         Reviewed by Anders Carlsson.
2681         
2682         Put the implementation of togglePaginationMode: back, and correctly
2683         enable the menu item.
2684
2685         * MiniBrowser/mac/WK2BrowserWindowController.m:
2686         (-[WK2BrowserWindowController validateMenuItem:]):
2687         (-[WK2BrowserWindowController isPaginated]):
2688         (-[WK2BrowserWindowController togglePaginationMode:]):
2689
2690 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2691
2692         Add --reset option to Tools/Scripts/set-webkit-configuration script
2693         https://bugs.webkit.org/show_bug.cgi?id=130401
2694
2695         Reviewed by Csaba Osztrogonác.
2696
2697         * Scripts/set-webkit-configuration:
2698
2699 2014-03-18  Alberto Garcia  <berto@igalia.com>
2700
2701         [GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
2702         https://bugs.webkit.org/show_bug.cgi?id=130388
2703
2704         Reviewed by Sergio Villar Senin.
2705
2706         * Scripts/webkitdirs.pm:
2707         (shouldRemoveCMakeCache): make sure that the build directory
2708         exists before attempting to create a file in it.
2709
2710 2014-03-18  Robert Plociennik  <r.plociennik@samsung.com>
2711
2712         [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
2713         https://bugs.webkit.org/show_bug.cgi?id=130336
2714
2715         Reviewed by Gyuyoung Kim.
2716
2717         Compilation with gcc 4.8.x results in 'invalid suffix on literal; C++11
2718         requires a space between literal and string macro [-Wliteral-suffix]'
2719         warning treated as error.
2720
2721         This patch applies a solution from r162448 to the EFL port.
2722
2723         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
2724         * efl/jhbuild.modules: Added appropriate patch section.
2725
2726 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
2727
2728         webkitpy test rebaseline.
2729
2730         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2731         (MainTest.test_default_args):
2732
2733 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
2734
2735         --profile should imply --test-runner-count=1 in run-perf-tests
2736         https://bugs.webkit.org/show_bug.cgi?id=130375
2737
2738         Reviewed by Benjamin Poulain.
2739
2740         Use the test runner count of 1 when --profile is specified but not --test-runner-count.
2741
2742         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2743         (PerfTestsRunner._parse_args): Use -1 as the default value.
2744         (PerfTestsRunner._collect_tests): If --test-runner-count is set (i.e. it's a positive value),
2745         then use that value. Otherwise, if it's never set and --profile is present, test-runner-count
2746         should be 1.
2747
2748 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2749
2750         Address some style nits.
2751
2752         * MiniBrowser/mac/WK2BrowserWindowController.m:
2753
2754 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2755
2756         Add transparent window support back into MiniBrowser
2757         https://bugs.webkit.org/show_bug.cgi?id=130363
2758
2759         Reviewed by Anders Carlsson.
2760         
2761         Re-enable transparent window support for WK2.
2762
2763         * MiniBrowser/mac/WK2BrowserWindowController.m:
2764         (-[WK2BrowserWindowController validateMenuItem:]):
2765         (-[WK2BrowserWindowController toggleTransparentWindow:]):
2766
2767 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2768
2769         Fix the 32-bit build; make the open panel make a WK1 window.
2770
2771         * MiniBrowser/mac/AppDelegate.m:
2772         (-[BrowserAppDelegate openDocument:]):
2773
2774 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2775
2776         Convert MiniBrowser to use WKWebView API
2777         https://bugs.webkit.org/show_bug.cgi?id=130061
2778
2779         Reviewed by Anders Carlsson.
2780         
2781         Convert the MiniBrowser WK2 window to use WebKit2 API as much
2782         as possible.
2783         
2784         Some functionality was removed temporarily:
2785             - text zoom, page zoom
2786             - reload
2787             - pagination mode
2788             - transparent window
2789             - dumping source
2790             - window.open support
2791             - beforeUnload panel
2792             - find in page
2793
2794         * MiniBrowser/mac/AppDelegate.h:
2795         * MiniBrowser/mac/AppDelegate.m:
2796         (-[BrowserAppDelegate init]):
2797         (-[BrowserAppDelegate newWindow:]):
2798         (-[BrowserAppDelegate applicationWillTerminate:]):
2799         (-[BrowserAppDelegate openDocument:]):
2800         * MiniBrowser/mac/WK2BrowserWindowController.h:
2801         * MiniBrowser/mac/WK2BrowserWindowController.m:
2802         (-[WK2BrowserWindowController awakeFromNib]):
2803         (-[WK2BrowserWindowController dealloc]):
2804         (-[WK2BrowserWindowController fetch:]):
2805         (-[WK2BrowserWindowController validateMenuItem:]):
2806         (-[WK2BrowserWindowController reload:]):
2807         (-[WK2BrowserWindowController goBack:]):
2808         (-[WK2BrowserWindowController goForward:]):
2809         (-[WK2BrowserWindowController toggleZoomMode:]):
2810         (-[WK2BrowserWindowController resetZoom:]):
2811         (-[WK2BrowserWindowController canResetZoom]):
2812         (-[WK2BrowserWindowController dumpSourceToConsole:]):
2813         (-[WK2BrowserWindowController togglePaginationMode:]):
2814         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
2815         (-[WK2BrowserWindowController windowShouldClose:]):
2816         (-[WK2BrowserWindowController applicationTerminating]):
2817         (-[WK2BrowserWindowController currentZoomFactor]):
2818         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
2819         (-[WK2BrowserWindowController toggleTransparentWindow:]):
2820         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
2821         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2822         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2823         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
2824         (-[WK2BrowserWindowController find:]):
2825         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
2826         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
2827         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
2828         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
2829         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
2830         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
2831         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
2832         * WebKitTestRunner/PlatformWebView.h:
2833         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2834         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2835
2836 2014-03-17  Zan Dobersek  <zdobersek@igalia.com>
2837
2838         Use RunLoop objects through references instead of pointers
2839         https://bugs.webkit.org/show_bug.cgi?id=130313
2840
2841         Reviewed by Andreas Kling.
2842
2843         Adjust the code accordingly now that RunLoop::current() and RunLoop::main()
2844         return RunLoop reference instead of a pointer.
2845
2846         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
2847         (loadedCallback):
2848         (clickedCallback):
2849
2850 2014-03-17  Tim Horton  <timothy_horton@apple.com>
2851
2852         sort-export-file --help doesn't work (missing 'use')
2853         https://bugs.webkit.org/show_bug.cgi?id=130338
2854
2855         Reviewed by Anders Carlsson.
2856
2857         * Scripts/sort-export-file:
2858         Add a missing 'use', and fix a typo in an error message.
2859
2860 2014-03-17  Martin Robinson  <mrobinson@igalia.com>
2861
2862         [GTK][CMake] Ensure that HAVE_GTK_UNIX_PRINTING is defined when appropriate
2863         https://bugs.webkit.org/show_bug.cgi?id=130155
2864
2865         Reviewed by Philippe Normand.
2866
2867         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add GTK_UNIX_PRINT flags to the build.
2868
2869 2014-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2870
2871         [GTK] MiniBrowser fails to load injected bundle lib
2872         https://bugs.webkit.org/show_bug.cgi?id=130332
2873
2874         Reviewed by Anders Carlsson.
2875
2876         This is because WEBKIT_INJECTED_BUNDLE_PATH env var is set too late.
2877
2878         * MiniBrowser/gtk/main.c:
2879         (main): Make sure WEBKIT_INJECTED_BUNDLE_PATH is set before a web
2880         process is spawn.
2881
2882 2014-03-16  Kim Byung Jun  <bj1987.kim@samsung.com>
2883
2884         [EFL] Enable TOUCH_SLIDER macro
2885         https://bugs.webkit.org/show_bug.cgi?id=130185
2886
2887         Reviewed by Gyuyoung Kim.
2888
2889         * Scripts/webkitperl/FeatureList.pm:
2890
2891 2014-03-16  Zan Dobersek  <zdobersek@igalia.com>
2892
2893         [GTK][CMake] Build with -fno-rtti
2894         https://bugs.webkit.org/show_bug.cgi?id=130261
2895
2896         Reviewed by Martin Robinson.
2897
2898         * TestWebKitAPI/CMakeLists.txt: Build TestWebKitAPI with GTEST_HAS_RTTI macro
2899         defined to 0 to prevent typeid use in included GTest headers.
2900
2901 2014-03-16  Brian Burg  <bburg@apple.com>
2902
2903         Web Inspector: vended backend commands file should be generated as part of the build
2904         https://bugs.webkit.org/show_bug.cgi?id=130110
2905
2906         Reviewed by Timothy Hatcher.
2907
2908         * Scripts/build-webkit: build WebInspectorUI after WebCore but before WebKit.
2909
2910 2014-03-16  Diego Pino García  <dpino@igalia.com>
2911
2912         [GTK] Minibrowser: Add shortcuts for reloading page and reloading page ignoring cache
2913         https://bugs.webkit.org/show_bug.cgi?id=128999
2914
2915         Reviewed by Philippe Normand.
2916
2917         * MiniBrowser/gtk/BrowserWindow.c:
2918         (reloadPage):
2919         (reloadPageIgnoringCache):
2920         (browser_window_init):
2921
2922 2014-03-15  Martin Robinson  <mrobinson@igalia.com>
2923
2924         [GTK] Improve ninja detection in webkitdirs.pm
2925         https://bugs.webkit.org/show_bug.cgi?id=129902
2926
2927         Reviewed by Daniel Bates.
2928
2929         * Scripts/webkitdirs.pm:
2930         (canUseNinja): Use which instead of trying to invoke ninja directly. This also allows
2931         us to look for ninja-build as well.
2932
2933 2014-03-14  Maciej Stachowiak  <mjs@apple.com>
2934
2935         Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers
2936         https://bugs.webkit.org/show_bug.cgi?id=130276
2937         <rdar://problem/16266927>
2938         
2939         Reviewed by Simon Fraser.
2940
2941         * BuildSlaveSupport/build-launcher-app:
2942         * BuildSlaveSupport/build-launcher-dmg:
2943         * DumpRenderTree/DumpRenderTree.h:
2944         * DumpRenderTree/DumpRenderTreePrefix.h:
2945         * DumpRenderTree/GCController.cpp:
2946         * DumpRenderTree/GCController.h:
2947         * DumpRenderTree/JavaScriptThreading.cpp:
2948         * DumpRenderTree/JavaScriptThreading.h:
2949         * DumpRenderTree/PixelDumpSupport.cpp:
2950         * DumpRenderTree/PixelDumpSupport.h:
2951         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
2952         * DumpRenderTree/TestRunner.cpp:
2953         * DumpRenderTree/TestRunner.h:
2954         * DumpRenderTree/WorkQueue.cpp:
2955         * DumpRenderTree/WorkQueue.h:
2956         * DumpRenderTree/WorkQueueItem.h:
2957         * DumpRenderTree/atk/AccessibilityCallbacks.h:
2958         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
2959         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
2960         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
2961         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2962         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2963         * DumpRenderTree/efl/EditingCallbacks.cpp:
2964         * DumpRenderTree/efl/EditingCallbacks.h:
2965         * DumpRenderTree/efl/EventSender.cpp:
2966         * DumpRenderTree/efl/EventSender.h:
2967         * DumpRenderTree/efl/GCControllerEfl.cpp:
2968         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
2969         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2970         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2971         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
2972         * DumpRenderTree/gtk/EditingCallbacks.cpp:
2973         * DumpRenderTree/gtk/EditingCallbacks.h:
2974         * DumpRenderTree/gtk/EventSender.cpp:
2975         * DumpRenderTree/gtk/EventSender.h:
2976         * DumpRenderTree/gtk/GCControllerGtk.cpp:
2977         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
2978         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
2979         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h:
2980         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2981         * DumpRenderTree/gtk/TextInputController.cpp:
2982         * DumpRenderTree/gtk/TextInputController.h:
2983         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL:
2984         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
2985         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2986         * DumpRenderTree/mac/AppleScriptController.h:
2987         * DumpRenderTree/mac/AppleScriptController.m:
2988         * DumpRenderTree/mac/CheckedMalloc.cpp:
2989         * DumpRenderTree/mac/CheckedMalloc.h:
2990         * DumpRenderTree/mac/DumpRenderTree.mm:
2991         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
2992         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2993         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2994         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
2995         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2996         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2997         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2998         * DumpRenderTree/mac/EditingDelegate.h:
2999         * DumpRenderTree/mac/EditingDelegate.mm:
3000         * DumpRenderTree/mac/EventSendingController.h:
3001         * DumpRenderTree/mac/EventSendingController.mm:
3002         * DumpRenderTree/mac/FrameLoadDelegate.h:
3003         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3004         * DumpRenderTree/mac/GCControllerMac.mm:
3005         * DumpRenderTree/mac/MockWebNotificationProvider.h:
3006         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
3007         * DumpRenderTree/mac/NavigationController.h:
3008         * DumpRenderTree/mac/NavigationController.m:
3009         * DumpRenderTree/mac/ObjCController.h:
3010         * DumpRenderTree/mac/ObjCController.m:
3011         * DumpRenderTree/mac/ObjCPlugin.h:
3012         * DumpRenderTree/mac/ObjCPlugin.m:
3013         * DumpRenderTree/mac/ObjCPluginFunction.h:
3014         * DumpRenderTree/mac/ObjCPluginFunction.m:
3015         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3016         * DumpRenderTree/mac/PolicyDelegate.h:
3017         * DumpRenderTree/mac/PolicyDelegate.mm:
3018         * DumpRenderTree/mac/ResourceLoadDelegate.h:
3019         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3020         * DumpRenderTree/mac/TestRunnerMac.mm:
3021         * DumpRenderTree/mac/TextInputController.h:
3022         * DumpRenderTree/mac/TextInputController.m:
3023         * DumpRenderTree/mac/UIDelegate.h:
3024         * DumpRenderTree/mac/UIDelegate.mm:
3025         * DumpRenderTree/mac/WorkQueueItemMac.mm:
3026         * DumpRenderTree/win/DRTDataObject.cpp:
3027         * DumpRenderTree/win/DRTDataObject.h:
3028         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
3029         * DumpRenderTree/win/DRTDropSource.cpp:
3030         * DumpRenderTree/win/DRTDropSource.h:
3031         * DumpRenderTree/win/DraggingInfo.h:
3032         * DumpRenderTree/win/DumpRenderTree.cpp:
3033         * DumpRenderTree/win/DumpRenderTreeWin.h:
3034         * DumpRenderTree/win/EditingDelegate.cpp:
3035         * DumpRenderTree/win/EditingDelegate.h:
3036         * DumpRenderTree/win/EventSender.cpp:
3037         * DumpRenderTree/win/EventSender.h:
3038         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3039         * DumpRenderTree/win/FrameLoadDelegate.h:
3040         * DumpRenderTree/win/GCControllerWin.cpp:
3041         * DumpRenderTree/win/HistoryDelegate.cpp:
3042         * DumpRenderTree/win/HistoryDelegate.h:
3043         * DumpRenderTree/win/MD5.cpp:
3044         * DumpRenderTree/win/MD5.h:
3045         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3046         * DumpRenderTree/win/PolicyDelegate.cpp:
3047         * DumpRenderTree/win/PolicyDelegate.h:
3048         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3049         * DumpRenderTree/win/ResourceLoadDelegate.h:
3050         * DumpRenderTree/win/TestRunnerWin.cpp:
3051         * DumpRenderTree/win/TextInputController.cpp:
3052         * DumpRenderTree/win/TextInputController.h:
3053         * DumpRenderTree/win/TextInputControllerWin.cpp:
3054         * DumpRenderTree/win/UIDelegate.cpp:
3055         * DumpRenderTree/win/UIDelegate.h:
3056         * DumpRenderTree/win/WorkQueueItemWin.cpp:
3057         * EWebLauncher/main.c:
3058         * GtkLauncher/main.c:
3059         * ImageDiff/efl/ImageDiff.cpp:
3060         * ImageDiff/gtk/ImageDiff.cpp:
3061         * MiniBrowser/gtk/main.c:
3062         * Scripts/SpacingHeuristics.pm:
3063         * Scripts/VCSUtils.pm:
3064         * Scripts/bisect-builds:
3065         * Scripts/build-dumprendertree:
3066         * Scripts/build-jsc:
3067         * Scripts/build-webkit:
3068         * Scripts/check-dom-results:
3069         * Scripts/check-for-exit-time-destructors:
3070         * Scripts/check-for-global-initializers:
3071         * Scripts/commit-log-editor:
3072         * Scripts/compare-timing-files:
3073         * Scripts/debug-minibrowser:
3074         * Scripts/debug-safari:
3075         * Scripts/do-file-rename:
3076         * Scripts/find-extra-includes:
3077         * Scripts/generate-coverage-data:
3078         * Scripts/make-script-test-wrappers:
3079         * Scripts/malloc-tree:
3080         * Scripts/old-run-webkit-tests:
3081         * Scripts/parse-malloc-history:
3082         * Scripts/report-include-statistics:
3083         * Scripts/resolve-ChangeLogs:
3084         * Scripts/run-bindings-tests:
3085         * Scripts/run-iexploder-tests:
3086         * Scripts/run-javascriptcore-tests:
3087         * Scripts/run-jsc:
3088         * Scripts/run-launcher:
3089         * Scripts/run-leaks:
3090         * Scripts/run-mangleme-tests:
3091         * Scripts/run-minibrowser:
3092         * Scripts/run-pageloadtest:
3093         * Scripts/run-regexp-tests:
3094         * Scripts/run-safari:
3095         * Scripts/run-sunspider:
3096         * Scripts/run-webkit-app:
3097         * Scripts/sampstat:
3098         * Scripts/set-webkit-configuration:
3099         * Scripts/sort-Xcode-project-file:
3100         * Scripts/sort-export-file:
3101         * Scripts/split-file-by-class:
3102         * Scripts/sunspider-compare-results:
3103         * Scripts/svn-apply:
3104         * Scripts/svn-create-patch:
3105         * Scripts/svn-unapply:
3106         * Scripts/test-webkit-scripts:
3107         * Scripts/update-javascriptcore-test-results:
3108         * Scripts/update-webkit:
3109         * Scripts/update-webkit-auxiliary-libs:
3110         * Scripts/update-webkit-dependency:
3111         * Scripts/update-webkit-localizable-strings:
3112         * Scripts/update-webkit-support-libs:
3113         * Scripts/update-webkit-wincairo-libs:
3114         * Scripts/webkit-build-directory:
3115         * Scripts/webkitdirs.pm:
3116         (installedSafariPath):
3117         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
3118         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
3119         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
3120         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
3121         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
3122         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
3123         * Scripts/webkitperl/features.pm:
3124         * Scripts/webkitperl/httpd.pm:
3125         * Scripts/webkitpy/bindings/main.py:
3126         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
3127         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3128         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3129         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3130         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
3131         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
3132         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
3133         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3134         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
3135         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h:
3136         * WebKitTestRunner/PixelDumpSupport.cpp:
3137         * WebKitTestRunner/PixelDumpSupport.h:
3138         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3139         * WinLauncher/WinLauncher.cpp:
3140         * WinLauncher/WinLauncher.h:
3141         * WinLauncher/stdafx.cpp:
3142         * WinLauncher/stdafx.h:
3143
3144 2014-03-14  Filip Pizlo  <fpizlo@apple.com>
3145
3146         Sometimes we need to be explicit about the SDK when running ranlib on Darwin
3147         https://bugs.webkit.org/show_bug.cgi?id=130265
3148
3149         Reviewed by Michael Saboff.
3150
3151         * Scripts/build-webkit:
3152         * Scripts/copy-webkitlibraries-to-product-directory:
3153
3154 2014-03-14  Landry Breuil  <landry@openbsd.org>
3155
3156         Recognize openbsd/netbsd and am64 archs in Tools/Scripts.
3157         Also allow to set MAKE in the environment.
3158         https://bugs.webkit.org/show_bug.cgi?id=129991
3159
3160         Reviewed by Andreas Kling.
3161
3162         * Scripts/webkitdirs.pm:
3163         (determineArchitecture):
3164         (determineNumberOfCPUs):
3165         (isBSD):
3166         (buildAutotoolsProject):
3167         * Scripts/webkitpy/common/system/platforminfo.py:
3168         (PlatformInfo.__init__):
3169         (PlatformInfo.is_openbsd):
3170         (PlatformInfo):
3171         (PlatformInfo.is_netbsd):
3172         (PlatformInfo._determine_os_name):
3173
3174 2014-03-14  Dean Jackson  <dino@apple.com>
3175
3176         Remove libWebKitSystemInterfaceLion.a
3177         https://bugs.webkit.org/show_bug.cgi?id=130254
3178
3179         Reviewed by Geoffrey Garen and Andreas Kling.
3180
3181         No need to copy the Lion libraries into the build.
3182
3183         * Scripts/copy-webkitlibraries-to-product-directory:
3184
3185 2014-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3186
3187         [EFL][MiniBrowser] Revise help messages of command line parameters
3188         https://bugs.webkit.org/show_bug.cgi?id=130222
3189
3190         Reviewed by Csaba Osztrogonác.
3191
3192         Correct the default value description and make help messages to be consistent.
3193
3194         * MiniBrowser/efl/main.c:
3195
3196 2014-03-12  Sergio Villar Senin  <svillar@igalia.com>
3197
3198         Rename DEFINE_STATIC_LOCAL to DEPRECATED_DEFINE_STATIC_LOCAL
3199         https://bugs.webkit.org/show_bug.cgi?id=129612
3200
3201         Reviewed by Darin Adler.
3202
3203         For new code use static NeverDestroyed<T> instead.
3204
3205         * DumpRenderTree/JavaScriptThreading.cpp:
3206         (javaScriptThreadsMutex):
3207         (javaScriptThreads):
3208         * DumpRenderTree/efl/EventSender.cpp:
3209         (touchPointList):
3210         (delayedEventQueue):
3211         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3212         (delegatesWithDelayedWork):
3213         * Scripts/check-for-exit-time-destructors:
3214         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
3215         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
3216         (testsMap):
3217
3218 2014-03-13  Sanghyup Lee  <sh53.lee@samsung.com>
3219
3220         [EFL][WK2] Fix compilation warning in Minibrowser
3221         https://bugs.webkit.org/show_bug.cgi?id=130132
3222
3223         Reviewed by Csaba Osztrogonác.
3224
3225         Replace mktemp() with mkstemp() to fix compilation warning in MiniBrowser.
3226
3227         * MiniBrowser/efl/main.c:
3228         (on_download_request):
3229
3230 2014-03-13  Filip Pizlo  <fpizlo@apple.com>
3231
3232         FTL should support IsBlah
3233         https://bugs.webkit.org/show_bug.cgi?id=130202
3234
3235         Reviewed by Geoffrey Garen.
3236         
3237         Running existing JSRegress tests with noInline gives us coverage for these
3238         changes. Chances are, this will also give coverage for other interesting things
3239         as well.
3240
3241         * Scripts/run-jsc-stress-tests:
3242
3243 2014-03-12  Brian Burg  <bburg@apple.com>
3244
3245         Web Inspector: Remove unused callId parameter from evaluateInWebInspector
3246         https://bugs.webkit.org/show_bug.cgi?id=129744
3247
3248         Reviewed by Timothy Hatcher.
3249
3250         * DumpRenderTree/TestRunner.cpp:
3251         (evaluateInWebInspectorCallback):
3252         * DumpRenderTree/TestRunner.h:
3253         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3254         (TestRunner::evaluateInWebInspector):
3255         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3256         (TestRunner::evaluateInWebInspector):
3257         * DumpRenderTree/mac/TestRunnerMac.mm:
3258         (TestRunner::evaluateInWebInspector):
3259         * DumpRenderTree/win/TestRunnerWin.cpp:
3260         (TestRunner::evaluateInWebInspector):
3261         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3262         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3263         (WTR::TestRunner::evaluateInWebInspector):
3264         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3265
3266 2014-03-13  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
3267
3268         [GTK] build-webkit shouldn't show error message when ninja isn't installed
3269         https://bugs.webkit.org/show_bug.cgi?id=130129
3270
3271         Reviewed by Csaba Osztrogonác.
3272
3273         * Scripts/webkitdirs.pm:
3274         (canUseNinja): Redirecting stderr to /dev/null
3275
3276 2014-03-13  Andres Gomez  <agomez@igalia.com>
3277
3278         [GTK] "Tools/jhbuild/jhbuild-wrapper --gtk" build fails even after running Tools/gtk/install-dependencies due to missing proper libxml2 python bindings
3279         https://bugs.webkit.org/show_bug.cgi?id=130092
3280
3281         Reviewed by Csaba Osztrogonác.
3282
3283         Added "python-dev" as dependency for deb based distros. It is
3284         already present for rpm based distros. This dependency will allow
3285         libxml2 to generate its python bindings, needed by gtk-doc.
3286
3287         * gtk/install-dependencies:
3288
3289 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3290
3291         Unreviewed. Fix GTK+ cmake build after r165488.
3292
3293         * MiniBrowser/gtk/CMakeLists.txt: Add CMAKE_BINARY_DIR to include dirs.
3294
3295 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3296
3297         [GTK][CMAKE] Remove compile warnings about GTK+ deprecated API
3298         https://bugs.webkit.org/show_bug.cgi?id=130014
3299
3300         Reviewed by Martin Robinson.
3301
3302         Include cmake or autotools config header.
3303
3304         * MiniBrowser/gtk/BrowserDownloadsBar.c:
3305         * MiniBrowser/gtk/BrowserSearchBar.c:
3306         * MiniBrowser/gtk/BrowserWindow.c:
3307         * MiniBrowser/gtk/main.c:
3308
3309 2014-03-12  Commit Queue  <commit-queue@webkit.org>
3310
3311         Unreviewed, rolling out r165471.
3312         https://bugs.webkit.org/show_bug.cgi?id=130139
3313
3314         Didn't really fix the issue and broke another bot (Requested
3315         by mrobinson on #webkit).
3316
3317         Reverted changeset:
3318
3319         "[CMake] Newer versions of CMake cannot find older versions of
3320         Freetype"
3321         https://bugs.webkit.org/show_bug.cgi?id=130107
3322         http://trac.webkit.org/changeset/165471
3323
3324 2014-03-11  Filip Pizlo  <fpizlo@apple.com>
3325
3326         It should be possible to build WebKit with FTL on iOS
3327         https://bugs.webkit.org/show_bug.cgi?id=130116
3328
3329         Reviewed by Dan Bernstein.
3330
3331         * Scripts/build-webkit:
3332         * Scripts/copy-webkitlibraries-to-product-directory:
3333
3334 2014-03-12  Brent Fulgham  <bfulgham@apple.com>
3335
3336         [Win] Remove use of QTSDK
3337         https://bugs.webkit.org/show_bug.cgi?id=130049
3338
3339         Reviewed by Darin Adler.
3340
3341         * DumpRenderTree/win/DumpRenderTree.cpp:
3342         (initialize): Remove QuickTime code.
3343         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't grab logs from
3344         building QTMovieWin.
3345
3346 2014-03-12  Martin Robinson  <mrobinson@igalia.com>
3347
3348         [GTK][CMAKE] Too verbose build output
3349         https://bugs.webkit.org/show_bug.cgi?id=130076
3350
3351         Reviewed by Carlos Garcia Campos.
3352
3353         Instead of building with cmake --build which isn't smart about pretty printing and
3354         colors, we build with a script which calls the proper build command.
3355
3356         * Scripts/webkitdirs.pm:
3357         (buildCMakeGeneratedProject): For GTK+ call the script that we generate during
3358         the CMake configuration pass.
3359
3360 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
3361
3362         [CMake] Newer versions of CMake cannot find older versions of Freetype
3363         https://bugs.webkit.org/show_bug.cgi?id=130107
3364
3365         Reviewed by Gustavo Noronha Silva.
3366
3367         * gtk/jhbuildrc: Work around a bug in newer CMakes by giving the FREETYPE_DIR hint
3368         to CMake during jhbuild initialization.
3369
3370 2014-03-12  Zalan Bujtas  <zalan@apple.com>
3371
3372         Add hiDPI support for compositing content in DumpRenderTree/WebKitTestRunner
3373         https://bugs.webkit.org/show_bug.cgi?id=129961
3374
3375         Reviewed by Simon Fraser.
3376
3377         Now scaled content can go through the window capturing mechanism too for compositing content.
3378         AppleMagnifiedMode is redundant.
3379
3380         * DumpRenderTree/mac/DumpRenderTree.mm:
3381         (setDefaultsToConsistentValuesForTesting):
3382         (runTest):
3383         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3384         (createBitmapContextFromWebView):
3385         * WebKitTestRunner/PlatformWebView.h:
3386         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3387         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3388         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3389         (WTR::PlatformWebView::didInitializeClients):
3390         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3391         (WTR::PlatformWebView::forceWindowFramesChanged):
3392         * WebKitTestRunner/mac/main.mm:
3393         (setDefaultsToConsistentValuesForTesting):
3394
3395 2014-03-12  Anton Obzhirov  <a.obzhirov@samsung.com>
3396
3397         Unreviewed. Add myself as a committer.
3398
3399         * Scripts/webkitpy/common/config/contributors.json:
3400
3401 2014-03-12  Ryuan Choi  <ryuan.choi@samsung.com>
3402
3403         Unreviewed build fix on the EFL port when used lower version of ATK
3404
3405         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3406         (WTR::AccessibilityUIElement::y): Fixed typo.
3407
3408 2014-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
3409
3410         Some images are blank in the rebaseline server UI
3411         https://bugs.webkit.org/show_bug.cgi?id=130104
3412
3413         Reviewed by Tim Horton.
3414
3415         Let the server check for images in the 'retries' directory
3416         if it can't find an image otherwise.
3417
3418         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3419         (RebaselineHTTPRequestHandler.test_result):
3420
3421 2014-03-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3422
3423         [GTK][CMake] --update-gtk has no effect
3424         https://bugs.webkit.org/show_bug.cgi?id=130088
3425
3426         Reviewed by Philippe Normand.
3427
3428         * Scripts/webkitdirs.pm:
3429         (buildCMakeProjectOrExit): call update-webkitgtk-libs if --update-gtk has been passed
3430         as an argument.
3431
3432 2014-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
3433
3434         Add "System Font" to the list of whitelisted DRT fonts
3435         https://bugs.webkit.org/show_bug.cgi?id=130046
3436
3437         Reviewed by Darin Adler.
3438
3439         * DumpRenderTree/mac/DumpRenderTree.mm:
3440         (allowedFontFamilySet):
3441         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3442
3443 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
3444
3445         [GTK] The jhbuild environment should set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_PATH
3446         https://bugs.webkit.org/show_bug.cgi?id=130064
3447
3448         Reviewed by Philippe Normand.
3449
3450         * efl/jhbuildrc: Remove duplicated code.
3451         * gtk/jhbuildrc: Remove duplicated code.
3452         * jhbuild/jhbuildrc_common.py:
3453         (init): Move duplicated code from jhbuildrc's and extend setting CMake environment variables to
3454         GTK+. We always set the CMAKE_LIBRARY_PATH, which should be harmless for EFL 32-bit systems.
3455         and is apparently necessary for GTK+.
3456
3457 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
3458
3459         check-webkit-style failed to complain about missing braces
3460         https://bugs.webkit.org/show_bug.cgi?id=34189
3461
3462         Reviewed by Ryosuke Niwa.
3463
3464         * Scripts/webkitpy/style/checkers/cpp.py:
3465         (check_braces):
3466         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3467         (WebKitStyleTest.test_braces):
3468
3469 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
3470
3471         Remove Qt cruft from style checker.
3472         https://bugs.webkit.org/show_bug.cgi?id=130085
3473
3474         Reviewed by Csaba Osztrogonác.
3475
3476         There is no 'foreach' keyword in c++. That was a Qt feature
3477         added in: http://trac.webkit.org/changeset/46113
3478         Qt was removed from WebKit, so we should remove the checks
3479         of this keyword from check-webkit-style scripts.
3480
3481         * Scripts/webkitpy/style/checkers/cpp.py:
3482         (check_spacing_for_function_call):
3483         (check_spacing):
3484         (check_braces):
3485         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3486         (CppStyleTest.test_mismatching_spaces_in_parens):
3487         (CppStyleTest.test_spacing_for_fncall):
3488         (WebKitStyleTest.test_braces):
3489
3490 2014-03-11  Martin Hodovan  <mhodovan@inf.u-szeged.hu>
3491
3492         [GTK] update-webkitgtk-libs needs itstool
3493         https://bugs.webkit.org/show_bug.cgi?id=130082
3494
3495         After http://trac.webkit.org/changeset/165110 WebKitGTK+ uses gtk-doc 1.20.
3496         itstool is a dependency of building gtk-doc from version 1.19, so it should
3497         be added to Tools/gtk/install-dependencies script, too.
3498
3499         Reviewed by Philippe Normand.
3500
3501         * gtk/install-dependencies:
3502
3503 2014-03-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3504
3505         webkitbot rollout ChangeLogs should be nicer
3506         https://bugs.webkit.org/show_bug.cgi?id=122654
3507
3508         Reviewed by Csaba Osztrogonác.
3509
3510         Added bug urls and descriptions of rolled out patches to the rollout changelog
3511         if they are present in the original changelog. Additionally removed the list of
3512         changed files and functions.
3513
3514         * Scripts/webkitpy/common/checkout/changelog.py:
3515         (ChangeLog.update_with_unreviewed_message): Cut off the list of modified files.
3516         * Scripts/webkitpy/common/checkout/checkout.py:
3517         (Checkout._changelog_data_for_revision): Store bug description.
3518         * Scripts/webkitpy/common/checkout/checkout_mock.py:
3519         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3520         (CheckoutTest.test_commit_info_for_revision):
3521         * Scripts/webkitpy/common/checkout/commitinfo.py:
3522         (CommitInfo.bug_description): Added.
3523         (CommitInfo.to_json):
3524         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
3525         (CommitInfoTest.test_commit_info_creation):
3526         * Scripts/webkitpy/tool/commands/download.py:
3527         (AbstractRolloutPrepCommand._prepare_state): Store bug ids and descriptions of rolled
3528         out patches for creating rollout changelog.
3529         (CreateRollout._prepare_state): Remove obsolete comments and code, the bug id that
3530         caused the regression is stored in state["bug_blocked"] now.
3531         * Scripts/webkitpy/tool/commands/download_unittest.py:
3532         (test_prepare_rollout):
3533         (test_create_rollout_multiple_revision):
3534         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3535         (PrepareChangeLogForRevert._message_for_revert): Add bug urls and descriptions of
3536         rolled out patches to the changelog.
3537         (PrepareChangeLogForRevert.run):
3538         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
3539         (UpdateChangeLogsForRevertTest):
3540         (test_message_for_revert):
3541         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
3542         (ReopenBugAfterRollout.run):
3543
3544 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
3545
3546         [ATK] Adjust WKTR/DRT to use new API from ATK 2.11.90
3547         https://bugs.webkit.org/show_bug.cgi?id=130021
3548
3549         Reviewed by Mario Sanchez Prada.
3550
3551         Replace deprecated functions to use new API from ATK 2.11.90.
3552
3553         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3554         (AccessibilityUIElement::x):
3555         (AccessibilityUIElement::y):
3556         (AccessibilityUIElement::width):
3557         (AccessibilityUIElement::height):
3558         (AccessibilityUIElement::clickPointX):
3559         (AccessibilityUIElement::clickPointY):
3560         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3561         (WTR::AccessibilityUIElement::x):
3562         (WTR::AccessibilityUIElement::y):
3563         (WTR::AccessibilityUIElement::width):
3564         (WTR::AccessibilityUIElement::height):
3565         (WTR::AccessibilityUIElement::clickPointX):
3566         (WTR::AccessibilityUIElement::clickPointY):
3567
3568 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
3569
3570         [ATK] Expose aria-posinset and aria-setsize through object attributes
3571         https://bugs.webkit.org/show_bug.cgi?id=130011
3572
3573         Reviewed by Chris Fleizach.
3574
3575         Added missing implementation of numberAttributeValue both to WKTR and DRT.
3576
3577         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3578         (AccessibilityUIElement::numberAttributeValue):
3579         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3580         (WTR::AccessibilityUIElement::numberAttributeValue):
3581
3582 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
3583
3584         [Win] Unreviewed build fix.
3585
3586         Some bad Windows code was committed at some point that prevents the Apple Windows port
3587         from finding its runtime dependencies reliably.
3588
3589         * win/DLLLauncher/DLLLauncherMain.cpp:
3590         (appleApplicationSupportDirectory): Restored this function.
3591         (modifyPath): Update to use appleApplicationSupportDirectory function.
3592
3593 2014-03-10  Zoltan Horvath  <zoltan@webkit.org>
3594
3595         Let the user define the full address of the performance-site-server for uploading results
3596         https://bugs.webkit.org/show_bug.cgi?id=129819
3597
3598         Reviewed by Ryosuke Niwa.
3599
3600         Currently perftestsrunner.py assumes that the server uses https protocol all the time, which
3601         can be confusing. It's more straightforward, if you need to define explicitly the server's full
3602         address along with the protocol, when you're using this parameter. I added HTTPS as the default
3603         protocol for now, in order to avoid breaking the perf bots.
3604
3605         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3606         (_upload_json):
3607         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3608         (MainTest.test_upload_json):
3609
3610 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
3611
3612         [Win] Pass environment to Pre-Build, Pre-Link, and Post-Build Stages.
3613         https://bugs.webkit.org/show_bug.cgi?id=130023
3614
3615         Reviewed by Dean Jackson.
3616
3617         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add missing
3618         /SAFESEH flag to DLL launcher process.
3619
3620 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
3621
3622         RunGtkWebKitGObjectDOMBindingsAPIBreakTests should be added to the BuildAndTestFactory not the TestFactory
3623         https://bugs.webkit.org/show_bug.cgi?id=129980
3624
3625         Reviewed by Carlos Garcia Campos.
3626
3627         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add RunGtkWebKitGObjectDOMBindingsAPIBreakTests to the correct factory.
3628
3629 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
3630
3631         [GTK] Remove the WebView source-mode WebKit1 test
3632         https://bugs.webkit.org/show_bug.cgi?id=129976
3633
3634         Reviewed by Carlos Garcia Campos.
3635
3636         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Remove the source-mode test.
3637
3638 2014-03-08  Martin Robinson  <mrobinson@igalia.com>
3639
3640         Unreviewed build fix for GTKbuild after the switch to CMake
3641
3642         * gtk/common.py:
3643         (is_cmake_build): Like r165284, we need to assume CMake by default, since the
3644         test-only bot doesn't have any build files.
3645
3646 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
3647
3648         [GTK] built-product-archive does not handle GTK+ CMake build
3649         https://bugs.webkit.org/show_bug.cgi?id=129941
3650
3651         * BuildSlaveSupport/built-product-archive:
3652         (archiveBuiltProduct): Fix the build by adding support to built-product-archive for
3653         the CMake build.
3654
3655 2014-03-07  Lorenzo Tilve  <ltilve@igalia.com>
3656
3657         [GTK] Include CMake into install-dependencies script
3658         https://bugs.webkit.org/show_bug.cgi?id=129909
3659
3660         Reviewed by Martin Robinson.
3661
3662         As since r165267 buid-webkit uses CMake by default, the dependency
3663         with 'cmake' package should be introduced.
3664
3665         * gtk/install-dependencies: Ditto.
3666
3667 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
3668
3669         REGRESSION(165267): Broke a webkitpy unit tests
3670         https://bugs.webkit.org/show_bug.cgi?id=129904
3671
3672         Reviewed by Jon Honeycutt.
3673
3674         * Scripts/webkitpy/port/gtk.py: Flip the default test to assume CMake by default.